Fix parallel builds on Windows in lib-src.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
55a6cca6
EZ
12012-07-29 Eli Zaretskii <eliz@gnu.org>
2
3 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
4
dbcf001c
DA
52012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
6
7 Cleanup statistics calculation in Fgarbage_collect.
8 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
9 zombies percentage calculation. Simplify elapsed time calculation.
10
e2688e4a
DA
112012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
12
13 Generalize marker debugging code under MARKER_DEBUG and use eassert.
14 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
15 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
16 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
17 (replace_range, replace_range_2, del_range_2): Change to eassert.
18 * marker.c (byte_char_debug_check): Adjust style.
19
b46a6a83
PE
202012-07-29 Paul Eggert <eggert@cs.ucla.edu>
21
22 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
23 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
24 long-ago-commented-out code that talks about "WIN32".
25 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
26 All uses changed.
27
e32a5799
PE
282012-07-28 Paul Eggert <eggert@cs.ucla.edu>
29
30 Use Gnulib stdalign module (Bug#9772, Bug#9960).
31 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
32 Simplify by using alignof.
33 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
34 * lisp.h: Include <stdalign.h>.
35 (GCALIGNMENT): New macro and constant.
36 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
37 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
38 (stdalign): New macro, if not already defined.
39
df81cd29
EZ
402012-07-28 Eli Zaretskii <eliz@gnu.org>
41
01bd1b0d
EZ
42 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
43 * w32inevt.c: Include w32inevt.h.
44 (w32_read_console_input): New inline function, calls either
45 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
46 w32_console_unicode_input.
47 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
48 (w32_kbd_patch_key, key_event): Use the codepage returned by
49 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
50 (key_event): use uChar.UnicodeChar only if
51 w32_console_unicode_input is non-zero.
52
53 * w32console.c: Include w32heap.h.
54 <w32_console_unicode_input>: New global variable.
55 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
56 family of Windows, zero otherwise.
57
58 * w32inevt.h: Declare w32_console_unicode_input.
59
df81cd29
EZ
60 * xdisp.c (init_iterator): Don't reference tip_frame in a build
61 --without-x. (Bug#11742)
62
c20fdd9e
PE
632012-07-27 Paul Eggert <eggert@cs.ucla.edu>
64
65 Adjust GDB to reflect pvec_type changes (Bug#12036).
66 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
67 2012-07-04 changes to pseudovector representation. Problem
68 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
69
32770973 702012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
71
72 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
73 bus address.
74 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
75
3438fe21
EZ
762012-07-27 Eli Zaretskii <eliz@gnu.org>
77
bcfbc9de
EZ
78 * alloc.c (listn): Fix the order the arguments are consed onto the
79 list.
80
3438fe21
EZ
81 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
82 enumeration constants, as PURE and HEAP are too general, and clash
83 with other headers and sources, such as gmalloc.c and the
84 MS-Windows system headers. All users changed.
85
eeaea515
DA
862012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Revert last save_excursion_save and save_excursion_restore changes.
89 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
90 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
91
073c88c2
DA
922012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
93
94 Fix recently-introduced typos in Windows port.
95 Reported by Martin Rudalics <rudalics@gmx.at>.
96 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 97 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 98
4706125e
PE
992012-07-27 Paul Eggert <eggert@cs.ucla.edu>
100
101 Improve GDB symbol export (Bug#12036).
102 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
103 arms of an 'if', not using conditional expressions; otherwise GDB
104 complains about the types in the unevaluated arm when the argument
105 is an integer literal.
106 (xgetint): Simplify expression.
107 * alloc.c (gdb_make_enums_visible): New constant. This ports to
108 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
109 Zaretskii in <http://bugs.gnu.org/12036#13>.
110 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
111 needed now that we have gdb_make_enums_visible.
112 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
113 (enum enum_USE_LSB_TAG):
114 New enum types, packaging up enums that need to be exported to GDB.
115
694b6c97
DA
1162012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
117
118 Utility function to make a list from specified amount of objects.
119 * lisp.h (enum constype): New datatype.
120 (listn): New prototype.
121 * alloc.c (listn): New function.
122 (Fmemory_use_count, syms_of_alloc): Use it.
123 * buffer.c (syms_of_buffer): Likewise.
124 * callint.c (syms_of_callint): Likewise.
125 * charset.c (define_charset_internal): Likewise.
126 * coding.c (syms_of_coding): Likewise.
127 * keymap.c (syms_of_keymap): Likewise.
128 * search.c (syms_of_search): Likewise.
129 * syntax.c (syms_of_syntax): Likewise.
130 * w32.c (init_environment): Likewise.
131 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
132 * xdisp.c (syms_of_xdisp): Likewise.
133 * xfns.c (syms_of_xfns): Likewise.
134
6195f384
DA
1352012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
136
137 Fast save_excursion_save and save_excursion_restore.
138 * lisp.h (struct Lisp_Excursion): New data type.
139 (PVEC_EXCURSION): New pseudovector type.
140 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
141 to deal with it. Adjust comments.
142 (init_marker, attach_marker): New prototype.
143 (unchain_marker): Adjust prototype.
144 * marker.c (attach_marker): Change to global.
145 (init_marker): New function.
146 * alloc.c (Fmake_marker, build_marker): Use it.
147 (build_marker): More easserts.
148 (mark_object): Handle struct Lisp_Excursion.
149 * editfns.c (save_excursion_save, save_excursion_restore):
150 Reimplement to use struct Lisp_Excursion. Add comments.
151
5eceb8fb
PE
1522012-07-26 Paul Eggert <eggert@cs.ucla.edu>
153
154 Fix export of symbols to GDB (Bug#12036).
155 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
156 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
157 emacs.c, as this is a more-suitable home. Had this been done earlier
158 the fix for 12036 would have avoided some of the problems noted in
159 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
160 would have been more obvious.
562157c8
PE
161 * emacs.c: Do not include <verify.h>; no longer needed.
162 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
163 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
164 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
165 Remove; now done in lisp.h.
166 * lisp.h (PUBLISH_TO_GDB): New macro.
167 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
168 (DATA_SEG_BITS): Use it.
169 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
170 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
171 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
172 not be usable in #if. This simplifies things.
173
d6749401
JB
1742012-07-26 Juanma Barranquero <lekktu@gmail.com>
175
176 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
177
1781b9e9
PE
1782012-07-26 Paul Eggert <eggert@cs.ucla.edu>
179
d89518db 180 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
181 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
182 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
183 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
184 Adjust to changes in lisp.h and emacs.c, by using
185 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
186 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
187 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
188 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
189 instead of gdb_valbits.
190 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
191 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
192 instead of gdb_array_mark_flag.
193 (xboolvector): Get size from $->size, not $->header.size.
194 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
195 (xreload, hook-run, hookpost-run): Remove.
196 * emacs.c: Include <verify.h>.
197 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
198 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
199 Remove.
200 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
201 (gdb_USE_LSB_TAG): New enum constants.
202 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
203 Also define these as enum constants, so they're visible to GDB.
204 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
205 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
206 as constants, so they're visible to GDB.
207 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
208 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
209 Now enum constants, not macros, so they're visible to GDB.
210 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
211 more convenient now. All uses changed.
212 (VALMASK) [USE_LSB_TAG]: Also define in this case.
213 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
214
3628596a
DA
2152012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
216
217 Explicitly free restriction data that are not needed anymore.
218 * editfns.c (save_restriction_restore): Free restriction data.
219
7abaf5cc
SM
2202012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
221
222 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
223 add argument, tune behavior, and adjust all callers.
224
71f88e00
PE
2252012-07-25 Paul Eggert <eggert@cs.ucla.edu>
226
227 Use typedef for EMACS_INT, EMACS_UINT.
228 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
229 than macros. This simplifies debugging in the usual case, since
230 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
231 and it allows expressions involving EMACS_INT casts.
232 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
233
57ec3034
JD
2342012-07-25 Jan Djärv <jan.h.d@swipnet.se>
235
236 * nsterm.m (ns_read_socket): Return early if there is a modal
237 window (Bug#12043).
238
8137e7b3
MR
2392012-07-25 Martin Rudalics <rudalics@gmx.at>
240
241 * frame.c (Fredirect_frame_focus): In doc-string don't mention
242 that FOCUS-FRAME can be omitted.
243
04e9897c
DA
2442012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
245
246 Adjust buffer text indirection counters at the end of Fkill_buffer.
247 * buffer.c (Fkill_buffer): Adjust indirection counters when the
248 buffer is definitely dead. This should really fix an issue reported
249 by Christoph Scholtes again. (Bug#12007).
250 (init_buffer_once): Initialize indirection counters of
251 buffer_defaults and buffer_local_symbols (for sanity and safety).
252
8a0484e1
EZ
2532012-07-24 Eli Zaretskii <eliz@gnu.org>
254
255 * xdisp.c (init_iterator): Don't compute dimensions of truncation
256 and continuation glyphs on tooltip frames, leave them at zero.
257 Avoids continued lines in tooltips. (Bug#11832)
258
fa691a83
DA
2592012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
260
261 Simplify copy_overlay.
04e9897c 262 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
263 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
264
436bc8e0
EZ
2652012-07-23 Eli Zaretskii <eliz@gnu.org>
266
267 * print.c (print_object): Don't crash when a frame's name is nil
268 or invalid. (Bug#12025)
269
270 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
271 it signals an error when a tooltip frame is being created.
272
d7a7fda3
DA
2732012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
274
275 Cleanup miscellaneous objects allocation and initialization.
276 * alloc.c (allocate_misc): Change to static. Add argument to
277 specify the subtype. Adjust comment and users.
278 (build_overlay): New function.
279 * buffer.c (copy_overlays, Fmake_overlay): Use it.
280 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
281 (allocate_misc): Remove prototype.
282 (build_overlay): Add prototype.
283
2842012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
285
286 Swap buffer text indirection counters in Fbuffer_swap_text.
287 * buffer.c (Fbuffer_swap_text): Swap indirections too.
288 This avoids crash reported by Christoph Scholtes at
289 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
290
9d7fa573
JD
2912012-07-22 Jan Djärv <jan.h.d@swipnet.se>
292
293 * nsmenu.m (Popdown_data): New struct.
294 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
295 free Popdown_data.
296 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
297 (initWithContentRect): Make imgView and contentView non-static
298 and autorelease them. Also autorelease img and matrix (Bug#12005).
299 (dealloc): Remove (Bug#12005).
300
0dd6d66d
DA
3012012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
302
303 Adjust consing_since_gc when objects are explicitly freed.
304 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
305 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
306 (free_cons, free_misc): Subtract object size from consing_since_gc.
307
d36d71df
DA
3082012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
309
310 Simplify and cleanup markers positioning code.
311 * marker.c (attach_marker): More useful eassert.
312 (live_buffer, set_marker_internal): New function.
313 (Fset_marker, set_marker_restricted): Use set_marker_internal.
314 (set_marker_both, set_marker_restricted_both): Use live_buffer.
315
fb9ea40f
PE
3162012-07-22 Paul Eggert <eggert@cs.ucla.edu>
317
318 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
319 as it's limited by the amount of memory, not by INT_MAX.
320
2d5c5f7d
EZ
3212012-07-21 Eli Zaretskii <eliz@gnu.org>
322
07fb592e
EZ
323 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
324 in special-event-map. See the discussion at
325 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
326 for the reasons.
327
37a9eac8 328 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
329 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
330 Fabrice Popineau <fabrice.popineau@supelec.fr>.
331
c4328746
JD
3322012-07-21 Jan Djärv <jan.h.d@swipnet.se>
333
334 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 335 (conversationIdentifier): Return value is NSInteger.
784051c4 336 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 337
6e5d1c12
CY
3382012-07-21 Chong Yidong <cyd@gnu.org>
339
340 * window.c (decode_any_window): Signal an error if the window is
341 on a dead frame (Bug#11984).
342
9928463d
DA
3432012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
344
345 Add indirection counting to speed up Fkill_buffer.
346 * buffer.h (struct buffer): New member.
347 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
348 (Fmake_indirect_buffer): Set indirection counter to -1, increment
349 base buffer indirection counter.
350 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
351 (Fkill_buffer): Adjust indirection counters as needed, don't walk
352 through buffer list if indirection counter is 0.
353
f8643a6b
DA
3542012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
355
356 Extend the value returned by Fgarbage_collect with heap statistics.
357 * alloc.c (Qheap): New symbol.
358 (syms_of_alloc): DEFSYM it.
359 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
360 (Fmemory_free): Remove.
361 (syms_of_alloc): Don't defsubr it.
362 * buffer.c (Fcompact_buffer): Remove.
363 (syms_of_buffer): Don't defsubr it.
364
dac616ff
DA
3652012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
366
367 Make maybe_gc inline.
368 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
369 * lisp.h (consing_since_gc, gc_relative_threshold)
370 (memory_full_cons_threshold): Revert declaration.
371 (maybe_gc): Remove prototype, define as inline.
372 * alloc.c: Remove old commented-out code.
373 (consing_since_gc, gc_relative_threshold)
374 (memory_full_cons_threshold): Revert to global.
375 (maybe_gc): Remove.
376
d7ea76b4
DA
3772012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
378
379 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
380 * lisp.h (build_unibyte_string): New function.
381 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
382 * sysdep.c, w32fns.c, xfns.c: Use it.
383 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
384 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
385 Adjust users accordingly.
386 * font.h (font_open_by_name): Adjust prototype.
387
765e61e3
DA
3882012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
389
390 Cleanup calls to Fgarbage_collect.
391 * lisp.h (maybe_gc): New prototype.
392 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
393 Remove declarations.
394 * alloc.c (maybe_gc): New function.
395 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
396 Make them static.
397 * bytecode.c (MAYBE_GC): Use maybe_gc.
398 * eval.c (eval_sub, Ffuncall): Likewise.
399 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
400 to avoid dependency from auto-save feature.
401
52b852c7
PE
4022012-07-19 Paul Eggert <eggert@cs.ucla.edu>
403
404 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
405 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
406 'for_each_per_buffer_object_at'.
407 All uses changed. It's better to use upper-case for macros that
408 cannot be implemented as functions, to give the reader a clue
409 that they're special.
410
5db81e33
SM
4112012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
412
413 * alloc.c (Fgarbage_collect): Tweak docstring.
414
5b835e1d
DA
4152012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Tweak the value returned from Fgarbage_collect again.
418 * alloc.c (Fgarbage_collect): New return value, as confirmed in
419 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
420 Adjust documentation.
421 (total_vector_bytes): Rename to total_vector_slots, adjust
422 accounting.
423 (total_free_vector_bytes): Rename to total_free_vector_slots,
424 adjust accounting.
425 (Qstring_bytes, Qvector_slots): New symbols.
426 (syms_of_alloc): DEFSYM them.
427
9cd47b72
DA
4282012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
429
430 Buffer compaction primitive which may be used from Lisp.
431 * buffer.c (compact_buffer, Fcompact_buffer): New function.
432 (syms_of_buffer): Register Fcompact_buffer.
433 * alloc.c (Fgarbage_collect): Use compact_buffer.
434 * buffer.h (compact_buffer): New prototype.
435 (struct buffer_text): New member.
436
d17337e5
DA
4372012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
438
439 New macro to iterate over all buffers, miscellaneous cleanups.
440 * lisp.h (all_buffers): Remove declaration.
441 * buffer.h (all_buffers): Add declaration, with comment.
442 (for_each_buffer): New macro.
443 * alloc.c (Fgarbage_collect, mark_object): Use it.
444 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
445 (init_buffer): Likewise.
446 * data.c (Fset_default): Likewise.
447 * coding.c (code_conversion_restore): Remove redundant check
448 for dead buffer.
449 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
450
60cfd278
AS
4512012-07-18 Andreas Schwab <schwab@linux-m68k.org>
452
453 Fix bug that created negative-length intervals.
454 * intervals.c (merge_interval_right, merge_interval_left):
455 Do not zero out this interval if it is absorbed by its children,
456 as this interval's total length doesn't change in that case. See
457 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
458
d06714cb
PE
4592012-07-18 Paul Eggert <eggert@cs.ucla.edu>
460
83713154
PE
461 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
462 when invoking (make-bool-vector N t) and N is a positive
463 multiple of 8 -- the last 8 bits were mistakenly cleared.
464
d06714cb
PE
465 Remove some struct layout assumptions in bool vectors.
466 * alloc.c (bool_header_size): New constant.
467 (header_size, word_size): Move earlier, as they're now used earlier.
468 Use 'word_size' in a few more places, where it's appropriate.
469 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
470 padding before the data member of a bool vector.
471 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
472 than doing the check by hand with an abort ().
473
464d5a5e
SM
4742012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
475
5fbc0409
SM
476 * eval.c (Fdefvar): Don't check constants since we only set the var if
477 it's not yet defined anyway (bug#11904).
478
464d5a5e
SM
479 * lisp.h (last_undo_boundary): Declare new var.
480 * keyboard.c (command_loop_1): Set it.
481 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
482 were auto-added by the command loop (bug#11774).
483
8dc2e44a
AS
4842012-07-18 Andreas Schwab <schwab@linux-m68k.org>
485
486 * w32font.c (Qsymbol): Remove local definition.
487 (syms_of_w32font): Don't DEFSYM it.
488
169925ec
DA
4892012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
490
491 Fix sweep_vectors to handle large bool vectors correctly.
492 * alloc.c (sweep_vectors): Account total_vector_bytes for
493 bool vectors larger than VBLOCK_BYTES_MAX.
494
5fbfb018
CY
4952012-07-18 Chong Yidong <cyd@gnu.org>
496
497 * frame.c (x_set_frame_parameters): Revert bogus change introduced
498 in 2012-05-25 commit by Paul Eggert (Bug#11738).
499
3ab6e069
DA
5002012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
501
502 Return more descriptive data from Fgarbage_collect.
503 Suggested by Stefan Monnier in
504 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
505 * alloc.c (bounded_number): New function.
506 (total_buffers, total_vectors): New variable.
507 (total_string_size): Rename to total_string_bytes, adjust users.
508 (total_vector_size): Rename to total_vector_bytes, adjust users.
509 (sweep_vectors): Account total_vectors and total_vector_bytes.
510 (Fgarbage_collect): New return value. Adjust documentation.
511 (gc_sweep): Account total_buffers.
512 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
513 (VECTOR_SIZE): Remove.
514 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
515 (Qinterval, Qmisc): New symbols.
516 (syms_of_data): Initialize them.
517 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
518 (Qcons, Qbuffer): New declarations.
519
6d02fe5b
PE
5202012-07-17 Paul Eggert <eggert@cs.ucla.edu>
521
522 * alloc.c (Fmemory_free): Account for memory-free's own storage.
523 Round up, not down. Improve doc.
524
b7ffe040
DA
5252012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
526
527 Restore old code in allocate_string_data to avoid Faset breakage.
528 Reported by Julien Danjou <julien@danjou.info> in
529 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
530 * alloc.c (allocate_string_data): Restore old code with minor
531 adjustments, fix comment to explain this subtle issue.
532
4dc7c8d5
SM
5332012-07-17 Eli Zaretskii <eliz@gnu.org>
534
535 Remove FILE_SYSTEM_CASE.
536 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
537
538 * fileio.c (FILE_SYSTEM_CASE): Don't define.
539 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
540 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
541 call-process-region passes it through expand-file-name.
542
543 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
544
5452012-07-17 Andreas Schwab <schwab@linux-m68k.org>
546
547 Fix crash when creating indirect buffer (Bug#11917)
548 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
549 Don't handle unbound variables specially if non-zero.
550 (Fbuffer_local_variables): Pass zero.
551 (clone_per_buffer_values): Pass non-zero.
552
5532012-07-17 Andreas Schwab <schwab@linux-m68k.org>
554
555 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
556 to make the loop interruptible.
557
5582012-07-17 Andreas Schwab <schwab@linux-m68k.org>
559
560 * gnutls.c (emacs_gnutls_handshake): Only retry if
561 GNUTLS_E_INTERRUPTED.
562
cce7fefc
DA
5632012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
564
565 Cleanup and convert miscellaneous checks to eassert.
566 * alloc.c (mark_interval): Fix comment, partially rephrase
567 old comment from intervals.h (see below).
568 * intervals.c (find_interval, adjust_intervals_for_insertion)
569 (delete_interval, adjust_intervals_for_deletion)
570 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
571 Convert to eassert.
572 (adjust_intervals_for_insertion, make_new_interval):
573 Remove obsolete and unused code.
574 * intervals.h (struct interval): Remove obsolete comment.
575 * textprotp.c (erase_properties): Remove unused code.
576 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
577 (Fremove_list_of_text_properties): Convert to eassert.
578
9ea10cc3
CY
5792012-07-17 Chong Yidong <cyd@gnu.org>
580
581 * editfns.c (Finsert_char): Doc fix.
582
3900d5de
DA
5832012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
584
585 Fix previous change to make Fmemory_free always accurate.
586 * alloc.c (make_interval): Update total_free_intervals.
587 (make_float): Likewise for total_free_floats.
588 (free_cons, Fcons): Likewise for total_free_conses.
589 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
590 Likewise for total_free_vector_bytes.
591 (Fmake_symbol): Likewise for total_free_symbols.
592 (bytes_free): Remove.
593
7098646f
DA
5942012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
595
596 Simple free memory accounting feature.
597 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
598 (sweep_vectors): Accumulate size of free vectors.
599 (Fgarbage_collect): Setup bytes_free.
600 (Fmemory_free): New function.
601 (syms_of_alloc): Register it.
602
22657b40
DA
6032012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
604
605 Cleanup overlays checking.
606 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
607 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
608 eassert and OVERLAYP.
609 (sort_overlays): Change to use OVERLAYP.
610
ddfc8813
RK
6112012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
612
613 * editfns.c (Finsert_char): Make it interactive, and make the
614 second arg optional. Copy interactive spec and docstring from
615 ucs-insert.
616
7c26cf3c
PE
6172012-07-17 Paul Eggert <eggert@cs.ucla.edu>
618
619 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
620 Unlike the other wrapped functions, fabs has an unspecified
621 effect on errno.
622
5d127af9
JD
6232012-07-16 Jan Djärv <jan.h.d@swipnet.se>
624
625 * nsterm.m (keyDown): Interpret flags without left/right bits
626 as the left key (Bug#11670).
627
6a0dd1d7
DA
6282012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
629
630 Remove empty and useless init functions.
631 * lisp.h (init_character_once, init_fns, init_image)
632 (init_filelock, init_sound): Remove prototype.
633 * character.c (init_character_once): Remove.
634 * filelock.c (init_filelock): Likewise.
635 * fns.c (init_fns): Likewise.
636 * image.c (init_image): Likewise.
637 * sound.c (init_sound): Likewise.
638 * emacs.c (main): Adjust accordingly.
639
7a6136fd
DA
6402012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
641
642 * gtkutil.h: Tiny cleanups.
643 (use_old_gtk_file_dialog): Remove useless declaration.
644 (xg_uses_old_file_dialog): Add suggested const attribute.
645
ce811ad9
EZ
6462012-07-15 Eli Zaretskii <eliz@gnu.org>
647
648 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
649 (bidi_paragraph_init): Use it to limit search forward for a strong
650 directional character in abnormally large paragraphs full of
651 neutral or weak characters. (Bug#11943)
652
c9adfeaa
SF
6532012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
654
655 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
656 the toolbar (Bug#9451).
657 (xg_make_tool_item): Give the widget event box a transparent
658 background.
659
fff62aa9
DA
6602012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
661
662 Cleanup basic allocation variables and functions.
663 * alloc.c (ignore_warnings, init_intervals, init_float)
664 (init_cons, init_symbol, init_marker): Remove.
665 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
666 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
667 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
668 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
669 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
670 (staticidx, init_alloc_once, init_strings, free_ablock):
671 Remove redundant initialization.
672 * fns.c (init_weak_hash_tables): Remove.
673 * lisp.h (init_weak_hash_tables): Remove prototype.
674
9730daca
DA
6752012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
676
677 Use zero_vector where appropriate.
678 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
679 accordingly.
680 * lisp.h (zero_vector): New declaration.
681 * font.c (null_vector): Remove.
682 (syms_of_font): Remove initialization and staticpro.
683 (font_list_entities, font_find_for_lface): Change to use zero_vector.
684 * keymap.c (Faccessible_keymaps): Likewise.
685
2e2d2a13
LL
6862012-07-15 Leo Liu <sdl.web@gmail.com>
687
688 * fringe.c: Fix typo in comments.
689
cd276f6e
LL
6902012-07-14 Leo Liu <sdl.web@gmail.com>
691
692 * fringe.c: Add a new bitmap exclamation-mark.
693
5a1131d9
EZ
6942012-07-14 Eli Zaretskii <eliz@gnu.org>
695
696 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
697
698 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
699 (HAVE_MENUS): Don't define, defined by editing config.in with
700 msdos/sed2v2.inp.
701 (GMALLOC_INHIBIT_VALLOC): Don't define.
702 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
703
22e983b7
JB
7042012-07-14 Juanma Barranquero <lekktu@gmail.com>
705
706 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
707
5b3f250f
GM
7082012-07-14 Glenn Morris <rgm@gnu.org>
709
710 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
711 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
712 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
713
33d63ff4
GM
7142012-07-13 Glenn Morris <rgm@gnu.org>
715
5b633342
GM
716 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
717
33d63ff4
GM
718 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
719 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
720
b55b9f85
JD
7212012-07-13 Jan Djärv <jan.h.d@swipnet.se>
722
0dc8cf50
JD
723 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
724 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
725 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
726 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
727 where appropriate.
728 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
729 as boolean expression.
730 (x_set_window_size): Remove unused variable toolbar.
731 (ns_get_color_default, ns_mod_to_lisp): Remove.
732 (ns_mouse_position): Remove unused variables xchar and ychar.
733 (ns_compute_glyph_string_overhangs): Remove unused variable face.
734 (ns_set_vertical_scroll_bar): Remove unused variable count.
735 (ns_delete_terminal): Remove unused variable i.
736 (ns_term_init): Remove unused variables r, g and b.
737 (mouseDown): Remove unused variable window.
738 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
739 (initFrameFromEmacs): Remove unused variable vbextra.
740 (mouseEntered): Remove unused variables p and dpyinfo.
741 (mouseExited): Remove unused variables p and r.
742 (ns_define_frame_cursor, ns_clear_frame_area)
743 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
744 (menuDown): Assign [sender tag] to variable and cast the variable.
745
746 * nsterm.h (menuDown): Add id as type to argument sender.
747 (ns_display_info_for_name): Add Lisp_Object argument.
748 (ns_term_init): Add Lisp_Object argument.
749 (ns_map_event_to_object): Add void argument.
750 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
751 prototype with arguments and only declare if __OBJC__.
752 (nxatoms_of_nsselect): Add void argument.
753 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
754 (ns_alloc_autorelease_pool): Add void argument.
755 (ns_release_autorelease_pool): Add void* argument.
756 (ns_get_defaults_value): Add const char* argument.
757
758 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
759 (initFromContents): Use SSDATA where appropriate.
760 (ns_update_menubar): Add braces to ambigous if-else.
761 (initWithTitle): Put () around assignment in if statement.
762 (ns_menu_show): Remove unused variables window and keymap.
763 (update_frame_tool_bar): Remove unused variable selected_p.
764 (initWithContentRect): Remove unused variable this_cmd_name.
765
766 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
767 appropriate.
768 (setXBMColor): Remove unused variable len.
769 (setPixmapData): Put () around assignment in loop statement.
770
771 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
772 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
773 where appropriate.
774 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
775 around assignment in loop statement.
776 (nsfont_open): Remove unused variable i.
777 (nsfont_open): Remove unused variable len.
778 (nsfont_draw): Remove unused variable cs.
779
780 * nsfns.m (x_set_icon_name, ns_set_name_internal)
781 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
782 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
783 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
784 (Fns_font_name, Fns_perform_service)
785 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
786 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
787 (ns_set_name): Remove unused variable view.
788 (x_set_menu_bar_lines): Remove unused variable olines.
789 (x_set_tool_bar_lines): Remove unused variable root_window.
790 (Fns_list_colors): Put () around assignment in while statement.
791 (Fns_perform_service): Remove unused variable len.
792 (Fns_display_usable_bounds): Remove unused variable top.
793 (syms_of_nsfns): Remove unused variable i.
794
b55b9f85
JD
795 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
796 memcpy (Bug#11907).
797
ed9265fc 7982012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
799
800 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
801 and free it with DestroyExceptionInfo (Bug#11558).
802
ef099b57
JB
8032012-07-13 Juanma Barranquero <lekktu@gmail.com>
804
805 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
806 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
807 Set here, not in nt/config.nt.
808
ea814a5d
EZ
8092012-07-13 Eli Zaretskii <eliz@gnu.org>
810
811 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
812 cursor overflow into the last glyph on display line when the right
813 fringe is off. (Bug#11832)
814
1a952767
PE
8152012-07-13 Paul Eggert <eggert@cs.ucla.edu>
816
817 * xdisp.c (produce_special_glyphs): Now static.
818 * dispextern.h (produce_special_glyphs): Remove decl.
819
983188fd
GM
8202012-07-13 Glenn Morris <rgm@gnu.org>
821
32fb4bb6
GM
822 * s/bsd-common, s/cygwin.h: Remove empty files.
823 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
824
983188fd
GM
825 * s/usg5-4-common.h (USG, USG5):
826 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
827 * s/sol2-6.h (SOLARIS2):
828 * s/irix6-5.h (IRIX6_5):
829 * s/hpux10-20.h (USG, USG5, HPUX):
830 * s/gnu-linux.h (USG, GNU_LINUX):
831 * s/freebsd.h (BSD_SYSTEM):
832 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
833 * s/cygwin.h (CYGWIN):
834 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
835 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
836
d1e68667 8372012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
838
839 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 840
6de0e799
GM
8412012-07-13 Glenn Morris <rgm@gnu.org>
842
739ae010
GM
843 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
844
dbee5793
GM
845 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
846
6de0e799
GM
847 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
848 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
849
b82da769
GM
8502012-07-12 Glenn Morris <rgm@gnu.org>
851
4fae5a7a 852 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
853
854 * process.c (init_process_emacs): Rename from init_process.
855 The old name is also the name of a Mach system call.
856 * lisp.h, emacs.c: Update for this name change.
857 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
858 longer needed.
859
5a979817
EZ
8602012-07-12 Eli Zaretskii <eliz@gnu.org>
861
862 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
863 memmove call that removes glyphs covered by the left truncation
864 glyph. Improve commentary.
865 (display_line): Fix display of continuation glyphs on GUI frames
866 when the right fringe is turned off and variable-size fonts are
867 used in the window. Move the code that appends a stretch glyph to
868 produce_special_glyphs, so that it could be used for truncation
869 and continuation glyphs alike.
870 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
871 glyph of a suitably computed width, to align the special glyphs at
872 the window margin. Code moved from display_line. (Bug#11832)
873
3e91a053
GM
8742012-07-12 Glenn Morris <rgm@gnu.org>
875
ba9e4b84
GM
876 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
877
878 * s/gnu-linux.h, s/hpux10-20.h:
879 Do not unconditionally define HAVE_XRMSETDATABASE.
880
3e91a053
GM
881 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
882
b300b1f4
PE
8832012-07-12 Paul Eggert <eggert@cs.ucla.edu>
884
885 Fix typos that broke OS X build.
886 Reported by Randal L. Schwartz in
887 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
888 * nsterm.m (ns_timeout): Add missing local decl.
889 (ns_get_color): snprintf -> sprintf, to fix typo.
890
6e777848
GM
8912012-07-12 Glenn Morris <rgm@gnu.org>
892
3f922c37
GM
893 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
894 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
895 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
896 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
897
0ab7b23a
GM
898 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
899 Move PTY_OPEN to configure.
900
6e777848
GM
901 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
902 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
903 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
904
4a7edc24
DA
9052012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
906
907 Use empty_unibyte_string where applicable.
908 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
909 * lread.c (read1): Likewise.
910 * xsettings.c (syms_of_xsettings): Likewise.
911
308aab79
GM
9122012-07-12 Glenn Morris <rgm@gnu.org>
913
42bd1719
GM
914 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
915 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
916 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
917 * s/hpux10-20.h (RUN_TIME_REMAP):
918 * s/bsd-common.h (TABDLY): Move to configure.
919
920 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
921
922 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
923
ea0bbd17 924 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 925 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
926
927 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 928
308aab79
GM
929 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
930 * s/template.h: Move NARROWPROTO to configure.
931
ee1cf5cf
GM
9322012-07-11 Glenn Morris <rgm@gnu.org>
933
30fe9bf4
GM
934 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
935 unused since 2011-01-17 change to systty.h.
936
ee1cf5cf
GM
937 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
938 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
939 Move HAVE_PTYS and HAVE_SOCKETS to configure.
940
63e47e07
PE
9412012-07-11 Paul Eggert <eggert@cs.ucla.edu>
942
943 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
944
c43fb4c3
GM
9452012-07-11 Glenn Morris <rgm@gnu.org>
946
947 * s/darwin.h, s/gnu-linux.h, s/template.h:
948 Move INTERRUPT_INPUT to configure.
949
e8df9267
DA
9502012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
951
952 Minor adjustments to interning code.
953 * lisp.h (intern, intern_c_string): Redefine as static inline
954 wrappers for intern_1 and intern_c_string_1, respectively.
955 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
956 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
957 Vobarray checking.
e8df9267
DA
958 * font.c (font_intern_prop): Likewise. Adjust comment.
959 * w32font.c (intern_font_name): Likewise.
960
34348bd4
AS
9612012-07-11 Andreas Schwab <schwab@linux-m68k.org>
962
d96a1e0c
AS
963 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
964
34348bd4
AS
965 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
966 of Fcar/Fcdr if possible.
967 * font.c (check_otf_features): Likewise.
968 * fontset.c (Fnew_fontset): Likewise.
969 * gnutls.c (Fgnutls_boot): Likewise.
970 * minibuf.c (read_minibuf): Likewise.
971 * msdos.c (IT_set_frame_parameters): Likewise.
972 * xmenu.c (Fx_popup_dialog): Likewise.
973 * w32menu.c (Fx_popup_dialog): Likewise.
974
c8add24e
GM
9752012-07-11 Glenn Morris <rgm@gnu.org>
976
4b575b3c
GM
977 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
978 since nothing has defined it on these platforms.
979
09f4e3b0
GM
980 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
981 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
982
172bedef
GM
983 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
984 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
985 Move CLASH_DETECTION to configure.
986
249685df
GM
987 * s/gnu.h: Remove file, which is now empty.
988
c8add24e
GM
989 * s/gnu.h, s/gnu-linux.h:
990 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
991
b41253a3
JW
9922012-07-11 John Wiegley <johnw@newartisans.com>
993
994 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
995 function attribute, so we only use it if it exists in the
996 compiler.
997
d923b542
DA
9982012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
999
1000 Avoid call to strlen in fast_c_string_match_ignore_case.
1001 * search.c (fast_c_string_match_ignore_case): Change to use
1002 length argument. Adjust users accordingly.
1003 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1004
5ebbef1d
PE
10052012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1006
bb352260
PE
1007 Assume mkdir, rmdir.
1008 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1009 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1010
57054ddd
PE
1011 Assume rename.
1012 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1013
b747d3f7
PE
1014 Assume perror.
1015 * s/hpux10-20.h (HAVE_PERROR): Remove.
1016 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1017 Remove dummy definition, as this problem was obsolete long ago.
1018
5ebbef1d
PE
1019 Assume strerror.
1020 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1021
984e7f30
DA
10222012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1023
1024 Avoid calls to strlen in font processing functions.
1025 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1026 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1027 users accordingly.
d923b542
DA
1028 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1029 Adjust prototypes.
1030 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1031 Change to return ptrdiff_t.
984e7f30
DA
1032 (xfont_list_pattern, xfont_match): Use length returned by
1033 xfont_decode_coding_xlfd.
1034 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1035
20e94fdd
GM
10362012-07-11 Glenn Morris <rgm@gnu.org>
1037
9d596af3
GM
1038 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1039 Move DONT_REOPEN_PTY to configure.
1040
20e94fdd
GM
1041 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1042 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1043
e99a530f
PE
10442012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1045
22ffb973
PE
1046 Remove "#define unix" that is no longer needed (Bug#11905).
1047 * s/aix4-2.h (unix): Remove; no longer needed.
1048
e9a9ae03
PE
1049 EMACS_TIME simplification (Bug#11875).
1050 This replaces macros (which typically do not work in GDB)
1051 with functions, typedefs and enums, making the code easier to debug.
1052 The functional style also makes code easier to read and maintain.
1053 * systime.h: Include <sys/time.h> on all hosts, not just if
1054 WINDOWSNT, since 'struct timeval' is needed in general.
1055 (EMACS_TIME): Now a typedef, not a macro.
1056 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1057 not macros.
1058 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1059 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1060 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1061 (EMACS_TIME_LE): Now functions, not macros.
1062 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1063 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1064 which are not functions. All uses rewritten to use:
1065 (make_emacs_time): New function.
1066 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1067 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1068 not functions. All uses rewritten to use the following, respectively:
1069 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1070 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1071 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1072 * fileio.c (Fcopy_file):
1073 * xterm.c (XTflash): Get the current time closer to when it's used.
1074 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1075
ffacb126
PE
1076 * bytecode.c (targets): Suppress -Woverride-init warnings.
1077
e99a530f
PE
1078 Simplify by avoiding confusing use of strncpy etc.
1079 * doc.c (Fsnarf_documentation):
1080 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1081 * frame.c (Fmake_terminal_frame):
1082 * gtkutil.c (get_utf8_string):
1083 * lread.c (openp):
1084 * nsmenu.m (ns_update_menubar):
1085 * regex.c (regerror):
1086 Prefer memcpy to strncpy and strncat when either will do.
1087 * fileio.c (Fsubstitute_in_file_name):
1088 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1089 (menu_separator_name_p):
1090 * nsmenu.m (ns_update_menubar):
1091 Prefer memcmp to strncmp when either will do.
1092 * nsterm.m: Include <ftoastr.h>.
1093 (ns_get_color):
1094 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1095 Prefer snprintf to strncpy.
1096 * nsterm.m (ns_term_init):
1097 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1098 * nsterm.m (ns_term_init):
1099 Avoid the need for strncpy, by using build_string or
1100 make_unibyte_string directly. Use dtoastr, not snprintf.
1101 * process.c (Fmake_network_process): Diagnose service names that
1102 are too long, rather than silently truncating them or creating
1103 non-null-terminated names.
1104 (Fnetwork_interface_info): Likewise, for interface names.
1105 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1106 Prefer sprintf to strncat.
1107 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1108 Prefer vsnprintf to vsprintf + strncpy.
1109
c59592b3
GM
11102012-07-10 Glenn Morris <rgm@gnu.org>
1111
1112 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1113 Clarify fallback case.
1114
7d7bbefd
DA
11152012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1116
1117 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1118 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1119 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1120 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1121 where argument type is known to be a Lisp_Cons.
1122
3a4c8000
TT
11232012-07-10 Tom Tromey <tromey@redhat.com>
1124
1125 * bytecode.c (BYTE_CODE_THREADED): New macro.
1126 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1127 (enum byte_code_op): New type.
1128 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1129 (exec_byte_code): Use them. Use token threading when applicable.
1130
2a0213a6
DA
11312012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1132
1133 Optimize pure C strings initialization.
1134 * lisp.h (make_pure_string): Fix prototype.
1135 (build_pure_c_string): New function, defined as static inline. This
1136 provides a better opportunity to optimize away calls to strlen when
1137 the function is called with compile-time constant argument.
1138 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1139 argument, adjust users accordingly. Use build_pure_c_string where
1140 appropriate.
1141 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1142 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1143 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1144
cb1caeaf
DA
11452012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1146
1147 Avoid calls to strlen in miscellaneous functions.
1148 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1149 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1150 * lread.c (openp): Likewise.
1151
c293e30c
DA
11522012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1153
1154 Avoid calls to strlen in path processing functions.
1155 * fileio.c (file_name_as_directory): Add comment. Change to add
1156 srclen argument and return the length of result. Adjust users
1157 accordingly.
1158 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1159 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1160 users accordingly.
1161 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1162
9e059e3f
GM
11632012-07-10 Glenn Morris <rgm@gnu.org>
1164
d02eb359
GM
1165 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1166 Move PENDING_OUTPUT_COUNT definition to configure.
1167
882cf227
GM
1168 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1169 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1170 * s/gnu.h (DATA_START): Move definitions to configure.
1171
af6e839f
GM
1172 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1173 We include usg5-4-common.h, which defines them both.
1174
40289a12
GM
1175 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1176 O_RDONLY already includes it).
1177
9e059e3f
GM
1178 Stop ns builds setting the EMACSLOADPATH environment variable.
1179 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1180 Now it does not set EMACSLOADPATH, just returns the load-path string.
1181 * nsterm.h: Update accordingly.
1182 * lread.c [HAVE_NS]: Include nsterm.h.
1183 (init_lread) [HAVE_NS]: Use ns_load_path.
1184 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1185
7c4e8ec0
GM
11862012-07-09 Glenn Morris <rgm@gnu.org>
1187
d4f600ff
GM
1188 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1189 since the included bsd-common.h does so.
1190
cbb31951
GM
1191 Stop ns builds setting the EMACSPATH environment variable.
1192 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1193 (ns_init_paths): Do not set EMACSPATH.
1194 * nsterm.h (ns_exec_path): Add it.
1195 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1196 Use ns_exec_path.
1197
7c4e8ec0
GM
1198 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1199
26bccfae
PE
12002012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1201
a0bee46f
PE
1202 * process.c (wait_reading_process_output): 'waitchannels' was unset
1203 when read_kbd || !NILP (wait_for_cell); fix this.
1204
5994c183
PE
1205 Add GCC-style 'const' attribute to functions that can use it.
1206 * character.h (char_resolve_modifier_mask):
1207 * keyboard.h (make_ctrl_char):
1208 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1209 (init_character_once, next_almost_prime, init_fns, init_image)
1210 (flush_pending_output, init_sound):
1211 * mem-limits.h (start_of_data):
1212 * menu.h (finish_menu_items):
1213 Add ATTRIBUTE_CONST.
1214 * emacs.c (DEFINE_DUMMY_FUNCTION):
1215 Declare the dummy function with ATTRIBUTE_CONST.
1216 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1217 Add decls with ATTRIBUTE_CONST.
1218
26bccfae
PE
1219 Minor improvements to make_formatted_string.
1220 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1221 where int is good enough, as vsprintf returns an int.
1222 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1223
a8290ec3
DA
12242012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1225
1226 Use make_formatted_string to avoid double length calculation.
1227 * lisp.h (make_formatted_string): New prototype.
1228 * alloc.c (make_formatted_string): New function.
1229 * buffer.c (Fgenerate_new_buffer_name): Use it.
1230 * dbus.c (syms_of_dbusbind): Likewise.
1231 * editfns.c (Fcurrent_time_zone): Likewise.
1232 * filelock.c (get_boot_time): Likewise.
1233 * frame.c (make_terminal_frame, set_term_frame_name)
1234 (x_report_frame_params): Likewise.
1235 * image.c (gs_load): Likewise.
1236 * minibuf.c (get_minibuffer): Likewise.
1237 * msdos.c (dos_set_window_size): Likewise.
1238 * process.c (make_process): Likewise.
1239 * xdisp.c (ensure_echo_area_buffers): Likewise.
1240 * xsettings.c (apply_xft_settings): Likewise.
1241
d01ba2f1
GM
12422012-07-09 Glenn Morris <rgm@gnu.org>
1243
1244 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1245 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1246 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1247 * nsterm.h (ns_etc_directory): Add it.
1248 * callproc.c [HAVE_NS]: Include nsterm.h.
1249 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1250
f1f924b6
DA
12512012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1252
1253 Move marker debugging code under MARKER_DEBUG.
1254 * marker.c (MARKER_DEBUG): Move marker debugging code under
1255 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1256 for bootstrap with --enable-checking (~3x slowdown reported
1257 by Juanma Barranquero <lekktu@gmail.com>).
1258 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1259
ab531b66
PE
12602012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1261
1262 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1263 See <http://bugs.gnu.org/11825#29>.
1264
c4b3bc8a
EZ
12652012-07-08 Eli Zaretskii <eliz@gnu.org>
1266
1267 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1268 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1269 (display_line): Add commentary about displaying truncation glyphs
1270 on GUI frames.
1271 (produce_special_glyphs): Move here from term.c.
1272
1273 * term.c (produce_special_glyphs): Move to xdisp.c.
1274
1275 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1276 section.
c4b3bc8a 1277
b676b881
AS
12782012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1279
f17c5273
AS
1280 * xdisp.c (display_line): Avoid warning about implicit declaration
1281 of FRAME_FONT.
1282
298819b9
AS
1283 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1284
b676b881
AS
1285 * lisp.h: Remove empty conditional.
1286
6045c4fd
PE
12872012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1288
b3350bf9
PE
1289 * lread.c (load_path_check): Now static.
1290
6045c4fd
PE
1291 Fix some minor --with-ns problems found by static checking.
1292 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1293 (x_set_font) [!HAVE_X_WINDOWS]:
1294 * image.c (xpm_load_image) [HAVE_NS]:
1295 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1296 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1297 Remove unused local.
1298 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1299 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1300 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1301 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1302 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1303 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1304 Fix pointer signedness problem.
1305 * xfaces.c (FRAME_X_FONT_TABLE):
1306 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1307
929e7845
GM
13082012-07-07 Glenn Morris <rgm@gnu.org>
1309
1310 * lread.c (load_path_check): New function, split from init_lread.
1311 (init_lread): Reorganize. Motivation:
1312 If EMACSLOADPATH is set, check/warn about that rather than the
1313 defaults, which we are not going to use. Hence we can remove
1314 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1315 Don't warn if site-lisp directories are missing.
1316 If not installed, start from a blank load-path, since
1317 PATH_LOADSEARCH refers to the eventual installation directories.
1318
58dd0aa4
EZ
13192012-07-07 Eli Zaretskii <eliz@gnu.org>
1320
1321 Support truncation and continuation glyphs on GUI frames, when
1322 fringes are disabled. (Bug#11832)
1323 * xdisp.c (init_iterator): Get dimensions of truncation and
1324 continuation glyphs even if on GUI frames. Adjust
1325 it->last_visible_x on GUI frames when the left or right fringes,
1326 or both, are absent.
1327 (start_display, move_it_in_display_line_to): Handle the case of a
1328 GUI frame without a fringe to display continuation or truncation
1329 glyphs.
1330 (insert_left_trunc_glyphs): Support GUI frames: make sure
1331 truncation glyphs overwrite enough glyphs from the current line to
1332 have sufficient space in pixels.
1333 (display_line): Support truncation and continuation glyphs on GUI
1334 frames. If some spare pixels are left on the line after inserting
1335 the truncation glyphs, fill that space with a stretch glyph of a
1336 suitably computed width.
1337
1338 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1339 produce_glyphs, to support GUI sessions.
1340
31571fd7
PE
13412012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1342
5a16b9bc
PE
1343 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1344
f3047c75
PE
1345 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1346
31571fd7
PE
1347 Do not require float-time's arg to fit in time_t (Bug#11825).
1348 This works better on hosts where time_t is unsigned, and where
1349 float-time is applied to the (negative) difference between two times.
1350 * editfns.c (decode_time_components): Last arg is now double *,
1351 not int *, and means to store all the result as a double, without
1352 worrying about whether the seconds part fits in time_t.
1353 All callers changed.
1354 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1355 All callers changed.
1356 (Ffloat_time): Do not fail merely because the specified time falls
1357 outside of time_t range.
1358
4516fbef
GM
13592012-07-07 Glenn Morris <rgm@gnu.org>
1360
1361 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1362 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1363 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1364
07adc2c6
JB
13652012-07-07 Juanma Barranquero <lekktu@gmail.com>
1366
1367 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1368 Update dependencies.
1369
1370 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1371
fd573f31
PE
13722012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1373
fee5959d
PE
1374 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1375 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1376 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1377 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1378 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1379 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1380
fd573f31
PE
1381 * xfont.c (compare_font_names): Redo to omit the need for casts.
1382
ddadbc0e
AS
13832012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1384
fca8d6b6
AS
1385 * xfns.c (Fx_change_window_property): Doc fix.
1386 * w32fns.c (Fx_change_window_property): Doc fix.
1387
ddadbc0e
AS
1388 * w32fns.c (Fx_window_property): Accept the same arguments as the
1389 X Windows version. Doc fix.
1390 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1391
ed9265fc 13922012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1393 Eli Zaretskii <eliz@gnu.org>
1394
1395 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1396 Windows-specific code from nt/config.nt moved here.
1397 Obsolete settings removed.
1398
216ee680
PE
13992012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1400
1401 * process.c: Avoid unnecessary calls to gettime.
1402 (wait_reading_process_output): Don't get the time of day
1403 when gobbling data immediately and not waiting, as there's no need
1404 for it in that case. This removes a FIXME.
1405
bdd091e4
JD
14062012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1407
1408 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1409 is defined (Bug#11768).
1410
9d44f8ce
DA
14112012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1412
1413 Fix marker debugging code.
1414 * marker.c (byte_char_debug_check): Do not perform the check
1415 if buffer is not multibyte.
090bd7cb
JB
1416 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1417 Call byte_char_debug_check with correct arguments.
9d44f8ce 1418
90fc4786
DA
14192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1420
1421 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1422 * marker.c (byte_char_debug_check, count_markers):
1423 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1424 (byte_debug_flag): Remove.
1425 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1426 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1427
7b7ae965
DA
14282012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1429
4e57b342
DA
1430 Avoid code repetition in marker-related functions.
1431 * marker.c (attach_marker): New function.
1432 (Fset_marker, set_marker_restricted, set_marker_both)
1433 (set_marker_restricted_both): Use it.
1434 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1435 Consistently rename charno to charpos.
1436 (marker_position): Add eassert.
1437 (marker_byte_position): Convert to eassert.
1438
14392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1440
1441 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1442 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1443 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1444
657924ff
DA
14452012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1446
1447 Introduce fast path for the widely used marker operation.
1448 * alloc.c (build_marker): New function.
1449 * lisp.h (build_marker): New prototype.
1450 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1451 * composite.c (autocmp_chars): Likewise.
1452 * editfns.c (buildmark): Remove.
1453 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1454 (save_restriction_save): Use build_marker.
1455 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1456 * window.c (save_window_save): Likewise.
1457
041a49a6
DA
14582012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1459
1460 Do not use Fdelete_overlay in delete_all_overlays
1461 to avoid redundant calls to unchain_overlay.
1462 * buffer.c (drop_overlay): New function.
1463 (delete_all_overlays, Fdelete_overlay): Use it.
1464 * minibuf.c (get_minibuffer): Fix comment.
1465
7dca65a4
PE
14662012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1467
1468 Port to OpenBSD 5.1 amd64.
1469 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1470 This is needed for OpenBSD, and should be harmless on all BSD systems.
1471 Also, include <sys/sysctl.h>, as it should be available on all
1472 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1473 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1474 use p_pid member, not kp_proc.pid.
1475
8eb876e2
GM
14762012-07-06 Glenn Morris <rgm@gnu.org>
1477
1478 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1479
38182d90
PE
14802012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1481
1482 More xmalloc and related cleanup.
1483 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1484 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1485 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1486 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1487 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1488 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1489 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1490 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1491 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1492 * xterm.c:
1493 Omit needless casts involving void * pointers and allocation.
1494 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1495 as the former is more robust if P's type is changed.
1496 Prefer xzalloc to xmalloc + memset 0.
1497 Simplify malloc-or-realloc to realloc.
1498 Don't worry about xmalloc returning a null pointer.
1499 Prefer xstrdup to xmalloc + strcpy.
1500 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1501 growing it.
1502 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1503 alloca of a constant.
1504
6dd5a677
EZ
15052012-07-05 Eli Zaretskii <eliz@gnu.org>
1506
1507 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1508 hscroll is larger than the line width. Fixes long and futile
1509 looping inside extend_face_to_end_of_line (on a TTY) producing
1510 glyphs that are not needed and thrown away.
1511
6b312f0f
DA
15122012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1513
1514 * marker.c (set_marker_restricted_both): Simplify by using
1515 clip_to_bounds.
1516
f520ef9b
PE
15172012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1518
1519 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1520
383b7c95
JD
15212012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1522
1523 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1524 not defined (Bug#11768).
1525 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1526 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1527 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1528 followed by gtk_box_set_homogeneous (Bug#11768).
1529 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1530 (update_theme_scrollbar_width, xg_create_scroll_bar):
1531 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1532 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1533 (is_box_type): New function (Bug#11768).
1534 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1535 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1536 with default display (Bug#11768).
1537
d6e7bf45
EZ
15382012-07-05 Eli Zaretskii <eliz@gnu.org>
1539
1540 * xdisp.c (window_hscroll_limited): New function.
1541 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1542 coordinates when window's hscroll is set to insanely large
1543 values. (Bug#11857)
1544
431391ec
JB
15452012-07-05 Juanma Barranquero <lekktu@gmail.com>
1546
1547 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1548 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1549
23f86fce
DA
15502012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1551
1552 Cleanup xmalloc.
1553 * lisp.h (xzalloc): New prototype. Omit needless casts.
1554 * alloc.c (xzalloc): New function. Omit needless casts.
1555 * charset.c: Omit needless casts. Convert all calls to
1556 xmalloc with following memset to xzalloc.
1557 * dispnew.c: Likewise.
1558 * fringe.c: Likewise.
1559 * image.c: Likewise.
1560 * sound.c: Likewise.
1561 * term.c: Likewise.
1562 * w32fns.c: Likewise.
1563 * w32font.c: Likewise.
1564 * w32term.c: Likewise.
1565 * xfaces.c: Likewise.
1566 * xfns.c: Likewise.
1567 * xterm.c: Likewise.
1568 * atimer.c: Omit needless casts.
1569 * buffer.c: Likewise.
1570 * callproc.c: Likewise.
1571 * ccl.c: Likewise.
1572 * coding.c: Likewise.
1573 * composite.c: Likewise.
1574 * doc.c: Likewise.
1575 * doprnt.c: Likewise.
1576 * editfns.c: Likewise.
1577 * emacs.c: Likewise.
1578 * eval.c: Likewise.
1579 * filelock.c: Likewise.
1580 * fns.c: Likewise.
1581 * gtkutil.c: Likewise.
1582 * keyboard.c: Likewise.
1583 * lisp.h: Likewise.
1584 * lread.c: Likewise.
1585 * minibuf.c: Likewise.
1586 * msdos.c: Likewise.
1587 * print.c: Likewise.
1588 * process.c: Likewise.
1589 * region-cache.c: Likewise.
1590 * search.c: Likewise.
1591 * sysdep.c: Likewise.
1592 * termcap.c: Likewise.
1593 * terminal.c: Likewise.
1594 * tparam.c: Likewise.
1595 * w16select.c: Likewise.
1596 * w32.c: Likewise.
1597 * w32reg.c: Likewise.
1598 * w32select.c: Likewise.
1599 * w32uniscribe.c: Likewise.
1600 * widget.c: Likewise.
1601 * xdisp.c: Likewise.
1602 * xmenu.c: Likewise.
1603 * xrdb.c: Likewise.
1604 * xselect.c: Likewise.
1605
0497dc44
PE
16062012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1607
1608 * fileio.c (time_error_value): Check the right error number.
1609 Problem reported by Troels Nielsen in
1610 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1611
356e7178
PE
16122012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1613
4e71fd89
PE
1614 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1615 This should be fixed in a better way; see Eli Zaretskii in
1616 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1617 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1618
f0941253
PE
1619 * fileio.c (time_error_value): Rename from special_mtime.
1620 The old name's problems were noted by Eli Zaretskii in
1621 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1622
065c9eb4
PE
1623 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1624 This variable's comment says Emacs needs at least one GDB-visible
1625 symbol of type enum pvec_type, to work around GDB problems.
1626 The symbol's value doesn't matter.
1627
356e7178
PE
1628 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1629 that causes compilation to fail on pre-C99 compilers.
1630
ed9265fc 16312012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1632
1633 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1634 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1635
3884d954
DA
16362012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1637
d209e2fb 1638 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1639 headers for buffer_defaults and buffer_local_symbols.
1640 Reported by Juanma Barranquero <lekktu@gmail.com>.
1641
ee28be33
SM
16422012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1643
1644 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1645 * lisp.h (enum pvec_type): Use fewer bits.
1646 (PSEUDOVECTOR_SIZE_BITS): New constant.
1647 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1648 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1649 change in pvec_type.
1650 (PSEUDOVECTOR_TYPEP): New macro.
1651 (TYPED_PSEUDOVECTORP): Use it.
1652 * fns.c (internal_equal): Adapt code to extract pvectype.
1653 * emacs.c (gdb_pvec_type): Update type.
1654 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1655 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1656 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1657 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1658 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1659 abusing vector->header.next.nbytes.
1660 (live_vector_p): Use PVEC_TYPE.
1661 (mark_object): Adapt code to extract pvectype. Use switch.
1662
c7f2cd7f
PE
16632012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1664
1665 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1666 Tighten new eassert a bit.
1667
8ce70ed2
DA
16682012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1669
1670 Fix compilation with --enable-gcc-warnings and -O1
1671 optimization level.
1672 * doprnt.c (doprnt): Change type of tem to int, initialize
1673 to avoid compiler warning. Add eassert.
1674 * search.c (simple_search): Initialize match_byte to avoid
1675 compiler warning. Add eassert.
1676
dea7f1e5
PE
16772012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1678
24a212eb
PE
1679 Avoid weird behavior with large horizontal scrolls.
1680 Without this change, for example, large hscroll values would
1681 mess up Emacs's display on Fedora 15 x86, presumably due to
1682 overflows in int calculations in the display code.
1683 Also, if buffers had long lines, Emacs would freeze.
1684 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1685 (set_window_hscroll): New function, containing the old guts of
1686 Fset_window_hscroll. Return the clipped value.
1687 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1688 This avoids the need to check against PTRDIFF_MAX.
1689
dea7f1e5
PE
1690 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1691
76046526
DA
16922012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1693
1694 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1695
39adff0d
PE
16962012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1697
63807d47
PE
1698 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1699 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1700 since GCC 4.4.6 issues a bogus warning for them.
1701
39adff0d
PE
1702 Fix bugs in file timestamp newness comparisons.
1703 * fileio.c (Ffile_newer_than_file_p):
1704 * lread.c (Fload): Use full timestamp resolution of files,
1705 not just the 1-second resolution, so that files that are only
1706 slightly newer still count as newer.
1707 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1708 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1709
dbeed9a6
PE
17102012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1711
1712 * fileio.c: Improve handling of file time marker. (Bug#11852)
1713 (special_mtime): New function.
1714 (Finsert_file_contents, Fverify_visited_file_modtime):
1715 Use it to set special mtime values consistently.
1716
636334d6
AS
17172012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1718
1719 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1720 marker for non-existing file. (Bug#11852)
1721
e2017fe2
GM
17222012-07-03 Glenn Morris <rgm@gnu.org>
1723
1724 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1725 and did not make it into globals.h).
1726
404dbd37
TT
17272012-07-03 Tom Tromey <tromey@redhat.com>
1728
1729 * window.c (Fset_window_margins, Fset_window_fringes)
1730 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1731 * textprop.c (Fprevious_property_change): No longer static.
1732 * syntax.c (Fsyntax_table_p): No longer static.
1733 * process.c (Fget_process, Fprocess_datagram_address): No longer
1734 static.
1735 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1736 * keyboard.c (Fcommand_execute): No longer static.
1737 Remove EXFUN.
1738 * insdel.c (Fcombine_after_change_execute): No longer static.
1739 * image.c (Finit_image_library): No longer static.
1740 * fileio.c (Fmake_symbolic_link): No longer static.
1741 * eval.c (Ffetch_bytecode): No longer static.
1742 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1743 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1744 No longer static.
404dbd37
TT
1745 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1746 static.
1747 * dired.c (Ffile_attributes): No longer static.
1748 * composite.c (Fcomposition_get_gstring): No longer static.
1749 * callproc.c (Fgetenv_internal): No longer static.
1750
1751 * ccl.h: Remove EXFUNs.
1752 * buffer.h: Remove EXFUNs.
1753 * dispextern.h: Remove EXFUNs.
1754 * intervals.h: Remove EXFUNs.
1755 * fontset.h: Remove EXFUN.
1756 * font.h: Remove EXFUNs.
1757 * dosfns.c (system_process_attributes): Remove EXFUN.
1758 * keymap.h: Remove EXFUNs.
1759 * lisp.h: Remove EXFUNs.
1760 * w32term.h: Remove EXFUNs.
1761 * window.h: Remove EXFUNs.
1762 * xsettings.h: Remove EXFUN.
1763 * xterm.h: Remove EXFUN.
1764
8e4fd1e1
GM
17652012-07-03 Glenn Morris <rgm@gnu.org>
1766
1767 * lisp.h (Frandom): Make it visible to C.
1768 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1769 buffer for invisible buffers. (Bug#1229)
1770
ca95b3eb
DA
17712012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1772
1773 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1774 values which aren't power of 2.
1775 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1776 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1777 accordingly.
1778
7555c33f
SM
17792012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1780
1781 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1782
1783 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1784
d12e8f5a
DA
17852012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1786
1787 * alloc.c (allocate_vector_block): Remove redundant
1788 calls to mallopt if DOUG_LEA_MALLOC is defined.
1789 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1790 avoid calls to mallopt if zero_vector is returned.
1791
296094c3
DA
17922012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1793
1794 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1795 is enabled, avoid dereferencing NULL current_sblock if
1796 running undumped.
1797
36429c89
DA
17982012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1799
1800 Cleanup basic buffer management.
1801 * buffer.h (struct buffer): Change layout to use generic vector
1802 marking code. Fix some comments. Change type of 'clip_changed'
1803 to bitfield. Remove unused #ifndef old.
1804 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1805 (GET_OVERLAYS_AT): Fix indentation.
1806 (for_each_per_buffer_object_at): New macro.
1807 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1808 (Fbuffer_local_variables): Use it.
1809 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1810 * alloc.c (allocate_buffer): Adjust to match new layout of
1811 struct buffer. Fix comment.
1812 (mark_overlay): New function.
1813 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1814 Lisp area of struct buffer.
1815 (mark_object): Use it. Adjust marking of misc objects
1816 and related comments.
1817
3b3e4cac
PE
18182012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1821 wrapper that is not needed because the wrapped code is a no-op (zero
1822 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1823 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1824
cf5c0175
DA
18252012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1826
1827 * alloc.c (mark_buffer): Simplify. Remove prototype.
1828 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1829 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1830 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1831 redundant calls to mark_vectorlike for bool vectors.
1832
ca26824c
GM
18332012-06-30 Glenn Morris <rgm@gnu.org>
1834
2e4c5312
GM
1835 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1836
ca26824c
GM
1837 * epaths.in (PATH_SITELOADSEARCH): New.
1838 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1839 This is rather than relying on --enable-locallisppath elements
1840 having "site-lisp" in their names. (Bug#10208#25, 11658)
1841
0d23c240
EZ
18422012-06-30 Eli Zaretskii <eliz@gnu.org>
1843
c9240d7a
EZ
1844 * w32proc.c (sys_select): Accept and ignore one more argument.
1845
1846 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1847
0d23c240 1848 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1849 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1850
1851 * sysdep.c: Don't include dos.h and dosfns.h.
1852
1853 * process.c (sys_select):
1854 * msdos.c (sys_select): Accept one more argument and ignore it.
1855
1856 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1857 adapt data types and code to that.
1858
1859 * dosfns.c:
1860 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1861 which clashes with the gnulib function of the same name.
1862
af5a5a98
AS
18632012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1864
c5e4379c
AS
1865 * font.c (font_style_to_value, font_style_symbolic)
1866 (font_prop_validate_style): Add type checks for values in
1867 font_style_table.
1868
af5a5a98
AS
1869 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1870 argument.
1871 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1872 uses.
1873
8d38f461
EZ
18742012-06-29 Eli Zaretskii <eliz@gnu.org>
1875
2e5a6631
EZ
1876 * xdisp.c (try_window_id): Undo last change.
1877
8d38f461
EZ
1878 * w32.c (getwd): Adjust commentary about startup_dir.
1879 (init_environment): Always call sys_access, even in non-MSVC
1880 builds. Don't chdir to the directory of the Emacs executable.
1881 This undoes code from 1997 which was justified by the need to
1882 "avoid conflicts when removing and renaming directories". But its
1883 downside was that every relative file name was being interpreted
1884 relative to the directory of the Emacs executable, which can never
1885 be TRT. In particular, it broke sys_access when called with
1886 relative file names.
1887 (sys_access): Map GetLastError to errno.
1888
2af3565e
DA
18892012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1890
1891 * window.h (struct window): Change type of 'fringes_outside_margins'
1892 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1893 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1894 Adjust comment.
1895 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1896 to ptrdiff_t.
1897
c8d3a25c 18982012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1899
c8d3a25c
GM
1900 * gnutls.c (emacs_gnutls_handshake):
1901 Add QUIT to make the loop interruptible.
57570cd3 1902
c8d3a25c 19032012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1904
c8d3a25c
GM
1905 * charset.c (init_charset): Make lack of etc/charsets fatal.
1906
3e984ee8
DA
19072012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1908
1909 * editfns.c (region_limit): Fix type mismatch.
1910
ef884f23
DA
19112012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1912
1913 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1914 undefined. Convert from xassert to eassert.
1915 * nsmenu.m: Convert from xassert to eassert.
1916 * nsterm.m: Likewise.
1917
7d7e0027
SM
19182012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1919
1920 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1921
aa754e6a
PE
19222012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1923
1924 Avoid integer overflow on scroll-left and scroll-right.
1925 * window.c (HSCROLL_MAX): New macro.
1926 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1927 overflow when requested scroll falls outside ptrdiff_t range.
1928
80b00b08
DA
19292012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1930
1931 * window.h (struct window): Change type of 'hscroll',
1932 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1933 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1934 Adjust users accordingly.
1935 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1936 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1937 from EMACS_INT to ptrdiff_t.
1938 (make_window): Omit redundant initialization.
1939
62b2bcf6
JB
19402012-06-28 Juanma Barranquero <lekktu@gmail.com>
1941
1942 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1943
45942c7d
DA
19442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1945
1946 * window.h (struct window): Change type of 'use_time' and
1947 'sequence_number' from Lisp_Object to int.
1948 * frame.c (make_frame): Adjust users accordingly.
1949 * print.c (print_object): Likewise.
1950 * window.c (select_window, Fwindow_use_time, make_parent_window)
1951 (make_window): Likewise.
1952
e509cfa6
DA
19532012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1954
1955 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1956 enabled with --enable-checking=[all,glyphs] configure option.
1957 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1958 adjust comments accordingly.
1959 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1960 undefined, adjust comments accordingly.
1961 * image.c: Likewise.
1962 * scroll.c: Likewise.
1963 * w32fns.c: Likewise.
1964 * w32term.c: Likewise.
1965 * xdisp.c: Likewise.
1966 * xfaces.c: Likewise.
1967 * xfns.c: Likewise.
1968 * xterm.c: Likewise.
1969
a54e2c05
DA
19702012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1971
1972 Generalize run-time debugging checks.
1973 * dispextern.h (XASSERTS): Remove.
1974 * fontset.c (xassert): Remove.
1975 Convert from xassert to eassert.
1976 * alloc.c: Convert from xassert to eassert.
1977 * bidi.c: Likewise.
1978 * dispnew.c: Likewise.
1979 * fns.c: Likewise.
1980 * fringe.c: Likewise.
1981 * ftfont.c: Likewise.
1982 * gtkutil.c: Likewise.
1983 * image.c: Likewise.
1984 * keyboard.c: Likewise.
1985 * menu.c: Likewise.
1986 * process.c: Likewise.
1987 * scroll.c: Likewise.
1988 * sound.c: Likewise.
1989 * term.c: Likewise.
1990 * w32console.c: Likewise.
1991 * w32fns.c: Likewise.
1992 * w32term.c: Likewise.
1993 * window.c: Likewise.
1994 * xdisp.c: Likewise.
1995 * xfaces.c: Likewise.
1996 * xfns.c: Likewise.
1997 * xselect.c: Likewise.
1998 * xterm.c: Likewise.
1999
1ec4b7b2
SM
20002012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2001
2002 * fns.c (maybe_resize_hash_table): Output message when growing the
2003 purify-hashtable.
2004
2014308a
DA
20052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2006
2007 * alloc.c (allocate_string_data): Remove dead code.
2008 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2009 avoid GCC warning about unused macro.
2010
246155eb
DA
20112012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2012
2013 * alloc.c (allocate_string): Omit intervals initialization.
2014 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2015 as in make_pure_string and make_pure_c_string.
2016
43184b7b
DA
20172012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2018
d209e2fb 2019 * alloc.c (allocate_string): Fix last change.
43184b7b 2020
3fe6dd74
DA
20212012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2022
d209e2fb 2023 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2024 to memset, add explicit initialization where appropriate.
2025
1ba6038a
GM
20262012-06-27 Glenn Morris <rgm@gnu.org>
2027
2028 * lisp.mk (lisp): Remove paths.elc.
2029
c89926a5
CY
20302012-06-27 Chong Yidong <cyd@gnu.org>
2031
2032 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2033
ed6b3510
JW
20342012-06-26 John Wiegley <johnw@newartisans.com>
2035
1ec4b7b2 2036 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2037 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2038
ed6b3510
JW
2039 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2040 when building with Clang.
2041
8edd4a2b
SM
20422012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2043
2044 * eval.c (Fapply): Allow calling it with a single argument.
2045
f6f62d1b
EZ
20462012-06-26 Eli Zaretskii <eliz@gnu.org>
2047
2048 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2049 _stricmp and _strnicmp.
2050 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2051
62efea5e
DA
20522012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2053
2054 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2055 allocated window.
2056 (allocate_process): Likewise for new process.
8edd4a2b 2057 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2058 (allocate_frame): Likewise.
2059 * frame.c (make_frame): Omit redundant initialization.
2060 * window.c (make_parent_window): Use memset.
2061 (make_window): Omit redundant initialization.
2062 * process.c (make_process): Omit redundant initialization.
2063 * terminal.c (create_terminal): Likewise.
2064
42997f4d
DA
20652012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2066
2067 * term.c (delete_tty): Remove redundant call to memset.
2068
1130ecfc
DA
20692012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2070
2071 * alloc.c: Remove build_string.
2072 * lisp.h: Define build_string as static inline. This provides
2073 a better opportunity to optimize away calls to strlen when the
2074 function is called with compile-time constant argument.
2075 * image.c (imagemagick_error): Convert to build_string.
2076 * w32proc.c (sys_spawnve): Likewise.
2077 * xterm.c (x_term_init): Likewise.
2078
cf38a720
PE
20792012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2080
99027bdd
PE
2081 Use sprintf return value instead of invoking strlen on result.
2082 In the old days this wasn't portable, since some sprintf
2083 implementations returned char *. But they died out years ago and
2084 Emacs already assumes sprintf returns int.
2085 Similarly for float_to_string.
2086 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2087 * ccl.c (ccl_driver):
2088 * character.c (string_escape_byte8):
2089 * data.c (Fnumber_to_string):
2090 * doprnt.c (doprnt):
2091 * print.c (print_object):
2092 * xdisp.c (message_dolog):
2093 * xfns.c (syms_of_xfns):
2094 Use sprintf or float_to_string result to avoid need to call strlen.
2095 * data.c (Fnumber_to_string):
2096 Use make_unibyte_string, since the string must be ASCII.
2097 * lisp.h, print.c (float_to_string): Now returns int length.
2098 * term.c (produce_glyphless_glyph):
2099 Use sprintf result rather than recomputing it.
2100
cf38a720
PE
2101 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2102 * Makefile.in (ALL_CFLAGS):
2103 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2104 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2105
3511c784
DA
21062012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2107
0a08eb21 2108 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2109 strcasecmp if available.
2110 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2111
fb7da12e
AS
21122012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2115 Avoid comma operator.
2116 * menu.c (push_submenu_start, push_submenu_end)
2117 (push_left_right_boundary, push_menu_pane): Likewise.
2118 * msdos.c (dos_rawgetc): Likewise.
2119
afa2ffd8
DA
21202012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2121
2122 * xfns.c (xic_create_fontsetname): Remove redundant calls
2123 to memset.
2124
b3b4476b
PE
21252012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2126
4495ff38
PE
2127 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2128 sprintf already null-terminates its output.
2129
b3b4476b
PE
2130 * xfns.c (x_window): Remove redundant cast.
2131
b00876c9
DA
21322012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2133
2134 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2135 `const char *' to `char *' to avoid compiler warning.
2136
d188e26b
PE
21372012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2138
885d1d74
PE
2139 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2140 instead of truncating it to 63 (admittedly a generous limit).
2141
d188e26b
PE
2142 * process.c: Fix spelling and caps in comments.
2143
e2f560b1
DN
21442012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2145
e86db54b 2146 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2147 * sysdep.c (setpgrp): Remove definition, not used in this file.
2148
7583a3a1
JB
21492012-06-24 Juanma Barranquero <lekktu@gmail.com>
2150
2151 * makefile.w32-in: Update dependencies.
2152
696056c2
EZ
21532012-06-24 Eli Zaretskii <eliz@gnu.org>
2154
2155 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2156 (SYSTIME_H): Add nt/inc/sys/time.h.
2157
2158 * systime.h [WINDOWSNT]: Include sys/time.h.
2159
2160 * s/ms-w32.h (struct timespec): Definition moved from
2161 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2162
845ca893
PE
21632012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2164
2165 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2166 * buffer.h (buffer_slot_type_mismatch):
2167 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2168 * eval.c (unwind_to_catch):
2169 * image.c (my_png_error, my_error_exit):
2170 * keyboard.c (quit_throw_to_read_char, user_error)
2171 (Fexit_recursive_edit, Fabort_recursive_edit):
2172 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2173 (wrong_type_argument, buffer_overflow, __executable_start)
2174 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2175 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2176 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2177 (fatal):
2178 (child_setup) [!DOS_NT]:
2179 * lread.c (end_of_file_error, invalid_syntax):
2180 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2181 * puresize.h (pure_write_error):
2182 * search.c (matcher_overflow):
2183 * sound.c (sound_perror, alsa_sound_perror):
2184 * sysdep.c, syssignal.h (croak):
2185 * term.c (maybe_fatal, vfatal):
2186 * textprop.c (text_read_only):
2187 * undo.c (user_error):
2188 * unexmacosx.c (unexec_error):
2189 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2190 Use _Noreturn rather than NO_RETURN.
2191 No need for separate decl merely because of _Noreturn.
2192 * sound.c (sound_warning, parse_sound):
2193 Remove unnecessary forward decls.
2194
f1dd8073
PE
21952012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2196
2197 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2198 * lisp.h (WAIT_READING_MAX): New macro.
2199 * dispnew.c (Fsleep_for, sit_for):
2200 * keyboard.c (kbd_buffer_get_event):
2201 * process.c (Faccept_process_output):
2202 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2203 This improves on the previous patch, which introduced a bug
2204 when time_t is unsigned and as wide as intmax_t.
2205 See <http://bugs.gnu.org/9000#51>.
2206
b82c1755
EZ
22072012-06-23 Eli Zaretskii <eliz@gnu.org>
2208
2209 * dispnew.c (sit_for, Fsleep_for):
2210 * keyboard.c (kbd_buffer_get_event):
2211 * process.c (Faccept_process_output): Avoid compiler warnings when
2212 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2213
ca300656
JB
22142012-06-23 Juanma Barranquero <lekktu@gmail.com>
2215
049ec95b
JB
2216 * makefile.w32-in: Update dependencies.
2217
ca300656
JB
2218 * w32.c (ltime): Add return type and declare static.
2219 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2220
db7b8d06
PE
22212012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2222
2223 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2224 Privately reported by Herbert J. Skuhra.
2225 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2226 All uses changed.
2227 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2228 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2229
0bd8297f
EZ
22302012-06-23 Eli Zaretskii <eliz@gnu.org>
2231
96512555
EZ
2232 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2233 last argument of make_unibyte_string.
2234
0bd8297f
EZ
2235 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2236 language ID in the event parameters.
2237
2238 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2239 event.code, not the obscure "character set ID".
2240
63def6b6
CY
22412012-06-23 Chong Yidong <cyd@gnu.org>
2242
2243 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2244
e8a02204
EZ
22452012-06-23 Eli Zaretskii <eliz@gnu.org>
2246
388cdec0
EZ
2247 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2248 * w32.c (fdutimens): New function.
2249
2250 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2251
2252 * s/ms-w32.h (pselect): Redirect to sys_select.
2253
2254 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2255
e8a02204
EZ
2256 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2257 in the logic of incrementing and decrementing the value of
2258 use_relocatable_buffers.
2259
d054f3fb
PE
22602012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2263 Privately reported by Herbert J. Skuhra.
2264 [__FreeBSD__]: Remove "*/" typo after "#include".
2265 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2266 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2267 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2268 Don't assume EMACS_TIME and struct timeval are the same type.
2269
d35af63c
PE
22702012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2271
2272 Support higher-resolution time stamps (Bug#9000).
2273 The time stamps are only nanosecond-resolution at the C level,
2274 since that's the best that any real-world system supports now.
2275 But they are picosecond-resolution at the Lisp level, as that's
2276 easy, and leaves room for future OS improvements.
2277
2278 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2279 (LIBES): Use it.
2280
2281 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2282 Don't get current time unless it's needed.
2283
2284 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2285 now provides it if it's absent.
2286 (start_atimer): Port to higher-res time stamps.
2287 Check for time stamp overflow. Don't get current time more
2288 often than is needed.
2289
2290 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2291 Include systime.h, not time.h.
2292 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2293
2294 * dired.c: Include stat-time.h.
2295 (Ffile-attributes): File times now have higher resolution.
2296
2297 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2298 (struct image): Timestamp now has higher resolution.
2299
2300 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2301 has at least microseconds now. All uses removed.
2302 (update_frame, update_single_window, update_window, update_frame_1)
2303 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2304
2305 * editfns.c (time_overflow): Now extern.
2306 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2307 (float-time, Fformat_time_string, Fcurrent_time_string)
2308 (Fcurrent_time_zone): Accept and generate higher-resolution
2309 time stamps.
2310 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2311 (decode_time_components, lisp_seconds_argument): New functions.
2312 (make_time): Now static.
2313 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2314 Report an error if the time is invalid, rather than having the caller
2315 do that.
2316
2317 * fileio.c: Include <stat-time.h>
2318 (Fcopy_file): Copy higher-resolution time stamps.
2319 Prefer to set the time stamp via a file descriptor if that works.
2320 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2321 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2322 (Fvisited_file_modtime, Fset_visited_file_modtime):
2323 Support higher-resolution time stamps.
2324
2325 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2326
2327 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2328
2329 * image.c (prepare_image_for_display, clear_image_cache)
2330 (lookup_image): Port to higer-resolution time stamps.
2331
2332 * keyboard.c (start_polling, bind_polling_period):
2333 Check for time stamp overflow.
2334 (read_char, kbd_buffer_get_event, timer_start_idle)
2335 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2336 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2337 Port to higher-resolution time stamps. Do not assume time_t is signed.
2338 (decode_timer): New function. Timers are now vectors of length 9,
2339 not 8, to accommodate the picosecond component.
2340 (timer_check_2): Use it.
2341
2342 * nsterm.m (select_timeout, timeval_subtract): Remove.
2343 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2344 as they're a bit more accurate and handle overflow better.
2345 (ns_select): Change prototype to be compatible with pselect.
2346 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2347 * nsterm.h (ns_select): Adjust prototype.
2348
2349 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2350 us-resolution time stamps.
2351 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2352
2353 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2354
2355 * lisp.h (time_overflow): New decl.
2356 (wait_reading_process_output): First arg is now intmax_t, not int,
2357 to accommodate larger waits.
2358
2359 * process.h (struct Lisp_Process.read_output_delay):
2360 Now counts nanoseconds, not microseconds.
2361 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2362 EMACS_HAS_USECS.
2363 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2364 (wait_reading_process_output):
2365 Port to ns-resolution time stamps.
2366 (Faccept_process_output, wait_reading_process_output):
2367 Check for time stamp overflow. Do not assume time_t is signed.
2368 (select_wrapper): Remove; we now use pselect.
2369 (Fprocess_attributes): Now generates ns-resolution time stamps.
2370
2371 * sysdep.c: Include utimens.h. Don't include utime.h
2372 or worry about struct utimbuf; gnulib does that for us now.
2373 (gettimeofday): Remove; gnulib provides a substitute.
2374 (make_timeval): New function.
2375 (set_file_times): Now sets ns-resolution time stamps.
2376 New arg FD; all uses changed.
2377 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2378 (system_process_attributes):
2379 Now returns ns-resolution time stamp. All uses changed.
2380 Check for time stamp overflow.
2381
2382 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2383 provides a substitute now.
2384
2385 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2386 since it guarantees struct timespec.
2387 (EMACS_TIME): Now struct timespec, so that we can support
2388 ns-resolution time stamps.
2389 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2390 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2391 (EMACS_USECS): Remove.
2392 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2393 so multiply the arg by 1000 before storing it.
2394 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2395 New macros.
2396 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2397 Port to ns-resolution time stamps.
2398 (EMACS_TIME_NEG_P): Remove; replaced by....
2399 (EMACS_TIME_SIGN): New macro.
2400 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2401 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2402 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2403 (make_timeval, make_lisp_time, decode_time_components): New decls.
2404 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2405 that it mishandled time_t overflow. You can't compare by subtracting!
2406 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2407 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2408
2409 * term.c: Include <sys/time.h>.
2410 (timeval_to_Time): New function, for proper overflow wraparound.
2411 (term_mouse_position, term_mouse_click): Use it.
2412
2413 * undo.c (record_first_change): Support higher-resolution time stamps
2414 in the undo buffer.
2415 (Fprimitive_undo): Use them when restoring time stamps.
2416
2417 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2418 (w32_get_internal_run_time):
2419 Port to higher-resolution Emacs time stamps.
2420 (ltime): Now accepts single 64-bit integer, as that's more convenient
2421 for callers.
2422
2423 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2424
2425 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2426 for compatibility with pselect. Support ns-resolution time stamps.
2427
2428 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2429
2430 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2431 Check for time stamp overflow, and support ns-resolution time stamps.
2432
2433 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2434 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2435 (timeval_subtract): Remove; no longer needed.
2436 (XTflash, XTring_bell, x_wait_for_event):
2437 Port to ns-resolution time stamps. Don't assume time_t is signed.
2438
b6a92dfe
CY
24392012-06-22 Chong Yidong <cyd@gnu.org>
2440
2441 * xdisp.c (x_consider_frame_title): Revert last change.
2442
d251c37c
EZ
24432012-06-22 Eli Zaretskii <eliz@gnu.org>
2444
2445 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2446 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2447 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2448 staticidx goes up to 1597 out of 1600 = 0x640.)
2449
f10deafb
PE
24502012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2451
2452 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2453 Otherwise, the umask might be mistakenly 0 while handling input signals.
2454
ec6de1e2
SM
24552012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2456
2457 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2458
28be1ada
DA
24592012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2460
2461 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2462 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2463 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2464 access to `contents' member of Lisp_Vector objects with AREF and ASET
2465 where appropriate.
2466
c6bf3022
CY
24672012-06-19 Chong Yidong <cyd@gnu.org>
2468
2469 * frame.c (delete_frame): When selecting a frame on a different
2470 text terminal, do not alter the terminal's top-frame.
2471
2472 * xdisp.c (format_mode_line_unwind_data): Record the target
2473 frame's selected window and its terminal's top-frame.
2474 (unwind_format_mode_line): Restore them.
2475 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2476 Callers changed.
2477 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2478 since tty frames can be explicitly named.
2479 (prepare_menu_bars): Likewise.
2480
2481 * term.c (Ftty_top_frame): New function.
2482
defd4196
PE
24832012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2484
2485 Port byte-code-meter to modern targets.
2486 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2487 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2488 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2489 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2490 (METER_1, METER_2): Simplify.
2491
1053a871
SM
24922012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2493
2494 * data.c (Fdefalias): Return `symbol' (bug#11686).
2495
b7e8d081
MR
24962012-06-18 Martin Rudalics <rudalics@gmx.at>
2497
2498 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2499 gets killed during executing of this function (Bug#11665).
2500 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2501 (Vkill_buffer_query_functions): In doc-string say that functions
2502 run by this hook should not change the current buffer.
2503
7ea2b339
PE
25042012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2505
2506 Fix recently-introduced process.c problems found by static checking.
2507 * process.c (write_queue_push, write_queue_pop, send_process):
2508 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2509 (write_queue_pop): Fix pointer signedness problem.
2510 (send_process): Remove unused local.
2511
96a313a1
CY
25122012-06-17 Chong Yidong <cyd@gnu.org>
2513
2514 * xdisp.c (redisplay_internal): No need to redisplay terminal
2515 frames that are not on top.
2516
20ca2e94
TN
25172012-06-17 Troels Nielsen <bn.troels@gmail.com>
2518
2519 * process.c (make_process): Initialize write_queue.
2520 (write_queue_push, write_queue_pop): New functions.
2521 (send_process): Use them to maintain correct ordering of process
2522 writes (Bug#10815).
2523
9a900ca9
PE
25242012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2525
310fbfa8
PE
2526 * lisp.h (eassert): Assume C89 or later.
2527 This removes the need for CHECK.
2528 (CHECK): Remove. Its comments about always evaluating its
2529 argument were confusing, as 'eassert' typically does not evaluate
2530 its argument.
2531
27bb1ca4
PE
2532 * coding.c (produce_chars): Use ptrdiff_t, not int.
2533
9a900ca9
PE
2534 * xterm.c (x_draw_underwave): Check for integer overflow.
2535 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2536
41b7f8bc 25372012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2538
2539 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2540 referenced (Bug#11583).
2541
9b0e3eba
AA
25422012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2543
2544 Implement wave-style variant of underlining.
2545 * dispextern.h (face_underline_type): New enum.
2546 (face): Add field for underline type.
2547 * nsterm.m (ns_draw_underwave): New function.
2548 (ns_draw_text_decoration): Use it.
2549 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2550 New functions.
2551 (x_draw_glyph_string): Use them.
2552 * xfaces.c (Qline, Qwave): New Lisp objects.
2553 (check_lface_attrs, merge_face_ref)
1053a871
SM
2554 (Finternal_set_lisp_face_attribute, realize_x_face):
2555 Handle wave-style underline face attributes.
9b0e3eba
AA
2556 * xterm.c (x_draw_underwave): New function.
2557 (x_draw_glyph_string): Use it.
2558
0fb52f11
JB
25592012-06-16 Juanma Barranquero <lekktu@gmail.com>
2560
2561 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2562 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2563 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2564 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2565 ($(BLD)/w32select.$(O)): Update dependencies.
2566
e5560ff7
AS
25672012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2568
2569 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2570 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2571 * character.c (_fetch_multibyte_char_p): Remove.
2572 * alloc.c: Include "character.h" before "buffer.h".
2573 * bidi.c: Likewise.
2574 * buffer.c: Likewise.
2575 * bytecode.c: Likewise.
2576 * callint.c: Likewise.
2577 * callproc.c: Likewise.
2578 * casefiddle.c: Likewise.
2579 * casetab.c: Likewise.
2580 * category.c: Likewise.
2581 * cmds.c: Likewise.
2582 * coding.c: Likewise.
2583 * composite.c: Likewise.
2584 * dired.c: Likewise.
2585 * dispnew.c: Likewise.
2586 * doc.c: Likewise.
2587 * dosfns.c: Likewise.
2588 * editfns.c: Likewise.
2589 * emacs.c: Likewise.
2590 * fileio.c: Likewise.
2591 * filelock.c: Likewise.
2592 * font.c: Likewise.
2593 * fontset.c: Likewise.
2594 * fringe.c: Likewise.
2595 * indent.c: Likewise.
2596 * insdel.c: Likewise.
2597 * intervals.c: Likewise.
2598 * keyboard.c: Likewise.
2599 * keymap.c: Likewise.
2600 * lread.c: Likewise.
2601 * macros.c: Likewise.
2602 * marker.c: Likewise.
2603 * minibuf.c: Likewise.
2604 * nsfns.m: Likewise.
2605 * nsmenu.m: Likewise.
2606 * print.c: Likewise.
2607 * process.c: Likewise.
2608 * regex.c: Likewise.
2609 * region-cache.c: Likewise.
2610 * search.c: Likewise.
2611 * syntax.c: Likewise.
2612 * term.c: Likewise.
2613 * textprop.c: Likewise.
2614 * undo.c: Likewise.
2615 * unexsol.c: Likewise.
2616 * w16select.c: Likewise.
2617 * w32fns.c: Likewise.
2618 * w32menu.c: Likewise.
2619 * window.c: Likewise.
2620 * xdisp.c: Likewise.
2621 * xfns.c: Likewise.
2622 * xmenu.c: Likewise.
2623 * xml.c: Likewise.
2624 * xselect.c: Likewise.
2625
2f07e6af
EZ
26262012-06-16 Eli Zaretskii <eliz@gnu.org>
2627
1053a871
SM
2628 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2629 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2630 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2631 row.
2632 (handle_face_prop): Use chunk-relative overlay string index when
2633 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2634 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2635 the rightmost. (Bug#11720)
2f07e6af 2636
29b83cec
AS
26372012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2638
2639 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2640 (CATEGORY_MEMBER): Enforce 1/0 value.
2641 * category.c (_temp_category_set): Remove.
2642
4c5501e9
EZ
26432012-06-16 Eli Zaretskii <eliz@gnu.org>
2644
2645 * window.c (Fdelete_other_windows_internal)
2646 (Fdelete_window_internal): Don't access frame's mouse highlight
2647 info of the initial frame. (Bug#11677)
2648
2b570124
PE
26492012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2650
e93864f9
PE
2651 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2652 Assume USE_2_TAGS_FOR_INTS.
2653 (xreload): Adjust $tagmask width to match recent lisp.h change.
2654
2b570124
PE
2655 Simplify lisp.h in minor ways that should not affect code.
2656 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2657 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2658 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2659 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2660 (INTTYPEBITS): New macro, for clarity.
2661 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2662 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2663 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2664 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2665 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2666
81755f69
JB
26672012-06-13 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2670
16192a57
GM
26712012-06-13 Glenn Morris <rgm@gnu.org>
2672
2673 * s/bsd-common.h (BSD4_3):
2674 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2675
646b5f55
AS
26762012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2677
2678 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2679 instead of union.
2680 (XLI, XIL): Define.
1053a871
SM
2681 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2682 Use them.
2683 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2684 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2685 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2686 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2687 * frame.c (delete_frame): Remove outdated comment.
2688 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2689 USE_LISP_UNION_TYPE.
2690 (Fw32_unregister_hot_key): Likewise.
2691 (Fw32_toggle_lock_key): Likewise.
2692 * w32menu.c (add_menu_item): Likewise.
2693 (w32_menu_display_help): Use XIL instead of checking
2694 USE_LISP_UNION_TYPE.
2695 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2696 (init_heap): Likewise.
2697 * w32term.c (w32_read_socket): Update comment.
2698
1d3823c9
GM
26992012-06-13 Glenn Morris <rgm@gnu.org>
2700
c62ff706
GM
2701 * s/usg5-4-common.h, src/s/unixware.h:
2702 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2703
1d3823c9
GM
2704 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2705
bfe3e0a2
PE
27062012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2707
2708 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2709 * alloc.c (make_number) [!defined make_number]:
2710 Remove, as lisp.h always defines this now.
2711 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2712 (roundup_size): Verify that it is a power of 2.
2713 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2714 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2715 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2716 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2717 USE_LSB_TAG now is always defined to be either 0 or 1.
2718 All uses changed.
2719 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2720 code works fine either way, and efficiency is not a concern here,
2721 as the union type is for debugging, not for production.
2722 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2723 Use an inline function on all platforms when using the union type,
2724 since this is simpler and 'static inline' can be used portably
2725 within Emacs now.
2726 (LISP_INITIALLY_ZERO): New macro.
2727 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2728 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2729
45fa9c0f
GM
27302012-06-12 Glenn Morris <rgm@gnu.org>
2731
b4492cba
GM
2732 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2733
2734 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2735
45fa9c0f
GM
2736 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2737 Move BROKEN_SIGIO to configure.
2738
2739 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2740 Move NO_TERMIO to configure.
2741
0e25d334
CY
27422012-06-12 Chong Yidong <cyd@gnu.org>
2743
2744 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2745 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2746 MagickExportImagePixels is undefined.
2747
43682bb6
PE
27482012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2749
2750 * image.c (imagemagick_load_image): Remove unused label.
2751
a9be7d2b
GM
27522012-06-11 Glenn Morris <rgm@gnu.org>
2753
2754 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2755 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2756 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2757 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2758
3017f87f
SM
27592012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2760
2761 * alloc.c (make_byte_code): New function.
2762 (Fmake_byte_code): Use it. Don't purify here.
2763 * lread.c (read1): Use it as well to avoid extra allocation.
2764
1b9b4cf4
CY
27652012-06-11 Chong Yidong <cyd@gnu.org>
2766
2767 * image.c (imagemagick_load_image): Implement transparency.
2768
95988fcf
AS
27692012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2770
2771 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2772 account for preceding backslashes. (Bug#11663)
2773
cd4eb164
CY
27742012-06-09 Chong Yidong <cyd@gnu.org>
2775
2776 * term.c: Support italics in capable terminals (Bug#9652).
2777 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2778 (turn_on_face): Output using TS_enter_italic_mode if available.
2779 Don't handle unused blinking and alt-charset cases.
2780 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2781 and tty_alt_charset_p cases.
2782 (tty_capable_p, init_tty): Support italics.
2783
2784 * termchar.h (struct tty_display_info): Add field for italics.
2785 Remove unused blink field.
2786
2787 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2788 Handle slant.
2789
2790 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2791 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2792 tty_alt_charset_p. Add tty_italic_p.
2793
ff88beb8
MA
27942012-06-09 Michael Albinus <michael.albinus@gmx.de>
2795
2796 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2797 dbus_type_is_basic if available.
2798 (xd_extract_signed, xd_extract_unsigned): Rename from
2799 extract_signed and extract_unsigned, respectively. Adapt callers.
2800
44286096
CY
28012012-06-09 Chong Yidong <cyd@gnu.org>
2802
1682701f
CY
2803 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2804
44286096
CY
2805 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2806 case (Bug#9752).
2807
d86feb17
PE
28082012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2809
2810 * xdisp.c (vmessage): Treat frame message as multibyte.
2811 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2812 would generate the diagnostic "Making \302\247 buffer-local while
2813 let-bound!".
2814
d5c20fe8
EZ
28152012-06-08 Eli Zaretskii <eliz@gnu.org>
2816
2817 * dispnew.c (showing_window_margins_p): Undo last change, which
2818 was done due to an inadvertent commit.
2819 (adjust_frame_glyphs_for_frame_redisplay): Do call
2820 showing_window_margins_p.
2821
513749ee
SM
28222012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2823
2824 * eval.c (Fmake_var_non_special): New primitive.
2825 (syms_of_eval): Defsubr it.
2826 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2827
d4a8f5c1
JB
28282012-06-08 Juanma Barranquero <lekktu@gmail.com>
2829
2830 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2831 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2832
8bbbc977
EZ
28332012-06-08 Eli Zaretskii <eliz@gnu.org>
2834
2835 * alloc.c (allocate_vectorlike): Fix last change.
2836
f3372c87
DA
28372012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2838
2839 Block-based vector allocation of small vectors.
2840 * lisp.h (struct vectorlike_header): New field `nbytes',
2841 adjust comment accordingly.
2842 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2843 to denote vector blocks. Adjust users (live_vector_p,
2844 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2845 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2846 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2847 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2848 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2849 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2850 (roundup_size): New constant.
2851 (struct vector_block): New data type.
2852 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2853 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2854 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2855 (sweep_vectors): New functions.
2856 (allocate_vectorlike): Return `zero_vector' as the only vector of
2857 0 items. Allocate new vector from block if vector size is less than
2858 or equal to VBLOCK_BYTES_MAX.
2859 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2860 (init_alloc_once): Add call to init_vectors.
2861
4f18a4ed
SM
28622012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2863
2864 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2865
86f158bc
PE
28662012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2867
2868 * doprnt.c (doprnt): Truncate multibyte char correctly.
2869 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2870 would mishandle a string argument "Xc" if X was a multibyte
2871 character of length 2: it would truncate after X's first byte
2872 rather than including all of X.
2873
c5cfcbe0
CY
28742012-06-06 Chong Yidong <cyd@gnu.org>
2875
2876 * buffer.c (word_wrap): Doc fix.
2877
c05cf390
PE
28782012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2879
2880 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2881
0c3461de
GM
28822012-06-03 Glenn Morris <rgm@gnu.org>
2883
2884 * xdisp.c (tool-bar-style): Doc fix.
2885
c71232db
UM
28862012-06-03 Ulrich Müller <ulm@gentoo.org>
2887
2888 * Makefile.in (PAXCTL): Define.
2889 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2890 binary via PaX flags if the paxctl utility is available.
2891 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2892 Restore PaX flags to their default. (Bug#11398)
2893
383f7350
CY
28942012-06-03 Chong Yidong <cyd@gnu.org>
2895
2896 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2897 buffer (Bug#11226).
2898
5f2c76c6
CY
28992012-06-03 Chong Yidong <cyd@gnu.org>
2900
2901 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2902 (note_mode_line_or_margin_highlight): If there is no help echo,
2903 use mode-line-default-help-echo. Handle the case where the mouse
2904 position is past the end of the mode line string.
2905
2906 * buffer.c (buffer_local_value_1): New function, split from
2907 Fbuffer_local_value; can return Qunbound.
2908 (Fbuffer_local_value): Use it.
2909 (Vmode_line_format): Docstring tweaks.
2910
773d47f6
PE
29112012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2912
2913 * sysdep.c (system_process_attributes): Improve comment.
2914
f2d6a3df
SM
29152012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2916
2917 * keyboard.c: Export real-this-command to Elisp.
2918 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2919 and DEFVAR it. Update all users.
2920
63810350
PE
29212012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2922
7bd5c1f4
PE
2923 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2924
63810350
PE
2925 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2926 Convert pctcpu and pctmem to Lisp float properly.
2927 Let the compiler fold better, as 100.0/0x8000 is exact.
2928
a2821611
AS
29292012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2930
2931 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2932 cons_block.
2933
5fceba1d
PE
29342012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2935
2936 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2937
c98ff5dd
DA
29382012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2939
2940 For a 'struct window', replace some Lisp_Object fields to
2941 bitfields where appropriate, remove unused fields.
2942 * window.h (struct window): Remove unused 'last_mark_x' and
2943 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2944 change it's type from Lisp_Object to bitfield.
2945 Change type of 'force_start', 'optional_new_start',
2946 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2947 fields from Lisp_Object to bitfield. Adjust users accordingly.
2948
ca34e0be
PE
29492012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2950
2951 Pacify gcc -Wdouble-precision when using Xaw.
2952 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2953 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2954 Use 'float' consistently, rather than 'float' in most places
2955 and 'double' in a couple of places.
2956
efc00ab1 29572012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2958
2959 * xdisp.c (handle_stop): Detect whether we have overlay strings
2960 loaded by testing it->current.overlay_string_index to be
2961 non-negative, instead of checking whether n_overlay_strings is
2962 positive. (Bug#11587)
2963
efc00ab1 29642012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2965
2966 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2967
2968 * doc.c (Fsubstitute_command_keys): Doc fix.
2969
efc00ab1 29702012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2971
2972 * search.c (search_buffer): Remove calls to
2973 r_alloc_inhibit_buffer_relocation, as it is now called by
2974 maybe_unify_char, which was the cause of relocation of buffer text
2975 in bug#11519.
2976
efc00ab1 29772012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2978
2979 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2980 for the duration of call to load_charset, to avoid problems with
2981 callers of maybe_unify_char that access buffer text through C
2982 pointers.
2983
2984 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2985 decrement the inhibition flag, instead of just setting or
2986 resetting it.
2987
ba93a187
PE
29882012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2989
2990 Remove obsolete '#define static' cruft.
2991 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2992 This #undef was "temporary" in 2000; it is no longer needed
2993 now that '#define static' has gone away.
2994 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2995 (gray_bitmap_bits): Remove; no longer needed.
2996 All uses replaced with definiens.
2997 * xterm.c: Include "bitmaps/gray.xbm".
2998
9e4bf381
PE
29992012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3000
3001 Clean up __executable_start, monstartup when --enable-profiling.
3002 The following changes affect the code only when profiling.
3003 * dispnew.c (__executable_start): Rename from safe_bcopy.
3004 Define only on platforms that need it.
3005 * emacs.c: Include <sys/gmon.h> when profiling.
3006 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3007 (__executable_start): Remove decl, since lisp.h does it now.
3008 (safe_bcopy): Remove decl; no longer has that name.
3009 (main): Coalesce #if into single bit of code, for simplicity.
3010 Cast pointers to uintptr_t, since standard libraries want integers
3011 and not pointers.
3012 * lisp.h (__executable_start): New decl.
3013
32d72c2f
GM
30142012-05-31 Glenn Morris <rgm@gnu.org>
3015
3016 * image.c (Fimagemagick_types): Doc fix.
3017
baac5bc7
JM
30182012-05-30 Jim Meyering <meyering@redhat.com>
3019
3020 * callproc.c (Fcall_process_region): Include directory component
3021 in mkstemp error message (Bug#11586).
3022
72cb32cf
PE
30232012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3024
3025 * alloc.c, lisp.h (make_pure_vector): Now static.
3026
61b108cc
SM
30272012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3028
3029 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3030 Move to byte-run.el.
3031 (Fautoload): Do the hash-doc more carefully.
3032 * data.c (Fdefalias): Purify definition, except for keymaps.
3033 (Qdefun): Move from eval.c.
3034 * lisp.h (Qdefun): Remove.
3035 * lread.c (read1): Tiny simplification.
3036
471fe23d
TN
30372012-05-29 Troels Nielsen <bn.troels@gmail.com>
3038
934f3f58 3039 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3040 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3041 Bug#9642, but explicitly check that the buffer the overlay would
3042 be moved to is live and rearrange lines to make sure that errors
3043 will not put the overlay in an inconsistent state.
3044 (Fdelete_overlay): Cosmetics.
3045
85d0efd1
EZ
30462012-05-28 Eli Zaretskii <eliz@gnu.org>
3047
3048 * w32term.c (my_bring_window_to_top): New function.
3049 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3050 could be different from the original one.
3051 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3052 (Bug#11513)
3053
3054 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3055 by calling BringWindowToTop.
3056
3057 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3058 (WM_EMACS_END): Increase by one.
3059
da92a98c
PE
30602012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3061
3062 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3063 This avoids undefined behavior that might cause the eassert
3064 to not catch an out-of-range value.
3065
74d1f848
JB
30662012-05-28 Juanma Barranquero <lekktu@gmail.com>
3067
3068 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3069 Update dependencies.
3070
9e1a06fc
EZ
30712012-05-27 Eli Zaretskii <eliz@gnu.org>
3072
3073 * bidi.c (bidi_mirror_char): Fix last change.
3074
f3dd7312
AS
30752012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3076
3077 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3078 when referring to sectname field in printf format.
3079
81899c91
PE
30802012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3081
57b81a9f
PE
3082 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3083 Only r_alloc_inhibit_buffer_relocation needed to be added;
3084 the others were already declared.
3085
81899c91
PE
3086 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3087 before checking whether it's out of range. Put the check inside
3088 eassert. See
3089 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3090
33017faf 30912012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3092
3093 * callproc.c (Fcall_process): Restore a line that was accidentally
3094 commented out in the 2011-02-13 change (bug#11547).
3095
33017faf 30962012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3097
3098 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3099 defined on ralloc.c.
3100
3101 * buffer.c [REL_ALLOC]: Remove prototypes of
3102 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3103 they are now on lisp.h.
3104
3105 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3106
3107 * search.c (search_buffer): Use it to inhibit relocation of buffer
3108 text while re_search_2 is doing its job, because re_search_2 is
3109 passed C pointers to buffer text. (Bug#11519)
3110
23415acf
EZ
3111 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3112 Update value to 24.
3113
44e27368
EZ
3114 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3115 state after an additional call to move_it_in_display_line_to, keep
3116 the values of it->max_ascent and it->max_descent found for the
3117 entire line.
3118 (pos_visible_p): Revert the comparison against bottom_y to what it
3119 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3120 (Bug#11464)
3121
c1892f11
PE
31222012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 Fix coding-related core dumps with gcc -ftrapv.
3125 The code was computing A - B, where A and B are pointers, and B is
3126 random garbage. This can lead to core dumps on platforms that
3127 have special pointer registers, and it also leads to core dumps on
3128 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3129 A - B only when B is initialized properly.
3130 * coding.c (coding_set_source, coding_set_destination): Return void.
3131 (coding_change_source, coding_change_destinations): New functions,
3132 with the old behaviors of coding_set_source and coding_set_destination.
3133 All callers that need an offset changed to use these new functions.
3134
eb7afdad
GM
31352012-05-26 Glenn Morris <rgm@gnu.org>
3136
3137 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3138
f12fdf02
EZ
31392012-05-26 Eli Zaretskii <eliz@gnu.org>
3140
53a63be6 3141 Extend mouse support on W32 text-mode console.
61b108cc
SM
3142 * xdisp.c (draw_row_with_mouse_face):
3143 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3144
eb3f6f01 3145 * w32console.c: Include window.h.
61b108cc
SM
3146 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3147 New functions.
eb3f6f01
EZ
3148 (initialize_w32_display): Initialize mouse-highlight data.
3149
53a63be6
EZ
3150 * w32inevt.c: Include termchar.h and window.h.
3151 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3152 moves, call note_mouse_highlight. If help_echo changed, call
3153 gen_help_event to produce help-echo message in the echo area.
3154 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3155 highlight info.
3156
4cfd81f6
PE
31572012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3158
3159 * lread.c (read1): Simplify slightly to avoid an overflow warning
3160 with GCC 4.7.0 on x86-64.
3161
4446092a
EZ
31622012-05-26 Eli Zaretskii <eliz@gnu.org>
3163
3164 * bidi.c (bidi_mirror_char): Revert last change: an int is
3165 definitely wide enough here.
3166
42b2a986 31672012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3168
42b2a986 3169 Fix integer width and related bugs (Bug#9874).
eb106a49 3170 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3171 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3172 (string_bytes, check_sblock, allocate_string_data):
3173 (compact_small_strings, Fmake_bool_vector, make_string)
3174 (make_unibyte_string, make_multibyte_string)
3175 (make_string_from_bytes, make_specified_string)
3176 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3177 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3178 (mark_vectorlike):
3179 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3180 (allocate_pseudovector):
3181 Use int, not EMACS_INT, where int is wide enough.
3182 (inhibit_garbage_collection, Fgarbage_collect):
3183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3184 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3185 int might not be wide enough.
3186 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3187 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3188 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3189 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3190 (bidi_level_of_next_char, bidi_move_to_visually_next):
3191 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3192 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3193 (Fkill_buffer, Fset_buffer_major_mode)
3194 (advance_to_char_boundary, Fbuffer_swap_text)
3195 (Fset_buffer_multibyte, overlays_at, overlays_in)
3196 (overlay_touches_p, struct sortvec, record_overlay_string)
3197 (overlay_strings, recenter_overlay_lists)
3198 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3199 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3200 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3201 (Foverlay_recenter, last_overlay_modification_hooks_used)
3202 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3203 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3204 (validate_region): Omit unnecessary test for b <= e,
3205 since that's guaranteed by the previous test.
d311d28c
PE
3206 (adjust_overlays_for_delete): Avoid pos + length overflow.
3207 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3208 (report_overlay_modification):
3209 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3210 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3211 Omit pointer cast, which isn't needed anyway, and doesn't work
3212 after the EMACS_INT -> ptrdiff_t change.
02481186 3213 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3214 * buffer.h: Adjust decls to match defn changes elsewhere.
3215 (struct buffer_text, struct buffer):
3216 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3217 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3218 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3219 not int, to avoid needless 32-bit limit on 64-bit hosts.
3220 (exec_byte_code): Use tighter memory-full test, one that checks
3221 for alloca overflow. Don't compute the address of the object just
3222 before an array, as that's not portable. Use EMACS_INT, not
3223 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3224 * callint.c (Fcall_interactively):
3225 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3226 * callproc.c (call_process_kill, Fcall_process):
3227 Don't assume pid_t fits into an Emacs fixnum.
3228 (call_process_cleanup, Fcall_process, child_setup):
3229 Don't assume pid_t fits into int.
3230 (call_process_cleanup, Fcall_process, delete_temp_file)
3231 (Fcall_process_region):
3232 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3233 (Fcall_process): Simplify handling of volatile integers.
3234 Use int, not EMACS_INT, where int will do.
3235 * casefiddle.c (casify_object, casify_region, operate_on_word)
3236 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3237 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3238 (casify_object): Avoid integer overflow when overallocating buffer.
3239 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3240 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3241 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3242 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3243 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3244 integers are now checked earlier. All uses replaced with XINT.
3245 (ccl_driver):
3246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3247 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3248 (ccl_driver, Fregister_code_conversion_map):
3249 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3250 (resolve_symbol_ccl_program): Check that vector header is in range.
3251 Always copy the vector, so that we can check its contents reliably
3252 now rather than having to recheck each instruction as it's being
3253 executed. Check that vector words fit in 'int'.
3254 (ccl_get_compiled_code, Fregister_ccl_program)
3255 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3256 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3257 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3258 contents are in range.
3259 (Fccl_execute_on_string): Check that status is in range.
3260 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3261 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3262 Accept and return EMACS_INT, not int, because callers can pass values
3263 out of 'int' range.
3264 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3265 (multibyte_chars_in_text, parse_str_as_multibyte)
3266 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3267 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3268 (string_escape_byte8, Fget_byte):
3269 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3270 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3271 avoid mishandling large integers.
3272 * character.h: Adjust decls to match defn changes elsewhere.
3273 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3274 (Ffind_charset_region):
3275 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3276 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3277 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3278 Don't assume fixnum fits in int.
d311d28c
PE
3279 (load_charset_map_from_vector, Fmap_charset_chars):
3280 Remove now-unnecessary CHECK_NATNUMs.
3281 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3282 Don't rely on undefined behavior with signed left shift overflow.
3283 Don't assume unsigned int fits into fixnum, or that fixnum fits
3284 into unsigned int. Don't require max_code to be a valid fixnum;
3285 that's not true for gb10830 4-byte on a 32-bit host. Allow
3286 invalid_code to be a cons, for the same reason. Require code_offset
3287 to be a character. Avoid int overflow if max_char is close
3288 to INT_MAX.
3289 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3290 this is intended anyway and avoids some undefined behavior.
3291 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3292 INDEX_TO_CODE_POINT, as that's what it expects.
3293 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3294 * charset.h (DECODE_CHAR): Return int, not unsigned;
3295 this is what was intended anyway, and it avoids undefined behavior.
3296 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3297 integer-overflow issues.
3298 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3299 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3300 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3301 * chartab.c (Fmake_char_table, Fset_char_table_range)
3302 (uniprop_get_decoder, uniprop_get_encoder):
3303 Don't assume fixnum fits in int.
3304 * cmds.c (move_point): New function, that does the gist of
3305 Fforward_char and Fbackward_char, but does so while checking
3306 for integer overflow more accurately.
c96e5d6a 3307 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3308 (Fforward_line, Fend_of_line, internal_self_insert)
3309 (internal_self_insert):
3310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3311 Fix a FIXME, by checking for integer overflow when calculating
3312 target_clm and actual_clm.
3313 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3314 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3315 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3316 (coding_alloc_by_making_gap, alloc_destination)
3317 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3318 (encode_coding_utf_16, detect_coding_emacs_mule)
3319 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3320 (detect_coding_iso_2022, decode_coding_iso_2022)
3321 (encode_invocation_designation, encode_designation_at_bol)
3322 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3323 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3324 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3325 (encode_coding_ccl, encode_coding_raw_text)
3326 (detect_coding_charset, decode_coding_charset)
3327 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3328 (produce_composition, produce_charset, produce_annotation)
3329 (decode_coding, handle_composition_annotation)
3330 (handle_charset_annotation, consume_chars, decode_coding_gap)
3331 (decode_coding_object, encode_coding_object, detect_coding_system)
3332 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3333 (code_convert_region, code_convert_string)
8f50130c
PE
3334 (Fdefine_coding_system_internal)
3335 (coding_set_source, coding_set_destination):
d311d28c
PE
3336 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3337 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3338 (Fdefine_coding_system_internal):
3339 Don't assume fixnums fit in int.
3340 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3341 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3342 (Funencodable_char_position, Fcheck_coding_systems_region)
3343 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3345 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3346 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3347 Don't access memory outside of the args array.
d311d28c 3348 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3349 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3350 result of ENCODE_CHAR.
d311d28c
PE
3351 * coding.h: Adjust decls to match defn changes elsewhere.
3352 (struct coding_system):
3353 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3354 * composite.c (get_composition_id, find_composition)
3355 (run_composition_function, update_compositions)
3356 (compose_text, composition_gstring_put_cache)
3357 (composition_gstring_p, composition_gstring_width)
3358 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3359 (composition_compute_stop_pos, composition_reseat_it)
3360 (composition_update_it, struct position_record)
3361 (find_automatic_composition, composition_adjust_point)
3362 (Fcomposition_get_gstring, Ffind_composition_internal):
3363 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3364 (update_compositions):
3365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3366 * composite.h: Adjust decls to match defn changes elsewhere.
3367 (struct composition):
3368 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3369 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3370 Do not attempt to compute the address of the object just before a
3371 buffer; this is not portable.
3372 (Faref, Faset):
3373 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3374 (Faset): Use int, not EMACS_INT, where int is wide enough.
3375 (Fstring_to_number): Don't assume fixnums fit in int.
3376 (Frem): Don't assume arg is nonnegative.
3377 * dbusbind.c (xd_append_arg): Check for integers out of range.
3378 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3379 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3380 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3381 (xd_get_connection_references): Return ptrdiff_t, not int.
3382 All uses changed.
3383 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3384 (xd_read_message_1):
3385 Use int, not unsigned, where the dbus API uses int.
3386 (Fdbus_message_internal): Don't overflow mtype.
3387 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3388 * dired.c (directory_files_internal, file_name_completion, scmp)
3389 (file_name_completion_stat):
3390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3391 (file_name_completion): Don't overflow matchcount.
3392 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3393 * dispextern.h: Adjust decls to match defn changes elsewhere.
3394 (struct text_pos, struct glyph, struct bidi_saved_info)
3395 (struct bidi_string_data, struct bidi_it, struct composition_it)
3396 (struct it):
3397 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3398 (struct display_pos, struct composition_it, struct it):
3399 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3400 * dispnew.c (increment_matrix_positions)
3401 (increment_row_positions, mode_line_string)
3402 (marginal_area_string):
3403 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3404 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3406 (duration_to_sec_usec): New function, to check for overflow better.
3407 (Fsleep_for, sit_for): Use it.
3408 * doc.c (get_doc_string, store_function_docstring):
3409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3410 (get_doc_string, Fsnarf_documentation):
3411 Use int, not EMACS_INT, where int is wide enough.
3412 (get_doc_string):
3413 Use SAFE_ALLOCA, not alloca.
3414 Check for overflow when converting EMACS_INT to off_t.
3415 * doprnt.c (doprnt):
3416 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3417 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3418 Don't assume uid_t fits into fixnum.
3419 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3420 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3421 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3422 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3423 (general_insert_function)
3424 (Finsert_char, make_buffer_string, make_buffer_string_both)
3425 (update_buffer_properties, Fbuffer_substring)
3426 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3427 (Fsubst_char_in_region, check_translation)
3428 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3429 (transpose_markers, Ftranspose_regions):
3430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3431 (clip_to_bounds): Move to lisp.h as an inline function).
3432 (Fconstrain_to_field): Don't assume integers are nonnegative.
3433 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3434 (Fsubst_char_in_region, Fsave_restriction):
3435 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3436 (Femacs_pid): Don't assume pid_t fits into fixnum.
3437 (lo_time): Use int, not EMACS_INT, when int suffices.
3438 (lisp_time_argument): Check for usec out of range.
3439 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3440 (Fuser_login_name, Fuser_full_name): Signal an error
3441 if a uid argument is out of range, rather than relying on
3442 undefined behavior.
c8d5c857
PE
3443 (Fformat_time_string): Remove now-unnecessary check.
3444 lisp_time_argument checks for out-of-range usec now.
243e0530 3445 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3446 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3447 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3448 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3449 (init_cmdargs, Fdump_emacs):
3450 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3451 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3452 the bottom (typically) 32 bits of the fixnum.
3453 * eval.c (specpdl_size, call_debugger):
3454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3455 (when_entered_debugger, Fbacktrace_debug):
3456 Don't assume fixnum can fit in int.
3457 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3458 the object just before a buffer; this is not portable.
3459 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3460 (grow_specpdl, unbind_to):
3461 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3462 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3463 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3464 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3465 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3466 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3467 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3468 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3469 (a_write, e_write):
3470 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3471 (Fcopy_file, non_regular_nbytes, read_non_regular)
3472 (Finsert_file_contents):
3473 Use int, not EMACS_INT, where int is wide enough.
3474 (READ_BUF_SIZE): Verify that it fits in int.
3475 (Finsert_file_contents): Check that counts are in proper range,
3476 rather than assuming fixnums fit into ptrdiff_t etc.
3477 Don't assume fixnums fit into int.
125b3835 3478 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3479 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3480 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3481 (string_char_to_byte, string_byte_to_char)
3482 (string_make_multibyte, string_to_multibyte)
3483 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3484 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3485 (substring_both, Fdelete, internal_equal, Ffillarray)
3486 (Fclear_string, mapcar1)
3487 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3488 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3489 (larger_vector, make_hash_table, maybe_resize_hash_table)
3490 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3491 (Fmaphash, secure_hash):
3492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3493 (concat): Check for string index and length overflow.
3494 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3495 (Frequire):
3496 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3497 (larger_vector): New API (vec, incr_min, size_max) replaces old
3498 one (vec, new_size, init). This catches size overflow.
3499 INIT was removed because it was always Qnil.
3500 All callers changed.
3501 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3502 the upper bound on a hash table index size.
3503 (make_hash_table, maybe_resize_hash_table): Use it.
3504 (secure_hash): Computer start_byte and end_byte only after
3505 they're known to be in ptrdiff_t range.
3506 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3507 (Ffont_get_glyphs, Ffont_at):
3508 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3509 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3510 (Flist_fonts, Fopen_font):
3511 Don't assume fixnum can fit in int.
3512 (check_gstring): Don't assume index can fit in int.
3513 (font_match_p): Check that fixnum is a character, not a nonnegative
3514 fixnum, since the later code needs to stuff it into an int.
3515 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3516 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3517 conversion overflow issues.
3518 (Fopen_font): Check for integer out of range.
3519 (Ffont_get_glyphs): Don't assume index can fit in int.
3520 * font.h: Adjust decls to match defn changes elsewhere.
3521 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3522 integer overflow.
3523 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3524 printmax_t, where ptrdiff_t is wide enough.
3525 (Finternal_char_font):
3526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3527 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3528 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3529 (Fset_frame_position, x_set_frame_parameters)
3530 (x_set_line_spacing, x_set_border_width)
3531 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3532 Check that fixnums are in proper range for system types.
3533 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3534 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3535 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3536 Use SAFE_ALLOCA_LISP, not alloca.
3537 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3538 intptr_t is wide enough.
3539 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3540 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3541 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3542 Check for fixnum out of range.
3543 * ftfont.c (ftfont_list): Don't assume index fits in int.
3544 Check that fixnums are in proper range for system types.
3545 (ftfont_shape_by_flt):
3546 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3547 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3548 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3549 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3550 Check that fixnums are in proper range for system types.
3551 * gnutls.h: Adjust decls to match defn changes elsewhere.
3552 * gtkutil.c (xg_dialog_run):
3553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3554 (update_frame_tool_bar):
3555 Check that fixnums are in proper range for system types.
3556 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3557 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3558 * indent.c (last_known_column, last_known_column_point):
3559 (current_column_bol_cache):
3560 (skip_invisible, current_column, check_display_width):
3561 (check_display_width, scan_for_column, current_column_1)
3562 (Findent_to, Fcurrent_indentation, position_indentation)
3563 (indented_beyond_p, Fmove_to_column, compute_motion):
3564 (Fcompute_motion, Fvertical_motion):
3565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3566 (last_known_column_modified): Use EMACS_INT, not int.
3567 (check_display_width):
3568 (Fcompute_motion):
3569 Check that fixnums and floats are in proper range for system types.
3570 (compute_motion): Don't assume index or fixnum fits in int.
3571 (compute_motion, Fcompute_motion):
3572 Use int, not EMACS_INT, when it is wide enough.
3573 (vmotion): Omit local var start_hpos that is always 0; that way
3574 we don't need to worry about overflow in expressions involving it.
3575 * indent.h: Adjust decls to match defn changes elsewhere.
3576 (struct position):
3577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3578 Use int, not EMACS_INT, where int is wide enough.
3579 Remove unused members ovstring_chars_done and tab_offset;
3580 all uses removed.
3581 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3582 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3583 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3584 (make_gap, copy_text, insert, insert_and_inherit)
3585 (insert_before_markers, insert_before_markers_and_inherit)
3586 (insert_1, count_combining_before, count_combining_after)
3587 (insert_1_both, insert_from_string)
3588 (insert_from_string_before_markers, insert_from_string_1)
3589 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3590 (adjust_after_replace, adjust_after_insert, replace_range)
3591 (replace_range_2, del_range, del_range_1, del_range_byte)
3592 (del_range_both, del_range_2, modify_region)
3593 (prepare_to_modify_buffer, signal_before_change)
3594 (signal_after_change, Fcombine_after_change_execute):
3595 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3596 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3597 (balance_an_interval, split_interval_right, split_interval_left)
3598 (find_interval, next_interval, update_interval)
3599 (adjust_intervals_for_insertion, delete_node, delete_interval)
3600 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3601 (static_offset_intervals, offset_intervals)
3602 (merge_interval_right, merge_interval_left, make_new_interval)
3603 (graft_intervals_into_buffer, temp_set_point_both)
3604 (temp_set_point, set_point, adjust_for_invis_intang)
3605 (set_point_both, move_if_not_intangible, get_property_and_range)
3606 (get_local_map, copy_intervals, copy_intervals_to_string)
3607 (compare_string_intervals, set_intervals_multibyte_1):
3608 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3609 * intervals.h: Adjust decls to match defn changes elsewhere.
3610 (struct interval):
3611 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3612 * keyboard.c (this_command_key_count, this_single_command_key_start)
3613 (before_command_key_count, before_command_echo_length, echo_now)
3614 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3615 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3616 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3617 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3618 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3619 (last_non_minibuf_size, last_point_position, echo_truncate)
3620 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3621 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3622 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3623 (stuff_buffered_input):
3624 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3625 (last_auto_save, command_loop_1, read_char):
3626 Use EMACS_INT, not int, to avoid integer overflow.
3627 (record_char): Avoid overflow in total_keys computation.
3628 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3629 * keyboard.h: Adjust decls to match defn changes elsewhere.
3630 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3631 (Fkey_description, Fdescribe_vector, Flookup_key):
3632 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3633 (click_position): New function, to check that positions are in range.
3634 (Fcurrent_active_maps):
3635 (describe_command):
3636 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3637 (Faccessible_keymaps, Fkey_description):
3638 (preferred_sequence_p):
3639 Don't assume fixnum can fit into int.
3640 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3641 Check for integer overflow in size calculations.
3642 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3643 avoid mishandling large integers.
3644 * lisp.h: Adjust decls to match defn changes elsewhere.
3645 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3646 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3647 (struct Lisp_Marker):
3648 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3649 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3650 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3651 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3652 All callers changed.
3653 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3654 Assume the arg has valid form, since it always does.
3655 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3656 unsigned integer system type.
3657 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3658 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3659 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3660 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3661 (duration_to_sec_usec): New decl.
3662 * lread.c (read_from_string_index, read_from_string_index_byte)
3663 (read_from_string_limit, readchar, unreadchar, openp)
3664 (read_internal_start, read1, oblookup):
3665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3666 (Fload, readevalloop, Feval_buffer, Feval_region):
3667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3668 (openp): Check for out-of-range argument to 'access'.
3669 (read1): Use int, not EMACS_INT, where int is wide enough.
3670 Don't assume fixnum fits into int.
6efdadfd 3671 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3672 (read_filtered_event): Use duration_to_sec_usec
3673 to do proper overflow checking on durations.
d311d28c
PE
3674 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3675 in size calculation.
3676 (Fexecute_kbd_macro):
3677 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3678 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3679 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3680 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3681 (set_marker_both, set_marker_restricted_both, marker_position)
3682 (marker_byte_position, Fbuffer_has_markers_at):
3683 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3684 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3685 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3686 It now merely ensures that the menu is large enough, without
3687 necessarily growing it, as this avoids some integer overflow issues.
3688 All callers changed.
3689 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3690 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3691 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3692 Use SAFE_ALLOCA_LISP, not alloca.
3693 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3694 to EMACS_INT. Check that fixnums are in proper range for system types.
3695 * minibuf.c (minibuf_prompt_width, string_to_object)
3696 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3697 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3699 (get_minibuffer, read_minibuf_unwind):
3700 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3701 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3702 this simplifies overflow checking. All callers changed.
3703 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3704 (Ftest_completion):
3705 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3706 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3707 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3708 Check that fixnums are in proper range for system types.
3709 (Fx_create_frame, Fx_show_tip):
3710 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3711 * nsfont.m (ns_findfonts, nsfont_list_family):
3712 Don't assume fixnum fits in long.
3713 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3714 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3715 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3716 wide enough.
17fdb222 3717 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3718 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3719 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3720 (PRINTDECLARE, PRINTPREPARE):
3721 (strout, print_string):
3722 (print, print_preprocess, print_check_string_charset_prop)
3723 (print_object):
3724 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3725 (PRINTDECLARE):
3726 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3727 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3728 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3729 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3730 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3731 (print_error_message): Use SAFE_ALLOCA, not alloca.
3732 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3733 (print_depth, new_backquote_output, print_number_index):
3734 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3735 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3736 (Fset_process_window_size, Fformat_network_address)
3737 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3738 (sigchld_handler):
d311d28c 3739 Check that fixnums are in proper range for system types.
d44287d4 3740 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3741 Check for process-ids out of pid_t range rather than relying on
3742 undefined behavior.
e4d81efc 3743 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3744 (Fformat_network_address, read_process_output, send_process)
3745 (Fprocess_send_region, status_notify):
3746 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3747 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3748 (wait_reading_process_output, read_process_output, exec_sentinel):
3749 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3750 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3751 (Faccept_process_output): Use duration_to_sec_usec to do proper
3752 overflow checking on durations.
dde14581
PE
3753 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3754 Don't assume pid_t fits in int.
02481186
PE
3755 * process.h (struct Lisp_Process): Members tick and update_tick
3756 are now of type EMACS_INT, not int.
b62b53e8
PE
3757 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3758 configured --with-wide-int.
d311d28c
PE
3759 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3760 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3761 * search.c (looking_at_1, string_match_1):
3762 (fast_string_match, fast_c_string_match_ignore_case)
3763 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3764 (scan_newline, find_before_next_newline, search_command)
3765 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3766 (set_search_regs, wordify):
3767 (Freplace_match):
3768 (Fmatch_data):
3769 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3770 (string_match_1, search_buffer, set_search_regs):
3771 (Fmatch_data):
3772 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3773 (wordify): Check for overflow in size calculation.
3774 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3775 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3776 Check that fixnums are in proper range for system types.
3777 * sound.c (struct sound_device)
3778 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3779 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3780 (Fplay_sound_internal):
3781 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3782 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3783 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3784 (Fparse_partial_sexp):
3785 Don't assume fixnums can fit in int.
3786 (struct lisp_parse_state, find_start_pos, find_start_value)
3787 (find_start_value_byte, find_start_begv)
3788 (update_syntax_table, char_quoted, dec_bytepos)
3789 (find_defun_start, prev_char_comend_first, back_comment):
3790 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3791 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3792 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3793 (Finternal_describe_syntax_value): Check that match_lisp is a
3794 character, not an integer, since the code stuffs it into int.
3795 (scan_words, scan_sexps_forward):
3796 Check that fixnums are in proper range for system types.
3797 (Fforward_word):
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3799 (scan_sexps_forward):
3800 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3801 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3802 * syntax.h: Adjust decls to match defn changes elsewhere.
3803 (struct gl_state_s):
3804 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3805 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3806 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3807 * sysdep.c (wait_for_termination_1, wait_for_termination)
3808 (interruptible_wait_for_termination, mkdir):
3809 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3810 (emacs_read, emacs_write):
3811 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3812 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3813 and double all fit in int.
d311d28c
PE
3814 * term.c (set_tty_color_mode):
3815 Check that fixnums are in proper range for system types.
3816 * termhooks.h (struct input_event):
3817 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3818 * textprop.c (validate_interval_range, interval_of)
3819 (Fadd_text_properties, set_text_properties_1)
3820 (Fremove_text_properties, Fremove_list_of_text_properties)
3821 (Ftext_property_any, Ftext_property_not_all)
3822 (copy_text_properties, text_property_list, extend_property_ranges)
3823 (verify_interval_modification):
3824 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3825 (Fnext_single_char_property_change)
3826 (Fprevious_single_char_property_change):
3827 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3828 (copy_text_properties):
3829 Check for integer overflow in index calculation.
d311d28c
PE
3830 * undo.c (last_boundary_position, record_point, record_insert)
3831 (record_delete, record_marker_adjustment, record_change)
3832 (record_property_change):
3833 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3834 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3836 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3837 (Fx_hide_tip, Fx_file_dialog):
3838 * w32menu.c (set_frame_menubar):
3839 Use ptrdiff_t, not int, for consistency with rest of code.
3840 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3841 (select_window, Fdelete_other_windows_internal)
3842 (window_scroll_pixel_based, window_scroll_line_based)
3843 (Frecenter, Fset_window_configuration):
3844 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3845 (Fset_window_hscroll, run_window_configuration_change_hook)
3846 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3847 (Fscroll_other_window, Frecenter):
d311d28c
PE
3848 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3849 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3850 Don't assume fixnum fits in int.
3851 (Fset_window_scroll_bars):
3852 Check that fixnums are in proper range for system types.
3853 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3854 (string_pos, c_string_pos, number_of_chars, init_iterator)
3855 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3856 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3857 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3858 (face_before_or_after_it_pos, handle_invisible_prop)
3859 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3860 (display_prop_intangible_p, string_buffer_position_lim)
3861 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3862 (get_overlay_strings_1, get_overlay_strings)
3863 (iterate_out_of_display_property, forward_to_next_line_start)
3864 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3865 (get_next_display_element, set_iterator_to_next)
3866 (get_visually_first_element, compute_stop_pos_backwards)
3867 (handle_stop_backwards, next_element_from_buffer)
3868 (move_it_in_display_line_to, move_it_in_display_line)
3869 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3870 (add_to_log, message_dolog, message_log_check_duplicate)
3871 (message2, message2_nolog, message3, message3_nolog
3872 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3873 (current_message_1, truncate_echo_area, truncate_message_1)
3874 (set_message, set_message_1, store_mode_line_noprop)
3875 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3876 (text_outside_line_unchanged_p, check_point_in_composition)
3877 (reconsider_clip_changes)
3878 (redisplay_internal, set_cursor_from_row, try_scrolling)
3879 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3880 (redisplay_window, find_last_unchanged_at_beg_row)
3881 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3882 (trailing_whitespace_p, find_row_edges, display_line)
3883 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3884 (display_mode_element, store_mode_line_string)
3885 (pint2str, pint2hrstr, decode_mode_spec)
3886 (display_count_lines, display_string, draw_glyphs)
3887 (x_produce_glyphs, x_insert_glyphs)
3888 (rows_from_pos_range, mouse_face_from_buffer_pos)
3889 (fast_find_string_pos, mouse_face_from_string_pos)
3890 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3891 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3892 (safe_call, init_from_display_pos, handle_fontified_prop)
3893 (handle_single_display_spec, load_overlay_strings)
3894 (with_echo_area_buffer, setup_echo_area_for_printing)
3895 (display_echo_area, echo_area_display)
3896 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3897 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3898 (redisplay_window, dump_glyph_row, display_mode_line)
3899 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3900 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3902 (handle_single_display_spec, build_desired_tool_bar_string)
3903 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3904 (get_specified_cursor_type):
3905 Check that fixnums are in proper range for system types.
3906 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3907 (Flookup_image_map):
3908 Don't assume fixnums fit in int.
3909 (compare_overlay_entries):
3910 Avoid mishandling comparisons due to subtraction overflow.
3911 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3912 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3913 (handle_tool_bar_click):
3914 Use int, not unsigned, since we prefer signed and the signedness
3915 doesn't matter here.
3916 (get_next_display_element, next_element_from_display_vector):
3917 Use int, not EMACS_INT, when int is wide enough.
3918 (start_hourglass): Use duration_to_sec_usec to do proper
3919 overflow checking on durations.
3920 * xfaces.c (Fbitmap_spec_p):
3921 Check that fixnums are in proper range for system types.
3922 (compare_fonts_by_sort_order):
3923 Avoid mishandling comparisons due to subtraction overflow.
3924 (Fx_family_fonts, realize_basic_faces):
3925 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3926 (Fx_family_fonts):
3927 Don't assume fixnum fits in int.
3928 Use SAFE_ALLOCA_LISP, not alloca.
3929 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3930 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3931 (face_at_buffer_position, face_for_overlay_string)
3932 (face_at_string_position):
3933 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3934 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3935 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3936 (Fx_show_tip):
3937 Check that fixnums are in proper range for system types.
3938 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3939 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3940 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3941 (Fx_change_window_property): Don't assume fixnums fit in int.
3942 * xfont.c (xfont_chars_supported):
3943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3944 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3945 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3946 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3947 * xml.c (parse_region):
3948 * xrdb.c (magic_file_p):
3949 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3950 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3951 (x_get_local_selection, x_reply_selection_request)
3952 (x_handle_selection_request, wait_for_property_change):
3953 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3954 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3955 short is wide enough.
3956 (x_send_client_event): Don't assume fixnum fits in int.
3957 * xterm.c (x_x_to_emacs_modifiers):
3958 Don't assume EMACS_INT overflows nicely into int.
3959 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3960 may come from Lisp.
3961 (handle_one_xevent): NATNUMP can eval its arg twice.
3962 (x_connection_closed):
3963 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3964 * xterm.h: Adjust decls to match defn changes elsewhere.
3965 (struct scroll_bar): Use struct vectorlike_header
3966 rather than rolling our own approximation.
3967 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3968
c6574eb5
GM
39692012-05-25 Glenn Morris <rgm@gnu.org>
3970
3971 * lisp.mk (lisp): Update for more files being compiled now.
3972
e8d32c7e
SM
39732012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3974
48def666
SM
3975 * lread.c: Remove `read_pure' which makes no difference.
3976 (read_pure): Remove var.
3977 (unreadpure): Remove function.
3978 (readevalloop): Don't call read_list with -1 flag.
3979 (read1, read_vector): Don't test read_pure any more.
3980 (read_list): Simplify.
3981
e8d32c7e
SM
3982 * fileio.c, character.h: Minor style tweaks.
3983
4b2addb7
DA
39842012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3985
3986 * window.h (clip_changed): Remove useless declaration.
3987
584461b2
JB
39882012-05-22 Juanma Barranquero <lekktu@gmail.com>
3989
3990 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3991 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3992
34374650
PE
39932012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3994
3995 Remove src/m/*.
3996 This directory predates autoconf and is no longer needed nowadays.
3997 Move its few remaining bits of functionality to where they're needed.
3998 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3999 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4000 * m/template.h: Remove.
4001 * Makefile.in (M_FILE): Remove. All uses removed.
4002 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4003 * lisp.h (USE_LSB_TAG):
4004 * mem-limits.h (EXCEEDS_LISP_PTR):
4005 Use VAL_MAX, not VALBITS, in #if.
4006 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4007 (EMACS_UINT): Define unconditionally now.
4008 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4009 (BITS_PER_EMACS_INT): New constants, replacing
4010 what used to be in config.h, but not useful in #if.
4011 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4012 define them any more.
4013 (VAL_MAX): New macro.
4014 (VALMASK): Use it.
4015 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4016 BITS_PER_EMACS_INT, in #if.
4017 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4018 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4019 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4020 * s/ms-w32.h (DATA_START):
4021 Move here from removed file m/intel386.h.
4022 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4023 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4024
261cb4bb
PE
40252012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4026
4027 Assume C89 or later.
4028 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4029 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4030 (xrealloc):
4031 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4032 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4033 * textprop.c, tparam.c (NULL): Remove.
4034 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4035 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4036 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4037 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4038 * xterm.c (input_signal_count): Assume volatile works.
4039
ff23cd9f
KB
40402012-05-21 Ken Brown <kbrown@cornell.edu>
4041
4042 * xgselect.c (xg_select): Fix first argument in call to 'select'
4043 (bug#11508).
4044
1b170bc6
KB
40452012-05-20 Ken Brown <kbrown@cornell.edu>
4046
4047 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4048 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4049
b2f4d39f
KB
40502012-05-19 Ken Brown <kbrown@cornell.edu>
4051
4052 * xfns.c (x_in_use): Remove `static' qualifier.
4053 * xterm.h (x_in_use): Declare.
4054 * xgselect.c: Include xterm.h.
4055 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4056 and `display_arg' (bug#9754).
4057
003fdae2
PE
40582012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4059
9232a6d9
PE
4060 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4061
003fdae2
PE
4062 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4063 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4064
784b56e2
EZ
40652012-05-18 Eli Zaretskii <eliz@gnu.org>
4066
4067 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4068
4069 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4070 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4071
4072 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4073 reference to image_cache->refcount.
4074 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4075
a0a79cde
JL
40762012-05-17 Juri Linkov <juri@jurta.org>
4077
4078 * search.c (Fword_search_regexp, Fword_search_backward)
4079 (Fword_search_forward, Fword_search_backward_lax)
4080 (Fword_search_forward_lax): Move functions to isearch.el
4081 (bug#10145, bug#11381).
4082
b0572523
PE
40832012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4084
4085 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4086
9660f5fc
SM
40872012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4088
4089 * lread.c (init_obarray): Declare Qt and Qnil as special.
4090
4374de83
GM
40912012-05-14 Glenn Morris <rgm@gnu.org>
4092
4093 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4094 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4095
dc44c39a
PE
40962012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4097
078c97cb
PE
4098 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4099
dc44c39a
PE
4100 * unexaix.c: Port to more-recent AIX compilers.
4101 (report_error, report_error_1, make_hdr, copy_sym)
4102 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4103 Make arguments const char *, not char *, to avoid violations of C
4104 standard and to fix some AIX warnings reported by Gilles Pion.
4105
e18afed7 41062012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4107
4108 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4109 already have overlays loaded.
4110 (handle_single_display_spec): Before returning without displaying
4111 fringe bitmap, synchronize the bidi iterator with the main display
4112 iterator, by calling iterate_out_of_display_property.
4113 (iterate_out_of_display_property): Detect buffer iteration by
4114 testing that it->string is a Lisp string.
4115 (get_next_display_element): When the current object is exhausted,
4116 and there's something on it->stack, call set_iterator_to_next to
4117 proceed with what's on the stack, instead of returning zero.
4118 (set_iterator_to_next): If called at the end of a Lisp string,
4119 proceed to consider_string_end without incrementing string
4120 position. Don't increment display vector index past the end of
4121 the display vector. (Bug#11417)
c8fb9dc6
EZ
4122 (pos_visible_p): Don't report a position visible when move_it_to
4123 stopped at the last line of window, which happens to be scanned
4124 backwards by the bidi iteration. (Bug#11464)
ac268e67 4125
e18afed7 41262012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4127
4128 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4129 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4130 are on a TTY, and thus unable to display on the fringes.
4131 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4132 so we need to signal to the caller that this is a "replacing"
4133 display spec. This fixes display when the spec is invalid or we
4134 are on a TTY.
4135
e18afed7 41362012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4137
4138 * unexaix.c (make_hdr): Fix typo in prototype.
4139 This bug broke the build on AIX. Problem reported by Gilles Pion.
4140
9d0a235a
MA
41412012-05-14 Michael Albinus <michael.albinus@gmx.de>
4142
4143 * keyboard.c (kbd_buffer_get_event): Read special events also in
4144 batch mode. (Bug#11415)
4145
9e6b06ed
GM
41462012-05-12 Glenn Morris <rgm@gnu.org>
4147
4148 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4149
c1a1d7a3
EZ
41502012-05-12 Eli Zaretskii <eliz@gnu.org>
4151
4152 * lisp.mk (lisp): Add newcomment.elc.
4153
3fe7cdc8
GM
41542012-05-12 Glenn Morris <rgm@gnu.org>
4155
4156 * Makefile.in (MKDIR_P): New, set by configure.
4157 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4158
53f7d2c0
PE
41592012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4160
4161 Remove unused function hourglass_started.
4162 * dispextern.h (hourglass_started):
4163 * w32fns.c (hourglass_started):
4164 * xdisp.c (hourglass_started): Remove.
4165
75aafb17
JB
41662012-05-10 Juanma Barranquero <lekktu@gmail.com>
4167
4168 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4169 Update dependencies.
4170
12959e8e
PE
41712012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4172
97107e2e
PE
4173 * xgselect.c (xg_select): Put maxfds+1 into a var.
4174 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4175
12959e8e
PE
4176 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4177
836d29b3
DA
41782012-05-10 Dave Abrahams <dave@boostpro.com>
4179
4180 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4181 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4182
5cb67954
MA
41832012-05-09 Michael Albinus <michael.albinus@gmx.de>
4184
4185 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4186 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4187 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4188 Initialize xd_registered_buses.
4189
3478ec45
PE
41902012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4191
b263a6b0
PE
4192 Untag more efficiently if USE_LSB_TAG.
4193 This is based on a proposal by YAMAMOTO Mitsuharu in
4194 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4195 For an admittedly artificial (nth 8000 longlist) benchmark on
4196 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4197 Emacs's overall text size by 1%.
4198 * lisp.h (XUNTAG): New macro.
4199 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4200 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4201 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4202 * eval.c (Fautoload):
4203 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4204 * frame.h (XFRAME): Use XUNTAG.
4205
3478ec45
PE
4206 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4207 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4208 Remove unportable assumptions about print widths of types like
4209 dbus_uint32_t.
4210 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4211 intptr_t when converting between pointer and integer, to avoid GCC
4212 warnings about wrong width.
4213
666b903b 42142012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4215
4216 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4217 stack for each reader_thread, instead of defaulting to 8MB
4218 determined by the linker. This avoids failures in creating
4219 subprocesses on Windows 7, see the discussion in this thread:
4220 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4221
b120cc17
JC
42222012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4223
4224 Fix up display of the *Minibuf-0* buffer in the mini window.
4225 * keyboard.c (read_char): Don't clear the echo area if there's no
4226 message to clear.
4227 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4228 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4229
9a4b36f8
MA
42302012-05-07 Michael Albinus <michael.albinus@gmx.de>
4231
4232 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4233 batch mode.
4234
e5f9458f
CY
42352012-05-06 Chong Yidong <cyd@gnu.org>
4236
4237 * lisp.mk (lisp): Update.
4238
eceeb5fc 42392012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4240
4241 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4242
71873e2b
SM
42432012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4244
4245 * data.c (PUT_ERROR): New macro.
4246 (syms_of_data): Use it. Add new error type `user-error'.
4247 * undo.c (user_error): New function.
4248 (Fprimitive_undo): Use it.
4249 * print.c (print_error_message): Adjust print style for `user-error'.
4250 * keyboard.c (user_error): New function.
4251 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4252
ab0fa4e4
PE
42532012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4254
4255 Do not limit current-time-string to years 1000..9999.
4256 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4257 (Fcurrent_time_string): Support any year that is supported by the
4258 underlying localtime representation. Don't use asctime, as it
4259 has undefined behavior for years outside the range -999..9999.
4260
7ed806a7
PE
42612012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4262
4263 Fix race conditions involving setenv, gmtime, localtime, asctime.
4264 Without this fix, interrupts could mess up code that uses these
4265 nonreentrant functions, since setting TZ invalidates existing
4266 tm_zone or tzname values, and since most of these functions return
4267 pointers to static storage.
4268 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4269 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4270 Grow the critical sections to include not just invoking
4271 localtime/gmtime, but also accessing these functions' results
4272 including their tm_zone values if any, and any related TZ setting.
4273 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4274 so that the struct tm is saved in the critical section.
4275 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4276 motivated by the fact that memory allocation needs to be outside
4277 the critical section.
4278
0c16dfed
DA
42792012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4280
4281 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4282 with RESET_INTERVAL.
4283
4284 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4285 Remove duplicated buffer name initialization.
4286
3f83ace8
JM
42872012-05-02 Jim Meyering <jim@meyering.net>
4288
4289 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4290
c7b8541e
JM
4291 * xfns.c (x_window): Use xstrdup (Bug#11375).
4292
90207a15 42932012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4294
4295 * xdisp.c (pos_visible_p): If already at a newline from the
4296 display string before the 'while' loop, don't walk back the glyphs
4297 from it3.glyph_row. Solves assertion violation when the display
4298 string begins with a newline (egg.el). (Bug#11367)
4299
b593d6a9
AH
43002012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4301
4302 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4303 Move to simple.el.
4304
4737362e
GM
43052012-05-01 Glenn Morris <rgm@gnu.org>
4306
99cf43f9
GM
4307 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4308 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4309 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4310 All were removed before 23.1.
4311
9311dcff
GM
4312 * dispnew.c: Remove HAVE_LIBNCURSES test;
4313 it is always true on relevant platforms.
4314
4d5c6349
GM
4315 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4316 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4317
4737362e
GM
4318 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4319
74dd3a6b
AS
43202012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4321
4322 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4323 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4324 Remove.
4325
13c379ee
PE
43262012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4327
4328 Do not avoid creating empty evaporating overlays (Bug#9642).
4329 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4330 That is, do not delete an evaporating overlay if it becomes
4331 empty after its bounds are adjusted to fit within its buffer.
4332 This fix caused other problems, and I'm reverting it until we get
4333 to the bottom of them.
4334
a8e7d6d7 43352012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4336
4337 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4338
a8e7d6d7 43392012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4340
4341 * xdisp.c (pos_visible_p): If the window start position is beyond
4342 ZV, start the display from buffer beginning. Prevents assertion
4343 violation in init_iterator when the minibuffer window is scrolled
4344 via the scroll bar.
4345
4346 * window.c (window_scroll_pixel_based): Likewise.
4347
a8e7d6d7 43482012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4349
4350 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4351
a8e7d6d7 43522012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4353
4354 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4355 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4356
a8e7d6d7 43572012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4358
b593d6a9
AH
4359 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4360 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4361
1c6900d9
EZ
43622012-04-26 Eli Zaretskii <eliz@gnu.org>
4363
4c3fa1d9
EZ
4364 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4365 display element, check also the underlying string or buffer
4366 character. (Bug#11341)
4367
1c6900d9
EZ
4368 * w32menu.c: Include w32heap.h.
4369 (add_menu_item): If the call to AppendMenuW (via
4370 unicode_append_menu) fails, disable Unicode menus only if we are
4371 running on Windows 9X/Me.
4372
42bf8205
AS
43732012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4374
4375 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4376 (xgetint): Add missing shift for LSB tags.
4377
b1bac16e
MR
43782012-04-24 Martin Rudalics <rudalics@gmx.at>
4379
4380 * keyboard.c (read_char): Don't wipe echo area for select window
4381 events: These might get delayed via `mouse-autoselect-window'
4382 (Bug#11304).
4383
d69621cc
JB
43842012-04-24 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4387 manipulation of :loaded-from data.
4388
02fd101b
JB
43892012-04-23 Juanma Barranquero <lekktu@gmail.com>
4390
4391 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4392 now a cons (bug#11311).
4393
888bec30
PE
43942012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4395
89a438bd
PE
4396 Do not create empty overlays with the evaporate property (Bug#9642).
4397 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4398 if it becomes empty after its bounds are adjusted to fit within
4399 its buffer. Without this fix, in a nonempty buffer (let ((o
4400 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4401 yields an empty overlay that has the evaporate property, which is
4402 not supposed to happen.
4403
1068fe4d
PE
4404 Fix minor GTK3 problems found by static checking.
4405 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4406 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4407 (struct _EmacsFixedClass, emacs_fixed_get_type):
4408 Move decls here from emacsgtkfixed.h, since they needn't be public.
4409 (emacs_fixed_get_type): Now static.
4410 (emacs_fixed_class_init): Omit unused local.
4411 (emacs_fixed_child_type): Remove; unused.
4412 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4413 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4414 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4415 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4416 (EMACS_FIXED_GET_CLASS): Remove; unused.
4417 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4418
888bec30
PE
4419 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4420 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4421
de85e130
PE
44222012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4423
d0baac98 4424 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4425 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4426 (__malloc_size_t, __malloc_ptrdiff_t):
4427 Remove. All uses removed, replaced by the definiens if needed,
4428 since we can assume C89 or better now.
4429 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4430 (protect_malloc_state, align, get_contiguous_space)
4431 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4432 (malloc_atfork_handler_child, malloc_enable_thread)
4433 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4434 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4435 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4436 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4437 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4438 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4439 Define using prototypes, not old style.
4440 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4441 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4442 (align): Don't assume that signed integer overflow wraps around.
4443 Omit unused local var.
4444 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4445 (_free_internal_nolock, memalign, mallochook, reallochook):
4446 Omit no-longer-needed casts.
4447 (valloc): Use getpagesize, not __getpagesize.
4448 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4449 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4450
de85e130
PE
4451 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4452
dcbf5805
MA
44532012-04-22 Michael Albinus <michael.albinus@gmx.de>
4454
4455 Move functions from C to Lisp. Make non-blocking method calls
4456 the default. Implement further D-Bus standard interfaces.
4457
4458 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4459 (QCdbus_request_name_allow_replacement)
4460 (QCdbus_request_name_replace_existing)
4461 (QCdbus_request_name_do_not_queue)
4462 (QCdbus_request_name_reply_primary_owner)
4463 (QCdbus_request_name_reply_in_queue)
4464 (QCdbus_request_name_reply_exists)
4465 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4466 (QCdbus_registered_serial, QCdbus_registered_method)
4467 (QCdbus_registered_signal): New Lisp objects.
4468 (XD_DEBUG_MESSAGE): Use sizeof.
4469 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4470 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4471 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4472 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4473 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4474 (xd_signature, xd_append_arg): Allow float for integer types.
4475 (xd_get_connection_references): New function.
b593d6a9
AH
4476 (xd_get_connection_address): Rename from xd_initialize.
4477 Return cached address.
dcbf5805
MA
4478 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4479 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4480 level.
4481 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4482 Return number of refcounts.
dcbf5805
MA
4483 (Fdbus_get_unique_name): Make stronger parameter check.
4484 (Fdbus_message_internal): New defun.
4485 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4486 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4487 (Fdbus_send_signal, Fdbus_register_service)
4488 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4489 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4490 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4491 (Vdbus_compiled_version, Vdbus_runtime_version)
4492 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4493 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4494 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4495 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4496 Adapt docstring.
dcbf5805 4497
52828e02
PE
44982012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4499
da05bc4c
PE
4500 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4501 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4502 Do not assume ptrdiff_t is the same width as 'int'.
4503
52828e02
PE
4504 * alloc.c: Handle unusual debugging option combinations.
4505 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4506 since the two debugging options are incompatible.
4507 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4508 is defined.
4509 (mem_init, mem_insert, mem_insert_fixup):
4510 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4511 (NEED_MEM_INSERT): Remove; no longer needed.
4512
f01769f9
LL
45132012-04-22 Leo Liu <sdl.web@gmail.com>
4514
4515 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4516
5790543d
PE
45172012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4518
4519 * sysdep.c [__FreeBSD__]: Minor cleanups.
4520 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4521 Use Emacs indenting style more consistently. Avoid some casts.
4522 Use 'double' consistently rather than mixing 'float' and 'double'.
4523
b91b7e4d
EW
45242012-04-21 Eduard Wiebe <usenet@pusto.de>
4525
b593d6a9
AH
4526 * sysdep.c (list_system_processes, system_process_attributes):
4527 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4528
6114eb15
AS
45292012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4530
4531 * lisp.mk (lisp): Update.
4532
2f38dff7
PE
45332012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4534
4535 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4536 It is never used otherwise.
4537
4ae29f89
SM
45382012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4539
4540 * print.c (print_preprocess): Only check print_depth if print-circle
4541 is nil.
4542 (print_object): Check for cycles even when print-circle is nil and
4543 print-gensym is t, but only check print_depth if print-circle is nil.
4544
f30d612a
CY
45452012-04-20 Chong Yidong <cyd@gnu.org>
4546
4547 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4548 set the status to "failed" and ensure that sentinel is run.
4549
c07a4c0b 45502012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4551
4552 * process.c (Fset_process_inherit_coding_system_flag)
4553 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4554 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4555
c07a4c0b 45562012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4557
4558 * xdisp.c (string_buffer_position_lim): Limit starting position to
4559 BEGV.
4560 (set_cursor_from_row): If called for a mode-line or header-line
4561 row, return zero immediately.
4562 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4563 farther than the first row after the header line, if any.
4564 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4565 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4566
c07a4c0b 45672012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4568
4ae29f89
SM
4569 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4570 (bug#11238).
ad3a2b41 4571
c07a4c0b 45722012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 45732012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4574
4575 configure: new option --enable-gcc-warnings (Bug#11207)
4576 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4577 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4578 (ALL_CFLAGS): Use new macros rather than old.
4579 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4580 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4581 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4582 -Wunused-result, -Wunused-variable. This should go away once
4583 the Emacs and Gnulib regex code is merged.
4584 (xmalloc, xrealloc): Now static.
4585
aba027e8
PE
45862012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4587
4588 * dired.c (Fsystem_groups): Remove unused local.
4589
e5a36063
GM
45902012-04-17 Glenn Morris <rgm@gnu.org>
4591
4592 * dired.c (Fsystem_users): Doc fix.
4593
316411f0
DA
45942012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4595
4596 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4597 (syms_of_dired): Add them.
4598
9426aba4
PE
45992012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4600
b62a57be
PE
4601 Fix minor alloc.c problems found by static checking.
4602 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4603 New extern decls, to avoid calling undeclared functions.
4604 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4605 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4606 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4607 (NEED_MEM_INSERT): New macro.
4608 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4609 Remove one incorrect comment and fix another.
b62a57be 4610
3539f31f
PE
4611 Fix minor ralloc.c problems found by static checking.
4612 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4613 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4614 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4615 (r_alloc_sbrk): Now static.
4616
a041960a
PE
4617 Improve ralloc.c interface checking.
4618 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4619 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4620 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4621 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4622 [REL_ALLOC]: ... to here, to check interface.
4623 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4624 Remove decls. This fixes an "It stinks!".
4625
9426aba4
PE
4626 * alloc.c (which_symbols): Fix alignment issue / type clash.
4627
d55c12ed
AS
46282012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4629
4630 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4631 (struct Lisp_Misc_Any): Likewise.
4632 (struct Lisp_Free): Likewise.
4633 * alloc.c (union aligned_Lisp_Symbol): Define.
4634 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4635 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4636 (union aligned_Lisp_Misc): Define.
4637 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4638 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4639 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4640
b948ce8b
PE
46412012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4644 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4645 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4646 * s/netbsd.h, s/sol2-6.h:
4647 Remove definition of GC_MARK_STACK, since the default now works.
4648 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4649 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4650 no longer the default.
4651 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4652
35dc09a1 46532012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4654
35dc09a1
GM
4655 * lread.c (lisp_file_lexically_bound_p):
4656 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4657
35dc09a1
GM
46582012-04-14 Eli Zaretskii <eliz@gnu.org>
4659
4660 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4661 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4662
46632012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4664
4665 * nsterm.m (constrainFrameRect): Always constrain when there is only
4666 one screen (Bug#10962).
4667
bcd86815
KB
46682012-04-13 Ken Brown <kbrown@cornell.edu>
4669
4670 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4671
c25df26e
RT
46722012-04-13 Reuben Thomas <rrt@sc3d.org>
4673
4674 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4675
0fc59f1e
DC
46762012-04-11 Daniel Colascione <dancol@dancol.org>
4677
4678 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4679 against is gone. It's better to use vfork now so that when Cygwin
4680 gains a new, working vfork, we use it automatically (bug#10398).
4681
de8c03dc
SM
46822012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4683
4684 * window.c (save_window_save): Obey window-point-insertion-type.
4685
2f097256
GM
46862012-04-11 Glenn Morris <rgm@gnu.org>
4687
4688 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4689
453b951e
SM
46902012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4691
4692 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4693
75f1671a 46942012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4695
4696 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4697 (force_quit_count): New var.
4698 (handle_interrupt): Use it.
4699
2a8ce227
JB
47002012-04-10 Juanma Barranquero <lekktu@gmail.com>
4701
4702 * w32.c (w32_delayed_load): Record the full path of the library
4703 being loaded (bug#10424).
4704
935396c0
GM
47052012-04-09 Glenn Morris <rgm@gnu.org>
4706
05920a43
GM
4707 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4708 not just in the obarray, before snarfing them. (Bug#11036)
4709
935396c0
GM
4710 * Makefile.in ($(leimdir)/leim-list.el):
4711 Pass EMACS rather than BUILT_EMACS.
4712
a18ecafa
TZ
47132012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4714
4715 * process.c (make_process):
4716 * process.h: Add integer `gnutls_handshakes_tried' member to
4717 process struct.
4718
6bbef4e5
JC
4719 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4720 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4721
4722 * gnutls.c (gnutls_log_function2i): Convenience log function.
4723 (emacs_gnutls_read): Use new log functions,
4724 `gnutls_handshakes_tried' process member, and
4725 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4726 attempts per process (connection).
4727
b4d3bc10
CY
47282012-04-09 Chong Yidong <cyd@gnu.org>
4729
4730 * eval.c (Fuser_variable_p, user_variable_p_eh)
4731 (lisp_indirect_variable): Functions deleted.
4732 (Fdefvar): Caller changed.
4733
4734 * callint.c (Finteractive, Fcall_interactively):
4735 * minibuf.c (Fread_variable): Callers changed.
4736
70f4d973
EZ
47372012-04-09 Eli Zaretskii <eliz@gnu.org>
4738
4739 * xdisp.c (set_cursor_from_row): If the display string appears in
4740 the buffer at position that is closer to point than the position
4741 after the display string, display the cursor on the first glyph of
4742 the display string. Fixes cursor display when a 'display' text
4743 property immediately follows invisible text. (Bug#11094)
4744
cb3c2e3e
PE
47452012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4746
4747 composite.c: use 'double' consistently
4748 * composite.c (get_composition_id): Use 'double' consistently
4749 instead of converting 'float' to 'double' and vice versa; this is
4750 easier to understand and avoids a GCC warning.
4751
fd06db5d
GM
47522012-04-09 Glenn Morris <rgm@gnu.org>
4753
50fe702a
GM
4754 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4755 preparation for dumping it with emacs. (Bug#4789)
4756 (leimdir): New variable.
4757 ($(leimdir)/leim-list.el): New rule.
4758 (emacs$(EXEEXT)): Depend on leim-list.el.
4759
fd06db5d
GM
4760 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4761 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4762 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4763
55c131ee
AS
47642012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4765
4766 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4767 proper alignment.
4768
9209588f
JB
47692012-04-07 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4772 Remove unused local variable.
4773
e3fb2efb
PE
47742012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4775
4776 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4777 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4778 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4779 objects, as mark_maybe_pointer will catch them otherwise.
4780 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4781 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4782
b5385551
PE
47832012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4784
4785 Fix typo that broke non-Windows builds.
4786 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4787
9078ead6
EZ
47882012-04-07 Eli Zaretskii <eliz@gnu.org>
4789
4790 Support building on MS-Windows with libxml2.
4791
4792 * makefile.w32-in (OBJ2): Add xml.$(O).
4793 (GLOBAL_SOURCES): Add xml.c.
4794 ($(BLD)/xml.$(O)): New dependency list.
4795
4796 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4797 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4798 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4799 [!WINDOWSNT]: New macros.
4800 (init_libxml2_functions, libxml2_loaded_p): New functions.
4801 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4802 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4803 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4804 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4805 linked in).
6bbef4e5
JC
4806 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4807 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4808 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4809
4810 * emacs.c: Don't include libxml/parser.h.
4811 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4812 xmlCleanupParser directly.
4813
4814 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4815
3811fdf3
EZ
48162012-04-07 Eli Zaretskii <eliz@gnu.org>
4817
4818 * indent.c (Fvertical_motion): If there is a display string at
4819 point, use it.vpos to compute how many lines to backtrack after
4820 move_it_to point. (Bug#11133)
4821
2f8e16b2
EZ
48222012-04-06 Eli Zaretskii <eliz@gnu.org>
4823
4824 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4825 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4826 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4827 macros related to unification of CJK characters. For the details,
4828 see the discussion following the message here:
4829 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4830
3d439cd1
CY
48312012-04-04 Chong Yidong <cyd@gnu.org>
4832
4833 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4834
8bc53d00
EZ
48352012-04-01 Eli Zaretskii <eliz@gnu.org>
4836
4837 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4838 instead of alloca. (Bug#11138)
4839
3b0512a3
AS
48402012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4841
4842 * w32menu.c (is_simple_dialog): Properly check lisp types.
4843 (Bug#11141)
4844
8427ddd2
EZ
48452012-03-31 Eli Zaretskii <eliz@gnu.org>
4846
979022ef
EZ
4847 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4848 position we get to after a call to move_it_to fails the
4849 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4850 only if we wind up in a string from display property. (Bug#11063)
4851
a6b1c7cc
EZ
4852 * window.c (Fdelete_other_windows_internal): Invalidate the row
4853 and column information about mouse highlight, so that redisplay
4854 restores it after reallocating the glyph matrices. (Bug#7464)
4855
8427ddd2
EZ
4856 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4857 string comes from a `display' text property, use the buffer
4858 position of that property as if we actually saw that position in
4859 the row's glyphs.
697ba24b
EZ
4860 (move_it_by_lines): Remove the assertion that
4861 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4862 violated when there's a before-string at the beginning of a line.
4863 (Bug#11063)
8427ddd2 4864
65a0a738
EZ
48652012-03-30 Eli Zaretskii <eliz@gnu.org>
4866
4867 * xdisp.c (append_space_for_newline): If the default face was
4868 remapped, use the remapped face for the appended newline.
4869 (extend_face_to_end_of_line): Use the remapped default face for
4870 extending the face to the end of the line.
4871 (display_line): Call extend_face_to_end_of_line when the default
4872 face was remapped. (Bug#11068)
4873
581355cc
EZ
48742012-03-29 Eli Zaretskii <eliz@gnu.org>
4875
4876 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4877
e8fc049f
SM
48782012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4879
4880 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4881
4fb9a543
GM
48822012-03-27 Glenn Morris <rgm@gnu.org>
4883
4884 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4885 Doc fixes.
4886
679910f1
KH
48872012-03-26 Kenichi Handa <handa@m17n.org>
4888
4889 * dispextern.h (struct glyph): Fix previous change. Change the
4890 bit length of glyphless.ch to 25 (Bug#11082).
4891
90d49b7f
CY
48922012-03-26 Chong Yidong <cyd@gnu.org>
4893
4894 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4895 (command_loop_1): Use it; inhibit selection update for
4896 handle-select-window too (Bug#8996).
4897
f514f6f0
FP
48982012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4899
e8fc049f 4900 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4901
bf43fa51
KH
49022012-03-25 Kenichi Handa <handa@m17n.org>
4903
4904 * dispextern.h (struct glyph): Change the bit length of
4905 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4906
8a0c01dd
EZ
49072012-03-24 Eli Zaretskii <eliz@gnu.org>
4908
4909 * s/ms-w32.h (tzname): Include time.h before redirecting to
4910 _tzname. Fixes the MSVC build. (Bug#9960)
4911
7d1c3a76
AS
49122012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4913
8ed79523
AS
4914 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4915 characters.
4916
7d1c3a76
AS
4917 * xterm.c (XTread_socket): Only modify handling_signal if
4918 !SYNC_INPUT. (Bug#11080)
4919
e99a9b8b
EZ
49202012-03-23 Eli Zaretskii <eliz@gnu.org>
4921
4922 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4923 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4924 when fetching a multibyte character consumes more bytes than
4925 CHAR_BYTES returns, due to unification of CJK characters in
4926 string_char. (Bug#11073)
4927
5063c0e1
TN
49282012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4929
4930 * process.c (wait_reading_process_output): Handle pty disconnect
4931 by refraining from sending oneself a SIGCHLD (bug#10933).
4932
9f851fbd
CY
49332012-03-22 Chong Yidong <cyd@gnu.org>
4934
4935 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4936
5063c0e1 4937 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4938 Mark string as coming from a prefix property.
4939 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4940 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4941
fb5b8aca
CY
49422012-03-21 Chong Yidong <cyd@gnu.org>
4943
4944 * xfaces.c (Vface_remapping_alist): Doc fix.
4945
62356a1b
EZ
49462012-03-20 Eli Zaretskii <eliz@gnu.org>
4947
4948 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4949 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4950 Doc fixes.
62356a1b 4951
025de85b
CY
49522012-03-20 Chong Yidong <cyd@gnu.org>
4953
4954 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4955 to reflect default non-nil value of redisplay-dont-pause.
4956
4827f94e
KH
49572012-03-19 Kenichi Handa <handa@m17n.org>
4958
4959 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4960 it fit in a valid range (Bug#11003).
4961
e50a24a2
EZ
49622012-03-18 Eli Zaretskii <eliz@gnu.org>
4963
4964 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4965 that is not from display property, accept the row as a "cursor
4966 row" if one of the string's character has a non-nil `cursor'
4967 property. Fixes cursor positioning when there are newlines in
4968 overlay strings, e.g. in icomplete.el. (Bug#11035)
4969
9af5ed87
PE
49702012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4971
4972 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4973
d1f55f16
CY
49742012-03-12 Chong Yidong <cyd@gnu.org>
4975
4976 * eval.c (inhibit_lisp_code): Rename from
4977 inhibit_window_configuration_change_hook; move from window.c.
4978
4979 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4980 * window.c (run_window_configuration_change_hook)
4981 (syms_of_window): Callers changed.
4982
66c5eebd
CY
49832012-03-11 Chong Yidong <cyd@gnu.org>
4984
413df973
CY
4985 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4986
66c5eebd
CY
4987 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4988
1de11f56
CY
49892012-03-10 Chong Yidong <cyd@gnu.org>
4990
4991 * frame.c (other_visible_frames): Don't assume the selected frame
4992 is visible (Bug#10955).
4993
cae07000
SM
49942012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4995
4996 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4997
89c94350
JD
49982012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4999
5000 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5001 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5002 zero (Bug#10954).
5003
999dd333
GM
50042012-03-03 Glenn Morris <rgm@gnu.org>
5005
01a6dcc8 5006 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5007
de0100f2
EZ
50082012-03-02 Eli Zaretskii <eliz@gnu.org>
5009
5010 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5011 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5012 (redisplay_window, next_element_from_string): Fix typos in
5013 comments.
3e441275
EZ
5014 (redisplay_window): Pass to move_it_vertically the margin in
5015 pixels, not in screen lines.
de0100f2 5016
96a72ee9
GM
50172012-03-02 Glenn Morris <rgm@gnu.org>
5018
5019 * buffer.c (buffer-list-update-hook): Doc fix.
5020
312508d7
EZ
50212012-02-29 Eli Zaretskii <eliz@gnu.org>
5022
5023 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5024 push_it before setting up the iterator for the first overlay
5025 string, even if we have an empty string loaded.
5026 (next_overlay_string): If there's an empty string on the iterator
5027 stack, pop the stack. (Bug#10903)
5028
27f3c637
PE
50292012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5030
5031 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5032 Suggested by Stefan Monnier in
5033 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5034 * alloc.c (widen_to_Lisp_Object): New static function.
5035 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5036 and widening them to Lisp_Objects. This would work even if
5037 USE_LSB_TAG is defined and wide integers are used, which might
5038 happen in a future version of Emacs.
5039
3c9dfce6
CY
50402012-02-25 Chong Yidong <cyd@gnu.org>
5041
fa74b241
CY
5042 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5043 Doc fix.
5044
3c9dfce6
CY
5045 * xselect.c (Fx_selection_exists_p): Doc fix.
5046 (x_clipboard_manager_save_all): Print an informative message
5047 before saving to clipboard manager.
5048
9486df08
CY
50492012-02-24 Chong Yidong <cyd@gnu.org>
5050
5051 * keyboard.c (process_special_events): Handle all X selection
5052 requests in kbd_buffer, not just the next one (Bug#8869).
5053
f01d3321
CY
50542012-02-23 Chong Yidong <cyd@gnu.org>
5055
5056 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5057 call when setting menu-bar-lines and tool-bar-lines parameters.
5058 (unwind_create_frame_1): New helper function.
5059
5060 * window.c (inhibit_window_configuration_change_hook): New var.
5061 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5062 (syms_of_window): Initialize it.
f01d3321 5063
86b847b6
CY
50642012-02-22 Chong Yidong <cyd@gnu.org>
5065
5066 * xterm.c (x_draw_image_relief): Add missing type check for
5067 Vtool_bar_button_margin (Bug#10743).
5068
a59225b1
CY
50692012-02-21 Chong Yidong <cyd@gnu.org>
5070
5071 * fileio.c (Vfile_name_handler_alist): Doc fix.
5072
5073 * buffer.c (Fget_file_buffer): Protect against invalid file
5074 handler return value.
5075
310f5bd4
PE
50762012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5077
cb3a28cc
PE
5078 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5079 when computing $valmask.
5080
310f5bd4
PE
5081 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5082 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5083 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5084 It's useless in that case, and it can cause problems on hosts
5085 that allocate halves of EMACS_INT values separately.
5086 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5087 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5088 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5089 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5090 it avoids undefined behavior on hosts where shifting right by more
5091 than the word width has undefined behavior.
5092
2375c96a
CY
50932012-02-19 Chong Yidong <cyd@gnu.org>
5094
5095 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5096 (Funhandled_file_name_directory, Ffile_name_as_directory)
5097 (Fdirectory_file_name, Fexpand_file_name)
5098 (Fsubstitute_in_file_name): Protect against invalid file handler
5099 return values (Bug#10845).
5100
3eb49e71
EZ
51012012-02-18 Eli Zaretskii <eliz@gnu.org>
5102
5103 * .gdbinit (pitx): Fix incorrect references to fields of the
5104 iterator stack.
5105
7b926f3f
CY
51062012-02-17 Chong Yidong <cyd@gnu.org>
5107
5108 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5109
11273115
PE
51102012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5111
5112 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5113 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5114
c3a70e2b
CY
51152012-02-15 Chong Yidong <cyd@gnu.org>
5116
5117 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5118 marked as special. Also, starting docstrings with * is obsolete.
5119
0ca43699
AS
51202012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5121
5122 * gnutls.c (emacs_gnutls_write): Fix last change.
5123
2e8f3c56
LI
51242012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5125
5126 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5127 send_process.
5128
af70074f
SM
51292012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5130
5131 * keymap.c (Fsingle_key_description): Handle char ranges.
5132
95986d52
CY
51332012-02-12 Chong Yidong <cyd@gnu.org>
5134
afd83bd1
CY
5135 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5136 as that creates a dangerous corner case.
5137
95986d52
CY
5138 * window.c (Fdelete_window_internal): Invalidate the mouse
5139 highlight (Bug#9904).
5140
bd7da63e
GM
51412012-02-12 Glenn Morris <rgm@gnu.org>
5142
5143 * xselect.c (Fx_own_selection_internal)
5144 (Fx_get_selection_internal, Fx_disown_selection_internal)
5145 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5146 * nsselect.m (Fx_own_selection_internal)
5147 (Fx_disown_selection_internal, Fx_selection_exists_p)
5148 (Fx_selection_owner_p, Fx_get_selection_internal):
5149 Sync docs and argument specs with the xselect.c versions.
5150
77abcbc2
LI
51512012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5152
5153 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5154
90b671e2
EZ
51552012-02-11 Eli Zaretskii <eliz@gnu.org>
5156
1c0ca0b7
EZ
5157 * w32select.c (Fx_selection_exists_p): Sync doc string and
5158 argument list with xselect.c. (Bug#10783)
5159
5160 * w16select.c (Fx_selection_exists_p): Sync doc string and
5161 argument list with xselect.c. (Bug#10783)
90b671e2 5162
49241268
GM
51632012-02-10 Glenn Morris <rgm@gnu.org>
5164
5165 * fns.c (Fsecure_hash): Doc fix.
5166
f998bbe7 51672012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5168
5169 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5170
0992bd9c
CY
51712012-02-07 Chong Yidong <cyd@gnu.org>
5172
5173 * buffer.c (Fbuffer_local_variables)
5174 (buffer_lisp_local_variables): Handle unbound vars correctly;
5175 don't let Qunbound leak into Lisp.
5176
af008560
GM
51772012-02-07 Glenn Morris <rgm@gnu.org>
5178
dd605cc4
GM
5179 * image.c (Fimagemagick_types): Doc fix.
5180
af008560
GM
5181 * image.c (imagemagick-render-type): Change it from a lisp object
5182 to an integer. Move the doc here from the lisp manual.
5183 Treat all values not equal to 0 the same.
5184
1449fa1d
CY
51852012-02-06 Chong Yidong <cyd@gnu.org>
5186
5187 * doc.c (store_function_docstring): Avoid applying docstring of
5188 alias to base function (Bug#2603).
5189
3723ec07
AS
51902012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5191
5192 * .gdbinit (pp1, pv1): Remove redundant defines.
5193 (pr): Use pp.
5194
79c1cc1e
CY
51952012-02-04 Chong Yidong <cyd@gnu.org>
5196
5197 * nsterm.m: Declare a global (Bug#10694).
5198
d7f29f8e
EZ
51992012-02-04 Eli Zaretskii <eliz@gnu.org>
5200
cae07000
SM
5201 * w32.c (get_emacs_configuration_options):
5202 Include --enable-checking, if specified, in the return value.
d7f29f8e 5203
3b95a6f9
MR
52042012-02-04 Martin Rudalics <rudalics@gmx.at>
5205
5206 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5207 after rounding frame sizes. (Bug#9723)
5208
d6fa96a6
EZ
52092012-02-04 Eli Zaretskii <eliz@gnu.org>
5210
5211 * keyboard.c (adjust_point_for_property): Don't position point
5212 before BEGV. (Bug#10696)
5213
df0b2940
PE
52142012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5215
5216 Handle overflow when computing char display width (Bug#9496).
5217 * character.c (char_width): Return EMACS_INT, not int.
5218 (char_width, c_string_width): Check for overflow when
5219 computing the width; this is possible now that individual
5220 characters can have unbounded width. Problem introduced
5221 by merge from Emacs 23 on 2012-01-19.
5222
6bee44d6
MA
52232012-02-02 Michael Albinus <michael.albinus@gmx.de>
5224
5225 * dbusbind.c (Fdbus_register_method): Mention the return value
5226 :ignore in the docstring.
5227
44f92739
GM
52282012-02-02 Glenn Morris <rgm@gnu.org>
5229
1b9f60cc
GM
5230 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5231
44f92739
GM
5232 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5233 Unconditionally set to t. (Bug#10673)
5234 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5235 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5236 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5237
c5d3843c
KH
52382012-02-02 Kenichi Handa <handa@m17n.org>
5239
5240 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5241 0, do not call append_composite_glyph.
5242
159462d4 52432012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5244
5245 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5246 NULL (Bug#6988).
5247 (x_produce_glyphs): If the component of a composition is a null
5248 string, set it->pixel_width to 1 to avoid zero-width glyph.
5249
78cef877
EZ
52502012-02-01 Eli Zaretskii <eliz@gnu.org>
5251
5252 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5253 first 2 arguments are identical. This makes inserting large
5254 output from a subprocess an order of magnitude faster on
5255 MS-Windows, where all sbrk'ed memory is always contiguous.
5256
97897668
GM
52572012-01-31 Glenn Morris <rgm@gnu.org>
5258
5259 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5260 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5261 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5262
31fd3586
GM
52632012-01-29 Glenn Morris <rgm@gnu.org>
5264
5265 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5266
0e24a8b2
CY
52672012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5268
5269 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5270
cc0adcb0
CY
52712012-01-28 Chong Yidong <cyd@gnu.org>
5272
5273 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5274
acc28cb9
CY
52752012-01-26 Chong Yidong <cyd@gnu.org>
5276
9c69cfb7
CY
5277 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5278
acc28cb9
CY
5279 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5280 repeat counts (Bug#10507).
5281
48da7392
GM
52822012-01-26 Glenn Morris <rgm@gnu.org>
5283
5284 * lread.c (syms_of_lread): Doc fix.
5285
14af5f7f
CY
52862012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5287
5288 * coding.c (encode_designation_at_bol): Change return value to
5289 EMACS_INT.
5290
0b21c100
CY
52912012-01-25 Chong Yidong <cyd@gnu.org>
5292
5293 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5294
3c2907f7
CY
52952012-01-21 Chong Yidong <cyd@gnu.org>
5296
5297 * floatfns.c (Fcopysign): Make the second argument non-optional,
5298 since nil is not allowed anyway.
5299
959ad23f
AS
53002012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5301
5302 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5303 (send_process): Likewise.
5304
34a02f46
MR
53052012-01-19 Martin Rudalics <rudalics@gmx.at>
5306
5307 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5308 (Vwindow_persistent_parameters): Do not use Qstate.
5309 Rewrite doc-strings.
34a02f46 5310
1259009a 53112012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5312
5313 * character.c (char_width): New function.
70d4fdf6
GM
5314 (Fchar_width, c_string_width, lisp_string_width):
5315 Use char_width (Bug#9496).
25ed9e61 5316
6a6ee00d
MR
53172012-01-16 Martin Rudalics <rudalics@gmx.at>
5318
5319 * window.c (Vwindow_persistent_parameters): New variable.
5320 (Fset_window_configuration, save_window_save): Handle persistent
5321 window parameters.
5322
c85efaf7
EZ
53232012-01-14 Eli Zaretskii <eliz@gnu.org>
5324
5325 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5326 thrashing the stack of the thread. (Bug#9087)
5327
5944709e
PE
53282012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5329
5330 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5331
e71f5d99
EZ
53322012-01-11 Eli Zaretskii <eliz@gnu.org>
5333
5334 * xdisp.c (rows_from_pos_range): Handle the case where the
5335 highlight ends on a newline. (Bug#10464)
5336 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5337 he end column for display of highlight that ends on a newline
5338 before a R2L line.
5339
ce316182
GM
53402012-01-11 Glenn Morris <rgm@gnu.org>
5341
5342 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5343 from load-path also when installation-directory is nil. (Bug#10208)
5344
5b43da69
GM
53452012-01-10 Glenn Morris <rgm@gnu.org>
5346
74cc8ff9
GM
5347 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5348
7d8d6e4e
GM
5349 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5350 Update template values to be closer to their typical values these days.
5b43da69 5351
a0db8d43
EZ
53522012-01-09 Eli Zaretskii <eliz@gnu.org>
5353
5354 * xdisp.c (rows_from_pos_range): Accept additional argument
5355 DISP_STRING, and accept any glyph in a row whose object is that
5356 string as eligible for mouse highlight. Fixes mouse highlight of
5357 display strings from overlays. (Bug#10464)
5358
9a0115ab 53592012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5360
b9110d6a 5361 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5362 * fileio.c (auto_saving_dir_umask): New static var.
5363 (Fmake_directory_internal): Use it.
5364 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5365 creating the directory. The old code temporarily assigns
5366 too-generous permissions to the directory.
5367 (do_auto_save_eh): Clear it.
b9110d6a 5368 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5369 that the var is always cleared.
5370
6c1bd3f3
EZ
53712012-01-07 Eli Zaretskii <eliz@gnu.org>
5372
5373 * search.c (scan_buffer): Pass character positions to
5374 know_region_cache, not byte positions. (Bug#6540)
5375
069d2b50
L
53762012-01-07 LynX <_LynX@bk.ru> (tiny change)
5377
5378 * w32.c (sys_rename): Report EXDEV when rename of a directory
5379 fails because the target is on another logical disk. (Bug#10284)
5380
75bf0d33
DB
53812012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5382
5383 * xterm.c (x_embed_request_focus): New function.
5384
5385 * xterm.h: Add prototype.
5386
5387 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5388
1c6e5a32
GM
53892012-01-05 Glenn Morris <rgm@gnu.org>
5390
5391 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5392
651e947e
EZ
53932012-01-01 Eli Zaretskii <eliz@gnu.org>
5394
5395 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5396 Load gnutls_transport_set_lowat only if GnuTLS version is below
5397 2.11.1.
5398 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5399 GnuTLS versions below 2.11.1.
5400
3778cdd8
AL
54012011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5402
5403 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5404 to the doc string advising against its use for altering the way
5405 windows are scrolled.
5406
0e5317f7
KH
54072011-12-28 Kenichi Handa <handa@m17n.org>
5408
5409 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5410 coding-system ASCII compatible only when it does not produce BOM
5411 on encoding (Bug#10383).
5412
93d5ca1f
JD
54132011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5414
5415 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5416 can scroll.
5417 (create_and_show_popup_menu): Always use menu_position_func for
5418 Gtk3 (Bug#10361).
5419
ca22b785
AS
54202011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5421
5422 * callint.c (Fcall_interactively): Don't truncate prompt string.
5423
d048e1e6
EZ
54242011-12-23 Eli Zaretskii <eliz@gnu.org>
5425
5426 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5427 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5428 resumed from there (after widening). (Bug#10360)
d048e1e6 5429
5ccaba1f
JD
54302011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5431
5432 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5433
204ee57f
JD
54342011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5435
b81d40f0
JB
5436 * nsterm.m (x_free_frame_resources):
5437 Release f->output_data.ns->miniimage.
204ee57f
JD
5438 (ns_index_color): Fix indentation. Do not retain
5439 color_table->colors[i].
5440
5441 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5442 before returning.
5443
5444 * nsfns.m (x_set_background_color): Assign return value from
5445 ns_index_color to face-background instead of NSColor*.
5446 (ns_implicitly_set_icon_type): Fix indentation.
5447 Change assignment in for loop to comparison.
5448
5449 * emacs.c (ns_pool): New variable.
5450 (main): Assign ns_pool.
5451 (Fkill_emacs): Call ns_release_autorelease_pool.
5452
5453 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5454 autorelease fdesc, release fdAttrs and tdict.
5455 (ns_get_covering_families): Release charset.
5456 (ns_findfonts): Release NSFontDescriptor created with new.
5457 (ns_uni_to_glyphs): Fix indentation.
5458 (setString): Release attrStr before assigning new value.
5459
c803b2b7
JD
54602011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5461
678f4426
JD
5462 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5463 and NS_IMPL_COCOA.
5464 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5465 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5466
cd394be1 54672011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5468
5fecd5fc
JD
5469 * nsterm.m (ns_term_init): Subscribe for notifications
5470 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5471 to method trackingNotification in EmacsMenu.
5472
5473 * nsmenu.m (trackingMenu): New variable.
3771cb17 5474 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5475 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5476 from Aquamacs (Bug#7030).
678f4426
JD
5477
54782011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5479
c803b2b7
JD
5480 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5481 (symbol_to_nsstring): Fix indentation.
5482 (ns_symbol_to_pb): New function.
cae07000
SM
5483 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5484 (Fns_rotate_cut_buffers_internal): Remove.
5485 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5486 Fns_store_cut_buffer_internal.
5487 (ns_get_foreign_selection, Fx_own_selection_internal)
5488 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5489 (Fns_get_selection_internal, Fns_store_selection_internal):
5490 Use ns_symbol_to_pb and check if return value is nil.
5491 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5492 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5493 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5494 renamed to Sns_store_selection_internal.
5495 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5496 and remove this function.
5497 (ns_handle_selection_clear): Remove, never used.
5498 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5499 here.
5500
e1b01a3a
KB
55012011-12-17 Ken Brown <kbrown@cornell.edu>
5502
5503 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5504 GID is unknown (Bug#10257).
5505
2adb6e85
PE
55062011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5507
5508 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5509 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5510 which caused a build failure on GNU/Linux IA-64. This problem was
5511 introduced by my 2011-10-07 patch.
5512
d1d7b339
JL
55132011-12-15 Juri Linkov <juri@jurta.org>
5514
5515 * image.c (imagemagick_error): New function. (Bug#10112)
5516 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5517 Use `imagemagick_error' where ImageMagick functions return
5518 `MagickFalse'.
5519 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5520 proper order.
5521
100d5755
KH
55222011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5523
5524 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5525 fill background (Bug#8992).
5526
454592a6
MR
55272011-12-13 Martin Rudalics <rudalics@gmx.at>
5528
5529 * window.c (Vwindow_combination_resize)
5530 (Vwindow_combination_limit): Use t instead of non-nil in
5531 doc-strings.
61d4b438
MR
5532 (Vrecenter_redisplay): Add first sentence of doc-string on
5533 separate line.
53524d93 5534 (Frecenter): Fix doc-string typo.
454592a6 5535
3633e3aa
KH
55362011-12-11 Kenichi Handa <handa@m17n.org>
5537
5538 * coding.c (Funencodable_char_position): Pay attention to the
5539 buffer text relocation (Bug#9389).
5540
7b9d523a 55412011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5542
7b9d523a
JD
5543 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5544 gtk_init (Bug#10100).
5545
b73189c6
EZ
55462011-12-10 Eli Zaretskii <eliz@gnu.org>
5547
5548 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5549 IT->string is nil. (Bug#10263)
5550
f7dfe5d6
JD
55512011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5552
83faebb4
JD
5553 * nsterm.h (x_free_frame_resources): Declare.
5554
f7dfe5d6
JD
5555 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5556 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5557
5558 * nsterm.h (ns_get_defaults_value): Declare.
5559
5560 * nsterm.m (ns_default): Call ns_get_defaults_value.
5561
7cd4e72c
EZ
55622011-12-09 Eli Zaretskii <eliz@gnu.org>
5563
5564 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5565 (Bug#10170)
5566
b34d7317
YM
55672011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5568
5569 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5570 that where the value of an _OBJC_* symbol points to is in the .bss
5571 section (Bug#10240).
5572
76470ad1
KH
55732011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5574
5575 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5576 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5577
745fff94
KH
55782011-12-08 Kenichi Handa <handa@m17n.org>
5579
5580 * ftfont.c (get_adstyle_property): Fix previous change
5581 (Bug#10233).
5582
6e44397c
JB
55832011-12-07 Juanma Barranquero <lekktu@gmail.com>
5584
5585 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5586 dirs from the default value of EMACSLOADPATH (bug#10208).
5587
7efa6272
GM
55882011-12-07 Glenn Morris <rgm@gnu.org>
5589
5590 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5591 installation and source directories as well. (Bug#10208)
5592
f6fc4d87
CY
55932011-12-06 Chong Yidong <cyd@gnu.org>
5594
5595 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5596
2bf26180
GM
55972011-12-06 Glenn Morris <rgm@gnu.org>
5598
5599 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5600 as an error, not just -1. (Bug#10217)
5601
3a6ad4f0
CY
56022011-12-05 Chong Yidong <cyd@gnu.org>
5603
5604 * keyboard.c (process_special_events): New function.
5605 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5606
75a3b399
PE
56072011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5608
5609 * coding.c (encode_designation_at_bol): Don't use uninitialized
5610 local variable (Bug#9318).
5611
c3c9e25e
KH
56122011-12-05 Kenichi Handa <handa@m17n.org>
5613
5614 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5615 return Qnil (Bug#8046, Bug#10193).
5616
5eb05ea3
KH
56172011-12-05 Kenichi Handa <handa@m17n.org>
5618
5619 * coding.c (encode_designation_at_bol): New args charbuf_end and
5620 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5621 (coding_set_source): Return how many bytes coding->source was
5622 relocated.
5623 (coding_set_destination): Return how many bytes
5624 coding->destination was relocated.
5625 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5626 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5627
56282011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5629
5630 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5631 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5632 macro (Bug#9318).
5633
56342011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5635
5636 The following changes are to fix Bug#9318.
5637
a79703f5 5638 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5639 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5640 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5641 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5642
7dbda6df
JB
56432011-12-05 Juanma Barranquero <lekktu@gmail.com>
5644
5645 * lisp.h (process_quit_flag): Fix external declaration.
5646
6d5eb5b0
SM
56472011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5648
5649 Don't macro-inline non-performance-critical code.
5650 * eval.c (process_quit_flag): New function.
5651 * lisp.h (QUIT): Use it.
5652
a0c3fad0
JD
56532011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5654
5655 * nsfns.m (get_geometry_from_preferences): New function.
5656 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5657
6c07aac2
AS
56582011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5659
5660 * emacs.c (Qkill_emacs): Define.
5661 (syms_of_emacs): Initialize it.
5662 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5663 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5664 (quit_throw_to_read_char): Add parameter `from_signal'.
5665 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5666 * lisp.h (QUIT): Call Fkill_emacs if requested.
5667
c052ead4
JD
56682011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5669
5670 * widget.c (update_wm_hints): Return if wmshell is null.
5671 (widget_update_wm_size_hints): New function.
5672
5673 * widget.h (widget_update_wm_size_hints): Declare.
5674
5675 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5676 widget_update_wm_size_hints (Bug#10104).
5677
9e49252b
EZ
56782011-12-03 Eli Zaretskii <eliz@gnu.org>
5679
5680 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5681 before a newline, prepare the bidi iterator for consuming the
5682 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5683 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5684
02b16839
JL
56852011-12-02 Juri Linkov <juri@jurta.org>
5686
5687 * search.c (Fword_search_regexp): New Lisp function created from
5688 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5689 (Fword_search_backward, Fword_search_forward)
5690 (Fword_search_backward_lax, Fword_search_forward_lax):
5691 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5692 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5693
0068070e
SM
56942011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5695
5696 * fileio.c (Finsert_file_contents): Move after-change-function call
5697 to before the "handled:" label, since all "goto handled" appear in
5698 cases where the *-change-functions have already been properly called
5699 (bug#10117).
5700
3360a3fc
AS
57012011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5702
5703 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5704 waiting for input. (Bug#10169)
5705
73d6c093
EZ
57062011-11-30 Eli Zaretskii <eliz@gnu.org>
5707
5708 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5709 verifies glyph row's hash code--we have just reallocated the
5710 glyphs, so their contents can be complete garbage. (Bug#10164)
5711
febe6bea
JB
57122011-11-30 Juanma Barranquero <lekktu@gmail.com>
5713
5714 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5715
801a4313
EZ
57162011-11-30 Eli Zaretskii <eliz@gnu.org>
5717
5718 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5719 attributes are tested _before_ calling verify_row_hash, to protect
5720 against GCC re-ordering of the tests. (Bug#10164)
5721
2b56b87e
JD
57222011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5723
5724 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5725
5726 * xterm.c (handle_one_xevent): Only set async_visible and friends
5727 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5728 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5729 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5730
dbf31225
PE
57312011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5732
5733 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5734 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5735 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5736 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5737 All uses changed to use GCPRO1 etc.
5738 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5739 Revert to old implementation (i.e., before 2011-03-11).
5740
1305621b
YM
57412011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5742
5743 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5744 of scroll runs so as to avoid assigning disabled bogus rows and
5745 unnecessary graphics copy operations.
5746
8c9afb46
EZ
57472011-11-27 Eli Zaretskii <eliz@gnu.org>
5748
5749 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5750 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5751 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5752 (malloc, free, realloc, calloc): Redirect to e_* only when
5753 compiling Emacs.
5754
5755 * lisp.h (GCTYPEBITS): Move before first use.
5756 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5757 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5758 this macro definition.
5759
5760 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5761 _MSC_VER.
5762
54e9e3bf
JD
57632011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5764
6d5eb5b0
SM
5765 * gtkutil.c (xg_create_frame_widgets):
5766 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5767 present with Gtk+ 2.0.
5768
83aca1cb
PE
57692011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5770
5771 * fileio.c (Finsert_file_contents): Undo previous change; see
5772 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5773
5b76caa4
PE
57742011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5775
5776 Rename locals to avoid shadowing.
5777 * fileio.c (Finsert_file_contents):
5778 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5779 * process.c (wait_reading_process_output):
5780 Rename inner 'proc' to 'p' to avoid shadowing.
5781 Indent for consistency with usual Emacs style.
5782
8c535114
EZ
57832011-11-25 Eli Zaretskii <eliz@gnu.org>
5784
5785 * xdisp.c (redisplay_window): If cursor row is not fully visible
5786 after recentering, and scroll-conservatively is set to a large
5787 number, scroll window by a few more lines to make the cursor fully
5788 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5789 (start_display): Don't move to the next line if the display should
5790 start at a newline that is part of a display vector or an overlay
5791 string. (Bug#10119)
8c535114 5792
fa4fdb5c
JL
57932011-11-24 Juri Linkov <juri@jurta.org>
5794
5795 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5796 after the `MagickPingImage' call. (Bug#10112)
5797
90ec88df
CY
57982011-11-23 Chong Yidong <cyd@gnu.org>
5799
5800 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5801
56e2e794
MR
58022011-11-23 Martin Rudalics <rudalics@gmx.at>
5803
5804 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5805 making another buffer current. (Bug#10114)
5806
b6e64c41
GM
58072011-11-23 Glenn Morris <rgm@gnu.org>
5808
5809 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5810
6b21de18
CY
58112011-11-23 Chong Yidong <cyd@gnu.org>
5812
5813 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5814 using it (Bug#5984).
5815
b12cd789
EZ
58162011-11-22 Eli Zaretskii <eliz@gnu.org>
5817
5818 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5819 and header-lines, as they don't have one computed for them.
5820 (Bug#10098)
5821
5822 * .gdbinit (prow): Make displayed values more self-explaining.
5823 Add row's hash code.
5824
261b6fd4
LMI
58252011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5826
5827 * process.c (wait_reading_process_output): Fix asynchrounous
5828 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5829 (wait_reading_process_output): Add comment and URL.
261b6fd4 5830
e7cfd277
JD
58312011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5832
5833 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5834
a9b9b7f5
CY
58352011-11-21 Chong Yidong <cyd@gnu.org>
5836
5837 * window.c (Fnext_window, Fprevious_window): Doc fix.
5838
b0d15b4f
SM
58392011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5840
5841 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5842
fe7a3057
JB
58432011-11-20 Juanma Barranquero <lekktu@gmail.com>
5844
5845 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5846
d2999b1a
MR
58472011-11-20 Martin Rudalics <rudalics@gmx.at>
5848
5849 * window.c (Fset_window_combination_limit): Rename argument
5850 STATUS to LIMIT.
5851 (Vwindow_combination_limit): Remove "status" from doc-string.
5852
d5ff9cd0
AS
58532011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5854
5855 * m/ibms390.h: Remove.
5856 * m/ibms390x.h: Don't include "ibms390.h".
5857
a5bb9bd3
SM
58582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5859
5860 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5861 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5862
cd1181db
JB
58632011-11-20 Juanma Barranquero <lekktu@gmail.com>
5864
5865 * casetab.c (Fset_case_table):
5866 * charset.c (Fcharset_after): Fix typos.
5867
615a3b8d 58682011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5869
17e845af
PE
5870 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5871 Otherwise, valgrind does not work on some platforms.
5872 Problem reported by Andreas Schwab in
6a0bf43d
PE
5873 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5874 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5875 is set, removing the need for VIRT_ADDRESS_VARIES.
5876 (PURE_P): Use a more-efficient implementation that needs just one
5877 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5878 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5879 to 4 (xorl, subq, cmpq, setbe).
5880 * alloc.c (pure): Always extern now, since that's the
5881 VIRT_ADDR_VARIES behavior.
5882 (PURE_POINTER_P): Use a single comparison, not two, for
5883 consistency with the new puresize.h.
5884 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5885 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5886 Remove VIRT_ADDR_VARIES no longer needed.
5887
f8fe6f96
EZ
58882011-11-19 Eli Zaretskii <eliz@gnu.org>
5889
5890 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5891 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5892 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5893 behave as if the cursor position were at the window margin.
5894
5895 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5896 and the cursor position is out of bounds, behave as if the cursor
5897 position were at the window margin. (Bug#10075)
5898
df05a53c
CY
58992011-11-18 Chong Yidong <cyd@gnu.org>
5900
5901 * window.c (Fwindow_combination_limit): Make first argument
5902 non-optional, since it is meaningless for live windows like the
5903 selected window.
61ccba97 5904
2071918e
DA
59052011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5906
5907 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5908
b50a28de
SM
59092011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5910
5911 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5912 (graft_intervals_into_buffer): Simplify.
5913
015137db
EZ
59142011-11-18 Eli Zaretskii <eliz@gnu.org>
5915
5916 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5917 hash values of the two rows.
5918 (copy_row_except_pointers): Preserve the used[] arrays and the
5919 hash values of the two rows. (Bug#10035)
68c95424 5920 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5921
5922 * xdisp.c (row_hash): New function, body extracted from
5923 compute_line_metrics.
5924 (compute_line_metrics): Call row_hash, instead of computing the
5925 hash code inline.
5926
5927 * dispnew.c (verify_row_hash): Call row_hash for computing the
5928 hash code of a row, instead of duplicating code from xdisp.c.
5929
5930 * dispextern.h (row_hash): Add prototype.
5931
a2addb04
TH
59322011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5933
5934 * frame.c (delete_frame): Don't delete the terminal when the last
5935 X frame is closed if emacs is built with GTK toolkit.
5936
df85d315
JB
59372011-11-17 Juanma Barranquero <lekktu@gmail.com>
5938
5939 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5940
a0c2d0ae
MR
59412011-11-17 Martin Rudalics <rudalics@gmx.at>
5942
5943 * window.c (Vwindow_splits): Rename to
5944 Vwindow_combination_resize. Suggested by Juri Linkov.
5945 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5946 of Vwindow_splits.
5947
58179cce
JB
59482011-11-16 Juanma Barranquero <lekktu@gmail.com>
5949
7877f373
JB
5950 * nsfns.m (Fns_font_name):
5951 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5952
b6f67890
MR
59532011-11-16 Martin Rudalics <rudalics@gmx.at>
5954
5955 * window.h (window): Rename slot "nest" to "combination_limit".
5956 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5957 (Fset_window_nest): Rename to Fset_window_combination_limit.
5958 (Vwindow_nest): Rename to Vwindow_combination_limit.
5959 (recombine_windows, make_parent_window, make_window)
5960 (Fsplit_window_internal, saved_window)
5961 (Fset_window_configuration, save_window_save): Rename all
5962 occurrences of window_nest to window_combination_limit.
5963
c7015153
JB
59642011-11-15 Juanma Barranquero <lekktu@gmail.com>
5965
5966 * image.c (imagemagick_load_image): Fix typo.
5967
322ad6ec
EZ
59682011-11-14 Eli Zaretskii <eliz@gnu.org>
5969
5970 * xdisp.c (display_line): Move the call to
5971 highlight_trailing_whitespace before the call to
5972 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5973 faces of all the glyphs to compute ROW's hash value.
5974 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5975
f067b8ec
JB
59762011-11-14 Juanma Barranquero <lekktu@gmail.com>
5977
5978 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5979 just return (bug#10044).
5980
1e5b2111
EZ
59812011-11-12 Eli Zaretskii <eliz@gnu.org>
5982
7ef3cbd5
EZ
5983 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5984 with user-defined heap size. Bump the default size of the temacs
5985 heap to 27MB, to avoid memory warning when running temacs.
5986 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5987
1e5b2111
EZ
5988 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5989 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5990 (verify_row_hash) [XASSERTS]: New function.
5991 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5992 that the hash value of glyph rows is correct.
1e5b2111 5993
89d61221
MR
59942011-11-12 Martin Rudalics <rudalics@gmx.at>
5995
5996 * window.h (window): Remove splits slot.
5997 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5998 (Fdelete_other_windows_internal, make_parent_window)
5999 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6000 (Fset_window_configuration, save_window_save): Don't deal with
6001 split status of windows.
6002 (saved_window): Remove splits slot.
6003 (Vwindow_splits): Rewrite doc-string.
6004
97f18cc8
JD
60052011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6006
6007 * xfns.c (unwind_create_frame):
6008 * nsfns.m (unwind_create_frame):
6009 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6010 Vframe_list (Bug#9999).
6011
22a648b4
DA
60122011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6013
0b381c7e 6014 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6015
659afede
KH
60162011-11-11 Kenichi Handa <handa@m17n.org>
6017
6018 * callproc.c (Fcall_process): Set the member dst_multibyte of
6019 process_coding.
6020
9ac0394b
KH
60212011-11-11 Johan Bockgård <bojohan@gnu.org>
6022
6023 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6024 avoid a crash (bug#9496).
6025
2fbdc249
CY
60262011-11-09 Chong Yidong <cyd@gnu.org>
6027
6028 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6029 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6030
ac6b1f81
PE
60312011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6032
6033 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6034
09db192c
PE
60352011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6036
6037 Avoid some portability problems by eschewing 'extern inline' functions.
6038 The trivial performance wins aren't worth the portability hassles; see
6039 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6040 et seq.
6041 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6042 (window_box_width, window_box_left, window_box_left_offset)
6043 (window_box_right, window_box_right_offset): Undo previous change,
6044 by removing the "extern"s.
6045 * intervals.c (adjust_intervals_for_insertion)
6046 (adjust_intervals_for_deletion): Undo previous change,
6047 making these static again.
6048 (offset_intervals, temp_set_point_both, temp_set_point)
6049 (copy_intervals_to_string): No longer inline.
6050 * xdisp.c (window_text_bottom_y, window_box_width)
6051 (window_box_height, window_box_left_offset)
6052 (window_box_right_offset, window_box_left, window_box_right)
6053 (window_box): No longer inline.
6054
105216ed
CY
60552011-11-08 Chong Yidong <cyd@gnu.org>
6056
6057 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6058 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6059 Signal an error if not a live window.
105216ed
CY
6060 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6061 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6062
ae9e237f
JB
60632011-11-07 Juanma Barranquero <lekktu@gmail.com>
6064
6065 * lisp.h (syms_of_abbrev): Remove declaration.
6066 Reported by CHENG Gao <chenggao@royau.me>.
6067
c7aa8333
EZ
60682011-11-07 Eli Zaretskii <eliz@gnu.org>
6069
6070 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6071 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6072 of temacs in GUI mode.
6073
be7f5545
MR
60742011-11-07 Martin Rudalics <rudalics@gmx.at>
6075
6076 * window.h: Declare delete_all_child_windows instead of
6077 delete_all_subwindows.
6078 * window.c (Fwindow_nest, Fset_window_nest)
6079 (Fset_window_new_total, Fset_window_new_normal)
6080 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6081 (delete_all_subwindows): Rename to delete_all_child_windows.
6082 (Fdelete_other_windows_internal, Fset_window_configuration):
6083 Call delete_all_child_windows instead of delete_all_subwindows.
6084 * frame.c (delete_frame): Call delete_all_child_windows instead
6085 of delete_all_subwindows.
6086
ca78dc43
PE
60872011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6088
6089 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6090 This is also needed for porting to any host where GC_MARK_STACK is
6091 not GC_MAKE_GCPROS_NOOPS.
6092 (which_symbols): Use it.
6093
a0241d01
KH
60942011-11-07 Kenichi Handa <handa@m17n.org>
6095
6096 * coding.c (coding_set_destination): Check coding->src_pos only
6097 when coding->src_object is a buffer (bug#9910).
6098
6099 * process.c (send_process): Set the member src_multibyte of coding
6100 to 0 (bug#9911) when sending a unibyte text.
6101
6102 * callproc.c (Fcall_process): Set the member src_multibyte of
6103 process_coding to 0 (bug#9912).
6104
a64bfdfa 61052011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6106
6107 * xmenu.c (cleanup_widget_value_tree): New function.
6108 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6109 calling free_menubar_widget_value_tree directly (Bug#9830).
6110
cb41b32a
PE
61112011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6112
6113 Fix some portability problems with 'inline'.
6114 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6115 (window_box_width, window_box_left, window_box_left_offset)
6116 (window_box_right, window_box_right_offset): Declare extern.
6117 Otherwise, these inline functions do not conform to C99 and
6118 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6119 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6120 * intervals.c (adjust_intervals_for_insertion)
6121 (adjust_intervals_for_deletion): Now extern, because otherwise the
6122 extern inline functions 'offset_intervals' couldn't refer to it.
6123 (static_offset_intervals): Remove.
6124 (offset_intervals): Rewrite using the old contents of
6125 static_offset_intervals. The old version didn't conform to C99
6126 because an extern inline function contained a reference to an
6127 identifier with static linkage.
6128
b7041366
AS
61292011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6130
6131 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6132 GC.
6133
88a37c4d
EZ
61342011-11-06 Eli Zaretskii <eliz@gnu.org>
6135
6136 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6137 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6138 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6139 return Qleft_to_right.
6140
49745b39
CY
61412011-11-06 Chong Yidong <cyd@gnu.org>
6142
6143 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6144 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6145 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6146 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6147 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6148 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6149 (Fwindow_vscroll): Doc fix.
6150 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6151 argument, since it makes no sense to pass a live window and for
6152 consistency with window-child.
6153
1f05cd82
CS
61542011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6155
6156 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6157 support MSVC.
6158
22610910
JR
61592011-11-05 Jason Rumney <jasonr@gnu.org>
6160
6161 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6162 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6163 fonts (Bug#6029).
6164 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6165 bitwise arithmetic preventing use of unicode-sip and non-truetype
6166 opentype fonts.
6167
a06776b2
EZ
61682011-11-05 Eli Zaretskii <eliz@gnu.org>
6169
3ad924ba
EZ
6170 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6171 "emacs"-only part.
6172
a06776b2
EZ
6173 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6174 initialization code to keep similarity to xfns.c after changes
6175 from 2011-11-05.
6176
c9e7db78
JD
61772011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6178
a97f8f3f
JD
6179 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6180 (unwind_create_frame): New function (Bug#9943).
6181 (Fx_create_frame): Restructure code to be more similar to the one in
6182 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6183 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6184 Move terminal->reference_count++ just before making the frame official
6185 (Bug#9943).
6186
6187 * nsterm.m (x_free_frame_resources): New function.
6188 (x_destroy_window): Move code to x_free_frame_resources.
6189
c9e7db78 6190 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6191 (Fx_create_frame, x_create_tip_frame):
6192 Move terminal->reference_count++ just before making the frame
75f1671a 6193 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6194 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6195
a6fc3b5c
EZ
61962011-11-05 Eli Zaretskii <eliz@gnu.org>
6197
6198 Support MSVC build with newer versions of Visual Studio.
6199 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6200 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6201 nt/gmake.defs.
6202
6203 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6204 which are not supported by MSVC.
6205 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6206 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6207 bitfields.
6208 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6209 types in bitfields.
6210 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6211
6212 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6213
58179cce 62142011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6215
6216 Support MSVC build with newer versions of Visual Studio.
6217 * w32.c: Don't include w32api.h for MSVC.
6218 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6219
6220 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6221 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6222 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6223 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6224 e_* cousins.
6225 (alloca) [_MSC_VER]: Define to _alloca.
6226
6227 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6228
6229 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6230
a58c13ed
EZ
62312011-11-04 Eli Zaretskii <eliz@gnu.org>
6232
6233 * xdisp.c (note_mouse_highlight): If either of
6234 previous/next-single-property-change returns nil, treat that as
6235 the beginning or the end of the buffer. (Bug#9955)
6236
fe0b6370
JD
62372011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6238
a58c13ed 6239 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6240 label is not null (Bug#9951).
6241 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6242 may be NULL.
6243
89bd5ee1
EZ
62442011-11-04 Eli Zaretskii <eliz@gnu.org>
6245
6246 * window.c (Fwindow_body_size): Mention in the doc string that the
6247 return value is in frame's canonical units. (Bug#9949)
6248
84c3edb9
EZ
62492011-11-03 Eli Zaretskii <eliz@gnu.org>
6250
4e2fb5c7
EZ
6251 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6252
84c3edb9 6253 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6254 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6255 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6256
bc17a887
EZ
62572011-11-01 Eli Zaretskii <eliz@gnu.org>
6258
6259 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6260 Don't stop backward scan on the continuation glyph, even though
6261 its CHARPOS is positive.
6d5eb5b0
SM
6262 (mouse_face_from_buffer_pos, note_mouse_highlight):
6263 Rename cover_string to disp_string.
bc17a887 6264
4ee88440
MR
62652011-11-01 Martin Rudalics <rudalics@gmx.at>
6266
6267 * window.c (temp_output_buffer_show): Don't use
6268 Vtemp_buffer_show_specifiers.
6269 (Vtemp_buffer_show_specifiers): Remove unused variable.
6270
c2ff3c02
EZ
62712011-10-30 Eli Zaretskii <eliz@gnu.org>
6272
6273 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6274 past the beginning of the current glyph matrix.
6275
58179cce 62762011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6277
6278 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6279 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6280 HAVE_GTK3 (Bug#9869).
b77a6a7f 6281
3b574623
JD
6282 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6283 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6284
b77a6a7f
JD
6285 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6286
6287 * xterm.c: Declare x_handle_net_wm_state to return int.
6288 (handle_one_xevent): Check if we are iconified but don't have
6289 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6290 (get_current_wm_state): Return non-zero if not hidden,
6291 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6292 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6293 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6294 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6295
196e41e4
PE
62962011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6297
6298 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6299 so that this new function doesn't get optimized away by a
6300 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6301
021f2e1a
AS
63022011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6303
6304 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6305
8b058d44
EZ
63062011-10-29 Eli Zaretskii <eliz@gnu.org>
6307
6308 Fix the `xbytecode' command.
6309 * .gdbinit (xprintbytestr): New command.
b50a28de 6310 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6311 (xbytecode): Print the byte-code string as well.
6312
4452fb80
EZ
63132011-10-29 Kim Storm <storm@cua.dk>
6314
8b058d44
EZ
6315 * alloc.c (which_symbols): New function.
6316
21b72067
AS
63172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6318
6319 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6320 line. (Bug#9903)
6321
83ed7b5c
GM
63222011-10-29 Glenn Morris <rgm@gnu.org>
6323
6324 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6325 Not clear what it was for, and it causes various bugs. (Bug#9839)
6326
5a7a728b
EZ
63272011-10-28 Eli Zaretskii <eliz@gnu.org>
6328
6329 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6330 possible random value that matches one of those tested as
6331 condition to clear the mouse face.
6332
d3d0842f
CY
63332011-10-28 Chong Yidong <cyd@gnu.org>
6334
6335 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6336
31b39d13
DN
63372011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6338
6339 * window.c (make_window): Initialize phys_cursor_on_p.
6340
9aba6043
SM
63412011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6342
6343 * lisp.h (struct Lisp_Symbol): Update comments.
6344
c20992f4
JB
63452011-10-28 Juanma Barranquero <lekktu@gmail.com>
6346
6347 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6348
db4f02f2
EZ
63492011-10-28 Eli Zaretskii <eliz@gnu.org>
6350
6351 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6352 <oslsachem@gmail.com> for helping to debug this.
6353
6354 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6355 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6356 (g_b_init_get_glyph_outline_w): New static variables.
6357 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6358 (GetGlyphOutlineW_Proc): New typedefs.
6359 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6360 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6361 New functions.
6362 (w32font_open_internal, compute_metrics):
6363 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6364 instead of calling the "wide" APIs directly.
6365
6366 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6367
6368 * w32.h (syms_of_w32font): Add prototype.
6369
87e68db4
JB
63702011-10-27 Juanma Barranquero <lekktu@gmail.com>
6371
6372 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6373 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6374 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6375 (Fmove_to_window_line): Doc fix.
6376
435c1d67
CY
63772011-10-27 Chong Yidong <cyd@gnu.org>
6378
6379 * process.c (make_process): Set gnutls_state to NULL.
6380
6381 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6382 non-NULL, regardless of GNUTLS_INITSTAGE.
6383 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6384 an error. Set process slots as soon as we allocate them.
6385
6386 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6387
9c6c6f49
CY
63882011-10-27 Chong Yidong <cyd@gnu.org>
6389
9aba6043
SM
6390 * gnutls.c (emacs_gnutls_deinit): New function.
6391 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6392 (Fgnutls_deinit, Fgnutls_boot): Use it.
6393
6394 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6395 (deactivate_process): Call emacs_gnutls_deinit.
6396
657d08d3
JB
63972011-10-27 Juanma Barranquero <lekktu@gmail.com>
6398
6399 * image.c (x_create_x_image_and_pixmap):
6400 * w32.c (sys_rename, w32_delayed_load):
6401 * w32font.c (fill_in_logfont):
6402 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6403
5430d399
JB
64042011-10-26 Juanma Barranquero <lekktu@gmail.com>
6405
6406 * w32fns.c (w32_default_color_map): New function,
6407 extracted from Fw32_default_color_map.
a7ef684b 6408 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6409
fe0055fa
PE
64102011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6411
6412 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6413
e6346438
SM
64142011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6415
6416 * keyboard.c (test_undefined): New function (bug#9751).
6417 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6418
e112cc37
ET
64192011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6420
6421 * sysdep.c (init_sys_modes): Fix the check for the controlling
6422 terminal (Bug#6649).
6423
7b5d6677
EZ
64242011-10-20 Eli Zaretskii <eliz@gnu.org>
6425
6426 * dispextern.h (struct bidi_it): New member next_en_type.
6427
6428 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6429 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6430 current character, check also for next_en_type being WEAK_EN.
6431 (bidi_resolve_weak): Don't enter the expensive loop if the current
6432 position is before next_en_pos. Record the bidi type of the first
6433 non-ET, non-BN character we find, in addition to its position.
6434 (bidi_level_of_next_char): Invalidate next_en_type when
6435 next_en_pos is over-stepped.
6436
7da0b018
PE
64372011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6438
6439 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6440 * editfns.c: Rewrite current-time-zone so that it invokes
6441 the equivalent of (format-time-string "%Z") to get the time zone name.
6442 This fixes a bug when the time zone name contains characters that
6443 need converting from the system time locale to Emacs internal format.
6444 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6445 that patch fixed format-time-string to do the conversion, but
6446 I forgot to fix current-time-zone.
6447 (format_time_string): New function, containing most of
6448 what Fformat_time_string used to contain.
6449 (Fformat_time_string): Rewrite in terms of format_time_string.
6450 This doesn't change this function's behavior.
6451 (current-time-zone): Rewrite to use format_time_string.
6452 This fixes the bug reported by Michael Schierl in
6453 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6454 Jason Rumney's 2007-06-07 change worked around this bug, but
6455 didn't fix it.
6456 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6457
8547b010
EZ
64582011-10-19 Eli Zaretskii <eliz@gnu.org>
6459
6460 * xdisp.c (start_display): If the character at POS is displayed
6461 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6462 (try_window_reusing_current_matrix): If a line ends in a display
6463 vector or the next line starts in a display vector, continue
6464 redrawing the window even though the character position of
6465 start_row was reached.
8547b010
EZ
6466 (Bug#9771, part 2)
6467
4e948d15
CY
64682011-10-18 Chong Yidong <cyd@gnu.org>
6469
6470 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6471 with nobreak-char-display too.
6472
4787455f
EZ
64732011-10-18 Eli Zaretskii <eliz@gnu.org>
6474
6475 Fix part 3 of bug#9771.
6476 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6477 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6478 non-neutral characters if the current character is a paragraph
6479 separator (a.k.a. Newline). This avoids running the same
6480 expensive loop twice, once when we consume the preceding newline
6481 and the other time when the line actually needs to be displayed.
6482 Avoid the loop when we see neutrals on the base embedding level
6483 following a character whose directionality is the same as the
6484 paragraph's. This avoids running the expensive loop when a line
6485 ends in a long sequence of neutrals, like control characters.
6486 Add assertion against STRONG_AL type. Slightly rearrange code
6487 that determines the type of a neutral given the first non-neutral
6488 that follows it.
6489 (bidi_level_of_next_char): Set next_en_pos to zero when
6490 invalidating its info.
6491
2c91f553
EZ
64922011-10-17 Eli Zaretskii <eliz@gnu.org>
6493
6494 * xdisp.c (push_display_prop): Determine whether to record string
6495 or buffer position by IT->string, not by IT->method. Allow
6496 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6497 (move_it_vertically_backward): Don't look for character position
6498 immediately after the newline when in a continuation line.
6499 (Bug#9771, part 1)
2c91f553 6500
c7b08b0d
MR
65012011-10-15 Martin Rudalics <rudalics@gmx.at>
6502
6503 * window.c (coordinates_in_window): Rewrite and delabelize
6504 vertical border check. (Bug#5357) (Bug#9618)
6505
6b02f655
SM
65062011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6507
6508 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6509 errors in XSetWindowBorder (bug#9310).
6510
81d40c92
DA
65112011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6512
6513 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6514 avoid crash when xmalloc overrun checking is enabled.
6515
d4172c3b
EZ
65162011-10-13 Eli Zaretskii <eliz@gnu.org>
6517
6518 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6519 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6520 cursor motion with <left> and <right> arrow keys.
6521
6522 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6523 some callers set that themselves.
6524
b00eea75
EZ
65252011-10-12 Eli Zaretskii <eliz@gnu.org>
6526
6527 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6528 display string and the previous row comes from the same string and
6529 is empty. (Bug#9739) (Bug#9738)
6530
8fe012c4
SM
65312011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6532
6533 * doc.c (get_doc_string): Encode file name (bug#9735).
6534
0074aef2
EZ
65352011-10-12 Eli Zaretskii <eliz@gnu.org>
6536
79beb178
EZ
6537 * bidi.c (bidi_level_of_next_char):
6538 * xdisp.c (get_visually_first_element): Remove old incorrect
6539 comments regarding the Unicode Line Separator character.
6540
0074aef2
EZ
6541 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6542
6e4b3fbe
DA
65432011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6544
6545 * alloc.c (Fgc_status): Do not access beyond zombies array
6546 boundary if nzombies > MAX_ZOMBIES.
6547 * alloc.c (dump_zombies): Add missing format specifier.
6548
0324f3af
PE
65492011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6550
b5525cac
PE
6551 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6552 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6553
0324f3af
PE
6554 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6555 Some packages use them to denote characters with modifiers.
6556
e9b5f888
AS
65572011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6558
6559 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6560 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6561 matching a pp-number. Rename parameter var to var1.
6562
127827c0
SM
65632011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6564
6565 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6566
c8fd3bd0
GM
65672011-10-08 Glenn Morris <rgm@gnu.org>
6568
6569 * callint.c (Fcall_interactively): Give a more explicit error for the
6570 'c' case with a non-character input. (Bug#8479)
6571
352ec8ff
EZ
65722011-10-08 Eli Zaretskii <eliz@gnu.org>
6573
03669ccb
EZ
6574 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6575 lines.
7061c986
EZ
6576 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6577 lines that are hscrolled on the left.
03669ccb 6578
352ec8ff
EZ
6579 * dispnew.c (buffer_posn_from_coords): Account for a possible
6580 presence of header-line. (Bug#4426)
6581
a66cfb1c
SM
65822011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6583
6b02f655
SM
6584 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6585 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6586
7c5ee88e
PE
65872011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6588
6589 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6590 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6591 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6592 this makes Emacs dump core during garbage collection on rare
6593 occasions. sizeof is obviously inferior to offsetof here, so
6594 stick with offsetof.
6595 (GC_POINTER_ALIGNMENT): New macro.
6596 (mark_memory): Omit 3rd (offset) arg; caller changed.
6597 Don't assume EMACS_INT alignment is the same as pointer alignment.
6598
df1bbe5b
SM
65992011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6600
6601 * keyboard.c (read_key_sequence_remapped): New var.
6602 (read_key_sequence): Compute remapping in the right buffer.
6603 (command_loop_1): Use read_key_sequence's remapping directly.
6604
51553db6
SM
66052011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6606
32c1fffd
SM
6607 * dired.c (file_name_completion): Don't expand file name.
6608 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6609 before checking file name handler.
6610
51553db6
SM
6611 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6612 they've been requested explicitly (bug#9591).
6613
b6bd1599 66142011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6615
6616 * keymap.c (Fsingle_key_description): Use make_specified_string
6617 instead of build_string to build string from push_key_description.
6618 (Bug#5193)
6619
f701dc2a
PE
66202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6621
4222c55d
PE
6622 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6623 This fixes a Y2038 bug on 64-bit hosts.
6624 * buffer.c (reset_buffer):
6625 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6626 (Fclear_buffer_auto_save_failure):
6627 Use 0, not -1, to represent an unset failure time, since time_t
6628 might not be signed.
6629
f701dc2a
PE
6630 Remove dependency on glibc malloc internals.
6631 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6632 Move back here from lisp.h, but with their new implementations.
6633 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6634 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6635 * charset.c (charset_table_init): New static var.
6636 (syms_of_charset): Use it instead of xmalloc. This removes a
6637 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6638 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6639 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6640 Move back to alloc.c.
6641 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6642 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6643
9ceebf39
JD
66442011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6645
6646 * nsterm.m (windowDidResize): Call x_set_window_size only when
6647 ns_in_resize is true. Otherwise set pixelwidth/height and
6648 call change_frame_size (Bug#9628).
6649
cb993c58
PE
66502011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6651
3930c88b
PE
6652 Port --enable-checking=all to Fedora 14 x86-64.
6653 * charset.c (syms_of_charset): Also account for glibc malloc's
6654 internal overhead when calculating the initial malloc maximum.
6655
cb993c58
PE
6656 Port --enable-checking=all to Fedora 14 x86.
6657 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6658 Move to lisp.h.
6659 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6660 (overrun_check_realloc, overrun_check_free):
6661 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6662 That way, xmalloc returns a properly-aligned pointer even if
6663 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6664 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6665 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6666 into account when calculating the initial malloc maximum.
6667 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6668 Move here from alloc.c, so that charset.c can use it too.
6669 Properly align; the old code wasn't right for common 32-bit hosts
6670 when configured with --enable-checking=all.
6671 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6672 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6673
31bed486
EZ
66742011-09-29 Eli Zaretskii <eliz@gnu.org>
6675
04c70788 6676 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6677 use EDOM.
6678
fbcaa2f3
EZ
66792011-09-28 Eli Zaretskii <eliz@gnu.org>
6680
6681 * xdisp.c (compute_display_string_end): If there's no display
6682 string at CHARPOS, return -1.
6683
6684 * bidi.c (bidi_fetch_char): When compute_display_string_end
6685 returns a negative value, treat the character as a normal
6686 character not covered by a display string. (Bug#9624)
6687
a239d4e9
JB
66882011-09-28 Juanma Barranquero <lekktu@gmail.com>
6689
6690 * lread.c (Fread_from_string): Fix typo in docstring.
6691
88652fd5
EZ
66922011-09-27 Eli Zaretskii <eliz@gnu.org>
6693
6694 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6695 newline, reseat the iterator instead of bidi-iterating there one
6696 character at a time. (Bug#9610)
32c1fffd
SM
6697 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6698 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6699
ed497dd4
AS
67002011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6701
6702 * lread.c (readevalloop): Use correct code for NBSP.
6703 (read1): Likewise. (Bug#9608)
6704
b2bf61aa
MA
67052011-09-25 Michael Albinus <michael.albinus@gmx.de>
6706
6707 * dbusbind.c (Fdbus_register_signal): When service is not
6708 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6709
32bbb17c
GM
67102011-09-25 Glenn Morris <rgm@gnu.org>
6711
6712 * buffer.c (truncate-lines): Doc fix.
6713
94e0933e
CY
67142011-09-24 Chong Yidong <cyd@stupidchicken.com>
6715
6716 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6717 (Fset_window_next_buffers): Doc fix.
6718
cddde921
GM
67192011-09-24 Glenn Morris <rgm@gnu.org>
6720
6721 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6722
1260aef1
PE
67232011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6724
25b4bfa0
PE
6725 Fix minor problems found by static checking.
6726 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6727 * indent.c (Fvertical_motion): Fix == vs = typo.
6728
e3cbd34b
EZ
67292011-09-24 Eli Zaretskii <eliz@gnu.org>
6730
a66cfb1c
SM
6731 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6732 Default value is now t. Doc fix.
6bf7006f 6733
e3cbd34b 6734 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6735 logic when moving up, not only when moving down. Fix the
e3cbd34b 6736 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6737 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6738
6739 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6740 CHARPOS is covered by a display string which includes newlines.
6741 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6742 is covered by a display string with embedded newlines.
6743
a3de0cbd
MA
67442011-09-24 Michael Albinus <michael.albinus@gmx.de>
6745
6746 * dbusbind.c (Fdbus_register_signal): Add match rule to
6747 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6748 (Fdbus_register_method, Vdbus_registered_objects_table):
6749 Fix docstring.
a3de0cbd 6750
b260039d
JM
67512011-09-24 Jim Meyering <meyering@redhat.com>
6752
32c1fffd 6753 do not ignore write error for any output size
b260039d
JM
6754 The previous change was incomplete.
6755 While it makes emacs --batch detect the vast majority of stdout
6756 write failures, errors were still ignored whenever the output size is
6757 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6758 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6759 && echo FAIL: ignored write error
6760 FAIL: ignored write error
6761 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6762 && echo FAIL: ignored write error
6763 FAIL: ignored write error
6764 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6765
8eca8a7c
AS
67662011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6767
6768 * emacs.c (Fkill_emacs): In noninteractive mode exit
6769 non-successfully if a write error occurred on stdout. (Bug#9574)
6770
3341db62
EZ
67712011-09-21 Eli Zaretskii <eliz@gnu.org>
6772
6773 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6774 the xassert test.
6775
6776 * dispextern.h (struct it): Update the comment documenting what
6777 can it->OBJECT be.
6778
8c203dbf
EZ
67792011-09-20 Eli Zaretskii <eliz@gnu.org>
6780
6781 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6782 a display string, extend search for cursor position to end of row.
6783 (find_row_edges): If the row ends in a newline from a display
6784 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6785 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6786 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6787 non-empty line. Fixes confusing cursor motion with arrow keys at
6788 the beginning of a line that starts with whitespace.
8c203dbf 6789
a4824228
LMI
67902011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6791
6792 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6793 (bug#9493).
6794
33ed493b
CY
67952011-09-18 Chong Yidong <cyd@stupidchicken.com>
6796
6797 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6798 boolean (Bug#9154).
6799
56cd55c8
EZ
68002011-09-18 Eli Zaretskii <eliz@gnu.org>
6801
6802 * xdisp.c (display_line): Record maximum and minimum buffer
6803 positions even if no glyphs were produced (e.g., by a zero-width
6804 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6805 buffer positions that will be removed from the glyph row because
6806 they don't fit.
c02dcedf
EZ
6807 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6808 column is beyond frame width: don't subtract 1 "pixel" when
6809 computing width of the stretch.
3e62b7e0
EZ
6810 (reseat_at_next_visible_line_start): Undo the change made on
6811 2011-09-17 that saved paragraph information and restored it after
6812 the call to `reseat'. (Bug#9545)
56cd55c8 6813
5ed99d36 68142011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6815
6816 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6817 and turn window cursor on if cleared (Bug#9415).
6818
5ed99d36 68192011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6820
6821 * search.c (boyer_moore): Take unibyte characters from pattern
6822 literally. (Bug#9458)
6823
9bade7b2
EZ
68242011-09-18 Eli Zaretskii <eliz@gnu.org>
6825
6826 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6827
e5e9d610
PE
68282011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6829
87e4427a
PE
6830 Fix minor problem found by static checking.
6831 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6832 initialized, to pacify gcc -Wuninitialized.
6833
e5e9d610
PE
6834 * fileio.c: Report proper errno when syscall falls.
6835 (Finsert_file_contents): Save and restore errno,
6836 so that report_file_error outputs the correct diagnostic.
6837 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6838
a1674f0b
EZ
68392011-09-18 Eli Zaretskii <eliz@gnu.org>
6840
6841 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6842
fbfb6dd4
EZ
68432011-09-17 Eli Zaretskii <eliz@gnu.org>
6844
6845 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6846 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6847
bb187662
EZ
68482011-09-17 Eli Zaretskii <eliz@gnu.org>
6849
1137e8b8 6850 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6851 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6852
6853 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6854 (bidi_find_paragraph_start): Search back for paragraph beginning
6855 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6856 (bidi_move_to_visually_next): Only trigger paragraph-related
6857 computations when the last character is a newline or at EOB, not
6858 just any NEUTRAL_B. (Bug#9470)
6859
bb187662
EZ
6860 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6861 truncated lines if point is covered by a display string. (Bug#9524)
6862
2e621251
PE
68632011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6864
6865 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6866 (cons_to_x_long): New function.
6867 (lisp_data_to_selection_data): Use it. Correct the test for
6868 short-versus-long data; it was negated. Break out of vector
6869 loop, for efficiency, when a long datum is discovered.
6870
91a15bc6
SM
68712011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6872
6873 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6874
b41c3a35
EZ
68752011-09-16 Eli Zaretskii <eliz@gnu.org>
6876
6877 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6878 GCC PR/17406) by declaring this function with external scope.
6879
7812ba2d
PE
68802011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6881
6882 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6883 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6884
cf7edc2a
AS
68852011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6886
6887 * editfns.c (Fformat): Correctly handle text properties on "%%".
6888
bd01620e
EZ
68892011-09-15 Eli Zaretskii <eliz@gnu.org>
6890
6891 * xterm.c (x_draw_composite_glyph_string_foreground):
6892 * w32term.c (x_draw_composite_glyph_string_foreground):
6893 * term.c (encode_terminal_code):
6894 * composite.c (composition_update_it, get_composition_id):
6895 * xdisp.c (get_next_display_element)
6896 (fill_composite_glyph_string): Add comments about special meaning
6897 of TAB characters in a composition.
6898
a02719a3
PE
68992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6900
6901 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6902 This occurs when processing a multibyte format.
6903 Problem reported by Wolfgang Jenker.
a02719a3 6904
72589a3c
JB
69052011-09-15 Johan Bockgård <bojohan@gnu.org>
6906
6907 * xdisp.c (try_cursor_movement): Only check for exact match if
6908 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6909
1c14176c
PE
69102011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6911
6912 Remove unused external symbols.
6913 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6914 * xdisp.c (calc_pixel_width_or_height): Now static.
6915 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6916 * indent.c (check_display_width):
6917 * w32term.c: Fix comment to match code.
6918 * xterm.c, xterm.h (x_catching_errors): Remove.
6919
d2eea5b5
PE
69202011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6921
6922 * xselect.c: Use signed conversions more consistently (Bug#9498).
6923 (selection_data_to_lisp_data): Assume incoming selection data are
6924 signed integers, not unsigned. This is to be consistent with
6925 outgoing selection data, which was modified to use signed integers
6926 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6927 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6928 expects long, not unsigned long.
6929
46888499
EZ
69302011-09-14 Eli Zaretskii <eliz@gnu.org>
6931
6932 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6933 computation of loop end. Reported by Johan Bockgård
6934 <bojohan@gnu.org>.
6935
ef8ef9fb
CY
69362011-09-13 Chong Yidong <cyd@stupidchicken.com>
6937
6938 * frame.c (Fother_visible_frames_p): Function deleted.
6939
fa819fed
EZ
69402011-09-12 Eli Zaretskii <eliz@gnu.org>
6941
6942 * indent.c (compute_motion): Process display vector front to back
6943 rather than the other way around. (Bug#2496)
6944
2ba8e008
SM
69452011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6946
6947 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6948
20f53c69
CY
69492011-09-11 Chong Yidong <cyd@stupidchicken.com>
6950
6951 * minibuf.c (Fread_from_minibuffer): Doc fix.
6952
d562d7a4
EZ
69532011-09-11 Eli Zaretskii <eliz@gnu.org>
6954
6955 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6956 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6957
1c4d7f3d
LMI
69582011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6959
6960 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6961 value for non-existent files.
6962
b885bf36
EZ
69632011-09-11 Eli Zaretskii <eliz@gnu.org>
6964
6965 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6966 set its "size" to -1. This will set the modtime_size field of
6967 the corresponding buffer to -1, which is what
6968 verify-visited-file-modtime expects for files that do not exist.
6969 (Bug#9139)
6970
6612f0bf
PE
69712011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6972
6973 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6974 here ...
6975 * lisp.h: ... from here. push_key_description is no longer
6976 defined in keyboard.c, so its declaration should not be in
6977 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6978 logically belongs with push_key_description.
6979
dfb3f755
PE
69802011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6981
6982 * buffer.h: Include <sys/types.h> instead of <time.h>.
6983 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6984 Problem reported by Herbert J. Skuhra.
6985
3134906c
LMI
69862011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6987
6988 * xml.c (parse_region): Make the parsing work for
6989 non-comment-starting XML files again (bug#9144).
6990
8d903f4e
AS
69912011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6992
6993 * image.c (gif_load): Fix calculation of bottom and right corner.
6994 (Bug#9468)
6995
80ad64f4
EZ
69962011-09-10 Eli Zaretskii <eliz@gnu.org>
6997
6998 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6999 redisplay in small windows.
7000
208a048d
EZ
70012011-09-09 Eli Zaretskii <eliz@gnu.org>
7002
7003 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7004
9b1c252e
MR
70052011-09-08 Martin Rudalics <rudalics@gmx.at>
7006
7007 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7008 Operate on live windows only.
7009
2949f33b
JB
70102011-09-08 Juanma Barranquero <lekktu@gmail.com>
7011
7012 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7013
e08dcafd
EZ
70142011-09-07 Eli Zaretskii <eliz@gnu.org>
7015
7016 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7017 only under bidi iteration.
7018
115b96bd
JD
70192011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7020
7021 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7022
c8199d0f
PE
70232011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7024
7025 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7026 Without this fix, the command to link temacs failed due to an
7027 undefined symbol __builtin_isnan. This is because
7028 /usr/include/iso/math_c99.h #defines isnan(x) to
7029 __builtin_isnan(x), but the bundled gcc, which identifies itself
7030 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7031 a __builtin_isnan.
7032 * floatfns.c (isnan): #undef, and then #define to a clone of
7033 what's in data.c.
7034 (Fisnan): Always define, since it's always available now.
7035 (syms_of_floatfns): Always define isnan at the Lisp level.
7036
e39b275c 70372011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7038
7039 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7040
b2db44d9 70412011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7042
f4af5137 7043 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7044 The previous code assumed that file offsets (off_t values) fit in
7045 EMACS_INT variables, which is not true on typical 32-bit hosts.
7046 The code messed up by falsely reporting buffer overflow in cases
7047 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7048 when "big" contains more than 2**29 bytes, even though this
7049 inserts just one byte and does not overflow the buffer.
7050 (Finsert_file_contents): Store file offsets as off_t
7051 values, not as EMACS_INT values. Check for overflow when
7052 converting between EMACS_INT and off_t. When checking for
7053 buffer overflow or for overlap, take the offsets into account.
7054 Don't use EMACS_INT for small values where int suffices.
7055 When checking for overlap, fix a typo: ZV was used where
7056 ZV_BYTE was intended.
7057 (Fwrite_region): Don't assume off_t fits into 'long'.
7058 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7059
ecfc0a49
MA
70602011-09-05 Michael Albinus <michael.albinus@gmx.de>
7061
7062 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7063
6511acf2 70642011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7065
0999621a 7066 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7067
7068 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7069 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7070 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7071 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7072 (modify_event_symbol): Do not assume that the length of
7073 name_alist_or_stem is safe to alloca and fits in int.
7074 (Fexecute_extended_command): Likewise for function name and binding.
7075 (Frecursion_depth): Wrap around reliably on integer overflow.
7076 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7077 since some callers pass EMACS_INT values.
7078 (Fsingle_key_description): Don't crash if symbol name contains more
7079 than MAX_ALLOCA bytes.
7080 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7081 (get_minibuffer): Arg is now EMACS_INT, not int.
7082 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7083 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7084 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7085
2be7d702
PE
7086 * dbusbind.c (signature_cat): New function.
7087 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7088 Do not overrun buffer; instead, report string overflow.
7089
9d1df220
PE
7090 * dispnew.c (add_window_display_history): Don't overrun buffer.
7091 Truncate instead; this is OK since it's just a log.
7092
33ef5c64
PE
7093 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7094 even if the time zone offset is outlandishly large.
7095 Don't mishandle offset == INT_MIN.
7096
66c6fdd5
PE
7097 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7098 when creating daemon; the previous buffer-overflow check was incorrect.
7099
d749b01b
PE
7100 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7101 which has the guts of the old verror function.
7102
b5cd1905
PE
7103 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7104 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7105
6e1a67fb
PE
7106 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7107 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7108 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7109 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7110 length of string rather than counting it via multiple sprintfs;
7111 that's simpler and more reliable.
c21721cc
PE
7112 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7113 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7114 sprintf, in case result does not fit in int.
7115
c57b67fc
PE
7116 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7117 (fontset_from_font): Print it.
7118
8a401434
PE
7119 * frame.c (tty_frame_count): Now printmax_t, not int.
7120 (make_terminal_frame, set_term_frame_name): Print it.
7121 (x_report_frame_params): In X, window IDs are unsigned long,
7122 not signed long, so print them as unsigned.
7123 (validate_x_resource_name): Check for implausibly long names,
7124 and don't assume name length fits in 'int'.
7125 (x_get_resource_string): Don't blindly alloca invocation name;
7126 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7127 not fit in int.
7128
6e1a67fb
PE
7129 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7130 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7131 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7132
0df02bf3
PE
7133 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7134 Use esprintf, not sprintf, in case result does not fit in int.
7135
48e30793
PE
7136 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7137 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7138 it as a large positive number.
7139 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7140 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7141
a66ff6d8
PE
7142 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7143 in case result does not fit in int.
7144
aca216ff
PE
7145 * print.c (float_to_string): Detect width overflow more reliably.
7146 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7147 buffer overrun. Don't assume list length fits in 'int'. Treat
7148 print length of 0 as 0, not as infinity; to be consistent with other
7149 uses of print length in this function. Don't overflow print length
7150 index. Don't assume hash table size fits in 'long', or that
7151 vectorlike size fits in 'unsigned long'.
7152
31c286f7
PE
7153 * process.c (make_process): Use printmax_t, not int, to format
7154 process-name gensyms.
7155
55e5faa1
PE
7156 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7157
80f2e268
PE
7158 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7159 to avoid potential buffer overrun.
7160
670741ab
PE
7161 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7162 if X resource line is longer than 512 bytes.
7163
b7163a50
PE
7164 * xfns.c (x_window): Make sprintf buffer a bit bigger
7165 to avoid potential buffer overrun.
7166
ae58ff1f
PE
7167 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7168
c43c8a6a
PE
7169 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7170
3f8236f4
PE
71712011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7172
53e9fe90 7173 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7174 Without these, Emacs silently mishandles large integers sometimes.
7175 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7176 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7177
6511acf2
PE
7178 * xdisp.c (try_window_id): Check Emacs fixnum range before
7179 converting to 'int'.
806add1d 7180
6511acf2 7181 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7182 Check that an Emacs fixnum is in range before assigning it to 'int'.
7183 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7184 values converted from Emacs fixnums.
7185 (Frecenter): Don't wrap around a line count if it is out of 'int'
7186 range; instead, treat it as an extreme value.
7187 (Fset_window_configuration, compare_window_configurations):
7188 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7189
6511acf2
PE
7190 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7191 that can exceed INT_MAX. Check that EMACS_INT value is in range
7192 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7193 (match_limit): Don't assume that a fixnum can fit in 'int'.
7194
6511acf2 7195 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7196 exceed INT_MAX.
7197
6511acf2 7198 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7199 (Fvertical_motion): Don't wrap around LINES values that don't fit
7200 in 'int'. Instead, treat them as extreme values. This is good
7201 enough for windows, which can't have more than INT_MAX lines anyway.
7202
fcb901a7
LMI
72032011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7204
0f2f6b6d
LMI
7205 * Require libxml/parser.h to avoid compilation warning.
7206
fcb901a7
LMI
7207 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7208
7209 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7210 since this reportedly can destroy thread storage.
7211
6e20a0d4
CY
72122011-08-30 Chong Yidong <cyd@stupidchicken.com>
7213
7214 * syntax.c (find_defun_start): Update all cache variables if
7215 exiting early (Bug#9401).
7216
148ae00e
EZ
72172011-08-30 Eli Zaretskii <eliz@gnu.org>
7218
f6cfbd8f
EZ
7219 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7220
148ae00e
EZ
7221 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7222 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7223 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7224
7225 * term.c (tty_append_glyph): New function.
7226 (produce_stretch_glyph): Static function and its prototype deleted.
7227
a66cfb1c
SM
7228 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7229 Add prototypes.
148ae00e 7230
c4a07a4c
PE
72312011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7232
7233 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7234 when checking :margin (Bug#9390).
7235 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7236 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7237 so that the name doesn't mislead. All uses changed.
7238
6bc8cd65
JB
72392011-08-28 Johan Bockgård <bojohan@gnu.org>
7240
7241 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7242 set_tty_hooks.
7243
dca4927e
EZ
72442011-08-27 Eli Zaretskii <eliz@gnu.org>
7245
7246 * xdisp.c (move_it_to): Don't bail out early when reaching
7247 position beyond to_charpos, if we are scanning backwards.
7248 (move_it_vertically_backward): When DY == 0, make sure we get to
7249 the first character in the line after the newline.
7250
f2cad773
PE
72512011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7252
7253 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7254 (ccl_driver): Do not generate an out-of-range pointer.
7255 (Fccl_execute_on_string): Remove unnecessary check for
7256 integer overflow, noted by Stefan Monnier in
7257 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7258 Remove a FIXME that didn't need fixing.
7259 Simplify the newly-introduced buffer reallocation code.
7260
0cae2cdb
JB
72612011-08-27 Juanma Barranquero <lekktu@gmail.com>
7262
7263 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7264
5fc295a4 72652011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7266
70c60eb2 7267 Integer and memory overflow issues (Bug#9196).
726e0ab1 7268
d31850da
PE
7269 * doc.c (get_doc_string): Rework so that
7270 get_doc_string_buffer_size is the actual buffer size, rather than
7271 being 1 less than the actual buffer size; this makes xpalloc more
7272 convenient.
7273
a69fbedb
PE
7274 * image.c (x_allocate_bitmap_record, cache_image):
7275 * xselect.c (Fx_register_dnd_atom):
7276 Simplify previous changes by using xpalloc.
7277
fe5c5d37
PE
7278 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7279 since either will do and ptrdiff_t is convenient with xpalloc.
7280
0065d054
PE
7281 * charset.c (charset_table_size)
7282 (struct charset_sort_data.priority): Now ptrdiff_t.
7283 (charset_compare): Don't overflow if priorities differ greatly.
7284 (Fsort_charsets): Don't assume list length fits in int.
7285 Check for size-calculation overflow when allocating sort data.
7286 (syms_of_charset): Allocate an initial charset table that is
7287 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7288
7289 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7290
7291 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7292 The actual value is always <= INT_MAX, and leaving it unsigned made
7293 overflow checking harder.
7294
7295 * dispextern.h (struct glyph_matrix.rows_allocated)
7296 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7297 with xpalloc. The values are still always <= INT_MAX.
7298
7299 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7300
7301 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7302 (SAFE_NALLOCA): New macro.
7303
7304 * region-cache.c (struct boundary.pos, find_cache_boundary)
7305 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7306 (set_cache_region, invalidate_region_cache)
7307 (revalidate_region_cache, know_region_cache, region_cache_forward)
7308 (region_cache_backward, pp_cache):
7309 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7310 so that ptrdiff_t * can be passed to xpalloc.
7311 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7312 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7313 (pp_cache): Don't assume cache_len fits in int.
7314 * region-cache.h: Adjust extern decls to match.
7315
7316 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7317 EMACS_INT, since either will do, for xpalloc.
7318
7319 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7320 (xnmalloc, xnrealloc, xpalloc): New functions.
7321
726e0ab1
PE
7322 * bidi.c (bidi_shelve_header_size): New constant.
7323 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7324 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7325
51f30bc5 7326 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7327 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7328 (overlay_strings):
7329 Don't update size of array until after memory allocation succeeds,
7330 because xmalloc/xrealloc may not return.
0065d054
PE
7331 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7332 now that we have proper integer overflow checking.
7333 (record_overlay_string, overlay_strings): Catch overflows when
7334 calculating size of overlay_str_buf.
726e0ab1 7335
0065d054
PE
7336 * callproc.c (Fcall_process): Check for size overflow when
7337 calculating size of args2.
7338 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7339 Normally we prefer signed values, but sticking with ptrdiff_t would
7340 require adding more-complicated checks.
726e0ab1
PE
7341
7342 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7343 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7344 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7345 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7346
7347 * character.c (Fstring): Check for size-calculation overflow.
7348
7349 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7350 unnecessary integer overflow. Check for size overflow.
7351 (encode_coding_object): Don't update size until xmalloc succeeds.
7352
7353 * composite.c (get_composition_id): Check for overflow in glyph
7354 length calculations.
7355
7356 Integer and memory overflow fixes for display code.
7357 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7358 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7359 (scrolling_window): Check for overflow in size calculations.
7360 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7361 Don't assume glyph table len fits in int.
7362 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7363 (row_table_size): Now ptrdiff_t, not int.
7364 (scrolling_window): Avoid overflow in size calculations.
7365 Don't update size until allocation succeeds.
7366 * fns.c (concat): Check for overflow in size calculations.
7367 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7368 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7369 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7370
7371 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7372 (get_doc_string): Check for size calculation overflow.
7373 Don't update size until allocation succeeds.
7374 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7375 EMACS_INT, where ptrdiff_t will do.
7376 (Fsubstitute_command_keys): Check for string overflow.
7377
7378 * editfns.c (set_time_zone_rule): Don't assume environment length
7379 fits in int.
7380 (message_length): Now ptrdiff_t, not int.
7381 (Fmessage_box): Don't update size until allocation succeeds.
7382 Don't assume message length fits in int.
7383 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7384
0065d054
PE
7385 * emacs.c (main): Do not reallocate argv, since there is a null at
7386 the end that can be overwritten, and this way there's no need to
7387 worry about size-calculation overflow.
7388 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7389
7390 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7391 alloc succeeds.
7392 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7393
7394 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7395 (x_set_scroll_bar_width, x_figure_window_size):
7396 Check for integer overflow.
7397 (x_set_alpha): Do not assume XINT fits in int.
7398
7399 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7400 This is for the members text_lines, text_cols, total_lines, total_cols,
7401 where the system imposes an 'int' limit.
7402
7403 * fringe.c (Fdefine_fringe_bitmap):
7404 Don't update size until alloc works.
7405
7406 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7407 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7408
7409 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7410 Check for size-calculation overflow.
7411 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7412 do, as we prefer signed integers.
7413 (id_to_widget.max_size, id_to_widget.used)
7414 (xg_store_widget_in_map, xg_remove_widget_from_map)
7415 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7416 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7417 Use and return ptrdiff_t, not int.
7418 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7419 * gtkutil.h: Change prototypes to match the above.
7420
7421 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7422 are duplicate now that they've been promoted to lisp.h.
7423 (x_allocate_bitmap_record, x_alloc_image_color)
7424 (make_image_cache, cache_image, xpm_load):
7425 Don't update size until alloc is done.
7426 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7427 (x_detect_edges):
3256efce 7428 Check for size calculation overflow.
726e0ab1
PE
7429 (ct_colors_allocated_max): New constant.
7430 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7431 overflow.
3256efce 7432
726e0ab1
PE
7433 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7434 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7435 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7436 Use ptrdiff_t, not int, to count maps.
7437 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7438 calculations. Don't update size until allocation succeeds.
7439 Redo calculations to avoid overflow.
726e0ab1
PE
7440 * keyboard.h: Change prototypes to match the above.
7441
7442 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7443 to count maps.
7444 (current_minor_maps): Check for size calculation overflow.
7445 * keymap.h: Change prototypes to match the above.
7446
7447 * lread.c (read1, init_obarray): Don't update size until alloc done.
7448
7449 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7450 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7451
726e0ab1
PE
7452 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7453 Now ptrdiff_t, not int.
7454 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7455 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7456
7457 * process.c (Fnetwork_interface_list): Check for overflow
7458 in size calculation.
7459
7460 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7461
7462 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7463 overflow. Don't bother calling xmalloc when xrealloc will do.
7464
7465 * search.c (Freplace_match): Check for size calculation overflow.
7466 (Fset_match_data): Don't assume list lengths fit in 'int'.
7467
7468 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7469 for command line length. Do not attempt to address one before the
7470 beginning of an array, as that's not portable.
7471
7472 * term.c (max_frame_lines): Remove; unused.
7473 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7474 not int.
7475 (encode_terminal_code, calculate_costs): Check for size
7476 calculation overflow.
7477 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7478 table lengths and related sizes. Don't update size until alloc
7479 done. Redo calculations to avoid overflow.
7480 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7481
7482 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7483 subtracting pointers.
7484 (gobble_line): Check for overflow more carefully. Don't update size
7485 until alloc done.
7486
7487 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7488 Don't update size until alloc done.
7489 Redo size calculations to avoid overflow.
7490 Check for size calculation overflow.
0065d054 7491 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7492
7493 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7494 Use ptrdiff_t, not int, for sizes.
7495 (store_mode_line_noprop_char): Don't update size until alloc done.
7496
0065d054
PE
7497 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7498 Use ptrdiff_t, not int, for sizes.
7499 (Finternal_make_lisp_face, cache_face):
7500 Check for size calculation overflow.
7501 (cache_face): Treat size calculation overflows as if they were
7502 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7503
7504 * xfns.c (x_encode_text, x_set_name_internal)
7505 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7506 sizes, since they can exceed INT_MAX in size. Check for size
7507 calculation overflow.
7508
0065d054
PE
7509 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7510 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7511 Don't update size until alloc done.
7512
0065d054 7513 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7514 as sprintf is limited to int lengths.
1d526e2f 7515
252c5ee1
PE
7516 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7517 (X_LONG_MIN): New macros.
864d7ce7
PE
7518 Use them to make the following changes clearer.
7519 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7520 This change doesn't affect the value now, but it may help remind
7521 future maintainers not to raise the value too much later.
7522 (SELECTION_QUANTUM): Remove, replacing with ...
7523 (selection_quantum): ... new function, which avoids overflow.
7524 All uses changed.
7525 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7526 assumption that selection length fits in 'int'.
7527 (x_reply_selection_request, x_handle_selection_request)
7528 (x_get_window_property, receive_incremental_selection)
7529 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7530 (lisp_data_to_selection_data, clean_local_selection_data):
7531 Use ptrdiff_t, not int, to record length of selection.
7532 (x_reply_selection_request, x_get_window_property)
7533 (receive_incremental_selection, x_property_data_to_lisp):
7534 Redo calculations to avoid overflow.
7535 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7536 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7537 something.
7538 (x_get_window_property, receive_incremental_selection)
7539 (lisp_data_to_selection_data, x_property_data_to_lisp):
7540 Check for size-calculation overflow.
7541 (x_get_window_property, receive_incremental_selection)
7542 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7543 Don't store size until memory allocation succeeds.
7544 (x_get_window_property): Plug memory leak on memory exhaustion.
7545 Don't double-block input; malloc is safe here. Don't assume 2**34
7546 - 4 fits in unsigned long. Add an xassert to check
7547 XGetWindowProperty overflow. Be more careful about overflow
7548 calculations, and distinguish size from memory overflow better.
7549 (receive_incremental_selection): When tracing, don't assume
7550 unsigned int is less than INT_MAX.
7551 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7552 harmful) conversions of unsigned short to int.
7553 (lisp_data_to_selection_data): Don't assume that integers
7554 in the range -65535 through -1 fit in an X unsigned short.
7555 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7556 result parameters unless successful. Rely on cons_to_unsigned
7557 to report problems with elements; the old code wasn't right anyway.
7558 (x_check_property_data): Check for int overflow; we cannot use
7559 a wider type due to X limits.
7560 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7561
726e0ab1 7562 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7563
0065d054
PE
7564 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7565 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7566 (x_color_cells): Don't store size until memory allocation succeeds.
7567 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7568 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7569 (x_term_init): Don't assume length fits in int (sprintf is limited
7570 to int size).
bc18e09d 7571
ebfa62c0
PE
7572 Use ptrdiff_t for composition IDs.
7573 * character.c (lisp_string_width):
7574 * composite.c (composition_table_size, n_compositions)
7575 (get_composition_id, composition_gstring_from_id):
7576 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7577 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7578 * window.c (Frecenter):
7579 Use ptrdiff_t, not int, for composition IDs.
7580 * composite.c (get_composition_id): Check for integer overflow.
7581 * composite.h: Adjust prototypes to match the above changes.
7582
d3411f89
PE
7583 Use ptrdiff_t for hash table indexes.
7584 * category.c (hash_get_category_set):
7585 * ccl.c (ccl_driver):
7586 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7587 * coding.c (coding_system_charset_list, detect_coding_system):
7588 * coding.h (struct coding_system.id):
7589 * composite.c (get_composition_id, gstring_lookup_cache):
7590 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7591 * image.c (xpm_get_color_table_h):
7592 * lisp.h (hash_lookup, hash_put):
7593 * minibuf.c (Ftest_completion):
7594 Use ptrdiff_t for hash table indexes, not int (which is too
7595 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7596 32-bit --with-wide-int hosts).
7597
e097a6fa
PE
7598 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7599 Add a FIXME comment about memory leaks.
7600 (syms_of_charset): Don't assume xmalloc returns.
7601
5637687f
PE
7602 Don't assume that stated character widths fit in int.
7603 * character.c (Fchar_width, c_string_width, lisp_string_width):
7604 * character.h (CHAR_WIDTH):
7605 * indent.c (MULTIBYTE_BYTES_WIDTH):
7606 Use sanitize_char_width to avoid undefined and/or bad behavior
7607 with outlandish widths.
a66cfb1c 7608 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7609 now that we have two such functions. All uses changed.
7610 (sanitize_char_width): New inline function.
7611
a2271ba2
PE
7612 Don't assume that tab-width fits in int.
7613 * character.h (sanitize_width): New inline function.
7614 (SANE_TAB_WIDTH): New macro.
7615 (ASCII_CHAR_WIDTH): Use it.
7616 * indent.c (sane_tab_width): Remove. All uses replaced by
7617 SANE_TAB_WIDTH (current_buffer).
7618 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7619
18c52557
PE
7620 * fileio.c: Integer overflow issues with file modes.
7621 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7622
caeeedc1
PE
7623 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7624 Remove unreachable code.
7625 (read_hex, load_charset_map_from_file): Check for integer overflow.
7626
6df6ae42 7627 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7628 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7629 (x_send_scroll_bar_event): Likewise. Check that the size does not
7630 exceed limits imposed by XClientMessageEvent, as well as the usual
7631 ptrdiff_t and size_t limits.
7632
b13995db
PE
7633 * keyboard.c: Overflow, signedness and related fixes.
7634 (make_lispy_movement): Use same integer type in forward decl
7635 that is used in the definition.
7636 (read_key_sequence, keyremap_step):
7637 Change bufsize argument back to int, undoing my 2011-03-30 change.
7638 We prefer signed types, and int is wide enough here.
7639 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7640 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7641 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7642 length, not size_t. Use ptrdiff_t for index, not int.
7643 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7644 possibility of integer overflow.
7645
13464394
PE
7646 Overflow, signedness and related fixes for images.
7647
7648 * dispextern.h (struct it.stack[0].u.image.image_id)
7649 (struct_it.image_id, struct image.id, struct image_cache.size)
7650 (struct image_cache.used, struct image_cache.ref_count):
7651 * gtkutil.c (update_frame_tool_bar):
7652 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7653 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7654 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7655 * nsmenu.m (update_frame_tool_bar):
7656 * xdisp.c (calc_pixel_width_or_height):
7657 * xfns.c (image_cache_refcount):
7658 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7659 on typical 64-bit hosts.
7660
7661 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7662 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7663 Omit unnecessary casts to int.
7664 (parse_image_spec): Check that integers fall into 'int' range
7665 when the callers expect that.
7666 (image_ascent): Redo ascent calculation to avoid int overflow.
7667 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7668 (lookup_image): Remove unnecessary tests.
7669 (xbm_image_p): Locals are now of int, not EMACS_INT,
7670 since parse_image_check makes sure they fit into int.
7671 (png_load, gif_load, svg_load_image):
7672 Prefer int to unsigned where either will do.
7673 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7674 old tiff_error_handler and tiff_warning_handler.
7675 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7676 stack buffer overflows. It uses only the features of vsnprintf
7677 that are common to both POSIX and native Microsoft.
7678 (tiff_error_handler, tiff_warning_handler): Use it.
7679 (tiff_load, gif_load, imagemagick_load_image):
7680 Don't assume :index value fits in 'int'.
7681 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7682 (imagemagick_load_image): Check that crop parameters fit into
7683 the integer types that MagickCropImage accepts. Don't assume
7684 Vimagemagick_render_type has a nonnegative value. Don't assume
7685 size_t fits in 'long'.
7686 (gs_load): Use printmax_t to print the widest integers possible.
7687 Check for integer overflow when computing image height and width.
7688
c11821d4
EZ
76892011-08-26 Eli Zaretskii <eliz@gnu.org>
7690
7691 * xdisp.c (redisplay_window): Don't force window start if point
7692 will be invisible in the resulting window. (Bug#9324)
7693
0c95fcf7
EZ
76942011-08-25 Eli Zaretskii <eliz@gnu.org>
7695
7696 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7697 the display spec is of the form `(space ...)'.
7698 (handle_display_spec): Return the value returned by
7699 handle_single_display_spec, not just 1 or zero.
7700 (handle_single_display_spec): If the display spec is of the form
7701 `(space ...)', and specifies display in the text area, return 2
7702 rather than 1.
fee65a97 7703 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7704 accurately, and prefer exact match for point under bidi.
7705 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7706
7707 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7708 into disp_prop; all users changed.
7709
7710 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7711 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7712 for the text covered by the display property.
7713
e4ed06f1
CY
77142011-08-25 Chong Yidong <cyd@stupidchicken.com>
7715
7716 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7717 Change return value to nil.
7718 (Frecord_buffer): Delete unused function.
7719
f67cdd7f
EZ
77202011-08-24 Eli Zaretskii <eliz@gnu.org>
7721
5980d4c6
EZ
7722 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7723 buffers, return left-to-right.
8610fe8b
EZ
7724 (set_cursor_from_row): Consider candidate row a win if its glyph
7725 represents a newline and point is on that newline. Fixes cursor
7726 positioning on the newline at EOL of R2L text within L2R
7727 paragraph, and vice versa.
7728 (try_cursor_movement): Check continued rows, in addition to
7729 continuation rows. Fixes unwarranted scroll when point enters a
7730 continued line of R2L text within an L2R paragraph, or vice versa.
7731 (cursor_row_p): Consider the case of point being equal to
7732 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7733 from the end of a short line to the beginning of a continued line
7734 of R2L text within L2R paragraph.
7735 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7736 composed characters.
5980d4c6 7737
f67cdd7f
EZ
7738 * bidi.c (bidi_check_type): Use xassert.
7739 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7740 members.
7741
bca633fb
EZ
77422011-08-23 Eli Zaretskii <eliz@gnu.org>
7743
7744 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7745 a character.
7746
4a5885a7
CY
77472011-08-23 Chong Yidong <cyd@stupidchicken.com>
7748
7749 * nsfont.m (ns_otf_to_script): Fix typo.
7750
0902a04e
KH
77512011-08-22 Kenichi Handa <handa@m17n.org>
7752
7753 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7754 extra slot even if the purpose is char-code-property-table.
7755
1a2e6670
EZ
77562011-08-23 Eli Zaretskii <eliz@gnu.org>
7757
8ddde651
EZ
7758 * xdisp.c (redisplay_window): When computing centering_position,
7759 account for the height of the header line. (Bug#8874)
7760
425cc014
EZ
7761 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7762 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7763 candidate is selected by the mouse, and that candidate has a
7764 composed character under the mouse.
7765
1a2e6670
EZ
7766 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7767 coordinates reported by pos-visible-in-window-p for a composed
7768 character in column zero.
7769
8b76d6f8
SM
77702011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7771
7772 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7773
dac347dd
EZ
77742011-08-22 Eli Zaretskii <eliz@gnu.org>
7775
7776 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7777 consider it a hit if to_charpos is anywhere in the range of the
7778 composed buffer positions.
7779
e013fb34
CY
77802011-08-22 Chong Yidong <cyd@stupidchicken.com>
7781
7782 * image.c (gif_load): Don't assume that each subimage has the same
7783 dimensions as the base image. Handle disposal method that is
7784 "undefined" by the gif spec (Bug#9335).
7785
bd1ba3e8
CY
77862011-08-20 Chong Yidong <cyd@stupidchicken.com>
7787
7788 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7789 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7790
54a1215b
EZ
77912011-08-19 Eli Zaretskii <eliz@gnu.org>
7792
823564e5
EZ
7793 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7794 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7795 from an Org mode buffer to a Speedbar frame.
7796
54a1215b
EZ
7797 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7798 a composition, take its buffer position from IT->cmp_it.charpos.
7799 Fixes cursor positioning at the beginning of a line that begins
7800 with a composed character.
7801
9778ebcc
EZ
78022011-08-18 Eli Zaretskii <eliz@gnu.org>
7803
0be6ee06
EZ
7804 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7805 character bidirectional type, use STRONG_L instead. Fixes crashes
7806 in a buffer produced by `describe-categories'.
7807
9778ebcc
EZ
7808 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7809 members before the level stack, so they would be saved and
7810 restored when copying iterator state. Fixes incorrect reordering
7811 around TABs covered by display properties.
7812
156bffbe
AS
78132011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7814
6b02f655 7815 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7816
72ad093b
CY
78172011-08-17 Chong Yidong <cyd@stupidchicken.com>
7818
7819 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7820 (internal_condition_case_2, internal_condition_case_n):
7821 Remove unnecessary aborts (Bug#9081).
72ad093b 7822
35774242
EZ
78232011-08-17 Eli Zaretskii <eliz@gnu.org>
7824
7825 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7826 has no `load' handler, try opening the file locally. (Bug#9311)
7827
db76dd85
KB
78282011-08-16 Ken Brown <kbrown@cornell.edu>
7829
7830 * gmalloc.c: Expand comment.
7831
b215eee5
EZ
78322011-08-16 Eli Zaretskii <eliz@gnu.org>
7833
7834 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7835 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7836
a4579d33
KB
78372011-08-16 Ken Brown <kbrown@cornell.edu>
7838
7839 Fix memory allocation problems in Cygwin build (Bug#9273).
7840
7841 * unexcw.c ( __malloc_initialized): Declare external variable.
7842 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7843
8b76d6f8
SM
7844 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7845 New variables.
a4579d33
KB
7846 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7847 dumped emacs.
7848 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7849 in the static heap.
7850 [CYGWIN] (special_realloc): New function.
7851 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7852 requests to realloc storage in the static heap.
7853
3ebec551
PE
78542011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7855
7856 * bidi.c (bidi_initialize): Remove unused local.
7857
9fd8be00
EZ
78582011-08-15 Eli Zaretskii <eliz@gnu.org>
7859
6b02f655
SM
7860 * bidimirror.h:
7861 * biditype.h: Remove file.
7862 * makefile.w32-in ($(BLD)/bidi.$(O)):
7863 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7864
7865 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7866
7867 * chartab.c: Improve commentary for the uniprop_table API.
7868
32413314
EZ
7869 * bidi.c (bidi_paragraph_init): Support zero value of
7870 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7871 (bidi_initialize): Use uniprop_table instead of including
7872 biditype.h and bidimirror.h.
32413314 7873
9fd8be00
EZ
7874 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7875 coordinates of the iterator when restoring from ppos_it.
7876 (Bug#9296)
7877
5cf2b69b
KH
78782011-08-14 Kenichi Handa <handa@m17n.org>
7879
7880 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7881 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7882
daf17d00
EZ
78832011-08-14 Eli Zaretskii <eliz@gnu.org>
7884
7885 * xdisp.c (move_it_in_display_line_to): Don't invoke
7886 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7887 ppos_it. Fixes vertical cursor motion when line beginning is
7888 covered by an image. (Bug#9296)
7889
08e3161a
JD
78902011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7891
7892 * nsterm.h (ns_run_ascript): Declare.
7893 (NSAPP_DATA2_RUNASSCRIPT): Define.
7894
7895 * nsfns.m (as_script, as_result, as_status): New static variables.
7896 (ns_run_ascript): New function.
5e617bc2 7897 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7898 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7899 the event loop. Get status from as_status (Bug#7276).
7900
7901 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7902 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7903 the event loop (Bug#7276).
7904
a3720aa2
AS
79052011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7906
7907 * gnutls.c (QCgnutls_bootprop_priority)
7908 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7909 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7910 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7911 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7912 (QCgnutls_bootprop_verify_hostname_error)
7913 (QCgnutls_bootprop_callbacks_verify): Rename from
7914 Qgnutls_bootprop_..., all uses changed.
7915
7916 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7917 uses changed.
7918
0a0d27fb
PE
79192011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7920
19d5c50c
PE
7921 * xfaces.c (Qframe_set_background_mode): Now static.
7922 * dispextern.h (Qframe_set_background_mode): Remove decl.
7923
0a0d27fb
PE
7924 * process.c (Fnetwork_interface_info): Declare local only if needed.
7925
377538cb
JD
79262011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7927
7928 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7929 (Fnetwork_interface_list): Allocate in increments of bytes instead
7930 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7931 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7932 sockaddr.
7933 (struct ifflag_def): notrailers is smart on OSX.
7934 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7935 Get hardware address with getifaddrs if available.
7936
08fff70c
EZ
79372011-08-12 Eli Zaretskii <eliz@gnu.org>
7938
7939 * xdisp.c (iterate_out_of_display_property): xassert that
7940 IT->position is set to within IT->object's boundaries. Break from
7941 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7942 when IT->position is set up wrongly due to some bug.
7943 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7944 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7945 entry. Force push_it to save on the stack the current
7946 buffer/string position, to be restored by pop_it. Fix flags in
7947 the iterator structure wrt the object coming from a display
7948 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7949 properties. (Bug#9284)
7950
7be1c708 79512011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7952
7be1c708
CY
7953 * fontset.c (fontset_get_font_group): Add proper type checks.
7954 (Bug#9172)
aac0c6e3 7955
7be1c708 79562011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7957
7be1c708
CY
7958 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7959 and LC_VERSION_MIN_MACOSX.
7960 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7961 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7962
97bb72a6
EZ
79632011-08-08 Eli Zaretskii <eliz@gnu.org>
7964
7965 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7966 no-display-properties-and-no-overlays under bidi display.
7967 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7968 properties and overlays.
97bb72a6 7969
d5617611
CY
79702011-08-08 Chong Yidong <cyd@stupidchicken.com>
7971
37e11a63
CY
7972 * editfns.c (Fset_time_zone_rule): Document relationship with the
7973 setenv function.
7974
d5617611
CY
7975 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7976 the font entity extracted from the cache (Bug#8109).
7977
58872834
CY
79782011-08-07 Chong Yidong <cyd@stupidchicken.com>
7979
7980 * composite.c (autocmp_chars): Don't reset point. That is done by
7981 restore_point_unwind (Bug#5984).
7982
75bfc667
JL
79832011-08-07 Juri Linkov <juri@jurta.org>
7984
7985 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7986 to show the arg `TIME' instead of `TIMEVAL'.
7987
d1410150
EZ
79882011-08-06 Eli Zaretskii <eliz@gnu.org>
7989
7990 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7991 display property strides EOL and includes a newline, as in
7992 longlines-mode. (Bug#9254)
75b771e4
EZ
7993 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7994 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7995
7996 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7997 is non-zero, even if the data buffer is NULL. Fixes a crash in
7998 vertical-motion with longlines-mode. (Bug#9254)
7999
35928349
EZ
80002011-08-05 Eli Zaretskii <eliz@gnu.org>
8001
ec7cc85b
EZ
8002 * bidi.c <bidi_cache_total_alloc>: Now static.
8003 (bidi_initialize): Initialize bidi_cache_total_alloc.
8004
8b76d6f8 8005 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8006 cache. (Bug#9221)
8007
8008 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8009 amount allocated this far in `bidi_cache_total_alloc'.
8010 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8011 non-zero, only free the data buffer without restoring the cache
8012 contents. All callers changed.
8013
8014 * dispextern.h (bidi_unshelve_cache): Update prototype.
8015
8016 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8017 (move_it_in_display_line, move_it_to)
8018 (move_it_vertically_backward, move_it_by_lines): Replace the call
8019 to xfree to an equivalent call to bidi_unshelve_cache.
8020 (move_it_in_display_line_to): Fix logic of returning
412b6358 8021 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8022
e2e2423b
EZ
80232011-08-05 Eli Zaretskii <eliz@gnu.org>
8024
8025 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8026 came from a string character with a `cursor' property. (Bug#9229)
8027
ae9e757a
JD
80282011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8029
8030 * Makefile.in (LIB_PTHREAD): New variable.
8031 (LIBES): Add LIB_PTHREAD (Bug#9216).
8032
8033 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8034 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8035
213bd7f2
AS
80362011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8037
6b02f655 8038 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8039
99aaf75f
JD
80402011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8041
8042 * xterm.c (x_find_topmost_parent): New function.
8043 (x_set_frame_alpha): Find topmost parent window with
8044 x_find_topmost_parent and set the property there also (bug#9181).
8045 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8046
c74e9d86
PE
80472011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8048
8049 * callproc.c (Fcall_process): Avoid vfork clobbering
8050 the local vars buffer, coding_systems, current_dir.
8051
640c8776
SM
80522011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8053
8054 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8055
f26d0e4c
PE
80562011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8057
8a10d76c
PE
8058 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8059 so that it is not optimized away.
8060
f26d0e4c
PE
8061 * xdisp.c (compute_display_string_pos): Remove unused local.
8062
55439c61
EZ
80632011-08-02 Eli Zaretskii <eliz@gnu.org>
8064
8065 Fix slow cursor motion and scrolling in large buffers with
8066 selective display, like Org Mode buffers. (Bug#9218)
8067
8068 * dispextern.h (struct bidi_it): New member disp_prop_p.
8069
8070 * xdisp.c: Remove one-slot cache of display string positions.
8071 (compute_display_string_pos): Accept an additional argument
5e617bc2 8072 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8073 for a display string or property. If found, set DISP_PROP_P
8074 non-zero.
8075
8076 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8077 DISP_PROP_P, and pass it to compute_display_string_pos.
8078 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8079 non-zero. All callers of bidi_fetch_char changed.
8080
fb33fa43
SM
80812011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8082
8083 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8084
b099e063
DM
80852010-12-03 Don March <don@ohspite.net>
8086
8087 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8088 last character M-[char] is translated to ESC [char] (bug#7541).
8089
5cc7f7af
KH
80902011-08-02 Kenichi Handa <handa@m17n.org>
8091
d0fffa3f 8092 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8093
8094 * chartab.c (uniprop_table): Make it non-static.
8095
525d5e6e
EZ
80962011-08-01 Eli Zaretskii <eliz@gnu.org>
8097
8098 * xdisp.c (forward_to_next_line_start): Accept additional argument
8099 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8100 on the newline.
8101 (reseat_at_next_visible_line_start): Use the bidi iterator state
8102 returned by forward_to_next_line_start to restore the state of
8103 it->bidi_it after backing up to previous newline. (Bug#9212)
8104
31011111
AS
81052011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8106
8107 * regex.c (re_comp): Protoize.
8108 (re_exec): Fix return type.
8109 (regexec): Fix type of `ret'. (Bug#9203)
8110
476371c4
PE
81112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8112
e5d76069
PE
8113 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8114 This is needed if max-image-size is a floating-point number.
8115
9a79b20c
AS
81162011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8117
8118 * print.c (print_object): Print empty symbol as ##.
8119
8120 * lread.c (read1): Read ## as empty symbol.
8121
d8c2fa78
AA
81222011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8123
8124 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8125 setting frame foreground color (Bug#9175).
8126 (x_set_background_color): Likewise.
8127
ffe57a7a
AA
8128 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8129 contents (Bug#9176).
8130 (EmacsTooltip -init): Remove bezels and add shadows to
8131 tooltip windows.
8132
bf3492a5
AA
8133 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8134 or scroll bar (Bug#8470).
8135
d55e9c53
AA
8136 * nsfont.m (nsfont_open): Remove assignment to voffset and
8137 unnecessary vars hshink, expand, hd, full_height, min_height.
8138 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8139
8140 * nsterm.h (nsfont_info): Remove voffset field.
8141
d8c2fa78 81422011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8143
8144 Implement strike-through and overline on NextStep (Bug#8863).
8145
8146 * nsfont.m (nsfont_open): Use underline position provided by font,
8147 instead of hard-coded value of 2.
8148 (nsfont_draw): Call ns_draw_text_decoration instead.
8149
8150 * nsterm.h: Add declaration for ns_draw_text_decoration.
8151
8152 * nsterm.m (ns_draw_text_decoration): New function for drawing
8153 underline, overline, and strike-through.
8154 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8155 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8156 accommodate underlining, etc.
4843aac3 8157
4cc60b9b
EZ
81582011-07-28 Eli Zaretskii <eliz@gnu.org>
8159
bc7ece87
EZ
8160 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8161 default.
4cc60b9b 8162
476371c4
PE
81632011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8164
66606eea
PE
8165 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8166 Without this fix, if a signal arrives just after memory fills up,
8167 'malloc' might be invoked reentrantly.
8168
476371c4
PE
8169 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8170 In other words, assume that every image size is allowed, on non-X
8171 hosts. This assumption is probably wrong, but it lets Emacs compile.
8172
f3fcc40d
AS
81732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8174
8175 * regex.c (re_iswctype): Convert return values to boolean.
8176
350c992f
EZ
81772011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8178
8179 * xdisp.c (compute_display_string_pos): Don't use cached display
8180 string position if the buffer had its restriction changed.
8181 (Bug#9184)
8182
5266b4bb
PE
81832011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8184
8185 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8186
2573a837 81872011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8188
41f55ccd 8189 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8190
39e378da
PE
8191 * bidi.c: Integer size and overflow fixes.
8192 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8193 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8194 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8195 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8196 (bidi_find_other_level_edge):
8197 Use ptrdiff_t instead of EMACS_INT where either will do.
8198 This works better on 32-bit hosts configured --with-wide-int.
8199 (bidi_cache_ensure_space): Check for size-calculation overflow.
8200 Use % rather than repeated addition, for better worst-case speed.
8201 Don't set bidi_cache_size until after xrealloc returns, because it
8202 might not return.
8203 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8204 (bidi_cache_ensure_space): Also check that the bidi cache size
8205 does not exceed that of the largest Lisp string or buffer. See Eli
8206 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8207
5e927815
PE
8208 * alloc.c (__malloc_size_t): Remove.
8209 All uses replaced by size_t. See Andreas Schwab's note
8210 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8211
ca4aa935
PE
8212 * image.c: Improve checking for integer overflow.
8213 (check_image_size): Assume that f is nonnull, since
8214 it is always nonnull in practice. This is one less thing to
8215 worry about when checking for integer overflow later.
8216 (x_check_image_size): New function, which checks for integer
8217 overflow issues inside X.
8218 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8219 This removes the need for a memory_full check.
8220 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8221 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8222 (xbm_read_bitmap_data): Change locals back to 'int', since
8223 their values must fit in 'int'.
8224 (xpm_load_image, png_load, tiff_load):
8225 Invoke x_create_x_image_and_pixmap earlier,
8226 to avoid much needless work if the image is too large.
8227 (tiff_load): Treat overly large images as if
8228 x_create_x_image_and_pixmap failed, not as malloc failures.
8229 (gs_load): Use x_check_image_size.
8230
5f8f9cc2
PE
8231 * gtkutil.c: Omit integer casts.
8232 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8233 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8234
5adf60bc
PE
8235 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8236
c8907a93
PE
8237 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8238 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8239 would wrongly return t on a 64-bit host.
8240
e3c25c68
PE
8241 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8242 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8243 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8244 and therefore cause GCC to emit a bogus diagnostic in some cases.
8245
3f791afe
PE
8246 * image.c: Integer signedness and overflow and related fixes.
8247 This is not an exhaustive set of fixes, but it's time to
8248 record what I've got.
8249 (lookup_pixel_color, check_image_size): Remove redundant decls.
8250 (check_image_size): Don't assume that arbitrary EMACS_INT values
8251 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8252 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8253 (tiff_load, imagemagick_load_image):
8254 Check for overflow in size calculations.
8255 (x_create_x_image_and_pixmap): Remove unnecessary test for
8256 xmalloc returning NULL; that can't happen.
8257 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8258 (xpm_color_bucket): Use better integer hashing function.
8259 (xpm_cache_color): Don't possibly over-allocate memory.
8260 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8261 (gif_memory_source):
8262 Use ptrdiff_t, not int or size_t, to record sizes.
8263 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8264 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8265 either works, as we prefer signed integers.
8266 (tiff_read_from_memory, tiff_write_from_memory):
8267 Return tsize_t, not size_t, since that's what the TIFF API wants.
8268 (tiff_read_from_memory): Don't fail simply because the read would
8269 go past EOF; instead, return a short read.
8270 (tiff_load): Omit no-longer-needed casts.
8271 (Fimagemagick_types): Don't assume size fits into 'int'.
8272
3cc5a532
PE
8273 Improve hashing quality when configured --with-wide-int.
8274 * fns.c (hash_string): New function, taken from sxhash_string.
8275 Do not discard information about ASCII character case; this
8276 discarding is no longer needed.
8277 (sxhash-string): Use it. Change sig to match it. Caller changed.
8278 * lisp.h: Declare it.
8279 * lread.c (hash_string): Remove, since we now use fns.c's version.
8280 The fns.c version returns a wider integer if --with-wide-int is
8281 specified, so this should help the quality of the hashing a bit.
8282
b312a492
PE
8283 * emacs.c: Integer overflow minor fix.
8284 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8285 Define only if GNU_LINUX.
8286 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8287
dfd153ae
PE
8288 * dispnew.c: Integer signedness and overflow fixes.
8289 Remove unnecessary forward decls, that were a maintenance hassle.
8290 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8291 All uses changed.
8292 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8293 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8294 (prepare_desired_row, line_draw_cost):
8295 Use int, not unsigned, where either works.
8296 (save_current_matrix, restore_current_matrix):
8297 Use ptrdiff_t, not size_t, where either works.
8298 (init_display): Check for overflow more accurately, and without
8299 relying on undefined behavior.
8300
a81d11a3
PE
8301 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8302 Remove, replacing with the new symbols in lisp.h. All uses changed.
8303 * fileio.c (make_temp_name):
8304 * filelock.c (lock_file_1, lock_file):
8305 * xdisp.c (message_dolog):
8306 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8307 Use pMd etc. instead.
8308 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8309 replacing the pWIDE etc. symbols removed from editfns.c.
8310
3300e6fd
PE
8311 * keyboard.h (num_input_events): Now uintmax_t.
8312 This is (very slightly) less likely to mess up due to wraparound.
8313 All uses changed.
8314
fd05c7e9
PE
8315 * buffer.c: Integer signedness fixes.
8316 (alloc_buffer_text, enlarge_buffer_text):
8317 Use ptrdiff_t rather than size_t when either will do, as we prefer
8318 signed integers.
8319
903fe15d
PE
8320 * alloc.c: Integer signedness and overflow fixes.
8321 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8322 (__malloc_size_t): Default to size_t, not to int.
8323 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8324 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8325 Prefer ptrdiff_t to size_t when either would do, as we prefer
8326 signed integers.
8327 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8328 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8329 Now const. Initialize with values that are in range even if char
8330 is signed.
8331 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8332 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8333 These functions do the right thing with sizes > 2**32.
8334 (check_depth): Now ptrdiff_t, not int.
8335 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8336 Adjust to new way of storing sizes. Check for size overflow bugs
8337 in rest of code.
8338 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8339 slightly wrong anyway, as it missed one instance of
8340 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8341 (refill_memory_reserve): Omit needless cast to size_t.
8342 (mark_object_loop_halt): Mark as externally visible.
8343
ac82cc6a
PE
8344 * xselect.c: Integer signedness and overflow fixes.
8345 (Fx_register_dnd_atom, x_handle_dnd_message):
8346 Use ptrdiff_t, not size_t, since we prefer signed.
8347 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8348 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8349 x_dnd_atoms_size and x_dnd_atoms_length.
8350
c2d1e36d
PE
8351 * doprnt.c: Prefer signed to unsigned when either works.
8352 * eval.c (verror):
8353 * doprnt.c (doprnt):
8354 * lisp.h (doprnt):
8355 * xdisp.c (vmessage):
8356 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8357 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8358 prefer signed arithmetic to avoid comparison confusion.
8359 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8360 but is a bit tricky.
8361
0e926e56
PE
8362 Assume freestanding C89 headers, string.h, stdlib.h.
8363 * data.c, doprnt.c, floatfns.c, print.c:
8364 Include float.h unconditionally.
8365 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8366 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8367 * regex.c: Likewise for stddef.h, string.h.
8368 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8369 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8370 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8371 (STDC_HEADERS): Remove obsolete defines.
8372 * sysdep.c: Include limits.h unconditionally.
8373
9cfdb3ec
PE
8374 Assume support for memcmp, memcpy, memmove, memset.
8375 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8376 * regex.c (memcmp, memcpy):
8377 Remove; we assume C89 now.
8378
8379 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8380 (__malloc_safe_bcopy): Remove; no longer needed.
8381
cf950e6b 8382 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8383 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8384 well either way, and we prefer signed to unsigned.
8385
dbf38e02
LMI
83862011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8387
8388 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8389 closes the connection while we're reading (bug#9182).
8390
d6f0886c 83912011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8392
d6f0886c
JD
8393 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8394 are specified (Bug#9168).
24e0f6b1 8395
2eb1f9e6
PE
83962011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8397
8398 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8399 Found by GCC static checking and --with-wide-int on a 32-bit host.
8400
22381272 84012011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8402
8403 * xdisp.c (compute_display_string_pos): Fix logic of caching
8404 previous display string position. Initialize cached_prev_pos to
8405 -1. Fixes slow-down at the beginning of a buffer.
8406
f25e39b4
EZ
84072011-07-24 Eli Zaretskii <eliz@gnu.org>
8408
8409 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8410 for attrs[LFACE_FONTSET_INDEX].
8411
04c4b52e
PE
84122011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8413
8414 * xml.c (parse_region): Remove unused local
8415 that was recently introduced.
8416
c1734fbd
EZ
84172011-07-23 Eli Zaretskii <eliz@gnu.org>
8418
be18c5a5
EZ
8419 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8420 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8421
c1734fbd
EZ
8422 * xdisp.c (move_it_in_display_line_to): Record the best matching
8423 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8424 exit if none of the characters scanned was an exact match.
8425 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8426 when exact match is impossible due to invisible text, and the
8427 lines are truncated.
8428
a258d627
JD
84292011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8430
8431 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8432 for OSX >= 10.7.
8433
b6d5a689
EZ
84342011-07-22 Eli Zaretskii <eliz@gnu.org>
8435
0f74f785
EZ
8436 Fix a significant slow-down of cursor motion with C-n, C-p,
8437 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8438 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8439 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8440 (next_element_from_buffer): Call compute_stop_pos_backwards to
8441 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8442 base_level_stop.
8443 (reseat): Don't look for prev_stop, as that could mean a very long
8444 run.
8445 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8446 <cached_disp_overlay_modiff>: Cache for last found display string
8447 position.
551918c1 8448 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8449 about the same buffer in the same area of character positions, and
8450 the buffer wasn't changed since the time the display string
8451 position was cached.
551918c1 8452
b2d0c91a
EZ
84532011-07-22 Eli Zaretskii <eliz@gnu.org>
8454
8455 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8456 is an integer, which is important for empty lines. (Bug#9149)
8457
043604ee
CY
84582011-07-22 Chong Yidong <cyd@stupidchicken.com>
8459
8460 * frame.c (Fmodify_frame_parameters): In tty case, update the
8461 default face if necessary (Bug#4238).
8462
da4adb04
CY
84632011-07-21 Chong Yidong <cyd@stupidchicken.com>
8464
8465 * editfns.c (Fstring_to_char): No need to explain what a character
8466 is in the docstring (Bug#6576).
8467
9abd0532
LMI
84682011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8469
8470 * xml.c (parse_region): Make sure we always return a tree.
8471
36881d16
HK
84722011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8473
8474 * xml.c (parse_region): If a document contains only comments,
8475 return that, too.
8476
1e98674d
LMI
84772011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8478
8479 * xml.c (make_dom): Return comments, too.
8480
590bd467
PE
84812011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8482
8483 Port to OpenBSD.
8484 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8485 and the surrounding thread.
8486 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8487 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8488 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8489 timer goes off.
8490 * s/openbsd.h (BROKEN_SIGIO): Define.
8491 * unexelf.c (unexec) [__OpenBSD__]:
8492 Don't update the .mdebug section of the Alpha COFF symbol table.
8493
f41628b2
LMI
84942011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8495
8496 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8497 (bug#8460).
8498
b59b67c5
PE
84992011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8500
15e3a074
PE
8501 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8502 This fixes some race conditions on the permissions of any newly
8503 created file.
8504
41bed37d
PE
8505 * alloc.c (valid_pointer_p): Use pipe, not open.
8506 This fixes some permissions issues when debugging.
8507
b59b67c5
PE
8508 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8509 If fchown fails to set both uid and gid, try to set just gid,
8510 as that is sometimes allowed. Adjust the file's mode to eliminate
8511 setuid or setgid bits that are inappropriate if fchown fails.
8512
925a6be7
SM
85132011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8514
8515 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8516 to compare Lisp_Objects.
8517 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8518 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8519 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8520
52968808
AS
85212011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8522
0a6a104b
AS
8523 * lread.c (read_integer): Unread even EOF character.
8524 (read1): Likewise. Properly record start position of symbol.
8525
52968808
AS
8526 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8527 symbol character follows.
8528
9e381cdd
PE
85292011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8530
8531 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8532 This works around a problem with the previous change to Fcopy_file.
8533 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8534 and without this change, GCC might complain about discarding
8535 fchown's return value.
8536
b5641435
JB
85372011-07-16 Juanma Barranquero <lekktu@gmail.com>
8538
8539 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8540
a8031457
PE
85412011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8542
8543 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8544
dd889327
LMI
85452011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8546
750c33f7
LMI
8547 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8548 it's used from the C level.
8549
dd889327
LMI
8550 * process.c: Use the same condition for POLL_FOR_INPUT in both
8551 keyboard.c and process.c (bug#1858).
8552
87e86684
LM
85532011-07-09 Lawrence Mitchell <wence@gmx.li>
8554
8555 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8556 (Fgnutls_boot): Use it.
8557
64348f40
AS
85582011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8559
8560 * doc.c (Fsubstitute_command_keys): Revert last change.
8561
1d698799
LMI
85622011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8563
f863868c
LMI
8564 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8565 quotes the next character, and doesn't affect other longer
8566 sequences (bug#8935).
8567
1d698799
LMI
8568 * lread.c (syms_of_lread): Clarify that is isn't only
8569 `eval-buffer' and `eval-defun' that's affected by
8570 `lexical-binding' (bug#8460).
8571
aa4b6df6
EZ
85722011-07-15 Eli Zaretskii <eliz@gnu.org>
8573
8574 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8575 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8576
5d856da6
PE
85772011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8578
ad6042bb
PE
8579 Fix minor problems found by static checking.
8580 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8581 (elsz): Now a signed constant, not a size_t var. We prefer signed
8582 types to unsigned, to avoid integer comparison confusion. Without
8583 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8584 "cannot optimize loop, the loop counter may overflow", a symptom
8585 of the confusion.
f00bbb22 8586 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8587 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8588
6468f31c
LMI
85892011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8590
49080b10
LMI
8591 * search.c (Fre_search_backward): Mention `case-fold-search' in
8592 all the re_search_* functions (bug#8138).
8593
6468f31c
LMI
8594 * keyboard.c (Fopen_dribble_file): Document when the file is
8595 closed (bug#8056).
8596
c965adc5
EZ
85972011-07-14 Eli Zaretskii <eliz@gnu.org>
8598
df9733bf
EZ
8599 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8600 bidi_cache_idx.
8601
0bb23927
EZ
8602 Support bidi reordering of display and overlay strings.
8603 * xdisp.c (compute_display_string_pos)
8604 (compute_display_string_end): Accept additional argument STRING.
8605 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8606 (reseat_to_string): Initialize bidi_it->string.s and
8607 bidi_it->string.schars.
8608 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8609 NULL (avoids a crash in bidi_paragraph_init).
8610 Initialize itb.string.lstring.
0bb23927
EZ
8611 (init_iterator): Call bidi_init_it only of a valid
8612 buffer position was specified. Initialize paragraph_embedding to
8613 L2R.
8614 (reseat_to_string): Initialize the bidi iterator.
8615 (display_string): If we need to ignore text properties of
8616 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8617 original value of -1 will not work with bidi.)
8618 (compute_display_string_pos): First arg is now struct
8619 `text_pos *'; all callers changed. Support display properties on
8620 Lisp strings.
8621 (compute_display_string_end): Support display properties on Lisp
8622 strings.
8623 (init_iterator, reseat_1, reseat_to_string): Initialize the
8624 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8625 when iterating on a string not from display properties).
640c8776
SM
8626 (compute_display_string_pos, compute_display_string_end):
8627 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8628 arrow keys.
8629 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8630 base_level_stop; instead, set base_level_stop to BEGV.
8631 Fixes crashes in vertical-motion.
0bb23927
EZ
8632 (next_element_from_buffer): Improve commentary for when
8633 the iterator is before prev_stop.
8634 (init_iterator): Initialize bidi_p from the default value of
8635 bidi-display-reordering, not from buffer-local value. Use the
8636 buffer-local value only if initializing for buffer iteration.
8637 (handle_invisible_prop): Support invisible properties on strings
8638 that are being bidi-reordered.
8639 (set_iterator_to_next): Support bidi reordering of C strings and
8640 Lisp strings.
8641 (next_element_from_string): Support bidi reordering of Lisp
8642 strings.
8643 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8644 (display_string): Support display of R2L glyph rows.
8645 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8646 (init_iterator): Don't initialize it->bidi_p for strings
8647 here.
8648 (reseat_to_string): Initialize it->bidi_p for strings here.
8649 (next_element_from_string, next_element_from_c_string)
8650 (next_element_from_buffer): Add xassert's for correspondence
8651 between IT's object being iterated and it->bidi_it.string
8652 structure.
8653 (face_before_or_after_it_pos): Support bidi iteration.
8654 (next_element_from_c_string): Handle the case of the first string
8655 character that is not the first one in the visual order.
8656 (get_visually_first_element): New function, refactored from common
8657 parts of next_element_from_buffer, next_element_from_string, and
8658 next_element_from_c_string.
8659 (tool_bar_lines_needed, redisplay_tool_bar)
8660 (display_menu_bar): Force left-to-right direction. Add a FIXME
8661 comment for making that be controlled by a user option.
8662 (push_it, pop_it): Save and restore the state of the
8663 bidi iterator. Save and restore the bidi_p flag.
8664 (pop_it): Iterate out of display property for string iteration as
8665 well.
8666 (iterate_out_of_display_property): Support iteration over strings.
8667 (handle_single_display_spec): Set up it->bidi_it for iteration
8668 over a display string, and call bidi_init_it.
8669 (handle_single_display_spec, next_overlay_string)
8670 (get_overlay_strings_1, push_display_prop): Set up the bidi
8671 iterator for displaying display or overlay strings.
8672 (forward_to_next_line_start): Don't use the shortcut if
8673 bidi-iterating.
8674 (back_to_previous_visible_line_start): If handle_display_prop
8675 pushed the iterator stack, restore the internal state of the bidi
8676 iterator by calling bidi_pop_it same number of times.
8677 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8678 and we are bidi-iterating, don't decrement the iterator position;
8679 instead, set the first_elt flag in the bidi iterator, to produce
8680 the same effect.
8681 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8682 (push_display_prop): xassert that we are iterating a buffer.
8683 (push_it, pop_it): Save and restore paragraph_embedding member.
8684 (handle_single_display_spec, next_overlay_string)
8685 (get_overlay_strings_1, reseat_1, reseat_to_string)
8686 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8687 correctly. Don't assume unibyte strings are not bidi-reordered.
8688 (compute_display_string_pos)
8689 (compute_display_string_end): Fix handling the case of C string.
8690 (push_it, pop_it): Save and restore from_disp_prop_p.
8691 (handle_single_display_spec, push_display_prop): Set the
8692 from_disp_prop_p flag.
8693 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8694 (pop_it): Call iterate_out_of_display_property only if we are
8695 popping after iteration over a string that came from a display
8696 property. Fix a typo in popping stretch info. Add an assertion
8697 for verifying that the iterator position is in sync with the bidi
8698 iterator.
8699 (handle_single_display_spec, get_overlay_strings_1)
8700 (push_display_prop): Fix initialization of paragraph direction for
8701 string when that of the parent object is not yet determined.
8702 (reseat_1): Call bidi_init_it to resync the bidi
8703 iterator with IT's position. (Bug#7616)
8704 (find_row_edges): If ROW->start.pos gives position
8705 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8706 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8707 Reset the from_disp_prop_p flag.
8708 (SAVE_IT, RESTORE_IT): New macros.
8709 (pos_visible_p, face_before_or_after_it_pos)
8710 (back_to_previous_visible_line_start)
8711 (move_it_in_display_line_to, move_it_in_display_line)
8712 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8713 (try_scrolling, redisplay_window, display_line): Use them when
8714 saving a temporary copy of the iterator and restoring it back.
8715 (back_to_previous_visible_line_start, reseat_1)
8716 (init_iterator): Empty the bidi cache "stack".
8717 (move_it_in_display_line_to): If iterator ended up at
8718 EOL, but we never saw any buffer positions smaller than
8719 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8720 motion in bidi-reordered lines.
8721 (move_it_in_display_line_to): Record prev_method and prev_pos
8722 immediately before the call to set_iterator_to_next. Fixes cursor
8723 motion in bidi-reordered lines with stretch glyphs and strings
8724 displayed in margins. (Bug#8133) (Bug#8867)
8725 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8726 TO_CHARPOS.
640c8776
SM
8727 (pos_visible_p): Support positions in bidi-reordered lines.
8728 Save and restore bidi cache.
0bb23927
EZ
8729
8730 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8731 (bidi_paragraph_info): Delete unused struct.
8732 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8733 (bidi_cache_start): New variable.
8734 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8735 to zero.
8736 (bidi_cache_fetch_state, bidi_cache_search)
8737 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8738 (bidi_cache_find, bidi_peek_at_next_level)
8739 (bidi_level_of_next_char, bidi_find_other_level_edge)
8740 (bidi_move_to_visually_next): Compare cache index with
8741 bidi_cache_start rather than with zero.
8742 (bidi_fetch_char): Accept new argument STRING; all callers
8743 changed. Support iteration over a string. Support strings with
8744 display properties. Support unibyte strings. Fix the type of
8745 `len' according to what STRING_CHAR_AND_LENGTH expects.
8746 (bidi_paragraph_init, bidi_resolve_explicit_1)
8747 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8748 (bidi_level_of_next_char, bidi_move_to_visually_next):
8749 Support iteration over a string.
0bb23927
EZ
8750 (bidi_set_sor_type, bidi_resolve_explicit_1)
8751 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8752 can now be zero (for strings); special values 0 and -1 were
8753 changed to -1 and -2, respectively.
8754 (bidi_char_at_pos): New function.
8755 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8756 Call it instead of FETCH_MULTIBYTE_CHAR.
8757 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8758 initialized to valid values.
8759 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8760 values.
8761 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8762 the test for valid cached positions. Fix the logic for looking up
8763 the sentinel state in the cache. GCPRO the Lisp string we are
8764 iterating.
8765 (bidi_push_it, bidi_pop_it): New functions.
8766 (bidi_initialize): Initialize the bidi cache start stack pointer.
8767 (bidi_cache_ensure_space): New function, refactored from part of
8768 bidi_cache_iterator_state. Don't assume the required size is just
8769 one BIDI_CACHE_CHUNK away.
8770 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8771 (bidi_count_bytes, bidi_char_at_pos): New functions.
8772 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8773 always valid if bidi_cache_idx is valid.
8774 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8775 is valid if it's going to be used.
8776 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8777 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8778 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8779 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8780 (bidi_find_other_level_edge, bidi_cache_start_stack):
8781 All variables related to cache indices are now EMACS_INT.
c965adc5 8782
0bb23927
EZ
8783 * dispextern.h (struct bidi_string_data): New structure.
8784 (struct bidi_it): New member `string'. Make flag members be 1-bit
8785 fields, and put them last in the struct.
640c8776
SM
8786 (compute_display_string_pos, compute_display_string_end):
8787 Update prototypes.
0bb23927
EZ
8788 (bidi_push_it, bidi_pop_it): Add prototypes.
8789 (struct iterator_stack_entry): New members bidi_p,
8790 paragraph_embedding, and from_disp_prop_p.
8791 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8792 (bidi_shelve_cache, bidi_unshelve_cache):
8793 Declare prototypes.
0bb23927
EZ
8794
8795 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8796 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8797 and vector-like objects.
8798
8799 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8800 cache around display iteration.
8801
8802 * window.c (Fwindow_end, window_scroll_pixel_based)
8803 (displayed_window_lines, Frecenter): Save and restore the bidi
8804 cache around display iteration.
8805
3bbd2265
LMI
88062011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8807
8808 * editfns.c (Fdelete_region): Clarify the use of the named
8809 parameters (bug#6788).
8810
adc47434
MR
88112011-07-14 Martin Rudalics <rudalics@gmx.at>
8812
8813 * indent.c (Fvertical_motion): Set and restore w->pointm when
8814 saving and restoring the window's buffer (Bug#9006).
8815
837c31f8
LMI
88162011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8817
8818 * editfns.c (Fstring_to_char): Clarify just what is returned
8819 (bug#6576). Text by Eli Zaretskii.
8820
ac389d0c
JB
88212011-07-13 Juanma Barranquero <lekktu@gmail.com>
8822
8823 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8824
0be0ce47
EZ
88252011-07-13 Eli Zaretskii <eliz@gnu.org>
8826
8827 * buffer.c (mmap_find): Fix a typo.
8828
cd18e7e3
JB
88292011-07-13 Johan Bockgård <bojohan@gnu.org>
8830
8831 Fix execution of x selection hooks.
8832 * xselect.c (Qx_lost_selection_functions)
8833 (Qx_sent_selection_functions): New vars.
8834 (syms_of_xselect): DEFSYM them.
8835 (x_handle_selection_request): Pass Qx_sent_selection_functions
8836 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8837 (x_handle_selection_clear,x_clear_frame_selections):
8838 Pass Qx_lost_selection_functions rather than
8839 Vx_lost_selection_functions to Frun_hook_with_args.
8840
47ea7f44
PE
88412011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8842
ac389d0c 8843 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8844 The old code sometimes used this field without initializing it.
8845
47ea7f44
PE
8846 * alloc.c (gc_sweep): Don't read past end of array.
8847 In theory, the old code could also have corrupted Emacs internals,
8848 though it'd be very unlikely.
8849
bc985c87
AS
88502011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8851
8852 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8853 argument. (Bug#4026)
bc985c87 8854
0cf34688
LMI
88552011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8856
b3dadd76
LMI
8857 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8858 key" (bug#4257).
8859
0cf34688
LMI
8860 * window.c (Fset_window_start): Doc fix (bug#4199).
8861 (Fset_window_hscroll): Ditto.
8862
270768cd
PE
88632011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8864
077e3dda 8865 Fix minor new problems caught by GCC 4.6.1.
270768cd 8866 * term.c (init_tty): Remove unused local.
490011a6 8867 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8868 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8869 not used otherwise.
270768cd 8870
b1f58454
CY
88712011-07-12 Chong Yidong <cyd@stupidchicken.com>
8872
8873 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8874
22b9578d
LMI
88752011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8876
6e70ab07
LMI
8877 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8878 are the mini-buffer and the echo area (bug#3320).
8879
22b9578d
LMI
8880 * term.c (init_tty): Remove support for supdup, c10 and perq
8881 terminals, which are no longer supported (bug#1482).
8882
8974cc9f
JB
88832011-07-10 Johan Bockgård <bojohan@gnu.org>
8884
8885 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8886
a560d974
JD
88872011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8888
8889 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8890 for non-popups (Bug#3642).
8891
1dae0f0a
AS
88922011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8893
268c2c36 8894 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8895 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8896 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8897 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8898 * data.c (fmod): Likewise.
8899 * dispnew.c (swap_glyphs_in_rows): Likewise.
8900 * emacs.c (memory_warning_signal): Likewise.
8901 * floatfns.c (float_error): Likewise.
8902 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8903 (otf_open, font_otf_capability, generate_otf_features)
8904 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8905 Likewise.
8906 * image.c (pbm_read_file): Likewise.
8907 * indent.c (string_display_width): Likewise.
8908 * intervals.c (check_for_interval, search_for_interval)
8909 (inc_interval_count, count_intervals, root_interval)
8910 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8911 * lread.c (defalias): Likewise.
268c2c36 8912 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8913 * regex.c (set_image_of_range_1, set_image_of_range)
8914 (regex_grow_registers): Likewise.
8915 * sysdep.c (strerror): Likewise.
8916 * termcap.c (valid_filename_p, tprint, main): Likewise.
8917 * tparam.c (main): Likewise.
8918 * unexhp9k800.c (run_time_remap, save_data_space)
8919 (update_file_ptrs, read_header, write_header, calculate_checksum)
8920 (copy_file, copy_rest, display_header): Likewise.
8921 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8922 Likewise.
8923 * xdisp.c (check_it): Likewise.
8924 * xfaces.c (register_color, unregister_color, unregister_colors):
8925 Likewise.
8926 * xfns.c (print_fontset_result): Likewise.
8927 * xrdb.c (member, fatal, main): Likewise.
8928
99033785
PE
89292011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8930
8931 Fix minor problems found by static checking (Bug#9031).
8932 * chartab.c (char_table_set_range, map_sub_char_table):
8933 Remove unused locals.
8934 (uniprop_table): Now static.
8935 * composite.c (_work_char): Remove unused static var.
8936
9cb2ac56
JB
89372011-07-09 Juanma Barranquero <lekktu@gmail.com>
8938
8939 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8940
f25661f0
JD
89412011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8942
8943 * gtkutil.c (qttip_cb): Remove code without function.
8944
8278c4fe
EZ
89452011-07-09 Eli Zaretskii <eliz@gnu.org>
8946
8947 * w32.c (pthread_sigmask): New stub.
8948
1692ae2d 89492011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8950
8a6ebd58 8951 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8952 sigprocmask is portable only for single-threaded applications, and
8953 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8954 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8955 (LIBES): Use it.
8956 * callproc.c (Fcall_process):
8957 * process.c (create_process):
8958 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8959 Use pthread_sigmask, not sigprocmask.
123403e4 8960
1b854618
JD
89612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8962
8963 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8964 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8965 wrong (Bug#8591).
8966
3fe4b549
JD
89672011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8968
0ce7e563
JD
8969 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8970 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8971 (xg_hide_tooltip): Fix comment.
8972
3fe4b549
JD
8973 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8974 in registerServicesMenuSendTypes.
8975 (validRequestorForSendType): Don't check ns_return_types.
8976
8977 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8978 ns_return_type.
8979
5df75e47
JR
89802011-07-08 Jason Rumney <jasonr@gnu.org>
8981
22610910
JR
8982 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8983 SH_SHOW for hidden windows (Bug#5482).
8984
5df75e47
JR
8985 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8986 frame struct members of non-existent frames (Bug#6284).
8987
699c10bd
JD
89882011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8989
4393663b
JD
8990 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8991 variable firstTime not needed on OSX >= 10.6.
8992 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8993 >= 10.5. Use setKnobProportion, setDoubleValue.
8994
8995 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8996 (MAC_OS_X_VERSION_10_5): Define if not defined.
8997 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8998 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8999 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9000
9001 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9002 cString and lossyCString on OSX >= 10.4.
4393663b 9003
58179cce 9004 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9005 sizeToFit on OSX >= 10.2.
9006
9007 * nsimage.m (allocInitFromFile): Don't use deprecated method
9008 bestRepresentationForDevice on OSX >= 10.6.
9009
9010 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9011 to avoid warning.
9012
9013 * emacs.c: Declare unexec_init_emacs_zone.
9014
a63e0781
JD
9015 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9016
699c10bd
JD
9017 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9018
9019 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9020 on svcsMenu (Bug#8842).
9021
9022 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9023 ns_return_types.
9024 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9025
9026 * nsterm.m (QUTF8_STRING): Declare.
9027 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9028 (validRequestorForSendType): Return type is (id).
9029 Change indexOfObjectIdenticalTo to indexOfObject.
9030 Check if we have local selection before returning self (Bug#8842).
9031 (writeSelectionToPasteboard): Put local selection into paste board
9032 if we have a local selection (Bug#8842).
9033 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9034
9035 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9036 (ns_get_local_selection): Declare.
9037
54e10184
LMI
90382011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9039
9888ff71
LMI
9040 * keymap.c (describe_map_tree): Don't insert a double newline at
9041 the end of the buffer (bug#1169) and return whether we inserted
9042 something.
9043
54e10184
LMI
9044 * callint.c (Fcall_interactively): Change "reading args" to
9045 "providing args" to try to clarify what it does (bug#1010).
9046
15fa4783
KH
90472011-07-07 Kenichi Handa <handa@m17n.org>
9048
9049 * composite.c (composition_compute_stop_pos): Ignore a static
9050 composition starting before CHARPOS (Bug#8915).
9051
9052 * xdisp.c (handle_composition_prop): Likewise.
9053
a8815b00
EZ
90542011-07-07 Eli Zaretskii <eliz@gnu.org>
9055
9056 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9057 (Bug#9015)
9058
ef7b981d 90592011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9060
9061 * character.h (unicode_category_t): New enum type.
9062
9063 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9064 (Qchar_code_property_table): New variable.
9065 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9066 (UNIPROP_COMPRESSED_FORM_P): New macros.
9067 (char_table_ascii): Uncompress the compressed values.
9068 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9069 Uncompress the compressed values.
ac389d0c 9070 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9071 (char_table_ref_and_range): Uncompress the compressed values.
9072 (sub_char_table_set): New arg is_uniprop. Callers changed.
9073 Uncompress the compressed values.
9074 (sub_char_table_set_range): Args changed. Callers changed.
9075 (char_table_set_range): Adjuted for the above change.
9076 (map_sub_char_table): Delete args default_val and parent. Add arg
9077 top. Give decoded values to a Lisp function.
640c8776 9078 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9079 values to a Lisp function. Gcpro more variables.
9080 (uniprop_table_uncompress)
9081 (uniprop_decode_value_run_length): New functions.
9082 (uniprop_decoder, uniprop_decoder_count): New variables.
9083 (uniprop_get_decoder, uniprop_encode_value_character)
9084 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9085 New functions.
9086 (uniprop_encoder, uniprop_encoder_count): New variables.
9087 (uniprop_get_encoder, uniprop_table)
9088 (Funicode_property_table_internal, Fget_unicode_property_internal)
9089 (Fput_unicode_property_internal): New functions.
9090 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9091 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9092 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9093 char-code-property-alist.
9094
640c8776 9095 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9096 Vunicode_category_table.
9097
640c8776 9098 * font.c (font_range): Adjust for the change of
c805dec0
KH
9099 Vunicode_category_table.
9100
76b397fb
DN
91012011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9102
9103 * m/iris4d.h: Remove file, move contents ...
9104 * s/irix6-5.h: ... here.
9105
22b4128e
PE
91062011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9107
9108 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9109 * alloc.c (mark_buffer):
9110 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9111 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9112 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9113 This isn't true in general, and it's particularly not true
9114 if Emacs is configured with --with-wide-int.
9115 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9116 New macros, used in the buffer.c change.
9117
869795d6
JD
91182011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9119
9120 * xsettings.c: Use both GConf and GSettings if both are available.
9121 (store_config_changed_event): Add comment.
9122 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9123 (store_tool_bar_style_changed): New functions.
5e617bc2 9124 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9125 (struct xsettings): Move font inside HAVE_XFT.
9126 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9127 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9128 Move inside HAVE_XFT.
640c8776 9129 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9130 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9131 also.
9132 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9133 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9134 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9135 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9136 (parse_settings): Move check for font inside HAVE_XFT.
9137 (read_settings, apply_xft_settings): Add comment.
9138 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9139 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9140 call store_font_name_changed.
9141 (xft_settings_event): Add comment.
9142 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9143 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9144 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9145 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9146 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9147 (xsettings_get_system_font, xsettings_get_system_normal_font):
9148 Add comment.
869795d6 9149
d8ed26bd
PE
91502011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9151
9152 Random fixes. E.g., (random) never returned negative values.
9153 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9154 subseconds part to the entropy, as that's a bit more random.
9155 Prefer signed to unsigned, since the signedness doesn't matter and
9156 in general we prefer signed. When given a limit, use a
9157 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9158 latter isn't right if USE_2_TAGS_FOR_INTS.
9159 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9160 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9161
cabf1cac
SM
91622011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9163
9164 * textprop.c (text_property_stickiness):
9165 Obey Vtext_property_default_nonsticky.
9166 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9167 * w32fns.c (syms_of_w32fns):
9168 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9169
6e9b2be9
PE
91702011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9171
9172 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9173 This is more efficient than Ffile_directory_p and avoids a minor race.
9174
90186c68
LMI
91752011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9176
7c301272
LMI
9177 * buffer.c (Foverlay_put): Say what the return value is
9178 (bug#7835).
9179
c4f2d8d4
LMI
9180 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9181 is a directory before asking whether to use the file name
9182 (bug#7564).
ad637907
LMI
9183 (barf_or_query_if_file_exists): Make the "File is a directory"
9184 error be more correct.
c4f2d8d4 9185
90186c68
LMI
9186 * fns.c (Frequire): Remove the mention of the .gz files, since
9187 that's installation-specific, but keep the mention of
9188 `get-load-suffixes'.
9189
da64016e
PE
91902011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9191
9192 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9193 Report string overflow if the output is too long.
9194
7d47b580
JB
91952011-07-04 Juanma Barranquero <lekktu@gmail.com>
9196
a555cb87
JB
9197 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9198 (syms_of_gnutls): Remove duplicate DEFSYM for
9199 Qgnutls_bootprop_verify_hostname_error, an error for
9200 Qgnutls_bootprop_verify_error (which is no longer used).
9201
7d47b580
JB
9202 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9203 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9204 Also (re)move comments that are misplaced or no longer relevant.
9205
1e49bfab
LMI
92062011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9207
9208 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9209
1485f4c0
CY
92102011-07-03 Chong Yidong <cyd@stupidchicken.com>
9211
9212 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9213 and background color parameters if they have been changed.
9214
a9ab721e
LMI
92152011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9216
9217 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9218
cf7cff57
PE
92192011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9220
2e13213d
PE
9221 * xsettings.c (SYSTEM_FONT): Define only when used.
9222 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9223
cf7cff57
PE
9224 * keymap.c (access_keymap_1): Now static.
9225
7a8e04f7
CY
92262011-07-02 Chong Yidong <cyd@stupidchicken.com>
9227
9228 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9229 leave any prefix arg for the up event (Bug#1586).
9230
61352f62
LMI
92312011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9232
69bb1ef7
LMI
9233 * lread.c (syms_of_lread): Mention single symbols defined by
9234 `defvar' or `defconst' (bug#7154).
9235
61352f62 9236 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9237 (Frequire): Mention get-load-suffixes.
61352f62 9238
28545e04
MR
92392011-07-02 Martin Rudalics <rudalics@gmx.at>
9240
9241 * window.h (window): Remove clone_number slot.
9242 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9243 Remove.
9244 (make_parent_window, make_window, saved_window)
9245 (Fset_window_configuration, save_window_save): Don't deal with
9246 clone numbers.
9247 * buffer.c (Qclone_number): Remove declaration.
9248 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9249
3349e122
SM
92502011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9251
9252 Add multiple inheritance to keymaps.
9253 * keymap.c (Fmake_composed_keymap): New function.
9254 (Fset_keymap_parent): Simplify.
9255 (fix_submap_inheritance): Remove.
9256 (access_keymap_1): New function extracted from access_keymap to handle
9257 embedded parents and handle lists of maps.
9258 (access_keymap): Use it.
9259 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9260 (Fcopy_keymap): Handle embedded parents.
9261 (Fcommand_remapping, define_as_prefix): Simplify.
9262 (Fkey_binding): Simplify.
9263 (syms_of_keymap): Move minibuffer-local-completion-map,
9264 minibuffer-local-filename-completion-map,
9265 minibuffer-local-must-match-map, and
9266 minibuffer-local-filename-must-match-map to Elisp.
9267 (syms_of_keymap): Defsubr make-composed-keymap.
9268 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9269 (parse_menu_item): Trivial simplification.
9270
3279eb87
GM
92712011-07-01 Glenn Morris <rgm@gnu.org>
9272
9273 * Makefile.in (SETTINGS_LIBS): Fix typo.
9274
4550efdf
KI
92752011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9276
9277 * coding.c (Fencode_coding_string): Record the last coding system
9278 used, as the function doc string says (bug#8738).
9279
0949d2b6
JD
92802011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9281
9282 * xsettings.c (store_monospaced_changed): Take new font as arg and
9283 check for change against current_mono_font.
9284 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9285 (emacs_settings_constructor, emacs_settings_get_property)
9286 (emacs_settings_set_property, emacs_settings_class_init)
9287 (emacs_settings_init, gsettings_obj): Remove.
9288 (something_changedCB): New function for HAVE_GSETTINGS.
9289 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9290 with value as argument.
9291 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9292 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9293 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9294 "changed".
9295
9296 * xgselect.c: Add defined (HAVE_GSETTINGS).
9297 (xgselect_initialize): Ditto.
9298
9299 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9300 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9301 xg_select.
9302
bbc6b304
PE
93032011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9304
9305 * eval.c (struct backtrace): Simplify and port the data structure.
9306 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9307 signed bit field, as this assumption is not portable and it makes
9308 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9309 "char debug_on_exit : 1" as this is not portable either; instead,
9310 use the portable "unsigned int debug_on_exit : 1". Remove unused
9311 member evalargs. Remove obsolete comments about cc bombing out.
9312
9851bfc5
JD
93132011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9314
51bb811f 9315 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9316 Let HAVE_GSETTINGS override HAVE_GCONF.
9317 (store_monospaced_changed): New function.
9318 (EMACS_SETTINGS): A new type derived from GObject to handle
9319 GSettings notifications.
9320 (emacs_settings_constructor, emacs_settings_get_property)
9321 (emacs_settings_set_property, emacs_settings_class_init):
9322 New functions.
9323 (gsettings_client, gsettings_obj): New variables.
9324 (GSETTINGS_SCHEMA): New define.
9325 (something_changedCB): Call store_monospaced_changed.
9326 (init_gsettings): New function.
9327 (xsettings_initialize): Call init_gsettings.
9328 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9329 to NULL.
9330
640c8776 9331 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9332 GCONF_CFLAGS/LIBS.
9333
5386012d
MR
93342011-06-29 Martin Rudalics <rudalics@gmx.at>
9335
9336 * window.c (resize_root_window, grow_mini_window)
9337 (shrink_mini_window): Rename Qresize_root_window to
9338 Qwindow_resize_root_window and Qresize_root_window_vertically to
9339 Qwindow_resize_root_window_vertically.
9340
f13e0b08
PE
93412011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9342
9343 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9344
94515237
JB
93452011-06-27 Juanma Barranquero <lekktu@gmail.com>
9346
9347 * makefile.w32-in: Redesign dependencies so they reflect more
9348 clearly which files are directly included by each source file,
9349 and not through other includes.
9350
e43b6e43
MR
93512011-06-27 Martin Rudalics <rudalics@gmx.at>
9352
9353 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9354 (sort_overlays, overlay_strings): When an overlay's clone number
9355 matches the window's clone number process the overlay even if
9356 the overlay's window property doesn't match the current window.
9357
d68443dc
MR
9358 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9359 (Fwindow_hchild): Rename to Fwindow_left_child.
9360 (Fwindow_next): Rename to Fwindow_next_sibling.
9361 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9362 (resize_window_check): Rename to window_resize_check.
9363 (resize_window_apply): Rename to window_resize_apply.
9364 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9365 (Fdelete_other_windows_internal, resize_frame_windows)
9366 (Fsplit_window_internal, Fdelete_window_internal)
9367 (grow_mini_window, shrink_mini_window)
9368 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9369
c7e73be5
JD
93702011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9371
9372 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9373 (emacs_fixed_set_min_size): Remove.
9374 (emacs_fixed_new): Take frame as argument.
9375
9376 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9377 (_EmacsFixedPrivate): Remove minwidth/height.
9378 Add struct frame *f.
9379 (emacs_fixed_init): Initialize priv->f.
9380 (get_parent_class, emacs_fixed_set_min_size): Remove.
9381 (emacs_fixed_new): Set priv->f to argument.
9382 (emacs_fixed_get_preferred_width)
9383 (emacs_fixed_get_preferred_height): Use min_width/height from
9384 frames size_hint to set minimum and natural (Bug#8919).
9385 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9386 and use min_width/height from frames size_hint to set
9387 min_width/height (Bug#8919).
9388
9389 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9390 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9391 Fix indentation.
c7e73be5 9392
cf99dcf8
EZ
93932011-06-26 Eli Zaretskii <eliz@gnu.org>
9394
9395 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9396 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9397 called at ZV.
9398
029529ac
CY
93992011-06-26 Chong Yidong <cyd@stupidchicken.com>
9400
9401 * process.c (wait_reading_process_output): Bypass select if
9402 waiting for a cell while ignoring keyboard input, and input is
9403 pending. Suggested by Jan Djärv (Bug#8869).
9404
7a7ef429
PE
94052011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9406
9407 Use gnulib's dup2 module instead of rolling our own.
9408 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9409
11fdef7d 94102011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9411
9412 * dispnew.c (scrolling_window): Before scrolling, turn off a
9413 mouse-highlight in the window being scrolled.
9414
cd3520a4
JB
94152011-06-24 Juanma Barranquero <lekktu@gmail.com>
9416
9417 Move DEFSYM to lisp.h and use everywhere.
9418
9419 * character.h (DEFSYM): Move declaration...
9420 * lisp.h (DEFSYM): ...here.
9421
9422 * gnutls.c:
9423 * minibuf.c:
9424 * w32menu.c:
9425 * w32proc.c:
9426 * w32select.c: Don't include character.h.
9427
9428 * alloc.c (syms_of_alloc):
9429 * buffer.c (syms_of_buffer):
9430 * bytecode.c (syms_of_bytecode):
9431 * callint.c (syms_of_callint):
9432 * casefiddle.c (syms_of_casefiddle):
9433 * casetab.c (init_casetab_once):
9434 * category.c (init_category_once, syms_of_category):
9435 * ccl.c (syms_of_ccl):
9436 * cmds.c (syms_of_cmds):
9437 * composite.c (syms_of_composite):
9438 * dbusbind.c (syms_of_dbusbind):
9439 * dired.c (syms_of_dired):
9440 * dispnew.c (syms_of_display):
9441 * doc.c (syms_of_doc):
9442 * editfns.c (syms_of_editfns):
9443 * emacs.c (syms_of_emacs):
9444 * eval.c (syms_of_eval):
9445 * fileio.c (syms_of_fileio):
9446 * fns.c (syms_of_fns):
9447 * frame.c (syms_of_frame):
9448 * fringe.c (syms_of_fringe):
9449 * insdel.c (syms_of_insdel):
9450 * keymap.c (syms_of_keymap):
9451 * lread.c (init_obarray, syms_of_lread):
9452 * macros.c (syms_of_macros):
9453 * msdos.c (syms_of_msdos):
9454 * print.c (syms_of_print):
9455 * process.c (syms_of_process):
9456 * search.c (syms_of_search):
9457 * sound.c (syms_of_sound):
9458 * syntax.c (init_syntax_once, syms_of_syntax):
9459 * terminal.c (syms_of_terminal):
9460 * textprop.c (syms_of_textprop):
9461 * undo.c (syms_of_undo):
9462 * w32.c (globals_of_w32):
9463 * window.c (syms_of_window):
9464 * xdisp.c (syms_of_xdisp):
9465 * xfaces.c (syms_of_xfaces):
9466 * xfns.c (syms_of_xfns):
9467 * xmenu.c (syms_of_xmenu):
9468 * xsettings.c (syms_of_xsettings):
9469 * xterm.c (syms_of_xterm): Use DEFSYM.
9470
4228cf16
TZ
94712011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9472
cd3520a4 9473 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9474
7fcccf1e
PE
94752011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9476
7efb4e0e
PE
9477 Integer and buffer overflow fixes (Bug#8873).
9478
ff5844ad
PE
9479 * print.c (printchar, strout): Check for string overflow.
9480 (PRINTPREPARE, printchar, strout):
9481 Don't set size unless allocation succeeds.
9482
90532f02
PE
9483 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9484 for sizes. Check for string overflow more accurately.
9485 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9486
6d84508d
PE
9487 * macros.c: Integer and buffer overflow fixes.
9488 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9489 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9490 Use ptrdiff_t, not int, for sizes.
9491 Don't increment bufsize until after realloc succeeds.
9492 Check for size-calculation overflow.
9493 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9494
437b2cb4
PE
9495 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9496
8b9ac8b4
PE
9497 * lread.c: Integer overflow fixes.
9498 (read_integer): Radix is now EMACS_INT, not int,
9499 to improve quality of diagnostics for out-of-range radices.
9500 Calculate buffer size correctly for out-of-range radices.
9501 (read1): Check for integer overflow in radices, and in
9502 read-circle numbers.
82cb60d3
PE
9503 (read_escape): Avoid int overflow.
9504 (Fload, openp, read_buffer_size, read1)
9505 (substitute_object_recurse, read_vector, read_list, map_obarray):
9506 Use ptrdiff_t, not int, for sizes.
9507 (read1): Use EMACS_INT, not int, for sizes.
20270765 9508 Check for size overflow.
8b9ac8b4 9509
7fcccf1e
PE
9510 * image.c (cache_image): Check for size arithmetic overflow.
9511
bfbbd7e7
PE
9512 * lread.c: Integer overflow issues.
9513 (saved_doc_string_size, saved_doc_string_length)
9514 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9515 Now ptrdiff_t, not int.
9516 (read1): Don't assume doc string length fits in int. Check for
9517 out-of-range doc string lengths.
9518 (read_list): Don't assume file position fits in int.
39019e54 9519 (read_escape): Check for hex character overflow.
bfbbd7e7 9520
4e323265
LL
95212011-06-22 Leo Liu <sdl.web@gmail.com>
9522
9523 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9524 Move to minibuffer.el.
9525
85fece3e
PE
95262011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9527
20b84ce9 9528 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9529 The following patches are for when GLYPH_DEBUG && !XASSERT.
9530 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9531 * dispnew.c (flush_stdout):
9532 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9533 Mark as externally visible.
9534 * dispnew.c (check_window_matrix_pointers): Now static.
9535 * dispnew.c (window_to_frame_vpos):
9536 * xfns.c (unwind_create_frame):
9537 * xterm.c (x_check_font): Remove unused local.
9538 * scroll.c (CHECK_BOUNDS):
9539 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9540 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9541 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9542 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9543 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9544 Now static.
9545 (debug_method_add): Use va_list and vsprintf rather than relying
9546 on undefined behavior with wrong number of arguments.
9547 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9548 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9549 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9550 since we're not interested in debugging glyphs with old libraries.
9551 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9552 GCC 4.6.0's static checking.
9553
0766b489
PE
95542011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9555
31fd4b32
PE
9556 Integer overflow and signedness fixes (Bug#8873).
9557 A few related buffer overrun fixes, too.
9558
b79e8648
PE
9559 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9560
0766b489
PE
9561 * dispextern.h (struct face.stipple):
9562 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9563 (x_bitmap_mask, x_allocate_bitmap_record)
9564 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9565 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9566 (x_create_bitmap_from_xpm_data):
9567 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9568 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9569 (.bitmaps_last):
9570 * xfaces.c (load_pixmap):
9571 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9572 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9573 (.bitmaps_last, struct x_output.icon_bitmap):
9574 Use ptrdiff_t, not int, for bitmap indexes.
9575 (x_allocate_bitmap_record): Check for size overflow.
9576 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9577
b081724f
PE
9578 Use ptrdiff_t, not int, for overlay counts.
9579 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9580 * editfns.c (overlays_around, get_pos_property):
9581 * textprop.c (get_char_property_and_overlay):
9582 * xdisp.c (next_overlay_change, note_mouse_highlight):
9583 * xfaces.c (face_at_buffer_position):
21514da7
PE
9584 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9585 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9586 (Fnext_overlay_change, Fprevious_overlay_change)
9587 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9588 Use ptrdiff_t, not int, for sizes.
21514da7 9589 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9590
3de73e5e
PE
9591 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9592
2606c57b
PE
9593 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9594 (x_session_initialize): Do not assume string length fits in int.
9595
aaafe47a
PE
9596 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9597 This is unlikely, but can occur if DPI is outlandish.
9598
2674ddc8 9599 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9600 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9601
28154962
PE
9602 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9603 * xrdb.c (magic_file_p, search_magic_path):
9604 Omit last arg SUFFIX; it was always 0. All callers changed.
9605 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9606
7de51af5
PE
9607 * xfont.c (xfont_match): Avoid need for strlen.
9608
25ed6cc3
PE
9609 * xfns.c: Don't assume strlen fits in int.
9610 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9611
4eab31dd
PE
9612 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9613 not unsigned long, as we prefer signed integers. All callers changed.
9614 Detect integer overflow in repeat count.
9615 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9616 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9617
171e2a58
PE
9618 * termcap.c: Don't assume sizes fit in int and never overflow.
9619 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9620 (gobble_line): Check for size-calculation overflow.
9621
ad39faca 9622 * minibuf.c (Fread_buffer):
6e5bb2dc 9623 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9624 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9625 Don't assume string length fits in int.
9626
52c61c22 9627 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9628 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9629
b5b8c9e5
PE
9630 * font.c: Don't assume string length fits in int.
9631 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9632 Use ptrdiff_t, not int.
ccd6111c
PE
9633 (font_intern_prop): Don't assume string length fits in int.
9634 Don't assume integer property fits in fixnum.
9635 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9636
882f0d81 9637 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9638 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9639 Reformulate so as not to need the command string.
9640 Invoke gzip -cd rather than gunzip, as it's more portable.
9641 (lock_info_type, lock_file_1, lock_file):
9642 Don't assume pid_t and time_t fit in unsigned long.
9643 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9644 (current_lock_owner): Prefer signed type for sizes.
9645 Use memcpy, not strncpy, where memcpy is what is really wanted.
9646 Don't assume (via atoi) that time_t and pid_t fit in int.
9647 Check for time_t and/or pid_t out of range, e.g., via a network share.
9648 Don't alloca where an auto var works fine.
9649
93f4cf88
PE
9650 * fileio.c: Fix some integer overflow issues.
9651 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9652 Don't assume string length fits in int.
9653 (directory_file_name): Don't assume string length fits in long.
9654 (make_temp_name): Don't assume pid fits in int, or that its print
9655 length is less than 20.
9656
f3e92b69
PE
9657 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9658
1bfdaf10
PE
9659 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9660
35016e9a
PE
9661 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9662
3d1e65a1
PE
9663 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9664 We prefer signed integers, even for size calculations.
9665
0b963a93
PE
9666 * emacs.c: Don't assume string length fits in 'int'.
9667 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9668 (main): Don't invoke strlen when not needed.
9669
573f4b54
PE
9670 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9671 (XD_DEBUG_MESSAGE): Don't waste a byte.
9672
989f33ba
PE
9673 * callproc.c (getenv_internal_1, getenv_internal)
9674 (Fgetenv_internal):
965d34eb
PE
9675 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9676
e4d29b33
PE
9677 * lread.c (invalid_syntax): Omit length argument.
9678 All uses changed. This doesn't fix a bug, but it simplifies the
9679 code away from its former Hollerith-constant appearance, and it's
9680 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9681 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9682
eb49b136
PE
9683 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9684 This didn't break anything, but it didn't help either.
9685 It's confusing to put a bogus integer in a place where the actual
9686 value does not matter.
9f62aeb1 9687 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9688 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9689
15375a22
PE
9690 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9691 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9692 implementation.
b61cc01c
PE
9693 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9694 We prefer signed types, and the value cannot exceed the EMACS_INT
9695 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9696 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9697 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9698 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9699
53b2623d
PE
9700 * indent.c (sane_tab_width): New function.
9701 (current_column, scan_for_column, Findent_to, position_indentation)
9702 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9703 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9704
51cab52b 9705 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9706
f2ed8a70
PE
9707 * lisp.h (lint_assume): New macro.
9708 * composite.c (composition_gstring_put_cache):
9709 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9710
abe80cc6
PE
9711 * editfns.c, insdel.c:
9712 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9713
b02c740e
PE
9714 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9715
ebc96716
PE
9716 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9717
b4e50fa0 9718 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9719 Use much-faster test for byte-length change.
311d5d7c 9720 Don't assume string byte-length fits in 'int'.
a4cf38e4 9721 Check that character arg fits in 'int'.
85461888 9722 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9723
c0c1ee9f
PE
9724 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9725
a498d7f4
PE
9726 * fns.c (concat): Catch string overflow earlier.
9727 Do not rely on integer wraparound.
9728
51cab52b
PE
9729 * dispextern.h (struct it.overlay_strings_charpos)
9730 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9731 * xdisp.c (forward_to_next_line_start)
9732 (back_to_previous_visible_line_start)
9733 (reseat_at_next_visible_line_start, next_element_from_buffer):
9734 Don't arbitrarily truncate the value of 'selective' to int.
9735
76031fad
PE
9736 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9737
5eb55db9
PE
9738 * composite.c: Don't truncate sizes to 'int'.
9739 (composition_gstring_p, composition_reseat_it)
9740 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9741 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9742 not EMACS_UINT, for indexes.
5eb55db9 9743
0703a717
PE
9744 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9745
d6202519
PE
9746 * buffer.c: Include <verify.h>.
9747 (struct sortvec.priority, struct sortstr.priority):
8961a454 9748 Now EMACS_INT, not int.
c20998a7 9749 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9750 (struct sortstr.size, record_overlay_string)
9751 (struct sortstrlist.size, struct sortlist.used):
9752 Don't truncate size to int.
9753 (record_overlay_string): Check for size-calculation overflow.
d6202519 9754 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9755
d5a19415
JM
97562011-06-22 Jim Meyering <meyering@redhat.com>
9757
029529ac 9758 Don't leak an XBM-image-sized buffer
d5a19415
JM
9759 * image.c (xbm_load): Free the image buffer after using it.
9760
a9041e6c
PE
97612011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9762
9763 Port to Sun C.
9764 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9765 that Sun C diagnosed.
9766 * fns.c (secure_hash): Fix pointer signedness issue.
9767 * intervals.c (static_offset_intervals): New function.
9768 (offset_intervals): Use it.
9769
7f3f739f
LL
97702011-06-21 Leo Liu <sdl.web@gmail.com>
9771
9772 * deps.mk (fns.o):
9773 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9774 sha512.h.
9775
9776 * fns.c (secure_hash): Rename from crypto_hash_function and change
9777 the first arg to accept symbols.
5b66d427 9778 (Fsecure_hash): New primitive.
7f3f739f
LL
9779 (syms_of_fns): New symbols.
9780
76147d94
DD
97812011-06-20 Deniz Dogan <deniz@dogan.se>
9782
9783 * process.c (Fset_process_buffer): Clarify return value in
9784 docstring.
9785
7d7d0045
CY
97862011-06-18 Chong Yidong <cyd@stupidchicken.com>
9787
9788 * dispnew.c (add_window_display_history): Use BVAR.
9789
9790 * xdisp.c (debug_method_add): Use BVAR.
9791 (check_window_end, dump_glyph_matrix, dump_glyph)
9792 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9793
9794 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9795 Likewise.
9796
9797 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9798 check till after the cache is created in init_frame_faces.
9799
ff2bc410
SM
98002011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9801
9802 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9803
28177add
PE
98042011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9805
dd3482fe
PE
9806 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9807 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9808 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9809
393d71f3 9810 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9811 * fileio.c (Finsert_file_contents):
9812 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9813 Remove the old (too-loose) buffer overflow checks.
9814 They weren't needed, since make_gap checks for buffer overflow.
9815 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9816 The old code merely checked for Emacs fixnum overflow, and relied
9817 on undefined (wraparound) behavior. The new code avoids undefined
9818 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9819
2e6813b0 9820 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9821 Tune. Don't use wider integers than needed. Don't use alloca.
9822 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9823
599a9e4f
PE
9824 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9825
99561444
PE
9826 * insdel.c, lisp.h (buffer_overflow): New function.
9827 (insert_from_buffer_1, replace_range, replace_range_2):
9828 * insdel.c (make_gap_larger):
9829 * editfns.c (Finsert_char):
9830 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9831
28177add
PE
9832 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9833
e69dafad
PE
98342011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9835
4baa020d 9836 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9837
b1c46f02
PE
9838 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9839 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9840
e69dafad
PE
9841 * fileio.c: Don't assume EMACS_INT fits in off_t.
9842 (emacs_lseek): New static function.
9843 (Finsert_file_contents, Fwrite_region): Use it.
9844 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9845
566684ea
PE
9846 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9847
e6966cd6
PE
9848 * fns.c: Don't overflow int when computing a list length.
9849 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9850 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9851 truncation on 64-bit hosts. Check for QUIT every
9852 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9853 faster and is responsive enough.
9854 (Flength): Report an error instead of overflowing an integer.
9855 (Fsafe_length): Return a float if the value is not representable
9856 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9857 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9858 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9859
dd0b0efb
PE
9860 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9861 (header_size, word_size): New constants.
9862 (allocate_vectorlike): Don't check size overflow here.
9863 (allocate_vector): Check it here instead, since this is the only
9864 caller of allocate_vectorlike that could cause overflow.
9865 Check that the new vector's length is representable as a fixnum.
9866
86fe5cfe
PE
9867 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9868 The previous code was bogus. For example, next_almost_prime (32)
9869 returned 39, which is undesirable as it is a multiple of 3; and
9870 next_almost_prime (24) returned 25, which is a multiple of 5 so
9871 why was the code bothering to check for multiples of 7?
9872
80e88859
PE
9873 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9874
4a2f0ad6
PE
9875 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9876
f66c7cf8
PE
9877 Variadic C functions now count arguments with ptrdiff_t.
9878 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9879 Back then I didn't know that the Emacs coding style prefers signed int.
9880 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9881 were being counted with int, which may truncate counts on 64-bit
9882 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9883 * lisp.h (struct Lisp_Subr.function.aMANY)
9884 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9885 Arg counts are now ptrdiff_t, not size_t.
9886 All variadic functions and their callers changed accordingly.
9887 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9888 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9889 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9890 * callint.c (Fcall_interactively): Check arg count for overflow,
9891 to avoid potential buffer overrun. Use signed char, not 'int',
9892 for 'varies' array, so that we needn't bother to check its size
9893 calculation for overflow.
9894 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9895 * eval.c (apply_lambda):
9896 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9897 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9898 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9899
a1759b76
PE
9900 * callint.c (Fcall_interactively): Don't use index var as event count.
9901
d96be9fc
PE
9902 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9903 * mem-limits.h (SIZE): Remove; no longer used.
9904
a690a978 9905 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9906
578c21e6
PE
9907 Remove unnecessary casts.
9908 * xterm.c (x_term_init):
9909 * xfns.c (x_set_border_pixel):
9910 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9911 These aren't needed now that we assume ANSI C.
9912
96f53c6c
PE
9913 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9914 It's more likely to cause problems (due to unsigned overflow)
9915 than to cure them.
9916
83c77d31
PE
9917 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9918
ee2079f1
PE
9919 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9920
6da65536
PE
9921 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9922
7147c4a4
PE
9923 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9924
193e32d9
PE
9925 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9926
e5533da6
PE
9927 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9928
9910e595
PE
9929 GLYPH_CODE_FACE returns EMACS_INT, not int.
9930 * dispextern.h (merge_faces):
9931 * xfaces.c (merge_faces):
01103c44
PE
9932 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9933 Don't assume EMACS_INT fits in int.
9910e595 9934
2638320e
PE
9935 * character.h (CHAR_VALID_P): Remove unused parameter.
9936 * fontset.c, lisp.h, xdisp.c: All uses changed.
9937
045eb8d9
PE
9938 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9939
c1f134b5
PE
9940 * fns.c (concat): Minor tuning based on overflow analysis.
9941 This doesn't fix any bugs. Use int to hold character, instead
9942 of constantly refetching from Emacs object. Use XFASTINT, not
9943 XINT, for value known to be a character. Don't bother comparing
9944 a single byte to 0400, as it's always less.
9945
395fcb93 9946 * floatfns.c (Fexpt):
327eeec8
PE
9947 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9948
abbd3d23
PE
9949 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9950 for characters.
9951
684a03ef
PE
9952 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9953
0fed43f3
PE
9954 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9955 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9956 incorrectly succeed when S was a string, because 4294967386 was
9957 truncated before it was used.
9958
8fd02eb7
PE
9959 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9960 Otherwise, an out-of-range integer could cause undefined behavior
9961 on a 64-bit host.
9962
f8c86b69
PE
9963 * composite.c: Use int, not EMACS_INT, for characters.
9964 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9965 EMACS_INT, for values that are known to be in character range.
9966 This doesn't fix any bugs but is the usual style inside Emacs and
9967 may generate better code on 32-bit machines.
9968
34206dd2
PE
9969 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9970 This is for reasons similar to the recent CHAR_STRING fix.
9971 * charset.c (Fencode_char): Check that character arg is actually
9972 a character. Pass an int to ENCODE_CHAR.
9973 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9974 wider than 'int', as a compile-time check to prevent future regressions
9975 in this area.
9976
c5958d4c 9977 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9978
9979 Make sure a 64-bit char is never passed to CHAR_STRING.
9980 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9981 by silently ignoring the top 32 bits, allowing some values
9982 that were far too large to be valid characters.
9983 * character.h: Include <verify.h>.
9984 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9985 arguments are no wider than unsigned, as a compile-time check
9986 to prevent future regressions in this area.
9987 * data.c (Faset):
01103c44 9988 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9989 (Fsubst_char_in_region):
9990 * fns.c (concat):
9991 * xdisp.c (decode_mode_spec_coding):
9992 Adjust to CHAR_STRING's new requirement.
9993 * editfns.c (Finsert_char, Fsubst_char_in_region):
9994 * fns.c (concat): Check that character args are actually
9995 characters. Without this test, these functions did the wrong
9996 thing with wildly out-of-range values on 64-bit hosts.
9997
d37ca623
PE
9998 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9999 These casts should not be needed on 32-bit hosts, either.
10000 * keyboard.c (read_char):
10001 * lread.c (Fload): Remove casts to unsigned.
10002
ea204efb
PE
10003 * lisp.h (UNSIGNED_CMP): New macro.
10004 This fixes comparison bugs on 64-bit hosts.
10005 (ASCII_CHAR_P): Use it.
10006 * casefiddle.c (casify_object):
01103c44 10007 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10008 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10009 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10010 * dispextern.h (FACE_FROM_ID):
10011 * keyboard.c (read_char): Use UNSIGNED_CMP.
10012
41cb286c
PE
10013 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10014 not to EMACS_INT, to avoid GCC warning.
10015
4a1b9832
PE
10016 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10017
55daad71
PE
10018 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10019 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10020 isn't needed on 32-bit machines.
8f95c75c 10021
01103c44
PE
10022 * buffer.c (Fgenerate_new_buffer_name):
10023 Use EMACS_INT for count, not int.
0ceccced 10024 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10025
10026 * data.c (Qcompiled_function): Now static.
10027
c6f072e7
PE
10028 * window.c (window_body_lines): Now static.
10029
20ce5912
PE
10030 * image.c (gif_load): Rename local to avoid shadowing.
10031
9c4c5f81
PE
10032 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10033 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10034 * alloc.c (make_save_value): Integer argument is now of type
10035 ptrdiff_t, not int.
10036 (mark_object): Use ptrdiff_t, not int.
10037 * lisp.h (pD): New macro.
10038 * print.c (print_object): Use it.
10039
c0c5c8ae
PE
10040 * alloc.c: Use EMACS_INT, not int, to count objects.
10041 (total_conses, total_markers, total_symbols, total_vector_size)
10042 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10043 (total_free_floats, total_floats, total_free_intervals)
10044 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10045 Now EMACS_INT, not int. All uses changed.
10046 (Fgarbage_collect): Compute overall total using a double, so that
10047 integer overflow is less likely to be a problem. Check for overflow
10048 when converting back to an integer.
5a25e253
PE
10049 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10050 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10051 These were 'int' variables that could overflow on 64-bit hosts;
10052 they were never used, so remove them instead of repairing them.
211a0b2a 10053 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10054 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10055 Previously, this ceilinged at INT_MAX, but that doesn't work on
10056 64-bit machines.
e46bb31a 10057 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10058
c78baabf 10059 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10060 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10061 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10062 when a (possibly-narrower) signed value would do just as well.
10063 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10064
c9d624c6
PE
10065 * alloc.c: Catch some string size overflows that we were missing.
10066 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10067 for convenience in STRING_BYTES_MAX.
10068 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10069 The definition here is exact; the one in lisp.h was approximate.
10070 (allocate_string_data): Check for string overflow. This catches
10071 some instances we weren't catching before. Also, it catches
10072 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10073 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10074 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10075
c9d624c6
PE
10076 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10077 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10078 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10079
353032ce
PE
10080 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10081
2bccce07
PE
10082 * alloc.c (Fmake_string): Check for out-of-range init.
10083
0ac30604
SM
100842011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10085
10086 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10087
c195f2de
JD
100882011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10089
10090 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10091 xg_get_default_scrollbar_width.
10092
10093 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10094 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10095 (style_changed_cb): Call update_theme_scrollbar_width and call
10096 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10097 all frames (Bug#8505).
10098 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10099 Call gtk_window_set_resizable if HAVE_GTK3.
10100 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10101 and height if HAVE_GTK3 (Bug#8505).
10102 (scroll_bar_width_for_theme): New variable.
10103 (update_theme_scrollbar_width): New function.
10104 (xg_get_default_scrollbar_width): Move code to
10105 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10106 (xg_initialize): Call update_theme_scrollbar_width.
10107
10108 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10109
10110 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10111
e10ac9f1
MR
101122011-06-12 Martin Rudalics <rudalics@gmx.at>
10113
10114 * frame.c (make_frame): Call other_buffer_safely instead of
10115 other_buffer.
10116
10117 * window.c (temp_output_buffer_show): Call display_buffer with
10118 second argument Vtemp_buffer_show_specifiers and reset latter
10119 immediately after the call.
10120 (Vtemp_buffer_show_specifiers): New variable.
10121 (auto_window_vscroll_p, next_screen_context_lines)
10122 (Vscroll_preserve_screen_position): Remove leading asterisks from
10123 doc-strings.
10124
2d3c217e 101252011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10126
7b7f97e8 10127 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10128 * buffer.c (Qclone_number): Remove for now, as it's unused.
10129 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10130 (record_buffer): Remove unused local.
10131 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10132 (set_frame_buffer_list): Remove; unused.
10133 * frame.h (other_visible_frames): Remove decl.
10134 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10135 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10136 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10137 if HAVE_GPM.
10138 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10139 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10140 Define only if HAVE_GPM.
10141 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10142 (update_hints_inhibit): Remove; never set. All uses removed.
10143 * widgetprv.h (emacsFrameClassRec): Remove decl.
10144 * window.c (delete_deletable_window): Now returns void, since it
10145 wasn't returning anything.
10146 (compare_window_configurations): Remove unused locals.
10147 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10148 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10149 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10150 the same widths as pointers. This follows up on the 2011-05-06 patch.
10151 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10152 * xterm.h: Likewise.
10153 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10154
1384b89e
JB
101552011-06-12 Juanma Barranquero <lekktu@gmail.com>
10156
10157 * makefile.w32-in: Update dependencies.
10158 (LISP_H): Add lib/intprops.h.
10159
1100a63c
CY
101602011-06-11 Chong Yidong <cyd@stupidchicken.com>
10161
10162 * image.c (gif_load): Add animation frame delay to the metadata.
10163 (syms_of_image): Use DEFSYM. New symbol `delay'.
10164
6198ccd0
MR
101652011-06-11 Martin Rudalics <rudalics@gmx.at>
10166
10167 * window.c (delete_deletable_window): Re-add.
10168 (Fset_window_configuration): Rewrite to handle dead buffers and
10169 consequently deletable windows.
10170 (window_tree, Fwindow_tree): Remove. Supply functionality in
10171 window.el.
10172 (compare_window_configurations): Simplify code.
10173
b6e3633c
AS
101742011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10175
1ab0dee5
AS
10176 * image.c (imagemagick_load_image): Fix type mismatch.
10177 (Fimagemagick_types): Likewise.
10178
b6e3633c
AS
10179 * window.h (replace_buffer_in_windows): Declare.
10180
9397e56f
MR
101812011-06-11 Martin Rudalics <rudalics@gmx.at>
10182
10183 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10184 Qclone_number. Remove external declaration of Qdelete_window.
10185 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10186 code.
640c8776
SM
10187 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10188 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10189 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10190 buffer list implementation.
10191 (other_buffer_safely): New function.
10192 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10193 calls to replace_buffer_in_windows and
10194 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10195 if allowed.
10196 (record_buffer): Inhibit quitting and rewrite using quittable
10197 functions. Run Qbuffer_list_update_hook if allowed.
10198 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10199 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10200 Move switch-to-buffer to window.el.
9397e56f
MR
10201 (bury-buffer): Move to window.el.
10202 (Vbuffer_list_update_hook): New variable.
10203
10204 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10205 section.
10206
10207 * window.h (resize_frame_windows): Move up in code.
10208 (Fwindow_frame): Remove EXFUN.
10209 (replace_buffer_in_all_windows): Remove prototype.
10210 (replace_buffer_in_windows_safely): Add prototype.
10211
10212 * window.c: Declare Qdelete_window static again. Move down
10213 declaration of select_count.
10214 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10215 (Fother_window): Move to window.el.
10216 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10217 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10218 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10219 window.el.
10220 (replace_buffer_in_windows): Implement by calling
10221 Qreplace_buffer_in_windows.
10222 (replace_buffer_in_all_windows): Remove with some functionality
10223 moved into replace_buffer_in_windows_safely.
10224 (replace_buffer_in_windows_safely): New function.
10225 (select_window_norecord, select_frame_norecord): Move in front
10226 of run_window_configuration_change_hook. Remove now obsolete
10227 declarations.
640c8776
SM
10228 (Fset_window_buffer): Rewrite doc-string.
10229 Call Qrecord_window_buffer.
9397e56f
MR
10230 (keys_of_window): Move binding for other-window to window.el.
10231
b50691aa
CY
102322011-06-11 Chong Yidong <cyd@stupidchicken.com>
10233
10234 * dispextern.h (struct image): Replace data member, whose int_val
10235 and ptr_val fields were not used by anything, with a single
10236 lisp_val object.
10237
10238 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10239 (gif_clear_image, gif_load, imagemagick_load_image)
10240 (gs_clear_image, gs_load): Callers changed.
10241
3f754b86
PE
102422011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10243
cca69397
PE
10244 * buffer.h: Include <time.h>, for time_t.
10245 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10246
109e28d0
PE
10247 Fix minor problems found by static checking.
10248
60737f02
PE
10249 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10250
4b66faf3
PE
10251 Make identifiers static if they are not used in other modules.
10252 * data.c (Qcompiled_function, Qframe, Qvector):
10253 * image.c (QimageMagick, Qsvg):
10254 * minibuf.c (Qmetadata):
10255 * window.c (resize_window_check, resize_root_window): Now static.
10256 * window.h (resize_window_check, resize_root_window): Remove decls.
10257
109e28d0
PE
10258 * window.c (window_deletion_count, delete_deletable_window):
10259 Remove; unused.
46a4ce9e
PE
10260 (window_body_lines): Now static.
10261 (Fdelete_other_windows_internal): Mark vars as initialized.
10262 Make sure 'resize_failed' is initialized.
10263 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10264 (resize_window_apply): Remove unused local.
10265 * window.h (delete_deletable_window): Remove decl.
10266
109e28d0 10267 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10268 (imagemagick_load_image): Fix pointer signedness problem by changing
10269 last arg from unsigned char * to char *. All uses changed.
10270 Also, fix a local for similar reasons.
10271 Remove unused locals. Remove locals to avoid shadowing.
10272 (fn_rsvg_handle_free): Remove; unused.
10273 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10274 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10275
3f754b86
PE
10276 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10277
2547adb1
CY
102782011-06-10 Chong Yidong <cyd@stupidchicken.com>
10279
10280 * image.c (gif_load): Fix omitted cast error introduced by
10281 2011-06-06 change.
10282
2c8e37d4
MR
102832011-06-10 Martin Rudalics <rudalics@gmx.at>
10284
10285 * window.h (resize_proportionally, orig_total_lines)
10286 (orig_top_line): Remove from window structure.
10287 (set_window_height, set_window_width, change_window_heights)
10288 (Fdelete_window): Remove prototypes.
10289 (resize_frame_windows): Remove duplicate declaration.
10290
440a42e3
EZ
102912011-06-10 Eli Zaretskii <eliz@gnu.org>
10292
10293 * window.h (resize_frame_windows, resize_window_check)
10294 (delete_deletable_window, resize_root_window)
10295 (resize_frame_windows): Declare prototypes.
10296
10297 * window.c (resize_window_apply): Make definition be "static" to
10298 match the prototype.
10299
562dd5e9
MR
103002011-06-10 Martin Rudalics <rudalics@gmx.at>
10301
10302 * window.c: Remove declarations of Qwindow_size_fixed,
10303 window_min_size_1, window_min_size_2, window_min_size,
10304 size_window, window_fixed_size_p, enlarge_window, delete_window.
10305 Remove static from declaration of Qdelete_window, it's
10306 temporarily needed by Fbury_buffer.
10307 (replace_window): Don't assign orig_top_line and
10308 orig_total_lines.
10309 (Fdelete_window, delete_window): Remove. Window deletion is
10310 handled by window.el.
640c8776
SM
10311 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10312 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10313 (Fdelete_other_windows): Remove. Deleting other windows is
10314 handled by window.el.
10315 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10316 handled in window.el.
10317 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10318 Window minimum sizes are handled in window.el.
10319 (shrink_windows, size_window, set_window_height)
10320 (set_window_width, change_window_heights, window_height)
10321 (window_width, CURBEG, CURSIZE, enlarge_window)
10322 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10323 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10324 handled in window.el.
10325 (make_dummy_parent): Rename to make_parent_window and give it a
10326 second argument horflag.
10327 (make_window): Don't set resize_proportionally any more.
10328 (Fsplit_window): Remove. Windows are split in window.el.
10329 (save_restore_action, save_restore_orig_size)
10330 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10331 Resize mini windows in window.el.
10332 (grow_mini_window, shrink_mini_window): Implement by calling
10333 Qresize_root_window_vertically, resize_window_check and
10334 resize_window_apply.
640c8776
SM
10335 (saved_window, Fset_window_configuration, save_window_save):
10336 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10337 resize_proportionally.
10338 (window_min_height, window_min_width): Move to window.el.
10339 (keys_of_window): Move bindings for delete-other-windows,
10340 split-window, delete-window and enlarge-window to window.el.
10341
10342 * buffer.c: Temporarily extern Qdelete_window.
10343 (Fbury_buffer): Temporarily call Qdelete_window instead of
10344 Fdelete_window (Fbury_buffer will move to window.el soon).
10345
10346 * frame.c (set_menu_bar_lines_1): Remove code handling
10347 orig_top_line and orig_total_lines.
10348
10349 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10350 set_window_height but set heights directly.
10351 (change_frame_size_1): Use resize_frame_windows.
10352
10353 * xdisp.c (init_xdisp): Don't use set_window_height but set
10354 heights directly.
10355
640c8776
SM
10356 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10357 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10358 run_window_configuration_change_hook.
10359
10360 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10361 instead of change_window_heights and run
10362 run_window_configuration_change_hook.
10363
1a13852e
MR
103642011-06-09 Martin Rudalics <rudalics@gmx.at>
10365
10366 * window.c (replace_window): Rename second argument REPLACEMENT to
10367 NEW. New third argument SETFLAG. Rewrite.
10368 (delete_window, make_dummy_parent): Call replace_window with
10369 third argument 1.
10370 (window_list_1): Move down in code.
10371 (run_window_configuration_change_hook): Move set_buffer part
10372 before select_frame_norecord part in order to unwind correctly.
10373 Rename count1 to count.
10374 (recombine_windows, delete_deletable_window, resize_root_window)
10375 (Fdelete_other_windows_internal)
10376 (Frun_window_configuration_change_hook, make_parent_window)
10377 (resize_window_check, resize_window_apply, Fresize_window_apply)
10378 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10379 (Fdelete_window_internal, Fresize_mini_window_internal):
10380 New functions.
1a13852e
MR
10381 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10382
f3d1777e
MR
103832011-06-08 Martin Rudalics <rudalics@gmx.at>
10384
496e208e
MR
10385 * window.h (window): Add some new members to window structure -
10386 normal_lines, normal_cols, new_total, new_normal, clone_number,
10387 splits, nest, prev_buffers, next_buffers.
10388 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10389 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10390
f3d1777e
MR
10391 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10392 Remove.
496e208e
MR
10393 (make_dummy_parent): Set new members of windows structure.
10394 (make_window): Move down in code. Handle new members of window
10395 structure.
10396 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10397 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10398 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10399 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10400 (Fset_window_next_buffers, Fset_window_clone_number):
10401 New functions.
496e208e
MR
10402 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10403 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10404 Doc-string fixes.
10405 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10406 Argument WINDOW can be now internal window too.
10407 (Fwindow_use_time): Move up in code.
10408 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10409 Rewrite doc-string.
10410 (Fset_window_configuration, saved_window)
10411 (Fcurrent_window_configuration, save_window_save): Handle new
10412 members of window structure.
b9e809c2
MR
10413 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10414 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10415 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10416 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10417 Qget_mru_window, Qresize_root_window,
10418 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10419 Qauto_buffer_name; staticpro them.
f3d1777e 10420
abde8f8c
MR
104212011-06-07 Martin Rudalics <rudalics@gmx.at>
10422
10423 * window.c (Fwindow_total_size, Fwindow_left_column)
10424 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10425 (Fwindow_list_1): New functions.
10426 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10427 (Fwindow_width, Fscroll_left, Fscroll_right):
10428 Use window_body_cols instead of window_box_text_cols.
10429 (delete_window, Fset_window_configuration):
10430 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10431 (delete_all_subwindows): Take a window as argument and not a
10432 structure. Rewrite.
190b47e6
MR
10433 (window_loop): Remove handling of GET_LRU_WINDOW and
10434 GET_LARGEST_WINDOW.
10435 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10436
10437 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10438 window_box_text_cols. delete_all_subwindows now takes a
10439 Lisp_Object as argument.
abde8f8c 10440
640c8776
SM
10441 * indent.c (compute_motion, Fcompute_motion):
10442 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10443
fa8a67e6
MR
10444 * frame.c (delete_frame): Call delete_all_subwindows with root
10445 window as argument.
10446
a54e3482
DC
104472011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10448
10449 * fns.c (Fputhash): Document return value.
10450
60002bf5
CY
104512011-06-06 Chong Yidong <cyd@stupidchicken.com>
10452
10453 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10454
0c671da6 104552011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10456
b862a52a 10457 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10458
be44ca6c
PE
10459 Check for overflow when converting integer to cons and back.
10460 * charset.c (Fdefine_charset_internal, Fdecode_char):
10461 Use cons_to_unsigned to catch overflow.
10462 (Fencode_char): Use INTEGER_TO_CONS.
10463 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10464 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10465 * data.c (long_to_cons, cons_to_long): Remove.
10466 (cons_to_unsigned, cons_to_signed): New functions.
10467 These signal an error for invalid or out-of-range values.
10468 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10469 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10470 * font.c (Ffont_variation_glyphs):
10471 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10472 * lisp.h: Include <intprops.h>.
10473 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10474 (cons_to_signed, cons_to_unsigned): New decls.
10475 (long_to_cons, cons_to_long): Remove decls.
10476 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10477 (Fprimitive_undo): Use CONS_TO_INTEGER.
10478 * xfns.c (Fx_window_property): Likewise.
10479 * xselect.c: Include <limits.h>.
10480 (x_own_selection, selection_data_to_lisp_data):
10481 Use INTEGER_TO_CONS.
10482 (x_handle_selection_request, x_handle_selection_clear)
10483 (x_get_foreign_selection, Fx_disown_selection_internal)
10484 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10485 (lisp_data_to_selection_data): Use cons_to_unsigned.
10486 (x_fill_property_data): Use cons_to_signed.
10487 Report values out of range.
10488
d1f3d2af
PE
10489 Check for buffer and string overflow more precisely.
10490 * buffer.h (BUF_BYTES_MAX): New macro.
10491 * lisp.h (STRING_BYTES_MAX): New macro.
10492 * alloc.c (Fmake_string):
10493 * character.c (string_escape_byte8):
10494 * coding.c (coding_alloc_by_realloc):
10495 * doprnt.c (doprnt):
10496 * editfns.c (Fformat):
10497 * eval.c (verror):
10498 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10499 since they may not be the same number.
10500 * editfns.c (Finsert_char):
10501 * fileio.c (Finsert_file_contents):
10502 Likewise for BUF_BYTES_MAX.
10503
dd52fcea
PE
10504 * image.c: Use ptrdiff_t, not int, for sizes.
10505 (slurp_file): Switch from int to ptrdiff_t.
10506 All uses changed.
10507 (slurp_file): Check that file size fits in both size_t (for
10508 malloc) and ptrdiff_t (for sanity and safety).
10509
7f9bbdbb
PE
10510 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10511 if b->modtime has its maximal value.
10512
dfe18f82
PE
10513 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10514
84acfcf0
PE
10515 Don't assume time_t can fit into int.
10516 * buffer.h (struct buffer.modtime): Now time_t, not int.
10517 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10518 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10519
ccd9a01a
PE
10520 Minor fixes for signed vs unsigned integers.
10521 * character.h (MAYBE_UNIFY_CHAR):
10522 * charset.c (maybe_unify_char):
10523 * keyboard.c (read_char, reorder_modifiers):
10524 XINT -> XFASTINT, since the integer must be nonnegative.
10525 * ftfont.c (ftfont_spec_pattern):
10526 * keymap.c (access_keymap, silly_event_symbol_error):
10527 XUINT -> XFASTINT, since the integer must be nonnegative.
10528 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10529 since it makes no difference and we prefer signed.
10530 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10531 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10532 nonnegative.
10533
d6d100dd
SM
105342011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10535
10536 * window.h (Fwindow_frame): Declare.
10537
2b6148e4
PE
105382011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10539
10540 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10541 (SPARE_MEMORY): Always define.
10542 (LARGE_REQUEST): Remove.
10543 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10544
f230ecc9
MR
105452011-06-06 Martin Rudalics <rudalics@gmx.at>
10546
727e958e
MR
10547 * lisp.h: Move EXFUNS for Fframe_root_window,
10548 Fframe_first_window and Fset_frame_selected_window to window.h.
10549
10550 * window.h: Move EXFUNS for Fframe_root_window,
10551 Fframe_first_window and Fset_frame_selected_window here from
10552 lisp.h.
10553
10554 * frame.c (Fwindow_frame, Fframe_first_window)
10555 (Fframe_root_window, Fframe_selected_window)
10556 (Fset_frame_selected_window): Move to window.c.
10557 (Factive_minibuffer_window): Move to minibuf.c.
10558 (Fother_visible_frames_p): New function.
10559
10560 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10561
f230ecc9
MR
10562 * window.c (decode_window, decode_any_window): Move up in code.
10563 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10564 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10565 (Fwindow_buffer): Move up and rewrite doc-string.
10566 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10567 (Fwindow_prev): New functions.
727e958e
MR
10568 (Fwindow_frame): Move here from frame.c. Accept any window as
10569 argument.
10570 (Fframe_root_window, Fframe_first_window)
10571 (Fframe_selected_window): Move here from frame.c. Accept frame
10572 or arbitrary window as argument. Update doc-strings.
10573 (Fminibuffer_window): Move up in code.
10574 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10575 (Fset_frame_selected_window): Move here from frame.c.
10576 Marginal rewrite.
727e958e
MR
10577 (Fselected_window, select_window, Fselect_window): Move up in
10578 code. Minor doc-string fixes.
f230ecc9 10579
4d09bcf6
PE
105802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10581
10582 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10583 Do not assume that spare memory exists; that assumption is valid
10584 only if SYSTEM_MALLOC.
10585 (LARGE_REQUEST): New macro, so that the issue of large requests
10586 is separated from the issue of spare memory.
10587
810928a2
AS
105882011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10589
172418ad
AS
10590 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10591 format. (Bug#8806)
10592
43f862f7
AS
10593 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10594
810928a2
AS
10595 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10596 before statements.
10597
a059fe24
JD
105982011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10599
10600 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10601
10602 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10603
10604 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10605 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10606
989bf368
JB
106072011-06-05 Juanma Barranquero <lekktu@gmail.com>
10608
10609 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10610
4b80f674
CY
106112011-06-04 Chong Yidong <cyd@stupidchicken.com>
10612
10613 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10614 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10615 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10616 New error handlers.
4b80f674
CY
10617 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10618 Obey Vx_select_enable_clipboard_manager. Catch errors in
10619 x_clipboard_manager_save (Bug#8779).
10620 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10621 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10622
99a33b77 106232011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10624
10625 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10626
99a33b77 106272011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10628
10629 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10630 in the current matrix if keep_current_p is non-zero.
10631
8264569d
EZ
106322011-06-04 Eli Zaretskii <eliz@gnu.org>
10633
10634 * bidi.c (bidi_level_of_next_char): Fix last change.
10635
57f97249
EZ
106362011-06-03 Eli Zaretskii <eliz@gnu.org>
10637
fec2107c 10638 Support bidi reordering of text covered by display properties.
57f97249 10639
fec2107c
EZ
10640 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10641 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10642 (bidi_cache_search, bidi_cache_iterator_state)
10643 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10644 (bidi_level_of_next_char, bidi_move_to_visually_next):
10645 Support character positions inside a run of characters covered by a
fec2107c
EZ
10646 display string.
10647 (bidi_paragraph_init, bidi_resolve_explicit_1)
10648 (bidi_level_of_next_char): Call bidi_fetch_char and
10649 bidi_fetch_char_advance instead of FETCH_CHAR and
10650 FETCH_CHAR_ADVANCE.
10651 (bidi_init_it): Initialize new members.
10652 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10653 definitions.
10654 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10655 instead of using explicit *_CHAR codes.
d6d100dd
SM
10656 (bidi_resolve_explicit, bidi_resolve_weak):
10657 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10658 bidirectional text is supported only in multibyte buffers.
10659 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10660 it to initialize the frame_window_p member of struct bidi_it.
10661 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10662 (bidi_resolve_explicit, bidi_resolve_weak)
10663 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10664 bidi_it->nchars is non-positive.
10665 (bidi_level_of_next_char): Don't try to lookup the cache for the
10666 next/previous character if nothing is cached there yet, or if we
10667 were just reseat()'ed to a new position.
c40e2fb2 10668
0e14fe90
EZ
10669 * xdisp.c (set_cursor_from_row): Set start and stop points
10670 according to the row's direction when priming the loop that looks
10671 for the glyph on which to display cursor.
10672 (single_display_spec_intangible_p): Function deleted.
10673 (display_prop_intangible_p): Reimplement to call
10674 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10675 Accept 3 additional arguments needed by handle_display_spec.
10676 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10677 values: lists, `(when COND...)' forms, etc.
10678 (single_display_spec_string_p): Support property values that are
10679 lists with the argument STRING its top-level element.
10680 (display_prop_string_p): Fix the condition for processing a
10681 property that is a list to be consistent with handle_display_spec.
fec2107c 10682 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10683 last portion of handle_display_prop.
10684 (compute_display_string_pos): Accept additional argument
10685 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10686 value of a `display' property is a "replacing spec".
10687 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10688 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10689 the display property, but just return a value indicating whether
10690 the display property will replace the characters it covers.
10691 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10692 frame_window_p members of struct bidi_it.
d6d100dd
SM
10693 (compute_display_string_pos, compute_display_string_end):
10694 New functions.
fec2107c
EZ
10695 (push_it): Accept second argument POSITION, where pop_it should
10696 jump to continue iteration.
10697 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10698
fec2107c
EZ
10699 * keyboard.c (adjust_point_for_property): Adjust the call to
10700 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10701
10702 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10703 (bidi_init_it): Update prototypes.
10704 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10705 (compute_display_string_pos, compute_display_string_end):
10706 Declare prototypes.
fec2107c
EZ
10707 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10708 EMACS_INT.
fc6f18ce 10709
40087514 107102011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10711
57f53182
PE
10712 Malloc failure behavior now depends on size of allocation.
10713 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10714 * lisp.h: Change signatures accordingly.
10715 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10716 All callers changed. (Bug#8762)
10717
10718 * gnutls.c: Use Emacs's memory allocators.
10719 Without this change, the gnutls library would invoke malloc etc.
10720 directly, which causes problems on non-SYNC_INPUT hosts, and which
10721 runs afoul of improving memory_full behavior. (Bug#8761)
10722 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10723 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10724 xfree instead of the default malloc, realloc, free.
10725 (Fgnutls_boot): No need to check for memory allocation failure,
10726 since xmalloc does that for us.
10727
ac32cd99 10728 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10729 * category.c (hash_get_category_set):
10730 * ccl.c (ccl_driver):
10731 * charset.c (Fdefine_charset_internal):
10732 * charset.h (struct charset.hash_index):
10733 * composite.c (get_composition_id, gstring_lookup_cache)
10734 (composition_gstring_put_cache):
10735 * composite.h (struct composition.hash_index):
10736 * dispextern.h (struct image.hash):
10737 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10738 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10739 (hashfn_equal, hashfn_user_defined, make_hash_table)
10740 (maybe_resize_hash_table, hash_lookup, hash_put)
10741 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10742 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10743 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10744 * image.c (make_image, search_image_cache, lookup_image)
10745 (xpm_put_color_table_h):
10746 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10747 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10748 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10749 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10750 * alloc.c (allocate_vectorlike):
10751 Check for overflow in vector size calculations.
10752 * ccl.c (ccl_driver):
10753 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10754 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10755 need to be updated by these changes.
40087514
PE
10756 * fns.c (make_hash_table, maybe_resize_hash_table):
10757 Check for integer overflow with large hash tables.
0de4bb68
PE
10758 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10759 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10760 (SXHASH_REDUCE): New macro.
10761 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10762 Use it instead of discarding useful hash info with large hash values.
10763 (sxhash_float): New function.
10764 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10765 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10766 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10767 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10768 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10769 Adjust signatures to match updated version of code.
10770 (consing_since_gc): Now EMACS_INT, since a single hash table can
10771 use more than INT_MAX bytes.
10772
698d32e2
DN
107732011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10774
10775 Make it possible to build with GCC-4.6+ -O2 -flto.
10776
10777 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10778
fd6fa53f
SM
107792011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10780
10781 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10782 Call minibuffer-inactive-mode.
10783
864db017
JB
107842011-05-31 Juanma Barranquero <lekktu@gmail.com>
10785
10786 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10787 Update dependencies.
10788
2ad0baf4
DN
107892011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10790
10791 * data.c (init_data): Remove code for UTS, this system is not
10792 supported anymore.
10793
4fcc2638
DN
107942011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10795
10796 Don't force ./temacs to start in terminal mode.
10797
10798 * frame.c (make_initial_frame): Initialize faces in all cases, not
10799 only when CANNOT_DUMP is defined.
10800 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10801
c56e0fd5
DN
108022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10803
10804 * dispnew.c (add_window_display_history): Use const for the string
10805 pointer. Remove declaration, not needed.
10806
333d54da 108072011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10808
55d4c1b2 10809 Use 'inline', not 'INLINE'.
333d54da 10810 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10811 * alloc.c, fontset.c (INLINE): Remove.
10812 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10813 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10814 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10815 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10816 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10817
738db178
DN
108182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10819
10820 Make it possible to run ./temacs.
10821
10822 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10823 syms_of_callproc does the same thing. Remove test for
10824 "initialized", do it in the caller.
10825 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10826
620c53a6
SM
108272011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10828
10829 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10830 (read_minibuf): Use get_minibuffer.
10831 (syms_of_minibuf): Use DEFSYM.
10832 (Qmetadata): New var.
10833 * data.c (Qbuffer): Don't make it static.
10834 (syms_of_data): Use DEFSYM.
10835
e003a292
PE
108362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10837
10838 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10839 (CCL_CODE_MIN): New macro.
10840
ed008a6d
PE
108412011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10842
3687c2ef
PE
10843 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10844
ed008a6d
PE
10845 * eval.c (Qdebug): Now static.
10846 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10847 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10848 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10849
d66c4c7c
CY
108502011-05-29 Chong Yidong <cyd@stupidchicken.com>
10851
10852 * image.c: Various fixes to ImageMagick code comments.
10853 (Fimagemagick_types): Doc fix.
10854
5fbc2025
PE
108552011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10856
0196f88a
PE
10857 Minor fixes prompted by GCC 4.6.0 warnings.
10858
10859 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10860
5fbc2025
PE
10861 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10862 (x_clipboard_manager_save_all): Move extern decl to ...
10863 * xterm.h: ... here, so that it can be checked for consistency.
10864
1dd3c2d9
CY
108652011-05-29 Chong Yidong <cyd@stupidchicken.com>
10866
10867 * xselect.c (x_clipboard_manager_save_frame)
10868 (x_clipboard_manager_save_all): New functions.
10869 (Fx_clipboard_manager_save): Lisp function deleted.
10870
10871 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10872 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10873
10874 * xterm.h: Update prototype.
10875
5ba6571d
WX
108762011-05-28 William Xu <william.xwl@gmail.com>
10877
10878 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10879 exiting (Bug#8239).
10880
3eaff834
JM
108812011-05-28 Jim Meyering <meyering@redhat.com>
10882
e1900994 10883 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10884 * fns.c (to_uchar): Define.
10885 (crypto_hash_function): Use it to convert some newly-signed
10886 variables to unsigned, to avoid sign-extension bugs. For example,
10887 without this change, (md5 "truc") would evaluate to
10888 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10889 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10890 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10891
0f6990a7
PE
108922011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10893
10894 Integer overflow fixes.
c8a9ca5a 10895
08686060
PE
10896 * dbusbind.c: Serial number integer overflow fixes.
10897 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10898 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10899 to hold a serial number that is too large for a fixnum.
10900 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10901 Check for serial numbers out of range. Decode any serial number
59568bf0 10902 that was so large that it became a float. (Bug#8722)
08686060 10903
2d1fc3c7
PE
10904 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10905 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10906 Use XFASTINT rather than XUINT when numbers are nonnegative.
10907 (xd_append_arg, Fdbus_method_return_internal):
10908 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10909 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10910 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10911 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10912 (Bug#8722)
2d1fc3c7 10913
c8a9ca5a
PE
10914 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10915
519e1d69
PE
10916 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10917
6df6ae42 10918 ccl: Add integer overflow checks.
30569699
PE
10919 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10920 (IN_INT_RANGE): New macros.
10921 (ccl_driver): Use them to check for integer overflow when
10922 decoding a CCL program. Many of the new checks are whether XINT (x)
10923 fits in int; it doesn't always, on 64-bit hosts. The new version
10924 doesn't catch all possible integer overflows, but it's an
847044ea 10925 improvement. (Bug#8719)
30569699 10926
c11285dc
PE
10927 * alloc.c (make_event_array): Use XINT, not XUINT.
10928 There's no need for unsigned here.
10929
fdccd48e
PE
10930 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10931 This follows up to the 2011-05-06 change that substituted uintptr_t
10932 for EMACS_INT. This case wasn't caught back then.
10933
37910ab2
PE
10934 Rework Fformat to avoid integer overflow issues.
10935 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10936 now (part of C89). Include <verify.h>.
10937 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10938 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10939 (Fformat): Avoid the prepass trying to compute sizes; it was only
10940 approximate and thus did not catch overflow reliably. Instead, walk
10941 through the format just once, formatting and computing sizes as we go,
10942 checking for integer overflow at every step, and allocating a larger
10943 buffer as needed. Keep track separately whether the format is
10944 multibyte. Keep only the most-recently calculated precision, rather
10945 than them all. Record whether each argument has been converted to
10946 string. Use EMACS_INT, not int, for byte and char and arg counts.
10947 Support field widths and precisions larger than INT_MAX. Avoid
10948 sprintf's undefined behavior with conversion specifications such as %#d
10949 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10950 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10951 formatting out-of-range floating point numbers with int
9173deec 10952 formats. (Bug#8668)
37910ab2 10953
2e6578fb
PE
10954 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10955
0ae6bdee
PE
10956 * data.c: Avoid integer truncation in expressions involving floats.
10957 * data.c: Include <intprops.h>.
10958 (arith_driver): When there's an integer overflow in an expression
10959 involving floating point, convert the integers to floating point
10960 so that the resulting value does not suffer from catastrophic
10961 integer truncation. For example, on a 64-bit host (* 4
10962 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10963 Do not rely on undefined behavior after integer overflow.
10964
de883a70
PE
10965 merge count_size_as_multibyte, parse_str_to_multibyte
10966 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10967 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10968 Check for integer overflow.
10969 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10970 since it's now a duplicate of the other. This is more of
10971 a character than a buffer op, so better that it's in character.c.
10972 * fns.c, print.c: Adjust to above changes.
10973
2ff916cb
PE
109742011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10975
10976 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10977
f1b54466
PE
109782011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10979
fb1ac845
PE
10980 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10981 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10982 (x_clipboard_manager_save): Now static.
10983 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10984
f1b54466
PE
10985 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10986 (crypto_hash_function): Now static.
10987 Fix pointer signedness problems. Avoid unnecessary initializations.
10988
a9f737ee
CY
109892011-05-27 Chong Yidong <cyd@stupidchicken.com>
10990
10991 * termhooks.h (Vselection_alist): Make it terminal-local.
10992
10993 * terminal.c (create_terminal): Initialize it.
10994
10995 * xselect.c: Support for clipboard managers.
10996 (Vselection_alist): Move to termhooks.h as terminal-local var.
10997 (LOCAL_SELECTION): New macro.
10998 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10999 (symbol_to_x_atom): Remove gratuitous arg.
11000 (x_handle_selection_request, lisp_data_to_selection_data)
11001 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11002 (x_own_selection, x_get_local_selection, x_convert_selection):
11003 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11004 (some_frame_on_display): Delete unused function.
11005 (Fx_own_selection_internal, Fx_get_selection_internal)
11006 (Fx_disown_selection_internal, Fx_selection_owner_p)
11007 (Fx_selection_exists_p): New optional frame arg.
11008 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11009 (x_handle_selection_clear): Don't treat other terminals with the
11010 same keyboard specially. Use the terminal-local Vselection_alist.
11011 (x_clear_frame_selections): Use Frun_hook_with_args.
11012
11013 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11014
11015 * xterm.h: Add support for those atoms.
11016
e067f0c1
CY
110172011-05-26 Chong Yidong <cyd@stupidchicken.com>
11018
11019 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11020 (converted_selections, conversion_fail_tag): New global variables.
11021 (x_selection_request_lisp_error): Free the above.
11022 (x_get_local_selection): Remove unnecessary code.
11023 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11024 of converted selections stored in converted_selections.
11025 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11026 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11027 (x_convert_selection): New function.
11028 (x_handle_selection_event): Simplify.
11029 (x_get_foreign_selection): Don't ignore incoming requests while
11030 waiting for an answer; this will fail when we implement
11031 SAVE_TARGETS, and seems unnecessary anyway.
11032 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11033 (Vx_sent_selection_functions): Doc fix.
11034
0f4aebc0
LL
110352011-05-26 Leo Liu <sdl.web@gmail.com>
11036
11037 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11038
e61124cd
YM
110392011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11040
11041 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11042
11043 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11044 for fringe update if it has periodic bitmap.
ac389d0c 11045 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11046 and fringe_bitmap_periodic_p.
11047
11048 * fringe.c (get_fringe_bitmap_data): New function.
11049 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11050 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11051 row. Mark glyph row for fringe update if periodicity changed.
11052
11053 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11054 for fringe update unless it has periodic bitmap.
11055
f16d9837
KH
110562011-05-25 Kenichi Handa <handa@m17n.org>
11057
11058 * xdisp.c (get_next_display_element): Set correct it->face_id for
11059 a static composition.
11060
e1b90ef6
LL
110612011-05-24 Leo Liu <sdl.web@gmail.com>
11062
11063 * deps.mk (fns.o):
11064 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11065
11066 * fns.c (crypto_hash_function, Fsha1): New function.
11067 (Fmd5): Use crypto_hash_function.
11068 (syms_of_fns): Add Ssha1.
11069
7400048f
PE
110702011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11071
11072 * gnutls.c: Remove unused macros.
11073 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11074 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11075 Remove macros that are defined and never used.
11076 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11077
abb71cf4
CY
110782011-05-22 Chong Yidong <cyd@stupidchicken.com>
11079
11080 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11081 (Fx_get_selection_internal): Minor cleanup.
11082 (Fx_own_selection_internal): Rename arguments for consistency with
11083 select.el.
11084
6307db39
PE
110852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11086
11087 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11088
f3d4e0a4
CY
110892011-05-22 Chong Yidong <cyd@stupidchicken.com>
11090
11091 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11092
4d8ade89
YM
110932011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11094
11095 * dispnew.c (scrolling_window): Don't exclude the case that the
11096 last enabled row in the desired matrix touches the bottom boundary.
11097
32078c8d
GM
110982011-05-21 Glenn Morris <rgm@gnu.org>
11099
11100 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11101 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11102 and add some more files.
32078c8d 11103
7285dc67
EZ
111042011-05-20 Eli Zaretskii <eliz@gnu.org>
11105
11106 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11107 report_file_error introduced by the change from 2011-05-07.
11108
89d1bd22
PE
111092011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11110
11111 * systime.h (Time): Define only if emacs is defined.
11112 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11113 where the include path doesn't have X11/X.h by default. See
11114 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11115
cd394be1 111162011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11117
11118 * composite.c (find_automatic_composition): Fix previous change.
11119
b9704ad9
GM
111202011-05-20 Glenn Morris <rgm@gnu.org>
11121
11122 * lisp.mk: New file, split from Makefile.in.
11123 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11124 (shortlisp): Remove.
11125 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11126
4a720484
GM
111272011-05-19 Glenn Morris <rgm@gnu.org>
11128
11129 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11130 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11131 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11132 (lisp): Set the order to that of loadup.el.
11133 (shortlisp): Make it a copy of $lisp.
11134 (SOME_MACHINE_LISP): Remove.
11135 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11136 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11137
a28d4396
KH
111382011-05-18 Kenichi Handa <handa@m17n.org>
11139
11140 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11141 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11142 (find_automatic_composition): Mostly rewrite for efficiency.
11143
a2b1fa8e
JB
111442011-05-18 Juanma Barranquero <lekktu@gmail.com>
11145
11146 * makefile.w32-in: Update dependencies.
11147
8e1f5610
CS
111482011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11149
11150 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11151 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11152
7025ee00 111532011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11154
cdfa6eab
PE
11155 Fix some integer overflow issues, such as string length overflow.
11156
06d6db33
PE
11157 * insdel.c (count_size_as_multibyte): Check for string overflow.
11158
2b4560a8
PE
11159 * character.c (lisp_string_width): Check for string overflow.
11160 Use EMACS_INT, not int, for string indexes and lengths; in
11161 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11162 the resulting string length overflows an EMACS_INT; instead,
11163 report a string overflow if no precision given. When checking for
11164 precision exhaustion, use a check that cannot possibly have
11165 integer overflow. (Bug#8675)
11166 * character.h (lisp_string_width): Adjust to new signature.
11167
cb93f9be
PE
11168 * alloc.c (string_overflow): New function.
11169 (Fmake_string): Use it. This doesn't change behavior, but saves
11170 a few bytes and will simplify future changes.
11171 * character.c (string_escape_byte8): Likewise.
11172 * lisp.h (string_overflow): New decl.
11173
1a1f3366
PE
11174 Fixups, following up to the user-interface timestamp change.
11175 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11176 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11177 * msdos.c (mouse_get_pos): Likewise.
11178 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11179 * w32gui.h (Time): Define by including "systime.h" rather than by
11180 declaring it ourselves. (Bug#8664)
11181
d4e3e4d3
PE
11182 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11183 * image.c (clear_image_cache): Likewise.
11184
f6a24d19
PE
11185 * term.c (term_mouse_position): Don't assume time_t wraparound.
11186
08dc5ae6
PE
11187 Be more systematic about user-interface timestamps.
11188 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11189 and sometimes 'EMACS_UINT', to represent these timestamps.
11190 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11191 This makes the code easier to follow, and makes it easier to catch
11192 integer overflow bugs such as Bug#8664.
11193 * frame.c (Fmouse_position, Fmouse_pixel_position):
11194 Use Time, not unsigned long, for user-interface timestamps.
11195 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11196 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11197 * keyboard.h (last_event_timestamp): Likewise.
11198 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11199 * menu.h (xmenu_show): Likewise.
11200 * term.c (term_mouse_position): Likewise.
11201 * termhooks.h (struct input_event.timestamp): Likewise.
11202 (struct terminal.mouse_position_hook): Likewise.
11203 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11204 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11205 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11206 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11207 what it was before.
11208 * menu.h, termhooks.h: Include "systime.h", for Time.
11209
8e55734a
PE
11210 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11211 Don't assume that the difference between two unsigned long values
11212 can fit into an integer. At this point, we know button_down_time
11213 <= event->timestamp, so the difference must be nonnegative, so
11214 there's no need to cast the result if double-click-time is
11215 nonnegative, as it should be; check that it's nonnegative, just in
11216 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11217 apart (about 25 days). (Bug#8664)
8e55734a 11218
841f1b75 11219 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11220 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11221
3e26f69c
PE
11222 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11223 that always fit in int. Use a sentinel instead of a counter, to
11224 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11225 * frame.h (struct frame): Use int for menu_bar_items_used
11226 instead of EMACS_INT, since it always fits in int.
3e26f69c 11227
5cc152c0
PE
11228 * menu.c (grow_menu_items): Check for int overflow.
11229
d89eb65e
PE
11230 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11231
5235bd3e
PE
11232 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11233 Before, the code was not consistent. These values cannot exceed
11234 2**31 - 1 so there's no need to make them unsigned.
11235 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11236 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11237 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11238 as modifiers.
11239 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11240
bc827e23
PE
11241 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11242 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11243 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11244 presumably because the widths might not match.
11245
78eb494e
PE
11246 * window.c (size_window): Avoid needless test at loop start.
11247
04f2d78b
CB
112482011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11249
11250 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11251
d2fc7e3d 112522011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11253
11254 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11255
d2fc7e3d 112562011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11257
11258 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11259 `width' to `bar_area_x' and `bar_area_width', respectively.
11260 (x_scroll_run): Take account of fringe background extension.
11261
04f2d78b
CB
11262 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11263 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11264 `bar_area_width', respectively.
11265 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11266 background extension.
11267
79b70037
GM
112682011-05-10 Jim Meyering <meyering@redhat.com>
11269
11270 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11271
2f142cc5
JB
112722011-05-10 Juanma Barranquero <lekktu@gmail.com>
11273
11274 * image.c (Finit_image_library): Return t for built-in image types,
11275 like pbm and xbm. (Bug#8640)
11276
57679c86
AS
112772011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11278
11279 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11280
888c9e86
EZ
112812011-05-07 Eli Zaretskii <eliz@gnu.org>
11282
b0512a1d
EZ
11283 * w32console.c (Fset_screen_color): Doc fix.
11284 (Fget_screen_color): New function.
11285 (syms_of_ntterm): Defsubr it.
11286
7285dc67
EZ
11287 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11288 unlink the temporary file if Fcall_process didn't create it in the
11289 first place.
11290 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11291 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11292 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11293 cue to call_process_cleanup not to close that handle.
11294
4d3fcc8e
BK
112952011-05-07 Ben Key <bkey76@gmail.com>
11296
11297 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11298 one of two shell specific rules, either bootstrap-temacs-CMD or
11299 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11300 to the previous implementation of the bootstrap-temacs rule.
11301 The bootstrap-temacs-CMD rule is similar to the previous
11302 implementation of the bootstrap-temacs rule except that it
11303 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11304 variable.
11305
11306 These changes, along with some changes to nt/configure.bat,
11307 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11308 earlier fix to add support for --cflags and --ldflags options
11309 that include quotes so that it works whether make uses cmd or
11310 sh as the shell.
11311
b4289b64
MA
113122011-05-06 Michael Albinus <michael.albinus@gmx.de>
11313
11314 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11315 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11316 is a constant.
11317 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11318 a string. Handle both cases.
11319 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11320 (Fdbus_register_method): Use Qinvalid_function.
11321
af4c0e28
JB
113222011-05-06 Juanma Barranquero <lekktu@gmail.com>
11323
11324 * makefile.w32-in: Update dependencies.
11325 (LISP_H): Add inttypes.h and stdin.h.
11326 (PROCESS_H): Add unistd.h.
11327
c51453d9
EZ
113282011-05-06 Eli Zaretskii <eliz@gnu.org>
11329
11330 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11331 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11332
8ff0ac3c 113332011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11334
4c4b566b
PE
11335 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11336
aab2b9b5
PE
11337 * term.c (vfatal): Remove stray call to va_end.
11338 It's not needed and the C Standard doesn't allow it here anyway.
11339
c378da0b
PE
11340 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11341 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11342
288b08c7
PE
11343 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11344 bytes.
11345
e3601888
PE
11346 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11347
db6c0e74
PE
11348 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11349
dd5963ea
PE
11350 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11351
88c9450f
PE
11352 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11353
2f9442b8
PE
11354 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11355
c032b5f8
PE
11356 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11357 * charset.c (Fdefine_charset_internal): Don't initialize
11358 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11359 32-bit int (Bug#8600).
a108c10b
PE
11360
11361 * lread.c (read_integer): Be more consistent with string-to-number.
11362 Use string_to_number to do the actual conversion; this avoids
11363 rounding errors and fixes some other screwups. Without this fix,
11364 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11365 (digit_to_number): Move earlier, for benefit of read_integer.
11366 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11367 not a digit in any supported base. (Bug#8602)
a108c10b 11368
ad5f9eea
PE
11369 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11370
aec1708a
PE
11371 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11372 to match comment at start of function. This also removes a
11373 GCC warning about overflow in a 32+64-bit port.
11374
47be4ab5
PE
11375 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11376
371cac43
PE
11377 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11378 Reported by Stefan Monnier in
11379 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11380 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11381 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11382
d01a7826
PE
11383 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11384 (EMACS_UINTPTR): Likewise, with uintptr_t.
11385
7fd47d5c
PE
11386 * lisp.h: Prefer 64-bit EMACS_INT if available.
11387 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11388 on 32-bit hosts that have 64-bit int, so that they can access
11389 large files.
122b0c86
PE
11390 However, temporarily disable this change unless the temporary
11391 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11392
8727937b
PE
11393 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11394
8ac068ac
PE
11395 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11396 This removes an assumption that EMACS_INT and long are the same
11397 width as pointers. The assumption is true for Emacs porting targets
11398 now, but we want to make other targets possible.
11399 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11400 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11401 In the rest of the code, change types of integers that hold casted
11402 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11403 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11404 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11405 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11406 No need to cast type when ORing.
11407 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11408 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11409 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11410 assume EMACS_INT is the same width as char *.
11411 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11412 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11413 Remove no-longer-needed casts.
11414 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11415 (xg_tool_bar_help_callback, xg_make_tool_item):
11416 Use EMACS_INTPTR to hold an integer
11417 that will be cast to void *; this can avoid a GCC warning
11418 if EMACS_INT is not the same width as void *.
11419 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11420 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11421 (current_message_1, set_message_1):
11422 Use a local to convert to proper width without a cast.
11423 * xmenu.c (dialog_selection_callback): Likewise.
11424
ede49d71
PE
11425 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11426 Also, don't assume VALBITS / RAND_BITS is less than 5,
11427 and don't rely on undefined behavior when shifting a 1 left into
11428 the sign bit.
11429 * lisp.h (get_random): Change signature to match.
11430
2f30ecd0
PE
11431 * lread.c (hash_string): Use size_t, not int, for hash computation.
11432 Normally we prefer signed values; but hashing is special, because
11433 it's better to use unsigned division on hash table sizes so that
11434 the remainder is nonnegative. Also, size_t is the natural width
11435 for hashing into memory. The previous code used 'int', which doesn't
11436 retain enough info to hash well into very large tables.
11437 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11438
2a866e7b
PE
11439 * dbusbind.c: Don't possibly lose pointer info when converting.
11440 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11441 Use XPNTR rather than XHASH, so that the high-order bits of
11442 the pointer aren't lost when converting through void *.
11443
51639eac
PE
11444 * eval.c (Fautoload): Don't double-shift a pointer.
11445
92394119
PE
11446 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11447
dbdb9a7c
JB
114482011-05-06 Juanma Barranquero <lekktu@gmail.com>
11449
11450 * gnutls.c (DEF_GNUTLS_FN):
11451 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11452
db7a0b4f
AS
114532011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11454
11455 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11456 marker. (Bug#8610)
11457
cd394be1 114582011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11459
11460 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11461 New version that can reserve upto 2GB of heap space.
11462
f7ff1b0f 114632011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11464
11465 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11466
639c109b
TZ
114672011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11468
11469 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11470 `gnutls_certificate_set_x509_key_file'.
11471
d2127135
JB
114722011-05-05 Juanma Barranquero <lekktu@gmail.com>
11473
11474 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11475 Update dependencies.
11476
e968f4f3
JB
114772011-05-04 Juanma Barranquero <lekktu@gmail.com>
11478
11479 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11480 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11481 Remove unused parameter `fildes'.
11482 * process.c (read_process_output, send_process): Don't pass it.
11483
84d358f0
JB
114842011-05-04 Juanma Barranquero <lekktu@gmail.com>
11485
11486 Fix previous change: the library cache is defined in w32.c.
11487 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11488 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11489
0898ca10
JB
114902011-05-04 Juanma Barranquero <lekktu@gmail.com>
11491
11492 Implement dynamic loading of GnuTLS on Windows.
11493
11494 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11495 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11496 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11497 Declare.
11498
11499 * gnutls.c (Qgnutls_dll): Define.
11500 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11501 (gnutls_*): Declare function pointers.
11502 (init_gnutls_functions): New function to initialize function pointers.
11503 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11504 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11505 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11506 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11507 (emacs_gnutls_write, emacs_gnutls_read)
11508 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11509 (Fgnutls_available_p): New function.
11510 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11511 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11512 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11513
11514 * image.c: Include w32.h.
11515 (Vimage_type_cache): Delete.
11516 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11517 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11518 (w32_delayed_load): Move to w32.c.
11519
11520 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11521
11522 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11523 (w32_delayed_load): Move from image.c. When loading a library, record
11524 its filename in the :loaded-from property of the library id.
11525 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11526 Initialize and staticpro them.
11527 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11528
11529 * process.c: Include lisp.h before w32.h, not after.
11530 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11531 instead of gnutls_record_check_pending.
11532
11533 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11534
ff4de4aa
TZ
115352011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11536
11537 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11538 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11539 as passed in.
11540
abe95abb
JD
115412011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11542
11543 * xterm.c (x_set_frame_alpha): Do not set property on anything
11544 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11545
e16e55d4
JB
115462011-05-02 Juanma Barranquero <lekktu@gmail.com>
11547
11548 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11549
bafcf6a5
JB
115502011-05-02 Juanma Barranquero <lekktu@gmail.com>
11551
11552 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11553 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11554 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11555 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11556 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11557 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11558 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11559 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11560 (Qgnutls_bootprop_callbacks_verify): Make static.
11561
e7a6747f
AS
115622011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11563
19ed11ba
AS
11564 * callproc.c: Indentation fixup.
11565
e7a6747f 11566 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11567 (wait_for_termination, interruptible_wait_for_termination):
11568 Move after wait_for_termination_1.
e7a6747f 11569
1ef14cb4
LMI
115702011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11571
11572 * sysdep.c (interruptible_wait_for_termination): New function
11573 which is like wait_for_termination, but allows keyboard
11574 interruptions.
11575
11576 * callproc.c (Fcall_process): Add (:file "file") as an option for
11577 the STDOUT buffer.
11578 (Fcall_process_region): Ditto.
11579
330d880c
EZ
115802011-04-30 Eli Zaretskii <eliz@gnu.org>
11581
8db90b73
EZ
11582 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11583 rather than `XVECTOR (FOO)->size'.
11584
330d880c
EZ
11585 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11586 inttypes.h, as a gnulib replacement is used if it not available in
11587 system headers.
11588
15cbd324
EZ
115892011-04-21 Eli Zaretskii <eliz@gnu.org>
11590
11591 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11592 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11593 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11594
11595 * coding.c (coding_alloc_by_realloc): Error out if destination
11596 will grow beyond MOST_POSITIVE_FIXNUM.
11597 (decode_coding_emacs_mule): Abort if there isn't enough place in
11598 charbuf for the composition carryover bytes. Reserve an extra
11599 space for up to 2 characters produced in a loop.
11600 (decode_coding_iso_2022): Abort if there isn't enough place in
11601 charbuf for the composition carryover bytes.
11602
116032011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11604
ae940cca
EZ
11605 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11606 aborting when %lld or %lll format is passed.
11607 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11608 %llo or %llx format is passed. (Bug#8545)
11609
03ab8921
EZ
11610 * window.c (window_scroll_line_based): Use a marker instead of
11611 simple variables to record original value of point. (Bug#7952)
11612
afda1437
EZ
11613 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11614 produced by %s or %c overflows available buffer space. (Bug#8545)
11615
f76dee0c
PE
116162011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11617
11618 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11619 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11620
fdc5744d
JB
116212011-04-28 Juanma Barranquero <lekktu@gmail.com>
11622
11623 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11624
638f053a
JB
116252011-04-28 Juanma Barranquero <lekktu@gmail.com>
11626
11627 * keyboard.c (Qdelayed_warnings_hook): Define.
11628 (command_loop_1): Run `delayed-warnings-hook'
11629 if Vdelayed_warnings_list is non-nil.
11630 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11631 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11632
d178f871
EZ
116332011-04-28 Eli Zaretskii <eliz@gnu.org>
11634
11635 * doprnt.c (doprnt): Don't return value smaller than the buffer
11636 size if the message was truncated. (Bug#8545).
11637
b124fd93
JB
116382011-04-28 Juanma Barranquero <lekktu@gmail.com>
11639
11640 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11641 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11642
e810457d
PE
116432011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11644
11645 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11646
ea51cceb
JB
116472011-04-27 Juanma Barranquero <lekktu@gmail.com>
11648
11649 * makefile.w32-in: Update dependencies.
11650
94dcfacf
EZ
116512011-04-27 Eli Zaretskii <eliz@gnu.org>
11652
11653 Improve `doprnt' and its usage. (Bug#8545)
11654 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11655 `format_end'. Remove support for %l as a conversion specifier.
11656 Don't use xrealloc. Improve diagnostics when the %l size modifier
11657 is used. Update the commentary.
11658
11659 * eval.c (verror): Simplify calculation of size_t.
11660
11661 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11662 messages.
11663
f61f41d7
PE
116642011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11665
11666 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11667 change.
11668
96fb4434
PE
116692011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11670
11671 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11672 This makes this file independent of the recent pseudovector change.
11673
671875da 116742011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11675
69e9b5a3
PE
11676 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11677
b5f869a7 11678 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11679 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11680 Remove unused local.
c8926152 11681 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11682
841a1577 11683 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11684 GCC 4.6.0 optimizes based on type-based alias analysis.
11685 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11686 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11687 != &v->size, and therefore "v->size = 1; b->size = 2; return
11688 v->size;" must therefore return 1. This assumption is incorrect
11689 for Emacs, since it type-puns struct Lisp_Vector * with many other
11690 types. To fix this problem, this patch adds a new type struct
f904488f 11691 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11692 and pseudovectors, and helps optimizing compilers not get fooled
11693 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11694 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11695 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11696 the size member.
eab3844f
PE
11697 (XSETPVECTYPE): Rewrite in terms of new macro.
11698 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11699 This is a bit clearer, and further avoids the possibility of
11700 undesirable aliasing.
11701 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11702 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11703 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11704 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11705 (ASIZE): Now uses header.size rather than size.
11706 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11707 to avoid the hassle of writing XVECTOR (foo)->header.size.
11708 (struct vectorlike_header): New type.
eab3844f
PE
11709 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11710 object, to help avoid aliasing.
11711 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11712 (SUBRP): Likewise, since Lisp_Subr is a special case.
11713 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11714 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11715 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11716 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11717 changed to be "header.size" and "header.next".
11718 * buffer.h (struct buffer): Likewise.
11719 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11720 * frame.h (struct frame): Likewise.
11721 * process.h (struct Lisp_Process): Likewise.
11722 * termhooks.h (struct terminal): Likewise.
11723 * window.c (struct save_window_data, struct saved_window): Likewise.
11724 * window.h (struct window): Likewise.
11725 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11726 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11727 * buffer.c (init_buffer_once): Likewise.
11728 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11729 special case.
11730 * process.c (Fformat_network_address): Use local var for size,
11731 for brevity.
11732
0df1eac5
PE
11733 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11734
847ab9d1 11735 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11736 * data.c (atof): Remove decl; no longer used or needed.
11737 (digit_to_number): Move to lread.c.
11738 (Fstring_to_number): Use new string_to_number function, to be
11739 consistent with how the Lisp reader treats infinities and NaNs.
11740 Do not assume that floating-point numbers represent EMACS_INT
11741 without losing information; this is not true on most 64-bit hosts.
11742 Avoid double-rounding errors, by insisting on integers when
11743 parsing non-base-10 numbers, as the documentation specifies.
11744 * lisp.h (string_to_number): New decl, replacing ...
11745 (isfloat_string): Remove.
bc0a5c13 11746 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11747 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11748 appears to have been a coding error. Similarly, do not accept
11749 strings like +-1e0 as floating point numbers. Do not report
11750 overflow for integer overflows unless the base is not 10 which
11751 means we have no simple and reliable way to continue.
11752 Break out the floating-point parsing into a new
11753 function string_to_number, so that Fstring_to_number parses
11754 floating point numbers consistently with the Lisp reader.
04f2d78b 11755 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11756 (E_CHAR, EXP_INT): Remove, replacing with ...
11757 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11758 (string_to_number): New function, replacing isfloat_string.
11759 This function checks for valid syntax and produces the resulting
11760 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11761 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11762 so that overflow for non-base-10 numbers is reported only when
11763 there's no portable and simple way to convert to floating point.
452f4150 11764
67769ffc
PE
11765 * textprop.c (set_text_properties_1): Rewrite for clarity,
11766 and to avoid GCC warning about integer overflow.
11767
c20db43f
PE
11768 * intervals.h (struct interval): Use EMACS_INT for members
11769 where EMACS_UINT might cause problems. See
11770 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11771 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11772 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11773 All uses changed.
37aa2f85
PE
11774 (offset_intervals): Tell GCC not to worry about length overflow
11775 when negating a negative length.
c20db43f 11776
2538aa2f
PE
11777 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11778 (overrun_check_free): Likewise.
11779
f2d3008d
PE
11780 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11781 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11782 word size.
11783
ec8df744
PE
11784 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11785 (gnutls_make_error): Rename local to avoid shadowing.
11786 (gnutls_emacs_global_deinit): ifdef out; not used.
11787 (Fgnutls_boot): Use const for pointer to readonly storage.
11788 Comment out unused local. Fix pointer signedness problems.
11789
640ee02d
PE
11790 * lread.c (openp): Don't stuff size_t into an 'int'.
11791 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11792 about possible signed overflow.
11793
6048fb2a
PE
11794 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11795 (GDK_KEY_g): Don't define if already defined.
11796 (xg_prepare_tooltip): Avoid pointer signedness problem.
11797 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11798
fa3c87e1
PE
11799 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11800 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11801
2172544b
PE
11802 * xfns.c (Fx_window_property): Simplify a bit,
11803 to make a bit faster and to avoid GCC 4.6.0 warning.
11804 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11805
9b821a21
PE
11806 * fns.c (internal_equal): Don't assume size_t fits in int.
11807
3c616cfa
PE
11808 * alloc.c (compact_small_strings): Tighten assertion a little.
11809
c2982e87
PE
11810 Replace pEd with more-general pI, and fix some printf arg casts.
11811 * lisp.h (pI): New macro, generalizing old pEd macro to other
11812 conversion specifiers. For example, use "...%"pI"d..." rather
11813 than "...%"pEd"...".
11814 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11815 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11816 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11817 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11818 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11819 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11820 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11821 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11822 64-bit hosts.
11823 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11824 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11825 * print.c (safe_debug_print, print_object): Likewise.
11826 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11827 to int.
6f04d126
PE
11828 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11829 avoiding the 0 flag, which is not portable.
c2982e87
PE
11830 * process.c (Fmake_network_process): Use pI to avoid cast.
11831 * region-cache.c (pp_cache): Likewise.
11832 * xdisp.c (decode_mode_spec): Likewise.
11833 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11834 behavior on 64-bit hosts with printf arg.
6f04d126 11835 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11836 (x_stop_queuing_selection_requests): Likewise.
11837 (x_get_window_property): Don't truncate byte count to an 'int'
11838 when tracing.
0b432f21 11839
5e073ec7
PE
11840 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11841 here, since it parses constructs like leading '-' and spaces,
11842 which are not wanted; and it overflows with large numbers.
11843 Instead, simply match F[0-9]+, which is what is wanted anyway.
11844
36372bf9
PE
11845 * alloc.c: Remove unportable assumptions about struct layout.
11846 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11847 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11848 (allocate_vectorlike, make_pure_vector): Use the new macros,
11849 plus offsetof, to remove unportable assumptions about struct layout.
11850 These assumptions hold on all porting targets that I know of, but
11851 they are not guaranteed, they're easy to remove, and removing them
11852 makes further changes easier.
11853
0b432f21
PE
11854 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11855 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11856 (string_overrun_cookie): Now const. Use initializers that
11857 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11858 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11859 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11860 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11861 multiple of sizeof (EMACS_INT); it need not be, if
11862 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11863 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11864
895009e1
JB
118652011-04-26 Juanma Barranquero <lekktu@gmail.com>
11866
11867 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11868
6a7a1b0b
TZ
118692011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11870
11871 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11872 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11873 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11874
841a1577 118752011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11876
11877 * lisp.h (Qdebug): List symbol.
895009e1 11878 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11879 * keyboard.c (debug-on-event): New variable.
11880 (handle_user_signal): Break into debugger when debug-on-event
11881 matches the current signal symbol.
11882
f2d3ba6f
DN
118832011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11884
11885 * alloc.c (check_sblock, check_string_bytes)
11886 (check_string_free_list): Convert to standard C.
11887
42ce4c63
TZ
118882011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11889
11890 * w32.c (emacs_gnutls_push): Fix typo.
11891
825cd63c
EZ
118922011-04-25 Eli Zaretskii <eliz@gnu.org>
11893
fb11d64d
EZ
11894 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11895 "cast to pointer from integer of different size".
11896
825cd63c
EZ
11897 Improve doprnt and its use in verror. (Bug#8545)
11898 * doprnt.c (doprnt): Document the set of format control sequences
11899 supported by the function. Use SAFE_ALLOCA instead of always
11900 using `alloca'.
11901
11902 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11903 is one byte too soon. Don't use xrealloc; instead xfree and
11904 xmalloc anew.
11905
e061a11b
TZ
119062011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11907
11908 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11909 callbacks stage.
11910
11911 * gnutls.c: Renamed global_initialized to
11912 gnutls_global_initialized. Added internals for the
11913 :verify-hostname-error, :verify-error, and :verify-flags
11914 parameters of `gnutls-boot' and documented those parameters in the
11915 docstring. Start callback support.
9173deec
JB
11916 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11917 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11918 on error. Return error code.
e061a11b
TZ
11919 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11920 (emacs_gnutls_read): Likewise.
11921 (Fgnutls_boot): Return handshake error code.
11922 (emacs_gnutls_handle_error): New function.
11923 (wsaerror_to_errno): Likewise.
11924
11925 * w32.h (emacs_gnutls_pull): Add prototype.
11926 (emacs_gnutls_push): Likewise.
11927
11928 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11929 (emacs_gnutls_push): Likewise.
11930
119312011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11932
11933 * process.c (wait_reading_process_output): Check if GnuTLS
11934 buffered some data internally if no FDs are set for TLS
11935 connections.
11936
11937 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11938 (LIBS): Link to USER_LIBS.
11939 ($(BLD)/gnutls.$(0)): New target.
11940
fa6996bc
EZ
119412011-04-24 Eli Zaretskii <eliz@gnu.org>
11942
eb35682e
EZ
11943 * xdisp.c (handle_single_display_spec): Rename the
11944 display_replaced_before_p argument into display_replaced_p, to
11945 make it consistent with the commentary. Fix typos in the
11946 commentary.
11947
e2ad650c
EZ
11948 * textprop.c (syms_of_textprop): Remove dead code.
11949 (copy_text_properties): Delete obsolete commentary about an
11950 interface that was deleted long ago. Fix typos in the description
11951 of arguments.
11952
1b2de274
EZ
11953 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11954 to changes in oldXMenu/XMenu.h from 2011-04-16.
11955 <menu_help_message, prev_menu_help_message>: Constify.
11956 (IT_menu_make_room): menu->help_text is now `const char **';
11957 adjust.
11958
11959 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11960 to changes in oldXMenu/XMenu.h from 2011-04-16.
11961 (struct XMenu): Declare `help_text' `const char **'.
11962
11963 * xfaces.c <Qunspecified>: Make extern again.
11964
11965 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11966 required by POSIX.
1b2de274 11967
762b15be
EZ
11968 * doc.c (get_doc_string): Improve the format passed to `error'.
11969
11970 * doprnt.c (doprnt): Improve commentary.
11971
11972 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11973
11974 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11975 them with etags.
11976
f1052e5d
EZ
11977 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11978 changes in globals.h immediately force recompilation.
762b15be
EZ
11979 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11980 $(CURDIR)/s/ms-w32.h.
11981 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11982
fa6996bc
EZ
11983 * character.c (Fchar_direction): Function deleted.
11984 (syms_of_character): Don't defsubr it.
11985 <char-direction-table>: Deleted.
11986
e6c3da20
EZ
119872011-04-23 Eli Zaretskii <eliz@gnu.org>
11988
11989 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11990 * doprnt.c: Include limits.h.
11991 (SIZE_MAX): New macro.
04f2d78b
CB
11992 (doprnt): Return a size_t value. 2nd arg is now size_t.
11993 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11994 Improve overflow protection. Support `l' modifier for integer
11995 conversions. Support %l conversion. Don't assume an EMACS_INT
11996 argument for integer conversions and for %c.
11997
11998 * lisp.h (doprnt): Restore prototype.
11999
12000 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12001 $(SRC)/character.h.
12002
12003 * Makefile.in (base_obj): Add back doprnt.o.
12004
12005 * deps.mk (doprnt.o): Add back prerequisites.
12006 (callint.o): Depend on character.h.
12007
12008 * eval.c (internal_lisp_condition_case): Include the handler
12009 representation in the error message.
12010 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12011 when breaking from the loop.
12012
12013 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12014
12015 * callint.c (Fcall_interactively): When displaying error message
12016 about invalid control letter, pass the character's codepoint, not
12017 a pointer to its multibyte form. Improve display of the character
12018 in octal and display also its hex code.
12019
12020 * character.c (char_string): Use %x to display the (unsigned)
12021 codepoint of an invalid character, to avoid displaying a bogus
12022 negative value.
12023
12024 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12025 `error', not SYMBOL_NAME itself.
12026
12027 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12028 character arguments to `error'.
12029
12030 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12031 to `error' in error message about FINAL_CHAR argument. Make sure
12032 FINAL_CHAR is a character, and use %c when it is passed as
12033 argument to `error'.
12034
4ffd0d6b 120352011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12036
12037 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12038
12039 * w32.c: Include <time.h>.
12040 (sys_localtime): New function.
12041
4ffd0d6b 120422011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12043
12044 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12045
4ffd0d6b 12046 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12047
4ffd0d6b 120482011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12049
4ffd0d6b
GM
12050 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12051 zombies (Bug#8467).
aac0c6e3 12052
04c56954
EZ
120532011-04-19 Eli Zaretskii <eliz@gnu.org>
12054
12055 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12056 gl_state.e_property when gl_state.object is Qt.
12057
12058 * insdel.c (make_gap_larger): Remove limitation of buffer size
12059 to <= INT_MAX.
12060
16a43933
CY
120612011-04-18 Chong Yidong <cyd@stupidchicken.com>
12062
12063 * xdisp.c (lookup_glyphless_char_display)
12064 (produce_glyphless_glyph): Handle cons cell entry in
12065 glyphless-char-display.
12066 (Vglyphless_char_display): Document it.
12067
12068 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12069 glyphless-char-display.
12070
4581706e
CY
120712011-04-17 Chong Yidong <cyd@stupidchicken.com>
12072
12073 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12074
12075 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12076
12077 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12078 definition for no-X builds.
12079
4887c6e2 120802011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12081
fd35b6f9
PE
12082 Static checks with GCC 4.6.0 and non-default toolkits.
12083
5c1ccb01
PE
12084 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12085
006c5daa
PE
12086 * process.c (keyboard_bit_set): Define only if SIGIO.
12087 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12088 (send_process): Repair possible setjmp clobbering.
12089
efc736d3
PE
12090 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12091
4e2fe2e6
PE
12092 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12093
f97334a2
PE
12094 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12095
4e75f29d
PE
12096 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12097 Define only if needed.
12098
90efadd1
PE
12099 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12100 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12101 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12102
3c647824
PE
12103 * dispextern.h (struct redisplay_interface): Rename param
12104 to avoid shadowing.
e264f262 12105 * termhooks.h (struct terminal): Likewise.
761383f4 12106 * xterm.c (xembed_send_message): Likewise.
3c647824 12107
b58c5c4a
PE
12108 * insdel.c (make_gap_smaller): Define only if
12109 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12110
cad59032
PE
12111 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12112 it.
12113
c339dc2e
PE
12114 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12115 so that we aren't warned about unused symbols.
12116
91a3e27b
PE
12117 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12118
399c71d3 12119 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12120
8ffc96f5
PE
12121 * xfns.c (x_real_positions): Mark locals as initialized.
12122
eef9bc79
PE
12123 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12124
098db9dd
PE
12125 * xterm.c: Fix problems found by static analysis with other toolkits.
12126 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12127 (x_dispatch_event): Declare static if USE_GTK, and
12128 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12129 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12130 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12131 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12132 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12133
eb18f6cc
PE
12134 * xmenu.c (menu_help_callback): Pointer type fixes.
12135 Use const pointers when pointing at readonly data. Avoid pointer
12136 signedness clashes.
12137 (FALSE): Remove unused macro.
12138 (update_frame_menubar): Remove unused decl.
12139
1fe72bf8
PE
12140 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12141
60d9e1db
PE
12142 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12143 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12144 (single_menu_item): Rename local to avoid shadowing.
12145
39261c26
PE
12146 * keyboard.c (make_lispy_event): Remove unused local var.
12147
018c5e19
PE
12148 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12149 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12150
63d2b86e
PE
12151 * bitmaps: Change bitmaps from unsigned char back to the X11
12152 compatible char. Avoid the old compiler warnings about
12153 out-of-range initializers by using, for example, '\xab' rather
12154 than 0xab.
12155
aefd87e1
PE
12156 * xgselect.c (xgselect_initialize): Check vs interface
12157 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12158
bf501fb9
PE
12159 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12160
e9829fdf
PE
12161 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12162 to read-only memory.
12163
1086c095
PE
12164 * fns.c (vector): Remove; this old hack is no longer needed.
12165
2baccd04 12166 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12167 Remove unused var.
dde42981 12168 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12169
72391843 12170 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12171
436c16df 12172 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12173 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12174 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12175
92bb796d 12176 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12177 (x_term_init): Remove local to avoid shadowing.
92bb796d 12178
764430a3 12179 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12180
12181 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12182 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12183
d1dfb56c
EZ
121842011-04-16 Eli Zaretskii <eliz@gnu.org>
12185
c4354cb4
EZ
12186 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12187
d1dfb56c
EZ
12188 Fix regex.c, syntax.c and friends for buffers > 2GB.
12189 * syntax.h (struct gl_state_s): Declare character position members
12190 EMACS_INT.
12191
12192 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12193
04f2d78b
CB
12194 * textprop.c (verify_interval_modification, interval_of):
12195 Declare arguments EMACS_INT.
d1dfb56c
EZ
12196
12197 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12198 EMACS_INT.
12199
12200 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12201
12202 * indent.c (Fvertical_motion): Local variable it_start is now
12203 EMACS_INT.
12204
12205 * regex.c (re_match, re_match_2, re_match_2_internal)
12206 (bcmp_translate, regcomp, regexec, print_double_string)
12207 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12208 (re_compile_pattern, re_exec): Declare arguments and local
12209 variables `size_t' and `ssize_t' and return values `regoff_t', as
12210 appropriate.
12211 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12212 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12213 <compile_stack_type>: `size' and `avail' are now `size_t'.
12214
12215 * regex.h <regoff_t>: Use ssize_t, not int.
12216 (re_search, re_search_2, re_match, re_match_2): Arguments that
12217 specify buffer/string position and length are now ssize_t and
12218 size_t. Return type is regoff_t.
12219
613052cd
BK
122202011-04-16 Ben Key <bkey76@gmail.com>
12221
12222 * nsfont.m: Fixed bugs in ns_get_family and
12223 ns_descriptor_to_entity that were caused by using free to
12224 deallocate memory blocks that were allocated by xmalloc (via
12225 xstrdup). This caused Emacs to crash when compiled with
12226 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12227 --enable-checking=xmallocoverrun). xfree is now used to
12228 deallocate these memory blocks.
12229
4170f62f 122302011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12231
71b41406
PE
12232 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12233
9587a89d
PE
12234 emacs_write: Accept and return EMACS_INT for sizes.
12235 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12236 et seq.
12237 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12238 Accept and return EMACS_INT.
12239 (emacs_gnutls_write): Return the number of bytes written on
12240 partial writes.
12241 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12242 (emacs_read, emacs_write): Remove check for negative size, as the
12243 Emacs source code has been audited now.
9587a89d
PE
12244 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12245 (emacs_read, emacs_write): Use it.
273a5f82
PE
12246 * process.c (send_process): Adjust to the new signatures of
12247 emacs_write and emacs_gnutls_write. Do not attempt to store
12248 a byte offset into an 'int'; it might overflow.
9587a89d 12249 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12250
3e047f51
PE
12251 * sound.c: Don't assume sizes fit in 'int'.
12252 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12253 Return EMACS_INT, not int.
3e047f51 12254 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12255 Accept EMACS_INT, not int.
12256 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12257 record read return values.
12258
cc39a9db
BK
122592011-04-15 Ben Key <bkey76@gmail.com>
12260
c9d0ec6d
JB
12261 * keyboard.c (Qundefined): Don't declare static since it is used
12262 in nsfns.m.
12263 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12264 static since they are used in nsfont.m.
cc39a9db 12265
6c60eb9f
SM
122662011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12267
12268 * process.c (Qprocessp): Don't declare static.
12269 * lisp.h (Qprocessp): Declare again.
12270
7990b61a
JB
122712011-04-15 Juanma Barranquero <lekktu@gmail.com>
12272
12273 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12274
5d4cb038
PE
122752011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12276
8bd7b830 12277 Improve C-level modularity by making more things 'static'.
cd64ea1d 12278
e3b27b31
PE
12279 Don't publish debugger-only interfaces to other modules.
12280 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12281 (verify_bytepos, count_markers): Move decls to the only modules
12282 that need them.
12283 * region-cache.h (pp_cache): Likewise.
12284 * window.h (check_all_windows): Likewise.
12285 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12286
5d4cb038
PE
12287 * sysdep.c (croak): Now static, if
12288 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12289 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12290
12291 * alloc.c (refill_memory_reserve): Now static if
12292 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12293 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12294
e87b6180
PE
12295 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12296 Define only if USE_LUCID.
12297
ac64929e
PE
12298 * xrdb.c (x_customization_string, x_rm_string): Now static.
12299
6f37259d
PE
12300 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12301 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12302
1683e3ab
PE
12303 * xdisp.c (draw_row_with_mouse_face): Now static.
12304 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12305
de9c2632
PE
12306 * window.h (check_all_windows): Mark externally visible.
12307
2b96acb7
PE
12308 * window.c (window_deletion_count): Now static.
12309
12310 * undo.c: Make symbols static if they're not exported.
12311 (last_undo_buffer, last_boundary_position, pending_boundary):
12312 Now static.
12313
50436f33
PE
12314 * textprop.c (interval_insert_behind_hooks): Now static.
12315 (interval_insert_in_front_hooks): Likewise.
12316
64520e5c
PE
12317 * term.c: Make symbols static if they're not exported.
12318 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12319 (max_frame_lines, tty_set_terminal_modes):
12320 (tty_reset_terminal_modes, tty_turn_off_highlight):
12321 (get_tty_terminal): Now static.
12322 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12323 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12324 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12325 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12326 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12327
1fa53021
PE
12328 * sysdep.c: Make symbols static if they're not exported.
12329 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12330 Now static.
12331 (sigprocmask_set, full_mask): Remove; unused.
12332 (wait_debugging): Mark as visible.
12333 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12334 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12335
d4b43b22
PE
12336 * syntax.c (syntax_temp): Define only if !__GNUC__.
12337
b7c513d0
PE
12338 * sound.c (current_sound_device, current_sound): Now static.
12339
989b29ad
PE
12340 * search.c (searchbufs, searchbuf_head): Now static.
12341
13a55a78
PE
12342 * scroll.c (scroll_cost): Remove; unused.
12343 * dispextern.h (scroll_cost): Remove decl.
12344
de68a1fc
PE
12345 * region-cache.h (pp_cache): Mark as externally visible.
12346
40ccffa6
PE
12347 * process.c: Make symbols static if they're not exported.
12348 (process_tick, update_tick, create_process, chan_process):
12349 (Vprocess_alist, proc_buffered_char, datagram_access):
12350 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12351 (deactivate_process): Mark defn as static, as well as decl.
12352 * lisp.h (create_process): Remove decl.
12353 * process.h (chan_process, Vprocess_alist): Remove decls.
12354
ad64fc97
PE
12355 * print.c: Make symbols static if they're not exported.
12356 (print_depth, new_backquote_output, being_printed, print_buffer):
12357 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12358 (print_interval, print_number_index, initial_stderr_stream):
12359 Now static.
12360 * lisp.h (Fprinc): Remove decl.
12361 (debug_output_compilation_hack): Mark as externally visible.
12362
adddb265
PE
12363 * sysdep.c (croak): Move decl from here to syssignal.h.
12364 * syssignal.h (croak): Put it here, so the API can be checked when
12365 'croak' is called from dissociate_if_controlling_tty.
12366
1717ede2
PE
12367 * minibuf.c: Make symbols static if they're not exported.
12368 (minibuf_save_list, choose_minibuf_frame): Now static.
12369 * lisp.h (choose_minibuf_frame): Remove decl.
12370
fa5fb2bc
PE
12371 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12372
1e3890d1
PE
12373 * lread.c: Make symbols static if they're not exported.
12374 (read_objects, initial_obarray, oblookup_last_bucket_number):
12375 Now static.
12376 (make_symbol): Remove; unused.
12377 * lisp.h (initial_obarray, make_symbol): Remove decls.
12378
8a1414fa
PE
12379 * keyboard.c: Make symbols static if they're not exported.
12380 (single_kboard, recent_keys_index, total_keys, recent_keys):
12381 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12382 (this_single_command_key_start, echoing, last_auto_save):
12383 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12384 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12385 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12386 (Vlispy_mouse_stem, double_click_count):
12387 Now static.
12388 (force_auto_save_soon): Define only if SIGDANGER.
12389 (ignore_mouse_drag_p): Now static if
12390 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12391 (print_help): Remove; unused.
12392 (stop_character, last_timer_event): Mark as externally visible.
12393 * keyboard.h (ignore_mouse_drag_p): Declare only if
12394 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12395 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12396 * lisp.h (echoing): Remove decl.
12397 (force_auto_save_soon): Declare only if SIGDANGER.
12398 * xdisp.c (redisplay_window): Simplify code, to make it more
12399 obvious that ignore_mouse_drag_p is not accessed if !defined
12400 USE_GTK && !defined HAVE_NS.
12401
93ea6e8f
PE
12402 * intervals.c: Make symbols static if they're not exported.
12403 (merge_properties_sticky, merge_interval_right, delete_interval):
12404 Now static.
12405 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12406
77382fcc
PE
12407 * insdel.c: Make symbols static if they're not exported.
12408 However, leave prepare_to_modify_buffer alone. It's never
12409 called from outside this function, but that appears to be a bug.
12410 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12411 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12412 (adjust_after_replace_noundo): Remove; unused.
12413 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12414 (signal_before_change): Remove decls.
77382fcc 12415
9306c32e
PE
12416 * indent.c (val_compute_motion, val_vmotion): Now static.
12417
cd44d2eb
PE
12418 * image.c: Make symbols static if they're not exported.
12419 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12420 if USE_GTK.
12421 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12422 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12423
ad9a7a06
PE
12424 * fringe.c (standard_bitmaps): Now static.
12425 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12426
81626931
PE
12427 * frame.c: Make symbols static if they're not exported.
12428 (x_report_frame_params, make_terminal_frame): Now static.
12429 (get_frame_param): Now static, unless HAVE_NS.
12430 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12431 (x_get_resource_string): Remove; not used.
12432 * frame.h (make_terminal_frame, x_report_frame_params):
12433 (x_get_resource_string); Remove decls.
12434 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12435 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12436
239f9db9
PE
12437 * font.c, fontset.c: Make symbols static if they're not exported.
12438 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12439 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12440 * font.c (font_close_object): Now static.
12441 * font.h (font_close_object): Remove.
12442 * fontset.c (FONTSET_OBJLIST): Remove.
12443 (free_realized_fontset) #if-0 the body, which does nothing.
12444 (face_suitable_for_char_p): #if-0, as it's never called.
12445 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12446 * xfaces.c (face_at_string_position):
12447 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12448 since 0 is always ASCII.
12449
dfcf3579
PE
12450 * fns.c (weak_hash_tables): Now static.
12451
5045092b
PE
12452 * fileio.c: Make symbols static if they're not exported.
12453 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12454 (Vwrite_region_annotation_buffers): Now static.
12455
57a96f5c
PE
12456 * eval.c: Make symbols static if they're not exported.
12457 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12458 * lisp.h (backtrace_list): Remove decl.
12459
35f08c38
PE
12460 * emacs.c: Make symbols static if they're not exported.
12461 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12462 (fatal_error_code, fatal_error_signal_hook, standard_args):
12463 Now static.
12464 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12465 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12466 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12467 * lisp.h (fatal_error_signal_hook): Remove decl.
12468 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12469
f44bd759
PE
12470 * editfns.c: Move a (normally-unused) function to its only use.
12471 * editfns.c, lisp.h (get_operating_system_release): Remove.
12472 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12473 worth the hassle of breaking this out.
12474
b532497d
PE
12475 * xterm.c: Make symbols static if they're not exported.
12476 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12477 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12478 (x_destroy_window, x_delete_display):
12479 Now static.
12480 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12481 (x_mouse_leave): Remove; unused.
12482 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12483 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12484 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12485 Remove decls.
12486 (x_mouse_leave): Declare only if WINDOWSNT.
12487 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12488 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12489 USE_X_TOOLKIT.
12490
1675728f
PE
12491 * ftxfont.c: Make symbols static if they're not exported.
12492 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12493 HAVE_FREETYPE.
12494 * font.h (ftxfont_driver): Likewise.
12495
e4cebfca
PE
12496 * xfns.c: Make symbols static if they're not exported.
12497 (x_last_font_name, x_display_info_for_name):
12498 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12499 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12500 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12501 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12502 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12503 (last_show_tip_args): Now static.
12504 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12505 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12506 (x_screen_planes): Remove; unused.
12507 * dispextern.h (x_screen_planes): Remove decl.
12508
5bf46f05
PE
12509 * dispnew.c: Make symbols static if they're not exported.
12510 * dispextern.h (redraw_garbaged_frames, scrolling):
12511 (increment_row_positions): Remove.
12512 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12513 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12514 Now static.
12515 (redraw_garbaged_frames): Remove; unused.
12516
435f4c28
PE
12517 * xfaces.c: Make symbols static if they're not exported.
12518 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12519 Remove decls.
12520 * xterm.h (defined_color): Remove decls.
12521 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12522 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12523 (menu_face_changed_default, defined_color, free_realized_face):
12524 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12525 (ascii_face_of_lisp_face): Remove; unused.
12526
8524aef3
PE
12527 * xdisp.c: Make symbols static if they're not exported.
12528 * dispextern.h (scratch_glyph_row, window_box_edges):
12529 (glyph_to_pixel_coords, set_cursor_from_row):
12530 (get_next_display_element, set_iterator_to_next):
12531 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12532 (show_mouse_face): Remove decls
12533 * frame.h (message_buf_print): Likewise.
12534 * lisp.h (pop_message, set_message, check_point_in_composition):
12535 Likewise.
12536 * xterm.h (set_vertical_scroll_bar): Likewise.
12537 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12538 (message_buf_print, scratch_glyph_row, displayed_buffer):
12539 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12540 (get_next_display_element, show_mouse_face, window_box_edges):
12541 (frame_to_window_pixel_xy, check_point_in_composition):
12542 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12543 (glyph_to_pixel_coords): Remove; unused.
12544
16390cd2
PE
12545 * dired.c (file_name_completion): Now static.
12546
12547 * dbusbind.c (xd_in_read_queued_messages): Now static.
12548
a25f4dfa
PE
12549 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12550 * data.c (circular_list_error): Remove.
12551
14a9c8df
PE
12552 * commands.h (last_point_position, last_point_position_buffer):
12553 (last_point_position_window): Remove decls.
12554 * keyboard.c: Make these variables static.
12555
04f2d78b
CB
12556 * coding.h (coding, code_convert_region, encode_coding_gap):
12557 Remove decls.
74ab6df5
PE
12558 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12559 (iso_code_class, detect_coding, code_convert_region): Now static.
12560 (encode_coding_gap): Remove; unused.
12561
38dfbee1
PE
12562 * chartab.c (chartab_chars, chartab_bits): Now static.
12563
a2cb4e63
PE
12564 * charset.h (charset_iso_8859_1): Remove decl.
12565 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12566 Now static.
12567
127198fd
PE
12568 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12569 * ccl.c (Vccl_program_table): Now static.
12570 (check_ccl_update): Remove; unused.
12571
d85b608f
PE
12572 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12573 * category.h: ... from here.
12574 * category.c (check_category_table, set_category_set): Now static.
12575
31cd66f3
PE
12576 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12577 * lisp.h: Remove these decls.
12578
c358e587
PE
12579 * buffer.c (buffer_count): Remove unused var.
12580
e78aecca
PE
12581 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12582 so that it's not optimized away.
12583 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12584 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12585 exported only to the debugger.
12586
e192d7d3 12587 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12588 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12589
92470028
PE
12590 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12591 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12592 was inaccessible from Lisp.
12593 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12594 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12595
244ed907
PE
12596 alloc.c: Import and export fewer symbols, and remove unused items.
12597 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12598 is defined.
12599 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12600 it's not optimized away by whole-program optimization.
12601 (message_enable_multibyte, free_misc): Remove.
12602 (catchlist, handlerlist, mark_backtrace):
12603 Declare only if BYTE_MARK_STACK.
12604 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12605 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12606 (message_enable_multibyte): Remove decl.
12607 (free_misc, interval_free_list, float_block, float_block_index):
12608 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12609 (cons_free_list, last_marked_index):
12610 Now static.
12611 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12612 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12613 (mark_backtrace): Define only if BYTE_MARK_STACK.
12614 * xdisp.c (message_enable_multibyte): Now static.
12615
61c2b50e 12616 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12617 This makes it easier for human readers (and static analyzers)
12618 to see whether these variables are used from other modules.
12619 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12620 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12621 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12622 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12623 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12624 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12625 * xmenu.c, xselect.c:
12626 Declare Q* vars static if they are not used in other modules.
12627 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12628 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12629 Remove decls of unexported vars.
12630 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12631
95c82688
PE
12632 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12633
16a97296
PE
12634 Make Emacs functions such as Fatom 'static' by default.
12635 This makes it easier for human readers (and static analyzers)
12636 to see whether these functions can be called from other modules.
12637 DEFUN now defines a static function. To make the function external
12638 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12639 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12640 (Finit_image_library):
16a97296
PE
12641 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12642 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12643 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12644 Remove decls, since these functions are now static.
12645 (Funintern, Fget_internal_run_time): New decls, since these functions
12646 were already external.
95c82688 12647
16a97296
PE
12648 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12649 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12650 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12651 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12652 * keyboard.c, keymap.c, lread.c:
12653 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12654 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12655 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12656 Mark functions with DEFUE instead of DEFUN,
12657 if they are used in other modules.
12658 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12659 decls for now-static functions.
12660 * buffer.h (Fdelete_overlay): Remove decl.
12661 * callproc.c (Fgetenv_internal): Mark as internal.
12662 * composite.c (Fremove_list_of_text_properties): Remove decl.
12663 (Fcomposition_get_gstring): New forward static decl.
12664 * composite.h (Fcomposite_get_gstring): Remove decl.
12665 * dired.c (Ffile_attributes): New forward static decl.
12666 * doc.c (Fdocumntation_property): New forward static decl.
12667 * eval.c (Ffetch_bytecode): New forward static decl.
12668 (Funintern): Remove extern decl; now in .h file where it belongs.
12669 * fileio.c (Fmake_symbolic_link): New forward static decl.
12670 * image.c (Finit_image_library): New forward static decl.
12671 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12672 * intervals.h (Fprevious_property_change):
12673 (Fremove_list_of_text_properties): Remove decls.
12674 * keyboard.c (Fthis_command_keys): Remove decl.
12675 (Fcommand_execute): New forward static decl.
12676 * keymap.c (Flookup_key): New forward static decl.
12677 (Fcopy_keymap): Now static.
12678 * keymap.h (Flookup_key): Remove decl.
12679 * process.c (Fget_process): New forward static decl.
12680 (Fprocess_datagram_address): Mark as internal.
12681 * syntax.c (Fsyntax_table_p): New forward static decl.
12682 (skip_chars): Remove duplicate decl.
12683 * textprop.c (Fprevious_property_change): New forward static decl.
12684 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12685 Now internal.
12686 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12687 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12688
785bbd42
PE
12689 * editfns.c (Fformat): Remove unreachable code.
12690
8b913b57
AS
126912011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12692
12693 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12694 change. (Bug#8496)
12695
a6744a35
EZ
126962011-04-13 Eli Zaretskii <eliz@gnu.org>
12697
12698 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12699 when at ZV. (Bug#8487)
12700
e7974947
AS
127012011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12702
baad03f0
AS
12703 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12704 (Bug#8437)
12705 * keyboard.c (parse_tool_bar_item): Likewise.
12706 * sound.c (sound_cleanup, alsa_close): Likewise.
12707 * termcap.c (tgetent): Likewise.
12708 * xfns.c (x_default_font_parameter): Likewise.
12709 * xsettings.c (read_and_apply_settings): Likewise.
12710
e7974947
AS
12711 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12712 (overrun_check_free): Protoize.
12713
28272684
PE
127142011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12715
12716 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12717 since callers should never pass a negative size.
12718 Change the signature to match that of plain 'read' and 'write'; see
12719 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12720 * lisp.h: Update prototypes of emacs_write and emacs_read.
12721
11997c76
EZ
127222011-04-11 Eli Zaretskii <eliz@gnu.org>
12723
12724 * xdisp.c (redisplay_window): Don't try to determine the character
12725 position of the scroll margin if the window start point w->startp
e896f03c 12726 is outside the buffer's accessible region. (Bug#8468)
11997c76 12727
8a2cbd72
EZ
127282011-04-10 Eli Zaretskii <eliz@gnu.org>
12729
12730 Fix write-region and its subroutines for buffers > 2GB.
12731 * fileio.c (a_write, e_write): Modify declaration of arguments and
12732 local variables to support buffers larger than 2GB.
12733 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12734
12735 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12736 argument, local variables, and return value.
12737
12738 * lisp.h: Update prototypes of emacs_write and emacs_read.
12739
12740 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12741
4073e537 127422011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12743
1ebfdcb6
PE
12744 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12745
b2ded58d
PE
12746 Fix more problems found by GCC 4.6.0's static checks.
12747
7d66342c
PE
12748 * xdisp.c (vmessage): Use a better test for character truncation.
12749
bbf47d44
PE
12750 * charset.c (load_charset_map): <, not <=, for optimization,
12751 and to avoid potential problems with integer overflow.
9248994d 12752 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12753 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12754 * editfns.c (Fformat): Likewise.
1e69125e 12755 * syntax.c (skip_chars): Likewise.
3befa583 12756
e3019616
PE
12757 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12758 This also lets GCC 4.6.0 generate slightly better loop code.
12759
becfa255
PE
12760 * callint.c (Fcall_interactively): <, not <=, for optimization.
12761 (Fcall_interactively): Count the number of arguments produced,
12762 not the number of arguments given. This is simpler and lets GCC
12763 4.6.0 generate slightly better code.
12764
dae0cd48
PE
12765 * ftfont.c: Distingish more carefully between FcChar8 and char.
12766 The previous code passed unsigned char * to a functions like
12767 strlen and xstrcasecmp that expect char *, which does not
12768 conform to the C standard.
12769 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12770 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12771 char * when the C standard requires it.
12772
76032d70
PE
12773 * keyboard.c (read_char): Remove unused var.
12774
eb3f1cc8
PE
12775 * eval.c: Port to Windows vsnprintf (Bug#8435).
12776 Include <limits.h>.
12777 (SIZE_MAX): Define if the headers do not.
12778 (verror): Do not give up if vsnprintf returns a negative count.
12779 Instead, grow the buffer. This ports to Windows vsnprintf, which
12780 does not conform to C99. Problem reported by Eli Zaretskii.
12781 Also, simplify the allocation scheme, by avoiding the need for
12782 calling realloc, and removing the ALLOCATED variable.
12783
70476b54
PE
12784 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12785
12020a9e
PE
12786 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12787 But keep the doprint source code for now, as we might revamp it
12788 and use it again (Bug#8435).
ea6c7ae6
PE
12789 * lisp.h (doprnt): Remove.
12790 * Makefile.in (base_obj): Remove doprnt.o.
12791 * deps.mk (doprnt.o): Remove.
12792
5fdb398c
PE
12793 error: Print 32- and 64-bit integers portably (Bug#8435).
12794 Without this change, on typical 64-bit hosts error ("...%d...", N)
12795 was used to print both 32- and 64-bit integers N, which relied on
12796 undefined behavior.
61bdb816 12797 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12798 * lisp.h (error, verror): Mark as printf-like functions.
12799 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12800 Report overflow in size calculations when allocating printf buffer.
12801 Do not truncate output string at its first null byte.
12802 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12803 Truncate the output at a character boundary, since vsnprintf does not
12804 do that.
12805 * charset.c (check_iso_charset_parameter): Convert internal
12806 character to string before calling 'error', since %c now has the
12807 printf meaning.
12808 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12809 overflow when computing char to be passed to 'error'. Do not
12810 pass Lisp_Object to 'error'; pass the integer instead.
12811 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12812 formatted with plain %d.
12813
b189fa66
PE
12814 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12815
bff87ef0
PE
12816 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12817
7e2cac20
PE
12818 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12819
ce4d90b5
PE
12820 * xterm.c (x_catch_errors): Remove duplicate declaration.
12821
266c9547
PE
12822 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12823
79c49ad2
PE
12824 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12825
368f4090
JM
128262011-04-10 Jim Meyering <meyering@redhat.com>
12827
12828 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12829 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12830 return ssize_t not "int", and use size_t as the buffer length.
12831 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12832 * gnutls.h: Update declarations.
12833 * process.c (read_process_output): Use ssize_t, to match.
12834 (send_process): Likewise.
12835
a32d4040
CY
128362011-04-09 Chong Yidong <cyd@stupidchicken.com>
12837
12838 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12839
8546720e 128402011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12841
04f2d78b
CB
12842 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12843 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12844
8546720e
GM
12845 * xterm.c (handle_one_xevent):
12846 * xmenu.c (create_and_show_popup_menu):
12847 * xselect.c (x_decline_selection_request)
12848 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12849
0a2f5c1a 128502011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12851
12852 Fix some uses of `int' instead of EMACS_INT.
12853 * search.c (string_match_1, fast_string_match)
12854 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12855 (scan_buffer, find_next_newline_no_quit)
12856 (find_before_next_newline, search_command, Freplace_match)
12857 (Fmatch_data): Make some `int' variables be EMACS_INT.
12858
12859 * xdisp.c (display_count_lines): 3rd argument and return value now
12860 EMACS_INT. All callers changed.
12861 (pint2hrstr): Last argument is now EMACS_INT.
12862
12863 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12864 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12865 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12866 (decode_coding_utf_16, decode_coding_emacs_mule)
12867 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12868 (decode_coding_ccl, decode_coding_charset)
12869 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12870 (decode_coding_iso_2022, decode_coding_emacs_mule)
12871 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12872 <char_offset, last_offset>: Declare EMACS_INT.
12873 (encode_coding_utf_8, encode_coding_utf_16)
12874 (encode_coding_emacs_mule, encode_invocation_designation)
12875 (encode_designation_at_bol, encode_coding_iso_2022)
12876 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12877 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12878 Declare EMACS_INT.
12879 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12880 (encode_invocation_designation): Last argument P_NCHARS is now
12881 EMACS_INT.
12882 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12883 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12884
12885 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12886 All users changed.
12887
12888 * ccl.c (Fccl_execute_on_string): Declare some variables
12889 EMACS_INT.
12890
8546720e 128912011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12892
12893 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12894
4e19a977
CS
128952011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12896
12897 * process.c (Fformat_network_address): Doc fix.
12898
87302331
R
128992011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12900
ee7683eb 12901 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12902
cbb59342
CY
129032011-04-08 Chong Yidong <cyd@stupidchicken.com>
12904
12905 * keyboard.c (read_char): Call Lisp function help-form-show,
12906 instead of using internal_with_output_to_temp_buffer.
12907 (Qhelp_form_show): New var.
e0d38eeb 12908 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12909
12910 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12911
12912 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12913
e67a13ab
CY
129142011-04-06 Chong Yidong <cyd@stupidchicken.com>
12915
04f2d78b
CB
12916 * process.c (Flist_processes): Remove to Lisp.
12917 (list_processes_1): Delete.
e67a13ab 12918
973f782d
EZ
129192011-04-06 Eli Zaretskii <eliz@gnu.org>
12920
7c106b1e
EZ
12921 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12922
973f782d
EZ
12923 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12924
41cf7d1a 129252011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12926
ca23cc88
PE
12927 Fix more problems found by GCC 4.6.0's static checks.
12928
f390e2d5
PE
12929 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12930
42eea0d0
PE
12931 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12932
b69769da 12933 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12934
f9541e84
PE
12935 * xdisp.c (vmessage): Mark as a printf-like function.
12936
13841b55
PE
12937 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12938
c136c10f
PE
12939 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12940
5e2d4a30
PE
12941 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12942 printf-like functions.
12943 (tiff_load): Add casts to remove these marks before passing them
12944 to system-supplied API.
12945
583f48b9
PE
12946 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12947
b25d760e
PE
12948 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12949 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12950 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12951 directly, rather than having caller test rule sign. This avoids
12952 some unnecessary tests.
12953 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12954 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12955 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12956
bc7b6697 12957 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12958 (xfont_open): Avoid unnecessary tests.
bc7b6697 12959
27ccc379
PE
12960 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12961
dcd5c89a
PE
12962 * composite.h, composite.c (composition_gstring_put_cache):
12963 Use EMACS_INT, not int, for length.
12964
b13a45c6
PE
12965 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12966 breaking out part of COMPOSITION_DECODE_RULE.
12967 (COMPOSITION_DECODE_RULE): Use it.
12968 * composite.c (get_composition_id): Remove unused local vars,
12969 by using the new macro.
12970
1e792e4d
PE
12971 * textprop.c (set_text_properties_1): Change while to do-while,
12972 since the condition is always true at first.
12973
dc6c6455 12974 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12975 (interval_deletion_adjustment): Return unsigned value.
12976 All uses changed.
dc6c6455 12977
aba7731a
PE
12978 * process.c (list_processes_1, create_pty, read_process_output):
12979 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12980 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12981 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12982 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12983 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12984
fdfc4bf3
PE
12985 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12986
fca8fe46 12987 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12988 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12989
06a0259a 12990 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12991 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12992 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12993
e7b9e80f
PE
12994 * print.c (print_error_message): Avoid int overflow.
12995
56201685
PE
12996 * font.c (font_list_entities): Redo for clarity,
12997 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12998
78834453 12999 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13000 (font_score): Avoid potential overflow in diff calculation.
78834453 13001
0bc0b309 13002 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13003 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13004
e610eaca
PE
13005 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13006
b895abce
PE
13007 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13008 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13009 can always succeed if overflow has undefined behavior.
13010
1f1d9321 13011 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13012 (wordify): Omit three unnecessary tests.
1f1d9321 13013
c59478bc
PE
13014 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13015 All callers changed. This avoids the need for an unused var.
13016
79b73827
PE
13017 * casefiddle.c (casify_region): Remove var that is set but not used.
13018
a4db5dfe
PE
13019 * dired.c (file_name_completion): Remove var that is set but not used.
13020
43aae36e
PE
13021 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13022
2a47c44d 13023 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13024 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13025
a37c69bf
PE
13026 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13027 Check for integer overflow on size calculations.
13028
328ab8e7
PE
13029 * buffer.c (Fprevious_overlay_change): Remove var that is set
13030 but not used.
13031
e5a2a5cb
PE
13032 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13033 Remove vars that are set but not used.
8d84a6eb 13034 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13035 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13036
a60e5f68
PE
13037 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13038
f661cb61 13039 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13040 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13041
f0397f5a
PE
13042 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13043 that are set but not used.
13044
8664db06 13045 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13046 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13047
6abdaa4a
PE
13048 * xselect.c (x_get_local_selection, x_handle_property_notify):
13049 Remove vars that are set but not used.
13050
0ce7538d 13051 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13052 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13053
9ae848fc
PE
13054 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13055 Remove var that is set but not used.
0b918413
PE
13056 (scroll_bar_windows_size): Now size_t, not int.
13057 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13058 Check for overflow.
9ae848fc 13059
a5a62657
PE
13060 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13061 (map_tty_color) [!defined MSDOS]: Likewise.
13062
5c5cdd39
PE
13063 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13064
66ebf983
PE
13065 * coding.c: Remove vars that are set but not used.
13066 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13067 All callers changed.
13068 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13069 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13070 (decode_coding_charset): Remove vars that are set but not used.
13071
1be4d761
PE
13072 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13073 that is set but not used.
13074
47553fa8
PE
13075 * print.c (print_object): Remove var that is set but not used.
13076
1f7196bf 13077 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13078 The gnulib version avoids calling malloc in the usual case,
13079 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13080 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13081 * filelock.c (current_lock_owner): Likewise.
13082 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13083 * sysdep.c: Include allocator.h, careadlinkat.h.
13084 (emacs_no_realloc_allocator): New static constant.
13085 (emacs_readlink): New function.
fdb61804
PE
13086 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13087 ../lib/careadlinkat.h.
d1fdcab7 13088
f84c17c7
SM
130892011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13090
13091 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13092 first non-nil return value).
13093
ef3862ad
JD
130942011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13095
13096 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13097 if not defined (Bug#8403).
13098
376a7006
JB
130992011-04-02 Juanma Barranquero <lekktu@gmail.com>
13100
13101 * xdisp.c (display_count_lines): Remove parameter `start',
13102 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13103 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13104 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13105 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13106 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13107 and thereabouts. All callers changed.
13108 (get_per_char_metric): Remove parameter `f', unused since
13109 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13110
6ca3801d
JM
131112011-04-02 Jim Meyering <meyering@redhat.com>
13112
13113 do not dereference NULL upon failed strdup
13114 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13115 (ns_get_family): Likewise.
13116
d8e2b5ba
JB
131172011-04-02 Juanma Barranquero <lekktu@gmail.com>
13118
13119 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13120
8c74fcbd
JD
131212011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13122
13123 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13124 later (Bug#8403).
13125
7200d79c
SM
131262011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13127
03408648 13128 Add lexical binding.
7200d79c 13129
03408648
SM
13130 * window.c (Ftemp_output_buffer_show): New fun.
13131 (Fsave_window_excursion):
13132 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13133
13134 * lread.c (lisp_file_lexically_bound_p): New function.
13135 (Fload): Bind Qlexical_binding.
13136 (readevalloop): Remove `evalfun' arg.
13137 Bind Qinternal_interpreter_environment.
13138 (Feval_buffer): Bind Qlexical_binding.
13139 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13140 Mark as dynamic.
13141 (syms_of_lread): Declare `lexical-binding'.
13142
13143 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13144
13145 * keyboard.c (eval_dyn): New fun.
13146 (menu_item_eval_property): Use it.
ca105506
SM
13147
13148 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13149
03408648
SM
13150 * fns.c (concat, mapcar1): Accept byte-code-functions.
13151
13152 * eval.c (Fsetq): Handle lexical vars.
13153 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13154 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13155 (FletX, Flet): Obey lexical binding.
13156 (Fcommandp): Handle closures.
13157 (Feval): New `lexical' arg.
13158 (eval_sub): New function extracted from Feval. Use it almost
13159 everywhere where Feval was used. Look up vars in lexical env.
13160 Handle closures.
13161 (Ffunctionp): Move from subr.el.
13162 (Ffuncall): Handle closures.
13163 (apply_lambda): Remove `eval_flags'.
13164 (funcall_lambda): Handle closures and new byte-code-functions.
13165 (Fspecial_variable_p): New function.
13166 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13167 but without exporting it to Lisp.
23aba0ea 13168
23aba0ea 13169 * doc.c (Fdocumentation, store_function_docstring):
03408648 13170 * data.c (Finteractive_form): Handle closures.
23aba0ea 13171
03408648
SM
13172 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13173 interactive spec.
ba83908c 13174
04f2d78b
CB
13175 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13176 New byte-codes.
03408648
SM
13177 (exec_byte_code): New function extracted from Fbyte_code to handle new
13178 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13179
03408648 13180 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13181
03408648 13182 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13183
e2abce01
JB
131842011-03-31 Juanma Barranquero <lekktu@gmail.com>
13185
13186 * xdisp.c (redisplay_internal): Fix prototype.
13187
63696a73 131882011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13189
63696a73 13190 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13191 (try_scrolling): Use it when setting scroll_limit.
13192 Limit scrolling to 100 screen lines.
63696a73
EZ
13193 (redisplay_window): Even when falling back on "recentering",
13194 position point in the window according to scroll-conservatively,
13195 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13196
13197 (try_scrolling): When point is above the window, allow searching
13198 as far as scroll_max, or one screenful, to compute vertical
13199 distance from PT to the scroll margin position. This prevents
13200 try_scrolling from unnecessarily failing when
13201 scroll-conservatively is set to a value slightly larger than the
13202 window height. Clean up the case of PT below the margin at bottom
13203 of window: scroll_max can no longer be INT_MAX. When aggressive
13204 scrolling is in use, don't let point enter the opposite scroll
13205 margin as result of the scroll.
13206 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13207 threshold of 100 lines for never-recentering scrolling.
13208
e4cc2dfc
JB
132092011-03-31 Juanma Barranquero <lekktu@gmail.com>
13210
13211 * dispextern.h (move_it_by_lines):
13212 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13213 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13214 (message_log_check_duplicate): Remove parameters `prev_bol' and
13215 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13216 (redisplay_internal): Remove parameter `preserve_echo_area',
13217 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13218
13219 * indent.c (Fvertical_motion):
13220 * window.c (window_scroll_pixel_based, Frecenter):
13221 Don't pass `need_y_p' to `move_it_by_lines'.
13222
1c470562
SM
132232011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13224
44f230aa
SM
13225 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13226 steal a few bits to be more compact.
13227 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13228 Remove unneeded casts.
13229
1c470562
SM
13230 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13231
888adce9
ZK
132322011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13233
13234 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13235 binding" message (bug#7967).
13236
f838ed7b
PE
132372011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13238
77861b95
PE
13239 Fix more problems found by GCC 4.6.0's static checks.
13240
de6dbc14
PE
13241 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13242 Remove unused local var.
13243
f838ed7b
PE
13244 * editfns.c (Fmessage_box): Remove unused local var.
13245
792c7b2b
PE
13246 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13247 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13248 Omit unused local vars.
c499e557 13249 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13250 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13251 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13252 Omit unused local var.
13253
ba0165e1
PE
13254 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13255 Don't assume string length fits in int.
32ad8845 13256 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13257 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13258
3c59b4c9
PE
13259 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13260 instead of alloca (Bug#8344).
13261
a3eed478 13262 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13263 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13264
eb4d412d
PE
13265 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13266
1658b401
PE
13267 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13268 concerns.
13269
13270 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13271
13272 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13273
9a2c6e05
PE
13274 * keyboard.c (syms_of_keyboard): Use the same style as later
13275 in this function when indexing through an array. This also
13276 works around GCC bug 48267.
13277
03d0a109
PE
13278 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13279
44f730c8
PE
13280 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13281
fe75f926
PE
13282 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13283 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13284
ffa8c828
PE
13285 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13286 This avoids undefined behavior on integer overflow, and is a bit
13287 more convenient anyway since it is compared to a size_t variable.
13288
c5101a77
PE
13289 Variadic C functions now count arguments with size_t, not int.
13290 This avoids an unnecessary limitation on 64-bit machines, which
13291 caused (substring ...) to crash on large vectors (Bug#8344).
13292 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13293 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13294 All variadic functions and their callers changed accordingly.
c5101a77
PE
13295 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13296 * data.c (arith_driver, float_arith_driver): Likewise.
13297 * editfns.c (general_insert_function): Likewise.
13298 * eval.c (struct backtrace.nargs, interactive_p)
13299 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13300 (funcall_lambda, mark_backtrace): Likewise.
13301 * fns.c (concat): Likewise.
13302 * frame.c (x_set_frame_parameters): Likewise.
13303 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13304 0 if not found, not -1. All callers changed.
13305
dd3f25f7
PE
13306 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13307 (stack_copy_size): Now size_t, not int.
13308 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13309
461c2ab9
JB
133102011-03-28 Juanma Barranquero <lekktu@gmail.com>
13311
13312 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13313 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13314 All callers changed.
13315
13316 * lisp.h (multibyte_char_to_unibyte):
13317 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13318 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13319 * character.h (CHAR_TO_BYTE8):
13320 * cmds.c (internal_self_insert):
13321 * editfns.c (general_insert_function):
13322 * keymap.c (push_key_description):
13323 * search.c (Freplace_match):
13324 * xdisp.c (message_dolog, set_message_1): All callers changed.
13325
f6d62986
SM
133262011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13327
13328 * keyboard.c (safe_run_hook_funcall): New function.
13329 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13330 don't set the hook to nil, but remove the offending function instead.
13331 (Qcommand_hook_internal): Remove, unused.
13332 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13333 Vcommand_hook_internal.
13334
13335 * eval.c (enum run_hooks_condition): Remove.
13336 (funcall_nil, funcall_not): New functions.
13337 (run_hook_with_args): Call each function through a `funcall' argument.
13338 Remove `cond' argument, now redundant.
13339 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13340 (Frun_hook_with_args_until_failure): Adjust accordingly.
13341 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13342
1db5b1ad
JB
133432011-03-28 Juanma Barranquero <lekktu@gmail.com>
13344
13345 * dispextern.h (string_buffer_position): Remove declaration.
13346
13347 * print.c (strout): Remove parameter `multibyte', unused since
13348 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13349
13350 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13351 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13352 All callers changed.
13353
13354 * w32.c (_wsa_errlist): Use braces for struct initializers.
13355
13356 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13357 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13358 All callers changed.
13359 (string_buffer_position): Likewise. Also, make static (it's never
13360 used outside xdisp.c).
13361 (cursor_row_p): Remove parameter `w', unused since
13362 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13363 (decode_mode_spec): Remove parameter `precision', introduced during
13364 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13365 All callers changed.
13366
5ffb62aa
JD
133672011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13368
13369 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13370
461c2ab9 133712011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13372
13373 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13374 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13375 (ns_update_auto_hide_menu_bar): New functions.
13376 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13377 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13378 ns_constrain_all_frames.
13379 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13380 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13381
5c380ffb
JD
133822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13383
13384 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13385
9af30bdf
GM
133862011-03-27 Glenn Morris <rgm@gnu.org>
13387
13388 * syssignal.h: Replace RETSIGTYPE with void.
13389 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13390 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13391 Replace SIGTYPE with void everywhere.
13392 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13393 * s/template.h (SIGTYPE): Remove commented out definition.
13394
e2abce01
JB
133952011-03-26 Eli Zaretskii <eliz@gnu.org>
13396
13397 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13398 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13399
f868cd8a
JB
134002011-03-26 Juanma Barranquero <lekktu@gmail.com>
13401
59eb0929
JB
13402 * w32.c (read_unc_volume): Use parameter `henum', instead of
13403 global variable `wget_enum_handle'.
13404
13405 * keymap.c (describe_vector): Remove parameters `indices' and
13406 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13407 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13408
f868cd8a
JB
13409 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13410
13411 * keyboard.c (timer_check): Remove parameter `do_it_now',
13412 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13413 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13414 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13415
13416 * keyboard.c (read_char):
13417 * w32menu.c (w32_menu_display_help):
13418 * xmenu.c (show_help_event, menu_help_callback):
13419 Adjust calls to `show_help_echo'.
13420
13421 * gtkutil.c (xg_maybe_add_timer):
13422 * keyboard.c (readable_events):
13423 * process.c (wait_reading_process_output):
13424 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13425
13426 * insdel.c (adjust_markers_gap_motion):
13427 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13428 (gap_left, gap_right): Don't call it.
13429
2ecf6fdb
CY
134302011-03-25 Chong Yidong <cyd@stupidchicken.com>
13431
13432 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13433 incurred during fontification.
13434
6b1f9ba4
JB
134352011-03-25 Juanma Barranquero <lekktu@gmail.com>
13436
13437 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13438 (DEFVAR_PER_BUFFER): Don't pass it.
13439
13440 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13441 (scrolling_window): Don't pass it.
13442
0f4a96b5
JB
134432011-03-25 Juanma Barranquero <lekktu@gmail.com>
13444
13445 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13446
13447 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13448 and `suffix'.
13449 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13450 of variables specific to SELinux and computation of `encoded_absname'.
13451
13452 * image.c (XPutPixel): Remove unused variable `height'.
13453
13454 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13455
13456 * unexw32.c (get_section_info): Remove unused variable `section'.
13457
13458 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13459 (system_process_attributes): Remove unused variable `sess'.
13460 (sys_read): Remove unused variable `err'.
13461
13462 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13463 (w32_wnd_proc): Remove unused variable `isdead'.
13464 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13465 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13466 (x_create_tip_frame): Remove unused variable `tem'.
13467
13468 * w32inevt.c (w32_console_read_socket):
13469 Remove unused variable `no_events'.
13470
13471 * w32term.c (x_draw_composite_glyph_string_foreground):
13472 Remove unused variable `width'.
13473
1149507c
JB
134742011-03-24 Juanma Barranquero <lekktu@gmail.com>
13475
13476 * w32term.c (x_set_glyph_string_clipping):
13477 Don't pass uninitialized region to CombineRgn.
13478
9c88f339
JB
134792011-03-23 Juanma Barranquero <lekktu@gmail.com>
13480
13481 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13482 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13483 (Fx_close_connection): Remove unused variable `i'.
13484
13485 * w32font.c (w32font_draw): Return number of glyphs.
13486 (w32font_open_internal): Remove unused variable `i'.
13487 (w32font_driver): Add missing initializer.
13488
13489 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13490 (fill_in_menu): Remove unused variable `items_added'.
13491
13492 * w32term.c (last_mouse_press_frame): Remove static global variable.
13493 (w32_clip_to_row): Remove unused variable `f'.
13494 (x_delete_terminal): Remove unused variable `i'.
13495
13496 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13497 (NOTHING): Remove unused static global variable.
13498 (uniscribe_check_otf): Remove unused variable `table'.
13499 (uniscribe_font_driver): Add missing initializers.
13500
dee091a3
JD
135012011-03-23 Julien Danjou <julien@danjou.info>
13502
13503 * term.c (Fsuspend_tty, Fresume_tty):
13504 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13505 * window.c (temp_output_buffer_show):
13506 * insdel.c (signal_before_change):
13507 * frame.c (Fhandle_switch_frame):
13508 * fileio.c (Fdo_auto_save):
13509 * emacs.c (Fkill_emacs):
13510 * editfns.c (save_excursion_restore):
13511 * cmds.c (internal_self_insert):
13512 * callint.c (Fcall_interactively):
13513 * buffer.c (Fkill_all_local_variables):
13514 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13515 Use Frun_hooks.
0f4a96b5 13516 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13517 unconditionally since it does the check itself.
dee091a3 13518
2c520ab5 135192011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13520
c9c49752
PE
13521 Fix more problems found by GCC 4.5.2's static checks.
13522
8abc3f12
PE
13523 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13524 the first time through the loop, since we know p0 < p1 then.
13525 This also avoids a gcc -Wstrict-overflow warning.
13526
a2d26660
PE
13527 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13528 leading to a memory leak, possible in functions like
13529 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13530 of objects (Bug#8318).
a2d26660 13531
916c72e9
PE
13532 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13533 that could (at least in theory) be that large.
13534
19ab8a18
PE
13535 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13536 This is less likely to overflow, and avoids undefined behavior if
13537 overflow does occur. All callers changed. Use strtoul to scan
13538 for the unsigned long integer.
b7cbbd6f
PE
13539 (pint2hrstr): Simplify and tune code slightly.
13540 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13541
f0641eff
PE
13542 * scroll.c (do_scrolling): Work around GCC bug 48228.
13543 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13544
7f650bb9
PE
13545 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13546 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13547 (validate_x_resource_name): Simplify count usage.
13548 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13549
37dd57d1
PE
13550 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13551 fail (Bug#8306).
81e56e61 13552
699979fc 13553 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13554
401bf9b4
PE
13555 * process.c (Fmake_network_process): Use socklen_t, not int,
13556 where POSIX says socklen_t is required in portable programs.
13557 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13558 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13559 (Fmake_network_process, server_accept_connection):
13560 (wait_reading_process_output, read_process_output):
13561 Likewise.
13562
b93aacde
PE
13563 * process.c: Rename or move locals to avoid shadowing.
13564 (list_processes_1, Fmake_network_process):
13565 (read_process_output_error_handler, exec_sentinel_error_handler):
13566 Rename or move locals.
4dc343ee 13567 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13568 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13569 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13570 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13571 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13572
af8a867c 13573 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13574 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13575 Include tparam.h instead, since it declares them.
af8a867c
PE
13576 * cm.h (PC): Remove extern decl; tparam.h now does this.
13577 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13578 * terminfo.c: Include tparam.h, to check interfaces.
13579 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13580 (tparam): Adjust signature to match interface in tparam.h;
13581 this removes some undefined behavior. Check that outstring and len
13582 are zero, which they always are with Emacs.
13583 * tparam.h (PC, BC, UP): New extern decls.
13584
0248044d 13585 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13586 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13587
8ff096c1 13588 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13589 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13590 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13591 (ftfont_list): Remove unused local.
49eaafba
PE
13592 (get_adstyle_property, ftfont_pattern_entity):
13593 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13594 Rename locals to avoid shadowing.
8ff096c1 13595
e2be39f6
PE
13596 * xfont.c (xfont_list_family): Mark var as initialized.
13597
c9735e30
PE
13598 * xml.c (make_dom): Now static.
13599
8f5201ae
PE
13600 * composite.c (composition_compute_stop_pos): Rename local to
13601 avoid shadowing.
b246f932
PE
13602 (composition_reseat_it): Remove unused locals.
13603 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13604 (composition_update_it): Mark var as initialized.
11b61122
PE
13605 (find_automatic_composition): Mark vars as initialized,
13606 with a FIXME (Bug#8290).
8f5201ae 13607
760fbc2c
PE
13608 character.h: Rename locals to avoid shadowing.
13609 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13610 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13611 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13612 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13613 to avoid shadowing.
13614
ff08eb85
PE
13615 * textprop.c (property_change_between_p): Remove; unused.
13616
fc7bf025
PE
13617 * intervals.c (interval_start_pos): Now static.
13618
235d7abc
PE
13619 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13620
44f230aa
SM
13621 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13622 Rename locals to avoid shadowing.
3e7d6594 13623
50060332
PE
13624 * sound.c (wav_play, au_play, Fplay_sound_internal):
13625 Fix pointer signedness.
d01f234b 13626 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13627 (wav_play): Initialize a variable to 0, to prevent undefined
13628 behavior (Bug#8278).
50060332 13629
c4fc4e30
PE
13630 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13631
918436ed
PE
13632 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13633
c939f91b
PE
13634 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13635 clobbering (Bug#8298).
b9c7f648
PE
13636 * sysdep.c (sys_subshell): Likewise.
13637 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13638
6bd8c144
PE
13639 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13640 This should get cleaned up, so that child_setup has the
13641 same signature on all platforms.
13642
7710357c 13643 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13644 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13645
c59da222
CY
136462011-03-22 Chong Yidong <cyd@stupidchicken.com>
13647
13648 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13649 not to be necessary, and produces flickering.
13650
66b87493
GM
136512011-03-20 Glenn Morris <rgm@gnu.org>
13652
13653 * config.in: Remove file.
13654
45b6f6d5
JB
136552011-03-20 Juanma Barranquero <lekktu@gmail.com>
13656
13657 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13658 are now in src/globals.h.
13659 (syms_of_minibuf): Remove spurious & from previous change.
13660
cd394be1 136612011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13662
13663 * minibuf.c (completing-read-function): New variable.
13664 (completing-read-default): Rename from completing-read.
13665 (completing-read): Call completing-read-function.
13666
b14e3e21
CY
136672011-03-19 Juanma Barranquero <lekktu@gmail.com>
13668
13669 * xfaces.c (Fx_load_color_file):
13670 Read color file from absolute filename (bug#8250).
13671
f2b726e6
JB
136722011-03-19 Juanma Barranquero <lekktu@gmail.com>
13673
13674 * makefile.w32-in: Update dependencies.
13675
09f6ff02
EZ
136762011-03-17 Eli Zaretskii <eliz@gnu.org>
13677
13678 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13679
29a6015a
PE
136802011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13681
a3a6c54e
PE
13682 Fix more problems found by GCC 4.5.2's static checks.
13683
b766f867
PE
13684 * process.c (make_serial_process_unwind, send_process_trap):
13685 (sigchld_handler): Now static.
13686
be02381c
PE
13687 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13688 That way, the code declares only the vars that it needs.
13689 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13690 * s/cygwin.h (PTY_ITERATION): Likewise.
13691 * s/darwin.h (PTY_ITERATION): Likewise.
13692 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13693
57048744
PE
13694 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13695 * process.c (allocate_pty): Don't declare stb unless it's needed.
13696
7914961c 13697 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13698 (CONSTANTLIM): Remove; unused.
13699 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13700 Define only if needed.
7914961c 13701
b3967b18
PE
13702 * unexelf.c (unexec): Name an expression,
13703 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13704 Use a different way to cause a compilation error if anyone uses
13705 n rather than nn, a way that does not involve shadowing.
73366a00 13706 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13707
29a6015a
PE
13708 * deps.mk (unexalpha.o): Remove; unused.
13709
43cfc33e 13710 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13711 * unexec.h: New file.
ce701a33
PE
13712 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13713 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13714 Depend on unexec.h.
13715 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13716 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13717 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13718 Change as necessary to match prototype in unexec.h.
ce701a33 13719
01f44d5a
PE
13720 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13721 shadowing.
4f63c6bb 13722 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13723
a6670b0b
PE
13724 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13725 Rename locals to avoid shadowing.
13726
cef2010d 13727 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13728 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13729
d4d7173a
PE
13730 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13731
f08b802a
PE
13732 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13733 warning when compiling print.c.
13734
3ddb0639
PE
13735 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13736 instead of using an uninitialized var.
5ad03b97 13737 (font_sort_entities): Mark var as initialized.
3ddb0639 13738
170a2692
PE
13739 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13740
e663c700
PE
13741 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13742 pointers to constants.
89bc529a 13743 (font_parse_fcname): Remove unused vars.
7b81e2d0 13744 (font_delete_unmatched): Now static.
ea838e10 13745 (font_get_spec): Remove; unused.
13a547c6
PE
13746 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13747 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13748 Rename or move locals to avoid shadowing.
e663c700 13749
2a80c887 13750 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13751 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13752
1384fa33 13753 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13754 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13755
8b2c52e9
PE
13756 * alloc.c (mark_backtrace): Move decl from here ...
13757 * lisp.h: ... to here, so that it can be checked.
13758
475545b5 13759 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13760 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13761 (lisp_indirect_variable): Name an expression,
13762 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13763 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13764
b1349114 13765 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13766 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13767 Use const pointer when appropriate.
b1349114 13768
a2928364
PE
13769 * lisp.h (get_system_name, get_operating_system_release):
13770 Move decls here, to check interfaces.
13771 * process.c (get_operating_system_release): Move decl to lisp.h.
13772 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13773 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13774 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13775 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13776 (Fformat_time_string, Fencode_time, Finsert_char):
13777 (Ftranslate_region_internal, Fformat):
13778 Rename or remove local vars to avoid shadowing.
9710023e 13779 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13780
a415e694
PE
13781 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13782 avoid shadowing.
13783
8ef4622d
PE
13784 * lisp.h (eassert): Check that the argument compiles, even if
13785 ENABLE_CHECKING is not defined.
13786
946f9a5b
PE
13787 * data.c (Findirect_variable): Name an expression, to avoid
13788 gcc -Wbad-function-cast warning.
112396d6 13789 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13790 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13791 (Fmake_variable_buffer_local, Fmake_local_variable):
13792 Mark variables as initialized.
52746918 13793 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13794
e5aab7e7 13795 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13796 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13797 Rename locals to avoid shadowing.
dff45157
PE
13798 (mark_stack): Move local variables into the #ifdef region where
13799 they're used.
7bc26fdb
PE
13800 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13801 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13802 needed otherwise.
13803 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13804 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13805 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13806
e5aab7e7
PE
13807 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13808 avoids undefined behavior in theory.
13809
4da60324
PE
13810 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13811
88043301
PE
13812 Use functions, not macros, for up- and down-casing (Bug#8254).
13813 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13814 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13815 to use the following functions instead of these macros.
13816 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13817 EMACS_INT, since callers assume the returned value fits in int.
13818 (upcase1): Likewise, for UPCASE_TABLE.
13819 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13820 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13821 the race-condition problem in the old DOWNCASE.
88043301 13822
19ed5445
PE
13823 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13824 Rename locals to avoid shadowing.
13825 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13826 (regex_compile, re_search_2, re_match_2_internal):
13827 Remove unused local vars.
952db0d7
PE
13828 (FREE_VAR): Rewrite so as not to use empty "else",
13829 which gcc can warn about.
da053e48 13830 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13831 (RETALLOC_IF): Define only if needed.
13832 (WORDCHAR_P): Likewise. This one is never needed, but is used
13833 only in a comment talking about a compiler bug, so put inside
13834 the #if 0 of that comment.
13835 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13836 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13837 Remove; unused.
19ed5445 13838
1f3561e4 13839 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13840 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13841 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13842
ded6f8f7
PE
13843 * search.c (simple_search): Remove unused var.
13844
dbd37a95
PE
13845 * dired.c (compile_pattern): Move decl from here ...
13846 * lisp.h: ... to here, so that it can be checked.
13847 (struct re_registers): New forward decl.
13848
7e47afad
PE
13849 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13850
85f24f61
PE
13851 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13852 All uses changed.
13853 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13854 Rename locals to avoid shadowing.
5671df8f 13855 (Fvertical_motion): Mark locals as initialized.
85f24f61 13856
181aa2be 13857 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13858 (casify_region): Mark local as initialized.
181aa2be 13859
930d429c
PE
13860 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13861
7082eac6
PE
13862 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13863 New macros, so that the caller can use some names other than
13864 gcpro1, gcpro2, etc.
13865 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13866 of the new macros.
13867 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13868 argument, for consistency with GCPRO2_VAR, etc: it is now the
13869 prefix of the variable, not the variable itself. All uses
13870 changed.
38b2c076
PE
13871 * dired.c (directory_files_internal, file_name_completion):
13872 Rename locals to avoid shadowing.
13873
15206ed9
PE
13874 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13875 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13876 dired.c's scmp function, had undefined behavior.
13877 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13878 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13879 * buffer.h: ... to here, because these macros use current_buffer,
13880 and the new implementation with inline functions needs to have
13881 current_buffer in scope now, rather than later when the macros
13882 are used.
13883 (downcase, upcase1): New static inline functions.
13884 (DOWNCASE, UPCASE1): Reimplement using these functions.
13885 This avoids undefined behavior in expressions like
13886 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13887 from race conditions in accessing the global variables
13888 case_temp1 and case_temp2.
13889 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13890 * lisp.h (case_temp1, case_temp2): Remove their decls.
13891 * character.h (ASCII_CHAR_P): Move from here ...
13892 * lisp.h: ... to here, so that the inline functions mentioned
13893 above can use them.
13894
4a6bea26
PE
13895 * dired.c (directory_files_internal_unwind): Now static.
13896
f14b7e14
PE
13897 * fileio.c (file_name_as_directory, directory_file_name):
13898 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13899 Now static.
2893f146
PE
13900 (file_name_as_directory): Use const pointers when appropriate.
13901 (Fexpand_file_name): Likewise. In particular, newdir might
13902 point at constant storage, so make it a const pointer.
fd4ead52 13903 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13904 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13905 signedness issues.
f839df0c
PE
13906 (Fset_file_times, Finsert_file_contents, auto_save_error):
13907 Rename locals to avoid shadowing.
f14b7e14 13908
5716756e 13909 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13910 (Ftry_completion, Fall_completions): Rename or remove locals
13911 to avoid shadowing.
5716756e 13912
b4c3046a
PE
13913 * marker.c (bytepos_to_charpos): Remove; unused.
13914
b45db522
PE
13915 * lisp.h (verify_bytepos, count_markers): New decls,
13916 so that gcc does not warn that these functions aren't declared.
13917
85876d07
PE
13918 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13919 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13920 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13921 (copy_text): Remove unused local var.
85876d07 13922
03d78a21 13923 * filelock.c (within_one_second): Now static.
b3dd38ab 13924 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13925
5df8f01b
PE
13926 * buffer.c (fix_overlays_before): Mark locals as initialized.
13927 (fix_start_end_in_overlays): Likewise. This function should be
13928 simplified by using pointers-to-pointers, but that's a different
13929 matter.
b1d876f1 13930 (switch_to_buffer_1): Now static.
8f54f30a
PE
13931 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13932 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13933
a70072c9 13934 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13935 Fix pointer signedness issue.
edced198
PE
13936 (sys_subshell): Mark local as volatile if checking for lint,
13937 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13938 (MAXPATHLEN): Define only if needed.
a70072c9 13939
a0977c44
PE
13940 * process.c (serial_open, serial_configure): Move decls from here ...
13941 * systty.h: ... to here, so that they can be checked.
13942
a884fdcc
PE
13943 * fns.c (get_random, seed_random): Move extern decls from here ...
13944 * lisp.h: ... to here, so that they can be checked.
13945
604efe86 13946 * sysdep.c (reset_io): Now static.
b8950c94 13947 (wait_for_termination_signal): Remove; unused.
604efe86 13948
38fc62d9
PE
13949 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13950 (copy_keymap_item, append_key, push_text_char_description):
13951 Now static.
1004a21a 13952 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13953 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13954 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13955 (describe_map_tree):
13956 Rename locals to avoid shadowing.
38fc62d9 13957
2f2650da
PE
13958 * keyboard.c: Declare functions static if they are not used elsewhere.
13959 (echo_char, echo_dash, cmd_error, top_level_2):
13960 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13961 (read_char, kbd_buffer_get_event, make_lispy_position):
13962 (make_lispy_event, make_lispy_movement, apply_modifiers):
13963 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13964 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13965 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13966 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13967 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13968
a053e86c 13969 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13970 (mark_kboards): Move decl here ...
13971 * alloc.c (mark_kboards): ... from here.
a053e86c 13972
4752793e
PE
13973 * lisp.h (force_auto_save_soon): New decl.
13974
74f10ca7 13975 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13976 (DEFINE_DUMMY_FUNCTION): New macro.
13977 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13978 Use it.
c03cd23f
PE
13979 (main): Add casts to avoid warnings
13980 if GCC considers string literals to be constants.
74f10ca7 13981
022e70d4
PE
13982 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13983
59d6fe83
PE
13984 * dbusbind.c: Pointer signedness fixes.
13985 (xd_signature, xd_append_arg, xd_initialize):
13986 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13987 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13988 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13989 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13990
78320123
PE
13991 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13992 if GCC considers string literals to be constants.
49cebcca 13993 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13994
35ac2a97
SM
139952011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13996
fb103ca9
SM
13997 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13998 (print_preprocess, print_object): New macro to fix last change.
13999
35ac2a97
SM
14000 * print.c (print_preprocess): Don't forget font objects.
14001
62973b41
JB
140022011-03-16 Juanma Barranquero <lekktu@gmail.com>
14003
14004 * emacs.c (USAGE3): Doc fixes.
14005
0e48bb22
AS
140062011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14007
14008 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14009 structure.
14010
7684e57b
JB
140112011-03-14 Juanma Barranquero <lekktu@gmail.com>
14012
14013 * lisp.h (VWindow_system, Qfile_name_history):
14014 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14015 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14016 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14017
14018 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14019 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14020
14021 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14022 * w32console.c (detect_input_pending, read_input_pending)
14023 (encode_terminal_code):
14024 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14025 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14026 (w32_system_caret_y, Qfile_name_history):
14027 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14028 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14029 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14030 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14031 * w32proc.c (Qlocal, report_file_error):
14032 * w32term.c (Vwindow_system, updating_frame):
14033 * w32uniscribe.c (initialized, uniscribe_font_driver):
14034 Remove unneeded extern declarations.
14035
2aa46d6c
CY
140362011-03-14 Chong Yidong <cyd@stupidchicken.com>
14037
c96bbc66 14038 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14039
cffc6f3b
CY
140402011-03-13 Chong Yidong <cyd@stupidchicken.com>
14041
14042 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14043 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14044 These macros can no longer be used for assignment.
14045
44f230aa
SM
14046 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14047 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14048 (record_buffer_markers, fetch_buffer_markers): New functions for
14049 recording and fetching special buffer markers.
14050 (set_buffer_internal_1, set_buffer_temp): Use them.
14051
14052 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14053
14054 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14055
14056 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14057 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14058
14059 * xdisp.c (hscroll_window_tree):
14060 (reconsider_clip_changes): Use PT instead of BUF_PT.
14061
d251f04b
EZ
140622011-03-13 Eli Zaretskii <eliz@gnu.org>
14063
14064 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14065 $(EMACS_ROOT)/lib/intprops.h.
14066
f0c77cd1
PE
140672011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14068
3eca4629
PE
14069 Fix more problems found by GCC 4.5.2's static checks.
14070
7c86ee98
PE
14071 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14072 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14073 (xg_free_frame_widgets): Make it clear that a local variable is
14074 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14075 (gdk_window_get_screen): Make it clear that this macro is needed
14076 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14077 (int_gtk_range_get_value): New function, which avoids a diagnostic
14078 from gcc -Wbad-function-cast.
14079 (xg_set_toolkit_scroll_bar_thumb): Use it.
14080 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14081 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14082 (get_utf8_string, xg_get_file_with_chooser):
14083 Rename locals to avoid shadowing.
14084 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14085
41729b81
PE
14086 * xgselect.c (xg_select): Remove unused var.
14087
f0c77cd1
PE
14088 * image.c (four_corners_best): Mark locals as initialized.
14089 (gif_load): Initialize transparent_p to zero (Bug#8238).
14090 Mark another local as initialized.
ec6cf4c6 14091 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14092
ce0ad53d 14093 * image.c (clear_image_cache): Now static.
d5d5a617 14094 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14095 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14096 (x_edge_detection): Remove unnecessary cast that
14097 gcc -Wbad-function-cast diagnoses.
2037898d 14098 (gif_load): Fix pointer signedness.
6ae141d6
PE
14099 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14100 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14101
33383987 141022011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14103
d32df629
PE
14104 Improve quality of tests for time stamp overflow.
14105 For example, without this patch (encode-time 0 0 0 1 1
14106 1152921504606846976) returns the obviously-bogus value (-948597
14107 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14108 reports time overflow. See
14109 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14110 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14111 * editfns.c: Include limits.h and intprops.h.
14112 (TIME_T_MIN, TIME_T_MAX): New macros.
14113 (time_overflow): Move earlier, to before first use.
14114 (hi_time, lo_time): New functions, for an accurate test for
14115 out-of-range times.
14116 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14117 (Fget_internal_run_time): Don't assume time_t fits in int.
14118 (make_time): Use list2 instead of Fcons twice.
14119 (Fdecode_time): More accurate test for out-of-range times.
14120 (check_tm_member): New function.
14121 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14122 (lisp_time_argument): Don't rely on undefined left-shift and
14123 right-shift behavior when checking for time stamp overflow.
8be6f318 14124
fe31d94c
PE
14125 * editfns.c (time_overflow): New function, refactoring common code.
14126 (Fformat_time_string, Fdecode_time, Fencode_time):
14127 (Fcurrent_time_string): Use it.
14128
8be6f318
PE
14129 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14130 * dired.c (make_time): Move to ...
14131 * editfns.c (make_time): ... here.
14132 * systime.h: Note the move.
14133
09d9db2c 141342011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14135
126bc0dc
YM
14136 * fringe.c (update_window_fringes): Remove unused variables.
14137
c47cbdfd
YM
14138 * unexmacosx.c (copy_data_segment): Also copy __got section.
14139 (Bug#8223)
14140
7ac80be9
EZ
141412011-03-12 Eli Zaretskii <eliz@gnu.org>
14142
c96bbc66 14143 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14144 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14145 Constify `char *' arguments and their references according to
14146 prototypes in tparam.h.
14147
ecb0f94d 14148 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14149
7ac80be9
EZ
14150 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14151 Adapt all references accordingly.
14152
14153 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14154
ef1fd07e
TT
141552011-03-11 Tom Tromey <tromey@redhat.com>
14156
14157 * buffer.c (syms_of_buffer): Remove obsolete comment.
14158
7ef4b50c
EZ
141592011-03-11 Eli Zaretskii <eliz@gnu.org>
14160
14161 * termhooks.h (encode_terminal_code): Declare prototype.
14162
14163 * msdos.c (encode_terminal_code): Don't declare prototype.
14164
14165 * term.c (encode_terminal_code): Now external again, used by
14166 w32console.c and msdos.c.
14167
44f230aa
SM
14168 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14169 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14170
4b1ec863 141712011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14172
1714f52b 14173 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14174
4b1ec863
PE
14175 * fringe.c (update_window_fringes): Mark locals as initialized
14176 (Bug#8227).
14177 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14178
524c7aa6
PE
14179 * alloc.c (mark_fringe_data): Move decl from here ...
14180 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14181 to check its interface.
14182 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14183
a5c0af81 14184 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14185 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14186 (fontset_font): Mark local as initialized.
a9a06e0b 14187 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14188
b4716021
PE
14189 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14190
811e9bac 14191 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14192 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14193 (x_own_selection, Fx_disown_selection_internal): Rename locals
14194 to avoid shadowing.
14195 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14196
7e3ab302
PE
14197 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14198 so that the caller can use some name other than gcpro1.
14199 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14200 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14201 (Fx_backspace_delete_keys_p):
14202 Use them to avoid shadowing, and rename vars to avoid shadowing.
14203 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14204 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14205 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14206 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14207 Remove unused locals.
7e3ab302
PE
14208 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14209 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14210 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14211 macros.
f78faa98 14212
e2b13473
PE
14213 * xterm.h (x_mouse_leave): New decl.
14214
77f23912
PE
14215 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14216 Remove unused functions.
cdf4ba58
PE
14217 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14218 (x_calc_absolute_position): Now static.
7411c686 14219 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14220 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14221 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14222 unless they are used.
38d0b34a
PE
14223 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14224 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14225 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14226 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14227 (x_error_catcher, x_connection_closed, x_error_handler):
14228 (x_error_quitter, xembed_send_message, x_iconify_frame):
14229 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14230 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14231 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14232
44f230aa
SM
14233 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14234 Rename or move locals to avoid shadowing.
6b463e58 14235 (tty_defined_color, merge_face_heights): Now static.
5967d051 14236 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14237 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14238 does not deduce is never used uninitialized.
73719eba
PE
14239 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14240 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14241
426994c3 14242 * terminal.c (store_terminal_param): Now static.
5489860b 14243
032f1620 14244 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14245 (set_frame_menubar): Remove unused local.
d4323972 14246 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14247 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14248 since they might point to immutable storage.
281585b0
PE
14249 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14250 since it's unused otherwise.
032f1620 14251
367c19e5 14252 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14253 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14254 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14255 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14256 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14257 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14258 does not deduce are never used uninitialized.
70739cbe 14259
07b48fa9
PE
14260 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14261
8868a238 14262 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14263 * window.c (window_loop, size_window):
14264 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14265
7e5cf297 14266 * window.c (display_buffer): Now static.
d6550a9f
PE
14267 (size_window): Mark variables that gcc -Wuninitialized
14268 does not deduce are never used uninitialized.
a586633d
PE
14269 * window.h (check_all_windows): New decl, to forestall
14270 gcc -Wmissing-prototypes diagnostic.
5b555da1 14271 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14272
f6095868
PE
14273 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14274 shadowing.
14275 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14276 Include <limits.h>.
14277 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14278 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14279 (load_charset_map): Mark variables that gcc -Wuninitialized
14280 does not deduce are never used uninitialized.
53df7c11 14281 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14282
f38b440c
PE
14283 * coding.c (coding_set_source, coding_set_destination):
14284 Use "else { /* comment */ }" rather than "else /* comment */;"
14285 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14286 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14287 a block, when the outer 'i' will do.
14288 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14289 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14290 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14291 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14292 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14293 Rename locals to avoid shadowing.
14294 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14295 * coding.c (emacs_mule_char, encode_invocation_designation):
14296 Now static, since they're not used elsewhere.
413bb2db 14297 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14298 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14299 (decode_coding_emacs_mule): Mark variables that gcc
14300 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14301 (detect_coding_iso_2022): Initialize a local variable that might
14302 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14303 this initialization is needed. (Bug#8211)
5f58e762
PE
14304 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14305 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14306 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14307 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14308 Remove unused macros.
f38b440c 14309
232b38b9 14310 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14311 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14312 * character.c (string_count_byte8): Likewise.
232b38b9 14313
fb90da1b
PE
14314 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14315 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14316
fb93dbc2
PE
14317 * chartab.c (copy_sub_char_table): Now static, since it's not used
14318 elsewhere.
5c156ace
PE
14319 (sub_char_table_ref_and_range, char_table_ref_and_range):
14320 Rename locals to avoid shadowing.
bbcd0949 14321 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14322
7d3b3862 14323 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14324 (BIDI_BOB): Remove unused macro.
7d3b3862 14325
6be7d3da
PE
14326 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14327 deduce are never used uninitialized.
c2ed9c8b 14328 * term.c (encode_terminal_code): Likewise.
6be7d3da 14329
75f8807f 14330 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14331
50938595
PE
14332 * tparam.h: New file.
14333 * term.c, tparam.h: Include it.
14334 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14335 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14336 Move these decls to tparam.h, and make them agree with what
14337 is actually in tparam.c. The previous trick of using incompatible
14338 decls in different modules does not conform to the C standard.
14339 All callers of tparam changed to use tparam's actual API.
14340 * tparam.c (tparam1, tparam, tgoto):
14341 Use const pointers where appropriate.
14342
fbceeba2
PE
14343 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14344 * cm.h (struct cm): Likewise.
14345 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14346 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14347 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14348 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14349 (turn_on_face, init_tty): Likewise.
14350 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14351
7f3f1250
PE
14352 * term.c (term_mouse_position): Rename local to avoid shadowing.
14353
e6ca6543
PE
14354 * alloc.c (mark_ttys): Move decl from here ...
14355 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14356
c40f8d15
AS
143572011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14358
14359 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14360
cfe0661d
JB
143612011-03-09 Juanma Barranquero <lekktu@gmail.com>
14362
14363 * search.c (compile_pattern_1): Remove argument regp, unused since
14364 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14365 (compile_pattern): Don't pass it.
14366
0afb4571
J
143672011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14368
14369 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14370 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14371 for ! HAVE_GTK3.
14372 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14373
14374 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14375
14376 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14377 gdk_window_get_screen, gdk_window_get_geometry,
14378 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14379 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14380 (xg_get_pixbuf_from_pixmap): New function.
14381 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14382 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14383 Call xg_get_pixbuf_from_pixmap instead of
14384 gdk_pixbuf_get_from_drawable.
14385 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14386 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14387 (xg_check_special_colors): Use GtkStyleContext and its functions
14388 for HAVE_GTK3.
14389 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14390 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14391 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14392 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14393 Call gtk_widget_get_preferred_size.
0afb4571
J
14394 (xg_frame_resized): gdk_window_get_geometry only takes 5
14395 parameters.
44f230aa
SM
14396 (xg_win_to_widget, xg_event_is_for_menubar):
14397 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14398 (xg_set_widget_bg): New function.
14399 (delete_cb): New function.
895009e1 14400 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14401 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14402 (xg_set_background_color): Call xg_set_widget_bg.
14403 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14404 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14405 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14406 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14407 if ! HAVE_GTK3.
14408 (update_frame_tool_bar): Call gtk_widget_hide.
14409 (xg_initialize): Use GDK_KEY_g.
14410
14411 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14412 if ! HAVE_GTK3
14413 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14414
14415 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14416 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14417 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14418
1c2cc4ef
JB
144192011-03-08 Juanma Barranquero <lekktu@gmail.com>
14420
14421 * w32xfns.c (select_palette): Check success of RealizePalette against
14422 GDI_ERROR, not zero.
14423
33383987 14424See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14425
14426;; Local Variables:
14427;; coding: utf-8
aac0c6e3
MR
14428;; End:
14429
2f097256 14430 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14431
14432 This file is part of GNU Emacs.
14433
14434 GNU Emacs is free software: you can redistribute it and/or modify
14435 it under the terms of the GNU General Public License as published by
14436 the Free Software Foundation, either version 3 of the License, or
14437 (at your option) any later version.
14438
14439 GNU Emacs is distributed in the hope that it will be useful,
14440 but WITHOUT ANY WARRANTY; without even the implied warranty of
14441 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14442 GNU General Public License for more details.
14443
14444 You should have received a copy of the GNU General Public License
14445 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.