Merge from trunk.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
ca4aa935
PE
12011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2
41f55ccd 3 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 4
5e927815
PE
5 * alloc.c (__malloc_size_t): Remove.
6 All uses replaced by size_t. See Andreas Schwab's note
7 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8
ca4aa935
PE
9 * image.c: Improve checking for integer overflow.
10 (check_image_size): Assume that f is nonnull, since
11 it is always nonnull in practice. This is one less thing to
12 worry about when checking for integer overflow later.
13 (x_check_image_size): New function, which checks for integer
14 overflow issues inside X.
15 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
16 This removes the need for a memory_full check.
17 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
18 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
19 (xbm_read_bitmap_data): Change locals back to 'int', since
20 their values must fit in 'int'.
21 (xpm_load_image, png_load, tiff_load):
22 Invoke x_create_x_image_and_pixmap earlier,
23 to avoid much needless work if the image is too large.
24 (tiff_load): Treat overly large images as if
25 x_create_x_image_and_pixmap failed, not as malloc failures.
26 (gs_load): Use x_check_image_size.
27
5f8f9cc2
PE
28 * gtkutil.c: Omit integer casts.
29 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
30 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
31
5adf60bc
PE
32 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
33
c8907a93
PE
34 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
35 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
36 would wrongly return t on a 64-bit host.
37
e3c25c68
PE
38 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
39 The plain *_OVERFLOW macros run afoul of GCC bug 49705
40 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
41 and therefore cause GCC to emit a bogus diagnostic in some cases.
42
3f791afe
PE
43 * image.c: Integer signedness and overflow and related fixes.
44 This is not an exhaustive set of fixes, but it's time to
45 record what I've got.
46 (lookup_pixel_color, check_image_size): Remove redundant decls.
47 (check_image_size): Don't assume that arbitrary EMACS_INT values
48 fit in 'int', or that arbitrary 'double' values fit in 'int'.
49 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
50 (tiff_load, imagemagick_load_image):
51 Check for overflow in size calculations.
52 (x_create_x_image_and_pixmap): Remove unnecessary test for
53 xmalloc returning NULL; that can't happen.
54 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
55 (xpm_color_bucket): Use better integer hashing function.
56 (xpm_cache_color): Don't possibly over-allocate memory.
57 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
58 (gif_memory_source):
59 Use ptrdiff_t, not int or size_t, to record sizes.
60 (png_load): Don't assume values greater than 2**31 fit in 'int'.
61 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
62 either works, as we prefer signed integers.
63 (tiff_read_from_memory, tiff_write_from_memory):
64 Return tsize_t, not size_t, since that's what the TIFF API wants.
65 (tiff_read_from_memory): Don't fail simply because the read would
66 go past EOF; instead, return a short read.
67 (tiff_load): Omit no-longer-needed casts.
68 (Fimagemagick_types): Don't assume size fits into 'int'.
69
3cc5a532
PE
70 Improve hashing quality when configured --with-wide-int.
71 * fns.c (hash_string): New function, taken from sxhash_string.
72 Do not discard information about ASCII character case; this
73 discarding is no longer needed.
74 (sxhash-string): Use it. Change sig to match it. Caller changed.
75 * lisp.h: Declare it.
76 * lread.c (hash_string): Remove, since we now use fns.c's version.
77 The fns.c version returns a wider integer if --with-wide-int is
78 specified, so this should help the quality of the hashing a bit.
79
b312a492
PE
80 * emacs.c: Integer overflow minor fix.
81 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
82 Define only if GNU_LINUX.
83 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
84
dfd153ae
PE
85 * dispnew.c: Integer signedness and overflow fixes.
86 Remove unnecessary forward decls, that were a maintenance hassle.
87 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
88 All uses changed.
89 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
90 (scrolling_window): Use ptrdiff_t, not int, for byte count.
91 (prepare_desired_row, line_draw_cost):
92 Use int, not unsigned, where either works.
93 (save_current_matrix, restore_current_matrix):
94 Use ptrdiff_t, not size_t, where either works.
95 (init_display): Check for overflow more accurately, and without
96 relying on undefined behavior.
97
a81d11a3
PE
98 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
99 Remove, replacing with the new symbols in lisp.h. All uses changed.
100 * fileio.c (make_temp_name):
101 * filelock.c (lock_file_1, lock_file):
102 * xdisp.c (message_dolog):
103 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
104 Use pMd etc. instead.
105 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
106 replacing the pWIDE etc. symbols removed from editfns.c.
107
3300e6fd
PE
108 * keyboard.h (num_input_events): Now uintmax_t.
109 This is (very slightly) less likely to mess up due to wraparound.
110 All uses changed.
111
fd05c7e9
PE
112 * buffer.c: Integer signedness fixes.
113 (alloc_buffer_text, enlarge_buffer_text):
114 Use ptrdiff_t rather than size_t when either will do, as we prefer
115 signed integers.
116
903fe15d
PE
117 * alloc.c: Integer signedness and overflow fixes.
118 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
119 (__malloc_size_t): Default to size_t, not to int.
120 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
121 (Fgarbage_collect, mark_object_loop_halt, mark_object):
122 Prefer ptrdiff_t to size_t when either would do, as we prefer
123 signed integers.
124 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
125 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
126 Now const. Initialize with values that are in range even if char
127 is signed.
128 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
129 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
130 These functions do the right thing with sizes > 2**32.
131 (check_depth): Now ptrdiff_t, not int.
132 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
133 Adjust to new way of storing sizes. Check for size overflow bugs
134 in rest of code.
135 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
136 slightly wrong anyway, as it missed one instance of
137 XMALLOC_OVERRUN_CHECK_OVERHEAD.
138 (refill_memory_reserve): Omit needless cast to size_t.
139 (mark_object_loop_halt): Mark as externally visible.
140
ac82cc6a
PE
141 * xselect.c: Integer signedness and overflow fixes.
142 (Fx_register_dnd_atom, x_handle_dnd_message):
143 Use ptrdiff_t, not size_t, since we prefer signed.
144 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
145 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
146 x_dnd_atoms_size and x_dnd_atoms_length.
147
c2d1e36d
PE
148 * doprnt.c: Prefer signed to unsigned when either works.
149 * eval.c (verror):
150 * doprnt.c (doprnt):
151 * lisp.h (doprnt):
152 * xdisp.c (vmessage):
153 Use ptrdiff_t, not size_t, when using or implementing doprnt,
154 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
155 prefer signed arithmetic to avoid comparison confusion.
156 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
157 but is a bit tricky.
158
0e926e56
PE
159 Assume freestanding C89 headers, string.h, stdlib.h.
160 * data.c, doprnt.c, floatfns.c, print.c:
161 Include float.h unconditionally.
162 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
163 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
164 * regex.c: Likewise for stddef.h, string.h.
165 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
166 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
167 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
168 (STDC_HEADERS): Remove obsolete defines.
169 * sysdep.c: Include limits.h unconditionally.
170
9cfdb3ec
PE
171 Assume support for memcmp, memcpy, memmove, memset.
172 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
173 * regex.c (memcmp, memcpy):
174 Remove; we assume C89 now.
175
176 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
177 (__malloc_safe_bcopy): Remove; no longer needed.
178
cf950e6b 179 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
180 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
181 well either way, and we prefer signed to unsigned.
182
5d856da6
PE
1832011-07-14 Paul Eggert <eggert@cs.ucla.edu>
184
ad6042bb
PE
185 Fix minor problems found by static checking.
186 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
187 (elsz): Now a signed constant, not a size_t var. We prefer signed
188 types to unsigned, to avoid integer comparison confusion. Without
189 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
190 "cannot optimize loop, the loop counter may overflow", a symptom
191 of the confusion.
f00bbb22 192 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
193 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
194
6468f31c
LMI
1952011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
196
2fd0959d
LMI
197 * data.c (Fcdr, Fcar): Revert the last change, since it didn't
198 really clarify much.
199
49080b10
LMI
200 * search.c (Fre_search_backward): Mention `case-fold-search' in
201 all the re_search_* functions (bug#8138).
202
6468f31c
LMI
203 * keyboard.c (Fopen_dribble_file): Document when the file is
204 closed (bug#8056).
205
c965adc5
EZ
2062011-07-14 Eli Zaretskii <eliz@gnu.org>
207
df9733bf
EZ
208 * bidi.c (bidi_dump_cached_states): Fix format of displaying
209 bidi_cache_idx.
210
0bb23927
EZ
211 Support bidi reordering of display and overlay strings.
212 * xdisp.c (compute_display_string_pos)
213 (compute_display_string_end): Accept additional argument STRING.
214 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
215 (reseat_to_string): Initialize bidi_it->string.s and
216 bidi_it->string.schars.
217 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
218 NULL (avoids a crash in bidi_paragraph_init). Initialize
219 itb.string.lstring.
220 (init_iterator): Call bidi_init_it only of a valid
221 buffer position was specified. Initialize paragraph_embedding to
222 L2R.
223 (reseat_to_string): Initialize the bidi iterator.
224 (display_string): If we need to ignore text properties of
225 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
226 original value of -1 will not work with bidi.)
227 (compute_display_string_pos): First arg is now struct
228 `text_pos *'; all callers changed. Support display properties on
229 Lisp strings.
230 (compute_display_string_end): Support display properties on Lisp
231 strings.
232 (init_iterator, reseat_1, reseat_to_string): Initialize the
233 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
234 when iterating on a string not from display properties).
235 (compute_display_string_pos, compute_display_string_end): Fix
236 calculation of the object to scan. Fixes an error when using
237 arrow keys.
238 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
239 base_level_stop; instead, set base_level_stop to BEGV. Fixes
240 crashes in vertical-motion.
241 (next_element_from_buffer): Improve commentary for when
242 the iterator is before prev_stop.
243 (init_iterator): Initialize bidi_p from the default value of
244 bidi-display-reordering, not from buffer-local value. Use the
245 buffer-local value only if initializing for buffer iteration.
246 (handle_invisible_prop): Support invisible properties on strings
247 that are being bidi-reordered.
248 (set_iterator_to_next): Support bidi reordering of C strings and
249 Lisp strings.
250 (next_element_from_string): Support bidi reordering of Lisp
251 strings.
252 (handle_stop_backwards): Support Lisp strings as well.
253 (display_string): Support display of R2L glyph rows. Use
254 IT_STRING_CHARPOS when displaying from a Lisp string.
255 (init_iterator): Don't initialize it->bidi_p for strings
256 here.
257 (reseat_to_string): Initialize it->bidi_p for strings here.
258 (next_element_from_string, next_element_from_c_string)
259 (next_element_from_buffer): Add xassert's for correspondence
260 between IT's object being iterated and it->bidi_it.string
261 structure.
262 (face_before_or_after_it_pos): Support bidi iteration.
263 (next_element_from_c_string): Handle the case of the first string
264 character that is not the first one in the visual order.
265 (get_visually_first_element): New function, refactored from common
266 parts of next_element_from_buffer, next_element_from_string, and
267 next_element_from_c_string.
268 (tool_bar_lines_needed, redisplay_tool_bar)
269 (display_menu_bar): Force left-to-right direction. Add a FIXME
270 comment for making that be controlled by a user option.
271 (push_it, pop_it): Save and restore the state of the
272 bidi iterator. Save and restore the bidi_p flag.
273 (pop_it): Iterate out of display property for string iteration as
274 well.
275 (iterate_out_of_display_property): Support iteration over strings.
276 (handle_single_display_spec): Set up it->bidi_it for iteration
277 over a display string, and call bidi_init_it.
278 (handle_single_display_spec, next_overlay_string)
279 (get_overlay_strings_1, push_display_prop): Set up the bidi
280 iterator for displaying display or overlay strings.
281 (forward_to_next_line_start): Don't use the shortcut if
282 bidi-iterating.
283 (back_to_previous_visible_line_start): If handle_display_prop
284 pushed the iterator stack, restore the internal state of the bidi
285 iterator by calling bidi_pop_it same number of times.
286 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
287 and we are bidi-iterating, don't decrement the iterator position;
288 instead, set the first_elt flag in the bidi iterator, to produce
289 the same effect.
290 (reseat_1): Remove redundant setting of string_from_display_prop_p.
291 (push_display_prop): xassert that we are iterating a buffer.
292 (push_it, pop_it): Save and restore paragraph_embedding member.
293 (handle_single_display_spec, next_overlay_string)
294 (get_overlay_strings_1, reseat_1, reseat_to_string)
295 (push_display_prop): Set up the `unibyte' member of bidi_it.string
296 correctly. Don't assume unibyte strings are not bidi-reordered.
297 (compute_display_string_pos)
298 (compute_display_string_end): Fix handling the case of C string.
299 (push_it, pop_it): Save and restore from_disp_prop_p.
300 (handle_single_display_spec, push_display_prop): Set the
301 from_disp_prop_p flag.
302 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
303 (pop_it): Call iterate_out_of_display_property only if we are
304 popping after iteration over a string that came from a display
305 property. Fix a typo in popping stretch info. Add an assertion
306 for verifying that the iterator position is in sync with the bidi
307 iterator.
308 (handle_single_display_spec, get_overlay_strings_1)
309 (push_display_prop): Fix initialization of paragraph direction for
310 string when that of the parent object is not yet determined.
311 (reseat_1): Call bidi_init_it to resync the bidi
312 iterator with IT's position. (Bug#7616)
313 (find_row_edges): If ROW->start.pos gives position
314 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
315 (handle_stop, back_to_previous_visible_line_start, reseat_1):
316 Reset the from_disp_prop_p flag.
317 (SAVE_IT, RESTORE_IT): New macros.
318 (pos_visible_p, face_before_or_after_it_pos)
319 (back_to_previous_visible_line_start)
320 (move_it_in_display_line_to, move_it_in_display_line)
321 (move_it_to, move_it_vertically_backward, move_it_by_lines)
322 (try_scrolling, redisplay_window, display_line): Use them when
323 saving a temporary copy of the iterator and restoring it back.
324 (back_to_previous_visible_line_start, reseat_1)
325 (init_iterator): Empty the bidi cache "stack".
326 (move_it_in_display_line_to): If iterator ended up at
327 EOL, but we never saw any buffer positions smaller than
328 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
329 motion in bidi-reordered lines.
330 (move_it_in_display_line_to): Record prev_method and prev_pos
331 immediately before the call to set_iterator_to_next. Fixes cursor
332 motion in bidi-reordered lines with stretch glyphs and strings
333 displayed in margins. (Bug#8133) (Bug#8867)
334 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
335 TO_CHARPOS.
336 (pos_visible_p): Support positions in bidi-reordered lines. Save
337 and restore bidi cache.
338
339 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
340 (bidi_paragraph_info): Delete unused struct.
341 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
342 (bidi_cache_start): New variable.
343 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
344 to zero.
345 (bidi_cache_fetch_state, bidi_cache_search)
346 (bidi_cache_find_level_change, bidi_cache_iterator_state)
347 (bidi_cache_find, bidi_peek_at_next_level)
348 (bidi_level_of_next_char, bidi_find_other_level_edge)
349 (bidi_move_to_visually_next): Compare cache index with
350 bidi_cache_start rather than with zero.
351 (bidi_fetch_char): Accept new argument STRING; all callers
352 changed. Support iteration over a string. Support strings with
353 display properties. Support unibyte strings. Fix the type of
354 `len' according to what STRING_CHAR_AND_LENGTH expects.
355 (bidi_paragraph_init, bidi_resolve_explicit_1)
356 (bidi_resolve_explicit, bidi_resolve_weak)
357 (bidi_level_of_next_char, bidi_move_to_visually_next): Support
358 iteration over a string.
359 (bidi_set_sor_type, bidi_resolve_explicit_1)
360 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
361 can now be zero (for strings); special values 0 and -1 were
362 changed to -1 and -2, respectively.
363 (bidi_char_at_pos): New function.
364 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
365 Call it instead of FETCH_MULTIBYTE_CHAR.
366 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
367 initialized to valid values.
368 (bidi_init_it): Don't initialize charpos and bytepos with invalid
369 values.
370 (bidi_level_of_next_char): Allow the sentinel "position" to pass
371 the test for valid cached positions. Fix the logic for looking up
372 the sentinel state in the cache. GCPRO the Lisp string we are
373 iterating.
374 (bidi_push_it, bidi_pop_it): New functions.
375 (bidi_initialize): Initialize the bidi cache start stack pointer.
376 (bidi_cache_ensure_space): New function, refactored from part of
377 bidi_cache_iterator_state. Don't assume the required size is just
378 one BIDI_CACHE_CHUNK away.
379 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
380 (bidi_count_bytes, bidi_char_at_pos): New functions.
381 (bidi_cache_search): Don't assume bidi_cache_last_idx is
382 always valid if bidi_cache_idx is valid.
383 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
384 is valid if it's going to be used.
385 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
386 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
387 (bidi_cache_find_level_change, bidi_cache_ensure_space)
388 (bidi_cache_iterator_state, bidi_cache_find)
389 (bidi_find_other_level_edge, bidi_cache_start_stack): All
390 variables related to cache indices are now EMACS_INT.
391
0bb23927
EZ
392 * dispextern.h (struct bidi_string_data): New structure.
393 (struct bidi_it): New member `string'. Make flag members be 1-bit
394 fields, and put them last in the struct.
395 (compute_display_string_pos, compute_display_string_end): Update
396 prototypes.
397 (bidi_push_it, bidi_pop_it): Add prototypes.
398 (struct iterator_stack_entry): New members bidi_p,
399 paragraph_embedding, and from_disp_prop_p.
400 (struct it): Member bidi_p is now a bit field 1 bit wide.
401 (bidi_shelve_cache, bidi_unshelve_cache): Declare
402 prototypes.
403
404 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
405 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
406 and vector-like objects.
407
408 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
409 cache around display iteration.
410
411 * window.c (Fwindow_end, window_scroll_pixel_based)
412 (displayed_window_lines, Frecenter): Save and restore the bidi
413 cache around display iteration.
414
3bbd2265
LMI
4152011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
416
417 * editfns.c (Fdelete_region): Clarify the use of the named
418 parameters (bug#6788).
419
adc47434
MR
4202011-07-14 Martin Rudalics <rudalics@gmx.at>
421
422 * indent.c (Fvertical_motion): Set and restore w->pointm when
423 saving and restoring the window's buffer (Bug#9006).
424
837c31f8
LMI
4252011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
426
427 * editfns.c (Fstring_to_char): Clarify just what is returned
428 (bug#6576). Text by Eli Zaretskii.
429
ac389d0c
JB
4302011-07-13 Juanma Barranquero <lekktu@gmail.com>
431
432 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
433
0be0ce47
EZ
4342011-07-13 Eli Zaretskii <eliz@gnu.org>
435
436 * buffer.c (mmap_find): Fix a typo.
437
cd18e7e3
JB
4382011-07-13 Johan Bockgård <bojohan@gnu.org>
439
440 Fix execution of x selection hooks.
441 * xselect.c (Qx_lost_selection_functions)
442 (Qx_sent_selection_functions): New vars.
443 (syms_of_xselect): DEFSYM them.
444 (x_handle_selection_request): Pass Qx_sent_selection_functions
445 rather than Vx_sent_selection_functions to Frun_hook_with_args.
446 (x_handle_selection_clear,x_clear_frame_selections):
447 Pass Qx_lost_selection_functions rather than
448 Vx_lost_selection_functions to Frun_hook_with_args.
449
47ea7f44
PE
4502011-07-13 Paul Eggert <eggert@cs.ucla.edu>
451
ac389d0c 452 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
453 The old code sometimes used this field without initializing it.
454
47ea7f44
PE
455 * alloc.c (gc_sweep): Don't read past end of array.
456 In theory, the old code could also have corrupted Emacs internals,
457 though it'd be very unlikely.
458
bc985c87
AS
4592011-07-12 Andreas Schwab <schwab@linux-m68k.org>
460
461 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 462 argument. (Bug#4026)
bc985c87 463
0cf34688
LMI
4642011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
465
b3dadd76
LMI
466 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
467 key" (bug#4257).
468
0cf34688
LMI
469 * window.c (Fset_window_start): Doc fix (bug#4199).
470 (Fset_window_hscroll): Ditto.
471
270768cd
PE
4722011-07-12 Paul Eggert <eggert@cs.ucla.edu>
473
077e3dda 474 Fix minor new problems caught by GCC 4.6.1.
270768cd 475 * term.c (init_tty): Remove unused local.
490011a6 476 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 477 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 478 not used otherwise.
270768cd 479
b1f58454
CY
4802011-07-12 Chong Yidong <cyd@stupidchicken.com>
481
482 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
483
22b9578d
LMI
4842011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
485
6e70ab07
LMI
486 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
487 are the mini-buffer and the echo area (bug#3320).
488
22b9578d
LMI
489 * term.c (init_tty): Remove support for supdup, c10 and perq
490 terminals, which are no longer supported (bug#1482).
491
8974cc9f
JB
4922011-07-10 Johan Bockgård <bojohan@gnu.org>
493
494 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
495
a560d974
JD
4962011-07-10 Jan Djärv <jan.h.d@swipnet.se>
497
498 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
499 for non-popups (Bug#3642).
500
1dae0f0a
AS
5012011-07-10 Andreas Schwab <schwab@linux-m68k.org>
502
268c2c36 503 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 504 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
505 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
506 * cm.c (losecursor): Likewise.
1dae0f0a
AS
507 * data.c (fmod): Likewise.
508 * dispnew.c (swap_glyphs_in_rows): Likewise.
509 * emacs.c (memory_warning_signal): Likewise.
510 * floatfns.c (float_error): Likewise.
511 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
512 (otf_open, font_otf_capability, generate_otf_features)
513 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
514 Likewise.
515 * image.c (pbm_read_file): Likewise.
516 * indent.c (string_display_width): Likewise.
517 * intervals.c (check_for_interval, search_for_interval)
518 (inc_interval_count, count_intervals, root_interval)
519 (adjust_intervals_for_insertion, make_new_interval): Likewise.
520 * lread.c (defalias): Likewise.
268c2c36 521 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
522 * regex.c (set_image_of_range_1, set_image_of_range)
523 (regex_grow_registers): Likewise.
524 * sysdep.c (strerror): Likewise.
525 * termcap.c (valid_filename_p, tprint, main): Likewise.
526 * tparam.c (main): Likewise.
527 * unexhp9k800.c (run_time_remap, save_data_space)
528 (update_file_ptrs, read_header, write_header, calculate_checksum)
529 (copy_file, copy_rest, display_header): Likewise.
530 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
531 Likewise.
532 * xdisp.c (check_it): Likewise.
533 * xfaces.c (register_color, unregister_color, unregister_colors):
534 Likewise.
535 * xfns.c (print_fontset_result): Likewise.
536 * xrdb.c (member, fatal, main): Likewise.
537
99033785
PE
5382011-07-10 Paul Eggert <eggert@cs.ucla.edu>
539
540 Fix minor problems found by static checking (Bug#9031).
541 * chartab.c (char_table_set_range, map_sub_char_table):
542 Remove unused locals.
543 (uniprop_table): Now static.
544 * composite.c (_work_char): Remove unused static var.
545
9cb2ac56
JB
5462011-07-09 Juanma Barranquero <lekktu@gmail.com>
547
548 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
549
f25661f0
JD
5502011-07-09 Jan Djärv <jan.h.d@swipnet.se>
551
552 * gtkutil.c (qttip_cb): Remove code without function.
553
8278c4fe
EZ
5542011-07-09 Eli Zaretskii <eliz@gnu.org>
555
556 * w32.c (pthread_sigmask): New stub.
557
1692ae2d 5582011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 559
8a6ebd58 560 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
561 sigprocmask is portable only for single-threaded applications, and
562 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
563 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
564 (LIBES): Use it.
565 * callproc.c (Fcall_process):
566 * process.c (create_process):
567 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
568 Use pthread_sigmask, not sigprocmask.
123403e4 569
1b854618
JD
5702011-07-08 Jan Djärv <jan.h.d@swipnet.se>
571
572 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
573 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
574 wrong (Bug#8591).
575
3fe4b549
JD
5762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
577
0ce7e563
JD
578 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
579 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
580 (xg_hide_tooltip): Fix comment.
581
3fe4b549
JD
582 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
583 in registerServicesMenuSendTypes.
584 (validRequestorForSendType): Don't check ns_return_types.
585
586 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
587 ns_return_type.
588
5df75e47
JR
5892011-07-08 Jason Rumney <jasonr@gnu.org>
590
591 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
592 frame struct members of non-existent frames (Bug#6284).
593
699c10bd
JD
5942011-07-08 Jan Djärv <jan.h.d@swipnet.se>
595
4393663b
JD
596 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
597 variable firstTime not needed on OSX >= 10.6.
598 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
599 >= 10.5. Use setKnobProportion, setDoubleValue.
600
601 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
602 (MAC_OS_X_VERSION_10_5): Define if not defined.
603 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
604 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
605 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
606
607 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
608 cString and lossyCString on OSX >= 10.4
609
610 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
611 sizeToFit on OSX >= 10.2.
612
613 * nsimage.m (allocInitFromFile): Don't use deprecated method
614 bestRepresentationForDevice on OSX >= 10.6.
615
616 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
617 to avoid warning.
618
619 * emacs.c: Declare unexec_init_emacs_zone.
620
a63e0781
JD
621 * nsgui.h: Fix compiler warning about gnulib redefining verify.
622
699c10bd
JD
623 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
624
625 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
626 on svcsMenu (Bug#8842).
627
628 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
629 ns_return_types.
630 (Fns_list_services): Just return Qnil on 10.6, code not working there.
631
632 * nsterm.m (QUTF8_STRING): Declare.
633 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
634 (validRequestorForSendType): Return type is (id).
635 Change indexOfObjectIdenticalTo to indexOfObject.
636 Check if we have local selection before returning self (Bug#8842).
637 (writeSelectionToPasteboard): Put local selection into paste board
638 if we have a local selection (Bug#8842).
639 (syms_of_nsterm): DEFSYM QUTF8_STRING.
640
641 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
642 (ns_get_local_selection): Declare.
643
54e10184
LMI
6442011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
645
9888ff71
LMI
646 * keymap.c (describe_map_tree): Don't insert a double newline at
647 the end of the buffer (bug#1169) and return whether we inserted
648 something.
649
54e10184
LMI
650 * callint.c (Fcall_interactively): Change "reading args" to
651 "providing args" to try to clarify what it does (bug#1010).
652
15fa4783
KH
6532011-07-07 Kenichi Handa <handa@m17n.org>
654
655 * composite.c (composition_compute_stop_pos): Ignore a static
656 composition starting before CHARPOS (Bug#8915).
657
658 * xdisp.c (handle_composition_prop): Likewise.
659
a8815b00
EZ
6602011-07-07 Eli Zaretskii <eliz@gnu.org>
661
662 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
663 (Bug#9015)
664
ef7b981d 6652011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
666
667 * character.h (unicode_category_t): New enum type.
668
669 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
670 (Qchar_code_property_table): New variable.
671 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
672 (UNIPROP_COMPRESSED_FORM_P): New macros.
673 (char_table_ascii): Uncompress the compressed values.
674 (sub_char_table_ref): New arg is_uniprop. Callers changed.
675 Uncompress the compressed values.
ac389d0c 676 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
677 (char_table_ref_and_range): Uncompress the compressed values.
678 (sub_char_table_set): New arg is_uniprop. Callers changed.
679 Uncompress the compressed values.
680 (sub_char_table_set_range): Args changed. Callers changed.
681 (char_table_set_range): Adjuted for the above change.
682 (map_sub_char_table): Delete args default_val and parent. Add arg
683 top. Give decoded values to a Lisp function.
684 (map_char_table): Adjusted for the above change. Give decoded
685 values to a Lisp function. Gcpro more variables.
686 (uniprop_table_uncompress)
687 (uniprop_decode_value_run_length): New functions.
688 (uniprop_decoder, uniprop_decoder_count): New variables.
689 (uniprop_get_decoder, uniprop_encode_value_character)
690 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
691 New functions.
692 (uniprop_encoder, uniprop_encoder_count): New variables.
693 (uniprop_get_encoder, uniprop_table)
694 (Funicode_property_table_internal, Fget_unicode_property_internal)
695 (Fput_unicode_property_internal): New functions.
696 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
697 Sunicode_property_table_internal, Sget_unicode_property_internal,
698 and Sput_unicode_property_internal. Defvar_lisp
699 char-code-property-alist.
700
701 * composite.c (CHAR_COMPOSABLE_P): Adjusted for the change of
702 Vunicode_category_table.
703
704 * font.c (font_range): Adjusted for the change of
705 Vunicode_category_table.
706
76b397fb
DN
7072011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
708
709 * m/iris4d.h: Remove file, move contents ...
710 * s/irix6-5.h: ... here.
711
22b4128e
PE
7122011-07-06 Paul Eggert <eggert@cs.ucla.edu>
713
714 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
715 * alloc.c (mark_buffer):
716 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
717 (clone_per_buffer_values): Don't assume that
22b4128e
PE
718 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
719 This isn't true in general, and it's particularly not true
720 if Emacs is configured with --with-wide-int.
721 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
722 New macros, used in the buffer.c change.
723
869795d6
JD
7242011-07-05 Jan Djärv <jan.h.d@swipnet.se>
725
726 * xsettings.c: Use both GConf and GSettings if both are available.
727 (store_config_changed_event): Add comment.
728 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
729 (store_tool_bar_style_changed): New functions.
730 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
731 (struct xsettings): Move font inside HAVE_XFT.
732 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
733 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
734 Move inside HAVE_XFT.
735 (something_changed_gsettingsCB): Renamed from something_changedCB.
736 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
737 also.
738 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
739 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
740 (something_changed_gconfCB): Renamed from something_changedCB.
741 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
742 (parse_settings): Move check for font inside HAVE_XFT.
743 (read_settings, apply_xft_settings): Add comment.
744 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
745 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
746 call store_font_name_changed.
747 (xft_settings_event): Add comment.
748 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
749 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
750 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
751 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
752 (xsettings_initialize): Call init_gsettings last.
753 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
754 comment.
755
d8ed26bd
PE
7562011-07-05 Paul Eggert <eggert@cs.ucla.edu>
757
758 Random fixes. E.g., (random) never returned negative values.
759 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
760 subseconds part to the entropy, as that's a bit more random.
761 Prefer signed to unsigned, since the signedness doesn't matter and
762 in general we prefer signed. When given a limit, use a
763 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
764 latter isn't right if USE_2_TAGS_FOR_INTS.
765 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
766 not 0..VALMASK. Don't discard "excess" bits that random () returns.
767
cabf1cac
SM
7682011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
769
770 * textprop.c (text_property_stickiness):
771 Obey Vtext_property_default_nonsticky.
772 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
773 * w32fns.c (syms_of_w32fns):
774 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
775
6e9b2be9
PE
7762011-07-04 Paul Eggert <eggert@cs.ucla.edu>
777
778 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
779 This is more efficient than Ffile_directory_p and avoids a minor race.
780
90186c68
LMI
7812011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
782
7c301272
LMI
783 * buffer.c (Foverlay_put): Say what the return value is
784 (bug#7835).
785
c4f2d8d4
LMI
786 * fileio.c (barf_or_query_if_file_exists): Check first if the file
787 is a directory before asking whether to use the file name
788 (bug#7564).
ad637907
LMI
789 (barf_or_query_if_file_exists): Make the "File is a directory"
790 error be more correct.
c4f2d8d4 791
90186c68
LMI
792 * fns.c (Frequire): Remove the mention of the .gz files, since
793 that's installation-specific, but keep the mention of
794 `get-load-suffixes'.
795
da64016e
PE
7962011-07-04 Paul Eggert <eggert@cs.ucla.edu>
797
798 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
799 Report string overflow if the output is too long.
800
7d47b580
JB
8012011-07-04 Juanma Barranquero <lekktu@gmail.com>
802
a555cb87
JB
803 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
804 (syms_of_gnutls): Remove duplicate DEFSYM for
805 Qgnutls_bootprop_verify_hostname_error, an error for
806 Qgnutls_bootprop_verify_error (which is no longer used).
807
7d47b580
JB
808 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
809 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
810 Also (re)move comments that are misplaced or no longer relevant.
811
1e49bfab
LMI
8122011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
813
814 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
815
1485f4c0
CY
8162011-07-03 Chong Yidong <cyd@stupidchicken.com>
817
818 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
819 and background color parameters if they have been changed.
820
a9ab721e
LMI
8212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
822
823 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
824
cf7cff57
PE
8252011-07-03 Paul Eggert <eggert@cs.ucla.edu>
826
2e13213d
PE
827 * xsettings.c (SYSTEM_FONT): Define only when used.
828 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
829
cf7cff57
PE
830 * keymap.c (access_keymap_1): Now static.
831
7a8e04f7
CY
8322011-07-02 Chong Yidong <cyd@stupidchicken.com>
833
834 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
835 leave any prefix arg for the up event (Bug#1586).
836
61352f62
LMI
8372011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
838
69bb1ef7
LMI
839 * lread.c (syms_of_lread): Mention single symbols defined by
840 `defvar' or `defconst' (bug#7154).
841
61352f62 842 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 843 (Frequire): Mention get-load-suffixes.
61352f62 844
28545e04
MR
8452011-07-02 Martin Rudalics <rudalics@gmx.at>
846
847 * window.h (window): Remove clone_number slot.
848 * window.c (Fwindow_clone_number, Fset_window_clone_number):
849 Remove.
850 (make_parent_window, make_window, saved_window)
851 (Fset_window_configuration, save_window_save): Don't deal with
852 clone numbers.
853 * buffer.c (Qclone_number): Remove declaration.
854 (sort_overlays, overlay_strings): Don't deal with clone numbers.
855
3349e122
SM
8562011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
857
858 Add multiple inheritance to keymaps.
859 * keymap.c (Fmake_composed_keymap): New function.
860 (Fset_keymap_parent): Simplify.
861 (fix_submap_inheritance): Remove.
862 (access_keymap_1): New function extracted from access_keymap to handle
863 embedded parents and handle lists of maps.
864 (access_keymap): Use it.
865 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
866 (Fcopy_keymap): Handle embedded parents.
867 (Fcommand_remapping, define_as_prefix): Simplify.
868 (Fkey_binding): Simplify.
869 (syms_of_keymap): Move minibuffer-local-completion-map,
870 minibuffer-local-filename-completion-map,
871 minibuffer-local-must-match-map, and
872 minibuffer-local-filename-must-match-map to Elisp.
873 (syms_of_keymap): Defsubr make-composed-keymap.
874 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
875 (parse_menu_item): Trivial simplification.
876
3279eb87
GM
8772011-07-01 Glenn Morris <rgm@gnu.org>
878
879 * Makefile.in (SETTINGS_LIBS): Fix typo.
880
4550efdf
KI
8812011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
882
883 * coding.c (Fencode_coding_string): Record the last coding system
884 used, as the function doc string says (bug#8738).
885
0949d2b6
JD
8862011-07-01 Jan Djärv <jan.h.d@swipnet.se>
887
888 * xsettings.c (store_monospaced_changed): Take new font as arg and
889 check for change against current_mono_font.
890 (EMACS_TYPE_SETTINGS): Remove this and related defines.
891 (emacs_settings_constructor, emacs_settings_get_property)
892 (emacs_settings_set_property, emacs_settings_class_init)
893 (emacs_settings_init, gsettings_obj): Remove.
894 (something_changedCB): New function for HAVE_GSETTINGS.
895 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
896 with value as argument.
897 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
898 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 899 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
900 "changed".
901
902 * xgselect.c: Add defined (HAVE_GSETTINGS).
903 (xgselect_initialize): Ditto.
904
905 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
906 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
907 xg_select.
908
bbc6b304
PE
9092011-07-01 Paul Eggert <eggert@cs.ucla.edu>
910
911 * eval.c (struct backtrace): Simplify and port the data structure.
912 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
913 signed bit field, as this assumption is not portable and it makes
914 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
915 "char debug_on_exit : 1" as this is not portable either; instead,
916 use the portable "unsigned int debug_on_exit : 1". Remove unused
917 member evalargs. Remove obsolete comments about cc bombing out.
918
9851bfc5
JD
9192011-06-30 Jan Djärv <jan.h.d@swipnet.se>
920
51bb811f 921 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
922 Let HAVE_GSETTINGS override HAVE_GCONF.
923 (store_monospaced_changed): New function.
924 (EMACS_SETTINGS): A new type derived from GObject to handle
925 GSettings notifications.
926 (emacs_settings_constructor, emacs_settings_get_property)
927 (emacs_settings_set_property, emacs_settings_class_init):
928 New functions.
929 (gsettings_client, gsettings_obj): New variables.
930 (GSETTINGS_SCHEMA): New define.
931 (something_changedCB): Call store_monospaced_changed.
932 (init_gsettings): New function.
933 (xsettings_initialize): Call init_gsettings.
934 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
935 to NULL.
936
937 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
938 GCONF_CFLAGS/LIBS.
939
5386012d
MR
9402011-06-29 Martin Rudalics <rudalics@gmx.at>
941
942 * window.c (resize_root_window, grow_mini_window)
943 (shrink_mini_window): Rename Qresize_root_window to
944 Qwindow_resize_root_window and Qresize_root_window_vertically to
945 Qwindow_resize_root_window_vertically.
946
f13e0b08
PE
9472011-06-28 Paul Eggert <eggert@cs.ucla.edu>
948
949 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
950
94515237
JB
9512011-06-27 Juanma Barranquero <lekktu@gmail.com>
952
953 * makefile.w32-in: Redesign dependencies so they reflect more
954 clearly which files are directly included by each source file,
955 and not through other includes.
956
e43b6e43
MR
9572011-06-27 Martin Rudalics <rudalics@gmx.at>
958
959 * buffer.c (Qclone_number): Declare static and DEFSYM it.
960 (sort_overlays, overlay_strings): When an overlay's clone number
961 matches the window's clone number process the overlay even if
962 the overlay's window property doesn't match the current window.
963
d68443dc
MR
964 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
965 (Fwindow_hchild): Rename to Fwindow_left_child.
966 (Fwindow_next): Rename to Fwindow_next_sibling.
967 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
968 (resize_window_check): Rename to window_resize_check.
969 (resize_window_apply): Rename to window_resize_apply.
970 (Fresize_window_apply): Rename to Fwindow_resize_apply.
971 (Fdelete_other_windows_internal, resize_frame_windows)
972 (Fsplit_window_internal, Fdelete_window_internal)
973 (grow_mini_window, shrink_mini_window)
974 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 975
c7e73be5
JD
9762011-06-26 Jan Djärv <jan.h.d@swipnet.se>
977
978 * emacsgtkfixed.h: State that this is only used with Gtk+3.
979 (emacs_fixed_set_min_size): Remove.
980 (emacs_fixed_new): Take frame as argument.
981
982 * emacsgtkfixed.c: State that this is only used with Gtk+3.
983 (_EmacsFixedPrivate): Remove minwidth/height.
984 Add struct frame *f.
985 (emacs_fixed_init): Initialize priv->f.
986 (get_parent_class, emacs_fixed_set_min_size): Remove.
987 (emacs_fixed_new): Set priv->f to argument.
988 (emacs_fixed_get_preferred_width)
989 (emacs_fixed_get_preferred_height): Use min_width/height from
990 frames size_hint to set minimum and natural (Bug#8919).
991 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
992 and use min_width/height from frames size_hint to set
993 min_width/height (Bug#8919).
994
995 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
996 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
997 Fix indentation.
c7e73be5 998
cf99dcf8
EZ
9992011-06-26 Eli Zaretskii <eliz@gnu.org>
1000
1001 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1002 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1003 called at ZV.
1004
029529ac
CY
10052011-06-26 Chong Yidong <cyd@stupidchicken.com>
1006
1007 * process.c (wait_reading_process_output): Bypass select if
1008 waiting for a cell while ignoring keyboard input, and input is
1009 pending. Suggested by Jan Djärv (Bug#8869).
1010
7a7ef429
PE
10112011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1012
1013 Use gnulib's dup2 module instead of rolling our own.
1014 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1015
11fdef7d 10162011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1017
1018 * dispnew.c (scrolling_window): Before scrolling, turn off a
1019 mouse-highlight in the window being scrolled.
1020
cd3520a4
JB
10212011-06-24 Juanma Barranquero <lekktu@gmail.com>
1022
1023 Move DEFSYM to lisp.h and use everywhere.
1024
1025 * character.h (DEFSYM): Move declaration...
1026 * lisp.h (DEFSYM): ...here.
1027
1028 * gnutls.c:
1029 * minibuf.c:
1030 * w32menu.c:
1031 * w32proc.c:
1032 * w32select.c: Don't include character.h.
1033
1034 * alloc.c (syms_of_alloc):
1035 * buffer.c (syms_of_buffer):
1036 * bytecode.c (syms_of_bytecode):
1037 * callint.c (syms_of_callint):
1038 * casefiddle.c (syms_of_casefiddle):
1039 * casetab.c (init_casetab_once):
1040 * category.c (init_category_once, syms_of_category):
1041 * ccl.c (syms_of_ccl):
1042 * cmds.c (syms_of_cmds):
1043 * composite.c (syms_of_composite):
1044 * dbusbind.c (syms_of_dbusbind):
1045 * dired.c (syms_of_dired):
1046 * dispnew.c (syms_of_display):
1047 * doc.c (syms_of_doc):
1048 * editfns.c (syms_of_editfns):
1049 * emacs.c (syms_of_emacs):
1050 * eval.c (syms_of_eval):
1051 * fileio.c (syms_of_fileio):
1052 * fns.c (syms_of_fns):
1053 * frame.c (syms_of_frame):
1054 * fringe.c (syms_of_fringe):
1055 * insdel.c (syms_of_insdel):
1056 * keymap.c (syms_of_keymap):
1057 * lread.c (init_obarray, syms_of_lread):
1058 * macros.c (syms_of_macros):
1059 * msdos.c (syms_of_msdos):
1060 * print.c (syms_of_print):
1061 * process.c (syms_of_process):
1062 * search.c (syms_of_search):
1063 * sound.c (syms_of_sound):
1064 * syntax.c (init_syntax_once, syms_of_syntax):
1065 * terminal.c (syms_of_terminal):
1066 * textprop.c (syms_of_textprop):
1067 * undo.c (syms_of_undo):
1068 * w32.c (globals_of_w32):
1069 * window.c (syms_of_window):
1070 * xdisp.c (syms_of_xdisp):
1071 * xfaces.c (syms_of_xfaces):
1072 * xfns.c (syms_of_xfns):
1073 * xmenu.c (syms_of_xmenu):
1074 * xsettings.c (syms_of_xsettings):
1075 * xterm.c (syms_of_xterm): Use DEFSYM.
1076
4228cf16
TZ
10772011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1078
cd3520a4 1079 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1080
7fcccf1e
PE
10812011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1082
7efb4e0e
PE
1083 Integer and buffer overflow fixes (Bug#8873).
1084
ff5844ad
PE
1085 * print.c (printchar, strout): Check for string overflow.
1086 (PRINTPREPARE, printchar, strout):
1087 Don't set size unless allocation succeeds.
1088
90532f02
PE
1089 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1090 for sizes. Check for string overflow more accurately.
1091 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1092
6d84508d
PE
1093 * macros.c: Integer and buffer overflow fixes.
1094 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1095 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1096 Use ptrdiff_t, not int, for sizes.
1097 Don't increment bufsize until after realloc succeeds.
1098 Check for size-calculation overflow.
1099 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1100
437b2cb4
PE
1101 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1102
8b9ac8b4
PE
1103 * lread.c: Integer overflow fixes.
1104 (read_integer): Radix is now EMACS_INT, not int,
1105 to improve quality of diagnostics for out-of-range radices.
1106 Calculate buffer size correctly for out-of-range radices.
1107 (read1): Check for integer overflow in radices, and in
1108 read-circle numbers.
82cb60d3
PE
1109 (read_escape): Avoid int overflow.
1110 (Fload, openp, read_buffer_size, read1)
1111 (substitute_object_recurse, read_vector, read_list, map_obarray):
1112 Use ptrdiff_t, not int, for sizes.
1113 (read1): Use EMACS_INT, not int, for sizes.
20270765 1114 Check for size overflow.
8b9ac8b4 1115
7fcccf1e
PE
1116 * image.c (cache_image): Check for size arithmetic overflow.
1117
bfbbd7e7
PE
1118 * lread.c: Integer overflow issues.
1119 (saved_doc_string_size, saved_doc_string_length)
1120 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1121 Now ptrdiff_t, not int.
1122 (read1): Don't assume doc string length fits in int. Check for
1123 out-of-range doc string lengths.
1124 (read_list): Don't assume file position fits in int.
39019e54 1125 (read_escape): Check for hex character overflow.
bfbbd7e7 1126
4e323265
LL
11272011-06-22 Leo Liu <sdl.web@gmail.com>
1128
1129 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1130 Move to minibuffer.el.
1131
85fece3e
PE
11322011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1133
20b84ce9 1134 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1135 The following patches are for when GLYPH_DEBUG && !XASSERT.
1136 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1137 * dispnew.c (flush_stdout):
1138 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1139 Mark as externally visible.
1140 * dispnew.c (check_window_matrix_pointers): Now static.
1141 * dispnew.c (window_to_frame_vpos):
1142 * xfns.c (unwind_create_frame):
1143 * xterm.c (x_check_font): Remove unused local.
1144 * scroll.c (CHECK_BOUNDS):
1145 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1146 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1147 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1148 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1149 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1150 Now static.
1151 (debug_method_add): Use va_list and vsprintf rather than relying
1152 on undefined behavior with wrong number of arguments.
1153 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1154 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1155 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1156 since we're not interested in debugging glyphs with old libraries.
1157 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1158 GCC 4.6.0's static checking.
1159
0766b489
PE
11602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1161
31fd4b32
PE
1162 Integer overflow and signedness fixes (Bug#8873).
1163 A few related buffer overrun fixes, too.
1164
b79e8648
PE
1165 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1166
0766b489
PE
1167 * dispextern.h (struct face.stipple):
1168 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1169 (x_bitmap_mask, x_allocate_bitmap_record)
1170 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1171 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1172 (x_create_bitmap_from_xpm_data):
1173 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1174 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1175 (.bitmaps_last):
1176 * xfaces.c (load_pixmap):
1177 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1178 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1179 (.bitmaps_last, struct x_output.icon_bitmap):
1180 Use ptrdiff_t, not int, for bitmap indexes.
1181 (x_allocate_bitmap_record): Check for size overflow.
1182 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1183
b081724f
PE
1184 Use ptrdiff_t, not int, for overlay counts.
1185 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1186 * editfns.c (overlays_around, get_pos_property):
1187 * textprop.c (get_char_property_and_overlay):
1188 * xdisp.c (next_overlay_change, note_mouse_highlight):
1189 * xfaces.c (face_at_buffer_position):
21514da7
PE
1190 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1191 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1192 (Fnext_overlay_change, Fprevious_overlay_change)
1193 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1194 Use ptrdiff_t, not int, for sizes.
21514da7 1195 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1196
3de73e5e
PE
1197 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1198
2606c57b
PE
1199 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1200 (x_session_initialize): Do not assume string length fits in int.
1201
aaafe47a
PE
1202 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1203 This is unlikely, but can occur if DPI is outlandish.
1204
2674ddc8 1205 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1206 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1207
28154962
PE
1208 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1209 * xrdb.c (magic_file_p, search_magic_path):
1210 Omit last arg SUFFIX; it was always 0. All callers changed.
1211 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1212
7de51af5
PE
1213 * xfont.c (xfont_match): Avoid need for strlen.
1214
25ed6cc3
PE
1215 * xfns.c: Don't assume strlen fits in int.
1216 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1217
4eab31dd
PE
1218 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1219 not unsigned long, as we prefer signed integers. All callers changed.
1220 Detect integer overflow in repeat count.
1221 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1222 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1223
171e2a58
PE
1224 * termcap.c: Don't assume sizes fit in int and never overflow.
1225 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1226 (gobble_line): Check for size-calculation overflow.
1227
ad39faca 1228 * minibuf.c (Fread_buffer):
6e5bb2dc 1229 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1230 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1231 Don't assume string length fits in int.
1232
52c61c22 1233 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1234 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1235
b5b8c9e5
PE
1236 * font.c: Don't assume string length fits in int.
1237 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1238 Use ptrdiff_t, not int.
ccd6111c
PE
1239 (font_intern_prop): Don't assume string length fits in int.
1240 Don't assume integer property fits in fixnum.
1241 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1242
882f0d81 1243 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1244 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1245 Reformulate so as not to need the command string.
1246 Invoke gzip -cd rather than gunzip, as it's more portable.
1247 (lock_info_type, lock_file_1, lock_file):
1248 Don't assume pid_t and time_t fit in unsigned long.
1249 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1250 (current_lock_owner): Prefer signed type for sizes.
1251 Use memcpy, not strncpy, where memcpy is what is really wanted.
1252 Don't assume (via atoi) that time_t and pid_t fit in int.
1253 Check for time_t and/or pid_t out of range, e.g., via a network share.
1254 Don't alloca where an auto var works fine.
1255
93f4cf88
PE
1256 * fileio.c: Fix some integer overflow issues.
1257 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1258 Don't assume string length fits in int.
1259 (directory_file_name): Don't assume string length fits in long.
1260 (make_temp_name): Don't assume pid fits in int, or that its print
1261 length is less than 20.
1262
f3e92b69
PE
1263 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1264
1bfdaf10
PE
1265 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1266
35016e9a
PE
1267 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1268
3d1e65a1
PE
1269 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1270 We prefer signed integers, even for size calculations.
1271
0b963a93
PE
1272 * emacs.c: Don't assume string length fits in 'int'.
1273 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1274 (main): Don't invoke strlen when not needed.
1275
573f4b54
PE
1276 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1277 (XD_DEBUG_MESSAGE): Don't waste a byte.
1278
989f33ba
PE
1279 * callproc.c (getenv_internal_1, getenv_internal)
1280 (Fgetenv_internal):
965d34eb
PE
1281 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1282
e4d29b33
PE
1283 * lread.c (invalid_syntax): Omit length argument.
1284 All uses changed. This doesn't fix a bug, but it simplifies the
1285 code away from its former Hollerith-constant appearance, and it's
1286 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1287 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1288
eb49b136
PE
1289 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1290 This didn't break anything, but it didn't help either.
1291 It's confusing to put a bogus integer in a place where the actual
1292 value does not matter.
9f62aeb1 1293 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1294 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1295
15375a22
PE
1296 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1297 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1298 implementation.
b61cc01c
PE
1299 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1300 We prefer signed types, and the value cannot exceed the EMACS_INT
1301 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1302 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1303 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1304 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1305
53b2623d
PE
1306 * indent.c (sane_tab_width): New function.
1307 (current_column, scan_for_column, Findent_to, position_indentation)
1308 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1309 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1310
51cab52b 1311 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1312
f2ed8a70
PE
1313 * lisp.h (lint_assume): New macro.
1314 * composite.c (composition_gstring_put_cache):
1315 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1316
abe80cc6
PE
1317 * editfns.c, insdel.c:
1318 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1319
b02c740e
PE
1320 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1321
ebc96716
PE
1322 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1323
b4e50fa0 1324 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1325 Use much-faster test for byte-length change.
311d5d7c 1326 Don't assume string byte-length fits in 'int'.
a4cf38e4 1327 Check that character arg fits in 'int'.
85461888 1328 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1329
c0c1ee9f
PE
1330 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1331
a498d7f4
PE
1332 * fns.c (concat): Catch string overflow earlier.
1333 Do not rely on integer wraparound.
1334
51cab52b
PE
1335 * dispextern.h (struct it.overlay_strings_charpos)
1336 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1337 * xdisp.c (forward_to_next_line_start)
1338 (back_to_previous_visible_line_start)
1339 (reseat_at_next_visible_line_start, next_element_from_buffer):
1340 Don't arbitrarily truncate the value of 'selective' to int.
1341
76031fad
PE
1342 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1343
5eb55db9
PE
1344 * composite.c: Don't truncate sizes to 'int'.
1345 (composition_gstring_p, composition_reseat_it)
1346 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1347 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1348 not EMACS_UINT, for indexes.
5eb55db9 1349
0703a717
PE
1350 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1351
d6202519
PE
1352 * buffer.c: Include <verify.h>.
1353 (struct sortvec.priority, struct sortstr.priority):
8961a454 1354 Now EMACS_INT, not int.
c20998a7 1355 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1356 (struct sortstr.size, record_overlay_string)
1357 (struct sortstrlist.size, struct sortlist.used):
1358 Don't truncate size to int.
1359 (record_overlay_string): Check for size-calculation overflow.
d6202519 1360 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1361
d5a19415
JM
13622011-06-22 Jim Meyering <meyering@redhat.com>
1363
029529ac 1364 Don't leak an XBM-image-sized buffer
d5a19415
JM
1365 * image.c (xbm_load): Free the image buffer after using it.
1366
a9041e6c
PE
13672011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1368
1369 Port to Sun C.
1370 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1371 that Sun C diagnosed.
1372 * fns.c (secure_hash): Fix pointer signedness issue.
1373 * intervals.c (static_offset_intervals): New function.
1374 (offset_intervals): Use it.
1375
7f3f739f
LL
13762011-06-21 Leo Liu <sdl.web@gmail.com>
1377
1378 * deps.mk (fns.o):
1379 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1380 sha512.h.
1381
1382 * fns.c (secure_hash): Rename from crypto_hash_function and change
1383 the first arg to accept symbols.
5b66d427 1384 (Fsecure_hash): New primitive.
7f3f739f
LL
1385 (syms_of_fns): New symbols.
1386
76147d94
DD
13872011-06-20 Deniz Dogan <deniz@dogan.se>
1388
1389 * process.c (Fset_process_buffer): Clarify return value in
1390 docstring.
1391
7d7d0045
CY
13922011-06-18 Chong Yidong <cyd@stupidchicken.com>
1393
1394 * dispnew.c (add_window_display_history): Use BVAR.
1395
1396 * xdisp.c (debug_method_add): Use BVAR.
1397 (check_window_end, dump_glyph_matrix, dump_glyph)
1398 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1399
1400 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1401 Likewise.
1402
1403 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1404 check till after the cache is created in init_frame_faces.
1405
ff2bc410
SM
14062011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1407
1408 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1409
28177add
PE
14102011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1411
dd3482fe
PE
1412 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1413 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1414 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1415
393d71f3 1416 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1417 * fileio.c (Finsert_file_contents):
1418 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1419 Remove the old (too-loose) buffer overflow checks.
1420 They weren't needed, since make_gap checks for buffer overflow.
1421 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1422 The old code merely checked for Emacs fixnum overflow, and relied
1423 on undefined (wraparound) behavior. The new code avoids undefined
1424 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1425
2e6813b0 1426 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1427 Tune. Don't use wider integers than needed. Don't use alloca.
1428 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1429
599a9e4f
PE
1430 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1431
99561444
PE
1432 * insdel.c, lisp.h (buffer_overflow): New function.
1433 (insert_from_buffer_1, replace_range, replace_range_2):
1434 * insdel.c (make_gap_larger):
1435 * editfns.c (Finsert_char):
1436 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1437
28177add
PE
1438 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1439
e69dafad
PE
14402011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1441
a7af7fde 1442 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1443
b1c46f02
PE
1444 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1445 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1446
e69dafad
PE
1447 * fileio.c: Don't assume EMACS_INT fits in off_t.
1448 (emacs_lseek): New static function.
1449 (Finsert_file_contents, Fwrite_region): Use it.
1450 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1451
566684ea
PE
1452 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1453
e6966cd6
PE
1454 * fns.c: Don't overflow int when computing a list length.
1455 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1456 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1457 truncation on 64-bit hosts. Check for QUIT every
1458 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1459 faster and is responsive enough.
1460 (Flength): Report an error instead of overflowing an integer.
1461 (Fsafe_length): Return a float if the value is not representable
1462 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1463 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1464 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1465
dd0b0efb
PE
1466 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1467 (header_size, word_size): New constants.
1468 (allocate_vectorlike): Don't check size overflow here.
1469 (allocate_vector): Check it here instead, since this is the only
1470 caller of allocate_vectorlike that could cause overflow.
1471 Check that the new vector's length is representable as a fixnum.
1472
86fe5cfe
PE
1473 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1474 The previous code was bogus. For example, next_almost_prime (32)
1475 returned 39, which is undesirable as it is a multiple of 3; and
1476 next_almost_prime (24) returned 25, which is a multiple of 5 so
1477 why was the code bothering to check for multiples of 7?
1478
80e88859
PE
1479 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1480
4a2f0ad6
PE
1481 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1482
f66c7cf8
PE
1483 Variadic C functions now count arguments with ptrdiff_t.
1484 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1485 Back then I didn't know that the Emacs coding style prefers signed int.
1486 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1487 were being counted with int, which may truncate counts on 64-bit
1488 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1489 * lisp.h (struct Lisp_Subr.function.aMANY)
1490 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1491 Arg counts are now ptrdiff_t, not size_t.
1492 All variadic functions and their callers changed accordingly.
1493 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1494 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1495 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1496 * callint.c (Fcall_interactively): Check arg count for overflow,
1497 to avoid potential buffer overrun. Use signed char, not 'int',
1498 for 'varies' array, so that we needn't bother to check its size
1499 calculation for overflow.
1500 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1501 * eval.c (apply_lambda):
1502 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1503 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1504 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1505
a1759b76
PE
1506 * callint.c (Fcall_interactively): Don't use index var as event count.
1507
d96be9fc
PE
1508 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1509 * mem-limits.h (SIZE): Remove; no longer used.
1510
a690a978 1511 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1512
578c21e6
PE
1513 Remove unnecessary casts.
1514 * xterm.c (x_term_init):
1515 * xfns.c (x_set_border_pixel):
1516 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1517 These aren't needed now that we assume ANSI C.
1518
96f53c6c
PE
1519 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1520 It's more likely to cause problems (due to unsigned overflow)
1521 than to cure them.
1522
83c77d31
PE
1523 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1524
ee2079f1
PE
1525 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1526
6da65536
PE
1527 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1528
7147c4a4
PE
1529 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1530
193e32d9
PE
1531 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1532
e5533da6
PE
1533 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1534
9910e595
PE
1535 GLYPH_CODE_FACE returns EMACS_INT, not int.
1536 * dispextern.h (merge_faces):
1537 * xfaces.c (merge_faces):
01103c44
PE
1538 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1539 Don't assume EMACS_INT fits in int.
9910e595 1540
2638320e
PE
1541 * character.h (CHAR_VALID_P): Remove unused parameter.
1542 * fontset.c, lisp.h, xdisp.c: All uses changed.
1543
045eb8d9
PE
1544 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1545
c1f134b5
PE
1546 * fns.c (concat): Minor tuning based on overflow analysis.
1547 This doesn't fix any bugs. Use int to hold character, instead
1548 of constantly refetching from Emacs object. Use XFASTINT, not
1549 XINT, for value known to be a character. Don't bother comparing
1550 a single byte to 0400, as it's always less.
1551
395fcb93 1552 * floatfns.c (Fexpt):
327eeec8
PE
1553 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1554
abbd3d23
PE
1555 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1556 for characters.
1557
684a03ef
PE
1558 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1559
0fed43f3
PE
1560 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1561 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1562 incorrectly succeed when S was a string, because 4294967386 was
1563 truncated before it was used.
1564
8fd02eb7
PE
1565 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1566 Otherwise, an out-of-range integer could cause undefined behavior
1567 on a 64-bit host.
1568
f8c86b69
PE
1569 * composite.c: Use int, not EMACS_INT, for characters.
1570 (fill_gstring_body, composition_compute_stop_pos): Use int, not
1571 EMACS_INT, for values that are known to be in character range.
1572 This doesn't fix any bugs but is the usual style inside Emacs and
1573 may generate better code on 32-bit machines.
1574
34206dd2
PE
1575 Make sure a 64-bit char is never passed to ENCODE_CHAR.
1576 This is for reasons similar to the recent CHAR_STRING fix.
1577 * charset.c (Fencode_char): Check that character arg is actually
1578 a character. Pass an int to ENCODE_CHAR.
1579 * charset.h (ENCODE_CHAR): Verify that the character argument is no
1580 wider than 'int', as a compile-time check to prevent future regressions
1581 in this area.
1582
c5958d4c 1583 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
1584
1585 Make sure a 64-bit char is never passed to CHAR_STRING.
1586 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
1587 by silently ignoring the top 32 bits, allowing some values
1588 that were far too large to be valid characters.
1589 * character.h: Include <verify.h>.
1590 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
1591 arguments are no wider than unsigned, as a compile-time check
1592 to prevent future regressions in this area.
1593 * data.c (Faset):
01103c44 1594 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
1595 (Fsubst_char_in_region):
1596 * fns.c (concat):
1597 * xdisp.c (decode_mode_spec_coding):
1598 Adjust to CHAR_STRING's new requirement.
1599 * editfns.c (Finsert_char, Fsubst_char_in_region):
1600 * fns.c (concat): Check that character args are actually
1601 characters. Without this test, these functions did the wrong
1602 thing with wildly out-of-range values on 64-bit hosts.
1603
d37ca623
PE
1604 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
1605 These casts should not be needed on 32-bit hosts, either.
1606 * keyboard.c (read_char):
1607 * lread.c (Fload): Remove casts to unsigned.
1608
ea204efb
PE
1609 * lisp.h (UNSIGNED_CMP): New macro.
1610 This fixes comparison bugs on 64-bit hosts.
1611 (ASCII_CHAR_P): Use it.
1612 * casefiddle.c (casify_object):
01103c44 1613 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
1614 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
1615 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
1616 * dispextern.h (FACE_FROM_ID):
1617 * keyboard.c (read_char): Use UNSIGNED_CMP.
1618
41cb286c
PE
1619 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
1620 not to EMACS_INT, to avoid GCC warning.
1621
4a1b9832
PE
1622 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
1623
55daad71
PE
1624 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
1625 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
1626 isn't needed on 32-bit machines.
8f95c75c 1627
01103c44
PE
1628 * buffer.c (Fgenerate_new_buffer_name):
1629 Use EMACS_INT for count, not int.
0ceccced 1630 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
1631
1632 * data.c (Qcompiled_function): Now static.
1633
c6f072e7
PE
1634 * window.c (window_body_lines): Now static.
1635
20ce5912
PE
1636 * image.c (gif_load): Rename local to avoid shadowing.
1637
9c4c5f81
PE
1638 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
1639 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
1640 * alloc.c (make_save_value): Integer argument is now of type
1641 ptrdiff_t, not int.
1642 (mark_object): Use ptrdiff_t, not int.
1643 * lisp.h (pD): New macro.
1644 * print.c (print_object): Use it.
1645
c0c5c8ae
PE
1646 * alloc.c: Use EMACS_INT, not int, to count objects.
1647 (total_conses, total_markers, total_symbols, total_vector_size)
1648 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
1649 (total_free_floats, total_floats, total_free_intervals)
1650 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
1651 Now EMACS_INT, not int. All uses changed.
1652 (Fgarbage_collect): Compute overall total using a double, so that
1653 integer overflow is less likely to be a problem. Check for overflow
1654 when converting back to an integer.
5a25e253
PE
1655 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
1656 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
1657 These were 'int' variables that could overflow on 64-bit hosts;
1658 they were never used, so remove them instead of repairing them.
211a0b2a 1659 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
1660 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
1661 Previously, this ceilinged at INT_MAX, but that doesn't work on
1662 64-bit machines.
e46bb31a 1663 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 1664
c78baabf 1665 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 1666 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
1667 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
1668 when a (possibly-narrower) signed value would do just as well.
1669 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 1670
c9d624c6
PE
1671 * alloc.c: Catch some string size overflows that we were missing.
1672 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1673 for convenience in STRING_BYTES_MAX.
1674 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1675 The definition here is exact; the one in lisp.h was approximate.
1676 (allocate_string_data): Check for string overflow. This catches
1677 some instances we weren't catching before. Also, it catches
1678 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1679 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1680 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1681
c9d624c6
PE
1682 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1683 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1684 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1685
353032ce
PE
1686 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1687
2bccce07
PE
1688 * alloc.c (Fmake_string): Check for out-of-range init.
1689
0ac30604
SM
16902011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1691
1692 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1693
c195f2de
JD
16942011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1695
1696 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1697 xg_get_default_scrollbar_width.
1698
1699 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1700 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1701 (style_changed_cb): Call update_theme_scrollbar_width and call
1702 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1703 all frames (Bug#8505).
1704 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1705 Call gtk_window_set_resizable if HAVE_GTK3.
1706 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1707 and height if HAVE_GTK3 (Bug#8505).
1708 (scroll_bar_width_for_theme): New variable.
1709 (update_theme_scrollbar_width): New function.
1710 (xg_get_default_scrollbar_width): Move code to
1711 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1712 (xg_initialize): Call update_theme_scrollbar_width.
1713
1714 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1715
1716 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1717
e10ac9f1
MR
17182011-06-12 Martin Rudalics <rudalics@gmx.at>
1719
1720 * frame.c (make_frame): Call other_buffer_safely instead of
1721 other_buffer.
1722
1723 * window.c (temp_output_buffer_show): Call display_buffer with
1724 second argument Vtemp_buffer_show_specifiers and reset latter
1725 immediately after the call.
1726 (Vtemp_buffer_show_specifiers): New variable.
1727 (auto_window_vscroll_p, next_screen_context_lines)
1728 (Vscroll_preserve_screen_position): Remove leading asterisks from
1729 doc-strings.
1730
2d3c217e 17312011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1732
7b7f97e8 1733 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1734 * buffer.c (Qclone_number): Remove for now, as it's unused.
1735 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1736 (record_buffer): Remove unused local.
1737 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1738 (set_frame_buffer_list): Remove; unused.
1739 * frame.h (other_visible_frames): Remove decl.
1740 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1741 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1742 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1743 if HAVE_GPM.
1744 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1745 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1746 Define only if HAVE_GPM.
1747 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1748 (update_hints_inhibit): Remove; never set. All uses removed.
1749 * widgetprv.h (emacsFrameClassRec): Remove decl.
1750 * window.c (delete_deletable_window): Now returns void, since it
1751 wasn't returning anything.
1752 (compare_window_configurations): Remove unused locals.
1753 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1754 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1755 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1756 the same widths as pointers. This follows up on the 2011-05-06 patch.
1757 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1758 * xterm.h: Likewise.
1759 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1760
1384b89e
JB
17612011-06-12 Juanma Barranquero <lekktu@gmail.com>
1762
1763 * makefile.w32-in: Update dependencies.
1764 (LISP_H): Add lib/intprops.h.
1765
1100a63c
CY
17662011-06-11 Chong Yidong <cyd@stupidchicken.com>
1767
1768 * image.c (gif_load): Add animation frame delay to the metadata.
1769 (syms_of_image): Use DEFSYM. New symbol `delay'.
1770
6198ccd0
MR
17712011-06-11 Martin Rudalics <rudalics@gmx.at>
1772
1773 * window.c (delete_deletable_window): Re-add.
1774 (Fset_window_configuration): Rewrite to handle dead buffers and
1775 consequently deletable windows.
1776 (window_tree, Fwindow_tree): Remove. Supply functionality in
1777 window.el.
1778 (compare_window_configurations): Simplify code.
1779
b6e3633c
AS
17802011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1781
1ab0dee5
AS
1782 * image.c (imagemagick_load_image): Fix type mismatch.
1783 (Fimagemagick_types): Likewise.
1784
b6e3633c
AS
1785 * window.h (replace_buffer_in_windows): Declare.
1786
9397e56f
MR
17872011-06-11 Martin Rudalics <rudalics@gmx.at>
1788
1789 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1790 Qclone_number. Remove external declaration of Qdelete_window.
1791 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1792 code.
1793 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1794 Qbuffer_list_update_hook if allowed.
1795 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1796 buffer list implementation.
1797 (other_buffer_safely): New function.
1798 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1799 calls to replace_buffer_in_windows and
1800 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1801 if allowed.
1802 (record_buffer): Inhibit quitting and rewrite using quittable
1803 functions. Run Qbuffer_list_update_hook if allowed.
1804 (Frecord_buffer, Funrecord_buffer): New functions.
1805 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1806 switch-to-buffer to window.el.
1807 (bury-buffer): Move to window.el.
1808 (Vbuffer_list_update_hook): New variable.
1809
1810 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1811 section.
1812
1813 * window.h (resize_frame_windows): Move up in code.
1814 (Fwindow_frame): Remove EXFUN.
1815 (replace_buffer_in_all_windows): Remove prototype.
1816 (replace_buffer_in_windows_safely): Add prototype.
1817
1818 * window.c: Declare Qdelete_window static again. Move down
1819 declaration of select_count.
1820 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1821 (Fother_window): Move to window.el.
1822 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1823 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1824 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1825 window.el.
1826 (replace_buffer_in_windows): Implement by calling
1827 Qreplace_buffer_in_windows.
1828 (replace_buffer_in_all_windows): Remove with some functionality
1829 moved into replace_buffer_in_windows_safely.
1830 (replace_buffer_in_windows_safely): New function.
1831 (select_window_norecord, select_frame_norecord): Move in front
1832 of run_window_configuration_change_hook. Remove now obsolete
1833 declarations.
1834 (Fset_window_buffer): Rewrite doc-string. Call
1835 Qrecord_window_buffer.
1836 (keys_of_window): Move binding for other-window to window.el.
1837
b50691aa
CY
18382011-06-11 Chong Yidong <cyd@stupidchicken.com>
1839
1840 * dispextern.h (struct image): Replace data member, whose int_val
1841 and ptr_val fields were not used by anything, with a single
1842 lisp_val object.
1843
1844 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1845 (gif_clear_image, gif_load, imagemagick_load_image)
1846 (gs_clear_image, gs_load): Callers changed.
1847
3f754b86
PE
18482011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1849
cca69397
PE
1850 * buffer.h: Include <time.h>, for time_t.
1851 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1852
109e28d0
PE
1853 Fix minor problems found by static checking.
1854
60737f02
PE
1855 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1856
4b66faf3
PE
1857 Make identifiers static if they are not used in other modules.
1858 * data.c (Qcompiled_function, Qframe, Qvector):
1859 * image.c (QimageMagick, Qsvg):
1860 * minibuf.c (Qmetadata):
1861 * window.c (resize_window_check, resize_root_window): Now static.
1862 * window.h (resize_window_check, resize_root_window): Remove decls.
1863
109e28d0
PE
1864 * window.c (window_deletion_count, delete_deletable_window):
1865 Remove; unused.
46a4ce9e
PE
1866 (window_body_lines): Now static.
1867 (Fdelete_other_windows_internal): Mark vars as initialized.
1868 Make sure 'resize_failed' is initialized.
1869 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1870 (resize_window_apply): Remove unused local.
1871 * window.h (delete_deletable_window): Remove decl.
1872
109e28d0 1873 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1874 (imagemagick_load_image): Fix pointer signedness problem by changing
1875 last arg from unsigned char * to char *. All uses changed.
1876 Also, fix a local for similar reasons.
1877 Remove unused locals. Remove locals to avoid shadowing.
1878 (fn_rsvg_handle_free): Remove; unused.
1879 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1880 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1881
3f754b86
PE
1882 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1883
2547adb1
CY
18842011-06-10 Chong Yidong <cyd@stupidchicken.com>
1885
1886 * image.c (gif_load): Fix omitted cast error introduced by
1887 2011-06-06 change.
1888
2c8e37d4
MR
18892011-06-10 Martin Rudalics <rudalics@gmx.at>
1890
1891 * window.h (resize_proportionally, orig_total_lines)
1892 (orig_top_line): Remove from window structure.
1893 (set_window_height, set_window_width, change_window_heights)
1894 (Fdelete_window): Remove prototypes.
1895 (resize_frame_windows): Remove duplicate declaration.
1896
440a42e3
EZ
18972011-06-10 Eli Zaretskii <eliz@gnu.org>
1898
1899 * window.h (resize_frame_windows, resize_window_check)
1900 (delete_deletable_window, resize_root_window)
1901 (resize_frame_windows): Declare prototypes.
1902
1903 * window.c (resize_window_apply): Make definition be "static" to
1904 match the prototype.
1905
562dd5e9
MR
19062011-06-10 Martin Rudalics <rudalics@gmx.at>
1907
1908 * window.c: Remove declarations of Qwindow_size_fixed,
1909 window_min_size_1, window_min_size_2, window_min_size,
1910 size_window, window_fixed_size_p, enlarge_window, delete_window.
1911 Remove static from declaration of Qdelete_window, it's
1912 temporarily needed by Fbury_buffer.
1913 (replace_window): Don't assign orig_top_line and
1914 orig_total_lines.
1915 (Fdelete_window, delete_window): Remove. Window deletion is
1916 handled by window.el.
1917 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1918 Fdelete_window calls with calls to Qdelete_window.
1919 (Fdelete_other_windows): Remove. Deleting other windows is
1920 handled by window.el.
1921 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1922 handled in window.el.
1923 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1924 Window minimum sizes are handled in window.el.
1925 (shrink_windows, size_window, set_window_height)
1926 (set_window_width, change_window_heights, window_height)
1927 (window_width, CURBEG, CURSIZE, enlarge_window)
1928 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1929 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1930 handled in window.el.
1931 (make_dummy_parent): Rename to make_parent_window and give it a
1932 second argument horflag.
1933 (make_window): Don't set resize_proportionally any more.
1934 (Fsplit_window): Remove. Windows are split in window.el.
1935 (save_restore_action, save_restore_orig_size)
1936 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1937 Resize mini windows in window.el.
1938 (grow_mini_window, shrink_mini_window): Implement by calling
1939 Qresize_root_window_vertically, resize_window_check and
1940 resize_window_apply.
1941 (saved_window, Fset_window_configuration, save_window_save): Do
1942 not handle orig_top_line, orig_total_lines, and
1943 resize_proportionally.
1944 (window_min_height, window_min_width): Move to window.el.
1945 (keys_of_window): Move bindings for delete-other-windows,
1946 split-window, delete-window and enlarge-window to window.el.
1947
1948 * buffer.c: Temporarily extern Qdelete_window.
1949 (Fbury_buffer): Temporarily call Qdelete_window instead of
1950 Fdelete_window (Fbury_buffer will move to window.el soon).
1951
1952 * frame.c (set_menu_bar_lines_1): Remove code handling
1953 orig_top_line and orig_total_lines.
1954
1955 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1956 set_window_height but set heights directly.
1957 (change_frame_size_1): Use resize_frame_windows.
1958
1959 * xdisp.c (init_xdisp): Don't use set_window_height but set
1960 heights directly.
1961
1962 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1963 resize_frame_windows instead of change_window_heights and run
1964 run_window_configuration_change_hook.
1965
1966 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1967 instead of change_window_heights and run
1968 run_window_configuration_change_hook.
1969
1a13852e
MR
19702011-06-09 Martin Rudalics <rudalics@gmx.at>
1971
1972 * window.c (replace_window): Rename second argument REPLACEMENT to
1973 NEW. New third argument SETFLAG. Rewrite.
1974 (delete_window, make_dummy_parent): Call replace_window with
1975 third argument 1.
1976 (window_list_1): Move down in code.
1977 (run_window_configuration_change_hook): Move set_buffer part
1978 before select_frame_norecord part in order to unwind correctly.
1979 Rename count1 to count.
1980 (recombine_windows, delete_deletable_window, resize_root_window)
1981 (Fdelete_other_windows_internal)
1982 (Frun_window_configuration_change_hook, make_parent_window)
1983 (resize_window_check, resize_window_apply, Fresize_window_apply)
1984 (resize_frame_windows, Fsplit_window_internal)
1985 (Fdelete_window_internal, Fresize_mini_window_internal): New
1986 functions.
1987 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1988
f3d1777e
MR
19892011-06-08 Martin Rudalics <rudalics@gmx.at>
1990
496e208e
MR
1991 * window.h (window): Add some new members to window structure -
1992 normal_lines, normal_cols, new_total, new_normal, clone_number,
1993 splits, nest, prev_buffers, next_buffers.
1994 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1995 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1996
f3d1777e
MR
1997 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1998 Remove.
496e208e
MR
1999 (make_dummy_parent): Set new members of windows structure.
2000 (make_window): Move down in code. Handle new members of window
2001 structure.
2002 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2003 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2004 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2005 (Fset_window_prev_buffers, Fwindow_next_buffers)
2006 (Fset_window_next_buffers, Fset_window_clone_number): New
2007 functions.
2008 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2009 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2010 Doc-string fixes.
2011 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2012 Argument WINDOW can be now internal window too.
2013 (Fwindow_use_time): Move up in code.
2014 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2015 Rewrite doc-string.
2016 (Fset_window_configuration, saved_window)
2017 (Fcurrent_window_configuration, save_window_save): Handle new
2018 members of window structure.
b9e809c2
MR
2019 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2020 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2021 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2022 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2023 Qget_mru_window, Qresize_root_window,
2024 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2025 Qauto_buffer_name; staticpro them.
f3d1777e 2026
abde8f8c
MR
20272011-06-07 Martin Rudalics <rudalics@gmx.at>
2028
2029 * window.c (Fwindow_total_size, Fwindow_left_column)
2030 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2031 (Fwindow_list_1): New functions.
2032 (window_box_text_cols): Replace with window_body_cols.
2033 (Fwindow_width, Fscroll_left, Fscroll_right): Use
2034 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
2035 (delete_window, Fset_window_configuration): Call
2036 delete_all_subwindows with window as argument.
2037 (delete_all_subwindows): Take a window as argument and not a
2038 structure. Rewrite.
190b47e6
MR
2039 (window_loop): Remove handling of GET_LRU_WINDOW and
2040 GET_LARGEST_WINDOW.
2041 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2042
2043 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2044 window_box_text_cols. delete_all_subwindows now takes a
2045 Lisp_Object as argument.
abde8f8c
MR
2046
2047 * indent.c (compute_motion, Fcompute_motion): Use
2048 window_body_cols instead of window_box_text_cols.
2049
fa8a67e6
MR
2050 * frame.c (delete_frame): Call delete_all_subwindows with root
2051 window as argument.
2052
a54e3482
DC
20532011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2054
2055 * fns.c (Fputhash): Document return value.
2056
60002bf5
CY
20572011-06-06 Chong Yidong <cyd@stupidchicken.com>
2058
2059 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2060
0c671da6 20612011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2062
b862a52a 2063 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2064
be44ca6c
PE
2065 Check for overflow when converting integer to cons and back.
2066 * charset.c (Fdefine_charset_internal, Fdecode_char):
2067 Use cons_to_unsigned to catch overflow.
2068 (Fencode_char): Use INTEGER_TO_CONS.
2069 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2070 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2071 * data.c (long_to_cons, cons_to_long): Remove.
2072 (cons_to_unsigned, cons_to_signed): New functions.
2073 These signal an error for invalid or out-of-range values.
2074 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2075 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2076 * font.c (Ffont_variation_glyphs):
2077 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2078 * lisp.h: Include <intprops.h>.
2079 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2080 (cons_to_signed, cons_to_unsigned): New decls.
2081 (long_to_cons, cons_to_long): Remove decls.
2082 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2083 (Fprimitive_undo): Use CONS_TO_INTEGER.
2084 * xfns.c (Fx_window_property): Likewise.
2085 * xselect.c: Include <limits.h>.
2086 (x_own_selection, selection_data_to_lisp_data):
2087 Use INTEGER_TO_CONS.
2088 (x_handle_selection_request, x_handle_selection_clear)
2089 (x_get_foreign_selection, Fx_disown_selection_internal)
2090 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2091 (lisp_data_to_selection_data): Use cons_to_unsigned.
2092 (x_fill_property_data): Use cons_to_signed.
2093 Report values out of range.
2094
d1f3d2af
PE
2095 Check for buffer and string overflow more precisely.
2096 * buffer.h (BUF_BYTES_MAX): New macro.
2097 * lisp.h (STRING_BYTES_MAX): New macro.
2098 * alloc.c (Fmake_string):
2099 * character.c (string_escape_byte8):
2100 * coding.c (coding_alloc_by_realloc):
2101 * doprnt.c (doprnt):
2102 * editfns.c (Fformat):
2103 * eval.c (verror):
2104 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2105 since they may not be the same number.
2106 * editfns.c (Finsert_char):
2107 * fileio.c (Finsert_file_contents):
2108 Likewise for BUF_BYTES_MAX.
2109
dd52fcea
PE
2110 * image.c: Use ptrdiff_t, not int, for sizes.
2111 (slurp_file): Switch from int to ptrdiff_t.
2112 All uses changed.
2113 (slurp_file): Check that file size fits in both size_t (for
2114 malloc) and ptrdiff_t (for sanity and safety).
2115
7f9bbdbb
PE
2116 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2117 if b->modtime has its maximal value.
2118
dfe18f82
PE
2119 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2120
84acfcf0
PE
2121 Don't assume time_t can fit into int.
2122 * buffer.h (struct buffer.modtime): Now time_t, not int.
2123 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2124 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2125
ccd9a01a
PE
2126 Minor fixes for signed vs unsigned integers.
2127 * character.h (MAYBE_UNIFY_CHAR):
2128 * charset.c (maybe_unify_char):
2129 * keyboard.c (read_char, reorder_modifiers):
2130 XINT -> XFASTINT, since the integer must be nonnegative.
2131 * ftfont.c (ftfont_spec_pattern):
2132 * keymap.c (access_keymap, silly_event_symbol_error):
2133 XUINT -> XFASTINT, since the integer must be nonnegative.
2134 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2135 since it makes no difference and we prefer signed.
2136 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2137 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2138 nonnegative.
2139
d6d100dd
SM
21402011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2141
2142 * window.h (Fwindow_frame): Declare.
2143
2b6148e4
PE
21442011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2145
2146 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2147 (SPARE_MEMORY): Always define.
2148 (LARGE_REQUEST): Remove.
2149 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2150
f230ecc9
MR
21512011-06-06 Martin Rudalics <rudalics@gmx.at>
2152
727e958e
MR
2153 * lisp.h: Move EXFUNS for Fframe_root_window,
2154 Fframe_first_window and Fset_frame_selected_window to window.h.
2155
2156 * window.h: Move EXFUNS for Fframe_root_window,
2157 Fframe_first_window and Fset_frame_selected_window here from
2158 lisp.h.
2159
2160 * frame.c (Fwindow_frame, Fframe_first_window)
2161 (Fframe_root_window, Fframe_selected_window)
2162 (Fset_frame_selected_window): Move to window.c.
2163 (Factive_minibuffer_window): Move to minibuf.c.
2164 (Fother_visible_frames_p): New function.
2165
2166 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2167
f230ecc9
MR
2168 * window.c (decode_window, decode_any_window): Move up in code.
2169 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2170 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2171 (Fwindow_buffer): Move up and rewrite doc-string.
2172 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2173 (Fwindow_prev): New functions.
727e958e
MR
2174 (Fwindow_frame): Move here from frame.c. Accept any window as
2175 argument.
2176 (Fframe_root_window, Fframe_first_window)
2177 (Fframe_selected_window): Move here from frame.c. Accept frame
2178 or arbitrary window as argument. Update doc-strings.
2179 (Fminibuffer_window): Move up in code.
2180 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2181 (Fset_frame_selected_window): Move here from frame.c.
2182 Marginal rewrite.
727e958e
MR
2183 (Fselected_window, select_window, Fselect_window): Move up in
2184 code. Minor doc-string fixes.
f230ecc9 2185
4d09bcf6
PE
21862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2187
2188 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2189 Do not assume that spare memory exists; that assumption is valid
2190 only if SYSTEM_MALLOC.
2191 (LARGE_REQUEST): New macro, so that the issue of large requests
2192 is separated from the issue of spare memory.
2193
810928a2
AS
21942011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2195
172418ad
AS
2196 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2197 format. (Bug#8806)
2198
43f862f7
AS
2199 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2200
810928a2
AS
2201 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2202 before statements.
2203
a059fe24
JD
22042011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2205
2206 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2207
2208 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2209
2210 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2211 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2212
989bf368
JB
22132011-06-05 Juanma Barranquero <lekktu@gmail.com>
2214
2215 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2216
4b80f674
CY
22172011-06-04 Chong Yidong <cyd@stupidchicken.com>
2218
2219 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2220 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2221 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2222 New error handlers.
4b80f674
CY
2223 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2224 Obey Vx_select_enable_clipboard_manager. Catch errors in
2225 x_clipboard_manager_save (Bug#8779).
2226 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2227 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2228
99a33b77 22292011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2230
2231 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2232
99a33b77 22332011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2234
2235 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2236 in the current matrix if keep_current_p is non-zero.
2237
8264569d
EZ
22382011-06-04 Eli Zaretskii <eliz@gnu.org>
2239
2240 * bidi.c (bidi_level_of_next_char): Fix last change.
2241
57f97249
EZ
22422011-06-03 Eli Zaretskii <eliz@gnu.org>
2243
fec2107c 2244 Support bidi reordering of text covered by display properties.
57f97249 2245
fec2107c
EZ
2246 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2247 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2248 (bidi_cache_search, bidi_cache_iterator_state)
2249 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2250 (bidi_level_of_next_char, bidi_move_to_visually_next):
2251 Support character positions inside a run of characters covered by a
fec2107c
EZ
2252 display string.
2253 (bidi_paragraph_init, bidi_resolve_explicit_1)
2254 (bidi_level_of_next_char): Call bidi_fetch_char and
2255 bidi_fetch_char_advance instead of FETCH_CHAR and
2256 FETCH_CHAR_ADVANCE.
2257 (bidi_init_it): Initialize new members.
2258 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2259 definitions.
2260 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2261 instead of using explicit *_CHAR codes.
d6d100dd
SM
2262 (bidi_resolve_explicit, bidi_resolve_weak):
2263 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2264 bidirectional text is supported only in multibyte buffers.
2265 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2266 it to initialize the frame_window_p member of struct bidi_it.
2267 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2268 (bidi_resolve_explicit, bidi_resolve_weak)
2269 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2270 bidi_it->nchars is non-positive.
2271 (bidi_level_of_next_char): Don't try to lookup the cache for the
2272 next/previous character if nothing is cached there yet, or if we
2273 were just reseat()'ed to a new position.
c40e2fb2 2274
0e14fe90
EZ
2275 * xdisp.c (set_cursor_from_row): Set start and stop points
2276 according to the row's direction when priming the loop that looks
2277 for the glyph on which to display cursor.
2278 (single_display_spec_intangible_p): Function deleted.
2279 (display_prop_intangible_p): Reimplement to call
2280 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2281 Accept 3 additional arguments needed by handle_display_spec.
2282 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2283 values: lists, `(when COND...)' forms, etc.
2284 (single_display_spec_string_p): Support property values that are
2285 lists with the argument STRING its top-level element.
2286 (display_prop_string_p): Fix the condition for processing a
2287 property that is a list to be consistent with handle_display_spec.
fec2107c 2288 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2289 last portion of handle_display_prop.
2290 (compute_display_string_pos): Accept additional argument
2291 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2292 value of a `display' property is a "replacing spec".
2293 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2294 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2295 the display property, but just return a value indicating whether
2296 the display property will replace the characters it covers.
2297 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2298 frame_window_p members of struct bidi_it.
d6d100dd
SM
2299 (compute_display_string_pos, compute_display_string_end):
2300 New functions.
fec2107c
EZ
2301 (push_it): Accept second argument POSITION, where pop_it should
2302 jump to continue iteration.
2303 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2304
fec2107c
EZ
2305 * keyboard.c (adjust_point_for_property): Adjust the call to
2306 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2307
2308 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2309 (bidi_init_it): Update prototypes.
2310 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2311 (compute_display_string_pos, compute_display_string_end):
2312 Declare prototypes.
fec2107c
EZ
2313 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2314 EMACS_INT.
fc6f18ce 2315
40087514 23162011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2317
57f53182
PE
2318 Malloc failure behavior now depends on size of allocation.
2319 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2320 * lisp.h: Change signatures accordingly.
2321 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2322 All callers changed. (Bug#8762)
2323
2324 * gnutls.c: Use Emacs's memory allocators.
2325 Without this change, the gnutls library would invoke malloc etc.
2326 directly, which causes problems on non-SYNC_INPUT hosts, and which
2327 runs afoul of improving memory_full behavior. (Bug#8761)
2328 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2329 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2330 xfree instead of the default malloc, realloc, free.
2331 (Fgnutls_boot): No need to check for memory allocation failure,
2332 since xmalloc does that for us.
2333
ac32cd99 2334 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2335 * category.c (hash_get_category_set):
2336 * ccl.c (ccl_driver):
2337 * charset.c (Fdefine_charset_internal):
2338 * charset.h (struct charset.hash_index):
2339 * composite.c (get_composition_id, gstring_lookup_cache)
2340 (composition_gstring_put_cache):
2341 * composite.h (struct composition.hash_index):
2342 * dispextern.h (struct image.hash):
2343 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2344 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2345 (hashfn_equal, hashfn_user_defined, make_hash_table)
2346 (maybe_resize_hash_table, hash_lookup, hash_put)
2347 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2348 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2349 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2350 * image.c (make_image, search_image_cache, lookup_image)
2351 (xpm_put_color_table_h):
2352 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2353 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2354 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2355 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2356 * alloc.c (allocate_vectorlike):
2357 Check for overflow in vector size calculations.
2358 * ccl.c (ccl_driver):
2359 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2360 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2361 need to be updated by these changes.
40087514
PE
2362 * fns.c (make_hash_table, maybe_resize_hash_table):
2363 Check for integer overflow with large hash tables.
0de4bb68
PE
2364 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2365 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2366 (SXHASH_REDUCE): New macro.
2367 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2368 Use it instead of discarding useful hash info with large hash values.
2369 (sxhash_float): New function.
2370 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2371 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2372 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2373 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2374 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2375 Adjust signatures to match updated version of code.
2376 (consing_since_gc): Now EMACS_INT, since a single hash table can
2377 use more than INT_MAX bytes.
2378
698d32e2
DN
23792011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2380
2381 Make it possible to build with GCC-4.6+ -O2 -flto.
2382
2383 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2384
fd6fa53f
SM
23852011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2386
2387 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2388 Call minibuffer-inactive-mode.
2389
864db017
JB
23902011-05-31 Juanma Barranquero <lekktu@gmail.com>
2391
2392 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2393 Update dependencies.
2394
2ad0baf4
DN
23952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2396
2397 * data.c (init_data): Remove code for UTS, this system is not
2398 supported anymore.
2399
4fcc2638
DN
24002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2401
2402 Don't force ./temacs to start in terminal mode.
2403
2404 * frame.c (make_initial_frame): Initialize faces in all cases, not
2405 only when CANNOT_DUMP is defined.
2406 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2407
c56e0fd5
DN
24082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2409
2410 * dispnew.c (add_window_display_history): Use const for the string
2411 pointer. Remove declaration, not needed.
2412
333d54da 24132011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2414
55d4c1b2 2415 Use 'inline', not 'INLINE'.
333d54da 2416 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2417 * alloc.c, fontset.c (INLINE): Remove.
2418 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2419 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2420 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2421 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2422 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2423
738db178
DN
24242011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2425
2426 Make it possible to run ./temacs.
2427
2428 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2429 syms_of_callproc does the same thing. Remove test for
2430 "initialized", do it in the caller.
2431 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2432
620c53a6
SM
24332011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2434
2435 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2436 (read_minibuf): Use get_minibuffer.
2437 (syms_of_minibuf): Use DEFSYM.
2438 (Qmetadata): New var.
2439 * data.c (Qbuffer): Don't make it static.
2440 (syms_of_data): Use DEFSYM.
2441
e003a292
PE
24422011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2443
2444 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2445 (CCL_CODE_MIN): New macro.
2446
ed008a6d
PE
24472011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2448
3687c2ef
PE
2449 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2450
ed008a6d
PE
2451 * eval.c (Qdebug): Now static.
2452 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2453 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2454 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2455
d66c4c7c
CY
24562011-05-29 Chong Yidong <cyd@stupidchicken.com>
2457
2458 * image.c: Various fixes to ImageMagick code comments.
2459 (Fimagemagick_types): Doc fix.
2460
5fbc2025
PE
24612011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2462
0196f88a
PE
2463 Minor fixes prompted by GCC 4.6.0 warnings.
2464
2465 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2466
5fbc2025
PE
2467 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2468 (x_clipboard_manager_save_all): Move extern decl to ...
2469 * xterm.h: ... here, so that it can be checked for consistency.
2470
1dd3c2d9
CY
24712011-05-29 Chong Yidong <cyd@stupidchicken.com>
2472
2473 * xselect.c (x_clipboard_manager_save_frame)
2474 (x_clipboard_manager_save_all): New functions.
2475 (Fx_clipboard_manager_save): Lisp function deleted.
2476
2477 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2478 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2479
2480 * xterm.h: Update prototype.
2481
5ba6571d
WX
24822011-05-28 William Xu <william.xwl@gmail.com>
2483
2484 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2485 exiting (Bug#8239).
2486
3eaff834
JM
24872011-05-28 Jim Meyering <meyering@redhat.com>
2488
e1900994 2489 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2490 * fns.c (to_uchar): Define.
2491 (crypto_hash_function): Use it to convert some newly-signed
2492 variables to unsigned, to avoid sign-extension bugs. For example,
2493 without this change, (md5 "truc") would evaluate to
2494 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2495 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2496 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2497
0f6990a7
PE
24982011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2499
2500 Integer overflow fixes.
c8a9ca5a 2501
08686060
PE
2502 * dbusbind.c: Serial number integer overflow fixes.
2503 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2504 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2505 to hold a serial number that is too large for a fixnum.
2506 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2507 Check for serial numbers out of range. Decode any serial number
59568bf0 2508 that was so large that it became a float. (Bug#8722)
08686060 2509
2d1fc3c7
PE
2510 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2511 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2512 Use XFASTINT rather than XUINT when numbers are nonnegative.
2513 (xd_append_arg, Fdbus_method_return_internal):
2514 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2515 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2516 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2517 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2518 (Bug#8722)
2d1fc3c7 2519
c8a9ca5a
PE
2520 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2521
519e1d69
PE
2522 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2523
30569699
PE
2524 ccl: add integer overflow checks
2525 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2526 (IN_INT_RANGE): New macros.
2527 (ccl_driver): Use them to check for integer overflow when
2528 decoding a CCL program. Many of the new checks are whether XINT (x)
2529 fits in int; it doesn't always, on 64-bit hosts. The new version
2530 doesn't catch all possible integer overflows, but it's an
847044ea 2531 improvement. (Bug#8719)
30569699 2532
c11285dc
PE
2533 * alloc.c (make_event_array): Use XINT, not XUINT.
2534 There's no need for unsigned here.
2535
fdccd48e
PE
2536 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2537 This follows up to the 2011-05-06 change that substituted uintptr_t
2538 for EMACS_INT. This case wasn't caught back then.
2539
37910ab2
PE
2540 Rework Fformat to avoid integer overflow issues.
2541 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2542 now (part of C89). Include <verify.h>.
2543 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2544 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2545 (Fformat): Avoid the prepass trying to compute sizes; it was only
2546 approximate and thus did not catch overflow reliably. Instead, walk
2547 through the format just once, formatting and computing sizes as we go,
2548 checking for integer overflow at every step, and allocating a larger
2549 buffer as needed. Keep track separately whether the format is
2550 multibyte. Keep only the most-recently calculated precision, rather
2551 than them all. Record whether each argument has been converted to
2552 string. Use EMACS_INT, not int, for byte and char and arg counts.
2553 Support field widths and precisions larger than INT_MAX. Avoid
2554 sprintf's undefined behavior with conversion specifications such as %#d
2555 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2556 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2557 formatting out-of-range floating point numbers with int
9173deec 2558 formats. (Bug#8668)
37910ab2 2559
2e6578fb
PE
2560 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2561
0ae6bdee
PE
2562 * data.c: Avoid integer truncation in expressions involving floats.
2563 * data.c: Include <intprops.h>.
2564 (arith_driver): When there's an integer overflow in an expression
2565 involving floating point, convert the integers to floating point
2566 so that the resulting value does not suffer from catastrophic
2567 integer truncation. For example, on a 64-bit host (* 4
2568 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
2569 Do not rely on undefined behavior after integer overflow.
2570
de883a70
PE
2571 merge count_size_as_multibyte, parse_str_to_multibyte
2572 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 2573 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
2574 Check for integer overflow.
2575 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
2576 since it's now a duplicate of the other. This is more of
2577 a character than a buffer op, so better that it's in character.c.
2578 * fns.c, print.c: Adjust to above changes.
2579
2ff916cb
PE
25802011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
2581
2582 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
2583
f1b54466
PE
25842011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2585
fb1ac845
PE
2586 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2587 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
2588 (x_clipboard_manager_save): Now static.
2589 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
2590
f1b54466
PE
2591 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
2592 (crypto_hash_function): Now static.
2593 Fix pointer signedness problems. Avoid unnecessary initializations.
2594
a9f737ee
CY
25952011-05-27 Chong Yidong <cyd@stupidchicken.com>
2596
2597 * termhooks.h (Vselection_alist): Make it terminal-local.
2598
2599 * terminal.c (create_terminal): Initialize it.
2600
2601 * xselect.c: Support for clipboard managers.
2602 (Vselection_alist): Move to termhooks.h as terminal-local var.
2603 (LOCAL_SELECTION): New macro.
2604 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
2605 (symbol_to_x_atom): Remove gratuitous arg.
2606 (x_handle_selection_request, lisp_data_to_selection_data)
2607 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
2608 (x_own_selection, x_get_local_selection, x_convert_selection):
2609 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
2610 (some_frame_on_display): Delete unused function.
2611 (Fx_own_selection_internal, Fx_get_selection_internal)
2612 (Fx_disown_selection_internal, Fx_selection_owner_p)
2613 (Fx_selection_exists_p): New optional frame arg.
2614 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
2615 (x_handle_selection_clear): Don't treat other terminals with the
2616 same keyboard specially. Use the terminal-local Vselection_alist.
2617 (x_clear_frame_selections): Use Frun_hook_with_args.
2618
2619 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
2620
2621 * xterm.h: Add support for those atoms.
2622
e067f0c1
CY
26232011-05-26 Chong Yidong <cyd@stupidchicken.com>
2624
2625 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
2626 (converted_selections, conversion_fail_tag): New global variables.
2627 (x_selection_request_lisp_error): Free the above.
2628 (x_get_local_selection): Remove unnecessary code.
2629 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
2630 of converted selections stored in converted_selections.
2631 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
2632 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
2633 (x_convert_selection): New function.
2634 (x_handle_selection_event): Simplify.
2635 (x_get_foreign_selection): Don't ignore incoming requests while
2636 waiting for an answer; this will fail when we implement
2637 SAVE_TARGETS, and seems unnecessary anyway.
2638 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
2639 (Vx_sent_selection_functions): Doc fix.
2640
0f4aebc0
LL
26412011-05-26 Leo Liu <sdl.web@gmail.com>
2642
2643 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
2644
e61124cd
YM
26452011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2646
2647 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
2648
2649 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
2650 for fringe update if it has periodic bitmap.
ac389d0c 2651 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
2652 and fringe_bitmap_periodic_p.
2653
2654 * fringe.c (get_fringe_bitmap_data): New function.
2655 (draw_fringe_bitmap_1, update_window_fringes): Use it.
2656 (update_window_fringes): Record periodicity of fringe bitmap in glyph
2657 row. Mark glyph row for fringe update if periodicity changed.
2658
2659 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
2660 for fringe update unless it has periodic bitmap.
2661
f16d9837
KH
26622011-05-25 Kenichi Handa <handa@m17n.org>
2663
2664 * xdisp.c (get_next_display_element): Set correct it->face_id for
2665 a static composition.
2666
e1b90ef6
LL
26672011-05-24 Leo Liu <sdl.web@gmail.com>
2668
2669 * deps.mk (fns.o):
2670 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
2671
2672 * fns.c (crypto_hash_function, Fsha1): New function.
2673 (Fmd5): Use crypto_hash_function.
2674 (syms_of_fns): Add Ssha1.
2675
7400048f
PE
26762011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 * gnutls.c: Remove unused macros.
2679 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2680 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2681 Remove macros that are defined and never used.
2682 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2683
abb71cf4
CY
26842011-05-22 Chong Yidong <cyd@stupidchicken.com>
2685
2686 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2687 (Fx_get_selection_internal): Minor cleanup.
2688 (Fx_own_selection_internal): Rename arguments for consistency with
2689 select.el.
2690
6307db39
PE
26912011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2692
2693 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2694
f3d4e0a4
CY
26952011-05-22 Chong Yidong <cyd@stupidchicken.com>
2696
2697 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2698
4d8ade89
YM
26992011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2700
2701 * dispnew.c (scrolling_window): Don't exclude the case that the
2702 last enabled row in the desired matrix touches the bottom boundary.
2703
32078c8d
GM
27042011-05-21 Glenn Morris <rgm@gnu.org>
2705
2706 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2707 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2708 and add some more files.
32078c8d 2709
7285dc67
EZ
27102011-05-20 Eli Zaretskii <eliz@gnu.org>
2711
2712 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2713 report_file_error introduced by the change from 2011-05-07.
2714
89d1bd22
PE
27152011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2716
2717 * systime.h (Time): Define only if emacs is defined.
2718 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2719 where the include path doesn't have X11/X.h by default. See
2720 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2721
e23640bb 27222011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2723
2724 * composite.c (find_automatic_composition): Fix previous change.
2725
b9704ad9
GM
27262011-05-20 Glenn Morris <rgm@gnu.org>
2727
2728 * lisp.mk: New file, split from Makefile.in.
2729 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2730 (shortlisp): Remove.
2731 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2732
4a720484
GM
27332011-05-19 Glenn Morris <rgm@gnu.org>
2734
2735 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2736 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2737 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2738 (lisp): Set the order to that of loadup.el.
2739 (shortlisp): Make it a copy of $lisp.
2740 (SOME_MACHINE_LISP): Remove.
2741 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2742 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2743
a28d4396
KH
27442011-05-18 Kenichi Handa <handa@m17n.org>
2745
2746 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2747 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2748 (find_automatic_composition): Mostly rewrite for efficiency.
2749
a2b1fa8e
JB
27502011-05-18 Juanma Barranquero <lekktu@gmail.com>
2751
2752 * makefile.w32-in: Update dependencies.
2753
8e1f5610
CS
27542011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2755
2756 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2757 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2758
7025ee00 27592011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2760
cdfa6eab
PE
2761 Fix some integer overflow issues, such as string length overflow.
2762
06d6db33
PE
2763 * insdel.c (count_size_as_multibyte): Check for string overflow.
2764
2b4560a8
PE
2765 * character.c (lisp_string_width): Check for string overflow.
2766 Use EMACS_INT, not int, for string indexes and lengths; in
2767 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2768 the resulting string length overflows an EMACS_INT; instead,
2769 report a string overflow if no precision given. When checking for
2770 precision exhaustion, use a check that cannot possibly have
2771 integer overflow. (Bug#8675)
2772 * character.h (lisp_string_width): Adjust to new signature.
2773
cb93f9be
PE
2774 * alloc.c (string_overflow): New function.
2775 (Fmake_string): Use it. This doesn't change behavior, but saves
2776 a few bytes and will simplify future changes.
2777 * character.c (string_escape_byte8): Likewise.
2778 * lisp.h (string_overflow): New decl.
2779
1a1f3366
PE
2780 Fixups, following up to the user-interface timestamp change.
2781 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2782 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2783 * msdos.c (mouse_get_pos): Likewise.
2784 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2785 * w32gui.h (Time): Define by including "systime.h" rather than by
2786 declaring it ourselves. (Bug#8664)
2787
d4e3e4d3
PE
2788 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2789 * image.c (clear_image_cache): Likewise.
2790
f6a24d19
PE
2791 * term.c (term_mouse_position): Don't assume time_t wraparound.
2792
08dc5ae6
PE
2793 Be more systematic about user-interface timestamps.
2794 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2795 and sometimes 'EMACS_UINT', to represent these timestamps.
2796 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2797 This makes the code easier to follow, and makes it easier to catch
2798 integer overflow bugs such as Bug#8664.
2799 * frame.c (Fmouse_position, Fmouse_pixel_position):
2800 Use Time, not unsigned long, for user-interface timestamps.
2801 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2802 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2803 * keyboard.h (last_event_timestamp): Likewise.
2804 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2805 * menu.h (xmenu_show): Likewise.
2806 * term.c (term_mouse_position): Likewise.
2807 * termhooks.h (struct input_event.timestamp): Likewise.
2808 (struct terminal.mouse_position_hook): Likewise.
2809 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2810 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2811 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2812 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2813 what it was before.
2814 * menu.h, termhooks.h: Include "systime.h", for Time.
2815
8e55734a
PE
2816 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2817 Don't assume that the difference between two unsigned long values
2818 can fit into an integer. At this point, we know button_down_time
2819 <= event->timestamp, so the difference must be nonnegative, so
2820 there's no need to cast the result if double-click-time is
2821 nonnegative, as it should be; check that it's nonnegative, just in
2822 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2823 apart (about 25 days). (Bug#8664)
8e55734a 2824
841f1b75 2825 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2826 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2827
3e26f69c
PE
2828 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2829 that always fit in int. Use a sentinel instead of a counter, to
2830 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2831 * frame.h (struct frame): Use int for menu_bar_items_used
2832 instead of EMACS_INT, since it always fits in int.
3e26f69c 2833
5cc152c0
PE
2834 * menu.c (grow_menu_items): Check for int overflow.
2835
d89eb65e
PE
2836 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2837
5235bd3e
PE
2838 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2839 Before, the code was not consistent. These values cannot exceed
2840 2**31 - 1 so there's no need to make them unsigned.
2841 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2842 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2843 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2844 as modifiers.
2845 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2846
bc827e23
PE
2847 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2848 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2849 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2850 presumably because the widths might not match.
2851
78eb494e
PE
2852 * window.c (size_window): Avoid needless test at loop start.
2853
04f2d78b
CB
28542011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2855
2856 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2857
d2fc7e3d 28582011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2859
2860 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2861
d2fc7e3d 28622011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2863
2864 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2865 `width' to `bar_area_x' and `bar_area_width', respectively.
2866 (x_scroll_run): Take account of fringe background extension.
2867
04f2d78b
CB
2868 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2869 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2870 `bar_area_width', respectively.
2871 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2872 background extension.
2873
79b70037
GM
28742011-05-10 Jim Meyering <meyering@redhat.com>
2875
2876 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2877
2f142cc5
JB
28782011-05-10 Juanma Barranquero <lekktu@gmail.com>
2879
2880 * image.c (Finit_image_library): Return t for built-in image types,
2881 like pbm and xbm. (Bug#8640)
2882
57679c86
AS
28832011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2884
2885 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2886
888c9e86
EZ
28872011-05-07 Eli Zaretskii <eliz@gnu.org>
2888
b0512a1d
EZ
2889 * w32console.c (Fset_screen_color): Doc fix.
2890 (Fget_screen_color): New function.
2891 (syms_of_ntterm): Defsubr it.
2892
7285dc67
EZ
2893 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2894 unlink the temporary file if Fcall_process didn't create it in the
2895 first place.
2896 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2897 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2898 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2899 cue to call_process_cleanup not to close that handle.
2900
4d3fcc8e
BK
29012011-05-07 Ben Key <bkey76@gmail.com>
2902
2903 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2904 one of two shell specific rules, either bootstrap-temacs-CMD or
2905 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2906 to the previous implementation of the bootstrap-temacs rule.
2907 The bootstrap-temacs-CMD rule is similar to the previous
2908 implementation of the bootstrap-temacs rule except that it
2909 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2910 variable.
2911
2912 These changes, along with some changes to nt/configure.bat,
2913 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2914 earlier fix to add support for --cflags and --ldflags options
2915 that include quotes so that it works whether make uses cmd or
2916 sh as the shell.
2917
b4289b64
MA
29182011-05-06 Michael Albinus <michael.albinus@gmx.de>
2919
2920 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2921 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2922 is a constant.
2923 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2924 a string. Handle both cases.
2925 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2926 (Fdbus_register_method): Use Qinvalid_function.
2927
af4c0e28
JB
29282011-05-06 Juanma Barranquero <lekktu@gmail.com>
2929
2930 * makefile.w32-in: Update dependencies.
2931 (LISP_H): Add inttypes.h and stdin.h.
2932 (PROCESS_H): Add unistd.h.
2933
c51453d9
EZ
29342011-05-06 Eli Zaretskii <eliz@gnu.org>
2935
2936 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2937 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2938
8ff0ac3c 29392011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2940
4c4b566b
PE
2941 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2942
aab2b9b5
PE
2943 * term.c (vfatal): Remove stray call to va_end.
2944 It's not needed and the C Standard doesn't allow it here anyway.
2945
c378da0b
PE
2946 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2947 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2948
288b08c7
PE
2949 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2950 bytes.
2951
e3601888
PE
2952 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2953
db6c0e74
PE
2954 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2955
dd5963ea
PE
2956 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2957
88c9450f
PE
2958 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2959
2f9442b8
PE
2960 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2961
c032b5f8
PE
2962 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2963 * charset.c (Fdefine_charset_internal): Don't initialize
2964 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2965 32-bit int (Bug#8600).
a108c10b
PE
2966
2967 * lread.c (read_integer): Be more consistent with string-to-number.
2968 Use string_to_number to do the actual conversion; this avoids
2969 rounding errors and fixes some other screwups. Without this fix,
2970 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2971 (digit_to_number): Move earlier, for benefit of read_integer.
2972 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2973 not a digit in any supported base. (Bug#8602)
a108c10b 2974
ad5f9eea
PE
2975 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2976
aec1708a
PE
2977 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2978 to match comment at start of function. This also removes a
2979 GCC warning about overflow in a 32+64-bit port.
2980
47be4ab5
PE
2981 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2982
371cac43
PE
2983 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2984 Reported by Stefan Monnier in
2985 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2986 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2987 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2988
d01a7826
PE
2989 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2990 (EMACS_UINTPTR): Likewise, with uintptr_t.
2991
7fd47d5c
PE
2992 * lisp.h: Prefer 64-bit EMACS_INT if available.
2993 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2994 on 32-bit hosts that have 64-bit int, so that they can access
2995 large files.
122b0c86
PE
2996 However, temporarily disable this change unless the temporary
2997 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2998
8727937b
PE
2999 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3000
8ac068ac
PE
3001 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3002 This removes an assumption that EMACS_INT and long are the same
3003 width as pointers. The assumption is true for Emacs porting targets
3004 now, but we want to make other targets possible.
3005 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3006 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3007 In the rest of the code, change types of integers that hold casted
3008 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3009 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3010 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3011 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3012 No need to cast type when ORing.
3013 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3014 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3015 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3016 assume EMACS_INT is the same width as char *.
3017 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3018 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3019 Remove no-longer-needed casts.
3020 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3021 (xg_tool_bar_help_callback, xg_make_tool_item):
3022 Use EMACS_INTPTR to hold an integer
3023 that will be cast to void *; this can avoid a GCC warning
3024 if EMACS_INT is not the same width as void *.
3025 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3026 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3027 (current_message_1, set_message_1):
3028 Use a local to convert to proper width without a cast.
3029 * xmenu.c (dialog_selection_callback): Likewise.
3030
ede49d71
PE
3031 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3032 Also, don't assume VALBITS / RAND_BITS is less than 5,
3033 and don't rely on undefined behavior when shifting a 1 left into
3034 the sign bit.
3035 * lisp.h (get_random): Change signature to match.
3036
2f30ecd0
PE
3037 * lread.c (hash_string): Use size_t, not int, for hash computation.
3038 Normally we prefer signed values; but hashing is special, because
3039 it's better to use unsigned division on hash table sizes so that
3040 the remainder is nonnegative. Also, size_t is the natural width
3041 for hashing into memory. The previous code used 'int', which doesn't
3042 retain enough info to hash well into very large tables.
3043 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3044
2a866e7b
PE
3045 * dbusbind.c: Don't possibly lose pointer info when converting.
3046 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3047 Use XPNTR rather than XHASH, so that the high-order bits of
3048 the pointer aren't lost when converting through void *.
3049
51639eac
PE
3050 * eval.c (Fautoload): Don't double-shift a pointer.
3051
92394119
PE
3052 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3053
dbdb9a7c
JB
30542011-05-06 Juanma Barranquero <lekktu@gmail.com>
3055
3056 * gnutls.c (DEF_GNUTLS_FN):
3057 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3058
db7a0b4f
AS
30592011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3060
3061 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3062 marker. (Bug#8610)
3063
f7ff1b0f 30642011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3065
3066 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3067 New version that can reserve upto 2GB of heap space.
3068
f7ff1b0f 30692011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3070
3071 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3072
639c109b
TZ
30732011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3074
3075 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3076 `gnutls_certificate_set_x509_key_file'.
3077
d2127135
JB
30782011-05-05 Juanma Barranquero <lekktu@gmail.com>
3079
3080 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3081 Update dependencies.
3082
e968f4f3
JB
30832011-05-04 Juanma Barranquero <lekktu@gmail.com>
3084
3085 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3086 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3087 Remove unused parameter `fildes'.
3088 * process.c (read_process_output, send_process): Don't pass it.
3089
84d358f0
JB
30902011-05-04 Juanma Barranquero <lekktu@gmail.com>
3091
3092 Fix previous change: the library cache is defined in w32.c.
3093 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3094 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3095
0898ca10
JB
30962011-05-04 Juanma Barranquero <lekktu@gmail.com>
3097
3098 Implement dynamic loading of GnuTLS on Windows.
3099
3100 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3101 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3102 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3103 Declare.
3104
3105 * gnutls.c (Qgnutls_dll): Define.
3106 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3107 (gnutls_*): Declare function pointers.
3108 (init_gnutls_functions): New function to initialize function pointers.
3109 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3110 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3111 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3112 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3113 (emacs_gnutls_write, emacs_gnutls_read)
3114 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3115 (Fgnutls_available_p): New function.
3116 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3117 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3118 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3119
3120 * image.c: Include w32.h.
3121 (Vimage_type_cache): Delete.
3122 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3123 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3124 (w32_delayed_load): Move to w32.c.
3125
3126 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3127
3128 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3129 (w32_delayed_load): Move from image.c. When loading a library, record
3130 its filename in the :loaded-from property of the library id.
3131 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3132 Initialize and staticpro them.
3133 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3134
3135 * process.c: Include lisp.h before w32.h, not after.
3136 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3137 instead of gnutls_record_check_pending.
3138
3139 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3140
ff4de4aa
TZ
31412011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3142
3143 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3144 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3145 as passed in.
3146
abe95abb
JD
31472011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3148
3149 * xterm.c (x_set_frame_alpha): Do not set property on anything
3150 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3151
e16e55d4
JB
31522011-05-02 Juanma Barranquero <lekktu@gmail.com>
3153
3154 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3155
bafcf6a5
JB
31562011-05-02 Juanma Barranquero <lekktu@gmail.com>
3157
3158 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3159 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3160 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3161 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3162 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3163 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3164 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3165 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3166 (Qgnutls_bootprop_callbacks_verify): Make static.
3167
e7a6747f
AS
31682011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3169
19ed11ba
AS
3170 * callproc.c: Indentation fixup.
3171
e7a6747f 3172 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3173 (wait_for_termination, interruptible_wait_for_termination):
3174 Move after wait_for_termination_1.
e7a6747f 3175
1ef14cb4
LMI
31762011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3177
3178 * sysdep.c (interruptible_wait_for_termination): New function
3179 which is like wait_for_termination, but allows keyboard
3180 interruptions.
3181
3182 * callproc.c (Fcall_process): Add (:file "file") as an option for
3183 the STDOUT buffer.
3184 (Fcall_process_region): Ditto.
3185
330d880c
EZ
31862011-04-30 Eli Zaretskii <eliz@gnu.org>
3187
8db90b73
EZ
3188 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3189 rather than `XVECTOR (FOO)->size'.
3190
330d880c
EZ
3191 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3192 inttypes.h, as a gnulib replacement is used if it not available in
3193 system headers.
3194
15cbd324
EZ
31952011-04-21 Eli Zaretskii <eliz@gnu.org>
3196
3197 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3198 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3199 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3200
3201 * coding.c (coding_alloc_by_realloc): Error out if destination
3202 will grow beyond MOST_POSITIVE_FIXNUM.
3203 (decode_coding_emacs_mule): Abort if there isn't enough place in
3204 charbuf for the composition carryover bytes. Reserve an extra
3205 space for up to 2 characters produced in a loop.
3206 (decode_coding_iso_2022): Abort if there isn't enough place in
3207 charbuf for the composition carryover bytes.
3208
32092011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3210
ae940cca
EZ
3211 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3212 aborting when %lld or %lll format is passed.
3213 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3214 %llo or %llx format is passed. (Bug#8545)
3215
03ab8921
EZ
3216 * window.c (window_scroll_line_based): Use a marker instead of
3217 simple variables to record original value of point. (Bug#7952)
3218
afda1437
EZ
3219 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3220 produced by %s or %c overflows available buffer space. (Bug#8545)
3221
f76dee0c
PE
32222011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3223
3224 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3225 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3226
fdc5744d
JB
32272011-04-28 Juanma Barranquero <lekktu@gmail.com>
3228
3229 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3230
638f053a
JB
32312011-04-28 Juanma Barranquero <lekktu@gmail.com>
3232
3233 * keyboard.c (Qdelayed_warnings_hook): Define.
3234 (command_loop_1): Run `delayed-warnings-hook'
3235 if Vdelayed_warnings_list is non-nil.
3236 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3237 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3238
d178f871
EZ
32392011-04-28 Eli Zaretskii <eliz@gnu.org>
3240
3241 * doprnt.c (doprnt): Don't return value smaller than the buffer
3242 size if the message was truncated. (Bug#8545).
3243
b124fd93
JB
32442011-04-28 Juanma Barranquero <lekktu@gmail.com>
3245
3246 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3247 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3248
e810457d
PE
32492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3250
3251 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3252
ea51cceb
JB
32532011-04-27 Juanma Barranquero <lekktu@gmail.com>
3254
3255 * makefile.w32-in: Update dependencies.
3256
94dcfacf
EZ
32572011-04-27 Eli Zaretskii <eliz@gnu.org>
3258
3259 Improve `doprnt' and its usage. (Bug#8545)
3260 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3261 `format_end'. Remove support for %l as a conversion specifier.
3262 Don't use xrealloc. Improve diagnostics when the %l size modifier
3263 is used. Update the commentary.
3264
3265 * eval.c (verror): Simplify calculation of size_t.
3266
3267 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3268 messages.
3269
f61f41d7
PE
32702011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3271
3272 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3273 change.
3274
96fb4434
PE
32752011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3276
3277 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3278 This makes this file independent of the recent pseudovector change.
3279
671875da 32802011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3281
69e9b5a3
PE
3282 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3283
b5f869a7 3284 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3285 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3286 Remove unused local.
c8926152 3287 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3288
841a1577 3289 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3290 GCC 4.6.0 optimizes based on type-based alias analysis.
3291 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3292 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3293 != &v->size, and therefore "v->size = 1; b->size = 2; return
3294 v->size;" must therefore return 1. This assumption is incorrect
3295 for Emacs, since it type-puns struct Lisp_Vector * with many other
3296 types. To fix this problem, this patch adds a new type struct
f904488f 3297 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3298 and pseudovectors, and helps optimizing compilers not get fooled
3299 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3300 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3301 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3302 the size member.
eab3844f
PE
3303 (XSETPVECTYPE): Rewrite in terms of new macro.
3304 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3305 This is a bit clearer, and further avoids the possibility of
3306 undesirable aliasing.
3307 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3308 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3309 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3310 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3311 (ASIZE): Now uses header.size rather than size.
3312 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3313 to avoid the hassle of writing XVECTOR (foo)->header.size.
3314 (struct vectorlike_header): New type.
eab3844f
PE
3315 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3316 object, to help avoid aliasing.
3317 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3318 (SUBRP): Likewise, since Lisp_Subr is a special case.
3319 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3320 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3321 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3322 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3323 changed to be "header.size" and "header.next".
3324 * buffer.h (struct buffer): Likewise.
3325 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3326 * frame.h (struct frame): Likewise.
3327 * process.h (struct Lisp_Process): Likewise.
3328 * termhooks.h (struct terminal): Likewise.
3329 * window.c (struct save_window_data, struct saved_window): Likewise.
3330 * window.h (struct window): Likewise.
3331 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3332 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3333 * buffer.c (init_buffer_once): Likewise.
3334 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3335 special case.
3336 * process.c (Fformat_network_address): Use local var for size,
3337 for brevity.
3338
0df1eac5
PE
3339 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3340
847ab9d1 3341 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3342 * data.c (atof): Remove decl; no longer used or needed.
3343 (digit_to_number): Move to lread.c.
3344 (Fstring_to_number): Use new string_to_number function, to be
3345 consistent with how the Lisp reader treats infinities and NaNs.
3346 Do not assume that floating-point numbers represent EMACS_INT
3347 without losing information; this is not true on most 64-bit hosts.
3348 Avoid double-rounding errors, by insisting on integers when
3349 parsing non-base-10 numbers, as the documentation specifies.
3350 * lisp.h (string_to_number): New decl, replacing ...
3351 (isfloat_string): Remove.
bc0a5c13 3352 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3353 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3354 appears to have been a coding error. Similarly, do not accept
3355 strings like +-1e0 as floating point numbers. Do not report
3356 overflow for integer overflows unless the base is not 10 which
3357 means we have no simple and reliable way to continue.
3358 Break out the floating-point parsing into a new
3359 function string_to_number, so that Fstring_to_number parses
3360 floating point numbers consistently with the Lisp reader.
04f2d78b 3361 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3362 (E_CHAR, EXP_INT): Remove, replacing with ...
3363 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3364 (string_to_number): New function, replacing isfloat_string.
3365 This function checks for valid syntax and produces the resulting
3366 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3367 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3368 so that overflow for non-base-10 numbers is reported only when
3369 there's no portable and simple way to convert to floating point.
452f4150 3370
67769ffc
PE
3371 * textprop.c (set_text_properties_1): Rewrite for clarity,
3372 and to avoid GCC warning about integer overflow.
3373
c20db43f
PE
3374 * intervals.h (struct interval): Use EMACS_INT for members
3375 where EMACS_UINT might cause problems. See
3376 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3377 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3378 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3379 All uses changed.
37aa2f85
PE
3380 (offset_intervals): Tell GCC not to worry about length overflow
3381 when negating a negative length.
c20db43f 3382
2538aa2f
PE
3383 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3384 (overrun_check_free): Likewise.
3385
f2d3008d
PE
3386 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3387 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3388 word size.
3389
ec8df744
PE
3390 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3391 (gnutls_make_error): Rename local to avoid shadowing.
3392 (gnutls_emacs_global_deinit): ifdef out; not used.
3393 (Fgnutls_boot): Use const for pointer to readonly storage.
3394 Comment out unused local. Fix pointer signedness problems.
3395
640ee02d
PE
3396 * lread.c (openp): Don't stuff size_t into an 'int'.
3397 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3398 about possible signed overflow.
3399
6048fb2a
PE
3400 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3401 (GDK_KEY_g): Don't define if already defined.
3402 (xg_prepare_tooltip): Avoid pointer signedness problem.
3403 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3404
fa3c87e1
PE
3405 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3406 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3407
2172544b
PE
3408 * xfns.c (Fx_window_property): Simplify a bit,
3409 to make a bit faster and to avoid GCC 4.6.0 warning.
3410 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3411
9b821a21
PE
3412 * fns.c (internal_equal): Don't assume size_t fits in int.
3413
3c616cfa
PE
3414 * alloc.c (compact_small_strings): Tighten assertion a little.
3415
c2982e87
PE
3416 Replace pEd with more-general pI, and fix some printf arg casts.
3417 * lisp.h (pI): New macro, generalizing old pEd macro to other
3418 conversion specifiers. For example, use "...%"pI"d..." rather
3419 than "...%"pEd"...".
3420 (pEd): Remove. All uses replaced with similar uses of pI.
3421 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3422 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3423 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3424 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3425 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3426 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3427 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3428 64-bit hosts.
3429 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3430 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3431 * print.c (safe_debug_print, print_object): Likewise.
3432 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3433 to int.
6f04d126
PE
3434 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3435 avoiding the 0 flag, which is not portable.
c2982e87
PE
3436 * process.c (Fmake_network_process): Use pI to avoid cast.
3437 * region-cache.c (pp_cache): Likewise.
3438 * xdisp.c (decode_mode_spec): Likewise.
3439 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3440 behavior on 64-bit hosts with printf arg.
6f04d126 3441 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3442 (x_stop_queuing_selection_requests): Likewise.
3443 (x_get_window_property): Don't truncate byte count to an 'int'
3444 when tracing.
0b432f21 3445
5e073ec7
PE
3446 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3447 here, since it parses constructs like leading '-' and spaces,
3448 which are not wanted; and it overflows with large numbers.
3449 Instead, simply match F[0-9]+, which is what is wanted anyway.
3450
36372bf9
PE
3451 * alloc.c: Remove unportable assumptions about struct layout.
3452 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3453 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3454 (allocate_vectorlike, make_pure_vector): Use the new macros,
3455 plus offsetof, to remove unportable assumptions about struct layout.
3456 These assumptions hold on all porting targets that I know of, but
3457 they are not guaranteed, they're easy to remove, and removing them
3458 makes further changes easier.
3459
0b432f21
PE
3460 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3461 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3462 (string_overrun_cookie): Now const. Use initializers that
3463 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3464 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3465 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3466 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3467 multiple of sizeof (EMACS_INT); it need not be, if
3468 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3469 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3470
895009e1
JB
34712011-04-26 Juanma Barranquero <lekktu@gmail.com>
3472
3473 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3474
6a7a1b0b
TZ
34752011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3476
3477 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3478 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3479 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3480
841a1577 34812011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3482
3483 * lisp.h (Qdebug): List symbol.
895009e1 3484 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3485 * keyboard.c (debug-on-event): New variable.
3486 (handle_user_signal): Break into debugger when debug-on-event
3487 matches the current signal symbol.
3488
f2d3ba6f
DN
34892011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3490
3491 * alloc.c (check_sblock, check_string_bytes)
3492 (check_string_free_list): Convert to standard C.
3493
42ce4c63
TZ
34942011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3495
3496 * w32.c (emacs_gnutls_push): Fix typo.
3497
825cd63c
EZ
34982011-04-25 Eli Zaretskii <eliz@gnu.org>
3499
fb11d64d
EZ
3500 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3501 "cast to pointer from integer of different size".
3502
825cd63c
EZ
3503 Improve doprnt and its use in verror. (Bug#8545)
3504 * doprnt.c (doprnt): Document the set of format control sequences
3505 supported by the function. Use SAFE_ALLOCA instead of always
3506 using `alloca'.
3507
3508 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3509 is one byte too soon. Don't use xrealloc; instead xfree and
3510 xmalloc anew.
3511
e061a11b
TZ
35122011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3513
3514 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3515 callbacks stage.
3516
3517 * gnutls.c: Renamed global_initialized to
3518 gnutls_global_initialized. Added internals for the
3519 :verify-hostname-error, :verify-error, and :verify-flags
3520 parameters of `gnutls-boot' and documented those parameters in the
3521 docstring. Start callback support.
9173deec
JB
3522 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3523 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3524 on error. Return error code.
e061a11b
TZ
3525 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3526 (emacs_gnutls_read): Likewise.
3527 (Fgnutls_boot): Return handshake error code.
3528 (emacs_gnutls_handle_error): New function.
3529 (wsaerror_to_errno): Likewise.
3530
3531 * w32.h (emacs_gnutls_pull): Add prototype.
3532 (emacs_gnutls_push): Likewise.
3533
3534 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3535 (emacs_gnutls_push): Likewise.
3536
35372011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3538
3539 * process.c (wait_reading_process_output): Check if GnuTLS
3540 buffered some data internally if no FDs are set for TLS
3541 connections.
3542
3543 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3544 (LIBS): Link to USER_LIBS.
3545 ($(BLD)/gnutls.$(0)): New target.
3546
fa6996bc
EZ
35472011-04-24 Eli Zaretskii <eliz@gnu.org>
3548
eb35682e
EZ
3549 * xdisp.c (handle_single_display_spec): Rename the
3550 display_replaced_before_p argument into display_replaced_p, to
3551 make it consistent with the commentary. Fix typos in the
3552 commentary.
3553
e2ad650c
EZ
3554 * textprop.c (syms_of_textprop): Remove dead code.
3555 (copy_text_properties): Delete obsolete commentary about an
3556 interface that was deleted long ago. Fix typos in the description
3557 of arguments.
3558
1b2de274
EZ
3559 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3560 to changes in oldXMenu/XMenu.h from 2011-04-16.
3561 <menu_help_message, prev_menu_help_message>: Constify.
3562 (IT_menu_make_room): menu->help_text is now `const char **';
3563 adjust.
3564
3565 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3566 to changes in oldXMenu/XMenu.h from 2011-04-16.
3567 (struct XMenu): Declare `help_text' `const char **'.
3568
3569 * xfaces.c <Qunspecified>: Make extern again.
3570
3571 * syntax.c: Include sys/types.h before including regex.h, as
3572 required by Posix.
3573
762b15be
EZ
3574 * doc.c (get_doc_string): Improve the format passed to `error'.
3575
3576 * doprnt.c (doprnt): Improve commentary.
3577
3578 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
3579
3580 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
3581 them with etags.
3582
f1052e5d
EZ
3583 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
3584 changes in globals.h immediately force recompilation.
762b15be
EZ
3585 (TAGS): Depend on $(CURDIR)/m/intel386.h and
3586 $(CURDIR)/s/ms-w32.h.
3587 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 3588
fa6996bc
EZ
3589 * character.c (Fchar_direction): Function deleted.
3590 (syms_of_character): Don't defsubr it.
3591 <char-direction-table>: Deleted.
3592
e6c3da20
EZ
35932011-04-23 Eli Zaretskii <eliz@gnu.org>
3594
3595 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
3596 * doprnt.c: Include limits.h.
3597 (SIZE_MAX): New macro.
04f2d78b
CB
3598 (doprnt): Return a size_t value. 2nd arg is now size_t.
3599 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
3600 Improve overflow protection. Support `l' modifier for integer
3601 conversions. Support %l conversion. Don't assume an EMACS_INT
3602 argument for integer conversions and for %c.
3603
3604 * lisp.h (doprnt): Restore prototype.
3605
3606 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
3607 $(SRC)/character.h.
3608
3609 * Makefile.in (base_obj): Add back doprnt.o.
3610
3611 * deps.mk (doprnt.o): Add back prerequisites.
3612 (callint.o): Depend on character.h.
3613
3614 * eval.c (internal_lisp_condition_case): Include the handler
3615 representation in the error message.
3616 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
3617 when breaking from the loop.
3618
3619 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
3620
3621 * callint.c (Fcall_interactively): When displaying error message
3622 about invalid control letter, pass the character's codepoint, not
3623 a pointer to its multibyte form. Improve display of the character
3624 in octal and display also its hex code.
3625
3626 * character.c (char_string): Use %x to display the (unsigned)
3627 codepoint of an invalid character, to avoid displaying a bogus
3628 negative value.
3629
3630 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
3631 `error', not SYMBOL_NAME itself.
3632
3633 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
3634 character arguments to `error'.
3635
3636 * charset.c (check_iso_charset_parameter): Fix incorrect argument
3637 to `error' in error message about FINAL_CHAR argument. Make sure
3638 FINAL_CHAR is a character, and use %c when it is passed as
3639 argument to `error'.
3640
4ffd0d6b 36412011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
3642
3643 * s/ms-w32.h (localtime): Redirect to sys_localtime.
3644
3645 * w32.c: Include <time.h>.
3646 (sys_localtime): New function.
3647
4ffd0d6b 36482011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
3649
3650 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
3651
4ffd0d6b 3652 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 3653
4ffd0d6b 36542011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 3655
4ffd0d6b
GM
3656 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
3657 zombies (Bug#8467).
aac0c6e3 3658
04c56954
EZ
36592011-04-19 Eli Zaretskii <eliz@gnu.org>
3660
3661 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
3662 gl_state.e_property when gl_state.object is Qt.
3663
3664 * insdel.c (make_gap_larger): Remove limitation of buffer size
3665 to <= INT_MAX.
3666
16a43933
CY
36672011-04-18 Chong Yidong <cyd@stupidchicken.com>
3668
3669 * xdisp.c (lookup_glyphless_char_display)
3670 (produce_glyphless_glyph): Handle cons cell entry in
3671 glyphless-char-display.
3672 (Vglyphless_char_display): Document it.
3673
3674 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3675 glyphless-char-display.
3676
4581706e
CY
36772011-04-17 Chong Yidong <cyd@stupidchicken.com>
3678
3679 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3680
3681 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3682
3683 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3684 definition for no-X builds.
3685
4887c6e2 36862011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3687
fd35b6f9
PE
3688 Static checks with GCC 4.6.0 and non-default toolkits.
3689
5c1ccb01
PE
3690 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3691
006c5daa
PE
3692 * process.c (keyboard_bit_set): Define only if SIGIO.
3693 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3694 (send_process): Repair possible setjmp clobbering.
3695
efc736d3
PE
3696 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3697
4e2fe2e6
PE
3698 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3699
f97334a2
PE
3700 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3701
4e75f29d
PE
3702 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3703 Define only if needed.
3704
90efadd1
PE
3705 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3706 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3707 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3708
3c647824
PE
3709 * dispextern.h (struct redisplay_interface): Rename param
3710 to avoid shadowing.
e264f262 3711 * termhooks.h (struct terminal): Likewise.
761383f4 3712 * xterm.c (xembed_send_message): Likewise.
3c647824 3713
b58c5c4a
PE
3714 * insdel.c (make_gap_smaller): Define only if
3715 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3716
cad59032
PE
3717 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3718 it.
3719
c339dc2e
PE
3720 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3721 so that we aren't warned about unused symbols.
3722
91a3e27b
PE
3723 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3724
399c71d3 3725 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3726
8ffc96f5
PE
3727 * xfns.c (x_real_positions): Mark locals as initialized.
3728
eef9bc79
PE
3729 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3730
098db9dd
PE
3731 * xterm.c: Fix problems found by static analysis with other toolkits.
3732 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3733 (x_dispatch_event): Declare static if USE_GTK, and
3734 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3735 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3736 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3737 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3738 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3739
eb18f6cc
PE
3740 * xmenu.c (menu_help_callback): Pointer type fixes.
3741 Use const pointers when pointing at readonly data. Avoid pointer
3742 signedness clashes.
3743 (FALSE): Remove unused macro.
3744 (update_frame_menubar): Remove unused decl.
3745
1fe72bf8
PE
3746 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3747
60d9e1db
PE
3748 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3749 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3750 (single_menu_item): Rename local to avoid shadowing.
3751
39261c26
PE
3752 * keyboard.c (make_lispy_event): Remove unused local var.
3753
018c5e19
PE
3754 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3755 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3756
63d2b86e
PE
3757 * bitmaps: Change bitmaps from unsigned char back to the X11
3758 compatible char. Avoid the old compiler warnings about
3759 out-of-range initializers by using, for example, '\xab' rather
3760 than 0xab.
3761
aefd87e1
PE
3762 * xgselect.c (xgselect_initialize): Check vs interface
3763 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3764
bf501fb9
PE
3765 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3766
e9829fdf
PE
3767 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3768 to read-only memory.
3769
1086c095
PE
3770 * fns.c (vector): Remove; this old hack is no longer needed.
3771
2baccd04 3772 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3773 Remove unused var.
dde42981 3774 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3775
72391843 3776 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3777
436c16df 3778 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3779 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3780 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3781
92bb796d 3782 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3783 (x_term_init): Remove local to avoid shadowing.
92bb796d 3784
764430a3 3785 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3786
3787 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3788 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3789
d1dfb56c
EZ
37902011-04-16 Eli Zaretskii <eliz@gnu.org>
3791
c4354cb4
EZ
3792 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3793
d1dfb56c
EZ
3794 Fix regex.c, syntax.c and friends for buffers > 2GB.
3795 * syntax.h (struct gl_state_s): Declare character position members
3796 EMACS_INT.
3797
3798 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3799
04f2d78b
CB
3800 * textprop.c (verify_interval_modification, interval_of):
3801 Declare arguments EMACS_INT.
d1dfb56c
EZ
3802
3803 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3804 EMACS_INT.
3805
3806 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3807
3808 * indent.c (Fvertical_motion): Local variable it_start is now
3809 EMACS_INT.
3810
3811 * regex.c (re_match, re_match_2, re_match_2_internal)
3812 (bcmp_translate, regcomp, regexec, print_double_string)
3813 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3814 (re_compile_pattern, re_exec): Declare arguments and local
3815 variables `size_t' and `ssize_t' and return values `regoff_t', as
3816 appropriate.
3817 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3818 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3819 <compile_stack_type>: `size' and `avail' are now `size_t'.
3820
3821 * regex.h <regoff_t>: Use ssize_t, not int.
3822 (re_search, re_search_2, re_match, re_match_2): Arguments that
3823 specify buffer/string position and length are now ssize_t and
3824 size_t. Return type is regoff_t.
3825
613052cd
BK
38262011-04-16 Ben Key <bkey76@gmail.com>
3827
3828 * nsfont.m: Fixed bugs in ns_get_family and
3829 ns_descriptor_to_entity that were caused by using free to
3830 deallocate memory blocks that were allocated by xmalloc (via
3831 xstrdup). This caused Emacs to crash when compiled with
3832 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3833 --enable-checking=xmallocoverrun). xfree is now used to
3834 deallocate these memory blocks.
3835
4170f62f 38362011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3837
71b41406
PE
3838 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3839
9587a89d
PE
3840 emacs_write: Accept and return EMACS_INT for sizes.
3841 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3842 et seq.
3843 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3844 Accept and return EMACS_INT.
3845 (emacs_gnutls_write): Return the number of bytes written on
3846 partial writes.
3847 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3848 (emacs_read, emacs_write): Remove check for negative size, as the
3849 Emacs source code has been audited now.
9587a89d
PE
3850 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3851 (emacs_read, emacs_write): Use it.
273a5f82
PE
3852 * process.c (send_process): Adjust to the new signatures of
3853 emacs_write and emacs_gnutls_write. Do not attempt to store
3854 a byte offset into an 'int'; it might overflow.
9587a89d 3855 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3856
3e047f51
PE
3857 * sound.c: Don't assume sizes fit in 'int'.
3858 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3859 Return EMACS_INT, not int.
3e047f51 3860 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3861 Accept EMACS_INT, not int.
3862 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3863 record read return values.
3864
cc39a9db
BK
38652011-04-15 Ben Key <bkey76@gmail.com>
3866
c9d0ec6d
JB
3867 * keyboard.c (Qundefined): Don't declare static since it is used
3868 in nsfns.m.
3869 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3870 static since they are used in nsfont.m.
cc39a9db 3871
6c60eb9f
SM
38722011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3873
3874 * process.c (Qprocessp): Don't declare static.
3875 * lisp.h (Qprocessp): Declare again.
3876
7990b61a
JB
38772011-04-15 Juanma Barranquero <lekktu@gmail.com>
3878
3879 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3880
5d4cb038
PE
38812011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3882
8bd7b830 3883 Improve C-level modularity by making more things 'static'.
cd64ea1d 3884
e3b27b31
PE
3885 Don't publish debugger-only interfaces to other modules.
3886 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3887 (verify_bytepos, count_markers): Move decls to the only modules
3888 that need them.
3889 * region-cache.h (pp_cache): Likewise.
3890 * window.h (check_all_windows): Likewise.
3891 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3892
5d4cb038
PE
3893 * sysdep.c (croak): Now static, if
3894 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3895 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3896
3897 * alloc.c (refill_memory_reserve): Now static if
3898 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3899 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3900
e87b6180
PE
3901 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3902 Define only if USE_LUCID.
3903
ac64929e
PE
3904 * xrdb.c (x_customization_string, x_rm_string): Now static.
3905
6f37259d
PE
3906 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3907 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3908
1683e3ab
PE
3909 * xdisp.c (draw_row_with_mouse_face): Now static.
3910 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3911
de9c2632
PE
3912 * window.h (check_all_windows): Mark externally visible.
3913
2b96acb7
PE
3914 * window.c (window_deletion_count): Now static.
3915
3916 * undo.c: Make symbols static if they're not exported.
3917 (last_undo_buffer, last_boundary_position, pending_boundary):
3918 Now static.
3919
50436f33
PE
3920 * textprop.c (interval_insert_behind_hooks): Now static.
3921 (interval_insert_in_front_hooks): Likewise.
3922
64520e5c
PE
3923 * term.c: Make symbols static if they're not exported.
3924 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3925 (max_frame_lines, tty_set_terminal_modes):
3926 (tty_reset_terminal_modes, tty_turn_off_highlight):
3927 (get_tty_terminal): Now static.
3928 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3929 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3930 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3931 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3932 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3933
1fa53021
PE
3934 * sysdep.c: Make symbols static if they're not exported.
3935 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3936 Now static.
3937 (sigprocmask_set, full_mask): Remove; unused.
3938 (wait_debugging): Mark as visible.
3939 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3940 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3941
d4b43b22
PE
3942 * syntax.c (syntax_temp): Define only if !__GNUC__.
3943
b7c513d0
PE
3944 * sound.c (current_sound_device, current_sound): Now static.
3945
989b29ad
PE
3946 * search.c (searchbufs, searchbuf_head): Now static.
3947
13a55a78
PE
3948 * scroll.c (scroll_cost): Remove; unused.
3949 * dispextern.h (scroll_cost): Remove decl.
3950
de68a1fc
PE
3951 * region-cache.h (pp_cache): Mark as externally visible.
3952
40ccffa6
PE
3953 * process.c: Make symbols static if they're not exported.
3954 (process_tick, update_tick, create_process, chan_process):
3955 (Vprocess_alist, proc_buffered_char, datagram_access):
3956 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3957 (deactivate_process): Mark defn as static, as well as decl.
3958 * lisp.h (create_process): Remove decl.
3959 * process.h (chan_process, Vprocess_alist): Remove decls.
3960
ad64fc97
PE
3961 * print.c: Make symbols static if they're not exported.
3962 (print_depth, new_backquote_output, being_printed, print_buffer):
3963 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3964 (print_interval, print_number_index, initial_stderr_stream):
3965 Now static.
3966 * lisp.h (Fprinc): Remove decl.
3967 (debug_output_compilation_hack): Mark as externally visible.
3968
adddb265
PE
3969 * sysdep.c (croak): Move decl from here to syssignal.h.
3970 * syssignal.h (croak): Put it here, so the API can be checked when
3971 'croak' is called from dissociate_if_controlling_tty.
3972
1717ede2
PE
3973 * minibuf.c: Make symbols static if they're not exported.
3974 (minibuf_save_list, choose_minibuf_frame): Now static.
3975 * lisp.h (choose_minibuf_frame): Remove decl.
3976
fa5fb2bc
PE
3977 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3978
1e3890d1
PE
3979 * lread.c: Make symbols static if they're not exported.
3980 (read_objects, initial_obarray, oblookup_last_bucket_number):
3981 Now static.
3982 (make_symbol): Remove; unused.
3983 * lisp.h (initial_obarray, make_symbol): Remove decls.
3984
8a1414fa
PE
3985 * keyboard.c: Make symbols static if they're not exported.
3986 (single_kboard, recent_keys_index, total_keys, recent_keys):
3987 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3988 (this_single_command_key_start, echoing, last_auto_save):
3989 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3990 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3991 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3992 (Vlispy_mouse_stem, double_click_count):
3993 Now static.
3994 (force_auto_save_soon): Define only if SIGDANGER.
3995 (ignore_mouse_drag_p): Now static if
3996 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3997 (print_help): Remove; unused.
3998 (stop_character, last_timer_event): Mark as externally visible.
3999 * keyboard.h (ignore_mouse_drag_p): Declare only if
4000 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4001 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4002 * lisp.h (echoing): Remove decl.
4003 (force_auto_save_soon): Declare only if SIGDANGER.
4004 * xdisp.c (redisplay_window): Simplify code, to make it more
4005 obvious that ignore_mouse_drag_p is not accessed if !defined
4006 USE_GTK && !defined HAVE_NS.
4007
93ea6e8f
PE
4008 * intervals.c: Make symbols static if they're not exported.
4009 (merge_properties_sticky, merge_interval_right, delete_interval):
4010 Now static.
4011 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4012
77382fcc
PE
4013 * insdel.c: Make symbols static if they're not exported.
4014 However, leave prepare_to_modify_buffer alone. It's never
4015 called from outside this function, but that appears to be a bug.
4016 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4017 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4018 (adjust_after_replace_noundo): Remove; unused.
4019 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4020 (signal_before_change): Remove decls.
77382fcc 4021
9306c32e
PE
4022 * indent.c (val_compute_motion, val_vmotion): Now static.
4023
cd44d2eb
PE
4024 * image.c: Make symbols static if they're not exported.
4025 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4026 if USE_GTK.
4027 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4028 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4029
ad9a7a06
PE
4030 * fringe.c (standard_bitmaps): Now static.
4031 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4032
81626931
PE
4033 * frame.c: Make symbols static if they're not exported.
4034 (x_report_frame_params, make_terminal_frame): Now static.
4035 (get_frame_param): Now static, unless HAVE_NS.
4036 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4037 (x_get_resource_string): Remove; not used.
4038 * frame.h (make_terminal_frame, x_report_frame_params):
4039 (x_get_resource_string); Remove decls.
4040 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4041 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4042
239f9db9
PE
4043 * font.c, fontset.c: Make symbols static if they're not exported.
4044 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4045 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4046 * font.c (font_close_object): Now static.
4047 * font.h (font_close_object): Remove.
4048 * fontset.c (FONTSET_OBJLIST): Remove.
4049 (free_realized_fontset) #if-0 the body, which does nothing.
4050 (face_suitable_for_char_p): #if-0, as it's never called.
4051 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4052 * xfaces.c (face_at_string_position):
4053 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4054 since 0 is always ASCII.
4055
dfcf3579
PE
4056 * fns.c (weak_hash_tables): Now static.
4057
5045092b
PE
4058 * fileio.c: Make symbols static if they're not exported.
4059 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4060 (Vwrite_region_annotation_buffers): Now static.
4061
57a96f5c
PE
4062 * eval.c: Make symbols static if they're not exported.
4063 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4064 * lisp.h (backtrace_list): Remove decl.
4065
35f08c38
PE
4066 * emacs.c: Make symbols static if they're not exported.
4067 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4068 (fatal_error_code, fatal_error_signal_hook, standard_args):
4069 Now static.
4070 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4071 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4072 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4073 * lisp.h (fatal_error_signal_hook): Remove decl.
4074 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4075
f44bd759
PE
4076 * editfns.c: Move a (normally-unused) function to its only use.
4077 * editfns.c, lisp.h (get_operating_system_release): Remove.
4078 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4079 worth the hassle of breaking this out.
4080
b532497d
PE
4081 * xterm.c: Make symbols static if they're not exported.
4082 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4083 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4084 (x_destroy_window, x_delete_display):
4085 Now static.
4086 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4087 (x_mouse_leave): Remove; unused.
4088 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4089 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4090 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4091 Remove decls.
4092 (x_mouse_leave): Declare only if WINDOWSNT.
4093 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4094 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4095 USE_X_TOOLKIT.
4096
1675728f
PE
4097 * ftxfont.c: Make symbols static if they're not exported.
4098 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4099 HAVE_FREETYPE.
4100 * font.h (ftxfont_driver): Likewise.
4101
e4cebfca
PE
4102 * xfns.c: Make symbols static if they're not exported.
4103 (x_last_font_name, x_display_info_for_name):
4104 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4105 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4106 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4107 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4108 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4109 (last_show_tip_args): Now static.
4110 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4111 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4112 (x_screen_planes): Remove; unused.
4113 * dispextern.h (x_screen_planes): Remove decl.
4114
5bf46f05
PE
4115 * dispnew.c: Make symbols static if they're not exported.
4116 * dispextern.h (redraw_garbaged_frames, scrolling):
4117 (increment_row_positions): Remove.
4118 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4119 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4120 Now static.
4121 (redraw_garbaged_frames): Remove; unused.
4122
435f4c28
PE
4123 * xfaces.c: Make symbols static if they're not exported.
4124 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4125 Remove decls.
4126 * xterm.h (defined_color): Remove decls.
4127 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4128 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4129 (menu_face_changed_default, defined_color, free_realized_face):
4130 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4131 (ascii_face_of_lisp_face): Remove; unused.
4132
8524aef3
PE
4133 * xdisp.c: Make symbols static if they're not exported.
4134 * dispextern.h (scratch_glyph_row, window_box_edges):
4135 (glyph_to_pixel_coords, set_cursor_from_row):
4136 (get_next_display_element, set_iterator_to_next):
4137 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4138 (show_mouse_face): Remove decls
4139 * frame.h (message_buf_print): Likewise.
4140 * lisp.h (pop_message, set_message, check_point_in_composition):
4141 Likewise.
4142 * xterm.h (set_vertical_scroll_bar): Likewise.
4143 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4144 (message_buf_print, scratch_glyph_row, displayed_buffer):
4145 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4146 (get_next_display_element, show_mouse_face, window_box_edges):
4147 (frame_to_window_pixel_xy, check_point_in_composition):
4148 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4149 (glyph_to_pixel_coords): Remove; unused.
4150
16390cd2
PE
4151 * dired.c (file_name_completion): Now static.
4152
4153 * dbusbind.c (xd_in_read_queued_messages): Now static.
4154
a25f4dfa
PE
4155 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4156 * data.c (circular_list_error): Remove.
4157
14a9c8df
PE
4158 * commands.h (last_point_position, last_point_position_buffer):
4159 (last_point_position_window): Remove decls.
4160 * keyboard.c: Make these variables static.
4161
04f2d78b
CB
4162 * coding.h (coding, code_convert_region, encode_coding_gap):
4163 Remove decls.
74ab6df5
PE
4164 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4165 (iso_code_class, detect_coding, code_convert_region): Now static.
4166 (encode_coding_gap): Remove; unused.
4167
38dfbee1
PE
4168 * chartab.c (chartab_chars, chartab_bits): Now static.
4169
a2cb4e63
PE
4170 * charset.h (charset_iso_8859_1): Remove decl.
4171 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4172 Now static.
4173
127198fd
PE
4174 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4175 * ccl.c (Vccl_program_table): Now static.
4176 (check_ccl_update): Remove; unused.
4177
d85b608f
PE
4178 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4179 * category.h: ... from here.
4180 * category.c (check_category_table, set_category_set): Now static.
4181
31cd66f3
PE
4182 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4183 * lisp.h: Remove these decls.
4184
c358e587
PE
4185 * buffer.c (buffer_count): Remove unused var.
4186
e78aecca
PE
4187 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4188 so that it's not optimized away.
4189 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4190 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4191 exported only to the debugger.
4192
e192d7d3 4193 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4194 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4195
92470028
PE
4196 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4197 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4198 was inaccessible from Lisp.
4199 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4200 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4201
244ed907
PE
4202 alloc.c: Import and export fewer symbols, and remove unused items.
4203 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4204 is defined.
4205 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4206 it's not optimized away by whole-program optimization.
4207 (message_enable_multibyte, free_misc): Remove.
4208 (catchlist, handlerlist, mark_backtrace):
4209 Declare only if BYTE_MARK_STACK.
4210 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4211 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4212 (message_enable_multibyte): Remove decl.
4213 (free_misc, interval_free_list, float_block, float_block_index):
4214 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4215 (cons_free_list, last_marked_index):
4216 Now static.
4217 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4218 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4219 (mark_backtrace): Define only if BYTE_MARK_STACK.
4220 * xdisp.c (message_enable_multibyte): Now static.
4221
61c2b50e 4222 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4223 This makes it easier for human readers (and static analyzers)
4224 to see whether these variables are used from other modules.
4225 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4226 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4227 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4228 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4229 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4230 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4231 * xmenu.c, xselect.c:
4232 Declare Q* vars static if they are not used in other modules.
4233 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4234 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4235 Remove decls of unexported vars.
4236 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4237
95c82688
PE
4238 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4239
16a97296
PE
4240 Make Emacs functions such as Fatom 'static' by default.
4241 This makes it easier for human readers (and static analyzers)
4242 to see whether these functions can be called from other modules.
4243 DEFUN now defines a static function. To make the function external
4244 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4245 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4246 (Finit_image_library):
16a97296
PE
4247 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4248 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4249 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4250 Remove decls, since these functions are now static.
4251 (Funintern, Fget_internal_run_time): New decls, since these functions
4252 were already external.
95c82688 4253
16a97296
PE
4254 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4255 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4256 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4257 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4258 * keyboard.c, keymap.c, lread.c:
4259 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4260 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4261 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4262 Mark functions with DEFUE instead of DEFUN,
4263 if they are used in other modules.
4264 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4265 decls for now-static functions.
4266 * buffer.h (Fdelete_overlay): Remove decl.
4267 * callproc.c (Fgetenv_internal): Mark as internal.
4268 * composite.c (Fremove_list_of_text_properties): Remove decl.
4269 (Fcomposition_get_gstring): New forward static decl.
4270 * composite.h (Fcomposite_get_gstring): Remove decl.
4271 * dired.c (Ffile_attributes): New forward static decl.
4272 * doc.c (Fdocumntation_property): New forward static decl.
4273 * eval.c (Ffetch_bytecode): New forward static decl.
4274 (Funintern): Remove extern decl; now in .h file where it belongs.
4275 * fileio.c (Fmake_symbolic_link): New forward static decl.
4276 * image.c (Finit_image_library): New forward static decl.
4277 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4278 * intervals.h (Fprevious_property_change):
4279 (Fremove_list_of_text_properties): Remove decls.
4280 * keyboard.c (Fthis_command_keys): Remove decl.
4281 (Fcommand_execute): New forward static decl.
4282 * keymap.c (Flookup_key): New forward static decl.
4283 (Fcopy_keymap): Now static.
4284 * keymap.h (Flookup_key): Remove decl.
4285 * process.c (Fget_process): New forward static decl.
4286 (Fprocess_datagram_address): Mark as internal.
4287 * syntax.c (Fsyntax_table_p): New forward static decl.
4288 (skip_chars): Remove duplicate decl.
4289 * textprop.c (Fprevious_property_change): New forward static decl.
4290 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4291 Now internal.
4292 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4293 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4294
785bbd42
PE
4295 * editfns.c (Fformat): Remove unreachable code.
4296
8b913b57
AS
42972011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4298
4299 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4300 change. (Bug#8496)
4301
a6744a35
EZ
43022011-04-13 Eli Zaretskii <eliz@gnu.org>
4303
4304 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4305 when at ZV. (Bug#8487)
4306
e7974947
AS
43072011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4308
baad03f0
AS
4309 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4310 (Bug#8437)
4311 * keyboard.c (parse_tool_bar_item): Likewise.
4312 * sound.c (sound_cleanup, alsa_close): Likewise.
4313 * termcap.c (tgetent): Likewise.
4314 * xfns.c (x_default_font_parameter): Likewise.
4315 * xsettings.c (read_and_apply_settings): Likewise.
4316
e7974947
AS
4317 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4318 (overrun_check_free): Protoize.
4319
28272684
PE
43202011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4321
4322 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4323 since callers should never pass a negative size.
4324 Change the signature to match that of plain 'read' and 'write'; see
4325 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4326 * lisp.h: Update prototypes of emacs_write and emacs_read.
4327
11997c76
EZ
43282011-04-11 Eli Zaretskii <eliz@gnu.org>
4329
4330 * xdisp.c (redisplay_window): Don't try to determine the character
4331 position of the scroll margin if the window start point w->startp
e896f03c 4332 is outside the buffer's accessible region. (Bug#8468)
11997c76 4333
8a2cbd72
EZ
43342011-04-10 Eli Zaretskii <eliz@gnu.org>
4335
4336 Fix write-region and its subroutines for buffers > 2GB.
4337 * fileio.c (a_write, e_write): Modify declaration of arguments and
4338 local variables to support buffers larger than 2GB.
4339 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4340
4341 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4342 argument, local variables, and return value.
4343
4344 * lisp.h: Update prototypes of emacs_write and emacs_read.
4345
4346 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4347
4073e537 43482011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4349
1ebfdcb6
PE
4350 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4351
b2ded58d
PE
4352 Fix more problems found by GCC 4.6.0's static checks.
4353
7d66342c
PE
4354 * xdisp.c (vmessage): Use a better test for character truncation.
4355
bbf47d44
PE
4356 * charset.c (load_charset_map): <, not <=, for optimization,
4357 and to avoid potential problems with integer overflow.
9248994d 4358 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4359 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4360 * editfns.c (Fformat): Likewise.
1e69125e 4361 * syntax.c (skip_chars): Likewise.
3befa583 4362
e3019616
PE
4363 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4364 This also lets GCC 4.6.0 generate slightly better loop code.
4365
becfa255
PE
4366 * callint.c (Fcall_interactively): <, not <=, for optimization.
4367 (Fcall_interactively): Count the number of arguments produced,
4368 not the number of arguments given. This is simpler and lets GCC
4369 4.6.0 generate slightly better code.
4370
dae0cd48
PE
4371 * ftfont.c: Distingish more carefully between FcChar8 and char.
4372 The previous code passed unsigned char * to a functions like
4373 strlen and xstrcasecmp that expect char *, which does not
4374 conform to the C standard.
4375 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4376 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4377 char * when the C standard requires it.
4378
76032d70
PE
4379 * keyboard.c (read_char): Remove unused var.
4380
eb3f1cc8
PE
4381 * eval.c: Port to Windows vsnprintf (Bug#8435).
4382 Include <limits.h>.
4383 (SIZE_MAX): Define if the headers do not.
4384 (verror): Do not give up if vsnprintf returns a negative count.
4385 Instead, grow the buffer. This ports to Windows vsnprintf, which
4386 does not conform to C99. Problem reported by Eli Zaretskii.
4387 Also, simplify the allocation scheme, by avoiding the need for
4388 calling realloc, and removing the ALLOCATED variable.
4389
70476b54
PE
4390 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4391
12020a9e
PE
4392 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4393 But keep the doprint source code for now, as we might revamp it
4394 and use it again (Bug#8435).
ea6c7ae6
PE
4395 * lisp.h (doprnt): Remove.
4396 * Makefile.in (base_obj): Remove doprnt.o.
4397 * deps.mk (doprnt.o): Remove.
4398
5fdb398c
PE
4399 error: Print 32- and 64-bit integers portably (Bug#8435).
4400 Without this change, on typical 64-bit hosts error ("...%d...", N)
4401 was used to print both 32- and 64-bit integers N, which relied on
4402 undefined behavior.
4403 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4404 New macro.
4405 * lisp.h (error, verror): Mark as printf-like functions.
4406 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4407 Report overflow in size calculations when allocating printf buffer.
4408 Do not truncate output string at its first null byte.
4409 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4410 Truncate the output at a character boundary, since vsnprintf does not
4411 do that.
4412 * charset.c (check_iso_charset_parameter): Convert internal
4413 character to string before calling 'error', since %c now has the
4414 printf meaning.
4415 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4416 overflow when computing char to be passed to 'error'. Do not
4417 pass Lisp_Object to 'error'; pass the integer instead.
4418 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4419 formatted with plain %d.
4420
b189fa66
PE
4421 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4422
bff87ef0
PE
4423 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4424
7e2cac20
PE
4425 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4426
ce4d90b5
PE
4427 * xterm.c (x_catch_errors): Remove duplicate declaration.
4428
266c9547
PE
4429 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4430
79c49ad2
PE
4431 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4432
368f4090
JM
44332011-04-10 Jim Meyering <meyering@redhat.com>
4434
4435 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4436 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4437 return ssize_t not "int", and use size_t as the buffer length.
4438 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4439 * gnutls.h: Update declarations.
4440 * process.c (read_process_output): Use ssize_t, to match.
4441 (send_process): Likewise.
4442
a32d4040
CY
44432011-04-09 Chong Yidong <cyd@stupidchicken.com>
4444
4445 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4446
8546720e 44472011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4448
04f2d78b
CB
4449 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4450 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4451
8546720e
GM
4452 * xterm.c (handle_one_xevent):
4453 * xmenu.c (create_and_show_popup_menu):
4454 * xselect.c (x_decline_selection_request)
4455 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4456
0a2f5c1a 44572011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4458
4459 Fix some uses of `int' instead of EMACS_INT.
4460 * search.c (string_match_1, fast_string_match)
4461 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4462 (scan_buffer, find_next_newline_no_quit)
4463 (find_before_next_newline, search_command, Freplace_match)
4464 (Fmatch_data): Make some `int' variables be EMACS_INT.
4465
4466 * xdisp.c (display_count_lines): 3rd argument and return value now
4467 EMACS_INT. All callers changed.
4468 (pint2hrstr): Last argument is now EMACS_INT.
4469
4470 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4471 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4472 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4473 (decode_coding_utf_16, decode_coding_emacs_mule)
4474 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4475 (decode_coding_ccl, decode_coding_charset)
4476 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4477 (decode_coding_iso_2022, decode_coding_emacs_mule)
4478 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4479 <char_offset, last_offset>: Declare EMACS_INT.
4480 (encode_coding_utf_8, encode_coding_utf_16)
4481 (encode_coding_emacs_mule, encode_invocation_designation)
4482 (encode_designation_at_bol, encode_coding_iso_2022)
4483 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4484 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4485 Declare EMACS_INT.
4486 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4487 (encode_invocation_designation): Last argument P_NCHARS is now
4488 EMACS_INT.
4489 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4490 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4491
4492 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4493 All users changed.
4494
4495 * ccl.c (Fccl_execute_on_string): Declare some variables
4496 EMACS_INT.
4497
8546720e 44982011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4499
4500 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4501
4e19a977
CS
45022011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4503
4504 * process.c (Fformat_network_address): Doc fix.
4505
87302331
R
45062011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4507
4508 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4509
cbb59342
CY
45102011-04-08 Chong Yidong <cyd@stupidchicken.com>
4511
4512 * keyboard.c (read_char): Call Lisp function help-form-show,
4513 instead of using internal_with_output_to_temp_buffer.
4514 (Qhelp_form_show): New var.
e0d38eeb 4515 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4516
4517 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4518
4519 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4520
e67a13ab
CY
45212011-04-06 Chong Yidong <cyd@stupidchicken.com>
4522
04f2d78b
CB
4523 * process.c (Flist_processes): Remove to Lisp.
4524 (list_processes_1): Delete.
e67a13ab 4525
973f782d
EZ
45262011-04-06 Eli Zaretskii <eliz@gnu.org>
4527
7c106b1e
EZ
4528 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4529
973f782d
EZ
4530 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4531
41cf7d1a 45322011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4533
ca23cc88
PE
4534 Fix more problems found by GCC 4.6.0's static checks.
4535
f390e2d5
PE
4536 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4537
42eea0d0
PE
4538 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4539
b69769da 4540 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4541
f9541e84
PE
4542 * xdisp.c (vmessage): Mark as a printf-like function.
4543
13841b55
PE
4544 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4545
c136c10f
PE
4546 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4547
5e2d4a30
PE
4548 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4549 printf-like functions.
4550 (tiff_load): Add casts to remove these marks before passing them
4551 to system-supplied API.
4552
583f48b9
PE
4553 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4554
b25d760e
PE
4555 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4556 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4557 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4558 directly, rather than having caller test rule sign. This avoids
4559 some unnecessary tests.
4560 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4561 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4562 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4563
bc7b6697 4564 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4565 (xfont_open): Avoid unnecessary tests.
bc7b6697 4566
27ccc379
PE
4567 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4568
dcd5c89a
PE
4569 * composite.h, composite.c (composition_gstring_put_cache):
4570 Use EMACS_INT, not int, for length.
4571
b13a45c6
PE
4572 * composite.h (COMPOSITION_DECODE_REFS): New macro,
4573 breaking out part of COMPOSITION_DECODE_RULE.
4574 (COMPOSITION_DECODE_RULE): Use it.
4575 * composite.c (get_composition_id): Remove unused local vars,
4576 by using the new macro.
4577
1e792e4d
PE
4578 * textprop.c (set_text_properties_1): Change while to do-while,
4579 since the condition is always true at first.
4580
dc6c6455 4581 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
4582 (interval_deletion_adjustment): Return unsigned value.
4583 All uses changed.
dc6c6455 4584
aba7731a
PE
4585 * process.c (list_processes_1, create_pty, read_process_output):
4586 (exec_sentinel): Remove vars that were set but not used.
afd4052b 4587 (create_pty): Remove unnecessary "volatile"s.
bc57d757 4588 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 4589 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 4590 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 4591
fdfc4bf3
PE
4592 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
4593
fca8fe46 4594 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 4595 (update_syntax_table): Use unsigned instead of int.
fca8fe46 4596
06a0259a 4597 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 4598 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 4599 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 4600
e7b9e80f
PE
4601 * print.c (print_error_message): Avoid int overflow.
4602
56201685
PE
4603 * font.c (font_list_entities): Redo for clarity,
4604 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
4605
78834453 4606 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 4607 (font_score): Avoid potential overflow in diff calculation.
78834453 4608
0bc0b309 4609 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 4610 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 4611
e610eaca
PE
4612 * eval.c (funcall_lambda): Rename local to avoid shadowing.
4613
b895abce
PE
4614 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
4615 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
4616 can always succeed if overflow has undefined behavior.
4617
1f1d9321 4618 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 4619 (wordify): Omit three unnecessary tests.
1f1d9321 4620
c59478bc
PE
4621 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
4622 All callers changed. This avoids the need for an unused var.
4623
79b73827
PE
4624 * casefiddle.c (casify_region): Remove var that is set but not used.
4625
a4db5dfe
PE
4626 * dired.c (file_name_completion): Remove var that is set but not used.
4627
43aae36e
PE
4628 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
4629
2a47c44d 4630 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 4631 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 4632
a37c69bf
PE
4633 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
4634 Check for integer overflow on size calculations.
4635
328ab8e7
PE
4636 * buffer.c (Fprevious_overlay_change): Remove var that is set
4637 but not used.
4638
e5a2a5cb
PE
4639 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
4640 Remove vars that are set but not used.
8d84a6eb 4641 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 4642 (timer_check_2): Mark vars as initialized.
e5a2a5cb 4643
a60e5f68
PE
4644 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
4645
f661cb61 4646 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 4647 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 4648
f0397f5a
PE
4649 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
4650 that are set but not used.
4651
8664db06 4652 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 4653 if XCreateBitmapFromData fails (Bug#8410).
8664db06 4654
6abdaa4a
PE
4655 * xselect.c (x_get_local_selection, x_handle_property_notify):
4656 Remove vars that are set but not used.
4657
0ce7538d 4658 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 4659 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 4660
9ae848fc
PE
4661 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
4662 Remove var that is set but not used.
0b918413
PE
4663 (scroll_bar_windows_size): Now size_t, not int.
4664 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
4665 Check for overflow.
9ae848fc 4666
a5a62657
PE
4667 * xfaces.c (realize_named_face): Remove vars that are set but not used.
4668 (map_tty_color) [!defined MSDOS]: Likewise.
4669
5c5cdd39
PE
4670 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
4671
66ebf983
PE
4672 * coding.c: Remove vars that are set but not used.
4673 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4674 All callers changed.
4675 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4676 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4677 (decode_coding_charset): Remove vars that are set but not used.
4678
1be4d761
PE
4679 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4680 that is set but not used.
4681
47553fa8
PE
4682 * print.c (print_object): Remove var that is set but not used.
4683
1f7196bf 4684 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4685 The gnulib version avoids calling malloc in the usual case,
4686 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4687 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4688 * filelock.c (current_lock_owner): Likewise.
4689 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4690 * sysdep.c: Include allocator.h, careadlinkat.h.
4691 (emacs_no_realloc_allocator): New static constant.
4692 (emacs_readlink): New function.
fdb61804
PE
4693 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4694 ../lib/careadlinkat.h.
d1fdcab7 4695
f84c17c7
SM
46962011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4697
4698 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4699 first non-nil return value).
4700
ef3862ad
JD
47012011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4702
4703 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4704 if not defined (Bug#8403).
4705
376a7006
JB
47062011-04-02 Juanma Barranquero <lekktu@gmail.com>
4707
4708 * xdisp.c (display_count_lines): Remove parameter `start',
4709 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4710 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4711 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4712 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4713 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4714 and thereabouts. All callers changed.
4715 (get_per_char_metric): Remove parameter `f', unused since
4716 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4717
6ca3801d
JM
47182011-04-02 Jim Meyering <meyering@redhat.com>
4719
4720 do not dereference NULL upon failed strdup
4721 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4722 (ns_get_family): Likewise.
4723
d8e2b5ba
JB
47242011-04-02 Juanma Barranquero <lekktu@gmail.com>
4725
4726 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4727
8c74fcbd
JD
47282011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4729
4730 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4731 later (Bug#8403).
4732
7200d79c
SM
47332011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4734
03408648 4735 Add lexical binding.
7200d79c 4736
03408648
SM
4737 * window.c (Ftemp_output_buffer_show): New fun.
4738 (Fsave_window_excursion):
4739 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4740
4741 * lread.c (lisp_file_lexically_bound_p): New function.
4742 (Fload): Bind Qlexical_binding.
4743 (readevalloop): Remove `evalfun' arg.
4744 Bind Qinternal_interpreter_environment.
4745 (Feval_buffer): Bind Qlexical_binding.
4746 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4747 Mark as dynamic.
4748 (syms_of_lread): Declare `lexical-binding'.
4749
4750 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4751
4752 * keyboard.c (eval_dyn): New fun.
4753 (menu_item_eval_property): Use it.
ca105506
SM
4754
4755 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4756
03408648
SM
4757 * fns.c (concat, mapcar1): Accept byte-code-functions.
4758
4759 * eval.c (Fsetq): Handle lexical vars.
4760 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4761 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4762 (FletX, Flet): Obey lexical binding.
4763 (Fcommandp): Handle closures.
4764 (Feval): New `lexical' arg.
4765 (eval_sub): New function extracted from Feval. Use it almost
4766 everywhere where Feval was used. Look up vars in lexical env.
4767 Handle closures.
4768 (Ffunctionp): Move from subr.el.
4769 (Ffuncall): Handle closures.
4770 (apply_lambda): Remove `eval_flags'.
4771 (funcall_lambda): Handle closures and new byte-code-functions.
4772 (Fspecial_variable_p): New function.
4773 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4774 but without exporting it to Lisp.
23aba0ea 4775
23aba0ea 4776 * doc.c (Fdocumentation, store_function_docstring):
03408648 4777 * data.c (Finteractive_form): Handle closures.
23aba0ea 4778
03408648
SM
4779 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4780 interactive spec.
ba83908c 4781
04f2d78b
CB
4782 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4783 New byte-codes.
03408648
SM
4784 (exec_byte_code): New function extracted from Fbyte_code to handle new
4785 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4786
03408648 4787 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4788
03408648 4789 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4790
e2abce01
JB
47912011-03-31 Juanma Barranquero <lekktu@gmail.com>
4792
4793 * xdisp.c (redisplay_internal): Fix prototype.
4794
63696a73 47952011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4796
63696a73 4797 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4798 (try_scrolling): Use it when setting scroll_limit.
4799 Limit scrolling to 100 screen lines.
63696a73
EZ
4800 (redisplay_window): Even when falling back on "recentering",
4801 position point in the window according to scroll-conservatively,
4802 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4803
4804 (try_scrolling): When point is above the window, allow searching
4805 as far as scroll_max, or one screenful, to compute vertical
4806 distance from PT to the scroll margin position. This prevents
4807 try_scrolling from unnecessarily failing when
4808 scroll-conservatively is set to a value slightly larger than the
4809 window height. Clean up the case of PT below the margin at bottom
4810 of window: scroll_max can no longer be INT_MAX. When aggressive
4811 scrolling is in use, don't let point enter the opposite scroll
4812 margin as result of the scroll.
4813 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4814 threshold of 100 lines for never-recentering scrolling.
4815
e4cc2dfc
JB
48162011-03-31 Juanma Barranquero <lekktu@gmail.com>
4817
4818 * dispextern.h (move_it_by_lines):
4819 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4820 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4821 (message_log_check_duplicate): Remove parameters `prev_bol' and
4822 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4823 (redisplay_internal): Remove parameter `preserve_echo_area',
4824 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4825
4826 * indent.c (Fvertical_motion):
4827 * window.c (window_scroll_pixel_based, Frecenter):
4828 Don't pass `need_y_p' to `move_it_by_lines'.
4829
1c470562
SM
48302011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4831
44f230aa
SM
4832 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4833 steal a few bits to be more compact.
4834 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4835 Remove unneeded casts.
4836
1c470562
SM
4837 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4838
888adce9
ZK
48392011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4840
4841 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4842 binding" message (bug#7967).
4843
f838ed7b
PE
48442011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4845
77861b95
PE
4846 Fix more problems found by GCC 4.6.0's static checks.
4847
de6dbc14
PE
4848 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4849 Remove unused local var.
4850
f838ed7b
PE
4851 * editfns.c (Fmessage_box): Remove unused local var.
4852
792c7b2b
PE
4853 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4854 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4855 Omit unused local vars.
c499e557 4856 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4857 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4858 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4859 Omit unused local var.
4860
ba0165e1
PE
4861 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4862 Don't assume string length fits in int.
32ad8845 4863 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4864 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4865
3c59b4c9
PE
4866 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4867 instead of alloca (Bug#8344).
4868
a3eed478 4869 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4870 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4871
eb4d412d
PE
4872 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4873
1658b401
PE
4874 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4875 concerns.
4876
4877 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4878
4879 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4880
9a2c6e05
PE
4881 * keyboard.c (syms_of_keyboard): Use the same style as later
4882 in this function when indexing through an array. This also
4883 works around GCC bug 48267.
4884
03d0a109
PE
4885 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4886
44f730c8
PE
4887 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4888
fe75f926
PE
4889 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4890 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4891
ffa8c828
PE
4892 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4893 This avoids undefined behavior on integer overflow, and is a bit
4894 more convenient anyway since it is compared to a size_t variable.
4895
c5101a77
PE
4896 Variadic C functions now count arguments with size_t, not int.
4897 This avoids an unnecessary limitation on 64-bit machines, which
4898 caused (substring ...) to crash on large vectors (Bug#8344).
4899 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4900 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4901 All variadic functions and their callers changed accordingly.
c5101a77
PE
4902 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4903 * data.c (arith_driver, float_arith_driver): Likewise.
4904 * editfns.c (general_insert_function): Likewise.
4905 * eval.c (struct backtrace.nargs, interactive_p)
4906 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4907 (funcall_lambda, mark_backtrace): Likewise.
4908 * fns.c (concat): Likewise.
4909 * frame.c (x_set_frame_parameters): Likewise.
4910 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4911 0 if not found, not -1. All callers changed.
4912
dd3f25f7
PE
4913 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4914 (stack_copy_size): Now size_t, not int.
4915 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4916
461c2ab9
JB
49172011-03-28 Juanma Barranquero <lekktu@gmail.com>
4918
4919 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4920 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4921 All callers changed.
4922
4923 * lisp.h (multibyte_char_to_unibyte):
4924 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4925 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4926 * character.h (CHAR_TO_BYTE8):
4927 * cmds.c (internal_self_insert):
4928 * editfns.c (general_insert_function):
4929 * keymap.c (push_key_description):
4930 * search.c (Freplace_match):
4931 * xdisp.c (message_dolog, set_message_1): All callers changed.
4932
f6d62986
SM
49332011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4934
4935 * keyboard.c (safe_run_hook_funcall): New function.
4936 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4937 don't set the hook to nil, but remove the offending function instead.
4938 (Qcommand_hook_internal): Remove, unused.
4939 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4940 Vcommand_hook_internal.
4941
4942 * eval.c (enum run_hooks_condition): Remove.
4943 (funcall_nil, funcall_not): New functions.
4944 (run_hook_with_args): Call each function through a `funcall' argument.
4945 Remove `cond' argument, now redundant.
4946 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4947 (Frun_hook_with_args_until_failure): Adjust accordingly.
4948 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4949
1db5b1ad
JB
49502011-03-28 Juanma Barranquero <lekktu@gmail.com>
4951
4952 * dispextern.h (string_buffer_position): Remove declaration.
4953
4954 * print.c (strout): Remove parameter `multibyte', unused since
4955 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4956
4957 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4958 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4959 All callers changed.
4960
4961 * w32.c (_wsa_errlist): Use braces for struct initializers.
4962
4963 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4964 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4965 All callers changed.
4966 (string_buffer_position): Likewise. Also, make static (it's never
4967 used outside xdisp.c).
4968 (cursor_row_p): Remove parameter `w', unused since
4969 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4970 (decode_mode_spec): Remove parameter `precision', introduced during
4971 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4972 All callers changed.
4973
5ffb62aa
JD
49742011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4975
4976 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4977
461c2ab9 49782011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4979
4980 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4981 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4982 (ns_update_auto_hide_menu_bar): New functions.
4983 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4984 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4985 ns_constrain_all_frames.
4986 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4987 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4988
5c380ffb
JD
49892011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4990
4991 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4992
9af30bdf
GM
49932011-03-27 Glenn Morris <rgm@gnu.org>
4994
4995 * syssignal.h: Replace RETSIGTYPE with void.
4996 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4997 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4998 Replace SIGTYPE with void everywhere.
4999 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5000 * s/template.h (SIGTYPE): Remove commented out definition.
5001
e2abce01
JB
50022011-03-26 Eli Zaretskii <eliz@gnu.org>
5003
5004 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5005 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5006
f868cd8a
JB
50072011-03-26 Juanma Barranquero <lekktu@gmail.com>
5008
59eb0929
JB
5009 * w32.c (read_unc_volume): Use parameter `henum', instead of
5010 global variable `wget_enum_handle'.
5011
5012 * keymap.c (describe_vector): Remove parameters `indices' and
5013 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5014 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5015
f868cd8a
JB
5016 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5017
5018 * keyboard.c (timer_check): Remove parameter `do_it_now',
5019 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5020 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5021 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5022
5023 * keyboard.c (read_char):
5024 * w32menu.c (w32_menu_display_help):
5025 * xmenu.c (show_help_event, menu_help_callback):
5026 Adjust calls to `show_help_echo'.
5027
5028 * gtkutil.c (xg_maybe_add_timer):
5029 * keyboard.c (readable_events):
5030 * process.c (wait_reading_process_output):
5031 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5032
5033 * insdel.c (adjust_markers_gap_motion):
5034 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5035 (gap_left, gap_right): Don't call it.
5036
2ecf6fdb
CY
50372011-03-25 Chong Yidong <cyd@stupidchicken.com>
5038
5039 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5040 incurred during fontification.
5041
6b1f9ba4
JB
50422011-03-25 Juanma Barranquero <lekktu@gmail.com>
5043
5044 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5045 (DEFVAR_PER_BUFFER): Don't pass it.
5046
5047 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5048 (scrolling_window): Don't pass it.
5049
0f4a96b5
JB
50502011-03-25 Juanma Barranquero <lekktu@gmail.com>
5051
5052 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5053
5054 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5055 and `suffix'.
5056 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5057 of variables specific to SELinux and computation of `encoded_absname'.
5058
5059 * image.c (XPutPixel): Remove unused variable `height'.
5060
5061 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5062
5063 * unexw32.c (get_section_info): Remove unused variable `section'.
5064
5065 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5066 (system_process_attributes): Remove unused variable `sess'.
5067 (sys_read): Remove unused variable `err'.
5068
5069 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5070 (w32_wnd_proc): Remove unused variable `isdead'.
5071 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5072 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5073 (x_create_tip_frame): Remove unused variable `tem'.
5074
5075 * w32inevt.c (w32_console_read_socket):
5076 Remove unused variable `no_events'.
5077
5078 * w32term.c (x_draw_composite_glyph_string_foreground):
5079 Remove unused variable `width'.
5080
1149507c
JB
50812011-03-24 Juanma Barranquero <lekktu@gmail.com>
5082
5083 * w32term.c (x_set_glyph_string_clipping):
5084 Don't pass uninitialized region to CombineRgn.
5085
9c88f339
JB
50862011-03-23 Juanma Barranquero <lekktu@gmail.com>
5087
5088 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5089 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5090 (Fx_close_connection): Remove unused variable `i'.
5091
5092 * w32font.c (w32font_draw): Return number of glyphs.
5093 (w32font_open_internal): Remove unused variable `i'.
5094 (w32font_driver): Add missing initializer.
5095
5096 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5097 (fill_in_menu): Remove unused variable `items_added'.
5098
5099 * w32term.c (last_mouse_press_frame): Remove static global variable.
5100 (w32_clip_to_row): Remove unused variable `f'.
5101 (x_delete_terminal): Remove unused variable `i'.
5102
5103 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5104 (NOTHING): Remove unused static global variable.
5105 (uniscribe_check_otf): Remove unused variable `table'.
5106 (uniscribe_font_driver): Add missing initializers.
5107
dee091a3
JD
51082011-03-23 Julien Danjou <julien@danjou.info>
5109
5110 * term.c (Fsuspend_tty, Fresume_tty):
5111 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5112 * window.c (temp_output_buffer_show):
5113 * insdel.c (signal_before_change):
5114 * frame.c (Fhandle_switch_frame):
5115 * fileio.c (Fdo_auto_save):
5116 * emacs.c (Fkill_emacs):
5117 * editfns.c (save_excursion_restore):
5118 * cmds.c (internal_self_insert):
5119 * callint.c (Fcall_interactively):
5120 * buffer.c (Fkill_all_local_variables):
5121 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5122 Use Frun_hooks.
0f4a96b5 5123 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5124 unconditionnaly since it does the check itself.
5125
2c520ab5 51262011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5127
c9c49752
PE
5128 Fix more problems found by GCC 4.5.2's static checks.
5129
8abc3f12
PE
5130 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5131 the first time through the loop, since we know p0 < p1 then.
5132 This also avoids a gcc -Wstrict-overflow warning.
5133
a2d26660
PE
5134 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5135 leading to a memory leak, possible in functions like
5136 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5137 of objects (Bug#8318).
a2d26660 5138
916c72e9
PE
5139 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5140 that could (at least in theory) be that large.
5141
19ab8a18
PE
5142 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5143 This is less likely to overflow, and avoids undefined behavior if
5144 overflow does occur. All callers changed. Use strtoul to scan
5145 for the unsigned long integer.
b7cbbd6f
PE
5146 (pint2hrstr): Simplify and tune code slightly.
5147 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5148
f0641eff
PE
5149 * scroll.c (do_scrolling): Work around GCC bug 48228.
5150 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5151
7f650bb9
PE
5152 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5153 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5154 (validate_x_resource_name): Simplify count usage.
5155 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5156
37dd57d1
PE
5157 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5158 fail (Bug#8306).
81e56e61 5159
699979fc 5160 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5161
401bf9b4
PE
5162 * process.c (Fmake_network_process): Use socklen_t, not int,
5163 where POSIX says socklen_t is required in portable programs.
5164 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5165 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5166 (Fmake_network_process, server_accept_connection):
5167 (wait_reading_process_output, read_process_output):
5168 Likewise.
5169
b93aacde
PE
5170 * process.c: Rename or move locals to avoid shadowing.
5171 (list_processes_1, Fmake_network_process):
5172 (read_process_output_error_handler, exec_sentinel_error_handler):
5173 Rename or move locals.
4dc343ee 5174 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5175 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5176 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5177 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5178 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5179
af8a867c 5180 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5181 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5182 Include tparam.h instead, since it declares them.
af8a867c
PE
5183 * cm.h (PC): Remove extern decl; tparam.h now does this.
5184 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5185 * terminfo.c: Include tparam.h, to check interfaces.
5186 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5187 (tparam): Adjust signature to match interface in tparam.h;
5188 this removes some undefined behavior. Check that outstring and len
5189 are zero, which they always are with Emacs.
5190 * tparam.h (PC, BC, UP): New extern decls.
5191
0248044d 5192 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5193 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5194
8ff096c1 5195 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5196 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5197 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5198 (ftfont_list): Remove unused local.
49eaafba
PE
5199 (get_adstyle_property, ftfont_pattern_entity):
5200 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5201 Rename locals to avoid shadowing.
8ff096c1 5202
e2be39f6
PE
5203 * xfont.c (xfont_list_family): Mark var as initialized.
5204
c9735e30
PE
5205 * xml.c (make_dom): Now static.
5206
8f5201ae
PE
5207 * composite.c (composition_compute_stop_pos): Rename local to
5208 avoid shadowing.
b246f932
PE
5209 (composition_reseat_it): Remove unused locals.
5210 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5211 (composition_update_it): Mark var as initialized.
11b61122
PE
5212 (find_automatic_composition): Mark vars as initialized,
5213 with a FIXME (Bug#8290).
8f5201ae 5214
760fbc2c
PE
5215 character.h: Rename locals to avoid shadowing.
5216 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5217 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5218 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5219 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5220 to avoid shadowing.
5221
ff08eb85
PE
5222 * textprop.c (property_change_between_p): Remove; unused.
5223
fc7bf025
PE
5224 * intervals.c (interval_start_pos): Now static.
5225
235d7abc
PE
5226 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5227
44f230aa
SM
5228 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5229 Rename locals to avoid shadowing.
3e7d6594 5230
50060332
PE
5231 * sound.c (wav_play, au_play, Fplay_sound_internal):
5232 Fix pointer signedness.
d01f234b 5233 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5234 (wav_play): Initialize a variable to 0, to prevent undefined
5235 behavior (Bug#8278).
50060332 5236
c4fc4e30
PE
5237 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5238
918436ed
PE
5239 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5240
c939f91b
PE
5241 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5242 clobbering (Bug#8298).
b9c7f648
PE
5243 * sysdep.c (sys_subshell): Likewise.
5244 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5245
6bd8c144
PE
5246 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5247 This should get cleaned up, so that child_setup has the
5248 same signature on all platforms.
5249
7710357c 5250 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5251 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5252
c59da222
CY
52532011-03-22 Chong Yidong <cyd@stupidchicken.com>
5254
5255 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5256 not to be necessary, and produces flickering.
5257
66b87493
GM
52582011-03-20 Glenn Morris <rgm@gnu.org>
5259
5260 * config.in: Remove file.
5261
45b6f6d5
JB
52622011-03-20 Juanma Barranquero <lekktu@gmail.com>
5263
5264 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5265 are now in src/globals.h.
5266 (syms_of_minibuf): Remove spurious & from previous change.
5267
3ec03f7e
LL
52682011-03-20 Leo <sdl.web@gmail.com>
5269
5270 * minibuf.c (completing-read-function): New variable.
5271 (completing-read-default): Rename from completing-read.
5272 (completing-read): Call completing-read-function.
5273
b14e3e21
CY
52742011-03-19 Juanma Barranquero <lekktu@gmail.com>
5275
5276 * xfaces.c (Fx_load_color_file):
5277 Read color file from absolute filename (bug#8250).
5278
f2b726e6
JB
52792011-03-19 Juanma Barranquero <lekktu@gmail.com>
5280
5281 * makefile.w32-in: Update dependencies.
5282
09f6ff02
EZ
52832011-03-17 Eli Zaretskii <eliz@gnu.org>
5284
5285 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5286
29a6015a
PE
52872011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5288
a3a6c54e
PE
5289 Fix more problems found by GCC 4.5.2's static checks.
5290
b766f867
PE
5291 * process.c (make_serial_process_unwind, send_process_trap):
5292 (sigchld_handler): Now static.
5293
be02381c
PE
5294 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5295 That way, the code declares only the vars that it needs.
5296 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5297 * s/cygwin.h (PTY_ITERATION): Likewise.
5298 * s/darwin.h (PTY_ITERATION): Likewise.
5299 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5300
57048744
PE
5301 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5302 * process.c (allocate_pty): Don't declare stb unless it's needed.
5303
7914961c 5304 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5305 (CONSTANTLIM): Remove; unused.
5306 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5307 Define only if needed.
7914961c 5308
b3967b18
PE
5309 * unexelf.c (unexec): Name an expression,
5310 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5311 Use a different way to cause a compilation error if anyone uses
5312 n rather than nn, a way that does not involve shadowing.
73366a00 5313 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5314
29a6015a
PE
5315 * deps.mk (unexalpha.o): Remove; unused.
5316
43cfc33e 5317 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5318 * unexec.h: New file.
ce701a33
PE
5319 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5320 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5321 Depend on unexec.h.
5322 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5323 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5324 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5325 Change as necessary to match prototype in unexec.h.
ce701a33 5326
01f44d5a
PE
5327 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5328 shadowing.
4f63c6bb 5329 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5330
a6670b0b
PE
5331 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5332 Rename locals to avoid shadowing.
5333
cef2010d 5334 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5335 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5336
d4d7173a
PE
5337 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5338
f08b802a
PE
5339 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5340 warning when compiling print.c.
5341
3ddb0639
PE
5342 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5343 instead of using an uninitialized var.
5ad03b97 5344 (font_sort_entities): Mark var as initialized.
3ddb0639 5345
170a2692
PE
5346 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5347
e663c700
PE
5348 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5349 pointers to constants.
89bc529a 5350 (font_parse_fcname): Remove unused vars.
7b81e2d0 5351 (font_delete_unmatched): Now static.
ea838e10 5352 (font_get_spec): Remove; unused.
13a547c6
PE
5353 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5354 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5355 Rename or move locals to avoid shadowing.
e663c700 5356
2a80c887 5357 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5358 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5359
1384fa33 5360 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5361 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5362
8b2c52e9
PE
5363 * alloc.c (mark_backtrace): Move decl from here ...
5364 * lisp.h: ... to here, so that it can be checked.
5365
475545b5 5366 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5367 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5368 (lisp_indirect_variable): Name an expression,
5369 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5370 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5371
b1349114 5372 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5373 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5374 Use const pointer when appropriate.
b1349114 5375
a2928364
PE
5376 * lisp.h (get_system_name, get_operating_system_release):
5377 Move decls here, to check interfaces.
5378 * process.c (get_operating_system_release): Move decl to lisp.h.
5379 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5380 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5381 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5382 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5383 (Fformat_time_string, Fencode_time, Finsert_char):
5384 (Ftranslate_region_internal, Fformat):
5385 Rename or remove local vars to avoid shadowing.
9710023e 5386 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5387
a415e694
PE
5388 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5389 avoid shadowing.
5390
8ef4622d
PE
5391 * lisp.h (eassert): Check that the argument compiles, even if
5392 ENABLE_CHECKING is not defined.
5393
946f9a5b
PE
5394 * data.c (Findirect_variable): Name an expression, to avoid
5395 gcc -Wbad-function-cast warning.
112396d6 5396 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5397 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5398 (Fmake_variable_buffer_local, Fmake_local_variable):
5399 Mark variables as initialized.
52746918 5400 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5401
e5aab7e7 5402 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5403 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5404 Rename locals to avoid shadowing.
dff45157
PE
5405 (mark_stack): Move local variables into the #ifdef region where
5406 they're used.
7bc26fdb
PE
5407 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5408 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5409 needed otherwise.
5410 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5411 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5412 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5413
e5aab7e7
PE
5414 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5415 avoids undefined behavior in theory.
5416
4da60324
PE
5417 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5418
88043301
PE
5419 Use functions, not macros, for up- and down-casing (Bug#8254).
5420 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5421 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5422 to use the following functions instead of these macros.
5423 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5424 EMACS_INT, since callers assume the returned value fits in int.
5425 (upcase1): Likewise, for UPCASE_TABLE.
5426 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5427 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5428 the race-condition problem in the old DOWNCASE.
88043301 5429
19ed5445
PE
5430 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5431 Rename locals to avoid shadowing.
5432 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5433 (regex_compile, re_search_2, re_match_2_internal):
5434 Remove unused local vars.
952db0d7
PE
5435 (FREE_VAR): Rewrite so as not to use empty "else",
5436 which gcc can warn about.
da053e48 5437 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5438 (RETALLOC_IF): Define only if needed.
5439 (WORDCHAR_P): Likewise. This one is never needed, but is used
5440 only in a comment talking about a compiler bug, so put inside
5441 the #if 0 of that comment.
5442 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5443 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5444 Remove; unused.
19ed5445 5445
1f3561e4 5446 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5447 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5448 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5449
ded6f8f7
PE
5450 * search.c (simple_search): Remove unused var.
5451
dbd37a95
PE
5452 * dired.c (compile_pattern): Move decl from here ...
5453 * lisp.h: ... to here, so that it can be checked.
5454 (struct re_registers): New forward decl.
5455
7e47afad
PE
5456 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5457
85f24f61
PE
5458 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5459 All uses changed.
5460 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5461 Rename locals to avoid shadowing.
5671df8f 5462 (Fvertical_motion): Mark locals as initialized.
85f24f61 5463
181aa2be 5464 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5465 (casify_region): Mark local as initialized.
181aa2be 5466
930d429c
PE
5467 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5468
7082eac6
PE
5469 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5470 New macros, so that the caller can use some names other than
5471 gcpro1, gcpro2, etc.
5472 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5473 of the new macros.
5474 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5475 argument, for consistency with GCPRO2_VAR, etc: it is now the
5476 prefix of the variable, not the variable itself. All uses
5477 changed.
38b2c076
PE
5478 * dired.c (directory_files_internal, file_name_completion):
5479 Rename locals to avoid shadowing.
5480
15206ed9
PE
5481 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5482 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5483 dired.c's scmp function, had undefined behavior.
5484 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5485 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5486 * buffer.h: ... to here, because these macros use current_buffer,
5487 and the new implementation with inline functions needs to have
5488 current_buffer in scope now, rather than later when the macros
5489 are used.
5490 (downcase, upcase1): New static inline functions.
5491 (DOWNCASE, UPCASE1): Reimplement using these functions.
5492 This avoids undefined behavior in expressions like
5493 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5494 from race conditions in accessing the global variables
5495 case_temp1 and case_temp2.
5496 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5497 * lisp.h (case_temp1, case_temp2): Remove their decls.
5498 * character.h (ASCII_CHAR_P): Move from here ...
5499 * lisp.h: ... to here, so that the inline functions mentioned
5500 above can use them.
5501
4a6bea26
PE
5502 * dired.c (directory_files_internal_unwind): Now static.
5503
f14b7e14
PE
5504 * fileio.c (file_name_as_directory, directory_file_name):
5505 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5506 Now static.
2893f146
PE
5507 (file_name_as_directory): Use const pointers when appropriate.
5508 (Fexpand_file_name): Likewise. In particular, newdir might
5509 point at constant storage, so make it a const pointer.
fd4ead52 5510 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5511 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5512 signedness issues.
f839df0c
PE
5513 (Fset_file_times, Finsert_file_contents, auto_save_error):
5514 Rename locals to avoid shadowing.
f14b7e14 5515
5716756e 5516 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5517 (Ftry_completion, Fall_completions): Rename or remove locals
5518 to avoid shadowing.
5716756e 5519
b4c3046a
PE
5520 * marker.c (bytepos_to_charpos): Remove; unused.
5521
b45db522
PE
5522 * lisp.h (verify_bytepos, count_markers): New decls,
5523 so that gcc does not warn that these functions aren't declared.
5524
85876d07
PE
5525 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5526 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5527 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5528 (copy_text): Remove unused local var.
85876d07 5529
03d78a21 5530 * filelock.c (within_one_second): Now static.
b3dd38ab 5531 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5532
5df8f01b
PE
5533 * buffer.c (fix_overlays_before): Mark locals as initialized.
5534 (fix_start_end_in_overlays): Likewise. This function should be
5535 simplified by using pointers-to-pointers, but that's a different
5536 matter.
b1d876f1 5537 (switch_to_buffer_1): Now static.
8f54f30a
PE
5538 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5539 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5540
a70072c9 5541 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5542 Fix pointer signedness issue.
edced198
PE
5543 (sys_subshell): Mark local as volatile if checking for lint,
5544 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5545 (MAXPATHLEN): Define only if needed.
a70072c9 5546
a0977c44
PE
5547 * process.c (serial_open, serial_configure): Move decls from here ...
5548 * systty.h: ... to here, so that they can be checked.
5549
a884fdcc
PE
5550 * fns.c (get_random, seed_random): Move extern decls from here ...
5551 * lisp.h: ... to here, so that they can be checked.
5552
604efe86 5553 * sysdep.c (reset_io): Now static.
b8950c94 5554 (wait_for_termination_signal): Remove; unused.
604efe86 5555
38fc62d9
PE
5556 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5557 (copy_keymap_item, append_key, push_text_char_description):
5558 Now static.
1004a21a 5559 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5560 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5561 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5562 (describe_map_tree):
5563 Rename locals to avoid shadowing.
38fc62d9 5564
2f2650da
PE
5565 * keyboard.c: Declare functions static if they are not used elsewhere.
5566 (echo_char, echo_dash, cmd_error, top_level_2):
5567 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5568 (read_char, kbd_buffer_get_event, make_lispy_position):
5569 (make_lispy_event, make_lispy_movement, apply_modifiers):
5570 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
5571 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
5572 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 5573 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 5574 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 5575
a053e86c 5576 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
5577 (mark_kboards): Move decl here ...
5578 * alloc.c (mark_kboards): ... from here.
a053e86c 5579
4752793e
PE
5580 * lisp.h (force_auto_save_soon): New decl.
5581
74f10ca7 5582 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
5583 (DEFINE_DUMMY_FUNCTION): New macro.
5584 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
5585 Use it.
c03cd23f
PE
5586 (main): Add casts to avoid warnings
5587 if GCC considers string literals to be constants.
74f10ca7 5588
022e70d4
PE
5589 * lisp.h (fatal_error_signal): Add decl, since it's exported.
5590
59d6fe83
PE
5591 * dbusbind.c: Pointer signedness fixes.
5592 (xd_signature, xd_append_arg, xd_initialize):
5593 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5594 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5595 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
5596 (Fdbus_register_signal): Use SSDATA when the context wants char *.
5597
78320123
PE
5598 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
5599 if GCC considers string literals to be constants.
49cebcca 5600 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 5601
35ac2a97
SM
56022011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
5603
fb103ca9
SM
5604 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
5605 (print_preprocess, print_object): New macro to fix last change.
5606
35ac2a97
SM
5607 * print.c (print_preprocess): Don't forget font objects.
5608
62973b41
JB
56092011-03-16 Juanma Barranquero <lekktu@gmail.com>
5610
5611 * emacs.c (USAGE3): Doc fixes.
5612
0e48bb22
AS
56132011-03-15 Andreas Schwab <schwab@linux-m68k.org>
5614
5615 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
5616 structure.
5617
7684e57b
JB
56182011-03-14 Juanma Barranquero <lekktu@gmail.com>
5619
5620 * lisp.h (VWindow_system, Qfile_name_history):
5621 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
5622 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
5623 (w32_system_caret_x, w32_system_caret_y): Declare extern.
5624
5625 * w32select.c: Don't #include "keyboard.h".
c96bbc66 5626 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
5627
5628 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
5629 * w32console.c (detect_input_pending, read_input_pending)
5630 (encode_terminal_code):
5631 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
5632 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
5633 (w32_system_caret_y, Qfile_name_history):
5634 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
5635 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
5636 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
5637 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
5638 * w32proc.c (Qlocal, report_file_error):
5639 * w32term.c (Vwindow_system, updating_frame):
5640 * w32uniscribe.c (initialized, uniscribe_font_driver):
5641 Remove unneeded extern declarations.
5642
2aa46d6c
CY
56432011-03-14 Chong Yidong <cyd@stupidchicken.com>
5644
c96bbc66 5645 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 5646
cffc6f3b
CY
56472011-03-13 Chong Yidong <cyd@stupidchicken.com>
5648
5649 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
5650 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
5651 These macros can no longer be used for assignment.
5652
44f230aa
SM
5653 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5654 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
5655 (record_buffer_markers, fetch_buffer_markers): New functions for
5656 recording and fetching special buffer markers.
5657 (set_buffer_internal_1, set_buffer_temp): Use them.
5658
5659 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
5660
5661 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
5662
5663 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
5664 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
5665
5666 * xdisp.c (hscroll_window_tree):
5667 (reconsider_clip_changes): Use PT instead of BUF_PT.
5668
d251f04b
EZ
56692011-03-13 Eli Zaretskii <eliz@gnu.org>
5670
5671 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5672 $(EMACS_ROOT)/lib/intprops.h.
5673
f0c77cd1
PE
56742011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5675
3eca4629
PE
5676 Fix more problems found by GCC 4.5.2's static checks.
5677
7c86ee98
PE
5678 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5679 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5680 (xg_free_frame_widgets): Make it clear that a local variable is
5681 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5682 (gdk_window_get_screen): Make it clear that this macro is needed
5683 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5684 (int_gtk_range_get_value): New function, which avoids a diagnostic
5685 from gcc -Wbad-function-cast.
5686 (xg_set_toolkit_scroll_bar_thumb): Use it.
5687 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5688 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5689 (get_utf8_string, xg_get_file_with_chooser):
5690 Rename locals to avoid shadowing.
5691 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5692
41729b81
PE
5693 * xgselect.c (xg_select): Remove unused var.
5694
f0c77cd1
PE
5695 * image.c (four_corners_best): Mark locals as initialized.
5696 (gif_load): Initialize transparent_p to zero (Bug#8238).
5697 Mark another local as initialized.
ec6cf4c6 5698 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5699
ce0ad53d 5700 * image.c (clear_image_cache): Now static.
d5d5a617 5701 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5702 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5703 (x_edge_detection): Remove unnecessary cast that
5704 gcc -Wbad-function-cast diagnoses.
2037898d 5705 (gif_load): Fix pointer signedness.
6ae141d6
PE
5706 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5707 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5708
33383987 57092011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5710
d32df629
PE
5711 Improve quality of tests for time stamp overflow.
5712 For example, without this patch (encode-time 0 0 0 1 1
5713 1152921504606846976) returns the obviously-bogus value (-948597
5714 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5715 reports time overflow. See
5716 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5717 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5718 * editfns.c: Include limits.h and intprops.h.
5719 (TIME_T_MIN, TIME_T_MAX): New macros.
5720 (time_overflow): Move earlier, to before first use.
5721 (hi_time, lo_time): New functions, for an accurate test for
5722 out-of-range times.
5723 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5724 (Fget_internal_run_time): Don't assume time_t fits in int.
5725 (make_time): Use list2 instead of Fcons twice.
5726 (Fdecode_time): More accurate test for out-of-range times.
5727 (check_tm_member): New function.
5728 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5729 (lisp_time_argument): Don't rely on undefined left-shift and
5730 right-shift behavior when checking for time stamp overflow.
8be6f318 5731
fe31d94c
PE
5732 * editfns.c (time_overflow): New function, refactoring common code.
5733 (Fformat_time_string, Fdecode_time, Fencode_time):
5734 (Fcurrent_time_string): Use it.
5735
8be6f318
PE
5736 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5737 * dired.c (make_time): Move to ...
5738 * editfns.c (make_time): ... here.
5739 * systime.h: Note the move.
5740
09d9db2c 57412011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5742
126bc0dc
YM
5743 * fringe.c (update_window_fringes): Remove unused variables.
5744
c47cbdfd
YM
5745 * unexmacosx.c (copy_data_segment): Also copy __got section.
5746 (Bug#8223)
5747
7ac80be9
EZ
57482011-03-12 Eli Zaretskii <eliz@gnu.org>
5749
c96bbc66 5750 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5751 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5752 Constify `char *' arguments and their references according to
5753 prototypes in tparam.h.
5754
ecb0f94d 5755 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5756
7ac80be9
EZ
5757 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5758 Adapt all references accordingly.
5759
5760 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5761
ef1fd07e
TT
57622011-03-11 Tom Tromey <tromey@redhat.com>
5763
5764 * buffer.c (syms_of_buffer): Remove obsolete comment.
5765
7ef4b50c
EZ
57662011-03-11 Eli Zaretskii <eliz@gnu.org>
5767
5768 * termhooks.h (encode_terminal_code): Declare prototype.
5769
5770 * msdos.c (encode_terminal_code): Don't declare prototype.
5771
5772 * term.c (encode_terminal_code): Now external again, used by
5773 w32console.c and msdos.c.
5774
44f230aa
SM
5775 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5776 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5777
4b1ec863 57782011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5779
1714f52b 5780 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5781
4b1ec863
PE
5782 * fringe.c (update_window_fringes): Mark locals as initialized
5783 (Bug#8227).
5784 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5785
524c7aa6
PE
5786 * alloc.c (mark_fringe_data): Move decl from here ...
5787 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5788 to check its interface.
5789 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5790
a5c0af81 5791 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5792 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5793 (fontset_font): Mark local as initialized.
a9a06e0b 5794 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5795
b4716021
PE
5796 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5797
811e9bac 5798 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5799 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5800 (x_own_selection, Fx_disown_selection_internal): Rename locals
5801 to avoid shadowing.
5802 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5803
7e3ab302
PE
5804 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5805 so that the caller can use some name other than gcpro1.
5806 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5807 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5808 (Fx_backspace_delete_keys_p):
5809 Use them to avoid shadowing, and rename vars to avoid shadowing.
5810 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5811 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5812 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5813 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5814 Remove unused locals.
7e3ab302
PE
5815 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5816 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5817 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5818 macros.
f78faa98 5819
e2b13473
PE
5820 * xterm.h (x_mouse_leave): New decl.
5821
77f23912
PE
5822 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5823 Remove unused functions.
cdf4ba58
PE
5824 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5825 (x_calc_absolute_position): Now static.
7411c686 5826 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5827 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5828 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5829 unless they are used.
38d0b34a
PE
5830 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5831 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5832 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5833 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5834 (x_error_catcher, x_connection_closed, x_error_handler):
5835 (x_error_quitter, xembed_send_message, x_iconify_frame):
5836 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5837 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5838 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5839
44f230aa
SM
5840 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5841 Rename or move locals to avoid shadowing.
6b463e58 5842 (tty_defined_color, merge_face_heights): Now static.
5967d051 5843 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5844 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5845 does not deduce is never used uninitialized.
73719eba
PE
5846 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5847 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5848
426994c3 5849 * terminal.c (store_terminal_param): Now static.
5489860b 5850
032f1620 5851 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5852 (set_frame_menubar): Remove unused local.
d4323972 5853 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5854 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5855 since they might point to immutable storage.
281585b0
PE
5856 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5857 since it's unused otherwise.
032f1620 5858
367c19e5 5859 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5860 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5861 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5862 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5863 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5864 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5865 does not deduce are never used uninitialized.
70739cbe 5866
07b48fa9
PE
5867 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5868
8868a238 5869 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5870 * window.c (window_loop, size_window):
5871 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5872
7e5cf297 5873 * window.c (display_buffer): Now static.
d6550a9f
PE
5874 (size_window): Mark variables that gcc -Wuninitialized
5875 does not deduce are never used uninitialized.
a586633d
PE
5876 * window.h (check_all_windows): New decl, to forestall
5877 gcc -Wmissing-prototypes diagnostic.
5b555da1 5878 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5879
f6095868
PE
5880 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5881 shadowing.
5882 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5883 Include <limits.h>.
5884 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5885 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5886 (load_charset_map): Mark variables that gcc -Wuninitialized
5887 does not deduce are never used uninitialized.
53df7c11 5888 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5889
f38b440c
PE
5890 * coding.c (coding_set_source, coding_set_destination):
5891 Use "else { /* comment */ }" rather than "else /* comment */;"
5892 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5893 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5894 a block, when the outer 'i' will do.
5895 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5896 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5897 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5898 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5899 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5900 Rename locals to avoid shadowing.
5901 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5902 * coding.c (emacs_mule_char, encode_invocation_designation):
5903 Now static, since they're not used elsewhere.
413bb2db 5904 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5905 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5906 (decode_coding_emacs_mule): Mark variables that gcc
5907 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5908 (detect_coding_iso_2022): Initialize a local variable that might
5909 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5910 this initialization is needed. (Bug#8211)
5f58e762
PE
5911 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5912 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5913 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5914 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5915 Remove unused macros.
f38b440c 5916
232b38b9 5917 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5918 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5919 * character.c (string_count_byte8): Likewise.
232b38b9 5920
fb90da1b
PE
5921 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5922 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5923
fb93dbc2
PE
5924 * chartab.c (copy_sub_char_table): Now static, since it's not used
5925 elsewhere.
5c156ace
PE
5926 (sub_char_table_ref_and_range, char_table_ref_and_range):
5927 Rename locals to avoid shadowing.
bbcd0949 5928 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5929
7d3b3862 5930 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5931 (BIDI_BOB): Remove unused macro.
7d3b3862 5932
6be7d3da
PE
5933 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5934 deduce are never used uninitialized.
c2ed9c8b 5935 * term.c (encode_terminal_code): Likewise.
6be7d3da 5936
75f8807f 5937 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5938
50938595
PE
5939 * tparam.h: New file.
5940 * term.c, tparam.h: Include it.
5941 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5942 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5943 Move these decls to tparam.h, and make them agree with what
5944 is actually in tparam.c. The previous trick of using incompatible
5945 decls in different modules does not conform to the C standard.
5946 All callers of tparam changed to use tparam's actual API.
5947 * tparam.c (tparam1, tparam, tgoto):
5948 Use const pointers where appropriate.
5949
fbceeba2
PE
5950 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5951 * cm.h (struct cm): Likewise.
5952 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5953 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5954 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5955 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5956 (turn_on_face, init_tty): Likewise.
5957 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5958
7f3f1250
PE
5959 * term.c (term_mouse_position): Rename local to avoid shadowing.
5960
e6ca6543
PE
5961 * alloc.c (mark_ttys): Move decl from here ...
5962 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5963
c40f8d15
AS
59642011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5965
5966 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5967
cfe0661d
JB
59682011-03-09 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * search.c (compile_pattern_1): Remove argument regp, unused since
5971 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5972 (compile_pattern): Don't pass it.
5973
0afb4571
J
59742011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5975
5976 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5977 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5978 for ! HAVE_GTK3.
5979 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5980
5981 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5982
5983 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5984 gdk_window_get_screen, gdk_window_get_geometry,
5985 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5986 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5987 (xg_get_pixbuf_from_pixmap): New function.
5988 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5989 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5990 Call xg_get_pixbuf_from_pixmap instead of
5991 gdk_pixbuf_get_from_drawable.
5992 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5993 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5994 (xg_check_special_colors): Use GtkStyleContext and its functions
5995 for HAVE_GTK3.
5996 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5997 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5998 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5999 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6000 Call gtk_widget_get_preferred_size.
0afb4571
J
6001 (xg_frame_resized): gdk_window_get_geometry only takes 5
6002 parameters.
44f230aa
SM
6003 (xg_win_to_widget, xg_event_is_for_menubar):
6004 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6005 (xg_set_widget_bg): New function.
6006 (delete_cb): New function.
895009e1 6007 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6008 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6009 (xg_set_background_color): Call xg_set_widget_bg.
6010 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6011 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6012 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6013 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6014 if ! HAVE_GTK3.
6015 (update_frame_tool_bar): Call gtk_widget_hide.
6016 (xg_initialize): Use GDK_KEY_g.
6017
6018 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6019 if ! HAVE_GTK3
6020 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6021
6022 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6023 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6024 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6025
1c2cc4ef
JB
60262011-03-08 Juanma Barranquero <lekktu@gmail.com>
6027
6028 * w32xfns.c (select_palette): Check success of RealizePalette against
6029 GDI_ERROR, not zero.
6030
33383987 6031See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6032
6033;; Local Variables:
6034;; coding: utf-8
aac0c6e3
MR
6035;; End:
6036
33383987 6037 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6038
6039 This file is part of GNU Emacs.
6040
6041 GNU Emacs is free software: you can redistribute it and/or modify
6042 it under the terms of the GNU General Public License as published by
6043 the Free Software Foundation, either version 3 of the License, or
6044 (at your option) any later version.
6045
6046 GNU Emacs is distributed in the hope that it will be useful,
6047 but WITHOUT ANY WARRANTY; without even the implied warranty of
6048 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6049 GNU General Public License for more details.
6050
6051 You should have received a copy of the GNU General Public License
6052 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.