* window.h (struct window): Change type of 'use_time' and
[bpt/emacs.git] / src / ChangeLog
CommitLineData
45942c7d
DA
12012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2
3 * window.h (struct window): Change type of 'use_time' and
4 'sequence_number' from Lisp_Object to int.
5 * frame.c (make_frame): Adjust users accordingly.
6 * print.c (print_object): Likewise.
7 * window.c (select_window, Fwindow_use_time, make_parent_window)
8 (make_window): Likewise.
9
e509cfa6
DA
102012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
11
12 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
13 enabled with --enable-checking=[all,glyphs] configure option.
14 Fix GLYPH_DEBUG usage assuming that it may be undefined,
15 adjust comments accordingly.
16 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
17 undefined, adjust comments accordingly.
18 * image.c: Likewise.
19 * scroll.c: Likewise.
20 * w32fns.c: Likewise.
21 * w32term.c: Likewise.
22 * xdisp.c: Likewise.
23 * xfaces.c: Likewise.
24 * xfns.c: Likewise.
25 * xterm.c: Likewise.
26
a54e2c05
DA
272012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
28
29 Generalize run-time debugging checks.
30 * dispextern.h (XASSERTS): Remove.
31 * fontset.c (xassert): Remove.
32 Convert from xassert to eassert.
33 * alloc.c: Convert from xassert to eassert.
34 * bidi.c: Likewise.
35 * dispnew.c: Likewise.
36 * fns.c: Likewise.
37 * fringe.c: Likewise.
38 * ftfont.c: Likewise.
39 * gtkutil.c: Likewise.
40 * image.c: Likewise.
41 * keyboard.c: Likewise.
42 * menu.c: Likewise.
43 * process.c: Likewise.
44 * scroll.c: Likewise.
45 * sound.c: Likewise.
46 * term.c: Likewise.
47 * w32console.c: Likewise.
48 * w32fns.c: Likewise.
49 * w32term.c: Likewise.
50 * window.c: Likewise.
51 * xdisp.c: Likewise.
52 * xfaces.c: Likewise.
53 * xfns.c: Likewise.
54 * xselect.c: Likewise.
55 * xterm.c: Likewise.
56
1ec4b7b2
SM
572012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
58
59 * fns.c (maybe_resize_hash_table): Output message when growing the
60 purify-hashtable.
61
2014308a
DA
622012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
63
64 * alloc.c (allocate_string_data): Remove dead code.
65 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
66 avoid GCC warning about unused macro.
67
246155eb
DA
682012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
69
70 * alloc.c (allocate_string): Omit intervals initialization.
71 * alloc.c (make_uninit_multibyte_string): Initialize intervals
72 as in make_pure_string and make_pure_c_string.
73
43184b7b
DA
742012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
75
76 * alloc.c (allocate_string): Fix last change.
77
3fe6dd74
DA
782012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
79
80 * alloc.c (allocate_string): Remove two redundant calls
81 to memset, add explicit initialization where appropriate.
82
1ba6038a
GM
832012-06-27 Glenn Morris <rgm@gnu.org>
84
85 * lisp.mk (lisp): Remove paths.elc.
86
c89926a5
CY
872012-06-27 Chong Yidong <cyd@gnu.org>
88
89 * doc.c (Fsubstitute_command_keys): Fix punctuation.
90
ed6b3510
JW
912012-06-26 John Wiegley <johnw@newartisans.com>
92
1ec4b7b2 93 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
94 on Mac OS X Lion: __mod_init_func and __mod_term_func.
95
ed6b3510
JW
96 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
97 when building with Clang.
98
8edd4a2b
SM
992012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
100
101 * eval.c (Fapply): Allow calling it with a single argument.
102
f6f62d1b
EZ
1032012-06-26 Eli Zaretskii <eliz@gnu.org>
104
105 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
106 _stricmp and _strnicmp.
107 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
108
62efea5e
DA
1092012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
110
111 * alloc.c (allocate_window): Zero out non-Lisp part of newly
112 allocated window.
113 (allocate_process): Likewise for new process.
8edd4a2b 114 (allocate_terminal): Change to use offsetof.
62efea5e
DA
115 (allocate_frame): Likewise.
116 * frame.c (make_frame): Omit redundant initialization.
117 * window.c (make_parent_window): Use memset.
118 (make_window): Omit redundant initialization.
119 * process.c (make_process): Omit redundant initialization.
120 * terminal.c (create_terminal): Likewise.
121
42997f4d
DA
1222012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
123
124 * term.c (delete_tty): Remove redundant call to memset.
125
1130ecfc
DA
1262012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
127
128 * alloc.c: Remove build_string.
129 * lisp.h: Define build_string as static inline. This provides
130 a better opportunity to optimize away calls to strlen when the
131 function is called with compile-time constant argument.
132 * image.c (imagemagick_error): Convert to build_string.
133 * w32proc.c (sys_spawnve): Likewise.
134 * xterm.c (x_term_init): Likewise.
135
cf38a720
PE
1362012-06-26 Paul Eggert <eggert@cs.ucla.edu>
137
99027bdd
PE
138 Use sprintf return value instead of invoking strlen on result.
139 In the old days this wasn't portable, since some sprintf
140 implementations returned char *. But they died out years ago and
141 Emacs already assumes sprintf returns int.
142 Similarly for float_to_string.
143 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
144 * ccl.c (ccl_driver):
145 * character.c (string_escape_byte8):
146 * data.c (Fnumber_to_string):
147 * doprnt.c (doprnt):
148 * print.c (print_object):
149 * xdisp.c (message_dolog):
150 * xfns.c (syms_of_xfns):
151 Use sprintf or float_to_string result to avoid need to call strlen.
152 * data.c (Fnumber_to_string):
153 Use make_unibyte_string, since the string must be ASCII.
154 * lisp.h, print.c (float_to_string): Now returns int length.
155 * term.c (produce_glyphless_glyph):
156 Use sprintf result rather than recomputing it.
157
cf38a720
PE
158 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
159 * Makefile.in (ALL_CFLAGS):
160 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
161 * gmalloc.c, regex.c: Include <config.h> unconditionally.
162
3511c784
DA
1632012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
164
0a08eb21 165 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
166 strcasecmp if available.
167 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
168
fb7da12e
AS
1692012-06-25 Andreas Schwab <schwab@linux-m68k.org>
170
171 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
172 Avoid comma operator.
173 * menu.c (push_submenu_start, push_submenu_end)
174 (push_left_right_boundary, push_menu_pane): Likewise.
175 * msdos.c (dos_rawgetc): Likewise.
176
afa2ffd8
DA
1772012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
178
179 * xfns.c (xic_create_fontsetname): Remove redundant calls
180 to memset.
181
b3b4476b
PE
1822012-06-25 Paul Eggert <eggert@cs.ucla.edu>
183
4495ff38
PE
184 * gtkutil.c (get_utf8_string): Remove redundant assignment.
185 sprintf already null-terminates its output.
186
b3b4476b
PE
187 * xfns.c (x_window): Remove redundant cast.
188
b00876c9
DA
1892012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
190
191 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
192 `const char *' to `char *' to avoid compiler warning.
193
d188e26b
PE
1942012-06-24 Paul Eggert <eggert@cs.ucla.edu>
195
885d1d74
PE
196 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
197 instead of truncating it to 63 (admittedly a generous limit).
198
d188e26b
PE
199 * process.c: Fix spelling and caps in comments.
200
e2f560b1
DN
2012012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
202
e86db54b 203 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
204 * sysdep.c (setpgrp): Remove definition, not used in this file.
205
7583a3a1
JB
2062012-06-24 Juanma Barranquero <lekktu@gmail.com>
207
208 * makefile.w32-in: Update dependencies.
209
696056c2
EZ
2102012-06-24 Eli Zaretskii <eliz@gnu.org>
211
212 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
213 (SYSTIME_H): Add nt/inc/sys/time.h.
214
215 * systime.h [WINDOWSNT]: Include sys/time.h.
216
217 * s/ms-w32.h (struct timespec): Definition moved from
218 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
219
845ca893
PE
2202012-06-24 Paul Eggert <eggert@cs.ucla.edu>
221
222 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
223 * buffer.h (buffer_slot_type_mismatch):
224 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
225 * eval.c (unwind_to_catch):
226 * image.c (my_png_error, my_error_exit):
227 * keyboard.c (quit_throw_to_read_char, user_error)
228 (Fexit_recursive_edit, Fabort_recursive_edit):
229 * lisp.h (die, args_out_of_range, args_out_of_range_3)
230 (wrong_type_argument, buffer_overflow, __executable_start)
231 (memory_full, buffer_memory_full, string_overflow, Fthrow)
232 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
233 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
234 (fatal):
235 (child_setup) [!DOS_NT]:
236 * lread.c (end_of_file_error, invalid_syntax):
237 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
238 * puresize.h (pure_write_error):
239 * search.c (matcher_overflow):
240 * sound.c (sound_perror, alsa_sound_perror):
241 * sysdep.c, syssignal.h (croak):
242 * term.c (maybe_fatal, vfatal):
243 * textprop.c (text_read_only):
244 * undo.c (user_error):
245 * unexmacosx.c (unexec_error):
246 * xterm.c (x_ins_del_lines, x_delete_glyphs):
247 Use _Noreturn rather than NO_RETURN.
248 No need for separate decl merely because of _Noreturn.
249 * sound.c (sound_warning, parse_sound):
250 Remove unnecessary forward decls.
251
f1dd8073
PE
2522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
253
254 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
255 * lisp.h (WAIT_READING_MAX): New macro.
256 * dispnew.c (Fsleep_for, sit_for):
257 * keyboard.c (kbd_buffer_get_event):
258 * process.c (Faccept_process_output):
259 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
260 This improves on the previous patch, which introduced a bug
261 when time_t is unsigned and as wide as intmax_t.
262 See <http://bugs.gnu.org/9000#51>.
263
b82c1755
EZ
2642012-06-23 Eli Zaretskii <eliz@gnu.org>
265
266 * dispnew.c (sit_for, Fsleep_for):
267 * keyboard.c (kbd_buffer_get_event):
268 * process.c (Faccept_process_output): Avoid compiler warnings when
269 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
270
ca300656
JB
2712012-06-23 Juanma Barranquero <lekktu@gmail.com>
272
049ec95b
JB
273 * makefile.w32-in: Update dependencies.
274
ca300656
JB
275 * w32.c (ltime): Add return type and declare static.
276 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
277
db7b8d06
PE
2782012-06-23 Paul Eggert <eggert@cs.ucla.edu>
279
280 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
281 Privately reported by Herbert J. Skuhra.
282 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
283 All uses changed.
284 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
285 not make_lisp_timeval, when the argument is of type EMACS_TIME.
286
0bd8297f
EZ
2872012-06-23 Eli Zaretskii <eliz@gnu.org>
288
96512555
EZ
289 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
290 last argument of make_unibyte_string.
291
0bd8297f
EZ
292 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
293 language ID in the event parameters.
294
295 * w32term.c (w32_read_socket): Put the new keyboard codepage into
296 event.code, not the obscure "character set ID".
297
63def6b6
CY
2982012-06-23 Chong Yidong <cyd@gnu.org>
299
300 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
301
e8a02204
EZ
3022012-06-23 Eli Zaretskii <eliz@gnu.org>
303
388cdec0
EZ
304 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
305 * w32.c (fdutimens): New function.
306
307 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
308
309 * s/ms-w32.h (pselect): Redirect to sys_select.
310
311 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
312
e8a02204
EZ
313 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
314 in the logic of incrementing and decrementing the value of
315 use_relocatable_buffers.
316
d054f3fb
PE
3172012-06-23 Paul Eggert <eggert@cs.ucla.edu>
318
319 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
320 Privately reported by Herbert J. Skuhra.
321 [__FreeBSD__]: Remove "*/" typo after "#include".
322 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
323 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
324 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
325 Don't assume EMACS_TIME and struct timeval are the same type.
326
d35af63c
PE
3272012-06-22 Paul Eggert <eggert@cs.ucla.edu>
328
329 Support higher-resolution time stamps (Bug#9000).
330 The time stamps are only nanosecond-resolution at the C level,
331 since that's the best that any real-world system supports now.
332 But they are picosecond-resolution at the Lisp level, as that's
333 easy, and leaves room for future OS improvements.
334
335 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
336 (LIBES): Use it.
337
338 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
339 Don't get current time unless it's needed.
340
341 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
342 now provides it if it's absent.
343 (start_atimer): Port to higher-res time stamps.
344 Check for time stamp overflow. Don't get current time more
345 often than is needed.
346
347 * buffer.h (struct buffer): Buffer modtime now has high resolution.
348 Include systime.h, not time.h.
349 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
350
351 * dired.c: Include stat-time.h.
352 (Ffile-attributes): File times now have higher resolution.
353
354 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
355 (struct image): Timestamp now has higher resolution.
356
357 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
358 has at least microseconds now. All uses removed.
359 (update_frame, update_single_window, update_window, update_frame_1)
360 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
361
362 * editfns.c (time_overflow): Now extern.
363 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
364 (float-time, Fformat_time_string, Fcurrent_time_string)
365 (Fcurrent_time_zone): Accept and generate higher-resolution
366 time stamps.
367 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
368 (decode_time_components, lisp_seconds_argument): New functions.
369 (make_time): Now static.
370 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
371 Report an error if the time is invalid, rather than having the caller
372 do that.
373
374 * fileio.c: Include <stat-time.h>
375 (Fcopy_file): Copy higher-resolution time stamps.
376 Prefer to set the time stamp via a file descriptor if that works.
377 (Fset_file_times, Finsert_file_contents, Fwrite_region)
378 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
379 (Fvisited_file_modtime, Fset_visited_file_modtime):
380 Support higher-resolution time stamps.
381
382 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
383
384 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
385
386 * image.c (prepare_image_for_display, clear_image_cache)
387 (lookup_image): Port to higer-resolution time stamps.
388
389 * keyboard.c (start_polling, bind_polling_period):
390 Check for time stamp overflow.
391 (read_char, kbd_buffer_get_event, timer_start_idle)
392 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
393 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
394 Port to higher-resolution time stamps. Do not assume time_t is signed.
395 (decode_timer): New function. Timers are now vectors of length 9,
396 not 8, to accommodate the picosecond component.
397 (timer_check_2): Use it.
398
399 * nsterm.m (select_timeout, timeval_subtract): Remove.
400 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
401 as they're a bit more accurate and handle overflow better.
402 (ns_select): Change prototype to be compatible with pselect.
403 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
404 * nsterm.h (ns_select): Adjust prototype.
405
406 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
407 us-resolution time stamps.
408 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
409
410 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
411
412 * lisp.h (time_overflow): New decl.
413 (wait_reading_process_output): First arg is now intmax_t, not int,
414 to accommodate larger waits.
415
416 * process.h (struct Lisp_Process.read_output_delay):
417 Now counts nanoseconds, not microseconds.
418 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
419 EMACS_HAS_USECS.
420 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
421 (wait_reading_process_output):
422 Port to ns-resolution time stamps.
423 (Faccept_process_output, wait_reading_process_output):
424 Check for time stamp overflow. Do not assume time_t is signed.
425 (select_wrapper): Remove; we now use pselect.
426 (Fprocess_attributes): Now generates ns-resolution time stamps.
427
428 * sysdep.c: Include utimens.h. Don't include utime.h
429 or worry about struct utimbuf; gnulib does that for us now.
430 (gettimeofday): Remove; gnulib provides a substitute.
431 (make_timeval): New function.
432 (set_file_times): Now sets ns-resolution time stamps.
433 New arg FD; all uses changed.
434 (time_from_jiffies, ltime_from_jiffies, get_up_time)
435 (system_process_attributes):
436 Now returns ns-resolution time stamp. All uses changed.
437 Check for time stamp overflow.
438
439 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
440 provides a substitute now.
441
442 * systime.h: Include timespec.h rather than sys/time.h and time.h,
443 since it guarantees struct timespec.
444 (EMACS_TIME): Now struct timespec, so that we can support
445 ns-resolution time stamps.
446 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
447 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
448 (EMACS_USECS): Remove.
449 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
450 so multiply the arg by 1000 before storing it.
451 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
452 New macros.
453 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
454 Port to ns-resolution time stamps.
455 (EMACS_TIME_NEG_P): Remove; replaced by....
456 (EMACS_TIME_SIGN): New macro.
457 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
458 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
459 (set_file_times, make_time, lisp_time_argument): Adjust signature.
460 (make_timeval, make_lisp_time, decode_time_components): New decls.
461 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
462 that it mishandled time_t overflow. You can't compare by subtracting!
463 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
464 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
465
466 * term.c: Include <sys/time.h>.
467 (timeval_to_Time): New function, for proper overflow wraparound.
468 (term_mouse_position, term_mouse_click): Use it.
469
470 * undo.c (record_first_change): Support higher-resolution time stamps
471 in the undo buffer.
472 (Fprimitive_undo): Use them when restoring time stamps.
473
474 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
475 (w32_get_internal_run_time):
476 Port to higher-resolution Emacs time stamps.
477 (ltime): Now accepts single 64-bit integer, as that's more convenient
478 for callers.
479
480 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
481
482 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
483 for compatibility with pselect. Support ns-resolution time stamps.
484
485 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
486
487 * xselect.c (wait_for_property_change, x_get_foreign_selection):
488 Check for time stamp overflow, and support ns-resolution time stamps.
489
490 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
491 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
492 (timeval_subtract): Remove; no longer needed.
493 (XTflash, XTring_bell, x_wait_for_event):
494 Port to ns-resolution time stamps. Don't assume time_t is signed.
495
b6a92dfe
CY
4962012-06-22 Chong Yidong <cyd@gnu.org>
497
498 * xdisp.c (x_consider_frame_title): Revert last change.
499
d251c37c
EZ
5002012-06-22 Eli Zaretskii <eliz@gnu.org>
501
502 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
503 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
504 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
505 staticidx goes up to 1597 out of 1600 = 0x640.)
506
f10deafb
PE
5072012-06-20 Paul Eggert <eggert@cs.ucla.edu>
508
509 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
510 Otherwise, the umask might be mistakenly 0 while handling input signals.
511
ec6de1e2
SM
5122012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
513
514 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
515
28be1ada
DA
5162012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
517
518 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
519 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
520 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
521 access to `contents' member of Lisp_Vector objects with AREF and ASET
522 where appropriate.
523
c6bf3022
CY
5242012-06-19 Chong Yidong <cyd@gnu.org>
525
526 * frame.c (delete_frame): When selecting a frame on a different
527 text terminal, do not alter the terminal's top-frame.
528
529 * xdisp.c (format_mode_line_unwind_data): Record the target
530 frame's selected window and its terminal's top-frame.
531 (unwind_format_mode_line): Restore them.
532 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
533 Callers changed.
534 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
535 since tty frames can be explicitly named.
536 (prepare_menu_bars): Likewise.
537
538 * term.c (Ftty_top_frame): New function.
539
defd4196
PE
5402012-06-18 Paul Eggert <eggert@cs.ucla.edu>
541
542 Port byte-code-meter to modern targets.
543 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
544 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 545 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
546 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
547 (METER_1, METER_2): Simplify.
548
1053a871
SM
5492012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
550
551 * data.c (Fdefalias): Return `symbol' (bug#11686).
552
b7e8d081
MR
5532012-06-18 Martin Rudalics <rudalics@gmx.at>
554
555 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
556 gets killed during executing of this function (Bug#11665).
557 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
558 (Vkill_buffer_query_functions): In doc-string say that functions
559 run by this hook should not change the current buffer.
560
7ea2b339
PE
5612012-06-18 Paul Eggert <eggert@cs.ucla.edu>
562
563 Fix recently-introduced process.c problems found by static checking.
564 * process.c (write_queue_push, write_queue_pop, send_process):
565 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
566 (write_queue_pop): Fix pointer signedness problem.
567 (send_process): Remove unused local.
568
96a313a1
CY
5692012-06-17 Chong Yidong <cyd@gnu.org>
570
571 * xdisp.c (redisplay_internal): No need to redisplay terminal
572 frames that are not on top.
573
20ca2e94
TN
5742012-06-17 Troels Nielsen <bn.troels@gmail.com>
575
576 * process.c (make_process): Initialize write_queue.
577 (write_queue_push, write_queue_pop): New functions.
578 (send_process): Use them to maintain correct ordering of process
579 writes (Bug#10815).
580
9a900ca9
PE
5812012-06-17 Paul Eggert <eggert@cs.ucla.edu>
582
310fbfa8
PE
583 * lisp.h (eassert): Assume C89 or later.
584 This removes the need for CHECK.
585 (CHECK): Remove. Its comments about always evaluating its
586 argument were confusing, as 'eassert' typically does not evaluate
587 its argument.
588
27bb1ca4
PE
589 * coding.c (produce_chars): Use ptrdiff_t, not int.
590
9a900ca9
PE
591 * xterm.c (x_draw_underwave): Check for integer overflow.
592 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
593
41b7f8bc 5942012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
595
596 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
597 referenced (Bug#11583).
598
9b0e3eba
AA
5992012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
600
601 Implement wave-style variant of underlining.
602 * dispextern.h (face_underline_type): New enum.
603 (face): Add field for underline type.
604 * nsterm.m (ns_draw_underwave): New function.
605 (ns_draw_text_decoration): Use it.
606 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
607 New functions.
608 (x_draw_glyph_string): Use them.
609 * xfaces.c (Qline, Qwave): New Lisp objects.
610 (check_lface_attrs, merge_face_ref)
1053a871
SM
611 (Finternal_set_lisp_face_attribute, realize_x_face):
612 Handle wave-style underline face attributes.
9b0e3eba
AA
613 * xterm.c (x_draw_underwave): New function.
614 (x_draw_glyph_string): Use it.
615
0fb52f11
JB
6162012-06-16 Juanma Barranquero <lekktu@gmail.com>
617
618 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
619 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
620 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
621 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
622 ($(BLD)/w32select.$(O)): Update dependencies.
623
e5560ff7
AS
6242012-06-16 Andreas Schwab <schwab@linux-m68k.org>
625
626 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
627 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
628 * character.c (_fetch_multibyte_char_p): Remove.
629 * alloc.c: Include "character.h" before "buffer.h".
630 * bidi.c: Likewise.
631 * buffer.c: Likewise.
632 * bytecode.c: Likewise.
633 * callint.c: Likewise.
634 * callproc.c: Likewise.
635 * casefiddle.c: Likewise.
636 * casetab.c: Likewise.
637 * category.c: Likewise.
638 * cmds.c: Likewise.
639 * coding.c: Likewise.
640 * composite.c: Likewise.
641 * dired.c: Likewise.
642 * dispnew.c: Likewise.
643 * doc.c: Likewise.
644 * dosfns.c: Likewise.
645 * editfns.c: Likewise.
646 * emacs.c: Likewise.
647 * fileio.c: Likewise.
648 * filelock.c: Likewise.
649 * font.c: Likewise.
650 * fontset.c: Likewise.
651 * fringe.c: Likewise.
652 * indent.c: Likewise.
653 * insdel.c: Likewise.
654 * intervals.c: Likewise.
655 * keyboard.c: Likewise.
656 * keymap.c: Likewise.
657 * lread.c: Likewise.
658 * macros.c: Likewise.
659 * marker.c: Likewise.
660 * minibuf.c: Likewise.
661 * nsfns.m: Likewise.
662 * nsmenu.m: Likewise.
663 * print.c: Likewise.
664 * process.c: Likewise.
665 * regex.c: Likewise.
666 * region-cache.c: Likewise.
667 * search.c: Likewise.
668 * syntax.c: Likewise.
669 * term.c: Likewise.
670 * textprop.c: Likewise.
671 * undo.c: Likewise.
672 * unexsol.c: Likewise.
673 * w16select.c: Likewise.
674 * w32fns.c: Likewise.
675 * w32menu.c: Likewise.
676 * window.c: Likewise.
677 * xdisp.c: Likewise.
678 * xfns.c: Likewise.
679 * xmenu.c: Likewise.
680 * xml.c: Likewise.
681 * xselect.c: Likewise.
682
2f07e6af
EZ
6832012-06-16 Eli Zaretskii <eliz@gnu.org>
684
1053a871
SM
685 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
686 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 687 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
688 row.
689 (handle_face_prop): Use chunk-relative overlay string index when
690 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
691 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
692 the rightmost. (Bug#11720)
2f07e6af 693
29b83cec
AS
6942012-06-16 Andreas Schwab <schwab@linux-m68k.org>
695
696 * category.h (CHAR_HAS_CATEGORY): Define as inline.
697 (CATEGORY_MEMBER): Enforce 1/0 value.
698 * category.c (_temp_category_set): Remove.
699
4c5501e9
EZ
7002012-06-16 Eli Zaretskii <eliz@gnu.org>
701
702 * window.c (Fdelete_other_windows_internal)
703 (Fdelete_window_internal): Don't access frame's mouse highlight
704 info of the initial frame. (Bug#11677)
705
2b570124
PE
7062012-06-14 Paul Eggert <eggert@cs.ucla.edu>
707
e93864f9
PE
708 * .gdbinit (xgetint): Fix recently-introduced paren typo.
709 Assume USE_2_TAGS_FOR_INTS.
710 (xreload): Adjust $tagmask width to match recent lisp.h change.
711
2b570124
PE
712 Simplify lisp.h in minor ways that should not affect code.
713 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
714 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
715 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
716 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
717 (INTTYPEBITS): New macro, for clarity.
718 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
719 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
720 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
721 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
722 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
723
81755f69
JB
7242012-06-13 Juanma Barranquero <lekktu@gmail.com>
725
726 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
727
16192a57
GM
7282012-06-13 Glenn Morris <rgm@gnu.org>
729
730 * s/bsd-common.h (BSD4_3):
731 * s/usg5-4-common.h (USG5_4): No longer define; unused.
732
646b5f55
AS
7332012-06-13 Andreas Schwab <schwab@linux-m68k.org>
734
735 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
736 instead of union.
737 (XLI, XIL): Define.
1053a871
SM
738 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
739 Use them.
740 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 741 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 742 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
743 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
744 * frame.c (delete_frame): Remove outdated comment.
745 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
746 USE_LISP_UNION_TYPE.
747 (Fw32_unregister_hot_key): Likewise.
748 (Fw32_toggle_lock_key): Likewise.
749 * w32menu.c (add_menu_item): Likewise.
750 (w32_menu_display_help): Use XIL instead of checking
751 USE_LISP_UNION_TYPE.
752 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
753 (init_heap): Likewise.
754 * w32term.c (w32_read_socket): Update comment.
755
1d3823c9
GM
7562012-06-13 Glenn Morris <rgm@gnu.org>
757
c62ff706
GM
758 * s/usg5-4-common.h, src/s/unixware.h:
759 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
760
1d3823c9
GM
761 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
762
bfe3e0a2
PE
7632012-06-13 Paul Eggert <eggert@cs.ucla.edu>
764
765 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
766 * alloc.c (make_number) [!defined make_number]:
767 Remove, as lisp.h always defines this now.
768 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
769 (roundup_size): Verify that it is a power of 2.
770 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
771 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
772 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
773 -DUSE_LSB_TAG=0, to override the automatically-selected default.
774 USE_LSB_TAG now is always defined to be either 0 or 1.
775 All uses changed.
776 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
777 code works fine either way, and efficiency is not a concern here,
778 as the union type is for debugging, not for production.
779 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
780 Use an inline function on all platforms when using the union type,
781 since this is simpler and 'static inline' can be used portably
782 within Emacs now.
783 (LISP_INITIALLY_ZERO): New macro.
784 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
785 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
786
45fa9c0f
GM
7872012-06-12 Glenn Morris <rgm@gnu.org>
788
b4492cba
GM
789 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
790
791 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 792
45fa9c0f
GM
793 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
794 Move BROKEN_SIGIO to configure.
795
796 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
797 Move NO_TERMIO to configure.
798
0e25d334
CY
7992012-06-12 Chong Yidong <cyd@gnu.org>
800
801 * image.c (imagemagick_load_image): Use MagickFlattenImage if
802 MagickMergeImageLayers is undefined. Use pixel pusher loop if
803 MagickExportImagePixels is undefined.
804
43682bb6
PE
8052012-06-12 Paul Eggert <eggert@cs.ucla.edu>
806
807 * image.c (imagemagick_load_image): Remove unused label.
808
a9be7d2b
GM
8092012-06-11 Glenn Morris <rgm@gnu.org>
810
811 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
812 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
813 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
814 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
815
3017f87f
SM
8162012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
817
818 * alloc.c (make_byte_code): New function.
819 (Fmake_byte_code): Use it. Don't purify here.
820 * lread.c (read1): Use it as well to avoid extra allocation.
821
1b9b4cf4
CY
8222012-06-11 Chong Yidong <cyd@gnu.org>
823
824 * image.c (imagemagick_load_image): Implement transparency.
825
95988fcf
AS
8262012-06-10 Andreas Schwab <schwab@linux-m68k.org>
827
828 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
829 account for preceding backslashes. (Bug#11663)
830
cd4eb164
CY
8312012-06-09 Chong Yidong <cyd@gnu.org>
832
833 * term.c: Support italics in capable terminals (Bug#9652).
834 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
835 (turn_on_face): Output using TS_enter_italic_mode if available.
836 Don't handle unused blinking and alt-charset cases.
837 (turn_off_face): Handle italic case; discard unused tty_blinking_p
838 and tty_alt_charset_p cases.
839 (tty_capable_p, init_tty): Support italics.
840
841 * termchar.h (struct tty_display_info): Add field for italics.
842 Remove unused blink field.
843
844 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
845 Handle slant.
846
847 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
848 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
849 tty_alt_charset_p. Add tty_italic_p.
850
ff88beb8
MA
8512012-06-09 Michael Albinus <michael.albinus@gmx.de>
852
853 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
854 dbus_type_is_basic if available.
855 (xd_extract_signed, xd_extract_unsigned): Rename from
856 extract_signed and extract_unsigned, respectively. Adapt callers.
857
44286096
CY
8582012-06-09 Chong Yidong <cyd@gnu.org>
859
1682701f
CY
860 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
861
44286096
CY
862 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
863 case (Bug#9752).
864
d86feb17
PE
8652012-06-08 Paul Eggert <eggert@cs.ucla.edu>
866
867 * xdisp.c (vmessage): Treat frame message as multibyte.
868 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
869 would generate the diagnostic "Making \302\247 buffer-local while
870 let-bound!".
871
d5c20fe8
EZ
8722012-06-08 Eli Zaretskii <eliz@gnu.org>
873
874 * dispnew.c (showing_window_margins_p): Undo last change, which
875 was done due to an inadvertent commit.
876 (adjust_frame_glyphs_for_frame_redisplay): Do call
877 showing_window_margins_p.
878
513749ee
SM
8792012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
880
881 * eval.c (Fmake_var_non_special): New primitive.
882 (syms_of_eval): Defsubr it.
883 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
884
d4a8f5c1
JB
8852012-06-08 Juanma Barranquero <lekktu@gmail.com>
886
887 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
888 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
889
8bbbc977
EZ
8902012-06-08 Eli Zaretskii <eliz@gnu.org>
891
892 * alloc.c (allocate_vectorlike): Fix last change.
893
f3372c87
DA
8942012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
895
896 Block-based vector allocation of small vectors.
897 * lisp.h (struct vectorlike_header): New field `nbytes',
898 adjust comment accordingly.
899 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
900 to denote vector blocks. Adjust users (live_vector_p,
901 mark_maybe_pointer, valid_lisp_object_p) accordingly.
902 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
903 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
904 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
905 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
906 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
907 (roundup_size): New constant.
908 (struct vector_block): New data type.
909 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 910 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
911 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
912 (sweep_vectors): New functions.
913 (allocate_vectorlike): Return `zero_vector' as the only vector of
914 0 items. Allocate new vector from block if vector size is less than
915 or equal to VBLOCK_BYTES_MAX.
916 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
917 (init_alloc_once): Add call to init_vectors.
918
4f18a4ed
SM
9192012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
920
921 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
922
86f158bc
PE
9232012-06-07 Paul Eggert <eggert@cs.ucla.edu>
924
925 * doprnt.c (doprnt): Truncate multibyte char correctly.
926 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
927 would mishandle a string argument "Xc" if X was a multibyte
928 character of length 2: it would truncate after X's first byte
929 rather than including all of X.
930
c5cfcbe0
CY
9312012-06-06 Chong Yidong <cyd@gnu.org>
932
933 * buffer.c (word_wrap): Doc fix.
934
c05cf390
PE
9352012-06-04 Paul Eggert <eggert@cs.ucla.edu>
936
937 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
938
0c3461de
GM
9392012-06-03 Glenn Morris <rgm@gnu.org>
940
941 * xdisp.c (tool-bar-style): Doc fix.
942
c71232db
UM
9432012-06-03 Ulrich Müller <ulm@gentoo.org>
944
945 * Makefile.in (PAXCTL): Define.
946 (temacs$(EXEEXT)): Disable memory randomization for the temacs
947 binary via PaX flags if the paxctl utility is available.
948 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
949 Restore PaX flags to their default. (Bug#11398)
950
383f7350
CY
9512012-06-03 Chong Yidong <cyd@gnu.org>
952
953 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
954 buffer (Bug#11226).
955
5f2c76c6
CY
9562012-06-03 Chong Yidong <cyd@gnu.org>
957
958 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
959 (note_mode_line_or_margin_highlight): If there is no help echo,
960 use mode-line-default-help-echo. Handle the case where the mouse
961 position is past the end of the mode line string.
962
963 * buffer.c (buffer_local_value_1): New function, split from
964 Fbuffer_local_value; can return Qunbound.
965 (Fbuffer_local_value): Use it.
966 (Vmode_line_format): Docstring tweaks.
967
773d47f6
PE
9682012-06-02 Paul Eggert <eggert@cs.ucla.edu>
969
970 * sysdep.c (system_process_attributes): Improve comment.
971
f2d6a3df
SM
9722012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
973
974 * keyboard.c: Export real-this-command to Elisp.
975 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
976 and DEFVAR it. Update all users.
977
63810350
PE
9782012-06-02 Paul Eggert <eggert@cs.ucla.edu>
979
7bd5c1f4
PE
980 * minibuf.c (Fassoc_string): Remove duplicate declaration.
981
63810350
PE
982 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
983 Convert pctcpu and pctmem to Lisp float properly.
984 Let the compiler fold better, as 100.0/0x8000 is exact.
985
a2821611
AS
9862012-06-02 Andreas Schwab <schwab@linux-m68k.org>
987
988 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
989 cons_block.
990
5fceba1d
PE
9912012-06-01 Paul Eggert <eggert@cs.ucla.edu>
992
993 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
994
c98ff5dd
DA
9952012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
996
997 For a 'struct window', replace some Lisp_Object fields to
998 bitfields where appropriate, remove unused fields.
999 * window.h (struct window): Remove unused 'last_mark_x' and
1000 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1001 change it's type from Lisp_Object to bitfield.
1002 Change type of 'force_start', 'optional_new_start',
1003 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1004 fields from Lisp_Object to bitfield. Adjust users accordingly.
1005
ca34e0be
PE
10062012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1007
1008 Pacify gcc -Wdouble-precision when using Xaw.
1009 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1010 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1011 Use 'float' consistently, rather than 'float' in most places
1012 and 'double' in a couple of places.
1013
efc00ab1 10142012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1015
1016 * xdisp.c (handle_stop): Detect whether we have overlay strings
1017 loaded by testing it->current.overlay_string_index to be
1018 non-negative, instead of checking whether n_overlay_strings is
1019 positive. (Bug#11587)
1020
efc00ab1 10212012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1022
1023 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1024
1025 * doc.c (Fsubstitute_command_keys): Doc fix.
1026
efc00ab1 10272012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1028
1029 * search.c (search_buffer): Remove calls to
1030 r_alloc_inhibit_buffer_relocation, as it is now called by
1031 maybe_unify_char, which was the cause of relocation of buffer text
1032 in bug#11519.
1033
efc00ab1 10342012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1035
1036 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1037 for the duration of call to load_charset, to avoid problems with
1038 callers of maybe_unify_char that access buffer text through C
1039 pointers.
1040
1041 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1042 decrement the inhibition flag, instead of just setting or
1043 resetting it.
1044
ba93a187
PE
10452012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1046
1047 Remove obsolete '#define static' cruft.
1048 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1049 This #undef was "temporary" in 2000; it is no longer needed
1050 now that '#define static' has gone away.
1051 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1052 (gray_bitmap_bits): Remove; no longer needed.
1053 All uses replaced with definiens.
1054 * xterm.c: Include "bitmaps/gray.xbm".
1055
9e4bf381
PE
10562012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1057
1058 Clean up __executable_start, monstartup when --enable-profiling.
1059 The following changes affect the code only when profiling.
1060 * dispnew.c (__executable_start): Rename from safe_bcopy.
1061 Define only on platforms that need it.
1062 * emacs.c: Include <sys/gmon.h> when profiling.
1063 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1064 (__executable_start): Remove decl, since lisp.h does it now.
1065 (safe_bcopy): Remove decl; no longer has that name.
1066 (main): Coalesce #if into single bit of code, for simplicity.
1067 Cast pointers to uintptr_t, since standard libraries want integers
1068 and not pointers.
1069 * lisp.h (__executable_start): New decl.
1070
32d72c2f
GM
10712012-05-31 Glenn Morris <rgm@gnu.org>
1072
1073 * image.c (Fimagemagick_types): Doc fix.
1074
baac5bc7
JM
10752012-05-30 Jim Meyering <meyering@redhat.com>
1076
1077 * callproc.c (Fcall_process_region): Include directory component
1078 in mkstemp error message (Bug#11586).
1079
72cb32cf
PE
10802012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1081
1082 * alloc.c, lisp.h (make_pure_vector): Now static.
1083
61b108cc
SM
10842012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1085
1086 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1087 Move to byte-run.el.
1088 (Fautoload): Do the hash-doc more carefully.
1089 * data.c (Fdefalias): Purify definition, except for keymaps.
1090 (Qdefun): Move from eval.c.
1091 * lisp.h (Qdefun): Remove.
1092 * lread.c (read1): Tiny simplification.
1093
471fe23d
TN
10942012-05-29 Troels Nielsen <bn.troels@gmail.com>
1095
934f3f58 1096 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1097 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1098 Bug#9642, but explicitly check that the buffer the overlay would
1099 be moved to is live and rearrange lines to make sure that errors
1100 will not put the overlay in an inconsistent state.
1101 (Fdelete_overlay): Cosmetics.
1102
85d0efd1
EZ
11032012-05-28 Eli Zaretskii <eliz@gnu.org>
1104
1105 * w32term.c (my_bring_window_to_top): New function.
1106 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1107 could be different from the original one.
1108 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1109 (Bug#11513)
1110
1111 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1112 by calling BringWindowToTop.
1113
1114 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1115 (WM_EMACS_END): Increase by one.
1116
da92a98c
PE
11172012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1118
1119 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1120 This avoids undefined behavior that might cause the eassert
1121 to not catch an out-of-range value.
1122
74d1f848
JB
11232012-05-28 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1126 Update dependencies.
1127
9e1a06fc
EZ
11282012-05-27 Eli Zaretskii <eliz@gnu.org>
1129
1130 * bidi.c (bidi_mirror_char): Fix last change.
1131
f3dd7312
AS
11322012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1133
1134 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1135 when referring to sectname field in printf format.
1136
81899c91
PE
11372012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1138
57b81a9f
PE
1139 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1140 Only r_alloc_inhibit_buffer_relocation needed to be added;
1141 the others were already declared.
1142
81899c91
PE
1143 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1144 before checking whether it's out of range. Put the check inside
1145 eassert. See
1146 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1147
33017faf 11482012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1149
1150 * callproc.c (Fcall_process): Restore a line that was accidentally
1151 commented out in the 2011-02-13 change (bug#11547).
1152
33017faf 11532012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1154
1155 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1156 defined on ralloc.c.
1157
1158 * buffer.c [REL_ALLOC]: Remove prototypes of
1159 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1160 they are now on lisp.h.
1161
1162 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1163
1164 * search.c (search_buffer): Use it to inhibit relocation of buffer
1165 text while re_search_2 is doing its job, because re_search_2 is
1166 passed C pointers to buffer text. (Bug#11519)
1167
23415acf
EZ
1168 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1169 Update value to 24.
1170
44e27368
EZ
1171 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1172 state after an additional call to move_it_in_display_line_to, keep
1173 the values of it->max_ascent and it->max_descent found for the
1174 entire line.
1175 (pos_visible_p): Revert the comparison against bottom_y to what it
1176 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1177 (Bug#11464)
1178
c1892f11
PE
11792012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1180
1181 Fix coding-related core dumps with gcc -ftrapv.
1182 The code was computing A - B, where A and B are pointers, and B is
1183 random garbage. This can lead to core dumps on platforms that
1184 have special pointer registers, and it also leads to core dumps on
1185 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1186 A - B only when B is initialized properly.
1187 * coding.c (coding_set_source, coding_set_destination): Return void.
1188 (coding_change_source, coding_change_destinations): New functions,
1189 with the old behaviors of coding_set_source and coding_set_destination.
1190 All callers that need an offset changed to use these new functions.
1191
eb7afdad
GM
11922012-05-26 Glenn Morris <rgm@gnu.org>
1193
1194 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1195
f12fdf02
EZ
11962012-05-26 Eli Zaretskii <eliz@gnu.org>
1197
53a63be6 1198 Extend mouse support on W32 text-mode console.
61b108cc
SM
1199 * xdisp.c (draw_row_with_mouse_face):
1200 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1201
eb3f6f01 1202 * w32console.c: Include window.h.
61b108cc
SM
1203 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1204 New functions.
eb3f6f01
EZ
1205 (initialize_w32_display): Initialize mouse-highlight data.
1206
53a63be6
EZ
1207 * w32inevt.c: Include termchar.h and window.h.
1208 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1209 moves, call note_mouse_highlight. If help_echo changed, call
1210 gen_help_event to produce help-echo message in the echo area.
1211 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1212 highlight info.
1213
4cfd81f6
PE
12142012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1215
1216 * lread.c (read1): Simplify slightly to avoid an overflow warning
1217 with GCC 4.7.0 on x86-64.
1218
4446092a
EZ
12192012-05-26 Eli Zaretskii <eliz@gnu.org>
1220
1221 * bidi.c (bidi_mirror_char): Revert last change: an int is
1222 definitely wide enough here.
1223
42b2a986 12242012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1225
42b2a986 1226 Fix integer width and related bugs (Bug#9874).
eb106a49 1227 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1228 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1229 (string_bytes, check_sblock, allocate_string_data):
1230 (compact_small_strings, Fmake_bool_vector, make_string)
1231 (make_unibyte_string, make_multibyte_string)
1232 (make_string_from_bytes, make_specified_string)
1233 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1234 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1235 (mark_vectorlike):
1236 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1237 (allocate_pseudovector):
1238 Use int, not EMACS_INT, where int is wide enough.
1239 (inhibit_garbage_collection, Fgarbage_collect):
1240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1241 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1242 int might not be wide enough.
1243 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1244 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1245 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1246 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1247 (bidi_level_of_next_char, bidi_move_to_visually_next):
1248 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1249 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1250 (Fkill_buffer, Fset_buffer_major_mode)
1251 (advance_to_char_boundary, Fbuffer_swap_text)
1252 (Fset_buffer_multibyte, overlays_at, overlays_in)
1253 (overlay_touches_p, struct sortvec, record_overlay_string)
1254 (overlay_strings, recenter_overlay_lists)
1255 (adjust_overlays_for_insert, adjust_overlays_for_delete)
1256 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
1257 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
1258 (Foverlay_recenter, last_overlay_modification_hooks_used)
1259 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
1260 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
1261 (validate_region): Omit unnecessary test for b <= e,
1262 since that's guaranteed by the previous test.
d311d28c
PE
1263 (adjust_overlays_for_delete): Avoid pos + length overflow.
1264 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
1265 (report_overlay_modification):
1266 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1267 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
1268 Omit pointer cast, which isn't needed anyway, and doesn't work
1269 after the EMACS_INT -> ptrdiff_t change.
02481186 1270 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
1271 * buffer.h: Adjust decls to match defn changes elsewhere.
1272 (struct buffer_text, struct buffer):
1273 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1274 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
1275 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
1276 not int, to avoid needless 32-bit limit on 64-bit hosts.
1277 (exec_byte_code): Use tighter memory-full test, one that checks
1278 for alloca overflow. Don't compute the address of the object just
1279 before an array, as that's not portable. Use EMACS_INT, not
1280 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
1281 * callint.c (Fcall_interactively):
1282 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1283 * callproc.c (call_process_kill, Fcall_process):
1284 Don't assume pid_t fits into an Emacs fixnum.
1285 (call_process_cleanup, Fcall_process, child_setup):
1286 Don't assume pid_t fits into int.
1287 (call_process_cleanup, Fcall_process, delete_temp_file)
1288 (Fcall_process_region):
1289 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1290 (Fcall_process): Simplify handling of volatile integers.
1291 Use int, not EMACS_INT, where int will do.
1292 * casefiddle.c (casify_object, casify_region, operate_on_word)
1293 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
1294 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1295 (casify_object): Avoid integer overflow when overallocating buffer.
1296 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 1297 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
1298 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
1299 * category.h (CATEGORYP): Don't assume arg is nonnegative.
1300 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
1301 integers are now checked earlier. All uses replaced with XINT.
1302 (ccl_driver):
1303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1304 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
1305 (ccl_driver, Fregister_code_conversion_map):
1306 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
1307 (resolve_symbol_ccl_program): Check that vector header is in range.
1308 Always copy the vector, so that we can check its contents reliably
1309 now rather than having to recheck each instruction as it's being
1310 executed. Check that vector words fit in 'int'.
1311 (ccl_get_compiled_code, Fregister_ccl_program)
1312 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
1313 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
1314 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
1315 contents are in range.
1316 (Fccl_execute_on_string): Check that status is in range.
1317 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
1318 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
1319 Accept and return EMACS_INT, not int, because callers can pass values
1320 out of 'int' range.
1321 (c_string_width, strwidth, lisp_string_width, chars_in_text)
1322 (multibyte_chars_in_text, parse_str_as_multibyte)
1323 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
1324 (str_as_unibyte, str_to_unibyte, string_count_byte8)
1325 (string_escape_byte8, Fget_byte):
1326 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 1327 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
1328 avoid mishandling large integers.
1329 * character.h: Adjust decls to match defn changes elsewhere.
1330 * charset.c (load_charset_map_from_file, find_charsets_in_text)
1331 (Ffind_charset_region):
1332 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1333 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
1334 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 1335 Don't assume fixnum fits in int.
d311d28c
PE
1336 (load_charset_map_from_vector, Fmap_charset_chars):
1337 Remove now-unnecessary CHECK_NATNUMs.
1338 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
1339 Don't rely on undefined behavior with signed left shift overflow.
1340 Don't assume unsigned int fits into fixnum, or that fixnum fits
1341 into unsigned int. Don't require max_code to be a valid fixnum;
1342 that's not true for gb10830 4-byte on a 32-bit host. Allow
1343 invalid_code to be a cons, for the same reason. Require code_offset
1344 to be a character. Avoid int overflow if max_char is close
1345 to INT_MAX.
1346 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
1347 this is intended anyway and avoids some undefined behavior.
1348 (load_charset_map): Pass unsigned, not int, as 2nd arg of
1349 INDEX_TO_CODE_POINT, as that's what it expects.
1350 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
1351 * charset.h (DECODE_CHAR): Return int, not unsigned;
1352 this is what was intended anyway, and it avoids undefined behavior.
1353 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
1354 integer-overflow issues.
1355 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
1356 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
1357 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
1358 * chartab.c (Fmake_char_table, Fset_char_table_range)
1359 (uniprop_get_decoder, uniprop_get_encoder):
1360 Don't assume fixnum fits in int.
1361 * cmds.c (move_point): New function, that does the gist of
1362 Fforward_char and Fbackward_char, but does so while checking
1363 for integer overflow more accurately.
c96e5d6a 1364 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
1365 (Fforward_line, Fend_of_line, internal_self_insert)
1366 (internal_self_insert):
1367 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1368 Fix a FIXME, by checking for integer overflow when calculating
1369 target_clm and actual_clm.
1370 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 1371 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
1372 (ASSURE_DESTINATION, coding_alloc_by_realloc)
1373 (coding_alloc_by_making_gap, alloc_destination)
1374 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
1375 (encode_coding_utf_16, detect_coding_emacs_mule)
1376 (decode_coding_emacs_mule, encode_coding_emacs_mule)
1377 (detect_coding_iso_2022, decode_coding_iso_2022)
1378 (encode_invocation_designation, encode_designation_at_bol)
1379 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1380 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
1381 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
1382 (encode_coding_ccl, encode_coding_raw_text)
1383 (detect_coding_charset, decode_coding_charset)
1384 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
1385 (produce_composition, produce_charset, produce_annotation)
1386 (decode_coding, handle_composition_annotation)
1387 (handle_charset_annotation, consume_chars, decode_coding_gap)
1388 (decode_coding_object, encode_coding_object, detect_coding_system)
1389 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
1390 (code_convert_region, code_convert_string)
8f50130c
PE
1391 (Fdefine_coding_system_internal)
1392 (coding_set_source, coding_set_destination):
d311d28c
PE
1393 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1394 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
1395 (Fdefine_coding_system_internal):
1396 Don't assume fixnums fit in int.
1397 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 1398 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
1399 (Funencodable_char_position, Fcheck_coding_systems_region)
1400 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 1401 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 1402 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 1403 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 1404 Don't access memory outside of the args array.
d311d28c 1405 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
1406 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
1407 result of ENCODE_CHAR.
d311d28c
PE
1408 * coding.h: Adjust decls to match defn changes elsewhere.
1409 (struct coding_system):
1410 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1411 * composite.c (get_composition_id, find_composition)
1412 (run_composition_function, update_compositions)
1413 (compose_text, composition_gstring_put_cache)
1414 (composition_gstring_p, composition_gstring_width)
1415 (fill_gstring_header, fill_gstring_body, autocmp_chars)
1416 (composition_compute_stop_pos, composition_reseat_it)
1417 (composition_update_it, struct position_record)
1418 (find_automatic_composition, composition_adjust_point)
1419 (Fcomposition_get_gstring, Ffind_composition_internal):
1420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1421 (update_compositions):
1422 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1423 * composite.h: Adjust decls to match defn changes elsewhere.
1424 (struct composition):
1425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1426 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
1427 Do not attempt to compute the address of the object just before a
1428 buffer; this is not portable.
1429 (Faref, Faset):
1430 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1431 (Faset): Use int, not EMACS_INT, where int is wide enough.
1432 (Fstring_to_number): Don't assume fixnums fit in int.
1433 (Frem): Don't assume arg is nonnegative.
1434 * dbusbind.c (xd_append_arg): Check for integers out of range.
1435 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 1436 (extract_signed, extract_unsigned): New functions.
243e0530
PE
1437 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
1438 (xd_get_connection_references): Return ptrdiff_t, not int.
1439 All uses changed.
1440 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
1441 (xd_read_message_1):
1442 Use int, not unsigned, where the dbus API uses int.
1443 (Fdbus_message_internal): Don't overflow mtype.
1444 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
1445 * dired.c (directory_files_internal, file_name_completion, scmp)
1446 (file_name_completion_stat):
1447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1448 (file_name_completion): Don't overflow matchcount.
1449 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
1450 * dispextern.h: Adjust decls to match defn changes elsewhere.
1451 (struct text_pos, struct glyph, struct bidi_saved_info)
1452 (struct bidi_string_data, struct bidi_it, struct composition_it)
1453 (struct it):
1454 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1455 (struct display_pos, struct composition_it, struct it):
1456 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1457 * dispnew.c (increment_matrix_positions)
1458 (increment_row_positions, mode_line_string)
1459 (marginal_area_string):
1460 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 1461 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
1462 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1463 (duration_to_sec_usec): New function, to check for overflow better.
1464 (Fsleep_for, sit_for): Use it.
1465 * doc.c (get_doc_string, store_function_docstring):
1466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1467 (get_doc_string, Fsnarf_documentation):
1468 Use int, not EMACS_INT, where int is wide enough.
1469 (get_doc_string):
1470 Use SAFE_ALLOCA, not alloca.
1471 Check for overflow when converting EMACS_INT to off_t.
1472 * doprnt.c (doprnt):
1473 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1474 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
1475 Don't assume uid_t fits into fixnum.
1476 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
1477 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
1478 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
1479 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
1480 (general_insert_function)
1481 (Finsert_char, make_buffer_string, make_buffer_string_both)
1482 (update_buffer_properties, Fbuffer_substring)
1483 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
1484 (Fsubst_char_in_region, check_translation)
1485 (Ftranslate_region_internal, save_restriction_restore, Fformat)
1486 (transpose_markers, Ftranspose_regions):
1487 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1488 (clip_to_bounds): Move to lisp.h as an inline function).
1489 (Fconstrain_to_field): Don't assume integers are nonnegative.
1490 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
1491 (Fsubst_char_in_region, Fsave_restriction):
1492 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1493 (Femacs_pid): Don't assume pid_t fits into fixnum.
1494 (lo_time): Use int, not EMACS_INT, when int suffices.
1495 (lisp_time_argument): Check for usec out of range.
1496 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
1497 (Fuser_login_name, Fuser_full_name): Signal an error
1498 if a uid argument is out of range, rather than relying on
1499 undefined behavior.
c8d5c857
PE
1500 (Fformat_time_string): Remove now-unnecessary check.
1501 lisp_time_argument checks for out-of-range usec now.
243e0530 1502 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
1503 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
1504 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
1505 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
1506 (init_cmdargs, Fdump_emacs):
1507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1508 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
1509 the bottom (typically) 32 bits of the fixnum.
1510 * eval.c (specpdl_size, call_debugger):
1511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1512 (when_entered_debugger, Fbacktrace_debug):
1513 Don't assume fixnum can fit in int.
1514 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
1515 the object just before a buffer; this is not portable.
1516 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
1517 (grow_specpdl, unbind_to):
1518 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1519 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
1520 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 1521 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
1522 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
1523 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
1524 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1525 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
1526 (a_write, e_write):
1527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1528 (Fcopy_file, non_regular_nbytes, read_non_regular)
1529 (Finsert_file_contents):
1530 Use int, not EMACS_INT, where int is wide enough.
1531 (READ_BUF_SIZE): Verify that it fits in int.
1532 (Finsert_file_contents): Check that counts are in proper range,
1533 rather than assuming fixnums fit into ptrdiff_t etc.
1534 Don't assume fixnums fit into int.
125b3835 1535 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
1536 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
1537 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
1538 (string_char_to_byte, string_byte_to_char)
1539 (string_make_multibyte, string_to_multibyte)
1540 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
1541 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
1542 (substring_both, Fdelete, internal_equal, Ffillarray)
1543 (Fclear_string, mapcar1)
1544 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
1545 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
1546 (larger_vector, make_hash_table, maybe_resize_hash_table)
1547 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
1548 (Fmaphash, secure_hash):
1549 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1550 (concat): Check for string index and length overflow.
1551 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
1552 (Frequire):
1553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1554 (larger_vector): New API (vec, incr_min, size_max) replaces old
1555 one (vec, new_size, init). This catches size overflow.
1556 INIT was removed because it was always Qnil.
1557 All callers changed.
1558 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
1559 the upper bound on a hash table index size.
1560 (make_hash_table, maybe_resize_hash_table): Use it.
1561 (secure_hash): Computer start_byte and end_byte only after
1562 they're known to be in ptrdiff_t range.
1563 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
1564 (Ffont_get_glyphs, Ffont_at):
1565 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1566 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
1567 (Flist_fonts, Fopen_font):
1568 Don't assume fixnum can fit in int.
1569 (check_gstring): Don't assume index can fit in int.
1570 (font_match_p): Check that fixnum is a character, not a nonnegative
1571 fixnum, since the later code needs to stuff it into an int.
1572 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
1573 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
1574 conversion overflow issues.
1575 (Fopen_font): Check for integer out of range.
1576 (Ffont_get_glyphs): Don't assume index can fit in int.
1577 * font.h: Adjust decls to match defn changes elsewhere.
1578 * fontset.c (reorder_font_vector): Redo score calculation to avoid
1579 integer overflow.
1580 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
1581 printmax_t, where ptrdiff_t is wide enough.
1582 (Finternal_char_font):
1583 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1584 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
1585 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
1586 (Fset_frame_position, x_set_frame_parameters)
1587 (x_set_line_spacing, x_set_border_width)
1588 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
1589 Check that fixnums are in proper range for system types.
1590 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
1591 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1592 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
1593 Use SAFE_ALLOCA_LISP, not alloca.
1594 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
1595 intptr_t is wide enough.
1596 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
1597 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
1598 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
1599 Check for fixnum out of range.
1600 * ftfont.c (ftfont_list): Don't assume index fits in int.
1601 Check that fixnums are in proper range for system types.
1602 (ftfont_shape_by_flt):
1603 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
1604 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1606 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
1607 Check that fixnums are in proper range for system types.
1608 * gnutls.h: Adjust decls to match defn changes elsewhere.
1609 * gtkutil.c (xg_dialog_run):
1610 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1611 (update_frame_tool_bar):
1612 Check that fixnums are in proper range for system types.
1613 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 1614 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1615 * indent.c (last_known_column, last_known_column_point):
1616 (current_column_bol_cache):
1617 (skip_invisible, current_column, check_display_width):
1618 (check_display_width, scan_for_column, current_column_1)
1619 (Findent_to, Fcurrent_indentation, position_indentation)
1620 (indented_beyond_p, Fmove_to_column, compute_motion):
1621 (Fcompute_motion, Fvertical_motion):
1622 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1623 (last_known_column_modified): Use EMACS_INT, not int.
1624 (check_display_width):
1625 (Fcompute_motion):
1626 Check that fixnums and floats are in proper range for system types.
1627 (compute_motion): Don't assume index or fixnum fits in int.
1628 (compute_motion, Fcompute_motion):
1629 Use int, not EMACS_INT, when it is wide enough.
1630 (vmotion): Omit local var start_hpos that is always 0; that way
1631 we don't need to worry about overflow in expressions involving it.
1632 * indent.h: Adjust decls to match defn changes elsewhere.
1633 (struct position):
1634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1635 Use int, not EMACS_INT, where int is wide enough.
1636 Remove unused members ovstring_chars_done and tab_offset;
1637 all uses removed.
1638 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1639 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1640 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1641 (make_gap, copy_text, insert, insert_and_inherit)
1642 (insert_before_markers, insert_before_markers_and_inherit)
1643 (insert_1, count_combining_before, count_combining_after)
1644 (insert_1_both, insert_from_string)
1645 (insert_from_string_before_markers, insert_from_string_1)
1646 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1647 (adjust_after_replace, adjust_after_insert, replace_range)
1648 (replace_range_2, del_range, del_range_1, del_range_byte)
1649 (del_range_both, del_range_2, modify_region)
1650 (prepare_to_modify_buffer, signal_before_change)
1651 (signal_after_change, Fcombine_after_change_execute):
1652 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1653 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1654 (balance_an_interval, split_interval_right, split_interval_left)
1655 (find_interval, next_interval, update_interval)
1656 (adjust_intervals_for_insertion, delete_node, delete_interval)
1657 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1658 (static_offset_intervals, offset_intervals)
1659 (merge_interval_right, merge_interval_left, make_new_interval)
1660 (graft_intervals_into_buffer, temp_set_point_both)
1661 (temp_set_point, set_point, adjust_for_invis_intang)
1662 (set_point_both, move_if_not_intangible, get_property_and_range)
1663 (get_local_map, copy_intervals, copy_intervals_to_string)
1664 (compare_string_intervals, set_intervals_multibyte_1):
1665 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1666 * intervals.h: Adjust decls to match defn changes elsewhere.
1667 (struct interval):
1668 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1669 * keyboard.c (this_command_key_count, this_single_command_key_start)
1670 (before_command_key_count, before_command_echo_length, echo_now)
1671 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1672 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1673 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1674 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1676 (last_non_minibuf_size, last_point_position, echo_truncate)
1677 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1678 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1679 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1680 (stuff_buffered_input):
1681 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1682 (last_auto_save, command_loop_1, read_char):
1683 Use EMACS_INT, not int, to avoid integer overflow.
1684 (record_char): Avoid overflow in total_keys computation.
1685 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1686 * keyboard.h: Adjust decls to match defn changes elsewhere.
1687 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1688 (Fkey_description, Fdescribe_vector, Flookup_key):
1689 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1690 (click_position): New function, to check that positions are in range.
1691 (Fcurrent_active_maps):
1692 (describe_command):
1693 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1694 (Faccessible_keymaps, Fkey_description):
1695 (preferred_sequence_p):
1696 Don't assume fixnum can fit into int.
1697 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1698 Check for integer overflow in size calculations.
1699 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1700 avoid mishandling large integers.
1701 * lisp.h: Adjust decls to match defn changes elsewhere.
1702 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1703 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1704 (struct Lisp_Marker):
1705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1706 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1707 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1708 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1709 All callers changed.
1710 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1711 Assume the arg has valid form, since it always does.
1712 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1713 unsigned integer system type.
1714 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1715 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1716 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1717 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1718 (duration_to_sec_usec): New decl.
1719 * lread.c (read_from_string_index, read_from_string_index_byte)
1720 (read_from_string_limit, readchar, unreadchar, openp)
1721 (read_internal_start, read1, oblookup):
1722 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1723 (Fload, readevalloop, Feval_buffer, Feval_region):
1724 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1725 (openp): Check for out-of-range argument to 'access'.
1726 (read1): Use int, not EMACS_INT, where int is wide enough.
1727 Don't assume fixnum fits into int.
6efdadfd 1728 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1729 (read_filtered_event): Use duration_to_sec_usec
1730 to do proper overflow checking on durations.
d311d28c
PE
1731 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1732 in size calculation.
1733 (Fexecute_kbd_macro):
1734 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1735 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1736 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1737 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1738 (set_marker_both, set_marker_restricted_both, marker_position)
1739 (marker_byte_position, Fbuffer_has_markers_at):
1740 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1741 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1742 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1743 It now merely ensures that the menu is large enough, without
1744 necessarily growing it, as this avoids some integer overflow issues.
1745 All callers changed.
1746 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1748 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1749 Use SAFE_ALLOCA_LISP, not alloca.
1750 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1751 to EMACS_INT. Check that fixnums are in proper range for system types.
1752 * minibuf.c (minibuf_prompt_width, string_to_object)
1753 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1754 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1755 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1756 (get_minibuffer, read_minibuf_unwind):
1757 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1758 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1759 this simplifies overflow checking. All callers changed.
1760 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1761 (Ftest_completion):
1762 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1763 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1764 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1765 Check that fixnums are in proper range for system types.
1766 (Fx_create_frame, Fx_show_tip):
1767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1768 * nsfont.m (ns_findfonts, nsfont_list_family):
1769 Don't assume fixnum fits in long.
1770 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1771 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1772 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1773 wide enough.
17fdb222 1774 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1776 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1777 (PRINTDECLARE, PRINTPREPARE):
1778 (strout, print_string):
1779 (print, print_preprocess, print_check_string_charset_prop)
1780 (print_object):
1781 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1782 (PRINTDECLARE):
1783 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1784 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1785 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1786 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1787 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1788 (print_error_message): Use SAFE_ALLOCA, not alloca.
1789 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1790 (print_depth, new_backquote_output, print_number_index):
1791 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1792 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1793 (Fset_process_window_size, Fformat_network_address)
1794 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1795 (sigchld_handler):
d311d28c 1796 Check that fixnums are in proper range for system types.
d44287d4 1797 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1798 Check for process-ids out of pid_t range rather than relying on
1799 undefined behavior.
e4d81efc 1800 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1801 (Fformat_network_address, read_process_output, send_process)
1802 (Fprocess_send_region, status_notify):
1803 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1804 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1805 (wait_reading_process_output, read_process_output, exec_sentinel):
1806 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1807 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1808 (Faccept_process_output): Use duration_to_sec_usec to do proper
1809 overflow checking on durations.
dde14581
PE
1810 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1811 Don't assume pid_t fits in int.
02481186
PE
1812 * process.h (struct Lisp_Process): Members tick and update_tick
1813 are now of type EMACS_INT, not int.
b62b53e8
PE
1814 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1815 configured --with-wide-int.
d311d28c
PE
1816 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1817 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1818 * search.c (looking_at_1, string_match_1):
1819 (fast_string_match, fast_c_string_match_ignore_case)
1820 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1821 (scan_newline, find_before_next_newline, search_command)
1822 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1823 (set_search_regs, wordify):
1824 (Freplace_match):
1825 (Fmatch_data):
1826 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1827 (string_match_1, search_buffer, set_search_regs):
1828 (Fmatch_data):
1829 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1830 (wordify): Check for overflow in size calculation.
1831 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1832 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1833 Check that fixnums are in proper range for system types.
1834 * sound.c (struct sound_device)
1835 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1836 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1837 (Fplay_sound_internal):
1838 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1839 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1840 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1841 (Fparse_partial_sexp):
1842 Don't assume fixnums can fit in int.
1843 (struct lisp_parse_state, find_start_pos, find_start_value)
1844 (find_start_value_byte, find_start_begv)
1845 (update_syntax_table, char_quoted, dec_bytepos)
1846 (find_defun_start, prev_char_comend_first, back_comment):
1847 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1848 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1849 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1850 (Finternal_describe_syntax_value): Check that match_lisp is a
1851 character, not an integer, since the code stuffs it into int.
1852 (scan_words, scan_sexps_forward):
1853 Check that fixnums are in proper range for system types.
1854 (Fforward_word):
1855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1856 (scan_sexps_forward):
1857 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1858 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1859 * syntax.h: Adjust decls to match defn changes elsewhere.
1860 (struct gl_state_s):
1861 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1862 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1863 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1864 * sysdep.c (wait_for_termination_1, wait_for_termination)
1865 (interruptible_wait_for_termination, mkdir):
1866 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1867 (emacs_read, emacs_write):
1868 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1869 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1870 and double all fit in int.
d311d28c
PE
1871 * term.c (set_tty_color_mode):
1872 Check that fixnums are in proper range for system types.
1873 * termhooks.h (struct input_event):
1874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1875 * textprop.c (validate_interval_range, interval_of)
1876 (Fadd_text_properties, set_text_properties_1)
1877 (Fremove_text_properties, Fremove_list_of_text_properties)
1878 (Ftext_property_any, Ftext_property_not_all)
1879 (copy_text_properties, text_property_list, extend_property_ranges)
1880 (verify_interval_modification):
1881 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1882 (Fnext_single_char_property_change)
1883 (Fprevious_single_char_property_change):
1884 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1885 (copy_text_properties):
1886 Check for integer overflow in index calculation.
d311d28c
PE
1887 * undo.c (last_boundary_position, record_point, record_insert)
1888 (record_delete, record_marker_adjustment, record_change)
1889 (record_property_change):
1890 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1891 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1893 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1894 (Fx_hide_tip, Fx_file_dialog):
1895 * w32menu.c (set_frame_menubar):
1896 Use ptrdiff_t, not int, for consistency with rest of code.
1897 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1898 (select_window, Fdelete_other_windows_internal)
1899 (window_scroll_pixel_based, window_scroll_line_based)
1900 (Frecenter, Fset_window_configuration):
1901 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1902 (Fset_window_hscroll, run_window_configuration_change_hook)
1903 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1904 (Fscroll_other_window, Frecenter):
d311d28c
PE
1905 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1906 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1907 Don't assume fixnum fits in int.
1908 (Fset_window_scroll_bars):
1909 Check that fixnums are in proper range for system types.
1910 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1911 (string_pos, c_string_pos, number_of_chars, init_iterator)
1912 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1913 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1914 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1915 (face_before_or_after_it_pos, handle_invisible_prop)
1916 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1917 (display_prop_intangible_p, string_buffer_position_lim)
1918 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1919 (get_overlay_strings_1, get_overlay_strings)
1920 (iterate_out_of_display_property, forward_to_next_line_start)
1921 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1922 (get_next_display_element, set_iterator_to_next)
1923 (get_visually_first_element, compute_stop_pos_backwards)
1924 (handle_stop_backwards, next_element_from_buffer)
1925 (move_it_in_display_line_to, move_it_in_display_line)
1926 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1927 (add_to_log, message_dolog, message_log_check_duplicate)
1928 (message2, message2_nolog, message3, message3_nolog
1929 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1930 (current_message_1, truncate_echo_area, truncate_message_1)
1931 (set_message, set_message_1, store_mode_line_noprop)
1932 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1933 (text_outside_line_unchanged_p, check_point_in_composition)
1934 (reconsider_clip_changes)
1935 (redisplay_internal, set_cursor_from_row, try_scrolling)
1936 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1937 (redisplay_window, find_last_unchanged_at_beg_row)
1938 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1939 (trailing_whitespace_p, find_row_edges, display_line)
1940 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1941 (display_mode_element, store_mode_line_string)
1942 (pint2str, pint2hrstr, decode_mode_spec)
1943 (display_count_lines, display_string, draw_glyphs)
1944 (x_produce_glyphs, x_insert_glyphs)
1945 (rows_from_pos_range, mouse_face_from_buffer_pos)
1946 (fast_find_string_pos, mouse_face_from_string_pos)
1947 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1948 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1949 (safe_call, init_from_display_pos, handle_fontified_prop)
1950 (handle_single_display_spec, load_overlay_strings)
1951 (with_echo_area_buffer, setup_echo_area_for_printing)
1952 (display_echo_area, echo_area_display)
1953 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1954 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1955 (redisplay_window, dump_glyph_row, display_mode_line)
1956 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1957 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1958 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1959 (handle_single_display_spec, build_desired_tool_bar_string)
1960 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1961 (get_specified_cursor_type):
1962 Check that fixnums are in proper range for system types.
1963 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1964 (Flookup_image_map):
1965 Don't assume fixnums fit in int.
1966 (compare_overlay_entries):
1967 Avoid mishandling comparisons due to subtraction overflow.
1968 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1969 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1970 (handle_tool_bar_click):
1971 Use int, not unsigned, since we prefer signed and the signedness
1972 doesn't matter here.
1973 (get_next_display_element, next_element_from_display_vector):
1974 Use int, not EMACS_INT, when int is wide enough.
1975 (start_hourglass): Use duration_to_sec_usec to do proper
1976 overflow checking on durations.
1977 * xfaces.c (Fbitmap_spec_p):
1978 Check that fixnums are in proper range for system types.
1979 (compare_fonts_by_sort_order):
1980 Avoid mishandling comparisons due to subtraction overflow.
1981 (Fx_family_fonts, realize_basic_faces):
1982 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1983 (Fx_family_fonts):
1984 Don't assume fixnum fits in int.
1985 Use SAFE_ALLOCA_LISP, not alloca.
1986 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1987 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1988 (face_at_buffer_position, face_for_overlay_string)
1989 (face_at_string_position):
1990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1991 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1992 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1993 (Fx_show_tip):
1994 Check that fixnums are in proper range for system types.
1995 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1996 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1997 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1998 (Fx_change_window_property): Don't assume fixnums fit in int.
1999 * xfont.c (xfont_chars_supported):
2000 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2001 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2002 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2003 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2004 * xml.c (parse_region):
2005 * xrdb.c (magic_file_p):
2006 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2007 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2008 (x_get_local_selection, x_reply_selection_request)
2009 (x_handle_selection_request, wait_for_property_change):
2010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2011 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2012 short is wide enough.
2013 (x_send_client_event): Don't assume fixnum fits in int.
2014 * xterm.c (x_x_to_emacs_modifiers):
2015 Don't assume EMACS_INT overflows nicely into int.
2016 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2017 may come from Lisp.
2018 (handle_one_xevent): NATNUMP can eval its arg twice.
2019 (x_connection_closed):
2020 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2021 * xterm.h: Adjust decls to match defn changes elsewhere.
2022 (struct scroll_bar): Use struct vectorlike_header
2023 rather than rolling our own approximation.
2024 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2025
c6574eb5
GM
20262012-05-25 Glenn Morris <rgm@gnu.org>
2027
2028 * lisp.mk (lisp): Update for more files being compiled now.
2029
e8d32c7e
SM
20302012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2031
48def666
SM
2032 * lread.c: Remove `read_pure' which makes no difference.
2033 (read_pure): Remove var.
2034 (unreadpure): Remove function.
2035 (readevalloop): Don't call read_list with -1 flag.
2036 (read1, read_vector): Don't test read_pure any more.
2037 (read_list): Simplify.
2038
e8d32c7e
SM
2039 * fileio.c, character.h: Minor style tweaks.
2040
4b2addb7
DA
20412012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2042
2043 * window.h (clip_changed): Remove useless declaration.
2044
584461b2
JB
20452012-05-22 Juanma Barranquero <lekktu@gmail.com>
2046
2047 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2048 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2049
34374650
PE
20502012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2051
2052 Remove src/m/*.
2053 This directory predates autoconf and is no longer needed nowadays.
2054 Move its few remaining bits of functionality to where they're needed.
2055 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2056 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2057 * m/template.h: Remove.
2058 * Makefile.in (M_FILE): Remove. All uses removed.
2059 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2060 * lisp.h (USE_LSB_TAG):
2061 * mem-limits.h (EXCEEDS_LISP_PTR):
2062 Use VAL_MAX, not VALBITS, in #if.
2063 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2064 (EMACS_UINT): Define unconditionally now.
2065 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2066 (BITS_PER_EMACS_INT): New constants, replacing
2067 what used to be in config.h, but not useful in #if.
2068 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2069 define them any more.
2070 (VAL_MAX): New macro.
2071 (VALMASK): Use it.
2072 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2073 BITS_PER_EMACS_INT, in #if.
2074 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2075 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2076 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2077 * s/ms-w32.h (DATA_START):
2078 Move here from removed file m/intel386.h.
2079 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2080 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2081
261cb4bb
PE
20822012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2083
2084 Assume C89 or later.
2085 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2086 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2087 (xrealloc):
2088 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2089 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2090 * textprop.c, tparam.c (NULL): Remove.
2091 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2092 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2093 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2094 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2095 * xterm.c (input_signal_count): Assume volatile works.
2096
ff23cd9f
KB
20972012-05-21 Ken Brown <kbrown@cornell.edu>
2098
2099 * xgselect.c (xg_select): Fix first argument in call to 'select'
2100 (bug#11508).
2101
1b170bc6
KB
21022012-05-20 Ken Brown <kbrown@cornell.edu>
2103
2104 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2105 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2106
b2f4d39f
KB
21072012-05-19 Ken Brown <kbrown@cornell.edu>
2108
2109 * xfns.c (x_in_use): Remove `static' qualifier.
2110 * xterm.h (x_in_use): Declare.
2111 * xgselect.c: Include xterm.h.
2112 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2113 and `display_arg' (bug#9754).
2114
003fdae2
PE
21152012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2116
9232a6d9
PE
2117 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2118
003fdae2
PE
2119 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2120 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2121
784b56e2
EZ
21222012-05-18 Eli Zaretskii <eliz@gnu.org>
2123
2124 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2125
2126 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
2127 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
2128
2129 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2130 reference to image_cache->refcount.
2131 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2132
a0a79cde
JL
21332012-05-17 Juri Linkov <juri@jurta.org>
2134
2135 * search.c (Fword_search_regexp, Fword_search_backward)
2136 (Fword_search_forward, Fword_search_backward_lax)
2137 (Fword_search_forward_lax): Move functions to isearch.el
2138 (bug#10145, bug#11381).
2139
b0572523
PE
21402012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2141
2142 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2143
9660f5fc
SM
21442012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2145
2146 * lread.c (init_obarray): Declare Qt and Qnil as special.
2147
4374de83
GM
21482012-05-14 Glenn Morris <rgm@gnu.org>
2149
2150 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2151 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2152
dc44c39a
PE
21532012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2154
078c97cb
PE
2155 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2156
dc44c39a
PE
2157 * unexaix.c: Port to more-recent AIX compilers.
2158 (report_error, report_error_1, make_hdr, copy_sym)
2159 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2160 Make arguments const char *, not char *, to avoid violations of C
2161 standard and to fix some AIX warnings reported by Gilles Pion.
2162
e18afed7 21632012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2164
2165 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2166 already have overlays loaded.
2167 (handle_single_display_spec): Before returning without displaying
2168 fringe bitmap, synchronize the bidi iterator with the main display
2169 iterator, by calling iterate_out_of_display_property.
2170 (iterate_out_of_display_property): Detect buffer iteration by
2171 testing that it->string is a Lisp string.
2172 (get_next_display_element): When the current object is exhausted,
2173 and there's something on it->stack, call set_iterator_to_next to
2174 proceed with what's on the stack, instead of returning zero.
2175 (set_iterator_to_next): If called at the end of a Lisp string,
2176 proceed to consider_string_end without incrementing string
2177 position. Don't increment display vector index past the end of
2178 the display vector. (Bug#11417)
c8fb9dc6
EZ
2179 (pos_visible_p): Don't report a position visible when move_it_to
2180 stopped at the last line of window, which happens to be scanned
2181 backwards by the bidi iteration. (Bug#11464)
ac268e67 2182
e18afed7 21832012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2184
2185 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2186 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2187 are on a TTY, and thus unable to display on the fringes.
2188 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2189 so we need to signal to the caller that this is a "replacing"
2190 display spec. This fixes display when the spec is invalid or we
2191 are on a TTY.
2192
e18afed7 21932012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2194
2195 * unexaix.c (make_hdr): Fix typo in prototype.
2196 This bug broke the build on AIX. Problem reported by Gilles Pion.
2197
9d0a235a
MA
21982012-05-14 Michael Albinus <michael.albinus@gmx.de>
2199
2200 * keyboard.c (kbd_buffer_get_event): Read special events also in
2201 batch mode. (Bug#11415)
2202
9e6b06ed
GM
22032012-05-12 Glenn Morris <rgm@gnu.org>
2204
2205 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2206
c1a1d7a3
EZ
22072012-05-12 Eli Zaretskii <eliz@gnu.org>
2208
2209 * lisp.mk (lisp): Add newcomment.elc.
2210
3fe7cdc8
GM
22112012-05-12 Glenn Morris <rgm@gnu.org>
2212
2213 * Makefile.in (MKDIR_P): New, set by configure.
2214 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2215
53f7d2c0
PE
22162012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 Remove unused function hourglass_started.
2219 * dispextern.h (hourglass_started):
2220 * w32fns.c (hourglass_started):
2221 * xdisp.c (hourglass_started): Remove.
2222
75aafb17
JB
22232012-05-10 Juanma Barranquero <lekktu@gmail.com>
2224
2225 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2226 Update dependencies.
2227
12959e8e
PE
22282012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2229
97107e2e
PE
2230 * xgselect.c (xg_select): Put maxfds+1 into a var.
2231 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2232
12959e8e
PE
2233 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2234
836d29b3
DA
22352012-05-10 Dave Abrahams <dave@boostpro.com>
2236
2237 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2238 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2239
5cb67954
MA
22402012-05-09 Michael Albinus <michael.albinus@gmx.de>
2241
2242 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2243 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2244 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2245 Initialize xd_registered_buses.
2246
3478ec45
PE
22472012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2248
b263a6b0
PE
2249 Untag more efficiently if USE_LSB_TAG.
2250 This is based on a proposal by YAMAMOTO Mitsuharu in
2251 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2252 For an admittedly artificial (nth 8000 longlist) benchmark on
2253 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2254 Emacs's overall text size by 1%.
2255 * lisp.h (XUNTAG): New macro.
2256 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
2257 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
2258 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
2259 * eval.c (Fautoload):
2260 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
2261 * frame.h (XFRAME): Use XUNTAG.
2262
3478ec45
PE
2263 Port recent dbusbind.c changes to 32-bit --with-wide-int.
2264 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
2265 Remove unportable assumptions about print widths of types like
2266 dbus_uint32_t.
2267 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
2268 intptr_t when converting between pointer and integer, to avoid GCC
2269 warnings about wrong width.
2270
666b903b 22712012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
2272
2273 * w32proc.c (new_child): Force Windows to reserve only 64KB of
2274 stack for each reader_thread, instead of defaulting to 8MB
2275 determined by the linker. This avoids failures in creating
2276 subprocesses on Windows 7, see the discussion in this thread:
2277 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
2278
b120cc17
JC
22792012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
2280
2281 Fix up display of the *Minibuf-0* buffer in the mini window.
2282 * keyboard.c (read_char): Don't clear the echo area if there's no
2283 message to clear.
2284 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 2285 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 2286
9a4b36f8
MA
22872012-05-07 Michael Albinus <michael.albinus@gmx.de>
2288
2289 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
2290 batch mode.
2291
e5f9458f
CY
22922012-05-06 Chong Yidong <cyd@gnu.org>
2293
2294 * lisp.mk (lisp): Update.
2295
eceeb5fc 22962012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
2297
2298 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
2299
71873e2b
SM
23002012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
2301
2302 * data.c (PUT_ERROR): New macro.
2303 (syms_of_data): Use it. Add new error type `user-error'.
2304 * undo.c (user_error): New function.
2305 (Fprimitive_undo): Use it.
2306 * print.c (print_error_message): Adjust print style for `user-error'.
2307 * keyboard.c (user_error): New function.
2308 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
2309
ab0fa4e4
PE
23102012-05-03 Paul Eggert <eggert@cs.ucla.edu>
2311
2312 Do not limit current-time-string to years 1000..9999.
2313 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
2314 (Fcurrent_time_string): Support any year that is supported by the
2315 underlying localtime representation. Don't use asctime, as it
2316 has undefined behavior for years outside the range -999..9999.
2317
7ed806a7
PE
23182012-05-02 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 Fix race conditions involving setenv, gmtime, localtime, asctime.
2321 Without this fix, interrupts could mess up code that uses these
2322 nonreentrant functions, since setting TZ invalidates existing
2323 tm_zone or tzname values, and since most of these functions return
2324 pointers to static storage.
2325 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
2326 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
2327 Grow the critical sections to include not just invoking
2328 localtime/gmtime, but also accessing these functions' results
2329 including their tm_zone values if any, and any related TZ setting.
2330 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
2331 so that the struct tm is saved in the critical section.
2332 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
2333 motivated by the fact that memory allocation needs to be outside
2334 the critical section.
2335
0c16dfed
DA
23362012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
2337
2338 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
2339 with RESET_INTERVAL.
2340
2341 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2342 Remove duplicated buffer name initialization.
2343
3f83ace8
JM
23442012-05-02 Jim Meyering <jim@meyering.net>
2345
2346 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
2347
c7b8541e
JM
2348 * xfns.c (x_window): Use xstrdup (Bug#11375).
2349
90207a15 23502012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
2351
2352 * xdisp.c (pos_visible_p): If already at a newline from the
2353 display string before the 'while' loop, don't walk back the glyphs
2354 from it3.glyph_row. Solves assertion violation when the display
2355 string begins with a newline (egg.el). (Bug#11367)
2356
b593d6a9
AH
23572012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
2358
2359 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
2360 Move to simple.el.
2361
4737362e
GM
23622012-05-01 Glenn Morris <rgm@gnu.org>
2363
99cf43f9
GM
2364 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
2365 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
2366 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
2367 All were removed before 23.1.
2368
9311dcff
GM
2369 * dispnew.c: Remove HAVE_LIBNCURSES test;
2370 it is always true on relevant platforms.
2371
4d5c6349
GM
2372 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
2373 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
2374
4737362e
GM
2375 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
2376
74dd3a6b
AS
23772012-04-30 Andreas Schwab <schwab@linux-m68k.org>
2378
2379 * .gdbinit (xpr): Remove checks for no longer existing misc types.
2380 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
2381 Remove.
2382
13c379ee
PE
23832012-04-28 Paul Eggert <eggert@cs.ucla.edu>
2384
2385 Do not avoid creating empty evaporating overlays (Bug#9642).
2386 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
2387 That is, do not delete an evaporating overlay if it becomes
2388 empty after its bounds are adjusted to fit within its buffer.
2389 This fix caused other problems, and I'm reverting it until we get
2390 to the bottom of them.
2391
a8e7d6d7 23922012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
2393
2394 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
2395
a8e7d6d7 23962012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
2397
2398 * xdisp.c (pos_visible_p): If the window start position is beyond
2399 ZV, start the display from buffer beginning. Prevents assertion
2400 violation in init_iterator when the minibuffer window is scrolled
2401 via the scroll bar.
2402
2403 * window.c (window_scroll_pixel_based): Likewise.
2404
a8e7d6d7 24052012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
2406
2407 * keymap.c (where_is_internal): Doc fix (Bug#10872).
2408
a8e7d6d7 24092012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
2410
2411 * fileio.c (Fcopy_file, Fset_file_selinux_context):
2412 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
2413
a8e7d6d7 24142012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 2415
b593d6a9
AH
2416 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
2417 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 2418
1c6900d9
EZ
24192012-04-26 Eli Zaretskii <eliz@gnu.org>
2420
4c3fa1d9
EZ
2421 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
2422 display element, check also the underlying string or buffer
2423 character. (Bug#11341)
2424
1c6900d9
EZ
2425 * w32menu.c: Include w32heap.h.
2426 (add_menu_item): If the call to AppendMenuW (via
2427 unicode_append_menu) fails, disable Unicode menus only if we are
2428 running on Windows 9X/Me.
2429
42bf8205
AS
24302012-04-24 Andreas Schwab <schwab@linux-m68k.org>
2431
2432 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
2433 (xgetint): Add missing shift for LSB tags.
2434
b1bac16e
MR
24352012-04-24 Martin Rudalics <rudalics@gmx.at>
2436
2437 * keyboard.c (read_char): Don't wipe echo area for select window
2438 events: These might get delayed via `mouse-autoselect-window'
2439 (Bug#11304).
2440
d69621cc
JB
24412012-04-24 Juanma Barranquero <lekktu@gmail.com>
2442
2443 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
2444 manipulation of :loaded-from data.
2445
02fd101b
JB
24462012-04-23 Juanma Barranquero <lekktu@gmail.com>
2447
2448 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
2449 now a cons (bug#11311).
2450
888bec30
PE
24512012-04-23 Paul Eggert <eggert@cs.ucla.edu>
2452
89a438bd
PE
2453 Do not create empty overlays with the evaporate property (Bug#9642).
2454 * buffer.c (Fmove_overlay): Delete an evaporating overlay
2455 if it becomes empty after its bounds are adjusted to fit within
2456 its buffer. Without this fix, in a nonempty buffer (let ((o
2457 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
2458 yields an empty overlay that has the evaporate property, which is
2459 not supposed to happen.
2460
1068fe4d
PE
2461 Fix minor GTK3 problems found by static checking.
2462 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2463 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2464 (struct _EmacsFixedClass, emacs_fixed_get_type):
2465 Move decls here from emacsgtkfixed.h, since they needn't be public.
2466 (emacs_fixed_get_type): Now static.
2467 (emacs_fixed_class_init): Omit unused local.
2468 (emacs_fixed_child_type): Remove; unused.
2469 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
2470 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
2471 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
2472 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
2473 (EMACS_FIXED_GET_CLASS): Remove; unused.
2474 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
2475
888bec30
PE
2476 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
2477 Problem reported by Juanma Barranquero for Windows -Wunused-function.
2478
de85e130
PE
24792012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2480
d0baac98 2481 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 2482 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
2483 (__malloc_size_t, __malloc_ptrdiff_t):
2484 Remove. All uses removed, replaced by the definiens if needed,
2485 since we can assume C89 or better now.
2486 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
2487 (protect_malloc_state, align, get_contiguous_space)
2488 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
2489 (malloc_atfork_handler_child, malloc_enable_thread)
2490 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
2491 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
2492 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
2493 (special_realloc, _realloc_internal_nolock, _realloc_internal)
2494 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
2495 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
2496 Define using prototypes, not old style.
2497 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
2498 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
2499 (align): Don't assume that signed integer overflow wraps around.
2500 Omit unused local var.
2501 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
2502 (_free_internal_nolock, memalign, mallochook, reallochook):
2503 Omit no-longer-needed casts.
2504 (valloc): Use getpagesize, not __getpagesize.
2505 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
2506 (struct hdr): The 'magic' member is now size_t, not unsigned long.
2507
de85e130
PE
2508 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
2509
dcbf5805
MA
25102012-04-22 Michael Albinus <michael.albinus@gmx.de>
2511
2512 Move functions from C to Lisp. Make non-blocking method calls
2513 the default. Implement further D-Bus standard interfaces.
2514
2515 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
2516 (QCdbus_request_name_allow_replacement)
2517 (QCdbus_request_name_replace_existing)
2518 (QCdbus_request_name_do_not_queue)
2519 (QCdbus_request_name_reply_primary_owner)
2520 (QCdbus_request_name_reply_in_queue)
2521 (QCdbus_request_name_reply_exists)
2522 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
2523 (QCdbus_registered_serial, QCdbus_registered_method)
2524 (QCdbus_registered_signal): New Lisp objects.
2525 (XD_DEBUG_MESSAGE): Use sizeof.
2526 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
2527 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
2528 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
2529 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
2530 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
2531 (xd_signature, xd_append_arg): Allow float for integer types.
2532 (xd_get_connection_references): New function.
b593d6a9
AH
2533 (xd_get_connection_address): Rename from xd_initialize.
2534 Return cached address.
dcbf5805
MA
2535 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
2536 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
2537 level.
2538 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 2539 Return number of refcounts.
dcbf5805
MA
2540 (Fdbus_get_unique_name): Make stronger parameter check.
2541 (Fdbus_message_internal): New defun.
2542 (Fdbus_call_method, Fdbus_call_method_asynchronously)
2543 (Fdbus_method_return_internal, Fdbus_method_error_internal)
2544 (Fdbus_send_signal, Fdbus_register_service)
2545 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
2546 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
2547 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
2548 (Vdbus_compiled_version, Vdbus_runtime_version)
2549 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
2550 (Vdbus_message_type_method_return, Vdbus_message_type_error)
2551 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
2552 (Vdbus_registered_buses, Vdbus_registered_objects_table):
2553 Adapt docstring.
dcbf5805 2554
52828e02
PE
25552012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2556
da05bc4c
PE
2557 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
2558 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
2559 Do not assume ptrdiff_t is the same width as 'int'.
2560
52828e02
PE
2561 * alloc.c: Handle unusual debugging option combinations.
2562 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
2563 since the two debugging options are incompatible.
2564 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
2565 is defined.
2566 (mem_init, mem_insert, mem_insert_fixup):
2567 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
2568 (NEED_MEM_INSERT): Remove; no longer needed.
2569
f01769f9
LL
25702012-04-22 Leo Liu <sdl.web@gmail.com>
2571
2572 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
2573
5790543d
PE
25742012-04-22 Paul Eggert <eggert@cs.ucla.edu>
2575
2576 * sysdep.c [__FreeBSD__]: Minor cleanups.
2577 (list_system_processes, system_process_attributes) [__FreeBSD__]:
2578 Use Emacs indenting style more consistently. Avoid some casts.
2579 Use 'double' consistently rather than mixing 'float' and 'double'.
2580
b91b7e4d
EW
25812012-04-21 Eduard Wiebe <usenet@pusto.de>
2582
b593d6a9
AH
2583 * sysdep.c (list_system_processes, system_process_attributes):
2584 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 2585
6114eb15
AS
25862012-04-21 Andreas Schwab <schwab@linux-m68k.org>
2587
2588 * lisp.mk (lisp): Update.
2589
2f38dff7
PE
25902012-04-20 Paul Eggert <eggert@cs.ucla.edu>
2591
2592 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
2593 It is never used otherwise.
2594
4ae29f89
SM
25952012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
2596
2597 * print.c (print_preprocess): Only check print_depth if print-circle
2598 is nil.
2599 (print_object): Check for cycles even when print-circle is nil and
2600 print-gensym is t, but only check print_depth if print-circle is nil.
2601
f30d612a
CY
26022012-04-20 Chong Yidong <cyd@gnu.org>
2603
2604 * process.c (wait_reading_process_output): If EIO occurs on a pty,
2605 set the status to "failed" and ensure that sentinel is run.
2606
c07a4c0b 26072012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
2608
2609 * process.c (Fset_process_inherit_coding_system_flag)
2610 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 2611 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 2612
c07a4c0b 26132012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
2614
2615 * xdisp.c (string_buffer_position_lim): Limit starting position to
2616 BEGV.
2617 (set_cursor_from_row): If called for a mode-line or header-line
2618 row, return zero immediately.
2619 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2620 farther than the first row after the header line, if any.
2621 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2622 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2623
c07a4c0b 26242012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2625
4ae29f89
SM
2626 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2627 (bug#11238).
ad3a2b41 2628
c07a4c0b 26292012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 26302012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2631
2632 configure: new option --enable-gcc-warnings (Bug#11207)
2633 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2634 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2635 (ALL_CFLAGS): Use new macros rather than old.
2636 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2637 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2638 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2639 -Wunused-result, -Wunused-variable. This should go away once
2640 the Emacs and Gnulib regex code is merged.
2641 (xmalloc, xrealloc): Now static.
2642
aba027e8
PE
26432012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2644
2645 * dired.c (Fsystem_groups): Remove unused local.
2646
e5a36063
GM
26472012-04-17 Glenn Morris <rgm@gnu.org>
2648
2649 * dired.c (Fsystem_users): Doc fix.
2650
316411f0
DA
26512012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2652
2653 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2654 (syms_of_dired): Add them.
2655
9426aba4
PE
26562012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2657
b62a57be
PE
2658 Fix minor alloc.c problems found by static checking.
2659 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2660 New extern decls, to avoid calling undeclared functions.
2661 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2662 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2663 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2664 (NEED_MEM_INSERT): New macro.
2665 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2666 Remove one incorrect comment and fix another.
b62a57be 2667
3539f31f
PE
2668 Fix minor ralloc.c problems found by static checking.
2669 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2670 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2671 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2672 (r_alloc_sbrk): Now static.
2673
a041960a
PE
2674 Improve ralloc.c interface checking.
2675 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2676 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2677 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2678 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2679 [REL_ALLOC]: ... to here, to check interface.
2680 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2681 Remove decls. This fixes an "It stinks!".
2682
9426aba4
PE
2683 * alloc.c (which_symbols): Fix alignment issue / type clash.
2684
d55c12ed
AS
26852012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2686
2687 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2688 (struct Lisp_Misc_Any): Likewise.
2689 (struct Lisp_Free): Likewise.
2690 * alloc.c (union aligned_Lisp_Symbol): Define.
2691 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2692 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2693 (union aligned_Lisp_Misc): Define.
2694 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2695 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2696 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2697
b948ce8b
PE
26982012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2699
2700 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2701 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2702 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2703 * s/netbsd.h, s/sol2-6.h:
2704 Remove definition of GC_MARK_STACK, since the default now works.
2705 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2706 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2707 no longer the default.
2708 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2709
35dc09a1 27102012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2711
35dc09a1
GM
2712 * lread.c (lisp_file_lexically_bound_p):
2713 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2714
35dc09a1
GM
27152012-04-14 Eli Zaretskii <eliz@gnu.org>
2716
2717 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2718 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2719
27202012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2721
2722 * nsterm.m (constrainFrameRect): Always constrain when there is only
2723 one screen (Bug#10962).
2724
bcd86815
KB
27252012-04-13 Ken Brown <kbrown@cornell.edu>
2726
2727 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2728
c25df26e
RT
27292012-04-13 Reuben Thomas <rrt@sc3d.org>
2730
2731 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2732
0fc59f1e
DC
27332012-04-11 Daniel Colascione <dancol@dancol.org>
2734
2735 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2736 against is gone. It's better to use vfork now so that when Cygwin
2737 gains a new, working vfork, we use it automatically (bug#10398).
2738
de8c03dc
SM
27392012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2740
2741 * window.c (save_window_save): Obey window-point-insertion-type.
2742
2f097256
GM
27432012-04-11 Glenn Morris <rgm@gnu.org>
2744
2745 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2746
453b951e
SM
27472012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2748
2749 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2750
75f1671a 27512012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2752
2753 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2754 (force_quit_count): New var.
2755 (handle_interrupt): Use it.
2756
2a8ce227
JB
27572012-04-10 Juanma Barranquero <lekktu@gmail.com>
2758
2759 * w32.c (w32_delayed_load): Record the full path of the library
2760 being loaded (bug#10424).
2761
935396c0
GM
27622012-04-09 Glenn Morris <rgm@gnu.org>
2763
05920a43
GM
2764 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2765 not just in the obarray, before snarfing them. (Bug#11036)
2766
935396c0
GM
2767 * Makefile.in ($(leimdir)/leim-list.el):
2768 Pass EMACS rather than BUILT_EMACS.
2769
a18ecafa
TZ
27702012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2771
2772 * process.c (make_process):
2773 * process.h: Add integer `gnutls_handshakes_tried' member to
2774 process struct.
2775
6bbef4e5
JC
2776 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2777 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2778
2779 * gnutls.c (gnutls_log_function2i): Convenience log function.
2780 (emacs_gnutls_read): Use new log functions,
2781 `gnutls_handshakes_tried' process member, and
2782 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2783 attempts per process (connection).
2784
b4d3bc10
CY
27852012-04-09 Chong Yidong <cyd@gnu.org>
2786
2787 * eval.c (Fuser_variable_p, user_variable_p_eh)
2788 (lisp_indirect_variable): Functions deleted.
2789 (Fdefvar): Caller changed.
2790
2791 * callint.c (Finteractive, Fcall_interactively):
2792 * minibuf.c (Fread_variable): Callers changed.
2793
70f4d973
EZ
27942012-04-09 Eli Zaretskii <eliz@gnu.org>
2795
2796 * xdisp.c (set_cursor_from_row): If the display string appears in
2797 the buffer at position that is closer to point than the position
2798 after the display string, display the cursor on the first glyph of
2799 the display string. Fixes cursor display when a 'display' text
2800 property immediately follows invisible text. (Bug#11094)
2801
cb3c2e3e
PE
28022012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2803
2804 composite.c: use 'double' consistently
2805 * composite.c (get_composition_id): Use 'double' consistently
2806 instead of converting 'float' to 'double' and vice versa; this is
2807 easier to understand and avoids a GCC warning.
2808
fd06db5d
GM
28092012-04-09 Glenn Morris <rgm@gnu.org>
2810
50fe702a
GM
2811 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2812 preparation for dumping it with emacs. (Bug#4789)
2813 (leimdir): New variable.
2814 ($(leimdir)/leim-list.el): New rule.
2815 (emacs$(EXEEXT)): Depend on leim-list.el.
2816
fd06db5d
GM
2817 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2818 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2819 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2820
55c131ee
AS
28212012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2822
2823 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2824 proper alignment.
2825
9209588f
JB
28262012-04-07 Juanma Barranquero <lekktu@gmail.com>
2827
2828 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2829 Remove unused local variable.
2830
e3fb2efb
PE
28312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2832
2833 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2834 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2835 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2836 objects, as mark_maybe_pointer will catch them otherwise.
2837 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2838 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2839
b5385551
PE
28402012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2841
2842 Fix typo that broke non-Windows builds.
2843 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2844
9078ead6
EZ
28452012-04-07 Eli Zaretskii <eliz@gnu.org>
2846
2847 Support building on MS-Windows with libxml2.
2848
2849 * makefile.w32-in (OBJ2): Add xml.$(O).
2850 (GLOBAL_SOURCES): Add xml.c.
2851 ($(BLD)/xml.$(O)): New dependency list.
2852
2853 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2854 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2855 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2856 [!WINDOWSNT]: New macros.
2857 (init_libxml2_functions, libxml2_loaded_p): New functions.
2858 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2859 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2860 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2861 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2862 linked in).
6bbef4e5
JC
2863 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2864 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2865 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2866
2867 * emacs.c: Don't include libxml/parser.h.
2868 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2869 xmlCleanupParser directly.
2870
2871 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2872
3811fdf3
EZ
28732012-04-07 Eli Zaretskii <eliz@gnu.org>
2874
2875 * indent.c (Fvertical_motion): If there is a display string at
2876 point, use it.vpos to compute how many lines to backtrack after
2877 move_it_to point. (Bug#11133)
2878
2f8e16b2
EZ
28792012-04-06 Eli Zaretskii <eliz@gnu.org>
2880
2881 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2882 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2883 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2884 macros related to unification of CJK characters. For the details,
2885 see the discussion following the message here:
2886 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2887
3d439cd1
CY
28882012-04-04 Chong Yidong <cyd@gnu.org>
2889
2890 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2891
8bc53d00
EZ
28922012-04-01 Eli Zaretskii <eliz@gnu.org>
2893
2894 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2895 instead of alloca. (Bug#11138)
2896
3b0512a3
AS
28972012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2898
2899 * w32menu.c (is_simple_dialog): Properly check lisp types.
2900 (Bug#11141)
2901
8427ddd2
EZ
29022012-03-31 Eli Zaretskii <eliz@gnu.org>
2903
979022ef
EZ
2904 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2905 position we get to after a call to move_it_to fails the
2906 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2907 only if we wind up in a string from display property. (Bug#11063)
2908
a6b1c7cc
EZ
2909 * window.c (Fdelete_other_windows_internal): Invalidate the row
2910 and column information about mouse highlight, so that redisplay
2911 restores it after reallocating the glyph matrices. (Bug#7464)
2912
8427ddd2
EZ
2913 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2914 string comes from a `display' text property, use the buffer
2915 position of that property as if we actually saw that position in
2916 the row's glyphs.
697ba24b
EZ
2917 (move_it_by_lines): Remove the assertion that
2918 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2919 violated when there's a before-string at the beginning of a line.
2920 (Bug#11063)
8427ddd2 2921
65a0a738
EZ
29222012-03-30 Eli Zaretskii <eliz@gnu.org>
2923
2924 * xdisp.c (append_space_for_newline): If the default face was
2925 remapped, use the remapped face for the appended newline.
2926 (extend_face_to_end_of_line): Use the remapped default face for
2927 extending the face to the end of the line.
2928 (display_line): Call extend_face_to_end_of_line when the default
2929 face was remapped. (Bug#11068)
2930
581355cc
EZ
29312012-03-29 Eli Zaretskii <eliz@gnu.org>
2932
2933 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2934
e8fc049f
SM
29352012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2936
2937 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2938
4fb9a543
GM
29392012-03-27 Glenn Morris <rgm@gnu.org>
2940
2941 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2942 Doc fixes.
2943
679910f1
KH
29442012-03-26 Kenichi Handa <handa@m17n.org>
2945
2946 * dispextern.h (struct glyph): Fix previous change. Change the
2947 bit length of glyphless.ch to 25 (Bug#11082).
2948
90d49b7f
CY
29492012-03-26 Chong Yidong <cyd@gnu.org>
2950
2951 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2952 (command_loop_1): Use it; inhibit selection update for
2953 handle-select-window too (Bug#8996).
2954
f514f6f0
FP
29552012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2956
e8fc049f 2957 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2958
bf43fa51
KH
29592012-03-25 Kenichi Handa <handa@m17n.org>
2960
2961 * dispextern.h (struct glyph): Change the bit length of
2962 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2963
8a0c01dd
EZ
29642012-03-24 Eli Zaretskii <eliz@gnu.org>
2965
2966 * s/ms-w32.h (tzname): Include time.h before redirecting to
2967 _tzname. Fixes the MSVC build. (Bug#9960)
2968
7d1c3a76
AS
29692012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2970
8ed79523
AS
2971 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2972 characters.
2973
7d1c3a76
AS
2974 * xterm.c (XTread_socket): Only modify handling_signal if
2975 !SYNC_INPUT. (Bug#11080)
2976
e99a9b8b
EZ
29772012-03-23 Eli Zaretskii <eliz@gnu.org>
2978
2979 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2980 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2981 when fetching a multibyte character consumes more bytes than
2982 CHAR_BYTES returns, due to unification of CJK characters in
2983 string_char. (Bug#11073)
2984
5063c0e1
TN
29852012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2986
2987 * process.c (wait_reading_process_output): Handle pty disconnect
2988 by refraining from sending oneself a SIGCHLD (bug#10933).
2989
9f851fbd
CY
29902012-03-22 Chong Yidong <cyd@gnu.org>
2991
2992 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2993
5063c0e1 2994 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2995 Mark string as coming from a prefix property.
2996 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2997 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2998
fb5b8aca
CY
29992012-03-21 Chong Yidong <cyd@gnu.org>
3000
3001 * xfaces.c (Vface_remapping_alist): Doc fix.
3002
62356a1b
EZ
30032012-03-20 Eli Zaretskii <eliz@gnu.org>
3004
3005 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3006 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3007 Doc fixes.
62356a1b 3008
025de85b
CY
30092012-03-20 Chong Yidong <cyd@gnu.org>
3010
3011 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3012 to reflect default non-nil value of redisplay-dont-pause.
3013
4827f94e
KH
30142012-03-19 Kenichi Handa <handa@m17n.org>
3015
3016 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3017 it fit in a valid range (Bug#11003).
3018
e50a24a2
EZ
30192012-03-18 Eli Zaretskii <eliz@gnu.org>
3020
3021 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3022 that is not from display property, accept the row as a "cursor
3023 row" if one of the string's character has a non-nil `cursor'
3024 property. Fixes cursor positioning when there are newlines in
3025 overlay strings, e.g. in icomplete.el. (Bug#11035)
3026
9af5ed87
PE
30272012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3028
3029 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3030
d1f55f16
CY
30312012-03-12 Chong Yidong <cyd@gnu.org>
3032
3033 * eval.c (inhibit_lisp_code): Rename from
3034 inhibit_window_configuration_change_hook; move from window.c.
3035
3036 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3037 * window.c (run_window_configuration_change_hook)
3038 (syms_of_window): Callers changed.
3039
66c5eebd
CY
30402012-03-11 Chong Yidong <cyd@gnu.org>
3041
413df973
CY
3042 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3043
66c5eebd
CY
3044 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3045
1de11f56
CY
30462012-03-10 Chong Yidong <cyd@gnu.org>
3047
3048 * frame.c (other_visible_frames): Don't assume the selected frame
3049 is visible (Bug#10955).
3050
cae07000
SM
30512012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3052
3053 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3054
89c94350
JD
30552012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3056
3057 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3058 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3059 zero (Bug#10954).
3060
999dd333
GM
30612012-03-03 Glenn Morris <rgm@gnu.org>
3062
01a6dcc8 3063 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3064
de0100f2
EZ
30652012-03-02 Eli Zaretskii <eliz@gnu.org>
3066
3067 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3068 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3069 (redisplay_window, next_element_from_string): Fix typos in
3070 comments.
3e441275
EZ
3071 (redisplay_window): Pass to move_it_vertically the margin in
3072 pixels, not in screen lines.
de0100f2 3073
96a72ee9
GM
30742012-03-02 Glenn Morris <rgm@gnu.org>
3075
3076 * buffer.c (buffer-list-update-hook): Doc fix.
3077
312508d7
EZ
30782012-02-29 Eli Zaretskii <eliz@gnu.org>
3079
3080 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3081 push_it before setting up the iterator for the first overlay
3082 string, even if we have an empty string loaded.
3083 (next_overlay_string): If there's an empty string on the iterator
3084 stack, pop the stack. (Bug#10903)
3085
27f3c637
PE
30862012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3087
3088 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3089 Suggested by Stefan Monnier in
3090 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3091 * alloc.c (widen_to_Lisp_Object): New static function.
3092 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3093 and widening them to Lisp_Objects. This would work even if
3094 USE_LSB_TAG is defined and wide integers are used, which might
3095 happen in a future version of Emacs.
3096
3c9dfce6
CY
30972012-02-25 Chong Yidong <cyd@gnu.org>
3098
fa74b241
CY
3099 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3100 Doc fix.
3101
3c9dfce6
CY
3102 * xselect.c (Fx_selection_exists_p): Doc fix.
3103 (x_clipboard_manager_save_all): Print an informative message
3104 before saving to clipboard manager.
3105
9486df08
CY
31062012-02-24 Chong Yidong <cyd@gnu.org>
3107
3108 * keyboard.c (process_special_events): Handle all X selection
3109 requests in kbd_buffer, not just the next one (Bug#8869).
3110
f01d3321
CY
31112012-02-23 Chong Yidong <cyd@gnu.org>
3112
3113 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3114 call when setting menu-bar-lines and tool-bar-lines parameters.
3115 (unwind_create_frame_1): New helper function.
3116
3117 * window.c (inhibit_window_configuration_change_hook): New var.
3118 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3119 (syms_of_window): Initialize it.
f01d3321 3120
86b847b6
CY
31212012-02-22 Chong Yidong <cyd@gnu.org>
3122
3123 * xterm.c (x_draw_image_relief): Add missing type check for
3124 Vtool_bar_button_margin (Bug#10743).
3125
a59225b1
CY
31262012-02-21 Chong Yidong <cyd@gnu.org>
3127
3128 * fileio.c (Vfile_name_handler_alist): Doc fix.
3129
3130 * buffer.c (Fget_file_buffer): Protect against invalid file
3131 handler return value.
3132
310f5bd4
PE
31332012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3134
cb3a28cc
PE
3135 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3136 when computing $valmask.
3137
310f5bd4
PE
3138 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3139 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3140 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3141 It's useless in that case, and it can cause problems on hosts
3142 that allocate halves of EMACS_INT values separately.
3143 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3144 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3145 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3146 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3147 it avoids undefined behavior on hosts where shifting right by more
3148 than the word width has undefined behavior.
3149
2375c96a
CY
31502012-02-19 Chong Yidong <cyd@gnu.org>
3151
3152 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3153 (Funhandled_file_name_directory, Ffile_name_as_directory)
3154 (Fdirectory_file_name, Fexpand_file_name)
3155 (Fsubstitute_in_file_name): Protect against invalid file handler
3156 return values (Bug#10845).
3157
3eb49e71
EZ
31582012-02-18 Eli Zaretskii <eliz@gnu.org>
3159
3160 * .gdbinit (pitx): Fix incorrect references to fields of the
3161 iterator stack.
3162
7b926f3f
CY
31632012-02-17 Chong Yidong <cyd@gnu.org>
3164
3165 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3166
11273115
PE
31672012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3168
3169 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3170 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3171
c3a70e2b
CY
31722012-02-15 Chong Yidong <cyd@gnu.org>
3173
3174 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3175 marked as special. Also, starting docstrings with * is obsolete.
3176
0ca43699
AS
31772012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3178
3179 * gnutls.c (emacs_gnutls_write): Fix last change.
3180
2e8f3c56
LI
31812012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3182
3183 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3184 send_process.
3185
af70074f
SM
31862012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3187
3188 * keymap.c (Fsingle_key_description): Handle char ranges.
3189
95986d52
CY
31902012-02-12 Chong Yidong <cyd@gnu.org>
3191
afd83bd1
CY
3192 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3193 as that creates a dangerous corner case.
3194
95986d52
CY
3195 * window.c (Fdelete_window_internal): Invalidate the mouse
3196 highlight (Bug#9904).
3197
bd7da63e
GM
31982012-02-12 Glenn Morris <rgm@gnu.org>
3199
3200 * xselect.c (Fx_own_selection_internal)
3201 (Fx_get_selection_internal, Fx_disown_selection_internal)
3202 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3203 * nsselect.m (Fx_own_selection_internal)
3204 (Fx_disown_selection_internal, Fx_selection_exists_p)
3205 (Fx_selection_owner_p, Fx_get_selection_internal):
3206 Sync docs and argument specs with the xselect.c versions.
3207
77abcbc2
LI
32082012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3209
3210 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3211
90b671e2
EZ
32122012-02-11 Eli Zaretskii <eliz@gnu.org>
3213
1c0ca0b7
EZ
3214 * w32select.c (Fx_selection_exists_p): Sync doc string and
3215 argument list with xselect.c. (Bug#10783)
3216
3217 * w16select.c (Fx_selection_exists_p): Sync doc string and
3218 argument list with xselect.c. (Bug#10783)
90b671e2 3219
49241268
GM
32202012-02-10 Glenn Morris <rgm@gnu.org>
3221
3222 * fns.c (Fsecure_hash): Doc fix.
3223
f998bbe7 32242012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3225
3226 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3227
0992bd9c
CY
32282012-02-07 Chong Yidong <cyd@gnu.org>
3229
3230 * buffer.c (Fbuffer_local_variables)
3231 (buffer_lisp_local_variables): Handle unbound vars correctly;
3232 don't let Qunbound leak into Lisp.
3233
af008560
GM
32342012-02-07 Glenn Morris <rgm@gnu.org>
3235
dd605cc4
GM
3236 * image.c (Fimagemagick_types): Doc fix.
3237
af008560
GM
3238 * image.c (imagemagick-render-type): Change it from a lisp object
3239 to an integer. Move the doc here from the lisp manual.
3240 Treat all values not equal to 0 the same.
3241
1449fa1d
CY
32422012-02-06 Chong Yidong <cyd@gnu.org>
3243
3244 * doc.c (store_function_docstring): Avoid applying docstring of
3245 alias to base function (Bug#2603).
3246
3723ec07
AS
32472012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3248
3249 * .gdbinit (pp1, pv1): Remove redundant defines.
3250 (pr): Use pp.
3251
79c1cc1e
CY
32522012-02-04 Chong Yidong <cyd@gnu.org>
3253
3254 * nsterm.m: Declare a global (Bug#10694).
3255
d7f29f8e
EZ
32562012-02-04 Eli Zaretskii <eliz@gnu.org>
3257
cae07000
SM
3258 * w32.c (get_emacs_configuration_options):
3259 Include --enable-checking, if specified, in the return value.
d7f29f8e 3260
3b95a6f9
MR
32612012-02-04 Martin Rudalics <rudalics@gmx.at>
3262
3263 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
3264 after rounding frame sizes. (Bug#9723)
3265
d6fa96a6
EZ
32662012-02-04 Eli Zaretskii <eliz@gnu.org>
3267
3268 * keyboard.c (adjust_point_for_property): Don't position point
3269 before BEGV. (Bug#10696)
3270
df0b2940
PE
32712012-02-03 Paul Eggert <eggert@cs.ucla.edu>
3272
3273 Handle overflow when computing char display width (Bug#9496).
3274 * character.c (char_width): Return EMACS_INT, not int.
3275 (char_width, c_string_width): Check for overflow when
3276 computing the width; this is possible now that individual
3277 characters can have unbounded width. Problem introduced
3278 by merge from Emacs 23 on 2012-01-19.
3279
6bee44d6
MA
32802012-02-02 Michael Albinus <michael.albinus@gmx.de>
3281
3282 * dbusbind.c (Fdbus_register_method): Mention the return value
3283 :ignore in the docstring.
3284
44f92739
GM
32852012-02-02 Glenn Morris <rgm@gnu.org>
3286
1b9f60cc
GM
3287 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
3288
44f92739
GM
3289 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3290 Unconditionally set to t. (Bug#10673)
3291 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
3292 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
3293 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
3294
c5d3843c
KH
32952012-02-02 Kenichi Handa <handa@m17n.org>
3296
3297 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
3298 0, do not call append_composite_glyph.
3299
159462d4 33002012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
3301
3302 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
3303 NULL (Bug#6988).
3304 (x_produce_glyphs): If the component of a composition is a null
3305 string, set it->pixel_width to 1 to avoid zero-width glyph.
3306
78cef877
EZ
33072012-02-01 Eli Zaretskii <eliz@gnu.org>
3308
3309 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
3310 first 2 arguments are identical. This makes inserting large
3311 output from a subprocess an order of magnitude faster on
3312 MS-Windows, where all sbrk'ed memory is always contiguous.
3313
97897668
GM
33142012-01-31 Glenn Morris <rgm@gnu.org>
3315
3316 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 3317 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
3318 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
3319
31fd3586
GM
33202012-01-29 Glenn Morris <rgm@gnu.org>
3321
3322 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
3323
0e24a8b2
CY
33242012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
3325
3326 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
3327
cc0adcb0
CY
33282012-01-28 Chong Yidong <cyd@gnu.org>
3329
3330 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
3331
acc28cb9
CY
33322012-01-26 Chong Yidong <cyd@gnu.org>
3333
9c69cfb7
CY
3334 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
3335
acc28cb9
CY
3336 * search.c (Fsearch_forward, Fsearch_backward): Document negative
3337 repeat counts (Bug#10507).
3338
48da7392
GM
33392012-01-26 Glenn Morris <rgm@gnu.org>
3340
3341 * lread.c (syms_of_lread): Doc fix.
3342
14af5f7f
CY
33432012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
3344
3345 * coding.c (encode_designation_at_bol): Change return value to
3346 EMACS_INT.
3347
0b21c100
CY
33482012-01-25 Chong Yidong <cyd@gnu.org>
3349
3350 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
3351
3c2907f7
CY
33522012-01-21 Chong Yidong <cyd@gnu.org>
3353
3354 * floatfns.c (Fcopysign): Make the second argument non-optional,
3355 since nil is not allowed anyway.
3356
959ad23f
AS
33572012-01-21 Andreas Schwab <schwab@linux-m68k.org>
3358
3359 * process.c (read_process_output): Use p instead of XPROCESS (proc).
3360 (send_process): Likewise.
3361
34a02f46
MR
33622012-01-19 Martin Rudalics <rudalics@gmx.at>
3363
3364 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
3365 (Vwindow_persistent_parameters): Do not use Qstate.
3366 Rewrite doc-strings.
34a02f46 3367
1259009a 33682012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
3369
3370 * character.c (char_width): New function.
70d4fdf6
GM
3371 (Fchar_width, c_string_width, lisp_string_width):
3372 Use char_width (Bug#9496).
25ed9e61 3373
6a6ee00d
MR
33742012-01-16 Martin Rudalics <rudalics@gmx.at>
3375
3376 * window.c (Vwindow_persistent_parameters): New variable.
3377 (Fset_window_configuration, save_window_save): Handle persistent
3378 window parameters.
3379
c85efaf7
EZ
33802012-01-14 Eli Zaretskii <eliz@gnu.org>
3381
3382 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
3383 thrashing the stack of the thread. (Bug#9087)
3384
5944709e
PE
33852012-01-12 Paul Eggert <eggert@cs.ucla.edu>
3386
3387 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
3388
e71f5d99
EZ
33892012-01-11 Eli Zaretskii <eliz@gnu.org>
3390
3391 * xdisp.c (rows_from_pos_range): Handle the case where the
3392 highlight ends on a newline. (Bug#10464)
3393 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
3394 he end column for display of highlight that ends on a newline
3395 before a R2L line.
3396
ce316182
GM
33972012-01-11 Glenn Morris <rgm@gnu.org>
3398
3399 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
3400 from load-path also when installation-directory is nil. (Bug#10208)
3401
5b43da69
GM
34022012-01-10 Glenn Morris <rgm@gnu.org>
3403
74cc8ff9
GM
3404 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
3405
7d8d6e4e
GM
3406 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
3407 Update template values to be closer to their typical values these days.
5b43da69 3408
a0db8d43
EZ
34092012-01-09 Eli Zaretskii <eliz@gnu.org>
3410
3411 * xdisp.c (rows_from_pos_range): Accept additional argument
3412 DISP_STRING, and accept any glyph in a row whose object is that
3413 string as eligible for mouse highlight. Fixes mouse highlight of
3414 display strings from overlays. (Bug#10464)
3415
9a0115ab 34162012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 3417
b9110d6a 3418 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
3419 * fileio.c (auto_saving_dir_umask): New static var.
3420 (Fmake_directory_internal): Use it.
3421 (do_auto_save_make_dir): Set it, instead of invoking chmod after
3422 creating the directory. The old code temporarily assigns
3423 too-generous permissions to the directory.
3424 (do_auto_save_eh): Clear it.
b9110d6a 3425 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
3426 that the var is always cleared.
3427
6c1bd3f3
EZ
34282012-01-07 Eli Zaretskii <eliz@gnu.org>
3429
3430 * search.c (scan_buffer): Pass character positions to
3431 know_region_cache, not byte positions. (Bug#6540)
3432
069d2b50
L
34332012-01-07 LynX <_LynX@bk.ru> (tiny change)
3434
3435 * w32.c (sys_rename): Report EXDEV when rename of a directory
3436 fails because the target is on another logical disk. (Bug#10284)
3437
75bf0d33
DB
34382012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
3439
3440 * xterm.c (x_embed_request_focus): New function.
3441
3442 * xterm.h: Add prototype.
3443
3444 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
3445
1c6e5a32
GM
34462012-01-05 Glenn Morris <rgm@gnu.org>
3447
3448 * emacs.c (emacs_copyright): Update short copyright year to 2012.
3449
651e947e
EZ
34502012-01-01 Eli Zaretskii <eliz@gnu.org>
3451
3452 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
3453 Load gnutls_transport_set_lowat only if GnuTLS version is below
3454 2.11.1.
3455 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
3456 GnuTLS versions below 2.11.1.
3457
3778cdd8
AL
34582011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
3459
3460 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
3461 to the doc string advising against its use for altering the way
3462 windows are scrolled.
3463
0e5317f7
KH
34642011-12-28 Kenichi Handa <handa@m17n.org>
3465
3466 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
3467 coding-system ASCII compatible only when it does not produce BOM
3468 on encoding (Bug#10383).
3469
93d5ca1f
JD
34702011-12-26 Jan Djärv <jan.h.d@swipnet.se>
3471
3472 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
3473 can scroll.
3474 (create_and_show_popup_menu): Always use menu_position_func for
3475 Gtk3 (Bug#10361).
3476
ca22b785
AS
34772011-12-24 Andreas Schwab <schwab@linux-m68k.org>
3478
3479 * callint.c (Fcall_interactively): Don't truncate prompt string.
3480
d048e1e6
EZ
34812011-12-23 Eli Zaretskii <eliz@gnu.org>
3482
3483 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
3484 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 3485 resumed from there (after widening). (Bug#10360)
d048e1e6 3486
5ccaba1f
JD
34872011-12-22 Jan Djärv <jan.h.d@swipnet.se>
3488
3489 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
3490
204ee57f
JD
34912011-12-21 Jan Djärv <jan.h.d@swipnet.se>
3492
b81d40f0
JB
3493 * nsterm.m (x_free_frame_resources):
3494 Release f->output_data.ns->miniimage.
204ee57f
JD
3495 (ns_index_color): Fix indentation. Do not retain
3496 color_table->colors[i].
3497
3498 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
3499 before returning.
3500
3501 * nsfns.m (x_set_background_color): Assign return value from
3502 ns_index_color to face-background instead of NSColor*.
3503 (ns_implicitly_set_icon_type): Fix indentation.
3504 Change assignment in for loop to comparison.
3505
3506 * emacs.c (ns_pool): New variable.
3507 (main): Assign ns_pool.
3508 (Fkill_emacs): Call ns_release_autorelease_pool.
3509
3510 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
3511 autorelease fdesc, release fdAttrs and tdict.
3512 (ns_get_covering_families): Release charset.
3513 (ns_findfonts): Release NSFontDescriptor created with new.
3514 (ns_uni_to_glyphs): Fix indentation.
3515 (setString): Release attrStr before assigning new value.
3516
c803b2b7
JD
35172011-12-18 Jan Djärv <jan.h.d@swipnet.se>
3518
678f4426
JD
3519 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
3520 and NS_IMPL_COCOA.
3521 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
3522 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
3523
cd394be1 35242011-12-18 David Reitter <reitter@cmu.edu>
678f4426 3525
5fecd5fc
JD
3526 * nsterm.m (ns_term_init): Subscribe for notifications
3527 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
3528 to method trackingNotification in EmacsMenu.
3529
3530 * nsmenu.m (trackingMenu): New variable.
3771cb17 3531 (trackingNotification): New method (from Aquamacs).
5fecd5fc 3532 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 3533 from Aquamacs (Bug#7030).
678f4426
JD
3534
35352011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 3536
c803b2b7
JD
3537 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
3538 (symbol_to_nsstring): Fix indentation.
3539 (ns_symbol_to_pb): New function.
cae07000
SM
3540 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
3541 (Fns_rotate_cut_buffers_internal): Remove.
3542 (Fns_store_selection_internal): Rename from
c803b2b7
JD
3543 Fns_store_cut_buffer_internal.
3544 (ns_get_foreign_selection, Fx_own_selection_internal)
3545 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
3546 (Fns_get_selection_internal, Fns_store_selection_internal):
3547 Use ns_symbol_to_pb and check if return value is nil.
3548 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
3549 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
3550 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
3551 renamed to Sns_store_selection_internal.
3552 (ns_handle_selection_request): Move code to Fx_own_selection_internal
3553 and remove this function.
3554 (ns_handle_selection_clear): Remove, never used.
3555 (Fx_own_selection_internal): Move code from ns_handle_selection_request
3556 here.
3557
e1b01a3a
KB
35582011-12-17 Ken Brown <kbrown@cornell.edu>
3559
3560 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
3561 GID is unknown (Bug#10257).
3562
2adb6e85
PE
35632011-12-17 Paul Eggert <eggert@cs.ucla.edu>
3564
3565 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
3566 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
3567 which caused a build failure on GNU/Linux IA-64. This problem was
3568 introduced by my 2011-10-07 patch.
3569
d1d7b339
JL
35702011-12-15 Juri Linkov <juri@jurta.org>
3571
3572 * image.c (imagemagick_error): New function. (Bug#10112)
3573 (imagemagick_load_image): Comment out `MagickSetResolution' call.
3574 Use `imagemagick_error' where ImageMagick functions return
3575 `MagickFalse'.
3576 (Fimagemagick_types): Add `Fnreverse' to return the list in the
3577 proper order.
3578
100d5755
KH
35792011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3580
3581 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
3582 fill background (Bug#8992).
3583
454592a6
MR
35842011-12-13 Martin Rudalics <rudalics@gmx.at>
3585
3586 * window.c (Vwindow_combination_resize)
3587 (Vwindow_combination_limit): Use t instead of non-nil in
3588 doc-strings.
61d4b438
MR
3589 (Vrecenter_redisplay): Add first sentence of doc-string on
3590 separate line.
53524d93 3591 (Frecenter): Fix doc-string typo.
454592a6 3592
3633e3aa
KH
35932011-12-11 Kenichi Handa <handa@m17n.org>
3594
3595 * coding.c (Funencodable_char_position): Pay attention to the
3596 buffer text relocation (Bug#9389).
3597
7b9d523a 35982011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 3599
7b9d523a
JD
3600 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
3601 gtk_init (Bug#10100).
3602
b73189c6
EZ
36032011-12-10 Eli Zaretskii <eliz@gnu.org>
3604
3605 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
3606 IT->string is nil. (Bug#10263)
3607
f7dfe5d6
JD
36082011-12-10 Jan Djärv <jan.h.d@swipnet.se>
3609
83faebb4
JD
3610 * nsterm.h (x_free_frame_resources): Declare.
3611
f7dfe5d6
JD
3612 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
3613 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
3614
3615 * nsterm.h (ns_get_defaults_value): Declare.
3616
3617 * nsterm.m (ns_default): Call ns_get_defaults_value.
3618
7cd4e72c
EZ
36192011-12-09 Eli Zaretskii <eliz@gnu.org>
3620
3621 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3622 (Bug#10170)
3623
b34d7317
YM
36242011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3625
3626 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3627 that where the value of an _OBJC_* symbol points to is in the .bss
3628 section (Bug#10240).
3629
76470ad1
KH
36302011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3631
3632 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3633 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3634
745fff94
KH
36352011-12-08 Kenichi Handa <handa@m17n.org>
3636
3637 * ftfont.c (get_adstyle_property): Fix previous change
3638 (Bug#10233).
3639
6e44397c
JB
36402011-12-07 Juanma Barranquero <lekktu@gmail.com>
3641
3642 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3643 dirs from the default value of EMACSLOADPATH (bug#10208).
3644
7efa6272
GM
36452011-12-07 Glenn Morris <rgm@gnu.org>
3646
3647 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3648 installation and source directories as well. (Bug#10208)
3649
f6fc4d87
CY
36502011-12-06 Chong Yidong <cyd@gnu.org>
3651
3652 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3653
2bf26180
GM
36542011-12-06 Glenn Morris <rgm@gnu.org>
3655
3656 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3657 as an error, not just -1. (Bug#10217)
3658
3a6ad4f0
CY
36592011-12-05 Chong Yidong <cyd@gnu.org>
3660
3661 * keyboard.c (process_special_events): New function.
3662 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3663
75a3b399
PE
36642011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3665
3666 * coding.c (encode_designation_at_bol): Don't use uninitialized
3667 local variable (Bug#9318).
3668
c3c9e25e
KH
36692011-12-05 Kenichi Handa <handa@m17n.org>
3670
3671 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3672 return Qnil (Bug#8046, Bug#10193).
3673
5eb05ea3
KH
36742011-12-05 Kenichi Handa <handa@m17n.org>
3675
3676 * coding.c (encode_designation_at_bol): New args charbuf_end and
3677 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3678 (coding_set_source): Return how many bytes coding->source was
3679 relocated.
3680 (coding_set_destination): Return how many bytes
3681 coding->destination was relocated.
3682 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3683 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3684
36852011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3686
3687 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3688 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3689 macro (Bug#9318).
3690
36912011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3692
3693 The following changes are to fix Bug#9318.
3694
a79703f5 3695 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3696 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3697 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3698 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3699
7dbda6df
JB
37002011-12-05 Juanma Barranquero <lekktu@gmail.com>
3701
3702 * lisp.h (process_quit_flag): Fix external declaration.
3703
6d5eb5b0
SM
37042011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3705
3706 Don't macro-inline non-performance-critical code.
3707 * eval.c (process_quit_flag): New function.
3708 * lisp.h (QUIT): Use it.
3709
a0c3fad0
JD
37102011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3711
3712 * nsfns.m (get_geometry_from_preferences): New function.
3713 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3714
6c07aac2
AS
37152011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3716
3717 * emacs.c (Qkill_emacs): Define.
3718 (syms_of_emacs): Initialize it.
3719 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3720 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3721 (quit_throw_to_read_char): Add parameter `from_signal'.
3722 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3723 * lisp.h (QUIT): Call Fkill_emacs if requested.
3724
c052ead4
JD
37252011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3726
3727 * widget.c (update_wm_hints): Return if wmshell is null.
3728 (widget_update_wm_size_hints): New function.
3729
3730 * widget.h (widget_update_wm_size_hints): Declare.
3731
3732 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3733 widget_update_wm_size_hints (Bug#10104).
3734
9e49252b
EZ
37352011-12-03 Eli Zaretskii <eliz@gnu.org>
3736
3737 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3738 before a newline, prepare the bidi iterator for consuming the
3739 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3740 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3741
02b16839
JL
37422011-12-02 Juri Linkov <juri@jurta.org>
3743
3744 * search.c (Fword_search_regexp): New Lisp function created from
3745 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3746 (Fword_search_backward, Fword_search_forward)
3747 (Fword_search_backward_lax, Fword_search_forward_lax):
3748 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3749 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3750
0068070e
SM
37512011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3752
3753 * fileio.c (Finsert_file_contents): Move after-change-function call
3754 to before the "handled:" label, since all "goto handled" appear in
3755 cases where the *-change-functions have already been properly called
3756 (bug#10117).
3757
3360a3fc
AS
37582011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3759
3760 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3761 waiting for input. (Bug#10169)
3762
73d6c093
EZ
37632011-11-30 Eli Zaretskii <eliz@gnu.org>
3764
3765 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3766 verifies glyph row's hash code--we have just reallocated the
3767 glyphs, so their contents can be complete garbage. (Bug#10164)
3768
febe6bea
JB
37692011-11-30 Juanma Barranquero <lekktu@gmail.com>
3770
3771 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3772
801a4313
EZ
37732011-11-30 Eli Zaretskii <eliz@gnu.org>
3774
3775 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3776 attributes are tested _before_ calling verify_row_hash, to protect
3777 against GCC re-ordering of the tests. (Bug#10164)
3778
2b56b87e
JD
37792011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3780
3781 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3782
3783 * xterm.c (handle_one_xevent): Only set async_visible and friends
3784 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3785 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3786 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3787
dbf31225
PE
37882011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3789
3790 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3791 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3792 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3793 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3794 All uses changed to use GCPRO1 etc.
3795 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3796 Revert to old implementation (i.e., before 2011-03-11).
3797
1305621b
YM
37982011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3799
3800 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3801 of scroll runs so as to avoid assigning disabled bogus rows and
3802 unnecessary graphics copy operations.
3803
8c9afb46
EZ
38042011-11-27 Eli Zaretskii <eliz@gnu.org>
3805
3806 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3807 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3808 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3809 (malloc, free, realloc, calloc): Redirect to e_* only when
3810 compiling Emacs.
3811
3812 * lisp.h (GCTYPEBITS): Move before first use.
3813 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3814 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3815 this macro definition.
3816
3817 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3818 _MSC_VER.
3819
54e9e3bf
JD
38202011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3821
6d5eb5b0
SM
3822 * gtkutil.c (xg_create_frame_widgets):
3823 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3824 present with Gtk+ 2.0.
3825
83aca1cb
PE
38262011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3827
3828 * fileio.c (Finsert_file_contents): Undo previous change; see
3829 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3830
5b76caa4
PE
38312011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3832
3833 Rename locals to avoid shadowing.
3834 * fileio.c (Finsert_file_contents):
3835 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3836 * process.c (wait_reading_process_output):
3837 Rename inner 'proc' to 'p' to avoid shadowing.
3838 Indent for consistency with usual Emacs style.
3839
8c535114
EZ
38402011-11-25 Eli Zaretskii <eliz@gnu.org>
3841
3842 * xdisp.c (redisplay_window): If cursor row is not fully visible
3843 after recentering, and scroll-conservatively is set to a large
3844 number, scroll window by a few more lines to make the cursor fully
3845 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3846 (start_display): Don't move to the next line if the display should
3847 start at a newline that is part of a display vector or an overlay
3848 string. (Bug#10119)
8c535114 3849
fa4fdb5c
JL
38502011-11-24 Juri Linkov <juri@jurta.org>
3851
3852 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3853 after the `MagickPingImage' call. (Bug#10112)
3854
90ec88df
CY
38552011-11-23 Chong Yidong <cyd@gnu.org>
3856
3857 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3858
56e2e794
MR
38592011-11-23 Martin Rudalics <rudalics@gmx.at>
3860
3861 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3862 making another buffer current. (Bug#10114)
3863
b6e64c41
GM
38642011-11-23 Glenn Morris <rgm@gnu.org>
3865
3866 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3867
6b21de18
CY
38682011-11-23 Chong Yidong <cyd@gnu.org>
3869
3870 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3871 using it (Bug#5984).
3872
b12cd789
EZ
38732011-11-22 Eli Zaretskii <eliz@gnu.org>
3874
3875 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3876 and header-lines, as they don't have one computed for them.
3877 (Bug#10098)
3878
3879 * .gdbinit (prow): Make displayed values more self-explaining.
3880 Add row's hash code.
3881
261b6fd4
LMI
38822011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3883
3884 * process.c (wait_reading_process_output): Fix asynchrounous
3885 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3886 (wait_reading_process_output): Add comment and URL.
261b6fd4 3887
e7cfd277
JD
38882011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3889
3890 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3891
a9b9b7f5
CY
38922011-11-21 Chong Yidong <cyd@gnu.org>
3893
3894 * window.c (Fnext_window, Fprevious_window): Doc fix.
3895
b0d15b4f
SM
38962011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3897
3898 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3899
fe7a3057
JB
39002011-11-20 Juanma Barranquero <lekktu@gmail.com>
3901
3902 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3903
d2999b1a
MR
39042011-11-20 Martin Rudalics <rudalics@gmx.at>
3905
3906 * window.c (Fset_window_combination_limit): Rename argument
3907 STATUS to LIMIT.
3908 (Vwindow_combination_limit): Remove "status" from doc-string.
3909
d5ff9cd0
AS
39102011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3911
3912 * m/ibms390.h: Remove.
3913 * m/ibms390x.h: Don't include "ibms390.h".
3914
a5bb9bd3
SM
39152011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3916
3917 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3918 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3919
cd1181db
JB
39202011-11-20 Juanma Barranquero <lekktu@gmail.com>
3921
3922 * casetab.c (Fset_case_table):
3923 * charset.c (Fcharset_after): Fix typos.
3924
615a3b8d 39252011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3926
17e845af
PE
3927 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3928 Otherwise, valgrind does not work on some platforms.
3929 Problem reported by Andreas Schwab in
6a0bf43d
PE
3930 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3931 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3932 is set, removing the need for VIRT_ADDRESS_VARIES.
3933 (PURE_P): Use a more-efficient implementation that needs just one
3934 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3935 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3936 to 4 (xorl, subq, cmpq, setbe).
3937 * alloc.c (pure): Always extern now, since that's the
3938 VIRT_ADDR_VARIES behavior.
3939 (PURE_POINTER_P): Use a single comparison, not two, for
3940 consistency with the new puresize.h.
3941 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3942 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3943 Remove VIRT_ADDR_VARIES no longer needed.
3944
f8fe6f96
EZ
39452011-11-19 Eli Zaretskii <eliz@gnu.org>
3946
3947 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3948 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3949 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3950 behave as if the cursor position were at the window margin.
3951
3952 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3953 and the cursor position is out of bounds, behave as if the cursor
3954 position were at the window margin. (Bug#10075)
3955
df05a53c
CY
39562011-11-18 Chong Yidong <cyd@gnu.org>
3957
3958 * window.c (Fwindow_combination_limit): Make first argument
3959 non-optional, since it is meaningless for live windows like the
3960 selected window.
61ccba97 3961
2071918e
DA
39622011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3963
3964 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3965
b50a28de
SM
39662011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3967
3968 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3969 (graft_intervals_into_buffer): Simplify.
3970
015137db
EZ
39712011-11-18 Eli Zaretskii <eliz@gnu.org>
3972
3973 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3974 hash values of the two rows.
3975 (copy_row_except_pointers): Preserve the used[] arrays and the
3976 hash values of the two rows. (Bug#10035)
68c95424 3977 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3978
3979 * xdisp.c (row_hash): New function, body extracted from
3980 compute_line_metrics.
3981 (compute_line_metrics): Call row_hash, instead of computing the
3982 hash code inline.
3983
3984 * dispnew.c (verify_row_hash): Call row_hash for computing the
3985 hash code of a row, instead of duplicating code from xdisp.c.
3986
3987 * dispextern.h (row_hash): Add prototype.
3988
a2addb04
TH
39892011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3990
3991 * frame.c (delete_frame): Don't delete the terminal when the last
3992 X frame is closed if emacs is built with GTK toolkit.
3993
df85d315
JB
39942011-11-17 Juanma Barranquero <lekktu@gmail.com>
3995
3996 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3997
a0c2d0ae
MR
39982011-11-17 Martin Rudalics <rudalics@gmx.at>
3999
4000 * window.c (Vwindow_splits): Rename to
4001 Vwindow_combination_resize. Suggested by Juri Linkov.
4002 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4003 of Vwindow_splits.
4004
58179cce
JB
40052011-11-16 Juanma Barranquero <lekktu@gmail.com>
4006
7877f373
JB
4007 * nsfns.m (Fns_font_name):
4008 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4009
b6f67890
MR
40102011-11-16 Martin Rudalics <rudalics@gmx.at>
4011
4012 * window.h (window): Rename slot "nest" to "combination_limit".
4013 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4014 (Fset_window_nest): Rename to Fset_window_combination_limit.
4015 (Vwindow_nest): Rename to Vwindow_combination_limit.
4016 (recombine_windows, make_parent_window, make_window)
4017 (Fsplit_window_internal, saved_window)
4018 (Fset_window_configuration, save_window_save): Rename all
4019 occurrences of window_nest to window_combination_limit.
4020
c7015153
JB
40212011-11-15 Juanma Barranquero <lekktu@gmail.com>
4022
4023 * image.c (imagemagick_load_image): Fix typo.
4024
322ad6ec
EZ
40252011-11-14 Eli Zaretskii <eliz@gnu.org>
4026
4027 * xdisp.c (display_line): Move the call to
4028 highlight_trailing_whitespace before the call to
4029 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4030 faces of all the glyphs to compute ROW's hash value.
4031 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4032
f067b8ec
JB
40332011-11-14 Juanma Barranquero <lekktu@gmail.com>
4034
4035 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4036 just return (bug#10044).
4037
1e5b2111
EZ
40382011-11-12 Eli Zaretskii <eliz@gnu.org>
4039
7ef3cbd5
EZ
4040 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4041 with user-defined heap size. Bump the default size of the temacs
4042 heap to 27MB, to avoid memory warning when running temacs.
4043 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4044
1e5b2111
EZ
4045 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4046 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4047 (verify_row_hash) [XASSERTS]: New function.
4048 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4049 that the hash value of glyph rows is correct.
1e5b2111 4050
89d61221
MR
40512011-11-12 Martin Rudalics <rudalics@gmx.at>
4052
4053 * window.h (window): Remove splits slot.
4054 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4055 (Fdelete_other_windows_internal, make_parent_window)
4056 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4057 (Fset_window_configuration, save_window_save): Don't deal with
4058 split status of windows.
4059 (saved_window): Remove splits slot.
4060 (Vwindow_splits): Rewrite doc-string.
4061
97f18cc8
JD
40622011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4063
4064 * xfns.c (unwind_create_frame):
4065 * nsfns.m (unwind_create_frame):
4066 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4067 Vframe_list (Bug#9999).
4068
22a648b4
DA
40692011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4070
0b381c7e 4071 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4072
659afede
KH
40732011-11-11 Kenichi Handa <handa@m17n.org>
4074
4075 * callproc.c (Fcall_process): Set the member dst_multibyte of
4076 process_coding.
4077
9ac0394b
KH
40782011-11-11 Johan Bockgård <bojohan@gnu.org>
4079
4080 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4081 avoid a crash (bug#9496).
4082
2fbdc249
CY
40832011-11-09 Chong Yidong <cyd@gnu.org>
4084
4085 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4086 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4087
ac6b1f81
PE
40882011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4089
4090 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4091
09db192c
PE
40922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4093
4094 Avoid some portability problems by eschewing 'extern inline' functions.
4095 The trivial performance wins aren't worth the portability hassles; see
4096 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4097 et seq.
4098 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4099 (window_box_width, window_box_left, window_box_left_offset)
4100 (window_box_right, window_box_right_offset): Undo previous change,
4101 by removing the "extern"s.
4102 * intervals.c (adjust_intervals_for_insertion)
4103 (adjust_intervals_for_deletion): Undo previous change,
4104 making these static again.
4105 (offset_intervals, temp_set_point_both, temp_set_point)
4106 (copy_intervals_to_string): No longer inline.
4107 * xdisp.c (window_text_bottom_y, window_box_width)
4108 (window_box_height, window_box_left_offset)
4109 (window_box_right_offset, window_box_left, window_box_right)
4110 (window_box): No longer inline.
4111
105216ed
CY
41122011-11-08 Chong Yidong <cyd@gnu.org>
4113
4114 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4115 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4116 Signal an error if not a live window.
105216ed
CY
4117 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4118 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4119
ae9e237f
JB
41202011-11-07 Juanma Barranquero <lekktu@gmail.com>
4121
4122 * lisp.h (syms_of_abbrev): Remove declaration.
4123 Reported by CHENG Gao <chenggao@royau.me>.
4124
c7aa8333
EZ
41252011-11-07 Eli Zaretskii <eliz@gnu.org>
4126
4127 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4128 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4129 of temacs in GUI mode.
4130
be7f5545
MR
41312011-11-07 Martin Rudalics <rudalics@gmx.at>
4132
4133 * window.h: Declare delete_all_child_windows instead of
4134 delete_all_subwindows.
4135 * window.c (Fwindow_nest, Fset_window_nest)
4136 (Fset_window_new_total, Fset_window_new_normal)
4137 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4138 (delete_all_subwindows): Rename to delete_all_child_windows.
4139 (Fdelete_other_windows_internal, Fset_window_configuration):
4140 Call delete_all_child_windows instead of delete_all_subwindows.
4141 * frame.c (delete_frame): Call delete_all_child_windows instead
4142 of delete_all_subwindows.
4143
ca78dc43
PE
41442011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4145
4146 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4147 This is also needed for porting to any host where GC_MARK_STACK is
4148 not GC_MAKE_GCPROS_NOOPS.
4149 (which_symbols): Use it.
4150
a0241d01
KH
41512011-11-07 Kenichi Handa <handa@m17n.org>
4152
4153 * coding.c (coding_set_destination): Check coding->src_pos only
4154 when coding->src_object is a buffer (bug#9910).
4155
4156 * process.c (send_process): Set the member src_multibyte of coding
4157 to 0 (bug#9911) when sending a unibyte text.
4158
4159 * callproc.c (Fcall_process): Set the member src_multibyte of
4160 process_coding to 0 (bug#9912).
4161
a64bfdfa 41622011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4163
4164 * xmenu.c (cleanup_widget_value_tree): New function.
4165 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4166 calling free_menubar_widget_value_tree directly (Bug#9830).
4167
cb41b32a
PE
41682011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 Fix some portability problems with 'inline'.
4171 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4172 (window_box_width, window_box_left, window_box_left_offset)
4173 (window_box_right, window_box_right_offset): Declare extern.
4174 Otherwise, these inline functions do not conform to C99 and
4175 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4176 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4177 * intervals.c (adjust_intervals_for_insertion)
4178 (adjust_intervals_for_deletion): Now extern, because otherwise the
4179 extern inline functions 'offset_intervals' couldn't refer to it.
4180 (static_offset_intervals): Remove.
4181 (offset_intervals): Rewrite using the old contents of
4182 static_offset_intervals. The old version didn't conform to C99
4183 because an extern inline function contained a reference to an
4184 identifier with static linkage.
4185
b7041366
AS
41862011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4187
4188 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4189 GC.
4190
88a37c4d
EZ
41912011-11-06 Eli Zaretskii <eliz@gnu.org>
4192
4193 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4194 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4195 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4196 return Qleft_to_right.
4197
49745b39
CY
41982011-11-06 Chong Yidong <cyd@gnu.org>
4199
4200 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4201 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4202 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4203 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4204 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4205 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4206 (Fwindow_vscroll): Doc fix.
4207 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4208 argument, since it makes no sense to pass a live window and for
4209 consistency with window-child.
4210
1f05cd82
CS
42112011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4212
4213 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4214 support MSVC.
4215
22610910
JR
42162011-11-05 Jason Rumney <jasonr@gnu.org>
4217
4218 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4219 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4220 fonts (Bug#6029).
4221 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4222 bitwise arithmetic preventing use of unicode-sip and non-truetype
4223 opentype fonts.
4224
a06776b2
EZ
42252011-11-05 Eli Zaretskii <eliz@gnu.org>
4226
3ad924ba
EZ
4227 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4228 "emacs"-only part.
4229
a06776b2
EZ
4230 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4231 initialization code to keep similarity to xfns.c after changes
4232 from 2011-11-05.
4233
c9e7db78
JD
42342011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4235
a97f8f3f
JD
4236 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4237 (unwind_create_frame): New function (Bug#9943).
4238 (Fx_create_frame): Restructure code to be more similar to the one in
4239 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4240 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4241 Move terminal->reference_count++ just before making the frame official
4242 (Bug#9943).
4243
4244 * nsterm.m (x_free_frame_resources): New function.
4245 (x_destroy_window): Move code to x_free_frame_resources.
4246
c9e7db78 4247 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4248 (Fx_create_frame, x_create_tip_frame):
4249 Move terminal->reference_count++ just before making the frame
75f1671a 4250 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4251 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4252
a6fc3b5c
EZ
42532011-11-05 Eli Zaretskii <eliz@gnu.org>
4254
4255 Support MSVC build with newer versions of Visual Studio.
4256 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
4257 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
4258 nt/gmake.defs.
4259
4260 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
4261 which are not supported by MSVC.
4262 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
4263 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
4264 bitfields.
4265 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
4266 types in bitfields.
4267 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
4268
4269 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
4270
58179cce 42712011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
4272
4273 Support MSVC build with newer versions of Visual Studio.
4274 * w32.c: Don't include w32api.h for MSVC.
4275 (init_environment) [_MSC_VER]: Call sys_access, not _access.
4276
4277 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
4278 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
4279 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
4280 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
4281 e_* cousins.
4282 (alloca) [_MSC_VER]: Define to _alloca.
4283
4284 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
4285
4286 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
4287
a58c13ed
EZ
42882011-11-04 Eli Zaretskii <eliz@gnu.org>
4289
4290 * xdisp.c (note_mouse_highlight): If either of
4291 previous/next-single-property-change returns nil, treat that as
4292 the beginning or the end of the buffer. (Bug#9955)
4293
fe0b6370
JD
42942011-11-04 Jan Djärv <jan.h.d@swipnet.se>
4295
a58c13ed 4296 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
4297 label is not null (Bug#9951).
4298 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
4299 may be NULL.
4300
89bd5ee1
EZ
43012011-11-04 Eli Zaretskii <eliz@gnu.org>
4302
4303 * window.c (Fwindow_body_size): Mention in the doc string that the
4304 return value is in frame's canonical units. (Bug#9949)
4305
84c3edb9
EZ
43062011-11-03 Eli Zaretskii <eliz@gnu.org>
4307
4e2fb5c7
EZ
4308 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
4309
84c3edb9 4310 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 4311 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 4312 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 4313
bc17a887
EZ
43142011-11-01 Eli Zaretskii <eliz@gnu.org>
4315
4316 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
4317 Don't stop backward scan on the continuation glyph, even though
4318 its CHARPOS is positive.
6d5eb5b0
SM
4319 (mouse_face_from_buffer_pos, note_mouse_highlight):
4320 Rename cover_string to disp_string.
bc17a887 4321
4ee88440
MR
43222011-11-01 Martin Rudalics <rudalics@gmx.at>
4323
4324 * window.c (temp_output_buffer_show): Don't use
4325 Vtemp_buffer_show_specifiers.
4326 (Vtemp_buffer_show_specifiers): Remove unused variable.
4327
c2ff3c02
EZ
43282011-10-30 Eli Zaretskii <eliz@gnu.org>
4329
4330 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
4331 past the beginning of the current glyph matrix.
4332
58179cce 43332011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
4334
4335 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
4336 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
4337 HAVE_GTK3 (Bug#9869).
b77a6a7f 4338
3b574623
JD
4339 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
4340 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
4341
b77a6a7f
JD
4342 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
4343
4344 * xterm.c: Declare x_handle_net_wm_state to return int.
4345 (handle_one_xevent): Check if we are iconified but don't have
4346 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
4347 (get_current_wm_state): Return non-zero if not hidden,
4348 check for _NET_WM_STATE_HIDDEN (Bug#9893).
4349 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
4350 (x_handle_net_wm_state): Return what get_current_wm_state returns.
4351 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
4352
196e41e4
PE
43532011-10-29 Paul Eggert <eggert@cs.ucla.edu>
4354
4355 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
4356 so that this new function doesn't get optimized away by a
4357 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
4358
021f2e1a
AS
43592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4360
4361 * frame.h (MOUSE_HL_INFO): Remove excess parens.
4362
8b058d44
EZ
43632011-10-29 Eli Zaretskii <eliz@gnu.org>
4364
4365 Fix the `xbytecode' command.
4366 * .gdbinit (xprintbytestr): New command.
b50a28de 4367 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
4368 (xbytecode): Print the byte-code string as well.
4369
4452fb80
EZ
43702011-10-29 Kim Storm <storm@cua.dk>
4371
8b058d44
EZ
4372 * alloc.c (which_symbols): New function.
4373
21b72067
AS
43742011-10-29 Andreas Schwab <schwab@linux-m68k.org>
4375
4376 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
4377 line. (Bug#9903)
4378
83ed7b5c
GM
43792011-10-29 Glenn Morris <rgm@gnu.org>
4380
4381 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
4382 Not clear what it was for, and it causes various bugs. (Bug#9839)
4383
5a7a728b
EZ
43842011-10-28 Eli Zaretskii <eliz@gnu.org>
4385
4386 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
4387 possible random value that matches one of those tested as
4388 condition to clear the mouse face.
4389
d3d0842f
CY
43902011-10-28 Chong Yidong <cyd@gnu.org>
4391
4392 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
4393
31b39d13
DN
43942011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
4395
4396 * window.c (make_window): Initialize phys_cursor_on_p.
4397
9aba6043
SM
43982011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
4399
4400 * lisp.h (struct Lisp_Symbol): Update comments.
4401
c20992f4
JB
44022011-10-28 Juanma Barranquero <lekktu@gmail.com>
4403
4404 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
4405
db4f02f2
EZ
44062011-10-28 Eli Zaretskii <eliz@gnu.org>
4407
4408 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
4409 <oslsachem@gmail.com> for helping to debug this.
4410
4411 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
4412 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
4413 (g_b_init_get_glyph_outline_w): New static variables.
4414 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
4415 (GetGlyphOutlineW_Proc): New typedefs.
4416 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
4417 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
4418 New functions.
4419 (w32font_open_internal, compute_metrics):
4420 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
4421 instead of calling the "wide" APIs directly.
4422
4423 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
4424
4425 * w32.h (syms_of_w32font): Add prototype.
4426
87e68db4
JB
44272011-10-27 Juanma Barranquero <lekktu@gmail.com>
4428
4429 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
4430 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
4431 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
4432 (Fmove_to_window_line): Doc fix.
4433
435c1d67
CY
44342011-10-27 Chong Yidong <cyd@gnu.org>
4435
4436 * process.c (make_process): Set gnutls_state to NULL.
4437
4438 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
4439 non-NULL, regardless of GNUTLS_INITSTAGE.
4440 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
4441 an error. Set process slots as soon as we allocate them.
4442
4443 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
4444
9c6c6f49
CY
44452011-10-27 Chong Yidong <cyd@gnu.org>
4446
9aba6043
SM
4447 * gnutls.c (emacs_gnutls_deinit): New function.
4448 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
4449 (Fgnutls_deinit, Fgnutls_boot): Use it.
4450
4451 * process.c (make_process): Initialize GnuTLS credentials to NULL.
4452 (deactivate_process): Call emacs_gnutls_deinit.
4453
657d08d3
JB
44542011-10-27 Juanma Barranquero <lekktu@gmail.com>
4455
4456 * image.c (x_create_x_image_and_pixmap):
4457 * w32.c (sys_rename, w32_delayed_load):
4458 * w32font.c (fill_in_logfont):
4459 * w32reg.c (x_get_string_resource): Silence compiler warnings.
4460
5430d399
JB
44612011-10-26 Juanma Barranquero <lekktu@gmail.com>
4462
4463 * w32fns.c (w32_default_color_map): New function,
4464 extracted from Fw32_default_color_map.
a7ef684b 4465 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 4466
fe0055fa
PE
44672011-10-25 Paul Eggert <eggert@cs.ucla.edu>
4468
4469 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
4470
e6346438
SM
44712011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
4472
4473 * keyboard.c (test_undefined): New function (bug#9751).
4474 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
4475
e112cc37
ET
44762011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
4477
4478 * sysdep.c (init_sys_modes): Fix the check for the controlling
4479 terminal (Bug#6649).
4480
7b5d6677
EZ
44812011-10-20 Eli Zaretskii <eliz@gnu.org>
4482
4483 * dispextern.h (struct bidi_it): New member next_en_type.
4484
4485 * bidi.c (bidi_line_init): Initialize the next_en_type member.
4486 (bidi_resolve_explicit_1): When next_en_pos is valid for the
4487 current character, check also for next_en_type being WEAK_EN.
4488 (bidi_resolve_weak): Don't enter the expensive loop if the current
4489 position is before next_en_pos. Record the bidi type of the first
4490 non-ET, non-BN character we find, in addition to its position.
4491 (bidi_level_of_next_char): Invalidate next_en_type when
4492 next_en_pos is over-stepped.
4493
7da0b018
PE
44942011-10-20 Paul Eggert <eggert@cs.ucla.edu>
4495
4496 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
4497 * editfns.c: Rewrite current-time-zone so that it invokes
4498 the equivalent of (format-time-string "%Z") to get the time zone name.
4499 This fixes a bug when the time zone name contains characters that
4500 need converting from the system time locale to Emacs internal format.
4501 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
4502 that patch fixed format-time-string to do the conversion, but
4503 I forgot to fix current-time-zone.
4504 (format_time_string): New function, containing most of
4505 what Fformat_time_string used to contain.
4506 (Fformat_time_string): Rewrite in terms of format_time_string.
4507 This doesn't change this function's behavior.
4508 (current-time-zone): Rewrite to use format_time_string.
4509 This fixes the bug reported by Michael Schierl in
4510 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
4511 Jason Rumney's 2007-06-07 change worked around this bug, but
4512 didn't fix it.
4513 * systime.h (tzname, timezone): Remove no-longer-used declarations.
4514
8547b010
EZ
45152011-10-19 Eli Zaretskii <eliz@gnu.org>
4516
4517 * xdisp.c (start_display): If the character at POS is displayed
4518 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
4519 (try_window_reusing_current_matrix): If a line ends in a display
4520 vector or the next line starts in a display vector, continue
4521 redrawing the window even though the character position of
4522 start_row was reached.
8547b010
EZ
4523 (Bug#9771, part 2)
4524
4e948d15
CY
45252011-10-18 Chong Yidong <cyd@gnu.org>
4526
4527 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
4528 with nobreak-char-display too.
4529
4787455f
EZ
45302011-10-18 Eli Zaretskii <eliz@gnu.org>
4531
4532 Fix part 3 of bug#9771.
4533 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
4534 (bidi_resolve_neutral): Don't enter the expensive loop looking for
4535 non-neutral characters if the current character is a paragraph
4536 separator (a.k.a. Newline). This avoids running the same
4537 expensive loop twice, once when we consume the preceding newline
4538 and the other time when the line actually needs to be displayed.
4539 Avoid the loop when we see neutrals on the base embedding level
4540 following a character whose directionality is the same as the
4541 paragraph's. This avoids running the expensive loop when a line
4542 ends in a long sequence of neutrals, like control characters.
4543 Add assertion against STRONG_AL type. Slightly rearrange code
4544 that determines the type of a neutral given the first non-neutral
4545 that follows it.
4546 (bidi_level_of_next_char): Set next_en_pos to zero when
4547 invalidating its info.
4548
2c91f553
EZ
45492011-10-17 Eli Zaretskii <eliz@gnu.org>
4550
4551 * xdisp.c (push_display_prop): Determine whether to record string
4552 or buffer position by IT->string, not by IT->method. Allow
4553 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
4554 (move_it_vertically_backward): Don't look for character position
4555 immediately after the newline when in a continuation line.
4556 (Bug#9771, part 1)
2c91f553 4557
c7b08b0d
MR
45582011-10-15 Martin Rudalics <rudalics@gmx.at>
4559
4560 * window.c (coordinates_in_window): Rewrite and delabelize
4561 vertical border check. (Bug#5357) (Bug#9618)
4562
6b02f655
SM
45632011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
4564
4565 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
4566 errors in XSetWindowBorder (bug#9310).
4567
81d40c92
DA
45682011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
4569
4570 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
4571 avoid crash when xmalloc overrun checking is enabled.
4572
d4172c3b
EZ
45732011-10-13 Eli Zaretskii <eliz@gnu.org>
4574
4575 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
4576 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
4577 cursor motion with <left> and <right> arrow keys.
4578
4579 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
4580 some callers set that themselves.
4581
b00eea75
EZ
45822011-10-12 Eli Zaretskii <eliz@gnu.org>
4583
4584 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
4585 display string and the previous row comes from the same string and
4586 is empty. (Bug#9739) (Bug#9738)
4587
8fe012c4
SM
45882011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
4589
4590 * doc.c (get_doc_string): Encode file name (bug#9735).
4591
0074aef2
EZ
45922011-10-12 Eli Zaretskii <eliz@gnu.org>
4593
79beb178
EZ
4594 * bidi.c (bidi_level_of_next_char):
4595 * xdisp.c (get_visually_first_element): Remove old incorrect
4596 comments regarding the Unicode Line Separator character.
4597
0074aef2
EZ
4598 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
4599
6e4b3fbe
DA
46002011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
4601
4602 * alloc.c (Fgc_status): Do not access beyond zombies array
4603 boundary if nzombies > MAX_ZOMBIES.
4604 * alloc.c (dump_zombies): Add missing format specifier.
4605
0324f3af
PE
46062011-10-12 Paul Eggert <eggert@cs.ucla.edu>
4607
b5525cac
PE
4608 * xdisp.c (set_cursor_from_row): Simplify conditionals,
4609 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
4610
0324f3af
PE
4611 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
4612 Some packages use them to denote characters with modifiers.
4613
e9b5f888
AS
46142011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4615
4616 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4617 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4618 matching a pp-number. Rename parameter var to var1.
4619
127827c0
SM
46202011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4621
4622 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4623
c8fd3bd0
GM
46242011-10-08 Glenn Morris <rgm@gnu.org>
4625
4626 * callint.c (Fcall_interactively): Give a more explicit error for the
4627 'c' case with a non-character input. (Bug#8479)
4628
352ec8ff
EZ
46292011-10-08 Eli Zaretskii <eliz@gnu.org>
4630
03669ccb
EZ
4631 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4632 lines.
7061c986
EZ
4633 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4634 lines that are hscrolled on the left.
03669ccb 4635
352ec8ff
EZ
4636 * dispnew.c (buffer_posn_from_coords): Account for a possible
4637 presence of header-line. (Bug#4426)
4638
a66cfb1c
SM
46392011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4640
6b02f655
SM
4641 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4642 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4643
7c5ee88e
PE
46442011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4645
4646 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4647 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4648 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4649 this makes Emacs dump core during garbage collection on rare
4650 occasions. sizeof is obviously inferior to offsetof here, so
4651 stick with offsetof.
4652 (GC_POINTER_ALIGNMENT): New macro.
4653 (mark_memory): Omit 3rd (offset) arg; caller changed.
4654 Don't assume EMACS_INT alignment is the same as pointer alignment.
4655
df1bbe5b
SM
46562011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4657
4658 * keyboard.c (read_key_sequence_remapped): New var.
4659 (read_key_sequence): Compute remapping in the right buffer.
4660 (command_loop_1): Use read_key_sequence's remapping directly.
4661
51553db6
SM
46622011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4663
32c1fffd
SM
4664 * dired.c (file_name_completion): Don't expand file name.
4665 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4666 before checking file name handler.
4667
51553db6
SM
4668 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4669 they've been requested explicitly (bug#9591).
4670
b6bd1599 46712011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4672
4673 * keymap.c (Fsingle_key_description): Use make_specified_string
4674 instead of build_string to build string from push_key_description.
4675 (Bug#5193)
4676
f701dc2a
PE
46772011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4678
4222c55d
PE
4679 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4680 This fixes a Y2038 bug on 64-bit hosts.
4681 * buffer.c (reset_buffer):
4682 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4683 (Fclear_buffer_auto_save_failure):
4684 Use 0, not -1, to represent an unset failure time, since time_t
4685 might not be signed.
4686
f701dc2a
PE
4687 Remove dependency on glibc malloc internals.
4688 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4689 Move back here from lisp.h, but with their new implementations.
4690 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4691 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4692 * charset.c (charset_table_init): New static var.
4693 (syms_of_charset): Use it instead of xmalloc. This removes a
4694 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4695 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4696 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4697 Move back to alloc.c.
4698 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4699 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4700
9ceebf39
JD
47012011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4702
4703 * nsterm.m (windowDidResize): Call x_set_window_size only when
4704 ns_in_resize is true. Otherwise set pixelwidth/height and
4705 call change_frame_size (Bug#9628).
4706
cb993c58
PE
47072011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4708
3930c88b
PE
4709 Port --enable-checking=all to Fedora 14 x86-64.
4710 * charset.c (syms_of_charset): Also account for glibc malloc's
4711 internal overhead when calculating the initial malloc maximum.
4712
cb993c58
PE
4713 Port --enable-checking=all to Fedora 14 x86.
4714 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4715 Move to lisp.h.
4716 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4717 (overrun_check_realloc, overrun_check_free):
4718 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4719 That way, xmalloc returns a properly-aligned pointer even if
4720 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4721 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4722 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4723 into account when calculating the initial malloc maximum.
4724 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4725 Move here from alloc.c, so that charset.c can use it too.
4726 Properly align; the old code wasn't right for common 32-bit hosts
4727 when configured with --enable-checking=all.
4728 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4729 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4730
31bed486
EZ
47312011-09-29 Eli Zaretskii <eliz@gnu.org>
4732
04c70788 4733 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4734 use EDOM.
4735
fbcaa2f3
EZ
47362011-09-28 Eli Zaretskii <eliz@gnu.org>
4737
4738 * xdisp.c (compute_display_string_end): If there's no display
4739 string at CHARPOS, return -1.
4740
4741 * bidi.c (bidi_fetch_char): When compute_display_string_end
4742 returns a negative value, treat the character as a normal
4743 character not covered by a display string. (Bug#9624)
4744
a239d4e9
JB
47452011-09-28 Juanma Barranquero <lekktu@gmail.com>
4746
4747 * lread.c (Fread_from_string): Fix typo in docstring.
4748
88652fd5
EZ
47492011-09-27 Eli Zaretskii <eliz@gnu.org>
4750
4751 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4752 newline, reseat the iterator instead of bidi-iterating there one
4753 character at a time. (Bug#9610)
32c1fffd
SM
4754 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4755 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4756
ed497dd4
AS
47572011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4758
4759 * lread.c (readevalloop): Use correct code for NBSP.
4760 (read1): Likewise. (Bug#9608)
4761
b2bf61aa
MA
47622011-09-25 Michael Albinus <michael.albinus@gmx.de>
4763
4764 * dbusbind.c (Fdbus_register_signal): When service is not
4765 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4766
32bbb17c
GM
47672011-09-25 Glenn Morris <rgm@gnu.org>
4768
4769 * buffer.c (truncate-lines): Doc fix.
4770
94e0933e
CY
47712011-09-24 Chong Yidong <cyd@stupidchicken.com>
4772
4773 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4774 (Fset_window_next_buffers): Doc fix.
4775
cddde921
GM
47762011-09-24 Glenn Morris <rgm@gnu.org>
4777
4778 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4779
1260aef1
PE
47802011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4781
25b4bfa0
PE
4782 Fix minor problems found by static checking.
4783 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4784 * indent.c (Fvertical_motion): Fix == vs = typo.
4785
e3cbd34b
EZ
47862011-09-24 Eli Zaretskii <eliz@gnu.org>
4787
a66cfb1c
SM
4788 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4789 Default value is now t. Doc fix.
6bf7006f 4790
e3cbd34b 4791 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4792 logic when moving up, not only when moving down. Fix the
e3cbd34b 4793 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4794 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4795
4796 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4797 CHARPOS is covered by a display string which includes newlines.
4798 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4799 is covered by a display string with embedded newlines.
4800
a3de0cbd
MA
48012011-09-24 Michael Albinus <michael.albinus@gmx.de>
4802
4803 * dbusbind.c (Fdbus_register_signal): Add match rule to
4804 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4805 (Fdbus_register_method, Vdbus_registered_objects_table):
4806 Fix docstring.
a3de0cbd 4807
b260039d
JM
48082011-09-24 Jim Meyering <meyering@redhat.com>
4809
32c1fffd 4810 do not ignore write error for any output size
b260039d
JM
4811 The previous change was incomplete.
4812 While it makes emacs --batch detect the vast majority of stdout
4813 write failures, errors were still ignored whenever the output size is
4814 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4815 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4816 && echo FAIL: ignored write error
4817 FAIL: ignored write error
4818 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4819 && echo FAIL: ignored write error
4820 FAIL: ignored write error
4821 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4822
8eca8a7c
AS
48232011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4824
4825 * emacs.c (Fkill_emacs): In noninteractive mode exit
4826 non-successfully if a write error occurred on stdout. (Bug#9574)
4827
3341db62
EZ
48282011-09-21 Eli Zaretskii <eliz@gnu.org>
4829
4830 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4831 the xassert test.
4832
4833 * dispextern.h (struct it): Update the comment documenting what
4834 can it->OBJECT be.
4835
8c203dbf
EZ
48362011-09-20 Eli Zaretskii <eliz@gnu.org>
4837
4838 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4839 a display string, extend search for cursor position to end of row.
4840 (find_row_edges): If the row ends in a newline from a display
4841 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4842 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4843 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4844 non-empty line. Fixes confusing cursor motion with arrow keys at
4845 the beginning of a line that starts with whitespace.
8c203dbf 4846
a4824228
LMI
48472011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4848
4849 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4850 (bug#9493).
4851
33ed493b
CY
48522011-09-18 Chong Yidong <cyd@stupidchicken.com>
4853
4854 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4855 boolean (Bug#9154).
4856
56cd55c8
EZ
48572011-09-18 Eli Zaretskii <eliz@gnu.org>
4858
4859 * xdisp.c (display_line): Record maximum and minimum buffer
4860 positions even if no glyphs were produced (e.g., by a zero-width
4861 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4862 buffer positions that will be removed from the glyph row because
4863 they don't fit.
c02dcedf
EZ
4864 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4865 column is beyond frame width: don't subtract 1 "pixel" when
4866 computing width of the stretch.
3e62b7e0
EZ
4867 (reseat_at_next_visible_line_start): Undo the change made on
4868 2011-09-17 that saved paragraph information and restored it after
4869 the call to `reseat'. (Bug#9545)
56cd55c8 4870
5ed99d36 48712011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4872
4873 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4874 and turn window cursor on if cleared (Bug#9415).
4875
5ed99d36 48762011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4877
4878 * search.c (boyer_moore): Take unibyte characters from pattern
4879 literally. (Bug#9458)
4880
9bade7b2
EZ
48812011-09-18 Eli Zaretskii <eliz@gnu.org>
4882
4883 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4884
e5e9d610
PE
48852011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4886
87e4427a
PE
4887 Fix minor problem found by static checking.
4888 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4889 initialized, to pacify gcc -Wuninitialized.
4890
e5e9d610
PE
4891 * fileio.c: Report proper errno when syscall falls.
4892 (Finsert_file_contents): Save and restore errno,
4893 so that report_file_error outputs the correct diagnostic.
4894 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4895
a1674f0b
EZ
48962011-09-18 Eli Zaretskii <eliz@gnu.org>
4897
4898 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4899
fbfb6dd4
EZ
49002011-09-17 Eli Zaretskii <eliz@gnu.org>
4901
4902 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4903 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4904
bb187662
EZ
49052011-09-17 Eli Zaretskii <eliz@gnu.org>
4906
1137e8b8 4907 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4908 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4909
4910 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4911 (bidi_find_paragraph_start): Search back for paragraph beginning
4912 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4913 (bidi_move_to_visually_next): Only trigger paragraph-related
4914 computations when the last character is a newline or at EOB, not
4915 just any NEUTRAL_B. (Bug#9470)
4916
bb187662
EZ
4917 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4918 truncated lines if point is covered by a display string. (Bug#9524)
4919
2e621251
PE
49202011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4921
4922 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4923 (cons_to_x_long): New function.
4924 (lisp_data_to_selection_data): Use it. Correct the test for
4925 short-versus-long data; it was negated. Break out of vector
4926 loop, for efficiency, when a long datum is discovered.
4927
91a15bc6
SM
49282011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4929
4930 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4931
b41c3a35
EZ
49322011-09-16 Eli Zaretskii <eliz@gnu.org>
4933
4934 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4935 GCC PR/17406) by declaring this function with external scope.
4936
7812ba2d
PE
49372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4938
4939 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4940 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4941
cf7edc2a
AS
49422011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4943
4944 * editfns.c (Fformat): Correctly handle text properties on "%%".
4945
bd01620e
EZ
49462011-09-15 Eli Zaretskii <eliz@gnu.org>
4947
4948 * xterm.c (x_draw_composite_glyph_string_foreground):
4949 * w32term.c (x_draw_composite_glyph_string_foreground):
4950 * term.c (encode_terminal_code):
4951 * composite.c (composition_update_it, get_composition_id):
4952 * xdisp.c (get_next_display_element)
4953 (fill_composite_glyph_string): Add comments about special meaning
4954 of TAB characters in a composition.
4955
a02719a3
PE
49562011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4957
4958 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4959 This occurs when processing a multibyte format.
4960 Problem reported by Wolfgang Jenker.
a02719a3 4961
72589a3c
JB
49622011-09-15 Johan Bockgård <bojohan@gnu.org>
4963
4964 * xdisp.c (try_cursor_movement): Only check for exact match if
4965 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4966
1c14176c
PE
49672011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4968
4969 Remove unused external symbols.
4970 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4971 * xdisp.c (calc_pixel_width_or_height): Now static.
4972 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4973 * indent.c (check_display_width):
4974 * w32term.c: Fix comment to match code.
4975 * xterm.c, xterm.h (x_catching_errors): Remove.
4976
d2eea5b5
PE
49772011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 * xselect.c: Use signed conversions more consistently (Bug#9498).
4980 (selection_data_to_lisp_data): Assume incoming selection data are
4981 signed integers, not unsigned. This is to be consistent with
4982 outgoing selection data, which was modified to use signed integers
4983 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4984 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4985 expects long, not unsigned long.
4986
46888499
EZ
49872011-09-14 Eli Zaretskii <eliz@gnu.org>
4988
4989 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4990 computation of loop end. Reported by Johan Bockgård
4991 <bojohan@gnu.org>.
4992
ef8ef9fb
CY
49932011-09-13 Chong Yidong <cyd@stupidchicken.com>
4994
4995 * frame.c (Fother_visible_frames_p): Function deleted.
4996
fa819fed
EZ
49972011-09-12 Eli Zaretskii <eliz@gnu.org>
4998
4999 * indent.c (compute_motion): Process display vector front to back
5000 rather than the other way around. (Bug#2496)
5001
2ba8e008
SM
50022011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5003
5004 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5005
20f53c69
CY
50062011-09-11 Chong Yidong <cyd@stupidchicken.com>
5007
5008 * minibuf.c (Fread_from_minibuffer): Doc fix.
5009
d562d7a4
EZ
50102011-09-11 Eli Zaretskii <eliz@gnu.org>
5011
5012 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5013 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5014
1c4d7f3d
LMI
50152011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5016
5017 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5018 value for non-existent files.
5019
b885bf36
EZ
50202011-09-11 Eli Zaretskii <eliz@gnu.org>
5021
5022 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5023 set its "size" to -1. This will set the modtime_size field of
5024 the corresponding buffer to -1, which is what
5025 verify-visited-file-modtime expects for files that do not exist.
5026 (Bug#9139)
5027
6612f0bf
PE
50282011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5029
5030 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5031 here ...
5032 * lisp.h: ... from here. push_key_description is no longer
5033 defined in keyboard.c, so its declaration should not be in
5034 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5035 logically belongs with push_key_description.
5036
dfb3f755
PE
50372011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5038
5039 * buffer.h: Include <sys/types.h> instead of <time.h>.
5040 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5041 Problem reported by Herbert J. Skuhra.
5042
3134906c
LMI
50432011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5044
5045 * xml.c (parse_region): Make the parsing work for
5046 non-comment-starting XML files again (bug#9144).
5047
8d903f4e
AS
50482011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5049
5050 * image.c (gif_load): Fix calculation of bottom and right corner.
5051 (Bug#9468)
5052
80ad64f4
EZ
50532011-09-10 Eli Zaretskii <eliz@gnu.org>
5054
5055 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5056 redisplay in small windows.
5057
208a048d
EZ
50582011-09-09 Eli Zaretskii <eliz@gnu.org>
5059
5060 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5061
9b1c252e
MR
50622011-09-08 Martin Rudalics <rudalics@gmx.at>
5063
5064 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5065 Operate on live windows only.
5066
2949f33b
JB
50672011-09-08 Juanma Barranquero <lekktu@gmail.com>
5068
5069 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5070
e08dcafd
EZ
50712011-09-07 Eli Zaretskii <eliz@gnu.org>
5072
5073 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5074 only under bidi iteration.
5075
115b96bd
JD
50762011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5077
5078 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5079
c8199d0f
PE
50802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5081
5082 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5083 Without this fix, the command to link temacs failed due to an
5084 undefined symbol __builtin_isnan. This is because
5085 /usr/include/iso/math_c99.h #defines isnan(x) to
5086 __builtin_isnan(x), but the bundled gcc, which identifies itself
5087 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5088 a __builtin_isnan.
5089 * floatfns.c (isnan): #undef, and then #define to a clone of
5090 what's in data.c.
5091 (Fisnan): Always define, since it's always available now.
5092 (syms_of_floatfns): Always define isnan at the Lisp level.
5093
e39b275c 50942011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5095
5096 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5097
b2db44d9 50982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5099
f4af5137 5100 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5101 The previous code assumed that file offsets (off_t values) fit in
5102 EMACS_INT variables, which is not true on typical 32-bit hosts.
5103 The code messed up by falsely reporting buffer overflow in cases
5104 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5105 when "big" contains more than 2**29 bytes, even though this
5106 inserts just one byte and does not overflow the buffer.
5107 (Finsert_file_contents): Store file offsets as off_t
5108 values, not as EMACS_INT values. Check for overflow when
5109 converting between EMACS_INT and off_t. When checking for
5110 buffer overflow or for overlap, take the offsets into account.
5111 Don't use EMACS_INT for small values where int suffices.
5112 When checking for overlap, fix a typo: ZV was used where
5113 ZV_BYTE was intended.
5114 (Fwrite_region): Don't assume off_t fits into 'long'.
5115 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5116
ecfc0a49
MA
51172011-09-05 Michael Albinus <michael.albinus@gmx.de>
5118
5119 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5120
6511acf2 51212011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5122
0999621a 5123 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5124
5125 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5126 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5127 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5128 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5129 (modify_event_symbol): Do not assume that the length of
5130 name_alist_or_stem is safe to alloca and fits in int.
5131 (Fexecute_extended_command): Likewise for function name and binding.
5132 (Frecursion_depth): Wrap around reliably on integer overflow.
5133 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5134 since some callers pass EMACS_INT values.
5135 (Fsingle_key_description): Don't crash if symbol name contains more
5136 than MAX_ALLOCA bytes.
5137 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5138 (get_minibuffer): Arg is now EMACS_INT, not int.
5139 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5140 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5141 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5142
2be7d702
PE
5143 * dbusbind.c (signature_cat): New function.
5144 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5145 Do not overrun buffer; instead, report string overflow.
5146
9d1df220
PE
5147 * dispnew.c (add_window_display_history): Don't overrun buffer.
5148 Truncate instead; this is OK since it's just a log.
5149
33ef5c64
PE
5150 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5151 even if the time zone offset is outlandishly large.
5152 Don't mishandle offset == INT_MIN.
5153
66c6fdd5
PE
5154 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5155 when creating daemon; the previous buffer-overflow check was incorrect.
5156
d749b01b
PE
5157 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5158 which has the guts of the old verror function.
5159
b5cd1905
PE
5160 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5161 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5162
6e1a67fb
PE
5163 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5164 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5165 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5166 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5167 length of string rather than counting it via multiple sprintfs;
5168 that's simpler and more reliable.
c21721cc
PE
5169 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5170 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5171 sprintf, in case result does not fit in int.
5172
c57b67fc
PE
5173 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5174 (fontset_from_font): Print it.
5175
8a401434
PE
5176 * frame.c (tty_frame_count): Now printmax_t, not int.
5177 (make_terminal_frame, set_term_frame_name): Print it.
5178 (x_report_frame_params): In X, window IDs are unsigned long,
5179 not signed long, so print them as unsigned.
5180 (validate_x_resource_name): Check for implausibly long names,
5181 and don't assume name length fits in 'int'.
5182 (x_get_resource_string): Don't blindly alloca invocation name;
5183 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5184 not fit in int.
5185
6e1a67fb
PE
5186 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5187 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5188 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5189
0df02bf3
PE
5190 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5191 Use esprintf, not sprintf, in case result does not fit in int.
5192
48e30793
PE
5193 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5194 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5195 it as a large positive number.
5196 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5197 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5198
a66ff6d8
PE
5199 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5200 in case result does not fit in int.
5201
aca216ff
PE
5202 * print.c (float_to_string): Detect width overflow more reliably.
5203 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5204 buffer overrun. Don't assume list length fits in 'int'. Treat
5205 print length of 0 as 0, not as infinity; to be consistent with other
5206 uses of print length in this function. Don't overflow print length
5207 index. Don't assume hash table size fits in 'long', or that
5208 vectorlike size fits in 'unsigned long'.
5209
31c286f7
PE
5210 * process.c (make_process): Use printmax_t, not int, to format
5211 process-name gensyms.
5212
55e5faa1
PE
5213 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5214
80f2e268
PE
5215 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5216 to avoid potential buffer overrun.
5217
670741ab
PE
5218 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5219 if X resource line is longer than 512 bytes.
5220
b7163a50
PE
5221 * xfns.c (x_window): Make sprintf buffer a bit bigger
5222 to avoid potential buffer overrun.
5223
ae58ff1f
PE
5224 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5225
c43c8a6a
PE
5226 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5227
3f8236f4
PE
52282011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5229
53e9fe90 5230 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5231 Without these, Emacs silently mishandles large integers sometimes.
5232 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5233 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5234
6511acf2
PE
5235 * xdisp.c (try_window_id): Check Emacs fixnum range before
5236 converting to 'int'.
806add1d 5237
6511acf2 5238 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5239 Check that an Emacs fixnum is in range before assigning it to 'int'.
5240 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5241 values converted from Emacs fixnums.
5242 (Frecenter): Don't wrap around a line count if it is out of 'int'
5243 range; instead, treat it as an extreme value.
5244 (Fset_window_configuration, compare_window_configurations):
5245 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5246
6511acf2
PE
5247 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5248 that can exceed INT_MAX. Check that EMACS_INT value is in range
5249 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5250 (match_limit): Don't assume that a fixnum can fit in 'int'.
5251
6511acf2 5252 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5253 exceed INT_MAX.
5254
6511acf2 5255 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
5256 (Fvertical_motion): Don't wrap around LINES values that don't fit
5257 in 'int'. Instead, treat them as extreme values. This is good
5258 enough for windows, which can't have more than INT_MAX lines anyway.
5259
fcb901a7
LMI
52602011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
5261
0f2f6b6d
LMI
5262 * Require libxml/parser.h to avoid compilation warning.
5263
fcb901a7
LMI
5264 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
5265
5266 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
5267 since this reportedly can destroy thread storage.
5268
6e20a0d4
CY
52692011-08-30 Chong Yidong <cyd@stupidchicken.com>
5270
5271 * syntax.c (find_defun_start): Update all cache variables if
5272 exiting early (Bug#9401).
5273
148ae00e
EZ
52742011-08-30 Eli Zaretskii <eliz@gnu.org>
5275
f6cfbd8f
EZ
5276 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
5277
148ae00e
EZ
5278 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
5279 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
5280 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
5281
5282 * term.c (tty_append_glyph): New function.
5283 (produce_stretch_glyph): Static function and its prototype deleted.
5284
a66cfb1c
SM
5285 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
5286 Add prototypes.
148ae00e 5287
c4a07a4c
PE
52882011-08-29 Paul Eggert <eggert@cs.ucla.edu>
5289
5290 * image.c (parse_image_spec): Check for nonnegative, not for positive,
5291 when checking :margin (Bug#9390).
5292 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 5293 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
5294 so that the name doesn't mislead. All uses changed.
5295
6bc8cd65
JB
52962011-08-28 Johan Bockgård <bojohan@gnu.org>
5297
5298 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
5299 set_tty_hooks.
5300
dca4927e
EZ
53012011-08-27 Eli Zaretskii <eliz@gnu.org>
5302
5303 * xdisp.c (move_it_to): Don't bail out early when reaching
5304 position beyond to_charpos, if we are scanning backwards.
5305 (move_it_vertically_backward): When DY == 0, make sure we get to
5306 the first character in the line after the newline.
5307
f2cad773
PE
53082011-08-27 Paul Eggert <eggert@cs.ucla.edu>
5309
5310 * ccl.c: Improve and simplify overflow checking (Bug#9196).
5311 (ccl_driver): Do not generate an out-of-range pointer.
5312 (Fccl_execute_on_string): Remove unnecessary check for
5313 integer overflow, noted by Stefan Monnier in
5314 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
5315 Remove a FIXME that didn't need fixing.
5316 Simplify the newly-introduced buffer reallocation code.
5317
0cae2cdb
JB
53182011-08-27 Juanma Barranquero <lekktu@gmail.com>
5319
5320 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
5321
5fc295a4 53222011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 5323
70c60eb2 5324 Integer and memory overflow issues (Bug#9196).
726e0ab1 5325
d31850da
PE
5326 * doc.c (get_doc_string): Rework so that
5327 get_doc_string_buffer_size is the actual buffer size, rather than
5328 being 1 less than the actual buffer size; this makes xpalloc more
5329 convenient.
5330
a69fbedb
PE
5331 * image.c (x_allocate_bitmap_record, cache_image):
5332 * xselect.c (Fx_register_dnd_atom):
5333 Simplify previous changes by using xpalloc.
5334
fe5c5d37
PE
5335 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
5336 since either will do and ptrdiff_t is convenient with xpalloc.
5337
0065d054
PE
5338 * charset.c (charset_table_size)
5339 (struct charset_sort_data.priority): Now ptrdiff_t.
5340 (charset_compare): Don't overflow if priorities differ greatly.
5341 (Fsort_charsets): Don't assume list length fits in int.
5342 Check for size-calculation overflow when allocating sort data.
5343 (syms_of_charset): Allocate an initial charset table that is
5344 just under 64 KiB, to avoid problems with glibc malloc and mmap.
5345
5346 * cmds.c (internal_self_insert): Check for size-calculation overflow.
5347
5348 * composite.h (struct composition.glyph_len): Now int, not unsigned.
5349 The actual value is always <= INT_MAX, and leaving it unsigned made
5350 overflow checking harder.
5351
5352 * dispextern.h (struct glyph_matrix.rows_allocated)
5353 (struct face_cache.size): Now ptrdiff_t, for convenience in use
5354 with xpalloc. The values are still always <= INT_MAX.
5355
5356 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
5357
5358 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
5359 (SAFE_NALLOCA): New macro.
5360
5361 * region-cache.c (struct boundary.pos, find_cache_boundary)
5362 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
5363 (set_cache_region, invalidate_region_cache)
5364 (revalidate_region_cache, know_region_cache, region_cache_forward)
5365 (region_cache_backward, pp_cache):
5366 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
5367 so that ptrdiff_t * can be passed to xpalloc.
5368 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
5369 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
5370 (pp_cache): Don't assume cache_len fits in int.
5371 * region-cache.h: Adjust extern decls to match.
5372
5373 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
5374 EMACS_INT, since either will do, for xpalloc.
5375
5376 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
5377 (xnmalloc, xnrealloc, xpalloc): New functions.
5378
726e0ab1
PE
5379 * bidi.c (bidi_shelve_header_size): New constant.
5380 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
5381 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
5382
51f30bc5 5383 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
5384 * buffer.c (overlays_at, overlays_in, record_overlay_string)
5385 (overlay_strings):
5386 Don't update size of array until after memory allocation succeeds,
5387 because xmalloc/xrealloc may not return.
0065d054
PE
5388 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
5389 now that we have proper integer overflow checking.
5390 (record_overlay_string, overlay_strings): Catch overflows when
5391 calculating size of overlay_str_buf.
726e0ab1 5392
0065d054
PE
5393 * callproc.c (Fcall_process): Check for size overflow when
5394 calculating size of args2.
5395 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
5396 Normally we prefer signed values, but sticking with ptrdiff_t would
5397 require adding more-complicated checks.
726e0ab1
PE
5398
5399 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
5400 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
5401 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 5402 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
5403
5404 * character.c (Fstring): Check for size-calculation overflow.
5405
5406 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
5407 unnecessary integer overflow. Check for size overflow.
5408 (encode_coding_object): Don't update size until xmalloc succeeds.
5409
5410 * composite.c (get_composition_id): Check for overflow in glyph
5411 length calculations.
5412
5413 Integer and memory overflow fixes for display code.
5414 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
5415 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
5416 (scrolling_window): Check for overflow in size calculations.
5417 (line_draw_cost, realloc_glyph_pool, add_row_entry):
5418 Don't assume glyph table len fits in int.
5419 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
5420 (row_table_size): Now ptrdiff_t, not int.
5421 (scrolling_window): Avoid overflow in size calculations.
5422 Don't update size until allocation succeeds.
5423 * fns.c (concat): Check for overflow in size calculations.
5424 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
5425 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5426 (NEXT_ALMOST_PRIME_LIMIT): New constant.
5427
5428 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
5429 (get_doc_string): Check for size calculation overflow.
5430 Don't update size until allocation succeeds.
5431 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
5432 EMACS_INT, where ptrdiff_t will do.
5433 (Fsubstitute_command_keys): Check for string overflow.
5434
5435 * editfns.c (set_time_zone_rule): Don't assume environment length
5436 fits in int.
5437 (message_length): Now ptrdiff_t, not int.
5438 (Fmessage_box): Don't update size until allocation succeeds.
5439 Don't assume message length fits in int.
5440 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
5441
0065d054
PE
5442 * emacs.c (main): Do not reallocate argv, since there is a null at
5443 the end that can be overwritten, and this way there's no need to
5444 worry about size-calculation overflow.
5445 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
5446
5447 * eval.c (init_eval_once, grow_specpdl): Don't update size until
5448 alloc succeeds.
5449 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
5450
5451 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
5452 (x_set_scroll_bar_width, x_figure_window_size):
5453 Check for integer overflow.
5454 (x_set_alpha): Do not assume XINT fits in int.
5455
5456 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
5457 This is for the members text_lines, text_cols, total_lines, total_cols,
5458 where the system imposes an 'int' limit.
5459
5460 * fringe.c (Fdefine_fringe_bitmap):
5461 Don't update size until alloc works.
5462
5463 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
5464 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
5465
5466 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
5467 Check for size-calculation overflow.
5468 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
5469 do, as we prefer signed integers.
5470 (id_to_widget.max_size, id_to_widget.used)
5471 (xg_store_widget_in_map, xg_remove_widget_from_map)
5472 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
5473 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
5474 Use and return ptrdiff_t, not int.
5475 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
5476 * gtkutil.h: Change prototypes to match the above.
5477
5478 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
5479 are duplicate now that they've been promoted to lisp.h.
5480 (x_allocate_bitmap_record, x_alloc_image_color)
5481 (make_image_cache, cache_image, xpm_load):
5482 Don't update size until alloc is done.
5483 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
5484 (x_detect_edges):
3256efce 5485 Check for size calculation overflow.
726e0ab1
PE
5486 (ct_colors_allocated_max): New constant.
5487 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
5488 overflow.
3256efce 5489
726e0ab1
PE
5490 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
5491 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
5492 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
5493 Use ptrdiff_t, not int, to count maps.
5494 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
5495 calculations. Don't update size until allocation succeeds.
5496 Redo calculations to avoid overflow.
726e0ab1
PE
5497 * keyboard.h: Change prototypes to match the above.
5498
5499 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
5500 to count maps.
5501 (current_minor_maps): Check for size calculation overflow.
5502 * keymap.h: Change prototypes to match the above.
5503
5504 * lread.c (read1, init_obarray): Don't update size until alloc done.
5505
5506 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
5507 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
5508
726e0ab1
PE
5509 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
5510 Now ptrdiff_t, not int.
5511 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
5512 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
5513
5514 * process.c (Fnetwork_interface_list): Check for overflow
5515 in size calculation.
5516
5517 * region-cache.c (move_cache_gap): Check for size calculation overflow.
5518
5519 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
5520 overflow. Don't bother calling xmalloc when xrealloc will do.
5521
5522 * search.c (Freplace_match): Check for size calculation overflow.
5523 (Fset_match_data): Don't assume list lengths fit in 'int'.
5524
5525 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
5526 for command line length. Do not attempt to address one before the
5527 beginning of an array, as that's not portable.
5528
5529 * term.c (max_frame_lines): Remove; unused.
5530 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
5531 not int.
5532 (encode_terminal_code, calculate_costs): Check for size
5533 calculation overflow.
5534 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
5535 table lengths and related sizes. Don't update size until alloc
5536 done. Redo calculations to avoid overflow.
5537 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
5538
5539 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
5540 subtracting pointers.
5541 (gobble_line): Check for overflow more carefully. Don't update size
5542 until alloc done.
5543
5544 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
5545 Don't update size until alloc done.
5546 Redo size calculations to avoid overflow.
5547 Check for size calculation overflow.
0065d054 5548 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
5549
5550 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
5551 Use ptrdiff_t, not int, for sizes.
5552 (store_mode_line_noprop_char): Don't update size until alloc done.
5553
0065d054
PE
5554 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
5555 Use ptrdiff_t, not int, for sizes.
5556 (Finternal_make_lisp_face, cache_face):
5557 Check for size calculation overflow.
5558 (cache_face): Treat size calculation overflows as if they were
5559 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
5560
5561 * xfns.c (x_encode_text, x_set_name_internal)
5562 (Fx_change_window_property): Use ptrdiff_t, not int, to count
5563 sizes, since they can exceed INT_MAX in size. Check for size
5564 calculation overflow.
5565
0065d054
PE
5566 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
5567 (xg_select): Check for size calculation overflow.
726e0ab1
PE
5568 Don't update size until alloc done.
5569
0065d054 5570 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 5571 as sprintf is limited to int lengths.
1d526e2f 5572
252c5ee1
PE
5573 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
5574 (X_LONG_MIN): New macros.
864d7ce7
PE
5575 Use them to make the following changes clearer.
5576 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
5577 This change doesn't affect the value now, but it may help remind
5578 future maintainers not to raise the value too much later.
5579 (SELECTION_QUANTUM): Remove, replacing with ...
5580 (selection_quantum): ... new function, which avoids overflow.
5581 All uses changed.
5582 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
5583 assumption that selection length fits in 'int'.
5584 (x_reply_selection_request, x_handle_selection_request)
5585 (x_get_window_property, receive_incremental_selection)
5586 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
5587 (lisp_data_to_selection_data, clean_local_selection_data):
5588 Use ptrdiff_t, not int, to record length of selection.
5589 (x_reply_selection_request, x_get_window_property)
5590 (receive_incremental_selection, x_property_data_to_lisp):
5591 Redo calculations to avoid overflow.
5592 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 5593 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
5594 something.
5595 (x_get_window_property, receive_incremental_selection)
5596 (lisp_data_to_selection_data, x_property_data_to_lisp):
5597 Check for size-calculation overflow.
5598 (x_get_window_property, receive_incremental_selection)
5599 (lisp_data_to_selection_data, Fx_register_dnd_atom):
5600 Don't store size until memory allocation succeeds.
5601 (x_get_window_property): Plug memory leak on memory exhaustion.
5602 Don't double-block input; malloc is safe here. Don't assume 2**34
5603 - 4 fits in unsigned long. Add an xassert to check
5604 XGetWindowProperty overflow. Be more careful about overflow
5605 calculations, and distinguish size from memory overflow better.
5606 (receive_incremental_selection): When tracing, don't assume
5607 unsigned int is less than INT_MAX.
5608 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
5609 harmful) conversions of unsigned short to int.
5610 (lisp_data_to_selection_data): Don't assume that integers
5611 in the range -65535 through -1 fit in an X unsigned short.
5612 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
5613 result parameters unless successful. Rely on cons_to_unsigned
5614 to report problems with elements; the old code wasn't right anyway.
5615 (x_check_property_data): Check for int overflow; we cannot use
5616 a wider type due to X limits.
5617 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5618
726e0ab1 5619 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5620
0065d054
PE
5621 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5622 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5623 (x_color_cells): Don't store size until memory allocation succeeds.
5624 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5625 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5626 (x_term_init): Don't assume length fits in int (sprintf is limited
5627 to int size).
bc18e09d 5628
ebfa62c0
PE
5629 Use ptrdiff_t for composition IDs.
5630 * character.c (lisp_string_width):
5631 * composite.c (composition_table_size, n_compositions)
5632 (get_composition_id, composition_gstring_from_id):
5633 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5634 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5635 * window.c (Frecenter):
5636 Use ptrdiff_t, not int, for composition IDs.
5637 * composite.c (get_composition_id): Check for integer overflow.
5638 * composite.h: Adjust prototypes to match the above changes.
5639
d3411f89
PE
5640 Use ptrdiff_t for hash table indexes.
5641 * category.c (hash_get_category_set):
5642 * ccl.c (ccl_driver):
5643 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5644 * coding.c (coding_system_charset_list, detect_coding_system):
5645 * coding.h (struct coding_system.id):
5646 * composite.c (get_composition_id, gstring_lookup_cache):
5647 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5648 * image.c (xpm_get_color_table_h):
5649 * lisp.h (hash_lookup, hash_put):
5650 * minibuf.c (Ftest_completion):
5651 Use ptrdiff_t for hash table indexes, not int (which is too
5652 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5653 32-bit --with-wide-int hosts).
5654
e097a6fa
PE
5655 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5656 Add a FIXME comment about memory leaks.
5657 (syms_of_charset): Don't assume xmalloc returns.
5658
5637687f
PE
5659 Don't assume that stated character widths fit in int.
5660 * character.c (Fchar_width, c_string_width, lisp_string_width):
5661 * character.h (CHAR_WIDTH):
5662 * indent.c (MULTIBYTE_BYTES_WIDTH):
5663 Use sanitize_char_width to avoid undefined and/or bad behavior
5664 with outlandish widths.
a66cfb1c 5665 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5666 now that we have two such functions. All uses changed.
5667 (sanitize_char_width): New inline function.
5668
a2271ba2
PE
5669 Don't assume that tab-width fits in int.
5670 * character.h (sanitize_width): New inline function.
5671 (SANE_TAB_WIDTH): New macro.
5672 (ASCII_CHAR_WIDTH): Use it.
5673 * indent.c (sane_tab_width): Remove. All uses replaced by
5674 SANE_TAB_WIDTH (current_buffer).
5675 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5676
18c52557
PE
5677 * fileio.c: Integer overflow issues with file modes.
5678 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5679
caeeedc1
PE
5680 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5681 Remove unreachable code.
5682 (read_hex, load_charset_map_from_file): Check for integer overflow.
5683
6df6ae42 5684 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5685 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5686 (x_send_scroll_bar_event): Likewise. Check that the size does not
5687 exceed limits imposed by XClientMessageEvent, as well as the usual
5688 ptrdiff_t and size_t limits.
5689
b13995db
PE
5690 * keyboard.c: Overflow, signedness and related fixes.
5691 (make_lispy_movement): Use same integer type in forward decl
5692 that is used in the definition.
5693 (read_key_sequence, keyremap_step):
5694 Change bufsize argument back to int, undoing my 2011-03-30 change.
5695 We prefer signed types, and int is wide enough here.
5696 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5697 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5698 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5699 length, not size_t. Use ptrdiff_t for index, not int.
5700 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5701 possibility of integer overflow.
5702
13464394
PE
5703 Overflow, signedness and related fixes for images.
5704
5705 * dispextern.h (struct it.stack[0].u.image.image_id)
5706 (struct_it.image_id, struct image.id, struct image_cache.size)
5707 (struct image_cache.used, struct image_cache.ref_count):
5708 * gtkutil.c (update_frame_tool_bar):
5709 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5710 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5711 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5712 * nsmenu.m (update_frame_tool_bar):
5713 * xdisp.c (calc_pixel_width_or_height):
5714 * xfns.c (image_cache_refcount):
5715 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5716 on typical 64-bit hosts.
5717
5718 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5719 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5720 Omit unnecessary casts to int.
5721 (parse_image_spec): Check that integers fall into 'int' range
5722 when the callers expect that.
5723 (image_ascent): Redo ascent calculation to avoid int overflow.
5724 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5725 (lookup_image): Remove unnecessary tests.
5726 (xbm_image_p): Locals are now of int, not EMACS_INT,
5727 since parse_image_check makes sure they fit into int.
5728 (png_load, gif_load, svg_load_image):
5729 Prefer int to unsigned where either will do.
5730 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5731 old tiff_error_handler and tiff_warning_handler.
5732 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5733 stack buffer overflows. It uses only the features of vsnprintf
5734 that are common to both POSIX and native Microsoft.
5735 (tiff_error_handler, tiff_warning_handler): Use it.
5736 (tiff_load, gif_load, imagemagick_load_image):
5737 Don't assume :index value fits in 'int'.
5738 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5739 (imagemagick_load_image): Check that crop parameters fit into
5740 the integer types that MagickCropImage accepts. Don't assume
5741 Vimagemagick_render_type has a nonnegative value. Don't assume
5742 size_t fits in 'long'.
5743 (gs_load): Use printmax_t to print the widest integers possible.
5744 Check for integer overflow when computing image height and width.
5745
c11821d4
EZ
57462011-08-26 Eli Zaretskii <eliz@gnu.org>
5747
5748 * xdisp.c (redisplay_window): Don't force window start if point
5749 will be invisible in the resulting window. (Bug#9324)
5750
0c95fcf7
EZ
57512011-08-25 Eli Zaretskii <eliz@gnu.org>
5752
5753 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5754 the display spec is of the form `(space ...)'.
5755 (handle_display_spec): Return the value returned by
5756 handle_single_display_spec, not just 1 or zero.
5757 (handle_single_display_spec): If the display spec is of the form
5758 `(space ...)', and specifies display in the text area, return 2
5759 rather than 1.
fee65a97 5760 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5761 accurately, and prefer exact match for point under bidi.
5762 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5763
5764 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5765 into disp_prop; all users changed.
5766
5767 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5768 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5769 for the text covered by the display property.
5770
e4ed06f1
CY
57712011-08-25 Chong Yidong <cyd@stupidchicken.com>
5772
5773 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5774 Change return value to nil.
5775 (Frecord_buffer): Delete unused function.
5776
f67cdd7f
EZ
57772011-08-24 Eli Zaretskii <eliz@gnu.org>
5778
5980d4c6
EZ
5779 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5780 buffers, return left-to-right.
8610fe8b
EZ
5781 (set_cursor_from_row): Consider candidate row a win if its glyph
5782 represents a newline and point is on that newline. Fixes cursor
5783 positioning on the newline at EOL of R2L text within L2R
5784 paragraph, and vice versa.
5785 (try_cursor_movement): Check continued rows, in addition to
5786 continuation rows. Fixes unwarranted scroll when point enters a
5787 continued line of R2L text within an L2R paragraph, or vice versa.
5788 (cursor_row_p): Consider the case of point being equal to
5789 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5790 from the end of a short line to the beginning of a continued line
5791 of R2L text within L2R paragraph.
5792 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5793 composed characters.
5980d4c6 5794
f67cdd7f
EZ
5795 * bidi.c (bidi_check_type): Use xassert.
5796 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5797 members.
5798
bca633fb
EZ
57992011-08-23 Eli Zaretskii <eliz@gnu.org>
5800
5801 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5802 a character.
5803
4a5885a7
CY
58042011-08-23 Chong Yidong <cyd@stupidchicken.com>
5805
5806 * nsfont.m (ns_otf_to_script): Fix typo.
5807
0902a04e
KH
58082011-08-22 Kenichi Handa <handa@m17n.org>
5809
5810 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5811 extra slot even if the purpose is char-code-property-table.
5812
1a2e6670
EZ
58132011-08-23 Eli Zaretskii <eliz@gnu.org>
5814
8ddde651
EZ
5815 * xdisp.c (redisplay_window): When computing centering_position,
5816 account for the height of the header line. (Bug#8874)
5817
425cc014
EZ
5818 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5819 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5820 candidate is selected by the mouse, and that candidate has a
5821 composed character under the mouse.
5822
1a2e6670
EZ
5823 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5824 coordinates reported by pos-visible-in-window-p for a composed
5825 character in column zero.
5826
8b76d6f8
SM
58272011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5828
5829 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5830
dac347dd
EZ
58312011-08-22 Eli Zaretskii <eliz@gnu.org>
5832
5833 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5834 consider it a hit if to_charpos is anywhere in the range of the
5835 composed buffer positions.
5836
e013fb34
CY
58372011-08-22 Chong Yidong <cyd@stupidchicken.com>
5838
5839 * image.c (gif_load): Don't assume that each subimage has the same
5840 dimensions as the base image. Handle disposal method that is
5841 "undefined" by the gif spec (Bug#9335).
5842
bd1ba3e8
CY
58432011-08-20 Chong Yidong <cyd@stupidchicken.com>
5844
5845 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5846 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5847
54a1215b
EZ
58482011-08-19 Eli Zaretskii <eliz@gnu.org>
5849
823564e5
EZ
5850 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5851 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5852 from an Org mode buffer to a Speedbar frame.
5853
54a1215b
EZ
5854 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5855 a composition, take its buffer position from IT->cmp_it.charpos.
5856 Fixes cursor positioning at the beginning of a line that begins
5857 with a composed character.
5858
9778ebcc
EZ
58592011-08-18 Eli Zaretskii <eliz@gnu.org>
5860
0be6ee06
EZ
5861 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5862 character bidirectional type, use STRONG_L instead. Fixes crashes
5863 in a buffer produced by `describe-categories'.
5864
9778ebcc
EZ
5865 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5866 members before the level stack, so they would be saved and
5867 restored when copying iterator state. Fixes incorrect reordering
5868 around TABs covered by display properties.
5869
156bffbe
AS
58702011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5871
6b02f655 5872 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5873
72ad093b
CY
58742011-08-17 Chong Yidong <cyd@stupidchicken.com>
5875
5876 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5877 (internal_condition_case_2, internal_condition_case_n):
5878 Remove unnecessary aborts (Bug#9081).
72ad093b 5879
35774242
EZ
58802011-08-17 Eli Zaretskii <eliz@gnu.org>
5881
5882 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5883 has no `load' handler, try opening the file locally. (Bug#9311)
5884
db76dd85
KB
58852011-08-16 Ken Brown <kbrown@cornell.edu>
5886
5887 * gmalloc.c: Expand comment.
5888
b215eee5
EZ
58892011-08-16 Eli Zaretskii <eliz@gnu.org>
5890
5891 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5892 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5893
a4579d33
KB
58942011-08-16 Ken Brown <kbrown@cornell.edu>
5895
5896 Fix memory allocation problems in Cygwin build (Bug#9273).
5897
5898 * unexcw.c ( __malloc_initialized): Declare external variable.
5899 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5900
8b76d6f8
SM
5901 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5902 New variables.
a4579d33
KB
5903 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5904 dumped emacs.
5905 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5906 in the static heap.
5907 [CYGWIN] (special_realloc): New function.
5908 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5909 requests to realloc storage in the static heap.
5910
3ebec551
PE
59112011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5912
5913 * bidi.c (bidi_initialize): Remove unused local.
5914
9fd8be00
EZ
59152011-08-15 Eli Zaretskii <eliz@gnu.org>
5916
6b02f655
SM
5917 * bidimirror.h:
5918 * biditype.h: Remove file.
5919 * makefile.w32-in ($(BLD)/bidi.$(O)):
5920 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5921
5922 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5923
5924 * chartab.c: Improve commentary for the uniprop_table API.
5925
32413314
EZ
5926 * bidi.c (bidi_paragraph_init): Support zero value of
5927 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5928 (bidi_initialize): Use uniprop_table instead of including
5929 biditype.h and bidimirror.h.
32413314 5930
9fd8be00
EZ
5931 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5932 coordinates of the iterator when restoring from ppos_it.
5933 (Bug#9296)
5934
5cf2b69b
KH
59352011-08-14 Kenichi Handa <handa@m17n.org>
5936
5937 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5938 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5939
daf17d00
EZ
59402011-08-14 Eli Zaretskii <eliz@gnu.org>
5941
5942 * xdisp.c (move_it_in_display_line_to): Don't invoke
5943 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5944 ppos_it. Fixes vertical cursor motion when line beginning is
5945 covered by an image. (Bug#9296)
5946
08e3161a
JD
59472011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5948
5949 * nsterm.h (ns_run_ascript): Declare.
5950 (NSAPP_DATA2_RUNASSCRIPT): Define.
5951
5952 * nsfns.m (as_script, as_result, as_status): New static variables.
5953 (ns_run_ascript): New function.
5e617bc2 5954 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5955 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5956 the event loop. Get status from as_status (Bug#7276).
5957
5958 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5959 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5960 the event loop (Bug#7276).
5961
a3720aa2
AS
59622011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5963
5964 * gnutls.c (QCgnutls_bootprop_priority)
5965 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5966 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5967 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5968 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5969 (QCgnutls_bootprop_verify_hostname_error)
5970 (QCgnutls_bootprop_callbacks_verify): Rename from
5971 Qgnutls_bootprop_..., all uses changed.
5972
5973 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5974 uses changed.
5975
0a0d27fb
PE
59762011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5977
19d5c50c
PE
5978 * xfaces.c (Qframe_set_background_mode): Now static.
5979 * dispextern.h (Qframe_set_background_mode): Remove decl.
5980
0a0d27fb
PE
5981 * process.c (Fnetwork_interface_info): Declare local only if needed.
5982
377538cb
JD
59832011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5984
5985 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5986 (Fnetwork_interface_list): Allocate in increments of bytes instead
5987 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5988 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5989 sockaddr.
5990 (struct ifflag_def): notrailers is smart on OSX.
5991 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5992 Get hardware address with getifaddrs if available.
5993
08fff70c
EZ
59942011-08-12 Eli Zaretskii <eliz@gnu.org>
5995
5996 * xdisp.c (iterate_out_of_display_property): xassert that
5997 IT->position is set to within IT->object's boundaries. Break from
5998 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5999 when IT->position is set up wrongly due to some bug.
6000 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6001 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6002 entry. Force push_it to save on the stack the current
6003 buffer/string position, to be restored by pop_it. Fix flags in
6004 the iterator structure wrt the object coming from a display
6005 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6006 properties. (Bug#9284)
6007
7be1c708 60082011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6009
7be1c708
CY
6010 * fontset.c (fontset_get_font_group): Add proper type checks.
6011 (Bug#9172)
aac0c6e3 6012
7be1c708 60132011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6014
7be1c708
CY
6015 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6016 and LC_VERSION_MIN_MACOSX.
6017 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6018 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6019
97bb72a6
EZ
60202011-08-08 Eli Zaretskii <eliz@gnu.org>
6021
6022 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6023 no-display-properties-and-no-overlays under bidi display.
6024 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6025 properties and overlays.
97bb72a6 6026
d5617611
CY
60272011-08-08 Chong Yidong <cyd@stupidchicken.com>
6028
37e11a63
CY
6029 * editfns.c (Fset_time_zone_rule): Document relationship with the
6030 setenv function.
6031
d5617611
CY
6032 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6033 the font entity extracted from the cache (Bug#8109).
6034
58872834
CY
60352011-08-07 Chong Yidong <cyd@stupidchicken.com>
6036
6037 * composite.c (autocmp_chars): Don't reset point. That is done by
6038 restore_point_unwind (Bug#5984).
6039
75bfc667
JL
60402011-08-07 Juri Linkov <juri@jurta.org>
6041
6042 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6043 to show the arg `TIME' instead of `TIMEVAL'.
6044
d1410150
EZ
60452011-08-06 Eli Zaretskii <eliz@gnu.org>
6046
6047 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6048 display property strides EOL and includes a newline, as in
6049 longlines-mode. (Bug#9254)
75b771e4
EZ
6050 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6051 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6052
6053 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6054 is non-zero, even if the data buffer is NULL. Fixes a crash in
6055 vertical-motion with longlines-mode. (Bug#9254)
6056
35928349
EZ
60572011-08-05 Eli Zaretskii <eliz@gnu.org>
6058
ec7cc85b
EZ
6059 * bidi.c <bidi_cache_total_alloc>: Now static.
6060 (bidi_initialize): Initialize bidi_cache_total_alloc.
6061
8b76d6f8 6062 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6063 cache. (Bug#9221)
6064
6065 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6066 amount allocated this far in `bidi_cache_total_alloc'.
6067 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6068 non-zero, only free the data buffer without restoring the cache
6069 contents. All callers changed.
6070
6071 * dispextern.h (bidi_unshelve_cache): Update prototype.
6072
6073 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6074 (move_it_in_display_line, move_it_to)
6075 (move_it_vertically_backward, move_it_by_lines): Replace the call
6076 to xfree to an equivalent call to bidi_unshelve_cache.
6077 (move_it_in_display_line_to): Fix logic of returning
412b6358 6078 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6079
e2e2423b
EZ
60802011-08-05 Eli Zaretskii <eliz@gnu.org>
6081
6082 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6083 came from a string character with a `cursor' property. (Bug#9229)
6084
ae9e757a
JD
60852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6086
6087 * Makefile.in (LIB_PTHREAD): New variable.
6088 (LIBES): Add LIB_PTHREAD (Bug#9216).
6089
6090 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6091 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6092
213bd7f2
AS
60932011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6094
6b02f655 6095 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6096
99aaf75f
JD
60972011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6098
6099 * xterm.c (x_find_topmost_parent): New function.
6100 (x_set_frame_alpha): Find topmost parent window with
6101 x_find_topmost_parent and set the property there also (bug#9181).
6102 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6103
c74e9d86
PE
61042011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6105
6106 * callproc.c (Fcall_process): Avoid vfork clobbering
6107 the local vars buffer, coding_systems, current_dir.
6108
640c8776
SM
61092011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6110
6111 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6112
f26d0e4c
PE
61132011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6114
8a10d76c
PE
6115 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6116 so that it is not optimized away.
6117
f26d0e4c
PE
6118 * xdisp.c (compute_display_string_pos): Remove unused local.
6119
55439c61
EZ
61202011-08-02 Eli Zaretskii <eliz@gnu.org>
6121
6122 Fix slow cursor motion and scrolling in large buffers with
6123 selective display, like Org Mode buffers. (Bug#9218)
6124
6125 * dispextern.h (struct bidi_it): New member disp_prop_p.
6126
6127 * xdisp.c: Remove one-slot cache of display string positions.
6128 (compute_display_string_pos): Accept an additional argument
5e617bc2 6129 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6130 for a display string or property. If found, set DISP_PROP_P
6131 non-zero.
6132
6133 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6134 DISP_PROP_P, and pass it to compute_display_string_pos.
6135 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6136 non-zero. All callers of bidi_fetch_char changed.
6137
fb33fa43
SM
61382011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6139
6140 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6141
b099e063
DM
61422010-12-03 Don March <don@ohspite.net>
6143
6144 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6145 last character M-[char] is translated to ESC [char] (bug#7541).
6146
5cc7f7af
KH
61472011-08-02 Kenichi Handa <handa@m17n.org>
6148
d0fffa3f 6149 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6150
6151 * chartab.c (uniprop_table): Make it non-static.
6152
525d5e6e
EZ
61532011-08-01 Eli Zaretskii <eliz@gnu.org>
6154
6155 * xdisp.c (forward_to_next_line_start): Accept additional argument
6156 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6157 on the newline.
6158 (reseat_at_next_visible_line_start): Use the bidi iterator state
6159 returned by forward_to_next_line_start to restore the state of
6160 it->bidi_it after backing up to previous newline. (Bug#9212)
6161
31011111
AS
61622011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6163
6164 * regex.c (re_comp): Protoize.
6165 (re_exec): Fix return type.
6166 (regexec): Fix type of `ret'. (Bug#9203)
6167
476371c4
PE
61682011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6169
e5d76069
PE
6170 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6171 This is needed if max-image-size is a floating-point number.
6172
9a79b20c
AS
61732011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6174
6175 * print.c (print_object): Print empty symbol as ##.
6176
6177 * lread.c (read1): Read ## as empty symbol.
6178
d8c2fa78
AA
61792011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6180
6181 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6182 setting frame foreground color (Bug#9175).
6183 (x_set_background_color): Likewise.
6184
ffe57a7a
AA
6185 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6186 contents (Bug#9176).
6187 (EmacsTooltip -init): Remove bezels and add shadows to
6188 tooltip windows.
6189
bf3492a5
AA
6190 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6191 or scroll bar (Bug#8470).
6192
d55e9c53
AA
6193 * nsfont.m (nsfont_open): Remove assignment to voffset and
6194 unnecessary vars hshink, expand, hd, full_height, min_height.
6195 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6196
6197 * nsterm.h (nsfont_info): Remove voffset field.
6198
d8c2fa78 61992011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6200
6201 Implement strike-through and overline on NextStep (Bug#8863).
6202
6203 * nsfont.m (nsfont_open): Use underline position provided by font,
6204 instead of hard-coded value of 2.
6205 (nsfont_draw): Call ns_draw_text_decoration instead.
6206
6207 * nsterm.h: Add declaration for ns_draw_text_decoration.
6208
6209 * nsterm.m (ns_draw_text_decoration): New function for drawing
6210 underline, overline, and strike-through.
6211 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6212 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6213 accommodate underlining, etc.
4843aac3 6214
4cc60b9b
EZ
62152011-07-28 Eli Zaretskii <eliz@gnu.org>
6216
bc7ece87
EZ
6217 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6218 default.
4cc60b9b 6219
476371c4
PE
62202011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6221
66606eea
PE
6222 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6223 Without this fix, if a signal arrives just after memory fills up,
6224 'malloc' might be invoked reentrantly.
6225
476371c4
PE
6226 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6227 In other words, assume that every image size is allowed, on non-X
6228 hosts. This assumption is probably wrong, but it lets Emacs compile.
6229
f3fcc40d
AS
62302011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6231
6232 * regex.c (re_iswctype): Convert return values to boolean.
6233
350c992f
EZ
62342011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6235
6236 * xdisp.c (compute_display_string_pos): Don't use cached display
6237 string position if the buffer had its restriction changed.
6238 (Bug#9184)
6239
5266b4bb
PE
62402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6241
6242 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6243
2573a837 62442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6245
41f55ccd 6246 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6247
39e378da
PE
6248 * bidi.c: Integer size and overflow fixes.
6249 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6250 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6251 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6252 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6253 (bidi_find_other_level_edge):
6254 Use ptrdiff_t instead of EMACS_INT where either will do.
6255 This works better on 32-bit hosts configured --with-wide-int.
6256 (bidi_cache_ensure_space): Check for size-calculation overflow.
6257 Use % rather than repeated addition, for better worst-case speed.
6258 Don't set bidi_cache_size until after xrealloc returns, because it
6259 might not return.
6260 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
6261 (bidi_cache_ensure_space): Also check that the bidi cache size
6262 does not exceed that of the largest Lisp string or buffer. See Eli
6263 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 6264
5e927815
PE
6265 * alloc.c (__malloc_size_t): Remove.
6266 All uses replaced by size_t. See Andreas Schwab's note
6267 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
6268
ca4aa935
PE
6269 * image.c: Improve checking for integer overflow.
6270 (check_image_size): Assume that f is nonnull, since
6271 it is always nonnull in practice. This is one less thing to
6272 worry about when checking for integer overflow later.
6273 (x_check_image_size): New function, which checks for integer
6274 overflow issues inside X.
6275 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
6276 This removes the need for a memory_full check.
6277 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
6278 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
6279 (xbm_read_bitmap_data): Change locals back to 'int', since
6280 their values must fit in 'int'.
6281 (xpm_load_image, png_load, tiff_load):
6282 Invoke x_create_x_image_and_pixmap earlier,
6283 to avoid much needless work if the image is too large.
6284 (tiff_load): Treat overly large images as if
6285 x_create_x_image_and_pixmap failed, not as malloc failures.
6286 (gs_load): Use x_check_image_size.
6287
5f8f9cc2
PE
6288 * gtkutil.c: Omit integer casts.
6289 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
6290 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
6291
5adf60bc
PE
6292 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
6293
c8907a93
PE
6294 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
6295 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
6296 would wrongly return t on a 64-bit host.
6297
e3c25c68
PE
6298 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
6299 The plain *_OVERFLOW macros run afoul of GCC bug 49705
6300 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
6301 and therefore cause GCC to emit a bogus diagnostic in some cases.
6302
3f791afe
PE
6303 * image.c: Integer signedness and overflow and related fixes.
6304 This is not an exhaustive set of fixes, but it's time to
6305 record what I've got.
6306 (lookup_pixel_color, check_image_size): Remove redundant decls.
6307 (check_image_size): Don't assume that arbitrary EMACS_INT values
6308 fit in 'int', or that arbitrary 'double' values fit in 'int'.
6309 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
6310 (tiff_load, imagemagick_load_image):
6311 Check for overflow in size calculations.
6312 (x_create_x_image_and_pixmap): Remove unnecessary test for
6313 xmalloc returning NULL; that can't happen.
6314 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
6315 (xpm_color_bucket): Use better integer hashing function.
6316 (xpm_cache_color): Don't possibly over-allocate memory.
6317 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
6318 (gif_memory_source):
6319 Use ptrdiff_t, not int or size_t, to record sizes.
6320 (png_load): Don't assume values greater than 2**31 fit in 'int'.
6321 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
6322 either works, as we prefer signed integers.
6323 (tiff_read_from_memory, tiff_write_from_memory):
6324 Return tsize_t, not size_t, since that's what the TIFF API wants.
6325 (tiff_read_from_memory): Don't fail simply because the read would
6326 go past EOF; instead, return a short read.
6327 (tiff_load): Omit no-longer-needed casts.
6328 (Fimagemagick_types): Don't assume size fits into 'int'.
6329
3cc5a532
PE
6330 Improve hashing quality when configured --with-wide-int.
6331 * fns.c (hash_string): New function, taken from sxhash_string.
6332 Do not discard information about ASCII character case; this
6333 discarding is no longer needed.
6334 (sxhash-string): Use it. Change sig to match it. Caller changed.
6335 * lisp.h: Declare it.
6336 * lread.c (hash_string): Remove, since we now use fns.c's version.
6337 The fns.c version returns a wider integer if --with-wide-int is
6338 specified, so this should help the quality of the hashing a bit.
6339
b312a492
PE
6340 * emacs.c: Integer overflow minor fix.
6341 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
6342 Define only if GNU_LINUX.
6343 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
6344
dfd153ae
PE
6345 * dispnew.c: Integer signedness and overflow fixes.
6346 Remove unnecessary forward decls, that were a maintenance hassle.
6347 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
6348 All uses changed.
6349 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
6350 (scrolling_window): Use ptrdiff_t, not int, for byte count.
6351 (prepare_desired_row, line_draw_cost):
6352 Use int, not unsigned, where either works.
6353 (save_current_matrix, restore_current_matrix):
6354 Use ptrdiff_t, not size_t, where either works.
6355 (init_display): Check for overflow more accurately, and without
6356 relying on undefined behavior.
6357
a81d11a3
PE
6358 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
6359 Remove, replacing with the new symbols in lisp.h. All uses changed.
6360 * fileio.c (make_temp_name):
6361 * filelock.c (lock_file_1, lock_file):
6362 * xdisp.c (message_dolog):
6363 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
6364 Use pMd etc. instead.
6365 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
6366 replacing the pWIDE etc. symbols removed from editfns.c.
6367
3300e6fd
PE
6368 * keyboard.h (num_input_events): Now uintmax_t.
6369 This is (very slightly) less likely to mess up due to wraparound.
6370 All uses changed.
6371
fd05c7e9
PE
6372 * buffer.c: Integer signedness fixes.
6373 (alloc_buffer_text, enlarge_buffer_text):
6374 Use ptrdiff_t rather than size_t when either will do, as we prefer
6375 signed integers.
6376
903fe15d
PE
6377 * alloc.c: Integer signedness and overflow fixes.
6378 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
6379 (__malloc_size_t): Default to size_t, not to int.
6380 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
6381 (Fgarbage_collect, mark_object_loop_halt, mark_object):
6382 Prefer ptrdiff_t to size_t when either would do, as we prefer
6383 signed integers.
6384 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
6385 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
6386 Now const. Initialize with values that are in range even if char
6387 is signed.
6388 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
6389 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
6390 These functions do the right thing with sizes > 2**32.
6391 (check_depth): Now ptrdiff_t, not int.
6392 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
6393 Adjust to new way of storing sizes. Check for size overflow bugs
6394 in rest of code.
6395 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
6396 slightly wrong anyway, as it missed one instance of
6397 XMALLOC_OVERRUN_CHECK_OVERHEAD.
6398 (refill_memory_reserve): Omit needless cast to size_t.
6399 (mark_object_loop_halt): Mark as externally visible.
6400
ac82cc6a
PE
6401 * xselect.c: Integer signedness and overflow fixes.
6402 (Fx_register_dnd_atom, x_handle_dnd_message):
6403 Use ptrdiff_t, not size_t, since we prefer signed.
6404 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
6405 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
6406 x_dnd_atoms_size and x_dnd_atoms_length.
6407
c2d1e36d
PE
6408 * doprnt.c: Prefer signed to unsigned when either works.
6409 * eval.c (verror):
6410 * doprnt.c (doprnt):
6411 * lisp.h (doprnt):
6412 * xdisp.c (vmessage):
6413 Use ptrdiff_t, not size_t, when using or implementing doprnt,
6414 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
6415 prefer signed arithmetic to avoid comparison confusion.
6416 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
6417 but is a bit tricky.
6418
0e926e56
PE
6419 Assume freestanding C89 headers, string.h, stdlib.h.
6420 * data.c, doprnt.c, floatfns.c, print.c:
6421 Include float.h unconditionally.
6422 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
6423 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
6424 * regex.c: Likewise for stddef.h, string.h.
6425 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
6426 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
6427 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
6428 (STDC_HEADERS): Remove obsolete defines.
6429 * sysdep.c: Include limits.h unconditionally.
6430
9cfdb3ec
PE
6431 Assume support for memcmp, memcpy, memmove, memset.
6432 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
6433 * regex.c (memcmp, memcpy):
6434 Remove; we assume C89 now.
6435
6436 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
6437 (__malloc_safe_bcopy): Remove; no longer needed.
6438
cf950e6b 6439 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
6440 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
6441 well either way, and we prefer signed to unsigned.
6442
dbf38e02
LMI
64432011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
6444
6445 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
6446 closes the connection while we're reading (bug#9182).
6447
d6f0886c 64482011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 6449
d6f0886c
JD
6450 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
6451 are specified (Bug#9168).
24e0f6b1 6452
2eb1f9e6
PE
64532011-07-25 Paul Eggert <eggert@cs.ucla.edu>
6454
6455 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
6456 Found by GCC static checking and --with-wide-int on a 32-bit host.
6457
22381272 64582011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
6459
6460 * xdisp.c (compute_display_string_pos): Fix logic of caching
6461 previous display string position. Initialize cached_prev_pos to
6462 -1. Fixes slow-down at the beginning of a buffer.
6463
f25e39b4
EZ
64642011-07-24 Eli Zaretskii <eliz@gnu.org>
6465
6466 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
6467 for attrs[LFACE_FONTSET_INDEX].
6468
04c4b52e
PE
64692011-07-23 Paul Eggert <eggert@cs.ucla.edu>
6470
6471 * xml.c (parse_region): Remove unused local
6472 that was recently introduced.
6473
c1734fbd
EZ
64742011-07-23 Eli Zaretskii <eliz@gnu.org>
6475
be18c5a5
EZ
6476 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
6477 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
6478
c1734fbd
EZ
6479 * xdisp.c (move_it_in_display_line_to): Record the best matching
6480 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
6481 exit if none of the characters scanned was an exact match.
6482 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
6483 when exact match is impossible due to invisible text, and the
6484 lines are truncated.
6485
a258d627
JD
64862011-07-23 Jan Djärv <jan.h.d@swipnet.se>
6487
6488 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
6489 for OSX >= 10.7.
6490
b6d5a689
EZ
64912011-07-22 Eli Zaretskii <eliz@gnu.org>
6492
0f74f785
EZ
6493 Fix a significant slow-down of cursor motion with C-n, C-p,
6494 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
6495 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 6496 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
6497 (next_element_from_buffer): Call compute_stop_pos_backwards to
6498 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
6499 base_level_stop.
6500 (reseat): Don't look for prev_stop, as that could mean a very long
6501 run.
6502 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
6503 <cached_disp_overlay_modiff>: Cache for last found display string
6504 position.
551918c1 6505 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
6506 about the same buffer in the same area of character positions, and
6507 the buffer wasn't changed since the time the display string
6508 position was cached.
551918c1 6509
b2d0c91a
EZ
65102011-07-22 Eli Zaretskii <eliz@gnu.org>
6511
6512 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
6513 is an integer, which is important for empty lines. (Bug#9149)
6514
043604ee
CY
65152011-07-22 Chong Yidong <cyd@stupidchicken.com>
6516
6517 * frame.c (Fmodify_frame_parameters): In tty case, update the
6518 default face if necessary (Bug#4238).
6519
da4adb04
CY
65202011-07-21 Chong Yidong <cyd@stupidchicken.com>
6521
6522 * editfns.c (Fstring_to_char): No need to explain what a character
6523 is in the docstring (Bug#6576).
6524
9abd0532
LMI
65252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6526
6527 * xml.c (parse_region): Make sure we always return a tree.
6528
36881d16
HK
65292011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
6530
6531 * xml.c (parse_region): If a document contains only comments,
6532 return that, too.
6533
1e98674d
LMI
65342011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
6535
6536 * xml.c (make_dom): Return comments, too.
6537
590bd467
PE
65382011-07-19 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 Port to OpenBSD.
6541 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
6542 and the surrounding thread.
6543 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
6544 rather than fgets, and retry after EINTR. Otherwise, 'emacs
6545 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
6546 timer goes off.
6547 * s/openbsd.h (BROKEN_SIGIO): Define.
6548 * unexelf.c (unexec) [__OpenBSD__]:
6549 Don't update the .mdebug section of the Alpha COFF symbol table.
6550
f41628b2
LMI
65512011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6552
6553 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
6554 (bug#8460).
6555
b59b67c5
PE
65562011-07-18 Paul Eggert <eggert@cs.ucla.edu>
6557
15e3a074
PE
6558 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
6559 This fixes some race conditions on the permissions of any newly
6560 created file.
6561
41bed37d
PE
6562 * alloc.c (valid_pointer_p): Use pipe, not open.
6563 This fixes some permissions issues when debugging.
6564
b59b67c5
PE
6565 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
6566 If fchown fails to set both uid and gid, try to set just gid,
6567 as that is sometimes allowed. Adjust the file's mode to eliminate
6568 setuid or setgid bits that are inappropriate if fchown fails.
6569
925a6be7
SM
65702011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
6571
6572 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
6573 to compare Lisp_Objects.
6574 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
6575 global_gnutls_log_level, don't mistake it for a Lisp_Object.
6576 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
6577
52968808
AS
65782011-07-17 Andreas Schwab <schwab@linux-m68k.org>
6579
0a6a104b
AS
6580 * lread.c (read_integer): Unread even EOF character.
6581 (read1): Likewise. Properly record start position of symbol.
6582
52968808
AS
6583 * lread.c (read1): Read `#:' as empty uninterned symbol if no
6584 symbol character follows.
6585
9e381cdd
PE
65862011-07-17 Paul Eggert <eggert@cs.ucla.edu>
6587
6588 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
6589 This works around a problem with the previous change to Fcopy_file.
6590 Recent glibc declares fchown with __attribute__((warn_unused_result)),
6591 and without this change, GCC might complain about discarding
6592 fchown's return value.
6593
b5641435
JB
65942011-07-16 Juanma Barranquero <lekktu@gmail.com>
6595
6596 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
6597
a8031457
PE
65982011-07-16 Paul Eggert <eggert@cs.ucla.edu>
6599
6600 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
6601
dd889327
LMI
66022011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
6603
750c33f7
LMI
6604 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
6605 it's used from the C level.
6606
dd889327
LMI
6607 * process.c: Use the same condition for POLL_FOR_INPUT in both
6608 keyboard.c and process.c (bug#1858).
6609
87e86684
LM
66102011-07-09 Lawrence Mitchell <wence@gmx.li>
6611
6612 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
6613 (Fgnutls_boot): Use it.
6614
64348f40
AS
66152011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6616
6617 * doc.c (Fsubstitute_command_keys): Revert last change.
6618
1d698799
LMI
66192011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6620
f863868c
LMI
6621 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6622 quotes the next character, and doesn't affect other longer
6623 sequences (bug#8935).
6624
1d698799
LMI
6625 * lread.c (syms_of_lread): Clarify that is isn't only
6626 `eval-buffer' and `eval-defun' that's affected by
6627 `lexical-binding' (bug#8460).
6628
aa4b6df6
EZ
66292011-07-15 Eli Zaretskii <eliz@gnu.org>
6630
6631 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6632 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6633
5d856da6
PE
66342011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6635
ad6042bb
PE
6636 Fix minor problems found by static checking.
6637 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6638 (elsz): Now a signed constant, not a size_t var. We prefer signed
6639 types to unsigned, to avoid integer comparison confusion. Without
6640 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6641 "cannot optimize loop, the loop counter may overflow", a symptom
6642 of the confusion.
f00bbb22 6643 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6644 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6645
6468f31c
LMI
66462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6647
49080b10
LMI
6648 * search.c (Fre_search_backward): Mention `case-fold-search' in
6649 all the re_search_* functions (bug#8138).
6650
6468f31c
LMI
6651 * keyboard.c (Fopen_dribble_file): Document when the file is
6652 closed (bug#8056).
6653
c965adc5
EZ
66542011-07-14 Eli Zaretskii <eliz@gnu.org>
6655
df9733bf
EZ
6656 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6657 bidi_cache_idx.
6658
0bb23927
EZ
6659 Support bidi reordering of display and overlay strings.
6660 * xdisp.c (compute_display_string_pos)
6661 (compute_display_string_end): Accept additional argument STRING.
6662 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6663 (reseat_to_string): Initialize bidi_it->string.s and
6664 bidi_it->string.schars.
6665 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6666 NULL (avoids a crash in bidi_paragraph_init).
6667 Initialize itb.string.lstring.
0bb23927
EZ
6668 (init_iterator): Call bidi_init_it only of a valid
6669 buffer position was specified. Initialize paragraph_embedding to
6670 L2R.
6671 (reseat_to_string): Initialize the bidi iterator.
6672 (display_string): If we need to ignore text properties of
6673 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6674 original value of -1 will not work with bidi.)
6675 (compute_display_string_pos): First arg is now struct
6676 `text_pos *'; all callers changed. Support display properties on
6677 Lisp strings.
6678 (compute_display_string_end): Support display properties on Lisp
6679 strings.
6680 (init_iterator, reseat_1, reseat_to_string): Initialize the
6681 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6682 when iterating on a string not from display properties).
640c8776
SM
6683 (compute_display_string_pos, compute_display_string_end):
6684 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6685 arrow keys.
6686 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6687 base_level_stop; instead, set base_level_stop to BEGV.
6688 Fixes crashes in vertical-motion.
0bb23927
EZ
6689 (next_element_from_buffer): Improve commentary for when
6690 the iterator is before prev_stop.
6691 (init_iterator): Initialize bidi_p from the default value of
6692 bidi-display-reordering, not from buffer-local value. Use the
6693 buffer-local value only if initializing for buffer iteration.
6694 (handle_invisible_prop): Support invisible properties on strings
6695 that are being bidi-reordered.
6696 (set_iterator_to_next): Support bidi reordering of C strings and
6697 Lisp strings.
6698 (next_element_from_string): Support bidi reordering of Lisp
6699 strings.
6700 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6701 (display_string): Support display of R2L glyph rows.
6702 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6703 (init_iterator): Don't initialize it->bidi_p for strings
6704 here.
6705 (reseat_to_string): Initialize it->bidi_p for strings here.
6706 (next_element_from_string, next_element_from_c_string)
6707 (next_element_from_buffer): Add xassert's for correspondence
6708 between IT's object being iterated and it->bidi_it.string
6709 structure.
6710 (face_before_or_after_it_pos): Support bidi iteration.
6711 (next_element_from_c_string): Handle the case of the first string
6712 character that is not the first one in the visual order.
6713 (get_visually_first_element): New function, refactored from common
6714 parts of next_element_from_buffer, next_element_from_string, and
6715 next_element_from_c_string.
6716 (tool_bar_lines_needed, redisplay_tool_bar)
6717 (display_menu_bar): Force left-to-right direction. Add a FIXME
6718 comment for making that be controlled by a user option.
6719 (push_it, pop_it): Save and restore the state of the
6720 bidi iterator. Save and restore the bidi_p flag.
6721 (pop_it): Iterate out of display property for string iteration as
6722 well.
6723 (iterate_out_of_display_property): Support iteration over strings.
6724 (handle_single_display_spec): Set up it->bidi_it for iteration
6725 over a display string, and call bidi_init_it.
6726 (handle_single_display_spec, next_overlay_string)
6727 (get_overlay_strings_1, push_display_prop): Set up the bidi
6728 iterator for displaying display or overlay strings.
6729 (forward_to_next_line_start): Don't use the shortcut if
6730 bidi-iterating.
6731 (back_to_previous_visible_line_start): If handle_display_prop
6732 pushed the iterator stack, restore the internal state of the bidi
6733 iterator by calling bidi_pop_it same number of times.
6734 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6735 and we are bidi-iterating, don't decrement the iterator position;
6736 instead, set the first_elt flag in the bidi iterator, to produce
6737 the same effect.
6738 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6739 (push_display_prop): xassert that we are iterating a buffer.
6740 (push_it, pop_it): Save and restore paragraph_embedding member.
6741 (handle_single_display_spec, next_overlay_string)
6742 (get_overlay_strings_1, reseat_1, reseat_to_string)
6743 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6744 correctly. Don't assume unibyte strings are not bidi-reordered.
6745 (compute_display_string_pos)
6746 (compute_display_string_end): Fix handling the case of C string.
6747 (push_it, pop_it): Save and restore from_disp_prop_p.
6748 (handle_single_display_spec, push_display_prop): Set the
6749 from_disp_prop_p flag.
6750 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6751 (pop_it): Call iterate_out_of_display_property only if we are
6752 popping after iteration over a string that came from a display
6753 property. Fix a typo in popping stretch info. Add an assertion
6754 for verifying that the iterator position is in sync with the bidi
6755 iterator.
6756 (handle_single_display_spec, get_overlay_strings_1)
6757 (push_display_prop): Fix initialization of paragraph direction for
6758 string when that of the parent object is not yet determined.
6759 (reseat_1): Call bidi_init_it to resync the bidi
6760 iterator with IT's position. (Bug#7616)
6761 (find_row_edges): If ROW->start.pos gives position
6762 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6763 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6764 Reset the from_disp_prop_p flag.
6765 (SAVE_IT, RESTORE_IT): New macros.
6766 (pos_visible_p, face_before_or_after_it_pos)
6767 (back_to_previous_visible_line_start)
6768 (move_it_in_display_line_to, move_it_in_display_line)
6769 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6770 (try_scrolling, redisplay_window, display_line): Use them when
6771 saving a temporary copy of the iterator and restoring it back.
6772 (back_to_previous_visible_line_start, reseat_1)
6773 (init_iterator): Empty the bidi cache "stack".
6774 (move_it_in_display_line_to): If iterator ended up at
6775 EOL, but we never saw any buffer positions smaller than
6776 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6777 motion in bidi-reordered lines.
6778 (move_it_in_display_line_to): Record prev_method and prev_pos
6779 immediately before the call to set_iterator_to_next. Fixes cursor
6780 motion in bidi-reordered lines with stretch glyphs and strings
6781 displayed in margins. (Bug#8133) (Bug#8867)
6782 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6783 TO_CHARPOS.
640c8776
SM
6784 (pos_visible_p): Support positions in bidi-reordered lines.
6785 Save and restore bidi cache.
0bb23927
EZ
6786
6787 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6788 (bidi_paragraph_info): Delete unused struct.
6789 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6790 (bidi_cache_start): New variable.
6791 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6792 to zero.
6793 (bidi_cache_fetch_state, bidi_cache_search)
6794 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6795 (bidi_cache_find, bidi_peek_at_next_level)
6796 (bidi_level_of_next_char, bidi_find_other_level_edge)
6797 (bidi_move_to_visually_next): Compare cache index with
6798 bidi_cache_start rather than with zero.
6799 (bidi_fetch_char): Accept new argument STRING; all callers
6800 changed. Support iteration over a string. Support strings with
6801 display properties. Support unibyte strings. Fix the type of
6802 `len' according to what STRING_CHAR_AND_LENGTH expects.
6803 (bidi_paragraph_init, bidi_resolve_explicit_1)
6804 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6805 (bidi_level_of_next_char, bidi_move_to_visually_next):
6806 Support iteration over a string.
0bb23927
EZ
6807 (bidi_set_sor_type, bidi_resolve_explicit_1)
6808 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6809 can now be zero (for strings); special values 0 and -1 were
6810 changed to -1 and -2, respectively.
6811 (bidi_char_at_pos): New function.
6812 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6813 Call it instead of FETCH_MULTIBYTE_CHAR.
6814 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6815 initialized to valid values.
6816 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6817 values.
6818 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6819 the test for valid cached positions. Fix the logic for looking up
6820 the sentinel state in the cache. GCPRO the Lisp string we are
6821 iterating.
6822 (bidi_push_it, bidi_pop_it): New functions.
6823 (bidi_initialize): Initialize the bidi cache start stack pointer.
6824 (bidi_cache_ensure_space): New function, refactored from part of
6825 bidi_cache_iterator_state. Don't assume the required size is just
6826 one BIDI_CACHE_CHUNK away.
6827 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6828 (bidi_count_bytes, bidi_char_at_pos): New functions.
6829 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6830 always valid if bidi_cache_idx is valid.
6831 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6832 is valid if it's going to be used.
6833 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6834 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6835 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6836 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6837 (bidi_find_other_level_edge, bidi_cache_start_stack):
6838 All variables related to cache indices are now EMACS_INT.
c965adc5 6839
0bb23927
EZ
6840 * dispextern.h (struct bidi_string_data): New structure.
6841 (struct bidi_it): New member `string'. Make flag members be 1-bit
6842 fields, and put them last in the struct.
640c8776
SM
6843 (compute_display_string_pos, compute_display_string_end):
6844 Update prototypes.
0bb23927
EZ
6845 (bidi_push_it, bidi_pop_it): Add prototypes.
6846 (struct iterator_stack_entry): New members bidi_p,
6847 paragraph_embedding, and from_disp_prop_p.
6848 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6849 (bidi_shelve_cache, bidi_unshelve_cache):
6850 Declare prototypes.
0bb23927
EZ
6851
6852 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6853 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6854 and vector-like objects.
6855
6856 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6857 cache around display iteration.
6858
6859 * window.c (Fwindow_end, window_scroll_pixel_based)
6860 (displayed_window_lines, Frecenter): Save and restore the bidi
6861 cache around display iteration.
6862
3bbd2265
LMI
68632011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6864
6865 * editfns.c (Fdelete_region): Clarify the use of the named
6866 parameters (bug#6788).
6867
adc47434
MR
68682011-07-14 Martin Rudalics <rudalics@gmx.at>
6869
6870 * indent.c (Fvertical_motion): Set and restore w->pointm when
6871 saving and restoring the window's buffer (Bug#9006).
6872
837c31f8
LMI
68732011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6874
6875 * editfns.c (Fstring_to_char): Clarify just what is returned
6876 (bug#6576). Text by Eli Zaretskii.
6877
ac389d0c
JB
68782011-07-13 Juanma Barranquero <lekktu@gmail.com>
6879
6880 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6881
0be0ce47
EZ
68822011-07-13 Eli Zaretskii <eliz@gnu.org>
6883
6884 * buffer.c (mmap_find): Fix a typo.
6885
cd18e7e3
JB
68862011-07-13 Johan Bockgård <bojohan@gnu.org>
6887
6888 Fix execution of x selection hooks.
6889 * xselect.c (Qx_lost_selection_functions)
6890 (Qx_sent_selection_functions): New vars.
6891 (syms_of_xselect): DEFSYM them.
6892 (x_handle_selection_request): Pass Qx_sent_selection_functions
6893 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6894 (x_handle_selection_clear,x_clear_frame_selections):
6895 Pass Qx_lost_selection_functions rather than
6896 Vx_lost_selection_functions to Frun_hook_with_args.
6897
47ea7f44
PE
68982011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6899
ac389d0c 6900 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6901 The old code sometimes used this field without initializing it.
6902
47ea7f44
PE
6903 * alloc.c (gc_sweep): Don't read past end of array.
6904 In theory, the old code could also have corrupted Emacs internals,
6905 though it'd be very unlikely.
6906
bc985c87
AS
69072011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6908
6909 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6910 argument. (Bug#4026)
bc985c87 6911
0cf34688
LMI
69122011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6913
b3dadd76
LMI
6914 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6915 key" (bug#4257).
6916
0cf34688
LMI
6917 * window.c (Fset_window_start): Doc fix (bug#4199).
6918 (Fset_window_hscroll): Ditto.
6919
270768cd
PE
69202011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6921
077e3dda 6922 Fix minor new problems caught by GCC 4.6.1.
270768cd 6923 * term.c (init_tty): Remove unused local.
490011a6 6924 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6925 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6926 not used otherwise.
270768cd 6927
b1f58454
CY
69282011-07-12 Chong Yidong <cyd@stupidchicken.com>
6929
6930 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6931
22b9578d
LMI
69322011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6933
6e70ab07
LMI
6934 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6935 are the mini-buffer and the echo area (bug#3320).
6936
22b9578d
LMI
6937 * term.c (init_tty): Remove support for supdup, c10 and perq
6938 terminals, which are no longer supported (bug#1482).
6939
8974cc9f
JB
69402011-07-10 Johan Bockgård <bojohan@gnu.org>
6941
6942 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6943
a560d974
JD
69442011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6945
6946 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6947 for non-popups (Bug#3642).
6948
1dae0f0a
AS
69492011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6950
268c2c36 6951 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6952 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6953 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6954 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6955 * data.c (fmod): Likewise.
6956 * dispnew.c (swap_glyphs_in_rows): Likewise.
6957 * emacs.c (memory_warning_signal): Likewise.
6958 * floatfns.c (float_error): Likewise.
6959 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6960 (otf_open, font_otf_capability, generate_otf_features)
6961 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6962 Likewise.
6963 * image.c (pbm_read_file): Likewise.
6964 * indent.c (string_display_width): Likewise.
6965 * intervals.c (check_for_interval, search_for_interval)
6966 (inc_interval_count, count_intervals, root_interval)
6967 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6968 * lread.c (defalias): Likewise.
268c2c36 6969 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6970 * regex.c (set_image_of_range_1, set_image_of_range)
6971 (regex_grow_registers): Likewise.
6972 * sysdep.c (strerror): Likewise.
6973 * termcap.c (valid_filename_p, tprint, main): Likewise.
6974 * tparam.c (main): Likewise.
6975 * unexhp9k800.c (run_time_remap, save_data_space)
6976 (update_file_ptrs, read_header, write_header, calculate_checksum)
6977 (copy_file, copy_rest, display_header): Likewise.
6978 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6979 Likewise.
6980 * xdisp.c (check_it): Likewise.
6981 * xfaces.c (register_color, unregister_color, unregister_colors):
6982 Likewise.
6983 * xfns.c (print_fontset_result): Likewise.
6984 * xrdb.c (member, fatal, main): Likewise.
6985
99033785
PE
69862011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6987
6988 Fix minor problems found by static checking (Bug#9031).
6989 * chartab.c (char_table_set_range, map_sub_char_table):
6990 Remove unused locals.
6991 (uniprop_table): Now static.
6992 * composite.c (_work_char): Remove unused static var.
6993
9cb2ac56
JB
69942011-07-09 Juanma Barranquero <lekktu@gmail.com>
6995
6996 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6997
f25661f0
JD
69982011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6999
7000 * gtkutil.c (qttip_cb): Remove code without function.
7001
8278c4fe
EZ
70022011-07-09 Eli Zaretskii <eliz@gnu.org>
7003
7004 * w32.c (pthread_sigmask): New stub.
7005
1692ae2d 70062011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7007
8a6ebd58 7008 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7009 sigprocmask is portable only for single-threaded applications, and
7010 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7011 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7012 (LIBES): Use it.
7013 * callproc.c (Fcall_process):
7014 * process.c (create_process):
7015 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7016 Use pthread_sigmask, not sigprocmask.
123403e4 7017
1b854618
JD
70182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7019
7020 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7021 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7022 wrong (Bug#8591).
7023
3fe4b549
JD
70242011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7025
0ce7e563
JD
7026 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7027 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7028 (xg_hide_tooltip): Fix comment.
7029
3fe4b549
JD
7030 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7031 in registerServicesMenuSendTypes.
7032 (validRequestorForSendType): Don't check ns_return_types.
7033
7034 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7035 ns_return_type.
7036
5df75e47
JR
70372011-07-08 Jason Rumney <jasonr@gnu.org>
7038
22610910
JR
7039 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7040 SH_SHOW for hidden windows (Bug#5482).
7041
5df75e47
JR
7042 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7043 frame struct members of non-existent frames (Bug#6284).
7044
699c10bd
JD
70452011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7046
4393663b
JD
7047 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7048 variable firstTime not needed on OSX >= 10.6.
7049 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7050 >= 10.5. Use setKnobProportion, setDoubleValue.
7051
7052 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7053 (MAC_OS_X_VERSION_10_5): Define if not defined.
7054 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7055 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7056 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7057
7058 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
7059 cString and lossyCString on OSX >= 10.4
7060
58179cce 7061 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7062 sizeToFit on OSX >= 10.2.
7063
7064 * nsimage.m (allocInitFromFile): Don't use deprecated method
7065 bestRepresentationForDevice on OSX >= 10.6.
7066
7067 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7068 to avoid warning.
7069
7070 * emacs.c: Declare unexec_init_emacs_zone.
7071
a63e0781
JD
7072 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7073
699c10bd
JD
7074 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7075
7076 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7077 on svcsMenu (Bug#8842).
7078
7079 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7080 ns_return_types.
7081 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7082
7083 * nsterm.m (QUTF8_STRING): Declare.
7084 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7085 (validRequestorForSendType): Return type is (id).
7086 Change indexOfObjectIdenticalTo to indexOfObject.
7087 Check if we have local selection before returning self (Bug#8842).
7088 (writeSelectionToPasteboard): Put local selection into paste board
7089 if we have a local selection (Bug#8842).
7090 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7091
7092 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7093 (ns_get_local_selection): Declare.
7094
54e10184
LMI
70952011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7096
9888ff71
LMI
7097 * keymap.c (describe_map_tree): Don't insert a double newline at
7098 the end of the buffer (bug#1169) and return whether we inserted
7099 something.
7100
54e10184
LMI
7101 * callint.c (Fcall_interactively): Change "reading args" to
7102 "providing args" to try to clarify what it does (bug#1010).
7103
15fa4783
KH
71042011-07-07 Kenichi Handa <handa@m17n.org>
7105
7106 * composite.c (composition_compute_stop_pos): Ignore a static
7107 composition starting before CHARPOS (Bug#8915).
7108
7109 * xdisp.c (handle_composition_prop): Likewise.
7110
a8815b00
EZ
71112011-07-07 Eli Zaretskii <eliz@gnu.org>
7112
7113 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7114 (Bug#9015)
7115
ef7b981d 71162011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7117
7118 * character.h (unicode_category_t): New enum type.
7119
7120 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7121 (Qchar_code_property_table): New variable.
7122 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7123 (UNIPROP_COMPRESSED_FORM_P): New macros.
7124 (char_table_ascii): Uncompress the compressed values.
7125 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7126 Uncompress the compressed values.
ac389d0c 7127 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7128 (char_table_ref_and_range): Uncompress the compressed values.
7129 (sub_char_table_set): New arg is_uniprop. Callers changed.
7130 Uncompress the compressed values.
7131 (sub_char_table_set_range): Args changed. Callers changed.
7132 (char_table_set_range): Adjuted for the above change.
7133 (map_sub_char_table): Delete args default_val and parent. Add arg
7134 top. Give decoded values to a Lisp function.
640c8776 7135 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7136 values to a Lisp function. Gcpro more variables.
7137 (uniprop_table_uncompress)
7138 (uniprop_decode_value_run_length): New functions.
7139 (uniprop_decoder, uniprop_decoder_count): New variables.
7140 (uniprop_get_decoder, uniprop_encode_value_character)
7141 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7142 New functions.
7143 (uniprop_encoder, uniprop_encoder_count): New variables.
7144 (uniprop_get_encoder, uniprop_table)
7145 (Funicode_property_table_internal, Fget_unicode_property_internal)
7146 (Fput_unicode_property_internal): New functions.
7147 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7148 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7149 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7150 char-code-property-alist.
7151
640c8776 7152 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7153 Vunicode_category_table.
7154
640c8776 7155 * font.c (font_range): Adjust for the change of
c805dec0
KH
7156 Vunicode_category_table.
7157
76b397fb
DN
71582011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7159
7160 * m/iris4d.h: Remove file, move contents ...
7161 * s/irix6-5.h: ... here.
7162
22b4128e
PE
71632011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7164
7165 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7166 * alloc.c (mark_buffer):
7167 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7168 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7169 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7170 This isn't true in general, and it's particularly not true
7171 if Emacs is configured with --with-wide-int.
7172 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7173 New macros, used in the buffer.c change.
7174
869795d6
JD
71752011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7176
7177 * xsettings.c: Use both GConf and GSettings if both are available.
7178 (store_config_changed_event): Add comment.
7179 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7180 (store_tool_bar_style_changed): New functions.
5e617bc2 7181 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7182 (struct xsettings): Move font inside HAVE_XFT.
7183 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7184 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7185 Move inside HAVE_XFT.
640c8776 7186 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7187 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7188 also.
7189 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7190 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7191 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7192 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7193 (parse_settings): Move check for font inside HAVE_XFT.
7194 (read_settings, apply_xft_settings): Add comment.
7195 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7196 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7197 call store_font_name_changed.
7198 (xft_settings_event): Add comment.
7199 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7200 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7201 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7202 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7203 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7204 (xsettings_get_system_font, xsettings_get_system_normal_font):
7205 Add comment.
869795d6 7206
d8ed26bd
PE
72072011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7208
7209 Random fixes. E.g., (random) never returned negative values.
7210 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7211 subseconds part to the entropy, as that's a bit more random.
7212 Prefer signed to unsigned, since the signedness doesn't matter and
7213 in general we prefer signed. When given a limit, use a
7214 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7215 latter isn't right if USE_2_TAGS_FOR_INTS.
7216 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7217 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7218
cabf1cac
SM
72192011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7220
7221 * textprop.c (text_property_stickiness):
7222 Obey Vtext_property_default_nonsticky.
7223 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7224 * w32fns.c (syms_of_w32fns):
7225 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7226
6e9b2be9
PE
72272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7228
7229 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7230 This is more efficient than Ffile_directory_p and avoids a minor race.
7231
90186c68
LMI
72322011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7233
7c301272
LMI
7234 * buffer.c (Foverlay_put): Say what the return value is
7235 (bug#7835).
7236
c4f2d8d4
LMI
7237 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7238 is a directory before asking whether to use the file name
7239 (bug#7564).
ad637907
LMI
7240 (barf_or_query_if_file_exists): Make the "File is a directory"
7241 error be more correct.
c4f2d8d4 7242
90186c68
LMI
7243 * fns.c (Frequire): Remove the mention of the .gz files, since
7244 that's installation-specific, but keep the mention of
7245 `get-load-suffixes'.
7246
da64016e
PE
72472011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7248
7249 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7250 Report string overflow if the output is too long.
7251
7d47b580
JB
72522011-07-04 Juanma Barranquero <lekktu@gmail.com>
7253
a555cb87
JB
7254 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7255 (syms_of_gnutls): Remove duplicate DEFSYM for
7256 Qgnutls_bootprop_verify_hostname_error, an error for
7257 Qgnutls_bootprop_verify_error (which is no longer used).
7258
7d47b580
JB
7259 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
7260 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
7261 Also (re)move comments that are misplaced or no longer relevant.
7262
1e49bfab
LMI
72632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7264
7265 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
7266
1485f4c0
CY
72672011-07-03 Chong Yidong <cyd@stupidchicken.com>
7268
7269 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
7270 and background color parameters if they have been changed.
7271
a9ab721e
LMI
72722011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7273
7274 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
7275
cf7cff57
PE
72762011-07-03 Paul Eggert <eggert@cs.ucla.edu>
7277
2e13213d
PE
7278 * xsettings.c (SYSTEM_FONT): Define only when used.
7279 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
7280
cf7cff57
PE
7281 * keymap.c (access_keymap_1): Now static.
7282
7a8e04f7
CY
72832011-07-02 Chong Yidong <cyd@stupidchicken.com>
7284
7285 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
7286 leave any prefix arg for the up event (Bug#1586).
7287
61352f62
LMI
72882011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
7289
69bb1ef7
LMI
7290 * lread.c (syms_of_lread): Mention single symbols defined by
7291 `defvar' or `defconst' (bug#7154).
7292
61352f62 7293 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 7294 (Frequire): Mention get-load-suffixes.
61352f62 7295
28545e04
MR
72962011-07-02 Martin Rudalics <rudalics@gmx.at>
7297
7298 * window.h (window): Remove clone_number slot.
7299 * window.c (Fwindow_clone_number, Fset_window_clone_number):
7300 Remove.
7301 (make_parent_window, make_window, saved_window)
7302 (Fset_window_configuration, save_window_save): Don't deal with
7303 clone numbers.
7304 * buffer.c (Qclone_number): Remove declaration.
7305 (sort_overlays, overlay_strings): Don't deal with clone numbers.
7306
3349e122
SM
73072011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
7308
7309 Add multiple inheritance to keymaps.
7310 * keymap.c (Fmake_composed_keymap): New function.
7311 (Fset_keymap_parent): Simplify.
7312 (fix_submap_inheritance): Remove.
7313 (access_keymap_1): New function extracted from access_keymap to handle
7314 embedded parents and handle lists of maps.
7315 (access_keymap): Use it.
7316 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
7317 (Fcopy_keymap): Handle embedded parents.
7318 (Fcommand_remapping, define_as_prefix): Simplify.
7319 (Fkey_binding): Simplify.
7320 (syms_of_keymap): Move minibuffer-local-completion-map,
7321 minibuffer-local-filename-completion-map,
7322 minibuffer-local-must-match-map, and
7323 minibuffer-local-filename-must-match-map to Elisp.
7324 (syms_of_keymap): Defsubr make-composed-keymap.
7325 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
7326 (parse_menu_item): Trivial simplification.
7327
3279eb87
GM
73282011-07-01 Glenn Morris <rgm@gnu.org>
7329
7330 * Makefile.in (SETTINGS_LIBS): Fix typo.
7331
4550efdf
KI
73322011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
7333
7334 * coding.c (Fencode_coding_string): Record the last coding system
7335 used, as the function doc string says (bug#8738).
7336
0949d2b6
JD
73372011-07-01 Jan Djärv <jan.h.d@swipnet.se>
7338
7339 * xsettings.c (store_monospaced_changed): Take new font as arg and
7340 check for change against current_mono_font.
7341 (EMACS_TYPE_SETTINGS): Remove this and related defines.
7342 (emacs_settings_constructor, emacs_settings_get_property)
7343 (emacs_settings_set_property, emacs_settings_class_init)
7344 (emacs_settings_init, gsettings_obj): Remove.
7345 (something_changedCB): New function for HAVE_GSETTINGS.
7346 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
7347 with value as argument.
7348 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
7349 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 7350 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
7351 "changed".
7352
7353 * xgselect.c: Add defined (HAVE_GSETTINGS).
7354 (xgselect_initialize): Ditto.
7355
7356 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
7357 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
7358 xg_select.
7359
bbc6b304
PE
73602011-07-01 Paul Eggert <eggert@cs.ucla.edu>
7361
7362 * eval.c (struct backtrace): Simplify and port the data structure.
7363 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
7364 signed bit field, as this assumption is not portable and it makes
7365 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
7366 "char debug_on_exit : 1" as this is not portable either; instead,
7367 use the portable "unsigned int debug_on_exit : 1". Remove unused
7368 member evalargs. Remove obsolete comments about cc bombing out.
7369
9851bfc5
JD
73702011-06-30 Jan Djärv <jan.h.d@swipnet.se>
7371
51bb811f 7372 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
7373 Let HAVE_GSETTINGS override HAVE_GCONF.
7374 (store_monospaced_changed): New function.
7375 (EMACS_SETTINGS): A new type derived from GObject to handle
7376 GSettings notifications.
7377 (emacs_settings_constructor, emacs_settings_get_property)
7378 (emacs_settings_set_property, emacs_settings_class_init):
7379 New functions.
7380 (gsettings_client, gsettings_obj): New variables.
7381 (GSETTINGS_SCHEMA): New define.
7382 (something_changedCB): Call store_monospaced_changed.
7383 (init_gsettings): New function.
7384 (xsettings_initialize): Call init_gsettings.
7385 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
7386 to NULL.
7387
640c8776 7388 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
7389 GCONF_CFLAGS/LIBS.
7390
5386012d
MR
73912011-06-29 Martin Rudalics <rudalics@gmx.at>
7392
7393 * window.c (resize_root_window, grow_mini_window)
7394 (shrink_mini_window): Rename Qresize_root_window to
7395 Qwindow_resize_root_window and Qresize_root_window_vertically to
7396 Qwindow_resize_root_window_vertically.
7397
f13e0b08
PE
73982011-06-28 Paul Eggert <eggert@cs.ucla.edu>
7399
7400 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
7401
94515237
JB
74022011-06-27 Juanma Barranquero <lekktu@gmail.com>
7403
7404 * makefile.w32-in: Redesign dependencies so they reflect more
7405 clearly which files are directly included by each source file,
7406 and not through other includes.
7407
e43b6e43
MR
74082011-06-27 Martin Rudalics <rudalics@gmx.at>
7409
7410 * buffer.c (Qclone_number): Declare static and DEFSYM it.
7411 (sort_overlays, overlay_strings): When an overlay's clone number
7412 matches the window's clone number process the overlay even if
7413 the overlay's window property doesn't match the current window.
7414
d68443dc
MR
7415 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
7416 (Fwindow_hchild): Rename to Fwindow_left_child.
7417 (Fwindow_next): Rename to Fwindow_next_sibling.
7418 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
7419 (resize_window_check): Rename to window_resize_check.
7420 (resize_window_apply): Rename to window_resize_apply.
7421 (Fresize_window_apply): Rename to Fwindow_resize_apply.
7422 (Fdelete_other_windows_internal, resize_frame_windows)
7423 (Fsplit_window_internal, Fdelete_window_internal)
7424 (grow_mini_window, shrink_mini_window)
7425 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 7426
c7e73be5
JD
74272011-06-26 Jan Djärv <jan.h.d@swipnet.se>
7428
7429 * emacsgtkfixed.h: State that this is only used with Gtk+3.
7430 (emacs_fixed_set_min_size): Remove.
7431 (emacs_fixed_new): Take frame as argument.
7432
7433 * emacsgtkfixed.c: State that this is only used with Gtk+3.
7434 (_EmacsFixedPrivate): Remove minwidth/height.
7435 Add struct frame *f.
7436 (emacs_fixed_init): Initialize priv->f.
7437 (get_parent_class, emacs_fixed_set_min_size): Remove.
7438 (emacs_fixed_new): Set priv->f to argument.
7439 (emacs_fixed_get_preferred_width)
7440 (emacs_fixed_get_preferred_height): Use min_width/height from
7441 frames size_hint to set minimum and natural (Bug#8919).
7442 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
7443 and use min_width/height from frames size_hint to set
7444 min_width/height (Bug#8919).
7445
7446 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
7447 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
7448 Fix indentation.
c7e73be5 7449
cf99dcf8
EZ
74502011-06-26 Eli Zaretskii <eliz@gnu.org>
7451
7452 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
7453 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
7454 called at ZV.
7455
029529ac
CY
74562011-06-26 Chong Yidong <cyd@stupidchicken.com>
7457
7458 * process.c (wait_reading_process_output): Bypass select if
7459 waiting for a cell while ignoring keyboard input, and input is
7460 pending. Suggested by Jan Djärv (Bug#8869).
7461
7a7ef429
PE
74622011-06-25 Paul Eggert <eggert@cs.ucla.edu>
7463
7464 Use gnulib's dup2 module instead of rolling our own.
7465 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
7466
11fdef7d 74672011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
7468
7469 * dispnew.c (scrolling_window): Before scrolling, turn off a
7470 mouse-highlight in the window being scrolled.
7471
cd3520a4
JB
74722011-06-24 Juanma Barranquero <lekktu@gmail.com>
7473
7474 Move DEFSYM to lisp.h and use everywhere.
7475
7476 * character.h (DEFSYM): Move declaration...
7477 * lisp.h (DEFSYM): ...here.
7478
7479 * gnutls.c:
7480 * minibuf.c:
7481 * w32menu.c:
7482 * w32proc.c:
7483 * w32select.c: Don't include character.h.
7484
7485 * alloc.c (syms_of_alloc):
7486 * buffer.c (syms_of_buffer):
7487 * bytecode.c (syms_of_bytecode):
7488 * callint.c (syms_of_callint):
7489 * casefiddle.c (syms_of_casefiddle):
7490 * casetab.c (init_casetab_once):
7491 * category.c (init_category_once, syms_of_category):
7492 * ccl.c (syms_of_ccl):
7493 * cmds.c (syms_of_cmds):
7494 * composite.c (syms_of_composite):
7495 * dbusbind.c (syms_of_dbusbind):
7496 * dired.c (syms_of_dired):
7497 * dispnew.c (syms_of_display):
7498 * doc.c (syms_of_doc):
7499 * editfns.c (syms_of_editfns):
7500 * emacs.c (syms_of_emacs):
7501 * eval.c (syms_of_eval):
7502 * fileio.c (syms_of_fileio):
7503 * fns.c (syms_of_fns):
7504 * frame.c (syms_of_frame):
7505 * fringe.c (syms_of_fringe):
7506 * insdel.c (syms_of_insdel):
7507 * keymap.c (syms_of_keymap):
7508 * lread.c (init_obarray, syms_of_lread):
7509 * macros.c (syms_of_macros):
7510 * msdos.c (syms_of_msdos):
7511 * print.c (syms_of_print):
7512 * process.c (syms_of_process):
7513 * search.c (syms_of_search):
7514 * sound.c (syms_of_sound):
7515 * syntax.c (init_syntax_once, syms_of_syntax):
7516 * terminal.c (syms_of_terminal):
7517 * textprop.c (syms_of_textprop):
7518 * undo.c (syms_of_undo):
7519 * w32.c (globals_of_w32):
7520 * window.c (syms_of_window):
7521 * xdisp.c (syms_of_xdisp):
7522 * xfaces.c (syms_of_xfaces):
7523 * xfns.c (syms_of_xfns):
7524 * xmenu.c (syms_of_xmenu):
7525 * xsettings.c (syms_of_xsettings):
7526 * xterm.c (syms_of_xterm): Use DEFSYM.
7527
4228cf16
TZ
75282011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
7529
cd3520a4 7530 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 7531
7fcccf1e
PE
75322011-06-23 Paul Eggert <eggert@cs.ucla.edu>
7533
7efb4e0e
PE
7534 Integer and buffer overflow fixes (Bug#8873).
7535
ff5844ad
PE
7536 * print.c (printchar, strout): Check for string overflow.
7537 (PRINTPREPARE, printchar, strout):
7538 Don't set size unless allocation succeeds.
7539
90532f02
PE
7540 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
7541 for sizes. Check for string overflow more accurately.
7542 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
7543
6d84508d
PE
7544 * macros.c: Integer and buffer overflow fixes.
7545 * keyboard.h (struct keyboard.kbd_macro_bufsize):
7546 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
7547 Use ptrdiff_t, not int, for sizes.
7548 Don't increment bufsize until after realloc succeeds.
7549 Check for size-calculation overflow.
7550 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
7551
437b2cb4
PE
7552 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
7553
8b9ac8b4
PE
7554 * lread.c: Integer overflow fixes.
7555 (read_integer): Radix is now EMACS_INT, not int,
7556 to improve quality of diagnostics for out-of-range radices.
7557 Calculate buffer size correctly for out-of-range radices.
7558 (read1): Check for integer overflow in radices, and in
7559 read-circle numbers.
82cb60d3
PE
7560 (read_escape): Avoid int overflow.
7561 (Fload, openp, read_buffer_size, read1)
7562 (substitute_object_recurse, read_vector, read_list, map_obarray):
7563 Use ptrdiff_t, not int, for sizes.
7564 (read1): Use EMACS_INT, not int, for sizes.
20270765 7565 Check for size overflow.
8b9ac8b4 7566
7fcccf1e
PE
7567 * image.c (cache_image): Check for size arithmetic overflow.
7568
bfbbd7e7
PE
7569 * lread.c: Integer overflow issues.
7570 (saved_doc_string_size, saved_doc_string_length)
7571 (prev_saved_doc_string_size, prev_saved_doc_string_length):
7572 Now ptrdiff_t, not int.
7573 (read1): Don't assume doc string length fits in int. Check for
7574 out-of-range doc string lengths.
7575 (read_list): Don't assume file position fits in int.
39019e54 7576 (read_escape): Check for hex character overflow.
bfbbd7e7 7577
4e323265
LL
75782011-06-22 Leo Liu <sdl.web@gmail.com>
7579
7580 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
7581 Move to minibuffer.el.
7582
85fece3e
PE
75832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7584
20b84ce9 7585 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
7586 The following patches are for when GLYPH_DEBUG && !XASSERT.
7587 * dispextern.h (trace_redisplay_p, dump_glyph_string):
7588 * dispnew.c (flush_stdout):
7589 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
7590 Mark as externally visible.
7591 * dispnew.c (check_window_matrix_pointers): Now static.
7592 * dispnew.c (window_to_frame_vpos):
7593 * xfns.c (unwind_create_frame):
7594 * xterm.c (x_check_font): Remove unused local.
7595 * scroll.c (CHECK_BOUNDS):
7596 * xfaces.c (cache_fache): Rename local to avoid shadowing.
7597 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
7598 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
7599 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
7600 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
7601 Now static.
7602 (debug_method_add): Use va_list and vsprintf rather than relying
7603 on undefined behavior with wrong number of arguments.
7604 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
7605 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
7606 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
7607 since we're not interested in debugging glyphs with old libraries.
7608 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
7609 GCC 4.6.0's static checking.
7610
0766b489
PE
76112011-06-22 Paul Eggert <eggert@cs.ucla.edu>
7612
31fd4b32
PE
7613 Integer overflow and signedness fixes (Bug#8873).
7614 A few related buffer overrun fixes, too.
7615
b79e8648
PE
7616 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7617
0766b489
PE
7618 * dispextern.h (struct face.stipple):
7619 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7620 (x_bitmap_mask, x_allocate_bitmap_record)
7621 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7622 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7623 (x_create_bitmap_from_xpm_data):
7624 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7625 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7626 (.bitmaps_last):
7627 * xfaces.c (load_pixmap):
7628 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7629 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7630 (.bitmaps_last, struct x_output.icon_bitmap):
7631 Use ptrdiff_t, not int, for bitmap indexes.
7632 (x_allocate_bitmap_record): Check for size overflow.
7633 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7634
b081724f
PE
7635 Use ptrdiff_t, not int, for overlay counts.
7636 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7637 * editfns.c (overlays_around, get_pos_property):
7638 * textprop.c (get_char_property_and_overlay):
7639 * xdisp.c (next_overlay_change, note_mouse_highlight):
7640 * xfaces.c (face_at_buffer_position):
21514da7
PE
7641 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7642 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7643 (Fnext_overlay_change, Fprevious_overlay_change)
7644 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7645 Use ptrdiff_t, not int, for sizes.
21514da7 7646 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7647
3de73e5e
PE
7648 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7649
2606c57b
PE
7650 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7651 (x_session_initialize): Do not assume string length fits in int.
7652
aaafe47a
PE
7653 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7654 This is unlikely, but can occur if DPI is outlandish.
7655
2674ddc8 7656 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7657 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7658
28154962
PE
7659 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7660 * xrdb.c (magic_file_p, search_magic_path):
7661 Omit last arg SUFFIX; it was always 0. All callers changed.
7662 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7663
7de51af5
PE
7664 * xfont.c (xfont_match): Avoid need for strlen.
7665
25ed6cc3
PE
7666 * xfns.c: Don't assume strlen fits in int.
7667 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7668
4eab31dd
PE
7669 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7670 not unsigned long, as we prefer signed integers. All callers changed.
7671 Detect integer overflow in repeat count.
7672 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7673 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7674
171e2a58
PE
7675 * termcap.c: Don't assume sizes fit in int and never overflow.
7676 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7677 (gobble_line): Check for size-calculation overflow.
7678
ad39faca 7679 * minibuf.c (Fread_buffer):
6e5bb2dc 7680 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7681 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7682 Don't assume string length fits in int.
7683
52c61c22 7684 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7685 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7686
b5b8c9e5
PE
7687 * font.c: Don't assume string length fits in int.
7688 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7689 Use ptrdiff_t, not int.
ccd6111c
PE
7690 (font_intern_prop): Don't assume string length fits in int.
7691 Don't assume integer property fits in fixnum.
7692 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7693
882f0d81 7694 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7695 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7696 Reformulate so as not to need the command string.
7697 Invoke gzip -cd rather than gunzip, as it's more portable.
7698 (lock_info_type, lock_file_1, lock_file):
7699 Don't assume pid_t and time_t fit in unsigned long.
7700 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7701 (current_lock_owner): Prefer signed type for sizes.
7702 Use memcpy, not strncpy, where memcpy is what is really wanted.
7703 Don't assume (via atoi) that time_t and pid_t fit in int.
7704 Check for time_t and/or pid_t out of range, e.g., via a network share.
7705 Don't alloca where an auto var works fine.
7706
93f4cf88
PE
7707 * fileio.c: Fix some integer overflow issues.
7708 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7709 Don't assume string length fits in int.
7710 (directory_file_name): Don't assume string length fits in long.
7711 (make_temp_name): Don't assume pid fits in int, or that its print
7712 length is less than 20.
7713
f3e92b69
PE
7714 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7715
1bfdaf10
PE
7716 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7717
35016e9a
PE
7718 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7719
3d1e65a1
PE
7720 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7721 We prefer signed integers, even for size calculations.
7722
0b963a93
PE
7723 * emacs.c: Don't assume string length fits in 'int'.
7724 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7725 (main): Don't invoke strlen when not needed.
7726
573f4b54
PE
7727 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7728 (XD_DEBUG_MESSAGE): Don't waste a byte.
7729
989f33ba
PE
7730 * callproc.c (getenv_internal_1, getenv_internal)
7731 (Fgetenv_internal):
965d34eb
PE
7732 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7733
e4d29b33
PE
7734 * lread.c (invalid_syntax): Omit length argument.
7735 All uses changed. This doesn't fix a bug, but it simplifies the
7736 code away from its former Hollerith-constant appearance, and it's
7737 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7738 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7739
eb49b136
PE
7740 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7741 This didn't break anything, but it didn't help either.
7742 It's confusing to put a bogus integer in a place where the actual
7743 value does not matter.
9f62aeb1 7744 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7745 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7746
15375a22
PE
7747 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7748 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7749 implementation.
b61cc01c
PE
7750 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7751 We prefer signed types, and the value cannot exceed the EMACS_INT
7752 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7753 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7754 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7755 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7756
53b2623d
PE
7757 * indent.c (sane_tab_width): New function.
7758 (current_column, scan_for_column, Findent_to, position_indentation)
7759 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7760 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7761
51cab52b 7762 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7763
f2ed8a70
PE
7764 * lisp.h (lint_assume): New macro.
7765 * composite.c (composition_gstring_put_cache):
7766 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7767
abe80cc6
PE
7768 * editfns.c, insdel.c:
7769 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7770
b02c740e
PE
7771 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7772
ebc96716
PE
7773 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7774
b4e50fa0 7775 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7776 Use much-faster test for byte-length change.
311d5d7c 7777 Don't assume string byte-length fits in 'int'.
a4cf38e4 7778 Check that character arg fits in 'int'.
85461888 7779 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7780
c0c1ee9f
PE
7781 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7782
a498d7f4
PE
7783 * fns.c (concat): Catch string overflow earlier.
7784 Do not rely on integer wraparound.
7785
51cab52b
PE
7786 * dispextern.h (struct it.overlay_strings_charpos)
7787 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7788 * xdisp.c (forward_to_next_line_start)
7789 (back_to_previous_visible_line_start)
7790 (reseat_at_next_visible_line_start, next_element_from_buffer):
7791 Don't arbitrarily truncate the value of 'selective' to int.
7792
76031fad
PE
7793 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7794
5eb55db9
PE
7795 * composite.c: Don't truncate sizes to 'int'.
7796 (composition_gstring_p, composition_reseat_it)
7797 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7798 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7799 not EMACS_UINT, for indexes.
5eb55db9 7800
0703a717
PE
7801 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7802
d6202519
PE
7803 * buffer.c: Include <verify.h>.
7804 (struct sortvec.priority, struct sortstr.priority):
8961a454 7805 Now EMACS_INT, not int.
c20998a7 7806 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7807 (struct sortstr.size, record_overlay_string)
7808 (struct sortstrlist.size, struct sortlist.used):
7809 Don't truncate size to int.
7810 (record_overlay_string): Check for size-calculation overflow.
d6202519 7811 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7812
d5a19415
JM
78132011-06-22 Jim Meyering <meyering@redhat.com>
7814
029529ac 7815 Don't leak an XBM-image-sized buffer
d5a19415
JM
7816 * image.c (xbm_load): Free the image buffer after using it.
7817
a9041e6c
PE
78182011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7819
7820 Port to Sun C.
7821 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7822 that Sun C diagnosed.
7823 * fns.c (secure_hash): Fix pointer signedness issue.
7824 * intervals.c (static_offset_intervals): New function.
7825 (offset_intervals): Use it.
7826
7f3f739f
LL
78272011-06-21 Leo Liu <sdl.web@gmail.com>
7828
7829 * deps.mk (fns.o):
7830 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7831 sha512.h.
7832
7833 * fns.c (secure_hash): Rename from crypto_hash_function and change
7834 the first arg to accept symbols.
5b66d427 7835 (Fsecure_hash): New primitive.
7f3f739f
LL
7836 (syms_of_fns): New symbols.
7837
76147d94
DD
78382011-06-20 Deniz Dogan <deniz@dogan.se>
7839
7840 * process.c (Fset_process_buffer): Clarify return value in
7841 docstring.
7842
7d7d0045
CY
78432011-06-18 Chong Yidong <cyd@stupidchicken.com>
7844
7845 * dispnew.c (add_window_display_history): Use BVAR.
7846
7847 * xdisp.c (debug_method_add): Use BVAR.
7848 (check_window_end, dump_glyph_matrix, dump_glyph)
7849 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7850
7851 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7852 Likewise.
7853
7854 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7855 check till after the cache is created in init_frame_faces.
7856
ff2bc410
SM
78572011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7858
7859 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7860
28177add
PE
78612011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7862
dd3482fe
PE
7863 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7864 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7865 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7866
393d71f3 7867 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7868 * fileio.c (Finsert_file_contents):
7869 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7870 Remove the old (too-loose) buffer overflow checks.
7871 They weren't needed, since make_gap checks for buffer overflow.
7872 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7873 The old code merely checked for Emacs fixnum overflow, and relied
7874 on undefined (wraparound) behavior. The new code avoids undefined
7875 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7876
2e6813b0 7877 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7878 Tune. Don't use wider integers than needed. Don't use alloca.
7879 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7880
599a9e4f
PE
7881 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7882
99561444
PE
7883 * insdel.c, lisp.h (buffer_overflow): New function.
7884 (insert_from_buffer_1, replace_range, replace_range_2):
7885 * insdel.c (make_gap_larger):
7886 * editfns.c (Finsert_char):
7887 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7888
28177add
PE
7889 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7890
e69dafad
PE
78912011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7892
4baa020d 7893 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7894
b1c46f02
PE
7895 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7896 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7897
e69dafad
PE
7898 * fileio.c: Don't assume EMACS_INT fits in off_t.
7899 (emacs_lseek): New static function.
7900 (Finsert_file_contents, Fwrite_region): Use it.
7901 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7902
566684ea
PE
7903 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7904
e6966cd6
PE
7905 * fns.c: Don't overflow int when computing a list length.
7906 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7907 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7908 truncation on 64-bit hosts. Check for QUIT every
7909 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7910 faster and is responsive enough.
7911 (Flength): Report an error instead of overflowing an integer.
7912 (Fsafe_length): Return a float if the value is not representable
7913 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7914 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7915 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7916
dd0b0efb
PE
7917 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7918 (header_size, word_size): New constants.
7919 (allocate_vectorlike): Don't check size overflow here.
7920 (allocate_vector): Check it here instead, since this is the only
7921 caller of allocate_vectorlike that could cause overflow.
7922 Check that the new vector's length is representable as a fixnum.
7923
86fe5cfe
PE
7924 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7925 The previous code was bogus. For example, next_almost_prime (32)
7926 returned 39, which is undesirable as it is a multiple of 3; and
7927 next_almost_prime (24) returned 25, which is a multiple of 5 so
7928 why was the code bothering to check for multiples of 7?
7929
80e88859
PE
7930 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7931
4a2f0ad6
PE
7932 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7933
f66c7cf8
PE
7934 Variadic C functions now count arguments with ptrdiff_t.
7935 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7936 Back then I didn't know that the Emacs coding style prefers signed int.
7937 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7938 were being counted with int, which may truncate counts on 64-bit
7939 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7940 * lisp.h (struct Lisp_Subr.function.aMANY)
7941 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7942 Arg counts are now ptrdiff_t, not size_t.
7943 All variadic functions and their callers changed accordingly.
7944 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7945 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7946 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7947 * callint.c (Fcall_interactively): Check arg count for overflow,
7948 to avoid potential buffer overrun. Use signed char, not 'int',
7949 for 'varies' array, so that we needn't bother to check its size
7950 calculation for overflow.
7951 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7952 * eval.c (apply_lambda):
7953 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7954 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7955 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7956
a1759b76
PE
7957 * callint.c (Fcall_interactively): Don't use index var as event count.
7958
d96be9fc
PE
7959 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7960 * mem-limits.h (SIZE): Remove; no longer used.
7961
a690a978 7962 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7963
578c21e6
PE
7964 Remove unnecessary casts.
7965 * xterm.c (x_term_init):
7966 * xfns.c (x_set_border_pixel):
7967 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7968 These aren't needed now that we assume ANSI C.
7969
96f53c6c
PE
7970 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7971 It's more likely to cause problems (due to unsigned overflow)
7972 than to cure them.
7973
83c77d31
PE
7974 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7975
ee2079f1
PE
7976 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7977
6da65536
PE
7978 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7979
7147c4a4
PE
7980 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7981
193e32d9
PE
7982 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7983
e5533da6
PE
7984 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7985
9910e595
PE
7986 GLYPH_CODE_FACE returns EMACS_INT, not int.
7987 * dispextern.h (merge_faces):
7988 * xfaces.c (merge_faces):
01103c44
PE
7989 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7990 Don't assume EMACS_INT fits in int.
9910e595 7991
2638320e
PE
7992 * character.h (CHAR_VALID_P): Remove unused parameter.
7993 * fontset.c, lisp.h, xdisp.c: All uses changed.
7994
045eb8d9
PE
7995 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7996
c1f134b5
PE
7997 * fns.c (concat): Minor tuning based on overflow analysis.
7998 This doesn't fix any bugs. Use int to hold character, instead
7999 of constantly refetching from Emacs object. Use XFASTINT, not
8000 XINT, for value known to be a character. Don't bother comparing
8001 a single byte to 0400, as it's always less.
8002
395fcb93 8003 * floatfns.c (Fexpt):
327eeec8
PE
8004 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8005
abbd3d23
PE
8006 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8007 for characters.
8008
684a03ef
PE
8009 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8010
0fed43f3
PE
8011 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8012 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8013 incorrectly succeed when S was a string, because 4294967386 was
8014 truncated before it was used.
8015
8fd02eb7
PE
8016 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8017 Otherwise, an out-of-range integer could cause undefined behavior
8018 on a 64-bit host.
8019
f8c86b69
PE
8020 * composite.c: Use int, not EMACS_INT, for characters.
8021 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8022 EMACS_INT, for values that are known to be in character range.
8023 This doesn't fix any bugs but is the usual style inside Emacs and
8024 may generate better code on 32-bit machines.
8025
34206dd2
PE
8026 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8027 This is for reasons similar to the recent CHAR_STRING fix.
8028 * charset.c (Fencode_char): Check that character arg is actually
8029 a character. Pass an int to ENCODE_CHAR.
8030 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8031 wider than 'int', as a compile-time check to prevent future regressions
8032 in this area.
8033
c5958d4c 8034 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8035
8036 Make sure a 64-bit char is never passed to CHAR_STRING.
8037 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8038 by silently ignoring the top 32 bits, allowing some values
8039 that were far too large to be valid characters.
8040 * character.h: Include <verify.h>.
8041 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8042 arguments are no wider than unsigned, as a compile-time check
8043 to prevent future regressions in this area.
8044 * data.c (Faset):
01103c44 8045 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8046 (Fsubst_char_in_region):
8047 * fns.c (concat):
8048 * xdisp.c (decode_mode_spec_coding):
8049 Adjust to CHAR_STRING's new requirement.
8050 * editfns.c (Finsert_char, Fsubst_char_in_region):
8051 * fns.c (concat): Check that character args are actually
8052 characters. Without this test, these functions did the wrong
8053 thing with wildly out-of-range values on 64-bit hosts.
8054
d37ca623
PE
8055 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8056 These casts should not be needed on 32-bit hosts, either.
8057 * keyboard.c (read_char):
8058 * lread.c (Fload): Remove casts to unsigned.
8059
ea204efb
PE
8060 * lisp.h (UNSIGNED_CMP): New macro.
8061 This fixes comparison bugs on 64-bit hosts.
8062 (ASCII_CHAR_P): Use it.
8063 * casefiddle.c (casify_object):
01103c44 8064 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8065 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8066 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8067 * dispextern.h (FACE_FROM_ID):
8068 * keyboard.c (read_char): Use UNSIGNED_CMP.
8069
41cb286c
PE
8070 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8071 not to EMACS_INT, to avoid GCC warning.
8072
4a1b9832
PE
8073 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8074
55daad71
PE
8075 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8076 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8077 isn't needed on 32-bit machines.
8f95c75c 8078
01103c44
PE
8079 * buffer.c (Fgenerate_new_buffer_name):
8080 Use EMACS_INT for count, not int.
0ceccced 8081 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8082
8083 * data.c (Qcompiled_function): Now static.
8084
c6f072e7
PE
8085 * window.c (window_body_lines): Now static.
8086
20ce5912
PE
8087 * image.c (gif_load): Rename local to avoid shadowing.
8088
9c4c5f81
PE
8089 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8090 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8091 * alloc.c (make_save_value): Integer argument is now of type
8092 ptrdiff_t, not int.
8093 (mark_object): Use ptrdiff_t, not int.
8094 * lisp.h (pD): New macro.
8095 * print.c (print_object): Use it.
8096
c0c5c8ae
PE
8097 * alloc.c: Use EMACS_INT, not int, to count objects.
8098 (total_conses, total_markers, total_symbols, total_vector_size)
8099 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8100 (total_free_floats, total_floats, total_free_intervals)
8101 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8102 Now EMACS_INT, not int. All uses changed.
8103 (Fgarbage_collect): Compute overall total using a double, so that
8104 integer overflow is less likely to be a problem. Check for overflow
8105 when converting back to an integer.
5a25e253
PE
8106 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8107 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8108 These were 'int' variables that could overflow on 64-bit hosts;
8109 they were never used, so remove them instead of repairing them.
211a0b2a 8110 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8111 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8112 Previously, this ceilinged at INT_MAX, but that doesn't work on
8113 64-bit machines.
e46bb31a 8114 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8115
c78baabf 8116 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8117 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8118 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8119 when a (possibly-narrower) signed value would do just as well.
8120 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8121
c9d624c6
PE
8122 * alloc.c: Catch some string size overflows that we were missing.
8123 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8124 for convenience in STRING_BYTES_MAX.
8125 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8126 The definition here is exact; the one in lisp.h was approximate.
8127 (allocate_string_data): Check for string overflow. This catches
8128 some instances we weren't catching before. Also, it catches
8129 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8130 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8131 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8132
c9d624c6
PE
8133 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8134 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8135 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8136
353032ce
PE
8137 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8138
2bccce07
PE
8139 * alloc.c (Fmake_string): Check for out-of-range init.
8140
0ac30604
SM
81412011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8142
8143 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8144
c195f2de
JD
81452011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8146
8147 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8148 xg_get_default_scrollbar_width.
8149
8150 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8151 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8152 (style_changed_cb): Call update_theme_scrollbar_width and call
8153 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8154 all frames (Bug#8505).
8155 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8156 Call gtk_window_set_resizable if HAVE_GTK3.
8157 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8158 and height if HAVE_GTK3 (Bug#8505).
8159 (scroll_bar_width_for_theme): New variable.
8160 (update_theme_scrollbar_width): New function.
8161 (xg_get_default_scrollbar_width): Move code to
8162 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8163 (xg_initialize): Call update_theme_scrollbar_width.
8164
8165 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8166
8167 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8168
e10ac9f1
MR
81692011-06-12 Martin Rudalics <rudalics@gmx.at>
8170
8171 * frame.c (make_frame): Call other_buffer_safely instead of
8172 other_buffer.
8173
8174 * window.c (temp_output_buffer_show): Call display_buffer with
8175 second argument Vtemp_buffer_show_specifiers and reset latter
8176 immediately after the call.
8177 (Vtemp_buffer_show_specifiers): New variable.
8178 (auto_window_vscroll_p, next_screen_context_lines)
8179 (Vscroll_preserve_screen_position): Remove leading asterisks from
8180 doc-strings.
8181
2d3c217e 81822011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8183
7b7f97e8 8184 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8185 * buffer.c (Qclone_number): Remove for now, as it's unused.
8186 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8187 (record_buffer): Remove unused local.
8188 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8189 (set_frame_buffer_list): Remove; unused.
8190 * frame.h (other_visible_frames): Remove decl.
8191 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8192 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8193 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8194 if HAVE_GPM.
8195 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8196 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8197 Define only if HAVE_GPM.
8198 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8199 (update_hints_inhibit): Remove; never set. All uses removed.
8200 * widgetprv.h (emacsFrameClassRec): Remove decl.
8201 * window.c (delete_deletable_window): Now returns void, since it
8202 wasn't returning anything.
8203 (compare_window_configurations): Remove unused locals.
8204 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8205 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8206 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8207 the same widths as pointers. This follows up on the 2011-05-06 patch.
8208 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8209 * xterm.h: Likewise.
8210 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8211
1384b89e
JB
82122011-06-12 Juanma Barranquero <lekktu@gmail.com>
8213
8214 * makefile.w32-in: Update dependencies.
8215 (LISP_H): Add lib/intprops.h.
8216
1100a63c
CY
82172011-06-11 Chong Yidong <cyd@stupidchicken.com>
8218
8219 * image.c (gif_load): Add animation frame delay to the metadata.
8220 (syms_of_image): Use DEFSYM. New symbol `delay'.
8221
6198ccd0
MR
82222011-06-11 Martin Rudalics <rudalics@gmx.at>
8223
8224 * window.c (delete_deletable_window): Re-add.
8225 (Fset_window_configuration): Rewrite to handle dead buffers and
8226 consequently deletable windows.
8227 (window_tree, Fwindow_tree): Remove. Supply functionality in
8228 window.el.
8229 (compare_window_configurations): Simplify code.
8230
b6e3633c
AS
82312011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8232
1ab0dee5
AS
8233 * image.c (imagemagick_load_image): Fix type mismatch.
8234 (Fimagemagick_types): Likewise.
8235
b6e3633c
AS
8236 * window.h (replace_buffer_in_windows): Declare.
8237
9397e56f
MR
82382011-06-11 Martin Rudalics <rudalics@gmx.at>
8239
8240 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8241 Qclone_number. Remove external declaration of Qdelete_window.
8242 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8243 code.
640c8776
SM
8244 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8245 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8246 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8247 buffer list implementation.
8248 (other_buffer_safely): New function.
8249 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8250 calls to replace_buffer_in_windows and
8251 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8252 if allowed.
8253 (record_buffer): Inhibit quitting and rewrite using quittable
8254 functions. Run Qbuffer_list_update_hook if allowed.
8255 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
8256 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
8257 Move switch-to-buffer to window.el.
9397e56f
MR
8258 (bury-buffer): Move to window.el.
8259 (Vbuffer_list_update_hook): New variable.
8260
8261 * lisp.h (other_buffer_safely): Add prototype in buffer.c
8262 section.
8263
8264 * window.h (resize_frame_windows): Move up in code.
8265 (Fwindow_frame): Remove EXFUN.
8266 (replace_buffer_in_all_windows): Remove prototype.
8267 (replace_buffer_in_windows_safely): Add prototype.
8268
8269 * window.c: Declare Qdelete_window static again. Move down
8270 declaration of select_count.
8271 (Fnext_window, Fprevious_window): Rewrite doc-strings.
8272 (Fother_window): Move to window.el.
8273 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
8274 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
8275 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
8276 window.el.
8277 (replace_buffer_in_windows): Implement by calling
8278 Qreplace_buffer_in_windows.
8279 (replace_buffer_in_all_windows): Remove with some functionality
8280 moved into replace_buffer_in_windows_safely.
8281 (replace_buffer_in_windows_safely): New function.
8282 (select_window_norecord, select_frame_norecord): Move in front
8283 of run_window_configuration_change_hook. Remove now obsolete
8284 declarations.
640c8776
SM
8285 (Fset_window_buffer): Rewrite doc-string.
8286 Call Qrecord_window_buffer.
9397e56f
MR
8287 (keys_of_window): Move binding for other-window to window.el.
8288
b50691aa
CY
82892011-06-11 Chong Yidong <cyd@stupidchicken.com>
8290
8291 * dispextern.h (struct image): Replace data member, whose int_val
8292 and ptr_val fields were not used by anything, with a single
8293 lisp_val object.
8294
8295 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
8296 (gif_clear_image, gif_load, imagemagick_load_image)
8297 (gs_clear_image, gs_load): Callers changed.
8298
3f754b86
PE
82992011-06-10 Paul Eggert <eggert@cs.ucla.edu>
8300
cca69397
PE
8301 * buffer.h: Include <time.h>, for time_t.
8302 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
8303
109e28d0
PE
8304 Fix minor problems found by static checking.
8305
60737f02
PE
8306 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
8307
4b66faf3
PE
8308 Make identifiers static if they are not used in other modules.
8309 * data.c (Qcompiled_function, Qframe, Qvector):
8310 * image.c (QimageMagick, Qsvg):
8311 * minibuf.c (Qmetadata):
8312 * window.c (resize_window_check, resize_root_window): Now static.
8313 * window.h (resize_window_check, resize_root_window): Remove decls.
8314
109e28d0
PE
8315 * window.c (window_deletion_count, delete_deletable_window):
8316 Remove; unused.
46a4ce9e
PE
8317 (window_body_lines): Now static.
8318 (Fdelete_other_windows_internal): Mark vars as initialized.
8319 Make sure 'resize_failed' is initialized.
8320 (run_window_configuration_change_hook): Rename local to avoid shadowing.
8321 (resize_window_apply): Remove unused local.
8322 * window.h (delete_deletable_window): Remove decl.
8323
109e28d0 8324 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
8325 (imagemagick_load_image): Fix pointer signedness problem by changing
8326 last arg from unsigned char * to char *. All uses changed.
8327 Also, fix a local for similar reasons.
8328 Remove unused locals. Remove locals to avoid shadowing.
8329 (fn_rsvg_handle_free): Remove; unused.
8330 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 8331 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 8332
3f754b86
PE
8333 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
8334
2547adb1
CY
83352011-06-10 Chong Yidong <cyd@stupidchicken.com>
8336
8337 * image.c (gif_load): Fix omitted cast error introduced by
8338 2011-06-06 change.
8339
2c8e37d4
MR
83402011-06-10 Martin Rudalics <rudalics@gmx.at>
8341
8342 * window.h (resize_proportionally, orig_total_lines)
8343 (orig_top_line): Remove from window structure.
8344 (set_window_height, set_window_width, change_window_heights)
8345 (Fdelete_window): Remove prototypes.
8346 (resize_frame_windows): Remove duplicate declaration.
8347
440a42e3
EZ
83482011-06-10 Eli Zaretskii <eliz@gnu.org>
8349
8350 * window.h (resize_frame_windows, resize_window_check)
8351 (delete_deletable_window, resize_root_window)
8352 (resize_frame_windows): Declare prototypes.
8353
8354 * window.c (resize_window_apply): Make definition be "static" to
8355 match the prototype.
8356
562dd5e9
MR
83572011-06-10 Martin Rudalics <rudalics@gmx.at>
8358
8359 * window.c: Remove declarations of Qwindow_size_fixed,
8360 window_min_size_1, window_min_size_2, window_min_size,
8361 size_window, window_fixed_size_p, enlarge_window, delete_window.
8362 Remove static from declaration of Qdelete_window, it's
8363 temporarily needed by Fbury_buffer.
8364 (replace_window): Don't assign orig_top_line and
8365 orig_total_lines.
8366 (Fdelete_window, delete_window): Remove. Window deletion is
8367 handled by window.el.
640c8776
SM
8368 (window_loop): Remove DELETE_OTHER_WINDOWS case.
8369 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
8370 (Fdelete_other_windows): Remove. Deleting other windows is
8371 handled by window.el.
8372 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
8373 handled in window.el.
8374 (window_min_size_2, window_min_size_1, window_min_size): Remove.
8375 Window minimum sizes are handled in window.el.
8376 (shrink_windows, size_window, set_window_height)
8377 (set_window_width, change_window_heights, window_height)
8378 (window_width, CURBEG, CURSIZE, enlarge_window)
8379 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
8380 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
8381 handled in window.el.
8382 (make_dummy_parent): Rename to make_parent_window and give it a
8383 second argument horflag.
8384 (make_window): Don't set resize_proportionally any more.
8385 (Fsplit_window): Remove. Windows are split in window.el.
8386 (save_restore_action, save_restore_orig_size)
8387 (shrink_window_lowest_first, save_restore_orig_size): Remove.
8388 Resize mini windows in window.el.
8389 (grow_mini_window, shrink_mini_window): Implement by calling
8390 Qresize_root_window_vertically, resize_window_check and
8391 resize_window_apply.
640c8776
SM
8392 (saved_window, Fset_window_configuration, save_window_save):
8393 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
8394 resize_proportionally.
8395 (window_min_height, window_min_width): Move to window.el.
8396 (keys_of_window): Move bindings for delete-other-windows,
8397 split-window, delete-window and enlarge-window to window.el.
8398
8399 * buffer.c: Temporarily extern Qdelete_window.
8400 (Fbury_buffer): Temporarily call Qdelete_window instead of
8401 Fdelete_window (Fbury_buffer will move to window.el soon).
8402
8403 * frame.c (set_menu_bar_lines_1): Remove code handling
8404 orig_top_line and orig_total_lines.
8405
8406 * dispnew.c (adjust_frame_glyphs_initially): Don't use
8407 set_window_height but set heights directly.
8408 (change_frame_size_1): Use resize_frame_windows.
8409
8410 * xdisp.c (init_xdisp): Don't use set_window_height but set
8411 heights directly.
8412
640c8776
SM
8413 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
8414 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
8415 run_window_configuration_change_hook.
8416
8417 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
8418 instead of change_window_heights and run
8419 run_window_configuration_change_hook.
8420
1a13852e
MR
84212011-06-09 Martin Rudalics <rudalics@gmx.at>
8422
8423 * window.c (replace_window): Rename second argument REPLACEMENT to
8424 NEW. New third argument SETFLAG. Rewrite.
8425 (delete_window, make_dummy_parent): Call replace_window with
8426 third argument 1.
8427 (window_list_1): Move down in code.
8428 (run_window_configuration_change_hook): Move set_buffer part
8429 before select_frame_norecord part in order to unwind correctly.
8430 Rename count1 to count.
8431 (recombine_windows, delete_deletable_window, resize_root_window)
8432 (Fdelete_other_windows_internal)
8433 (Frun_window_configuration_change_hook, make_parent_window)
8434 (resize_window_check, resize_window_apply, Fresize_window_apply)
8435 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
8436 (Fdelete_window_internal, Fresize_mini_window_internal):
8437 New functions.
1a13852e
MR
8438 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
8439
f3d1777e
MR
84402011-06-08 Martin Rudalics <rudalics@gmx.at>
8441
496e208e
MR
8442 * window.h (window): Add some new members to window structure -
8443 normal_lines, normal_cols, new_total, new_normal, clone_number,
8444 splits, nest, prev_buffers, next_buffers.
8445 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 8446 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 8447
f3d1777e
MR
8448 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
8449 Remove.
496e208e
MR
8450 (make_dummy_parent): Set new members of windows structure.
8451 (make_window): Move down in code. Handle new members of window
8452 structure.
8453 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
8454 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
8455 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
8456 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
8457 (Fset_window_next_buffers, Fset_window_clone_number):
8458 New functions.
496e208e
MR
8459 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
8460 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
8461 Doc-string fixes.
8462 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
8463 Argument WINDOW can be now internal window too.
8464 (Fwindow_use_time): Move up in code.
8465 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
8466 Rewrite doc-string.
8467 (Fset_window_configuration, saved_window)
8468 (Fcurrent_window_configuration, save_window_save): Handle new
8469 members of window structure.
b9e809c2
MR
8470 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
8471 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
8472 (syms_of_window): New Lisp objects Qrecord_window_buffer,
8473 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
8474 Qget_mru_window, Qresize_root_window,
8475 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
8476 Qauto_buffer_name; staticpro them.
f3d1777e 8477
abde8f8c
MR
84782011-06-07 Martin Rudalics <rudalics@gmx.at>
8479
8480 * window.c (Fwindow_total_size, Fwindow_left_column)
8481 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
8482 (Fwindow_list_1): New functions.
8483 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
8484 (Fwindow_width, Fscroll_left, Fscroll_right):
8485 Use window_body_cols instead of window_box_text_cols.
8486 (delete_window, Fset_window_configuration):
8487 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
8488 (delete_all_subwindows): Take a window as argument and not a
8489 structure. Rewrite.
190b47e6
MR
8490 (window_loop): Remove handling of GET_LRU_WINDOW and
8491 GET_LARGEST_WINDOW.
8492 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
8493
8494 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
8495 window_box_text_cols. delete_all_subwindows now takes a
8496 Lisp_Object as argument.
abde8f8c 8497
640c8776
SM
8498 * indent.c (compute_motion, Fcompute_motion):
8499 Use window_body_cols instead of window_box_text_cols.
abde8f8c 8500
fa8a67e6
MR
8501 * frame.c (delete_frame): Call delete_all_subwindows with root
8502 window as argument.
8503
a54e3482
DC
85042011-06-07 Daniel Colascione <dan.colascione@gmail.com>
8505
8506 * fns.c (Fputhash): Document return value.
8507
60002bf5
CY
85082011-06-06 Chong Yidong <cyd@stupidchicken.com>
8509
8510 * image.c (gif_load): Implement gif89a spec "no disposal" method.
8511
0c671da6 85122011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 8513
b862a52a 8514 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 8515
be44ca6c
PE
8516 Check for overflow when converting integer to cons and back.
8517 * charset.c (Fdefine_charset_internal, Fdecode_char):
8518 Use cons_to_unsigned to catch overflow.
8519 (Fencode_char): Use INTEGER_TO_CONS.
8520 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
8521 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
8522 * data.c (long_to_cons, cons_to_long): Remove.
8523 (cons_to_unsigned, cons_to_signed): New functions.
8524 These signal an error for invalid or out-of-range values.
8525 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
8526 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
8527 * font.c (Ffont_variation_glyphs):
8528 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
8529 * lisp.h: Include <intprops.h>.
8530 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
8531 (cons_to_signed, cons_to_unsigned): New decls.
8532 (long_to_cons, cons_to_long): Remove decls.
8533 * undo.c (record_first_change): Use INTEGER_TO_CONS.
8534 (Fprimitive_undo): Use CONS_TO_INTEGER.
8535 * xfns.c (Fx_window_property): Likewise.
8536 * xselect.c: Include <limits.h>.
8537 (x_own_selection, selection_data_to_lisp_data):
8538 Use INTEGER_TO_CONS.
8539 (x_handle_selection_request, x_handle_selection_clear)
8540 (x_get_foreign_selection, Fx_disown_selection_internal)
8541 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
8542 (lisp_data_to_selection_data): Use cons_to_unsigned.
8543 (x_fill_property_data): Use cons_to_signed.
8544 Report values out of range.
8545
d1f3d2af
PE
8546 Check for buffer and string overflow more precisely.
8547 * buffer.h (BUF_BYTES_MAX): New macro.
8548 * lisp.h (STRING_BYTES_MAX): New macro.
8549 * alloc.c (Fmake_string):
8550 * character.c (string_escape_byte8):
8551 * coding.c (coding_alloc_by_realloc):
8552 * doprnt.c (doprnt):
8553 * editfns.c (Fformat):
8554 * eval.c (verror):
8555 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
8556 since they may not be the same number.
8557 * editfns.c (Finsert_char):
8558 * fileio.c (Finsert_file_contents):
8559 Likewise for BUF_BYTES_MAX.
8560
dd52fcea
PE
8561 * image.c: Use ptrdiff_t, not int, for sizes.
8562 (slurp_file): Switch from int to ptrdiff_t.
8563 All uses changed.
8564 (slurp_file): Check that file size fits in both size_t (for
8565 malloc) and ptrdiff_t (for sanity and safety).
8566
7f9bbdbb
PE
8567 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
8568 if b->modtime has its maximal value.
8569
dfe18f82
PE
8570 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
8571
84acfcf0
PE
8572 Don't assume time_t can fit into int.
8573 * buffer.h (struct buffer.modtime): Now time_t, not int.
8574 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
8575 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
8576
ccd9a01a
PE
8577 Minor fixes for signed vs unsigned integers.
8578 * character.h (MAYBE_UNIFY_CHAR):
8579 * charset.c (maybe_unify_char):
8580 * keyboard.c (read_char, reorder_modifiers):
8581 XINT -> XFASTINT, since the integer must be nonnegative.
8582 * ftfont.c (ftfont_spec_pattern):
8583 * keymap.c (access_keymap, silly_event_symbol_error):
8584 XUINT -> XFASTINT, since the integer must be nonnegative.
8585 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
8586 since it makes no difference and we prefer signed.
8587 * keyboard.c (record_char): Use XUINT when all the neighbors do.
8588 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
8589 nonnegative.
8590
d6d100dd
SM
85912011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
8592
8593 * window.h (Fwindow_frame): Declare.
8594
2b6148e4
PE
85952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8596
8597 * alloc.c: Simplify handling of large-request failures (Bug#8800).
8598 (SPARE_MEMORY): Always define.
8599 (LARGE_REQUEST): Remove.
8600 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
8601
f230ecc9
MR
86022011-06-06 Martin Rudalics <rudalics@gmx.at>
8603
727e958e
MR
8604 * lisp.h: Move EXFUNS for Fframe_root_window,
8605 Fframe_first_window and Fset_frame_selected_window to window.h.
8606
8607 * window.h: Move EXFUNS for Fframe_root_window,
8608 Fframe_first_window and Fset_frame_selected_window here from
8609 lisp.h.
8610
8611 * frame.c (Fwindow_frame, Fframe_first_window)
8612 (Fframe_root_window, Fframe_selected_window)
8613 (Fset_frame_selected_window): Move to window.c.
8614 (Factive_minibuffer_window): Move to minibuf.c.
8615 (Fother_visible_frames_p): New function.
8616
8617 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8618
f230ecc9
MR
8619 * window.c (decode_window, decode_any_window): Move up in code.
8620 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8621 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8622 (Fwindow_buffer): Move up and rewrite doc-string.
8623 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8624 (Fwindow_prev): New functions.
727e958e
MR
8625 (Fwindow_frame): Move here from frame.c. Accept any window as
8626 argument.
8627 (Fframe_root_window, Fframe_first_window)
8628 (Fframe_selected_window): Move here from frame.c. Accept frame
8629 or arbitrary window as argument. Update doc-strings.
8630 (Fminibuffer_window): Move up in code.
8631 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8632 (Fset_frame_selected_window): Move here from frame.c.
8633 Marginal rewrite.
727e958e
MR
8634 (Fselected_window, select_window, Fselect_window): Move up in
8635 code. Minor doc-string fixes.
f230ecc9 8636
4d09bcf6
PE
86372011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8638
8639 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8640 Do not assume that spare memory exists; that assumption is valid
8641 only if SYSTEM_MALLOC.
8642 (LARGE_REQUEST): New macro, so that the issue of large requests
8643 is separated from the issue of spare memory.
8644
810928a2
AS
86452011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8646
172418ad
AS
8647 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8648 format. (Bug#8806)
8649
43f862f7
AS
8650 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8651
810928a2
AS
8652 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8653 before statements.
8654
a059fe24
JD
86552011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8656
8657 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8658
8659 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8660
8661 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8662 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8663
989bf368
JB
86642011-06-05 Juanma Barranquero <lekktu@gmail.com>
8665
8666 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8667
4b80f674
CY
86682011-06-04 Chong Yidong <cyd@stupidchicken.com>
8669
8670 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8671 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8672 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8673 New error handlers.
4b80f674
CY
8674 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8675 Obey Vx_select_enable_clipboard_manager. Catch errors in
8676 x_clipboard_manager_save (Bug#8779).
8677 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8678 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8679
99a33b77 86802011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8681
8682 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8683
99a33b77 86842011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8685
8686 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8687 in the current matrix if keep_current_p is non-zero.
8688
8264569d
EZ
86892011-06-04 Eli Zaretskii <eliz@gnu.org>
8690
8691 * bidi.c (bidi_level_of_next_char): Fix last change.
8692
57f97249
EZ
86932011-06-03 Eli Zaretskii <eliz@gnu.org>
8694
fec2107c 8695 Support bidi reordering of text covered by display properties.
57f97249 8696
fec2107c
EZ
8697 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8698 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8699 (bidi_cache_search, bidi_cache_iterator_state)
8700 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8701 (bidi_level_of_next_char, bidi_move_to_visually_next):
8702 Support character positions inside a run of characters covered by a
fec2107c
EZ
8703 display string.
8704 (bidi_paragraph_init, bidi_resolve_explicit_1)
8705 (bidi_level_of_next_char): Call bidi_fetch_char and
8706 bidi_fetch_char_advance instead of FETCH_CHAR and
8707 FETCH_CHAR_ADVANCE.
8708 (bidi_init_it): Initialize new members.
8709 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8710 definitions.
8711 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8712 instead of using explicit *_CHAR codes.
d6d100dd
SM
8713 (bidi_resolve_explicit, bidi_resolve_weak):
8714 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8715 bidirectional text is supported only in multibyte buffers.
8716 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8717 it to initialize the frame_window_p member of struct bidi_it.
8718 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8719 (bidi_resolve_explicit, bidi_resolve_weak)
8720 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8721 bidi_it->nchars is non-positive.
8722 (bidi_level_of_next_char): Don't try to lookup the cache for the
8723 next/previous character if nothing is cached there yet, or if we
8724 were just reseat()'ed to a new position.
c40e2fb2 8725
0e14fe90
EZ
8726 * xdisp.c (set_cursor_from_row): Set start and stop points
8727 according to the row's direction when priming the loop that looks
8728 for the glyph on which to display cursor.
8729 (single_display_spec_intangible_p): Function deleted.
8730 (display_prop_intangible_p): Reimplement to call
8731 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8732 Accept 3 additional arguments needed by handle_display_spec.
8733 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8734 values: lists, `(when COND...)' forms, etc.
8735 (single_display_spec_string_p): Support property values that are
8736 lists with the argument STRING its top-level element.
8737 (display_prop_string_p): Fix the condition for processing a
8738 property that is a list to be consistent with handle_display_spec.
fec2107c 8739 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8740 last portion of handle_display_prop.
8741 (compute_display_string_pos): Accept additional argument
8742 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8743 value of a `display' property is a "replacing spec".
8744 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8745 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8746 the display property, but just return a value indicating whether
8747 the display property will replace the characters it covers.
8748 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8749 frame_window_p members of struct bidi_it.
d6d100dd
SM
8750 (compute_display_string_pos, compute_display_string_end):
8751 New functions.
fec2107c
EZ
8752 (push_it): Accept second argument POSITION, where pop_it should
8753 jump to continue iteration.
8754 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8755
fec2107c
EZ
8756 * keyboard.c (adjust_point_for_property): Adjust the call to
8757 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8758
8759 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8760 (bidi_init_it): Update prototypes.
8761 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8762 (compute_display_string_pos, compute_display_string_end):
8763 Declare prototypes.
fec2107c
EZ
8764 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8765 EMACS_INT.
fc6f18ce 8766
40087514 87672011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8768
57f53182
PE
8769 Malloc failure behavior now depends on size of allocation.
8770 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8771 * lisp.h: Change signatures accordingly.
8772 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8773 All callers changed. (Bug#8762)
8774
8775 * gnutls.c: Use Emacs's memory allocators.
8776 Without this change, the gnutls library would invoke malloc etc.
8777 directly, which causes problems on non-SYNC_INPUT hosts, and which
8778 runs afoul of improving memory_full behavior. (Bug#8761)
8779 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8780 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8781 xfree instead of the default malloc, realloc, free.
8782 (Fgnutls_boot): No need to check for memory allocation failure,
8783 since xmalloc does that for us.
8784
ac32cd99 8785 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8786 * category.c (hash_get_category_set):
8787 * ccl.c (ccl_driver):
8788 * charset.c (Fdefine_charset_internal):
8789 * charset.h (struct charset.hash_index):
8790 * composite.c (get_composition_id, gstring_lookup_cache)
8791 (composition_gstring_put_cache):
8792 * composite.h (struct composition.hash_index):
8793 * dispextern.h (struct image.hash):
8794 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8795 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8796 (hashfn_equal, hashfn_user_defined, make_hash_table)
8797 (maybe_resize_hash_table, hash_lookup, hash_put)
8798 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8799 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8800 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8801 * image.c (make_image, search_image_cache, lookup_image)
8802 (xpm_put_color_table_h):
8803 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8804 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8805 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8806 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8807 * alloc.c (allocate_vectorlike):
8808 Check for overflow in vector size calculations.
8809 * ccl.c (ccl_driver):
8810 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8811 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8812 need to be updated by these changes.
40087514
PE
8813 * fns.c (make_hash_table, maybe_resize_hash_table):
8814 Check for integer overflow with large hash tables.
0de4bb68
PE
8815 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8816 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8817 (SXHASH_REDUCE): New macro.
8818 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8819 Use it instead of discarding useful hash info with large hash values.
8820 (sxhash_float): New function.
8821 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8822 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8823 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8824 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8825 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8826 Adjust signatures to match updated version of code.
8827 (consing_since_gc): Now EMACS_INT, since a single hash table can
8828 use more than INT_MAX bytes.
8829
698d32e2
DN
88302011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8831
8832 Make it possible to build with GCC-4.6+ -O2 -flto.
8833
8834 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8835
fd6fa53f
SM
88362011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8837
8838 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8839 Call minibuffer-inactive-mode.
8840
864db017
JB
88412011-05-31 Juanma Barranquero <lekktu@gmail.com>
8842
8843 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8844 Update dependencies.
8845
2ad0baf4
DN
88462011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8847
8848 * data.c (init_data): Remove code for UTS, this system is not
8849 supported anymore.
8850
4fcc2638
DN
88512011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8852
8853 Don't force ./temacs to start in terminal mode.
8854
8855 * frame.c (make_initial_frame): Initialize faces in all cases, not
8856 only when CANNOT_DUMP is defined.
8857 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8858
c56e0fd5
DN
88592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8860
8861 * dispnew.c (add_window_display_history): Use const for the string
8862 pointer. Remove declaration, not needed.
8863
333d54da 88642011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8865
55d4c1b2 8866 Use 'inline', not 'INLINE'.
333d54da 8867 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8868 * alloc.c, fontset.c (INLINE): Remove.
8869 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8870 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8871 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8872 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8873 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8874
738db178
DN
88752011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8876
8877 Make it possible to run ./temacs.
8878
8879 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8880 syms_of_callproc does the same thing. Remove test for
8881 "initialized", do it in the caller.
8882 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8883
620c53a6
SM
88842011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8885
8886 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8887 (read_minibuf): Use get_minibuffer.
8888 (syms_of_minibuf): Use DEFSYM.
8889 (Qmetadata): New var.
8890 * data.c (Qbuffer): Don't make it static.
8891 (syms_of_data): Use DEFSYM.
8892
e003a292
PE
88932011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8894
8895 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8896 (CCL_CODE_MIN): New macro.
8897
ed008a6d
PE
88982011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8899
3687c2ef
PE
8900 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8901
ed008a6d
PE
8902 * eval.c (Qdebug): Now static.
8903 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8904 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8905 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8906
d66c4c7c
CY
89072011-05-29 Chong Yidong <cyd@stupidchicken.com>
8908
8909 * image.c: Various fixes to ImageMagick code comments.
8910 (Fimagemagick_types): Doc fix.
8911
5fbc2025
PE
89122011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8913
0196f88a
PE
8914 Minor fixes prompted by GCC 4.6.0 warnings.
8915
8916 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8917
5fbc2025
PE
8918 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8919 (x_clipboard_manager_save_all): Move extern decl to ...
8920 * xterm.h: ... here, so that it can be checked for consistency.
8921
1dd3c2d9
CY
89222011-05-29 Chong Yidong <cyd@stupidchicken.com>
8923
8924 * xselect.c (x_clipboard_manager_save_frame)
8925 (x_clipboard_manager_save_all): New functions.
8926 (Fx_clipboard_manager_save): Lisp function deleted.
8927
8928 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8929 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8930
8931 * xterm.h: Update prototype.
8932
5ba6571d
WX
89332011-05-28 William Xu <william.xwl@gmail.com>
8934
8935 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8936 exiting (Bug#8239).
8937
3eaff834
JM
89382011-05-28 Jim Meyering <meyering@redhat.com>
8939
e1900994 8940 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8941 * fns.c (to_uchar): Define.
8942 (crypto_hash_function): Use it to convert some newly-signed
8943 variables to unsigned, to avoid sign-extension bugs. For example,
8944 without this change, (md5 "truc") would evaluate to
8945 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8946 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8947 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8948
0f6990a7
PE
89492011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8950
8951 Integer overflow fixes.
c8a9ca5a 8952
08686060
PE
8953 * dbusbind.c: Serial number integer overflow fixes.
8954 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8955 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8956 to hold a serial number that is too large for a fixnum.
8957 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8958 Check for serial numbers out of range. Decode any serial number
59568bf0 8959 that was so large that it became a float. (Bug#8722)
08686060 8960
2d1fc3c7
PE
8961 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8962 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8963 Use XFASTINT rather than XUINT when numbers are nonnegative.
8964 (xd_append_arg, Fdbus_method_return_internal):
8965 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8966 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8967 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8968 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8969 (Bug#8722)
2d1fc3c7 8970
c8a9ca5a
PE
8971 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8972
519e1d69
PE
8973 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8974
6df6ae42 8975 ccl: Add integer overflow checks.
30569699
PE
8976 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8977 (IN_INT_RANGE): New macros.
8978 (ccl_driver): Use them to check for integer overflow when
8979 decoding a CCL program. Many of the new checks are whether XINT (x)
8980 fits in int; it doesn't always, on 64-bit hosts. The new version
8981 doesn't catch all possible integer overflows, but it's an
847044ea 8982 improvement. (Bug#8719)
30569699 8983
c11285dc
PE
8984 * alloc.c (make_event_array): Use XINT, not XUINT.
8985 There's no need for unsigned here.
8986
fdccd48e
PE
8987 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8988 This follows up to the 2011-05-06 change that substituted uintptr_t
8989 for EMACS_INT. This case wasn't caught back then.
8990
37910ab2
PE
8991 Rework Fformat to avoid integer overflow issues.
8992 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8993 now (part of C89). Include <verify.h>.
8994 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8995 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8996 (Fformat): Avoid the prepass trying to compute sizes; it was only
8997 approximate and thus did not catch overflow reliably. Instead, walk
8998 through the format just once, formatting and computing sizes as we go,
8999 checking for integer overflow at every step, and allocating a larger
9000 buffer as needed. Keep track separately whether the format is
9001 multibyte. Keep only the most-recently calculated precision, rather
9002 than them all. Record whether each argument has been converted to
9003 string. Use EMACS_INT, not int, for byte and char and arg counts.
9004 Support field widths and precisions larger than INT_MAX. Avoid
9005 sprintf's undefined behavior with conversion specifications such as %#d
9006 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9007 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9008 formatting out-of-range floating point numbers with int
9173deec 9009 formats. (Bug#8668)
37910ab2 9010
2e6578fb
PE
9011 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9012
0ae6bdee
PE
9013 * data.c: Avoid integer truncation in expressions involving floats.
9014 * data.c: Include <intprops.h>.
9015 (arith_driver): When there's an integer overflow in an expression
9016 involving floating point, convert the integers to floating point
9017 so that the resulting value does not suffer from catastrophic
9018 integer truncation. For example, on a 64-bit host (* 4
9019 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9020 Do not rely on undefined behavior after integer overflow.
9021
de883a70
PE
9022 merge count_size_as_multibyte, parse_str_to_multibyte
9023 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9024 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9025 Check for integer overflow.
9026 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9027 since it's now a duplicate of the other. This is more of
9028 a character than a buffer op, so better that it's in character.c.
9029 * fns.c, print.c: Adjust to above changes.
9030
2ff916cb
PE
90312011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9032
9033 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9034
f1b54466
PE
90352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9036
fb1ac845
PE
9037 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9038 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9039 (x_clipboard_manager_save): Now static.
9040 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9041
f1b54466
PE
9042 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9043 (crypto_hash_function): Now static.
9044 Fix pointer signedness problems. Avoid unnecessary initializations.
9045
a9f737ee
CY
90462011-05-27 Chong Yidong <cyd@stupidchicken.com>
9047
9048 * termhooks.h (Vselection_alist): Make it terminal-local.
9049
9050 * terminal.c (create_terminal): Initialize it.
9051
9052 * xselect.c: Support for clipboard managers.
9053 (Vselection_alist): Move to termhooks.h as terminal-local var.
9054 (LOCAL_SELECTION): New macro.
9055 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9056 (symbol_to_x_atom): Remove gratuitous arg.
9057 (x_handle_selection_request, lisp_data_to_selection_data)
9058 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9059 (x_own_selection, x_get_local_selection, x_convert_selection):
9060 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9061 (some_frame_on_display): Delete unused function.
9062 (Fx_own_selection_internal, Fx_get_selection_internal)
9063 (Fx_disown_selection_internal, Fx_selection_owner_p)
9064 (Fx_selection_exists_p): New optional frame arg.
9065 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9066 (x_handle_selection_clear): Don't treat other terminals with the
9067 same keyboard specially. Use the terminal-local Vselection_alist.
9068 (x_clear_frame_selections): Use Frun_hook_with_args.
9069
9070 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9071
9072 * xterm.h: Add support for those atoms.
9073
e067f0c1
CY
90742011-05-26 Chong Yidong <cyd@stupidchicken.com>
9075
9076 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9077 (converted_selections, conversion_fail_tag): New global variables.
9078 (x_selection_request_lisp_error): Free the above.
9079 (x_get_local_selection): Remove unnecessary code.
9080 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9081 of converted selections stored in converted_selections.
9082 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9083 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9084 (x_convert_selection): New function.
9085 (x_handle_selection_event): Simplify.
9086 (x_get_foreign_selection): Don't ignore incoming requests while
9087 waiting for an answer; this will fail when we implement
9088 SAVE_TARGETS, and seems unnecessary anyway.
9089 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9090 (Vx_sent_selection_functions): Doc fix.
9091
0f4aebc0
LL
90922011-05-26 Leo Liu <sdl.web@gmail.com>
9093
9094 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9095
e61124cd
YM
90962011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9097
9098 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9099
9100 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9101 for fringe update if it has periodic bitmap.
ac389d0c 9102 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9103 and fringe_bitmap_periodic_p.
9104
9105 * fringe.c (get_fringe_bitmap_data): New function.
9106 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9107 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9108 row. Mark glyph row for fringe update if periodicity changed.
9109
9110 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9111 for fringe update unless it has periodic bitmap.
9112
f16d9837
KH
91132011-05-25 Kenichi Handa <handa@m17n.org>
9114
9115 * xdisp.c (get_next_display_element): Set correct it->face_id for
9116 a static composition.
9117
e1b90ef6
LL
91182011-05-24 Leo Liu <sdl.web@gmail.com>
9119
9120 * deps.mk (fns.o):
9121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9122
9123 * fns.c (crypto_hash_function, Fsha1): New function.
9124 (Fmd5): Use crypto_hash_function.
9125 (syms_of_fns): Add Ssha1.
9126
7400048f
PE
91272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9128
9129 * gnutls.c: Remove unused macros.
9130 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9131 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9132 Remove macros that are defined and never used.
9133 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9134
abb71cf4
CY
91352011-05-22 Chong Yidong <cyd@stupidchicken.com>
9136
9137 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9138 (Fx_get_selection_internal): Minor cleanup.
9139 (Fx_own_selection_internal): Rename arguments for consistency with
9140 select.el.
9141
6307db39
PE
91422011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9143
9144 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9145
f3d4e0a4
CY
91462011-05-22 Chong Yidong <cyd@stupidchicken.com>
9147
9148 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9149
4d8ade89
YM
91502011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9151
9152 * dispnew.c (scrolling_window): Don't exclude the case that the
9153 last enabled row in the desired matrix touches the bottom boundary.
9154
32078c8d
GM
91552011-05-21 Glenn Morris <rgm@gnu.org>
9156
9157 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9158 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9159 and add some more files.
32078c8d 9160
7285dc67
EZ
91612011-05-20 Eli Zaretskii <eliz@gnu.org>
9162
9163 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9164 report_file_error introduced by the change from 2011-05-07.
9165
89d1bd22
PE
91662011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9167
9168 * systime.h (Time): Define only if emacs is defined.
9169 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9170 where the include path doesn't have X11/X.h by default. See
9171 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9172
cd394be1 91732011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9174
9175 * composite.c (find_automatic_composition): Fix previous change.
9176
b9704ad9
GM
91772011-05-20 Glenn Morris <rgm@gnu.org>
9178
9179 * lisp.mk: New file, split from Makefile.in.
9180 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9181 (shortlisp): Remove.
9182 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9183
4a720484
GM
91842011-05-19 Glenn Morris <rgm@gnu.org>
9185
9186 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9187 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9188 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9189 (lisp): Set the order to that of loadup.el.
9190 (shortlisp): Make it a copy of $lisp.
9191 (SOME_MACHINE_LISP): Remove.
9192 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9193 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9194
a28d4396
KH
91952011-05-18 Kenichi Handa <handa@m17n.org>
9196
9197 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9198 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9199 (find_automatic_composition): Mostly rewrite for efficiency.
9200
a2b1fa8e
JB
92012011-05-18 Juanma Barranquero <lekktu@gmail.com>
9202
9203 * makefile.w32-in: Update dependencies.
9204
8e1f5610
CS
92052011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9206
9207 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9208 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9209
7025ee00 92102011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9211
cdfa6eab
PE
9212 Fix some integer overflow issues, such as string length overflow.
9213
06d6db33
PE
9214 * insdel.c (count_size_as_multibyte): Check for string overflow.
9215
2b4560a8
PE
9216 * character.c (lisp_string_width): Check for string overflow.
9217 Use EMACS_INT, not int, for string indexes and lengths; in
9218 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9219 the resulting string length overflows an EMACS_INT; instead,
9220 report a string overflow if no precision given. When checking for
9221 precision exhaustion, use a check that cannot possibly have
9222 integer overflow. (Bug#8675)
9223 * character.h (lisp_string_width): Adjust to new signature.
9224
cb93f9be
PE
9225 * alloc.c (string_overflow): New function.
9226 (Fmake_string): Use it. This doesn't change behavior, but saves
9227 a few bytes and will simplify future changes.
9228 * character.c (string_escape_byte8): Likewise.
9229 * lisp.h (string_overflow): New decl.
9230
1a1f3366
PE
9231 Fixups, following up to the user-interface timestamp change.
9232 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9233 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9234 * msdos.c (mouse_get_pos): Likewise.
9235 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9236 * w32gui.h (Time): Define by including "systime.h" rather than by
9237 declaring it ourselves. (Bug#8664)
9238
d4e3e4d3
PE
9239 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9240 * image.c (clear_image_cache): Likewise.
9241
f6a24d19
PE
9242 * term.c (term_mouse_position): Don't assume time_t wraparound.
9243
08dc5ae6
PE
9244 Be more systematic about user-interface timestamps.
9245 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9246 and sometimes 'EMACS_UINT', to represent these timestamps.
9247 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9248 This makes the code easier to follow, and makes it easier to catch
9249 integer overflow bugs such as Bug#8664.
9250 * frame.c (Fmouse_position, Fmouse_pixel_position):
9251 Use Time, not unsigned long, for user-interface timestamps.
9252 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9253 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9254 * keyboard.h (last_event_timestamp): Likewise.
9255 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
9256 * menu.h (xmenu_show): Likewise.
9257 * term.c (term_mouse_position): Likewise.
9258 * termhooks.h (struct input_event.timestamp): Likewise.
9259 (struct terminal.mouse_position_hook): Likewise.
9260 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
9261 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
9262 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
9263 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
9264 what it was before.
9265 * menu.h, termhooks.h: Include "systime.h", for Time.
9266
8e55734a
PE
9267 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
9268 Don't assume that the difference between two unsigned long values
9269 can fit into an integer. At this point, we know button_down_time
9270 <= event->timestamp, so the difference must be nonnegative, so
9271 there's no need to cast the result if double-click-time is
9272 nonnegative, as it should be; check that it's nonnegative, just in
9273 case. This bug is triggered when events are more than 2**31 ms
86db42d2 9274 apart (about 25 days). (Bug#8664)
8e55734a 9275
841f1b75 9276 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 9277 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 9278
3e26f69c
PE
9279 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
9280 that always fit in int. Use a sentinel instead of a counter, to
9281 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
9282 * frame.h (struct frame): Use int for menu_bar_items_used
9283 instead of EMACS_INT, since it always fits in int.
3e26f69c 9284
5cc152c0
PE
9285 * menu.c (grow_menu_items): Check for int overflow.
9286
d89eb65e
PE
9287 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
9288
5235bd3e
PE
9289 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
9290 Before, the code was not consistent. These values cannot exceed
9291 2**31 - 1 so there's no need to make them unsigned.
9292 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
9293 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
9294 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
9295 as modifiers.
9296 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
9297
bc827e23
PE
9298 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
9299 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
9300 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
9301 presumably because the widths might not match.
9302
78eb494e
PE
9303 * window.c (size_window): Avoid needless test at loop start.
9304
04f2d78b
CB
93052011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
9306
9307 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
9308
d2fc7e3d 93092011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
9310
9311 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
9312
d2fc7e3d 93132011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
9314
9315 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
9316 `width' to `bar_area_x' and `bar_area_width', respectively.
9317 (x_scroll_run): Take account of fringe background extension.
9318
04f2d78b
CB
9319 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
9320 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
9321 `bar_area_width', respectively.
9322 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
9323 background extension.
9324
79b70037
GM
93252011-05-10 Jim Meyering <meyering@redhat.com>
9326
9327 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
9328
2f142cc5
JB
93292011-05-10 Juanma Barranquero <lekktu@gmail.com>
9330
9331 * image.c (Finit_image_library): Return t for built-in image types,
9332 like pbm and xbm. (Bug#8640)
9333
57679c86
AS
93342011-05-09 Andreas Schwab <schwab@linux-m68k.org>
9335
9336 * w32menu.c (set_frame_menubar): Fix submenu allocation.
9337
888c9e86
EZ
93382011-05-07 Eli Zaretskii <eliz@gnu.org>
9339
b0512a1d
EZ
9340 * w32console.c (Fset_screen_color): Doc fix.
9341 (Fget_screen_color): New function.
9342 (syms_of_ntterm): Defsubr it.
9343
7285dc67
EZ
9344 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
9345 unlink the temporary file if Fcall_process didn't create it in the
9346 first place.
9347 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
9348 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
9349 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
9350 cue to call_process_cleanup not to close that handle.
9351
4d3fcc8e
BK
93522011-05-07 Ben Key <bkey76@gmail.com>
9353
9354 * makefile.w32-in: The bootstrap-temacs rule now makes use of
9355 one of two shell specific rules, either bootstrap-temacs-CMD or
9356 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
9357 to the previous implementation of the bootstrap-temacs rule.
9358 The bootstrap-temacs-CMD rule is similar to the previous
9359 implementation of the bootstrap-temacs rule except that it
9360 makes use of the ESC_CFLAGS variable instead of the CFLAGS
9361 variable.
9362
9363 These changes, along with some changes to nt/configure.bat,
9364 nt/gmake.defs, and nt/nmake.defs, are required to extend my
9365 earlier fix to add support for --cflags and --ldflags options
9366 that include quotes so that it works whether make uses cmd or
9367 sh as the shell.
9368
b4289b64
MA
93692011-05-06 Michael Albinus <michael.albinus@gmx.de>
9370
9371 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
9372 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
9373 is a constant.
9374 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
9375 a string. Handle both cases.
9376 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
9377 (Fdbus_register_method): Use Qinvalid_function.
9378
af4c0e28
JB
93792011-05-06 Juanma Barranquero <lekktu@gmail.com>
9380
9381 * makefile.w32-in: Update dependencies.
9382 (LISP_H): Add inttypes.h and stdin.h.
9383 (PROCESS_H): Add unistd.h.
9384
c51453d9
EZ
93852011-05-06 Eli Zaretskii <eliz@gnu.org>
9386
9387 * lread.c: Include limits.h (fixes the MS-Windows build broken by
9388 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
9389
8ff0ac3c 93902011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 9391
4c4b566b
PE
9392 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
9393
aab2b9b5
PE
9394 * term.c (vfatal): Remove stray call to va_end.
9395 It's not needed and the C Standard doesn't allow it here anyway.
9396
c378da0b
PE
9397 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
9398 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
9399
288b08c7
PE
9400 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
9401 bytes.
9402
e3601888
PE
9403 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
9404
db6c0e74
PE
9405 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9406
dd5963ea
PE
9407 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
9408
88c9450f
PE
9409 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
9410
2f9442b8
PE
9411 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
9412
c032b5f8
PE
9413 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
9414 * charset.c (Fdefine_charset_internal): Don't initialize
9415 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 9416 32-bit int (Bug#8600).
a108c10b
PE
9417
9418 * lread.c (read_integer): Be more consistent with string-to-number.
9419 Use string_to_number to do the actual conversion; this avoids
9420 rounding errors and fixes some other screwups. Without this fix,
9421 for example, #x1fffffffffffffff was misread as -2305843009213693952.
9422 (digit_to_number): Move earlier, for benefit of read_integer.
9423 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 9424 not a digit in any supported base. (Bug#8602)
a108c10b 9425
ad5f9eea
PE
9426 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
9427
aec1708a
PE
9428 * dispnew.c (scrolling_window): Return 1 if we scrolled,
9429 to match comment at start of function. This also removes a
9430 GCC warning about overflow in a 32+64-bit port.
9431
47be4ab5
PE
9432 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
9433
371cac43
PE
9434 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
9435 Reported by Stefan Monnier in
9436 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
9437 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9438 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 9439
d01a7826
PE
9440 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
9441 (EMACS_UINTPTR): Likewise, with uintptr_t.
9442
7fd47d5c
PE
9443 * lisp.h: Prefer 64-bit EMACS_INT if available.
9444 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
9445 on 32-bit hosts that have 64-bit int, so that they can access
9446 large files.
122b0c86
PE
9447 However, temporarily disable this change unless the temporary
9448 symbol WIDE_EMACS_INT is defined.
7fd47d5c 9449
8727937b
PE
9450 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
9451
8ac068ac
PE
9452 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
9453 This removes an assumption that EMACS_INT and long are the same
9454 width as pointers. The assumption is true for Emacs porting targets
9455 now, but we want to make other targets possible.
9456 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
9457 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
9458 In the rest of the code, change types of integers that hold casted
9459 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
9460 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
9461 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
9462 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
9463 No need to cast type when ORing.
9464 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
9465 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
9466 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
9467 assume EMACS_INT is the same width as char *.
9468 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
9469 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
9470 Remove no-longer-needed casts.
9471 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
9472 (xg_tool_bar_help_callback, xg_make_tool_item):
9473 Use EMACS_INTPTR to hold an integer
9474 that will be cast to void *; this can avoid a GCC warning
9475 if EMACS_INT is not the same width as void *.
9476 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
9477 * xdisp.c (display_echo_area_1, resize_mini_window_1):
9478 (current_message_1, set_message_1):
9479 Use a local to convert to proper width without a cast.
9480 * xmenu.c (dialog_selection_callback): Likewise.
9481
ede49d71
PE
9482 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
9483 Also, don't assume VALBITS / RAND_BITS is less than 5,
9484 and don't rely on undefined behavior when shifting a 1 left into
9485 the sign bit.
9486 * lisp.h (get_random): Change signature to match.
9487
2f30ecd0
PE
9488 * lread.c (hash_string): Use size_t, not int, for hash computation.
9489 Normally we prefer signed values; but hashing is special, because
9490 it's better to use unsigned division on hash table sizes so that
9491 the remainder is nonnegative. Also, size_t is the natural width
9492 for hashing into memory. The previous code used 'int', which doesn't
9493 retain enough info to hash well into very large tables.
9494 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
9495
2a866e7b
PE
9496 * dbusbind.c: Don't possibly lose pointer info when converting.
9497 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
9498 Use XPNTR rather than XHASH, so that the high-order bits of
9499 the pointer aren't lost when converting through void *.
9500
51639eac
PE
9501 * eval.c (Fautoload): Don't double-shift a pointer.
9502
92394119
PE
9503 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
9504
dbdb9a7c
JB
95052011-05-06 Juanma Barranquero <lekktu@gmail.com>
9506
9507 * gnutls.c (DEF_GNUTLS_FN):
9508 * image.c (DEF_IMGLIB_FN): Make function pointers static.
9509
db7a0b4f
AS
95102011-05-05 Andreas Schwab <schwab@linux-m68k.org>
9511
9512 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
9513 marker. (Bug#8610)
9514
cd394be1 95152011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
9516
9517 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
9518 New version that can reserve upto 2GB of heap space.
9519
f7ff1b0f 95202011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
9521
9522 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
9523
639c109b
TZ
95242011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
9525
9526 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
9527 `gnutls_certificate_set_x509_key_file'.
9528
d2127135
JB
95292011-05-05 Juanma Barranquero <lekktu@gmail.com>
9530
9531 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
9532 Update dependencies.
9533
e968f4f3
JB
95342011-05-04 Juanma Barranquero <lekktu@gmail.com>
9535
9536 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
9537 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
9538 Remove unused parameter `fildes'.
9539 * process.c (read_process_output, send_process): Don't pass it.
9540
84d358f0
JB
95412011-05-04 Juanma Barranquero <lekktu@gmail.com>
9542
9543 Fix previous change: the library cache is defined in w32.c.
9544 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
9545 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
9546
0898ca10
JB
95472011-05-04 Juanma Barranquero <lekktu@gmail.com>
9548
9549 Implement dynamic loading of GnuTLS on Windows.
9550
9551 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
9552 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
9553 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9554 Declare.
9555
9556 * gnutls.c (Qgnutls_dll): Define.
9557 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
9558 (gnutls_*): Declare function pointers.
9559 (init_gnutls_functions): New function to initialize function pointers.
9560 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
9561 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
9562 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
9563 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
9564 (emacs_gnutls_write, emacs_gnutls_read)
9565 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
9566 (Fgnutls_available_p): New function.
9567 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
9568 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
9569 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
9570
9571 * image.c: Include w32.h.
9572 (Vimage_type_cache): Delete.
9573 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
9574 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
9575 (w32_delayed_load): Move to w32.c.
9576
9577 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
9578
9579 * w32.c (QCloaded_from, Vlibrary_cache): Define.
9580 (w32_delayed_load): Move from image.c. When loading a library, record
9581 its filename in the :loaded-from property of the library id.
9582 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
9583 Initialize and staticpro them.
9584 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
9585
9586 * process.c: Include lisp.h before w32.h, not after.
9587 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
9588 instead of gnutls_record_check_pending.
9589
9590 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
9591
ff4de4aa
TZ
95922011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
9593
9594 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
9595 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
9596 as passed in.
9597
abe95abb
JD
95982011-05-03 Jan Djärv <jan.h.d@swipnet.se>
9599
9600 * xterm.c (x_set_frame_alpha): Do not set property on anything
9601 else than FRAME_X_OUTER_WINDOW (Bug#8608).
9602
e16e55d4
JB
96032011-05-02 Juanma Barranquero <lekktu@gmail.com>
9604
9605 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
9606
bafcf6a5
JB
96072011-05-02 Juanma Barranquero <lekktu@gmail.com>
9608
9609 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
9610 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
9611 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
9612 (gnutls_global_initialized, Qgnutls_bootprop_priority)
9613 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
9614 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9615 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9616 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9617 (Qgnutls_bootprop_callbacks_verify): Make static.
9618
e7a6747f
AS
96192011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9620
19ed11ba
AS
9621 * callproc.c: Indentation fixup.
9622
e7a6747f 9623 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9624 (wait_for_termination, interruptible_wait_for_termination):
9625 Move after wait_for_termination_1.
e7a6747f 9626
1ef14cb4
LMI
96272011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9628
9629 * sysdep.c (interruptible_wait_for_termination): New function
9630 which is like wait_for_termination, but allows keyboard
9631 interruptions.
9632
9633 * callproc.c (Fcall_process): Add (:file "file") as an option for
9634 the STDOUT buffer.
9635 (Fcall_process_region): Ditto.
9636
330d880c
EZ
96372011-04-30 Eli Zaretskii <eliz@gnu.org>
9638
8db90b73
EZ
9639 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9640 rather than `XVECTOR (FOO)->size'.
9641
330d880c
EZ
9642 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9643 inttypes.h, as a gnulib replacement is used if it not available in
9644 system headers.
9645
15cbd324
EZ
96462011-04-21 Eli Zaretskii <eliz@gnu.org>
9647
9648 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9649 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9650 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9651
9652 * coding.c (coding_alloc_by_realloc): Error out if destination
9653 will grow beyond MOST_POSITIVE_FIXNUM.
9654 (decode_coding_emacs_mule): Abort if there isn't enough place in
9655 charbuf for the composition carryover bytes. Reserve an extra
9656 space for up to 2 characters produced in a loop.
9657 (decode_coding_iso_2022): Abort if there isn't enough place in
9658 charbuf for the composition carryover bytes.
9659
96602011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9661
ae940cca
EZ
9662 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9663 aborting when %lld or %lll format is passed.
9664 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9665 %llo or %llx format is passed. (Bug#8545)
9666
03ab8921
EZ
9667 * window.c (window_scroll_line_based): Use a marker instead of
9668 simple variables to record original value of point. (Bug#7952)
9669
afda1437
EZ
9670 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9671 produced by %s or %c overflows available buffer space. (Bug#8545)
9672
f76dee0c
PE
96732011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9674
9675 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9676 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9677
fdc5744d
JB
96782011-04-28 Juanma Barranquero <lekktu@gmail.com>
9679
9680 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9681
638f053a
JB
96822011-04-28 Juanma Barranquero <lekktu@gmail.com>
9683
9684 * keyboard.c (Qdelayed_warnings_hook): Define.
9685 (command_loop_1): Run `delayed-warnings-hook'
9686 if Vdelayed_warnings_list is non-nil.
9687 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9688 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9689
d178f871
EZ
96902011-04-28 Eli Zaretskii <eliz@gnu.org>
9691
9692 * doprnt.c (doprnt): Don't return value smaller than the buffer
9693 size if the message was truncated. (Bug#8545).
9694
b124fd93
JB
96952011-04-28 Juanma Barranquero <lekktu@gmail.com>
9696
9697 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9698 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9699
e810457d
PE
97002011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9701
9702 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9703
ea51cceb
JB
97042011-04-27 Juanma Barranquero <lekktu@gmail.com>
9705
9706 * makefile.w32-in: Update dependencies.
9707
94dcfacf
EZ
97082011-04-27 Eli Zaretskii <eliz@gnu.org>
9709
9710 Improve `doprnt' and its usage. (Bug#8545)
9711 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9712 `format_end'. Remove support for %l as a conversion specifier.
9713 Don't use xrealloc. Improve diagnostics when the %l size modifier
9714 is used. Update the commentary.
9715
9716 * eval.c (verror): Simplify calculation of size_t.
9717
9718 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9719 messages.
9720
f61f41d7
PE
97212011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9722
9723 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9724 change.
9725
96fb4434
PE
97262011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9727
9728 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9729 This makes this file independent of the recent pseudovector change.
9730
671875da 97312011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9732
69e9b5a3
PE
9733 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9734
b5f869a7 9735 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9736 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9737 Remove unused local.
c8926152 9738 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9739
841a1577 9740 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9741 GCC 4.6.0 optimizes based on type-based alias analysis.
9742 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9743 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9744 != &v->size, and therefore "v->size = 1; b->size = 2; return
9745 v->size;" must therefore return 1. This assumption is incorrect
9746 for Emacs, since it type-puns struct Lisp_Vector * with many other
9747 types. To fix this problem, this patch adds a new type struct
f904488f 9748 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9749 and pseudovectors, and helps optimizing compilers not get fooled
9750 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9751 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9752 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9753 the size member.
eab3844f
PE
9754 (XSETPVECTYPE): Rewrite in terms of new macro.
9755 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9756 This is a bit clearer, and further avoids the possibility of
9757 undesirable aliasing.
9758 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9759 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9760 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9761 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9762 (ASIZE): Now uses header.size rather than size.
9763 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9764 to avoid the hassle of writing XVECTOR (foo)->header.size.
9765 (struct vectorlike_header): New type.
eab3844f
PE
9766 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9767 object, to help avoid aliasing.
9768 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9769 (SUBRP): Likewise, since Lisp_Subr is a special case.
9770 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9771 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9772 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9773 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9774 changed to be "header.size" and "header.next".
9775 * buffer.h (struct buffer): Likewise.
9776 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9777 * frame.h (struct frame): Likewise.
9778 * process.h (struct Lisp_Process): Likewise.
9779 * termhooks.h (struct terminal): Likewise.
9780 * window.c (struct save_window_data, struct saved_window): Likewise.
9781 * window.h (struct window): Likewise.
9782 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9783 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9784 * buffer.c (init_buffer_once): Likewise.
9785 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9786 special case.
9787 * process.c (Fformat_network_address): Use local var for size,
9788 for brevity.
9789
0df1eac5
PE
9790 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9791
847ab9d1 9792 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9793 * data.c (atof): Remove decl; no longer used or needed.
9794 (digit_to_number): Move to lread.c.
9795 (Fstring_to_number): Use new string_to_number function, to be
9796 consistent with how the Lisp reader treats infinities and NaNs.
9797 Do not assume that floating-point numbers represent EMACS_INT
9798 without losing information; this is not true on most 64-bit hosts.
9799 Avoid double-rounding errors, by insisting on integers when
9800 parsing non-base-10 numbers, as the documentation specifies.
9801 * lisp.h (string_to_number): New decl, replacing ...
9802 (isfloat_string): Remove.
bc0a5c13 9803 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9804 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9805 appears to have been a coding error. Similarly, do not accept
9806 strings like +-1e0 as floating point numbers. Do not report
9807 overflow for integer overflows unless the base is not 10 which
9808 means we have no simple and reliable way to continue.
9809 Break out the floating-point parsing into a new
9810 function string_to_number, so that Fstring_to_number parses
9811 floating point numbers consistently with the Lisp reader.
04f2d78b 9812 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9813 (E_CHAR, EXP_INT): Remove, replacing with ...
9814 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9815 (string_to_number): New function, replacing isfloat_string.
9816 This function checks for valid syntax and produces the resulting
9817 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9818 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9819 so that overflow for non-base-10 numbers is reported only when
9820 there's no portable and simple way to convert to floating point.
452f4150 9821
67769ffc
PE
9822 * textprop.c (set_text_properties_1): Rewrite for clarity,
9823 and to avoid GCC warning about integer overflow.
9824
c20db43f
PE
9825 * intervals.h (struct interval): Use EMACS_INT for members
9826 where EMACS_UINT might cause problems. See
9827 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9828 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9829 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9830 All uses changed.
37aa2f85
PE
9831 (offset_intervals): Tell GCC not to worry about length overflow
9832 when negating a negative length.
c20db43f 9833
2538aa2f
PE
9834 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9835 (overrun_check_free): Likewise.
9836
f2d3008d
PE
9837 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9838 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9839 word size.
9840
ec8df744
PE
9841 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9842 (gnutls_make_error): Rename local to avoid shadowing.
9843 (gnutls_emacs_global_deinit): ifdef out; not used.
9844 (Fgnutls_boot): Use const for pointer to readonly storage.
9845 Comment out unused local. Fix pointer signedness problems.
9846
640ee02d
PE
9847 * lread.c (openp): Don't stuff size_t into an 'int'.
9848 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9849 about possible signed overflow.
9850
6048fb2a
PE
9851 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9852 (GDK_KEY_g): Don't define if already defined.
9853 (xg_prepare_tooltip): Avoid pointer signedness problem.
9854 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9855
fa3c87e1
PE
9856 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9857 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9858
2172544b
PE
9859 * xfns.c (Fx_window_property): Simplify a bit,
9860 to make a bit faster and to avoid GCC 4.6.0 warning.
9861 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9862
9b821a21
PE
9863 * fns.c (internal_equal): Don't assume size_t fits in int.
9864
3c616cfa
PE
9865 * alloc.c (compact_small_strings): Tighten assertion a little.
9866
c2982e87
PE
9867 Replace pEd with more-general pI, and fix some printf arg casts.
9868 * lisp.h (pI): New macro, generalizing old pEd macro to other
9869 conversion specifiers. For example, use "...%"pI"d..." rather
9870 than "...%"pEd"...".
9871 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9872 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9873 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9874 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9875 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9876 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9877 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9878 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9879 64-bit hosts.
9880 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9881 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9882 * print.c (safe_debug_print, print_object): Likewise.
9883 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9884 to int.
6f04d126
PE
9885 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9886 avoiding the 0 flag, which is not portable.
c2982e87
PE
9887 * process.c (Fmake_network_process): Use pI to avoid cast.
9888 * region-cache.c (pp_cache): Likewise.
9889 * xdisp.c (decode_mode_spec): Likewise.
9890 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9891 behavior on 64-bit hosts with printf arg.
6f04d126 9892 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9893 (x_stop_queuing_selection_requests): Likewise.
9894 (x_get_window_property): Don't truncate byte count to an 'int'
9895 when tracing.
0b432f21 9896
5e073ec7
PE
9897 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9898 here, since it parses constructs like leading '-' and spaces,
9899 which are not wanted; and it overflows with large numbers.
9900 Instead, simply match F[0-9]+, which is what is wanted anyway.
9901
36372bf9
PE
9902 * alloc.c: Remove unportable assumptions about struct layout.
9903 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9904 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9905 (allocate_vectorlike, make_pure_vector): Use the new macros,
9906 plus offsetof, to remove unportable assumptions about struct layout.
9907 These assumptions hold on all porting targets that I know of, but
9908 they are not guaranteed, they're easy to remove, and removing them
9909 makes further changes easier.
9910
0b432f21
PE
9911 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9912 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9913 (string_overrun_cookie): Now const. Use initializers that
9914 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9915 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9916 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9917 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9918 multiple of sizeof (EMACS_INT); it need not be, if
9919 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9920 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9921
895009e1
JB
99222011-04-26 Juanma Barranquero <lekktu@gmail.com>
9923
9924 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9925
6a7a1b0b
TZ
99262011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9927
9928 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9929 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9930 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9931
841a1577 99322011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9933
9934 * lisp.h (Qdebug): List symbol.
895009e1 9935 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9936 * keyboard.c (debug-on-event): New variable.
9937 (handle_user_signal): Break into debugger when debug-on-event
9938 matches the current signal symbol.
9939
f2d3ba6f
DN
99402011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9941
9942 * alloc.c (check_sblock, check_string_bytes)
9943 (check_string_free_list): Convert to standard C.
9944
42ce4c63
TZ
99452011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9946
9947 * w32.c (emacs_gnutls_push): Fix typo.
9948
825cd63c
EZ
99492011-04-25 Eli Zaretskii <eliz@gnu.org>
9950
fb11d64d
EZ
9951 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9952 "cast to pointer from integer of different size".
9953
825cd63c
EZ
9954 Improve doprnt and its use in verror. (Bug#8545)
9955 * doprnt.c (doprnt): Document the set of format control sequences
9956 supported by the function. Use SAFE_ALLOCA instead of always
9957 using `alloca'.
9958
9959 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9960 is one byte too soon. Don't use xrealloc; instead xfree and
9961 xmalloc anew.
9962
e061a11b
TZ
99632011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9964
9965 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9966 callbacks stage.
9967
9968 * gnutls.c: Renamed global_initialized to
9969 gnutls_global_initialized. Added internals for the
9970 :verify-hostname-error, :verify-error, and :verify-flags
9971 parameters of `gnutls-boot' and documented those parameters in the
9972 docstring. Start callback support.
9173deec
JB
9973 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9974 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9975 on error. Return error code.
e061a11b
TZ
9976 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9977 (emacs_gnutls_read): Likewise.
9978 (Fgnutls_boot): Return handshake error code.
9979 (emacs_gnutls_handle_error): New function.
9980 (wsaerror_to_errno): Likewise.
9981
9982 * w32.h (emacs_gnutls_pull): Add prototype.
9983 (emacs_gnutls_push): Likewise.
9984
9985 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9986 (emacs_gnutls_push): Likewise.
9987
99882011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9989
9990 * process.c (wait_reading_process_output): Check if GnuTLS
9991 buffered some data internally if no FDs are set for TLS
9992 connections.
9993
9994 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9995 (LIBS): Link to USER_LIBS.
9996 ($(BLD)/gnutls.$(0)): New target.
9997
fa6996bc
EZ
99982011-04-24 Eli Zaretskii <eliz@gnu.org>
9999
eb35682e
EZ
10000 * xdisp.c (handle_single_display_spec): Rename the
10001 display_replaced_before_p argument into display_replaced_p, to
10002 make it consistent with the commentary. Fix typos in the
10003 commentary.
10004
e2ad650c
EZ
10005 * textprop.c (syms_of_textprop): Remove dead code.
10006 (copy_text_properties): Delete obsolete commentary about an
10007 interface that was deleted long ago. Fix typos in the description
10008 of arguments.
10009
1b2de274
EZ
10010 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10011 to changes in oldXMenu/XMenu.h from 2011-04-16.
10012 <menu_help_message, prev_menu_help_message>: Constify.
10013 (IT_menu_make_room): menu->help_text is now `const char **';
10014 adjust.
10015
10016 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10017 to changes in oldXMenu/XMenu.h from 2011-04-16.
10018 (struct XMenu): Declare `help_text' `const char **'.
10019
10020 * xfaces.c <Qunspecified>: Make extern again.
10021
10022 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10023 required by POSIX.
1b2de274 10024
762b15be
EZ
10025 * doc.c (get_doc_string): Improve the format passed to `error'.
10026
10027 * doprnt.c (doprnt): Improve commentary.
10028
10029 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10030
10031 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10032 them with etags.
10033
f1052e5d
EZ
10034 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10035 changes in globals.h immediately force recompilation.
762b15be
EZ
10036 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10037 $(CURDIR)/s/ms-w32.h.
10038 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10039
fa6996bc
EZ
10040 * character.c (Fchar_direction): Function deleted.
10041 (syms_of_character): Don't defsubr it.
10042 <char-direction-table>: Deleted.
10043
e6c3da20
EZ
100442011-04-23 Eli Zaretskii <eliz@gnu.org>
10045
10046 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10047 * doprnt.c: Include limits.h.
10048 (SIZE_MAX): New macro.
04f2d78b
CB
10049 (doprnt): Return a size_t value. 2nd arg is now size_t.
10050 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10051 Improve overflow protection. Support `l' modifier for integer
10052 conversions. Support %l conversion. Don't assume an EMACS_INT
10053 argument for integer conversions and for %c.
10054
10055 * lisp.h (doprnt): Restore prototype.
10056
10057 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10058 $(SRC)/character.h.
10059
10060 * Makefile.in (base_obj): Add back doprnt.o.
10061
10062 * deps.mk (doprnt.o): Add back prerequisites.
10063 (callint.o): Depend on character.h.
10064
10065 * eval.c (internal_lisp_condition_case): Include the handler
10066 representation in the error message.
10067 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10068 when breaking from the loop.
10069
10070 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10071
10072 * callint.c (Fcall_interactively): When displaying error message
10073 about invalid control letter, pass the character's codepoint, not
10074 a pointer to its multibyte form. Improve display of the character
10075 in octal and display also its hex code.
10076
10077 * character.c (char_string): Use %x to display the (unsigned)
10078 codepoint of an invalid character, to avoid displaying a bogus
10079 negative value.
10080
10081 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10082 `error', not SYMBOL_NAME itself.
10083
10084 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10085 character arguments to `error'.
10086
10087 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10088 to `error' in error message about FINAL_CHAR argument. Make sure
10089 FINAL_CHAR is a character, and use %c when it is passed as
10090 argument to `error'.
10091
4ffd0d6b 100922011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10093
10094 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10095
10096 * w32.c: Include <time.h>.
10097 (sys_localtime): New function.
10098
4ffd0d6b 100992011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10100
10101 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10102
4ffd0d6b 10103 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10104
4ffd0d6b 101052011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10106
4ffd0d6b
GM
10107 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10108 zombies (Bug#8467).
aac0c6e3 10109
04c56954
EZ
101102011-04-19 Eli Zaretskii <eliz@gnu.org>
10111
10112 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10113 gl_state.e_property when gl_state.object is Qt.
10114
10115 * insdel.c (make_gap_larger): Remove limitation of buffer size
10116 to <= INT_MAX.
10117
16a43933
CY
101182011-04-18 Chong Yidong <cyd@stupidchicken.com>
10119
10120 * xdisp.c (lookup_glyphless_char_display)
10121 (produce_glyphless_glyph): Handle cons cell entry in
10122 glyphless-char-display.
10123 (Vglyphless_char_display): Document it.
10124
10125 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10126 glyphless-char-display.
10127
4581706e
CY
101282011-04-17 Chong Yidong <cyd@stupidchicken.com>
10129
10130 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10131
10132 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10133
10134 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10135 definition for no-X builds.
10136
4887c6e2 101372011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10138
fd35b6f9
PE
10139 Static checks with GCC 4.6.0 and non-default toolkits.
10140
5c1ccb01
PE
10141 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10142
006c5daa
PE
10143 * process.c (keyboard_bit_set): Define only if SIGIO.
10144 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10145 (send_process): Repair possible setjmp clobbering.
10146
efc736d3
PE
10147 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10148
4e2fe2e6
PE
10149 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10150
f97334a2
PE
10151 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10152
4e75f29d
PE
10153 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10154 Define only if needed.
10155
90efadd1
PE
10156 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10157 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10158 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10159
3c647824
PE
10160 * dispextern.h (struct redisplay_interface): Rename param
10161 to avoid shadowing.
e264f262 10162 * termhooks.h (struct terminal): Likewise.
761383f4 10163 * xterm.c (xembed_send_message): Likewise.
3c647824 10164
b58c5c4a
PE
10165 * insdel.c (make_gap_smaller): Define only if
10166 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10167
cad59032
PE
10168 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10169 it.
10170
c339dc2e
PE
10171 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10172 so that we aren't warned about unused symbols.
10173
91a3e27b
PE
10174 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10175
399c71d3 10176 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10177
8ffc96f5
PE
10178 * xfns.c (x_real_positions): Mark locals as initialized.
10179
eef9bc79
PE
10180 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10181
098db9dd
PE
10182 * xterm.c: Fix problems found by static analysis with other toolkits.
10183 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10184 (x_dispatch_event): Declare static if USE_GTK, and
10185 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10186 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10187 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10188 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10189 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10190
eb18f6cc
PE
10191 * xmenu.c (menu_help_callback): Pointer type fixes.
10192 Use const pointers when pointing at readonly data. Avoid pointer
10193 signedness clashes.
10194 (FALSE): Remove unused macro.
10195 (update_frame_menubar): Remove unused decl.
10196
1fe72bf8
PE
10197 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10198
60d9e1db
PE
10199 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10200 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10201 (single_menu_item): Rename local to avoid shadowing.
10202
39261c26
PE
10203 * keyboard.c (make_lispy_event): Remove unused local var.
10204
018c5e19
PE
10205 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10206 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10207
63d2b86e
PE
10208 * bitmaps: Change bitmaps from unsigned char back to the X11
10209 compatible char. Avoid the old compiler warnings about
10210 out-of-range initializers by using, for example, '\xab' rather
10211 than 0xab.
10212
aefd87e1
PE
10213 * xgselect.c (xgselect_initialize): Check vs interface
10214 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10215
bf501fb9
PE
10216 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10217
e9829fdf
PE
10218 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10219 to read-only memory.
10220
1086c095
PE
10221 * fns.c (vector): Remove; this old hack is no longer needed.
10222
2baccd04 10223 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10224 Remove unused var.
dde42981 10225 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10226
72391843 10227 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10228
436c16df 10229 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10230 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10231 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10232
92bb796d 10233 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10234 (x_term_init): Remove local to avoid shadowing.
92bb796d 10235
764430a3 10236 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10237
10238 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10239 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10240
d1dfb56c
EZ
102412011-04-16 Eli Zaretskii <eliz@gnu.org>
10242
c4354cb4
EZ
10243 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10244
d1dfb56c
EZ
10245 Fix regex.c, syntax.c and friends for buffers > 2GB.
10246 * syntax.h (struct gl_state_s): Declare character position members
10247 EMACS_INT.
10248
10249 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10250
04f2d78b
CB
10251 * textprop.c (verify_interval_modification, interval_of):
10252 Declare arguments EMACS_INT.
d1dfb56c
EZ
10253
10254 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10255 EMACS_INT.
10256
10257 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
10258
10259 * indent.c (Fvertical_motion): Local variable it_start is now
10260 EMACS_INT.
10261
10262 * regex.c (re_match, re_match_2, re_match_2_internal)
10263 (bcmp_translate, regcomp, regexec, print_double_string)
10264 (group_in_compile_stack, re_search, re_search_2, regex_compile)
10265 (re_compile_pattern, re_exec): Declare arguments and local
10266 variables `size_t' and `ssize_t' and return values `regoff_t', as
10267 appropriate.
10268 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
10269 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
10270 <compile_stack_type>: `size' and `avail' are now `size_t'.
10271
10272 * regex.h <regoff_t>: Use ssize_t, not int.
10273 (re_search, re_search_2, re_match, re_match_2): Arguments that
10274 specify buffer/string position and length are now ssize_t and
10275 size_t. Return type is regoff_t.
10276
613052cd
BK
102772011-04-16 Ben Key <bkey76@gmail.com>
10278
10279 * nsfont.m: Fixed bugs in ns_get_family and
10280 ns_descriptor_to_entity that were caused by using free to
10281 deallocate memory blocks that were allocated by xmalloc (via
10282 xstrdup). This caused Emacs to crash when compiled with
10283 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
10284 --enable-checking=xmallocoverrun). xfree is now used to
10285 deallocate these memory blocks.
10286
4170f62f 102872011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 10288
71b41406
PE
10289 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
10290
9587a89d
PE
10291 emacs_write: Accept and return EMACS_INT for sizes.
10292 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
10293 et seq.
10294 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
10295 Accept and return EMACS_INT.
10296 (emacs_gnutls_write): Return the number of bytes written on
10297 partial writes.
10298 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
10299 (emacs_read, emacs_write): Remove check for negative size, as the
10300 Emacs source code has been audited now.
9587a89d
PE
10301 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
10302 (emacs_read, emacs_write): Use it.
273a5f82
PE
10303 * process.c (send_process): Adjust to the new signatures of
10304 emacs_write and emacs_gnutls_write. Do not attempt to store
10305 a byte offset into an 'int'; it might overflow.
9587a89d 10306 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 10307
3e047f51
PE
10308 * sound.c: Don't assume sizes fit in 'int'.
10309 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 10310 Return EMACS_INT, not int.
3e047f51 10311 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
10312 Accept EMACS_INT, not int.
10313 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
10314 record read return values.
10315
cc39a9db
BK
103162011-04-15 Ben Key <bkey76@gmail.com>
10317
c9d0ec6d
JB
10318 * keyboard.c (Qundefined): Don't declare static since it is used
10319 in nsfns.m.
10320 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
10321 static since they are used in nsfont.m.
cc39a9db 10322
6c60eb9f
SM
103232011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
10324
10325 * process.c (Qprocessp): Don't declare static.
10326 * lisp.h (Qprocessp): Declare again.
10327
7990b61a
JB
103282011-04-15 Juanma Barranquero <lekktu@gmail.com>
10329
10330 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
10331
5d4cb038
PE
103322011-04-14 Paul Eggert <eggert@cs.ucla.edu>
10333
8bd7b830 10334 Improve C-level modularity by making more things 'static'.
cd64ea1d 10335
e3b27b31
PE
10336 Don't publish debugger-only interfaces to other modules.
10337 * lisp.h (safe_debug_print, debug_output_compilation_hack):
10338 (verify_bytepos, count_markers): Move decls to the only modules
10339 that need them.
10340 * region-cache.h (pp_cache): Likewise.
10341 * window.h (check_all_windows): Likewise.
10342 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10343
5d4cb038
PE
10344 * sysdep.c (croak): Now static, if
10345 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
10346 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
10347
10348 * alloc.c (refill_memory_reserve): Now static if
10349 !defined REL_ALLOC || defined SYSTEM_MALLOC.
10350 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 10351
e87b6180
PE
10352 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
10353 Define only if USE_LUCID.
10354
ac64929e
PE
10355 * xrdb.c (x_customization_string, x_rm_string): Now static.
10356
6f37259d
PE
10357 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
10358 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
10359
1683e3ab
PE
10360 * xdisp.c (draw_row_with_mouse_face): Now static.
10361 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
10362
de9c2632
PE
10363 * window.h (check_all_windows): Mark externally visible.
10364
2b96acb7
PE
10365 * window.c (window_deletion_count): Now static.
10366
10367 * undo.c: Make symbols static if they're not exported.
10368 (last_undo_buffer, last_boundary_position, pending_boundary):
10369 Now static.
10370
50436f33
PE
10371 * textprop.c (interval_insert_behind_hooks): Now static.
10372 (interval_insert_in_front_hooks): Likewise.
10373
64520e5c
PE
10374 * term.c: Make symbols static if they're not exported.
10375 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
10376 (max_frame_lines, tty_set_terminal_modes):
10377 (tty_reset_terminal_modes, tty_turn_off_highlight):
10378 (get_tty_terminal): Now static.
10379 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
10380 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 10381 HAVE_WINDOW_SYSTEM.
64520e5c
PE
10382 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
10383 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
10384
1fa53021
PE
10385 * sysdep.c: Make symbols static if they're not exported.
10386 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
10387 Now static.
10388 (sigprocmask_set, full_mask): Remove; unused.
10389 (wait_debugging): Mark as visible.
10390 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
10391 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
10392
d4b43b22
PE
10393 * syntax.c (syntax_temp): Define only if !__GNUC__.
10394
b7c513d0
PE
10395 * sound.c (current_sound_device, current_sound): Now static.
10396
989b29ad
PE
10397 * search.c (searchbufs, searchbuf_head): Now static.
10398
13a55a78
PE
10399 * scroll.c (scroll_cost): Remove; unused.
10400 * dispextern.h (scroll_cost): Remove decl.
10401
de68a1fc
PE
10402 * region-cache.h (pp_cache): Mark as externally visible.
10403
40ccffa6
PE
10404 * process.c: Make symbols static if they're not exported.
10405 (process_tick, update_tick, create_process, chan_process):
10406 (Vprocess_alist, proc_buffered_char, datagram_access):
10407 (fd_callback_data, send_process_frame, process_sent_to): Now static.
10408 (deactivate_process): Mark defn as static, as well as decl.
10409 * lisp.h (create_process): Remove decl.
10410 * process.h (chan_process, Vprocess_alist): Remove decls.
10411
ad64fc97
PE
10412 * print.c: Make symbols static if they're not exported.
10413 (print_depth, new_backquote_output, being_printed, print_buffer):
10414 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
10415 (print_interval, print_number_index, initial_stderr_stream):
10416 Now static.
10417 * lisp.h (Fprinc): Remove decl.
10418 (debug_output_compilation_hack): Mark as externally visible.
10419
adddb265
PE
10420 * sysdep.c (croak): Move decl from here to syssignal.h.
10421 * syssignal.h (croak): Put it here, so the API can be checked when
10422 'croak' is called from dissociate_if_controlling_tty.
10423
1717ede2
PE
10424 * minibuf.c: Make symbols static if they're not exported.
10425 (minibuf_save_list, choose_minibuf_frame): Now static.
10426 * lisp.h (choose_minibuf_frame): Remove decl.
10427
fa5fb2bc
PE
10428 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
10429
1e3890d1
PE
10430 * lread.c: Make symbols static if they're not exported.
10431 (read_objects, initial_obarray, oblookup_last_bucket_number):
10432 Now static.
10433 (make_symbol): Remove; unused.
10434 * lisp.h (initial_obarray, make_symbol): Remove decls.
10435
8a1414fa
PE
10436 * keyboard.c: Make symbols static if they're not exported.
10437 (single_kboard, recent_keys_index, total_keys, recent_keys):
10438 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
10439 (this_single_command_key_start, echoing, last_auto_save):
10440 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
10441 (command_loop, echo_now, keyboard_init_hook, help_char_p):
10442 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
10443 (Vlispy_mouse_stem, double_click_count):
10444 Now static.
10445 (force_auto_save_soon): Define only if SIGDANGER.
10446 (ignore_mouse_drag_p): Now static if
10447 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
10448 (print_help): Remove; unused.
10449 (stop_character, last_timer_event): Mark as externally visible.
10450 * keyboard.h (ignore_mouse_drag_p): Declare only if
10451 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
10452 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
10453 * lisp.h (echoing): Remove decl.
10454 (force_auto_save_soon): Declare only if SIGDANGER.
10455 * xdisp.c (redisplay_window): Simplify code, to make it more
10456 obvious that ignore_mouse_drag_p is not accessed if !defined
10457 USE_GTK && !defined HAVE_NS.
10458
93ea6e8f
PE
10459 * intervals.c: Make symbols static if they're not exported.
10460 (merge_properties_sticky, merge_interval_right, delete_interval):
10461 Now static.
10462 * intervals.h (merge_interval_right, delete_interval): Remove decls.
10463
77382fcc
PE
10464 * insdel.c: Make symbols static if they're not exported.
10465 However, leave prepare_to_modify_buffer alone. It's never
10466 called from outside this function, but that appears to be a bug.
10467 (combine_after_change_list, combine_after_change_buffer):
4889fc82 10468 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
10469 (adjust_after_replace_noundo): Remove; unused.
10470 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 10471 (signal_before_change): Remove decls.
77382fcc 10472
9306c32e
PE
10473 * indent.c (val_compute_motion, val_vmotion): Now static.
10474
cd44d2eb
PE
10475 * image.c: Make symbols static if they're not exported.
10476 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
10477 if USE_GTK.
10478 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
10479 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
10480
ad9a7a06
PE
10481 * fringe.c (standard_bitmaps): Now static.
10482 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
10483
81626931
PE
10484 * frame.c: Make symbols static if they're not exported.
10485 (x_report_frame_params, make_terminal_frame): Now static.
10486 (get_frame_param): Now static, unless HAVE_NS.
10487 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
10488 (x_get_resource_string): Remove; not used.
10489 * frame.h (make_terminal_frame, x_report_frame_params):
10490 (x_get_resource_string); Remove decls.
10491 (x_fullscreen_adjust): Declare only if WINDOWSNT.
10492 * lisp.h (get_frame_param): Declare only if HAVE_NS.
10493
239f9db9
PE
10494 * font.c, fontset.c: Make symbols static if they're not exported.
10495 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
10496 (FACE_SUITABLE_FOR_CHAR_P): Use it.
10497 * font.c (font_close_object): Now static.
10498 * font.h (font_close_object): Remove.
10499 * fontset.c (FONTSET_OBJLIST): Remove.
10500 (free_realized_fontset) #if-0 the body, which does nothing.
10501 (face_suitable_for_char_p): #if-0, as it's never called.
10502 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
10503 * xfaces.c (face_at_string_position):
10504 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
10505 since 0 is always ASCII.
10506
dfcf3579
PE
10507 * fns.c (weak_hash_tables): Now static.
10508
5045092b
PE
10509 * fileio.c: Make symbols static if they're not exported.
10510 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
10511 (Vwrite_region_annotation_buffers): Now static.
10512
57a96f5c
PE
10513 * eval.c: Make symbols static if they're not exported.
10514 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
10515 * lisp.h (backtrace_list): Remove decl.
10516
35f08c38
PE
10517 * emacs.c: Make symbols static if they're not exported.
10518 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
10519 (fatal_error_code, fatal_error_signal_hook, standard_args):
10520 Now static.
10521 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
10522 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
10523 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
10524 * lisp.h (fatal_error_signal_hook): Remove decl.
10525 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
10526
f44bd759
PE
10527 * editfns.c: Move a (normally-unused) function to its only use.
10528 * editfns.c, lisp.h (get_operating_system_release): Remove.
10529 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
10530 worth the hassle of breaking this out.
10531
b532497d
PE
10532 * xterm.c: Make symbols static if they're not exported.
10533 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
10534 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
10535 (x_destroy_window, x_delete_display):
10536 Now static.
10537 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
10538 (x_mouse_leave): Remove; unused.
10539 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
10540 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
10541 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
10542 Remove decls.
10543 (x_mouse_leave): Declare only if WINDOWSNT.
10544 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
10545 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
10546 USE_X_TOOLKIT.
10547
1675728f
PE
10548 * ftxfont.c: Make symbols static if they're not exported.
10549 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
10550 HAVE_FREETYPE.
10551 * font.h (ftxfont_driver): Likewise.
10552
e4cebfca
PE
10553 * xfns.c: Make symbols static if they're not exported.
10554 (x_last_font_name, x_display_info_for_name):
10555 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
10556 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
10557 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
10558 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
10559 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
10560 (last_show_tip_args): Now static.
10561 (xic_defaut_fontset, xic_create_fontsetname): Define only if
10562 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
10563 (x_screen_planes): Remove; unused.
10564 * dispextern.h (x_screen_planes): Remove decl.
10565
5bf46f05
PE
10566 * dispnew.c: Make symbols static if they're not exported.
10567 * dispextern.h (redraw_garbaged_frames, scrolling):
10568 (increment_row_positions): Remove.
10569 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
10570 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
10571 Now static.
10572 (redraw_garbaged_frames): Remove; unused.
10573
435f4c28
PE
10574 * xfaces.c: Make symbols static if they're not exported.
10575 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
10576 Remove decls.
10577 * xterm.h (defined_color): Remove decls.
10578 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
10579 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
10580 (menu_face_changed_default, defined_color, free_realized_face):
10581 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
10582 (ascii_face_of_lisp_face): Remove; unused.
10583
8524aef3
PE
10584 * xdisp.c: Make symbols static if they're not exported.
10585 * dispextern.h (scratch_glyph_row, window_box_edges):
10586 (glyph_to_pixel_coords, set_cursor_from_row):
10587 (get_next_display_element, set_iterator_to_next):
10588 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
10589 (show_mouse_face): Remove decls
10590 * frame.h (message_buf_print): Likewise.
10591 * lisp.h (pop_message, set_message, check_point_in_composition):
10592 Likewise.
10593 * xterm.h (set_vertical_scroll_bar): Likewise.
10594 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
10595 (message_buf_print, scratch_glyph_row, displayed_buffer):
10596 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
10597 (get_next_display_element, show_mouse_face, window_box_edges):
10598 (frame_to_window_pixel_xy, check_point_in_composition):
10599 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
10600 (glyph_to_pixel_coords): Remove; unused.
10601
16390cd2
PE
10602 * dired.c (file_name_completion): Now static.
10603
10604 * dbusbind.c (xd_in_read_queued_messages): Now static.
10605
a25f4dfa
PE
10606 * lisp.h (circular_list_error, FOREACH): Remove; unused.
10607 * data.c (circular_list_error): Remove.
10608
14a9c8df
PE
10609 * commands.h (last_point_position, last_point_position_buffer):
10610 (last_point_position_window): Remove decls.
10611 * keyboard.c: Make these variables static.
10612
04f2d78b
CB
10613 * coding.h (coding, code_convert_region, encode_coding_gap):
10614 Remove decls.
74ab6df5
PE
10615 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10616 (iso_code_class, detect_coding, code_convert_region): Now static.
10617 (encode_coding_gap): Remove; unused.
10618
38dfbee1
PE
10619 * chartab.c (chartab_chars, chartab_bits): Now static.
10620
a2cb4e63
PE
10621 * charset.h (charset_iso_8859_1): Remove decl.
10622 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10623 Now static.
10624
127198fd
PE
10625 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10626 * ccl.c (Vccl_program_table): Now static.
10627 (check_ccl_update): Remove; unused.
10628
d85b608f
PE
10629 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10630 * category.h: ... from here.
10631 * category.c (check_category_table, set_category_set): Now static.
10632
31cd66f3
PE
10633 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10634 * lisp.h: Remove these decls.
10635
c358e587
PE
10636 * buffer.c (buffer_count): Remove unused var.
10637
e78aecca
PE
10638 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10639 so that it's not optimized away.
10640 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10641 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10642 exported only to the debugger.
10643
e192d7d3 10644 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10645 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10646
92470028
PE
10647 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10648 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10649 was inaccessible from Lisp.
10650 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10651 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10652
244ed907
PE
10653 alloc.c: Import and export fewer symbols, and remove unused items.
10654 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10655 is defined.
10656 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10657 it's not optimized away by whole-program optimization.
10658 (message_enable_multibyte, free_misc): Remove.
10659 (catchlist, handlerlist, mark_backtrace):
10660 Declare only if BYTE_MARK_STACK.
10661 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10662 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10663 (message_enable_multibyte): Remove decl.
10664 (free_misc, interval_free_list, float_block, float_block_index):
10665 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10666 (cons_free_list, last_marked_index):
10667 Now static.
10668 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10669 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10670 (mark_backtrace): Define only if BYTE_MARK_STACK.
10671 * xdisp.c (message_enable_multibyte): Now static.
10672
61c2b50e 10673 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10674 This makes it easier for human readers (and static analyzers)
10675 to see whether these variables are used from other modules.
10676 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10677 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10678 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10679 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10680 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10681 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10682 * xmenu.c, xselect.c:
10683 Declare Q* vars static if they are not used in other modules.
10684 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10685 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10686 Remove decls of unexported vars.
10687 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10688
95c82688
PE
10689 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10690
16a97296
PE
10691 Make Emacs functions such as Fatom 'static' by default.
10692 This makes it easier for human readers (and static analyzers)
10693 to see whether these functions can be called from other modules.
10694 DEFUN now defines a static function. To make the function external
10695 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10696 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10697 (Finit_image_library):
16a97296
PE
10698 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10699 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10700 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10701 Remove decls, since these functions are now static.
10702 (Funintern, Fget_internal_run_time): New decls, since these functions
10703 were already external.
95c82688 10704
16a97296
PE
10705 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10706 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10707 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10708 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10709 * keyboard.c, keymap.c, lread.c:
10710 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10711 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10712 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10713 Mark functions with DEFUE instead of DEFUN,
10714 if they are used in other modules.
10715 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10716 decls for now-static functions.
10717 * buffer.h (Fdelete_overlay): Remove decl.
10718 * callproc.c (Fgetenv_internal): Mark as internal.
10719 * composite.c (Fremove_list_of_text_properties): Remove decl.
10720 (Fcomposition_get_gstring): New forward static decl.
10721 * composite.h (Fcomposite_get_gstring): Remove decl.
10722 * dired.c (Ffile_attributes): New forward static decl.
10723 * doc.c (Fdocumntation_property): New forward static decl.
10724 * eval.c (Ffetch_bytecode): New forward static decl.
10725 (Funintern): Remove extern decl; now in .h file where it belongs.
10726 * fileio.c (Fmake_symbolic_link): New forward static decl.
10727 * image.c (Finit_image_library): New forward static decl.
10728 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10729 * intervals.h (Fprevious_property_change):
10730 (Fremove_list_of_text_properties): Remove decls.
10731 * keyboard.c (Fthis_command_keys): Remove decl.
10732 (Fcommand_execute): New forward static decl.
10733 * keymap.c (Flookup_key): New forward static decl.
10734 (Fcopy_keymap): Now static.
10735 * keymap.h (Flookup_key): Remove decl.
10736 * process.c (Fget_process): New forward static decl.
10737 (Fprocess_datagram_address): Mark as internal.
10738 * syntax.c (Fsyntax_table_p): New forward static decl.
10739 (skip_chars): Remove duplicate decl.
10740 * textprop.c (Fprevious_property_change): New forward static decl.
10741 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10742 Now internal.
10743 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10744 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10745
785bbd42
PE
10746 * editfns.c (Fformat): Remove unreachable code.
10747
8b913b57
AS
107482011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10749
10750 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10751 change. (Bug#8496)
10752
a6744a35
EZ
107532011-04-13 Eli Zaretskii <eliz@gnu.org>
10754
10755 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10756 when at ZV. (Bug#8487)
10757
e7974947
AS
107582011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10759
baad03f0
AS
10760 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10761 (Bug#8437)
10762 * keyboard.c (parse_tool_bar_item): Likewise.
10763 * sound.c (sound_cleanup, alsa_close): Likewise.
10764 * termcap.c (tgetent): Likewise.
10765 * xfns.c (x_default_font_parameter): Likewise.
10766 * xsettings.c (read_and_apply_settings): Likewise.
10767
e7974947
AS
10768 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10769 (overrun_check_free): Protoize.
10770
28272684
PE
107712011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10772
10773 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10774 since callers should never pass a negative size.
10775 Change the signature to match that of plain 'read' and 'write'; see
10776 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10777 * lisp.h: Update prototypes of emacs_write and emacs_read.
10778
11997c76
EZ
107792011-04-11 Eli Zaretskii <eliz@gnu.org>
10780
10781 * xdisp.c (redisplay_window): Don't try to determine the character
10782 position of the scroll margin if the window start point w->startp
e896f03c 10783 is outside the buffer's accessible region. (Bug#8468)
11997c76 10784
8a2cbd72
EZ
107852011-04-10 Eli Zaretskii <eliz@gnu.org>
10786
10787 Fix write-region and its subroutines for buffers > 2GB.
10788 * fileio.c (a_write, e_write): Modify declaration of arguments and
10789 local variables to support buffers larger than 2GB.
10790 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10791
10792 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10793 argument, local variables, and return value.
10794
10795 * lisp.h: Update prototypes of emacs_write and emacs_read.
10796
10797 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10798
4073e537 107992011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10800
1ebfdcb6
PE
10801 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10802
b2ded58d
PE
10803 Fix more problems found by GCC 4.6.0's static checks.
10804
7d66342c
PE
10805 * xdisp.c (vmessage): Use a better test for character truncation.
10806
bbf47d44
PE
10807 * charset.c (load_charset_map): <, not <=, for optimization,
10808 and to avoid potential problems with integer overflow.
9248994d 10809 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10810 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10811 * editfns.c (Fformat): Likewise.
1e69125e 10812 * syntax.c (skip_chars): Likewise.
3befa583 10813
e3019616
PE
10814 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10815 This also lets GCC 4.6.0 generate slightly better loop code.
10816
becfa255
PE
10817 * callint.c (Fcall_interactively): <, not <=, for optimization.
10818 (Fcall_interactively): Count the number of arguments produced,
10819 not the number of arguments given. This is simpler and lets GCC
10820 4.6.0 generate slightly better code.
10821
dae0cd48
PE
10822 * ftfont.c: Distingish more carefully between FcChar8 and char.
10823 The previous code passed unsigned char * to a functions like
10824 strlen and xstrcasecmp that expect char *, which does not
10825 conform to the C standard.
10826 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10827 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10828 char * when the C standard requires it.
10829
76032d70
PE
10830 * keyboard.c (read_char): Remove unused var.
10831
eb3f1cc8
PE
10832 * eval.c: Port to Windows vsnprintf (Bug#8435).
10833 Include <limits.h>.
10834 (SIZE_MAX): Define if the headers do not.
10835 (verror): Do not give up if vsnprintf returns a negative count.
10836 Instead, grow the buffer. This ports to Windows vsnprintf, which
10837 does not conform to C99. Problem reported by Eli Zaretskii.
10838 Also, simplify the allocation scheme, by avoiding the need for
10839 calling realloc, and removing the ALLOCATED variable.
10840
70476b54
PE
10841 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10842
12020a9e
PE
10843 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10844 But keep the doprint source code for now, as we might revamp it
10845 and use it again (Bug#8435).
ea6c7ae6
PE
10846 * lisp.h (doprnt): Remove.
10847 * Makefile.in (base_obj): Remove doprnt.o.
10848 * deps.mk (doprnt.o): Remove.
10849
5fdb398c
PE
10850 error: Print 32- and 64-bit integers portably (Bug#8435).
10851 Without this change, on typical 64-bit hosts error ("...%d...", N)
10852 was used to print both 32- and 64-bit integers N, which relied on
10853 undefined behavior.
61bdb816 10854 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10855 * lisp.h (error, verror): Mark as printf-like functions.
10856 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10857 Report overflow in size calculations when allocating printf buffer.
10858 Do not truncate output string at its first null byte.
10859 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10860 Truncate the output at a character boundary, since vsnprintf does not
10861 do that.
10862 * charset.c (check_iso_charset_parameter): Convert internal
10863 character to string before calling 'error', since %c now has the
10864 printf meaning.
10865 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10866 overflow when computing char to be passed to 'error'. Do not
10867 pass Lisp_Object to 'error'; pass the integer instead.
10868 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10869 formatted with plain %d.
10870
b189fa66
PE
10871 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10872
bff87ef0
PE
10873 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10874
7e2cac20
PE
10875 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10876
ce4d90b5
PE
10877 * xterm.c (x_catch_errors): Remove duplicate declaration.
10878
266c9547
PE
10879 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10880
79c49ad2
PE
10881 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10882
368f4090
JM
108832011-04-10 Jim Meyering <meyering@redhat.com>
10884
10885 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10886 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10887 return ssize_t not "int", and use size_t as the buffer length.
10888 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10889 * gnutls.h: Update declarations.
10890 * process.c (read_process_output): Use ssize_t, to match.
10891 (send_process): Likewise.
10892
a32d4040
CY
108932011-04-09 Chong Yidong <cyd@stupidchicken.com>
10894
10895 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10896
8546720e 108972011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10898
04f2d78b
CB
10899 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10900 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10901
8546720e
GM
10902 * xterm.c (handle_one_xevent):
10903 * xmenu.c (create_and_show_popup_menu):
10904 * xselect.c (x_decline_selection_request)
10905 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10906
0a2f5c1a 109072011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10908
10909 Fix some uses of `int' instead of EMACS_INT.
10910 * search.c (string_match_1, fast_string_match)
10911 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10912 (scan_buffer, find_next_newline_no_quit)
10913 (find_before_next_newline, search_command, Freplace_match)
10914 (Fmatch_data): Make some `int' variables be EMACS_INT.
10915
10916 * xdisp.c (display_count_lines): 3rd argument and return value now
10917 EMACS_INT. All callers changed.
10918 (pint2hrstr): Last argument is now EMACS_INT.
10919
10920 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10921 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10922 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10923 (decode_coding_utf_16, decode_coding_emacs_mule)
10924 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10925 (decode_coding_ccl, decode_coding_charset)
10926 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10927 (decode_coding_iso_2022, decode_coding_emacs_mule)
10928 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10929 <char_offset, last_offset>: Declare EMACS_INT.
10930 (encode_coding_utf_8, encode_coding_utf_16)
10931 (encode_coding_emacs_mule, encode_invocation_designation)
10932 (encode_designation_at_bol, encode_coding_iso_2022)
10933 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10934 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10935 Declare EMACS_INT.
10936 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10937 (encode_invocation_designation): Last argument P_NCHARS is now
10938 EMACS_INT.
10939 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10940 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10941
10942 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10943 All users changed.
10944
10945 * ccl.c (Fccl_execute_on_string): Declare some variables
10946 EMACS_INT.
10947
8546720e 109482011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10949
10950 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10951
4e19a977
CS
109522011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10953
10954 * process.c (Fformat_network_address): Doc fix.
10955
87302331
R
109562011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10957
ee7683eb 10958 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10959
cbb59342
CY
109602011-04-08 Chong Yidong <cyd@stupidchicken.com>
10961
10962 * keyboard.c (read_char): Call Lisp function help-form-show,
10963 instead of using internal_with_output_to_temp_buffer.
10964 (Qhelp_form_show): New var.
e0d38eeb 10965 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10966
10967 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10968
10969 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10970
e67a13ab
CY
109712011-04-06 Chong Yidong <cyd@stupidchicken.com>
10972
04f2d78b
CB
10973 * process.c (Flist_processes): Remove to Lisp.
10974 (list_processes_1): Delete.
e67a13ab 10975
973f782d
EZ
109762011-04-06 Eli Zaretskii <eliz@gnu.org>
10977
7c106b1e
EZ
10978 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10979
973f782d
EZ
10980 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10981
41cf7d1a 109822011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10983
ca23cc88
PE
10984 Fix more problems found by GCC 4.6.0's static checks.
10985
f390e2d5
PE
10986 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10987
42eea0d0
PE
10988 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10989
b69769da 10990 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10991
f9541e84
PE
10992 * xdisp.c (vmessage): Mark as a printf-like function.
10993
13841b55
PE
10994 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10995
c136c10f
PE
10996 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10997
5e2d4a30
PE
10998 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10999 printf-like functions.
11000 (tiff_load): Add casts to remove these marks before passing them
11001 to system-supplied API.
11002
583f48b9
PE
11003 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11004
b25d760e
PE
11005 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11006 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11007 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11008 directly, rather than having caller test rule sign. This avoids
11009 some unnecessary tests.
11010 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11011 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11012 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11013
bc7b6697 11014 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11015 (xfont_open): Avoid unnecessary tests.
bc7b6697 11016
27ccc379
PE
11017 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11018
dcd5c89a
PE
11019 * composite.h, composite.c (composition_gstring_put_cache):
11020 Use EMACS_INT, not int, for length.
11021
b13a45c6
PE
11022 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11023 breaking out part of COMPOSITION_DECODE_RULE.
11024 (COMPOSITION_DECODE_RULE): Use it.
11025 * composite.c (get_composition_id): Remove unused local vars,
11026 by using the new macro.
11027
1e792e4d
PE
11028 * textprop.c (set_text_properties_1): Change while to do-while,
11029 since the condition is always true at first.
11030
dc6c6455 11031 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11032 (interval_deletion_adjustment): Return unsigned value.
11033 All uses changed.
dc6c6455 11034
aba7731a
PE
11035 * process.c (list_processes_1, create_pty, read_process_output):
11036 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11037 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11038 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11039 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11040 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11041
fdfc4bf3
PE
11042 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11043
fca8fe46 11044 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11045 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11046
06a0259a 11047 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11048 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11049 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11050
e7b9e80f
PE
11051 * print.c (print_error_message): Avoid int overflow.
11052
56201685
PE
11053 * font.c (font_list_entities): Redo for clarity,
11054 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11055
78834453 11056 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11057 (font_score): Avoid potential overflow in diff calculation.
78834453 11058
0bc0b309 11059 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11060 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11061
e610eaca
PE
11062 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11063
b895abce
PE
11064 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11065 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11066 can always succeed if overflow has undefined behavior.
11067
1f1d9321 11068 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11069 (wordify): Omit three unnecessary tests.
1f1d9321 11070
c59478bc
PE
11071 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11072 All callers changed. This avoids the need for an unused var.
11073
79b73827
PE
11074 * casefiddle.c (casify_region): Remove var that is set but not used.
11075
a4db5dfe
PE
11076 * dired.c (file_name_completion): Remove var that is set but not used.
11077
43aae36e
PE
11078 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11079
2a47c44d 11080 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11081 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11082
a37c69bf
PE
11083 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11084 Check for integer overflow on size calculations.
11085
328ab8e7
PE
11086 * buffer.c (Fprevious_overlay_change): Remove var that is set
11087 but not used.
11088
e5a2a5cb
PE
11089 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11090 Remove vars that are set but not used.
8d84a6eb 11091 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11092 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11093
a60e5f68
PE
11094 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11095
f661cb61 11096 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11097 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11098
f0397f5a
PE
11099 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11100 that are set but not used.
11101
8664db06 11102 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11103 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11104
6abdaa4a
PE
11105 * xselect.c (x_get_local_selection, x_handle_property_notify):
11106 Remove vars that are set but not used.
11107
0ce7538d 11108 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11109 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11110
9ae848fc
PE
11111 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11112 Remove var that is set but not used.
0b918413
PE
11113 (scroll_bar_windows_size): Now size_t, not int.
11114 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11115 Check for overflow.
9ae848fc 11116
a5a62657
PE
11117 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11118 (map_tty_color) [!defined MSDOS]: Likewise.
11119
5c5cdd39
PE
11120 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11121
66ebf983
PE
11122 * coding.c: Remove vars that are set but not used.
11123 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11124 All callers changed.
11125 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11126 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11127 (decode_coding_charset): Remove vars that are set but not used.
11128
1be4d761
PE
11129 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11130 that is set but not used.
11131
47553fa8
PE
11132 * print.c (print_object): Remove var that is set but not used.
11133
1f7196bf 11134 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11135 The gnulib version avoids calling malloc in the usual case,
11136 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11137 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11138 * filelock.c (current_lock_owner): Likewise.
11139 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11140 * sysdep.c: Include allocator.h, careadlinkat.h.
11141 (emacs_no_realloc_allocator): New static constant.
11142 (emacs_readlink): New function.
fdb61804
PE
11143 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11144 ../lib/careadlinkat.h.
d1fdcab7 11145
f84c17c7
SM
111462011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11147
11148 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11149 first non-nil return value).
11150
ef3862ad
JD
111512011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11152
11153 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11154 if not defined (Bug#8403).
11155
376a7006
JB
111562011-04-02 Juanma Barranquero <lekktu@gmail.com>
11157
11158 * xdisp.c (display_count_lines): Remove parameter `start',
11159 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11160 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11161 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11162 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11163 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11164 and thereabouts. All callers changed.
11165 (get_per_char_metric): Remove parameter `f', unused since
11166 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11167
6ca3801d
JM
111682011-04-02 Jim Meyering <meyering@redhat.com>
11169
11170 do not dereference NULL upon failed strdup
11171 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11172 (ns_get_family): Likewise.
11173
d8e2b5ba
JB
111742011-04-02 Juanma Barranquero <lekktu@gmail.com>
11175
11176 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11177
8c74fcbd
JD
111782011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11179
11180 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11181 later (Bug#8403).
11182
7200d79c
SM
111832011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11184
03408648 11185 Add lexical binding.
7200d79c 11186
03408648
SM
11187 * window.c (Ftemp_output_buffer_show): New fun.
11188 (Fsave_window_excursion):
11189 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11190
11191 * lread.c (lisp_file_lexically_bound_p): New function.
11192 (Fload): Bind Qlexical_binding.
11193 (readevalloop): Remove `evalfun' arg.
11194 Bind Qinternal_interpreter_environment.
11195 (Feval_buffer): Bind Qlexical_binding.
11196 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11197 Mark as dynamic.
11198 (syms_of_lread): Declare `lexical-binding'.
11199
11200 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11201
11202 * keyboard.c (eval_dyn): New fun.
11203 (menu_item_eval_property): Use it.
ca105506
SM
11204
11205 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11206
03408648
SM
11207 * fns.c (concat, mapcar1): Accept byte-code-functions.
11208
11209 * eval.c (Fsetq): Handle lexical vars.
11210 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11211 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11212 (FletX, Flet): Obey lexical binding.
11213 (Fcommandp): Handle closures.
11214 (Feval): New `lexical' arg.
11215 (eval_sub): New function extracted from Feval. Use it almost
11216 everywhere where Feval was used. Look up vars in lexical env.
11217 Handle closures.
11218 (Ffunctionp): Move from subr.el.
11219 (Ffuncall): Handle closures.
11220 (apply_lambda): Remove `eval_flags'.
11221 (funcall_lambda): Handle closures and new byte-code-functions.
11222 (Fspecial_variable_p): New function.
11223 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11224 but without exporting it to Lisp.
23aba0ea 11225
23aba0ea 11226 * doc.c (Fdocumentation, store_function_docstring):
03408648 11227 * data.c (Finteractive_form): Handle closures.
23aba0ea 11228
03408648
SM
11229 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11230 interactive spec.
ba83908c 11231
04f2d78b
CB
11232 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11233 New byte-codes.
03408648
SM
11234 (exec_byte_code): New function extracted from Fbyte_code to handle new
11235 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11236
03408648 11237 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11238
03408648 11239 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11240
e2abce01
JB
112412011-03-31 Juanma Barranquero <lekktu@gmail.com>
11242
11243 * xdisp.c (redisplay_internal): Fix prototype.
11244
63696a73 112452011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11246
63696a73 11247 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11248 (try_scrolling): Use it when setting scroll_limit.
11249 Limit scrolling to 100 screen lines.
63696a73
EZ
11250 (redisplay_window): Even when falling back on "recentering",
11251 position point in the window according to scroll-conservatively,
11252 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11253
11254 (try_scrolling): When point is above the window, allow searching
11255 as far as scroll_max, or one screenful, to compute vertical
11256 distance from PT to the scroll margin position. This prevents
11257 try_scrolling from unnecessarily failing when
11258 scroll-conservatively is set to a value slightly larger than the
11259 window height. Clean up the case of PT below the margin at bottom
11260 of window: scroll_max can no longer be INT_MAX. When aggressive
11261 scrolling is in use, don't let point enter the opposite scroll
11262 margin as result of the scroll.
11263 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
11264 threshold of 100 lines for never-recentering scrolling.
11265
e4cc2dfc
JB
112662011-03-31 Juanma Barranquero <lekktu@gmail.com>
11267
11268 * dispextern.h (move_it_by_lines):
11269 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
11270 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
11271 (message_log_check_duplicate): Remove parameters `prev_bol' and
11272 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11273 (redisplay_internal): Remove parameter `preserve_echo_area',
11274 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
11275
11276 * indent.c (Fvertical_motion):
11277 * window.c (window_scroll_pixel_based, Frecenter):
11278 Don't pass `need_y_p' to `move_it_by_lines'.
11279
1c470562
SM
112802011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
11281
44f230aa
SM
11282 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
11283 steal a few bits to be more compact.
11284 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
11285 Remove unneeded casts.
11286
1c470562
SM
11287 * bytecode.c (Fbyte_code): CAR and CDR can GC.
11288
888adce9
ZK
112892011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
11290
11291 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
11292 binding" message (bug#7967).
11293
f838ed7b
PE
112942011-03-30 Paul Eggert <eggert@cs.ucla.edu>
11295
77861b95
PE
11296 Fix more problems found by GCC 4.6.0's static checks.
11297
de6dbc14
PE
11298 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
11299 Remove unused local var.
11300
f838ed7b
PE
11301 * editfns.c (Fmessage_box): Remove unused local var.
11302
792c7b2b
PE
11303 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
11304 (note_mode_line_or_margin_highlight, note_mouse_highlight):
11305 Omit unused local vars.
c499e557 11306 * window.c (shrink_windows): Omit unused local var.
b01a1c29 11307 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
11308 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
11309 Omit unused local var.
11310
ba0165e1
PE
11311 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
11312 Don't assume string length fits in int.
32ad8845 11313 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 11314 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 11315
3c59b4c9
PE
11316 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
11317 instead of alloca (Bug#8344).
11318
a3eed478 11319 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 11320 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 11321
eb4d412d
PE
11322 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
11323
1658b401
PE
11324 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
11325 concerns.
11326
11327 * term.c (produce_glyphless_glyph): Remove unnecessary test.
11328
11329 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 11330
9a2c6e05
PE
11331 * keyboard.c (syms_of_keyboard): Use the same style as later
11332 in this function when indexing through an array. This also
11333 works around GCC bug 48267.
11334
03d0a109
PE
11335 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
11336
44f730c8
PE
11337 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
11338
fe75f926
PE
11339 * chartab.c (sub_char_table_ref_and_range): Redo for slight
11340 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
11341
ffa8c828
PE
11342 * keyboard.c, keyboard.h (num_input_events): Now size_t.
11343 This avoids undefined behavior on integer overflow, and is a bit
11344 more convenient anyway since it is compared to a size_t variable.
11345
c5101a77
PE
11346 Variadic C functions now count arguments with size_t, not int.
11347 This avoids an unnecessary limitation on 64-bit machines, which
11348 caused (substring ...) to crash on large vectors (Bug#8344).
11349 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
11350 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 11351 All variadic functions and their callers changed accordingly.
c5101a77
PE
11352 (struct gcpro.nvars): Now size_t, not int. All uses changed.
11353 * data.c (arith_driver, float_arith_driver): Likewise.
11354 * editfns.c (general_insert_function): Likewise.
11355 * eval.c (struct backtrace.nargs, interactive_p)
11356 (internal_condition_case_n, run_hook_with_args, apply_lambda)
11357 (funcall_lambda, mark_backtrace): Likewise.
11358 * fns.c (concat): Likewise.
11359 * frame.c (x_set_frame_parameters): Likewise.
11360 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
11361 0 if not found, not -1. All callers changed.
11362
dd3f25f7
PE
11363 * alloc.c (garbage_collect): Don't assume stack size fits in int.
11364 (stack_copy_size): Now size_t, not int.
11365 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
11366
461c2ab9
JB
113672011-03-28 Juanma Barranquero <lekktu@gmail.com>
11368
11369 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
11370 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11371 All callers changed.
11372
11373 * lisp.h (multibyte_char_to_unibyte):
11374 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
11375 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
11376 * character.h (CHAR_TO_BYTE8):
11377 * cmds.c (internal_self_insert):
11378 * editfns.c (general_insert_function):
11379 * keymap.c (push_key_description):
11380 * search.c (Freplace_match):
11381 * xdisp.c (message_dolog, set_message_1): All callers changed.
11382
f6d62986
SM
113832011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
11384
11385 * keyboard.c (safe_run_hook_funcall): New function.
11386 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
11387 don't set the hook to nil, but remove the offending function instead.
11388 (Qcommand_hook_internal): Remove, unused.
11389 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
11390 Vcommand_hook_internal.
11391
11392 * eval.c (enum run_hooks_condition): Remove.
11393 (funcall_nil, funcall_not): New functions.
11394 (run_hook_with_args): Call each function through a `funcall' argument.
11395 Remove `cond' argument, now redundant.
11396 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
11397 (Frun_hook_with_args_until_failure): Adjust accordingly.
11398 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
11399
1db5b1ad
JB
114002011-03-28 Juanma Barranquero <lekktu@gmail.com>
11401
11402 * dispextern.h (string_buffer_position): Remove declaration.
11403
11404 * print.c (strout): Remove parameter `multibyte', unused since
11405 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
11406
11407 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
11408 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
11409 All callers changed.
11410
11411 * w32.c (_wsa_errlist): Use braces for struct initializers.
11412
11413 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
11414 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
11415 All callers changed.
11416 (string_buffer_position): Likewise. Also, make static (it's never
11417 used outside xdisp.c).
11418 (cursor_row_p): Remove parameter `w', unused since
11419 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
11420 (decode_mode_spec): Remove parameter `precision', introduced during
11421 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
11422 All callers changed.
11423
5ffb62aa
JD
114242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11425
11426 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
11427
461c2ab9 114282011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
11429
11430 * nsterm.m (ns_menu_bar_is_hidden): New variable.
11431 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
11432 (ns_update_auto_hide_menu_bar): New functions.
11433 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
11434 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
11435 ns_constrain_all_frames.
11436 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
11437 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
11438
5c380ffb
JD
114392011-03-27 Jan Djärv <jan.h.d@swipnet.se>
11440
11441 * nsmenu.m (runDialogAt): Remove argument to timer_check.
11442
9af30bdf
GM
114432011-03-27 Glenn Morris <rgm@gnu.org>
11444
11445 * syssignal.h: Replace RETSIGTYPE with void.
11446 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
11447 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
11448 Replace SIGTYPE with void everywhere.
11449 * s/usg5-4-common.h (SIGTYPE): Remove definition.
11450 * s/template.h (SIGTYPE): Remove commented out definition.
11451
e2abce01
JB
114522011-03-26 Eli Zaretskii <eliz@gnu.org>
11453
11454 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
11455 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
11456
f868cd8a
JB
114572011-03-26 Juanma Barranquero <lekktu@gmail.com>
11458
59eb0929
JB
11459 * w32.c (read_unc_volume): Use parameter `henum', instead of
11460 global variable `wget_enum_handle'.
11461
11462 * keymap.c (describe_vector): Remove parameters `indices' and
11463 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
11464 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
11465
f868cd8a
JB
11466 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
11467
11468 * keyboard.c (timer_check): Remove parameter `do_it_now',
11469 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
11470 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
11471 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
11472
11473 * keyboard.c (read_char):
11474 * w32menu.c (w32_menu_display_help):
11475 * xmenu.c (show_help_event, menu_help_callback):
11476 Adjust calls to `show_help_echo'.
11477
11478 * gtkutil.c (xg_maybe_add_timer):
11479 * keyboard.c (readable_events):
11480 * process.c (wait_reading_process_output):
11481 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
11482
11483 * insdel.c (adjust_markers_gap_motion):
11484 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
11485 (gap_left, gap_right): Don't call it.
11486
2ecf6fdb
CY
114872011-03-25 Chong Yidong <cyd@stupidchicken.com>
11488
11489 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
11490 incurred during fontification.
11491
6b1f9ba4
JB
114922011-03-25 Juanma Barranquero <lekktu@gmail.com>
11493
11494 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
11495 (DEFVAR_PER_BUFFER): Don't pass it.
11496
11497 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
11498 (scrolling_window): Don't pass it.
11499
0f4a96b5
JB
115002011-03-25 Juanma Barranquero <lekktu@gmail.com>
11501
11502 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
11503
11504 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
11505 and `suffix'.
11506 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
11507 of variables specific to SELinux and computation of `encoded_absname'.
11508
11509 * image.c (XPutPixel): Remove unused variable `height'.
11510
11511 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
11512
11513 * unexw32.c (get_section_info): Remove unused variable `section'.
11514
11515 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
11516 (system_process_attributes): Remove unused variable `sess'.
11517 (sys_read): Remove unused variable `err'.
11518
11519 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
11520 (w32_wnd_proc): Remove unused variable `isdead'.
11521 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
11522 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
11523 (x_create_tip_frame): Remove unused variable `tem'.
11524
11525 * w32inevt.c (w32_console_read_socket):
11526 Remove unused variable `no_events'.
11527
11528 * w32term.c (x_draw_composite_glyph_string_foreground):
11529 Remove unused variable `width'.
11530
1149507c
JB
115312011-03-24 Juanma Barranquero <lekktu@gmail.com>
11532
11533 * w32term.c (x_set_glyph_string_clipping):
11534 Don't pass uninitialized region to CombineRgn.
11535
9c88f339
JB
115362011-03-23 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
11539 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
11540 (Fx_close_connection): Remove unused variable `i'.
11541
11542 * w32font.c (w32font_draw): Return number of glyphs.
11543 (w32font_open_internal): Remove unused variable `i'.
11544 (w32font_driver): Add missing initializer.
11545
11546 * w32menu.c (utf8to16): Remove unused variable `utf16'.
11547 (fill_in_menu): Remove unused variable `items_added'.
11548
11549 * w32term.c (last_mouse_press_frame): Remove static global variable.
11550 (w32_clip_to_row): Remove unused variable `f'.
11551 (x_delete_terminal): Remove unused variable `i'.
11552
11553 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
11554 (NOTHING): Remove unused static global variable.
11555 (uniscribe_check_otf): Remove unused variable `table'.
11556 (uniscribe_font_driver): Add missing initializers.
11557
dee091a3
JD
115582011-03-23 Julien Danjou <julien@danjou.info>
11559
11560 * term.c (Fsuspend_tty, Fresume_tty):
11561 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
11562 * window.c (temp_output_buffer_show):
11563 * insdel.c (signal_before_change):
11564 * frame.c (Fhandle_switch_frame):
11565 * fileio.c (Fdo_auto_save):
11566 * emacs.c (Fkill_emacs):
11567 * editfns.c (save_excursion_restore):
11568 * cmds.c (internal_self_insert):
11569 * callint.c (Fcall_interactively):
11570 * buffer.c (Fkill_all_local_variables):
11571 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
11572 Use Frun_hooks.
0f4a96b5 11573 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 11574 unconditionally since it does the check itself.
dee091a3 11575
2c520ab5 115762011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 11577
c9c49752
PE
11578 Fix more problems found by GCC 4.5.2's static checks.
11579
8abc3f12
PE
11580 * coding.c (encode_coding_raw_text): Avoid unnecessary test
11581 the first time through the loop, since we know p0 < p1 then.
11582 This also avoids a gcc -Wstrict-overflow warning.
11583
a2d26660
PE
11584 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
11585 leading to a memory leak, possible in functions like
11586 load_charset_map_from_file that can allocate an unbounded number
b12ef411 11587 of objects (Bug#8318).
a2d26660 11588
916c72e9
PE
11589 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
11590 that could (at least in theory) be that large.
11591
19ab8a18
PE
11592 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
11593 This is less likely to overflow, and avoids undefined behavior if
11594 overflow does occur. All callers changed. Use strtoul to scan
11595 for the unsigned long integer.
b7cbbd6f
PE
11596 (pint2hrstr): Simplify and tune code slightly.
11597 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 11598
f0641eff
PE
11599 * scroll.c (do_scrolling): Work around GCC bug 48228.
11600 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
11601
7f650bb9
PE
11602 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
11603 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
11604 (validate_x_resource_name): Simplify count usage.
11605 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 11606
37dd57d1
PE
11607 * fileio.c (Fcopy_file): Report error if fchown or fchmod
11608 fail (Bug#8306).
81e56e61 11609
699979fc 11610 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 11611
401bf9b4
PE
11612 * process.c (Fmake_network_process): Use socklen_t, not int,
11613 where POSIX says socklen_t is required in portable programs.
11614 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11615 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11616 (Fmake_network_process, server_accept_connection):
11617 (wait_reading_process_output, read_process_output):
11618 Likewise.
11619
b93aacde
PE
11620 * process.c: Rename or move locals to avoid shadowing.
11621 (list_processes_1, Fmake_network_process):
11622 (read_process_output_error_handler, exec_sentinel_error_handler):
11623 Rename or move locals.
4dc343ee 11624 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11625 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11626 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11627 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11628 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11629
af8a867c 11630 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11631 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11632 Include tparam.h instead, since it declares them.
af8a867c
PE
11633 * cm.h (PC): Remove extern decl; tparam.h now does this.
11634 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11635 * terminfo.c: Include tparam.h, to check interfaces.
11636 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11637 (tparam): Adjust signature to match interface in tparam.h;
11638 this removes some undefined behavior. Check that outstring and len
11639 are zero, which they always are with Emacs.
11640 * tparam.h (PC, BC, UP): New extern decls.
11641
0248044d 11642 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11643 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11644
8ff096c1 11645 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11646 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11647 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11648 (ftfont_list): Remove unused local.
49eaafba
PE
11649 (get_adstyle_property, ftfont_pattern_entity):
11650 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11651 Rename locals to avoid shadowing.
8ff096c1 11652
e2be39f6
PE
11653 * xfont.c (xfont_list_family): Mark var as initialized.
11654
c9735e30
PE
11655 * xml.c (make_dom): Now static.
11656
8f5201ae
PE
11657 * composite.c (composition_compute_stop_pos): Rename local to
11658 avoid shadowing.
b246f932
PE
11659 (composition_reseat_it): Remove unused locals.
11660 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11661 (composition_update_it): Mark var as initialized.
11b61122
PE
11662 (find_automatic_composition): Mark vars as initialized,
11663 with a FIXME (Bug#8290).
8f5201ae 11664
760fbc2c
PE
11665 character.h: Rename locals to avoid shadowing.
11666 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11667 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11668 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11669 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11670 to avoid shadowing.
11671
ff08eb85
PE
11672 * textprop.c (property_change_between_p): Remove; unused.
11673
fc7bf025
PE
11674 * intervals.c (interval_start_pos): Now static.
11675
235d7abc
PE
11676 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11677
44f230aa
SM
11678 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11679 Rename locals to avoid shadowing.
3e7d6594 11680
50060332
PE
11681 * sound.c (wav_play, au_play, Fplay_sound_internal):
11682 Fix pointer signedness.
d01f234b 11683 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11684 (wav_play): Initialize a variable to 0, to prevent undefined
11685 behavior (Bug#8278).
50060332 11686
c4fc4e30
PE
11687 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11688
918436ed
PE
11689 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11690
c939f91b
PE
11691 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11692 clobbering (Bug#8298).
b9c7f648
PE
11693 * sysdep.c (sys_subshell): Likewise.
11694 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11695
6bd8c144
PE
11696 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11697 This should get cleaned up, so that child_setup has the
11698 same signature on all platforms.
11699
7710357c 11700 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11701 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11702
c59da222
CY
117032011-03-22 Chong Yidong <cyd@stupidchicken.com>
11704
11705 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11706 not to be necessary, and produces flickering.
11707
66b87493
GM
117082011-03-20 Glenn Morris <rgm@gnu.org>
11709
11710 * config.in: Remove file.
11711
45b6f6d5
JB
117122011-03-20 Juanma Barranquero <lekktu@gmail.com>
11713
11714 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11715 are now in src/globals.h.
11716 (syms_of_minibuf): Remove spurious & from previous change.
11717
cd394be1 117182011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11719
11720 * minibuf.c (completing-read-function): New variable.
11721 (completing-read-default): Rename from completing-read.
11722 (completing-read): Call completing-read-function.
11723
b14e3e21
CY
117242011-03-19 Juanma Barranquero <lekktu@gmail.com>
11725
11726 * xfaces.c (Fx_load_color_file):
11727 Read color file from absolute filename (bug#8250).
11728
f2b726e6
JB
117292011-03-19 Juanma Barranquero <lekktu@gmail.com>
11730
11731 * makefile.w32-in: Update dependencies.
11732
09f6ff02
EZ
117332011-03-17 Eli Zaretskii <eliz@gnu.org>
11734
11735 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11736
29a6015a
PE
117372011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11738
a3a6c54e
PE
11739 Fix more problems found by GCC 4.5.2's static checks.
11740
b766f867
PE
11741 * process.c (make_serial_process_unwind, send_process_trap):
11742 (sigchld_handler): Now static.
11743
be02381c
PE
11744 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11745 That way, the code declares only the vars that it needs.
11746 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11747 * s/cygwin.h (PTY_ITERATION): Likewise.
11748 * s/darwin.h (PTY_ITERATION): Likewise.
11749 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11750
57048744
PE
11751 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11752 * process.c (allocate_pty): Don't declare stb unless it's needed.
11753
7914961c 11754 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11755 (CONSTANTLIM): Remove; unused.
11756 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11757 Define only if needed.
7914961c 11758
b3967b18
PE
11759 * unexelf.c (unexec): Name an expression,
11760 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11761 Use a different way to cause a compilation error if anyone uses
11762 n rather than nn, a way that does not involve shadowing.
73366a00 11763 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11764
29a6015a
PE
11765 * deps.mk (unexalpha.o): Remove; unused.
11766
43cfc33e 11767 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11768 * unexec.h: New file.
ce701a33
PE
11769 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11770 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11771 Depend on unexec.h.
11772 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11773 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11774 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11775 Change as necessary to match prototype in unexec.h.
ce701a33 11776
01f44d5a
PE
11777 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11778 shadowing.
4f63c6bb 11779 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11780
a6670b0b
PE
11781 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11782 Rename locals to avoid shadowing.
11783
cef2010d 11784 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11785 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11786
d4d7173a
PE
11787 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11788
f08b802a
PE
11789 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11790 warning when compiling print.c.
11791
3ddb0639
PE
11792 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11793 instead of using an uninitialized var.
5ad03b97 11794 (font_sort_entities): Mark var as initialized.
3ddb0639 11795
170a2692
PE
11796 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11797
e663c700
PE
11798 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11799 pointers to constants.
89bc529a 11800 (font_parse_fcname): Remove unused vars.
7b81e2d0 11801 (font_delete_unmatched): Now static.
ea838e10 11802 (font_get_spec): Remove; unused.
13a547c6
PE
11803 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11804 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11805 Rename or move locals to avoid shadowing.
e663c700 11806
2a80c887 11807 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11808 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11809
1384fa33 11810 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11811 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11812
8b2c52e9
PE
11813 * alloc.c (mark_backtrace): Move decl from here ...
11814 * lisp.h: ... to here, so that it can be checked.
11815
475545b5 11816 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11817 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11818 (lisp_indirect_variable): Name an expression,
11819 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11820 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11821
b1349114 11822 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11823 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11824 Use const pointer when appropriate.
b1349114 11825
a2928364
PE
11826 * lisp.h (get_system_name, get_operating_system_release):
11827 Move decls here, to check interfaces.
11828 * process.c (get_operating_system_release): Move decl to lisp.h.
11829 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11830 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11831 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11832 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11833 (Fformat_time_string, Fencode_time, Finsert_char):
11834 (Ftranslate_region_internal, Fformat):
11835 Rename or remove local vars to avoid shadowing.
9710023e 11836 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11837
a415e694
PE
11838 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11839 avoid shadowing.
11840
8ef4622d
PE
11841 * lisp.h (eassert): Check that the argument compiles, even if
11842 ENABLE_CHECKING is not defined.
11843
946f9a5b
PE
11844 * data.c (Findirect_variable): Name an expression, to avoid
11845 gcc -Wbad-function-cast warning.
112396d6 11846 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11847 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11848 (Fmake_variable_buffer_local, Fmake_local_variable):
11849 Mark variables as initialized.
52746918 11850 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11851
e5aab7e7 11852 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11853 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11854 Rename locals to avoid shadowing.
dff45157
PE
11855 (mark_stack): Move local variables into the #ifdef region where
11856 they're used.
7bc26fdb
PE
11857 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11858 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11859 needed otherwise.
11860 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11861 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11862 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11863
e5aab7e7
PE
11864 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11865 avoids undefined behavior in theory.
11866
4da60324
PE
11867 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11868
88043301
PE
11869 Use functions, not macros, for up- and down-casing (Bug#8254).
11870 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11871 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11872 to use the following functions instead of these macros.
11873 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11874 EMACS_INT, since callers assume the returned value fits in int.
11875 (upcase1): Likewise, for UPCASE_TABLE.
11876 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11877 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11878 the race-condition problem in the old DOWNCASE.
88043301 11879
19ed5445
PE
11880 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11881 Rename locals to avoid shadowing.
11882 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11883 (regex_compile, re_search_2, re_match_2_internal):
11884 Remove unused local vars.
952db0d7
PE
11885 (FREE_VAR): Rewrite so as not to use empty "else",
11886 which gcc can warn about.
da053e48 11887 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11888 (RETALLOC_IF): Define only if needed.
11889 (WORDCHAR_P): Likewise. This one is never needed, but is used
11890 only in a comment talking about a compiler bug, so put inside
11891 the #if 0 of that comment.
11892 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11893 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11894 Remove; unused.
19ed5445 11895
1f3561e4 11896 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11897 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11898 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11899
ded6f8f7
PE
11900 * search.c (simple_search): Remove unused var.
11901
dbd37a95
PE
11902 * dired.c (compile_pattern): Move decl from here ...
11903 * lisp.h: ... to here, so that it can be checked.
11904 (struct re_registers): New forward decl.
11905
7e47afad
PE
11906 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11907
85f24f61
PE
11908 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11909 All uses changed.
11910 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11911 Rename locals to avoid shadowing.
5671df8f 11912 (Fvertical_motion): Mark locals as initialized.
85f24f61 11913
181aa2be 11914 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11915 (casify_region): Mark local as initialized.
181aa2be 11916
930d429c
PE
11917 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11918
7082eac6
PE
11919 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11920 New macros, so that the caller can use some names other than
11921 gcpro1, gcpro2, etc.
11922 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11923 of the new macros.
11924 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11925 argument, for consistency with GCPRO2_VAR, etc: it is now the
11926 prefix of the variable, not the variable itself. All uses
11927 changed.
38b2c076
PE
11928 * dired.c (directory_files_internal, file_name_completion):
11929 Rename locals to avoid shadowing.
11930
15206ed9
PE
11931 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11932 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11933 dired.c's scmp function, had undefined behavior.
11934 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11935 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11936 * buffer.h: ... to here, because these macros use current_buffer,
11937 and the new implementation with inline functions needs to have
11938 current_buffer in scope now, rather than later when the macros
11939 are used.
11940 (downcase, upcase1): New static inline functions.
11941 (DOWNCASE, UPCASE1): Reimplement using these functions.
11942 This avoids undefined behavior in expressions like
11943 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11944 from race conditions in accessing the global variables
11945 case_temp1 and case_temp2.
11946 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11947 * lisp.h (case_temp1, case_temp2): Remove their decls.
11948 * character.h (ASCII_CHAR_P): Move from here ...
11949 * lisp.h: ... to here, so that the inline functions mentioned
11950 above can use them.
11951
4a6bea26
PE
11952 * dired.c (directory_files_internal_unwind): Now static.
11953
f14b7e14
PE
11954 * fileio.c (file_name_as_directory, directory_file_name):
11955 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11956 Now static.
2893f146
PE
11957 (file_name_as_directory): Use const pointers when appropriate.
11958 (Fexpand_file_name): Likewise. In particular, newdir might
11959 point at constant storage, so make it a const pointer.
fd4ead52 11960 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11961 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11962 signedness issues.
f839df0c
PE
11963 (Fset_file_times, Finsert_file_contents, auto_save_error):
11964 Rename locals to avoid shadowing.
f14b7e14 11965
5716756e 11966 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11967 (Ftry_completion, Fall_completions): Rename or remove locals
11968 to avoid shadowing.
5716756e 11969
b4c3046a
PE
11970 * marker.c (bytepos_to_charpos): Remove; unused.
11971
b45db522
PE
11972 * lisp.h (verify_bytepos, count_markers): New decls,
11973 so that gcc does not warn that these functions aren't declared.
11974
85876d07
PE
11975 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11976 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11977 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11978 (copy_text): Remove unused local var.
85876d07 11979
03d78a21 11980 * filelock.c (within_one_second): Now static.
b3dd38ab 11981 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11982
5df8f01b
PE
11983 * buffer.c (fix_overlays_before): Mark locals as initialized.
11984 (fix_start_end_in_overlays): Likewise. This function should be
11985 simplified by using pointers-to-pointers, but that's a different
11986 matter.
b1d876f1 11987 (switch_to_buffer_1): Now static.
8f54f30a
PE
11988 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11989 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11990
a70072c9 11991 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11992 Fix pointer signedness issue.
edced198
PE
11993 (sys_subshell): Mark local as volatile if checking for lint,
11994 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11995 (MAXPATHLEN): Define only if needed.
a70072c9 11996
a0977c44
PE
11997 * process.c (serial_open, serial_configure): Move decls from here ...
11998 * systty.h: ... to here, so that they can be checked.
11999
a884fdcc
PE
12000 * fns.c (get_random, seed_random): Move extern decls from here ...
12001 * lisp.h: ... to here, so that they can be checked.
12002
604efe86 12003 * sysdep.c (reset_io): Now static.
b8950c94 12004 (wait_for_termination_signal): Remove; unused.
604efe86 12005
38fc62d9
PE
12006 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12007 (copy_keymap_item, append_key, push_text_char_description):
12008 Now static.
1004a21a 12009 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12010 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12011 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12012 (describe_map_tree):
12013 Rename locals to avoid shadowing.
38fc62d9 12014
2f2650da
PE
12015 * keyboard.c: Declare functions static if they are not used elsewhere.
12016 (echo_char, echo_dash, cmd_error, top_level_2):
12017 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12018 (read_char, kbd_buffer_get_event, make_lispy_position):
12019 (make_lispy_event, make_lispy_movement, apply_modifiers):
12020 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12021 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12022 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12023 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12024 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12025
a053e86c 12026 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12027 (mark_kboards): Move decl here ...
12028 * alloc.c (mark_kboards): ... from here.
a053e86c 12029
4752793e
PE
12030 * lisp.h (force_auto_save_soon): New decl.
12031
74f10ca7 12032 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12033 (DEFINE_DUMMY_FUNCTION): New macro.
12034 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12035 Use it.
c03cd23f
PE
12036 (main): Add casts to avoid warnings
12037 if GCC considers string literals to be constants.
74f10ca7 12038
022e70d4
PE
12039 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12040
59d6fe83
PE
12041 * dbusbind.c: Pointer signedness fixes.
12042 (xd_signature, xd_append_arg, xd_initialize):
12043 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12044 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12045 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12046 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12047
78320123
PE
12048 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12049 if GCC considers string literals to be constants.
49cebcca 12050 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12051
35ac2a97
SM
120522011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12053
fb103ca9
SM
12054 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12055 (print_preprocess, print_object): New macro to fix last change.
12056
35ac2a97
SM
12057 * print.c (print_preprocess): Don't forget font objects.
12058
62973b41
JB
120592011-03-16 Juanma Barranquero <lekktu@gmail.com>
12060
12061 * emacs.c (USAGE3): Doc fixes.
12062
0e48bb22
AS
120632011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12064
12065 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12066 structure.
12067
7684e57b
JB
120682011-03-14 Juanma Barranquero <lekktu@gmail.com>
12069
12070 * lisp.h (VWindow_system, Qfile_name_history):
12071 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12072 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12073 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12074
12075 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12076 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12077
12078 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12079 * w32console.c (detect_input_pending, read_input_pending)
12080 (encode_terminal_code):
12081 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12082 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12083 (w32_system_caret_y, Qfile_name_history):
12084 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12085 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12086 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12087 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12088 * w32proc.c (Qlocal, report_file_error):
12089 * w32term.c (Vwindow_system, updating_frame):
12090 * w32uniscribe.c (initialized, uniscribe_font_driver):
12091 Remove unneeded extern declarations.
12092
2aa46d6c
CY
120932011-03-14 Chong Yidong <cyd@stupidchicken.com>
12094
c96bbc66 12095 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12096
cffc6f3b
CY
120972011-03-13 Chong Yidong <cyd@stupidchicken.com>
12098
12099 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12100 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12101 These macros can no longer be used for assignment.
12102
44f230aa
SM
12103 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12104 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12105 (record_buffer_markers, fetch_buffer_markers): New functions for
12106 recording and fetching special buffer markers.
12107 (set_buffer_internal_1, set_buffer_temp): Use them.
12108
12109 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12110
12111 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12112
12113 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12114 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12115
12116 * xdisp.c (hscroll_window_tree):
12117 (reconsider_clip_changes): Use PT instead of BUF_PT.
12118
d251f04b
EZ
121192011-03-13 Eli Zaretskii <eliz@gnu.org>
12120
12121 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12122 $(EMACS_ROOT)/lib/intprops.h.
12123
f0c77cd1
PE
121242011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12125
3eca4629
PE
12126 Fix more problems found by GCC 4.5.2's static checks.
12127
7c86ee98
PE
12128 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12129 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12130 (xg_free_frame_widgets): Make it clear that a local variable is
12131 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12132 (gdk_window_get_screen): Make it clear that this macro is needed
12133 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12134 (int_gtk_range_get_value): New function, which avoids a diagnostic
12135 from gcc -Wbad-function-cast.
12136 (xg_set_toolkit_scroll_bar_thumb): Use it.
12137 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12138 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12139 (get_utf8_string, xg_get_file_with_chooser):
12140 Rename locals to avoid shadowing.
12141 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12142
41729b81
PE
12143 * xgselect.c (xg_select): Remove unused var.
12144
f0c77cd1
PE
12145 * image.c (four_corners_best): Mark locals as initialized.
12146 (gif_load): Initialize transparent_p to zero (Bug#8238).
12147 Mark another local as initialized.
ec6cf4c6 12148 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12149
ce0ad53d 12150 * image.c (clear_image_cache): Now static.
d5d5a617 12151 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12152 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12153 (x_edge_detection): Remove unnecessary cast that
12154 gcc -Wbad-function-cast diagnoses.
2037898d 12155 (gif_load): Fix pointer signedness.
6ae141d6
PE
12156 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12157 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12158
33383987 121592011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12160
d32df629
PE
12161 Improve quality of tests for time stamp overflow.
12162 For example, without this patch (encode-time 0 0 0 1 1
12163 1152921504606846976) returns the obviously-bogus value (-948597
12164 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12165 reports time overflow. See
12166 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12167 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12168 * editfns.c: Include limits.h and intprops.h.
12169 (TIME_T_MIN, TIME_T_MAX): New macros.
12170 (time_overflow): Move earlier, to before first use.
12171 (hi_time, lo_time): New functions, for an accurate test for
12172 out-of-range times.
12173 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12174 (Fget_internal_run_time): Don't assume time_t fits in int.
12175 (make_time): Use list2 instead of Fcons twice.
12176 (Fdecode_time): More accurate test for out-of-range times.
12177 (check_tm_member): New function.
12178 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12179 (lisp_time_argument): Don't rely on undefined left-shift and
12180 right-shift behavior when checking for time stamp overflow.
8be6f318 12181
fe31d94c
PE
12182 * editfns.c (time_overflow): New function, refactoring common code.
12183 (Fformat_time_string, Fdecode_time, Fencode_time):
12184 (Fcurrent_time_string): Use it.
12185
8be6f318
PE
12186 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12187 * dired.c (make_time): Move to ...
12188 * editfns.c (make_time): ... here.
12189 * systime.h: Note the move.
12190
09d9db2c 121912011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12192
126bc0dc
YM
12193 * fringe.c (update_window_fringes): Remove unused variables.
12194
c47cbdfd
YM
12195 * unexmacosx.c (copy_data_segment): Also copy __got section.
12196 (Bug#8223)
12197
7ac80be9
EZ
121982011-03-12 Eli Zaretskii <eliz@gnu.org>
12199
c96bbc66 12200 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12201 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12202 Constify `char *' arguments and their references according to
12203 prototypes in tparam.h.
12204
ecb0f94d 12205 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12206
7ac80be9
EZ
12207 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12208 Adapt all references accordingly.
12209
12210 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12211
ef1fd07e
TT
122122011-03-11 Tom Tromey <tromey@redhat.com>
12213
12214 * buffer.c (syms_of_buffer): Remove obsolete comment.
12215
7ef4b50c
EZ
122162011-03-11 Eli Zaretskii <eliz@gnu.org>
12217
12218 * termhooks.h (encode_terminal_code): Declare prototype.
12219
12220 * msdos.c (encode_terminal_code): Don't declare prototype.
12221
12222 * term.c (encode_terminal_code): Now external again, used by
12223 w32console.c and msdos.c.
12224
44f230aa
SM
12225 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12226 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12227
4b1ec863 122282011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12229
1714f52b 12230 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12231
4b1ec863
PE
12232 * fringe.c (update_window_fringes): Mark locals as initialized
12233 (Bug#8227).
12234 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12235
524c7aa6
PE
12236 * alloc.c (mark_fringe_data): Move decl from here ...
12237 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12238 to check its interface.
12239 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12240
a5c0af81 12241 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12242 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12243 (fontset_font): Mark local as initialized.
a9a06e0b 12244 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12245
b4716021
PE
12246 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12247
811e9bac 12248 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12249 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12250 (x_own_selection, Fx_disown_selection_internal): Rename locals
12251 to avoid shadowing.
12252 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12253
7e3ab302
PE
12254 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12255 so that the caller can use some name other than gcpro1.
12256 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
12257 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12258 (Fx_backspace_delete_keys_p):
12259 Use them to avoid shadowing, and rename vars to avoid shadowing.
12260 (x_decode_color, x_set_name, x_window): Now static.
6b437900 12261 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 12262 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
12263 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
12264 Remove unused locals.
7e3ab302
PE
12265 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
12266 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
12267 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
12268 macros.
f78faa98 12269
e2b13473
PE
12270 * xterm.h (x_mouse_leave): New decl.
12271
77f23912
PE
12272 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
12273 Remove unused functions.
cdf4ba58
PE
12274 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
12275 (x_calc_absolute_position): Now static.
7411c686 12276 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 12277 Don't declare local "event" unless it's used.
ed7bf3a5
PE
12278 (x_iconify_frame, x_free_frame_resources): Don't declare locals
12279 unless they are used.
38d0b34a
PE
12280 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
12281 (x_fatal_error_signal): Remove; not used.
a6067996
PE
12282 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
12283 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
12284 (x_error_catcher, x_connection_closed, x_error_handler):
12285 (x_error_quitter, xembed_send_message, x_iconify_frame):
12286 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 12287 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 12288 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 12289
44f230aa
SM
12290 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
12291 Rename or move locals to avoid shadowing.
6b463e58 12292 (tty_defined_color, merge_face_heights): Now static.
5967d051 12293 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
12294 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
12295 does not deduce is never used uninitialized.
73719eba
PE
12296 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
12297 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 12298
426994c3 12299 * terminal.c (store_terminal_param): Now static.
5489860b 12300
032f1620 12301 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 12302 (set_frame_menubar): Remove unused local.
d4323972 12303 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
12304 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
12305 since they might point to immutable storage.
281585b0
PE
12306 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
12307 since it's unused otherwise.
032f1620 12308
367c19e5 12309 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 12310 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
12311 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
12312 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 12313 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
12314 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
12315 does not deduce are never used uninitialized.
70739cbe 12316
07b48fa9
PE
12317 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
12318
8868a238 12319 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
12320 * window.c (window_loop, size_window):
12321 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 12322
7e5cf297 12323 * window.c (display_buffer): Now static.
d6550a9f
PE
12324 (size_window): Mark variables that gcc -Wuninitialized
12325 does not deduce are never used uninitialized.
a586633d
PE
12326 * window.h (check_all_windows): New decl, to forestall
12327 gcc -Wmissing-prototypes diagnostic.
5b555da1 12328 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 12329
f6095868
PE
12330 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
12331 shadowing.
12332 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
12333 Include <limits.h>.
12334 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
12335 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
12336 (load_charset_map): Mark variables that gcc -Wuninitialized
12337 does not deduce are never used uninitialized.
53df7c11 12338 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 12339
f38b440c
PE
12340 * coding.c (coding_set_source, coding_set_destination):
12341 Use "else { /* comment */ }" rather than "else /* comment */;"
12342 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
12343 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
12344 a block, when the outer 'i' will do.
12345 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
12346 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
12347 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
12348 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
12349 (Fdecode_sjis_char, Fdefine_coding_system_internal):
12350 Rename locals to avoid shadowing.
12351 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
12352 * coding.c (emacs_mule_char, encode_invocation_designation):
12353 Now static, since they're not used elsewhere.
413bb2db 12354 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 12355 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
12356 (decode_coding_emacs_mule): Mark variables that gcc
12357 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
12358 (detect_coding_iso_2022): Initialize a local variable that might
12359 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 12360 this initialization is needed. (Bug#8211)
5f58e762
PE
12361 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
12362 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
12363 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
12364 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
12365 Remove unused macros.
f38b440c 12366
232b38b9 12367 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 12368 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 12369 * character.c (string_count_byte8): Likewise.
232b38b9 12370
fb90da1b
PE
12371 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
12372 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
12373
fb93dbc2
PE
12374 * chartab.c (copy_sub_char_table): Now static, since it's not used
12375 elsewhere.
5c156ace
PE
12376 (sub_char_table_ref_and_range, char_table_ref_and_range):
12377 Rename locals to avoid shadowing.
bbcd0949 12378 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 12379
7d3b3862 12380 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 12381 (BIDI_BOB): Remove unused macro.
7d3b3862 12382
6be7d3da
PE
12383 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
12384 deduce are never used uninitialized.
c2ed9c8b 12385 * term.c (encode_terminal_code): Likewise.
6be7d3da 12386
75f8807f 12387 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 12388
50938595
PE
12389 * tparam.h: New file.
12390 * term.c, tparam.h: Include it.
12391 * deps.mk (term.o, tparam.o): Depend on tparam.h.
12392 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
12393 Move these decls to tparam.h, and make them agree with what
12394 is actually in tparam.c. The previous trick of using incompatible
12395 decls in different modules does not conform to the C standard.
12396 All callers of tparam changed to use tparam's actual API.
12397 * tparam.c (tparam1, tparam, tgoto):
12398 Use const pointers where appropriate.
12399
fbceeba2
PE
12400 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
12401 * cm.h (struct cm): Likewise.
12402 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
12403 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
12404 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
12405 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
12406 (turn_on_face, init_tty): Likewise.
12407 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 12408
7f3f1250
PE
12409 * term.c (term_mouse_position): Rename local to avoid shadowing.
12410
e6ca6543
PE
12411 * alloc.c (mark_ttys): Move decl from here ...
12412 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
12413
c40f8d15
AS
124142011-03-11 Andreas Schwab <schwab@linux-m68k.org>
12415
12416 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
12417
cfe0661d
JB
124182011-03-09 Juanma Barranquero <lekktu@gmail.com>
12419
12420 * search.c (compile_pattern_1): Remove argument regp, unused since
12421 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
12422 (compile_pattern): Don't pass it.
12423
0afb4571
J
124242011-03-08 Jan Djärv <jan.h.d@swipnet.se>
12425
12426 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
12427 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
12428 for ! HAVE_GTK3.
12429 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
12430
12431 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
12432
12433 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
12434 gdk_window_get_screen, gdk_window_get_geometry,
12435 gdk_x11_window_lookup_for_display and GDK_KEY_g.
12436 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
12437 (xg_get_pixbuf_from_pixmap): New function.
12438 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
12439 to Pixmap, take frame as parameter, remove GdkColormap parameter.
12440 Call xg_get_pixbuf_from_pixmap instead of
12441 gdk_pixbuf_get_from_drawable.
12442 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
12443 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
12444 (xg_check_special_colors): Use GtkStyleContext and its functions
12445 for HAVE_GTK3.
12446 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
12447 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
12448 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
12449 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
12450 Call gtk_widget_get_preferred_size.
0afb4571
J
12451 (xg_frame_resized): gdk_window_get_geometry only takes 5
12452 parameters.
44f230aa
SM
12453 (xg_win_to_widget, xg_event_is_for_menubar):
12454 Call gdk_x11_window_lookup_for_display.
0afb4571
J
12455 (xg_set_widget_bg): New function.
12456 (delete_cb): New function.
895009e1 12457 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 12458 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
12459 (xg_set_background_color): Call xg_set_widget_bg.
12460 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
12461 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
12462 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
12463 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
12464 if ! HAVE_GTK3.
12465 (update_frame_tool_bar): Call gtk_widget_hide.
12466 (xg_initialize): Use GDK_KEY_g.
12467
12468 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
12469 if ! HAVE_GTK3
12470 (x_session_initialize): Call gdk_x11_set_sm_client_id.
12471
12472 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
12473 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
12474 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
12475
1c2cc4ef
JB
124762011-03-08 Juanma Barranquero <lekktu@gmail.com>
12477
12478 * w32xfns.c (select_palette): Check success of RealizePalette against
12479 GDI_ERROR, not zero.
12480
33383987 12481See ChangeLog.11 for earlier changes.
aac0c6e3
MR
12482
12483;; Local Variables:
12484;; coding: utf-8
aac0c6e3
MR
12485;; End:
12486
2f097256 12487 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
12488
12489 This file is part of GNU Emacs.
12490
12491 GNU Emacs is free software: you can redistribute it and/or modify
12492 it under the terms of the GNU General Public License as published by
12493 the Free Software Foundation, either version 3 of the License, or
12494 (at your option) any later version.
12495
12496 GNU Emacs is distributed in the hope that it will be useful,
12497 but WITHOUT ANY WARRANTY; without even the implied warranty of
12498 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
12499 GNU General Public License for more details.
12500
12501 You should have received a copy of the GNU General Public License
12502 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.