* process.c (wait_reading_process_output): 'waitchannels' was unset
[bpt/emacs.git] / src / ChangeLog
CommitLineData
26bccfae
PE
12012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2
a0bee46f
PE
3 * process.c (wait_reading_process_output): 'waitchannels' was unset
4 when read_kbd || !NILP (wait_for_cell); fix this.
5
5994c183
PE
6 Add GCC-style 'const' attribute to functions that can use it.
7 * character.h (char_resolve_modifier_mask):
8 * keyboard.h (make_ctrl_char):
9 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
10 (init_character_once, next_almost_prime, init_fns, init_image)
11 (flush_pending_output, init_sound):
12 * mem-limits.h (start_of_data):
13 * menu.h (finish_menu_items):
14 Add ATTRIBUTE_CONST.
15 * emacs.c (DEFINE_DUMMY_FUNCTION):
16 Declare the dummy function with ATTRIBUTE_CONST.
17 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
18 Add decls with ATTRIBUTE_CONST.
19
26bccfae
PE
20 Minor improvements to make_formatted_string.
21 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
22 where int is good enough, as vsprintf returns an int.
23 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
24
a8290ec3
DA
252012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
26
27 Use make_formatted_string to avoid double length calculation.
28 * lisp.h (make_formatted_string): New prototype.
29 * alloc.c (make_formatted_string): New function.
30 * buffer.c (Fgenerate_new_buffer_name): Use it.
31 * dbus.c (syms_of_dbusbind): Likewise.
32 * editfns.c (Fcurrent_time_zone): Likewise.
33 * filelock.c (get_boot_time): Likewise.
34 * frame.c (make_terminal_frame, set_term_frame_name)
35 (x_report_frame_params): Likewise.
36 * image.c (gs_load): Likewise.
37 * minibuf.c (get_minibuffer): Likewise.
38 * msdos.c (dos_set_window_size): Likewise.
39 * process.c (make_process): Likewise.
40 * xdisp.c (ensure_echo_area_buffers): Likewise.
41 * xsettings.c (apply_xft_settings): Likewise.
42
d01ba2f1
GM
432012-07-09 Glenn Morris <rgm@gnu.org>
44
45 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
46 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
47 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
48 * nsterm.h (ns_etc_directory): Add it.
49 * callproc.c [HAVE_NS]: Include nsterm.h.
50 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
51
f1f924b6
DA
522012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
53
54 Move marker debugging code under MARKER_DEBUG.
55 * marker.c (MARKER_DEBUG): Move marker debugging code under
56 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
57 for bootstrap with --enable-checking (~3x slowdown reported
58 by Juanma Barranquero <lekktu@gmail.com>).
59 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
60
ab531b66
PE
612012-07-08 Paul Eggert <eggert@cs.ucla.edu>
62
63 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
64 See <http://bugs.gnu.org/11825#29>.
65
c4b3bc8a
EZ
662012-07-08 Eli Zaretskii <eliz@gnu.org>
67
68 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
69 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
70 (display_line): Add commentary about displaying truncation glyphs
71 on GUI frames.
72 (produce_special_glyphs): Move here from term.c.
73
74 * term.c (produce_special_glyphs): Move to xdisp.c.
75
76 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
77 section.
c4b3bc8a 78
b676b881
AS
792012-07-07 Andreas Schwab <schwab@linux-m68k.org>
80
f17c5273
AS
81 * xdisp.c (display_line): Avoid warning about implicit declaration
82 of FRAME_FONT.
83
298819b9
AS
84 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
85
b676b881
AS
86 * lisp.h: Remove empty conditional.
87
6045c4fd
PE
882012-07-07 Paul Eggert <eggert@cs.ucla.edu>
89
b3350bf9
PE
90 * lread.c (load_path_check): Now static.
91
6045c4fd
PE
92 Fix some minor --with-ns problems found by static checking.
93 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
94 (x_set_font) [!HAVE_X_WINDOWS]:
95 * image.c (xpm_load_image) [HAVE_NS]:
96 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
97 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
98 Remove unused local.
99 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
100 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
101 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
102 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
103 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
104 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
105 Fix pointer signedness problem.
106 * xfaces.c (FRAME_X_FONT_TABLE):
107 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
108
929e7845
GM
1092012-07-07 Glenn Morris <rgm@gnu.org>
110
111 * lread.c (load_path_check): New function, split from init_lread.
112 (init_lread): Reorganize. Motivation:
113 If EMACSLOADPATH is set, check/warn about that rather than the
114 defaults, which we are not going to use. Hence we can remove
115 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
116 Don't warn if site-lisp directories are missing.
117 If not installed, start from a blank load-path, since
118 PATH_LOADSEARCH refers to the eventual installation directories.
119
58dd0aa4
EZ
1202012-07-07 Eli Zaretskii <eliz@gnu.org>
121
122 Support truncation and continuation glyphs on GUI frames, when
123 fringes are disabled. (Bug#11832)
124 * xdisp.c (init_iterator): Get dimensions of truncation and
125 continuation glyphs even if on GUI frames. Adjust
126 it->last_visible_x on GUI frames when the left or right fringes,
127 or both, are absent.
128 (start_display, move_it_in_display_line_to): Handle the case of a
129 GUI frame without a fringe to display continuation or truncation
130 glyphs.
131 (insert_left_trunc_glyphs): Support GUI frames: make sure
132 truncation glyphs overwrite enough glyphs from the current line to
133 have sufficient space in pixels.
134 (display_line): Support truncation and continuation glyphs on GUI
135 frames. If some spare pixels are left on the line after inserting
136 the truncation glyphs, fill that space with a stretch glyph of a
137 suitably computed width.
138
139 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
140 produce_glyphs, to support GUI sessions.
141
31571fd7
PE
1422012-07-07 Paul Eggert <eggert@cs.ucla.edu>
143
5a16b9bc
PE
144 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
145
f3047c75
PE
146 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
147
31571fd7
PE
148 Do not require float-time's arg to fit in time_t (Bug#11825).
149 This works better on hosts where time_t is unsigned, and where
150 float-time is applied to the (negative) difference between two times.
151 * editfns.c (decode_time_components): Last arg is now double *,
152 not int *, and means to store all the result as a double, without
153 worrying about whether the seconds part fits in time_t.
154 All callers changed.
155 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
156 All callers changed.
157 (Ffloat_time): Do not fail merely because the specified time falls
158 outside of time_t range.
159
4516fbef
GM
1602012-07-07 Glenn Morris <rgm@gnu.org>
161
162 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
163 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
164 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
165
07adc2c6
JB
1662012-07-07 Juanma Barranquero <lekktu@gmail.com>
167
168 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
169 Update dependencies.
170
171 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
172
fd573f31
PE
1732012-07-06 Paul Eggert <eggert@cs.ucla.edu>
174
fee5959d
PE
175 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
176 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
177 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
178 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
179 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
180 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
181
fd573f31
PE
182 * xfont.c (compare_font_names): Redo to omit the need for casts.
183
ddadbc0e
AS
1842012-07-06 Andreas Schwab <schwab@linux-m68k.org>
185
fca8d6b6
AS
186 * xfns.c (Fx_change_window_property): Doc fix.
187 * w32fns.c (Fx_change_window_property): Doc fix.
188
ddadbc0e
AS
189 * w32fns.c (Fx_window_property): Accept the same arguments as the
190 X Windows version. Doc fix.
191 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
192
f247498e
JB
1932012-07-06 Juanma Barranquero <lekktu@gmail.com>
194 Eli Zaretskii <eliz@gnu.org>
195
196 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
197 Windows-specific code from nt/config.nt moved here.
198 Obsolete settings removed.
199
216ee680
PE
2002012-07-06 Paul Eggert <eggert@cs.ucla.edu>
201
202 * process.c: Avoid unnecessary calls to gettime.
203 (wait_reading_process_output): Don't get the time of day
204 when gobbling data immediately and not waiting, as there's no need
205 for it in that case. This removes a FIXME.
206
bdd091e4
JD
2072012-07-06 Jan Djärv <jan.h.d@swipnet.se>
208
209 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
210 is defined (Bug#11768).
211
9d44f8ce
DA
2122012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
213
214 Fix marker debugging code.
215 * marker.c (byte_char_debug_check): Do not perform the check
216 if buffer is not multibyte.
090bd7cb
JB
217 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
218 Call byte_char_debug_check with correct arguments.
9d44f8ce 219
90fc4786
DA
2202012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
221
222 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
223 * marker.c (byte_char_debug_check, count_markers):
224 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
225 (byte_debug_flag): Remove.
226 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
227 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
228
7b7ae965
DA
2292012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
230
4e57b342
DA
231 Avoid code repetition in marker-related functions.
232 * marker.c (attach_marker): New function.
233 (Fset_marker, set_marker_restricted, set_marker_both)
234 (set_marker_restricted_both): Use it.
235 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
236 Consistently rename charno to charpos.
237 (marker_position): Add eassert.
238 (marker_byte_position): Convert to eassert.
239
2402012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
241
242 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 243 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 244 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 245
657924ff
DA
2462012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
247
248 Introduce fast path for the widely used marker operation.
249 * alloc.c (build_marker): New function.
250 * lisp.h (build_marker): New prototype.
251 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
252 * composite.c (autocmp_chars): Likewise.
253 * editfns.c (buildmark): Remove.
254 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
255 (save_restriction_save): Use build_marker.
256 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
257 * window.c (save_window_save): Likewise.
258
041a49a6
DA
2592012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
260
261 Do not use Fdelete_overlay in delete_all_overlays
262 to avoid redundant calls to unchain_overlay.
263 * buffer.c (drop_overlay): New function.
264 (delete_all_overlays, Fdelete_overlay): Use it.
265 * minibuf.c (get_minibuffer): Fix comment.
266
7dca65a4
PE
2672012-07-06 Paul Eggert <eggert@cs.ucla.edu>
268
269 Port to OpenBSD 5.1 amd64.
270 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
271 This is needed for OpenBSD, and should be harmless on all BSD systems.
272 Also, include <sys/sysctl.h>, as it should be available on all
273 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
274 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
275 use p_pid member, not kp_proc.pid.
276
8eb876e2
GM
2772012-07-06 Glenn Morris <rgm@gnu.org>
278
279 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
280
38182d90
PE
2812012-07-05 Paul Eggert <eggert@cs.ucla.edu>
282
283 More xmalloc and related cleanup.
284 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
285 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
286 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
287 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
288 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
289 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
290 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
291 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
292 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
293 * xterm.c:
294 Omit needless casts involving void * pointers and allocation.
295 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
296 as the former is more robust if P's type is changed.
297 Prefer xzalloc to xmalloc + memset 0.
298 Simplify malloc-or-realloc to realloc.
299 Don't worry about xmalloc returning a null pointer.
300 Prefer xstrdup to xmalloc + strcpy.
301 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
302 growing it.
303 * keyboard.c (apply_modifiers_uncached): Prefer local array to
304 alloca of a constant.
305
6dd5a677
EZ
3062012-07-05 Eli Zaretskii <eliz@gnu.org>
307
308 * xdisp.c (display_line): Fix horizontal pixel coordinates when
309 hscroll is larger than the line width. Fixes long and futile
310 looping inside extend_face_to_end_of_line (on a TTY) producing
311 glyphs that are not needed and thrown away.
312
6b312f0f
DA
3132012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
314
315 * marker.c (set_marker_restricted_both): Simplify by using
316 clip_to_bounds.
317
f520ef9b
PE
3182012-07-05 Paul Eggert <eggert@cs.ucla.edu>
319
320 * editfns.c (region_limit): Simplify by using clip_to_bounds.
321
383b7c95
JD
3222012-07-05 Jan Djärv <jan.h.d@swipnet.se>
323
324 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
325 not defined (Bug#11768).
326 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
327 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
328 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
329 followed by gtk_box_set_homogeneous (Bug#11768).
330 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
331 (update_theme_scrollbar_width, xg_create_scroll_bar):
332 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
333 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
334 (is_box_type): New function (Bug#11768).
335 (xg_tool_item_stale_p): Call is_box_type.
5293d758 336 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
337 with default display (Bug#11768).
338
d6e7bf45
EZ
3392012-07-05 Eli Zaretskii <eliz@gnu.org>
340
341 * xdisp.c (window_hscroll_limited): New function.
342 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
343 coordinates when window's hscroll is set to insanely large
344 values. (Bug#11857)
345
431391ec
JB
3462012-07-05 Juanma Barranquero <lekktu@gmail.com>
347
348 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
349 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
350
23f86fce
DA
3512012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
352
353 Cleanup xmalloc.
354 * lisp.h (xzalloc): New prototype. Omit needless casts.
355 * alloc.c (xzalloc): New function. Omit needless casts.
356 * charset.c: Omit needless casts. Convert all calls to
357 xmalloc with following memset to xzalloc.
358 * dispnew.c: Likewise.
359 * fringe.c: Likewise.
360 * image.c: Likewise.
361 * sound.c: Likewise.
362 * term.c: Likewise.
363 * w32fns.c: Likewise.
364 * w32font.c: Likewise.
365 * w32term.c: Likewise.
366 * xfaces.c: Likewise.
367 * xfns.c: Likewise.
368 * xterm.c: Likewise.
369 * atimer.c: Omit needless casts.
370 * buffer.c: Likewise.
371 * callproc.c: Likewise.
372 * ccl.c: Likewise.
373 * coding.c: Likewise.
374 * composite.c: Likewise.
375 * doc.c: Likewise.
376 * doprnt.c: Likewise.
377 * editfns.c: Likewise.
378 * emacs.c: Likewise.
379 * eval.c: Likewise.
380 * filelock.c: Likewise.
381 * fns.c: Likewise.
382 * gtkutil.c: Likewise.
383 * keyboard.c: Likewise.
384 * lisp.h: Likewise.
385 * lread.c: Likewise.
386 * minibuf.c: Likewise.
387 * msdos.c: Likewise.
388 * print.c: Likewise.
389 * process.c: Likewise.
390 * region-cache.c: Likewise.
391 * search.c: Likewise.
392 * sysdep.c: Likewise.
393 * termcap.c: Likewise.
394 * terminal.c: Likewise.
395 * tparam.c: Likewise.
396 * w16select.c: Likewise.
397 * w32.c: Likewise.
398 * w32reg.c: Likewise.
399 * w32select.c: Likewise.
400 * w32uniscribe.c: Likewise.
401 * widget.c: Likewise.
402 * xdisp.c: Likewise.
403 * xmenu.c: Likewise.
404 * xrdb.c: Likewise.
405 * xselect.c: Likewise.
406
0497dc44
PE
4072012-07-05 Paul Eggert <eggert@cs.ucla.edu>
408
409 * fileio.c (time_error_value): Check the right error number.
410 Problem reported by Troels Nielsen in
411 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
412
356e7178
PE
4132012-07-04 Paul Eggert <eggert@cs.ucla.edu>
414
4e71fd89
PE
415 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
416 This should be fixed in a better way; see Eli Zaretskii in
417 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
418 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
419
f0941253
PE
420 * fileio.c (time_error_value): Rename from special_mtime.
421 The old name's problems were noted by Eli Zaretskii in
422 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
423
065c9eb4
PE
424 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
425 This variable's comment says Emacs needs at least one GDB-visible
426 symbol of type enum pvec_type, to work around GDB problems.
427 The symbol's value doesn't matter.
428
356e7178
PE
429 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
430 that causes compilation to fail on pre-C99 compilers.
431
95f61aa2
JB
4322012-07-04 Juanma Barranquero <lekktu@gmail.com>
433
434 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
435 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
436
3884d954
DA
4372012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
438
d209e2fb 439 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
440 headers for buffer_defaults and buffer_local_symbols.
441 Reported by Juanma Barranquero <lekktu@gmail.com>.
442
ee28be33
SM
4432012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
444
445 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
446 * lisp.h (enum pvec_type): Use fewer bits.
447 (PSEUDOVECTOR_SIZE_BITS): New constant.
448 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
449 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
450 change in pvec_type.
451 (PSEUDOVECTOR_TYPEP): New macro.
452 (TYPED_PSEUDOVECTORP): Use it.
453 * fns.c (internal_equal): Adapt code to extract pvectype.
454 * emacs.c (gdb_pvec_type): Update type.
455 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
456 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
457 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
458 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
459 (sweep_vectors): Use it. Use local var `total_bytes' instead of
460 abusing vector->header.next.nbytes.
461 (live_vector_p): Use PVEC_TYPE.
462 (mark_object): Adapt code to extract pvectype. Use switch.
463
c7f2cd7f
PE
4642012-07-04 Paul Eggert <eggert@cs.ucla.edu>
465
466 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
467 Tighten new eassert a bit.
468
8ce70ed2
DA
4692012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
470
471 Fix compilation with --enable-gcc-warnings and -O1
472 optimization level.
473 * doprnt.c (doprnt): Change type of tem to int, initialize
474 to avoid compiler warning. Add eassert.
475 * search.c (simple_search): Initialize match_byte to avoid
476 compiler warning. Add eassert.
477
dea7f1e5
PE
4782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
479
24a212eb
PE
480 Avoid weird behavior with large horizontal scrolls.
481 Without this change, for example, large hscroll values would
482 mess up Emacs's display on Fedora 15 x86, presumably due to
483 overflows in int calculations in the display code.
484 Also, if buffers had long lines, Emacs would freeze.
485 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
486 (set_window_hscroll): New function, containing the old guts of
487 Fset_window_hscroll. Return the clipped value.
488 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
489 This avoids the need to check against PTRDIFF_MAX.
490
dea7f1e5
PE
491 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
492
76046526
DA
4932012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
494
495 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
496
39adff0d
PE
4972012-07-04 Paul Eggert <eggert@cs.ucla.edu>
498
63807d47
PE
499 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
500 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
501 since GCC 4.4.6 issues a bogus warning for them.
502
39adff0d
PE
503 Fix bugs in file timestamp newness comparisons.
504 * fileio.c (Ffile_newer_than_file_p):
505 * lread.c (Fload): Use full timestamp resolution of files,
506 not just the 1-second resolution, so that files that are only
507 slightly newer still count as newer.
508 * fileio.c (Ffile_newer_than_file_p): Don't assume file
509 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
510
dbeed9a6
PE
5112012-07-03 Paul Eggert <eggert@cs.ucla.edu>
512
513 * fileio.c: Improve handling of file time marker. (Bug#11852)
514 (special_mtime): New function.
515 (Finsert_file_contents, Fverify_visited_file_modtime):
516 Use it to set special mtime values consistently.
517
636334d6
AS
5182012-07-03 Andreas Schwab <schwab@linux-m68k.org>
519
520 * fileio.c (Finsert_file_contents): Properly handle st_mtime
521 marker for non-existing file. (Bug#11852)
522
e2017fe2
GM
5232012-07-03 Glenn Morris <rgm@gnu.org>
524
525 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
526 and did not make it into globals.h).
527
404dbd37
TT
5282012-07-03 Tom Tromey <tromey@redhat.com>
529
530 * window.c (Fset_window_margins, Fset_window_fringes)
531 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
532 * textprop.c (Fprevious_property_change): No longer static.
533 * syntax.c (Fsyntax_table_p): No longer static.
534 * process.c (Fget_process, Fprocess_datagram_address): No longer
535 static.
536 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
537 * keyboard.c (Fcommand_execute): No longer static.
538 Remove EXFUN.
539 * insdel.c (Fcombine_after_change_execute): No longer static.
540 * image.c (Finit_image_library): No longer static.
541 * fileio.c (Fmake_symbolic_link): No longer static.
542 * eval.c (Ffetch_bytecode): No longer static.
543 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
544 * doc.c (Fdocumentation_property, Fsnarf_documentation):
545 No longer static.
404dbd37
TT
546 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
547 static.
548 * dired.c (Ffile_attributes): No longer static.
549 * composite.c (Fcomposition_get_gstring): No longer static.
550 * callproc.c (Fgetenv_internal): No longer static.
551
552 * ccl.h: Remove EXFUNs.
553 * buffer.h: Remove EXFUNs.
554 * dispextern.h: Remove EXFUNs.
555 * intervals.h: Remove EXFUNs.
556 * fontset.h: Remove EXFUN.
557 * font.h: Remove EXFUNs.
558 * dosfns.c (system_process_attributes): Remove EXFUN.
559 * keymap.h: Remove EXFUNs.
560 * lisp.h: Remove EXFUNs.
561 * w32term.h: Remove EXFUNs.
562 * window.h: Remove EXFUNs.
563 * xsettings.h: Remove EXFUN.
564 * xterm.h: Remove EXFUN.
565
8e4fd1e1
GM
5662012-07-03 Glenn Morris <rgm@gnu.org>
567
568 * lisp.h (Frandom): Make it visible to C.
569 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
570 buffer for invisible buffers. (Bug#1229)
571
ca95b3eb
DA
5722012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
573
574 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
575 values which aren't power of 2.
576 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
577 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
578 accordingly.
579
7555c33f
SM
5802012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
581
582 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
583
584 * alloc.c (mark_object): Revert part of last patch to use `switch'.
585
d12e8f5a
DA
5862012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
587
588 * alloc.c (allocate_vector_block): Remove redundant
589 calls to mallopt if DOUG_LEA_MALLOC is defined.
590 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
591 avoid calls to mallopt if zero_vector is returned.
592
296094c3
DA
5932012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
594
595 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
596 is enabled, avoid dereferencing NULL current_sblock if
597 running undumped.
598
36429c89
DA
5992012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Cleanup basic buffer management.
602 * buffer.h (struct buffer): Change layout to use generic vector
603 marking code. Fix some comments. Change type of 'clip_changed'
604 to bitfield. Remove unused #ifndef old.
605 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
606 (GET_OVERLAYS_AT): Fix indentation.
607 (for_each_per_buffer_object_at): New macro.
608 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
609 (Fbuffer_local_variables): Use it.
610 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
611 * alloc.c (allocate_buffer): Adjust to match new layout of
612 struct buffer. Fix comment.
613 (mark_overlay): New function.
614 (mark_buffer): Use it. Use mark_vectorlike to mark normal
615 Lisp area of struct buffer.
616 (mark_object): Use it. Adjust marking of misc objects
617 and related comments.
618
3b3e4cac
PE
6192012-07-02 Paul Eggert <eggert@cs.ucla.edu>
620
621 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
622 wrapper that is not needed because the wrapped code is a no-op (zero
623 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
624 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
625
cf5c0175
DA
6262012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
627
628 * alloc.c (mark_buffer): Simplify. Remove prototype.
629 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 630 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
631 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
632 redundant calls to mark_vectorlike for bool vectors.
633
ca26824c
GM
6342012-06-30 Glenn Morris <rgm@gnu.org>
635
2e4c5312
GM
636 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
637
ca26824c
GM
638 * epaths.in (PATH_SITELOADSEARCH): New.
639 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
640 This is rather than relying on --enable-locallisppath elements
641 having "site-lisp" in their names. (Bug#10208#25, 11658)
642
0d23c240
EZ
6432012-06-30 Eli Zaretskii <eliz@gnu.org>
644
c9240d7a
EZ
645 * w32proc.c (sys_select): Accept and ignore one more argument.
646
647 * w32.c (emacs_gnutls_pull): Call select with one more argument.
648
0d23c240 649 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 650 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
651
652 * sysdep.c: Don't include dos.h and dosfns.h.
653
654 * process.c (sys_select):
655 * msdos.c (sys_select): Accept one more argument and ignore it.
656
657 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
658 adapt data types and code to that.
659
660 * dosfns.c:
661 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
662 which clashes with the gnulib function of the same name.
663
af5a5a98
AS
6642012-06-30 Andreas Schwab <schwab@linux-m68k.org>
665
c5e4379c
AS
666 * font.c (font_style_to_value, font_style_symbolic)
667 (font_prop_validate_style): Add type checks for values in
668 font_style_table.
669
af5a5a98
AS
670 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
671 argument.
672 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
673 uses.
674
8d38f461
EZ
6752012-06-29 Eli Zaretskii <eliz@gnu.org>
676
2e5a6631
EZ
677 * xdisp.c (try_window_id): Undo last change.
678
8d38f461
EZ
679 * w32.c (getwd): Adjust commentary about startup_dir.
680 (init_environment): Always call sys_access, even in non-MSVC
681 builds. Don't chdir to the directory of the Emacs executable.
682 This undoes code from 1997 which was justified by the need to
683 "avoid conflicts when removing and renaming directories". But its
684 downside was that every relative file name was being interpreted
685 relative to the directory of the Emacs executable, which can never
686 be TRT. In particular, it broke sys_access when called with
687 relative file names.
688 (sys_access): Map GetLastError to errno.
689
2af3565e
DA
6902012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
691
692 * window.h (struct window): Change type of 'fringes_outside_margins'
693 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 694 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
695 Adjust comment.
696 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
697 to ptrdiff_t.
698
c8d3a25c 6992012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 700
c8d3a25c
GM
701 * gnutls.c (emacs_gnutls_handshake):
702 Add QUIT to make the loop interruptible.
57570cd3 703
c8d3a25c 7042012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 705
c8d3a25c
GM
706 * charset.c (init_charset): Make lack of etc/charsets fatal.
707
3e984ee8
DA
7082012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
709
710 * editfns.c (region_limit): Fix type mismatch.
711
ef884f23
DA
7122012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
713
714 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
715 undefined. Convert from xassert to eassert.
716 * nsmenu.m: Convert from xassert to eassert.
717 * nsterm.m: Likewise.
718
7d7e0027
SM
7192012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
720
721 * editfns.c (region_limit): Clip to narrowing (bug#11770).
722
aa754e6a
PE
7232012-06-28 Paul Eggert <eggert@cs.ucla.edu>
724
725 Avoid integer overflow on scroll-left and scroll-right.
726 * window.c (HSCROLL_MAX): New macro.
727 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
728 overflow when requested scroll falls outside ptrdiff_t range.
729
80b00b08
DA
7302012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
731
732 * window.h (struct window): Change type of 'hscroll',
733 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
734 'last_modified' and 'last_overlay_modified' to EMACS_INT.
735 Adjust users accordingly.
736 * xdisp.c (try_cursor_movement): Replace type check with eassert.
737 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
738 from EMACS_INT to ptrdiff_t.
739 (make_window): Omit redundant initialization.
740
62b2bcf6
JB
7412012-06-28 Juanma Barranquero <lekktu@gmail.com>
742
743 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
744
45942c7d
DA
7452012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
746
747 * window.h (struct window): Change type of 'use_time' and
748 'sequence_number' from Lisp_Object to int.
749 * frame.c (make_frame): Adjust users accordingly.
750 * print.c (print_object): Likewise.
751 * window.c (select_window, Fwindow_use_time, make_parent_window)
752 (make_window): Likewise.
753
e509cfa6
DA
7542012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
755
756 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
757 enabled with --enable-checking=[all,glyphs] configure option.
758 Fix GLYPH_DEBUG usage assuming that it may be undefined,
759 adjust comments accordingly.
760 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
761 undefined, adjust comments accordingly.
762 * image.c: Likewise.
763 * scroll.c: Likewise.
764 * w32fns.c: Likewise.
765 * w32term.c: Likewise.
766 * xdisp.c: Likewise.
767 * xfaces.c: Likewise.
768 * xfns.c: Likewise.
769 * xterm.c: Likewise.
770
a54e2c05
DA
7712012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
772
773 Generalize run-time debugging checks.
774 * dispextern.h (XASSERTS): Remove.
775 * fontset.c (xassert): Remove.
776 Convert from xassert to eassert.
777 * alloc.c: Convert from xassert to eassert.
778 * bidi.c: Likewise.
779 * dispnew.c: Likewise.
780 * fns.c: Likewise.
781 * fringe.c: Likewise.
782 * ftfont.c: Likewise.
783 * gtkutil.c: Likewise.
784 * image.c: Likewise.
785 * keyboard.c: Likewise.
786 * menu.c: Likewise.
787 * process.c: Likewise.
788 * scroll.c: Likewise.
789 * sound.c: Likewise.
790 * term.c: Likewise.
791 * w32console.c: Likewise.
792 * w32fns.c: Likewise.
793 * w32term.c: Likewise.
794 * window.c: Likewise.
795 * xdisp.c: Likewise.
796 * xfaces.c: Likewise.
797 * xfns.c: Likewise.
798 * xselect.c: Likewise.
799 * xterm.c: Likewise.
800
1ec4b7b2
SM
8012012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 * fns.c (maybe_resize_hash_table): Output message when growing the
804 purify-hashtable.
805
2014308a
DA
8062012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
807
808 * alloc.c (allocate_string_data): Remove dead code.
809 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
810 avoid GCC warning about unused macro.
811
246155eb
DA
8122012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
813
814 * alloc.c (allocate_string): Omit intervals initialization.
815 * alloc.c (make_uninit_multibyte_string): Initialize intervals
816 as in make_pure_string and make_pure_c_string.
817
43184b7b
DA
8182012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
819
d209e2fb 820 * alloc.c (allocate_string): Fix last change.
43184b7b 821
3fe6dd74
DA
8222012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
823
d209e2fb 824 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
825 to memset, add explicit initialization where appropriate.
826
1ba6038a
GM
8272012-06-27 Glenn Morris <rgm@gnu.org>
828
829 * lisp.mk (lisp): Remove paths.elc.
830
c89926a5
CY
8312012-06-27 Chong Yidong <cyd@gnu.org>
832
833 * doc.c (Fsubstitute_command_keys): Fix punctuation.
834
ed6b3510
JW
8352012-06-26 John Wiegley <johnw@newartisans.com>
836
1ec4b7b2 837 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
838 on Mac OS X Lion: __mod_init_func and __mod_term_func.
839
ed6b3510
JW
840 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
841 when building with Clang.
842
8edd4a2b
SM
8432012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
844
845 * eval.c (Fapply): Allow calling it with a single argument.
846
f6f62d1b
EZ
8472012-06-26 Eli Zaretskii <eliz@gnu.org>
848
849 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
850 _stricmp and _strnicmp.
851 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
852
62efea5e
DA
8532012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
854
855 * alloc.c (allocate_window): Zero out non-Lisp part of newly
856 allocated window.
857 (allocate_process): Likewise for new process.
8edd4a2b 858 (allocate_terminal): Change to use offsetof.
62efea5e
DA
859 (allocate_frame): Likewise.
860 * frame.c (make_frame): Omit redundant initialization.
861 * window.c (make_parent_window): Use memset.
862 (make_window): Omit redundant initialization.
863 * process.c (make_process): Omit redundant initialization.
864 * terminal.c (create_terminal): Likewise.
865
42997f4d
DA
8662012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
867
868 * term.c (delete_tty): Remove redundant call to memset.
869
1130ecfc
DA
8702012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
871
872 * alloc.c: Remove build_string.
873 * lisp.h: Define build_string as static inline. This provides
874 a better opportunity to optimize away calls to strlen when the
875 function is called with compile-time constant argument.
876 * image.c (imagemagick_error): Convert to build_string.
877 * w32proc.c (sys_spawnve): Likewise.
878 * xterm.c (x_term_init): Likewise.
879
cf38a720
PE
8802012-06-26 Paul Eggert <eggert@cs.ucla.edu>
881
99027bdd
PE
882 Use sprintf return value instead of invoking strlen on result.
883 In the old days this wasn't portable, since some sprintf
884 implementations returned char *. But they died out years ago and
885 Emacs already assumes sprintf returns int.
886 Similarly for float_to_string.
887 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
888 * ccl.c (ccl_driver):
889 * character.c (string_escape_byte8):
890 * data.c (Fnumber_to_string):
891 * doprnt.c (doprnt):
892 * print.c (print_object):
893 * xdisp.c (message_dolog):
894 * xfns.c (syms_of_xfns):
895 Use sprintf or float_to_string result to avoid need to call strlen.
896 * data.c (Fnumber_to_string):
897 Use make_unibyte_string, since the string must be ASCII.
898 * lisp.h, print.c (float_to_string): Now returns int length.
899 * term.c (produce_glyphless_glyph):
900 Use sprintf result rather than recomputing it.
901
cf38a720
PE
902 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
903 * Makefile.in (ALL_CFLAGS):
904 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
905 * gmalloc.c, regex.c: Include <config.h> unconditionally.
906
3511c784
DA
9072012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
908
0a08eb21 909 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
910 strcasecmp if available.
911 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
912
fb7da12e
AS
9132012-06-25 Andreas Schwab <schwab@linux-m68k.org>
914
915 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
916 Avoid comma operator.
917 * menu.c (push_submenu_start, push_submenu_end)
918 (push_left_right_boundary, push_menu_pane): Likewise.
919 * msdos.c (dos_rawgetc): Likewise.
920
afa2ffd8
DA
9212012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
922
923 * xfns.c (xic_create_fontsetname): Remove redundant calls
924 to memset.
925
b3b4476b
PE
9262012-06-25 Paul Eggert <eggert@cs.ucla.edu>
927
4495ff38
PE
928 * gtkutil.c (get_utf8_string): Remove redundant assignment.
929 sprintf already null-terminates its output.
930
b3b4476b
PE
931 * xfns.c (x_window): Remove redundant cast.
932
b00876c9
DA
9332012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
934
935 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
936 `const char *' to `char *' to avoid compiler warning.
937
d188e26b
PE
9382012-06-24 Paul Eggert <eggert@cs.ucla.edu>
939
885d1d74
PE
940 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
941 instead of truncating it to 63 (admittedly a generous limit).
942
d188e26b
PE
943 * process.c: Fix spelling and caps in comments.
944
e2f560b1
DN
9452012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
946
e86db54b 947 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
948 * sysdep.c (setpgrp): Remove definition, not used in this file.
949
7583a3a1
JB
9502012-06-24 Juanma Barranquero <lekktu@gmail.com>
951
952 * makefile.w32-in: Update dependencies.
953
696056c2
EZ
9542012-06-24 Eli Zaretskii <eliz@gnu.org>
955
956 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
957 (SYSTIME_H): Add nt/inc/sys/time.h.
958
959 * systime.h [WINDOWSNT]: Include sys/time.h.
960
961 * s/ms-w32.h (struct timespec): Definition moved from
962 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
963
845ca893
PE
9642012-06-24 Paul Eggert <eggert@cs.ucla.edu>
965
966 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
967 * buffer.h (buffer_slot_type_mismatch):
968 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
969 * eval.c (unwind_to_catch):
970 * image.c (my_png_error, my_error_exit):
971 * keyboard.c (quit_throw_to_read_char, user_error)
972 (Fexit_recursive_edit, Fabort_recursive_edit):
973 * lisp.h (die, args_out_of_range, args_out_of_range_3)
974 (wrong_type_argument, buffer_overflow, __executable_start)
975 (memory_full, buffer_memory_full, string_overflow, Fthrow)
976 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
977 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
978 (fatal):
979 (child_setup) [!DOS_NT]:
980 * lread.c (end_of_file_error, invalid_syntax):
981 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
982 * puresize.h (pure_write_error):
983 * search.c (matcher_overflow):
984 * sound.c (sound_perror, alsa_sound_perror):
985 * sysdep.c, syssignal.h (croak):
986 * term.c (maybe_fatal, vfatal):
987 * textprop.c (text_read_only):
988 * undo.c (user_error):
989 * unexmacosx.c (unexec_error):
990 * xterm.c (x_ins_del_lines, x_delete_glyphs):
991 Use _Noreturn rather than NO_RETURN.
992 No need for separate decl merely because of _Noreturn.
993 * sound.c (sound_warning, parse_sound):
994 Remove unnecessary forward decls.
995
f1dd8073
PE
9962012-06-24 Paul Eggert <eggert@cs.ucla.edu>
997
998 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
999 * lisp.h (WAIT_READING_MAX): New macro.
1000 * dispnew.c (Fsleep_for, sit_for):
1001 * keyboard.c (kbd_buffer_get_event):
1002 * process.c (Faccept_process_output):
1003 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
1004 This improves on the previous patch, which introduced a bug
1005 when time_t is unsigned and as wide as intmax_t.
1006 See <http://bugs.gnu.org/9000#51>.
1007
b82c1755
EZ
10082012-06-23 Eli Zaretskii <eliz@gnu.org>
1009
1010 * dispnew.c (sit_for, Fsleep_for):
1011 * keyboard.c (kbd_buffer_get_event):
1012 * process.c (Faccept_process_output): Avoid compiler warnings when
1013 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
1014
ca300656
JB
10152012-06-23 Juanma Barranquero <lekktu@gmail.com>
1016
049ec95b
JB
1017 * makefile.w32-in: Update dependencies.
1018
ca300656
JB
1019 * w32.c (ltime): Add return type and declare static.
1020 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
1021
db7b8d06
PE
10222012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1023
1024 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
1025 Privately reported by Herbert J. Skuhra.
1026 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
1027 All uses changed.
1028 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
1029 not make_lisp_timeval, when the argument is of type EMACS_TIME.
1030
0bd8297f
EZ
10312012-06-23 Eli Zaretskii <eliz@gnu.org>
1032
96512555
EZ
1033 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
1034 last argument of make_unibyte_string.
1035
0bd8297f
EZ
1036 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
1037 language ID in the event parameters.
1038
1039 * w32term.c (w32_read_socket): Put the new keyboard codepage into
1040 event.code, not the obscure "character set ID".
1041
63def6b6
CY
10422012-06-23 Chong Yidong <cyd@gnu.org>
1043
1044 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
1045
e8a02204
EZ
10462012-06-23 Eli Zaretskii <eliz@gnu.org>
1047
388cdec0
EZ
1048 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
1049 * w32.c (fdutimens): New function.
1050
1051 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
1052
1053 * s/ms-w32.h (pselect): Redirect to sys_select.
1054
1055 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
1056
e8a02204
EZ
1057 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
1058 in the logic of incrementing and decrementing the value of
1059 use_relocatable_buffers.
1060
d054f3fb
PE
10612012-06-23 Paul Eggert <eggert@cs.ucla.edu>
1062
1063 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
1064 Privately reported by Herbert J. Skuhra.
1065 [__FreeBSD__]: Remove "*/" typo after "#include".
1066 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
1067 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
1068 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
1069 Don't assume EMACS_TIME and struct timeval are the same type.
1070
d35af63c
PE
10712012-06-22 Paul Eggert <eggert@cs.ucla.edu>
1072
1073 Support higher-resolution time stamps (Bug#9000).
1074 The time stamps are only nanosecond-resolution at the C level,
1075 since that's the best that any real-world system supports now.
1076 But they are picosecond-resolution at the Lisp level, as that's
1077 easy, and leaves room for future OS improvements.
1078
1079 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
1080 (LIBES): Use it.
1081
1082 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
1083 Don't get current time unless it's needed.
1084
1085 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
1086 now provides it if it's absent.
1087 (start_atimer): Port to higher-res time stamps.
1088 Check for time stamp overflow. Don't get current time more
1089 often than is needed.
1090
1091 * buffer.h (struct buffer): Buffer modtime now has high resolution.
1092 Include systime.h, not time.h.
1093 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
1094
1095 * dired.c: Include stat-time.h.
1096 (Ffile-attributes): File times now have higher resolution.
1097
1098 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
1099 (struct image): Timestamp now has higher resolution.
1100
1101 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
1102 has at least microseconds now. All uses removed.
1103 (update_frame, update_single_window, update_window, update_frame_1)
1104 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
1105
1106 * editfns.c (time_overflow): Now extern.
1107 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
1108 (float-time, Fformat_time_string, Fcurrent_time_string)
1109 (Fcurrent_time_zone): Accept and generate higher-resolution
1110 time stamps.
1111 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
1112 (decode_time_components, lisp_seconds_argument): New functions.
1113 (make_time): Now static.
1114 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
1115 Report an error if the time is invalid, rather than having the caller
1116 do that.
1117
1118 * fileio.c: Include <stat-time.h>
1119 (Fcopy_file): Copy higher-resolution time stamps.
1120 Prefer to set the time stamp via a file descriptor if that works.
1121 (Fset_file_times, Finsert_file_contents, Fwrite_region)
1122 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
1123 (Fvisited_file_modtime, Fset_visited_file_modtime):
1124 Support higher-resolution time stamps.
1125
1126 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
1127
1128 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
1129
1130 * image.c (prepare_image_for_display, clear_image_cache)
1131 (lookup_image): Port to higer-resolution time stamps.
1132
1133 * keyboard.c (start_polling, bind_polling_period):
1134 Check for time stamp overflow.
1135 (read_char, kbd_buffer_get_event, timer_start_idle)
1136 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
1137 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
1138 Port to higher-resolution time stamps. Do not assume time_t is signed.
1139 (decode_timer): New function. Timers are now vectors of length 9,
1140 not 8, to accommodate the picosecond component.
1141 (timer_check_2): Use it.
1142
1143 * nsterm.m (select_timeout, timeval_subtract): Remove.
1144 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
1145 as they're a bit more accurate and handle overflow better.
1146 (ns_select): Change prototype to be compatible with pselect.
1147 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
1148 * nsterm.h (ns_select): Adjust prototype.
1149
1150 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
1151 us-resolution time stamps.
1152 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
1153
1154 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
1155
1156 * lisp.h (time_overflow): New decl.
1157 (wait_reading_process_output): First arg is now intmax_t, not int,
1158 to accommodate larger waits.
1159
1160 * process.h (struct Lisp_Process.read_output_delay):
1161 Now counts nanoseconds, not microseconds.
1162 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
1163 EMACS_HAS_USECS.
1164 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
1165 (wait_reading_process_output):
1166 Port to ns-resolution time stamps.
1167 (Faccept_process_output, wait_reading_process_output):
1168 Check for time stamp overflow. Do not assume time_t is signed.
1169 (select_wrapper): Remove; we now use pselect.
1170 (Fprocess_attributes): Now generates ns-resolution time stamps.
1171
1172 * sysdep.c: Include utimens.h. Don't include utime.h
1173 or worry about struct utimbuf; gnulib does that for us now.
1174 (gettimeofday): Remove; gnulib provides a substitute.
1175 (make_timeval): New function.
1176 (set_file_times): Now sets ns-resolution time stamps.
1177 New arg FD; all uses changed.
1178 (time_from_jiffies, ltime_from_jiffies, get_up_time)
1179 (system_process_attributes):
1180 Now returns ns-resolution time stamp. All uses changed.
1181 Check for time stamp overflow.
1182
1183 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
1184 provides a substitute now.
1185
1186 * systime.h: Include timespec.h rather than sys/time.h and time.h,
1187 since it guarantees struct timespec.
1188 (EMACS_TIME): Now struct timespec, so that we can support
1189 ns-resolution time stamps.
1190 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
1191 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
1192 (EMACS_USECS): Remove.
1193 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
1194 so multiply the arg by 1000 before storing it.
1195 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
1196 New macros.
1197 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
1198 Port to ns-resolution time stamps.
1199 (EMACS_TIME_NEG_P): Remove; replaced by....
1200 (EMACS_TIME_SIGN): New macro.
1201 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
1202 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
1203 (set_file_times, make_time, lisp_time_argument): Adjust signature.
1204 (make_timeval, make_lisp_time, decode_time_components): New decls.
1205 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
1206 that it mishandled time_t overflow. You can't compare by subtracting!
1207 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
1208 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
1209
1210 * term.c: Include <sys/time.h>.
1211 (timeval_to_Time): New function, for proper overflow wraparound.
1212 (term_mouse_position, term_mouse_click): Use it.
1213
1214 * undo.c (record_first_change): Support higher-resolution time stamps
1215 in the undo buffer.
1216 (Fprimitive_undo): Use them when restoring time stamps.
1217
1218 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
1219 (w32_get_internal_run_time):
1220 Port to higher-resolution Emacs time stamps.
1221 (ltime): Now accepts single 64-bit integer, as that's more convenient
1222 for callers.
1223
1224 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
1225
1226 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
1227 for compatibility with pselect. Support ns-resolution time stamps.
1228
1229 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
1230
1231 * xselect.c (wait_for_property_change, x_get_foreign_selection):
1232 Check for time stamp overflow, and support ns-resolution time stamps.
1233
1234 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
1235 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
1236 (timeval_subtract): Remove; no longer needed.
1237 (XTflash, XTring_bell, x_wait_for_event):
1238 Port to ns-resolution time stamps. Don't assume time_t is signed.
1239
b6a92dfe
CY
12402012-06-22 Chong Yidong <cyd@gnu.org>
1241
1242 * xdisp.c (x_consider_frame_title): Revert last change.
1243
d251c37c
EZ
12442012-06-22 Eli Zaretskii <eliz@gnu.org>
1245
1246 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
1247 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
1248 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
1249 staticidx goes up to 1597 out of 1600 = 0x640.)
1250
f10deafb
PE
12512012-06-20 Paul Eggert <eggert@cs.ucla.edu>
1252
1253 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
1254 Otherwise, the umask might be mistakenly 0 while handling input signals.
1255
ec6de1e2
SM
12562012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
1257
1258 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
1259
28be1ada
DA
12602012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
1263 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
1264 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
1265 access to `contents' member of Lisp_Vector objects with AREF and ASET
1266 where appropriate.
1267
c6bf3022
CY
12682012-06-19 Chong Yidong <cyd@gnu.org>
1269
1270 * frame.c (delete_frame): When selecting a frame on a different
1271 text terminal, do not alter the terminal's top-frame.
1272
1273 * xdisp.c (format_mode_line_unwind_data): Record the target
1274 frame's selected window and its terminal's top-frame.
1275 (unwind_format_mode_line): Restore them.
1276 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
1277 Callers changed.
1278 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
1279 since tty frames can be explicitly named.
1280 (prepare_menu_bars): Likewise.
1281
1282 * term.c (Ftty_top_frame): New function.
1283
defd4196
PE
12842012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1285
1286 Port byte-code-meter to modern targets.
1287 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
1288 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 1289 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
1290 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
1291 (METER_1, METER_2): Simplify.
1292
1053a871
SM
12932012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
1294
1295 * data.c (Fdefalias): Return `symbol' (bug#11686).
1296
b7e8d081
MR
12972012-06-18 Martin Rudalics <rudalics@gmx.at>
1298
1299 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
1300 gets killed during executing of this function (Bug#11665).
1301 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
1302 (Vkill_buffer_query_functions): In doc-string say that functions
1303 run by this hook should not change the current buffer.
1304
7ea2b339
PE
13052012-06-18 Paul Eggert <eggert@cs.ucla.edu>
1306
1307 Fix recently-introduced process.c problems found by static checking.
1308 * process.c (write_queue_push, write_queue_pop, send_process):
1309 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
1310 (write_queue_pop): Fix pointer signedness problem.
1311 (send_process): Remove unused local.
1312
96a313a1
CY
13132012-06-17 Chong Yidong <cyd@gnu.org>
1314
1315 * xdisp.c (redisplay_internal): No need to redisplay terminal
1316 frames that are not on top.
1317
20ca2e94
TN
13182012-06-17 Troels Nielsen <bn.troels@gmail.com>
1319
1320 * process.c (make_process): Initialize write_queue.
1321 (write_queue_push, write_queue_pop): New functions.
1322 (send_process): Use them to maintain correct ordering of process
1323 writes (Bug#10815).
1324
9a900ca9
PE
13252012-06-17 Paul Eggert <eggert@cs.ucla.edu>
1326
310fbfa8
PE
1327 * lisp.h (eassert): Assume C89 or later.
1328 This removes the need for CHECK.
1329 (CHECK): Remove. Its comments about always evaluating its
1330 argument were confusing, as 'eassert' typically does not evaluate
1331 its argument.
1332
27bb1ca4
PE
1333 * coding.c (produce_chars): Use ptrdiff_t, not int.
1334
9a900ca9
PE
1335 * xterm.c (x_draw_underwave): Check for integer overflow.
1336 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
1337
41b7f8bc 13382012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
1339
1340 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
1341 referenced (Bug#11583).
1342
9b0e3eba
AA
13432012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
1344
1345 Implement wave-style variant of underlining.
1346 * dispextern.h (face_underline_type): New enum.
1347 (face): Add field for underline type.
1348 * nsterm.m (ns_draw_underwave): New function.
1349 (ns_draw_text_decoration): Use it.
1350 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
1351 New functions.
1352 (x_draw_glyph_string): Use them.
1353 * xfaces.c (Qline, Qwave): New Lisp objects.
1354 (check_lface_attrs, merge_face_ref)
1053a871
SM
1355 (Finternal_set_lisp_face_attribute, realize_x_face):
1356 Handle wave-style underline face attributes.
9b0e3eba
AA
1357 * xterm.c (x_draw_underwave): New function.
1358 (x_draw_glyph_string): Use it.
1359
0fb52f11
JB
13602012-06-16 Juanma Barranquero <lekktu@gmail.com>
1361
1362 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
1363 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
1364 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
1365 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
1366 ($(BLD)/w32select.$(O)): Update dependencies.
1367
e5560ff7
AS
13682012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1369
1370 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
1371 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
1372 * character.c (_fetch_multibyte_char_p): Remove.
1373 * alloc.c: Include "character.h" before "buffer.h".
1374 * bidi.c: Likewise.
1375 * buffer.c: Likewise.
1376 * bytecode.c: Likewise.
1377 * callint.c: Likewise.
1378 * callproc.c: Likewise.
1379 * casefiddle.c: Likewise.
1380 * casetab.c: Likewise.
1381 * category.c: Likewise.
1382 * cmds.c: Likewise.
1383 * coding.c: Likewise.
1384 * composite.c: Likewise.
1385 * dired.c: Likewise.
1386 * dispnew.c: Likewise.
1387 * doc.c: Likewise.
1388 * dosfns.c: Likewise.
1389 * editfns.c: Likewise.
1390 * emacs.c: Likewise.
1391 * fileio.c: Likewise.
1392 * filelock.c: Likewise.
1393 * font.c: Likewise.
1394 * fontset.c: Likewise.
1395 * fringe.c: Likewise.
1396 * indent.c: Likewise.
1397 * insdel.c: Likewise.
1398 * intervals.c: Likewise.
1399 * keyboard.c: Likewise.
1400 * keymap.c: Likewise.
1401 * lread.c: Likewise.
1402 * macros.c: Likewise.
1403 * marker.c: Likewise.
1404 * minibuf.c: Likewise.
1405 * nsfns.m: Likewise.
1406 * nsmenu.m: Likewise.
1407 * print.c: Likewise.
1408 * process.c: Likewise.
1409 * regex.c: Likewise.
1410 * region-cache.c: Likewise.
1411 * search.c: Likewise.
1412 * syntax.c: Likewise.
1413 * term.c: Likewise.
1414 * textprop.c: Likewise.
1415 * undo.c: Likewise.
1416 * unexsol.c: Likewise.
1417 * w16select.c: Likewise.
1418 * w32fns.c: Likewise.
1419 * w32menu.c: Likewise.
1420 * window.c: Likewise.
1421 * xdisp.c: Likewise.
1422 * xfns.c: Likewise.
1423 * xmenu.c: Likewise.
1424 * xml.c: Likewise.
1425 * xselect.c: Likewise.
1426
2f07e6af
EZ
14272012-06-16 Eli Zaretskii <eliz@gnu.org>
1428
1053a871
SM
1429 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
1430 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 1431 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
1432 row.
1433 (handle_face_prop): Use chunk-relative overlay string index when
1434 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
1435 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
1436 the rightmost. (Bug#11720)
2f07e6af 1437
29b83cec
AS
14382012-06-16 Andreas Schwab <schwab@linux-m68k.org>
1439
1440 * category.h (CHAR_HAS_CATEGORY): Define as inline.
1441 (CATEGORY_MEMBER): Enforce 1/0 value.
1442 * category.c (_temp_category_set): Remove.
1443
4c5501e9
EZ
14442012-06-16 Eli Zaretskii <eliz@gnu.org>
1445
1446 * window.c (Fdelete_other_windows_internal)
1447 (Fdelete_window_internal): Don't access frame's mouse highlight
1448 info of the initial frame. (Bug#11677)
1449
2b570124
PE
14502012-06-14 Paul Eggert <eggert@cs.ucla.edu>
1451
e93864f9
PE
1452 * .gdbinit (xgetint): Fix recently-introduced paren typo.
1453 Assume USE_2_TAGS_FOR_INTS.
1454 (xreload): Adjust $tagmask width to match recent lisp.h change.
1455
2b570124
PE
1456 Simplify lisp.h in minor ways that should not affect code.
1457 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
1458 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
1459 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
1460 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
1461 (INTTYPEBITS): New macro, for clarity.
1462 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
1463 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
1464 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
1465 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
1466 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
1467
81755f69
JB
14682012-06-13 Juanma Barranquero <lekktu@gmail.com>
1469
1470 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
1471
16192a57
GM
14722012-06-13 Glenn Morris <rgm@gnu.org>
1473
1474 * s/bsd-common.h (BSD4_3):
1475 * s/usg5-4-common.h (USG5_4): No longer define; unused.
1476
646b5f55
AS
14772012-06-13 Andreas Schwab <schwab@linux-m68k.org>
1478
1479 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
1480 instead of union.
1481 (XLI, XIL): Define.
1053a871
SM
1482 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
1483 Use them.
1484 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 1485 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 1486 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
1487 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
1488 * frame.c (delete_frame): Remove outdated comment.
1489 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
1490 USE_LISP_UNION_TYPE.
1491 (Fw32_unregister_hot_key): Likewise.
1492 (Fw32_toggle_lock_key): Likewise.
1493 * w32menu.c (add_menu_item): Likewise.
1494 (w32_menu_display_help): Use XIL instead of checking
1495 USE_LISP_UNION_TYPE.
1496 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
1497 (init_heap): Likewise.
1498 * w32term.c (w32_read_socket): Update comment.
1499
1d3823c9
GM
15002012-06-13 Glenn Morris <rgm@gnu.org>
1501
c62ff706
GM
1502 * s/usg5-4-common.h, src/s/unixware.h:
1503 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
1504
1d3823c9
GM
1505 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
1506
bfe3e0a2
PE
15072012-06-13 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
1510 * alloc.c (make_number) [!defined make_number]:
1511 Remove, as lisp.h always defines this now.
1512 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
1513 (roundup_size): Verify that it is a power of 2.
1514 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
1515 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
1516 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
1517 -DUSE_LSB_TAG=0, to override the automatically-selected default.
1518 USE_LSB_TAG now is always defined to be either 0 or 1.
1519 All uses changed.
1520 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
1521 code works fine either way, and efficiency is not a concern here,
1522 as the union type is for debugging, not for production.
1523 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
1524 Use an inline function on all platforms when using the union type,
1525 since this is simpler and 'static inline' can be used portably
1526 within Emacs now.
1527 (LISP_INITIALLY_ZERO): New macro.
1528 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
1529 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
1530
45fa9c0f
GM
15312012-06-12 Glenn Morris <rgm@gnu.org>
1532
b4492cba
GM
1533 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
1534
1535 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 1536
45fa9c0f
GM
1537 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
1538 Move BROKEN_SIGIO to configure.
1539
1540 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
1541 Move NO_TERMIO to configure.
1542
0e25d334
CY
15432012-06-12 Chong Yidong <cyd@gnu.org>
1544
1545 * image.c (imagemagick_load_image): Use MagickFlattenImage if
1546 MagickMergeImageLayers is undefined. Use pixel pusher loop if
1547 MagickExportImagePixels is undefined.
1548
43682bb6
PE
15492012-06-12 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * image.c (imagemagick_load_image): Remove unused label.
1552
a9be7d2b
GM
15532012-06-11 Glenn Morris <rgm@gnu.org>
1554
1555 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1556 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
1557 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
1558 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
1559
3017f87f
SM
15602012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
1561
1562 * alloc.c (make_byte_code): New function.
1563 (Fmake_byte_code): Use it. Don't purify here.
1564 * lread.c (read1): Use it as well to avoid extra allocation.
1565
1b9b4cf4
CY
15662012-06-11 Chong Yidong <cyd@gnu.org>
1567
1568 * image.c (imagemagick_load_image): Implement transparency.
1569
95988fcf
AS
15702012-06-10 Andreas Schwab <schwab@linux-m68k.org>
1571
1572 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
1573 account for preceding backslashes. (Bug#11663)
1574
cd4eb164
CY
15752012-06-09 Chong Yidong <cyd@gnu.org>
1576
1577 * term.c: Support italics in capable terminals (Bug#9652).
1578 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
1579 (turn_on_face): Output using TS_enter_italic_mode if available.
1580 Don't handle unused blinking and alt-charset cases.
1581 (turn_off_face): Handle italic case; discard unused tty_blinking_p
1582 and tty_alt_charset_p cases.
1583 (tty_capable_p, init_tty): Support italics.
1584
1585 * termchar.h (struct tty_display_info): Add field for italics.
1586 Remove unused blink field.
1587
1588 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
1589 Handle slant.
1590
1591 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
1592 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
1593 tty_alt_charset_p. Add tty_italic_p.
1594
ff88beb8
MA
15952012-06-09 Michael Albinus <michael.albinus@gmx.de>
1596
1597 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
1598 dbus_type_is_basic if available.
1599 (xd_extract_signed, xd_extract_unsigned): Rename from
1600 extract_signed and extract_unsigned, respectively. Adapt callers.
1601
44286096
CY
16022012-06-09 Chong Yidong <cyd@gnu.org>
1603
1682701f
CY
1604 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
1605
44286096
CY
1606 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
1607 case (Bug#9752).
1608
d86feb17
PE
16092012-06-08 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 * xdisp.c (vmessage): Treat frame message as multibyte.
1612 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
1613 would generate the diagnostic "Making \302\247 buffer-local while
1614 let-bound!".
1615
d5c20fe8
EZ
16162012-06-08 Eli Zaretskii <eliz@gnu.org>
1617
1618 * dispnew.c (showing_window_margins_p): Undo last change, which
1619 was done due to an inadvertent commit.
1620 (adjust_frame_glyphs_for_frame_redisplay): Do call
1621 showing_window_margins_p.
1622
513749ee
SM
16232012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1624
1625 * eval.c (Fmake_var_non_special): New primitive.
1626 (syms_of_eval): Defsubr it.
1627 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
1628
d4a8f5c1
JB
16292012-06-08 Juanma Barranquero <lekktu@gmail.com>
1630
1631 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
1632 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
1633
8bbbc977
EZ
16342012-06-08 Eli Zaretskii <eliz@gnu.org>
1635
1636 * alloc.c (allocate_vectorlike): Fix last change.
1637
f3372c87
DA
16382012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
1639
1640 Block-based vector allocation of small vectors.
1641 * lisp.h (struct vectorlike_header): New field `nbytes',
1642 adjust comment accordingly.
1643 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
1644 to denote vector blocks. Adjust users (live_vector_p,
1645 mark_maybe_pointer, valid_lisp_object_p) accordingly.
1646 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
1647 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
1648 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
1649 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
1650 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
1651 (roundup_size): New constant.
1652 (struct vector_block): New data type.
1653 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 1654 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
1655 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
1656 (sweep_vectors): New functions.
1657 (allocate_vectorlike): Return `zero_vector' as the only vector of
1658 0 items. Allocate new vector from block if vector size is less than
1659 or equal to VBLOCK_BYTES_MAX.
1660 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
1661 (init_alloc_once): Add call to init_vectors.
1662
4f18a4ed
SM
16632012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
1664
1665 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
1666
86f158bc
PE
16672012-06-07 Paul Eggert <eggert@cs.ucla.edu>
1668
1669 * doprnt.c (doprnt): Truncate multibyte char correctly.
1670 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
1671 would mishandle a string argument "Xc" if X was a multibyte
1672 character of length 2: it would truncate after X's first byte
1673 rather than including all of X.
1674
c5cfcbe0
CY
16752012-06-06 Chong Yidong <cyd@gnu.org>
1676
1677 * buffer.c (word_wrap): Doc fix.
1678
c05cf390
PE
16792012-06-04 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
1682
0c3461de
GM
16832012-06-03 Glenn Morris <rgm@gnu.org>
1684
1685 * xdisp.c (tool-bar-style): Doc fix.
1686
c71232db
UM
16872012-06-03 Ulrich Müller <ulm@gentoo.org>
1688
1689 * Makefile.in (PAXCTL): Define.
1690 (temacs$(EXEEXT)): Disable memory randomization for the temacs
1691 binary via PaX flags if the paxctl utility is available.
1692 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
1693 Restore PaX flags to their default. (Bug#11398)
1694
383f7350
CY
16952012-06-03 Chong Yidong <cyd@gnu.org>
1696
1697 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
1698 buffer (Bug#11226).
1699
5f2c76c6
CY
17002012-06-03 Chong Yidong <cyd@gnu.org>
1701
1702 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
1703 (note_mode_line_or_margin_highlight): If there is no help echo,
1704 use mode-line-default-help-echo. Handle the case where the mouse
1705 position is past the end of the mode line string.
1706
1707 * buffer.c (buffer_local_value_1): New function, split from
1708 Fbuffer_local_value; can return Qunbound.
1709 (Fbuffer_local_value): Use it.
1710 (Vmode_line_format): Docstring tweaks.
1711
773d47f6
PE
17122012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1713
1714 * sysdep.c (system_process_attributes): Improve comment.
1715
f2d6a3df
SM
17162012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
1717
1718 * keyboard.c: Export real-this-command to Elisp.
1719 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
1720 and DEFVAR it. Update all users.
1721
63810350
PE
17222012-06-02 Paul Eggert <eggert@cs.ucla.edu>
1723
7bd5c1f4
PE
1724 * minibuf.c (Fassoc_string): Remove duplicate declaration.
1725
63810350
PE
1726 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
1727 Convert pctcpu and pctmem to Lisp float properly.
1728 Let the compiler fold better, as 100.0/0x8000 is exact.
1729
a2821611
AS
17302012-06-02 Andreas Schwab <schwab@linux-m68k.org>
1731
1732 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
1733 cons_block.
1734
5fceba1d
PE
17352012-06-01 Paul Eggert <eggert@cs.ucla.edu>
1736
1737 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
1738
c98ff5dd
DA
17392012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
1740
1741 For a 'struct window', replace some Lisp_Object fields to
1742 bitfields where appropriate, remove unused fields.
1743 * window.h (struct window): Remove unused 'last_mark_x' and
1744 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
1745 change it's type from Lisp_Object to bitfield.
1746 Change type of 'force_start', 'optional_new_start',
1747 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
1748 fields from Lisp_Object to bitfield. Adjust users accordingly.
1749
ca34e0be
PE
17502012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1751
1752 Pacify gcc -Wdouble-precision when using Xaw.
1753 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
1754 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
1755 Use 'float' consistently, rather than 'float' in most places
1756 and 'double' in a couple of places.
1757
efc00ab1 17582012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
1759
1760 * xdisp.c (handle_stop): Detect whether we have overlay strings
1761 loaded by testing it->current.overlay_string_index to be
1762 non-negative, instead of checking whether n_overlay_strings is
1763 positive. (Bug#11587)
1764
efc00ab1 17652012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
1766
1767 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
1768
1769 * doc.c (Fsubstitute_command_keys): Doc fix.
1770
efc00ab1 17712012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
1772
1773 * search.c (search_buffer): Remove calls to
1774 r_alloc_inhibit_buffer_relocation, as it is now called by
1775 maybe_unify_char, which was the cause of relocation of buffer text
1776 in bug#11519.
1777
efc00ab1 17782012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
1779
1780 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
1781 for the duration of call to load_charset, to avoid problems with
1782 callers of maybe_unify_char that access buffer text through C
1783 pointers.
1784
1785 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
1786 decrement the inhibition flag, instead of just setting or
1787 resetting it.
1788
ba93a187
PE
17892012-05-31 Paul Eggert <eggert@cs.ucla.edu>
1790
1791 Remove obsolete '#define static' cruft.
1792 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
1793 This #undef was "temporary" in 2000; it is no longer needed
1794 now that '#define static' has gone away.
1795 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
1796 (gray_bitmap_bits): Remove; no longer needed.
1797 All uses replaced with definiens.
1798 * xterm.c: Include "bitmaps/gray.xbm".
1799
9e4bf381
PE
18002012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1801
1802 Clean up __executable_start, monstartup when --enable-profiling.
1803 The following changes affect the code only when profiling.
1804 * dispnew.c (__executable_start): Rename from safe_bcopy.
1805 Define only on platforms that need it.
1806 * emacs.c: Include <sys/gmon.h> when profiling.
1807 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
1808 (__executable_start): Remove decl, since lisp.h does it now.
1809 (safe_bcopy): Remove decl; no longer has that name.
1810 (main): Coalesce #if into single bit of code, for simplicity.
1811 Cast pointers to uintptr_t, since standard libraries want integers
1812 and not pointers.
1813 * lisp.h (__executable_start): New decl.
1814
32d72c2f
GM
18152012-05-31 Glenn Morris <rgm@gnu.org>
1816
1817 * image.c (Fimagemagick_types): Doc fix.
1818
baac5bc7
JM
18192012-05-30 Jim Meyering <meyering@redhat.com>
1820
1821 * callproc.c (Fcall_process_region): Include directory component
1822 in mkstemp error message (Bug#11586).
1823
72cb32cf
PE
18242012-05-30 Paul Eggert <eggert@cs.ucla.edu>
1825
1826 * alloc.c, lisp.h (make_pure_vector): Now static.
1827
61b108cc
SM
18282012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
1829
1830 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
1831 Move to byte-run.el.
1832 (Fautoload): Do the hash-doc more carefully.
1833 * data.c (Fdefalias): Purify definition, except for keymaps.
1834 (Qdefun): Move from eval.c.
1835 * lisp.h (Qdefun): Remove.
1836 * lread.c (read1): Tiny simplification.
1837
471fe23d
TN
18382012-05-29 Troels Nielsen <bn.troels@gmail.com>
1839
934f3f58 1840 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
1841 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
1842 Bug#9642, but explicitly check that the buffer the overlay would
1843 be moved to is live and rearrange lines to make sure that errors
1844 will not put the overlay in an inconsistent state.
1845 (Fdelete_overlay): Cosmetics.
1846
85d0efd1
EZ
18472012-05-28 Eli Zaretskii <eliz@gnu.org>
1848
1849 * w32term.c (my_bring_window_to_top): New function.
1850 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
1851 could be different from the original one.
1852 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
1853 (Bug#11513)
1854
1855 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
1856 by calling BringWindowToTop.
1857
1858 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
1859 (WM_EMACS_END): Increase by one.
1860
da92a98c
PE
18612012-05-28 Paul Eggert <eggert@cs.ucla.edu>
1862
1863 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
1864 This avoids undefined behavior that might cause the eassert
1865 to not catch an out-of-range value.
1866
74d1f848
JB
18672012-05-28 Juanma Barranquero <lekktu@gmail.com>
1868
1869 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
1870 Update dependencies.
1871
9e1a06fc
EZ
18722012-05-27 Eli Zaretskii <eliz@gnu.org>
1873
1874 * bidi.c (bidi_mirror_char): Fix last change.
1875
f3dd7312
AS
18762012-05-27 Andreas Schwab <schwab@linux-m68k.org>
1877
1878 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
1879 when referring to sectname field in printf format.
1880
81899c91
PE
18812012-05-27 Paul Eggert <eggert@cs.ucla.edu>
1882
57b81a9f
PE
1883 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
1884 Only r_alloc_inhibit_buffer_relocation needed to be added;
1885 the others were already declared.
1886
81899c91
PE
1887 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
1888 before checking whether it's out of range. Put the check inside
1889 eassert. See
1890 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
1891
33017faf 18922012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
1893
1894 * callproc.c (Fcall_process): Restore a line that was accidentally
1895 commented out in the 2011-02-13 change (bug#11547).
1896
33017faf 18972012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
1898
1899 * lisp.h [REL_ALLOC]: Add prototypes for external functions
1900 defined on ralloc.c.
1901
1902 * buffer.c [REL_ALLOC]: Remove prototypes of
1903 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
1904 they are now on lisp.h.
1905
1906 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
1907
1908 * search.c (search_buffer): Use it to inhibit relocation of buffer
1909 text while re_search_2 is doing its job, because re_search_2 is
1910 passed C pointers to buffer text. (Bug#11519)
1911
23415acf
EZ
1912 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
1913 Update value to 24.
1914
44e27368
EZ
1915 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
1916 state after an additional call to move_it_in_display_line_to, keep
1917 the values of it->max_ascent and it->max_descent found for the
1918 entire line.
1919 (pos_visible_p): Revert the comparison against bottom_y to what it
1920 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
1921 (Bug#11464)
1922
c1892f11
PE
19232012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1924
1925 Fix coding-related core dumps with gcc -ftrapv.
1926 The code was computing A - B, where A and B are pointers, and B is
1927 random garbage. This can lead to core dumps on platforms that
1928 have special pointer registers, and it also leads to core dumps on
1929 x86-64 when compiled with gcc -ftrapv. The fix is to compute
1930 A - B only when B is initialized properly.
1931 * coding.c (coding_set_source, coding_set_destination): Return void.
1932 (coding_change_source, coding_change_destinations): New functions,
1933 with the old behaviors of coding_set_source and coding_set_destination.
1934 All callers that need an offset changed to use these new functions.
1935
eb7afdad
GM
19362012-05-26 Glenn Morris <rgm@gnu.org>
1937
1938 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
1939
f12fdf02
EZ
19402012-05-26 Eli Zaretskii <eliz@gnu.org>
1941
53a63be6 1942 Extend mouse support on W32 text-mode console.
61b108cc
SM
1943 * xdisp.c (draw_row_with_mouse_face):
1944 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 1945
eb3f6f01 1946 * w32console.c: Include window.h.
61b108cc
SM
1947 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
1948 New functions.
eb3f6f01
EZ
1949 (initialize_w32_display): Initialize mouse-highlight data.
1950
53a63be6
EZ
1951 * w32inevt.c: Include termchar.h and window.h.
1952 (do_mouse_event): Support mouse-autoselect-window. When the mouse
1953 moves, call note_mouse_highlight. If help_echo changed, call
1954 gen_help_event to produce help-echo message in the echo area.
1955 Call clear_mouse_face if mouse_face_hidden is set in the mouse
1956 highlight info.
1957
4cfd81f6
PE
19582012-05-26 Paul Eggert <eggert@cs.ucla.edu>
1959
1960 * lread.c (read1): Simplify slightly to avoid an overflow warning
1961 with GCC 4.7.0 on x86-64.
1962
4446092a
EZ
19632012-05-26 Eli Zaretskii <eliz@gnu.org>
1964
1965 * bidi.c (bidi_mirror_char): Revert last change: an int is
1966 definitely wide enough here.
1967
42b2a986 19682012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 1969
42b2a986 1970 Fix integer width and related bugs (Bug#9874).
eb106a49 1971 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
1972 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
1973 (string_bytes, check_sblock, allocate_string_data):
1974 (compact_small_strings, Fmake_bool_vector, make_string)
1975 (make_unibyte_string, make_multibyte_string)
1976 (make_string_from_bytes, make_specified_string)
1977 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
1978 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
1979 (mark_vectorlike):
1980 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1981 (allocate_pseudovector):
1982 Use int, not EMACS_INT, where int is wide enough.
1983 (inhibit_garbage_collection, Fgarbage_collect):
1984 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1985 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
1986 int might not be wide enough.
1987 (bidi_cache_search, bidi_cache_find, bidi_init_it)
1988 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
1989 (bidi_at_paragraph_end, bidi_find_paragraph_start)
1990 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
1991 (bidi_level_of_next_char, bidi_move_to_visually_next):
1992 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1993 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
1994 (Fkill_buffer, Fset_buffer_major_mode)
1995 (advance_to_char_boundary, Fbuffer_swap_text)
1996 (Fset_buffer_multibyte, overlays_at, overlays_in)
1997 (overlay_touches_p, struct sortvec, record_overlay_string)
1998 (overlay_strings, recenter_overlay_lists)
1999 (adjust_overlays_for_insert, adjust_overlays_for_delete)
2000 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
2001 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
2002 (Foverlay_recenter, last_overlay_modification_hooks_used)
2003 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
2004 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
2005 (validate_region): Omit unnecessary test for b <= e,
2006 since that's guaranteed by the previous test.
d311d28c
PE
2007 (adjust_overlays_for_delete): Avoid pos + length overflow.
2008 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
2009 (report_overlay_modification):
2010 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2011 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
2012 Omit pointer cast, which isn't needed anyway, and doesn't work
2013 after the EMACS_INT -> ptrdiff_t change.
02481186 2014 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
2015 * buffer.h: Adjust decls to match defn changes elsewhere.
2016 (struct buffer_text, struct buffer):
2017 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2018 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
2019 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
2020 not int, to avoid needless 32-bit limit on 64-bit hosts.
2021 (exec_byte_code): Use tighter memory-full test, one that checks
2022 for alloca overflow. Don't compute the address of the object just
2023 before an array, as that's not portable. Use EMACS_INT, not
2024 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
2025 * callint.c (Fcall_interactively):
2026 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2027 * callproc.c (call_process_kill, Fcall_process):
2028 Don't assume pid_t fits into an Emacs fixnum.
2029 (call_process_cleanup, Fcall_process, child_setup):
2030 Don't assume pid_t fits into int.
2031 (call_process_cleanup, Fcall_process, delete_temp_file)
2032 (Fcall_process_region):
2033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2034 (Fcall_process): Simplify handling of volatile integers.
2035 Use int, not EMACS_INT, where int will do.
2036 * casefiddle.c (casify_object, casify_region, operate_on_word)
2037 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
2038 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2039 (casify_object): Avoid integer overflow when overallocating buffer.
2040 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 2041 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
2042 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
2043 * category.h (CATEGORYP): Don't assume arg is nonnegative.
2044 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
2045 integers are now checked earlier. All uses replaced with XINT.
2046 (ccl_driver):
2047 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2048 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
2049 (ccl_driver, Fregister_code_conversion_map):
2050 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
2051 (resolve_symbol_ccl_program): Check that vector header is in range.
2052 Always copy the vector, so that we can check its contents reliably
2053 now rather than having to recheck each instruction as it's being
2054 executed. Check that vector words fit in 'int'.
2055 (ccl_get_compiled_code, Fregister_ccl_program)
2056 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
2057 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
2058 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
2059 contents are in range.
2060 (Fccl_execute_on_string): Check that status is in range.
2061 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
2062 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
2063 Accept and return EMACS_INT, not int, because callers can pass values
2064 out of 'int' range.
2065 (c_string_width, strwidth, lisp_string_width, chars_in_text)
2066 (multibyte_chars_in_text, parse_str_as_multibyte)
2067 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
2068 (str_as_unibyte, str_to_unibyte, string_count_byte8)
2069 (string_escape_byte8, Fget_byte):
2070 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 2071 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
2072 avoid mishandling large integers.
2073 * character.h: Adjust decls to match defn changes elsewhere.
2074 * charset.c (load_charset_map_from_file, find_charsets_in_text)
2075 (Ffind_charset_region):
2076 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2077 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
2078 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 2079 Don't assume fixnum fits in int.
d311d28c
PE
2080 (load_charset_map_from_vector, Fmap_charset_chars):
2081 Remove now-unnecessary CHECK_NATNUMs.
2082 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
2083 Don't rely on undefined behavior with signed left shift overflow.
2084 Don't assume unsigned int fits into fixnum, or that fixnum fits
2085 into unsigned int. Don't require max_code to be a valid fixnum;
2086 that's not true for gb10830 4-byte on a 32-bit host. Allow
2087 invalid_code to be a cons, for the same reason. Require code_offset
2088 to be a character. Avoid int overflow if max_char is close
2089 to INT_MAX.
2090 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
2091 this is intended anyway and avoids some undefined behavior.
2092 (load_charset_map): Pass unsigned, not int, as 2nd arg of
2093 INDEX_TO_CODE_POINT, as that's what it expects.
2094 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
2095 * charset.h (DECODE_CHAR): Return int, not unsigned;
2096 this is what was intended anyway, and it avoids undefined behavior.
2097 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
2098 integer-overflow issues.
2099 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
2100 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
2101 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
2102 * chartab.c (Fmake_char_table, Fset_char_table_range)
2103 (uniprop_get_decoder, uniprop_get_encoder):
2104 Don't assume fixnum fits in int.
2105 * cmds.c (move_point): New function, that does the gist of
2106 Fforward_char and Fbackward_char, but does so while checking
2107 for integer overflow more accurately.
c96e5d6a 2108 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
2109 (Fforward_line, Fend_of_line, internal_self_insert)
2110 (internal_self_insert):
2111 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2112 Fix a FIXME, by checking for integer overflow when calculating
2113 target_clm and actual_clm.
2114 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 2115 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
2116 (ASSURE_DESTINATION, coding_alloc_by_realloc)
2117 (coding_alloc_by_making_gap, alloc_destination)
2118 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
2119 (encode_coding_utf_16, detect_coding_emacs_mule)
2120 (decode_coding_emacs_mule, encode_coding_emacs_mule)
2121 (detect_coding_iso_2022, decode_coding_iso_2022)
2122 (encode_invocation_designation, encode_designation_at_bol)
2123 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2124 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
2125 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
2126 (encode_coding_ccl, encode_coding_raw_text)
2127 (detect_coding_charset, decode_coding_charset)
2128 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
2129 (produce_composition, produce_charset, produce_annotation)
2130 (decode_coding, handle_composition_annotation)
2131 (handle_charset_annotation, consume_chars, decode_coding_gap)
2132 (decode_coding_object, encode_coding_object, detect_coding_system)
2133 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
2134 (code_convert_region, code_convert_string)
8f50130c
PE
2135 (Fdefine_coding_system_internal)
2136 (coding_set_source, coding_set_destination):
d311d28c
PE
2137 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2138 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
2139 (Fdefine_coding_system_internal):
2140 Don't assume fixnums fit in int.
2141 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 2142 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
2143 (Funencodable_char_position, Fcheck_coding_systems_region)
2144 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 2145 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 2146 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 2147 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 2148 Don't access memory outside of the args array.
d311d28c 2149 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
2150 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
2151 result of ENCODE_CHAR.
d311d28c
PE
2152 * coding.h: Adjust decls to match defn changes elsewhere.
2153 (struct coding_system):
2154 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2155 * composite.c (get_composition_id, find_composition)
2156 (run_composition_function, update_compositions)
2157 (compose_text, composition_gstring_put_cache)
2158 (composition_gstring_p, composition_gstring_width)
2159 (fill_gstring_header, fill_gstring_body, autocmp_chars)
2160 (composition_compute_stop_pos, composition_reseat_it)
2161 (composition_update_it, struct position_record)
2162 (find_automatic_composition, composition_adjust_point)
2163 (Fcomposition_get_gstring, Ffind_composition_internal):
2164 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2165 (update_compositions):
2166 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2167 * composite.h: Adjust decls to match defn changes elsewhere.
2168 (struct composition):
2169 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2170 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
2171 Do not attempt to compute the address of the object just before a
2172 buffer; this is not portable.
2173 (Faref, Faset):
2174 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2175 (Faset): Use int, not EMACS_INT, where int is wide enough.
2176 (Fstring_to_number): Don't assume fixnums fit in int.
2177 (Frem): Don't assume arg is nonnegative.
2178 * dbusbind.c (xd_append_arg): Check for integers out of range.
2179 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 2180 (extract_signed, extract_unsigned): New functions.
243e0530
PE
2181 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
2182 (xd_get_connection_references): Return ptrdiff_t, not int.
2183 All uses changed.
2184 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
2185 (xd_read_message_1):
2186 Use int, not unsigned, where the dbus API uses int.
2187 (Fdbus_message_internal): Don't overflow mtype.
2188 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
2189 * dired.c (directory_files_internal, file_name_completion, scmp)
2190 (file_name_completion_stat):
2191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2192 (file_name_completion): Don't overflow matchcount.
2193 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
2194 * dispextern.h: Adjust decls to match defn changes elsewhere.
2195 (struct text_pos, struct glyph, struct bidi_saved_info)
2196 (struct bidi_string_data, struct bidi_it, struct composition_it)
2197 (struct it):
2198 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2199 (struct display_pos, struct composition_it, struct it):
2200 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2201 * dispnew.c (increment_matrix_positions)
2202 (increment_row_positions, mode_line_string)
2203 (marginal_area_string):
2204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 2205 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
2206 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2207 (duration_to_sec_usec): New function, to check for overflow better.
2208 (Fsleep_for, sit_for): Use it.
2209 * doc.c (get_doc_string, store_function_docstring):
2210 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2211 (get_doc_string, Fsnarf_documentation):
2212 Use int, not EMACS_INT, where int is wide enough.
2213 (get_doc_string):
2214 Use SAFE_ALLOCA, not alloca.
2215 Check for overflow when converting EMACS_INT to off_t.
2216 * doprnt.c (doprnt):
2217 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2218 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
2219 Don't assume uid_t fits into fixnum.
2220 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
2221 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
2222 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
2223 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
2224 (general_insert_function)
2225 (Finsert_char, make_buffer_string, make_buffer_string_both)
2226 (update_buffer_properties, Fbuffer_substring)
2227 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
2228 (Fsubst_char_in_region, check_translation)
2229 (Ftranslate_region_internal, save_restriction_restore, Fformat)
2230 (transpose_markers, Ftranspose_regions):
2231 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2232 (clip_to_bounds): Move to lisp.h as an inline function).
2233 (Fconstrain_to_field): Don't assume integers are nonnegative.
2234 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
2235 (Fsubst_char_in_region, Fsave_restriction):
2236 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2237 (Femacs_pid): Don't assume pid_t fits into fixnum.
2238 (lo_time): Use int, not EMACS_INT, when int suffices.
2239 (lisp_time_argument): Check for usec out of range.
2240 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
2241 (Fuser_login_name, Fuser_full_name): Signal an error
2242 if a uid argument is out of range, rather than relying on
2243 undefined behavior.
c8d5c857
PE
2244 (Fformat_time_string): Remove now-unnecessary check.
2245 lisp_time_argument checks for out-of-range usec now.
243e0530 2246 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
2247 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
2248 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
2249 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
2250 (init_cmdargs, Fdump_emacs):
2251 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2252 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
2253 the bottom (typically) 32 bits of the fixnum.
2254 * eval.c (specpdl_size, call_debugger):
2255 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2256 (when_entered_debugger, Fbacktrace_debug):
2257 Don't assume fixnum can fit in int.
2258 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
2259 the object just before a buffer; this is not portable.
2260 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
2261 (grow_specpdl, unbind_to):
2262 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2263 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
2264 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 2265 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
2266 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
2267 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
2268 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2269 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
2270 (a_write, e_write):
2271 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2272 (Fcopy_file, non_regular_nbytes, read_non_regular)
2273 (Finsert_file_contents):
2274 Use int, not EMACS_INT, where int is wide enough.
2275 (READ_BUF_SIZE): Verify that it fits in int.
2276 (Finsert_file_contents): Check that counts are in proper range,
2277 rather than assuming fixnums fit into ptrdiff_t etc.
2278 Don't assume fixnums fit into int.
125b3835 2279 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
2280 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
2281 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
2282 (string_char_to_byte, string_byte_to_char)
2283 (string_make_multibyte, string_to_multibyte)
2284 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
2285 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
2286 (substring_both, Fdelete, internal_equal, Ffillarray)
2287 (Fclear_string, mapcar1)
2288 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
2289 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
2290 (larger_vector, make_hash_table, maybe_resize_hash_table)
2291 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
2292 (Fmaphash, secure_hash):
2293 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2294 (concat): Check for string index and length overflow.
2295 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
2296 (Frequire):
2297 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2298 (larger_vector): New API (vec, incr_min, size_max) replaces old
2299 one (vec, new_size, init). This catches size overflow.
2300 INIT was removed because it was always Qnil.
2301 All callers changed.
2302 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
2303 the upper bound on a hash table index size.
2304 (make_hash_table, maybe_resize_hash_table): Use it.
2305 (secure_hash): Computer start_byte and end_byte only after
2306 they're known to be in ptrdiff_t range.
2307 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
2308 (Ffont_get_glyphs, Ffont_at):
2309 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2310 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
2311 (Flist_fonts, Fopen_font):
2312 Don't assume fixnum can fit in int.
2313 (check_gstring): Don't assume index can fit in int.
2314 (font_match_p): Check that fixnum is a character, not a nonnegative
2315 fixnum, since the later code needs to stuff it into an int.
2316 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
2317 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
2318 conversion overflow issues.
2319 (Fopen_font): Check for integer out of range.
2320 (Ffont_get_glyphs): Don't assume index can fit in int.
2321 * font.h: Adjust decls to match defn changes elsewhere.
2322 * fontset.c (reorder_font_vector): Redo score calculation to avoid
2323 integer overflow.
2324 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
2325 printmax_t, where ptrdiff_t is wide enough.
2326 (Finternal_char_font):
2327 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2328 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
2329 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
2330 (Fset_frame_position, x_set_frame_parameters)
2331 (x_set_line_spacing, x_set_border_width)
2332 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
2333 Check that fixnums are in proper range for system types.
2334 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
2335 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2336 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
2337 Use SAFE_ALLOCA_LISP, not alloca.
2338 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
2339 intptr_t is wide enough.
2340 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
2341 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
2342 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
2343 Check for fixnum out of range.
2344 * ftfont.c (ftfont_list): Don't assume index fits in int.
2345 Check that fixnums are in proper range for system types.
2346 (ftfont_shape_by_flt):
2347 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
2348 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2349 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2350 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
2351 Check that fixnums are in proper range for system types.
2352 * gnutls.h: Adjust decls to match defn changes elsewhere.
2353 * gtkutil.c (xg_dialog_run):
2354 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2355 (update_frame_tool_bar):
2356 Check that fixnums are in proper range for system types.
2357 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 2358 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
2359 * indent.c (last_known_column, last_known_column_point):
2360 (current_column_bol_cache):
2361 (skip_invisible, current_column, check_display_width):
2362 (check_display_width, scan_for_column, current_column_1)
2363 (Findent_to, Fcurrent_indentation, position_indentation)
2364 (indented_beyond_p, Fmove_to_column, compute_motion):
2365 (Fcompute_motion, Fvertical_motion):
2366 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2367 (last_known_column_modified): Use EMACS_INT, not int.
2368 (check_display_width):
2369 (Fcompute_motion):
2370 Check that fixnums and floats are in proper range for system types.
2371 (compute_motion): Don't assume index or fixnum fits in int.
2372 (compute_motion, Fcompute_motion):
2373 Use int, not EMACS_INT, when it is wide enough.
2374 (vmotion): Omit local var start_hpos that is always 0; that way
2375 we don't need to worry about overflow in expressions involving it.
2376 * indent.h: Adjust decls to match defn changes elsewhere.
2377 (struct position):
2378 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2379 Use int, not EMACS_INT, where int is wide enough.
2380 Remove unused members ovstring_chars_done and tab_offset;
2381 all uses removed.
2382 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
2383 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
2384 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
2385 (make_gap, copy_text, insert, insert_and_inherit)
2386 (insert_before_markers, insert_before_markers_and_inherit)
2387 (insert_1, count_combining_before, count_combining_after)
2388 (insert_1_both, insert_from_string)
2389 (insert_from_string_before_markers, insert_from_string_1)
2390 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
2391 (adjust_after_replace, adjust_after_insert, replace_range)
2392 (replace_range_2, del_range, del_range_1, del_range_byte)
2393 (del_range_both, del_range_2, modify_region)
2394 (prepare_to_modify_buffer, signal_before_change)
2395 (signal_after_change, Fcombine_after_change_execute):
2396 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2397 * intervals.c (traverse_intervals, rotate_right, rotate_left)
2398 (balance_an_interval, split_interval_right, split_interval_left)
2399 (find_interval, next_interval, update_interval)
2400 (adjust_intervals_for_insertion, delete_node, delete_interval)
2401 (interval_deletion_adjustment, adjust_intervals_for_deletion)
2402 (static_offset_intervals, offset_intervals)
2403 (merge_interval_right, merge_interval_left, make_new_interval)
2404 (graft_intervals_into_buffer, temp_set_point_both)
2405 (temp_set_point, set_point, adjust_for_invis_intang)
2406 (set_point_both, move_if_not_intangible, get_property_and_range)
2407 (get_local_map, copy_intervals, copy_intervals_to_string)
2408 (compare_string_intervals, set_intervals_multibyte_1):
2409 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2410 * intervals.h: Adjust decls to match defn changes elsewhere.
2411 (struct interval):
2412 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2413 * keyboard.c (this_command_key_count, this_single_command_key_start)
2414 (before_command_key_count, before_command_echo_length, echo_now)
2415 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
2416 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
2417 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
2418 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
2419 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2420 (last_non_minibuf_size, last_point_position, echo_truncate)
2421 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
2422 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
2423 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
2424 (stuff_buffered_input):
2425 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2426 (last_auto_save, command_loop_1, read_char):
2427 Use EMACS_INT, not int, to avoid integer overflow.
2428 (record_char): Avoid overflow in total_keys computation.
2429 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
2430 * keyboard.h: Adjust decls to match defn changes elsewhere.
2431 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
2432 (Fkey_description, Fdescribe_vector, Flookup_key):
2433 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2434 (click_position): New function, to check that positions are in range.
2435 (Fcurrent_active_maps):
2436 (describe_command):
2437 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2438 (Faccessible_keymaps, Fkey_description):
2439 (preferred_sequence_p):
2440 Don't assume fixnum can fit into int.
2441 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
2442 Check for integer overflow in size calculations.
2443 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
2444 avoid mishandling large integers.
2445 * lisp.h: Adjust decls to match defn changes elsewhere.
2446 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
2447 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
2448 (struct Lisp_Marker):
2449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2450 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
2451 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
2452 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
2453 All callers changed.
2454 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
2455 Assume the arg has valid form, since it always does.
2456 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
2457 unsigned integer system type.
2458 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
2459 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
2460 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2461 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
2462 (duration_to_sec_usec): New decl.
2463 * lread.c (read_from_string_index, read_from_string_index_byte)
2464 (read_from_string_limit, readchar, unreadchar, openp)
2465 (read_internal_start, read1, oblookup):
2466 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2467 (Fload, readevalloop, Feval_buffer, Feval_region):
2468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2469 (openp): Check for out-of-range argument to 'access'.
2470 (read1): Use int, not EMACS_INT, where int is wide enough.
2471 Don't assume fixnum fits into int.
6efdadfd 2472 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
2473 (read_filtered_event): Use duration_to_sec_usec
2474 to do proper overflow checking on durations.
d311d28c
PE
2475 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
2476 in size calculation.
2477 (Fexecute_kbd_macro):
2478 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2479 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
2480 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
2481 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
2482 (set_marker_both, set_marker_restricted_both, marker_position)
2483 (marker_byte_position, Fbuffer_has_markers_at):
2484 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2485 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 2486 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
2487 It now merely ensures that the menu is large enough, without
2488 necessarily growing it, as this avoids some integer overflow issues.
2489 All callers changed.
2490 (keymap_panes, parse_single_submenu, Fx_popup_menu):
2491 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2492 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
2493 Use SAFE_ALLOCA_LISP, not alloca.
2494 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
2495 to EMACS_INT. Check that fixnums are in proper range for system types.
2496 * minibuf.c (minibuf_prompt_width, string_to_object)
2497 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
2498 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
2499 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2500 (get_minibuffer, read_minibuf_unwind):
2501 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2502 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
2503 this simplifies overflow checking. All callers changed.
2504 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
2505 (Ftest_completion):
2506 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2507 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
2508 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
2509 Check that fixnums are in proper range for system types.
2510 (Fx_create_frame, Fx_show_tip):
2511 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2512 * nsfont.m (ns_findfonts, nsfont_list_family):
2513 Don't assume fixnum fits in long.
2514 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
2515 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2516 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
2517 wide enough.
17fdb222 2518 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
2519 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2520 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
2521 (PRINTDECLARE, PRINTPREPARE):
2522 (strout, print_string):
2523 (print, print_preprocess, print_check_string_charset_prop)
2524 (print_object):
2525 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2526 (PRINTDECLARE):
2527 (temp_output_buffer_setup, Fprin1_to_string, print_object):
2528 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2529 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 2530 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 2531 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
2532 (print_error_message): Use SAFE_ALLOCA, not alloca.
2533 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
2534 (print_depth, new_backquote_output, print_number_index):
2535 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
2536 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
2537 (Fset_process_window_size, Fformat_network_address)
2538 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 2539 (sigchld_handler):
d311d28c 2540 Check that fixnums are in proper range for system types.
d44287d4 2541 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
2542 Check for process-ids out of pid_t range rather than relying on
2543 undefined behavior.
e4d81efc 2544 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
2545 (Fformat_network_address, read_process_output, send_process)
2546 (Fprocess_send_region, status_notify):
2547 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2548 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
2549 (wait_reading_process_output, read_process_output, exec_sentinel):
2550 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2551 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
2552 (Faccept_process_output): Use duration_to_sec_usec to do proper
2553 overflow checking on durations.
dde14581
PE
2554 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
2555 Don't assume pid_t fits in int.
02481186
PE
2556 * process.h (struct Lisp_Process): Members tick and update_tick
2557 are now of type EMACS_INT, not int.
b62b53e8
PE
2558 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
2559 configured --with-wide-int.
d311d28c
PE
2560 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
2561 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
2562 * search.c (looking_at_1, string_match_1):
2563 (fast_string_match, fast_c_string_match_ignore_case)
2564 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
2565 (scan_newline, find_before_next_newline, search_command)
2566 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
2567 (set_search_regs, wordify):
2568 (Freplace_match):
2569 (Fmatch_data):
2570 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2571 (string_match_1, search_buffer, set_search_regs):
2572 (Fmatch_data):
2573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2574 (wordify): Check for overflow in size calculation.
2575 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
2576 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
2577 Check that fixnums are in proper range for system types.
2578 * sound.c (struct sound_device)
2579 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
2580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2581 (Fplay_sound_internal):
2582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 2583 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
2584 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
2585 (Fparse_partial_sexp):
2586 Don't assume fixnums can fit in int.
2587 (struct lisp_parse_state, find_start_pos, find_start_value)
2588 (find_start_value_byte, find_start_begv)
2589 (update_syntax_table, char_quoted, dec_bytepos)
2590 (find_defun_start, prev_char_comend_first, back_comment):
2591 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
2592 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
2593 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2594 (Finternal_describe_syntax_value): Check that match_lisp is a
2595 character, not an integer, since the code stuffs it into int.
2596 (scan_words, scan_sexps_forward):
2597 Check that fixnums are in proper range for system types.
2598 (Fforward_word):
2599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2600 (scan_sexps_forward):
2601 Use CHARACTERP, not INTEGERP, since the value must fit into int.
2602 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
2603 * syntax.h: Adjust decls to match defn changes elsewhere.
2604 (struct gl_state_s):
2605 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
2606 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
2607 MOST_POSITIVE_FIXNUM.
d311d28c
PE
2608 * sysdep.c (wait_for_termination_1, wait_for_termination)
2609 (interruptible_wait_for_termination, mkdir):
2610 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
2611 (emacs_read, emacs_write):
2612 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
2613 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
2614 and double all fit in int.
d311d28c
PE
2615 * term.c (set_tty_color_mode):
2616 Check that fixnums are in proper range for system types.
2617 * termhooks.h (struct input_event):
2618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2619 * textprop.c (validate_interval_range, interval_of)
2620 (Fadd_text_properties, set_text_properties_1)
2621 (Fremove_text_properties, Fremove_list_of_text_properties)
2622 (Ftext_property_any, Ftext_property_not_all)
2623 (copy_text_properties, text_property_list, extend_property_ranges)
2624 (verify_interval_modification):
2625 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2626 (Fnext_single_char_property_change)
2627 (Fprevious_single_char_property_change):
2628 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
2629 (copy_text_properties):
2630 Check for integer overflow in index calculation.
d311d28c
PE
2631 * undo.c (last_boundary_position, record_point, record_insert)
2632 (record_delete, record_marker_adjustment, record_change)
2633 (record_property_change):
2634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2635 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
2636 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2637 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2638 (Fx_hide_tip, Fx_file_dialog):
2639 * w32menu.c (set_frame_menubar):
2640 Use ptrdiff_t, not int, for consistency with rest of code.
2641 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
2642 (select_window, Fdelete_other_windows_internal)
2643 (window_scroll_pixel_based, window_scroll_line_based)
2644 (Frecenter, Fset_window_configuration):
2645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2646 (Fset_window_hscroll, run_window_configuration_change_hook)
2647 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 2648 (Fscroll_other_window, Frecenter):
d311d28c
PE
2649 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2650 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
2651 Don't assume fixnum fits in int.
2652 (Fset_window_scroll_bars):
2653 Check that fixnums are in proper range for system types.
2654 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
2655 (string_pos, c_string_pos, number_of_chars, init_iterator)
2656 (in_ellipses_for_invisible_text_p, init_from_display_pos)
2657 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
2658 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
2659 (face_before_or_after_it_pos, handle_invisible_prop)
2660 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
2661 (display_prop_intangible_p, string_buffer_position_lim)
2662 (string_buffer_position, handle_composition_prop, load_overlay_strings)
2663 (get_overlay_strings_1, get_overlay_strings)
2664 (iterate_out_of_display_property, forward_to_next_line_start)
2665 (back_to_previous_visible_line_start, reseat, reseat_to_string)
2666 (get_next_display_element, set_iterator_to_next)
2667 (get_visually_first_element, compute_stop_pos_backwards)
2668 (handle_stop_backwards, next_element_from_buffer)
2669 (move_it_in_display_line_to, move_it_in_display_line)
2670 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2671 (add_to_log, message_dolog, message_log_check_duplicate)
2672 (message2, message2_nolog, message3, message3_nolog
2673 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
2674 (current_message_1, truncate_echo_area, truncate_message_1)
2675 (set_message, set_message_1, store_mode_line_noprop)
2676 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
2677 (text_outside_line_unchanged_p, check_point_in_composition)
2678 (reconsider_clip_changes)
2679 (redisplay_internal, set_cursor_from_row, try_scrolling)
2680 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
2681 (redisplay_window, find_last_unchanged_at_beg_row)
2682 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
2683 (trailing_whitespace_p, find_row_edges, display_line)
2684 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
2685 (display_mode_element, store_mode_line_string)
2686 (pint2str, pint2hrstr, decode_mode_spec)
2687 (display_count_lines, display_string, draw_glyphs)
2688 (x_produce_glyphs, x_insert_glyphs)
2689 (rows_from_pos_range, mouse_face_from_buffer_pos)
2690 (fast_find_string_pos, mouse_face_from_string_pos)
2691 (note_mode_line_or_margin_highlight, note_mouse_highlight):
2692 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2693 (safe_call, init_from_display_pos, handle_fontified_prop)
2694 (handle_single_display_spec, load_overlay_strings)
2695 (with_echo_area_buffer, setup_echo_area_for_printing)
2696 (display_echo_area, echo_area_display)
2697 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
2698 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
2699 (redisplay_window, dump_glyph_row, display_mode_line)
2700 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 2701 (handle_display_spec, display_prop_string_p):
d311d28c
PE
2702 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2703 (handle_single_display_spec, build_desired_tool_bar_string)
2704 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
2705 (get_specified_cursor_type):
2706 Check that fixnums are in proper range for system types.
2707 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
2708 (Flookup_image_map):
2709 Don't assume fixnums fit in int.
2710 (compare_overlay_entries):
2711 Avoid mishandling comparisons due to subtraction overflow.
2712 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
2713 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
2714 (handle_tool_bar_click):
2715 Use int, not unsigned, since we prefer signed and the signedness
2716 doesn't matter here.
2717 (get_next_display_element, next_element_from_display_vector):
2718 Use int, not EMACS_INT, when int is wide enough.
2719 (start_hourglass): Use duration_to_sec_usec to do proper
2720 overflow checking on durations.
2721 * xfaces.c (Fbitmap_spec_p):
2722 Check that fixnums are in proper range for system types.
2723 (compare_fonts_by_sort_order):
2724 Avoid mishandling comparisons due to subtraction overflow.
2725 (Fx_family_fonts, realize_basic_faces):
2726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2727 (Fx_family_fonts):
2728 Don't assume fixnum fits in int.
2729 Use SAFE_ALLOCA_LISP, not alloca.
2730 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
2731 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
2732 (face_at_buffer_position, face_for_overlay_string)
2733 (face_at_string_position):
2734 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2735 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
2736 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
2737 (Fx_show_tip):
2738 Check that fixnums are in proper range for system types.
2739 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
2740 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
2741 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2742 (Fx_change_window_property): Don't assume fixnums fit in int.
2743 * xfont.c (xfont_chars_supported):
2744 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2745 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
2746 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
2747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2748 * xml.c (parse_region):
2749 * xrdb.c (magic_file_p):
2750 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
2751 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
2752 (x_get_local_selection, x_reply_selection_request)
2753 (x_handle_selection_request, wait_for_property_change):
2754 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2755 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
2756 short is wide enough.
2757 (x_send_client_event): Don't assume fixnum fits in int.
2758 * xterm.c (x_x_to_emacs_modifiers):
2759 Don't assume EMACS_INT overflows nicely into int.
2760 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
2761 may come from Lisp.
2762 (handle_one_xevent): NATNUMP can eval its arg twice.
2763 (x_connection_closed):
2764 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
2765 * xterm.h: Adjust decls to match defn changes elsewhere.
2766 (struct scroll_bar): Use struct vectorlike_header
2767 rather than rolling our own approximation.
2768 (SCROLL_BAR_VEC_SIZE): Remove; not used.
2769
c6574eb5
GM
27702012-05-25 Glenn Morris <rgm@gnu.org>
2771
2772 * lisp.mk (lisp): Update for more files being compiled now.
2773
e8d32c7e
SM
27742012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
2775
48def666
SM
2776 * lread.c: Remove `read_pure' which makes no difference.
2777 (read_pure): Remove var.
2778 (unreadpure): Remove function.
2779 (readevalloop): Don't call read_list with -1 flag.
2780 (read1, read_vector): Don't test read_pure any more.
2781 (read_list): Simplify.
2782
e8d32c7e
SM
2783 * fileio.c, character.h: Minor style tweaks.
2784
4b2addb7
DA
27852012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
2786
2787 * window.h (clip_changed): Remove useless declaration.
2788
584461b2
JB
27892012-05-22 Juanma Barranquero <lekktu@gmail.com>
2790
2791 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
2792 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
2793
34374650
PE
27942012-05-22 Paul Eggert <eggert@cs.ucla.edu>
2795
2796 Remove src/m/*.
2797 This directory predates autoconf and is no longer needed nowadays.
2798 Move its few remaining bits of functionality to where they're needed.
2799 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
2800 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
2801 * m/template.h: Remove.
2802 * Makefile.in (M_FILE): Remove. All uses removed.
2803 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
2804 * lisp.h (USE_LSB_TAG):
2805 * mem-limits.h (EXCEEDS_LISP_PTR):
2806 Use VAL_MAX, not VALBITS, in #if.
2807 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
2808 (EMACS_UINT): Define unconditionally now.
2809 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
2810 (BITS_PER_EMACS_INT): New constants, replacing
2811 what used to be in config.h, but not useful in #if.
2812 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
2813 define them any more.
2814 (VAL_MAX): New macro.
2815 (VALMASK): Use it.
2816 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
2817 BITS_PER_EMACS_INT, in #if.
2818 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
2819 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
2820 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
2821 * s/ms-w32.h (DATA_START):
2822 Move here from removed file m/intel386.h.
2823 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
2824 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
2825
261cb4bb
PE
28262012-05-21 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 Assume C89 or later.
2829 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
2830 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
2831 (xrealloc):
2832 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
2833 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
2834 * textprop.c, tparam.c (NULL): Remove.
2835 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
2836 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
2837 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
2838 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
2839 * xterm.c (input_signal_count): Assume volatile works.
2840
ff23cd9f
KB
28412012-05-21 Ken Brown <kbrown@cornell.edu>
2842
2843 * xgselect.c (xg_select): Fix first argument in call to 'select'
2844 (bug#11508).
2845
1b170bc6
KB
28462012-05-20 Ken Brown <kbrown@cornell.edu>
2847
2848 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 2849 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 2850
b2f4d39f
KB
28512012-05-19 Ken Brown <kbrown@cornell.edu>
2852
2853 * xfns.c (x_in_use): Remove `static' qualifier.
2854 * xterm.h (x_in_use): Declare.
2855 * xgselect.c: Include xterm.h.
2856 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
2857 and `display_arg' (bug#9754).
2858
003fdae2
PE
28592012-05-19 Paul Eggert <eggert@cs.ucla.edu>
2860
9232a6d9
PE
2861 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
2862
003fdae2
PE
2863 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
2864 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
2865
784b56e2
EZ
28662012-05-18 Eli Zaretskii <eliz@gnu.org>
2867
2868 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
2869
2870 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 2871 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
2872
2873 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
2874 reference to image_cache->refcount.
2875 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
2876
a0a79cde
JL
28772012-05-17 Juri Linkov <juri@jurta.org>
2878
2879 * search.c (Fword_search_regexp, Fword_search_backward)
2880 (Fword_search_forward, Fword_search_backward_lax)
2881 (Fword_search_forward_lax): Move functions to isearch.el
2882 (bug#10145, bug#11381).
2883
b0572523
PE
28842012-05-16 Paul Eggert <eggert@cs.ucla.edu>
2885
2886 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
2887
9660f5fc
SM
28882012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
2889
2890 * lread.c (init_obarray): Declare Qt and Qnil as special.
2891
4374de83
GM
28922012-05-14 Glenn Morris <rgm@gnu.org>
2893
2894 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 2895 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 2896
dc44c39a
PE
28972012-05-14 Paul Eggert <eggert@cs.ucla.edu>
2898
078c97cb
PE
2899 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
2900
dc44c39a
PE
2901 * unexaix.c: Port to more-recent AIX compilers.
2902 (report_error, report_error_1, make_hdr, copy_sym)
2903 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
2904 Make arguments const char *, not char *, to avoid violations of C
2905 standard and to fix some AIX warnings reported by Gilles Pion.
2906
e18afed7 29072012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
2908
2909 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
2910 already have overlays loaded.
2911 (handle_single_display_spec): Before returning without displaying
2912 fringe bitmap, synchronize the bidi iterator with the main display
2913 iterator, by calling iterate_out_of_display_property.
2914 (iterate_out_of_display_property): Detect buffer iteration by
2915 testing that it->string is a Lisp string.
2916 (get_next_display_element): When the current object is exhausted,
2917 and there's something on it->stack, call set_iterator_to_next to
2918 proceed with what's on the stack, instead of returning zero.
2919 (set_iterator_to_next): If called at the end of a Lisp string,
2920 proceed to consider_string_end without incrementing string
2921 position. Don't increment display vector index past the end of
2922 the display vector. (Bug#11417)
c8fb9dc6
EZ
2923 (pos_visible_p): Don't report a position visible when move_it_to
2924 stopped at the last line of window, which happens to be scanned
2925 backwards by the bidi iteration. (Bug#11464)
ac268e67 2926
e18afed7 29272012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
2928
2929 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
2930 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
2931 are on a TTY, and thus unable to display on the fringes.
2932 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
2933 so we need to signal to the caller that this is a "replacing"
2934 display spec. This fixes display when the spec is invalid or we
2935 are on a TTY.
2936
e18afed7 29372012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
2938
2939 * unexaix.c (make_hdr): Fix typo in prototype.
2940 This bug broke the build on AIX. Problem reported by Gilles Pion.
2941
9d0a235a
MA
29422012-05-14 Michael Albinus <michael.albinus@gmx.de>
2943
2944 * keyboard.c (kbd_buffer_get_event): Read special events also in
2945 batch mode. (Bug#11415)
2946
9e6b06ed
GM
29472012-05-12 Glenn Morris <rgm@gnu.org>
2948
2949 * ns.mk: Update for ns_appbindir no longer having trailing "/".
2950
c1a1d7a3
EZ
29512012-05-12 Eli Zaretskii <eliz@gnu.org>
2952
2953 * lisp.mk (lisp): Add newcomment.elc.
2954
3fe7cdc8
GM
29552012-05-12 Glenn Morris <rgm@gnu.org>
2956
2957 * Makefile.in (MKDIR_P): New, set by configure.
2958 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
2959
53f7d2c0
PE
29602012-05-11 Paul Eggert <eggert@cs.ucla.edu>
2961
2962 Remove unused function hourglass_started.
2963 * dispextern.h (hourglass_started):
2964 * w32fns.c (hourglass_started):
2965 * xdisp.c (hourglass_started): Remove.
2966
75aafb17
JB
29672012-05-10 Juanma Barranquero <lekktu@gmail.com>
2968
2969 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
2970 Update dependencies.
2971
12959e8e
PE
29722012-05-10 Paul Eggert <eggert@cs.ucla.edu>
2973
97107e2e
PE
2974 * xgselect.c (xg_select): Put maxfds+1 into a var.
2975 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
2976
12959e8e
PE
2977 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
2978
836d29b3
DA
29792012-05-10 Dave Abrahams <dave@boostpro.com>
2980
2981 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
2982 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
2983
5cb67954
MA
29842012-05-09 Michael Albinus <michael.albinus@gmx.de>
2985
2986 * dbusbind.c (xd_registered_buses): New internal Lisp object.
2987 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
2988 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
2989 Initialize xd_registered_buses.
2990
3478ec45
PE
29912012-05-09 Paul Eggert <eggert@cs.ucla.edu>
2992
b263a6b0
PE
2993 Untag more efficiently if USE_LSB_TAG.
2994 This is based on a proposal by YAMAMOTO Mitsuharu in
2995 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
2996 For an admittedly artificial (nth 8000 longlist) benchmark on
2997 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
2998 Emacs's overall text size by 1%.
2999 * lisp.h (XUNTAG): New macro.
3000 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
3001 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
3002 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
3003 * eval.c (Fautoload):
3004 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
3005 * frame.h (XFRAME): Use XUNTAG.
3006
3478ec45
PE
3007 Port recent dbusbind.c changes to 32-bit --with-wide-int.
3008 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
3009 Remove unportable assumptions about print widths of types like
3010 dbus_uint32_t.
3011 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
3012 intptr_t when converting between pointer and integer, to avoid GCC
3013 warnings about wrong width.
3014
666b903b 30152012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
3016
3017 * w32proc.c (new_child): Force Windows to reserve only 64KB of
3018 stack for each reader_thread, instead of defaulting to 8MB
3019 determined by the linker. This avoids failures in creating
3020 subprocesses on Windows 7, see the discussion in this thread:
3021 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
3022
b120cc17
JC
30232012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
3024
3025 Fix up display of the *Minibuf-0* buffer in the mini window.
3026 * keyboard.c (read_char): Don't clear the echo area if there's no
3027 message to clear.
3028 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 3029 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 3030
9a4b36f8
MA
30312012-05-07 Michael Albinus <michael.albinus@gmx.de>
3032
3033 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
3034 batch mode.
3035
e5f9458f
CY
30362012-05-06 Chong Yidong <cyd@gnu.org>
3037
3038 * lisp.mk (lisp): Update.
3039
eceeb5fc 30402012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
3041
3042 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
3043
71873e2b
SM
30442012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
3045
3046 * data.c (PUT_ERROR): New macro.
3047 (syms_of_data): Use it. Add new error type `user-error'.
3048 * undo.c (user_error): New function.
3049 (Fprimitive_undo): Use it.
3050 * print.c (print_error_message): Adjust print style for `user-error'.
3051 * keyboard.c (user_error): New function.
3052 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
3053
ab0fa4e4
PE
30542012-05-03 Paul Eggert <eggert@cs.ucla.edu>
3055
3056 Do not limit current-time-string to years 1000..9999.
3057 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
3058 (Fcurrent_time_string): Support any year that is supported by the
3059 underlying localtime representation. Don't use asctime, as it
3060 has undefined behavior for years outside the range -999..9999.
3061
7ed806a7
PE
30622012-05-02 Paul Eggert <eggert@cs.ucla.edu>
3063
3064 Fix race conditions involving setenv, gmtime, localtime, asctime.
3065 Without this fix, interrupts could mess up code that uses these
3066 nonreentrant functions, since setting TZ invalidates existing
3067 tm_zone or tzname values, and since most of these functions return
3068 pointers to static storage.
3069 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
3070 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
3071 Grow the critical sections to include not just invoking
3072 localtime/gmtime, but also accessing these functions' results
3073 including their tm_zone values if any, and any related TZ setting.
3074 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
3075 so that the struct tm is saved in the critical section.
3076 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
3077 motivated by the fact that memory allocation needs to be outside
3078 the critical section.
3079
0c16dfed
DA
30802012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
3081
3082 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
3083 with RESET_INTERVAL.
3084
3085 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3086 Remove duplicated buffer name initialization.
3087
3f83ace8
JM
30882012-05-02 Jim Meyering <jim@meyering.net>
3089
3090 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
3091
c7b8541e
JM
3092 * xfns.c (x_window): Use xstrdup (Bug#11375).
3093
90207a15 30942012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
3095
3096 * xdisp.c (pos_visible_p): If already at a newline from the
3097 display string before the 'while' loop, don't walk back the glyphs
3098 from it3.glyph_row. Solves assertion violation when the display
3099 string begins with a newline (egg.el). (Bug#11367)
3100
b593d6a9
AH
31012012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
3102
3103 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
3104 Move to simple.el.
3105
4737362e
GM
31062012-05-01 Glenn Morris <rgm@gnu.org>
3107
99cf43f9
GM
3108 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
3109 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
3110 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
3111 All were removed before 23.1.
3112
9311dcff
GM
3113 * dispnew.c: Remove HAVE_LIBNCURSES test;
3114 it is always true on relevant platforms.
3115
4d5c6349
GM
3116 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
3117 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
3118
4737362e
GM
3119 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
3120
74dd3a6b
AS
31212012-04-30 Andreas Schwab <schwab@linux-m68k.org>
3122
3123 * .gdbinit (xpr): Remove checks for no longer existing misc types.
3124 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
3125 Remove.
3126
13c379ee
PE
31272012-04-28 Paul Eggert <eggert@cs.ucla.edu>
3128
3129 Do not avoid creating empty evaporating overlays (Bug#9642).
3130 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
3131 That is, do not delete an evaporating overlay if it becomes
3132 empty after its bounds are adjusted to fit within its buffer.
3133 This fix caused other problems, and I'm reverting it until we get
3134 to the bottom of them.
3135
a8e7d6d7 31362012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
3137
3138 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
3139
a8e7d6d7 31402012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
3141
3142 * xdisp.c (pos_visible_p): If the window start position is beyond
3143 ZV, start the display from buffer beginning. Prevents assertion
3144 violation in init_iterator when the minibuffer window is scrolled
3145 via the scroll bar.
3146
3147 * window.c (window_scroll_pixel_based): Likewise.
3148
a8e7d6d7 31492012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
3150
3151 * keymap.c (where_is_internal): Doc fix (Bug#10872).
3152
a8e7d6d7 31532012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
3154
3155 * fileio.c (Fcopy_file, Fset_file_selinux_context):
3156 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
3157
a8e7d6d7 31582012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 3159
b593d6a9
AH
3160 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
3161 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 3162
1c6900d9
EZ
31632012-04-26 Eli Zaretskii <eliz@gnu.org>
3164
4c3fa1d9
EZ
3165 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
3166 display element, check also the underlying string or buffer
3167 character. (Bug#11341)
3168
1c6900d9
EZ
3169 * w32menu.c: Include w32heap.h.
3170 (add_menu_item): If the call to AppendMenuW (via
3171 unicode_append_menu) fails, disable Unicode menus only if we are
3172 running on Windows 9X/Me.
3173
42bf8205
AS
31742012-04-24 Andreas Schwab <schwab@linux-m68k.org>
3175
3176 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
3177 (xgetint): Add missing shift for LSB tags.
3178
b1bac16e
MR
31792012-04-24 Martin Rudalics <rudalics@gmx.at>
3180
3181 * keyboard.c (read_char): Don't wipe echo area for select window
3182 events: These might get delayed via `mouse-autoselect-window'
3183 (Bug#11304).
3184
d69621cc
JB
31852012-04-24 Juanma Barranquero <lekktu@gmail.com>
3186
3187 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
3188 manipulation of :loaded-from data.
3189
02fd101b
JB
31902012-04-23 Juanma Barranquero <lekktu@gmail.com>
3191
3192 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
3193 now a cons (bug#11311).
3194
888bec30
PE
31952012-04-23 Paul Eggert <eggert@cs.ucla.edu>
3196
89a438bd
PE
3197 Do not create empty overlays with the evaporate property (Bug#9642).
3198 * buffer.c (Fmove_overlay): Delete an evaporating overlay
3199 if it becomes empty after its bounds are adjusted to fit within
3200 its buffer. Without this fix, in a nonempty buffer (let ((o
3201 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
3202 yields an empty overlay that has the evaporate property, which is
3203 not supposed to happen.
3204
1068fe4d
PE
3205 Fix minor GTK3 problems found by static checking.
3206 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3207 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3208 (struct _EmacsFixedClass, emacs_fixed_get_type):
3209 Move decls here from emacsgtkfixed.h, since they needn't be public.
3210 (emacs_fixed_get_type): Now static.
3211 (emacs_fixed_class_init): Omit unused local.
3212 (emacs_fixed_child_type): Remove; unused.
3213 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
3214 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
3215 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
3216 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
3217 (EMACS_FIXED_GET_CLASS): Remove; unused.
3218 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
3219
888bec30
PE
3220 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
3221 Problem reported by Juanma Barranquero for Windows -Wunused-function.
3222
de85e130
PE
32232012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3224
d0baac98 3225 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 3226 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
3227 (__malloc_size_t, __malloc_ptrdiff_t):
3228 Remove. All uses removed, replaced by the definiens if needed,
3229 since we can assume C89 or better now.
3230 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
3231 (protect_malloc_state, align, get_contiguous_space)
3232 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
3233 (malloc_atfork_handler_child, malloc_enable_thread)
3234 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
3235 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
3236 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
3237 (special_realloc, _realloc_internal_nolock, _realloc_internal)
3238 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
3239 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
3240 Define using prototypes, not old style.
3241 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
3242 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
3243 (align): Don't assume that signed integer overflow wraps around.
3244 Omit unused local var.
3245 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
3246 (_free_internal_nolock, memalign, mallochook, reallochook):
3247 Omit no-longer-needed casts.
3248 (valloc): Use getpagesize, not __getpagesize.
3249 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
3250 (struct hdr): The 'magic' member is now size_t, not unsigned long.
3251
de85e130
PE
3252 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
3253
dcbf5805
MA
32542012-04-22 Michael Albinus <michael.albinus@gmx.de>
3255
3256 Move functions from C to Lisp. Make non-blocking method calls
3257 the default. Implement further D-Bus standard interfaces.
3258
3259 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
3260 (QCdbus_request_name_allow_replacement)
3261 (QCdbus_request_name_replace_existing)
3262 (QCdbus_request_name_do_not_queue)
3263 (QCdbus_request_name_reply_primary_owner)
3264 (QCdbus_request_name_reply_in_queue)
3265 (QCdbus_request_name_reply_exists)
3266 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
3267 (QCdbus_registered_serial, QCdbus_registered_method)
3268 (QCdbus_registered_signal): New Lisp objects.
3269 (XD_DEBUG_MESSAGE): Use sizeof.
3270 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
3271 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
3272 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
3273 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
3274 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
3275 (xd_signature, xd_append_arg): Allow float for integer types.
3276 (xd_get_connection_references): New function.
b593d6a9
AH
3277 (xd_get_connection_address): Rename from xd_initialize.
3278 Return cached address.
dcbf5805
MA
3279 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
3280 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
3281 level.
3282 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 3283 Return number of refcounts.
dcbf5805
MA
3284 (Fdbus_get_unique_name): Make stronger parameter check.
3285 (Fdbus_message_internal): New defun.
3286 (Fdbus_call_method, Fdbus_call_method_asynchronously)
3287 (Fdbus_method_return_internal, Fdbus_method_error_internal)
3288 (Fdbus_send_signal, Fdbus_register_service)
3289 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
3290 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
3291 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
3292 (Vdbus_compiled_version, Vdbus_runtime_version)
3293 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
3294 (Vdbus_message_type_method_return, Vdbus_message_type_error)
3295 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
3296 (Vdbus_registered_buses, Vdbus_registered_objects_table):
3297 Adapt docstring.
dcbf5805 3298
52828e02
PE
32992012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3300
da05bc4c
PE
3301 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
3302 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
3303 Do not assume ptrdiff_t is the same width as 'int'.
3304
52828e02
PE
3305 * alloc.c: Handle unusual debugging option combinations.
3306 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
3307 since the two debugging options are incompatible.
3308 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
3309 is defined.
3310 (mem_init, mem_insert, mem_insert_fixup):
3311 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
3312 (NEED_MEM_INSERT): Remove; no longer needed.
3313
f01769f9
LL
33142012-04-22 Leo Liu <sdl.web@gmail.com>
3315
3316 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
3317
5790543d
PE
33182012-04-22 Paul Eggert <eggert@cs.ucla.edu>
3319
3320 * sysdep.c [__FreeBSD__]: Minor cleanups.
3321 (list_system_processes, system_process_attributes) [__FreeBSD__]:
3322 Use Emacs indenting style more consistently. Avoid some casts.
3323 Use 'double' consistently rather than mixing 'float' and 'double'.
3324
b91b7e4d
EW
33252012-04-21 Eduard Wiebe <usenet@pusto.de>
3326
b593d6a9
AH
3327 * sysdep.c (list_system_processes, system_process_attributes):
3328 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 3329
6114eb15
AS
33302012-04-21 Andreas Schwab <schwab@linux-m68k.org>
3331
3332 * lisp.mk (lisp): Update.
3333
2f38dff7
PE
33342012-04-20 Paul Eggert <eggert@cs.ucla.edu>
3335
3336 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
3337 It is never used otherwise.
3338
4ae29f89
SM
33392012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
3340
3341 * print.c (print_preprocess): Only check print_depth if print-circle
3342 is nil.
3343 (print_object): Check for cycles even when print-circle is nil and
3344 print-gensym is t, but only check print_depth if print-circle is nil.
3345
f30d612a
CY
33462012-04-20 Chong Yidong <cyd@gnu.org>
3347
3348 * process.c (wait_reading_process_output): If EIO occurs on a pty,
3349 set the status to "failed" and ensure that sentinel is run.
3350
c07a4c0b 33512012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
3352
3353 * process.c (Fset_process_inherit_coding_system_flag)
3354 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 3355 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 3356
c07a4c0b 33572012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
3358
3359 * xdisp.c (string_buffer_position_lim): Limit starting position to
3360 BEGV.
3361 (set_cursor_from_row): If called for a mode-line or header-line
3362 row, return zero immediately.
3363 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
3364 farther than the first row after the header line, if any.
3365 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
3366 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
3367
c07a4c0b 33682012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3369
4ae29f89
SM
3370 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
3371 (bug#11238).
ad3a2b41 3372
c07a4c0b 33732012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 33742012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
3375
3376 configure: new option --enable-gcc-warnings (Bug#11207)
3377 * Makefile.in (C_WARNINGS_SWITCH): Remove.
3378 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
3379 (ALL_CFLAGS): Use new macros rather than old.
3380 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
3381 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
3382 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
3383 -Wunused-result, -Wunused-variable. This should go away once
3384 the Emacs and Gnulib regex code is merged.
3385 (xmalloc, xrealloc): Now static.
3386
aba027e8
PE
33872012-04-17 Paul Eggert <eggert@cs.ucla.edu>
3388
3389 * dired.c (Fsystem_groups): Remove unused local.
3390
e5a36063
GM
33912012-04-17 Glenn Morris <rgm@gnu.org>
3392
3393 * dired.c (Fsystem_users): Doc fix.
3394
316411f0
DA
33952012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
3396
3397 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
3398 (syms_of_dired): Add them.
3399
9426aba4
PE
34002012-04-16 Paul Eggert <eggert@cs.ucla.edu>
3401
b62a57be
PE
3402 Fix minor alloc.c problems found by static checking.
3403 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
3404 New extern decls, to avoid calling undeclared functions.
3405 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
3406 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
3407 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
3408 (NEED_MEM_INSERT): New macro.
3409 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 3410 Remove one incorrect comment and fix another.
b62a57be 3411
3539f31f
PE
3412 Fix minor ralloc.c problems found by static checking.
3413 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3414 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
3415 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
3416 (r_alloc_sbrk): Now static.
3417
a041960a
PE
3418 Improve ralloc.c interface checking.
3419 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
3420 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
3421 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
3422 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
3423 [REL_ALLOC]: ... to here, to check interface.
3424 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
3425 Remove decls. This fixes an "It stinks!".
3426
9426aba4
PE
3427 * alloc.c (which_symbols): Fix alignment issue / type clash.
3428
d55c12ed
AS
34292012-04-15 Andreas Schwab <schwab@linux-m68k.org>
3430
3431 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
3432 (struct Lisp_Misc_Any): Likewise.
3433 (struct Lisp_Free): Likewise.
3434 * alloc.c (union aligned_Lisp_Symbol): Define.
3435 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
3436 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
3437 (union aligned_Lisp_Misc): Define.
3438 (MARKER_BLOCK_SIZE, struct marker_block): Use union
3439 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 3440 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 3441
b948ce8b
PE
34422012-04-14 Paul Eggert <eggert@cs.ucla.edu>
3443
3444 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
3445 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
3446 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
3447 * s/netbsd.h, s/sol2-6.h:
3448 Remove definition of GC_MARK_STACK, since the default now works.
3449 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
3450 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
3451 no longer the default.
3452 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
3453
35dc09a1 34542012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 3455
35dc09a1
GM
3456 * lread.c (lisp_file_lexically_bound_p):
3457 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 3458
35dc09a1
GM
34592012-04-14 Eli Zaretskii <eliz@gnu.org>
3460
3461 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
3462 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
3463
34642012-04-14 Jan Djärv <jan.h.d@swipnet.se>
3465
3466 * nsterm.m (constrainFrameRect): Always constrain when there is only
3467 one screen (Bug#10962).
3468
bcd86815
KB
34692012-04-13 Ken Brown <kbrown@cornell.edu>
3470
3471 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
3472
c25df26e
RT
34732012-04-13 Reuben Thomas <rrt@sc3d.org>
3474
3475 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
3476
0fc59f1e
DC
34772012-04-11 Daniel Colascione <dancol@dancol.org>
3478
3479 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
3480 against is gone. It's better to use vfork now so that when Cygwin
3481 gains a new, working vfork, we use it automatically (bug#10398).
3482
de8c03dc
SM
34832012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3484
3485 * window.c (save_window_save): Obey window-point-insertion-type.
3486
2f097256
GM
34872012-04-11 Glenn Morris <rgm@gnu.org>
3488
3489 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
3490
453b951e
SM
34912012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
3492
3493 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
3494
75f1671a 34952012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
3496
3497 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
3498 (force_quit_count): New var.
3499 (handle_interrupt): Use it.
3500
2a8ce227
JB
35012012-04-10 Juanma Barranquero <lekktu@gmail.com>
3502
3503 * w32.c (w32_delayed_load): Record the full path of the library
3504 being loaded (bug#10424).
3505
935396c0
GM
35062012-04-09 Glenn Morris <rgm@gnu.org>
3507
05920a43
GM
3508 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
3509 not just in the obarray, before snarfing them. (Bug#11036)
3510
935396c0
GM
3511 * Makefile.in ($(leimdir)/leim-list.el):
3512 Pass EMACS rather than BUILT_EMACS.
3513
a18ecafa
TZ
35142012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
3515
3516 * process.c (make_process):
3517 * process.h: Add integer `gnutls_handshakes_tried' member to
3518 process struct.
3519
6bbef4e5
JC
3520 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
3521 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
3522
3523 * gnutls.c (gnutls_log_function2i): Convenience log function.
3524 (emacs_gnutls_read): Use new log functions,
3525 `gnutls_handshakes_tried' process member, and
3526 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
3527 attempts per process (connection).
3528
b4d3bc10
CY
35292012-04-09 Chong Yidong <cyd@gnu.org>
3530
3531 * eval.c (Fuser_variable_p, user_variable_p_eh)
3532 (lisp_indirect_variable): Functions deleted.
3533 (Fdefvar): Caller changed.
3534
3535 * callint.c (Finteractive, Fcall_interactively):
3536 * minibuf.c (Fread_variable): Callers changed.
3537
70f4d973
EZ
35382012-04-09 Eli Zaretskii <eliz@gnu.org>
3539
3540 * xdisp.c (set_cursor_from_row): If the display string appears in
3541 the buffer at position that is closer to point than the position
3542 after the display string, display the cursor on the first glyph of
3543 the display string. Fixes cursor display when a 'display' text
3544 property immediately follows invisible text. (Bug#11094)
3545
cb3c2e3e
PE
35462012-04-09 Paul Eggert <eggert@cs.ucla.edu>
3547
3548 composite.c: use 'double' consistently
3549 * composite.c (get_composition_id): Use 'double' consistently
3550 instead of converting 'float' to 'double' and vice versa; this is
3551 easier to understand and avoids a GCC warning.
3552
fd06db5d
GM
35532012-04-09 Glenn Morris <rgm@gnu.org>
3554
50fe702a
GM
3555 * Makefile.in: Generate leim-list with bootstrap-emacs, in
3556 preparation for dumping it with emacs. (Bug#4789)
3557 (leimdir): New variable.
3558 ($(leimdir)/leim-list.el): New rule.
3559 (emacs$(EXEEXT)): Depend on leim-list.el.
3560
fd06db5d
GM
3561 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
3562 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
3563 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
3564
55c131ee
AS
35652012-04-08 Andreas Schwab <schwab@linux-m68k.org>
3566
3567 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
3568 proper alignment.
3569
9209588f
JB
35702012-04-07 Juanma Barranquero <lekktu@gmail.com>
3571
3572 * xml.c (init_libxml2_functions) [WINDOWSNT]:
3573 Remove unused local variable.
3574
e3fb2efb
PE
35752012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3576
3577 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
3578 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
3579 (mark_memory): Mark Lisp_Objects only if pointers might hide in
3580 objects, as mark_maybe_pointer will catch them otherwise.
3581 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
3582 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
3583
b5385551
PE
35842012-04-07 Paul Eggert <eggert@cs.ucla.edu>
3585
3586 Fix typo that broke non-Windows builds.
3587 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
3588
9078ead6
EZ
35892012-04-07 Eli Zaretskii <eliz@gnu.org>
3590
3591 Support building on MS-Windows with libxml2.
3592
3593 * makefile.w32-in (OBJ2): Add xml.$(O).
3594 (GLOBAL_SOURCES): Add xml.c.
3595 ($(BLD)/xml.$(O)): New dependency list.
3596
3597 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
3598 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
3599 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
3600 [!WINDOWSNT]: New macros.
3601 (init_libxml2_functions, libxml2_loaded_p): New functions.
3602 (parse_region): Call fn_xmlCheckVersion instead of using the macro
3603 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
3604 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
3605 Calls xmlCleanupParser only if libxml2 was loaded (or statically
3606 linked in).
6bbef4e5
JC
3607 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
3608 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
3609 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
3610
3611 * emacs.c: Don't include libxml/parser.h.
3612 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
3613 xmlCleanupParser directly.
3614
3615 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
3616
3811fdf3
EZ
36172012-04-07 Eli Zaretskii <eliz@gnu.org>
3618
3619 * indent.c (Fvertical_motion): If there is a display string at
3620 point, use it.vpos to compute how many lines to backtrack after
3621 move_it_to point. (Bug#11133)
3622
2f8e16b2
EZ
36232012-04-06 Eli Zaretskii <eliz@gnu.org>
3624
3625 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
3626 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
3627 about subtle differences between FETCH_CHAR* and STRING_CHAR*
3628 macros related to unification of CJK characters. For the details,
3629 see the discussion following the message here:
3630 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
3631
3d439cd1
CY
36322012-04-04 Chong Yidong <cyd@gnu.org>
3633
3634 * keyboard.c (Vdelayed_warnings_list): Doc fix.
3635
8bc53d00
EZ
36362012-04-01 Eli Zaretskii <eliz@gnu.org>
3637
3638 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
3639 instead of alloca. (Bug#11138)
3640
3b0512a3
AS
36412012-04-01 Andreas Schwab <schwab@linux-m68k.org>
3642
3643 * w32menu.c (is_simple_dialog): Properly check lisp types.
3644 (Bug#11141)
3645
8427ddd2
EZ
36462012-03-31 Eli Zaretskii <eliz@gnu.org>
3647
979022ef
EZ
3648 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
3649 position we get to after a call to move_it_to fails the
3650 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
3651 only if we wind up in a string from display property. (Bug#11063)
3652
a6b1c7cc
EZ
3653 * window.c (Fdelete_other_windows_internal): Invalidate the row
3654 and column information about mouse highlight, so that redisplay
3655 restores it after reallocating the glyph matrices. (Bug#7464)
3656
8427ddd2
EZ
3657 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
3658 string comes from a `display' text property, use the buffer
3659 position of that property as if we actually saw that position in
3660 the row's glyphs.
697ba24b
EZ
3661 (move_it_by_lines): Remove the assertion that
3662 "it->current_x == 0 && it->hpos == 0" which can be legitimately
3663 violated when there's a before-string at the beginning of a line.
3664 (Bug#11063)
8427ddd2 3665
65a0a738
EZ
36662012-03-30 Eli Zaretskii <eliz@gnu.org>
3667
3668 * xdisp.c (append_space_for_newline): If the default face was
3669 remapped, use the remapped face for the appended newline.
3670 (extend_face_to_end_of_line): Use the remapped default face for
3671 extending the face to the end of the line.
3672 (display_line): Call extend_face_to_end_of_line when the default
3673 face was remapped. (Bug#11068)
3674
581355cc
EZ
36752012-03-29 Eli Zaretskii <eliz@gnu.org>
3676
3677 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
3678
e8fc049f
SM
36792012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3680
3681 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
3682
4fb9a543
GM
36832012-03-27 Glenn Morris <rgm@gnu.org>
3684
3685 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
3686 Doc fixes.
3687
679910f1
KH
36882012-03-26 Kenichi Handa <handa@m17n.org>
3689
3690 * dispextern.h (struct glyph): Fix previous change. Change the
3691 bit length of glyphless.ch to 25 (Bug#11082).
3692
90d49b7f
CY
36932012-03-26 Chong Yidong <cyd@gnu.org>
3694
3695 * keyboard.c (Vselection_inhibit_update_commands): New variable.
3696 (command_loop_1): Use it; inhibit selection update for
3697 handle-select-window too (Bug#8996).
3698
f514f6f0
FP
36992012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
3700
e8fc049f 3701 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 3702
bf43fa51
KH
37032012-03-25 Kenichi Handa <handa@m17n.org>
3704
3705 * dispextern.h (struct glyph): Change the bit length of
3706 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
3707
8a0c01dd
EZ
37082012-03-24 Eli Zaretskii <eliz@gnu.org>
3709
3710 * s/ms-w32.h (tzname): Include time.h before redirecting to
3711 _tzname. Fixes the MSVC build. (Bug#9960)
3712
7d1c3a76
AS
37132012-03-24 Andreas Schwab <schwab@linux-m68k.org>
3714
8ed79523
AS
3715 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
3716 characters.
3717
7d1c3a76
AS
3718 * xterm.c (XTread_socket): Only modify handling_signal if
3719 !SYNC_INPUT. (Bug#11080)
3720
e99a9b8b
EZ
37212012-03-23 Eli Zaretskii <eliz@gnu.org>
3722
3723 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
3724 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
3725 when fetching a multibyte character consumes more bytes than
3726 CHAR_BYTES returns, due to unification of CJK characters in
3727 string_char. (Bug#11073)
3728
5063c0e1
TN
37292012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
3730
3731 * process.c (wait_reading_process_output): Handle pty disconnect
3732 by refraining from sending oneself a SIGCHLD (bug#10933).
3733
9f851fbd
CY
37342012-03-22 Chong Yidong <cyd@gnu.org>
3735
3736 * dispextern.h (struct it): New member string_from_prefix_prop_p.
3737
5063c0e1 3738 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
3739 Mark string as coming from a prefix property.
3740 (handle_face_prop): Use default face for prefix strings (Bug#4281).
3741 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
3742
fb5b8aca
CY
37432012-03-21 Chong Yidong <cyd@gnu.org>
3744
3745 * xfaces.c (Vface_remapping_alist): Doc fix.
3746
62356a1b
EZ
37472012-03-20 Eli Zaretskii <eliz@gnu.org>
3748
3749 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
3750 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
3751 Doc fixes.
62356a1b 3752
025de85b
CY
37532012-03-20 Chong Yidong <cyd@gnu.org>
3754
3755 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
3756 to reflect default non-nil value of redisplay-dont-pause.
3757
4827f94e
KH
37582012-03-19 Kenichi Handa <handa@m17n.org>
3759
3760 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
3761 it fit in a valid range (Bug#11003).
3762
e50a24a2
EZ
37632012-03-18 Eli Zaretskii <eliz@gnu.org>
3764
3765 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
3766 that is not from display property, accept the row as a "cursor
3767 row" if one of the string's character has a non-nil `cursor'
3768 property. Fixes cursor positioning when there are newlines in
3769 overlay strings, e.g. in icomplete.el. (Bug#11035)
3770
9af5ed87
PE
37712012-03-12 Paul Eggert <eggert@cs.ucla.edu>
3772
3773 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
3774
d1f55f16
CY
37752012-03-12 Chong Yidong <cyd@gnu.org>
3776
3777 * eval.c (inhibit_lisp_code): Rename from
3778 inhibit_window_configuration_change_hook; move from window.c.
3779
3780 * xfns.c (unwind_create_frame_1, Fx_create_frame):
3781 * window.c (run_window_configuration_change_hook)
3782 (syms_of_window): Callers changed.
3783
66c5eebd
CY
37842012-03-11 Chong Yidong <cyd@gnu.org>
3785
413df973
CY
3786 * keymap.c (Fkey_description): Doc fix (Bug#9700).
3787
66c5eebd
CY
3788 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
3789
1de11f56
CY
37902012-03-10 Chong Yidong <cyd@gnu.org>
3791
3792 * frame.c (other_visible_frames): Don't assume the selected frame
3793 is visible (Bug#10955).
3794
cae07000
SM
37952012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
3796
3797 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
3798
89c94350
JD
37992012-03-08 Jan Djärv <jan.h.d@swipnet.se>
3800
3801 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
3802 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
3803 zero (Bug#10954).
3804
999dd333
GM
38052012-03-03 Glenn Morris <rgm@gnu.org>
3806
01a6dcc8 3807 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 3808
de0100f2
EZ
38092012-03-02 Eli Zaretskii <eliz@gnu.org>
3810
3811 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
3812 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
3813 (redisplay_window, next_element_from_string): Fix typos in
3814 comments.
3e441275
EZ
3815 (redisplay_window): Pass to move_it_vertically the margin in
3816 pixels, not in screen lines.
de0100f2 3817
96a72ee9
GM
38182012-03-02 Glenn Morris <rgm@gnu.org>
3819
3820 * buffer.c (buffer-list-update-hook): Doc fix.
3821
312508d7
EZ
38222012-02-29 Eli Zaretskii <eliz@gnu.org>
3823
3824 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
3825 push_it before setting up the iterator for the first overlay
3826 string, even if we have an empty string loaded.
3827 (next_overlay_string): If there's an empty string on the iterator
3828 stack, pop the stack. (Bug#10903)
3829
27f3c637
PE
38302012-02-25 Paul Eggert <eggert@cs.ucla.edu>
3831
3832 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
3833 Suggested by Stefan Monnier in
3834 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
3835 * alloc.c (widen_to_Lisp_Object): New static function.
3836 (mark_memory): Also mark Lisp_Objects by fetching pointer words
3837 and widening them to Lisp_Objects. This would work even if
3838 USE_LSB_TAG is defined and wide integers are used, which might
3839 happen in a future version of Emacs.
3840
3c9dfce6
CY
38412012-02-25 Chong Yidong <cyd@gnu.org>
3842
fa74b241
CY
3843 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
3844 Doc fix.
3845
3c9dfce6
CY
3846 * xselect.c (Fx_selection_exists_p): Doc fix.
3847 (x_clipboard_manager_save_all): Print an informative message
3848 before saving to clipboard manager.
3849
9486df08
CY
38502012-02-24 Chong Yidong <cyd@gnu.org>
3851
3852 * keyboard.c (process_special_events): Handle all X selection
3853 requests in kbd_buffer, not just the next one (Bug#8869).
3854
f01d3321
CY
38552012-02-23 Chong Yidong <cyd@gnu.org>
3856
3857 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
3858 call when setting menu-bar-lines and tool-bar-lines parameters.
3859 (unwind_create_frame_1): New helper function.
3860
3861 * window.c (inhibit_window_configuration_change_hook): New var.
3862 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 3863 (syms_of_window): Initialize it.
f01d3321 3864
86b847b6
CY
38652012-02-22 Chong Yidong <cyd@gnu.org>
3866
3867 * xterm.c (x_draw_image_relief): Add missing type check for
3868 Vtool_bar_button_margin (Bug#10743).
3869
a59225b1
CY
38702012-02-21 Chong Yidong <cyd@gnu.org>
3871
3872 * fileio.c (Vfile_name_handler_alist): Doc fix.
3873
3874 * buffer.c (Fget_file_buffer): Protect against invalid file
3875 handler return value.
3876
310f5bd4
PE
38772012-02-20 Paul Eggert <eggert@cs.ucla.edu>
3878
cb3a28cc
PE
3879 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
3880 when computing $valmask.
3881
310f5bd4
PE
3882 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
3883 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
3884 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
3885 It's useless in that case, and it can cause problems on hosts
3886 that allocate halves of EMACS_INT values separately.
3887 Reported by Dan Horák. Diagnosed by Andreas Schwab in
3888 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
3889 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
3890 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
3891 it avoids undefined behavior on hosts where shifting right by more
3892 than the word width has undefined behavior.
3893
2375c96a
CY
38942012-02-19 Chong Yidong <cyd@gnu.org>
3895
3896 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
3897 (Funhandled_file_name_directory, Ffile_name_as_directory)
3898 (Fdirectory_file_name, Fexpand_file_name)
3899 (Fsubstitute_in_file_name): Protect against invalid file handler
3900 return values (Bug#10845).
3901
3eb49e71
EZ
39022012-02-18 Eli Zaretskii <eliz@gnu.org>
3903
3904 * .gdbinit (pitx): Fix incorrect references to fields of the
3905 iterator stack.
3906
7b926f3f
CY
39072012-02-17 Chong Yidong <cyd@gnu.org>
3908
3909 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
3910
11273115
PE
39112012-02-15 Paul Eggert <eggert@cs.ucla.edu>
3912
3913 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
3914 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
3915
c3a70e2b
CY
39162012-02-15 Chong Yidong <cyd@gnu.org>
3917
3918 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
3919 marked as special. Also, starting docstrings with * is obsolete.
3920
0ca43699
AS
39212012-02-13 Andreas Schwab <schwab@linux-m68k.org>
3922
3923 * gnutls.c (emacs_gnutls_write): Fix last change.
3924
2e8f3c56
LI
39252012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
3926
3927 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
3928 send_process.
3929
af70074f
SM
39302012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
3931
3932 * keymap.c (Fsingle_key_description): Handle char ranges.
3933
95986d52
CY
39342012-02-12 Chong Yidong <cyd@gnu.org>
3935
afd83bd1
CY
3936 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
3937 as that creates a dangerous corner case.
3938
95986d52
CY
3939 * window.c (Fdelete_window_internal): Invalidate the mouse
3940 highlight (Bug#9904).
3941
bd7da63e
GM
39422012-02-12 Glenn Morris <rgm@gnu.org>
3943
3944 * xselect.c (Fx_own_selection_internal)
3945 (Fx_get_selection_internal, Fx_disown_selection_internal)
3946 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
3947 * nsselect.m (Fx_own_selection_internal)
3948 (Fx_disown_selection_internal, Fx_selection_exists_p)
3949 (Fx_selection_owner_p, Fx_get_selection_internal):
3950 Sync docs and argument specs with the xselect.c versions.
3951
77abcbc2
LI
39522012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
3953
3954 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
3955
90b671e2
EZ
39562012-02-11 Eli Zaretskii <eliz@gnu.org>
3957
1c0ca0b7
EZ
3958 * w32select.c (Fx_selection_exists_p): Sync doc string and
3959 argument list with xselect.c. (Bug#10783)
3960
3961 * w16select.c (Fx_selection_exists_p): Sync doc string and
3962 argument list with xselect.c. (Bug#10783)
90b671e2 3963
49241268
GM
39642012-02-10 Glenn Morris <rgm@gnu.org>
3965
3966 * fns.c (Fsecure_hash): Doc fix.
3967
f998bbe7 39682012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
3969
3970 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
3971
0992bd9c
CY
39722012-02-07 Chong Yidong <cyd@gnu.org>
3973
3974 * buffer.c (Fbuffer_local_variables)
3975 (buffer_lisp_local_variables): Handle unbound vars correctly;
3976 don't let Qunbound leak into Lisp.
3977
af008560
GM
39782012-02-07 Glenn Morris <rgm@gnu.org>
3979
dd605cc4
GM
3980 * image.c (Fimagemagick_types): Doc fix.
3981
af008560
GM
3982 * image.c (imagemagick-render-type): Change it from a lisp object
3983 to an integer. Move the doc here from the lisp manual.
3984 Treat all values not equal to 0 the same.
3985
1449fa1d
CY
39862012-02-06 Chong Yidong <cyd@gnu.org>
3987
3988 * doc.c (store_function_docstring): Avoid applying docstring of
3989 alias to base function (Bug#2603).
3990
3723ec07
AS
39912012-02-04 Andreas Schwab <schwab@linux-m68k.org>
3992
3993 * .gdbinit (pp1, pv1): Remove redundant defines.
3994 (pr): Use pp.
3995
79c1cc1e
CY
39962012-02-04 Chong Yidong <cyd@gnu.org>
3997
3998 * nsterm.m: Declare a global (Bug#10694).
3999
d7f29f8e
EZ
40002012-02-04 Eli Zaretskii <eliz@gnu.org>
4001
cae07000
SM
4002 * w32.c (get_emacs_configuration_options):
4003 Include --enable-checking, if specified, in the return value.
d7f29f8e 4004
3b95a6f9
MR
40052012-02-04 Martin Rudalics <rudalics@gmx.at>
4006
4007 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
4008 after rounding frame sizes. (Bug#9723)
4009
d6fa96a6
EZ
40102012-02-04 Eli Zaretskii <eliz@gnu.org>
4011
4012 * keyboard.c (adjust_point_for_property): Don't position point
4013 before BEGV. (Bug#10696)
4014
df0b2940
PE
40152012-02-03 Paul Eggert <eggert@cs.ucla.edu>
4016
4017 Handle overflow when computing char display width (Bug#9496).
4018 * character.c (char_width): Return EMACS_INT, not int.
4019 (char_width, c_string_width): Check for overflow when
4020 computing the width; this is possible now that individual
4021 characters can have unbounded width. Problem introduced
4022 by merge from Emacs 23 on 2012-01-19.
4023
6bee44d6
MA
40242012-02-02 Michael Albinus <michael.albinus@gmx.de>
4025
4026 * dbusbind.c (Fdbus_register_method): Mention the return value
4027 :ignore in the docstring.
4028
44f92739
GM
40292012-02-02 Glenn Morris <rgm@gnu.org>
4030
1b9f60cc
GM
4031 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
4032
44f92739
GM
4033 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4034 Unconditionally set to t. (Bug#10673)
4035 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
4036 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
4037 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
4038
c5d3843c
KH
40392012-02-02 Kenichi Handa <handa@m17n.org>
4040
4041 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
4042 0, do not call append_composite_glyph.
4043
159462d4 40442012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
4045
4046 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
4047 NULL (Bug#6988).
4048 (x_produce_glyphs): If the component of a composition is a null
4049 string, set it->pixel_width to 1 to avoid zero-width glyph.
4050
78cef877
EZ
40512012-02-01 Eli Zaretskii <eliz@gnu.org>
4052
4053 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
4054 first 2 arguments are identical. This makes inserting large
4055 output from a subprocess an order of magnitude faster on
4056 MS-Windows, where all sbrk'ed memory is always contiguous.
4057
97897668
GM
40582012-01-31 Glenn Morris <rgm@gnu.org>
4059
4060 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 4061 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
4062 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
4063
31fd3586
GM
40642012-01-29 Glenn Morris <rgm@gnu.org>
4065
4066 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
4067
0e24a8b2
CY
40682012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
4069
4070 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
4071
cc0adcb0
CY
40722012-01-28 Chong Yidong <cyd@gnu.org>
4073
4074 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
4075
acc28cb9
CY
40762012-01-26 Chong Yidong <cyd@gnu.org>
4077
9c69cfb7
CY
4078 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
4079
acc28cb9
CY
4080 * search.c (Fsearch_forward, Fsearch_backward): Document negative
4081 repeat counts (Bug#10507).
4082
48da7392
GM
40832012-01-26 Glenn Morris <rgm@gnu.org>
4084
4085 * lread.c (syms_of_lread): Doc fix.
4086
14af5f7f
CY
40872012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
4088
4089 * coding.c (encode_designation_at_bol): Change return value to
4090 EMACS_INT.
4091
0b21c100
CY
40922012-01-25 Chong Yidong <cyd@gnu.org>
4093
4094 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
4095
3c2907f7
CY
40962012-01-21 Chong Yidong <cyd@gnu.org>
4097
4098 * floatfns.c (Fcopysign): Make the second argument non-optional,
4099 since nil is not allowed anyway.
4100
959ad23f
AS
41012012-01-21 Andreas Schwab <schwab@linux-m68k.org>
4102
4103 * process.c (read_process_output): Use p instead of XPROCESS (proc).
4104 (send_process): Likewise.
4105
34a02f46
MR
41062012-01-19 Martin Rudalics <rudalics@gmx.at>
4107
4108 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
4109 (Vwindow_persistent_parameters): Do not use Qstate.
4110 Rewrite doc-strings.
34a02f46 4111
1259009a 41122012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
4113
4114 * character.c (char_width): New function.
70d4fdf6
GM
4115 (Fchar_width, c_string_width, lisp_string_width):
4116 Use char_width (Bug#9496).
25ed9e61 4117
6a6ee00d
MR
41182012-01-16 Martin Rudalics <rudalics@gmx.at>
4119
4120 * window.c (Vwindow_persistent_parameters): New variable.
4121 (Fset_window_configuration, save_window_save): Handle persistent
4122 window parameters.
4123
c85efaf7
EZ
41242012-01-14 Eli Zaretskii <eliz@gnu.org>
4125
4126 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
4127 thrashing the stack of the thread. (Bug#9087)
4128
5944709e
PE
41292012-01-12 Paul Eggert <eggert@cs.ucla.edu>
4130
4131 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
4132
e71f5d99
EZ
41332012-01-11 Eli Zaretskii <eliz@gnu.org>
4134
4135 * xdisp.c (rows_from_pos_range): Handle the case where the
4136 highlight ends on a newline. (Bug#10464)
4137 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
4138 he end column for display of highlight that ends on a newline
4139 before a R2L line.
4140
ce316182
GM
41412012-01-11 Glenn Morris <rgm@gnu.org>
4142
4143 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
4144 from load-path also when installation-directory is nil. (Bug#10208)
4145
5b43da69
GM
41462012-01-10 Glenn Morris <rgm@gnu.org>
4147
74cc8ff9
GM
4148 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
4149
7d8d6e4e
GM
4150 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
4151 Update template values to be closer to their typical values these days.
5b43da69 4152
a0db8d43
EZ
41532012-01-09 Eli Zaretskii <eliz@gnu.org>
4154
4155 * xdisp.c (rows_from_pos_range): Accept additional argument
4156 DISP_STRING, and accept any glyph in a row whose object is that
4157 string as eligible for mouse highlight. Fixes mouse highlight of
4158 display strings from overlays. (Bug#10464)
4159
9a0115ab 41602012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 4161
b9110d6a 4162 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
4163 * fileio.c (auto_saving_dir_umask): New static var.
4164 (Fmake_directory_internal): Use it.
4165 (do_auto_save_make_dir): Set it, instead of invoking chmod after
4166 creating the directory. The old code temporarily assigns
4167 too-generous permissions to the directory.
4168 (do_auto_save_eh): Clear it.
b9110d6a 4169 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
4170 that the var is always cleared.
4171
6c1bd3f3
EZ
41722012-01-07 Eli Zaretskii <eliz@gnu.org>
4173
4174 * search.c (scan_buffer): Pass character positions to
4175 know_region_cache, not byte positions. (Bug#6540)
4176
069d2b50
L
41772012-01-07 LynX <_LynX@bk.ru> (tiny change)
4178
4179 * w32.c (sys_rename): Report EXDEV when rename of a directory
4180 fails because the target is on another logical disk. (Bug#10284)
4181
75bf0d33
DB
41822012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
4183
4184 * xterm.c (x_embed_request_focus): New function.
4185
4186 * xterm.h: Add prototype.
4187
4188 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
4189
1c6e5a32
GM
41902012-01-05 Glenn Morris <rgm@gnu.org>
4191
4192 * emacs.c (emacs_copyright): Update short copyright year to 2012.
4193
651e947e
EZ
41942012-01-01 Eli Zaretskii <eliz@gnu.org>
4195
4196 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
4197 Load gnutls_transport_set_lowat only if GnuTLS version is below
4198 2.11.1.
4199 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
4200 GnuTLS versions below 2.11.1.
4201
3778cdd8
AL
42022011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
4203
4204 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
4205 to the doc string advising against its use for altering the way
4206 windows are scrolled.
4207
0e5317f7
KH
42082011-12-28 Kenichi Handa <handa@m17n.org>
4209
4210 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4211 coding-system ASCII compatible only when it does not produce BOM
4212 on encoding (Bug#10383).
4213
93d5ca1f
JD
42142011-12-26 Jan Djärv <jan.h.d@swipnet.se>
4215
4216 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
4217 can scroll.
4218 (create_and_show_popup_menu): Always use menu_position_func for
4219 Gtk3 (Bug#10361).
4220
ca22b785
AS
42212011-12-24 Andreas Schwab <schwab@linux-m68k.org>
4222
4223 * callint.c (Fcall_interactively): Don't truncate prompt string.
4224
d048e1e6
EZ
42252011-12-23 Eli Zaretskii <eliz@gnu.org>
4226
4227 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
4228 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 4229 resumed from there (after widening). (Bug#10360)
d048e1e6 4230
5ccaba1f
JD
42312011-12-22 Jan Djärv <jan.h.d@swipnet.se>
4232
4233 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
4234
204ee57f
JD
42352011-12-21 Jan Djärv <jan.h.d@swipnet.se>
4236
b81d40f0
JB
4237 * nsterm.m (x_free_frame_resources):
4238 Release f->output_data.ns->miniimage.
204ee57f
JD
4239 (ns_index_color): Fix indentation. Do not retain
4240 color_table->colors[i].
4241
4242 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
4243 before returning.
4244
4245 * nsfns.m (x_set_background_color): Assign return value from
4246 ns_index_color to face-background instead of NSColor*.
4247 (ns_implicitly_set_icon_type): Fix indentation.
4248 Change assignment in for loop to comparison.
4249
4250 * emacs.c (ns_pool): New variable.
4251 (main): Assign ns_pool.
4252 (Fkill_emacs): Call ns_release_autorelease_pool.
4253
4254 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
4255 autorelease fdesc, release fdAttrs and tdict.
4256 (ns_get_covering_families): Release charset.
4257 (ns_findfonts): Release NSFontDescriptor created with new.
4258 (ns_uni_to_glyphs): Fix indentation.
4259 (setString): Release attrStr before assigning new value.
4260
c803b2b7
JD
42612011-12-18 Jan Djärv <jan.h.d@swipnet.se>
4262
678f4426
JD
4263 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
4264 and NS_IMPL_COCOA.
4265 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
4266 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
4267
cd394be1 42682011-12-18 David Reitter <reitter@cmu.edu>
678f4426 4269
5fecd5fc
JD
4270 * nsterm.m (ns_term_init): Subscribe for notifications
4271 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
4272 to method trackingNotification in EmacsMenu.
4273
4274 * nsmenu.m (trackingMenu): New variable.
3771cb17 4275 (trackingNotification): New method (from Aquamacs).
5fecd5fc 4276 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 4277 from Aquamacs (Bug#7030).
678f4426
JD
4278
42792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 4280
c803b2b7
JD
4281 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
4282 (symbol_to_nsstring): Fix indentation.
4283 (ns_symbol_to_pb): New function.
cae07000
SM
4284 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
4285 (Fns_rotate_cut_buffers_internal): Remove.
4286 (Fns_store_selection_internal): Rename from
c803b2b7
JD
4287 Fns_store_cut_buffer_internal.
4288 (ns_get_foreign_selection, Fx_own_selection_internal)
4289 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
4290 (Fns_get_selection_internal, Fns_store_selection_internal):
4291 Use ns_symbol_to_pb and check if return value is nil.
4292 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
4293 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
4294 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
4295 renamed to Sns_store_selection_internal.
4296 (ns_handle_selection_request): Move code to Fx_own_selection_internal
4297 and remove this function.
4298 (ns_handle_selection_clear): Remove, never used.
4299 (Fx_own_selection_internal): Move code from ns_handle_selection_request
4300 here.
4301
e1b01a3a
KB
43022011-12-17 Ken Brown <kbrown@cornell.edu>
4303
4304 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
4305 GID is unknown (Bug#10257).
4306
2adb6e85
PE
43072011-12-17 Paul Eggert <eggert@cs.ucla.edu>
4308
4309 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
4310 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
4311 which caused a build failure on GNU/Linux IA-64. This problem was
4312 introduced by my 2011-10-07 patch.
4313
d1d7b339
JL
43142011-12-15 Juri Linkov <juri@jurta.org>
4315
4316 * image.c (imagemagick_error): New function. (Bug#10112)
4317 (imagemagick_load_image): Comment out `MagickSetResolution' call.
4318 Use `imagemagick_error' where ImageMagick functions return
4319 `MagickFalse'.
4320 (Fimagemagick_types): Add `Fnreverse' to return the list in the
4321 proper order.
4322
100d5755
KH
43232011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4324
4325 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
4326 fill background (Bug#8992).
4327
454592a6
MR
43282011-12-13 Martin Rudalics <rudalics@gmx.at>
4329
4330 * window.c (Vwindow_combination_resize)
4331 (Vwindow_combination_limit): Use t instead of non-nil in
4332 doc-strings.
61d4b438
MR
4333 (Vrecenter_redisplay): Add first sentence of doc-string on
4334 separate line.
53524d93 4335 (Frecenter): Fix doc-string typo.
454592a6 4336
3633e3aa
KH
43372011-12-11 Kenichi Handa <handa@m17n.org>
4338
4339 * coding.c (Funencodable_char_position): Pay attention to the
4340 buffer text relocation (Bug#9389).
4341
7b9d523a 43422011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 4343
7b9d523a
JD
4344 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
4345 gtk_init (Bug#10100).
4346
b73189c6
EZ
43472011-12-10 Eli Zaretskii <eliz@gnu.org>
4348
4349 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
4350 IT->string is nil. (Bug#10263)
4351
f7dfe5d6
JD
43522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
4353
83faebb4
JD
4354 * nsterm.h (x_free_frame_resources): Declare.
4355
f7dfe5d6
JD
4356 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
4357 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
4358
4359 * nsterm.h (ns_get_defaults_value): Declare.
4360
4361 * nsterm.m (ns_default): Call ns_get_defaults_value.
4362
7cd4e72c
EZ
43632011-12-09 Eli Zaretskii <eliz@gnu.org>
4364
4365 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
4366 (Bug#10170)
4367
b34d7317
YM
43682011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4369
4370 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
4371 that where the value of an _OBJC_* symbol points to is in the .bss
4372 section (Bug#10240).
4373
76470ad1
KH
43742011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4375
4376 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 4377 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 4378
745fff94
KH
43792011-12-08 Kenichi Handa <handa@m17n.org>
4380
4381 * ftfont.c (get_adstyle_property): Fix previous change
4382 (Bug#10233).
4383
6e44397c
JB
43842011-12-07 Juanma Barranquero <lekktu@gmail.com>
4385
4386 * w32.c (init_environment): If no_site_lisp, remove site-lisp
4387 dirs from the default value of EMACSLOADPATH (bug#10208).
4388
7efa6272
GM
43892011-12-07 Glenn Morris <rgm@gnu.org>
4390
4391 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
4392 installation and source directories as well. (Bug#10208)
4393
f6fc4d87
CY
43942011-12-06 Chong Yidong <cyd@gnu.org>
4395
4396 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
4397
2bf26180
GM
43982011-12-06 Glenn Morris <rgm@gnu.org>
4399
4400 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
4401 as an error, not just -1. (Bug#10217)
4402
3a6ad4f0
CY
44032011-12-05 Chong Yidong <cyd@gnu.org>
4404
4405 * keyboard.c (process_special_events): New function.
4406 (swallow_events, Finput_pending_p): Use it (Bug#10195).
4407
75a3b399
PE
44082011-12-05 Paul Eggert <eggert@cs.ucla.edu>
4409
4410 * coding.c (encode_designation_at_bol): Don't use uninitialized
4411 local variable (Bug#9318).
4412
c3c9e25e
KH
44132011-12-05 Kenichi Handa <handa@m17n.org>
4414
4415 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
4416 return Qnil (Bug#8046, Bug#10193).
4417
5eb05ea3
KH
44182011-12-05 Kenichi Handa <handa@m17n.org>
4419
4420 * coding.c (encode_designation_at_bol): New args charbuf_end and
4421 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
4422 (coding_set_source): Return how many bytes coding->source was
4423 relocated.
4424 (coding_set_destination): Return how many bytes
4425 coding->destination was relocated.
4426 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 4427 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
4428
44292011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4430
4431 * coding.c (CODING_CHAR_CHARSET_P): New macro.
4432 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
4433 macro (Bug#9318).
4434
44352011-12-05 Andreas Schwab <schwab@linux-m68k.org>
4436
4437 The following changes are to fix Bug#9318.
4438
a79703f5 4439 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
4440 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
4441 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 4442 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 4443
7dbda6df
JB
44442011-12-05 Juanma Barranquero <lekktu@gmail.com>
4445
4446 * lisp.h (process_quit_flag): Fix external declaration.
4447
6d5eb5b0
SM
44482011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
4449
4450 Don't macro-inline non-performance-critical code.
4451 * eval.c (process_quit_flag): New function.
4452 * lisp.h (QUIT): Use it.
4453
a0c3fad0
JD
44542011-12-04 Jan Djärv <jan.h.d@swipnet.se>
4455
4456 * nsfns.m (get_geometry_from_preferences): New function.
4457 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
4458
6c07aac2
AS
44592011-12-04 Andreas Schwab <schwab@linux-m68k.org>
4460
4461 * emacs.c (Qkill_emacs): Define.
4462 (syms_of_emacs): Initialize it.
4463 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
4464 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
4465 (quit_throw_to_read_char): Add parameter `from_signal'.
4466 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
4467 * lisp.h (QUIT): Call Fkill_emacs if requested.
4468
c052ead4
JD
44692011-12-03 Jan Djärv <jan.h.d@swipnet.se>
4470
4471 * widget.c (update_wm_hints): Return if wmshell is null.
4472 (widget_update_wm_size_hints): New function.
4473
4474 * widget.h (widget_update_wm_size_hints): Declare.
4475
4476 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
4477 widget_update_wm_size_hints (Bug#10104).
4478
9e49252b
EZ
44792011-12-03 Eli Zaretskii <eliz@gnu.org>
4480
4481 * xdisp.c (handle_invisible_prop): If the invisible text ends just
4482 before a newline, prepare the bidi iterator for consuming the
4483 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 4484 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 4485
02b16839
JL
44862011-12-02 Juri Linkov <juri@jurta.org>
4487
4488 * search.c (Fword_search_regexp): New Lisp function created from
4489 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
4490 (Fword_search_backward, Fword_search_forward)
4491 (Fword_search_backward_lax, Fword_search_forward_lax):
4492 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
4493 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
4494
0068070e
SM
44952011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
4496
4497 * fileio.c (Finsert_file_contents): Move after-change-function call
4498 to before the "handled:" label, since all "goto handled" appear in
4499 cases where the *-change-functions have already been properly called
4500 (bug#10117).
4501
3360a3fc
AS
45022011-12-01 Andreas Schwab <schwab@linux-m68k.org>
4503
4504 * keyboard.c (interrupt_signal): Don't call kill-emacs when
4505 waiting for input. (Bug#10169)
4506
73d6c093
EZ
45072011-11-30 Eli Zaretskii <eliz@gnu.org>
4508
4509 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
4510 verifies glyph row's hash code--we have just reallocated the
4511 glyphs, so their contents can be complete garbage. (Bug#10164)
4512
febe6bea
JB
45132011-11-30 Juanma Barranquero <lekktu@gmail.com>
4514
4515 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
4516
801a4313
EZ
45172011-11-30 Eli Zaretskii <eliz@gnu.org>
4518
4519 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
4520 attributes are tested _before_ calling verify_row_hash, to protect
4521 against GCC re-ordering of the tests. (Bug#10164)
4522
2b56b87e
JD
45232011-11-29 Jan Djärv <jan.h.d@swipnet.se>
4524
4525 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
4526
4527 * xterm.c (handle_one_xevent): Only set async_visible and friends
4528 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 4529 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
4530 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
4531
dbf31225
PE
45322011-11-28 Paul Eggert <eggert@cs.ucla.edu>
4533
4534 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4535 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
4536 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
4537 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4538 All uses changed to use GCPRO1 etc.
4539 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
4540 Revert to old implementation (i.e., before 2011-03-11).
4541
1305621b
YM
45422011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4543
4544 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
4545 of scroll runs so as to avoid assigning disabled bogus rows and
4546 unnecessary graphics copy operations.
4547
8c9afb46
EZ
45482011-11-27 Eli Zaretskii <eliz@gnu.org>
4549
4550 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
4551 (snprintf) [_MSC_VER]: Redirect to _snprintf.
4552 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
4553 (malloc, free, realloc, calloc): Redirect to e_* only when
4554 compiling Emacs.
4555
4556 * lisp.h (GCTYPEBITS): Move before first use.
4557 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
4558 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
4559 this macro definition.
4560
4561 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
4562 _MSC_VER.
4563
54e9e3bf
JD
45642011-11-27 Jan Djärv <jan.h.d@swipnet.se>
4565
6d5eb5b0
SM
4566 * gtkutil.c (xg_create_frame_widgets):
4567 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
4568 present with Gtk+ 2.0.
4569
83aca1cb
PE
45702011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4571
4572 * fileio.c (Finsert_file_contents): Undo previous change; see
4573 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
4574
5b76caa4
PE
45752011-11-26 Paul Eggert <eggert@cs.ucla.edu>
4576
4577 Rename locals to avoid shadowing.
4578 * fileio.c (Finsert_file_contents):
4579 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
4580 * process.c (wait_reading_process_output):
4581 Rename inner 'proc' to 'p' to avoid shadowing.
4582 Indent for consistency with usual Emacs style.
4583
8c535114
EZ
45842011-11-25 Eli Zaretskii <eliz@gnu.org>
4585
4586 * xdisp.c (redisplay_window): If cursor row is not fully visible
4587 after recentering, and scroll-conservatively is set to a large
4588 number, scroll window by a few more lines to make the cursor fully
4589 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
4590 (start_display): Don't move to the next line if the display should
4591 start at a newline that is part of a display vector or an overlay
4592 string. (Bug#10119)
8c535114 4593
fa4fdb5c
JL
45942011-11-24 Juri Linkov <juri@jurta.org>
4595
4596 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
4597 after the `MagickPingImage' call. (Bug#10112)
4598
90ec88df
CY
45992011-11-23 Chong Yidong <cyd@gnu.org>
4600
4601 * window.c (Fcoordinates_in_window_p): Accept only live windows.
4602
56e2e794
MR
46032011-11-23 Martin Rudalics <rudalics@gmx.at>
4604
4605 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
4606 making another buffer current. (Bug#10114)
4607
b6e64c41
GM
46082011-11-23 Glenn Morris <rgm@gnu.org>
4609
4610 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
4611
6b21de18
CY
46122011-11-23 Chong Yidong <cyd@gnu.org>
4613
4614 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
4615 using it (Bug#5984).
4616
b12cd789
EZ
46172011-11-22 Eli Zaretskii <eliz@gnu.org>
4618
4619 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
4620 and header-lines, as they don't have one computed for them.
4621 (Bug#10098)
4622
4623 * .gdbinit (prow): Make displayed values more self-explaining.
4624 Add row's hash code.
4625
261b6fd4
LMI
46262011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
4627
4628 * process.c (wait_reading_process_output): Fix asynchrounous
4629 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 4630 (wait_reading_process_output): Add comment and URL.
261b6fd4 4631
e7cfd277
JD
46322011-11-21 Jan Djärv <jan.h.d@swipnet.se>
4633
4634 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
4635
a9b9b7f5
CY
46362011-11-21 Chong Yidong <cyd@gnu.org>
4637
4638 * window.c (Fnext_window, Fprevious_window): Doc fix.
4639
b0d15b4f
SM
46402011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4641
4642 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
4643
fe7a3057
JB
46442011-11-20 Juanma Barranquero <lekktu@gmail.com>
4645
4646 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
4647
d2999b1a
MR
46482011-11-20 Martin Rudalics <rudalics@gmx.at>
4649
4650 * window.c (Fset_window_combination_limit): Rename argument
4651 STATUS to LIMIT.
4652 (Vwindow_combination_limit): Remove "status" from doc-string.
4653
d5ff9cd0
AS
46542011-11-20 Andreas Schwab <schwab@linux-m68k.org>
4655
4656 * m/ibms390.h: Remove.
4657 * m/ibms390x.h: Don't include "ibms390.h".
4658
a5bb9bd3
SM
46592011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
4660
4661 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
4662 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
4663
cd1181db
JB
46642011-11-20 Juanma Barranquero <lekktu@gmail.com>
4665
4666 * casetab.c (Fset_case_table):
4667 * charset.c (Fcharset_after): Fix typos.
4668
615a3b8d 46692011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 4670
17e845af
PE
4671 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
4672 Otherwise, valgrind does not work on some platforms.
4673 Problem reported by Andreas Schwab in
6a0bf43d
PE
4674 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
4675 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
4676 is set, removing the need for VIRT_ADDRESS_VARIES.
4677 (PURE_P): Use a more-efficient implementation that needs just one
4678 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
4679 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
4680 to 4 (xorl, subq, cmpq, setbe).
4681 * alloc.c (pure): Always extern now, since that's the
4682 VIRT_ADDR_VARIES behavior.
4683 (PURE_POINTER_P): Use a single comparison, not two, for
4684 consistency with the new puresize.h.
4685 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
4686 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
4687 Remove VIRT_ADDR_VARIES no longer needed.
4688
f8fe6f96
EZ
46892011-11-19 Eli Zaretskii <eliz@gnu.org>
4690
4691 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
4692 (erase_phys_cursor, update_window_cursor, show_mouse_face)
4693 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
4694 behave as if the cursor position were at the window margin.
4695
4696 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
4697 and the cursor position is out of bounds, behave as if the cursor
4698 position were at the window margin. (Bug#10075)
4699
df05a53c
CY
47002011-11-18 Chong Yidong <cyd@gnu.org>
4701
4702 * window.c (Fwindow_combination_limit): Make first argument
4703 non-optional, since it is meaningless for live windows like the
4704 selected window.
61ccba97 4705
2071918e
DA
47062011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
4707
4708 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
4709
b50a28de
SM
47102011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
4711
4712 * intervals.c: Fix grafting over the whole buffer (bug#10071).
4713 (graft_intervals_into_buffer): Simplify.
4714
015137db
EZ
47152011-11-18 Eli Zaretskii <eliz@gnu.org>
4716
4717 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
4718 hash values of the two rows.
4719 (copy_row_except_pointers): Preserve the used[] arrays and the
4720 hash values of the two rows. (Bug#10035)
68c95424 4721 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
4722
4723 * xdisp.c (row_hash): New function, body extracted from
4724 compute_line_metrics.
4725 (compute_line_metrics): Call row_hash, instead of computing the
4726 hash code inline.
4727
4728 * dispnew.c (verify_row_hash): Call row_hash for computing the
4729 hash code of a row, instead of duplicating code from xdisp.c.
4730
4731 * dispextern.h (row_hash): Add prototype.
4732
a2addb04
TH
47332011-11-18 Tassilo Horn <tassilo@member.fsf.org>
4734
4735 * frame.c (delete_frame): Don't delete the terminal when the last
4736 X frame is closed if emacs is built with GTK toolkit.
4737
df85d315
JB
47382011-11-17 Juanma Barranquero <lekktu@gmail.com>
4739
4740 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
4741
a0c2d0ae
MR
47422011-11-17 Martin Rudalics <rudalics@gmx.at>
4743
4744 * window.c (Vwindow_splits): Rename to
4745 Vwindow_combination_resize. Suggested by Juri Linkov.
4746 (Fsplit_window_internal): Use Vwindow_combination_resize instead
4747 of Vwindow_splits.
4748
58179cce
JB
47492011-11-16 Juanma Barranquero <lekktu@gmail.com>
4750
7877f373
JB
4751 * nsfns.m (Fns_font_name):
4752 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 4753
b6f67890
MR
47542011-11-16 Martin Rudalics <rudalics@gmx.at>
4755
4756 * window.h (window): Rename slot "nest" to "combination_limit".
4757 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
4758 (Fset_window_nest): Rename to Fset_window_combination_limit.
4759 (Vwindow_nest): Rename to Vwindow_combination_limit.
4760 (recombine_windows, make_parent_window, make_window)
4761 (Fsplit_window_internal, saved_window)
4762 (Fset_window_configuration, save_window_save): Rename all
4763 occurrences of window_nest to window_combination_limit.
4764
c7015153
JB
47652011-11-15 Juanma Barranquero <lekktu@gmail.com>
4766
4767 * image.c (imagemagick_load_image): Fix typo.
4768
322ad6ec
EZ
47692011-11-14 Eli Zaretskii <eliz@gnu.org>
4770
4771 * xdisp.c (display_line): Move the call to
4772 highlight_trailing_whitespace before the call to
4773 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
4774 faces of all the glyphs to compute ROW's hash value.
4775 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 4776
f067b8ec
JB
47772011-11-14 Juanma Barranquero <lekktu@gmail.com>
4778
4779 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
4780 just return (bug#10044).
4781
1e5b2111
EZ
47822011-11-12 Eli Zaretskii <eliz@gnu.org>
4783
7ef3cbd5
EZ
4784 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
4785 with user-defined heap size. Bump the default size of the temacs
4786 heap to 27MB, to avoid memory warning when running temacs.
4787 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
4788
1e5b2111
EZ
4789 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
4790 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
4791 (verify_row_hash) [XASSERTS]: New function.
4792 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
4793 that the hash value of glyph rows is correct.
1e5b2111 4794
89d61221
MR
47952011-11-12 Martin Rudalics <rudalics@gmx.at>
4796
4797 * window.h (window): Remove splits slot.
4798 * window.c (Fwindow_splits, Fset_window_splits): Remove.
4799 (Fdelete_other_windows_internal, make_parent_window)
4800 (make_window, Fsplit_window_internal, Fdelete_window_internal)
4801 (Fset_window_configuration, save_window_save): Don't deal with
4802 split status of windows.
4803 (saved_window): Remove splits slot.
4804 (Vwindow_splits): Rewrite doc-string.
4805
97f18cc8
JD
48062011-11-11 Jan Djärv <jan.h.d@swipnet.se>
4807
4808 * xfns.c (unwind_create_frame):
4809 * nsfns.m (unwind_create_frame):
4810 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
4811 Vframe_list (Bug#9999).
4812
22a648b4
DA
48132011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
4814
0b381c7e 4815 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 4816
659afede
KH
48172011-11-11 Kenichi Handa <handa@m17n.org>
4818
4819 * callproc.c (Fcall_process): Set the member dst_multibyte of
4820 process_coding.
4821
9ac0394b
KH
48222011-11-11 Johan Bockgård <bojohan@gnu.org>
4823
4824 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
4825 avoid a crash (bug#9496).
4826
2fbdc249
CY
48272011-11-09 Chong Yidong <cyd@gnu.org>
4828
4829 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
4830 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
4831
ac6b1f81
PE
48322011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4833
4834 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
4835
09db192c
PE
48362011-11-08 Paul Eggert <eggert@cs.ucla.edu>
4837
4838 Avoid some portability problems by eschewing 'extern inline' functions.
4839 The trivial performance wins aren't worth the portability hassles; see
4840 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
4841 et seq.
4842 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4843 (window_box_width, window_box_left, window_box_left_offset)
4844 (window_box_right, window_box_right_offset): Undo previous change,
4845 by removing the "extern"s.
4846 * intervals.c (adjust_intervals_for_insertion)
4847 (adjust_intervals_for_deletion): Undo previous change,
4848 making these static again.
4849 (offset_intervals, temp_set_point_both, temp_set_point)
4850 (copy_intervals_to_string): No longer inline.
4851 * xdisp.c (window_text_bottom_y, window_box_width)
4852 (window_box_height, window_box_left_offset)
4853 (window_box_right_offset, window_box_left, window_box_right)
4854 (window_box): No longer inline.
4855
105216ed
CY
48562011-11-08 Chong Yidong <cyd@gnu.org>
4857
4858 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
4859 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
4860 Signal an error if not a live window.
105216ed
CY
4861 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
4862 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
4863
ae9e237f
JB
48642011-11-07 Juanma Barranquero <lekktu@gmail.com>
4865
4866 * lisp.h (syms_of_abbrev): Remove declaration.
4867 Reported by CHENG Gao <chenggao@royau.me>.
4868
c7aa8333
EZ
48692011-11-07 Eli Zaretskii <eliz@gnu.org>
4870
4871 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
4872 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
4873 of temacs in GUI mode.
4874
be7f5545
MR
48752011-11-07 Martin Rudalics <rudalics@gmx.at>
4876
4877 * window.h: Declare delete_all_child_windows instead of
4878 delete_all_subwindows.
4879 * window.c (Fwindow_nest, Fset_window_nest)
4880 (Fset_window_new_total, Fset_window_new_normal)
4881 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
4882 (delete_all_subwindows): Rename to delete_all_child_windows.
4883 (Fdelete_other_windows_internal, Fset_window_configuration):
4884 Call delete_all_child_windows instead of delete_all_subwindows.
4885 * frame.c (delete_frame): Call delete_all_child_windows instead
4886 of delete_all_subwindows.
4887
ca78dc43
PE
48882011-11-07 Paul Eggert <eggert@cs.ucla.edu>
4889
4890 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
4891 This is also needed for porting to any host where GC_MARK_STACK is
4892 not GC_MAKE_GCPROS_NOOPS.
4893 (which_symbols): Use it.
4894
a0241d01
KH
48952011-11-07 Kenichi Handa <handa@m17n.org>
4896
4897 * coding.c (coding_set_destination): Check coding->src_pos only
4898 when coding->src_object is a buffer (bug#9910).
4899
4900 * process.c (send_process): Set the member src_multibyte of coding
4901 to 0 (bug#9911) when sending a unibyte text.
4902
4903 * callproc.c (Fcall_process): Set the member src_multibyte of
4904 process_coding to 0 (bug#9912).
4905
a64bfdfa 49062011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
4907
4908 * xmenu.c (cleanup_widget_value_tree): New function.
4909 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
4910 calling free_menubar_widget_value_tree directly (Bug#9830).
4911
cb41b32a
PE
49122011-11-06 Paul Eggert <eggert@cs.ucla.edu>
4913
4914 Fix some portability problems with 'inline'.
4915 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
4916 (window_box_width, window_box_left, window_box_left_offset)
4917 (window_box_right, window_box_right_offset): Declare extern.
4918 Otherwise, these inline functions do not conform to C99 and
4919 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
4920 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
4921 * intervals.c (adjust_intervals_for_insertion)
4922 (adjust_intervals_for_deletion): Now extern, because otherwise the
4923 extern inline functions 'offset_intervals' couldn't refer to it.
4924 (static_offset_intervals): Remove.
4925 (offset_intervals): Rewrite using the old contents of
4926 static_offset_intervals. The old version didn't conform to C99
4927 because an extern inline function contained a reference to an
4928 identifier with static linkage.
4929
b7041366
AS
49302011-11-06 Andreas Schwab <schwab@linux-m68k.org>
4931
4932 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
4933 GC.
4934
88a37c4d
EZ
49352011-11-06 Eli Zaretskii <eliz@gnu.org>
4936
4937 * xdisp.c (init_iterator, reseat_to_string): Don't set the
4938 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
4939 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
4940 return Qleft_to_right.
4941
49745b39
CY
49422011-11-06 Chong Yidong <cyd@gnu.org>
4943
4944 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
4945 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
4946 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
4947 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
4948 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
4949 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
4950 (Fwindow_vscroll): Doc fix.
4951 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
4952 argument, since it makes no sense to pass a live window and for
4953 consistency with window-child.
4954
1f05cd82
CS
49552011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
4956
4957 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
4958 support MSVC.
4959
22610910
JR
49602011-11-05 Jason Rumney <jasonr@gnu.org>
4961
4962 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
4963 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
4964 fonts (Bug#6029).
4965 (add_font_entity_to_list): Fix logic errors in mixed boolean and
4966 bitwise arithmetic preventing use of unicode-sip and non-truetype
4967 opentype fonts.
4968
a06776b2
EZ
49692011-11-05 Eli Zaretskii <eliz@gnu.org>
4970
3ad924ba
EZ
4971 * s/ms-w32.h (fstat, stat, utime): Move redirections to
4972 "emacs"-only part.
4973
a06776b2
EZ
4974 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
4975 initialization code to keep similarity to xfns.c after changes
4976 from 2011-11-05.
4977
c9e7db78
JD
49782011-11-05 Jan Djärv <jan.h.d@swipnet.se>
4979
a97f8f3f
JD
4980 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
4981 (unwind_create_frame): New function (Bug#9943).
4982 (Fx_create_frame): Restructure code to be more similar to the one in
4983 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
4984 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
4985 Move terminal->reference_count++ just before making the frame official
4986 (Bug#9943).
4987
4988 * nsterm.m (x_free_frame_resources): New function.
4989 (x_destroy_window): Move code to x_free_frame_resources.
4990
c9e7db78 4991 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
4992 (Fx_create_frame, x_create_tip_frame):
4993 Move terminal->reference_count++ just before making the frame
75f1671a 4994 official. Move initialization of image_cache_refcount and
c9e7db78
JD
4995 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
4996
a6fc3b5c
EZ
49972011-11-05 Eli Zaretskii <eliz@gnu.org>
4998
4999 Support MSVC build with newer versions of Visual Studio.
5000 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
5001 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
5002 nt/gmake.defs.
5003
5004 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
5005 which are not supported by MSVC.
5006 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
5007 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
5008 bitfields.
5009 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
5010 types in bitfields.
5011 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
5012
5013 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
5014
58179cce 50152011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
5016
5017 Support MSVC build with newer versions of Visual Studio.
5018 * w32.c: Don't include w32api.h for MSVC.
5019 (init_environment) [_MSC_VER]: Call sys_access, not _access.
5020
5021 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
5022 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
5023 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
5024 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
5025 e_* cousins.
5026 (alloca) [_MSC_VER]: Define to _alloca.
5027
5028 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
5029
5030 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
5031
a58c13ed
EZ
50322011-11-04 Eli Zaretskii <eliz@gnu.org>
5033
5034 * xdisp.c (note_mouse_highlight): If either of
5035 previous/next-single-property-change returns nil, treat that as
5036 the beginning or the end of the buffer. (Bug#9955)
5037
fe0b6370
JD
50382011-11-04 Jan Djärv <jan.h.d@swipnet.se>
5039
a58c13ed 5040 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
5041 label is not null (Bug#9951).
5042 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
5043 may be NULL.
5044
89bd5ee1
EZ
50452011-11-04 Eli Zaretskii <eliz@gnu.org>
5046
5047 * window.c (Fwindow_body_size): Mention in the doc string that the
5048 return value is in frame's canonical units. (Bug#9949)
5049
84c3edb9
EZ
50502011-11-03 Eli Zaretskii <eliz@gnu.org>
5051
4e2fb5c7
EZ
5052 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
5053
84c3edb9 5054 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 5055 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 5056 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 5057
bc17a887
EZ
50582011-11-01 Eli Zaretskii <eliz@gnu.org>
5059
5060 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
5061 Don't stop backward scan on the continuation glyph, even though
5062 its CHARPOS is positive.
6d5eb5b0
SM
5063 (mouse_face_from_buffer_pos, note_mouse_highlight):
5064 Rename cover_string to disp_string.
bc17a887 5065
4ee88440
MR
50662011-11-01 Martin Rudalics <rudalics@gmx.at>
5067
5068 * window.c (temp_output_buffer_show): Don't use
5069 Vtemp_buffer_show_specifiers.
5070 (Vtemp_buffer_show_specifiers): Remove unused variable.
5071
c2ff3c02
EZ
50722011-10-30 Eli Zaretskii <eliz@gnu.org>
5073
5074 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
5075 past the beginning of the current glyph matrix.
5076
58179cce 50772011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
5078
5079 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
5080 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
5081 HAVE_GTK3 (Bug#9869).
b77a6a7f 5082
3b574623
JD
5083 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
5084 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
5085
b77a6a7f
JD
5086 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
5087
5088 * xterm.c: Declare x_handle_net_wm_state to return int.
5089 (handle_one_xevent): Check if we are iconified but don't have
5090 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
5091 (get_current_wm_state): Return non-zero if not hidden,
5092 check for _NET_WM_STATE_HIDDEN (Bug#9893).
5093 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
5094 (x_handle_net_wm_state): Return what get_current_wm_state returns.
5095 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
5096
196e41e4
PE
50972011-10-29 Paul Eggert <eggert@cs.ucla.edu>
5098
5099 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
5100 so that this new function doesn't get optimized away by a
5101 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
5102
021f2e1a
AS
51032011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5104
5105 * frame.h (MOUSE_HL_INFO): Remove excess parens.
5106
8b058d44
EZ
51072011-10-29 Eli Zaretskii <eliz@gnu.org>
5108
5109 Fix the `xbytecode' command.
5110 * .gdbinit (xprintbytestr): New command.
b50a28de 5111 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
5112 (xbytecode): Print the byte-code string as well.
5113
4452fb80
EZ
51142011-10-29 Kim Storm <storm@cua.dk>
5115
8b058d44
EZ
5116 * alloc.c (which_symbols): New function.
5117
21b72067
AS
51182011-10-29 Andreas Schwab <schwab@linux-m68k.org>
5119
5120 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
5121 line. (Bug#9903)
5122
83ed7b5c
GM
51232011-10-29 Glenn Morris <rgm@gnu.org>
5124
5125 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
5126 Not clear what it was for, and it causes various bugs. (Bug#9839)
5127
5a7a728b
EZ
51282011-10-28 Eli Zaretskii <eliz@gnu.org>
5129
5130 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
5131 possible random value that matches one of those tested as
5132 condition to clear the mouse face.
5133
d3d0842f
CY
51342011-10-28 Chong Yidong <cyd@gnu.org>
5135
5136 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
5137
31b39d13
DN
51382011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
5139
5140 * window.c (make_window): Initialize phys_cursor_on_p.
5141
9aba6043
SM
51422011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
5143
5144 * lisp.h (struct Lisp_Symbol): Update comments.
5145
c20992f4
JB
51462011-10-28 Juanma Barranquero <lekktu@gmail.com>
5147
5148 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
5149
db4f02f2
EZ
51502011-10-28 Eli Zaretskii <eliz@gnu.org>
5151
5152 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
5153 <oslsachem@gmail.com> for helping to debug this.
5154
5155 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
5156 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
5157 (g_b_init_get_glyph_outline_w): New static variables.
5158 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
5159 (GetGlyphOutlineW_Proc): New typedefs.
5160 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
5161 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
5162 New functions.
5163 (w32font_open_internal, compute_metrics):
5164 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
5165 instead of calling the "wide" APIs directly.
5166
5167 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
5168
5169 * w32.h (syms_of_w32font): Add prototype.
5170
87e68db4
JB
51712011-10-27 Juanma Barranquero <lekktu@gmail.com>
5172
5173 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
5174 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
5175 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
5176 (Fmove_to_window_line): Doc fix.
5177
435c1d67
CY
51782011-10-27 Chong Yidong <cyd@gnu.org>
5179
5180 * process.c (make_process): Set gnutls_state to NULL.
5181
5182 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
5183 non-NULL, regardless of GNUTLS_INITSTAGE.
5184 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
5185 an error. Set process slots as soon as we allocate them.
5186
5187 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
5188
9c6c6f49
CY
51892011-10-27 Chong Yidong <cyd@gnu.org>
5190
9aba6043
SM
5191 * gnutls.c (emacs_gnutls_deinit): New function.
5192 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
5193 (Fgnutls_deinit, Fgnutls_boot): Use it.
5194
5195 * process.c (make_process): Initialize GnuTLS credentials to NULL.
5196 (deactivate_process): Call emacs_gnutls_deinit.
5197
657d08d3
JB
51982011-10-27 Juanma Barranquero <lekktu@gmail.com>
5199
5200 * image.c (x_create_x_image_and_pixmap):
5201 * w32.c (sys_rename, w32_delayed_load):
5202 * w32font.c (fill_in_logfont):
5203 * w32reg.c (x_get_string_resource): Silence compiler warnings.
5204
5430d399
JB
52052011-10-26 Juanma Barranquero <lekktu@gmail.com>
5206
5207 * w32fns.c (w32_default_color_map): New function,
5208 extracted from Fw32_default_color_map.
a7ef684b 5209 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 5210
fe0055fa
PE
52112011-10-25 Paul Eggert <eggert@cs.ucla.edu>
5212
5213 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
5214
e6346438
SM
52152011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
5216
5217 * keyboard.c (test_undefined): New function (bug#9751).
5218 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
5219
e112cc37
ET
52202011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
5221
5222 * sysdep.c (init_sys_modes): Fix the check for the controlling
5223 terminal (Bug#6649).
5224
7b5d6677
EZ
52252011-10-20 Eli Zaretskii <eliz@gnu.org>
5226
5227 * dispextern.h (struct bidi_it): New member next_en_type.
5228
5229 * bidi.c (bidi_line_init): Initialize the next_en_type member.
5230 (bidi_resolve_explicit_1): When next_en_pos is valid for the
5231 current character, check also for next_en_type being WEAK_EN.
5232 (bidi_resolve_weak): Don't enter the expensive loop if the current
5233 position is before next_en_pos. Record the bidi type of the first
5234 non-ET, non-BN character we find, in addition to its position.
5235 (bidi_level_of_next_char): Invalidate next_en_type when
5236 next_en_pos is over-stepped.
5237
7da0b018
PE
52382011-10-20 Paul Eggert <eggert@cs.ucla.edu>
5239
5240 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
5241 * editfns.c: Rewrite current-time-zone so that it invokes
5242 the equivalent of (format-time-string "%Z") to get the time zone name.
5243 This fixes a bug when the time zone name contains characters that
5244 need converting from the system time locale to Emacs internal format.
5245 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
5246 that patch fixed format-time-string to do the conversion, but
5247 I forgot to fix current-time-zone.
5248 (format_time_string): New function, containing most of
5249 what Fformat_time_string used to contain.
5250 (Fformat_time_string): Rewrite in terms of format_time_string.
5251 This doesn't change this function's behavior.
5252 (current-time-zone): Rewrite to use format_time_string.
5253 This fixes the bug reported by Michael Schierl in
5254 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
5255 Jason Rumney's 2007-06-07 change worked around this bug, but
5256 didn't fix it.
5257 * systime.h (tzname, timezone): Remove no-longer-used declarations.
5258
8547b010
EZ
52592011-10-19 Eli Zaretskii <eliz@gnu.org>
5260
5261 * xdisp.c (start_display): If the character at POS is displayed
5262 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
5263 (try_window_reusing_current_matrix): If a line ends in a display
5264 vector or the next line starts in a display vector, continue
5265 redrawing the window even though the character position of
5266 start_row was reached.
8547b010
EZ
5267 (Bug#9771, part 2)
5268
4e948d15
CY
52692011-10-18 Chong Yidong <cyd@gnu.org>
5270
5271 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
5272 with nobreak-char-display too.
5273
4787455f
EZ
52742011-10-18 Eli Zaretskii <eliz@gnu.org>
5275
5276 Fix part 3 of bug#9771.
5277 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
5278 (bidi_resolve_neutral): Don't enter the expensive loop looking for
5279 non-neutral characters if the current character is a paragraph
5280 separator (a.k.a. Newline). This avoids running the same
5281 expensive loop twice, once when we consume the preceding newline
5282 and the other time when the line actually needs to be displayed.
5283 Avoid the loop when we see neutrals on the base embedding level
5284 following a character whose directionality is the same as the
5285 paragraph's. This avoids running the expensive loop when a line
5286 ends in a long sequence of neutrals, like control characters.
5287 Add assertion against STRONG_AL type. Slightly rearrange code
5288 that determines the type of a neutral given the first non-neutral
5289 that follows it.
5290 (bidi_level_of_next_char): Set next_en_pos to zero when
5291 invalidating its info.
5292
2c91f553
EZ
52932011-10-17 Eli Zaretskii <eliz@gnu.org>
5294
5295 * xdisp.c (push_display_prop): Determine whether to record string
5296 or buffer position by IT->string, not by IT->method. Allow
5297 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
5298 (move_it_vertically_backward): Don't look for character position
5299 immediately after the newline when in a continuation line.
5300 (Bug#9771, part 1)
2c91f553 5301
c7b08b0d
MR
53022011-10-15 Martin Rudalics <rudalics@gmx.at>
5303
5304 * window.c (coordinates_in_window): Rewrite and delabelize
5305 vertical border check. (Bug#5357) (Bug#9618)
5306
6b02f655
SM
53072011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
5308
5309 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
5310 errors in XSetWindowBorder (bug#9310).
5311
81d40c92
DA
53122011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
5313
5314 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
5315 avoid crash when xmalloc overrun checking is enabled.
5316
d4172c3b
EZ
53172011-10-13 Eli Zaretskii <eliz@gnu.org>
5318
5319 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
5320 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
5321 cursor motion with <left> and <right> arrow keys.
5322
5323 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
5324 some callers set that themselves.
5325
b00eea75
EZ
53262011-10-12 Eli Zaretskii <eliz@gnu.org>
5327
5328 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
5329 display string and the previous row comes from the same string and
5330 is empty. (Bug#9739) (Bug#9738)
5331
8fe012c4
SM
53322011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
5333
5334 * doc.c (get_doc_string): Encode file name (bug#9735).
5335
0074aef2
EZ
53362011-10-12 Eli Zaretskii <eliz@gnu.org>
5337
79beb178
EZ
5338 * bidi.c (bidi_level_of_next_char):
5339 * xdisp.c (get_visually_first_element): Remove old incorrect
5340 comments regarding the Unicode Line Separator character.
5341
0074aef2
EZ
5342 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
5343
6e4b3fbe
DA
53442011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
5345
5346 * alloc.c (Fgc_status): Do not access beyond zombies array
5347 boundary if nzombies > MAX_ZOMBIES.
5348 * alloc.c (dump_zombies): Add missing format specifier.
5349
0324f3af
PE
53502011-10-12 Paul Eggert <eggert@cs.ucla.edu>
5351
b5525cac
PE
5352 * xdisp.c (set_cursor_from_row): Simplify conditionals,
5353 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
5354
0324f3af
PE
5355 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
5356 Some packages use them to denote characters with modifiers.
5357
e9b5f888
AS
53582011-10-11 Andreas Schwab <schwab@linux-m68k.org>
5359
5360 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
5361 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
5362 matching a pp-number. Rename parameter var to var1.
5363
127827c0
SM
53642011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
5365
5366 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
5367
c8fd3bd0
GM
53682011-10-08 Glenn Morris <rgm@gnu.org>
5369
5370 * callint.c (Fcall_interactively): Give a more explicit error for the
5371 'c' case with a non-character input. (Bug#8479)
5372
352ec8ff
EZ
53732011-10-08 Eli Zaretskii <eliz@gnu.org>
5374
03669ccb
EZ
5375 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
5376 lines.
7061c986
EZ
5377 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
5378 lines that are hscrolled on the left.
03669ccb 5379
352ec8ff
EZ
5380 * dispnew.c (buffer_posn_from_coords): Account for a possible
5381 presence of header-line. (Bug#4426)
5382
a66cfb1c
SM
53832011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
5384
6b02f655
SM
5385 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
5386 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 5387
7c5ee88e
PE
53882011-10-07 Paul Eggert <eggert@cs.ucla.edu>
5389
5390 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
5391 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
5392 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
5393 this makes Emacs dump core during garbage collection on rare
5394 occasions. sizeof is obviously inferior to offsetof here, so
5395 stick with offsetof.
5396 (GC_POINTER_ALIGNMENT): New macro.
5397 (mark_memory): Omit 3rd (offset) arg; caller changed.
5398 Don't assume EMACS_INT alignment is the same as pointer alignment.
5399
df1bbe5b
SM
54002011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
5401
5402 * keyboard.c (read_key_sequence_remapped): New var.
5403 (read_key_sequence): Compute remapping in the right buffer.
5404 (command_loop_1): Use read_key_sequence's remapping directly.
5405
51553db6
SM
54062011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
5407
32c1fffd
SM
5408 * dired.c (file_name_completion): Don't expand file name.
5409 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
5410 before checking file name handler.
5411
51553db6
SM
5412 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
5413 they've been requested explicitly (bug#9591).
5414
b6bd1599 54152011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
5416
5417 * keymap.c (Fsingle_key_description): Use make_specified_string
5418 instead of build_string to build string from push_key_description.
5419 (Bug#5193)
5420
f701dc2a
PE
54212011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5422
4222c55d
PE
5423 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
5424 This fixes a Y2038 bug on 64-bit hosts.
5425 * buffer.c (reset_buffer):
5426 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
5427 (Fclear_buffer_auto_save_failure):
5428 Use 0, not -1, to represent an unset failure time, since time_t
5429 might not be signed.
5430
f701dc2a
PE
5431 Remove dependency on glibc malloc internals.
5432 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5433 Move back here from lisp.h, but with their new implementations.
5434 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5435 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
5436 * charset.c (charset_table_init): New static var.
5437 (syms_of_charset): Use it instead of xmalloc. This removes a
5438 dependency on glibc malloc internals. See Eli Zaretskii's comment in
5439 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
5440 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5441 Move back to alloc.c.
5442 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5443 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
5444
9ceebf39
JD
54452011-09-30 Jan Djärv <jan.h.d@swipnet.se>
5446
5447 * nsterm.m (windowDidResize): Call x_set_window_size only when
5448 ns_in_resize is true. Otherwise set pixelwidth/height and
5449 call change_frame_size (Bug#9628).
5450
cb993c58
PE
54512011-09-30 Paul Eggert <eggert@cs.ucla.edu>
5452
3930c88b
PE
5453 Port --enable-checking=all to Fedora 14 x86-64.
5454 * charset.c (syms_of_charset): Also account for glibc malloc's
5455 internal overhead when calculating the initial malloc maximum.
5456
cb993c58
PE
5457 Port --enable-checking=all to Fedora 14 x86.
5458 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5459 Move to lisp.h.
5460 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
5461 (overrun_check_realloc, overrun_check_free):
5462 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
5463 That way, xmalloc returns a properly-aligned pointer even if
5464 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
5465 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
5466 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
5467 into account when calculating the initial malloc maximum.
5468 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
5469 Move here from alloc.c, so that charset.c can use it too.
5470 Properly align; the old code wasn't right for common 32-bit hosts
5471 when configured with --enable-checking=all.
5472 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
5473 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
5474
31bed486
EZ
54752011-09-29 Eli Zaretskii <eliz@gnu.org>
5476
04c70788 5477 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
5478 use EDOM.
5479
fbcaa2f3
EZ
54802011-09-28 Eli Zaretskii <eliz@gnu.org>
5481
5482 * xdisp.c (compute_display_string_end): If there's no display
5483 string at CHARPOS, return -1.
5484
5485 * bidi.c (bidi_fetch_char): When compute_display_string_end
5486 returns a negative value, treat the character as a normal
5487 character not covered by a display string. (Bug#9624)
5488
a239d4e9
JB
54892011-09-28 Juanma Barranquero <lekktu@gmail.com>
5490
5491 * lread.c (Fread_from_string): Fix typo in docstring.
5492
88652fd5
EZ
54932011-09-27 Eli Zaretskii <eliz@gnu.org>
5494
5495 * xdisp.c (handle_invisible_prop): If invisible text ends on a
5496 newline, reseat the iterator instead of bidi-iterating there one
5497 character at a time. (Bug#9610)
32c1fffd
SM
5498 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
5499 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 5500
ed497dd4
AS
55012011-09-27 Andreas Schwab <schwab@linux-m68k.org>
5502
5503 * lread.c (readevalloop): Use correct code for NBSP.
5504 (read1): Likewise. (Bug#9608)
5505
b2bf61aa
MA
55062011-09-25 Michael Albinus <michael.albinus@gmx.de>
5507
5508 * dbusbind.c (Fdbus_register_signal): When service is not
5509 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
5510
32bbb17c
GM
55112011-09-25 Glenn Morris <rgm@gnu.org>
5512
5513 * buffer.c (truncate-lines): Doc fix.
5514
94e0933e
CY
55152011-09-24 Chong Yidong <cyd@stupidchicken.com>
5516
5517 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
5518 (Fset_window_next_buffers): Doc fix.
5519
cddde921
GM
55202011-09-24 Glenn Morris <rgm@gnu.org>
5521
5522 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
5523
1260aef1
PE
55242011-09-24 Paul Eggert <eggert@cs.ucla.edu>
5525
25b4bfa0
PE
5526 Fix minor problems found by static checking.
5527 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
5528 * indent.c (Fvertical_motion): Fix == vs = typo.
5529
e3cbd34b
EZ
55302011-09-24 Eli Zaretskii <eliz@gnu.org>
5531
a66cfb1c
SM
5532 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
5533 Default value is now t. Doc fix.
6bf7006f 5534
e3cbd34b 5535 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 5536 logic when moving up, not only when moving down. Fix the
e3cbd34b 5537 confusing name and values of the it_overshoot_expected variable;
32c1fffd 5538 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
5539
5540 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
5541 CHARPOS is covered by a display string which includes newlines.
5542 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
5543 is covered by a display string with embedded newlines.
5544
a3de0cbd
MA
55452011-09-24 Michael Albinus <michael.albinus@gmx.de>
5546
5547 * dbusbind.c (Fdbus_register_signal): Add match rule to
5548 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
5549 (Fdbus_register_method, Vdbus_registered_objects_table):
5550 Fix docstring.
a3de0cbd 5551
b260039d
JM
55522011-09-24 Jim Meyering <meyering@redhat.com>
5553
32c1fffd 5554 do not ignore write error for any output size
b260039d
JM
5555 The previous change was incomplete.
5556 While it makes emacs --batch detect the vast majority of stdout
5557 write failures, errors were still ignored whenever the output size is
5558 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
5559 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
5560 && echo FAIL: ignored write error
5561 FAIL: ignored write error
5562 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
5563 && echo FAIL: ignored write error
5564 FAIL: ignored write error
5565 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
5566
8eca8a7c
AS
55672011-09-23 Andreas Schwab <schwab@linux-m68k.org>
5568
5569 * emacs.c (Fkill_emacs): In noninteractive mode exit
5570 non-successfully if a write error occurred on stdout. (Bug#9574)
5571
3341db62
EZ
55722011-09-21 Eli Zaretskii <eliz@gnu.org>
5573
5574 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
5575 the xassert test.
5576
5577 * dispextern.h (struct it): Update the comment documenting what
5578 can it->OBJECT be.
5579
8c203dbf
EZ
55802011-09-20 Eli Zaretskii <eliz@gnu.org>
5581
5582 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
5583 a display string, extend search for cursor position to end of row.
5584 (find_row_edges): If the row ends in a newline from a display
5585 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
5586 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
5587 (Fcurrent_bidi_paragraph_direction): Fix search for previous
5588 non-empty line. Fixes confusing cursor motion with arrow keys at
5589 the beginning of a line that starts with whitespace.
8c203dbf 5590
a4824228
LMI
55912011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5592
5593 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
5594 (bug#9493).
5595
33ed493b
CY
55962011-09-18 Chong Yidong <cyd@stupidchicken.com>
5597
5598 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
5599 boolean (Bug#9154).
5600
56cd55c8
EZ
56012011-09-18 Eli Zaretskii <eliz@gnu.org>
5602
5603 * xdisp.c (display_line): Record maximum and minimum buffer
5604 positions even if no glyphs were produced (e.g., by a zero-width
5605 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
5606 buffer positions that will be removed from the glyph row because
5607 they don't fit.
c02dcedf
EZ
5608 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
5609 column is beyond frame width: don't subtract 1 "pixel" when
5610 computing width of the stretch.
3e62b7e0
EZ
5611 (reseat_at_next_visible_line_start): Undo the change made on
5612 2011-09-17 that saved paragraph information and restored it after
5613 the call to `reseat'. (Bug#9545)
56cd55c8 5614
5ed99d36 56152011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
5616
5617 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
5618 and turn window cursor on if cleared (Bug#9415).
5619
5ed99d36 56202011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
5621
5622 * search.c (boyer_moore): Take unibyte characters from pattern
5623 literally. (Bug#9458)
5624
9bade7b2
EZ
56252011-09-18 Eli Zaretskii <eliz@gnu.org>
5626
5627 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
5628
e5e9d610
PE
56292011-09-18 Paul Eggert <eggert@cs.ucla.edu>
5630
87e4427a
PE
5631 Fix minor problem found by static checking.
5632 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
5633 initialized, to pacify gcc -Wuninitialized.
5634
e5e9d610
PE
5635 * fileio.c: Report proper errno when syscall falls.
5636 (Finsert_file_contents): Save and restore errno,
5637 so that report_file_error outputs the correct diagnostic.
5638 (Fwrite_region) [CLASH_DETECTION]: Likewise.
5639
a1674f0b
EZ
56402011-09-18 Eli Zaretskii <eliz@gnu.org>
5641
5642 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
5643
fbfb6dd4
EZ
56442011-09-17 Eli Zaretskii <eliz@gnu.org>
5645
5646 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
5647 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
5648
bb187662
EZ
56492011-09-17 Eli Zaretskii <eliz@gnu.org>
5650
1137e8b8 5651 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 5652 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
5653
5654 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
5655 (bidi_find_paragraph_start): Search back for paragraph beginning
5656 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
5657 (bidi_move_to_visually_next): Only trigger paragraph-related
5658 computations when the last character is a newline or at EOB, not
5659 just any NEUTRAL_B. (Bug#9470)
5660
bb187662
EZ
5661 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
5662 truncated lines if point is covered by a display string. (Bug#9524)
5663
2e621251
PE
56642011-09-16 Paul Eggert <eggert@cs.ucla.edu>
5665
5666 * xselect.c: Relax test for outgoing X longs (Bug#9498).
5667 (cons_to_x_long): New function.
5668 (lisp_data_to_selection_data): Use it. Correct the test for
5669 short-versus-long data; it was negated. Break out of vector
5670 loop, for efficiency, when a long datum is discovered.
5671
91a15bc6
SM
56722011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
5673
5674 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
5675
b41c3a35
EZ
56762011-09-16 Eli Zaretskii <eliz@gnu.org>
5677
5678 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
5679 GCC PR/17406) by declaring this function with external scope.
5680
7812ba2d
PE
56812011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5682
5683 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
5684 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
5685
cf7edc2a
AS
56862011-09-15 Andreas Schwab <schwab@linux-m68k.org>
5687
5688 * editfns.c (Fformat): Correctly handle text properties on "%%".
5689
bd01620e
EZ
56902011-09-15 Eli Zaretskii <eliz@gnu.org>
5691
5692 * xterm.c (x_draw_composite_glyph_string_foreground):
5693 * w32term.c (x_draw_composite_glyph_string_foreground):
5694 * term.c (encode_terminal_code):
5695 * composite.c (composition_update_it, get_composition_id):
5696 * xdisp.c (get_next_display_element)
5697 (fill_composite_glyph_string): Add comments about special meaning
5698 of TAB characters in a composition.
5699
a02719a3
PE
57002011-09-15 Paul Eggert <eggert@cs.ucla.edu>
5701
5702 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
5703 This occurs when processing a multibyte format.
5704 Problem reported by Wolfgang Jenker.
a02719a3 5705
72589a3c
JB
57062011-09-15 Johan Bockgård <bojohan@gnu.org>
5707
5708 * xdisp.c (try_cursor_movement): Only check for exact match if
5709 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
5710
1c14176c
PE
57112011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5712
5713 Remove unused external symbols.
5714 * dispextern.h (calc_pixel_width_or_height): Remove decl.
5715 * xdisp.c (calc_pixel_width_or_height): Now static.
5716 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
5717 * indent.c (check_display_width):
5718 * w32term.c: Fix comment to match code.
5719 * xterm.c, xterm.h (x_catching_errors): Remove.
5720
d2eea5b5
PE
57212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
5722
5723 * xselect.c: Use signed conversions more consistently (Bug#9498).
5724 (selection_data_to_lisp_data): Assume incoming selection data are
5725 signed integers, not unsigned. This is to be consistent with
5726 outgoing selection data, which was modified to use signed integers
5727 in as part of the fix to Bug#9196 in response to Jan D.'s comment
5728 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
5729 expects long, not unsigned long.
5730
46888499
EZ
57312011-09-14 Eli Zaretskii <eliz@gnu.org>
5732
5733 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
5734 computation of loop end. Reported by Johan Bockgård
5735 <bojohan@gnu.org>.
5736
ef8ef9fb
CY
57372011-09-13 Chong Yidong <cyd@stupidchicken.com>
5738
5739 * frame.c (Fother_visible_frames_p): Function deleted.
5740
fa819fed
EZ
57412011-09-12 Eli Zaretskii <eliz@gnu.org>
5742
5743 * indent.c (compute_motion): Process display vector front to back
5744 rather than the other way around. (Bug#2496)
5745
2ba8e008
SM
57462011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
5747
5748 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
5749
20f53c69
CY
57502011-09-11 Chong Yidong <cyd@stupidchicken.com>
5751
5752 * minibuf.c (Fread_from_minibuffer): Doc fix.
5753
d562d7a4
EZ
57542011-09-11 Eli Zaretskii <eliz@gnu.org>
5755
5756 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
5757 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
5758
1c4d7f3d
LMI
57592011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
5760
5761 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
5762 value for non-existent files.
5763
b885bf36
EZ
57642011-09-11 Eli Zaretskii <eliz@gnu.org>
5765
5766 * fileio.c (Finsert_file_contents): If the file cannot be opened,
5767 set its "size" to -1. This will set the modtime_size field of
5768 the corresponding buffer to -1, which is what
5769 verify-visited-file-modtime expects for files that do not exist.
5770 (Bug#9139)
5771
6612f0bf
PE
57722011-09-11 Paul Eggert <eggert@cs.ucla.edu>
5773
5774 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
5775 here ...
5776 * lisp.h: ... from here. push_key_description is no longer
5777 defined in keyboard.c, so its declaration should not be in
5778 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
5779 logically belongs with push_key_description.
5780
dfb3f755
PE
57812011-09-10 Paul Eggert <eggert@cs.ucla.edu>
5782
5783 * buffer.h: Include <sys/types.h> instead of <time.h>.
5784 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
5785 Problem reported by Herbert J. Skuhra.
5786
3134906c
LMI
57872011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
5788
5789 * xml.c (parse_region): Make the parsing work for
5790 non-comment-starting XML files again (bug#9144).
5791
8d903f4e
AS
57922011-09-10 Andreas Schwab <schwab@linux-m68k.org>
5793
5794 * image.c (gif_load): Fix calculation of bottom and right corner.
5795 (Bug#9468)
5796
80ad64f4
EZ
57972011-09-10 Eli Zaretskii <eliz@gnu.org>
5798
5799 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
5800 redisplay in small windows.
5801
208a048d
EZ
58022011-09-09 Eli Zaretskii <eliz@gnu.org>
5803
5804 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
5805
9b1c252e
MR
58062011-09-08 Martin Rudalics <rudalics@gmx.at>
5807
5808 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
5809 Operate on live windows only.
5810
2949f33b
JB
58112011-09-08 Juanma Barranquero <lekktu@gmail.com>
5812
5813 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
5814
e08dcafd
EZ
58152011-09-07 Eli Zaretskii <eliz@gnu.org>
5816
5817 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
5818 only under bidi iteration.
5819
115b96bd
JD
58202011-09-07 Jan Djärv <jan.h.d@swipnet.se>
5821
5822 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
5823
c8199d0f
PE
58242011-09-06 Paul Eggert <eggert@cs.ucla.edu>
5825
5826 isnan: Fix porting problem to Solaris 10 with bundled gcc.
5827 Without this fix, the command to link temacs failed due to an
5828 undefined symbol __builtin_isnan. This is because
5829 /usr/include/iso/math_c99.h #defines isnan(x) to
5830 __builtin_isnan(x), but the bundled gcc, which identifies itself
5831 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
5832 a __builtin_isnan.
5833 * floatfns.c (isnan): #undef, and then #define to a clone of
5834 what's in data.c.
5835 (Fisnan): Always define, since it's always available now.
5836 (syms_of_floatfns): Always define isnan at the Lisp level.
5837
e39b275c 58382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
5839
5840 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
5841
b2db44d9 58422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 5843
f4af5137 5844 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
5845 The previous code assumed that file offsets (off_t values) fit in
5846 EMACS_INT variables, which is not true on typical 32-bit hosts.
5847 The code messed up by falsely reporting buffer overflow in cases
5848 such as (insert-file-contents "big" nil 1 2) into an empty buffer
5849 when "big" contains more than 2**29 bytes, even though this
5850 inserts just one byte and does not overflow the buffer.
5851 (Finsert_file_contents): Store file offsets as off_t
5852 values, not as EMACS_INT values. Check for overflow when
5853 converting between EMACS_INT and off_t. When checking for
5854 buffer overflow or for overlap, take the offsets into account.
5855 Don't use EMACS_INT for small values where int suffices.
5856 When checking for overlap, fix a typo: ZV was used where
5857 ZV_BYTE was intended.
5858 (Fwrite_region): Don't assume off_t fits into 'long'.
5859 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
5860
ecfc0a49
MA
58612011-09-05 Michael Albinus <michael.albinus@gmx.de>
5862
5863 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
5864
6511acf2 58652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 5866
0999621a 5867 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
5868
5869 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 5870 (esprintf, exprintf, evxprintf): New functions.
62f19c19 5871 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 5872 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
5873 (modify_event_symbol): Do not assume that the length of
5874 name_alist_or_stem is safe to alloca and fits in int.
5875 (Fexecute_extended_command): Likewise for function name and binding.
5876 (Frecursion_depth): Wrap around reliably on integer overflow.
5877 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
5878 since some callers pass EMACS_INT values.
5879 (Fsingle_key_description): Don't crash if symbol name contains more
5880 than MAX_ALLOCA bytes.
5881 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
5882 (get_minibuffer): Arg is now EMACS_INT, not int.
5883 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 5884 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
5885 * window.h (command_loop_level, minibuf_level): Reflect API changes.
5886
2be7d702
PE
5887 * dbusbind.c (signature_cat): New function.
5888 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
5889 Do not overrun buffer; instead, report string overflow.
5890
9d1df220
PE
5891 * dispnew.c (add_window_display_history): Don't overrun buffer.
5892 Truncate instead; this is OK since it's just a log.
5893
33ef5c64
PE
5894 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
5895 even if the time zone offset is outlandishly large.
5896 Don't mishandle offset == INT_MIN.
5897
66c6fdd5
PE
5898 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
5899 when creating daemon; the previous buffer-overflow check was incorrect.
5900
d749b01b
PE
5901 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
5902 which has the guts of the old verror function.
5903
b5cd1905
PE
5904 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
5905 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
5906
6e1a67fb
PE
5907 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
5908 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 5909 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 5910 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
5911 length of string rather than counting it via multiple sprintfs;
5912 that's simpler and more reliable.
c21721cc
PE
5913 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
5914 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
5915 sprintf, in case result does not fit in int.
5916
c57b67fc
PE
5917 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
5918 (fontset_from_font): Print it.
5919
8a401434
PE
5920 * frame.c (tty_frame_count): Now printmax_t, not int.
5921 (make_terminal_frame, set_term_frame_name): Print it.
5922 (x_report_frame_params): In X, window IDs are unsigned long,
5923 not signed long, so print them as unsigned.
5924 (validate_x_resource_name): Check for implausibly long names,
5925 and don't assume name length fits in 'int'.
5926 (x_get_resource_string): Don't blindly alloca invocation name;
5927 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
5928 not fit in int.
5929
6e1a67fb
PE
5930 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
5931 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
5932 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
5933
0df02bf3
PE
5934 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
5935 Use esprintf, not sprintf, in case result does not fit in int.
5936
48e30793
PE
5937 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5938 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
5939 it as a large positive number.
5940 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
5941 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
5942
a66ff6d8
PE
5943 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
5944 in case result does not fit in int.
5945
aca216ff
PE
5946 * print.c (float_to_string): Detect width overflow more reliably.
5947 (print_object): Make sprintf buffer a bit bigger, to avoid potential
5948 buffer overrun. Don't assume list length fits in 'int'. Treat
5949 print length of 0 as 0, not as infinity; to be consistent with other
5950 uses of print length in this function. Don't overflow print length
5951 index. Don't assume hash table size fits in 'long', or that
5952 vectorlike size fits in 'unsigned long'.
5953
31c286f7
PE
5954 * process.c (make_process): Use printmax_t, not int, to format
5955 process-name gensyms.
5956
55e5faa1
PE
5957 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
5958
80f2e268
PE
5959 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
5960 to avoid potential buffer overrun.
5961
670741ab
PE
5962 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
5963 if X resource line is longer than 512 bytes.
5964
b7163a50
PE
5965 * xfns.c (x_window): Make sprintf buffer a bit bigger
5966 to avoid potential buffer overrun.
5967
ae58ff1f
PE
5968 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
5969
c43c8a6a
PE
5970 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
5971
3f8236f4
PE
59722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
5973
53e9fe90 5974 Integer overflow fixes for scrolling, etc.
6511acf2
PE
5975 Without these, Emacs silently mishandles large integers sometimes.
5976 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
5977 it were "C-u 1 M-x recenter" on a typical 64-bit host.
5978
6511acf2
PE
5979 * xdisp.c (try_window_id): Check Emacs fixnum range before
5980 converting to 'int'.
806add1d 5981
6511acf2 5982 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
5983 Check that an Emacs fixnum is in range before assigning it to 'int'.
5984 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
5985 values converted from Emacs fixnums.
5986 (Frecenter): Don't wrap around a line count if it is out of 'int'
5987 range; instead, treat it as an extreme value.
5988 (Fset_window_configuration, compare_window_configurations):
5989 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
5990
6511acf2
PE
5991 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
5992 that can exceed INT_MAX. Check that EMACS_INT value is in range
5993 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
5994 (match_limit): Don't assume that a fixnum can fit in 'int'.
5995
6511acf2 5996 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
5997 exceed INT_MAX.
5998
6511acf2 5999 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
6000 (Fvertical_motion): Don't wrap around LINES values that don't fit
6001 in 'int'. Instead, treat them as extreme values. This is good
6002 enough for windows, which can't have more than INT_MAX lines anyway.
6003
fcb901a7
LMI
60042011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6005
0f2f6b6d
LMI
6006 * Require libxml/parser.h to avoid compilation warning.
6007
fcb901a7
LMI
6008 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
6009
6010 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
6011 since this reportedly can destroy thread storage.
6012
6e20a0d4
CY
60132011-08-30 Chong Yidong <cyd@stupidchicken.com>
6014
6015 * syntax.c (find_defun_start): Update all cache variables if
6016 exiting early (Bug#9401).
6017
148ae00e
EZ
60182011-08-30 Eli Zaretskii <eliz@gnu.org>
6019
f6cfbd8f
EZ
6020 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
6021
148ae00e
EZ
6022 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
6023 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
6024 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
6025
6026 * term.c (tty_append_glyph): New function.
6027 (produce_stretch_glyph): Static function and its prototype deleted.
6028
a66cfb1c
SM
6029 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
6030 Add prototypes.
148ae00e 6031
c4a07a4c
PE
60322011-08-29 Paul Eggert <eggert@cs.ucla.edu>
6033
6034 * image.c (parse_image_spec): Check for nonnegative, not for positive,
6035 when checking :margin (Bug#9390).
6036 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 6037 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
6038 so that the name doesn't mislead. All uses changed.
6039
6bc8cd65
JB
60402011-08-28 Johan Bockgård <bojohan@gnu.org>
6041
6042 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
6043 set_tty_hooks.
6044
dca4927e
EZ
60452011-08-27 Eli Zaretskii <eliz@gnu.org>
6046
6047 * xdisp.c (move_it_to): Don't bail out early when reaching
6048 position beyond to_charpos, if we are scanning backwards.
6049 (move_it_vertically_backward): When DY == 0, make sure we get to
6050 the first character in the line after the newline.
6051
f2cad773
PE
60522011-08-27 Paul Eggert <eggert@cs.ucla.edu>
6053
6054 * ccl.c: Improve and simplify overflow checking (Bug#9196).
6055 (ccl_driver): Do not generate an out-of-range pointer.
6056 (Fccl_execute_on_string): Remove unnecessary check for
6057 integer overflow, noted by Stefan Monnier in
6058 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
6059 Remove a FIXME that didn't need fixing.
6060 Simplify the newly-introduced buffer reallocation code.
6061
0cae2cdb
JB
60622011-08-27 Juanma Barranquero <lekktu@gmail.com>
6063
6064 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
6065
5fc295a4 60662011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 6067
70c60eb2 6068 Integer and memory overflow issues (Bug#9196).
726e0ab1 6069
d31850da
PE
6070 * doc.c (get_doc_string): Rework so that
6071 get_doc_string_buffer_size is the actual buffer size, rather than
6072 being 1 less than the actual buffer size; this makes xpalloc more
6073 convenient.
6074
a69fbedb
PE
6075 * image.c (x_allocate_bitmap_record, cache_image):
6076 * xselect.c (Fx_register_dnd_atom):
6077 Simplify previous changes by using xpalloc.
6078
fe5c5d37
PE
6079 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
6080 since either will do and ptrdiff_t is convenient with xpalloc.
6081
0065d054
PE
6082 * charset.c (charset_table_size)
6083 (struct charset_sort_data.priority): Now ptrdiff_t.
6084 (charset_compare): Don't overflow if priorities differ greatly.
6085 (Fsort_charsets): Don't assume list length fits in int.
6086 Check for size-calculation overflow when allocating sort data.
6087 (syms_of_charset): Allocate an initial charset table that is
6088 just under 64 KiB, to avoid problems with glibc malloc and mmap.
6089
6090 * cmds.c (internal_self_insert): Check for size-calculation overflow.
6091
6092 * composite.h (struct composition.glyph_len): Now int, not unsigned.
6093 The actual value is always <= INT_MAX, and leaving it unsigned made
6094 overflow checking harder.
6095
6096 * dispextern.h (struct glyph_matrix.rows_allocated)
6097 (struct face_cache.size): Now ptrdiff_t, for convenience in use
6098 with xpalloc. The values are still always <= INT_MAX.
6099
6100 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
6101
6102 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
6103 (SAFE_NALLOCA): New macro.
6104
6105 * region-cache.c (struct boundary.pos, find_cache_boundary)
6106 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
6107 (set_cache_region, invalidate_region_cache)
6108 (revalidate_region_cache, know_region_cache, region_cache_forward)
6109 (region_cache_backward, pp_cache):
6110 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
6111 so that ptrdiff_t * can be passed to xpalloc.
6112 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
6113 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
6114 (pp_cache): Don't assume cache_len fits in int.
6115 * region-cache.h: Adjust extern decls to match.
6116
6117 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
6118 EMACS_INT, since either will do, for xpalloc.
6119
6120 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
6121 (xnmalloc, xnrealloc, xpalloc): New functions.
6122
726e0ab1
PE
6123 * bidi.c (bidi_shelve_header_size): New constant.
6124 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
6125 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
6126
51f30bc5 6127 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
6128 * buffer.c (overlays_at, overlays_in, record_overlay_string)
6129 (overlay_strings):
6130 Don't update size of array until after memory allocation succeeds,
6131 because xmalloc/xrealloc may not return.
0065d054
PE
6132 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
6133 now that we have proper integer overflow checking.
6134 (record_overlay_string, overlay_strings): Catch overflows when
6135 calculating size of overlay_str_buf.
726e0ab1 6136
0065d054
PE
6137 * callproc.c (Fcall_process): Check for size overflow when
6138 calculating size of args2.
6139 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
6140 Normally we prefer signed values, but sticking with ptrdiff_t would
6141 require adding more-complicated checks.
726e0ab1
PE
6142
6143 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
6144 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
6145 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 6146 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
6147
6148 * character.c (Fstring): Check for size-calculation overflow.
6149
6150 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
6151 unnecessary integer overflow. Check for size overflow.
6152 (encode_coding_object): Don't update size until xmalloc succeeds.
6153
6154 * composite.c (get_composition_id): Check for overflow in glyph
6155 length calculations.
6156
6157 Integer and memory overflow fixes for display code.
6158 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
6159 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
6160 (scrolling_window): Check for overflow in size calculations.
6161 (line_draw_cost, realloc_glyph_pool, add_row_entry):
6162 Don't assume glyph table len fits in int.
6163 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
6164 (row_table_size): Now ptrdiff_t, not int.
6165 (scrolling_window): Avoid overflow in size calculations.
6166 Don't update size until allocation succeeds.
6167 * fns.c (concat): Check for overflow in size calculations.
6168 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
6169 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6170 (NEXT_ALMOST_PRIME_LIMIT): New constant.
6171
6172 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
6173 (get_doc_string): Check for size calculation overflow.
6174 Don't update size until allocation succeeds.
6175 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
6176 EMACS_INT, where ptrdiff_t will do.
6177 (Fsubstitute_command_keys): Check for string overflow.
6178
6179 * editfns.c (set_time_zone_rule): Don't assume environment length
6180 fits in int.
6181 (message_length): Now ptrdiff_t, not int.
6182 (Fmessage_box): Don't update size until allocation succeeds.
6183 Don't assume message length fits in int.
6184 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
6185
0065d054
PE
6186 * emacs.c (main): Do not reallocate argv, since there is a null at
6187 the end that can be overwritten, and this way there's no need to
6188 worry about size-calculation overflow.
6189 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
6190
6191 * eval.c (init_eval_once, grow_specpdl): Don't update size until
6192 alloc succeeds.
6193 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
6194
6195 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
6196 (x_set_scroll_bar_width, x_figure_window_size):
6197 Check for integer overflow.
6198 (x_set_alpha): Do not assume XINT fits in int.
6199
6200 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
6201 This is for the members text_lines, text_cols, total_lines, total_cols,
6202 where the system imposes an 'int' limit.
6203
6204 * fringe.c (Fdefine_fringe_bitmap):
6205 Don't update size until alloc works.
6206
6207 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
6208 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
6209
6210 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
6211 Check for size-calculation overflow.
6212 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
6213 do, as we prefer signed integers.
6214 (id_to_widget.max_size, id_to_widget.used)
6215 (xg_store_widget_in_map, xg_remove_widget_from_map)
6216 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
6217 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
6218 Use and return ptrdiff_t, not int.
6219 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
6220 * gtkutil.h: Change prototypes to match the above.
6221
6222 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
6223 are duplicate now that they've been promoted to lisp.h.
6224 (x_allocate_bitmap_record, x_alloc_image_color)
6225 (make_image_cache, cache_image, xpm_load):
6226 Don't update size until alloc is done.
6227 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
6228 (x_detect_edges):
3256efce 6229 Check for size calculation overflow.
726e0ab1
PE
6230 (ct_colors_allocated_max): New constant.
6231 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
6232 overflow.
3256efce 6233
726e0ab1
PE
6234 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
6235 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
6236 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
6237 Use ptrdiff_t, not int, to count maps.
6238 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
6239 calculations. Don't update size until allocation succeeds.
6240 Redo calculations to avoid overflow.
726e0ab1
PE
6241 * keyboard.h: Change prototypes to match the above.
6242
6243 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
6244 to count maps.
6245 (current_minor_maps): Check for size calculation overflow.
6246 * keymap.h: Change prototypes to match the above.
6247
6248 * lread.c (read1, init_obarray): Don't update size until alloc done.
6249
6250 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
6251 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
6252
726e0ab1
PE
6253 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
6254 Now ptrdiff_t, not int.
6255 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
6256 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
6257
6258 * process.c (Fnetwork_interface_list): Check for overflow
6259 in size calculation.
6260
6261 * region-cache.c (move_cache_gap): Check for size calculation overflow.
6262
6263 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
6264 overflow. Don't bother calling xmalloc when xrealloc will do.
6265
6266 * search.c (Freplace_match): Check for size calculation overflow.
6267 (Fset_match_data): Don't assume list lengths fit in 'int'.
6268
6269 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
6270 for command line length. Do not attempt to address one before the
6271 beginning of an array, as that's not portable.
6272
6273 * term.c (max_frame_lines): Remove; unused.
6274 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
6275 not int.
6276 (encode_terminal_code, calculate_costs): Check for size
6277 calculation overflow.
6278 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
6279 table lengths and related sizes. Don't update size until alloc
6280 done. Redo calculations to avoid overflow.
6281 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
6282
6283 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
6284 subtracting pointers.
6285 (gobble_line): Check for overflow more carefully. Don't update size
6286 until alloc done.
6287
6288 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
6289 Don't update size until alloc done.
6290 Redo size calculations to avoid overflow.
6291 Check for size calculation overflow.
0065d054 6292 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
6293
6294 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
6295 Use ptrdiff_t, not int, for sizes.
6296 (store_mode_line_noprop_char): Don't update size until alloc done.
6297
0065d054
PE
6298 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
6299 Use ptrdiff_t, not int, for sizes.
6300 (Finternal_make_lisp_face, cache_face):
6301 Check for size calculation overflow.
6302 (cache_face): Treat size calculation overflows as if they were
6303 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
6304
6305 * xfns.c (x_encode_text, x_set_name_internal)
6306 (Fx_change_window_property): Use ptrdiff_t, not int, to count
6307 sizes, since they can exceed INT_MAX in size. Check for size
6308 calculation overflow.
6309
0065d054
PE
6310 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
6311 (xg_select): Check for size calculation overflow.
726e0ab1
PE
6312 Don't update size until alloc done.
6313
0065d054 6314 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 6315 as sprintf is limited to int lengths.
1d526e2f 6316
252c5ee1
PE
6317 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
6318 (X_LONG_MIN): New macros.
864d7ce7
PE
6319 Use them to make the following changes clearer.
6320 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
6321 This change doesn't affect the value now, but it may help remind
6322 future maintainers not to raise the value too much later.
6323 (SELECTION_QUANTUM): Remove, replacing with ...
6324 (selection_quantum): ... new function, which avoids overflow.
6325 All uses changed.
6326 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
6327 assumption that selection length fits in 'int'.
6328 (x_reply_selection_request, x_handle_selection_request)
6329 (x_get_window_property, receive_incremental_selection)
6330 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
6331 (lisp_data_to_selection_data, clean_local_selection_data):
6332 Use ptrdiff_t, not int, to record length of selection.
6333 (x_reply_selection_request, x_get_window_property)
6334 (receive_incremental_selection, x_property_data_to_lisp):
6335 Redo calculations to avoid overflow.
6336 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 6337 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
6338 something.
6339 (x_get_window_property, receive_incremental_selection)
6340 (lisp_data_to_selection_data, x_property_data_to_lisp):
6341 Check for size-calculation overflow.
6342 (x_get_window_property, receive_incremental_selection)
6343 (lisp_data_to_selection_data, Fx_register_dnd_atom):
6344 Don't store size until memory allocation succeeds.
6345 (x_get_window_property): Plug memory leak on memory exhaustion.
6346 Don't double-block input; malloc is safe here. Don't assume 2**34
6347 - 4 fits in unsigned long. Add an xassert to check
6348 XGetWindowProperty overflow. Be more careful about overflow
6349 calculations, and distinguish size from memory overflow better.
6350 (receive_incremental_selection): When tracing, don't assume
6351 unsigned int is less than INT_MAX.
6352 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
6353 harmful) conversions of unsigned short to int.
6354 (lisp_data_to_selection_data): Don't assume that integers
6355 in the range -65535 through -1 fit in an X unsigned short.
6356 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
6357 result parameters unless successful. Rely on cons_to_unsigned
6358 to report problems with elements; the old code wasn't right anyway.
6359 (x_check_property_data): Check for int overflow; we cannot use
6360 a wider type due to X limits.
6361 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
6362
726e0ab1 6363 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 6364
0065d054
PE
6365 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
6366 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
6367 (x_color_cells): Don't store size until memory allocation succeeds.
6368 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 6369 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
6370 (x_term_init): Don't assume length fits in int (sprintf is limited
6371 to int size).
bc18e09d 6372
ebfa62c0
PE
6373 Use ptrdiff_t for composition IDs.
6374 * character.c (lisp_string_width):
6375 * composite.c (composition_table_size, n_compositions)
6376 (get_composition_id, composition_gstring_from_id):
6377 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
6378 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
6379 * window.c (Frecenter):
6380 Use ptrdiff_t, not int, for composition IDs.
6381 * composite.c (get_composition_id): Check for integer overflow.
6382 * composite.h: Adjust prototypes to match the above changes.
6383
d3411f89
PE
6384 Use ptrdiff_t for hash table indexes.
6385 * category.c (hash_get_category_set):
6386 * ccl.c (ccl_driver):
6387 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
6388 * coding.c (coding_system_charset_list, detect_coding_system):
6389 * coding.h (struct coding_system.id):
6390 * composite.c (get_composition_id, gstring_lookup_cache):
6391 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
6392 * image.c (xpm_get_color_table_h):
6393 * lisp.h (hash_lookup, hash_put):
6394 * minibuf.c (Ftest_completion):
6395 Use ptrdiff_t for hash table indexes, not int (which is too
6396 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
6397 32-bit --with-wide-int hosts).
6398
e097a6fa
PE
6399 * charset.c (Fdefine_charset_internal): Check for integer overflow.
6400 Add a FIXME comment about memory leaks.
6401 (syms_of_charset): Don't assume xmalloc returns.
6402
5637687f
PE
6403 Don't assume that stated character widths fit in int.
6404 * character.c (Fchar_width, c_string_width, lisp_string_width):
6405 * character.h (CHAR_WIDTH):
6406 * indent.c (MULTIBYTE_BYTES_WIDTH):
6407 Use sanitize_char_width to avoid undefined and/or bad behavior
6408 with outlandish widths.
a66cfb1c 6409 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
6410 now that we have two such functions. All uses changed.
6411 (sanitize_char_width): New inline function.
6412
a2271ba2
PE
6413 Don't assume that tab-width fits in int.
6414 * character.h (sanitize_width): New inline function.
6415 (SANE_TAB_WIDTH): New macro.
6416 (ASCII_CHAR_WIDTH): Use it.
6417 * indent.c (sane_tab_width): Remove. All uses replaced by
6418 SANE_TAB_WIDTH (current_buffer).
6419 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
6420
18c52557
PE
6421 * fileio.c: Integer overflow issues with file modes.
6422 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
6423
caeeedc1
PE
6424 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
6425 Remove unreachable code.
6426 (read_hex, load_charset_map_from_file): Check for integer overflow.
6427
6df6ae42 6428 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
6429 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
6430 (x_send_scroll_bar_event): Likewise. Check that the size does not
6431 exceed limits imposed by XClientMessageEvent, as well as the usual
6432 ptrdiff_t and size_t limits.
6433
b13995db
PE
6434 * keyboard.c: Overflow, signedness and related fixes.
6435 (make_lispy_movement): Use same integer type in forward decl
6436 that is used in the definition.
6437 (read_key_sequence, keyremap_step):
6438 Change bufsize argument back to int, undoing my 2011-03-30 change.
6439 We prefer signed types, and int is wide enough here.
6440 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
6441 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
6442 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
6443 length, not size_t. Use ptrdiff_t for index, not int.
6444 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
6445 possibility of integer overflow.
6446
13464394
PE
6447 Overflow, signedness and related fixes for images.
6448
6449 * dispextern.h (struct it.stack[0].u.image.image_id)
6450 (struct_it.image_id, struct image.id, struct image_cache.size)
6451 (struct image_cache.used, struct image_cache.ref_count):
6452 * gtkutil.c (update_frame_tool_bar):
6453 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
6454 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
6455 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
6456 * nsmenu.m (update_frame_tool_bar):
6457 * xdisp.c (calc_pixel_width_or_height):
6458 * xfns.c (image_cache_refcount):
6459 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
6460 on typical 64-bit hosts.
6461
6462 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
6463 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
6464 Omit unnecessary casts to int.
6465 (parse_image_spec): Check that integers fall into 'int' range
6466 when the callers expect that.
6467 (image_ascent): Redo ascent calculation to avoid int overflow.
6468 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
6469 (lookup_image): Remove unnecessary tests.
6470 (xbm_image_p): Locals are now of int, not EMACS_INT,
6471 since parse_image_check makes sure they fit into int.
6472 (png_load, gif_load, svg_load_image):
6473 Prefer int to unsigned where either will do.
6474 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
6475 old tiff_error_handler and tiff_warning_handler.
6476 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
6477 stack buffer overflows. It uses only the features of vsnprintf
6478 that are common to both POSIX and native Microsoft.
6479 (tiff_error_handler, tiff_warning_handler): Use it.
6480 (tiff_load, gif_load, imagemagick_load_image):
6481 Don't assume :index value fits in 'int'.
6482 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
6483 (imagemagick_load_image): Check that crop parameters fit into
6484 the integer types that MagickCropImage accepts. Don't assume
6485 Vimagemagick_render_type has a nonnegative value. Don't assume
6486 size_t fits in 'long'.
6487 (gs_load): Use printmax_t to print the widest integers possible.
6488 Check for integer overflow when computing image height and width.
6489
c11821d4
EZ
64902011-08-26 Eli Zaretskii <eliz@gnu.org>
6491
6492 * xdisp.c (redisplay_window): Don't force window start if point
6493 will be invisible in the resulting window. (Bug#9324)
6494
0c95fcf7
EZ
64952011-08-25 Eli Zaretskii <eliz@gnu.org>
6496
6497 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
6498 the display spec is of the form `(space ...)'.
6499 (handle_display_spec): Return the value returned by
6500 handle_single_display_spec, not just 1 or zero.
6501 (handle_single_display_spec): If the display spec is of the form
6502 `(space ...)', and specifies display in the text area, return 2
6503 rather than 1.
fee65a97 6504 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
6505 accurately, and prefer exact match for point under bidi.
6506 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
6507
6508 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
6509 into disp_prop; all users changed.
6510
6511 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
6512 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
6513 for the text covered by the display property.
6514
e4ed06f1
CY
65152011-08-25 Chong Yidong <cyd@stupidchicken.com>
6516
6517 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
6518 Change return value to nil.
6519 (Frecord_buffer): Delete unused function.
6520
f67cdd7f
EZ
65212011-08-24 Eli Zaretskii <eliz@gnu.org>
6522
5980d4c6
EZ
6523 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
6524 buffers, return left-to-right.
8610fe8b
EZ
6525 (set_cursor_from_row): Consider candidate row a win if its glyph
6526 represents a newline and point is on that newline. Fixes cursor
6527 positioning on the newline at EOL of R2L text within L2R
6528 paragraph, and vice versa.
6529 (try_cursor_movement): Check continued rows, in addition to
6530 continuation rows. Fixes unwarranted scroll when point enters a
6531 continued line of R2L text within an L2R paragraph, or vice versa.
6532 (cursor_row_p): Consider the case of point being equal to
6533 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
6534 from the end of a short line to the beginning of a continued line
6535 of R2L text within L2R paragraph.
6536 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
6537 composed characters.
5980d4c6 6538
f67cdd7f
EZ
6539 * bidi.c (bidi_check_type): Use xassert.
6540 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
6541 members.
6542
bca633fb
EZ
65432011-08-23 Eli Zaretskii <eliz@gnu.org>
6544
6545 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
6546 a character.
6547
4a5885a7
CY
65482011-08-23 Chong Yidong <cyd@stupidchicken.com>
6549
6550 * nsfont.m (ns_otf_to_script): Fix typo.
6551
0902a04e
KH
65522011-08-22 Kenichi Handa <handa@m17n.org>
6553
6554 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
6555 extra slot even if the purpose is char-code-property-table.
6556
1a2e6670
EZ
65572011-08-23 Eli Zaretskii <eliz@gnu.org>
6558
8ddde651
EZ
6559 * xdisp.c (redisplay_window): When computing centering_position,
6560 account for the height of the header line. (Bug#8874)
6561
425cc014
EZ
6562 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
6563 instead of CHAR_TO_BYTE. Fixes a crash when a completion
6564 candidate is selected by the mouse, and that candidate has a
6565 composed character under the mouse.
6566
1a2e6670
EZ
6567 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
6568 coordinates reported by pos-visible-in-window-p for a composed
6569 character in column zero.
6570
8b76d6f8
SM
65712011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
6572
6573 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
6574
dac347dd
EZ
65752011-08-22 Eli Zaretskii <eliz@gnu.org>
6576
6577 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
6578 consider it a hit if to_charpos is anywhere in the range of the
6579 composed buffer positions.
6580
e013fb34
CY
65812011-08-22 Chong Yidong <cyd@stupidchicken.com>
6582
6583 * image.c (gif_load): Don't assume that each subimage has the same
6584 dimensions as the base image. Handle disposal method that is
6585 "undefined" by the gif spec (Bug#9335).
6586
bd1ba3e8
CY
65872011-08-20 Chong Yidong <cyd@stupidchicken.com>
6588
6589 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 6590 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 6591
54a1215b
EZ
65922011-08-19 Eli Zaretskii <eliz@gnu.org>
6593
823564e5
EZ
6594 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
6595 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
6596 from an Org mode buffer to a Speedbar frame.
6597
54a1215b
EZ
6598 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
6599 a composition, take its buffer position from IT->cmp_it.charpos.
6600 Fixes cursor positioning at the beginning of a line that begins
6601 with a composed character.
6602
9778ebcc
EZ
66032011-08-18 Eli Zaretskii <eliz@gnu.org>
6604
0be6ee06
EZ
6605 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
6606 character bidirectional type, use STRONG_L instead. Fixes crashes
6607 in a buffer produced by `describe-categories'.
6608
9778ebcc
EZ
6609 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
6610 members before the level stack, so they would be saved and
6611 restored when copying iterator state. Fixes incorrect reordering
6612 around TABs covered by display properties.
6613
156bffbe
AS
66142011-08-18 Andreas Schwab <schwab@linux-m68k.org>
6615
6b02f655 6616 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 6617
72ad093b
CY
66182011-08-17 Chong Yidong <cyd@stupidchicken.com>
6619
6620 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
6621 (internal_condition_case_2, internal_condition_case_n):
6622 Remove unnecessary aborts (Bug#9081).
72ad093b 6623
35774242
EZ
66242011-08-17 Eli Zaretskii <eliz@gnu.org>
6625
6626 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
6627 has no `load' handler, try opening the file locally. (Bug#9311)
6628
db76dd85
KB
66292011-08-16 Ken Brown <kbrown@cornell.edu>
6630
6631 * gmalloc.c: Expand comment.
6632
b215eee5
EZ
66332011-08-16 Eli Zaretskii <eliz@gnu.org>
6634
6635 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
6636 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
6637
a4579d33
KB
66382011-08-16 Ken Brown <kbrown@cornell.edu>
6639
6640 Fix memory allocation problems in Cygwin build (Bug#9273).
6641
6642 * unexcw.c ( __malloc_initialized): Declare external variable.
6643 (fixup_executable): Force the dumped emacs to reinitialize malloc.
6644
8b76d6f8
SM
6645 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
6646 New variables.
a4579d33
KB
6647 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
6648 dumped emacs.
6649 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
6650 in the static heap.
6651 [CYGWIN] (special_realloc): New function.
6652 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
6653 requests to realloc storage in the static heap.
6654
3ebec551
PE
66552011-08-15 Paul Eggert <eggert@cs.ucla.edu>
6656
6657 * bidi.c (bidi_initialize): Remove unused local.
6658
9fd8be00
EZ
66592011-08-15 Eli Zaretskii <eliz@gnu.org>
6660
6b02f655
SM
6661 * bidimirror.h:
6662 * biditype.h: Remove file.
6663 * makefile.w32-in ($(BLD)/bidi.$(O)):
6664 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
6665
6666 * dispextern.h: Fix a typo in the comment to bidi_type_t.
6667
6668 * chartab.c: Improve commentary for the uniprop_table API.
6669
32413314
EZ
6670 * bidi.c (bidi_paragraph_init): Support zero value of
6671 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
6672 (bidi_initialize): Use uniprop_table instead of including
6673 biditype.h and bidimirror.h.
32413314 6674
9fd8be00
EZ
6675 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
6676 coordinates of the iterator when restoring from ppos_it.
6677 (Bug#9296)
6678
5cf2b69b
KH
66792011-08-14 Kenichi Handa <handa@m17n.org>
6680
6681 * process.c (create_process): Call setup_process_coding_systems
72ad093b 6682 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 6683
daf17d00
EZ
66842011-08-14 Eli Zaretskii <eliz@gnu.org>
6685
6686 * xdisp.c (move_it_in_display_line_to): Don't invoke
6687 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
6688 ppos_it. Fixes vertical cursor motion when line beginning is
6689 covered by an image. (Bug#9296)
6690
08e3161a
JD
66912011-08-14 Jan Djärv <jan.h.d@swipnet.se>
6692
6693 * nsterm.h (ns_run_ascript): Declare.
6694 (NSAPP_DATA2_RUNASSCRIPT): Define.
6695
6696 * nsfns.m (as_script, as_result, as_status): New static variables.
6697 (ns_run_ascript): New function.
5e617bc2 6698 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
6699 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
6700 the event loop. Get status from as_status (Bug#7276).
6701
6702 * nsterm.m (sendEvent): If event is NSApplicationDefined and
6703 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
6704 the event loop (Bug#7276).
6705
a3720aa2
AS
67062011-08-14 Andreas Schwab <schwab@linux-m68k.org>
6707
6708 * gnutls.c (QCgnutls_bootprop_priority)
6709 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
6710 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
6711 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
6712 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
6713 (QCgnutls_bootprop_verify_hostname_error)
6714 (QCgnutls_bootprop_callbacks_verify): Rename from
6715 Qgnutls_bootprop_..., all uses changed.
6716
6717 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
6718 uses changed.
6719
0a0d27fb
PE
67202011-08-14 Paul Eggert <eggert@cs.ucla.edu>
6721
19d5c50c
PE
6722 * xfaces.c (Qframe_set_background_mode): Now static.
6723 * dispextern.h (Qframe_set_background_mode): Remove decl.
6724
0a0d27fb
PE
6725 * process.c (Fnetwork_interface_info): Declare local only if needed.
6726
377538cb
JD
67272011-08-13 Jan Djärv <jan.h.d@swipnet.se>
6728
6729 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
6730 (Fnetwork_interface_list): Allocate in increments of bytes instead
6731 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
6732 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
6733 sockaddr.
6734 (struct ifflag_def): notrailers is smart on OSX.
6735 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
6736 Get hardware address with getifaddrs if available.
6737
08fff70c
EZ
67382011-08-12 Eli Zaretskii <eliz@gnu.org>
6739
6740 * xdisp.c (iterate_out_of_display_property): xassert that
6741 IT->position is set to within IT->object's boundaries. Break from
6742 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
6743 when IT->position is set up wrongly due to some bug.
6744 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
6745 (push_display_prop): Allow GET_FROM_STRING as IT->method on
6746 entry. Force push_it to save on the stack the current
6747 buffer/string position, to be restored by pop_it. Fix flags in
6748 the iterator structure wrt the object coming from a display
6749 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
6750 properties. (Bug#9284)
6751
7be1c708 67522011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 6753
7be1c708
CY
6754 * fontset.c (fontset_get_font_group): Add proper type checks.
6755 (Bug#9172)
aac0c6e3 6756
7be1c708 67572011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 6758
7be1c708
CY
6759 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
6760 and LC_VERSION_MIN_MACOSX.
6761 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
6762 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 6763
97bb72a6
EZ
67642011-08-08 Eli Zaretskii <eliz@gnu.org>
6765
6766 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
6767 no-display-properties-and-no-overlays under bidi display.
6768 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 6769 properties and overlays.
97bb72a6 6770
d5617611
CY
67712011-08-08 Chong Yidong <cyd@stupidchicken.com>
6772
37e11a63
CY
6773 * editfns.c (Fset_time_zone_rule): Document relationship with the
6774 setenv function.
6775
d5617611
CY
6776 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
6777 the font entity extracted from the cache (Bug#8109).
6778
58872834
CY
67792011-08-07 Chong Yidong <cyd@stupidchicken.com>
6780
6781 * composite.c (autocmp_chars): Don't reset point. That is done by
6782 restore_point_unwind (Bug#5984).
6783
75bfc667
JL
67842011-08-07 Juri Linkov <juri@jurta.org>
6785
6786 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
6787 to show the arg `TIME' instead of `TIMEVAL'.
6788
d1410150
EZ
67892011-08-06 Eli Zaretskii <eliz@gnu.org>
6790
6791 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
6792 display property strides EOL and includes a newline, as in
6793 longlines-mode. (Bug#9254)
75b771e4
EZ
6794 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
6795 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
6796
6797 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
6798 is non-zero, even if the data buffer is NULL. Fixes a crash in
6799 vertical-motion with longlines-mode. (Bug#9254)
6800
35928349
EZ
68012011-08-05 Eli Zaretskii <eliz@gnu.org>
6802
ec7cc85b
EZ
6803 * bidi.c <bidi_cache_total_alloc>: Now static.
6804 (bidi_initialize): Initialize bidi_cache_total_alloc.
6805
8b76d6f8 6806 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
6807 cache. (Bug#9221)
6808
6809 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
6810 amount allocated this far in `bidi_cache_total_alloc'.
6811 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
6812 non-zero, only free the data buffer without restoring the cache
6813 contents. All callers changed.
6814
6815 * dispextern.h (bidi_unshelve_cache): Update prototype.
6816
6817 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
6818 (move_it_in_display_line, move_it_to)
6819 (move_it_vertically_backward, move_it_by_lines): Replace the call
6820 to xfree to an equivalent call to bidi_unshelve_cache.
6821 (move_it_in_display_line_to): Fix logic of returning
412b6358 6822 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 6823
e2e2423b
EZ
68242011-08-05 Eli Zaretskii <eliz@gnu.org>
6825
6826 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
6827 came from a string character with a `cursor' property. (Bug#9229)
6828
ae9e757a
JD
68292011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6830
6831 * Makefile.in (LIB_PTHREAD): New variable.
6832 (LIBES): Add LIB_PTHREAD (Bug#9216).
6833
6834 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
6835 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
6836
213bd7f2
AS
68372011-08-04 Andreas Schwab <schwab@linux-m68k.org>
6838
6b02f655 6839 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 6840
99aaf75f
JD
68412011-08-04 Jan Djärv <jan.h.d@swipnet.se>
6842
6843 * xterm.c (x_find_topmost_parent): New function.
6844 (x_set_frame_alpha): Find topmost parent window with
6845 x_find_topmost_parent and set the property there also (bug#9181).
6846 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
6847
c74e9d86
PE
68482011-08-04 Paul Eggert <eggert@cs.ucla.edu>
6849
6850 * callproc.c (Fcall_process): Avoid vfork clobbering
6851 the local vars buffer, coding_systems, current_dir.
6852
640c8776
SM
68532011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
6854
6855 * keymap.c (Fmake_composed_keymap): Move to subr.el.
6856
f26d0e4c
PE
68572011-08-03 Paul Eggert <eggert@cs.ucla.edu>
6858
8a10d76c
PE
6859 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
6860 so that it is not optimized away.
6861
f26d0e4c
PE
6862 * xdisp.c (compute_display_string_pos): Remove unused local.
6863
55439c61
EZ
68642011-08-02 Eli Zaretskii <eliz@gnu.org>
6865
6866 Fix slow cursor motion and scrolling in large buffers with
6867 selective display, like Org Mode buffers. (Bug#9218)
6868
6869 * dispextern.h (struct bidi_it): New member disp_prop_p.
6870
6871 * xdisp.c: Remove one-slot cache of display string positions.
6872 (compute_display_string_pos): Accept an additional argument
5e617bc2 6873 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
6874 for a display string or property. If found, set DISP_PROP_P
6875 non-zero.
6876
6877 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
6878 DISP_PROP_P, and pass it to compute_display_string_pos.
6879 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
6880 non-zero. All callers of bidi_fetch_char changed.
6881
fb33fa43
SM
68822011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
6883
6884 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
6885
b099e063
DM
68862010-12-03 Don March <don@ohspite.net>
6887
6888 * keymap.c (Fdefine_key): Fix non-prefix key error message when
6889 last character M-[char] is translated to ESC [char] (bug#7541).
6890
5cc7f7af
KH
68912011-08-02 Kenichi Handa <handa@m17n.org>
6892
d0fffa3f 6893 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
6894
6895 * chartab.c (uniprop_table): Make it non-static.
6896
525d5e6e
EZ
68972011-08-01 Eli Zaretskii <eliz@gnu.org>
6898
6899 * xdisp.c (forward_to_next_line_start): Accept additional argument
6900 BIDI_IT_PREV, and store into it the state of the bidi iterator had
6901 on the newline.
6902 (reseat_at_next_visible_line_start): Use the bidi iterator state
6903 returned by forward_to_next_line_start to restore the state of
6904 it->bidi_it after backing up to previous newline. (Bug#9212)
6905
31011111
AS
69062011-07-30 Andreas Schwab <schwab@linux-m68k.org>
6907
6908 * regex.c (re_comp): Protoize.
6909 (re_exec): Fix return type.
6910 (regexec): Fix type of `ret'. (Bug#9203)
6911
476371c4
PE
69122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6913
e5d76069
PE
6914 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
6915 This is needed if max-image-size is a floating-point number.
6916
9a79b20c
AS
69172011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6918
6919 * print.c (print_object): Print empty symbol as ##.
6920
6921 * lread.c (read1): Read ## as empty symbol.
6922
d8c2fa78
AA
69232011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
6924
6925 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
6926 setting frame foreground color (Bug#9175).
6927 (x_set_background_color): Likewise.
6928
ffe57a7a
AA
6929 * nsmenu.m (-setText): Size tooltip dimensions precisely to
6930 contents (Bug#9176).
6931 (EmacsTooltip -init): Remove bezels and add shadows to
6932 tooltip windows.
6933
bf3492a5
AA
6934 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
6935 or scroll bar (Bug#8470).
6936
d55e9c53
AA
6937 * nsfont.m (nsfont_open): Remove assignment to voffset and
6938 unnecessary vars hshink, expand, hd, full_height, min_height.
6939 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
6940
6941 * nsterm.h (nsfont_info): Remove voffset field.
6942
d8c2fa78 69432011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
6944
6945 Implement strike-through and overline on NextStep (Bug#8863).
6946
6947 * nsfont.m (nsfont_open): Use underline position provided by font,
6948 instead of hard-coded value of 2.
6949 (nsfont_draw): Call ns_draw_text_decoration instead.
6950
6951 * nsterm.h: Add declaration for ns_draw_text_decoration.
6952
6953 * nsterm.m (ns_draw_text_decoration): New function for drawing
6954 underline, overline, and strike-through.
6955 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
6956 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 6957 accommodate underlining, etc.
4843aac3 6958
4cc60b9b
EZ
69592011-07-28 Eli Zaretskii <eliz@gnu.org>
6960
bc7ece87
EZ
6961 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
6962 default.
4cc60b9b 6963
476371c4
PE
69642011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6965
66606eea
PE
6966 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
6967 Without this fix, if a signal arrives just after memory fills up,
6968 'malloc' might be invoked reentrantly.
6969
476371c4
PE
6970 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
6971 In other words, assume that every image size is allowed, on non-X
6972 hosts. This assumption is probably wrong, but it lets Emacs compile.
6973
f3fcc40d
AS
69742011-07-28 Andreas Schwab <schwab@linux-m68k.org>
6975
6976 * regex.c (re_iswctype): Convert return values to boolean.
6977
350c992f
EZ
69782011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
6979
6980 * xdisp.c (compute_display_string_pos): Don't use cached display
6981 string position if the buffer had its restriction changed.
6982 (Bug#9184)
6983
5266b4bb
PE
69842011-07-28 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6987
2573a837 69882011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 6989
41f55ccd 6990 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 6991
39e378da
PE
6992 * bidi.c: Integer size and overflow fixes.
6993 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
6994 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
6995 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6996 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
6997 (bidi_find_other_level_edge):
6998 Use ptrdiff_t instead of EMACS_INT where either will do.
6999 This works better on 32-bit hosts configured --with-wide-int.
7000 (bidi_cache_ensure_space): Check for size-calculation overflow.
7001 Use % rather than repeated addition, for better worst-case speed.
7002 Don't set bidi_cache_size until after xrealloc returns, because it
7003 might not return.
7004 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
7005 (bidi_cache_ensure_space): Also check that the bidi cache size
7006 does not exceed that of the largest Lisp string or buffer. See Eli
7007 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 7008
5e927815
PE
7009 * alloc.c (__malloc_size_t): Remove.
7010 All uses replaced by size_t. See Andreas Schwab's note
7011 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
7012
ca4aa935
PE
7013 * image.c: Improve checking for integer overflow.
7014 (check_image_size): Assume that f is nonnull, since
7015 it is always nonnull in practice. This is one less thing to
7016 worry about when checking for integer overflow later.
7017 (x_check_image_size): New function, which checks for integer
7018 overflow issues inside X.
7019 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
7020 This removes the need for a memory_full check.
7021 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
7022 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
7023 (xbm_read_bitmap_data): Change locals back to 'int', since
7024 their values must fit in 'int'.
7025 (xpm_load_image, png_load, tiff_load):
7026 Invoke x_create_x_image_and_pixmap earlier,
7027 to avoid much needless work if the image is too large.
7028 (tiff_load): Treat overly large images as if
7029 x_create_x_image_and_pixmap failed, not as malloc failures.
7030 (gs_load): Use x_check_image_size.
7031
5f8f9cc2
PE
7032 * gtkutil.c: Omit integer casts.
7033 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
7034 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
7035
5adf60bc
PE
7036 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
7037
c8907a93
PE
7038 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
7039 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
7040 would wrongly return t on a 64-bit host.
7041
e3c25c68
PE
7042 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
7043 The plain *_OVERFLOW macros run afoul of GCC bug 49705
7044 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
7045 and therefore cause GCC to emit a bogus diagnostic in some cases.
7046
3f791afe
PE
7047 * image.c: Integer signedness and overflow and related fixes.
7048 This is not an exhaustive set of fixes, but it's time to
7049 record what I've got.
7050 (lookup_pixel_color, check_image_size): Remove redundant decls.
7051 (check_image_size): Don't assume that arbitrary EMACS_INT values
7052 fit in 'int', or that arbitrary 'double' values fit in 'int'.
7053 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
7054 (tiff_load, imagemagick_load_image):
7055 Check for overflow in size calculations.
7056 (x_create_x_image_and_pixmap): Remove unnecessary test for
7057 xmalloc returning NULL; that can't happen.
7058 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
7059 (xpm_color_bucket): Use better integer hashing function.
7060 (xpm_cache_color): Don't possibly over-allocate memory.
7061 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
7062 (gif_memory_source):
7063 Use ptrdiff_t, not int or size_t, to record sizes.
7064 (png_load): Don't assume values greater than 2**31 fit in 'int'.
7065 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
7066 either works, as we prefer signed integers.
7067 (tiff_read_from_memory, tiff_write_from_memory):
7068 Return tsize_t, not size_t, since that's what the TIFF API wants.
7069 (tiff_read_from_memory): Don't fail simply because the read would
7070 go past EOF; instead, return a short read.
7071 (tiff_load): Omit no-longer-needed casts.
7072 (Fimagemagick_types): Don't assume size fits into 'int'.
7073
3cc5a532
PE
7074 Improve hashing quality when configured --with-wide-int.
7075 * fns.c (hash_string): New function, taken from sxhash_string.
7076 Do not discard information about ASCII character case; this
7077 discarding is no longer needed.
7078 (sxhash-string): Use it. Change sig to match it. Caller changed.
7079 * lisp.h: Declare it.
7080 * lread.c (hash_string): Remove, since we now use fns.c's version.
7081 The fns.c version returns a wider integer if --with-wide-int is
7082 specified, so this should help the quality of the hashing a bit.
7083
b312a492
PE
7084 * emacs.c: Integer overflow minor fix.
7085 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
7086 Define only if GNU_LINUX.
7087 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
7088
dfd153ae
PE
7089 * dispnew.c: Integer signedness and overflow fixes.
7090 Remove unnecessary forward decls, that were a maintenance hassle.
7091 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
7092 All uses changed.
7093 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
7094 (scrolling_window): Use ptrdiff_t, not int, for byte count.
7095 (prepare_desired_row, line_draw_cost):
7096 Use int, not unsigned, where either works.
7097 (save_current_matrix, restore_current_matrix):
7098 Use ptrdiff_t, not size_t, where either works.
7099 (init_display): Check for overflow more accurately, and without
7100 relying on undefined behavior.
7101
a81d11a3
PE
7102 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
7103 Remove, replacing with the new symbols in lisp.h. All uses changed.
7104 * fileio.c (make_temp_name):
7105 * filelock.c (lock_file_1, lock_file):
7106 * xdisp.c (message_dolog):
7107 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
7108 Use pMd etc. instead.
7109 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
7110 replacing the pWIDE etc. symbols removed from editfns.c.
7111
3300e6fd
PE
7112 * keyboard.h (num_input_events): Now uintmax_t.
7113 This is (very slightly) less likely to mess up due to wraparound.
7114 All uses changed.
7115
fd05c7e9
PE
7116 * buffer.c: Integer signedness fixes.
7117 (alloc_buffer_text, enlarge_buffer_text):
7118 Use ptrdiff_t rather than size_t when either will do, as we prefer
7119 signed integers.
7120
903fe15d
PE
7121 * alloc.c: Integer signedness and overflow fixes.
7122 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
7123 (__malloc_size_t): Default to size_t, not to int.
7124 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
7125 (Fgarbage_collect, mark_object_loop_halt, mark_object):
7126 Prefer ptrdiff_t to size_t when either would do, as we prefer
7127 signed integers.
7128 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
7129 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
7130 Now const. Initialize with values that are in range even if char
7131 is signed.
7132 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
7133 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
7134 These functions do the right thing with sizes > 2**32.
7135 (check_depth): Now ptrdiff_t, not int.
7136 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
7137 Adjust to new way of storing sizes. Check for size overflow bugs
7138 in rest of code.
7139 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
7140 slightly wrong anyway, as it missed one instance of
7141 XMALLOC_OVERRUN_CHECK_OVERHEAD.
7142 (refill_memory_reserve): Omit needless cast to size_t.
7143 (mark_object_loop_halt): Mark as externally visible.
7144
ac82cc6a
PE
7145 * xselect.c: Integer signedness and overflow fixes.
7146 (Fx_register_dnd_atom, x_handle_dnd_message):
7147 Use ptrdiff_t, not size_t, since we prefer signed.
7148 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
7149 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
7150 x_dnd_atoms_size and x_dnd_atoms_length.
7151
c2d1e36d
PE
7152 * doprnt.c: Prefer signed to unsigned when either works.
7153 * eval.c (verror):
7154 * doprnt.c (doprnt):
7155 * lisp.h (doprnt):
7156 * xdisp.c (vmessage):
7157 Use ptrdiff_t, not size_t, when using or implementing doprnt,
7158 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
7159 prefer signed arithmetic to avoid comparison confusion.
7160 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
7161 but is a bit tricky.
7162
0e926e56
PE
7163 Assume freestanding C89 headers, string.h, stdlib.h.
7164 * data.c, doprnt.c, floatfns.c, print.c:
7165 Include float.h unconditionally.
7166 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
7167 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
7168 * regex.c: Likewise for stddef.h, string.h.
7169 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
7170 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
7171 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
7172 (STDC_HEADERS): Remove obsolete defines.
7173 * sysdep.c: Include limits.h unconditionally.
7174
9cfdb3ec
PE
7175 Assume support for memcmp, memcpy, memmove, memset.
7176 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
7177 * regex.c (memcmp, memcpy):
7178 Remove; we assume C89 now.
7179
7180 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
7181 (__malloc_safe_bcopy): Remove; no longer needed.
7182
cf950e6b 7183 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
7184 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
7185 well either way, and we prefer signed to unsigned.
7186
dbf38e02
LMI
71872011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
7188
7189 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
7190 closes the connection while we're reading (bug#9182).
7191
d6f0886c 71922011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 7193
d6f0886c
JD
7194 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
7195 are specified (Bug#9168).
24e0f6b1 7196
2eb1f9e6
PE
71972011-07-25 Paul Eggert <eggert@cs.ucla.edu>
7198
7199 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
7200 Found by GCC static checking and --with-wide-int on a 32-bit host.
7201
22381272 72022011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
7203
7204 * xdisp.c (compute_display_string_pos): Fix logic of caching
7205 previous display string position. Initialize cached_prev_pos to
7206 -1. Fixes slow-down at the beginning of a buffer.
7207
f25e39b4
EZ
72082011-07-24 Eli Zaretskii <eliz@gnu.org>
7209
7210 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
7211 for attrs[LFACE_FONTSET_INDEX].
7212
04c4b52e
PE
72132011-07-23 Paul Eggert <eggert@cs.ucla.edu>
7214
7215 * xml.c (parse_region): Remove unused local
7216 that was recently introduced.
7217
c1734fbd
EZ
72182011-07-23 Eli Zaretskii <eliz@gnu.org>
7219
be18c5a5
EZ
7220 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
7221 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
7222
c1734fbd
EZ
7223 * xdisp.c (move_it_in_display_line_to): Record the best matching
7224 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
7225 exit if none of the characters scanned was an exact match.
7226 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
7227 when exact match is impossible due to invisible text, and the
7228 lines are truncated.
7229
a258d627
JD
72302011-07-23 Jan Djärv <jan.h.d@swipnet.se>
7231
7232 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
7233 for OSX >= 10.7.
7234
b6d5a689
EZ
72352011-07-22 Eli Zaretskii <eliz@gnu.org>
7236
0f74f785
EZ
7237 Fix a significant slow-down of cursor motion with C-n, C-p,
7238 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
7239 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 7240 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
7241 (next_element_from_buffer): Call compute_stop_pos_backwards to
7242 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
7243 base_level_stop.
7244 (reseat): Don't look for prev_stop, as that could mean a very long
7245 run.
7246 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
7247 <cached_disp_overlay_modiff>: Cache for last found display string
7248 position.
551918c1 7249 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
7250 about the same buffer in the same area of character positions, and
7251 the buffer wasn't changed since the time the display string
7252 position was cached.
551918c1 7253
b2d0c91a
EZ
72542011-07-22 Eli Zaretskii <eliz@gnu.org>
7255
7256 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
7257 is an integer, which is important for empty lines. (Bug#9149)
7258
043604ee
CY
72592011-07-22 Chong Yidong <cyd@stupidchicken.com>
7260
7261 * frame.c (Fmodify_frame_parameters): In tty case, update the
7262 default face if necessary (Bug#4238).
7263
da4adb04
CY
72642011-07-21 Chong Yidong <cyd@stupidchicken.com>
7265
7266 * editfns.c (Fstring_to_char): No need to explain what a character
7267 is in the docstring (Bug#6576).
7268
9abd0532
LMI
72692011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7270
7271 * xml.c (parse_region): Make sure we always return a tree.
7272
36881d16
HK
72732011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
7274
7275 * xml.c (parse_region): If a document contains only comments,
7276 return that, too.
7277
1e98674d
LMI
72782011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
7279
7280 * xml.c (make_dom): Return comments, too.
7281
590bd467
PE
72822011-07-19 Paul Eggert <eggert@cs.ucla.edu>
7283
7284 Port to OpenBSD.
7285 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
7286 and the surrounding thread.
7287 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
7288 rather than fgets, and retry after EINTR. Otherwise, 'emacs
7289 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
7290 timer goes off.
7291 * s/openbsd.h (BROKEN_SIGIO): Define.
7292 * unexelf.c (unexec) [__OpenBSD__]:
7293 Don't update the .mdebug section of the Alpha COFF symbol table.
7294
f41628b2
LMI
72952011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7296
7297 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
7298 (bug#8460).
7299
b59b67c5
PE
73002011-07-18 Paul Eggert <eggert@cs.ucla.edu>
7301
15e3a074
PE
7302 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
7303 This fixes some race conditions on the permissions of any newly
7304 created file.
7305
41bed37d
PE
7306 * alloc.c (valid_pointer_p): Use pipe, not open.
7307 This fixes some permissions issues when debugging.
7308
b59b67c5
PE
7309 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
7310 If fchown fails to set both uid and gid, try to set just gid,
7311 as that is sometimes allowed. Adjust the file's mode to eliminate
7312 setuid or setgid bits that are inappropriate if fchown fails.
7313
925a6be7
SM
73142011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
7315
7316 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
7317 to compare Lisp_Objects.
7318 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
7319 global_gnutls_log_level, don't mistake it for a Lisp_Object.
7320 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
7321
52968808
AS
73222011-07-17 Andreas Schwab <schwab@linux-m68k.org>
7323
0a6a104b
AS
7324 * lread.c (read_integer): Unread even EOF character.
7325 (read1): Likewise. Properly record start position of symbol.
7326
52968808
AS
7327 * lread.c (read1): Read `#:' as empty uninterned symbol if no
7328 symbol character follows.
7329
9e381cdd
PE
73302011-07-17 Paul Eggert <eggert@cs.ucla.edu>
7331
7332 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
7333 This works around a problem with the previous change to Fcopy_file.
7334 Recent glibc declares fchown with __attribute__((warn_unused_result)),
7335 and without this change, GCC might complain about discarding
7336 fchown's return value.
7337
b5641435
JB
73382011-07-16 Juanma Barranquero <lekktu@gmail.com>
7339
7340 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
7341
a8031457
PE
73422011-07-16 Paul Eggert <eggert@cs.ucla.edu>
7343
7344 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
7345
dd889327
LMI
73462011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
7347
750c33f7
LMI
7348 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
7349 it's used from the C level.
7350
dd889327
LMI
7351 * process.c: Use the same condition for POLL_FOR_INPUT in both
7352 keyboard.c and process.c (bug#1858).
7353
87e86684
LM
73542011-07-09 Lawrence Mitchell <wence@gmx.li>
7355
7356 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
7357 (Fgnutls_boot): Use it.
7358
64348f40
AS
73592011-07-15 Andreas Schwab <schwab@linux-m68k.org>
7360
7361 * doc.c (Fsubstitute_command_keys): Revert last change.
7362
1d698799
LMI
73632011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
7364
f863868c
LMI
7365 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
7366 quotes the next character, and doesn't affect other longer
7367 sequences (bug#8935).
7368
1d698799
LMI
7369 * lread.c (syms_of_lread): Clarify that is isn't only
7370 `eval-buffer' and `eval-defun' that's affected by
7371 `lexical-binding' (bug#8460).
7372
aa4b6df6
EZ
73732011-07-15 Eli Zaretskii <eliz@gnu.org>
7374
7375 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 7376 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 7377
5d856da6
PE
73782011-07-14 Paul Eggert <eggert@cs.ucla.edu>
7379
ad6042bb
PE
7380 Fix minor problems found by static checking.
7381 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
7382 (elsz): Now a signed constant, not a size_t var. We prefer signed
7383 types to unsigned, to avoid integer comparison confusion. Without
7384 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
7385 "cannot optimize loop, the loop counter may overflow", a symptom
7386 of the confusion.
f00bbb22 7387 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
7388 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
7389
6468f31c
LMI
73902011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7391
49080b10
LMI
7392 * search.c (Fre_search_backward): Mention `case-fold-search' in
7393 all the re_search_* functions (bug#8138).
7394
6468f31c
LMI
7395 * keyboard.c (Fopen_dribble_file): Document when the file is
7396 closed (bug#8056).
7397
c965adc5
EZ
73982011-07-14 Eli Zaretskii <eliz@gnu.org>
7399
df9733bf
EZ
7400 * bidi.c (bidi_dump_cached_states): Fix format of displaying
7401 bidi_cache_idx.
7402
0bb23927
EZ
7403 Support bidi reordering of display and overlay strings.
7404 * xdisp.c (compute_display_string_pos)
7405 (compute_display_string_end): Accept additional argument STRING.
7406 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
7407 (reseat_to_string): Initialize bidi_it->string.s and
7408 bidi_it->string.schars.
7409 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
7410 NULL (avoids a crash in bidi_paragraph_init).
7411 Initialize itb.string.lstring.
0bb23927
EZ
7412 (init_iterator): Call bidi_init_it only of a valid
7413 buffer position was specified. Initialize paragraph_embedding to
7414 L2R.
7415 (reseat_to_string): Initialize the bidi iterator.
7416 (display_string): If we need to ignore text properties of
7417 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
7418 original value of -1 will not work with bidi.)
7419 (compute_display_string_pos): First arg is now struct
7420 `text_pos *'; all callers changed. Support display properties on
7421 Lisp strings.
7422 (compute_display_string_end): Support display properties on Lisp
7423 strings.
7424 (init_iterator, reseat_1, reseat_to_string): Initialize the
7425 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
7426 when iterating on a string not from display properties).
640c8776
SM
7427 (compute_display_string_pos, compute_display_string_end):
7428 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
7429 arrow keys.
7430 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
7431 base_level_stop; instead, set base_level_stop to BEGV.
7432 Fixes crashes in vertical-motion.
0bb23927
EZ
7433 (next_element_from_buffer): Improve commentary for when
7434 the iterator is before prev_stop.
7435 (init_iterator): Initialize bidi_p from the default value of
7436 bidi-display-reordering, not from buffer-local value. Use the
7437 buffer-local value only if initializing for buffer iteration.
7438 (handle_invisible_prop): Support invisible properties on strings
7439 that are being bidi-reordered.
7440 (set_iterator_to_next): Support bidi reordering of C strings and
7441 Lisp strings.
7442 (next_element_from_string): Support bidi reordering of Lisp
7443 strings.
7444 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
7445 (display_string): Support display of R2L glyph rows.
7446 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
7447 (init_iterator): Don't initialize it->bidi_p for strings
7448 here.
7449 (reseat_to_string): Initialize it->bidi_p for strings here.
7450 (next_element_from_string, next_element_from_c_string)
7451 (next_element_from_buffer): Add xassert's for correspondence
7452 between IT's object being iterated and it->bidi_it.string
7453 structure.
7454 (face_before_or_after_it_pos): Support bidi iteration.
7455 (next_element_from_c_string): Handle the case of the first string
7456 character that is not the first one in the visual order.
7457 (get_visually_first_element): New function, refactored from common
7458 parts of next_element_from_buffer, next_element_from_string, and
7459 next_element_from_c_string.
7460 (tool_bar_lines_needed, redisplay_tool_bar)
7461 (display_menu_bar): Force left-to-right direction. Add a FIXME
7462 comment for making that be controlled by a user option.
7463 (push_it, pop_it): Save and restore the state of the
7464 bidi iterator. Save and restore the bidi_p flag.
7465 (pop_it): Iterate out of display property for string iteration as
7466 well.
7467 (iterate_out_of_display_property): Support iteration over strings.
7468 (handle_single_display_spec): Set up it->bidi_it for iteration
7469 over a display string, and call bidi_init_it.
7470 (handle_single_display_spec, next_overlay_string)
7471 (get_overlay_strings_1, push_display_prop): Set up the bidi
7472 iterator for displaying display or overlay strings.
7473 (forward_to_next_line_start): Don't use the shortcut if
7474 bidi-iterating.
7475 (back_to_previous_visible_line_start): If handle_display_prop
7476 pushed the iterator stack, restore the internal state of the bidi
7477 iterator by calling bidi_pop_it same number of times.
7478 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
7479 and we are bidi-iterating, don't decrement the iterator position;
7480 instead, set the first_elt flag in the bidi iterator, to produce
7481 the same effect.
7482 (reseat_1): Remove redundant setting of string_from_display_prop_p.
7483 (push_display_prop): xassert that we are iterating a buffer.
7484 (push_it, pop_it): Save and restore paragraph_embedding member.
7485 (handle_single_display_spec, next_overlay_string)
7486 (get_overlay_strings_1, reseat_1, reseat_to_string)
7487 (push_display_prop): Set up the `unibyte' member of bidi_it.string
7488 correctly. Don't assume unibyte strings are not bidi-reordered.
7489 (compute_display_string_pos)
7490 (compute_display_string_end): Fix handling the case of C string.
7491 (push_it, pop_it): Save and restore from_disp_prop_p.
7492 (handle_single_display_spec, push_display_prop): Set the
7493 from_disp_prop_p flag.
7494 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
7495 (pop_it): Call iterate_out_of_display_property only if we are
7496 popping after iteration over a string that came from a display
7497 property. Fix a typo in popping stretch info. Add an assertion
7498 for verifying that the iterator position is in sync with the bidi
7499 iterator.
7500 (handle_single_display_spec, get_overlay_strings_1)
7501 (push_display_prop): Fix initialization of paragraph direction for
7502 string when that of the parent object is not yet determined.
7503 (reseat_1): Call bidi_init_it to resync the bidi
7504 iterator with IT's position. (Bug#7616)
7505 (find_row_edges): If ROW->start.pos gives position
7506 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
7507 (handle_stop, back_to_previous_visible_line_start, reseat_1):
7508 Reset the from_disp_prop_p flag.
7509 (SAVE_IT, RESTORE_IT): New macros.
7510 (pos_visible_p, face_before_or_after_it_pos)
7511 (back_to_previous_visible_line_start)
7512 (move_it_in_display_line_to, move_it_in_display_line)
7513 (move_it_to, move_it_vertically_backward, move_it_by_lines)
7514 (try_scrolling, redisplay_window, display_line): Use them when
7515 saving a temporary copy of the iterator and restoring it back.
7516 (back_to_previous_visible_line_start, reseat_1)
7517 (init_iterator): Empty the bidi cache "stack".
7518 (move_it_in_display_line_to): If iterator ended up at
7519 EOL, but we never saw any buffer positions smaller than
7520 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
7521 motion in bidi-reordered lines.
7522 (move_it_in_display_line_to): Record prev_method and prev_pos
7523 immediately before the call to set_iterator_to_next. Fixes cursor
7524 motion in bidi-reordered lines with stretch glyphs and strings
7525 displayed in margins. (Bug#8133) (Bug#8867)
7526 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
7527 TO_CHARPOS.
640c8776
SM
7528 (pos_visible_p): Support positions in bidi-reordered lines.
7529 Save and restore bidi cache.
0bb23927
EZ
7530
7531 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
7532 (bidi_paragraph_info): Delete unused struct.
7533 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
7534 (bidi_cache_start): New variable.
7535 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
7536 to zero.
7537 (bidi_cache_fetch_state, bidi_cache_search)
7538 (bidi_cache_find_level_change, bidi_cache_iterator_state)
7539 (bidi_cache_find, bidi_peek_at_next_level)
7540 (bidi_level_of_next_char, bidi_find_other_level_edge)
7541 (bidi_move_to_visually_next): Compare cache index with
7542 bidi_cache_start rather than with zero.
7543 (bidi_fetch_char): Accept new argument STRING; all callers
7544 changed. Support iteration over a string. Support strings with
7545 display properties. Support unibyte strings. Fix the type of
7546 `len' according to what STRING_CHAR_AND_LENGTH expects.
7547 (bidi_paragraph_init, bidi_resolve_explicit_1)
7548 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
7549 (bidi_level_of_next_char, bidi_move_to_visually_next):
7550 Support iteration over a string.
0bb23927
EZ
7551 (bidi_set_sor_type, bidi_resolve_explicit_1)
7552 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
7553 can now be zero (for strings); special values 0 and -1 were
7554 changed to -1 and -2, respectively.
7555 (bidi_char_at_pos): New function.
7556 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
7557 Call it instead of FETCH_MULTIBYTE_CHAR.
7558 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
7559 initialized to valid values.
7560 (bidi_init_it): Don't initialize charpos and bytepos with invalid
7561 values.
7562 (bidi_level_of_next_char): Allow the sentinel "position" to pass
7563 the test for valid cached positions. Fix the logic for looking up
7564 the sentinel state in the cache. GCPRO the Lisp string we are
7565 iterating.
7566 (bidi_push_it, bidi_pop_it): New functions.
7567 (bidi_initialize): Initialize the bidi cache start stack pointer.
7568 (bidi_cache_ensure_space): New function, refactored from part of
7569 bidi_cache_iterator_state. Don't assume the required size is just
7570 one BIDI_CACHE_CHUNK away.
7571 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
7572 (bidi_count_bytes, bidi_char_at_pos): New functions.
7573 (bidi_cache_search): Don't assume bidi_cache_last_idx is
7574 always valid if bidi_cache_idx is valid.
7575 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
7576 is valid if it's going to be used.
7577 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
7578 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
7579 (bidi_cache_find_level_change, bidi_cache_ensure_space)
7580 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
7581 (bidi_find_other_level_edge, bidi_cache_start_stack):
7582 All variables related to cache indices are now EMACS_INT.
c965adc5 7583
0bb23927
EZ
7584 * dispextern.h (struct bidi_string_data): New structure.
7585 (struct bidi_it): New member `string'. Make flag members be 1-bit
7586 fields, and put them last in the struct.
640c8776
SM
7587 (compute_display_string_pos, compute_display_string_end):
7588 Update prototypes.
0bb23927
EZ
7589 (bidi_push_it, bidi_pop_it): Add prototypes.
7590 (struct iterator_stack_entry): New members bidi_p,
7591 paragraph_embedding, and from_disp_prop_p.
7592 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
7593 (bidi_shelve_cache, bidi_unshelve_cache):
7594 Declare prototypes.
0bb23927
EZ
7595
7596 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
7597 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
7598 and vector-like objects.
7599
7600 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
7601 cache around display iteration.
7602
7603 * window.c (Fwindow_end, window_scroll_pixel_based)
7604 (displayed_window_lines, Frecenter): Save and restore the bidi
7605 cache around display iteration.
7606
3bbd2265
LMI
76072011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
7608
7609 * editfns.c (Fdelete_region): Clarify the use of the named
7610 parameters (bug#6788).
7611
adc47434
MR
76122011-07-14 Martin Rudalics <rudalics@gmx.at>
7613
7614 * indent.c (Fvertical_motion): Set and restore w->pointm when
7615 saving and restoring the window's buffer (Bug#9006).
7616
837c31f8
LMI
76172011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
7618
7619 * editfns.c (Fstring_to_char): Clarify just what is returned
7620 (bug#6576). Text by Eli Zaretskii.
7621
ac389d0c
JB
76222011-07-13 Juanma Barranquero <lekktu@gmail.com>
7623
7624 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
7625
0be0ce47
EZ
76262011-07-13 Eli Zaretskii <eliz@gnu.org>
7627
7628 * buffer.c (mmap_find): Fix a typo.
7629
cd18e7e3
JB
76302011-07-13 Johan Bockgård <bojohan@gnu.org>
7631
7632 Fix execution of x selection hooks.
7633 * xselect.c (Qx_lost_selection_functions)
7634 (Qx_sent_selection_functions): New vars.
7635 (syms_of_xselect): DEFSYM them.
7636 (x_handle_selection_request): Pass Qx_sent_selection_functions
7637 rather than Vx_sent_selection_functions to Frun_hook_with_args.
7638 (x_handle_selection_clear,x_clear_frame_selections):
7639 Pass Qx_lost_selection_functions rather than
7640 Vx_lost_selection_functions to Frun_hook_with_args.
7641
47ea7f44
PE
76422011-07-13 Paul Eggert <eggert@cs.ucla.edu>
7643
ac389d0c 7644 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
7645 The old code sometimes used this field without initializing it.
7646
47ea7f44
PE
7647 * alloc.c (gc_sweep): Don't read past end of array.
7648 In theory, the old code could also have corrupted Emacs internals,
7649 though it'd be very unlikely.
7650
bc985c87
AS
76512011-07-12 Andreas Schwab <schwab@linux-m68k.org>
7652
7653 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 7654 argument. (Bug#4026)
bc985c87 7655
0cf34688
LMI
76562011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
7657
b3dadd76
LMI
7658 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
7659 key" (bug#4257).
7660
0cf34688
LMI
7661 * window.c (Fset_window_start): Doc fix (bug#4199).
7662 (Fset_window_hscroll): Ditto.
7663
270768cd
PE
76642011-07-12 Paul Eggert <eggert@cs.ucla.edu>
7665
077e3dda 7666 Fix minor new problems caught by GCC 4.6.1.
270768cd 7667 * term.c (init_tty): Remove unused local.
490011a6 7668 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 7669 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 7670 not used otherwise.
270768cd 7671
b1f58454
CY
76722011-07-12 Chong Yidong <cyd@stupidchicken.com>
7673
7674 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
7675
22b9578d
LMI
76762011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7677
6e70ab07
LMI
7678 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
7679 are the mini-buffer and the echo area (bug#3320).
7680
22b9578d
LMI
7681 * term.c (init_tty): Remove support for supdup, c10 and perq
7682 terminals, which are no longer supported (bug#1482).
7683
8974cc9f
JB
76842011-07-10 Johan Bockgård <bojohan@gnu.org>
7685
7686 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
7687
a560d974
JD
76882011-07-10 Jan Djärv <jan.h.d@swipnet.se>
7689
7690 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
7691 for non-popups (Bug#3642).
7692
1dae0f0a
AS
76932011-07-10 Andreas Schwab <schwab@linux-m68k.org>
7694
268c2c36 7695 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 7696 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
7697 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
7698 * cm.c (losecursor): Likewise.
1dae0f0a
AS
7699 * data.c (fmod): Likewise.
7700 * dispnew.c (swap_glyphs_in_rows): Likewise.
7701 * emacs.c (memory_warning_signal): Likewise.
7702 * floatfns.c (float_error): Likewise.
7703 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
7704 (otf_open, font_otf_capability, generate_otf_features)
7705 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
7706 Likewise.
7707 * image.c (pbm_read_file): Likewise.
7708 * indent.c (string_display_width): Likewise.
7709 * intervals.c (check_for_interval, search_for_interval)
7710 (inc_interval_count, count_intervals, root_interval)
7711 (adjust_intervals_for_insertion, make_new_interval): Likewise.
7712 * lread.c (defalias): Likewise.
268c2c36 7713 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
7714 * regex.c (set_image_of_range_1, set_image_of_range)
7715 (regex_grow_registers): Likewise.
7716 * sysdep.c (strerror): Likewise.
7717 * termcap.c (valid_filename_p, tprint, main): Likewise.
7718 * tparam.c (main): Likewise.
7719 * unexhp9k800.c (run_time_remap, save_data_space)
7720 (update_file_ptrs, read_header, write_header, calculate_checksum)
7721 (copy_file, copy_rest, display_header): Likewise.
7722 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
7723 Likewise.
7724 * xdisp.c (check_it): Likewise.
7725 * xfaces.c (register_color, unregister_color, unregister_colors):
7726 Likewise.
7727 * xfns.c (print_fontset_result): Likewise.
7728 * xrdb.c (member, fatal, main): Likewise.
7729
99033785
PE
77302011-07-10 Paul Eggert <eggert@cs.ucla.edu>
7731
7732 Fix minor problems found by static checking (Bug#9031).
7733 * chartab.c (char_table_set_range, map_sub_char_table):
7734 Remove unused locals.
7735 (uniprop_table): Now static.
7736 * composite.c (_work_char): Remove unused static var.
7737
9cb2ac56
JB
77382011-07-09 Juanma Barranquero <lekktu@gmail.com>
7739
7740 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
7741
f25661f0
JD
77422011-07-09 Jan Djärv <jan.h.d@swipnet.se>
7743
7744 * gtkutil.c (qttip_cb): Remove code without function.
7745
8278c4fe
EZ
77462011-07-09 Eli Zaretskii <eliz@gnu.org>
7747
7748 * w32.c (pthread_sigmask): New stub.
7749
1692ae2d 77502011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 7751
8a6ebd58 7752 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
7753 sigprocmask is portable only for single-threaded applications, and
7754 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
7755 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
7756 (LIBES): Use it.
7757 * callproc.c (Fcall_process):
7758 * process.c (create_process):
7759 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
7760 Use pthread_sigmask, not sigprocmask.
123403e4 7761
1b854618
JD
77622011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7763
7764 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
7765 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
7766 wrong (Bug#8591).
7767
3fe4b549
JD
77682011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7769
0ce7e563
JD
7770 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
7771 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
7772 (xg_hide_tooltip): Fix comment.
7773
3fe4b549
JD
7774 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
7775 in registerServicesMenuSendTypes.
7776 (validRequestorForSendType): Don't check ns_return_types.
7777
7778 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
7779 ns_return_type.
7780
5df75e47
JR
77812011-07-08 Jason Rumney <jasonr@gnu.org>
7782
22610910
JR
7783 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
7784 SH_SHOW for hidden windows (Bug#5482).
7785
5df75e47
JR
7786 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
7787 frame struct members of non-existent frames (Bug#6284).
7788
699c10bd
JD
77892011-07-08 Jan Djärv <jan.h.d@swipnet.se>
7790
4393663b
JD
7791 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
7792 variable firstTime not needed on OSX >= 10.6.
7793 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
7794 >= 10.5. Use setKnobProportion, setDoubleValue.
7795
7796 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
7797 (MAC_OS_X_VERSION_10_5): Define if not defined.
7798 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
7799 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
7800 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
7801
7802 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 7803 cString and lossyCString on OSX >= 10.4.
4393663b 7804
58179cce 7805 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
7806 sizeToFit on OSX >= 10.2.
7807
7808 * nsimage.m (allocInitFromFile): Don't use deprecated method
7809 bestRepresentationForDevice on OSX >= 10.6.
7810
7811 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
7812 to avoid warning.
7813
7814 * emacs.c: Declare unexec_init_emacs_zone.
7815
a63e0781
JD
7816 * nsgui.h: Fix compiler warning about gnulib redefining verify.
7817
699c10bd
JD
7818 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
7819
7820 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
7821 on svcsMenu (Bug#8842).
7822
7823 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
7824 ns_return_types.
7825 (Fns_list_services): Just return Qnil on 10.6, code not working there.
7826
7827 * nsterm.m (QUTF8_STRING): Declare.
7828 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
7829 (validRequestorForSendType): Return type is (id).
7830 Change indexOfObjectIdenticalTo to indexOfObject.
7831 Check if we have local selection before returning self (Bug#8842).
7832 (writeSelectionToPasteboard): Put local selection into paste board
7833 if we have a local selection (Bug#8842).
7834 (syms_of_nsterm): DEFSYM QUTF8_STRING.
7835
7836 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
7837 (ns_get_local_selection): Declare.
7838
54e10184
LMI
78392011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
7840
9888ff71
LMI
7841 * keymap.c (describe_map_tree): Don't insert a double newline at
7842 the end of the buffer (bug#1169) and return whether we inserted
7843 something.
7844
54e10184
LMI
7845 * callint.c (Fcall_interactively): Change "reading args" to
7846 "providing args" to try to clarify what it does (bug#1010).
7847
15fa4783
KH
78482011-07-07 Kenichi Handa <handa@m17n.org>
7849
7850 * composite.c (composition_compute_stop_pos): Ignore a static
7851 composition starting before CHARPOS (Bug#8915).
7852
7853 * xdisp.c (handle_composition_prop): Likewise.
7854
a8815b00
EZ
78552011-07-07 Eli Zaretskii <eliz@gnu.org>
7856
7857 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
7858 (Bug#9015)
7859
ef7b981d 78602011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
7861
7862 * character.h (unicode_category_t): New enum type.
7863
7864 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
7865 (Qchar_code_property_table): New variable.
7866 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
7867 (UNIPROP_COMPRESSED_FORM_P): New macros.
7868 (char_table_ascii): Uncompress the compressed values.
7869 (sub_char_table_ref): New arg is_uniprop. Callers changed.
7870 Uncompress the compressed values.
ac389d0c 7871 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
7872 (char_table_ref_and_range): Uncompress the compressed values.
7873 (sub_char_table_set): New arg is_uniprop. Callers changed.
7874 Uncompress the compressed values.
7875 (sub_char_table_set_range): Args changed. Callers changed.
7876 (char_table_set_range): Adjuted for the above change.
7877 (map_sub_char_table): Delete args default_val and parent. Add arg
7878 top. Give decoded values to a Lisp function.
640c8776 7879 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
7880 values to a Lisp function. Gcpro more variables.
7881 (uniprop_table_uncompress)
7882 (uniprop_decode_value_run_length): New functions.
7883 (uniprop_decoder, uniprop_decoder_count): New variables.
7884 (uniprop_get_decoder, uniprop_encode_value_character)
7885 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
7886 New functions.
7887 (uniprop_encoder, uniprop_encoder_count): New variables.
7888 (uniprop_get_encoder, uniprop_table)
7889 (Funicode_property_table_internal, Fget_unicode_property_internal)
7890 (Fput_unicode_property_internal): New functions.
7891 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
7892 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 7893 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
7894 char-code-property-alist.
7895
640c8776 7896 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
7897 Vunicode_category_table.
7898
640c8776 7899 * font.c (font_range): Adjust for the change of
c805dec0
KH
7900 Vunicode_category_table.
7901
76b397fb
DN
79022011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
7903
7904 * m/iris4d.h: Remove file, move contents ...
7905 * s/irix6-5.h: ... here.
7906
22b4128e
PE
79072011-07-06 Paul Eggert <eggert@cs.ucla.edu>
7908
7909 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
7910 * alloc.c (mark_buffer):
7911 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
7912 (clone_per_buffer_values): Don't assume that
22b4128e
PE
7913 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
7914 This isn't true in general, and it's particularly not true
7915 if Emacs is configured with --with-wide-int.
7916 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
7917 New macros, used in the buffer.c change.
7918
869795d6
JD
79192011-07-05 Jan Djärv <jan.h.d@swipnet.se>
7920
7921 * xsettings.c: Use both GConf and GSettings if both are available.
7922 (store_config_changed_event): Add comment.
7923 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
7924 (store_tool_bar_style_changed): New functions.
5e617bc2 7925 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
7926 (struct xsettings): Move font inside HAVE_XFT.
7927 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 7928 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 7929 Move inside HAVE_XFT.
640c8776 7930 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
7931 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
7932 also.
7933 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 7934 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 7935 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
7936 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
7937 (parse_settings): Move check for font inside HAVE_XFT.
7938 (read_settings, apply_xft_settings): Add comment.
7939 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
7940 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
7941 call store_font_name_changed.
7942 (xft_settings_event): Add comment.
7943 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
7944 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
7945 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
7946 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
7947 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
7948 (xsettings_get_system_font, xsettings_get_system_normal_font):
7949 Add comment.
869795d6 7950
d8ed26bd
PE
79512011-07-05 Paul Eggert <eggert@cs.ucla.edu>
7952
7953 Random fixes. E.g., (random) never returned negative values.
7954 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
7955 subseconds part to the entropy, as that's a bit more random.
7956 Prefer signed to unsigned, since the signedness doesn't matter and
7957 in general we prefer signed. When given a limit, use a
7958 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
7959 latter isn't right if USE_2_TAGS_FOR_INTS.
7960 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
7961 not 0..VALMASK. Don't discard "excess" bits that random () returns.
7962
cabf1cac
SM
79632011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
7964
7965 * textprop.c (text_property_stickiness):
7966 Obey Vtext_property_default_nonsticky.
7967 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
7968 * w32fns.c (syms_of_w32fns):
7969 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
7970
6e9b2be9
PE
79712011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7972
7973 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
7974 This is more efficient than Ffile_directory_p and avoids a minor race.
7975
90186c68
LMI
79762011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
7977
7c301272
LMI
7978 * buffer.c (Foverlay_put): Say what the return value is
7979 (bug#7835).
7980
c4f2d8d4
LMI
7981 * fileio.c (barf_or_query_if_file_exists): Check first if the file
7982 is a directory before asking whether to use the file name
7983 (bug#7564).
ad637907
LMI
7984 (barf_or_query_if_file_exists): Make the "File is a directory"
7985 error be more correct.
c4f2d8d4 7986
90186c68
LMI
7987 * fns.c (Frequire): Remove the mention of the .gz files, since
7988 that's installation-specific, but keep the mention of
7989 `get-load-suffixes'.
7990
da64016e
PE
79912011-07-04 Paul Eggert <eggert@cs.ucla.edu>
7992
7993 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
7994 Report string overflow if the output is too long.
7995
7d47b580
JB
79962011-07-04 Juanma Barranquero <lekktu@gmail.com>
7997
a555cb87
JB
7998 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
7999 (syms_of_gnutls): Remove duplicate DEFSYM for
8000 Qgnutls_bootprop_verify_hostname_error, an error for
8001 Qgnutls_bootprop_verify_error (which is no longer used).
8002
7d47b580
JB
8003 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
8004 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
8005 Also (re)move comments that are misplaced or no longer relevant.
8006
1e49bfab
LMI
80072011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8008
8009 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
8010
1485f4c0
CY
80112011-07-03 Chong Yidong <cyd@stupidchicken.com>
8012
8013 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
8014 and background color parameters if they have been changed.
8015
a9ab721e
LMI
80162011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8017
8018 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
8019
cf7cff57
PE
80202011-07-03 Paul Eggert <eggert@cs.ucla.edu>
8021
2e13213d
PE
8022 * xsettings.c (SYSTEM_FONT): Define only when used.
8023 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
8024
cf7cff57
PE
8025 * keymap.c (access_keymap_1): Now static.
8026
7a8e04f7
CY
80272011-07-02 Chong Yidong <cyd@stupidchicken.com>
8028
8029 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
8030 leave any prefix arg for the up event (Bug#1586).
8031
61352f62
LMI
80322011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
8033
69bb1ef7
LMI
8034 * lread.c (syms_of_lread): Mention single symbols defined by
8035 `defvar' or `defconst' (bug#7154).
8036
61352f62 8037 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 8038 (Frequire): Mention get-load-suffixes.
61352f62 8039
28545e04
MR
80402011-07-02 Martin Rudalics <rudalics@gmx.at>
8041
8042 * window.h (window): Remove clone_number slot.
8043 * window.c (Fwindow_clone_number, Fset_window_clone_number):
8044 Remove.
8045 (make_parent_window, make_window, saved_window)
8046 (Fset_window_configuration, save_window_save): Don't deal with
8047 clone numbers.
8048 * buffer.c (Qclone_number): Remove declaration.
8049 (sort_overlays, overlay_strings): Don't deal with clone numbers.
8050
3349e122
SM
80512011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
8052
8053 Add multiple inheritance to keymaps.
8054 * keymap.c (Fmake_composed_keymap): New function.
8055 (Fset_keymap_parent): Simplify.
8056 (fix_submap_inheritance): Remove.
8057 (access_keymap_1): New function extracted from access_keymap to handle
8058 embedded parents and handle lists of maps.
8059 (access_keymap): Use it.
8060 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
8061 (Fcopy_keymap): Handle embedded parents.
8062 (Fcommand_remapping, define_as_prefix): Simplify.
8063 (Fkey_binding): Simplify.
8064 (syms_of_keymap): Move minibuffer-local-completion-map,
8065 minibuffer-local-filename-completion-map,
8066 minibuffer-local-must-match-map, and
8067 minibuffer-local-filename-must-match-map to Elisp.
8068 (syms_of_keymap): Defsubr make-composed-keymap.
8069 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
8070 (parse_menu_item): Trivial simplification.
8071
3279eb87
GM
80722011-07-01 Glenn Morris <rgm@gnu.org>
8073
8074 * Makefile.in (SETTINGS_LIBS): Fix typo.
8075
4550efdf
KI
80762011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
8077
8078 * coding.c (Fencode_coding_string): Record the last coding system
8079 used, as the function doc string says (bug#8738).
8080
0949d2b6
JD
80812011-07-01 Jan Djärv <jan.h.d@swipnet.se>
8082
8083 * xsettings.c (store_monospaced_changed): Take new font as arg and
8084 check for change against current_mono_font.
8085 (EMACS_TYPE_SETTINGS): Remove this and related defines.
8086 (emacs_settings_constructor, emacs_settings_get_property)
8087 (emacs_settings_set_property, emacs_settings_class_init)
8088 (emacs_settings_init, gsettings_obj): Remove.
8089 (something_changedCB): New function for HAVE_GSETTINGS.
8090 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
8091 with value as argument.
8092 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
8093 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 8094 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
8095 "changed".
8096
8097 * xgselect.c: Add defined (HAVE_GSETTINGS).
8098 (xgselect_initialize): Ditto.
8099
8100 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
8101 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
8102 xg_select.
8103
bbc6b304
PE
81042011-07-01 Paul Eggert <eggert@cs.ucla.edu>
8105
8106 * eval.c (struct backtrace): Simplify and port the data structure.
8107 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
8108 signed bit field, as this assumption is not portable and it makes
8109 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
8110 "char debug_on_exit : 1" as this is not portable either; instead,
8111 use the portable "unsigned int debug_on_exit : 1". Remove unused
8112 member evalargs. Remove obsolete comments about cc bombing out.
8113
9851bfc5
JD
81142011-06-30 Jan Djärv <jan.h.d@swipnet.se>
8115
51bb811f 8116 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
8117 Let HAVE_GSETTINGS override HAVE_GCONF.
8118 (store_monospaced_changed): New function.
8119 (EMACS_SETTINGS): A new type derived from GObject to handle
8120 GSettings notifications.
8121 (emacs_settings_constructor, emacs_settings_get_property)
8122 (emacs_settings_set_property, emacs_settings_class_init):
8123 New functions.
8124 (gsettings_client, gsettings_obj): New variables.
8125 (GSETTINGS_SCHEMA): New define.
8126 (something_changedCB): Call store_monospaced_changed.
8127 (init_gsettings): New function.
8128 (xsettings_initialize): Call init_gsettings.
8129 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
8130 to NULL.
8131
640c8776 8132 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
8133 GCONF_CFLAGS/LIBS.
8134
5386012d
MR
81352011-06-29 Martin Rudalics <rudalics@gmx.at>
8136
8137 * window.c (resize_root_window, grow_mini_window)
8138 (shrink_mini_window): Rename Qresize_root_window to
8139 Qwindow_resize_root_window and Qresize_root_window_vertically to
8140 Qwindow_resize_root_window_vertically.
8141
f13e0b08
PE
81422011-06-28 Paul Eggert <eggert@cs.ucla.edu>
8143
8144 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
8145
94515237
JB
81462011-06-27 Juanma Barranquero <lekktu@gmail.com>
8147
8148 * makefile.w32-in: Redesign dependencies so they reflect more
8149 clearly which files are directly included by each source file,
8150 and not through other includes.
8151
e43b6e43
MR
81522011-06-27 Martin Rudalics <rudalics@gmx.at>
8153
8154 * buffer.c (Qclone_number): Declare static and DEFSYM it.
8155 (sort_overlays, overlay_strings): When an overlay's clone number
8156 matches the window's clone number process the overlay even if
8157 the overlay's window property doesn't match the current window.
8158
d68443dc
MR
8159 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
8160 (Fwindow_hchild): Rename to Fwindow_left_child.
8161 (Fwindow_next): Rename to Fwindow_next_sibling.
8162 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
8163 (resize_window_check): Rename to window_resize_check.
8164 (resize_window_apply): Rename to window_resize_apply.
8165 (Fresize_window_apply): Rename to Fwindow_resize_apply.
8166 (Fdelete_other_windows_internal, resize_frame_windows)
8167 (Fsplit_window_internal, Fdelete_window_internal)
8168 (grow_mini_window, shrink_mini_window)
8169 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 8170
c7e73be5
JD
81712011-06-26 Jan Djärv <jan.h.d@swipnet.se>
8172
8173 * emacsgtkfixed.h: State that this is only used with Gtk+3.
8174 (emacs_fixed_set_min_size): Remove.
8175 (emacs_fixed_new): Take frame as argument.
8176
8177 * emacsgtkfixed.c: State that this is only used with Gtk+3.
8178 (_EmacsFixedPrivate): Remove minwidth/height.
8179 Add struct frame *f.
8180 (emacs_fixed_init): Initialize priv->f.
8181 (get_parent_class, emacs_fixed_set_min_size): Remove.
8182 (emacs_fixed_new): Set priv->f to argument.
8183 (emacs_fixed_get_preferred_width)
8184 (emacs_fixed_get_preferred_height): Use min_width/height from
8185 frames size_hint to set minimum and natural (Bug#8919).
8186 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
8187 and use min_width/height from frames size_hint to set
8188 min_width/height (Bug#8919).
8189
8190 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
8191 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
8192 Fix indentation.
c7e73be5 8193
cf99dcf8
EZ
81942011-06-26 Eli Zaretskii <eliz@gnu.org>
8195
8196 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
8197 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
8198 called at ZV.
8199
029529ac
CY
82002011-06-26 Chong Yidong <cyd@stupidchicken.com>
8201
8202 * process.c (wait_reading_process_output): Bypass select if
8203 waiting for a cell while ignoring keyboard input, and input is
8204 pending. Suggested by Jan Djärv (Bug#8869).
8205
7a7ef429
PE
82062011-06-25 Paul Eggert <eggert@cs.ucla.edu>
8207
8208 Use gnulib's dup2 module instead of rolling our own.
8209 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
8210
11fdef7d 82112011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
8212
8213 * dispnew.c (scrolling_window): Before scrolling, turn off a
8214 mouse-highlight in the window being scrolled.
8215
cd3520a4
JB
82162011-06-24 Juanma Barranquero <lekktu@gmail.com>
8217
8218 Move DEFSYM to lisp.h and use everywhere.
8219
8220 * character.h (DEFSYM): Move declaration...
8221 * lisp.h (DEFSYM): ...here.
8222
8223 * gnutls.c:
8224 * minibuf.c:
8225 * w32menu.c:
8226 * w32proc.c:
8227 * w32select.c: Don't include character.h.
8228
8229 * alloc.c (syms_of_alloc):
8230 * buffer.c (syms_of_buffer):
8231 * bytecode.c (syms_of_bytecode):
8232 * callint.c (syms_of_callint):
8233 * casefiddle.c (syms_of_casefiddle):
8234 * casetab.c (init_casetab_once):
8235 * category.c (init_category_once, syms_of_category):
8236 * ccl.c (syms_of_ccl):
8237 * cmds.c (syms_of_cmds):
8238 * composite.c (syms_of_composite):
8239 * dbusbind.c (syms_of_dbusbind):
8240 * dired.c (syms_of_dired):
8241 * dispnew.c (syms_of_display):
8242 * doc.c (syms_of_doc):
8243 * editfns.c (syms_of_editfns):
8244 * emacs.c (syms_of_emacs):
8245 * eval.c (syms_of_eval):
8246 * fileio.c (syms_of_fileio):
8247 * fns.c (syms_of_fns):
8248 * frame.c (syms_of_frame):
8249 * fringe.c (syms_of_fringe):
8250 * insdel.c (syms_of_insdel):
8251 * keymap.c (syms_of_keymap):
8252 * lread.c (init_obarray, syms_of_lread):
8253 * macros.c (syms_of_macros):
8254 * msdos.c (syms_of_msdos):
8255 * print.c (syms_of_print):
8256 * process.c (syms_of_process):
8257 * search.c (syms_of_search):
8258 * sound.c (syms_of_sound):
8259 * syntax.c (init_syntax_once, syms_of_syntax):
8260 * terminal.c (syms_of_terminal):
8261 * textprop.c (syms_of_textprop):
8262 * undo.c (syms_of_undo):
8263 * w32.c (globals_of_w32):
8264 * window.c (syms_of_window):
8265 * xdisp.c (syms_of_xdisp):
8266 * xfaces.c (syms_of_xfaces):
8267 * xfns.c (syms_of_xfns):
8268 * xmenu.c (syms_of_xmenu):
8269 * xsettings.c (syms_of_xsettings):
8270 * xterm.c (syms_of_xterm): Use DEFSYM.
8271
4228cf16
TZ
82722011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
8273
cd3520a4 8274 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 8275
7fcccf1e
PE
82762011-06-23 Paul Eggert <eggert@cs.ucla.edu>
8277
7efb4e0e
PE
8278 Integer and buffer overflow fixes (Bug#8873).
8279
ff5844ad
PE
8280 * print.c (printchar, strout): Check for string overflow.
8281 (PRINTPREPARE, printchar, strout):
8282 Don't set size unless allocation succeeds.
8283
90532f02
PE
8284 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
8285 for sizes. Check for string overflow more accurately.
8286 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
8287
6d84508d
PE
8288 * macros.c: Integer and buffer overflow fixes.
8289 * keyboard.h (struct keyboard.kbd_macro_bufsize):
8290 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
8291 Use ptrdiff_t, not int, for sizes.
8292 Don't increment bufsize until after realloc succeeds.
8293 Check for size-calculation overflow.
8294 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
8295
437b2cb4
PE
8296 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
8297
8b9ac8b4
PE
8298 * lread.c: Integer overflow fixes.
8299 (read_integer): Radix is now EMACS_INT, not int,
8300 to improve quality of diagnostics for out-of-range radices.
8301 Calculate buffer size correctly for out-of-range radices.
8302 (read1): Check for integer overflow in radices, and in
8303 read-circle numbers.
82cb60d3
PE
8304 (read_escape): Avoid int overflow.
8305 (Fload, openp, read_buffer_size, read1)
8306 (substitute_object_recurse, read_vector, read_list, map_obarray):
8307 Use ptrdiff_t, not int, for sizes.
8308 (read1): Use EMACS_INT, not int, for sizes.
20270765 8309 Check for size overflow.
8b9ac8b4 8310
7fcccf1e
PE
8311 * image.c (cache_image): Check for size arithmetic overflow.
8312
bfbbd7e7
PE
8313 * lread.c: Integer overflow issues.
8314 (saved_doc_string_size, saved_doc_string_length)
8315 (prev_saved_doc_string_size, prev_saved_doc_string_length):
8316 Now ptrdiff_t, not int.
8317 (read1): Don't assume doc string length fits in int. Check for
8318 out-of-range doc string lengths.
8319 (read_list): Don't assume file position fits in int.
39019e54 8320 (read_escape): Check for hex character overflow.
bfbbd7e7 8321
4e323265
LL
83222011-06-22 Leo Liu <sdl.web@gmail.com>
8323
8324 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
8325 Move to minibuffer.el.
8326
85fece3e
PE
83272011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8328
20b84ce9 8329 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
8330 The following patches are for when GLYPH_DEBUG && !XASSERT.
8331 * dispextern.h (trace_redisplay_p, dump_glyph_string):
8332 * dispnew.c (flush_stdout):
8333 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
8334 Mark as externally visible.
8335 * dispnew.c (check_window_matrix_pointers): Now static.
8336 * dispnew.c (window_to_frame_vpos):
8337 * xfns.c (unwind_create_frame):
8338 * xterm.c (x_check_font): Remove unused local.
8339 * scroll.c (CHECK_BOUNDS):
8340 * xfaces.c (cache_fache): Rename local to avoid shadowing.
8341 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
8342 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
8343 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
8344 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
8345 Now static.
8346 (debug_method_add): Use va_list and vsprintf rather than relying
8347 on undefined behavior with wrong number of arguments.
8348 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
8349 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
8350 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
8351 since we're not interested in debugging glyphs with old libraries.
8352 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
8353 GCC 4.6.0's static checking.
8354
0766b489
PE
83552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
8356
31fd4b32
PE
8357 Integer overflow and signedness fixes (Bug#8873).
8358 A few related buffer overrun fixes, too.
8359
b79e8648
PE
8360 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
8361
0766b489
PE
8362 * dispextern.h (struct face.stipple):
8363 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
8364 (x_bitmap_mask, x_allocate_bitmap_record)
8365 (x_create_bitmap_from_data, x_create_bitmap_from_file)
8366 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
8367 (x_create_bitmap_from_xpm_data):
8368 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
8369 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
8370 (.bitmaps_last):
8371 * xfaces.c (load_pixmap):
8372 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
8373 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
8374 (.bitmaps_last, struct x_output.icon_bitmap):
8375 Use ptrdiff_t, not int, for bitmap indexes.
8376 (x_allocate_bitmap_record): Check for size overflow.
8377 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
8378
b081724f
PE
8379 Use ptrdiff_t, not int, for overlay counts.
8380 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
8381 * editfns.c (overlays_around, get_pos_property):
8382 * textprop.c (get_char_property_and_overlay):
8383 * xdisp.c (next_overlay_change, note_mouse_highlight):
8384 * xfaces.c (face_at_buffer_position):
21514da7
PE
8385 * buffer.c (OVERLAY_COUNT_MAX): New macro.
8386 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
8387 (Fnext_overlay_change, Fprevious_overlay_change)
8388 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 8389 Use ptrdiff_t, not int, for sizes.
21514da7 8390 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 8391
3de73e5e
PE
8392 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
8393
2606c57b
PE
8394 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
8395 (x_session_initialize): Do not assume string length fits in int.
8396
aaafe47a
PE
8397 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
8398 This is unlikely, but can occur if DPI is outlandish.
8399
2674ddc8 8400 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
8401 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
8402
28154962
PE
8403 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
8404 * xrdb.c (magic_file_p, search_magic_path):
8405 Omit last arg SUFFIX; it was always 0. All callers changed.
8406 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
8407
7de51af5
PE
8408 * xfont.c (xfont_match): Avoid need for strlen.
8409
25ed6cc3
PE
8410 * xfns.c: Don't assume strlen fits in int.
8411 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
8412
4eab31dd
PE
8413 * xdisp.c (message_log_check_duplicate): Return intmax_t,
8414 not unsigned long, as we prefer signed integers. All callers changed.
8415 Detect integer overflow in repeat count.
8416 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 8417 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 8418
171e2a58
PE
8419 * termcap.c: Don't assume sizes fit in int and never overflow.
8420 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
8421 (gobble_line): Check for size-calculation overflow.
8422
ad39faca 8423 * minibuf.c (Fread_buffer):
6e5bb2dc 8424 * lread.c (intern, intern_c_string):
74ca2eb3
PE
8425 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
8426 Don't assume string length fits in int.
8427
52c61c22 8428 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
8429 * gtkutil.c (style_changed_cb): Avoid need for strlen.
8430
b5b8c9e5
PE
8431 * font.c: Don't assume string length fits in int.
8432 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
8433 Use ptrdiff_t, not int.
ccd6111c
PE
8434 (font_intern_prop): Don't assume string length fits in int.
8435 Don't assume integer property fits in fixnum.
8436 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 8437
882f0d81 8438 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 8439 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
8440 Reformulate so as not to need the command string.
8441 Invoke gzip -cd rather than gunzip, as it's more portable.
8442 (lock_info_type, lock_file_1, lock_file):
8443 Don't assume pid_t and time_t fit in unsigned long.
8444 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
8445 (current_lock_owner): Prefer signed type for sizes.
8446 Use memcpy, not strncpy, where memcpy is what is really wanted.
8447 Don't assume (via atoi) that time_t and pid_t fit in int.
8448 Check for time_t and/or pid_t out of range, e.g., via a network share.
8449 Don't alloca where an auto var works fine.
8450
93f4cf88
PE
8451 * fileio.c: Fix some integer overflow issues.
8452 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
8453 Don't assume string length fits in int.
8454 (directory_file_name): Don't assume string length fits in long.
8455 (make_temp_name): Don't assume pid fits in int, or that its print
8456 length is less than 20.
8457
f3e92b69
PE
8458 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
8459
1bfdaf10
PE
8460 * coding.c (make_subsidiaries): Don't assume string length fits in int.
8461
35016e9a
PE
8462 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
8463
3d1e65a1
PE
8464 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
8465 We prefer signed integers, even for size calculations.
8466
0b963a93
PE
8467 * emacs.c: Don't assume string length fits in 'int'.
8468 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
8469 (main): Don't invoke strlen when not needed.
8470
573f4b54
PE
8471 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
8472 (XD_DEBUG_MESSAGE): Don't waste a byte.
8473
989f33ba
PE
8474 * callproc.c (getenv_internal_1, getenv_internal)
8475 (Fgetenv_internal):
965d34eb
PE
8476 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
8477
e4d29b33
PE
8478 * lread.c (invalid_syntax): Omit length argument.
8479 All uses changed. This doesn't fix a bug, but it simplifies the
8480 code away from its former Hollerith-constant appearance, and it's
8481 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 8482 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 8483
eb49b136
PE
8484 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
8485 This didn't break anything, but it didn't help either.
8486 It's confusing to put a bogus integer in a place where the actual
8487 value does not matter.
9f62aeb1 8488 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 8489 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 8490
15375a22
PE
8491 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
8492 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
8493 implementation.
b61cc01c
PE
8494 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
8495 We prefer signed types, and the value cannot exceed the EMACS_INT
8496 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
8497 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
8498 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
8499 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 8500
53b2623d
PE
8501 * indent.c (sane_tab_width): New function.
8502 (current_column, scan_for_column, Findent_to, position_indentation)
8503 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 8504 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 8505
51cab52b 8506 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 8507
f2ed8a70
PE
8508 * lisp.h (lint_assume): New macro.
8509 * composite.c (composition_gstring_put_cache):
8510 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
8511
abe80cc6
PE
8512 * editfns.c, insdel.c:
8513 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 8514
b02c740e
PE
8515 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
8516
ebc96716
PE
8517 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
8518
b4e50fa0 8519 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 8520 Use much-faster test for byte-length change.
311d5d7c 8521 Don't assume string byte-length fits in 'int'.
a4cf38e4 8522 Check that character arg fits in 'int'.
85461888 8523 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 8524
c0c1ee9f
PE
8525 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
8526
a498d7f4
PE
8527 * fns.c (concat): Catch string overflow earlier.
8528 Do not rely on integer wraparound.
8529
51cab52b
PE
8530 * dispextern.h (struct it.overlay_strings_charpos)
8531 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
8532 * xdisp.c (forward_to_next_line_start)
8533 (back_to_previous_visible_line_start)
8534 (reseat_at_next_visible_line_start, next_element_from_buffer):
8535 Don't arbitrarily truncate the value of 'selective' to int.
8536
76031fad
PE
8537 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
8538
5eb55db9
PE
8539 * composite.c: Don't truncate sizes to 'int'.
8540 (composition_gstring_p, composition_reseat_it)
8541 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
8542 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
8543 not EMACS_UINT, for indexes.
5eb55db9 8544
0703a717
PE
8545 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
8546
d6202519
PE
8547 * buffer.c: Include <verify.h>.
8548 (struct sortvec.priority, struct sortstr.priority):
8961a454 8549 Now EMACS_INT, not int.
c20998a7 8550 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
8551 (struct sortstr.size, record_overlay_string)
8552 (struct sortstrlist.size, struct sortlist.used):
8553 Don't truncate size to int.
8554 (record_overlay_string): Check for size-calculation overflow.
d6202519 8555 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 8556
d5a19415
JM
85572011-06-22 Jim Meyering <meyering@redhat.com>
8558
029529ac 8559 Don't leak an XBM-image-sized buffer
d5a19415
JM
8560 * image.c (xbm_load): Free the image buffer after using it.
8561
a9041e6c
PE
85622011-06-21 Paul Eggert <eggert@cs.ucla.edu>
8563
8564 Port to Sun C.
8565 * composite.c (find_automatic_composition): Omit needless 'return 0;'
8566 that Sun C diagnosed.
8567 * fns.c (secure_hash): Fix pointer signedness issue.
8568 * intervals.c (static_offset_intervals): New function.
8569 (offset_intervals): Use it.
8570
7f3f739f
LL
85712011-06-21 Leo Liu <sdl.web@gmail.com>
8572
8573 * deps.mk (fns.o):
8574 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
8575 sha512.h.
8576
8577 * fns.c (secure_hash): Rename from crypto_hash_function and change
8578 the first arg to accept symbols.
5b66d427 8579 (Fsecure_hash): New primitive.
7f3f739f
LL
8580 (syms_of_fns): New symbols.
8581
76147d94
DD
85822011-06-20 Deniz Dogan <deniz@dogan.se>
8583
8584 * process.c (Fset_process_buffer): Clarify return value in
8585 docstring.
8586
7d7d0045
CY
85872011-06-18 Chong Yidong <cyd@stupidchicken.com>
8588
8589 * dispnew.c (add_window_display_history): Use BVAR.
8590
8591 * xdisp.c (debug_method_add): Use BVAR.
8592 (check_window_end, dump_glyph_matrix, dump_glyph)
8593 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
8594
8595 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
8596 Likewise.
8597
8598 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
8599 check till after the cache is created in init_frame_faces.
8600
ff2bc410
SM
86012011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
8602
8603 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
8604
28177add
PE
86052011-06-16 Paul Eggert <eggert@cs.ucla.edu>
8606
dd3482fe
PE
8607 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
8608 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
8609 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
8610
393d71f3 8611 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
8612 * fileio.c (Finsert_file_contents):
8613 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
8614 Remove the old (too-loose) buffer overflow checks.
8615 They weren't needed, since make_gap checks for buffer overflow.
8616 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
8617 The old code merely checked for Emacs fixnum overflow, and relied
8618 on undefined (wraparound) behavior. The new code avoids undefined
8619 behavior, and also checks for ptrdiff_t and/or size_t overflow.
8620
2e6813b0 8621 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
8622 Tune. Don't use wider integers than needed. Don't use alloca.
8623 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 8624
599a9e4f
PE
8625 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
8626
99561444
PE
8627 * insdel.c, lisp.h (buffer_overflow): New function.
8628 (insert_from_buffer_1, replace_range, replace_range_2):
8629 * insdel.c (make_gap_larger):
8630 * editfns.c (Finsert_char):
8631 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
8632
28177add
PE
8633 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
8634
e69dafad
PE
86352011-06-15 Paul Eggert <eggert@cs.ucla.edu>
8636
4baa020d 8637 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 8638
b1c46f02
PE
8639 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
8640 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
8641
e69dafad
PE
8642 * fileio.c: Don't assume EMACS_INT fits in off_t.
8643 (emacs_lseek): New static function.
8644 (Finsert_file_contents, Fwrite_region): Use it.
8645 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
8646
566684ea
PE
8647 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
8648
e6966cd6
PE
8649 * fns.c: Don't overflow int when computing a list length.
8650 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
8651 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
8652 truncation on 64-bit hosts. Check for QUIT every
8653 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
8654 faster and is responsive enough.
8655 (Flength): Report an error instead of overflowing an integer.
8656 (Fsafe_length): Return a float if the value is not representable
8657 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 8658 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 8659 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 8660
dd0b0efb
PE
8661 * alloc.c: Check that resized vectors' lengths fit in fixnums.
8662 (header_size, word_size): New constants.
8663 (allocate_vectorlike): Don't check size overflow here.
8664 (allocate_vector): Check it here instead, since this is the only
8665 caller of allocate_vectorlike that could cause overflow.
8666 Check that the new vector's length is representable as a fixnum.
8667
86fe5cfe
PE
8668 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
8669 The previous code was bogus. For example, next_almost_prime (32)
8670 returned 39, which is undesirable as it is a multiple of 3; and
8671 next_almost_prime (24) returned 25, which is a multiple of 5 so
8672 why was the code bothering to check for multiples of 7?
8673
80e88859
PE
8674 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
8675
4a2f0ad6
PE
8676 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
8677
f66c7cf8
PE
8678 Variadic C functions now count arguments with ptrdiff_t.
8679 This partly undoes my 2011-03-30 change, which replaced int with size_t.
8680 Back then I didn't know that the Emacs coding style prefers signed int.
8681 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
8682 were being counted with int, which may truncate counts on 64-bit
8683 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
8684 * lisp.h (struct Lisp_Subr.function.aMANY)
8685 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
8686 Arg counts are now ptrdiff_t, not size_t.
8687 All variadic functions and their callers changed accordingly.
8688 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
8689 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
8690 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
8691 * callint.c (Fcall_interactively): Check arg count for overflow,
8692 to avoid potential buffer overrun. Use signed char, not 'int',
8693 for 'varies' array, so that we needn't bother to check its size
8694 calculation for overflow.
8695 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
8696 * eval.c (apply_lambda):
8697 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
8698 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
8699 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
8700
a1759b76
PE
8701 * callint.c (Fcall_interactively): Don't use index var as event count.
8702
d96be9fc
PE
8703 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
8704 * mem-limits.h (SIZE): Remove; no longer used.
8705
a690a978 8706 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 8707
578c21e6
PE
8708 Remove unnecessary casts.
8709 * xterm.c (x_term_init):
8710 * xfns.c (x_set_border_pixel):
8711 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
8712 These aren't needed now that we assume ANSI C.
8713
96f53c6c
PE
8714 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
8715 It's more likely to cause problems (due to unsigned overflow)
8716 than to cure them.
8717
83c77d31
PE
8718 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
8719
ee2079f1
PE
8720 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
8721
6da65536
PE
8722 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
8723
7147c4a4
PE
8724 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
8725
193e32d9
PE
8726 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
8727
e5533da6
PE
8728 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
8729
9910e595
PE
8730 GLYPH_CODE_FACE returns EMACS_INT, not int.
8731 * dispextern.h (merge_faces):
8732 * xfaces.c (merge_faces):
01103c44
PE
8733 * xdisp.c (get_next_display_element, next_element_from_display_vector):
8734 Don't assume EMACS_INT fits in int.
9910e595 8735
2638320e
PE
8736 * character.h (CHAR_VALID_P): Remove unused parameter.
8737 * fontset.c, lisp.h, xdisp.c: All uses changed.
8738
045eb8d9
PE
8739 * editfns.c (Ftranslate_region_internal): Omit redundant test.
8740
c1f134b5
PE
8741 * fns.c (concat): Minor tuning based on overflow analysis.
8742 This doesn't fix any bugs. Use int to hold character, instead
8743 of constantly refetching from Emacs object. Use XFASTINT, not
8744 XINT, for value known to be a character. Don't bother comparing
8745 a single byte to 0400, as it's always less.
8746
395fcb93 8747 * floatfns.c (Fexpt):
327eeec8
PE
8748 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
8749
abbd3d23
PE
8750 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
8751 for characters.
8752
684a03ef
PE
8753 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
8754
0fed43f3
PE
8755 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
8756 Without this fix, on a 64-bit host (aset S 0 4294967386) would
8757 incorrectly succeed when S was a string, because 4294967386 was
8758 truncated before it was used.
8759
8fd02eb7
PE
8760 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
8761 Otherwise, an out-of-range integer could cause undefined behavior
8762 on a 64-bit host.
8763
f8c86b69
PE
8764 * composite.c: Use int, not EMACS_INT, for characters.
8765 (fill_gstring_body, composition_compute_stop_pos): Use int, not
8766 EMACS_INT, for values that are known to be in character range.
8767 This doesn't fix any bugs but is the usual style inside Emacs and
8768 may generate better code on 32-bit machines.
8769
34206dd2
PE
8770 Make sure a 64-bit char is never passed to ENCODE_CHAR.
8771 This is for reasons similar to the recent CHAR_STRING fix.
8772 * charset.c (Fencode_char): Check that character arg is actually
8773 a character. Pass an int to ENCODE_CHAR.
8774 * charset.h (ENCODE_CHAR): Verify that the character argument is no
8775 wider than 'int', as a compile-time check to prevent future regressions
8776 in this area.
8777
c5958d4c 8778 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
8779
8780 Make sure a 64-bit char is never passed to CHAR_STRING.
8781 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
8782 by silently ignoring the top 32 bits, allowing some values
8783 that were far too large to be valid characters.
8784 * character.h: Include <verify.h>.
8785 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
8786 arguments are no wider than unsigned, as a compile-time check
8787 to prevent future regressions in this area.
8788 * data.c (Faset):
01103c44 8789 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
8790 (Fsubst_char_in_region):
8791 * fns.c (concat):
8792 * xdisp.c (decode_mode_spec_coding):
8793 Adjust to CHAR_STRING's new requirement.
8794 * editfns.c (Finsert_char, Fsubst_char_in_region):
8795 * fns.c (concat): Check that character args are actually
8796 characters. Without this test, these functions did the wrong
8797 thing with wildly out-of-range values on 64-bit hosts.
8798
d37ca623
PE
8799 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
8800 These casts should not be needed on 32-bit hosts, either.
8801 * keyboard.c (read_char):
8802 * lread.c (Fload): Remove casts to unsigned.
8803
ea204efb
PE
8804 * lisp.h (UNSIGNED_CMP): New macro.
8805 This fixes comparison bugs on 64-bit hosts.
8806 (ASCII_CHAR_P): Use it.
8807 * casefiddle.c (casify_object):
01103c44 8808 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
8809 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
8810 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
8811 * dispextern.h (FACE_FROM_ID):
8812 * keyboard.c (read_char): Use UNSIGNED_CMP.
8813
41cb286c
PE
8814 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
8815 not to EMACS_INT, to avoid GCC warning.
8816
4a1b9832
PE
8817 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
8818
55daad71
PE
8819 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
8820 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
8821 isn't needed on 32-bit machines.
8f95c75c 8822
01103c44
PE
8823 * buffer.c (Fgenerate_new_buffer_name):
8824 Use EMACS_INT for count, not int.
0ceccced 8825 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
8826
8827 * data.c (Qcompiled_function): Now static.
8828
c6f072e7
PE
8829 * window.c (window_body_lines): Now static.
8830
20ce5912
PE
8831 * image.c (gif_load): Rename local to avoid shadowing.
8832
9c4c5f81
PE
8833 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
8834 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
8835 * alloc.c (make_save_value): Integer argument is now of type
8836 ptrdiff_t, not int.
8837 (mark_object): Use ptrdiff_t, not int.
8838 * lisp.h (pD): New macro.
8839 * print.c (print_object): Use it.
8840
c0c5c8ae
PE
8841 * alloc.c: Use EMACS_INT, not int, to count objects.
8842 (total_conses, total_markers, total_symbols, total_vector_size)
8843 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
8844 (total_free_floats, total_floats, total_free_intervals)
8845 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
8846 Now EMACS_INT, not int. All uses changed.
8847 (Fgarbage_collect): Compute overall total using a double, so that
8848 integer overflow is less likely to be a problem. Check for overflow
8849 when converting back to an integer.
5a25e253
PE
8850 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
8851 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
8852 These were 'int' variables that could overflow on 64-bit hosts;
8853 they were never used, so remove them instead of repairing them.
211a0b2a 8854 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
8855 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
8856 Previously, this ceilinged at INT_MAX, but that doesn't work on
8857 64-bit machines.
e46bb31a 8858 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 8859
c78baabf 8860 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 8861 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
8862 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
8863 when a (possibly-narrower) signed value would do just as well.
8864 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 8865
c9d624c6
PE
8866 * alloc.c: Catch some string size overflows that we were missing.
8867 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
8868 for convenience in STRING_BYTES_MAX.
8869 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
8870 The definition here is exact; the one in lisp.h was approximate.
8871 (allocate_string_data): Check for string overflow. This catches
8872 some instances we weren't catching before. Also, it catches
8873 size_t overflow on (unusual) hosts where SIZE_MAX <= min
8874 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
8875 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 8876
c9d624c6
PE
8877 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
8878 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 8879 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 8880
353032ce
PE
8881 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
8882
2bccce07
PE
8883 * alloc.c (Fmake_string): Check for out-of-range init.
8884
0ac30604
SM
88852011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
8886
8887 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
8888
c195f2de
JD
88892011-06-14 Jan Djärv <jan.h.d@swipnet.se>
8890
8891 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
8892 xg_get_default_scrollbar_width.
8893
8894 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
8895 (int_gtk_range_get_value): Move to the scroll bar part of the file.
8896 (style_changed_cb): Call update_theme_scrollbar_width and call
8897 x_set_scroll_bar_default_width and xg_frame_set_char_size for
8898 all frames (Bug#8505).
8899 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
8900 Call gtk_window_set_resizable if HAVE_GTK3.
8901 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
8902 and height if HAVE_GTK3 (Bug#8505).
8903 (scroll_bar_width_for_theme): New variable.
8904 (update_theme_scrollbar_width): New function.
8905 (xg_get_default_scrollbar_width): Move code to
8906 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
8907 (xg_initialize): Call update_theme_scrollbar_width.
8908
8909 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
8910
8911 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
8912
e10ac9f1
MR
89132011-06-12 Martin Rudalics <rudalics@gmx.at>
8914
8915 * frame.c (make_frame): Call other_buffer_safely instead of
8916 other_buffer.
8917
8918 * window.c (temp_output_buffer_show): Call display_buffer with
8919 second argument Vtemp_buffer_show_specifiers and reset latter
8920 immediately after the call.
8921 (Vtemp_buffer_show_specifiers): New variable.
8922 (auto_window_vscroll_p, next_screen_context_lines)
8923 (Vscroll_preserve_screen_position): Remove leading asterisks from
8924 doc-strings.
8925
2d3c217e 89262011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 8927
7b7f97e8 8928 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
8929 * buffer.c (Qclone_number): Remove for now, as it's unused.
8930 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
8931 (record_buffer): Remove unused local.
8932 * frame.c (other_visible_frames, frame_buffer_list): Now static.
8933 (set_frame_buffer_list): Remove; unused.
8934 * frame.h (other_visible_frames): Remove decl.
8935 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
8936 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
8937 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
8938 if HAVE_GPM.
8939 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
8940 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
8941 Define only if HAVE_GPM.
8942 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
8943 (update_hints_inhibit): Remove; never set. All uses removed.
8944 * widgetprv.h (emacsFrameClassRec): Remove decl.
8945 * window.c (delete_deletable_window): Now returns void, since it
8946 wasn't returning anything.
8947 (compare_window_configurations): Remove unused locals.
8948 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
8949 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
8950 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
8951 the same widths as pointers. This follows up on the 2011-05-06 patch.
8952 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
8953 * xterm.h: Likewise.
8954 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
8955
1384b89e
JB
89562011-06-12 Juanma Barranquero <lekktu@gmail.com>
8957
8958 * makefile.w32-in: Update dependencies.
8959 (LISP_H): Add lib/intprops.h.
8960
1100a63c
CY
89612011-06-11 Chong Yidong <cyd@stupidchicken.com>
8962
8963 * image.c (gif_load): Add animation frame delay to the metadata.
8964 (syms_of_image): Use DEFSYM. New symbol `delay'.
8965
6198ccd0
MR
89662011-06-11 Martin Rudalics <rudalics@gmx.at>
8967
8968 * window.c (delete_deletable_window): Re-add.
8969 (Fset_window_configuration): Rewrite to handle dead buffers and
8970 consequently deletable windows.
8971 (window_tree, Fwindow_tree): Remove. Supply functionality in
8972 window.el.
8973 (compare_window_configurations): Simplify code.
8974
b6e3633c
AS
89752011-06-11 Andreas Schwab <schwab@linux-m68k.org>
8976
1ab0dee5
AS
8977 * image.c (imagemagick_load_image): Fix type mismatch.
8978 (Fimagemagick_types): Likewise.
8979
b6e3633c
AS
8980 * window.h (replace_buffer_in_windows): Declare.
8981
9397e56f
MR
89822011-06-11 Martin Rudalics <rudalics@gmx.at>
8983
8984 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
8985 Qclone_number. Remove external declaration of Qdelete_window.
8986 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
8987 code.
640c8776
SM
8988 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
8989 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
8990 (Fother_buffer): Rewrite doc-string. Major rewrite for new
8991 buffer list implementation.
8992 (other_buffer_safely): New function.
8993 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
8994 calls to replace_buffer_in_windows and
8995 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
8996 if allowed.
8997 (record_buffer): Inhibit quitting and rewrite using quittable
8998 functions. Run Qbuffer_list_update_hook if allowed.
8999 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
9000 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
9001 Move switch-to-buffer to window.el.
9397e56f
MR
9002 (bury-buffer): Move to window.el.
9003 (Vbuffer_list_update_hook): New variable.
9004
9005 * lisp.h (other_buffer_safely): Add prototype in buffer.c
9006 section.
9007
9008 * window.h (resize_frame_windows): Move up in code.
9009 (Fwindow_frame): Remove EXFUN.
9010 (replace_buffer_in_all_windows): Remove prototype.
9011 (replace_buffer_in_windows_safely): Add prototype.
9012
9013 * window.c: Declare Qdelete_window static again. Move down
9014 declaration of select_count.
9015 (Fnext_window, Fprevious_window): Rewrite doc-strings.
9016 (Fother_window): Move to window.el.
9017 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
9018 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
9019 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
9020 window.el.
9021 (replace_buffer_in_windows): Implement by calling
9022 Qreplace_buffer_in_windows.
9023 (replace_buffer_in_all_windows): Remove with some functionality
9024 moved into replace_buffer_in_windows_safely.
9025 (replace_buffer_in_windows_safely): New function.
9026 (select_window_norecord, select_frame_norecord): Move in front
9027 of run_window_configuration_change_hook. Remove now obsolete
9028 declarations.
640c8776
SM
9029 (Fset_window_buffer): Rewrite doc-string.
9030 Call Qrecord_window_buffer.
9397e56f
MR
9031 (keys_of_window): Move binding for other-window to window.el.
9032
b50691aa
CY
90332011-06-11 Chong Yidong <cyd@stupidchicken.com>
9034
9035 * dispextern.h (struct image): Replace data member, whose int_val
9036 and ptr_val fields were not used by anything, with a single
9037 lisp_val object.
9038
9039 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
9040 (gif_clear_image, gif_load, imagemagick_load_image)
9041 (gs_clear_image, gs_load): Callers changed.
9042
3f754b86
PE
90432011-06-10 Paul Eggert <eggert@cs.ucla.edu>
9044
cca69397
PE
9045 * buffer.h: Include <time.h>, for time_t.
9046 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
9047
109e28d0
PE
9048 Fix minor problems found by static checking.
9049
60737f02
PE
9050 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
9051
4b66faf3
PE
9052 Make identifiers static if they are not used in other modules.
9053 * data.c (Qcompiled_function, Qframe, Qvector):
9054 * image.c (QimageMagick, Qsvg):
9055 * minibuf.c (Qmetadata):
9056 * window.c (resize_window_check, resize_root_window): Now static.
9057 * window.h (resize_window_check, resize_root_window): Remove decls.
9058
109e28d0
PE
9059 * window.c (window_deletion_count, delete_deletable_window):
9060 Remove; unused.
46a4ce9e
PE
9061 (window_body_lines): Now static.
9062 (Fdelete_other_windows_internal): Mark vars as initialized.
9063 Make sure 'resize_failed' is initialized.
9064 (run_window_configuration_change_hook): Rename local to avoid shadowing.
9065 (resize_window_apply): Remove unused local.
9066 * window.h (delete_deletable_window): Remove decl.
9067
109e28d0 9068 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
9069 (imagemagick_load_image): Fix pointer signedness problem by changing
9070 last arg from unsigned char * to char *. All uses changed.
9071 Also, fix a local for similar reasons.
9072 Remove unused locals. Remove locals to avoid shadowing.
9073 (fn_rsvg_handle_free): Remove; unused.
9074 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 9075 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 9076
3f754b86
PE
9077 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
9078
2547adb1
CY
90792011-06-10 Chong Yidong <cyd@stupidchicken.com>
9080
9081 * image.c (gif_load): Fix omitted cast error introduced by
9082 2011-06-06 change.
9083
2c8e37d4
MR
90842011-06-10 Martin Rudalics <rudalics@gmx.at>
9085
9086 * window.h (resize_proportionally, orig_total_lines)
9087 (orig_top_line): Remove from window structure.
9088 (set_window_height, set_window_width, change_window_heights)
9089 (Fdelete_window): Remove prototypes.
9090 (resize_frame_windows): Remove duplicate declaration.
9091
440a42e3
EZ
90922011-06-10 Eli Zaretskii <eliz@gnu.org>
9093
9094 * window.h (resize_frame_windows, resize_window_check)
9095 (delete_deletable_window, resize_root_window)
9096 (resize_frame_windows): Declare prototypes.
9097
9098 * window.c (resize_window_apply): Make definition be "static" to
9099 match the prototype.
9100
562dd5e9
MR
91012011-06-10 Martin Rudalics <rudalics@gmx.at>
9102
9103 * window.c: Remove declarations of Qwindow_size_fixed,
9104 window_min_size_1, window_min_size_2, window_min_size,
9105 size_window, window_fixed_size_p, enlarge_window, delete_window.
9106 Remove static from declaration of Qdelete_window, it's
9107 temporarily needed by Fbury_buffer.
9108 (replace_window): Don't assign orig_top_line and
9109 orig_total_lines.
9110 (Fdelete_window, delete_window): Remove. Window deletion is
9111 handled by window.el.
640c8776
SM
9112 (window_loop): Remove DELETE_OTHER_WINDOWS case.
9113 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
9114 (Fdelete_other_windows): Remove. Deleting other windows is
9115 handled by window.el.
9116 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
9117 handled in window.el.
9118 (window_min_size_2, window_min_size_1, window_min_size): Remove.
9119 Window minimum sizes are handled in window.el.
9120 (shrink_windows, size_window, set_window_height)
9121 (set_window_width, change_window_heights, window_height)
9122 (window_width, CURBEG, CURSIZE, enlarge_window)
9123 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
9124 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
9125 handled in window.el.
9126 (make_dummy_parent): Rename to make_parent_window and give it a
9127 second argument horflag.
9128 (make_window): Don't set resize_proportionally any more.
9129 (Fsplit_window): Remove. Windows are split in window.el.
9130 (save_restore_action, save_restore_orig_size)
9131 (shrink_window_lowest_first, save_restore_orig_size): Remove.
9132 Resize mini windows in window.el.
9133 (grow_mini_window, shrink_mini_window): Implement by calling
9134 Qresize_root_window_vertically, resize_window_check and
9135 resize_window_apply.
640c8776
SM
9136 (saved_window, Fset_window_configuration, save_window_save):
9137 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
9138 resize_proportionally.
9139 (window_min_height, window_min_width): Move to window.el.
9140 (keys_of_window): Move bindings for delete-other-windows,
9141 split-window, delete-window and enlarge-window to window.el.
9142
9143 * buffer.c: Temporarily extern Qdelete_window.
9144 (Fbury_buffer): Temporarily call Qdelete_window instead of
9145 Fdelete_window (Fbury_buffer will move to window.el soon).
9146
9147 * frame.c (set_menu_bar_lines_1): Remove code handling
9148 orig_top_line and orig_total_lines.
9149
9150 * dispnew.c (adjust_frame_glyphs_initially): Don't use
9151 set_window_height but set heights directly.
9152 (change_frame_size_1): Use resize_frame_windows.
9153
9154 * xdisp.c (init_xdisp): Don't use set_window_height but set
9155 heights directly.
9156
640c8776
SM
9157 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
9158 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
9159 run_window_configuration_change_hook.
9160
9161 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
9162 instead of change_window_heights and run
9163 run_window_configuration_change_hook.
9164
1a13852e
MR
91652011-06-09 Martin Rudalics <rudalics@gmx.at>
9166
9167 * window.c (replace_window): Rename second argument REPLACEMENT to
9168 NEW. New third argument SETFLAG. Rewrite.
9169 (delete_window, make_dummy_parent): Call replace_window with
9170 third argument 1.
9171 (window_list_1): Move down in code.
9172 (run_window_configuration_change_hook): Move set_buffer part
9173 before select_frame_norecord part in order to unwind correctly.
9174 Rename count1 to count.
9175 (recombine_windows, delete_deletable_window, resize_root_window)
9176 (Fdelete_other_windows_internal)
9177 (Frun_window_configuration_change_hook, make_parent_window)
9178 (resize_window_check, resize_window_apply, Fresize_window_apply)
9179 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
9180 (Fdelete_window_internal, Fresize_mini_window_internal):
9181 New functions.
1a13852e
MR
9182 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
9183
f3d1777e
MR
91842011-06-08 Martin Rudalics <rudalics@gmx.at>
9185
496e208e
MR
9186 * window.h (window): Add some new members to window structure -
9187 normal_lines, normal_cols, new_total, new_normal, clone_number,
9188 splits, nest, prev_buffers, next_buffers.
9189 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 9190 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 9191
f3d1777e
MR
9192 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
9193 Remove.
496e208e
MR
9194 (make_dummy_parent): Set new members of windows structure.
9195 (make_window): Move down in code. Handle new members of window
9196 structure.
9197 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
9198 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
9199 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
9200 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
9201 (Fset_window_next_buffers, Fset_window_clone_number):
9202 New functions.
496e208e
MR
9203 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
9204 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
9205 Doc-string fixes.
9206 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
9207 Argument WINDOW can be now internal window too.
9208 (Fwindow_use_time): Move up in code.
9209 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
9210 Rewrite doc-string.
9211 (Fset_window_configuration, saved_window)
9212 (Fcurrent_window_configuration, save_window_save): Handle new
9213 members of window structure.
b9e809c2
MR
9214 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
9215 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
9216 (syms_of_window): New Lisp objects Qrecord_window_buffer,
9217 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
9218 Qget_mru_window, Qresize_root_window,
9219 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
9220 Qauto_buffer_name; staticpro them.
f3d1777e 9221
abde8f8c
MR
92222011-06-07 Martin Rudalics <rudalics@gmx.at>
9223
9224 * window.c (Fwindow_total_size, Fwindow_left_column)
9225 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
9226 (Fwindow_list_1): New functions.
9227 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
9228 (Fwindow_width, Fscroll_left, Fscroll_right):
9229 Use window_body_cols instead of window_box_text_cols.
9230 (delete_window, Fset_window_configuration):
9231 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
9232 (delete_all_subwindows): Take a window as argument and not a
9233 structure. Rewrite.
190b47e6
MR
9234 (window_loop): Remove handling of GET_LRU_WINDOW and
9235 GET_LARGEST_WINDOW.
9236 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
9237
9238 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
9239 window_box_text_cols. delete_all_subwindows now takes a
9240 Lisp_Object as argument.
abde8f8c 9241
640c8776
SM
9242 * indent.c (compute_motion, Fcompute_motion):
9243 Use window_body_cols instead of window_box_text_cols.
abde8f8c 9244
fa8a67e6
MR
9245 * frame.c (delete_frame): Call delete_all_subwindows with root
9246 window as argument.
9247
a54e3482
DC
92482011-06-07 Daniel Colascione <dan.colascione@gmail.com>
9249
9250 * fns.c (Fputhash): Document return value.
9251
60002bf5
CY
92522011-06-06 Chong Yidong <cyd@stupidchicken.com>
9253
9254 * image.c (gif_load): Implement gif89a spec "no disposal" method.
9255
0c671da6 92562011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 9257
b862a52a 9258 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 9259
be44ca6c
PE
9260 Check for overflow when converting integer to cons and back.
9261 * charset.c (Fdefine_charset_internal, Fdecode_char):
9262 Use cons_to_unsigned to catch overflow.
9263 (Fencode_char): Use INTEGER_TO_CONS.
9264 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
9265 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
9266 * data.c (long_to_cons, cons_to_long): Remove.
9267 (cons_to_unsigned, cons_to_signed): New functions.
9268 These signal an error for invalid or out-of-range values.
9269 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
9270 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
9271 * font.c (Ffont_variation_glyphs):
9272 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
9273 * lisp.h: Include <intprops.h>.
9274 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
9275 (cons_to_signed, cons_to_unsigned): New decls.
9276 (long_to_cons, cons_to_long): Remove decls.
9277 * undo.c (record_first_change): Use INTEGER_TO_CONS.
9278 (Fprimitive_undo): Use CONS_TO_INTEGER.
9279 * xfns.c (Fx_window_property): Likewise.
9280 * xselect.c: Include <limits.h>.
9281 (x_own_selection, selection_data_to_lisp_data):
9282 Use INTEGER_TO_CONS.
9283 (x_handle_selection_request, x_handle_selection_clear)
9284 (x_get_foreign_selection, Fx_disown_selection_internal)
9285 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
9286 (lisp_data_to_selection_data): Use cons_to_unsigned.
9287 (x_fill_property_data): Use cons_to_signed.
9288 Report values out of range.
9289
d1f3d2af
PE
9290 Check for buffer and string overflow more precisely.
9291 * buffer.h (BUF_BYTES_MAX): New macro.
9292 * lisp.h (STRING_BYTES_MAX): New macro.
9293 * alloc.c (Fmake_string):
9294 * character.c (string_escape_byte8):
9295 * coding.c (coding_alloc_by_realloc):
9296 * doprnt.c (doprnt):
9297 * editfns.c (Fformat):
9298 * eval.c (verror):
9299 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
9300 since they may not be the same number.
9301 * editfns.c (Finsert_char):
9302 * fileio.c (Finsert_file_contents):
9303 Likewise for BUF_BYTES_MAX.
9304
dd52fcea
PE
9305 * image.c: Use ptrdiff_t, not int, for sizes.
9306 (slurp_file): Switch from int to ptrdiff_t.
9307 All uses changed.
9308 (slurp_file): Check that file size fits in both size_t (for
9309 malloc) and ptrdiff_t (for sanity and safety).
9310
7f9bbdbb
PE
9311 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
9312 if b->modtime has its maximal value.
9313
dfe18f82
PE
9314 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
9315
84acfcf0
PE
9316 Don't assume time_t can fit into int.
9317 * buffer.h (struct buffer.modtime): Now time_t, not int.
9318 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
9319 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
9320
ccd9a01a
PE
9321 Minor fixes for signed vs unsigned integers.
9322 * character.h (MAYBE_UNIFY_CHAR):
9323 * charset.c (maybe_unify_char):
9324 * keyboard.c (read_char, reorder_modifiers):
9325 XINT -> XFASTINT, since the integer must be nonnegative.
9326 * ftfont.c (ftfont_spec_pattern):
9327 * keymap.c (access_keymap, silly_event_symbol_error):
9328 XUINT -> XFASTINT, since the integer must be nonnegative.
9329 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
9330 since it makes no difference and we prefer signed.
9331 * keyboard.c (record_char): Use XUINT when all the neighbors do.
9332 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
9333 nonnegative.
9334
d6d100dd
SM
93352011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
9336
9337 * window.h (Fwindow_frame): Declare.
9338
2b6148e4
PE
93392011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9340
9341 * alloc.c: Simplify handling of large-request failures (Bug#8800).
9342 (SPARE_MEMORY): Always define.
9343 (LARGE_REQUEST): Remove.
9344 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
9345
f230ecc9
MR
93462011-06-06 Martin Rudalics <rudalics@gmx.at>
9347
727e958e
MR
9348 * lisp.h: Move EXFUNS for Fframe_root_window,
9349 Fframe_first_window and Fset_frame_selected_window to window.h.
9350
9351 * window.h: Move EXFUNS for Fframe_root_window,
9352 Fframe_first_window and Fset_frame_selected_window here from
9353 lisp.h.
9354
9355 * frame.c (Fwindow_frame, Fframe_first_window)
9356 (Fframe_root_window, Fframe_selected_window)
9357 (Fset_frame_selected_window): Move to window.c.
9358 (Factive_minibuffer_window): Move to minibuf.c.
9359 (Fother_visible_frames_p): New function.
9360
9361 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
9362
f230ecc9
MR
9363 * window.c (decode_window, decode_any_window): Move up in code.
9364 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
9365 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
9366 (Fwindow_buffer): Move up and rewrite doc-string.
9367 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
9368 (Fwindow_prev): New functions.
727e958e
MR
9369 (Fwindow_frame): Move here from frame.c. Accept any window as
9370 argument.
9371 (Fframe_root_window, Fframe_first_window)
9372 (Fframe_selected_window): Move here from frame.c. Accept frame
9373 or arbitrary window as argument. Update doc-strings.
9374 (Fminibuffer_window): Move up in code.
9375 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
9376 (Fset_frame_selected_window): Move here from frame.c.
9377 Marginal rewrite.
727e958e
MR
9378 (Fselected_window, select_window, Fselect_window): Move up in
9379 code. Minor doc-string fixes.
f230ecc9 9380
4d09bcf6
PE
93812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
9382
9383 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
9384 Do not assume that spare memory exists; that assumption is valid
9385 only if SYSTEM_MALLOC.
9386 (LARGE_REQUEST): New macro, so that the issue of large requests
9387 is separated from the issue of spare memory.
9388
810928a2
AS
93892011-06-05 Andreas Schwab <schwab@linux-m68k.org>
9390
172418ad
AS
9391 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
9392 format. (Bug#8806)
9393
43f862f7
AS
9394 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
9395
810928a2
AS
9396 * xfns.c (x_set_scroll_bar_default_width): Move declarations
9397 before statements.
9398
a059fe24
JD
93992011-06-05 Jan Djärv <jan.h.d@swipnet.se>
9400
9401 * gtkutil.c (xg_get_default_scrollbar_width): New function.
9402
9403 * gtkutil.h: Declare xg_get_default_scrollbar_width.
9404
9405 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
9406 min width by calling x_set_scroll_bar_default_width (Bug#8505).
9407
989bf368
JB
94082011-06-05 Juanma Barranquero <lekktu@gmail.com>
9409
9410 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
9411
4b80f674
CY
94122011-06-04 Chong Yidong <cyd@stupidchicken.com>
9413
9414 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
9415 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
9416 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
9417 New error handlers.
4b80f674
CY
9418 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
9419 Obey Vx_select_enable_clipboard_manager. Catch errors in
9420 x_clipboard_manager_save (Bug#8779).
9421 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 9422 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 9423
99a33b77 94242011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
9425
9426 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
9427
99a33b77 94282011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
9429
9430 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
9431 in the current matrix if keep_current_p is non-zero.
9432
8264569d
EZ
94332011-06-04 Eli Zaretskii <eliz@gnu.org>
9434
9435 * bidi.c (bidi_level_of_next_char): Fix last change.
9436
57f97249
EZ
94372011-06-03 Eli Zaretskii <eliz@gnu.org>
9438
fec2107c 9439 Support bidi reordering of text covered by display properties.
57f97249 9440
fec2107c
EZ
9441 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
9442 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
9443 (bidi_cache_search, bidi_cache_iterator_state)
9444 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
9445 (bidi_level_of_next_char, bidi_move_to_visually_next):
9446 Support character positions inside a run of characters covered by a
fec2107c
EZ
9447 display string.
9448 (bidi_paragraph_init, bidi_resolve_explicit_1)
9449 (bidi_level_of_next_char): Call bidi_fetch_char and
9450 bidi_fetch_char_advance instead of FETCH_CHAR and
9451 FETCH_CHAR_ADVANCE.
9452 (bidi_init_it): Initialize new members.
9453 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
9454 definitions.
9455 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
9456 instead of using explicit *_CHAR codes.
d6d100dd
SM
9457 (bidi_resolve_explicit, bidi_resolve_weak):
9458 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
9459 bidirectional text is supported only in multibyte buffers.
9460 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
9461 it to initialize the frame_window_p member of struct bidi_it.
9462 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
9463 (bidi_resolve_explicit, bidi_resolve_weak)
9464 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
9465 bidi_it->nchars is non-positive.
9466 (bidi_level_of_next_char): Don't try to lookup the cache for the
9467 next/previous character if nothing is cached there yet, or if we
9468 were just reseat()'ed to a new position.
c40e2fb2 9469
0e14fe90
EZ
9470 * xdisp.c (set_cursor_from_row): Set start and stop points
9471 according to the row's direction when priming the loop that looks
9472 for the glyph on which to display cursor.
9473 (single_display_spec_intangible_p): Function deleted.
9474 (display_prop_intangible_p): Reimplement to call
9475 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
9476 Accept 3 additional arguments needed by handle_display_spec.
9477 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
9478 values: lists, `(when COND...)' forms, etc.
9479 (single_display_spec_string_p): Support property values that are
9480 lists with the argument STRING its top-level element.
9481 (display_prop_string_p): Fix the condition for processing a
9482 property that is a list to be consistent with handle_display_spec.
fec2107c 9483 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
9484 last portion of handle_display_prop.
9485 (compute_display_string_pos): Accept additional argument
9486 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
9487 value of a `display' property is a "replacing spec".
9488 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
9489 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
9490 the display property, but just return a value indicating whether
9491 the display property will replace the characters it covers.
9492 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
9493 frame_window_p members of struct bidi_it.
d6d100dd
SM
9494 (compute_display_string_pos, compute_display_string_end):
9495 New functions.
fec2107c
EZ
9496 (push_it): Accept second argument POSITION, where pop_it should
9497 jump to continue iteration.
9498 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 9499
fec2107c
EZ
9500 * keyboard.c (adjust_point_for_property): Adjust the call to
9501 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
9502
9503 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
9504 (bidi_init_it): Update prototypes.
9505 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
9506 (compute_display_string_pos, compute_display_string_end):
9507 Declare prototypes.
fec2107c
EZ
9508 (struct bidi_it): New members nchars and disp_pos. ch_len is now
9509 EMACS_INT.
fc6f18ce 9510
40087514 95112011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 9512
57f53182
PE
9513 Malloc failure behavior now depends on size of allocation.
9514 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
9515 * lisp.h: Change signatures accordingly.
9516 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
9517 All callers changed. (Bug#8762)
9518
9519 * gnutls.c: Use Emacs's memory allocators.
9520 Without this change, the gnutls library would invoke malloc etc.
9521 directly, which causes problems on non-SYNC_INPUT hosts, and which
9522 runs afoul of improving memory_full behavior. (Bug#8761)
9523 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
9524 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
9525 xfree instead of the default malloc, realloc, free.
9526 (Fgnutls_boot): No need to check for memory allocation failure,
9527 since xmalloc does that for us.
9528
ac32cd99 9529 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
9530 * category.c (hash_get_category_set):
9531 * ccl.c (ccl_driver):
9532 * charset.c (Fdefine_charset_internal):
9533 * charset.h (struct charset.hash_index):
9534 * composite.c (get_composition_id, gstring_lookup_cache)
9535 (composition_gstring_put_cache):
9536 * composite.h (struct composition.hash_index):
9537 * dispextern.h (struct image.hash):
9538 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
9539 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
9540 (hashfn_equal, hashfn_user_defined, make_hash_table)
9541 (maybe_resize_hash_table, hash_lookup, hash_put)
9542 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
9543 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
9544 (Fsxhash, Fgethash, Fputhash, Fmaphash):
9545 * image.c (make_image, search_image_cache, lookup_image)
9546 (xpm_put_color_table_h):
9547 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 9548 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 9549 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 9550 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
9551 * alloc.c (allocate_vectorlike):
9552 Check for overflow in vector size calculations.
9553 * ccl.c (ccl_driver):
9554 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
9555 * fns.c, image.c: Remove unnecessary static decls that would otherwise
9556 need to be updated by these changes.
40087514
PE
9557 * fns.c (make_hash_table, maybe_resize_hash_table):
9558 Check for integer overflow with large hash tables.
0de4bb68
PE
9559 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
9560 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
9561 (SXHASH_REDUCE): New macro.
9562 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
9563 Use it instead of discarding useful hash info with large hash values.
9564 (sxhash_float): New function.
9565 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
9566 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
9567 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
9568 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
9569 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
9570 Adjust signatures to match updated version of code.
9571 (consing_since_gc): Now EMACS_INT, since a single hash table can
9572 use more than INT_MAX bytes.
9573
698d32e2
DN
95742011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
9575
9576 Make it possible to build with GCC-4.6+ -O2 -flto.
9577
9578 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
9579
fd6fa53f
SM
95802011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
9581
9582 * minibuf.c (get_minibuffer, read_minibuf_unwind):
9583 Call minibuffer-inactive-mode.
9584
864db017
JB
95852011-05-31 Juanma Barranquero <lekktu@gmail.com>
9586
9587 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
9588 Update dependencies.
9589
2ad0baf4
DN
95902011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9591
9592 * data.c (init_data): Remove code for UTS, this system is not
9593 supported anymore.
9594
4fcc2638
DN
95952011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9596
9597 Don't force ./temacs to start in terminal mode.
9598
9599 * frame.c (make_initial_frame): Initialize faces in all cases, not
9600 only when CANNOT_DUMP is defined.
9601 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
9602
c56e0fd5
DN
96032011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9604
9605 * dispnew.c (add_window_display_history): Use const for the string
9606 pointer. Remove declaration, not needed.
9607
333d54da 96082011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 9609
55d4c1b2 9610 Use 'inline', not 'INLINE'.
333d54da 9611 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
9612 * alloc.c, fontset.c (INLINE): Remove.
9613 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
9614 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
9615 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
9616 * gmalloc.c (register_heapinfo): Use inline unconditionally.
9617 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
9618
738db178
DN
96192011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
9620
9621 Make it possible to run ./temacs.
9622
9623 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
9624 syms_of_callproc does the same thing. Remove test for
9625 "initialized", do it in the caller.
9626 * emacs.c (main): Avoid calling set_initial_environment when dumping.
9627
620c53a6
SM
96282011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
9629
9630 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
9631 (read_minibuf): Use get_minibuffer.
9632 (syms_of_minibuf): Use DEFSYM.
9633 (Qmetadata): New var.
9634 * data.c (Qbuffer): Don't make it static.
9635 (syms_of_data): Use DEFSYM.
9636
e003a292
PE
96372011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9638
9639 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
9640 (CCL_CODE_MIN): New macro.
9641
ed008a6d
PE
96422011-05-30 Paul Eggert <eggert@cs.ucla.edu>
9643
3687c2ef
PE
9644 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
9645
ed008a6d
PE
9646 * eval.c (Qdebug): Now static.
9647 * lisp.h (Qdebug): Remove decl. This reverts a part of the
9648 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
9649 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
9650
d66c4c7c
CY
96512011-05-29 Chong Yidong <cyd@stupidchicken.com>
9652
9653 * image.c: Various fixes to ImageMagick code comments.
9654 (Fimagemagick_types): Doc fix.
9655
5fbc2025
PE
96562011-05-29 Paul Eggert <eggert@cs.ucla.edu>
9657
0196f88a
PE
9658 Minor fixes prompted by GCC 4.6.0 warnings.
9659
9660 * xselect.c (converted_selections, conversion_fail_tag): Now static.
9661
5fbc2025
PE
9662 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
9663 (x_clipboard_manager_save_all): Move extern decl to ...
9664 * xterm.h: ... here, so that it can be checked for consistency.
9665
1dd3c2d9
CY
96662011-05-29 Chong Yidong <cyd@stupidchicken.com>
9667
9668 * xselect.c (x_clipboard_manager_save_frame)
9669 (x_clipboard_manager_save_all): New functions.
9670 (Fx_clipboard_manager_save): Lisp function deleted.
9671
9672 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
9673 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
9674
9675 * xterm.h: Update prototype.
9676
5ba6571d
WX
96772011-05-28 William Xu <william.xwl@gmail.com>
9678
9679 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
9680 exiting (Bug#8239).
9681
3eaff834
JM
96822011-05-28 Jim Meyering <meyering@redhat.com>
9683
e1900994 9684 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
9685 * fns.c (to_uchar): Define.
9686 (crypto_hash_function): Use it to convert some newly-signed
9687 variables to unsigned, to avoid sign-extension bugs. For example,
9688 without this change, (md5 "truc") would evaluate to
9689 45723a2aff78ff4fff7fff1114760e62 rather than the expected
9690 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 9691 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 9692
0f6990a7
PE
96932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9694
9695 Integer overflow fixes.
c8a9ca5a 9696
08686060
PE
9697 * dbusbind.c: Serial number integer overflow fixes.
9698 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
9699 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
9700 to hold a serial number that is too large for a fixnum.
9701 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9702 Check for serial numbers out of range. Decode any serial number
59568bf0 9703 that was so large that it became a float. (Bug#8722)
08686060 9704
2d1fc3c7
PE
9705 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
9706 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9707 Use XFASTINT rather than XUINT when numbers are nonnegative.
9708 (xd_append_arg, Fdbus_method_return_internal):
9709 (Fdbus_method_error_internal): Likewise. Also, for unsigned
9710 arguments, check that Lisp number is nonnegative, rather than
59568bf0 9711 silently wrapping negative numbers around. (Bug#8722)
30217ff0 9712 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 9713 (Bug#8722)
2d1fc3c7 9714
c8a9ca5a
PE
9715 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
9716
519e1d69
PE
9717 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
9718
6df6ae42 9719 ccl: Add integer overflow checks.
30569699
PE
9720 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
9721 (IN_INT_RANGE): New macros.
9722 (ccl_driver): Use them to check for integer overflow when
9723 decoding a CCL program. Many of the new checks are whether XINT (x)
9724 fits in int; it doesn't always, on 64-bit hosts. The new version
9725 doesn't catch all possible integer overflows, but it's an
847044ea 9726 improvement. (Bug#8719)
30569699 9727
c11285dc
PE
9728 * alloc.c (make_event_array): Use XINT, not XUINT.
9729 There's no need for unsigned here.
9730
fdccd48e
PE
9731 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
9732 This follows up to the 2011-05-06 change that substituted uintptr_t
9733 for EMACS_INT. This case wasn't caught back then.
9734
37910ab2
PE
9735 Rework Fformat to avoid integer overflow issues.
9736 * editfns.c: Include <float.h> unconditionally, as it's everywhere
9737 now (part of C89). Include <verify.h>.
9738 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
9739 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
9740 (Fformat): Avoid the prepass trying to compute sizes; it was only
9741 approximate and thus did not catch overflow reliably. Instead, walk
9742 through the format just once, formatting and computing sizes as we go,
9743 checking for integer overflow at every step, and allocating a larger
9744 buffer as needed. Keep track separately whether the format is
9745 multibyte. Keep only the most-recently calculated precision, rather
9746 than them all. Record whether each argument has been converted to
9747 string. Use EMACS_INT, not int, for byte and char and arg counts.
9748 Support field widths and precisions larger than INT_MAX. Avoid
9749 sprintf's undefined behavior with conversion specifications such as %#d
9750 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
9751 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
9752 formatting out-of-range floating point numbers with int
9173deec 9753 formats. (Bug#8668)
37910ab2 9754
2e6578fb
PE
9755 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
9756
0ae6bdee
PE
9757 * data.c: Avoid integer truncation in expressions involving floats.
9758 * data.c: Include <intprops.h>.
9759 (arith_driver): When there's an integer overflow in an expression
9760 involving floating point, convert the integers to floating point
9761 so that the resulting value does not suffer from catastrophic
9762 integer truncation. For example, on a 64-bit host (* 4
9763 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
9764 Do not rely on undefined behavior after integer overflow.
9765
de883a70
PE
9766 merge count_size_as_multibyte, parse_str_to_multibyte
9767 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 9768 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
9769 Check for integer overflow.
9770 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
9771 since it's now a duplicate of the other. This is more of
9772 a character than a buffer op, so better that it's in character.c.
9773 * fns.c, print.c: Adjust to above changes.
9774
2ff916cb
PE
97752011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
9776
9777 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
9778
f1b54466
PE
97792011-05-27 Paul Eggert <eggert@cs.ucla.edu>
9780
fb1ac845
PE
9781 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9782 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
9783 (x_clipboard_manager_save): Now static.
9784 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
9785
f1b54466
PE
9786 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
9787 (crypto_hash_function): Now static.
9788 Fix pointer signedness problems. Avoid unnecessary initializations.
9789
a9f737ee
CY
97902011-05-27 Chong Yidong <cyd@stupidchicken.com>
9791
9792 * termhooks.h (Vselection_alist): Make it terminal-local.
9793
9794 * terminal.c (create_terminal): Initialize it.
9795
9796 * xselect.c: Support for clipboard managers.
9797 (Vselection_alist): Move to termhooks.h as terminal-local var.
9798 (LOCAL_SELECTION): New macro.
9799 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
9800 (symbol_to_x_atom): Remove gratuitous arg.
9801 (x_handle_selection_request, lisp_data_to_selection_data)
9802 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
9803 (x_own_selection, x_get_local_selection, x_convert_selection):
9804 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
9805 (some_frame_on_display): Delete unused function.
9806 (Fx_own_selection_internal, Fx_get_selection_internal)
9807 (Fx_disown_selection_internal, Fx_selection_owner_p)
9808 (Fx_selection_exists_p): New optional frame arg.
9809 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
9810 (x_handle_selection_clear): Don't treat other terminals with the
9811 same keyboard specially. Use the terminal-local Vselection_alist.
9812 (x_clear_frame_selections): Use Frun_hook_with_args.
9813
9814 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
9815
9816 * xterm.h: Add support for those atoms.
9817
e067f0c1
CY
98182011-05-26 Chong Yidong <cyd@stupidchicken.com>
9819
9820 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
9821 (converted_selections, conversion_fail_tag): New global variables.
9822 (x_selection_request_lisp_error): Free the above.
9823 (x_get_local_selection): Remove unnecessary code.
9824 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
9825 of converted selections stored in converted_selections.
9826 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
9827 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
9828 (x_convert_selection): New function.
9829 (x_handle_selection_event): Simplify.
9830 (x_get_foreign_selection): Don't ignore incoming requests while
9831 waiting for an answer; this will fail when we implement
9832 SAVE_TARGETS, and seems unnecessary anyway.
9833 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
9834 (Vx_sent_selection_functions): Doc fix.
9835
0f4aebc0
LL
98362011-05-26 Leo Liu <sdl.web@gmail.com>
9837
9838 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
9839
e61124cd
YM
98402011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9841
9842 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
9843
9844 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
9845 for fringe update if it has periodic bitmap.
ac389d0c 9846 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
9847 and fringe_bitmap_periodic_p.
9848
9849 * fringe.c (get_fringe_bitmap_data): New function.
9850 (draw_fringe_bitmap_1, update_window_fringes): Use it.
9851 (update_window_fringes): Record periodicity of fringe bitmap in glyph
9852 row. Mark glyph row for fringe update if periodicity changed.
9853
9854 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
9855 for fringe update unless it has periodic bitmap.
9856
f16d9837
KH
98572011-05-25 Kenichi Handa <handa@m17n.org>
9858
9859 * xdisp.c (get_next_display_element): Set correct it->face_id for
9860 a static composition.
9861
e1b90ef6
LL
98622011-05-24 Leo Liu <sdl.web@gmail.com>
9863
9864 * deps.mk (fns.o):
9865 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
9866
9867 * fns.c (crypto_hash_function, Fsha1): New function.
9868 (Fmd5): Use crypto_hash_function.
9869 (syms_of_fns): Add Ssha1.
9870
7400048f
PE
98712011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9872
9873 * gnutls.c: Remove unused macros.
9874 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
9875 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
9876 Remove macros that are defined and never used.
9877 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
9878
abb71cf4
CY
98792011-05-22 Chong Yidong <cyd@stupidchicken.com>
9880
9881 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
9882 (Fx_get_selection_internal): Minor cleanup.
9883 (Fx_own_selection_internal): Rename arguments for consistency with
9884 select.el.
9885
6307db39
PE
98862011-05-22 Paul Eggert <eggert@cs.ucla.edu>
9887
9888 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
9889
f3d4e0a4
CY
98902011-05-22 Chong Yidong <cyd@stupidchicken.com>
9891
9892 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
9893
4d8ade89
YM
98942011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
9895
9896 * dispnew.c (scrolling_window): Don't exclude the case that the
9897 last enabled row in the desired matrix touches the bottom boundary.
9898
32078c8d
GM
98992011-05-21 Glenn Morris <rgm@gnu.org>
9900
9901 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
9902 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
9903 and add some more files.
32078c8d 9904
7285dc67
EZ
99052011-05-20 Eli Zaretskii <eliz@gnu.org>
9906
9907 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
9908 report_file_error introduced by the change from 2011-05-07.
9909
89d1bd22
PE
99102011-05-20 Paul Eggert <eggert@cs.ucla.edu>
9911
9912 * systime.h (Time): Define only if emacs is defined.
9913 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
9914 where the include path doesn't have X11/X.h by default. See
9915 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
9916
cd394be1 99172011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
9918
9919 * composite.c (find_automatic_composition): Fix previous change.
9920
b9704ad9
GM
99212011-05-20 Glenn Morris <rgm@gnu.org>
9922
9923 * lisp.mk: New file, split from Makefile.in.
9924 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
9925 (shortlisp): Remove.
9926 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
9927
4a720484
GM
99282011-05-19 Glenn Morris <rgm@gnu.org>
9929
9930 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
9931 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
9932 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
9933 (lisp): Set the order to that of loadup.el.
9934 (shortlisp): Make it a copy of $lisp.
9935 (SOME_MACHINE_LISP): Remove.
9936 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
9937 Use just $shortlisp, not $SOME_MACHINE_LISP too.
9938
a28d4396
KH
99392011-05-18 Kenichi Handa <handa@m17n.org>
9940
9941 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
9942 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
9943 (find_automatic_composition): Mostly rewrite for efficiency.
9944
a2b1fa8e
JB
99452011-05-18 Juanma Barranquero <lekktu@gmail.com>
9946
9947 * makefile.w32-in: Update dependencies.
9948
8e1f5610
CS
99492011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
9950
9951 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 9952 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 9953
7025ee00 99542011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 9955
cdfa6eab
PE
9956 Fix some integer overflow issues, such as string length overflow.
9957
06d6db33
PE
9958 * insdel.c (count_size_as_multibyte): Check for string overflow.
9959
2b4560a8
PE
9960 * character.c (lisp_string_width): Check for string overflow.
9961 Use EMACS_INT, not int, for string indexes and lengths; in
9962 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
9963 the resulting string length overflows an EMACS_INT; instead,
9964 report a string overflow if no precision given. When checking for
9965 precision exhaustion, use a check that cannot possibly have
9966 integer overflow. (Bug#8675)
9967 * character.h (lisp_string_width): Adjust to new signature.
9968
cb93f9be
PE
9969 * alloc.c (string_overflow): New function.
9970 (Fmake_string): Use it. This doesn't change behavior, but saves
9971 a few bytes and will simplify future changes.
9972 * character.c (string_escape_byte8): Likewise.
9973 * lisp.h (string_overflow): New decl.
9974
1a1f3366
PE
9975 Fixups, following up to the user-interface timestamp change.
9976 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
9977 for UI timestamps, instead of unsigned long.
9fbd6841
PE
9978 * msdos.c (mouse_get_pos): Likewise.
9979 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
9980 * w32gui.h (Time): Define by including "systime.h" rather than by
9981 declaring it ourselves. (Bug#8664)
9982
d4e3e4d3
PE
9983 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
9984 * image.c (clear_image_cache): Likewise.
9985
f6a24d19
PE
9986 * term.c (term_mouse_position): Don't assume time_t wraparound.
9987
08dc5ae6
PE
9988 Be more systematic about user-interface timestamps.
9989 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
9990 and sometimes 'EMACS_UINT', to represent these timestamps.
9991 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
9992 This makes the code easier to follow, and makes it easier to catch
9993 integer overflow bugs such as Bug#8664.
9994 * frame.c (Fmouse_position, Fmouse_pixel_position):
9995 Use Time, not unsigned long, for user-interface timestamps.
9996 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
9997 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
9998 * keyboard.h (last_event_timestamp): Likewise.
9999 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
10000 * menu.h (xmenu_show): Likewise.
10001 * term.c (term_mouse_position): Likewise.
10002 * termhooks.h (struct input_event.timestamp): Likewise.
10003 (struct terminal.mouse_position_hook): Likewise.
10004 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
10005 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
10006 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
10007 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
10008 what it was before.
10009 * menu.h, termhooks.h: Include "systime.h", for Time.
10010
8e55734a
PE
10011 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
10012 Don't assume that the difference between two unsigned long values
10013 can fit into an integer. At this point, we know button_down_time
10014 <= event->timestamp, so the difference must be nonnegative, so
10015 there's no need to cast the result if double-click-time is
10016 nonnegative, as it should be; check that it's nonnegative, just in
10017 case. This bug is triggered when events are more than 2**31 ms
86db42d2 10018 apart (about 25 days). (Bug#8664)
8e55734a 10019
841f1b75 10020 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 10021 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 10022
3e26f69c
PE
10023 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
10024 that always fit in int. Use a sentinel instead of a counter, to
10025 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
10026 * frame.h (struct frame): Use int for menu_bar_items_used
10027 instead of EMACS_INT, since it always fits in int.
3e26f69c 10028
5cc152c0
PE
10029 * menu.c (grow_menu_items): Check for int overflow.
10030
d89eb65e
PE
10031 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
10032
5235bd3e
PE
10033 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
10034 Before, the code was not consistent. These values cannot exceed
10035 2**31 - 1 so there's no need to make them unsigned.
10036 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
10037 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
10038 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
10039 as modifiers.
10040 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
10041
bc827e23
PE
10042 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
10043 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
10044 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
10045 presumably because the widths might not match.
10046
78eb494e
PE
10047 * window.c (size_window): Avoid needless test at loop start.
10048
04f2d78b
CB
100492011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
10050
10051 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
10052
d2fc7e3d 100532011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
10054
10055 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
10056
d2fc7e3d 100572011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
10058
10059 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
10060 `width' to `bar_area_x' and `bar_area_width', respectively.
10061 (x_scroll_run): Take account of fringe background extension.
10062
04f2d78b
CB
10063 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
10064 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
10065 `bar_area_width', respectively.
10066 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
10067 background extension.
10068
79b70037
GM
100692011-05-10 Jim Meyering <meyering@redhat.com>
10070
10071 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
10072
2f142cc5
JB
100732011-05-10 Juanma Barranquero <lekktu@gmail.com>
10074
10075 * image.c (Finit_image_library): Return t for built-in image types,
10076 like pbm and xbm. (Bug#8640)
10077
57679c86
AS
100782011-05-09 Andreas Schwab <schwab@linux-m68k.org>
10079
10080 * w32menu.c (set_frame_menubar): Fix submenu allocation.
10081
888c9e86
EZ
100822011-05-07 Eli Zaretskii <eliz@gnu.org>
10083
b0512a1d
EZ
10084 * w32console.c (Fset_screen_color): Doc fix.
10085 (Fget_screen_color): New function.
10086 (syms_of_ntterm): Defsubr it.
10087
7285dc67
EZ
10088 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
10089 unlink the temporary file if Fcall_process didn't create it in the
10090 first place.
10091 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
10092 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
10093 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
10094 cue to call_process_cleanup not to close that handle.
10095
4d3fcc8e
BK
100962011-05-07 Ben Key <bkey76@gmail.com>
10097
10098 * makefile.w32-in: The bootstrap-temacs rule now makes use of
10099 one of two shell specific rules, either bootstrap-temacs-CMD or
10100 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
10101 to the previous implementation of the bootstrap-temacs rule.
10102 The bootstrap-temacs-CMD rule is similar to the previous
10103 implementation of the bootstrap-temacs rule except that it
10104 makes use of the ESC_CFLAGS variable instead of the CFLAGS
10105 variable.
10106
10107 These changes, along with some changes to nt/configure.bat,
10108 nt/gmake.defs, and nt/nmake.defs, are required to extend my
10109 earlier fix to add support for --cflags and --ldflags options
10110 that include quotes so that it works whether make uses cmd or
10111 sh as the shell.
10112
b4289b64
MA
101132011-05-06 Michael Albinus <michael.albinus@gmx.de>
10114
10115 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
10116 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
10117 is a constant.
10118 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
10119 a string. Handle both cases.
10120 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
10121 (Fdbus_register_method): Use Qinvalid_function.
10122
af4c0e28
JB
101232011-05-06 Juanma Barranquero <lekktu@gmail.com>
10124
10125 * makefile.w32-in: Update dependencies.
10126 (LISP_H): Add inttypes.h and stdin.h.
10127 (PROCESS_H): Add unistd.h.
10128
c51453d9
EZ
101292011-05-06 Eli Zaretskii <eliz@gnu.org>
10130
10131 * lread.c: Include limits.h (fixes the MS-Windows build broken by
10132 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
10133
8ff0ac3c 101342011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 10135
4c4b566b
PE
10136 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
10137
aab2b9b5
PE
10138 * term.c (vfatal): Remove stray call to va_end.
10139 It's not needed and the C Standard doesn't allow it here anyway.
10140
c378da0b
PE
10141 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
10142 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
10143
288b08c7
PE
10144 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
10145 bytes.
10146
e3601888
PE
10147 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
10148
db6c0e74
PE
10149 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
10150
dd5963ea
PE
10151 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
10152
88c9450f
PE
10153 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
10154
2f9442b8
PE
10155 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
10156
c032b5f8
PE
10157 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
10158 * charset.c (Fdefine_charset_internal): Don't initialize
10159 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 10160 32-bit int (Bug#8600).
a108c10b
PE
10161
10162 * lread.c (read_integer): Be more consistent with string-to-number.
10163 Use string_to_number to do the actual conversion; this avoids
10164 rounding errors and fixes some other screwups. Without this fix,
10165 for example, #x1fffffffffffffff was misread as -2305843009213693952.
10166 (digit_to_number): Move earlier, for benefit of read_integer.
10167 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 10168 not a digit in any supported base. (Bug#8602)
a108c10b 10169
ad5f9eea
PE
10170 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
10171
aec1708a
PE
10172 * dispnew.c (scrolling_window): Return 1 if we scrolled,
10173 to match comment at start of function. This also removes a
10174 GCC warning about overflow in a 32+64-bit port.
10175
47be4ab5
PE
10176 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
10177
371cac43
PE
10178 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
10179 Reported by Stefan Monnier in
10180 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
10181 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10182 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 10183
d01a7826
PE
10184 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
10185 (EMACS_UINTPTR): Likewise, with uintptr_t.
10186
7fd47d5c
PE
10187 * lisp.h: Prefer 64-bit EMACS_INT if available.
10188 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
10189 on 32-bit hosts that have 64-bit int, so that they can access
10190 large files.
122b0c86
PE
10191 However, temporarily disable this change unless the temporary
10192 symbol WIDE_EMACS_INT is defined.
7fd47d5c 10193
8727937b
PE
10194 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
10195
8ac068ac
PE
10196 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
10197 This removes an assumption that EMACS_INT and long are the same
10198 width as pointers. The assumption is true for Emacs porting targets
10199 now, but we want to make other targets possible.
10200 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
10201 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
10202 In the rest of the code, change types of integers that hold casted
10203 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
10204 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
10205 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
10206 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
10207 No need to cast type when ORing.
10208 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
10209 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
10210 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
10211 assume EMACS_INT is the same width as char *.
10212 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
10213 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
10214 Remove no-longer-needed casts.
10215 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
10216 (xg_tool_bar_help_callback, xg_make_tool_item):
10217 Use EMACS_INTPTR to hold an integer
10218 that will be cast to void *; this can avoid a GCC warning
10219 if EMACS_INT is not the same width as void *.
10220 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
10221 * xdisp.c (display_echo_area_1, resize_mini_window_1):
10222 (current_message_1, set_message_1):
10223 Use a local to convert to proper width without a cast.
10224 * xmenu.c (dialog_selection_callback): Likewise.
10225
ede49d71
PE
10226 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
10227 Also, don't assume VALBITS / RAND_BITS is less than 5,
10228 and don't rely on undefined behavior when shifting a 1 left into
10229 the sign bit.
10230 * lisp.h (get_random): Change signature to match.
10231
2f30ecd0
PE
10232 * lread.c (hash_string): Use size_t, not int, for hash computation.
10233 Normally we prefer signed values; but hashing is special, because
10234 it's better to use unsigned division on hash table sizes so that
10235 the remainder is nonnegative. Also, size_t is the natural width
10236 for hashing into memory. The previous code used 'int', which doesn't
10237 retain enough info to hash well into very large tables.
10238 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
10239
2a866e7b
PE
10240 * dbusbind.c: Don't possibly lose pointer info when converting.
10241 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
10242 Use XPNTR rather than XHASH, so that the high-order bits of
10243 the pointer aren't lost when converting through void *.
10244
51639eac
PE
10245 * eval.c (Fautoload): Don't double-shift a pointer.
10246
92394119
PE
10247 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
10248
dbdb9a7c
JB
102492011-05-06 Juanma Barranquero <lekktu@gmail.com>
10250
10251 * gnutls.c (DEF_GNUTLS_FN):
10252 * image.c (DEF_IMGLIB_FN): Make function pointers static.
10253
db7a0b4f
AS
102542011-05-05 Andreas Schwab <schwab@linux-m68k.org>
10255
10256 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
10257 marker. (Bug#8610)
10258
cd394be1 102592011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
10260
10261 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
10262 New version that can reserve upto 2GB of heap space.
10263
f7ff1b0f 102642011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
10265
10266 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
10267
639c109b
TZ
102682011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
10269
10270 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
10271 `gnutls_certificate_set_x509_key_file'.
10272
d2127135
JB
102732011-05-05 Juanma Barranquero <lekktu@gmail.com>
10274
10275 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
10276 Update dependencies.
10277
e968f4f3
JB
102782011-05-04 Juanma Barranquero <lekktu@gmail.com>
10279
10280 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
10281 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
10282 Remove unused parameter `fildes'.
10283 * process.c (read_process_output, send_process): Don't pass it.
10284
84d358f0
JB
102852011-05-04 Juanma Barranquero <lekktu@gmail.com>
10286
10287 Fix previous change: the library cache is defined in w32.c.
10288 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
10289 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
10290
0898ca10
JB
102912011-05-04 Juanma Barranquero <lekktu@gmail.com>
10292
10293 Implement dynamic loading of GnuTLS on Windows.
10294
10295 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
10296 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
10297 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10298 Declare.
10299
10300 * gnutls.c (Qgnutls_dll): Define.
10301 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
10302 (gnutls_*): Declare function pointers.
10303 (init_gnutls_functions): New function to initialize function pointers.
10304 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
10305 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
10306 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
10307 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
10308 (emacs_gnutls_write, emacs_gnutls_read)
10309 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
10310 (Fgnutls_available_p): New function.
10311 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
10312 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
10313 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
10314
10315 * image.c: Include w32.h.
10316 (Vimage_type_cache): Delete.
10317 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
10318 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
10319 (w32_delayed_load): Move to w32.c.
10320
10321 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
10322
10323 * w32.c (QCloaded_from, Vlibrary_cache): Define.
10324 (w32_delayed_load): Move from image.c. When loading a library, record
10325 its filename in the :loaded-from property of the library id.
10326 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
10327 Initialize and staticpro them.
10328 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
10329
10330 * process.c: Include lisp.h before w32.h, not after.
10331 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
10332 instead of gnutls_record_check_pending.
10333
10334 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
10335
ff4de4aa
TZ
103362011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
10337
10338 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
10339 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
10340 as passed in.
10341
abe95abb
JD
103422011-05-03 Jan Djärv <jan.h.d@swipnet.se>
10343
10344 * xterm.c (x_set_frame_alpha): Do not set property on anything
10345 else than FRAME_X_OUTER_WINDOW (Bug#8608).
10346
e16e55d4
JB
103472011-05-02 Juanma Barranquero <lekktu@gmail.com>
10348
10349 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
10350
bafcf6a5
JB
103512011-05-02 Juanma Barranquero <lekktu@gmail.com>
10352
10353 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
10354 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
10355 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
10356 (gnutls_global_initialized, Qgnutls_bootprop_priority)
10357 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
10358 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
10359 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
10360 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
10361 (Qgnutls_bootprop_callbacks_verify): Make static.
10362
e7a6747f
AS
103632011-05-01 Andreas Schwab <schwab@linux-m68k.org>
10364
19ed11ba
AS
10365 * callproc.c: Indentation fixup.
10366
e7a6747f 10367 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
10368 (wait_for_termination, interruptible_wait_for_termination):
10369 Move after wait_for_termination_1.
e7a6747f 10370
1ef14cb4
LMI
103712011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
10372
10373 * sysdep.c (interruptible_wait_for_termination): New function
10374 which is like wait_for_termination, but allows keyboard
10375 interruptions.
10376
10377 * callproc.c (Fcall_process): Add (:file "file") as an option for
10378 the STDOUT buffer.
10379 (Fcall_process_region): Ditto.
10380
330d880c
EZ
103812011-04-30 Eli Zaretskii <eliz@gnu.org>
10382
8db90b73
EZ
10383 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
10384 rather than `XVECTOR (FOO)->size'.
10385
330d880c
EZ
10386 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
10387 inttypes.h, as a gnulib replacement is used if it not available in
10388 system headers.
10389
15cbd324
EZ
103902011-04-21 Eli Zaretskii <eliz@gnu.org>
10391
10392 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
10393 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
10394 of MOST_POSITIVE_FIXNUM. (Bug#8528)
10395
10396 * coding.c (coding_alloc_by_realloc): Error out if destination
10397 will grow beyond MOST_POSITIVE_FIXNUM.
10398 (decode_coding_emacs_mule): Abort if there isn't enough place in
10399 charbuf for the composition carryover bytes. Reserve an extra
10400 space for up to 2 characters produced in a loop.
10401 (decode_coding_iso_2022): Abort if there isn't enough place in
10402 charbuf for the composition carryover bytes.
10403
104042011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 10405
ae940cca
EZ
10406 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
10407 aborting when %lld or %lll format is passed.
10408 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
10409 %llo or %llx format is passed. (Bug#8545)
10410
03ab8921
EZ
10411 * window.c (window_scroll_line_based): Use a marker instead of
10412 simple variables to record original value of point. (Bug#7952)
10413
afda1437
EZ
10414 * doprnt.c (doprnt): Fix the case where a multibyte sequence
10415 produced by %s or %c overflows available buffer space. (Bug#8545)
10416
f76dee0c
PE
104172011-04-28 Paul Eggert <eggert@cs.ucla.edu>
10418
10419 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 10420 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 10421
fdc5744d
JB
104222011-04-28 Juanma Barranquero <lekktu@gmail.com>
10423
10424 * w32.c (init_environment): Warn about defaulting HOME to C:\.
10425
638f053a
JB
104262011-04-28 Juanma Barranquero <lekktu@gmail.com>
10427
10428 * keyboard.c (Qdelayed_warnings_hook): Define.
10429 (command_loop_1): Run `delayed-warnings-hook'
10430 if Vdelayed_warnings_list is non-nil.
10431 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
10432 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
10433
d178f871
EZ
104342011-04-28 Eli Zaretskii <eliz@gnu.org>
10435
10436 * doprnt.c (doprnt): Don't return value smaller than the buffer
10437 size if the message was truncated. (Bug#8545).
10438
b124fd93
JB
104392011-04-28 Juanma Barranquero <lekktu@gmail.com>
10440
10441 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
10442 (Fx_window_property): #if-0 the whole functions, not just the bodies.
10443
e810457d
PE
104442011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10445
10446 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
10447
ea51cceb
JB
104482011-04-27 Juanma Barranquero <lekktu@gmail.com>
10449
10450 * makefile.w32-in: Update dependencies.
10451
94dcfacf
EZ
104522011-04-27 Eli Zaretskii <eliz@gnu.org>
10453
10454 Improve `doprnt' and its usage. (Bug#8545)
10455 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
10456 `format_end'. Remove support for %l as a conversion specifier.
10457 Don't use xrealloc. Improve diagnostics when the %l size modifier
10458 is used. Update the commentary.
10459
10460 * eval.c (verror): Simplify calculation of size_t.
10461
10462 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
10463 messages.
10464
f61f41d7
PE
104652011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
10466
10467 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
10468 change.
10469
96fb4434
PE
104702011-04-27 Paul Eggert <eggert@cs.ucla.edu>
10471
10472 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
10473 This makes this file independent of the recent pseudovector change.
10474
671875da 104752011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 10476
69e9b5a3
PE
10477 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
10478
b5f869a7 10479 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 10480 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10481 Remove unused local.
c8926152 10482 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 10483
841a1577 10484 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
10485 GCC 4.6.0 optimizes based on type-based alias analysis.
10486 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
10487 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
10488 != &v->size, and therefore "v->size = 1; b->size = 2; return
10489 v->size;" must therefore return 1. This assumption is incorrect
10490 for Emacs, since it type-puns struct Lisp_Vector * with many other
10491 types. To fix this problem, this patch adds a new type struct
f904488f 10492 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
10493 and pseudovectors, and helps optimizing compilers not get fooled
10494 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
10495 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
10496 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
10497 the size member.
eab3844f
PE
10498 (XSETPVECTYPE): Rewrite in terms of new macro.
10499 (XSETPVECTYPESIZE): New macro, specifying both type and size.
10500 This is a bit clearer, and further avoids the possibility of
10501 undesirable aliasing.
10502 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 10503 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
10504 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
10505 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
10506 (ASIZE): Now uses header.size rather than size.
10507 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
10508 to avoid the hassle of writing XVECTOR (foo)->header.size.
10509 (struct vectorlike_header): New type.
eab3844f
PE
10510 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
10511 object, to help avoid aliasing.
10512 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
10513 (SUBRP): Likewise, since Lisp_Subr is a special case.
10514 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
10515 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
10516 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 10517 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
10518 changed to be "header.size" and "header.next".
10519 * buffer.h (struct buffer): Likewise.
10520 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
10521 * frame.h (struct frame): Likewise.
10522 * process.h (struct Lisp_Process): Likewise.
10523 * termhooks.h (struct terminal): Likewise.
10524 * window.c (struct save_window_data, struct saved_window): Likewise.
10525 * window.h (struct window): Likewise.
10526 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
10527 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
10528 * buffer.c (init_buffer_once): Likewise.
10529 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
10530 special case.
10531 * process.c (Fformat_network_address): Use local var for size,
10532 for brevity.
10533
0df1eac5
PE
10534 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
10535
847ab9d1 10536 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
10537 * data.c (atof): Remove decl; no longer used or needed.
10538 (digit_to_number): Move to lread.c.
10539 (Fstring_to_number): Use new string_to_number function, to be
10540 consistent with how the Lisp reader treats infinities and NaNs.
10541 Do not assume that floating-point numbers represent EMACS_INT
10542 without losing information; this is not true on most 64-bit hosts.
10543 Avoid double-rounding errors, by insisting on integers when
10544 parsing non-base-10 numbers, as the documentation specifies.
10545 * lisp.h (string_to_number): New decl, replacing ...
10546 (isfloat_string): Remove.
bc0a5c13 10547 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 10548 (read1): Do not accept +. and -. as integers; this
452f4150
PE
10549 appears to have been a coding error. Similarly, do not accept
10550 strings like +-1e0 as floating point numbers. Do not report
10551 overflow for integer overflows unless the base is not 10 which
10552 means we have no simple and reliable way to continue.
10553 Break out the floating-point parsing into a new
10554 function string_to_number, so that Fstring_to_number parses
10555 floating point numbers consistently with the Lisp reader.
04f2d78b 10556 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
10557 (E_CHAR, EXP_INT): Remove, replacing with ...
10558 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
10559 (string_to_number): New function, replacing isfloat_string.
10560 This function checks for valid syntax and produces the resulting
10561 Lisp float number too. Rework it so that string-to-number
bc0a5c13 10562 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
10563 so that overflow for non-base-10 numbers is reported only when
10564 there's no portable and simple way to convert to floating point.
452f4150 10565
67769ffc
PE
10566 * textprop.c (set_text_properties_1): Rewrite for clarity,
10567 and to avoid GCC warning about integer overflow.
10568
c20db43f
PE
10569 * intervals.h (struct interval): Use EMACS_INT for members
10570 where EMACS_UINT might cause problems. See
10571 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
10572 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
10573 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
10574 All uses changed.
37aa2f85
PE
10575 (offset_intervals): Tell GCC not to worry about length overflow
10576 when negating a negative length.
c20db43f 10577
2538aa2f
PE
10578 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
10579 (overrun_check_free): Likewise.
10580
f2d3008d
PE
10581 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
10582 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
10583 word size.
10584
ec8df744
PE
10585 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10586 (gnutls_make_error): Rename local to avoid shadowing.
10587 (gnutls_emacs_global_deinit): ifdef out; not used.
10588 (Fgnutls_boot): Use const for pointer to readonly storage.
10589 Comment out unused local. Fix pointer signedness problems.
10590
640ee02d
PE
10591 * lread.c (openp): Don't stuff size_t into an 'int'.
10592 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
10593 about possible signed overflow.
10594
6048fb2a
PE
10595 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
10596 (GDK_KEY_g): Don't define if already defined.
10597 (xg_prepare_tooltip): Avoid pointer signedness problem.
10598 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
10599
fa3c87e1
PE
10600 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
10601 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
10602
2172544b
PE
10603 * xfns.c (Fx_window_property): Simplify a bit,
10604 to make a bit faster and to avoid GCC 4.6.0 warning.
10605 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
10606
9b821a21
PE
10607 * fns.c (internal_equal): Don't assume size_t fits in int.
10608
3c616cfa
PE
10609 * alloc.c (compact_small_strings): Tighten assertion a little.
10610
c2982e87
PE
10611 Replace pEd with more-general pI, and fix some printf arg casts.
10612 * lisp.h (pI): New macro, generalizing old pEd macro to other
10613 conversion specifiers. For example, use "...%"pI"d..." rather
10614 than "...%"pEd"...".
10615 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 10616 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
10617 * alloc.c (check_pure_size): Don't overflow by converting size to int.
10618 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
10619 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
10620 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
10621 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
10622 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
10623 64-bit hosts.
10624 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
10625 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
10626 * print.c (safe_debug_print, print_object): Likewise.
10627 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
10628 to int.
6f04d126
PE
10629 Use pI instead of if-then-else-abort. Use %p to avoid casts,
10630 avoiding the 0 flag, which is not portable.
c2982e87
PE
10631 * process.c (Fmake_network_process): Use pI to avoid cast.
10632 * region-cache.c (pp_cache): Likewise.
10633 * xdisp.c (decode_mode_spec): Likewise.
10634 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
10635 behavior on 64-bit hosts with printf arg.
6f04d126 10636 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
10637 (x_stop_queuing_selection_requests): Likewise.
10638 (x_get_window_property): Don't truncate byte count to an 'int'
10639 when tracing.
0b432f21 10640
5e073ec7
PE
10641 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
10642 here, since it parses constructs like leading '-' and spaces,
10643 which are not wanted; and it overflows with large numbers.
10644 Instead, simply match F[0-9]+, which is what is wanted anyway.
10645
36372bf9
PE
10646 * alloc.c: Remove unportable assumptions about struct layout.
10647 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
10648 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
10649 (allocate_vectorlike, make_pure_vector): Use the new macros,
10650 plus offsetof, to remove unportable assumptions about struct layout.
10651 These assumptions hold on all porting targets that I know of, but
10652 they are not guaranteed, they're easy to remove, and removing them
10653 makes further changes easier.
10654
0b432f21
PE
10655 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
10656 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
10657 (string_overrun_cookie): Now const. Use initializers that
10658 don't formally overflow signed char, to avoid warnings.
000098c1
PE
10659 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
10660 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
10661 (allocate_buffer): Don't assume sizeof (struct buffer) is a
10662 multiple of sizeof (EMACS_INT); it need not be, if
10663 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 10664 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 10665
895009e1
JB
106662011-04-26 Juanma Barranquero <lekktu@gmail.com>
10667
10668 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
10669
6a7a1b0b
TZ
106702011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
10671
10672 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 10673 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
10674 Reported by Paul Eggert <eggert@cs.ucla.edu>.
10675
841a1577 106762011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
10677
10678 * lisp.h (Qdebug): List symbol.
895009e1 10679 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
10680 * keyboard.c (debug-on-event): New variable.
10681 (handle_user_signal): Break into debugger when debug-on-event
10682 matches the current signal symbol.
10683
f2d3ba6f
DN
106842011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
10685
10686 * alloc.c (check_sblock, check_string_bytes)
10687 (check_string_free_list): Convert to standard C.
10688
42ce4c63
TZ
106892011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
10690
10691 * w32.c (emacs_gnutls_push): Fix typo.
10692
825cd63c
EZ
106932011-04-25 Eli Zaretskii <eliz@gnu.org>
10694
fb11d64d
EZ
10695 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
10696 "cast to pointer from integer of different size".
10697
825cd63c
EZ
10698 Improve doprnt and its use in verror. (Bug#8545)
10699 * doprnt.c (doprnt): Document the set of format control sequences
10700 supported by the function. Use SAFE_ALLOCA instead of always
10701 using `alloca'.
10702
10703 * eval.c (verror): Don't limit the buffer size at size_max-1, that
10704 is one byte too soon. Don't use xrealloc; instead xfree and
10705 xmalloc anew.
10706
e061a11b
TZ
107072011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
10708
10709 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
10710 callbacks stage.
10711
10712 * gnutls.c: Renamed global_initialized to
10713 gnutls_global_initialized. Added internals for the
10714 :verify-hostname-error, :verify-error, and :verify-flags
10715 parameters of `gnutls-boot' and documented those parameters in the
10716 docstring. Start callback support.
9173deec
JB
10717 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
10718 unless a fatal error occurred. Call gnutls_alert_send_appropriate
10719 on error. Return error code.
e061a11b
TZ
10720 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
10721 (emacs_gnutls_read): Likewise.
10722 (Fgnutls_boot): Return handshake error code.
10723 (emacs_gnutls_handle_error): New function.
10724 (wsaerror_to_errno): Likewise.
10725
10726 * w32.h (emacs_gnutls_pull): Add prototype.
10727 (emacs_gnutls_push): Likewise.
10728
10729 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
10730 (emacs_gnutls_push): Likewise.
10731
107322011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
10733
10734 * process.c (wait_reading_process_output): Check if GnuTLS
10735 buffered some data internally if no FDs are set for TLS
10736 connections.
10737
10738 * makefile.w32-in (OBJ2): Add gnutls.$(O).
10739 (LIBS): Link to USER_LIBS.
10740 ($(BLD)/gnutls.$(0)): New target.
10741
fa6996bc
EZ
107422011-04-24 Eli Zaretskii <eliz@gnu.org>
10743
eb35682e
EZ
10744 * xdisp.c (handle_single_display_spec): Rename the
10745 display_replaced_before_p argument into display_replaced_p, to
10746 make it consistent with the commentary. Fix typos in the
10747 commentary.
10748
e2ad650c
EZ
10749 * textprop.c (syms_of_textprop): Remove dead code.
10750 (copy_text_properties): Delete obsolete commentary about an
10751 interface that was deleted long ago. Fix typos in the description
10752 of arguments.
10753
1b2de274
EZ
10754 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
10755 to changes in oldXMenu/XMenu.h from 2011-04-16.
10756 <menu_help_message, prev_menu_help_message>: Constify.
10757 (IT_menu_make_room): menu->help_text is now `const char **';
10758 adjust.
10759
10760 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
10761 to changes in oldXMenu/XMenu.h from 2011-04-16.
10762 (struct XMenu): Declare `help_text' `const char **'.
10763
10764 * xfaces.c <Qunspecified>: Make extern again.
10765
10766 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 10767 required by POSIX.
1b2de274 10768
762b15be
EZ
10769 * doc.c (get_doc_string): Improve the format passed to `error'.
10770
10771 * doprnt.c (doprnt): Improve commentary.
10772
10773 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
10774
10775 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
10776 them with etags.
10777
f1052e5d
EZ
10778 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
10779 changes in globals.h immediately force recompilation.
762b15be
EZ
10780 (TAGS): Depend on $(CURDIR)/m/intel386.h and
10781 $(CURDIR)/s/ms-w32.h.
10782 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 10783
fa6996bc
EZ
10784 * character.c (Fchar_direction): Function deleted.
10785 (syms_of_character): Don't defsubr it.
10786 <char-direction-table>: Deleted.
10787
e6c3da20
EZ
107882011-04-23 Eli Zaretskii <eliz@gnu.org>
10789
10790 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
10791 * doprnt.c: Include limits.h.
10792 (SIZE_MAX): New macro.
04f2d78b
CB
10793 (doprnt): Return a size_t value. 2nd arg is now size_t.
10794 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
10795 Improve overflow protection. Support `l' modifier for integer
10796 conversions. Support %l conversion. Don't assume an EMACS_INT
10797 argument for integer conversions and for %c.
10798
10799 * lisp.h (doprnt): Restore prototype.
10800
10801 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
10802 $(SRC)/character.h.
10803
10804 * Makefile.in (base_obj): Add back doprnt.o.
10805
10806 * deps.mk (doprnt.o): Add back prerequisites.
10807 (callint.o): Depend on character.h.
10808
10809 * eval.c (internal_lisp_condition_case): Include the handler
10810 representation in the error message.
10811 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
10812 when breaking from the loop.
10813
10814 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
10815
10816 * callint.c (Fcall_interactively): When displaying error message
10817 about invalid control letter, pass the character's codepoint, not
10818 a pointer to its multibyte form. Improve display of the character
10819 in octal and display also its hex code.
10820
10821 * character.c (char_string): Use %x to display the (unsigned)
10822 codepoint of an invalid character, to avoid displaying a bogus
10823 negative value.
10824
10825 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
10826 `error', not SYMBOL_NAME itself.
10827
10828 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
10829 character arguments to `error'.
10830
10831 * charset.c (check_iso_charset_parameter): Fix incorrect argument
10832 to `error' in error message about FINAL_CHAR argument. Make sure
10833 FINAL_CHAR is a character, and use %c when it is passed as
10834 argument to `error'.
10835
4ffd0d6b 108362011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
10837
10838 * s/ms-w32.h (localtime): Redirect to sys_localtime.
10839
10840 * w32.c: Include <time.h>.
10841 (sys_localtime): New function.
10842
4ffd0d6b 108432011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
10844
10845 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
10846
4ffd0d6b 10847 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 10848
4ffd0d6b 108492011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 10850
4ffd0d6b
GM
10851 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
10852 zombies (Bug#8467).
aac0c6e3 10853
04c56954
EZ
108542011-04-19 Eli Zaretskii <eliz@gnu.org>
10855
10856 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
10857 gl_state.e_property when gl_state.object is Qt.
10858
10859 * insdel.c (make_gap_larger): Remove limitation of buffer size
10860 to <= INT_MAX.
10861
16a43933
CY
108622011-04-18 Chong Yidong <cyd@stupidchicken.com>
10863
10864 * xdisp.c (lookup_glyphless_char_display)
10865 (produce_glyphless_glyph): Handle cons cell entry in
10866 glyphless-char-display.
10867 (Vglyphless_char_display): Document it.
10868
10869 * term.c (produce_glyphless_glyph): Handle cons cell entry in
10870 glyphless-char-display.
10871
4581706e
CY
108722011-04-17 Chong Yidong <cyd@stupidchicken.com>
10873
10874 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
10875
10876 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
10877
10878 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
10879 definition for no-X builds.
10880
4887c6e2 108812011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 10882
fd35b6f9
PE
10883 Static checks with GCC 4.6.0 and non-default toolkits.
10884
5c1ccb01
PE
10885 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
10886
006c5daa
PE
10887 * process.c (keyboard_bit_set): Define only if SIGIO.
10888 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
10889 (send_process): Repair possible setjmp clobbering.
10890
efc736d3
PE
10891 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
10892
4e2fe2e6
PE
10893 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
10894
f97334a2
PE
10895 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
10896
4e75f29d
PE
10897 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
10898 Define only if needed.
10899
90efadd1
PE
10900 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
10901 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 10902 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 10903
3c647824
PE
10904 * dispextern.h (struct redisplay_interface): Rename param
10905 to avoid shadowing.
e264f262 10906 * termhooks.h (struct terminal): Likewise.
761383f4 10907 * xterm.c (xembed_send_message): Likewise.
3c647824 10908
b58c5c4a
PE
10909 * insdel.c (make_gap_smaller): Define only if
10910 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
10911
cad59032
PE
10912 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
10913 it.
10914
c339dc2e
PE
10915 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10916 so that we aren't warned about unused symbols.
10917
91a3e27b
PE
10918 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
10919
399c71d3 10920 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 10921
8ffc96f5
PE
10922 * xfns.c (x_real_positions): Mark locals as initialized.
10923
eef9bc79
PE
10924 * xmenu.c (xmenu_show): Don't use uninitialized vars.
10925
098db9dd
PE
10926 * xterm.c: Fix problems found by static analysis with other toolkits.
10927 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
10928 (x_dispatch_event): Declare static if USE_GTK, and
10929 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 10930 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 10931 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
10932 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
10933 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 10934
eb18f6cc
PE
10935 * xmenu.c (menu_help_callback): Pointer type fixes.
10936 Use const pointers when pointing at readonly data. Avoid pointer
10937 signedness clashes.
10938 (FALSE): Remove unused macro.
10939 (update_frame_menubar): Remove unused decl.
10940
1fe72bf8
PE
10941 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
10942
60d9e1db
PE
10943 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
10944 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
10945 (single_menu_item): Rename local to avoid shadowing.
10946
39261c26
PE
10947 * keyboard.c (make_lispy_event): Remove unused local var.
10948
018c5e19
PE
10949 * frame.c, frame.h (x_get_resource_string): Bring this back, but
10950 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
10951
63d2b86e
PE
10952 * bitmaps: Change bitmaps from unsigned char back to the X11
10953 compatible char. Avoid the old compiler warnings about
10954 out-of-range initializers by using, for example, '\xab' rather
10955 than 0xab.
10956
aefd87e1
PE
10957 * xgselect.c (xgselect_initialize): Check vs interface
10958 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
10959
bf501fb9
PE
10960 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
10961
e9829fdf
PE
10962 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
10963 to read-only memory.
10964
1086c095
PE
10965 * fns.c (vector): Remove; this old hack is no longer needed.
10966
2baccd04 10967 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 10968 Remove unused var.
dde42981 10969 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 10970
72391843 10971 * xrdb.c (x_load_resources): Omit unused local.
3565b346 10972
436c16df 10973 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 10974 (x_window): Rename locals to avoid shadowing.
dc5ddd85 10975 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 10976
92bb796d 10977 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 10978 (x_term_init): Remove local to avoid shadowing.
92bb796d 10979
764430a3 10980 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
10981
10982 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
10983 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
10984
d1dfb56c
EZ
109852011-04-16 Eli Zaretskii <eliz@gnu.org>
10986
c4354cb4
EZ
10987 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
10988
d1dfb56c
EZ
10989 Fix regex.c, syntax.c and friends for buffers > 2GB.
10990 * syntax.h (struct gl_state_s): Declare character position members
10991 EMACS_INT.
10992
10993 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
10994
04f2d78b
CB
10995 * textprop.c (verify_interval_modification, interval_of):
10996 Declare arguments EMACS_INT.
d1dfb56c
EZ
10997
10998 * intervals.c (adjust_intervals_for_insertion): Declare arguments
10999 EMACS_INT.
11000
11001 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
11002
11003 * indent.c (Fvertical_motion): Local variable it_start is now
11004 EMACS_INT.
11005
11006 * regex.c (re_match, re_match_2, re_match_2_internal)
11007 (bcmp_translate, regcomp, regexec, print_double_string)
11008 (group_in_compile_stack, re_search, re_search_2, regex_compile)
11009 (re_compile_pattern, re_exec): Declare arguments and local
11010 variables `size_t' and `ssize_t' and return values `regoff_t', as
11011 appropriate.
11012 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
11013 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
11014 <compile_stack_type>: `size' and `avail' are now `size_t'.
11015
11016 * regex.h <regoff_t>: Use ssize_t, not int.
11017 (re_search, re_search_2, re_match, re_match_2): Arguments that
11018 specify buffer/string position and length are now ssize_t and
11019 size_t. Return type is regoff_t.
11020
613052cd
BK
110212011-04-16 Ben Key <bkey76@gmail.com>
11022
11023 * nsfont.m: Fixed bugs in ns_get_family and
11024 ns_descriptor_to_entity that were caused by using free to
11025 deallocate memory blocks that were allocated by xmalloc (via
11026 xstrdup). This caused Emacs to crash when compiled with
11027 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
11028 --enable-checking=xmallocoverrun). xfree is now used to
11029 deallocate these memory blocks.
11030
4170f62f 110312011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 11032
71b41406
PE
11033 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
11034
9587a89d
PE
11035 emacs_write: Accept and return EMACS_INT for sizes.
11036 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
11037 et seq.
11038 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
11039 Accept and return EMACS_INT.
11040 (emacs_gnutls_write): Return the number of bytes written on
11041 partial writes.
11042 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
11043 (emacs_read, emacs_write): Remove check for negative size, as the
11044 Emacs source code has been audited now.
9587a89d
PE
11045 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
11046 (emacs_read, emacs_write): Use it.
273a5f82
PE
11047 * process.c (send_process): Adjust to the new signatures of
11048 emacs_write and emacs_gnutls_write. Do not attempt to store
11049 a byte offset into an 'int'; it might overflow.
9587a89d 11050 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 11051
3e047f51
PE
11052 * sound.c: Don't assume sizes fit in 'int'.
11053 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 11054 Return EMACS_INT, not int.
3e047f51 11055 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
11056 Accept EMACS_INT, not int.
11057 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
11058 record read return values.
11059
cc39a9db
BK
110602011-04-15 Ben Key <bkey76@gmail.com>
11061
c9d0ec6d
JB
11062 * keyboard.c (Qundefined): Don't declare static since it is used
11063 in nsfns.m.
11064 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
11065 static since they are used in nsfont.m.
cc39a9db 11066
6c60eb9f
SM
110672011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
11068
11069 * process.c (Qprocessp): Don't declare static.
11070 * lisp.h (Qprocessp): Declare again.
11071
7990b61a
JB
110722011-04-15 Juanma Barranquero <lekktu@gmail.com>
11073
11074 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
11075
5d4cb038
PE
110762011-04-14 Paul Eggert <eggert@cs.ucla.edu>
11077
8bd7b830 11078 Improve C-level modularity by making more things 'static'.
cd64ea1d 11079
e3b27b31
PE
11080 Don't publish debugger-only interfaces to other modules.
11081 * lisp.h (safe_debug_print, debug_output_compilation_hack):
11082 (verify_bytepos, count_markers): Move decls to the only modules
11083 that need them.
11084 * region-cache.h (pp_cache): Likewise.
11085 * window.h (check_all_windows): Likewise.
11086 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
11087
5d4cb038
PE
11088 * sysdep.c (croak): Now static, if
11089 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
11090 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
11091
11092 * alloc.c (refill_memory_reserve): Now static if
11093 !defined REL_ALLOC || defined SYSTEM_MALLOC.
11094 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 11095
e87b6180
PE
11096 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
11097 Define only if USE_LUCID.
11098
ac64929e
PE
11099 * xrdb.c (x_customization_string, x_rm_string): Now static.
11100
6f37259d
PE
11101 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
11102 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
11103
1683e3ab
PE
11104 * xdisp.c (draw_row_with_mouse_face): Now static.
11105 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
11106
de9c2632
PE
11107 * window.h (check_all_windows): Mark externally visible.
11108
2b96acb7
PE
11109 * window.c (window_deletion_count): Now static.
11110
11111 * undo.c: Make symbols static if they're not exported.
11112 (last_undo_buffer, last_boundary_position, pending_boundary):
11113 Now static.
11114
50436f33
PE
11115 * textprop.c (interval_insert_behind_hooks): Now static.
11116 (interval_insert_in_front_hooks): Likewise.
11117
64520e5c
PE
11118 * term.c: Make symbols static if they're not exported.
11119 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
11120 (max_frame_lines, tty_set_terminal_modes):
11121 (tty_reset_terminal_modes, tty_turn_off_highlight):
11122 (get_tty_terminal): Now static.
11123 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
11124 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 11125 HAVE_WINDOW_SYSTEM.
64520e5c
PE
11126 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
11127 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
11128
1fa53021
PE
11129 * sysdep.c: Make symbols static if they're not exported.
11130 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
11131 Now static.
11132 (sigprocmask_set, full_mask): Remove; unused.
11133 (wait_debugging): Mark as visible.
11134 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
11135 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
11136
d4b43b22
PE
11137 * syntax.c (syntax_temp): Define only if !__GNUC__.
11138
b7c513d0
PE
11139 * sound.c (current_sound_device, current_sound): Now static.
11140
989b29ad
PE
11141 * search.c (searchbufs, searchbuf_head): Now static.
11142
13a55a78
PE
11143 * scroll.c (scroll_cost): Remove; unused.
11144 * dispextern.h (scroll_cost): Remove decl.
11145
de68a1fc
PE
11146 * region-cache.h (pp_cache): Mark as externally visible.
11147
40ccffa6
PE
11148 * process.c: Make symbols static if they're not exported.
11149 (process_tick, update_tick, create_process, chan_process):
11150 (Vprocess_alist, proc_buffered_char, datagram_access):
11151 (fd_callback_data, send_process_frame, process_sent_to): Now static.
11152 (deactivate_process): Mark defn as static, as well as decl.
11153 * lisp.h (create_process): Remove decl.
11154 * process.h (chan_process, Vprocess_alist): Remove decls.
11155
ad64fc97
PE
11156 * print.c: Make symbols static if they're not exported.
11157 (print_depth, new_backquote_output, being_printed, print_buffer):
11158 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
11159 (print_interval, print_number_index, initial_stderr_stream):
11160 Now static.
11161 * lisp.h (Fprinc): Remove decl.
11162 (debug_output_compilation_hack): Mark as externally visible.
11163
adddb265
PE
11164 * sysdep.c (croak): Move decl from here to syssignal.h.
11165 * syssignal.h (croak): Put it here, so the API can be checked when
11166 'croak' is called from dissociate_if_controlling_tty.
11167
1717ede2
PE
11168 * minibuf.c: Make symbols static if they're not exported.
11169 (minibuf_save_list, choose_minibuf_frame): Now static.
11170 * lisp.h (choose_minibuf_frame): Remove decl.
11171
fa5fb2bc
PE
11172 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
11173
1e3890d1
PE
11174 * lread.c: Make symbols static if they're not exported.
11175 (read_objects, initial_obarray, oblookup_last_bucket_number):
11176 Now static.
11177 (make_symbol): Remove; unused.
11178 * lisp.h (initial_obarray, make_symbol): Remove decls.
11179
8a1414fa
PE
11180 * keyboard.c: Make symbols static if they're not exported.
11181 (single_kboard, recent_keys_index, total_keys, recent_keys):
11182 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
11183 (this_single_command_key_start, echoing, last_auto_save):
11184 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
11185 (command_loop, echo_now, keyboard_init_hook, help_char_p):
11186 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
11187 (Vlispy_mouse_stem, double_click_count):
11188 Now static.
11189 (force_auto_save_soon): Define only if SIGDANGER.
11190 (ignore_mouse_drag_p): Now static if
11191 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
11192 (print_help): Remove; unused.
11193 (stop_character, last_timer_event): Mark as externally visible.
11194 * keyboard.h (ignore_mouse_drag_p): Declare only if
11195 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
11196 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
11197 * lisp.h (echoing): Remove decl.
11198 (force_auto_save_soon): Declare only if SIGDANGER.
11199 * xdisp.c (redisplay_window): Simplify code, to make it more
11200 obvious that ignore_mouse_drag_p is not accessed if !defined
11201 USE_GTK && !defined HAVE_NS.
11202
93ea6e8f
PE
11203 * intervals.c: Make symbols static if they're not exported.
11204 (merge_properties_sticky, merge_interval_right, delete_interval):
11205 Now static.
11206 * intervals.h (merge_interval_right, delete_interval): Remove decls.
11207
77382fcc
PE
11208 * insdel.c: Make symbols static if they're not exported.
11209 However, leave prepare_to_modify_buffer alone. It's never
11210 called from outside this function, but that appears to be a bug.
11211 (combine_after_change_list, combine_after_change_buffer):
4889fc82 11212 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
11213 (adjust_after_replace_noundo): Remove; unused.
11214 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 11215 (signal_before_change): Remove decls.
77382fcc 11216
9306c32e
PE
11217 * indent.c (val_compute_motion, val_vmotion): Now static.
11218
cd44d2eb
PE
11219 * image.c: Make symbols static if they're not exported.
11220 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
11221 if USE_GTK.
11222 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
11223 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
11224
ad9a7a06
PE
11225 * fringe.c (standard_bitmaps): Now static.
11226 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
11227
81626931
PE
11228 * frame.c: Make symbols static if they're not exported.
11229 (x_report_frame_params, make_terminal_frame): Now static.
11230 (get_frame_param): Now static, unless HAVE_NS.
11231 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
11232 (x_get_resource_string): Remove; not used.
11233 * frame.h (make_terminal_frame, x_report_frame_params):
11234 (x_get_resource_string); Remove decls.
11235 (x_fullscreen_adjust): Declare only if WINDOWSNT.
11236 * lisp.h (get_frame_param): Declare only if HAVE_NS.
11237
239f9db9
PE
11238 * font.c, fontset.c: Make symbols static if they're not exported.
11239 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
11240 (FACE_SUITABLE_FOR_CHAR_P): Use it.
11241 * font.c (font_close_object): Now static.
11242 * font.h (font_close_object): Remove.
11243 * fontset.c (FONTSET_OBJLIST): Remove.
11244 (free_realized_fontset) #if-0 the body, which does nothing.
11245 (face_suitable_for_char_p): #if-0, as it's never called.
11246 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
11247 * xfaces.c (face_at_string_position):
11248 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
11249 since 0 is always ASCII.
11250
dfcf3579
PE
11251 * fns.c (weak_hash_tables): Now static.
11252
5045092b
PE
11253 * fileio.c: Make symbols static if they're not exported.
11254 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
11255 (Vwrite_region_annotation_buffers): Now static.
11256
57a96f5c
PE
11257 * eval.c: Make symbols static if they're not exported.
11258 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
11259 * lisp.h (backtrace_list): Remove decl.
11260
35f08c38
PE
11261 * emacs.c: Make symbols static if they're not exported.
11262 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
11263 (fatal_error_code, fatal_error_signal_hook, standard_args):
11264 Now static.
11265 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
11266 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
11267 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
11268 * lisp.h (fatal_error_signal_hook): Remove decl.
11269 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
11270
f44bd759
PE
11271 * editfns.c: Move a (normally-unused) function to its only use.
11272 * editfns.c, lisp.h (get_operating_system_release): Remove.
11273 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
11274 worth the hassle of breaking this out.
11275
b532497d
PE
11276 * xterm.c: Make symbols static if they're not exported.
11277 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
11278 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
11279 (x_destroy_window, x_delete_display):
11280 Now static.
11281 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
11282 (x_mouse_leave): Remove; unused.
11283 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
11284 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
11285 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
11286 Remove decls.
11287 (x_mouse_leave): Declare only if WINDOWSNT.
11288 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
11289 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
11290 USE_X_TOOLKIT.
11291
1675728f
PE
11292 * ftxfont.c: Make symbols static if they're not exported.
11293 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
11294 HAVE_FREETYPE.
11295 * font.h (ftxfont_driver): Likewise.
11296
e4cebfca
PE
11297 * xfns.c: Make symbols static if they're not exported.
11298 (x_last_font_name, x_display_info_for_name):
11299 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
11300 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
11301 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
11302 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
11303 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
11304 (last_show_tip_args): Now static.
11305 (xic_defaut_fontset, xic_create_fontsetname): Define only if
11306 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
11307 (x_screen_planes): Remove; unused.
11308 * dispextern.h (x_screen_planes): Remove decl.
11309
5bf46f05
PE
11310 * dispnew.c: Make symbols static if they're not exported.
11311 * dispextern.h (redraw_garbaged_frames, scrolling):
11312 (increment_row_positions): Remove.
11313 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
11314 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
11315 Now static.
11316 (redraw_garbaged_frames): Remove; unused.
11317
435f4c28
PE
11318 * xfaces.c: Make symbols static if they're not exported.
11319 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
11320 Remove decls.
11321 * xterm.h (defined_color): Remove decls.
11322 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
11323 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
11324 (menu_face_changed_default, defined_color, free_realized_face):
11325 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
11326 (ascii_face_of_lisp_face): Remove; unused.
11327
8524aef3
PE
11328 * xdisp.c: Make symbols static if they're not exported.
11329 * dispextern.h (scratch_glyph_row, window_box_edges):
11330 (glyph_to_pixel_coords, set_cursor_from_row):
11331 (get_next_display_element, set_iterator_to_next):
11332 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
11333 (show_mouse_face): Remove decls
11334 * frame.h (message_buf_print): Likewise.
11335 * lisp.h (pop_message, set_message, check_point_in_composition):
11336 Likewise.
11337 * xterm.h (set_vertical_scroll_bar): Likewise.
11338 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
11339 (message_buf_print, scratch_glyph_row, displayed_buffer):
11340 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
11341 (get_next_display_element, show_mouse_face, window_box_edges):
11342 (frame_to_window_pixel_xy, check_point_in_composition):
11343 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
11344 (glyph_to_pixel_coords): Remove; unused.
11345
16390cd2
PE
11346 * dired.c (file_name_completion): Now static.
11347
11348 * dbusbind.c (xd_in_read_queued_messages): Now static.
11349
a25f4dfa
PE
11350 * lisp.h (circular_list_error, FOREACH): Remove; unused.
11351 * data.c (circular_list_error): Remove.
11352
14a9c8df
PE
11353 * commands.h (last_point_position, last_point_position_buffer):
11354 (last_point_position_window): Remove decls.
11355 * keyboard.c: Make these variables static.
11356
04f2d78b
CB
11357 * coding.h (coding, code_convert_region, encode_coding_gap):
11358 Remove decls.
74ab6df5
PE
11359 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
11360 (iso_code_class, detect_coding, code_convert_region): Now static.
11361 (encode_coding_gap): Remove; unused.
11362
38dfbee1
PE
11363 * chartab.c (chartab_chars, chartab_bits): Now static.
11364
a2cb4e63
PE
11365 * charset.h (charset_iso_8859_1): Remove decl.
11366 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
11367 Now static.
11368
127198fd
PE
11369 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
11370 * ccl.c (Vccl_program_table): Now static.
11371 (check_ccl_update): Remove; unused.
11372
d85b608f
PE
11373 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
11374 * category.h: ... from here.
11375 * category.c (check_category_table, set_category_set): Now static.
11376
31cd66f3
PE
11377 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
11378 * lisp.h: Remove these decls.
11379
c358e587
PE
11380 * buffer.c (buffer_count): Remove unused var.
11381
e78aecca
PE
11382 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
11383 so that it's not optimized away.
11384 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
11385 * dispextern.h (bidi_dump_cached_states): Remove, since it's
11386 exported only to the debugger.
11387
e192d7d3 11388 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 11389 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 11390
92470028
PE
11391 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
11392 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
11393 was inaccessible from Lisp.
11394 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
11395 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
11396
244ed907
PE
11397 alloc.c: Import and export fewer symbols, and remove unused items.
11398 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
11399 is defined.
11400 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
11401 it's not optimized away by whole-program optimization.
11402 (message_enable_multibyte, free_misc): Remove.
11403 (catchlist, handlerlist, mark_backtrace):
11404 Declare only if BYTE_MARK_STACK.
11405 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
11406 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
11407 (message_enable_multibyte): Remove decl.
11408 (free_misc, interval_free_list, float_block, float_block_index):
11409 (n_float_blocks, float_free_list, cons_block, cons_block_index):
11410 (cons_free_list, last_marked_index):
11411 Now static.
11412 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
11413 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
11414 (mark_backtrace): Define only if BYTE_MARK_STACK.
11415 * xdisp.c (message_enable_multibyte): Now static.
11416
61c2b50e 11417 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
11418 This makes it easier for human readers (and static analyzers)
11419 to see whether these variables are used from other modules.
11420 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
11421 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
11422 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
11423 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
11424 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
11425 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
11426 * xmenu.c, xselect.c:
11427 Declare Q* vars static if they are not used in other modules.
11428 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
11429 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
11430 Remove decls of unexported vars.
11431 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
11432
95c82688
PE
11433 * lisp.h (DEFINE_FUNC): Make sname 'static'.
11434
16a97296
PE
11435 Make Emacs functions such as Fatom 'static' by default.
11436 This makes it easier for human readers (and static analyzers)
11437 to see whether these functions can be called from other modules.
11438 DEFUN now defines a static function. To make the function external
11439 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
11440 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
11441 (Finit_image_library):
16a97296
PE
11442 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
11443 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
11444 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
11445 Remove decls, since these functions are now static.
11446 (Funintern, Fget_internal_run_time): New decls, since these functions
11447 were already external.
95c82688 11448
16a97296
PE
11449 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
11450 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
11451 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
11452 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
11453 * keyboard.c, keymap.c, lread.c:
11454 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
11455 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
11456 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
11457 Mark functions with DEFUE instead of DEFUN,
11458 if they are used in other modules.
11459 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
11460 decls for now-static functions.
11461 * buffer.h (Fdelete_overlay): Remove decl.
11462 * callproc.c (Fgetenv_internal): Mark as internal.
11463 * composite.c (Fremove_list_of_text_properties): Remove decl.
11464 (Fcomposition_get_gstring): New forward static decl.
11465 * composite.h (Fcomposite_get_gstring): Remove decl.
11466 * dired.c (Ffile_attributes): New forward static decl.
11467 * doc.c (Fdocumntation_property): New forward static decl.
11468 * eval.c (Ffetch_bytecode): New forward static decl.
11469 (Funintern): Remove extern decl; now in .h file where it belongs.
11470 * fileio.c (Fmake_symbolic_link): New forward static decl.
11471 * image.c (Finit_image_library): New forward static decl.
11472 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
11473 * intervals.h (Fprevious_property_change):
11474 (Fremove_list_of_text_properties): Remove decls.
11475 * keyboard.c (Fthis_command_keys): Remove decl.
11476 (Fcommand_execute): New forward static decl.
11477 * keymap.c (Flookup_key): New forward static decl.
11478 (Fcopy_keymap): Now static.
11479 * keymap.h (Flookup_key): Remove decl.
11480 * process.c (Fget_process): New forward static decl.
11481 (Fprocess_datagram_address): Mark as internal.
11482 * syntax.c (Fsyntax_table_p): New forward static decl.
11483 (skip_chars): Remove duplicate decl.
11484 * textprop.c (Fprevious_property_change): New forward static decl.
11485 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
11486 Now internal.
11487 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
11488 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
11489
785bbd42
PE
11490 * editfns.c (Fformat): Remove unreachable code.
11491
8b913b57
AS
114922011-04-14 Andreas Schwab <schwab@linux-m68k.org>
11493
11494 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
11495 change. (Bug#8496)
11496
a6744a35
EZ
114972011-04-13 Eli Zaretskii <eliz@gnu.org>
11498
11499 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
11500 when at ZV. (Bug#8487)
11501
e7974947
AS
115022011-04-12 Andreas Schwab <schwab@linux-m68k.org>
11503
baad03f0
AS
11504 * charset.c (Fclear_charset_maps): Use xfree instead of free.
11505 (Bug#8437)
11506 * keyboard.c (parse_tool_bar_item): Likewise.
11507 * sound.c (sound_cleanup, alsa_close): Likewise.
11508 * termcap.c (tgetent): Likewise.
11509 * xfns.c (x_default_font_parameter): Likewise.
11510 * xsettings.c (read_and_apply_settings): Likewise.
11511
e7974947
AS
11512 * alloc.c (overrun_check_malloc, overrun_check_realloc)
11513 (overrun_check_free): Protoize.
11514
28272684
PE
115152011-04-12 Paul Eggert <eggert@cs.ucla.edu>
11516
11517 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
11518 since callers should never pass a negative size.
11519 Change the signature to match that of plain 'read' and 'write'; see
11520 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
11521 * lisp.h: Update prototypes of emacs_write and emacs_read.
11522
11997c76
EZ
115232011-04-11 Eli Zaretskii <eliz@gnu.org>
11524
11525 * xdisp.c (redisplay_window): Don't try to determine the character
11526 position of the scroll margin if the window start point w->startp
e896f03c 11527 is outside the buffer's accessible region. (Bug#8468)
11997c76 11528
8a2cbd72
EZ
115292011-04-10 Eli Zaretskii <eliz@gnu.org>
11530
11531 Fix write-region and its subroutines for buffers > 2GB.
11532 * fileio.c (a_write, e_write): Modify declaration of arguments and
11533 local variables to support buffers larger than 2GB.
11534 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
11535
11536 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
11537 argument, local variables, and return value.
11538
11539 * lisp.h: Update prototypes of emacs_write and emacs_read.
11540
11541 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
11542
4073e537 115432011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 11544
1ebfdcb6
PE
11545 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
11546
b2ded58d
PE
11547 Fix more problems found by GCC 4.6.0's static checks.
11548
7d66342c
PE
11549 * xdisp.c (vmessage): Use a better test for character truncation.
11550
bbf47d44
PE
11551 * charset.c (load_charset_map): <, not <=, for optimization,
11552 and to avoid potential problems with integer overflow.
9248994d 11553 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 11554 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 11555 * editfns.c (Fformat): Likewise.
1e69125e 11556 * syntax.c (skip_chars): Likewise.
3befa583 11557
e3019616
PE
11558 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
11559 This also lets GCC 4.6.0 generate slightly better loop code.
11560
becfa255
PE
11561 * callint.c (Fcall_interactively): <, not <=, for optimization.
11562 (Fcall_interactively): Count the number of arguments produced,
11563 not the number of arguments given. This is simpler and lets GCC
11564 4.6.0 generate slightly better code.
11565
dae0cd48
PE
11566 * ftfont.c: Distingish more carefully between FcChar8 and char.
11567 The previous code passed unsigned char * to a functions like
11568 strlen and xstrcasecmp that expect char *, which does not
11569 conform to the C standard.
11570 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
11571 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
11572 char * when the C standard requires it.
11573
76032d70
PE
11574 * keyboard.c (read_char): Remove unused var.
11575
eb3f1cc8
PE
11576 * eval.c: Port to Windows vsnprintf (Bug#8435).
11577 Include <limits.h>.
11578 (SIZE_MAX): Define if the headers do not.
11579 (verror): Do not give up if vsnprintf returns a negative count.
11580 Instead, grow the buffer. This ports to Windows vsnprintf, which
11581 does not conform to C99. Problem reported by Eli Zaretskii.
11582 Also, simplify the allocation scheme, by avoiding the need for
11583 calling realloc, and removing the ALLOCATED variable.
11584
70476b54
PE
11585 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
11586
12020a9e
PE
11587 Remove invocations of doprnt, as Emacs now uses vsnprintf.
11588 But keep the doprint source code for now, as we might revamp it
11589 and use it again (Bug#8435).
ea6c7ae6
PE
11590 * lisp.h (doprnt): Remove.
11591 * Makefile.in (base_obj): Remove doprnt.o.
11592 * deps.mk (doprnt.o): Remove.
11593
5fdb398c
PE
11594 error: Print 32- and 64-bit integers portably (Bug#8435).
11595 Without this change, on typical 64-bit hosts error ("...%d...", N)
11596 was used to print both 32- and 64-bit integers N, which relied on
11597 undefined behavior.
61bdb816 11598 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
11599 * lisp.h (error, verror): Mark as printf-like functions.
11600 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
11601 Report overflow in size calculations when allocating printf buffer.
11602 Do not truncate output string at its first null byte.
11603 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
11604 Truncate the output at a character boundary, since vsnprintf does not
11605 do that.
11606 * charset.c (check_iso_charset_parameter): Convert internal
11607 character to string before calling 'error', since %c now has the
11608 printf meaning.
11609 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
11610 overflow when computing char to be passed to 'error'. Do not
11611 pass Lisp_Object to 'error'; pass the integer instead.
11612 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
11613 formatted with plain %d.
11614
b189fa66
PE
11615 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
11616
bff87ef0
PE
11617 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
11618
7e2cac20
PE
11619 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
11620
ce4d90b5
PE
11621 * xterm.c (x_catch_errors): Remove duplicate declaration.
11622
266c9547
PE
11623 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
11624
79c49ad2
PE
11625 * xdisp.c, lisp.h (message_nolog): Remove; unused.
11626
368f4090
JM
116272011-04-10 Jim Meyering <meyering@redhat.com>
11628
11629 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
11630 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
11631 return ssize_t not "int", and use size_t as the buffer length.
11632 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
11633 * gnutls.h: Update declarations.
11634 * process.c (read_process_output): Use ssize_t, to match.
11635 (send_process): Likewise.
11636
a32d4040
CY
116372011-04-09 Chong Yidong <cyd@stupidchicken.com>
11638
11639 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
11640
8546720e 116412011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 11642
04f2d78b
CB
11643 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
11644 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 11645
8546720e
GM
11646 * xterm.c (handle_one_xevent):
11647 * xmenu.c (create_and_show_popup_menu):
11648 * xselect.c (x_decline_selection_request)
11649 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 11650
0a2f5c1a 116512011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
11652
11653 Fix some uses of `int' instead of EMACS_INT.
11654 * search.c (string_match_1, fast_string_match)
11655 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
11656 (scan_buffer, find_next_newline_no_quit)
11657 (find_before_next_newline, search_command, Freplace_match)
11658 (Fmatch_data): Make some `int' variables be EMACS_INT.
11659
11660 * xdisp.c (display_count_lines): 3rd argument and return value now
11661 EMACS_INT. All callers changed.
11662 (pint2hrstr): Last argument is now EMACS_INT.
11663
11664 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
11665 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
11666 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
11667 (decode_coding_utf_16, decode_coding_emacs_mule)
11668 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
11669 (decode_coding_ccl, decode_coding_charset)
11670 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
11671 (decode_coding_iso_2022, decode_coding_emacs_mule)
11672 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
11673 <char_offset, last_offset>: Declare EMACS_INT.
11674 (encode_coding_utf_8, encode_coding_utf_16)
11675 (encode_coding_emacs_mule, encode_invocation_designation)
11676 (encode_designation_at_bol, encode_coding_iso_2022)
11677 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
11678 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
11679 Declare EMACS_INT.
11680 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
11681 (encode_invocation_designation): Last argument P_NCHARS is now
11682 EMACS_INT.
11683 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
11684 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
11685
11686 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
11687 All users changed.
11688
11689 * ccl.c (Fccl_execute_on_string): Declare some variables
11690 EMACS_INT.
11691
8546720e 116922011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
11693
11694 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
11695
4e19a977
CS
116962011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
11697
11698 * process.c (Fformat_network_address): Doc fix.
11699
87302331
R
117002011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
11701
ee7683eb 11702 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 11703
cbb59342
CY
117042011-04-08 Chong Yidong <cyd@stupidchicken.com>
11705
11706 * keyboard.c (read_char): Call Lisp function help-form-show,
11707 instead of using internal_with_output_to_temp_buffer.
11708 (Qhelp_form_show): New var.
e0d38eeb 11709 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
11710
11711 * print.c (internal_with_output_to_temp_buffer): Function deleted.
11712
11713 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
11714
e67a13ab
CY
117152011-04-06 Chong Yidong <cyd@stupidchicken.com>
11716
04f2d78b
CB
11717 * process.c (Flist_processes): Remove to Lisp.
11718 (list_processes_1): Delete.
e67a13ab 11719
973f782d
EZ
117202011-04-06 Eli Zaretskii <eliz@gnu.org>
11721
7c106b1e
EZ
11722 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
11723
973f782d
EZ
11724 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
11725
41cf7d1a 117262011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 11727
ca23cc88
PE
11728 Fix more problems found by GCC 4.6.0's static checks.
11729
f390e2d5
PE
11730 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
11731
42eea0d0
PE
11732 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
11733
b69769da 11734 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 11735
f9541e84
PE
11736 * xdisp.c (vmessage): Mark as a printf-like function.
11737
13841b55
PE
11738 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
11739
c136c10f
PE
11740 * sound.c (sound_warning): Don't crash if arg contains a printf format.
11741
5e2d4a30
PE
11742 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
11743 printf-like functions.
11744 (tiff_load): Add casts to remove these marks before passing them
11745 to system-supplied API.
11746
583f48b9
PE
11747 * eval.c (Fsignal): Remove excess argument to 'fatal'.
11748
b25d760e
PE
11749 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
11750 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
11751 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
11752 directly, rather than having caller test rule sign. This avoids
11753 some unnecessary tests.
11754 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
11755 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
11756 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 11757
bc7b6697 11758 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 11759 (xfont_open): Avoid unnecessary tests.
bc7b6697 11760
27ccc379
PE
11761 * composite.c (composition_gstring_put_cache): Use unsigned integer.
11762
dcd5c89a
PE
11763 * composite.h, composite.c (composition_gstring_put_cache):
11764 Use EMACS_INT, not int, for length.
11765
b13a45c6
PE
11766 * composite.h (COMPOSITION_DECODE_REFS): New macro,
11767 breaking out part of COMPOSITION_DECODE_RULE.
11768 (COMPOSITION_DECODE_RULE): Use it.
11769 * composite.c (get_composition_id): Remove unused local vars,
11770 by using the new macro.
11771
1e792e4d
PE
11772 * textprop.c (set_text_properties_1): Change while to do-while,
11773 since the condition is always true at first.
11774
dc6c6455 11775 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
11776 (interval_deletion_adjustment): Return unsigned value.
11777 All uses changed.
dc6c6455 11778
aba7731a
PE
11779 * process.c (list_processes_1, create_pty, read_process_output):
11780 (exec_sentinel): Remove vars that were set but not used.
afd4052b 11781 (create_pty): Remove unnecessary "volatile"s.
bc57d757 11782 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 11783 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 11784 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 11785
fdfc4bf3
PE
11786 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
11787
fca8fe46 11788 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 11789 (update_syntax_table): Use unsigned instead of int.
fca8fe46 11790
06a0259a 11791 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 11792 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 11793 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 11794
e7b9e80f
PE
11795 * print.c (print_error_message): Avoid int overflow.
11796
56201685
PE
11797 * font.c (font_list_entities): Redo for clarity,
11798 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
11799
78834453 11800 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 11801 (font_score): Avoid potential overflow in diff calculation.
78834453 11802
0bc0b309 11803 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 11804 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 11805
e610eaca
PE
11806 * eval.c (funcall_lambda): Rename local to avoid shadowing.
11807
b895abce
PE
11808 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
11809 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
11810 can always succeed if overflow has undefined behavior.
11811
1f1d9321 11812 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 11813 (wordify): Omit three unnecessary tests.
1f1d9321 11814
c59478bc
PE
11815 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
11816 All callers changed. This avoids the need for an unused var.
11817
79b73827
PE
11818 * casefiddle.c (casify_region): Remove var that is set but not used.
11819
a4db5dfe
PE
11820 * dired.c (file_name_completion): Remove var that is set but not used.
11821
43aae36e
PE
11822 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
11823
2a47c44d 11824 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 11825 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 11826
a37c69bf
PE
11827 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
11828 Check for integer overflow on size calculations.
11829
328ab8e7
PE
11830 * buffer.c (Fprevious_overlay_change): Remove var that is set
11831 but not used.
11832
e5a2a5cb
PE
11833 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
11834 Remove vars that are set but not used.
8d84a6eb 11835 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 11836 (timer_check_2): Mark vars as initialized.
e5a2a5cb 11837
a60e5f68
PE
11838 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
11839
f661cb61 11840 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 11841 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 11842
f0397f5a
PE
11843 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
11844 that are set but not used.
11845
8664db06 11846 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 11847 if XCreateBitmapFromData fails (Bug#8410).
8664db06 11848
6abdaa4a
PE
11849 * xselect.c (x_get_local_selection, x_handle_property_notify):
11850 Remove vars that are set but not used.
11851
0ce7538d 11852 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 11853 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 11854
9ae848fc
PE
11855 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
11856 Remove var that is set but not used.
0b918413
PE
11857 (scroll_bar_windows_size): Now size_t, not int.
11858 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
11859 Check for overflow.
9ae848fc 11860
a5a62657
PE
11861 * xfaces.c (realize_named_face): Remove vars that are set but not used.
11862 (map_tty_color) [!defined MSDOS]: Likewise.
11863
5c5cdd39
PE
11864 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
11865
66ebf983
PE
11866 * coding.c: Remove vars that are set but not used.
11867 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
11868 All callers changed.
11869 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
11870 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
11871 (decode_coding_charset): Remove vars that are set but not used.
11872
1be4d761
PE
11873 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
11874 that is set but not used.
11875
47553fa8
PE
11876 * print.c (print_object): Remove var that is set but not used.
11877
1f7196bf 11878 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
11879 The gnulib version avoids calling malloc in the usual case,
11880 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
11881 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
11882 * filelock.c (current_lock_owner): Likewise.
11883 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
11884 * sysdep.c: Include allocator.h, careadlinkat.h.
11885 (emacs_no_realloc_allocator): New static constant.
11886 (emacs_readlink): New function.
fdb61804
PE
11887 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
11888 ../lib/careadlinkat.h.
d1fdcab7 11889
f84c17c7
SM
118902011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
11891
11892 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
11893 first non-nil return value).
11894
ef3862ad
JD
118952011-04-03 Jan Djärv <jan.h.d@swipnet.se>
11896
11897 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
11898 if not defined (Bug#8403).
11899
376a7006
JB
119002011-04-02 Juanma Barranquero <lekktu@gmail.com>
11901
11902 * xdisp.c (display_count_lines): Remove parameter `start',
11903 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
11904 (get_char_face_and_encoding): Remove parameter `multibyte_p',
11905 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11906 (fill_stretch_glyph_string): Remove parameters `row' and `area',
11907 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
11908 and thereabouts. All callers changed.
11909 (get_per_char_metric): Remove parameter `f', unused since
11910 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
11911
6ca3801d
JM
119122011-04-02 Jim Meyering <meyering@redhat.com>
11913
11914 do not dereference NULL upon failed strdup
11915 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
11916 (ns_get_family): Likewise.
11917
d8e2b5ba
JB
119182011-04-02 Juanma Barranquero <lekktu@gmail.com>
11919
11920 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
11921
8c74fcbd
JD
119222011-04-02 Jan Djärv <jan.h.d@swipnet.se>
11923
11924 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
11925 later (Bug#8403).
11926
7200d79c
SM
119272011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
11928
03408648 11929 Add lexical binding.
7200d79c 11930
03408648
SM
11931 * window.c (Ftemp_output_buffer_show): New fun.
11932 (Fsave_window_excursion):
11933 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
11934
11935 * lread.c (lisp_file_lexically_bound_p): New function.
11936 (Fload): Bind Qlexical_binding.
11937 (readevalloop): Remove `evalfun' arg.
11938 Bind Qinternal_interpreter_environment.
11939 (Feval_buffer): Bind Qlexical_binding.
11940 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
11941 Mark as dynamic.
11942 (syms_of_lread): Declare `lexical-binding'.
11943
11944 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
11945
11946 * keyboard.c (eval_dyn): New fun.
11947 (menu_item_eval_property): Use it.
ca105506
SM
11948
11949 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 11950
03408648
SM
11951 * fns.c (concat, mapcar1): Accept byte-code-functions.
11952
11953 * eval.c (Fsetq): Handle lexical vars.
11954 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
11955 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
11956 (FletX, Flet): Obey lexical binding.
11957 (Fcommandp): Handle closures.
11958 (Feval): New `lexical' arg.
11959 (eval_sub): New function extracted from Feval. Use it almost
11960 everywhere where Feval was used. Look up vars in lexical env.
11961 Handle closures.
11962 (Ffunctionp): Move from subr.el.
11963 (Ffuncall): Handle closures.
11964 (apply_lambda): Remove `eval_flags'.
11965 (funcall_lambda): Handle closures and new byte-code-functions.
11966 (Fspecial_variable_p): New function.
11967 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
11968 but without exporting it to Lisp.
23aba0ea 11969
23aba0ea 11970 * doc.c (Fdocumentation, store_function_docstring):
03408648 11971 * data.c (Finteractive_form): Handle closures.
23aba0ea 11972
03408648
SM
11973 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
11974 interactive spec.
ba83908c 11975
04f2d78b
CB
11976 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
11977 New byte-codes.
03408648
SM
11978 (exec_byte_code): New function extracted from Fbyte_code to handle new
11979 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 11980
03408648 11981 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 11982
03408648 11983 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 11984
e2abce01
JB
119852011-03-31 Juanma Barranquero <lekktu@gmail.com>
11986
11987 * xdisp.c (redisplay_internal): Fix prototype.
11988
63696a73 119892011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 11990
63696a73 11991 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
11992 (try_scrolling): Use it when setting scroll_limit.
11993 Limit scrolling to 100 screen lines.
63696a73
EZ
11994 (redisplay_window): Even when falling back on "recentering",
11995 position point in the window according to scroll-conservatively,
11996 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
11997
11998 (try_scrolling): When point is above the window, allow searching
11999 as far as scroll_max, or one screenful, to compute vertical
12000 distance from PT to the scroll margin position. This prevents
12001 try_scrolling from unnecessarily failing when
12002 scroll-conservatively is set to a value slightly larger than the
12003 window height. Clean up the case of PT below the margin at bottom
12004 of window: scroll_max can no longer be INT_MAX. When aggressive
12005 scrolling is in use, don't let point enter the opposite scroll
12006 margin as result of the scroll.
12007 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
12008 threshold of 100 lines for never-recentering scrolling.
12009
e4cc2dfc
JB
120102011-03-31 Juanma Barranquero <lekktu@gmail.com>
12011
12012 * dispextern.h (move_it_by_lines):
12013 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
12014 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
12015 (message_log_check_duplicate): Remove parameters `prev_bol' and
12016 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
12017 (redisplay_internal): Remove parameter `preserve_echo_area',
12018 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
12019
12020 * indent.c (Fvertical_motion):
12021 * window.c (window_scroll_pixel_based, Frecenter):
12022 Don't pass `need_y_p' to `move_it_by_lines'.
12023
1c470562
SM
120242011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
12025
44f230aa
SM
12026 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
12027 steal a few bits to be more compact.
12028 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
12029 Remove unneeded casts.
12030
1c470562
SM
12031 * bytecode.c (Fbyte_code): CAR and CDR can GC.
12032
888adce9
ZK
120332011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
12034
12035 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
12036 binding" message (bug#7967).
12037
f838ed7b
PE
120382011-03-30 Paul Eggert <eggert@cs.ucla.edu>
12039
77861b95
PE
12040 Fix more problems found by GCC 4.6.0's static checks.
12041
de6dbc14
PE
12042 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
12043 Remove unused local var.
12044
f838ed7b
PE
12045 * editfns.c (Fmessage_box): Remove unused local var.
12046
792c7b2b
PE
12047 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
12048 (note_mode_line_or_margin_highlight, note_mouse_highlight):
12049 Omit unused local vars.
c499e557 12050 * window.c (shrink_windows): Omit unused local var.
b01a1c29 12051 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
12052 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
12053 Omit unused local var.
12054
ba0165e1
PE
12055 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
12056 Don't assume string length fits in int.
32ad8845 12057 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 12058 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 12059
3c59b4c9
PE
12060 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
12061 instead of alloca (Bug#8344).
12062
a3eed478 12063 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 12064 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 12065
eb4d412d
PE
12066 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
12067
1658b401
PE
12068 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
12069 concerns.
12070
12071 * term.c (produce_glyphless_glyph): Remove unnecessary test.
12072
12073 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 12074
9a2c6e05
PE
12075 * keyboard.c (syms_of_keyboard): Use the same style as later
12076 in this function when indexing through an array. This also
12077 works around GCC bug 48267.
12078
03d0a109
PE
12079 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
12080
44f730c8
PE
12081 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
12082
fe75f926
PE
12083 * chartab.c (sub_char_table_ref_and_range): Redo for slight
12084 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
12085
ffa8c828
PE
12086 * keyboard.c, keyboard.h (num_input_events): Now size_t.
12087 This avoids undefined behavior on integer overflow, and is a bit
12088 more convenient anyway since it is compared to a size_t variable.
12089
c5101a77
PE
12090 Variadic C functions now count arguments with size_t, not int.
12091 This avoids an unnecessary limitation on 64-bit machines, which
12092 caused (substring ...) to crash on large vectors (Bug#8344).
12093 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
12094 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 12095 All variadic functions and their callers changed accordingly.
c5101a77
PE
12096 (struct gcpro.nvars): Now size_t, not int. All uses changed.
12097 * data.c (arith_driver, float_arith_driver): Likewise.
12098 * editfns.c (general_insert_function): Likewise.
12099 * eval.c (struct backtrace.nargs, interactive_p)
12100 (internal_condition_case_n, run_hook_with_args, apply_lambda)
12101 (funcall_lambda, mark_backtrace): Likewise.
12102 * fns.c (concat): Likewise.
12103 * frame.c (x_set_frame_parameters): Likewise.
12104 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
12105 0 if not found, not -1. All callers changed.
12106
dd3f25f7
PE
12107 * alloc.c (garbage_collect): Don't assume stack size fits in int.
12108 (stack_copy_size): Now size_t, not int.
12109 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
12110
461c2ab9
JB
121112011-03-28 Juanma Barranquero <lekktu@gmail.com>
12112
12113 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
12114 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12115 All callers changed.
12116
12117 * lisp.h (multibyte_char_to_unibyte):
12118 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
12119 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
12120 * character.h (CHAR_TO_BYTE8):
12121 * cmds.c (internal_self_insert):
12122 * editfns.c (general_insert_function):
12123 * keymap.c (push_key_description):
12124 * search.c (Freplace_match):
12125 * xdisp.c (message_dolog, set_message_1): All callers changed.
12126
f6d62986
SM
121272011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
12128
12129 * keyboard.c (safe_run_hook_funcall): New function.
12130 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
12131 don't set the hook to nil, but remove the offending function instead.
12132 (Qcommand_hook_internal): Remove, unused.
12133 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
12134 Vcommand_hook_internal.
12135
12136 * eval.c (enum run_hooks_condition): Remove.
12137 (funcall_nil, funcall_not): New functions.
12138 (run_hook_with_args): Call each function through a `funcall' argument.
12139 Remove `cond' argument, now redundant.
12140 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
12141 (Frun_hook_with_args_until_failure): Adjust accordingly.
12142 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
12143
1db5b1ad
JB
121442011-03-28 Juanma Barranquero <lekktu@gmail.com>
12145
12146 * dispextern.h (string_buffer_position): Remove declaration.
12147
12148 * print.c (strout): Remove parameter `multibyte', unused since
12149 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
12150
12151 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
12152 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
12153 All callers changed.
12154
12155 * w32.c (_wsa_errlist): Use braces for struct initializers.
12156
12157 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
12158 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
12159 All callers changed.
12160 (string_buffer_position): Likewise. Also, make static (it's never
12161 used outside xdisp.c).
12162 (cursor_row_p): Remove parameter `w', unused since
12163 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
12164 (decode_mode_spec): Remove parameter `precision', introduced during
12165 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
12166 All callers changed.
12167
5ffb62aa
JD
121682011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12169
12170 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
12171
461c2ab9 121722011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
12173
12174 * nsterm.m (ns_menu_bar_is_hidden): New variable.
12175 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
12176 (ns_update_auto_hide_menu_bar): New functions.
12177 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
12178 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
12179 ns_constrain_all_frames.
12180 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
12181 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
12182
5c380ffb
JD
121832011-03-27 Jan Djärv <jan.h.d@swipnet.se>
12184
12185 * nsmenu.m (runDialogAt): Remove argument to timer_check.
12186
9af30bdf
GM
121872011-03-27 Glenn Morris <rgm@gnu.org>
12188
12189 * syssignal.h: Replace RETSIGTYPE with void.
12190 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
12191 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
12192 Replace SIGTYPE with void everywhere.
12193 * s/usg5-4-common.h (SIGTYPE): Remove definition.
12194 * s/template.h (SIGTYPE): Remove commented out definition.
12195
e2abce01
JB
121962011-03-26 Eli Zaretskii <eliz@gnu.org>
12197
12198 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
12199 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
12200
f868cd8a
JB
122012011-03-26 Juanma Barranquero <lekktu@gmail.com>
12202
59eb0929
JB
12203 * w32.c (read_unc_volume): Use parameter `henum', instead of
12204 global variable `wget_enum_handle'.
12205
12206 * keymap.c (describe_vector): Remove parameters `indices' and
12207 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
12208 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
12209
f868cd8a
JB
12210 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
12211
12212 * keyboard.c (timer_check): Remove parameter `do_it_now',
12213 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
12214 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
12215 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
12216
12217 * keyboard.c (read_char):
12218 * w32menu.c (w32_menu_display_help):
12219 * xmenu.c (show_help_event, menu_help_callback):
12220 Adjust calls to `show_help_echo'.
12221
12222 * gtkutil.c (xg_maybe_add_timer):
12223 * keyboard.c (readable_events):
12224 * process.c (wait_reading_process_output):
12225 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
12226
12227 * insdel.c (adjust_markers_gap_motion):
12228 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
12229 (gap_left, gap_right): Don't call it.
12230
2ecf6fdb
CY
122312011-03-25 Chong Yidong <cyd@stupidchicken.com>
12232
12233 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
12234 incurred during fontification.
12235
6b1f9ba4
JB
122362011-03-25 Juanma Barranquero <lekktu@gmail.com>
12237
12238 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
12239 (DEFVAR_PER_BUFFER): Don't pass it.
12240
12241 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
12242 (scrolling_window): Don't pass it.
12243
0f4a96b5
JB
122442011-03-25 Juanma Barranquero <lekktu@gmail.com>
12245
12246 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
12247
12248 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
12249 and `suffix'.
12250 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
12251 of variables specific to SELinux and computation of `encoded_absname'.
12252
12253 * image.c (XPutPixel): Remove unused variable `height'.
12254
12255 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
12256
12257 * unexw32.c (get_section_info): Remove unused variable `section'.
12258
12259 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
12260 (system_process_attributes): Remove unused variable `sess'.
12261 (sys_read): Remove unused variable `err'.
12262
12263 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
12264 (w32_wnd_proc): Remove unused variable `isdead'.
12265 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
12266 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
12267 (x_create_tip_frame): Remove unused variable `tem'.
12268
12269 * w32inevt.c (w32_console_read_socket):
12270 Remove unused variable `no_events'.
12271
12272 * w32term.c (x_draw_composite_glyph_string_foreground):
12273 Remove unused variable `width'.
12274
1149507c
JB
122752011-03-24 Juanma Barranquero <lekktu@gmail.com>
12276
12277 * w32term.c (x_set_glyph_string_clipping):
12278 Don't pass uninitialized region to CombineRgn.
12279
9c88f339
JB
122802011-03-23 Juanma Barranquero <lekktu@gmail.com>
12281
12282 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
12283 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
12284 (Fx_close_connection): Remove unused variable `i'.
12285
12286 * w32font.c (w32font_draw): Return number of glyphs.
12287 (w32font_open_internal): Remove unused variable `i'.
12288 (w32font_driver): Add missing initializer.
12289
12290 * w32menu.c (utf8to16): Remove unused variable `utf16'.
12291 (fill_in_menu): Remove unused variable `items_added'.
12292
12293 * w32term.c (last_mouse_press_frame): Remove static global variable.
12294 (w32_clip_to_row): Remove unused variable `f'.
12295 (x_delete_terminal): Remove unused variable `i'.
12296
12297 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
12298 (NOTHING): Remove unused static global variable.
12299 (uniscribe_check_otf): Remove unused variable `table'.
12300 (uniscribe_font_driver): Add missing initializers.
12301
dee091a3
JD
123022011-03-23 Julien Danjou <julien@danjou.info>
12303
12304 * term.c (Fsuspend_tty, Fresume_tty):
12305 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
12306 * window.c (temp_output_buffer_show):
12307 * insdel.c (signal_before_change):
12308 * frame.c (Fhandle_switch_frame):
12309 * fileio.c (Fdo_auto_save):
12310 * emacs.c (Fkill_emacs):
12311 * editfns.c (save_excursion_restore):
12312 * cmds.c (internal_self_insert):
12313 * callint.c (Fcall_interactively):
12314 * buffer.c (Fkill_all_local_variables):
12315 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
12316 Use Frun_hooks.
0f4a96b5 12317 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 12318 unconditionally since it does the check itself.
dee091a3 12319
2c520ab5 123202011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 12321
c9c49752
PE
12322 Fix more problems found by GCC 4.5.2's static checks.
12323
8abc3f12
PE
12324 * coding.c (encode_coding_raw_text): Avoid unnecessary test
12325 the first time through the loop, since we know p0 < p1 then.
12326 This also avoids a gcc -Wstrict-overflow warning.
12327
a2d26660
PE
12328 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
12329 leading to a memory leak, possible in functions like
12330 load_charset_map_from_file that can allocate an unbounded number
b12ef411 12331 of objects (Bug#8318).
a2d26660 12332
916c72e9
PE
12333 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
12334 that could (at least in theory) be that large.
12335
19ab8a18
PE
12336 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
12337 This is less likely to overflow, and avoids undefined behavior if
12338 overflow does occur. All callers changed. Use strtoul to scan
12339 for the unsigned long integer.
b7cbbd6f
PE
12340 (pint2hrstr): Simplify and tune code slightly.
12341 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 12342
f0641eff
PE
12343 * scroll.c (do_scrolling): Work around GCC bug 48228.
12344 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
12345
7f650bb9
PE
12346 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
12347 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
12348 (validate_x_resource_name): Simplify count usage.
12349 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 12350
37dd57d1
PE
12351 * fileio.c (Fcopy_file): Report error if fchown or fchmod
12352 fail (Bug#8306).
81e56e61 12353
699979fc 12354 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 12355
401bf9b4
PE
12356 * process.c (Fmake_network_process): Use socklen_t, not int,
12357 where POSIX says socklen_t is required in portable programs.
12358 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 12359 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
12360 (Fmake_network_process, server_accept_connection):
12361 (wait_reading_process_output, read_process_output):
12362 Likewise.
12363
b93aacde
PE
12364 * process.c: Rename or move locals to avoid shadowing.
12365 (list_processes_1, Fmake_network_process):
12366 (read_process_output_error_handler, exec_sentinel_error_handler):
12367 Rename or move locals.
4dc343ee 12368 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 12369 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 12370 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 12371 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 12372 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 12373
af8a867c 12374 Make tparam.h and terminfo.c consistent.
44f230aa
SM
12375 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
12376 Include tparam.h instead, since it declares them.
af8a867c
PE
12377 * cm.h (PC): Remove extern decl; tparam.h now does this.
12378 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
12379 * terminfo.c: Include tparam.h, to check interfaces.
12380 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
12381 (tparam): Adjust signature to match interface in tparam.h;
12382 this removes some undefined behavior. Check that outstring and len
12383 are zero, which they always are with Emacs.
12384 * tparam.h (PC, BC, UP): New extern decls.
12385
0248044d 12386 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 12387 (xftfont_open): Rename locals to avoid shadowing.
0248044d 12388
8ff096c1 12389 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
12390 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
12391 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 12392 (ftfont_list): Remove unused local.
49eaafba
PE
12393 (get_adstyle_property, ftfont_pattern_entity):
12394 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
12395 Rename locals to avoid shadowing.
8ff096c1 12396
e2be39f6
PE
12397 * xfont.c (xfont_list_family): Mark var as initialized.
12398
c9735e30
PE
12399 * xml.c (make_dom): Now static.
12400
8f5201ae
PE
12401 * composite.c (composition_compute_stop_pos): Rename local to
12402 avoid shadowing.
b246f932
PE
12403 (composition_reseat_it): Remove unused locals.
12404 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 12405 (composition_update_it): Mark var as initialized.
11b61122
PE
12406 (find_automatic_composition): Mark vars as initialized,
12407 with a FIXME (Bug#8290).
8f5201ae 12408
760fbc2c
PE
12409 character.h: Rename locals to avoid shadowing.
12410 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
12411 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
12412 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
12413 (BUF_DEC_POS): Be more systematic about renaming local temporaries
12414 to avoid shadowing.
12415
ff08eb85
PE
12416 * textprop.c (property_change_between_p): Remove; unused.
12417
fc7bf025
PE
12418 * intervals.c (interval_start_pos): Now static.
12419
235d7abc
PE
12420 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
12421
44f230aa
SM
12422 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
12423 Rename locals to avoid shadowing.
3e7d6594 12424
50060332
PE
12425 * sound.c (wav_play, au_play, Fplay_sound_internal):
12426 Fix pointer signedness.
d01f234b 12427 (alsa_choose_format): Remove unused local var.
c83b8872
PE
12428 (wav_play): Initialize a variable to 0, to prevent undefined
12429 behavior (Bug#8278).
50060332 12430
c4fc4e30
PE
12431 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
12432
918436ed
PE
12433 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
12434
c939f91b
PE
12435 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
12436 clobbering (Bug#8298).
b9c7f648
PE
12437 * sysdep.c (sys_subshell): Likewise.
12438 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 12439
6bd8c144
PE
12440 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
12441 This should get cleaned up, so that child_setup has the
12442 same signature on all platforms.
12443
7710357c 12444 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 12445 (relocate_fd): Rename locals to avoid shadowing.
7710357c 12446
c59da222
CY
124472011-03-22 Chong Yidong <cyd@stupidchicken.com>
12448
12449 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
12450 not to be necessary, and produces flickering.
12451
66b87493
GM
124522011-03-20 Glenn Morris <rgm@gnu.org>
12453
12454 * config.in: Remove file.
12455
45b6f6d5
JB
124562011-03-20 Juanma Barranquero <lekktu@gmail.com>
12457
12458 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
12459 are now in src/globals.h.
12460 (syms_of_minibuf): Remove spurious & from previous change.
12461
cd394be1 124622011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
12463
12464 * minibuf.c (completing-read-function): New variable.
12465 (completing-read-default): Rename from completing-read.
12466 (completing-read): Call completing-read-function.
12467
b14e3e21
CY
124682011-03-19 Juanma Barranquero <lekktu@gmail.com>
12469
12470 * xfaces.c (Fx_load_color_file):
12471 Read color file from absolute filename (bug#8250).
12472
f2b726e6
JB
124732011-03-19 Juanma Barranquero <lekktu@gmail.com>
12474
12475 * makefile.w32-in: Update dependencies.
12476
09f6ff02
EZ
124772011-03-17 Eli Zaretskii <eliz@gnu.org>
12478
12479 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
12480
29a6015a
PE
124812011-03-17 Paul Eggert <eggert@cs.ucla.edu>
12482
a3a6c54e
PE
12483 Fix more problems found by GCC 4.5.2's static checks.
12484
b766f867
PE
12485 * process.c (make_serial_process_unwind, send_process_trap):
12486 (sigchld_handler): Now static.
12487
be02381c
PE
12488 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
12489 That way, the code declares only the vars that it needs.
12490 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
12491 * s/cygwin.h (PTY_ITERATION): Likewise.
12492 * s/darwin.h (PTY_ITERATION): Likewise.
12493 * s/gnu-linux.h (PTY_ITERATION): Likewise.
12494
57048744
PE
12495 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
12496 * process.c (allocate_pty): Don't declare stb unless it's needed.
12497
7914961c 12498 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
12499 (CONSTANTLIM): Remove; unused.
12500 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
12501 Define only if needed.
7914961c 12502
b3967b18
PE
12503 * unexelf.c (unexec): Name an expression,
12504 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
12505 Use a different way to cause a compilation error if anyone uses
12506 n rather than nn, a way that does not involve shadowing.
73366a00 12507 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 12508
29a6015a
PE
12509 * deps.mk (unexalpha.o): Remove; unused.
12510
43cfc33e 12511 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 12512 * unexec.h: New file.
ce701a33
PE
12513 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
12514 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
12515 Depend on unexec.h.
12516 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
12517 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
12518 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 12519 Change as necessary to match prototype in unexec.h.
ce701a33 12520
01f44d5a
PE
12521 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
12522 shadowing.
4f63c6bb 12523 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 12524
a6670b0b
PE
12525 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
12526 Rename locals to avoid shadowing.
12527
cef2010d 12528 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 12529 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 12530
d4d7173a
PE
12531 * print.c (Fredirect_debugging_output): Fix pointer signedess.
12532
f08b802a
PE
12533 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
12534 warning when compiling print.c.
12535
3ddb0639
PE
12536 * font.c (font_unparse_fcname): Abort in an "impossible" situation
12537 instead of using an uninitialized var.
5ad03b97 12538 (font_sort_entities): Mark var as initialized.
3ddb0639 12539
170a2692
PE
12540 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
12541
e663c700
PE
12542 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
12543 pointers to constants.
89bc529a 12544 (font_parse_fcname): Remove unused vars.
7b81e2d0 12545 (font_delete_unmatched): Now static.
ea838e10 12546 (font_get_spec): Remove; unused.
13a547c6
PE
12547 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
12548 (font_update_drivers, Ffont_get_glyphs, font_add_log):
12549 Rename or move locals to avoid shadowing.
e663c700 12550
2a80c887 12551 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 12552 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 12553
1384fa33 12554 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 12555 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 12556
8b2c52e9
PE
12557 * alloc.c (mark_backtrace): Move decl from here ...
12558 * lisp.h: ... to here, so that it can be checked.
12559
475545b5 12560 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 12561 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
12562 (lisp_indirect_variable): Name an expression,
12563 to avoid gcc -Wbad-function-cast warning.
1faed8ae 12564 (Fdefvar): Rename locals to avoid shadowing.
475545b5 12565
b1349114 12566 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 12567 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 12568 Use const pointer when appropriate.
b1349114 12569
a2928364
PE
12570 * lisp.h (get_system_name, get_operating_system_release):
12571 Move decls here, to check interfaces.
12572 * process.c (get_operating_system_release): Move decl to lisp.h.
12573 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
12574 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
12575 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
12576 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
12577 (Fformat_time_string, Fencode_time, Finsert_char):
12578 (Ftranslate_region_internal, Fformat):
12579 Rename or remove local vars to avoid shadowing.
9710023e 12580 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 12581
a415e694
PE
12582 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
12583 avoid shadowing.
12584
8ef4622d
PE
12585 * lisp.h (eassert): Check that the argument compiles, even if
12586 ENABLE_CHECKING is not defined.
12587
946f9a5b
PE
12588 * data.c (Findirect_variable): Name an expression, to avoid
12589 gcc -Wbad-function-cast warning.
112396d6 12590 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 12591 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
12592 (Fmake_variable_buffer_local, Fmake_local_variable):
12593 Mark variables as initialized.
52746918 12594 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 12595
e5aab7e7 12596 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
12597 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
12598 Rename locals to avoid shadowing.
dff45157
PE
12599 (mark_stack): Move local variables into the #ifdef region where
12600 they're used.
7bc26fdb
PE
12601 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
12602 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
12603 needed otherwise.
12604 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
12605 (GC_STRING_CHARS): Remove; not used.
d40d4be1 12606 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 12607
e5aab7e7
PE
12608 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
12609 avoids undefined behavior in theory.
12610
4da60324
PE
12611 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
12612
88043301
PE
12613 Use functions, not macros, for up- and down-casing (Bug#8254).
12614 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12615 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
12616 to use the following functions instead of these macros.
12617 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
12618 EMACS_INT, since callers assume the returned value fits in int.
12619 (upcase1): Likewise, for UPCASE_TABLE.
12620 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 12621 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 12622 the race-condition problem in the old DOWNCASE.
88043301 12623
19ed5445
PE
12624 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
12625 Rename locals to avoid shadowing.
12626 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
12627 (regex_compile, re_search_2, re_match_2_internal):
12628 Remove unused local vars.
952db0d7
PE
12629 (FREE_VAR): Rewrite so as not to use empty "else",
12630 which gcc can warn about.
da053e48 12631 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
12632 (RETALLOC_IF): Define only if needed.
12633 (WORDCHAR_P): Likewise. This one is never needed, but is used
12634 only in a comment talking about a compiler bug, so put inside
12635 the #if 0 of that comment.
12636 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
12637 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
12638 Remove; unused.
19ed5445 12639
1f3561e4 12640 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
12641 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
12642 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 12643
ded6f8f7
PE
12644 * search.c (simple_search): Remove unused var.
12645
dbd37a95
PE
12646 * dired.c (compile_pattern): Move decl from here ...
12647 * lisp.h: ... to here, so that it can be checked.
12648 (struct re_registers): New forward decl.
12649
7e47afad
PE
12650 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
12651
85f24f61
PE
12652 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
12653 All uses changed.
12654 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
12655 Rename locals to avoid shadowing.
5671df8f 12656 (Fvertical_motion): Mark locals as initialized.
85f24f61 12657
181aa2be 12658 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 12659 (casify_region): Mark local as initialized.
181aa2be 12660
930d429c
PE
12661 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
12662
7082eac6
PE
12663 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
12664 New macros, so that the caller can use some names other than
12665 gcpro1, gcpro2, etc.
12666 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
12667 of the new macros.
12668 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
12669 argument, for consistency with GCPRO2_VAR, etc: it is now the
12670 prefix of the variable, not the variable itself. All uses
12671 changed.
38b2c076
PE
12672 * dired.c (directory_files_internal, file_name_completion):
12673 Rename locals to avoid shadowing.
12674
15206ed9
PE
12675 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
12676 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
12677 dired.c's scmp function, had undefined behavior.
12678 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
12679 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
12680 * buffer.h: ... to here, because these macros use current_buffer,
12681 and the new implementation with inline functions needs to have
12682 current_buffer in scope now, rather than later when the macros
12683 are used.
12684 (downcase, upcase1): New static inline functions.
12685 (DOWNCASE, UPCASE1): Reimplement using these functions.
12686 This avoids undefined behavior in expressions like
12687 DOWNCASE (x) == DOWNCASE (y), which previously suffered
12688 from race conditions in accessing the global variables
12689 case_temp1 and case_temp2.
12690 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
12691 * lisp.h (case_temp1, case_temp2): Remove their decls.
12692 * character.h (ASCII_CHAR_P): Move from here ...
12693 * lisp.h: ... to here, so that the inline functions mentioned
12694 above can use them.
12695
4a6bea26
PE
12696 * dired.c (directory_files_internal_unwind): Now static.
12697
f14b7e14
PE
12698 * fileio.c (file_name_as_directory, directory_file_name):
12699 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
12700 Now static.
2893f146
PE
12701 (file_name_as_directory): Use const pointers when appropriate.
12702 (Fexpand_file_name): Likewise. In particular, newdir might
12703 point at constant storage, so make it a const pointer.
fd4ead52 12704 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
12705 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
12706 signedness issues.
f839df0c
PE
12707 (Fset_file_times, Finsert_file_contents, auto_save_error):
12708 Rename locals to avoid shadowing.
f14b7e14 12709
5716756e 12710 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
12711 (Ftry_completion, Fall_completions): Rename or remove locals
12712 to avoid shadowing.
5716756e 12713
b4c3046a
PE
12714 * marker.c (bytepos_to_charpos): Remove; unused.
12715
b45db522
PE
12716 * lisp.h (verify_bytepos, count_markers): New decls,
12717 so that gcc does not warn that these functions aren't declared.
12718
85876d07
PE
12719 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
12720 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 12721 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 12722 (copy_text): Remove unused local var.
85876d07 12723
03d78a21 12724 * filelock.c (within_one_second): Now static.
b3dd38ab 12725 (lock_file_1): Rename local to avoid shadowing.
03d78a21 12726
5df8f01b
PE
12727 * buffer.c (fix_overlays_before): Mark locals as initialized.
12728 (fix_start_end_in_overlays): Likewise. This function should be
12729 simplified by using pointers-to-pointers, but that's a different
12730 matter.
b1d876f1 12731 (switch_to_buffer_1): Now static.
8f54f30a
PE
12732 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
12733 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 12734
a70072c9 12735 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 12736 Fix pointer signedness issue.
edced198
PE
12737 (sys_subshell): Mark local as volatile if checking for lint,
12738 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 12739 (MAXPATHLEN): Define only if needed.
a70072c9 12740
a0977c44
PE
12741 * process.c (serial_open, serial_configure): Move decls from here ...
12742 * systty.h: ... to here, so that they can be checked.
12743
a884fdcc
PE
12744 * fns.c (get_random, seed_random): Move extern decls from here ...
12745 * lisp.h: ... to here, so that they can be checked.
12746
604efe86 12747 * sysdep.c (reset_io): Now static.
b8950c94 12748 (wait_for_termination_signal): Remove; unused.
604efe86 12749
38fc62d9
PE
12750 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
12751 (copy_keymap_item, append_key, push_text_char_description):
12752 Now static.
1004a21a 12753 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 12754 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
12755 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
12756 (describe_map_tree):
12757 Rename locals to avoid shadowing.
38fc62d9 12758
2f2650da
PE
12759 * keyboard.c: Declare functions static if they are not used elsewhere.
12760 (echo_char, echo_dash, cmd_error, top_level_2):
12761 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
12762 (read_char, kbd_buffer_get_event, make_lispy_position):
12763 (make_lispy_event, make_lispy_movement, apply_modifiers):
12764 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
12765 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
12766 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 12767 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 12768 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 12769
a053e86c 12770 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
12771 (mark_kboards): Move decl here ...
12772 * alloc.c (mark_kboards): ... from here.
a053e86c 12773
4752793e
PE
12774 * lisp.h (force_auto_save_soon): New decl.
12775
74f10ca7 12776 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
12777 (DEFINE_DUMMY_FUNCTION): New macro.
12778 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
12779 Use it.
c03cd23f
PE
12780 (main): Add casts to avoid warnings
12781 if GCC considers string literals to be constants.
74f10ca7 12782
022e70d4
PE
12783 * lisp.h (fatal_error_signal): Add decl, since it's exported.
12784
59d6fe83
PE
12785 * dbusbind.c: Pointer signedness fixes.
12786 (xd_signature, xd_append_arg, xd_initialize):
12787 (Fdbus_call_method, Fdbus_call_method_asynchronously):
12788 (Fdbus_method_return_internal, Fdbus_method_error_internal):
12789 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
12790 (Fdbus_register_signal): Use SSDATA when the context wants char *.
12791
78320123
PE
12792 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
12793 if GCC considers string literals to be constants.
49cebcca 12794 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 12795
35ac2a97
SM
127962011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
12797
fb103ca9
SM
12798 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
12799 (print_preprocess, print_object): New macro to fix last change.
12800
35ac2a97
SM
12801 * print.c (print_preprocess): Don't forget font objects.
12802
62973b41
JB
128032011-03-16 Juanma Barranquero <lekktu@gmail.com>
12804
12805 * emacs.c (USAGE3): Doc fixes.
12806
0e48bb22
AS
128072011-03-15 Andreas Schwab <schwab@linux-m68k.org>
12808
12809 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
12810 structure.
12811
7684e57b
JB
128122011-03-14 Juanma Barranquero <lekktu@gmail.com>
12813
12814 * lisp.h (VWindow_system, Qfile_name_history):
12815 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
12816 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
12817 (w32_system_caret_x, w32_system_caret_y): Declare extern.
12818
12819 * w32select.c: Don't #include "keyboard.h".
c96bbc66 12820 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
12821
12822 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
12823 * w32console.c (detect_input_pending, read_input_pending)
12824 (encode_terminal_code):
12825 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
12826 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
12827 (w32_system_caret_y, Qfile_name_history):
12828 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
12829 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
12830 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
12831 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
12832 * w32proc.c (Qlocal, report_file_error):
12833 * w32term.c (Vwindow_system, updating_frame):
12834 * w32uniscribe.c (initialized, uniscribe_font_driver):
12835 Remove unneeded extern declarations.
12836
2aa46d6c
CY
128372011-03-14 Chong Yidong <cyd@stupidchicken.com>
12838
c96bbc66 12839 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 12840
cffc6f3b
CY
128412011-03-13 Chong Yidong <cyd@stupidchicken.com>
12842
12843 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
12844 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
12845 These macros can no longer be used for assignment.
12846
44f230aa
SM
12847 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
12848 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
12849 (record_buffer_markers, fetch_buffer_markers): New functions for
12850 recording and fetching special buffer markers.
12851 (set_buffer_internal_1, set_buffer_temp): Use them.
12852
12853 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
12854
12855 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
12856
12857 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
12858 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
12859
12860 * xdisp.c (hscroll_window_tree):
12861 (reconsider_clip_changes): Use PT instead of BUF_PT.
12862
d251f04b
EZ
128632011-03-13 Eli Zaretskii <eliz@gnu.org>
12864
12865 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
12866 $(EMACS_ROOT)/lib/intprops.h.
12867
f0c77cd1
PE
128682011-03-13 Paul Eggert <eggert@cs.ucla.edu>
12869
3eca4629
PE
12870 Fix more problems found by GCC 4.5.2's static checks.
12871
7c86ee98
PE
12872 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
12873 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
12874 (xg_free_frame_widgets): Make it clear that a local variable is
12875 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
12876 (gdk_window_get_screen): Make it clear that this macro is needed
12877 only if USE_GTK_TOOLTIP.
1e5524e7
PE
12878 (int_gtk_range_get_value): New function, which avoids a diagnostic
12879 from gcc -Wbad-function-cast.
12880 (xg_set_toolkit_scroll_bar_thumb): Use it.
12881 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
12882 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
12883 (get_utf8_string, xg_get_file_with_chooser):
12884 Rename locals to avoid shadowing.
12885 (create_dialog): Move locals to avoid shadowing.
7c86ee98 12886
41729b81
PE
12887 * xgselect.c (xg_select): Remove unused var.
12888
f0c77cd1
PE
12889 * image.c (four_corners_best): Mark locals as initialized.
12890 (gif_load): Initialize transparent_p to zero (Bug#8238).
12891 Mark another local as initialized.
ec6cf4c6 12892 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 12893
ce0ad53d 12894 * image.c (clear_image_cache): Now static.
d5d5a617 12895 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 12896 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
12897 (x_edge_detection): Remove unnecessary cast that
12898 gcc -Wbad-function-cast diagnoses.
2037898d 12899 (gif_load): Fix pointer signedness.
6ae141d6
PE
12900 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
12901 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 12902
33383987 129032011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 12904
d32df629
PE
12905 Improve quality of tests for time stamp overflow.
12906 For example, without this patch (encode-time 0 0 0 1 1
12907 1152921504606846976) returns the obviously-bogus value (-948597
12908 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
12909 reports time overflow. See
12910 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
12911 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
12912 * editfns.c: Include limits.h and intprops.h.
12913 (TIME_T_MIN, TIME_T_MAX): New macros.
12914 (time_overflow): Move earlier, to before first use.
12915 (hi_time, lo_time): New functions, for an accurate test for
12916 out-of-range times.
12917 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
12918 (Fget_internal_run_time): Don't assume time_t fits in int.
12919 (make_time): Use list2 instead of Fcons twice.
12920 (Fdecode_time): More accurate test for out-of-range times.
12921 (check_tm_member): New function.
12922 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
12923 (lisp_time_argument): Don't rely on undefined left-shift and
12924 right-shift behavior when checking for time stamp overflow.
8be6f318 12925
fe31d94c
PE
12926 * editfns.c (time_overflow): New function, refactoring common code.
12927 (Fformat_time_string, Fdecode_time, Fencode_time):
12928 (Fcurrent_time_string): Use it.
12929
8be6f318
PE
12930 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
12931 * dired.c (make_time): Move to ...
12932 * editfns.c (make_time): ... here.
12933 * systime.h: Note the move.
12934
09d9db2c 129352011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 12936
126bc0dc
YM
12937 * fringe.c (update_window_fringes): Remove unused variables.
12938
c47cbdfd
YM
12939 * unexmacosx.c (copy_data_segment): Also copy __got section.
12940 (Bug#8223)
12941
7ac80be9
EZ
129422011-03-12 Eli Zaretskii <eliz@gnu.org>
12943
c96bbc66 12944 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
12945 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
12946 Constify `char *' arguments and their references according to
12947 prototypes in tparam.h.
12948
ecb0f94d 12949 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 12950
7ac80be9
EZ
12951 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
12952 Adapt all references accordingly.
12953
12954 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
12955
ef1fd07e
TT
129562011-03-11 Tom Tromey <tromey@redhat.com>
12957
12958 * buffer.c (syms_of_buffer): Remove obsolete comment.
12959
7ef4b50c
EZ
129602011-03-11 Eli Zaretskii <eliz@gnu.org>
12961
12962 * termhooks.h (encode_terminal_code): Declare prototype.
12963
12964 * msdos.c (encode_terminal_code): Don't declare prototype.
12965
12966 * term.c (encode_terminal_code): Now external again, used by
12967 w32console.c and msdos.c.
12968
44f230aa
SM
12969 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
12970 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 12971
4b1ec863 129722011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 12973
1714f52b 12974 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 12975
4b1ec863
PE
12976 * fringe.c (update_window_fringes): Mark locals as initialized
12977 (Bug#8227).
12978 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 12979
524c7aa6
PE
12980 * alloc.c (mark_fringe_data): Move decl from here ...
12981 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
12982 to check its interface.
12983 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
12984
a5c0af81 12985 * fontset.c (free_realized_fontset): Now static.
7519b8cd 12986 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 12987 (fontset_font): Mark local as initialized.
a9a06e0b 12988 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 12989
b4716021
PE
12990 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
12991
811e9bac 12992 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 12993 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
12994 (x_own_selection, Fx_disown_selection_internal): Rename locals
12995 to avoid shadowing.
12996 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 12997
7e3ab302
PE
12998 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
12999 so that the caller can use some name other than gcpro1.
13000 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
13001 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13002 (Fx_backspace_delete_keys_p):
13003 Use them to avoid shadowing, and rename vars to avoid shadowing.
13004 (x_decode_color, x_set_name, x_window): Now static.
6b437900 13005 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 13006 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
13007 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
13008 Remove unused locals.
7e3ab302
PE
13009 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
13010 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
13011 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
13012 macros.
f78faa98 13013
e2b13473
PE
13014 * xterm.h (x_mouse_leave): New decl.
13015
77f23912
PE
13016 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
13017 Remove unused functions.
cdf4ba58
PE
13018 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
13019 (x_calc_absolute_position): Now static.
7411c686 13020 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 13021 Don't declare local "event" unless it's used.
ed7bf3a5
PE
13022 (x_iconify_frame, x_free_frame_resources): Don't declare locals
13023 unless they are used.
38d0b34a
PE
13024 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
13025 (x_fatal_error_signal): Remove; not used.
a6067996
PE
13026 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
13027 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
13028 (x_error_catcher, x_connection_closed, x_error_handler):
13029 (x_error_quitter, xembed_send_message, x_iconify_frame):
13030 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 13031 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 13032 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 13033
44f230aa
SM
13034 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
13035 Rename or move locals to avoid shadowing.
6b463e58 13036 (tty_defined_color, merge_face_heights): Now static.
5967d051 13037 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
13038 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
13039 does not deduce is never used uninitialized.
73719eba
PE
13040 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
13041 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 13042
426994c3 13043 * terminal.c (store_terminal_param): Now static.
5489860b 13044
032f1620 13045 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 13046 (set_frame_menubar): Remove unused local.
d4323972 13047 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
13048 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
13049 since they might point to immutable storage.
281585b0
PE
13050 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
13051 since it's unused otherwise.
032f1620 13052
367c19e5 13053 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 13054 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
13055 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
13056 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 13057 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
13058 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
13059 does not deduce are never used uninitialized.
70739cbe 13060
07b48fa9
PE
13061 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
13062
8868a238 13063 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
13064 * window.c (window_loop, size_window):
13065 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 13066
7e5cf297 13067 * window.c (display_buffer): Now static.
d6550a9f
PE
13068 (size_window): Mark variables that gcc -Wuninitialized
13069 does not deduce are never used uninitialized.
a586633d
PE
13070 * window.h (check_all_windows): New decl, to forestall
13071 gcc -Wmissing-prototypes diagnostic.
5b555da1 13072 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 13073
f6095868
PE
13074 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
13075 shadowing.
13076 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
13077 Include <limits.h>.
13078 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
13079 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
13080 (load_charset_map): Mark variables that gcc -Wuninitialized
13081 does not deduce are never used uninitialized.
53df7c11 13082 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 13083
f38b440c
PE
13084 * coding.c (coding_set_source, coding_set_destination):
13085 Use "else { /* comment */ }" rather than "else /* comment */;"
13086 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
13087 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
13088 a block, when the outer 'i' will do.
13089 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
13090 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
13091 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
13092 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
13093 (Fdecode_sjis_char, Fdefine_coding_system_internal):
13094 Rename locals to avoid shadowing.
13095 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
13096 * coding.c (emacs_mule_char, encode_invocation_designation):
13097 Now static, since they're not used elsewhere.
413bb2db 13098 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 13099 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
13100 (decode_coding_emacs_mule): Mark variables that gcc
13101 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
13102 (detect_coding_iso_2022): Initialize a local variable that might
13103 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 13104 this initialization is needed. (Bug#8211)
5f58e762
PE
13105 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
13106 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
13107 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
13108 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
13109 Remove unused macros.
f38b440c 13110
232b38b9 13111 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 13112 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 13113 * character.c (string_count_byte8): Likewise.
232b38b9 13114
fb90da1b
PE
13115 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
13116 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
13117
fb93dbc2
PE
13118 * chartab.c (copy_sub_char_table): Now static, since it's not used
13119 elsewhere.
5c156ace
PE
13120 (sub_char_table_ref_and_range, char_table_ref_and_range):
13121 Rename locals to avoid shadowing.
bbcd0949 13122 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 13123
7d3b3862 13124 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 13125 (BIDI_BOB): Remove unused macro.
7d3b3862 13126
6be7d3da
PE
13127 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
13128 deduce are never used uninitialized.
c2ed9c8b 13129 * term.c (encode_terminal_code): Likewise.
6be7d3da 13130
75f8807f 13131 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 13132
50938595
PE
13133 * tparam.h: New file.
13134 * term.c, tparam.h: Include it.
13135 * deps.mk (term.o, tparam.o): Depend on tparam.h.
13136 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
13137 Move these decls to tparam.h, and make them agree with what
13138 is actually in tparam.c. The previous trick of using incompatible
13139 decls in different modules does not conform to the C standard.
13140 All callers of tparam changed to use tparam's actual API.
13141 * tparam.c (tparam1, tparam, tgoto):
13142 Use const pointers where appropriate.
13143
fbceeba2
PE
13144 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
13145 * cm.h (struct cm): Likewise.
13146 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
13147 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
13148 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
13149 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
13150 (turn_on_face, init_tty): Likewise.
13151 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 13152
7f3f1250
PE
13153 * term.c (term_mouse_position): Rename local to avoid shadowing.
13154
e6ca6543
PE
13155 * alloc.c (mark_ttys): Move decl from here ...
13156 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
13157
c40f8d15
AS
131582011-03-11 Andreas Schwab <schwab@linux-m68k.org>
13159
13160 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
13161
cfe0661d
JB
131622011-03-09 Juanma Barranquero <lekktu@gmail.com>
13163
13164 * search.c (compile_pattern_1): Remove argument regp, unused since
13165 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
13166 (compile_pattern): Don't pass it.
13167
0afb4571
J
131682011-03-08 Jan Djärv <jan.h.d@swipnet.se>
13169
13170 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
13171 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
13172 for ! HAVE_GTK3.
13173 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
13174
13175 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
13176
13177 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
13178 gdk_window_get_screen, gdk_window_get_geometry,
13179 gdk_x11_window_lookup_for_display and GDK_KEY_g.
13180 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
13181 (xg_get_pixbuf_from_pixmap): New function.
13182 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
13183 to Pixmap, take frame as parameter, remove GdkColormap parameter.
13184 Call xg_get_pixbuf_from_pixmap instead of
13185 gdk_pixbuf_get_from_drawable.
13186 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
13187 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
13188 (xg_check_special_colors): Use GtkStyleContext and its functions
13189 for HAVE_GTK3.
13190 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
13191 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
13192 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
13193 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
13194 Call gtk_widget_get_preferred_size.
0afb4571
J
13195 (xg_frame_resized): gdk_window_get_geometry only takes 5
13196 parameters.
44f230aa
SM
13197 (xg_win_to_widget, xg_event_is_for_menubar):
13198 Call gdk_x11_window_lookup_for_display.
0afb4571
J
13199 (xg_set_widget_bg): New function.
13200 (delete_cb): New function.
895009e1 13201 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 13202 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
13203 (xg_set_background_color): Call xg_set_widget_bg.
13204 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
13205 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
13206 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
13207 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
13208 if ! HAVE_GTK3.
13209 (update_frame_tool_bar): Call gtk_widget_hide.
13210 (xg_initialize): Use GDK_KEY_g.
13211
13212 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
13213 if ! HAVE_GTK3
13214 (x_session_initialize): Call gdk_x11_set_sm_client_id.
13215
13216 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
13217 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
13218 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
13219
1c2cc4ef
JB
132202011-03-08 Juanma Barranquero <lekktu@gmail.com>
13221
13222 * w32xfns.c (select_palette): Check success of RealizePalette against
13223 GDI_ERROR, not zero.
13224
33383987 13225See ChangeLog.11 for earlier changes.
aac0c6e3
MR
13226
13227;; Local Variables:
13228;; coding: utf-8
aac0c6e3
MR
13229;; End:
13230
2f097256 13231 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
13232
13233 This file is part of GNU Emacs.
13234
13235 GNU Emacs is free software: you can redistribute it and/or modify
13236 it under the terms of the GNU General Public License as published by
13237 the Free Software Foundation, either version 3 of the License, or
13238 (at your option) any later version.
13239
13240 GNU Emacs is distributed in the hope that it will be useful,
13241 but WITHOUT ANY WARRANTY; without even the implied warranty of
13242 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
13243 GNU General Public License for more details.
13244
13245 You should have received a copy of the GNU General Public License
13246 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.