Auto-commit of loaddefs files.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
48da7392
GM
12012-01-26 Glenn Morris <rgm@gnu.org>
2
3 * lread.c (syms_of_lread): Doc fix.
4
14af5f7f
CY
52012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6
7 * coding.c (encode_designation_at_bol): Change return value to
8 EMACS_INT.
9
0b21c100
CY
102012-01-25 Chong Yidong <cyd@gnu.org>
11
12 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
13
3c2907f7
CY
142012-01-21 Chong Yidong <cyd@gnu.org>
15
16 * floatfns.c (Fcopysign): Make the second argument non-optional,
17 since nil is not allowed anyway.
18
959ad23f
AS
192012-01-21 Andreas Schwab <schwab@linux-m68k.org>
20
21 * process.c (read_process_output): Use p instead of XPROCESS (proc).
22 (send_process): Likewise.
23
34a02f46
MR
242012-01-19 Martin Rudalics <rudalics@gmx.at>
25
26 * window.c (save_window_save, Fcurrent_window_configuration)
27 (Vwindow_persistent_parameters): Do not use Qstate. Rewrite
28 doc-strings.
29
1259009a 302012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
31
32 * character.c (char_width): New function.
70d4fdf6
GM
33 (Fchar_width, c_string_width, lisp_string_width):
34 Use char_width (Bug#9496).
25ed9e61 35
6a6ee00d
MR
362012-01-16 Martin Rudalics <rudalics@gmx.at>
37
38 * window.c (Vwindow_persistent_parameters): New variable.
39 (Fset_window_configuration, save_window_save): Handle persistent
40 window parameters.
41
c85efaf7
EZ
422012-01-14 Eli Zaretskii <eliz@gnu.org>
43
44 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
45 thrashing the stack of the thread. (Bug#9087)
46
5944709e
PE
472012-01-12 Paul Eggert <eggert@cs.ucla.edu>
48
49 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
50
e71f5d99
EZ
512012-01-11 Eli Zaretskii <eliz@gnu.org>
52
53 * xdisp.c (rows_from_pos_range): Handle the case where the
54 highlight ends on a newline. (Bug#10464)
55 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
56 he end column for display of highlight that ends on a newline
57 before a R2L line.
58
ce316182
GM
592012-01-11 Glenn Morris <rgm@gnu.org>
60
61 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
62 from load-path also when installation-directory is nil. (Bug#10208)
63
5b43da69
GM
642012-01-10 Glenn Morris <rgm@gnu.org>
65
74cc8ff9
GM
66 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
67
7d8d6e4e
GM
68 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
69 Update template values to be closer to their typical values these days.
5b43da69 70
a0db8d43
EZ
712012-01-09 Eli Zaretskii <eliz@gnu.org>
72
73 * xdisp.c (rows_from_pos_range): Accept additional argument
74 DISP_STRING, and accept any glyph in a row whose object is that
75 string as eligible for mouse highlight. Fixes mouse highlight of
76 display strings from overlays. (Bug#10464)
77
9a0115ab 782012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 79
b9110d6a 80 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
81 * fileio.c (auto_saving_dir_umask): New static var.
82 (Fmake_directory_internal): Use it.
83 (do_auto_save_make_dir): Set it, instead of invoking chmod after
84 creating the directory. The old code temporarily assigns
85 too-generous permissions to the directory.
86 (do_auto_save_eh): Clear it.
b9110d6a 87 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
88 that the var is always cleared.
89
6c1bd3f3
EZ
902012-01-07 Eli Zaretskii <eliz@gnu.org>
91
92 * search.c (scan_buffer): Pass character positions to
93 know_region_cache, not byte positions. (Bug#6540)
94
069d2b50
L
952012-01-07 LynX <_LynX@bk.ru> (tiny change)
96
97 * w32.c (sys_rename): Report EXDEV when rename of a directory
98 fails because the target is on another logical disk. (Bug#10284)
99
75bf0d33
DB
1002012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
101
102 * xterm.c (x_embed_request_focus): New function.
103
104 * xterm.h: Add prototype.
105
106 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
107
1c6e5a32
GM
1082012-01-05 Glenn Morris <rgm@gnu.org>
109
110 * emacs.c (emacs_copyright): Update short copyright year to 2012.
111
651e947e
EZ
1122012-01-01 Eli Zaretskii <eliz@gnu.org>
113
114 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
115 Load gnutls_transport_set_lowat only if GnuTLS version is below
116 2.11.1.
117 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
118 GnuTLS versions below 2.11.1.
119
3778cdd8
AL
1202011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
121
122 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
123 to the doc string advising against its use for altering the way
124 windows are scrolled.
125
0e5317f7
KH
1262011-12-28 Kenichi Handa <handa@m17n.org>
127
128 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
129 coding-system ASCII compatible only when it does not produce BOM
130 on encoding (Bug#10383).
131
93d5ca1f
JD
1322011-12-26 Jan Djärv <jan.h.d@swipnet.se>
133
134 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
135 can scroll.
136 (create_and_show_popup_menu): Always use menu_position_func for
137 Gtk3 (Bug#10361).
138
ca22b785
AS
1392011-12-24 Andreas Schwab <schwab@linux-m68k.org>
140
141 * callint.c (Fcall_interactively): Don't truncate prompt string.
142
d048e1e6
EZ
1432011-12-23 Eli Zaretskii <eliz@gnu.org>
144
145 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
146 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 147 resumed from there (after widening). (Bug#10360)
d048e1e6 148
5ccaba1f
JD
1492011-12-22 Jan Djärv <jan.h.d@swipnet.se>
150
151 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
152
204ee57f
JD
1532011-12-21 Jan Djärv <jan.h.d@swipnet.se>
154
b81d40f0
JB
155 * nsterm.m (x_free_frame_resources):
156 Release f->output_data.ns->miniimage.
204ee57f
JD
157 (ns_index_color): Fix indentation. Do not retain
158 color_table->colors[i].
159
160 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
161 before returning.
162
163 * nsfns.m (x_set_background_color): Assign return value from
164 ns_index_color to face-background instead of NSColor*.
165 (ns_implicitly_set_icon_type): Fix indentation.
166 Change assignment in for loop to comparison.
167
168 * emacs.c (ns_pool): New variable.
169 (main): Assign ns_pool.
170 (Fkill_emacs): Call ns_release_autorelease_pool.
171
172 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
173 autorelease fdesc, release fdAttrs and tdict.
174 (ns_get_covering_families): Release charset.
175 (ns_findfonts): Release NSFontDescriptor created with new.
176 (ns_uni_to_glyphs): Fix indentation.
177 (setString): Release attrStr before assigning new value.
178
c803b2b7
JD
1792011-12-18 Jan Djärv <jan.h.d@swipnet.se>
180
678f4426
JD
181 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
182 and NS_IMPL_COCOA.
183 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
184 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
185
cd394be1 1862011-12-18 David Reitter <reitter@cmu.edu>
678f4426 187
5fecd5fc
JD
188 * nsterm.m (ns_term_init): Subscribe for notifications
189 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
190 to method trackingNotification in EmacsMenu.
191
192 * nsmenu.m (trackingMenu): New variable.
3771cb17 193 (trackingNotification): New method (from Aquamacs).
5fecd5fc 194 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 195 from Aquamacs (Bug#7030).
678f4426
JD
196
1972011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 198
c803b2b7
JD
199 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
200 (symbol_to_nsstring): Fix indentation.
201 (ns_symbol_to_pb): New function.
202 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
203 (Fns_rotate_cut_buffers_internal): Removed.
204 (Fns_store_selection_internal): Renamed from
205 Fns_store_cut_buffer_internal.
206 (ns_get_foreign_selection, Fx_own_selection_internal)
207 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
208 (Fns_get_selection_internal, Fns_store_selection_internal):
209 Use ns_symbol_to_pb and check if return value is nil.
210 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
211 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
212 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
213 renamed to Sns_store_selection_internal.
214 (ns_handle_selection_request): Move code to Fx_own_selection_internal
215 and remove this function.
216 (ns_handle_selection_clear): Remove, never used.
217 (Fx_own_selection_internal): Move code from ns_handle_selection_request
218 here.
219
e1b01a3a
KB
2202011-12-17 Ken Brown <kbrown@cornell.edu>
221
222 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
223 GID is unknown (Bug#10257).
224
2adb6e85
PE
2252011-12-17 Paul Eggert <eggert@cs.ucla.edu>
226
227 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
228 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
229 which caused a build failure on GNU/Linux IA-64. This problem was
230 introduced by my 2011-10-07 patch.
231
d1d7b339
JL
2322011-12-15 Juri Linkov <juri@jurta.org>
233
234 * image.c (imagemagick_error): New function. (Bug#10112)
235 (imagemagick_load_image): Comment out `MagickSetResolution' call.
236 Use `imagemagick_error' where ImageMagick functions return
237 `MagickFalse'.
238 (Fimagemagick_types): Add `Fnreverse' to return the list in the
239 proper order.
240
100d5755
KH
2412011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
242
243 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
244 fill background (Bug#8992).
245
454592a6
MR
2462011-12-13 Martin Rudalics <rudalics@gmx.at>
247
248 * window.c (Vwindow_combination_resize)
249 (Vwindow_combination_limit): Use t instead of non-nil in
250 doc-strings.
61d4b438
MR
251 (Vrecenter_redisplay): Add first sentence of doc-string on
252 separate line.
53524d93 253 (Frecenter): Fix doc-string typo.
454592a6 254
3633e3aa
KH
2552011-12-11 Kenichi Handa <handa@m17n.org>
256
257 * coding.c (Funencodable_char_position): Pay attention to the
258 buffer text relocation (Bug#9389).
259
7b9d523a
JD
2602011-12-10 Jan Djärv <jan.h.d@swipnet.se>
261
262 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
263 gtk_init (Bug#10100).
264
b73189c6
EZ
2652011-12-10 Eli Zaretskii <eliz@gnu.org>
266
267 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
268 IT->string is nil. (Bug#10263)
269
f7dfe5d6
JD
2702011-12-10 Jan Djärv <jan.h.d@swipnet.se>
271
83faebb4
JD
272 * nsterm.h (x_free_frame_resources): Declare.
273
f7dfe5d6
JD
274 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
275 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
276
277 * nsterm.h (ns_get_defaults_value): Declare.
278
279 * nsterm.m (ns_default): Call ns_get_defaults_value.
280
7cd4e72c
EZ
2812011-12-09 Eli Zaretskii <eliz@gnu.org>
282
283 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
284 (Bug#10170)
285
b34d7317
YM
2862011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
287
288 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
289 that where the value of an _OBJC_* symbol points to is in the .bss
290 section (Bug#10240).
291
76470ad1
KH
2922011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
293
294 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 295 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 296
745fff94
KH
2972011-12-08 Kenichi Handa <handa@m17n.org>
298
299 * ftfont.c (get_adstyle_property): Fix previous change
300 (Bug#10233).
301
6e44397c
JB
3022011-12-07 Juanma Barranquero <lekktu@gmail.com>
303
304 * w32.c (init_environment): If no_site_lisp, remove site-lisp
305 dirs from the default value of EMACSLOADPATH (bug#10208).
306
7efa6272
GM
3072011-12-07 Glenn Morris <rgm@gnu.org>
308
309 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
310 installation and source directories as well. (Bug#10208)
311
f6fc4d87
CY
3122011-12-06 Chong Yidong <cyd@gnu.org>
313
314 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
315
2bf26180
GM
3162011-12-06 Glenn Morris <rgm@gnu.org>
317
318 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
319 as an error, not just -1. (Bug#10217)
320
3a6ad4f0
CY
3212011-12-05 Chong Yidong <cyd@gnu.org>
322
323 * keyboard.c (process_special_events): New function.
324 (swallow_events, Finput_pending_p): Use it (Bug#10195).
325
75a3b399
PE
3262011-12-05 Paul Eggert <eggert@cs.ucla.edu>
327
328 * coding.c (encode_designation_at_bol): Don't use uninitialized
329 local variable (Bug#9318).
330
c3c9e25e
KH
3312011-12-05 Kenichi Handa <handa@m17n.org>
332
333 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
334 return Qnil (Bug#8046, Bug#10193).
335
5eb05ea3
KH
3362011-12-05 Kenichi Handa <handa@m17n.org>
337
338 * coding.c (encode_designation_at_bol): New args charbuf_end and
339 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
340 (coding_set_source): Return how many bytes coding->source was
341 relocated.
342 (coding_set_destination): Return how many bytes
343 coding->destination was relocated.
344 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
345 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
346
3472011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
348
349 * coding.c (CODING_CHAR_CHARSET_P): New macro.
350 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
351 macro (Bug#9318).
352
3532011-12-05 Andreas Schwab <schwab@linux-m68k.org>
354
355 The following changes are to fix Bug#9318.
356
a79703f5 357 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
358 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
359 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 360 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 361
7dbda6df
JB
3622011-12-05 Juanma Barranquero <lekktu@gmail.com>
363
364 * lisp.h (process_quit_flag): Fix external declaration.
365
6d5eb5b0
SM
3662011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
367
368 Don't macro-inline non-performance-critical code.
369 * eval.c (process_quit_flag): New function.
370 * lisp.h (QUIT): Use it.
371
a0c3fad0
JD
3722011-12-04 Jan Djärv <jan.h.d@swipnet.se>
373
374 * nsfns.m (get_geometry_from_preferences): New function.
375 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
376
6c07aac2
AS
3772011-12-04 Andreas Schwab <schwab@linux-m68k.org>
378
379 * emacs.c (Qkill_emacs): Define.
380 (syms_of_emacs): Initialize it.
381 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
382 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
383 (quit_throw_to_read_char): Add parameter `from_signal'.
384 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
385 * lisp.h (QUIT): Call Fkill_emacs if requested.
386
c052ead4
JD
3872011-12-03 Jan Djärv <jan.h.d@swipnet.se>
388
389 * widget.c (update_wm_hints): Return if wmshell is null.
390 (widget_update_wm_size_hints): New function.
391
392 * widget.h (widget_update_wm_size_hints): Declare.
393
394 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
395 widget_update_wm_size_hints (Bug#10104).
396
9e49252b
EZ
3972011-12-03 Eli Zaretskii <eliz@gnu.org>
398
399 * xdisp.c (handle_invisible_prop): If the invisible text ends just
400 before a newline, prepare the bidi iterator for consuming the
401 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 402 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 403
02b16839
JL
4042011-12-02 Juri Linkov <juri@jurta.org>
405
406 * search.c (Fword_search_regexp): New Lisp function created from
407 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
408 (Fword_search_backward, Fword_search_forward)
409 (Fword_search_backward_lax, Fword_search_forward_lax):
410 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
411 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
412
0068070e
SM
4132011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
414
415 * fileio.c (Finsert_file_contents): Move after-change-function call
416 to before the "handled:" label, since all "goto handled" appear in
417 cases where the *-change-functions have already been properly called
418 (bug#10117).
419
3360a3fc
AS
4202011-12-01 Andreas Schwab <schwab@linux-m68k.org>
421
422 * keyboard.c (interrupt_signal): Don't call kill-emacs when
423 waiting for input. (Bug#10169)
424
73d6c093
EZ
4252011-11-30 Eli Zaretskii <eliz@gnu.org>
426
427 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
428 verifies glyph row's hash code--we have just reallocated the
429 glyphs, so their contents can be complete garbage. (Bug#10164)
430
febe6bea
JB
4312011-11-30 Juanma Barranquero <lekktu@gmail.com>
432
433 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
434
801a4313
EZ
4352011-11-30 Eli Zaretskii <eliz@gnu.org>
436
437 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
438 attributes are tested _before_ calling verify_row_hash, to protect
439 against GCC re-ordering of the tests. (Bug#10164)
440
2b56b87e
JD
4412011-11-29 Jan Djärv <jan.h.d@swipnet.se>
442
443 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
444
445 * xterm.c (handle_one_xevent): Only set async_visible and friends
446 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 447 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
448 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
449
dbf31225
PE
4502011-11-28 Paul Eggert <eggert@cs.ucla.edu>
451
452 Remove GCPRO-related macros that exist only to avoid shadowing locals.
453 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
454 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
455 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
456 All uses changed to use GCPRO1 etc.
457 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
458 Revert to old implementation (i.e., before 2011-03-11).
459
1305621b
YM
4602011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
461
462 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
463 of scroll runs so as to avoid assigning disabled bogus rows and
464 unnecessary graphics copy operations.
465
8c9afb46
EZ
4662011-11-27 Eli Zaretskii <eliz@gnu.org>
467
468 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
469 (snprintf) [_MSC_VER]: Redirect to _snprintf.
470 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
471 (malloc, free, realloc, calloc): Redirect to e_* only when
472 compiling Emacs.
473
474 * lisp.h (GCTYPEBITS): Move before first use.
475 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
476 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
477 this macro definition.
478
479 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
480 _MSC_VER.
481
54e9e3bf
JD
4822011-11-27 Jan Djärv <jan.h.d@swipnet.se>
483
6d5eb5b0
SM
484 * gtkutil.c (xg_create_frame_widgets):
485 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
486 present with Gtk+ 2.0.
487
83aca1cb
PE
4882011-11-26 Paul Eggert <eggert@cs.ucla.edu>
489
490 * fileio.c (Finsert_file_contents): Undo previous change; see
491 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
492
5b76caa4
PE
4932011-11-26 Paul Eggert <eggert@cs.ucla.edu>
494
495 Rename locals to avoid shadowing.
496 * fileio.c (Finsert_file_contents):
497 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
498 * process.c (wait_reading_process_output):
499 Rename inner 'proc' to 'p' to avoid shadowing.
500 Indent for consistency with usual Emacs style.
501
8c535114
EZ
5022011-11-25 Eli Zaretskii <eliz@gnu.org>
503
504 * xdisp.c (redisplay_window): If cursor row is not fully visible
505 after recentering, and scroll-conservatively is set to a large
506 number, scroll window by a few more lines to make the cursor fully
507 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
508 (start_display): Don't move to the next line if the display should
509 start at a newline that is part of a display vector or an overlay
510 string. (Bug#10119)
8c535114 511
fa4fdb5c
JL
5122011-11-24 Juri Linkov <juri@jurta.org>
513
514 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
515 after the `MagickPingImage' call. (Bug#10112)
516
90ec88df
CY
5172011-11-23 Chong Yidong <cyd@gnu.org>
518
519 * window.c (Fcoordinates_in_window_p): Accept only live windows.
520
56e2e794
MR
5212011-11-23 Martin Rudalics <rudalics@gmx.at>
522
523 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
524 making another buffer current. (Bug#10114)
525
b6e64c41
GM
5262011-11-23 Glenn Morris <rgm@gnu.org>
527
528 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
529
6b21de18
CY
5302011-11-23 Chong Yidong <cyd@gnu.org>
531
532 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
533 using it (Bug#5984).
534
b12cd789
EZ
5352011-11-22 Eli Zaretskii <eliz@gnu.org>
536
537 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
538 and header-lines, as they don't have one computed for them.
539 (Bug#10098)
540
541 * .gdbinit (prow): Make displayed values more self-explaining.
542 Add row's hash code.
543
261b6fd4
LMI
5442011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
545
546 * process.c (wait_reading_process_output): Fix asynchrounous
547 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 548 (wait_reading_process_output): Add comment and URL.
261b6fd4 549
e7cfd277
JD
5502011-11-21 Jan Djärv <jan.h.d@swipnet.se>
551
552 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
553
a9b9b7f5
CY
5542011-11-21 Chong Yidong <cyd@gnu.org>
555
556 * window.c (Fnext_window, Fprevious_window): Doc fix.
557
b0d15b4f
SM
5582011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
559
560 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
561
fe7a3057
JB
5622011-11-20 Juanma Barranquero <lekktu@gmail.com>
563
564 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
565
d2999b1a
MR
5662011-11-20 Martin Rudalics <rudalics@gmx.at>
567
568 * window.c (Fset_window_combination_limit): Rename argument
569 STATUS to LIMIT.
570 (Vwindow_combination_limit): Remove "status" from doc-string.
571
d5ff9cd0
AS
5722011-11-20 Andreas Schwab <schwab@linux-m68k.org>
573
574 * m/ibms390.h: Remove.
575 * m/ibms390x.h: Don't include "ibms390.h".
576
a5bb9bd3
SM
5772011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
578
579 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
580 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
581
cd1181db
JB
5822011-11-20 Juanma Barranquero <lekktu@gmail.com>
583
584 * casetab.c (Fset_case_table):
585 * charset.c (Fcharset_after): Fix typos.
586
615a3b8d 5872011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 588
17e845af
PE
589 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
590 Otherwise, valgrind does not work on some platforms.
591 Problem reported by Andreas Schwab in
6a0bf43d
PE
592 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
593 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
594 is set, removing the need for VIRT_ADDRESS_VARIES.
595 (PURE_P): Use a more-efficient implementation that needs just one
596 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
597 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
598 to 4 (xorl, subq, cmpq, setbe).
599 * alloc.c (pure): Always extern now, since that's the
600 VIRT_ADDR_VARIES behavior.
601 (PURE_POINTER_P): Use a single comparison, not two, for
602 consistency with the new puresize.h.
603 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
604 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
605 Remove VIRT_ADDR_VARIES no longer needed.
606
f8fe6f96
EZ
6072011-11-19 Eli Zaretskii <eliz@gnu.org>
608
609 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
610 (erase_phys_cursor, update_window_cursor, show_mouse_face)
611 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
612 behave as if the cursor position were at the window margin.
613
614 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
615 and the cursor position is out of bounds, behave as if the cursor
616 position were at the window margin. (Bug#10075)
617
df05a53c
CY
6182011-11-18 Chong Yidong <cyd@gnu.org>
619
620 * window.c (Fwindow_combination_limit): Make first argument
621 non-optional, since it is meaningless for live windows like the
622 selected window.
623
2071918e
DA
6242011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
625
626 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
627
b50a28de
SM
6282011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
629
630 * intervals.c: Fix grafting over the whole buffer (bug#10071).
631 (graft_intervals_into_buffer): Simplify.
632
015137db
EZ
6332011-11-18 Eli Zaretskii <eliz@gnu.org>
634
635 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
636 hash values of the two rows.
637 (copy_row_except_pointers): Preserve the used[] arrays and the
638 hash values of the two rows. (Bug#10035)
68c95424 639 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
640
641 * xdisp.c (row_hash): New function, body extracted from
642 compute_line_metrics.
643 (compute_line_metrics): Call row_hash, instead of computing the
644 hash code inline.
645
646 * dispnew.c (verify_row_hash): Call row_hash for computing the
647 hash code of a row, instead of duplicating code from xdisp.c.
648
649 * dispextern.h (row_hash): Add prototype.
650
a2addb04
TH
6512011-11-18 Tassilo Horn <tassilo@member.fsf.org>
652
653 * frame.c (delete_frame): Don't delete the terminal when the last
654 X frame is closed if emacs is built with GTK toolkit.
655
df85d315
JB
6562011-11-17 Juanma Barranquero <lekktu@gmail.com>
657
658 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
659
a0c2d0ae
MR
6602011-11-17 Martin Rudalics <rudalics@gmx.at>
661
662 * window.c (Vwindow_splits): Rename to
663 Vwindow_combination_resize. Suggested by Juri Linkov.
664 (Fsplit_window_internal): Use Vwindow_combination_resize instead
665 of Vwindow_splits.
666
58179cce
JB
6672011-11-16 Juanma Barranquero <lekktu@gmail.com>
668
7877f373
JB
669 * nsfns.m (Fns_font_name):
670 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 671
b6f67890
MR
6722011-11-16 Martin Rudalics <rudalics@gmx.at>
673
674 * window.h (window): Rename slot "nest" to "combination_limit".
675 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
676 (Fset_window_nest): Rename to Fset_window_combination_limit.
677 (Vwindow_nest): Rename to Vwindow_combination_limit.
678 (recombine_windows, make_parent_window, make_window)
679 (Fsplit_window_internal, saved_window)
680 (Fset_window_configuration, save_window_save): Rename all
681 occurrences of window_nest to window_combination_limit.
682
c7015153
JB
6832011-11-15 Juanma Barranquero <lekktu@gmail.com>
684
685 * image.c (imagemagick_load_image): Fix typo.
686
322ad6ec
EZ
6872011-11-14 Eli Zaretskii <eliz@gnu.org>
688
689 * xdisp.c (display_line): Move the call to
690 highlight_trailing_whitespace before the call to
691 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
692 faces of all the glyphs to compute ROW's hash value.
693 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 694
f067b8ec
JB
6952011-11-14 Juanma Barranquero <lekktu@gmail.com>
696
697 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
698 just return (bug#10044).
699
1e5b2111
EZ
7002011-11-12 Eli Zaretskii <eliz@gnu.org>
701
7ef3cbd5
EZ
702 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
703 with user-defined heap size. Bump the default size of the temacs
704 heap to 27MB, to avoid memory warning when running temacs.
705 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
706
1e5b2111
EZ
707 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
708 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
709 (verify_row_hash) [XASSERTS]: New function.
710 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
711 that the hash value of glyph rows is correct.
1e5b2111 712
89d61221
MR
7132011-11-12 Martin Rudalics <rudalics@gmx.at>
714
715 * window.h (window): Remove splits slot.
716 * window.c (Fwindow_splits, Fset_window_splits): Remove.
717 (Fdelete_other_windows_internal, make_parent_window)
718 (make_window, Fsplit_window_internal, Fdelete_window_internal)
719 (Fset_window_configuration, save_window_save): Don't deal with
720 split status of windows.
721 (saved_window): Remove splits slot.
722 (Vwindow_splits): Rewrite doc-string.
723
97f18cc8
JD
7242011-11-11 Jan Djärv <jan.h.d@swipnet.se>
725
726 * xfns.c (unwind_create_frame):
727 * nsfns.m (unwind_create_frame):
728 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
729 Vframe_list (Bug#9999).
730
22a648b4
DA
7312011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
732
0b381c7e 733 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 734
659afede
KH
7352011-11-11 Kenichi Handa <handa@m17n.org>
736
737 * callproc.c (Fcall_process): Set the member dst_multibyte of
738 process_coding.
739
9ac0394b
KH
7402011-11-11 Johan Bockgård <bojohan@gnu.org>
741
742 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
743 avoid a crash (bug#9496).
744
2fbdc249
CY
7452011-11-09 Chong Yidong <cyd@gnu.org>
746
747 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
748 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
749
ac6b1f81
PE
7502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
751
752 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
753
09db192c
PE
7542011-11-08 Paul Eggert <eggert@cs.ucla.edu>
755
756 Avoid some portability problems by eschewing 'extern inline' functions.
757 The trivial performance wins aren't worth the portability hassles; see
758 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
759 et seq.
760 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
761 (window_box_width, window_box_left, window_box_left_offset)
762 (window_box_right, window_box_right_offset): Undo previous change,
763 by removing the "extern"s.
764 * intervals.c (adjust_intervals_for_insertion)
765 (adjust_intervals_for_deletion): Undo previous change,
766 making these static again.
767 (offset_intervals, temp_set_point_both, temp_set_point)
768 (copy_intervals_to_string): No longer inline.
769 * xdisp.c (window_text_bottom_y, window_box_width)
770 (window_box_height, window_box_left_offset)
771 (window_box_right_offset, window_box_left, window_box_right)
772 (window_box): No longer inline.
773
105216ed
CY
7742011-11-08 Chong Yidong <cyd@gnu.org>
775
776 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
777 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
778 Signal an error if not a live window.
105216ed
CY
779 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
780 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
781
ae9e237f
JB
7822011-11-07 Juanma Barranquero <lekktu@gmail.com>
783
784 * lisp.h (syms_of_abbrev): Remove declaration.
785 Reported by CHENG Gao <chenggao@royau.me>.
786
c7aa8333
EZ
7872011-11-07 Eli Zaretskii <eliz@gnu.org>
788
789 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
790 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
791 of temacs in GUI mode.
792
be7f5545
MR
7932011-11-07 Martin Rudalics <rudalics@gmx.at>
794
795 * window.h: Declare delete_all_child_windows instead of
796 delete_all_subwindows.
797 * window.c (Fwindow_nest, Fset_window_nest)
798 (Fset_window_new_total, Fset_window_new_normal)
799 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
800 (delete_all_subwindows): Rename to delete_all_child_windows.
801 (Fdelete_other_windows_internal, Fset_window_configuration):
802 Call delete_all_child_windows instead of delete_all_subwindows.
803 * frame.c (delete_frame): Call delete_all_child_windows instead
804 of delete_all_subwindows.
805
ca78dc43
PE
8062011-11-07 Paul Eggert <eggert@cs.ucla.edu>
807
808 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
809 This is also needed for porting to any host where GC_MARK_STACK is
810 not GC_MAKE_GCPROS_NOOPS.
811 (which_symbols): Use it.
812
a0241d01
KH
8132011-11-07 Kenichi Handa <handa@m17n.org>
814
815 * coding.c (coding_set_destination): Check coding->src_pos only
816 when coding->src_object is a buffer (bug#9910).
817
818 * process.c (send_process): Set the member src_multibyte of coding
819 to 0 (bug#9911) when sending a unibyte text.
820
821 * callproc.c (Fcall_process): Set the member src_multibyte of
822 process_coding to 0 (bug#9912).
823
a64bfdfa 8242011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
825
826 * xmenu.c (cleanup_widget_value_tree): New function.
827 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
828 calling free_menubar_widget_value_tree directly (Bug#9830).
829
cb41b32a
PE
8302011-11-06 Paul Eggert <eggert@cs.ucla.edu>
831
832 Fix some portability problems with 'inline'.
833 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
834 (window_box_width, window_box_left, window_box_left_offset)
835 (window_box_right, window_box_right_offset): Declare extern.
836 Otherwise, these inline functions do not conform to C99 and
837 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
838 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
839 * intervals.c (adjust_intervals_for_insertion)
840 (adjust_intervals_for_deletion): Now extern, because otherwise the
841 extern inline functions 'offset_intervals' couldn't refer to it.
842 (static_offset_intervals): Remove.
843 (offset_intervals): Rewrite using the old contents of
844 static_offset_intervals. The old version didn't conform to C99
845 because an extern inline function contained a reference to an
846 identifier with static linkage.
847
b7041366
AS
8482011-11-06 Andreas Schwab <schwab@linux-m68k.org>
849
850 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
851 GC.
852
88a37c4d
EZ
8532011-11-06 Eli Zaretskii <eliz@gnu.org>
854
855 * xdisp.c (init_iterator, reseat_to_string): Don't set the
856 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
857 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
858 return Qleft_to_right.
859
49745b39
CY
8602011-11-06 Chong Yidong <cyd@gnu.org>
861
862 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
863 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
864 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
865 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
866 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
867 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
868 (Fwindow_vscroll): Doc fix.
869 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
870 argument, since it makes no sense to pass a live window and for
871 consistency with window-child.
872
1f05cd82
CS
8732011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
874
875 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
876 support MSVC.
877
22610910
JR
8782011-11-05 Jason Rumney <jasonr@gnu.org>
879
880 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
881 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
882 fonts (Bug#6029).
883 (add_font_entity_to_list): Fix logic errors in mixed boolean and
884 bitwise arithmetic preventing use of unicode-sip and non-truetype
885 opentype fonts.
886
a06776b2
EZ
8872011-11-05 Eli Zaretskii <eliz@gnu.org>
888
3ad924ba
EZ
889 * s/ms-w32.h (fstat, stat, utime): Move redirections to
890 "emacs"-only part.
891
a06776b2
EZ
892 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
893 initialization code to keep similarity to xfns.c after changes
894 from 2011-11-05.
895
c9e7db78
JD
8962011-11-05 Jan Djärv <jan.h.d@swipnet.se>
897
a97f8f3f
JD
898 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
899 (unwind_create_frame): New function (Bug#9943).
900 (Fx_create_frame): Restructure code to be more similar to the one in
901 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
902 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
903 Move terminal->reference_count++ just before making the frame official
904 (Bug#9943).
905
906 * nsterm.m (x_free_frame_resources): New function.
907 (x_destroy_window): Move code to x_free_frame_resources.
908
c9e7db78 909 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
910 (Fx_create_frame, x_create_tip_frame):
911 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
912 official. Move initialization of image_cache_refcount and
913 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
914
a6fc3b5c
EZ
9152011-11-05 Eli Zaretskii <eliz@gnu.org>
916
917 Support MSVC build with newer versions of Visual Studio.
918 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
919 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
920 nt/gmake.defs.
921
922 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
923 which are not supported by MSVC.
924 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
925 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
926 bitfields.
927 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
928 types in bitfields.
929 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
930
931 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
932
58179cce 9332011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
934
935 Support MSVC build with newer versions of Visual Studio.
936 * w32.c: Don't include w32api.h for MSVC.
937 (init_environment) [_MSC_VER]: Call sys_access, not _access.
938
939 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
940 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
941 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
942 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
943 e_* cousins.
944 (alloca) [_MSC_VER]: Define to _alloca.
945
946 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
947
948 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
949
a58c13ed
EZ
9502011-11-04 Eli Zaretskii <eliz@gnu.org>
951
952 * xdisp.c (note_mouse_highlight): If either of
953 previous/next-single-property-change returns nil, treat that as
954 the beginning or the end of the buffer. (Bug#9955)
955
fe0b6370
JD
9562011-11-04 Jan Djärv <jan.h.d@swipnet.se>
957
a58c13ed 958 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
959 label is not null (Bug#9951).
960 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
961 may be NULL.
962
89bd5ee1
EZ
9632011-11-04 Eli Zaretskii <eliz@gnu.org>
964
965 * window.c (Fwindow_body_size): Mention in the doc string that the
966 return value is in frame's canonical units. (Bug#9949)
967
84c3edb9
EZ
9682011-11-03 Eli Zaretskii <eliz@gnu.org>
969
4e2fb5c7
EZ
970 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
971
84c3edb9 972 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 973 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 974 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 975
bc17a887
EZ
9762011-11-01 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
979 Don't stop backward scan on the continuation glyph, even though
980 its CHARPOS is positive.
6d5eb5b0
SM
981 (mouse_face_from_buffer_pos, note_mouse_highlight):
982 Rename cover_string to disp_string.
bc17a887 983
4ee88440
MR
9842011-11-01 Martin Rudalics <rudalics@gmx.at>
985
986 * window.c (temp_output_buffer_show): Don't use
987 Vtemp_buffer_show_specifiers.
988 (Vtemp_buffer_show_specifiers): Remove unused variable.
989
c2ff3c02
EZ
9902011-10-30 Eli Zaretskii <eliz@gnu.org>
991
992 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
993 past the beginning of the current glyph matrix.
994
58179cce 9952011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
996
997 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
998 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
999 HAVE_GTK3 (Bug#9869).
b77a6a7f 1000
3b574623
JD
1001 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1002 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1003
b77a6a7f
JD
1004 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1005
1006 * xterm.c: Declare x_handle_net_wm_state to return int.
1007 (handle_one_xevent): Check if we are iconified but don't have
1008 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1009 (get_current_wm_state): Return non-zero if not hidden,
1010 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1011 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1012 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1013 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1014
196e41e4
PE
10152011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1016
1017 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1018 so that this new function doesn't get optimized away by a
1019 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1020
021f2e1a
AS
10212011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1022
1023 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1024
8b058d44
EZ
10252011-10-29 Eli Zaretskii <eliz@gnu.org>
1026
1027 Fix the `xbytecode' command.
1028 * .gdbinit (xprintbytestr): New command.
b50a28de 1029 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1030 (xbytecode): Print the byte-code string as well.
1031
4452fb80
EZ
10322011-10-29 Kim Storm <storm@cua.dk>
1033
8b058d44
EZ
1034 * alloc.c (which_symbols): New function.
1035
21b72067
AS
10362011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1037
1038 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1039 line. (Bug#9903)
1040
83ed7b5c
GM
10412011-10-29 Glenn Morris <rgm@gnu.org>
1042
1043 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1044 Not clear what it was for, and it causes various bugs. (Bug#9839)
1045
5a7a728b
EZ
10462011-10-28 Eli Zaretskii <eliz@gnu.org>
1047
1048 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1049 possible random value that matches one of those tested as
1050 condition to clear the mouse face.
1051
d3d0842f
CY
10522011-10-28 Chong Yidong <cyd@gnu.org>
1053
1054 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1055
31b39d13
DN
10562011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1057
1058 * window.c (make_window): Initialize phys_cursor_on_p.
1059
9aba6043
SM
10602011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1061
1062 * lisp.h (struct Lisp_Symbol): Update comments.
1063
c20992f4
JB
10642011-10-28 Juanma Barranquero <lekktu@gmail.com>
1065
1066 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1067
db4f02f2
EZ
10682011-10-28 Eli Zaretskii <eliz@gnu.org>
1069
1070 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1071 <oslsachem@gmail.com> for helping to debug this.
1072
1073 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1074 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1075 (g_b_init_get_glyph_outline_w): New static variables.
1076 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1077 (GetGlyphOutlineW_Proc): New typedefs.
1078 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1079 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1080 New functions.
1081 (w32font_open_internal, compute_metrics):
1082 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1083 instead of calling the "wide" APIs directly.
1084
1085 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1086
1087 * w32.h (syms_of_w32font): Add prototype.
1088
87e68db4
JB
10892011-10-27 Juanma Barranquero <lekktu@gmail.com>
1090
1091 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1092 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1093 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1094 (Fmove_to_window_line): Doc fix.
1095
435c1d67
CY
10962011-10-27 Chong Yidong <cyd@gnu.org>
1097
1098 * process.c (make_process): Set gnutls_state to NULL.
1099
1100 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1101 non-NULL, regardless of GNUTLS_INITSTAGE.
1102 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1103 an error. Set process slots as soon as we allocate them.
1104
1105 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1106
9c6c6f49
CY
11072011-10-27 Chong Yidong <cyd@gnu.org>
1108
9aba6043
SM
1109 * gnutls.c (emacs_gnutls_deinit): New function.
1110 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1111 (Fgnutls_deinit, Fgnutls_boot): Use it.
1112
1113 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1114 (deactivate_process): Call emacs_gnutls_deinit.
1115
657d08d3
JB
11162011-10-27 Juanma Barranquero <lekktu@gmail.com>
1117
1118 * image.c (x_create_x_image_and_pixmap):
1119 * w32.c (sys_rename, w32_delayed_load):
1120 * w32font.c (fill_in_logfont):
1121 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1122
5430d399
JB
11232011-10-26 Juanma Barranquero <lekktu@gmail.com>
1124
1125 * w32fns.c (w32_default_color_map): New function,
1126 extracted from Fw32_default_color_map.
a7ef684b 1127 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1128
fe0055fa
PE
11292011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1130
1131 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1132
e6346438
SM
11332011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1134
1135 * keyboard.c (test_undefined): New function (bug#9751).
1136 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1137
e112cc37
ET
11382011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1139
1140 * sysdep.c (init_sys_modes): Fix the check for the controlling
1141 terminal (Bug#6649).
1142
7b5d6677
EZ
11432011-10-20 Eli Zaretskii <eliz@gnu.org>
1144
1145 * dispextern.h (struct bidi_it): New member next_en_type.
1146
1147 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1148 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1149 current character, check also for next_en_type being WEAK_EN.
1150 (bidi_resolve_weak): Don't enter the expensive loop if the current
1151 position is before next_en_pos. Record the bidi type of the first
1152 non-ET, non-BN character we find, in addition to its position.
1153 (bidi_level_of_next_char): Invalidate next_en_type when
1154 next_en_pos is over-stepped.
1155
7da0b018
PE
11562011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1157
1158 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1159 * editfns.c: Rewrite current-time-zone so that it invokes
1160 the equivalent of (format-time-string "%Z") to get the time zone name.
1161 This fixes a bug when the time zone name contains characters that
1162 need converting from the system time locale to Emacs internal format.
1163 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1164 that patch fixed format-time-string to do the conversion, but
1165 I forgot to fix current-time-zone.
1166 (format_time_string): New function, containing most of
1167 what Fformat_time_string used to contain.
1168 (Fformat_time_string): Rewrite in terms of format_time_string.
1169 This doesn't change this function's behavior.
1170 (current-time-zone): Rewrite to use format_time_string.
1171 This fixes the bug reported by Michael Schierl in
1172 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1173 Jason Rumney's 2007-06-07 change worked around this bug, but
1174 didn't fix it.
1175 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1176
8547b010
EZ
11772011-10-19 Eli Zaretskii <eliz@gnu.org>
1178
1179 * xdisp.c (start_display): If the character at POS is displayed
1180 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1181 (try_window_reusing_current_matrix): If a line ends in a display
1182 vector or the next line starts in a display vector, continue
1183 redrawing the window even though the character position of
1184 start_row was reached.
8547b010
EZ
1185 (Bug#9771, part 2)
1186
4e948d15
CY
11872011-10-18 Chong Yidong <cyd@gnu.org>
1188
1189 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1190 with nobreak-char-display too.
1191
4787455f
EZ
11922011-10-18 Eli Zaretskii <eliz@gnu.org>
1193
1194 Fix part 3 of bug#9771.
1195 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1196 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1197 non-neutral characters if the current character is a paragraph
1198 separator (a.k.a. Newline). This avoids running the same
1199 expensive loop twice, once when we consume the preceding newline
1200 and the other time when the line actually needs to be displayed.
1201 Avoid the loop when we see neutrals on the base embedding level
1202 following a character whose directionality is the same as the
1203 paragraph's. This avoids running the expensive loop when a line
1204 ends in a long sequence of neutrals, like control characters.
1205 Add assertion against STRONG_AL type. Slightly rearrange code
1206 that determines the type of a neutral given the first non-neutral
1207 that follows it.
1208 (bidi_level_of_next_char): Set next_en_pos to zero when
1209 invalidating its info.
1210
2c91f553
EZ
12112011-10-17 Eli Zaretskii <eliz@gnu.org>
1212
1213 * xdisp.c (push_display_prop): Determine whether to record string
1214 or buffer position by IT->string, not by IT->method. Allow
1215 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1216 (move_it_vertically_backward): Don't look for character position
1217 immediately after the newline when in a continuation line.
1218 (Bug#9771, part 1)
2c91f553 1219
c7b08b0d
MR
12202011-10-15 Martin Rudalics <rudalics@gmx.at>
1221
1222 * window.c (coordinates_in_window): Rewrite and delabelize
1223 vertical border check. (Bug#5357) (Bug#9618)
1224
6b02f655
SM
12252011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1226
1227 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1228 errors in XSetWindowBorder (bug#9310).
1229
81d40c92
DA
12302011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1231
1232 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1233 avoid crash when xmalloc overrun checking is enabled.
1234
d4172c3b
EZ
12352011-10-13 Eli Zaretskii <eliz@gnu.org>
1236
1237 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1238 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1239 cursor motion with <left> and <right> arrow keys.
1240
1241 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1242 some callers set that themselves.
1243
b00eea75
EZ
12442011-10-12 Eli Zaretskii <eliz@gnu.org>
1245
1246 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1247 display string and the previous row comes from the same string and
1248 is empty. (Bug#9739) (Bug#9738)
1249
8fe012c4
SM
12502011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1251
1252 * doc.c (get_doc_string): Encode file name (bug#9735).
1253
0074aef2
EZ
12542011-10-12 Eli Zaretskii <eliz@gnu.org>
1255
79beb178
EZ
1256 * bidi.c (bidi_level_of_next_char):
1257 * xdisp.c (get_visually_first_element): Remove old incorrect
1258 comments regarding the Unicode Line Separator character.
1259
0074aef2
EZ
1260 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1261
6e4b3fbe
DA
12622011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1263
1264 * alloc.c (Fgc_status): Do not access beyond zombies array
1265 boundary if nzombies > MAX_ZOMBIES.
1266 * alloc.c (dump_zombies): Add missing format specifier.
1267
0324f3af
PE
12682011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1269
b5525cac
PE
1270 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1271 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1272
0324f3af
PE
1273 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1274 Some packages use them to denote characters with modifiers.
1275
e9b5f888
AS
12762011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1277
1278 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1279 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1280 matching a pp-number. Rename parameter var to var1.
1281
127827c0
SM
12822011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1283
1284 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1285
c8fd3bd0
GM
12862011-10-08 Glenn Morris <rgm@gnu.org>
1287
1288 * callint.c (Fcall_interactively): Give a more explicit error for the
1289 'c' case with a non-character input. (Bug#8479)
1290
352ec8ff
EZ
12912011-10-08 Eli Zaretskii <eliz@gnu.org>
1292
03669ccb
EZ
1293 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1294 lines.
7061c986
EZ
1295 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1296 lines that are hscrolled on the left.
03669ccb 1297
352ec8ff
EZ
1298 * dispnew.c (buffer_posn_from_coords): Account for a possible
1299 presence of header-line. (Bug#4426)
1300
a66cfb1c
SM
13012011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1302
6b02f655
SM
1303 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1304 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1305
7c5ee88e
PE
13062011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1307
1308 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1309 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1310 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1311 this makes Emacs dump core during garbage collection on rare
1312 occasions. sizeof is obviously inferior to offsetof here, so
1313 stick with offsetof.
1314 (GC_POINTER_ALIGNMENT): New macro.
1315 (mark_memory): Omit 3rd (offset) arg; caller changed.
1316 Don't assume EMACS_INT alignment is the same as pointer alignment.
1317
df1bbe5b
SM
13182011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1319
1320 * keyboard.c (read_key_sequence_remapped): New var.
1321 (read_key_sequence): Compute remapping in the right buffer.
1322 (command_loop_1): Use read_key_sequence's remapping directly.
1323
51553db6
SM
13242011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1325
32c1fffd
SM
1326 * dired.c (file_name_completion): Don't expand file name.
1327 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1328 before checking file name handler.
1329
51553db6
SM
1330 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1331 they've been requested explicitly (bug#9591).
1332
b6bd1599 13332011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1334
1335 * keymap.c (Fsingle_key_description): Use make_specified_string
1336 instead of build_string to build string from push_key_description.
1337 (Bug#5193)
1338
f701dc2a
PE
13392011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1340
4222c55d
PE
1341 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1342 This fixes a Y2038 bug on 64-bit hosts.
1343 * buffer.c (reset_buffer):
1344 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1345 (Fclear_buffer_auto_save_failure):
1346 Use 0, not -1, to represent an unset failure time, since time_t
1347 might not be signed.
1348
f701dc2a
PE
1349 Remove dependency on glibc malloc internals.
1350 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1351 Move back here from lisp.h, but with their new implementations.
1352 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1353 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1354 * charset.c (charset_table_init): New static var.
1355 (syms_of_charset): Use it instead of xmalloc. This removes a
1356 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1357 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1358 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1359 Move back to alloc.c.
1360 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1361 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1362
9ceebf39
JD
13632011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1364
1365 * nsterm.m (windowDidResize): Call x_set_window_size only when
1366 ns_in_resize is true. Otherwise set pixelwidth/height and
1367 call change_frame_size (Bug#9628).
1368
cb993c58
PE
13692011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1370
3930c88b
PE
1371 Port --enable-checking=all to Fedora 14 x86-64.
1372 * charset.c (syms_of_charset): Also account for glibc malloc's
1373 internal overhead when calculating the initial malloc maximum.
1374
cb993c58
PE
1375 Port --enable-checking=all to Fedora 14 x86.
1376 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1377 Move to lisp.h.
1378 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1379 (overrun_check_realloc, overrun_check_free):
1380 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1381 That way, xmalloc returns a properly-aligned pointer even if
1382 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1383 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1384 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1385 into account when calculating the initial malloc maximum.
1386 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1387 Move here from alloc.c, so that charset.c can use it too.
1388 Properly align; the old code wasn't right for common 32-bit hosts
1389 when configured with --enable-checking=all.
1390 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1391 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1392
31bed486
EZ
13932011-09-29 Eli Zaretskii <eliz@gnu.org>
1394
04c70788 1395 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1396 use EDOM.
1397
fbcaa2f3
EZ
13982011-09-28 Eli Zaretskii <eliz@gnu.org>
1399
1400 * xdisp.c (compute_display_string_end): If there's no display
1401 string at CHARPOS, return -1.
1402
1403 * bidi.c (bidi_fetch_char): When compute_display_string_end
1404 returns a negative value, treat the character as a normal
1405 character not covered by a display string. (Bug#9624)
1406
a239d4e9
JB
14072011-09-28 Juanma Barranquero <lekktu@gmail.com>
1408
1409 * lread.c (Fread_from_string): Fix typo in docstring.
1410
88652fd5
EZ
14112011-09-27 Eli Zaretskii <eliz@gnu.org>
1412
1413 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1414 newline, reseat the iterator instead of bidi-iterating there one
1415 character at a time. (Bug#9610)
32c1fffd
SM
1416 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1417 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1418
ed497dd4
AS
14192011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1420
1421 * lread.c (readevalloop): Use correct code for NBSP.
1422 (read1): Likewise. (Bug#9608)
1423
b2bf61aa
MA
14242011-09-25 Michael Albinus <michael.albinus@gmx.de>
1425
1426 * dbusbind.c (Fdbus_register_signal): When service is not
1427 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1428
32bbb17c
GM
14292011-09-25 Glenn Morris <rgm@gnu.org>
1430
1431 * buffer.c (truncate-lines): Doc fix.
1432
94e0933e
CY
14332011-09-24 Chong Yidong <cyd@stupidchicken.com>
1434
1435 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1436 (Fset_window_next_buffers): Doc fix.
1437
cddde921
GM
14382011-09-24 Glenn Morris <rgm@gnu.org>
1439
1440 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1441
1260aef1
PE
14422011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1443
25b4bfa0
PE
1444 Fix minor problems found by static checking.
1445 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1446 * indent.c (Fvertical_motion): Fix == vs = typo.
1447
e3cbd34b
EZ
14482011-09-24 Eli Zaretskii <eliz@gnu.org>
1449
a66cfb1c
SM
1450 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1451 Default value is now t. Doc fix.
6bf7006f 1452
e3cbd34b 1453 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1454 logic when moving up, not only when moving down. Fix the
e3cbd34b 1455 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1456 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1457
1458 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1459 CHARPOS is covered by a display string which includes newlines.
1460 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1461 is covered by a display string with embedded newlines.
1462
a3de0cbd
MA
14632011-09-24 Michael Albinus <michael.albinus@gmx.de>
1464
1465 * dbusbind.c (Fdbus_register_signal): Add match rule to
1466 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1467 (Fdbus_register_method, Vdbus_registered_objects_table):
1468 Fix docstring.
a3de0cbd 1469
b260039d
JM
14702011-09-24 Jim Meyering <meyering@redhat.com>
1471
32c1fffd 1472 do not ignore write error for any output size
b260039d
JM
1473 The previous change was incomplete.
1474 While it makes emacs --batch detect the vast majority of stdout
1475 write failures, errors were still ignored whenever the output size is
1476 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1477 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1478 && echo FAIL: ignored write error
1479 FAIL: ignored write error
1480 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1481 && echo FAIL: ignored write error
1482 FAIL: ignored write error
1483 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1484
8eca8a7c
AS
14852011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1486
1487 * emacs.c (Fkill_emacs): In noninteractive mode exit
1488 non-successfully if a write error occurred on stdout. (Bug#9574)
1489
3341db62
EZ
14902011-09-21 Eli Zaretskii <eliz@gnu.org>
1491
1492 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1493 the xassert test.
1494
1495 * dispextern.h (struct it): Update the comment documenting what
1496 can it->OBJECT be.
1497
8c203dbf
EZ
14982011-09-20 Eli Zaretskii <eliz@gnu.org>
1499
1500 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1501 a display string, extend search for cursor position to end of row.
1502 (find_row_edges): If the row ends in a newline from a display
1503 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1504 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1505 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1506 non-empty line. Fixes confusing cursor motion with arrow keys at
1507 the beginning of a line that starts with whitespace.
8c203dbf 1508
a4824228
LMI
15092011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1510
1511 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1512 (bug#9493).
1513
33ed493b
CY
15142011-09-18 Chong Yidong <cyd@stupidchicken.com>
1515
1516 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1517 boolean (Bug#9154).
1518
56cd55c8
EZ
15192011-09-18 Eli Zaretskii <eliz@gnu.org>
1520
1521 * xdisp.c (display_line): Record maximum and minimum buffer
1522 positions even if no glyphs were produced (e.g., by a zero-width
1523 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1524 buffer positions that will be removed from the glyph row because
1525 they don't fit.
c02dcedf
EZ
1526 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1527 column is beyond frame width: don't subtract 1 "pixel" when
1528 computing width of the stretch.
3e62b7e0
EZ
1529 (reseat_at_next_visible_line_start): Undo the change made on
1530 2011-09-17 that saved paragraph information and restored it after
1531 the call to `reseat'. (Bug#9545)
56cd55c8 1532
5ed99d36 15332011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1534
1535 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1536 and turn window cursor on if cleared (Bug#9415).
1537
5ed99d36 15382011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1539
1540 * search.c (boyer_moore): Take unibyte characters from pattern
1541 literally. (Bug#9458)
1542
9bade7b2
EZ
15432011-09-18 Eli Zaretskii <eliz@gnu.org>
1544
1545 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1546
e5e9d610
PE
15472011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1548
87e4427a
PE
1549 Fix minor problem found by static checking.
1550 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1551 initialized, to pacify gcc -Wuninitialized.
1552
e5e9d610
PE
1553 * fileio.c: Report proper errno when syscall falls.
1554 (Finsert_file_contents): Save and restore errno,
1555 so that report_file_error outputs the correct diagnostic.
1556 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1557
a1674f0b
EZ
15582011-09-18 Eli Zaretskii <eliz@gnu.org>
1559
1560 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1561
fbfb6dd4
EZ
15622011-09-17 Eli Zaretskii <eliz@gnu.org>
1563
1564 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1565 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1566
bb187662
EZ
15672011-09-17 Eli Zaretskii <eliz@gnu.org>
1568
1137e8b8 1569 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1570 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1571
1572 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1573 (bidi_find_paragraph_start): Search back for paragraph beginning
1574 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1575 (bidi_move_to_visually_next): Only trigger paragraph-related
1576 computations when the last character is a newline or at EOB, not
1577 just any NEUTRAL_B. (Bug#9470)
1578
bb187662
EZ
1579 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1580 truncated lines if point is covered by a display string. (Bug#9524)
1581
2e621251
PE
15822011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1583
1584 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1585 (cons_to_x_long): New function.
1586 (lisp_data_to_selection_data): Use it. Correct the test for
1587 short-versus-long data; it was negated. Break out of vector
1588 loop, for efficiency, when a long datum is discovered.
1589
91a15bc6
SM
15902011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1591
1592 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1593
b41c3a35
EZ
15942011-09-16 Eli Zaretskii <eliz@gnu.org>
1595
1596 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1597 GCC PR/17406) by declaring this function with external scope.
1598
7812ba2d
PE
15992011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1600
1601 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1602 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1603
cf7edc2a
AS
16042011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1605
1606 * editfns.c (Fformat): Correctly handle text properties on "%%".
1607
bd01620e
EZ
16082011-09-15 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xterm.c (x_draw_composite_glyph_string_foreground):
1611 * w32term.c (x_draw_composite_glyph_string_foreground):
1612 * term.c (encode_terminal_code):
1613 * composite.c (composition_update_it, get_composition_id):
1614 * xdisp.c (get_next_display_element)
1615 (fill_composite_glyph_string): Add comments about special meaning
1616 of TAB characters in a composition.
1617
a02719a3
PE
16182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1619
1620 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1621 This occurs when processing a multibyte format.
1622 Problem reported by Wolfgang Jenker.
a02719a3 1623
72589a3c
JB
16242011-09-15 Johan Bockgård <bojohan@gnu.org>
1625
1626 * xdisp.c (try_cursor_movement): Only check for exact match if
1627 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1628
1c14176c
PE
16292011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1630
1631 Remove unused external symbols.
1632 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1633 * xdisp.c (calc_pixel_width_or_height): Now static.
1634 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1635 * indent.c (check_display_width):
1636 * w32term.c: Fix comment to match code.
1637 * xterm.c, xterm.h (x_catching_errors): Remove.
1638
d2eea5b5
PE
16392011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1640
1641 * xselect.c: Use signed conversions more consistently (Bug#9498).
1642 (selection_data_to_lisp_data): Assume incoming selection data are
1643 signed integers, not unsigned. This is to be consistent with
1644 outgoing selection data, which was modified to use signed integers
1645 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1646 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1647 expects long, not unsigned long.
1648
46888499
EZ
16492011-09-14 Eli Zaretskii <eliz@gnu.org>
1650
1651 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1652 computation of loop end. Reported by Johan Bockgård
1653 <bojohan@gnu.org>.
1654
ef8ef9fb
CY
16552011-09-13 Chong Yidong <cyd@stupidchicken.com>
1656
1657 * frame.c (Fother_visible_frames_p): Function deleted.
1658
fa819fed
EZ
16592011-09-12 Eli Zaretskii <eliz@gnu.org>
1660
1661 * indent.c (compute_motion): Process display vector front to back
1662 rather than the other way around. (Bug#2496)
1663
2ba8e008
SM
16642011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1665
1666 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1667
20f53c69
CY
16682011-09-11 Chong Yidong <cyd@stupidchicken.com>
1669
1670 * minibuf.c (Fread_from_minibuffer): Doc fix.
1671
d562d7a4
EZ
16722011-09-11 Eli Zaretskii <eliz@gnu.org>
1673
1674 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1675 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1676
1c4d7f3d
LMI
16772011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1678
1679 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1680 value for non-existent files.
1681
b885bf36
EZ
16822011-09-11 Eli Zaretskii <eliz@gnu.org>
1683
1684 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1685 set its "size" to -1. This will set the modtime_size field of
1686 the corresponding buffer to -1, which is what
1687 verify-visited-file-modtime expects for files that do not exist.
1688 (Bug#9139)
1689
6612f0bf
PE
16902011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1691
1692 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1693 here ...
1694 * lisp.h: ... from here. push_key_description is no longer
1695 defined in keyboard.c, so its declaration should not be in
1696 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1697 logically belongs with push_key_description.
1698
dfb3f755
PE
16992011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1700
1701 * buffer.h: Include <sys/types.h> instead of <time.h>.
1702 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1703 Problem reported by Herbert J. Skuhra.
1704
3134906c
LMI
17052011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1706
1707 * xml.c (parse_region): Make the parsing work for
1708 non-comment-starting XML files again (bug#9144).
1709
8d903f4e
AS
17102011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1711
1712 * image.c (gif_load): Fix calculation of bottom and right corner.
1713 (Bug#9468)
1714
80ad64f4
EZ
17152011-09-10 Eli Zaretskii <eliz@gnu.org>
1716
1717 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1718 redisplay in small windows.
1719
208a048d
EZ
17202011-09-09 Eli Zaretskii <eliz@gnu.org>
1721
1722 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1723
9b1c252e
MR
17242011-09-08 Martin Rudalics <rudalics@gmx.at>
1725
1726 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1727 Operate on live windows only.
1728
2949f33b
JB
17292011-09-08 Juanma Barranquero <lekktu@gmail.com>
1730
1731 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1732
e08dcafd
EZ
17332011-09-07 Eli Zaretskii <eliz@gnu.org>
1734
1735 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1736 only under bidi iteration.
1737
115b96bd
JD
17382011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1739
1740 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1741
c8199d0f
PE
17422011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1743
1744 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1745 Without this fix, the command to link temacs failed due to an
1746 undefined symbol __builtin_isnan. This is because
1747 /usr/include/iso/math_c99.h #defines isnan(x) to
1748 __builtin_isnan(x), but the bundled gcc, which identifies itself
1749 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1750 a __builtin_isnan.
1751 * floatfns.c (isnan): #undef, and then #define to a clone of
1752 what's in data.c.
1753 (Fisnan): Always define, since it's always available now.
1754 (syms_of_floatfns): Always define isnan at the Lisp level.
1755
e39b275c 17562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1757
1758 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1759
b2db44d9 17602011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1761
f4af5137 1762 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1763 The previous code assumed that file offsets (off_t values) fit in
1764 EMACS_INT variables, which is not true on typical 32-bit hosts.
1765 The code messed up by falsely reporting buffer overflow in cases
1766 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1767 when "big" contains more than 2**29 bytes, even though this
1768 inserts just one byte and does not overflow the buffer.
1769 (Finsert_file_contents): Store file offsets as off_t
1770 values, not as EMACS_INT values. Check for overflow when
1771 converting between EMACS_INT and off_t. When checking for
1772 buffer overflow or for overlap, take the offsets into account.
1773 Don't use EMACS_INT for small values where int suffices.
1774 When checking for overlap, fix a typo: ZV was used where
1775 ZV_BYTE was intended.
1776 (Fwrite_region): Don't assume off_t fits into 'long'.
1777 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1778
ecfc0a49
MA
17792011-09-05 Michael Albinus <michael.albinus@gmx.de>
1780
1781 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1782
6511acf2 17832011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1784
0999621a 1785 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1786
1787 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1788 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1789 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1790 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1791 (modify_event_symbol): Do not assume that the length of
1792 name_alist_or_stem is safe to alloca and fits in int.
1793 (Fexecute_extended_command): Likewise for function name and binding.
1794 (Frecursion_depth): Wrap around reliably on integer overflow.
1795 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1796 since some callers pass EMACS_INT values.
1797 (Fsingle_key_description): Don't crash if symbol name contains more
1798 than MAX_ALLOCA bytes.
1799 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1800 (get_minibuffer): Arg is now EMACS_INT, not int.
1801 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1802 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1803 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1804
2be7d702
PE
1805 * dbusbind.c (signature_cat): New function.
1806 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1807 Do not overrun buffer; instead, report string overflow.
1808
9d1df220
PE
1809 * dispnew.c (add_window_display_history): Don't overrun buffer.
1810 Truncate instead; this is OK since it's just a log.
1811
33ef5c64
PE
1812 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1813 even if the time zone offset is outlandishly large.
1814 Don't mishandle offset == INT_MIN.
1815
66c6fdd5
PE
1816 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1817 when creating daemon; the previous buffer-overflow check was incorrect.
1818
d749b01b
PE
1819 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1820 which has the guts of the old verror function.
1821
b5cd1905
PE
1822 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1823 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1824
6e1a67fb
PE
1825 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1826 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1827 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1828 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1829 length of string rather than counting it via multiple sprintfs;
1830 that's simpler and more reliable.
c21721cc
PE
1831 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1832 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1833 sprintf, in case result does not fit in int.
1834
c57b67fc
PE
1835 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1836 (fontset_from_font): Print it.
1837
8a401434
PE
1838 * frame.c (tty_frame_count): Now printmax_t, not int.
1839 (make_terminal_frame, set_term_frame_name): Print it.
1840 (x_report_frame_params): In X, window IDs are unsigned long,
1841 not signed long, so print them as unsigned.
1842 (validate_x_resource_name): Check for implausibly long names,
1843 and don't assume name length fits in 'int'.
1844 (x_get_resource_string): Don't blindly alloca invocation name;
1845 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1846 not fit in int.
1847
6e1a67fb
PE
1848 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1849 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1850 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1851
0df02bf3
PE
1852 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1853 Use esprintf, not sprintf, in case result does not fit in int.
1854
48e30793
PE
1855 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1856 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1857 it as a large positive number.
1858 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1859 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1860
a66ff6d8
PE
1861 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1862 in case result does not fit in int.
1863
aca216ff
PE
1864 * print.c (float_to_string): Detect width overflow more reliably.
1865 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1866 buffer overrun. Don't assume list length fits in 'int'. Treat
1867 print length of 0 as 0, not as infinity; to be consistent with other
1868 uses of print length in this function. Don't overflow print length
1869 index. Don't assume hash table size fits in 'long', or that
1870 vectorlike size fits in 'unsigned long'.
1871
31c286f7
PE
1872 * process.c (make_process): Use printmax_t, not int, to format
1873 process-name gensyms.
1874
55e5faa1
PE
1875 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1876
80f2e268
PE
1877 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1878 to avoid potential buffer overrun.
1879
670741ab
PE
1880 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1881 if X resource line is longer than 512 bytes.
1882
b7163a50
PE
1883 * xfns.c (x_window): Make sprintf buffer a bit bigger
1884 to avoid potential buffer overrun.
1885
ae58ff1f
PE
1886 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1887
c43c8a6a
PE
1888 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1889
3f8236f4
PE
18902011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1891
53e9fe90 1892 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1893 Without these, Emacs silently mishandles large integers sometimes.
1894 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1895 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1896
6511acf2
PE
1897 * xdisp.c (try_window_id): Check Emacs fixnum range before
1898 converting to 'int'.
806add1d 1899
6511acf2 1900 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1901 Check that an Emacs fixnum is in range before assigning it to 'int'.
1902 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1903 values converted from Emacs fixnums.
1904 (Frecenter): Don't wrap around a line count if it is out of 'int'
1905 range; instead, treat it as an extreme value.
1906 (Fset_window_configuration, compare_window_configurations):
1907 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1908
6511acf2
PE
1909 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1910 that can exceed INT_MAX. Check that EMACS_INT value is in range
1911 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1912 (match_limit): Don't assume that a fixnum can fit in 'int'.
1913
6511acf2 1914 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1915 exceed INT_MAX.
1916
6511acf2 1917 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1918 (Fvertical_motion): Don't wrap around LINES values that don't fit
1919 in 'int'. Instead, treat them as extreme values. This is good
1920 enough for windows, which can't have more than INT_MAX lines anyway.
1921
fcb901a7
LMI
19222011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1923
0f2f6b6d
LMI
1924 * Require libxml/parser.h to avoid compilation warning.
1925
fcb901a7
LMI
1926 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1927
1928 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1929 since this reportedly can destroy thread storage.
1930
6e20a0d4
CY
19312011-08-30 Chong Yidong <cyd@stupidchicken.com>
1932
1933 * syntax.c (find_defun_start): Update all cache variables if
1934 exiting early (Bug#9401).
1935
148ae00e
EZ
19362011-08-30 Eli Zaretskii <eliz@gnu.org>
1937
f6cfbd8f
EZ
1938 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1939
148ae00e
EZ
1940 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1941 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1942 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1943
1944 * term.c (tty_append_glyph): New function.
1945 (produce_stretch_glyph): Static function and its prototype deleted.
1946
a66cfb1c
SM
1947 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1948 Add prototypes.
148ae00e 1949
c4a07a4c
PE
19502011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1951
1952 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1953 when checking :margin (Bug#9390).
1954 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1955 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1956 so that the name doesn't mislead. All uses changed.
1957
6bc8cd65
JB
19582011-08-28 Johan Bockgård <bojohan@gnu.org>
1959
1960 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1961 set_tty_hooks.
1962
dca4927e
EZ
19632011-08-27 Eli Zaretskii <eliz@gnu.org>
1964
1965 * xdisp.c (move_it_to): Don't bail out early when reaching
1966 position beyond to_charpos, if we are scanning backwards.
1967 (move_it_vertically_backward): When DY == 0, make sure we get to
1968 the first character in the line after the newline.
1969
f2cad773
PE
19702011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1971
1972 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1973 (ccl_driver): Do not generate an out-of-range pointer.
1974 (Fccl_execute_on_string): Remove unnecessary check for
1975 integer overflow, noted by Stefan Monnier in
1976 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1977 Remove a FIXME that didn't need fixing.
1978 Simplify the newly-introduced buffer reallocation code.
1979
0cae2cdb
JB
19802011-08-27 Juanma Barranquero <lekktu@gmail.com>
1981
1982 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1983
5fc295a4 19842011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1985
70c60eb2 1986 Integer and memory overflow issues (Bug#9196).
726e0ab1 1987
d31850da
PE
1988 * doc.c (get_doc_string): Rework so that
1989 get_doc_string_buffer_size is the actual buffer size, rather than
1990 being 1 less than the actual buffer size; this makes xpalloc more
1991 convenient.
1992
a69fbedb
PE
1993 * image.c (x_allocate_bitmap_record, cache_image):
1994 * xselect.c (Fx_register_dnd_atom):
1995 Simplify previous changes by using xpalloc.
1996
fe5c5d37
PE
1997 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1998 since either will do and ptrdiff_t is convenient with xpalloc.
1999
0065d054
PE
2000 * charset.c (charset_table_size)
2001 (struct charset_sort_data.priority): Now ptrdiff_t.
2002 (charset_compare): Don't overflow if priorities differ greatly.
2003 (Fsort_charsets): Don't assume list length fits in int.
2004 Check for size-calculation overflow when allocating sort data.
2005 (syms_of_charset): Allocate an initial charset table that is
2006 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2007
2008 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2009
2010 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2011 The actual value is always <= INT_MAX, and leaving it unsigned made
2012 overflow checking harder.
2013
2014 * dispextern.h (struct glyph_matrix.rows_allocated)
2015 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2016 with xpalloc. The values are still always <= INT_MAX.
2017
2018 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2019
2020 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2021 (SAFE_NALLOCA): New macro.
2022
2023 * region-cache.c (struct boundary.pos, find_cache_boundary)
2024 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2025 (set_cache_region, invalidate_region_cache)
2026 (revalidate_region_cache, know_region_cache, region_cache_forward)
2027 (region_cache_backward, pp_cache):
2028 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2029 so that ptrdiff_t * can be passed to xpalloc.
2030 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2031 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2032 (pp_cache): Don't assume cache_len fits in int.
2033 * region-cache.h: Adjust extern decls to match.
2034
2035 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2036 EMACS_INT, since either will do, for xpalloc.
2037
2038 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2039 (xnmalloc, xnrealloc, xpalloc): New functions.
2040
726e0ab1
PE
2041 * bidi.c (bidi_shelve_header_size): New constant.
2042 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2043 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2044
51f30bc5 2045 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2046 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2047 (overlay_strings):
2048 Don't update size of array until after memory allocation succeeds,
2049 because xmalloc/xrealloc may not return.
0065d054
PE
2050 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2051 now that we have proper integer overflow checking.
2052 (record_overlay_string, overlay_strings): Catch overflows when
2053 calculating size of overlay_str_buf.
726e0ab1 2054
0065d054
PE
2055 * callproc.c (Fcall_process): Check for size overflow when
2056 calculating size of args2.
2057 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2058 Normally we prefer signed values, but sticking with ptrdiff_t would
2059 require adding more-complicated checks.
726e0ab1
PE
2060
2061 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2062 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2063 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2064 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2065
2066 * character.c (Fstring): Check for size-calculation overflow.
2067
2068 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2069 unnecessary integer overflow. Check for size overflow.
2070 (encode_coding_object): Don't update size until xmalloc succeeds.
2071
2072 * composite.c (get_composition_id): Check for overflow in glyph
2073 length calculations.
2074
2075 Integer and memory overflow fixes for display code.
2076 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2077 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2078 (scrolling_window): Check for overflow in size calculations.
2079 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2080 Don't assume glyph table len fits in int.
2081 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2082 (row_table_size): Now ptrdiff_t, not int.
2083 (scrolling_window): Avoid overflow in size calculations.
2084 Don't update size until allocation succeeds.
2085 * fns.c (concat): Check for overflow in size calculations.
2086 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2087 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2088 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2089
2090 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2091 (get_doc_string): Check for size calculation overflow.
2092 Don't update size until allocation succeeds.
2093 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2094 EMACS_INT, where ptrdiff_t will do.
2095 (Fsubstitute_command_keys): Check for string overflow.
2096
2097 * editfns.c (set_time_zone_rule): Don't assume environment length
2098 fits in int.
2099 (message_length): Now ptrdiff_t, not int.
2100 (Fmessage_box): Don't update size until allocation succeeds.
2101 Don't assume message length fits in int.
2102 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2103
0065d054
PE
2104 * emacs.c (main): Do not reallocate argv, since there is a null at
2105 the end that can be overwritten, and this way there's no need to
2106 worry about size-calculation overflow.
2107 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2108
2109 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2110 alloc succeeds.
2111 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2112
2113 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2114 (x_set_scroll_bar_width, x_figure_window_size):
2115 Check for integer overflow.
2116 (x_set_alpha): Do not assume XINT fits in int.
2117
2118 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2119 This is for the members text_lines, text_cols, total_lines, total_cols,
2120 where the system imposes an 'int' limit.
2121
2122 * fringe.c (Fdefine_fringe_bitmap):
2123 Don't update size until alloc works.
2124
2125 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2126 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2127
2128 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2129 Check for size-calculation overflow.
2130 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2131 do, as we prefer signed integers.
2132 (id_to_widget.max_size, id_to_widget.used)
2133 (xg_store_widget_in_map, xg_remove_widget_from_map)
2134 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2135 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2136 Use and return ptrdiff_t, not int.
2137 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2138 * gtkutil.h: Change prototypes to match the above.
2139
2140 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2141 are duplicate now that they've been promoted to lisp.h.
2142 (x_allocate_bitmap_record, x_alloc_image_color)
2143 (make_image_cache, cache_image, xpm_load):
2144 Don't update size until alloc is done.
2145 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2146 (x_detect_edges):
3256efce 2147 Check for size calculation overflow.
726e0ab1
PE
2148 (ct_colors_allocated_max): New constant.
2149 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2150 overflow.
3256efce 2151
726e0ab1
PE
2152 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2153 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2154 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2155 Use ptrdiff_t, not int, to count maps.
2156 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2157 calculations. Don't update size until allocation succeeds.
2158 Redo calculations to avoid overflow.
726e0ab1
PE
2159 * keyboard.h: Change prototypes to match the above.
2160
2161 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2162 to count maps.
2163 (current_minor_maps): Check for size calculation overflow.
2164 * keymap.h: Change prototypes to match the above.
2165
2166 * lread.c (read1, init_obarray): Don't update size until alloc done.
2167
2168 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2169 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2170
726e0ab1
PE
2171 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2172 Now ptrdiff_t, not int.
2173 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2174 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2175
2176 * process.c (Fnetwork_interface_list): Check for overflow
2177 in size calculation.
2178
2179 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2180
2181 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2182 overflow. Don't bother calling xmalloc when xrealloc will do.
2183
2184 * search.c (Freplace_match): Check for size calculation overflow.
2185 (Fset_match_data): Don't assume list lengths fit in 'int'.
2186
2187 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2188 for command line length. Do not attempt to address one before the
2189 beginning of an array, as that's not portable.
2190
2191 * term.c (max_frame_lines): Remove; unused.
2192 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2193 not int.
2194 (encode_terminal_code, calculate_costs): Check for size
2195 calculation overflow.
2196 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2197 table lengths and related sizes. Don't update size until alloc
2198 done. Redo calculations to avoid overflow.
2199 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2200
2201 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2202 subtracting pointers.
2203 (gobble_line): Check for overflow more carefully. Don't update size
2204 until alloc done.
2205
2206 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2207 Don't update size until alloc done.
2208 Redo size calculations to avoid overflow.
2209 Check for size calculation overflow.
0065d054 2210 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2211
2212 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2213 Use ptrdiff_t, not int, for sizes.
2214 (store_mode_line_noprop_char): Don't update size until alloc done.
2215
0065d054
PE
2216 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2217 Use ptrdiff_t, not int, for sizes.
2218 (Finternal_make_lisp_face, cache_face):
2219 Check for size calculation overflow.
2220 (cache_face): Treat size calculation overflows as if they were
2221 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2222
2223 * xfns.c (x_encode_text, x_set_name_internal)
2224 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2225 sizes, since they can exceed INT_MAX in size. Check for size
2226 calculation overflow.
2227
0065d054
PE
2228 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2229 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2230 Don't update size until alloc done.
2231
0065d054 2232 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2233 as sprintf is limited to int lengths.
1d526e2f 2234
252c5ee1
PE
2235 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2236 (X_LONG_MIN): New macros.
864d7ce7
PE
2237 Use them to make the following changes clearer.
2238 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2239 This change doesn't affect the value now, but it may help remind
2240 future maintainers not to raise the value too much later.
2241 (SELECTION_QUANTUM): Remove, replacing with ...
2242 (selection_quantum): ... new function, which avoids overflow.
2243 All uses changed.
2244 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2245 assumption that selection length fits in 'int'.
2246 (x_reply_selection_request, x_handle_selection_request)
2247 (x_get_window_property, receive_incremental_selection)
2248 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2249 (lisp_data_to_selection_data, clean_local_selection_data):
2250 Use ptrdiff_t, not int, to record length of selection.
2251 (x_reply_selection_request, x_get_window_property)
2252 (receive_incremental_selection, x_property_data_to_lisp):
2253 Redo calculations to avoid overflow.
2254 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2255 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2256 something.
2257 (x_get_window_property, receive_incremental_selection)
2258 (lisp_data_to_selection_data, x_property_data_to_lisp):
2259 Check for size-calculation overflow.
2260 (x_get_window_property, receive_incremental_selection)
2261 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2262 Don't store size until memory allocation succeeds.
2263 (x_get_window_property): Plug memory leak on memory exhaustion.
2264 Don't double-block input; malloc is safe here. Don't assume 2**34
2265 - 4 fits in unsigned long. Add an xassert to check
2266 XGetWindowProperty overflow. Be more careful about overflow
2267 calculations, and distinguish size from memory overflow better.
2268 (receive_incremental_selection): When tracing, don't assume
2269 unsigned int is less than INT_MAX.
2270 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2271 harmful) conversions of unsigned short to int.
2272 (lisp_data_to_selection_data): Don't assume that integers
2273 in the range -65535 through -1 fit in an X unsigned short.
2274 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2275 result parameters unless successful. Rely on cons_to_unsigned
2276 to report problems with elements; the old code wasn't right anyway.
2277 (x_check_property_data): Check for int overflow; we cannot use
2278 a wider type due to X limits.
2279 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2280
726e0ab1 2281 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2282
0065d054
PE
2283 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2284 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2285 (x_color_cells): Don't store size until memory allocation succeeds.
2286 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2287 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2288 (x_term_init): Don't assume length fits in int (sprintf is limited
2289 to int size).
bc18e09d 2290
ebfa62c0
PE
2291 Use ptrdiff_t for composition IDs.
2292 * character.c (lisp_string_width):
2293 * composite.c (composition_table_size, n_compositions)
2294 (get_composition_id, composition_gstring_from_id):
2295 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2296 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2297 * window.c (Frecenter):
2298 Use ptrdiff_t, not int, for composition IDs.
2299 * composite.c (get_composition_id): Check for integer overflow.
2300 * composite.h: Adjust prototypes to match the above changes.
2301
d3411f89
PE
2302 Use ptrdiff_t for hash table indexes.
2303 * category.c (hash_get_category_set):
2304 * ccl.c (ccl_driver):
2305 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2306 * coding.c (coding_system_charset_list, detect_coding_system):
2307 * coding.h (struct coding_system.id):
2308 * composite.c (get_composition_id, gstring_lookup_cache):
2309 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2310 * image.c (xpm_get_color_table_h):
2311 * lisp.h (hash_lookup, hash_put):
2312 * minibuf.c (Ftest_completion):
2313 Use ptrdiff_t for hash table indexes, not int (which is too
2314 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2315 32-bit --with-wide-int hosts).
2316
e097a6fa
PE
2317 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2318 Add a FIXME comment about memory leaks.
2319 (syms_of_charset): Don't assume xmalloc returns.
2320
5637687f
PE
2321 Don't assume that stated character widths fit in int.
2322 * character.c (Fchar_width, c_string_width, lisp_string_width):
2323 * character.h (CHAR_WIDTH):
2324 * indent.c (MULTIBYTE_BYTES_WIDTH):
2325 Use sanitize_char_width to avoid undefined and/or bad behavior
2326 with outlandish widths.
a66cfb1c 2327 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2328 now that we have two such functions. All uses changed.
2329 (sanitize_char_width): New inline function.
2330
a2271ba2
PE
2331 Don't assume that tab-width fits in int.
2332 * character.h (sanitize_width): New inline function.
2333 (SANE_TAB_WIDTH): New macro.
2334 (ASCII_CHAR_WIDTH): Use it.
2335 * indent.c (sane_tab_width): Remove. All uses replaced by
2336 SANE_TAB_WIDTH (current_buffer).
2337 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2338
18c52557
PE
2339 * fileio.c: Integer overflow issues with file modes.
2340 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2341
caeeedc1
PE
2342 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2343 Remove unreachable code.
2344 (read_hex, load_charset_map_from_file): Check for integer overflow.
2345
50849c52
PE
2346 * xterm.c: don't go over XClientMessageEvent limit
2347 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2348 (x_send_scroll_bar_event): Likewise. Check that the size does not
2349 exceed limits imposed by XClientMessageEvent, as well as the usual
2350 ptrdiff_t and size_t limits.
2351
b13995db
PE
2352 * keyboard.c: Overflow, signedness and related fixes.
2353 (make_lispy_movement): Use same integer type in forward decl
2354 that is used in the definition.
2355 (read_key_sequence, keyremap_step):
2356 Change bufsize argument back to int, undoing my 2011-03-30 change.
2357 We prefer signed types, and int is wide enough here.
2358 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2359 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2360 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2361 length, not size_t. Use ptrdiff_t for index, not int.
2362 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2363 possibility of integer overflow.
2364
13464394
PE
2365 Overflow, signedness and related fixes for images.
2366
2367 * dispextern.h (struct it.stack[0].u.image.image_id)
2368 (struct_it.image_id, struct image.id, struct image_cache.size)
2369 (struct image_cache.used, struct image_cache.ref_count):
2370 * gtkutil.c (update_frame_tool_bar):
2371 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2372 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2373 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2374 * nsmenu.m (update_frame_tool_bar):
2375 * xdisp.c (calc_pixel_width_or_height):
2376 * xfns.c (image_cache_refcount):
2377 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2378 on typical 64-bit hosts.
2379
2380 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2381 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2382 Omit unnecessary casts to int.
2383 (parse_image_spec): Check that integers fall into 'int' range
2384 when the callers expect that.
2385 (image_ascent): Redo ascent calculation to avoid int overflow.
2386 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2387 (lookup_image): Remove unnecessary tests.
2388 (xbm_image_p): Locals are now of int, not EMACS_INT,
2389 since parse_image_check makes sure they fit into int.
2390 (png_load, gif_load, svg_load_image):
2391 Prefer int to unsigned where either will do.
2392 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2393 old tiff_error_handler and tiff_warning_handler.
2394 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2395 stack buffer overflows. It uses only the features of vsnprintf
2396 that are common to both POSIX and native Microsoft.
2397 (tiff_error_handler, tiff_warning_handler): Use it.
2398 (tiff_load, gif_load, imagemagick_load_image):
2399 Don't assume :index value fits in 'int'.
2400 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2401 (imagemagick_load_image): Check that crop parameters fit into
2402 the integer types that MagickCropImage accepts. Don't assume
2403 Vimagemagick_render_type has a nonnegative value. Don't assume
2404 size_t fits in 'long'.
2405 (gs_load): Use printmax_t to print the widest integers possible.
2406 Check for integer overflow when computing image height and width.
2407
c11821d4
EZ
24082011-08-26 Eli Zaretskii <eliz@gnu.org>
2409
2410 * xdisp.c (redisplay_window): Don't force window start if point
2411 will be invisible in the resulting window. (Bug#9324)
2412
0c95fcf7
EZ
24132011-08-25 Eli Zaretskii <eliz@gnu.org>
2414
2415 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2416 the display spec is of the form `(space ...)'.
2417 (handle_display_spec): Return the value returned by
2418 handle_single_display_spec, not just 1 or zero.
2419 (handle_single_display_spec): If the display spec is of the form
2420 `(space ...)', and specifies display in the text area, return 2
2421 rather than 1.
fee65a97 2422 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2423 accurately, and prefer exact match for point under bidi.
2424 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2425
2426 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2427 into disp_prop; all users changed.
2428
2429 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2430 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2431 for the text covered by the display property.
2432
e4ed06f1
CY
24332011-08-25 Chong Yidong <cyd@stupidchicken.com>
2434
2435 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2436 Change return value to nil.
2437 (Frecord_buffer): Delete unused function.
2438
f67cdd7f
EZ
24392011-08-24 Eli Zaretskii <eliz@gnu.org>
2440
5980d4c6
EZ
2441 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2442 buffers, return left-to-right.
8610fe8b
EZ
2443 (set_cursor_from_row): Consider candidate row a win if its glyph
2444 represents a newline and point is on that newline. Fixes cursor
2445 positioning on the newline at EOL of R2L text within L2R
2446 paragraph, and vice versa.
2447 (try_cursor_movement): Check continued rows, in addition to
2448 continuation rows. Fixes unwarranted scroll when point enters a
2449 continued line of R2L text within an L2R paragraph, or vice versa.
2450 (cursor_row_p): Consider the case of point being equal to
2451 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2452 from the end of a short line to the beginning of a continued line
2453 of R2L text within L2R paragraph.
2454 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2455 composed characters.
5980d4c6 2456
f67cdd7f
EZ
2457 * bidi.c (bidi_check_type): Use xassert.
2458 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2459 members.
2460
bca633fb
EZ
24612011-08-23 Eli Zaretskii <eliz@gnu.org>
2462
2463 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2464 a character.
2465
4a5885a7
CY
24662011-08-23 Chong Yidong <cyd@stupidchicken.com>
2467
2468 * nsfont.m (ns_otf_to_script): Fix typo.
2469
0902a04e
KH
24702011-08-22 Kenichi Handa <handa@m17n.org>
2471
2472 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2473 extra slot even if the purpose is char-code-property-table.
2474
1a2e6670
EZ
24752011-08-23 Eli Zaretskii <eliz@gnu.org>
2476
8ddde651
EZ
2477 * xdisp.c (redisplay_window): When computing centering_position,
2478 account for the height of the header line. (Bug#8874)
2479
425cc014
EZ
2480 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2481 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2482 candidate is selected by the mouse, and that candidate has a
2483 composed character under the mouse.
2484
1a2e6670
EZ
2485 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2486 coordinates reported by pos-visible-in-window-p for a composed
2487 character in column zero.
2488
8b76d6f8
SM
24892011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2490
2491 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2492
dac347dd
EZ
24932011-08-22 Eli Zaretskii <eliz@gnu.org>
2494
2495 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2496 consider it a hit if to_charpos is anywhere in the range of the
2497 composed buffer positions.
2498
e013fb34
CY
24992011-08-22 Chong Yidong <cyd@stupidchicken.com>
2500
2501 * image.c (gif_load): Don't assume that each subimage has the same
2502 dimensions as the base image. Handle disposal method that is
2503 "undefined" by the gif spec (Bug#9335).
2504
bd1ba3e8
CY
25052011-08-20 Chong Yidong <cyd@stupidchicken.com>
2506
2507 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2508 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2509
54a1215b
EZ
25102011-08-19 Eli Zaretskii <eliz@gnu.org>
2511
823564e5
EZ
2512 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2513 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2514 from an Org mode buffer to a Speedbar frame.
2515
54a1215b
EZ
2516 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2517 a composition, take its buffer position from IT->cmp_it.charpos.
2518 Fixes cursor positioning at the beginning of a line that begins
2519 with a composed character.
2520
9778ebcc
EZ
25212011-08-18 Eli Zaretskii <eliz@gnu.org>
2522
0be6ee06
EZ
2523 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2524 character bidirectional type, use STRONG_L instead. Fixes crashes
2525 in a buffer produced by `describe-categories'.
2526
9778ebcc
EZ
2527 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2528 members before the level stack, so they would be saved and
2529 restored when copying iterator state. Fixes incorrect reordering
2530 around TABs covered by display properties.
2531
156bffbe
AS
25322011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2533
6b02f655 2534 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2535
72ad093b
CY
25362011-08-17 Chong Yidong <cyd@stupidchicken.com>
2537
2538 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2539 (internal_condition_case_2, internal_condition_case_n):
2540 Remove unnecessary aborts (Bug#9081).
72ad093b 2541
35774242
EZ
25422011-08-17 Eli Zaretskii <eliz@gnu.org>
2543
2544 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2545 has no `load' handler, try opening the file locally. (Bug#9311)
2546
db76dd85
KB
25472011-08-16 Ken Brown <kbrown@cornell.edu>
2548
2549 * gmalloc.c: Expand comment.
2550
b215eee5
EZ
25512011-08-16 Eli Zaretskii <eliz@gnu.org>
2552
2553 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2554 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2555
a4579d33
KB
25562011-08-16 Ken Brown <kbrown@cornell.edu>
2557
2558 Fix memory allocation problems in Cygwin build (Bug#9273).
2559
2560 * unexcw.c ( __malloc_initialized): Declare external variable.
2561 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2562
8b76d6f8
SM
2563 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2564 New variables.
a4579d33
KB
2565 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2566 dumped emacs.
2567 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2568 in the static heap.
2569 [CYGWIN] (special_realloc): New function.
2570 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2571 requests to realloc storage in the static heap.
2572
3ebec551
PE
25732011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2574
2575 * bidi.c (bidi_initialize): Remove unused local.
2576
9fd8be00
EZ
25772011-08-15 Eli Zaretskii <eliz@gnu.org>
2578
6b02f655
SM
2579 * bidimirror.h:
2580 * biditype.h: Remove file.
2581 * makefile.w32-in ($(BLD)/bidi.$(O)):
2582 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2583
2584 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2585
2586 * chartab.c: Improve commentary for the uniprop_table API.
2587
32413314
EZ
2588 * bidi.c (bidi_paragraph_init): Support zero value of
2589 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2590 (bidi_initialize): Use uniprop_table instead of including
2591 biditype.h and bidimirror.h.
32413314 2592
9fd8be00
EZ
2593 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2594 coordinates of the iterator when restoring from ppos_it.
2595 (Bug#9296)
2596
5cf2b69b
KH
25972011-08-14 Kenichi Handa <handa@m17n.org>
2598
2599 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2600 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2601
daf17d00
EZ
26022011-08-14 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (move_it_in_display_line_to): Don't invoke
2605 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2606 ppos_it. Fixes vertical cursor motion when line beginning is
2607 covered by an image. (Bug#9296)
2608
08e3161a
JD
26092011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2610
2611 * nsterm.h (ns_run_ascript): Declare.
2612 (NSAPP_DATA2_RUNASSCRIPT): Define.
2613
2614 * nsfns.m (as_script, as_result, as_status): New static variables.
2615 (ns_run_ascript): New function.
5e617bc2 2616 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2617 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2618 the event loop. Get status from as_status (Bug#7276).
2619
2620 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2621 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2622 the event loop (Bug#7276).
2623
a3720aa2
AS
26242011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2625
2626 * gnutls.c (QCgnutls_bootprop_priority)
2627 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2628 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2629 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2630 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2631 (QCgnutls_bootprop_verify_hostname_error)
2632 (QCgnutls_bootprop_callbacks_verify): Rename from
2633 Qgnutls_bootprop_..., all uses changed.
2634
2635 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2636 uses changed.
2637
0a0d27fb
PE
26382011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2639
19d5c50c
PE
2640 * xfaces.c (Qframe_set_background_mode): Now static.
2641 * dispextern.h (Qframe_set_background_mode): Remove decl.
2642
0a0d27fb
PE
2643 * process.c (Fnetwork_interface_info): Declare local only if needed.
2644
377538cb
JD
26452011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2646
2647 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2648 (Fnetwork_interface_list): Allocate in increments of bytes instead
2649 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2650 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2651 sockaddr.
2652 (struct ifflag_def): notrailers is smart on OSX.
2653 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2654 Get hardware address with getifaddrs if available.
2655
08fff70c
EZ
26562011-08-12 Eli Zaretskii <eliz@gnu.org>
2657
2658 * xdisp.c (iterate_out_of_display_property): xassert that
2659 IT->position is set to within IT->object's boundaries. Break from
2660 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2661 when IT->position is set up wrongly due to some bug.
2662 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2663 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2664 entry. Force push_it to save on the stack the current
2665 buffer/string position, to be restored by pop_it. Fix flags in
2666 the iterator structure wrt the object coming from a display
2667 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2668 properties. (Bug#9284)
2669
7be1c708 26702011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2671
7be1c708
CY
2672 * fontset.c (fontset_get_font_group): Add proper type checks.
2673 (Bug#9172)
aac0c6e3 2674
7be1c708 26752011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2676
7be1c708
CY
2677 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2678 and LC_VERSION_MIN_MACOSX.
2679 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2680 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2681
97bb72a6
EZ
26822011-08-08 Eli Zaretskii <eliz@gnu.org>
2683
2684 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2685 no-display-properties-and-no-overlays under bidi display.
2686 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2687 properties and overlays.
97bb72a6 2688
d5617611
CY
26892011-08-08 Chong Yidong <cyd@stupidchicken.com>
2690
37e11a63
CY
2691 * editfns.c (Fset_time_zone_rule): Document relationship with the
2692 setenv function.
2693
d5617611
CY
2694 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2695 the font entity extracted from the cache (Bug#8109).
2696
58872834
CY
26972011-08-07 Chong Yidong <cyd@stupidchicken.com>
2698
2699 * composite.c (autocmp_chars): Don't reset point. That is done by
2700 restore_point_unwind (Bug#5984).
2701
75bfc667
JL
27022011-08-07 Juri Linkov <juri@jurta.org>
2703
2704 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2705 to show the arg `TIME' instead of `TIMEVAL'.
2706
d1410150
EZ
27072011-08-06 Eli Zaretskii <eliz@gnu.org>
2708
2709 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2710 display property strides EOL and includes a newline, as in
2711 longlines-mode. (Bug#9254)
75b771e4
EZ
2712 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2713 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2714
2715 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2716 is non-zero, even if the data buffer is NULL. Fixes a crash in
2717 vertical-motion with longlines-mode. (Bug#9254)
2718
35928349
EZ
27192011-08-05 Eli Zaretskii <eliz@gnu.org>
2720
ec7cc85b
EZ
2721 * bidi.c <bidi_cache_total_alloc>: Now static.
2722 (bidi_initialize): Initialize bidi_cache_total_alloc.
2723
8b76d6f8 2724 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2725 cache. (Bug#9221)
2726
2727 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2728 amount allocated this far in `bidi_cache_total_alloc'.
2729 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2730 non-zero, only free the data buffer without restoring the cache
2731 contents. All callers changed.
2732
2733 * dispextern.h (bidi_unshelve_cache): Update prototype.
2734
2735 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2736 (move_it_in_display_line, move_it_to)
2737 (move_it_vertically_backward, move_it_by_lines): Replace the call
2738 to xfree to an equivalent call to bidi_unshelve_cache.
2739 (move_it_in_display_line_to): Fix logic of returning
412b6358 2740 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2741
e2e2423b
EZ
27422011-08-05 Eli Zaretskii <eliz@gnu.org>
2743
2744 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2745 came from a string character with a `cursor' property. (Bug#9229)
2746
ae9e757a
JD
27472011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2748
2749 * Makefile.in (LIB_PTHREAD): New variable.
2750 (LIBES): Add LIB_PTHREAD (Bug#9216).
2751
2752 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2753 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2754
213bd7f2
AS
27552011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2756
6b02f655 2757 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2758
99aaf75f
JD
27592011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2760
2761 * xterm.c (x_find_topmost_parent): New function.
2762 (x_set_frame_alpha): Find topmost parent window with
2763 x_find_topmost_parent and set the property there also (bug#9181).
2764 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2765
c74e9d86
PE
27662011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2767
2768 * callproc.c (Fcall_process): Avoid vfork clobbering
2769 the local vars buffer, coding_systems, current_dir.
2770
640c8776
SM
27712011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2772
2773 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2774
f26d0e4c
PE
27752011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2776
8a10d76c
PE
2777 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2778 so that it is not optimized away.
2779
f26d0e4c
PE
2780 * xdisp.c (compute_display_string_pos): Remove unused local.
2781
55439c61
EZ
27822011-08-02 Eli Zaretskii <eliz@gnu.org>
2783
2784 Fix slow cursor motion and scrolling in large buffers with
2785 selective display, like Org Mode buffers. (Bug#9218)
2786
2787 * dispextern.h (struct bidi_it): New member disp_prop_p.
2788
2789 * xdisp.c: Remove one-slot cache of display string positions.
2790 (compute_display_string_pos): Accept an additional argument
5e617bc2 2791 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2792 for a display string or property. If found, set DISP_PROP_P
2793 non-zero.
2794
2795 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2796 DISP_PROP_P, and pass it to compute_display_string_pos.
2797 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2798 non-zero. All callers of bidi_fetch_char changed.
2799
fb33fa43
SM
28002011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2801
2802 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2803
b099e063
DM
28042010-12-03 Don March <don@ohspite.net>
2805
2806 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2807 last character M-[char] is translated to ESC [char] (bug#7541).
2808
5cc7f7af
KH
28092011-08-02 Kenichi Handa <handa@m17n.org>
2810
d0fffa3f 2811 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2812
2813 * chartab.c (uniprop_table): Make it non-static.
2814
525d5e6e
EZ
28152011-08-01 Eli Zaretskii <eliz@gnu.org>
2816
2817 * xdisp.c (forward_to_next_line_start): Accept additional argument
2818 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2819 on the newline.
2820 (reseat_at_next_visible_line_start): Use the bidi iterator state
2821 returned by forward_to_next_line_start to restore the state of
2822 it->bidi_it after backing up to previous newline. (Bug#9212)
2823
31011111
AS
28242011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2825
2826 * regex.c (re_comp): Protoize.
2827 (re_exec): Fix return type.
2828 (regexec): Fix type of `ret'. (Bug#9203)
2829
476371c4
PE
28302011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2831
e5d76069
PE
2832 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2833 This is needed if max-image-size is a floating-point number.
2834
9a79b20c
AS
28352011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2836
2837 * print.c (print_object): Print empty symbol as ##.
2838
2839 * lread.c (read1): Read ## as empty symbol.
2840
d8c2fa78
AA
28412011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2842
2843 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2844 setting frame foreground color (Bug#9175).
2845 (x_set_background_color): Likewise.
2846
ffe57a7a
AA
2847 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2848 contents (Bug#9176).
2849 (EmacsTooltip -init): Remove bezels and add shadows to
2850 tooltip windows.
2851
bf3492a5
AA
2852 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2853 or scroll bar (Bug#8470).
2854
d55e9c53
AA
2855 * nsfont.m (nsfont_open): Remove assignment to voffset and
2856 unnecessary vars hshink, expand, hd, full_height, min_height.
2857 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2858
2859 * nsterm.h (nsfont_info): Remove voffset field.
2860
d8c2fa78 28612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2862
2863 Implement strike-through and overline on NextStep (Bug#8863).
2864
2865 * nsfont.m (nsfont_open): Use underline position provided by font,
2866 instead of hard-coded value of 2.
2867 (nsfont_draw): Call ns_draw_text_decoration instead.
2868
2869 * nsterm.h: Add declaration for ns_draw_text_decoration.
2870
2871 * nsterm.m (ns_draw_text_decoration): New function for drawing
2872 underline, overline, and strike-through.
2873 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2874 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2875 accommodate underlining, etc.
4843aac3 2876
4cc60b9b
EZ
28772011-07-28 Eli Zaretskii <eliz@gnu.org>
2878
bc7ece87
EZ
2879 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2880 default.
4cc60b9b 2881
476371c4
PE
28822011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2883
66606eea
PE
2884 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2885 Without this fix, if a signal arrives just after memory fills up,
2886 'malloc' might be invoked reentrantly.
2887
476371c4
PE
2888 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2889 In other words, assume that every image size is allowed, on non-X
2890 hosts. This assumption is probably wrong, but it lets Emacs compile.
2891
f3fcc40d
AS
28922011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2893
2894 * regex.c (re_iswctype): Convert return values to boolean.
2895
350c992f
EZ
28962011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2897
2898 * xdisp.c (compute_display_string_pos): Don't use cached display
2899 string position if the buffer had its restriction changed.
2900 (Bug#9184)
2901
5266b4bb
PE
29022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2903
2904 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2905
2573a837 29062011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2907
41f55ccd 2908 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2909
39e378da
PE
2910 * bidi.c: Integer size and overflow fixes.
2911 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2912 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2913 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2914 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2915 (bidi_find_other_level_edge):
2916 Use ptrdiff_t instead of EMACS_INT where either will do.
2917 This works better on 32-bit hosts configured --with-wide-int.
2918 (bidi_cache_ensure_space): Check for size-calculation overflow.
2919 Use % rather than repeated addition, for better worst-case speed.
2920 Don't set bidi_cache_size until after xrealloc returns, because it
2921 might not return.
2922 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2923 (bidi_cache_ensure_space): Also check that the bidi cache size
2924 does not exceed that of the largest Lisp string or buffer. See Eli
2925 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2926
5e927815
PE
2927 * alloc.c (__malloc_size_t): Remove.
2928 All uses replaced by size_t. See Andreas Schwab's note
2929 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2930
ca4aa935
PE
2931 * image.c: Improve checking for integer overflow.
2932 (check_image_size): Assume that f is nonnull, since
2933 it is always nonnull in practice. This is one less thing to
2934 worry about when checking for integer overflow later.
2935 (x_check_image_size): New function, which checks for integer
2936 overflow issues inside X.
2937 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2938 This removes the need for a memory_full check.
2939 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2940 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2941 (xbm_read_bitmap_data): Change locals back to 'int', since
2942 their values must fit in 'int'.
2943 (xpm_load_image, png_load, tiff_load):
2944 Invoke x_create_x_image_and_pixmap earlier,
2945 to avoid much needless work if the image is too large.
2946 (tiff_load): Treat overly large images as if
2947 x_create_x_image_and_pixmap failed, not as malloc failures.
2948 (gs_load): Use x_check_image_size.
2949
5f8f9cc2
PE
2950 * gtkutil.c: Omit integer casts.
2951 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2952 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2953
5adf60bc
PE
2954 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2955
c8907a93
PE
2956 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2957 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2958 would wrongly return t on a 64-bit host.
2959
e3c25c68
PE
2960 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2961 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2962 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2963 and therefore cause GCC to emit a bogus diagnostic in some cases.
2964
3f791afe
PE
2965 * image.c: Integer signedness and overflow and related fixes.
2966 This is not an exhaustive set of fixes, but it's time to
2967 record what I've got.
2968 (lookup_pixel_color, check_image_size): Remove redundant decls.
2969 (check_image_size): Don't assume that arbitrary EMACS_INT values
2970 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2971 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2972 (tiff_load, imagemagick_load_image):
2973 Check for overflow in size calculations.
2974 (x_create_x_image_and_pixmap): Remove unnecessary test for
2975 xmalloc returning NULL; that can't happen.
2976 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2977 (xpm_color_bucket): Use better integer hashing function.
2978 (xpm_cache_color): Don't possibly over-allocate memory.
2979 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2980 (gif_memory_source):
2981 Use ptrdiff_t, not int or size_t, to record sizes.
2982 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2983 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2984 either works, as we prefer signed integers.
2985 (tiff_read_from_memory, tiff_write_from_memory):
2986 Return tsize_t, not size_t, since that's what the TIFF API wants.
2987 (tiff_read_from_memory): Don't fail simply because the read would
2988 go past EOF; instead, return a short read.
2989 (tiff_load): Omit no-longer-needed casts.
2990 (Fimagemagick_types): Don't assume size fits into 'int'.
2991
3cc5a532
PE
2992 Improve hashing quality when configured --with-wide-int.
2993 * fns.c (hash_string): New function, taken from sxhash_string.
2994 Do not discard information about ASCII character case; this
2995 discarding is no longer needed.
2996 (sxhash-string): Use it. Change sig to match it. Caller changed.
2997 * lisp.h: Declare it.
2998 * lread.c (hash_string): Remove, since we now use fns.c's version.
2999 The fns.c version returns a wider integer if --with-wide-int is
3000 specified, so this should help the quality of the hashing a bit.
3001
b312a492
PE
3002 * emacs.c: Integer overflow minor fix.
3003 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3004 Define only if GNU_LINUX.
3005 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3006
dfd153ae
PE
3007 * dispnew.c: Integer signedness and overflow fixes.
3008 Remove unnecessary forward decls, that were a maintenance hassle.
3009 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3010 All uses changed.
3011 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3012 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3013 (prepare_desired_row, line_draw_cost):
3014 Use int, not unsigned, where either works.
3015 (save_current_matrix, restore_current_matrix):
3016 Use ptrdiff_t, not size_t, where either works.
3017 (init_display): Check for overflow more accurately, and without
3018 relying on undefined behavior.
3019
a81d11a3
PE
3020 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3021 Remove, replacing with the new symbols in lisp.h. All uses changed.
3022 * fileio.c (make_temp_name):
3023 * filelock.c (lock_file_1, lock_file):
3024 * xdisp.c (message_dolog):
3025 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3026 Use pMd etc. instead.
3027 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3028 replacing the pWIDE etc. symbols removed from editfns.c.
3029
3300e6fd
PE
3030 * keyboard.h (num_input_events): Now uintmax_t.
3031 This is (very slightly) less likely to mess up due to wraparound.
3032 All uses changed.
3033
fd05c7e9
PE
3034 * buffer.c: Integer signedness fixes.
3035 (alloc_buffer_text, enlarge_buffer_text):
3036 Use ptrdiff_t rather than size_t when either will do, as we prefer
3037 signed integers.
3038
903fe15d
PE
3039 * alloc.c: Integer signedness and overflow fixes.
3040 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3041 (__malloc_size_t): Default to size_t, not to int.
3042 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3043 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3044 Prefer ptrdiff_t to size_t when either would do, as we prefer
3045 signed integers.
3046 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3047 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3048 Now const. Initialize with values that are in range even if char
3049 is signed.
3050 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3051 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3052 These functions do the right thing with sizes > 2**32.
3053 (check_depth): Now ptrdiff_t, not int.
3054 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3055 Adjust to new way of storing sizes. Check for size overflow bugs
3056 in rest of code.
3057 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3058 slightly wrong anyway, as it missed one instance of
3059 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3060 (refill_memory_reserve): Omit needless cast to size_t.
3061 (mark_object_loop_halt): Mark as externally visible.
3062
ac82cc6a
PE
3063 * xselect.c: Integer signedness and overflow fixes.
3064 (Fx_register_dnd_atom, x_handle_dnd_message):
3065 Use ptrdiff_t, not size_t, since we prefer signed.
3066 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3067 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3068 x_dnd_atoms_size and x_dnd_atoms_length.
3069
c2d1e36d
PE
3070 * doprnt.c: Prefer signed to unsigned when either works.
3071 * eval.c (verror):
3072 * doprnt.c (doprnt):
3073 * lisp.h (doprnt):
3074 * xdisp.c (vmessage):
3075 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3076 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3077 prefer signed arithmetic to avoid comparison confusion.
3078 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3079 but is a bit tricky.
3080
0e926e56
PE
3081 Assume freestanding C89 headers, string.h, stdlib.h.
3082 * data.c, doprnt.c, floatfns.c, print.c:
3083 Include float.h unconditionally.
3084 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3085 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3086 * regex.c: Likewise for stddef.h, string.h.
3087 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3088 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3089 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3090 (STDC_HEADERS): Remove obsolete defines.
3091 * sysdep.c: Include limits.h unconditionally.
3092
9cfdb3ec
PE
3093 Assume support for memcmp, memcpy, memmove, memset.
3094 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3095 * regex.c (memcmp, memcpy):
3096 Remove; we assume C89 now.
3097
3098 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3099 (__malloc_safe_bcopy): Remove; no longer needed.
3100
cf950e6b 3101 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3102 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3103 well either way, and we prefer signed to unsigned.
3104
dbf38e02
LMI
31052011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3106
3107 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3108 closes the connection while we're reading (bug#9182).
3109
d6f0886c 31102011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3111
d6f0886c
JD
3112 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3113 are specified (Bug#9168).
24e0f6b1 3114
2eb1f9e6
PE
31152011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3118 Found by GCC static checking and --with-wide-int on a 32-bit host.
3119
22381272 31202011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3121
3122 * xdisp.c (compute_display_string_pos): Fix logic of caching
3123 previous display string position. Initialize cached_prev_pos to
3124 -1. Fixes slow-down at the beginning of a buffer.
3125
f25e39b4
EZ
31262011-07-24 Eli Zaretskii <eliz@gnu.org>
3127
3128 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3129 for attrs[LFACE_FONTSET_INDEX].
3130
04c4b52e
PE
31312011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 * xml.c (parse_region): Remove unused local
3134 that was recently introduced.
3135
c1734fbd
EZ
31362011-07-23 Eli Zaretskii <eliz@gnu.org>
3137
be18c5a5
EZ
3138 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3139 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3140
c1734fbd
EZ
3141 * xdisp.c (move_it_in_display_line_to): Record the best matching
3142 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3143 exit if none of the characters scanned was an exact match.
3144 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3145 when exact match is impossible due to invisible text, and the
3146 lines are truncated.
3147
a258d627
JD
31482011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3149
3150 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3151 for OSX >= 10.7.
3152
b6d5a689
EZ
31532011-07-22 Eli Zaretskii <eliz@gnu.org>
3154
0f74f785
EZ
3155 Fix a significant slow-down of cursor motion with C-n, C-p,
3156 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3157 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3158 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3159 (next_element_from_buffer): Call compute_stop_pos_backwards to
3160 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3161 base_level_stop.
3162 (reseat): Don't look for prev_stop, as that could mean a very long
3163 run.
3164 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3165 <cached_disp_overlay_modiff>: Cache for last found display string
3166 position.
551918c1 3167 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3168 about the same buffer in the same area of character positions, and
3169 the buffer wasn't changed since the time the display string
3170 position was cached.
551918c1 3171
b2d0c91a
EZ
31722011-07-22 Eli Zaretskii <eliz@gnu.org>
3173
3174 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3175 is an integer, which is important for empty lines. (Bug#9149)
3176
043604ee
CY
31772011-07-22 Chong Yidong <cyd@stupidchicken.com>
3178
3179 * frame.c (Fmodify_frame_parameters): In tty case, update the
3180 default face if necessary (Bug#4238).
3181
da4adb04
CY
31822011-07-21 Chong Yidong <cyd@stupidchicken.com>
3183
3184 * editfns.c (Fstring_to_char): No need to explain what a character
3185 is in the docstring (Bug#6576).
3186
9abd0532
LMI
31872011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3188
3189 * xml.c (parse_region): Make sure we always return a tree.
3190
36881d16
HK
31912011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3192
3193 * xml.c (parse_region): If a document contains only comments,
3194 return that, too.
3195
1e98674d
LMI
31962011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3197
3198 * xml.c (make_dom): Return comments, too.
3199
590bd467
PE
32002011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3201
3202 Port to OpenBSD.
3203 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3204 and the surrounding thread.
3205 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3206 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3207 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3208 timer goes off.
3209 * s/openbsd.h (BROKEN_SIGIO): Define.
3210 * unexelf.c (unexec) [__OpenBSD__]:
3211 Don't update the .mdebug section of the Alpha COFF symbol table.
3212
f41628b2
LMI
32132011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3214
3215 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3216 (bug#8460).
3217
b59b67c5
PE
32182011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3219
15e3a074
PE
3220 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3221 This fixes some race conditions on the permissions of any newly
3222 created file.
3223
41bed37d
PE
3224 * alloc.c (valid_pointer_p): Use pipe, not open.
3225 This fixes some permissions issues when debugging.
3226
b59b67c5
PE
3227 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3228 If fchown fails to set both uid and gid, try to set just gid,
3229 as that is sometimes allowed. Adjust the file's mode to eliminate
3230 setuid or setgid bits that are inappropriate if fchown fails.
3231
925a6be7
SM
32322011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3233
3234 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3235 to compare Lisp_Objects.
3236 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3237 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3238 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3239
52968808
AS
32402011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3241
0a6a104b
AS
3242 * lread.c (read_integer): Unread even EOF character.
3243 (read1): Likewise. Properly record start position of symbol.
3244
52968808
AS
3245 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3246 symbol character follows.
3247
9e381cdd
PE
32482011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3249
3250 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3251 This works around a problem with the previous change to Fcopy_file.
3252 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3253 and without this change, GCC might complain about discarding
3254 fchown's return value.
3255
b5641435
JB
32562011-07-16 Juanma Barranquero <lekktu@gmail.com>
3257
3258 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3259
a8031457
PE
32602011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3261
3262 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3263
dd889327
LMI
32642011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3265
750c33f7
LMI
3266 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3267 it's used from the C level.
3268
dd889327
LMI
3269 * process.c: Use the same condition for POLL_FOR_INPUT in both
3270 keyboard.c and process.c (bug#1858).
3271
87e86684
LM
32722011-07-09 Lawrence Mitchell <wence@gmx.li>
3273
3274 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3275 (Fgnutls_boot): Use it.
3276
64348f40
AS
32772011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3278
3279 * doc.c (Fsubstitute_command_keys): Revert last change.
3280
1d698799
LMI
32812011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3282
f863868c
LMI
3283 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3284 quotes the next character, and doesn't affect other longer
3285 sequences (bug#8935).
3286
1d698799
LMI
3287 * lread.c (syms_of_lread): Clarify that is isn't only
3288 `eval-buffer' and `eval-defun' that's affected by
3289 `lexical-binding' (bug#8460).
3290
aa4b6df6
EZ
32912011-07-15 Eli Zaretskii <eliz@gnu.org>
3292
3293 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3294 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3295
5d856da6
PE
32962011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3297
ad6042bb
PE
3298 Fix minor problems found by static checking.
3299 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3300 (elsz): Now a signed constant, not a size_t var. We prefer signed
3301 types to unsigned, to avoid integer comparison confusion. Without
3302 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3303 "cannot optimize loop, the loop counter may overflow", a symptom
3304 of the confusion.
f00bbb22 3305 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3306 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3307
6468f31c
LMI
33082011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3309
49080b10
LMI
3310 * search.c (Fre_search_backward): Mention `case-fold-search' in
3311 all the re_search_* functions (bug#8138).
3312
6468f31c
LMI
3313 * keyboard.c (Fopen_dribble_file): Document when the file is
3314 closed (bug#8056).
3315
c965adc5
EZ
33162011-07-14 Eli Zaretskii <eliz@gnu.org>
3317
df9733bf
EZ
3318 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3319 bidi_cache_idx.
3320
0bb23927
EZ
3321 Support bidi reordering of display and overlay strings.
3322 * xdisp.c (compute_display_string_pos)
3323 (compute_display_string_end): Accept additional argument STRING.
3324 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3325 (reseat_to_string): Initialize bidi_it->string.s and
3326 bidi_it->string.schars.
3327 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3328 NULL (avoids a crash in bidi_paragraph_init).
3329 Initialize itb.string.lstring.
0bb23927
EZ
3330 (init_iterator): Call bidi_init_it only of a valid
3331 buffer position was specified. Initialize paragraph_embedding to
3332 L2R.
3333 (reseat_to_string): Initialize the bidi iterator.
3334 (display_string): If we need to ignore text properties of
3335 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3336 original value of -1 will not work with bidi.)
3337 (compute_display_string_pos): First arg is now struct
3338 `text_pos *'; all callers changed. Support display properties on
3339 Lisp strings.
3340 (compute_display_string_end): Support display properties on Lisp
3341 strings.
3342 (init_iterator, reseat_1, reseat_to_string): Initialize the
3343 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3344 when iterating on a string not from display properties).
640c8776
SM
3345 (compute_display_string_pos, compute_display_string_end):
3346 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3347 arrow keys.
3348 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3349 base_level_stop; instead, set base_level_stop to BEGV.
3350 Fixes crashes in vertical-motion.
0bb23927
EZ
3351 (next_element_from_buffer): Improve commentary for when
3352 the iterator is before prev_stop.
3353 (init_iterator): Initialize bidi_p from the default value of
3354 bidi-display-reordering, not from buffer-local value. Use the
3355 buffer-local value only if initializing for buffer iteration.
3356 (handle_invisible_prop): Support invisible properties on strings
3357 that are being bidi-reordered.
3358 (set_iterator_to_next): Support bidi reordering of C strings and
3359 Lisp strings.
3360 (next_element_from_string): Support bidi reordering of Lisp
3361 strings.
3362 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3363 (display_string): Support display of R2L glyph rows.
3364 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3365 (init_iterator): Don't initialize it->bidi_p for strings
3366 here.
3367 (reseat_to_string): Initialize it->bidi_p for strings here.
3368 (next_element_from_string, next_element_from_c_string)
3369 (next_element_from_buffer): Add xassert's for correspondence
3370 between IT's object being iterated and it->bidi_it.string
3371 structure.
3372 (face_before_or_after_it_pos): Support bidi iteration.
3373 (next_element_from_c_string): Handle the case of the first string
3374 character that is not the first one in the visual order.
3375 (get_visually_first_element): New function, refactored from common
3376 parts of next_element_from_buffer, next_element_from_string, and
3377 next_element_from_c_string.
3378 (tool_bar_lines_needed, redisplay_tool_bar)
3379 (display_menu_bar): Force left-to-right direction. Add a FIXME
3380 comment for making that be controlled by a user option.
3381 (push_it, pop_it): Save and restore the state of the
3382 bidi iterator. Save and restore the bidi_p flag.
3383 (pop_it): Iterate out of display property for string iteration as
3384 well.
3385 (iterate_out_of_display_property): Support iteration over strings.
3386 (handle_single_display_spec): Set up it->bidi_it for iteration
3387 over a display string, and call bidi_init_it.
3388 (handle_single_display_spec, next_overlay_string)
3389 (get_overlay_strings_1, push_display_prop): Set up the bidi
3390 iterator for displaying display or overlay strings.
3391 (forward_to_next_line_start): Don't use the shortcut if
3392 bidi-iterating.
3393 (back_to_previous_visible_line_start): If handle_display_prop
3394 pushed the iterator stack, restore the internal state of the bidi
3395 iterator by calling bidi_pop_it same number of times.
3396 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3397 and we are bidi-iterating, don't decrement the iterator position;
3398 instead, set the first_elt flag in the bidi iterator, to produce
3399 the same effect.
3400 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3401 (push_display_prop): xassert that we are iterating a buffer.
3402 (push_it, pop_it): Save and restore paragraph_embedding member.
3403 (handle_single_display_spec, next_overlay_string)
3404 (get_overlay_strings_1, reseat_1, reseat_to_string)
3405 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3406 correctly. Don't assume unibyte strings are not bidi-reordered.
3407 (compute_display_string_pos)
3408 (compute_display_string_end): Fix handling the case of C string.
3409 (push_it, pop_it): Save and restore from_disp_prop_p.
3410 (handle_single_display_spec, push_display_prop): Set the
3411 from_disp_prop_p flag.
3412 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3413 (pop_it): Call iterate_out_of_display_property only if we are
3414 popping after iteration over a string that came from a display
3415 property. Fix a typo in popping stretch info. Add an assertion
3416 for verifying that the iterator position is in sync with the bidi
3417 iterator.
3418 (handle_single_display_spec, get_overlay_strings_1)
3419 (push_display_prop): Fix initialization of paragraph direction for
3420 string when that of the parent object is not yet determined.
3421 (reseat_1): Call bidi_init_it to resync the bidi
3422 iterator with IT's position. (Bug#7616)
3423 (find_row_edges): If ROW->start.pos gives position
3424 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3425 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3426 Reset the from_disp_prop_p flag.
3427 (SAVE_IT, RESTORE_IT): New macros.
3428 (pos_visible_p, face_before_or_after_it_pos)
3429 (back_to_previous_visible_line_start)
3430 (move_it_in_display_line_to, move_it_in_display_line)
3431 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3432 (try_scrolling, redisplay_window, display_line): Use them when
3433 saving a temporary copy of the iterator and restoring it back.
3434 (back_to_previous_visible_line_start, reseat_1)
3435 (init_iterator): Empty the bidi cache "stack".
3436 (move_it_in_display_line_to): If iterator ended up at
3437 EOL, but we never saw any buffer positions smaller than
3438 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3439 motion in bidi-reordered lines.
3440 (move_it_in_display_line_to): Record prev_method and prev_pos
3441 immediately before the call to set_iterator_to_next. Fixes cursor
3442 motion in bidi-reordered lines with stretch glyphs and strings
3443 displayed in margins. (Bug#8133) (Bug#8867)
3444 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3445 TO_CHARPOS.
640c8776
SM
3446 (pos_visible_p): Support positions in bidi-reordered lines.
3447 Save and restore bidi cache.
0bb23927
EZ
3448
3449 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3450 (bidi_paragraph_info): Delete unused struct.
3451 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3452 (bidi_cache_start): New variable.
3453 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3454 to zero.
3455 (bidi_cache_fetch_state, bidi_cache_search)
3456 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3457 (bidi_cache_find, bidi_peek_at_next_level)
3458 (bidi_level_of_next_char, bidi_find_other_level_edge)
3459 (bidi_move_to_visually_next): Compare cache index with
3460 bidi_cache_start rather than with zero.
3461 (bidi_fetch_char): Accept new argument STRING; all callers
3462 changed. Support iteration over a string. Support strings with
3463 display properties. Support unibyte strings. Fix the type of
3464 `len' according to what STRING_CHAR_AND_LENGTH expects.
3465 (bidi_paragraph_init, bidi_resolve_explicit_1)
3466 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3467 (bidi_level_of_next_char, bidi_move_to_visually_next):
3468 Support iteration over a string.
0bb23927
EZ
3469 (bidi_set_sor_type, bidi_resolve_explicit_1)
3470 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3471 can now be zero (for strings); special values 0 and -1 were
3472 changed to -1 and -2, respectively.
3473 (bidi_char_at_pos): New function.
3474 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3475 Call it instead of FETCH_MULTIBYTE_CHAR.
3476 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3477 initialized to valid values.
3478 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3479 values.
3480 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3481 the test for valid cached positions. Fix the logic for looking up
3482 the sentinel state in the cache. GCPRO the Lisp string we are
3483 iterating.
3484 (bidi_push_it, bidi_pop_it): New functions.
3485 (bidi_initialize): Initialize the bidi cache start stack pointer.
3486 (bidi_cache_ensure_space): New function, refactored from part of
3487 bidi_cache_iterator_state. Don't assume the required size is just
3488 one BIDI_CACHE_CHUNK away.
3489 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3490 (bidi_count_bytes, bidi_char_at_pos): New functions.
3491 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3492 always valid if bidi_cache_idx is valid.
3493 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3494 is valid if it's going to be used.
3495 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3496 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3497 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3498 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3499 (bidi_find_other_level_edge, bidi_cache_start_stack):
3500 All variables related to cache indices are now EMACS_INT.
c965adc5 3501
0bb23927
EZ
3502 * dispextern.h (struct bidi_string_data): New structure.
3503 (struct bidi_it): New member `string'. Make flag members be 1-bit
3504 fields, and put them last in the struct.
640c8776
SM
3505 (compute_display_string_pos, compute_display_string_end):
3506 Update prototypes.
0bb23927
EZ
3507 (bidi_push_it, bidi_pop_it): Add prototypes.
3508 (struct iterator_stack_entry): New members bidi_p,
3509 paragraph_embedding, and from_disp_prop_p.
3510 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3511 (bidi_shelve_cache, bidi_unshelve_cache):
3512 Declare prototypes.
0bb23927
EZ
3513
3514 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3515 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3516 and vector-like objects.
3517
3518 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3519 cache around display iteration.
3520
3521 * window.c (Fwindow_end, window_scroll_pixel_based)
3522 (displayed_window_lines, Frecenter): Save and restore the bidi
3523 cache around display iteration.
3524
3bbd2265
LMI
35252011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3526
3527 * editfns.c (Fdelete_region): Clarify the use of the named
3528 parameters (bug#6788).
3529
adc47434
MR
35302011-07-14 Martin Rudalics <rudalics@gmx.at>
3531
3532 * indent.c (Fvertical_motion): Set and restore w->pointm when
3533 saving and restoring the window's buffer (Bug#9006).
3534
837c31f8
LMI
35352011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3536
3537 * editfns.c (Fstring_to_char): Clarify just what is returned
3538 (bug#6576). Text by Eli Zaretskii.
3539
ac389d0c
JB
35402011-07-13 Juanma Barranquero <lekktu@gmail.com>
3541
3542 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3543
0be0ce47
EZ
35442011-07-13 Eli Zaretskii <eliz@gnu.org>
3545
3546 * buffer.c (mmap_find): Fix a typo.
3547
cd18e7e3
JB
35482011-07-13 Johan Bockgård <bojohan@gnu.org>
3549
3550 Fix execution of x selection hooks.
3551 * xselect.c (Qx_lost_selection_functions)
3552 (Qx_sent_selection_functions): New vars.
3553 (syms_of_xselect): DEFSYM them.
3554 (x_handle_selection_request): Pass Qx_sent_selection_functions
3555 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3556 (x_handle_selection_clear,x_clear_frame_selections):
3557 Pass Qx_lost_selection_functions rather than
3558 Vx_lost_selection_functions to Frun_hook_with_args.
3559
47ea7f44
PE
35602011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3561
ac389d0c 3562 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3563 The old code sometimes used this field without initializing it.
3564
47ea7f44
PE
3565 * alloc.c (gc_sweep): Don't read past end of array.
3566 In theory, the old code could also have corrupted Emacs internals,
3567 though it'd be very unlikely.
3568
bc985c87
AS
35692011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3570
3571 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3572 argument. (Bug#4026)
bc985c87 3573
0cf34688
LMI
35742011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3575
b3dadd76
LMI
3576 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3577 key" (bug#4257).
3578
0cf34688
LMI
3579 * window.c (Fset_window_start): Doc fix (bug#4199).
3580 (Fset_window_hscroll): Ditto.
3581
270768cd
PE
35822011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3583
077e3dda 3584 Fix minor new problems caught by GCC 4.6.1.
270768cd 3585 * term.c (init_tty): Remove unused local.
490011a6 3586 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3587 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3588 not used otherwise.
270768cd 3589
b1f58454
CY
35902011-07-12 Chong Yidong <cyd@stupidchicken.com>
3591
3592 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3593
22b9578d
LMI
35942011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3595
6e70ab07
LMI
3596 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3597 are the mini-buffer and the echo area (bug#3320).
3598
22b9578d
LMI
3599 * term.c (init_tty): Remove support for supdup, c10 and perq
3600 terminals, which are no longer supported (bug#1482).
3601
8974cc9f
JB
36022011-07-10 Johan Bockgård <bojohan@gnu.org>
3603
3604 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3605
a560d974
JD
36062011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3607
3608 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3609 for non-popups (Bug#3642).
3610
1dae0f0a
AS
36112011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3612
268c2c36 3613 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3614 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3615 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3616 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3617 * data.c (fmod): Likewise.
3618 * dispnew.c (swap_glyphs_in_rows): Likewise.
3619 * emacs.c (memory_warning_signal): Likewise.
3620 * floatfns.c (float_error): Likewise.
3621 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3622 (otf_open, font_otf_capability, generate_otf_features)
3623 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3624 Likewise.
3625 * image.c (pbm_read_file): Likewise.
3626 * indent.c (string_display_width): Likewise.
3627 * intervals.c (check_for_interval, search_for_interval)
3628 (inc_interval_count, count_intervals, root_interval)
3629 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3630 * lread.c (defalias): Likewise.
268c2c36 3631 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3632 * regex.c (set_image_of_range_1, set_image_of_range)
3633 (regex_grow_registers): Likewise.
3634 * sysdep.c (strerror): Likewise.
3635 * termcap.c (valid_filename_p, tprint, main): Likewise.
3636 * tparam.c (main): Likewise.
3637 * unexhp9k800.c (run_time_remap, save_data_space)
3638 (update_file_ptrs, read_header, write_header, calculate_checksum)
3639 (copy_file, copy_rest, display_header): Likewise.
3640 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3641 Likewise.
3642 * xdisp.c (check_it): Likewise.
3643 * xfaces.c (register_color, unregister_color, unregister_colors):
3644 Likewise.
3645 * xfns.c (print_fontset_result): Likewise.
3646 * xrdb.c (member, fatal, main): Likewise.
3647
99033785
PE
36482011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3649
3650 Fix minor problems found by static checking (Bug#9031).
3651 * chartab.c (char_table_set_range, map_sub_char_table):
3652 Remove unused locals.
3653 (uniprop_table): Now static.
3654 * composite.c (_work_char): Remove unused static var.
3655
9cb2ac56
JB
36562011-07-09 Juanma Barranquero <lekktu@gmail.com>
3657
3658 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3659
f25661f0
JD
36602011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3661
3662 * gtkutil.c (qttip_cb): Remove code without function.
3663
8278c4fe
EZ
36642011-07-09 Eli Zaretskii <eliz@gnu.org>
3665
3666 * w32.c (pthread_sigmask): New stub.
3667
1692ae2d 36682011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3669
8a6ebd58 3670 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3671 sigprocmask is portable only for single-threaded applications, and
3672 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3673 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3674 (LIBES): Use it.
3675 * callproc.c (Fcall_process):
3676 * process.c (create_process):
3677 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3678 Use pthread_sigmask, not sigprocmask.
123403e4 3679
1b854618
JD
36802011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3681
3682 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3683 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3684 wrong (Bug#8591).
3685
3fe4b549
JD
36862011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3687
0ce7e563
JD
3688 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3689 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3690 (xg_hide_tooltip): Fix comment.
3691
3fe4b549
JD
3692 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3693 in registerServicesMenuSendTypes.
3694 (validRequestorForSendType): Don't check ns_return_types.
3695
3696 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3697 ns_return_type.
3698
5df75e47
JR
36992011-07-08 Jason Rumney <jasonr@gnu.org>
3700
22610910
JR
3701 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3702 SH_SHOW for hidden windows (Bug#5482).
3703
5df75e47
JR
3704 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3705 frame struct members of non-existent frames (Bug#6284).
3706
699c10bd
JD
37072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3708
4393663b
JD
3709 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3710 variable firstTime not needed on OSX >= 10.6.
3711 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3712 >= 10.5. Use setKnobProportion, setDoubleValue.
3713
3714 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3715 (MAC_OS_X_VERSION_10_5): Define if not defined.
3716 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3717 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3718 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3719
3720 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3721 cString and lossyCString on OSX >= 10.4
3722
58179cce 3723 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3724 sizeToFit on OSX >= 10.2.
3725
3726 * nsimage.m (allocInitFromFile): Don't use deprecated method
3727 bestRepresentationForDevice on OSX >= 10.6.
3728
3729 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3730 to avoid warning.
3731
3732 * emacs.c: Declare unexec_init_emacs_zone.
3733
a63e0781
JD
3734 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3735
699c10bd
JD
3736 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3737
3738 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3739 on svcsMenu (Bug#8842).
3740
3741 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3742 ns_return_types.
3743 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3744
3745 * nsterm.m (QUTF8_STRING): Declare.
3746 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3747 (validRequestorForSendType): Return type is (id).
3748 Change indexOfObjectIdenticalTo to indexOfObject.
3749 Check if we have local selection before returning self (Bug#8842).
3750 (writeSelectionToPasteboard): Put local selection into paste board
3751 if we have a local selection (Bug#8842).
3752 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3753
3754 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3755 (ns_get_local_selection): Declare.
3756
54e10184
LMI
37572011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3758
9888ff71
LMI
3759 * keymap.c (describe_map_tree): Don't insert a double newline at
3760 the end of the buffer (bug#1169) and return whether we inserted
3761 something.
3762
54e10184
LMI
3763 * callint.c (Fcall_interactively): Change "reading args" to
3764 "providing args" to try to clarify what it does (bug#1010).
3765
15fa4783
KH
37662011-07-07 Kenichi Handa <handa@m17n.org>
3767
3768 * composite.c (composition_compute_stop_pos): Ignore a static
3769 composition starting before CHARPOS (Bug#8915).
3770
3771 * xdisp.c (handle_composition_prop): Likewise.
3772
a8815b00
EZ
37732011-07-07 Eli Zaretskii <eliz@gnu.org>
3774
3775 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3776 (Bug#9015)
3777
ef7b981d 37782011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3779
3780 * character.h (unicode_category_t): New enum type.
3781
3782 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3783 (Qchar_code_property_table): New variable.
3784 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3785 (UNIPROP_COMPRESSED_FORM_P): New macros.
3786 (char_table_ascii): Uncompress the compressed values.
3787 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3788 Uncompress the compressed values.
ac389d0c 3789 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3790 (char_table_ref_and_range): Uncompress the compressed values.
3791 (sub_char_table_set): New arg is_uniprop. Callers changed.
3792 Uncompress the compressed values.
3793 (sub_char_table_set_range): Args changed. Callers changed.
3794 (char_table_set_range): Adjuted for the above change.
3795 (map_sub_char_table): Delete args default_val and parent. Add arg
3796 top. Give decoded values to a Lisp function.
640c8776 3797 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3798 values to a Lisp function. Gcpro more variables.
3799 (uniprop_table_uncompress)
3800 (uniprop_decode_value_run_length): New functions.
3801 (uniprop_decoder, uniprop_decoder_count): New variables.
3802 (uniprop_get_decoder, uniprop_encode_value_character)
3803 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3804 New functions.
3805 (uniprop_encoder, uniprop_encoder_count): New variables.
3806 (uniprop_get_encoder, uniprop_table)
3807 (Funicode_property_table_internal, Fget_unicode_property_internal)
3808 (Fput_unicode_property_internal): New functions.
3809 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3810 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3811 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3812 char-code-property-alist.
3813
640c8776 3814 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3815 Vunicode_category_table.
3816
640c8776 3817 * font.c (font_range): Adjust for the change of
c805dec0
KH
3818 Vunicode_category_table.
3819
76b397fb
DN
38202011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3821
3822 * m/iris4d.h: Remove file, move contents ...
3823 * s/irix6-5.h: ... here.
3824
22b4128e
PE
38252011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3826
3827 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3828 * alloc.c (mark_buffer):
3829 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3830 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3831 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3832 This isn't true in general, and it's particularly not true
3833 if Emacs is configured with --with-wide-int.
3834 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3835 New macros, used in the buffer.c change.
3836
869795d6
JD
38372011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3838
3839 * xsettings.c: Use both GConf and GSettings if both are available.
3840 (store_config_changed_event): Add comment.
3841 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3842 (store_tool_bar_style_changed): New functions.
5e617bc2 3843 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3844 (struct xsettings): Move font inside HAVE_XFT.
3845 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3846 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3847 Move inside HAVE_XFT.
640c8776 3848 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3849 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3850 also.
3851 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3852 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3853 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3854 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3855 (parse_settings): Move check for font inside HAVE_XFT.
3856 (read_settings, apply_xft_settings): Add comment.
3857 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3858 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3859 call store_font_name_changed.
3860 (xft_settings_event): Add comment.
3861 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3862 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3863 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3864 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3865 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3866 (xsettings_get_system_font, xsettings_get_system_normal_font):
3867 Add comment.
869795d6 3868
d8ed26bd
PE
38692011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3870
3871 Random fixes. E.g., (random) never returned negative values.
3872 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3873 subseconds part to the entropy, as that's a bit more random.
3874 Prefer signed to unsigned, since the signedness doesn't matter and
3875 in general we prefer signed. When given a limit, use a
3876 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3877 latter isn't right if USE_2_TAGS_FOR_INTS.
3878 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3879 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3880
cabf1cac
SM
38812011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3882
3883 * textprop.c (text_property_stickiness):
3884 Obey Vtext_property_default_nonsticky.
3885 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3886 * w32fns.c (syms_of_w32fns):
3887 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3888
6e9b2be9
PE
38892011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3890
3891 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3892 This is more efficient than Ffile_directory_p and avoids a minor race.
3893
90186c68
LMI
38942011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3895
7c301272
LMI
3896 * buffer.c (Foverlay_put): Say what the return value is
3897 (bug#7835).
3898
c4f2d8d4
LMI
3899 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3900 is a directory before asking whether to use the file name
3901 (bug#7564).
ad637907
LMI
3902 (barf_or_query_if_file_exists): Make the "File is a directory"
3903 error be more correct.
c4f2d8d4 3904
90186c68
LMI
3905 * fns.c (Frequire): Remove the mention of the .gz files, since
3906 that's installation-specific, but keep the mention of
3907 `get-load-suffixes'.
3908
da64016e
PE
39092011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3910
3911 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3912 Report string overflow if the output is too long.
3913
7d47b580
JB
39142011-07-04 Juanma Barranquero <lekktu@gmail.com>
3915
a555cb87
JB
3916 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3917 (syms_of_gnutls): Remove duplicate DEFSYM for
3918 Qgnutls_bootprop_verify_hostname_error, an error for
3919 Qgnutls_bootprop_verify_error (which is no longer used).
3920
7d47b580
JB
3921 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3922 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3923 Also (re)move comments that are misplaced or no longer relevant.
3924
1e49bfab
LMI
39252011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3926
3927 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3928
1485f4c0
CY
39292011-07-03 Chong Yidong <cyd@stupidchicken.com>
3930
3931 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3932 and background color parameters if they have been changed.
3933
a9ab721e
LMI
39342011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3935
3936 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3937
cf7cff57
PE
39382011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3939
2e13213d
PE
3940 * xsettings.c (SYSTEM_FONT): Define only when used.
3941 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3942
cf7cff57
PE
3943 * keymap.c (access_keymap_1): Now static.
3944
7a8e04f7
CY
39452011-07-02 Chong Yidong <cyd@stupidchicken.com>
3946
3947 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3948 leave any prefix arg for the up event (Bug#1586).
3949
61352f62
LMI
39502011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3951
69bb1ef7
LMI
3952 * lread.c (syms_of_lread): Mention single symbols defined by
3953 `defvar' or `defconst' (bug#7154).
3954
61352f62 3955 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3956 (Frequire): Mention get-load-suffixes.
61352f62 3957
28545e04
MR
39582011-07-02 Martin Rudalics <rudalics@gmx.at>
3959
3960 * window.h (window): Remove clone_number slot.
3961 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3962 Remove.
3963 (make_parent_window, make_window, saved_window)
3964 (Fset_window_configuration, save_window_save): Don't deal with
3965 clone numbers.
3966 * buffer.c (Qclone_number): Remove declaration.
3967 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3968
3349e122
SM
39692011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3970
3971 Add multiple inheritance to keymaps.
3972 * keymap.c (Fmake_composed_keymap): New function.
3973 (Fset_keymap_parent): Simplify.
3974 (fix_submap_inheritance): Remove.
3975 (access_keymap_1): New function extracted from access_keymap to handle
3976 embedded parents and handle lists of maps.
3977 (access_keymap): Use it.
3978 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3979 (Fcopy_keymap): Handle embedded parents.
3980 (Fcommand_remapping, define_as_prefix): Simplify.
3981 (Fkey_binding): Simplify.
3982 (syms_of_keymap): Move minibuffer-local-completion-map,
3983 minibuffer-local-filename-completion-map,
3984 minibuffer-local-must-match-map, and
3985 minibuffer-local-filename-must-match-map to Elisp.
3986 (syms_of_keymap): Defsubr make-composed-keymap.
3987 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3988 (parse_menu_item): Trivial simplification.
3989
3279eb87
GM
39902011-07-01 Glenn Morris <rgm@gnu.org>
3991
3992 * Makefile.in (SETTINGS_LIBS): Fix typo.
3993
4550efdf
KI
39942011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3995
3996 * coding.c (Fencode_coding_string): Record the last coding system
3997 used, as the function doc string says (bug#8738).
3998
0949d2b6
JD
39992011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4000
4001 * xsettings.c (store_monospaced_changed): Take new font as arg and
4002 check for change against current_mono_font.
4003 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4004 (emacs_settings_constructor, emacs_settings_get_property)
4005 (emacs_settings_set_property, emacs_settings_class_init)
4006 (emacs_settings_init, gsettings_obj): Remove.
4007 (something_changedCB): New function for HAVE_GSETTINGS.
4008 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4009 with value as argument.
4010 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4011 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4012 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4013 "changed".
4014
4015 * xgselect.c: Add defined (HAVE_GSETTINGS).
4016 (xgselect_initialize): Ditto.
4017
4018 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4019 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4020 xg_select.
4021
bbc6b304
PE
40222011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4023
4024 * eval.c (struct backtrace): Simplify and port the data structure.
4025 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4026 signed bit field, as this assumption is not portable and it makes
4027 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4028 "char debug_on_exit : 1" as this is not portable either; instead,
4029 use the portable "unsigned int debug_on_exit : 1". Remove unused
4030 member evalargs. Remove obsolete comments about cc bombing out.
4031
9851bfc5
JD
40322011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4033
51bb811f 4034 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4035 Let HAVE_GSETTINGS override HAVE_GCONF.
4036 (store_monospaced_changed): New function.
4037 (EMACS_SETTINGS): A new type derived from GObject to handle
4038 GSettings notifications.
4039 (emacs_settings_constructor, emacs_settings_get_property)
4040 (emacs_settings_set_property, emacs_settings_class_init):
4041 New functions.
4042 (gsettings_client, gsettings_obj): New variables.
4043 (GSETTINGS_SCHEMA): New define.
4044 (something_changedCB): Call store_monospaced_changed.
4045 (init_gsettings): New function.
4046 (xsettings_initialize): Call init_gsettings.
4047 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4048 to NULL.
4049
640c8776 4050 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4051 GCONF_CFLAGS/LIBS.
4052
5386012d
MR
40532011-06-29 Martin Rudalics <rudalics@gmx.at>
4054
4055 * window.c (resize_root_window, grow_mini_window)
4056 (shrink_mini_window): Rename Qresize_root_window to
4057 Qwindow_resize_root_window and Qresize_root_window_vertically to
4058 Qwindow_resize_root_window_vertically.
4059
f13e0b08
PE
40602011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4061
4062 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4063
94515237
JB
40642011-06-27 Juanma Barranquero <lekktu@gmail.com>
4065
4066 * makefile.w32-in: Redesign dependencies so they reflect more
4067 clearly which files are directly included by each source file,
4068 and not through other includes.
4069
e43b6e43
MR
40702011-06-27 Martin Rudalics <rudalics@gmx.at>
4071
4072 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4073 (sort_overlays, overlay_strings): When an overlay's clone number
4074 matches the window's clone number process the overlay even if
4075 the overlay's window property doesn't match the current window.
4076
d68443dc
MR
4077 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4078 (Fwindow_hchild): Rename to Fwindow_left_child.
4079 (Fwindow_next): Rename to Fwindow_next_sibling.
4080 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4081 (resize_window_check): Rename to window_resize_check.
4082 (resize_window_apply): Rename to window_resize_apply.
4083 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4084 (Fdelete_other_windows_internal, resize_frame_windows)
4085 (Fsplit_window_internal, Fdelete_window_internal)
4086 (grow_mini_window, shrink_mini_window)
4087 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4088
c7e73be5
JD
40892011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4090
4091 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4092 (emacs_fixed_set_min_size): Remove.
4093 (emacs_fixed_new): Take frame as argument.
4094
4095 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4096 (_EmacsFixedPrivate): Remove minwidth/height.
4097 Add struct frame *f.
4098 (emacs_fixed_init): Initialize priv->f.
4099 (get_parent_class, emacs_fixed_set_min_size): Remove.
4100 (emacs_fixed_new): Set priv->f to argument.
4101 (emacs_fixed_get_preferred_width)
4102 (emacs_fixed_get_preferred_height): Use min_width/height from
4103 frames size_hint to set minimum and natural (Bug#8919).
4104 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4105 and use min_width/height from frames size_hint to set
4106 min_width/height (Bug#8919).
4107
4108 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4109 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4110 Fix indentation.
c7e73be5 4111
cf99dcf8
EZ
41122011-06-26 Eli Zaretskii <eliz@gnu.org>
4113
4114 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4115 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4116 called at ZV.
4117
029529ac
CY
41182011-06-26 Chong Yidong <cyd@stupidchicken.com>
4119
4120 * process.c (wait_reading_process_output): Bypass select if
4121 waiting for a cell while ignoring keyboard input, and input is
4122 pending. Suggested by Jan Djärv (Bug#8869).
4123
7a7ef429
PE
41242011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4125
4126 Use gnulib's dup2 module instead of rolling our own.
4127 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4128
11fdef7d 41292011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4130
4131 * dispnew.c (scrolling_window): Before scrolling, turn off a
4132 mouse-highlight in the window being scrolled.
4133
cd3520a4
JB
41342011-06-24 Juanma Barranquero <lekktu@gmail.com>
4135
4136 Move DEFSYM to lisp.h and use everywhere.
4137
4138 * character.h (DEFSYM): Move declaration...
4139 * lisp.h (DEFSYM): ...here.
4140
4141 * gnutls.c:
4142 * minibuf.c:
4143 * w32menu.c:
4144 * w32proc.c:
4145 * w32select.c: Don't include character.h.
4146
4147 * alloc.c (syms_of_alloc):
4148 * buffer.c (syms_of_buffer):
4149 * bytecode.c (syms_of_bytecode):
4150 * callint.c (syms_of_callint):
4151 * casefiddle.c (syms_of_casefiddle):
4152 * casetab.c (init_casetab_once):
4153 * category.c (init_category_once, syms_of_category):
4154 * ccl.c (syms_of_ccl):
4155 * cmds.c (syms_of_cmds):
4156 * composite.c (syms_of_composite):
4157 * dbusbind.c (syms_of_dbusbind):
4158 * dired.c (syms_of_dired):
4159 * dispnew.c (syms_of_display):
4160 * doc.c (syms_of_doc):
4161 * editfns.c (syms_of_editfns):
4162 * emacs.c (syms_of_emacs):
4163 * eval.c (syms_of_eval):
4164 * fileio.c (syms_of_fileio):
4165 * fns.c (syms_of_fns):
4166 * frame.c (syms_of_frame):
4167 * fringe.c (syms_of_fringe):
4168 * insdel.c (syms_of_insdel):
4169 * keymap.c (syms_of_keymap):
4170 * lread.c (init_obarray, syms_of_lread):
4171 * macros.c (syms_of_macros):
4172 * msdos.c (syms_of_msdos):
4173 * print.c (syms_of_print):
4174 * process.c (syms_of_process):
4175 * search.c (syms_of_search):
4176 * sound.c (syms_of_sound):
4177 * syntax.c (init_syntax_once, syms_of_syntax):
4178 * terminal.c (syms_of_terminal):
4179 * textprop.c (syms_of_textprop):
4180 * undo.c (syms_of_undo):
4181 * w32.c (globals_of_w32):
4182 * window.c (syms_of_window):
4183 * xdisp.c (syms_of_xdisp):
4184 * xfaces.c (syms_of_xfaces):
4185 * xfns.c (syms_of_xfns):
4186 * xmenu.c (syms_of_xmenu):
4187 * xsettings.c (syms_of_xsettings):
4188 * xterm.c (syms_of_xterm): Use DEFSYM.
4189
4228cf16
TZ
41902011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4191
cd3520a4 4192 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4193
7fcccf1e
PE
41942011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4195
7efb4e0e
PE
4196 Integer and buffer overflow fixes (Bug#8873).
4197
ff5844ad
PE
4198 * print.c (printchar, strout): Check for string overflow.
4199 (PRINTPREPARE, printchar, strout):
4200 Don't set size unless allocation succeeds.
4201
90532f02
PE
4202 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4203 for sizes. Check for string overflow more accurately.
4204 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4205
6d84508d
PE
4206 * macros.c: Integer and buffer overflow fixes.
4207 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4208 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4209 Use ptrdiff_t, not int, for sizes.
4210 Don't increment bufsize until after realloc succeeds.
4211 Check for size-calculation overflow.
4212 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4213
437b2cb4
PE
4214 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4215
8b9ac8b4
PE
4216 * lread.c: Integer overflow fixes.
4217 (read_integer): Radix is now EMACS_INT, not int,
4218 to improve quality of diagnostics for out-of-range radices.
4219 Calculate buffer size correctly for out-of-range radices.
4220 (read1): Check for integer overflow in radices, and in
4221 read-circle numbers.
82cb60d3
PE
4222 (read_escape): Avoid int overflow.
4223 (Fload, openp, read_buffer_size, read1)
4224 (substitute_object_recurse, read_vector, read_list, map_obarray):
4225 Use ptrdiff_t, not int, for sizes.
4226 (read1): Use EMACS_INT, not int, for sizes.
20270765 4227 Check for size overflow.
8b9ac8b4 4228
7fcccf1e
PE
4229 * image.c (cache_image): Check for size arithmetic overflow.
4230
bfbbd7e7
PE
4231 * lread.c: Integer overflow issues.
4232 (saved_doc_string_size, saved_doc_string_length)
4233 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4234 Now ptrdiff_t, not int.
4235 (read1): Don't assume doc string length fits in int. Check for
4236 out-of-range doc string lengths.
4237 (read_list): Don't assume file position fits in int.
39019e54 4238 (read_escape): Check for hex character overflow.
bfbbd7e7 4239
4e323265
LL
42402011-06-22 Leo Liu <sdl.web@gmail.com>
4241
4242 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4243 Move to minibuffer.el.
4244
85fece3e
PE
42452011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4246
20b84ce9 4247 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4248 The following patches are for when GLYPH_DEBUG && !XASSERT.
4249 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4250 * dispnew.c (flush_stdout):
4251 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4252 Mark as externally visible.
4253 * dispnew.c (check_window_matrix_pointers): Now static.
4254 * dispnew.c (window_to_frame_vpos):
4255 * xfns.c (unwind_create_frame):
4256 * xterm.c (x_check_font): Remove unused local.
4257 * scroll.c (CHECK_BOUNDS):
4258 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4259 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4260 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4261 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4262 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4263 Now static.
4264 (debug_method_add): Use va_list and vsprintf rather than relying
4265 on undefined behavior with wrong number of arguments.
4266 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4267 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4268 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4269 since we're not interested in debugging glyphs with old libraries.
4270 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4271 GCC 4.6.0's static checking.
4272
0766b489
PE
42732011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4274
31fd4b32
PE
4275 Integer overflow and signedness fixes (Bug#8873).
4276 A few related buffer overrun fixes, too.
4277
b79e8648
PE
4278 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4279
0766b489
PE
4280 * dispextern.h (struct face.stipple):
4281 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4282 (x_bitmap_mask, x_allocate_bitmap_record)
4283 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4284 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4285 (x_create_bitmap_from_xpm_data):
4286 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4287 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4288 (.bitmaps_last):
4289 * xfaces.c (load_pixmap):
4290 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4291 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4292 (.bitmaps_last, struct x_output.icon_bitmap):
4293 Use ptrdiff_t, not int, for bitmap indexes.
4294 (x_allocate_bitmap_record): Check for size overflow.
4295 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4296
b081724f
PE
4297 Use ptrdiff_t, not int, for overlay counts.
4298 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4299 * editfns.c (overlays_around, get_pos_property):
4300 * textprop.c (get_char_property_and_overlay):
4301 * xdisp.c (next_overlay_change, note_mouse_highlight):
4302 * xfaces.c (face_at_buffer_position):
21514da7
PE
4303 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4304 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4305 (Fnext_overlay_change, Fprevious_overlay_change)
4306 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4307 Use ptrdiff_t, not int, for sizes.
21514da7 4308 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4309
3de73e5e
PE
4310 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4311
2606c57b
PE
4312 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4313 (x_session_initialize): Do not assume string length fits in int.
4314
aaafe47a
PE
4315 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4316 This is unlikely, but can occur if DPI is outlandish.
4317
2674ddc8 4318 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4319 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4320
28154962
PE
4321 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4322 * xrdb.c (magic_file_p, search_magic_path):
4323 Omit last arg SUFFIX; it was always 0. All callers changed.
4324 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4325
7de51af5
PE
4326 * xfont.c (xfont_match): Avoid need for strlen.
4327
25ed6cc3
PE
4328 * xfns.c: Don't assume strlen fits in int.
4329 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4330
4eab31dd
PE
4331 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4332 not unsigned long, as we prefer signed integers. All callers changed.
4333 Detect integer overflow in repeat count.
4334 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4335 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4336
171e2a58
PE
4337 * termcap.c: Don't assume sizes fit in int and never overflow.
4338 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4339 (gobble_line): Check for size-calculation overflow.
4340
ad39faca 4341 * minibuf.c (Fread_buffer):
6e5bb2dc 4342 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4343 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4344 Don't assume string length fits in int.
4345
52c61c22 4346 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4347 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4348
b5b8c9e5
PE
4349 * font.c: Don't assume string length fits in int.
4350 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4351 Use ptrdiff_t, not int.
ccd6111c
PE
4352 (font_intern_prop): Don't assume string length fits in int.
4353 Don't assume integer property fits in fixnum.
4354 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4355
882f0d81 4356 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4357 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4358 Reformulate so as not to need the command string.
4359 Invoke gzip -cd rather than gunzip, as it's more portable.
4360 (lock_info_type, lock_file_1, lock_file):
4361 Don't assume pid_t and time_t fit in unsigned long.
4362 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4363 (current_lock_owner): Prefer signed type for sizes.
4364 Use memcpy, not strncpy, where memcpy is what is really wanted.
4365 Don't assume (via atoi) that time_t and pid_t fit in int.
4366 Check for time_t and/or pid_t out of range, e.g., via a network share.
4367 Don't alloca where an auto var works fine.
4368
93f4cf88
PE
4369 * fileio.c: Fix some integer overflow issues.
4370 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4371 Don't assume string length fits in int.
4372 (directory_file_name): Don't assume string length fits in long.
4373 (make_temp_name): Don't assume pid fits in int, or that its print
4374 length is less than 20.
4375
f3e92b69
PE
4376 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4377
1bfdaf10
PE
4378 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4379
35016e9a
PE
4380 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4381
3d1e65a1
PE
4382 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4383 We prefer signed integers, even for size calculations.
4384
0b963a93
PE
4385 * emacs.c: Don't assume string length fits in 'int'.
4386 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4387 (main): Don't invoke strlen when not needed.
4388
573f4b54
PE
4389 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4390 (XD_DEBUG_MESSAGE): Don't waste a byte.
4391
989f33ba
PE
4392 * callproc.c (getenv_internal_1, getenv_internal)
4393 (Fgetenv_internal):
965d34eb
PE
4394 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4395
e4d29b33
PE
4396 * lread.c (invalid_syntax): Omit length argument.
4397 All uses changed. This doesn't fix a bug, but it simplifies the
4398 code away from its former Hollerith-constant appearance, and it's
4399 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4400 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4401
eb49b136
PE
4402 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4403 This didn't break anything, but it didn't help either.
4404 It's confusing to put a bogus integer in a place where the actual
4405 value does not matter.
9f62aeb1 4406 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4407 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4408
15375a22
PE
4409 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4410 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4411 implementation.
b61cc01c
PE
4412 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4413 We prefer signed types, and the value cannot exceed the EMACS_INT
4414 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4415 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4416 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4417 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4418
53b2623d
PE
4419 * indent.c (sane_tab_width): New function.
4420 (current_column, scan_for_column, Findent_to, position_indentation)
4421 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4422 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4423
51cab52b 4424 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4425
f2ed8a70
PE
4426 * lisp.h (lint_assume): New macro.
4427 * composite.c (composition_gstring_put_cache):
4428 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4429
abe80cc6
PE
4430 * editfns.c, insdel.c:
4431 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4432
b02c740e
PE
4433 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4434
ebc96716
PE
4435 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4436
b4e50fa0 4437 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4438 Use much-faster test for byte-length change.
311d5d7c 4439 Don't assume string byte-length fits in 'int'.
a4cf38e4 4440 Check that character arg fits in 'int'.
85461888 4441 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4442
c0c1ee9f
PE
4443 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4444
a498d7f4
PE
4445 * fns.c (concat): Catch string overflow earlier.
4446 Do not rely on integer wraparound.
4447
51cab52b
PE
4448 * dispextern.h (struct it.overlay_strings_charpos)
4449 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4450 * xdisp.c (forward_to_next_line_start)
4451 (back_to_previous_visible_line_start)
4452 (reseat_at_next_visible_line_start, next_element_from_buffer):
4453 Don't arbitrarily truncate the value of 'selective' to int.
4454
76031fad
PE
4455 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4456
5eb55db9
PE
4457 * composite.c: Don't truncate sizes to 'int'.
4458 (composition_gstring_p, composition_reseat_it)
4459 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4460 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4461 not EMACS_UINT, for indexes.
5eb55db9 4462
0703a717
PE
4463 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4464
d6202519
PE
4465 * buffer.c: Include <verify.h>.
4466 (struct sortvec.priority, struct sortstr.priority):
8961a454 4467 Now EMACS_INT, not int.
c20998a7 4468 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4469 (struct sortstr.size, record_overlay_string)
4470 (struct sortstrlist.size, struct sortlist.used):
4471 Don't truncate size to int.
4472 (record_overlay_string): Check for size-calculation overflow.
d6202519 4473 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4474
d5a19415
JM
44752011-06-22 Jim Meyering <meyering@redhat.com>
4476
029529ac 4477 Don't leak an XBM-image-sized buffer
d5a19415
JM
4478 * image.c (xbm_load): Free the image buffer after using it.
4479
a9041e6c
PE
44802011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4481
4482 Port to Sun C.
4483 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4484 that Sun C diagnosed.
4485 * fns.c (secure_hash): Fix pointer signedness issue.
4486 * intervals.c (static_offset_intervals): New function.
4487 (offset_intervals): Use it.
4488
7f3f739f
LL
44892011-06-21 Leo Liu <sdl.web@gmail.com>
4490
4491 * deps.mk (fns.o):
4492 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4493 sha512.h.
4494
4495 * fns.c (secure_hash): Rename from crypto_hash_function and change
4496 the first arg to accept symbols.
5b66d427 4497 (Fsecure_hash): New primitive.
7f3f739f
LL
4498 (syms_of_fns): New symbols.
4499
76147d94
DD
45002011-06-20 Deniz Dogan <deniz@dogan.se>
4501
4502 * process.c (Fset_process_buffer): Clarify return value in
4503 docstring.
4504
7d7d0045
CY
45052011-06-18 Chong Yidong <cyd@stupidchicken.com>
4506
4507 * dispnew.c (add_window_display_history): Use BVAR.
4508
4509 * xdisp.c (debug_method_add): Use BVAR.
4510 (check_window_end, dump_glyph_matrix, dump_glyph)
4511 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4512
4513 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4514 Likewise.
4515
4516 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4517 check till after the cache is created in init_frame_faces.
4518
ff2bc410
SM
45192011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4520
4521 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4522
28177add
PE
45232011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4524
dd3482fe
PE
4525 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4526 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4527 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4528
393d71f3 4529 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4530 * fileio.c (Finsert_file_contents):
4531 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4532 Remove the old (too-loose) buffer overflow checks.
4533 They weren't needed, since make_gap checks for buffer overflow.
4534 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4535 The old code merely checked for Emacs fixnum overflow, and relied
4536 on undefined (wraparound) behavior. The new code avoids undefined
4537 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4538
2e6813b0 4539 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4540 Tune. Don't use wider integers than needed. Don't use alloca.
4541 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4542
599a9e4f
PE
4543 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4544
99561444
PE
4545 * insdel.c, lisp.h (buffer_overflow): New function.
4546 (insert_from_buffer_1, replace_range, replace_range_2):
4547 * insdel.c (make_gap_larger):
4548 * editfns.c (Finsert_char):
4549 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4550
28177add
PE
4551 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4552
e69dafad
PE
45532011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4554
4baa020d 4555 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 4556
b1c46f02
PE
4557 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4558 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4559
e69dafad
PE
4560 * fileio.c: Don't assume EMACS_INT fits in off_t.
4561 (emacs_lseek): New static function.
4562 (Finsert_file_contents, Fwrite_region): Use it.
4563 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4564
566684ea
PE
4565 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4566
e6966cd6
PE
4567 * fns.c: Don't overflow int when computing a list length.
4568 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4569 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4570 truncation on 64-bit hosts. Check for QUIT every
4571 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4572 faster and is responsive enough.
4573 (Flength): Report an error instead of overflowing an integer.
4574 (Fsafe_length): Return a float if the value is not representable
4575 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4576 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4577 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4578
dd0b0efb
PE
4579 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4580 (header_size, word_size): New constants.
4581 (allocate_vectorlike): Don't check size overflow here.
4582 (allocate_vector): Check it here instead, since this is the only
4583 caller of allocate_vectorlike that could cause overflow.
4584 Check that the new vector's length is representable as a fixnum.
4585
86fe5cfe
PE
4586 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4587 The previous code was bogus. For example, next_almost_prime (32)
4588 returned 39, which is undesirable as it is a multiple of 3; and
4589 next_almost_prime (24) returned 25, which is a multiple of 5 so
4590 why was the code bothering to check for multiples of 7?
4591
80e88859
PE
4592 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4593
4a2f0ad6
PE
4594 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4595
f66c7cf8
PE
4596 Variadic C functions now count arguments with ptrdiff_t.
4597 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4598 Back then I didn't know that the Emacs coding style prefers signed int.
4599 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4600 were being counted with int, which may truncate counts on 64-bit
4601 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4602 * lisp.h (struct Lisp_Subr.function.aMANY)
4603 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4604 Arg counts are now ptrdiff_t, not size_t.
4605 All variadic functions and their callers changed accordingly.
4606 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4607 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4608 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4609 * callint.c (Fcall_interactively): Check arg count for overflow,
4610 to avoid potential buffer overrun. Use signed char, not 'int',
4611 for 'varies' array, so that we needn't bother to check its size
4612 calculation for overflow.
4613 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4614 * eval.c (apply_lambda):
4615 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4616 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4617 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4618
a1759b76
PE
4619 * callint.c (Fcall_interactively): Don't use index var as event count.
4620
d96be9fc
PE
4621 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4622 * mem-limits.h (SIZE): Remove; no longer used.
4623
a690a978 4624 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4625
578c21e6
PE
4626 Remove unnecessary casts.
4627 * xterm.c (x_term_init):
4628 * xfns.c (x_set_border_pixel):
4629 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4630 These aren't needed now that we assume ANSI C.
4631
96f53c6c
PE
4632 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4633 It's more likely to cause problems (due to unsigned overflow)
4634 than to cure them.
4635
83c77d31
PE
4636 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4637
ee2079f1
PE
4638 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4639
6da65536
PE
4640 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4641
7147c4a4
PE
4642 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4643
193e32d9
PE
4644 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4645
e5533da6
PE
4646 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4647
9910e595
PE
4648 GLYPH_CODE_FACE returns EMACS_INT, not int.
4649 * dispextern.h (merge_faces):
4650 * xfaces.c (merge_faces):
01103c44
PE
4651 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4652 Don't assume EMACS_INT fits in int.
9910e595 4653
2638320e
PE
4654 * character.h (CHAR_VALID_P): Remove unused parameter.
4655 * fontset.c, lisp.h, xdisp.c: All uses changed.
4656
045eb8d9
PE
4657 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4658
c1f134b5
PE
4659 * fns.c (concat): Minor tuning based on overflow analysis.
4660 This doesn't fix any bugs. Use int to hold character, instead
4661 of constantly refetching from Emacs object. Use XFASTINT, not
4662 XINT, for value known to be a character. Don't bother comparing
4663 a single byte to 0400, as it's always less.
4664
395fcb93 4665 * floatfns.c (Fexpt):
327eeec8
PE
4666 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4667
abbd3d23
PE
4668 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4669 for characters.
4670
684a03ef
PE
4671 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4672
0fed43f3
PE
4673 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4674 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4675 incorrectly succeed when S was a string, because 4294967386 was
4676 truncated before it was used.
4677
8fd02eb7
PE
4678 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4679 Otherwise, an out-of-range integer could cause undefined behavior
4680 on a 64-bit host.
4681
f8c86b69
PE
4682 * composite.c: Use int, not EMACS_INT, for characters.
4683 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4684 EMACS_INT, for values that are known to be in character range.
4685 This doesn't fix any bugs but is the usual style inside Emacs and
4686 may generate better code on 32-bit machines.
4687
34206dd2
PE
4688 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4689 This is for reasons similar to the recent CHAR_STRING fix.
4690 * charset.c (Fencode_char): Check that character arg is actually
4691 a character. Pass an int to ENCODE_CHAR.
4692 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4693 wider than 'int', as a compile-time check to prevent future regressions
4694 in this area.
4695
c5958d4c 4696 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4697
4698 Make sure a 64-bit char is never passed to CHAR_STRING.
4699 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4700 by silently ignoring the top 32 bits, allowing some values
4701 that were far too large to be valid characters.
4702 * character.h: Include <verify.h>.
4703 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4704 arguments are no wider than unsigned, as a compile-time check
4705 to prevent future regressions in this area.
4706 * data.c (Faset):
01103c44 4707 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4708 (Fsubst_char_in_region):
4709 * fns.c (concat):
4710 * xdisp.c (decode_mode_spec_coding):
4711 Adjust to CHAR_STRING's new requirement.
4712 * editfns.c (Finsert_char, Fsubst_char_in_region):
4713 * fns.c (concat): Check that character args are actually
4714 characters. Without this test, these functions did the wrong
4715 thing with wildly out-of-range values on 64-bit hosts.
4716
d37ca623
PE
4717 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4718 These casts should not be needed on 32-bit hosts, either.
4719 * keyboard.c (read_char):
4720 * lread.c (Fload): Remove casts to unsigned.
4721
ea204efb
PE
4722 * lisp.h (UNSIGNED_CMP): New macro.
4723 This fixes comparison bugs on 64-bit hosts.
4724 (ASCII_CHAR_P): Use it.
4725 * casefiddle.c (casify_object):
01103c44 4726 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4727 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4728 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4729 * dispextern.h (FACE_FROM_ID):
4730 * keyboard.c (read_char): Use UNSIGNED_CMP.
4731
41cb286c
PE
4732 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4733 not to EMACS_INT, to avoid GCC warning.
4734
4a1b9832
PE
4735 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4736
55daad71
PE
4737 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4738 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4739 isn't needed on 32-bit machines.
8f95c75c 4740
01103c44
PE
4741 * buffer.c (Fgenerate_new_buffer_name):
4742 Use EMACS_INT for count, not int.
0ceccced 4743 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4744
4745 * data.c (Qcompiled_function): Now static.
4746
c6f072e7
PE
4747 * window.c (window_body_lines): Now static.
4748
20ce5912
PE
4749 * image.c (gif_load): Rename local to avoid shadowing.
4750
9c4c5f81
PE
4751 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4752 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4753 * alloc.c (make_save_value): Integer argument is now of type
4754 ptrdiff_t, not int.
4755 (mark_object): Use ptrdiff_t, not int.
4756 * lisp.h (pD): New macro.
4757 * print.c (print_object): Use it.
4758
c0c5c8ae
PE
4759 * alloc.c: Use EMACS_INT, not int, to count objects.
4760 (total_conses, total_markers, total_symbols, total_vector_size)
4761 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4762 (total_free_floats, total_floats, total_free_intervals)
4763 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4764 Now EMACS_INT, not int. All uses changed.
4765 (Fgarbage_collect): Compute overall total using a double, so that
4766 integer overflow is less likely to be a problem. Check for overflow
4767 when converting back to an integer.
5a25e253
PE
4768 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4769 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4770 These were 'int' variables that could overflow on 64-bit hosts;
4771 they were never used, so remove them instead of repairing them.
211a0b2a 4772 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4773 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4774 Previously, this ceilinged at INT_MAX, but that doesn't work on
4775 64-bit machines.
e46bb31a 4776 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4777
c78baabf 4778 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4779 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4780 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4781 when a (possibly-narrower) signed value would do just as well.
4782 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4783
c9d624c6
PE
4784 * alloc.c: Catch some string size overflows that we were missing.
4785 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4786 for convenience in STRING_BYTES_MAX.
4787 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4788 The definition here is exact; the one in lisp.h was approximate.
4789 (allocate_string_data): Check for string overflow. This catches
4790 some instances we weren't catching before. Also, it catches
4791 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4792 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4793 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4794
c9d624c6
PE
4795 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4796 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4797 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4798
353032ce
PE
4799 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4800
2bccce07
PE
4801 * alloc.c (Fmake_string): Check for out-of-range init.
4802
0ac30604
SM
48032011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4804
4805 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4806
c195f2de
JD
48072011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4808
4809 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4810 xg_get_default_scrollbar_width.
4811
4812 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4813 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4814 (style_changed_cb): Call update_theme_scrollbar_width and call
4815 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4816 all frames (Bug#8505).
4817 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4818 Call gtk_window_set_resizable if HAVE_GTK3.
4819 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4820 and height if HAVE_GTK3 (Bug#8505).
4821 (scroll_bar_width_for_theme): New variable.
4822 (update_theme_scrollbar_width): New function.
4823 (xg_get_default_scrollbar_width): Move code to
4824 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4825 (xg_initialize): Call update_theme_scrollbar_width.
4826
4827 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4828
4829 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4830
e10ac9f1
MR
48312011-06-12 Martin Rudalics <rudalics@gmx.at>
4832
4833 * frame.c (make_frame): Call other_buffer_safely instead of
4834 other_buffer.
4835
4836 * window.c (temp_output_buffer_show): Call display_buffer with
4837 second argument Vtemp_buffer_show_specifiers and reset latter
4838 immediately after the call.
4839 (Vtemp_buffer_show_specifiers): New variable.
4840 (auto_window_vscroll_p, next_screen_context_lines)
4841 (Vscroll_preserve_screen_position): Remove leading asterisks from
4842 doc-strings.
4843
2d3c217e 48442011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4845
7b7f97e8 4846 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4847 * buffer.c (Qclone_number): Remove for now, as it's unused.
4848 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4849 (record_buffer): Remove unused local.
4850 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4851 (set_frame_buffer_list): Remove; unused.
4852 * frame.h (other_visible_frames): Remove decl.
4853 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4854 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4855 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4856 if HAVE_GPM.
4857 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4858 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4859 Define only if HAVE_GPM.
4860 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4861 (update_hints_inhibit): Remove; never set. All uses removed.
4862 * widgetprv.h (emacsFrameClassRec): Remove decl.
4863 * window.c (delete_deletable_window): Now returns void, since it
4864 wasn't returning anything.
4865 (compare_window_configurations): Remove unused locals.
4866 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4867 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4868 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4869 the same widths as pointers. This follows up on the 2011-05-06 patch.
4870 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4871 * xterm.h: Likewise.
4872 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4873
1384b89e
JB
48742011-06-12 Juanma Barranquero <lekktu@gmail.com>
4875
4876 * makefile.w32-in: Update dependencies.
4877 (LISP_H): Add lib/intprops.h.
4878
1100a63c
CY
48792011-06-11 Chong Yidong <cyd@stupidchicken.com>
4880
4881 * image.c (gif_load): Add animation frame delay to the metadata.
4882 (syms_of_image): Use DEFSYM. New symbol `delay'.
4883
6198ccd0
MR
48842011-06-11 Martin Rudalics <rudalics@gmx.at>
4885
4886 * window.c (delete_deletable_window): Re-add.
4887 (Fset_window_configuration): Rewrite to handle dead buffers and
4888 consequently deletable windows.
4889 (window_tree, Fwindow_tree): Remove. Supply functionality in
4890 window.el.
4891 (compare_window_configurations): Simplify code.
4892
b6e3633c
AS
48932011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4894
1ab0dee5
AS
4895 * image.c (imagemagick_load_image): Fix type mismatch.
4896 (Fimagemagick_types): Likewise.
4897
b6e3633c
AS
4898 * window.h (replace_buffer_in_windows): Declare.
4899
9397e56f
MR
49002011-06-11 Martin Rudalics <rudalics@gmx.at>
4901
4902 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4903 Qclone_number. Remove external declaration of Qdelete_window.
4904 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4905 code.
640c8776
SM
4906 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4907 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4908 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4909 buffer list implementation.
4910 (other_buffer_safely): New function.
4911 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4912 calls to replace_buffer_in_windows and
4913 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4914 if allowed.
4915 (record_buffer): Inhibit quitting and rewrite using quittable
4916 functions. Run Qbuffer_list_update_hook if allowed.
4917 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4918 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4919 Move switch-to-buffer to window.el.
9397e56f
MR
4920 (bury-buffer): Move to window.el.
4921 (Vbuffer_list_update_hook): New variable.
4922
4923 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4924 section.
4925
4926 * window.h (resize_frame_windows): Move up in code.
4927 (Fwindow_frame): Remove EXFUN.
4928 (replace_buffer_in_all_windows): Remove prototype.
4929 (replace_buffer_in_windows_safely): Add prototype.
4930
4931 * window.c: Declare Qdelete_window static again. Move down
4932 declaration of select_count.
4933 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4934 (Fother_window): Move to window.el.
4935 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4936 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4937 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4938 window.el.
4939 (replace_buffer_in_windows): Implement by calling
4940 Qreplace_buffer_in_windows.
4941 (replace_buffer_in_all_windows): Remove with some functionality
4942 moved into replace_buffer_in_windows_safely.
4943 (replace_buffer_in_windows_safely): New function.
4944 (select_window_norecord, select_frame_norecord): Move in front
4945 of run_window_configuration_change_hook. Remove now obsolete
4946 declarations.
640c8776
SM
4947 (Fset_window_buffer): Rewrite doc-string.
4948 Call Qrecord_window_buffer.
9397e56f
MR
4949 (keys_of_window): Move binding for other-window to window.el.
4950
b50691aa
CY
49512011-06-11 Chong Yidong <cyd@stupidchicken.com>
4952
4953 * dispextern.h (struct image): Replace data member, whose int_val
4954 and ptr_val fields were not used by anything, with a single
4955 lisp_val object.
4956
4957 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4958 (gif_clear_image, gif_load, imagemagick_load_image)
4959 (gs_clear_image, gs_load): Callers changed.
4960
3f754b86
PE
49612011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4962
cca69397
PE
4963 * buffer.h: Include <time.h>, for time_t.
4964 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4965
109e28d0
PE
4966 Fix minor problems found by static checking.
4967
60737f02
PE
4968 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4969
4b66faf3
PE
4970 Make identifiers static if they are not used in other modules.
4971 * data.c (Qcompiled_function, Qframe, Qvector):
4972 * image.c (QimageMagick, Qsvg):
4973 * minibuf.c (Qmetadata):
4974 * window.c (resize_window_check, resize_root_window): Now static.
4975 * window.h (resize_window_check, resize_root_window): Remove decls.
4976
109e28d0
PE
4977 * window.c (window_deletion_count, delete_deletable_window):
4978 Remove; unused.
46a4ce9e
PE
4979 (window_body_lines): Now static.
4980 (Fdelete_other_windows_internal): Mark vars as initialized.
4981 Make sure 'resize_failed' is initialized.
4982 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4983 (resize_window_apply): Remove unused local.
4984 * window.h (delete_deletable_window): Remove decl.
4985
109e28d0 4986 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4987 (imagemagick_load_image): Fix pointer signedness problem by changing
4988 last arg from unsigned char * to char *. All uses changed.
4989 Also, fix a local for similar reasons.
4990 Remove unused locals. Remove locals to avoid shadowing.
4991 (fn_rsvg_handle_free): Remove; unused.
4992 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4993 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4994
3f754b86
PE
4995 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4996
2547adb1
CY
49972011-06-10 Chong Yidong <cyd@stupidchicken.com>
4998
4999 * image.c (gif_load): Fix omitted cast error introduced by
5000 2011-06-06 change.
5001
2c8e37d4
MR
50022011-06-10 Martin Rudalics <rudalics@gmx.at>
5003
5004 * window.h (resize_proportionally, orig_total_lines)
5005 (orig_top_line): Remove from window structure.
5006 (set_window_height, set_window_width, change_window_heights)
5007 (Fdelete_window): Remove prototypes.
5008 (resize_frame_windows): Remove duplicate declaration.
5009
440a42e3
EZ
50102011-06-10 Eli Zaretskii <eliz@gnu.org>
5011
5012 * window.h (resize_frame_windows, resize_window_check)
5013 (delete_deletable_window, resize_root_window)
5014 (resize_frame_windows): Declare prototypes.
5015
5016 * window.c (resize_window_apply): Make definition be "static" to
5017 match the prototype.
5018
562dd5e9
MR
50192011-06-10 Martin Rudalics <rudalics@gmx.at>
5020
5021 * window.c: Remove declarations of Qwindow_size_fixed,
5022 window_min_size_1, window_min_size_2, window_min_size,
5023 size_window, window_fixed_size_p, enlarge_window, delete_window.
5024 Remove static from declaration of Qdelete_window, it's
5025 temporarily needed by Fbury_buffer.
5026 (replace_window): Don't assign orig_top_line and
5027 orig_total_lines.
5028 (Fdelete_window, delete_window): Remove. Window deletion is
5029 handled by window.el.
640c8776
SM
5030 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5031 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5032 (Fdelete_other_windows): Remove. Deleting other windows is
5033 handled by window.el.
5034 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5035 handled in window.el.
5036 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5037 Window minimum sizes are handled in window.el.
5038 (shrink_windows, size_window, set_window_height)
5039 (set_window_width, change_window_heights, window_height)
5040 (window_width, CURBEG, CURSIZE, enlarge_window)
5041 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5042 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5043 handled in window.el.
5044 (make_dummy_parent): Rename to make_parent_window and give it a
5045 second argument horflag.
5046 (make_window): Don't set resize_proportionally any more.
5047 (Fsplit_window): Remove. Windows are split in window.el.
5048 (save_restore_action, save_restore_orig_size)
5049 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5050 Resize mini windows in window.el.
5051 (grow_mini_window, shrink_mini_window): Implement by calling
5052 Qresize_root_window_vertically, resize_window_check and
5053 resize_window_apply.
640c8776
SM
5054 (saved_window, Fset_window_configuration, save_window_save):
5055 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5056 resize_proportionally.
5057 (window_min_height, window_min_width): Move to window.el.
5058 (keys_of_window): Move bindings for delete-other-windows,
5059 split-window, delete-window and enlarge-window to window.el.
5060
5061 * buffer.c: Temporarily extern Qdelete_window.
5062 (Fbury_buffer): Temporarily call Qdelete_window instead of
5063 Fdelete_window (Fbury_buffer will move to window.el soon).
5064
5065 * frame.c (set_menu_bar_lines_1): Remove code handling
5066 orig_top_line and orig_total_lines.
5067
5068 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5069 set_window_height but set heights directly.
5070 (change_frame_size_1): Use resize_frame_windows.
5071
5072 * xdisp.c (init_xdisp): Don't use set_window_height but set
5073 heights directly.
5074
640c8776
SM
5075 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5076 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5077 run_window_configuration_change_hook.
5078
5079 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5080 instead of change_window_heights and run
5081 run_window_configuration_change_hook.
5082
1a13852e
MR
50832011-06-09 Martin Rudalics <rudalics@gmx.at>
5084
5085 * window.c (replace_window): Rename second argument REPLACEMENT to
5086 NEW. New third argument SETFLAG. Rewrite.
5087 (delete_window, make_dummy_parent): Call replace_window with
5088 third argument 1.
5089 (window_list_1): Move down in code.
5090 (run_window_configuration_change_hook): Move set_buffer part
5091 before select_frame_norecord part in order to unwind correctly.
5092 Rename count1 to count.
5093 (recombine_windows, delete_deletable_window, resize_root_window)
5094 (Fdelete_other_windows_internal)
5095 (Frun_window_configuration_change_hook, make_parent_window)
5096 (resize_window_check, resize_window_apply, Fresize_window_apply)
5097 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5098 (Fdelete_window_internal, Fresize_mini_window_internal):
5099 New functions.
1a13852e
MR
5100 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5101
f3d1777e
MR
51022011-06-08 Martin Rudalics <rudalics@gmx.at>
5103
496e208e
MR
5104 * window.h (window): Add some new members to window structure -
5105 normal_lines, normal_cols, new_total, new_normal, clone_number,
5106 splits, nest, prev_buffers, next_buffers.
5107 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5108 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5109
f3d1777e
MR
5110 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5111 Remove.
496e208e
MR
5112 (make_dummy_parent): Set new members of windows structure.
5113 (make_window): Move down in code. Handle new members of window
5114 structure.
5115 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5116 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5117 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5118 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5119 (Fset_window_next_buffers, Fset_window_clone_number):
5120 New functions.
496e208e
MR
5121 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5122 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5123 Doc-string fixes.
5124 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5125 Argument WINDOW can be now internal window too.
5126 (Fwindow_use_time): Move up in code.
5127 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5128 Rewrite doc-string.
5129 (Fset_window_configuration, saved_window)
5130 (Fcurrent_window_configuration, save_window_save): Handle new
5131 members of window structure.
b9e809c2
MR
5132 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5133 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5134 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5135 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5136 Qget_mru_window, Qresize_root_window,
5137 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5138 Qauto_buffer_name; staticpro them.
f3d1777e 5139
abde8f8c
MR
51402011-06-07 Martin Rudalics <rudalics@gmx.at>
5141
5142 * window.c (Fwindow_total_size, Fwindow_left_column)
5143 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5144 (Fwindow_list_1): New functions.
5145 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5146 (Fwindow_width, Fscroll_left, Fscroll_right):
5147 Use window_body_cols instead of window_box_text_cols.
5148 (delete_window, Fset_window_configuration):
5149 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5150 (delete_all_subwindows): Take a window as argument and not a
5151 structure. Rewrite.
190b47e6
MR
5152 (window_loop): Remove handling of GET_LRU_WINDOW and
5153 GET_LARGEST_WINDOW.
5154 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5155
5156 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5157 window_box_text_cols. delete_all_subwindows now takes a
5158 Lisp_Object as argument.
abde8f8c 5159
640c8776
SM
5160 * indent.c (compute_motion, Fcompute_motion):
5161 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5162
fa8a67e6
MR
5163 * frame.c (delete_frame): Call delete_all_subwindows with root
5164 window as argument.
5165
a54e3482
DC
51662011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5167
5168 * fns.c (Fputhash): Document return value.
5169
60002bf5
CY
51702011-06-06 Chong Yidong <cyd@stupidchicken.com>
5171
5172 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5173
0c671da6 51742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5175
b862a52a 5176 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5177
be44ca6c
PE
5178 Check for overflow when converting integer to cons and back.
5179 * charset.c (Fdefine_charset_internal, Fdecode_char):
5180 Use cons_to_unsigned to catch overflow.
5181 (Fencode_char): Use INTEGER_TO_CONS.
5182 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5183 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5184 * data.c (long_to_cons, cons_to_long): Remove.
5185 (cons_to_unsigned, cons_to_signed): New functions.
5186 These signal an error for invalid or out-of-range values.
5187 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5188 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5189 * font.c (Ffont_variation_glyphs):
5190 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5191 * lisp.h: Include <intprops.h>.
5192 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5193 (cons_to_signed, cons_to_unsigned): New decls.
5194 (long_to_cons, cons_to_long): Remove decls.
5195 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5196 (Fprimitive_undo): Use CONS_TO_INTEGER.
5197 * xfns.c (Fx_window_property): Likewise.
5198 * xselect.c: Include <limits.h>.
5199 (x_own_selection, selection_data_to_lisp_data):
5200 Use INTEGER_TO_CONS.
5201 (x_handle_selection_request, x_handle_selection_clear)
5202 (x_get_foreign_selection, Fx_disown_selection_internal)
5203 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5204 (lisp_data_to_selection_data): Use cons_to_unsigned.
5205 (x_fill_property_data): Use cons_to_signed.
5206 Report values out of range.
5207
d1f3d2af
PE
5208 Check for buffer and string overflow more precisely.
5209 * buffer.h (BUF_BYTES_MAX): New macro.
5210 * lisp.h (STRING_BYTES_MAX): New macro.
5211 * alloc.c (Fmake_string):
5212 * character.c (string_escape_byte8):
5213 * coding.c (coding_alloc_by_realloc):
5214 * doprnt.c (doprnt):
5215 * editfns.c (Fformat):
5216 * eval.c (verror):
5217 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5218 since they may not be the same number.
5219 * editfns.c (Finsert_char):
5220 * fileio.c (Finsert_file_contents):
5221 Likewise for BUF_BYTES_MAX.
5222
dd52fcea
PE
5223 * image.c: Use ptrdiff_t, not int, for sizes.
5224 (slurp_file): Switch from int to ptrdiff_t.
5225 All uses changed.
5226 (slurp_file): Check that file size fits in both size_t (for
5227 malloc) and ptrdiff_t (for sanity and safety).
5228
7f9bbdbb
PE
5229 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5230 if b->modtime has its maximal value.
5231
dfe18f82
PE
5232 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5233
84acfcf0
PE
5234 Don't assume time_t can fit into int.
5235 * buffer.h (struct buffer.modtime): Now time_t, not int.
5236 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5237 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5238
ccd9a01a
PE
5239 Minor fixes for signed vs unsigned integers.
5240 * character.h (MAYBE_UNIFY_CHAR):
5241 * charset.c (maybe_unify_char):
5242 * keyboard.c (read_char, reorder_modifiers):
5243 XINT -> XFASTINT, since the integer must be nonnegative.
5244 * ftfont.c (ftfont_spec_pattern):
5245 * keymap.c (access_keymap, silly_event_symbol_error):
5246 XUINT -> XFASTINT, since the integer must be nonnegative.
5247 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5248 since it makes no difference and we prefer signed.
5249 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5250 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5251 nonnegative.
5252
d6d100dd
SM
52532011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5254
5255 * window.h (Fwindow_frame): Declare.
5256
2b6148e4
PE
52572011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5258
5259 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5260 (SPARE_MEMORY): Always define.
5261 (LARGE_REQUEST): Remove.
5262 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5263
f230ecc9
MR
52642011-06-06 Martin Rudalics <rudalics@gmx.at>
5265
727e958e
MR
5266 * lisp.h: Move EXFUNS for Fframe_root_window,
5267 Fframe_first_window and Fset_frame_selected_window to window.h.
5268
5269 * window.h: Move EXFUNS for Fframe_root_window,
5270 Fframe_first_window and Fset_frame_selected_window here from
5271 lisp.h.
5272
5273 * frame.c (Fwindow_frame, Fframe_first_window)
5274 (Fframe_root_window, Fframe_selected_window)
5275 (Fset_frame_selected_window): Move to window.c.
5276 (Factive_minibuffer_window): Move to minibuf.c.
5277 (Fother_visible_frames_p): New function.
5278
5279 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5280
f230ecc9
MR
5281 * window.c (decode_window, decode_any_window): Move up in code.
5282 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5283 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5284 (Fwindow_buffer): Move up and rewrite doc-string.
5285 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5286 (Fwindow_prev): New functions.
727e958e
MR
5287 (Fwindow_frame): Move here from frame.c. Accept any window as
5288 argument.
5289 (Fframe_root_window, Fframe_first_window)
5290 (Fframe_selected_window): Move here from frame.c. Accept frame
5291 or arbitrary window as argument. Update doc-strings.
5292 (Fminibuffer_window): Move up in code.
5293 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5294 (Fset_frame_selected_window): Move here from frame.c.
5295 Marginal rewrite.
727e958e
MR
5296 (Fselected_window, select_window, Fselect_window): Move up in
5297 code. Minor doc-string fixes.
f230ecc9 5298
4d09bcf6
PE
52992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5300
5301 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5302 Do not assume that spare memory exists; that assumption is valid
5303 only if SYSTEM_MALLOC.
5304 (LARGE_REQUEST): New macro, so that the issue of large requests
5305 is separated from the issue of spare memory.
5306
810928a2
AS
53072011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5308
172418ad
AS
5309 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5310 format. (Bug#8806)
5311
43f862f7
AS
5312 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5313
810928a2
AS
5314 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5315 before statements.
5316
a059fe24
JD
53172011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5318
5319 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5320
5321 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5322
5323 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5324 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5325
989bf368
JB
53262011-06-05 Juanma Barranquero <lekktu@gmail.com>
5327
5328 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5329
4b80f674
CY
53302011-06-04 Chong Yidong <cyd@stupidchicken.com>
5331
5332 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5333 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5334 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5335 New error handlers.
4b80f674
CY
5336 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5337 Obey Vx_select_enable_clipboard_manager. Catch errors in
5338 x_clipboard_manager_save (Bug#8779).
5339 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5340 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5341
99a33b77 53422011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5343
5344 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5345
99a33b77 53462011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5347
5348 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5349 in the current matrix if keep_current_p is non-zero.
5350
8264569d
EZ
53512011-06-04 Eli Zaretskii <eliz@gnu.org>
5352
5353 * bidi.c (bidi_level_of_next_char): Fix last change.
5354
57f97249
EZ
53552011-06-03 Eli Zaretskii <eliz@gnu.org>
5356
fec2107c 5357 Support bidi reordering of text covered by display properties.
57f97249 5358
fec2107c
EZ
5359 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5360 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5361 (bidi_cache_search, bidi_cache_iterator_state)
5362 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5363 (bidi_level_of_next_char, bidi_move_to_visually_next):
5364 Support character positions inside a run of characters covered by a
fec2107c
EZ
5365 display string.
5366 (bidi_paragraph_init, bidi_resolve_explicit_1)
5367 (bidi_level_of_next_char): Call bidi_fetch_char and
5368 bidi_fetch_char_advance instead of FETCH_CHAR and
5369 FETCH_CHAR_ADVANCE.
5370 (bidi_init_it): Initialize new members.
5371 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5372 definitions.
5373 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5374 instead of using explicit *_CHAR codes.
d6d100dd
SM
5375 (bidi_resolve_explicit, bidi_resolve_weak):
5376 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5377 bidirectional text is supported only in multibyte buffers.
5378 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5379 it to initialize the frame_window_p member of struct bidi_it.
5380 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5381 (bidi_resolve_explicit, bidi_resolve_weak)
5382 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5383 bidi_it->nchars is non-positive.
5384 (bidi_level_of_next_char): Don't try to lookup the cache for the
5385 next/previous character if nothing is cached there yet, or if we
5386 were just reseat()'ed to a new position.
c40e2fb2 5387
0e14fe90
EZ
5388 * xdisp.c (set_cursor_from_row): Set start and stop points
5389 according to the row's direction when priming the loop that looks
5390 for the glyph on which to display cursor.
5391 (single_display_spec_intangible_p): Function deleted.
5392 (display_prop_intangible_p): Reimplement to call
5393 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5394 Accept 3 additional arguments needed by handle_display_spec.
5395 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5396 values: lists, `(when COND...)' forms, etc.
5397 (single_display_spec_string_p): Support property values that are
5398 lists with the argument STRING its top-level element.
5399 (display_prop_string_p): Fix the condition for processing a
5400 property that is a list to be consistent with handle_display_spec.
fec2107c 5401 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5402 last portion of handle_display_prop.
5403 (compute_display_string_pos): Accept additional argument
5404 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5405 value of a `display' property is a "replacing spec".
5406 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5407 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5408 the display property, but just return a value indicating whether
5409 the display property will replace the characters it covers.
5410 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5411 frame_window_p members of struct bidi_it.
d6d100dd
SM
5412 (compute_display_string_pos, compute_display_string_end):
5413 New functions.
fec2107c
EZ
5414 (push_it): Accept second argument POSITION, where pop_it should
5415 jump to continue iteration.
5416 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5417
fec2107c
EZ
5418 * keyboard.c (adjust_point_for_property): Adjust the call to
5419 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5420
5421 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5422 (bidi_init_it): Update prototypes.
5423 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5424 (compute_display_string_pos, compute_display_string_end):
5425 Declare prototypes.
fec2107c
EZ
5426 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5427 EMACS_INT.
fc6f18ce 5428
40087514 54292011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5430
57f53182
PE
5431 Malloc failure behavior now depends on size of allocation.
5432 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5433 * lisp.h: Change signatures accordingly.
5434 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5435 All callers changed. (Bug#8762)
5436
5437 * gnutls.c: Use Emacs's memory allocators.
5438 Without this change, the gnutls library would invoke malloc etc.
5439 directly, which causes problems on non-SYNC_INPUT hosts, and which
5440 runs afoul of improving memory_full behavior. (Bug#8761)
5441 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5442 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5443 xfree instead of the default malloc, realloc, free.
5444 (Fgnutls_boot): No need to check for memory allocation failure,
5445 since xmalloc does that for us.
5446
ac32cd99 5447 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5448 * category.c (hash_get_category_set):
5449 * ccl.c (ccl_driver):
5450 * charset.c (Fdefine_charset_internal):
5451 * charset.h (struct charset.hash_index):
5452 * composite.c (get_composition_id, gstring_lookup_cache)
5453 (composition_gstring_put_cache):
5454 * composite.h (struct composition.hash_index):
5455 * dispextern.h (struct image.hash):
5456 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5457 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5458 (hashfn_equal, hashfn_user_defined, make_hash_table)
5459 (maybe_resize_hash_table, hash_lookup, hash_put)
5460 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5461 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5462 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5463 * image.c (make_image, search_image_cache, lookup_image)
5464 (xpm_put_color_table_h):
5465 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5466 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5467 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5468 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5469 * alloc.c (allocate_vectorlike):
5470 Check for overflow in vector size calculations.
5471 * ccl.c (ccl_driver):
5472 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5473 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5474 need to be updated by these changes.
40087514
PE
5475 * fns.c (make_hash_table, maybe_resize_hash_table):
5476 Check for integer overflow with large hash tables.
0de4bb68
PE
5477 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5478 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5479 (SXHASH_REDUCE): New macro.
5480 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5481 Use it instead of discarding useful hash info with large hash values.
5482 (sxhash_float): New function.
5483 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5484 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5485 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5486 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5487 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5488 Adjust signatures to match updated version of code.
5489 (consing_since_gc): Now EMACS_INT, since a single hash table can
5490 use more than INT_MAX bytes.
5491
698d32e2
DN
54922011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5493
5494 Make it possible to build with GCC-4.6+ -O2 -flto.
5495
5496 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5497
fd6fa53f
SM
54982011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5499
5500 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5501 Call minibuffer-inactive-mode.
5502
864db017
JB
55032011-05-31 Juanma Barranquero <lekktu@gmail.com>
5504
5505 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5506 Update dependencies.
5507
2ad0baf4
DN
55082011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5509
5510 * data.c (init_data): Remove code for UTS, this system is not
5511 supported anymore.
5512
4fcc2638
DN
55132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5514
5515 Don't force ./temacs to start in terminal mode.
5516
5517 * frame.c (make_initial_frame): Initialize faces in all cases, not
5518 only when CANNOT_DUMP is defined.
5519 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5520
c56e0fd5
DN
55212011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5522
5523 * dispnew.c (add_window_display_history): Use const for the string
5524 pointer. Remove declaration, not needed.
5525
333d54da 55262011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5527
55d4c1b2 5528 Use 'inline', not 'INLINE'.
333d54da 5529 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5530 * alloc.c, fontset.c (INLINE): Remove.
5531 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5532 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5533 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5534 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5535 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5536
738db178
DN
55372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5538
5539 Make it possible to run ./temacs.
5540
5541 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5542 syms_of_callproc does the same thing. Remove test for
5543 "initialized", do it in the caller.
5544 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5545
620c53a6
SM
55462011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5547
5548 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5549 (read_minibuf): Use get_minibuffer.
5550 (syms_of_minibuf): Use DEFSYM.
5551 (Qmetadata): New var.
5552 * data.c (Qbuffer): Don't make it static.
5553 (syms_of_data): Use DEFSYM.
5554
e003a292
PE
55552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5556
5557 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5558 (CCL_CODE_MIN): New macro.
5559
ed008a6d
PE
55602011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5561
3687c2ef
PE
5562 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5563
ed008a6d
PE
5564 * eval.c (Qdebug): Now static.
5565 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5566 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5567 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5568
d66c4c7c
CY
55692011-05-29 Chong Yidong <cyd@stupidchicken.com>
5570
5571 * image.c: Various fixes to ImageMagick code comments.
5572 (Fimagemagick_types): Doc fix.
5573
5fbc2025
PE
55742011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5575
0196f88a
PE
5576 Minor fixes prompted by GCC 4.6.0 warnings.
5577
5578 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5579
5fbc2025
PE
5580 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5581 (x_clipboard_manager_save_all): Move extern decl to ...
5582 * xterm.h: ... here, so that it can be checked for consistency.
5583
1dd3c2d9
CY
55842011-05-29 Chong Yidong <cyd@stupidchicken.com>
5585
5586 * xselect.c (x_clipboard_manager_save_frame)
5587 (x_clipboard_manager_save_all): New functions.
5588 (Fx_clipboard_manager_save): Lisp function deleted.
5589
5590 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5591 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5592
5593 * xterm.h: Update prototype.
5594
5ba6571d
WX
55952011-05-28 William Xu <william.xwl@gmail.com>
5596
5597 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5598 exiting (Bug#8239).
5599
3eaff834
JM
56002011-05-28 Jim Meyering <meyering@redhat.com>
5601
e1900994 5602 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5603 * fns.c (to_uchar): Define.
5604 (crypto_hash_function): Use it to convert some newly-signed
5605 variables to unsigned, to avoid sign-extension bugs. For example,
5606 without this change, (md5 "truc") would evaluate to
5607 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5608 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5609 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5610
0f6990a7
PE
56112011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5612
5613 Integer overflow fixes.
c8a9ca5a 5614
08686060
PE
5615 * dbusbind.c: Serial number integer overflow fixes.
5616 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5617 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5618 to hold a serial number that is too large for a fixnum.
5619 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5620 Check for serial numbers out of range. Decode any serial number
59568bf0 5621 that was so large that it became a float. (Bug#8722)
08686060 5622
2d1fc3c7
PE
5623 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5624 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5625 Use XFASTINT rather than XUINT when numbers are nonnegative.
5626 (xd_append_arg, Fdbus_method_return_internal):
5627 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5628 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5629 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5630 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5631 (Bug#8722)
2d1fc3c7 5632
c8a9ca5a
PE
5633 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5634
519e1d69
PE
5635 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5636
30569699
PE
5637 ccl: add integer overflow checks
5638 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5639 (IN_INT_RANGE): New macros.
5640 (ccl_driver): Use them to check for integer overflow when
5641 decoding a CCL program. Many of the new checks are whether XINT (x)
5642 fits in int; it doesn't always, on 64-bit hosts. The new version
5643 doesn't catch all possible integer overflows, but it's an
847044ea 5644 improvement. (Bug#8719)
30569699 5645
c11285dc
PE
5646 * alloc.c (make_event_array): Use XINT, not XUINT.
5647 There's no need for unsigned here.
5648
fdccd48e
PE
5649 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5650 This follows up to the 2011-05-06 change that substituted uintptr_t
5651 for EMACS_INT. This case wasn't caught back then.
5652
37910ab2
PE
5653 Rework Fformat to avoid integer overflow issues.
5654 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5655 now (part of C89). Include <verify.h>.
5656 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5657 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5658 (Fformat): Avoid the prepass trying to compute sizes; it was only
5659 approximate and thus did not catch overflow reliably. Instead, walk
5660 through the format just once, formatting and computing sizes as we go,
5661 checking for integer overflow at every step, and allocating a larger
5662 buffer as needed. Keep track separately whether the format is
5663 multibyte. Keep only the most-recently calculated precision, rather
5664 than them all. Record whether each argument has been converted to
5665 string. Use EMACS_INT, not int, for byte and char and arg counts.
5666 Support field widths and precisions larger than INT_MAX. Avoid
5667 sprintf's undefined behavior with conversion specifications such as %#d
5668 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5669 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5670 formatting out-of-range floating point numbers with int
9173deec 5671 formats. (Bug#8668)
37910ab2 5672
2e6578fb
PE
5673 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5674
0ae6bdee
PE
5675 * data.c: Avoid integer truncation in expressions involving floats.
5676 * data.c: Include <intprops.h>.
5677 (arith_driver): When there's an integer overflow in an expression
5678 involving floating point, convert the integers to floating point
5679 so that the resulting value does not suffer from catastrophic
5680 integer truncation. For example, on a 64-bit host (* 4
5681 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5682 Do not rely on undefined behavior after integer overflow.
5683
de883a70
PE
5684 merge count_size_as_multibyte, parse_str_to_multibyte
5685 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5686 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5687 Check for integer overflow.
5688 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5689 since it's now a duplicate of the other. This is more of
5690 a character than a buffer op, so better that it's in character.c.
5691 * fns.c, print.c: Adjust to above changes.
5692
2ff916cb
PE
56932011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5694
5695 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5696
f1b54466
PE
56972011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5698
fb1ac845
PE
5699 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5700 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5701 (x_clipboard_manager_save): Now static.
5702 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5703
f1b54466
PE
5704 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5705 (crypto_hash_function): Now static.
5706 Fix pointer signedness problems. Avoid unnecessary initializations.
5707
a9f737ee
CY
57082011-05-27 Chong Yidong <cyd@stupidchicken.com>
5709
5710 * termhooks.h (Vselection_alist): Make it terminal-local.
5711
5712 * terminal.c (create_terminal): Initialize it.
5713
5714 * xselect.c: Support for clipboard managers.
5715 (Vselection_alist): Move to termhooks.h as terminal-local var.
5716 (LOCAL_SELECTION): New macro.
5717 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5718 (symbol_to_x_atom): Remove gratuitous arg.
5719 (x_handle_selection_request, lisp_data_to_selection_data)
5720 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5721 (x_own_selection, x_get_local_selection, x_convert_selection):
5722 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5723 (some_frame_on_display): Delete unused function.
5724 (Fx_own_selection_internal, Fx_get_selection_internal)
5725 (Fx_disown_selection_internal, Fx_selection_owner_p)
5726 (Fx_selection_exists_p): New optional frame arg.
5727 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5728 (x_handle_selection_clear): Don't treat other terminals with the
5729 same keyboard specially. Use the terminal-local Vselection_alist.
5730 (x_clear_frame_selections): Use Frun_hook_with_args.
5731
5732 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5733
5734 * xterm.h: Add support for those atoms.
5735
e067f0c1
CY
57362011-05-26 Chong Yidong <cyd@stupidchicken.com>
5737
5738 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5739 (converted_selections, conversion_fail_tag): New global variables.
5740 (x_selection_request_lisp_error): Free the above.
5741 (x_get_local_selection): Remove unnecessary code.
5742 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5743 of converted selections stored in converted_selections.
5744 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5745 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5746 (x_convert_selection): New function.
5747 (x_handle_selection_event): Simplify.
5748 (x_get_foreign_selection): Don't ignore incoming requests while
5749 waiting for an answer; this will fail when we implement
5750 SAVE_TARGETS, and seems unnecessary anyway.
5751 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5752 (Vx_sent_selection_functions): Doc fix.
5753
0f4aebc0
LL
57542011-05-26 Leo Liu <sdl.web@gmail.com>
5755
5756 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5757
e61124cd
YM
57582011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5759
5760 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5761
5762 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5763 for fringe update if it has periodic bitmap.
ac389d0c 5764 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5765 and fringe_bitmap_periodic_p.
5766
5767 * fringe.c (get_fringe_bitmap_data): New function.
5768 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5769 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5770 row. Mark glyph row for fringe update if periodicity changed.
5771
5772 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5773 for fringe update unless it has periodic bitmap.
5774
f16d9837
KH
57752011-05-25 Kenichi Handa <handa@m17n.org>
5776
5777 * xdisp.c (get_next_display_element): Set correct it->face_id for
5778 a static composition.
5779
e1b90ef6
LL
57802011-05-24 Leo Liu <sdl.web@gmail.com>
5781
5782 * deps.mk (fns.o):
5783 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5784
5785 * fns.c (crypto_hash_function, Fsha1): New function.
5786 (Fmd5): Use crypto_hash_function.
5787 (syms_of_fns): Add Ssha1.
5788
7400048f
PE
57892011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5790
5791 * gnutls.c: Remove unused macros.
5792 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5793 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5794 Remove macros that are defined and never used.
5795 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5796
abb71cf4
CY
57972011-05-22 Chong Yidong <cyd@stupidchicken.com>
5798
5799 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5800 (Fx_get_selection_internal): Minor cleanup.
5801 (Fx_own_selection_internal): Rename arguments for consistency with
5802 select.el.
5803
6307db39
PE
58042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5805
5806 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5807
f3d4e0a4
CY
58082011-05-22 Chong Yidong <cyd@stupidchicken.com>
5809
5810 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5811
4d8ade89
YM
58122011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5813
5814 * dispnew.c (scrolling_window): Don't exclude the case that the
5815 last enabled row in the desired matrix touches the bottom boundary.
5816
32078c8d
GM
58172011-05-21 Glenn Morris <rgm@gnu.org>
5818
5819 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5820 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5821 and add some more files.
32078c8d 5822
7285dc67
EZ
58232011-05-20 Eli Zaretskii <eliz@gnu.org>
5824
5825 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5826 report_file_error introduced by the change from 2011-05-07.
5827
89d1bd22
PE
58282011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5829
5830 * systime.h (Time): Define only if emacs is defined.
5831 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5832 where the include path doesn't have X11/X.h by default. See
5833 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5834
cd394be1 58352011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5836
5837 * composite.c (find_automatic_composition): Fix previous change.
5838
b9704ad9
GM
58392011-05-20 Glenn Morris <rgm@gnu.org>
5840
5841 * lisp.mk: New file, split from Makefile.in.
5842 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5843 (shortlisp): Remove.
5844 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5845
4a720484
GM
58462011-05-19 Glenn Morris <rgm@gnu.org>
5847
5848 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5849 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5850 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5851 (lisp): Set the order to that of loadup.el.
5852 (shortlisp): Make it a copy of $lisp.
5853 (SOME_MACHINE_LISP): Remove.
5854 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5855 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5856
a28d4396
KH
58572011-05-18 Kenichi Handa <handa@m17n.org>
5858
5859 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5860 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5861 (find_automatic_composition): Mostly rewrite for efficiency.
5862
a2b1fa8e
JB
58632011-05-18 Juanma Barranquero <lekktu@gmail.com>
5864
5865 * makefile.w32-in: Update dependencies.
5866
8e1f5610
CS
58672011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5868
5869 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5870 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5871
7025ee00 58722011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5873
cdfa6eab
PE
5874 Fix some integer overflow issues, such as string length overflow.
5875
06d6db33
PE
5876 * insdel.c (count_size_as_multibyte): Check for string overflow.
5877
2b4560a8
PE
5878 * character.c (lisp_string_width): Check for string overflow.
5879 Use EMACS_INT, not int, for string indexes and lengths; in
5880 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5881 the resulting string length overflows an EMACS_INT; instead,
5882 report a string overflow if no precision given. When checking for
5883 precision exhaustion, use a check that cannot possibly have
5884 integer overflow. (Bug#8675)
5885 * character.h (lisp_string_width): Adjust to new signature.
5886
cb93f9be
PE
5887 * alloc.c (string_overflow): New function.
5888 (Fmake_string): Use it. This doesn't change behavior, but saves
5889 a few bytes and will simplify future changes.
5890 * character.c (string_escape_byte8): Likewise.
5891 * lisp.h (string_overflow): New decl.
5892
1a1f3366
PE
5893 Fixups, following up to the user-interface timestamp change.
5894 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5895 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5896 * msdos.c (mouse_get_pos): Likewise.
5897 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5898 * w32gui.h (Time): Define by including "systime.h" rather than by
5899 declaring it ourselves. (Bug#8664)
5900
d4e3e4d3
PE
5901 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5902 * image.c (clear_image_cache): Likewise.
5903
f6a24d19
PE
5904 * term.c (term_mouse_position): Don't assume time_t wraparound.
5905
08dc5ae6
PE
5906 Be more systematic about user-interface timestamps.
5907 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5908 and sometimes 'EMACS_UINT', to represent these timestamps.
5909 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5910 This makes the code easier to follow, and makes it easier to catch
5911 integer overflow bugs such as Bug#8664.
5912 * frame.c (Fmouse_position, Fmouse_pixel_position):
5913 Use Time, not unsigned long, for user-interface timestamps.
5914 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5915 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5916 * keyboard.h (last_event_timestamp): Likewise.
5917 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5918 * menu.h (xmenu_show): Likewise.
5919 * term.c (term_mouse_position): Likewise.
5920 * termhooks.h (struct input_event.timestamp): Likewise.
5921 (struct terminal.mouse_position_hook): Likewise.
5922 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5923 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5924 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5925 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5926 what it was before.
5927 * menu.h, termhooks.h: Include "systime.h", for Time.
5928
8e55734a
PE
5929 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5930 Don't assume that the difference between two unsigned long values
5931 can fit into an integer. At this point, we know button_down_time
5932 <= event->timestamp, so the difference must be nonnegative, so
5933 there's no need to cast the result if double-click-time is
5934 nonnegative, as it should be; check that it's nonnegative, just in
5935 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5936 apart (about 25 days). (Bug#8664)
8e55734a 5937
841f1b75 5938 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5939 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5940
3e26f69c
PE
5941 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5942 that always fit in int. Use a sentinel instead of a counter, to
5943 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5944 * frame.h (struct frame): Use int for menu_bar_items_used
5945 instead of EMACS_INT, since it always fits in int.
3e26f69c 5946
5cc152c0
PE
5947 * menu.c (grow_menu_items): Check for int overflow.
5948
d89eb65e
PE
5949 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5950
5235bd3e
PE
5951 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5952 Before, the code was not consistent. These values cannot exceed
5953 2**31 - 1 so there's no need to make them unsigned.
5954 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5955 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5956 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5957 as modifiers.
5958 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5959
bc827e23
PE
5960 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5961 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5962 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5963 presumably because the widths might not match.
5964
78eb494e
PE
5965 * window.c (size_window): Avoid needless test at loop start.
5966
04f2d78b
CB
59672011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5968
5969 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5970
d2fc7e3d 59712011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5972
5973 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5974
d2fc7e3d 59752011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5976
5977 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5978 `width' to `bar_area_x' and `bar_area_width', respectively.
5979 (x_scroll_run): Take account of fringe background extension.
5980
04f2d78b
CB
5981 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5982 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5983 `bar_area_width', respectively.
5984 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5985 background extension.
5986
79b70037
GM
59872011-05-10 Jim Meyering <meyering@redhat.com>
5988
5989 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5990
2f142cc5
JB
59912011-05-10 Juanma Barranquero <lekktu@gmail.com>
5992
5993 * image.c (Finit_image_library): Return t for built-in image types,
5994 like pbm and xbm. (Bug#8640)
5995
57679c86
AS
59962011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5997
5998 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5999
888c9e86
EZ
60002011-05-07 Eli Zaretskii <eliz@gnu.org>
6001
b0512a1d
EZ
6002 * w32console.c (Fset_screen_color): Doc fix.
6003 (Fget_screen_color): New function.
6004 (syms_of_ntterm): Defsubr it.
6005
7285dc67
EZ
6006 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6007 unlink the temporary file if Fcall_process didn't create it in the
6008 first place.
6009 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6010 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6011 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6012 cue to call_process_cleanup not to close that handle.
6013
4d3fcc8e
BK
60142011-05-07 Ben Key <bkey76@gmail.com>
6015
6016 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6017 one of two shell specific rules, either bootstrap-temacs-CMD or
6018 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6019 to the previous implementation of the bootstrap-temacs rule.
6020 The bootstrap-temacs-CMD rule is similar to the previous
6021 implementation of the bootstrap-temacs rule except that it
6022 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6023 variable.
6024
6025 These changes, along with some changes to nt/configure.bat,
6026 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6027 earlier fix to add support for --cflags and --ldflags options
6028 that include quotes so that it works whether make uses cmd or
6029 sh as the shell.
6030
b4289b64
MA
60312011-05-06 Michael Albinus <michael.albinus@gmx.de>
6032
6033 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6034 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6035 is a constant.
6036 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6037 a string. Handle both cases.
6038 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6039 (Fdbus_register_method): Use Qinvalid_function.
6040
af4c0e28
JB
60412011-05-06 Juanma Barranquero <lekktu@gmail.com>
6042
6043 * makefile.w32-in: Update dependencies.
6044 (LISP_H): Add inttypes.h and stdin.h.
6045 (PROCESS_H): Add unistd.h.
6046
c51453d9
EZ
60472011-05-06 Eli Zaretskii <eliz@gnu.org>
6048
6049 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6050 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6051
8ff0ac3c 60522011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6053
4c4b566b
PE
6054 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6055
aab2b9b5
PE
6056 * term.c (vfatal): Remove stray call to va_end.
6057 It's not needed and the C Standard doesn't allow it here anyway.
6058
c378da0b
PE
6059 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6060 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6061
288b08c7
PE
6062 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6063 bytes.
6064
e3601888
PE
6065 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6066
db6c0e74
PE
6067 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6068
dd5963ea
PE
6069 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6070
88c9450f
PE
6071 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6072
2f9442b8
PE
6073 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6074
c032b5f8
PE
6075 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6076 * charset.c (Fdefine_charset_internal): Don't initialize
6077 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6078 32-bit int (Bug#8600).
a108c10b
PE
6079
6080 * lread.c (read_integer): Be more consistent with string-to-number.
6081 Use string_to_number to do the actual conversion; this avoids
6082 rounding errors and fixes some other screwups. Without this fix,
6083 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6084 (digit_to_number): Move earlier, for benefit of read_integer.
6085 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6086 not a digit in any supported base. (Bug#8602)
a108c10b 6087
ad5f9eea
PE
6088 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6089
aec1708a
PE
6090 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6091 to match comment at start of function. This also removes a
6092 GCC warning about overflow in a 32+64-bit port.
6093
47be4ab5
PE
6094 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6095
371cac43
PE
6096 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6097 Reported by Stefan Monnier in
6098 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6099 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6100 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6101
d01a7826
PE
6102 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6103 (EMACS_UINTPTR): Likewise, with uintptr_t.
6104
7fd47d5c
PE
6105 * lisp.h: Prefer 64-bit EMACS_INT if available.
6106 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6107 on 32-bit hosts that have 64-bit int, so that they can access
6108 large files.
122b0c86
PE
6109 However, temporarily disable this change unless the temporary
6110 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6111
8727937b
PE
6112 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6113
8ac068ac
PE
6114 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6115 This removes an assumption that EMACS_INT and long are the same
6116 width as pointers. The assumption is true for Emacs porting targets
6117 now, but we want to make other targets possible.
6118 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6119 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6120 In the rest of the code, change types of integers that hold casted
6121 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6122 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6123 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6124 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6125 No need to cast type when ORing.
6126 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6127 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6128 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6129 assume EMACS_INT is the same width as char *.
6130 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6131 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6132 Remove no-longer-needed casts.
6133 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6134 (xg_tool_bar_help_callback, xg_make_tool_item):
6135 Use EMACS_INTPTR to hold an integer
6136 that will be cast to void *; this can avoid a GCC warning
6137 if EMACS_INT is not the same width as void *.
6138 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6139 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6140 (current_message_1, set_message_1):
6141 Use a local to convert to proper width without a cast.
6142 * xmenu.c (dialog_selection_callback): Likewise.
6143
ede49d71
PE
6144 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6145 Also, don't assume VALBITS / RAND_BITS is less than 5,
6146 and don't rely on undefined behavior when shifting a 1 left into
6147 the sign bit.
6148 * lisp.h (get_random): Change signature to match.
6149
2f30ecd0
PE
6150 * lread.c (hash_string): Use size_t, not int, for hash computation.
6151 Normally we prefer signed values; but hashing is special, because
6152 it's better to use unsigned division on hash table sizes so that
6153 the remainder is nonnegative. Also, size_t is the natural width
6154 for hashing into memory. The previous code used 'int', which doesn't
6155 retain enough info to hash well into very large tables.
6156 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6157
2a866e7b
PE
6158 * dbusbind.c: Don't possibly lose pointer info when converting.
6159 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6160 Use XPNTR rather than XHASH, so that the high-order bits of
6161 the pointer aren't lost when converting through void *.
6162
51639eac
PE
6163 * eval.c (Fautoload): Don't double-shift a pointer.
6164
92394119
PE
6165 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6166
dbdb9a7c
JB
61672011-05-06 Juanma Barranquero <lekktu@gmail.com>
6168
6169 * gnutls.c (DEF_GNUTLS_FN):
6170 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6171
db7a0b4f
AS
61722011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6173
6174 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6175 marker. (Bug#8610)
6176
cd394be1 61772011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6178
6179 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6180 New version that can reserve upto 2GB of heap space.
6181
f7ff1b0f 61822011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6183
6184 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6185
639c109b
TZ
61862011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6187
6188 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6189 `gnutls_certificate_set_x509_key_file'.
6190
d2127135
JB
61912011-05-05 Juanma Barranquero <lekktu@gmail.com>
6192
6193 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6194 Update dependencies.
6195
e968f4f3
JB
61962011-05-04 Juanma Barranquero <lekktu@gmail.com>
6197
6198 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6199 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6200 Remove unused parameter `fildes'.
6201 * process.c (read_process_output, send_process): Don't pass it.
6202
84d358f0
JB
62032011-05-04 Juanma Barranquero <lekktu@gmail.com>
6204
6205 Fix previous change: the library cache is defined in w32.c.
6206 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6207 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6208
0898ca10
JB
62092011-05-04 Juanma Barranquero <lekktu@gmail.com>
6210
6211 Implement dynamic loading of GnuTLS on Windows.
6212
6213 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6214 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6215 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6216 Declare.
6217
6218 * gnutls.c (Qgnutls_dll): Define.
6219 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6220 (gnutls_*): Declare function pointers.
6221 (init_gnutls_functions): New function to initialize function pointers.
6222 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6223 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6224 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6225 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6226 (emacs_gnutls_write, emacs_gnutls_read)
6227 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6228 (Fgnutls_available_p): New function.
6229 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6230 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6231 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6232
6233 * image.c: Include w32.h.
6234 (Vimage_type_cache): Delete.
6235 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6236 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6237 (w32_delayed_load): Move to w32.c.
6238
6239 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6240
6241 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6242 (w32_delayed_load): Move from image.c. When loading a library, record
6243 its filename in the :loaded-from property of the library id.
6244 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6245 Initialize and staticpro them.
6246 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6247
6248 * process.c: Include lisp.h before w32.h, not after.
6249 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6250 instead of gnutls_record_check_pending.
6251
6252 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6253
ff4de4aa
TZ
62542011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6255
6256 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6257 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6258 as passed in.
6259
abe95abb
JD
62602011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6261
6262 * xterm.c (x_set_frame_alpha): Do not set property on anything
6263 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6264
e16e55d4
JB
62652011-05-02 Juanma Barranquero <lekktu@gmail.com>
6266
6267 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6268
bafcf6a5
JB
62692011-05-02 Juanma Barranquero <lekktu@gmail.com>
6270
6271 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6272 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6273 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6274 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6275 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6276 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6277 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6278 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6279 (Qgnutls_bootprop_callbacks_verify): Make static.
6280
e7a6747f
AS
62812011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6282
19ed11ba
AS
6283 * callproc.c: Indentation fixup.
6284
e7a6747f 6285 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6286 (wait_for_termination, interruptible_wait_for_termination):
6287 Move after wait_for_termination_1.
e7a6747f 6288
1ef14cb4
LMI
62892011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6290
6291 * sysdep.c (interruptible_wait_for_termination): New function
6292 which is like wait_for_termination, but allows keyboard
6293 interruptions.
6294
6295 * callproc.c (Fcall_process): Add (:file "file") as an option for
6296 the STDOUT buffer.
6297 (Fcall_process_region): Ditto.
6298
330d880c
EZ
62992011-04-30 Eli Zaretskii <eliz@gnu.org>
6300
8db90b73
EZ
6301 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6302 rather than `XVECTOR (FOO)->size'.
6303
330d880c
EZ
6304 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6305 inttypes.h, as a gnulib replacement is used if it not available in
6306 system headers.
6307
15cbd324
EZ
63082011-04-21 Eli Zaretskii <eliz@gnu.org>
6309
6310 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6311 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6312 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6313
6314 * coding.c (coding_alloc_by_realloc): Error out if destination
6315 will grow beyond MOST_POSITIVE_FIXNUM.
6316 (decode_coding_emacs_mule): Abort if there isn't enough place in
6317 charbuf for the composition carryover bytes. Reserve an extra
6318 space for up to 2 characters produced in a loop.
6319 (decode_coding_iso_2022): Abort if there isn't enough place in
6320 charbuf for the composition carryover bytes.
6321
63222011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6323
ae940cca
EZ
6324 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6325 aborting when %lld or %lll format is passed.
6326 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6327 %llo or %llx format is passed. (Bug#8545)
6328
03ab8921
EZ
6329 * window.c (window_scroll_line_based): Use a marker instead of
6330 simple variables to record original value of point. (Bug#7952)
6331
afda1437
EZ
6332 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6333 produced by %s or %c overflows available buffer space. (Bug#8545)
6334
f76dee0c
PE
63352011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6336
6337 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6338 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6339
fdc5744d
JB
63402011-04-28 Juanma Barranquero <lekktu@gmail.com>
6341
6342 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6343
638f053a
JB
63442011-04-28 Juanma Barranquero <lekktu@gmail.com>
6345
6346 * keyboard.c (Qdelayed_warnings_hook): Define.
6347 (command_loop_1): Run `delayed-warnings-hook'
6348 if Vdelayed_warnings_list is non-nil.
6349 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6350 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6351
d178f871
EZ
63522011-04-28 Eli Zaretskii <eliz@gnu.org>
6353
6354 * doprnt.c (doprnt): Don't return value smaller than the buffer
6355 size if the message was truncated. (Bug#8545).
6356
b124fd93
JB
63572011-04-28 Juanma Barranquero <lekktu@gmail.com>
6358
6359 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6360 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6361
e810457d
PE
63622011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6363
6364 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6365
ea51cceb
JB
63662011-04-27 Juanma Barranquero <lekktu@gmail.com>
6367
6368 * makefile.w32-in: Update dependencies.
6369
94dcfacf
EZ
63702011-04-27 Eli Zaretskii <eliz@gnu.org>
6371
6372 Improve `doprnt' and its usage. (Bug#8545)
6373 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6374 `format_end'. Remove support for %l as a conversion specifier.
6375 Don't use xrealloc. Improve diagnostics when the %l size modifier
6376 is used. Update the commentary.
6377
6378 * eval.c (verror): Simplify calculation of size_t.
6379
6380 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6381 messages.
6382
f61f41d7
PE
63832011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6384
6385 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6386 change.
6387
96fb4434
PE
63882011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6389
6390 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6391 This makes this file independent of the recent pseudovector change.
6392
671875da 63932011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6394
69e9b5a3
PE
6395 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6396
b5f869a7 6397 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6398 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6399 Remove unused local.
c8926152 6400 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6401
841a1577 6402 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6403 GCC 4.6.0 optimizes based on type-based alias analysis.
6404 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6405 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6406 != &v->size, and therefore "v->size = 1; b->size = 2; return
6407 v->size;" must therefore return 1. This assumption is incorrect
6408 for Emacs, since it type-puns struct Lisp_Vector * with many other
6409 types. To fix this problem, this patch adds a new type struct
f904488f 6410 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6411 and pseudovectors, and helps optimizing compilers not get fooled
6412 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6413 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6414 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6415 the size member.
eab3844f
PE
6416 (XSETPVECTYPE): Rewrite in terms of new macro.
6417 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6418 This is a bit clearer, and further avoids the possibility of
6419 undesirable aliasing.
6420 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6421 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6422 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6423 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6424 (ASIZE): Now uses header.size rather than size.
6425 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6426 to avoid the hassle of writing XVECTOR (foo)->header.size.
6427 (struct vectorlike_header): New type.
eab3844f
PE
6428 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6429 object, to help avoid aliasing.
6430 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6431 (SUBRP): Likewise, since Lisp_Subr is a special case.
6432 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6433 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6434 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6435 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6436 changed to be "header.size" and "header.next".
6437 * buffer.h (struct buffer): Likewise.
6438 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6439 * frame.h (struct frame): Likewise.
6440 * process.h (struct Lisp_Process): Likewise.
6441 * termhooks.h (struct terminal): Likewise.
6442 * window.c (struct save_window_data, struct saved_window): Likewise.
6443 * window.h (struct window): Likewise.
6444 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6445 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6446 * buffer.c (init_buffer_once): Likewise.
6447 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6448 special case.
6449 * process.c (Fformat_network_address): Use local var for size,
6450 for brevity.
6451
0df1eac5
PE
6452 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6453
847ab9d1 6454 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6455 * data.c (atof): Remove decl; no longer used or needed.
6456 (digit_to_number): Move to lread.c.
6457 (Fstring_to_number): Use new string_to_number function, to be
6458 consistent with how the Lisp reader treats infinities and NaNs.
6459 Do not assume that floating-point numbers represent EMACS_INT
6460 without losing information; this is not true on most 64-bit hosts.
6461 Avoid double-rounding errors, by insisting on integers when
6462 parsing non-base-10 numbers, as the documentation specifies.
6463 * lisp.h (string_to_number): New decl, replacing ...
6464 (isfloat_string): Remove.
bc0a5c13 6465 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6466 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6467 appears to have been a coding error. Similarly, do not accept
6468 strings like +-1e0 as floating point numbers. Do not report
6469 overflow for integer overflows unless the base is not 10 which
6470 means we have no simple and reliable way to continue.
6471 Break out the floating-point parsing into a new
6472 function string_to_number, so that Fstring_to_number parses
6473 floating point numbers consistently with the Lisp reader.
04f2d78b 6474 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6475 (E_CHAR, EXP_INT): Remove, replacing with ...
6476 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6477 (string_to_number): New function, replacing isfloat_string.
6478 This function checks for valid syntax and produces the resulting
6479 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6480 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6481 so that overflow for non-base-10 numbers is reported only when
6482 there's no portable and simple way to convert to floating point.
452f4150 6483
67769ffc
PE
6484 * textprop.c (set_text_properties_1): Rewrite for clarity,
6485 and to avoid GCC warning about integer overflow.
6486
c20db43f
PE
6487 * intervals.h (struct interval): Use EMACS_INT for members
6488 where EMACS_UINT might cause problems. See
6489 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6490 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6491 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6492 All uses changed.
37aa2f85
PE
6493 (offset_intervals): Tell GCC not to worry about length overflow
6494 when negating a negative length.
c20db43f 6495
2538aa2f
PE
6496 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6497 (overrun_check_free): Likewise.
6498
f2d3008d
PE
6499 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6500 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6501 word size.
6502
ec8df744
PE
6503 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6504 (gnutls_make_error): Rename local to avoid shadowing.
6505 (gnutls_emacs_global_deinit): ifdef out; not used.
6506 (Fgnutls_boot): Use const for pointer to readonly storage.
6507 Comment out unused local. Fix pointer signedness problems.
6508
640ee02d
PE
6509 * lread.c (openp): Don't stuff size_t into an 'int'.
6510 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6511 about possible signed overflow.
6512
6048fb2a
PE
6513 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6514 (GDK_KEY_g): Don't define if already defined.
6515 (xg_prepare_tooltip): Avoid pointer signedness problem.
6516 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6517
fa3c87e1
PE
6518 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6519 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6520
2172544b
PE
6521 * xfns.c (Fx_window_property): Simplify a bit,
6522 to make a bit faster and to avoid GCC 4.6.0 warning.
6523 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6524
9b821a21
PE
6525 * fns.c (internal_equal): Don't assume size_t fits in int.
6526
3c616cfa
PE
6527 * alloc.c (compact_small_strings): Tighten assertion a little.
6528
c2982e87
PE
6529 Replace pEd with more-general pI, and fix some printf arg casts.
6530 * lisp.h (pI): New macro, generalizing old pEd macro to other
6531 conversion specifiers. For example, use "...%"pI"d..." rather
6532 than "...%"pEd"...".
6533 (pEd): Remove. All uses replaced with similar uses of pI.
6534 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6535 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6536 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6537 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6538 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6539 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6540 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6541 64-bit hosts.
6542 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6543 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6544 * print.c (safe_debug_print, print_object): Likewise.
6545 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6546 to int.
6f04d126
PE
6547 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6548 avoiding the 0 flag, which is not portable.
c2982e87
PE
6549 * process.c (Fmake_network_process): Use pI to avoid cast.
6550 * region-cache.c (pp_cache): Likewise.
6551 * xdisp.c (decode_mode_spec): Likewise.
6552 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6553 behavior on 64-bit hosts with printf arg.
6f04d126 6554 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6555 (x_stop_queuing_selection_requests): Likewise.
6556 (x_get_window_property): Don't truncate byte count to an 'int'
6557 when tracing.
0b432f21 6558
5e073ec7
PE
6559 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6560 here, since it parses constructs like leading '-' and spaces,
6561 which are not wanted; and it overflows with large numbers.
6562 Instead, simply match F[0-9]+, which is what is wanted anyway.
6563
36372bf9
PE
6564 * alloc.c: Remove unportable assumptions about struct layout.
6565 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6566 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6567 (allocate_vectorlike, make_pure_vector): Use the new macros,
6568 plus offsetof, to remove unportable assumptions about struct layout.
6569 These assumptions hold on all porting targets that I know of, but
6570 they are not guaranteed, they're easy to remove, and removing them
6571 makes further changes easier.
6572
0b432f21
PE
6573 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6574 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6575 (string_overrun_cookie): Now const. Use initializers that
6576 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6577 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6578 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6579 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6580 multiple of sizeof (EMACS_INT); it need not be, if
6581 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6582 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6583
895009e1
JB
65842011-04-26 Juanma Barranquero <lekktu@gmail.com>
6585
6586 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6587
6a7a1b0b
TZ
65882011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6589
6590 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6591 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6592 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6593
841a1577 65942011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6595
6596 * lisp.h (Qdebug): List symbol.
895009e1 6597 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6598 * keyboard.c (debug-on-event): New variable.
6599 (handle_user_signal): Break into debugger when debug-on-event
6600 matches the current signal symbol.
6601
f2d3ba6f
DN
66022011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6603
6604 * alloc.c (check_sblock, check_string_bytes)
6605 (check_string_free_list): Convert to standard C.
6606
42ce4c63
TZ
66072011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6608
6609 * w32.c (emacs_gnutls_push): Fix typo.
6610
825cd63c
EZ
66112011-04-25 Eli Zaretskii <eliz@gnu.org>
6612
fb11d64d
EZ
6613 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6614 "cast to pointer from integer of different size".
6615
825cd63c
EZ
6616 Improve doprnt and its use in verror. (Bug#8545)
6617 * doprnt.c (doprnt): Document the set of format control sequences
6618 supported by the function. Use SAFE_ALLOCA instead of always
6619 using `alloca'.
6620
6621 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6622 is one byte too soon. Don't use xrealloc; instead xfree and
6623 xmalloc anew.
6624
e061a11b
TZ
66252011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6626
6627 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6628 callbacks stage.
6629
6630 * gnutls.c: Renamed global_initialized to
6631 gnutls_global_initialized. Added internals for the
6632 :verify-hostname-error, :verify-error, and :verify-flags
6633 parameters of `gnutls-boot' and documented those parameters in the
6634 docstring. Start callback support.
9173deec
JB
6635 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6636 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6637 on error. Return error code.
e061a11b
TZ
6638 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6639 (emacs_gnutls_read): Likewise.
6640 (Fgnutls_boot): Return handshake error code.
6641 (emacs_gnutls_handle_error): New function.
6642 (wsaerror_to_errno): Likewise.
6643
6644 * w32.h (emacs_gnutls_pull): Add prototype.
6645 (emacs_gnutls_push): Likewise.
6646
6647 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6648 (emacs_gnutls_push): Likewise.
6649
66502011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6651
6652 * process.c (wait_reading_process_output): Check if GnuTLS
6653 buffered some data internally if no FDs are set for TLS
6654 connections.
6655
6656 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6657 (LIBS): Link to USER_LIBS.
6658 ($(BLD)/gnutls.$(0)): New target.
6659
fa6996bc
EZ
66602011-04-24 Eli Zaretskii <eliz@gnu.org>
6661
eb35682e
EZ
6662 * xdisp.c (handle_single_display_spec): Rename the
6663 display_replaced_before_p argument into display_replaced_p, to
6664 make it consistent with the commentary. Fix typos in the
6665 commentary.
6666
e2ad650c
EZ
6667 * textprop.c (syms_of_textprop): Remove dead code.
6668 (copy_text_properties): Delete obsolete commentary about an
6669 interface that was deleted long ago. Fix typos in the description
6670 of arguments.
6671
1b2de274
EZ
6672 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6673 to changes in oldXMenu/XMenu.h from 2011-04-16.
6674 <menu_help_message, prev_menu_help_message>: Constify.
6675 (IT_menu_make_room): menu->help_text is now `const char **';
6676 adjust.
6677
6678 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6679 to changes in oldXMenu/XMenu.h from 2011-04-16.
6680 (struct XMenu): Declare `help_text' `const char **'.
6681
6682 * xfaces.c <Qunspecified>: Make extern again.
6683
6684 * syntax.c: Include sys/types.h before including regex.h, as
6685 required by Posix.
6686
762b15be
EZ
6687 * doc.c (get_doc_string): Improve the format passed to `error'.
6688
6689 * doprnt.c (doprnt): Improve commentary.
6690
6691 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6692
6693 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6694 them with etags.
6695
f1052e5d
EZ
6696 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6697 changes in globals.h immediately force recompilation.
762b15be
EZ
6698 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6699 $(CURDIR)/s/ms-w32.h.
6700 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6701
fa6996bc
EZ
6702 * character.c (Fchar_direction): Function deleted.
6703 (syms_of_character): Don't defsubr it.
6704 <char-direction-table>: Deleted.
6705
e6c3da20
EZ
67062011-04-23 Eli Zaretskii <eliz@gnu.org>
6707
6708 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6709 * doprnt.c: Include limits.h.
6710 (SIZE_MAX): New macro.
04f2d78b
CB
6711 (doprnt): Return a size_t value. 2nd arg is now size_t.
6712 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6713 Improve overflow protection. Support `l' modifier for integer
6714 conversions. Support %l conversion. Don't assume an EMACS_INT
6715 argument for integer conversions and for %c.
6716
6717 * lisp.h (doprnt): Restore prototype.
6718
6719 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6720 $(SRC)/character.h.
6721
6722 * Makefile.in (base_obj): Add back doprnt.o.
6723
6724 * deps.mk (doprnt.o): Add back prerequisites.
6725 (callint.o): Depend on character.h.
6726
6727 * eval.c (internal_lisp_condition_case): Include the handler
6728 representation in the error message.
6729 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6730 when breaking from the loop.
6731
6732 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6733
6734 * callint.c (Fcall_interactively): When displaying error message
6735 about invalid control letter, pass the character's codepoint, not
6736 a pointer to its multibyte form. Improve display of the character
6737 in octal and display also its hex code.
6738
6739 * character.c (char_string): Use %x to display the (unsigned)
6740 codepoint of an invalid character, to avoid displaying a bogus
6741 negative value.
6742
6743 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6744 `error', not SYMBOL_NAME itself.
6745
6746 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6747 character arguments to `error'.
6748
6749 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6750 to `error' in error message about FINAL_CHAR argument. Make sure
6751 FINAL_CHAR is a character, and use %c when it is passed as
6752 argument to `error'.
6753
4ffd0d6b 67542011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6755
6756 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6757
6758 * w32.c: Include <time.h>.
6759 (sys_localtime): New function.
6760
4ffd0d6b 67612011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6762
6763 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6764
4ffd0d6b 6765 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6766
4ffd0d6b 67672011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6768
4ffd0d6b
GM
6769 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6770 zombies (Bug#8467).
aac0c6e3 6771
04c56954
EZ
67722011-04-19 Eli Zaretskii <eliz@gnu.org>
6773
6774 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6775 gl_state.e_property when gl_state.object is Qt.
6776
6777 * insdel.c (make_gap_larger): Remove limitation of buffer size
6778 to <= INT_MAX.
6779
16a43933
CY
67802011-04-18 Chong Yidong <cyd@stupidchicken.com>
6781
6782 * xdisp.c (lookup_glyphless_char_display)
6783 (produce_glyphless_glyph): Handle cons cell entry in
6784 glyphless-char-display.
6785 (Vglyphless_char_display): Document it.
6786
6787 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6788 glyphless-char-display.
6789
4581706e
CY
67902011-04-17 Chong Yidong <cyd@stupidchicken.com>
6791
6792 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6793
6794 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6795
6796 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6797 definition for no-X builds.
6798
4887c6e2 67992011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6800
fd35b6f9
PE
6801 Static checks with GCC 4.6.0 and non-default toolkits.
6802
5c1ccb01
PE
6803 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6804
006c5daa
PE
6805 * process.c (keyboard_bit_set): Define only if SIGIO.
6806 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6807 (send_process): Repair possible setjmp clobbering.
6808
efc736d3
PE
6809 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6810
4e2fe2e6
PE
6811 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6812
f97334a2
PE
6813 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6814
4e75f29d
PE
6815 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6816 Define only if needed.
6817
90efadd1
PE
6818 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6819 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6820 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6821
3c647824
PE
6822 * dispextern.h (struct redisplay_interface): Rename param
6823 to avoid shadowing.
e264f262 6824 * termhooks.h (struct terminal): Likewise.
761383f4 6825 * xterm.c (xembed_send_message): Likewise.
3c647824 6826
b58c5c4a
PE
6827 * insdel.c (make_gap_smaller): Define only if
6828 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6829
cad59032
PE
6830 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6831 it.
6832
c339dc2e
PE
6833 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6834 so that we aren't warned about unused symbols.
6835
91a3e27b
PE
6836 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6837
399c71d3 6838 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6839
8ffc96f5
PE
6840 * xfns.c (x_real_positions): Mark locals as initialized.
6841
eef9bc79
PE
6842 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6843
098db9dd
PE
6844 * xterm.c: Fix problems found by static analysis with other toolkits.
6845 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6846 (x_dispatch_event): Declare static if USE_GTK, and
6847 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6848 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6849 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6850 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6851 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6852
eb18f6cc
PE
6853 * xmenu.c (menu_help_callback): Pointer type fixes.
6854 Use const pointers when pointing at readonly data. Avoid pointer
6855 signedness clashes.
6856 (FALSE): Remove unused macro.
6857 (update_frame_menubar): Remove unused decl.
6858
1fe72bf8
PE
6859 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6860
60d9e1db
PE
6861 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6862 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6863 (single_menu_item): Rename local to avoid shadowing.
6864
39261c26
PE
6865 * keyboard.c (make_lispy_event): Remove unused local var.
6866
018c5e19
PE
6867 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6868 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6869
63d2b86e
PE
6870 * bitmaps: Change bitmaps from unsigned char back to the X11
6871 compatible char. Avoid the old compiler warnings about
6872 out-of-range initializers by using, for example, '\xab' rather
6873 than 0xab.
6874
aefd87e1
PE
6875 * xgselect.c (xgselect_initialize): Check vs interface
6876 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6877
bf501fb9
PE
6878 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6879
e9829fdf
PE
6880 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6881 to read-only memory.
6882
1086c095
PE
6883 * fns.c (vector): Remove; this old hack is no longer needed.
6884
2baccd04 6885 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6886 Remove unused var.
dde42981 6887 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6888
72391843 6889 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6890
436c16df 6891 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6892 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6893 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6894
92bb796d 6895 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6896 (x_term_init): Remove local to avoid shadowing.
92bb796d 6897
764430a3 6898 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6899
6900 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6901 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6902
d1dfb56c
EZ
69032011-04-16 Eli Zaretskii <eliz@gnu.org>
6904
c4354cb4
EZ
6905 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6906
d1dfb56c
EZ
6907 Fix regex.c, syntax.c and friends for buffers > 2GB.
6908 * syntax.h (struct gl_state_s): Declare character position members
6909 EMACS_INT.
6910
6911 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6912
04f2d78b
CB
6913 * textprop.c (verify_interval_modification, interval_of):
6914 Declare arguments EMACS_INT.
d1dfb56c
EZ
6915
6916 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6917 EMACS_INT.
6918
6919 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6920
6921 * indent.c (Fvertical_motion): Local variable it_start is now
6922 EMACS_INT.
6923
6924 * regex.c (re_match, re_match_2, re_match_2_internal)
6925 (bcmp_translate, regcomp, regexec, print_double_string)
6926 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6927 (re_compile_pattern, re_exec): Declare arguments and local
6928 variables `size_t' and `ssize_t' and return values `regoff_t', as
6929 appropriate.
6930 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6931 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6932 <compile_stack_type>: `size' and `avail' are now `size_t'.
6933
6934 * regex.h <regoff_t>: Use ssize_t, not int.
6935 (re_search, re_search_2, re_match, re_match_2): Arguments that
6936 specify buffer/string position and length are now ssize_t and
6937 size_t. Return type is regoff_t.
6938
613052cd
BK
69392011-04-16 Ben Key <bkey76@gmail.com>
6940
6941 * nsfont.m: Fixed bugs in ns_get_family and
6942 ns_descriptor_to_entity that were caused by using free to
6943 deallocate memory blocks that were allocated by xmalloc (via
6944 xstrdup). This caused Emacs to crash when compiled with
6945 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6946 --enable-checking=xmallocoverrun). xfree is now used to
6947 deallocate these memory blocks.
6948
4170f62f 69492011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6950
71b41406
PE
6951 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6952
9587a89d
PE
6953 emacs_write: Accept and return EMACS_INT for sizes.
6954 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6955 et seq.
6956 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6957 Accept and return EMACS_INT.
6958 (emacs_gnutls_write): Return the number of bytes written on
6959 partial writes.
6960 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6961 (emacs_read, emacs_write): Remove check for negative size, as the
6962 Emacs source code has been audited now.
9587a89d
PE
6963 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6964 (emacs_read, emacs_write): Use it.
273a5f82
PE
6965 * process.c (send_process): Adjust to the new signatures of
6966 emacs_write and emacs_gnutls_write. Do not attempt to store
6967 a byte offset into an 'int'; it might overflow.
9587a89d 6968 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6969
3e047f51
PE
6970 * sound.c: Don't assume sizes fit in 'int'.
6971 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6972 Return EMACS_INT, not int.
3e047f51 6973 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6974 Accept EMACS_INT, not int.
6975 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6976 record read return values.
6977
cc39a9db
BK
69782011-04-15 Ben Key <bkey76@gmail.com>
6979
c9d0ec6d
JB
6980 * keyboard.c (Qundefined): Don't declare static since it is used
6981 in nsfns.m.
6982 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6983 static since they are used in nsfont.m.
cc39a9db 6984
6c60eb9f
SM
69852011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6986
6987 * process.c (Qprocessp): Don't declare static.
6988 * lisp.h (Qprocessp): Declare again.
6989
7990b61a
JB
69902011-04-15 Juanma Barranquero <lekktu@gmail.com>
6991
6992 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6993
5d4cb038
PE
69942011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6995
8bd7b830 6996 Improve C-level modularity by making more things 'static'.
cd64ea1d 6997
e3b27b31
PE
6998 Don't publish debugger-only interfaces to other modules.
6999 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7000 (verify_bytepos, count_markers): Move decls to the only modules
7001 that need them.
7002 * region-cache.h (pp_cache): Likewise.
7003 * window.h (check_all_windows): Likewise.
7004 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7005
5d4cb038
PE
7006 * sysdep.c (croak): Now static, if
7007 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7008 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7009
7010 * alloc.c (refill_memory_reserve): Now static if
7011 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7012 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7013
e87b6180
PE
7014 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7015 Define only if USE_LUCID.
7016
ac64929e
PE
7017 * xrdb.c (x_customization_string, x_rm_string): Now static.
7018
6f37259d
PE
7019 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7020 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7021
1683e3ab
PE
7022 * xdisp.c (draw_row_with_mouse_face): Now static.
7023 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7024
de9c2632
PE
7025 * window.h (check_all_windows): Mark externally visible.
7026
2b96acb7
PE
7027 * window.c (window_deletion_count): Now static.
7028
7029 * undo.c: Make symbols static if they're not exported.
7030 (last_undo_buffer, last_boundary_position, pending_boundary):
7031 Now static.
7032
50436f33
PE
7033 * textprop.c (interval_insert_behind_hooks): Now static.
7034 (interval_insert_in_front_hooks): Likewise.
7035
64520e5c
PE
7036 * term.c: Make symbols static if they're not exported.
7037 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7038 (max_frame_lines, tty_set_terminal_modes):
7039 (tty_reset_terminal_modes, tty_turn_off_highlight):
7040 (get_tty_terminal): Now static.
7041 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7042 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7043 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7044 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7045 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7046
1fa53021
PE
7047 * sysdep.c: Make symbols static if they're not exported.
7048 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7049 Now static.
7050 (sigprocmask_set, full_mask): Remove; unused.
7051 (wait_debugging): Mark as visible.
7052 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7053 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7054
d4b43b22
PE
7055 * syntax.c (syntax_temp): Define only if !__GNUC__.
7056
b7c513d0
PE
7057 * sound.c (current_sound_device, current_sound): Now static.
7058
989b29ad
PE
7059 * search.c (searchbufs, searchbuf_head): Now static.
7060
13a55a78
PE
7061 * scroll.c (scroll_cost): Remove; unused.
7062 * dispextern.h (scroll_cost): Remove decl.
7063
de68a1fc
PE
7064 * region-cache.h (pp_cache): Mark as externally visible.
7065
40ccffa6
PE
7066 * process.c: Make symbols static if they're not exported.
7067 (process_tick, update_tick, create_process, chan_process):
7068 (Vprocess_alist, proc_buffered_char, datagram_access):
7069 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7070 (deactivate_process): Mark defn as static, as well as decl.
7071 * lisp.h (create_process): Remove decl.
7072 * process.h (chan_process, Vprocess_alist): Remove decls.
7073
ad64fc97
PE
7074 * print.c: Make symbols static if they're not exported.
7075 (print_depth, new_backquote_output, being_printed, print_buffer):
7076 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7077 (print_interval, print_number_index, initial_stderr_stream):
7078 Now static.
7079 * lisp.h (Fprinc): Remove decl.
7080 (debug_output_compilation_hack): Mark as externally visible.
7081
adddb265
PE
7082 * sysdep.c (croak): Move decl from here to syssignal.h.
7083 * syssignal.h (croak): Put it here, so the API can be checked when
7084 'croak' is called from dissociate_if_controlling_tty.
7085
1717ede2
PE
7086 * minibuf.c: Make symbols static if they're not exported.
7087 (minibuf_save_list, choose_minibuf_frame): Now static.
7088 * lisp.h (choose_minibuf_frame): Remove decl.
7089
fa5fb2bc
PE
7090 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7091
1e3890d1
PE
7092 * lread.c: Make symbols static if they're not exported.
7093 (read_objects, initial_obarray, oblookup_last_bucket_number):
7094 Now static.
7095 (make_symbol): Remove; unused.
7096 * lisp.h (initial_obarray, make_symbol): Remove decls.
7097
8a1414fa
PE
7098 * keyboard.c: Make symbols static if they're not exported.
7099 (single_kboard, recent_keys_index, total_keys, recent_keys):
7100 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7101 (this_single_command_key_start, echoing, last_auto_save):
7102 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7103 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7104 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7105 (Vlispy_mouse_stem, double_click_count):
7106 Now static.
7107 (force_auto_save_soon): Define only if SIGDANGER.
7108 (ignore_mouse_drag_p): Now static if
7109 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7110 (print_help): Remove; unused.
7111 (stop_character, last_timer_event): Mark as externally visible.
7112 * keyboard.h (ignore_mouse_drag_p): Declare only if
7113 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7114 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7115 * lisp.h (echoing): Remove decl.
7116 (force_auto_save_soon): Declare only if SIGDANGER.
7117 * xdisp.c (redisplay_window): Simplify code, to make it more
7118 obvious that ignore_mouse_drag_p is not accessed if !defined
7119 USE_GTK && !defined HAVE_NS.
7120
93ea6e8f
PE
7121 * intervals.c: Make symbols static if they're not exported.
7122 (merge_properties_sticky, merge_interval_right, delete_interval):
7123 Now static.
7124 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7125
77382fcc
PE
7126 * insdel.c: Make symbols static if they're not exported.
7127 However, leave prepare_to_modify_buffer alone. It's never
7128 called from outside this function, but that appears to be a bug.
7129 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7130 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7131 (adjust_after_replace_noundo): Remove; unused.
7132 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7133 (signal_before_change): Remove decls.
77382fcc 7134
9306c32e
PE
7135 * indent.c (val_compute_motion, val_vmotion): Now static.
7136
cd44d2eb
PE
7137 * image.c: Make symbols static if they're not exported.
7138 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7139 if USE_GTK.
7140 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7141 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7142
ad9a7a06
PE
7143 * fringe.c (standard_bitmaps): Now static.
7144 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7145
81626931
PE
7146 * frame.c: Make symbols static if they're not exported.
7147 (x_report_frame_params, make_terminal_frame): Now static.
7148 (get_frame_param): Now static, unless HAVE_NS.
7149 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7150 (x_get_resource_string): Remove; not used.
7151 * frame.h (make_terminal_frame, x_report_frame_params):
7152 (x_get_resource_string); Remove decls.
7153 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7154 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7155
239f9db9
PE
7156 * font.c, fontset.c: Make symbols static if they're not exported.
7157 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7158 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7159 * font.c (font_close_object): Now static.
7160 * font.h (font_close_object): Remove.
7161 * fontset.c (FONTSET_OBJLIST): Remove.
7162 (free_realized_fontset) #if-0 the body, which does nothing.
7163 (face_suitable_for_char_p): #if-0, as it's never called.
7164 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7165 * xfaces.c (face_at_string_position):
7166 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7167 since 0 is always ASCII.
7168
dfcf3579
PE
7169 * fns.c (weak_hash_tables): Now static.
7170
5045092b
PE
7171 * fileio.c: Make symbols static if they're not exported.
7172 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7173 (Vwrite_region_annotation_buffers): Now static.
7174
57a96f5c
PE
7175 * eval.c: Make symbols static if they're not exported.
7176 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7177 * lisp.h (backtrace_list): Remove decl.
7178
35f08c38
PE
7179 * emacs.c: Make symbols static if they're not exported.
7180 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7181 (fatal_error_code, fatal_error_signal_hook, standard_args):
7182 Now static.
7183 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7184 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7185 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7186 * lisp.h (fatal_error_signal_hook): Remove decl.
7187 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7188
f44bd759
PE
7189 * editfns.c: Move a (normally-unused) function to its only use.
7190 * editfns.c, lisp.h (get_operating_system_release): Remove.
7191 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7192 worth the hassle of breaking this out.
7193
b532497d
PE
7194 * xterm.c: Make symbols static if they're not exported.
7195 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7196 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7197 (x_destroy_window, x_delete_display):
7198 Now static.
7199 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7200 (x_mouse_leave): Remove; unused.
7201 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7202 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7203 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7204 Remove decls.
7205 (x_mouse_leave): Declare only if WINDOWSNT.
7206 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7207 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7208 USE_X_TOOLKIT.
7209
1675728f
PE
7210 * ftxfont.c: Make symbols static if they're not exported.
7211 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7212 HAVE_FREETYPE.
7213 * font.h (ftxfont_driver): Likewise.
7214
e4cebfca
PE
7215 * xfns.c: Make symbols static if they're not exported.
7216 (x_last_font_name, x_display_info_for_name):
7217 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7218 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7219 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7220 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7221 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7222 (last_show_tip_args): Now static.
7223 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7224 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7225 (x_screen_planes): Remove; unused.
7226 * dispextern.h (x_screen_planes): Remove decl.
7227
5bf46f05
PE
7228 * dispnew.c: Make symbols static if they're not exported.
7229 * dispextern.h (redraw_garbaged_frames, scrolling):
7230 (increment_row_positions): Remove.
7231 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7232 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7233 Now static.
7234 (redraw_garbaged_frames): Remove; unused.
7235
435f4c28
PE
7236 * xfaces.c: Make symbols static if they're not exported.
7237 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7238 Remove decls.
7239 * xterm.h (defined_color): Remove decls.
7240 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7241 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7242 (menu_face_changed_default, defined_color, free_realized_face):
7243 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7244 (ascii_face_of_lisp_face): Remove; unused.
7245
8524aef3
PE
7246 * xdisp.c: Make symbols static if they're not exported.
7247 * dispextern.h (scratch_glyph_row, window_box_edges):
7248 (glyph_to_pixel_coords, set_cursor_from_row):
7249 (get_next_display_element, set_iterator_to_next):
7250 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7251 (show_mouse_face): Remove decls
7252 * frame.h (message_buf_print): Likewise.
7253 * lisp.h (pop_message, set_message, check_point_in_composition):
7254 Likewise.
7255 * xterm.h (set_vertical_scroll_bar): Likewise.
7256 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7257 (message_buf_print, scratch_glyph_row, displayed_buffer):
7258 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7259 (get_next_display_element, show_mouse_face, window_box_edges):
7260 (frame_to_window_pixel_xy, check_point_in_composition):
7261 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7262 (glyph_to_pixel_coords): Remove; unused.
7263
16390cd2
PE
7264 * dired.c (file_name_completion): Now static.
7265
7266 * dbusbind.c (xd_in_read_queued_messages): Now static.
7267
a25f4dfa
PE
7268 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7269 * data.c (circular_list_error): Remove.
7270
14a9c8df
PE
7271 * commands.h (last_point_position, last_point_position_buffer):
7272 (last_point_position_window): Remove decls.
7273 * keyboard.c: Make these variables static.
7274
04f2d78b
CB
7275 * coding.h (coding, code_convert_region, encode_coding_gap):
7276 Remove decls.
74ab6df5
PE
7277 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7278 (iso_code_class, detect_coding, code_convert_region): Now static.
7279 (encode_coding_gap): Remove; unused.
7280
38dfbee1
PE
7281 * chartab.c (chartab_chars, chartab_bits): Now static.
7282
a2cb4e63
PE
7283 * charset.h (charset_iso_8859_1): Remove decl.
7284 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7285 Now static.
7286
127198fd
PE
7287 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7288 * ccl.c (Vccl_program_table): Now static.
7289 (check_ccl_update): Remove; unused.
7290
d85b608f
PE
7291 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7292 * category.h: ... from here.
7293 * category.c (check_category_table, set_category_set): Now static.
7294
31cd66f3
PE
7295 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7296 * lisp.h: Remove these decls.
7297
c358e587
PE
7298 * buffer.c (buffer_count): Remove unused var.
7299
e78aecca
PE
7300 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7301 so that it's not optimized away.
7302 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7303 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7304 exported only to the debugger.
7305
e192d7d3 7306 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7307 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7308
92470028
PE
7309 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7310 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7311 was inaccessible from Lisp.
7312 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7313 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7314
244ed907
PE
7315 alloc.c: Import and export fewer symbols, and remove unused items.
7316 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7317 is defined.
7318 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7319 it's not optimized away by whole-program optimization.
7320 (message_enable_multibyte, free_misc): Remove.
7321 (catchlist, handlerlist, mark_backtrace):
7322 Declare only if BYTE_MARK_STACK.
7323 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7324 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7325 (message_enable_multibyte): Remove decl.
7326 (free_misc, interval_free_list, float_block, float_block_index):
7327 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7328 (cons_free_list, last_marked_index):
7329 Now static.
7330 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7331 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7332 (mark_backtrace): Define only if BYTE_MARK_STACK.
7333 * xdisp.c (message_enable_multibyte): Now static.
7334
61c2b50e 7335 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7336 This makes it easier for human readers (and static analyzers)
7337 to see whether these variables are used from other modules.
7338 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7339 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7340 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7341 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7342 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7343 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7344 * xmenu.c, xselect.c:
7345 Declare Q* vars static if they are not used in other modules.
7346 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7347 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7348 Remove decls of unexported vars.
7349 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7350
95c82688
PE
7351 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7352
16a97296
PE
7353 Make Emacs functions such as Fatom 'static' by default.
7354 This makes it easier for human readers (and static analyzers)
7355 to see whether these functions can be called from other modules.
7356 DEFUN now defines a static function. To make the function external
7357 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7358 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7359 (Finit_image_library):
16a97296
PE
7360 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7361 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7362 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7363 Remove decls, since these functions are now static.
7364 (Funintern, Fget_internal_run_time): New decls, since these functions
7365 were already external.
95c82688 7366
16a97296
PE
7367 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7368 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7369 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7370 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7371 * keyboard.c, keymap.c, lread.c:
7372 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7373 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7374 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7375 Mark functions with DEFUE instead of DEFUN,
7376 if they are used in other modules.
7377 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7378 decls for now-static functions.
7379 * buffer.h (Fdelete_overlay): Remove decl.
7380 * callproc.c (Fgetenv_internal): Mark as internal.
7381 * composite.c (Fremove_list_of_text_properties): Remove decl.
7382 (Fcomposition_get_gstring): New forward static decl.
7383 * composite.h (Fcomposite_get_gstring): Remove decl.
7384 * dired.c (Ffile_attributes): New forward static decl.
7385 * doc.c (Fdocumntation_property): New forward static decl.
7386 * eval.c (Ffetch_bytecode): New forward static decl.
7387 (Funintern): Remove extern decl; now in .h file where it belongs.
7388 * fileio.c (Fmake_symbolic_link): New forward static decl.
7389 * image.c (Finit_image_library): New forward static decl.
7390 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7391 * intervals.h (Fprevious_property_change):
7392 (Fremove_list_of_text_properties): Remove decls.
7393 * keyboard.c (Fthis_command_keys): Remove decl.
7394 (Fcommand_execute): New forward static decl.
7395 * keymap.c (Flookup_key): New forward static decl.
7396 (Fcopy_keymap): Now static.
7397 * keymap.h (Flookup_key): Remove decl.
7398 * process.c (Fget_process): New forward static decl.
7399 (Fprocess_datagram_address): Mark as internal.
7400 * syntax.c (Fsyntax_table_p): New forward static decl.
7401 (skip_chars): Remove duplicate decl.
7402 * textprop.c (Fprevious_property_change): New forward static decl.
7403 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7404 Now internal.
7405 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7406 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7407
785bbd42
PE
7408 * editfns.c (Fformat): Remove unreachable code.
7409
8b913b57
AS
74102011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7411
7412 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7413 change. (Bug#8496)
7414
a6744a35
EZ
74152011-04-13 Eli Zaretskii <eliz@gnu.org>
7416
7417 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7418 when at ZV. (Bug#8487)
7419
e7974947
AS
74202011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7421
baad03f0
AS
7422 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7423 (Bug#8437)
7424 * keyboard.c (parse_tool_bar_item): Likewise.
7425 * sound.c (sound_cleanup, alsa_close): Likewise.
7426 * termcap.c (tgetent): Likewise.
7427 * xfns.c (x_default_font_parameter): Likewise.
7428 * xsettings.c (read_and_apply_settings): Likewise.
7429
e7974947
AS
7430 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7431 (overrun_check_free): Protoize.
7432
28272684
PE
74332011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7434
7435 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7436 since callers should never pass a negative size.
7437 Change the signature to match that of plain 'read' and 'write'; see
7438 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7439 * lisp.h: Update prototypes of emacs_write and emacs_read.
7440
11997c76
EZ
74412011-04-11 Eli Zaretskii <eliz@gnu.org>
7442
7443 * xdisp.c (redisplay_window): Don't try to determine the character
7444 position of the scroll margin if the window start point w->startp
e896f03c 7445 is outside the buffer's accessible region. (Bug#8468)
11997c76 7446
8a2cbd72
EZ
74472011-04-10 Eli Zaretskii <eliz@gnu.org>
7448
7449 Fix write-region and its subroutines for buffers > 2GB.
7450 * fileio.c (a_write, e_write): Modify declaration of arguments and
7451 local variables to support buffers larger than 2GB.
7452 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7453
7454 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7455 argument, local variables, and return value.
7456
7457 * lisp.h: Update prototypes of emacs_write and emacs_read.
7458
7459 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7460
4073e537 74612011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7462
1ebfdcb6
PE
7463 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7464
b2ded58d
PE
7465 Fix more problems found by GCC 4.6.0's static checks.
7466
7d66342c
PE
7467 * xdisp.c (vmessage): Use a better test for character truncation.
7468
bbf47d44
PE
7469 * charset.c (load_charset_map): <, not <=, for optimization,
7470 and to avoid potential problems with integer overflow.
9248994d 7471 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7472 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7473 * editfns.c (Fformat): Likewise.
1e69125e 7474 * syntax.c (skip_chars): Likewise.
3befa583 7475
e3019616
PE
7476 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7477 This also lets GCC 4.6.0 generate slightly better loop code.
7478
becfa255
PE
7479 * callint.c (Fcall_interactively): <, not <=, for optimization.
7480 (Fcall_interactively): Count the number of arguments produced,
7481 not the number of arguments given. This is simpler and lets GCC
7482 4.6.0 generate slightly better code.
7483
dae0cd48
PE
7484 * ftfont.c: Distingish more carefully between FcChar8 and char.
7485 The previous code passed unsigned char * to a functions like
7486 strlen and xstrcasecmp that expect char *, which does not
7487 conform to the C standard.
7488 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7489 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7490 char * when the C standard requires it.
7491
76032d70
PE
7492 * keyboard.c (read_char): Remove unused var.
7493
eb3f1cc8
PE
7494 * eval.c: Port to Windows vsnprintf (Bug#8435).
7495 Include <limits.h>.
7496 (SIZE_MAX): Define if the headers do not.
7497 (verror): Do not give up if vsnprintf returns a negative count.
7498 Instead, grow the buffer. This ports to Windows vsnprintf, which
7499 does not conform to C99. Problem reported by Eli Zaretskii.
7500 Also, simplify the allocation scheme, by avoiding the need for
7501 calling realloc, and removing the ALLOCATED variable.
7502
70476b54
PE
7503 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7504
12020a9e
PE
7505 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7506 But keep the doprint source code for now, as we might revamp it
7507 and use it again (Bug#8435).
ea6c7ae6
PE
7508 * lisp.h (doprnt): Remove.
7509 * Makefile.in (base_obj): Remove doprnt.o.
7510 * deps.mk (doprnt.o): Remove.
7511
5fdb398c
PE
7512 error: Print 32- and 64-bit integers portably (Bug#8435).
7513 Without this change, on typical 64-bit hosts error ("...%d...", N)
7514 was used to print both 32- and 64-bit integers N, which relied on
7515 undefined behavior.
7516 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7517 New macro.
7518 * lisp.h (error, verror): Mark as printf-like functions.
7519 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7520 Report overflow in size calculations when allocating printf buffer.
7521 Do not truncate output string at its first null byte.
7522 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7523 Truncate the output at a character boundary, since vsnprintf does not
7524 do that.
7525 * charset.c (check_iso_charset_parameter): Convert internal
7526 character to string before calling 'error', since %c now has the
7527 printf meaning.
7528 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7529 overflow when computing char to be passed to 'error'. Do not
7530 pass Lisp_Object to 'error'; pass the integer instead.
7531 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7532 formatted with plain %d.
7533
b189fa66
PE
7534 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7535
bff87ef0
PE
7536 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7537
7e2cac20
PE
7538 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7539
ce4d90b5
PE
7540 * xterm.c (x_catch_errors): Remove duplicate declaration.
7541
266c9547
PE
7542 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7543
79c49ad2
PE
7544 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7545
368f4090
JM
75462011-04-10 Jim Meyering <meyering@redhat.com>
7547
7548 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7549 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7550 return ssize_t not "int", and use size_t as the buffer length.
7551 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7552 * gnutls.h: Update declarations.
7553 * process.c (read_process_output): Use ssize_t, to match.
7554 (send_process): Likewise.
7555
a32d4040
CY
75562011-04-09 Chong Yidong <cyd@stupidchicken.com>
7557
7558 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7559
8546720e 75602011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7561
04f2d78b
CB
7562 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7563 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7564
8546720e
GM
7565 * xterm.c (handle_one_xevent):
7566 * xmenu.c (create_and_show_popup_menu):
7567 * xselect.c (x_decline_selection_request)
7568 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7569
0a2f5c1a 75702011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7571
7572 Fix some uses of `int' instead of EMACS_INT.
7573 * search.c (string_match_1, fast_string_match)
7574 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7575 (scan_buffer, find_next_newline_no_quit)
7576 (find_before_next_newline, search_command, Freplace_match)
7577 (Fmatch_data): Make some `int' variables be EMACS_INT.
7578
7579 * xdisp.c (display_count_lines): 3rd argument and return value now
7580 EMACS_INT. All callers changed.
7581 (pint2hrstr): Last argument is now EMACS_INT.
7582
7583 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7584 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7585 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7586 (decode_coding_utf_16, decode_coding_emacs_mule)
7587 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7588 (decode_coding_ccl, decode_coding_charset)
7589 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7590 (decode_coding_iso_2022, decode_coding_emacs_mule)
7591 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7592 <char_offset, last_offset>: Declare EMACS_INT.
7593 (encode_coding_utf_8, encode_coding_utf_16)
7594 (encode_coding_emacs_mule, encode_invocation_designation)
7595 (encode_designation_at_bol, encode_coding_iso_2022)
7596 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7597 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7598 Declare EMACS_INT.
7599 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7600 (encode_invocation_designation): Last argument P_NCHARS is now
7601 EMACS_INT.
7602 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7603 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7604
7605 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7606 All users changed.
7607
7608 * ccl.c (Fccl_execute_on_string): Declare some variables
7609 EMACS_INT.
7610
8546720e 76112011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7612
7613 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7614
4e19a977
CS
76152011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7616
7617 * process.c (Fformat_network_address): Doc fix.
7618
87302331
R
76192011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7620
ee7683eb 7621 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7622
cbb59342
CY
76232011-04-08 Chong Yidong <cyd@stupidchicken.com>
7624
7625 * keyboard.c (read_char): Call Lisp function help-form-show,
7626 instead of using internal_with_output_to_temp_buffer.
7627 (Qhelp_form_show): New var.
e0d38eeb 7628 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7629
7630 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7631
7632 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7633
e67a13ab
CY
76342011-04-06 Chong Yidong <cyd@stupidchicken.com>
7635
04f2d78b
CB
7636 * process.c (Flist_processes): Remove to Lisp.
7637 (list_processes_1): Delete.
e67a13ab 7638
973f782d
EZ
76392011-04-06 Eli Zaretskii <eliz@gnu.org>
7640
7c106b1e
EZ
7641 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7642
973f782d
EZ
7643 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7644
41cf7d1a 76452011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7646
ca23cc88
PE
7647 Fix more problems found by GCC 4.6.0's static checks.
7648
f390e2d5
PE
7649 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7650
42eea0d0
PE
7651 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7652
b69769da 7653 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7654
f9541e84
PE
7655 * xdisp.c (vmessage): Mark as a printf-like function.
7656
13841b55
PE
7657 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7658
c136c10f
PE
7659 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7660
5e2d4a30
PE
7661 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7662 printf-like functions.
7663 (tiff_load): Add casts to remove these marks before passing them
7664 to system-supplied API.
7665
583f48b9
PE
7666 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7667
b25d760e
PE
7668 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7669 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7670 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7671 directly, rather than having caller test rule sign. This avoids
7672 some unnecessary tests.
7673 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7674 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7675 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7676
bc7b6697 7677 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7678 (xfont_open): Avoid unnecessary tests.
bc7b6697 7679
27ccc379
PE
7680 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7681
dcd5c89a
PE
7682 * composite.h, composite.c (composition_gstring_put_cache):
7683 Use EMACS_INT, not int, for length.
7684
b13a45c6
PE
7685 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7686 breaking out part of COMPOSITION_DECODE_RULE.
7687 (COMPOSITION_DECODE_RULE): Use it.
7688 * composite.c (get_composition_id): Remove unused local vars,
7689 by using the new macro.
7690
1e792e4d
PE
7691 * textprop.c (set_text_properties_1): Change while to do-while,
7692 since the condition is always true at first.
7693
dc6c6455 7694 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7695 (interval_deletion_adjustment): Return unsigned value.
7696 All uses changed.
dc6c6455 7697
aba7731a
PE
7698 * process.c (list_processes_1, create_pty, read_process_output):
7699 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7700 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7701 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7702 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7703 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7704
fdfc4bf3
PE
7705 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7706
fca8fe46 7707 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7708 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7709
06a0259a 7710 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7711 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7712 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7713
e7b9e80f
PE
7714 * print.c (print_error_message): Avoid int overflow.
7715
56201685
PE
7716 * font.c (font_list_entities): Redo for clarity,
7717 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7718
78834453 7719 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7720 (font_score): Avoid potential overflow in diff calculation.
78834453 7721
0bc0b309 7722 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7723 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7724
e610eaca
PE
7725 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7726
b895abce
PE
7727 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7728 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7729 can always succeed if overflow has undefined behavior.
7730
1f1d9321 7731 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7732 (wordify): Omit three unnecessary tests.
1f1d9321 7733
c59478bc
PE
7734 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7735 All callers changed. This avoids the need for an unused var.
7736
79b73827
PE
7737 * casefiddle.c (casify_region): Remove var that is set but not used.
7738
a4db5dfe
PE
7739 * dired.c (file_name_completion): Remove var that is set but not used.
7740
43aae36e
PE
7741 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7742
2a47c44d 7743 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7744 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7745
a37c69bf
PE
7746 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7747 Check for integer overflow on size calculations.
7748
328ab8e7
PE
7749 * buffer.c (Fprevious_overlay_change): Remove var that is set
7750 but not used.
7751
e5a2a5cb
PE
7752 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7753 Remove vars that are set but not used.
8d84a6eb 7754 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7755 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7756
a60e5f68
PE
7757 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7758
f661cb61 7759 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7760 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7761
f0397f5a
PE
7762 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7763 that are set but not used.
7764
8664db06 7765 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7766 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7767
6abdaa4a
PE
7768 * xselect.c (x_get_local_selection, x_handle_property_notify):
7769 Remove vars that are set but not used.
7770
0ce7538d 7771 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7772 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7773
9ae848fc
PE
7774 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7775 Remove var that is set but not used.
0b918413
PE
7776 (scroll_bar_windows_size): Now size_t, not int.
7777 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7778 Check for overflow.
9ae848fc 7779
a5a62657
PE
7780 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7781 (map_tty_color) [!defined MSDOS]: Likewise.
7782
5c5cdd39
PE
7783 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7784
66ebf983
PE
7785 * coding.c: Remove vars that are set but not used.
7786 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7787 All callers changed.
7788 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7789 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7790 (decode_coding_charset): Remove vars that are set but not used.
7791
1be4d761
PE
7792 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7793 that is set but not used.
7794
47553fa8
PE
7795 * print.c (print_object): Remove var that is set but not used.
7796
1f7196bf 7797 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7798 The gnulib version avoids calling malloc in the usual case,
7799 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7800 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7801 * filelock.c (current_lock_owner): Likewise.
7802 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7803 * sysdep.c: Include allocator.h, careadlinkat.h.
7804 (emacs_no_realloc_allocator): New static constant.
7805 (emacs_readlink): New function.
fdb61804
PE
7806 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7807 ../lib/careadlinkat.h.
d1fdcab7 7808
f84c17c7
SM
78092011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7810
7811 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7812 first non-nil return value).
7813
ef3862ad
JD
78142011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7815
7816 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7817 if not defined (Bug#8403).
7818
376a7006
JB
78192011-04-02 Juanma Barranquero <lekktu@gmail.com>
7820
7821 * xdisp.c (display_count_lines): Remove parameter `start',
7822 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7823 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7824 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7825 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7826 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7827 and thereabouts. All callers changed.
7828 (get_per_char_metric): Remove parameter `f', unused since
7829 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7830
6ca3801d
JM
78312011-04-02 Jim Meyering <meyering@redhat.com>
7832
7833 do not dereference NULL upon failed strdup
7834 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7835 (ns_get_family): Likewise.
7836
d8e2b5ba
JB
78372011-04-02 Juanma Barranquero <lekktu@gmail.com>
7838
7839 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7840
8c74fcbd
JD
78412011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7842
7843 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7844 later (Bug#8403).
7845
7200d79c
SM
78462011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7847
03408648 7848 Add lexical binding.
7200d79c 7849
03408648
SM
7850 * window.c (Ftemp_output_buffer_show): New fun.
7851 (Fsave_window_excursion):
7852 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7853
7854 * lread.c (lisp_file_lexically_bound_p): New function.
7855 (Fload): Bind Qlexical_binding.
7856 (readevalloop): Remove `evalfun' arg.
7857 Bind Qinternal_interpreter_environment.
7858 (Feval_buffer): Bind Qlexical_binding.
7859 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7860 Mark as dynamic.
7861 (syms_of_lread): Declare `lexical-binding'.
7862
7863 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7864
7865 * keyboard.c (eval_dyn): New fun.
7866 (menu_item_eval_property): Use it.
ca105506
SM
7867
7868 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7869
03408648
SM
7870 * fns.c (concat, mapcar1): Accept byte-code-functions.
7871
7872 * eval.c (Fsetq): Handle lexical vars.
7873 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7874 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7875 (FletX, Flet): Obey lexical binding.
7876 (Fcommandp): Handle closures.
7877 (Feval): New `lexical' arg.
7878 (eval_sub): New function extracted from Feval. Use it almost
7879 everywhere where Feval was used. Look up vars in lexical env.
7880 Handle closures.
7881 (Ffunctionp): Move from subr.el.
7882 (Ffuncall): Handle closures.
7883 (apply_lambda): Remove `eval_flags'.
7884 (funcall_lambda): Handle closures and new byte-code-functions.
7885 (Fspecial_variable_p): New function.
7886 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7887 but without exporting it to Lisp.
23aba0ea 7888
23aba0ea 7889 * doc.c (Fdocumentation, store_function_docstring):
03408648 7890 * data.c (Finteractive_form): Handle closures.
23aba0ea 7891
03408648
SM
7892 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7893 interactive spec.
ba83908c 7894
04f2d78b
CB
7895 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7896 New byte-codes.
03408648
SM
7897 (exec_byte_code): New function extracted from Fbyte_code to handle new
7898 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7899
03408648 7900 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7901
03408648 7902 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7903
e2abce01
JB
79042011-03-31 Juanma Barranquero <lekktu@gmail.com>
7905
7906 * xdisp.c (redisplay_internal): Fix prototype.
7907
63696a73 79082011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7909
63696a73 7910 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7911 (try_scrolling): Use it when setting scroll_limit.
7912 Limit scrolling to 100 screen lines.
63696a73
EZ
7913 (redisplay_window): Even when falling back on "recentering",
7914 position point in the window according to scroll-conservatively,
7915 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7916
7917 (try_scrolling): When point is above the window, allow searching
7918 as far as scroll_max, or one screenful, to compute vertical
7919 distance from PT to the scroll margin position. This prevents
7920 try_scrolling from unnecessarily failing when
7921 scroll-conservatively is set to a value slightly larger than the
7922 window height. Clean up the case of PT below the margin at bottom
7923 of window: scroll_max can no longer be INT_MAX. When aggressive
7924 scrolling is in use, don't let point enter the opposite scroll
7925 margin as result of the scroll.
7926 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7927 threshold of 100 lines for never-recentering scrolling.
7928
e4cc2dfc
JB
79292011-03-31 Juanma Barranquero <lekktu@gmail.com>
7930
7931 * dispextern.h (move_it_by_lines):
7932 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7933 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7934 (message_log_check_duplicate): Remove parameters `prev_bol' and
7935 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7936 (redisplay_internal): Remove parameter `preserve_echo_area',
7937 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7938
7939 * indent.c (Fvertical_motion):
7940 * window.c (window_scroll_pixel_based, Frecenter):
7941 Don't pass `need_y_p' to `move_it_by_lines'.
7942
1c470562
SM
79432011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7944
44f230aa
SM
7945 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7946 steal a few bits to be more compact.
7947 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7948 Remove unneeded casts.
7949
1c470562
SM
7950 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7951
888adce9
ZK
79522011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7953
7954 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7955 binding" message (bug#7967).
7956
f838ed7b
PE
79572011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7958
77861b95
PE
7959 Fix more problems found by GCC 4.6.0's static checks.
7960
de6dbc14
PE
7961 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7962 Remove unused local var.
7963
f838ed7b
PE
7964 * editfns.c (Fmessage_box): Remove unused local var.
7965
792c7b2b
PE
7966 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7967 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7968 Omit unused local vars.
c499e557 7969 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7970 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7971 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7972 Omit unused local var.
7973
ba0165e1
PE
7974 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7975 Don't assume string length fits in int.
32ad8845 7976 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7977 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7978
3c59b4c9
PE
7979 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7980 instead of alloca (Bug#8344).
7981
a3eed478 7982 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7983 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7984
eb4d412d
PE
7985 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7986
1658b401
PE
7987 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7988 concerns.
7989
7990 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7991
7992 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7993
9a2c6e05
PE
7994 * keyboard.c (syms_of_keyboard): Use the same style as later
7995 in this function when indexing through an array. This also
7996 works around GCC bug 48267.
7997
03d0a109
PE
7998 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7999
44f730c8
PE
8000 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8001
fe75f926
PE
8002 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8003 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8004
ffa8c828
PE
8005 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8006 This avoids undefined behavior on integer overflow, and is a bit
8007 more convenient anyway since it is compared to a size_t variable.
8008
c5101a77
PE
8009 Variadic C functions now count arguments with size_t, not int.
8010 This avoids an unnecessary limitation on 64-bit machines, which
8011 caused (substring ...) to crash on large vectors (Bug#8344).
8012 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8013 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8014 All variadic functions and their callers changed accordingly.
c5101a77
PE
8015 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8016 * data.c (arith_driver, float_arith_driver): Likewise.
8017 * editfns.c (general_insert_function): Likewise.
8018 * eval.c (struct backtrace.nargs, interactive_p)
8019 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8020 (funcall_lambda, mark_backtrace): Likewise.
8021 * fns.c (concat): Likewise.
8022 * frame.c (x_set_frame_parameters): Likewise.
8023 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8024 0 if not found, not -1. All callers changed.
8025
dd3f25f7
PE
8026 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8027 (stack_copy_size): Now size_t, not int.
8028 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8029
461c2ab9
JB
80302011-03-28 Juanma Barranquero <lekktu@gmail.com>
8031
8032 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8033 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8034 All callers changed.
8035
8036 * lisp.h (multibyte_char_to_unibyte):
8037 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8038 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8039 * character.h (CHAR_TO_BYTE8):
8040 * cmds.c (internal_self_insert):
8041 * editfns.c (general_insert_function):
8042 * keymap.c (push_key_description):
8043 * search.c (Freplace_match):
8044 * xdisp.c (message_dolog, set_message_1): All callers changed.
8045
f6d62986
SM
80462011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8047
8048 * keyboard.c (safe_run_hook_funcall): New function.
8049 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8050 don't set the hook to nil, but remove the offending function instead.
8051 (Qcommand_hook_internal): Remove, unused.
8052 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8053 Vcommand_hook_internal.
8054
8055 * eval.c (enum run_hooks_condition): Remove.
8056 (funcall_nil, funcall_not): New functions.
8057 (run_hook_with_args): Call each function through a `funcall' argument.
8058 Remove `cond' argument, now redundant.
8059 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8060 (Frun_hook_with_args_until_failure): Adjust accordingly.
8061 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8062
1db5b1ad
JB
80632011-03-28 Juanma Barranquero <lekktu@gmail.com>
8064
8065 * dispextern.h (string_buffer_position): Remove declaration.
8066
8067 * print.c (strout): Remove parameter `multibyte', unused since
8068 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8069
8070 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8071 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8072 All callers changed.
8073
8074 * w32.c (_wsa_errlist): Use braces for struct initializers.
8075
8076 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8077 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8078 All callers changed.
8079 (string_buffer_position): Likewise. Also, make static (it's never
8080 used outside xdisp.c).
8081 (cursor_row_p): Remove parameter `w', unused since
8082 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8083 (decode_mode_spec): Remove parameter `precision', introduced during
8084 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8085 All callers changed.
8086
5ffb62aa
JD
80872011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8088
8089 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8090
461c2ab9 80912011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8092
8093 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8094 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8095 (ns_update_auto_hide_menu_bar): New functions.
8096 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8097 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8098 ns_constrain_all_frames.
8099 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8100 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8101
5c380ffb
JD
81022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8103
8104 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8105
9af30bdf
GM
81062011-03-27 Glenn Morris <rgm@gnu.org>
8107
8108 * syssignal.h: Replace RETSIGTYPE with void.
8109 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8110 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8111 Replace SIGTYPE with void everywhere.
8112 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8113 * s/template.h (SIGTYPE): Remove commented out definition.
8114
e2abce01
JB
81152011-03-26 Eli Zaretskii <eliz@gnu.org>
8116
8117 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8118 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8119
f868cd8a
JB
81202011-03-26 Juanma Barranquero <lekktu@gmail.com>
8121
59eb0929
JB
8122 * w32.c (read_unc_volume): Use parameter `henum', instead of
8123 global variable `wget_enum_handle'.
8124
8125 * keymap.c (describe_vector): Remove parameters `indices' and
8126 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8127 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8128
f868cd8a
JB
8129 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8130
8131 * keyboard.c (timer_check): Remove parameter `do_it_now',
8132 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8133 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8134 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8135
8136 * keyboard.c (read_char):
8137 * w32menu.c (w32_menu_display_help):
8138 * xmenu.c (show_help_event, menu_help_callback):
8139 Adjust calls to `show_help_echo'.
8140
8141 * gtkutil.c (xg_maybe_add_timer):
8142 * keyboard.c (readable_events):
8143 * process.c (wait_reading_process_output):
8144 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8145
8146 * insdel.c (adjust_markers_gap_motion):
8147 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8148 (gap_left, gap_right): Don't call it.
8149
2ecf6fdb
CY
81502011-03-25 Chong Yidong <cyd@stupidchicken.com>
8151
8152 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8153 incurred during fontification.
8154
6b1f9ba4
JB
81552011-03-25 Juanma Barranquero <lekktu@gmail.com>
8156
8157 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8158 (DEFVAR_PER_BUFFER): Don't pass it.
8159
8160 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8161 (scrolling_window): Don't pass it.
8162
0f4a96b5
JB
81632011-03-25 Juanma Barranquero <lekktu@gmail.com>
8164
8165 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8166
8167 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8168 and `suffix'.
8169 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8170 of variables specific to SELinux and computation of `encoded_absname'.
8171
8172 * image.c (XPutPixel): Remove unused variable `height'.
8173
8174 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8175
8176 * unexw32.c (get_section_info): Remove unused variable `section'.
8177
8178 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8179 (system_process_attributes): Remove unused variable `sess'.
8180 (sys_read): Remove unused variable `err'.
8181
8182 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8183 (w32_wnd_proc): Remove unused variable `isdead'.
8184 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8185 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8186 (x_create_tip_frame): Remove unused variable `tem'.
8187
8188 * w32inevt.c (w32_console_read_socket):
8189 Remove unused variable `no_events'.
8190
8191 * w32term.c (x_draw_composite_glyph_string_foreground):
8192 Remove unused variable `width'.
8193
1149507c
JB
81942011-03-24 Juanma Barranquero <lekktu@gmail.com>
8195
8196 * w32term.c (x_set_glyph_string_clipping):
8197 Don't pass uninitialized region to CombineRgn.
8198
9c88f339
JB
81992011-03-23 Juanma Barranquero <lekktu@gmail.com>
8200
8201 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8202 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8203 (Fx_close_connection): Remove unused variable `i'.
8204
8205 * w32font.c (w32font_draw): Return number of glyphs.
8206 (w32font_open_internal): Remove unused variable `i'.
8207 (w32font_driver): Add missing initializer.
8208
8209 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8210 (fill_in_menu): Remove unused variable `items_added'.
8211
8212 * w32term.c (last_mouse_press_frame): Remove static global variable.
8213 (w32_clip_to_row): Remove unused variable `f'.
8214 (x_delete_terminal): Remove unused variable `i'.
8215
8216 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8217 (NOTHING): Remove unused static global variable.
8218 (uniscribe_check_otf): Remove unused variable `table'.
8219 (uniscribe_font_driver): Add missing initializers.
8220
dee091a3
JD
82212011-03-23 Julien Danjou <julien@danjou.info>
8222
8223 * term.c (Fsuspend_tty, Fresume_tty):
8224 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8225 * window.c (temp_output_buffer_show):
8226 * insdel.c (signal_before_change):
8227 * frame.c (Fhandle_switch_frame):
8228 * fileio.c (Fdo_auto_save):
8229 * emacs.c (Fkill_emacs):
8230 * editfns.c (save_excursion_restore):
8231 * cmds.c (internal_self_insert):
8232 * callint.c (Fcall_interactively):
8233 * buffer.c (Fkill_all_local_variables):
8234 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8235 Use Frun_hooks.
0f4a96b5 8236 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8237 unconditionally since it does the check itself.
dee091a3 8238
2c520ab5 82392011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8240
c9c49752
PE
8241 Fix more problems found by GCC 4.5.2's static checks.
8242
8abc3f12
PE
8243 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8244 the first time through the loop, since we know p0 < p1 then.
8245 This also avoids a gcc -Wstrict-overflow warning.
8246
a2d26660
PE
8247 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8248 leading to a memory leak, possible in functions like
8249 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8250 of objects (Bug#8318).
a2d26660 8251
916c72e9
PE
8252 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8253 that could (at least in theory) be that large.
8254
19ab8a18
PE
8255 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8256 This is less likely to overflow, and avoids undefined behavior if
8257 overflow does occur. All callers changed. Use strtoul to scan
8258 for the unsigned long integer.
b7cbbd6f
PE
8259 (pint2hrstr): Simplify and tune code slightly.
8260 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8261
f0641eff
PE
8262 * scroll.c (do_scrolling): Work around GCC bug 48228.
8263 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8264
7f650bb9
PE
8265 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8266 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8267 (validate_x_resource_name): Simplify count usage.
8268 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8269
37dd57d1
PE
8270 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8271 fail (Bug#8306).
81e56e61 8272
699979fc 8273 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8274
401bf9b4
PE
8275 * process.c (Fmake_network_process): Use socklen_t, not int,
8276 where POSIX says socklen_t is required in portable programs.
8277 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8278 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8279 (Fmake_network_process, server_accept_connection):
8280 (wait_reading_process_output, read_process_output):
8281 Likewise.
8282
b93aacde
PE
8283 * process.c: Rename or move locals to avoid shadowing.
8284 (list_processes_1, Fmake_network_process):
8285 (read_process_output_error_handler, exec_sentinel_error_handler):
8286 Rename or move locals.
4dc343ee 8287 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8288 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8289 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8290 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8291 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8292
af8a867c 8293 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8294 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8295 Include tparam.h instead, since it declares them.
af8a867c
PE
8296 * cm.h (PC): Remove extern decl; tparam.h now does this.
8297 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8298 * terminfo.c: Include tparam.h, to check interfaces.
8299 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8300 (tparam): Adjust signature to match interface in tparam.h;
8301 this removes some undefined behavior. Check that outstring and len
8302 are zero, which they always are with Emacs.
8303 * tparam.h (PC, BC, UP): New extern decls.
8304
0248044d 8305 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8306 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8307
8ff096c1 8308 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8309 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8310 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8311 (ftfont_list): Remove unused local.
49eaafba
PE
8312 (get_adstyle_property, ftfont_pattern_entity):
8313 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8314 Rename locals to avoid shadowing.
8ff096c1 8315
e2be39f6
PE
8316 * xfont.c (xfont_list_family): Mark var as initialized.
8317
c9735e30
PE
8318 * xml.c (make_dom): Now static.
8319
8f5201ae
PE
8320 * composite.c (composition_compute_stop_pos): Rename local to
8321 avoid shadowing.
b246f932
PE
8322 (composition_reseat_it): Remove unused locals.
8323 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8324 (composition_update_it): Mark var as initialized.
11b61122
PE
8325 (find_automatic_composition): Mark vars as initialized,
8326 with a FIXME (Bug#8290).
8f5201ae 8327
760fbc2c
PE
8328 character.h: Rename locals to avoid shadowing.
8329 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8330 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8331 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8332 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8333 to avoid shadowing.
8334
ff08eb85
PE
8335 * textprop.c (property_change_between_p): Remove; unused.
8336
fc7bf025
PE
8337 * intervals.c (interval_start_pos): Now static.
8338
235d7abc
PE
8339 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8340
44f230aa
SM
8341 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8342 Rename locals to avoid shadowing.
3e7d6594 8343
50060332
PE
8344 * sound.c (wav_play, au_play, Fplay_sound_internal):
8345 Fix pointer signedness.
d01f234b 8346 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8347 (wav_play): Initialize a variable to 0, to prevent undefined
8348 behavior (Bug#8278).
50060332 8349
c4fc4e30
PE
8350 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8351
918436ed
PE
8352 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8353
c939f91b
PE
8354 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8355 clobbering (Bug#8298).
b9c7f648
PE
8356 * sysdep.c (sys_subshell): Likewise.
8357 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8358
6bd8c144
PE
8359 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8360 This should get cleaned up, so that child_setup has the
8361 same signature on all platforms.
8362
7710357c 8363 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8364 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8365
c59da222
CY
83662011-03-22 Chong Yidong <cyd@stupidchicken.com>
8367
8368 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8369 not to be necessary, and produces flickering.
8370
66b87493
GM
83712011-03-20 Glenn Morris <rgm@gnu.org>
8372
8373 * config.in: Remove file.
8374
45b6f6d5
JB
83752011-03-20 Juanma Barranquero <lekktu@gmail.com>
8376
8377 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8378 are now in src/globals.h.
8379 (syms_of_minibuf): Remove spurious & from previous change.
8380
cd394be1 83812011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8382
8383 * minibuf.c (completing-read-function): New variable.
8384 (completing-read-default): Rename from completing-read.
8385 (completing-read): Call completing-read-function.
8386
b14e3e21
CY
83872011-03-19 Juanma Barranquero <lekktu@gmail.com>
8388
8389 * xfaces.c (Fx_load_color_file):
8390 Read color file from absolute filename (bug#8250).
8391
f2b726e6
JB
83922011-03-19 Juanma Barranquero <lekktu@gmail.com>
8393
8394 * makefile.w32-in: Update dependencies.
8395
09f6ff02
EZ
83962011-03-17 Eli Zaretskii <eliz@gnu.org>
8397
8398 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8399
29a6015a
PE
84002011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8401
a3a6c54e
PE
8402 Fix more problems found by GCC 4.5.2's static checks.
8403
b766f867
PE
8404 * process.c (make_serial_process_unwind, send_process_trap):
8405 (sigchld_handler): Now static.
8406
be02381c
PE
8407 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8408 That way, the code declares only the vars that it needs.
8409 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8410 * s/cygwin.h (PTY_ITERATION): Likewise.
8411 * s/darwin.h (PTY_ITERATION): Likewise.
8412 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8413
57048744
PE
8414 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8415 * process.c (allocate_pty): Don't declare stb unless it's needed.
8416
7914961c 8417 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8418 (CONSTANTLIM): Remove; unused.
8419 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8420 Define only if needed.
7914961c 8421
b3967b18
PE
8422 * unexelf.c (unexec): Name an expression,
8423 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8424 Use a different way to cause a compilation error if anyone uses
8425 n rather than nn, a way that does not involve shadowing.
73366a00 8426 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8427
29a6015a
PE
8428 * deps.mk (unexalpha.o): Remove; unused.
8429
43cfc33e 8430 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8431 * unexec.h: New file.
ce701a33
PE
8432 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8433 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8434 Depend on unexec.h.
8435 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8436 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8437 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8438 Change as necessary to match prototype in unexec.h.
ce701a33 8439
01f44d5a
PE
8440 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8441 shadowing.
4f63c6bb 8442 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8443
a6670b0b
PE
8444 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8445 Rename locals to avoid shadowing.
8446
cef2010d 8447 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8448 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8449
d4d7173a
PE
8450 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8451
f08b802a
PE
8452 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8453 warning when compiling print.c.
8454
3ddb0639
PE
8455 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8456 instead of using an uninitialized var.
5ad03b97 8457 (font_sort_entities): Mark var as initialized.
3ddb0639 8458
170a2692
PE
8459 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8460
e663c700
PE
8461 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8462 pointers to constants.
89bc529a 8463 (font_parse_fcname): Remove unused vars.
7b81e2d0 8464 (font_delete_unmatched): Now static.
ea838e10 8465 (font_get_spec): Remove; unused.
13a547c6
PE
8466 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8467 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8468 Rename or move locals to avoid shadowing.
e663c700 8469
2a80c887 8470 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8471 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8472
1384fa33 8473 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8474 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8475
8b2c52e9
PE
8476 * alloc.c (mark_backtrace): Move decl from here ...
8477 * lisp.h: ... to here, so that it can be checked.
8478
475545b5 8479 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8480 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8481 (lisp_indirect_variable): Name an expression,
8482 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8483 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8484
b1349114 8485 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8486 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8487 Use const pointer when appropriate.
b1349114 8488
a2928364
PE
8489 * lisp.h (get_system_name, get_operating_system_release):
8490 Move decls here, to check interfaces.
8491 * process.c (get_operating_system_release): Move decl to lisp.h.
8492 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8493 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8494 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8495 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8496 (Fformat_time_string, Fencode_time, Finsert_char):
8497 (Ftranslate_region_internal, Fformat):
8498 Rename or remove local vars to avoid shadowing.
9710023e 8499 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8500
a415e694
PE
8501 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8502 avoid shadowing.
8503
8ef4622d
PE
8504 * lisp.h (eassert): Check that the argument compiles, even if
8505 ENABLE_CHECKING is not defined.
8506
946f9a5b
PE
8507 * data.c (Findirect_variable): Name an expression, to avoid
8508 gcc -Wbad-function-cast warning.
112396d6 8509 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8510 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8511 (Fmake_variable_buffer_local, Fmake_local_variable):
8512 Mark variables as initialized.
52746918 8513 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8514
e5aab7e7 8515 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8516 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8517 Rename locals to avoid shadowing.
dff45157
PE
8518 (mark_stack): Move local variables into the #ifdef region where
8519 they're used.
7bc26fdb
PE
8520 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8521 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8522 needed otherwise.
8523 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8524 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8525 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8526
e5aab7e7
PE
8527 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8528 avoids undefined behavior in theory.
8529
4da60324
PE
8530 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8531
88043301
PE
8532 Use functions, not macros, for up- and down-casing (Bug#8254).
8533 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8534 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8535 to use the following functions instead of these macros.
8536 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8537 EMACS_INT, since callers assume the returned value fits in int.
8538 (upcase1): Likewise, for UPCASE_TABLE.
8539 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8540 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8541 the race-condition problem in the old DOWNCASE.
88043301 8542
19ed5445
PE
8543 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8544 Rename locals to avoid shadowing.
8545 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8546 (regex_compile, re_search_2, re_match_2_internal):
8547 Remove unused local vars.
952db0d7
PE
8548 (FREE_VAR): Rewrite so as not to use empty "else",
8549 which gcc can warn about.
da053e48 8550 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8551 (RETALLOC_IF): Define only if needed.
8552 (WORDCHAR_P): Likewise. This one is never needed, but is used
8553 only in a comment talking about a compiler bug, so put inside
8554 the #if 0 of that comment.
8555 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8556 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8557 Remove; unused.
19ed5445 8558
1f3561e4 8559 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8560 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8561 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8562
ded6f8f7
PE
8563 * search.c (simple_search): Remove unused var.
8564
dbd37a95
PE
8565 * dired.c (compile_pattern): Move decl from here ...
8566 * lisp.h: ... to here, so that it can be checked.
8567 (struct re_registers): New forward decl.
8568
7e47afad
PE
8569 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8570
85f24f61
PE
8571 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8572 All uses changed.
8573 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8574 Rename locals to avoid shadowing.
5671df8f 8575 (Fvertical_motion): Mark locals as initialized.
85f24f61 8576
181aa2be 8577 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8578 (casify_region): Mark local as initialized.
181aa2be 8579
930d429c
PE
8580 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8581
7082eac6
PE
8582 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8583 New macros, so that the caller can use some names other than
8584 gcpro1, gcpro2, etc.
8585 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8586 of the new macros.
8587 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8588 argument, for consistency with GCPRO2_VAR, etc: it is now the
8589 prefix of the variable, not the variable itself. All uses
8590 changed.
38b2c076
PE
8591 * dired.c (directory_files_internal, file_name_completion):
8592 Rename locals to avoid shadowing.
8593
15206ed9
PE
8594 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8595 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8596 dired.c's scmp function, had undefined behavior.
8597 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8598 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8599 * buffer.h: ... to here, because these macros use current_buffer,
8600 and the new implementation with inline functions needs to have
8601 current_buffer in scope now, rather than later when the macros
8602 are used.
8603 (downcase, upcase1): New static inline functions.
8604 (DOWNCASE, UPCASE1): Reimplement using these functions.
8605 This avoids undefined behavior in expressions like
8606 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8607 from race conditions in accessing the global variables
8608 case_temp1 and case_temp2.
8609 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8610 * lisp.h (case_temp1, case_temp2): Remove their decls.
8611 * character.h (ASCII_CHAR_P): Move from here ...
8612 * lisp.h: ... to here, so that the inline functions mentioned
8613 above can use them.
8614
4a6bea26
PE
8615 * dired.c (directory_files_internal_unwind): Now static.
8616
f14b7e14
PE
8617 * fileio.c (file_name_as_directory, directory_file_name):
8618 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8619 Now static.
2893f146
PE
8620 (file_name_as_directory): Use const pointers when appropriate.
8621 (Fexpand_file_name): Likewise. In particular, newdir might
8622 point at constant storage, so make it a const pointer.
fd4ead52 8623 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8624 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8625 signedness issues.
f839df0c
PE
8626 (Fset_file_times, Finsert_file_contents, auto_save_error):
8627 Rename locals to avoid shadowing.
f14b7e14 8628
5716756e 8629 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8630 (Ftry_completion, Fall_completions): Rename or remove locals
8631 to avoid shadowing.
5716756e 8632
b4c3046a
PE
8633 * marker.c (bytepos_to_charpos): Remove; unused.
8634
b45db522
PE
8635 * lisp.h (verify_bytepos, count_markers): New decls,
8636 so that gcc does not warn that these functions aren't declared.
8637
85876d07
PE
8638 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8639 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8640 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8641 (copy_text): Remove unused local var.
85876d07 8642
03d78a21 8643 * filelock.c (within_one_second): Now static.
b3dd38ab 8644 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8645
5df8f01b
PE
8646 * buffer.c (fix_overlays_before): Mark locals as initialized.
8647 (fix_start_end_in_overlays): Likewise. This function should be
8648 simplified by using pointers-to-pointers, but that's a different
8649 matter.
b1d876f1 8650 (switch_to_buffer_1): Now static.
8f54f30a
PE
8651 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8652 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8653
a70072c9 8654 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8655 Fix pointer signedness issue.
edced198
PE
8656 (sys_subshell): Mark local as volatile if checking for lint,
8657 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8658 (MAXPATHLEN): Define only if needed.
a70072c9 8659
a0977c44
PE
8660 * process.c (serial_open, serial_configure): Move decls from here ...
8661 * systty.h: ... to here, so that they can be checked.
8662
a884fdcc
PE
8663 * fns.c (get_random, seed_random): Move extern decls from here ...
8664 * lisp.h: ... to here, so that they can be checked.
8665
604efe86 8666 * sysdep.c (reset_io): Now static.
b8950c94 8667 (wait_for_termination_signal): Remove; unused.
604efe86 8668
38fc62d9
PE
8669 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8670 (copy_keymap_item, append_key, push_text_char_description):
8671 Now static.
1004a21a 8672 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8673 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8674 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8675 (describe_map_tree):
8676 Rename locals to avoid shadowing.
38fc62d9 8677
2f2650da
PE
8678 * keyboard.c: Declare functions static if they are not used elsewhere.
8679 (echo_char, echo_dash, cmd_error, top_level_2):
8680 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8681 (read_char, kbd_buffer_get_event, make_lispy_position):
8682 (make_lispy_event, make_lispy_movement, apply_modifiers):
8683 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8684 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8685 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8686 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8687 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8688
a053e86c 8689 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8690 (mark_kboards): Move decl here ...
8691 * alloc.c (mark_kboards): ... from here.
a053e86c 8692
4752793e
PE
8693 * lisp.h (force_auto_save_soon): New decl.
8694
74f10ca7 8695 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8696 (DEFINE_DUMMY_FUNCTION): New macro.
8697 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8698 Use it.
c03cd23f
PE
8699 (main): Add casts to avoid warnings
8700 if GCC considers string literals to be constants.
74f10ca7 8701
022e70d4
PE
8702 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8703
59d6fe83
PE
8704 * dbusbind.c: Pointer signedness fixes.
8705 (xd_signature, xd_append_arg, xd_initialize):
8706 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8707 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8708 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8709 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8710
78320123
PE
8711 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8712 if GCC considers string literals to be constants.
49cebcca 8713 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8714
35ac2a97
SM
87152011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8716
fb103ca9
SM
8717 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8718 (print_preprocess, print_object): New macro to fix last change.
8719
35ac2a97
SM
8720 * print.c (print_preprocess): Don't forget font objects.
8721
62973b41
JB
87222011-03-16 Juanma Barranquero <lekktu@gmail.com>
8723
8724 * emacs.c (USAGE3): Doc fixes.
8725
0e48bb22
AS
87262011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8727
8728 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8729 structure.
8730
7684e57b
JB
87312011-03-14 Juanma Barranquero <lekktu@gmail.com>
8732
8733 * lisp.h (VWindow_system, Qfile_name_history):
8734 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8735 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8736 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8737
8738 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8739 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8740
8741 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8742 * w32console.c (detect_input_pending, read_input_pending)
8743 (encode_terminal_code):
8744 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8745 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8746 (w32_system_caret_y, Qfile_name_history):
8747 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8748 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8749 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8750 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8751 * w32proc.c (Qlocal, report_file_error):
8752 * w32term.c (Vwindow_system, updating_frame):
8753 * w32uniscribe.c (initialized, uniscribe_font_driver):
8754 Remove unneeded extern declarations.
8755
2aa46d6c
CY
87562011-03-14 Chong Yidong <cyd@stupidchicken.com>
8757
c96bbc66 8758 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8759
cffc6f3b
CY
87602011-03-13 Chong Yidong <cyd@stupidchicken.com>
8761
8762 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8763 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8764 These macros can no longer be used for assignment.
8765
44f230aa
SM
8766 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8767 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8768 (record_buffer_markers, fetch_buffer_markers): New functions for
8769 recording and fetching special buffer markers.
8770 (set_buffer_internal_1, set_buffer_temp): Use them.
8771
8772 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8773
8774 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8775
8776 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8777 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8778
8779 * xdisp.c (hscroll_window_tree):
8780 (reconsider_clip_changes): Use PT instead of BUF_PT.
8781
d251f04b
EZ
87822011-03-13 Eli Zaretskii <eliz@gnu.org>
8783
8784 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8785 $(EMACS_ROOT)/lib/intprops.h.
8786
f0c77cd1
PE
87872011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8788
3eca4629
PE
8789 Fix more problems found by GCC 4.5.2's static checks.
8790
7c86ee98
PE
8791 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8792 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8793 (xg_free_frame_widgets): Make it clear that a local variable is
8794 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8795 (gdk_window_get_screen): Make it clear that this macro is needed
8796 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8797 (int_gtk_range_get_value): New function, which avoids a diagnostic
8798 from gcc -Wbad-function-cast.
8799 (xg_set_toolkit_scroll_bar_thumb): Use it.
8800 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8801 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8802 (get_utf8_string, xg_get_file_with_chooser):
8803 Rename locals to avoid shadowing.
8804 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8805
41729b81
PE
8806 * xgselect.c (xg_select): Remove unused var.
8807
f0c77cd1
PE
8808 * image.c (four_corners_best): Mark locals as initialized.
8809 (gif_load): Initialize transparent_p to zero (Bug#8238).
8810 Mark another local as initialized.
ec6cf4c6 8811 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8812
ce0ad53d 8813 * image.c (clear_image_cache): Now static.
d5d5a617 8814 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8815 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8816 (x_edge_detection): Remove unnecessary cast that
8817 gcc -Wbad-function-cast diagnoses.
2037898d 8818 (gif_load): Fix pointer signedness.
6ae141d6
PE
8819 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8820 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8821
33383987 88222011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8823
d32df629
PE
8824 Improve quality of tests for time stamp overflow.
8825 For example, without this patch (encode-time 0 0 0 1 1
8826 1152921504606846976) returns the obviously-bogus value (-948597
8827 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8828 reports time overflow. See
8829 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8830 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8831 * editfns.c: Include limits.h and intprops.h.
8832 (TIME_T_MIN, TIME_T_MAX): New macros.
8833 (time_overflow): Move earlier, to before first use.
8834 (hi_time, lo_time): New functions, for an accurate test for
8835 out-of-range times.
8836 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8837 (Fget_internal_run_time): Don't assume time_t fits in int.
8838 (make_time): Use list2 instead of Fcons twice.
8839 (Fdecode_time): More accurate test for out-of-range times.
8840 (check_tm_member): New function.
8841 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8842 (lisp_time_argument): Don't rely on undefined left-shift and
8843 right-shift behavior when checking for time stamp overflow.
8be6f318 8844
fe31d94c
PE
8845 * editfns.c (time_overflow): New function, refactoring common code.
8846 (Fformat_time_string, Fdecode_time, Fencode_time):
8847 (Fcurrent_time_string): Use it.
8848
8be6f318
PE
8849 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8850 * dired.c (make_time): Move to ...
8851 * editfns.c (make_time): ... here.
8852 * systime.h: Note the move.
8853
09d9db2c 88542011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8855
126bc0dc
YM
8856 * fringe.c (update_window_fringes): Remove unused variables.
8857
c47cbdfd
YM
8858 * unexmacosx.c (copy_data_segment): Also copy __got section.
8859 (Bug#8223)
8860
7ac80be9
EZ
88612011-03-12 Eli Zaretskii <eliz@gnu.org>
8862
c96bbc66 8863 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8864 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8865 Constify `char *' arguments and their references according to
8866 prototypes in tparam.h.
8867
ecb0f94d 8868 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8869
7ac80be9
EZ
8870 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8871 Adapt all references accordingly.
8872
8873 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8874
ef1fd07e
TT
88752011-03-11 Tom Tromey <tromey@redhat.com>
8876
8877 * buffer.c (syms_of_buffer): Remove obsolete comment.
8878
7ef4b50c
EZ
88792011-03-11 Eli Zaretskii <eliz@gnu.org>
8880
8881 * termhooks.h (encode_terminal_code): Declare prototype.
8882
8883 * msdos.c (encode_terminal_code): Don't declare prototype.
8884
8885 * term.c (encode_terminal_code): Now external again, used by
8886 w32console.c and msdos.c.
8887
44f230aa
SM
8888 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8889 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8890
4b1ec863 88912011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8892
1714f52b 8893 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8894
4b1ec863
PE
8895 * fringe.c (update_window_fringes): Mark locals as initialized
8896 (Bug#8227).
8897 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8898
524c7aa6
PE
8899 * alloc.c (mark_fringe_data): Move decl from here ...
8900 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8901 to check its interface.
8902 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8903
a5c0af81 8904 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8905 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8906 (fontset_font): Mark local as initialized.
a9a06e0b 8907 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8908
b4716021
PE
8909 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8910
811e9bac 8911 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8912 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8913 (x_own_selection, Fx_disown_selection_internal): Rename locals
8914 to avoid shadowing.
8915 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8916
7e3ab302
PE
8917 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8918 so that the caller can use some name other than gcpro1.
8919 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8920 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8921 (Fx_backspace_delete_keys_p):
8922 Use them to avoid shadowing, and rename vars to avoid shadowing.
8923 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8924 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8925 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8926 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8927 Remove unused locals.
7e3ab302
PE
8928 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8929 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8930 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8931 macros.
f78faa98 8932
e2b13473
PE
8933 * xterm.h (x_mouse_leave): New decl.
8934
77f23912
PE
8935 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8936 Remove unused functions.
cdf4ba58
PE
8937 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8938 (x_calc_absolute_position): Now static.
7411c686 8939 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8940 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8941 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8942 unless they are used.
38d0b34a
PE
8943 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8944 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8945 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8946 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8947 (x_error_catcher, x_connection_closed, x_error_handler):
8948 (x_error_quitter, xembed_send_message, x_iconify_frame):
8949 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8950 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8951 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8952
44f230aa
SM
8953 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8954 Rename or move locals to avoid shadowing.
6b463e58 8955 (tty_defined_color, merge_face_heights): Now static.
5967d051 8956 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8957 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8958 does not deduce is never used uninitialized.
73719eba
PE
8959 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8960 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8961
426994c3 8962 * terminal.c (store_terminal_param): Now static.
5489860b 8963
032f1620 8964 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8965 (set_frame_menubar): Remove unused local.
d4323972 8966 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8967 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8968 since they might point to immutable storage.
281585b0
PE
8969 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8970 since it's unused otherwise.
032f1620 8971
367c19e5 8972 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8973 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8974 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8975 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8976 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8977 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8978 does not deduce are never used uninitialized.
70739cbe 8979
07b48fa9
PE
8980 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8981
8868a238 8982 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8983 * window.c (window_loop, size_window):
8984 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8985
7e5cf297 8986 * window.c (display_buffer): Now static.
d6550a9f
PE
8987 (size_window): Mark variables that gcc -Wuninitialized
8988 does not deduce are never used uninitialized.
a586633d
PE
8989 * window.h (check_all_windows): New decl, to forestall
8990 gcc -Wmissing-prototypes diagnostic.
5b555da1 8991 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8992
f6095868
PE
8993 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8994 shadowing.
8995 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8996 Include <limits.h>.
8997 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8998 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8999 (load_charset_map): Mark variables that gcc -Wuninitialized
9000 does not deduce are never used uninitialized.
53df7c11 9001 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9002
f38b440c
PE
9003 * coding.c (coding_set_source, coding_set_destination):
9004 Use "else { /* comment */ }" rather than "else /* comment */;"
9005 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9006 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9007 a block, when the outer 'i' will do.
9008 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9009 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9010 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9011 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9012 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9013 Rename locals to avoid shadowing.
9014 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9015 * coding.c (emacs_mule_char, encode_invocation_designation):
9016 Now static, since they're not used elsewhere.
413bb2db 9017 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9018 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9019 (decode_coding_emacs_mule): Mark variables that gcc
9020 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9021 (detect_coding_iso_2022): Initialize a local variable that might
9022 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9023 this initialization is needed. (Bug#8211)
5f58e762
PE
9024 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9025 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9026 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9027 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9028 Remove unused macros.
f38b440c 9029
232b38b9 9030 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9031 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9032 * character.c (string_count_byte8): Likewise.
232b38b9 9033
fb90da1b
PE
9034 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9035 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9036
fb93dbc2
PE
9037 * chartab.c (copy_sub_char_table): Now static, since it's not used
9038 elsewhere.
5c156ace
PE
9039 (sub_char_table_ref_and_range, char_table_ref_and_range):
9040 Rename locals to avoid shadowing.
bbcd0949 9041 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9042
7d3b3862 9043 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9044 (BIDI_BOB): Remove unused macro.
7d3b3862 9045
6be7d3da
PE
9046 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9047 deduce are never used uninitialized.
c2ed9c8b 9048 * term.c (encode_terminal_code): Likewise.
6be7d3da 9049
75f8807f 9050 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9051
50938595
PE
9052 * tparam.h: New file.
9053 * term.c, tparam.h: Include it.
9054 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9055 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9056 Move these decls to tparam.h, and make them agree with what
9057 is actually in tparam.c. The previous trick of using incompatible
9058 decls in different modules does not conform to the C standard.
9059 All callers of tparam changed to use tparam's actual API.
9060 * tparam.c (tparam1, tparam, tgoto):
9061 Use const pointers where appropriate.
9062
fbceeba2
PE
9063 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9064 * cm.h (struct cm): Likewise.
9065 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9066 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9067 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9068 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9069 (turn_on_face, init_tty): Likewise.
9070 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9071
7f3f1250
PE
9072 * term.c (term_mouse_position): Rename local to avoid shadowing.
9073
e6ca6543
PE
9074 * alloc.c (mark_ttys): Move decl from here ...
9075 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9076
c40f8d15
AS
90772011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9078
9079 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9080
cfe0661d
JB
90812011-03-09 Juanma Barranquero <lekktu@gmail.com>
9082
9083 * search.c (compile_pattern_1): Remove argument regp, unused since
9084 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9085 (compile_pattern): Don't pass it.
9086
0afb4571
J
90872011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9088
9089 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9090 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9091 for ! HAVE_GTK3.
9092 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9093
9094 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9095
9096 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9097 gdk_window_get_screen, gdk_window_get_geometry,
9098 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9099 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9100 (xg_get_pixbuf_from_pixmap): New function.
9101 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9102 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9103 Call xg_get_pixbuf_from_pixmap instead of
9104 gdk_pixbuf_get_from_drawable.
9105 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9106 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9107 (xg_check_special_colors): Use GtkStyleContext and its functions
9108 for HAVE_GTK3.
9109 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9110 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9111 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9112 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9113 Call gtk_widget_get_preferred_size.
0afb4571
J
9114 (xg_frame_resized): gdk_window_get_geometry only takes 5
9115 parameters.
44f230aa
SM
9116 (xg_win_to_widget, xg_event_is_for_menubar):
9117 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9118 (xg_set_widget_bg): New function.
9119 (delete_cb): New function.
895009e1 9120 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9121 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9122 (xg_set_background_color): Call xg_set_widget_bg.
9123 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9124 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9125 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9126 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9127 if ! HAVE_GTK3.
9128 (update_frame_tool_bar): Call gtk_widget_hide.
9129 (xg_initialize): Use GDK_KEY_g.
9130
9131 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9132 if ! HAVE_GTK3
9133 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9134
9135 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9136 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9137 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9138
1c2cc4ef
JB
91392011-03-08 Juanma Barranquero <lekktu@gmail.com>
9140
9141 * w32xfns.c (select_palette): Check success of RealizePalette against
9142 GDI_ERROR, not zero.
9143
33383987 9144See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9145
9146;; Local Variables:
9147;; coding: utf-8
aac0c6e3
MR
9148;; End:
9149
acaf905b 9150 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9151
9152 This file is part of GNU Emacs.
9153
9154 GNU Emacs is free software: you can redistribute it and/or modify
9155 it under the terms of the GNU General Public License as published by
9156 the Free Software Foundation, either version 3 of the License, or
9157 (at your option) any later version.
9158
9159 GNU Emacs is distributed in the hope that it will be useful,
9160 but WITHOUT ANY WARRANTY; without even the implied warranty of
9161 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9162 GNU General Public License for more details.
9163
9164 You should have received a copy of the GNU General Public License
9165 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.