Add bug numbers.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
671875da 12011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2
080e5a8d
PE
3 * gnutls.c (emacs_gnutls_handshake): Don't return a garbage value.
4 Expect the caller to check whether GNUTLS_STAGE_HANDSHAKE_CANDO <=
5 proc->gnutls_initstage, if the check is needed. The check isn't
847ab9d1 6 needed for one caller, Fgnutls_boot. (Bug#8556)
080e5a8d 7 (emacs_gnutls_read): Do that check. This is the other caller.
0c8c7e5c 8 (emacs_gnutls_handle_error): Remove unused local.
7754e151 9 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 10 Remove unused local.
c8926152 11 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12
847ab9d1 13 lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
eab3844f
PE
14 GCC 4.6.0 optimizes based on type-based alias analysis. For
15 example, if b is of type struct buffer * and v of type struct
16 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
17 != &v->size, and therefore "v->size = 1; b->size = 2; return
18 v->size;" must therefore return 1. This assumption is incorrect
19 for Emacs, since it type-puns struct Lisp_Vector * with many other
20 types. To fix this problem, this patch adds a new type struct
f904488f 21 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
22 and pseudovectors, and helps optimizing compilers not get fooled
23 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
24 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
25 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
26 the size member.
eab3844f
PE
27 (XSETPVECTYPE): Rewrite in terms of new macro.
28 (XSETPVECTYPESIZE): New macro, specifying both type and size.
29 This is a bit clearer, and further avoids the possibility of
30 undesirable aliasing.
31 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 32 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
33 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
34 since Lisp_Subr is a special case (no "next" field).
f904488f
PE
35 (ASIZE): Now uses header.size rather than size. All
36 previous uses of XVECTOR (foo)->size replaced to use this macro,
37 to avoid the hassle of writing XVECTOR (foo)->header.size.
38 (struct vectorlike_header): New type.
eab3844f
PE
39 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
40 object, to help avoid aliasing.
41 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
42 (SUBRP): Likewise, since Lisp_Subr is a special case.
43 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
44 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
45 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 46 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
47 changed to be "header.size" and "header.next".
48 * buffer.h (struct buffer): Likewise.
49 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
50 * frame.h (struct frame): Likewise.
51 * process.h (struct Lisp_Process): Likewise.
52 * termhooks.h (struct terminal): Likewise.
53 * window.c (struct save_window_data, struct saved_window): Likewise.
54 * window.h (struct window): Likewise.
55 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
56 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
57 * buffer.c (init_buffer_once): Likewise.
58 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
59 special case.
60 * process.c (Fformat_network_address): Use local var for size,
61 for brevity.
62
0df1eac5
PE
63 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
64
847ab9d1 65 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
66 * data.c (atof): Remove decl; no longer used or needed.
67 (digit_to_number): Move to lread.c.
68 (Fstring_to_number): Use new string_to_number function, to be
69 consistent with how the Lisp reader treats infinities and NaNs.
70 Do not assume that floating-point numbers represent EMACS_INT
71 without losing information; this is not true on most 64-bit hosts.
72 Avoid double-rounding errors, by insisting on integers when
73 parsing non-base-10 numbers, as the documentation specifies.
74 * lisp.h (string_to_number): New decl, replacing ...
75 (isfloat_string): Remove.
bc0a5c13 76 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 77 (read1): Do not accept +. and -. as integers; this
452f4150
PE
78 appears to have been a coding error. Similarly, do not accept
79 strings like +-1e0 as floating point numbers. Do not report
80 overflow for integer overflows unless the base is not 10 which
81 means we have no simple and reliable way to continue.
82 Break out the floating-point parsing into a new
83 function string_to_number, so that Fstring_to_number parses
84 floating point numbers consistently with the Lisp reader.
85 (digit_to_number): Moved here from data.c. Make it static inline.
86 (E_CHAR, EXP_INT): Remove, replacing with ...
87 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
88 (string_to_number): New function, replacing isfloat_string.
89 This function checks for valid syntax and produces the resulting
90 Lisp float number too. Rework it so that string-to-number
bc0a5c13 91 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
92 so that overflow for non-base-10 numbers is reported only when
93 there's no portable and simple way to convert to floating point.
452f4150 94
67769ffc
PE
95 * textprop.c (set_text_properties_1): Rewrite for clarity,
96 and to avoid GCC warning about integer overflow.
97
c20db43f
PE
98 * intervals.h (struct interval): Use EMACS_INT for members
99 where EMACS_UINT might cause problems. See
100 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
101 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
102 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
103 All uses changed.
37aa2f85
PE
104 (offset_intervals): Tell GCC not to worry about length overflow
105 when negating a negative length.
c20db43f 106
2538aa2f
PE
107 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
108 (overrun_check_free): Likewise.
109
f2d3008d
PE
110 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
111 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
112 word size.
113
ec8df744
PE
114 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
115 (gnutls_make_error): Rename local to avoid shadowing.
116 (gnutls_emacs_global_deinit): ifdef out; not used.
117 (Fgnutls_boot): Use const for pointer to readonly storage.
118 Comment out unused local. Fix pointer signedness problems.
119
640ee02d
PE
120 * lread.c (openp): Don't stuff size_t into an 'int'.
121 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
122 about possible signed overflow.
123
6048fb2a
PE
124 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
125 (GDK_KEY_g): Don't define if already defined.
126 (xg_prepare_tooltip): Avoid pointer signedness problem.
127 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
128
fa3c87e1
PE
129 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
130 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
131
2172544b
PE
132 * xfns.c (Fx_window_property): Simplify a bit,
133 to make a bit faster and to avoid GCC 4.6.0 warning.
134 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
135
9b821a21
PE
136 * fns.c (internal_equal): Don't assume size_t fits in int.
137
3c616cfa
PE
138 * alloc.c (compact_small_strings): Tighten assertion a little.
139
c2982e87
PE
140 Replace pEd with more-general pI, and fix some printf arg casts.
141 * lisp.h (pI): New macro, generalizing old pEd macro to other
142 conversion specifiers. For example, use "...%"pI"d..." rather
143 than "...%"pEd"...".
144 (pEd): Remove. All uses replaced with similar uses of pI.
145 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
146 * alloc.c (check_pure_size): Don't overflow by converting size to int.
147 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
148 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
149 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
150 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
151 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
152 64-bit hosts.
153 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
154 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
155 * print.c (safe_debug_print, print_object): Likewise.
156 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
157 to int.
6f04d126
PE
158 Use pI instead of if-then-else-abort. Use %p to avoid casts,
159 avoiding the 0 flag, which is not portable.
c2982e87
PE
160 * process.c (Fmake_network_process): Use pI to avoid cast.
161 * region-cache.c (pp_cache): Likewise.
162 * xdisp.c (decode_mode_spec): Likewise.
163 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
164 behavior on 64-bit hosts with printf arg.
6f04d126 165 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
166 (x_stop_queuing_selection_requests): Likewise.
167 (x_get_window_property): Don't truncate byte count to an 'int'
168 when tracing.
0b432f21 169
5e073ec7
PE
170 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
171 here, since it parses constructs like leading '-' and spaces,
172 which are not wanted; and it overflows with large numbers.
173 Instead, simply match F[0-9]+, which is what is wanted anyway.
174
36372bf9
PE
175 * alloc.c: Remove unportable assumptions about struct layout.
176 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
177 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
178 (allocate_vectorlike, make_pure_vector): Use the new macros,
179 plus offsetof, to remove unportable assumptions about struct layout.
180 These assumptions hold on all porting targets that I know of, but
181 they are not guaranteed, they're easy to remove, and removing them
182 makes further changes easier.
183
0b432f21
PE
184 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
185 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
186 (string_overrun_cookie): Now const. Use initializers that
187 don't formally overflow signed char, to avoid warnings.
000098c1
PE
188 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
189 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
190 (allocate_buffer): Don't assume sizeof (struct buffer) is a
191 multiple of sizeof (EMACS_INT); it need not be, if
192 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 193 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 194
f2d3ba6f
DN
1952011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
196
197 * alloc.c (check_sblock, check_string_bytes)
198 (check_string_free_list): Convert to standard C.
199
42ce4c63
TZ
2002011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
201
202 * w32.c (emacs_gnutls_push): Fix typo.
203
825cd63c
EZ
2042011-04-25 Eli Zaretskii <eliz@gnu.org>
205
fb11d64d
EZ
206 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
207 "cast to pointer from integer of different size".
208
825cd63c
EZ
209 Improve doprnt and its use in verror. (Bug#8545)
210 * doprnt.c (doprnt): Document the set of format control sequences
211 supported by the function. Use SAFE_ALLOCA instead of always
212 using `alloca'.
213
214 * eval.c (verror): Don't limit the buffer size at size_max-1, that
215 is one byte too soon. Don't use xrealloc; instead xfree and
216 xmalloc anew.
217
e061a11b
TZ
2182011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
219
220 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
221 callbacks stage.
222
223 * gnutls.c: Renamed global_initialized to
224 gnutls_global_initialized. Added internals for the
225 :verify-hostname-error, :verify-error, and :verify-flags
226 parameters of `gnutls-boot' and documented those parameters in the
227 docstring. Start callback support.
228 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
229 unless a fatal error occured. Call gnutls_alert_send_appropriate
230 on error. Return error code.
231 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
232 (emacs_gnutls_read): Likewise.
233 (Fgnutls_boot): Return handshake error code.
234 (emacs_gnutls_handle_error): New function.
235 (wsaerror_to_errno): Likewise.
236
237 * w32.h (emacs_gnutls_pull): Add prototype.
238 (emacs_gnutls_push): Likewise.
239
240 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
241 (emacs_gnutls_push): Likewise.
242
2432011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
244
245 * process.c (wait_reading_process_output): Check if GnuTLS
246 buffered some data internally if no FDs are set for TLS
247 connections.
248
249 * makefile.w32-in (OBJ2): Add gnutls.$(O).
250 (LIBS): Link to USER_LIBS.
251 ($(BLD)/gnutls.$(0)): New target.
252
fa6996bc
EZ
2532011-04-24 Eli Zaretskii <eliz@gnu.org>
254
eb35682e
EZ
255 * xdisp.c (handle_single_display_spec): Rename the
256 display_replaced_before_p argument into display_replaced_p, to
257 make it consistent with the commentary. Fix typos in the
258 commentary.
259
e2ad650c
EZ
260 * textprop.c (syms_of_textprop): Remove dead code.
261 (copy_text_properties): Delete obsolete commentary about an
262 interface that was deleted long ago. Fix typos in the description
263 of arguments.
264
1b2de274
EZ
265 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
266 to changes in oldXMenu/XMenu.h from 2011-04-16.
267 <menu_help_message, prev_menu_help_message>: Constify.
268 (IT_menu_make_room): menu->help_text is now `const char **';
269 adjust.
270
271 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
272 to changes in oldXMenu/XMenu.h from 2011-04-16.
273 (struct XMenu): Declare `help_text' `const char **'.
274
275 * xfaces.c <Qunspecified>: Make extern again.
276
277 * syntax.c: Include sys/types.h before including regex.h, as
278 required by Posix.
279
762b15be
EZ
280 * doc.c (get_doc_string): Improve the format passed to `error'.
281
282 * doprnt.c (doprnt): Improve commentary.
283
284 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
285
286 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
287 them with etags.
288
f1052e5d
EZ
289 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
290 changes in globals.h immediately force recompilation.
762b15be
EZ
291 (TAGS): Depend on $(CURDIR)/m/intel386.h and
292 $(CURDIR)/s/ms-w32.h.
293 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 294
fa6996bc
EZ
295 * character.c (Fchar_direction): Function deleted.
296 (syms_of_character): Don't defsubr it.
297 <char-direction-table>: Deleted.
298
e6c3da20
EZ
2992011-04-23 Eli Zaretskii <eliz@gnu.org>
300
301 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
302 * doprnt.c: Include limits.h.
303 (SIZE_MAX): New macro.
304 (doprnt): Return a size_t value. 2nd arg is now size_t. Many
305 local variables are now size_t instead of int or unsigned.
306 Improve overflow protection. Support `l' modifier for integer
307 conversions. Support %l conversion. Don't assume an EMACS_INT
308 argument for integer conversions and for %c.
309
310 * lisp.h (doprnt): Restore prototype.
311
312 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
313 $(SRC)/character.h.
314
315 * Makefile.in (base_obj): Add back doprnt.o.
316
317 * deps.mk (doprnt.o): Add back prerequisites.
318 (callint.o): Depend on character.h.
319
320 * eval.c (internal_lisp_condition_case): Include the handler
321 representation in the error message.
322 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
323 when breaking from the loop.
324
325 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
326
327 * callint.c (Fcall_interactively): When displaying error message
328 about invalid control letter, pass the character's codepoint, not
329 a pointer to its multibyte form. Improve display of the character
330 in octal and display also its hex code.
331
332 * character.c (char_string): Use %x to display the (unsigned)
333 codepoint of an invalid character, to avoid displaying a bogus
334 negative value.
335
336 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
337 `error', not SYMBOL_NAME itself.
338
339 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
340 character arguments to `error'.
341
342 * charset.c (check_iso_charset_parameter): Fix incorrect argument
343 to `error' in error message about FINAL_CHAR argument. Make sure
344 FINAL_CHAR is a character, and use %c when it is passed as
345 argument to `error'.
346
4ffd0d6b 3472011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
348
349 * s/ms-w32.h (localtime): Redirect to sys_localtime.
350
351 * w32.c: Include <time.h>.
352 (sys_localtime): New function.
353
4ffd0d6b 3542011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
355
356 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
357
4ffd0d6b 358 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 359
4ffd0d6b 3602011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 361
4ffd0d6b
GM
362 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
363 zombies (Bug#8467).
aac0c6e3 364
04c56954
EZ
3652011-04-19 Eli Zaretskii <eliz@gnu.org>
366
367 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
368 gl_state.e_property when gl_state.object is Qt.
369
370 * insdel.c (make_gap_larger): Remove limitation of buffer size
371 to <= INT_MAX.
372
16a43933
CY
3732011-04-18 Chong Yidong <cyd@stupidchicken.com>
374
375 * xdisp.c (lookup_glyphless_char_display)
376 (produce_glyphless_glyph): Handle cons cell entry in
377 glyphless-char-display.
378 (Vglyphless_char_display): Document it.
379
380 * term.c (produce_glyphless_glyph): Handle cons cell entry in
381 glyphless-char-display.
382
4581706e
CY
3832011-04-17 Chong Yidong <cyd@stupidchicken.com>
384
385 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
386
387 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
388
389 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
390 definition for no-X builds.
391
4887c6e2 3922011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 393
fd35b6f9
PE
394 Static checks with GCC 4.6.0 and non-default toolkits.
395
5c1ccb01
PE
396 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
397
006c5daa
PE
398 * process.c (keyboard_bit_set): Define only if SIGIO.
399 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
400 (send_process): Repair possible setjmp clobbering.
401
efc736d3
PE
402 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
403
4e2fe2e6
PE
404 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
405
f97334a2
PE
406 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
407
4e75f29d
PE
408 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
409 Define only if needed.
410
90efadd1
PE
411 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
412 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 413 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 414
3c647824
PE
415 * dispextern.h (struct redisplay_interface): Rename param
416 to avoid shadowing.
e264f262 417 * termhooks.h (struct terminal): Likewise.
761383f4 418 * xterm.c (xembed_send_message): Likewise.
3c647824 419
b58c5c4a
PE
420 * insdel.c (make_gap_smaller): Define only if
421 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
422
cad59032
PE
423 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
424 it.
425
c339dc2e
PE
426 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
427 so that we aren't warned about unused symbols.
428
91a3e27b
PE
429 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
430
399c71d3 431 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 432
8ffc96f5
PE
433 * xfns.c (x_real_positions): Mark locals as initialized.
434
eef9bc79
PE
435 * xmenu.c (xmenu_show): Don't use uninitialized vars.
436
098db9dd
PE
437 * xterm.c: Fix problems found by static analysis with other toolkits.
438 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
439 (x_dispatch_event): Declare static if USE_GTK, and
440 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 441 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 442 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
443 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
444 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
445
eb18f6cc
PE
446 * xmenu.c (menu_help_callback): Pointer type fixes.
447 Use const pointers when pointing at readonly data. Avoid pointer
448 signedness clashes.
449 (FALSE): Remove unused macro.
450 (update_frame_menubar): Remove unused decl.
451
1fe72bf8
PE
452 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
453
60d9e1db
PE
454 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
455 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
456 (single_menu_item): Rename local to avoid shadowing.
457
39261c26
PE
458 * keyboard.c (make_lispy_event): Remove unused local var.
459
018c5e19
PE
460 * frame.c, frame.h (x_get_resource_string): Bring this back, but
461 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
462
63d2b86e
PE
463 * bitmaps: Change bitmaps from unsigned char back to the X11
464 compatible char. Avoid the old compiler warnings about
465 out-of-range initializers by using, for example, '\xab' rather
466 than 0xab.
467
aefd87e1
PE
468 * xgselect.c (xgselect_initialize): Check vs interface
469 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
470
bf501fb9
PE
471 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
472
e9829fdf
PE
473 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
474 to read-only memory.
475
1086c095
PE
476 * fns.c (vector): Remove; this old hack is no longer needed.
477
2baccd04 478 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 479 Remove unused var.
dde42981 480 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 481
72391843 482 * xrdb.c (x_load_resources): Omit unused local.
3565b346 483
436c16df 484 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 485 (x_window): Rename locals to avoid shadowing.
dc5ddd85 486 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 487
92bb796d 488 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 489 (x_term_init): Remove local to avoid shadowing.
92bb796d 490
764430a3 491 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
492
493 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
494 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
495
d1dfb56c
EZ
4962011-04-16 Eli Zaretskii <eliz@gnu.org>
497
c4354cb4
EZ
498 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
499
d1dfb56c
EZ
500 Fix regex.c, syntax.c and friends for buffers > 2GB.
501 * syntax.h (struct gl_state_s): Declare character position members
502 EMACS_INT.
503
504 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
505
506 * textprop.c (verify_interval_modification, interval_of): Declare
507 arguments EMACS_INT.
508
509 * intervals.c (adjust_intervals_for_insertion): Declare arguments
510 EMACS_INT.
511
512 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
513
514 * indent.c (Fvertical_motion): Local variable it_start is now
515 EMACS_INT.
516
517 * regex.c (re_match, re_match_2, re_match_2_internal)
518 (bcmp_translate, regcomp, regexec, print_double_string)
519 (group_in_compile_stack, re_search, re_search_2, regex_compile)
520 (re_compile_pattern, re_exec): Declare arguments and local
521 variables `size_t' and `ssize_t' and return values `regoff_t', as
522 appropriate.
523 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
524 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
525 <compile_stack_type>: `size' and `avail' are now `size_t'.
526
527 * regex.h <regoff_t>: Use ssize_t, not int.
528 (re_search, re_search_2, re_match, re_match_2): Arguments that
529 specify buffer/string position and length are now ssize_t and
530 size_t. Return type is regoff_t.
531
613052cd
BK
5322011-04-16 Ben Key <bkey76@gmail.com>
533
534 * nsfont.m: Fixed bugs in ns_get_family and
535 ns_descriptor_to_entity that were caused by using free to
536 deallocate memory blocks that were allocated by xmalloc (via
537 xstrdup). This caused Emacs to crash when compiled with
538 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
539 --enable-checking=xmallocoverrun). xfree is now used to
540 deallocate these memory blocks.
541
4170f62f 5422011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 543
71b41406
PE
544 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
545
9587a89d
PE
546 emacs_write: Accept and return EMACS_INT for sizes.
547 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
548 et seq.
549 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
550 Accept and return EMACS_INT.
551 (emacs_gnutls_write): Return the number of bytes written on
552 partial writes.
553 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
554 (emacs_read, emacs_write): Remove check for negative size, as the
555 Emacs source code has been audited now.
9587a89d
PE
556 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
557 (emacs_read, emacs_write): Use it.
273a5f82
PE
558 * process.c (send_process): Adjust to the new signatures of
559 emacs_write and emacs_gnutls_write. Do not attempt to store
560 a byte offset into an 'int'; it might overflow.
9587a89d 561 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 562
3e047f51
PE
563 * sound.c: Don't assume sizes fit in 'int'.
564 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 565 Return EMACS_INT, not int.
3e047f51 566 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
567 Accept EMACS_INT, not int.
568 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
569 record read return values.
570
cc39a9db
BK
5712011-04-15 Ben Key <bkey76@gmail.com>
572
c9d0ec6d
JB
573 * keyboard.c (Qundefined): Don't declare static since it is used
574 in nsfns.m.
575 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
576 static since they are used in nsfont.m.
cc39a9db 577
6c60eb9f
SM
5782011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
579
580 * process.c (Qprocessp): Don't declare static.
581 * lisp.h (Qprocessp): Declare again.
582
7990b61a
JB
5832011-04-15 Juanma Barranquero <lekktu@gmail.com>
584
585 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
586
5d4cb038
PE
5872011-04-14 Paul Eggert <eggert@cs.ucla.edu>
588
8bd7b830 589 Improve C-level modularity by making more things 'static'.
cd64ea1d 590
e3b27b31
PE
591 Don't publish debugger-only interfaces to other modules.
592 * lisp.h (safe_debug_print, debug_output_compilation_hack):
593 (verify_bytepos, count_markers): Move decls to the only modules
594 that need them.
595 * region-cache.h (pp_cache): Likewise.
596 * window.h (check_all_windows): Likewise.
597 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
598
5d4cb038
PE
599 * sysdep.c (croak): Now static, if
600 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
601 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
602
603 * alloc.c (refill_memory_reserve): Now static if
604 !defined REL_ALLOC || defined SYSTEM_MALLOC.
605 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 606
e87b6180
PE
607 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
608 Define only if USE_LUCID.
609
ac64929e
PE
610 * xrdb.c (x_customization_string, x_rm_string): Now static.
611
6f37259d
PE
612 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
613 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
614
1683e3ab
PE
615 * xdisp.c (draw_row_with_mouse_face): Now static.
616 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
617
de9c2632
PE
618 * window.h (check_all_windows): Mark externally visible.
619
2b96acb7
PE
620 * window.c (window_deletion_count): Now static.
621
622 * undo.c: Make symbols static if they're not exported.
623 (last_undo_buffer, last_boundary_position, pending_boundary):
624 Now static.
625
50436f33
PE
626 * textprop.c (interval_insert_behind_hooks): Now static.
627 (interval_insert_in_front_hooks): Likewise.
628
64520e5c
PE
629 * term.c: Make symbols static if they're not exported.
630 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
631 (max_frame_lines, tty_set_terminal_modes):
632 (tty_reset_terminal_modes, tty_turn_off_highlight):
633 (get_tty_terminal): Now static.
634 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
635 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 636 HAVE_WINDOW_SYSTEM.
64520e5c
PE
637 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
638 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
639
1fa53021
PE
640 * sysdep.c: Make symbols static if they're not exported.
641 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
642 Now static.
643 (sigprocmask_set, full_mask): Remove; unused.
644 (wait_debugging): Mark as visible.
645 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
646 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
647
d4b43b22
PE
648 * syntax.c (syntax_temp): Define only if !__GNUC__.
649
b7c513d0
PE
650 * sound.c (current_sound_device, current_sound): Now static.
651
989b29ad
PE
652 * search.c (searchbufs, searchbuf_head): Now static.
653
13a55a78
PE
654 * scroll.c (scroll_cost): Remove; unused.
655 * dispextern.h (scroll_cost): Remove decl.
656
de68a1fc
PE
657 * region-cache.h (pp_cache): Mark as externally visible.
658
40ccffa6
PE
659 * process.c: Make symbols static if they're not exported.
660 (process_tick, update_tick, create_process, chan_process):
661 (Vprocess_alist, proc_buffered_char, datagram_access):
662 (fd_callback_data, send_process_frame, process_sent_to): Now static.
663 (deactivate_process): Mark defn as static, as well as decl.
664 * lisp.h (create_process): Remove decl.
665 * process.h (chan_process, Vprocess_alist): Remove decls.
666
ad64fc97
PE
667 * print.c: Make symbols static if they're not exported.
668 (print_depth, new_backquote_output, being_printed, print_buffer):
669 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
670 (print_interval, print_number_index, initial_stderr_stream):
671 Now static.
672 * lisp.h (Fprinc): Remove decl.
673 (debug_output_compilation_hack): Mark as externally visible.
674
adddb265
PE
675 * sysdep.c (croak): Move decl from here to syssignal.h.
676 * syssignal.h (croak): Put it here, so the API can be checked when
677 'croak' is called from dissociate_if_controlling_tty.
678
1717ede2
PE
679 * minibuf.c: Make symbols static if they're not exported.
680 (minibuf_save_list, choose_minibuf_frame): Now static.
681 * lisp.h (choose_minibuf_frame): Remove decl.
682
fa5fb2bc
PE
683 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
684
1e3890d1
PE
685 * lread.c: Make symbols static if they're not exported.
686 (read_objects, initial_obarray, oblookup_last_bucket_number):
687 Now static.
688 (make_symbol): Remove; unused.
689 * lisp.h (initial_obarray, make_symbol): Remove decls.
690
8a1414fa
PE
691 * keyboard.c: Make symbols static if they're not exported.
692 (single_kboard, recent_keys_index, total_keys, recent_keys):
693 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
694 (this_single_command_key_start, echoing, last_auto_save):
695 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
696 (command_loop, echo_now, keyboard_init_hook, help_char_p):
697 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
698 (Vlispy_mouse_stem, double_click_count):
699 Now static.
700 (force_auto_save_soon): Define only if SIGDANGER.
701 (ignore_mouse_drag_p): Now static if
702 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
703 (print_help): Remove; unused.
704 (stop_character, last_timer_event): Mark as externally visible.
705 * keyboard.h (ignore_mouse_drag_p): Declare only if
706 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
707 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
708 * lisp.h (echoing): Remove decl.
709 (force_auto_save_soon): Declare only if SIGDANGER.
710 * xdisp.c (redisplay_window): Simplify code, to make it more
711 obvious that ignore_mouse_drag_p is not accessed if !defined
712 USE_GTK && !defined HAVE_NS.
713
93ea6e8f
PE
714 * intervals.c: Make symbols static if they're not exported.
715 (merge_properties_sticky, merge_interval_right, delete_interval):
716 Now static.
717 * intervals.h (merge_interval_right, delete_interval): Remove decls.
718
77382fcc
PE
719 * insdel.c: Make symbols static if they're not exported.
720 However, leave prepare_to_modify_buffer alone. It's never
721 called from outside this function, but that appears to be a bug.
722 (combine_after_change_list, combine_after_change_buffer):
4889fc82 723 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
724 (adjust_after_replace_noundo): Remove; unused.
725 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 726 (signal_before_change): Remove decls.
77382fcc 727
9306c32e
PE
728 * indent.c (val_compute_motion, val_vmotion): Now static.
729
cd44d2eb
PE
730 * image.c: Make symbols static if they're not exported.
731 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
732 if USE_GTK.
733 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
734 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
735
ad9a7a06
PE
736 * fringe.c (standard_bitmaps): Now static.
737 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
738
81626931
PE
739 * frame.c: Make symbols static if they're not exported.
740 (x_report_frame_params, make_terminal_frame): Now static.
741 (get_frame_param): Now static, unless HAVE_NS.
742 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
743 (x_get_resource_string): Remove; not used.
744 * frame.h (make_terminal_frame, x_report_frame_params):
745 (x_get_resource_string); Remove decls.
746 (x_fullscreen_adjust): Declare only if WINDOWSNT.
747 * lisp.h (get_frame_param): Declare only if HAVE_NS.
748
239f9db9
PE
749 * font.c, fontset.c: Make symbols static if they're not exported.
750 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
751 (FACE_SUITABLE_FOR_CHAR_P): Use it.
752 * font.c (font_close_object): Now static.
753 * font.h (font_close_object): Remove.
754 * fontset.c (FONTSET_OBJLIST): Remove.
755 (free_realized_fontset) #if-0 the body, which does nothing.
756 (face_suitable_for_char_p): #if-0, as it's never called.
757 * fontset.h (face_suitable_for_char_p): Remove decl.
758 * xfaces.c (face_at_string_position): Use
759 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
760 since 0 is always ASCII.
761
dfcf3579
PE
762 * fns.c (weak_hash_tables): Now static.
763
5045092b
PE
764 * fileio.c: Make symbols static if they're not exported.
765 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
766 (Vwrite_region_annotation_buffers): Now static.
767
57a96f5c
PE
768 * eval.c: Make symbols static if they're not exported.
769 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
770 * lisp.h (backtrace_list): Remove decl.
771
35f08c38
PE
772 * emacs.c: Make symbols static if they're not exported.
773 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
774 (fatal_error_code, fatal_error_signal_hook, standard_args):
775 Now static.
776 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
777 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
778 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
779 * lisp.h (fatal_error_signal_hook): Remove decl.
780 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
781
f44bd759
PE
782 * editfns.c: Move a (normally-unused) function to its only use.
783 * editfns.c, lisp.h (get_operating_system_release): Remove.
784 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
785 worth the hassle of breaking this out.
786
b532497d
PE
787 * xterm.c: Make symbols static if they're not exported.
788 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
789 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
790 (x_destroy_window, x_delete_display):
791 Now static.
792 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
793 (x_mouse_leave): Remove; unused.
794 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
795 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
796 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
797 Remove decls.
798 (x_mouse_leave): Declare only if WINDOWSNT.
799 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
800 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
801 USE_X_TOOLKIT.
802
1675728f
PE
803 * ftxfont.c: Make symbols static if they're not exported.
804 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
805 HAVE_FREETYPE.
806 * font.h (ftxfont_driver): Likewise.
807
e4cebfca
PE
808 * xfns.c: Make symbols static if they're not exported.
809 (x_last_font_name, x_display_info_for_name):
810 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
811 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
812 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
813 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
814 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
815 (last_show_tip_args): Now static.
816 (xic_defaut_fontset, xic_create_fontsetname): Define only if
817 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
818 (x_screen_planes): Remove; unused.
819 * dispextern.h (x_screen_planes): Remove decl.
820
5bf46f05
PE
821 * dispnew.c: Make symbols static if they're not exported.
822 * dispextern.h (redraw_garbaged_frames, scrolling):
823 (increment_row_positions): Remove.
824 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
825 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
826 Now static.
827 (redraw_garbaged_frames): Remove; unused.
828
435f4c28
PE
829 * xfaces.c: Make symbols static if they're not exported.
830 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
831 Remove decls.
832 * xterm.h (defined_color): Remove decls.
833 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
834 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
835 (menu_face_changed_default, defined_color, free_realized_face):
836 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
837 (ascii_face_of_lisp_face): Remove; unused.
838
8524aef3
PE
839 * xdisp.c: Make symbols static if they're not exported.
840 * dispextern.h (scratch_glyph_row, window_box_edges):
841 (glyph_to_pixel_coords, set_cursor_from_row):
842 (get_next_display_element, set_iterator_to_next):
843 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
844 (show_mouse_face): Remove decls
845 * frame.h (message_buf_print): Likewise.
846 * lisp.h (pop_message, set_message, check_point_in_composition):
847 Likewise.
848 * xterm.h (set_vertical_scroll_bar): Likewise.
849 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
850 (message_buf_print, scratch_glyph_row, displayed_buffer):
851 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
852 (get_next_display_element, show_mouse_face, window_box_edges):
853 (frame_to_window_pixel_xy, check_point_in_composition):
854 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
855 (glyph_to_pixel_coords): Remove; unused.
856
16390cd2
PE
857 * dired.c (file_name_completion): Now static.
858
859 * dbusbind.c (xd_in_read_queued_messages): Now static.
860
a25f4dfa
PE
861 * lisp.h (circular_list_error, FOREACH): Remove; unused.
862 * data.c (circular_list_error): Remove.
863
14a9c8df
PE
864 * commands.h (last_point_position, last_point_position_buffer):
865 (last_point_position_window): Remove decls.
866 * keyboard.c: Make these variables static.
867
74ab6df5
PE
868 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
869 decls.
870 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
871 (iso_code_class, detect_coding, code_convert_region): Now static.
872 (encode_coding_gap): Remove; unused.
873
38dfbee1
PE
874 * chartab.c (chartab_chars, chartab_bits): Now static.
875
a2cb4e63
PE
876 * charset.h (charset_iso_8859_1): Remove decl.
877 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
878 Now static.
879
127198fd
PE
880 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
881 * ccl.c (Vccl_program_table): Now static.
882 (check_ccl_update): Remove; unused.
883
d85b608f
PE
884 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
885 * category.h: ... from here.
886 * category.c (check_category_table, set_category_set): Now static.
887
31cd66f3
PE
888 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
889 * lisp.h: Remove these decls.
890
c358e587
PE
891 * buffer.c (buffer_count): Remove unused var.
892
e78aecca
PE
893 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
894 so that it's not optimized away.
895 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
896 * dispextern.h (bidi_dump_cached_states): Remove, since it's
897 exported only to the debugger.
898
e192d7d3
PE
899 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
900 * atimer.h (run_all_atimers): Removed; not exported.
901
92470028
PE
902 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
903 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
904 was inaccessible from Lisp.
905 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
906 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
907
244ed907
PE
908 alloc.c: Import and export fewer symbols, and remove unused items.
909 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
910 is defined.
911 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
912 it's not optimized away by whole-program optimization.
913 (message_enable_multibyte, free_misc): Remove.
914 (catchlist, handlerlist, mark_backtrace):
915 Declare only if BYTE_MARK_STACK.
916 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
917 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
918 (message_enable_multibyte): Remove decl.
919 (free_misc, interval_free_list, float_block, float_block_index):
920 (n_float_blocks, float_free_list, cons_block, cons_block_index):
921 (cons_free_list, last_marked_index):
922 Now static.
923 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
924 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
925 (mark_backtrace): Define only if BYTE_MARK_STACK.
926 * xdisp.c (message_enable_multibyte): Now static.
927
61c2b50e 928 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
929 This makes it easier for human readers (and static analyzers)
930 to see whether these variables are used from other modules.
931 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
932 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
933 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
934 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
935 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
936 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
937 * xmenu.c, xselect.c:
938 Declare Q* vars static if they are not used in other modules.
939 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
940 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
941 Remove decls of unexported vars.
942 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
943
95c82688
PE
944 * lisp.h (DEFINE_FUNC): Make sname 'static'.
945
16a97296
PE
946 Make Emacs functions such as Fatom 'static' by default.
947 This makes it easier for human readers (and static analyzers)
948 to see whether these functions can be called from other modules.
949 DEFUN now defines a static function. To make the function external
950 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
951 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
952 (Finit_image_library):
16a97296
PE
953 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
954 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
955 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
956 Remove decls, since these functions are now static.
957 (Funintern, Fget_internal_run_time): New decls, since these functions
958 were already external.
95c82688 959
16a97296
PE
960 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
961 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
962 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
963 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
964 * keyboard.c, keymap.c, lread.c:
965 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
966 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
967 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
968 Mark functions with DEFUE instead of DEFUN,
969 if they are used in other modules.
970 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
971 decls for now-static functions.
972 * buffer.h (Fdelete_overlay): Remove decl.
973 * callproc.c (Fgetenv_internal): Mark as internal.
974 * composite.c (Fremove_list_of_text_properties): Remove decl.
975 (Fcomposition_get_gstring): New forward static decl.
976 * composite.h (Fcomposite_get_gstring): Remove decl.
977 * dired.c (Ffile_attributes): New forward static decl.
978 * doc.c (Fdocumntation_property): New forward static decl.
979 * eval.c (Ffetch_bytecode): New forward static decl.
980 (Funintern): Remove extern decl; now in .h file where it belongs.
981 * fileio.c (Fmake_symbolic_link): New forward static decl.
982 * image.c (Finit_image_library): New forward static decl.
983 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
984 * intervals.h (Fprevious_property_change):
985 (Fremove_list_of_text_properties): Remove decls.
986 * keyboard.c (Fthis_command_keys): Remove decl.
987 (Fcommand_execute): New forward static decl.
988 * keymap.c (Flookup_key): New forward static decl.
989 (Fcopy_keymap): Now static.
990 * keymap.h (Flookup_key): Remove decl.
991 * process.c (Fget_process): New forward static decl.
992 (Fprocess_datagram_address): Mark as internal.
993 * syntax.c (Fsyntax_table_p): New forward static decl.
994 (skip_chars): Remove duplicate decl.
995 * textprop.c (Fprevious_property_change): New forward static decl.
996 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
997 Now internal.
998 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
999 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
1000
785bbd42
PE
1001 * editfns.c (Fformat): Remove unreachable code.
1002
8b913b57
AS
10032011-04-14 Andreas Schwab <schwab@linux-m68k.org>
1004
1005 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
1006 change. (Bug#8496)
1007
a6744a35
EZ
10082011-04-13 Eli Zaretskii <eliz@gnu.org>
1009
1010 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
1011 when at ZV. (Bug#8487)
1012
e7974947
AS
10132011-04-12 Andreas Schwab <schwab@linux-m68k.org>
1014
baad03f0
AS
1015 * charset.c (Fclear_charset_maps): Use xfree instead of free.
1016 (Bug#8437)
1017 * keyboard.c (parse_tool_bar_item): Likewise.
1018 * sound.c (sound_cleanup, alsa_close): Likewise.
1019 * termcap.c (tgetent): Likewise.
1020 * xfns.c (x_default_font_parameter): Likewise.
1021 * xsettings.c (read_and_apply_settings): Likewise.
1022
e7974947
AS
1023 * alloc.c (overrun_check_malloc, overrun_check_realloc)
1024 (overrun_check_free): Protoize.
1025
28272684
PE
10262011-04-12 Paul Eggert <eggert@cs.ucla.edu>
1027
1028 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
1029 since callers should never pass a negative size.
1030 Change the signature to match that of plain 'read' and 'write'; see
1031 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
1032 * lisp.h: Update prototypes of emacs_write and emacs_read.
1033
11997c76
EZ
10342011-04-11 Eli Zaretskii <eliz@gnu.org>
1035
1036 * xdisp.c (redisplay_window): Don't try to determine the character
1037 position of the scroll margin if the window start point w->startp
e896f03c 1038 is outside the buffer's accessible region. (Bug#8468)
11997c76 1039
8a2cbd72
EZ
10402011-04-10 Eli Zaretskii <eliz@gnu.org>
1041
1042 Fix write-region and its subroutines for buffers > 2GB.
1043 * fileio.c (a_write, e_write): Modify declaration of arguments and
1044 local variables to support buffers larger than 2GB.
1045 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
1046
1047 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
1048 argument, local variables, and return value.
1049
1050 * lisp.h: Update prototypes of emacs_write and emacs_read.
1051
1052 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
1053
4073e537 10542011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 1055
1ebfdcb6
PE
1056 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
1057
b2ded58d
PE
1058 Fix more problems found by GCC 4.6.0's static checks.
1059
7d66342c
PE
1060 * xdisp.c (vmessage): Use a better test for character truncation.
1061
bbf47d44
PE
1062 * charset.c (load_charset_map): <, not <=, for optimization,
1063 and to avoid potential problems with integer overflow.
9248994d 1064 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 1065 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 1066 * editfns.c (Fformat): Likewise.
1e69125e 1067 * syntax.c (skip_chars): Likewise.
3befa583 1068
e3019616
PE
1069 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
1070 This also lets GCC 4.6.0 generate slightly better loop code.
1071
becfa255
PE
1072 * callint.c (Fcall_interactively): <, not <=, for optimization.
1073 (Fcall_interactively): Count the number of arguments produced,
1074 not the number of arguments given. This is simpler and lets GCC
1075 4.6.0 generate slightly better code.
1076
dae0cd48
PE
1077 * ftfont.c: Distingish more carefully between FcChar8 and char.
1078 The previous code passed unsigned char * to a functions like
1079 strlen and xstrcasecmp that expect char *, which does not
1080 conform to the C standard.
1081 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
1082 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
1083 char * when the C standard requires it.
1084
76032d70
PE
1085 * keyboard.c (read_char): Remove unused var.
1086
eb3f1cc8
PE
1087 * eval.c: Port to Windows vsnprintf (Bug#8435).
1088 Include <limits.h>.
1089 (SIZE_MAX): Define if the headers do not.
1090 (verror): Do not give up if vsnprintf returns a negative count.
1091 Instead, grow the buffer. This ports to Windows vsnprintf, which
1092 does not conform to C99. Problem reported by Eli Zaretskii.
1093 Also, simplify the allocation scheme, by avoiding the need for
1094 calling realloc, and removing the ALLOCATED variable.
1095
70476b54
PE
1096 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
1097
12020a9e
PE
1098 Remove invocations of doprnt, as Emacs now uses vsnprintf.
1099 But keep the doprint source code for now, as we might revamp it
1100 and use it again (Bug#8435).
ea6c7ae6
PE
1101 * lisp.h (doprnt): Remove.
1102 * Makefile.in (base_obj): Remove doprnt.o.
1103 * deps.mk (doprnt.o): Remove.
1104
5fdb398c
PE
1105 error: Print 32- and 64-bit integers portably (Bug#8435).
1106 Without this change, on typical 64-bit hosts error ("...%d...", N)
1107 was used to print both 32- and 64-bit integers N, which relied on
1108 undefined behavior.
1109 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
1110 New macro.
1111 * lisp.h (error, verror): Mark as printf-like functions.
1112 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
1113 Report overflow in size calculations when allocating printf buffer.
1114 Do not truncate output string at its first null byte.
1115 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
1116 Truncate the output at a character boundary, since vsnprintf does not
1117 do that.
1118 * charset.c (check_iso_charset_parameter): Convert internal
1119 character to string before calling 'error', since %c now has the
1120 printf meaning.
1121 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
1122 overflow when computing char to be passed to 'error'. Do not
1123 pass Lisp_Object to 'error'; pass the integer instead.
1124 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
1125 formatted with plain %d.
1126
b189fa66
PE
1127 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
1128
bff87ef0
PE
1129 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
1130
7e2cac20
PE
1131 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
1132
ce4d90b5
PE
1133 * xterm.c (x_catch_errors): Remove duplicate declaration.
1134
266c9547
PE
1135 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
1136
79c49ad2
PE
1137 * xdisp.c, lisp.h (message_nolog): Remove; unused.
1138
368f4090
JM
11392011-04-10 Jim Meyering <meyering@redhat.com>
1140
1141 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
1142 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
1143 return ssize_t not "int", and use size_t as the buffer length.
1144 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
1145 * gnutls.h: Update declarations.
1146 * process.c (read_process_output): Use ssize_t, to match.
1147 (send_process): Likewise.
1148
a32d4040
CY
11492011-04-09 Chong Yidong <cyd@stupidchicken.com>
1150
1151 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
1152
8546720e 11532011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 1154
8546720e
GM
1155 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
1156 unsigned char, to match FcChar8 type definition.
aac0c6e3 1157
8546720e
GM
1158 * xterm.c (handle_one_xevent):
1159 * xmenu.c (create_and_show_popup_menu):
1160 * xselect.c (x_decline_selection_request)
1161 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 1162
0a2f5c1a 11632011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
1164
1165 Fix some uses of `int' instead of EMACS_INT.
1166 * search.c (string_match_1, fast_string_match)
1167 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
1168 (scan_buffer, find_next_newline_no_quit)
1169 (find_before_next_newline, search_command, Freplace_match)
1170 (Fmatch_data): Make some `int' variables be EMACS_INT.
1171
1172 * xdisp.c (display_count_lines): 3rd argument and return value now
1173 EMACS_INT. All callers changed.
1174 (pint2hrstr): Last argument is now EMACS_INT.
1175
1176 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
1177 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
1178 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
1179 (decode_coding_utf_16, decode_coding_emacs_mule)
1180 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
1181 (decode_coding_ccl, decode_coding_charset)
1182 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
1183 (decode_coding_iso_2022, decode_coding_emacs_mule)
1184 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
1185 <char_offset, last_offset>: Declare EMACS_INT.
1186 (encode_coding_utf_8, encode_coding_utf_16)
1187 (encode_coding_emacs_mule, encode_invocation_designation)
1188 (encode_designation_at_bol, encode_coding_iso_2022)
1189 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
1190 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
1191 Declare EMACS_INT.
1192 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
1193 (encode_invocation_designation): Last argument P_NCHARS is now
1194 EMACS_INT.
1195 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
1196 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
1197
1198 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
1199 All users changed.
1200
1201 * ccl.c (Fccl_execute_on_string): Declare some variables
1202 EMACS_INT.
1203
8546720e 12042011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
1205
1206 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
1207
4e19a977
CS
12082011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
1209
1210 * process.c (Fformat_network_address): Doc fix.
1211
87302331
R
12122011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
1213
1214 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
1215
cbb59342
CY
12162011-04-08 Chong Yidong <cyd@stupidchicken.com>
1217
1218 * keyboard.c (read_char): Call Lisp function help-form-show,
1219 instead of using internal_with_output_to_temp_buffer.
1220 (Qhelp_form_show): New var.
e0d38eeb 1221 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
1222
1223 * print.c (internal_with_output_to_temp_buffer): Function deleted.
1224
1225 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
1226
e67a13ab
CY
12272011-04-06 Chong Yidong <cyd@stupidchicken.com>
1228
1229 * process.c (Flist_processes): Removed to Lisp.
1230 (list_processes_1): Deleted.
1231
973f782d
EZ
12322011-04-06 Eli Zaretskii <eliz@gnu.org>
1233
7c106b1e
EZ
1234 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
1235
973f782d
EZ
1236 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
1237
41cf7d1a 12382011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 1239
ca23cc88
PE
1240 Fix more problems found by GCC 4.6.0's static checks.
1241
f390e2d5
PE
1242 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
1243
42eea0d0
PE
1244 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
1245
b69769da 1246 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 1247
f9541e84
PE
1248 * xdisp.c (vmessage): Mark as a printf-like function.
1249
13841b55
PE
1250 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
1251
c136c10f
PE
1252 * sound.c (sound_warning): Don't crash if arg contains a printf format.
1253
5e2d4a30
PE
1254 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
1255 printf-like functions.
1256 (tiff_load): Add casts to remove these marks before passing them
1257 to system-supplied API.
1258
583f48b9
PE
1259 * eval.c (Fsignal): Remove excess argument to 'fatal'.
1260
b25d760e
PE
1261 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
1262 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
1263 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
1264 directly, rather than having caller test rule sign. This avoids
1265 some unnecessary tests.
1266 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
1267 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
1268 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 1269
bc7b6697 1270 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 1271 (xfont_open): Avoid unnecessary tests.
bc7b6697 1272
27ccc379
PE
1273 * composite.c (composition_gstring_put_cache): Use unsigned integer.
1274
dcd5c89a
PE
1275 * composite.h, composite.c (composition_gstring_put_cache):
1276 Use EMACS_INT, not int, for length.
1277
b13a45c6
PE
1278 * composite.h (COMPOSITION_DECODE_REFS): New macro,
1279 breaking out part of COMPOSITION_DECODE_RULE.
1280 (COMPOSITION_DECODE_RULE): Use it.
1281 * composite.c (get_composition_id): Remove unused local vars,
1282 by using the new macro.
1283
1e792e4d
PE
1284 * textprop.c (set_text_properties_1): Change while to do-while,
1285 since the condition is always true at first.
1286
dc6c6455 1287 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
1288 (interval_deletion_adjustment): Return unsigned value.
1289 All uses changed.
dc6c6455 1290
aba7731a
PE
1291 * process.c (list_processes_1, create_pty, read_process_output):
1292 (exec_sentinel): Remove vars that were set but not used.
afd4052b 1293 (create_pty): Remove unnecessary "volatile"s.
bc57d757 1294 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 1295 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 1296 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 1297
fdfc4bf3
PE
1298 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
1299
fca8fe46 1300 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 1301 (update_syntax_table): Use unsigned instead of int.
fca8fe46 1302
06a0259a 1303 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 1304 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 1305 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 1306
e7b9e80f
PE
1307 * print.c (print_error_message): Avoid int overflow.
1308
56201685
PE
1309 * font.c (font_list_entities): Redo for clarity,
1310 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
1311
78834453 1312 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 1313 (font_score): Avoid potential overflow in diff calculation.
78834453 1314
0bc0b309 1315 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 1316 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 1317
e610eaca
PE
1318 * eval.c (funcall_lambda): Rename local to avoid shadowing.
1319
b895abce
PE
1320 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
1321 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
1322 can always succeed if overflow has undefined behavior.
1323
1f1d9321 1324 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 1325 (wordify): Omit three unnecessary tests.
1f1d9321 1326
c59478bc
PE
1327 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
1328 All callers changed. This avoids the need for an unused var.
1329
79b73827
PE
1330 * casefiddle.c (casify_region): Remove var that is set but not used.
1331
a4db5dfe
PE
1332 * dired.c (file_name_completion): Remove var that is set but not used.
1333
43aae36e
PE
1334 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
1335
2a47c44d 1336 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 1337 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 1338
a37c69bf
PE
1339 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
1340 Check for integer overflow on size calculations.
1341
328ab8e7
PE
1342 * buffer.c (Fprevious_overlay_change): Remove var that is set
1343 but not used.
1344
e5a2a5cb
PE
1345 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
1346 Remove vars that are set but not used.
8d84a6eb 1347 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 1348 (timer_check_2): Mark vars as initialized.
e5a2a5cb 1349
a60e5f68
PE
1350 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
1351
f661cb61 1352 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 1353 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 1354
f0397f5a
PE
1355 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
1356 that are set but not used.
1357
8664db06 1358 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 1359 if XCreateBitmapFromData fails (Bug#8410).
8664db06 1360
6abdaa4a
PE
1361 * xselect.c (x_get_local_selection, x_handle_property_notify):
1362 Remove vars that are set but not used.
1363
0ce7538d 1364 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 1365 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 1366
9ae848fc
PE
1367 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
1368 Remove var that is set but not used.
0b918413
PE
1369 (scroll_bar_windows_size): Now size_t, not int.
1370 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
1371 Check for overflow.
9ae848fc 1372
a5a62657
PE
1373 * xfaces.c (realize_named_face): Remove vars that are set but not used.
1374 (map_tty_color) [!defined MSDOS]: Likewise.
1375
5c5cdd39
PE
1376 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
1377
66ebf983
PE
1378 * coding.c: Remove vars that are set but not used.
1379 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
1380 All callers changed.
1381 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
1382 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
1383 (decode_coding_charset): Remove vars that are set but not used.
1384
1be4d761
PE
1385 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
1386 that is set but not used.
1387
47553fa8
PE
1388 * print.c (print_object): Remove var that is set but not used.
1389
1f7196bf 1390 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
1391 The gnulib version avoids calling malloc in the usual case,
1392 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
1393 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
1394 * filelock.c (current_lock_owner): Likewise.
1395 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
1396 * sysdep.c: Include allocator.h, careadlinkat.h.
1397 (emacs_no_realloc_allocator): New static constant.
1398 (emacs_readlink): New function.
fdb61804
PE
1399 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
1400 ../lib/careadlinkat.h.
d1fdcab7 1401
f84c17c7
SM
14022011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
1403
1404 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
1405 first non-nil return value).
1406
ef3862ad
JD
14072011-04-03 Jan Djärv <jan.h.d@swipnet.se>
1408
1409 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
1410 if not defined (Bug#8403).
1411
376a7006
JB
14122011-04-02 Juanma Barranquero <lekktu@gmail.com>
1413
1414 * xdisp.c (display_count_lines): Remove parameter `start',
1415 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1416 (get_char_face_and_encoding): Remove parameter `multibyte_p',
1417 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1418 (fill_stretch_glyph_string): Remove parameters `row' and `area',
1419 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
1420 and thereabouts. All callers changed.
1421 (get_per_char_metric): Remove parameter `f', unused since
1422 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
1423
6ca3801d
JM
14242011-04-02 Jim Meyering <meyering@redhat.com>
1425
1426 do not dereference NULL upon failed strdup
1427 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
1428 (ns_get_family): Likewise.
1429
d8e2b5ba
JB
14302011-04-02 Juanma Barranquero <lekktu@gmail.com>
1431
1432 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
1433
8c74fcbd
JD
14342011-04-02 Jan Djärv <jan.h.d@swipnet.se>
1435
1436 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
1437 later (Bug#8403).
1438
7200d79c
SM
14392011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
1440
03408648 1441 Add lexical binding.
7200d79c 1442
03408648
SM
1443 * window.c (Ftemp_output_buffer_show): New fun.
1444 (Fsave_window_excursion):
1445 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
1446
1447 * lread.c (lisp_file_lexically_bound_p): New function.
1448 (Fload): Bind Qlexical_binding.
1449 (readevalloop): Remove `evalfun' arg.
1450 Bind Qinternal_interpreter_environment.
1451 (Feval_buffer): Bind Qlexical_binding.
1452 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
1453 Mark as dynamic.
1454 (syms_of_lread): Declare `lexical-binding'.
1455
1456 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
1457
1458 * keyboard.c (eval_dyn): New fun.
1459 (menu_item_eval_property): Use it.
ca105506
SM
1460
1461 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1462
03408648
SM
1463 * fns.c (concat, mapcar1): Accept byte-code-functions.
1464
1465 * eval.c (Fsetq): Handle lexical vars.
1466 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1467 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1468 (FletX, Flet): Obey lexical binding.
1469 (Fcommandp): Handle closures.
1470 (Feval): New `lexical' arg.
1471 (eval_sub): New function extracted from Feval. Use it almost
1472 everywhere where Feval was used. Look up vars in lexical env.
1473 Handle closures.
1474 (Ffunctionp): Move from subr.el.
1475 (Ffuncall): Handle closures.
1476 (apply_lambda): Remove `eval_flags'.
1477 (funcall_lambda): Handle closures and new byte-code-functions.
1478 (Fspecial_variable_p): New function.
1479 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1480 but without exporting it to Lisp.
23aba0ea 1481
23aba0ea 1482 * doc.c (Fdocumentation, store_function_docstring):
03408648 1483 * data.c (Finteractive_form): Handle closures.
23aba0ea 1484
03408648
SM
1485 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1486 interactive spec.
ba83908c 1487
03408648
SM
1488 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1489 byte-codes.
1490 (exec_byte_code): New function extracted from Fbyte_code to handle new
1491 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1492
03408648 1493 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1494
03408648 1495 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1496
e2abce01
JB
14972011-03-31 Juanma Barranquero <lekktu@gmail.com>
1498
1499 * xdisp.c (redisplay_internal): Fix prototype.
1500
63696a73 15012011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1502
63696a73
EZ
1503 * xdisp.c (SCROLL_LIMIT): New macro.
1504 (try_scrolling): Use it when setting scroll_limit. Limit
1505 scrolling to 100 screen lines.
1506 (redisplay_window): Even when falling back on "recentering",
1507 position point in the window according to scroll-conservatively,
1508 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1509
1510 (try_scrolling): When point is above the window, allow searching
1511 as far as scroll_max, or one screenful, to compute vertical
1512 distance from PT to the scroll margin position. This prevents
1513 try_scrolling from unnecessarily failing when
1514 scroll-conservatively is set to a value slightly larger than the
1515 window height. Clean up the case of PT below the margin at bottom
1516 of window: scroll_max can no longer be INT_MAX. When aggressive
1517 scrolling is in use, don't let point enter the opposite scroll
1518 margin as result of the scroll.
1519 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1520 threshold of 100 lines for never-recentering scrolling.
1521
e4cc2dfc
JB
15222011-03-31 Juanma Barranquero <lekktu@gmail.com>
1523
1524 * dispextern.h (move_it_by_lines):
1525 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1526 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1527 (message_log_check_duplicate): Remove parameters `prev_bol' and
1528 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1529 (redisplay_internal): Remove parameter `preserve_echo_area',
1530 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1531
1532 * indent.c (Fvertical_motion):
1533 * window.c (window_scroll_pixel_based, Frecenter):
1534 Don't pass `need_y_p' to `move_it_by_lines'.
1535
1c470562
SM
15362011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1537
44f230aa
SM
1538 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1539 steal a few bits to be more compact.
1540 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1541 Remove unneeded casts.
1542
1c470562
SM
1543 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1544
888adce9
ZK
15452011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1546
1547 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1548 binding" message (bug#7967).
1549
f838ed7b
PE
15502011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1551
77861b95
PE
1552 Fix more problems found by GCC 4.6.0's static checks.
1553
de6dbc14
PE
1554 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1555 Remove unused local var.
1556
f838ed7b
PE
1557 * editfns.c (Fmessage_box): Remove unused local var.
1558
792c7b2b
PE
1559 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1560 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1561 Omit unused local vars.
c499e557 1562 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1563 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1564 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1565 Omit unused local var.
1566
ba0165e1
PE
1567 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1568 Don't assume string length fits in int.
32ad8845 1569 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1570 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1571
3c59b4c9
PE
1572 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1573 instead of alloca (Bug#8344).
1574
a3eed478 1575 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1576 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1577
eb4d412d
PE
1578 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1579
1658b401
PE
1580 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1581 concerns.
1582
1583 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1584
1585 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1586
9a2c6e05
PE
1587 * keyboard.c (syms_of_keyboard): Use the same style as later
1588 in this function when indexing through an array. This also
1589 works around GCC bug 48267.
1590
03d0a109
PE
1591 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1592
44f730c8
PE
1593 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1594
fe75f926
PE
1595 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1596 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1597
ffa8c828
PE
1598 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1599 This avoids undefined behavior on integer overflow, and is a bit
1600 more convenient anyway since it is compared to a size_t variable.
1601
c5101a77
PE
1602 Variadic C functions now count arguments with size_t, not int.
1603 This avoids an unnecessary limitation on 64-bit machines, which
1604 caused (substring ...) to crash on large vectors (Bug#8344).
1605 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1606 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1607 All variadic functions and their callers changed accordingly.
c5101a77
PE
1608 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1609 * data.c (arith_driver, float_arith_driver): Likewise.
1610 * editfns.c (general_insert_function): Likewise.
1611 * eval.c (struct backtrace.nargs, interactive_p)
1612 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1613 (funcall_lambda, mark_backtrace): Likewise.
1614 * fns.c (concat): Likewise.
1615 * frame.c (x_set_frame_parameters): Likewise.
1616 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1617 0 if not found, not -1. All callers changed.
1618
dd3f25f7
PE
1619 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1620 (stack_copy_size): Now size_t, not int.
1621 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1622
461c2ab9
JB
16232011-03-28 Juanma Barranquero <lekktu@gmail.com>
1624
1625 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1626 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1627 All callers changed.
1628
1629 * lisp.h (multibyte_char_to_unibyte):
1630 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1631 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1632 * character.h (CHAR_TO_BYTE8):
1633 * cmds.c (internal_self_insert):
1634 * editfns.c (general_insert_function):
1635 * keymap.c (push_key_description):
1636 * search.c (Freplace_match):
1637 * xdisp.c (message_dolog, set_message_1): All callers changed.
1638
f6d62986
SM
16392011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1640
1641 * keyboard.c (safe_run_hook_funcall): New function.
1642 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1643 don't set the hook to nil, but remove the offending function instead.
1644 (Qcommand_hook_internal): Remove, unused.
1645 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1646 Vcommand_hook_internal.
1647
1648 * eval.c (enum run_hooks_condition): Remove.
1649 (funcall_nil, funcall_not): New functions.
1650 (run_hook_with_args): Call each function through a `funcall' argument.
1651 Remove `cond' argument, now redundant.
1652 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1653 (Frun_hook_with_args_until_failure): Adjust accordingly.
1654 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1655
1db5b1ad
JB
16562011-03-28 Juanma Barranquero <lekktu@gmail.com>
1657
1658 * dispextern.h (string_buffer_position): Remove declaration.
1659
1660 * print.c (strout): Remove parameter `multibyte', unused since
1661 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1662
1663 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1664 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1665 All callers changed.
1666
1667 * w32.c (_wsa_errlist): Use braces for struct initializers.
1668
1669 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1670 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1671 All callers changed.
1672 (string_buffer_position): Likewise. Also, make static (it's never
1673 used outside xdisp.c).
1674 (cursor_row_p): Remove parameter `w', unused since
1675 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1676 (decode_mode_spec): Remove parameter `precision', introduced during
1677 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1678 All callers changed.
1679
5ffb62aa
JD
16802011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1681
1682 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1683
461c2ab9 16842011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1685
1686 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1687 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1688 (ns_update_auto_hide_menu_bar): New functions.
1689 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1690 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1691 ns_constrain_all_frames.
1692 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1693 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1694
5c380ffb
JD
16952011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1696
1697 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1698
9af30bdf
GM
16992011-03-27 Glenn Morris <rgm@gnu.org>
1700
1701 * syssignal.h: Replace RETSIGTYPE with void.
1702 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1703 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1704 Replace SIGTYPE with void everywhere.
1705 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1706 * s/template.h (SIGTYPE): Remove commented out definition.
1707
e2abce01
JB
17082011-03-26 Eli Zaretskii <eliz@gnu.org>
1709
1710 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1711 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1712
f868cd8a
JB
17132011-03-26 Juanma Barranquero <lekktu@gmail.com>
1714
59eb0929
JB
1715 * w32.c (read_unc_volume): Use parameter `henum', instead of
1716 global variable `wget_enum_handle'.
1717
1718 * keymap.c (describe_vector): Remove parameters `indices' and
1719 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1720 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1721
f868cd8a
JB
1722 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1723
1724 * keyboard.c (timer_check): Remove parameter `do_it_now',
1725 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1726 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1727 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1728
1729 * keyboard.c (read_char):
1730 * w32menu.c (w32_menu_display_help):
1731 * xmenu.c (show_help_event, menu_help_callback):
1732 Adjust calls to `show_help_echo'.
1733
1734 * gtkutil.c (xg_maybe_add_timer):
1735 * keyboard.c (readable_events):
1736 * process.c (wait_reading_process_output):
1737 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1738
1739 * insdel.c (adjust_markers_gap_motion):
1740 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1741 (gap_left, gap_right): Don't call it.
1742
2ecf6fdb
CY
17432011-03-25 Chong Yidong <cyd@stupidchicken.com>
1744
1745 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1746 incurred during fontification.
1747
6b1f9ba4
JB
17482011-03-25 Juanma Barranquero <lekktu@gmail.com>
1749
1750 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1751 (DEFVAR_PER_BUFFER): Don't pass it.
1752
1753 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1754 (scrolling_window): Don't pass it.
1755
0f4a96b5
JB
17562011-03-25 Juanma Barranquero <lekktu@gmail.com>
1757
1758 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1759
1760 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1761 and `suffix'.
1762 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1763 of variables specific to SELinux and computation of `encoded_absname'.
1764
1765 * image.c (XPutPixel): Remove unused variable `height'.
1766
1767 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1768
1769 * unexw32.c (get_section_info): Remove unused variable `section'.
1770
1771 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1772 (system_process_attributes): Remove unused variable `sess'.
1773 (sys_read): Remove unused variable `err'.
1774
1775 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1776 (w32_wnd_proc): Remove unused variable `isdead'.
1777 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1778 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1779 (x_create_tip_frame): Remove unused variable `tem'.
1780
1781 * w32inevt.c (w32_console_read_socket):
1782 Remove unused variable `no_events'.
1783
1784 * w32term.c (x_draw_composite_glyph_string_foreground):
1785 Remove unused variable `width'.
1786
1149507c
JB
17872011-03-24 Juanma Barranquero <lekktu@gmail.com>
1788
1789 * w32term.c (x_set_glyph_string_clipping):
1790 Don't pass uninitialized region to CombineRgn.
1791
9c88f339
JB
17922011-03-23 Juanma Barranquero <lekktu@gmail.com>
1793
1794 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1795 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1796 (Fx_close_connection): Remove unused variable `i'.
1797
1798 * w32font.c (w32font_draw): Return number of glyphs.
1799 (w32font_open_internal): Remove unused variable `i'.
1800 (w32font_driver): Add missing initializer.
1801
1802 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1803 (fill_in_menu): Remove unused variable `items_added'.
1804
1805 * w32term.c (last_mouse_press_frame): Remove static global variable.
1806 (w32_clip_to_row): Remove unused variable `f'.
1807 (x_delete_terminal): Remove unused variable `i'.
1808
1809 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1810 (NOTHING): Remove unused static global variable.
1811 (uniscribe_check_otf): Remove unused variable `table'.
1812 (uniscribe_font_driver): Add missing initializers.
1813
dee091a3
JD
18142011-03-23 Julien Danjou <julien@danjou.info>
1815
1816 * term.c (Fsuspend_tty, Fresume_tty):
1817 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1818 * window.c (temp_output_buffer_show):
1819 * insdel.c (signal_before_change):
1820 * frame.c (Fhandle_switch_frame):
1821 * fileio.c (Fdo_auto_save):
1822 * emacs.c (Fkill_emacs):
1823 * editfns.c (save_excursion_restore):
1824 * cmds.c (internal_self_insert):
1825 * callint.c (Fcall_interactively):
1826 * buffer.c (Fkill_all_local_variables):
1827 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1828 Use Frun_hooks.
0f4a96b5 1829 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1830 unconditionnaly since it does the check itself.
1831
2c520ab5 18322011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1833
c9c49752
PE
1834 Fix more problems found by GCC 4.5.2's static checks.
1835
8abc3f12
PE
1836 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1837 the first time through the loop, since we know p0 < p1 then.
1838 This also avoids a gcc -Wstrict-overflow warning.
1839
a2d26660
PE
1840 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1841 leading to a memory leak, possible in functions like
1842 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1843 of objects (Bug#8318).
a2d26660 1844
916c72e9
PE
1845 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1846 that could (at least in theory) be that large.
1847
19ab8a18
PE
1848 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1849 This is less likely to overflow, and avoids undefined behavior if
1850 overflow does occur. All callers changed. Use strtoul to scan
1851 for the unsigned long integer.
b7cbbd6f
PE
1852 (pint2hrstr): Simplify and tune code slightly.
1853 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1854
f0641eff
PE
1855 * scroll.c (do_scrolling): Work around GCC bug 48228.
1856 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1857
7f650bb9
PE
1858 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1859 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1860 (validate_x_resource_name): Simplify count usage.
1861 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1862
37dd57d1
PE
1863 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1864 fail (Bug#8306).
81e56e61 1865
699979fc 1866 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1867
401bf9b4
PE
1868 * process.c (Fmake_network_process): Use socklen_t, not int,
1869 where POSIX says socklen_t is required in portable programs.
1870 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1871 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1872 (Fmake_network_process, server_accept_connection):
1873 (wait_reading_process_output, read_process_output):
1874 Likewise.
1875
b93aacde
PE
1876 * process.c: Rename or move locals to avoid shadowing.
1877 (list_processes_1, Fmake_network_process):
1878 (read_process_output_error_handler, exec_sentinel_error_handler):
1879 Rename or move locals.
4dc343ee 1880 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1881 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1882 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1883 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1884 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1885
af8a867c 1886 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1887 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1888 Include tparam.h instead, since it declares them.
af8a867c
PE
1889 * cm.h (PC): Remove extern decl; tparam.h now does this.
1890 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1891 * terminfo.c: Include tparam.h, to check interfaces.
1892 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1893 (tparam): Adjust signature to match interface in tparam.h;
1894 this removes some undefined behavior. Check that outstring and len
1895 are zero, which they always are with Emacs.
1896 * tparam.h (PC, BC, UP): New extern decls.
1897
0248044d 1898 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1899 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1900
8ff096c1 1901 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1902 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1903 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1904 (ftfont_list): Remove unused local.
49eaafba
PE
1905 (get_adstyle_property, ftfont_pattern_entity):
1906 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1907 Rename locals to avoid shadowing.
8ff096c1 1908
e2be39f6
PE
1909 * xfont.c (xfont_list_family): Mark var as initialized.
1910
c9735e30
PE
1911 * xml.c (make_dom): Now static.
1912
8f5201ae
PE
1913 * composite.c (composition_compute_stop_pos): Rename local to
1914 avoid shadowing.
b246f932
PE
1915 (composition_reseat_it): Remove unused locals.
1916 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1917 (composition_update_it): Mark var as initialized.
11b61122
PE
1918 (find_automatic_composition): Mark vars as initialized,
1919 with a FIXME (Bug#8290).
8f5201ae 1920
760fbc2c
PE
1921 character.h: Rename locals to avoid shadowing.
1922 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1923 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1924 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1925 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1926 to avoid shadowing.
1927
ff08eb85
PE
1928 * textprop.c (property_change_between_p): Remove; unused.
1929
fc7bf025
PE
1930 * intervals.c (interval_start_pos): Now static.
1931
235d7abc
PE
1932 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1933
44f230aa
SM
1934 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1935 Rename locals to avoid shadowing.
3e7d6594 1936
50060332
PE
1937 * sound.c (wav_play, au_play, Fplay_sound_internal):
1938 Fix pointer signedness.
d01f234b 1939 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1940 (wav_play): Initialize a variable to 0, to prevent undefined
1941 behavior (Bug#8278).
50060332 1942
c4fc4e30
PE
1943 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1944
918436ed
PE
1945 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1946
c939f91b
PE
1947 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1948 clobbering (Bug#8298).
b9c7f648
PE
1949 * sysdep.c (sys_subshell): Likewise.
1950 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1951
6bd8c144
PE
1952 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1953 This should get cleaned up, so that child_setup has the
1954 same signature on all platforms.
1955
7710357c 1956 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1957 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1958
c59da222
CY
19592011-03-22 Chong Yidong <cyd@stupidchicken.com>
1960
1961 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1962 not to be necessary, and produces flickering.
1963
66b87493
GM
19642011-03-20 Glenn Morris <rgm@gnu.org>
1965
1966 * config.in: Remove file.
1967
45b6f6d5
JB
19682011-03-20 Juanma Barranquero <lekktu@gmail.com>
1969
1970 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1971 are now in src/globals.h.
1972 (syms_of_minibuf): Remove spurious & from previous change.
1973
3ec03f7e
LL
19742011-03-20 Leo <sdl.web@gmail.com>
1975
1976 * minibuf.c (completing-read-function): New variable.
1977 (completing-read-default): Rename from completing-read.
1978 (completing-read): Call completing-read-function.
1979
b14e3e21
CY
19802011-03-19 Juanma Barranquero <lekktu@gmail.com>
1981
1982 * xfaces.c (Fx_load_color_file):
1983 Read color file from absolute filename (bug#8250).
1984
f2b726e6
JB
19852011-03-19 Juanma Barranquero <lekktu@gmail.com>
1986
1987 * makefile.w32-in: Update dependencies.
1988
09f6ff02
EZ
19892011-03-17 Eli Zaretskii <eliz@gnu.org>
1990
1991 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1992
29a6015a
PE
19932011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1994
a3a6c54e
PE
1995 Fix more problems found by GCC 4.5.2's static checks.
1996
b766f867
PE
1997 * process.c (make_serial_process_unwind, send_process_trap):
1998 (sigchld_handler): Now static.
1999
be02381c
PE
2000 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
2001 That way, the code declares only the vars that it needs.
2002 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
2003 * s/cygwin.h (PTY_ITERATION): Likewise.
2004 * s/darwin.h (PTY_ITERATION): Likewise.
2005 * s/gnu-linux.h (PTY_ITERATION): Likewise.
2006
57048744
PE
2007 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
2008 * process.c (allocate_pty): Don't declare stb unless it's needed.
2009
7914961c 2010 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
2011 (CONSTANTLIM): Remove; unused.
2012 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
2013 Define only if needed.
7914961c 2014
b3967b18
PE
2015 * unexelf.c (unexec): Name an expression,
2016 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
2017 Use a different way to cause a compilation error if anyone uses
2018 n rather than nn, a way that does not involve shadowing.
73366a00 2019 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 2020
29a6015a
PE
2021 * deps.mk (unexalpha.o): Remove; unused.
2022
43cfc33e 2023 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 2024 * unexec.h: New file.
ce701a33
PE
2025 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
2026 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
2027 Depend on unexec.h.
2028 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
2029 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
2030 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 2031 Change as necessary to match prototype in unexec.h.
ce701a33 2032
01f44d5a
PE
2033 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
2034 shadowing.
4f63c6bb 2035 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 2036
a6670b0b
PE
2037 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
2038 Rename locals to avoid shadowing.
2039
cef2010d 2040 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 2041 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 2042
d4d7173a
PE
2043 * print.c (Fredirect_debugging_output): Fix pointer signedess.
2044
f08b802a
PE
2045 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
2046 warning when compiling print.c.
2047
3ddb0639
PE
2048 * font.c (font_unparse_fcname): Abort in an "impossible" situation
2049 instead of using an uninitialized var.
5ad03b97 2050 (font_sort_entities): Mark var as initialized.
3ddb0639 2051
170a2692
PE
2052 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
2053
e663c700
PE
2054 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
2055 pointers to constants.
89bc529a 2056 (font_parse_fcname): Remove unused vars.
7b81e2d0 2057 (font_delete_unmatched): Now static.
ea838e10 2058 (font_get_spec): Remove; unused.
13a547c6
PE
2059 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
2060 (font_update_drivers, Ffont_get_glyphs, font_add_log):
2061 Rename or move locals to avoid shadowing.
e663c700 2062
2a80c887 2063 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 2064 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 2065
1384fa33 2066 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 2067 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 2068
8b2c52e9
PE
2069 * alloc.c (mark_backtrace): Move decl from here ...
2070 * lisp.h: ... to here, so that it can be checked.
2071
475545b5 2072 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 2073 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
2074 (lisp_indirect_variable): Name an expression,
2075 to avoid gcc -Wbad-function-cast warning.
1faed8ae 2076 (Fdefvar): Rename locals to avoid shadowing.
475545b5 2077
b1349114 2078 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 2079 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 2080 Use const pointer when appropriate.
b1349114 2081
a2928364
PE
2082 * lisp.h (get_system_name, get_operating_system_release):
2083 Move decls here, to check interfaces.
2084 * process.c (get_operating_system_release): Move decl to lisp.h.
2085 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
2086 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
2087 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
2088 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
2089 (Fformat_time_string, Fencode_time, Finsert_char):
2090 (Ftranslate_region_internal, Fformat):
2091 Rename or remove local vars to avoid shadowing.
9710023e 2092 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 2093
a415e694
PE
2094 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
2095 avoid shadowing.
2096
8ef4622d
PE
2097 * lisp.h (eassert): Check that the argument compiles, even if
2098 ENABLE_CHECKING is not defined.
2099
946f9a5b
PE
2100 * data.c (Findirect_variable): Name an expression, to avoid
2101 gcc -Wbad-function-cast warning.
112396d6 2102 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 2103 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
2104 (Fmake_variable_buffer_local, Fmake_local_variable):
2105 Mark variables as initialized.
52746918 2106 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 2107
e5aab7e7 2108 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
2109 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
2110 Rename locals to avoid shadowing.
dff45157
PE
2111 (mark_stack): Move local variables into the #ifdef region where
2112 they're used.
7bc26fdb
PE
2113 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
2114 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
2115 needed otherwise.
2116 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
2117 (GC_STRING_CHARS): Remove; not used.
d40d4be1 2118 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 2119
e5aab7e7
PE
2120 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
2121 avoids undefined behavior in theory.
2122
4da60324
PE
2123 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
2124
88043301
PE
2125 Use functions, not macros, for up- and down-casing (Bug#8254).
2126 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2127 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
2128 to use the following functions instead of these macros.
2129 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
2130 EMACS_INT, since callers assume the returned value fits in int.
2131 (upcase1): Likewise, for UPCASE_TABLE.
2132 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 2133 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 2134 the race-condition problem in the old DOWNCASE.
88043301 2135
19ed5445
PE
2136 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
2137 Rename locals to avoid shadowing.
2138 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
2139 (regex_compile, re_search_2, re_match_2_internal):
2140 Remove unused local vars.
952db0d7
PE
2141 (FREE_VAR): Rewrite so as not to use empty "else",
2142 which gcc can warn about.
da053e48 2143 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
2144 (RETALLOC_IF): Define only if needed.
2145 (WORDCHAR_P): Likewise. This one is never needed, but is used
2146 only in a comment talking about a compiler bug, so put inside
2147 the #if 0 of that comment.
2148 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
2149 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
2150 Remove; unused.
19ed5445 2151
1f3561e4 2152 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
2153 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
2154 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 2155
ded6f8f7
PE
2156 * search.c (simple_search): Remove unused var.
2157
dbd37a95
PE
2158 * dired.c (compile_pattern): Move decl from here ...
2159 * lisp.h: ... to here, so that it can be checked.
2160 (struct re_registers): New forward decl.
2161
7e47afad
PE
2162 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
2163
85f24f61
PE
2164 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
2165 All uses changed.
2166 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
2167 Rename locals to avoid shadowing.
5671df8f 2168 (Fvertical_motion): Mark locals as initialized.
85f24f61 2169
181aa2be 2170 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 2171 (casify_region): Mark local as initialized.
181aa2be 2172
930d429c
PE
2173 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
2174
7082eac6
PE
2175 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
2176 New macros, so that the caller can use some names other than
2177 gcpro1, gcpro2, etc.
2178 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
2179 of the new macros.
2180 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
2181 argument, for consistency with GCPRO2_VAR, etc: it is now the
2182 prefix of the variable, not the variable itself. All uses
2183 changed.
38b2c076
PE
2184 * dired.c (directory_files_internal, file_name_completion):
2185 Rename locals to avoid shadowing.
2186
15206ed9
PE
2187 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
2188 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
2189 dired.c's scmp function, had undefined behavior.
2190 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
2191 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
2192 * buffer.h: ... to here, because these macros use current_buffer,
2193 and the new implementation with inline functions needs to have
2194 current_buffer in scope now, rather than later when the macros
2195 are used.
2196 (downcase, upcase1): New static inline functions.
2197 (DOWNCASE, UPCASE1): Reimplement using these functions.
2198 This avoids undefined behavior in expressions like
2199 DOWNCASE (x) == DOWNCASE (y), which previously suffered
2200 from race conditions in accessing the global variables
2201 case_temp1 and case_temp2.
2202 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
2203 * lisp.h (case_temp1, case_temp2): Remove their decls.
2204 * character.h (ASCII_CHAR_P): Move from here ...
2205 * lisp.h: ... to here, so that the inline functions mentioned
2206 above can use them.
2207
4a6bea26
PE
2208 * dired.c (directory_files_internal_unwind): Now static.
2209
f14b7e14
PE
2210 * fileio.c (file_name_as_directory, directory_file_name):
2211 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
2212 Now static.
2893f146
PE
2213 (file_name_as_directory): Use const pointers when appropriate.
2214 (Fexpand_file_name): Likewise. In particular, newdir might
2215 point at constant storage, so make it a const pointer.
fd4ead52 2216 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
2217 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
2218 signedness issues.
f839df0c
PE
2219 (Fset_file_times, Finsert_file_contents, auto_save_error):
2220 Rename locals to avoid shadowing.
f14b7e14 2221
5716756e 2222 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
2223 (Ftry_completion, Fall_completions): Rename or remove locals
2224 to avoid shadowing.
5716756e 2225
b4c3046a
PE
2226 * marker.c (bytepos_to_charpos): Remove; unused.
2227
b45db522
PE
2228 * lisp.h (verify_bytepos, count_markers): New decls,
2229 so that gcc does not warn that these functions aren't declared.
2230
85876d07
PE
2231 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
2232 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 2233 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 2234 (copy_text): Remove unused local var.
85876d07 2235
03d78a21 2236 * filelock.c (within_one_second): Now static.
b3dd38ab 2237 (lock_file_1): Rename local to avoid shadowing.
03d78a21 2238
5df8f01b
PE
2239 * buffer.c (fix_overlays_before): Mark locals as initialized.
2240 (fix_start_end_in_overlays): Likewise. This function should be
2241 simplified by using pointers-to-pointers, but that's a different
2242 matter.
b1d876f1 2243 (switch_to_buffer_1): Now static.
8f54f30a
PE
2244 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
2245 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 2246
a70072c9 2247 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 2248 Fix pointer signedness issue.
edced198
PE
2249 (sys_subshell): Mark local as volatile if checking for lint,
2250 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 2251 (MAXPATHLEN): Define only if needed.
a70072c9 2252
a0977c44
PE
2253 * process.c (serial_open, serial_configure): Move decls from here ...
2254 * systty.h: ... to here, so that they can be checked.
2255
a884fdcc
PE
2256 * fns.c (get_random, seed_random): Move extern decls from here ...
2257 * lisp.h: ... to here, so that they can be checked.
2258
604efe86 2259 * sysdep.c (reset_io): Now static.
b8950c94 2260 (wait_for_termination_signal): Remove; unused.
604efe86 2261
38fc62d9
PE
2262 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
2263 (copy_keymap_item, append_key, push_text_char_description):
2264 Now static.
1004a21a 2265 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 2266 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
2267 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
2268 (describe_map_tree):
2269 Rename locals to avoid shadowing.
38fc62d9 2270
2f2650da
PE
2271 * keyboard.c: Declare functions static if they are not used elsewhere.
2272 (echo_char, echo_dash, cmd_error, top_level_2):
2273 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
2274 (read_char, kbd_buffer_get_event, make_lispy_position):
2275 (make_lispy_event, make_lispy_movement, apply_modifiers):
2276 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
2277 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
2278 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 2279 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 2280 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 2281
a053e86c 2282 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
2283 (mark_kboards): Move decl here ...
2284 * alloc.c (mark_kboards): ... from here.
a053e86c 2285
4752793e
PE
2286 * lisp.h (force_auto_save_soon): New decl.
2287
74f10ca7 2288 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
2289 (DEFINE_DUMMY_FUNCTION): New macro.
2290 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
2291 Use it.
c03cd23f
PE
2292 (main): Add casts to avoid warnings
2293 if GCC considers string literals to be constants.
74f10ca7 2294
022e70d4
PE
2295 * lisp.h (fatal_error_signal): Add decl, since it's exported.
2296
59d6fe83
PE
2297 * dbusbind.c: Pointer signedness fixes.
2298 (xd_signature, xd_append_arg, xd_initialize):
2299 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2300 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2301 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
2302 (Fdbus_register_signal): Use SSDATA when the context wants char *.
2303
78320123
PE
2304 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
2305 if GCC considers string literals to be constants.
49cebcca 2306 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 2307
35ac2a97
SM
23082011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
2309
fb103ca9
SM
2310 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
2311 (print_preprocess, print_object): New macro to fix last change.
2312
35ac2a97
SM
2313 * print.c (print_preprocess): Don't forget font objects.
2314
62973b41
JB
23152011-03-16 Juanma Barranquero <lekktu@gmail.com>
2316
2317 * emacs.c (USAGE3): Doc fixes.
2318
0e48bb22
AS
23192011-03-15 Andreas Schwab <schwab@linux-m68k.org>
2320
2321 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
2322 structure.
2323
7684e57b
JB
23242011-03-14 Juanma Barranquero <lekktu@gmail.com>
2325
2326 * lisp.h (VWindow_system, Qfile_name_history):
2327 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
2328 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
2329 (w32_system_caret_x, w32_system_caret_y): Declare extern.
2330
2331 * w32select.c: Don't #include "keyboard.h".
c96bbc66 2332 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
2333
2334 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
2335 * w32console.c (detect_input_pending, read_input_pending)
2336 (encode_terminal_code):
2337 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
2338 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
2339 (w32_system_caret_y, Qfile_name_history):
2340 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
2341 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
2342 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
2343 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
2344 * w32proc.c (Qlocal, report_file_error):
2345 * w32term.c (Vwindow_system, updating_frame):
2346 * w32uniscribe.c (initialized, uniscribe_font_driver):
2347 Remove unneeded extern declarations.
2348
2aa46d6c
CY
23492011-03-14 Chong Yidong <cyd@stupidchicken.com>
2350
c96bbc66 2351 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 2352
cffc6f3b
CY
23532011-03-13 Chong Yidong <cyd@stupidchicken.com>
2354
2355 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
2356 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
2357 These macros can no longer be used for assignment.
2358
44f230aa
SM
2359 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
2360 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
2361 (record_buffer_markers, fetch_buffer_markers): New functions for
2362 recording and fetching special buffer markers.
2363 (set_buffer_internal_1, set_buffer_temp): Use them.
2364
2365 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
2366
2367 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
2368
2369 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
2370 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
2371
2372 * xdisp.c (hscroll_window_tree):
2373 (reconsider_clip_changes): Use PT instead of BUF_PT.
2374
d251f04b
EZ
23752011-03-13 Eli Zaretskii <eliz@gnu.org>
2376
2377 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
2378 $(EMACS_ROOT)/lib/intprops.h.
2379
f0c77cd1
PE
23802011-03-13 Paul Eggert <eggert@cs.ucla.edu>
2381
3eca4629
PE
2382 Fix more problems found by GCC 4.5.2's static checks.
2383
7c86ee98
PE
2384 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
2385 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
2386 (xg_free_frame_widgets): Make it clear that a local variable is
2387 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
2388 (gdk_window_get_screen): Make it clear that this macro is needed
2389 only if USE_GTK_TOOLTIP.
1e5524e7
PE
2390 (int_gtk_range_get_value): New function, which avoids a diagnostic
2391 from gcc -Wbad-function-cast.
2392 (xg_set_toolkit_scroll_bar_thumb): Use it.
2393 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
2394 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
2395 (get_utf8_string, xg_get_file_with_chooser):
2396 Rename locals to avoid shadowing.
2397 (create_dialog): Move locals to avoid shadowing.
7c86ee98 2398
41729b81
PE
2399 * xgselect.c (xg_select): Remove unused var.
2400
f0c77cd1
PE
2401 * image.c (four_corners_best): Mark locals as initialized.
2402 (gif_load): Initialize transparent_p to zero (Bug#8238).
2403 Mark another local as initialized.
ec6cf4c6 2404 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 2405
ce0ad53d 2406 * image.c (clear_image_cache): Now static.
d5d5a617 2407 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 2408 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
2409 (x_edge_detection): Remove unnecessary cast that
2410 gcc -Wbad-function-cast diagnoses.
2037898d 2411 (gif_load): Fix pointer signedness.
6ae141d6
PE
2412 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
2413 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 2414
33383987 24152011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 2416
d32df629
PE
2417 Improve quality of tests for time stamp overflow.
2418 For example, without this patch (encode-time 0 0 0 1 1
2419 1152921504606846976) returns the obviously-bogus value (-948597
2420 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
2421 reports time overflow. See
2422 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
2423 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
2424 * editfns.c: Include limits.h and intprops.h.
2425 (TIME_T_MIN, TIME_T_MAX): New macros.
2426 (time_overflow): Move earlier, to before first use.
2427 (hi_time, lo_time): New functions, for an accurate test for
2428 out-of-range times.
2429 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
2430 (Fget_internal_run_time): Don't assume time_t fits in int.
2431 (make_time): Use list2 instead of Fcons twice.
2432 (Fdecode_time): More accurate test for out-of-range times.
2433 (check_tm_member): New function.
2434 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
2435 (lisp_time_argument): Don't rely on undefined left-shift and
2436 right-shift behavior when checking for time stamp overflow.
8be6f318 2437
fe31d94c
PE
2438 * editfns.c (time_overflow): New function, refactoring common code.
2439 (Fformat_time_string, Fdecode_time, Fencode_time):
2440 (Fcurrent_time_string): Use it.
2441
8be6f318
PE
2442 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
2443 * dired.c (make_time): Move to ...
2444 * editfns.c (make_time): ... here.
2445 * systime.h: Note the move.
2446
09d9db2c 24472011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 2448
126bc0dc
YM
2449 * fringe.c (update_window_fringes): Remove unused variables.
2450
c47cbdfd
YM
2451 * unexmacosx.c (copy_data_segment): Also copy __got section.
2452 (Bug#8223)
2453
7ac80be9
EZ
24542011-03-12 Eli Zaretskii <eliz@gnu.org>
2455
c96bbc66 2456 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
2457 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
2458 Constify `char *' arguments and their references according to
2459 prototypes in tparam.h.
2460
ecb0f94d 2461 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2462
7ac80be9
EZ
2463 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2464 Adapt all references accordingly.
2465
2466 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2467
ef1fd07e
TT
24682011-03-11 Tom Tromey <tromey@redhat.com>
2469
2470 * buffer.c (syms_of_buffer): Remove obsolete comment.
2471
7ef4b50c
EZ
24722011-03-11 Eli Zaretskii <eliz@gnu.org>
2473
2474 * termhooks.h (encode_terminal_code): Declare prototype.
2475
2476 * msdos.c (encode_terminal_code): Don't declare prototype.
2477
2478 * term.c (encode_terminal_code): Now external again, used by
2479 w32console.c and msdos.c.
2480
44f230aa
SM
2481 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2482 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2483
4b1ec863 24842011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2485
1714f52b 2486 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2487
4b1ec863
PE
2488 * fringe.c (update_window_fringes): Mark locals as initialized
2489 (Bug#8227).
2490 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2491
524c7aa6
PE
2492 * alloc.c (mark_fringe_data): Move decl from here ...
2493 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2494 to check its interface.
2495 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2496
a5c0af81 2497 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2498 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2499 (fontset_font): Mark local as initialized.
a9a06e0b 2500 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2501
b4716021
PE
2502 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2503
811e9bac 2504 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2505 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2506 (x_own_selection, Fx_disown_selection_internal): Rename locals
2507 to avoid shadowing.
2508 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2509
7e3ab302
PE
2510 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2511 so that the caller can use some name other than gcpro1.
2512 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2513 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2514 (Fx_backspace_delete_keys_p):
2515 Use them to avoid shadowing, and rename vars to avoid shadowing.
2516 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2517 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2518 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2519 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2520 Remove unused locals.
7e3ab302
PE
2521 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2522 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2523 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2524 macros.
f78faa98 2525
e2b13473
PE
2526 * xterm.h (x_mouse_leave): New decl.
2527
77f23912
PE
2528 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2529 Remove unused functions.
cdf4ba58
PE
2530 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2531 (x_calc_absolute_position): Now static.
7411c686 2532 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2533 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2534 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2535 unless they are used.
38d0b34a
PE
2536 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2537 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2538 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2539 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2540 (x_error_catcher, x_connection_closed, x_error_handler):
2541 (x_error_quitter, xembed_send_message, x_iconify_frame):
2542 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2543 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2544 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2545
44f230aa
SM
2546 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2547 Rename or move locals to avoid shadowing.
6b463e58 2548 (tty_defined_color, merge_face_heights): Now static.
5967d051 2549 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2550 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2551 does not deduce is never used uninitialized.
73719eba
PE
2552 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2553 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2554
426994c3 2555 * terminal.c (store_terminal_param): Now static.
5489860b 2556
032f1620 2557 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2558 (set_frame_menubar): Remove unused local.
d4323972 2559 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2560 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2561 since they might point to immutable storage.
281585b0
PE
2562 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2563 since it's unused otherwise.
032f1620 2564
367c19e5 2565 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2566 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2567 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2568 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2569 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2570 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2571 does not deduce are never used uninitialized.
70739cbe 2572
07b48fa9
PE
2573 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2574
8868a238 2575 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2576 * window.c (window_loop, size_window):
2577 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2578
7e5cf297 2579 * window.c (display_buffer): Now static.
d6550a9f
PE
2580 (size_window): Mark variables that gcc -Wuninitialized
2581 does not deduce are never used uninitialized.
a586633d
PE
2582 * window.h (check_all_windows): New decl, to forestall
2583 gcc -Wmissing-prototypes diagnostic.
5b555da1 2584 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2585
f6095868
PE
2586 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2587 shadowing.
2588 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2589 Include <limits.h>.
2590 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2591 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2592 (load_charset_map): Mark variables that gcc -Wuninitialized
2593 does not deduce are never used uninitialized.
53df7c11 2594 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2595
f38b440c
PE
2596 * coding.c (coding_set_source, coding_set_destination):
2597 Use "else { /* comment */ }" rather than "else /* comment */;"
2598 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2599 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2600 a block, when the outer 'i' will do.
2601 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2602 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2603 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2604 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2605 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2606 Rename locals to avoid shadowing.
2607 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2608 * coding.c (emacs_mule_char, encode_invocation_designation):
2609 Now static, since they're not used elsewhere.
413bb2db 2610 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2611 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2612 (decode_coding_emacs_mule): Mark variables that gcc
2613 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2614 (detect_coding_iso_2022): Initialize a local variable that might
2615 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2616 this initialization is needed. (Bug#8211)
5f58e762
PE
2617 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2618 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2619 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2620 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2621 Remove unused macros.
f38b440c 2622
232b38b9 2623 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2624 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2625 * character.c (string_count_byte8): Likewise.
232b38b9 2626
fb90da1b
PE
2627 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2628 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2629
fb93dbc2
PE
2630 * chartab.c (copy_sub_char_table): Now static, since it's not used
2631 elsewhere.
5c156ace
PE
2632 (sub_char_table_ref_and_range, char_table_ref_and_range):
2633 Rename locals to avoid shadowing.
bbcd0949 2634 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2635
7d3b3862 2636 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2637 (BIDI_BOB): Remove unused macro.
7d3b3862 2638
6be7d3da
PE
2639 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2640 deduce are never used uninitialized.
c2ed9c8b 2641 * term.c (encode_terminal_code): Likewise.
6be7d3da 2642
75f8807f 2643 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2644
50938595
PE
2645 * tparam.h: New file.
2646 * term.c, tparam.h: Include it.
2647 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2648 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2649 Move these decls to tparam.h, and make them agree with what
2650 is actually in tparam.c. The previous trick of using incompatible
2651 decls in different modules does not conform to the C standard.
2652 All callers of tparam changed to use tparam's actual API.
2653 * tparam.c (tparam1, tparam, tgoto):
2654 Use const pointers where appropriate.
2655
fbceeba2
PE
2656 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2657 * cm.h (struct cm): Likewise.
2658 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2659 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2660 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2661 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2662 (turn_on_face, init_tty): Likewise.
2663 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2664
7f3f1250
PE
2665 * term.c (term_mouse_position): Rename local to avoid shadowing.
2666
e6ca6543
PE
2667 * alloc.c (mark_ttys): Move decl from here ...
2668 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2669
c40f8d15
AS
26702011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2671
2672 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2673
cfe0661d
JB
26742011-03-09 Juanma Barranquero <lekktu@gmail.com>
2675
2676 * search.c (compile_pattern_1): Remove argument regp, unused since
2677 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2678 (compile_pattern): Don't pass it.
2679
0afb4571
J
26802011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2681
2682 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2683 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2684 for ! HAVE_GTK3.
2685 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2686
2687 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2688
2689 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2690 gdk_window_get_screen, gdk_window_get_geometry,
2691 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2692 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2693 (xg_get_pixbuf_from_pixmap): New function.
2694 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2695 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2696 Call xg_get_pixbuf_from_pixmap instead of
2697 gdk_pixbuf_get_from_drawable.
2698 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2699 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2700 (xg_check_special_colors): Use GtkStyleContext and its functions
2701 for HAVE_GTK3.
2702 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2703 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2704 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2705 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2706 Call gtk_widget_get_preferred_size.
0afb4571
J
2707 (xg_frame_resized): gdk_window_get_geometry only takes 5
2708 parameters.
44f230aa
SM
2709 (xg_win_to_widget, xg_event_is_for_menubar):
2710 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2711 (xg_set_widget_bg): New function.
2712 (delete_cb): New function.
2713 (xg_create_frame_widgets): connect delete-event to delete_cb.
2714 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2715 (xg_set_background_color): Call xg_set_widget_bg.
2716 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2717 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2718 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2719 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2720 if ! HAVE_GTK3.
2721 (update_frame_tool_bar): Call gtk_widget_hide.
2722 (xg_initialize): Use GDK_KEY_g.
2723
2724 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2725 if ! HAVE_GTK3
2726 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2727
2728 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2729 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2730 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2731
1c2cc4ef
JB
27322011-03-08 Juanma Barranquero <lekktu@gmail.com>
2733
2734 * w32xfns.c (select_palette): Check success of RealizePalette against
2735 GDI_ERROR, not zero.
2736
33383987 2737See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2738
2739;; Local Variables:
2740;; coding: utf-8
aac0c6e3
MR
2741;; End:
2742
33383987 2743 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2744
2745 This file is part of GNU Emacs.
2746
2747 GNU Emacs is free software: you can redistribute it and/or modify
2748 it under the terms of the GNU General Public License as published by
2749 the Free Software Foundation, either version 3 of the License, or
2750 (at your option) any later version.
2751
2752 GNU Emacs is distributed in the hope that it will be useful,
2753 but WITHOUT ANY WARRANTY; without even the implied warranty of
2754 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2755 GNU General Public License for more details.
2756
2757 You should have received a copy of the GNU General Public License
2758 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.