* subr.el (internal--after-with-selected-window): Fix typo.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5884c324
PE
12012-08-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 * gtkutil.c (xg_mark_data): Don't assume C99.
4
ca06f160
JD
52012-08-13 Jan Djärv <jan.h.d@swipnet.se>
6
7 * gtkutil.c (xg_frame_tb_info): New struct.
8 (TB_INFO_KEY): New define.
9 (xg_free_frame_widgets): Free xg_frame_tb_info for frame if present.
10 (xg_mark_data): Mark Lisp_Objects in xg_frame_tb_info.
11 (xg_create_tool_bar): Allocate and initialize a xg_frame_tb_info
12 if not present.
13 (update_frame_tool_bar): Return early if data in xg_frame_tb_info
14 is up to date. Otherwise store new data.
15 (free_frame_tool_bar): Free xg_frame_tb_info if present.
16
7864a3f7
DA
172012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
18
19 Use KSET for write access to Lisp_Object members of struct kboard.
20 * keyboard.h (KSET): New macro.
21 * callint.c, category.c, frame.c, keyboard.c, keyboard.h, macros.c:
22 * msdos.c, nsfns.m, nsterm.m, term.c, w32fns.c, w32term.c, xfns.c:
23 * xterm.c: Adjust users.
24
4c31be61
DA
252012-08-13 Dmitry Antipov <dmantipov@yandex.ru>
26
27 Use BSET for write access to Lisp_Object members of struct buffer.
28 * buffer.h (BSET): New macro.
29 * buffer.c, casetab.c, cmds.c, coding.c, data.c, editfns.c:
30 * fileio.c, frame.c, indent.c, insdel.c, intervals.c, keymap.c:
31 * minibuf.c, print.c, process.c, syntax.c, undo.c, w32fns.c:
32 * window.c, xdisp.c, xfns.c: Adjust users.
33
14ae4239
BT
342012-08-11 BT Templeton <bpt@hcoop.net> (tiny change)
35
36 * lread.c (syms_of_lread): Initialize Vlexical_binding.
37
32bcadb4
JD
382012-08-11 Jan Djärv <jan.h.d@swipnet.se>
39
3d29b2ce
JD
40 * nsterm.m (not_in_argv): New function.
41 (application:openFile, application:openTempFile:):
42 (application:openFileWithoutUI:, application:openFiles:): Open file
43 if not_in_argv returns non-zero (bug#12171).
44
32bcadb4 45 * gtkutil.c (gtk_font_chooser_dialog_new, GTK_FONT_CHOOSER)
14ae4239
BT
46 (gtk_font_chooser_set_font, gtk_font_chooser_get_font):
47 Define for Gtk+ versions less than 3.2.
32bcadb4
JD
48 (xg_get_font_name): Use those functions/macros here.
49 Reported by Frans Oilinki <moilinki@gmail.com>.
50
9ff9402d 512012-08-11 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8ccd072a
YM
52
53 * unexmacosx.c (copy_data_segment): Copy initialized data in
54 statically linked libraries from input file rather than memory.
55
db74a5fc
YM
56 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
57 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
58 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
59
25e65510
GM
602012-08-10 Glenn Morris <rgm@gnu.org>
61
62 * conf_post.h (IF_LINT, lint_assume): Move here from lisp.h.
63 * lisp.h (IF_LINT, lint_assume): Move to conf_post.h.
64
7961135c
DA
652012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Fix last change to allow compilation with low optimization levels.
68 * intervals.c (INTERVALS_INLINE): Define to EXTERN_INLINE.
69 Reported by Jan Djärv <jan.h.d@swipnet.se>.
70
42b3a444
DA
712012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
72
73 Use common inline syntax in intervals.h.
74 * intervals.h (INTERVALS_INLINE): New macro.
75 Change all users from LISP_INLINE.
76
9fb0c957
DA
772012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
78
79 Define Qnone once for all platforms.
80 * frame.c (Qnone): Define here.
81 (syms_of_frame): DEFSYM it.
82 * lisp.h (Qnone): New declaration.
83 * nsfns.m, nsterm.h, nsterm.m, w32fns.c, w32font.c:
84 * xfns.c: Remove duplication. Adjust users.
85
65e8ee52
DA
862012-08-10 Dmitry Antipov <dmantipov@yandex.ru>
87
88 Remove unused macros from intervals.h.
89 * intervals.h (MERGE_INSERTIONS, DISPLAY_INVISIBLE_GLYPH): Remove.
90 * intervals.c: Adjust comment.
91
9b855fd6
EZ
922012-08-10 Eli Zaretskii <eliz@gnu.org>
93
94 * w32fns.c <w32_unicode_gui>: New static variable.
95 (globals_of_w32fns): Initialize it according to os_subtype.
96 (w32_init_class, w32_msg_pump, w32_wnd_proc): Use it instead of
97 testing os_subtype.
98
39cb9e56 992012-08-10 Joakim Hårsman <joakim.harsman@gmail.com> (tiny change)
d30be705
EZ
100 Eli Zaretskii <eliz@gnu.org>
101
102 Fix bug #10299 with Unicode characters sent by customized
103 keyboards created by MSKLC.
104 * w32fns.c (INIT_WINDOW_CLASS): New macro.
105 (w32_init_class): Use it to initialize the Emacs class with either
106 ANSI or Unicode API calls.
107 (w32_msg_pump): Call GetMessageW and DispatchMessageW on NT and
108 later.
109 (w32_wnd_proc): If the character code sent by WM_CHAR or
110 WM_SYSCHAR is above 255, post a WM_UNICHAR message, not the
111 original message. Call DefWindowProcW on NT and later.
112
9374581a
GM
1132012-08-10 Glenn Morris <rgm@gnu.org>
114
4b94e8cf
GM
115 * Makefile.in (config_h): Fix conf_post.h out-of-tree build location.
116
9374581a
GM
117 * lisp.h (DIRECTORY_SEP): Let configure set it.
118
a2752828
DA
1192012-08-09 Dmitry Antipov <dmantipov@yandex.ru>
120
121 Use TSET for write access to Lisp_Object slots of struct terminal.
122 * termhooks.h (TSET): New macro.
123 * coding.c, terminal.c, xselect.c: Adjust users.
124
cc92c454
SM
1252012-08-08 Stefan Monnier <monnier@iro.umontreal.ca>
126
127 * xdisp.c (safe_eval_handler): Remove prototype. Receive args describing
128 the failing expression, include them in the error message.
129 * eval.c (internal_condition_case_n): Pass nargs and args to hfun.
130 * lisp.h (internal_condition_case_n): Update declaration.
131
4cb3e6b3
DA
1322012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
133
134 Inline functions to examine and change buffer overlays.
135 * buffer.c (unchain_both): New function.
136 * buffer.h (buffer_get_overlays, buffer_set_overlays):
137 (buffer_has_overlays): New function.
138 (enum overlay_type): New enum.
139 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c:
140 * insdel.c, intervals.c, print.c, xdisp.c: Adjust users.
141
8707c1e5
DA
1422012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
143
144 Inline functions to examine and change buffer intervals.
145 * alloc.c (mark_interval_tree): Remove.
146 (MARK_INTERVAL_TREE): Simplify.
147 (UNMARK_BALANCE_INTERVALS): Remove. Adjust users.
148 * intervals.c (buffer_balance_intervals): New function.
149 (graft_intervals_into_buffer): Adjust indentation.
150 (set_intervals_multibyte): Simplify.
151 * buffer.h (BUF_INTERVALS): Remove.
152 (buffer_get_intervals, buffer_set_intervals): New function.
153 * alloc.c, buffer.c, editfns.c, fileio.c, indent.c, insdel.c:
154 * intervals.c, textprop.c: Adjust users.
155
ad8c997f
DA
1562012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
157
158 Inline functions to examine and change string intervals.
159 * lisp.h (STRING_INTERVALS, STRING_SET_INTERVALS): Remove.
160 (string_get_intervals, string_set_intervals): New function.
161 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
162 * lread.c, print.c, textprop.c: Adjust users.
163
32ac3a6b
GM
1642012-08-08 Glenn Morris <rgm@gnu.org>
165
166 * lisp.mk (lisp): Remove language/persian.elc.
167
77c7bcb1
DA
1682012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
169
170 Cleanup intervals.
171 * intervals.h (NULL_INTERVAL, DEFAULT_INTERVAL): Remove.
172 (NULL_INTERVAL_P): Likewise. Adjust users.
14ae4239
BT
173 (FRONT_STICKY_P, END_NONSTICKY_P, FRONT_NONSTICKY_P):
174 Adjust comment. Move under #if 0.
77c7bcb1
DA
175 * alloc.c, buffer.c, editfns.c, fns.c, insdel.c, intervals.c:
176 * print.c, syntax.c, textprop.c, xdisp.c: Adjust users.
177
9c08a8d4
DA
1782012-08-08 Dmitry Antipov <dmantipov@yandex.ru>
179
180 Check total length of intervals with eassert.
181 * intervals.h (CHECK_TOTAL_LENGTH): Remove.
182 * intervals.c: Change all users to eassert.
183
26d16b35
EZ
1842012-08-07 Eli Zaretskii <eliz@gnu.org>
185
14ae4239
BT
186 * .gdbinit (xframe, xwindow, nextcons, xcar, xcdr, xlist):
187 Rename fields to match removal of FGET and WGET and disuse of
26d16b35
EZ
188 INTERNAL_FIELD in Lisp_Cons.
189
c644523b
DA
1902012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
191
192 Revert and cleanup Lisp_Cons, Lisp_Misc and Lisp_Symbol things.
193 * lisp.h (struct Lisp_Symbol): Change xname to meaningful
194 name since all xname users are fixed long time ago. Do not
195 use INTERNAL_FIELD.
196 (set_symbol_name, set_symbol_function, set_symbol_plist):
197 (set_symbol_next, set_overlay_plist): New function.
198 (struct Lisp_Cons): Do not use INTERNAL_FIELD.
199 (struct Lisp_Overlay): Likewise.
200 (CVAR, MVAR, SVAR): Remove.
201 * alloc.c, buffer.c, buffer.h, bytecode.c, cmds.c, data.c:
202 * doc.c, eval.c, fns.c, keyboard.c, lread.c, nsselect.m:
203 * xterm.c: Adjust users.
204 * .gdbinit: Change to use name field of struct Lisp_Symbol
205 where appropriate.
206
6a3d20cc
DA
2072012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
208
209 Basic functions to set Lisp_Object and pointer slots of intervals.
210 * intervals.h (interval_set_parent, interval_set_object):
211 (interval_set_left, interval_set_right, interval_set_plist):
212 (interval_copy_parent): New function.
213 (SET_INTERVAL_OBJECT, SET_INTERVAL_PARENT, INTERVAL_PTR_SIZE): Remove.
14ae4239
BT
214 (RESET_INTERVAL, COPY_INTERVAL_CACHE, MERGE_INTERVAL_CACHE):
215 Adjust indentation.
6a3d20cc
DA
216 (INTERVAL_SIZE): Remove. Adjust users.
217 * alloc.c, intervals.c, lread.c, textprop.c: Use new functions.
218
4d2b044c
DA
2192012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
220
221 Drop PGET and revert read access to Lisp_Objects slots of Lisp_Process.
222 * process.h (PGET): Remove.
223 (struct Lisp_Process): Do not use INTERNAL_FIELD.
224 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
225
d3d50620
DA
2262012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
227
228 Drop WGET and revert read access to Lisp_Objects slots of struct window.
229 * window.h (WGET): Remove.
230 (struct window): Do not use INTERNAL_FIELD.
231 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
232 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
233 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
234 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
235 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
236 Adjust users.
237
d10a51dc
CY
2382012-08-07 Chong Yidong <cyd@gnu.org>
239
240 * window.c (Fwindow_edges, Fwindow_pixel_edges)
241 (Fwindow_absolute_pixel_edges, Fdelete_other_windows_internal)
242 (Fdelete_window_internal): Signal an error if the window is not on
243 a live frame (Bug#12025).
244
e69b0960
DA
2452012-08-07 Dmitry Antipov <dmantipov@yandex.ru>
246
247 Drop FGET and revert read access to Lisp_Objects slots of struct frame.
248 * frame.h (FGET): Remove.
249 (struct frame): Do not use INTERNAL_FIELD.
250 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
251 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
252 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
253 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
254
25a20a3a
JB
2552012-08-06 Juanma Barranquero <lekktu@gmail.com>
256
257 * w32.c: Silence compiler warnings.
258 (map_w32_filename): Remove unused variable `is_fat'.
259 (chase_symlinks): Add parentheses around expression.
260
1c6f11f4
GM
2612012-08-06 Glenn Morris <rgm@gnu.org>
262
1db4583a
GM
263 * sysdep.c: Respect BROKEN_GETWD.
264
1c6f11f4
GM
265 * dispnew.c (GNU_LIBRARY_PENDING_OUTPUT_COUNT, PENDING_OUTPUT_COUNT):
266 Let configure handle it.
267 (stdio_ext.h) [DISPNEW_NEEDS_STDIO_EXT]: Include it.
268
2b90362b
DA
2692012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Use GCALIGNMENT where appropriate.
272 * alloc.c (XMALLOC_HEADER_ALIGNMENT, roundup_size):
273 (union aligned_Lisp_Symbol, union aligned_Lisp_Misc):
274 (mark_maybe_pointer, pure_alloc): Change to use GCALIGNMENT.
275
5f50daf2
EZ
2762012-08-06 Eli Zaretskii <eliz@gnu.org>
277
14ae4239
BT
278 * w32menu.c (set_frame_menubar, initialize_frame_menubar):
279 Don't use FRAME_MENU_BAR_ITEMS as an lvalue.
5f50daf2 280
cbcc7007
SM
2812012-08-06 Stefan Monnier <monnier@iro.umontreal.ca>
282
283 * buffer.h (struct buffer): Revert `indirections' to a simple int;
284 that should be sufficient for everyone.
285
4d365fa4
JD
2862012-08-06 Jan Djärv <jan.h.d@swipnet.se>
287
288 * keyboard.c (timer_check_2): Add break so timer_check returns next
289 timeout.
290
dd86bd82
DA
2912012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
292
293 Fix Windows build errors introduced after converting to WGET and WSET.
294 * w32term.c (w32_set_vertical_scroll_bar): Change to use WSET.
295 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
296
054e1668
JD
2972012-08-06 Jan Djärv <jan.h.d@swipnet.se>
298
299 * nsterm.m (ns_frame_rehighlight): Use FSET.
300
301 * nsmenu.m (ns_update_menubar): Use FSET.
302
21238f11
DA
3032012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Separate read and write access to Lisp_Object slots of Lisp_Process.
306 * process.h (PGET, PSET): New macros similar to AREF and ASET.
307 * gnutls.c, print.c, process.c, sysdep.c, w32.c, xdisp.c: Adjust users.
308
077288cf
DA
3092012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
310
311 Separate read and write access to Lisp_Object slots of struct window.
312 * window.h (WGET, WSET): New macros similar to AREF and ASET.
313 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
314 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
315 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, msdos.c, nsfns.m:
316 * nsmenu.m, nsterm.m, print.c, textprop.c, w32fns.c, w32menu.c:
317 * w32term.c, window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c:
318 Adjust users.
319
71688bd7
DA
3202012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
321
322 Fix Windows build errors introduced after converting to FGET and FSET.
323 * w32term.c (x_frame_rehighlight, x_scroll_bar_create):
324 (w32_condemn_scroll_bars, w32_redeem_scroll_bar):
325 (w32_judge_scroll_bars): Change to use FSET.
326 Reported by Andy Moreton <andrewjmoreton@gmail.com>.
327
f99bac93
DA
3282012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
329
330 Fix replacement typo.
331 * window.c (replace_window): Set root_window instead of
332 selected_window. This fixes a total window subsystem
333 malfunction reported by Bastien Guerry <bzg@gnu.org>.
334
8c2a0f2d
GM
3352012-08-06 Glenn Morris <rgm@gnu.org>
336
337 * lisp.mk (lisp): Add language/persian.elc.
338
edd74c35
DA
3392012-08-06 Dmitry Antipov <dmantipov@yandex.ru>
340
341 Separate read and write access to Lisp_Object slots of struct frame.
342 * frame.h (FGET, FSET): New macros similar to AREF and ASET.
343 * buffer.c, data.c, dispnew.c, dosfns.c, eval.c, fontset.c, frame.c:
344 * fringe.c, gtkutil.c, minibuf.c, msdos.c, nsfns.m, nsmenu.m, nsterm.m:
345 * print.c, term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
346 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Adjust users.
347
8671676c
AS
3482012-08-05 Andreas Schwab <schwab@linux-m68k.org>
349
350 * emacs.c (decode_env_path): Only use defaulted if WINDOWSNT.
351
663e2b3f
DA
3522012-08-05 Dmitry Antipov <dmantipov@yandex.ru>
353
354 Generalize common compile-time constants.
355 * lisp.h (header_size, bool_header_size, word_size): Now here.
356 (struct Lisp_Vector): Add comment.
357 (struct Lisp_Bool_Vector): Move up to define handy constants.
358 (VECSIZE, PSEUDOVECSIZE): Simplify.
359 (SAFE_ALLOCA_LISP): Use new constant. Adjust indentation.
360 * buffer.c, buffer.h, bytecode.c, callint.c, eval.c, fns.c:
361 * font.c, fontset.c, keyboard.c, keymap.c, macros.c, menu.c:
362 * msdos.c, w32menu.c, w32term.h, window.c, xdisp.c, xfaces.c:
363 * xfont.c, xmenu.c: Use word_size where appropriate.
364
d32e47af
LM
3652012-08-05 Lawrence Mitchell <wence@gmx.li>
366
367 * search.c (Freplace_match): Treat \? in the replacement text
368 literally (Bug#8161).
369
e5d9c0d1
CY
3702012-08-05 Chong Yidong <cyd@gnu.org>
371
372 * term.c (Vsuspend_tty_functions, Vresume_tty_functions):
373 * frame.c (Vdelete_frame_functions):
374 * emacs.c (Vkill_emacs_hook): Doc fix.
375
8da0576b
EZ
3762012-08-04 Eli Zaretskii <eliz@gnu.org>
377
378 * xfns.c (x_set_menu_bar_lines): Fix compilation error in
379 --with-x-toolkit=no builds.
380 Reported by Carsten Mattner <carstenmattner@gmail.com>.
381
02676e5d
CY
3822012-08-04 Chong Yidong <cyd@gnu.org>
383
384 * syntax.c (Fmodify_syntax_entry): Doc fix.
385
97147da9
EZ
3862012-08-04 Eli Zaretskii <eliz@gnu.org>
387
76151e2c
EZ
388 Fix startup warnings about ../site-lisp on MS-Windows. (Bug#11959)
389 * w32.c (init_environment): Change the default values of many
390 environment variables in dflt_envvars[] to NULL, to avoid pushing
14ae4239
BT
391 them into environment when they were not already defined.
392 Remove the code that deletes site-lisp subdirectories from the default
76151e2c 393 value of EMACSLOADPATH, as it is no longer needed.
14ae4239
BT
394 (check_windows_init_file): Now external, not static.
395 Use Vload_path as is, without adding anything, as this function is now
76151e2c
EZ
396 called when Vload_path is already set up.
397
398 * w32.h (check_windows_init_file): Add prototype.
399
400 * emacs.c (init_cmdargs) [WINDOWSNT]: When running from the build
401 directory, ignore the /*/i386/ tail in Vinvocation_directory, for
402 compatibility with Posix platforms.
403 (main): Move the call to check_windows_init_file to here from
404 w32.c.
405 (decode_env_path) [WINDOWSNT]: Expand the %emacs_dir%/ prefix, if
406 any, in the DEFALT argument into the root of the Emacs build or
407 installation tree, as appropriate.
408
409 * callproc.c (init_callproc_1): Call decode_env_path instead of
410 doing its equivalent by hand.
411 (init_callproc): Replace DOS_NT condition with MSDOS, thus letting
412 the code that sets Vexec_path run on MS-Windows.
413
414 * lread.c (init_lread): Add comments to #ifdef's.
415
97147da9
EZ
416 * msdos.c (dos_set_window_size, IT_update_begin)
417 (IT_frame_up_to_date, IT_set_frame_parameters): Use FVAR and WVAR
418 instead of direct references.
419
185ee146
PE
4202012-08-04 Paul Eggert <eggert@cs.ucla.edu>
421
422 Export DEFAULT_REHASH_* to GDB.
423 * lisp.h (DEFAULT_REHASH_THRESHOLD, DEFAULT_REHASH_SIZE):
424 Now constants, not macros.
425
8834c57a
PE
4262012-08-03 Paul Eggert <eggert@cs.ucla.edu>
427
98c6f1e3
PE
428 Remove unnecessary casts involving pointers.
429 These casts are no longer needed now that we assume C89 or later,
430 since they involve casting to or from void *.
431 * alloc.c (make_pure_string, make_pure_c_string, pure_cons)
432 (make_pure_float, make_pure_vector):
433 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP):
434 * macros.c (Fstart_kbd_macro):
435 * menu.c (find_and_return_menu_selection):
436 * minibuf.c (read_minibuf_noninteractive):
437 * sysdep.c (closedir):
438 * xdisp.c (x_produce_glyphs):
439 * xfaces.c (compare_fonts_by_sort_order):
440 * xfns.c (x_real_positions, select_visual):
441 * xselect.c (x_stop_queuing_selection_requests)
442 (x_get_window_property, x_get_window_property_as_lisp_data):
443 * xterm.c (x_set_frame_alpha, x_find_modifier_meanings):
444 Remove unnecessary pointer casts.
445 * alloc.c (record_xmalloc): New function.
446 * lisp.h (record_xmalloc): New decl.
447 (SAFE_ALLOCA): Now takes just one arg -- the size -- and acts
448 more like a function. This is because the pointer cast is not
449 needed. All uses changed.
450 * print.c (print_string, print_error_message): Avoid length recalc.
451
8834c57a
PE
452 Improve fix for macroexp crash with debugging (Bug#12118).
453 * lisp.h (ASET) [ENABLE_CHECKING]: Pay attention to
454 ARRAY_MARK_FLAG when checking subscripts, because ASET is
455 not supposed to be invoked from the garbage collector.
456 See Andreas Schwab in <http://bugs.gnu.org/12118#25>.
457 (gc_aset): New function, which is like ASET but can be
458 used in the garbage collector.
459 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
460 (set_hash_index): Use it instead of ASET.
461
6dad7178
EZ
4622012-08-03 Eli Zaretskii <eliz@gnu.org>
463
464 Support symlinks on latest versions of MS-Windows.
465 * w32.c: Include winioctl.h and aclapi.h.
466 (is_symlink, chase_symlinks, enable_privilege, restore_privilege)
467 (revert_to_self): Forward declarations of static functions.
468 <static BOOL g_b_init_get_security_info>:
469 <g_b_init_create_symbolic_link>: New static flags.
470 (globals_of_w32): Initialize them to zero.
471 (GetSecurityInfo_Proc, CreateSymbolicLink_Proc): New typedefs.
472 (map_w32_filename): Improve commentary. Simplify switch.
473 (SYMBOLIC_LINK_FLAG_DIRECTORY): Define if not defined in system
474 headers (most versions of MinGW w32api don't).
475 (get_security_info, create_symbolic_link)
476 (get_file_security_desc_by_handle, is_symlink, chase_symlinks):
477 New functions.
478 (sys_access, sys_chmod): Call 'chase_symlinks' to resolve symlinks
479 in the argument file name.
480 (sys_access): Call unc_volume_file_attributes only if
481 GetFileAttributes fails with network-related error codes.
482 (sys_rename): Diagnose renaming of a symlink when the user doesn't
483 have the required privileges.
14ae4239 484 (get_file_security_desc_by_name): Rename from
6dad7178
EZ
485 get_file_security_desc.
486 (stat_worker): New function, with most of the guts of 'stat', and
14ae4239
BT
487 with addition of handling of symlinks and support for 'lstat'.
488 If possible, get file's attributes and security information by
6dad7178
EZ
489 handle, not by name. Produce S_IFLNK bit for symlinks, when
490 called from 'lstat'.
491 (stat, lstat): New functions, call 'stat_worker'.
492 (symlink, readlink, careadlinkat): Rewritten to create and resolve
493 symlinks when the underlying filesystem supports them.
494
f162bcc3
PE
4952012-08-02 Paul Eggert <eggert@cs.ucla.edu>
496
79ea6c20
PE
497 Fix macroexp crash on Windows with debugging (Bug#12118).
498 * lisp.h (ASET) [ENABLE_CHECKING]: Ignore ARRAY_MARK_FLAG when
499 checking subscripts; problem introduced with the recent
500 "ASET (a, i, v)" rather than "AREF (a, i) = v" patch.
501 (ARRAY_MARK_FLAG): Now a macro as well as a constant,
502 since it's used in non-static inline functions now.
503
c0ce93fd
PE
504 * xfaces.c (face_at_buffer_position, face_for_overlay_string):
505 Don't assume buffer size fits in 'int'. Remove unused local.
c71f5156 506
f162bcc3
PE
507 Use C99-style 'extern inline' if available.
508 * buffer.h (BUFFER_INLINE):
509 * category.h (CATEGORY_INLINE):
510 * character.h (CHARACTER_INLINE):
511 * charset.h (CHARSET_INLINE):
512 * composite.h (COMPOSITE_INLINE):
513 * dispextern.h (DISPEXTERN_INLINE):
514 * lisp.h (LISP_INLINE):
515 * systime.h (SYSTIME_INLINE):
516 New macro, replacing 'static inline' in this header.
517 * buffer.h, category.h, character.h, charset.h, composite.h:
518 * dispextern.h, lisp.h, systime.h:
519 Use INLINE_HEADER_BEGIN, INLINE_HEADER_END.
520 * alloc.c (LISP_INLINE):
521 * buffer.c (BUFFER_INLINE):
522 * category.c (CATEGORY_INLINE):
523 * character.c (CHARACTER_INLINE):
524 * charset.c (CHARSET_INLINE):
525 * composite.c (COMPOSITE_INLINE):
526 * dispnew.c (DISPEXTERN_INLINE):
527 * sysdep.c (SYSTIME_INLINE):
528 Define to EXTERN_INLINE, so that the corresponding functions
529 are compiled into code.
530 * conf_post.h (INLINE, EXTERN_INLINE, INLINE_HEADER_BEGIN)
531 (INLINE_HEADER_END): New macros.
532 * lisp.h (PSEUDOVECTOR_FLAG): Now a macro as well as a constant,
533 since it's used in non-static inline functions now.
a8333d03 534 (VALMASK) [!USE_LSB_TAG]: Likewise.
f162bcc3 535
837b365b
GM
5362012-08-02 Glenn Morris <rgm@gnu.org>
537
d66b744d
GM
538 * s/: Remove empty directory.
539
837b365b
GM
540 * s/ms-w32.h: Move to ../nt/inc.
541 * makefile.w32-in (TAGS, TAGS-gmake, MS_W32_H):
542 Update for new ms-w32.h location.
543
13294f95
PE
5442012-08-02 Paul Eggert <eggert@cs.ucla.edu>
545
546 Port to Solaris 8.
547 * syswait.h (WRETCODE): Remove, consistently with ../configure.ac.
548
90df0db3
GM
5492012-08-02 Glenn Morris <rgm@gnu.org>
550
551 * nsterm.m (ns_exec_path, ns_load_path): Use SEPCHAR rather than
552 hard-coding the path separator.
553
4939150c
PE
5542012-08-01 Paul Eggert <eggert@cs.ucla.edu>
555
556 Use "ASET (a, i, v)" rather than "AREF (a, i) = v".
557 This how ASET and AREF are supposed to work, and makes
558 it easier to think about future improvements. See
559 <http://lists.gnu.org/archive/html/emacs-devel/2012-08/msg00026.html>.
560 * charset.h (set_charset_attr): New function.
561 All lvalue-style uses of CHARSET_DECODER etc. changed to use it.
562 * lisp.h (ASET): Rewrite so as not to use AREF in an lvalue style.
563 (aref_addr): New function. All uses of &AREF(...) changed.
564 (set_hash_key, set_hash_value, set_hash_next, set_hash_hash)
565 (set_hash_index): New functions. All lvalue-style uses of
566 HASH_KEY etc. changed.
567 * keyboard.c (set_prop): New function. All lvalue-style uses
568 of PROP changed.
569
947b2afd
AA
5702012-08-01 Alp Aker <alp.tekin.aker@gmail.com>
571
572 * nsterm.m (ns_set_vertical_scroll_bar, ns_redeem_scroll_bar)
573 (EmacsWindow-accessibilityAttributeValue, EmacsScroller-initFrame:)
574 (EmacsScroller-dealloc): Adjust to use WVAR. (Bug#12114)
575 * nsfns.m (ns_set_name_as_filename): Likewise.
576 * nsmenu.m (ns_update_menubar): Likewise.
577 * nsselect.m (symbol_to_nsstring): Adjust to use SVAR.
578
4f5d0325
EZ
5792012-08-01 Eli Zaretskii <eliz@gnu.org>
580
2008beae
EZ
581 * .gdbinit (xcar, xcdr, xlist, xwindow, nextcons, xprintsym):
582 Adapt to latest changes in field names of the corresponding Lisp
288479f6 583 objects.
2008beae 584
4f5d0325
EZ
585 * xdisp.c (try_window_id): Use WVAR in IF_DEBUG code.
586
fe3cc771
GM
5872012-08-01 Glenn Morris <rgm@gnu.org>
588
589 * s/msdos.h: Remove file.
590 * conf_post.h [MSDOS]: New section, moved from s/msdos.h.
591 * Makefile.in (S_FILE): Remove.
592 (config_h): Remove S_FILE.
593
c90acc54
JB
5942012-08-01 Juanma Barranquero <lekktu@gmail.com>
595
596 * s/ms-w32.h (DEVICE_SEP, IS_DIRECTORY_SEP, IS_ANY_SEP):
597 Remove; moved to nt/config.nt.
598
d8a05828
DA
5992012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
600
601 Use INTERNAL_FIELD for conses and overlays.
602 * lisp.h (struct Lisp_Cons): Use INTERNAL_FIELD.
603 Remove obsolete comment.
604 (MVAR): New macro.
605 (struct Lisp_Overlay): Use INTERNAL_FIELD.
606 * alloc.c, buffer.c, buffer.h, fns.c: Adjust users.
607
8271d590
DA
6082012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
609
610 Use INTERNAL_FIELD for symbols.
611 * lisp.h (SVAR): New macro. Adjust users.
612 * alloc.c, bytecode.c, cmds.c, data.c, doc.c, eval.c:
613 * fns.c, keyboard.c, lread.c, xterm.c: Users changed.
614
3193acd2
DA
6152012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
616
617 Use INTERNAL_FIELD for processes.
618 * process.h (PVAR): New macro. Adjust style.
619 (struct Lisp_Process): Change Lisp_Object members to INTERNAL_FIELD.
620 * print.c, process.c, sysdep.c, w32.c, xdisp.c: Users changed.
621
3a45383a
DA
6222012-08-01 Dmitry Antipov <dmantipov@yandex.ru>
623
624 Use INTERNAL_FIELD for windows.
625 * window.h (WVAR): New macro.
626 (struct window): Change Lisp_Object members to INTERNAL_FIELD.
627 * alloc.c, buffer.c, composite.c, dispextern.h, dispnew.c, editfns.c:
628 * fileio.c, font.c, fontset.c, frame.c, frame.h, fringe.c, indent.c:
629 * insdel.c, keyboard.c, keymap.c, lisp.h, minibuf.c, nsterm.m, print.c:
630 * textprop.c, w32fns.c, w32menu.c, w32term.c, window.c, xdisp.c:
631 * xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
632
c1dbc63c
PE
6332012-08-01 Paul Eggert <eggert@cs.ucla.edu>
634
635 * coding.h (CODING_ATTR_FLUSHING): Remove; unused and wouldn't work.
636
5c0c0e8a
GM
6372012-08-01 Glenn Morris <rgm@gnu.org>
638
639 * lisp.h (IS_DIRECTORY_SEP, IS_DEVICE_SEP, IS_ANY_SEP):
640 Move to configure.ac.
641
552a99b4
JB
6422012-08-01 Juanma Barranquero <lekktu@gmail.com>
643
644 * makefile.w32-in (CONFIG_H): Update dependencies.
645 (CONF_POST_H): New macro.
646
647 * s/ms-w32.h (SEPCHAR, NULL_DEVICE): Remove; moved to nt/config.nt.
648
8d8e2dfe
GM
6492012-07-31 Glenn Morris <rgm@gnu.org>
650
bc96620a
GM
651 * Makefile.in (S_FILE): No longer set by configure.
652
476b1b2d
GM
653 * conf_post.h (config_opsysfile): Move earlier, so that WINDOWSNT
654 is available.
655 (alloca.h) [WINDOWSNT]: Don't include it on MS Windows.
656
b2c7a106
GM
657 * process.h (NULL_DEVICE):
658 * emacs.c (SEPCHAR):
659 * editfns.c (USER_FULL_NAME): Let configure set them.
660
d53d062a
GM
661 * s/README, s/template.h: Remove files.
662
4515017f
GM
663 * conf_post.h [HPUX]: Undefine HAVE_RANDOM and HAVE_RINT.
664
8d8e2dfe
GM
665 * conf_post.h (AMPERSAND_FULL_NAME, subprocesses):
666 Move to configure.ac.
667
5b20b3cc
EZ
6682012-07-31 Eli Zaretskii <eliz@gnu.org>
669
1e0afd9a
EZ
670 * .gdbinit (xframe): Adapt to introduction of FVAR and the
671 resulting renaming of 'struct frame' members.
672
5b20b3cc
EZ
673 * w32menu.c (w32_menu_show): Revert bogus introduction of FVAR.
674
675 * fontset.c (dump_fontset): Fix compilation with ENABLE_CHECKING
676 after introduction of FVAR.
677
f1310128
JD
6782012-07-31 Jan Djärv <jan.h.d@swipnet.se>
679
79e721e0
JD
680 * nsmenu.m (update_frame_tool_bar): Change key from NSObject* to id.
681
682 * nsterm.m (ns_draw_fringe_bitmap, ns_dumpglyphs_image): Use drawInRect
683 instead of compositeToPoint.
684 (applicationShouldTerminate): Pass NS String literal to NSRunAlertPanel.
685
8d7c7eed 686 * nsfns.m, nsmenu.m, nsterm.m: Adopt to struct frame/FVAR changes.
f1310128 687
e34f7f79
DA
6882012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
689
690 Generalize INTERNAL_FIELD between buffers, keyboards and frames.
691 * lisp.h (INTERNAL_FIELD): New macro.
14ae4239 692 * buffer.h (BUFFER_INTERNAL_FIELD): Remove.
e34f7f79
DA
693 (BVAR): Change to use INTERNAL_FIELD.
694 * keyboard.h (KBOARD_INTERNAL_FIELD): Likewise.
695 (KVAR): Change to use INTERNAL_FIELD.
696 * frame.h (FVAR): New macro.
697 (struct frame): Use INTERNAL_FIELD for all Lisp_Object fields.
3a45383a
DA
698 * alloc.c, buffer.c, data.c, dispnew.c, dosfns.c, eval.c, frame.c:
699 * fringe.c, gtkutil.c, minibuf.c, nsfns.m, nsterm.m, print.c:
700 * term.c, w32fns.c, w32menu.c, w32term.c, window.c, window.h:
e34f7f79
DA
701 * xdisp.c, xfaces.c, xfns.c, xmenu.c, xterm.c: Users changed.
702
c09bfb2f
DA
7032012-07-31 Dmitry Antipov <dmantipov@yandex.ru>
704
705 Miscellaneous fixes for non-default X toolkits.
706 * xfns.c (Fx_file_dialog): Change to SSDATA to avoid warnings.
707 * xterm.c (x_frame_of_widget): Remove redundant prototype.
708 Move under #ifdef USE_LUCID.
709 (x_create_toolkit_scroll_bar): Adjust scroll_bar_name
710 definition and usage to avoid warnings.
711
14c114ae
JD
7122012-07-31 Jan Djärv <jan.h.d@swipnet.se>
713
714 * nsterm.m (openFiles): Fix previous checkin.
715
3bd21e82
PE
7162012-07-31 Paul Eggert <eggert@cs.ucla.edu>
717
718 * indent.c (compute_motion): Remove unused local.
719
c1529ded
GM
7202012-07-31 Glenn Morris <rgm@gnu.org>
721
400d5621
GM
722 * s/usg5-4-common.h (wait3, WRETCODE): Let configure set them.
723
268e2432
GM
724 * conf_post.h [USG5_4]:
725 Move remaining contents of s/usg5-4-common.h here.
726 * s/usg5-4-common.h: Remove file.
727
7552f3ee
GM
728 * conf_post.h [IRIX6_5]: Move remaining contents of s/irix6-5.h here.
729 * s/irix6-5.h: Remove file.
730
6a381852
GM
731 * conf_post.h [DARWIN_OS]: Move remaining contents of s/darwin.h here.
732 * s/darwin.h: Remove file.
733
c1529ded
GM
734 * conf_post.h [HPUX]: Move random, srandom here from s/hpux10-20.h.
735 * s/hpux10-20.h: Remove file, which is now empty.
736
b429a4ee
GM
7372012-07-30 Glenn Morris <rgm@gnu.org>
738
739 * conf_post.h: New, split from configure.ac's AH_BOTTOM.
740 * Makefile.in (config_h): Add conf_post.h.
741 * makefile.w32-in (CONFIG_H): Add conf_post.h.
742
adff3182
JD
7432012-07-30 Jan Djärv <jan.h.d@swipnet.se>
744
745 * nsterm.m (ns_do_open_file): New variable.
b9031d69 746 (ns_term_init): Set ns_do_open_file to YES after run returns.
14ae4239
BT
747 (openFile, openTempFile, openFileWithoutUI, openFiles):
748 Open files only if ns_do_open_file.
adff3182 749
c32af1e4
PE
7502012-07-30 Paul Eggert <eggert@cs.ucla.edu>
751
7393bcbb
PE
752 * lisp.h (SWITCH_ENUM_CAST): Remove. All uses removed.
753 This no-op macro hasn't been needed for many years.
754 * src/regex.c (SWITCH_ENUM_CAST) [!emacs]: Likewise.
755
c32af1e4
PE
756 Export DIRECTORY_SEP, TYPEMASK, VALMASK to GDB.
757 * alloc.c (gdb_make_enums_visible) [USE_LSB_TAG]: Add lsb_bits.
758 * lisp.h (enum lsb_bits) [USE_LSB_TAG]: New enum, for
759 gdb_make_enums_visible.
760 (TYPEMASK, VALMASK) [USE_LSB_TAGS]: Now enum constants, not macros.
761 (DIRECTORY_SEP): Now a constant, not a macro.
762
302fc036
EZ
7632012-07-30 Eli Zaretskii <eliz@gnu.org>
764
765 * w32fns.c (w32_wnd_proc): Pass w32_keyboard_codepage to
766 w32_kbd_patch_key as the 2nd arg. (Bug#12082)
767
768 * w32term.c <w32_keyboard_codepage>: Renamed from
769 keyboard_codepage and now external. All users changed.
770
771 * w32term.h: Add declaration of w32_keyboard_codepage.
772
773 * w32inevt.c (w32_kbd_patch_key): Accept an additional argument --
774 the codepage to translate keys to Unicode. If this argument is
775 -1, use the value returned by GetConsoleCP. All callers changed.
776
88fb40b4
PE
7772012-07-30 Paul Eggert <eggert@cs.ucla.edu>
778
0aee6912
PE
779 Update .PHONY listings in makefiles.
780 * Makefile.in (.PHONY): Add all, mostlyclean, clean,
781 bootstrap-clean, distclean, maintainer-clean, versioclean,
782 extraclean, frc.
783
88fb40b4
PE
784 * lisp.h (STRING_BYTES_BOUND): Cast entire result to ptrdiff_t.
785 This is a bit clearer. Fix some commentary typos.
786
0a763bd1
GM
7872012-07-30 Glenn Morris <rgm@gnu.org>
788
32bac6d6
GM
789 * s/netbsd.h: Let configure include signal.h if needed.
790 Remove file, which is now empty.
791
b65e7c46
GM
792 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
793 Let configure set them.
794 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
795 No more need to undefine.
0a763bd1 796
169304bd
AS
7972012-07-30 Andreas Schwab <schwab@linux-m68k.org>
798
799 * keymap.c (Fkey_description): Don't remove 0x80 bit from
800 non-single-byte char when adding meta modifier. (Bug#12090)
801
6cd7a139
DA
8022012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
803
804 Convert safe_call to use variable number of arguments.
805 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
806 (safe_call2): Fix comment.
807 * lisp.h (safe_call): Adjust prototype.
808 * coding.c (encode_coding_object): Change to use safe_call2.
809 * xfaces.c (merge_face_heights): Change to use safe_call1.
810
d34d6ffc
GM
8112012-07-30 Glenn Morris <rgm@gnu.org>
812
7b8a48e4 813 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 814 does that unconditionally. Remove file, which is now empty.
7b8a48e4 815
d34d6ffc
GM
816 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
817 Remove empty files.
818
03a660a6
PE
8192012-07-30 Paul Eggert <eggert@cs.ucla.edu>
820
821 Export to GDB most of lisp.h's remaining object-like macros.
822 * lisp.h (min, max): Move earlier, because they're used earlier now.
823 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
824 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
825 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
826 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
827 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
828 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
829 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
830 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
831 Now constants, for GDB. They need not be macros.
832 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
833 Now constants, for GDB, as well as macros, for static initializers.
834 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
835 Move to after the definition of struct Lisp_Char_Table,
836 since the former now needs that type defined.
837 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
838 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
839 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
840 New enums, for gdb_make_enums_visible.
841 (GLYPH_MODE_LINE_FACE): Remove; unused.
88fb40b4 842 * alloc.c (STRING_BYTES_MAX): Now a constant, not a macro.
03a660a6
PE
843 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
844 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
845 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
846 enum maxargs, enum MAX_ALLOCA.
847 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
848 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
849 no longer needed, now that they are done in lisp.h.
850
e499d0ee
DA
8512012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
852
853 Cleanup string bytes checking.
854 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
855 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
856 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
857 (check_sblock, compact_small_strings): Simplify.
858
d5040d2d
PE
8592012-07-29 Paul Eggert <eggert@cs.ucla.edu>
860
861 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
862 These macros are confusing and no longer need to be defined, as
863 the enum values now suffice. All uses replaced with definiens.
864 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
865
7f259ae6
JB
8662012-07-29 Juanma Barranquero <lekktu@gmail.com>
867
868 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
869 ($(BLD)/w32console.$(O)): Update dependencies.
870
7e63e0c3
DA
8712012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
872
873 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
874 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
875 time. Adjust users.
876 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
877
ffd817eb
JD
8782012-07-29 Jan Djärv <jan.h.d@swipnet.se>
879
880 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
881 setting sitelisp (Bug#12010).
882
417a7a0e
EZ
8832012-07-29 Eli Zaretskii <eliz@gnu.org>
884
14ae4239 885 * w32heap.h (OS_9X): Rename from OS_WINDOWS_95.
417a7a0e
EZ
886
887 * w32heap.c (cache_system_info):
888 * w32.c (sys_rename):
889 * w32proc.c (find_child_console, sys_kill): All users changed.
890
387d4d92
PE
8912012-07-29 Paul Eggert <eggert@cs.ucla.edu>
892
893 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
894
55a6cca6
EZ
8952012-07-29 Eli Zaretskii <eliz@gnu.org>
896
897 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
898
dbcf001c
DA
8992012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
900
901 Cleanup statistics calculation in Fgarbage_collect.
14ae4239
BT
902 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start.
903 Fix zombies percentage calculation. Simplify elapsed time calculation.
dbcf001c 904
e2688e4a
DA
9052012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
906
907 Generalize marker debugging code under MARKER_DEBUG and use eassert.
908 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
909 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
910 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
911 (replace_range, replace_range_2, del_range_2): Change to eassert.
912 * marker.c (byte_char_debug_check): Adjust style.
913
b46a6a83
PE
9142012-07-29 Paul Eggert <eggert@cs.ucla.edu>
915
916 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
917 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
918 long-ago-commented-out code that talks about "WIN32".
919 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
920 All uses changed.
921
e32a5799
PE
9222012-07-28 Paul Eggert <eggert@cs.ucla.edu>
923
924 Use Gnulib stdalign module (Bug#9772, Bug#9960).
925 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
926 Simplify by using alignof.
927 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
928 * lisp.h: Include <stdalign.h>.
929 (GCALIGNMENT): New macro and constant.
930 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
931 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
932 (stdalign): New macro, if not already defined.
933
df81cd29
EZ
9342012-07-28 Eli Zaretskii <eliz@gnu.org>
935
01bd1b0d
EZ
936 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
937 * w32inevt.c: Include w32inevt.h.
938 (w32_read_console_input): New inline function, calls either
939 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
940 w32_console_unicode_input.
941 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
942 (w32_kbd_patch_key, key_event): Use the codepage returned by
943 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
944 (key_event): use uChar.UnicodeChar only if
945 w32_console_unicode_input is non-zero.
946
947 * w32console.c: Include w32heap.h.
948 <w32_console_unicode_input>: New global variable.
949 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
950 family of Windows, zero otherwise.
951
952 * w32inevt.h: Declare w32_console_unicode_input.
953
df81cd29
EZ
954 * xdisp.c (init_iterator): Don't reference tip_frame in a build
955 --without-x. (Bug#11742)
956
c20fdd9e
PE
9572012-07-27 Paul Eggert <eggert@cs.ucla.edu>
958
959 Adjust GDB to reflect pvec_type changes (Bug#12036).
960 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
14ae4239
BT
961 2012-07-04 changes to pseudovector representation.
962 Problem reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
c20fdd9e 963
32770973 9642012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
965
966 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
967 bus address.
968 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
969
3438fe21
EZ
9702012-07-27 Eli Zaretskii <eliz@gnu.org>
971
bcfbc9de
EZ
972 * alloc.c (listn): Fix the order the arguments are consed onto the
973 list.
974
3438fe21
EZ
975 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
976 enumeration constants, as PURE and HEAP are too general, and clash
977 with other headers and sources, such as gmalloc.c and the
978 MS-Windows system headers. All users changed.
979
eeaea515
DA
9802012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
981
982 Revert last save_excursion_save and save_excursion_restore changes.
983 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
984 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
985
073c88c2
DA
9862012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
987
988 Fix recently-introduced typos in Windows port.
989 Reported by Martin Rudalics <rudalics@gmx.at>.
990 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 991 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 992
4706125e
PE
9932012-07-27 Paul Eggert <eggert@cs.ucla.edu>
994
995 Improve GDB symbol export (Bug#12036).
996 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
997 arms of an 'if', not using conditional expressions; otherwise GDB
998 complains about the types in the unevaluated arm when the argument
999 is an integer literal.
1000 (xgetint): Simplify expression.
1001 * alloc.c (gdb_make_enums_visible): New constant. This ports to
1002 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
1003 Zaretskii in <http://bugs.gnu.org/12036#13>.
1004 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
1005 needed now that we have gdb_make_enums_visible.
1006 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
1007 (enum enum_USE_LSB_TAG):
1008 New enum types, packaging up enums that need to be exported to GDB.
1009
694b6c97
DA
10102012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1011
1012 Utility function to make a list from specified amount of objects.
1013 * lisp.h (enum constype): New datatype.
1014 (listn): New prototype.
1015 * alloc.c (listn): New function.
1016 (Fmemory_use_count, syms_of_alloc): Use it.
1017 * buffer.c (syms_of_buffer): Likewise.
1018 * callint.c (syms_of_callint): Likewise.
1019 * charset.c (define_charset_internal): Likewise.
1020 * coding.c (syms_of_coding): Likewise.
1021 * keymap.c (syms_of_keymap): Likewise.
1022 * search.c (syms_of_search): Likewise.
1023 * syntax.c (syms_of_syntax): Likewise.
1024 * w32.c (init_environment): Likewise.
1025 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
1026 * xdisp.c (syms_of_xdisp): Likewise.
1027 * xfns.c (syms_of_xfns): Likewise.
1028
6195f384
DA
10292012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
1030
1031 Fast save_excursion_save and save_excursion_restore.
1032 * lisp.h (struct Lisp_Excursion): New data type.
1033 (PVEC_EXCURSION): New pseudovector type.
1034 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
1035 to deal with it. Adjust comments.
1036 (init_marker, attach_marker): New prototype.
1037 (unchain_marker): Adjust prototype.
1038 * marker.c (attach_marker): Change to global.
1039 (init_marker): New function.
1040 * alloc.c (Fmake_marker, build_marker): Use it.
1041 (build_marker): More easserts.
1042 (mark_object): Handle struct Lisp_Excursion.
1043 * editfns.c (save_excursion_save, save_excursion_restore):
1044 Reimplement to use struct Lisp_Excursion. Add comments.
1045
5eceb8fb
PE
10462012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1047
1048 Fix export of symbols to GDB (Bug#12036).
1049 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
1050 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
1051 emacs.c, as this is a more-suitable home. Had this been done earlier
1052 the fix for 12036 would have avoided some of the problems noted in
1053 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
1054 would have been more obvious.
562157c8
PE
1055 * emacs.c: Do not include <verify.h>; no longer needed.
1056 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
1057 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
1058 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1059 Remove; now done in lisp.h.
1060 * lisp.h (PUBLISH_TO_GDB): New macro.
1061 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
1062 (DATA_SEG_BITS): Use it.
1063 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
1064 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
1065 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
1066 not be usable in #if. This simplifies things.
1067
d6749401
JB
10682012-07-26 Juanma Barranquero <lekktu@gmail.com>
1069
1070 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
1071
1781b9e9
PE
10722012-07-26 Paul Eggert <eggert@cs.ucla.edu>
1073
d89518db 1074 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
1075 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
1076 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
1077 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
1078 Adjust to changes in lisp.h and emacs.c, by using
1079 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
1080 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
1081 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
1082 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
1083 instead of gdb_valbits.
1084 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
1085 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
1086 instead of gdb_array_mark_flag.
1087 (xboolvector): Get size from $->size, not $->header.size.
1088 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
1089 (xreload, hook-run, hookpost-run): Remove.
1090 * emacs.c: Include <verify.h>.
1091 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
1092 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
1093 Remove.
1094 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
1095 (gdb_USE_LSB_TAG): New enum constants.
1096 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
1097 Also define these as enum constants, so they're visible to GDB.
1098 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
1099 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
1100 as constants, so they're visible to GDB.
1101 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
1102 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
1103 Now enum constants, not macros, so they're visible to GDB.
1104 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
1105 more convenient now. All uses changed.
1106 (VALMASK) [USE_LSB_TAG]: Also define in this case.
1107 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
1108
3628596a
DA
11092012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
1110
1111 Explicitly free restriction data that are not needed anymore.
1112 * editfns.c (save_restriction_restore): Free restriction data.
1113
7abaf5cc
SM
11142012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
1115
1116 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
1117 add argument, tune behavior, and adjust all callers.
1118
71f88e00
PE
11192012-07-25 Paul Eggert <eggert@cs.ucla.edu>
1120
1121 Use typedef for EMACS_INT, EMACS_UINT.
1122 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
1123 than macros. This simplifies debugging in the usual case, since
1124 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
1125 and it allows expressions involving EMACS_INT casts.
1126 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
1127
57ec3034
JD
11282012-07-25 Jan Djärv <jan.h.d@swipnet.se>
1129
1130 * nsterm.m (ns_read_socket): Return early if there is a modal
1131 window (Bug#12043).
1132
8137e7b3
MR
11332012-07-25 Martin Rudalics <rudalics@gmx.at>
1134
1135 * frame.c (Fredirect_frame_focus): In doc-string don't mention
1136 that FOCUS-FRAME can be omitted.
1137
04e9897c
DA
11382012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
1139
1140 Adjust buffer text indirection counters at the end of Fkill_buffer.
1141 * buffer.c (Fkill_buffer): Adjust indirection counters when the
1142 buffer is definitely dead. This should really fix an issue reported
1143 by Christoph Scholtes again. (Bug#12007).
1144 (init_buffer_once): Initialize indirection counters of
1145 buffer_defaults and buffer_local_symbols (for sanity and safety).
1146
8a0484e1
EZ
11472012-07-24 Eli Zaretskii <eliz@gnu.org>
1148
1149 * xdisp.c (init_iterator): Don't compute dimensions of truncation
1150 and continuation glyphs on tooltip frames, leave them at zero.
1151 Avoids continued lines in tooltips. (Bug#11832)
1152
fa691a83
DA
11532012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
1154
1155 Simplify copy_overlay.
04e9897c 1156 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
1157 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
1158
436bc8e0
EZ
11592012-07-23 Eli Zaretskii <eliz@gnu.org>
1160
1161 * print.c (print_object): Don't crash when a frame's name is nil
1162 or invalid. (Bug#12025)
1163
1164 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
1165 it signals an error when a tooltip frame is being created.
1166
d7a7fda3
DA
11672012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
1168
1169 Cleanup miscellaneous objects allocation and initialization.
1170 * alloc.c (allocate_misc): Change to static. Add argument to
1171 specify the subtype. Adjust comment and users.
1172 (build_overlay): New function.
1173 * buffer.c (copy_overlays, Fmake_overlay): Use it.
1174 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
1175 (allocate_misc): Remove prototype.
1176 (build_overlay): Add prototype.
1177
11782012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
1179
1180 Swap buffer text indirection counters in Fbuffer_swap_text.
1181 * buffer.c (Fbuffer_swap_text): Swap indirections too.
1182 This avoids crash reported by Christoph Scholtes at
1183 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
1184
9d7fa573
JD
11852012-07-22 Jan Djärv <jan.h.d@swipnet.se>
1186
1187 * nsmenu.m (Popdown_data): New struct.
1188 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
1189 free Popdown_data.
1190 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
1191 (initWithContentRect): Make imgView and contentView non-static
1192 and autorelease them. Also autorelease img and matrix (Bug#12005).
1193 (dealloc): Remove (Bug#12005).
1194
0dd6d66d
DA
11952012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1196
1197 Adjust consing_since_gc when objects are explicitly freed.
1198 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
1199 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
1200 (free_cons, free_misc): Subtract object size from consing_since_gc.
1201
d36d71df
DA
12022012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
1203
1204 Simplify and cleanup markers positioning code.
1205 * marker.c (attach_marker): More useful eassert.
1206 (live_buffer, set_marker_internal): New function.
1207 (Fset_marker, set_marker_restricted): Use set_marker_internal.
1208 (set_marker_both, set_marker_restricted_both): Use live_buffer.
1209
fb9ea40f
PE
12102012-07-22 Paul Eggert <eggert@cs.ucla.edu>
1211
1212 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
1213 as it's limited by the amount of memory, not by INT_MAX.
1214
2d5c5f7d
EZ
12152012-07-21 Eli Zaretskii <eliz@gnu.org>
1216
07fb592e
EZ
1217 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
1218 in special-event-map. See the discussion at
1219 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
1220 for the reasons.
1221
37a9eac8 1222 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
14ae4239
BT
1223 info.dwItemData. Fixes crashes on 64-bit Windows.
1224 Suggested by Fabrice Popineau <fabrice.popineau@supelec.fr>.
2d5c5f7d 1225
c4328746
JD
12262012-07-21 Jan Djärv <jan.h.d@swipnet.se>
1227
1228 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 1229 (conversationIdentifier): Return value is NSInteger.
784051c4 1230 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 1231
6e5d1c12
CY
12322012-07-21 Chong Yidong <cyd@gnu.org>
1233
1234 * window.c (decode_any_window): Signal an error if the window is
1235 on a dead frame (Bug#11984).
1236
9928463d
DA
12372012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1238
1239 Add indirection counting to speed up Fkill_buffer.
1240 * buffer.h (struct buffer): New member.
1241 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
1242 (Fmake_indirect_buffer): Set indirection counter to -1, increment
1243 base buffer indirection counter.
1244 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
1245 (Fkill_buffer): Adjust indirection counters as needed, don't walk
1246 through buffer list if indirection counter is 0.
1247
f8643a6b
DA
12482012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1249
1250 Extend the value returned by Fgarbage_collect with heap statistics.
1251 * alloc.c (Qheap): New symbol.
1252 (syms_of_alloc): DEFSYM it.
1253 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
1254 (Fmemory_free): Remove.
1255 (syms_of_alloc): Don't defsubr it.
1256 * buffer.c (Fcompact_buffer): Remove.
1257 (syms_of_buffer): Don't defsubr it.
1258
dac616ff
DA
12592012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1260
1261 Make maybe_gc inline.
1262 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
1263 * lisp.h (consing_since_gc, gc_relative_threshold)
1264 (memory_full_cons_threshold): Revert declaration.
1265 (maybe_gc): Remove prototype, define as inline.
1266 * alloc.c: Remove old commented-out code.
1267 (consing_since_gc, gc_relative_threshold)
1268 (memory_full_cons_threshold): Revert to global.
1269 (maybe_gc): Remove.
1270
d7ea76b4
DA
12712012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1272
1273 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
1274 * lisp.h (build_unibyte_string): New function.
1275 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
1276 * sysdep.c, w32fns.c, xfns.c: Use it.
1277 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
1278 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
1279 Adjust users accordingly.
1280 * font.h (font_open_by_name): Adjust prototype.
1281
765e61e3
DA
12822012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
1283
1284 Cleanup calls to Fgarbage_collect.
1285 * lisp.h (maybe_gc): New prototype.
1286 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1287 Remove declarations.
1288 * alloc.c (maybe_gc): New function.
1289 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
1290 Make them static.
1291 * bytecode.c (MAYBE_GC): Use maybe_gc.
1292 * eval.c (eval_sub, Ffuncall): Likewise.
1293 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
1294 to avoid dependency from auto-save feature.
1295
52b852c7
PE
12962012-07-19 Paul Eggert <eggert@cs.ucla.edu>
1297
1298 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
1299 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
1300 'for_each_per_buffer_object_at'.
1301 All uses changed. It's better to use upper-case for macros that
1302 cannot be implemented as functions, to give the reader a clue
1303 that they're special.
1304
5db81e33
SM
13052012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
1306
1307 * alloc.c (Fgarbage_collect): Tweak docstring.
1308
5b835e1d
DA
13092012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1310
1311 Tweak the value returned from Fgarbage_collect again.
1312 * alloc.c (Fgarbage_collect): New return value, as confirmed in
1313 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
1314 Adjust documentation.
1315 (total_vector_bytes): Rename to total_vector_slots, adjust
1316 accounting.
1317 (total_free_vector_bytes): Rename to total_free_vector_slots,
1318 adjust accounting.
1319 (Qstring_bytes, Qvector_slots): New symbols.
1320 (syms_of_alloc): DEFSYM them.
1321
9cd47b72
DA
13222012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1323
1324 Buffer compaction primitive which may be used from Lisp.
1325 * buffer.c (compact_buffer, Fcompact_buffer): New function.
1326 (syms_of_buffer): Register Fcompact_buffer.
1327 * alloc.c (Fgarbage_collect): Use compact_buffer.
1328 * buffer.h (compact_buffer): New prototype.
1329 (struct buffer_text): New member.
1330
d17337e5
DA
13312012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
1332
1333 New macro to iterate over all buffers, miscellaneous cleanups.
1334 * lisp.h (all_buffers): Remove declaration.
1335 * buffer.h (all_buffers): Add declaration, with comment.
1336 (for_each_buffer): New macro.
1337 * alloc.c (Fgarbage_collect, mark_object): Use it.
1338 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
1339 (init_buffer): Likewise.
1340 * data.c (Fset_default): Likewise.
1341 * coding.c (code_conversion_restore): Remove redundant check
1342 for dead buffer.
1343 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
1344
60cfd278
AS
13452012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1346
1347 Fix bug that created negative-length intervals.
1348 * intervals.c (merge_interval_right, merge_interval_left):
1349 Do not zero out this interval if it is absorbed by its children,
1350 as this interval's total length doesn't change in that case. See
1351 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
1352
d06714cb
PE
13532012-07-18 Paul Eggert <eggert@cs.ucla.edu>
1354
83713154
PE
1355 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
1356 when invoking (make-bool-vector N t) and N is a positive
1357 multiple of 8 -- the last 8 bits were mistakenly cleared.
1358
d06714cb
PE
1359 Remove some struct layout assumptions in bool vectors.
1360 * alloc.c (bool_header_size): New constant.
1361 (header_size, word_size): Move earlier, as they're now used earlier.
1362 Use 'word_size' in a few more places, where it's appropriate.
1363 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
1364 padding before the data member of a bool vector.
1365 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
1366 than doing the check by hand with an abort ().
1367
464d5a5e
SM
13682012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1369
5fbc0409
SM
1370 * eval.c (Fdefvar): Don't check constants since we only set the var if
1371 it's not yet defined anyway (bug#11904).
1372
464d5a5e
SM
1373 * lisp.h (last_undo_boundary): Declare new var.
1374 * keyboard.c (command_loop_1): Set it.
1375 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
1376 were auto-added by the command loop (bug#11774).
1377
8dc2e44a
AS
13782012-07-18 Andreas Schwab <schwab@linux-m68k.org>
1379
1380 * w32font.c (Qsymbol): Remove local definition.
1381 (syms_of_w32font): Don't DEFSYM it.
1382
169925ec
DA
13832012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1384
1385 Fix sweep_vectors to handle large bool vectors correctly.
1386 * alloc.c (sweep_vectors): Account total_vector_bytes for
1387 bool vectors larger than VBLOCK_BYTES_MAX.
1388
5fbfb018
CY
13892012-07-18 Chong Yidong <cyd@gnu.org>
1390
1391 * frame.c (x_set_frame_parameters): Revert bogus change introduced
1392 in 2012-05-25 commit by Paul Eggert (Bug#11738).
1393
3ab6e069
DA
13942012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
1395
1396 Return more descriptive data from Fgarbage_collect.
1397 Suggested by Stefan Monnier in
1398 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
1399 * alloc.c (bounded_number): New function.
1400 (total_buffers, total_vectors): New variable.
1401 (total_string_size): Rename to total_string_bytes, adjust users.
1402 (total_vector_size): Rename to total_vector_bytes, adjust users.
1403 (sweep_vectors): Account total_vectors and total_vector_bytes.
1404 (Fgarbage_collect): New return value. Adjust documentation.
1405 (gc_sweep): Account total_buffers.
1406 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
1407 (VECTOR_SIZE): Remove.
1408 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
1409 (Qinterval, Qmisc): New symbols.
1410 (syms_of_data): Initialize them.
1411 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
1412 (Qcons, Qbuffer): New declarations.
1413
6d02fe5b
PE
14142012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1415
1416 * alloc.c (Fmemory_free): Account for memory-free's own storage.
1417 Round up, not down. Improve doc.
1418
b7ffe040
DA
14192012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1420
1421 Restore old code in allocate_string_data to avoid Faset breakage.
1422 Reported by Julien Danjou <julien@danjou.info> in
1423 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
1424 * alloc.c (allocate_string_data): Restore old code with minor
1425 adjustments, fix comment to explain this subtle issue.
1426
4dc7c8d5
SM
14272012-07-17 Eli Zaretskii <eliz@gnu.org>
1428
1429 Remove FILE_SYSTEM_CASE.
1430 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
1431
1432 * fileio.c (FILE_SYSTEM_CASE): Don't define.
1433 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
1434 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
1435 call-process-region passes it through expand-file-name.
1436
1437 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
1438
14392012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1440
1441 Fix crash when creating indirect buffer (Bug#11917)
1442 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
1443 Don't handle unbound variables specially if non-zero.
1444 (Fbuffer_local_variables): Pass zero.
1445 (clone_per_buffer_values): Pass non-zero.
1446
14472012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1448
1449 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
1450 to make the loop interruptible.
1451
14522012-07-17 Andreas Schwab <schwab@linux-m68k.org>
1453
1454 * gnutls.c (emacs_gnutls_handshake): Only retry if
1455 GNUTLS_E_INTERRUPTED.
1456
cce7fefc
DA
14572012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1458
1459 Cleanup and convert miscellaneous checks to eassert.
1460 * alloc.c (mark_interval): Fix comment, partially rephrase
1461 old comment from intervals.h (see below).
1462 * intervals.c (find_interval, adjust_intervals_for_insertion)
1463 (delete_interval, adjust_intervals_for_deletion)
1464 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
1465 Convert to eassert.
1466 (adjust_intervals_for_insertion, make_new_interval):
1467 Remove obsolete and unused code.
1468 * intervals.h (struct interval): Remove obsolete comment.
1469 * textprotp.c (erase_properties): Remove unused code.
1470 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
1471 (Fremove_list_of_text_properties): Convert to eassert.
1472
9ea10cc3
CY
14732012-07-17 Chong Yidong <cyd@gnu.org>
1474
1475 * editfns.c (Finsert_char): Doc fix.
1476
3900d5de
DA
14772012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1478
1479 Fix previous change to make Fmemory_free always accurate.
1480 * alloc.c (make_interval): Update total_free_intervals.
1481 (make_float): Likewise for total_free_floats.
1482 (free_cons, Fcons): Likewise for total_free_conses.
1483 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
1484 Likewise for total_free_vector_bytes.
1485 (Fmake_symbol): Likewise for total_free_symbols.
1486 (bytes_free): Remove.
1487
7098646f
DA
14882012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1489
1490 Simple free memory accounting feature.
1491 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
1492 (sweep_vectors): Accumulate size of free vectors.
1493 (Fgarbage_collect): Setup bytes_free.
1494 (Fmemory_free): New function.
1495 (syms_of_alloc): Register it.
1496
22657b40
DA
14972012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
1498
1499 Cleanup overlays checking.
1500 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
1501 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
1502 eassert and OVERLAYP.
1503 (sort_overlays): Change to use OVERLAYP.
1504
ddfc8813
RK
15052012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
1506
1507 * editfns.c (Finsert_char): Make it interactive, and make the
1508 second arg optional. Copy interactive spec and docstring from
1509 ucs-insert.
1510
7c26cf3c
PE
15112012-07-17 Paul Eggert <eggert@cs.ucla.edu>
1512
1513 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
1514 Unlike the other wrapped functions, fabs has an unspecified
1515 effect on errno.
1516
5d127af9
JD
15172012-07-16 Jan Djärv <jan.h.d@swipnet.se>
1518
1519 * nsterm.m (keyDown): Interpret flags without left/right bits
1520 as the left key (Bug#11670).
1521
6a0dd1d7
DA
15222012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1523
1524 Remove empty and useless init functions.
1525 * lisp.h (init_character_once, init_fns, init_image)
1526 (init_filelock, init_sound): Remove prototype.
1527 * character.c (init_character_once): Remove.
1528 * filelock.c (init_filelock): Likewise.
1529 * fns.c (init_fns): Likewise.
1530 * image.c (init_image): Likewise.
1531 * sound.c (init_sound): Likewise.
1532 * emacs.c (main): Adjust accordingly.
1533
7a6136fd
DA
15342012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
1535
1536 * gtkutil.h: Tiny cleanups.
1537 (use_old_gtk_file_dialog): Remove useless declaration.
1538 (xg_uses_old_file_dialog): Add suggested const attribute.
1539
ce811ad9
EZ
15402012-07-15 Eli Zaretskii <eliz@gnu.org>
1541
1542 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
1543 (bidi_paragraph_init): Use it to limit search forward for a strong
1544 directional character in abnormally large paragraphs full of
1545 neutral or weak characters. (Bug#11943)
1546
c9adfeaa
SF
15472012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
1548
1549 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
1550 the toolbar (Bug#9451).
1551 (xg_make_tool_item): Give the widget event box a transparent
1552 background.
1553
fff62aa9
DA
15542012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1555
1556 Cleanup basic allocation variables and functions.
1557 * alloc.c (ignore_warnings, init_intervals, init_float)
1558 (init_cons, init_symbol, init_marker): Remove.
1559 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
1560 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
1561 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
1562 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
1563 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
1564 (staticidx, init_alloc_once, init_strings, free_ablock):
1565 Remove redundant initialization.
1566 * fns.c (init_weak_hash_tables): Remove.
1567 * lisp.h (init_weak_hash_tables): Remove prototype.
1568
9730daca
DA
15692012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
1570
1571 Use zero_vector where appropriate.
1572 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
1573 accordingly.
1574 * lisp.h (zero_vector): New declaration.
1575 * font.c (null_vector): Remove.
1576 (syms_of_font): Remove initialization and staticpro.
1577 (font_list_entities, font_find_for_lface): Change to use zero_vector.
1578 * keymap.c (Faccessible_keymaps): Likewise.
1579
2e2d2a13
LL
15802012-07-15 Leo Liu <sdl.web@gmail.com>
1581
1582 * fringe.c: Fix typo in comments.
1583
cd276f6e
LL
15842012-07-14 Leo Liu <sdl.web@gmail.com>
1585
1586 * fringe.c: Add a new bitmap exclamation-mark.
1587
5a1131d9
EZ
15882012-07-14 Eli Zaretskii <eliz@gnu.org>
1589
1590 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
1591
1592 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
1593 (HAVE_MENUS): Don't define, defined by editing config.in with
1594 msdos/sed2v2.inp.
1595 (GMALLOC_INHIBIT_VALLOC): Don't define.
1596 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
1597
22e983b7
JB
15982012-07-14 Juanma Barranquero <lekktu@gmail.com>
1599
1600 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
1601
5b3f250f
GM
16022012-07-14 Glenn Morris <rgm@gnu.org>
1603
1604 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
1605 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
1606 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
1607
33d63ff4
GM
16082012-07-13 Glenn Morris <rgm@gnu.org>
1609
5b633342
GM
1610 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
1611
33d63ff4
GM
1612 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
1613 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
1614
b55b9f85
JD
16152012-07-13 Jan Djärv <jan.h.d@swipnet.se>
1616
0dc8cf50
JD
1617 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
1618 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
1619 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
1620 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
1621 where appropriate.
1622 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
1623 as boolean expression.
1624 (x_set_window_size): Remove unused variable toolbar.
1625 (ns_get_color_default, ns_mod_to_lisp): Remove.
1626 (ns_mouse_position): Remove unused variables xchar and ychar.
1627 (ns_compute_glyph_string_overhangs): Remove unused variable face.
1628 (ns_set_vertical_scroll_bar): Remove unused variable count.
1629 (ns_delete_terminal): Remove unused variable i.
1630 (ns_term_init): Remove unused variables r, g and b.
1631 (mouseDown): Remove unused variable window.
1632 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
1633 (initFrameFromEmacs): Remove unused variable vbextra.
1634 (mouseEntered): Remove unused variables p and dpyinfo.
1635 (mouseExited): Remove unused variables p and r.
1636 (ns_define_frame_cursor, ns_clear_frame_area)
1637 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
1638 (menuDown): Assign [sender tag] to variable and cast the variable.
1639
1640 * nsterm.h (menuDown): Add id as type to argument sender.
1641 (ns_display_info_for_name): Add Lisp_Object argument.
1642 (ns_term_init): Add Lisp_Object argument.
1643 (ns_map_event_to_object): Add void argument.
1644 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
1645 prototype with arguments and only declare if __OBJC__.
1646 (nxatoms_of_nsselect): Add void argument.
1647 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
1648 (ns_alloc_autorelease_pool): Add void argument.
1649 (ns_release_autorelease_pool): Add void* argument.
1650 (ns_get_defaults_value): Add const char* argument.
1651
1652 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
1653 (initFromContents): Use SSDATA where appropriate.
1654 (ns_update_menubar): Add braces to ambigous if-else.
1655 (initWithTitle): Put () around assignment in if statement.
1656 (ns_menu_show): Remove unused variables window and keymap.
1657 (update_frame_tool_bar): Remove unused variable selected_p.
1658 (initWithContentRect): Remove unused variable this_cmd_name.
1659
1660 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
1661 appropriate.
1662 (setXBMColor): Remove unused variable len.
1663 (setPixmapData): Put () around assignment in loop statement.
1664
1665 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
1666 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
1667 where appropriate.
1668 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
1669 around assignment in loop statement.
1670 (nsfont_open): Remove unused variable i.
1671 (nsfont_open): Remove unused variable len.
1672 (nsfont_draw): Remove unused variable cs.
1673
1674 * nsfns.m (x_set_icon_name, ns_set_name_internal)
1675 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
1676 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
1677 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
1678 (Fns_font_name, Fns_perform_service)
1679 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
1680 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
1681 (ns_set_name): Remove unused variable view.
1682 (x_set_menu_bar_lines): Remove unused variable olines.
1683 (x_set_tool_bar_lines): Remove unused variable root_window.
1684 (Fns_list_colors): Put () around assignment in while statement.
1685 (Fns_perform_service): Remove unused variable len.
1686 (Fns_display_usable_bounds): Remove unused variable top.
1687 (syms_of_nsfns): Remove unused variable i.
1688
b55b9f85
JD
1689 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
1690 memcpy (Bug#11907).
1691
ed9265fc 16922012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
1693
1694 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
1695 and free it with DestroyExceptionInfo (Bug#11558).
1696
ef099b57
JB
16972012-07-13 Juanma Barranquero <lekktu@gmail.com>
1698
1699 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
1700 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
1701 Set here, not in nt/config.nt.
1702
ea814a5d
EZ
17032012-07-13 Eli Zaretskii <eliz@gnu.org>
1704
1705 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
1706 cursor overflow into the last glyph on display line when the right
1707 fringe is off. (Bug#11832)
1708
1a952767
PE
17092012-07-13 Paul Eggert <eggert@cs.ucla.edu>
1710
1711 * xdisp.c (produce_special_glyphs): Now static.
1712 * dispextern.h (produce_special_glyphs): Remove decl.
1713
983188fd
GM
17142012-07-13 Glenn Morris <rgm@gnu.org>
1715
8d7c7eed 1716 * s/bsd-common.h, s/cygwin.h: Remove empty files.
32fb4bb6
GM
1717 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
1718
983188fd
GM
1719 * s/usg5-4-common.h (USG, USG5):
1720 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
1721 * s/sol2-6.h (SOLARIS2):
1722 * s/irix6-5.h (IRIX6_5):
1723 * s/hpux10-20.h (USG, USG5, HPUX):
1724 * s/gnu-linux.h (USG, GNU_LINUX):
1725 * s/freebsd.h (BSD_SYSTEM):
1726 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
1727 * s/cygwin.h (CYGWIN):
1728 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
1729 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
1730
d1e68667 17312012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
1732
1733 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 1734
6de0e799
GM
17352012-07-13 Glenn Morris <rgm@gnu.org>
1736
739ae010
GM
1737 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
1738
dbee5793
GM
1739 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
1740
6de0e799
GM
1741 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
1742 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
1743
b82da769
GM
17442012-07-12 Glenn Morris <rgm@gnu.org>
1745
4fae5a7a 1746 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
1747
1748 * process.c (init_process_emacs): Rename from init_process.
1749 The old name is also the name of a Mach system call.
1750 * lisp.h, emacs.c: Update for this name change.
1751 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
1752 longer needed.
1753
5a979817
EZ
17542012-07-12 Eli Zaretskii <eliz@gnu.org>
1755
1756 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
1757 memmove call that removes glyphs covered by the left truncation
1758 glyph. Improve commentary.
1759 (display_line): Fix display of continuation glyphs on GUI frames
1760 when the right fringe is turned off and variable-size fonts are
1761 used in the window. Move the code that appends a stretch glyph to
1762 produce_special_glyphs, so that it could be used for truncation
1763 and continuation glyphs alike.
1764 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
1765 glyph of a suitably computed width, to align the special glyphs at
1766 the window margin. Code moved from display_line. (Bug#11832)
1767
3e91a053
GM
17682012-07-12 Glenn Morris <rgm@gnu.org>
1769
ba9e4b84
GM
1770 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
1771
1772 * s/gnu-linux.h, s/hpux10-20.h:
1773 Do not unconditionally define HAVE_XRMSETDATABASE.
1774
3e91a053
GM
1775 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
1776
b300b1f4
PE
17772012-07-12 Paul Eggert <eggert@cs.ucla.edu>
1778
1779 Fix typos that broke OS X build.
1780 Reported by Randal L. Schwartz in
1781 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
1782 * nsterm.m (ns_timeout): Add missing local decl.
1783 (ns_get_color): snprintf -> sprintf, to fix typo.
1784
6e777848
GM
17852012-07-12 Glenn Morris <rgm@gnu.org>
1786
3f922c37
GM
1787 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1788 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1789 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1790 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1791
0ab7b23a
GM
1792 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1793 Move PTY_OPEN to configure.
1794
6e777848
GM
1795 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1796 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1797 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1798
4a7edc24
DA
17992012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1800
1801 Use empty_unibyte_string where applicable.
1802 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1803 * lread.c (read1): Likewise.
1804 * xsettings.c (syms_of_xsettings): Likewise.
1805
308aab79
GM
18062012-07-12 Glenn Morris <rgm@gnu.org>
1807
42bd1719
GM
1808 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1809 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1810 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1811 * s/hpux10-20.h (RUN_TIME_REMAP):
1812 * s/bsd-common.h (TABDLY): Move to configure.
1813
1814 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1815
1816 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1817
ea0bbd17 1818 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1819 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1820
1821 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1822
308aab79
GM
1823 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1824 * s/template.h: Move NARROWPROTO to configure.
1825
ee1cf5cf
GM
18262012-07-11 Glenn Morris <rgm@gnu.org>
1827
30fe9bf4
GM
1828 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1829 unused since 2011-01-17 change to systty.h.
1830
ee1cf5cf
GM
1831 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1832 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1833 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1834
63e47e07
PE
18352012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1836
1837 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1838
c43fb4c3
GM
18392012-07-11 Glenn Morris <rgm@gnu.org>
1840
1841 * s/darwin.h, s/gnu-linux.h, s/template.h:
1842 Move INTERRUPT_INPUT to configure.
1843
e8df9267
DA
18442012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1845
1846 Minor adjustments to interning code.
1847 * lisp.h (intern, intern_c_string): Redefine as static inline
1848 wrappers for intern_1 and intern_c_string_1, respectively.
1849 (intern_1, intern_c_string_1): Rename prototypes.
14ae4239
BT
1850 * lread.c (intern_1, intern_c_string_1, oblookup):
1851 Simplify Vobarray checking.
e8df9267
DA
1852 * font.c (font_intern_prop): Likewise. Adjust comment.
1853 * w32font.c (intern_font_name): Likewise.
1854
34348bd4
AS
18552012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1856
d96a1e0c
AS
1857 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1858
34348bd4
AS
1859 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1860 of Fcar/Fcdr if possible.
1861 * font.c (check_otf_features): Likewise.
1862 * fontset.c (Fnew_fontset): Likewise.
1863 * gnutls.c (Fgnutls_boot): Likewise.
1864 * minibuf.c (read_minibuf): Likewise.
1865 * msdos.c (IT_set_frame_parameters): Likewise.
1866 * xmenu.c (Fx_popup_dialog): Likewise.
1867 * w32menu.c (Fx_popup_dialog): Likewise.
1868
c8add24e
GM
18692012-07-11 Glenn Morris <rgm@gnu.org>
1870
4b575b3c
GM
1871 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1872 since nothing has defined it on these platforms.
1873
09f4e3b0
GM
1874 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1875 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1876
172bedef
GM
1877 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1878 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1879 Move CLASH_DETECTION to configure.
1880
249685df
GM
1881 * s/gnu.h: Remove file, which is now empty.
1882
c8add24e
GM
1883 * s/gnu.h, s/gnu-linux.h:
1884 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1885
b41253a3
JW
18862012-07-11 John Wiegley <johnw@newartisans.com>
1887
1888 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1889 function attribute, so we only use it if it exists in the
1890 compiler.
1891
d923b542
DA
18922012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1893
1894 Avoid call to strlen in fast_c_string_match_ignore_case.
1895 * search.c (fast_c_string_match_ignore_case): Change to use
1896 length argument. Adjust users accordingly.
1897 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1898
5ebbef1d
PE
18992012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1900
bb352260
PE
1901 Assume mkdir, rmdir.
1902 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1903 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1904
57054ddd
PE
1905 Assume rename.
1906 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1907
b747d3f7
PE
1908 Assume perror.
1909 * s/hpux10-20.h (HAVE_PERROR): Remove.
1910 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1911 Remove dummy definition, as this problem was obsolete long ago.
1912
5ebbef1d
PE
1913 Assume strerror.
1914 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1915
984e7f30
DA
19162012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1917
1918 Avoid calls to strlen in font processing functions.
1919 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
14ae4239
BT
1920 (font_open_by_name): Change to use length argument.
1921 Adjust users accordingly.
d923b542
DA
1922 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1923 Adjust prototypes.
1924 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1925 Change to return ptrdiff_t.
984e7f30
DA
1926 (xfont_list_pattern, xfont_match): Use length returned by
1927 xfont_decode_coding_xlfd.
1928 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1929
20e94fdd
GM
19302012-07-11 Glenn Morris <rgm@gnu.org>
1931
9d596af3
GM
1932 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1933 Move DONT_REOPEN_PTY to configure.
1934
20e94fdd
GM
1935 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1936 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1937
e99a530f
PE
19382012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1939
22ffb973
PE
1940 Remove "#define unix" that is no longer needed (Bug#11905).
1941 * s/aix4-2.h (unix): Remove; no longer needed.
1942
e9a9ae03
PE
1943 EMACS_TIME simplification (Bug#11875).
1944 This replaces macros (which typically do not work in GDB)
1945 with functions, typedefs and enums, making the code easier to debug.
1946 The functional style also makes code easier to read and maintain.
1947 * systime.h: Include <sys/time.h> on all hosts, not just if
1948 WINDOWSNT, since 'struct timeval' is needed in general.
1949 (EMACS_TIME): Now a typedef, not a macro.
1950 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1951 not macros.
1952 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1953 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1954 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1955 (EMACS_TIME_LE): Now functions, not macros.
1956 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1957 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1958 which are not functions. All uses rewritten to use:
1959 (make_emacs_time): New function.
1960 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1961 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1962 not functions. All uses rewritten to use the following, respectively:
1963 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1964 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1965 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1966 * fileio.c (Fcopy_file):
1967 * xterm.c (XTflash): Get the current time closer to when it's used.
1968 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1969
ffacb126
PE
1970 * bytecode.c (targets): Suppress -Woverride-init warnings.
1971
e99a530f
PE
1972 Simplify by avoiding confusing use of strncpy etc.
1973 * doc.c (Fsnarf_documentation):
1974 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1975 * frame.c (Fmake_terminal_frame):
1976 * gtkutil.c (get_utf8_string):
1977 * lread.c (openp):
1978 * nsmenu.m (ns_update_menubar):
1979 * regex.c (regerror):
1980 Prefer memcpy to strncpy and strncat when either will do.
1981 * fileio.c (Fsubstitute_in_file_name):
1982 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1983 (menu_separator_name_p):
1984 * nsmenu.m (ns_update_menubar):
1985 Prefer memcmp to strncmp when either will do.
1986 * nsterm.m: Include <ftoastr.h>.
1987 (ns_get_color):
1988 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1989 Prefer snprintf to strncpy.
1990 * nsterm.m (ns_term_init):
1991 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1992 * nsterm.m (ns_term_init):
1993 Avoid the need for strncpy, by using build_string or
1994 make_unibyte_string directly. Use dtoastr, not snprintf.
1995 * process.c (Fmake_network_process): Diagnose service names that
1996 are too long, rather than silently truncating them or creating
1997 non-null-terminated names.
1998 (Fnetwork_interface_info): Likewise, for interface names.
1999 * sysdep.c (system_process_attributes) [GNU_LINUX]:
2000 Prefer sprintf to strncat.
2001 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
2002 Prefer vsnprintf to vsprintf + strncpy.
2003
c59592b3
GM
20042012-07-10 Glenn Morris <rgm@gnu.org>
2005
2006 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
2007 Clarify fallback case.
2008
7d7bbefd
DA
20092012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2010
2011 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
2012 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
2013 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 2014 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
2015 where argument type is known to be a Lisp_Cons.
2016
3a4c8000
TT
20172012-07-10 Tom Tromey <tromey@redhat.com>
2018
2019 * bytecode.c (BYTE_CODE_THREADED): New macro.
2020 (BYTE_CODES): New macro. Replaces all old byte-code defines.
2021 (enum byte_code_op): New type.
2022 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
2023 (exec_byte_code): Use them. Use token threading when applicable.
2024
2a0213a6
DA
20252012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2026
2027 Optimize pure C strings initialization.
2028 * lisp.h (make_pure_string): Fix prototype.
2029 (build_pure_c_string): New function, defined as static inline. This
2030 provides a better opportunity to optimize away calls to strlen when
2031 the function is called with compile-time constant argument.
2032 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
2033 argument, adjust users accordingly. Use build_pure_c_string where
2034 appropriate.
2035 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
2036 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
2037 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
2038
cb1caeaf
DA
20392012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2040
2041 Avoid calls to strlen in miscellaneous functions.
2042 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
2043 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
2044 * lread.c (openp): Likewise.
2045
c293e30c
DA
20462012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
2047
2048 Avoid calls to strlen in path processing functions.
2049 * fileio.c (file_name_as_directory): Add comment. Change to add
2050 srclen argument and return the length of result. Adjust users
2051 accordingly.
2052 (directory_file_name): Fix comment. Change to add srclen argument,
14ae4239
BT
2053 swap 1st and 2nd arguments to obey the common convention.
2054 Adjust users accordingly.
c293e30c
DA
2055 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
2056
9e059e3f
GM
20572012-07-10 Glenn Morris <rgm@gnu.org>
2058
d02eb359
GM
2059 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
2060 Move PENDING_OUTPUT_COUNT definition to configure.
2061
882cf227
GM
2062 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
2063 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
2064 * s/gnu.h (DATA_START): Move definitions to configure.
2065
af6e839f
GM
2066 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
2067 We include usg5-4-common.h, which defines them both.
2068
40289a12
GM
2069 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
2070 O_RDONLY already includes it).
2071
9e059e3f
GM
2072 Stop ns builds setting the EMACSLOADPATH environment variable.
2073 * nsterm.m (ns_load_path): Rename from ns_init_paths.
2074 Now it does not set EMACSLOADPATH, just returns the load-path string.
2075 * nsterm.h: Update accordingly.
2076 * lread.c [HAVE_NS]: Include nsterm.h.
2077 (init_lread) [HAVE_NS]: Use ns_load_path.
2078 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
2079
7c4e8ec0
GM
20802012-07-09 Glenn Morris <rgm@gnu.org>
2081
d4f600ff
GM
2082 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
2083 since the included bsd-common.h does so.
2084
cbb31951
GM
2085 Stop ns builds setting the EMACSPATH environment variable.
2086 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
2087 (ns_init_paths): Do not set EMACSPATH.
2088 * nsterm.h (ns_exec_path): Add it.
2089 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
2090 Use ns_exec_path.
2091
7c4e8ec0
GM
2092 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
2093
26bccfae
PE
20942012-07-09 Paul Eggert <eggert@cs.ucla.edu>
2095
a0bee46f
PE
2096 * process.c (wait_reading_process_output): 'waitchannels' was unset
2097 when read_kbd || !NILP (wait_for_cell); fix this.
2098
5994c183
PE
2099 Add GCC-style 'const' attribute to functions that can use it.
2100 * character.h (char_resolve_modifier_mask):
2101 * keyboard.h (make_ctrl_char):
2102 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
2103 (init_character_once, next_almost_prime, init_fns, init_image)
2104 (flush_pending_output, init_sound):
2105 * mem-limits.h (start_of_data):
2106 * menu.h (finish_menu_items):
2107 Add ATTRIBUTE_CONST.
2108 * emacs.c (DEFINE_DUMMY_FUNCTION):
2109 Declare the dummy function with ATTRIBUTE_CONST.
2110 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
2111 Add decls with ATTRIBUTE_CONST.
2112
26bccfae
PE
2113 Minor improvements to make_formatted_string.
2114 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
2115 where int is good enough, as vsprintf returns an int.
2116 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
2117
a8290ec3
DA
21182012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2119
2120 Use make_formatted_string to avoid double length calculation.
2121 * lisp.h (make_formatted_string): New prototype.
2122 * alloc.c (make_formatted_string): New function.
2123 * buffer.c (Fgenerate_new_buffer_name): Use it.
2124 * dbus.c (syms_of_dbusbind): Likewise.
2125 * editfns.c (Fcurrent_time_zone): Likewise.
2126 * filelock.c (get_boot_time): Likewise.
2127 * frame.c (make_terminal_frame, set_term_frame_name)
2128 (x_report_frame_params): Likewise.
2129 * image.c (gs_load): Likewise.
2130 * minibuf.c (get_minibuffer): Likewise.
2131 * msdos.c (dos_set_window_size): Likewise.
2132 * process.c (make_process): Likewise.
2133 * xdisp.c (ensure_echo_area_buffers): Likewise.
2134 * xsettings.c (apply_xft_settings): Likewise.
2135
d01ba2f1
GM
21362012-07-09 Glenn Morris <rgm@gnu.org>
2137
2138 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
2139 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
2140 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
2141 * nsterm.h (ns_etc_directory): Add it.
2142 * callproc.c [HAVE_NS]: Include nsterm.h.
2143 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
2144
f1f924b6
DA
21452012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
2146
2147 Move marker debugging code under MARKER_DEBUG.
2148 * marker.c (MARKER_DEBUG): Move marker debugging code under
2149 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
2150 for bootstrap with --enable-checking (~3x slowdown reported
2151 by Juanma Barranquero <lekktu@gmail.com>).
2152 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
2153
ab531b66
PE
21542012-07-08 Paul Eggert <eggert@cs.ucla.edu>
2155
2156 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
2157 See <http://bugs.gnu.org/11825#29>.
2158
c4b3bc8a
EZ
21592012-07-08 Eli Zaretskii <eliz@gnu.org>
2160
2161 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
2162 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
2163 (display_line): Add commentary about displaying truncation glyphs
2164 on GUI frames.
2165 (produce_special_glyphs): Move here from term.c.
2166
2167 * term.c (produce_special_glyphs): Move to xdisp.c.
2168
2169 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
2170 section.
c4b3bc8a 2171
b676b881
AS
21722012-07-07 Andreas Schwab <schwab@linux-m68k.org>
2173
f17c5273
AS
2174 * xdisp.c (display_line): Avoid warning about implicit declaration
2175 of FRAME_FONT.
2176
298819b9
AS
2177 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
2178
b676b881
AS
2179 * lisp.h: Remove empty conditional.
2180
6045c4fd
PE
21812012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2182
b3350bf9
PE
2183 * lread.c (load_path_check): Now static.
2184
6045c4fd
PE
2185 Fix some minor --with-ns problems found by static checking.
2186 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
2187 (x_set_font) [!HAVE_X_WINDOWS]:
2188 * image.c (xpm_load_image) [HAVE_NS]:
2189 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
2190 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
2191 Remove unused local.
2192 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
2193 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
2194 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
2195 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
2196 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
2197 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
2198 Fix pointer signedness problem.
2199 * xfaces.c (FRAME_X_FONT_TABLE):
2200 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
2201
929e7845
GM
22022012-07-07 Glenn Morris <rgm@gnu.org>
2203
2204 * lread.c (load_path_check): New function, split from init_lread.
2205 (init_lread): Reorganize. Motivation:
2206 If EMACSLOADPATH is set, check/warn about that rather than the
2207 defaults, which we are not going to use. Hence we can remove
2208 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
2209 Don't warn if site-lisp directories are missing.
2210 If not installed, start from a blank load-path, since
2211 PATH_LOADSEARCH refers to the eventual installation directories.
2212
58dd0aa4
EZ
22132012-07-07 Eli Zaretskii <eliz@gnu.org>
2214
2215 Support truncation and continuation glyphs on GUI frames, when
2216 fringes are disabled. (Bug#11832)
2217 * xdisp.c (init_iterator): Get dimensions of truncation and
14ae4239
BT
2218 continuation glyphs even if on GUI frames.
2219 Adjust it->last_visible_x on GUI frames when the left or right fringes,
58dd0aa4
EZ
2220 or both, are absent.
2221 (start_display, move_it_in_display_line_to): Handle the case of a
2222 GUI frame without a fringe to display continuation or truncation
2223 glyphs.
2224 (insert_left_trunc_glyphs): Support GUI frames: make sure
2225 truncation glyphs overwrite enough glyphs from the current line to
2226 have sufficient space in pixels.
2227 (display_line): Support truncation and continuation glyphs on GUI
2228 frames. If some spare pixels are left on the line after inserting
2229 the truncation glyphs, fill that space with a stretch glyph of a
2230 suitably computed width.
2231
2232 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
2233 produce_glyphs, to support GUI sessions.
2234
31571fd7
PE
22352012-07-07 Paul Eggert <eggert@cs.ucla.edu>
2236
5a16b9bc
PE
2237 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
2238
f3047c75
PE
2239 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
2240
31571fd7
PE
2241 Do not require float-time's arg to fit in time_t (Bug#11825).
2242 This works better on hosts where time_t is unsigned, and where
2243 float-time is applied to the (negative) difference between two times.
2244 * editfns.c (decode_time_components): Last arg is now double *,
2245 not int *, and means to store all the result as a double, without
2246 worrying about whether the seconds part fits in time_t.
2247 All callers changed.
2248 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
2249 All callers changed.
2250 (Ffloat_time): Do not fail merely because the specified time falls
2251 outside of time_t range.
2252
4516fbef
GM
22532012-07-07 Glenn Morris <rgm@gnu.org>
2254
2255 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
2256 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
2257 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
2258
07adc2c6
JB
22592012-07-07 Juanma Barranquero <lekktu@gmail.com>
2260
2261 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
2262 Update dependencies.
2263
2264 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
2265
fd573f31
PE
22662012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2267
fee5959d
PE
2268 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
2269 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
2270 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
2271 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
2272 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
2273 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
2274
fd573f31
PE
2275 * xfont.c (compare_font_names): Redo to omit the need for casts.
2276
ddadbc0e
AS
22772012-07-06 Andreas Schwab <schwab@linux-m68k.org>
2278
fca8d6b6
AS
2279 * xfns.c (Fx_change_window_property): Doc fix.
2280 * w32fns.c (Fx_change_window_property): Doc fix.
2281
ddadbc0e
AS
2282 * w32fns.c (Fx_window_property): Accept the same arguments as the
2283 X Windows version. Doc fix.
2284 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
2285
ed9265fc 22862012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
2287 Eli Zaretskii <eliz@gnu.org>
2288
2289 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
2290 Windows-specific code from nt/config.nt moved here.
2291 Obsolete settings removed.
2292
216ee680
PE
22932012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 * process.c: Avoid unnecessary calls to gettime.
2296 (wait_reading_process_output): Don't get the time of day
2297 when gobbling data immediately and not waiting, as there's no need
2298 for it in that case. This removes a FIXME.
2299
bdd091e4
JD
23002012-07-06 Jan Djärv <jan.h.d@swipnet.se>
2301
2302 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
2303 is defined (Bug#11768).
2304
9d44f8ce
DA
23052012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2306
2307 Fix marker debugging code.
2308 * marker.c (byte_char_debug_check): Do not perform the check
2309 if buffer is not multibyte.
090bd7cb
JB
2310 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2311 Call byte_char_debug_check with correct arguments.
9d44f8ce 2312
90fc4786
DA
23132012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2314
2315 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
2316 * marker.c (byte_char_debug_check, count_markers):
2317 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
2318 (byte_debug_flag): Remove.
2319 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
2320 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
2321
7b7ae965
DA
23222012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2323
4e57b342
DA
2324 Avoid code repetition in marker-related functions.
2325 * marker.c (attach_marker): New function.
2326 (Fset_marker, set_marker_restricted, set_marker_both)
2327 (set_marker_restricted_both): Use it.
2328 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
2329 Consistently rename charno to charpos.
2330 (marker_position): Add eassert.
2331 (marker_byte_position): Convert to eassert.
2332
23332012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2334
2335 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 2336 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 2337 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 2338
657924ff
DA
23392012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2340
2341 Introduce fast path for the widely used marker operation.
2342 * alloc.c (build_marker): New function.
2343 * lisp.h (build_marker): New prototype.
2344 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
2345 * composite.c (autocmp_chars): Likewise.
2346 * editfns.c (buildmark): Remove.
2347 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
2348 (save_restriction_save): Use build_marker.
2349 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
2350 * window.c (save_window_save): Likewise.
2351
041a49a6
DA
23522012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
2353
2354 Do not use Fdelete_overlay in delete_all_overlays
2355 to avoid redundant calls to unchain_overlay.
2356 * buffer.c (drop_overlay): New function.
2357 (delete_all_overlays, Fdelete_overlay): Use it.
2358 * minibuf.c (get_minibuffer): Fix comment.
2359
7dca65a4
PE
23602012-07-06 Paul Eggert <eggert@cs.ucla.edu>
2361
2362 Port to OpenBSD 5.1 amd64.
2363 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
2364 This is needed for OpenBSD, and should be harmless on all BSD systems.
2365 Also, include <sys/sysctl.h>, as it should be available on all
2366 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
2367 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
2368 use p_pid member, not kp_proc.pid.
2369
8eb876e2
GM
23702012-07-06 Glenn Morris <rgm@gnu.org>
2371
2372 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
2373
38182d90
PE
23742012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 More xmalloc and related cleanup.
2377 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
2378 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
2379 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
2380 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
2381 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
2382 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
2383 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
2384 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
2385 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
2386 * xterm.c:
2387 Omit needless casts involving void * pointers and allocation.
2388 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
2389 as the former is more robust if P's type is changed.
2390 Prefer xzalloc to xmalloc + memset 0.
2391 Simplify malloc-or-realloc to realloc.
2392 Don't worry about xmalloc returning a null pointer.
2393 Prefer xstrdup to xmalloc + strcpy.
2394 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
2395 growing it.
2396 * keyboard.c (apply_modifiers_uncached): Prefer local array to
2397 alloca of a constant.
2398
6dd5a677
EZ
23992012-07-05 Eli Zaretskii <eliz@gnu.org>
2400
2401 * xdisp.c (display_line): Fix horizontal pixel coordinates when
2402 hscroll is larger than the line width. Fixes long and futile
2403 looping inside extend_face_to_end_of_line (on a TTY) producing
2404 glyphs that are not needed and thrown away.
2405
6b312f0f
DA
24062012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2407
2408 * marker.c (set_marker_restricted_both): Simplify by using
2409 clip_to_bounds.
2410
f520ef9b
PE
24112012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2412
2413 * editfns.c (region_limit): Simplify by using clip_to_bounds.
2414
383b7c95
JD
24152012-07-05 Jan Djärv <jan.h.d@swipnet.se>
2416
2417 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
2418 not defined (Bug#11768).
2419 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
2420 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
2421 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
2422 followed by gtk_box_set_homogeneous (Bug#11768).
2423 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
2424 (update_theme_scrollbar_width, xg_create_scroll_bar):
2425 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
2426 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
2427 (is_box_type): New function (Bug#11768).
2428 (xg_tool_item_stale_p): Call is_box_type.
5293d758 2429 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
2430 with default display (Bug#11768).
2431
d6e7bf45
EZ
24322012-07-05 Eli Zaretskii <eliz@gnu.org>
2433
2434 * xdisp.c (window_hscroll_limited): New function.
2435 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
2436 coordinates when window's hscroll is set to insanely large
2437 values. (Bug#11857)
2438
431391ec
JB
24392012-07-05 Juanma Barranquero <lekktu@gmail.com>
2440
2441 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
2442 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
2443
23f86fce
DA
24442012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
2445
2446 Cleanup xmalloc.
2447 * lisp.h (xzalloc): New prototype. Omit needless casts.
2448 * alloc.c (xzalloc): New function. Omit needless casts.
2449 * charset.c: Omit needless casts. Convert all calls to
2450 xmalloc with following memset to xzalloc.
2451 * dispnew.c: Likewise.
2452 * fringe.c: Likewise.
2453 * image.c: Likewise.
2454 * sound.c: Likewise.
2455 * term.c: Likewise.
2456 * w32fns.c: Likewise.
2457 * w32font.c: Likewise.
2458 * w32term.c: Likewise.
2459 * xfaces.c: Likewise.
2460 * xfns.c: Likewise.
2461 * xterm.c: Likewise.
2462 * atimer.c: Omit needless casts.
2463 * buffer.c: Likewise.
2464 * callproc.c: Likewise.
2465 * ccl.c: Likewise.
2466 * coding.c: Likewise.
2467 * composite.c: Likewise.
2468 * doc.c: Likewise.
2469 * doprnt.c: Likewise.
2470 * editfns.c: Likewise.
2471 * emacs.c: Likewise.
2472 * eval.c: Likewise.
2473 * filelock.c: Likewise.
2474 * fns.c: Likewise.
2475 * gtkutil.c: Likewise.
2476 * keyboard.c: Likewise.
2477 * lisp.h: Likewise.
2478 * lread.c: Likewise.
2479 * minibuf.c: Likewise.
2480 * msdos.c: Likewise.
2481 * print.c: Likewise.
2482 * process.c: Likewise.
2483 * region-cache.c: Likewise.
2484 * search.c: Likewise.
2485 * sysdep.c: Likewise.
2486 * termcap.c: Likewise.
2487 * terminal.c: Likewise.
2488 * tparam.c: Likewise.
2489 * w16select.c: Likewise.
2490 * w32.c: Likewise.
2491 * w32reg.c: Likewise.
2492 * w32select.c: Likewise.
2493 * w32uniscribe.c: Likewise.
2494 * widget.c: Likewise.
2495 * xdisp.c: Likewise.
2496 * xmenu.c: Likewise.
2497 * xrdb.c: Likewise.
2498 * xselect.c: Likewise.
2499
0497dc44
PE
25002012-07-05 Paul Eggert <eggert@cs.ucla.edu>
2501
2502 * fileio.c (time_error_value): Check the right error number.
2503 Problem reported by Troels Nielsen in
2504 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
2505
356e7178
PE
25062012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2507
4e71fd89
PE
2508 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
2509 This should be fixed in a better way; see Eli Zaretskii in
2510 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
2511 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
2512
f0941253
PE
2513 * fileio.c (time_error_value): Rename from special_mtime.
2514 The old name's problems were noted by Eli Zaretskii in
2515 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
2516
065c9eb4
PE
2517 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
2518 This variable's comment says Emacs needs at least one GDB-visible
2519 symbol of type enum pvec_type, to work around GDB problems.
2520 The symbol's value doesn't matter.
2521
356e7178
PE
2522 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
2523 that causes compilation to fail on pre-C99 compilers.
2524
ed9265fc 25252012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
2526
2527 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
2528 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
2529
3884d954
DA
25302012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2531
d209e2fb 2532 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
2533 headers for buffer_defaults and buffer_local_symbols.
2534 Reported by Juanma Barranquero <lekktu@gmail.com>.
2535
ee28be33
SM
25362012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2537
2538 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
2539 * lisp.h (enum pvec_type): Use fewer bits.
2540 (PSEUDOVECTOR_SIZE_BITS): New constant.
2541 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
2542 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
2543 change in pvec_type.
2544 (PSEUDOVECTOR_TYPEP): New macro.
2545 (TYPED_PSEUDOVECTORP): Use it.
2546 * fns.c (internal_equal): Adapt code to extract pvectype.
2547 * emacs.c (gdb_pvec_type): Update type.
2548 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
2549 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
2550 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
2551 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
2552 (sweep_vectors): Use it. Use local var `total_bytes' instead of
2553 abusing vector->header.next.nbytes.
2554 (live_vector_p): Use PVEC_TYPE.
2555 (mark_object): Adapt code to extract pvectype. Use switch.
2556
c7f2cd7f
PE
25572012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2558
2559 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
2560 Tighten new eassert a bit.
2561
8ce70ed2
DA
25622012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2563
2564 Fix compilation with --enable-gcc-warnings and -O1
2565 optimization level.
2566 * doprnt.c (doprnt): Change type of tem to int, initialize
2567 to avoid compiler warning. Add eassert.
2568 * search.c (simple_search): Initialize match_byte to avoid
2569 compiler warning. Add eassert.
2570
dea7f1e5
PE
25712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2572
24a212eb
PE
2573 Avoid weird behavior with large horizontal scrolls.
2574 Without this change, for example, large hscroll values would
2575 mess up Emacs's display on Fedora 15 x86, presumably due to
2576 overflows in int calculations in the display code.
2577 Also, if buffers had long lines, Emacs would freeze.
2578 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
2579 (set_window_hscroll): New function, containing the old guts of
2580 Fset_window_hscroll. Return the clipped value.
2581 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
2582 This avoids the need to check against PTRDIFF_MAX.
2583
dea7f1e5
PE
2584 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
2585
76046526
DA
25862012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
2587
2588 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
2589
39adff0d
PE
25902012-07-04 Paul Eggert <eggert@cs.ucla.edu>
2591
63807d47
PE
2592 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
2593 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
2594 since GCC 4.4.6 issues a bogus warning for them.
2595
39adff0d
PE
2596 Fix bugs in file timestamp newness comparisons.
2597 * fileio.c (Ffile_newer_than_file_p):
2598 * lread.c (Fload): Use full timestamp resolution of files,
2599 not just the 1-second resolution, so that files that are only
2600 slightly newer still count as newer.
2601 * fileio.c (Ffile_newer_than_file_p): Don't assume file
2602 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
2603
dbeed9a6
PE
26042012-07-03 Paul Eggert <eggert@cs.ucla.edu>
2605
2606 * fileio.c: Improve handling of file time marker. (Bug#11852)
2607 (special_mtime): New function.
2608 (Finsert_file_contents, Fverify_visited_file_modtime):
2609 Use it to set special mtime values consistently.
2610
636334d6
AS
26112012-07-03 Andreas Schwab <schwab@linux-m68k.org>
2612
2613 * fileio.c (Finsert_file_contents): Properly handle st_mtime
2614 marker for non-existing file. (Bug#11852)
2615
e2017fe2
GM
26162012-07-03 Glenn Morris <rgm@gnu.org>
2617
2618 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
2619 and did not make it into globals.h).
2620
404dbd37
TT
26212012-07-03 Tom Tromey <tromey@redhat.com>
2622
2623 * window.c (Fset_window_margins, Fset_window_fringes)
2624 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
2625 * textprop.c (Fprevious_property_change): No longer static.
2626 * syntax.c (Fsyntax_table_p): No longer static.
2627 * process.c (Fget_process, Fprocess_datagram_address): No longer
2628 static.
2629 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
2630 * keyboard.c (Fcommand_execute): No longer static.
2631 Remove EXFUN.
2632 * insdel.c (Fcombine_after_change_execute): No longer static.
2633 * image.c (Finit_image_library): No longer static.
2634 * fileio.c (Fmake_symbolic_link): No longer static.
2635 * eval.c (Ffetch_bytecode): No longer static.
2636 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
2637 * doc.c (Fdocumentation_property, Fsnarf_documentation):
2638 No longer static.
404dbd37
TT
2639 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
2640 static.
2641 * dired.c (Ffile_attributes): No longer static.
2642 * composite.c (Fcomposition_get_gstring): No longer static.
2643 * callproc.c (Fgetenv_internal): No longer static.
2644
2645 * ccl.h: Remove EXFUNs.
2646 * buffer.h: Remove EXFUNs.
2647 * dispextern.h: Remove EXFUNs.
2648 * intervals.h: Remove EXFUNs.
2649 * fontset.h: Remove EXFUN.
2650 * font.h: Remove EXFUNs.
2651 * dosfns.c (system_process_attributes): Remove EXFUN.
2652 * keymap.h: Remove EXFUNs.
2653 * lisp.h: Remove EXFUNs.
2654 * w32term.h: Remove EXFUNs.
2655 * window.h: Remove EXFUNs.
2656 * xsettings.h: Remove EXFUN.
2657 * xterm.h: Remove EXFUN.
2658
8e4fd1e1
GM
26592012-07-03 Glenn Morris <rgm@gnu.org>
2660
2661 * lisp.h (Frandom): Make it visible to C.
2662 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
2663 buffer for invisible buffers. (Bug#1229)
2664
ca95b3eb
DA
26652012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2666
2667 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
2668 values which aren't power of 2.
14ae4239
BT
2669 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro.
2670 Verify it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
ca95b3eb
DA
2671 accordingly.
2672
7555c33f
SM
26732012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
2674
2675 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
2676
2677 * alloc.c (mark_object): Revert part of last patch to use `switch'.
2678
d12e8f5a
DA
26792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2680
2681 * alloc.c (allocate_vector_block): Remove redundant
2682 calls to mallopt if DOUG_LEA_MALLOC is defined.
2683 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
2684 avoid calls to mallopt if zero_vector is returned.
2685
296094c3
DA
26862012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2687
2688 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
2689 is enabled, avoid dereferencing NULL current_sblock if
2690 running undumped.
2691
36429c89
DA
26922012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
2693
2694 Cleanup basic buffer management.
2695 * buffer.h (struct buffer): Change layout to use generic vector
2696 marking code. Fix some comments. Change type of 'clip_changed'
2697 to bitfield. Remove unused #ifndef old.
2698 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
2699 (GET_OVERLAYS_AT): Fix indentation.
2700 (for_each_per_buffer_object_at): New macro.
2701 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
2702 (Fbuffer_local_variables): Use it.
2703 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
2704 * alloc.c (allocate_buffer): Adjust to match new layout of
2705 struct buffer. Fix comment.
2706 (mark_overlay): New function.
2707 (mark_buffer): Use it. Use mark_vectorlike to mark normal
2708 Lisp area of struct buffer.
2709 (mark_object): Use it. Adjust marking of misc objects
2710 and related comments.
2711
3b3e4cac
PE
27122012-07-02 Paul Eggert <eggert@cs.ucla.edu>
2713
2714 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
2715 wrapper that is not needed because the wrapped code is a no-op (zero
2716 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
2717 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
2718
cf5c0175
DA
27192012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
2720
2721 * alloc.c (mark_buffer): Simplify. Remove prototype.
2722 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 2723 objects. Use CHECK_LIVE for all vector-like objects except buffers
14ae4239
BT
2724 and subroutines when GC_CHECK_MARKED_OBJECTS is defined.
2725 Avoid redundant calls to mark_vectorlike for bool vectors.
cf5c0175 2726
ca26824c
GM
27272012-06-30 Glenn Morris <rgm@gnu.org>
2728
2e4c5312
GM
2729 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
2730
ca26824c
GM
2731 * epaths.in (PATH_SITELOADSEARCH): New.
2732 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
2733 This is rather than relying on --enable-locallisppath elements
2734 having "site-lisp" in their names. (Bug#10208#25, 11658)
2735
0d23c240
EZ
27362012-06-30 Eli Zaretskii <eliz@gnu.org>
2737
c9240d7a
EZ
2738 * w32proc.c (sys_select): Accept and ignore one more argument.
2739
2740 * w32.c (emacs_gnutls_pull): Call select with one more argument.
2741
0d23c240 2742 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 2743 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
2744
2745 * sysdep.c: Don't include dos.h and dosfns.h.
2746
2747 * process.c (sys_select):
2748 * msdos.c (sys_select): Accept one more argument and ignore it.
2749
2750 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
2751 adapt data types and code to that.
2752
2753 * dosfns.c:
2754 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
2755 which clashes with the gnulib function of the same name.
2756
af5a5a98
AS
27572012-06-30 Andreas Schwab <schwab@linux-m68k.org>
2758
c5e4379c
AS
2759 * font.c (font_style_to_value, font_style_symbolic)
2760 (font_prop_validate_style): Add type checks for values in
2761 font_style_table.
2762
af5a5a98
AS
2763 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
2764 argument.
2765 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
2766 uses.
2767
8d38f461
EZ
27682012-06-29 Eli Zaretskii <eliz@gnu.org>
2769
2e5a6631
EZ
2770 * xdisp.c (try_window_id): Undo last change.
2771
8d38f461
EZ
2772 * w32.c (getwd): Adjust commentary about startup_dir.
2773 (init_environment): Always call sys_access, even in non-MSVC
2774 builds. Don't chdir to the directory of the Emacs executable.
2775 This undoes code from 1997 which was justified by the need to
2776 "avoid conflicts when removing and renaming directories". But its
2777 downside was that every relative file name was being interpreted
2778 relative to the directory of the Emacs executable, which can never
2779 be TRT. In particular, it broke sys_access when called with
2780 relative file names.
2781 (sys_access): Map GetLastError to errno.
2782
2af3565e
DA
27832012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2784
2785 * window.h (struct window): Change type of 'fringes_outside_margins'
2786 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2787 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2788 Adjust comment.
2789 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2790 to ptrdiff_t.
2791
c8d3a25c 27922012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2793
c8d3a25c
GM
2794 * gnutls.c (emacs_gnutls_handshake):
2795 Add QUIT to make the loop interruptible.
57570cd3 2796
c8d3a25c 27972012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2798
c8d3a25c
GM
2799 * charset.c (init_charset): Make lack of etc/charsets fatal.
2800
3e984ee8
DA
28012012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2802
2803 * editfns.c (region_limit): Fix type mismatch.
2804
ef884f23
DA
28052012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2806
2807 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2808 undefined. Convert from xassert to eassert.
2809 * nsmenu.m: Convert from xassert to eassert.
2810 * nsterm.m: Likewise.
2811
7d7e0027
SM
28122012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2813
2814 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2815
aa754e6a
PE
28162012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2817
2818 Avoid integer overflow on scroll-left and scroll-right.
2819 * window.c (HSCROLL_MAX): New macro.
2820 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2821 overflow when requested scroll falls outside ptrdiff_t range.
2822
80b00b08
DA
28232012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2824
2825 * window.h (struct window): Change type of 'hscroll',
2826 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2827 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2828 Adjust users accordingly.
2829 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2830 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2831 from EMACS_INT to ptrdiff_t.
2832 (make_window): Omit redundant initialization.
2833
62b2bcf6
JB
28342012-06-28 Juanma Barranquero <lekktu@gmail.com>
2835
2836 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2837
45942c7d
DA
28382012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2839
2840 * window.h (struct window): Change type of 'use_time' and
2841 'sequence_number' from Lisp_Object to int.
2842 * frame.c (make_frame): Adjust users accordingly.
2843 * print.c (print_object): Likewise.
2844 * window.c (select_window, Fwindow_use_time, make_parent_window)
2845 (make_window): Likewise.
2846
e509cfa6
DA
28472012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2848
2849 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2850 enabled with --enable-checking=[all,glyphs] configure option.
2851 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2852 adjust comments accordingly.
2853 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2854 undefined, adjust comments accordingly.
2855 * image.c: Likewise.
2856 * scroll.c: Likewise.
2857 * w32fns.c: Likewise.
2858 * w32term.c: Likewise.
2859 * xdisp.c: Likewise.
2860 * xfaces.c: Likewise.
2861 * xfns.c: Likewise.
2862 * xterm.c: Likewise.
2863
a54e2c05
DA
28642012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2865
2866 Generalize run-time debugging checks.
2867 * dispextern.h (XASSERTS): Remove.
2868 * fontset.c (xassert): Remove.
2869 Convert from xassert to eassert.
2870 * alloc.c: Convert from xassert to eassert.
2871 * bidi.c: Likewise.
2872 * dispnew.c: Likewise.
2873 * fns.c: Likewise.
2874 * fringe.c: Likewise.
2875 * ftfont.c: Likewise.
2876 * gtkutil.c: Likewise.
2877 * image.c: Likewise.
2878 * keyboard.c: Likewise.
2879 * menu.c: Likewise.
2880 * process.c: Likewise.
2881 * scroll.c: Likewise.
2882 * sound.c: Likewise.
2883 * term.c: Likewise.
2884 * w32console.c: Likewise.
2885 * w32fns.c: Likewise.
2886 * w32term.c: Likewise.
2887 * window.c: Likewise.
2888 * xdisp.c: Likewise.
2889 * xfaces.c: Likewise.
2890 * xfns.c: Likewise.
2891 * xselect.c: Likewise.
2892 * xterm.c: Likewise.
2893
1ec4b7b2
SM
28942012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2895
2896 * fns.c (maybe_resize_hash_table): Output message when growing the
2897 purify-hashtable.
2898
2014308a
DA
28992012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2900
2901 * alloc.c (allocate_string_data): Remove dead code.
2902 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2903 avoid GCC warning about unused macro.
2904
246155eb
DA
29052012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2906
2907 * alloc.c (allocate_string): Omit intervals initialization.
2908 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2909 as in make_pure_string and make_pure_c_string.
2910
43184b7b
DA
29112012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2912
d209e2fb 2913 * alloc.c (allocate_string): Fix last change.
43184b7b 2914
3fe6dd74
DA
29152012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2916
d209e2fb 2917 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2918 to memset, add explicit initialization where appropriate.
2919
1ba6038a
GM
29202012-06-27 Glenn Morris <rgm@gnu.org>
2921
2922 * lisp.mk (lisp): Remove paths.elc.
2923
c89926a5
CY
29242012-06-27 Chong Yidong <cyd@gnu.org>
2925
2926 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2927
ed6b3510
JW
29282012-06-26 John Wiegley <johnw@newartisans.com>
2929
1ec4b7b2 2930 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2931 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2932
ed6b3510
JW
2933 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2934 when building with Clang.
2935
8edd4a2b
SM
29362012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2937
2938 * eval.c (Fapply): Allow calling it with a single argument.
2939
f6f62d1b
EZ
29402012-06-26 Eli Zaretskii <eliz@gnu.org>
2941
2942 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2943 _stricmp and _strnicmp.
2944 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2945
62efea5e
DA
29462012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2947
2948 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2949 allocated window.
2950 (allocate_process): Likewise for new process.
8edd4a2b 2951 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2952 (allocate_frame): Likewise.
2953 * frame.c (make_frame): Omit redundant initialization.
2954 * window.c (make_parent_window): Use memset.
2955 (make_window): Omit redundant initialization.
2956 * process.c (make_process): Omit redundant initialization.
2957 * terminal.c (create_terminal): Likewise.
2958
42997f4d
DA
29592012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2960
2961 * term.c (delete_tty): Remove redundant call to memset.
2962
1130ecfc
DA
29632012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2964
2965 * alloc.c: Remove build_string.
2966 * lisp.h: Define build_string as static inline. This provides
2967 a better opportunity to optimize away calls to strlen when the
2968 function is called with compile-time constant argument.
2969 * image.c (imagemagick_error): Convert to build_string.
2970 * w32proc.c (sys_spawnve): Likewise.
2971 * xterm.c (x_term_init): Likewise.
2972
cf38a720
PE
29732012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2974
99027bdd
PE
2975 Use sprintf return value instead of invoking strlen on result.
2976 In the old days this wasn't portable, since some sprintf
2977 implementations returned char *. But they died out years ago and
2978 Emacs already assumes sprintf returns int.
2979 Similarly for float_to_string.
2980 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2981 * ccl.c (ccl_driver):
2982 * character.c (string_escape_byte8):
2983 * data.c (Fnumber_to_string):
2984 * doprnt.c (doprnt):
2985 * print.c (print_object):
2986 * xdisp.c (message_dolog):
2987 * xfns.c (syms_of_xfns):
2988 Use sprintf or float_to_string result to avoid need to call strlen.
2989 * data.c (Fnumber_to_string):
2990 Use make_unibyte_string, since the string must be ASCII.
2991 * lisp.h, print.c (float_to_string): Now returns int length.
2992 * term.c (produce_glyphless_glyph):
2993 Use sprintf result rather than recomputing it.
2994
cf38a720
PE
2995 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2996 * Makefile.in (ALL_CFLAGS):
2997 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2998 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2999
3511c784
DA
30002012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3001
0a08eb21 3002 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
3003 strcasecmp if available.
3004 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
3005
fb7da12e
AS
30062012-06-25 Andreas Schwab <schwab@linux-m68k.org>
3007
3008 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
3009 Avoid comma operator.
3010 * menu.c (push_submenu_start, push_submenu_end)
3011 (push_left_right_boundary, push_menu_pane): Likewise.
3012 * msdos.c (dos_rawgetc): Likewise.
3013
afa2ffd8
DA
30142012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3015
3016 * xfns.c (xic_create_fontsetname): Remove redundant calls
3017 to memset.
3018
b3b4476b
PE
30192012-06-25 Paul Eggert <eggert@cs.ucla.edu>
3020
4495ff38
PE
3021 * gtkutil.c (get_utf8_string): Remove redundant assignment.
3022 sprintf already null-terminates its output.
3023
b3b4476b
PE
3024 * xfns.c (x_window): Remove redundant cast.
3025
b00876c9
DA
30262012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
3027
3028 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
3029 `const char *' to `char *' to avoid compiler warning.
3030
d188e26b
PE
30312012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3032
885d1d74
PE
3033 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
3034 instead of truncating it to 63 (admittedly a generous limit).
3035
d188e26b
PE
3036 * process.c: Fix spelling and caps in comments.
3037
e2f560b1
DN
30382012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
3039
e86db54b 3040 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
3041 * sysdep.c (setpgrp): Remove definition, not used in this file.
3042
7583a3a1
JB
30432012-06-24 Juanma Barranquero <lekktu@gmail.com>
3044
3045 * makefile.w32-in: Update dependencies.
3046
696056c2
EZ
30472012-06-24 Eli Zaretskii <eliz@gnu.org>
3048
3049 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
3050 (SYSTIME_H): Add nt/inc/sys/time.h.
3051
3052 * systime.h [WINDOWSNT]: Include sys/time.h.
3053
3054 * s/ms-w32.h (struct timespec): Definition moved from
3055 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
3056
845ca893
PE
30572012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
3060 * buffer.h (buffer_slot_type_mismatch):
3061 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3062 * eval.c (unwind_to_catch):
3063 * image.c (my_png_error, my_error_exit):
3064 * keyboard.c (quit_throw_to_read_char, user_error)
3065 (Fexit_recursive_edit, Fabort_recursive_edit):
3066 * lisp.h (die, args_out_of_range, args_out_of_range_3)
3067 (wrong_type_argument, buffer_overflow, __executable_start)
3068 (memory_full, buffer_memory_full, string_overflow, Fthrow)
3069 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
3070 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
3071 (fatal):
3072 (child_setup) [!DOS_NT]:
3073 * lread.c (end_of_file_error, invalid_syntax):
3074 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
3075 * puresize.h (pure_write_error):
3076 * search.c (matcher_overflow):
3077 * sound.c (sound_perror, alsa_sound_perror):
3078 * sysdep.c, syssignal.h (croak):
3079 * term.c (maybe_fatal, vfatal):
3080 * textprop.c (text_read_only):
3081 * undo.c (user_error):
3082 * unexmacosx.c (unexec_error):
3083 * xterm.c (x_ins_del_lines, x_delete_glyphs):
3084 Use _Noreturn rather than NO_RETURN.
3085 No need for separate decl merely because of _Noreturn.
3086 * sound.c (sound_warning, parse_sound):
3087 Remove unnecessary forward decls.
3088
f1dd8073
PE
30892012-06-24 Paul Eggert <eggert@cs.ucla.edu>
3090
3091 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
3092 * lisp.h (WAIT_READING_MAX): New macro.
3093 * dispnew.c (Fsleep_for, sit_for):
3094 * keyboard.c (kbd_buffer_get_event):
3095 * process.c (Faccept_process_output):
3096 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
3097 This improves on the previous patch, which introduced a bug
3098 when time_t is unsigned and as wide as intmax_t.
3099 See <http://bugs.gnu.org/9000#51>.
3100
b82c1755
EZ
31012012-06-23 Eli Zaretskii <eliz@gnu.org>
3102
3103 * dispnew.c (sit_for, Fsleep_for):
3104 * keyboard.c (kbd_buffer_get_event):
3105 * process.c (Faccept_process_output): Avoid compiler warnings when
3106 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
3107
ca300656
JB
31082012-06-23 Juanma Barranquero <lekktu@gmail.com>
3109
049ec95b
JB
3110 * makefile.w32-in: Update dependencies.
3111
ca300656
JB
3112 * w32.c (ltime): Add return type and declare static.
3113 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
3114
db7b8d06
PE
31152012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3116
3117 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
3118 Privately reported by Herbert J. Skuhra.
3119 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
3120 All uses changed.
3121 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
3122 not make_lisp_timeval, when the argument is of type EMACS_TIME.
3123
0bd8297f
EZ
31242012-06-23 Eli Zaretskii <eliz@gnu.org>
3125
96512555
EZ
3126 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
3127 last argument of make_unibyte_string.
3128
0bd8297f
EZ
3129 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
3130 language ID in the event parameters.
3131
3132 * w32term.c (w32_read_socket): Put the new keyboard codepage into
3133 event.code, not the obscure "character set ID".
3134
63def6b6
CY
31352012-06-23 Chong Yidong <cyd@gnu.org>
3136
3137 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
3138
e8a02204
EZ
31392012-06-23 Eli Zaretskii <eliz@gnu.org>
3140
388cdec0
EZ
3141 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
3142 * w32.c (fdutimens): New function.
3143
3144 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
3145
3146 * s/ms-w32.h (pselect): Redirect to sys_select.
3147
3148 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
3149
e8a02204
EZ
3150 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
3151 in the logic of incrementing and decrementing the value of
3152 use_relocatable_buffers.
3153
d054f3fb
PE
31542012-06-23 Paul Eggert <eggert@cs.ucla.edu>
3155
3156 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
3157 Privately reported by Herbert J. Skuhra.
3158 [__FreeBSD__]: Remove "*/" typo after "#include".
3159 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
3160 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
3161 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
3162 Don't assume EMACS_TIME and struct timeval are the same type.
3163
d35af63c
PE
31642012-06-22 Paul Eggert <eggert@cs.ucla.edu>
3165
3166 Support higher-resolution time stamps (Bug#9000).
3167 The time stamps are only nanosecond-resolution at the C level,
3168 since that's the best that any real-world system supports now.
3169 But they are picosecond-resolution at the Lisp level, as that's
3170 easy, and leaves room for future OS improvements.
3171
3172 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
3173 (LIBES): Use it.
3174
3175 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
3176 Don't get current time unless it's needed.
3177
3178 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
3179 now provides it if it's absent.
3180 (start_atimer): Port to higher-res time stamps.
3181 Check for time stamp overflow. Don't get current time more
3182 often than is needed.
3183
3184 * buffer.h (struct buffer): Buffer modtime now has high resolution.
3185 Include systime.h, not time.h.
3186 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
3187
3188 * dired.c: Include stat-time.h.
3189 (Ffile-attributes): File times now have higher resolution.
3190
3191 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
3192 (struct image): Timestamp now has higher resolution.
3193
3194 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
3195 has at least microseconds now. All uses removed.
3196 (update_frame, update_single_window, update_window, update_frame_1)
3197 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
3198
3199 * editfns.c (time_overflow): Now extern.
3200 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
3201 (float-time, Fformat_time_string, Fcurrent_time_string)
3202 (Fcurrent_time_zone): Accept and generate higher-resolution
3203 time stamps.
3204 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
3205 (decode_time_components, lisp_seconds_argument): New functions.
3206 (make_time): Now static.
3207 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
3208 Report an error if the time is invalid, rather than having the caller
3209 do that.
3210
3211 * fileio.c: Include <stat-time.h>
3212 (Fcopy_file): Copy higher-resolution time stamps.
3213 Prefer to set the time stamp via a file descriptor if that works.
3214 (Fset_file_times, Finsert_file_contents, Fwrite_region)
3215 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
3216 (Fvisited_file_modtime, Fset_visited_file_modtime):
3217 Support higher-resolution time stamps.
3218
3219 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
3220
3221 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
3222
3223 * image.c (prepare_image_for_display, clear_image_cache)
3224 (lookup_image): Port to higer-resolution time stamps.
3225
3226 * keyboard.c (start_polling, bind_polling_period):
3227 Check for time stamp overflow.
3228 (read_char, kbd_buffer_get_event, timer_start_idle)
3229 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
3230 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
3231 Port to higher-resolution time stamps. Do not assume time_t is signed.
3232 (decode_timer): New function. Timers are now vectors of length 9,
3233 not 8, to accommodate the picosecond component.
3234 (timer_check_2): Use it.
3235
3236 * nsterm.m (select_timeout, timeval_subtract): Remove.
3237 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
3238 as they're a bit more accurate and handle overflow better.
3239 (ns_select): Change prototype to be compatible with pselect.
3240 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
3241 * nsterm.h (ns_select): Adjust prototype.
3242
3243 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
3244 us-resolution time stamps.
3245 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
3246
3247 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
3248
3249 * lisp.h (time_overflow): New decl.
3250 (wait_reading_process_output): First arg is now intmax_t, not int,
3251 to accommodate larger waits.
3252
3253 * process.h (struct Lisp_Process.read_output_delay):
3254 Now counts nanoseconds, not microseconds.
3255 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
3256 EMACS_HAS_USECS.
3257 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
3258 (wait_reading_process_output):
3259 Port to ns-resolution time stamps.
3260 (Faccept_process_output, wait_reading_process_output):
3261 Check for time stamp overflow. Do not assume time_t is signed.
3262 (select_wrapper): Remove; we now use pselect.
3263 (Fprocess_attributes): Now generates ns-resolution time stamps.
3264
3265 * sysdep.c: Include utimens.h. Don't include utime.h
3266 or worry about struct utimbuf; gnulib does that for us now.
3267 (gettimeofday): Remove; gnulib provides a substitute.
3268 (make_timeval): New function.
3269 (set_file_times): Now sets ns-resolution time stamps.
3270 New arg FD; all uses changed.
3271 (time_from_jiffies, ltime_from_jiffies, get_up_time)
3272 (system_process_attributes):
3273 Now returns ns-resolution time stamp. All uses changed.
3274 Check for time stamp overflow.
3275
3276 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
3277 provides a substitute now.
3278
3279 * systime.h: Include timespec.h rather than sys/time.h and time.h,
3280 since it guarantees struct timespec.
3281 (EMACS_TIME): Now struct timespec, so that we can support
3282 ns-resolution time stamps.
3283 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
3284 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
3285 (EMACS_USECS): Remove.
3286 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
3287 so multiply the arg by 1000 before storing it.
3288 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
3289 New macros.
3290 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
3291 Port to ns-resolution time stamps.
3292 (EMACS_TIME_NEG_P): Remove; replaced by....
3293 (EMACS_TIME_SIGN): New macro.
3294 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
3295 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
3296 (set_file_times, make_time, lisp_time_argument): Adjust signature.
3297 (make_timeval, make_lisp_time, decode_time_components): New decls.
3298 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
3299 that it mishandled time_t overflow. You can't compare by subtracting!
3300 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
3301 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
3302
3303 * term.c: Include <sys/time.h>.
3304 (timeval_to_Time): New function, for proper overflow wraparound.
3305 (term_mouse_position, term_mouse_click): Use it.
3306
3307 * undo.c (record_first_change): Support higher-resolution time stamps
3308 in the undo buffer.
3309 (Fprimitive_undo): Use them when restoring time stamps.
3310
3311 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
3312 (w32_get_internal_run_time):
3313 Port to higher-resolution Emacs time stamps.
3314 (ltime): Now accepts single 64-bit integer, as that's more convenient
3315 for callers.
3316
3317 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
3318
3319 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
3320 for compatibility with pselect. Support ns-resolution time stamps.
3321
3322 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
3323
3324 * xselect.c (wait_for_property_change, x_get_foreign_selection):
3325 Check for time stamp overflow, and support ns-resolution time stamps.
3326
3327 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
3328 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
3329 (timeval_subtract): Remove; no longer needed.
3330 (XTflash, XTring_bell, x_wait_for_event):
3331 Port to ns-resolution time stamps. Don't assume time_t is signed.
3332
b6a92dfe
CY
33332012-06-22 Chong Yidong <cyd@gnu.org>
3334
3335 * xdisp.c (x_consider_frame_title): Revert last change.
3336
d251c37c
EZ
33372012-06-22 Eli Zaretskii <eliz@gnu.org>
3338
3339 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
3340 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
3341 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
3342 staticidx goes up to 1597 out of 1600 = 0x640.)
3343
f10deafb
PE
33442012-06-20 Paul Eggert <eggert@cs.ucla.edu>
3345
3346 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
3347 Otherwise, the umask might be mistakenly 0 while handling input signals.
3348
ec6de1e2
SM
33492012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
3350
3351 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
3352
28be1ada
DA
33532012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
3354
3355 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
3356 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
3357 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
3358 access to `contents' member of Lisp_Vector objects with AREF and ASET
3359 where appropriate.
3360
c6bf3022
CY
33612012-06-19 Chong Yidong <cyd@gnu.org>
3362
3363 * frame.c (delete_frame): When selecting a frame on a different
3364 text terminal, do not alter the terminal's top-frame.
3365
3366 * xdisp.c (format_mode_line_unwind_data): Record the target
3367 frame's selected window and its terminal's top-frame.
3368 (unwind_format_mode_line): Restore them.
3369 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
3370 Callers changed.
3371 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
3372 since tty frames can be explicitly named.
3373 (prepare_menu_bars): Likewise.
3374
3375 * term.c (Ftty_top_frame): New function.
3376
defd4196
PE
33772012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3378
3379 Port byte-code-meter to modern targets.
3380 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
3381 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 3382 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
3383 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
3384 (METER_1, METER_2): Simplify.
3385
1053a871
SM
33862012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
3387
3388 * data.c (Fdefalias): Return `symbol' (bug#11686).
3389
b7e8d081
MR
33902012-06-18 Martin Rudalics <rudalics@gmx.at>
3391
3392 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
3393 gets killed during executing of this function (Bug#11665).
3394 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
3395 (Vkill_buffer_query_functions): In doc-string say that functions
3396 run by this hook should not change the current buffer.
3397
7ea2b339
PE
33982012-06-18 Paul Eggert <eggert@cs.ucla.edu>
3399
3400 Fix recently-introduced process.c problems found by static checking.
3401 * process.c (write_queue_push, write_queue_pop, send_process):
3402 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
3403 (write_queue_pop): Fix pointer signedness problem.
3404 (send_process): Remove unused local.
3405
96a313a1
CY
34062012-06-17 Chong Yidong <cyd@gnu.org>
3407
3408 * xdisp.c (redisplay_internal): No need to redisplay terminal
3409 frames that are not on top.
3410
20ca2e94
TN
34112012-06-17 Troels Nielsen <bn.troels@gmail.com>
3412
3413 * process.c (make_process): Initialize write_queue.
3414 (write_queue_push, write_queue_pop): New functions.
3415 (send_process): Use them to maintain correct ordering of process
3416 writes (Bug#10815).
3417
9a900ca9
PE
34182012-06-17 Paul Eggert <eggert@cs.ucla.edu>
3419
310fbfa8
PE
3420 * lisp.h (eassert): Assume C89 or later.
3421 This removes the need for CHECK.
3422 (CHECK): Remove. Its comments about always evaluating its
3423 argument were confusing, as 'eassert' typically does not evaluate
3424 its argument.
3425
27bb1ca4
PE
3426 * coding.c (produce_chars): Use ptrdiff_t, not int.
3427
9a900ca9
PE
3428 * xterm.c (x_draw_underwave): Check for integer overflow.
3429 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
3430
41b7f8bc 34312012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
3432
3433 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
3434 referenced (Bug#11583).
3435
9b0e3eba
AA
34362012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
3437
3438 Implement wave-style variant of underlining.
3439 * dispextern.h (face_underline_type): New enum.
3440 (face): Add field for underline type.
3441 * nsterm.m (ns_draw_underwave): New function.
3442 (ns_draw_text_decoration): Use it.
3443 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
3444 New functions.
3445 (x_draw_glyph_string): Use them.
3446 * xfaces.c (Qline, Qwave): New Lisp objects.
3447 (check_lface_attrs, merge_face_ref)
1053a871
SM
3448 (Finternal_set_lisp_face_attribute, realize_x_face):
3449 Handle wave-style underline face attributes.
9b0e3eba
AA
3450 * xterm.c (x_draw_underwave): New function.
3451 (x_draw_glyph_string): Use it.
3452
0fb52f11
JB
34532012-06-16 Juanma Barranquero <lekktu@gmail.com>
3454
3455 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
3456 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
3457 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
3458 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
3459 ($(BLD)/w32select.$(O)): Update dependencies.
3460
e5560ff7
AS
34612012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3462
3463 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
3464 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
3465 * character.c (_fetch_multibyte_char_p): Remove.
3466 * alloc.c: Include "character.h" before "buffer.h".
3467 * bidi.c: Likewise.
3468 * buffer.c: Likewise.
3469 * bytecode.c: Likewise.
3470 * callint.c: Likewise.
3471 * callproc.c: Likewise.
3472 * casefiddle.c: Likewise.
3473 * casetab.c: Likewise.
3474 * category.c: Likewise.
3475 * cmds.c: Likewise.
3476 * coding.c: Likewise.
3477 * composite.c: Likewise.
3478 * dired.c: Likewise.
3479 * dispnew.c: Likewise.
3480 * doc.c: Likewise.
3481 * dosfns.c: Likewise.
3482 * editfns.c: Likewise.
3483 * emacs.c: Likewise.
3484 * fileio.c: Likewise.
3485 * filelock.c: Likewise.
3486 * font.c: Likewise.
3487 * fontset.c: Likewise.
3488 * fringe.c: Likewise.
3489 * indent.c: Likewise.
3490 * insdel.c: Likewise.
3491 * intervals.c: Likewise.
3492 * keyboard.c: Likewise.
3493 * keymap.c: Likewise.
3494 * lread.c: Likewise.
3495 * macros.c: Likewise.
3496 * marker.c: Likewise.
3497 * minibuf.c: Likewise.
3498 * nsfns.m: Likewise.
3499 * nsmenu.m: Likewise.
3500 * print.c: Likewise.
3501 * process.c: Likewise.
3502 * regex.c: Likewise.
3503 * region-cache.c: Likewise.
3504 * search.c: Likewise.
3505 * syntax.c: Likewise.
3506 * term.c: Likewise.
3507 * textprop.c: Likewise.
3508 * undo.c: Likewise.
3509 * unexsol.c: Likewise.
3510 * w16select.c: Likewise.
3511 * w32fns.c: Likewise.
3512 * w32menu.c: Likewise.
3513 * window.c: Likewise.
3514 * xdisp.c: Likewise.
3515 * xfns.c: Likewise.
3516 * xmenu.c: Likewise.
3517 * xml.c: Likewise.
3518 * xselect.c: Likewise.
3519
2f07e6af
EZ
35202012-06-16 Eli Zaretskii <eliz@gnu.org>
3521
1053a871
SM
3522 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
3523 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 3524 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
3525 row.
3526 (handle_face_prop): Use chunk-relative overlay string index when
3527 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
3528 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
3529 the rightmost. (Bug#11720)
2f07e6af 3530
29b83cec
AS
35312012-06-16 Andreas Schwab <schwab@linux-m68k.org>
3532
3533 * category.h (CHAR_HAS_CATEGORY): Define as inline.
3534 (CATEGORY_MEMBER): Enforce 1/0 value.
3535 * category.c (_temp_category_set): Remove.
3536
4c5501e9
EZ
35372012-06-16 Eli Zaretskii <eliz@gnu.org>
3538
3539 * window.c (Fdelete_other_windows_internal)
3540 (Fdelete_window_internal): Don't access frame's mouse highlight
3541 info of the initial frame. (Bug#11677)
3542
2b570124
PE
35432012-06-14 Paul Eggert <eggert@cs.ucla.edu>
3544
e93864f9
PE
3545 * .gdbinit (xgetint): Fix recently-introduced paren typo.
3546 Assume USE_2_TAGS_FOR_INTS.
3547 (xreload): Adjust $tagmask width to match recent lisp.h change.
3548
2b570124
PE
3549 Simplify lisp.h in minor ways that should not affect code.
3550 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
3551 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
3552 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
3553 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
3554 (INTTYPEBITS): New macro, for clarity.
3555 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
3556 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
3557 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
3558 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
3559 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
3560
81755f69
JB
35612012-06-13 Juanma Barranquero <lekktu@gmail.com>
3562
3563 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
3564
16192a57
GM
35652012-06-13 Glenn Morris <rgm@gnu.org>
3566
3567 * s/bsd-common.h (BSD4_3):
3568 * s/usg5-4-common.h (USG5_4): No longer define; unused.
3569
646b5f55
AS
35702012-06-13 Andreas Schwab <schwab@linux-m68k.org>
3571
3572 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
3573 instead of union.
3574 (XLI, XIL): Define.
1053a871
SM
3575 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
3576 Use them.
3577 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 3578 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 3579 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
3580 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
3581 * frame.c (delete_frame): Remove outdated comment.
3582 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
3583 USE_LISP_UNION_TYPE.
3584 (Fw32_unregister_hot_key): Likewise.
3585 (Fw32_toggle_lock_key): Likewise.
3586 * w32menu.c (add_menu_item): Likewise.
3587 (w32_menu_display_help): Use XIL instead of checking
3588 USE_LISP_UNION_TYPE.
3589 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
3590 (init_heap): Likewise.
3591 * w32term.c (w32_read_socket): Update comment.
3592
1d3823c9
GM
35932012-06-13 Glenn Morris <rgm@gnu.org>
3594
c62ff706
GM
3595 * s/usg5-4-common.h, src/s/unixware.h:
3596 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
3597
1d3823c9
GM
3598 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
3599
bfe3e0a2
PE
36002012-06-13 Paul Eggert <eggert@cs.ucla.edu>
3601
3602 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
3603 * alloc.c (make_number) [!defined make_number]:
3604 Remove, as lisp.h always defines this now.
3605 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
3606 (roundup_size): Verify that it is a power of 2.
3607 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
3608 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
3609 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
3610 -DUSE_LSB_TAG=0, to override the automatically-selected default.
3611 USE_LSB_TAG now is always defined to be either 0 or 1.
3612 All uses changed.
3613 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
3614 code works fine either way, and efficiency is not a concern here,
3615 as the union type is for debugging, not for production.
3616 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
3617 Use an inline function on all platforms when using the union type,
3618 since this is simpler and 'static inline' can be used portably
3619 within Emacs now.
3620 (LISP_INITIALLY_ZERO): New macro.
3621 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
3622 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
3623
45fa9c0f
GM
36242012-06-12 Glenn Morris <rgm@gnu.org>
3625
b4492cba
GM
3626 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
3627
3628 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 3629
45fa9c0f
GM
3630 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
3631 Move BROKEN_SIGIO to configure.
3632
3633 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
3634 Move NO_TERMIO to configure.
3635
0e25d334
CY
36362012-06-12 Chong Yidong <cyd@gnu.org>
3637
3638 * image.c (imagemagick_load_image): Use MagickFlattenImage if
3639 MagickMergeImageLayers is undefined. Use pixel pusher loop if
3640 MagickExportImagePixels is undefined.
3641
43682bb6
PE
36422012-06-12 Paul Eggert <eggert@cs.ucla.edu>
3643
3644 * image.c (imagemagick_load_image): Remove unused label.
3645
a9be7d2b
GM
36462012-06-11 Glenn Morris <rgm@gnu.org>
3647
3648 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
3649 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
3650 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
3651 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
3652
3017f87f
SM
36532012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
3654
3655 * alloc.c (make_byte_code): New function.
3656 (Fmake_byte_code): Use it. Don't purify here.
3657 * lread.c (read1): Use it as well to avoid extra allocation.
3658
1b9b4cf4
CY
36592012-06-11 Chong Yidong <cyd@gnu.org>
3660
3661 * image.c (imagemagick_load_image): Implement transparency.
3662
95988fcf
AS
36632012-06-10 Andreas Schwab <schwab@linux-m68k.org>
3664
3665 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
3666 account for preceding backslashes. (Bug#11663)
3667
cd4eb164
CY
36682012-06-09 Chong Yidong <cyd@gnu.org>
3669
3670 * term.c: Support italics in capable terminals (Bug#9652).
3671 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
3672 (turn_on_face): Output using TS_enter_italic_mode if available.
3673 Don't handle unused blinking and alt-charset cases.
3674 (turn_off_face): Handle italic case; discard unused tty_blinking_p
3675 and tty_alt_charset_p cases.
3676 (tty_capable_p, init_tty): Support italics.
3677
3678 * termchar.h (struct tty_display_info): Add field for italics.
3679 Remove unused blink field.
3680
3681 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
3682 Handle slant.
3683
3684 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
3685 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
3686 tty_alt_charset_p. Add tty_italic_p.
3687
ff88beb8
MA
36882012-06-09 Michael Albinus <michael.albinus@gmx.de>
3689
3690 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
3691 dbus_type_is_basic if available.
3692 (xd_extract_signed, xd_extract_unsigned): Rename from
3693 extract_signed and extract_unsigned, respectively. Adapt callers.
3694
44286096
CY
36952012-06-09 Chong Yidong <cyd@gnu.org>
3696
1682701f
CY
3697 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
3698
44286096
CY
3699 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
3700 case (Bug#9752).
3701
d86feb17
PE
37022012-06-08 Paul Eggert <eggert@cs.ucla.edu>
3703
3704 * xdisp.c (vmessage): Treat frame message as multibyte.
3705 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
3706 would generate the diagnostic "Making \302\247 buffer-local while
3707 let-bound!".
3708
d5c20fe8
EZ
37092012-06-08 Eli Zaretskii <eliz@gnu.org>
3710
3711 * dispnew.c (showing_window_margins_p): Undo last change, which
3712 was done due to an inadvertent commit.
3713 (adjust_frame_glyphs_for_frame_redisplay): Do call
3714 showing_window_margins_p.
3715
513749ee
SM
37162012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3717
3718 * eval.c (Fmake_var_non_special): New primitive.
3719 (syms_of_eval): Defsubr it.
3720 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
3721
d4a8f5c1
JB
37222012-06-08 Juanma Barranquero <lekktu@gmail.com>
3723
3724 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
3725 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
3726
8bbbc977
EZ
37272012-06-08 Eli Zaretskii <eliz@gnu.org>
3728
3729 * alloc.c (allocate_vectorlike): Fix last change.
3730
f3372c87
DA
37312012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
3732
3733 Block-based vector allocation of small vectors.
3734 * lisp.h (struct vectorlike_header): New field `nbytes',
3735 adjust comment accordingly.
3736 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
3737 to denote vector blocks. Adjust users (live_vector_p,
3738 mark_maybe_pointer, valid_lisp_object_p) accordingly.
3739 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
3740 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
3741 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
3742 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
3743 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
3744 (roundup_size): New constant.
3745 (struct vector_block): New data type.
3746 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 3747 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
3748 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
3749 (sweep_vectors): New functions.
3750 (allocate_vectorlike): Return `zero_vector' as the only vector of
3751 0 items. Allocate new vector from block if vector size is less than
3752 or equal to VBLOCK_BYTES_MAX.
3753 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
3754 (init_alloc_once): Add call to init_vectors.
3755
4f18a4ed
SM
37562012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
3757
3758 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
3759
86f158bc
PE
37602012-06-07 Paul Eggert <eggert@cs.ucla.edu>
3761
3762 * doprnt.c (doprnt): Truncate multibyte char correctly.
3763 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
3764 would mishandle a string argument "Xc" if X was a multibyte
3765 character of length 2: it would truncate after X's first byte
3766 rather than including all of X.
3767
c5cfcbe0
CY
37682012-06-06 Chong Yidong <cyd@gnu.org>
3769
3770 * buffer.c (word_wrap): Doc fix.
3771
c05cf390
PE
37722012-06-04 Paul Eggert <eggert@cs.ucla.edu>
3773
3774 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
3775
0c3461de
GM
37762012-06-03 Glenn Morris <rgm@gnu.org>
3777
3778 * xdisp.c (tool-bar-style): Doc fix.
3779
c71232db
UM
37802012-06-03 Ulrich Müller <ulm@gentoo.org>
3781
3782 * Makefile.in (PAXCTL): Define.
3783 (temacs$(EXEEXT)): Disable memory randomization for the temacs
3784 binary via PaX flags if the paxctl utility is available.
3785 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3786 Restore PaX flags to their default. (Bug#11398)
3787
383f7350
CY
37882012-06-03 Chong Yidong <cyd@gnu.org>
3789
3790 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3791 buffer (Bug#11226).
3792
5f2c76c6
CY
37932012-06-03 Chong Yidong <cyd@gnu.org>
3794
3795 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3796 (note_mode_line_or_margin_highlight): If there is no help echo,
3797 use mode-line-default-help-echo. Handle the case where the mouse
3798 position is past the end of the mode line string.
3799
3800 * buffer.c (buffer_local_value_1): New function, split from
3801 Fbuffer_local_value; can return Qunbound.
3802 (Fbuffer_local_value): Use it.
3803 (Vmode_line_format): Docstring tweaks.
3804
773d47f6
PE
38052012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3806
3807 * sysdep.c (system_process_attributes): Improve comment.
3808
f2d6a3df
SM
38092012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3810
3811 * keyboard.c: Export real-this-command to Elisp.
3812 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3813 and DEFVAR it. Update all users.
3814
63810350
PE
38152012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3816
7bd5c1f4
PE
3817 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3818
63810350
PE
3819 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3820 Convert pctcpu and pctmem to Lisp float properly.
3821 Let the compiler fold better, as 100.0/0x8000 is exact.
3822
a2821611
AS
38232012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3824
3825 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3826 cons_block.
3827
5fceba1d
PE
38282012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3829
3830 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3831
c98ff5dd
DA
38322012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3833
3834 For a 'struct window', replace some Lisp_Object fields to
3835 bitfields where appropriate, remove unused fields.
3836 * window.h (struct window): Remove unused 'last_mark_x' and
3837 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3838 change it's type from Lisp_Object to bitfield.
3839 Change type of 'force_start', 'optional_new_start',
3840 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3841 fields from Lisp_Object to bitfield. Adjust users accordingly.
3842
ca34e0be
PE
38432012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3844
3845 Pacify gcc -Wdouble-precision when using Xaw.
3846 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3847 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3848 Use 'float' consistently, rather than 'float' in most places
3849 and 'double' in a couple of places.
3850
efc00ab1 38512012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3852
3853 * xdisp.c (handle_stop): Detect whether we have overlay strings
3854 loaded by testing it->current.overlay_string_index to be
3855 non-negative, instead of checking whether n_overlay_strings is
3856 positive. (Bug#11587)
3857
efc00ab1 38582012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3859
3860 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3861
3862 * doc.c (Fsubstitute_command_keys): Doc fix.
3863
efc00ab1 38642012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3865
3866 * search.c (search_buffer): Remove calls to
3867 r_alloc_inhibit_buffer_relocation, as it is now called by
3868 maybe_unify_char, which was the cause of relocation of buffer text
3869 in bug#11519.
3870
efc00ab1 38712012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3872
3873 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3874 for the duration of call to load_charset, to avoid problems with
3875 callers of maybe_unify_char that access buffer text through C
3876 pointers.
3877
3878 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3879 decrement the inhibition flag, instead of just setting or
3880 resetting it.
3881
ba93a187
PE
38822012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3883
3884 Remove obsolete '#define static' cruft.
3885 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3886 This #undef was "temporary" in 2000; it is no longer needed
3887 now that '#define static' has gone away.
3888 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3889 (gray_bitmap_bits): Remove; no longer needed.
3890 All uses replaced with definiens.
3891 * xterm.c: Include "bitmaps/gray.xbm".
3892
9e4bf381
PE
38932012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3894
3895 Clean up __executable_start, monstartup when --enable-profiling.
3896 The following changes affect the code only when profiling.
3897 * dispnew.c (__executable_start): Rename from safe_bcopy.
3898 Define only on platforms that need it.
3899 * emacs.c: Include <sys/gmon.h> when profiling.
3900 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3901 (__executable_start): Remove decl, since lisp.h does it now.
3902 (safe_bcopy): Remove decl; no longer has that name.
3903 (main): Coalesce #if into single bit of code, for simplicity.
3904 Cast pointers to uintptr_t, since standard libraries want integers
3905 and not pointers.
3906 * lisp.h (__executable_start): New decl.
3907
32d72c2f
GM
39082012-05-31 Glenn Morris <rgm@gnu.org>
3909
3910 * image.c (Fimagemagick_types): Doc fix.
3911
baac5bc7
JM
39122012-05-30 Jim Meyering <meyering@redhat.com>
3913
3914 * callproc.c (Fcall_process_region): Include directory component
3915 in mkstemp error message (Bug#11586).
3916
72cb32cf
PE
39172012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3918
3919 * alloc.c, lisp.h (make_pure_vector): Now static.
3920
61b108cc
SM
39212012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3922
3923 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3924 Move to byte-run.el.
3925 (Fautoload): Do the hash-doc more carefully.
3926 * data.c (Fdefalias): Purify definition, except for keymaps.
3927 (Qdefun): Move from eval.c.
3928 * lisp.h (Qdefun): Remove.
3929 * lread.c (read1): Tiny simplification.
3930
471fe23d
TN
39312012-05-29 Troels Nielsen <bn.troels@gmail.com>
3932
934f3f58 3933 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3934 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3935 Bug#9642, but explicitly check that the buffer the overlay would
3936 be moved to is live and rearrange lines to make sure that errors
3937 will not put the overlay in an inconsistent state.
3938 (Fdelete_overlay): Cosmetics.
3939
85d0efd1
EZ
39402012-05-28 Eli Zaretskii <eliz@gnu.org>
3941
3942 * w32term.c (my_bring_window_to_top): New function.
3943 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3944 could be different from the original one.
3945 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3946 (Bug#11513)
3947
3948 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3949 by calling BringWindowToTop.
3950
3951 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3952 (WM_EMACS_END): Increase by one.
3953
da92a98c
PE
39542012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3955
3956 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3957 This avoids undefined behavior that might cause the eassert
3958 to not catch an out-of-range value.
3959
74d1f848
JB
39602012-05-28 Juanma Barranquero <lekktu@gmail.com>
3961
3962 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3963 Update dependencies.
3964
9e1a06fc
EZ
39652012-05-27 Eli Zaretskii <eliz@gnu.org>
3966
3967 * bidi.c (bidi_mirror_char): Fix last change.
3968
f3dd7312
AS
39692012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3970
3971 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3972 when referring to sectname field in printf format.
3973
81899c91
PE
39742012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3975
57b81a9f
PE
3976 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3977 Only r_alloc_inhibit_buffer_relocation needed to be added;
3978 the others were already declared.
3979
81899c91
PE
3980 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3981 before checking whether it's out of range. Put the check inside
3982 eassert. See
3983 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3984
33017faf 39852012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3986
3987 * callproc.c (Fcall_process): Restore a line that was accidentally
3988 commented out in the 2011-02-13 change (bug#11547).
3989
33017faf 39902012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3991
3992 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3993 defined on ralloc.c.
3994
3995 * buffer.c [REL_ALLOC]: Remove prototypes of
3996 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3997 they are now on lisp.h.
3998
3999 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
4000
4001 * search.c (search_buffer): Use it to inhibit relocation of buffer
4002 text while re_search_2 is doing its job, because re_search_2 is
4003 passed C pointers to buffer text. (Bug#11519)
4004
23415acf
EZ
4005 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
4006 Update value to 24.
4007
44e27368
EZ
4008 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
4009 state after an additional call to move_it_in_display_line_to, keep
4010 the values of it->max_ascent and it->max_descent found for the
4011 entire line.
4012 (pos_visible_p): Revert the comparison against bottom_y to what it
4013 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
4014 (Bug#11464)
4015
c1892f11
PE
40162012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4017
4018 Fix coding-related core dumps with gcc -ftrapv.
4019 The code was computing A - B, where A and B are pointers, and B is
4020 random garbage. This can lead to core dumps on platforms that
4021 have special pointer registers, and it also leads to core dumps on
4022 x86-64 when compiled with gcc -ftrapv. The fix is to compute
4023 A - B only when B is initialized properly.
4024 * coding.c (coding_set_source, coding_set_destination): Return void.
4025 (coding_change_source, coding_change_destinations): New functions,
4026 with the old behaviors of coding_set_source and coding_set_destination.
4027 All callers that need an offset changed to use these new functions.
4028
eb7afdad
GM
40292012-05-26 Glenn Morris <rgm@gnu.org>
4030
4031 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
4032
f12fdf02
EZ
40332012-05-26 Eli Zaretskii <eliz@gnu.org>
4034
53a63be6 4035 Extend mouse support on W32 text-mode console.
61b108cc
SM
4036 * xdisp.c (draw_row_with_mouse_face):
4037 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 4038
eb3f6f01 4039 * w32console.c: Include window.h.
61b108cc
SM
4040 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
4041 New functions.
eb3f6f01
EZ
4042 (initialize_w32_display): Initialize mouse-highlight data.
4043
53a63be6
EZ
4044 * w32inevt.c: Include termchar.h and window.h.
4045 (do_mouse_event): Support mouse-autoselect-window. When the mouse
4046 moves, call note_mouse_highlight. If help_echo changed, call
4047 gen_help_event to produce help-echo message in the echo area.
4048 Call clear_mouse_face if mouse_face_hidden is set in the mouse
4049 highlight info.
4050
4cfd81f6
PE
40512012-05-26 Paul Eggert <eggert@cs.ucla.edu>
4052
4053 * lread.c (read1): Simplify slightly to avoid an overflow warning
4054 with GCC 4.7.0 on x86-64.
4055
4446092a
EZ
40562012-05-26 Eli Zaretskii <eliz@gnu.org>
4057
4058 * bidi.c (bidi_mirror_char): Revert last change: an int is
4059 definitely wide enough here.
4060
42b2a986 40612012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 4062
42b2a986 4063 Fix integer width and related bugs (Bug#9874).
eb106a49 4064 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
4065 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
4066 (string_bytes, check_sblock, allocate_string_data):
4067 (compact_small_strings, Fmake_bool_vector, make_string)
4068 (make_unibyte_string, make_multibyte_string)
4069 (make_string_from_bytes, make_specified_string)
4070 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
4071 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
4072 (mark_vectorlike):
4073 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4074 (allocate_pseudovector):
4075 Use int, not EMACS_INT, where int is wide enough.
4076 (inhibit_garbage_collection, Fgarbage_collect):
4077 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4078 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
4079 int might not be wide enough.
4080 (bidi_cache_search, bidi_cache_find, bidi_init_it)
4081 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
4082 (bidi_at_paragraph_end, bidi_find_paragraph_start)
4083 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
4084 (bidi_level_of_next_char, bidi_move_to_visually_next):
4085 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4086 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
4087 (Fkill_buffer, Fset_buffer_major_mode)
4088 (advance_to_char_boundary, Fbuffer_swap_text)
4089 (Fset_buffer_multibyte, overlays_at, overlays_in)
4090 (overlay_touches_p, struct sortvec, record_overlay_string)
4091 (overlay_strings, recenter_overlay_lists)
4092 (adjust_overlays_for_insert, adjust_overlays_for_delete)
4093 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
4094 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
4095 (Foverlay_recenter, last_overlay_modification_hooks_used)
4096 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
4097 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
4098 (validate_region): Omit unnecessary test for b <= e,
4099 since that's guaranteed by the previous test.
d311d28c
PE
4100 (adjust_overlays_for_delete): Avoid pos + length overflow.
4101 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
4102 (report_overlay_modification):
4103 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4104 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
4105 Omit pointer cast, which isn't needed anyway, and doesn't work
4106 after the EMACS_INT -> ptrdiff_t change.
02481186 4107 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
4108 * buffer.h: Adjust decls to match defn changes elsewhere.
4109 (struct buffer_text, struct buffer):
4110 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4111 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
4112 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
4113 not int, to avoid needless 32-bit limit on 64-bit hosts.
4114 (exec_byte_code): Use tighter memory-full test, one that checks
4115 for alloca overflow. Don't compute the address of the object just
4116 before an array, as that's not portable. Use EMACS_INT, not
4117 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
4118 * callint.c (Fcall_interactively):
4119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4120 * callproc.c (call_process_kill, Fcall_process):
4121 Don't assume pid_t fits into an Emacs fixnum.
4122 (call_process_cleanup, Fcall_process, child_setup):
4123 Don't assume pid_t fits into int.
4124 (call_process_cleanup, Fcall_process, delete_temp_file)
4125 (Fcall_process_region):
4126 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4127 (Fcall_process): Simplify handling of volatile integers.
4128 Use int, not EMACS_INT, where int will do.
4129 * casefiddle.c (casify_object, casify_region, operate_on_word)
4130 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
4131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4132 (casify_object): Avoid integer overflow when overallocating buffer.
4133 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 4134 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
4135 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
4136 * category.h (CATEGORYP): Don't assume arg is nonnegative.
4137 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
4138 integers are now checked earlier. All uses replaced with XINT.
4139 (ccl_driver):
4140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4141 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
4142 (ccl_driver, Fregister_code_conversion_map):
4143 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
4144 (resolve_symbol_ccl_program): Check that vector header is in range.
4145 Always copy the vector, so that we can check its contents reliably
4146 now rather than having to recheck each instruction as it's being
4147 executed. Check that vector words fit in 'int'.
4148 (ccl_get_compiled_code, Fregister_ccl_program)
4149 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
4150 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
4151 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
4152 contents are in range.
4153 (Fccl_execute_on_string): Check that status is in range.
4154 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
4155 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
4156 Accept and return EMACS_INT, not int, because callers can pass values
4157 out of 'int' range.
4158 (c_string_width, strwidth, lisp_string_width, chars_in_text)
4159 (multibyte_chars_in_text, parse_str_as_multibyte)
4160 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
4161 (str_as_unibyte, str_to_unibyte, string_count_byte8)
4162 (string_escape_byte8, Fget_byte):
4163 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 4164 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
4165 avoid mishandling large integers.
4166 * character.h: Adjust decls to match defn changes elsewhere.
4167 * charset.c (load_charset_map_from_file, find_charsets_in_text)
4168 (Ffind_charset_region):
4169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4170 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
4171 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 4172 Don't assume fixnum fits in int.
d311d28c
PE
4173 (load_charset_map_from_vector, Fmap_charset_chars):
4174 Remove now-unnecessary CHECK_NATNUMs.
4175 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
4176 Don't rely on undefined behavior with signed left shift overflow.
4177 Don't assume unsigned int fits into fixnum, or that fixnum fits
4178 into unsigned int. Don't require max_code to be a valid fixnum;
4179 that's not true for gb10830 4-byte on a 32-bit host. Allow
4180 invalid_code to be a cons, for the same reason. Require code_offset
4181 to be a character. Avoid int overflow if max_char is close
4182 to INT_MAX.
4183 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
4184 this is intended anyway and avoids some undefined behavior.
4185 (load_charset_map): Pass unsigned, not int, as 2nd arg of
4186 INDEX_TO_CODE_POINT, as that's what it expects.
4187 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
4188 * charset.h (DECODE_CHAR): Return int, not unsigned;
4189 this is what was intended anyway, and it avoids undefined behavior.
4190 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
4191 integer-overflow issues.
4192 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
4193 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
4194 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
4195 * chartab.c (Fmake_char_table, Fset_char_table_range)
4196 (uniprop_get_decoder, uniprop_get_encoder):
4197 Don't assume fixnum fits in int.
4198 * cmds.c (move_point): New function, that does the gist of
4199 Fforward_char and Fbackward_char, but does so while checking
4200 for integer overflow more accurately.
c96e5d6a 4201 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
4202 (Fforward_line, Fend_of_line, internal_self_insert)
4203 (internal_self_insert):
4204 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4205 Fix a FIXME, by checking for integer overflow when calculating
4206 target_clm and actual_clm.
4207 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 4208 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
4209 (ASSURE_DESTINATION, coding_alloc_by_realloc)
4210 (coding_alloc_by_making_gap, alloc_destination)
4211 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
4212 (encode_coding_utf_16, detect_coding_emacs_mule)
4213 (decode_coding_emacs_mule, encode_coding_emacs_mule)
4214 (detect_coding_iso_2022, decode_coding_iso_2022)
4215 (encode_invocation_designation, encode_designation_at_bol)
4216 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4217 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
4218 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
4219 (encode_coding_ccl, encode_coding_raw_text)
4220 (detect_coding_charset, decode_coding_charset)
4221 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
4222 (produce_composition, produce_charset, produce_annotation)
4223 (decode_coding, handle_composition_annotation)
4224 (handle_charset_annotation, consume_chars, decode_coding_gap)
4225 (decode_coding_object, encode_coding_object, detect_coding_system)
4226 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
4227 (code_convert_region, code_convert_string)
8f50130c
PE
4228 (Fdefine_coding_system_internal)
4229 (coding_set_source, coding_set_destination):
d311d28c
PE
4230 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4231 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
4232 (Fdefine_coding_system_internal):
4233 Don't assume fixnums fit in int.
4234 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 4235 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
4236 (Funencodable_char_position, Fcheck_coding_systems_region)
4237 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 4238 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 4239 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 4240 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 4241 Don't access memory outside of the args array.
d311d28c 4242 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
4243 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
4244 result of ENCODE_CHAR.
d311d28c
PE
4245 * coding.h: Adjust decls to match defn changes elsewhere.
4246 (struct coding_system):
4247 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4248 * composite.c (get_composition_id, find_composition)
4249 (run_composition_function, update_compositions)
4250 (compose_text, composition_gstring_put_cache)
4251 (composition_gstring_p, composition_gstring_width)
4252 (fill_gstring_header, fill_gstring_body, autocmp_chars)
4253 (composition_compute_stop_pos, composition_reseat_it)
4254 (composition_update_it, struct position_record)
4255 (find_automatic_composition, composition_adjust_point)
4256 (Fcomposition_get_gstring, Ffind_composition_internal):
4257 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4258 (update_compositions):
4259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4260 * composite.h: Adjust decls to match defn changes elsewhere.
4261 (struct composition):
4262 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4263 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
4264 Do not attempt to compute the address of the object just before a
4265 buffer; this is not portable.
4266 (Faref, Faset):
4267 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4268 (Faset): Use int, not EMACS_INT, where int is wide enough.
4269 (Fstring_to_number): Don't assume fixnums fit in int.
4270 (Frem): Don't assume arg is nonnegative.
4271 * dbusbind.c (xd_append_arg): Check for integers out of range.
4272 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 4273 (extract_signed, extract_unsigned): New functions.
243e0530
PE
4274 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
4275 (xd_get_connection_references): Return ptrdiff_t, not int.
4276 All uses changed.
4277 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
4278 (xd_read_message_1):
4279 Use int, not unsigned, where the dbus API uses int.
4280 (Fdbus_message_internal): Don't overflow mtype.
4281 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
4282 * dired.c (directory_files_internal, file_name_completion, scmp)
4283 (file_name_completion_stat):
4284 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4285 (file_name_completion): Don't overflow matchcount.
4286 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
4287 * dispextern.h: Adjust decls to match defn changes elsewhere.
4288 (struct text_pos, struct glyph, struct bidi_saved_info)
4289 (struct bidi_string_data, struct bidi_it, struct composition_it)
4290 (struct it):
4291 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4292 (struct display_pos, struct composition_it, struct it):
4293 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4294 * dispnew.c (increment_matrix_positions)
4295 (increment_row_positions, mode_line_string)
4296 (marginal_area_string):
4297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 4298 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
4299 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4300 (duration_to_sec_usec): New function, to check for overflow better.
4301 (Fsleep_for, sit_for): Use it.
4302 * doc.c (get_doc_string, store_function_docstring):
4303 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4304 (get_doc_string, Fsnarf_documentation):
4305 Use int, not EMACS_INT, where int is wide enough.
4306 (get_doc_string):
4307 Use SAFE_ALLOCA, not alloca.
4308 Check for overflow when converting EMACS_INT to off_t.
4309 * doprnt.c (doprnt):
4310 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4311 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
4312 Don't assume uid_t fits into fixnum.
4313 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
4314 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
4315 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
4316 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
4317 (general_insert_function)
4318 (Finsert_char, make_buffer_string, make_buffer_string_both)
4319 (update_buffer_properties, Fbuffer_substring)
4320 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
4321 (Fsubst_char_in_region, check_translation)
4322 (Ftranslate_region_internal, save_restriction_restore, Fformat)
4323 (transpose_markers, Ftranspose_regions):
4324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4325 (clip_to_bounds): Move to lisp.h as an inline function).
4326 (Fconstrain_to_field): Don't assume integers are nonnegative.
4327 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
4328 (Fsubst_char_in_region, Fsave_restriction):
4329 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4330 (Femacs_pid): Don't assume pid_t fits into fixnum.
4331 (lo_time): Use int, not EMACS_INT, when int suffices.
4332 (lisp_time_argument): Check for usec out of range.
4333 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
4334 (Fuser_login_name, Fuser_full_name): Signal an error
4335 if a uid argument is out of range, rather than relying on
4336 undefined behavior.
c8d5c857
PE
4337 (Fformat_time_string): Remove now-unnecessary check.
4338 lisp_time_argument checks for out-of-range usec now.
243e0530 4339 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
4340 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
4341 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
4342 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
4343 (init_cmdargs, Fdump_emacs):
4344 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4345 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
4346 the bottom (typically) 32 bits of the fixnum.
4347 * eval.c (specpdl_size, call_debugger):
4348 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4349 (when_entered_debugger, Fbacktrace_debug):
4350 Don't assume fixnum can fit in int.
4351 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
4352 the object just before a buffer; this is not portable.
4353 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
4354 (grow_specpdl, unbind_to):
4355 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4356 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
4357 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 4358 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
4359 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
4360 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
4361 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4362 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
4363 (a_write, e_write):
4364 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4365 (Fcopy_file, non_regular_nbytes, read_non_regular)
4366 (Finsert_file_contents):
4367 Use int, not EMACS_INT, where int is wide enough.
4368 (READ_BUF_SIZE): Verify that it fits in int.
4369 (Finsert_file_contents): Check that counts are in proper range,
4370 rather than assuming fixnums fit into ptrdiff_t etc.
4371 Don't assume fixnums fit into int.
125b3835 4372 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
4373 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
4374 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
4375 (string_char_to_byte, string_byte_to_char)
4376 (string_make_multibyte, string_to_multibyte)
4377 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
4378 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
4379 (substring_both, Fdelete, internal_equal, Ffillarray)
4380 (Fclear_string, mapcar1)
4381 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
4382 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
4383 (larger_vector, make_hash_table, maybe_resize_hash_table)
4384 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
4385 (Fmaphash, secure_hash):
4386 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4387 (concat): Check for string index and length overflow.
4388 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
4389 (Frequire):
4390 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4391 (larger_vector): New API (vec, incr_min, size_max) replaces old
4392 one (vec, new_size, init). This catches size overflow.
4393 INIT was removed because it was always Qnil.
4394 All callers changed.
4395 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
4396 the upper bound on a hash table index size.
4397 (make_hash_table, maybe_resize_hash_table): Use it.
4398 (secure_hash): Computer start_byte and end_byte only after
4399 they're known to be in ptrdiff_t range.
4400 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
4401 (Ffont_get_glyphs, Ffont_at):
4402 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4403 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
4404 (Flist_fonts, Fopen_font):
4405 Don't assume fixnum can fit in int.
4406 (check_gstring): Don't assume index can fit in int.
4407 (font_match_p): Check that fixnum is a character, not a nonnegative
4408 fixnum, since the later code needs to stuff it into an int.
4409 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
4410 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
4411 conversion overflow issues.
4412 (Fopen_font): Check for integer out of range.
4413 (Ffont_get_glyphs): Don't assume index can fit in int.
4414 * font.h: Adjust decls to match defn changes elsewhere.
4415 * fontset.c (reorder_font_vector): Redo score calculation to avoid
4416 integer overflow.
4417 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
4418 printmax_t, where ptrdiff_t is wide enough.
4419 (Finternal_char_font):
4420 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4421 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
4422 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
4423 (Fset_frame_position, x_set_frame_parameters)
4424 (x_set_line_spacing, x_set_border_width)
4425 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
4426 Check that fixnums are in proper range for system types.
4427 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
4428 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4429 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
4430 Use SAFE_ALLOCA_LISP, not alloca.
4431 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
4432 intptr_t is wide enough.
4433 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
4434 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
4435 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
4436 Check for fixnum out of range.
4437 * ftfont.c (ftfont_list): Don't assume index fits in int.
4438 Check that fixnums are in proper range for system types.
4439 (ftfont_shape_by_flt):
4440 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
4441 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4442 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4443 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
4444 Check that fixnums are in proper range for system types.
4445 * gnutls.h: Adjust decls to match defn changes elsewhere.
4446 * gtkutil.c (xg_dialog_run):
4447 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4448 (update_frame_tool_bar):
4449 Check that fixnums are in proper range for system types.
4450 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 4451 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
4452 * indent.c (last_known_column, last_known_column_point):
4453 (current_column_bol_cache):
4454 (skip_invisible, current_column, check_display_width):
4455 (check_display_width, scan_for_column, current_column_1)
4456 (Findent_to, Fcurrent_indentation, position_indentation)
4457 (indented_beyond_p, Fmove_to_column, compute_motion):
4458 (Fcompute_motion, Fvertical_motion):
4459 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4460 (last_known_column_modified): Use EMACS_INT, not int.
4461 (check_display_width):
4462 (Fcompute_motion):
4463 Check that fixnums and floats are in proper range for system types.
4464 (compute_motion): Don't assume index or fixnum fits in int.
4465 (compute_motion, Fcompute_motion):
4466 Use int, not EMACS_INT, when it is wide enough.
4467 (vmotion): Omit local var start_hpos that is always 0; that way
4468 we don't need to worry about overflow in expressions involving it.
4469 * indent.h: Adjust decls to match defn changes elsewhere.
4470 (struct position):
4471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4472 Use int, not EMACS_INT, where int is wide enough.
4473 Remove unused members ovstring_chars_done and tab_offset;
4474 all uses removed.
4475 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
4476 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
4477 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
4478 (make_gap, copy_text, insert, insert_and_inherit)
4479 (insert_before_markers, insert_before_markers_and_inherit)
4480 (insert_1, count_combining_before, count_combining_after)
4481 (insert_1_both, insert_from_string)
4482 (insert_from_string_before_markers, insert_from_string_1)
4483 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
4484 (adjust_after_replace, adjust_after_insert, replace_range)
4485 (replace_range_2, del_range, del_range_1, del_range_byte)
4486 (del_range_both, del_range_2, modify_region)
4487 (prepare_to_modify_buffer, signal_before_change)
4488 (signal_after_change, Fcombine_after_change_execute):
4489 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4490 * intervals.c (traverse_intervals, rotate_right, rotate_left)
4491 (balance_an_interval, split_interval_right, split_interval_left)
4492 (find_interval, next_interval, update_interval)
4493 (adjust_intervals_for_insertion, delete_node, delete_interval)
4494 (interval_deletion_adjustment, adjust_intervals_for_deletion)
4495 (static_offset_intervals, offset_intervals)
4496 (merge_interval_right, merge_interval_left, make_new_interval)
4497 (graft_intervals_into_buffer, temp_set_point_both)
4498 (temp_set_point, set_point, adjust_for_invis_intang)
4499 (set_point_both, move_if_not_intangible, get_property_and_range)
4500 (get_local_map, copy_intervals, copy_intervals_to_string)
4501 (compare_string_intervals, set_intervals_multibyte_1):
4502 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4503 * intervals.h: Adjust decls to match defn changes elsewhere.
4504 (struct interval):
4505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4506 * keyboard.c (this_command_key_count, this_single_command_key_start)
4507 (before_command_key_count, before_command_echo_length, echo_now)
4508 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
4509 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
4510 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
4511 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
4512 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4513 (last_non_minibuf_size, last_point_position, echo_truncate)
4514 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
4515 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
4516 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
4517 (stuff_buffered_input):
4518 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4519 (last_auto_save, command_loop_1, read_char):
4520 Use EMACS_INT, not int, to avoid integer overflow.
4521 (record_char): Avoid overflow in total_keys computation.
4522 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
4523 * keyboard.h: Adjust decls to match defn changes elsewhere.
4524 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
4525 (Fkey_description, Fdescribe_vector, Flookup_key):
4526 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4527 (click_position): New function, to check that positions are in range.
4528 (Fcurrent_active_maps):
4529 (describe_command):
4530 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4531 (Faccessible_keymaps, Fkey_description):
4532 (preferred_sequence_p):
4533 Don't assume fixnum can fit into int.
4534 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
4535 Check for integer overflow in size calculations.
4536 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
4537 avoid mishandling large integers.
4538 * lisp.h: Adjust decls to match defn changes elsewhere.
4539 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
4540 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
4541 (struct Lisp_Marker):
4542 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4543 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
4544 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
4545 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
4546 All callers changed.
4547 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
4548 Assume the arg has valid form, since it always does.
4549 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
4550 unsigned integer system type.
4551 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
4552 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
4553 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4554 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
4555 (duration_to_sec_usec): New decl.
4556 * lread.c (read_from_string_index, read_from_string_index_byte)
4557 (read_from_string_limit, readchar, unreadchar, openp)
4558 (read_internal_start, read1, oblookup):
4559 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4560 (Fload, readevalloop, Feval_buffer, Feval_region):
4561 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4562 (openp): Check for out-of-range argument to 'access'.
4563 (read1): Use int, not EMACS_INT, where int is wide enough.
4564 Don't assume fixnum fits into int.
6efdadfd 4565 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
4566 (read_filtered_event): Use duration_to_sec_usec
4567 to do proper overflow checking on durations.
d311d28c
PE
4568 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
4569 in size calculation.
4570 (Fexecute_kbd_macro):
4571 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4572 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
4573 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
4574 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
4575 (set_marker_both, set_marker_restricted_both, marker_position)
4576 (marker_byte_position, Fbuffer_has_markers_at):
4577 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4578 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 4579 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
4580 It now merely ensures that the menu is large enough, without
4581 necessarily growing it, as this avoids some integer overflow issues.
4582 All callers changed.
4583 (keymap_panes, parse_single_submenu, Fx_popup_menu):
4584 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4585 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
4586 Use SAFE_ALLOCA_LISP, not alloca.
4587 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
4588 to EMACS_INT. Check that fixnums are in proper range for system types.
4589 * minibuf.c (minibuf_prompt_width, string_to_object)
4590 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
4591 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
4592 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4593 (get_minibuffer, read_minibuf_unwind):
4594 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4595 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
4596 this simplifies overflow checking. All callers changed.
4597 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
4598 (Ftest_completion):
4599 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4600 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
4601 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
4602 Check that fixnums are in proper range for system types.
4603 (Fx_create_frame, Fx_show_tip):
4604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4605 * nsfont.m (ns_findfonts, nsfont_list_family):
4606 Don't assume fixnum fits in long.
4607 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
4608 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4609 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
4610 wide enough.
17fdb222 4611 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
4612 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4613 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
4614 (PRINTDECLARE, PRINTPREPARE):
4615 (strout, print_string):
4616 (print, print_preprocess, print_check_string_charset_prop)
4617 (print_object):
4618 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4619 (PRINTDECLARE):
4620 (temp_output_buffer_setup, Fprin1_to_string, print_object):
4621 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4622 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 4623 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 4624 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
4625 (print_error_message): Use SAFE_ALLOCA, not alloca.
4626 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
4627 (print_depth, new_backquote_output, print_number_index):
4628 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
4629 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
4630 (Fset_process_window_size, Fformat_network_address)
4631 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 4632 (sigchld_handler):
d311d28c 4633 Check that fixnums are in proper range for system types.
d44287d4 4634 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
4635 Check for process-ids out of pid_t range rather than relying on
4636 undefined behavior.
e4d81efc 4637 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
4638 (Fformat_network_address, read_process_output, send_process)
4639 (Fprocess_send_region, status_notify):
4640 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4641 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
4642 (wait_reading_process_output, read_process_output, exec_sentinel):
4643 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4644 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
4645 (Faccept_process_output): Use duration_to_sec_usec to do proper
4646 overflow checking on durations.
dde14581
PE
4647 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
4648 Don't assume pid_t fits in int.
02481186
PE
4649 * process.h (struct Lisp_Process): Members tick and update_tick
4650 are now of type EMACS_INT, not int.
b62b53e8
PE
4651 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
4652 configured --with-wide-int.
d311d28c
PE
4653 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
4654 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
4655 * search.c (looking_at_1, string_match_1):
4656 (fast_string_match, fast_c_string_match_ignore_case)
4657 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
4658 (scan_newline, find_before_next_newline, search_command)
4659 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
4660 (set_search_regs, wordify):
4661 (Freplace_match):
4662 (Fmatch_data):
4663 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4664 (string_match_1, search_buffer, set_search_regs):
4665 (Fmatch_data):
4666 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4667 (wordify): Check for overflow in size calculation.
4668 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
4669 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
4670 Check that fixnums are in proper range for system types.
4671 * sound.c (struct sound_device)
4672 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
4673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4674 (Fplay_sound_internal):
4675 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 4676 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
4677 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
4678 (Fparse_partial_sexp):
4679 Don't assume fixnums can fit in int.
4680 (struct lisp_parse_state, find_start_pos, find_start_value)
4681 (find_start_value_byte, find_start_begv)
4682 (update_syntax_table, char_quoted, dec_bytepos)
4683 (find_defun_start, prev_char_comend_first, back_comment):
4684 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
4685 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
4686 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4687 (Finternal_describe_syntax_value): Check that match_lisp is a
4688 character, not an integer, since the code stuffs it into int.
4689 (scan_words, scan_sexps_forward):
4690 Check that fixnums are in proper range for system types.
4691 (Fforward_word):
4692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4693 (scan_sexps_forward):
4694 Use CHARACTERP, not INTEGERP, since the value must fit into int.
4695 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
4696 * syntax.h: Adjust decls to match defn changes elsewhere.
4697 (struct gl_state_s):
4698 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
4699 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
4700 MOST_POSITIVE_FIXNUM.
d311d28c
PE
4701 * sysdep.c (wait_for_termination_1, wait_for_termination)
4702 (interruptible_wait_for_termination, mkdir):
4703 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
4704 (emacs_read, emacs_write):
4705 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
4706 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
4707 and double all fit in int.
d311d28c
PE
4708 * term.c (set_tty_color_mode):
4709 Check that fixnums are in proper range for system types.
4710 * termhooks.h (struct input_event):
4711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4712 * textprop.c (validate_interval_range, interval_of)
4713 (Fadd_text_properties, set_text_properties_1)
4714 (Fremove_text_properties, Fremove_list_of_text_properties)
4715 (Ftext_property_any, Ftext_property_not_all)
4716 (copy_text_properties, text_property_list, extend_property_ranges)
4717 (verify_interval_modification):
4718 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4719 (Fnext_single_char_property_change)
4720 (Fprevious_single_char_property_change):
4721 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
4722 (copy_text_properties):
4723 Check for integer overflow in index calculation.
d311d28c
PE
4724 * undo.c (last_boundary_position, record_point, record_insert)
4725 (record_delete, record_marker_adjustment, record_change)
4726 (record_property_change):
4727 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4728 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
4729 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4730 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4731 (Fx_hide_tip, Fx_file_dialog):
4732 * w32menu.c (set_frame_menubar):
4733 Use ptrdiff_t, not int, for consistency with rest of code.
4734 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
4735 (select_window, Fdelete_other_windows_internal)
4736 (window_scroll_pixel_based, window_scroll_line_based)
4737 (Frecenter, Fset_window_configuration):
4738 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4739 (Fset_window_hscroll, run_window_configuration_change_hook)
4740 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 4741 (Fscroll_other_window, Frecenter):
d311d28c
PE
4742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4743 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
4744 Don't assume fixnum fits in int.
4745 (Fset_window_scroll_bars):
4746 Check that fixnums are in proper range for system types.
4747 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
4748 (string_pos, c_string_pos, number_of_chars, init_iterator)
4749 (in_ellipses_for_invisible_text_p, init_from_display_pos)
4750 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
4751 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
4752 (face_before_or_after_it_pos, handle_invisible_prop)
4753 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
4754 (display_prop_intangible_p, string_buffer_position_lim)
4755 (string_buffer_position, handle_composition_prop, load_overlay_strings)
4756 (get_overlay_strings_1, get_overlay_strings)
4757 (iterate_out_of_display_property, forward_to_next_line_start)
4758 (back_to_previous_visible_line_start, reseat, reseat_to_string)
4759 (get_next_display_element, set_iterator_to_next)
4760 (get_visually_first_element, compute_stop_pos_backwards)
4761 (handle_stop_backwards, next_element_from_buffer)
4762 (move_it_in_display_line_to, move_it_in_display_line)
4763 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4764 (add_to_log, message_dolog, message_log_check_duplicate)
4765 (message2, message2_nolog, message3, message3_nolog
4766 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
4767 (current_message_1, truncate_echo_area, truncate_message_1)
4768 (set_message, set_message_1, store_mode_line_noprop)
4769 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
4770 (text_outside_line_unchanged_p, check_point_in_composition)
4771 (reconsider_clip_changes)
4772 (redisplay_internal, set_cursor_from_row, try_scrolling)
4773 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
4774 (redisplay_window, find_last_unchanged_at_beg_row)
4775 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
4776 (trailing_whitespace_p, find_row_edges, display_line)
4777 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
4778 (display_mode_element, store_mode_line_string)
4779 (pint2str, pint2hrstr, decode_mode_spec)
4780 (display_count_lines, display_string, draw_glyphs)
4781 (x_produce_glyphs, x_insert_glyphs)
4782 (rows_from_pos_range, mouse_face_from_buffer_pos)
4783 (fast_find_string_pos, mouse_face_from_string_pos)
4784 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4785 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4786 (safe_call, init_from_display_pos, handle_fontified_prop)
4787 (handle_single_display_spec, load_overlay_strings)
4788 (with_echo_area_buffer, setup_echo_area_for_printing)
4789 (display_echo_area, echo_area_display)
4790 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4791 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4792 (redisplay_window, dump_glyph_row, display_mode_line)
4793 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4794 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4795 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4796 (handle_single_display_spec, build_desired_tool_bar_string)
4797 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4798 (get_specified_cursor_type):
4799 Check that fixnums are in proper range for system types.
4800 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4801 (Flookup_image_map):
4802 Don't assume fixnums fit in int.
4803 (compare_overlay_entries):
4804 Avoid mishandling comparisons due to subtraction overflow.
4805 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4806 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4807 (handle_tool_bar_click):
4808 Use int, not unsigned, since we prefer signed and the signedness
4809 doesn't matter here.
4810 (get_next_display_element, next_element_from_display_vector):
4811 Use int, not EMACS_INT, when int is wide enough.
4812 (start_hourglass): Use duration_to_sec_usec to do proper
4813 overflow checking on durations.
4814 * xfaces.c (Fbitmap_spec_p):
4815 Check that fixnums are in proper range for system types.
4816 (compare_fonts_by_sort_order):
4817 Avoid mishandling comparisons due to subtraction overflow.
4818 (Fx_family_fonts, realize_basic_faces):
4819 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4820 (Fx_family_fonts):
4821 Don't assume fixnum fits in int.
4822 Use SAFE_ALLOCA_LISP, not alloca.
4823 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4824 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4825 (face_at_buffer_position, face_for_overlay_string)
4826 (face_at_string_position):
4827 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4828 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4829 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4830 (Fx_show_tip):
4831 Check that fixnums are in proper range for system types.
4832 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4833 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4834 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4835 (Fx_change_window_property): Don't assume fixnums fit in int.
4836 * xfont.c (xfont_chars_supported):
4837 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4838 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4839 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4841 * xml.c (parse_region):
4842 * xrdb.c (magic_file_p):
4843 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4844 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4845 (x_get_local_selection, x_reply_selection_request)
4846 (x_handle_selection_request, wait_for_property_change):
4847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4848 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4849 short is wide enough.
4850 (x_send_client_event): Don't assume fixnum fits in int.
4851 * xterm.c (x_x_to_emacs_modifiers):
4852 Don't assume EMACS_INT overflows nicely into int.
4853 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4854 may come from Lisp.
4855 (handle_one_xevent): NATNUMP can eval its arg twice.
4856 (x_connection_closed):
4857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4858 * xterm.h: Adjust decls to match defn changes elsewhere.
4859 (struct scroll_bar): Use struct vectorlike_header
4860 rather than rolling our own approximation.
4861 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4862
c6574eb5
GM
48632012-05-25 Glenn Morris <rgm@gnu.org>
4864
4865 * lisp.mk (lisp): Update for more files being compiled now.
4866
e8d32c7e
SM
48672012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4868
48def666
SM
4869 * lread.c: Remove `read_pure' which makes no difference.
4870 (read_pure): Remove var.
4871 (unreadpure): Remove function.
4872 (readevalloop): Don't call read_list with -1 flag.
4873 (read1, read_vector): Don't test read_pure any more.
4874 (read_list): Simplify.
4875
e8d32c7e
SM
4876 * fileio.c, character.h: Minor style tweaks.
4877
4b2addb7
DA
48782012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4879
4880 * window.h (clip_changed): Remove useless declaration.
4881
584461b2
JB
48822012-05-22 Juanma Barranquero <lekktu@gmail.com>
4883
4884 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4885 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4886
34374650
PE
48872012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4888
4889 Remove src/m/*.
4890 This directory predates autoconf and is no longer needed nowadays.
4891 Move its few remaining bits of functionality to where they're needed.
4892 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4893 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4894 * m/template.h: Remove.
4895 * Makefile.in (M_FILE): Remove. All uses removed.
4896 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4897 * lisp.h (USE_LSB_TAG):
4898 * mem-limits.h (EXCEEDS_LISP_PTR):
4899 Use VAL_MAX, not VALBITS, in #if.
4900 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4901 (EMACS_UINT): Define unconditionally now.
4902 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4903 (BITS_PER_EMACS_INT): New constants, replacing
4904 what used to be in config.h, but not useful in #if.
4905 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4906 define them any more.
4907 (VAL_MAX): New macro.
4908 (VALMASK): Use it.
4909 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4910 BITS_PER_EMACS_INT, in #if.
4911 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4912 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4913 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4914 * s/ms-w32.h (DATA_START):
4915 Move here from removed file m/intel386.h.
4916 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4917 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4918
261cb4bb
PE
49192012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4920
4921 Assume C89 or later.
4922 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4923 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4924 (xrealloc):
4925 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4926 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4927 * textprop.c, tparam.c (NULL): Remove.
4928 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4929 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4930 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4931 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4932 * xterm.c (input_signal_count): Assume volatile works.
4933
ff23cd9f
KB
49342012-05-21 Ken Brown <kbrown@cornell.edu>
4935
4936 * xgselect.c (xg_select): Fix first argument in call to 'select'
4937 (bug#11508).
4938
1b170bc6
KB
49392012-05-20 Ken Brown <kbrown@cornell.edu>
4940
4941 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4942 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4943
b2f4d39f
KB
49442012-05-19 Ken Brown <kbrown@cornell.edu>
4945
4946 * xfns.c (x_in_use): Remove `static' qualifier.
4947 * xterm.h (x_in_use): Declare.
4948 * xgselect.c: Include xterm.h.
4949 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4950 and `display_arg' (bug#9754).
4951
003fdae2
PE
49522012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4953
9232a6d9
PE
4954 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4955
003fdae2
PE
4956 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4957 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4958
784b56e2
EZ
49592012-05-18 Eli Zaretskii <eliz@gnu.org>
4960
4961 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4962
4963 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4964 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4965
4966 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4967 reference to image_cache->refcount.
4968 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4969
a0a79cde
JL
49702012-05-17 Juri Linkov <juri@jurta.org>
4971
4972 * search.c (Fword_search_regexp, Fword_search_backward)
4973 (Fword_search_forward, Fword_search_backward_lax)
4974 (Fword_search_forward_lax): Move functions to isearch.el
4975 (bug#10145, bug#11381).
4976
b0572523
PE
49772012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4978
4979 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4980
9660f5fc
SM
49812012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4982
4983 * lread.c (init_obarray): Declare Qt and Qnil as special.
4984
4374de83
GM
49852012-05-14 Glenn Morris <rgm@gnu.org>
4986
4987 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4988 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4989
dc44c39a
PE
49902012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4991
078c97cb
PE
4992 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4993
dc44c39a
PE
4994 * unexaix.c: Port to more-recent AIX compilers.
4995 (report_error, report_error_1, make_hdr, copy_sym)
4996 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4997 Make arguments const char *, not char *, to avoid violations of C
4998 standard and to fix some AIX warnings reported by Gilles Pion.
4999
e18afed7 50002012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
5001
5002 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
5003 already have overlays loaded.
5004 (handle_single_display_spec): Before returning without displaying
5005 fringe bitmap, synchronize the bidi iterator with the main display
5006 iterator, by calling iterate_out_of_display_property.
5007 (iterate_out_of_display_property): Detect buffer iteration by
5008 testing that it->string is a Lisp string.
5009 (get_next_display_element): When the current object is exhausted,
5010 and there's something on it->stack, call set_iterator_to_next to
5011 proceed with what's on the stack, instead of returning zero.
5012 (set_iterator_to_next): If called at the end of a Lisp string,
5013 proceed to consider_string_end without incrementing string
5014 position. Don't increment display vector index past the end of
5015 the display vector. (Bug#11417)
c8fb9dc6
EZ
5016 (pos_visible_p): Don't report a position visible when move_it_to
5017 stopped at the last line of window, which happens to be scanned
5018 backwards by the bidi iteration. (Bug#11464)
ac268e67 5019
e18afed7 50202012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
5021
5022 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
5023 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
5024 are on a TTY, and thus unable to display on the fringes.
5025 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
5026 so we need to signal to the caller that this is a "replacing"
5027 display spec. This fixes display when the spec is invalid or we
5028 are on a TTY.
5029
e18afed7 50302012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
5031
5032 * unexaix.c (make_hdr): Fix typo in prototype.
5033 This bug broke the build on AIX. Problem reported by Gilles Pion.
5034
9d0a235a
MA
50352012-05-14 Michael Albinus <michael.albinus@gmx.de>
5036
5037 * keyboard.c (kbd_buffer_get_event): Read special events also in
5038 batch mode. (Bug#11415)
5039
9e6b06ed
GM
50402012-05-12 Glenn Morris <rgm@gnu.org>
5041
5042 * ns.mk: Update for ns_appbindir no longer having trailing "/".
5043
c1a1d7a3
EZ
50442012-05-12 Eli Zaretskii <eliz@gnu.org>
5045
5046 * lisp.mk (lisp): Add newcomment.elc.
5047
3fe7cdc8
GM
50482012-05-12 Glenn Morris <rgm@gnu.org>
5049
5050 * Makefile.in (MKDIR_P): New, set by configure.
5051 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
5052
53f7d2c0
PE
50532012-05-11 Paul Eggert <eggert@cs.ucla.edu>
5054
5055 Remove unused function hourglass_started.
5056 * dispextern.h (hourglass_started):
5057 * w32fns.c (hourglass_started):
5058 * xdisp.c (hourglass_started): Remove.
5059
75aafb17
JB
50602012-05-10 Juanma Barranquero <lekktu@gmail.com>
5061
5062 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
5063 Update dependencies.
5064
12959e8e
PE
50652012-05-10 Paul Eggert <eggert@cs.ucla.edu>
5066
97107e2e
PE
5067 * xgselect.c (xg_select): Put maxfds+1 into a var.
5068 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
5069
12959e8e
PE
5070 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
5071
836d29b3
DA
50722012-05-10 Dave Abrahams <dave@boostpro.com>
5073
5074 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
5075 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
5076
5cb67954
MA
50772012-05-09 Michael Albinus <michael.albinus@gmx.de>
5078
5079 * dbusbind.c (xd_registered_buses): New internal Lisp object.
5080 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
5081 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
5082 Initialize xd_registered_buses.
5083
3478ec45
PE
50842012-05-09 Paul Eggert <eggert@cs.ucla.edu>
5085
b263a6b0
PE
5086 Untag more efficiently if USE_LSB_TAG.
5087 This is based on a proposal by YAMAMOTO Mitsuharu in
5088 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
5089 For an admittedly artificial (nth 8000 longlist) benchmark on
5090 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
5091 Emacs's overall text size by 1%.
5092 * lisp.h (XUNTAG): New macro.
5093 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
5094 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
5095 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
5096 * eval.c (Fautoload):
5097 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
5098 * frame.h (XFRAME): Use XUNTAG.
5099
3478ec45
PE
5100 Port recent dbusbind.c changes to 32-bit --with-wide-int.
5101 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
5102 Remove unportable assumptions about print widths of types like
5103 dbus_uint32_t.
5104 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
5105 intptr_t when converting between pointer and integer, to avoid GCC
5106 warnings about wrong width.
5107
666b903b 51082012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
5109
5110 * w32proc.c (new_child): Force Windows to reserve only 64KB of
5111 stack for each reader_thread, instead of defaulting to 8MB
5112 determined by the linker. This avoids failures in creating
5113 subprocesses on Windows 7, see the discussion in this thread:
5114 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
5115
b120cc17
JC
51162012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
5117
5118 Fix up display of the *Minibuf-0* buffer in the mini window.
5119 * keyboard.c (read_char): Don't clear the echo area if there's no
5120 message to clear.
5121 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 5122 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 5123
9a4b36f8
MA
51242012-05-07 Michael Albinus <michael.albinus@gmx.de>
5125
5126 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
5127 batch mode.
5128
e5f9458f
CY
51292012-05-06 Chong Yidong <cyd@gnu.org>
5130
5131 * lisp.mk (lisp): Update.
5132
eceeb5fc 51332012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
5134
5135 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
5136
71873e2b
SM
51372012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
5138
5139 * data.c (PUT_ERROR): New macro.
5140 (syms_of_data): Use it. Add new error type `user-error'.
5141 * undo.c (user_error): New function.
5142 (Fprimitive_undo): Use it.
5143 * print.c (print_error_message): Adjust print style for `user-error'.
5144 * keyboard.c (user_error): New function.
5145 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
5146
ab0fa4e4
PE
51472012-05-03 Paul Eggert <eggert@cs.ucla.edu>
5148
5149 Do not limit current-time-string to years 1000..9999.
5150 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
5151 (Fcurrent_time_string): Support any year that is supported by the
5152 underlying localtime representation. Don't use asctime, as it
5153 has undefined behavior for years outside the range -999..9999.
5154
7ed806a7
PE
51552012-05-02 Paul Eggert <eggert@cs.ucla.edu>
5156
5157 Fix race conditions involving setenv, gmtime, localtime, asctime.
5158 Without this fix, interrupts could mess up code that uses these
5159 nonreentrant functions, since setting TZ invalidates existing
5160 tm_zone or tzname values, and since most of these functions return
5161 pointers to static storage.
5162 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
5163 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
5164 Grow the critical sections to include not just invoking
5165 localtime/gmtime, but also accessing these functions' results
5166 including their tm_zone values if any, and any related TZ setting.
5167 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
5168 so that the struct tm is saved in the critical section.
5169 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
5170 motivated by the fact that memory allocation needs to be outside
5171 the critical section.
5172
0c16dfed
DA
51732012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
5174
5175 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
5176 with RESET_INTERVAL.
5177
5178 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
5179 Remove duplicated buffer name initialization.
5180
3f83ace8
JM
51812012-05-02 Jim Meyering <jim@meyering.net>
5182
5183 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
5184
c7b8541e
JM
5185 * xfns.c (x_window): Use xstrdup (Bug#11375).
5186
90207a15 51872012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
5188
5189 * xdisp.c (pos_visible_p): If already at a newline from the
5190 display string before the 'while' loop, don't walk back the glyphs
5191 from it3.glyph_row. Solves assertion violation when the display
5192 string begins with a newline (egg.el). (Bug#11367)
5193
b593d6a9
AH
51942012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
5195
5196 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
5197 Move to simple.el.
5198
4737362e
GM
51992012-05-01 Glenn Morris <rgm@gnu.org>
5200
99cf43f9
GM
5201 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
5202 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
5203 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
5204 All were removed before 23.1.
5205
9311dcff
GM
5206 * dispnew.c: Remove HAVE_LIBNCURSES test;
5207 it is always true on relevant platforms.
5208
4d5c6349
GM
5209 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
5210 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
5211
4737362e
GM
5212 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
5213
74dd3a6b
AS
52142012-04-30 Andreas Schwab <schwab@linux-m68k.org>
5215
5216 * .gdbinit (xpr): Remove checks for no longer existing misc types.
5217 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
5218 Remove.
5219
13c379ee
PE
52202012-04-28 Paul Eggert <eggert@cs.ucla.edu>
5221
5222 Do not avoid creating empty evaporating overlays (Bug#9642).
5223 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
5224 That is, do not delete an evaporating overlay if it becomes
5225 empty after its bounds are adjusted to fit within its buffer.
5226 This fix caused other problems, and I'm reverting it until we get
5227 to the bottom of them.
5228
a8e7d6d7 52292012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
5230
5231 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
5232
a8e7d6d7 52332012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
5234
5235 * xdisp.c (pos_visible_p): If the window start position is beyond
5236 ZV, start the display from buffer beginning. Prevents assertion
5237 violation in init_iterator when the minibuffer window is scrolled
5238 via the scroll bar.
5239
5240 * window.c (window_scroll_pixel_based): Likewise.
5241
a8e7d6d7 52422012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
5243
5244 * keymap.c (where_is_internal): Doc fix (Bug#10872).
5245
a8e7d6d7 52462012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
5247
5248 * fileio.c (Fcopy_file, Fset_file_selinux_context):
5249 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
5250
a8e7d6d7 52512012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 5252
b593d6a9
AH
5253 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
5254 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 5255
1c6900d9
EZ
52562012-04-26 Eli Zaretskii <eliz@gnu.org>
5257
4c3fa1d9
EZ
5258 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
5259 display element, check also the underlying string or buffer
5260 character. (Bug#11341)
5261
1c6900d9
EZ
5262 * w32menu.c: Include w32heap.h.
5263 (add_menu_item): If the call to AppendMenuW (via
5264 unicode_append_menu) fails, disable Unicode menus only if we are
5265 running on Windows 9X/Me.
5266
42bf8205
AS
52672012-04-24 Andreas Schwab <schwab@linux-m68k.org>
5268
5269 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
5270 (xgetint): Add missing shift for LSB tags.
5271
b1bac16e
MR
52722012-04-24 Martin Rudalics <rudalics@gmx.at>
5273
5274 * keyboard.c (read_char): Don't wipe echo area for select window
5275 events: These might get delayed via `mouse-autoselect-window'
5276 (Bug#11304).
5277
d69621cc
JB
52782012-04-24 Juanma Barranquero <lekktu@gmail.com>
5279
5280 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
5281 manipulation of :loaded-from data.
5282
02fd101b
JB
52832012-04-23 Juanma Barranquero <lekktu@gmail.com>
5284
5285 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
5286 now a cons (bug#11311).
5287
888bec30
PE
52882012-04-23 Paul Eggert <eggert@cs.ucla.edu>
5289
89a438bd
PE
5290 Do not create empty overlays with the evaporate property (Bug#9642).
5291 * buffer.c (Fmove_overlay): Delete an evaporating overlay
5292 if it becomes empty after its bounds are adjusted to fit within
5293 its buffer. Without this fix, in a nonempty buffer (let ((o
5294 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
5295 yields an empty overlay that has the evaporate property, which is
5296 not supposed to happen.
5297
1068fe4d
PE
5298 Fix minor GTK3 problems found by static checking.
5299 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5300 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5301 (struct _EmacsFixedClass, emacs_fixed_get_type):
5302 Move decls here from emacsgtkfixed.h, since they needn't be public.
5303 (emacs_fixed_get_type): Now static.
5304 (emacs_fixed_class_init): Omit unused local.
5305 (emacs_fixed_child_type): Remove; unused.
5306 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
5307 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
5308 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
5309 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
5310 (EMACS_FIXED_GET_CLASS): Remove; unused.
5311 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
5312
888bec30
PE
5313 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
5314 Problem reported by Juanma Barranquero for Windows -Wunused-function.
5315
de85e130
PE
53162012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5317
d0baac98 5318 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 5319 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
5320 (__malloc_size_t, __malloc_ptrdiff_t):
5321 Remove. All uses removed, replaced by the definiens if needed,
5322 since we can assume C89 or better now.
5323 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
5324 (protect_malloc_state, align, get_contiguous_space)
5325 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
5326 (malloc_atfork_handler_child, malloc_enable_thread)
5327 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
5328 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
5329 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
5330 (special_realloc, _realloc_internal_nolock, _realloc_internal)
5331 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
5332 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
5333 Define using prototypes, not old style.
5334 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
5335 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
5336 (align): Don't assume that signed integer overflow wraps around.
5337 Omit unused local var.
5338 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
5339 (_free_internal_nolock, memalign, mallochook, reallochook):
5340 Omit no-longer-needed casts.
5341 (valloc): Use getpagesize, not __getpagesize.
5342 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
5343 (struct hdr): The 'magic' member is now size_t, not unsigned long.
5344
de85e130
PE
5345 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
5346
dcbf5805
MA
53472012-04-22 Michael Albinus <michael.albinus@gmx.de>
5348
5349 Move functions from C to Lisp. Make non-blocking method calls
5350 the default. Implement further D-Bus standard interfaces.
5351
5352 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
5353 (QCdbus_request_name_allow_replacement)
5354 (QCdbus_request_name_replace_existing)
5355 (QCdbus_request_name_do_not_queue)
5356 (QCdbus_request_name_reply_primary_owner)
5357 (QCdbus_request_name_reply_in_queue)
5358 (QCdbus_request_name_reply_exists)
5359 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
5360 (QCdbus_registered_serial, QCdbus_registered_method)
5361 (QCdbus_registered_signal): New Lisp objects.
5362 (XD_DEBUG_MESSAGE): Use sizeof.
5363 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
5364 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
5365 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
5366 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
5367 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
5368 (xd_signature, xd_append_arg): Allow float for integer types.
5369 (xd_get_connection_references): New function.
b593d6a9
AH
5370 (xd_get_connection_address): Rename from xd_initialize.
5371 Return cached address.
dcbf5805
MA
5372 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
5373 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
5374 level.
5375 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 5376 Return number of refcounts.
dcbf5805
MA
5377 (Fdbus_get_unique_name): Make stronger parameter check.
5378 (Fdbus_message_internal): New defun.
5379 (Fdbus_call_method, Fdbus_call_method_asynchronously)
5380 (Fdbus_method_return_internal, Fdbus_method_error_internal)
5381 (Fdbus_send_signal, Fdbus_register_service)
5382 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
5383 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
5384 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
5385 (Vdbus_compiled_version, Vdbus_runtime_version)
5386 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
5387 (Vdbus_message_type_method_return, Vdbus_message_type_error)
5388 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
5389 (Vdbus_registered_buses, Vdbus_registered_objects_table):
5390 Adapt docstring.
dcbf5805 5391
52828e02
PE
53922012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5393
da05bc4c
PE
5394 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
5395 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
5396 Do not assume ptrdiff_t is the same width as 'int'.
5397
52828e02
PE
5398 * alloc.c: Handle unusual debugging option combinations.
5399 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
5400 since the two debugging options are incompatible.
5401 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
5402 is defined.
5403 (mem_init, mem_insert, mem_insert_fixup):
5404 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
5405 (NEED_MEM_INSERT): Remove; no longer needed.
5406
f01769f9
LL
54072012-04-22 Leo Liu <sdl.web@gmail.com>
5408
5409 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
5410
5790543d
PE
54112012-04-22 Paul Eggert <eggert@cs.ucla.edu>
5412
5413 * sysdep.c [__FreeBSD__]: Minor cleanups.
5414 (list_system_processes, system_process_attributes) [__FreeBSD__]:
5415 Use Emacs indenting style more consistently. Avoid some casts.
5416 Use 'double' consistently rather than mixing 'float' and 'double'.
5417
b91b7e4d
EW
54182012-04-21 Eduard Wiebe <usenet@pusto.de>
5419
b593d6a9
AH
5420 * sysdep.c (list_system_processes, system_process_attributes):
5421 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 5422
6114eb15
AS
54232012-04-21 Andreas Schwab <schwab@linux-m68k.org>
5424
5425 * lisp.mk (lisp): Update.
5426
2f38dff7
PE
54272012-04-20 Paul Eggert <eggert@cs.ucla.edu>
5428
5429 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
5430 It is never used otherwise.
5431
4ae29f89
SM
54322012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
5433
5434 * print.c (print_preprocess): Only check print_depth if print-circle
5435 is nil.
5436 (print_object): Check for cycles even when print-circle is nil and
5437 print-gensym is t, but only check print_depth if print-circle is nil.
5438
f30d612a
CY
54392012-04-20 Chong Yidong <cyd@gnu.org>
5440
5441 * process.c (wait_reading_process_output): If EIO occurs on a pty,
5442 set the status to "failed" and ensure that sentinel is run.
5443
c07a4c0b 54442012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
5445
5446 * process.c (Fset_process_inherit_coding_system_flag)
5447 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 5448 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 5449
c07a4c0b 54502012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
5451
5452 * xdisp.c (string_buffer_position_lim): Limit starting position to
5453 BEGV.
5454 (set_cursor_from_row): If called for a mode-line or header-line
5455 row, return zero immediately.
5456 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
5457 farther than the first row after the header line, if any.
5458 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
5459 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
5460
c07a4c0b 54612012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5462
4ae29f89
SM
5463 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
5464 (bug#11238).
ad3a2b41 5465
c07a4c0b 54662012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 54672012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
5468
5469 configure: new option --enable-gcc-warnings (Bug#11207)
5470 * Makefile.in (C_WARNINGS_SWITCH): Remove.
5471 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
5472 (ALL_CFLAGS): Use new macros rather than old.
5473 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
5474 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
5475 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
5476 -Wunused-result, -Wunused-variable. This should go away once
5477 the Emacs and Gnulib regex code is merged.
5478 (xmalloc, xrealloc): Now static.
5479
aba027e8
PE
54802012-04-17 Paul Eggert <eggert@cs.ucla.edu>
5481
5482 * dired.c (Fsystem_groups): Remove unused local.
5483
e5a36063
GM
54842012-04-17 Glenn Morris <rgm@gnu.org>
5485
5486 * dired.c (Fsystem_users): Doc fix.
5487
316411f0
DA
54882012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
5489
5490 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
5491 (syms_of_dired): Add them.
5492
9426aba4
PE
54932012-04-16 Paul Eggert <eggert@cs.ucla.edu>
5494
b62a57be
PE
5495 Fix minor alloc.c problems found by static checking.
5496 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
5497 New extern decls, to avoid calling undeclared functions.
5498 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
5499 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
5500 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
5501 (NEED_MEM_INSERT): New macro.
5502 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 5503 Remove one incorrect comment and fix another.
b62a57be 5504
3539f31f
PE
5505 Fix minor ralloc.c problems found by static checking.
5506 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5507 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
5508 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
5509 (r_alloc_sbrk): Now static.
5510
a041960a
PE
5511 Improve ralloc.c interface checking.
5512 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
5513 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
5514 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
5515 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
5516 [REL_ALLOC]: ... to here, to check interface.
5517 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
5518 Remove decls. This fixes an "It stinks!".
5519
9426aba4
PE
5520 * alloc.c (which_symbols): Fix alignment issue / type clash.
5521
d55c12ed
AS
55222012-04-15 Andreas Schwab <schwab@linux-m68k.org>
5523
5524 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
5525 (struct Lisp_Misc_Any): Likewise.
5526 (struct Lisp_Free): Likewise.
5527 * alloc.c (union aligned_Lisp_Symbol): Define.
5528 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
5529 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
5530 (union aligned_Lisp_Misc): Define.
5531 (MARKER_BLOCK_SIZE, struct marker_block): Use union
5532 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 5533 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 5534
b948ce8b
PE
55352012-04-14 Paul Eggert <eggert@cs.ucla.edu>
5536
5537 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
5538 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
5539 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
5540 * s/netbsd.h, s/sol2-6.h:
5541 Remove definition of GC_MARK_STACK, since the default now works.
5542 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
5543 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
5544 no longer the default.
5545 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
5546
35dc09a1 55472012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 5548
35dc09a1
GM
5549 * lread.c (lisp_file_lexically_bound_p):
5550 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 5551
35dc09a1
GM
55522012-04-14 Eli Zaretskii <eliz@gnu.org>
5553
5554 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
5555 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
5556
55572012-04-14 Jan Djärv <jan.h.d@swipnet.se>
5558
5559 * nsterm.m (constrainFrameRect): Always constrain when there is only
5560 one screen (Bug#10962).
5561
bcd86815
KB
55622012-04-13 Ken Brown <kbrown@cornell.edu>
5563
5564 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
5565
c25df26e
RT
55662012-04-13 Reuben Thomas <rrt@sc3d.org>
5567
5568 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
5569
0fc59f1e
DC
55702012-04-11 Daniel Colascione <dancol@dancol.org>
5571
5572 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
5573 against is gone. It's better to use vfork now so that when Cygwin
5574 gains a new, working vfork, we use it automatically (bug#10398).
5575
de8c03dc
SM
55762012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5577
5578 * window.c (save_window_save): Obey window-point-insertion-type.
5579
2f097256
GM
55802012-04-11 Glenn Morris <rgm@gnu.org>
5581
5582 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
5583
453b951e
SM
55842012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
5585
5586 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
5587
75f1671a 55882012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
5589
5590 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
5591 (force_quit_count): New var.
5592 (handle_interrupt): Use it.
5593
2a8ce227
JB
55942012-04-10 Juanma Barranquero <lekktu@gmail.com>
5595
5596 * w32.c (w32_delayed_load): Record the full path of the library
5597 being loaded (bug#10424).
5598
935396c0
GM
55992012-04-09 Glenn Morris <rgm@gnu.org>
5600
05920a43
GM
5601 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
5602 not just in the obarray, before snarfing them. (Bug#11036)
5603
935396c0
GM
5604 * Makefile.in ($(leimdir)/leim-list.el):
5605 Pass EMACS rather than BUILT_EMACS.
5606
a18ecafa
TZ
56072012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
5608
5609 * process.c (make_process):
5610 * process.h: Add integer `gnutls_handshakes_tried' member to
5611 process struct.
5612
6bbef4e5
JC
5613 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
5614 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
5615
5616 * gnutls.c (gnutls_log_function2i): Convenience log function.
5617 (emacs_gnutls_read): Use new log functions,
5618 `gnutls_handshakes_tried' process member, and
5619 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
5620 attempts per process (connection).
5621
b4d3bc10
CY
56222012-04-09 Chong Yidong <cyd@gnu.org>
5623
5624 * eval.c (Fuser_variable_p, user_variable_p_eh)
5625 (lisp_indirect_variable): Functions deleted.
5626 (Fdefvar): Caller changed.
5627
5628 * callint.c (Finteractive, Fcall_interactively):
5629 * minibuf.c (Fread_variable): Callers changed.
5630
70f4d973
EZ
56312012-04-09 Eli Zaretskii <eliz@gnu.org>
5632
5633 * xdisp.c (set_cursor_from_row): If the display string appears in
5634 the buffer at position that is closer to point than the position
5635 after the display string, display the cursor on the first glyph of
5636 the display string. Fixes cursor display when a 'display' text
5637 property immediately follows invisible text. (Bug#11094)
5638
cb3c2e3e
PE
56392012-04-09 Paul Eggert <eggert@cs.ucla.edu>
5640
5641 composite.c: use 'double' consistently
5642 * composite.c (get_composition_id): Use 'double' consistently
5643 instead of converting 'float' to 'double' and vice versa; this is
5644 easier to understand and avoids a GCC warning.
5645
fd06db5d
GM
56462012-04-09 Glenn Morris <rgm@gnu.org>
5647
50fe702a
GM
5648 * Makefile.in: Generate leim-list with bootstrap-emacs, in
5649 preparation for dumping it with emacs. (Bug#4789)
5650 (leimdir): New variable.
5651 ($(leimdir)/leim-list.el): New rule.
5652 (emacs$(EXEEXT)): Depend on leim-list.el.
5653
fd06db5d
GM
5654 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
5655 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
5656 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
5657
55c131ee
AS
56582012-04-08 Andreas Schwab <schwab@linux-m68k.org>
5659
5660 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
5661 proper alignment.
5662
9209588f
JB
56632012-04-07 Juanma Barranquero <lekktu@gmail.com>
5664
5665 * xml.c (init_libxml2_functions) [WINDOWSNT]:
5666 Remove unused local variable.
5667
e3fb2efb
PE
56682012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5669
5670 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
5671 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
5672 (mark_memory): Mark Lisp_Objects only if pointers might hide in
5673 objects, as mark_maybe_pointer will catch them otherwise.
5674 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
5675 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
5676
b5385551
PE
56772012-04-07 Paul Eggert <eggert@cs.ucla.edu>
5678
5679 Fix typo that broke non-Windows builds.
5680 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
5681
9078ead6
EZ
56822012-04-07 Eli Zaretskii <eliz@gnu.org>
5683
5684 Support building on MS-Windows with libxml2.
5685
5686 * makefile.w32-in (OBJ2): Add xml.$(O).
5687 (GLOBAL_SOURCES): Add xml.c.
5688 ($(BLD)/xml.$(O)): New dependency list.
5689
5690 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
5691 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
5692 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
5693 [!WINDOWSNT]: New macros.
5694 (init_libxml2_functions, libxml2_loaded_p): New functions.
5695 (parse_region): Call fn_xmlCheckVersion instead of using the macro
5696 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
5697 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
5698 Calls xmlCleanupParser only if libxml2 was loaded (or statically
5699 linked in).
6bbef4e5
JC
5700 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
5701 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
5702 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
5703
5704 * emacs.c: Don't include libxml/parser.h.
5705 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
5706 xmlCleanupParser directly.
5707
5708 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
5709
3811fdf3
EZ
57102012-04-07 Eli Zaretskii <eliz@gnu.org>
5711
5712 * indent.c (Fvertical_motion): If there is a display string at
5713 point, use it.vpos to compute how many lines to backtrack after
5714 move_it_to point. (Bug#11133)
5715
2f8e16b2
EZ
57162012-04-06 Eli Zaretskii <eliz@gnu.org>
5717
5718 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
5719 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
5720 about subtle differences between FETCH_CHAR* and STRING_CHAR*
5721 macros related to unification of CJK characters. For the details,
5722 see the discussion following the message here:
5723 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
5724
3d439cd1
CY
57252012-04-04 Chong Yidong <cyd@gnu.org>
5726
5727 * keyboard.c (Vdelayed_warnings_list): Doc fix.
5728
8bc53d00
EZ
57292012-04-01 Eli Zaretskii <eliz@gnu.org>
5730
5731 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
5732 instead of alloca. (Bug#11138)
5733
3b0512a3
AS
57342012-04-01 Andreas Schwab <schwab@linux-m68k.org>
5735
5736 * w32menu.c (is_simple_dialog): Properly check lisp types.
5737 (Bug#11141)
5738
8427ddd2
EZ
57392012-03-31 Eli Zaretskii <eliz@gnu.org>
5740
979022ef
EZ
5741 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
5742 position we get to after a call to move_it_to fails the
5743 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
5744 only if we wind up in a string from display property. (Bug#11063)
5745
a6b1c7cc
EZ
5746 * window.c (Fdelete_other_windows_internal): Invalidate the row
5747 and column information about mouse highlight, so that redisplay
5748 restores it after reallocating the glyph matrices. (Bug#7464)
5749
8427ddd2
EZ
5750 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
5751 string comes from a `display' text property, use the buffer
5752 position of that property as if we actually saw that position in
5753 the row's glyphs.
697ba24b
EZ
5754 (move_it_by_lines): Remove the assertion that
5755 "it->current_x == 0 && it->hpos == 0" which can be legitimately
5756 violated when there's a before-string at the beginning of a line.
5757 (Bug#11063)
8427ddd2 5758
65a0a738
EZ
57592012-03-30 Eli Zaretskii <eliz@gnu.org>
5760
5761 * xdisp.c (append_space_for_newline): If the default face was
5762 remapped, use the remapped face for the appended newline.
5763 (extend_face_to_end_of_line): Use the remapped default face for
5764 extending the face to the end of the line.
5765 (display_line): Call extend_face_to_end_of_line when the default
5766 face was remapped. (Bug#11068)
5767
581355cc
EZ
57682012-03-29 Eli Zaretskii <eliz@gnu.org>
5769
5770 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
5771
e8fc049f
SM
57722012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5773
5774 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
5775
4fb9a543
GM
57762012-03-27 Glenn Morris <rgm@gnu.org>
5777
5778 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
5779 Doc fixes.
5780
679910f1
KH
57812012-03-26 Kenichi Handa <handa@m17n.org>
5782
5783 * dispextern.h (struct glyph): Fix previous change. Change the
5784 bit length of glyphless.ch to 25 (Bug#11082).
5785
90d49b7f
CY
57862012-03-26 Chong Yidong <cyd@gnu.org>
5787
5788 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5789 (command_loop_1): Use it; inhibit selection update for
5790 handle-select-window too (Bug#8996).
5791
f514f6f0
FP
57922012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5793
e8fc049f 5794 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5795
bf43fa51
KH
57962012-03-25 Kenichi Handa <handa@m17n.org>
5797
5798 * dispextern.h (struct glyph): Change the bit length of
5799 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5800
8a0c01dd
EZ
58012012-03-24 Eli Zaretskii <eliz@gnu.org>
5802
5803 * s/ms-w32.h (tzname): Include time.h before redirecting to
5804 _tzname. Fixes the MSVC build. (Bug#9960)
5805
7d1c3a76
AS
58062012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5807
8ed79523
AS
5808 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5809 characters.
5810
7d1c3a76
AS
5811 * xterm.c (XTread_socket): Only modify handling_signal if
5812 !SYNC_INPUT. (Bug#11080)
5813
e99a9b8b
EZ
58142012-03-23 Eli Zaretskii <eliz@gnu.org>
5815
5816 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5817 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5818 when fetching a multibyte character consumes more bytes than
5819 CHAR_BYTES returns, due to unification of CJK characters in
5820 string_char. (Bug#11073)
5821
5063c0e1
TN
58222012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5823
5824 * process.c (wait_reading_process_output): Handle pty disconnect
5825 by refraining from sending oneself a SIGCHLD (bug#10933).
5826
9f851fbd
CY
58272012-03-22 Chong Yidong <cyd@gnu.org>
5828
5829 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5830
5063c0e1 5831 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5832 Mark string as coming from a prefix property.
5833 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5834 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5835
fb5b8aca
CY
58362012-03-21 Chong Yidong <cyd@gnu.org>
5837
5838 * xfaces.c (Vface_remapping_alist): Doc fix.
5839
62356a1b
EZ
58402012-03-20 Eli Zaretskii <eliz@gnu.org>
5841
5842 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5843 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5844 Doc fixes.
62356a1b 5845
025de85b
CY
58462012-03-20 Chong Yidong <cyd@gnu.org>
5847
5848 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5849 to reflect default non-nil value of redisplay-dont-pause.
5850
4827f94e
KH
58512012-03-19 Kenichi Handa <handa@m17n.org>
5852
5853 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5854 it fit in a valid range (Bug#11003).
5855
e50a24a2
EZ
58562012-03-18 Eli Zaretskii <eliz@gnu.org>
5857
5858 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5859 that is not from display property, accept the row as a "cursor
5860 row" if one of the string's character has a non-nil `cursor'
5861 property. Fixes cursor positioning when there are newlines in
5862 overlay strings, e.g. in icomplete.el. (Bug#11035)
5863
9af5ed87
PE
58642012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5865
5866 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5867
d1f55f16
CY
58682012-03-12 Chong Yidong <cyd@gnu.org>
5869
5870 * eval.c (inhibit_lisp_code): Rename from
5871 inhibit_window_configuration_change_hook; move from window.c.
5872
5873 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5874 * window.c (run_window_configuration_change_hook)
5875 (syms_of_window): Callers changed.
5876
66c5eebd
CY
58772012-03-11 Chong Yidong <cyd@gnu.org>
5878
413df973
CY
5879 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5880
66c5eebd
CY
5881 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5882
1de11f56
CY
58832012-03-10 Chong Yidong <cyd@gnu.org>
5884
5885 * frame.c (other_visible_frames): Don't assume the selected frame
5886 is visible (Bug#10955).
5887
cae07000
SM
58882012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5889
5890 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5891
89c94350
JD
58922012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5893
5894 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5895 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5896 zero (Bug#10954).
5897
999dd333
GM
58982012-03-03 Glenn Morris <rgm@gnu.org>
5899
01a6dcc8 5900 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5901
de0100f2
EZ
59022012-03-02 Eli Zaretskii <eliz@gnu.org>
5903
5904 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5905 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5906 (redisplay_window, next_element_from_string): Fix typos in
5907 comments.
3e441275
EZ
5908 (redisplay_window): Pass to move_it_vertically the margin in
5909 pixels, not in screen lines.
de0100f2 5910
96a72ee9
GM
59112012-03-02 Glenn Morris <rgm@gnu.org>
5912
5913 * buffer.c (buffer-list-update-hook): Doc fix.
5914
312508d7
EZ
59152012-02-29 Eli Zaretskii <eliz@gnu.org>
5916
5917 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5918 push_it before setting up the iterator for the first overlay
5919 string, even if we have an empty string loaded.
5920 (next_overlay_string): If there's an empty string on the iterator
5921 stack, pop the stack. (Bug#10903)
5922
27f3c637
PE
59232012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5926 Suggested by Stefan Monnier in
5927 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5928 * alloc.c (widen_to_Lisp_Object): New static function.
5929 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5930 and widening them to Lisp_Objects. This would work even if
5931 USE_LSB_TAG is defined and wide integers are used, which might
5932 happen in a future version of Emacs.
5933
3c9dfce6
CY
59342012-02-25 Chong Yidong <cyd@gnu.org>
5935
fa74b241
CY
5936 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5937 Doc fix.
5938
3c9dfce6
CY
5939 * xselect.c (Fx_selection_exists_p): Doc fix.
5940 (x_clipboard_manager_save_all): Print an informative message
5941 before saving to clipboard manager.
5942
9486df08
CY
59432012-02-24 Chong Yidong <cyd@gnu.org>
5944
5945 * keyboard.c (process_special_events): Handle all X selection
5946 requests in kbd_buffer, not just the next one (Bug#8869).
5947
f01d3321
CY
59482012-02-23 Chong Yidong <cyd@gnu.org>
5949
5950 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5951 call when setting menu-bar-lines and tool-bar-lines parameters.
5952 (unwind_create_frame_1): New helper function.
5953
5954 * window.c (inhibit_window_configuration_change_hook): New var.
5955 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5956 (syms_of_window): Initialize it.
f01d3321 5957
86b847b6
CY
59582012-02-22 Chong Yidong <cyd@gnu.org>
5959
5960 * xterm.c (x_draw_image_relief): Add missing type check for
5961 Vtool_bar_button_margin (Bug#10743).
5962
a59225b1
CY
59632012-02-21 Chong Yidong <cyd@gnu.org>
5964
5965 * fileio.c (Vfile_name_handler_alist): Doc fix.
5966
5967 * buffer.c (Fget_file_buffer): Protect against invalid file
5968 handler return value.
5969
310f5bd4
PE
59702012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5971
cb3a28cc
PE
5972 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5973 when computing $valmask.
5974
310f5bd4
PE
5975 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5976 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5977 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5978 It's useless in that case, and it can cause problems on hosts
5979 that allocate halves of EMACS_INT values separately.
5980 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5981 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5982 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5983 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5984 it avoids undefined behavior on hosts where shifting right by more
5985 than the word width has undefined behavior.
5986
2375c96a
CY
59872012-02-19 Chong Yidong <cyd@gnu.org>
5988
5989 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5990 (Funhandled_file_name_directory, Ffile_name_as_directory)
5991 (Fdirectory_file_name, Fexpand_file_name)
5992 (Fsubstitute_in_file_name): Protect against invalid file handler
5993 return values (Bug#10845).
5994
3eb49e71
EZ
59952012-02-18 Eli Zaretskii <eliz@gnu.org>
5996
5997 * .gdbinit (pitx): Fix incorrect references to fields of the
5998 iterator stack.
5999
7b926f3f
CY
60002012-02-17 Chong Yidong <cyd@gnu.org>
6001
6002 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
6003
11273115
PE
60042012-02-15 Paul Eggert <eggert@cs.ucla.edu>
6005
6006 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
6007 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
6008
c3a70e2b
CY
60092012-02-15 Chong Yidong <cyd@gnu.org>
6010
6011 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
6012 marked as special. Also, starting docstrings with * is obsolete.
6013
0ca43699
AS
60142012-02-13 Andreas Schwab <schwab@linux-m68k.org>
6015
6016 * gnutls.c (emacs_gnutls_write): Fix last change.
6017
2e8f3c56
LI
60182012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
6019
6020 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
6021 send_process.
6022
af70074f
SM
60232012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
6024
6025 * keymap.c (Fsingle_key_description): Handle char ranges.
6026
95986d52
CY
60272012-02-12 Chong Yidong <cyd@gnu.org>
6028
afd83bd1
CY
6029 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
6030 as that creates a dangerous corner case.
6031
95986d52
CY
6032 * window.c (Fdelete_window_internal): Invalidate the mouse
6033 highlight (Bug#9904).
6034
bd7da63e
GM
60352012-02-12 Glenn Morris <rgm@gnu.org>
6036
6037 * xselect.c (Fx_own_selection_internal)
6038 (Fx_get_selection_internal, Fx_disown_selection_internal)
6039 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
6040 * nsselect.m (Fx_own_selection_internal)
6041 (Fx_disown_selection_internal, Fx_selection_exists_p)
6042 (Fx_selection_owner_p, Fx_get_selection_internal):
6043 Sync docs and argument specs with the xselect.c versions.
6044
77abcbc2
LI
60452012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
6046
6047 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
6048
90b671e2
EZ
60492012-02-11 Eli Zaretskii <eliz@gnu.org>
6050
1c0ca0b7
EZ
6051 * w32select.c (Fx_selection_exists_p): Sync doc string and
6052 argument list with xselect.c. (Bug#10783)
6053
6054 * w16select.c (Fx_selection_exists_p): Sync doc string and
6055 argument list with xselect.c. (Bug#10783)
90b671e2 6056
49241268
GM
60572012-02-10 Glenn Morris <rgm@gnu.org>
6058
6059 * fns.c (Fsecure_hash): Doc fix.
6060
f998bbe7 60612012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
6062
6063 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
6064
0992bd9c
CY
60652012-02-07 Chong Yidong <cyd@gnu.org>
6066
6067 * buffer.c (Fbuffer_local_variables)
6068 (buffer_lisp_local_variables): Handle unbound vars correctly;
6069 don't let Qunbound leak into Lisp.
6070
af008560
GM
60712012-02-07 Glenn Morris <rgm@gnu.org>
6072
dd605cc4
GM
6073 * image.c (Fimagemagick_types): Doc fix.
6074
af008560
GM
6075 * image.c (imagemagick-render-type): Change it from a lisp object
6076 to an integer. Move the doc here from the lisp manual.
6077 Treat all values not equal to 0 the same.
6078
1449fa1d
CY
60792012-02-06 Chong Yidong <cyd@gnu.org>
6080
6081 * doc.c (store_function_docstring): Avoid applying docstring of
6082 alias to base function (Bug#2603).
6083
3723ec07
AS
60842012-02-04 Andreas Schwab <schwab@linux-m68k.org>
6085
6086 * .gdbinit (pp1, pv1): Remove redundant defines.
6087 (pr): Use pp.
6088
79c1cc1e
CY
60892012-02-04 Chong Yidong <cyd@gnu.org>
6090
6091 * nsterm.m: Declare a global (Bug#10694).
6092
d7f29f8e
EZ
60932012-02-04 Eli Zaretskii <eliz@gnu.org>
6094
cae07000
SM
6095 * w32.c (get_emacs_configuration_options):
6096 Include --enable-checking, if specified, in the return value.
d7f29f8e 6097
3b95a6f9
MR
60982012-02-04 Martin Rudalics <rudalics@gmx.at>
6099
6100 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
6101 after rounding frame sizes. (Bug#9723)
6102
d6fa96a6
EZ
61032012-02-04 Eli Zaretskii <eliz@gnu.org>
6104
6105 * keyboard.c (adjust_point_for_property): Don't position point
6106 before BEGV. (Bug#10696)
6107
df0b2940
PE
61082012-02-03 Paul Eggert <eggert@cs.ucla.edu>
6109
6110 Handle overflow when computing char display width (Bug#9496).
6111 * character.c (char_width): Return EMACS_INT, not int.
6112 (char_width, c_string_width): Check for overflow when
6113 computing the width; this is possible now that individual
6114 characters can have unbounded width. Problem introduced
6115 by merge from Emacs 23 on 2012-01-19.
6116
6bee44d6
MA
61172012-02-02 Michael Albinus <michael.albinus@gmx.de>
6118
6119 * dbusbind.c (Fdbus_register_method): Mention the return value
6120 :ignore in the docstring.
6121
44f92739
GM
61222012-02-02 Glenn Morris <rgm@gnu.org>
6123
1b9f60cc
GM
6124 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
6125
44f92739
GM
6126 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6127 Unconditionally set to t. (Bug#10673)
6128 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
6129 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
6130 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
6131
c5d3843c
KH
61322012-02-02 Kenichi Handa <handa@m17n.org>
6133
6134 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
6135 0, do not call append_composite_glyph.
6136
159462d4 61372012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
6138
6139 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
6140 NULL (Bug#6988).
6141 (x_produce_glyphs): If the component of a composition is a null
6142 string, set it->pixel_width to 1 to avoid zero-width glyph.
6143
78cef877
EZ
61442012-02-01 Eli Zaretskii <eliz@gnu.org>
6145
6146 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
6147 first 2 arguments are identical. This makes inserting large
6148 output from a subprocess an order of magnitude faster on
6149 MS-Windows, where all sbrk'ed memory is always contiguous.
6150
97897668
GM
61512012-01-31 Glenn Morris <rgm@gnu.org>
6152
6153 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 6154 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
6155 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
6156
31fd3586
GM
61572012-01-29 Glenn Morris <rgm@gnu.org>
6158
6159 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
6160
0e24a8b2
CY
61612012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
6162
6163 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
6164
cc0adcb0
CY
61652012-01-28 Chong Yidong <cyd@gnu.org>
6166
6167 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
6168
acc28cb9
CY
61692012-01-26 Chong Yidong <cyd@gnu.org>
6170
9c69cfb7
CY
6171 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
6172
acc28cb9
CY
6173 * search.c (Fsearch_forward, Fsearch_backward): Document negative
6174 repeat counts (Bug#10507).
6175
48da7392
GM
61762012-01-26 Glenn Morris <rgm@gnu.org>
6177
6178 * lread.c (syms_of_lread): Doc fix.
6179
14af5f7f
CY
61802012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
6181
6182 * coding.c (encode_designation_at_bol): Change return value to
6183 EMACS_INT.
6184
0b21c100
CY
61852012-01-25 Chong Yidong <cyd@gnu.org>
6186
6187 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
6188
3c2907f7
CY
61892012-01-21 Chong Yidong <cyd@gnu.org>
6190
6191 * floatfns.c (Fcopysign): Make the second argument non-optional,
6192 since nil is not allowed anyway.
6193
959ad23f
AS
61942012-01-21 Andreas Schwab <schwab@linux-m68k.org>
6195
6196 * process.c (read_process_output): Use p instead of XPROCESS (proc).
6197 (send_process): Likewise.
6198
34a02f46
MR
61992012-01-19 Martin Rudalics <rudalics@gmx.at>
6200
6201 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
6202 (Vwindow_persistent_parameters): Do not use Qstate.
6203 Rewrite doc-strings.
34a02f46 6204
1259009a 62052012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
6206
6207 * character.c (char_width): New function.
70d4fdf6
GM
6208 (Fchar_width, c_string_width, lisp_string_width):
6209 Use char_width (Bug#9496).
25ed9e61 6210
6a6ee00d
MR
62112012-01-16 Martin Rudalics <rudalics@gmx.at>
6212
6213 * window.c (Vwindow_persistent_parameters): New variable.
6214 (Fset_window_configuration, save_window_save): Handle persistent
6215 window parameters.
6216
c85efaf7
EZ
62172012-01-14 Eli Zaretskii <eliz@gnu.org>
6218
6219 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
6220 thrashing the stack of the thread. (Bug#9087)
6221
5944709e
PE
62222012-01-12 Paul Eggert <eggert@cs.ucla.edu>
6223
6224 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
6225
e71f5d99
EZ
62262012-01-11 Eli Zaretskii <eliz@gnu.org>
6227
6228 * xdisp.c (rows_from_pos_range): Handle the case where the
6229 highlight ends on a newline. (Bug#10464)
6230 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
6231 he end column for display of highlight that ends on a newline
6232 before a R2L line.
6233
ce316182
GM
62342012-01-11 Glenn Morris <rgm@gnu.org>
6235
6236 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
6237 from load-path also when installation-directory is nil. (Bug#10208)
6238
5b43da69
GM
62392012-01-10 Glenn Morris <rgm@gnu.org>
6240
74cc8ff9
GM
6241 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
6242
7d8d6e4e
GM
6243 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
6244 Update template values to be closer to their typical values these days.
5b43da69 6245
a0db8d43
EZ
62462012-01-09 Eli Zaretskii <eliz@gnu.org>
6247
6248 * xdisp.c (rows_from_pos_range): Accept additional argument
6249 DISP_STRING, and accept any glyph in a row whose object is that
6250 string as eligible for mouse highlight. Fixes mouse highlight of
6251 display strings from overlays. (Bug#10464)
6252
9a0115ab 62532012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 6254
b9110d6a 6255 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
6256 * fileio.c (auto_saving_dir_umask): New static var.
6257 (Fmake_directory_internal): Use it.
6258 (do_auto_save_make_dir): Set it, instead of invoking chmod after
6259 creating the directory. The old code temporarily assigns
6260 too-generous permissions to the directory.
6261 (do_auto_save_eh): Clear it.
b9110d6a 6262 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
6263 that the var is always cleared.
6264
6c1bd3f3
EZ
62652012-01-07 Eli Zaretskii <eliz@gnu.org>
6266
6267 * search.c (scan_buffer): Pass character positions to
6268 know_region_cache, not byte positions. (Bug#6540)
6269
069d2b50
L
62702012-01-07 LynX <_LynX@bk.ru> (tiny change)
6271
6272 * w32.c (sys_rename): Report EXDEV when rename of a directory
6273 fails because the target is on another logical disk. (Bug#10284)
6274
75bf0d33
DB
62752012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
6276
6277 * xterm.c (x_embed_request_focus): New function.
6278
6279 * xterm.h: Add prototype.
6280
6281 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
6282
1c6e5a32
GM
62832012-01-05 Glenn Morris <rgm@gnu.org>
6284
6285 * emacs.c (emacs_copyright): Update short copyright year to 2012.
6286
651e947e
EZ
62872012-01-01 Eli Zaretskii <eliz@gnu.org>
6288
6289 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
6290 Load gnutls_transport_set_lowat only if GnuTLS version is below
6291 2.11.1.
6292 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
6293 GnuTLS versions below 2.11.1.
6294
3778cdd8
AL
62952011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
6296
6297 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
6298 to the doc string advising against its use for altering the way
6299 windows are scrolled.
6300
0e5317f7
KH
63012011-12-28 Kenichi Handa <handa@m17n.org>
6302
6303 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
6304 coding-system ASCII compatible only when it does not produce BOM
6305 on encoding (Bug#10383).
6306
93d5ca1f
JD
63072011-12-26 Jan Djärv <jan.h.d@swipnet.se>
6308
6309 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
6310 can scroll.
6311 (create_and_show_popup_menu): Always use menu_position_func for
6312 Gtk3 (Bug#10361).
6313
ca22b785
AS
63142011-12-24 Andreas Schwab <schwab@linux-m68k.org>
6315
6316 * callint.c (Fcall_interactively): Don't truncate prompt string.
6317
d048e1e6
EZ
63182011-12-23 Eli Zaretskii <eliz@gnu.org>
6319
6320 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
6321 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 6322 resumed from there (after widening). (Bug#10360)
d048e1e6 6323
5ccaba1f
JD
63242011-12-22 Jan Djärv <jan.h.d@swipnet.se>
6325
6326 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
6327
204ee57f
JD
63282011-12-21 Jan Djärv <jan.h.d@swipnet.se>
6329
b81d40f0
JB
6330 * nsterm.m (x_free_frame_resources):
6331 Release f->output_data.ns->miniimage.
204ee57f
JD
6332 (ns_index_color): Fix indentation. Do not retain
6333 color_table->colors[i].
6334
6335 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
6336 before returning.
6337
6338 * nsfns.m (x_set_background_color): Assign return value from
6339 ns_index_color to face-background instead of NSColor*.
6340 (ns_implicitly_set_icon_type): Fix indentation.
6341 Change assignment in for loop to comparison.
6342
6343 * emacs.c (ns_pool): New variable.
6344 (main): Assign ns_pool.
6345 (Fkill_emacs): Call ns_release_autorelease_pool.
6346
6347 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
6348 autorelease fdesc, release fdAttrs and tdict.
6349 (ns_get_covering_families): Release charset.
6350 (ns_findfonts): Release NSFontDescriptor created with new.
6351 (ns_uni_to_glyphs): Fix indentation.
6352 (setString): Release attrStr before assigning new value.
6353
c803b2b7
JD
63542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
6355
678f4426
JD
6356 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
6357 and NS_IMPL_COCOA.
6358 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
6359 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
6360
cd394be1 63612011-12-18 David Reitter <reitter@cmu.edu>
678f4426 6362
5fecd5fc
JD
6363 * nsterm.m (ns_term_init): Subscribe for notifications
6364 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
6365 to method trackingNotification in EmacsMenu.
6366
6367 * nsmenu.m (trackingMenu): New variable.
3771cb17 6368 (trackingNotification): New method (from Aquamacs).
5fecd5fc 6369 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 6370 from Aquamacs (Bug#7030).
678f4426
JD
6371
63722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 6373
c803b2b7
JD
6374 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
6375 (symbol_to_nsstring): Fix indentation.
6376 (ns_symbol_to_pb): New function.
cae07000
SM
6377 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
6378 (Fns_rotate_cut_buffers_internal): Remove.
6379 (Fns_store_selection_internal): Rename from
c803b2b7
JD
6380 Fns_store_cut_buffer_internal.
6381 (ns_get_foreign_selection, Fx_own_selection_internal)
6382 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
6383 (Fns_get_selection_internal, Fns_store_selection_internal):
6384 Use ns_symbol_to_pb and check if return value is nil.
6385 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
6386 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
6387 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
6388 renamed to Sns_store_selection_internal.
6389 (ns_handle_selection_request): Move code to Fx_own_selection_internal
6390 and remove this function.
6391 (ns_handle_selection_clear): Remove, never used.
6392 (Fx_own_selection_internal): Move code from ns_handle_selection_request
6393 here.
6394
e1b01a3a
KB
63952011-12-17 Ken Brown <kbrown@cornell.edu>
6396
6397 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
6398 GID is unknown (Bug#10257).
6399
2adb6e85
PE
64002011-12-17 Paul Eggert <eggert@cs.ucla.edu>
6401
6402 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
6403 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
6404 which caused a build failure on GNU/Linux IA-64. This problem was
6405 introduced by my 2011-10-07 patch.
6406
d1d7b339
JL
64072011-12-15 Juri Linkov <juri@jurta.org>
6408
6409 * image.c (imagemagick_error): New function. (Bug#10112)
6410 (imagemagick_load_image): Comment out `MagickSetResolution' call.
6411 Use `imagemagick_error' where ImageMagick functions return
6412 `MagickFalse'.
6413 (Fimagemagick_types): Add `Fnreverse' to return the list in the
6414 proper order.
6415
100d5755
KH
64162011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6417
6418 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
6419 fill background (Bug#8992).
6420
454592a6
MR
64212011-12-13 Martin Rudalics <rudalics@gmx.at>
6422
6423 * window.c (Vwindow_combination_resize)
6424 (Vwindow_combination_limit): Use t instead of non-nil in
6425 doc-strings.
61d4b438
MR
6426 (Vrecenter_redisplay): Add first sentence of doc-string on
6427 separate line.
53524d93 6428 (Frecenter): Fix doc-string typo.
454592a6 6429
3633e3aa
KH
64302011-12-11 Kenichi Handa <handa@m17n.org>
6431
6432 * coding.c (Funencodable_char_position): Pay attention to the
6433 buffer text relocation (Bug#9389).
6434
7b9d523a 64352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 6436
7b9d523a
JD
6437 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
6438 gtk_init (Bug#10100).
6439
b73189c6
EZ
64402011-12-10 Eli Zaretskii <eliz@gnu.org>
6441
6442 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
6443 IT->string is nil. (Bug#10263)
6444
f7dfe5d6
JD
64452011-12-10 Jan Djärv <jan.h.d@swipnet.se>
6446
83faebb4
JD
6447 * nsterm.h (x_free_frame_resources): Declare.
6448
f7dfe5d6
JD
6449 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
6450 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
6451
6452 * nsterm.h (ns_get_defaults_value): Declare.
6453
6454 * nsterm.m (ns_default): Call ns_get_defaults_value.
6455
7cd4e72c
EZ
64562011-12-09 Eli Zaretskii <eliz@gnu.org>
6457
6458 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
6459 (Bug#10170)
6460
b34d7317
YM
64612011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6462
6463 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
6464 that where the value of an _OBJC_* symbol points to is in the .bss
6465 section (Bug#10240).
6466
76470ad1
KH
64672011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6468
6469 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 6470 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 6471
745fff94
KH
64722011-12-08 Kenichi Handa <handa@m17n.org>
6473
6474 * ftfont.c (get_adstyle_property): Fix previous change
6475 (Bug#10233).
6476
6e44397c
JB
64772011-12-07 Juanma Barranquero <lekktu@gmail.com>
6478
6479 * w32.c (init_environment): If no_site_lisp, remove site-lisp
6480 dirs from the default value of EMACSLOADPATH (bug#10208).
6481
7efa6272
GM
64822011-12-07 Glenn Morris <rgm@gnu.org>
6483
6484 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
6485 installation and source directories as well. (Bug#10208)
6486
f6fc4d87
CY
64872011-12-06 Chong Yidong <cyd@gnu.org>
6488
6489 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
6490
2bf26180
GM
64912011-12-06 Glenn Morris <rgm@gnu.org>
6492
6493 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
6494 as an error, not just -1. (Bug#10217)
6495
3a6ad4f0
CY
64962011-12-05 Chong Yidong <cyd@gnu.org>
6497
6498 * keyboard.c (process_special_events): New function.
6499 (swallow_events, Finput_pending_p): Use it (Bug#10195).
6500
75a3b399
PE
65012011-12-05 Paul Eggert <eggert@cs.ucla.edu>
6502
6503 * coding.c (encode_designation_at_bol): Don't use uninitialized
6504 local variable (Bug#9318).
6505
c3c9e25e
KH
65062011-12-05 Kenichi Handa <handa@m17n.org>
6507
6508 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
6509 return Qnil (Bug#8046, Bug#10193).
6510
5eb05ea3
KH
65112011-12-05 Kenichi Handa <handa@m17n.org>
6512
6513 * coding.c (encode_designation_at_bol): New args charbuf_end and
6514 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
6515 (coding_set_source): Return how many bytes coding->source was
6516 relocated.
6517 (coding_set_destination): Return how many bytes
6518 coding->destination was relocated.
6519 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 6520 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
6521
65222011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
6523
6524 * coding.c (CODING_CHAR_CHARSET_P): New macro.
6525 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
6526 macro (Bug#9318).
6527
65282011-12-05 Andreas Schwab <schwab@linux-m68k.org>
6529
6530 The following changes are to fix Bug#9318.
6531
a79703f5 6532 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
6533 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
6534 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 6535 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 6536
7dbda6df
JB
65372011-12-05 Juanma Barranquero <lekktu@gmail.com>
6538
6539 * lisp.h (process_quit_flag): Fix external declaration.
6540
6d5eb5b0
SM
65412011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
6542
6543 Don't macro-inline non-performance-critical code.
6544 * eval.c (process_quit_flag): New function.
6545 * lisp.h (QUIT): Use it.
6546
a0c3fad0
JD
65472011-12-04 Jan Djärv <jan.h.d@swipnet.se>
6548
6549 * nsfns.m (get_geometry_from_preferences): New function.
6550 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
6551
6c07aac2
AS
65522011-12-04 Andreas Schwab <schwab@linux-m68k.org>
6553
6554 * emacs.c (Qkill_emacs): Define.
6555 (syms_of_emacs): Initialize it.
6556 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
6557 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
6558 (quit_throw_to_read_char): Add parameter `from_signal'.
6559 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
6560 * lisp.h (QUIT): Call Fkill_emacs if requested.
6561
c052ead4
JD
65622011-12-03 Jan Djärv <jan.h.d@swipnet.se>
6563
6564 * widget.c (update_wm_hints): Return if wmshell is null.
6565 (widget_update_wm_size_hints): New function.
6566
6567 * widget.h (widget_update_wm_size_hints): Declare.
6568
6569 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
6570 widget_update_wm_size_hints (Bug#10104).
6571
9e49252b
EZ
65722011-12-03 Eli Zaretskii <eliz@gnu.org>
6573
6574 * xdisp.c (handle_invisible_prop): If the invisible text ends just
6575 before a newline, prepare the bidi iterator for consuming the
6576 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 6577 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 6578
02b16839
JL
65792011-12-02 Juri Linkov <juri@jurta.org>
6580
6581 * search.c (Fword_search_regexp): New Lisp function created from
6582 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
6583 (Fword_search_backward, Fword_search_forward)
6584 (Fword_search_backward_lax, Fword_search_forward_lax):
6585 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
6586 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
6587
0068070e
SM
65882011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
6589
6590 * fileio.c (Finsert_file_contents): Move after-change-function call
6591 to before the "handled:" label, since all "goto handled" appear in
6592 cases where the *-change-functions have already been properly called
6593 (bug#10117).
6594
3360a3fc
AS
65952011-12-01 Andreas Schwab <schwab@linux-m68k.org>
6596
6597 * keyboard.c (interrupt_signal): Don't call kill-emacs when
6598 waiting for input. (Bug#10169)
6599
73d6c093
EZ
66002011-11-30 Eli Zaretskii <eliz@gnu.org>
6601
6602 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
6603 verifies glyph row's hash code--we have just reallocated the
6604 glyphs, so their contents can be complete garbage. (Bug#10164)
6605
febe6bea
JB
66062011-11-30 Juanma Barranquero <lekktu@gmail.com>
6607
6608 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
6609
801a4313
EZ
66102011-11-30 Eli Zaretskii <eliz@gnu.org>
6611
6612 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
6613 attributes are tested _before_ calling verify_row_hash, to protect
6614 against GCC re-ordering of the tests. (Bug#10164)
6615
2b56b87e
JD
66162011-11-29 Jan Djärv <jan.h.d@swipnet.se>
6617
6618 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
6619
6620 * xterm.c (handle_one_xevent): Only set async_visible and friends
6621 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 6622 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
6623 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
6624
dbf31225
PE
66252011-11-28 Paul Eggert <eggert@cs.ucla.edu>
6626
6627 Remove GCPRO-related macros that exist only to avoid shadowing locals.
6628 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
6629 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6630 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6631 All uses changed to use GCPRO1 etc.
6632 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
6633 Revert to old implementation (i.e., before 2011-03-11).
6634
1305621b
YM
66352011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6636
6637 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
6638 of scroll runs so as to avoid assigning disabled bogus rows and
6639 unnecessary graphics copy operations.
6640
8c9afb46
EZ
66412011-11-27 Eli Zaretskii <eliz@gnu.org>
6642
6643 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
6644 (snprintf) [_MSC_VER]: Redirect to _snprintf.
6645 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
6646 (malloc, free, realloc, calloc): Redirect to e_* only when
6647 compiling Emacs.
6648
6649 * lisp.h (GCTYPEBITS): Move before first use.
6650 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
6651 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
6652 this macro definition.
6653
6654 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
6655 _MSC_VER.
6656
54e9e3bf
JD
66572011-11-27 Jan Djärv <jan.h.d@swipnet.se>
6658
6d5eb5b0
SM
6659 * gtkutil.c (xg_create_frame_widgets):
6660 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
6661 present with Gtk+ 2.0.
6662
83aca1cb
PE
66632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6664
6665 * fileio.c (Finsert_file_contents): Undo previous change; see
6666 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
6667
5b76caa4
PE
66682011-11-26 Paul Eggert <eggert@cs.ucla.edu>
6669
6670 Rename locals to avoid shadowing.
6671 * fileio.c (Finsert_file_contents):
6672 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
6673 * process.c (wait_reading_process_output):
6674 Rename inner 'proc' to 'p' to avoid shadowing.
6675 Indent for consistency with usual Emacs style.
6676
8c535114
EZ
66772011-11-25 Eli Zaretskii <eliz@gnu.org>
6678
6679 * xdisp.c (redisplay_window): If cursor row is not fully visible
6680 after recentering, and scroll-conservatively is set to a large
6681 number, scroll window by a few more lines to make the cursor fully
6682 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
6683 (start_display): Don't move to the next line if the display should
6684 start at a newline that is part of a display vector or an overlay
6685 string. (Bug#10119)
8c535114 6686
fa4fdb5c
JL
66872011-11-24 Juri Linkov <juri@jurta.org>
6688
6689 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
6690 after the `MagickPingImage' call. (Bug#10112)
6691
90ec88df
CY
66922011-11-23 Chong Yidong <cyd@gnu.org>
6693
6694 * window.c (Fcoordinates_in_window_p): Accept only live windows.
6695
56e2e794
MR
66962011-11-23 Martin Rudalics <rudalics@gmx.at>
6697
6698 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
6699 making another buffer current. (Bug#10114)
6700
b6e64c41
GM
67012011-11-23 Glenn Morris <rgm@gnu.org>
6702
6703 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
6704
6b21de18
CY
67052011-11-23 Chong Yidong <cyd@gnu.org>
6706
6707 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
6708 using it (Bug#5984).
6709
b12cd789
EZ
67102011-11-22 Eli Zaretskii <eliz@gnu.org>
6711
6712 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
6713 and header-lines, as they don't have one computed for them.
6714 (Bug#10098)
6715
6716 * .gdbinit (prow): Make displayed values more self-explaining.
6717 Add row's hash code.
6718
261b6fd4
LMI
67192011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
6720
6721 * process.c (wait_reading_process_output): Fix asynchrounous
6722 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 6723 (wait_reading_process_output): Add comment and URL.
261b6fd4 6724
e7cfd277
JD
67252011-11-21 Jan Djärv <jan.h.d@swipnet.se>
6726
6727 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
6728
a9b9b7f5
CY
67292011-11-21 Chong Yidong <cyd@gnu.org>
6730
6731 * window.c (Fnext_window, Fprevious_window): Doc fix.
6732
b0d15b4f
SM
67332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6734
6735 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
6736
fe7a3057
JB
67372011-11-20 Juanma Barranquero <lekktu@gmail.com>
6738
6739 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
6740
d2999b1a
MR
67412011-11-20 Martin Rudalics <rudalics@gmx.at>
6742
6743 * window.c (Fset_window_combination_limit): Rename argument
6744 STATUS to LIMIT.
6745 (Vwindow_combination_limit): Remove "status" from doc-string.
6746
d5ff9cd0
AS
67472011-11-20 Andreas Schwab <schwab@linux-m68k.org>
6748
6749 * m/ibms390.h: Remove.
6750 * m/ibms390x.h: Don't include "ibms390.h".
6751
a5bb9bd3
SM
67522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
6753
6754 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
6755 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
6756
cd1181db
JB
67572011-11-20 Juanma Barranquero <lekktu@gmail.com>
6758
6759 * casetab.c (Fset_case_table):
6760 * charset.c (Fcharset_after): Fix typos.
6761
615a3b8d 67622011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 6763
17e845af
PE
6764 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
6765 Otherwise, valgrind does not work on some platforms.
6766 Problem reported by Andreas Schwab in
6a0bf43d
PE
6767 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
6768 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
6769 is set, removing the need for VIRT_ADDRESS_VARIES.
6770 (PURE_P): Use a more-efficient implementation that needs just one
6771 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
6772 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
6773 to 4 (xorl, subq, cmpq, setbe).
6774 * alloc.c (pure): Always extern now, since that's the
6775 VIRT_ADDR_VARIES behavior.
6776 (PURE_POINTER_P): Use a single comparison, not two, for
6777 consistency with the new puresize.h.
6778 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
6779 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
6780 Remove VIRT_ADDR_VARIES no longer needed.
6781
f8fe6f96
EZ
67822011-11-19 Eli Zaretskii <eliz@gnu.org>
6783
6784 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
6785 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6786 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6787 behave as if the cursor position were at the window margin.
6788
6789 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6790 and the cursor position is out of bounds, behave as if the cursor
6791 position were at the window margin. (Bug#10075)
6792
df05a53c
CY
67932011-11-18 Chong Yidong <cyd@gnu.org>
6794
6795 * window.c (Fwindow_combination_limit): Make first argument
6796 non-optional, since it is meaningless for live windows like the
6797 selected window.
61ccba97 6798
2071918e
DA
67992011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6800
6801 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6802
b50a28de
SM
68032011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6804
6805 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6806 (graft_intervals_into_buffer): Simplify.
6807
015137db
EZ
68082011-11-18 Eli Zaretskii <eliz@gnu.org>
6809
6810 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6811 hash values of the two rows.
6812 (copy_row_except_pointers): Preserve the used[] arrays and the
6813 hash values of the two rows. (Bug#10035)
68c95424 6814 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6815
6816 * xdisp.c (row_hash): New function, body extracted from
6817 compute_line_metrics.
6818 (compute_line_metrics): Call row_hash, instead of computing the
6819 hash code inline.
6820
6821 * dispnew.c (verify_row_hash): Call row_hash for computing the
6822 hash code of a row, instead of duplicating code from xdisp.c.
6823
6824 * dispextern.h (row_hash): Add prototype.
6825
a2addb04
TH
68262011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6827
6828 * frame.c (delete_frame): Don't delete the terminal when the last
6829 X frame is closed if emacs is built with GTK toolkit.
6830
df85d315
JB
68312011-11-17 Juanma Barranquero <lekktu@gmail.com>
6832
6833 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6834
a0c2d0ae
MR
68352011-11-17 Martin Rudalics <rudalics@gmx.at>
6836
6837 * window.c (Vwindow_splits): Rename to
6838 Vwindow_combination_resize. Suggested by Juri Linkov.
6839 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6840 of Vwindow_splits.
6841
58179cce
JB
68422011-11-16 Juanma Barranquero <lekktu@gmail.com>
6843
7877f373
JB
6844 * nsfns.m (Fns_font_name):
6845 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6846
b6f67890
MR
68472011-11-16 Martin Rudalics <rudalics@gmx.at>
6848
6849 * window.h (window): Rename slot "nest" to "combination_limit".
6850 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6851 (Fset_window_nest): Rename to Fset_window_combination_limit.
6852 (Vwindow_nest): Rename to Vwindow_combination_limit.
6853 (recombine_windows, make_parent_window, make_window)
6854 (Fsplit_window_internal, saved_window)
6855 (Fset_window_configuration, save_window_save): Rename all
6856 occurrences of window_nest to window_combination_limit.
6857
c7015153
JB
68582011-11-15 Juanma Barranquero <lekktu@gmail.com>
6859
6860 * image.c (imagemagick_load_image): Fix typo.
6861
322ad6ec
EZ
68622011-11-14 Eli Zaretskii <eliz@gnu.org>
6863
6864 * xdisp.c (display_line): Move the call to
6865 highlight_trailing_whitespace before the call to
6866 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6867 faces of all the glyphs to compute ROW's hash value.
6868 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6869
f067b8ec
JB
68702011-11-14 Juanma Barranquero <lekktu@gmail.com>
6871
6872 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6873 just return (bug#10044).
6874
1e5b2111
EZ
68752011-11-12 Eli Zaretskii <eliz@gnu.org>
6876
7ef3cbd5
EZ
6877 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6878 with user-defined heap size. Bump the default size of the temacs
6879 heap to 27MB, to avoid memory warning when running temacs.
6880 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6881
1e5b2111
EZ
6882 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6883 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6884 (verify_row_hash) [XASSERTS]: New function.
6885 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6886 that the hash value of glyph rows is correct.
1e5b2111 6887
89d61221
MR
68882011-11-12 Martin Rudalics <rudalics@gmx.at>
6889
6890 * window.h (window): Remove splits slot.
6891 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6892 (Fdelete_other_windows_internal, make_parent_window)
6893 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6894 (Fset_window_configuration, save_window_save): Don't deal with
6895 split status of windows.
6896 (saved_window): Remove splits slot.
6897 (Vwindow_splits): Rewrite doc-string.
6898
97f18cc8
JD
68992011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6900
6901 * xfns.c (unwind_create_frame):
6902 * nsfns.m (unwind_create_frame):
6903 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6904 Vframe_list (Bug#9999).
6905
22a648b4
DA
69062011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6907
0b381c7e 6908 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6909
659afede
KH
69102011-11-11 Kenichi Handa <handa@m17n.org>
6911
6912 * callproc.c (Fcall_process): Set the member dst_multibyte of
6913 process_coding.
6914
9ac0394b
KH
69152011-11-11 Johan Bockgård <bojohan@gnu.org>
6916
6917 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6918 avoid a crash (bug#9496).
6919
2fbdc249
CY
69202011-11-09 Chong Yidong <cyd@gnu.org>
6921
6922 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6923 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6924
ac6b1f81
PE
69252011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6926
6927 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6928
09db192c
PE
69292011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6930
6931 Avoid some portability problems by eschewing 'extern inline' functions.
6932 The trivial performance wins aren't worth the portability hassles; see
6933 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6934 et seq.
6935 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6936 (window_box_width, window_box_left, window_box_left_offset)
6937 (window_box_right, window_box_right_offset): Undo previous change,
6938 by removing the "extern"s.
6939 * intervals.c (adjust_intervals_for_insertion)
6940 (adjust_intervals_for_deletion): Undo previous change,
6941 making these static again.
6942 (offset_intervals, temp_set_point_both, temp_set_point)
6943 (copy_intervals_to_string): No longer inline.
6944 * xdisp.c (window_text_bottom_y, window_box_width)
6945 (window_box_height, window_box_left_offset)
6946 (window_box_right_offset, window_box_left, window_box_right)
6947 (window_box): No longer inline.
6948
105216ed
CY
69492011-11-08 Chong Yidong <cyd@gnu.org>
6950
6951 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6952 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6953 Signal an error if not a live window.
105216ed
CY
6954 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6955 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6956
ae9e237f
JB
69572011-11-07 Juanma Barranquero <lekktu@gmail.com>
6958
6959 * lisp.h (syms_of_abbrev): Remove declaration.
6960 Reported by CHENG Gao <chenggao@royau.me>.
6961
c7aa8333
EZ
69622011-11-07 Eli Zaretskii <eliz@gnu.org>
6963
6964 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6965 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6966 of temacs in GUI mode.
6967
be7f5545
MR
69682011-11-07 Martin Rudalics <rudalics@gmx.at>
6969
6970 * window.h: Declare delete_all_child_windows instead of
6971 delete_all_subwindows.
6972 * window.c (Fwindow_nest, Fset_window_nest)
6973 (Fset_window_new_total, Fset_window_new_normal)
6974 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6975 (delete_all_subwindows): Rename to delete_all_child_windows.
6976 (Fdelete_other_windows_internal, Fset_window_configuration):
6977 Call delete_all_child_windows instead of delete_all_subwindows.
6978 * frame.c (delete_frame): Call delete_all_child_windows instead
6979 of delete_all_subwindows.
6980
ca78dc43
PE
69812011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6982
6983 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6984 This is also needed for porting to any host where GC_MARK_STACK is
6985 not GC_MAKE_GCPROS_NOOPS.
6986 (which_symbols): Use it.
6987
a0241d01
KH
69882011-11-07 Kenichi Handa <handa@m17n.org>
6989
6990 * coding.c (coding_set_destination): Check coding->src_pos only
6991 when coding->src_object is a buffer (bug#9910).
6992
6993 * process.c (send_process): Set the member src_multibyte of coding
6994 to 0 (bug#9911) when sending a unibyte text.
6995
6996 * callproc.c (Fcall_process): Set the member src_multibyte of
6997 process_coding to 0 (bug#9912).
6998
a64bfdfa 69992011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
7000
7001 * xmenu.c (cleanup_widget_value_tree): New function.
7002 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
7003 calling free_menubar_widget_value_tree directly (Bug#9830).
7004
cb41b32a
PE
70052011-11-06 Paul Eggert <eggert@cs.ucla.edu>
7006
7007 Fix some portability problems with 'inline'.
7008 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
7009 (window_box_width, window_box_left, window_box_left_offset)
7010 (window_box_right, window_box_right_offset): Declare extern.
7011 Otherwise, these inline functions do not conform to C99 and
7012 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
7013 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
7014 * intervals.c (adjust_intervals_for_insertion)
7015 (adjust_intervals_for_deletion): Now extern, because otherwise the
7016 extern inline functions 'offset_intervals' couldn't refer to it.
7017 (static_offset_intervals): Remove.
7018 (offset_intervals): Rewrite using the old contents of
7019 static_offset_intervals. The old version didn't conform to C99
7020 because an extern inline function contained a reference to an
7021 identifier with static linkage.
7022
b7041366
AS
70232011-11-06 Andreas Schwab <schwab@linux-m68k.org>
7024
7025 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
7026 GC.
7027
88a37c4d
EZ
70282011-11-06 Eli Zaretskii <eliz@gnu.org>
7029
7030 * xdisp.c (init_iterator, reseat_to_string): Don't set the
7031 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
7032 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
7033 return Qleft_to_right.
7034
49745b39
CY
70352011-11-06 Chong Yidong <cyd@gnu.org>
7036
7037 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
7038 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
7039 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
7040 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
7041 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
7042 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
7043 (Fwindow_vscroll): Doc fix.
7044 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
7045 argument, since it makes no sense to pass a live window and for
7046 consistency with window-child.
7047
1f05cd82
CS
70482011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
7049
7050 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
7051 support MSVC.
7052
22610910
JR
70532011-11-05 Jason Rumney <jasonr@gnu.org>
7054
7055 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
7056 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
7057 fonts (Bug#6029).
7058 (add_font_entity_to_list): Fix logic errors in mixed boolean and
7059 bitwise arithmetic preventing use of unicode-sip and non-truetype
7060 opentype fonts.
7061
a06776b2
EZ
70622011-11-05 Eli Zaretskii <eliz@gnu.org>
7063
3ad924ba
EZ
7064 * s/ms-w32.h (fstat, stat, utime): Move redirections to
7065 "emacs"-only part.
7066
a06776b2
EZ
7067 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
7068 initialization code to keep similarity to xfns.c after changes
7069 from 2011-11-05.
7070
c9e7db78
JD
70712011-11-05 Jan Djärv <jan.h.d@swipnet.se>
7072
a97f8f3f
JD
7073 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
7074 (unwind_create_frame): New function (Bug#9943).
7075 (Fx_create_frame): Restructure code to be more similar to the one in
7076 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
7077 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
7078 Move terminal->reference_count++ just before making the frame official
7079 (Bug#9943).
7080
7081 * nsterm.m (x_free_frame_resources): New function.
7082 (x_destroy_window): Move code to x_free_frame_resources.
7083
c9e7db78 7084 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
7085 (Fx_create_frame, x_create_tip_frame):
7086 Move terminal->reference_count++ just before making the frame
75f1671a 7087 official. Move initialization of image_cache_refcount and
c9e7db78
JD
7088 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
7089
a6fc3b5c
EZ
70902011-11-05 Eli Zaretskii <eliz@gnu.org>
7091
7092 Support MSVC build with newer versions of Visual Studio.
7093 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
7094 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
7095 nt/gmake.defs.
7096
7097 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
7098 which are not supported by MSVC.
7099 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
7100 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
7101 bitfields.
7102 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
7103 types in bitfields.
7104 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
7105
7106 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
7107
58179cce 71082011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
7109
7110 Support MSVC build with newer versions of Visual Studio.
7111 * w32.c: Don't include w32api.h for MSVC.
7112 (init_environment) [_MSC_VER]: Call sys_access, not _access.
7113
7114 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
7115 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
7116 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
7117 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
7118 e_* cousins.
7119 (alloca) [_MSC_VER]: Define to _alloca.
7120
7121 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
7122
7123 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
7124
a58c13ed
EZ
71252011-11-04 Eli Zaretskii <eliz@gnu.org>
7126
7127 * xdisp.c (note_mouse_highlight): If either of
7128 previous/next-single-property-change returns nil, treat that as
7129 the beginning or the end of the buffer. (Bug#9955)
7130
fe0b6370
JD
71312011-11-04 Jan Djärv <jan.h.d@swipnet.se>
7132
a58c13ed 7133 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
7134 label is not null (Bug#9951).
7135 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
7136 may be NULL.
7137
89bd5ee1
EZ
71382011-11-04 Eli Zaretskii <eliz@gnu.org>
7139
7140 * window.c (Fwindow_body_size): Mention in the doc string that the
7141 return value is in frame's canonical units. (Bug#9949)
7142
84c3edb9
EZ
71432011-11-03 Eli Zaretskii <eliz@gnu.org>
7144
4e2fb5c7
EZ
7145 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
7146
84c3edb9 7147 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 7148 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 7149 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 7150
bc17a887
EZ
71512011-11-01 Eli Zaretskii <eliz@gnu.org>
7152
7153 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
7154 Don't stop backward scan on the continuation glyph, even though
7155 its CHARPOS is positive.
6d5eb5b0
SM
7156 (mouse_face_from_buffer_pos, note_mouse_highlight):
7157 Rename cover_string to disp_string.
bc17a887 7158
4ee88440
MR
71592011-11-01 Martin Rudalics <rudalics@gmx.at>
7160
7161 * window.c (temp_output_buffer_show): Don't use
7162 Vtemp_buffer_show_specifiers.
7163 (Vtemp_buffer_show_specifiers): Remove unused variable.
7164
c2ff3c02
EZ
71652011-10-30 Eli Zaretskii <eliz@gnu.org>
7166
7167 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
7168 past the beginning of the current glyph matrix.
7169
58179cce 71702011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
7171
7172 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
7173 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
7174 HAVE_GTK3 (Bug#9869).
b77a6a7f 7175
3b574623
JD
7176 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
7177 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
7178
b77a6a7f
JD
7179 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
7180
7181 * xterm.c: Declare x_handle_net_wm_state to return int.
7182 (handle_one_xevent): Check if we are iconified but don't have
7183 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
7184 (get_current_wm_state): Return non-zero if not hidden,
7185 check for _NET_WM_STATE_HIDDEN (Bug#9893).
7186 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
7187 (x_handle_net_wm_state): Return what get_current_wm_state returns.
7188 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
7189
196e41e4
PE
71902011-10-29 Paul Eggert <eggert@cs.ucla.edu>
7191
7192 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
7193 so that this new function doesn't get optimized away by a
7194 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
7195
021f2e1a
AS
71962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7197
7198 * frame.h (MOUSE_HL_INFO): Remove excess parens.
7199
8b058d44
EZ
72002011-10-29 Eli Zaretskii <eliz@gnu.org>
7201
7202 Fix the `xbytecode' command.
7203 * .gdbinit (xprintbytestr): New command.
b50a28de 7204 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
7205 (xbytecode): Print the byte-code string as well.
7206
4452fb80
EZ
72072011-10-29 Kim Storm <storm@cua.dk>
7208
8b058d44
EZ
7209 * alloc.c (which_symbols): New function.
7210
21b72067
AS
72112011-10-29 Andreas Schwab <schwab@linux-m68k.org>
7212
7213 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
7214 line. (Bug#9903)
7215
83ed7b5c
GM
72162011-10-29 Glenn Morris <rgm@gnu.org>
7217
7218 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
7219 Not clear what it was for, and it causes various bugs. (Bug#9839)
7220
5a7a728b
EZ
72212011-10-28 Eli Zaretskii <eliz@gnu.org>
7222
7223 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
7224 possible random value that matches one of those tested as
7225 condition to clear the mouse face.
7226
d3d0842f
CY
72272011-10-28 Chong Yidong <cyd@gnu.org>
7228
7229 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
7230
31b39d13
DN
72312011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
7232
7233 * window.c (make_window): Initialize phys_cursor_on_p.
7234
9aba6043
SM
72352011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
7236
7237 * lisp.h (struct Lisp_Symbol): Update comments.
7238
c20992f4
JB
72392011-10-28 Juanma Barranquero <lekktu@gmail.com>
7240
7241 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
7242
db4f02f2
EZ
72432011-10-28 Eli Zaretskii <eliz@gnu.org>
7244
7245 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
7246 <oslsachem@gmail.com> for helping to debug this.
7247
7248 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
7249 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
7250 (g_b_init_get_glyph_outline_w): New static variables.
7251 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
7252 (GetGlyphOutlineW_Proc): New typedefs.
7253 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
7254 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
7255 New functions.
7256 (w32font_open_internal, compute_metrics):
7257 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
7258 instead of calling the "wide" APIs directly.
7259
7260 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
7261
7262 * w32.h (syms_of_w32font): Add prototype.
7263
87e68db4
JB
72642011-10-27 Juanma Barranquero <lekktu@gmail.com>
7265
7266 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
7267 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
7268 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
7269 (Fmove_to_window_line): Doc fix.
7270
435c1d67
CY
72712011-10-27 Chong Yidong <cyd@gnu.org>
7272
7273 * process.c (make_process): Set gnutls_state to NULL.
7274
7275 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
7276 non-NULL, regardless of GNUTLS_INITSTAGE.
7277 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
7278 an error. Set process slots as soon as we allocate them.
7279
7280 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
7281
9c6c6f49
CY
72822011-10-27 Chong Yidong <cyd@gnu.org>
7283
9aba6043
SM
7284 * gnutls.c (emacs_gnutls_deinit): New function.
7285 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
7286 (Fgnutls_deinit, Fgnutls_boot): Use it.
7287
7288 * process.c (make_process): Initialize GnuTLS credentials to NULL.
7289 (deactivate_process): Call emacs_gnutls_deinit.
7290
657d08d3
JB
72912011-10-27 Juanma Barranquero <lekktu@gmail.com>
7292
7293 * image.c (x_create_x_image_and_pixmap):
7294 * w32.c (sys_rename, w32_delayed_load):
7295 * w32font.c (fill_in_logfont):
7296 * w32reg.c (x_get_string_resource): Silence compiler warnings.
7297
5430d399
JB
72982011-10-26 Juanma Barranquero <lekktu@gmail.com>
7299
7300 * w32fns.c (w32_default_color_map): New function,
7301 extracted from Fw32_default_color_map.
a7ef684b 7302 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 7303
fe0055fa
PE
73042011-10-25 Paul Eggert <eggert@cs.ucla.edu>
7305
7306 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
7307
e6346438
SM
73082011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
7309
7310 * keyboard.c (test_undefined): New function (bug#9751).
7311 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
7312
e112cc37
ET
73132011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
7314
7315 * sysdep.c (init_sys_modes): Fix the check for the controlling
7316 terminal (Bug#6649).
7317
7b5d6677
EZ
73182011-10-20 Eli Zaretskii <eliz@gnu.org>
7319
7320 * dispextern.h (struct bidi_it): New member next_en_type.
7321
7322 * bidi.c (bidi_line_init): Initialize the next_en_type member.
7323 (bidi_resolve_explicit_1): When next_en_pos is valid for the
7324 current character, check also for next_en_type being WEAK_EN.
7325 (bidi_resolve_weak): Don't enter the expensive loop if the current
7326 position is before next_en_pos. Record the bidi type of the first
7327 non-ET, non-BN character we find, in addition to its position.
7328 (bidi_level_of_next_char): Invalidate next_en_type when
7329 next_en_pos is over-stepped.
7330
7da0b018
PE
73312011-10-20 Paul Eggert <eggert@cs.ucla.edu>
7332
7333 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
7334 * editfns.c: Rewrite current-time-zone so that it invokes
7335 the equivalent of (format-time-string "%Z") to get the time zone name.
7336 This fixes a bug when the time zone name contains characters that
7337 need converting from the system time locale to Emacs internal format.
7338 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
7339 that patch fixed format-time-string to do the conversion, but
7340 I forgot to fix current-time-zone.
7341 (format_time_string): New function, containing most of
7342 what Fformat_time_string used to contain.
7343 (Fformat_time_string): Rewrite in terms of format_time_string.
7344 This doesn't change this function's behavior.
7345 (current-time-zone): Rewrite to use format_time_string.
7346 This fixes the bug reported by Michael Schierl in
7347 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
7348 Jason Rumney's 2007-06-07 change worked around this bug, but
7349 didn't fix it.
7350 * systime.h (tzname, timezone): Remove no-longer-used declarations.
7351
8547b010
EZ
73522011-10-19 Eli Zaretskii <eliz@gnu.org>
7353
7354 * xdisp.c (start_display): If the character at POS is displayed
7355 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
7356 (try_window_reusing_current_matrix): If a line ends in a display
7357 vector or the next line starts in a display vector, continue
7358 redrawing the window even though the character position of
7359 start_row was reached.
8547b010
EZ
7360 (Bug#9771, part 2)
7361
4e948d15
CY
73622011-10-18 Chong Yidong <cyd@gnu.org>
7363
7364 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
7365 with nobreak-char-display too.
7366
4787455f
EZ
73672011-10-18 Eli Zaretskii <eliz@gnu.org>
7368
7369 Fix part 3 of bug#9771.
7370 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
7371 (bidi_resolve_neutral): Don't enter the expensive loop looking for
7372 non-neutral characters if the current character is a paragraph
7373 separator (a.k.a. Newline). This avoids running the same
7374 expensive loop twice, once when we consume the preceding newline
7375 and the other time when the line actually needs to be displayed.
7376 Avoid the loop when we see neutrals on the base embedding level
7377 following a character whose directionality is the same as the
7378 paragraph's. This avoids running the expensive loop when a line
7379 ends in a long sequence of neutrals, like control characters.
7380 Add assertion against STRONG_AL type. Slightly rearrange code
7381 that determines the type of a neutral given the first non-neutral
7382 that follows it.
7383 (bidi_level_of_next_char): Set next_en_pos to zero when
7384 invalidating its info.
7385
2c91f553
EZ
73862011-10-17 Eli Zaretskii <eliz@gnu.org>
7387
7388 * xdisp.c (push_display_prop): Determine whether to record string
7389 or buffer position by IT->string, not by IT->method. Allow
7390 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
7391 (move_it_vertically_backward): Don't look for character position
7392 immediately after the newline when in a continuation line.
7393 (Bug#9771, part 1)
2c91f553 7394
c7b08b0d
MR
73952011-10-15 Martin Rudalics <rudalics@gmx.at>
7396
7397 * window.c (coordinates_in_window): Rewrite and delabelize
7398 vertical border check. (Bug#5357) (Bug#9618)
7399
6b02f655
SM
74002011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
7401
7402 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
7403 errors in XSetWindowBorder (bug#9310).
7404
81d40c92
DA
74052011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
7406
7407 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
7408 avoid crash when xmalloc overrun checking is enabled.
7409
d4172c3b
EZ
74102011-10-13 Eli Zaretskii <eliz@gnu.org>
7411
7412 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
7413 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
7414 cursor motion with <left> and <right> arrow keys.
7415
7416 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
7417 some callers set that themselves.
7418
b00eea75
EZ
74192011-10-12 Eli Zaretskii <eliz@gnu.org>
7420
7421 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
7422 display string and the previous row comes from the same string and
7423 is empty. (Bug#9739) (Bug#9738)
7424
8fe012c4
SM
74252011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
7426
7427 * doc.c (get_doc_string): Encode file name (bug#9735).
7428
0074aef2
EZ
74292011-10-12 Eli Zaretskii <eliz@gnu.org>
7430
79beb178
EZ
7431 * bidi.c (bidi_level_of_next_char):
7432 * xdisp.c (get_visually_first_element): Remove old incorrect
7433 comments regarding the Unicode Line Separator character.
7434
0074aef2
EZ
7435 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
7436
6e4b3fbe
DA
74372011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
7438
7439 * alloc.c (Fgc_status): Do not access beyond zombies array
7440 boundary if nzombies > MAX_ZOMBIES.
7441 * alloc.c (dump_zombies): Add missing format specifier.
7442
0324f3af
PE
74432011-10-12 Paul Eggert <eggert@cs.ucla.edu>
7444
b5525cac
PE
7445 * xdisp.c (set_cursor_from_row): Simplify conditionals,
7446 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
7447
0324f3af
PE
7448 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
7449 Some packages use them to denote characters with modifiers.
7450
e9b5f888
AS
74512011-10-11 Andreas Schwab <schwab@linux-m68k.org>
7452
7453 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
7454 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
7455 matching a pp-number. Rename parameter var to var1.
7456
127827c0
SM
74572011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
7458
7459 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
7460
c8fd3bd0
GM
74612011-10-08 Glenn Morris <rgm@gnu.org>
7462
7463 * callint.c (Fcall_interactively): Give a more explicit error for the
7464 'c' case with a non-character input. (Bug#8479)
7465
352ec8ff
EZ
74662011-10-08 Eli Zaretskii <eliz@gnu.org>
7467
03669ccb
EZ
7468 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
7469 lines.
7061c986
EZ
7470 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
7471 lines that are hscrolled on the left.
03669ccb 7472
352ec8ff
EZ
7473 * dispnew.c (buffer_posn_from_coords): Account for a possible
7474 presence of header-line. (Bug#4426)
7475
a66cfb1c
SM
74762011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
7477
6b02f655
SM
7478 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
7479 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 7480
7c5ee88e
PE
74812011-10-07 Paul Eggert <eggert@cs.ucla.edu>
7482
7483 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
7484 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
7485 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
7486 this makes Emacs dump core during garbage collection on rare
7487 occasions. sizeof is obviously inferior to offsetof here, so
7488 stick with offsetof.
7489 (GC_POINTER_ALIGNMENT): New macro.
7490 (mark_memory): Omit 3rd (offset) arg; caller changed.
7491 Don't assume EMACS_INT alignment is the same as pointer alignment.
7492
df1bbe5b
SM
74932011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
7494
7495 * keyboard.c (read_key_sequence_remapped): New var.
7496 (read_key_sequence): Compute remapping in the right buffer.
7497 (command_loop_1): Use read_key_sequence's remapping directly.
7498
51553db6
SM
74992011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
7500
32c1fffd
SM
7501 * dired.c (file_name_completion): Don't expand file name.
7502 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
7503 before checking file name handler.
7504
51553db6
SM
7505 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
7506 they've been requested explicitly (bug#9591).
7507
b6bd1599 75082011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
7509
7510 * keymap.c (Fsingle_key_description): Use make_specified_string
7511 instead of build_string to build string from push_key_description.
7512 (Bug#5193)
7513
f701dc2a
PE
75142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7515
4222c55d
PE
7516 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
7517 This fixes a Y2038 bug on 64-bit hosts.
7518 * buffer.c (reset_buffer):
7519 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
7520 (Fclear_buffer_auto_save_failure):
7521 Use 0, not -1, to represent an unset failure time, since time_t
7522 might not be signed.
7523
f701dc2a
PE
7524 Remove dependency on glibc malloc internals.
7525 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7526 Move back here from lisp.h, but with their new implementations.
7527 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7528 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
7529 * charset.c (charset_table_init): New static var.
7530 (syms_of_charset): Use it instead of xmalloc. This removes a
7531 dependency on glibc malloc internals. See Eli Zaretskii's comment in
7532 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
7533 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7534 Move back to alloc.c.
7535 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7536 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
7537
9ceebf39
JD
75382011-09-30 Jan Djärv <jan.h.d@swipnet.se>
7539
7540 * nsterm.m (windowDidResize): Call x_set_window_size only when
7541 ns_in_resize is true. Otherwise set pixelwidth/height and
7542 call change_frame_size (Bug#9628).
7543
cb993c58
PE
75442011-09-30 Paul Eggert <eggert@cs.ucla.edu>
7545
3930c88b
PE
7546 Port --enable-checking=all to Fedora 14 x86-64.
7547 * charset.c (syms_of_charset): Also account for glibc malloc's
7548 internal overhead when calculating the initial malloc maximum.
7549
cb993c58
PE
7550 Port --enable-checking=all to Fedora 14 x86.
7551 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7552 Move to lisp.h.
7553 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
7554 (overrun_check_realloc, overrun_check_free):
7555 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
7556 That way, xmalloc returns a properly-aligned pointer even if
7557 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
7558 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
7559 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
7560 into account when calculating the initial malloc maximum.
7561 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
7562 Move here from alloc.c, so that charset.c can use it too.
7563 Properly align; the old code wasn't right for common 32-bit hosts
7564 when configured with --enable-checking=all.
7565 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
7566 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
7567
31bed486
EZ
75682011-09-29 Eli Zaretskii <eliz@gnu.org>
7569
04c70788 7570 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
7571 use EDOM.
7572
fbcaa2f3
EZ
75732011-09-28 Eli Zaretskii <eliz@gnu.org>
7574
7575 * xdisp.c (compute_display_string_end): If there's no display
7576 string at CHARPOS, return -1.
7577
7578 * bidi.c (bidi_fetch_char): When compute_display_string_end
7579 returns a negative value, treat the character as a normal
7580 character not covered by a display string. (Bug#9624)
7581
a239d4e9
JB
75822011-09-28 Juanma Barranquero <lekktu@gmail.com>
7583
7584 * lread.c (Fread_from_string): Fix typo in docstring.
7585
88652fd5
EZ
75862011-09-27 Eli Zaretskii <eliz@gnu.org>
7587
7588 * xdisp.c (handle_invisible_prop): If invisible text ends on a
7589 newline, reseat the iterator instead of bidi-iterating there one
7590 character at a time. (Bug#9610)
32c1fffd
SM
7591 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
7592 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 7593
ed497dd4
AS
75942011-09-27 Andreas Schwab <schwab@linux-m68k.org>
7595
7596 * lread.c (readevalloop): Use correct code for NBSP.
7597 (read1): Likewise. (Bug#9608)
7598
b2bf61aa
MA
75992011-09-25 Michael Albinus <michael.albinus@gmx.de>
7600
7601 * dbusbind.c (Fdbus_register_signal): When service is not
7602 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
7603
32bbb17c
GM
76042011-09-25 Glenn Morris <rgm@gnu.org>
7605
7606 * buffer.c (truncate-lines): Doc fix.
7607
94e0933e
CY
76082011-09-24 Chong Yidong <cyd@stupidchicken.com>
7609
7610 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
7611 (Fset_window_next_buffers): Doc fix.
7612
cddde921
GM
76132011-09-24 Glenn Morris <rgm@gnu.org>
7614
7615 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
7616
1260aef1
PE
76172011-09-24 Paul Eggert <eggert@cs.ucla.edu>
7618
25b4bfa0
PE
7619 Fix minor problems found by static checking.
7620 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
7621 * indent.c (Fvertical_motion): Fix == vs = typo.
7622
e3cbd34b
EZ
76232011-09-24 Eli Zaretskii <eliz@gnu.org>
7624
a66cfb1c
SM
7625 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
7626 Default value is now t. Doc fix.
6bf7006f 7627
e3cbd34b 7628 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 7629 logic when moving up, not only when moving down. Fix the
e3cbd34b 7630 confusing name and values of the it_overshoot_expected variable;
32c1fffd 7631 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
7632
7633 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
7634 CHARPOS is covered by a display string which includes newlines.
7635 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
7636 is covered by a display string with embedded newlines.
7637
a3de0cbd
MA
76382011-09-24 Michael Albinus <michael.albinus@gmx.de>
7639
7640 * dbusbind.c (Fdbus_register_signal): Add match rule to
7641 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
7642 (Fdbus_register_method, Vdbus_registered_objects_table):
7643 Fix docstring.
a3de0cbd 7644
b260039d
JM
76452011-09-24 Jim Meyering <meyering@redhat.com>
7646
32c1fffd 7647 do not ignore write error for any output size
b260039d
JM
7648 The previous change was incomplete.
7649 While it makes emacs --batch detect the vast majority of stdout
7650 write failures, errors were still ignored whenever the output size is
7651 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
7652 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
7653 && echo FAIL: ignored write error
7654 FAIL: ignored write error
7655 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
7656 && echo FAIL: ignored write error
7657 FAIL: ignored write error
7658 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
7659
8eca8a7c
AS
76602011-09-23 Andreas Schwab <schwab@linux-m68k.org>
7661
7662 * emacs.c (Fkill_emacs): In noninteractive mode exit
7663 non-successfully if a write error occurred on stdout. (Bug#9574)
7664
3341db62
EZ
76652011-09-21 Eli Zaretskii <eliz@gnu.org>
7666
7667 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
7668 the xassert test.
7669
7670 * dispextern.h (struct it): Update the comment documenting what
7671 can it->OBJECT be.
7672
8c203dbf
EZ
76732011-09-20 Eli Zaretskii <eliz@gnu.org>
7674
7675 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
7676 a display string, extend search for cursor position to end of row.
7677 (find_row_edges): If the row ends in a newline from a display
7678 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
7679 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
7680 (Fcurrent_bidi_paragraph_direction): Fix search for previous
7681 non-empty line. Fixes confusing cursor motion with arrow keys at
7682 the beginning of a line that starts with whitespace.
8c203dbf 7683
a4824228
LMI
76842011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
7685
7686 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
7687 (bug#9493).
7688
33ed493b
CY
76892011-09-18 Chong Yidong <cyd@stupidchicken.com>
7690
7691 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
7692 boolean (Bug#9154).
7693
56cd55c8
EZ
76942011-09-18 Eli Zaretskii <eliz@gnu.org>
7695
7696 * xdisp.c (display_line): Record maximum and minimum buffer
7697 positions even if no glyphs were produced (e.g., by a zero-width
7698 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
7699 buffer positions that will be removed from the glyph row because
7700 they don't fit.
c02dcedf
EZ
7701 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
7702 column is beyond frame width: don't subtract 1 "pixel" when
7703 computing width of the stretch.
3e62b7e0
EZ
7704 (reseat_at_next_visible_line_start): Undo the change made on
7705 2011-09-17 that saved paragraph information and restored it after
7706 the call to `reseat'. (Bug#9545)
56cd55c8 7707
5ed99d36 77082011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
7709
7710 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
7711 and turn window cursor on if cleared (Bug#9415).
7712
5ed99d36 77132011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
7714
7715 * search.c (boyer_moore): Take unibyte characters from pattern
7716 literally. (Bug#9458)
7717
9bade7b2
EZ
77182011-09-18 Eli Zaretskii <eliz@gnu.org>
7719
7720 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
7721
e5e9d610
PE
77222011-09-18 Paul Eggert <eggert@cs.ucla.edu>
7723
87e4427a
PE
7724 Fix minor problem found by static checking.
7725 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
7726 initialized, to pacify gcc -Wuninitialized.
7727
e5e9d610
PE
7728 * fileio.c: Report proper errno when syscall falls.
7729 (Finsert_file_contents): Save and restore errno,
7730 so that report_file_error outputs the correct diagnostic.
7731 (Fwrite_region) [CLASH_DETECTION]: Likewise.
7732
a1674f0b
EZ
77332011-09-18 Eli Zaretskii <eliz@gnu.org>
7734
7735 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
7736
fbfb6dd4
EZ
77372011-09-17 Eli Zaretskii <eliz@gnu.org>
7738
7739 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
7740 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
7741
bb187662
EZ
77422011-09-17 Eli Zaretskii <eliz@gnu.org>
7743
1137e8b8 7744 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 7745 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
7746
7747 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
7748 (bidi_find_paragraph_start): Search back for paragraph beginning
7749 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
7750 (bidi_move_to_visually_next): Only trigger paragraph-related
7751 computations when the last character is a newline or at EOB, not
7752 just any NEUTRAL_B. (Bug#9470)
7753
bb187662
EZ
7754 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
7755 truncated lines if point is covered by a display string. (Bug#9524)
7756
2e621251
PE
77572011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7758
7759 * xselect.c: Relax test for outgoing X longs (Bug#9498).
7760 (cons_to_x_long): New function.
7761 (lisp_data_to_selection_data): Use it. Correct the test for
7762 short-versus-long data; it was negated. Break out of vector
7763 loop, for efficiency, when a long datum is discovered.
7764
91a15bc6
SM
77652011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
7766
7767 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
7768
b41c3a35
EZ
77692011-09-16 Eli Zaretskii <eliz@gnu.org>
7770
7771 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
7772 GCC PR/17406) by declaring this function with external scope.
7773
7812ba2d
PE
77742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7775
7776 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
7777 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
7778
cf7edc2a
AS
77792011-09-15 Andreas Schwab <schwab@linux-m68k.org>
7780
7781 * editfns.c (Fformat): Correctly handle text properties on "%%".
7782
bd01620e
EZ
77832011-09-15 Eli Zaretskii <eliz@gnu.org>
7784
7785 * xterm.c (x_draw_composite_glyph_string_foreground):
7786 * w32term.c (x_draw_composite_glyph_string_foreground):
7787 * term.c (encode_terminal_code):
7788 * composite.c (composition_update_it, get_composition_id):
7789 * xdisp.c (get_next_display_element)
7790 (fill_composite_glyph_string): Add comments about special meaning
7791 of TAB characters in a composition.
7792
a02719a3
PE
77932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7794
7795 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7796 This occurs when processing a multibyte format.
7797 Problem reported by Wolfgang Jenker.
a02719a3 7798
72589a3c
JB
77992011-09-15 Johan Bockgård <bojohan@gnu.org>
7800
7801 * xdisp.c (try_cursor_movement): Only check for exact match if
7802 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7803
1c14176c
PE
78042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7805
7806 Remove unused external symbols.
7807 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7808 * xdisp.c (calc_pixel_width_or_height): Now static.
7809 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7810 * indent.c (check_display_width):
7811 * w32term.c: Fix comment to match code.
7812 * xterm.c, xterm.h (x_catching_errors): Remove.
7813
d2eea5b5
PE
78142011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7815
7816 * xselect.c: Use signed conversions more consistently (Bug#9498).
7817 (selection_data_to_lisp_data): Assume incoming selection data are
7818 signed integers, not unsigned. This is to be consistent with
7819 outgoing selection data, which was modified to use signed integers
7820 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7821 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7822 expects long, not unsigned long.
7823
46888499
EZ
78242011-09-14 Eli Zaretskii <eliz@gnu.org>
7825
7826 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7827 computation of loop end. Reported by Johan Bockgård
7828 <bojohan@gnu.org>.
7829
ef8ef9fb
CY
78302011-09-13 Chong Yidong <cyd@stupidchicken.com>
7831
7832 * frame.c (Fother_visible_frames_p): Function deleted.
7833
fa819fed
EZ
78342011-09-12 Eli Zaretskii <eliz@gnu.org>
7835
7836 * indent.c (compute_motion): Process display vector front to back
7837 rather than the other way around. (Bug#2496)
7838
2ba8e008
SM
78392011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7840
7841 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7842
20f53c69
CY
78432011-09-11 Chong Yidong <cyd@stupidchicken.com>
7844
7845 * minibuf.c (Fread_from_minibuffer): Doc fix.
7846
d562d7a4
EZ
78472011-09-11 Eli Zaretskii <eliz@gnu.org>
7848
7849 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7850 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7851
1c4d7f3d
LMI
78522011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7853
7854 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7855 value for non-existent files.
7856
b885bf36
EZ
78572011-09-11 Eli Zaretskii <eliz@gnu.org>
7858
7859 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7860 set its "size" to -1. This will set the modtime_size field of
7861 the corresponding buffer to -1, which is what
7862 verify-visited-file-modtime expects for files that do not exist.
7863 (Bug#9139)
7864
6612f0bf
PE
78652011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7866
7867 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7868 here ...
7869 * lisp.h: ... from here. push_key_description is no longer
7870 defined in keyboard.c, so its declaration should not be in
7871 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7872 logically belongs with push_key_description.
7873
dfb3f755
PE
78742011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7875
7876 * buffer.h: Include <sys/types.h> instead of <time.h>.
7877 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7878 Problem reported by Herbert J. Skuhra.
7879
3134906c
LMI
78802011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7881
7882 * xml.c (parse_region): Make the parsing work for
7883 non-comment-starting XML files again (bug#9144).
7884
8d903f4e
AS
78852011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7886
7887 * image.c (gif_load): Fix calculation of bottom and right corner.
7888 (Bug#9468)
7889
80ad64f4
EZ
78902011-09-10 Eli Zaretskii <eliz@gnu.org>
7891
7892 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7893 redisplay in small windows.
7894
208a048d
EZ
78952011-09-09 Eli Zaretskii <eliz@gnu.org>
7896
7897 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7898
9b1c252e
MR
78992011-09-08 Martin Rudalics <rudalics@gmx.at>
7900
7901 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7902 Operate on live windows only.
7903
2949f33b
JB
79042011-09-08 Juanma Barranquero <lekktu@gmail.com>
7905
7906 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7907
e08dcafd
EZ
79082011-09-07 Eli Zaretskii <eliz@gnu.org>
7909
7910 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7911 only under bidi iteration.
7912
115b96bd
JD
79132011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7914
7915 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7916
c8199d0f
PE
79172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7918
7919 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7920 Without this fix, the command to link temacs failed due to an
7921 undefined symbol __builtin_isnan. This is because
7922 /usr/include/iso/math_c99.h #defines isnan(x) to
7923 __builtin_isnan(x), but the bundled gcc, which identifies itself
7924 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7925 a __builtin_isnan.
7926 * floatfns.c (isnan): #undef, and then #define to a clone of
7927 what's in data.c.
7928 (Fisnan): Always define, since it's always available now.
7929 (syms_of_floatfns): Always define isnan at the Lisp level.
7930
e39b275c 79312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7932
7933 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7934
b2db44d9 79352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7936
f4af5137 7937 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7938 The previous code assumed that file offsets (off_t values) fit in
7939 EMACS_INT variables, which is not true on typical 32-bit hosts.
7940 The code messed up by falsely reporting buffer overflow in cases
7941 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7942 when "big" contains more than 2**29 bytes, even though this
7943 inserts just one byte and does not overflow the buffer.
7944 (Finsert_file_contents): Store file offsets as off_t
7945 values, not as EMACS_INT values. Check for overflow when
7946 converting between EMACS_INT and off_t. When checking for
7947 buffer overflow or for overlap, take the offsets into account.
7948 Don't use EMACS_INT for small values where int suffices.
7949 When checking for overlap, fix a typo: ZV was used where
7950 ZV_BYTE was intended.
7951 (Fwrite_region): Don't assume off_t fits into 'long'.
7952 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7953
ecfc0a49
MA
79542011-09-05 Michael Albinus <michael.albinus@gmx.de>
7955
7956 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7957
6511acf2 79582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7959
0999621a 7960 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7961
7962 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7963 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7964 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7965 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7966 (modify_event_symbol): Do not assume that the length of
7967 name_alist_or_stem is safe to alloca and fits in int.
7968 (Fexecute_extended_command): Likewise for function name and binding.
7969 (Frecursion_depth): Wrap around reliably on integer overflow.
7970 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7971 since some callers pass EMACS_INT values.
7972 (Fsingle_key_description): Don't crash if symbol name contains more
7973 than MAX_ALLOCA bytes.
7974 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7975 (get_minibuffer): Arg is now EMACS_INT, not int.
7976 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7977 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7978 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7979
2be7d702
PE
7980 * dbusbind.c (signature_cat): New function.
7981 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7982 Do not overrun buffer; instead, report string overflow.
7983
9d1df220
PE
7984 * dispnew.c (add_window_display_history): Don't overrun buffer.
7985 Truncate instead; this is OK since it's just a log.
7986
33ef5c64
PE
7987 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7988 even if the time zone offset is outlandishly large.
7989 Don't mishandle offset == INT_MIN.
7990
66c6fdd5
PE
7991 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7992 when creating daemon; the previous buffer-overflow check was incorrect.
7993
d749b01b
PE
7994 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7995 which has the guts of the old verror function.
7996
b5cd1905
PE
7997 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7998 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7999
6e1a67fb
PE
8000 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
8001 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 8002 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 8003 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
8004 length of string rather than counting it via multiple sprintfs;
8005 that's simpler and more reliable.
c21721cc
PE
8006 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
8007 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
8008 sprintf, in case result does not fit in int.
8009
c57b67fc
PE
8010 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
8011 (fontset_from_font): Print it.
8012
8a401434
PE
8013 * frame.c (tty_frame_count): Now printmax_t, not int.
8014 (make_terminal_frame, set_term_frame_name): Print it.
8015 (x_report_frame_params): In X, window IDs are unsigned long,
8016 not signed long, so print them as unsigned.
8017 (validate_x_resource_name): Check for implausibly long names,
8018 and don't assume name length fits in 'int'.
8019 (x_get_resource_string): Don't blindly alloca invocation name;
8020 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
8021 not fit in int.
8022
6e1a67fb
PE
8023 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
8024 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
8025 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
8026
0df02bf3
PE
8027 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
8028 Use esprintf, not sprintf, in case result does not fit in int.
8029
48e30793
PE
8030 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8031 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
8032 it as a large positive number.
8033 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
8034 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
8035
a66ff6d8
PE
8036 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
8037 in case result does not fit in int.
8038
aca216ff
PE
8039 * print.c (float_to_string): Detect width overflow more reliably.
8040 (print_object): Make sprintf buffer a bit bigger, to avoid potential
8041 buffer overrun. Don't assume list length fits in 'int'. Treat
8042 print length of 0 as 0, not as infinity; to be consistent with other
8043 uses of print length in this function. Don't overflow print length
8044 index. Don't assume hash table size fits in 'long', or that
8045 vectorlike size fits in 'unsigned long'.
8046
31c286f7
PE
8047 * process.c (make_process): Use printmax_t, not int, to format
8048 process-name gensyms.
8049
55e5faa1
PE
8050 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
8051
80f2e268
PE
8052 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
8053 to avoid potential buffer overrun.
8054
670741ab
PE
8055 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
8056 if X resource line is longer than 512 bytes.
8057
b7163a50
PE
8058 * xfns.c (x_window): Make sprintf buffer a bit bigger
8059 to avoid potential buffer overrun.
8060
ae58ff1f
PE
8061 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
8062
c43c8a6a
PE
8063 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
8064
3f8236f4
PE
80652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
8066
53e9fe90 8067 Integer overflow fixes for scrolling, etc.
6511acf2
PE
8068 Without these, Emacs silently mishandles large integers sometimes.
8069 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
8070 it were "C-u 1 M-x recenter" on a typical 64-bit host.
8071
6511acf2
PE
8072 * xdisp.c (try_window_id): Check Emacs fixnum range before
8073 converting to 'int'.
806add1d 8074
6511acf2 8075 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
8076 Check that an Emacs fixnum is in range before assigning it to 'int'.
8077 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
8078 values converted from Emacs fixnums.
8079 (Frecenter): Don't wrap around a line count if it is out of 'int'
8080 range; instead, treat it as an extreme value.
8081 (Fset_window_configuration, compare_window_configurations):
8082 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
8083
6511acf2
PE
8084 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
8085 that can exceed INT_MAX. Check that EMACS_INT value is in range
8086 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
8087 (match_limit): Don't assume that a fixnum can fit in 'int'.
8088
6511acf2 8089 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
8090 exceed INT_MAX.
8091
6511acf2 8092 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
8093 (Fvertical_motion): Don't wrap around LINES values that don't fit
8094 in 'int'. Instead, treat them as extreme values. This is good
8095 enough for windows, which can't have more than INT_MAX lines anyway.
8096
fcb901a7
LMI
80972011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
8098
0f2f6b6d
LMI
8099 * Require libxml/parser.h to avoid compilation warning.
8100
fcb901a7
LMI
8101 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
8102
8103 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
8104 since this reportedly can destroy thread storage.
8105
6e20a0d4
CY
81062011-08-30 Chong Yidong <cyd@stupidchicken.com>
8107
8108 * syntax.c (find_defun_start): Update all cache variables if
8109 exiting early (Bug#9401).
8110
148ae00e
EZ
81112011-08-30 Eli Zaretskii <eliz@gnu.org>
8112
f6cfbd8f
EZ
8113 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
8114
148ae00e
EZ
8115 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
8116 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
8117 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
8118
8119 * term.c (tty_append_glyph): New function.
8120 (produce_stretch_glyph): Static function and its prototype deleted.
8121
a66cfb1c
SM
8122 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
8123 Add prototypes.
148ae00e 8124
c4a07a4c
PE
81252011-08-29 Paul Eggert <eggert@cs.ucla.edu>
8126
8127 * image.c (parse_image_spec): Check for nonnegative, not for positive,
8128 when checking :margin (Bug#9390).
8129 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 8130 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
8131 so that the name doesn't mislead. All uses changed.
8132
6bc8cd65
JB
81332011-08-28 Johan Bockgård <bojohan@gnu.org>
8134
8135 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
8136 set_tty_hooks.
8137
dca4927e
EZ
81382011-08-27 Eli Zaretskii <eliz@gnu.org>
8139
8140 * xdisp.c (move_it_to): Don't bail out early when reaching
8141 position beyond to_charpos, if we are scanning backwards.
8142 (move_it_vertically_backward): When DY == 0, make sure we get to
8143 the first character in the line after the newline.
8144
f2cad773
PE
81452011-08-27 Paul Eggert <eggert@cs.ucla.edu>
8146
8147 * ccl.c: Improve and simplify overflow checking (Bug#9196).
8148 (ccl_driver): Do not generate an out-of-range pointer.
8149 (Fccl_execute_on_string): Remove unnecessary check for
8150 integer overflow, noted by Stefan Monnier in
8151 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
8152 Remove a FIXME that didn't need fixing.
8153 Simplify the newly-introduced buffer reallocation code.
8154
0cae2cdb
JB
81552011-08-27 Juanma Barranquero <lekktu@gmail.com>
8156
8157 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
8158
5fc295a4 81592011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 8160
70c60eb2 8161 Integer and memory overflow issues (Bug#9196).
726e0ab1 8162
d31850da
PE
8163 * doc.c (get_doc_string): Rework so that
8164 get_doc_string_buffer_size is the actual buffer size, rather than
8165 being 1 less than the actual buffer size; this makes xpalloc more
8166 convenient.
8167
a69fbedb
PE
8168 * image.c (x_allocate_bitmap_record, cache_image):
8169 * xselect.c (Fx_register_dnd_atom):
8170 Simplify previous changes by using xpalloc.
8171
fe5c5d37
PE
8172 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
8173 since either will do and ptrdiff_t is convenient with xpalloc.
8174
0065d054
PE
8175 * charset.c (charset_table_size)
8176 (struct charset_sort_data.priority): Now ptrdiff_t.
8177 (charset_compare): Don't overflow if priorities differ greatly.
8178 (Fsort_charsets): Don't assume list length fits in int.
8179 Check for size-calculation overflow when allocating sort data.
8180 (syms_of_charset): Allocate an initial charset table that is
8181 just under 64 KiB, to avoid problems with glibc malloc and mmap.
8182
8183 * cmds.c (internal_self_insert): Check for size-calculation overflow.
8184
8185 * composite.h (struct composition.glyph_len): Now int, not unsigned.
8186 The actual value is always <= INT_MAX, and leaving it unsigned made
8187 overflow checking harder.
8188
8189 * dispextern.h (struct glyph_matrix.rows_allocated)
8190 (struct face_cache.size): Now ptrdiff_t, for convenience in use
8191 with xpalloc. The values are still always <= INT_MAX.
8192
8193 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
8194
8195 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
8196 (SAFE_NALLOCA): New macro.
8197
8198 * region-cache.c (struct boundary.pos, find_cache_boundary)
8199 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
8200 (set_cache_region, invalidate_region_cache)
8201 (revalidate_region_cache, know_region_cache, region_cache_forward)
8202 (region_cache_backward, pp_cache):
8203 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
8204 so that ptrdiff_t * can be passed to xpalloc.
8205 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
8206 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
8207 (pp_cache): Don't assume cache_len fits in int.
8208 * region-cache.h: Adjust extern decls to match.
8209
8210 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
8211 EMACS_INT, since either will do, for xpalloc.
8212
8213 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
8214 (xnmalloc, xnrealloc, xpalloc): New functions.
8215
726e0ab1
PE
8216 * bidi.c (bidi_shelve_header_size): New constant.
8217 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
8218 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
8219
51f30bc5 8220 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
8221 * buffer.c (overlays_at, overlays_in, record_overlay_string)
8222 (overlay_strings):
8223 Don't update size of array until after memory allocation succeeds,
8224 because xmalloc/xrealloc may not return.
0065d054
PE
8225 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
8226 now that we have proper integer overflow checking.
8227 (record_overlay_string, overlay_strings): Catch overflows when
8228 calculating size of overlay_str_buf.
726e0ab1 8229
0065d054
PE
8230 * callproc.c (Fcall_process): Check for size overflow when
8231 calculating size of args2.
8232 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
8233 Normally we prefer signed values, but sticking with ptrdiff_t would
8234 require adding more-complicated checks.
726e0ab1
PE
8235
8236 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
8237 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
8238 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 8239 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
8240
8241 * character.c (Fstring): Check for size-calculation overflow.
8242
8243 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
8244 unnecessary integer overflow. Check for size overflow.
8245 (encode_coding_object): Don't update size until xmalloc succeeds.
8246
8247 * composite.c (get_composition_id): Check for overflow in glyph
8248 length calculations.
8249
8250 Integer and memory overflow fixes for display code.
8251 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
8252 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
8253 (scrolling_window): Check for overflow in size calculations.
8254 (line_draw_cost, realloc_glyph_pool, add_row_entry):
8255 Don't assume glyph table len fits in int.
8256 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
8257 (row_table_size): Now ptrdiff_t, not int.
8258 (scrolling_window): Avoid overflow in size calculations.
8259 Don't update size until allocation succeeds.
8260 * fns.c (concat): Check for overflow in size calculations.
8261 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
8262 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8263 (NEXT_ALMOST_PRIME_LIMIT): New constant.
8264
8265 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
8266 (get_doc_string): Check for size calculation overflow.
8267 Don't update size until allocation succeeds.
8268 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
8269 EMACS_INT, where ptrdiff_t will do.
8270 (Fsubstitute_command_keys): Check for string overflow.
8271
8272 * editfns.c (set_time_zone_rule): Don't assume environment length
8273 fits in int.
8274 (message_length): Now ptrdiff_t, not int.
8275 (Fmessage_box): Don't update size until allocation succeeds.
8276 Don't assume message length fits in int.
8277 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
8278
0065d054
PE
8279 * emacs.c (main): Do not reallocate argv, since there is a null at
8280 the end that can be overwritten, and this way there's no need to
8281 worry about size-calculation overflow.
8282 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
8283
8284 * eval.c (init_eval_once, grow_specpdl): Don't update size until
8285 alloc succeeds.
8286 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
8287
8288 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
8289 (x_set_scroll_bar_width, x_figure_window_size):
8290 Check for integer overflow.
8291 (x_set_alpha): Do not assume XINT fits in int.
8292
8293 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
8294 This is for the members text_lines, text_cols, total_lines, total_cols,
8295 where the system imposes an 'int' limit.
8296
8297 * fringe.c (Fdefine_fringe_bitmap):
8298 Don't update size until alloc works.
8299
8300 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
8301 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
8302
8303 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
8304 Check for size-calculation overflow.
8305 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
8306 do, as we prefer signed integers.
8307 (id_to_widget.max_size, id_to_widget.used)
8308 (xg_store_widget_in_map, xg_remove_widget_from_map)
8309 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
8310 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
8311 Use and return ptrdiff_t, not int.
8312 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
8313 * gtkutil.h: Change prototypes to match the above.
8314
8315 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
8316 are duplicate now that they've been promoted to lisp.h.
8317 (x_allocate_bitmap_record, x_alloc_image_color)
8318 (make_image_cache, cache_image, xpm_load):
8319 Don't update size until alloc is done.
8320 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
8321 (x_detect_edges):
3256efce 8322 Check for size calculation overflow.
726e0ab1
PE
8323 (ct_colors_allocated_max): New constant.
8324 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
8325 overflow.
3256efce 8326
726e0ab1
PE
8327 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
8328 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
8329 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
8330 Use ptrdiff_t, not int, to count maps.
8331 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
8332 calculations. Don't update size until allocation succeeds.
8333 Redo calculations to avoid overflow.
726e0ab1
PE
8334 * keyboard.h: Change prototypes to match the above.
8335
8336 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
8337 to count maps.
8338 (current_minor_maps): Check for size calculation overflow.
8339 * keymap.h: Change prototypes to match the above.
8340
8341 * lread.c (read1, init_obarray): Don't update size until alloc done.
8342
8343 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
8344 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
8345
726e0ab1
PE
8346 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
8347 Now ptrdiff_t, not int.
8348 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
8349 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
8350
8351 * process.c (Fnetwork_interface_list): Check for overflow
8352 in size calculation.
8353
8354 * region-cache.c (move_cache_gap): Check for size calculation overflow.
8355
8356 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
8357 overflow. Don't bother calling xmalloc when xrealloc will do.
8358
8359 * search.c (Freplace_match): Check for size calculation overflow.
8360 (Fset_match_data): Don't assume list lengths fit in 'int'.
8361
8362 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
8363 for command line length. Do not attempt to address one before the
8364 beginning of an array, as that's not portable.
8365
8366 * term.c (max_frame_lines): Remove; unused.
8367 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
8368 not int.
8369 (encode_terminal_code, calculate_costs): Check for size
8370 calculation overflow.
8371 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
8372 table lengths and related sizes. Don't update size until alloc
8373 done. Redo calculations to avoid overflow.
8374 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
8375
8376 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
8377 subtracting pointers.
8378 (gobble_line): Check for overflow more carefully. Don't update size
8379 until alloc done.
8380
8381 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
8382 Don't update size until alloc done.
8383 Redo size calculations to avoid overflow.
8384 Check for size calculation overflow.
0065d054 8385 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
8386
8387 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
8388 Use ptrdiff_t, not int, for sizes.
8389 (store_mode_line_noprop_char): Don't update size until alloc done.
8390
0065d054
PE
8391 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
8392 Use ptrdiff_t, not int, for sizes.
8393 (Finternal_make_lisp_face, cache_face):
8394 Check for size calculation overflow.
8395 (cache_face): Treat size calculation overflows as if they were
8396 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
8397
8398 * xfns.c (x_encode_text, x_set_name_internal)
8399 (Fx_change_window_property): Use ptrdiff_t, not int, to count
8400 sizes, since they can exceed INT_MAX in size. Check for size
8401 calculation overflow.
8402
0065d054
PE
8403 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
8404 (xg_select): Check for size calculation overflow.
726e0ab1
PE
8405 Don't update size until alloc done.
8406
0065d054 8407 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 8408 as sprintf is limited to int lengths.
1d526e2f 8409
252c5ee1
PE
8410 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
8411 (X_LONG_MIN): New macros.
864d7ce7
PE
8412 Use them to make the following changes clearer.
8413 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
8414 This change doesn't affect the value now, but it may help remind
8415 future maintainers not to raise the value too much later.
8416 (SELECTION_QUANTUM): Remove, replacing with ...
8417 (selection_quantum): ... new function, which avoids overflow.
8418 All uses changed.
8419 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
8420 assumption that selection length fits in 'int'.
8421 (x_reply_selection_request, x_handle_selection_request)
8422 (x_get_window_property, receive_incremental_selection)
8423 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
8424 (lisp_data_to_selection_data, clean_local_selection_data):
8425 Use ptrdiff_t, not int, to record length of selection.
8426 (x_reply_selection_request, x_get_window_property)
8427 (receive_incremental_selection, x_property_data_to_lisp):
8428 Redo calculations to avoid overflow.
8429 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 8430 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
8431 something.
8432 (x_get_window_property, receive_incremental_selection)
8433 (lisp_data_to_selection_data, x_property_data_to_lisp):
8434 Check for size-calculation overflow.
8435 (x_get_window_property, receive_incremental_selection)
8436 (lisp_data_to_selection_data, Fx_register_dnd_atom):
8437 Don't store size until memory allocation succeeds.
8438 (x_get_window_property): Plug memory leak on memory exhaustion.
8439 Don't double-block input; malloc is safe here. Don't assume 2**34
8440 - 4 fits in unsigned long. Add an xassert to check
8441 XGetWindowProperty overflow. Be more careful about overflow
8442 calculations, and distinguish size from memory overflow better.
8443 (receive_incremental_selection): When tracing, don't assume
8444 unsigned int is less than INT_MAX.
8445 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
8446 harmful) conversions of unsigned short to int.
8447 (lisp_data_to_selection_data): Don't assume that integers
8448 in the range -65535 through -1 fit in an X unsigned short.
8449 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
8450 result parameters unless successful. Rely on cons_to_unsigned
8451 to report problems with elements; the old code wasn't right anyway.
8452 (x_check_property_data): Check for int overflow; we cannot use
8453 a wider type due to X limits.
8454 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
8455
726e0ab1 8456 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 8457
0065d054
PE
8458 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
8459 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
8460 (x_color_cells): Don't store size until memory allocation succeeds.
8461 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 8462 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
8463 (x_term_init): Don't assume length fits in int (sprintf is limited
8464 to int size).
bc18e09d 8465
ebfa62c0
PE
8466 Use ptrdiff_t for composition IDs.
8467 * character.c (lisp_string_width):
8468 * composite.c (composition_table_size, n_compositions)
8469 (get_composition_id, composition_gstring_from_id):
8470 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
8471 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
8472 * window.c (Frecenter):
8473 Use ptrdiff_t, not int, for composition IDs.
8474 * composite.c (get_composition_id): Check for integer overflow.
8475 * composite.h: Adjust prototypes to match the above changes.
8476
d3411f89
PE
8477 Use ptrdiff_t for hash table indexes.
8478 * category.c (hash_get_category_set):
8479 * ccl.c (ccl_driver):
8480 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
8481 * coding.c (coding_system_charset_list, detect_coding_system):
8482 * coding.h (struct coding_system.id):
8483 * composite.c (get_composition_id, gstring_lookup_cache):
8484 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
8485 * image.c (xpm_get_color_table_h):
8486 * lisp.h (hash_lookup, hash_put):
8487 * minibuf.c (Ftest_completion):
8488 Use ptrdiff_t for hash table indexes, not int (which is too
8489 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
8490 32-bit --with-wide-int hosts).
8491
e097a6fa
PE
8492 * charset.c (Fdefine_charset_internal): Check for integer overflow.
8493 Add a FIXME comment about memory leaks.
8494 (syms_of_charset): Don't assume xmalloc returns.
8495
5637687f
PE
8496 Don't assume that stated character widths fit in int.
8497 * character.c (Fchar_width, c_string_width, lisp_string_width):
8498 * character.h (CHAR_WIDTH):
8499 * indent.c (MULTIBYTE_BYTES_WIDTH):
8500 Use sanitize_char_width to avoid undefined and/or bad behavior
8501 with outlandish widths.
a66cfb1c 8502 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
8503 now that we have two such functions. All uses changed.
8504 (sanitize_char_width): New inline function.
8505
a2271ba2
PE
8506 Don't assume that tab-width fits in int.
8507 * character.h (sanitize_width): New inline function.
8508 (SANE_TAB_WIDTH): New macro.
8509 (ASCII_CHAR_WIDTH): Use it.
8510 * indent.c (sane_tab_width): Remove. All uses replaced by
8511 SANE_TAB_WIDTH (current_buffer).
8512 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
8513
18c52557
PE
8514 * fileio.c: Integer overflow issues with file modes.
8515 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
8516
caeeedc1
PE
8517 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
8518 Remove unreachable code.
8519 (read_hex, load_charset_map_from_file): Check for integer overflow.
8520
6df6ae42 8521 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
8522 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
8523 (x_send_scroll_bar_event): Likewise. Check that the size does not
8524 exceed limits imposed by XClientMessageEvent, as well as the usual
8525 ptrdiff_t and size_t limits.
8526
b13995db
PE
8527 * keyboard.c: Overflow, signedness and related fixes.
8528 (make_lispy_movement): Use same integer type in forward decl
8529 that is used in the definition.
8530 (read_key_sequence, keyremap_step):
8531 Change bufsize argument back to int, undoing my 2011-03-30 change.
8532 We prefer signed types, and int is wide enough here.
8533 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
8534 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
8535 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
8536 length, not size_t. Use ptrdiff_t for index, not int.
8537 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
8538 possibility of integer overflow.
8539
13464394
PE
8540 Overflow, signedness and related fixes for images.
8541
8542 * dispextern.h (struct it.stack[0].u.image.image_id)
8543 (struct_it.image_id, struct image.id, struct image_cache.size)
8544 (struct image_cache.used, struct image_cache.ref_count):
8545 * gtkutil.c (update_frame_tool_bar):
8546 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
8547 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
8548 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
8549 * nsmenu.m (update_frame_tool_bar):
8550 * xdisp.c (calc_pixel_width_or_height):
8551 * xfns.c (image_cache_refcount):
8552 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
8553 on typical 64-bit hosts.
8554
8555 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
8556 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
8557 Omit unnecessary casts to int.
8558 (parse_image_spec): Check that integers fall into 'int' range
8559 when the callers expect that.
8560 (image_ascent): Redo ascent calculation to avoid int overflow.
8561 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
8562 (lookup_image): Remove unnecessary tests.
8563 (xbm_image_p): Locals are now of int, not EMACS_INT,
8564 since parse_image_check makes sure they fit into int.
8565 (png_load, gif_load, svg_load_image):
8566 Prefer int to unsigned where either will do.
8567 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
8568 old tiff_error_handler and tiff_warning_handler.
8569 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
8570 stack buffer overflows. It uses only the features of vsnprintf
8571 that are common to both POSIX and native Microsoft.
8572 (tiff_error_handler, tiff_warning_handler): Use it.
8573 (tiff_load, gif_load, imagemagick_load_image):
8574 Don't assume :index value fits in 'int'.
8575 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
8576 (imagemagick_load_image): Check that crop parameters fit into
8577 the integer types that MagickCropImage accepts. Don't assume
8578 Vimagemagick_render_type has a nonnegative value. Don't assume
8579 size_t fits in 'long'.
8580 (gs_load): Use printmax_t to print the widest integers possible.
8581 Check for integer overflow when computing image height and width.
8582
c11821d4
EZ
85832011-08-26 Eli Zaretskii <eliz@gnu.org>
8584
8585 * xdisp.c (redisplay_window): Don't force window start if point
8586 will be invisible in the resulting window. (Bug#9324)
8587
0c95fcf7
EZ
85882011-08-25 Eli Zaretskii <eliz@gnu.org>
8589
8590 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
8591 the display spec is of the form `(space ...)'.
8592 (handle_display_spec): Return the value returned by
8593 handle_single_display_spec, not just 1 or zero.
8594 (handle_single_display_spec): If the display spec is of the form
8595 `(space ...)', and specifies display in the text area, return 2
8596 rather than 1.
fee65a97 8597 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
8598 accurately, and prefer exact match for point under bidi.
8599 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
8600
8601 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
8602 into disp_prop; all users changed.
8603
8604 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
8605 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
8606 for the text covered by the display property.
8607
e4ed06f1
CY
86082011-08-25 Chong Yidong <cyd@stupidchicken.com>
8609
8610 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
8611 Change return value to nil.
8612 (Frecord_buffer): Delete unused function.
8613
f67cdd7f
EZ
86142011-08-24 Eli Zaretskii <eliz@gnu.org>
8615
5980d4c6
EZ
8616 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
8617 buffers, return left-to-right.
8610fe8b
EZ
8618 (set_cursor_from_row): Consider candidate row a win if its glyph
8619 represents a newline and point is on that newline. Fixes cursor
8620 positioning on the newline at EOL of R2L text within L2R
8621 paragraph, and vice versa.
8622 (try_cursor_movement): Check continued rows, in addition to
8623 continuation rows. Fixes unwarranted scroll when point enters a
8624 continued line of R2L text within an L2R paragraph, or vice versa.
8625 (cursor_row_p): Consider the case of point being equal to
8626 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
8627 from the end of a short line to the beginning of a continued line
8628 of R2L text within L2R paragraph.
8629 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
8630 composed characters.
5980d4c6 8631
f67cdd7f
EZ
8632 * bidi.c (bidi_check_type): Use xassert.
8633 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
8634 members.
8635
bca633fb
EZ
86362011-08-23 Eli Zaretskii <eliz@gnu.org>
8637
8638 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
8639 a character.
8640
4a5885a7
CY
86412011-08-23 Chong Yidong <cyd@stupidchicken.com>
8642
8643 * nsfont.m (ns_otf_to_script): Fix typo.
8644
0902a04e
KH
86452011-08-22 Kenichi Handa <handa@m17n.org>
8646
8647 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
8648 extra slot even if the purpose is char-code-property-table.
8649
1a2e6670
EZ
86502011-08-23 Eli Zaretskii <eliz@gnu.org>
8651
8ddde651
EZ
8652 * xdisp.c (redisplay_window): When computing centering_position,
8653 account for the height of the header line. (Bug#8874)
8654
425cc014
EZ
8655 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
8656 instead of CHAR_TO_BYTE. Fixes a crash when a completion
8657 candidate is selected by the mouse, and that candidate has a
8658 composed character under the mouse.
8659
1a2e6670
EZ
8660 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
8661 coordinates reported by pos-visible-in-window-p for a composed
8662 character in column zero.
8663
8b76d6f8
SM
86642011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
8665
8666 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
8667
dac347dd
EZ
86682011-08-22 Eli Zaretskii <eliz@gnu.org>
8669
8670 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
8671 consider it a hit if to_charpos is anywhere in the range of the
8672 composed buffer positions.
8673
e013fb34
CY
86742011-08-22 Chong Yidong <cyd@stupidchicken.com>
8675
8676 * image.c (gif_load): Don't assume that each subimage has the same
8677 dimensions as the base image. Handle disposal method that is
8678 "undefined" by the gif spec (Bug#9335).
8679
bd1ba3e8
CY
86802011-08-20 Chong Yidong <cyd@stupidchicken.com>
8681
8682 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 8683 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 8684
54a1215b
EZ
86852011-08-19 Eli Zaretskii <eliz@gnu.org>
8686
823564e5
EZ
8687 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
8688 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
8689 from an Org mode buffer to a Speedbar frame.
8690
54a1215b
EZ
8691 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
8692 a composition, take its buffer position from IT->cmp_it.charpos.
8693 Fixes cursor positioning at the beginning of a line that begins
8694 with a composed character.
8695
9778ebcc
EZ
86962011-08-18 Eli Zaretskii <eliz@gnu.org>
8697
0be6ee06
EZ
8698 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
8699 character bidirectional type, use STRONG_L instead. Fixes crashes
8700 in a buffer produced by `describe-categories'.
8701
9778ebcc
EZ
8702 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
8703 members before the level stack, so they would be saved and
8704 restored when copying iterator state. Fixes incorrect reordering
8705 around TABs covered by display properties.
8706
156bffbe
AS
87072011-08-18 Andreas Schwab <schwab@linux-m68k.org>
8708
6b02f655 8709 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 8710
72ad093b
CY
87112011-08-17 Chong Yidong <cyd@stupidchicken.com>
8712
8713 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
8714 (internal_condition_case_2, internal_condition_case_n):
8715 Remove unnecessary aborts (Bug#9081).
72ad093b 8716
35774242
EZ
87172011-08-17 Eli Zaretskii <eliz@gnu.org>
8718
8719 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
8720 has no `load' handler, try opening the file locally. (Bug#9311)
8721
db76dd85
KB
87222011-08-16 Ken Brown <kbrown@cornell.edu>
8723
8724 * gmalloc.c: Expand comment.
8725
b215eee5
EZ
87262011-08-16 Eli Zaretskii <eliz@gnu.org>
8727
8728 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
8729 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
8730
a4579d33
KB
87312011-08-16 Ken Brown <kbrown@cornell.edu>
8732
8733 Fix memory allocation problems in Cygwin build (Bug#9273).
8734
8735 * unexcw.c ( __malloc_initialized): Declare external variable.
8736 (fixup_executable): Force the dumped emacs to reinitialize malloc.
8737
8b76d6f8
SM
8738 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
8739 New variables.
a4579d33
KB
8740 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
8741 dumped emacs.
8742 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
8743 in the static heap.
8744 [CYGWIN] (special_realloc): New function.
8745 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
8746 requests to realloc storage in the static heap.
8747
3ebec551
PE
87482011-08-15 Paul Eggert <eggert@cs.ucla.edu>
8749
8750 * bidi.c (bidi_initialize): Remove unused local.
8751
9fd8be00
EZ
87522011-08-15 Eli Zaretskii <eliz@gnu.org>
8753
6b02f655
SM
8754 * bidimirror.h:
8755 * biditype.h: Remove file.
8756 * makefile.w32-in ($(BLD)/bidi.$(O)):
8757 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
8758
8759 * dispextern.h: Fix a typo in the comment to bidi_type_t.
8760
8761 * chartab.c: Improve commentary for the uniprop_table API.
8762
32413314
EZ
8763 * bidi.c (bidi_paragraph_init): Support zero value of
8764 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
8765 (bidi_initialize): Use uniprop_table instead of including
8766 biditype.h and bidimirror.h.
32413314 8767
9fd8be00
EZ
8768 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
8769 coordinates of the iterator when restoring from ppos_it.
8770 (Bug#9296)
8771
5cf2b69b
KH
87722011-08-14 Kenichi Handa <handa@m17n.org>
8773
8774 * process.c (create_process): Call setup_process_coding_systems
72ad093b 8775 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 8776
daf17d00
EZ
87772011-08-14 Eli Zaretskii <eliz@gnu.org>
8778
8779 * xdisp.c (move_it_in_display_line_to): Don't invoke
8780 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
8781 ppos_it. Fixes vertical cursor motion when line beginning is
8782 covered by an image. (Bug#9296)
8783
08e3161a
JD
87842011-08-14 Jan Djärv <jan.h.d@swipnet.se>
8785
8786 * nsterm.h (ns_run_ascript): Declare.
8787 (NSAPP_DATA2_RUNASSCRIPT): Define.
8788
8789 * nsfns.m (as_script, as_result, as_status): New static variables.
8790 (ns_run_ascript): New function.
5e617bc2 8791 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8792 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8793 the event loop. Get status from as_status (Bug#7276).
8794
8795 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8796 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8797 the event loop (Bug#7276).
8798
a3720aa2
AS
87992011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8800
8801 * gnutls.c (QCgnutls_bootprop_priority)
8802 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8803 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8804 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8805 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8806 (QCgnutls_bootprop_verify_hostname_error)
8807 (QCgnutls_bootprop_callbacks_verify): Rename from
8808 Qgnutls_bootprop_..., all uses changed.
8809
8810 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8811 uses changed.
8812
0a0d27fb
PE
88132011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8814
19d5c50c
PE
8815 * xfaces.c (Qframe_set_background_mode): Now static.
8816 * dispextern.h (Qframe_set_background_mode): Remove decl.
8817
0a0d27fb
PE
8818 * process.c (Fnetwork_interface_info): Declare local only if needed.
8819
377538cb
JD
88202011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8821
8822 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8823 (Fnetwork_interface_list): Allocate in increments of bytes instead
8824 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8825 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8826 sockaddr.
8827 (struct ifflag_def): notrailers is smart on OSX.
8828 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8829 Get hardware address with getifaddrs if available.
8830
08fff70c
EZ
88312011-08-12 Eli Zaretskii <eliz@gnu.org>
8832
8833 * xdisp.c (iterate_out_of_display_property): xassert that
8834 IT->position is set to within IT->object's boundaries. Break from
8835 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8836 when IT->position is set up wrongly due to some bug.
8837 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8838 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8839 entry. Force push_it to save on the stack the current
8840 buffer/string position, to be restored by pop_it. Fix flags in
8841 the iterator structure wrt the object coming from a display
8842 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8843 properties. (Bug#9284)
8844
7be1c708 88452011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8846
7be1c708
CY
8847 * fontset.c (fontset_get_font_group): Add proper type checks.
8848 (Bug#9172)
aac0c6e3 8849
7be1c708 88502011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8851
7be1c708
CY
8852 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8853 and LC_VERSION_MIN_MACOSX.
8854 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8855 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8856
97bb72a6
EZ
88572011-08-08 Eli Zaretskii <eliz@gnu.org>
8858
8859 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8860 no-display-properties-and-no-overlays under bidi display.
8861 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8862 properties and overlays.
97bb72a6 8863
d5617611
CY
88642011-08-08 Chong Yidong <cyd@stupidchicken.com>
8865
37e11a63
CY
8866 * editfns.c (Fset_time_zone_rule): Document relationship with the
8867 setenv function.
8868
d5617611
CY
8869 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8870 the font entity extracted from the cache (Bug#8109).
8871
58872834
CY
88722011-08-07 Chong Yidong <cyd@stupidchicken.com>
8873
8874 * composite.c (autocmp_chars): Don't reset point. That is done by
8875 restore_point_unwind (Bug#5984).
8876
75bfc667
JL
88772011-08-07 Juri Linkov <juri@jurta.org>
8878
8879 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8880 to show the arg `TIME' instead of `TIMEVAL'.
8881
d1410150
EZ
88822011-08-06 Eli Zaretskii <eliz@gnu.org>
8883
8884 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8885 display property strides EOL and includes a newline, as in
8886 longlines-mode. (Bug#9254)
75b771e4
EZ
8887 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8888 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8889
8890 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8891 is non-zero, even if the data buffer is NULL. Fixes a crash in
8892 vertical-motion with longlines-mode. (Bug#9254)
8893
35928349
EZ
88942011-08-05 Eli Zaretskii <eliz@gnu.org>
8895
ec7cc85b
EZ
8896 * bidi.c <bidi_cache_total_alloc>: Now static.
8897 (bidi_initialize): Initialize bidi_cache_total_alloc.
8898
8b76d6f8 8899 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8900 cache. (Bug#9221)
8901
8902 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8903 amount allocated this far in `bidi_cache_total_alloc'.
8904 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8905 non-zero, only free the data buffer without restoring the cache
8906 contents. All callers changed.
8907
8908 * dispextern.h (bidi_unshelve_cache): Update prototype.
8909
8910 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8911 (move_it_in_display_line, move_it_to)
8912 (move_it_vertically_backward, move_it_by_lines): Replace the call
8913 to xfree to an equivalent call to bidi_unshelve_cache.
8914 (move_it_in_display_line_to): Fix logic of returning
412b6358 8915 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8916
e2e2423b
EZ
89172011-08-05 Eli Zaretskii <eliz@gnu.org>
8918
8919 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8920 came from a string character with a `cursor' property. (Bug#9229)
8921
ae9e757a
JD
89222011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8923
8924 * Makefile.in (LIB_PTHREAD): New variable.
8925 (LIBES): Add LIB_PTHREAD (Bug#9216).
8926
8927 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8928 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8929
213bd7f2
AS
89302011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8931
6b02f655 8932 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8933
99aaf75f
JD
89342011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8935
8936 * xterm.c (x_find_topmost_parent): New function.
8937 (x_set_frame_alpha): Find topmost parent window with
8938 x_find_topmost_parent and set the property there also (bug#9181).
8939 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8940
c74e9d86
PE
89412011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8942
8943 * callproc.c (Fcall_process): Avoid vfork clobbering
8944 the local vars buffer, coding_systems, current_dir.
8945
640c8776
SM
89462011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8947
8948 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8949
f26d0e4c
PE
89502011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8951
8a10d76c
PE
8952 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8953 so that it is not optimized away.
8954
f26d0e4c
PE
8955 * xdisp.c (compute_display_string_pos): Remove unused local.
8956
55439c61
EZ
89572011-08-02 Eli Zaretskii <eliz@gnu.org>
8958
8959 Fix slow cursor motion and scrolling in large buffers with
8960 selective display, like Org Mode buffers. (Bug#9218)
8961
8962 * dispextern.h (struct bidi_it): New member disp_prop_p.
8963
8964 * xdisp.c: Remove one-slot cache of display string positions.
8965 (compute_display_string_pos): Accept an additional argument
5e617bc2 8966 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8967 for a display string or property. If found, set DISP_PROP_P
8968 non-zero.
8969
8970 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8971 DISP_PROP_P, and pass it to compute_display_string_pos.
8972 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8973 non-zero. All callers of bidi_fetch_char changed.
8974
fb33fa43
SM
89752011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8976
8977 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8978
b099e063
DM
89792010-12-03 Don March <don@ohspite.net>
8980
8981 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8982 last character M-[char] is translated to ESC [char] (bug#7541).
8983
5cc7f7af
KH
89842011-08-02 Kenichi Handa <handa@m17n.org>
8985
d0fffa3f 8986 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8987
8988 * chartab.c (uniprop_table): Make it non-static.
8989
525d5e6e
EZ
89902011-08-01 Eli Zaretskii <eliz@gnu.org>
8991
8992 * xdisp.c (forward_to_next_line_start): Accept additional argument
8993 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8994 on the newline.
8995 (reseat_at_next_visible_line_start): Use the bidi iterator state
8996 returned by forward_to_next_line_start to restore the state of
8997 it->bidi_it after backing up to previous newline. (Bug#9212)
8998
31011111
AS
89992011-07-30 Andreas Schwab <schwab@linux-m68k.org>
9000
9001 * regex.c (re_comp): Protoize.
9002 (re_exec): Fix return type.
9003 (regexec): Fix type of `ret'. (Bug#9203)
9004
476371c4
PE
90052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9006
e5d76069
PE
9007 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
9008 This is needed if max-image-size is a floating-point number.
9009
9a79b20c
AS
90102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9011
9012 * print.c (print_object): Print empty symbol as ##.
9013
9014 * lread.c (read1): Read ## as empty symbol.
9015
d8c2fa78
AA
90162011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
9017
9018 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
9019 setting frame foreground color (Bug#9175).
9020 (x_set_background_color): Likewise.
9021
ffe57a7a
AA
9022 * nsmenu.m (-setText): Size tooltip dimensions precisely to
9023 contents (Bug#9176).
9024 (EmacsTooltip -init): Remove bezels and add shadows to
9025 tooltip windows.
9026
bf3492a5
AA
9027 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
9028 or scroll bar (Bug#8470).
9029
d55e9c53
AA
9030 * nsfont.m (nsfont_open): Remove assignment to voffset and
9031 unnecessary vars hshink, expand, hd, full_height, min_height.
9032 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
9033
9034 * nsterm.h (nsfont_info): Remove voffset field.
9035
d8c2fa78 90362011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
9037
9038 Implement strike-through and overline on NextStep (Bug#8863).
9039
9040 * nsfont.m (nsfont_open): Use underline position provided by font,
9041 instead of hard-coded value of 2.
9042 (nsfont_draw): Call ns_draw_text_decoration instead.
9043
9044 * nsterm.h: Add declaration for ns_draw_text_decoration.
9045
9046 * nsterm.m (ns_draw_text_decoration): New function for drawing
9047 underline, overline, and strike-through.
9048 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
9049 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 9050 accommodate underlining, etc.
4843aac3 9051
4cc60b9b
EZ
90522011-07-28 Eli Zaretskii <eliz@gnu.org>
9053
bc7ece87
EZ
9054 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
9055 default.
4cc60b9b 9056
476371c4
PE
90572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9058
66606eea
PE
9059 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
9060 Without this fix, if a signal arrives just after memory fills up,
9061 'malloc' might be invoked reentrantly.
9062
476371c4
PE
9063 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
9064 In other words, assume that every image size is allowed, on non-X
9065 hosts. This assumption is probably wrong, but it lets Emacs compile.
9066
f3fcc40d
AS
90672011-07-28 Andreas Schwab <schwab@linux-m68k.org>
9068
9069 * regex.c (re_iswctype): Convert return values to boolean.
9070
350c992f
EZ
90712011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
9072
9073 * xdisp.c (compute_display_string_pos): Don't use cached display
9074 string position if the buffer had its restriction changed.
9075 (Bug#9184)
9076
5266b4bb
PE
90772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
9078
9079 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
9080
2573a837 90812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 9082
41f55ccd 9083 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 9084
39e378da
PE
9085 * bidi.c: Integer size and overflow fixes.
9086 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
9087 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
9088 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9089 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
9090 (bidi_find_other_level_edge):
9091 Use ptrdiff_t instead of EMACS_INT where either will do.
9092 This works better on 32-bit hosts configured --with-wide-int.
9093 (bidi_cache_ensure_space): Check for size-calculation overflow.
9094 Use % rather than repeated addition, for better worst-case speed.
9095 Don't set bidi_cache_size until after xrealloc returns, because it
9096 might not return.
9097 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
9098 (bidi_cache_ensure_space): Also check that the bidi cache size
9099 does not exceed that of the largest Lisp string or buffer. See Eli
9100 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 9101
5e927815
PE
9102 * alloc.c (__malloc_size_t): Remove.
9103 All uses replaced by size_t. See Andreas Schwab's note
9104 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
9105
ca4aa935
PE
9106 * image.c: Improve checking for integer overflow.
9107 (check_image_size): Assume that f is nonnull, since
9108 it is always nonnull in practice. This is one less thing to
9109 worry about when checking for integer overflow later.
9110 (x_check_image_size): New function, which checks for integer
9111 overflow issues inside X.
9112 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
9113 This removes the need for a memory_full check.
9114 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
9115 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
9116 (xbm_read_bitmap_data): Change locals back to 'int', since
9117 their values must fit in 'int'.
9118 (xpm_load_image, png_load, tiff_load):
9119 Invoke x_create_x_image_and_pixmap earlier,
9120 to avoid much needless work if the image is too large.
9121 (tiff_load): Treat overly large images as if
9122 x_create_x_image_and_pixmap failed, not as malloc failures.
9123 (gs_load): Use x_check_image_size.
9124
5f8f9cc2
PE
9125 * gtkutil.c: Omit integer casts.
9126 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
9127 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
9128
5adf60bc
PE
9129 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
9130
c8907a93
PE
9131 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
9132 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
9133 would wrongly return t on a 64-bit host.
9134
e3c25c68
PE
9135 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
9136 The plain *_OVERFLOW macros run afoul of GCC bug 49705
9137 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
9138 and therefore cause GCC to emit a bogus diagnostic in some cases.
9139
3f791afe
PE
9140 * image.c: Integer signedness and overflow and related fixes.
9141 This is not an exhaustive set of fixes, but it's time to
9142 record what I've got.
9143 (lookup_pixel_color, check_image_size): Remove redundant decls.
9144 (check_image_size): Don't assume that arbitrary EMACS_INT values
9145 fit in 'int', or that arbitrary 'double' values fit in 'int'.
9146 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
9147 (tiff_load, imagemagick_load_image):
9148 Check for overflow in size calculations.
9149 (x_create_x_image_and_pixmap): Remove unnecessary test for
9150 xmalloc returning NULL; that can't happen.
9151 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
9152 (xpm_color_bucket): Use better integer hashing function.
9153 (xpm_cache_color): Don't possibly over-allocate memory.
9154 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
9155 (gif_memory_source):
9156 Use ptrdiff_t, not int or size_t, to record sizes.
9157 (png_load): Don't assume values greater than 2**31 fit in 'int'.
9158 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
9159 either works, as we prefer signed integers.
9160 (tiff_read_from_memory, tiff_write_from_memory):
9161 Return tsize_t, not size_t, since that's what the TIFF API wants.
9162 (tiff_read_from_memory): Don't fail simply because the read would
9163 go past EOF; instead, return a short read.
9164 (tiff_load): Omit no-longer-needed casts.
9165 (Fimagemagick_types): Don't assume size fits into 'int'.
9166
3cc5a532
PE
9167 Improve hashing quality when configured --with-wide-int.
9168 * fns.c (hash_string): New function, taken from sxhash_string.
9169 Do not discard information about ASCII character case; this
9170 discarding is no longer needed.
9171 (sxhash-string): Use it. Change sig to match it. Caller changed.
9172 * lisp.h: Declare it.
9173 * lread.c (hash_string): Remove, since we now use fns.c's version.
9174 The fns.c version returns a wider integer if --with-wide-int is
9175 specified, so this should help the quality of the hashing a bit.
9176
b312a492
PE
9177 * emacs.c: Integer overflow minor fix.
9178 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
9179 Define only if GNU_LINUX.
9180 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
9181
dfd153ae
PE
9182 * dispnew.c: Integer signedness and overflow fixes.
9183 Remove unnecessary forward decls, that were a maintenance hassle.
9184 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
9185 All uses changed.
9186 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
9187 (scrolling_window): Use ptrdiff_t, not int, for byte count.
9188 (prepare_desired_row, line_draw_cost):
9189 Use int, not unsigned, where either works.
9190 (save_current_matrix, restore_current_matrix):
9191 Use ptrdiff_t, not size_t, where either works.
9192 (init_display): Check for overflow more accurately, and without
9193 relying on undefined behavior.
9194
a81d11a3
PE
9195 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
9196 Remove, replacing with the new symbols in lisp.h. All uses changed.
9197 * fileio.c (make_temp_name):
9198 * filelock.c (lock_file_1, lock_file):
9199 * xdisp.c (message_dolog):
9200 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
9201 Use pMd etc. instead.
9202 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
9203 replacing the pWIDE etc. symbols removed from editfns.c.
9204
3300e6fd
PE
9205 * keyboard.h (num_input_events): Now uintmax_t.
9206 This is (very slightly) less likely to mess up due to wraparound.
9207 All uses changed.
9208
fd05c7e9
PE
9209 * buffer.c: Integer signedness fixes.
9210 (alloc_buffer_text, enlarge_buffer_text):
9211 Use ptrdiff_t rather than size_t when either will do, as we prefer
9212 signed integers.
9213
903fe15d
PE
9214 * alloc.c: Integer signedness and overflow fixes.
9215 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
9216 (__malloc_size_t): Default to size_t, not to int.
9217 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
9218 (Fgarbage_collect, mark_object_loop_halt, mark_object):
9219 Prefer ptrdiff_t to size_t when either would do, as we prefer
9220 signed integers.
9221 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
9222 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
9223 Now const. Initialize with values that are in range even if char
9224 is signed.
9225 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
9226 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
9227 These functions do the right thing with sizes > 2**32.
9228 (check_depth): Now ptrdiff_t, not int.
9229 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
9230 Adjust to new way of storing sizes. Check for size overflow bugs
9231 in rest of code.
9232 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
9233 slightly wrong anyway, as it missed one instance of
9234 XMALLOC_OVERRUN_CHECK_OVERHEAD.
9235 (refill_memory_reserve): Omit needless cast to size_t.
9236 (mark_object_loop_halt): Mark as externally visible.
9237
ac82cc6a
PE
9238 * xselect.c: Integer signedness and overflow fixes.
9239 (Fx_register_dnd_atom, x_handle_dnd_message):
9240 Use ptrdiff_t, not size_t, since we prefer signed.
9241 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
9242 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
9243 x_dnd_atoms_size and x_dnd_atoms_length.
9244
c2d1e36d
PE
9245 * doprnt.c: Prefer signed to unsigned when either works.
9246 * eval.c (verror):
9247 * doprnt.c (doprnt):
9248 * lisp.h (doprnt):
9249 * xdisp.c (vmessage):
9250 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9251 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
9252 prefer signed arithmetic to avoid comparison confusion.
9253 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
9254 but is a bit tricky.
9255
0e926e56
PE
9256 Assume freestanding C89 headers, string.h, stdlib.h.
9257 * data.c, doprnt.c, floatfns.c, print.c:
9258 Include float.h unconditionally.
9259 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
9260 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
9261 * regex.c: Likewise for stddef.h, string.h.
9262 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
9263 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
9264 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
9265 (STDC_HEADERS): Remove obsolete defines.
9266 * sysdep.c: Include limits.h unconditionally.
9267
9cfdb3ec
PE
9268 Assume support for memcmp, memcpy, memmove, memset.
9269 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
9270 * regex.c (memcmp, memcpy):
9271 Remove; we assume C89 now.
9272
9273 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
9274 (__malloc_safe_bcopy): Remove; no longer needed.
9275
cf950e6b 9276 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
9277 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
9278 well either way, and we prefer signed to unsigned.
9279
dbf38e02
LMI
92802011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
9281
9282 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
9283 closes the connection while we're reading (bug#9182).
9284
d6f0886c 92852011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 9286
d6f0886c
JD
9287 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
9288 are specified (Bug#9168).
24e0f6b1 9289
2eb1f9e6
PE
92902011-07-25 Paul Eggert <eggert@cs.ucla.edu>
9291
9292 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
9293 Found by GCC static checking and --with-wide-int on a 32-bit host.
9294
22381272 92952011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
9296
9297 * xdisp.c (compute_display_string_pos): Fix logic of caching
9298 previous display string position. Initialize cached_prev_pos to
9299 -1. Fixes slow-down at the beginning of a buffer.
9300
f25e39b4
EZ
93012011-07-24 Eli Zaretskii <eliz@gnu.org>
9302
9303 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
9304 for attrs[LFACE_FONTSET_INDEX].
9305
04c4b52e
PE
93062011-07-23 Paul Eggert <eggert@cs.ucla.edu>
9307
9308 * xml.c (parse_region): Remove unused local
9309 that was recently introduced.
9310
c1734fbd
EZ
93112011-07-23 Eli Zaretskii <eliz@gnu.org>
9312
be18c5a5
EZ
9313 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
9314 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
9315
c1734fbd
EZ
9316 * xdisp.c (move_it_in_display_line_to): Record the best matching
9317 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
9318 exit if none of the characters scanned was an exact match.
9319 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
9320 when exact match is impossible due to invisible text, and the
9321 lines are truncated.
9322
a258d627
JD
93232011-07-23 Jan Djärv <jan.h.d@swipnet.se>
9324
9325 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
9326 for OSX >= 10.7.
9327
b6d5a689
EZ
93282011-07-22 Eli Zaretskii <eliz@gnu.org>
9329
0f74f785
EZ
9330 Fix a significant slow-down of cursor motion with C-n, C-p,
9331 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
9332 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 9333 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
9334 (next_element_from_buffer): Call compute_stop_pos_backwards to
9335 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
9336 base_level_stop.
9337 (reseat): Don't look for prev_stop, as that could mean a very long
9338 run.
9339 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
9340 <cached_disp_overlay_modiff>: Cache for last found display string
9341 position.
551918c1 9342 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
9343 about the same buffer in the same area of character positions, and
9344 the buffer wasn't changed since the time the display string
9345 position was cached.
551918c1 9346
b2d0c91a
EZ
93472011-07-22 Eli Zaretskii <eliz@gnu.org>
9348
9349 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
9350 is an integer, which is important for empty lines. (Bug#9149)
9351
043604ee
CY
93522011-07-22 Chong Yidong <cyd@stupidchicken.com>
9353
9354 * frame.c (Fmodify_frame_parameters): In tty case, update the
9355 default face if necessary (Bug#4238).
9356
da4adb04
CY
93572011-07-21 Chong Yidong <cyd@stupidchicken.com>
9358
9359 * editfns.c (Fstring_to_char): No need to explain what a character
9360 is in the docstring (Bug#6576).
9361
9abd0532
LMI
93622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9363
9364 * xml.c (parse_region): Make sure we always return a tree.
9365
36881d16
HK
93662011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
9367
9368 * xml.c (parse_region): If a document contains only comments,
9369 return that, too.
9370
1e98674d
LMI
93712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
9372
9373 * xml.c (make_dom): Return comments, too.
9374
590bd467
PE
93752011-07-19 Paul Eggert <eggert@cs.ucla.edu>
9376
9377 Port to OpenBSD.
9378 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
9379 and the surrounding thread.
9380 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
9381 rather than fgets, and retry after EINTR. Otherwise, 'emacs
9382 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
9383 timer goes off.
9384 * s/openbsd.h (BROKEN_SIGIO): Define.
9385 * unexelf.c (unexec) [__OpenBSD__]:
9386 Don't update the .mdebug section of the Alpha COFF symbol table.
9387
f41628b2
LMI
93882011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
9389
9390 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
9391 (bug#8460).
9392
b59b67c5
PE
93932011-07-18 Paul Eggert <eggert@cs.ucla.edu>
9394
15e3a074
PE
9395 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
9396 This fixes some race conditions on the permissions of any newly
9397 created file.
9398
41bed37d
PE
9399 * alloc.c (valid_pointer_p): Use pipe, not open.
9400 This fixes some permissions issues when debugging.
9401
b59b67c5
PE
9402 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
9403 If fchown fails to set both uid and gid, try to set just gid,
9404 as that is sometimes allowed. Adjust the file's mode to eliminate
9405 setuid or setgid bits that are inappropriate if fchown fails.
9406
925a6be7
SM
94072011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
9408
9409 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
9410 to compare Lisp_Objects.
9411 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
9412 global_gnutls_log_level, don't mistake it for a Lisp_Object.
9413 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
9414
52968808
AS
94152011-07-17 Andreas Schwab <schwab@linux-m68k.org>
9416
0a6a104b
AS
9417 * lread.c (read_integer): Unread even EOF character.
9418 (read1): Likewise. Properly record start position of symbol.
9419
52968808
AS
9420 * lread.c (read1): Read `#:' as empty uninterned symbol if no
9421 symbol character follows.
9422
9e381cdd
PE
94232011-07-17 Paul Eggert <eggert@cs.ucla.edu>
9424
9425 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
9426 This works around a problem with the previous change to Fcopy_file.
9427 Recent glibc declares fchown with __attribute__((warn_unused_result)),
9428 and without this change, GCC might complain about discarding
9429 fchown's return value.
9430
b5641435
JB
94312011-07-16 Juanma Barranquero <lekktu@gmail.com>
9432
9433 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
9434
a8031457
PE
94352011-07-16 Paul Eggert <eggert@cs.ucla.edu>
9436
9437 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
9438
dd889327
LMI
94392011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
9440
750c33f7
LMI
9441 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
9442 it's used from the C level.
9443
dd889327
LMI
9444 * process.c: Use the same condition for POLL_FOR_INPUT in both
9445 keyboard.c and process.c (bug#1858).
9446
87e86684
LM
94472011-07-09 Lawrence Mitchell <wence@gmx.li>
9448
9449 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
9450 (Fgnutls_boot): Use it.
9451
64348f40
AS
94522011-07-15 Andreas Schwab <schwab@linux-m68k.org>
9453
9454 * doc.c (Fsubstitute_command_keys): Revert last change.
9455
1d698799
LMI
94562011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
9457
f863868c
LMI
9458 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
9459 quotes the next character, and doesn't affect other longer
9460 sequences (bug#8935).
9461
1d698799
LMI
9462 * lread.c (syms_of_lread): Clarify that is isn't only
9463 `eval-buffer' and `eval-defun' that's affected by
9464 `lexical-binding' (bug#8460).
9465
aa4b6df6
EZ
94662011-07-15 Eli Zaretskii <eliz@gnu.org>
9467
9468 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 9469 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 9470
5d856da6
PE
94712011-07-14 Paul Eggert <eggert@cs.ucla.edu>
9472
ad6042bb
PE
9473 Fix minor problems found by static checking.
9474 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
9475 (elsz): Now a signed constant, not a size_t var. We prefer signed
9476 types to unsigned, to avoid integer comparison confusion. Without
9477 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
9478 "cannot optimize loop, the loop counter may overflow", a symptom
9479 of the confusion.
f00bbb22 9480 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
9481 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
9482
6468f31c
LMI
94832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9484
49080b10
LMI
9485 * search.c (Fre_search_backward): Mention `case-fold-search' in
9486 all the re_search_* functions (bug#8138).
9487
6468f31c
LMI
9488 * keyboard.c (Fopen_dribble_file): Document when the file is
9489 closed (bug#8056).
9490
c965adc5
EZ
94912011-07-14 Eli Zaretskii <eliz@gnu.org>
9492
df9733bf
EZ
9493 * bidi.c (bidi_dump_cached_states): Fix format of displaying
9494 bidi_cache_idx.
9495
0bb23927
EZ
9496 Support bidi reordering of display and overlay strings.
9497 * xdisp.c (compute_display_string_pos)
9498 (compute_display_string_end): Accept additional argument STRING.
9499 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
9500 (reseat_to_string): Initialize bidi_it->string.s and
9501 bidi_it->string.schars.
9502 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
9503 NULL (avoids a crash in bidi_paragraph_init).
9504 Initialize itb.string.lstring.
0bb23927
EZ
9505 (init_iterator): Call bidi_init_it only of a valid
9506 buffer position was specified. Initialize paragraph_embedding to
9507 L2R.
9508 (reseat_to_string): Initialize the bidi iterator.
9509 (display_string): If we need to ignore text properties of
9510 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
9511 original value of -1 will not work with bidi.)
9512 (compute_display_string_pos): First arg is now struct
9513 `text_pos *'; all callers changed. Support display properties on
9514 Lisp strings.
9515 (compute_display_string_end): Support display properties on Lisp
9516 strings.
9517 (init_iterator, reseat_1, reseat_to_string): Initialize the
9518 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
9519 when iterating on a string not from display properties).
640c8776
SM
9520 (compute_display_string_pos, compute_display_string_end):
9521 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
9522 arrow keys.
9523 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
9524 base_level_stop; instead, set base_level_stop to BEGV.
9525 Fixes crashes in vertical-motion.
0bb23927
EZ
9526 (next_element_from_buffer): Improve commentary for when
9527 the iterator is before prev_stop.
9528 (init_iterator): Initialize bidi_p from the default value of
9529 bidi-display-reordering, not from buffer-local value. Use the
9530 buffer-local value only if initializing for buffer iteration.
9531 (handle_invisible_prop): Support invisible properties on strings
9532 that are being bidi-reordered.
9533 (set_iterator_to_next): Support bidi reordering of C strings and
9534 Lisp strings.
9535 (next_element_from_string): Support bidi reordering of Lisp
9536 strings.
9537 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
9538 (display_string): Support display of R2L glyph rows.
9539 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
9540 (init_iterator): Don't initialize it->bidi_p for strings
9541 here.
9542 (reseat_to_string): Initialize it->bidi_p for strings here.
9543 (next_element_from_string, next_element_from_c_string)
9544 (next_element_from_buffer): Add xassert's for correspondence
9545 between IT's object being iterated and it->bidi_it.string
9546 structure.
9547 (face_before_or_after_it_pos): Support bidi iteration.
9548 (next_element_from_c_string): Handle the case of the first string
9549 character that is not the first one in the visual order.
9550 (get_visually_first_element): New function, refactored from common
9551 parts of next_element_from_buffer, next_element_from_string, and
9552 next_element_from_c_string.
9553 (tool_bar_lines_needed, redisplay_tool_bar)
9554 (display_menu_bar): Force left-to-right direction. Add a FIXME
9555 comment for making that be controlled by a user option.
9556 (push_it, pop_it): Save and restore the state of the
9557 bidi iterator. Save and restore the bidi_p flag.
9558 (pop_it): Iterate out of display property for string iteration as
9559 well.
9560 (iterate_out_of_display_property): Support iteration over strings.
9561 (handle_single_display_spec): Set up it->bidi_it for iteration
9562 over a display string, and call bidi_init_it.
9563 (handle_single_display_spec, next_overlay_string)
9564 (get_overlay_strings_1, push_display_prop): Set up the bidi
9565 iterator for displaying display or overlay strings.
9566 (forward_to_next_line_start): Don't use the shortcut if
9567 bidi-iterating.
9568 (back_to_previous_visible_line_start): If handle_display_prop
9569 pushed the iterator stack, restore the internal state of the bidi
9570 iterator by calling bidi_pop_it same number of times.
9571 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
9572 and we are bidi-iterating, don't decrement the iterator position;
9573 instead, set the first_elt flag in the bidi iterator, to produce
9574 the same effect.
9575 (reseat_1): Remove redundant setting of string_from_display_prop_p.
9576 (push_display_prop): xassert that we are iterating a buffer.
9577 (push_it, pop_it): Save and restore paragraph_embedding member.
9578 (handle_single_display_spec, next_overlay_string)
9579 (get_overlay_strings_1, reseat_1, reseat_to_string)
9580 (push_display_prop): Set up the `unibyte' member of bidi_it.string
9581 correctly. Don't assume unibyte strings are not bidi-reordered.
9582 (compute_display_string_pos)
9583 (compute_display_string_end): Fix handling the case of C string.
9584 (push_it, pop_it): Save and restore from_disp_prop_p.
9585 (handle_single_display_spec, push_display_prop): Set the
9586 from_disp_prop_p flag.
9587 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
9588 (pop_it): Call iterate_out_of_display_property only if we are
9589 popping after iteration over a string that came from a display
9590 property. Fix a typo in popping stretch info. Add an assertion
9591 for verifying that the iterator position is in sync with the bidi
9592 iterator.
9593 (handle_single_display_spec, get_overlay_strings_1)
9594 (push_display_prop): Fix initialization of paragraph direction for
9595 string when that of the parent object is not yet determined.
9596 (reseat_1): Call bidi_init_it to resync the bidi
9597 iterator with IT's position. (Bug#7616)
9598 (find_row_edges): If ROW->start.pos gives position
9599 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
9600 (handle_stop, back_to_previous_visible_line_start, reseat_1):
9601 Reset the from_disp_prop_p flag.
9602 (SAVE_IT, RESTORE_IT): New macros.
9603 (pos_visible_p, face_before_or_after_it_pos)
9604 (back_to_previous_visible_line_start)
9605 (move_it_in_display_line_to, move_it_in_display_line)
9606 (move_it_to, move_it_vertically_backward, move_it_by_lines)
9607 (try_scrolling, redisplay_window, display_line): Use them when
9608 saving a temporary copy of the iterator and restoring it back.
9609 (back_to_previous_visible_line_start, reseat_1)
9610 (init_iterator): Empty the bidi cache "stack".
9611 (move_it_in_display_line_to): If iterator ended up at
9612 EOL, but we never saw any buffer positions smaller than
9613 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
9614 motion in bidi-reordered lines.
9615 (move_it_in_display_line_to): Record prev_method and prev_pos
9616 immediately before the call to set_iterator_to_next. Fixes cursor
9617 motion in bidi-reordered lines with stretch glyphs and strings
9618 displayed in margins. (Bug#8133) (Bug#8867)
9619 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
9620 TO_CHARPOS.
640c8776
SM
9621 (pos_visible_p): Support positions in bidi-reordered lines.
9622 Save and restore bidi cache.
0bb23927
EZ
9623
9624 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
9625 (bidi_paragraph_info): Delete unused struct.
9626 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
9627 (bidi_cache_start): New variable.
9628 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
9629 to zero.
9630 (bidi_cache_fetch_state, bidi_cache_search)
9631 (bidi_cache_find_level_change, bidi_cache_iterator_state)
9632 (bidi_cache_find, bidi_peek_at_next_level)
9633 (bidi_level_of_next_char, bidi_find_other_level_edge)
9634 (bidi_move_to_visually_next): Compare cache index with
9635 bidi_cache_start rather than with zero.
9636 (bidi_fetch_char): Accept new argument STRING; all callers
9637 changed. Support iteration over a string. Support strings with
9638 display properties. Support unibyte strings. Fix the type of
9639 `len' according to what STRING_CHAR_AND_LENGTH expects.
9640 (bidi_paragraph_init, bidi_resolve_explicit_1)
9641 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
9642 (bidi_level_of_next_char, bidi_move_to_visually_next):
9643 Support iteration over a string.
0bb23927
EZ
9644 (bidi_set_sor_type, bidi_resolve_explicit_1)
9645 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
9646 can now be zero (for strings); special values 0 and -1 were
9647 changed to -1 and -2, respectively.
9648 (bidi_char_at_pos): New function.
9649 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
9650 Call it instead of FETCH_MULTIBYTE_CHAR.
9651 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
9652 initialized to valid values.
9653 (bidi_init_it): Don't initialize charpos and bytepos with invalid
9654 values.
9655 (bidi_level_of_next_char): Allow the sentinel "position" to pass
9656 the test for valid cached positions. Fix the logic for looking up
9657 the sentinel state in the cache. GCPRO the Lisp string we are
9658 iterating.
9659 (bidi_push_it, bidi_pop_it): New functions.
9660 (bidi_initialize): Initialize the bidi cache start stack pointer.
9661 (bidi_cache_ensure_space): New function, refactored from part of
9662 bidi_cache_iterator_state. Don't assume the required size is just
9663 one BIDI_CACHE_CHUNK away.
9664 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
9665 (bidi_count_bytes, bidi_char_at_pos): New functions.
9666 (bidi_cache_search): Don't assume bidi_cache_last_idx is
9667 always valid if bidi_cache_idx is valid.
9668 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
9669 is valid if it's going to be used.
9670 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
9671 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
9672 (bidi_cache_find_level_change, bidi_cache_ensure_space)
9673 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
9674 (bidi_find_other_level_edge, bidi_cache_start_stack):
9675 All variables related to cache indices are now EMACS_INT.
c965adc5 9676
0bb23927
EZ
9677 * dispextern.h (struct bidi_string_data): New structure.
9678 (struct bidi_it): New member `string'. Make flag members be 1-bit
9679 fields, and put them last in the struct.
640c8776
SM
9680 (compute_display_string_pos, compute_display_string_end):
9681 Update prototypes.
0bb23927
EZ
9682 (bidi_push_it, bidi_pop_it): Add prototypes.
9683 (struct iterator_stack_entry): New members bidi_p,
9684 paragraph_embedding, and from_disp_prop_p.
9685 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
9686 (bidi_shelve_cache, bidi_unshelve_cache):
9687 Declare prototypes.
0bb23927
EZ
9688
9689 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
9690 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
9691 and vector-like objects.
9692
9693 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
9694 cache around display iteration.
9695
9696 * window.c (Fwindow_end, window_scroll_pixel_based)
9697 (displayed_window_lines, Frecenter): Save and restore the bidi
9698 cache around display iteration.
9699
3bbd2265
LMI
97002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
9701
9702 * editfns.c (Fdelete_region): Clarify the use of the named
9703 parameters (bug#6788).
9704
adc47434
MR
97052011-07-14 Martin Rudalics <rudalics@gmx.at>
9706
9707 * indent.c (Fvertical_motion): Set and restore w->pointm when
9708 saving and restoring the window's buffer (Bug#9006).
9709
837c31f8
LMI
97102011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
9711
9712 * editfns.c (Fstring_to_char): Clarify just what is returned
9713 (bug#6576). Text by Eli Zaretskii.
9714
ac389d0c
JB
97152011-07-13 Juanma Barranquero <lekktu@gmail.com>
9716
9717 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
9718
0be0ce47
EZ
97192011-07-13 Eli Zaretskii <eliz@gnu.org>
9720
9721 * buffer.c (mmap_find): Fix a typo.
9722
cd18e7e3
JB
97232011-07-13 Johan Bockgård <bojohan@gnu.org>
9724
9725 Fix execution of x selection hooks.
9726 * xselect.c (Qx_lost_selection_functions)
9727 (Qx_sent_selection_functions): New vars.
9728 (syms_of_xselect): DEFSYM them.
9729 (x_handle_selection_request): Pass Qx_sent_selection_functions
9730 rather than Vx_sent_selection_functions to Frun_hook_with_args.
9731 (x_handle_selection_clear,x_clear_frame_selections):
9732 Pass Qx_lost_selection_functions rather than
9733 Vx_lost_selection_functions to Frun_hook_with_args.
9734
47ea7f44
PE
97352011-07-13 Paul Eggert <eggert@cs.ucla.edu>
9736
ac389d0c 9737 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
9738 The old code sometimes used this field without initializing it.
9739
47ea7f44
PE
9740 * alloc.c (gc_sweep): Don't read past end of array.
9741 In theory, the old code could also have corrupted Emacs internals,
9742 though it'd be very unlikely.
9743
bc985c87
AS
97442011-07-12 Andreas Schwab <schwab@linux-m68k.org>
9745
9746 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 9747 argument. (Bug#4026)
bc985c87 9748
0cf34688
LMI
97492011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
9750
b3dadd76
LMI
9751 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
9752 key" (bug#4257).
9753
0cf34688
LMI
9754 * window.c (Fset_window_start): Doc fix (bug#4199).
9755 (Fset_window_hscroll): Ditto.
9756
270768cd
PE
97572011-07-12 Paul Eggert <eggert@cs.ucla.edu>
9758
077e3dda 9759 Fix minor new problems caught by GCC 4.6.1.
270768cd 9760 * term.c (init_tty): Remove unused local.
490011a6 9761 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 9762 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 9763 not used otherwise.
270768cd 9764
b1f58454
CY
97652011-07-12 Chong Yidong <cyd@stupidchicken.com>
9766
9767 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
9768
22b9578d
LMI
97692011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
9770
6e70ab07
LMI
9771 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
9772 are the mini-buffer and the echo area (bug#3320).
9773
22b9578d
LMI
9774 * term.c (init_tty): Remove support for supdup, c10 and perq
9775 terminals, which are no longer supported (bug#1482).
9776
8974cc9f
JB
97772011-07-10 Johan Bockgård <bojohan@gnu.org>
9778
9779 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
9780
a560d974
JD
97812011-07-10 Jan Djärv <jan.h.d@swipnet.se>
9782
9783 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
9784 for non-popups (Bug#3642).
9785
1dae0f0a
AS
97862011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9787
268c2c36 9788 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9789 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9790 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9791 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9792 * data.c (fmod): Likewise.
9793 * dispnew.c (swap_glyphs_in_rows): Likewise.
9794 * emacs.c (memory_warning_signal): Likewise.
9795 * floatfns.c (float_error): Likewise.
9796 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9797 (otf_open, font_otf_capability, generate_otf_features)
9798 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9799 Likewise.
9800 * image.c (pbm_read_file): Likewise.
9801 * indent.c (string_display_width): Likewise.
9802 * intervals.c (check_for_interval, search_for_interval)
9803 (inc_interval_count, count_intervals, root_interval)
9804 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9805 * lread.c (defalias): Likewise.
268c2c36 9806 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9807 * regex.c (set_image_of_range_1, set_image_of_range)
9808 (regex_grow_registers): Likewise.
9809 * sysdep.c (strerror): Likewise.
9810 * termcap.c (valid_filename_p, tprint, main): Likewise.
9811 * tparam.c (main): Likewise.
9812 * unexhp9k800.c (run_time_remap, save_data_space)
9813 (update_file_ptrs, read_header, write_header, calculate_checksum)
9814 (copy_file, copy_rest, display_header): Likewise.
9815 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9816 Likewise.
9817 * xdisp.c (check_it): Likewise.
9818 * xfaces.c (register_color, unregister_color, unregister_colors):
9819 Likewise.
9820 * xfns.c (print_fontset_result): Likewise.
9821 * xrdb.c (member, fatal, main): Likewise.
9822
99033785
PE
98232011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9824
9825 Fix minor problems found by static checking (Bug#9031).
9826 * chartab.c (char_table_set_range, map_sub_char_table):
9827 Remove unused locals.
9828 (uniprop_table): Now static.
9829 * composite.c (_work_char): Remove unused static var.
9830
9cb2ac56
JB
98312011-07-09 Juanma Barranquero <lekktu@gmail.com>
9832
9833 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9834
f25661f0
JD
98352011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9836
9837 * gtkutil.c (qttip_cb): Remove code without function.
9838
8278c4fe
EZ
98392011-07-09 Eli Zaretskii <eliz@gnu.org>
9840
9841 * w32.c (pthread_sigmask): New stub.
9842
1692ae2d 98432011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9844
8a6ebd58 9845 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9846 sigprocmask is portable only for single-threaded applications, and
9847 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9848 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9849 (LIBES): Use it.
9850 * callproc.c (Fcall_process):
9851 * process.c (create_process):
9852 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9853 Use pthread_sigmask, not sigprocmask.
123403e4 9854
1b854618
JD
98552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9856
9857 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9858 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9859 wrong (Bug#8591).
9860
3fe4b549
JD
98612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9862
0ce7e563
JD
9863 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9864 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9865 (xg_hide_tooltip): Fix comment.
9866
3fe4b549
JD
9867 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9868 in registerServicesMenuSendTypes.
9869 (validRequestorForSendType): Don't check ns_return_types.
9870
9871 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9872 ns_return_type.
9873
5df75e47
JR
98742011-07-08 Jason Rumney <jasonr@gnu.org>
9875
22610910
JR
9876 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9877 SH_SHOW for hidden windows (Bug#5482).
9878
5df75e47
JR
9879 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9880 frame struct members of non-existent frames (Bug#6284).
9881
699c10bd
JD
98822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9883
4393663b
JD
9884 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9885 variable firstTime not needed on OSX >= 10.6.
9886 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9887 >= 10.5. Use setKnobProportion, setDoubleValue.
9888
9889 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9890 (MAC_OS_X_VERSION_10_5): Define if not defined.
9891 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9892 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9893 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9894
9895 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9896 cString and lossyCString on OSX >= 10.4.
4393663b 9897
58179cce 9898 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9899 sizeToFit on OSX >= 10.2.
9900
9901 * nsimage.m (allocInitFromFile): Don't use deprecated method
9902 bestRepresentationForDevice on OSX >= 10.6.
9903
9904 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9905 to avoid warning.
9906
9907 * emacs.c: Declare unexec_init_emacs_zone.
9908
a63e0781
JD
9909 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9910
699c10bd
JD
9911 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9912
9913 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9914 on svcsMenu (Bug#8842).
9915
9916 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9917 ns_return_types.
9918 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9919
9920 * nsterm.m (QUTF8_STRING): Declare.
9921 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9922 (validRequestorForSendType): Return type is (id).
9923 Change indexOfObjectIdenticalTo to indexOfObject.
9924 Check if we have local selection before returning self (Bug#8842).
9925 (writeSelectionToPasteboard): Put local selection into paste board
9926 if we have a local selection (Bug#8842).
9927 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9928
9929 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9930 (ns_get_local_selection): Declare.
9931
54e10184
LMI
99322011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9933
9888ff71
LMI
9934 * keymap.c (describe_map_tree): Don't insert a double newline at
9935 the end of the buffer (bug#1169) and return whether we inserted
9936 something.
9937
54e10184
LMI
9938 * callint.c (Fcall_interactively): Change "reading args" to
9939 "providing args" to try to clarify what it does (bug#1010).
9940
15fa4783
KH
99412011-07-07 Kenichi Handa <handa@m17n.org>
9942
9943 * composite.c (composition_compute_stop_pos): Ignore a static
9944 composition starting before CHARPOS (Bug#8915).
9945
9946 * xdisp.c (handle_composition_prop): Likewise.
9947
a8815b00
EZ
99482011-07-07 Eli Zaretskii <eliz@gnu.org>
9949
9950 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9951 (Bug#9015)
9952
ef7b981d 99532011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9954
9955 * character.h (unicode_category_t): New enum type.
9956
9957 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9958 (Qchar_code_property_table): New variable.
9959 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9960 (UNIPROP_COMPRESSED_FORM_P): New macros.
9961 (char_table_ascii): Uncompress the compressed values.
9962 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9963 Uncompress the compressed values.
ac389d0c 9964 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9965 (char_table_ref_and_range): Uncompress the compressed values.
9966 (sub_char_table_set): New arg is_uniprop. Callers changed.
9967 Uncompress the compressed values.
9968 (sub_char_table_set_range): Args changed. Callers changed.
9969 (char_table_set_range): Adjuted for the above change.
9970 (map_sub_char_table): Delete args default_val and parent. Add arg
9971 top. Give decoded values to a Lisp function.
640c8776 9972 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9973 values to a Lisp function. Gcpro more variables.
9974 (uniprop_table_uncompress)
9975 (uniprop_decode_value_run_length): New functions.
9976 (uniprop_decoder, uniprop_decoder_count): New variables.
9977 (uniprop_get_decoder, uniprop_encode_value_character)
9978 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9979 New functions.
9980 (uniprop_encoder, uniprop_encoder_count): New variables.
9981 (uniprop_get_encoder, uniprop_table)
9982 (Funicode_property_table_internal, Fget_unicode_property_internal)
9983 (Fput_unicode_property_internal): New functions.
9984 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9985 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9986 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9987 char-code-property-alist.
9988
640c8776 9989 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9990 Vunicode_category_table.
9991
640c8776 9992 * font.c (font_range): Adjust for the change of
c805dec0
KH
9993 Vunicode_category_table.
9994
76b397fb
DN
99952011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9996
9997 * m/iris4d.h: Remove file, move contents ...
9998 * s/irix6-5.h: ... here.
9999
22b4128e
PE
100002011-07-06 Paul Eggert <eggert@cs.ucla.edu>
10001
10002 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
10003 * alloc.c (mark_buffer):
10004 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
10005 (clone_per_buffer_values): Don't assume that
22b4128e
PE
10006 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
10007 This isn't true in general, and it's particularly not true
10008 if Emacs is configured with --with-wide-int.
10009 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
10010 New macros, used in the buffer.c change.
10011
869795d6
JD
100122011-07-05 Jan Djärv <jan.h.d@swipnet.se>
10013
10014 * xsettings.c: Use both GConf and GSettings if both are available.
10015 (store_config_changed_event): Add comment.
10016 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
10017 (store_tool_bar_style_changed): New functions.
5e617bc2 10018 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
10019 (struct xsettings): Move font inside HAVE_XFT.
10020 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 10021 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 10022 Move inside HAVE_XFT.
640c8776 10023 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
10024 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
10025 also.
10026 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 10027 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 10028 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
10029 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
10030 (parse_settings): Move check for font inside HAVE_XFT.
10031 (read_settings, apply_xft_settings): Add comment.
10032 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
10033 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
10034 call store_font_name_changed.
10035 (xft_settings_event): Add comment.
10036 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
10037 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
10038 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
10039 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
10040 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
10041 (xsettings_get_system_font, xsettings_get_system_normal_font):
10042 Add comment.
869795d6 10043
d8ed26bd
PE
100442011-07-05 Paul Eggert <eggert@cs.ucla.edu>
10045
10046 Random fixes. E.g., (random) never returned negative values.
10047 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
10048 subseconds part to the entropy, as that's a bit more random.
10049 Prefer signed to unsigned, since the signedness doesn't matter and
10050 in general we prefer signed. When given a limit, use a
10051 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
10052 latter isn't right if USE_2_TAGS_FOR_INTS.
10053 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
10054 not 0..VALMASK. Don't discard "excess" bits that random () returns.
10055
cabf1cac
SM
100562011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
10057
10058 * textprop.c (text_property_stickiness):
10059 Obey Vtext_property_default_nonsticky.
10060 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
10061 * w32fns.c (syms_of_w32fns):
10062 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
10063
6e9b2be9
PE
100642011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10065
10066 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
10067 This is more efficient than Ffile_directory_p and avoids a minor race.
10068
90186c68
LMI
100692011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
10070
7c301272
LMI
10071 * buffer.c (Foverlay_put): Say what the return value is
10072 (bug#7835).
10073
c4f2d8d4
LMI
10074 * fileio.c (barf_or_query_if_file_exists): Check first if the file
10075 is a directory before asking whether to use the file name
10076 (bug#7564).
ad637907
LMI
10077 (barf_or_query_if_file_exists): Make the "File is a directory"
10078 error be more correct.
c4f2d8d4 10079
90186c68
LMI
10080 * fns.c (Frequire): Remove the mention of the .gz files, since
10081 that's installation-specific, but keep the mention of
10082 `get-load-suffixes'.
10083
da64016e
PE
100842011-07-04 Paul Eggert <eggert@cs.ucla.edu>
10085
10086 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
10087 Report string overflow if the output is too long.
10088
7d47b580
JB
100892011-07-04 Juanma Barranquero <lekktu@gmail.com>
10090
a555cb87
JB
10091 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
10092 (syms_of_gnutls): Remove duplicate DEFSYM for
10093 Qgnutls_bootprop_verify_hostname_error, an error for
10094 Qgnutls_bootprop_verify_error (which is no longer used).
10095
7d47b580
JB
10096 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
10097 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
10098 Also (re)move comments that are misplaced or no longer relevant.
10099
1e49bfab
LMI
101002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10101
10102 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
10103
1485f4c0
CY
101042011-07-03 Chong Yidong <cyd@stupidchicken.com>
10105
10106 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
10107 and background color parameters if they have been changed.
10108
a9ab721e
LMI
101092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
10110
10111 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
10112
cf7cff57
PE
101132011-07-03 Paul Eggert <eggert@cs.ucla.edu>
10114
2e13213d
PE
10115 * xsettings.c (SYSTEM_FONT): Define only when used.
10116 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
10117
cf7cff57
PE
10118 * keymap.c (access_keymap_1): Now static.
10119
7a8e04f7
CY
101202011-07-02 Chong Yidong <cyd@stupidchicken.com>
10121
10122 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
10123 leave any prefix arg for the up event (Bug#1586).
10124
61352f62
LMI
101252011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
10126
69bb1ef7
LMI
10127 * lread.c (syms_of_lread): Mention single symbols defined by
10128 `defvar' or `defconst' (bug#7154).
10129
61352f62 10130 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 10131 (Frequire): Mention get-load-suffixes.
61352f62 10132
28545e04
MR
101332011-07-02 Martin Rudalics <rudalics@gmx.at>
10134
10135 * window.h (window): Remove clone_number slot.
10136 * window.c (Fwindow_clone_number, Fset_window_clone_number):
10137 Remove.
10138 (make_parent_window, make_window, saved_window)
10139 (Fset_window_configuration, save_window_save): Don't deal with
10140 clone numbers.
10141 * buffer.c (Qclone_number): Remove declaration.
10142 (sort_overlays, overlay_strings): Don't deal with clone numbers.
10143
3349e122
SM
101442011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
10145
10146 Add multiple inheritance to keymaps.
10147 * keymap.c (Fmake_composed_keymap): New function.
10148 (Fset_keymap_parent): Simplify.
10149 (fix_submap_inheritance): Remove.
10150 (access_keymap_1): New function extracted from access_keymap to handle
10151 embedded parents and handle lists of maps.
10152 (access_keymap): Use it.
10153 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
10154 (Fcopy_keymap): Handle embedded parents.
10155 (Fcommand_remapping, define_as_prefix): Simplify.
10156 (Fkey_binding): Simplify.
10157 (syms_of_keymap): Move minibuffer-local-completion-map,
10158 minibuffer-local-filename-completion-map,
10159 minibuffer-local-must-match-map, and
10160 minibuffer-local-filename-must-match-map to Elisp.
10161 (syms_of_keymap): Defsubr make-composed-keymap.
10162 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
10163 (parse_menu_item): Trivial simplification.
10164
3279eb87
GM
101652011-07-01 Glenn Morris <rgm@gnu.org>
10166
10167 * Makefile.in (SETTINGS_LIBS): Fix typo.
10168
39cb9e56 101692011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
4550efdf
KI
10170
10171 * coding.c (Fencode_coding_string): Record the last coding system
10172 used, as the function doc string says (bug#8738).
10173
0949d2b6
JD
101742011-07-01 Jan Djärv <jan.h.d@swipnet.se>
10175
10176 * xsettings.c (store_monospaced_changed): Take new font as arg and
10177 check for change against current_mono_font.
10178 (EMACS_TYPE_SETTINGS): Remove this and related defines.
10179 (emacs_settings_constructor, emacs_settings_get_property)
10180 (emacs_settings_set_property, emacs_settings_class_init)
10181 (emacs_settings_init, gsettings_obj): Remove.
10182 (something_changedCB): New function for HAVE_GSETTINGS.
10183 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
10184 with value as argument.
10185 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
10186 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 10187 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
10188 "changed".
10189
10190 * xgselect.c: Add defined (HAVE_GSETTINGS).
10191 (xgselect_initialize): Ditto.
10192
10193 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
10194 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
10195 xg_select.
10196
bbc6b304
PE
101972011-07-01 Paul Eggert <eggert@cs.ucla.edu>
10198
10199 * eval.c (struct backtrace): Simplify and port the data structure.
10200 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
10201 signed bit field, as this assumption is not portable and it makes
10202 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
10203 "char debug_on_exit : 1" as this is not portable either; instead,
10204 use the portable "unsigned int debug_on_exit : 1". Remove unused
10205 member evalargs. Remove obsolete comments about cc bombing out.
10206
9851bfc5
JD
102072011-06-30 Jan Djärv <jan.h.d@swipnet.se>
10208
51bb811f 10209 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
10210 Let HAVE_GSETTINGS override HAVE_GCONF.
10211 (store_monospaced_changed): New function.
10212 (EMACS_SETTINGS): A new type derived from GObject to handle
10213 GSettings notifications.
10214 (emacs_settings_constructor, emacs_settings_get_property)
10215 (emacs_settings_set_property, emacs_settings_class_init):
10216 New functions.
10217 (gsettings_client, gsettings_obj): New variables.
10218 (GSETTINGS_SCHEMA): New define.
10219 (something_changedCB): Call store_monospaced_changed.
10220 (init_gsettings): New function.
10221 (xsettings_initialize): Call init_gsettings.
10222 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
10223 to NULL.
10224
640c8776 10225 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
10226 GCONF_CFLAGS/LIBS.
10227
5386012d
MR
102282011-06-29 Martin Rudalics <rudalics@gmx.at>
10229
10230 * window.c (resize_root_window, grow_mini_window)
10231 (shrink_mini_window): Rename Qresize_root_window to
10232 Qwindow_resize_root_window and Qresize_root_window_vertically to
10233 Qwindow_resize_root_window_vertically.
10234
f13e0b08
PE
102352011-06-28 Paul Eggert <eggert@cs.ucla.edu>
10236
10237 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
10238
94515237
JB
102392011-06-27 Juanma Barranquero <lekktu@gmail.com>
10240
10241 * makefile.w32-in: Redesign dependencies so they reflect more
10242 clearly which files are directly included by each source file,
10243 and not through other includes.
10244
e43b6e43
MR
102452011-06-27 Martin Rudalics <rudalics@gmx.at>
10246
10247 * buffer.c (Qclone_number): Declare static and DEFSYM it.
10248 (sort_overlays, overlay_strings): When an overlay's clone number
10249 matches the window's clone number process the overlay even if
10250 the overlay's window property doesn't match the current window.
10251
d68443dc
MR
10252 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
10253 (Fwindow_hchild): Rename to Fwindow_left_child.
10254 (Fwindow_next): Rename to Fwindow_next_sibling.
10255 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
10256 (resize_window_check): Rename to window_resize_check.
10257 (resize_window_apply): Rename to window_resize_apply.
10258 (Fresize_window_apply): Rename to Fwindow_resize_apply.
10259 (Fdelete_other_windows_internal, resize_frame_windows)
10260 (Fsplit_window_internal, Fdelete_window_internal)
10261 (grow_mini_window, shrink_mini_window)
10262 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 10263
c7e73be5
JD
102642011-06-26 Jan Djärv <jan.h.d@swipnet.se>
10265
10266 * emacsgtkfixed.h: State that this is only used with Gtk+3.
10267 (emacs_fixed_set_min_size): Remove.
10268 (emacs_fixed_new): Take frame as argument.
10269
10270 * emacsgtkfixed.c: State that this is only used with Gtk+3.
10271 (_EmacsFixedPrivate): Remove minwidth/height.
10272 Add struct frame *f.
10273 (emacs_fixed_init): Initialize priv->f.
10274 (get_parent_class, emacs_fixed_set_min_size): Remove.
10275 (emacs_fixed_new): Set priv->f to argument.
10276 (emacs_fixed_get_preferred_width)
10277 (emacs_fixed_get_preferred_height): Use min_width/height from
10278 frames size_hint to set minimum and natural (Bug#8919).
10279 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
10280 and use min_width/height from frames size_hint to set
10281 min_width/height (Bug#8919).
10282
10283 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
10284 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
10285 Fix indentation.
c7e73be5 10286
cf99dcf8
EZ
102872011-06-26 Eli Zaretskii <eliz@gnu.org>
10288
10289 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
10290 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
10291 called at ZV.
10292
029529ac
CY
102932011-06-26 Chong Yidong <cyd@stupidchicken.com>
10294
10295 * process.c (wait_reading_process_output): Bypass select if
10296 waiting for a cell while ignoring keyboard input, and input is
10297 pending. Suggested by Jan Djärv (Bug#8869).
10298
7a7ef429
PE
102992011-06-25 Paul Eggert <eggert@cs.ucla.edu>
10300
10301 Use gnulib's dup2 module instead of rolling our own.
10302 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
10303
11fdef7d 103042011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
10305
10306 * dispnew.c (scrolling_window): Before scrolling, turn off a
10307 mouse-highlight in the window being scrolled.
10308
cd3520a4
JB
103092011-06-24 Juanma Barranquero <lekktu@gmail.com>
10310
10311 Move DEFSYM to lisp.h and use everywhere.
10312
10313 * character.h (DEFSYM): Move declaration...
10314 * lisp.h (DEFSYM): ...here.
10315
10316 * gnutls.c:
10317 * minibuf.c:
10318 * w32menu.c:
10319 * w32proc.c:
10320 * w32select.c: Don't include character.h.
10321
10322 * alloc.c (syms_of_alloc):
10323 * buffer.c (syms_of_buffer):
10324 * bytecode.c (syms_of_bytecode):
10325 * callint.c (syms_of_callint):
10326 * casefiddle.c (syms_of_casefiddle):
10327 * casetab.c (init_casetab_once):
10328 * category.c (init_category_once, syms_of_category):
10329 * ccl.c (syms_of_ccl):
10330 * cmds.c (syms_of_cmds):
10331 * composite.c (syms_of_composite):
10332 * dbusbind.c (syms_of_dbusbind):
10333 * dired.c (syms_of_dired):
10334 * dispnew.c (syms_of_display):
10335 * doc.c (syms_of_doc):
10336 * editfns.c (syms_of_editfns):
10337 * emacs.c (syms_of_emacs):
10338 * eval.c (syms_of_eval):
10339 * fileio.c (syms_of_fileio):
10340 * fns.c (syms_of_fns):
10341 * frame.c (syms_of_frame):
10342 * fringe.c (syms_of_fringe):
10343 * insdel.c (syms_of_insdel):
10344 * keymap.c (syms_of_keymap):
10345 * lread.c (init_obarray, syms_of_lread):
10346 * macros.c (syms_of_macros):
10347 * msdos.c (syms_of_msdos):
10348 * print.c (syms_of_print):
10349 * process.c (syms_of_process):
10350 * search.c (syms_of_search):
10351 * sound.c (syms_of_sound):
10352 * syntax.c (init_syntax_once, syms_of_syntax):
10353 * terminal.c (syms_of_terminal):
10354 * textprop.c (syms_of_textprop):
10355 * undo.c (syms_of_undo):
10356 * w32.c (globals_of_w32):
10357 * window.c (syms_of_window):
10358 * xdisp.c (syms_of_xdisp):
10359 * xfaces.c (syms_of_xfaces):
10360 * xfns.c (syms_of_xfns):
10361 * xmenu.c (syms_of_xmenu):
10362 * xsettings.c (syms_of_xsettings):
10363 * xterm.c (syms_of_xterm): Use DEFSYM.
10364
4228cf16
TZ
103652011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
10366
cd3520a4 10367 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 10368
7fcccf1e
PE
103692011-06-23 Paul Eggert <eggert@cs.ucla.edu>
10370
7efb4e0e
PE
10371 Integer and buffer overflow fixes (Bug#8873).
10372
ff5844ad
PE
10373 * print.c (printchar, strout): Check for string overflow.
10374 (PRINTPREPARE, printchar, strout):
10375 Don't set size unless allocation succeeds.
10376
90532f02
PE
10377 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
10378 for sizes. Check for string overflow more accurately.
10379 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
10380
6d84508d
PE
10381 * macros.c: Integer and buffer overflow fixes.
10382 * keyboard.h (struct keyboard.kbd_macro_bufsize):
10383 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
10384 Use ptrdiff_t, not int, for sizes.
10385 Don't increment bufsize until after realloc succeeds.
10386 Check for size-calculation overflow.
10387 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
10388
437b2cb4
PE
10389 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
10390
8b9ac8b4
PE
10391 * lread.c: Integer overflow fixes.
10392 (read_integer): Radix is now EMACS_INT, not int,
10393 to improve quality of diagnostics for out-of-range radices.
10394 Calculate buffer size correctly for out-of-range radices.
10395 (read1): Check for integer overflow in radices, and in
10396 read-circle numbers.
82cb60d3
PE
10397 (read_escape): Avoid int overflow.
10398 (Fload, openp, read_buffer_size, read1)
10399 (substitute_object_recurse, read_vector, read_list, map_obarray):
10400 Use ptrdiff_t, not int, for sizes.
10401 (read1): Use EMACS_INT, not int, for sizes.
20270765 10402 Check for size overflow.
8b9ac8b4 10403
7fcccf1e
PE
10404 * image.c (cache_image): Check for size arithmetic overflow.
10405
bfbbd7e7
PE
10406 * lread.c: Integer overflow issues.
10407 (saved_doc_string_size, saved_doc_string_length)
10408 (prev_saved_doc_string_size, prev_saved_doc_string_length):
10409 Now ptrdiff_t, not int.
10410 (read1): Don't assume doc string length fits in int. Check for
10411 out-of-range doc string lengths.
10412 (read_list): Don't assume file position fits in int.
39019e54 10413 (read_escape): Check for hex character overflow.
bfbbd7e7 10414
4e323265
LL
104152011-06-22 Leo Liu <sdl.web@gmail.com>
10416
10417 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
10418 Move to minibuffer.el.
10419
85fece3e
PE
104202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10421
20b84ce9 10422 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
10423 The following patches are for when GLYPH_DEBUG && !XASSERT.
10424 * dispextern.h (trace_redisplay_p, dump_glyph_string):
10425 * dispnew.c (flush_stdout):
10426 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
10427 Mark as externally visible.
10428 * dispnew.c (check_window_matrix_pointers): Now static.
10429 * dispnew.c (window_to_frame_vpos):
10430 * xfns.c (unwind_create_frame):
10431 * xterm.c (x_check_font): Remove unused local.
10432 * scroll.c (CHECK_BOUNDS):
10433 * xfaces.c (cache_fache): Rename local to avoid shadowing.
10434 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
10435 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
10436 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
10437 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
10438 Now static.
10439 (debug_method_add): Use va_list and vsprintf rather than relying
10440 on undefined behavior with wrong number of arguments.
10441 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
10442 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
10443 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
10444 since we're not interested in debugging glyphs with old libraries.
10445 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
10446 GCC 4.6.0's static checking.
10447
0766b489
PE
104482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
10449
31fd4b32
PE
10450 Integer overflow and signedness fixes (Bug#8873).
10451 A few related buffer overrun fixes, too.
10452
b79e8648
PE
10453 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
10454
0766b489
PE
10455 * dispextern.h (struct face.stipple):
10456 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
10457 (x_bitmap_mask, x_allocate_bitmap_record)
10458 (x_create_bitmap_from_data, x_create_bitmap_from_file)
10459 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
10460 (x_create_bitmap_from_xpm_data):
10461 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
10462 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
10463 (.bitmaps_last):
10464 * xfaces.c (load_pixmap):
10465 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
10466 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
10467 (.bitmaps_last, struct x_output.icon_bitmap):
10468 Use ptrdiff_t, not int, for bitmap indexes.
10469 (x_allocate_bitmap_record): Check for size overflow.
10470 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
10471
b081724f
PE
10472 Use ptrdiff_t, not int, for overlay counts.
10473 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
10474 * editfns.c (overlays_around, get_pos_property):
10475 * textprop.c (get_char_property_and_overlay):
10476 * xdisp.c (next_overlay_change, note_mouse_highlight):
10477 * xfaces.c (face_at_buffer_position):
21514da7
PE
10478 * buffer.c (OVERLAY_COUNT_MAX): New macro.
10479 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
10480 (Fnext_overlay_change, Fprevious_overlay_change)
10481 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 10482 Use ptrdiff_t, not int, for sizes.
21514da7 10483 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 10484
3de73e5e
PE
10485 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
10486
2606c57b
PE
10487 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
10488 (x_session_initialize): Do not assume string length fits in int.
10489
aaafe47a
PE
10490 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
10491 This is unlikely, but can occur if DPI is outlandish.
10492
2674ddc8 10493 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
10494 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
10495
28154962
PE
10496 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
10497 * xrdb.c (magic_file_p, search_magic_path):
10498 Omit last arg SUFFIX; it was always 0. All callers changed.
10499 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
10500
7de51af5
PE
10501 * xfont.c (xfont_match): Avoid need for strlen.
10502
25ed6cc3
PE
10503 * xfns.c: Don't assume strlen fits in int.
10504 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
10505
4eab31dd
PE
10506 * xdisp.c (message_log_check_duplicate): Return intmax_t,
10507 not unsigned long, as we prefer signed integers. All callers changed.
10508 Detect integer overflow in repeat count.
10509 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 10510 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 10511
171e2a58
PE
10512 * termcap.c: Don't assume sizes fit in int and never overflow.
10513 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
10514 (gobble_line): Check for size-calculation overflow.
10515
ad39faca 10516 * minibuf.c (Fread_buffer):
6e5bb2dc 10517 * lread.c (intern, intern_c_string):
74ca2eb3
PE
10518 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
10519 Don't assume string length fits in int.
10520
52c61c22 10521 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
10522 * gtkutil.c (style_changed_cb): Avoid need for strlen.
10523
b5b8c9e5
PE
10524 * font.c: Don't assume string length fits in int.
10525 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
10526 Use ptrdiff_t, not int.
ccd6111c
PE
10527 (font_intern_prop): Don't assume string length fits in int.
10528 Don't assume integer property fits in fixnum.
10529 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 10530
882f0d81 10531 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 10532 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
10533 Reformulate so as not to need the command string.
10534 Invoke gzip -cd rather than gunzip, as it's more portable.
10535 (lock_info_type, lock_file_1, lock_file):
10536 Don't assume pid_t and time_t fit in unsigned long.
10537 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
10538 (current_lock_owner): Prefer signed type for sizes.
10539 Use memcpy, not strncpy, where memcpy is what is really wanted.
10540 Don't assume (via atoi) that time_t and pid_t fit in int.
10541 Check for time_t and/or pid_t out of range, e.g., via a network share.
10542 Don't alloca where an auto var works fine.
10543
93f4cf88
PE
10544 * fileio.c: Fix some integer overflow issues.
10545 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
10546 Don't assume string length fits in int.
10547 (directory_file_name): Don't assume string length fits in long.
10548 (make_temp_name): Don't assume pid fits in int, or that its print
10549 length is less than 20.
10550
f3e92b69
PE
10551 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
10552
1bfdaf10
PE
10553 * coding.c (make_subsidiaries): Don't assume string length fits in int.
10554
35016e9a
PE
10555 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
10556
3d1e65a1
PE
10557 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
10558 We prefer signed integers, even for size calculations.
10559
0b963a93
PE
10560 * emacs.c: Don't assume string length fits in 'int'.
10561 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
10562 (main): Don't invoke strlen when not needed.
10563
573f4b54
PE
10564 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
10565 (XD_DEBUG_MESSAGE): Don't waste a byte.
10566
989f33ba
PE
10567 * callproc.c (getenv_internal_1, getenv_internal)
10568 (Fgetenv_internal):
965d34eb
PE
10569 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
10570
e4d29b33
PE
10571 * lread.c (invalid_syntax): Omit length argument.
10572 All uses changed. This doesn't fix a bug, but it simplifies the
10573 code away from its former Hollerith-constant appearance, and it's
10574 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 10575 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 10576
eb49b136
PE
10577 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
10578 This didn't break anything, but it didn't help either.
10579 It's confusing to put a bogus integer in a place where the actual
10580 value does not matter.
9f62aeb1 10581 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 10582 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 10583
15375a22
PE
10584 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
10585 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
10586 implementation.
b61cc01c
PE
10587 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
10588 We prefer signed types, and the value cannot exceed the EMACS_INT
10589 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
10590 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
10591 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
10592 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 10593
53b2623d
PE
10594 * indent.c (sane_tab_width): New function.
10595 (current_column, scan_for_column, Findent_to, position_indentation)
10596 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 10597 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 10598
51cab52b 10599 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 10600
f2ed8a70
PE
10601 * lisp.h (lint_assume): New macro.
10602 * composite.c (composition_gstring_put_cache):
10603 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
10604
abe80cc6
PE
10605 * editfns.c, insdel.c:
10606 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 10607
b02c740e
PE
10608 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
10609
ebc96716
PE
10610 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
10611
b4e50fa0 10612 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 10613 Use much-faster test for byte-length change.
311d5d7c 10614 Don't assume string byte-length fits in 'int'.
a4cf38e4 10615 Check that character arg fits in 'int'.
85461888 10616 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 10617
c0c1ee9f
PE
10618 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
10619
a498d7f4
PE
10620 * fns.c (concat): Catch string overflow earlier.
10621 Do not rely on integer wraparound.
10622
51cab52b
PE
10623 * dispextern.h (struct it.overlay_strings_charpos)
10624 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
10625 * xdisp.c (forward_to_next_line_start)
10626 (back_to_previous_visible_line_start)
10627 (reseat_at_next_visible_line_start, next_element_from_buffer):
10628 Don't arbitrarily truncate the value of 'selective' to int.
10629
76031fad
PE
10630 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
10631
5eb55db9
PE
10632 * composite.c: Don't truncate sizes to 'int'.
10633 (composition_gstring_p, composition_reseat_it)
10634 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
10635 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
10636 not EMACS_UINT, for indexes.
5eb55db9 10637
0703a717
PE
10638 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
10639
d6202519
PE
10640 * buffer.c: Include <verify.h>.
10641 (struct sortvec.priority, struct sortstr.priority):
8961a454 10642 Now EMACS_INT, not int.
c20998a7 10643 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
10644 (struct sortstr.size, record_overlay_string)
10645 (struct sortstrlist.size, struct sortlist.used):
10646 Don't truncate size to int.
10647 (record_overlay_string): Check for size-calculation overflow.
d6202519 10648 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 10649
d5a19415
JM
106502011-06-22 Jim Meyering <meyering@redhat.com>
10651
029529ac 10652 Don't leak an XBM-image-sized buffer
d5a19415
JM
10653 * image.c (xbm_load): Free the image buffer after using it.
10654
a9041e6c
PE
106552011-06-21 Paul Eggert <eggert@cs.ucla.edu>
10656
10657 Port to Sun C.
10658 * composite.c (find_automatic_composition): Omit needless 'return 0;'
10659 that Sun C diagnosed.
10660 * fns.c (secure_hash): Fix pointer signedness issue.
10661 * intervals.c (static_offset_intervals): New function.
10662 (offset_intervals): Use it.
10663
7f3f739f
LL
106642011-06-21 Leo Liu <sdl.web@gmail.com>
10665
10666 * deps.mk (fns.o):
10667 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
10668 sha512.h.
10669
10670 * fns.c (secure_hash): Rename from crypto_hash_function and change
10671 the first arg to accept symbols.
5b66d427 10672 (Fsecure_hash): New primitive.
7f3f739f
LL
10673 (syms_of_fns): New symbols.
10674
76147d94
DD
106752011-06-20 Deniz Dogan <deniz@dogan.se>
10676
10677 * process.c (Fset_process_buffer): Clarify return value in
10678 docstring.
10679
7d7d0045
CY
106802011-06-18 Chong Yidong <cyd@stupidchicken.com>
10681
10682 * dispnew.c (add_window_display_history): Use BVAR.
10683
10684 * xdisp.c (debug_method_add): Use BVAR.
10685 (check_window_end, dump_glyph_matrix, dump_glyph)
10686 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
10687
10688 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
10689 Likewise.
10690
10691 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
10692 check till after the cache is created in init_frame_faces.
10693
ff2bc410
SM
106942011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
10695
10696 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
10697
28177add
PE
106982011-06-16 Paul Eggert <eggert@cs.ucla.edu>
10699
dd3482fe
PE
10700 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
10701 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
10702 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
10703
393d71f3 10704 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
10705 * fileio.c (Finsert_file_contents):
10706 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
10707 Remove the old (too-loose) buffer overflow checks.
10708 They weren't needed, since make_gap checks for buffer overflow.
10709 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
10710 The old code merely checked for Emacs fixnum overflow, and relied
10711 on undefined (wraparound) behavior. The new code avoids undefined
10712 behavior, and also checks for ptrdiff_t and/or size_t overflow.
10713
2e6813b0 10714 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
10715 Tune. Don't use wider integers than needed. Don't use alloca.
10716 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 10717
599a9e4f
PE
10718 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
10719
99561444
PE
10720 * insdel.c, lisp.h (buffer_overflow): New function.
10721 (insert_from_buffer_1, replace_range, replace_range_2):
10722 * insdel.c (make_gap_larger):
10723 * editfns.c (Finsert_char):
10724 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
10725
28177add
PE
10726 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
10727
e69dafad
PE
107282011-06-15 Paul Eggert <eggert@cs.ucla.edu>
10729
4baa020d 10730 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 10731
b1c46f02
PE
10732 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
10733 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
10734
e69dafad
PE
10735 * fileio.c: Don't assume EMACS_INT fits in off_t.
10736 (emacs_lseek): New static function.
10737 (Finsert_file_contents, Fwrite_region): Use it.
10738 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
10739
566684ea
PE
10740 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
10741
e6966cd6
PE
10742 * fns.c: Don't overflow int when computing a list length.
10743 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
10744 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
10745 truncation on 64-bit hosts. Check for QUIT every
10746 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
10747 faster and is responsive enough.
10748 (Flength): Report an error instead of overflowing an integer.
10749 (Fsafe_length): Return a float if the value is not representable
10750 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 10751 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 10752 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 10753
dd0b0efb
PE
10754 * alloc.c: Check that resized vectors' lengths fit in fixnums.
10755 (header_size, word_size): New constants.
10756 (allocate_vectorlike): Don't check size overflow here.
10757 (allocate_vector): Check it here instead, since this is the only
10758 caller of allocate_vectorlike that could cause overflow.
10759 Check that the new vector's length is representable as a fixnum.
10760
86fe5cfe
PE
10761 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
10762 The previous code was bogus. For example, next_almost_prime (32)
10763 returned 39, which is undesirable as it is a multiple of 3; and
10764 next_almost_prime (24) returned 25, which is a multiple of 5 so
10765 why was the code bothering to check for multiples of 7?
10766
80e88859
PE
10767 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
10768
4a2f0ad6
PE
10769 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
10770
f66c7cf8
PE
10771 Variadic C functions now count arguments with ptrdiff_t.
10772 This partly undoes my 2011-03-30 change, which replaced int with size_t.
10773 Back then I didn't know that the Emacs coding style prefers signed int.
10774 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
10775 were being counted with int, which may truncate counts on 64-bit
10776 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
10777 * lisp.h (struct Lisp_Subr.function.aMANY)
10778 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
10779 Arg counts are now ptrdiff_t, not size_t.
10780 All variadic functions and their callers changed accordingly.
10781 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
10782 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
10783 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
10784 * callint.c (Fcall_interactively): Check arg count for overflow,
10785 to avoid potential buffer overrun. Use signed char, not 'int',
10786 for 'varies' array, so that we needn't bother to check its size
10787 calculation for overflow.
10788 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10789 * eval.c (apply_lambda):
10790 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10791 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10792 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10793
a1759b76
PE
10794 * callint.c (Fcall_interactively): Don't use index var as event count.
10795
d96be9fc
PE
10796 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10797 * mem-limits.h (SIZE): Remove; no longer used.
10798
a690a978 10799 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10800
578c21e6
PE
10801 Remove unnecessary casts.
10802 * xterm.c (x_term_init):
10803 * xfns.c (x_set_border_pixel):
10804 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10805 These aren't needed now that we assume ANSI C.
10806
96f53c6c
PE
10807 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10808 It's more likely to cause problems (due to unsigned overflow)
10809 than to cure them.
10810
83c77d31
PE
10811 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10812
ee2079f1
PE
10813 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10814
6da65536
PE
10815 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10816
7147c4a4
PE
10817 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10818
193e32d9
PE
10819 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10820
e5533da6
PE
10821 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10822
9910e595
PE
10823 GLYPH_CODE_FACE returns EMACS_INT, not int.
10824 * dispextern.h (merge_faces):
10825 * xfaces.c (merge_faces):
01103c44
PE
10826 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10827 Don't assume EMACS_INT fits in int.
9910e595 10828
2638320e
PE
10829 * character.h (CHAR_VALID_P): Remove unused parameter.
10830 * fontset.c, lisp.h, xdisp.c: All uses changed.
10831
045eb8d9
PE
10832 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10833
c1f134b5
PE
10834 * fns.c (concat): Minor tuning based on overflow analysis.
10835 This doesn't fix any bugs. Use int to hold character, instead
10836 of constantly refetching from Emacs object. Use XFASTINT, not
10837 XINT, for value known to be a character. Don't bother comparing
10838 a single byte to 0400, as it's always less.
10839
395fcb93 10840 * floatfns.c (Fexpt):
327eeec8
PE
10841 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10842
abbd3d23
PE
10843 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10844 for characters.
10845
684a03ef
PE
10846 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10847
0fed43f3
PE
10848 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10849 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10850 incorrectly succeed when S was a string, because 4294967386 was
10851 truncated before it was used.
10852
8fd02eb7
PE
10853 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10854 Otherwise, an out-of-range integer could cause undefined behavior
10855 on a 64-bit host.
10856
f8c86b69
PE
10857 * composite.c: Use int, not EMACS_INT, for characters.
10858 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10859 EMACS_INT, for values that are known to be in character range.
10860 This doesn't fix any bugs but is the usual style inside Emacs and
10861 may generate better code on 32-bit machines.
10862
34206dd2
PE
10863 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10864 This is for reasons similar to the recent CHAR_STRING fix.
10865 * charset.c (Fencode_char): Check that character arg is actually
10866 a character. Pass an int to ENCODE_CHAR.
10867 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10868 wider than 'int', as a compile-time check to prevent future regressions
10869 in this area.
10870
c5958d4c 10871 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10872
10873 Make sure a 64-bit char is never passed to CHAR_STRING.
10874 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10875 by silently ignoring the top 32 bits, allowing some values
10876 that were far too large to be valid characters.
10877 * character.h: Include <verify.h>.
10878 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10879 arguments are no wider than unsigned, as a compile-time check
10880 to prevent future regressions in this area.
10881 * data.c (Faset):
01103c44 10882 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10883 (Fsubst_char_in_region):
10884 * fns.c (concat):
10885 * xdisp.c (decode_mode_spec_coding):
10886 Adjust to CHAR_STRING's new requirement.
10887 * editfns.c (Finsert_char, Fsubst_char_in_region):
10888 * fns.c (concat): Check that character args are actually
10889 characters. Without this test, these functions did the wrong
10890 thing with wildly out-of-range values on 64-bit hosts.
10891
d37ca623
PE
10892 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10893 These casts should not be needed on 32-bit hosts, either.
10894 * keyboard.c (read_char):
10895 * lread.c (Fload): Remove casts to unsigned.
10896
ea204efb
PE
10897 * lisp.h (UNSIGNED_CMP): New macro.
10898 This fixes comparison bugs on 64-bit hosts.
10899 (ASCII_CHAR_P): Use it.
10900 * casefiddle.c (casify_object):
01103c44 10901 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10902 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10903 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10904 * dispextern.h (FACE_FROM_ID):
10905 * keyboard.c (read_char): Use UNSIGNED_CMP.
10906
41cb286c
PE
10907 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10908 not to EMACS_INT, to avoid GCC warning.
10909
4a1b9832
PE
10910 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10911
55daad71
PE
10912 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10913 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10914 isn't needed on 32-bit machines.
8f95c75c 10915
01103c44
PE
10916 * buffer.c (Fgenerate_new_buffer_name):
10917 Use EMACS_INT for count, not int.
0ceccced 10918 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10919
10920 * data.c (Qcompiled_function): Now static.
10921
c6f072e7
PE
10922 * window.c (window_body_lines): Now static.
10923
20ce5912
PE
10924 * image.c (gif_load): Rename local to avoid shadowing.
10925
9c4c5f81
PE
10926 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10927 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10928 * alloc.c (make_save_value): Integer argument is now of type
10929 ptrdiff_t, not int.
10930 (mark_object): Use ptrdiff_t, not int.
10931 * lisp.h (pD): New macro.
10932 * print.c (print_object): Use it.
10933
c0c5c8ae
PE
10934 * alloc.c: Use EMACS_INT, not int, to count objects.
10935 (total_conses, total_markers, total_symbols, total_vector_size)
10936 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10937 (total_free_floats, total_floats, total_free_intervals)
10938 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10939 Now EMACS_INT, not int. All uses changed.
10940 (Fgarbage_collect): Compute overall total using a double, so that
10941 integer overflow is less likely to be a problem. Check for overflow
10942 when converting back to an integer.
5a25e253
PE
10943 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10944 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10945 These were 'int' variables that could overflow on 64-bit hosts;
10946 they were never used, so remove them instead of repairing them.
211a0b2a 10947 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10948 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10949 Previously, this ceilinged at INT_MAX, but that doesn't work on
10950 64-bit machines.
e46bb31a 10951 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10952
c78baabf 10953 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10954 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10955 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10956 when a (possibly-narrower) signed value would do just as well.
10957 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10958
c9d624c6
PE
10959 * alloc.c: Catch some string size overflows that we were missing.
10960 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10961 for convenience in STRING_BYTES_MAX.
10962 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10963 The definition here is exact; the one in lisp.h was approximate.
10964 (allocate_string_data): Check for string overflow. This catches
10965 some instances we weren't catching before. Also, it catches
10966 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10967 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10968 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10969
c9d624c6
PE
10970 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10971 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10972 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10973
353032ce
PE
10974 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10975
2bccce07
PE
10976 * alloc.c (Fmake_string): Check for out-of-range init.
10977
0ac30604
SM
109782011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10979
10980 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10981
c195f2de
JD
109822011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10983
10984 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10985 xg_get_default_scrollbar_width.
10986
10987 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10988 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10989 (style_changed_cb): Call update_theme_scrollbar_width and call
10990 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10991 all frames (Bug#8505).
10992 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10993 Call gtk_window_set_resizable if HAVE_GTK3.
10994 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10995 and height if HAVE_GTK3 (Bug#8505).
10996 (scroll_bar_width_for_theme): New variable.
10997 (update_theme_scrollbar_width): New function.
10998 (xg_get_default_scrollbar_width): Move code to
10999 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
11000 (xg_initialize): Call update_theme_scrollbar_width.
11001
11002 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
11003
11004 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
11005
e10ac9f1
MR
110062011-06-12 Martin Rudalics <rudalics@gmx.at>
11007
11008 * frame.c (make_frame): Call other_buffer_safely instead of
11009 other_buffer.
11010
11011 * window.c (temp_output_buffer_show): Call display_buffer with
11012 second argument Vtemp_buffer_show_specifiers and reset latter
11013 immediately after the call.
11014 (Vtemp_buffer_show_specifiers): New variable.
11015 (auto_window_vscroll_p, next_screen_context_lines)
11016 (Vscroll_preserve_screen_position): Remove leading asterisks from
11017 doc-strings.
11018
2d3c217e 110192011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 11020
7b7f97e8 11021 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
11022 * buffer.c (Qclone_number): Remove for now, as it's unused.
11023 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
11024 (record_buffer): Remove unused local.
11025 * frame.c (other_visible_frames, frame_buffer_list): Now static.
11026 (set_frame_buffer_list): Remove; unused.
11027 * frame.h (other_visible_frames): Remove decl.
11028 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
11029 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
11030 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
11031 if HAVE_GPM.
11032 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
11033 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
11034 Define only if HAVE_GPM.
11035 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
11036 (update_hints_inhibit): Remove; never set. All uses removed.
11037 * widgetprv.h (emacsFrameClassRec): Remove decl.
11038 * window.c (delete_deletable_window): Now returns void, since it
11039 wasn't returning anything.
11040 (compare_window_configurations): Remove unused locals.
11041 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
11042 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
11043 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
11044 the same widths as pointers. This follows up on the 2011-05-06 patch.
11045 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
11046 * xterm.h: Likewise.
11047 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
11048
1384b89e
JB
110492011-06-12 Juanma Barranquero <lekktu@gmail.com>
11050
11051 * makefile.w32-in: Update dependencies.
11052 (LISP_H): Add lib/intprops.h.
11053
1100a63c
CY
110542011-06-11 Chong Yidong <cyd@stupidchicken.com>
11055
11056 * image.c (gif_load): Add animation frame delay to the metadata.
11057 (syms_of_image): Use DEFSYM. New symbol `delay'.
11058
6198ccd0
MR
110592011-06-11 Martin Rudalics <rudalics@gmx.at>
11060
11061 * window.c (delete_deletable_window): Re-add.
11062 (Fset_window_configuration): Rewrite to handle dead buffers and
11063 consequently deletable windows.
11064 (window_tree, Fwindow_tree): Remove. Supply functionality in
11065 window.el.
11066 (compare_window_configurations): Simplify code.
11067
b6e3633c
AS
110682011-06-11 Andreas Schwab <schwab@linux-m68k.org>
11069
1ab0dee5
AS
11070 * image.c (imagemagick_load_image): Fix type mismatch.
11071 (Fimagemagick_types): Likewise.
11072
b6e3633c
AS
11073 * window.h (replace_buffer_in_windows): Declare.
11074
9397e56f
MR
110752011-06-11 Martin Rudalics <rudalics@gmx.at>
11076
11077 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
11078 Qclone_number. Remove external declaration of Qdelete_window.
11079 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
11080 code.
640c8776
SM
11081 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
11082 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
11083 (Fother_buffer): Rewrite doc-string. Major rewrite for new
11084 buffer list implementation.
11085 (other_buffer_safely): New function.
11086 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
11087 calls to replace_buffer_in_windows and
11088 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
11089 if allowed.
11090 (record_buffer): Inhibit quitting and rewrite using quittable
11091 functions. Run Qbuffer_list_update_hook if allowed.
11092 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
11093 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
11094 Move switch-to-buffer to window.el.
9397e56f
MR
11095 (bury-buffer): Move to window.el.
11096 (Vbuffer_list_update_hook): New variable.
11097
11098 * lisp.h (other_buffer_safely): Add prototype in buffer.c
11099 section.
11100
11101 * window.h (resize_frame_windows): Move up in code.
11102 (Fwindow_frame): Remove EXFUN.
11103 (replace_buffer_in_all_windows): Remove prototype.
11104 (replace_buffer_in_windows_safely): Add prototype.
11105
11106 * window.c: Declare Qdelete_window static again. Move down
11107 declaration of select_count.
11108 (Fnext_window, Fprevious_window): Rewrite doc-strings.
11109 (Fother_window): Move to window.el.
11110 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
11111 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
11112 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
11113 window.el.
11114 (replace_buffer_in_windows): Implement by calling
11115 Qreplace_buffer_in_windows.
11116 (replace_buffer_in_all_windows): Remove with some functionality
11117 moved into replace_buffer_in_windows_safely.
11118 (replace_buffer_in_windows_safely): New function.
11119 (select_window_norecord, select_frame_norecord): Move in front
11120 of run_window_configuration_change_hook. Remove now obsolete
11121 declarations.
640c8776
SM
11122 (Fset_window_buffer): Rewrite doc-string.
11123 Call Qrecord_window_buffer.
9397e56f
MR
11124 (keys_of_window): Move binding for other-window to window.el.
11125
b50691aa
CY
111262011-06-11 Chong Yidong <cyd@stupidchicken.com>
11127
11128 * dispextern.h (struct image): Replace data member, whose int_val
11129 and ptr_val fields were not used by anything, with a single
11130 lisp_val object.
11131
11132 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
11133 (gif_clear_image, gif_load, imagemagick_load_image)
11134 (gs_clear_image, gs_load): Callers changed.
11135
3f754b86
PE
111362011-06-10 Paul Eggert <eggert@cs.ucla.edu>
11137
cca69397
PE
11138 * buffer.h: Include <time.h>, for time_t.
11139 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
11140
109e28d0
PE
11141 Fix minor problems found by static checking.
11142
60737f02
PE
11143 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
11144
4b66faf3
PE
11145 Make identifiers static if they are not used in other modules.
11146 * data.c (Qcompiled_function, Qframe, Qvector):
11147 * image.c (QimageMagick, Qsvg):
11148 * minibuf.c (Qmetadata):
11149 * window.c (resize_window_check, resize_root_window): Now static.
11150 * window.h (resize_window_check, resize_root_window): Remove decls.
11151
109e28d0
PE
11152 * window.c (window_deletion_count, delete_deletable_window):
11153 Remove; unused.
46a4ce9e
PE
11154 (window_body_lines): Now static.
11155 (Fdelete_other_windows_internal): Mark vars as initialized.
11156 Make sure 'resize_failed' is initialized.
11157 (run_window_configuration_change_hook): Rename local to avoid shadowing.
11158 (resize_window_apply): Remove unused local.
11159 * window.h (delete_deletable_window): Remove decl.
11160
109e28d0 11161 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
11162 (imagemagick_load_image): Fix pointer signedness problem by changing
11163 last arg from unsigned char * to char *. All uses changed.
11164 Also, fix a local for similar reasons.
11165 Remove unused locals. Remove locals to avoid shadowing.
11166 (fn_rsvg_handle_free): Remove; unused.
11167 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 11168 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 11169
3f754b86
PE
11170 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
11171
2547adb1
CY
111722011-06-10 Chong Yidong <cyd@stupidchicken.com>
11173
11174 * image.c (gif_load): Fix omitted cast error introduced by
11175 2011-06-06 change.
11176
2c8e37d4
MR
111772011-06-10 Martin Rudalics <rudalics@gmx.at>
11178
11179 * window.h (resize_proportionally, orig_total_lines)
11180 (orig_top_line): Remove from window structure.
11181 (set_window_height, set_window_width, change_window_heights)
11182 (Fdelete_window): Remove prototypes.
11183 (resize_frame_windows): Remove duplicate declaration.
11184
440a42e3
EZ
111852011-06-10 Eli Zaretskii <eliz@gnu.org>
11186
11187 * window.h (resize_frame_windows, resize_window_check)
11188 (delete_deletable_window, resize_root_window)
11189 (resize_frame_windows): Declare prototypes.
11190
11191 * window.c (resize_window_apply): Make definition be "static" to
11192 match the prototype.
11193
562dd5e9
MR
111942011-06-10 Martin Rudalics <rudalics@gmx.at>
11195
11196 * window.c: Remove declarations of Qwindow_size_fixed,
11197 window_min_size_1, window_min_size_2, window_min_size,
11198 size_window, window_fixed_size_p, enlarge_window, delete_window.
11199 Remove static from declaration of Qdelete_window, it's
11200 temporarily needed by Fbury_buffer.
11201 (replace_window): Don't assign orig_top_line and
11202 orig_total_lines.
11203 (Fdelete_window, delete_window): Remove. Window deletion is
11204 handled by window.el.
640c8776
SM
11205 (window_loop): Remove DELETE_OTHER_WINDOWS case.
11206 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
11207 (Fdelete_other_windows): Remove. Deleting other windows is
11208 handled by window.el.
11209 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
11210 handled in window.el.
11211 (window_min_size_2, window_min_size_1, window_min_size): Remove.
11212 Window minimum sizes are handled in window.el.
11213 (shrink_windows, size_window, set_window_height)
11214 (set_window_width, change_window_heights, window_height)
11215 (window_width, CURBEG, CURSIZE, enlarge_window)
11216 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
11217 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
11218 handled in window.el.
11219 (make_dummy_parent): Rename to make_parent_window and give it a
11220 second argument horflag.
11221 (make_window): Don't set resize_proportionally any more.
11222 (Fsplit_window): Remove. Windows are split in window.el.
11223 (save_restore_action, save_restore_orig_size)
11224 (shrink_window_lowest_first, save_restore_orig_size): Remove.
11225 Resize mini windows in window.el.
11226 (grow_mini_window, shrink_mini_window): Implement by calling
11227 Qresize_root_window_vertically, resize_window_check and
11228 resize_window_apply.
640c8776
SM
11229 (saved_window, Fset_window_configuration, save_window_save):
11230 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
11231 resize_proportionally.
11232 (window_min_height, window_min_width): Move to window.el.
11233 (keys_of_window): Move bindings for delete-other-windows,
11234 split-window, delete-window and enlarge-window to window.el.
11235
11236 * buffer.c: Temporarily extern Qdelete_window.
11237 (Fbury_buffer): Temporarily call Qdelete_window instead of
11238 Fdelete_window (Fbury_buffer will move to window.el soon).
11239
11240 * frame.c (set_menu_bar_lines_1): Remove code handling
11241 orig_top_line and orig_total_lines.
11242
11243 * dispnew.c (adjust_frame_glyphs_initially): Don't use
11244 set_window_height but set heights directly.
11245 (change_frame_size_1): Use resize_frame_windows.
11246
11247 * xdisp.c (init_xdisp): Don't use set_window_height but set
11248 heights directly.
11249
640c8776
SM
11250 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
11251 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
11252 run_window_configuration_change_hook.
11253
11254 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
11255 instead of change_window_heights and run
11256 run_window_configuration_change_hook.
11257
1a13852e
MR
112582011-06-09 Martin Rudalics <rudalics@gmx.at>
11259
11260 * window.c (replace_window): Rename second argument REPLACEMENT to
11261 NEW. New third argument SETFLAG. Rewrite.
11262 (delete_window, make_dummy_parent): Call replace_window with
11263 third argument 1.
11264 (window_list_1): Move down in code.
11265 (run_window_configuration_change_hook): Move set_buffer part
11266 before select_frame_norecord part in order to unwind correctly.
11267 Rename count1 to count.
11268 (recombine_windows, delete_deletable_window, resize_root_window)
11269 (Fdelete_other_windows_internal)
11270 (Frun_window_configuration_change_hook, make_parent_window)
11271 (resize_window_check, resize_window_apply, Fresize_window_apply)
11272 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
11273 (Fdelete_window_internal, Fresize_mini_window_internal):
11274 New functions.
1a13852e
MR
11275 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
11276
f3d1777e
MR
112772011-06-08 Martin Rudalics <rudalics@gmx.at>
11278
496e208e
MR
11279 * window.h (window): Add some new members to window structure -
11280 normal_lines, normal_cols, new_total, new_normal, clone_number,
11281 splits, nest, prev_buffers, next_buffers.
11282 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 11283 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 11284
f3d1777e
MR
11285 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
11286 Remove.
496e208e
MR
11287 (make_dummy_parent): Set new members of windows structure.
11288 (make_window): Move down in code. Handle new members of window
11289 structure.
11290 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
11291 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
11292 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
11293 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
11294 (Fset_window_next_buffers, Fset_window_clone_number):
11295 New functions.
496e208e
MR
11296 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
11297 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
11298 Doc-string fixes.
11299 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
11300 Argument WINDOW can be now internal window too.
11301 (Fwindow_use_time): Move up in code.
11302 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
11303 Rewrite doc-string.
11304 (Fset_window_configuration, saved_window)
11305 (Fcurrent_window_configuration, save_window_save): Handle new
11306 members of window structure.
b9e809c2
MR
11307 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
11308 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
11309 (syms_of_window): New Lisp objects Qrecord_window_buffer,
11310 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
11311 Qget_mru_window, Qresize_root_window,
11312 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
11313 Qauto_buffer_name; staticpro them.
f3d1777e 11314
abde8f8c
MR
113152011-06-07 Martin Rudalics <rudalics@gmx.at>
11316
11317 * window.c (Fwindow_total_size, Fwindow_left_column)
11318 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
11319 (Fwindow_list_1): New functions.
11320 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
11321 (Fwindow_width, Fscroll_left, Fscroll_right):
11322 Use window_body_cols instead of window_box_text_cols.
11323 (delete_window, Fset_window_configuration):
11324 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
11325 (delete_all_subwindows): Take a window as argument and not a
11326 structure. Rewrite.
190b47e6
MR
11327 (window_loop): Remove handling of GET_LRU_WINDOW and
11328 GET_LARGEST_WINDOW.
11329 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
11330
11331 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
11332 window_box_text_cols. delete_all_subwindows now takes a
11333 Lisp_Object as argument.
abde8f8c 11334
640c8776
SM
11335 * indent.c (compute_motion, Fcompute_motion):
11336 Use window_body_cols instead of window_box_text_cols.
abde8f8c 11337
fa8a67e6
MR
11338 * frame.c (delete_frame): Call delete_all_subwindows with root
11339 window as argument.
11340
a54e3482
DC
113412011-06-07 Daniel Colascione <dan.colascione@gmail.com>
11342
11343 * fns.c (Fputhash): Document return value.
11344
60002bf5
CY
113452011-06-06 Chong Yidong <cyd@stupidchicken.com>
11346
11347 * image.c (gif_load): Implement gif89a spec "no disposal" method.
11348
0c671da6 113492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 11350
b862a52a 11351 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 11352
be44ca6c
PE
11353 Check for overflow when converting integer to cons and back.
11354 * charset.c (Fdefine_charset_internal, Fdecode_char):
11355 Use cons_to_unsigned to catch overflow.
11356 (Fencode_char): Use INTEGER_TO_CONS.
11357 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
11358 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
11359 * data.c (long_to_cons, cons_to_long): Remove.
11360 (cons_to_unsigned, cons_to_signed): New functions.
11361 These signal an error for invalid or out-of-range values.
11362 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
11363 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
11364 * font.c (Ffont_variation_glyphs):
11365 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
11366 * lisp.h: Include <intprops.h>.
11367 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
11368 (cons_to_signed, cons_to_unsigned): New decls.
11369 (long_to_cons, cons_to_long): Remove decls.
11370 * undo.c (record_first_change): Use INTEGER_TO_CONS.
11371 (Fprimitive_undo): Use CONS_TO_INTEGER.
11372 * xfns.c (Fx_window_property): Likewise.
11373 * xselect.c: Include <limits.h>.
11374 (x_own_selection, selection_data_to_lisp_data):
11375 Use INTEGER_TO_CONS.
11376 (x_handle_selection_request, x_handle_selection_clear)
11377 (x_get_foreign_selection, Fx_disown_selection_internal)
11378 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
11379 (lisp_data_to_selection_data): Use cons_to_unsigned.
11380 (x_fill_property_data): Use cons_to_signed.
11381 Report values out of range.
11382
d1f3d2af
PE
11383 Check for buffer and string overflow more precisely.
11384 * buffer.h (BUF_BYTES_MAX): New macro.
11385 * lisp.h (STRING_BYTES_MAX): New macro.
11386 * alloc.c (Fmake_string):
11387 * character.c (string_escape_byte8):
11388 * coding.c (coding_alloc_by_realloc):
11389 * doprnt.c (doprnt):
11390 * editfns.c (Fformat):
11391 * eval.c (verror):
11392 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
11393 since they may not be the same number.
11394 * editfns.c (Finsert_char):
11395 * fileio.c (Finsert_file_contents):
11396 Likewise for BUF_BYTES_MAX.
11397
dd52fcea
PE
11398 * image.c: Use ptrdiff_t, not int, for sizes.
11399 (slurp_file): Switch from int to ptrdiff_t.
11400 All uses changed.
11401 (slurp_file): Check that file size fits in both size_t (for
11402 malloc) and ptrdiff_t (for sanity and safety).
11403
7f9bbdbb
PE
11404 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
11405 if b->modtime has its maximal value.
11406
dfe18f82
PE
11407 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
11408
84acfcf0
PE
11409 Don't assume time_t can fit into int.
11410 * buffer.h (struct buffer.modtime): Now time_t, not int.
11411 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
11412 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
11413
ccd9a01a
PE
11414 Minor fixes for signed vs unsigned integers.
11415 * character.h (MAYBE_UNIFY_CHAR):
11416 * charset.c (maybe_unify_char):
11417 * keyboard.c (read_char, reorder_modifiers):
11418 XINT -> XFASTINT, since the integer must be nonnegative.
11419 * ftfont.c (ftfont_spec_pattern):
11420 * keymap.c (access_keymap, silly_event_symbol_error):
11421 XUINT -> XFASTINT, since the integer must be nonnegative.
11422 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
11423 since it makes no difference and we prefer signed.
11424 * keyboard.c (record_char): Use XUINT when all the neighbors do.
11425 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
11426 nonnegative.
11427
d6d100dd
SM
114282011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
11429
11430 * window.h (Fwindow_frame): Declare.
11431
2b6148e4
PE
114322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11433
11434 * alloc.c: Simplify handling of large-request failures (Bug#8800).
11435 (SPARE_MEMORY): Always define.
11436 (LARGE_REQUEST): Remove.
11437 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
11438
f230ecc9
MR
114392011-06-06 Martin Rudalics <rudalics@gmx.at>
11440
727e958e
MR
11441 * lisp.h: Move EXFUNS for Fframe_root_window,
11442 Fframe_first_window and Fset_frame_selected_window to window.h.
11443
11444 * window.h: Move EXFUNS for Fframe_root_window,
11445 Fframe_first_window and Fset_frame_selected_window here from
11446 lisp.h.
11447
11448 * frame.c (Fwindow_frame, Fframe_first_window)
11449 (Fframe_root_window, Fframe_selected_window)
11450 (Fset_frame_selected_window): Move to window.c.
11451 (Factive_minibuffer_window): Move to minibuf.c.
11452 (Fother_visible_frames_p): New function.
11453
11454 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
11455
f230ecc9
MR
11456 * window.c (decode_window, decode_any_window): Move up in code.
11457 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
11458 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
11459 (Fwindow_buffer): Move up and rewrite doc-string.
11460 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
11461 (Fwindow_prev): New functions.
727e958e
MR
11462 (Fwindow_frame): Move here from frame.c. Accept any window as
11463 argument.
11464 (Fframe_root_window, Fframe_first_window)
11465 (Fframe_selected_window): Move here from frame.c. Accept frame
11466 or arbitrary window as argument. Update doc-strings.
11467 (Fminibuffer_window): Move up in code.
11468 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
11469 (Fset_frame_selected_window): Move here from frame.c.
11470 Marginal rewrite.
727e958e
MR
11471 (Fselected_window, select_window, Fselect_window): Move up in
11472 code. Minor doc-string fixes.
f230ecc9 11473
4d09bcf6
PE
114742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
11475
11476 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
11477 Do not assume that spare memory exists; that assumption is valid
11478 only if SYSTEM_MALLOC.
11479 (LARGE_REQUEST): New macro, so that the issue of large requests
11480 is separated from the issue of spare memory.
11481
810928a2
AS
114822011-06-05 Andreas Schwab <schwab@linux-m68k.org>
11483
172418ad
AS
11484 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
11485 format. (Bug#8806)
11486
43f862f7
AS
11487 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
11488
810928a2
AS
11489 * xfns.c (x_set_scroll_bar_default_width): Move declarations
11490 before statements.
11491
a059fe24
JD
114922011-06-05 Jan Djärv <jan.h.d@swipnet.se>
11493
11494 * gtkutil.c (xg_get_default_scrollbar_width): New function.
11495
11496 * gtkutil.h: Declare xg_get_default_scrollbar_width.
11497
11498 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
11499 min width by calling x_set_scroll_bar_default_width (Bug#8505).
11500
989bf368
JB
115012011-06-05 Juanma Barranquero <lekktu@gmail.com>
11502
11503 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
11504
4b80f674
CY
115052011-06-04 Chong Yidong <cyd@stupidchicken.com>
11506
11507 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
11508 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
11509 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
11510 New error handlers.
4b80f674
CY
11511 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
11512 Obey Vx_select_enable_clipboard_manager. Catch errors in
11513 x_clipboard_manager_save (Bug#8779).
11514 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 11515 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 11516
99a33b77 115172011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
11518
11519 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
11520
99a33b77 115212011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
11522
11523 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
11524 in the current matrix if keep_current_p is non-zero.
11525
8264569d
EZ
115262011-06-04 Eli Zaretskii <eliz@gnu.org>
11527
11528 * bidi.c (bidi_level_of_next_char): Fix last change.
11529
57f97249
EZ
115302011-06-03 Eli Zaretskii <eliz@gnu.org>
11531
fec2107c 11532 Support bidi reordering of text covered by display properties.
57f97249 11533
fec2107c
EZ
11534 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
11535 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
11536 (bidi_cache_search, bidi_cache_iterator_state)
11537 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
11538 (bidi_level_of_next_char, bidi_move_to_visually_next):
11539 Support character positions inside a run of characters covered by a
fec2107c
EZ
11540 display string.
11541 (bidi_paragraph_init, bidi_resolve_explicit_1)
11542 (bidi_level_of_next_char): Call bidi_fetch_char and
11543 bidi_fetch_char_advance instead of FETCH_CHAR and
11544 FETCH_CHAR_ADVANCE.
11545 (bidi_init_it): Initialize new members.
11546 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
11547 definitions.
11548 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
11549 instead of using explicit *_CHAR codes.
d6d100dd
SM
11550 (bidi_resolve_explicit, bidi_resolve_weak):
11551 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
11552 bidirectional text is supported only in multibyte buffers.
11553 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
11554 it to initialize the frame_window_p member of struct bidi_it.
11555 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
11556 (bidi_resolve_explicit, bidi_resolve_weak)
11557 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
11558 bidi_it->nchars is non-positive.
11559 (bidi_level_of_next_char): Don't try to lookup the cache for the
11560 next/previous character if nothing is cached there yet, or if we
11561 were just reseat()'ed to a new position.
c40e2fb2 11562
0e14fe90
EZ
11563 * xdisp.c (set_cursor_from_row): Set start and stop points
11564 according to the row's direction when priming the loop that looks
11565 for the glyph on which to display cursor.
11566 (single_display_spec_intangible_p): Function deleted.
11567 (display_prop_intangible_p): Reimplement to call
11568 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
11569 Accept 3 additional arguments needed by handle_display_spec.
11570 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
11571 values: lists, `(when COND...)' forms, etc.
11572 (single_display_spec_string_p): Support property values that are
11573 lists with the argument STRING its top-level element.
11574 (display_prop_string_p): Fix the condition for processing a
11575 property that is a list to be consistent with handle_display_spec.
fec2107c 11576 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
11577 last portion of handle_display_prop.
11578 (compute_display_string_pos): Accept additional argument
11579 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
11580 value of a `display' property is a "replacing spec".
11581 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
11582 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
11583 the display property, but just return a value indicating whether
11584 the display property will replace the characters it covers.
11585 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
11586 frame_window_p members of struct bidi_it.
d6d100dd
SM
11587 (compute_display_string_pos, compute_display_string_end):
11588 New functions.
fec2107c
EZ
11589 (push_it): Accept second argument POSITION, where pop_it should
11590 jump to continue iteration.
11591 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 11592
fec2107c
EZ
11593 * keyboard.c (adjust_point_for_property): Adjust the call to
11594 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
11595
11596 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
11597 (bidi_init_it): Update prototypes.
11598 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
11599 (compute_display_string_pos, compute_display_string_end):
11600 Declare prototypes.
fec2107c
EZ
11601 (struct bidi_it): New members nchars and disp_pos. ch_len is now
11602 EMACS_INT.
fc6f18ce 11603
40087514 116042011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 11605
57f53182
PE
11606 Malloc failure behavior now depends on size of allocation.
11607 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
11608 * lisp.h: Change signatures accordingly.
11609 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
11610 All callers changed. (Bug#8762)
11611
11612 * gnutls.c: Use Emacs's memory allocators.
11613 Without this change, the gnutls library would invoke malloc etc.
11614 directly, which causes problems on non-SYNC_INPUT hosts, and which
11615 runs afoul of improving memory_full behavior. (Bug#8761)
11616 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
11617 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
11618 xfree instead of the default malloc, realloc, free.
11619 (Fgnutls_boot): No need to check for memory allocation failure,
11620 since xmalloc does that for us.
11621
ac32cd99 11622 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
11623 * category.c (hash_get_category_set):
11624 * ccl.c (ccl_driver):
11625 * charset.c (Fdefine_charset_internal):
11626 * charset.h (struct charset.hash_index):
11627 * composite.c (get_composition_id, gstring_lookup_cache)
11628 (composition_gstring_put_cache):
11629 * composite.h (struct composition.hash_index):
11630 * dispextern.h (struct image.hash):
11631 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
11632 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
11633 (hashfn_equal, hashfn_user_defined, make_hash_table)
11634 (maybe_resize_hash_table, hash_lookup, hash_put)
11635 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
11636 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
11637 (Fsxhash, Fgethash, Fputhash, Fmaphash):
11638 * image.c (make_image, search_image_cache, lookup_image)
11639 (xpm_put_color_table_h):
11640 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 11641 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 11642 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 11643 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
11644 * alloc.c (allocate_vectorlike):
11645 Check for overflow in vector size calculations.
11646 * ccl.c (ccl_driver):
11647 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
11648 * fns.c, image.c: Remove unnecessary static decls that would otherwise
11649 need to be updated by these changes.
40087514
PE
11650 * fns.c (make_hash_table, maybe_resize_hash_table):
11651 Check for integer overflow with large hash tables.
0de4bb68
PE
11652 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
11653 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
11654 (SXHASH_REDUCE): New macro.
11655 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
11656 Use it instead of discarding useful hash info with large hash values.
11657 (sxhash_float): New function.
11658 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
11659 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
11660 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
11661 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
11662 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
11663 Adjust signatures to match updated version of code.
11664 (consing_since_gc): Now EMACS_INT, since a single hash table can
11665 use more than INT_MAX bytes.
11666
698d32e2
DN
116672011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
11668
11669 Make it possible to build with GCC-4.6+ -O2 -flto.
11670
11671 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
11672
fd6fa53f
SM
116732011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
11674
11675 * minibuf.c (get_minibuffer, read_minibuf_unwind):
11676 Call minibuffer-inactive-mode.
11677
864db017
JB
116782011-05-31 Juanma Barranquero <lekktu@gmail.com>
11679
11680 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
11681 Update dependencies.
11682
2ad0baf4
DN
116832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11684
11685 * data.c (init_data): Remove code for UTS, this system is not
11686 supported anymore.
11687
4fcc2638
DN
116882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11689
11690 Don't force ./temacs to start in terminal mode.
11691
11692 * frame.c (make_initial_frame): Initialize faces in all cases, not
11693 only when CANNOT_DUMP is defined.
11694 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
11695
c56e0fd5
DN
116962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11697
11698 * dispnew.c (add_window_display_history): Use const for the string
11699 pointer. Remove declaration, not needed.
11700
333d54da 117012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 11702
55d4c1b2 11703 Use 'inline', not 'INLINE'.
333d54da 11704 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
11705 * alloc.c, fontset.c (INLINE): Remove.
11706 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
11707 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
11708 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
11709 * gmalloc.c (register_heapinfo): Use inline unconditionally.
11710 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
11711
738db178
DN
117122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
11713
11714 Make it possible to run ./temacs.
11715
11716 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
11717 syms_of_callproc does the same thing. Remove test for
11718 "initialized", do it in the caller.
11719 * emacs.c (main): Avoid calling set_initial_environment when dumping.
11720
620c53a6
SM
117212011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
11722
11723 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
11724 (read_minibuf): Use get_minibuffer.
11725 (syms_of_minibuf): Use DEFSYM.
11726 (Qmetadata): New var.
11727 * data.c (Qbuffer): Don't make it static.
11728 (syms_of_data): Use DEFSYM.
11729
e003a292
PE
117302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
11731
11732 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
11733 (CCL_CODE_MIN): New macro.
11734
ed008a6d
PE
117352011-05-30 Paul Eggert <eggert@cs.ucla.edu>
11736
3687c2ef
PE
11737 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
11738
ed008a6d
PE
11739 * eval.c (Qdebug): Now static.
11740 * lisp.h (Qdebug): Remove decl. This reverts a part of the
11741 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
11742 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
11743
d66c4c7c
CY
117442011-05-29 Chong Yidong <cyd@stupidchicken.com>
11745
11746 * image.c: Various fixes to ImageMagick code comments.
11747 (Fimagemagick_types): Doc fix.
11748
5fbc2025
PE
117492011-05-29 Paul Eggert <eggert@cs.ucla.edu>
11750
0196f88a
PE
11751 Minor fixes prompted by GCC 4.6.0 warnings.
11752
11753 * xselect.c (converted_selections, conversion_fail_tag): Now static.
11754
5fbc2025
PE
11755 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
11756 (x_clipboard_manager_save_all): Move extern decl to ...
11757 * xterm.h: ... here, so that it can be checked for consistency.
11758
1dd3c2d9
CY
117592011-05-29 Chong Yidong <cyd@stupidchicken.com>
11760
11761 * xselect.c (x_clipboard_manager_save_frame)
11762 (x_clipboard_manager_save_all): New functions.
11763 (Fx_clipboard_manager_save): Lisp function deleted.
11764
11765 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
11766 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
11767
11768 * xterm.h: Update prototype.
11769
5ba6571d
WX
117702011-05-28 William Xu <william.xwl@gmail.com>
11771
11772 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
11773 exiting (Bug#8239).
11774
3eaff834
JM
117752011-05-28 Jim Meyering <meyering@redhat.com>
11776
e1900994 11777 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
11778 * fns.c (to_uchar): Define.
11779 (crypto_hash_function): Use it to convert some newly-signed
11780 variables to unsigned, to avoid sign-extension bugs. For example,
11781 without this change, (md5 "truc") would evaluate to
11782 45723a2aff78ff4fff7fff1114760e62 rather than the expected
11783 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 11784 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 11785
0f6990a7
PE
117862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11787
11788 Integer overflow fixes.
c8a9ca5a 11789
08686060
PE
11790 * dbusbind.c: Serial number integer overflow fixes.
11791 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11792 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11793 to hold a serial number that is too large for a fixnum.
11794 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11795 Check for serial numbers out of range. Decode any serial number
59568bf0 11796 that was so large that it became a float. (Bug#8722)
08686060 11797
2d1fc3c7
PE
11798 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11799 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11800 Use XFASTINT rather than XUINT when numbers are nonnegative.
11801 (xd_append_arg, Fdbus_method_return_internal):
11802 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11803 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11804 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11805 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11806 (Bug#8722)
2d1fc3c7 11807
c8a9ca5a
PE
11808 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11809
519e1d69
PE
11810 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11811
6df6ae42 11812 ccl: Add integer overflow checks.
30569699
PE
11813 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11814 (IN_INT_RANGE): New macros.
11815 (ccl_driver): Use them to check for integer overflow when
11816 decoding a CCL program. Many of the new checks are whether XINT (x)
11817 fits in int; it doesn't always, on 64-bit hosts. The new version
11818 doesn't catch all possible integer overflows, but it's an
847044ea 11819 improvement. (Bug#8719)
30569699 11820
c11285dc
PE
11821 * alloc.c (make_event_array): Use XINT, not XUINT.
11822 There's no need for unsigned here.
11823
fdccd48e
PE
11824 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11825 This follows up to the 2011-05-06 change that substituted uintptr_t
11826 for EMACS_INT. This case wasn't caught back then.
11827
37910ab2
PE
11828 Rework Fformat to avoid integer overflow issues.
11829 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11830 now (part of C89). Include <verify.h>.
11831 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11832 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11833 (Fformat): Avoid the prepass trying to compute sizes; it was only
11834 approximate and thus did not catch overflow reliably. Instead, walk
11835 through the format just once, formatting and computing sizes as we go,
11836 checking for integer overflow at every step, and allocating a larger
11837 buffer as needed. Keep track separately whether the format is
11838 multibyte. Keep only the most-recently calculated precision, rather
11839 than them all. Record whether each argument has been converted to
11840 string. Use EMACS_INT, not int, for byte and char and arg counts.
11841 Support field widths and precisions larger than INT_MAX. Avoid
11842 sprintf's undefined behavior with conversion specifications such as %#d
11843 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11844 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11845 formatting out-of-range floating point numbers with int
9173deec 11846 formats. (Bug#8668)
37910ab2 11847
2e6578fb
PE
11848 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11849
0ae6bdee
PE
11850 * data.c: Avoid integer truncation in expressions involving floats.
11851 * data.c: Include <intprops.h>.
11852 (arith_driver): When there's an integer overflow in an expression
11853 involving floating point, convert the integers to floating point
11854 so that the resulting value does not suffer from catastrophic
11855 integer truncation. For example, on a 64-bit host (* 4
11856 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11857 Do not rely on undefined behavior after integer overflow.
11858
de883a70
PE
11859 merge count_size_as_multibyte, parse_str_to_multibyte
11860 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11861 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11862 Check for integer overflow.
11863 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11864 since it's now a duplicate of the other. This is more of
11865 a character than a buffer op, so better that it's in character.c.
11866 * fns.c, print.c: Adjust to above changes.
11867
2ff916cb
PE
118682011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11869
11870 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11871
f1b54466
PE
118722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11873
fb1ac845
PE
11874 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11875 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11876 (x_clipboard_manager_save): Now static.
11877 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11878
f1b54466
PE
11879 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11880 (crypto_hash_function): Now static.
11881 Fix pointer signedness problems. Avoid unnecessary initializations.
11882
a9f737ee
CY
118832011-05-27 Chong Yidong <cyd@stupidchicken.com>
11884
11885 * termhooks.h (Vselection_alist): Make it terminal-local.
11886
11887 * terminal.c (create_terminal): Initialize it.
11888
11889 * xselect.c: Support for clipboard managers.
11890 (Vselection_alist): Move to termhooks.h as terminal-local var.
11891 (LOCAL_SELECTION): New macro.
11892 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11893 (symbol_to_x_atom): Remove gratuitous arg.
11894 (x_handle_selection_request, lisp_data_to_selection_data)
11895 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11896 (x_own_selection, x_get_local_selection, x_convert_selection):
11897 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11898 (some_frame_on_display): Delete unused function.
11899 (Fx_own_selection_internal, Fx_get_selection_internal)
11900 (Fx_disown_selection_internal, Fx_selection_owner_p)
11901 (Fx_selection_exists_p): New optional frame arg.
11902 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11903 (x_handle_selection_clear): Don't treat other terminals with the
11904 same keyboard specially. Use the terminal-local Vselection_alist.
11905 (x_clear_frame_selections): Use Frun_hook_with_args.
11906
11907 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11908
11909 * xterm.h: Add support for those atoms.
11910
e067f0c1
CY
119112011-05-26 Chong Yidong <cyd@stupidchicken.com>
11912
11913 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11914 (converted_selections, conversion_fail_tag): New global variables.
11915 (x_selection_request_lisp_error): Free the above.
11916 (x_get_local_selection): Remove unnecessary code.
11917 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11918 of converted selections stored in converted_selections.
11919 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11920 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11921 (x_convert_selection): New function.
11922 (x_handle_selection_event): Simplify.
11923 (x_get_foreign_selection): Don't ignore incoming requests while
11924 waiting for an answer; this will fail when we implement
11925 SAVE_TARGETS, and seems unnecessary anyway.
11926 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11927 (Vx_sent_selection_functions): Doc fix.
11928
0f4aebc0
LL
119292011-05-26 Leo Liu <sdl.web@gmail.com>
11930
11931 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11932
e61124cd
YM
119332011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11934
11935 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11936
11937 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11938 for fringe update if it has periodic bitmap.
ac389d0c 11939 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11940 and fringe_bitmap_periodic_p.
11941
11942 * fringe.c (get_fringe_bitmap_data): New function.
11943 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11944 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11945 row. Mark glyph row for fringe update if periodicity changed.
11946
11947 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11948 for fringe update unless it has periodic bitmap.
11949
f16d9837
KH
119502011-05-25 Kenichi Handa <handa@m17n.org>
11951
11952 * xdisp.c (get_next_display_element): Set correct it->face_id for
11953 a static composition.
11954
e1b90ef6
LL
119552011-05-24 Leo Liu <sdl.web@gmail.com>
11956
11957 * deps.mk (fns.o):
11958 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11959
11960 * fns.c (crypto_hash_function, Fsha1): New function.
11961 (Fmd5): Use crypto_hash_function.
11962 (syms_of_fns): Add Ssha1.
11963
7400048f
PE
119642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11965
11966 * gnutls.c: Remove unused macros.
11967 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11968 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11969 Remove macros that are defined and never used.
11970 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11971
abb71cf4
CY
119722011-05-22 Chong Yidong <cyd@stupidchicken.com>
11973
11974 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11975 (Fx_get_selection_internal): Minor cleanup.
11976 (Fx_own_selection_internal): Rename arguments for consistency with
11977 select.el.
11978
6307db39
PE
119792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11980
11981 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11982
f3d4e0a4
CY
119832011-05-22 Chong Yidong <cyd@stupidchicken.com>
11984
11985 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11986
4d8ade89
YM
119872011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11988
11989 * dispnew.c (scrolling_window): Don't exclude the case that the
11990 last enabled row in the desired matrix touches the bottom boundary.
11991
32078c8d
GM
119922011-05-21 Glenn Morris <rgm@gnu.org>
11993
11994 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11995 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11996 and add some more files.
32078c8d 11997
7285dc67
EZ
119982011-05-20 Eli Zaretskii <eliz@gnu.org>
11999
12000 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
12001 report_file_error introduced by the change from 2011-05-07.
12002
89d1bd22
PE
120032011-05-20 Paul Eggert <eggert@cs.ucla.edu>
12004
12005 * systime.h (Time): Define only if emacs is defined.
12006 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
12007 where the include path doesn't have X11/X.h by default. See
12008 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
12009
cd394be1 120102011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
12011
12012 * composite.c (find_automatic_composition): Fix previous change.
12013
b9704ad9
GM
120142011-05-20 Glenn Morris <rgm@gnu.org>
12015
12016 * lisp.mk: New file, split from Makefile.in.
12017 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
12018 (shortlisp): Remove.
12019 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
12020
4a720484
GM
120212011-05-19 Glenn Morris <rgm@gnu.org>
12022
12023 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
12024 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
12025 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
12026 (lisp): Set the order to that of loadup.el.
12027 (shortlisp): Make it a copy of $lisp.
12028 (SOME_MACHINE_LISP): Remove.
12029 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
12030 Use just $shortlisp, not $SOME_MACHINE_LISP too.
12031
a28d4396
KH
120322011-05-18 Kenichi Handa <handa@m17n.org>
12033
12034 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
12035 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
12036 (find_automatic_composition): Mostly rewrite for efficiency.
12037
a2b1fa8e
JB
120382011-05-18 Juanma Barranquero <lekktu@gmail.com>
12039
12040 * makefile.w32-in: Update dependencies.
12041
8e1f5610
CS
120422011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
12043
12044 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 12045 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 12046
7025ee00 120472011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 12048
cdfa6eab
PE
12049 Fix some integer overflow issues, such as string length overflow.
12050
06d6db33
PE
12051 * insdel.c (count_size_as_multibyte): Check for string overflow.
12052
2b4560a8
PE
12053 * character.c (lisp_string_width): Check for string overflow.
12054 Use EMACS_INT, not int, for string indexes and lengths; in
12055 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
12056 the resulting string length overflows an EMACS_INT; instead,
12057 report a string overflow if no precision given. When checking for
12058 precision exhaustion, use a check that cannot possibly have
12059 integer overflow. (Bug#8675)
12060 * character.h (lisp_string_width): Adjust to new signature.
12061
cb93f9be
PE
12062 * alloc.c (string_overflow): New function.
12063 (Fmake_string): Use it. This doesn't change behavior, but saves
12064 a few bytes and will simplify future changes.
12065 * character.c (string_escape_byte8): Likewise.
12066 * lisp.h (string_overflow): New decl.
12067
1a1f3366
PE
12068 Fixups, following up to the user-interface timestamp change.
12069 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
12070 for UI timestamps, instead of unsigned long.
9fbd6841
PE
12071 * msdos.c (mouse_get_pos): Likewise.
12072 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
12073 * w32gui.h (Time): Define by including "systime.h" rather than by
12074 declaring it ourselves. (Bug#8664)
12075
d4e3e4d3
PE
12076 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
12077 * image.c (clear_image_cache): Likewise.
12078
f6a24d19
PE
12079 * term.c (term_mouse_position): Don't assume time_t wraparound.
12080
08dc5ae6
PE
12081 Be more systematic about user-interface timestamps.
12082 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
12083 and sometimes 'EMACS_UINT', to represent these timestamps.
12084 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
12085 This makes the code easier to follow, and makes it easier to catch
12086 integer overflow bugs such as Bug#8664.
12087 * frame.c (Fmouse_position, Fmouse_pixel_position):
12088 Use Time, not unsigned long, for user-interface timestamps.
12089 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
12090 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
12091 * keyboard.h (last_event_timestamp): Likewise.
12092 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
12093 * menu.h (xmenu_show): Likewise.
12094 * term.c (term_mouse_position): Likewise.
12095 * termhooks.h (struct input_event.timestamp): Likewise.
12096 (struct terminal.mouse_position_hook): Likewise.
12097 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
12098 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
12099 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
12100 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
12101 what it was before.
12102 * menu.h, termhooks.h: Include "systime.h", for Time.
12103
8e55734a
PE
12104 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
12105 Don't assume that the difference between two unsigned long values
12106 can fit into an integer. At this point, we know button_down_time
12107 <= event->timestamp, so the difference must be nonnegative, so
12108 there's no need to cast the result if double-click-time is
12109 nonnegative, as it should be; check that it's nonnegative, just in
12110 case. This bug is triggered when events are more than 2**31 ms
86db42d2 12111 apart (about 25 days). (Bug#8664)
8e55734a 12112
841f1b75 12113 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 12114 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 12115
3e26f69c
PE
12116 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
12117 that always fit in int. Use a sentinel instead of a counter, to
12118 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
12119 * frame.h (struct frame): Use int for menu_bar_items_used
12120 instead of EMACS_INT, since it always fits in int.
3e26f69c 12121
5cc152c0
PE
12122 * menu.c (grow_menu_items): Check for int overflow.
12123
d89eb65e
PE
12124 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
12125
5235bd3e
PE
12126 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
12127 Before, the code was not consistent. These values cannot exceed
12128 2**31 - 1 so there's no need to make them unsigned.
12129 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
12130 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
12131 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
12132 as modifiers.
12133 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
12134
bc827e23
PE
12135 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
12136 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
12137 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
12138 presumably because the widths might not match.
12139
78eb494e
PE
12140 * window.c (size_window): Avoid needless test at loop start.
12141
04f2d78b
CB
121422011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
12143
12144 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
12145
d2fc7e3d 121462011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
12147
12148 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
12149
d2fc7e3d 121502011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
12151
12152 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
12153 `width' to `bar_area_x' and `bar_area_width', respectively.
12154 (x_scroll_run): Take account of fringe background extension.
12155
04f2d78b
CB
12156 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
12157 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
12158 `bar_area_width', respectively.
12159 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
12160 background extension.
12161
79b70037
GM
121622011-05-10 Jim Meyering <meyering@redhat.com>
12163
12164 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
12165
2f142cc5
JB
121662011-05-10 Juanma Barranquero <lekktu@gmail.com>
12167
12168 * image.c (Finit_image_library): Return t for built-in image types,
12169 like pbm and xbm. (Bug#8640)
12170
57679c86
AS
121712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
12172
12173 * w32menu.c (set_frame_menubar): Fix submenu allocation.
12174
888c9e86
EZ
121752011-05-07 Eli Zaretskii <eliz@gnu.org>
12176
b0512a1d
EZ
12177 * w32console.c (Fset_screen_color): Doc fix.
12178 (Fget_screen_color): New function.
12179 (syms_of_ntterm): Defsubr it.
12180
7285dc67
EZ
12181 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
12182 unlink the temporary file if Fcall_process didn't create it in the
12183 first place.
12184 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
12185 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
12186 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
12187 cue to call_process_cleanup not to close that handle.
12188
4d3fcc8e
BK
121892011-05-07 Ben Key <bkey76@gmail.com>
12190
12191 * makefile.w32-in: The bootstrap-temacs rule now makes use of
12192 one of two shell specific rules, either bootstrap-temacs-CMD or
12193 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
12194 to the previous implementation of the bootstrap-temacs rule.
12195 The bootstrap-temacs-CMD rule is similar to the previous
12196 implementation of the bootstrap-temacs rule except that it
12197 makes use of the ESC_CFLAGS variable instead of the CFLAGS
12198 variable.
12199
12200 These changes, along with some changes to nt/configure.bat,
12201 nt/gmake.defs, and nt/nmake.defs, are required to extend my
12202 earlier fix to add support for --cflags and --ldflags options
12203 that include quotes so that it works whether make uses cmd or
12204 sh as the shell.
12205
b4289b64
MA
122062011-05-06 Michael Albinus <michael.albinus@gmx.de>
12207
12208 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
12209 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
12210 is a constant.
12211 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
12212 a string. Handle both cases.
12213 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
12214 (Fdbus_register_method): Use Qinvalid_function.
12215
af4c0e28
JB
122162011-05-06 Juanma Barranquero <lekktu@gmail.com>
12217
12218 * makefile.w32-in: Update dependencies.
12219 (LISP_H): Add inttypes.h and stdin.h.
12220 (PROCESS_H): Add unistd.h.
12221
c51453d9
EZ
122222011-05-06 Eli Zaretskii <eliz@gnu.org>
12223
12224 * lread.c: Include limits.h (fixes the MS-Windows build broken by
12225 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
12226
8ff0ac3c 122272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 12228
4c4b566b
PE
12229 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
12230
aab2b9b5
PE
12231 * term.c (vfatal): Remove stray call to va_end.
12232 It's not needed and the C Standard doesn't allow it here anyway.
12233
c378da0b
PE
12234 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
12235 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
12236
288b08c7
PE
12237 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
12238 bytes.
12239
e3601888
PE
12240 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
12241
db6c0e74
PE
12242 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
12243
dd5963ea
PE
12244 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
12245
88c9450f
PE
12246 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
12247
2f9442b8
PE
12248 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
12249
c032b5f8
PE
12250 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
12251 * charset.c (Fdefine_charset_internal): Don't initialize
12252 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 12253 32-bit int (Bug#8600).
a108c10b
PE
12254
12255 * lread.c (read_integer): Be more consistent with string-to-number.
12256 Use string_to_number to do the actual conversion; this avoids
12257 rounding errors and fixes some other screwups. Without this fix,
12258 for example, #x1fffffffffffffff was misread as -2305843009213693952.
12259 (digit_to_number): Move earlier, for benefit of read_integer.
12260 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 12261 not a digit in any supported base. (Bug#8602)
a108c10b 12262
ad5f9eea
PE
12263 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
12264
aec1708a
PE
12265 * dispnew.c (scrolling_window): Return 1 if we scrolled,
12266 to match comment at start of function. This also removes a
12267 GCC warning about overflow in a 32+64-bit port.
12268
47be4ab5
PE
12269 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
12270
371cac43
PE
12271 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
12272 Reported by Stefan Monnier in
12273 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
12274 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12275 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 12276
d01a7826
PE
12277 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
12278 (EMACS_UINTPTR): Likewise, with uintptr_t.
12279
7fd47d5c
PE
12280 * lisp.h: Prefer 64-bit EMACS_INT if available.
12281 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
12282 on 32-bit hosts that have 64-bit int, so that they can access
12283 large files.
122b0c86
PE
12284 However, temporarily disable this change unless the temporary
12285 symbol WIDE_EMACS_INT is defined.
7fd47d5c 12286
8727937b
PE
12287 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
12288
8ac068ac
PE
12289 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
12290 This removes an assumption that EMACS_INT and long are the same
12291 width as pointers. The assumption is true for Emacs porting targets
12292 now, but we want to make other targets possible.
12293 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
12294 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
12295 In the rest of the code, change types of integers that hold casted
12296 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
12297 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
12298 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
12299 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
12300 No need to cast type when ORing.
12301 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
12302 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
12303 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
12304 assume EMACS_INT is the same width as char *.
12305 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
12306 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
12307 Remove no-longer-needed casts.
12308 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
12309 (xg_tool_bar_help_callback, xg_make_tool_item):
12310 Use EMACS_INTPTR to hold an integer
12311 that will be cast to void *; this can avoid a GCC warning
12312 if EMACS_INT is not the same width as void *.
12313 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
12314 * xdisp.c (display_echo_area_1, resize_mini_window_1):
12315 (current_message_1, set_message_1):
12316 Use a local to convert to proper width without a cast.
12317 * xmenu.c (dialog_selection_callback): Likewise.
12318
ede49d71
PE
12319 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
12320 Also, don't assume VALBITS / RAND_BITS is less than 5,
12321 and don't rely on undefined behavior when shifting a 1 left into
12322 the sign bit.
12323 * lisp.h (get_random): Change signature to match.
12324
2f30ecd0
PE
12325 * lread.c (hash_string): Use size_t, not int, for hash computation.
12326 Normally we prefer signed values; but hashing is special, because
12327 it's better to use unsigned division on hash table sizes so that
12328 the remainder is nonnegative. Also, size_t is the natural width
12329 for hashing into memory. The previous code used 'int', which doesn't
12330 retain enough info to hash well into very large tables.
12331 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
12332
2a866e7b
PE
12333 * dbusbind.c: Don't possibly lose pointer info when converting.
12334 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
12335 Use XPNTR rather than XHASH, so that the high-order bits of
12336 the pointer aren't lost when converting through void *.
12337
51639eac
PE
12338 * eval.c (Fautoload): Don't double-shift a pointer.
12339
92394119
PE
12340 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
12341
dbdb9a7c
JB
123422011-05-06 Juanma Barranquero <lekktu@gmail.com>
12343
12344 * gnutls.c (DEF_GNUTLS_FN):
12345 * image.c (DEF_IMGLIB_FN): Make function pointers static.
12346
db7a0b4f
AS
123472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
12348
12349 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
12350 marker. (Bug#8610)
12351
cd394be1 123522011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
12353
12354 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
12355 New version that can reserve upto 2GB of heap space.
12356
f7ff1b0f 123572011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
12358
12359 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
12360
639c109b
TZ
123612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
12362
12363 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
12364 `gnutls_certificate_set_x509_key_file'.
12365
d2127135
JB
123662011-05-05 Juanma Barranquero <lekktu@gmail.com>
12367
12368 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
12369 Update dependencies.
12370
e968f4f3
JB
123712011-05-04 Juanma Barranquero <lekktu@gmail.com>
12372
12373 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
12374 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
12375 Remove unused parameter `fildes'.
12376 * process.c (read_process_output, send_process): Don't pass it.
12377
84d358f0
JB
123782011-05-04 Juanma Barranquero <lekktu@gmail.com>
12379
12380 Fix previous change: the library cache is defined in w32.c.
12381 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
12382 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
12383
0898ca10
JB
123842011-05-04 Juanma Barranquero <lekktu@gmail.com>
12385
12386 Implement dynamic loading of GnuTLS on Windows.
12387
12388 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
12389 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
12390 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12391 Declare.
12392
12393 * gnutls.c (Qgnutls_dll): Define.
12394 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
12395 (gnutls_*): Declare function pointers.
12396 (init_gnutls_functions): New function to initialize function pointers.
12397 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
12398 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
12399 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
12400 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
12401 (emacs_gnutls_write, emacs_gnutls_read)
12402 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
12403 (Fgnutls_available_p): New function.
12404 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
12405 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
12406 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
12407
12408 * image.c: Include w32.h.
12409 (Vimage_type_cache): Delete.
12410 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
12411 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
12412 (w32_delayed_load): Move to w32.c.
12413
12414 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
12415
12416 * w32.c (QCloaded_from, Vlibrary_cache): Define.
12417 (w32_delayed_load): Move from image.c. When loading a library, record
12418 its filename in the :loaded-from property of the library id.
12419 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
12420 Initialize and staticpro them.
12421 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
12422
12423 * process.c: Include lisp.h before w32.h, not after.
12424 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
12425 instead of gnutls_record_check_pending.
12426
12427 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
12428
ff4de4aa
TZ
124292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
12430
12431 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
12432 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
12433 as passed in.
12434
abe95abb
JD
124352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
12436
12437 * xterm.c (x_set_frame_alpha): Do not set property on anything
12438 else than FRAME_X_OUTER_WINDOW (Bug#8608).
12439
e16e55d4
JB
124402011-05-02 Juanma Barranquero <lekktu@gmail.com>
12441
12442 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
12443
bafcf6a5
JB
124442011-05-02 Juanma Barranquero <lekktu@gmail.com>
12445
12446 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
12447 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
12448 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
12449 (gnutls_global_initialized, Qgnutls_bootprop_priority)
12450 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
12451 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
12452 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
12453 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
12454 (Qgnutls_bootprop_callbacks_verify): Make static.
12455
e7a6747f
AS
124562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
12457
19ed11ba
AS
12458 * callproc.c: Indentation fixup.
12459
e7a6747f 12460 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
12461 (wait_for_termination, interruptible_wait_for_termination):
12462 Move after wait_for_termination_1.
e7a6747f 12463
1ef14cb4
LMI
124642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
12465
12466 * sysdep.c (interruptible_wait_for_termination): New function
12467 which is like wait_for_termination, but allows keyboard
12468 interruptions.
12469
12470 * callproc.c (Fcall_process): Add (:file "file") as an option for
12471 the STDOUT buffer.
12472 (Fcall_process_region): Ditto.
12473
330d880c
EZ
124742011-04-30 Eli Zaretskii <eliz@gnu.org>
12475
8db90b73
EZ
12476 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
12477 rather than `XVECTOR (FOO)->size'.
12478
330d880c
EZ
12479 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
12480 inttypes.h, as a gnulib replacement is used if it not available in
12481 system headers.
12482
15cbd324
EZ
124832011-04-21 Eli Zaretskii <eliz@gnu.org>
12484
12485 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
12486 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
12487 of MOST_POSITIVE_FIXNUM. (Bug#8528)
12488
12489 * coding.c (coding_alloc_by_realloc): Error out if destination
12490 will grow beyond MOST_POSITIVE_FIXNUM.
12491 (decode_coding_emacs_mule): Abort if there isn't enough place in
12492 charbuf for the composition carryover bytes. Reserve an extra
12493 space for up to 2 characters produced in a loop.
12494 (decode_coding_iso_2022): Abort if there isn't enough place in
12495 charbuf for the composition carryover bytes.
12496
124972011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 12498
ae940cca
EZ
12499 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
12500 aborting when %lld or %lll format is passed.
12501 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
12502 %llo or %llx format is passed. (Bug#8545)
12503
03ab8921
EZ
12504 * window.c (window_scroll_line_based): Use a marker instead of
12505 simple variables to record original value of point. (Bug#7952)
12506
afda1437
EZ
12507 * doprnt.c (doprnt): Fix the case where a multibyte sequence
12508 produced by %s or %c overflows available buffer space. (Bug#8545)
12509
f76dee0c
PE
125102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
12511
12512 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 12513 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 12514
fdc5744d
JB
125152011-04-28 Juanma Barranquero <lekktu@gmail.com>
12516
12517 * w32.c (init_environment): Warn about defaulting HOME to C:\.
12518
638f053a
JB
125192011-04-28 Juanma Barranquero <lekktu@gmail.com>
12520
12521 * keyboard.c (Qdelayed_warnings_hook): Define.
12522 (command_loop_1): Run `delayed-warnings-hook'
12523 if Vdelayed_warnings_list is non-nil.
12524 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
12525 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
12526
d178f871
EZ
125272011-04-28 Eli Zaretskii <eliz@gnu.org>
12528
12529 * doprnt.c (doprnt): Don't return value smaller than the buffer
12530 size if the message was truncated. (Bug#8545).
12531
b124fd93
JB
125322011-04-28 Juanma Barranquero <lekktu@gmail.com>
12533
12534 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
12535 (Fx_window_property): #if-0 the whole functions, not just the bodies.
12536
e810457d
PE
125372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12538
12539 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
12540
ea51cceb
JB
125412011-04-27 Juanma Barranquero <lekktu@gmail.com>
12542
12543 * makefile.w32-in: Update dependencies.
12544
94dcfacf
EZ
125452011-04-27 Eli Zaretskii <eliz@gnu.org>
12546
12547 Improve `doprnt' and its usage. (Bug#8545)
12548 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
12549 `format_end'. Remove support for %l as a conversion specifier.
12550 Don't use xrealloc. Improve diagnostics when the %l size modifier
12551 is used. Update the commentary.
12552
12553 * eval.c (verror): Simplify calculation of size_t.
12554
12555 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
12556 messages.
12557
f61f41d7
PE
125582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
12559
12560 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
12561 change.
12562
96fb4434
PE
125632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
12564
12565 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
12566 This makes this file independent of the recent pseudovector change.
12567
671875da 125682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 12569
69e9b5a3
PE
12570 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
12571
b5f869a7 12572 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 12573 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 12574 Remove unused local.
c8926152 12575 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 12576
841a1577 12577 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
12578 GCC 4.6.0 optimizes based on type-based alias analysis.
12579 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
12580 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
12581 != &v->size, and therefore "v->size = 1; b->size = 2; return
12582 v->size;" must therefore return 1. This assumption is incorrect
12583 for Emacs, since it type-puns struct Lisp_Vector * with many other
12584 types. To fix this problem, this patch adds a new type struct
f904488f 12585 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
12586 and pseudovectors, and helps optimizing compilers not get fooled
12587 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
12588 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
12589 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
12590 the size member.
eab3844f
PE
12591 (XSETPVECTYPE): Rewrite in terms of new macro.
12592 (XSETPVECTYPESIZE): New macro, specifying both type and size.
12593 This is a bit clearer, and further avoids the possibility of
12594 undesirable aliasing.
12595 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 12596 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
12597 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
12598 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
12599 (ASIZE): Now uses header.size rather than size.
12600 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
12601 to avoid the hassle of writing XVECTOR (foo)->header.size.
12602 (struct vectorlike_header): New type.
eab3844f
PE
12603 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
12604 object, to help avoid aliasing.
12605 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
12606 (SUBRP): Likewise, since Lisp_Subr is a special case.
12607 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
12608 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
12609 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 12610 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
12611 changed to be "header.size" and "header.next".
12612 * buffer.h (struct buffer): Likewise.
12613 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
12614 * frame.h (struct frame): Likewise.
12615 * process.h (struct Lisp_Process): Likewise.
12616 * termhooks.h (struct terminal): Likewise.
12617 * window.c (struct save_window_data, struct saved_window): Likewise.
12618 * window.h (struct window): Likewise.
12619 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
12620 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
12621 * buffer.c (init_buffer_once): Likewise.
12622 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
12623 special case.
12624 * process.c (Fformat_network_address): Use local var for size,
12625 for brevity.
12626
0df1eac5
PE
12627 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
12628
847ab9d1 12629 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
12630 * data.c (atof): Remove decl; no longer used or needed.
12631 (digit_to_number): Move to lread.c.
12632 (Fstring_to_number): Use new string_to_number function, to be
12633 consistent with how the Lisp reader treats infinities and NaNs.
12634 Do not assume that floating-point numbers represent EMACS_INT
12635 without losing information; this is not true on most 64-bit hosts.
12636 Avoid double-rounding errors, by insisting on integers when
12637 parsing non-base-10 numbers, as the documentation specifies.
12638 * lisp.h (string_to_number): New decl, replacing ...
12639 (isfloat_string): Remove.
bc0a5c13 12640 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 12641 (read1): Do not accept +. and -. as integers; this
452f4150
PE
12642 appears to have been a coding error. Similarly, do not accept
12643 strings like +-1e0 as floating point numbers. Do not report
12644 overflow for integer overflows unless the base is not 10 which
12645 means we have no simple and reliable way to continue.
12646 Break out the floating-point parsing into a new
12647 function string_to_number, so that Fstring_to_number parses
12648 floating point numbers consistently with the Lisp reader.
04f2d78b 12649 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
12650 (E_CHAR, EXP_INT): Remove, replacing with ...
12651 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
12652 (string_to_number): New function, replacing isfloat_string.
12653 This function checks for valid syntax and produces the resulting
12654 Lisp float number too. Rework it so that string-to-number
bc0a5c13 12655 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
12656 so that overflow for non-base-10 numbers is reported only when
12657 there's no portable and simple way to convert to floating point.
452f4150 12658
67769ffc
PE
12659 * textprop.c (set_text_properties_1): Rewrite for clarity,
12660 and to avoid GCC warning about integer overflow.
12661
c20db43f
PE
12662 * intervals.h (struct interval): Use EMACS_INT for members
12663 where EMACS_UINT might cause problems. See
12664 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
12665 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
12666 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
12667 All uses changed.
37aa2f85
PE
12668 (offset_intervals): Tell GCC not to worry about length overflow
12669 when negating a negative length.
c20db43f 12670
2538aa2f
PE
12671 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
12672 (overrun_check_free): Likewise.
12673
f2d3008d
PE
12674 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
12675 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
12676 word size.
12677
ec8df744
PE
12678 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12679 (gnutls_make_error): Rename local to avoid shadowing.
12680 (gnutls_emacs_global_deinit): ifdef out; not used.
12681 (Fgnutls_boot): Use const for pointer to readonly storage.
12682 Comment out unused local. Fix pointer signedness problems.
12683
640ee02d
PE
12684 * lread.c (openp): Don't stuff size_t into an 'int'.
12685 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
12686 about possible signed overflow.
12687
6048fb2a
PE
12688 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
12689 (GDK_KEY_g): Don't define if already defined.
12690 (xg_prepare_tooltip): Avoid pointer signedness problem.
12691 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
12692
fa3c87e1
PE
12693 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
12694 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
12695
2172544b
PE
12696 * xfns.c (Fx_window_property): Simplify a bit,
12697 to make a bit faster and to avoid GCC 4.6.0 warning.
12698 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
12699
9b821a21
PE
12700 * fns.c (internal_equal): Don't assume size_t fits in int.
12701
3c616cfa
PE
12702 * alloc.c (compact_small_strings): Tighten assertion a little.
12703
c2982e87
PE
12704 Replace pEd with more-general pI, and fix some printf arg casts.
12705 * lisp.h (pI): New macro, generalizing old pEd macro to other
12706 conversion specifiers. For example, use "...%"pI"d..." rather
12707 than "...%"pEd"...".
12708 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 12709 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
12710 * alloc.c (check_pure_size): Don't overflow by converting size to int.
12711 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
12712 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
12713 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
12714 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
12715 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
12716 64-bit hosts.
12717 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
12718 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
12719 * print.c (safe_debug_print, print_object): Likewise.
12720 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
12721 to int.
6f04d126
PE
12722 Use pI instead of if-then-else-abort. Use %p to avoid casts,
12723 avoiding the 0 flag, which is not portable.
c2982e87
PE
12724 * process.c (Fmake_network_process): Use pI to avoid cast.
12725 * region-cache.c (pp_cache): Likewise.
12726 * xdisp.c (decode_mode_spec): Likewise.
12727 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
12728 behavior on 64-bit hosts with printf arg.
6f04d126 12729 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
12730 (x_stop_queuing_selection_requests): Likewise.
12731 (x_get_window_property): Don't truncate byte count to an 'int'
12732 when tracing.
0b432f21 12733
5e073ec7
PE
12734 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
12735 here, since it parses constructs like leading '-' and spaces,
12736 which are not wanted; and it overflows with large numbers.
12737 Instead, simply match F[0-9]+, which is what is wanted anyway.
12738
36372bf9
PE
12739 * alloc.c: Remove unportable assumptions about struct layout.
12740 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
12741 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
12742 (allocate_vectorlike, make_pure_vector): Use the new macros,
12743 plus offsetof, to remove unportable assumptions about struct layout.
12744 These assumptions hold on all porting targets that I know of, but
12745 they are not guaranteed, they're easy to remove, and removing them
12746 makes further changes easier.
12747
0b432f21
PE
12748 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
12749 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
12750 (string_overrun_cookie): Now const. Use initializers that
12751 don't formally overflow signed char, to avoid warnings.
000098c1
PE
12752 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
12753 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
12754 (allocate_buffer): Don't assume sizeof (struct buffer) is a
12755 multiple of sizeof (EMACS_INT); it need not be, if
12756 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 12757 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 12758
895009e1
JB
127592011-04-26 Juanma Barranquero <lekktu@gmail.com>
12760
12761 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
12762
6a7a1b0b
TZ
127632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
12764
12765 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 12766 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
12767 Reported by Paul Eggert <eggert@cs.ucla.edu>.
12768
841a1577 127692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
12770
12771 * lisp.h (Qdebug): List symbol.
895009e1 12772 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
12773 * keyboard.c (debug-on-event): New variable.
12774 (handle_user_signal): Break into debugger when debug-on-event
12775 matches the current signal symbol.
12776
f2d3ba6f
DN
127772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
12778
12779 * alloc.c (check_sblock, check_string_bytes)
12780 (check_string_free_list): Convert to standard C.
12781
42ce4c63
TZ
127822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
12783
12784 * w32.c (emacs_gnutls_push): Fix typo.
12785
825cd63c
EZ
127862011-04-25 Eli Zaretskii <eliz@gnu.org>
12787
fb11d64d
EZ
12788 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12789 "cast to pointer from integer of different size".
12790
825cd63c
EZ
12791 Improve doprnt and its use in verror. (Bug#8545)
12792 * doprnt.c (doprnt): Document the set of format control sequences
12793 supported by the function. Use SAFE_ALLOCA instead of always
12794 using `alloca'.
12795
12796 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12797 is one byte too soon. Don't use xrealloc; instead xfree and
12798 xmalloc anew.
12799
e061a11b
TZ
128002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12801
12802 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12803 callbacks stage.
12804
12805 * gnutls.c: Renamed global_initialized to
12806 gnutls_global_initialized. Added internals for the
12807 :verify-hostname-error, :verify-error, and :verify-flags
12808 parameters of `gnutls-boot' and documented those parameters in the
12809 docstring. Start callback support.
9173deec
JB
12810 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12811 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12812 on error. Return error code.
e061a11b
TZ
12813 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12814 (emacs_gnutls_read): Likewise.
12815 (Fgnutls_boot): Return handshake error code.
12816 (emacs_gnutls_handle_error): New function.
12817 (wsaerror_to_errno): Likewise.
12818
12819 * w32.h (emacs_gnutls_pull): Add prototype.
12820 (emacs_gnutls_push): Likewise.
12821
12822 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12823 (emacs_gnutls_push): Likewise.
12824
128252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12826
12827 * process.c (wait_reading_process_output): Check if GnuTLS
12828 buffered some data internally if no FDs are set for TLS
12829 connections.
12830
12831 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12832 (LIBS): Link to USER_LIBS.
12833 ($(BLD)/gnutls.$(0)): New target.
12834
fa6996bc
EZ
128352011-04-24 Eli Zaretskii <eliz@gnu.org>
12836
eb35682e
EZ
12837 * xdisp.c (handle_single_display_spec): Rename the
12838 display_replaced_before_p argument into display_replaced_p, to
12839 make it consistent with the commentary. Fix typos in the
12840 commentary.
12841
e2ad650c
EZ
12842 * textprop.c (syms_of_textprop): Remove dead code.
12843 (copy_text_properties): Delete obsolete commentary about an
12844 interface that was deleted long ago. Fix typos in the description
12845 of arguments.
12846
1b2de274
EZ
12847 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12848 to changes in oldXMenu/XMenu.h from 2011-04-16.
12849 <menu_help_message, prev_menu_help_message>: Constify.
12850 (IT_menu_make_room): menu->help_text is now `const char **';
12851 adjust.
12852
12853 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12854 to changes in oldXMenu/XMenu.h from 2011-04-16.
12855 (struct XMenu): Declare `help_text' `const char **'.
12856
12857 * xfaces.c <Qunspecified>: Make extern again.
12858
12859 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12860 required by POSIX.
1b2de274 12861
762b15be
EZ
12862 * doc.c (get_doc_string): Improve the format passed to `error'.
12863
12864 * doprnt.c (doprnt): Improve commentary.
12865
12866 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12867
12868 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12869 them with etags.
12870
f1052e5d
EZ
12871 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12872 changes in globals.h immediately force recompilation.
762b15be
EZ
12873 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12874 $(CURDIR)/s/ms-w32.h.
12875 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12876
fa6996bc
EZ
12877 * character.c (Fchar_direction): Function deleted.
12878 (syms_of_character): Don't defsubr it.
12879 <char-direction-table>: Deleted.
12880
e6c3da20
EZ
128812011-04-23 Eli Zaretskii <eliz@gnu.org>
12882
12883 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12884 * doprnt.c: Include limits.h.
12885 (SIZE_MAX): New macro.
04f2d78b
CB
12886 (doprnt): Return a size_t value. 2nd arg is now size_t.
12887 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12888 Improve overflow protection. Support `l' modifier for integer
12889 conversions. Support %l conversion. Don't assume an EMACS_INT
12890 argument for integer conversions and for %c.
12891
12892 * lisp.h (doprnt): Restore prototype.
12893
12894 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12895 $(SRC)/character.h.
12896
12897 * Makefile.in (base_obj): Add back doprnt.o.
12898
12899 * deps.mk (doprnt.o): Add back prerequisites.
12900 (callint.o): Depend on character.h.
12901
12902 * eval.c (internal_lisp_condition_case): Include the handler
12903 representation in the error message.
12904 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12905 when breaking from the loop.
12906
12907 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12908
12909 * callint.c (Fcall_interactively): When displaying error message
12910 about invalid control letter, pass the character's codepoint, not
12911 a pointer to its multibyte form. Improve display of the character
12912 in octal and display also its hex code.
12913
12914 * character.c (char_string): Use %x to display the (unsigned)
12915 codepoint of an invalid character, to avoid displaying a bogus
12916 negative value.
12917
12918 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12919 `error', not SYMBOL_NAME itself.
12920
12921 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12922 character arguments to `error'.
12923
12924 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12925 to `error' in error message about FINAL_CHAR argument. Make sure
12926 FINAL_CHAR is a character, and use %c when it is passed as
12927 argument to `error'.
12928
4ffd0d6b 129292011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12930
12931 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12932
12933 * w32.c: Include <time.h>.
12934 (sys_localtime): New function.
12935
4ffd0d6b 129362011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12937
12938 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12939
4ffd0d6b 12940 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12941
4ffd0d6b 129422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12943
4ffd0d6b
GM
12944 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12945 zombies (Bug#8467).
aac0c6e3 12946
04c56954
EZ
129472011-04-19 Eli Zaretskii <eliz@gnu.org>
12948
12949 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12950 gl_state.e_property when gl_state.object is Qt.
12951
12952 * insdel.c (make_gap_larger): Remove limitation of buffer size
12953 to <= INT_MAX.
12954
16a43933
CY
129552011-04-18 Chong Yidong <cyd@stupidchicken.com>
12956
12957 * xdisp.c (lookup_glyphless_char_display)
12958 (produce_glyphless_glyph): Handle cons cell entry in
12959 glyphless-char-display.
12960 (Vglyphless_char_display): Document it.
12961
12962 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12963 glyphless-char-display.
12964
4581706e
CY
129652011-04-17 Chong Yidong <cyd@stupidchicken.com>
12966
12967 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12968
12969 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12970
12971 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12972 definition for no-X builds.
12973
4887c6e2 129742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12975
fd35b6f9
PE
12976 Static checks with GCC 4.6.0 and non-default toolkits.
12977
5c1ccb01
PE
12978 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12979
006c5daa
PE
12980 * process.c (keyboard_bit_set): Define only if SIGIO.
12981 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12982 (send_process): Repair possible setjmp clobbering.
12983
efc736d3
PE
12984 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12985
4e2fe2e6
PE
12986 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12987
f97334a2
PE
12988 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12989
4e75f29d
PE
12990 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12991 Define only if needed.
12992
90efadd1
PE
12993 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12994 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12995 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12996
3c647824
PE
12997 * dispextern.h (struct redisplay_interface): Rename param
12998 to avoid shadowing.
e264f262 12999 * termhooks.h (struct terminal): Likewise.
761383f4 13000 * xterm.c (xembed_send_message): Likewise.
3c647824 13001
b58c5c4a
PE
13002 * insdel.c (make_gap_smaller): Define only if
13003 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
13004
cad59032
PE
13005 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
13006 it.
13007
c339dc2e
PE
13008 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
13009 so that we aren't warned about unused symbols.
13010
91a3e27b
PE
13011 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13012
399c71d3 13013 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 13014
8ffc96f5
PE
13015 * xfns.c (x_real_positions): Mark locals as initialized.
13016
eef9bc79
PE
13017 * xmenu.c (xmenu_show): Don't use uninitialized vars.
13018
098db9dd
PE
13019 * xterm.c: Fix problems found by static analysis with other toolkits.
13020 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
13021 (x_dispatch_event): Declare static if USE_GTK, and
13022 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 13023 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 13024 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
13025 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
13026 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 13027
eb18f6cc
PE
13028 * xmenu.c (menu_help_callback): Pointer type fixes.
13029 Use const pointers when pointing at readonly data. Avoid pointer
13030 signedness clashes.
13031 (FALSE): Remove unused macro.
13032 (update_frame_menubar): Remove unused decl.
13033
1fe72bf8
PE
13034 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
13035
60d9e1db
PE
13036 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
13037 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
13038 (single_menu_item): Rename local to avoid shadowing.
13039
39261c26
PE
13040 * keyboard.c (make_lispy_event): Remove unused local var.
13041
018c5e19
PE
13042 * frame.c, frame.h (x_get_resource_string): Bring this back, but
13043 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
13044
63d2b86e
PE
13045 * bitmaps: Change bitmaps from unsigned char back to the X11
13046 compatible char. Avoid the old compiler warnings about
13047 out-of-range initializers by using, for example, '\xab' rather
13048 than 0xab.
13049
aefd87e1
PE
13050 * xgselect.c (xgselect_initialize): Check vs interface
13051 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
13052
bf501fb9
PE
13053 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
13054
e9829fdf
PE
13055 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
13056 to read-only memory.
13057
1086c095
PE
13058 * fns.c (vector): Remove; this old hack is no longer needed.
13059
2baccd04 13060 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 13061 Remove unused var.
dde42981 13062 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 13063
72391843 13064 * xrdb.c (x_load_resources): Omit unused local.
3565b346 13065
436c16df 13066 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 13067 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13068 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 13069
92bb796d 13070 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 13071 (x_term_init): Remove local to avoid shadowing.
92bb796d 13072
764430a3 13073 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
13074
13075 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
13076 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
13077
d1dfb56c
EZ
130782011-04-16 Eli Zaretskii <eliz@gnu.org>
13079
c4354cb4
EZ
13080 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
13081
d1dfb56c
EZ
13082 Fix regex.c, syntax.c and friends for buffers > 2GB.
13083 * syntax.h (struct gl_state_s): Declare character position members
13084 EMACS_INT.
13085
13086 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
13087
04f2d78b
CB
13088 * textprop.c (verify_interval_modification, interval_of):
13089 Declare arguments EMACS_INT.
d1dfb56c
EZ
13090
13091 * intervals.c (adjust_intervals_for_insertion): Declare arguments
13092 EMACS_INT.
13093
13094 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
13095
13096 * indent.c (Fvertical_motion): Local variable it_start is now
13097 EMACS_INT.
13098
13099 * regex.c (re_match, re_match_2, re_match_2_internal)
13100 (bcmp_translate, regcomp, regexec, print_double_string)
13101 (group_in_compile_stack, re_search, re_search_2, regex_compile)
13102 (re_compile_pattern, re_exec): Declare arguments and local
13103 variables `size_t' and `ssize_t' and return values `regoff_t', as
13104 appropriate.
13105 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
13106 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
13107 <compile_stack_type>: `size' and `avail' are now `size_t'.
13108
13109 * regex.h <regoff_t>: Use ssize_t, not int.
13110 (re_search, re_search_2, re_match, re_match_2): Arguments that
13111 specify buffer/string position and length are now ssize_t and
13112 size_t. Return type is regoff_t.
13113
613052cd
BK
131142011-04-16 Ben Key <bkey76@gmail.com>
13115
13116 * nsfont.m: Fixed bugs in ns_get_family and
13117 ns_descriptor_to_entity that were caused by using free to
13118 deallocate memory blocks that were allocated by xmalloc (via
13119 xstrdup). This caused Emacs to crash when compiled with
13120 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
13121 --enable-checking=xmallocoverrun). xfree is now used to
13122 deallocate these memory blocks.
13123
4170f62f 131242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 13125
71b41406
PE
13126 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
13127
9587a89d
PE
13128 emacs_write: Accept and return EMACS_INT for sizes.
13129 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
13130 et seq.
13131 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
13132 Accept and return EMACS_INT.
13133 (emacs_gnutls_write): Return the number of bytes written on
13134 partial writes.
13135 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
13136 (emacs_read, emacs_write): Remove check for negative size, as the
13137 Emacs source code has been audited now.
9587a89d
PE
13138 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
13139 (emacs_read, emacs_write): Use it.
273a5f82
PE
13140 * process.c (send_process): Adjust to the new signatures of
13141 emacs_write and emacs_gnutls_write. Do not attempt to store
13142 a byte offset into an 'int'; it might overflow.
9587a89d 13143 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 13144
3e047f51
PE
13145 * sound.c: Don't assume sizes fit in 'int'.
13146 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 13147 Return EMACS_INT, not int.
3e047f51 13148 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
13149 Accept EMACS_INT, not int.
13150 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
13151 record read return values.
13152
cc39a9db
BK
131532011-04-15 Ben Key <bkey76@gmail.com>
13154
c9d0ec6d
JB
13155 * keyboard.c (Qundefined): Don't declare static since it is used
13156 in nsfns.m.
13157 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
13158 static since they are used in nsfont.m.
cc39a9db 13159
6c60eb9f
SM
131602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
13161
13162 * process.c (Qprocessp): Don't declare static.
13163 * lisp.h (Qprocessp): Declare again.
13164
7990b61a
JB
131652011-04-15 Juanma Barranquero <lekktu@gmail.com>
13166
13167 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
13168
5d4cb038
PE
131692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
13170
8bd7b830 13171 Improve C-level modularity by making more things 'static'.
cd64ea1d 13172
e3b27b31
PE
13173 Don't publish debugger-only interfaces to other modules.
13174 * lisp.h (safe_debug_print, debug_output_compilation_hack):
13175 (verify_bytepos, count_markers): Move decls to the only modules
13176 that need them.
13177 * region-cache.h (pp_cache): Likewise.
13178 * window.h (check_all_windows): Likewise.
13179 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
13180
5d4cb038
PE
13181 * sysdep.c (croak): Now static, if
13182 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13183 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
13184
13185 * alloc.c (refill_memory_reserve): Now static if
13186 !defined REL_ALLOC || defined SYSTEM_MALLOC.
13187 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 13188
e87b6180
PE
13189 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
13190 Define only if USE_LUCID.
13191
ac64929e
PE
13192 * xrdb.c (x_customization_string, x_rm_string): Now static.
13193
6f37259d
PE
13194 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
13195 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
13196
1683e3ab
PE
13197 * xdisp.c (draw_row_with_mouse_face): Now static.
13198 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
13199
de9c2632
PE
13200 * window.h (check_all_windows): Mark externally visible.
13201
2b96acb7
PE
13202 * window.c (window_deletion_count): Now static.
13203
13204 * undo.c: Make symbols static if they're not exported.
13205 (last_undo_buffer, last_boundary_position, pending_boundary):
13206 Now static.
13207
50436f33
PE
13208 * textprop.c (interval_insert_behind_hooks): Now static.
13209 (interval_insert_in_front_hooks): Likewise.
13210
64520e5c
PE
13211 * term.c: Make symbols static if they're not exported.
13212 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
13213 (max_frame_lines, tty_set_terminal_modes):
13214 (tty_reset_terminal_modes, tty_turn_off_highlight):
13215 (get_tty_terminal): Now static.
13216 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
13217 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 13218 HAVE_WINDOW_SYSTEM.
64520e5c
PE
13219 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
13220 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
13221
1fa53021
PE
13222 * sysdep.c: Make symbols static if they're not exported.
13223 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
13224 Now static.
13225 (sigprocmask_set, full_mask): Remove; unused.
13226 (wait_debugging): Mark as visible.
13227 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
13228 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
13229
d4b43b22
PE
13230 * syntax.c (syntax_temp): Define only if !__GNUC__.
13231
b7c513d0
PE
13232 * sound.c (current_sound_device, current_sound): Now static.
13233
989b29ad
PE
13234 * search.c (searchbufs, searchbuf_head): Now static.
13235
13a55a78
PE
13236 * scroll.c (scroll_cost): Remove; unused.
13237 * dispextern.h (scroll_cost): Remove decl.
13238
de68a1fc
PE
13239 * region-cache.h (pp_cache): Mark as externally visible.
13240
40ccffa6
PE
13241 * process.c: Make symbols static if they're not exported.
13242 (process_tick, update_tick, create_process, chan_process):
13243 (Vprocess_alist, proc_buffered_char, datagram_access):
13244 (fd_callback_data, send_process_frame, process_sent_to): Now static.
13245 (deactivate_process): Mark defn as static, as well as decl.
13246 * lisp.h (create_process): Remove decl.
13247 * process.h (chan_process, Vprocess_alist): Remove decls.
13248
ad64fc97
PE
13249 * print.c: Make symbols static if they're not exported.
13250 (print_depth, new_backquote_output, being_printed, print_buffer):
13251 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
13252 (print_interval, print_number_index, initial_stderr_stream):
13253 Now static.
13254 * lisp.h (Fprinc): Remove decl.
13255 (debug_output_compilation_hack): Mark as externally visible.
13256
adddb265
PE
13257 * sysdep.c (croak): Move decl from here to syssignal.h.
13258 * syssignal.h (croak): Put it here, so the API can be checked when
13259 'croak' is called from dissociate_if_controlling_tty.
13260
1717ede2
PE
13261 * minibuf.c: Make symbols static if they're not exported.
13262 (minibuf_save_list, choose_minibuf_frame): Now static.
13263 * lisp.h (choose_minibuf_frame): Remove decl.
13264
fa5fb2bc
PE
13265 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
13266
1e3890d1
PE
13267 * lread.c: Make symbols static if they're not exported.
13268 (read_objects, initial_obarray, oblookup_last_bucket_number):
13269 Now static.
13270 (make_symbol): Remove; unused.
13271 * lisp.h (initial_obarray, make_symbol): Remove decls.
13272
8a1414fa
PE
13273 * keyboard.c: Make symbols static if they're not exported.
13274 (single_kboard, recent_keys_index, total_keys, recent_keys):
13275 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
13276 (this_single_command_key_start, echoing, last_auto_save):
13277 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
13278 (command_loop, echo_now, keyboard_init_hook, help_char_p):
13279 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
13280 (Vlispy_mouse_stem, double_click_count):
13281 Now static.
13282 (force_auto_save_soon): Define only if SIGDANGER.
13283 (ignore_mouse_drag_p): Now static if
13284 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
13285 (print_help): Remove; unused.
13286 (stop_character, last_timer_event): Mark as externally visible.
13287 * keyboard.h (ignore_mouse_drag_p): Declare only if
13288 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
13289 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
13290 * lisp.h (echoing): Remove decl.
13291 (force_auto_save_soon): Declare only if SIGDANGER.
13292 * xdisp.c (redisplay_window): Simplify code, to make it more
13293 obvious that ignore_mouse_drag_p is not accessed if !defined
13294 USE_GTK && !defined HAVE_NS.
13295
93ea6e8f
PE
13296 * intervals.c: Make symbols static if they're not exported.
13297 (merge_properties_sticky, merge_interval_right, delete_interval):
13298 Now static.
13299 * intervals.h (merge_interval_right, delete_interval): Remove decls.
13300
77382fcc
PE
13301 * insdel.c: Make symbols static if they're not exported.
13302 However, leave prepare_to_modify_buffer alone. It's never
13303 called from outside this function, but that appears to be a bug.
13304 (combine_after_change_list, combine_after_change_buffer):
4889fc82 13305 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
13306 (adjust_after_replace_noundo): Remove; unused.
13307 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 13308 (signal_before_change): Remove decls.
77382fcc 13309
9306c32e
PE
13310 * indent.c (val_compute_motion, val_vmotion): Now static.
13311
cd44d2eb
PE
13312 * image.c: Make symbols static if they're not exported.
13313 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
13314 if USE_GTK.
13315 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
13316 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
13317
ad9a7a06
PE
13318 * fringe.c (standard_bitmaps): Now static.
13319 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
13320
81626931
PE
13321 * frame.c: Make symbols static if they're not exported.
13322 (x_report_frame_params, make_terminal_frame): Now static.
13323 (get_frame_param): Now static, unless HAVE_NS.
13324 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
13325 (x_get_resource_string): Remove; not used.
13326 * frame.h (make_terminal_frame, x_report_frame_params):
13327 (x_get_resource_string); Remove decls.
13328 (x_fullscreen_adjust): Declare only if WINDOWSNT.
13329 * lisp.h (get_frame_param): Declare only if HAVE_NS.
13330
239f9db9
PE
13331 * font.c, fontset.c: Make symbols static if they're not exported.
13332 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
13333 (FACE_SUITABLE_FOR_CHAR_P): Use it.
13334 * font.c (font_close_object): Now static.
13335 * font.h (font_close_object): Remove.
13336 * fontset.c (FONTSET_OBJLIST): Remove.
13337 (free_realized_fontset) #if-0 the body, which does nothing.
13338 (face_suitable_for_char_p): #if-0, as it's never called.
13339 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
13340 * xfaces.c (face_at_string_position):
13341 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
13342 since 0 is always ASCII.
13343
dfcf3579
PE
13344 * fns.c (weak_hash_tables): Now static.
13345
5045092b
PE
13346 * fileio.c: Make symbols static if they're not exported.
13347 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
13348 (Vwrite_region_annotation_buffers): Now static.
13349
57a96f5c
PE
13350 * eval.c: Make symbols static if they're not exported.
13351 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
13352 * lisp.h (backtrace_list): Remove decl.
13353
35f08c38
PE
13354 * emacs.c: Make symbols static if they're not exported.
13355 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
13356 (fatal_error_code, fatal_error_signal_hook, standard_args):
13357 Now static.
13358 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
13359 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
13360 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
13361 * lisp.h (fatal_error_signal_hook): Remove decl.
13362 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
13363
f44bd759
PE
13364 * editfns.c: Move a (normally-unused) function to its only use.
13365 * editfns.c, lisp.h (get_operating_system_release): Remove.
13366 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
13367 worth the hassle of breaking this out.
13368
b532497d
PE
13369 * xterm.c: Make symbols static if they're not exported.
13370 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
13371 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
13372 (x_destroy_window, x_delete_display):
13373 Now static.
13374 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
13375 (x_mouse_leave): Remove; unused.
13376 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
13377 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
13378 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
13379 Remove decls.
13380 (x_mouse_leave): Declare only if WINDOWSNT.
13381 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
13382 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
13383 USE_X_TOOLKIT.
13384
1675728f
PE
13385 * ftxfont.c: Make symbols static if they're not exported.
13386 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
13387 HAVE_FREETYPE.
13388 * font.h (ftxfont_driver): Likewise.
13389
e4cebfca
PE
13390 * xfns.c: Make symbols static if they're not exported.
13391 (x_last_font_name, x_display_info_for_name):
13392 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
13393 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
13394 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
13395 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
13396 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
13397 (last_show_tip_args): Now static.
13398 (xic_defaut_fontset, xic_create_fontsetname): Define only if
13399 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
13400 (x_screen_planes): Remove; unused.
13401 * dispextern.h (x_screen_planes): Remove decl.
13402
5bf46f05
PE
13403 * dispnew.c: Make symbols static if they're not exported.
13404 * dispextern.h (redraw_garbaged_frames, scrolling):
13405 (increment_row_positions): Remove.
13406 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
13407 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
13408 Now static.
13409 (redraw_garbaged_frames): Remove; unused.
13410
435f4c28
PE
13411 * xfaces.c: Make symbols static if they're not exported.
13412 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
13413 Remove decls.
13414 * xterm.h (defined_color): Remove decls.
13415 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
13416 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
13417 (menu_face_changed_default, defined_color, free_realized_face):
13418 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
13419 (ascii_face_of_lisp_face): Remove; unused.
13420
8524aef3
PE
13421 * xdisp.c: Make symbols static if they're not exported.
13422 * dispextern.h (scratch_glyph_row, window_box_edges):
13423 (glyph_to_pixel_coords, set_cursor_from_row):
13424 (get_next_display_element, set_iterator_to_next):
13425 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
13426 (show_mouse_face): Remove decls
13427 * frame.h (message_buf_print): Likewise.
13428 * lisp.h (pop_message, set_message, check_point_in_composition):
13429 Likewise.
13430 * xterm.h (set_vertical_scroll_bar): Likewise.
13431 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
13432 (message_buf_print, scratch_glyph_row, displayed_buffer):
13433 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
13434 (get_next_display_element, show_mouse_face, window_box_edges):
13435 (frame_to_window_pixel_xy, check_point_in_composition):
13436 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
13437 (glyph_to_pixel_coords): Remove; unused.
13438
16390cd2
PE
13439 * dired.c (file_name_completion): Now static.
13440
13441 * dbusbind.c (xd_in_read_queued_messages): Now static.
13442
a25f4dfa
PE
13443 * lisp.h (circular_list_error, FOREACH): Remove; unused.
13444 * data.c (circular_list_error): Remove.
13445
14a9c8df
PE
13446 * commands.h (last_point_position, last_point_position_buffer):
13447 (last_point_position_window): Remove decls.
13448 * keyboard.c: Make these variables static.
13449
04f2d78b
CB
13450 * coding.h (coding, code_convert_region, encode_coding_gap):
13451 Remove decls.
74ab6df5
PE
13452 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
13453 (iso_code_class, detect_coding, code_convert_region): Now static.
13454 (encode_coding_gap): Remove; unused.
13455
38dfbee1
PE
13456 * chartab.c (chartab_chars, chartab_bits): Now static.
13457
a2cb4e63
PE
13458 * charset.h (charset_iso_8859_1): Remove decl.
13459 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
13460 Now static.
13461
127198fd
PE
13462 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
13463 * ccl.c (Vccl_program_table): Now static.
13464 (check_ccl_update): Remove; unused.
13465
d85b608f
PE
13466 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
13467 * category.h: ... from here.
13468 * category.c (check_category_table, set_category_set): Now static.
13469
31cd66f3
PE
13470 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
13471 * lisp.h: Remove these decls.
13472
c358e587
PE
13473 * buffer.c (buffer_count): Remove unused var.
13474
e78aecca
PE
13475 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
13476 so that it's not optimized away.
13477 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
13478 * dispextern.h (bidi_dump_cached_states): Remove, since it's
13479 exported only to the debugger.
13480
e192d7d3 13481 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 13482 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 13483
92470028
PE
13484 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
13485 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
13486 was inaccessible from Lisp.
13487 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
13488 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
13489
244ed907
PE
13490 alloc.c: Import and export fewer symbols, and remove unused items.
13491 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
13492 is defined.
13493 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
13494 it's not optimized away by whole-program optimization.
13495 (message_enable_multibyte, free_misc): Remove.
13496 (catchlist, handlerlist, mark_backtrace):
13497 Declare only if BYTE_MARK_STACK.
13498 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
13499 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
13500 (message_enable_multibyte): Remove decl.
13501 (free_misc, interval_free_list, float_block, float_block_index):
13502 (n_float_blocks, float_free_list, cons_block, cons_block_index):
13503 (cons_free_list, last_marked_index):
13504 Now static.
13505 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
13506 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
13507 (mark_backtrace): Define only if BYTE_MARK_STACK.
13508 * xdisp.c (message_enable_multibyte): Now static.
13509
61c2b50e 13510 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
13511 This makes it easier for human readers (and static analyzers)
13512 to see whether these variables are used from other modules.
13513 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
13514 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
13515 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
13516 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
13517 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
13518 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
13519 * xmenu.c, xselect.c:
13520 Declare Q* vars static if they are not used in other modules.
13521 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
13522 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
13523 Remove decls of unexported vars.
13524 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
13525
95c82688
PE
13526 * lisp.h (DEFINE_FUNC): Make sname 'static'.
13527
16a97296
PE
13528 Make Emacs functions such as Fatom 'static' by default.
13529 This makes it easier for human readers (and static analyzers)
13530 to see whether these functions can be called from other modules.
13531 DEFUN now defines a static function. To make the function external
13532 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
13533 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
13534 (Finit_image_library):
16a97296
PE
13535 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
13536 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
13537 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
13538 Remove decls, since these functions are now static.
13539 (Funintern, Fget_internal_run_time): New decls, since these functions
13540 were already external.
95c82688 13541
16a97296
PE
13542 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
13543 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
13544 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
13545 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
13546 * keyboard.c, keymap.c, lread.c:
13547 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
13548 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
13549 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
13550 Mark functions with DEFUE instead of DEFUN,
13551 if they are used in other modules.
13552 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
13553 decls for now-static functions.
13554 * buffer.h (Fdelete_overlay): Remove decl.
13555 * callproc.c (Fgetenv_internal): Mark as internal.
13556 * composite.c (Fremove_list_of_text_properties): Remove decl.
13557 (Fcomposition_get_gstring): New forward static decl.
13558 * composite.h (Fcomposite_get_gstring): Remove decl.
13559 * dired.c (Ffile_attributes): New forward static decl.
13560 * doc.c (Fdocumntation_property): New forward static decl.
13561 * eval.c (Ffetch_bytecode): New forward static decl.
13562 (Funintern): Remove extern decl; now in .h file where it belongs.
13563 * fileio.c (Fmake_symbolic_link): New forward static decl.
13564 * image.c (Finit_image_library): New forward static decl.
13565 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
13566 * intervals.h (Fprevious_property_change):
13567 (Fremove_list_of_text_properties): Remove decls.
13568 * keyboard.c (Fthis_command_keys): Remove decl.
13569 (Fcommand_execute): New forward static decl.
13570 * keymap.c (Flookup_key): New forward static decl.
13571 (Fcopy_keymap): Now static.
13572 * keymap.h (Flookup_key): Remove decl.
13573 * process.c (Fget_process): New forward static decl.
13574 (Fprocess_datagram_address): Mark as internal.
13575 * syntax.c (Fsyntax_table_p): New forward static decl.
13576 (skip_chars): Remove duplicate decl.
13577 * textprop.c (Fprevious_property_change): New forward static decl.
13578 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
13579 Now internal.
13580 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
13581 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
13582
785bbd42
PE
13583 * editfns.c (Fformat): Remove unreachable code.
13584
8b913b57
AS
135852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
13586
13587 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
13588 change. (Bug#8496)
13589
a6744a35
EZ
135902011-04-13 Eli Zaretskii <eliz@gnu.org>
13591
13592 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
13593 when at ZV. (Bug#8487)
13594
e7974947
AS
135952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
13596
baad03f0
AS
13597 * charset.c (Fclear_charset_maps): Use xfree instead of free.
13598 (Bug#8437)
13599 * keyboard.c (parse_tool_bar_item): Likewise.
13600 * sound.c (sound_cleanup, alsa_close): Likewise.
13601 * termcap.c (tgetent): Likewise.
13602 * xfns.c (x_default_font_parameter): Likewise.
13603 * xsettings.c (read_and_apply_settings): Likewise.
13604
e7974947
AS
13605 * alloc.c (overrun_check_malloc, overrun_check_realloc)
13606 (overrun_check_free): Protoize.
13607
28272684
PE
136082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
13609
13610 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
13611 since callers should never pass a negative size.
13612 Change the signature to match that of plain 'read' and 'write'; see
13613 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
13614 * lisp.h: Update prototypes of emacs_write and emacs_read.
13615
11997c76
EZ
136162011-04-11 Eli Zaretskii <eliz@gnu.org>
13617
13618 * xdisp.c (redisplay_window): Don't try to determine the character
13619 position of the scroll margin if the window start point w->startp
e896f03c 13620 is outside the buffer's accessible region. (Bug#8468)
11997c76 13621
8a2cbd72
EZ
136222011-04-10 Eli Zaretskii <eliz@gnu.org>
13623
13624 Fix write-region and its subroutines for buffers > 2GB.
13625 * fileio.c (a_write, e_write): Modify declaration of arguments and
13626 local variables to support buffers larger than 2GB.
13627 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
13628
13629 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
13630 argument, local variables, and return value.
13631
13632 * lisp.h: Update prototypes of emacs_write and emacs_read.
13633
13634 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
13635
4073e537 136362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 13637
1ebfdcb6
PE
13638 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
13639
b2ded58d
PE
13640 Fix more problems found by GCC 4.6.0's static checks.
13641
7d66342c
PE
13642 * xdisp.c (vmessage): Use a better test for character truncation.
13643
bbf47d44
PE
13644 * charset.c (load_charset_map): <, not <=, for optimization,
13645 and to avoid potential problems with integer overflow.
9248994d 13646 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 13647 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 13648 * editfns.c (Fformat): Likewise.
1e69125e 13649 * syntax.c (skip_chars): Likewise.
3befa583 13650
e3019616
PE
13651 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
13652 This also lets GCC 4.6.0 generate slightly better loop code.
13653
becfa255
PE
13654 * callint.c (Fcall_interactively): <, not <=, for optimization.
13655 (Fcall_interactively): Count the number of arguments produced,
13656 not the number of arguments given. This is simpler and lets GCC
13657 4.6.0 generate slightly better code.
13658
dae0cd48
PE
13659 * ftfont.c: Distingish more carefully between FcChar8 and char.
13660 The previous code passed unsigned char * to a functions like
13661 strlen and xstrcasecmp that expect char *, which does not
13662 conform to the C standard.
13663 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
13664 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
13665 char * when the C standard requires it.
13666
76032d70
PE
13667 * keyboard.c (read_char): Remove unused var.
13668
eb3f1cc8
PE
13669 * eval.c: Port to Windows vsnprintf (Bug#8435).
13670 Include <limits.h>.
13671 (SIZE_MAX): Define if the headers do not.
13672 (verror): Do not give up if vsnprintf returns a negative count.
13673 Instead, grow the buffer. This ports to Windows vsnprintf, which
13674 does not conform to C99. Problem reported by Eli Zaretskii.
13675 Also, simplify the allocation scheme, by avoiding the need for
13676 calling realloc, and removing the ALLOCATED variable.
13677
70476b54
PE
13678 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
13679
12020a9e
PE
13680 Remove invocations of doprnt, as Emacs now uses vsnprintf.
13681 But keep the doprint source code for now, as we might revamp it
13682 and use it again (Bug#8435).
ea6c7ae6
PE
13683 * lisp.h (doprnt): Remove.
13684 * Makefile.in (base_obj): Remove doprnt.o.
13685 * deps.mk (doprnt.o): Remove.
13686
5fdb398c
PE
13687 error: Print 32- and 64-bit integers portably (Bug#8435).
13688 Without this change, on typical 64-bit hosts error ("...%d...", N)
13689 was used to print both 32- and 64-bit integers N, which relied on
13690 undefined behavior.
61bdb816 13691 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
13692 * lisp.h (error, verror): Mark as printf-like functions.
13693 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
13694 Report overflow in size calculations when allocating printf buffer.
13695 Do not truncate output string at its first null byte.
13696 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
13697 Truncate the output at a character boundary, since vsnprintf does not
13698 do that.
13699 * charset.c (check_iso_charset_parameter): Convert internal
13700 character to string before calling 'error', since %c now has the
13701 printf meaning.
13702 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
13703 overflow when computing char to be passed to 'error'. Do not
13704 pass Lisp_Object to 'error'; pass the integer instead.
13705 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
13706 formatted with plain %d.
13707
b189fa66
PE
13708 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
13709
bff87ef0
PE
13710 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
13711
7e2cac20
PE
13712 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
13713
ce4d90b5
PE
13714 * xterm.c (x_catch_errors): Remove duplicate declaration.
13715
266c9547
PE
13716 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
13717
79c49ad2
PE
13718 * xdisp.c, lisp.h (message_nolog): Remove; unused.
13719
368f4090
JM
137202011-04-10 Jim Meyering <meyering@redhat.com>
13721
13722 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
13723 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
13724 return ssize_t not "int", and use size_t as the buffer length.
13725 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
13726 * gnutls.h: Update declarations.
13727 * process.c (read_process_output): Use ssize_t, to match.
13728 (send_process): Likewise.
13729
a32d4040
CY
137302011-04-09 Chong Yidong <cyd@stupidchicken.com>
13731
13732 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
13733
8546720e 137342011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 13735
04f2d78b
CB
13736 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
13737 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 13738
8546720e
GM
13739 * xterm.c (handle_one_xevent):
13740 * xmenu.c (create_and_show_popup_menu):
13741 * xselect.c (x_decline_selection_request)
13742 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 13743
0a2f5c1a 137442011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
13745
13746 Fix some uses of `int' instead of EMACS_INT.
13747 * search.c (string_match_1, fast_string_match)
13748 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
13749 (scan_buffer, find_next_newline_no_quit)
13750 (find_before_next_newline, search_command, Freplace_match)
13751 (Fmatch_data): Make some `int' variables be EMACS_INT.
13752
13753 * xdisp.c (display_count_lines): 3rd argument and return value now
13754 EMACS_INT. All callers changed.
13755 (pint2hrstr): Last argument is now EMACS_INT.
13756
13757 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
13758 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
13759 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
13760 (decode_coding_utf_16, decode_coding_emacs_mule)
13761 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
13762 (decode_coding_ccl, decode_coding_charset)
13763 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
13764 (decode_coding_iso_2022, decode_coding_emacs_mule)
13765 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
13766 <char_offset, last_offset>: Declare EMACS_INT.
13767 (encode_coding_utf_8, encode_coding_utf_16)
13768 (encode_coding_emacs_mule, encode_invocation_designation)
13769 (encode_designation_at_bol, encode_coding_iso_2022)
13770 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
13771 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
13772 Declare EMACS_INT.
13773 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
13774 (encode_invocation_designation): Last argument P_NCHARS is now
13775 EMACS_INT.
13776 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
13777 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
13778
13779 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
13780 All users changed.
13781
13782 * ccl.c (Fccl_execute_on_string): Declare some variables
13783 EMACS_INT.
13784
8546720e 137852011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13786
13787 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13788
4e19a977
CS
137892011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13790
13791 * process.c (Fformat_network_address): Doc fix.
13792
87302331
R
137932011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13794
ee7683eb 13795 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13796
cbb59342
CY
137972011-04-08 Chong Yidong <cyd@stupidchicken.com>
13798
13799 * keyboard.c (read_char): Call Lisp function help-form-show,
13800 instead of using internal_with_output_to_temp_buffer.
13801 (Qhelp_form_show): New var.
e0d38eeb 13802 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13803
13804 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13805
13806 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13807
e67a13ab
CY
138082011-04-06 Chong Yidong <cyd@stupidchicken.com>
13809
04f2d78b
CB
13810 * process.c (Flist_processes): Remove to Lisp.
13811 (list_processes_1): Delete.
e67a13ab 13812
973f782d
EZ
138132011-04-06 Eli Zaretskii <eliz@gnu.org>
13814
7c106b1e
EZ
13815 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13816
973f782d
EZ
13817 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13818
41cf7d1a 138192011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13820
ca23cc88
PE
13821 Fix more problems found by GCC 4.6.0's static checks.
13822
f390e2d5
PE
13823 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13824
42eea0d0
PE
13825 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13826
b69769da 13827 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13828
f9541e84
PE
13829 * xdisp.c (vmessage): Mark as a printf-like function.
13830
13841b55
PE
13831 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13832
c136c10f
PE
13833 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13834
5e2d4a30
PE
13835 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13836 printf-like functions.
13837 (tiff_load): Add casts to remove these marks before passing them
13838 to system-supplied API.
13839
583f48b9
PE
13840 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13841
b25d760e
PE
13842 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13843 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13844 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13845 directly, rather than having caller test rule sign. This avoids
13846 some unnecessary tests.
13847 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13848 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13849 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13850
bc7b6697 13851 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13852 (xfont_open): Avoid unnecessary tests.
bc7b6697 13853
27ccc379
PE
13854 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13855
dcd5c89a
PE
13856 * composite.h, composite.c (composition_gstring_put_cache):
13857 Use EMACS_INT, not int, for length.
13858
b13a45c6
PE
13859 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13860 breaking out part of COMPOSITION_DECODE_RULE.
13861 (COMPOSITION_DECODE_RULE): Use it.
13862 * composite.c (get_composition_id): Remove unused local vars,
13863 by using the new macro.
13864
1e792e4d
PE
13865 * textprop.c (set_text_properties_1): Change while to do-while,
13866 since the condition is always true at first.
13867
dc6c6455 13868 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13869 (interval_deletion_adjustment): Return unsigned value.
13870 All uses changed.
dc6c6455 13871
aba7731a
PE
13872 * process.c (list_processes_1, create_pty, read_process_output):
13873 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13874 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13875 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13876 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13877 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13878
fdfc4bf3
PE
13879 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13880
fca8fe46 13881 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13882 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13883
06a0259a 13884 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13885 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13886 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13887
e7b9e80f
PE
13888 * print.c (print_error_message): Avoid int overflow.
13889
56201685
PE
13890 * font.c (font_list_entities): Redo for clarity,
13891 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13892
78834453 13893 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13894 (font_score): Avoid potential overflow in diff calculation.
78834453 13895
0bc0b309 13896 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13897 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13898
e610eaca
PE
13899 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13900
b895abce
PE
13901 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13902 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13903 can always succeed if overflow has undefined behavior.
13904
1f1d9321 13905 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13906 (wordify): Omit three unnecessary tests.
1f1d9321 13907
c59478bc
PE
13908 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13909 All callers changed. This avoids the need for an unused var.
13910
79b73827
PE
13911 * casefiddle.c (casify_region): Remove var that is set but not used.
13912
a4db5dfe
PE
13913 * dired.c (file_name_completion): Remove var that is set but not used.
13914
43aae36e
PE
13915 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13916
2a47c44d 13917 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13918 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13919
a37c69bf
PE
13920 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13921 Check for integer overflow on size calculations.
13922
328ab8e7
PE
13923 * buffer.c (Fprevious_overlay_change): Remove var that is set
13924 but not used.
13925
e5a2a5cb
PE
13926 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13927 Remove vars that are set but not used.
8d84a6eb 13928 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13929 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13930
a60e5f68
PE
13931 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13932
f661cb61 13933 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13934 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13935
f0397f5a
PE
13936 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13937 that are set but not used.
13938
8664db06 13939 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13940 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13941
6abdaa4a
PE
13942 * xselect.c (x_get_local_selection, x_handle_property_notify):
13943 Remove vars that are set but not used.
13944
0ce7538d 13945 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13946 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13947
9ae848fc
PE
13948 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13949 Remove var that is set but not used.
0b918413
PE
13950 (scroll_bar_windows_size): Now size_t, not int.
13951 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13952 Check for overflow.
9ae848fc 13953
a5a62657
PE
13954 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13955 (map_tty_color) [!defined MSDOS]: Likewise.
13956
5c5cdd39
PE
13957 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13958
66ebf983
PE
13959 * coding.c: Remove vars that are set but not used.
13960 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13961 All callers changed.
13962 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13963 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13964 (decode_coding_charset): Remove vars that are set but not used.
13965
1be4d761
PE
13966 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13967 that is set but not used.
13968
47553fa8
PE
13969 * print.c (print_object): Remove var that is set but not used.
13970
1f7196bf 13971 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13972 The gnulib version avoids calling malloc in the usual case,
13973 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13974 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13975 * filelock.c (current_lock_owner): Likewise.
13976 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13977 * sysdep.c: Include allocator.h, careadlinkat.h.
13978 (emacs_no_realloc_allocator): New static constant.
13979 (emacs_readlink): New function.
fdb61804
PE
13980 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13981 ../lib/careadlinkat.h.
d1fdcab7 13982
f84c17c7
SM
139832011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13984
13985 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13986 first non-nil return value).
13987
ef3862ad
JD
139882011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13989
13990 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13991 if not defined (Bug#8403).
13992
376a7006
JB
139932011-04-02 Juanma Barranquero <lekktu@gmail.com>
13994
13995 * xdisp.c (display_count_lines): Remove parameter `start',
13996 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13997 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13998 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13999 (fill_stretch_glyph_string): Remove parameters `row' and `area',
14000 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
14001 and thereabouts. All callers changed.
14002 (get_per_char_metric): Remove parameter `f', unused since
14003 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
14004
6ca3801d
JM
140052011-04-02 Jim Meyering <meyering@redhat.com>
14006
14007 do not dereference NULL upon failed strdup
14008 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
14009 (ns_get_family): Likewise.
14010
d8e2b5ba
JB
140112011-04-02 Juanma Barranquero <lekktu@gmail.com>
14012
14013 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
14014
8c74fcbd
JD
140152011-04-02 Jan Djärv <jan.h.d@swipnet.se>
14016
14017 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
14018 later (Bug#8403).
14019
7200d79c
SM
140202011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
14021
03408648 14022 Add lexical binding.
7200d79c 14023
03408648
SM
14024 * window.c (Ftemp_output_buffer_show): New fun.
14025 (Fsave_window_excursion):
14026 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
14027
14028 * lread.c (lisp_file_lexically_bound_p): New function.
14029 (Fload): Bind Qlexical_binding.
14030 (readevalloop): Remove `evalfun' arg.
14031 Bind Qinternal_interpreter_environment.
14032 (Feval_buffer): Bind Qlexical_binding.
14033 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
14034 Mark as dynamic.
14035 (syms_of_lread): Declare `lexical-binding'.
14036
14037 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
14038
14039 * keyboard.c (eval_dyn): New fun.
14040 (menu_item_eval_property): Use it.
ca105506
SM
14041
14042 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 14043
03408648
SM
14044 * fns.c (concat, mapcar1): Accept byte-code-functions.
14045
14046 * eval.c (Fsetq): Handle lexical vars.
14047 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
14048 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
14049 (FletX, Flet): Obey lexical binding.
14050 (Fcommandp): Handle closures.
14051 (Feval): New `lexical' arg.
14052 (eval_sub): New function extracted from Feval. Use it almost
14053 everywhere where Feval was used. Look up vars in lexical env.
14054 Handle closures.
14055 (Ffunctionp): Move from subr.el.
14056 (Ffuncall): Handle closures.
14057 (apply_lambda): Remove `eval_flags'.
14058 (funcall_lambda): Handle closures and new byte-code-functions.
14059 (Fspecial_variable_p): New function.
14060 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
14061 but without exporting it to Lisp.
23aba0ea 14062
23aba0ea 14063 * doc.c (Fdocumentation, store_function_docstring):
03408648 14064 * data.c (Finteractive_form): Handle closures.
23aba0ea 14065
03408648
SM
14066 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
14067 interactive spec.
ba83908c 14068
04f2d78b
CB
14069 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
14070 New byte-codes.
03408648
SM
14071 (exec_byte_code): New function extracted from Fbyte_code to handle new
14072 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 14073
03408648 14074 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 14075
03408648 14076 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 14077
e2abce01
JB
140782011-03-31 Juanma Barranquero <lekktu@gmail.com>
14079
14080 * xdisp.c (redisplay_internal): Fix prototype.
14081
63696a73 140822011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 14083
63696a73 14084 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
14085 (try_scrolling): Use it when setting scroll_limit.
14086 Limit scrolling to 100 screen lines.
63696a73
EZ
14087 (redisplay_window): Even when falling back on "recentering",
14088 position point in the window according to scroll-conservatively,
14089 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
14090
14091 (try_scrolling): When point is above the window, allow searching
14092 as far as scroll_max, or one screenful, to compute vertical
14093 distance from PT to the scroll margin position. This prevents
14094 try_scrolling from unnecessarily failing when
14095 scroll-conservatively is set to a value slightly larger than the
14096 window height. Clean up the case of PT below the margin at bottom
14097 of window: scroll_max can no longer be INT_MAX. When aggressive
14098 scrolling is in use, don't let point enter the opposite scroll
14099 margin as result of the scroll.
14100 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
14101 threshold of 100 lines for never-recentering scrolling.
14102
e4cc2dfc
JB
141032011-03-31 Juanma Barranquero <lekktu@gmail.com>
14104
14105 * dispextern.h (move_it_by_lines):
14106 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
14107 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
14108 (message_log_check_duplicate): Remove parameters `prev_bol' and
14109 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
14110 (redisplay_internal): Remove parameter `preserve_echo_area',
14111 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
14112
14113 * indent.c (Fvertical_motion):
14114 * window.c (window_scroll_pixel_based, Frecenter):
14115 Don't pass `need_y_p' to `move_it_by_lines'.
14116
1c470562
SM
141172011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
14118
44f230aa
SM
14119 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
14120 steal a few bits to be more compact.
14121 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
14122 Remove unneeded casts.
14123
1c470562
SM
14124 * bytecode.c (Fbyte_code): CAR and CDR can GC.
14125
888adce9
ZK
141262011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
14127
14128 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
14129 binding" message (bug#7967).
14130
f838ed7b
PE
141312011-03-30 Paul Eggert <eggert@cs.ucla.edu>
14132
77861b95
PE
14133 Fix more problems found by GCC 4.6.0's static checks.
14134
de6dbc14
PE
14135 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
14136 Remove unused local var.
14137
f838ed7b
PE
14138 * editfns.c (Fmessage_box): Remove unused local var.
14139
792c7b2b
PE
14140 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
14141 (note_mode_line_or_margin_highlight, note_mouse_highlight):
14142 Omit unused local vars.
c499e557 14143 * window.c (shrink_windows): Omit unused local var.
b01a1c29 14144 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
14145 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
14146 Omit unused local var.
14147
ba0165e1
PE
14148 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
14149 Don't assume string length fits in int.
32ad8845 14150 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 14151 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 14152
3c59b4c9
PE
14153 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
14154 instead of alloca (Bug#8344).
14155
a3eed478 14156 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 14157 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 14158
eb4d412d
PE
14159 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
14160
1658b401
PE
14161 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
14162 concerns.
14163
14164 * term.c (produce_glyphless_glyph): Remove unnecessary test.
14165
14166 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 14167
9a2c6e05
PE
14168 * keyboard.c (syms_of_keyboard): Use the same style as later
14169 in this function when indexing through an array. This also
14170 works around GCC bug 48267.
14171
03d0a109
PE
14172 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
14173
44f730c8
PE
14174 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
14175
fe75f926
PE
14176 * chartab.c (sub_char_table_ref_and_range): Redo for slight
14177 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
14178
ffa8c828
PE
14179 * keyboard.c, keyboard.h (num_input_events): Now size_t.
14180 This avoids undefined behavior on integer overflow, and is a bit
14181 more convenient anyway since it is compared to a size_t variable.
14182
c5101a77
PE
14183 Variadic C functions now count arguments with size_t, not int.
14184 This avoids an unnecessary limitation on 64-bit machines, which
14185 caused (substring ...) to crash on large vectors (Bug#8344).
14186 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
14187 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 14188 All variadic functions and their callers changed accordingly.
c5101a77
PE
14189 (struct gcpro.nvars): Now size_t, not int. All uses changed.
14190 * data.c (arith_driver, float_arith_driver): Likewise.
14191 * editfns.c (general_insert_function): Likewise.
14192 * eval.c (struct backtrace.nargs, interactive_p)
14193 (internal_condition_case_n, run_hook_with_args, apply_lambda)
14194 (funcall_lambda, mark_backtrace): Likewise.
14195 * fns.c (concat): Likewise.
14196 * frame.c (x_set_frame_parameters): Likewise.
14197 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
14198 0 if not found, not -1. All callers changed.
14199
dd3f25f7
PE
14200 * alloc.c (garbage_collect): Don't assume stack size fits in int.
14201 (stack_copy_size): Now size_t, not int.
14202 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
14203
461c2ab9
JB
142042011-03-28 Juanma Barranquero <lekktu@gmail.com>
14205
14206 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
14207 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14208 All callers changed.
14209
14210 * lisp.h (multibyte_char_to_unibyte):
14211 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
14212 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
14213 * character.h (CHAR_TO_BYTE8):
14214 * cmds.c (internal_self_insert):
14215 * editfns.c (general_insert_function):
14216 * keymap.c (push_key_description):
14217 * search.c (Freplace_match):
14218 * xdisp.c (message_dolog, set_message_1): All callers changed.
14219
f6d62986
SM
142202011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
14221
14222 * keyboard.c (safe_run_hook_funcall): New function.
14223 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
14224 don't set the hook to nil, but remove the offending function instead.
14225 (Qcommand_hook_internal): Remove, unused.
14226 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
14227 Vcommand_hook_internal.
14228
14229 * eval.c (enum run_hooks_condition): Remove.
14230 (funcall_nil, funcall_not): New functions.
14231 (run_hook_with_args): Call each function through a `funcall' argument.
14232 Remove `cond' argument, now redundant.
14233 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
14234 (Frun_hook_with_args_until_failure): Adjust accordingly.
14235 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
14236
1db5b1ad
JB
142372011-03-28 Juanma Barranquero <lekktu@gmail.com>
14238
14239 * dispextern.h (string_buffer_position): Remove declaration.
14240
14241 * print.c (strout): Remove parameter `multibyte', unused since
14242 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
14243
14244 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
14245 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
14246 All callers changed.
14247
14248 * w32.c (_wsa_errlist): Use braces for struct initializers.
14249
14250 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
14251 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
14252 All callers changed.
14253 (string_buffer_position): Likewise. Also, make static (it's never
14254 used outside xdisp.c).
14255 (cursor_row_p): Remove parameter `w', unused since
14256 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
14257 (decode_mode_spec): Remove parameter `precision', introduced during
14258 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
14259 All callers changed.
14260
5ffb62aa
JD
142612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14262
14263 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
14264
461c2ab9 142652011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
14266
14267 * nsterm.m (ns_menu_bar_is_hidden): New variable.
14268 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
14269 (ns_update_auto_hide_menu_bar): New functions.
14270 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
14271 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
14272 ns_constrain_all_frames.
14273 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
14274 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
14275
5c380ffb
JD
142762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
14277
14278 * nsmenu.m (runDialogAt): Remove argument to timer_check.
14279
9af30bdf
GM
142802011-03-27 Glenn Morris <rgm@gnu.org>
14281
14282 * syssignal.h: Replace RETSIGTYPE with void.
14283 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
14284 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
14285 Replace SIGTYPE with void everywhere.
14286 * s/usg5-4-common.h (SIGTYPE): Remove definition.
14287 * s/template.h (SIGTYPE): Remove commented out definition.
14288
e2abce01
JB
142892011-03-26 Eli Zaretskii <eliz@gnu.org>
14290
14291 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
14292 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
14293
f868cd8a
JB
142942011-03-26 Juanma Barranquero <lekktu@gmail.com>
14295
59eb0929
JB
14296 * w32.c (read_unc_volume): Use parameter `henum', instead of
14297 global variable `wget_enum_handle'.
14298
14299 * keymap.c (describe_vector): Remove parameters `indices' and
14300 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
14301 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
14302
f868cd8a
JB
14303 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
14304
14305 * keyboard.c (timer_check): Remove parameter `do_it_now',
14306 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
14307 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
14308 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
14309
14310 * keyboard.c (read_char):
14311 * w32menu.c (w32_menu_display_help):
14312 * xmenu.c (show_help_event, menu_help_callback):
14313 Adjust calls to `show_help_echo'.
14314
14315 * gtkutil.c (xg_maybe_add_timer):
14316 * keyboard.c (readable_events):
14317 * process.c (wait_reading_process_output):
14318 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
14319
14320 * insdel.c (adjust_markers_gap_motion):
14321 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
14322 (gap_left, gap_right): Don't call it.
14323
2ecf6fdb
CY
143242011-03-25 Chong Yidong <cyd@stupidchicken.com>
14325
14326 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
14327 incurred during fontification.
14328
6b1f9ba4
JB
143292011-03-25 Juanma Barranquero <lekktu@gmail.com>
14330
14331 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
14332 (DEFVAR_PER_BUFFER): Don't pass it.
14333
14334 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
14335 (scrolling_window): Don't pass it.
14336
0f4a96b5
JB
143372011-03-25 Juanma Barranquero <lekktu@gmail.com>
14338
14339 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
14340
14341 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
14342 and `suffix'.
14343 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
14344 of variables specific to SELinux and computation of `encoded_absname'.
14345
14346 * image.c (XPutPixel): Remove unused variable `height'.
14347
14348 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
14349
14350 * unexw32.c (get_section_info): Remove unused variable `section'.
14351
14352 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
14353 (system_process_attributes): Remove unused variable `sess'.
14354 (sys_read): Remove unused variable `err'.
14355
14356 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
14357 (w32_wnd_proc): Remove unused variable `isdead'.
14358 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
14359 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
14360 (x_create_tip_frame): Remove unused variable `tem'.
14361
14362 * w32inevt.c (w32_console_read_socket):
14363 Remove unused variable `no_events'.
14364
14365 * w32term.c (x_draw_composite_glyph_string_foreground):
14366 Remove unused variable `width'.
14367
1149507c
JB
143682011-03-24 Juanma Barranquero <lekktu@gmail.com>
14369
14370 * w32term.c (x_set_glyph_string_clipping):
14371 Don't pass uninitialized region to CombineRgn.
14372
9c88f339
JB
143732011-03-23 Juanma Barranquero <lekktu@gmail.com>
14374
14375 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
14376 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
14377 (Fx_close_connection): Remove unused variable `i'.
14378
14379 * w32font.c (w32font_draw): Return number of glyphs.
14380 (w32font_open_internal): Remove unused variable `i'.
14381 (w32font_driver): Add missing initializer.
14382
14383 * w32menu.c (utf8to16): Remove unused variable `utf16'.
14384 (fill_in_menu): Remove unused variable `items_added'.
14385
14386 * w32term.c (last_mouse_press_frame): Remove static global variable.
14387 (w32_clip_to_row): Remove unused variable `f'.
14388 (x_delete_terminal): Remove unused variable `i'.
14389
14390 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
14391 (NOTHING): Remove unused static global variable.
14392 (uniscribe_check_otf): Remove unused variable `table'.
14393 (uniscribe_font_driver): Add missing initializers.
14394
dee091a3
JD
143952011-03-23 Julien Danjou <julien@danjou.info>
14396
14397 * term.c (Fsuspend_tty, Fresume_tty):
14398 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
14399 * window.c (temp_output_buffer_show):
14400 * insdel.c (signal_before_change):
14401 * frame.c (Fhandle_switch_frame):
14402 * fileio.c (Fdo_auto_save):
14403 * emacs.c (Fkill_emacs):
14404 * editfns.c (save_excursion_restore):
14405 * cmds.c (internal_self_insert):
14406 * callint.c (Fcall_interactively):
14407 * buffer.c (Fkill_all_local_variables):
14408 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
14409 Use Frun_hooks.
0f4a96b5 14410 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 14411 unconditionally since it does the check itself.
dee091a3 14412
2c520ab5 144132011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 14414
c9c49752
PE
14415 Fix more problems found by GCC 4.5.2's static checks.
14416
8abc3f12
PE
14417 * coding.c (encode_coding_raw_text): Avoid unnecessary test
14418 the first time through the loop, since we know p0 < p1 then.
14419 This also avoids a gcc -Wstrict-overflow warning.
14420
a2d26660
PE
14421 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
14422 leading to a memory leak, possible in functions like
14423 load_charset_map_from_file that can allocate an unbounded number
b12ef411 14424 of objects (Bug#8318).
a2d26660 14425
916c72e9
PE
14426 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
14427 that could (at least in theory) be that large.
14428
19ab8a18
PE
14429 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
14430 This is less likely to overflow, and avoids undefined behavior if
14431 overflow does occur. All callers changed. Use strtoul to scan
14432 for the unsigned long integer.
b7cbbd6f
PE
14433 (pint2hrstr): Simplify and tune code slightly.
14434 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 14435
f0641eff
PE
14436 * scroll.c (do_scrolling): Work around GCC bug 48228.
14437 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
14438
7f650bb9
PE
14439 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
14440 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
14441 (validate_x_resource_name): Simplify count usage.
14442 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 14443
37dd57d1
PE
14444 * fileio.c (Fcopy_file): Report error if fchown or fchmod
14445 fail (Bug#8306).
81e56e61 14446
699979fc 14447 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 14448
401bf9b4
PE
14449 * process.c (Fmake_network_process): Use socklen_t, not int,
14450 where POSIX says socklen_t is required in portable programs.
14451 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 14452 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
14453 (Fmake_network_process, server_accept_connection):
14454 (wait_reading_process_output, read_process_output):
14455 Likewise.
14456
b93aacde
PE
14457 * process.c: Rename or move locals to avoid shadowing.
14458 (list_processes_1, Fmake_network_process):
14459 (read_process_output_error_handler, exec_sentinel_error_handler):
14460 Rename or move locals.
4dc343ee 14461 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 14462 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 14463 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 14464 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 14465 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 14466
af8a867c 14467 Make tparam.h and terminfo.c consistent.
44f230aa
SM
14468 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
14469 Include tparam.h instead, since it declares them.
af8a867c
PE
14470 * cm.h (PC): Remove extern decl; tparam.h now does this.
14471 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
14472 * terminfo.c: Include tparam.h, to check interfaces.
14473 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
14474 (tparam): Adjust signature to match interface in tparam.h;
14475 this removes some undefined behavior. Check that outstring and len
14476 are zero, which they always are with Emacs.
14477 * tparam.h (PC, BC, UP): New extern decls.
14478
0248044d 14479 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 14480 (xftfont_open): Rename locals to avoid shadowing.
0248044d 14481
8ff096c1 14482 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
14483 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
14484 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 14485 (ftfont_list): Remove unused local.
49eaafba
PE
14486 (get_adstyle_property, ftfont_pattern_entity):
14487 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
14488 Rename locals to avoid shadowing.
8ff096c1 14489
e2be39f6
PE
14490 * xfont.c (xfont_list_family): Mark var as initialized.
14491
c9735e30
PE
14492 * xml.c (make_dom): Now static.
14493
8f5201ae
PE
14494 * composite.c (composition_compute_stop_pos): Rename local to
14495 avoid shadowing.
b246f932
PE
14496 (composition_reseat_it): Remove unused locals.
14497 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 14498 (composition_update_it): Mark var as initialized.
11b61122
PE
14499 (find_automatic_composition): Mark vars as initialized,
14500 with a FIXME (Bug#8290).
8f5201ae 14501
760fbc2c
PE
14502 character.h: Rename locals to avoid shadowing.
14503 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
14504 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
14505 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
14506 (BUF_DEC_POS): Be more systematic about renaming local temporaries
14507 to avoid shadowing.
14508
ff08eb85
PE
14509 * textprop.c (property_change_between_p): Remove; unused.
14510
fc7bf025
PE
14511 * intervals.c (interval_start_pos): Now static.
14512
235d7abc
PE
14513 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
14514
44f230aa
SM
14515 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
14516 Rename locals to avoid shadowing.
3e7d6594 14517
50060332
PE
14518 * sound.c (wav_play, au_play, Fplay_sound_internal):
14519 Fix pointer signedness.
d01f234b 14520 (alsa_choose_format): Remove unused local var.
c83b8872
PE
14521 (wav_play): Initialize a variable to 0, to prevent undefined
14522 behavior (Bug#8278).
50060332 14523
c4fc4e30
PE
14524 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
14525
918436ed
PE
14526 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
14527
c939f91b
PE
14528 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
14529 clobbering (Bug#8298).
b9c7f648
PE
14530 * sysdep.c (sys_subshell): Likewise.
14531 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 14532
6bd8c144
PE
14533 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
14534 This should get cleaned up, so that child_setup has the
14535 same signature on all platforms.
14536
7710357c 14537 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 14538 (relocate_fd): Rename locals to avoid shadowing.
7710357c 14539
c59da222
CY
145402011-03-22 Chong Yidong <cyd@stupidchicken.com>
14541
14542 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
14543 not to be necessary, and produces flickering.
14544
66b87493
GM
145452011-03-20 Glenn Morris <rgm@gnu.org>
14546
14547 * config.in: Remove file.
14548
45b6f6d5
JB
145492011-03-20 Juanma Barranquero <lekktu@gmail.com>
14550
14551 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
14552 are now in src/globals.h.
14553 (syms_of_minibuf): Remove spurious & from previous change.
14554
cd394be1 145552011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
14556
14557 * minibuf.c (completing-read-function): New variable.
14558 (completing-read-default): Rename from completing-read.
14559 (completing-read): Call completing-read-function.
14560
b14e3e21
CY
145612011-03-19 Juanma Barranquero <lekktu@gmail.com>
14562
14563 * xfaces.c (Fx_load_color_file):
14564 Read color file from absolute filename (bug#8250).
14565
f2b726e6
JB
145662011-03-19 Juanma Barranquero <lekktu@gmail.com>
14567
14568 * makefile.w32-in: Update dependencies.
14569
09f6ff02
EZ
145702011-03-17 Eli Zaretskii <eliz@gnu.org>
14571
14572 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
14573
29a6015a
PE
145742011-03-17 Paul Eggert <eggert@cs.ucla.edu>
14575
a3a6c54e
PE
14576 Fix more problems found by GCC 4.5.2's static checks.
14577
b766f867
PE
14578 * process.c (make_serial_process_unwind, send_process_trap):
14579 (sigchld_handler): Now static.
14580
be02381c
PE
14581 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
14582 That way, the code declares only the vars that it needs.
14583 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
14584 * s/cygwin.h (PTY_ITERATION): Likewise.
14585 * s/darwin.h (PTY_ITERATION): Likewise.
14586 * s/gnu-linux.h (PTY_ITERATION): Likewise.
14587
57048744
PE
14588 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
14589 * process.c (allocate_pty): Don't declare stb unless it's needed.
14590
7914961c 14591 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
14592 (CONSTANTLIM): Remove; unused.
14593 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
14594 Define only if needed.
7914961c 14595
b3967b18
PE
14596 * unexelf.c (unexec): Name an expression,
14597 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
14598 Use a different way to cause a compilation error if anyone uses
14599 n rather than nn, a way that does not involve shadowing.
73366a00 14600 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 14601
29a6015a
PE
14602 * deps.mk (unexalpha.o): Remove; unused.
14603
43cfc33e 14604 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 14605 * unexec.h: New file.
ce701a33
PE
14606 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
14607 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
14608 Depend on unexec.h.
14609 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
14610 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
14611 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 14612 Change as necessary to match prototype in unexec.h.
ce701a33 14613
01f44d5a
PE
14614 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
14615 shadowing.
4f63c6bb 14616 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 14617
a6670b0b
PE
14618 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
14619 Rename locals to avoid shadowing.
14620
cef2010d 14621 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 14622 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 14623
d4d7173a
PE
14624 * print.c (Fredirect_debugging_output): Fix pointer signedess.
14625
f08b802a
PE
14626 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
14627 warning when compiling print.c.
14628
3ddb0639
PE
14629 * font.c (font_unparse_fcname): Abort in an "impossible" situation
14630 instead of using an uninitialized var.
5ad03b97 14631 (font_sort_entities): Mark var as initialized.
3ddb0639 14632
170a2692
PE
14633 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
14634
e663c700
PE
14635 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
14636 pointers to constants.
89bc529a 14637 (font_parse_fcname): Remove unused vars.
7b81e2d0 14638 (font_delete_unmatched): Now static.
ea838e10 14639 (font_get_spec): Remove; unused.
13a547c6
PE
14640 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
14641 (font_update_drivers, Ffont_get_glyphs, font_add_log):
14642 Rename or move locals to avoid shadowing.
e663c700 14643
2a80c887 14644 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 14645 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 14646
1384fa33 14647 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 14648 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 14649
8b2c52e9
PE
14650 * alloc.c (mark_backtrace): Move decl from here ...
14651 * lisp.h: ... to here, so that it can be checked.
14652
475545b5 14653 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 14654 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
14655 (lisp_indirect_variable): Name an expression,
14656 to avoid gcc -Wbad-function-cast warning.
1faed8ae 14657 (Fdefvar): Rename locals to avoid shadowing.
475545b5 14658
b1349114 14659 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 14660 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 14661 Use const pointer when appropriate.
b1349114 14662
a2928364
PE
14663 * lisp.h (get_system_name, get_operating_system_release):
14664 Move decls here, to check interfaces.
14665 * process.c (get_operating_system_release): Move decl to lisp.h.
14666 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
14667 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
14668 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
14669 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
14670 (Fformat_time_string, Fencode_time, Finsert_char):
14671 (Ftranslate_region_internal, Fformat):
14672 Rename or remove local vars to avoid shadowing.
9710023e 14673 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 14674
a415e694
PE
14675 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
14676 avoid shadowing.
14677
8ef4622d
PE
14678 * lisp.h (eassert): Check that the argument compiles, even if
14679 ENABLE_CHECKING is not defined.
14680
946f9a5b
PE
14681 * data.c (Findirect_variable): Name an expression, to avoid
14682 gcc -Wbad-function-cast warning.
112396d6 14683 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 14684 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
14685 (Fmake_variable_buffer_local, Fmake_local_variable):
14686 Mark variables as initialized.
52746918 14687 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 14688
e5aab7e7 14689 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
14690 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
14691 Rename locals to avoid shadowing.
dff45157
PE
14692 (mark_stack): Move local variables into the #ifdef region where
14693 they're used.
7bc26fdb
PE
14694 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
14695 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
14696 needed otherwise.
14697 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
14698 (GC_STRING_CHARS): Remove; not used.
d40d4be1 14699 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 14700
e5aab7e7
PE
14701 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
14702 avoids undefined behavior in theory.
14703
4da60324
PE
14704 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
14705
88043301
PE
14706 Use functions, not macros, for up- and down-casing (Bug#8254).
14707 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14708 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
14709 to use the following functions instead of these macros.
14710 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
14711 EMACS_INT, since callers assume the returned value fits in int.
14712 (upcase1): Likewise, for UPCASE_TABLE.
14713 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 14714 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 14715 the race-condition problem in the old DOWNCASE.
88043301 14716
19ed5445
PE
14717 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
14718 Rename locals to avoid shadowing.
14719 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
14720 (regex_compile, re_search_2, re_match_2_internal):
14721 Remove unused local vars.
952db0d7
PE
14722 (FREE_VAR): Rewrite so as not to use empty "else",
14723 which gcc can warn about.
da053e48 14724 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
14725 (RETALLOC_IF): Define only if needed.
14726 (WORDCHAR_P): Likewise. This one is never needed, but is used
14727 only in a comment talking about a compiler bug, so put inside
14728 the #if 0 of that comment.
14729 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
14730 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
14731 Remove; unused.
19ed5445 14732
1f3561e4 14733 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
14734 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
14735 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 14736
ded6f8f7
PE
14737 * search.c (simple_search): Remove unused var.
14738
dbd37a95
PE
14739 * dired.c (compile_pattern): Move decl from here ...
14740 * lisp.h: ... to here, so that it can be checked.
14741 (struct re_registers): New forward decl.
14742
7e47afad
PE
14743 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
14744
85f24f61
PE
14745 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
14746 All uses changed.
14747 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
14748 Rename locals to avoid shadowing.
5671df8f 14749 (Fvertical_motion): Mark locals as initialized.
85f24f61 14750
181aa2be 14751 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 14752 (casify_region): Mark local as initialized.
181aa2be 14753
930d429c
PE
14754 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
14755
7082eac6
PE
14756 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
14757 New macros, so that the caller can use some names other than
14758 gcpro1, gcpro2, etc.
14759 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
14760 of the new macros.
14761 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
14762 argument, for consistency with GCPRO2_VAR, etc: it is now the
14763 prefix of the variable, not the variable itself. All uses
14764 changed.
38b2c076
PE
14765 * dired.c (directory_files_internal, file_name_completion):
14766 Rename locals to avoid shadowing.
14767
15206ed9
PE
14768 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
14769 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
14770 dired.c's scmp function, had undefined behavior.
14771 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
14772 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
14773 * buffer.h: ... to here, because these macros use current_buffer,
14774 and the new implementation with inline functions needs to have
14775 current_buffer in scope now, rather than later when the macros
14776 are used.
14777 (downcase, upcase1): New static inline functions.
14778 (DOWNCASE, UPCASE1): Reimplement using these functions.
14779 This avoids undefined behavior in expressions like
14780 DOWNCASE (x) == DOWNCASE (y), which previously suffered
14781 from race conditions in accessing the global variables
14782 case_temp1 and case_temp2.
14783 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
14784 * lisp.h (case_temp1, case_temp2): Remove their decls.
14785 * character.h (ASCII_CHAR_P): Move from here ...
14786 * lisp.h: ... to here, so that the inline functions mentioned
14787 above can use them.
14788
4a6bea26
PE
14789 * dired.c (directory_files_internal_unwind): Now static.
14790
f14b7e14
PE
14791 * fileio.c (file_name_as_directory, directory_file_name):
14792 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14793 Now static.
2893f146
PE
14794 (file_name_as_directory): Use const pointers when appropriate.
14795 (Fexpand_file_name): Likewise. In particular, newdir might
14796 point at constant storage, so make it a const pointer.
fd4ead52 14797 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14798 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14799 signedness issues.
f839df0c
PE
14800 (Fset_file_times, Finsert_file_contents, auto_save_error):
14801 Rename locals to avoid shadowing.
f14b7e14 14802
5716756e 14803 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14804 (Ftry_completion, Fall_completions): Rename or remove locals
14805 to avoid shadowing.
5716756e 14806
b4c3046a
PE
14807 * marker.c (bytepos_to_charpos): Remove; unused.
14808
b45db522
PE
14809 * lisp.h (verify_bytepos, count_markers): New decls,
14810 so that gcc does not warn that these functions aren't declared.
14811
85876d07
PE
14812 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14813 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14814 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14815 (copy_text): Remove unused local var.
85876d07 14816
03d78a21 14817 * filelock.c (within_one_second): Now static.
b3dd38ab 14818 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14819
5df8f01b
PE
14820 * buffer.c (fix_overlays_before): Mark locals as initialized.
14821 (fix_start_end_in_overlays): Likewise. This function should be
14822 simplified by using pointers-to-pointers, but that's a different
14823 matter.
b1d876f1 14824 (switch_to_buffer_1): Now static.
8f54f30a
PE
14825 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14826 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14827
a70072c9 14828 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14829 Fix pointer signedness issue.
edced198
PE
14830 (sys_subshell): Mark local as volatile if checking for lint,
14831 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14832 (MAXPATHLEN): Define only if needed.
a70072c9 14833
a0977c44
PE
14834 * process.c (serial_open, serial_configure): Move decls from here ...
14835 * systty.h: ... to here, so that they can be checked.
14836
a884fdcc
PE
14837 * fns.c (get_random, seed_random): Move extern decls from here ...
14838 * lisp.h: ... to here, so that they can be checked.
14839
604efe86 14840 * sysdep.c (reset_io): Now static.
b8950c94 14841 (wait_for_termination_signal): Remove; unused.
604efe86 14842
38fc62d9
PE
14843 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14844 (copy_keymap_item, append_key, push_text_char_description):
14845 Now static.
1004a21a 14846 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14847 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14848 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14849 (describe_map_tree):
14850 Rename locals to avoid shadowing.
38fc62d9 14851
2f2650da
PE
14852 * keyboard.c: Declare functions static if they are not used elsewhere.
14853 (echo_char, echo_dash, cmd_error, top_level_2):
14854 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14855 (read_char, kbd_buffer_get_event, make_lispy_position):
14856 (make_lispy_event, make_lispy_movement, apply_modifiers):
14857 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14858 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14859 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14860 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14861 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14862
a053e86c 14863 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14864 (mark_kboards): Move decl here ...
14865 * alloc.c (mark_kboards): ... from here.
a053e86c 14866
4752793e
PE
14867 * lisp.h (force_auto_save_soon): New decl.
14868
74f10ca7 14869 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14870 (DEFINE_DUMMY_FUNCTION): New macro.
14871 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14872 Use it.
c03cd23f
PE
14873 (main): Add casts to avoid warnings
14874 if GCC considers string literals to be constants.
74f10ca7 14875
022e70d4
PE
14876 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14877
59d6fe83
PE
14878 * dbusbind.c: Pointer signedness fixes.
14879 (xd_signature, xd_append_arg, xd_initialize):
14880 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14881 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14882 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14883 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14884
78320123
PE
14885 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14886 if GCC considers string literals to be constants.
49cebcca 14887 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14888
35ac2a97
SM
148892011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14890
fb103ca9
SM
14891 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14892 (print_preprocess, print_object): New macro to fix last change.
14893
35ac2a97
SM
14894 * print.c (print_preprocess): Don't forget font objects.
14895
62973b41
JB
148962011-03-16 Juanma Barranquero <lekktu@gmail.com>
14897
14898 * emacs.c (USAGE3): Doc fixes.
14899
0e48bb22
AS
149002011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14901
14902 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14903 structure.
14904
7684e57b
JB
149052011-03-14 Juanma Barranquero <lekktu@gmail.com>
14906
14907 * lisp.h (VWindow_system, Qfile_name_history):
14908 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14909 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14910 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14911
14912 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14913 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14914
14915 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14916 * w32console.c (detect_input_pending, read_input_pending)
14917 (encode_terminal_code):
14918 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14919 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14920 (w32_system_caret_y, Qfile_name_history):
14921 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14922 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14923 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14924 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14925 * w32proc.c (Qlocal, report_file_error):
14926 * w32term.c (Vwindow_system, updating_frame):
14927 * w32uniscribe.c (initialized, uniscribe_font_driver):
14928 Remove unneeded extern declarations.
14929
2aa46d6c
CY
149302011-03-14 Chong Yidong <cyd@stupidchicken.com>
14931
c96bbc66 14932 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14933
cffc6f3b
CY
149342011-03-13 Chong Yidong <cyd@stupidchicken.com>
14935
14936 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14937 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14938 These macros can no longer be used for assignment.
14939
44f230aa
SM
14940 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14941 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14942 (record_buffer_markers, fetch_buffer_markers): New functions for
14943 recording and fetching special buffer markers.
14944 (set_buffer_internal_1, set_buffer_temp): Use them.
14945
14946 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14947
14948 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14949
14950 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14951 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14952
14953 * xdisp.c (hscroll_window_tree):
14954 (reconsider_clip_changes): Use PT instead of BUF_PT.
14955
d251f04b
EZ
149562011-03-13 Eli Zaretskii <eliz@gnu.org>
14957
14958 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14959 $(EMACS_ROOT)/lib/intprops.h.
14960
f0c77cd1
PE
149612011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14962
3eca4629
PE
14963 Fix more problems found by GCC 4.5.2's static checks.
14964
7c86ee98
PE
14965 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14966 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14967 (xg_free_frame_widgets): Make it clear that a local variable is
14968 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14969 (gdk_window_get_screen): Make it clear that this macro is needed
14970 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14971 (int_gtk_range_get_value): New function, which avoids a diagnostic
14972 from gcc -Wbad-function-cast.
14973 (xg_set_toolkit_scroll_bar_thumb): Use it.
14974 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14975 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14976 (get_utf8_string, xg_get_file_with_chooser):
14977 Rename locals to avoid shadowing.
14978 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14979
41729b81
PE
14980 * xgselect.c (xg_select): Remove unused var.
14981
f0c77cd1
PE
14982 * image.c (four_corners_best): Mark locals as initialized.
14983 (gif_load): Initialize transparent_p to zero (Bug#8238).
14984 Mark another local as initialized.
ec6cf4c6 14985 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14986
ce0ad53d 14987 * image.c (clear_image_cache): Now static.
d5d5a617 14988 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14989 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14990 (x_edge_detection): Remove unnecessary cast that
14991 gcc -Wbad-function-cast diagnoses.
2037898d 14992 (gif_load): Fix pointer signedness.
6ae141d6
PE
14993 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14994 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14995
33383987 149962011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14997
d32df629
PE
14998 Improve quality of tests for time stamp overflow.
14999 For example, without this patch (encode-time 0 0 0 1 1
15000 1152921504606846976) returns the obviously-bogus value (-948597
15001 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
15002 reports time overflow. See
15003 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
15004 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
15005 * editfns.c: Include limits.h and intprops.h.
15006 (TIME_T_MIN, TIME_T_MAX): New macros.
15007 (time_overflow): Move earlier, to before first use.
15008 (hi_time, lo_time): New functions, for an accurate test for
15009 out-of-range times.
15010 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
15011 (Fget_internal_run_time): Don't assume time_t fits in int.
15012 (make_time): Use list2 instead of Fcons twice.
15013 (Fdecode_time): More accurate test for out-of-range times.
15014 (check_tm_member): New function.
15015 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
15016 (lisp_time_argument): Don't rely on undefined left-shift and
15017 right-shift behavior when checking for time stamp overflow.
8be6f318 15018
fe31d94c
PE
15019 * editfns.c (time_overflow): New function, refactoring common code.
15020 (Fformat_time_string, Fdecode_time, Fencode_time):
15021 (Fcurrent_time_string): Use it.
15022
8be6f318
PE
15023 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
15024 * dired.c (make_time): Move to ...
15025 * editfns.c (make_time): ... here.
15026 * systime.h: Note the move.
15027
09d9db2c 150282011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 15029
126bc0dc
YM
15030 * fringe.c (update_window_fringes): Remove unused variables.
15031
c47cbdfd
YM
15032 * unexmacosx.c (copy_data_segment): Also copy __got section.
15033 (Bug#8223)
15034
7ac80be9
EZ
150352011-03-12 Eli Zaretskii <eliz@gnu.org>
15036
c96bbc66 15037 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
15038 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
15039 Constify `char *' arguments and their references according to
15040 prototypes in tparam.h.
15041
ecb0f94d 15042 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 15043
7ac80be9
EZ
15044 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
15045 Adapt all references accordingly.
15046
15047 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
15048
ef1fd07e
TT
150492011-03-11 Tom Tromey <tromey@redhat.com>
15050
15051 * buffer.c (syms_of_buffer): Remove obsolete comment.
15052
7ef4b50c
EZ
150532011-03-11 Eli Zaretskii <eliz@gnu.org>
15054
15055 * termhooks.h (encode_terminal_code): Declare prototype.
15056
15057 * msdos.c (encode_terminal_code): Don't declare prototype.
15058
15059 * term.c (encode_terminal_code): Now external again, used by
15060 w32console.c and msdos.c.
15061
44f230aa
SM
15062 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
15063 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 15064
4b1ec863 150652011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 15066
1714f52b 15067 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 15068
4b1ec863
PE
15069 * fringe.c (update_window_fringes): Mark locals as initialized
15070 (Bug#8227).
15071 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 15072
524c7aa6
PE
15073 * alloc.c (mark_fringe_data): Move decl from here ...
15074 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
15075 to check its interface.
15076 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
15077
a5c0af81 15078 * fontset.c (free_realized_fontset): Now static.
7519b8cd 15079 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 15080 (fontset_font): Mark local as initialized.
a9a06e0b 15081 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 15082
b4716021
PE
15083 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
15084
811e9bac 15085 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 15086 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
15087 (x_own_selection, Fx_disown_selection_internal): Rename locals
15088 to avoid shadowing.
15089 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 15090
7e3ab302
PE
15091 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
15092 so that the caller can use some name other than gcpro1.
15093 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
15094 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15095 (Fx_backspace_delete_keys_p):
15096 Use them to avoid shadowing, and rename vars to avoid shadowing.
15097 (x_decode_color, x_set_name, x_window): Now static.
6b437900 15098 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 15099 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
15100 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
15101 Remove unused locals.
7e3ab302
PE
15102 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
15103 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
15104 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
15105 macros.
f78faa98 15106
e2b13473
PE
15107 * xterm.h (x_mouse_leave): New decl.
15108
77f23912
PE
15109 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
15110 Remove unused functions.
cdf4ba58
PE
15111 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
15112 (x_calc_absolute_position): Now static.
7411c686 15113 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 15114 Don't declare local "event" unless it's used.
ed7bf3a5
PE
15115 (x_iconify_frame, x_free_frame_resources): Don't declare locals
15116 unless they are used.
38d0b34a
PE
15117 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
15118 (x_fatal_error_signal): Remove; not used.
a6067996
PE
15119 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
15120 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
15121 (x_error_catcher, x_connection_closed, x_error_handler):
15122 (x_error_quitter, xembed_send_message, x_iconify_frame):
15123 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 15124 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 15125 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 15126
44f230aa
SM
15127 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
15128 Rename or move locals to avoid shadowing.
6b463e58 15129 (tty_defined_color, merge_face_heights): Now static.
5967d051 15130 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
15131 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
15132 does not deduce is never used uninitialized.
73719eba
PE
15133 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
15134 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 15135
426994c3 15136 * terminal.c (store_terminal_param): Now static.
5489860b 15137
032f1620 15138 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 15139 (set_frame_menubar): Remove unused local.
d4323972 15140 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
15141 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
15142 since they might point to immutable storage.
281585b0
PE
15143 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
15144 since it's unused otherwise.
032f1620 15145
367c19e5 15146 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 15147 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
15148 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
15149 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 15150 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
15151 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
15152 does not deduce are never used uninitialized.
70739cbe 15153
07b48fa9
PE
15154 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
15155
8868a238 15156 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
15157 * window.c (window_loop, size_window):
15158 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 15159
7e5cf297 15160 * window.c (display_buffer): Now static.
d6550a9f
PE
15161 (size_window): Mark variables that gcc -Wuninitialized
15162 does not deduce are never used uninitialized.
a586633d
PE
15163 * window.h (check_all_windows): New decl, to forestall
15164 gcc -Wmissing-prototypes diagnostic.
5b555da1 15165 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 15166
f6095868
PE
15167 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
15168 shadowing.
15169 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
15170 Include <limits.h>.
15171 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
15172 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
15173 (load_charset_map): Mark variables that gcc -Wuninitialized
15174 does not deduce are never used uninitialized.
53df7c11 15175 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 15176
f38b440c
PE
15177 * coding.c (coding_set_source, coding_set_destination):
15178 Use "else { /* comment */ }" rather than "else /* comment */;"
15179 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
15180 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
15181 a block, when the outer 'i' will do.
15182 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
15183 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
15184 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
15185 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
15186 (Fdecode_sjis_char, Fdefine_coding_system_internal):
15187 Rename locals to avoid shadowing.
15188 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
15189 * coding.c (emacs_mule_char, encode_invocation_designation):
15190 Now static, since they're not used elsewhere.
413bb2db 15191 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 15192 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
15193 (decode_coding_emacs_mule): Mark variables that gcc
15194 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
15195 (detect_coding_iso_2022): Initialize a local variable that might
15196 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 15197 this initialization is needed. (Bug#8211)
5f58e762
PE
15198 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
15199 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
15200 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
15201 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
15202 Remove unused macros.
f38b440c 15203
232b38b9 15204 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 15205 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 15206 * character.c (string_count_byte8): Likewise.
232b38b9 15207
fb90da1b
PE
15208 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
15209 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
15210
fb93dbc2
PE
15211 * chartab.c (copy_sub_char_table): Now static, since it's not used
15212 elsewhere.
5c156ace
PE
15213 (sub_char_table_ref_and_range, char_table_ref_and_range):
15214 Rename locals to avoid shadowing.
bbcd0949 15215 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 15216
7d3b3862 15217 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 15218 (BIDI_BOB): Remove unused macro.
7d3b3862 15219
6be7d3da
PE
15220 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
15221 deduce are never used uninitialized.
c2ed9c8b 15222 * term.c (encode_terminal_code): Likewise.
6be7d3da 15223
75f8807f 15224 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 15225
50938595
PE
15226 * tparam.h: New file.
15227 * term.c, tparam.h: Include it.
15228 * deps.mk (term.o, tparam.o): Depend on tparam.h.
15229 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
15230 Move these decls to tparam.h, and make them agree with what
15231 is actually in tparam.c. The previous trick of using incompatible
15232 decls in different modules does not conform to the C standard.
15233 All callers of tparam changed to use tparam's actual API.
15234 * tparam.c (tparam1, tparam, tgoto):
15235 Use const pointers where appropriate.
15236
fbceeba2
PE
15237 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
15238 * cm.h (struct cm): Likewise.
15239 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
15240 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
15241 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
15242 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
15243 (turn_on_face, init_tty): Likewise.
15244 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 15245
7f3f1250
PE
15246 * term.c (term_mouse_position): Rename local to avoid shadowing.
15247
e6ca6543
PE
15248 * alloc.c (mark_ttys): Move decl from here ...
15249 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
15250
c40f8d15
AS
152512011-03-11 Andreas Schwab <schwab@linux-m68k.org>
15252
15253 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
15254
cfe0661d
JB
152552011-03-09 Juanma Barranquero <lekktu@gmail.com>
15256
15257 * search.c (compile_pattern_1): Remove argument regp, unused since
15258 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
15259 (compile_pattern): Don't pass it.
15260
0afb4571
J
152612011-03-08 Jan Djärv <jan.h.d@swipnet.se>
15262
15263 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
15264 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
15265 for ! HAVE_GTK3.
15266 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
15267
15268 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
15269
15270 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
15271 gdk_window_get_screen, gdk_window_get_geometry,
15272 gdk_x11_window_lookup_for_display and GDK_KEY_g.
15273 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
15274 (xg_get_pixbuf_from_pixmap): New function.
15275 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
15276 to Pixmap, take frame as parameter, remove GdkColormap parameter.
15277 Call xg_get_pixbuf_from_pixmap instead of
15278 gdk_pixbuf_get_from_drawable.
15279 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
15280 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
15281 (xg_check_special_colors): Use GtkStyleContext and its functions
15282 for HAVE_GTK3.
15283 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
15284 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
15285 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
15286 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
15287 Call gtk_widget_get_preferred_size.
0afb4571
J
15288 (xg_frame_resized): gdk_window_get_geometry only takes 5
15289 parameters.
44f230aa
SM
15290 (xg_win_to_widget, xg_event_is_for_menubar):
15291 Call gdk_x11_window_lookup_for_display.
0afb4571
J
15292 (xg_set_widget_bg): New function.
15293 (delete_cb): New function.
895009e1 15294 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 15295 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
15296 (xg_set_background_color): Call xg_set_widget_bg.
15297 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
15298 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
15299 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
15300 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
15301 if ! HAVE_GTK3.
15302 (update_frame_tool_bar): Call gtk_widget_hide.
15303 (xg_initialize): Use GDK_KEY_g.
15304
15305 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
15306 if ! HAVE_GTK3
15307 (x_session_initialize): Call gdk_x11_set_sm_client_id.
15308
15309 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
15310 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
15311 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
15312
1c2cc4ef
JB
153132011-03-08 Juanma Barranquero <lekktu@gmail.com>
15314
15315 * w32xfns.c (select_palette): Check success of RealizePalette against
15316 GDI_ERROR, not zero.
15317
33383987 15318See ChangeLog.11 for earlier changes.
aac0c6e3
MR
15319
15320;; Local Variables:
15321;; coding: utf-8
aac0c6e3
MR
15322;; End:
15323
2f097256 15324 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
15325
15326 This file is part of GNU Emacs.
15327
15328 GNU Emacs is free software: you can redistribute it and/or modify
15329 it under the terms of the GNU General Public License as published by
15330 the Free Software Foundation, either version 3 of the License, or
15331 (at your option) any later version.
15332
15333 GNU Emacs is distributed in the hope that it will be useful,
15334 but WITHOUT ANY WARRANTY; without even the implied warranty of
15335 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
15336 GNU General Public License for more details.
15337
15338 You should have received a copy of the GNU General Public License
15339 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.