Simplify lisp.h in minor ways that should not affect code.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2b570124
PE
12012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2
3 Simplify lisp.h in minor ways that should not affect code.
4 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
5 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
6 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
7 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
8 (INTTYPEBITS): New macro, for clarity.
9 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
10 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
11 now that USE_LSB_TAG is always defined.
12 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
13 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
14
81755f69
JB
152012-06-13 Juanma Barranquero <lekktu@gmail.com>
16
17 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
18
16192a57
GM
192012-06-13 Glenn Morris <rgm@gnu.org>
20
21 * s/bsd-common.h (BSD4_3):
22 * s/usg5-4-common.h (USG5_4): No longer define; unused.
23
646b5f55
AS
242012-06-13 Andreas Schwab <schwab@linux-m68k.org>
25
26 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
27 instead of union.
28 (XLI, XIL): Define.
29 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
30 them.
31 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
32 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
33 * alloc.c (widen_to_Lisp_Object): Removed.
34 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
35 * frame.c (delete_frame): Remove outdated comment.
36 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
37 USE_LISP_UNION_TYPE.
38 (Fw32_unregister_hot_key): Likewise.
39 (Fw32_toggle_lock_key): Likewise.
40 * w32menu.c (add_menu_item): Likewise.
41 (w32_menu_display_help): Use XIL instead of checking
42 USE_LISP_UNION_TYPE.
43 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
44 (init_heap): Likewise.
45 * w32term.c (w32_read_socket): Update comment.
46
1d3823c9
GM
472012-06-13 Glenn Morris <rgm@gnu.org>
48
c62ff706
GM
49 * s/usg5-4-common.h, src/s/unixware.h:
50 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
51
1d3823c9
GM
52 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
53
bfe3e0a2
PE
542012-06-13 Paul Eggert <eggert@cs.ucla.edu>
55
56 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
57 * alloc.c (make_number) [!defined make_number]:
58 Remove, as lisp.h always defines this now.
59 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
60 (roundup_size): Verify that it is a power of 2.
61 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
62 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
63 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
64 -DUSE_LSB_TAG=0, to override the automatically-selected default.
65 USE_LSB_TAG now is always defined to be either 0 or 1.
66 All uses changed.
67 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
68 code works fine either way, and efficiency is not a concern here,
69 as the union type is for debugging, not for production.
70 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
71 Use an inline function on all platforms when using the union type,
72 since this is simpler and 'static inline' can be used portably
73 within Emacs now.
74 (LISP_INITIALLY_ZERO): New macro.
75 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
76 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
77
45fa9c0f
GM
782012-06-12 Glenn Morris <rgm@gnu.org>
79
b4492cba
GM
80 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
81
82 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 83
45fa9c0f
GM
84 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
85 Move BROKEN_SIGIO to configure.
86
87 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
88 Move NO_TERMIO to configure.
89
0e25d334
CY
902012-06-12 Chong Yidong <cyd@gnu.org>
91
92 * image.c (imagemagick_load_image): Use MagickFlattenImage if
93 MagickMergeImageLayers is undefined. Use pixel pusher loop if
94 MagickExportImagePixels is undefined.
95
43682bb6
PE
962012-06-12 Paul Eggert <eggert@cs.ucla.edu>
97
98 * image.c (imagemagick_load_image): Remove unused label.
99
a9be7d2b
GM
1002012-06-11 Glenn Morris <rgm@gnu.org>
101
102 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
103 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
104 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
105 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
106
3017f87f
SM
1072012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
108
109 * alloc.c (make_byte_code): New function.
110 (Fmake_byte_code): Use it. Don't purify here.
111 * lread.c (read1): Use it as well to avoid extra allocation.
112
1b9b4cf4
CY
1132012-06-11 Chong Yidong <cyd@gnu.org>
114
115 * image.c (imagemagick_load_image): Implement transparency.
116
95988fcf
AS
1172012-06-10 Andreas Schwab <schwab@linux-m68k.org>
118
119 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
120 account for preceding backslashes. (Bug#11663)
121
cd4eb164
CY
1222012-06-09 Chong Yidong <cyd@gnu.org>
123
124 * term.c: Support italics in capable terminals (Bug#9652).
125 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
126 (turn_on_face): Output using TS_enter_italic_mode if available.
127 Don't handle unused blinking and alt-charset cases.
128 (turn_off_face): Handle italic case; discard unused tty_blinking_p
129 and tty_alt_charset_p cases.
130 (tty_capable_p, init_tty): Support italics.
131
132 * termchar.h (struct tty_display_info): Add field for italics.
133 Remove unused blink field.
134
135 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
136 Handle slant.
137
138 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
139 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
140 tty_alt_charset_p. Add tty_italic_p.
141
ff88beb8
MA
1422012-06-09 Michael Albinus <michael.albinus@gmx.de>
143
144 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
145 dbus_type_is_basic if available.
146 (xd_extract_signed, xd_extract_unsigned): Rename from
147 extract_signed and extract_unsigned, respectively. Adapt callers.
148
44286096
CY
1492012-06-09 Chong Yidong <cyd@gnu.org>
150
1682701f
CY
151 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
152
44286096
CY
153 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
154 case (Bug#9752).
155
d86feb17
PE
1562012-06-08 Paul Eggert <eggert@cs.ucla.edu>
157
158 * xdisp.c (vmessage): Treat frame message as multibyte.
159 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
160 would generate the diagnostic "Making \302\247 buffer-local while
161 let-bound!".
162
d5c20fe8
EZ
1632012-06-08 Eli Zaretskii <eliz@gnu.org>
164
165 * dispnew.c (showing_window_margins_p): Undo last change, which
166 was done due to an inadvertent commit.
167 (adjust_frame_glyphs_for_frame_redisplay): Do call
168 showing_window_margins_p.
169
513749ee
SM
1702012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
171
172 * eval.c (Fmake_var_non_special): New primitive.
173 (syms_of_eval): Defsubr it.
174 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
175
d4a8f5c1
JB
1762012-06-08 Juanma Barranquero <lekktu@gmail.com>
177
178 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
179 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
180
8bbbc977
EZ
1812012-06-08 Eli Zaretskii <eliz@gnu.org>
182
183 * alloc.c (allocate_vectorlike): Fix last change.
184
f3372c87
DA
1852012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
186
187 Block-based vector allocation of small vectors.
188 * lisp.h (struct vectorlike_header): New field `nbytes',
189 adjust comment accordingly.
190 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
191 to denote vector blocks. Adjust users (live_vector_p,
192 mark_maybe_pointer, valid_lisp_object_p) accordingly.
193 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
194 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
195 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
196 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
197 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
198 (roundup_size): New constant.
199 (struct vector_block): New data type.
200 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 201 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
202 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
203 (sweep_vectors): New functions.
204 (allocate_vectorlike): Return `zero_vector' as the only vector of
205 0 items. Allocate new vector from block if vector size is less than
206 or equal to VBLOCK_BYTES_MAX.
207 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
208 (init_alloc_once): Add call to init_vectors.
209
4f18a4ed
SM
2102012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
211
212 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
213
86f158bc
PE
2142012-06-07 Paul Eggert <eggert@cs.ucla.edu>
215
216 * doprnt.c (doprnt): Truncate multibyte char correctly.
217 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
218 would mishandle a string argument "Xc" if X was a multibyte
219 character of length 2: it would truncate after X's first byte
220 rather than including all of X.
221
c5cfcbe0
CY
2222012-06-06 Chong Yidong <cyd@gnu.org>
223
224 * buffer.c (word_wrap): Doc fix.
225
c05cf390
PE
2262012-06-04 Paul Eggert <eggert@cs.ucla.edu>
227
228 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
229
0c3461de
GM
2302012-06-03 Glenn Morris <rgm@gnu.org>
231
232 * xdisp.c (tool-bar-style): Doc fix.
233
c71232db
UM
2342012-06-03 Ulrich Müller <ulm@gentoo.org>
235
236 * Makefile.in (PAXCTL): Define.
237 (temacs$(EXEEXT)): Disable memory randomization for the temacs
238 binary via PaX flags if the paxctl utility is available.
239 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
240 Restore PaX flags to their default. (Bug#11398)
241
383f7350
CY
2422012-06-03 Chong Yidong <cyd@gnu.org>
243
244 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
245 buffer (Bug#11226).
246
5f2c76c6
CY
2472012-06-03 Chong Yidong <cyd@gnu.org>
248
249 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
250 (note_mode_line_or_margin_highlight): If there is no help echo,
251 use mode-line-default-help-echo. Handle the case where the mouse
252 position is past the end of the mode line string.
253
254 * buffer.c (buffer_local_value_1): New function, split from
255 Fbuffer_local_value; can return Qunbound.
256 (Fbuffer_local_value): Use it.
257 (Vmode_line_format): Docstring tweaks.
258
773d47f6
PE
2592012-06-02 Paul Eggert <eggert@cs.ucla.edu>
260
261 * sysdep.c (system_process_attributes): Improve comment.
262
f2d6a3df
SM
2632012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
264
265 * keyboard.c: Export real-this-command to Elisp.
266 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
267 and DEFVAR it. Update all users.
268
63810350
PE
2692012-06-02 Paul Eggert <eggert@cs.ucla.edu>
270
7bd5c1f4
PE
271 * minibuf.c (Fassoc_string): Remove duplicate declaration.
272
63810350
PE
273 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
274 Convert pctcpu and pctmem to Lisp float properly.
275 Let the compiler fold better, as 100.0/0x8000 is exact.
276
a2821611
AS
2772012-06-02 Andreas Schwab <schwab@linux-m68k.org>
278
279 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
280 cons_block.
281
5fceba1d
PE
2822012-06-01 Paul Eggert <eggert@cs.ucla.edu>
283
284 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
285
c98ff5dd
DA
2862012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
287
288 For a 'struct window', replace some Lisp_Object fields to
289 bitfields where appropriate, remove unused fields.
290 * window.h (struct window): Remove unused 'last_mark_x' and
291 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
292 change it's type from Lisp_Object to bitfield.
293 Change type of 'force_start', 'optional_new_start',
294 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
295 fields from Lisp_Object to bitfield. Adjust users accordingly.
296
ca34e0be
PE
2972012-05-31 Paul Eggert <eggert@cs.ucla.edu>
298
299 Pacify gcc -Wdouble-precision when using Xaw.
300 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
301 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
302 Use 'float' consistently, rather than 'float' in most places
303 and 'double' in a couple of places.
304
efc00ab1 3052012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
306
307 * xdisp.c (handle_stop): Detect whether we have overlay strings
308 loaded by testing it->current.overlay_string_index to be
309 non-negative, instead of checking whether n_overlay_strings is
310 positive. (Bug#11587)
311
efc00ab1 3122012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
313
314 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
315
316 * doc.c (Fsubstitute_command_keys): Doc fix.
317
efc00ab1 3182012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
319
320 * search.c (search_buffer): Remove calls to
321 r_alloc_inhibit_buffer_relocation, as it is now called by
322 maybe_unify_char, which was the cause of relocation of buffer text
323 in bug#11519.
324
efc00ab1 3252012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
326
327 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
328 for the duration of call to load_charset, to avoid problems with
329 callers of maybe_unify_char that access buffer text through C
330 pointers.
331
332 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
333 decrement the inhibition flag, instead of just setting or
334 resetting it.
335
ba93a187
PE
3362012-05-31 Paul Eggert <eggert@cs.ucla.edu>
337
338 Remove obsolete '#define static' cruft.
339 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
340 This #undef was "temporary" in 2000; it is no longer needed
341 now that '#define static' has gone away.
342 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
343 (gray_bitmap_bits): Remove; no longer needed.
344 All uses replaced with definiens.
345 * xterm.c: Include "bitmaps/gray.xbm".
346
9e4bf381
PE
3472012-05-30 Paul Eggert <eggert@cs.ucla.edu>
348
349 Clean up __executable_start, monstartup when --enable-profiling.
350 The following changes affect the code only when profiling.
351 * dispnew.c (__executable_start): Rename from safe_bcopy.
352 Define only on platforms that need it.
353 * emacs.c: Include <sys/gmon.h> when profiling.
354 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
355 (__executable_start): Remove decl, since lisp.h does it now.
356 (safe_bcopy): Remove decl; no longer has that name.
357 (main): Coalesce #if into single bit of code, for simplicity.
358 Cast pointers to uintptr_t, since standard libraries want integers
359 and not pointers.
360 * lisp.h (__executable_start): New decl.
361
32d72c2f
GM
3622012-05-31 Glenn Morris <rgm@gnu.org>
363
364 * image.c (Fimagemagick_types): Doc fix.
365
baac5bc7
JM
3662012-05-30 Jim Meyering <meyering@redhat.com>
367
368 * callproc.c (Fcall_process_region): Include directory component
369 in mkstemp error message (Bug#11586).
370
72cb32cf
PE
3712012-05-30 Paul Eggert <eggert@cs.ucla.edu>
372
373 * alloc.c, lisp.h (make_pure_vector): Now static.
374
61b108cc
SM
3752012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
376
377 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
378 Move to byte-run.el.
379 (Fautoload): Do the hash-doc more carefully.
380 * data.c (Fdefalias): Purify definition, except for keymaps.
381 (Qdefun): Move from eval.c.
382 * lisp.h (Qdefun): Remove.
383 * lread.c (read1): Tiny simplification.
384
471fe23d
TN
3852012-05-29 Troels Nielsen <bn.troels@gmail.com>
386
934f3f58 387 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
388 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
389 Bug#9642, but explicitly check that the buffer the overlay would
390 be moved to is live and rearrange lines to make sure that errors
391 will not put the overlay in an inconsistent state.
392 (Fdelete_overlay): Cosmetics.
393
85d0efd1
EZ
3942012-05-28 Eli Zaretskii <eliz@gnu.org>
395
396 * w32term.c (my_bring_window_to_top): New function.
397 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
398 could be different from the original one.
399 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
400 (Bug#11513)
401
402 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
403 by calling BringWindowToTop.
404
405 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
406 (WM_EMACS_END): Increase by one.
407
da92a98c
PE
4082012-05-28 Paul Eggert <eggert@cs.ucla.edu>
409
410 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
411 This avoids undefined behavior that might cause the eassert
412 to not catch an out-of-range value.
413
74d1f848
JB
4142012-05-28 Juanma Barranquero <lekktu@gmail.com>
415
416 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
417 Update dependencies.
418
9e1a06fc
EZ
4192012-05-27 Eli Zaretskii <eliz@gnu.org>
420
421 * bidi.c (bidi_mirror_char): Fix last change.
422
f3dd7312
AS
4232012-05-27 Andreas Schwab <schwab@linux-m68k.org>
424
425 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
426 when referring to sectname field in printf format.
427
81899c91
PE
4282012-05-27 Paul Eggert <eggert@cs.ucla.edu>
429
57b81a9f
PE
430 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
431 Only r_alloc_inhibit_buffer_relocation needed to be added;
432 the others were already declared.
433
81899c91
PE
434 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
435 before checking whether it's out of range. Put the check inside
436 eassert. See
437 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
438
33017faf 4392012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
440
441 * callproc.c (Fcall_process): Restore a line that was accidentally
442 commented out in the 2011-02-13 change (bug#11547).
443
33017faf 4442012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
445
446 * lisp.h [REL_ALLOC]: Add prototypes for external functions
447 defined on ralloc.c.
448
449 * buffer.c [REL_ALLOC]: Remove prototypes of
450 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
451 they are now on lisp.h.
452
453 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
454
455 * search.c (search_buffer): Use it to inhibit relocation of buffer
456 text while re_search_2 is doing its job, because re_search_2 is
457 passed C pointers to buffer text. (Bug#11519)
458
23415acf
EZ
459 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
460 Update value to 24.
461
44e27368
EZ
462 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
463 state after an additional call to move_it_in_display_line_to, keep
464 the values of it->max_ascent and it->max_descent found for the
465 entire line.
466 (pos_visible_p): Revert the comparison against bottom_y to what it
467 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
468 (Bug#11464)
469
c1892f11
PE
4702012-05-26 Paul Eggert <eggert@cs.ucla.edu>
471
472 Fix coding-related core dumps with gcc -ftrapv.
473 The code was computing A - B, where A and B are pointers, and B is
474 random garbage. This can lead to core dumps on platforms that
475 have special pointer registers, and it also leads to core dumps on
476 x86-64 when compiled with gcc -ftrapv. The fix is to compute
477 A - B only when B is initialized properly.
478 * coding.c (coding_set_source, coding_set_destination): Return void.
479 (coding_change_source, coding_change_destinations): New functions,
480 with the old behaviors of coding_set_source and coding_set_destination.
481 All callers that need an offset changed to use these new functions.
482
eb7afdad
GM
4832012-05-26 Glenn Morris <rgm@gnu.org>
484
485 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
486
f12fdf02
EZ
4872012-05-26 Eli Zaretskii <eliz@gnu.org>
488
53a63be6 489 Extend mouse support on W32 text-mode console.
61b108cc
SM
490 * xdisp.c (draw_row_with_mouse_face):
491 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 492
eb3f6f01 493 * w32console.c: Include window.h.
61b108cc
SM
494 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
495 New functions.
eb3f6f01
EZ
496 (initialize_w32_display): Initialize mouse-highlight data.
497
53a63be6
EZ
498 * w32inevt.c: Include termchar.h and window.h.
499 (do_mouse_event): Support mouse-autoselect-window. When the mouse
500 moves, call note_mouse_highlight. If help_echo changed, call
501 gen_help_event to produce help-echo message in the echo area.
502 Call clear_mouse_face if mouse_face_hidden is set in the mouse
503 highlight info.
504
4cfd81f6
PE
5052012-05-26 Paul Eggert <eggert@cs.ucla.edu>
506
507 * lread.c (read1): Simplify slightly to avoid an overflow warning
508 with GCC 4.7.0 on x86-64.
509
4446092a
EZ
5102012-05-26 Eli Zaretskii <eliz@gnu.org>
511
512 * bidi.c (bidi_mirror_char): Revert last change: an int is
513 definitely wide enough here.
514
42b2a986 5152012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 516
42b2a986 517 Fix integer width and related bugs (Bug#9874).
eb106a49 518 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
519 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
520 (string_bytes, check_sblock, allocate_string_data):
521 (compact_small_strings, Fmake_bool_vector, make_string)
522 (make_unibyte_string, make_multibyte_string)
523 (make_string_from_bytes, make_specified_string)
524 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
525 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
526 (mark_vectorlike):
527 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
528 (allocate_pseudovector):
529 Use int, not EMACS_INT, where int is wide enough.
530 (inhibit_garbage_collection, Fgarbage_collect):
531 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
532 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
533 int might not be wide enough.
534 (bidi_cache_search, bidi_cache_find, bidi_init_it)
535 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
536 (bidi_at_paragraph_end, bidi_find_paragraph_start)
537 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
538 (bidi_level_of_next_char, bidi_move_to_visually_next):
539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
540 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
541 (Fkill_buffer, Fset_buffer_major_mode)
542 (advance_to_char_boundary, Fbuffer_swap_text)
543 (Fset_buffer_multibyte, overlays_at, overlays_in)
544 (overlay_touches_p, struct sortvec, record_overlay_string)
545 (overlay_strings, recenter_overlay_lists)
546 (adjust_overlays_for_insert, adjust_overlays_for_delete)
547 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
548 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
549 (Foverlay_recenter, last_overlay_modification_hooks_used)
550 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
552 (validate_region): Omit unnecessary test for b <= e,
553 since that's guaranteed by the previous test.
d311d28c
PE
554 (adjust_overlays_for_delete): Avoid pos + length overflow.
555 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
556 (report_overlay_modification):
557 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
558 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
559 Omit pointer cast, which isn't needed anyway, and doesn't work
560 after the EMACS_INT -> ptrdiff_t change.
02481186 561 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
562 * buffer.h: Adjust decls to match defn changes elsewhere.
563 (struct buffer_text, struct buffer):
564 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
565 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
566 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
567 not int, to avoid needless 32-bit limit on 64-bit hosts.
568 (exec_byte_code): Use tighter memory-full test, one that checks
569 for alloca overflow. Don't compute the address of the object just
570 before an array, as that's not portable. Use EMACS_INT, not
571 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
572 * callint.c (Fcall_interactively):
573 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
574 * callproc.c (call_process_kill, Fcall_process):
575 Don't assume pid_t fits into an Emacs fixnum.
576 (call_process_cleanup, Fcall_process, child_setup):
577 Don't assume pid_t fits into int.
578 (call_process_cleanup, Fcall_process, delete_temp_file)
579 (Fcall_process_region):
580 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
581 (Fcall_process): Simplify handling of volatile integers.
582 Use int, not EMACS_INT, where int will do.
583 * casefiddle.c (casify_object, casify_region, operate_on_word)
584 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
585 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
586 (casify_object): Avoid integer overflow when overallocating buffer.
587 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 588 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
589 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
590 * category.h (CATEGORYP): Don't assume arg is nonnegative.
591 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
592 integers are now checked earlier. All uses replaced with XINT.
593 (ccl_driver):
594 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
595 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
596 (ccl_driver, Fregister_code_conversion_map):
597 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
598 (resolve_symbol_ccl_program): Check that vector header is in range.
599 Always copy the vector, so that we can check its contents reliably
600 now rather than having to recheck each instruction as it's being
601 executed. Check that vector words fit in 'int'.
602 (ccl_get_compiled_code, Fregister_ccl_program)
603 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
604 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
605 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
606 contents are in range.
607 (Fccl_execute_on_string): Check that status is in range.
608 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
609 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
610 Accept and return EMACS_INT, not int, because callers can pass values
611 out of 'int' range.
612 (c_string_width, strwidth, lisp_string_width, chars_in_text)
613 (multibyte_chars_in_text, parse_str_as_multibyte)
614 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
615 (str_as_unibyte, str_to_unibyte, string_count_byte8)
616 (string_escape_byte8, Fget_byte):
617 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 618 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
619 avoid mishandling large integers.
620 * character.h: Adjust decls to match defn changes elsewhere.
621 * charset.c (load_charset_map_from_file, find_charsets_in_text)
622 (Ffind_charset_region):
623 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
624 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
625 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 626 Don't assume fixnum fits in int.
d311d28c
PE
627 (load_charset_map_from_vector, Fmap_charset_chars):
628 Remove now-unnecessary CHECK_NATNUMs.
629 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
630 Don't rely on undefined behavior with signed left shift overflow.
631 Don't assume unsigned int fits into fixnum, or that fixnum fits
632 into unsigned int. Don't require max_code to be a valid fixnum;
633 that's not true for gb10830 4-byte on a 32-bit host. Allow
634 invalid_code to be a cons, for the same reason. Require code_offset
635 to be a character. Avoid int overflow if max_char is close
636 to INT_MAX.
637 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
638 this is intended anyway and avoids some undefined behavior.
639 (load_charset_map): Pass unsigned, not int, as 2nd arg of
640 INDEX_TO_CODE_POINT, as that's what it expects.
641 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
642 * charset.h (DECODE_CHAR): Return int, not unsigned;
643 this is what was intended anyway, and it avoids undefined behavior.
644 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
645 integer-overflow issues.
646 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
647 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
648 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
649 * chartab.c (Fmake_char_table, Fset_char_table_range)
650 (uniprop_get_decoder, uniprop_get_encoder):
651 Don't assume fixnum fits in int.
652 * cmds.c (move_point): New function, that does the gist of
653 Fforward_char and Fbackward_char, but does so while checking
654 for integer overflow more accurately.
c96e5d6a 655 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
656 (Fforward_line, Fend_of_line, internal_self_insert)
657 (internal_self_insert):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 Fix a FIXME, by checking for integer overflow when calculating
660 target_clm and actual_clm.
661 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 662 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
663 (ASSURE_DESTINATION, coding_alloc_by_realloc)
664 (coding_alloc_by_making_gap, alloc_destination)
665 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
666 (encode_coding_utf_16, detect_coding_emacs_mule)
667 (decode_coding_emacs_mule, encode_coding_emacs_mule)
668 (detect_coding_iso_2022, decode_coding_iso_2022)
669 (encode_invocation_designation, encode_designation_at_bol)
670 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
671 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
672 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
673 (encode_coding_ccl, encode_coding_raw_text)
674 (detect_coding_charset, decode_coding_charset)
675 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
676 (produce_composition, produce_charset, produce_annotation)
677 (decode_coding, handle_composition_annotation)
678 (handle_charset_annotation, consume_chars, decode_coding_gap)
679 (decode_coding_object, encode_coding_object, detect_coding_system)
680 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
681 (code_convert_region, code_convert_string)
8f50130c
PE
682 (Fdefine_coding_system_internal)
683 (coding_set_source, coding_set_destination):
d311d28c
PE
684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
685 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
686 (Fdefine_coding_system_internal):
687 Don't assume fixnums fit in int.
688 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 689 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
690 (Funencodable_char_position, Fcheck_coding_systems_region)
691 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 692 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 693 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 694 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 695 Don't access memory outside of the args array.
d311d28c 696 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
697 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
698 result of ENCODE_CHAR.
d311d28c
PE
699 * coding.h: Adjust decls to match defn changes elsewhere.
700 (struct coding_system):
701 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
702 * composite.c (get_composition_id, find_composition)
703 (run_composition_function, update_compositions)
704 (compose_text, composition_gstring_put_cache)
705 (composition_gstring_p, composition_gstring_width)
706 (fill_gstring_header, fill_gstring_body, autocmp_chars)
707 (composition_compute_stop_pos, composition_reseat_it)
708 (composition_update_it, struct position_record)
709 (find_automatic_composition, composition_adjust_point)
710 (Fcomposition_get_gstring, Ffind_composition_internal):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
712 (update_compositions):
713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
714 * composite.h: Adjust decls to match defn changes elsewhere.
715 (struct composition):
716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
717 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
718 Do not attempt to compute the address of the object just before a
719 buffer; this is not portable.
720 (Faref, Faset):
721 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
722 (Faset): Use int, not EMACS_INT, where int is wide enough.
723 (Fstring_to_number): Don't assume fixnums fit in int.
724 (Frem): Don't assume arg is nonnegative.
725 * dbusbind.c (xd_append_arg): Check for integers out of range.
726 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 727 (extract_signed, extract_unsigned): New functions.
243e0530
PE
728 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
729 (xd_get_connection_references): Return ptrdiff_t, not int.
730 All uses changed.
731 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
732 (xd_read_message_1):
733 Use int, not unsigned, where the dbus API uses int.
734 (Fdbus_message_internal): Don't overflow mtype.
735 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
736 * dired.c (directory_files_internal, file_name_completion, scmp)
737 (file_name_completion_stat):
738 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
739 (file_name_completion): Don't overflow matchcount.
740 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
741 * dispextern.h: Adjust decls to match defn changes elsewhere.
742 (struct text_pos, struct glyph, struct bidi_saved_info)
743 (struct bidi_string_data, struct bidi_it, struct composition_it)
744 (struct it):
745 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
746 (struct display_pos, struct composition_it, struct it):
747 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
748 * dispnew.c (increment_matrix_positions)
749 (increment_row_positions, mode_line_string)
750 (marginal_area_string):
751 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 752 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
753 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
754 (duration_to_sec_usec): New function, to check for overflow better.
755 (Fsleep_for, sit_for): Use it.
756 * doc.c (get_doc_string, store_function_docstring):
757 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
758 (get_doc_string, Fsnarf_documentation):
759 Use int, not EMACS_INT, where int is wide enough.
760 (get_doc_string):
761 Use SAFE_ALLOCA, not alloca.
762 Check for overflow when converting EMACS_INT to off_t.
763 * doprnt.c (doprnt):
764 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
765 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
766 Don't assume uid_t fits into fixnum.
767 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
768 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
769 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
770 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
771 (general_insert_function)
772 (Finsert_char, make_buffer_string, make_buffer_string_both)
773 (update_buffer_properties, Fbuffer_substring)
774 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
775 (Fsubst_char_in_region, check_translation)
776 (Ftranslate_region_internal, save_restriction_restore, Fformat)
777 (transpose_markers, Ftranspose_regions):
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
779 (clip_to_bounds): Move to lisp.h as an inline function).
780 (Fconstrain_to_field): Don't assume integers are nonnegative.
781 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
782 (Fsubst_char_in_region, Fsave_restriction):
783 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
784 (Femacs_pid): Don't assume pid_t fits into fixnum.
785 (lo_time): Use int, not EMACS_INT, when int suffices.
786 (lisp_time_argument): Check for usec out of range.
787 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
788 (Fuser_login_name, Fuser_full_name): Signal an error
789 if a uid argument is out of range, rather than relying on
790 undefined behavior.
c8d5c857
PE
791 (Fformat_time_string): Remove now-unnecessary check.
792 lisp_time_argument checks for out-of-range usec now.
243e0530 793 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
794 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
795 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
796 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
797 (init_cmdargs, Fdump_emacs):
798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
799 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
800 the bottom (typically) 32 bits of the fixnum.
801 * eval.c (specpdl_size, call_debugger):
802 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
803 (when_entered_debugger, Fbacktrace_debug):
804 Don't assume fixnum can fit in int.
805 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
806 the object just before a buffer; this is not portable.
807 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
808 (grow_specpdl, unbind_to):
809 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
810 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
811 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 812 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
813 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
814 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
815 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
816 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
817 (a_write, e_write):
818 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
819 (Fcopy_file, non_regular_nbytes, read_non_regular)
820 (Finsert_file_contents):
821 Use int, not EMACS_INT, where int is wide enough.
822 (READ_BUF_SIZE): Verify that it fits in int.
823 (Finsert_file_contents): Check that counts are in proper range,
824 rather than assuming fixnums fit into ptrdiff_t etc.
825 Don't assume fixnums fit into int.
125b3835 826 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
827 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
828 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
829 (string_char_to_byte, string_byte_to_char)
830 (string_make_multibyte, string_to_multibyte)
831 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
832 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
833 (substring_both, Fdelete, internal_equal, Ffillarray)
834 (Fclear_string, mapcar1)
835 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
836 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
837 (larger_vector, make_hash_table, maybe_resize_hash_table)
838 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
839 (Fmaphash, secure_hash):
840 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
841 (concat): Check for string index and length overflow.
842 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
843 (Frequire):
844 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
845 (larger_vector): New API (vec, incr_min, size_max) replaces old
846 one (vec, new_size, init). This catches size overflow.
847 INIT was removed because it was always Qnil.
848 All callers changed.
849 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
850 the upper bound on a hash table index size.
851 (make_hash_table, maybe_resize_hash_table): Use it.
852 (secure_hash): Computer start_byte and end_byte only after
853 they're known to be in ptrdiff_t range.
854 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
855 (Ffont_get_glyphs, Ffont_at):
856 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
857 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
858 (Flist_fonts, Fopen_font):
859 Don't assume fixnum can fit in int.
860 (check_gstring): Don't assume index can fit in int.
861 (font_match_p): Check that fixnum is a character, not a nonnegative
862 fixnum, since the later code needs to stuff it into an int.
863 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
864 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
865 conversion overflow issues.
866 (Fopen_font): Check for integer out of range.
867 (Ffont_get_glyphs): Don't assume index can fit in int.
868 * font.h: Adjust decls to match defn changes elsewhere.
869 * fontset.c (reorder_font_vector): Redo score calculation to avoid
870 integer overflow.
871 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
872 printmax_t, where ptrdiff_t is wide enough.
873 (Finternal_char_font):
874 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
875 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
876 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
877 (Fset_frame_position, x_set_frame_parameters)
878 (x_set_line_spacing, x_set_border_width)
879 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
880 Check that fixnums are in proper range for system types.
881 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
882 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
883 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
884 Use SAFE_ALLOCA_LISP, not alloca.
885 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
886 intptr_t is wide enough.
887 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
888 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
889 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
890 Check for fixnum out of range.
891 * ftfont.c (ftfont_list): Don't assume index fits in int.
892 Check that fixnums are in proper range for system types.
893 (ftfont_shape_by_flt):
894 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
895 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
897 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
898 Check that fixnums are in proper range for system types.
899 * gnutls.h: Adjust decls to match defn changes elsewhere.
900 * gtkutil.c (xg_dialog_run):
901 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
902 (update_frame_tool_bar):
903 Check that fixnums are in proper range for system types.
904 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 905 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
906 * indent.c (last_known_column, last_known_column_point):
907 (current_column_bol_cache):
908 (skip_invisible, current_column, check_display_width):
909 (check_display_width, scan_for_column, current_column_1)
910 (Findent_to, Fcurrent_indentation, position_indentation)
911 (indented_beyond_p, Fmove_to_column, compute_motion):
912 (Fcompute_motion, Fvertical_motion):
913 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
914 (last_known_column_modified): Use EMACS_INT, not int.
915 (check_display_width):
916 (Fcompute_motion):
917 Check that fixnums and floats are in proper range for system types.
918 (compute_motion): Don't assume index or fixnum fits in int.
919 (compute_motion, Fcompute_motion):
920 Use int, not EMACS_INT, when it is wide enough.
921 (vmotion): Omit local var start_hpos that is always 0; that way
922 we don't need to worry about overflow in expressions involving it.
923 * indent.h: Adjust decls to match defn changes elsewhere.
924 (struct position):
925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
926 Use int, not EMACS_INT, where int is wide enough.
927 Remove unused members ovstring_chars_done and tab_offset;
928 all uses removed.
929 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
930 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
931 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
932 (make_gap, copy_text, insert, insert_and_inherit)
933 (insert_before_markers, insert_before_markers_and_inherit)
934 (insert_1, count_combining_before, count_combining_after)
935 (insert_1_both, insert_from_string)
936 (insert_from_string_before_markers, insert_from_string_1)
937 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
938 (adjust_after_replace, adjust_after_insert, replace_range)
939 (replace_range_2, del_range, del_range_1, del_range_byte)
940 (del_range_both, del_range_2, modify_region)
941 (prepare_to_modify_buffer, signal_before_change)
942 (signal_after_change, Fcombine_after_change_execute):
943 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
944 * intervals.c (traverse_intervals, rotate_right, rotate_left)
945 (balance_an_interval, split_interval_right, split_interval_left)
946 (find_interval, next_interval, update_interval)
947 (adjust_intervals_for_insertion, delete_node, delete_interval)
948 (interval_deletion_adjustment, adjust_intervals_for_deletion)
949 (static_offset_intervals, offset_intervals)
950 (merge_interval_right, merge_interval_left, make_new_interval)
951 (graft_intervals_into_buffer, temp_set_point_both)
952 (temp_set_point, set_point, adjust_for_invis_intang)
953 (set_point_both, move_if_not_intangible, get_property_and_range)
954 (get_local_map, copy_intervals, copy_intervals_to_string)
955 (compare_string_intervals, set_intervals_multibyte_1):
956 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
957 * intervals.h: Adjust decls to match defn changes elsewhere.
958 (struct interval):
959 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
960 * keyboard.c (this_command_key_count, this_single_command_key_start)
961 (before_command_key_count, before_command_echo_length, echo_now)
962 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
963 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
964 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
965 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
966 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
967 (last_non_minibuf_size, last_point_position, echo_truncate)
968 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
969 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
970 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
971 (stuff_buffered_input):
972 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
973 (last_auto_save, command_loop_1, read_char):
974 Use EMACS_INT, not int, to avoid integer overflow.
975 (record_char): Avoid overflow in total_keys computation.
976 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
977 * keyboard.h: Adjust decls to match defn changes elsewhere.
978 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
979 (Fkey_description, Fdescribe_vector, Flookup_key):
980 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
981 (click_position): New function, to check that positions are in range.
982 (Fcurrent_active_maps):
983 (describe_command):
984 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
985 (Faccessible_keymaps, Fkey_description):
986 (preferred_sequence_p):
987 Don't assume fixnum can fit into int.
988 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
989 Check for integer overflow in size calculations.
990 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
991 avoid mishandling large integers.
992 * lisp.h: Adjust decls to match defn changes elsewhere.
993 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
994 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
995 (struct Lisp_Marker):
996 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
997 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
998 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
999 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1000 All callers changed.
1001 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1002 Assume the arg has valid form, since it always does.
1003 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1004 unsigned integer system type.
1005 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1006 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1007 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1008 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1009 (duration_to_sec_usec): New decl.
1010 * lread.c (read_from_string_index, read_from_string_index_byte)
1011 (read_from_string_limit, readchar, unreadchar, openp)
1012 (read_internal_start, read1, oblookup):
1013 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1014 (Fload, readevalloop, Feval_buffer, Feval_region):
1015 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1016 (openp): Check for out-of-range argument to 'access'.
1017 (read1): Use int, not EMACS_INT, where int is wide enough.
1018 Don't assume fixnum fits into int.
6efdadfd 1019 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1020 (read_filtered_event): Use duration_to_sec_usec
1021 to do proper overflow checking on durations.
d311d28c
PE
1022 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1023 in size calculation.
1024 (Fexecute_kbd_macro):
1025 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1026 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1027 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1028 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1029 (set_marker_both, set_marker_restricted_both, marker_position)
1030 (marker_byte_position, Fbuffer_has_markers_at):
1031 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1032 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1033 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1034 It now merely ensures that the menu is large enough, without
1035 necessarily growing it, as this avoids some integer overflow issues.
1036 All callers changed.
1037 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1038 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1039 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1040 Use SAFE_ALLOCA_LISP, not alloca.
1041 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1042 to EMACS_INT. Check that fixnums are in proper range for system types.
1043 * minibuf.c (minibuf_prompt_width, string_to_object)
1044 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1045 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1046 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1047 (get_minibuffer, read_minibuf_unwind):
1048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1049 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1050 this simplifies overflow checking. All callers changed.
1051 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1052 (Ftest_completion):
1053 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1054 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1055 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1056 Check that fixnums are in proper range for system types.
1057 (Fx_create_frame, Fx_show_tip):
1058 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1059 * nsfont.m (ns_findfonts, nsfont_list_family):
1060 Don't assume fixnum fits in long.
1061 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1062 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1063 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1064 wide enough.
17fdb222 1065 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1066 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1067 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1068 (PRINTDECLARE, PRINTPREPARE):
1069 (strout, print_string):
1070 (print, print_preprocess, print_check_string_charset_prop)
1071 (print_object):
1072 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1073 (PRINTDECLARE):
1074 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1075 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1076 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1077 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1078 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1079 (print_error_message): Use SAFE_ALLOCA, not alloca.
1080 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1081 (print_depth, new_backquote_output, print_number_index):
1082 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1083 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1084 (Fset_process_window_size, Fformat_network_address)
1085 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1086 (sigchld_handler):
d311d28c 1087 Check that fixnums are in proper range for system types.
d44287d4 1088 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1089 Check for process-ids out of pid_t range rather than relying on
1090 undefined behavior.
e4d81efc 1091 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1092 (Fformat_network_address, read_process_output, send_process)
1093 (Fprocess_send_region, status_notify):
1094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1095 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1096 (wait_reading_process_output, read_process_output, exec_sentinel):
1097 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1098 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1099 (Faccept_process_output): Use duration_to_sec_usec to do proper
1100 overflow checking on durations.
dde14581
PE
1101 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1102 Don't assume pid_t fits in int.
02481186
PE
1103 * process.h (struct Lisp_Process): Members tick and update_tick
1104 are now of type EMACS_INT, not int.
b62b53e8
PE
1105 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1106 configured --with-wide-int.
d311d28c
PE
1107 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1108 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1109 * search.c (looking_at_1, string_match_1):
1110 (fast_string_match, fast_c_string_match_ignore_case)
1111 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1112 (scan_newline, find_before_next_newline, search_command)
1113 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1114 (set_search_regs, wordify):
1115 (Freplace_match):
1116 (Fmatch_data):
1117 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1118 (string_match_1, search_buffer, set_search_regs):
1119 (Fmatch_data):
1120 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1121 (wordify): Check for overflow in size calculation.
1122 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1123 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1124 Check that fixnums are in proper range for system types.
1125 * sound.c (struct sound_device)
1126 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1127 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1128 (Fplay_sound_internal):
1129 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1130 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1131 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1132 (Fparse_partial_sexp):
1133 Don't assume fixnums can fit in int.
1134 (struct lisp_parse_state, find_start_pos, find_start_value)
1135 (find_start_value_byte, find_start_begv)
1136 (update_syntax_table, char_quoted, dec_bytepos)
1137 (find_defun_start, prev_char_comend_first, back_comment):
1138 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1139 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 (Finternal_describe_syntax_value): Check that match_lisp is a
1142 character, not an integer, since the code stuffs it into int.
1143 (scan_words, scan_sexps_forward):
1144 Check that fixnums are in proper range for system types.
1145 (Fforward_word):
1146 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1147 (scan_sexps_forward):
1148 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1149 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1150 * syntax.h: Adjust decls to match defn changes elsewhere.
1151 (struct gl_state_s):
1152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1153 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1154 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1155 * sysdep.c (wait_for_termination_1, wait_for_termination)
1156 (interruptible_wait_for_termination, mkdir):
1157 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1158 (emacs_read, emacs_write):
1159 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1160 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1161 and double all fit in int.
d311d28c
PE
1162 * term.c (set_tty_color_mode):
1163 Check that fixnums are in proper range for system types.
1164 * termhooks.h (struct input_event):
1165 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1166 * textprop.c (validate_interval_range, interval_of)
1167 (Fadd_text_properties, set_text_properties_1)
1168 (Fremove_text_properties, Fremove_list_of_text_properties)
1169 (Ftext_property_any, Ftext_property_not_all)
1170 (copy_text_properties, text_property_list, extend_property_ranges)
1171 (verify_interval_modification):
1172 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1173 (Fnext_single_char_property_change)
1174 (Fprevious_single_char_property_change):
1175 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1176 (copy_text_properties):
1177 Check for integer overflow in index calculation.
d311d28c
PE
1178 * undo.c (last_boundary_position, record_point, record_insert)
1179 (record_delete, record_marker_adjustment, record_change)
1180 (record_property_change):
1181 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1182 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1183 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1184 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1185 (Fx_hide_tip, Fx_file_dialog):
1186 * w32menu.c (set_frame_menubar):
1187 Use ptrdiff_t, not int, for consistency with rest of code.
1188 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1189 (select_window, Fdelete_other_windows_internal)
1190 (window_scroll_pixel_based, window_scroll_line_based)
1191 (Frecenter, Fset_window_configuration):
1192 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1193 (Fset_window_hscroll, run_window_configuration_change_hook)
1194 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1195 (Fscroll_other_window, Frecenter):
d311d28c
PE
1196 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1197 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1198 Don't assume fixnum fits in int.
1199 (Fset_window_scroll_bars):
1200 Check that fixnums are in proper range for system types.
1201 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1202 (string_pos, c_string_pos, number_of_chars, init_iterator)
1203 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1204 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1205 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1206 (face_before_or_after_it_pos, handle_invisible_prop)
1207 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1208 (display_prop_intangible_p, string_buffer_position_lim)
1209 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1210 (get_overlay_strings_1, get_overlay_strings)
1211 (iterate_out_of_display_property, forward_to_next_line_start)
1212 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1213 (get_next_display_element, set_iterator_to_next)
1214 (get_visually_first_element, compute_stop_pos_backwards)
1215 (handle_stop_backwards, next_element_from_buffer)
1216 (move_it_in_display_line_to, move_it_in_display_line)
1217 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1218 (add_to_log, message_dolog, message_log_check_duplicate)
1219 (message2, message2_nolog, message3, message3_nolog
1220 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1221 (current_message_1, truncate_echo_area, truncate_message_1)
1222 (set_message, set_message_1, store_mode_line_noprop)
1223 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1224 (text_outside_line_unchanged_p, check_point_in_composition)
1225 (reconsider_clip_changes)
1226 (redisplay_internal, set_cursor_from_row, try_scrolling)
1227 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1228 (redisplay_window, find_last_unchanged_at_beg_row)
1229 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1230 (trailing_whitespace_p, find_row_edges, display_line)
1231 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1232 (display_mode_element, store_mode_line_string)
1233 (pint2str, pint2hrstr, decode_mode_spec)
1234 (display_count_lines, display_string, draw_glyphs)
1235 (x_produce_glyphs, x_insert_glyphs)
1236 (rows_from_pos_range, mouse_face_from_buffer_pos)
1237 (fast_find_string_pos, mouse_face_from_string_pos)
1238 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1239 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1240 (safe_call, init_from_display_pos, handle_fontified_prop)
1241 (handle_single_display_spec, load_overlay_strings)
1242 (with_echo_area_buffer, setup_echo_area_for_printing)
1243 (display_echo_area, echo_area_display)
1244 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1245 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1246 (redisplay_window, dump_glyph_row, display_mode_line)
1247 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1248 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1249 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1250 (handle_single_display_spec, build_desired_tool_bar_string)
1251 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1252 (get_specified_cursor_type):
1253 Check that fixnums are in proper range for system types.
1254 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1255 (Flookup_image_map):
1256 Don't assume fixnums fit in int.
1257 (compare_overlay_entries):
1258 Avoid mishandling comparisons due to subtraction overflow.
1259 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1260 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1261 (handle_tool_bar_click):
1262 Use int, not unsigned, since we prefer signed and the signedness
1263 doesn't matter here.
1264 (get_next_display_element, next_element_from_display_vector):
1265 Use int, not EMACS_INT, when int is wide enough.
1266 (start_hourglass): Use duration_to_sec_usec to do proper
1267 overflow checking on durations.
1268 * xfaces.c (Fbitmap_spec_p):
1269 Check that fixnums are in proper range for system types.
1270 (compare_fonts_by_sort_order):
1271 Avoid mishandling comparisons due to subtraction overflow.
1272 (Fx_family_fonts, realize_basic_faces):
1273 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1274 (Fx_family_fonts):
1275 Don't assume fixnum fits in int.
1276 Use SAFE_ALLOCA_LISP, not alloca.
1277 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1278 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1279 (face_at_buffer_position, face_for_overlay_string)
1280 (face_at_string_position):
1281 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1282 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1283 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1284 (Fx_show_tip):
1285 Check that fixnums are in proper range for system types.
1286 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1287 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1288 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1289 (Fx_change_window_property): Don't assume fixnums fit in int.
1290 * xfont.c (xfont_chars_supported):
1291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1292 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1293 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1294 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1295 * xml.c (parse_region):
1296 * xrdb.c (magic_file_p):
1297 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1298 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1299 (x_get_local_selection, x_reply_selection_request)
1300 (x_handle_selection_request, wait_for_property_change):
1301 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1302 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1303 short is wide enough.
1304 (x_send_client_event): Don't assume fixnum fits in int.
1305 * xterm.c (x_x_to_emacs_modifiers):
1306 Don't assume EMACS_INT overflows nicely into int.
1307 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1308 may come from Lisp.
1309 (handle_one_xevent): NATNUMP can eval its arg twice.
1310 (x_connection_closed):
1311 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1312 * xterm.h: Adjust decls to match defn changes elsewhere.
1313 (struct scroll_bar): Use struct vectorlike_header
1314 rather than rolling our own approximation.
1315 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1316
c6574eb5
GM
13172012-05-25 Glenn Morris <rgm@gnu.org>
1318
1319 * lisp.mk (lisp): Update for more files being compiled now.
1320
e8d32c7e
SM
13212012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1322
48def666
SM
1323 * lread.c: Remove `read_pure' which makes no difference.
1324 (read_pure): Remove var.
1325 (unreadpure): Remove function.
1326 (readevalloop): Don't call read_list with -1 flag.
1327 (read1, read_vector): Don't test read_pure any more.
1328 (read_list): Simplify.
1329
e8d32c7e
SM
1330 * fileio.c, character.h: Minor style tweaks.
1331
4b2addb7
DA
13322012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 * window.h (clip_changed): Remove useless declaration.
1335
584461b2
JB
13362012-05-22 Juanma Barranquero <lekktu@gmail.com>
1337
1338 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1339 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1340
34374650
PE
13412012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1342
1343 Remove src/m/*.
1344 This directory predates autoconf and is no longer needed nowadays.
1345 Move its few remaining bits of functionality to where they're needed.
1346 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1347 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1348 * m/template.h: Remove.
1349 * Makefile.in (M_FILE): Remove. All uses removed.
1350 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1351 * lisp.h (USE_LSB_TAG):
1352 * mem-limits.h (EXCEEDS_LISP_PTR):
1353 Use VAL_MAX, not VALBITS, in #if.
1354 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1355 (EMACS_UINT): Define unconditionally now.
1356 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1357 (BITS_PER_EMACS_INT): New constants, replacing
1358 what used to be in config.h, but not useful in #if.
1359 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1360 define them any more.
1361 (VAL_MAX): New macro.
1362 (VALMASK): Use it.
1363 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1364 BITS_PER_EMACS_INT, in #if.
1365 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1366 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1367 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1368 * s/ms-w32.h (DATA_START):
1369 Move here from removed file m/intel386.h.
1370 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1371 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1372
261cb4bb
PE
13732012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1374
1375 Assume C89 or later.
1376 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1377 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1378 (xrealloc):
1379 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1380 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1381 * textprop.c, tparam.c (NULL): Remove.
1382 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1383 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1384 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1385 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1386 * xterm.c (input_signal_count): Assume volatile works.
1387
ff23cd9f
KB
13882012-05-21 Ken Brown <kbrown@cornell.edu>
1389
1390 * xgselect.c (xg_select): Fix first argument in call to 'select'
1391 (bug#11508).
1392
1b170bc6
KB
13932012-05-20 Ken Brown <kbrown@cornell.edu>
1394
1395 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1396 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1397
b2f4d39f
KB
13982012-05-19 Ken Brown <kbrown@cornell.edu>
1399
1400 * xfns.c (x_in_use): Remove `static' qualifier.
1401 * xterm.h (x_in_use): Declare.
1402 * xgselect.c: Include xterm.h.
1403 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1404 and `display_arg' (bug#9754).
1405
003fdae2
PE
14062012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1407
9232a6d9
PE
1408 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1409
003fdae2
PE
1410 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1411 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1412
784b56e2
EZ
14132012-05-18 Eli Zaretskii <eliz@gnu.org>
1414
1415 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1416
1417 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1418 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1419
1420 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1421 reference to image_cache->refcount.
1422 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1423
a0a79cde
JL
14242012-05-17 Juri Linkov <juri@jurta.org>
1425
1426 * search.c (Fword_search_regexp, Fword_search_backward)
1427 (Fword_search_forward, Fword_search_backward_lax)
1428 (Fword_search_forward_lax): Move functions to isearch.el
1429 (bug#10145, bug#11381).
1430
b0572523
PE
14312012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1432
1433 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1434
9660f5fc
SM
14352012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1436
1437 * lread.c (init_obarray): Declare Qt and Qnil as special.
1438
4374de83
GM
14392012-05-14 Glenn Morris <rgm@gnu.org>
1440
1441 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1442 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1443
dc44c39a
PE
14442012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1445
078c97cb
PE
1446 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1447
dc44c39a
PE
1448 * unexaix.c: Port to more-recent AIX compilers.
1449 (report_error, report_error_1, make_hdr, copy_sym)
1450 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1451 Make arguments const char *, not char *, to avoid violations of C
1452 standard and to fix some AIX warnings reported by Gilles Pion.
1453
e18afed7 14542012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1455
1456 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1457 already have overlays loaded.
1458 (handle_single_display_spec): Before returning without displaying
1459 fringe bitmap, synchronize the bidi iterator with the main display
1460 iterator, by calling iterate_out_of_display_property.
1461 (iterate_out_of_display_property): Detect buffer iteration by
1462 testing that it->string is a Lisp string.
1463 (get_next_display_element): When the current object is exhausted,
1464 and there's something on it->stack, call set_iterator_to_next to
1465 proceed with what's on the stack, instead of returning zero.
1466 (set_iterator_to_next): If called at the end of a Lisp string,
1467 proceed to consider_string_end without incrementing string
1468 position. Don't increment display vector index past the end of
1469 the display vector. (Bug#11417)
c8fb9dc6
EZ
1470 (pos_visible_p): Don't report a position visible when move_it_to
1471 stopped at the last line of window, which happens to be scanned
1472 backwards by the bidi iteration. (Bug#11464)
ac268e67 1473
e18afed7 14742012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1475
1476 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1477 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1478 are on a TTY, and thus unable to display on the fringes.
1479 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1480 so we need to signal to the caller that this is a "replacing"
1481 display spec. This fixes display when the spec is invalid or we
1482 are on a TTY.
1483
e18afed7 14842012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1485
1486 * unexaix.c (make_hdr): Fix typo in prototype.
1487 This bug broke the build on AIX. Problem reported by Gilles Pion.
1488
9d0a235a
MA
14892012-05-14 Michael Albinus <michael.albinus@gmx.de>
1490
1491 * keyboard.c (kbd_buffer_get_event): Read special events also in
1492 batch mode. (Bug#11415)
1493
9e6b06ed
GM
14942012-05-12 Glenn Morris <rgm@gnu.org>
1495
1496 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1497
c1a1d7a3
EZ
14982012-05-12 Eli Zaretskii <eliz@gnu.org>
1499
1500 * lisp.mk (lisp): Add newcomment.elc.
1501
3fe7cdc8
GM
15022012-05-12 Glenn Morris <rgm@gnu.org>
1503
1504 * Makefile.in (MKDIR_P): New, set by configure.
1505 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1506
53f7d2c0
PE
15072012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 Remove unused function hourglass_started.
1510 * dispextern.h (hourglass_started):
1511 * w32fns.c (hourglass_started):
1512 * xdisp.c (hourglass_started): Remove.
1513
75aafb17
JB
15142012-05-10 Juanma Barranquero <lekktu@gmail.com>
1515
1516 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1517 Update dependencies.
1518
12959e8e
PE
15192012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1520
97107e2e
PE
1521 * xgselect.c (xg_select): Put maxfds+1 into a var.
1522 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1523
12959e8e
PE
1524 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1525
836d29b3
DA
15262012-05-10 Dave Abrahams <dave@boostpro.com>
1527
1528 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1529 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1530
5cb67954
MA
15312012-05-09 Michael Albinus <michael.albinus@gmx.de>
1532
1533 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1534 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1535 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1536 Initialize xd_registered_buses.
1537
3478ec45
PE
15382012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1539
b263a6b0
PE
1540 Untag more efficiently if USE_LSB_TAG.
1541 This is based on a proposal by YAMAMOTO Mitsuharu in
1542 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1543 For an admittedly artificial (nth 8000 longlist) benchmark on
1544 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1545 Emacs's overall text size by 1%.
1546 * lisp.h (XUNTAG): New macro.
1547 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1548 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1549 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1550 * eval.c (Fautoload):
1551 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1552 * frame.h (XFRAME): Use XUNTAG.
1553
3478ec45
PE
1554 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1555 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1556 Remove unportable assumptions about print widths of types like
1557 dbus_uint32_t.
1558 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1559 intptr_t when converting between pointer and integer, to avoid GCC
1560 warnings about wrong width.
1561
666b903b 15622012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1563
1564 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1565 stack for each reader_thread, instead of defaulting to 8MB
1566 determined by the linker. This avoids failures in creating
1567 subprocesses on Windows 7, see the discussion in this thread:
1568 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1569
b120cc17
JC
15702012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1571
1572 Fix up display of the *Minibuf-0* buffer in the mini window.
1573 * keyboard.c (read_char): Don't clear the echo area if there's no
1574 message to clear.
1575 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1576 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1577
9a4b36f8
MA
15782012-05-07 Michael Albinus <michael.albinus@gmx.de>
1579
1580 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1581 batch mode.
1582
e5f9458f
CY
15832012-05-06 Chong Yidong <cyd@gnu.org>
1584
1585 * lisp.mk (lisp): Update.
1586
eceeb5fc 15872012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1588
1589 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1590
71873e2b
SM
15912012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1592
1593 * data.c (PUT_ERROR): New macro.
1594 (syms_of_data): Use it. Add new error type `user-error'.
1595 * undo.c (user_error): New function.
1596 (Fprimitive_undo): Use it.
1597 * print.c (print_error_message): Adjust print style for `user-error'.
1598 * keyboard.c (user_error): New function.
1599 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1600
ab0fa4e4
PE
16012012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 Do not limit current-time-string to years 1000..9999.
1604 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1605 (Fcurrent_time_string): Support any year that is supported by the
1606 underlying localtime representation. Don't use asctime, as it
1607 has undefined behavior for years outside the range -999..9999.
1608
7ed806a7
PE
16092012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1610
1611 Fix race conditions involving setenv, gmtime, localtime, asctime.
1612 Without this fix, interrupts could mess up code that uses these
1613 nonreentrant functions, since setting TZ invalidates existing
1614 tm_zone or tzname values, and since most of these functions return
1615 pointers to static storage.
1616 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1617 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1618 Grow the critical sections to include not just invoking
1619 localtime/gmtime, but also accessing these functions' results
1620 including their tm_zone values if any, and any related TZ setting.
1621 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1622 so that the struct tm is saved in the critical section.
1623 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1624 motivated by the fact that memory allocation needs to be outside
1625 the critical section.
1626
0c16dfed
DA
16272012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1628
1629 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1630 with RESET_INTERVAL.
1631
1632 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1633 Remove duplicated buffer name initialization.
1634
3f83ace8
JM
16352012-05-02 Jim Meyering <jim@meyering.net>
1636
1637 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1638
c7b8541e
JM
1639 * xfns.c (x_window): Use xstrdup (Bug#11375).
1640
90207a15 16412012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1642
1643 * xdisp.c (pos_visible_p): If already at a newline from the
1644 display string before the 'while' loop, don't walk back the glyphs
1645 from it3.glyph_row. Solves assertion violation when the display
1646 string begins with a newline (egg.el). (Bug#11367)
1647
b593d6a9
AH
16482012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1649
1650 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1651 Move to simple.el.
1652
4737362e
GM
16532012-05-01 Glenn Morris <rgm@gnu.org>
1654
99cf43f9
GM
1655 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1656 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1657 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1658 All were removed before 23.1.
1659
9311dcff
GM
1660 * dispnew.c: Remove HAVE_LIBNCURSES test;
1661 it is always true on relevant platforms.
1662
4d5c6349
GM
1663 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1664 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1665
4737362e
GM
1666 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1667
74dd3a6b
AS
16682012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1669
1670 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1671 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1672 Remove.
1673
13c379ee
PE
16742012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 Do not avoid creating empty evaporating overlays (Bug#9642).
1677 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1678 That is, do not delete an evaporating overlay if it becomes
1679 empty after its bounds are adjusted to fit within its buffer.
1680 This fix caused other problems, and I'm reverting it until we get
1681 to the bottom of them.
1682
a8e7d6d7 16832012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1684
1685 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1686
a8e7d6d7 16872012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1688
1689 * xdisp.c (pos_visible_p): If the window start position is beyond
1690 ZV, start the display from buffer beginning. Prevents assertion
1691 violation in init_iterator when the minibuffer window is scrolled
1692 via the scroll bar.
1693
1694 * window.c (window_scroll_pixel_based): Likewise.
1695
a8e7d6d7 16962012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1697
1698 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1699
a8e7d6d7 17002012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1701
1702 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1703 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1704
a8e7d6d7 17052012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1706
b593d6a9
AH
1707 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1708 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1709
1c6900d9
EZ
17102012-04-26 Eli Zaretskii <eliz@gnu.org>
1711
4c3fa1d9
EZ
1712 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1713 display element, check also the underlying string or buffer
1714 character. (Bug#11341)
1715
1c6900d9
EZ
1716 * w32menu.c: Include w32heap.h.
1717 (add_menu_item): If the call to AppendMenuW (via
1718 unicode_append_menu) fails, disable Unicode menus only if we are
1719 running on Windows 9X/Me.
1720
42bf8205
AS
17212012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1722
1723 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1724 (xgetint): Add missing shift for LSB tags.
1725
b1bac16e
MR
17262012-04-24 Martin Rudalics <rudalics@gmx.at>
1727
1728 * keyboard.c (read_char): Don't wipe echo area for select window
1729 events: These might get delayed via `mouse-autoselect-window'
1730 (Bug#11304).
1731
d69621cc
JB
17322012-04-24 Juanma Barranquero <lekktu@gmail.com>
1733
1734 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1735 manipulation of :loaded-from data.
1736
02fd101b
JB
17372012-04-23 Juanma Barranquero <lekktu@gmail.com>
1738
1739 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1740 now a cons (bug#11311).
1741
888bec30
PE
17422012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1743
89a438bd
PE
1744 Do not create empty overlays with the evaporate property (Bug#9642).
1745 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1746 if it becomes empty after its bounds are adjusted to fit within
1747 its buffer. Without this fix, in a nonempty buffer (let ((o
1748 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1749 yields an empty overlay that has the evaporate property, which is
1750 not supposed to happen.
1751
1068fe4d
PE
1752 Fix minor GTK3 problems found by static checking.
1753 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1754 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1755 (struct _EmacsFixedClass, emacs_fixed_get_type):
1756 Move decls here from emacsgtkfixed.h, since they needn't be public.
1757 (emacs_fixed_get_type): Now static.
1758 (emacs_fixed_class_init): Omit unused local.
1759 (emacs_fixed_child_type): Remove; unused.
1760 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1761 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1762 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1763 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1764 (EMACS_FIXED_GET_CLASS): Remove; unused.
1765 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1766
888bec30
PE
1767 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1768 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1769
de85e130
PE
17702012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1771
d0baac98 1772 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1773 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1774 (__malloc_size_t, __malloc_ptrdiff_t):
1775 Remove. All uses removed, replaced by the definiens if needed,
1776 since we can assume C89 or better now.
1777 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1778 (protect_malloc_state, align, get_contiguous_space)
1779 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1780 (malloc_atfork_handler_child, malloc_enable_thread)
1781 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1782 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1783 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1784 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1785 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1786 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1787 Define using prototypes, not old style.
1788 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1789 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1790 (align): Don't assume that signed integer overflow wraps around.
1791 Omit unused local var.
1792 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1793 (_free_internal_nolock, memalign, mallochook, reallochook):
1794 Omit no-longer-needed casts.
1795 (valloc): Use getpagesize, not __getpagesize.
1796 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1797 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1798
de85e130
PE
1799 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1800
dcbf5805
MA
18012012-04-22 Michael Albinus <michael.albinus@gmx.de>
1802
1803 Move functions from C to Lisp. Make non-blocking method calls
1804 the default. Implement further D-Bus standard interfaces.
1805
1806 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1807 (QCdbus_request_name_allow_replacement)
1808 (QCdbus_request_name_replace_existing)
1809 (QCdbus_request_name_do_not_queue)
1810 (QCdbus_request_name_reply_primary_owner)
1811 (QCdbus_request_name_reply_in_queue)
1812 (QCdbus_request_name_reply_exists)
1813 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1814 (QCdbus_registered_serial, QCdbus_registered_method)
1815 (QCdbus_registered_signal): New Lisp objects.
1816 (XD_DEBUG_MESSAGE): Use sizeof.
1817 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1818 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1819 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1820 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1821 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1822 (xd_signature, xd_append_arg): Allow float for integer types.
1823 (xd_get_connection_references): New function.
b593d6a9
AH
1824 (xd_get_connection_address): Rename from xd_initialize.
1825 Return cached address.
dcbf5805
MA
1826 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1827 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1828 level.
1829 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1830 Return number of refcounts.
dcbf5805
MA
1831 (Fdbus_get_unique_name): Make stronger parameter check.
1832 (Fdbus_message_internal): New defun.
1833 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1834 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1835 (Fdbus_send_signal, Fdbus_register_service)
1836 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1837 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1838 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1839 (Vdbus_compiled_version, Vdbus_runtime_version)
1840 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1841 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1842 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1843 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1844 Adapt docstring.
dcbf5805 1845
52828e02
PE
18462012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1847
da05bc4c
PE
1848 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1849 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1850 Do not assume ptrdiff_t is the same width as 'int'.
1851
52828e02
PE
1852 * alloc.c: Handle unusual debugging option combinations.
1853 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1854 since the two debugging options are incompatible.
1855 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1856 is defined.
1857 (mem_init, mem_insert, mem_insert_fixup):
1858 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1859 (NEED_MEM_INSERT): Remove; no longer needed.
1860
f01769f9
LL
18612012-04-22 Leo Liu <sdl.web@gmail.com>
1862
1863 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1864
5790543d
PE
18652012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1866
1867 * sysdep.c [__FreeBSD__]: Minor cleanups.
1868 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1869 Use Emacs indenting style more consistently. Avoid some casts.
1870 Use 'double' consistently rather than mixing 'float' and 'double'.
1871
b91b7e4d
EW
18722012-04-21 Eduard Wiebe <usenet@pusto.de>
1873
b593d6a9
AH
1874 * sysdep.c (list_system_processes, system_process_attributes):
1875 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1876
6114eb15
AS
18772012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1878
1879 * lisp.mk (lisp): Update.
1880
2f38dff7
PE
18812012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1882
1883 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1884 It is never used otherwise.
1885
4ae29f89
SM
18862012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1887
1888 * print.c (print_preprocess): Only check print_depth if print-circle
1889 is nil.
1890 (print_object): Check for cycles even when print-circle is nil and
1891 print-gensym is t, but only check print_depth if print-circle is nil.
1892
f30d612a
CY
18932012-04-20 Chong Yidong <cyd@gnu.org>
1894
1895 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1896 set the status to "failed" and ensure that sentinel is run.
1897
c07a4c0b 18982012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1899
1900 * process.c (Fset_process_inherit_coding_system_flag)
1901 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1902 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1903
c07a4c0b 19042012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1905
1906 * xdisp.c (string_buffer_position_lim): Limit starting position to
1907 BEGV.
1908 (set_cursor_from_row): If called for a mode-line or header-line
1909 row, return zero immediately.
1910 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
1911 farther than the first row after the header line, if any.
1912 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
1913 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
1914
c07a4c0b 19152012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 1916
4ae29f89
SM
1917 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
1918 (bug#11238).
ad3a2b41 1919
c07a4c0b 19202012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 19212012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
1922
1923 configure: new option --enable-gcc-warnings (Bug#11207)
1924 * Makefile.in (C_WARNINGS_SWITCH): Remove.
1925 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
1926 (ALL_CFLAGS): Use new macros rather than old.
1927 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
1928 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
1929 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
1930 -Wunused-result, -Wunused-variable. This should go away once
1931 the Emacs and Gnulib regex code is merged.
1932 (xmalloc, xrealloc): Now static.
1933
aba027e8
PE
19342012-04-17 Paul Eggert <eggert@cs.ucla.edu>
1935
1936 * dired.c (Fsystem_groups): Remove unused local.
1937
e5a36063
GM
19382012-04-17 Glenn Morris <rgm@gnu.org>
1939
1940 * dired.c (Fsystem_users): Doc fix.
1941
316411f0
DA
19422012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
1943
1944 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
1945 (syms_of_dired): Add them.
1946
9426aba4
PE
19472012-04-16 Paul Eggert <eggert@cs.ucla.edu>
1948
b62a57be
PE
1949 Fix minor alloc.c problems found by static checking.
1950 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
1951 New extern decls, to avoid calling undeclared functions.
1952 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
1953 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
1954 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
1955 (NEED_MEM_INSERT): New macro.
1956 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 1957 Remove one incorrect comment and fix another.
b62a57be 1958
3539f31f
PE
1959 Fix minor ralloc.c problems found by static checking.
1960 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1961 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
1962 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
1963 (r_alloc_sbrk): Now static.
1964
a041960a
PE
1965 Improve ralloc.c interface checking.
1966 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
1967 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
1968 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
1969 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
1970 [REL_ALLOC]: ... to here, to check interface.
1971 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
1972 Remove decls. This fixes an "It stinks!".
1973
9426aba4
PE
1974 * alloc.c (which_symbols): Fix alignment issue / type clash.
1975
d55c12ed
AS
19762012-04-15 Andreas Schwab <schwab@linux-m68k.org>
1977
1978 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
1979 (struct Lisp_Misc_Any): Likewise.
1980 (struct Lisp_Free): Likewise.
1981 * alloc.c (union aligned_Lisp_Symbol): Define.
1982 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
1983 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
1984 (union aligned_Lisp_Misc): Define.
1985 (MARKER_BLOCK_SIZE, struct marker_block): Use union
1986 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 1987 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 1988
b948ce8b
PE
19892012-04-14 Paul Eggert <eggert@cs.ucla.edu>
1990
1991 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
1992 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
1993 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
1994 * s/netbsd.h, s/sol2-6.h:
1995 Remove definition of GC_MARK_STACK, since the default now works.
1996 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
1997 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
1998 no longer the default.
1999 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2000
35dc09a1 20012012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2002
35dc09a1
GM
2003 * lread.c (lisp_file_lexically_bound_p):
2004 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2005
35dc09a1
GM
20062012-04-14 Eli Zaretskii <eliz@gnu.org>
2007
2008 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2009 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2010
20112012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2012
2013 * nsterm.m (constrainFrameRect): Always constrain when there is only
2014 one screen (Bug#10962).
2015
bcd86815
KB
20162012-04-13 Ken Brown <kbrown@cornell.edu>
2017
2018 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2019
c25df26e
RT
20202012-04-13 Reuben Thomas <rrt@sc3d.org>
2021
2022 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2023
0fc59f1e
DC
20242012-04-11 Daniel Colascione <dancol@dancol.org>
2025
2026 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2027 against is gone. It's better to use vfork now so that when Cygwin
2028 gains a new, working vfork, we use it automatically (bug#10398).
2029
de8c03dc
SM
20302012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2031
2032 * window.c (save_window_save): Obey window-point-insertion-type.
2033
2f097256
GM
20342012-04-11 Glenn Morris <rgm@gnu.org>
2035
2036 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2037
453b951e
SM
20382012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2039
2040 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2041
75f1671a 20422012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2043
2044 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2045 (force_quit_count): New var.
2046 (handle_interrupt): Use it.
2047
2a8ce227
JB
20482012-04-10 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * w32.c (w32_delayed_load): Record the full path of the library
2051 being loaded (bug#10424).
2052
935396c0
GM
20532012-04-09 Glenn Morris <rgm@gnu.org>
2054
05920a43
GM
2055 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2056 not just in the obarray, before snarfing them. (Bug#11036)
2057
935396c0
GM
2058 * Makefile.in ($(leimdir)/leim-list.el):
2059 Pass EMACS rather than BUILT_EMACS.
2060
a18ecafa
TZ
20612012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2062
2063 * process.c (make_process):
2064 * process.h: Add integer `gnutls_handshakes_tried' member to
2065 process struct.
2066
6bbef4e5
JC
2067 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2068 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2069
2070 * gnutls.c (gnutls_log_function2i): Convenience log function.
2071 (emacs_gnutls_read): Use new log functions,
2072 `gnutls_handshakes_tried' process member, and
2073 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2074 attempts per process (connection).
2075
b4d3bc10
CY
20762012-04-09 Chong Yidong <cyd@gnu.org>
2077
2078 * eval.c (Fuser_variable_p, user_variable_p_eh)
2079 (lisp_indirect_variable): Functions deleted.
2080 (Fdefvar): Caller changed.
2081
2082 * callint.c (Finteractive, Fcall_interactively):
2083 * minibuf.c (Fread_variable): Callers changed.
2084
70f4d973
EZ
20852012-04-09 Eli Zaretskii <eliz@gnu.org>
2086
2087 * xdisp.c (set_cursor_from_row): If the display string appears in
2088 the buffer at position that is closer to point than the position
2089 after the display string, display the cursor on the first glyph of
2090 the display string. Fixes cursor display when a 'display' text
2091 property immediately follows invisible text. (Bug#11094)
2092
cb3c2e3e
PE
20932012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2094
2095 composite.c: use 'double' consistently
2096 * composite.c (get_composition_id): Use 'double' consistently
2097 instead of converting 'float' to 'double' and vice versa; this is
2098 easier to understand and avoids a GCC warning.
2099
fd06db5d
GM
21002012-04-09 Glenn Morris <rgm@gnu.org>
2101
50fe702a
GM
2102 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2103 preparation for dumping it with emacs. (Bug#4789)
2104 (leimdir): New variable.
2105 ($(leimdir)/leim-list.el): New rule.
2106 (emacs$(EXEEXT)): Depend on leim-list.el.
2107
fd06db5d
GM
2108 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2109 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2110 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2111
55c131ee
AS
21122012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2113
2114 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2115 proper alignment.
2116
9209588f
JB
21172012-04-07 Juanma Barranquero <lekktu@gmail.com>
2118
2119 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2120 Remove unused local variable.
2121
e3fb2efb
PE
21222012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2123
2124 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2125 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2126 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2127 objects, as mark_maybe_pointer will catch them otherwise.
2128 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2129 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2130
b5385551
PE
21312012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2132
2133 Fix typo that broke non-Windows builds.
2134 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2135
9078ead6
EZ
21362012-04-07 Eli Zaretskii <eliz@gnu.org>
2137
2138 Support building on MS-Windows with libxml2.
2139
2140 * makefile.w32-in (OBJ2): Add xml.$(O).
2141 (GLOBAL_SOURCES): Add xml.c.
2142 ($(BLD)/xml.$(O)): New dependency list.
2143
2144 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2145 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2146 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2147 [!WINDOWSNT]: New macros.
2148 (init_libxml2_functions, libxml2_loaded_p): New functions.
2149 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2150 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2151 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2152 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2153 linked in).
6bbef4e5
JC
2154 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2155 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2156 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2157
2158 * emacs.c: Don't include libxml/parser.h.
2159 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2160 xmlCleanupParser directly.
2161
2162 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2163
3811fdf3
EZ
21642012-04-07 Eli Zaretskii <eliz@gnu.org>
2165
2166 * indent.c (Fvertical_motion): If there is a display string at
2167 point, use it.vpos to compute how many lines to backtrack after
2168 move_it_to point. (Bug#11133)
2169
2f8e16b2
EZ
21702012-04-06 Eli Zaretskii <eliz@gnu.org>
2171
2172 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2173 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2174 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2175 macros related to unification of CJK characters. For the details,
2176 see the discussion following the message here:
2177 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2178
3d439cd1
CY
21792012-04-04 Chong Yidong <cyd@gnu.org>
2180
2181 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2182
8bc53d00
EZ
21832012-04-01 Eli Zaretskii <eliz@gnu.org>
2184
2185 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2186 instead of alloca. (Bug#11138)
2187
3b0512a3
AS
21882012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2189
2190 * w32menu.c (is_simple_dialog): Properly check lisp types.
2191 (Bug#11141)
2192
8427ddd2
EZ
21932012-03-31 Eli Zaretskii <eliz@gnu.org>
2194
979022ef
EZ
2195 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2196 position we get to after a call to move_it_to fails the
2197 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2198 only if we wind up in a string from display property. (Bug#11063)
2199
a6b1c7cc
EZ
2200 * window.c (Fdelete_other_windows_internal): Invalidate the row
2201 and column information about mouse highlight, so that redisplay
2202 restores it after reallocating the glyph matrices. (Bug#7464)
2203
8427ddd2
EZ
2204 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2205 string comes from a `display' text property, use the buffer
2206 position of that property as if we actually saw that position in
2207 the row's glyphs.
697ba24b
EZ
2208 (move_it_by_lines): Remove the assertion that
2209 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2210 violated when there's a before-string at the beginning of a line.
2211 (Bug#11063)
8427ddd2 2212
65a0a738
EZ
22132012-03-30 Eli Zaretskii <eliz@gnu.org>
2214
2215 * xdisp.c (append_space_for_newline): If the default face was
2216 remapped, use the remapped face for the appended newline.
2217 (extend_face_to_end_of_line): Use the remapped default face for
2218 extending the face to the end of the line.
2219 (display_line): Call extend_face_to_end_of_line when the default
2220 face was remapped. (Bug#11068)
2221
581355cc
EZ
22222012-03-29 Eli Zaretskii <eliz@gnu.org>
2223
2224 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2225
e8fc049f
SM
22262012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2227
2228 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2229
4fb9a543
GM
22302012-03-27 Glenn Morris <rgm@gnu.org>
2231
2232 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2233 Doc fixes.
2234
679910f1
KH
22352012-03-26 Kenichi Handa <handa@m17n.org>
2236
2237 * dispextern.h (struct glyph): Fix previous change. Change the
2238 bit length of glyphless.ch to 25 (Bug#11082).
2239
90d49b7f
CY
22402012-03-26 Chong Yidong <cyd@gnu.org>
2241
2242 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2243 (command_loop_1): Use it; inhibit selection update for
2244 handle-select-window too (Bug#8996).
2245
f514f6f0
FP
22462012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2247
e8fc049f 2248 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2249
bf43fa51
KH
22502012-03-25 Kenichi Handa <handa@m17n.org>
2251
2252 * dispextern.h (struct glyph): Change the bit length of
2253 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2254
8a0c01dd
EZ
22552012-03-24 Eli Zaretskii <eliz@gnu.org>
2256
2257 * s/ms-w32.h (tzname): Include time.h before redirecting to
2258 _tzname. Fixes the MSVC build. (Bug#9960)
2259
7d1c3a76
AS
22602012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2261
8ed79523
AS
2262 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2263 characters.
2264
7d1c3a76
AS
2265 * xterm.c (XTread_socket): Only modify handling_signal if
2266 !SYNC_INPUT. (Bug#11080)
2267
e99a9b8b
EZ
22682012-03-23 Eli Zaretskii <eliz@gnu.org>
2269
2270 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2271 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2272 when fetching a multibyte character consumes more bytes than
2273 CHAR_BYTES returns, due to unification of CJK characters in
2274 string_char. (Bug#11073)
2275
5063c0e1
TN
22762012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2277
2278 * process.c (wait_reading_process_output): Handle pty disconnect
2279 by refraining from sending oneself a SIGCHLD (bug#10933).
2280
9f851fbd
CY
22812012-03-22 Chong Yidong <cyd@gnu.org>
2282
2283 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2284
5063c0e1 2285 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2286 Mark string as coming from a prefix property.
2287 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2288 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2289
fb5b8aca
CY
22902012-03-21 Chong Yidong <cyd@gnu.org>
2291
2292 * xfaces.c (Vface_remapping_alist): Doc fix.
2293
62356a1b
EZ
22942012-03-20 Eli Zaretskii <eliz@gnu.org>
2295
2296 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2297 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2298 Doc fixes.
62356a1b 2299
025de85b
CY
23002012-03-20 Chong Yidong <cyd@gnu.org>
2301
2302 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2303 to reflect default non-nil value of redisplay-dont-pause.
2304
4827f94e
KH
23052012-03-19 Kenichi Handa <handa@m17n.org>
2306
2307 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2308 it fit in a valid range (Bug#11003).
2309
e50a24a2
EZ
23102012-03-18 Eli Zaretskii <eliz@gnu.org>
2311
2312 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2313 that is not from display property, accept the row as a "cursor
2314 row" if one of the string's character has a non-nil `cursor'
2315 property. Fixes cursor positioning when there are newlines in
2316 overlay strings, e.g. in icomplete.el. (Bug#11035)
2317
9af5ed87
PE
23182012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2321
d1f55f16
CY
23222012-03-12 Chong Yidong <cyd@gnu.org>
2323
2324 * eval.c (inhibit_lisp_code): Rename from
2325 inhibit_window_configuration_change_hook; move from window.c.
2326
2327 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2328 * window.c (run_window_configuration_change_hook)
2329 (syms_of_window): Callers changed.
2330
66c5eebd
CY
23312012-03-11 Chong Yidong <cyd@gnu.org>
2332
413df973
CY
2333 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2334
66c5eebd
CY
2335 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2336
1de11f56
CY
23372012-03-10 Chong Yidong <cyd@gnu.org>
2338
2339 * frame.c (other_visible_frames): Don't assume the selected frame
2340 is visible (Bug#10955).
2341
cae07000
SM
23422012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2343
2344 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2345
89c94350
JD
23462012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2347
2348 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2349 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2350 zero (Bug#10954).
2351
999dd333
GM
23522012-03-03 Glenn Morris <rgm@gnu.org>
2353
01a6dcc8 2354 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2355
de0100f2
EZ
23562012-03-02 Eli Zaretskii <eliz@gnu.org>
2357
2358 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2359 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2360 (redisplay_window, next_element_from_string): Fix typos in
2361 comments.
3e441275
EZ
2362 (redisplay_window): Pass to move_it_vertically the margin in
2363 pixels, not in screen lines.
de0100f2 2364
96a72ee9
GM
23652012-03-02 Glenn Morris <rgm@gnu.org>
2366
2367 * buffer.c (buffer-list-update-hook): Doc fix.
2368
312508d7
EZ
23692012-02-29 Eli Zaretskii <eliz@gnu.org>
2370
2371 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2372 push_it before setting up the iterator for the first overlay
2373 string, even if we have an empty string loaded.
2374 (next_overlay_string): If there's an empty string on the iterator
2375 stack, pop the stack. (Bug#10903)
2376
27f3c637
PE
23772012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2378
2379 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2380 Suggested by Stefan Monnier in
2381 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2382 * alloc.c (widen_to_Lisp_Object): New static function.
2383 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2384 and widening them to Lisp_Objects. This would work even if
2385 USE_LSB_TAG is defined and wide integers are used, which might
2386 happen in a future version of Emacs.
2387
3c9dfce6
CY
23882012-02-25 Chong Yidong <cyd@gnu.org>
2389
fa74b241
CY
2390 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2391 Doc fix.
2392
3c9dfce6
CY
2393 * xselect.c (Fx_selection_exists_p): Doc fix.
2394 (x_clipboard_manager_save_all): Print an informative message
2395 before saving to clipboard manager.
2396
9486df08
CY
23972012-02-24 Chong Yidong <cyd@gnu.org>
2398
2399 * keyboard.c (process_special_events): Handle all X selection
2400 requests in kbd_buffer, not just the next one (Bug#8869).
2401
f01d3321
CY
24022012-02-23 Chong Yidong <cyd@gnu.org>
2403
2404 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2405 call when setting menu-bar-lines and tool-bar-lines parameters.
2406 (unwind_create_frame_1): New helper function.
2407
2408 * window.c (inhibit_window_configuration_change_hook): New var.
2409 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2410 (syms_of_window): Initialize it.
f01d3321 2411
86b847b6
CY
24122012-02-22 Chong Yidong <cyd@gnu.org>
2413
2414 * xterm.c (x_draw_image_relief): Add missing type check for
2415 Vtool_bar_button_margin (Bug#10743).
2416
a59225b1
CY
24172012-02-21 Chong Yidong <cyd@gnu.org>
2418
2419 * fileio.c (Vfile_name_handler_alist): Doc fix.
2420
2421 * buffer.c (Fget_file_buffer): Protect against invalid file
2422 handler return value.
2423
310f5bd4
PE
24242012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2425
cb3a28cc
PE
2426 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2427 when computing $valmask.
2428
310f5bd4
PE
2429 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2430 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2431 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2432 It's useless in that case, and it can cause problems on hosts
2433 that allocate halves of EMACS_INT values separately.
2434 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2435 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2436 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2437 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2438 it avoids undefined behavior on hosts where shifting right by more
2439 than the word width has undefined behavior.
2440
2375c96a
CY
24412012-02-19 Chong Yidong <cyd@gnu.org>
2442
2443 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2444 (Funhandled_file_name_directory, Ffile_name_as_directory)
2445 (Fdirectory_file_name, Fexpand_file_name)
2446 (Fsubstitute_in_file_name): Protect against invalid file handler
2447 return values (Bug#10845).
2448
3eb49e71
EZ
24492012-02-18 Eli Zaretskii <eliz@gnu.org>
2450
2451 * .gdbinit (pitx): Fix incorrect references to fields of the
2452 iterator stack.
2453
7b926f3f
CY
24542012-02-17 Chong Yidong <cyd@gnu.org>
2455
2456 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2457
11273115
PE
24582012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2459
2460 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2461 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2462
c3a70e2b
CY
24632012-02-15 Chong Yidong <cyd@gnu.org>
2464
2465 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2466 marked as special. Also, starting docstrings with * is obsolete.
2467
0ca43699
AS
24682012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2469
2470 * gnutls.c (emacs_gnutls_write): Fix last change.
2471
2e8f3c56
LI
24722012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2473
2474 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2475 send_process.
2476
af70074f
SM
24772012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2478
2479 * keymap.c (Fsingle_key_description): Handle char ranges.
2480
95986d52
CY
24812012-02-12 Chong Yidong <cyd@gnu.org>
2482
afd83bd1
CY
2483 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2484 as that creates a dangerous corner case.
2485
95986d52
CY
2486 * window.c (Fdelete_window_internal): Invalidate the mouse
2487 highlight (Bug#9904).
2488
bd7da63e
GM
24892012-02-12 Glenn Morris <rgm@gnu.org>
2490
2491 * xselect.c (Fx_own_selection_internal)
2492 (Fx_get_selection_internal, Fx_disown_selection_internal)
2493 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2494 * nsselect.m (Fx_own_selection_internal)
2495 (Fx_disown_selection_internal, Fx_selection_exists_p)
2496 (Fx_selection_owner_p, Fx_get_selection_internal):
2497 Sync docs and argument specs with the xselect.c versions.
2498
77abcbc2
LI
24992012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2500
2501 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2502
90b671e2
EZ
25032012-02-11 Eli Zaretskii <eliz@gnu.org>
2504
1c0ca0b7
EZ
2505 * w32select.c (Fx_selection_exists_p): Sync doc string and
2506 argument list with xselect.c. (Bug#10783)
2507
2508 * w16select.c (Fx_selection_exists_p): Sync doc string and
2509 argument list with xselect.c. (Bug#10783)
90b671e2 2510
49241268
GM
25112012-02-10 Glenn Morris <rgm@gnu.org>
2512
2513 * fns.c (Fsecure_hash): Doc fix.
2514
f998bbe7 25152012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2516
2517 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2518
0992bd9c
CY
25192012-02-07 Chong Yidong <cyd@gnu.org>
2520
2521 * buffer.c (Fbuffer_local_variables)
2522 (buffer_lisp_local_variables): Handle unbound vars correctly;
2523 don't let Qunbound leak into Lisp.
2524
af008560
GM
25252012-02-07 Glenn Morris <rgm@gnu.org>
2526
dd605cc4
GM
2527 * image.c (Fimagemagick_types): Doc fix.
2528
af008560
GM
2529 * image.c (imagemagick-render-type): Change it from a lisp object
2530 to an integer. Move the doc here from the lisp manual.
2531 Treat all values not equal to 0 the same.
2532
1449fa1d
CY
25332012-02-06 Chong Yidong <cyd@gnu.org>
2534
2535 * doc.c (store_function_docstring): Avoid applying docstring of
2536 alias to base function (Bug#2603).
2537
3723ec07
AS
25382012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2539
2540 * .gdbinit (pp1, pv1): Remove redundant defines.
2541 (pr): Use pp.
2542
79c1cc1e
CY
25432012-02-04 Chong Yidong <cyd@gnu.org>
2544
2545 * nsterm.m: Declare a global (Bug#10694).
2546
d7f29f8e
EZ
25472012-02-04 Eli Zaretskii <eliz@gnu.org>
2548
cae07000
SM
2549 * w32.c (get_emacs_configuration_options):
2550 Include --enable-checking, if specified, in the return value.
d7f29f8e 2551
3b95a6f9
MR
25522012-02-04 Martin Rudalics <rudalics@gmx.at>
2553
2554 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2555 after rounding frame sizes. (Bug#9723)
2556
d6fa96a6
EZ
25572012-02-04 Eli Zaretskii <eliz@gnu.org>
2558
2559 * keyboard.c (adjust_point_for_property): Don't position point
2560 before BEGV. (Bug#10696)
2561
df0b2940
PE
25622012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2563
2564 Handle overflow when computing char display width (Bug#9496).
2565 * character.c (char_width): Return EMACS_INT, not int.
2566 (char_width, c_string_width): Check for overflow when
2567 computing the width; this is possible now that individual
2568 characters can have unbounded width. Problem introduced
2569 by merge from Emacs 23 on 2012-01-19.
2570
6bee44d6
MA
25712012-02-02 Michael Albinus <michael.albinus@gmx.de>
2572
2573 * dbusbind.c (Fdbus_register_method): Mention the return value
2574 :ignore in the docstring.
2575
44f92739
GM
25762012-02-02 Glenn Morris <rgm@gnu.org>
2577
1b9f60cc
GM
2578 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2579
44f92739
GM
2580 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2581 Unconditionally set to t. (Bug#10673)
2582 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2583 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2584 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2585
c5d3843c
KH
25862012-02-02 Kenichi Handa <handa@m17n.org>
2587
2588 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2589 0, do not call append_composite_glyph.
2590
159462d4 25912012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2592
2593 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2594 NULL (Bug#6988).
2595 (x_produce_glyphs): If the component of a composition is a null
2596 string, set it->pixel_width to 1 to avoid zero-width glyph.
2597
78cef877
EZ
25982012-02-01 Eli Zaretskii <eliz@gnu.org>
2599
2600 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2601 first 2 arguments are identical. This makes inserting large
2602 output from a subprocess an order of magnitude faster on
2603 MS-Windows, where all sbrk'ed memory is always contiguous.
2604
97897668
GM
26052012-01-31 Glenn Morris <rgm@gnu.org>
2606
2607 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2608 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2609 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2610
31fd3586
GM
26112012-01-29 Glenn Morris <rgm@gnu.org>
2612
2613 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2614
0e24a8b2
CY
26152012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2616
2617 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2618
cc0adcb0
CY
26192012-01-28 Chong Yidong <cyd@gnu.org>
2620
2621 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2622
acc28cb9
CY
26232012-01-26 Chong Yidong <cyd@gnu.org>
2624
9c69cfb7
CY
2625 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2626
acc28cb9
CY
2627 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2628 repeat counts (Bug#10507).
2629
48da7392
GM
26302012-01-26 Glenn Morris <rgm@gnu.org>
2631
2632 * lread.c (syms_of_lread): Doc fix.
2633
14af5f7f
CY
26342012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2635
2636 * coding.c (encode_designation_at_bol): Change return value to
2637 EMACS_INT.
2638
0b21c100
CY
26392012-01-25 Chong Yidong <cyd@gnu.org>
2640
2641 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2642
3c2907f7
CY
26432012-01-21 Chong Yidong <cyd@gnu.org>
2644
2645 * floatfns.c (Fcopysign): Make the second argument non-optional,
2646 since nil is not allowed anyway.
2647
959ad23f
AS
26482012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2649
2650 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2651 (send_process): Likewise.
2652
34a02f46
MR
26532012-01-19 Martin Rudalics <rudalics@gmx.at>
2654
2655 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2656 (Vwindow_persistent_parameters): Do not use Qstate.
2657 Rewrite doc-strings.
34a02f46 2658
1259009a 26592012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2660
2661 * character.c (char_width): New function.
70d4fdf6
GM
2662 (Fchar_width, c_string_width, lisp_string_width):
2663 Use char_width (Bug#9496).
25ed9e61 2664
6a6ee00d
MR
26652012-01-16 Martin Rudalics <rudalics@gmx.at>
2666
2667 * window.c (Vwindow_persistent_parameters): New variable.
2668 (Fset_window_configuration, save_window_save): Handle persistent
2669 window parameters.
2670
c85efaf7
EZ
26712012-01-14 Eli Zaretskii <eliz@gnu.org>
2672
2673 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2674 thrashing the stack of the thread. (Bug#9087)
2675
5944709e
PE
26762012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2677
2678 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2679
e71f5d99
EZ
26802012-01-11 Eli Zaretskii <eliz@gnu.org>
2681
2682 * xdisp.c (rows_from_pos_range): Handle the case where the
2683 highlight ends on a newline. (Bug#10464)
2684 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2685 he end column for display of highlight that ends on a newline
2686 before a R2L line.
2687
ce316182
GM
26882012-01-11 Glenn Morris <rgm@gnu.org>
2689
2690 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2691 from load-path also when installation-directory is nil. (Bug#10208)
2692
5b43da69
GM
26932012-01-10 Glenn Morris <rgm@gnu.org>
2694
74cc8ff9
GM
2695 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2696
7d8d6e4e
GM
2697 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2698 Update template values to be closer to their typical values these days.
5b43da69 2699
a0db8d43
EZ
27002012-01-09 Eli Zaretskii <eliz@gnu.org>
2701
2702 * xdisp.c (rows_from_pos_range): Accept additional argument
2703 DISP_STRING, and accept any glyph in a row whose object is that
2704 string as eligible for mouse highlight. Fixes mouse highlight of
2705 display strings from overlays. (Bug#10464)
2706
9a0115ab 27072012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2708
b9110d6a 2709 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2710 * fileio.c (auto_saving_dir_umask): New static var.
2711 (Fmake_directory_internal): Use it.
2712 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2713 creating the directory. The old code temporarily assigns
2714 too-generous permissions to the directory.
2715 (do_auto_save_eh): Clear it.
b9110d6a 2716 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2717 that the var is always cleared.
2718
6c1bd3f3
EZ
27192012-01-07 Eli Zaretskii <eliz@gnu.org>
2720
2721 * search.c (scan_buffer): Pass character positions to
2722 know_region_cache, not byte positions. (Bug#6540)
2723
069d2b50
L
27242012-01-07 LynX <_LynX@bk.ru> (tiny change)
2725
2726 * w32.c (sys_rename): Report EXDEV when rename of a directory
2727 fails because the target is on another logical disk. (Bug#10284)
2728
75bf0d33
DB
27292012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2730
2731 * xterm.c (x_embed_request_focus): New function.
2732
2733 * xterm.h: Add prototype.
2734
2735 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2736
1c6e5a32
GM
27372012-01-05 Glenn Morris <rgm@gnu.org>
2738
2739 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2740
651e947e
EZ
27412012-01-01 Eli Zaretskii <eliz@gnu.org>
2742
2743 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2744 Load gnutls_transport_set_lowat only if GnuTLS version is below
2745 2.11.1.
2746 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2747 GnuTLS versions below 2.11.1.
2748
3778cdd8
AL
27492011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2750
2751 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2752 to the doc string advising against its use for altering the way
2753 windows are scrolled.
2754
0e5317f7
KH
27552011-12-28 Kenichi Handa <handa@m17n.org>
2756
2757 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2758 coding-system ASCII compatible only when it does not produce BOM
2759 on encoding (Bug#10383).
2760
93d5ca1f
JD
27612011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2762
2763 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2764 can scroll.
2765 (create_and_show_popup_menu): Always use menu_position_func for
2766 Gtk3 (Bug#10361).
2767
ca22b785
AS
27682011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2769
2770 * callint.c (Fcall_interactively): Don't truncate prompt string.
2771
d048e1e6
EZ
27722011-12-23 Eli Zaretskii <eliz@gnu.org>
2773
2774 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2775 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2776 resumed from there (after widening). (Bug#10360)
d048e1e6 2777
5ccaba1f
JD
27782011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2779
2780 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2781
204ee57f
JD
27822011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2783
b81d40f0
JB
2784 * nsterm.m (x_free_frame_resources):
2785 Release f->output_data.ns->miniimage.
204ee57f
JD
2786 (ns_index_color): Fix indentation. Do not retain
2787 color_table->colors[i].
2788
2789 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2790 before returning.
2791
2792 * nsfns.m (x_set_background_color): Assign return value from
2793 ns_index_color to face-background instead of NSColor*.
2794 (ns_implicitly_set_icon_type): Fix indentation.
2795 Change assignment in for loop to comparison.
2796
2797 * emacs.c (ns_pool): New variable.
2798 (main): Assign ns_pool.
2799 (Fkill_emacs): Call ns_release_autorelease_pool.
2800
2801 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2802 autorelease fdesc, release fdAttrs and tdict.
2803 (ns_get_covering_families): Release charset.
2804 (ns_findfonts): Release NSFontDescriptor created with new.
2805 (ns_uni_to_glyphs): Fix indentation.
2806 (setString): Release attrStr before assigning new value.
2807
c803b2b7
JD
28082011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2809
678f4426
JD
2810 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2811 and NS_IMPL_COCOA.
2812 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2813 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2814
cd394be1 28152011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2816
5fecd5fc
JD
2817 * nsterm.m (ns_term_init): Subscribe for notifications
2818 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2819 to method trackingNotification in EmacsMenu.
2820
2821 * nsmenu.m (trackingMenu): New variable.
3771cb17 2822 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2823 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2824 from Aquamacs (Bug#7030).
678f4426
JD
2825
28262011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2827
c803b2b7
JD
2828 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2829 (symbol_to_nsstring): Fix indentation.
2830 (ns_symbol_to_pb): New function.
cae07000
SM
2831 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2832 (Fns_rotate_cut_buffers_internal): Remove.
2833 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2834 Fns_store_cut_buffer_internal.
2835 (ns_get_foreign_selection, Fx_own_selection_internal)
2836 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2837 (Fns_get_selection_internal, Fns_store_selection_internal):
2838 Use ns_symbol_to_pb and check if return value is nil.
2839 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2840 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2841 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2842 renamed to Sns_store_selection_internal.
2843 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2844 and remove this function.
2845 (ns_handle_selection_clear): Remove, never used.
2846 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2847 here.
2848
e1b01a3a
KB
28492011-12-17 Ken Brown <kbrown@cornell.edu>
2850
2851 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2852 GID is unknown (Bug#10257).
2853
2adb6e85
PE
28542011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2855
2856 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2857 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2858 which caused a build failure on GNU/Linux IA-64. This problem was
2859 introduced by my 2011-10-07 patch.
2860
d1d7b339
JL
28612011-12-15 Juri Linkov <juri@jurta.org>
2862
2863 * image.c (imagemagick_error): New function. (Bug#10112)
2864 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2865 Use `imagemagick_error' where ImageMagick functions return
2866 `MagickFalse'.
2867 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2868 proper order.
2869
100d5755
KH
28702011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2871
2872 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2873 fill background (Bug#8992).
2874
454592a6
MR
28752011-12-13 Martin Rudalics <rudalics@gmx.at>
2876
2877 * window.c (Vwindow_combination_resize)
2878 (Vwindow_combination_limit): Use t instead of non-nil in
2879 doc-strings.
61d4b438
MR
2880 (Vrecenter_redisplay): Add first sentence of doc-string on
2881 separate line.
53524d93 2882 (Frecenter): Fix doc-string typo.
454592a6 2883
3633e3aa
KH
28842011-12-11 Kenichi Handa <handa@m17n.org>
2885
2886 * coding.c (Funencodable_char_position): Pay attention to the
2887 buffer text relocation (Bug#9389).
2888
7b9d523a 28892011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2890
7b9d523a
JD
2891 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2892 gtk_init (Bug#10100).
2893
b73189c6
EZ
28942011-12-10 Eli Zaretskii <eliz@gnu.org>
2895
2896 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2897 IT->string is nil. (Bug#10263)
2898
f7dfe5d6
JD
28992011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2900
83faebb4
JD
2901 * nsterm.h (x_free_frame_resources): Declare.
2902
f7dfe5d6
JD
2903 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2904 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2905
2906 * nsterm.h (ns_get_defaults_value): Declare.
2907
2908 * nsterm.m (ns_default): Call ns_get_defaults_value.
2909
7cd4e72c
EZ
29102011-12-09 Eli Zaretskii <eliz@gnu.org>
2911
2912 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
2913 (Bug#10170)
2914
b34d7317
YM
29152011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2916
2917 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
2918 that where the value of an _OBJC_* symbol points to is in the .bss
2919 section (Bug#10240).
2920
76470ad1
KH
29212011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2922
2923 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 2924 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 2925
745fff94
KH
29262011-12-08 Kenichi Handa <handa@m17n.org>
2927
2928 * ftfont.c (get_adstyle_property): Fix previous change
2929 (Bug#10233).
2930
6e44397c
JB
29312011-12-07 Juanma Barranquero <lekktu@gmail.com>
2932
2933 * w32.c (init_environment): If no_site_lisp, remove site-lisp
2934 dirs from the default value of EMACSLOADPATH (bug#10208).
2935
7efa6272
GM
29362011-12-07 Glenn Morris <rgm@gnu.org>
2937
2938 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
2939 installation and source directories as well. (Bug#10208)
2940
f6fc4d87
CY
29412011-12-06 Chong Yidong <cyd@gnu.org>
2942
2943 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
2944
2bf26180
GM
29452011-12-06 Glenn Morris <rgm@gnu.org>
2946
2947 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
2948 as an error, not just -1. (Bug#10217)
2949
3a6ad4f0
CY
29502011-12-05 Chong Yidong <cyd@gnu.org>
2951
2952 * keyboard.c (process_special_events): New function.
2953 (swallow_events, Finput_pending_p): Use it (Bug#10195).
2954
75a3b399
PE
29552011-12-05 Paul Eggert <eggert@cs.ucla.edu>
2956
2957 * coding.c (encode_designation_at_bol): Don't use uninitialized
2958 local variable (Bug#9318).
2959
c3c9e25e
KH
29602011-12-05 Kenichi Handa <handa@m17n.org>
2961
2962 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
2963 return Qnil (Bug#8046, Bug#10193).
2964
5eb05ea3
KH
29652011-12-05 Kenichi Handa <handa@m17n.org>
2966
2967 * coding.c (encode_designation_at_bol): New args charbuf_end and
2968 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
2969 (coding_set_source): Return how many bytes coding->source was
2970 relocated.
2971 (coding_set_destination): Return how many bytes
2972 coding->destination was relocated.
2973 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 2974 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
2975
29762011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
2977
2978 * coding.c (CODING_CHAR_CHARSET_P): New macro.
2979 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
2980 macro (Bug#9318).
2981
29822011-12-05 Andreas Schwab <schwab@linux-m68k.org>
2983
2984 The following changes are to fix Bug#9318.
2985
a79703f5 2986 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
2987 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
2988 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 2989 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 2990
7dbda6df
JB
29912011-12-05 Juanma Barranquero <lekktu@gmail.com>
2992
2993 * lisp.h (process_quit_flag): Fix external declaration.
2994
6d5eb5b0
SM
29952011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
2996
2997 Don't macro-inline non-performance-critical code.
2998 * eval.c (process_quit_flag): New function.
2999 * lisp.h (QUIT): Use it.
3000
a0c3fad0
JD
30012011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3002
3003 * nsfns.m (get_geometry_from_preferences): New function.
3004 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3005
6c07aac2
AS
30062011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3007
3008 * emacs.c (Qkill_emacs): Define.
3009 (syms_of_emacs): Initialize it.
3010 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3011 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3012 (quit_throw_to_read_char): Add parameter `from_signal'.
3013 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3014 * lisp.h (QUIT): Call Fkill_emacs if requested.
3015
c052ead4
JD
30162011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3017
3018 * widget.c (update_wm_hints): Return if wmshell is null.
3019 (widget_update_wm_size_hints): New function.
3020
3021 * widget.h (widget_update_wm_size_hints): Declare.
3022
3023 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3024 widget_update_wm_size_hints (Bug#10104).
3025
9e49252b
EZ
30262011-12-03 Eli Zaretskii <eliz@gnu.org>
3027
3028 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3029 before a newline, prepare the bidi iterator for consuming the
3030 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3031 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3032
02b16839
JL
30332011-12-02 Juri Linkov <juri@jurta.org>
3034
3035 * search.c (Fword_search_regexp): New Lisp function created from
3036 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3037 (Fword_search_backward, Fword_search_forward)
3038 (Fword_search_backward_lax, Fword_search_forward_lax):
3039 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3040 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3041
0068070e
SM
30422011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3043
3044 * fileio.c (Finsert_file_contents): Move after-change-function call
3045 to before the "handled:" label, since all "goto handled" appear in
3046 cases where the *-change-functions have already been properly called
3047 (bug#10117).
3048
3360a3fc
AS
30492011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3050
3051 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3052 waiting for input. (Bug#10169)
3053
73d6c093
EZ
30542011-11-30 Eli Zaretskii <eliz@gnu.org>
3055
3056 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3057 verifies glyph row's hash code--we have just reallocated the
3058 glyphs, so their contents can be complete garbage. (Bug#10164)
3059
febe6bea
JB
30602011-11-30 Juanma Barranquero <lekktu@gmail.com>
3061
3062 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3063
801a4313
EZ
30642011-11-30 Eli Zaretskii <eliz@gnu.org>
3065
3066 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3067 attributes are tested _before_ calling verify_row_hash, to protect
3068 against GCC re-ordering of the tests. (Bug#10164)
3069
2b56b87e
JD
30702011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3071
3072 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3073
3074 * xterm.c (handle_one_xevent): Only set async_visible and friends
3075 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3076 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3077 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3078
dbf31225
PE
30792011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3080
3081 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3082 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3083 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3084 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3085 All uses changed to use GCPRO1 etc.
3086 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3087 Revert to old implementation (i.e., before 2011-03-11).
3088
1305621b
YM
30892011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3090
3091 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3092 of scroll runs so as to avoid assigning disabled bogus rows and
3093 unnecessary graphics copy operations.
3094
8c9afb46
EZ
30952011-11-27 Eli Zaretskii <eliz@gnu.org>
3096
3097 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3098 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3099 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3100 (malloc, free, realloc, calloc): Redirect to e_* only when
3101 compiling Emacs.
3102
3103 * lisp.h (GCTYPEBITS): Move before first use.
3104 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3105 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3106 this macro definition.
3107
3108 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3109 _MSC_VER.
3110
54e9e3bf
JD
31112011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3112
6d5eb5b0
SM
3113 * gtkutil.c (xg_create_frame_widgets):
3114 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3115 present with Gtk+ 2.0.
3116
83aca1cb
PE
31172011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3118
3119 * fileio.c (Finsert_file_contents): Undo previous change; see
3120 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3121
5b76caa4
PE
31222011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 Rename locals to avoid shadowing.
3125 * fileio.c (Finsert_file_contents):
3126 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3127 * process.c (wait_reading_process_output):
3128 Rename inner 'proc' to 'p' to avoid shadowing.
3129 Indent for consistency with usual Emacs style.
3130
8c535114
EZ
31312011-11-25 Eli Zaretskii <eliz@gnu.org>
3132
3133 * xdisp.c (redisplay_window): If cursor row is not fully visible
3134 after recentering, and scroll-conservatively is set to a large
3135 number, scroll window by a few more lines to make the cursor fully
3136 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3137 (start_display): Don't move to the next line if the display should
3138 start at a newline that is part of a display vector or an overlay
3139 string. (Bug#10119)
8c535114 3140
fa4fdb5c
JL
31412011-11-24 Juri Linkov <juri@jurta.org>
3142
3143 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3144 after the `MagickPingImage' call. (Bug#10112)
3145
90ec88df
CY
31462011-11-23 Chong Yidong <cyd@gnu.org>
3147
3148 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3149
56e2e794
MR
31502011-11-23 Martin Rudalics <rudalics@gmx.at>
3151
3152 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3153 making another buffer current. (Bug#10114)
3154
b6e64c41
GM
31552011-11-23 Glenn Morris <rgm@gnu.org>
3156
3157 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3158
6b21de18
CY
31592011-11-23 Chong Yidong <cyd@gnu.org>
3160
3161 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3162 using it (Bug#5984).
3163
b12cd789
EZ
31642011-11-22 Eli Zaretskii <eliz@gnu.org>
3165
3166 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3167 and header-lines, as they don't have one computed for them.
3168 (Bug#10098)
3169
3170 * .gdbinit (prow): Make displayed values more self-explaining.
3171 Add row's hash code.
3172
261b6fd4
LMI
31732011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3174
3175 * process.c (wait_reading_process_output): Fix asynchrounous
3176 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3177 (wait_reading_process_output): Add comment and URL.
261b6fd4 3178
e7cfd277
JD
31792011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3180
3181 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3182
a9b9b7f5
CY
31832011-11-21 Chong Yidong <cyd@gnu.org>
3184
3185 * window.c (Fnext_window, Fprevious_window): Doc fix.
3186
b0d15b4f
SM
31872011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3188
3189 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3190
fe7a3057
JB
31912011-11-20 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3194
d2999b1a
MR
31952011-11-20 Martin Rudalics <rudalics@gmx.at>
3196
3197 * window.c (Fset_window_combination_limit): Rename argument
3198 STATUS to LIMIT.
3199 (Vwindow_combination_limit): Remove "status" from doc-string.
3200
d5ff9cd0
AS
32012011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3202
3203 * m/ibms390.h: Remove.
3204 * m/ibms390x.h: Don't include "ibms390.h".
3205
a5bb9bd3
SM
32062011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3207
3208 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3209 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3210
cd1181db
JB
32112011-11-20 Juanma Barranquero <lekktu@gmail.com>
3212
3213 * casetab.c (Fset_case_table):
3214 * charset.c (Fcharset_after): Fix typos.
3215
615a3b8d 32162011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3217
17e845af
PE
3218 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3219 Otherwise, valgrind does not work on some platforms.
3220 Problem reported by Andreas Schwab in
6a0bf43d
PE
3221 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3222 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3223 is set, removing the need for VIRT_ADDRESS_VARIES.
3224 (PURE_P): Use a more-efficient implementation that needs just one
3225 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3226 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3227 to 4 (xorl, subq, cmpq, setbe).
3228 * alloc.c (pure): Always extern now, since that's the
3229 VIRT_ADDR_VARIES behavior.
3230 (PURE_POINTER_P): Use a single comparison, not two, for
3231 consistency with the new puresize.h.
3232 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3233 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3234 Remove VIRT_ADDR_VARIES no longer needed.
3235
f8fe6f96
EZ
32362011-11-19 Eli Zaretskii <eliz@gnu.org>
3237
3238 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3239 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3240 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3241 behave as if the cursor position were at the window margin.
3242
3243 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3244 and the cursor position is out of bounds, behave as if the cursor
3245 position were at the window margin. (Bug#10075)
3246
df05a53c
CY
32472011-11-18 Chong Yidong <cyd@gnu.org>
3248
3249 * window.c (Fwindow_combination_limit): Make first argument
3250 non-optional, since it is meaningless for live windows like the
3251 selected window.
61ccba97 3252
2071918e
DA
32532011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3254
3255 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3256
b50a28de
SM
32572011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3258
3259 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3260 (graft_intervals_into_buffer): Simplify.
3261
015137db
EZ
32622011-11-18 Eli Zaretskii <eliz@gnu.org>
3263
3264 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3265 hash values of the two rows.
3266 (copy_row_except_pointers): Preserve the used[] arrays and the
3267 hash values of the two rows. (Bug#10035)
68c95424 3268 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3269
3270 * xdisp.c (row_hash): New function, body extracted from
3271 compute_line_metrics.
3272 (compute_line_metrics): Call row_hash, instead of computing the
3273 hash code inline.
3274
3275 * dispnew.c (verify_row_hash): Call row_hash for computing the
3276 hash code of a row, instead of duplicating code from xdisp.c.
3277
3278 * dispextern.h (row_hash): Add prototype.
3279
a2addb04
TH
32802011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3281
3282 * frame.c (delete_frame): Don't delete the terminal when the last
3283 X frame is closed if emacs is built with GTK toolkit.
3284
df85d315
JB
32852011-11-17 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3288
a0c2d0ae
MR
32892011-11-17 Martin Rudalics <rudalics@gmx.at>
3290
3291 * window.c (Vwindow_splits): Rename to
3292 Vwindow_combination_resize. Suggested by Juri Linkov.
3293 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3294 of Vwindow_splits.
3295
58179cce
JB
32962011-11-16 Juanma Barranquero <lekktu@gmail.com>
3297
7877f373
JB
3298 * nsfns.m (Fns_font_name):
3299 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3300
b6f67890
MR
33012011-11-16 Martin Rudalics <rudalics@gmx.at>
3302
3303 * window.h (window): Rename slot "nest" to "combination_limit".
3304 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3305 (Fset_window_nest): Rename to Fset_window_combination_limit.
3306 (Vwindow_nest): Rename to Vwindow_combination_limit.
3307 (recombine_windows, make_parent_window, make_window)
3308 (Fsplit_window_internal, saved_window)
3309 (Fset_window_configuration, save_window_save): Rename all
3310 occurrences of window_nest to window_combination_limit.
3311
c7015153
JB
33122011-11-15 Juanma Barranquero <lekktu@gmail.com>
3313
3314 * image.c (imagemagick_load_image): Fix typo.
3315
322ad6ec
EZ
33162011-11-14 Eli Zaretskii <eliz@gnu.org>
3317
3318 * xdisp.c (display_line): Move the call to
3319 highlight_trailing_whitespace before the call to
3320 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3321 faces of all the glyphs to compute ROW's hash value.
3322 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3323
f067b8ec
JB
33242011-11-14 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3327 just return (bug#10044).
3328
1e5b2111
EZ
33292011-11-12 Eli Zaretskii <eliz@gnu.org>
3330
7ef3cbd5
EZ
3331 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3332 with user-defined heap size. Bump the default size of the temacs
3333 heap to 27MB, to avoid memory warning when running temacs.
3334 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3335
1e5b2111
EZ
3336 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3337 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3338 (verify_row_hash) [XASSERTS]: New function.
3339 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3340 that the hash value of glyph rows is correct.
1e5b2111 3341
89d61221
MR
33422011-11-12 Martin Rudalics <rudalics@gmx.at>
3343
3344 * window.h (window): Remove splits slot.
3345 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3346 (Fdelete_other_windows_internal, make_parent_window)
3347 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3348 (Fset_window_configuration, save_window_save): Don't deal with
3349 split status of windows.
3350 (saved_window): Remove splits slot.
3351 (Vwindow_splits): Rewrite doc-string.
3352
97f18cc8
JD
33532011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3354
3355 * xfns.c (unwind_create_frame):
3356 * nsfns.m (unwind_create_frame):
3357 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3358 Vframe_list (Bug#9999).
3359
22a648b4
DA
33602011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3361
0b381c7e 3362 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3363
659afede
KH
33642011-11-11 Kenichi Handa <handa@m17n.org>
3365
3366 * callproc.c (Fcall_process): Set the member dst_multibyte of
3367 process_coding.
3368
9ac0394b
KH
33692011-11-11 Johan Bockgård <bojohan@gnu.org>
3370
3371 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3372 avoid a crash (bug#9496).
3373
2fbdc249
CY
33742011-11-09 Chong Yidong <cyd@gnu.org>
3375
3376 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3377 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3378
ac6b1f81
PE
33792011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3380
3381 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3382
09db192c
PE
33832011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3384
3385 Avoid some portability problems by eschewing 'extern inline' functions.
3386 The trivial performance wins aren't worth the portability hassles; see
3387 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3388 et seq.
3389 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3390 (window_box_width, window_box_left, window_box_left_offset)
3391 (window_box_right, window_box_right_offset): Undo previous change,
3392 by removing the "extern"s.
3393 * intervals.c (adjust_intervals_for_insertion)
3394 (adjust_intervals_for_deletion): Undo previous change,
3395 making these static again.
3396 (offset_intervals, temp_set_point_both, temp_set_point)
3397 (copy_intervals_to_string): No longer inline.
3398 * xdisp.c (window_text_bottom_y, window_box_width)
3399 (window_box_height, window_box_left_offset)
3400 (window_box_right_offset, window_box_left, window_box_right)
3401 (window_box): No longer inline.
3402
105216ed
CY
34032011-11-08 Chong Yidong <cyd@gnu.org>
3404
3405 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3406 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3407 Signal an error if not a live window.
105216ed
CY
3408 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3409 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3410
ae9e237f
JB
34112011-11-07 Juanma Barranquero <lekktu@gmail.com>
3412
3413 * lisp.h (syms_of_abbrev): Remove declaration.
3414 Reported by CHENG Gao <chenggao@royau.me>.
3415
c7aa8333
EZ
34162011-11-07 Eli Zaretskii <eliz@gnu.org>
3417
3418 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3419 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3420 of temacs in GUI mode.
3421
be7f5545
MR
34222011-11-07 Martin Rudalics <rudalics@gmx.at>
3423
3424 * window.h: Declare delete_all_child_windows instead of
3425 delete_all_subwindows.
3426 * window.c (Fwindow_nest, Fset_window_nest)
3427 (Fset_window_new_total, Fset_window_new_normal)
3428 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3429 (delete_all_subwindows): Rename to delete_all_child_windows.
3430 (Fdelete_other_windows_internal, Fset_window_configuration):
3431 Call delete_all_child_windows instead of delete_all_subwindows.
3432 * frame.c (delete_frame): Call delete_all_child_windows instead
3433 of delete_all_subwindows.
3434
ca78dc43
PE
34352011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3436
3437 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3438 This is also needed for porting to any host where GC_MARK_STACK is
3439 not GC_MAKE_GCPROS_NOOPS.
3440 (which_symbols): Use it.
3441
a0241d01
KH
34422011-11-07 Kenichi Handa <handa@m17n.org>
3443
3444 * coding.c (coding_set_destination): Check coding->src_pos only
3445 when coding->src_object is a buffer (bug#9910).
3446
3447 * process.c (send_process): Set the member src_multibyte of coding
3448 to 0 (bug#9911) when sending a unibyte text.
3449
3450 * callproc.c (Fcall_process): Set the member src_multibyte of
3451 process_coding to 0 (bug#9912).
3452
a64bfdfa 34532011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3454
3455 * xmenu.c (cleanup_widget_value_tree): New function.
3456 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3457 calling free_menubar_widget_value_tree directly (Bug#9830).
3458
cb41b32a
PE
34592011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3460
3461 Fix some portability problems with 'inline'.
3462 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3463 (window_box_width, window_box_left, window_box_left_offset)
3464 (window_box_right, window_box_right_offset): Declare extern.
3465 Otherwise, these inline functions do not conform to C99 and
3466 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3468 * intervals.c (adjust_intervals_for_insertion)
3469 (adjust_intervals_for_deletion): Now extern, because otherwise the
3470 extern inline functions 'offset_intervals' couldn't refer to it.
3471 (static_offset_intervals): Remove.
3472 (offset_intervals): Rewrite using the old contents of
3473 static_offset_intervals. The old version didn't conform to C99
3474 because an extern inline function contained a reference to an
3475 identifier with static linkage.
3476
b7041366
AS
34772011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3478
3479 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3480 GC.
3481
88a37c4d
EZ
34822011-11-06 Eli Zaretskii <eliz@gnu.org>
3483
3484 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3485 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3486 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3487 return Qleft_to_right.
3488
49745b39
CY
34892011-11-06 Chong Yidong <cyd@gnu.org>
3490
3491 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3492 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3493 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3494 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3495 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3496 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3497 (Fwindow_vscroll): Doc fix.
3498 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3499 argument, since it makes no sense to pass a live window and for
3500 consistency with window-child.
3501
1f05cd82
CS
35022011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3503
3504 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3505 support MSVC.
3506
22610910
JR
35072011-11-05 Jason Rumney <jasonr@gnu.org>
3508
3509 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3510 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3511 fonts (Bug#6029).
3512 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3513 bitwise arithmetic preventing use of unicode-sip and non-truetype
3514 opentype fonts.
3515
a06776b2
EZ
35162011-11-05 Eli Zaretskii <eliz@gnu.org>
3517
3ad924ba
EZ
3518 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3519 "emacs"-only part.
3520
a06776b2
EZ
3521 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3522 initialization code to keep similarity to xfns.c after changes
3523 from 2011-11-05.
3524
c9e7db78
JD
35252011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3526
a97f8f3f
JD
3527 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3528 (unwind_create_frame): New function (Bug#9943).
3529 (Fx_create_frame): Restructure code to be more similar to the one in
3530 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3531 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3532 Move terminal->reference_count++ just before making the frame official
3533 (Bug#9943).
3534
3535 * nsterm.m (x_free_frame_resources): New function.
3536 (x_destroy_window): Move code to x_free_frame_resources.
3537
c9e7db78 3538 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3539 (Fx_create_frame, x_create_tip_frame):
3540 Move terminal->reference_count++ just before making the frame
75f1671a 3541 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3542 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3543
a6fc3b5c
EZ
35442011-11-05 Eli Zaretskii <eliz@gnu.org>
3545
3546 Support MSVC build with newer versions of Visual Studio.
3547 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3548 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3549 nt/gmake.defs.
3550
3551 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3552 which are not supported by MSVC.
3553 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3554 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3555 bitfields.
3556 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3557 types in bitfields.
3558 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3559
3560 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3561
58179cce 35622011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3563
3564 Support MSVC build with newer versions of Visual Studio.
3565 * w32.c: Don't include w32api.h for MSVC.
3566 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3567
3568 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3569 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3570 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3571 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3572 e_* cousins.
3573 (alloca) [_MSC_VER]: Define to _alloca.
3574
3575 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3576
3577 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3578
a58c13ed
EZ
35792011-11-04 Eli Zaretskii <eliz@gnu.org>
3580
3581 * xdisp.c (note_mouse_highlight): If either of
3582 previous/next-single-property-change returns nil, treat that as
3583 the beginning or the end of the buffer. (Bug#9955)
3584
fe0b6370
JD
35852011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3586
a58c13ed 3587 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3588 label is not null (Bug#9951).
3589 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3590 may be NULL.
3591
89bd5ee1
EZ
35922011-11-04 Eli Zaretskii <eliz@gnu.org>
3593
3594 * window.c (Fwindow_body_size): Mention in the doc string that the
3595 return value is in frame's canonical units. (Bug#9949)
3596
84c3edb9
EZ
35972011-11-03 Eli Zaretskii <eliz@gnu.org>
3598
4e2fb5c7
EZ
3599 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3600
84c3edb9 3601 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3602 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3603 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3604
bc17a887
EZ
36052011-11-01 Eli Zaretskii <eliz@gnu.org>
3606
3607 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3608 Don't stop backward scan on the continuation glyph, even though
3609 its CHARPOS is positive.
6d5eb5b0
SM
3610 (mouse_face_from_buffer_pos, note_mouse_highlight):
3611 Rename cover_string to disp_string.
bc17a887 3612
4ee88440
MR
36132011-11-01 Martin Rudalics <rudalics@gmx.at>
3614
3615 * window.c (temp_output_buffer_show): Don't use
3616 Vtemp_buffer_show_specifiers.
3617 (Vtemp_buffer_show_specifiers): Remove unused variable.
3618
c2ff3c02
EZ
36192011-10-30 Eli Zaretskii <eliz@gnu.org>
3620
3621 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3622 past the beginning of the current glyph matrix.
3623
58179cce 36242011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3625
3626 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3627 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3628 HAVE_GTK3 (Bug#9869).
b77a6a7f 3629
3b574623
JD
3630 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3631 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3632
b77a6a7f
JD
3633 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3634
3635 * xterm.c: Declare x_handle_net_wm_state to return int.
3636 (handle_one_xevent): Check if we are iconified but don't have
3637 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3638 (get_current_wm_state): Return non-zero if not hidden,
3639 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3640 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3641 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3642 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3643
196e41e4
PE
36442011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3645
3646 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3647 so that this new function doesn't get optimized away by a
3648 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3649
021f2e1a
AS
36502011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3651
3652 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3653
8b058d44
EZ
36542011-10-29 Eli Zaretskii <eliz@gnu.org>
3655
3656 Fix the `xbytecode' command.
3657 * .gdbinit (xprintbytestr): New command.
b50a28de 3658 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3659 (xbytecode): Print the byte-code string as well.
3660
4452fb80
EZ
36612011-10-29 Kim Storm <storm@cua.dk>
3662
8b058d44
EZ
3663 * alloc.c (which_symbols): New function.
3664
21b72067
AS
36652011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3666
3667 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3668 line. (Bug#9903)
3669
83ed7b5c
GM
36702011-10-29 Glenn Morris <rgm@gnu.org>
3671
3672 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3673 Not clear what it was for, and it causes various bugs. (Bug#9839)
3674
5a7a728b
EZ
36752011-10-28 Eli Zaretskii <eliz@gnu.org>
3676
3677 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3678 possible random value that matches one of those tested as
3679 condition to clear the mouse face.
3680
d3d0842f
CY
36812011-10-28 Chong Yidong <cyd@gnu.org>
3682
3683 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3684
31b39d13
DN
36852011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3686
3687 * window.c (make_window): Initialize phys_cursor_on_p.
3688
9aba6043
SM
36892011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3690
3691 * lisp.h (struct Lisp_Symbol): Update comments.
3692
c20992f4
JB
36932011-10-28 Juanma Barranquero <lekktu@gmail.com>
3694
3695 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3696
db4f02f2
EZ
36972011-10-28 Eli Zaretskii <eliz@gnu.org>
3698
3699 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3700 <oslsachem@gmail.com> for helping to debug this.
3701
3702 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3703 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3704 (g_b_init_get_glyph_outline_w): New static variables.
3705 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3706 (GetGlyphOutlineW_Proc): New typedefs.
3707 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3708 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3709 New functions.
3710 (w32font_open_internal, compute_metrics):
3711 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3712 instead of calling the "wide" APIs directly.
3713
3714 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3715
3716 * w32.h (syms_of_w32font): Add prototype.
3717
87e68db4
JB
37182011-10-27 Juanma Barranquero <lekktu@gmail.com>
3719
3720 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3721 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3722 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3723 (Fmove_to_window_line): Doc fix.
3724
435c1d67
CY
37252011-10-27 Chong Yidong <cyd@gnu.org>
3726
3727 * process.c (make_process): Set gnutls_state to NULL.
3728
3729 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3730 non-NULL, regardless of GNUTLS_INITSTAGE.
3731 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3732 an error. Set process slots as soon as we allocate them.
3733
3734 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3735
9c6c6f49
CY
37362011-10-27 Chong Yidong <cyd@gnu.org>
3737
9aba6043
SM
3738 * gnutls.c (emacs_gnutls_deinit): New function.
3739 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3740 (Fgnutls_deinit, Fgnutls_boot): Use it.
3741
3742 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3743 (deactivate_process): Call emacs_gnutls_deinit.
3744
657d08d3
JB
37452011-10-27 Juanma Barranquero <lekktu@gmail.com>
3746
3747 * image.c (x_create_x_image_and_pixmap):
3748 * w32.c (sys_rename, w32_delayed_load):
3749 * w32font.c (fill_in_logfont):
3750 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3751
5430d399
JB
37522011-10-26 Juanma Barranquero <lekktu@gmail.com>
3753
3754 * w32fns.c (w32_default_color_map): New function,
3755 extracted from Fw32_default_color_map.
a7ef684b 3756 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3757
fe0055fa
PE
37582011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3759
3760 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3761
e6346438
SM
37622011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3763
3764 * keyboard.c (test_undefined): New function (bug#9751).
3765 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3766
e112cc37
ET
37672011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3768
3769 * sysdep.c (init_sys_modes): Fix the check for the controlling
3770 terminal (Bug#6649).
3771
7b5d6677
EZ
37722011-10-20 Eli Zaretskii <eliz@gnu.org>
3773
3774 * dispextern.h (struct bidi_it): New member next_en_type.
3775
3776 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3777 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3778 current character, check also for next_en_type being WEAK_EN.
3779 (bidi_resolve_weak): Don't enter the expensive loop if the current
3780 position is before next_en_pos. Record the bidi type of the first
3781 non-ET, non-BN character we find, in addition to its position.
3782 (bidi_level_of_next_char): Invalidate next_en_type when
3783 next_en_pos is over-stepped.
3784
7da0b018
PE
37852011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3786
3787 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3788 * editfns.c: Rewrite current-time-zone so that it invokes
3789 the equivalent of (format-time-string "%Z") to get the time zone name.
3790 This fixes a bug when the time zone name contains characters that
3791 need converting from the system time locale to Emacs internal format.
3792 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3793 that patch fixed format-time-string to do the conversion, but
3794 I forgot to fix current-time-zone.
3795 (format_time_string): New function, containing most of
3796 what Fformat_time_string used to contain.
3797 (Fformat_time_string): Rewrite in terms of format_time_string.
3798 This doesn't change this function's behavior.
3799 (current-time-zone): Rewrite to use format_time_string.
3800 This fixes the bug reported by Michael Schierl in
3801 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3802 Jason Rumney's 2007-06-07 change worked around this bug, but
3803 didn't fix it.
3804 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3805
8547b010
EZ
38062011-10-19 Eli Zaretskii <eliz@gnu.org>
3807
3808 * xdisp.c (start_display): If the character at POS is displayed
3809 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3810 (try_window_reusing_current_matrix): If a line ends in a display
3811 vector or the next line starts in a display vector, continue
3812 redrawing the window even though the character position of
3813 start_row was reached.
8547b010
EZ
3814 (Bug#9771, part 2)
3815
4e948d15
CY
38162011-10-18 Chong Yidong <cyd@gnu.org>
3817
3818 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3819 with nobreak-char-display too.
3820
4787455f
EZ
38212011-10-18 Eli Zaretskii <eliz@gnu.org>
3822
3823 Fix part 3 of bug#9771.
3824 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3825 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3826 non-neutral characters if the current character is a paragraph
3827 separator (a.k.a. Newline). This avoids running the same
3828 expensive loop twice, once when we consume the preceding newline
3829 and the other time when the line actually needs to be displayed.
3830 Avoid the loop when we see neutrals on the base embedding level
3831 following a character whose directionality is the same as the
3832 paragraph's. This avoids running the expensive loop when a line
3833 ends in a long sequence of neutrals, like control characters.
3834 Add assertion against STRONG_AL type. Slightly rearrange code
3835 that determines the type of a neutral given the first non-neutral
3836 that follows it.
3837 (bidi_level_of_next_char): Set next_en_pos to zero when
3838 invalidating its info.
3839
2c91f553
EZ
38402011-10-17 Eli Zaretskii <eliz@gnu.org>
3841
3842 * xdisp.c (push_display_prop): Determine whether to record string
3843 or buffer position by IT->string, not by IT->method. Allow
3844 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3845 (move_it_vertically_backward): Don't look for character position
3846 immediately after the newline when in a continuation line.
3847 (Bug#9771, part 1)
2c91f553 3848
c7b08b0d
MR
38492011-10-15 Martin Rudalics <rudalics@gmx.at>
3850
3851 * window.c (coordinates_in_window): Rewrite and delabelize
3852 vertical border check. (Bug#5357) (Bug#9618)
3853
6b02f655
SM
38542011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3855
3856 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3857 errors in XSetWindowBorder (bug#9310).
3858
81d40c92
DA
38592011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3860
3861 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3862 avoid crash when xmalloc overrun checking is enabled.
3863
d4172c3b
EZ
38642011-10-13 Eli Zaretskii <eliz@gnu.org>
3865
3866 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3867 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3868 cursor motion with <left> and <right> arrow keys.
3869
3870 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3871 some callers set that themselves.
3872
b00eea75
EZ
38732011-10-12 Eli Zaretskii <eliz@gnu.org>
3874
3875 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3876 display string and the previous row comes from the same string and
3877 is empty. (Bug#9739) (Bug#9738)
3878
8fe012c4
SM
38792011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3880
3881 * doc.c (get_doc_string): Encode file name (bug#9735).
3882
0074aef2
EZ
38832011-10-12 Eli Zaretskii <eliz@gnu.org>
3884
79beb178
EZ
3885 * bidi.c (bidi_level_of_next_char):
3886 * xdisp.c (get_visually_first_element): Remove old incorrect
3887 comments regarding the Unicode Line Separator character.
3888
0074aef2
EZ
3889 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3890
6e4b3fbe
DA
38912011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3892
3893 * alloc.c (Fgc_status): Do not access beyond zombies array
3894 boundary if nzombies > MAX_ZOMBIES.
3895 * alloc.c (dump_zombies): Add missing format specifier.
3896
0324f3af
PE
38972011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3898
b5525cac
PE
3899 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3900 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3901
0324f3af
PE
3902 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3903 Some packages use them to denote characters with modifiers.
3904
e9b5f888
AS
39052011-10-11 Andreas Schwab <schwab@linux-m68k.org>
3906
3907 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
3908 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
3909 matching a pp-number. Rename parameter var to var1.
3910
127827c0
SM
39112011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
3912
3913 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
3914
c8fd3bd0
GM
39152011-10-08 Glenn Morris <rgm@gnu.org>
3916
3917 * callint.c (Fcall_interactively): Give a more explicit error for the
3918 'c' case with a non-character input. (Bug#8479)
3919
352ec8ff
EZ
39202011-10-08 Eli Zaretskii <eliz@gnu.org>
3921
03669ccb
EZ
3922 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
3923 lines.
7061c986
EZ
3924 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
3925 lines that are hscrolled on the left.
03669ccb 3926
352ec8ff
EZ
3927 * dispnew.c (buffer_posn_from_coords): Account for a possible
3928 presence of header-line. (Bug#4426)
3929
a66cfb1c
SM
39302011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
3931
6b02f655
SM
3932 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
3933 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 3934
7c5ee88e
PE
39352011-10-07 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
3938 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
3939 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
3940 this makes Emacs dump core during garbage collection on rare
3941 occasions. sizeof is obviously inferior to offsetof here, so
3942 stick with offsetof.
3943 (GC_POINTER_ALIGNMENT): New macro.
3944 (mark_memory): Omit 3rd (offset) arg; caller changed.
3945 Don't assume EMACS_INT alignment is the same as pointer alignment.
3946
df1bbe5b
SM
39472011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
3948
3949 * keyboard.c (read_key_sequence_remapped): New var.
3950 (read_key_sequence): Compute remapping in the right buffer.
3951 (command_loop_1): Use read_key_sequence's remapping directly.
3952
51553db6
SM
39532011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
3954
32c1fffd
SM
3955 * dired.c (file_name_completion): Don't expand file name.
3956 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
3957 before checking file name handler.
3958
51553db6
SM
3959 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
3960 they've been requested explicitly (bug#9591).
3961
b6bd1599 39622011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
3963
3964 * keymap.c (Fsingle_key_description): Use make_specified_string
3965 instead of build_string to build string from push_key_description.
3966 (Bug#5193)
3967
f701dc2a
PE
39682011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3969
4222c55d
PE
3970 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
3971 This fixes a Y2038 bug on 64-bit hosts.
3972 * buffer.c (reset_buffer):
3973 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
3974 (Fclear_buffer_auto_save_failure):
3975 Use 0, not -1, to represent an unset failure time, since time_t
3976 might not be signed.
3977
f701dc2a
PE
3978 Remove dependency on glibc malloc internals.
3979 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3980 Move back here from lisp.h, but with their new implementations.
3981 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3982 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
3983 * charset.c (charset_table_init): New static var.
3984 (syms_of_charset): Use it instead of xmalloc. This removes a
3985 dependency on glibc malloc internals. See Eli Zaretskii's comment in
3986 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
3987 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
3988 Move back to alloc.c.
3989 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
3990 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
3991
9ceebf39
JD
39922011-09-30 Jan Djärv <jan.h.d@swipnet.se>
3993
3994 * nsterm.m (windowDidResize): Call x_set_window_size only when
3995 ns_in_resize is true. Otherwise set pixelwidth/height and
3996 call change_frame_size (Bug#9628).
3997
cb993c58
PE
39982011-09-30 Paul Eggert <eggert@cs.ucla.edu>
3999
3930c88b
PE
4000 Port --enable-checking=all to Fedora 14 x86-64.
4001 * charset.c (syms_of_charset): Also account for glibc malloc's
4002 internal overhead when calculating the initial malloc maximum.
4003
cb993c58
PE
4004 Port --enable-checking=all to Fedora 14 x86.
4005 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4006 Move to lisp.h.
4007 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4008 (overrun_check_realloc, overrun_check_free):
4009 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4010 That way, xmalloc returns a properly-aligned pointer even if
4011 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4012 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4013 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4014 into account when calculating the initial malloc maximum.
4015 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4016 Move here from alloc.c, so that charset.c can use it too.
4017 Properly align; the old code wasn't right for common 32-bit hosts
4018 when configured with --enable-checking=all.
4019 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4020 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4021
31bed486
EZ
40222011-09-29 Eli Zaretskii <eliz@gnu.org>
4023
04c70788 4024 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4025 use EDOM.
4026
fbcaa2f3
EZ
40272011-09-28 Eli Zaretskii <eliz@gnu.org>
4028
4029 * xdisp.c (compute_display_string_end): If there's no display
4030 string at CHARPOS, return -1.
4031
4032 * bidi.c (bidi_fetch_char): When compute_display_string_end
4033 returns a negative value, treat the character as a normal
4034 character not covered by a display string. (Bug#9624)
4035
a239d4e9
JB
40362011-09-28 Juanma Barranquero <lekktu@gmail.com>
4037
4038 * lread.c (Fread_from_string): Fix typo in docstring.
4039
88652fd5
EZ
40402011-09-27 Eli Zaretskii <eliz@gnu.org>
4041
4042 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4043 newline, reseat the iterator instead of bidi-iterating there one
4044 character at a time. (Bug#9610)
32c1fffd
SM
4045 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4046 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4047
ed497dd4
AS
40482011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4049
4050 * lread.c (readevalloop): Use correct code for NBSP.
4051 (read1): Likewise. (Bug#9608)
4052
b2bf61aa
MA
40532011-09-25 Michael Albinus <michael.albinus@gmx.de>
4054
4055 * dbusbind.c (Fdbus_register_signal): When service is not
4056 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4057
32bbb17c
GM
40582011-09-25 Glenn Morris <rgm@gnu.org>
4059
4060 * buffer.c (truncate-lines): Doc fix.
4061
94e0933e
CY
40622011-09-24 Chong Yidong <cyd@stupidchicken.com>
4063
4064 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4065 (Fset_window_next_buffers): Doc fix.
4066
cddde921
GM
40672011-09-24 Glenn Morris <rgm@gnu.org>
4068
4069 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4070
1260aef1
PE
40712011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4072
25b4bfa0
PE
4073 Fix minor problems found by static checking.
4074 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4075 * indent.c (Fvertical_motion): Fix == vs = typo.
4076
e3cbd34b
EZ
40772011-09-24 Eli Zaretskii <eliz@gnu.org>
4078
a66cfb1c
SM
4079 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4080 Default value is now t. Doc fix.
6bf7006f 4081
e3cbd34b 4082 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4083 logic when moving up, not only when moving down. Fix the
e3cbd34b 4084 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4085 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4086
4087 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4088 CHARPOS is covered by a display string which includes newlines.
4089 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4090 is covered by a display string with embedded newlines.
4091
a3de0cbd
MA
40922011-09-24 Michael Albinus <michael.albinus@gmx.de>
4093
4094 * dbusbind.c (Fdbus_register_signal): Add match rule to
4095 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4096 (Fdbus_register_method, Vdbus_registered_objects_table):
4097 Fix docstring.
a3de0cbd 4098
b260039d
JM
40992011-09-24 Jim Meyering <meyering@redhat.com>
4100
32c1fffd 4101 do not ignore write error for any output size
b260039d
JM
4102 The previous change was incomplete.
4103 While it makes emacs --batch detect the vast majority of stdout
4104 write failures, errors were still ignored whenever the output size is
4105 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4106 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4107 && echo FAIL: ignored write error
4108 FAIL: ignored write error
4109 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4110 && echo FAIL: ignored write error
4111 FAIL: ignored write error
4112 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4113
8eca8a7c
AS
41142011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4115
4116 * emacs.c (Fkill_emacs): In noninteractive mode exit
4117 non-successfully if a write error occurred on stdout. (Bug#9574)
4118
3341db62
EZ
41192011-09-21 Eli Zaretskii <eliz@gnu.org>
4120
4121 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4122 the xassert test.
4123
4124 * dispextern.h (struct it): Update the comment documenting what
4125 can it->OBJECT be.
4126
8c203dbf
EZ
41272011-09-20 Eli Zaretskii <eliz@gnu.org>
4128
4129 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4130 a display string, extend search for cursor position to end of row.
4131 (find_row_edges): If the row ends in a newline from a display
4132 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4133 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4134 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4135 non-empty line. Fixes confusing cursor motion with arrow keys at
4136 the beginning of a line that starts with whitespace.
8c203dbf 4137
a4824228
LMI
41382011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4139
4140 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4141 (bug#9493).
4142
33ed493b
CY
41432011-09-18 Chong Yidong <cyd@stupidchicken.com>
4144
4145 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4146 boolean (Bug#9154).
4147
56cd55c8
EZ
41482011-09-18 Eli Zaretskii <eliz@gnu.org>
4149
4150 * xdisp.c (display_line): Record maximum and minimum buffer
4151 positions even if no glyphs were produced (e.g., by a zero-width
4152 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4153 buffer positions that will be removed from the glyph row because
4154 they don't fit.
c02dcedf
EZ
4155 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4156 column is beyond frame width: don't subtract 1 "pixel" when
4157 computing width of the stretch.
3e62b7e0
EZ
4158 (reseat_at_next_visible_line_start): Undo the change made on
4159 2011-09-17 that saved paragraph information and restored it after
4160 the call to `reseat'. (Bug#9545)
56cd55c8 4161
5ed99d36 41622011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4163
4164 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4165 and turn window cursor on if cleared (Bug#9415).
4166
5ed99d36 41672011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4168
4169 * search.c (boyer_moore): Take unibyte characters from pattern
4170 literally. (Bug#9458)
4171
9bade7b2
EZ
41722011-09-18 Eli Zaretskii <eliz@gnu.org>
4173
4174 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4175
e5e9d610
PE
41762011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4177
87e4427a
PE
4178 Fix minor problem found by static checking.
4179 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4180 initialized, to pacify gcc -Wuninitialized.
4181
e5e9d610
PE
4182 * fileio.c: Report proper errno when syscall falls.
4183 (Finsert_file_contents): Save and restore errno,
4184 so that report_file_error outputs the correct diagnostic.
4185 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4186
a1674f0b
EZ
41872011-09-18 Eli Zaretskii <eliz@gnu.org>
4188
4189 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4190
fbfb6dd4
EZ
41912011-09-17 Eli Zaretskii <eliz@gnu.org>
4192
4193 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4194 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4195
bb187662
EZ
41962011-09-17 Eli Zaretskii <eliz@gnu.org>
4197
1137e8b8 4198 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4199 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4200
4201 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4202 (bidi_find_paragraph_start): Search back for paragraph beginning
4203 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4204 (bidi_move_to_visually_next): Only trigger paragraph-related
4205 computations when the last character is a newline or at EOB, not
4206 just any NEUTRAL_B. (Bug#9470)
4207
bb187662
EZ
4208 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4209 truncated lines if point is covered by a display string. (Bug#9524)
4210
2e621251
PE
42112011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4212
4213 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4214 (cons_to_x_long): New function.
4215 (lisp_data_to_selection_data): Use it. Correct the test for
4216 short-versus-long data; it was negated. Break out of vector
4217 loop, for efficiency, when a long datum is discovered.
4218
91a15bc6
SM
42192011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4220
4221 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4222
b41c3a35
EZ
42232011-09-16 Eli Zaretskii <eliz@gnu.org>
4224
4225 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4226 GCC PR/17406) by declaring this function with external scope.
4227
7812ba2d
PE
42282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4231 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4232
cf7edc2a
AS
42332011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4234
4235 * editfns.c (Fformat): Correctly handle text properties on "%%".
4236
bd01620e
EZ
42372011-09-15 Eli Zaretskii <eliz@gnu.org>
4238
4239 * xterm.c (x_draw_composite_glyph_string_foreground):
4240 * w32term.c (x_draw_composite_glyph_string_foreground):
4241 * term.c (encode_terminal_code):
4242 * composite.c (composition_update_it, get_composition_id):
4243 * xdisp.c (get_next_display_element)
4244 (fill_composite_glyph_string): Add comments about special meaning
4245 of TAB characters in a composition.
4246
a02719a3
PE
42472011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4248
4249 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4250 This occurs when processing a multibyte format.
4251 Problem reported by Wolfgang Jenker.
a02719a3 4252
72589a3c
JB
42532011-09-15 Johan Bockgård <bojohan@gnu.org>
4254
4255 * xdisp.c (try_cursor_movement): Only check for exact match if
4256 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4257
1c14176c
PE
42582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 Remove unused external symbols.
4261 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4262 * xdisp.c (calc_pixel_width_or_height): Now static.
4263 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4264 * indent.c (check_display_width):
4265 * w32term.c: Fix comment to match code.
4266 * xterm.c, xterm.h (x_catching_errors): Remove.
4267
d2eea5b5
PE
42682011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4269
4270 * xselect.c: Use signed conversions more consistently (Bug#9498).
4271 (selection_data_to_lisp_data): Assume incoming selection data are
4272 signed integers, not unsigned. This is to be consistent with
4273 outgoing selection data, which was modified to use signed integers
4274 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4275 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4276 expects long, not unsigned long.
4277
46888499
EZ
42782011-09-14 Eli Zaretskii <eliz@gnu.org>
4279
4280 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4281 computation of loop end. Reported by Johan Bockgård
4282 <bojohan@gnu.org>.
4283
ef8ef9fb
CY
42842011-09-13 Chong Yidong <cyd@stupidchicken.com>
4285
4286 * frame.c (Fother_visible_frames_p): Function deleted.
4287
fa819fed
EZ
42882011-09-12 Eli Zaretskii <eliz@gnu.org>
4289
4290 * indent.c (compute_motion): Process display vector front to back
4291 rather than the other way around. (Bug#2496)
4292
2ba8e008
SM
42932011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4294
4295 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4296
20f53c69
CY
42972011-09-11 Chong Yidong <cyd@stupidchicken.com>
4298
4299 * minibuf.c (Fread_from_minibuffer): Doc fix.
4300
d562d7a4
EZ
43012011-09-11 Eli Zaretskii <eliz@gnu.org>
4302
4303 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4304 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4305
1c4d7f3d
LMI
43062011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4307
4308 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4309 value for non-existent files.
4310
b885bf36
EZ
43112011-09-11 Eli Zaretskii <eliz@gnu.org>
4312
4313 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4314 set its "size" to -1. This will set the modtime_size field of
4315 the corresponding buffer to -1, which is what
4316 verify-visited-file-modtime expects for files that do not exist.
4317 (Bug#9139)
4318
6612f0bf
PE
43192011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4320
4321 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4322 here ...
4323 * lisp.h: ... from here. push_key_description is no longer
4324 defined in keyboard.c, so its declaration should not be in
4325 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4326 logically belongs with push_key_description.
4327
dfb3f755
PE
43282011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4329
4330 * buffer.h: Include <sys/types.h> instead of <time.h>.
4331 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4332 Problem reported by Herbert J. Skuhra.
4333
3134906c
LMI
43342011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4335
4336 * xml.c (parse_region): Make the parsing work for
4337 non-comment-starting XML files again (bug#9144).
4338
8d903f4e
AS
43392011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4340
4341 * image.c (gif_load): Fix calculation of bottom and right corner.
4342 (Bug#9468)
4343
80ad64f4
EZ
43442011-09-10 Eli Zaretskii <eliz@gnu.org>
4345
4346 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4347 redisplay in small windows.
4348
208a048d
EZ
43492011-09-09 Eli Zaretskii <eliz@gnu.org>
4350
4351 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4352
9b1c252e
MR
43532011-09-08 Martin Rudalics <rudalics@gmx.at>
4354
4355 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4356 Operate on live windows only.
4357
2949f33b
JB
43582011-09-08 Juanma Barranquero <lekktu@gmail.com>
4359
4360 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4361
e08dcafd
EZ
43622011-09-07 Eli Zaretskii <eliz@gnu.org>
4363
4364 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4365 only under bidi iteration.
4366
115b96bd
JD
43672011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4368
4369 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4370
c8199d0f
PE
43712011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4372
4373 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4374 Without this fix, the command to link temacs failed due to an
4375 undefined symbol __builtin_isnan. This is because
4376 /usr/include/iso/math_c99.h #defines isnan(x) to
4377 __builtin_isnan(x), but the bundled gcc, which identifies itself
4378 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4379 a __builtin_isnan.
4380 * floatfns.c (isnan): #undef, and then #define to a clone of
4381 what's in data.c.
4382 (Fisnan): Always define, since it's always available now.
4383 (syms_of_floatfns): Always define isnan at the Lisp level.
4384
e39b275c 43852011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4386
4387 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4388
b2db44d9 43892011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4390
f4af5137 4391 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4392 The previous code assumed that file offsets (off_t values) fit in
4393 EMACS_INT variables, which is not true on typical 32-bit hosts.
4394 The code messed up by falsely reporting buffer overflow in cases
4395 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4396 when "big" contains more than 2**29 bytes, even though this
4397 inserts just one byte and does not overflow the buffer.
4398 (Finsert_file_contents): Store file offsets as off_t
4399 values, not as EMACS_INT values. Check for overflow when
4400 converting between EMACS_INT and off_t. When checking for
4401 buffer overflow or for overlap, take the offsets into account.
4402 Don't use EMACS_INT for small values where int suffices.
4403 When checking for overlap, fix a typo: ZV was used where
4404 ZV_BYTE was intended.
4405 (Fwrite_region): Don't assume off_t fits into 'long'.
4406 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4407
ecfc0a49
MA
44082011-09-05 Michael Albinus <michael.albinus@gmx.de>
4409
4410 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4411
6511acf2 44122011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4413
0999621a 4414 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4415
4416 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4417 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4418 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4419 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4420 (modify_event_symbol): Do not assume that the length of
4421 name_alist_or_stem is safe to alloca and fits in int.
4422 (Fexecute_extended_command): Likewise for function name and binding.
4423 (Frecursion_depth): Wrap around reliably on integer overflow.
4424 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4425 since some callers pass EMACS_INT values.
4426 (Fsingle_key_description): Don't crash if symbol name contains more
4427 than MAX_ALLOCA bytes.
4428 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4429 (get_minibuffer): Arg is now EMACS_INT, not int.
4430 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4431 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4432 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4433
2be7d702
PE
4434 * dbusbind.c (signature_cat): New function.
4435 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4436 Do not overrun buffer; instead, report string overflow.
4437
9d1df220
PE
4438 * dispnew.c (add_window_display_history): Don't overrun buffer.
4439 Truncate instead; this is OK since it's just a log.
4440
33ef5c64
PE
4441 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4442 even if the time zone offset is outlandishly large.
4443 Don't mishandle offset == INT_MIN.
4444
66c6fdd5
PE
4445 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4446 when creating daemon; the previous buffer-overflow check was incorrect.
4447
d749b01b
PE
4448 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4449 which has the guts of the old verror function.
4450
b5cd1905
PE
4451 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4452 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4453
6e1a67fb
PE
4454 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4455 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4456 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4457 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4458 length of string rather than counting it via multiple sprintfs;
4459 that's simpler and more reliable.
c21721cc
PE
4460 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4461 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4462 sprintf, in case result does not fit in int.
4463
c57b67fc
PE
4464 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4465 (fontset_from_font): Print it.
4466
8a401434
PE
4467 * frame.c (tty_frame_count): Now printmax_t, not int.
4468 (make_terminal_frame, set_term_frame_name): Print it.
4469 (x_report_frame_params): In X, window IDs are unsigned long,
4470 not signed long, so print them as unsigned.
4471 (validate_x_resource_name): Check for implausibly long names,
4472 and don't assume name length fits in 'int'.
4473 (x_get_resource_string): Don't blindly alloca invocation name;
4474 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4475 not fit in int.
4476
6e1a67fb
PE
4477 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4478 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4479 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4480
0df02bf3
PE
4481 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4482 Use esprintf, not sprintf, in case result does not fit in int.
4483
48e30793
PE
4484 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4485 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4486 it as a large positive number.
4487 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4488 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4489
a66ff6d8
PE
4490 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4491 in case result does not fit in int.
4492
aca216ff
PE
4493 * print.c (float_to_string): Detect width overflow more reliably.
4494 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4495 buffer overrun. Don't assume list length fits in 'int'. Treat
4496 print length of 0 as 0, not as infinity; to be consistent with other
4497 uses of print length in this function. Don't overflow print length
4498 index. Don't assume hash table size fits in 'long', or that
4499 vectorlike size fits in 'unsigned long'.
4500
31c286f7
PE
4501 * process.c (make_process): Use printmax_t, not int, to format
4502 process-name gensyms.
4503
55e5faa1
PE
4504 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4505
80f2e268
PE
4506 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4507 to avoid potential buffer overrun.
4508
670741ab
PE
4509 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4510 if X resource line is longer than 512 bytes.
4511
b7163a50
PE
4512 * xfns.c (x_window): Make sprintf buffer a bit bigger
4513 to avoid potential buffer overrun.
4514
ae58ff1f
PE
4515 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4516
c43c8a6a
PE
4517 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4518
3f8236f4
PE
45192011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4520
53e9fe90 4521 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4522 Without these, Emacs silently mishandles large integers sometimes.
4523 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4524 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4525
6511acf2
PE
4526 * xdisp.c (try_window_id): Check Emacs fixnum range before
4527 converting to 'int'.
806add1d 4528
6511acf2 4529 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4530 Check that an Emacs fixnum is in range before assigning it to 'int'.
4531 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4532 values converted from Emacs fixnums.
4533 (Frecenter): Don't wrap around a line count if it is out of 'int'
4534 range; instead, treat it as an extreme value.
4535 (Fset_window_configuration, compare_window_configurations):
4536 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4537
6511acf2
PE
4538 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4539 that can exceed INT_MAX. Check that EMACS_INT value is in range
4540 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4541 (match_limit): Don't assume that a fixnum can fit in 'int'.
4542
6511acf2 4543 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4544 exceed INT_MAX.
4545
6511acf2 4546 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4547 (Fvertical_motion): Don't wrap around LINES values that don't fit
4548 in 'int'. Instead, treat them as extreme values. This is good
4549 enough for windows, which can't have more than INT_MAX lines anyway.
4550
fcb901a7
LMI
45512011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4552
0f2f6b6d
LMI
4553 * Require libxml/parser.h to avoid compilation warning.
4554
fcb901a7
LMI
4555 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4556
4557 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4558 since this reportedly can destroy thread storage.
4559
6e20a0d4
CY
45602011-08-30 Chong Yidong <cyd@stupidchicken.com>
4561
4562 * syntax.c (find_defun_start): Update all cache variables if
4563 exiting early (Bug#9401).
4564
148ae00e
EZ
45652011-08-30 Eli Zaretskii <eliz@gnu.org>
4566
f6cfbd8f
EZ
4567 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4568
148ae00e
EZ
4569 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4570 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4571 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4572
4573 * term.c (tty_append_glyph): New function.
4574 (produce_stretch_glyph): Static function and its prototype deleted.
4575
a66cfb1c
SM
4576 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4577 Add prototypes.
148ae00e 4578
c4a07a4c
PE
45792011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4580
4581 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4582 when checking :margin (Bug#9390).
4583 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4584 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4585 so that the name doesn't mislead. All uses changed.
4586
6bc8cd65
JB
45872011-08-28 Johan Bockgård <bojohan@gnu.org>
4588
4589 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4590 set_tty_hooks.
4591
dca4927e
EZ
45922011-08-27 Eli Zaretskii <eliz@gnu.org>
4593
4594 * xdisp.c (move_it_to): Don't bail out early when reaching
4595 position beyond to_charpos, if we are scanning backwards.
4596 (move_it_vertically_backward): When DY == 0, make sure we get to
4597 the first character in the line after the newline.
4598
f2cad773
PE
45992011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4600
4601 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4602 (ccl_driver): Do not generate an out-of-range pointer.
4603 (Fccl_execute_on_string): Remove unnecessary check for
4604 integer overflow, noted by Stefan Monnier in
4605 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4606 Remove a FIXME that didn't need fixing.
4607 Simplify the newly-introduced buffer reallocation code.
4608
0cae2cdb
JB
46092011-08-27 Juanma Barranquero <lekktu@gmail.com>
4610
4611 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4612
5fc295a4 46132011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4614
70c60eb2 4615 Integer and memory overflow issues (Bug#9196).
726e0ab1 4616
d31850da
PE
4617 * doc.c (get_doc_string): Rework so that
4618 get_doc_string_buffer_size is the actual buffer size, rather than
4619 being 1 less than the actual buffer size; this makes xpalloc more
4620 convenient.
4621
a69fbedb
PE
4622 * image.c (x_allocate_bitmap_record, cache_image):
4623 * xselect.c (Fx_register_dnd_atom):
4624 Simplify previous changes by using xpalloc.
4625
fe5c5d37
PE
4626 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4627 since either will do and ptrdiff_t is convenient with xpalloc.
4628
0065d054
PE
4629 * charset.c (charset_table_size)
4630 (struct charset_sort_data.priority): Now ptrdiff_t.
4631 (charset_compare): Don't overflow if priorities differ greatly.
4632 (Fsort_charsets): Don't assume list length fits in int.
4633 Check for size-calculation overflow when allocating sort data.
4634 (syms_of_charset): Allocate an initial charset table that is
4635 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4636
4637 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4638
4639 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4640 The actual value is always <= INT_MAX, and leaving it unsigned made
4641 overflow checking harder.
4642
4643 * dispextern.h (struct glyph_matrix.rows_allocated)
4644 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4645 with xpalloc. The values are still always <= INT_MAX.
4646
4647 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4648
4649 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4650 (SAFE_NALLOCA): New macro.
4651
4652 * region-cache.c (struct boundary.pos, find_cache_boundary)
4653 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4654 (set_cache_region, invalidate_region_cache)
4655 (revalidate_region_cache, know_region_cache, region_cache_forward)
4656 (region_cache_backward, pp_cache):
4657 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4658 so that ptrdiff_t * can be passed to xpalloc.
4659 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4660 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4661 (pp_cache): Don't assume cache_len fits in int.
4662 * region-cache.h: Adjust extern decls to match.
4663
4664 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4665 EMACS_INT, since either will do, for xpalloc.
4666
4667 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4668 (xnmalloc, xnrealloc, xpalloc): New functions.
4669
726e0ab1
PE
4670 * bidi.c (bidi_shelve_header_size): New constant.
4671 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4672 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4673
51f30bc5 4674 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4675 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4676 (overlay_strings):
4677 Don't update size of array until after memory allocation succeeds,
4678 because xmalloc/xrealloc may not return.
0065d054
PE
4679 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4680 now that we have proper integer overflow checking.
4681 (record_overlay_string, overlay_strings): Catch overflows when
4682 calculating size of overlay_str_buf.
726e0ab1 4683
0065d054
PE
4684 * callproc.c (Fcall_process): Check for size overflow when
4685 calculating size of args2.
4686 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4687 Normally we prefer signed values, but sticking with ptrdiff_t would
4688 require adding more-complicated checks.
726e0ab1
PE
4689
4690 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4691 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4692 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4693 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4694
4695 * character.c (Fstring): Check for size-calculation overflow.
4696
4697 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4698 unnecessary integer overflow. Check for size overflow.
4699 (encode_coding_object): Don't update size until xmalloc succeeds.
4700
4701 * composite.c (get_composition_id): Check for overflow in glyph
4702 length calculations.
4703
4704 Integer and memory overflow fixes for display code.
4705 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4706 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4707 (scrolling_window): Check for overflow in size calculations.
4708 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4709 Don't assume glyph table len fits in int.
4710 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4711 (row_table_size): Now ptrdiff_t, not int.
4712 (scrolling_window): Avoid overflow in size calculations.
4713 Don't update size until allocation succeeds.
4714 * fns.c (concat): Check for overflow in size calculations.
4715 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4716 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4717 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4718
4719 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4720 (get_doc_string): Check for size calculation overflow.
4721 Don't update size until allocation succeeds.
4722 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4723 EMACS_INT, where ptrdiff_t will do.
4724 (Fsubstitute_command_keys): Check for string overflow.
4725
4726 * editfns.c (set_time_zone_rule): Don't assume environment length
4727 fits in int.
4728 (message_length): Now ptrdiff_t, not int.
4729 (Fmessage_box): Don't update size until allocation succeeds.
4730 Don't assume message length fits in int.
4731 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4732
0065d054
PE
4733 * emacs.c (main): Do not reallocate argv, since there is a null at
4734 the end that can be overwritten, and this way there's no need to
4735 worry about size-calculation overflow.
4736 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4737
4738 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4739 alloc succeeds.
4740 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4741
4742 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4743 (x_set_scroll_bar_width, x_figure_window_size):
4744 Check for integer overflow.
4745 (x_set_alpha): Do not assume XINT fits in int.
4746
4747 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4748 This is for the members text_lines, text_cols, total_lines, total_cols,
4749 where the system imposes an 'int' limit.
4750
4751 * fringe.c (Fdefine_fringe_bitmap):
4752 Don't update size until alloc works.
4753
4754 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4755 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4756
4757 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4758 Check for size-calculation overflow.
4759 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4760 do, as we prefer signed integers.
4761 (id_to_widget.max_size, id_to_widget.used)
4762 (xg_store_widget_in_map, xg_remove_widget_from_map)
4763 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4764 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4765 Use and return ptrdiff_t, not int.
4766 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4767 * gtkutil.h: Change prototypes to match the above.
4768
4769 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4770 are duplicate now that they've been promoted to lisp.h.
4771 (x_allocate_bitmap_record, x_alloc_image_color)
4772 (make_image_cache, cache_image, xpm_load):
4773 Don't update size until alloc is done.
4774 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4775 (x_detect_edges):
3256efce 4776 Check for size calculation overflow.
726e0ab1
PE
4777 (ct_colors_allocated_max): New constant.
4778 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4779 overflow.
3256efce 4780
726e0ab1
PE
4781 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4782 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4783 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4784 Use ptrdiff_t, not int, to count maps.
4785 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4786 calculations. Don't update size until allocation succeeds.
4787 Redo calculations to avoid overflow.
726e0ab1
PE
4788 * keyboard.h: Change prototypes to match the above.
4789
4790 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4791 to count maps.
4792 (current_minor_maps): Check for size calculation overflow.
4793 * keymap.h: Change prototypes to match the above.
4794
4795 * lread.c (read1, init_obarray): Don't update size until alloc done.
4796
4797 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4798 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4799
726e0ab1
PE
4800 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4801 Now ptrdiff_t, not int.
4802 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4803 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4804
4805 * process.c (Fnetwork_interface_list): Check for overflow
4806 in size calculation.
4807
4808 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4809
4810 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4811 overflow. Don't bother calling xmalloc when xrealloc will do.
4812
4813 * search.c (Freplace_match): Check for size calculation overflow.
4814 (Fset_match_data): Don't assume list lengths fit in 'int'.
4815
4816 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4817 for command line length. Do not attempt to address one before the
4818 beginning of an array, as that's not portable.
4819
4820 * term.c (max_frame_lines): Remove; unused.
4821 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4822 not int.
4823 (encode_terminal_code, calculate_costs): Check for size
4824 calculation overflow.
4825 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4826 table lengths and related sizes. Don't update size until alloc
4827 done. Redo calculations to avoid overflow.
4828 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4829
4830 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4831 subtracting pointers.
4832 (gobble_line): Check for overflow more carefully. Don't update size
4833 until alloc done.
4834
4835 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4836 Don't update size until alloc done.
4837 Redo size calculations to avoid overflow.
4838 Check for size calculation overflow.
0065d054 4839 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4840
4841 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4842 Use ptrdiff_t, not int, for sizes.
4843 (store_mode_line_noprop_char): Don't update size until alloc done.
4844
0065d054
PE
4845 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4846 Use ptrdiff_t, not int, for sizes.
4847 (Finternal_make_lisp_face, cache_face):
4848 Check for size calculation overflow.
4849 (cache_face): Treat size calculation overflows as if they were
4850 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4851
4852 * xfns.c (x_encode_text, x_set_name_internal)
4853 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4854 sizes, since they can exceed INT_MAX in size. Check for size
4855 calculation overflow.
4856
0065d054
PE
4857 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4858 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4859 Don't update size until alloc done.
4860
0065d054 4861 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4862 as sprintf is limited to int lengths.
1d526e2f 4863
252c5ee1
PE
4864 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4865 (X_LONG_MIN): New macros.
864d7ce7
PE
4866 Use them to make the following changes clearer.
4867 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4868 This change doesn't affect the value now, but it may help remind
4869 future maintainers not to raise the value too much later.
4870 (SELECTION_QUANTUM): Remove, replacing with ...
4871 (selection_quantum): ... new function, which avoids overflow.
4872 All uses changed.
4873 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4874 assumption that selection length fits in 'int'.
4875 (x_reply_selection_request, x_handle_selection_request)
4876 (x_get_window_property, receive_incremental_selection)
4877 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4878 (lisp_data_to_selection_data, clean_local_selection_data):
4879 Use ptrdiff_t, not int, to record length of selection.
4880 (x_reply_selection_request, x_get_window_property)
4881 (receive_incremental_selection, x_property_data_to_lisp):
4882 Redo calculations to avoid overflow.
4883 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4884 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4885 something.
4886 (x_get_window_property, receive_incremental_selection)
4887 (lisp_data_to_selection_data, x_property_data_to_lisp):
4888 Check for size-calculation overflow.
4889 (x_get_window_property, receive_incremental_selection)
4890 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4891 Don't store size until memory allocation succeeds.
4892 (x_get_window_property): Plug memory leak on memory exhaustion.
4893 Don't double-block input; malloc is safe here. Don't assume 2**34
4894 - 4 fits in unsigned long. Add an xassert to check
4895 XGetWindowProperty overflow. Be more careful about overflow
4896 calculations, and distinguish size from memory overflow better.
4897 (receive_incremental_selection): When tracing, don't assume
4898 unsigned int is less than INT_MAX.
4899 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4900 harmful) conversions of unsigned short to int.
4901 (lisp_data_to_selection_data): Don't assume that integers
4902 in the range -65535 through -1 fit in an X unsigned short.
4903 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4904 result parameters unless successful. Rely on cons_to_unsigned
4905 to report problems with elements; the old code wasn't right anyway.
4906 (x_check_property_data): Check for int overflow; we cannot use
4907 a wider type due to X limits.
4908 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
4909
726e0ab1 4910 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 4911
0065d054
PE
4912 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
4913 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
4914 (x_color_cells): Don't store size until memory allocation succeeds.
4915 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 4916 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
4917 (x_term_init): Don't assume length fits in int (sprintf is limited
4918 to int size).
bc18e09d 4919
ebfa62c0
PE
4920 Use ptrdiff_t for composition IDs.
4921 * character.c (lisp_string_width):
4922 * composite.c (composition_table_size, n_compositions)
4923 (get_composition_id, composition_gstring_from_id):
4924 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
4925 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
4926 * window.c (Frecenter):
4927 Use ptrdiff_t, not int, for composition IDs.
4928 * composite.c (get_composition_id): Check for integer overflow.
4929 * composite.h: Adjust prototypes to match the above changes.
4930
d3411f89
PE
4931 Use ptrdiff_t for hash table indexes.
4932 * category.c (hash_get_category_set):
4933 * ccl.c (ccl_driver):
4934 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
4935 * coding.c (coding_system_charset_list, detect_coding_system):
4936 * coding.h (struct coding_system.id):
4937 * composite.c (get_composition_id, gstring_lookup_cache):
4938 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
4939 * image.c (xpm_get_color_table_h):
4940 * lisp.h (hash_lookup, hash_put):
4941 * minibuf.c (Ftest_completion):
4942 Use ptrdiff_t for hash table indexes, not int (which is too
4943 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
4944 32-bit --with-wide-int hosts).
4945
e097a6fa
PE
4946 * charset.c (Fdefine_charset_internal): Check for integer overflow.
4947 Add a FIXME comment about memory leaks.
4948 (syms_of_charset): Don't assume xmalloc returns.
4949
5637687f
PE
4950 Don't assume that stated character widths fit in int.
4951 * character.c (Fchar_width, c_string_width, lisp_string_width):
4952 * character.h (CHAR_WIDTH):
4953 * indent.c (MULTIBYTE_BYTES_WIDTH):
4954 Use sanitize_char_width to avoid undefined and/or bad behavior
4955 with outlandish widths.
a66cfb1c 4956 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
4957 now that we have two such functions. All uses changed.
4958 (sanitize_char_width): New inline function.
4959
a2271ba2
PE
4960 Don't assume that tab-width fits in int.
4961 * character.h (sanitize_width): New inline function.
4962 (SANE_TAB_WIDTH): New macro.
4963 (ASCII_CHAR_WIDTH): Use it.
4964 * indent.c (sane_tab_width): Remove. All uses replaced by
4965 SANE_TAB_WIDTH (current_buffer).
4966 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
4967
18c52557
PE
4968 * fileio.c: Integer overflow issues with file modes.
4969 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
4970
caeeedc1
PE
4971 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
4972 Remove unreachable code.
4973 (read_hex, load_charset_map_from_file): Check for integer overflow.
4974
6df6ae42 4975 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
4976 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
4977 (x_send_scroll_bar_event): Likewise. Check that the size does not
4978 exceed limits imposed by XClientMessageEvent, as well as the usual
4979 ptrdiff_t and size_t limits.
4980
b13995db
PE
4981 * keyboard.c: Overflow, signedness and related fixes.
4982 (make_lispy_movement): Use same integer type in forward decl
4983 that is used in the definition.
4984 (read_key_sequence, keyremap_step):
4985 Change bufsize argument back to int, undoing my 2011-03-30 change.
4986 We prefer signed types, and int is wide enough here.
4987 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
4988 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
4989 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
4990 length, not size_t. Use ptrdiff_t for index, not int.
4991 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
4992 possibility of integer overflow.
4993
13464394
PE
4994 Overflow, signedness and related fixes for images.
4995
4996 * dispextern.h (struct it.stack[0].u.image.image_id)
4997 (struct_it.image_id, struct image.id, struct image_cache.size)
4998 (struct image_cache.used, struct image_cache.ref_count):
4999 * gtkutil.c (update_frame_tool_bar):
5000 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5001 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5002 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5003 * nsmenu.m (update_frame_tool_bar):
5004 * xdisp.c (calc_pixel_width_or_height):
5005 * xfns.c (image_cache_refcount):
5006 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5007 on typical 64-bit hosts.
5008
5009 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5010 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5011 Omit unnecessary casts to int.
5012 (parse_image_spec): Check that integers fall into 'int' range
5013 when the callers expect that.
5014 (image_ascent): Redo ascent calculation to avoid int overflow.
5015 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5016 (lookup_image): Remove unnecessary tests.
5017 (xbm_image_p): Locals are now of int, not EMACS_INT,
5018 since parse_image_check makes sure they fit into int.
5019 (png_load, gif_load, svg_load_image):
5020 Prefer int to unsigned where either will do.
5021 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5022 old tiff_error_handler and tiff_warning_handler.
5023 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5024 stack buffer overflows. It uses only the features of vsnprintf
5025 that are common to both POSIX and native Microsoft.
5026 (tiff_error_handler, tiff_warning_handler): Use it.
5027 (tiff_load, gif_load, imagemagick_load_image):
5028 Don't assume :index value fits in 'int'.
5029 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5030 (imagemagick_load_image): Check that crop parameters fit into
5031 the integer types that MagickCropImage accepts. Don't assume
5032 Vimagemagick_render_type has a nonnegative value. Don't assume
5033 size_t fits in 'long'.
5034 (gs_load): Use printmax_t to print the widest integers possible.
5035 Check for integer overflow when computing image height and width.
5036
c11821d4
EZ
50372011-08-26 Eli Zaretskii <eliz@gnu.org>
5038
5039 * xdisp.c (redisplay_window): Don't force window start if point
5040 will be invisible in the resulting window. (Bug#9324)
5041
0c95fcf7
EZ
50422011-08-25 Eli Zaretskii <eliz@gnu.org>
5043
5044 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5045 the display spec is of the form `(space ...)'.
5046 (handle_display_spec): Return the value returned by
5047 handle_single_display_spec, not just 1 or zero.
5048 (handle_single_display_spec): If the display spec is of the form
5049 `(space ...)', and specifies display in the text area, return 2
5050 rather than 1.
fee65a97 5051 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5052 accurately, and prefer exact match for point under bidi.
5053 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5054
5055 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5056 into disp_prop; all users changed.
5057
5058 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5059 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5060 for the text covered by the display property.
5061
e4ed06f1
CY
50622011-08-25 Chong Yidong <cyd@stupidchicken.com>
5063
5064 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5065 Change return value to nil.
5066 (Frecord_buffer): Delete unused function.
5067
f67cdd7f
EZ
50682011-08-24 Eli Zaretskii <eliz@gnu.org>
5069
5980d4c6
EZ
5070 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5071 buffers, return left-to-right.
8610fe8b
EZ
5072 (set_cursor_from_row): Consider candidate row a win if its glyph
5073 represents a newline and point is on that newline. Fixes cursor
5074 positioning on the newline at EOL of R2L text within L2R
5075 paragraph, and vice versa.
5076 (try_cursor_movement): Check continued rows, in addition to
5077 continuation rows. Fixes unwarranted scroll when point enters a
5078 continued line of R2L text within an L2R paragraph, or vice versa.
5079 (cursor_row_p): Consider the case of point being equal to
5080 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5081 from the end of a short line to the beginning of a continued line
5082 of R2L text within L2R paragraph.
5083 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5084 composed characters.
5980d4c6 5085
f67cdd7f
EZ
5086 * bidi.c (bidi_check_type): Use xassert.
5087 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5088 members.
5089
bca633fb
EZ
50902011-08-23 Eli Zaretskii <eliz@gnu.org>
5091
5092 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5093 a character.
5094
4a5885a7
CY
50952011-08-23 Chong Yidong <cyd@stupidchicken.com>
5096
5097 * nsfont.m (ns_otf_to_script): Fix typo.
5098
0902a04e
KH
50992011-08-22 Kenichi Handa <handa@m17n.org>
5100
5101 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5102 extra slot even if the purpose is char-code-property-table.
5103
1a2e6670
EZ
51042011-08-23 Eli Zaretskii <eliz@gnu.org>
5105
8ddde651
EZ
5106 * xdisp.c (redisplay_window): When computing centering_position,
5107 account for the height of the header line. (Bug#8874)
5108
425cc014
EZ
5109 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5110 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5111 candidate is selected by the mouse, and that candidate has a
5112 composed character under the mouse.
5113
1a2e6670
EZ
5114 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5115 coordinates reported by pos-visible-in-window-p for a composed
5116 character in column zero.
5117
8b76d6f8
SM
51182011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5119
5120 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5121
dac347dd
EZ
51222011-08-22 Eli Zaretskii <eliz@gnu.org>
5123
5124 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5125 consider it a hit if to_charpos is anywhere in the range of the
5126 composed buffer positions.
5127
e013fb34
CY
51282011-08-22 Chong Yidong <cyd@stupidchicken.com>
5129
5130 * image.c (gif_load): Don't assume that each subimage has the same
5131 dimensions as the base image. Handle disposal method that is
5132 "undefined" by the gif spec (Bug#9335).
5133
bd1ba3e8
CY
51342011-08-20 Chong Yidong <cyd@stupidchicken.com>
5135
5136 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5137 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5138
54a1215b
EZ
51392011-08-19 Eli Zaretskii <eliz@gnu.org>
5140
823564e5
EZ
5141 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5142 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5143 from an Org mode buffer to a Speedbar frame.
5144
54a1215b
EZ
5145 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5146 a composition, take its buffer position from IT->cmp_it.charpos.
5147 Fixes cursor positioning at the beginning of a line that begins
5148 with a composed character.
5149
9778ebcc
EZ
51502011-08-18 Eli Zaretskii <eliz@gnu.org>
5151
0be6ee06
EZ
5152 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5153 character bidirectional type, use STRONG_L instead. Fixes crashes
5154 in a buffer produced by `describe-categories'.
5155
9778ebcc
EZ
5156 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5157 members before the level stack, so they would be saved and
5158 restored when copying iterator state. Fixes incorrect reordering
5159 around TABs covered by display properties.
5160
156bffbe
AS
51612011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5162
6b02f655 5163 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5164
72ad093b
CY
51652011-08-17 Chong Yidong <cyd@stupidchicken.com>
5166
5167 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5168 (internal_condition_case_2, internal_condition_case_n):
5169 Remove unnecessary aborts (Bug#9081).
72ad093b 5170
35774242
EZ
51712011-08-17 Eli Zaretskii <eliz@gnu.org>
5172
5173 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5174 has no `load' handler, try opening the file locally. (Bug#9311)
5175
db76dd85
KB
51762011-08-16 Ken Brown <kbrown@cornell.edu>
5177
5178 * gmalloc.c: Expand comment.
5179
b215eee5
EZ
51802011-08-16 Eli Zaretskii <eliz@gnu.org>
5181
5182 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5183 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5184
a4579d33
KB
51852011-08-16 Ken Brown <kbrown@cornell.edu>
5186
5187 Fix memory allocation problems in Cygwin build (Bug#9273).
5188
5189 * unexcw.c ( __malloc_initialized): Declare external variable.
5190 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5191
8b76d6f8
SM
5192 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5193 New variables.
a4579d33
KB
5194 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5195 dumped emacs.
5196 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5197 in the static heap.
5198 [CYGWIN] (special_realloc): New function.
5199 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5200 requests to realloc storage in the static heap.
5201
3ebec551
PE
52022011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5203
5204 * bidi.c (bidi_initialize): Remove unused local.
5205
9fd8be00
EZ
52062011-08-15 Eli Zaretskii <eliz@gnu.org>
5207
6b02f655
SM
5208 * bidimirror.h:
5209 * biditype.h: Remove file.
5210 * makefile.w32-in ($(BLD)/bidi.$(O)):
5211 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5212
5213 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5214
5215 * chartab.c: Improve commentary for the uniprop_table API.
5216
32413314
EZ
5217 * bidi.c (bidi_paragraph_init): Support zero value of
5218 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5219 (bidi_initialize): Use uniprop_table instead of including
5220 biditype.h and bidimirror.h.
32413314 5221
9fd8be00
EZ
5222 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5223 coordinates of the iterator when restoring from ppos_it.
5224 (Bug#9296)
5225
5cf2b69b
KH
52262011-08-14 Kenichi Handa <handa@m17n.org>
5227
5228 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5229 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5230
daf17d00
EZ
52312011-08-14 Eli Zaretskii <eliz@gnu.org>
5232
5233 * xdisp.c (move_it_in_display_line_to): Don't invoke
5234 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5235 ppos_it. Fixes vertical cursor motion when line beginning is
5236 covered by an image. (Bug#9296)
5237
08e3161a
JD
52382011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5239
5240 * nsterm.h (ns_run_ascript): Declare.
5241 (NSAPP_DATA2_RUNASSCRIPT): Define.
5242
5243 * nsfns.m (as_script, as_result, as_status): New static variables.
5244 (ns_run_ascript): New function.
5e617bc2 5245 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5246 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5247 the event loop. Get status from as_status (Bug#7276).
5248
5249 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5250 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5251 the event loop (Bug#7276).
5252
a3720aa2
AS
52532011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5254
5255 * gnutls.c (QCgnutls_bootprop_priority)
5256 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5257 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5258 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5259 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5260 (QCgnutls_bootprop_verify_hostname_error)
5261 (QCgnutls_bootprop_callbacks_verify): Rename from
5262 Qgnutls_bootprop_..., all uses changed.
5263
5264 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5265 uses changed.
5266
0a0d27fb
PE
52672011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5268
19d5c50c
PE
5269 * xfaces.c (Qframe_set_background_mode): Now static.
5270 * dispextern.h (Qframe_set_background_mode): Remove decl.
5271
0a0d27fb
PE
5272 * process.c (Fnetwork_interface_info): Declare local only if needed.
5273
377538cb
JD
52742011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5275
5276 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5277 (Fnetwork_interface_list): Allocate in increments of bytes instead
5278 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5279 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5280 sockaddr.
5281 (struct ifflag_def): notrailers is smart on OSX.
5282 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5283 Get hardware address with getifaddrs if available.
5284
08fff70c
EZ
52852011-08-12 Eli Zaretskii <eliz@gnu.org>
5286
5287 * xdisp.c (iterate_out_of_display_property): xassert that
5288 IT->position is set to within IT->object's boundaries. Break from
5289 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5290 when IT->position is set up wrongly due to some bug.
5291 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5292 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5293 entry. Force push_it to save on the stack the current
5294 buffer/string position, to be restored by pop_it. Fix flags in
5295 the iterator structure wrt the object coming from a display
5296 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5297 properties. (Bug#9284)
5298
7be1c708 52992011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5300
7be1c708
CY
5301 * fontset.c (fontset_get_font_group): Add proper type checks.
5302 (Bug#9172)
aac0c6e3 5303
7be1c708 53042011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5305
7be1c708
CY
5306 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5307 and LC_VERSION_MIN_MACOSX.
5308 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5309 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5310
97bb72a6
EZ
53112011-08-08 Eli Zaretskii <eliz@gnu.org>
5312
5313 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5314 no-display-properties-and-no-overlays under bidi display.
5315 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5316 properties and overlays.
97bb72a6 5317
d5617611
CY
53182011-08-08 Chong Yidong <cyd@stupidchicken.com>
5319
37e11a63
CY
5320 * editfns.c (Fset_time_zone_rule): Document relationship with the
5321 setenv function.
5322
d5617611
CY
5323 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5324 the font entity extracted from the cache (Bug#8109).
5325
58872834
CY
53262011-08-07 Chong Yidong <cyd@stupidchicken.com>
5327
5328 * composite.c (autocmp_chars): Don't reset point. That is done by
5329 restore_point_unwind (Bug#5984).
5330
75bfc667
JL
53312011-08-07 Juri Linkov <juri@jurta.org>
5332
5333 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5334 to show the arg `TIME' instead of `TIMEVAL'.
5335
d1410150
EZ
53362011-08-06 Eli Zaretskii <eliz@gnu.org>
5337
5338 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5339 display property strides EOL and includes a newline, as in
5340 longlines-mode. (Bug#9254)
75b771e4
EZ
5341 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5342 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5343
5344 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5345 is non-zero, even if the data buffer is NULL. Fixes a crash in
5346 vertical-motion with longlines-mode. (Bug#9254)
5347
35928349
EZ
53482011-08-05 Eli Zaretskii <eliz@gnu.org>
5349
ec7cc85b
EZ
5350 * bidi.c <bidi_cache_total_alloc>: Now static.
5351 (bidi_initialize): Initialize bidi_cache_total_alloc.
5352
8b76d6f8 5353 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5354 cache. (Bug#9221)
5355
5356 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5357 amount allocated this far in `bidi_cache_total_alloc'.
5358 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5359 non-zero, only free the data buffer without restoring the cache
5360 contents. All callers changed.
5361
5362 * dispextern.h (bidi_unshelve_cache): Update prototype.
5363
5364 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5365 (move_it_in_display_line, move_it_to)
5366 (move_it_vertically_backward, move_it_by_lines): Replace the call
5367 to xfree to an equivalent call to bidi_unshelve_cache.
5368 (move_it_in_display_line_to): Fix logic of returning
412b6358 5369 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5370
e2e2423b
EZ
53712011-08-05 Eli Zaretskii <eliz@gnu.org>
5372
5373 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5374 came from a string character with a `cursor' property. (Bug#9229)
5375
ae9e757a
JD
53762011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5377
5378 * Makefile.in (LIB_PTHREAD): New variable.
5379 (LIBES): Add LIB_PTHREAD (Bug#9216).
5380
5381 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5382 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5383
213bd7f2
AS
53842011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5385
6b02f655 5386 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5387
99aaf75f
JD
53882011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5389
5390 * xterm.c (x_find_topmost_parent): New function.
5391 (x_set_frame_alpha): Find topmost parent window with
5392 x_find_topmost_parent and set the property there also (bug#9181).
5393 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5394
c74e9d86
PE
53952011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5396
5397 * callproc.c (Fcall_process): Avoid vfork clobbering
5398 the local vars buffer, coding_systems, current_dir.
5399
640c8776
SM
54002011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5401
5402 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5403
f26d0e4c
PE
54042011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5405
8a10d76c
PE
5406 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5407 so that it is not optimized away.
5408
f26d0e4c
PE
5409 * xdisp.c (compute_display_string_pos): Remove unused local.
5410
55439c61
EZ
54112011-08-02 Eli Zaretskii <eliz@gnu.org>
5412
5413 Fix slow cursor motion and scrolling in large buffers with
5414 selective display, like Org Mode buffers. (Bug#9218)
5415
5416 * dispextern.h (struct bidi_it): New member disp_prop_p.
5417
5418 * xdisp.c: Remove one-slot cache of display string positions.
5419 (compute_display_string_pos): Accept an additional argument
5e617bc2 5420 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5421 for a display string or property. If found, set DISP_PROP_P
5422 non-zero.
5423
5424 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5425 DISP_PROP_P, and pass it to compute_display_string_pos.
5426 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5427 non-zero. All callers of bidi_fetch_char changed.
5428
fb33fa43
SM
54292011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5430
5431 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5432
b099e063
DM
54332010-12-03 Don March <don@ohspite.net>
5434
5435 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5436 last character M-[char] is translated to ESC [char] (bug#7541).
5437
5cc7f7af
KH
54382011-08-02 Kenichi Handa <handa@m17n.org>
5439
d0fffa3f 5440 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5441
5442 * chartab.c (uniprop_table): Make it non-static.
5443
525d5e6e
EZ
54442011-08-01 Eli Zaretskii <eliz@gnu.org>
5445
5446 * xdisp.c (forward_to_next_line_start): Accept additional argument
5447 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5448 on the newline.
5449 (reseat_at_next_visible_line_start): Use the bidi iterator state
5450 returned by forward_to_next_line_start to restore the state of
5451 it->bidi_it after backing up to previous newline. (Bug#9212)
5452
31011111
AS
54532011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5454
5455 * regex.c (re_comp): Protoize.
5456 (re_exec): Fix return type.
5457 (regexec): Fix type of `ret'. (Bug#9203)
5458
476371c4
PE
54592011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5460
e5d76069
PE
5461 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5462 This is needed if max-image-size is a floating-point number.
5463
9a79b20c
AS
54642011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5465
5466 * print.c (print_object): Print empty symbol as ##.
5467
5468 * lread.c (read1): Read ## as empty symbol.
5469
d8c2fa78
AA
54702011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5471
5472 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5473 setting frame foreground color (Bug#9175).
5474 (x_set_background_color): Likewise.
5475
ffe57a7a
AA
5476 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5477 contents (Bug#9176).
5478 (EmacsTooltip -init): Remove bezels and add shadows to
5479 tooltip windows.
5480
bf3492a5
AA
5481 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5482 or scroll bar (Bug#8470).
5483
d55e9c53
AA
5484 * nsfont.m (nsfont_open): Remove assignment to voffset and
5485 unnecessary vars hshink, expand, hd, full_height, min_height.
5486 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5487
5488 * nsterm.h (nsfont_info): Remove voffset field.
5489
d8c2fa78 54902011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5491
5492 Implement strike-through and overline on NextStep (Bug#8863).
5493
5494 * nsfont.m (nsfont_open): Use underline position provided by font,
5495 instead of hard-coded value of 2.
5496 (nsfont_draw): Call ns_draw_text_decoration instead.
5497
5498 * nsterm.h: Add declaration for ns_draw_text_decoration.
5499
5500 * nsterm.m (ns_draw_text_decoration): New function for drawing
5501 underline, overline, and strike-through.
5502 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5503 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5504 accommodate underlining, etc.
4843aac3 5505
4cc60b9b
EZ
55062011-07-28 Eli Zaretskii <eliz@gnu.org>
5507
bc7ece87
EZ
5508 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5509 default.
4cc60b9b 5510
476371c4
PE
55112011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5512
66606eea
PE
5513 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5514 Without this fix, if a signal arrives just after memory fills up,
5515 'malloc' might be invoked reentrantly.
5516
476371c4
PE
5517 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5518 In other words, assume that every image size is allowed, on non-X
5519 hosts. This assumption is probably wrong, but it lets Emacs compile.
5520
f3fcc40d
AS
55212011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5522
5523 * regex.c (re_iswctype): Convert return values to boolean.
5524
350c992f
EZ
55252011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5526
5527 * xdisp.c (compute_display_string_pos): Don't use cached display
5528 string position if the buffer had its restriction changed.
5529 (Bug#9184)
5530
5266b4bb
PE
55312011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5532
5533 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5534
2573a837 55352011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5536
41f55ccd 5537 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5538
39e378da
PE
5539 * bidi.c: Integer size and overflow fixes.
5540 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5541 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5542 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5543 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5544 (bidi_find_other_level_edge):
5545 Use ptrdiff_t instead of EMACS_INT where either will do.
5546 This works better on 32-bit hosts configured --with-wide-int.
5547 (bidi_cache_ensure_space): Check for size-calculation overflow.
5548 Use % rather than repeated addition, for better worst-case speed.
5549 Don't set bidi_cache_size until after xrealloc returns, because it
5550 might not return.
5551 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5552 (bidi_cache_ensure_space): Also check that the bidi cache size
5553 does not exceed that of the largest Lisp string or buffer. See Eli
5554 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5555
5e927815
PE
5556 * alloc.c (__malloc_size_t): Remove.
5557 All uses replaced by size_t. See Andreas Schwab's note
5558 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5559
ca4aa935
PE
5560 * image.c: Improve checking for integer overflow.
5561 (check_image_size): Assume that f is nonnull, since
5562 it is always nonnull in practice. This is one less thing to
5563 worry about when checking for integer overflow later.
5564 (x_check_image_size): New function, which checks for integer
5565 overflow issues inside X.
5566 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5567 This removes the need for a memory_full check.
5568 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5569 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5570 (xbm_read_bitmap_data): Change locals back to 'int', since
5571 their values must fit in 'int'.
5572 (xpm_load_image, png_load, tiff_load):
5573 Invoke x_create_x_image_and_pixmap earlier,
5574 to avoid much needless work if the image is too large.
5575 (tiff_load): Treat overly large images as if
5576 x_create_x_image_and_pixmap failed, not as malloc failures.
5577 (gs_load): Use x_check_image_size.
5578
5f8f9cc2
PE
5579 * gtkutil.c: Omit integer casts.
5580 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5581 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5582
5adf60bc
PE
5583 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5584
c8907a93
PE
5585 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5586 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5587 would wrongly return t on a 64-bit host.
5588
e3c25c68
PE
5589 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5590 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5591 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5592 and therefore cause GCC to emit a bogus diagnostic in some cases.
5593
3f791afe
PE
5594 * image.c: Integer signedness and overflow and related fixes.
5595 This is not an exhaustive set of fixes, but it's time to
5596 record what I've got.
5597 (lookup_pixel_color, check_image_size): Remove redundant decls.
5598 (check_image_size): Don't assume that arbitrary EMACS_INT values
5599 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5600 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5601 (tiff_load, imagemagick_load_image):
5602 Check for overflow in size calculations.
5603 (x_create_x_image_and_pixmap): Remove unnecessary test for
5604 xmalloc returning NULL; that can't happen.
5605 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5606 (xpm_color_bucket): Use better integer hashing function.
5607 (xpm_cache_color): Don't possibly over-allocate memory.
5608 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5609 (gif_memory_source):
5610 Use ptrdiff_t, not int or size_t, to record sizes.
5611 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5612 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5613 either works, as we prefer signed integers.
5614 (tiff_read_from_memory, tiff_write_from_memory):
5615 Return tsize_t, not size_t, since that's what the TIFF API wants.
5616 (tiff_read_from_memory): Don't fail simply because the read would
5617 go past EOF; instead, return a short read.
5618 (tiff_load): Omit no-longer-needed casts.
5619 (Fimagemagick_types): Don't assume size fits into 'int'.
5620
3cc5a532
PE
5621 Improve hashing quality when configured --with-wide-int.
5622 * fns.c (hash_string): New function, taken from sxhash_string.
5623 Do not discard information about ASCII character case; this
5624 discarding is no longer needed.
5625 (sxhash-string): Use it. Change sig to match it. Caller changed.
5626 * lisp.h: Declare it.
5627 * lread.c (hash_string): Remove, since we now use fns.c's version.
5628 The fns.c version returns a wider integer if --with-wide-int is
5629 specified, so this should help the quality of the hashing a bit.
5630
b312a492
PE
5631 * emacs.c: Integer overflow minor fix.
5632 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5633 Define only if GNU_LINUX.
5634 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5635
dfd153ae
PE
5636 * dispnew.c: Integer signedness and overflow fixes.
5637 Remove unnecessary forward decls, that were a maintenance hassle.
5638 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5639 All uses changed.
5640 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5641 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5642 (prepare_desired_row, line_draw_cost):
5643 Use int, not unsigned, where either works.
5644 (save_current_matrix, restore_current_matrix):
5645 Use ptrdiff_t, not size_t, where either works.
5646 (init_display): Check for overflow more accurately, and without
5647 relying on undefined behavior.
5648
a81d11a3
PE
5649 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5650 Remove, replacing with the new symbols in lisp.h. All uses changed.
5651 * fileio.c (make_temp_name):
5652 * filelock.c (lock_file_1, lock_file):
5653 * xdisp.c (message_dolog):
5654 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5655 Use pMd etc. instead.
5656 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5657 replacing the pWIDE etc. symbols removed from editfns.c.
5658
3300e6fd
PE
5659 * keyboard.h (num_input_events): Now uintmax_t.
5660 This is (very slightly) less likely to mess up due to wraparound.
5661 All uses changed.
5662
fd05c7e9
PE
5663 * buffer.c: Integer signedness fixes.
5664 (alloc_buffer_text, enlarge_buffer_text):
5665 Use ptrdiff_t rather than size_t when either will do, as we prefer
5666 signed integers.
5667
903fe15d
PE
5668 * alloc.c: Integer signedness and overflow fixes.
5669 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5670 (__malloc_size_t): Default to size_t, not to int.
5671 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5672 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5673 Prefer ptrdiff_t to size_t when either would do, as we prefer
5674 signed integers.
5675 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5676 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5677 Now const. Initialize with values that are in range even if char
5678 is signed.
5679 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5680 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5681 These functions do the right thing with sizes > 2**32.
5682 (check_depth): Now ptrdiff_t, not int.
5683 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5684 Adjust to new way of storing sizes. Check for size overflow bugs
5685 in rest of code.
5686 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5687 slightly wrong anyway, as it missed one instance of
5688 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5689 (refill_memory_reserve): Omit needless cast to size_t.
5690 (mark_object_loop_halt): Mark as externally visible.
5691
ac82cc6a
PE
5692 * xselect.c: Integer signedness and overflow fixes.
5693 (Fx_register_dnd_atom, x_handle_dnd_message):
5694 Use ptrdiff_t, not size_t, since we prefer signed.
5695 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5696 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5697 x_dnd_atoms_size and x_dnd_atoms_length.
5698
c2d1e36d
PE
5699 * doprnt.c: Prefer signed to unsigned when either works.
5700 * eval.c (verror):
5701 * doprnt.c (doprnt):
5702 * lisp.h (doprnt):
5703 * xdisp.c (vmessage):
5704 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5705 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5706 prefer signed arithmetic to avoid comparison confusion.
5707 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5708 but is a bit tricky.
5709
0e926e56
PE
5710 Assume freestanding C89 headers, string.h, stdlib.h.
5711 * data.c, doprnt.c, floatfns.c, print.c:
5712 Include float.h unconditionally.
5713 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5714 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5715 * regex.c: Likewise for stddef.h, string.h.
5716 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5717 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5718 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5719 (STDC_HEADERS): Remove obsolete defines.
5720 * sysdep.c: Include limits.h unconditionally.
5721
9cfdb3ec
PE
5722 Assume support for memcmp, memcpy, memmove, memset.
5723 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5724 * regex.c (memcmp, memcpy):
5725 Remove; we assume C89 now.
5726
5727 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5728 (__malloc_safe_bcopy): Remove; no longer needed.
5729
cf950e6b 5730 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5731 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5732 well either way, and we prefer signed to unsigned.
5733
dbf38e02
LMI
57342011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5735
5736 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5737 closes the connection while we're reading (bug#9182).
5738
d6f0886c 57392011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5740
d6f0886c
JD
5741 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5742 are specified (Bug#9168).
24e0f6b1 5743
2eb1f9e6
PE
57442011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5745
5746 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5747 Found by GCC static checking and --with-wide-int on a 32-bit host.
5748
22381272 57492011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5750
5751 * xdisp.c (compute_display_string_pos): Fix logic of caching
5752 previous display string position. Initialize cached_prev_pos to
5753 -1. Fixes slow-down at the beginning of a buffer.
5754
f25e39b4
EZ
57552011-07-24 Eli Zaretskii <eliz@gnu.org>
5756
5757 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5758 for attrs[LFACE_FONTSET_INDEX].
5759
04c4b52e
PE
57602011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5761
5762 * xml.c (parse_region): Remove unused local
5763 that was recently introduced.
5764
c1734fbd
EZ
57652011-07-23 Eli Zaretskii <eliz@gnu.org>
5766
be18c5a5
EZ
5767 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5768 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5769
c1734fbd
EZ
5770 * xdisp.c (move_it_in_display_line_to): Record the best matching
5771 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5772 exit if none of the characters scanned was an exact match.
5773 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5774 when exact match is impossible due to invisible text, and the
5775 lines are truncated.
5776
a258d627
JD
57772011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5778
5779 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5780 for OSX >= 10.7.
5781
b6d5a689
EZ
57822011-07-22 Eli Zaretskii <eliz@gnu.org>
5783
0f74f785
EZ
5784 Fix a significant slow-down of cursor motion with C-n, C-p,
5785 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5786 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5787 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5788 (next_element_from_buffer): Call compute_stop_pos_backwards to
5789 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5790 base_level_stop.
5791 (reseat): Don't look for prev_stop, as that could mean a very long
5792 run.
5793 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5794 <cached_disp_overlay_modiff>: Cache for last found display string
5795 position.
551918c1 5796 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5797 about the same buffer in the same area of character positions, and
5798 the buffer wasn't changed since the time the display string
5799 position was cached.
551918c1 5800
b2d0c91a
EZ
58012011-07-22 Eli Zaretskii <eliz@gnu.org>
5802
5803 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5804 is an integer, which is important for empty lines. (Bug#9149)
5805
043604ee
CY
58062011-07-22 Chong Yidong <cyd@stupidchicken.com>
5807
5808 * frame.c (Fmodify_frame_parameters): In tty case, update the
5809 default face if necessary (Bug#4238).
5810
da4adb04
CY
58112011-07-21 Chong Yidong <cyd@stupidchicken.com>
5812
5813 * editfns.c (Fstring_to_char): No need to explain what a character
5814 is in the docstring (Bug#6576).
5815
9abd0532
LMI
58162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5817
5818 * xml.c (parse_region): Make sure we always return a tree.
5819
36881d16
HK
58202011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5821
5822 * xml.c (parse_region): If a document contains only comments,
5823 return that, too.
5824
1e98674d
LMI
58252011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5826
5827 * xml.c (make_dom): Return comments, too.
5828
590bd467
PE
58292011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5830
5831 Port to OpenBSD.
5832 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5833 and the surrounding thread.
5834 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5835 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5836 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5837 timer goes off.
5838 * s/openbsd.h (BROKEN_SIGIO): Define.
5839 * unexelf.c (unexec) [__OpenBSD__]:
5840 Don't update the .mdebug section of the Alpha COFF symbol table.
5841
f41628b2
LMI
58422011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5843
5844 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5845 (bug#8460).
5846
b59b67c5
PE
58472011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5848
15e3a074
PE
5849 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5850 This fixes some race conditions on the permissions of any newly
5851 created file.
5852
41bed37d
PE
5853 * alloc.c (valid_pointer_p): Use pipe, not open.
5854 This fixes some permissions issues when debugging.
5855
b59b67c5
PE
5856 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5857 If fchown fails to set both uid and gid, try to set just gid,
5858 as that is sometimes allowed. Adjust the file's mode to eliminate
5859 setuid or setgid bits that are inappropriate if fchown fails.
5860
925a6be7
SM
58612011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5862
5863 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5864 to compare Lisp_Objects.
5865 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5866 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5867 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5868
52968808
AS
58692011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5870
0a6a104b
AS
5871 * lread.c (read_integer): Unread even EOF character.
5872 (read1): Likewise. Properly record start position of symbol.
5873
52968808
AS
5874 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5875 symbol character follows.
5876
9e381cdd
PE
58772011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5880 This works around a problem with the previous change to Fcopy_file.
5881 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5882 and without this change, GCC might complain about discarding
5883 fchown's return value.
5884
b5641435
JB
58852011-07-16 Juanma Barranquero <lekktu@gmail.com>
5886
5887 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5888
a8031457
PE
58892011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5890
5891 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5892
dd889327
LMI
58932011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5894
750c33f7
LMI
5895 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5896 it's used from the C level.
5897
dd889327
LMI
5898 * process.c: Use the same condition for POLL_FOR_INPUT in both
5899 keyboard.c and process.c (bug#1858).
5900
87e86684
LM
59012011-07-09 Lawrence Mitchell <wence@gmx.li>
5902
5903 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5904 (Fgnutls_boot): Use it.
5905
64348f40
AS
59062011-07-15 Andreas Schwab <schwab@linux-m68k.org>
5907
5908 * doc.c (Fsubstitute_command_keys): Revert last change.
5909
1d698799
LMI
59102011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
5911
f863868c
LMI
5912 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
5913 quotes the next character, and doesn't affect other longer
5914 sequences (bug#8935).
5915
1d698799
LMI
5916 * lread.c (syms_of_lread): Clarify that is isn't only
5917 `eval-buffer' and `eval-defun' that's affected by
5918 `lexical-binding' (bug#8460).
5919
aa4b6df6
EZ
59202011-07-15 Eli Zaretskii <eliz@gnu.org>
5921
5922 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 5923 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 5924
5d856da6
PE
59252011-07-14 Paul Eggert <eggert@cs.ucla.edu>
5926
ad6042bb
PE
5927 Fix minor problems found by static checking.
5928 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
5929 (elsz): Now a signed constant, not a size_t var. We prefer signed
5930 types to unsigned, to avoid integer comparison confusion. Without
5931 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
5932 "cannot optimize loop, the loop counter may overflow", a symptom
5933 of the confusion.
f00bbb22 5934 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
5935 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
5936
6468f31c
LMI
59372011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
5938
49080b10
LMI
5939 * search.c (Fre_search_backward): Mention `case-fold-search' in
5940 all the re_search_* functions (bug#8138).
5941
6468f31c
LMI
5942 * keyboard.c (Fopen_dribble_file): Document when the file is
5943 closed (bug#8056).
5944
c965adc5
EZ
59452011-07-14 Eli Zaretskii <eliz@gnu.org>
5946
df9733bf
EZ
5947 * bidi.c (bidi_dump_cached_states): Fix format of displaying
5948 bidi_cache_idx.
5949
0bb23927
EZ
5950 Support bidi reordering of display and overlay strings.
5951 * xdisp.c (compute_display_string_pos)
5952 (compute_display_string_end): Accept additional argument STRING.
5953 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
5954 (reseat_to_string): Initialize bidi_it->string.s and
5955 bidi_it->string.schars.
5956 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
5957 NULL (avoids a crash in bidi_paragraph_init).
5958 Initialize itb.string.lstring.
0bb23927
EZ
5959 (init_iterator): Call bidi_init_it only of a valid
5960 buffer position was specified. Initialize paragraph_embedding to
5961 L2R.
5962 (reseat_to_string): Initialize the bidi iterator.
5963 (display_string): If we need to ignore text properties of
5964 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
5965 original value of -1 will not work with bidi.)
5966 (compute_display_string_pos): First arg is now struct
5967 `text_pos *'; all callers changed. Support display properties on
5968 Lisp strings.
5969 (compute_display_string_end): Support display properties on Lisp
5970 strings.
5971 (init_iterator, reseat_1, reseat_to_string): Initialize the
5972 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
5973 when iterating on a string not from display properties).
640c8776
SM
5974 (compute_display_string_pos, compute_display_string_end):
5975 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
5976 arrow keys.
5977 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
5978 base_level_stop; instead, set base_level_stop to BEGV.
5979 Fixes crashes in vertical-motion.
0bb23927
EZ
5980 (next_element_from_buffer): Improve commentary for when
5981 the iterator is before prev_stop.
5982 (init_iterator): Initialize bidi_p from the default value of
5983 bidi-display-reordering, not from buffer-local value. Use the
5984 buffer-local value only if initializing for buffer iteration.
5985 (handle_invisible_prop): Support invisible properties on strings
5986 that are being bidi-reordered.
5987 (set_iterator_to_next): Support bidi reordering of C strings and
5988 Lisp strings.
5989 (next_element_from_string): Support bidi reordering of Lisp
5990 strings.
5991 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
5992 (display_string): Support display of R2L glyph rows.
5993 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
5994 (init_iterator): Don't initialize it->bidi_p for strings
5995 here.
5996 (reseat_to_string): Initialize it->bidi_p for strings here.
5997 (next_element_from_string, next_element_from_c_string)
5998 (next_element_from_buffer): Add xassert's for correspondence
5999 between IT's object being iterated and it->bidi_it.string
6000 structure.
6001 (face_before_or_after_it_pos): Support bidi iteration.
6002 (next_element_from_c_string): Handle the case of the first string
6003 character that is not the first one in the visual order.
6004 (get_visually_first_element): New function, refactored from common
6005 parts of next_element_from_buffer, next_element_from_string, and
6006 next_element_from_c_string.
6007 (tool_bar_lines_needed, redisplay_tool_bar)
6008 (display_menu_bar): Force left-to-right direction. Add a FIXME
6009 comment for making that be controlled by a user option.
6010 (push_it, pop_it): Save and restore the state of the
6011 bidi iterator. Save and restore the bidi_p flag.
6012 (pop_it): Iterate out of display property for string iteration as
6013 well.
6014 (iterate_out_of_display_property): Support iteration over strings.
6015 (handle_single_display_spec): Set up it->bidi_it for iteration
6016 over a display string, and call bidi_init_it.
6017 (handle_single_display_spec, next_overlay_string)
6018 (get_overlay_strings_1, push_display_prop): Set up the bidi
6019 iterator for displaying display or overlay strings.
6020 (forward_to_next_line_start): Don't use the shortcut if
6021 bidi-iterating.
6022 (back_to_previous_visible_line_start): If handle_display_prop
6023 pushed the iterator stack, restore the internal state of the bidi
6024 iterator by calling bidi_pop_it same number of times.
6025 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6026 and we are bidi-iterating, don't decrement the iterator position;
6027 instead, set the first_elt flag in the bidi iterator, to produce
6028 the same effect.
6029 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6030 (push_display_prop): xassert that we are iterating a buffer.
6031 (push_it, pop_it): Save and restore paragraph_embedding member.
6032 (handle_single_display_spec, next_overlay_string)
6033 (get_overlay_strings_1, reseat_1, reseat_to_string)
6034 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6035 correctly. Don't assume unibyte strings are not bidi-reordered.
6036 (compute_display_string_pos)
6037 (compute_display_string_end): Fix handling the case of C string.
6038 (push_it, pop_it): Save and restore from_disp_prop_p.
6039 (handle_single_display_spec, push_display_prop): Set the
6040 from_disp_prop_p flag.
6041 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6042 (pop_it): Call iterate_out_of_display_property only if we are
6043 popping after iteration over a string that came from a display
6044 property. Fix a typo in popping stretch info. Add an assertion
6045 for verifying that the iterator position is in sync with the bidi
6046 iterator.
6047 (handle_single_display_spec, get_overlay_strings_1)
6048 (push_display_prop): Fix initialization of paragraph direction for
6049 string when that of the parent object is not yet determined.
6050 (reseat_1): Call bidi_init_it to resync the bidi
6051 iterator with IT's position. (Bug#7616)
6052 (find_row_edges): If ROW->start.pos gives position
6053 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6054 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6055 Reset the from_disp_prop_p flag.
6056 (SAVE_IT, RESTORE_IT): New macros.
6057 (pos_visible_p, face_before_or_after_it_pos)
6058 (back_to_previous_visible_line_start)
6059 (move_it_in_display_line_to, move_it_in_display_line)
6060 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6061 (try_scrolling, redisplay_window, display_line): Use them when
6062 saving a temporary copy of the iterator and restoring it back.
6063 (back_to_previous_visible_line_start, reseat_1)
6064 (init_iterator): Empty the bidi cache "stack".
6065 (move_it_in_display_line_to): If iterator ended up at
6066 EOL, but we never saw any buffer positions smaller than
6067 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6068 motion in bidi-reordered lines.
6069 (move_it_in_display_line_to): Record prev_method and prev_pos
6070 immediately before the call to set_iterator_to_next. Fixes cursor
6071 motion in bidi-reordered lines with stretch glyphs and strings
6072 displayed in margins. (Bug#8133) (Bug#8867)
6073 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6074 TO_CHARPOS.
640c8776
SM
6075 (pos_visible_p): Support positions in bidi-reordered lines.
6076 Save and restore bidi cache.
0bb23927
EZ
6077
6078 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6079 (bidi_paragraph_info): Delete unused struct.
6080 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6081 (bidi_cache_start): New variable.
6082 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6083 to zero.
6084 (bidi_cache_fetch_state, bidi_cache_search)
6085 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6086 (bidi_cache_find, bidi_peek_at_next_level)
6087 (bidi_level_of_next_char, bidi_find_other_level_edge)
6088 (bidi_move_to_visually_next): Compare cache index with
6089 bidi_cache_start rather than with zero.
6090 (bidi_fetch_char): Accept new argument STRING; all callers
6091 changed. Support iteration over a string. Support strings with
6092 display properties. Support unibyte strings. Fix the type of
6093 `len' according to what STRING_CHAR_AND_LENGTH expects.
6094 (bidi_paragraph_init, bidi_resolve_explicit_1)
6095 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6096 (bidi_level_of_next_char, bidi_move_to_visually_next):
6097 Support iteration over a string.
0bb23927
EZ
6098 (bidi_set_sor_type, bidi_resolve_explicit_1)
6099 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6100 can now be zero (for strings); special values 0 and -1 were
6101 changed to -1 and -2, respectively.
6102 (bidi_char_at_pos): New function.
6103 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6104 Call it instead of FETCH_MULTIBYTE_CHAR.
6105 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6106 initialized to valid values.
6107 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6108 values.
6109 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6110 the test for valid cached positions. Fix the logic for looking up
6111 the sentinel state in the cache. GCPRO the Lisp string we are
6112 iterating.
6113 (bidi_push_it, bidi_pop_it): New functions.
6114 (bidi_initialize): Initialize the bidi cache start stack pointer.
6115 (bidi_cache_ensure_space): New function, refactored from part of
6116 bidi_cache_iterator_state. Don't assume the required size is just
6117 one BIDI_CACHE_CHUNK away.
6118 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6119 (bidi_count_bytes, bidi_char_at_pos): New functions.
6120 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6121 always valid if bidi_cache_idx is valid.
6122 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6123 is valid if it's going to be used.
6124 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6125 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6126 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6127 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6128 (bidi_find_other_level_edge, bidi_cache_start_stack):
6129 All variables related to cache indices are now EMACS_INT.
c965adc5 6130
0bb23927
EZ
6131 * dispextern.h (struct bidi_string_data): New structure.
6132 (struct bidi_it): New member `string'. Make flag members be 1-bit
6133 fields, and put them last in the struct.
640c8776
SM
6134 (compute_display_string_pos, compute_display_string_end):
6135 Update prototypes.
0bb23927
EZ
6136 (bidi_push_it, bidi_pop_it): Add prototypes.
6137 (struct iterator_stack_entry): New members bidi_p,
6138 paragraph_embedding, and from_disp_prop_p.
6139 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6140 (bidi_shelve_cache, bidi_unshelve_cache):
6141 Declare prototypes.
0bb23927
EZ
6142
6143 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6144 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6145 and vector-like objects.
6146
6147 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6148 cache around display iteration.
6149
6150 * window.c (Fwindow_end, window_scroll_pixel_based)
6151 (displayed_window_lines, Frecenter): Save and restore the bidi
6152 cache around display iteration.
6153
3bbd2265
LMI
61542011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6155
6156 * editfns.c (Fdelete_region): Clarify the use of the named
6157 parameters (bug#6788).
6158
adc47434
MR
61592011-07-14 Martin Rudalics <rudalics@gmx.at>
6160
6161 * indent.c (Fvertical_motion): Set and restore w->pointm when
6162 saving and restoring the window's buffer (Bug#9006).
6163
837c31f8
LMI
61642011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6165
6166 * editfns.c (Fstring_to_char): Clarify just what is returned
6167 (bug#6576). Text by Eli Zaretskii.
6168
ac389d0c
JB
61692011-07-13 Juanma Barranquero <lekktu@gmail.com>
6170
6171 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6172
0be0ce47
EZ
61732011-07-13 Eli Zaretskii <eliz@gnu.org>
6174
6175 * buffer.c (mmap_find): Fix a typo.
6176
cd18e7e3
JB
61772011-07-13 Johan Bockgård <bojohan@gnu.org>
6178
6179 Fix execution of x selection hooks.
6180 * xselect.c (Qx_lost_selection_functions)
6181 (Qx_sent_selection_functions): New vars.
6182 (syms_of_xselect): DEFSYM them.
6183 (x_handle_selection_request): Pass Qx_sent_selection_functions
6184 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6185 (x_handle_selection_clear,x_clear_frame_selections):
6186 Pass Qx_lost_selection_functions rather than
6187 Vx_lost_selection_functions to Frun_hook_with_args.
6188
47ea7f44
PE
61892011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6190
ac389d0c 6191 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6192 The old code sometimes used this field without initializing it.
6193
47ea7f44
PE
6194 * alloc.c (gc_sweep): Don't read past end of array.
6195 In theory, the old code could also have corrupted Emacs internals,
6196 though it'd be very unlikely.
6197
bc985c87
AS
61982011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6199
6200 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6201 argument. (Bug#4026)
bc985c87 6202
0cf34688
LMI
62032011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6204
b3dadd76
LMI
6205 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6206 key" (bug#4257).
6207
0cf34688
LMI
6208 * window.c (Fset_window_start): Doc fix (bug#4199).
6209 (Fset_window_hscroll): Ditto.
6210
270768cd
PE
62112011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6212
077e3dda 6213 Fix minor new problems caught by GCC 4.6.1.
270768cd 6214 * term.c (init_tty): Remove unused local.
490011a6 6215 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6216 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6217 not used otherwise.
270768cd 6218
b1f58454
CY
62192011-07-12 Chong Yidong <cyd@stupidchicken.com>
6220
6221 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6222
22b9578d
LMI
62232011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6224
6e70ab07
LMI
6225 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6226 are the mini-buffer and the echo area (bug#3320).
6227
22b9578d
LMI
6228 * term.c (init_tty): Remove support for supdup, c10 and perq
6229 terminals, which are no longer supported (bug#1482).
6230
8974cc9f
JB
62312011-07-10 Johan Bockgård <bojohan@gnu.org>
6232
6233 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6234
a560d974
JD
62352011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6236
6237 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6238 for non-popups (Bug#3642).
6239
1dae0f0a
AS
62402011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6241
268c2c36 6242 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6243 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6244 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6245 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6246 * data.c (fmod): Likewise.
6247 * dispnew.c (swap_glyphs_in_rows): Likewise.
6248 * emacs.c (memory_warning_signal): Likewise.
6249 * floatfns.c (float_error): Likewise.
6250 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6251 (otf_open, font_otf_capability, generate_otf_features)
6252 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6253 Likewise.
6254 * image.c (pbm_read_file): Likewise.
6255 * indent.c (string_display_width): Likewise.
6256 * intervals.c (check_for_interval, search_for_interval)
6257 (inc_interval_count, count_intervals, root_interval)
6258 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6259 * lread.c (defalias): Likewise.
268c2c36 6260 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6261 * regex.c (set_image_of_range_1, set_image_of_range)
6262 (regex_grow_registers): Likewise.
6263 * sysdep.c (strerror): Likewise.
6264 * termcap.c (valid_filename_p, tprint, main): Likewise.
6265 * tparam.c (main): Likewise.
6266 * unexhp9k800.c (run_time_remap, save_data_space)
6267 (update_file_ptrs, read_header, write_header, calculate_checksum)
6268 (copy_file, copy_rest, display_header): Likewise.
6269 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6270 Likewise.
6271 * xdisp.c (check_it): Likewise.
6272 * xfaces.c (register_color, unregister_color, unregister_colors):
6273 Likewise.
6274 * xfns.c (print_fontset_result): Likewise.
6275 * xrdb.c (member, fatal, main): Likewise.
6276
99033785
PE
62772011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6278
6279 Fix minor problems found by static checking (Bug#9031).
6280 * chartab.c (char_table_set_range, map_sub_char_table):
6281 Remove unused locals.
6282 (uniprop_table): Now static.
6283 * composite.c (_work_char): Remove unused static var.
6284
9cb2ac56
JB
62852011-07-09 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6288
f25661f0
JD
62892011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6290
6291 * gtkutil.c (qttip_cb): Remove code without function.
6292
8278c4fe
EZ
62932011-07-09 Eli Zaretskii <eliz@gnu.org>
6294
6295 * w32.c (pthread_sigmask): New stub.
6296
1692ae2d 62972011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6298
8a6ebd58 6299 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6300 sigprocmask is portable only for single-threaded applications, and
6301 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6302 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6303 (LIBES): Use it.
6304 * callproc.c (Fcall_process):
6305 * process.c (create_process):
6306 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6307 Use pthread_sigmask, not sigprocmask.
123403e4 6308
1b854618
JD
63092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6310
6311 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6312 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6313 wrong (Bug#8591).
6314
3fe4b549
JD
63152011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6316
0ce7e563
JD
6317 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6318 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6319 (xg_hide_tooltip): Fix comment.
6320
3fe4b549
JD
6321 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6322 in registerServicesMenuSendTypes.
6323 (validRequestorForSendType): Don't check ns_return_types.
6324
6325 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6326 ns_return_type.
6327
5df75e47
JR
63282011-07-08 Jason Rumney <jasonr@gnu.org>
6329
22610910
JR
6330 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6331 SH_SHOW for hidden windows (Bug#5482).
6332
5df75e47
JR
6333 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6334 frame struct members of non-existent frames (Bug#6284).
6335
699c10bd
JD
63362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6337
4393663b
JD
6338 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6339 variable firstTime not needed on OSX >= 10.6.
6340 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6341 >= 10.5. Use setKnobProportion, setDoubleValue.
6342
6343 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6344 (MAC_OS_X_VERSION_10_5): Define if not defined.
6345 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6346 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6347 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6348
6349 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6350 cString and lossyCString on OSX >= 10.4
6351
58179cce 6352 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6353 sizeToFit on OSX >= 10.2.
6354
6355 * nsimage.m (allocInitFromFile): Don't use deprecated method
6356 bestRepresentationForDevice on OSX >= 10.6.
6357
6358 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6359 to avoid warning.
6360
6361 * emacs.c: Declare unexec_init_emacs_zone.
6362
a63e0781
JD
6363 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6364
699c10bd
JD
6365 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6366
6367 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6368 on svcsMenu (Bug#8842).
6369
6370 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6371 ns_return_types.
6372 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6373
6374 * nsterm.m (QUTF8_STRING): Declare.
6375 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6376 (validRequestorForSendType): Return type is (id).
6377 Change indexOfObjectIdenticalTo to indexOfObject.
6378 Check if we have local selection before returning self (Bug#8842).
6379 (writeSelectionToPasteboard): Put local selection into paste board
6380 if we have a local selection (Bug#8842).
6381 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6382
6383 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6384 (ns_get_local_selection): Declare.
6385
54e10184
LMI
63862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6387
9888ff71
LMI
6388 * keymap.c (describe_map_tree): Don't insert a double newline at
6389 the end of the buffer (bug#1169) and return whether we inserted
6390 something.
6391
54e10184
LMI
6392 * callint.c (Fcall_interactively): Change "reading args" to
6393 "providing args" to try to clarify what it does (bug#1010).
6394
15fa4783
KH
63952011-07-07 Kenichi Handa <handa@m17n.org>
6396
6397 * composite.c (composition_compute_stop_pos): Ignore a static
6398 composition starting before CHARPOS (Bug#8915).
6399
6400 * xdisp.c (handle_composition_prop): Likewise.
6401
a8815b00
EZ
64022011-07-07 Eli Zaretskii <eliz@gnu.org>
6403
6404 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6405 (Bug#9015)
6406
ef7b981d 64072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6408
6409 * character.h (unicode_category_t): New enum type.
6410
6411 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6412 (Qchar_code_property_table): New variable.
6413 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6414 (UNIPROP_COMPRESSED_FORM_P): New macros.
6415 (char_table_ascii): Uncompress the compressed values.
6416 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6417 Uncompress the compressed values.
ac389d0c 6418 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6419 (char_table_ref_and_range): Uncompress the compressed values.
6420 (sub_char_table_set): New arg is_uniprop. Callers changed.
6421 Uncompress the compressed values.
6422 (sub_char_table_set_range): Args changed. Callers changed.
6423 (char_table_set_range): Adjuted for the above change.
6424 (map_sub_char_table): Delete args default_val and parent. Add arg
6425 top. Give decoded values to a Lisp function.
640c8776 6426 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6427 values to a Lisp function. Gcpro more variables.
6428 (uniprop_table_uncompress)
6429 (uniprop_decode_value_run_length): New functions.
6430 (uniprop_decoder, uniprop_decoder_count): New variables.
6431 (uniprop_get_decoder, uniprop_encode_value_character)
6432 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6433 New functions.
6434 (uniprop_encoder, uniprop_encoder_count): New variables.
6435 (uniprop_get_encoder, uniprop_table)
6436 (Funicode_property_table_internal, Fget_unicode_property_internal)
6437 (Fput_unicode_property_internal): New functions.
6438 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6439 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6440 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6441 char-code-property-alist.
6442
640c8776 6443 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6444 Vunicode_category_table.
6445
640c8776 6446 * font.c (font_range): Adjust for the change of
c805dec0
KH
6447 Vunicode_category_table.
6448
76b397fb
DN
64492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6450
6451 * m/iris4d.h: Remove file, move contents ...
6452 * s/irix6-5.h: ... here.
6453
22b4128e
PE
64542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6455
6456 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6457 * alloc.c (mark_buffer):
6458 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6459 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6460 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6461 This isn't true in general, and it's particularly not true
6462 if Emacs is configured with --with-wide-int.
6463 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6464 New macros, used in the buffer.c change.
6465
869795d6
JD
64662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6467
6468 * xsettings.c: Use both GConf and GSettings if both are available.
6469 (store_config_changed_event): Add comment.
6470 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6471 (store_tool_bar_style_changed): New functions.
5e617bc2 6472 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6473 (struct xsettings): Move font inside HAVE_XFT.
6474 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6475 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6476 Move inside HAVE_XFT.
640c8776 6477 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6478 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6479 also.
6480 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6481 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6482 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6483 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6484 (parse_settings): Move check for font inside HAVE_XFT.
6485 (read_settings, apply_xft_settings): Add comment.
6486 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6487 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6488 call store_font_name_changed.
6489 (xft_settings_event): Add comment.
6490 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6491 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6492 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6493 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6494 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6495 (xsettings_get_system_font, xsettings_get_system_normal_font):
6496 Add comment.
869795d6 6497
d8ed26bd
PE
64982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6499
6500 Random fixes. E.g., (random) never returned negative values.
6501 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6502 subseconds part to the entropy, as that's a bit more random.
6503 Prefer signed to unsigned, since the signedness doesn't matter and
6504 in general we prefer signed. When given a limit, use a
6505 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6506 latter isn't right if USE_2_TAGS_FOR_INTS.
6507 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6508 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6509
cabf1cac
SM
65102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6511
6512 * textprop.c (text_property_stickiness):
6513 Obey Vtext_property_default_nonsticky.
6514 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6515 * w32fns.c (syms_of_w32fns):
6516 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6517
6e9b2be9
PE
65182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6519
6520 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6521 This is more efficient than Ffile_directory_p and avoids a minor race.
6522
90186c68
LMI
65232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6524
7c301272
LMI
6525 * buffer.c (Foverlay_put): Say what the return value is
6526 (bug#7835).
6527
c4f2d8d4
LMI
6528 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6529 is a directory before asking whether to use the file name
6530 (bug#7564).
ad637907
LMI
6531 (barf_or_query_if_file_exists): Make the "File is a directory"
6532 error be more correct.
c4f2d8d4 6533
90186c68
LMI
6534 * fns.c (Frequire): Remove the mention of the .gz files, since
6535 that's installation-specific, but keep the mention of
6536 `get-load-suffixes'.
6537
da64016e
PE
65382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6539
6540 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6541 Report string overflow if the output is too long.
6542
7d47b580
JB
65432011-07-04 Juanma Barranquero <lekktu@gmail.com>
6544
a555cb87
JB
6545 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6546 (syms_of_gnutls): Remove duplicate DEFSYM for
6547 Qgnutls_bootprop_verify_hostname_error, an error for
6548 Qgnutls_bootprop_verify_error (which is no longer used).
6549
7d47b580
JB
6550 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6551 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6552 Also (re)move comments that are misplaced or no longer relevant.
6553
1e49bfab
LMI
65542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6555
6556 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6557
1485f4c0
CY
65582011-07-03 Chong Yidong <cyd@stupidchicken.com>
6559
6560 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6561 and background color parameters if they have been changed.
6562
a9ab721e
LMI
65632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6564
6565 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6566
cf7cff57
PE
65672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6568
2e13213d
PE
6569 * xsettings.c (SYSTEM_FONT): Define only when used.
6570 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6571
cf7cff57
PE
6572 * keymap.c (access_keymap_1): Now static.
6573
7a8e04f7
CY
65742011-07-02 Chong Yidong <cyd@stupidchicken.com>
6575
6576 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6577 leave any prefix arg for the up event (Bug#1586).
6578
61352f62
LMI
65792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6580
69bb1ef7
LMI
6581 * lread.c (syms_of_lread): Mention single symbols defined by
6582 `defvar' or `defconst' (bug#7154).
6583
61352f62 6584 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6585 (Frequire): Mention get-load-suffixes.
61352f62 6586
28545e04
MR
65872011-07-02 Martin Rudalics <rudalics@gmx.at>
6588
6589 * window.h (window): Remove clone_number slot.
6590 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6591 Remove.
6592 (make_parent_window, make_window, saved_window)
6593 (Fset_window_configuration, save_window_save): Don't deal with
6594 clone numbers.
6595 * buffer.c (Qclone_number): Remove declaration.
6596 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6597
3349e122
SM
65982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6599
6600 Add multiple inheritance to keymaps.
6601 * keymap.c (Fmake_composed_keymap): New function.
6602 (Fset_keymap_parent): Simplify.
6603 (fix_submap_inheritance): Remove.
6604 (access_keymap_1): New function extracted from access_keymap to handle
6605 embedded parents and handle lists of maps.
6606 (access_keymap): Use it.
6607 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6608 (Fcopy_keymap): Handle embedded parents.
6609 (Fcommand_remapping, define_as_prefix): Simplify.
6610 (Fkey_binding): Simplify.
6611 (syms_of_keymap): Move minibuffer-local-completion-map,
6612 minibuffer-local-filename-completion-map,
6613 minibuffer-local-must-match-map, and
6614 minibuffer-local-filename-must-match-map to Elisp.
6615 (syms_of_keymap): Defsubr make-composed-keymap.
6616 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6617 (parse_menu_item): Trivial simplification.
6618
3279eb87
GM
66192011-07-01 Glenn Morris <rgm@gnu.org>
6620
6621 * Makefile.in (SETTINGS_LIBS): Fix typo.
6622
4550efdf
KI
66232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6624
6625 * coding.c (Fencode_coding_string): Record the last coding system
6626 used, as the function doc string says (bug#8738).
6627
0949d2b6
JD
66282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6629
6630 * xsettings.c (store_monospaced_changed): Take new font as arg and
6631 check for change against current_mono_font.
6632 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6633 (emacs_settings_constructor, emacs_settings_get_property)
6634 (emacs_settings_set_property, emacs_settings_class_init)
6635 (emacs_settings_init, gsettings_obj): Remove.
6636 (something_changedCB): New function for HAVE_GSETTINGS.
6637 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6638 with value as argument.
6639 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6640 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6641 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6642 "changed".
6643
6644 * xgselect.c: Add defined (HAVE_GSETTINGS).
6645 (xgselect_initialize): Ditto.
6646
6647 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6648 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6649 xg_select.
6650
bbc6b304
PE
66512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6652
6653 * eval.c (struct backtrace): Simplify and port the data structure.
6654 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6655 signed bit field, as this assumption is not portable and it makes
6656 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6657 "char debug_on_exit : 1" as this is not portable either; instead,
6658 use the portable "unsigned int debug_on_exit : 1". Remove unused
6659 member evalargs. Remove obsolete comments about cc bombing out.
6660
9851bfc5
JD
66612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6662
51bb811f 6663 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6664 Let HAVE_GSETTINGS override HAVE_GCONF.
6665 (store_monospaced_changed): New function.
6666 (EMACS_SETTINGS): A new type derived from GObject to handle
6667 GSettings notifications.
6668 (emacs_settings_constructor, emacs_settings_get_property)
6669 (emacs_settings_set_property, emacs_settings_class_init):
6670 New functions.
6671 (gsettings_client, gsettings_obj): New variables.
6672 (GSETTINGS_SCHEMA): New define.
6673 (something_changedCB): Call store_monospaced_changed.
6674 (init_gsettings): New function.
6675 (xsettings_initialize): Call init_gsettings.
6676 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6677 to NULL.
6678
640c8776 6679 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6680 GCONF_CFLAGS/LIBS.
6681
5386012d
MR
66822011-06-29 Martin Rudalics <rudalics@gmx.at>
6683
6684 * window.c (resize_root_window, grow_mini_window)
6685 (shrink_mini_window): Rename Qresize_root_window to
6686 Qwindow_resize_root_window and Qresize_root_window_vertically to
6687 Qwindow_resize_root_window_vertically.
6688
f13e0b08
PE
66892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6690
6691 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6692
94515237
JB
66932011-06-27 Juanma Barranquero <lekktu@gmail.com>
6694
6695 * makefile.w32-in: Redesign dependencies so they reflect more
6696 clearly which files are directly included by each source file,
6697 and not through other includes.
6698
e43b6e43
MR
66992011-06-27 Martin Rudalics <rudalics@gmx.at>
6700
6701 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6702 (sort_overlays, overlay_strings): When an overlay's clone number
6703 matches the window's clone number process the overlay even if
6704 the overlay's window property doesn't match the current window.
6705
d68443dc
MR
6706 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6707 (Fwindow_hchild): Rename to Fwindow_left_child.
6708 (Fwindow_next): Rename to Fwindow_next_sibling.
6709 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6710 (resize_window_check): Rename to window_resize_check.
6711 (resize_window_apply): Rename to window_resize_apply.
6712 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6713 (Fdelete_other_windows_internal, resize_frame_windows)
6714 (Fsplit_window_internal, Fdelete_window_internal)
6715 (grow_mini_window, shrink_mini_window)
6716 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6717
c7e73be5
JD
67182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6719
6720 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6721 (emacs_fixed_set_min_size): Remove.
6722 (emacs_fixed_new): Take frame as argument.
6723
6724 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6725 (_EmacsFixedPrivate): Remove minwidth/height.
6726 Add struct frame *f.
6727 (emacs_fixed_init): Initialize priv->f.
6728 (get_parent_class, emacs_fixed_set_min_size): Remove.
6729 (emacs_fixed_new): Set priv->f to argument.
6730 (emacs_fixed_get_preferred_width)
6731 (emacs_fixed_get_preferred_height): Use min_width/height from
6732 frames size_hint to set minimum and natural (Bug#8919).
6733 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6734 and use min_width/height from frames size_hint to set
6735 min_width/height (Bug#8919).
6736
6737 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6738 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6739 Fix indentation.
c7e73be5 6740
cf99dcf8
EZ
67412011-06-26 Eli Zaretskii <eliz@gnu.org>
6742
6743 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6744 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6745 called at ZV.
6746
029529ac
CY
67472011-06-26 Chong Yidong <cyd@stupidchicken.com>
6748
6749 * process.c (wait_reading_process_output): Bypass select if
6750 waiting for a cell while ignoring keyboard input, and input is
6751 pending. Suggested by Jan Djärv (Bug#8869).
6752
7a7ef429
PE
67532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6754
6755 Use gnulib's dup2 module instead of rolling our own.
6756 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6757
11fdef7d 67582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6759
6760 * dispnew.c (scrolling_window): Before scrolling, turn off a
6761 mouse-highlight in the window being scrolled.
6762
cd3520a4
JB
67632011-06-24 Juanma Barranquero <lekktu@gmail.com>
6764
6765 Move DEFSYM to lisp.h and use everywhere.
6766
6767 * character.h (DEFSYM): Move declaration...
6768 * lisp.h (DEFSYM): ...here.
6769
6770 * gnutls.c:
6771 * minibuf.c:
6772 * w32menu.c:
6773 * w32proc.c:
6774 * w32select.c: Don't include character.h.
6775
6776 * alloc.c (syms_of_alloc):
6777 * buffer.c (syms_of_buffer):
6778 * bytecode.c (syms_of_bytecode):
6779 * callint.c (syms_of_callint):
6780 * casefiddle.c (syms_of_casefiddle):
6781 * casetab.c (init_casetab_once):
6782 * category.c (init_category_once, syms_of_category):
6783 * ccl.c (syms_of_ccl):
6784 * cmds.c (syms_of_cmds):
6785 * composite.c (syms_of_composite):
6786 * dbusbind.c (syms_of_dbusbind):
6787 * dired.c (syms_of_dired):
6788 * dispnew.c (syms_of_display):
6789 * doc.c (syms_of_doc):
6790 * editfns.c (syms_of_editfns):
6791 * emacs.c (syms_of_emacs):
6792 * eval.c (syms_of_eval):
6793 * fileio.c (syms_of_fileio):
6794 * fns.c (syms_of_fns):
6795 * frame.c (syms_of_frame):
6796 * fringe.c (syms_of_fringe):
6797 * insdel.c (syms_of_insdel):
6798 * keymap.c (syms_of_keymap):
6799 * lread.c (init_obarray, syms_of_lread):
6800 * macros.c (syms_of_macros):
6801 * msdos.c (syms_of_msdos):
6802 * print.c (syms_of_print):
6803 * process.c (syms_of_process):
6804 * search.c (syms_of_search):
6805 * sound.c (syms_of_sound):
6806 * syntax.c (init_syntax_once, syms_of_syntax):
6807 * terminal.c (syms_of_terminal):
6808 * textprop.c (syms_of_textprop):
6809 * undo.c (syms_of_undo):
6810 * w32.c (globals_of_w32):
6811 * window.c (syms_of_window):
6812 * xdisp.c (syms_of_xdisp):
6813 * xfaces.c (syms_of_xfaces):
6814 * xfns.c (syms_of_xfns):
6815 * xmenu.c (syms_of_xmenu):
6816 * xsettings.c (syms_of_xsettings):
6817 * xterm.c (syms_of_xterm): Use DEFSYM.
6818
4228cf16
TZ
68192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6820
cd3520a4 6821 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6822
7fcccf1e
PE
68232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6824
7efb4e0e
PE
6825 Integer and buffer overflow fixes (Bug#8873).
6826
ff5844ad
PE
6827 * print.c (printchar, strout): Check for string overflow.
6828 (PRINTPREPARE, printchar, strout):
6829 Don't set size unless allocation succeeds.
6830
90532f02
PE
6831 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6832 for sizes. Check for string overflow more accurately.
6833 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6834
6d84508d
PE
6835 * macros.c: Integer and buffer overflow fixes.
6836 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6837 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6838 Use ptrdiff_t, not int, for sizes.
6839 Don't increment bufsize until after realloc succeeds.
6840 Check for size-calculation overflow.
6841 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6842
437b2cb4
PE
6843 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6844
8b9ac8b4
PE
6845 * lread.c: Integer overflow fixes.
6846 (read_integer): Radix is now EMACS_INT, not int,
6847 to improve quality of diagnostics for out-of-range radices.
6848 Calculate buffer size correctly for out-of-range radices.
6849 (read1): Check for integer overflow in radices, and in
6850 read-circle numbers.
82cb60d3
PE
6851 (read_escape): Avoid int overflow.
6852 (Fload, openp, read_buffer_size, read1)
6853 (substitute_object_recurse, read_vector, read_list, map_obarray):
6854 Use ptrdiff_t, not int, for sizes.
6855 (read1): Use EMACS_INT, not int, for sizes.
20270765 6856 Check for size overflow.
8b9ac8b4 6857
7fcccf1e
PE
6858 * image.c (cache_image): Check for size arithmetic overflow.
6859
bfbbd7e7
PE
6860 * lread.c: Integer overflow issues.
6861 (saved_doc_string_size, saved_doc_string_length)
6862 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6863 Now ptrdiff_t, not int.
6864 (read1): Don't assume doc string length fits in int. Check for
6865 out-of-range doc string lengths.
6866 (read_list): Don't assume file position fits in int.
39019e54 6867 (read_escape): Check for hex character overflow.
bfbbd7e7 6868
4e323265
LL
68692011-06-22 Leo Liu <sdl.web@gmail.com>
6870
6871 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6872 Move to minibuffer.el.
6873
85fece3e
PE
68742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6875
20b84ce9 6876 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6877 The following patches are for when GLYPH_DEBUG && !XASSERT.
6878 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6879 * dispnew.c (flush_stdout):
6880 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6881 Mark as externally visible.
6882 * dispnew.c (check_window_matrix_pointers): Now static.
6883 * dispnew.c (window_to_frame_vpos):
6884 * xfns.c (unwind_create_frame):
6885 * xterm.c (x_check_font): Remove unused local.
6886 * scroll.c (CHECK_BOUNDS):
6887 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6888 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6889 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6890 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6891 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6892 Now static.
6893 (debug_method_add): Use va_list and vsprintf rather than relying
6894 on undefined behavior with wrong number of arguments.
6895 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6896 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6897 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6898 since we're not interested in debugging glyphs with old libraries.
6899 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6900 GCC 4.6.0's static checking.
6901
0766b489
PE
69022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6903
31fd4b32
PE
6904 Integer overflow and signedness fixes (Bug#8873).
6905 A few related buffer overrun fixes, too.
6906
b79e8648
PE
6907 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
6908
0766b489
PE
6909 * dispextern.h (struct face.stipple):
6910 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
6911 (x_bitmap_mask, x_allocate_bitmap_record)
6912 (x_create_bitmap_from_data, x_create_bitmap_from_file)
6913 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
6914 (x_create_bitmap_from_xpm_data):
6915 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
6916 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
6917 (.bitmaps_last):
6918 * xfaces.c (load_pixmap):
6919 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
6920 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
6921 (.bitmaps_last, struct x_output.icon_bitmap):
6922 Use ptrdiff_t, not int, for bitmap indexes.
6923 (x_allocate_bitmap_record): Check for size overflow.
6924 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
6925
b081724f
PE
6926 Use ptrdiff_t, not int, for overlay counts.
6927 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
6928 * editfns.c (overlays_around, get_pos_property):
6929 * textprop.c (get_char_property_and_overlay):
6930 * xdisp.c (next_overlay_change, note_mouse_highlight):
6931 * xfaces.c (face_at_buffer_position):
21514da7
PE
6932 * buffer.c (OVERLAY_COUNT_MAX): New macro.
6933 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
6934 (Fnext_overlay_change, Fprevious_overlay_change)
6935 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 6936 Use ptrdiff_t, not int, for sizes.
21514da7 6937 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 6938
3de73e5e
PE
6939 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
6940
2606c57b
PE
6941 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
6942 (x_session_initialize): Do not assume string length fits in int.
6943
aaafe47a
PE
6944 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
6945 This is unlikely, but can occur if DPI is outlandish.
6946
2674ddc8 6947 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
6948 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
6949
28154962
PE
6950 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
6951 * xrdb.c (magic_file_p, search_magic_path):
6952 Omit last arg SUFFIX; it was always 0. All callers changed.
6953 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
6954
7de51af5
PE
6955 * xfont.c (xfont_match): Avoid need for strlen.
6956
25ed6cc3
PE
6957 * xfns.c: Don't assume strlen fits in int.
6958 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
6959
4eab31dd
PE
6960 * xdisp.c (message_log_check_duplicate): Return intmax_t,
6961 not unsigned long, as we prefer signed integers. All callers changed.
6962 Detect integer overflow in repeat count.
6963 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 6964 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 6965
171e2a58
PE
6966 * termcap.c: Don't assume sizes fit in int and never overflow.
6967 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
6968 (gobble_line): Check for size-calculation overflow.
6969
ad39faca 6970 * minibuf.c (Fread_buffer):
6e5bb2dc 6971 * lread.c (intern, intern_c_string):
74ca2eb3
PE
6972 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
6973 Don't assume string length fits in int.
6974
52c61c22 6975 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
6976 * gtkutil.c (style_changed_cb): Avoid need for strlen.
6977
b5b8c9e5
PE
6978 * font.c: Don't assume string length fits in int.
6979 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
6980 Use ptrdiff_t, not int.
ccd6111c
PE
6981 (font_intern_prop): Don't assume string length fits in int.
6982 Don't assume integer property fits in fixnum.
6983 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 6984
882f0d81 6985 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 6986 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
6987 Reformulate so as not to need the command string.
6988 Invoke gzip -cd rather than gunzip, as it's more portable.
6989 (lock_info_type, lock_file_1, lock_file):
6990 Don't assume pid_t and time_t fit in unsigned long.
6991 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
6992 (current_lock_owner): Prefer signed type for sizes.
6993 Use memcpy, not strncpy, where memcpy is what is really wanted.
6994 Don't assume (via atoi) that time_t and pid_t fit in int.
6995 Check for time_t and/or pid_t out of range, e.g., via a network share.
6996 Don't alloca where an auto var works fine.
6997
93f4cf88
PE
6998 * fileio.c: Fix some integer overflow issues.
6999 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7000 Don't assume string length fits in int.
7001 (directory_file_name): Don't assume string length fits in long.
7002 (make_temp_name): Don't assume pid fits in int, or that its print
7003 length is less than 20.
7004
f3e92b69
PE
7005 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7006
1bfdaf10
PE
7007 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7008
35016e9a
PE
7009 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7010
3d1e65a1
PE
7011 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7012 We prefer signed integers, even for size calculations.
7013
0b963a93
PE
7014 * emacs.c: Don't assume string length fits in 'int'.
7015 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7016 (main): Don't invoke strlen when not needed.
7017
573f4b54
PE
7018 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7019 (XD_DEBUG_MESSAGE): Don't waste a byte.
7020
989f33ba
PE
7021 * callproc.c (getenv_internal_1, getenv_internal)
7022 (Fgetenv_internal):
965d34eb
PE
7023 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7024
e4d29b33
PE
7025 * lread.c (invalid_syntax): Omit length argument.
7026 All uses changed. This doesn't fix a bug, but it simplifies the
7027 code away from its former Hollerith-constant appearance, and it's
7028 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7029 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7030
eb49b136
PE
7031 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7032 This didn't break anything, but it didn't help either.
7033 It's confusing to put a bogus integer in a place where the actual
7034 value does not matter.
9f62aeb1 7035 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7036 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7037
15375a22
PE
7038 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7039 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7040 implementation.
b61cc01c
PE
7041 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7042 We prefer signed types, and the value cannot exceed the EMACS_INT
7043 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7044 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7045 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7046 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7047
53b2623d
PE
7048 * indent.c (sane_tab_width): New function.
7049 (current_column, scan_for_column, Findent_to, position_indentation)
7050 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7051 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7052
51cab52b 7053 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7054
f2ed8a70
PE
7055 * lisp.h (lint_assume): New macro.
7056 * composite.c (composition_gstring_put_cache):
7057 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7058
abe80cc6
PE
7059 * editfns.c, insdel.c:
7060 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7061
b02c740e
PE
7062 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7063
ebc96716
PE
7064 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7065
b4e50fa0 7066 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7067 Use much-faster test for byte-length change.
311d5d7c 7068 Don't assume string byte-length fits in 'int'.
a4cf38e4 7069 Check that character arg fits in 'int'.
85461888 7070 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7071
c0c1ee9f
PE
7072 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7073
a498d7f4
PE
7074 * fns.c (concat): Catch string overflow earlier.
7075 Do not rely on integer wraparound.
7076
51cab52b
PE
7077 * dispextern.h (struct it.overlay_strings_charpos)
7078 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7079 * xdisp.c (forward_to_next_line_start)
7080 (back_to_previous_visible_line_start)
7081 (reseat_at_next_visible_line_start, next_element_from_buffer):
7082 Don't arbitrarily truncate the value of 'selective' to int.
7083
76031fad
PE
7084 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7085
5eb55db9
PE
7086 * composite.c: Don't truncate sizes to 'int'.
7087 (composition_gstring_p, composition_reseat_it)
7088 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7089 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7090 not EMACS_UINT, for indexes.
5eb55db9 7091
0703a717
PE
7092 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7093
d6202519
PE
7094 * buffer.c: Include <verify.h>.
7095 (struct sortvec.priority, struct sortstr.priority):
8961a454 7096 Now EMACS_INT, not int.
c20998a7 7097 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7098 (struct sortstr.size, record_overlay_string)
7099 (struct sortstrlist.size, struct sortlist.used):
7100 Don't truncate size to int.
7101 (record_overlay_string): Check for size-calculation overflow.
d6202519 7102 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7103
d5a19415
JM
71042011-06-22 Jim Meyering <meyering@redhat.com>
7105
029529ac 7106 Don't leak an XBM-image-sized buffer
d5a19415
JM
7107 * image.c (xbm_load): Free the image buffer after using it.
7108
a9041e6c
PE
71092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7110
7111 Port to Sun C.
7112 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7113 that Sun C diagnosed.
7114 * fns.c (secure_hash): Fix pointer signedness issue.
7115 * intervals.c (static_offset_intervals): New function.
7116 (offset_intervals): Use it.
7117
7f3f739f
LL
71182011-06-21 Leo Liu <sdl.web@gmail.com>
7119
7120 * deps.mk (fns.o):
7121 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7122 sha512.h.
7123
7124 * fns.c (secure_hash): Rename from crypto_hash_function and change
7125 the first arg to accept symbols.
5b66d427 7126 (Fsecure_hash): New primitive.
7f3f739f
LL
7127 (syms_of_fns): New symbols.
7128
76147d94
DD
71292011-06-20 Deniz Dogan <deniz@dogan.se>
7130
7131 * process.c (Fset_process_buffer): Clarify return value in
7132 docstring.
7133
7d7d0045
CY
71342011-06-18 Chong Yidong <cyd@stupidchicken.com>
7135
7136 * dispnew.c (add_window_display_history): Use BVAR.
7137
7138 * xdisp.c (debug_method_add): Use BVAR.
7139 (check_window_end, dump_glyph_matrix, dump_glyph)
7140 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7141
7142 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7143 Likewise.
7144
7145 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7146 check till after the cache is created in init_frame_faces.
7147
ff2bc410
SM
71482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7149
7150 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7151
28177add
PE
71522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7153
dd3482fe
PE
7154 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7155 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7156 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7157
393d71f3 7158 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7159 * fileio.c (Finsert_file_contents):
7160 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7161 Remove the old (too-loose) buffer overflow checks.
7162 They weren't needed, since make_gap checks for buffer overflow.
7163 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7164 The old code merely checked for Emacs fixnum overflow, and relied
7165 on undefined (wraparound) behavior. The new code avoids undefined
7166 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7167
2e6813b0 7168 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7169 Tune. Don't use wider integers than needed. Don't use alloca.
7170 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7171
599a9e4f
PE
7172 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7173
99561444
PE
7174 * insdel.c, lisp.h (buffer_overflow): New function.
7175 (insert_from_buffer_1, replace_range, replace_range_2):
7176 * insdel.c (make_gap_larger):
7177 * editfns.c (Finsert_char):
7178 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7179
28177add
PE
7180 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7181
e69dafad
PE
71822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7183
4baa020d 7184 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7185
b1c46f02
PE
7186 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7187 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7188
e69dafad
PE
7189 * fileio.c: Don't assume EMACS_INT fits in off_t.
7190 (emacs_lseek): New static function.
7191 (Finsert_file_contents, Fwrite_region): Use it.
7192 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7193
566684ea
PE
7194 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7195
e6966cd6
PE
7196 * fns.c: Don't overflow int when computing a list length.
7197 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7198 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7199 truncation on 64-bit hosts. Check for QUIT every
7200 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7201 faster and is responsive enough.
7202 (Flength): Report an error instead of overflowing an integer.
7203 (Fsafe_length): Return a float if the value is not representable
7204 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7205 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7206 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7207
dd0b0efb
PE
7208 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7209 (header_size, word_size): New constants.
7210 (allocate_vectorlike): Don't check size overflow here.
7211 (allocate_vector): Check it here instead, since this is the only
7212 caller of allocate_vectorlike that could cause overflow.
7213 Check that the new vector's length is representable as a fixnum.
7214
86fe5cfe
PE
7215 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7216 The previous code was bogus. For example, next_almost_prime (32)
7217 returned 39, which is undesirable as it is a multiple of 3; and
7218 next_almost_prime (24) returned 25, which is a multiple of 5 so
7219 why was the code bothering to check for multiples of 7?
7220
80e88859
PE
7221 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7222
4a2f0ad6
PE
7223 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7224
f66c7cf8
PE
7225 Variadic C functions now count arguments with ptrdiff_t.
7226 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7227 Back then I didn't know that the Emacs coding style prefers signed int.
7228 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7229 were being counted with int, which may truncate counts on 64-bit
7230 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7231 * lisp.h (struct Lisp_Subr.function.aMANY)
7232 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7233 Arg counts are now ptrdiff_t, not size_t.
7234 All variadic functions and their callers changed accordingly.
7235 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7236 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7237 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7238 * callint.c (Fcall_interactively): Check arg count for overflow,
7239 to avoid potential buffer overrun. Use signed char, not 'int',
7240 for 'varies' array, so that we needn't bother to check its size
7241 calculation for overflow.
7242 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7243 * eval.c (apply_lambda):
7244 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7245 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7246 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7247
a1759b76
PE
7248 * callint.c (Fcall_interactively): Don't use index var as event count.
7249
d96be9fc
PE
7250 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7251 * mem-limits.h (SIZE): Remove; no longer used.
7252
a690a978 7253 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7254
578c21e6
PE
7255 Remove unnecessary casts.
7256 * xterm.c (x_term_init):
7257 * xfns.c (x_set_border_pixel):
7258 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7259 These aren't needed now that we assume ANSI C.
7260
96f53c6c
PE
7261 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7262 It's more likely to cause problems (due to unsigned overflow)
7263 than to cure them.
7264
83c77d31
PE
7265 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7266
ee2079f1
PE
7267 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7268
6da65536
PE
7269 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7270
7147c4a4
PE
7271 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7272
193e32d9
PE
7273 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7274
e5533da6
PE
7275 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7276
9910e595
PE
7277 GLYPH_CODE_FACE returns EMACS_INT, not int.
7278 * dispextern.h (merge_faces):
7279 * xfaces.c (merge_faces):
01103c44
PE
7280 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7281 Don't assume EMACS_INT fits in int.
9910e595 7282
2638320e
PE
7283 * character.h (CHAR_VALID_P): Remove unused parameter.
7284 * fontset.c, lisp.h, xdisp.c: All uses changed.
7285
045eb8d9
PE
7286 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7287
c1f134b5
PE
7288 * fns.c (concat): Minor tuning based on overflow analysis.
7289 This doesn't fix any bugs. Use int to hold character, instead
7290 of constantly refetching from Emacs object. Use XFASTINT, not
7291 XINT, for value known to be a character. Don't bother comparing
7292 a single byte to 0400, as it's always less.
7293
395fcb93 7294 * floatfns.c (Fexpt):
327eeec8
PE
7295 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7296
abbd3d23
PE
7297 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7298 for characters.
7299
684a03ef
PE
7300 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7301
0fed43f3
PE
7302 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7303 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7304 incorrectly succeed when S was a string, because 4294967386 was
7305 truncated before it was used.
7306
8fd02eb7
PE
7307 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7308 Otherwise, an out-of-range integer could cause undefined behavior
7309 on a 64-bit host.
7310
f8c86b69
PE
7311 * composite.c: Use int, not EMACS_INT, for characters.
7312 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7313 EMACS_INT, for values that are known to be in character range.
7314 This doesn't fix any bugs but is the usual style inside Emacs and
7315 may generate better code on 32-bit machines.
7316
34206dd2
PE
7317 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7318 This is for reasons similar to the recent CHAR_STRING fix.
7319 * charset.c (Fencode_char): Check that character arg is actually
7320 a character. Pass an int to ENCODE_CHAR.
7321 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7322 wider than 'int', as a compile-time check to prevent future regressions
7323 in this area.
7324
c5958d4c 7325 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7326
7327 Make sure a 64-bit char is never passed to CHAR_STRING.
7328 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7329 by silently ignoring the top 32 bits, allowing some values
7330 that were far too large to be valid characters.
7331 * character.h: Include <verify.h>.
7332 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7333 arguments are no wider than unsigned, as a compile-time check
7334 to prevent future regressions in this area.
7335 * data.c (Faset):
01103c44 7336 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7337 (Fsubst_char_in_region):
7338 * fns.c (concat):
7339 * xdisp.c (decode_mode_spec_coding):
7340 Adjust to CHAR_STRING's new requirement.
7341 * editfns.c (Finsert_char, Fsubst_char_in_region):
7342 * fns.c (concat): Check that character args are actually
7343 characters. Without this test, these functions did the wrong
7344 thing with wildly out-of-range values on 64-bit hosts.
7345
d37ca623
PE
7346 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7347 These casts should not be needed on 32-bit hosts, either.
7348 * keyboard.c (read_char):
7349 * lread.c (Fload): Remove casts to unsigned.
7350
ea204efb
PE
7351 * lisp.h (UNSIGNED_CMP): New macro.
7352 This fixes comparison bugs on 64-bit hosts.
7353 (ASCII_CHAR_P): Use it.
7354 * casefiddle.c (casify_object):
01103c44 7355 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7356 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7357 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7358 * dispextern.h (FACE_FROM_ID):
7359 * keyboard.c (read_char): Use UNSIGNED_CMP.
7360
41cb286c
PE
7361 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7362 not to EMACS_INT, to avoid GCC warning.
7363
4a1b9832
PE
7364 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7365
55daad71
PE
7366 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7367 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7368 isn't needed on 32-bit machines.
8f95c75c 7369
01103c44
PE
7370 * buffer.c (Fgenerate_new_buffer_name):
7371 Use EMACS_INT for count, not int.
0ceccced 7372 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7373
7374 * data.c (Qcompiled_function): Now static.
7375
c6f072e7
PE
7376 * window.c (window_body_lines): Now static.
7377
20ce5912
PE
7378 * image.c (gif_load): Rename local to avoid shadowing.
7379
9c4c5f81
PE
7380 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7381 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7382 * alloc.c (make_save_value): Integer argument is now of type
7383 ptrdiff_t, not int.
7384 (mark_object): Use ptrdiff_t, not int.
7385 * lisp.h (pD): New macro.
7386 * print.c (print_object): Use it.
7387
c0c5c8ae
PE
7388 * alloc.c: Use EMACS_INT, not int, to count objects.
7389 (total_conses, total_markers, total_symbols, total_vector_size)
7390 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7391 (total_free_floats, total_floats, total_free_intervals)
7392 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7393 Now EMACS_INT, not int. All uses changed.
7394 (Fgarbage_collect): Compute overall total using a double, so that
7395 integer overflow is less likely to be a problem. Check for overflow
7396 when converting back to an integer.
5a25e253
PE
7397 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7398 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7399 These were 'int' variables that could overflow on 64-bit hosts;
7400 they were never used, so remove them instead of repairing them.
211a0b2a 7401 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7402 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7403 Previously, this ceilinged at INT_MAX, but that doesn't work on
7404 64-bit machines.
e46bb31a 7405 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7406
c78baabf 7407 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7408 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7409 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7410 when a (possibly-narrower) signed value would do just as well.
7411 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7412
c9d624c6
PE
7413 * alloc.c: Catch some string size overflows that we were missing.
7414 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7415 for convenience in STRING_BYTES_MAX.
7416 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7417 The definition here is exact; the one in lisp.h was approximate.
7418 (allocate_string_data): Check for string overflow. This catches
7419 some instances we weren't catching before. Also, it catches
7420 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7421 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7422 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7423
c9d624c6
PE
7424 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7425 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7426 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7427
353032ce
PE
7428 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7429
2bccce07
PE
7430 * alloc.c (Fmake_string): Check for out-of-range init.
7431
0ac30604
SM
74322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7433
7434 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7435
c195f2de
JD
74362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7437
7438 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7439 xg_get_default_scrollbar_width.
7440
7441 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7442 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7443 (style_changed_cb): Call update_theme_scrollbar_width and call
7444 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7445 all frames (Bug#8505).
7446 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7447 Call gtk_window_set_resizable if HAVE_GTK3.
7448 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7449 and height if HAVE_GTK3 (Bug#8505).
7450 (scroll_bar_width_for_theme): New variable.
7451 (update_theme_scrollbar_width): New function.
7452 (xg_get_default_scrollbar_width): Move code to
7453 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7454 (xg_initialize): Call update_theme_scrollbar_width.
7455
7456 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7457
7458 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7459
e10ac9f1
MR
74602011-06-12 Martin Rudalics <rudalics@gmx.at>
7461
7462 * frame.c (make_frame): Call other_buffer_safely instead of
7463 other_buffer.
7464
7465 * window.c (temp_output_buffer_show): Call display_buffer with
7466 second argument Vtemp_buffer_show_specifiers and reset latter
7467 immediately after the call.
7468 (Vtemp_buffer_show_specifiers): New variable.
7469 (auto_window_vscroll_p, next_screen_context_lines)
7470 (Vscroll_preserve_screen_position): Remove leading asterisks from
7471 doc-strings.
7472
2d3c217e 74732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7474
7b7f97e8 7475 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7476 * buffer.c (Qclone_number): Remove for now, as it's unused.
7477 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7478 (record_buffer): Remove unused local.
7479 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7480 (set_frame_buffer_list): Remove; unused.
7481 * frame.h (other_visible_frames): Remove decl.
7482 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7483 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7484 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7485 if HAVE_GPM.
7486 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7487 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7488 Define only if HAVE_GPM.
7489 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7490 (update_hints_inhibit): Remove; never set. All uses removed.
7491 * widgetprv.h (emacsFrameClassRec): Remove decl.
7492 * window.c (delete_deletable_window): Now returns void, since it
7493 wasn't returning anything.
7494 (compare_window_configurations): Remove unused locals.
7495 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7496 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7497 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7498 the same widths as pointers. This follows up on the 2011-05-06 patch.
7499 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7500 * xterm.h: Likewise.
7501 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7502
1384b89e
JB
75032011-06-12 Juanma Barranquero <lekktu@gmail.com>
7504
7505 * makefile.w32-in: Update dependencies.
7506 (LISP_H): Add lib/intprops.h.
7507
1100a63c
CY
75082011-06-11 Chong Yidong <cyd@stupidchicken.com>
7509
7510 * image.c (gif_load): Add animation frame delay to the metadata.
7511 (syms_of_image): Use DEFSYM. New symbol `delay'.
7512
6198ccd0
MR
75132011-06-11 Martin Rudalics <rudalics@gmx.at>
7514
7515 * window.c (delete_deletable_window): Re-add.
7516 (Fset_window_configuration): Rewrite to handle dead buffers and
7517 consequently deletable windows.
7518 (window_tree, Fwindow_tree): Remove. Supply functionality in
7519 window.el.
7520 (compare_window_configurations): Simplify code.
7521
b6e3633c
AS
75222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7523
1ab0dee5
AS
7524 * image.c (imagemagick_load_image): Fix type mismatch.
7525 (Fimagemagick_types): Likewise.
7526
b6e3633c
AS
7527 * window.h (replace_buffer_in_windows): Declare.
7528
9397e56f
MR
75292011-06-11 Martin Rudalics <rudalics@gmx.at>
7530
7531 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7532 Qclone_number. Remove external declaration of Qdelete_window.
7533 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7534 code.
640c8776
SM
7535 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7536 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7537 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7538 buffer list implementation.
7539 (other_buffer_safely): New function.
7540 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7541 calls to replace_buffer_in_windows and
7542 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7543 if allowed.
7544 (record_buffer): Inhibit quitting and rewrite using quittable
7545 functions. Run Qbuffer_list_update_hook if allowed.
7546 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7547 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7548 Move switch-to-buffer to window.el.
9397e56f
MR
7549 (bury-buffer): Move to window.el.
7550 (Vbuffer_list_update_hook): New variable.
7551
7552 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7553 section.
7554
7555 * window.h (resize_frame_windows): Move up in code.
7556 (Fwindow_frame): Remove EXFUN.
7557 (replace_buffer_in_all_windows): Remove prototype.
7558 (replace_buffer_in_windows_safely): Add prototype.
7559
7560 * window.c: Declare Qdelete_window static again. Move down
7561 declaration of select_count.
7562 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7563 (Fother_window): Move to window.el.
7564 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7565 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7566 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7567 window.el.
7568 (replace_buffer_in_windows): Implement by calling
7569 Qreplace_buffer_in_windows.
7570 (replace_buffer_in_all_windows): Remove with some functionality
7571 moved into replace_buffer_in_windows_safely.
7572 (replace_buffer_in_windows_safely): New function.
7573 (select_window_norecord, select_frame_norecord): Move in front
7574 of run_window_configuration_change_hook. Remove now obsolete
7575 declarations.
640c8776
SM
7576 (Fset_window_buffer): Rewrite doc-string.
7577 Call Qrecord_window_buffer.
9397e56f
MR
7578 (keys_of_window): Move binding for other-window to window.el.
7579
b50691aa
CY
75802011-06-11 Chong Yidong <cyd@stupidchicken.com>
7581
7582 * dispextern.h (struct image): Replace data member, whose int_val
7583 and ptr_val fields were not used by anything, with a single
7584 lisp_val object.
7585
7586 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7587 (gif_clear_image, gif_load, imagemagick_load_image)
7588 (gs_clear_image, gs_load): Callers changed.
7589
3f754b86
PE
75902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7591
cca69397
PE
7592 * buffer.h: Include <time.h>, for time_t.
7593 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7594
109e28d0
PE
7595 Fix minor problems found by static checking.
7596
60737f02
PE
7597 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7598
4b66faf3
PE
7599 Make identifiers static if they are not used in other modules.
7600 * data.c (Qcompiled_function, Qframe, Qvector):
7601 * image.c (QimageMagick, Qsvg):
7602 * minibuf.c (Qmetadata):
7603 * window.c (resize_window_check, resize_root_window): Now static.
7604 * window.h (resize_window_check, resize_root_window): Remove decls.
7605
109e28d0
PE
7606 * window.c (window_deletion_count, delete_deletable_window):
7607 Remove; unused.
46a4ce9e
PE
7608 (window_body_lines): Now static.
7609 (Fdelete_other_windows_internal): Mark vars as initialized.
7610 Make sure 'resize_failed' is initialized.
7611 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7612 (resize_window_apply): Remove unused local.
7613 * window.h (delete_deletable_window): Remove decl.
7614
109e28d0 7615 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7616 (imagemagick_load_image): Fix pointer signedness problem by changing
7617 last arg from unsigned char * to char *. All uses changed.
7618 Also, fix a local for similar reasons.
7619 Remove unused locals. Remove locals to avoid shadowing.
7620 (fn_rsvg_handle_free): Remove; unused.
7621 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7622 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7623
3f754b86
PE
7624 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7625
2547adb1
CY
76262011-06-10 Chong Yidong <cyd@stupidchicken.com>
7627
7628 * image.c (gif_load): Fix omitted cast error introduced by
7629 2011-06-06 change.
7630
2c8e37d4
MR
76312011-06-10 Martin Rudalics <rudalics@gmx.at>
7632
7633 * window.h (resize_proportionally, orig_total_lines)
7634 (orig_top_line): Remove from window structure.
7635 (set_window_height, set_window_width, change_window_heights)
7636 (Fdelete_window): Remove prototypes.
7637 (resize_frame_windows): Remove duplicate declaration.
7638
440a42e3
EZ
76392011-06-10 Eli Zaretskii <eliz@gnu.org>
7640
7641 * window.h (resize_frame_windows, resize_window_check)
7642 (delete_deletable_window, resize_root_window)
7643 (resize_frame_windows): Declare prototypes.
7644
7645 * window.c (resize_window_apply): Make definition be "static" to
7646 match the prototype.
7647
562dd5e9
MR
76482011-06-10 Martin Rudalics <rudalics@gmx.at>
7649
7650 * window.c: Remove declarations of Qwindow_size_fixed,
7651 window_min_size_1, window_min_size_2, window_min_size,
7652 size_window, window_fixed_size_p, enlarge_window, delete_window.
7653 Remove static from declaration of Qdelete_window, it's
7654 temporarily needed by Fbury_buffer.
7655 (replace_window): Don't assign orig_top_line and
7656 orig_total_lines.
7657 (Fdelete_window, delete_window): Remove. Window deletion is
7658 handled by window.el.
640c8776
SM
7659 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7660 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7661 (Fdelete_other_windows): Remove. Deleting other windows is
7662 handled by window.el.
7663 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7664 handled in window.el.
7665 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7666 Window minimum sizes are handled in window.el.
7667 (shrink_windows, size_window, set_window_height)
7668 (set_window_width, change_window_heights, window_height)
7669 (window_width, CURBEG, CURSIZE, enlarge_window)
7670 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7671 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7672 handled in window.el.
7673 (make_dummy_parent): Rename to make_parent_window and give it a
7674 second argument horflag.
7675 (make_window): Don't set resize_proportionally any more.
7676 (Fsplit_window): Remove. Windows are split in window.el.
7677 (save_restore_action, save_restore_orig_size)
7678 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7679 Resize mini windows in window.el.
7680 (grow_mini_window, shrink_mini_window): Implement by calling
7681 Qresize_root_window_vertically, resize_window_check and
7682 resize_window_apply.
640c8776
SM
7683 (saved_window, Fset_window_configuration, save_window_save):
7684 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7685 resize_proportionally.
7686 (window_min_height, window_min_width): Move to window.el.
7687 (keys_of_window): Move bindings for delete-other-windows,
7688 split-window, delete-window and enlarge-window to window.el.
7689
7690 * buffer.c: Temporarily extern Qdelete_window.
7691 (Fbury_buffer): Temporarily call Qdelete_window instead of
7692 Fdelete_window (Fbury_buffer will move to window.el soon).
7693
7694 * frame.c (set_menu_bar_lines_1): Remove code handling
7695 orig_top_line and orig_total_lines.
7696
7697 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7698 set_window_height but set heights directly.
7699 (change_frame_size_1): Use resize_frame_windows.
7700
7701 * xdisp.c (init_xdisp): Don't use set_window_height but set
7702 heights directly.
7703
640c8776
SM
7704 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7705 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7706 run_window_configuration_change_hook.
7707
7708 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7709 instead of change_window_heights and run
7710 run_window_configuration_change_hook.
7711
1a13852e
MR
77122011-06-09 Martin Rudalics <rudalics@gmx.at>
7713
7714 * window.c (replace_window): Rename second argument REPLACEMENT to
7715 NEW. New third argument SETFLAG. Rewrite.
7716 (delete_window, make_dummy_parent): Call replace_window with
7717 third argument 1.
7718 (window_list_1): Move down in code.
7719 (run_window_configuration_change_hook): Move set_buffer part
7720 before select_frame_norecord part in order to unwind correctly.
7721 Rename count1 to count.
7722 (recombine_windows, delete_deletable_window, resize_root_window)
7723 (Fdelete_other_windows_internal)
7724 (Frun_window_configuration_change_hook, make_parent_window)
7725 (resize_window_check, resize_window_apply, Fresize_window_apply)
7726 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7727 (Fdelete_window_internal, Fresize_mini_window_internal):
7728 New functions.
1a13852e
MR
7729 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7730
f3d1777e
MR
77312011-06-08 Martin Rudalics <rudalics@gmx.at>
7732
496e208e
MR
7733 * window.h (window): Add some new members to window structure -
7734 normal_lines, normal_cols, new_total, new_normal, clone_number,
7735 splits, nest, prev_buffers, next_buffers.
7736 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7737 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7738
f3d1777e
MR
7739 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7740 Remove.
496e208e
MR
7741 (make_dummy_parent): Set new members of windows structure.
7742 (make_window): Move down in code. Handle new members of window
7743 structure.
7744 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7745 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7746 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7747 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7748 (Fset_window_next_buffers, Fset_window_clone_number):
7749 New functions.
496e208e
MR
7750 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7751 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7752 Doc-string fixes.
7753 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7754 Argument WINDOW can be now internal window too.
7755 (Fwindow_use_time): Move up in code.
7756 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7757 Rewrite doc-string.
7758 (Fset_window_configuration, saved_window)
7759 (Fcurrent_window_configuration, save_window_save): Handle new
7760 members of window structure.
b9e809c2
MR
7761 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7762 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7763 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7764 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7765 Qget_mru_window, Qresize_root_window,
7766 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7767 Qauto_buffer_name; staticpro them.
f3d1777e 7768
abde8f8c
MR
77692011-06-07 Martin Rudalics <rudalics@gmx.at>
7770
7771 * window.c (Fwindow_total_size, Fwindow_left_column)
7772 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7773 (Fwindow_list_1): New functions.
7774 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7775 (Fwindow_width, Fscroll_left, Fscroll_right):
7776 Use window_body_cols instead of window_box_text_cols.
7777 (delete_window, Fset_window_configuration):
7778 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7779 (delete_all_subwindows): Take a window as argument and not a
7780 structure. Rewrite.
190b47e6
MR
7781 (window_loop): Remove handling of GET_LRU_WINDOW and
7782 GET_LARGEST_WINDOW.
7783 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7784
7785 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7786 window_box_text_cols. delete_all_subwindows now takes a
7787 Lisp_Object as argument.
abde8f8c 7788
640c8776
SM
7789 * indent.c (compute_motion, Fcompute_motion):
7790 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7791
fa8a67e6
MR
7792 * frame.c (delete_frame): Call delete_all_subwindows with root
7793 window as argument.
7794
a54e3482
DC
77952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7796
7797 * fns.c (Fputhash): Document return value.
7798
60002bf5
CY
77992011-06-06 Chong Yidong <cyd@stupidchicken.com>
7800
7801 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7802
0c671da6 78032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7804
b862a52a 7805 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7806
be44ca6c
PE
7807 Check for overflow when converting integer to cons and back.
7808 * charset.c (Fdefine_charset_internal, Fdecode_char):
7809 Use cons_to_unsigned to catch overflow.
7810 (Fencode_char): Use INTEGER_TO_CONS.
7811 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7812 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7813 * data.c (long_to_cons, cons_to_long): Remove.
7814 (cons_to_unsigned, cons_to_signed): New functions.
7815 These signal an error for invalid or out-of-range values.
7816 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7817 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7818 * font.c (Ffont_variation_glyphs):
7819 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7820 * lisp.h: Include <intprops.h>.
7821 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7822 (cons_to_signed, cons_to_unsigned): New decls.
7823 (long_to_cons, cons_to_long): Remove decls.
7824 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7825 (Fprimitive_undo): Use CONS_TO_INTEGER.
7826 * xfns.c (Fx_window_property): Likewise.
7827 * xselect.c: Include <limits.h>.
7828 (x_own_selection, selection_data_to_lisp_data):
7829 Use INTEGER_TO_CONS.
7830 (x_handle_selection_request, x_handle_selection_clear)
7831 (x_get_foreign_selection, Fx_disown_selection_internal)
7832 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7833 (lisp_data_to_selection_data): Use cons_to_unsigned.
7834 (x_fill_property_data): Use cons_to_signed.
7835 Report values out of range.
7836
d1f3d2af
PE
7837 Check for buffer and string overflow more precisely.
7838 * buffer.h (BUF_BYTES_MAX): New macro.
7839 * lisp.h (STRING_BYTES_MAX): New macro.
7840 * alloc.c (Fmake_string):
7841 * character.c (string_escape_byte8):
7842 * coding.c (coding_alloc_by_realloc):
7843 * doprnt.c (doprnt):
7844 * editfns.c (Fformat):
7845 * eval.c (verror):
7846 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7847 since they may not be the same number.
7848 * editfns.c (Finsert_char):
7849 * fileio.c (Finsert_file_contents):
7850 Likewise for BUF_BYTES_MAX.
7851
dd52fcea
PE
7852 * image.c: Use ptrdiff_t, not int, for sizes.
7853 (slurp_file): Switch from int to ptrdiff_t.
7854 All uses changed.
7855 (slurp_file): Check that file size fits in both size_t (for
7856 malloc) and ptrdiff_t (for sanity and safety).
7857
7f9bbdbb
PE
7858 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7859 if b->modtime has its maximal value.
7860
dfe18f82
PE
7861 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7862
84acfcf0
PE
7863 Don't assume time_t can fit into int.
7864 * buffer.h (struct buffer.modtime): Now time_t, not int.
7865 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7866 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7867
ccd9a01a
PE
7868 Minor fixes for signed vs unsigned integers.
7869 * character.h (MAYBE_UNIFY_CHAR):
7870 * charset.c (maybe_unify_char):
7871 * keyboard.c (read_char, reorder_modifiers):
7872 XINT -> XFASTINT, since the integer must be nonnegative.
7873 * ftfont.c (ftfont_spec_pattern):
7874 * keymap.c (access_keymap, silly_event_symbol_error):
7875 XUINT -> XFASTINT, since the integer must be nonnegative.
7876 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7877 since it makes no difference and we prefer signed.
7878 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7879 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7880 nonnegative.
7881
d6d100dd
SM
78822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7883
7884 * window.h (Fwindow_frame): Declare.
7885
2b6148e4
PE
78862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7887
7888 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7889 (SPARE_MEMORY): Always define.
7890 (LARGE_REQUEST): Remove.
7891 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7892
f230ecc9
MR
78932011-06-06 Martin Rudalics <rudalics@gmx.at>
7894
727e958e
MR
7895 * lisp.h: Move EXFUNS for Fframe_root_window,
7896 Fframe_first_window and Fset_frame_selected_window to window.h.
7897
7898 * window.h: Move EXFUNS for Fframe_root_window,
7899 Fframe_first_window and Fset_frame_selected_window here from
7900 lisp.h.
7901
7902 * frame.c (Fwindow_frame, Fframe_first_window)
7903 (Fframe_root_window, Fframe_selected_window)
7904 (Fset_frame_selected_window): Move to window.c.
7905 (Factive_minibuffer_window): Move to minibuf.c.
7906 (Fother_visible_frames_p): New function.
7907
7908 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
7909
f230ecc9
MR
7910 * window.c (decode_window, decode_any_window): Move up in code.
7911 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
7912 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
7913 (Fwindow_buffer): Move up and rewrite doc-string.
7914 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
7915 (Fwindow_prev): New functions.
727e958e
MR
7916 (Fwindow_frame): Move here from frame.c. Accept any window as
7917 argument.
7918 (Fframe_root_window, Fframe_first_window)
7919 (Fframe_selected_window): Move here from frame.c. Accept frame
7920 or arbitrary window as argument. Update doc-strings.
7921 (Fminibuffer_window): Move up in code.
7922 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
7923 (Fset_frame_selected_window): Move here from frame.c.
7924 Marginal rewrite.
727e958e
MR
7925 (Fselected_window, select_window, Fselect_window): Move up in
7926 code. Minor doc-string fixes.
f230ecc9 7927
4d09bcf6
PE
79282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7929
7930 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
7931 Do not assume that spare memory exists; that assumption is valid
7932 only if SYSTEM_MALLOC.
7933 (LARGE_REQUEST): New macro, so that the issue of large requests
7934 is separated from the issue of spare memory.
7935
810928a2
AS
79362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
7937
172418ad
AS
7938 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
7939 format. (Bug#8806)
7940
43f862f7
AS
7941 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
7942
810928a2
AS
7943 * xfns.c (x_set_scroll_bar_default_width): Move declarations
7944 before statements.
7945
a059fe24
JD
79462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
7947
7948 * gtkutil.c (xg_get_default_scrollbar_width): New function.
7949
7950 * gtkutil.h: Declare xg_get_default_scrollbar_width.
7951
7952 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
7953 min width by calling x_set_scroll_bar_default_width (Bug#8505).
7954
989bf368
JB
79552011-06-05 Juanma Barranquero <lekktu@gmail.com>
7956
7957 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
7958
4b80f674
CY
79592011-06-04 Chong Yidong <cyd@stupidchicken.com>
7960
7961 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
7962 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
7963 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
7964 New error handlers.
4b80f674
CY
7965 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
7966 Obey Vx_select_enable_clipboard_manager. Catch errors in
7967 x_clipboard_manager_save (Bug#8779).
7968 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 7969 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 7970
99a33b77 79712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
7972
7973 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
7974
99a33b77 79752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
7976
7977 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
7978 in the current matrix if keep_current_p is non-zero.
7979
8264569d
EZ
79802011-06-04 Eli Zaretskii <eliz@gnu.org>
7981
7982 * bidi.c (bidi_level_of_next_char): Fix last change.
7983
57f97249
EZ
79842011-06-03 Eli Zaretskii <eliz@gnu.org>
7985
fec2107c 7986 Support bidi reordering of text covered by display properties.
57f97249 7987
fec2107c
EZ
7988 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
7989 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
7990 (bidi_cache_search, bidi_cache_iterator_state)
7991 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
7992 (bidi_level_of_next_char, bidi_move_to_visually_next):
7993 Support character positions inside a run of characters covered by a
fec2107c
EZ
7994 display string.
7995 (bidi_paragraph_init, bidi_resolve_explicit_1)
7996 (bidi_level_of_next_char): Call bidi_fetch_char and
7997 bidi_fetch_char_advance instead of FETCH_CHAR and
7998 FETCH_CHAR_ADVANCE.
7999 (bidi_init_it): Initialize new members.
8000 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8001 definitions.
8002 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8003 instead of using explicit *_CHAR codes.
d6d100dd
SM
8004 (bidi_resolve_explicit, bidi_resolve_weak):
8005 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8006 bidirectional text is supported only in multibyte buffers.
8007 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8008 it to initialize the frame_window_p member of struct bidi_it.
8009 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8010 (bidi_resolve_explicit, bidi_resolve_weak)
8011 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8012 bidi_it->nchars is non-positive.
8013 (bidi_level_of_next_char): Don't try to lookup the cache for the
8014 next/previous character if nothing is cached there yet, or if we
8015 were just reseat()'ed to a new position.
c40e2fb2 8016
0e14fe90
EZ
8017 * xdisp.c (set_cursor_from_row): Set start and stop points
8018 according to the row's direction when priming the loop that looks
8019 for the glyph on which to display cursor.
8020 (single_display_spec_intangible_p): Function deleted.
8021 (display_prop_intangible_p): Reimplement to call
8022 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8023 Accept 3 additional arguments needed by handle_display_spec.
8024 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8025 values: lists, `(when COND...)' forms, etc.
8026 (single_display_spec_string_p): Support property values that are
8027 lists with the argument STRING its top-level element.
8028 (display_prop_string_p): Fix the condition for processing a
8029 property that is a list to be consistent with handle_display_spec.
fec2107c 8030 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8031 last portion of handle_display_prop.
8032 (compute_display_string_pos): Accept additional argument
8033 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8034 value of a `display' property is a "replacing spec".
8035 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8036 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8037 the display property, but just return a value indicating whether
8038 the display property will replace the characters it covers.
8039 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8040 frame_window_p members of struct bidi_it.
d6d100dd
SM
8041 (compute_display_string_pos, compute_display_string_end):
8042 New functions.
fec2107c
EZ
8043 (push_it): Accept second argument POSITION, where pop_it should
8044 jump to continue iteration.
8045 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8046
fec2107c
EZ
8047 * keyboard.c (adjust_point_for_property): Adjust the call to
8048 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8049
8050 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8051 (bidi_init_it): Update prototypes.
8052 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8053 (compute_display_string_pos, compute_display_string_end):
8054 Declare prototypes.
fec2107c
EZ
8055 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8056 EMACS_INT.
fc6f18ce 8057
40087514 80582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8059
57f53182
PE
8060 Malloc failure behavior now depends on size of allocation.
8061 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8062 * lisp.h: Change signatures accordingly.
8063 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8064 All callers changed. (Bug#8762)
8065
8066 * gnutls.c: Use Emacs's memory allocators.
8067 Without this change, the gnutls library would invoke malloc etc.
8068 directly, which causes problems on non-SYNC_INPUT hosts, and which
8069 runs afoul of improving memory_full behavior. (Bug#8761)
8070 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8071 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8072 xfree instead of the default malloc, realloc, free.
8073 (Fgnutls_boot): No need to check for memory allocation failure,
8074 since xmalloc does that for us.
8075
ac32cd99 8076 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8077 * category.c (hash_get_category_set):
8078 * ccl.c (ccl_driver):
8079 * charset.c (Fdefine_charset_internal):
8080 * charset.h (struct charset.hash_index):
8081 * composite.c (get_composition_id, gstring_lookup_cache)
8082 (composition_gstring_put_cache):
8083 * composite.h (struct composition.hash_index):
8084 * dispextern.h (struct image.hash):
8085 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8086 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8087 (hashfn_equal, hashfn_user_defined, make_hash_table)
8088 (maybe_resize_hash_table, hash_lookup, hash_put)
8089 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8090 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8091 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8092 * image.c (make_image, search_image_cache, lookup_image)
8093 (xpm_put_color_table_h):
8094 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8095 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8096 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8097 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8098 * alloc.c (allocate_vectorlike):
8099 Check for overflow in vector size calculations.
8100 * ccl.c (ccl_driver):
8101 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8102 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8103 need to be updated by these changes.
40087514
PE
8104 * fns.c (make_hash_table, maybe_resize_hash_table):
8105 Check for integer overflow with large hash tables.
0de4bb68
PE
8106 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8107 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8108 (SXHASH_REDUCE): New macro.
8109 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8110 Use it instead of discarding useful hash info with large hash values.
8111 (sxhash_float): New function.
8112 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8113 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8114 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8115 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8116 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8117 Adjust signatures to match updated version of code.
8118 (consing_since_gc): Now EMACS_INT, since a single hash table can
8119 use more than INT_MAX bytes.
8120
698d32e2
DN
81212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8122
8123 Make it possible to build with GCC-4.6+ -O2 -flto.
8124
8125 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8126
fd6fa53f
SM
81272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8128
8129 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8130 Call minibuffer-inactive-mode.
8131
864db017
JB
81322011-05-31 Juanma Barranquero <lekktu@gmail.com>
8133
8134 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8135 Update dependencies.
8136
2ad0baf4
DN
81372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8138
8139 * data.c (init_data): Remove code for UTS, this system is not
8140 supported anymore.
8141
4fcc2638
DN
81422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8143
8144 Don't force ./temacs to start in terminal mode.
8145
8146 * frame.c (make_initial_frame): Initialize faces in all cases, not
8147 only when CANNOT_DUMP is defined.
8148 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8149
c56e0fd5
DN
81502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8151
8152 * dispnew.c (add_window_display_history): Use const for the string
8153 pointer. Remove declaration, not needed.
8154
333d54da 81552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8156
55d4c1b2 8157 Use 'inline', not 'INLINE'.
333d54da 8158 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8159 * alloc.c, fontset.c (INLINE): Remove.
8160 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8161 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8162 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8163 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8164 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8165
738db178
DN
81662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8167
8168 Make it possible to run ./temacs.
8169
8170 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8171 syms_of_callproc does the same thing. Remove test for
8172 "initialized", do it in the caller.
8173 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8174
620c53a6
SM
81752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8176
8177 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8178 (read_minibuf): Use get_minibuffer.
8179 (syms_of_minibuf): Use DEFSYM.
8180 (Qmetadata): New var.
8181 * data.c (Qbuffer): Don't make it static.
8182 (syms_of_data): Use DEFSYM.
8183
e003a292
PE
81842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8185
8186 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8187 (CCL_CODE_MIN): New macro.
8188
ed008a6d
PE
81892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8190
3687c2ef
PE
8191 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8192
ed008a6d
PE
8193 * eval.c (Qdebug): Now static.
8194 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8195 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8196 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8197
d66c4c7c
CY
81982011-05-29 Chong Yidong <cyd@stupidchicken.com>
8199
8200 * image.c: Various fixes to ImageMagick code comments.
8201 (Fimagemagick_types): Doc fix.
8202
5fbc2025
PE
82032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8204
0196f88a
PE
8205 Minor fixes prompted by GCC 4.6.0 warnings.
8206
8207 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8208
5fbc2025
PE
8209 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8210 (x_clipboard_manager_save_all): Move extern decl to ...
8211 * xterm.h: ... here, so that it can be checked for consistency.
8212
1dd3c2d9
CY
82132011-05-29 Chong Yidong <cyd@stupidchicken.com>
8214
8215 * xselect.c (x_clipboard_manager_save_frame)
8216 (x_clipboard_manager_save_all): New functions.
8217 (Fx_clipboard_manager_save): Lisp function deleted.
8218
8219 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8220 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8221
8222 * xterm.h: Update prototype.
8223
5ba6571d
WX
82242011-05-28 William Xu <william.xwl@gmail.com>
8225
8226 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8227 exiting (Bug#8239).
8228
3eaff834
JM
82292011-05-28 Jim Meyering <meyering@redhat.com>
8230
e1900994 8231 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8232 * fns.c (to_uchar): Define.
8233 (crypto_hash_function): Use it to convert some newly-signed
8234 variables to unsigned, to avoid sign-extension bugs. For example,
8235 without this change, (md5 "truc") would evaluate to
8236 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8237 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8238 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8239
0f6990a7
PE
82402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8241
8242 Integer overflow fixes.
c8a9ca5a 8243
08686060
PE
8244 * dbusbind.c: Serial number integer overflow fixes.
8245 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8246 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8247 to hold a serial number that is too large for a fixnum.
8248 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8249 Check for serial numbers out of range. Decode any serial number
59568bf0 8250 that was so large that it became a float. (Bug#8722)
08686060 8251
2d1fc3c7
PE
8252 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8253 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8254 Use XFASTINT rather than XUINT when numbers are nonnegative.
8255 (xd_append_arg, Fdbus_method_return_internal):
8256 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8257 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8258 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8259 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8260 (Bug#8722)
2d1fc3c7 8261
c8a9ca5a
PE
8262 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8263
519e1d69
PE
8264 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8265
6df6ae42 8266 ccl: Add integer overflow checks.
30569699
PE
8267 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8268 (IN_INT_RANGE): New macros.
8269 (ccl_driver): Use them to check for integer overflow when
8270 decoding a CCL program. Many of the new checks are whether XINT (x)
8271 fits in int; it doesn't always, on 64-bit hosts. The new version
8272 doesn't catch all possible integer overflows, but it's an
847044ea 8273 improvement. (Bug#8719)
30569699 8274
c11285dc
PE
8275 * alloc.c (make_event_array): Use XINT, not XUINT.
8276 There's no need for unsigned here.
8277
fdccd48e
PE
8278 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8279 This follows up to the 2011-05-06 change that substituted uintptr_t
8280 for EMACS_INT. This case wasn't caught back then.
8281
37910ab2
PE
8282 Rework Fformat to avoid integer overflow issues.
8283 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8284 now (part of C89). Include <verify.h>.
8285 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8286 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8287 (Fformat): Avoid the prepass trying to compute sizes; it was only
8288 approximate and thus did not catch overflow reliably. Instead, walk
8289 through the format just once, formatting and computing sizes as we go,
8290 checking for integer overflow at every step, and allocating a larger
8291 buffer as needed. Keep track separately whether the format is
8292 multibyte. Keep only the most-recently calculated precision, rather
8293 than them all. Record whether each argument has been converted to
8294 string. Use EMACS_INT, not int, for byte and char and arg counts.
8295 Support field widths and precisions larger than INT_MAX. Avoid
8296 sprintf's undefined behavior with conversion specifications such as %#d
8297 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8298 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8299 formatting out-of-range floating point numbers with int
9173deec 8300 formats. (Bug#8668)
37910ab2 8301
2e6578fb
PE
8302 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8303
0ae6bdee
PE
8304 * data.c: Avoid integer truncation in expressions involving floats.
8305 * data.c: Include <intprops.h>.
8306 (arith_driver): When there's an integer overflow in an expression
8307 involving floating point, convert the integers to floating point
8308 so that the resulting value does not suffer from catastrophic
8309 integer truncation. For example, on a 64-bit host (* 4
8310 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8311 Do not rely on undefined behavior after integer overflow.
8312
de883a70
PE
8313 merge count_size_as_multibyte, parse_str_to_multibyte
8314 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8315 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8316 Check for integer overflow.
8317 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8318 since it's now a duplicate of the other. This is more of
8319 a character than a buffer op, so better that it's in character.c.
8320 * fns.c, print.c: Adjust to above changes.
8321
2ff916cb
PE
83222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8323
8324 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8325
f1b54466
PE
83262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8327
fb1ac845
PE
8328 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8329 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8330 (x_clipboard_manager_save): Now static.
8331 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8332
f1b54466
PE
8333 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8334 (crypto_hash_function): Now static.
8335 Fix pointer signedness problems. Avoid unnecessary initializations.
8336
a9f737ee
CY
83372011-05-27 Chong Yidong <cyd@stupidchicken.com>
8338
8339 * termhooks.h (Vselection_alist): Make it terminal-local.
8340
8341 * terminal.c (create_terminal): Initialize it.
8342
8343 * xselect.c: Support for clipboard managers.
8344 (Vselection_alist): Move to termhooks.h as terminal-local var.
8345 (LOCAL_SELECTION): New macro.
8346 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8347 (symbol_to_x_atom): Remove gratuitous arg.
8348 (x_handle_selection_request, lisp_data_to_selection_data)
8349 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8350 (x_own_selection, x_get_local_selection, x_convert_selection):
8351 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8352 (some_frame_on_display): Delete unused function.
8353 (Fx_own_selection_internal, Fx_get_selection_internal)
8354 (Fx_disown_selection_internal, Fx_selection_owner_p)
8355 (Fx_selection_exists_p): New optional frame arg.
8356 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8357 (x_handle_selection_clear): Don't treat other terminals with the
8358 same keyboard specially. Use the terminal-local Vselection_alist.
8359 (x_clear_frame_selections): Use Frun_hook_with_args.
8360
8361 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8362
8363 * xterm.h: Add support for those atoms.
8364
e067f0c1
CY
83652011-05-26 Chong Yidong <cyd@stupidchicken.com>
8366
8367 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8368 (converted_selections, conversion_fail_tag): New global variables.
8369 (x_selection_request_lisp_error): Free the above.
8370 (x_get_local_selection): Remove unnecessary code.
8371 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8372 of converted selections stored in converted_selections.
8373 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8374 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8375 (x_convert_selection): New function.
8376 (x_handle_selection_event): Simplify.
8377 (x_get_foreign_selection): Don't ignore incoming requests while
8378 waiting for an answer; this will fail when we implement
8379 SAVE_TARGETS, and seems unnecessary anyway.
8380 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8381 (Vx_sent_selection_functions): Doc fix.
8382
0f4aebc0
LL
83832011-05-26 Leo Liu <sdl.web@gmail.com>
8384
8385 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8386
e61124cd
YM
83872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8388
8389 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8390
8391 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8392 for fringe update if it has periodic bitmap.
ac389d0c 8393 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8394 and fringe_bitmap_periodic_p.
8395
8396 * fringe.c (get_fringe_bitmap_data): New function.
8397 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8398 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8399 row. Mark glyph row for fringe update if periodicity changed.
8400
8401 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8402 for fringe update unless it has periodic bitmap.
8403
f16d9837
KH
84042011-05-25 Kenichi Handa <handa@m17n.org>
8405
8406 * xdisp.c (get_next_display_element): Set correct it->face_id for
8407 a static composition.
8408
e1b90ef6
LL
84092011-05-24 Leo Liu <sdl.web@gmail.com>
8410
8411 * deps.mk (fns.o):
8412 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8413
8414 * fns.c (crypto_hash_function, Fsha1): New function.
8415 (Fmd5): Use crypto_hash_function.
8416 (syms_of_fns): Add Ssha1.
8417
7400048f
PE
84182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8419
8420 * gnutls.c: Remove unused macros.
8421 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8422 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8423 Remove macros that are defined and never used.
8424 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8425
abb71cf4
CY
84262011-05-22 Chong Yidong <cyd@stupidchicken.com>
8427
8428 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8429 (Fx_get_selection_internal): Minor cleanup.
8430 (Fx_own_selection_internal): Rename arguments for consistency with
8431 select.el.
8432
6307db39
PE
84332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8434
8435 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8436
f3d4e0a4
CY
84372011-05-22 Chong Yidong <cyd@stupidchicken.com>
8438
8439 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8440
4d8ade89
YM
84412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8442
8443 * dispnew.c (scrolling_window): Don't exclude the case that the
8444 last enabled row in the desired matrix touches the bottom boundary.
8445
32078c8d
GM
84462011-05-21 Glenn Morris <rgm@gnu.org>
8447
8448 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8449 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8450 and add some more files.
32078c8d 8451
7285dc67
EZ
84522011-05-20 Eli Zaretskii <eliz@gnu.org>
8453
8454 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8455 report_file_error introduced by the change from 2011-05-07.
8456
89d1bd22
PE
84572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8458
8459 * systime.h (Time): Define only if emacs is defined.
8460 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8461 where the include path doesn't have X11/X.h by default. See
8462 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8463
cd394be1 84642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8465
8466 * composite.c (find_automatic_composition): Fix previous change.
8467
b9704ad9
GM
84682011-05-20 Glenn Morris <rgm@gnu.org>
8469
8470 * lisp.mk: New file, split from Makefile.in.
8471 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8472 (shortlisp): Remove.
8473 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8474
4a720484
GM
84752011-05-19 Glenn Morris <rgm@gnu.org>
8476
8477 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8478 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8479 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8480 (lisp): Set the order to that of loadup.el.
8481 (shortlisp): Make it a copy of $lisp.
8482 (SOME_MACHINE_LISP): Remove.
8483 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8484 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8485
a28d4396
KH
84862011-05-18 Kenichi Handa <handa@m17n.org>
8487
8488 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8489 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8490 (find_automatic_composition): Mostly rewrite for efficiency.
8491
a2b1fa8e
JB
84922011-05-18 Juanma Barranquero <lekktu@gmail.com>
8493
8494 * makefile.w32-in: Update dependencies.
8495
8e1f5610
CS
84962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8497
8498 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8499 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8500
7025ee00 85012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8502
cdfa6eab
PE
8503 Fix some integer overflow issues, such as string length overflow.
8504
06d6db33
PE
8505 * insdel.c (count_size_as_multibyte): Check for string overflow.
8506
2b4560a8
PE
8507 * character.c (lisp_string_width): Check for string overflow.
8508 Use EMACS_INT, not int, for string indexes and lengths; in
8509 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8510 the resulting string length overflows an EMACS_INT; instead,
8511 report a string overflow if no precision given. When checking for
8512 precision exhaustion, use a check that cannot possibly have
8513 integer overflow. (Bug#8675)
8514 * character.h (lisp_string_width): Adjust to new signature.
8515
cb93f9be
PE
8516 * alloc.c (string_overflow): New function.
8517 (Fmake_string): Use it. This doesn't change behavior, but saves
8518 a few bytes and will simplify future changes.
8519 * character.c (string_escape_byte8): Likewise.
8520 * lisp.h (string_overflow): New decl.
8521
1a1f3366
PE
8522 Fixups, following up to the user-interface timestamp change.
8523 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8524 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8525 * msdos.c (mouse_get_pos): Likewise.
8526 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8527 * w32gui.h (Time): Define by including "systime.h" rather than by
8528 declaring it ourselves. (Bug#8664)
8529
d4e3e4d3
PE
8530 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8531 * image.c (clear_image_cache): Likewise.
8532
f6a24d19
PE
8533 * term.c (term_mouse_position): Don't assume time_t wraparound.
8534
08dc5ae6
PE
8535 Be more systematic about user-interface timestamps.
8536 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8537 and sometimes 'EMACS_UINT', to represent these timestamps.
8538 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8539 This makes the code easier to follow, and makes it easier to catch
8540 integer overflow bugs such as Bug#8664.
8541 * frame.c (Fmouse_position, Fmouse_pixel_position):
8542 Use Time, not unsigned long, for user-interface timestamps.
8543 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8544 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8545 * keyboard.h (last_event_timestamp): Likewise.
8546 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8547 * menu.h (xmenu_show): Likewise.
8548 * term.c (term_mouse_position): Likewise.
8549 * termhooks.h (struct input_event.timestamp): Likewise.
8550 (struct terminal.mouse_position_hook): Likewise.
8551 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8552 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8553 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8554 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8555 what it was before.
8556 * menu.h, termhooks.h: Include "systime.h", for Time.
8557
8e55734a
PE
8558 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8559 Don't assume that the difference between two unsigned long values
8560 can fit into an integer. At this point, we know button_down_time
8561 <= event->timestamp, so the difference must be nonnegative, so
8562 there's no need to cast the result if double-click-time is
8563 nonnegative, as it should be; check that it's nonnegative, just in
8564 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8565 apart (about 25 days). (Bug#8664)
8e55734a 8566
841f1b75 8567 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8568 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8569
3e26f69c
PE
8570 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8571 that always fit in int. Use a sentinel instead of a counter, to
8572 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8573 * frame.h (struct frame): Use int for menu_bar_items_used
8574 instead of EMACS_INT, since it always fits in int.
3e26f69c 8575
5cc152c0
PE
8576 * menu.c (grow_menu_items): Check for int overflow.
8577
d89eb65e
PE
8578 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8579
5235bd3e
PE
8580 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8581 Before, the code was not consistent. These values cannot exceed
8582 2**31 - 1 so there's no need to make them unsigned.
8583 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8584 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8585 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8586 as modifiers.
8587 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8588
bc827e23
PE
8589 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8590 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8591 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8592 presumably because the widths might not match.
8593
78eb494e
PE
8594 * window.c (size_window): Avoid needless test at loop start.
8595
04f2d78b
CB
85962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8597
8598 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8599
d2fc7e3d 86002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8601
8602 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8603
d2fc7e3d 86042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8605
8606 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8607 `width' to `bar_area_x' and `bar_area_width', respectively.
8608 (x_scroll_run): Take account of fringe background extension.
8609
04f2d78b
CB
8610 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8611 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8612 `bar_area_width', respectively.
8613 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8614 background extension.
8615
79b70037
GM
86162011-05-10 Jim Meyering <meyering@redhat.com>
8617
8618 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8619
2f142cc5
JB
86202011-05-10 Juanma Barranquero <lekktu@gmail.com>
8621
8622 * image.c (Finit_image_library): Return t for built-in image types,
8623 like pbm and xbm. (Bug#8640)
8624
57679c86
AS
86252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8626
8627 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8628
888c9e86
EZ
86292011-05-07 Eli Zaretskii <eliz@gnu.org>
8630
b0512a1d
EZ
8631 * w32console.c (Fset_screen_color): Doc fix.
8632 (Fget_screen_color): New function.
8633 (syms_of_ntterm): Defsubr it.
8634
7285dc67
EZ
8635 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8636 unlink the temporary file if Fcall_process didn't create it in the
8637 first place.
8638 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8639 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8640 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8641 cue to call_process_cleanup not to close that handle.
8642
4d3fcc8e
BK
86432011-05-07 Ben Key <bkey76@gmail.com>
8644
8645 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8646 one of two shell specific rules, either bootstrap-temacs-CMD or
8647 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8648 to the previous implementation of the bootstrap-temacs rule.
8649 The bootstrap-temacs-CMD rule is similar to the previous
8650 implementation of the bootstrap-temacs rule except that it
8651 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8652 variable.
8653
8654 These changes, along with some changes to nt/configure.bat,
8655 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8656 earlier fix to add support for --cflags and --ldflags options
8657 that include quotes so that it works whether make uses cmd or
8658 sh as the shell.
8659
b4289b64
MA
86602011-05-06 Michael Albinus <michael.albinus@gmx.de>
8661
8662 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8663 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8664 is a constant.
8665 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8666 a string. Handle both cases.
8667 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8668 (Fdbus_register_method): Use Qinvalid_function.
8669
af4c0e28
JB
86702011-05-06 Juanma Barranquero <lekktu@gmail.com>
8671
8672 * makefile.w32-in: Update dependencies.
8673 (LISP_H): Add inttypes.h and stdin.h.
8674 (PROCESS_H): Add unistd.h.
8675
c51453d9
EZ
86762011-05-06 Eli Zaretskii <eliz@gnu.org>
8677
8678 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8679 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8680
8ff0ac3c 86812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8682
4c4b566b
PE
8683 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8684
aab2b9b5
PE
8685 * term.c (vfatal): Remove stray call to va_end.
8686 It's not needed and the C Standard doesn't allow it here anyway.
8687
c378da0b
PE
8688 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8689 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8690
288b08c7
PE
8691 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8692 bytes.
8693
e3601888
PE
8694 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8695
db6c0e74
PE
8696 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8697
dd5963ea
PE
8698 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8699
88c9450f
PE
8700 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8701
2f9442b8
PE
8702 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8703
c032b5f8
PE
8704 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8705 * charset.c (Fdefine_charset_internal): Don't initialize
8706 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8707 32-bit int (Bug#8600).
a108c10b
PE
8708
8709 * lread.c (read_integer): Be more consistent with string-to-number.
8710 Use string_to_number to do the actual conversion; this avoids
8711 rounding errors and fixes some other screwups. Without this fix,
8712 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8713 (digit_to_number): Move earlier, for benefit of read_integer.
8714 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8715 not a digit in any supported base. (Bug#8602)
a108c10b 8716
ad5f9eea
PE
8717 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8718
aec1708a
PE
8719 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8720 to match comment at start of function. This also removes a
8721 GCC warning about overflow in a 32+64-bit port.
8722
47be4ab5
PE
8723 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8724
371cac43
PE
8725 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8726 Reported by Stefan Monnier in
8727 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8728 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8729 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8730
d01a7826
PE
8731 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8732 (EMACS_UINTPTR): Likewise, with uintptr_t.
8733
7fd47d5c
PE
8734 * lisp.h: Prefer 64-bit EMACS_INT if available.
8735 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8736 on 32-bit hosts that have 64-bit int, so that they can access
8737 large files.
122b0c86
PE
8738 However, temporarily disable this change unless the temporary
8739 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8740
8727937b
PE
8741 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8742
8ac068ac
PE
8743 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8744 This removes an assumption that EMACS_INT and long are the same
8745 width as pointers. The assumption is true for Emacs porting targets
8746 now, but we want to make other targets possible.
8747 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8748 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8749 In the rest of the code, change types of integers that hold casted
8750 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8751 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8752 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8753 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8754 No need to cast type when ORing.
8755 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8756 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8757 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8758 assume EMACS_INT is the same width as char *.
8759 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8760 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8761 Remove no-longer-needed casts.
8762 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8763 (xg_tool_bar_help_callback, xg_make_tool_item):
8764 Use EMACS_INTPTR to hold an integer
8765 that will be cast to void *; this can avoid a GCC warning
8766 if EMACS_INT is not the same width as void *.
8767 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8768 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8769 (current_message_1, set_message_1):
8770 Use a local to convert to proper width without a cast.
8771 * xmenu.c (dialog_selection_callback): Likewise.
8772
ede49d71
PE
8773 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8774 Also, don't assume VALBITS / RAND_BITS is less than 5,
8775 and don't rely on undefined behavior when shifting a 1 left into
8776 the sign bit.
8777 * lisp.h (get_random): Change signature to match.
8778
2f30ecd0
PE
8779 * lread.c (hash_string): Use size_t, not int, for hash computation.
8780 Normally we prefer signed values; but hashing is special, because
8781 it's better to use unsigned division on hash table sizes so that
8782 the remainder is nonnegative. Also, size_t is the natural width
8783 for hashing into memory. The previous code used 'int', which doesn't
8784 retain enough info to hash well into very large tables.
8785 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8786
2a866e7b
PE
8787 * dbusbind.c: Don't possibly lose pointer info when converting.
8788 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8789 Use XPNTR rather than XHASH, so that the high-order bits of
8790 the pointer aren't lost when converting through void *.
8791
51639eac
PE
8792 * eval.c (Fautoload): Don't double-shift a pointer.
8793
92394119
PE
8794 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8795
dbdb9a7c
JB
87962011-05-06 Juanma Barranquero <lekktu@gmail.com>
8797
8798 * gnutls.c (DEF_GNUTLS_FN):
8799 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8800
db7a0b4f
AS
88012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8802
8803 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8804 marker. (Bug#8610)
8805
cd394be1 88062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8807
8808 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8809 New version that can reserve upto 2GB of heap space.
8810
f7ff1b0f 88112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8812
8813 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8814
639c109b
TZ
88152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8816
8817 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8818 `gnutls_certificate_set_x509_key_file'.
8819
d2127135
JB
88202011-05-05 Juanma Barranquero <lekktu@gmail.com>
8821
8822 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8823 Update dependencies.
8824
e968f4f3
JB
88252011-05-04 Juanma Barranquero <lekktu@gmail.com>
8826
8827 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8828 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8829 Remove unused parameter `fildes'.
8830 * process.c (read_process_output, send_process): Don't pass it.
8831
84d358f0
JB
88322011-05-04 Juanma Barranquero <lekktu@gmail.com>
8833
8834 Fix previous change: the library cache is defined in w32.c.
8835 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8836 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8837
0898ca10
JB
88382011-05-04 Juanma Barranquero <lekktu@gmail.com>
8839
8840 Implement dynamic loading of GnuTLS on Windows.
8841
8842 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8843 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8844 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8845 Declare.
8846
8847 * gnutls.c (Qgnutls_dll): Define.
8848 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8849 (gnutls_*): Declare function pointers.
8850 (init_gnutls_functions): New function to initialize function pointers.
8851 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8852 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8853 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8854 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8855 (emacs_gnutls_write, emacs_gnutls_read)
8856 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8857 (Fgnutls_available_p): New function.
8858 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8859 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8860 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8861
8862 * image.c: Include w32.h.
8863 (Vimage_type_cache): Delete.
8864 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8865 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8866 (w32_delayed_load): Move to w32.c.
8867
8868 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8869
8870 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8871 (w32_delayed_load): Move from image.c. When loading a library, record
8872 its filename in the :loaded-from property of the library id.
8873 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8874 Initialize and staticpro them.
8875 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8876
8877 * process.c: Include lisp.h before w32.h, not after.
8878 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8879 instead of gnutls_record_check_pending.
8880
8881 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8882
ff4de4aa
TZ
88832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8884
8885 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8886 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8887 as passed in.
8888
abe95abb
JD
88892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8890
8891 * xterm.c (x_set_frame_alpha): Do not set property on anything
8892 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8893
e16e55d4
JB
88942011-05-02 Juanma Barranquero <lekktu@gmail.com>
8895
8896 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8897
bafcf6a5
JB
88982011-05-02 Juanma Barranquero <lekktu@gmail.com>
8899
8900 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8901 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8902 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8903 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8904 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8905 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
8906 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
8907 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
8908 (Qgnutls_bootprop_callbacks_verify): Make static.
8909
e7a6747f
AS
89102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
8911
19ed11ba
AS
8912 * callproc.c: Indentation fixup.
8913
e7a6747f 8914 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
8915 (wait_for_termination, interruptible_wait_for_termination):
8916 Move after wait_for_termination_1.
e7a6747f 8917
1ef14cb4
LMI
89182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
8919
8920 * sysdep.c (interruptible_wait_for_termination): New function
8921 which is like wait_for_termination, but allows keyboard
8922 interruptions.
8923
8924 * callproc.c (Fcall_process): Add (:file "file") as an option for
8925 the STDOUT buffer.
8926 (Fcall_process_region): Ditto.
8927
330d880c
EZ
89282011-04-30 Eli Zaretskii <eliz@gnu.org>
8929
8db90b73
EZ
8930 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
8931 rather than `XVECTOR (FOO)->size'.
8932
330d880c
EZ
8933 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
8934 inttypes.h, as a gnulib replacement is used if it not available in
8935 system headers.
8936
15cbd324
EZ
89372011-04-21 Eli Zaretskii <eliz@gnu.org>
8938
8939 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
8940 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
8941 of MOST_POSITIVE_FIXNUM. (Bug#8528)
8942
8943 * coding.c (coding_alloc_by_realloc): Error out if destination
8944 will grow beyond MOST_POSITIVE_FIXNUM.
8945 (decode_coding_emacs_mule): Abort if there isn't enough place in
8946 charbuf for the composition carryover bytes. Reserve an extra
8947 space for up to 2 characters produced in a loop.
8948 (decode_coding_iso_2022): Abort if there isn't enough place in
8949 charbuf for the composition carryover bytes.
8950
89512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 8952
ae940cca
EZ
8953 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
8954 aborting when %lld or %lll format is passed.
8955 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
8956 %llo or %llx format is passed. (Bug#8545)
8957
03ab8921
EZ
8958 * window.c (window_scroll_line_based): Use a marker instead of
8959 simple variables to record original value of point. (Bug#7952)
8960
afda1437
EZ
8961 * doprnt.c (doprnt): Fix the case where a multibyte sequence
8962 produced by %s or %c overflows available buffer space. (Bug#8545)
8963
f76dee0c
PE
89642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
8965
8966 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 8967 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 8968
fdc5744d
JB
89692011-04-28 Juanma Barranquero <lekktu@gmail.com>
8970
8971 * w32.c (init_environment): Warn about defaulting HOME to C:\.
8972
638f053a
JB
89732011-04-28 Juanma Barranquero <lekktu@gmail.com>
8974
8975 * keyboard.c (Qdelayed_warnings_hook): Define.
8976 (command_loop_1): Run `delayed-warnings-hook'
8977 if Vdelayed_warnings_list is non-nil.
8978 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
8979 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
8980
d178f871
EZ
89812011-04-28 Eli Zaretskii <eliz@gnu.org>
8982
8983 * doprnt.c (doprnt): Don't return value smaller than the buffer
8984 size if the message was truncated. (Bug#8545).
8985
b124fd93
JB
89862011-04-28 Juanma Barranquero <lekktu@gmail.com>
8987
8988 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
8989 (Fx_window_property): #if-0 the whole functions, not just the bodies.
8990
e810457d
PE
89912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
8992
8993 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
8994
ea51cceb
JB
89952011-04-27 Juanma Barranquero <lekktu@gmail.com>
8996
8997 * makefile.w32-in: Update dependencies.
8998
94dcfacf
EZ
89992011-04-27 Eli Zaretskii <eliz@gnu.org>
9000
9001 Improve `doprnt' and its usage. (Bug#8545)
9002 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9003 `format_end'. Remove support for %l as a conversion specifier.
9004 Don't use xrealloc. Improve diagnostics when the %l size modifier
9005 is used. Update the commentary.
9006
9007 * eval.c (verror): Simplify calculation of size_t.
9008
9009 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9010 messages.
9011
f61f41d7
PE
90122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9013
9014 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9015 change.
9016
96fb4434
PE
90172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9018
9019 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9020 This makes this file independent of the recent pseudovector change.
9021
671875da 90222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9023
69e9b5a3
PE
9024 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9025
b5f869a7 9026 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9027 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9028 Remove unused local.
c8926152 9029 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9030
841a1577 9031 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9032 GCC 4.6.0 optimizes based on type-based alias analysis.
9033 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9034 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9035 != &v->size, and therefore "v->size = 1; b->size = 2; return
9036 v->size;" must therefore return 1. This assumption is incorrect
9037 for Emacs, since it type-puns struct Lisp_Vector * with many other
9038 types. To fix this problem, this patch adds a new type struct
f904488f 9039 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9040 and pseudovectors, and helps optimizing compilers not get fooled
9041 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9042 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9043 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9044 the size member.
eab3844f
PE
9045 (XSETPVECTYPE): Rewrite in terms of new macro.
9046 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9047 This is a bit clearer, and further avoids the possibility of
9048 undesirable aliasing.
9049 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9050 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9051 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9052 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9053 (ASIZE): Now uses header.size rather than size.
9054 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9055 to avoid the hassle of writing XVECTOR (foo)->header.size.
9056 (struct vectorlike_header): New type.
eab3844f
PE
9057 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9058 object, to help avoid aliasing.
9059 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9060 (SUBRP): Likewise, since Lisp_Subr is a special case.
9061 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9062 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9063 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9064 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9065 changed to be "header.size" and "header.next".
9066 * buffer.h (struct buffer): Likewise.
9067 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9068 * frame.h (struct frame): Likewise.
9069 * process.h (struct Lisp_Process): Likewise.
9070 * termhooks.h (struct terminal): Likewise.
9071 * window.c (struct save_window_data, struct saved_window): Likewise.
9072 * window.h (struct window): Likewise.
9073 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9074 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9075 * buffer.c (init_buffer_once): Likewise.
9076 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9077 special case.
9078 * process.c (Fformat_network_address): Use local var for size,
9079 for brevity.
9080
0df1eac5
PE
9081 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9082
847ab9d1 9083 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9084 * data.c (atof): Remove decl; no longer used or needed.
9085 (digit_to_number): Move to lread.c.
9086 (Fstring_to_number): Use new string_to_number function, to be
9087 consistent with how the Lisp reader treats infinities and NaNs.
9088 Do not assume that floating-point numbers represent EMACS_INT
9089 without losing information; this is not true on most 64-bit hosts.
9090 Avoid double-rounding errors, by insisting on integers when
9091 parsing non-base-10 numbers, as the documentation specifies.
9092 * lisp.h (string_to_number): New decl, replacing ...
9093 (isfloat_string): Remove.
bc0a5c13 9094 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9095 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9096 appears to have been a coding error. Similarly, do not accept
9097 strings like +-1e0 as floating point numbers. Do not report
9098 overflow for integer overflows unless the base is not 10 which
9099 means we have no simple and reliable way to continue.
9100 Break out the floating-point parsing into a new
9101 function string_to_number, so that Fstring_to_number parses
9102 floating point numbers consistently with the Lisp reader.
04f2d78b 9103 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9104 (E_CHAR, EXP_INT): Remove, replacing with ...
9105 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9106 (string_to_number): New function, replacing isfloat_string.
9107 This function checks for valid syntax and produces the resulting
9108 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9109 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9110 so that overflow for non-base-10 numbers is reported only when
9111 there's no portable and simple way to convert to floating point.
452f4150 9112
67769ffc
PE
9113 * textprop.c (set_text_properties_1): Rewrite for clarity,
9114 and to avoid GCC warning about integer overflow.
9115
c20db43f
PE
9116 * intervals.h (struct interval): Use EMACS_INT for members
9117 where EMACS_UINT might cause problems. See
9118 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9119 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9120 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9121 All uses changed.
37aa2f85
PE
9122 (offset_intervals): Tell GCC not to worry about length overflow
9123 when negating a negative length.
c20db43f 9124
2538aa2f
PE
9125 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9126 (overrun_check_free): Likewise.
9127
f2d3008d
PE
9128 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9129 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9130 word size.
9131
ec8df744
PE
9132 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9133 (gnutls_make_error): Rename local to avoid shadowing.
9134 (gnutls_emacs_global_deinit): ifdef out; not used.
9135 (Fgnutls_boot): Use const for pointer to readonly storage.
9136 Comment out unused local. Fix pointer signedness problems.
9137
640ee02d
PE
9138 * lread.c (openp): Don't stuff size_t into an 'int'.
9139 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9140 about possible signed overflow.
9141
6048fb2a
PE
9142 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9143 (GDK_KEY_g): Don't define if already defined.
9144 (xg_prepare_tooltip): Avoid pointer signedness problem.
9145 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9146
fa3c87e1
PE
9147 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9148 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9149
2172544b
PE
9150 * xfns.c (Fx_window_property): Simplify a bit,
9151 to make a bit faster and to avoid GCC 4.6.0 warning.
9152 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9153
9b821a21
PE
9154 * fns.c (internal_equal): Don't assume size_t fits in int.
9155
3c616cfa
PE
9156 * alloc.c (compact_small_strings): Tighten assertion a little.
9157
c2982e87
PE
9158 Replace pEd with more-general pI, and fix some printf arg casts.
9159 * lisp.h (pI): New macro, generalizing old pEd macro to other
9160 conversion specifiers. For example, use "...%"pI"d..." rather
9161 than "...%"pEd"...".
9162 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9163 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9164 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9165 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9166 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9167 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9168 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9169 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9170 64-bit hosts.
9171 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9172 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9173 * print.c (safe_debug_print, print_object): Likewise.
9174 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9175 to int.
6f04d126
PE
9176 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9177 avoiding the 0 flag, which is not portable.
c2982e87
PE
9178 * process.c (Fmake_network_process): Use pI to avoid cast.
9179 * region-cache.c (pp_cache): Likewise.
9180 * xdisp.c (decode_mode_spec): Likewise.
9181 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9182 behavior on 64-bit hosts with printf arg.
6f04d126 9183 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9184 (x_stop_queuing_selection_requests): Likewise.
9185 (x_get_window_property): Don't truncate byte count to an 'int'
9186 when tracing.
0b432f21 9187
5e073ec7
PE
9188 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9189 here, since it parses constructs like leading '-' and spaces,
9190 which are not wanted; and it overflows with large numbers.
9191 Instead, simply match F[0-9]+, which is what is wanted anyway.
9192
36372bf9
PE
9193 * alloc.c: Remove unportable assumptions about struct layout.
9194 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9195 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9196 (allocate_vectorlike, make_pure_vector): Use the new macros,
9197 plus offsetof, to remove unportable assumptions about struct layout.
9198 These assumptions hold on all porting targets that I know of, but
9199 they are not guaranteed, they're easy to remove, and removing them
9200 makes further changes easier.
9201
0b432f21
PE
9202 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9203 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9204 (string_overrun_cookie): Now const. Use initializers that
9205 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9206 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9207 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9208 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9209 multiple of sizeof (EMACS_INT); it need not be, if
9210 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9211 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9212
895009e1
JB
92132011-04-26 Juanma Barranquero <lekktu@gmail.com>
9214
9215 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9216
6a7a1b0b
TZ
92172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9218
9219 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9220 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9221 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9222
841a1577 92232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9224
9225 * lisp.h (Qdebug): List symbol.
895009e1 9226 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9227 * keyboard.c (debug-on-event): New variable.
9228 (handle_user_signal): Break into debugger when debug-on-event
9229 matches the current signal symbol.
9230
f2d3ba6f
DN
92312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9232
9233 * alloc.c (check_sblock, check_string_bytes)
9234 (check_string_free_list): Convert to standard C.
9235
42ce4c63
TZ
92362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9237
9238 * w32.c (emacs_gnutls_push): Fix typo.
9239
825cd63c
EZ
92402011-04-25 Eli Zaretskii <eliz@gnu.org>
9241
fb11d64d
EZ
9242 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9243 "cast to pointer from integer of different size".
9244
825cd63c
EZ
9245 Improve doprnt and its use in verror. (Bug#8545)
9246 * doprnt.c (doprnt): Document the set of format control sequences
9247 supported by the function. Use SAFE_ALLOCA instead of always
9248 using `alloca'.
9249
9250 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9251 is one byte too soon. Don't use xrealloc; instead xfree and
9252 xmalloc anew.
9253
e061a11b
TZ
92542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9255
9256 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9257 callbacks stage.
9258
9259 * gnutls.c: Renamed global_initialized to
9260 gnutls_global_initialized. Added internals for the
9261 :verify-hostname-error, :verify-error, and :verify-flags
9262 parameters of `gnutls-boot' and documented those parameters in the
9263 docstring. Start callback support.
9173deec
JB
9264 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9265 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9266 on error. Return error code.
e061a11b
TZ
9267 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9268 (emacs_gnutls_read): Likewise.
9269 (Fgnutls_boot): Return handshake error code.
9270 (emacs_gnutls_handle_error): New function.
9271 (wsaerror_to_errno): Likewise.
9272
9273 * w32.h (emacs_gnutls_pull): Add prototype.
9274 (emacs_gnutls_push): Likewise.
9275
9276 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9277 (emacs_gnutls_push): Likewise.
9278
92792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9280
9281 * process.c (wait_reading_process_output): Check if GnuTLS
9282 buffered some data internally if no FDs are set for TLS
9283 connections.
9284
9285 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9286 (LIBS): Link to USER_LIBS.
9287 ($(BLD)/gnutls.$(0)): New target.
9288
fa6996bc
EZ
92892011-04-24 Eli Zaretskii <eliz@gnu.org>
9290
eb35682e
EZ
9291 * xdisp.c (handle_single_display_spec): Rename the
9292 display_replaced_before_p argument into display_replaced_p, to
9293 make it consistent with the commentary. Fix typos in the
9294 commentary.
9295
e2ad650c
EZ
9296 * textprop.c (syms_of_textprop): Remove dead code.
9297 (copy_text_properties): Delete obsolete commentary about an
9298 interface that was deleted long ago. Fix typos in the description
9299 of arguments.
9300
1b2de274
EZ
9301 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9302 to changes in oldXMenu/XMenu.h from 2011-04-16.
9303 <menu_help_message, prev_menu_help_message>: Constify.
9304 (IT_menu_make_room): menu->help_text is now `const char **';
9305 adjust.
9306
9307 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9308 to changes in oldXMenu/XMenu.h from 2011-04-16.
9309 (struct XMenu): Declare `help_text' `const char **'.
9310
9311 * xfaces.c <Qunspecified>: Make extern again.
9312
9313 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9314 required by POSIX.
1b2de274 9315
762b15be
EZ
9316 * doc.c (get_doc_string): Improve the format passed to `error'.
9317
9318 * doprnt.c (doprnt): Improve commentary.
9319
9320 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9321
9322 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9323 them with etags.
9324
f1052e5d
EZ
9325 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9326 changes in globals.h immediately force recompilation.
762b15be
EZ
9327 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9328 $(CURDIR)/s/ms-w32.h.
9329 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9330
fa6996bc
EZ
9331 * character.c (Fchar_direction): Function deleted.
9332 (syms_of_character): Don't defsubr it.
9333 <char-direction-table>: Deleted.
9334
e6c3da20
EZ
93352011-04-23 Eli Zaretskii <eliz@gnu.org>
9336
9337 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9338 * doprnt.c: Include limits.h.
9339 (SIZE_MAX): New macro.
04f2d78b
CB
9340 (doprnt): Return a size_t value. 2nd arg is now size_t.
9341 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9342 Improve overflow protection. Support `l' modifier for integer
9343 conversions. Support %l conversion. Don't assume an EMACS_INT
9344 argument for integer conversions and for %c.
9345
9346 * lisp.h (doprnt): Restore prototype.
9347
9348 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9349 $(SRC)/character.h.
9350
9351 * Makefile.in (base_obj): Add back doprnt.o.
9352
9353 * deps.mk (doprnt.o): Add back prerequisites.
9354 (callint.o): Depend on character.h.
9355
9356 * eval.c (internal_lisp_condition_case): Include the handler
9357 representation in the error message.
9358 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9359 when breaking from the loop.
9360
9361 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9362
9363 * callint.c (Fcall_interactively): When displaying error message
9364 about invalid control letter, pass the character's codepoint, not
9365 a pointer to its multibyte form. Improve display of the character
9366 in octal and display also its hex code.
9367
9368 * character.c (char_string): Use %x to display the (unsigned)
9369 codepoint of an invalid character, to avoid displaying a bogus
9370 negative value.
9371
9372 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9373 `error', not SYMBOL_NAME itself.
9374
9375 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9376 character arguments to `error'.
9377
9378 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9379 to `error' in error message about FINAL_CHAR argument. Make sure
9380 FINAL_CHAR is a character, and use %c when it is passed as
9381 argument to `error'.
9382
4ffd0d6b 93832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9384
9385 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9386
9387 * w32.c: Include <time.h>.
9388 (sys_localtime): New function.
9389
4ffd0d6b 93902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9391
9392 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9393
4ffd0d6b 9394 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9395
4ffd0d6b 93962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9397
4ffd0d6b
GM
9398 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9399 zombies (Bug#8467).
aac0c6e3 9400
04c56954
EZ
94012011-04-19 Eli Zaretskii <eliz@gnu.org>
9402
9403 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9404 gl_state.e_property when gl_state.object is Qt.
9405
9406 * insdel.c (make_gap_larger): Remove limitation of buffer size
9407 to <= INT_MAX.
9408
16a43933
CY
94092011-04-18 Chong Yidong <cyd@stupidchicken.com>
9410
9411 * xdisp.c (lookup_glyphless_char_display)
9412 (produce_glyphless_glyph): Handle cons cell entry in
9413 glyphless-char-display.
9414 (Vglyphless_char_display): Document it.
9415
9416 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9417 glyphless-char-display.
9418
4581706e
CY
94192011-04-17 Chong Yidong <cyd@stupidchicken.com>
9420
9421 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9422
9423 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9424
9425 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9426 definition for no-X builds.
9427
4887c6e2 94282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9429
fd35b6f9
PE
9430 Static checks with GCC 4.6.0 and non-default toolkits.
9431
5c1ccb01
PE
9432 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9433
006c5daa
PE
9434 * process.c (keyboard_bit_set): Define only if SIGIO.
9435 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9436 (send_process): Repair possible setjmp clobbering.
9437
efc736d3
PE
9438 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9439
4e2fe2e6
PE
9440 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9441
f97334a2
PE
9442 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9443
4e75f29d
PE
9444 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9445 Define only if needed.
9446
90efadd1
PE
9447 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9448 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9449 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9450
3c647824
PE
9451 * dispextern.h (struct redisplay_interface): Rename param
9452 to avoid shadowing.
e264f262 9453 * termhooks.h (struct terminal): Likewise.
761383f4 9454 * xterm.c (xembed_send_message): Likewise.
3c647824 9455
b58c5c4a
PE
9456 * insdel.c (make_gap_smaller): Define only if
9457 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9458
cad59032
PE
9459 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9460 it.
9461
c339dc2e
PE
9462 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9463 so that we aren't warned about unused symbols.
9464
91a3e27b
PE
9465 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9466
399c71d3 9467 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9468
8ffc96f5
PE
9469 * xfns.c (x_real_positions): Mark locals as initialized.
9470
eef9bc79
PE
9471 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9472
098db9dd
PE
9473 * xterm.c: Fix problems found by static analysis with other toolkits.
9474 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9475 (x_dispatch_event): Declare static if USE_GTK, and
9476 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9477 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9478 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9479 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9480 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9481
eb18f6cc
PE
9482 * xmenu.c (menu_help_callback): Pointer type fixes.
9483 Use const pointers when pointing at readonly data. Avoid pointer
9484 signedness clashes.
9485 (FALSE): Remove unused macro.
9486 (update_frame_menubar): Remove unused decl.
9487
1fe72bf8
PE
9488 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9489
60d9e1db
PE
9490 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9491 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9492 (single_menu_item): Rename local to avoid shadowing.
9493
39261c26
PE
9494 * keyboard.c (make_lispy_event): Remove unused local var.
9495
018c5e19
PE
9496 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9497 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9498
63d2b86e
PE
9499 * bitmaps: Change bitmaps from unsigned char back to the X11
9500 compatible char. Avoid the old compiler warnings about
9501 out-of-range initializers by using, for example, '\xab' rather
9502 than 0xab.
9503
aefd87e1
PE
9504 * xgselect.c (xgselect_initialize): Check vs interface
9505 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9506
bf501fb9
PE
9507 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9508
e9829fdf
PE
9509 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9510 to read-only memory.
9511
1086c095
PE
9512 * fns.c (vector): Remove; this old hack is no longer needed.
9513
2baccd04 9514 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9515 Remove unused var.
dde42981 9516 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9517
72391843 9518 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9519
436c16df 9520 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9521 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9522 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9523
92bb796d 9524 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9525 (x_term_init): Remove local to avoid shadowing.
92bb796d 9526
764430a3 9527 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9528
9529 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9530 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9531
d1dfb56c
EZ
95322011-04-16 Eli Zaretskii <eliz@gnu.org>
9533
c4354cb4
EZ
9534 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9535
d1dfb56c
EZ
9536 Fix regex.c, syntax.c and friends for buffers > 2GB.
9537 * syntax.h (struct gl_state_s): Declare character position members
9538 EMACS_INT.
9539
9540 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9541
04f2d78b
CB
9542 * textprop.c (verify_interval_modification, interval_of):
9543 Declare arguments EMACS_INT.
d1dfb56c
EZ
9544
9545 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9546 EMACS_INT.
9547
9548 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9549
9550 * indent.c (Fvertical_motion): Local variable it_start is now
9551 EMACS_INT.
9552
9553 * regex.c (re_match, re_match_2, re_match_2_internal)
9554 (bcmp_translate, regcomp, regexec, print_double_string)
9555 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9556 (re_compile_pattern, re_exec): Declare arguments and local
9557 variables `size_t' and `ssize_t' and return values `regoff_t', as
9558 appropriate.
9559 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9560 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9561 <compile_stack_type>: `size' and `avail' are now `size_t'.
9562
9563 * regex.h <regoff_t>: Use ssize_t, not int.
9564 (re_search, re_search_2, re_match, re_match_2): Arguments that
9565 specify buffer/string position and length are now ssize_t and
9566 size_t. Return type is regoff_t.
9567
613052cd
BK
95682011-04-16 Ben Key <bkey76@gmail.com>
9569
9570 * nsfont.m: Fixed bugs in ns_get_family and
9571 ns_descriptor_to_entity that were caused by using free to
9572 deallocate memory blocks that were allocated by xmalloc (via
9573 xstrdup). This caused Emacs to crash when compiled with
9574 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9575 --enable-checking=xmallocoverrun). xfree is now used to
9576 deallocate these memory blocks.
9577
4170f62f 95782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9579
71b41406
PE
9580 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9581
9587a89d
PE
9582 emacs_write: Accept and return EMACS_INT for sizes.
9583 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9584 et seq.
9585 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9586 Accept and return EMACS_INT.
9587 (emacs_gnutls_write): Return the number of bytes written on
9588 partial writes.
9589 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9590 (emacs_read, emacs_write): Remove check for negative size, as the
9591 Emacs source code has been audited now.
9587a89d
PE
9592 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9593 (emacs_read, emacs_write): Use it.
273a5f82
PE
9594 * process.c (send_process): Adjust to the new signatures of
9595 emacs_write and emacs_gnutls_write. Do not attempt to store
9596 a byte offset into an 'int'; it might overflow.
9587a89d 9597 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9598
3e047f51
PE
9599 * sound.c: Don't assume sizes fit in 'int'.
9600 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9601 Return EMACS_INT, not int.
3e047f51 9602 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9603 Accept EMACS_INT, not int.
9604 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9605 record read return values.
9606
cc39a9db
BK
96072011-04-15 Ben Key <bkey76@gmail.com>
9608
c9d0ec6d
JB
9609 * keyboard.c (Qundefined): Don't declare static since it is used
9610 in nsfns.m.
9611 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9612 static since they are used in nsfont.m.
cc39a9db 9613
6c60eb9f
SM
96142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9615
9616 * process.c (Qprocessp): Don't declare static.
9617 * lisp.h (Qprocessp): Declare again.
9618
7990b61a
JB
96192011-04-15 Juanma Barranquero <lekktu@gmail.com>
9620
9621 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9622
5d4cb038
PE
96232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9624
8bd7b830 9625 Improve C-level modularity by making more things 'static'.
cd64ea1d 9626
e3b27b31
PE
9627 Don't publish debugger-only interfaces to other modules.
9628 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9629 (verify_bytepos, count_markers): Move decls to the only modules
9630 that need them.
9631 * region-cache.h (pp_cache): Likewise.
9632 * window.h (check_all_windows): Likewise.
9633 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9634
5d4cb038
PE
9635 * sysdep.c (croak): Now static, if
9636 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9637 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9638
9639 * alloc.c (refill_memory_reserve): Now static if
9640 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9641 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9642
e87b6180
PE
9643 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9644 Define only if USE_LUCID.
9645
ac64929e
PE
9646 * xrdb.c (x_customization_string, x_rm_string): Now static.
9647
6f37259d
PE
9648 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9649 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9650
1683e3ab
PE
9651 * xdisp.c (draw_row_with_mouse_face): Now static.
9652 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9653
de9c2632
PE
9654 * window.h (check_all_windows): Mark externally visible.
9655
2b96acb7
PE
9656 * window.c (window_deletion_count): Now static.
9657
9658 * undo.c: Make symbols static if they're not exported.
9659 (last_undo_buffer, last_boundary_position, pending_boundary):
9660 Now static.
9661
50436f33
PE
9662 * textprop.c (interval_insert_behind_hooks): Now static.
9663 (interval_insert_in_front_hooks): Likewise.
9664
64520e5c
PE
9665 * term.c: Make symbols static if they're not exported.
9666 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9667 (max_frame_lines, tty_set_terminal_modes):
9668 (tty_reset_terminal_modes, tty_turn_off_highlight):
9669 (get_tty_terminal): Now static.
9670 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9671 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9672 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9673 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9674 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9675
1fa53021
PE
9676 * sysdep.c: Make symbols static if they're not exported.
9677 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9678 Now static.
9679 (sigprocmask_set, full_mask): Remove; unused.
9680 (wait_debugging): Mark as visible.
9681 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9682 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9683
d4b43b22
PE
9684 * syntax.c (syntax_temp): Define only if !__GNUC__.
9685
b7c513d0
PE
9686 * sound.c (current_sound_device, current_sound): Now static.
9687
989b29ad
PE
9688 * search.c (searchbufs, searchbuf_head): Now static.
9689
13a55a78
PE
9690 * scroll.c (scroll_cost): Remove; unused.
9691 * dispextern.h (scroll_cost): Remove decl.
9692
de68a1fc
PE
9693 * region-cache.h (pp_cache): Mark as externally visible.
9694
40ccffa6
PE
9695 * process.c: Make symbols static if they're not exported.
9696 (process_tick, update_tick, create_process, chan_process):
9697 (Vprocess_alist, proc_buffered_char, datagram_access):
9698 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9699 (deactivate_process): Mark defn as static, as well as decl.
9700 * lisp.h (create_process): Remove decl.
9701 * process.h (chan_process, Vprocess_alist): Remove decls.
9702
ad64fc97
PE
9703 * print.c: Make symbols static if they're not exported.
9704 (print_depth, new_backquote_output, being_printed, print_buffer):
9705 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9706 (print_interval, print_number_index, initial_stderr_stream):
9707 Now static.
9708 * lisp.h (Fprinc): Remove decl.
9709 (debug_output_compilation_hack): Mark as externally visible.
9710
adddb265
PE
9711 * sysdep.c (croak): Move decl from here to syssignal.h.
9712 * syssignal.h (croak): Put it here, so the API can be checked when
9713 'croak' is called from dissociate_if_controlling_tty.
9714
1717ede2
PE
9715 * minibuf.c: Make symbols static if they're not exported.
9716 (minibuf_save_list, choose_minibuf_frame): Now static.
9717 * lisp.h (choose_minibuf_frame): Remove decl.
9718
fa5fb2bc
PE
9719 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9720
1e3890d1
PE
9721 * lread.c: Make symbols static if they're not exported.
9722 (read_objects, initial_obarray, oblookup_last_bucket_number):
9723 Now static.
9724 (make_symbol): Remove; unused.
9725 * lisp.h (initial_obarray, make_symbol): Remove decls.
9726
8a1414fa
PE
9727 * keyboard.c: Make symbols static if they're not exported.
9728 (single_kboard, recent_keys_index, total_keys, recent_keys):
9729 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9730 (this_single_command_key_start, echoing, last_auto_save):
9731 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9732 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9733 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9734 (Vlispy_mouse_stem, double_click_count):
9735 Now static.
9736 (force_auto_save_soon): Define only if SIGDANGER.
9737 (ignore_mouse_drag_p): Now static if
9738 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9739 (print_help): Remove; unused.
9740 (stop_character, last_timer_event): Mark as externally visible.
9741 * keyboard.h (ignore_mouse_drag_p): Declare only if
9742 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9743 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9744 * lisp.h (echoing): Remove decl.
9745 (force_auto_save_soon): Declare only if SIGDANGER.
9746 * xdisp.c (redisplay_window): Simplify code, to make it more
9747 obvious that ignore_mouse_drag_p is not accessed if !defined
9748 USE_GTK && !defined HAVE_NS.
9749
93ea6e8f
PE
9750 * intervals.c: Make symbols static if they're not exported.
9751 (merge_properties_sticky, merge_interval_right, delete_interval):
9752 Now static.
9753 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9754
77382fcc
PE
9755 * insdel.c: Make symbols static if they're not exported.
9756 However, leave prepare_to_modify_buffer alone. It's never
9757 called from outside this function, but that appears to be a bug.
9758 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9759 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9760 (adjust_after_replace_noundo): Remove; unused.
9761 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9762 (signal_before_change): Remove decls.
77382fcc 9763
9306c32e
PE
9764 * indent.c (val_compute_motion, val_vmotion): Now static.
9765
cd44d2eb
PE
9766 * image.c: Make symbols static if they're not exported.
9767 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9768 if USE_GTK.
9769 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9770 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9771
ad9a7a06
PE
9772 * fringe.c (standard_bitmaps): Now static.
9773 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9774
81626931
PE
9775 * frame.c: Make symbols static if they're not exported.
9776 (x_report_frame_params, make_terminal_frame): Now static.
9777 (get_frame_param): Now static, unless HAVE_NS.
9778 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9779 (x_get_resource_string): Remove; not used.
9780 * frame.h (make_terminal_frame, x_report_frame_params):
9781 (x_get_resource_string); Remove decls.
9782 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9783 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9784
239f9db9
PE
9785 * font.c, fontset.c: Make symbols static if they're not exported.
9786 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9787 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9788 * font.c (font_close_object): Now static.
9789 * font.h (font_close_object): Remove.
9790 * fontset.c (FONTSET_OBJLIST): Remove.
9791 (free_realized_fontset) #if-0 the body, which does nothing.
9792 (face_suitable_for_char_p): #if-0, as it's never called.
9793 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9794 * xfaces.c (face_at_string_position):
9795 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9796 since 0 is always ASCII.
9797
dfcf3579
PE
9798 * fns.c (weak_hash_tables): Now static.
9799
5045092b
PE
9800 * fileio.c: Make symbols static if they're not exported.
9801 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9802 (Vwrite_region_annotation_buffers): Now static.
9803
57a96f5c
PE
9804 * eval.c: Make symbols static if they're not exported.
9805 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9806 * lisp.h (backtrace_list): Remove decl.
9807
35f08c38
PE
9808 * emacs.c: Make symbols static if they're not exported.
9809 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9810 (fatal_error_code, fatal_error_signal_hook, standard_args):
9811 Now static.
9812 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9813 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9814 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9815 * lisp.h (fatal_error_signal_hook): Remove decl.
9816 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9817
f44bd759
PE
9818 * editfns.c: Move a (normally-unused) function to its only use.
9819 * editfns.c, lisp.h (get_operating_system_release): Remove.
9820 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9821 worth the hassle of breaking this out.
9822
b532497d
PE
9823 * xterm.c: Make symbols static if they're not exported.
9824 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9825 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9826 (x_destroy_window, x_delete_display):
9827 Now static.
9828 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9829 (x_mouse_leave): Remove; unused.
9830 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9831 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9832 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9833 Remove decls.
9834 (x_mouse_leave): Declare only if WINDOWSNT.
9835 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9836 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9837 USE_X_TOOLKIT.
9838
1675728f
PE
9839 * ftxfont.c: Make symbols static if they're not exported.
9840 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9841 HAVE_FREETYPE.
9842 * font.h (ftxfont_driver): Likewise.
9843
e4cebfca
PE
9844 * xfns.c: Make symbols static if they're not exported.
9845 (x_last_font_name, x_display_info_for_name):
9846 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9847 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9848 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9849 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9850 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9851 (last_show_tip_args): Now static.
9852 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9853 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9854 (x_screen_planes): Remove; unused.
9855 * dispextern.h (x_screen_planes): Remove decl.
9856
5bf46f05
PE
9857 * dispnew.c: Make symbols static if they're not exported.
9858 * dispextern.h (redraw_garbaged_frames, scrolling):
9859 (increment_row_positions): Remove.
9860 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9861 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9862 Now static.
9863 (redraw_garbaged_frames): Remove; unused.
9864
435f4c28
PE
9865 * xfaces.c: Make symbols static if they're not exported.
9866 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9867 Remove decls.
9868 * xterm.h (defined_color): Remove decls.
9869 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9870 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9871 (menu_face_changed_default, defined_color, free_realized_face):
9872 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9873 (ascii_face_of_lisp_face): Remove; unused.
9874
8524aef3
PE
9875 * xdisp.c: Make symbols static if they're not exported.
9876 * dispextern.h (scratch_glyph_row, window_box_edges):
9877 (glyph_to_pixel_coords, set_cursor_from_row):
9878 (get_next_display_element, set_iterator_to_next):
9879 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9880 (show_mouse_face): Remove decls
9881 * frame.h (message_buf_print): Likewise.
9882 * lisp.h (pop_message, set_message, check_point_in_composition):
9883 Likewise.
9884 * xterm.h (set_vertical_scroll_bar): Likewise.
9885 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9886 (message_buf_print, scratch_glyph_row, displayed_buffer):
9887 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9888 (get_next_display_element, show_mouse_face, window_box_edges):
9889 (frame_to_window_pixel_xy, check_point_in_composition):
9890 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9891 (glyph_to_pixel_coords): Remove; unused.
9892
16390cd2
PE
9893 * dired.c (file_name_completion): Now static.
9894
9895 * dbusbind.c (xd_in_read_queued_messages): Now static.
9896
a25f4dfa
PE
9897 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9898 * data.c (circular_list_error): Remove.
9899
14a9c8df
PE
9900 * commands.h (last_point_position, last_point_position_buffer):
9901 (last_point_position_window): Remove decls.
9902 * keyboard.c: Make these variables static.
9903
04f2d78b
CB
9904 * coding.h (coding, code_convert_region, encode_coding_gap):
9905 Remove decls.
74ab6df5
PE
9906 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
9907 (iso_code_class, detect_coding, code_convert_region): Now static.
9908 (encode_coding_gap): Remove; unused.
9909
38dfbee1
PE
9910 * chartab.c (chartab_chars, chartab_bits): Now static.
9911
a2cb4e63
PE
9912 * charset.h (charset_iso_8859_1): Remove decl.
9913 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
9914 Now static.
9915
127198fd
PE
9916 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
9917 * ccl.c (Vccl_program_table): Now static.
9918 (check_ccl_update): Remove; unused.
9919
d85b608f
PE
9920 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
9921 * category.h: ... from here.
9922 * category.c (check_category_table, set_category_set): Now static.
9923
31cd66f3
PE
9924 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
9925 * lisp.h: Remove these decls.
9926
c358e587
PE
9927 * buffer.c (buffer_count): Remove unused var.
9928
e78aecca
PE
9929 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
9930 so that it's not optimized away.
9931 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
9932 * dispextern.h (bidi_dump_cached_states): Remove, since it's
9933 exported only to the debugger.
9934
e192d7d3 9935 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 9936 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 9937
92470028
PE
9938 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
9939 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
9940 was inaccessible from Lisp.
9941 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
9942 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
9943
244ed907
PE
9944 alloc.c: Import and export fewer symbols, and remove unused items.
9945 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
9946 is defined.
9947 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
9948 it's not optimized away by whole-program optimization.
9949 (message_enable_multibyte, free_misc): Remove.
9950 (catchlist, handlerlist, mark_backtrace):
9951 Declare only if BYTE_MARK_STACK.
9952 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
9953 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
9954 (message_enable_multibyte): Remove decl.
9955 (free_misc, interval_free_list, float_block, float_block_index):
9956 (n_float_blocks, float_free_list, cons_block, cons_block_index):
9957 (cons_free_list, last_marked_index):
9958 Now static.
9959 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
9960 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
9961 (mark_backtrace): Define only if BYTE_MARK_STACK.
9962 * xdisp.c (message_enable_multibyte): Now static.
9963
61c2b50e 9964 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
9965 This makes it easier for human readers (and static analyzers)
9966 to see whether these variables are used from other modules.
9967 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
9968 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
9969 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
9970 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
9971 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
9972 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
9973 * xmenu.c, xselect.c:
9974 Declare Q* vars static if they are not used in other modules.
9975 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
9976 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
9977 Remove decls of unexported vars.
9978 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
9979
95c82688
PE
9980 * lisp.h (DEFINE_FUNC): Make sname 'static'.
9981
16a97296
PE
9982 Make Emacs functions such as Fatom 'static' by default.
9983 This makes it easier for human readers (and static analyzers)
9984 to see whether these functions can be called from other modules.
9985 DEFUN now defines a static function. To make the function external
9986 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
9987 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
9988 (Finit_image_library):
16a97296
PE
9989 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
9990 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
9991 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
9992 Remove decls, since these functions are now static.
9993 (Funintern, Fget_internal_run_time): New decls, since these functions
9994 were already external.
95c82688 9995
16a97296
PE
9996 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
9997 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
9998 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
9999 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10000 * keyboard.c, keymap.c, lread.c:
10001 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10002 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10003 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10004 Mark functions with DEFUE instead of DEFUN,
10005 if they are used in other modules.
10006 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10007 decls for now-static functions.
10008 * buffer.h (Fdelete_overlay): Remove decl.
10009 * callproc.c (Fgetenv_internal): Mark as internal.
10010 * composite.c (Fremove_list_of_text_properties): Remove decl.
10011 (Fcomposition_get_gstring): New forward static decl.
10012 * composite.h (Fcomposite_get_gstring): Remove decl.
10013 * dired.c (Ffile_attributes): New forward static decl.
10014 * doc.c (Fdocumntation_property): New forward static decl.
10015 * eval.c (Ffetch_bytecode): New forward static decl.
10016 (Funintern): Remove extern decl; now in .h file where it belongs.
10017 * fileio.c (Fmake_symbolic_link): New forward static decl.
10018 * image.c (Finit_image_library): New forward static decl.
10019 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10020 * intervals.h (Fprevious_property_change):
10021 (Fremove_list_of_text_properties): Remove decls.
10022 * keyboard.c (Fthis_command_keys): Remove decl.
10023 (Fcommand_execute): New forward static decl.
10024 * keymap.c (Flookup_key): New forward static decl.
10025 (Fcopy_keymap): Now static.
10026 * keymap.h (Flookup_key): Remove decl.
10027 * process.c (Fget_process): New forward static decl.
10028 (Fprocess_datagram_address): Mark as internal.
10029 * syntax.c (Fsyntax_table_p): New forward static decl.
10030 (skip_chars): Remove duplicate decl.
10031 * textprop.c (Fprevious_property_change): New forward static decl.
10032 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10033 Now internal.
10034 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10035 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10036
785bbd42
PE
10037 * editfns.c (Fformat): Remove unreachable code.
10038
8b913b57
AS
100392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10040
10041 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10042 change. (Bug#8496)
10043
a6744a35
EZ
100442011-04-13 Eli Zaretskii <eliz@gnu.org>
10045
10046 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10047 when at ZV. (Bug#8487)
10048
e7974947
AS
100492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10050
baad03f0
AS
10051 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10052 (Bug#8437)
10053 * keyboard.c (parse_tool_bar_item): Likewise.
10054 * sound.c (sound_cleanup, alsa_close): Likewise.
10055 * termcap.c (tgetent): Likewise.
10056 * xfns.c (x_default_font_parameter): Likewise.
10057 * xsettings.c (read_and_apply_settings): Likewise.
10058
e7974947
AS
10059 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10060 (overrun_check_free): Protoize.
10061
28272684
PE
100622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10063
10064 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10065 since callers should never pass a negative size.
10066 Change the signature to match that of plain 'read' and 'write'; see
10067 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10068 * lisp.h: Update prototypes of emacs_write and emacs_read.
10069
11997c76
EZ
100702011-04-11 Eli Zaretskii <eliz@gnu.org>
10071
10072 * xdisp.c (redisplay_window): Don't try to determine the character
10073 position of the scroll margin if the window start point w->startp
e896f03c 10074 is outside the buffer's accessible region. (Bug#8468)
11997c76 10075
8a2cbd72
EZ
100762011-04-10 Eli Zaretskii <eliz@gnu.org>
10077
10078 Fix write-region and its subroutines for buffers > 2GB.
10079 * fileio.c (a_write, e_write): Modify declaration of arguments and
10080 local variables to support buffers larger than 2GB.
10081 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10082
10083 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10084 argument, local variables, and return value.
10085
10086 * lisp.h: Update prototypes of emacs_write and emacs_read.
10087
10088 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10089
4073e537 100902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10091
1ebfdcb6
PE
10092 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10093
b2ded58d
PE
10094 Fix more problems found by GCC 4.6.0's static checks.
10095
7d66342c
PE
10096 * xdisp.c (vmessage): Use a better test for character truncation.
10097
bbf47d44
PE
10098 * charset.c (load_charset_map): <, not <=, for optimization,
10099 and to avoid potential problems with integer overflow.
9248994d 10100 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10101 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10102 * editfns.c (Fformat): Likewise.
1e69125e 10103 * syntax.c (skip_chars): Likewise.
3befa583 10104
e3019616
PE
10105 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10106 This also lets GCC 4.6.0 generate slightly better loop code.
10107
becfa255
PE
10108 * callint.c (Fcall_interactively): <, not <=, for optimization.
10109 (Fcall_interactively): Count the number of arguments produced,
10110 not the number of arguments given. This is simpler and lets GCC
10111 4.6.0 generate slightly better code.
10112
dae0cd48
PE
10113 * ftfont.c: Distingish more carefully between FcChar8 and char.
10114 The previous code passed unsigned char * to a functions like
10115 strlen and xstrcasecmp that expect char *, which does not
10116 conform to the C standard.
10117 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10118 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10119 char * when the C standard requires it.
10120
76032d70
PE
10121 * keyboard.c (read_char): Remove unused var.
10122
eb3f1cc8
PE
10123 * eval.c: Port to Windows vsnprintf (Bug#8435).
10124 Include <limits.h>.
10125 (SIZE_MAX): Define if the headers do not.
10126 (verror): Do not give up if vsnprintf returns a negative count.
10127 Instead, grow the buffer. This ports to Windows vsnprintf, which
10128 does not conform to C99. Problem reported by Eli Zaretskii.
10129 Also, simplify the allocation scheme, by avoiding the need for
10130 calling realloc, and removing the ALLOCATED variable.
10131
70476b54
PE
10132 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10133
12020a9e
PE
10134 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10135 But keep the doprint source code for now, as we might revamp it
10136 and use it again (Bug#8435).
ea6c7ae6
PE
10137 * lisp.h (doprnt): Remove.
10138 * Makefile.in (base_obj): Remove doprnt.o.
10139 * deps.mk (doprnt.o): Remove.
10140
5fdb398c
PE
10141 error: Print 32- and 64-bit integers portably (Bug#8435).
10142 Without this change, on typical 64-bit hosts error ("...%d...", N)
10143 was used to print both 32- and 64-bit integers N, which relied on
10144 undefined behavior.
61bdb816 10145 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10146 * lisp.h (error, verror): Mark as printf-like functions.
10147 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10148 Report overflow in size calculations when allocating printf buffer.
10149 Do not truncate output string at its first null byte.
10150 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10151 Truncate the output at a character boundary, since vsnprintf does not
10152 do that.
10153 * charset.c (check_iso_charset_parameter): Convert internal
10154 character to string before calling 'error', since %c now has the
10155 printf meaning.
10156 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10157 overflow when computing char to be passed to 'error'. Do not
10158 pass Lisp_Object to 'error'; pass the integer instead.
10159 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10160 formatted with plain %d.
10161
b189fa66
PE
10162 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10163
bff87ef0
PE
10164 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10165
7e2cac20
PE
10166 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10167
ce4d90b5
PE
10168 * xterm.c (x_catch_errors): Remove duplicate declaration.
10169
266c9547
PE
10170 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10171
79c49ad2
PE
10172 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10173
368f4090
JM
101742011-04-10 Jim Meyering <meyering@redhat.com>
10175
10176 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10177 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10178 return ssize_t not "int", and use size_t as the buffer length.
10179 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10180 * gnutls.h: Update declarations.
10181 * process.c (read_process_output): Use ssize_t, to match.
10182 (send_process): Likewise.
10183
a32d4040
CY
101842011-04-09 Chong Yidong <cyd@stupidchicken.com>
10185
10186 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10187
8546720e 101882011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10189
04f2d78b
CB
10190 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10191 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10192
8546720e
GM
10193 * xterm.c (handle_one_xevent):
10194 * xmenu.c (create_and_show_popup_menu):
10195 * xselect.c (x_decline_selection_request)
10196 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10197
0a2f5c1a 101982011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10199
10200 Fix some uses of `int' instead of EMACS_INT.
10201 * search.c (string_match_1, fast_string_match)
10202 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10203 (scan_buffer, find_next_newline_no_quit)
10204 (find_before_next_newline, search_command, Freplace_match)
10205 (Fmatch_data): Make some `int' variables be EMACS_INT.
10206
10207 * xdisp.c (display_count_lines): 3rd argument and return value now
10208 EMACS_INT. All callers changed.
10209 (pint2hrstr): Last argument is now EMACS_INT.
10210
10211 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10212 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10213 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10214 (decode_coding_utf_16, decode_coding_emacs_mule)
10215 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10216 (decode_coding_ccl, decode_coding_charset)
10217 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10218 (decode_coding_iso_2022, decode_coding_emacs_mule)
10219 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10220 <char_offset, last_offset>: Declare EMACS_INT.
10221 (encode_coding_utf_8, encode_coding_utf_16)
10222 (encode_coding_emacs_mule, encode_invocation_designation)
10223 (encode_designation_at_bol, encode_coding_iso_2022)
10224 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10225 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10226 Declare EMACS_INT.
10227 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10228 (encode_invocation_designation): Last argument P_NCHARS is now
10229 EMACS_INT.
10230 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10231 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10232
10233 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10234 All users changed.
10235
10236 * ccl.c (Fccl_execute_on_string): Declare some variables
10237 EMACS_INT.
10238
8546720e 102392011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10240
10241 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10242
4e19a977
CS
102432011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10244
10245 * process.c (Fformat_network_address): Doc fix.
10246
87302331
R
102472011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10248
ee7683eb 10249 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10250
cbb59342
CY
102512011-04-08 Chong Yidong <cyd@stupidchicken.com>
10252
10253 * keyboard.c (read_char): Call Lisp function help-form-show,
10254 instead of using internal_with_output_to_temp_buffer.
10255 (Qhelp_form_show): New var.
e0d38eeb 10256 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10257
10258 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10259
10260 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10261
e67a13ab
CY
102622011-04-06 Chong Yidong <cyd@stupidchicken.com>
10263
04f2d78b
CB
10264 * process.c (Flist_processes): Remove to Lisp.
10265 (list_processes_1): Delete.
e67a13ab 10266
973f782d
EZ
102672011-04-06 Eli Zaretskii <eliz@gnu.org>
10268
7c106b1e
EZ
10269 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10270
973f782d
EZ
10271 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10272
41cf7d1a 102732011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10274
ca23cc88
PE
10275 Fix more problems found by GCC 4.6.0's static checks.
10276
f390e2d5
PE
10277 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10278
42eea0d0
PE
10279 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10280
b69769da 10281 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10282
f9541e84
PE
10283 * xdisp.c (vmessage): Mark as a printf-like function.
10284
13841b55
PE
10285 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10286
c136c10f
PE
10287 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10288
5e2d4a30
PE
10289 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10290 printf-like functions.
10291 (tiff_load): Add casts to remove these marks before passing them
10292 to system-supplied API.
10293
583f48b9
PE
10294 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10295
b25d760e
PE
10296 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10297 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10298 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10299 directly, rather than having caller test rule sign. This avoids
10300 some unnecessary tests.
10301 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10302 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10303 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10304
bc7b6697 10305 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10306 (xfont_open): Avoid unnecessary tests.
bc7b6697 10307
27ccc379
PE
10308 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10309
dcd5c89a
PE
10310 * composite.h, composite.c (composition_gstring_put_cache):
10311 Use EMACS_INT, not int, for length.
10312
b13a45c6
PE
10313 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10314 breaking out part of COMPOSITION_DECODE_RULE.
10315 (COMPOSITION_DECODE_RULE): Use it.
10316 * composite.c (get_composition_id): Remove unused local vars,
10317 by using the new macro.
10318
1e792e4d
PE
10319 * textprop.c (set_text_properties_1): Change while to do-while,
10320 since the condition is always true at first.
10321
dc6c6455 10322 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10323 (interval_deletion_adjustment): Return unsigned value.
10324 All uses changed.
dc6c6455 10325
aba7731a
PE
10326 * process.c (list_processes_1, create_pty, read_process_output):
10327 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10328 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10329 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10330 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10331 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10332
fdfc4bf3
PE
10333 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10334
fca8fe46 10335 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10336 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10337
06a0259a 10338 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10339 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10340 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10341
e7b9e80f
PE
10342 * print.c (print_error_message): Avoid int overflow.
10343
56201685
PE
10344 * font.c (font_list_entities): Redo for clarity,
10345 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10346
78834453 10347 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10348 (font_score): Avoid potential overflow in diff calculation.
78834453 10349
0bc0b309 10350 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10351 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10352
e610eaca
PE
10353 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10354
b895abce
PE
10355 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10356 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10357 can always succeed if overflow has undefined behavior.
10358
1f1d9321 10359 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10360 (wordify): Omit three unnecessary tests.
1f1d9321 10361
c59478bc
PE
10362 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10363 All callers changed. This avoids the need for an unused var.
10364
79b73827
PE
10365 * casefiddle.c (casify_region): Remove var that is set but not used.
10366
a4db5dfe
PE
10367 * dired.c (file_name_completion): Remove var that is set but not used.
10368
43aae36e
PE
10369 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10370
2a47c44d 10371 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10372 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10373
a37c69bf
PE
10374 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10375 Check for integer overflow on size calculations.
10376
328ab8e7
PE
10377 * buffer.c (Fprevious_overlay_change): Remove var that is set
10378 but not used.
10379
e5a2a5cb
PE
10380 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10381 Remove vars that are set but not used.
8d84a6eb 10382 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10383 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10384
a60e5f68
PE
10385 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10386
f661cb61 10387 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10388 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10389
f0397f5a
PE
10390 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10391 that are set but not used.
10392
8664db06 10393 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10394 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10395
6abdaa4a
PE
10396 * xselect.c (x_get_local_selection, x_handle_property_notify):
10397 Remove vars that are set but not used.
10398
0ce7538d 10399 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10400 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10401
9ae848fc
PE
10402 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10403 Remove var that is set but not used.
0b918413
PE
10404 (scroll_bar_windows_size): Now size_t, not int.
10405 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10406 Check for overflow.
9ae848fc 10407
a5a62657
PE
10408 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10409 (map_tty_color) [!defined MSDOS]: Likewise.
10410
5c5cdd39
PE
10411 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10412
66ebf983
PE
10413 * coding.c: Remove vars that are set but not used.
10414 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10415 All callers changed.
10416 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10417 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10418 (decode_coding_charset): Remove vars that are set but not used.
10419
1be4d761
PE
10420 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10421 that is set but not used.
10422
47553fa8
PE
10423 * print.c (print_object): Remove var that is set but not used.
10424
1f7196bf 10425 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10426 The gnulib version avoids calling malloc in the usual case,
10427 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10428 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10429 * filelock.c (current_lock_owner): Likewise.
10430 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10431 * sysdep.c: Include allocator.h, careadlinkat.h.
10432 (emacs_no_realloc_allocator): New static constant.
10433 (emacs_readlink): New function.
fdb61804
PE
10434 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10435 ../lib/careadlinkat.h.
d1fdcab7 10436
f84c17c7
SM
104372011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10438
10439 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10440 first non-nil return value).
10441
ef3862ad
JD
104422011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10443
10444 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10445 if not defined (Bug#8403).
10446
376a7006
JB
104472011-04-02 Juanma Barranquero <lekktu@gmail.com>
10448
10449 * xdisp.c (display_count_lines): Remove parameter `start',
10450 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10451 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10452 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10453 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10454 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10455 and thereabouts. All callers changed.
10456 (get_per_char_metric): Remove parameter `f', unused since
10457 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10458
6ca3801d
JM
104592011-04-02 Jim Meyering <meyering@redhat.com>
10460
10461 do not dereference NULL upon failed strdup
10462 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10463 (ns_get_family): Likewise.
10464
d8e2b5ba
JB
104652011-04-02 Juanma Barranquero <lekktu@gmail.com>
10466
10467 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10468
8c74fcbd
JD
104692011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10470
10471 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10472 later (Bug#8403).
10473
7200d79c
SM
104742011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10475
03408648 10476 Add lexical binding.
7200d79c 10477
03408648
SM
10478 * window.c (Ftemp_output_buffer_show): New fun.
10479 (Fsave_window_excursion):
10480 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10481
10482 * lread.c (lisp_file_lexically_bound_p): New function.
10483 (Fload): Bind Qlexical_binding.
10484 (readevalloop): Remove `evalfun' arg.
10485 Bind Qinternal_interpreter_environment.
10486 (Feval_buffer): Bind Qlexical_binding.
10487 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10488 Mark as dynamic.
10489 (syms_of_lread): Declare `lexical-binding'.
10490
10491 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10492
10493 * keyboard.c (eval_dyn): New fun.
10494 (menu_item_eval_property): Use it.
ca105506
SM
10495
10496 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10497
03408648
SM
10498 * fns.c (concat, mapcar1): Accept byte-code-functions.
10499
10500 * eval.c (Fsetq): Handle lexical vars.
10501 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10502 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10503 (FletX, Flet): Obey lexical binding.
10504 (Fcommandp): Handle closures.
10505 (Feval): New `lexical' arg.
10506 (eval_sub): New function extracted from Feval. Use it almost
10507 everywhere where Feval was used. Look up vars in lexical env.
10508 Handle closures.
10509 (Ffunctionp): Move from subr.el.
10510 (Ffuncall): Handle closures.
10511 (apply_lambda): Remove `eval_flags'.
10512 (funcall_lambda): Handle closures and new byte-code-functions.
10513 (Fspecial_variable_p): New function.
10514 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10515 but without exporting it to Lisp.
23aba0ea 10516
23aba0ea 10517 * doc.c (Fdocumentation, store_function_docstring):
03408648 10518 * data.c (Finteractive_form): Handle closures.
23aba0ea 10519
03408648
SM
10520 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10521 interactive spec.
ba83908c 10522
04f2d78b
CB
10523 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10524 New byte-codes.
03408648
SM
10525 (exec_byte_code): New function extracted from Fbyte_code to handle new
10526 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10527
03408648 10528 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10529
03408648 10530 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10531
e2abce01
JB
105322011-03-31 Juanma Barranquero <lekktu@gmail.com>
10533
10534 * xdisp.c (redisplay_internal): Fix prototype.
10535
63696a73 105362011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10537
63696a73 10538 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10539 (try_scrolling): Use it when setting scroll_limit.
10540 Limit scrolling to 100 screen lines.
63696a73
EZ
10541 (redisplay_window): Even when falling back on "recentering",
10542 position point in the window according to scroll-conservatively,
10543 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10544
10545 (try_scrolling): When point is above the window, allow searching
10546 as far as scroll_max, or one screenful, to compute vertical
10547 distance from PT to the scroll margin position. This prevents
10548 try_scrolling from unnecessarily failing when
10549 scroll-conservatively is set to a value slightly larger than the
10550 window height. Clean up the case of PT below the margin at bottom
10551 of window: scroll_max can no longer be INT_MAX. When aggressive
10552 scrolling is in use, don't let point enter the opposite scroll
10553 margin as result of the scroll.
10554 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10555 threshold of 100 lines for never-recentering scrolling.
10556
e4cc2dfc
JB
105572011-03-31 Juanma Barranquero <lekktu@gmail.com>
10558
10559 * dispextern.h (move_it_by_lines):
10560 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10561 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10562 (message_log_check_duplicate): Remove parameters `prev_bol' and
10563 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10564 (redisplay_internal): Remove parameter `preserve_echo_area',
10565 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10566
10567 * indent.c (Fvertical_motion):
10568 * window.c (window_scroll_pixel_based, Frecenter):
10569 Don't pass `need_y_p' to `move_it_by_lines'.
10570
1c470562
SM
105712011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10572
44f230aa
SM
10573 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10574 steal a few bits to be more compact.
10575 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10576 Remove unneeded casts.
10577
1c470562
SM
10578 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10579
888adce9
ZK
105802011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10581
10582 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10583 binding" message (bug#7967).
10584
f838ed7b
PE
105852011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10586
77861b95
PE
10587 Fix more problems found by GCC 4.6.0's static checks.
10588
de6dbc14
PE
10589 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10590 Remove unused local var.
10591
f838ed7b
PE
10592 * editfns.c (Fmessage_box): Remove unused local var.
10593
792c7b2b
PE
10594 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10595 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10596 Omit unused local vars.
c499e557 10597 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10598 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10599 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10600 Omit unused local var.
10601
ba0165e1
PE
10602 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10603 Don't assume string length fits in int.
32ad8845 10604 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10605 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10606
3c59b4c9
PE
10607 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10608 instead of alloca (Bug#8344).
10609
a3eed478 10610 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10611 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10612
eb4d412d
PE
10613 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10614
1658b401
PE
10615 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10616 concerns.
10617
10618 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10619
10620 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10621
9a2c6e05
PE
10622 * keyboard.c (syms_of_keyboard): Use the same style as later
10623 in this function when indexing through an array. This also
10624 works around GCC bug 48267.
10625
03d0a109
PE
10626 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10627
44f730c8
PE
10628 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10629
fe75f926
PE
10630 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10631 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10632
ffa8c828
PE
10633 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10634 This avoids undefined behavior on integer overflow, and is a bit
10635 more convenient anyway since it is compared to a size_t variable.
10636
c5101a77
PE
10637 Variadic C functions now count arguments with size_t, not int.
10638 This avoids an unnecessary limitation on 64-bit machines, which
10639 caused (substring ...) to crash on large vectors (Bug#8344).
10640 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10641 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10642 All variadic functions and their callers changed accordingly.
c5101a77
PE
10643 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10644 * data.c (arith_driver, float_arith_driver): Likewise.
10645 * editfns.c (general_insert_function): Likewise.
10646 * eval.c (struct backtrace.nargs, interactive_p)
10647 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10648 (funcall_lambda, mark_backtrace): Likewise.
10649 * fns.c (concat): Likewise.
10650 * frame.c (x_set_frame_parameters): Likewise.
10651 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10652 0 if not found, not -1. All callers changed.
10653
dd3f25f7
PE
10654 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10655 (stack_copy_size): Now size_t, not int.
10656 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10657
461c2ab9
JB
106582011-03-28 Juanma Barranquero <lekktu@gmail.com>
10659
10660 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10661 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10662 All callers changed.
10663
10664 * lisp.h (multibyte_char_to_unibyte):
10665 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10666 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10667 * character.h (CHAR_TO_BYTE8):
10668 * cmds.c (internal_self_insert):
10669 * editfns.c (general_insert_function):
10670 * keymap.c (push_key_description):
10671 * search.c (Freplace_match):
10672 * xdisp.c (message_dolog, set_message_1): All callers changed.
10673
f6d62986
SM
106742011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10675
10676 * keyboard.c (safe_run_hook_funcall): New function.
10677 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10678 don't set the hook to nil, but remove the offending function instead.
10679 (Qcommand_hook_internal): Remove, unused.
10680 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10681 Vcommand_hook_internal.
10682
10683 * eval.c (enum run_hooks_condition): Remove.
10684 (funcall_nil, funcall_not): New functions.
10685 (run_hook_with_args): Call each function through a `funcall' argument.
10686 Remove `cond' argument, now redundant.
10687 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10688 (Frun_hook_with_args_until_failure): Adjust accordingly.
10689 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10690
1db5b1ad
JB
106912011-03-28 Juanma Barranquero <lekktu@gmail.com>
10692
10693 * dispextern.h (string_buffer_position): Remove declaration.
10694
10695 * print.c (strout): Remove parameter `multibyte', unused since
10696 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10697
10698 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10699 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10700 All callers changed.
10701
10702 * w32.c (_wsa_errlist): Use braces for struct initializers.
10703
10704 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10705 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10706 All callers changed.
10707 (string_buffer_position): Likewise. Also, make static (it's never
10708 used outside xdisp.c).
10709 (cursor_row_p): Remove parameter `w', unused since
10710 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10711 (decode_mode_spec): Remove parameter `precision', introduced during
10712 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10713 All callers changed.
10714
5ffb62aa
JD
107152011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10716
10717 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10718
461c2ab9 107192011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10720
10721 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10722 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10723 (ns_update_auto_hide_menu_bar): New functions.
10724 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10725 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10726 ns_constrain_all_frames.
10727 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10728 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10729
5c380ffb
JD
107302011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10731
10732 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10733
9af30bdf
GM
107342011-03-27 Glenn Morris <rgm@gnu.org>
10735
10736 * syssignal.h: Replace RETSIGTYPE with void.
10737 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10738 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10739 Replace SIGTYPE with void everywhere.
10740 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10741 * s/template.h (SIGTYPE): Remove commented out definition.
10742
e2abce01
JB
107432011-03-26 Eli Zaretskii <eliz@gnu.org>
10744
10745 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10746 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10747
f868cd8a
JB
107482011-03-26 Juanma Barranquero <lekktu@gmail.com>
10749
59eb0929
JB
10750 * w32.c (read_unc_volume): Use parameter `henum', instead of
10751 global variable `wget_enum_handle'.
10752
10753 * keymap.c (describe_vector): Remove parameters `indices' and
10754 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10755 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10756
f868cd8a
JB
10757 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10758
10759 * keyboard.c (timer_check): Remove parameter `do_it_now',
10760 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10761 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10762 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10763
10764 * keyboard.c (read_char):
10765 * w32menu.c (w32_menu_display_help):
10766 * xmenu.c (show_help_event, menu_help_callback):
10767 Adjust calls to `show_help_echo'.
10768
10769 * gtkutil.c (xg_maybe_add_timer):
10770 * keyboard.c (readable_events):
10771 * process.c (wait_reading_process_output):
10772 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10773
10774 * insdel.c (adjust_markers_gap_motion):
10775 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10776 (gap_left, gap_right): Don't call it.
10777
2ecf6fdb
CY
107782011-03-25 Chong Yidong <cyd@stupidchicken.com>
10779
10780 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10781 incurred during fontification.
10782
6b1f9ba4
JB
107832011-03-25 Juanma Barranquero <lekktu@gmail.com>
10784
10785 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10786 (DEFVAR_PER_BUFFER): Don't pass it.
10787
10788 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10789 (scrolling_window): Don't pass it.
10790
0f4a96b5
JB
107912011-03-25 Juanma Barranquero <lekktu@gmail.com>
10792
10793 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10794
10795 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10796 and `suffix'.
10797 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10798 of variables specific to SELinux and computation of `encoded_absname'.
10799
10800 * image.c (XPutPixel): Remove unused variable `height'.
10801
10802 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10803
10804 * unexw32.c (get_section_info): Remove unused variable `section'.
10805
10806 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10807 (system_process_attributes): Remove unused variable `sess'.
10808 (sys_read): Remove unused variable `err'.
10809
10810 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10811 (w32_wnd_proc): Remove unused variable `isdead'.
10812 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10813 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10814 (x_create_tip_frame): Remove unused variable `tem'.
10815
10816 * w32inevt.c (w32_console_read_socket):
10817 Remove unused variable `no_events'.
10818
10819 * w32term.c (x_draw_composite_glyph_string_foreground):
10820 Remove unused variable `width'.
10821
1149507c
JB
108222011-03-24 Juanma Barranquero <lekktu@gmail.com>
10823
10824 * w32term.c (x_set_glyph_string_clipping):
10825 Don't pass uninitialized region to CombineRgn.
10826
9c88f339
JB
108272011-03-23 Juanma Barranquero <lekktu@gmail.com>
10828
10829 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10830 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10831 (Fx_close_connection): Remove unused variable `i'.
10832
10833 * w32font.c (w32font_draw): Return number of glyphs.
10834 (w32font_open_internal): Remove unused variable `i'.
10835 (w32font_driver): Add missing initializer.
10836
10837 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10838 (fill_in_menu): Remove unused variable `items_added'.
10839
10840 * w32term.c (last_mouse_press_frame): Remove static global variable.
10841 (w32_clip_to_row): Remove unused variable `f'.
10842 (x_delete_terminal): Remove unused variable `i'.
10843
10844 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10845 (NOTHING): Remove unused static global variable.
10846 (uniscribe_check_otf): Remove unused variable `table'.
10847 (uniscribe_font_driver): Add missing initializers.
10848
dee091a3
JD
108492011-03-23 Julien Danjou <julien@danjou.info>
10850
10851 * term.c (Fsuspend_tty, Fresume_tty):
10852 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10853 * window.c (temp_output_buffer_show):
10854 * insdel.c (signal_before_change):
10855 * frame.c (Fhandle_switch_frame):
10856 * fileio.c (Fdo_auto_save):
10857 * emacs.c (Fkill_emacs):
10858 * editfns.c (save_excursion_restore):
10859 * cmds.c (internal_self_insert):
10860 * callint.c (Fcall_interactively):
10861 * buffer.c (Fkill_all_local_variables):
10862 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10863 Use Frun_hooks.
0f4a96b5 10864 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10865 unconditionally since it does the check itself.
dee091a3 10866
2c520ab5 108672011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10868
c9c49752
PE
10869 Fix more problems found by GCC 4.5.2's static checks.
10870
8abc3f12
PE
10871 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10872 the first time through the loop, since we know p0 < p1 then.
10873 This also avoids a gcc -Wstrict-overflow warning.
10874
a2d26660
PE
10875 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10876 leading to a memory leak, possible in functions like
10877 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10878 of objects (Bug#8318).
a2d26660 10879
916c72e9
PE
10880 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10881 that could (at least in theory) be that large.
10882
19ab8a18
PE
10883 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10884 This is less likely to overflow, and avoids undefined behavior if
10885 overflow does occur. All callers changed. Use strtoul to scan
10886 for the unsigned long integer.
b7cbbd6f
PE
10887 (pint2hrstr): Simplify and tune code slightly.
10888 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10889
f0641eff
PE
10890 * scroll.c (do_scrolling): Work around GCC bug 48228.
10891 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10892
7f650bb9
PE
10893 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10894 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10895 (validate_x_resource_name): Simplify count usage.
10896 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10897
37dd57d1
PE
10898 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10899 fail (Bug#8306).
81e56e61 10900
699979fc 10901 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10902
401bf9b4
PE
10903 * process.c (Fmake_network_process): Use socklen_t, not int,
10904 where POSIX says socklen_t is required in portable programs.
10905 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 10906 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
10907 (Fmake_network_process, server_accept_connection):
10908 (wait_reading_process_output, read_process_output):
10909 Likewise.
10910
b93aacde
PE
10911 * process.c: Rename or move locals to avoid shadowing.
10912 (list_processes_1, Fmake_network_process):
10913 (read_process_output_error_handler, exec_sentinel_error_handler):
10914 Rename or move locals.
4dc343ee 10915 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 10916 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 10917 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 10918 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 10919 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 10920
af8a867c 10921 Make tparam.h and terminfo.c consistent.
44f230aa
SM
10922 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
10923 Include tparam.h instead, since it declares them.
af8a867c
PE
10924 * cm.h (PC): Remove extern decl; tparam.h now does this.
10925 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
10926 * terminfo.c: Include tparam.h, to check interfaces.
10927 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
10928 (tparam): Adjust signature to match interface in tparam.h;
10929 this removes some undefined behavior. Check that outstring and len
10930 are zero, which they always are with Emacs.
10931 * tparam.h (PC, BC, UP): New extern decls.
10932
0248044d 10933 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 10934 (xftfont_open): Rename locals to avoid shadowing.
0248044d 10935
8ff096c1 10936 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
10937 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
10938 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 10939 (ftfont_list): Remove unused local.
49eaafba
PE
10940 (get_adstyle_property, ftfont_pattern_entity):
10941 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
10942 Rename locals to avoid shadowing.
8ff096c1 10943
e2be39f6
PE
10944 * xfont.c (xfont_list_family): Mark var as initialized.
10945
c9735e30
PE
10946 * xml.c (make_dom): Now static.
10947
8f5201ae
PE
10948 * composite.c (composition_compute_stop_pos): Rename local to
10949 avoid shadowing.
b246f932
PE
10950 (composition_reseat_it): Remove unused locals.
10951 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 10952 (composition_update_it): Mark var as initialized.
11b61122
PE
10953 (find_automatic_composition): Mark vars as initialized,
10954 with a FIXME (Bug#8290).
8f5201ae 10955
760fbc2c
PE
10956 character.h: Rename locals to avoid shadowing.
10957 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
10958 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
10959 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
10960 (BUF_DEC_POS): Be more systematic about renaming local temporaries
10961 to avoid shadowing.
10962
ff08eb85
PE
10963 * textprop.c (property_change_between_p): Remove; unused.
10964
fc7bf025
PE
10965 * intervals.c (interval_start_pos): Now static.
10966
235d7abc
PE
10967 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
10968
44f230aa
SM
10969 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
10970 Rename locals to avoid shadowing.
3e7d6594 10971
50060332
PE
10972 * sound.c (wav_play, au_play, Fplay_sound_internal):
10973 Fix pointer signedness.
d01f234b 10974 (alsa_choose_format): Remove unused local var.
c83b8872
PE
10975 (wav_play): Initialize a variable to 0, to prevent undefined
10976 behavior (Bug#8278).
50060332 10977
c4fc4e30
PE
10978 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
10979
918436ed
PE
10980 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
10981
c939f91b
PE
10982 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
10983 clobbering (Bug#8298).
b9c7f648
PE
10984 * sysdep.c (sys_subshell): Likewise.
10985 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 10986
6bd8c144
PE
10987 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
10988 This should get cleaned up, so that child_setup has the
10989 same signature on all platforms.
10990
7710357c 10991 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 10992 (relocate_fd): Rename locals to avoid shadowing.
7710357c 10993
c59da222
CY
109942011-03-22 Chong Yidong <cyd@stupidchicken.com>
10995
10996 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
10997 not to be necessary, and produces flickering.
10998
66b87493
GM
109992011-03-20 Glenn Morris <rgm@gnu.org>
11000
11001 * config.in: Remove file.
11002
45b6f6d5
JB
110032011-03-20 Juanma Barranquero <lekktu@gmail.com>
11004
11005 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11006 are now in src/globals.h.
11007 (syms_of_minibuf): Remove spurious & from previous change.
11008
cd394be1 110092011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11010
11011 * minibuf.c (completing-read-function): New variable.
11012 (completing-read-default): Rename from completing-read.
11013 (completing-read): Call completing-read-function.
11014
b14e3e21
CY
110152011-03-19 Juanma Barranquero <lekktu@gmail.com>
11016
11017 * xfaces.c (Fx_load_color_file):
11018 Read color file from absolute filename (bug#8250).
11019
f2b726e6
JB
110202011-03-19 Juanma Barranquero <lekktu@gmail.com>
11021
11022 * makefile.w32-in: Update dependencies.
11023
09f6ff02
EZ
110242011-03-17 Eli Zaretskii <eliz@gnu.org>
11025
11026 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11027
29a6015a
PE
110282011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11029
a3a6c54e
PE
11030 Fix more problems found by GCC 4.5.2's static checks.
11031
b766f867
PE
11032 * process.c (make_serial_process_unwind, send_process_trap):
11033 (sigchld_handler): Now static.
11034
be02381c
PE
11035 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11036 That way, the code declares only the vars that it needs.
11037 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11038 * s/cygwin.h (PTY_ITERATION): Likewise.
11039 * s/darwin.h (PTY_ITERATION): Likewise.
11040 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11041
57048744
PE
11042 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11043 * process.c (allocate_pty): Don't declare stb unless it's needed.
11044
7914961c 11045 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11046 (CONSTANTLIM): Remove; unused.
11047 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11048 Define only if needed.
7914961c 11049
b3967b18
PE
11050 * unexelf.c (unexec): Name an expression,
11051 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11052 Use a different way to cause a compilation error if anyone uses
11053 n rather than nn, a way that does not involve shadowing.
73366a00 11054 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11055
29a6015a
PE
11056 * deps.mk (unexalpha.o): Remove; unused.
11057
43cfc33e 11058 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11059 * unexec.h: New file.
ce701a33
PE
11060 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11061 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11062 Depend on unexec.h.
11063 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11064 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11065 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11066 Change as necessary to match prototype in unexec.h.
ce701a33 11067
01f44d5a
PE
11068 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11069 shadowing.
4f63c6bb 11070 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11071
a6670b0b
PE
11072 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11073 Rename locals to avoid shadowing.
11074
cef2010d 11075 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11076 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11077
d4d7173a
PE
11078 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11079
f08b802a
PE
11080 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11081 warning when compiling print.c.
11082
3ddb0639
PE
11083 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11084 instead of using an uninitialized var.
5ad03b97 11085 (font_sort_entities): Mark var as initialized.
3ddb0639 11086
170a2692
PE
11087 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11088
e663c700
PE
11089 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11090 pointers to constants.
89bc529a 11091 (font_parse_fcname): Remove unused vars.
7b81e2d0 11092 (font_delete_unmatched): Now static.
ea838e10 11093 (font_get_spec): Remove; unused.
13a547c6
PE
11094 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11095 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11096 Rename or move locals to avoid shadowing.
e663c700 11097
2a80c887 11098 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11099 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11100
1384fa33 11101 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11102 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11103
8b2c52e9
PE
11104 * alloc.c (mark_backtrace): Move decl from here ...
11105 * lisp.h: ... to here, so that it can be checked.
11106
475545b5 11107 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11108 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11109 (lisp_indirect_variable): Name an expression,
11110 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11111 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11112
b1349114 11113 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11114 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11115 Use const pointer when appropriate.
b1349114 11116
a2928364
PE
11117 * lisp.h (get_system_name, get_operating_system_release):
11118 Move decls here, to check interfaces.
11119 * process.c (get_operating_system_release): Move decl to lisp.h.
11120 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11121 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11122 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11123 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11124 (Fformat_time_string, Fencode_time, Finsert_char):
11125 (Ftranslate_region_internal, Fformat):
11126 Rename or remove local vars to avoid shadowing.
9710023e 11127 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11128
a415e694
PE
11129 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11130 avoid shadowing.
11131
8ef4622d
PE
11132 * lisp.h (eassert): Check that the argument compiles, even if
11133 ENABLE_CHECKING is not defined.
11134
946f9a5b
PE
11135 * data.c (Findirect_variable): Name an expression, to avoid
11136 gcc -Wbad-function-cast warning.
112396d6 11137 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11138 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11139 (Fmake_variable_buffer_local, Fmake_local_variable):
11140 Mark variables as initialized.
52746918 11141 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11142
e5aab7e7 11143 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11144 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11145 Rename locals to avoid shadowing.
dff45157
PE
11146 (mark_stack): Move local variables into the #ifdef region where
11147 they're used.
7bc26fdb
PE
11148 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11149 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11150 needed otherwise.
11151 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11152 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11153 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11154
e5aab7e7
PE
11155 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11156 avoids undefined behavior in theory.
11157
4da60324
PE
11158 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11159
88043301
PE
11160 Use functions, not macros, for up- and down-casing (Bug#8254).
11161 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11162 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11163 to use the following functions instead of these macros.
11164 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11165 EMACS_INT, since callers assume the returned value fits in int.
11166 (upcase1): Likewise, for UPCASE_TABLE.
11167 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11168 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11169 the race-condition problem in the old DOWNCASE.
88043301 11170
19ed5445
PE
11171 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11172 Rename locals to avoid shadowing.
11173 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11174 (regex_compile, re_search_2, re_match_2_internal):
11175 Remove unused local vars.
952db0d7
PE
11176 (FREE_VAR): Rewrite so as not to use empty "else",
11177 which gcc can warn about.
da053e48 11178 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11179 (RETALLOC_IF): Define only if needed.
11180 (WORDCHAR_P): Likewise. This one is never needed, but is used
11181 only in a comment talking about a compiler bug, so put inside
11182 the #if 0 of that comment.
11183 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11184 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11185 Remove; unused.
19ed5445 11186
1f3561e4 11187 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11188 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11189 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11190
ded6f8f7
PE
11191 * search.c (simple_search): Remove unused var.
11192
dbd37a95
PE
11193 * dired.c (compile_pattern): Move decl from here ...
11194 * lisp.h: ... to here, so that it can be checked.
11195 (struct re_registers): New forward decl.
11196
7e47afad
PE
11197 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11198
85f24f61
PE
11199 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11200 All uses changed.
11201 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11202 Rename locals to avoid shadowing.
5671df8f 11203 (Fvertical_motion): Mark locals as initialized.
85f24f61 11204
181aa2be 11205 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11206 (casify_region): Mark local as initialized.
181aa2be 11207
930d429c
PE
11208 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11209
7082eac6
PE
11210 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11211 New macros, so that the caller can use some names other than
11212 gcpro1, gcpro2, etc.
11213 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11214 of the new macros.
11215 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11216 argument, for consistency with GCPRO2_VAR, etc: it is now the
11217 prefix of the variable, not the variable itself. All uses
11218 changed.
38b2c076
PE
11219 * dired.c (directory_files_internal, file_name_completion):
11220 Rename locals to avoid shadowing.
11221
15206ed9
PE
11222 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11223 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11224 dired.c's scmp function, had undefined behavior.
11225 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11226 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11227 * buffer.h: ... to here, because these macros use current_buffer,
11228 and the new implementation with inline functions needs to have
11229 current_buffer in scope now, rather than later when the macros
11230 are used.
11231 (downcase, upcase1): New static inline functions.
11232 (DOWNCASE, UPCASE1): Reimplement using these functions.
11233 This avoids undefined behavior in expressions like
11234 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11235 from race conditions in accessing the global variables
11236 case_temp1 and case_temp2.
11237 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11238 * lisp.h (case_temp1, case_temp2): Remove their decls.
11239 * character.h (ASCII_CHAR_P): Move from here ...
11240 * lisp.h: ... to here, so that the inline functions mentioned
11241 above can use them.
11242
4a6bea26
PE
11243 * dired.c (directory_files_internal_unwind): Now static.
11244
f14b7e14
PE
11245 * fileio.c (file_name_as_directory, directory_file_name):
11246 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11247 Now static.
2893f146
PE
11248 (file_name_as_directory): Use const pointers when appropriate.
11249 (Fexpand_file_name): Likewise. In particular, newdir might
11250 point at constant storage, so make it a const pointer.
fd4ead52 11251 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11252 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11253 signedness issues.
f839df0c
PE
11254 (Fset_file_times, Finsert_file_contents, auto_save_error):
11255 Rename locals to avoid shadowing.
f14b7e14 11256
5716756e 11257 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11258 (Ftry_completion, Fall_completions): Rename or remove locals
11259 to avoid shadowing.
5716756e 11260
b4c3046a
PE
11261 * marker.c (bytepos_to_charpos): Remove; unused.
11262
b45db522
PE
11263 * lisp.h (verify_bytepos, count_markers): New decls,
11264 so that gcc does not warn that these functions aren't declared.
11265
85876d07
PE
11266 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11267 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11268 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11269 (copy_text): Remove unused local var.
85876d07 11270
03d78a21 11271 * filelock.c (within_one_second): Now static.
b3dd38ab 11272 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11273
5df8f01b
PE
11274 * buffer.c (fix_overlays_before): Mark locals as initialized.
11275 (fix_start_end_in_overlays): Likewise. This function should be
11276 simplified by using pointers-to-pointers, but that's a different
11277 matter.
b1d876f1 11278 (switch_to_buffer_1): Now static.
8f54f30a
PE
11279 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11280 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11281
a70072c9 11282 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11283 Fix pointer signedness issue.
edced198
PE
11284 (sys_subshell): Mark local as volatile if checking for lint,
11285 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11286 (MAXPATHLEN): Define only if needed.
a70072c9 11287
a0977c44
PE
11288 * process.c (serial_open, serial_configure): Move decls from here ...
11289 * systty.h: ... to here, so that they can be checked.
11290
a884fdcc
PE
11291 * fns.c (get_random, seed_random): Move extern decls from here ...
11292 * lisp.h: ... to here, so that they can be checked.
11293
604efe86 11294 * sysdep.c (reset_io): Now static.
b8950c94 11295 (wait_for_termination_signal): Remove; unused.
604efe86 11296
38fc62d9
PE
11297 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11298 (copy_keymap_item, append_key, push_text_char_description):
11299 Now static.
1004a21a 11300 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11301 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11302 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11303 (describe_map_tree):
11304 Rename locals to avoid shadowing.
38fc62d9 11305
2f2650da
PE
11306 * keyboard.c: Declare functions static if they are not used elsewhere.
11307 (echo_char, echo_dash, cmd_error, top_level_2):
11308 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11309 (read_char, kbd_buffer_get_event, make_lispy_position):
11310 (make_lispy_event, make_lispy_movement, apply_modifiers):
11311 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11312 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11313 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11314 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11315 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11316
a053e86c 11317 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11318 (mark_kboards): Move decl here ...
11319 * alloc.c (mark_kboards): ... from here.
a053e86c 11320
4752793e
PE
11321 * lisp.h (force_auto_save_soon): New decl.
11322
74f10ca7 11323 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11324 (DEFINE_DUMMY_FUNCTION): New macro.
11325 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11326 Use it.
c03cd23f
PE
11327 (main): Add casts to avoid warnings
11328 if GCC considers string literals to be constants.
74f10ca7 11329
022e70d4
PE
11330 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11331
59d6fe83
PE
11332 * dbusbind.c: Pointer signedness fixes.
11333 (xd_signature, xd_append_arg, xd_initialize):
11334 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11335 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11336 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11337 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11338
78320123
PE
11339 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11340 if GCC considers string literals to be constants.
49cebcca 11341 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11342
35ac2a97
SM
113432011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11344
fb103ca9
SM
11345 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11346 (print_preprocess, print_object): New macro to fix last change.
11347
35ac2a97
SM
11348 * print.c (print_preprocess): Don't forget font objects.
11349
62973b41
JB
113502011-03-16 Juanma Barranquero <lekktu@gmail.com>
11351
11352 * emacs.c (USAGE3): Doc fixes.
11353
0e48bb22
AS
113542011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11355
11356 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11357 structure.
11358
7684e57b
JB
113592011-03-14 Juanma Barranquero <lekktu@gmail.com>
11360
11361 * lisp.h (VWindow_system, Qfile_name_history):
11362 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11363 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11364 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11365
11366 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11367 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11368
11369 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11370 * w32console.c (detect_input_pending, read_input_pending)
11371 (encode_terminal_code):
11372 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11373 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11374 (w32_system_caret_y, Qfile_name_history):
11375 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11376 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11377 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11378 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11379 * w32proc.c (Qlocal, report_file_error):
11380 * w32term.c (Vwindow_system, updating_frame):
11381 * w32uniscribe.c (initialized, uniscribe_font_driver):
11382 Remove unneeded extern declarations.
11383
2aa46d6c
CY
113842011-03-14 Chong Yidong <cyd@stupidchicken.com>
11385
c96bbc66 11386 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11387
cffc6f3b
CY
113882011-03-13 Chong Yidong <cyd@stupidchicken.com>
11389
11390 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11391 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11392 These macros can no longer be used for assignment.
11393
44f230aa
SM
11394 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11395 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11396 (record_buffer_markers, fetch_buffer_markers): New functions for
11397 recording and fetching special buffer markers.
11398 (set_buffer_internal_1, set_buffer_temp): Use them.
11399
11400 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11401
11402 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11403
11404 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11405 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11406
11407 * xdisp.c (hscroll_window_tree):
11408 (reconsider_clip_changes): Use PT instead of BUF_PT.
11409
d251f04b
EZ
114102011-03-13 Eli Zaretskii <eliz@gnu.org>
11411
11412 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11413 $(EMACS_ROOT)/lib/intprops.h.
11414
f0c77cd1
PE
114152011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11416
3eca4629
PE
11417 Fix more problems found by GCC 4.5.2's static checks.
11418
7c86ee98
PE
11419 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11420 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11421 (xg_free_frame_widgets): Make it clear that a local variable is
11422 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11423 (gdk_window_get_screen): Make it clear that this macro is needed
11424 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11425 (int_gtk_range_get_value): New function, which avoids a diagnostic
11426 from gcc -Wbad-function-cast.
11427 (xg_set_toolkit_scroll_bar_thumb): Use it.
11428 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11429 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11430 (get_utf8_string, xg_get_file_with_chooser):
11431 Rename locals to avoid shadowing.
11432 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11433
41729b81
PE
11434 * xgselect.c (xg_select): Remove unused var.
11435
f0c77cd1
PE
11436 * image.c (four_corners_best): Mark locals as initialized.
11437 (gif_load): Initialize transparent_p to zero (Bug#8238).
11438 Mark another local as initialized.
ec6cf4c6 11439 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11440
ce0ad53d 11441 * image.c (clear_image_cache): Now static.
d5d5a617 11442 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11443 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11444 (x_edge_detection): Remove unnecessary cast that
11445 gcc -Wbad-function-cast diagnoses.
2037898d 11446 (gif_load): Fix pointer signedness.
6ae141d6
PE
11447 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11448 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11449
33383987 114502011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11451
d32df629
PE
11452 Improve quality of tests for time stamp overflow.
11453 For example, without this patch (encode-time 0 0 0 1 1
11454 1152921504606846976) returns the obviously-bogus value (-948597
11455 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11456 reports time overflow. See
11457 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11458 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11459 * editfns.c: Include limits.h and intprops.h.
11460 (TIME_T_MIN, TIME_T_MAX): New macros.
11461 (time_overflow): Move earlier, to before first use.
11462 (hi_time, lo_time): New functions, for an accurate test for
11463 out-of-range times.
11464 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11465 (Fget_internal_run_time): Don't assume time_t fits in int.
11466 (make_time): Use list2 instead of Fcons twice.
11467 (Fdecode_time): More accurate test for out-of-range times.
11468 (check_tm_member): New function.
11469 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11470 (lisp_time_argument): Don't rely on undefined left-shift and
11471 right-shift behavior when checking for time stamp overflow.
8be6f318 11472
fe31d94c
PE
11473 * editfns.c (time_overflow): New function, refactoring common code.
11474 (Fformat_time_string, Fdecode_time, Fencode_time):
11475 (Fcurrent_time_string): Use it.
11476
8be6f318
PE
11477 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11478 * dired.c (make_time): Move to ...
11479 * editfns.c (make_time): ... here.
11480 * systime.h: Note the move.
11481
09d9db2c 114822011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11483
126bc0dc
YM
11484 * fringe.c (update_window_fringes): Remove unused variables.
11485
c47cbdfd
YM
11486 * unexmacosx.c (copy_data_segment): Also copy __got section.
11487 (Bug#8223)
11488
7ac80be9
EZ
114892011-03-12 Eli Zaretskii <eliz@gnu.org>
11490
c96bbc66 11491 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11492 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11493 Constify `char *' arguments and their references according to
11494 prototypes in tparam.h.
11495
ecb0f94d 11496 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11497
7ac80be9
EZ
11498 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11499 Adapt all references accordingly.
11500
11501 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11502
ef1fd07e
TT
115032011-03-11 Tom Tromey <tromey@redhat.com>
11504
11505 * buffer.c (syms_of_buffer): Remove obsolete comment.
11506
7ef4b50c
EZ
115072011-03-11 Eli Zaretskii <eliz@gnu.org>
11508
11509 * termhooks.h (encode_terminal_code): Declare prototype.
11510
11511 * msdos.c (encode_terminal_code): Don't declare prototype.
11512
11513 * term.c (encode_terminal_code): Now external again, used by
11514 w32console.c and msdos.c.
11515
44f230aa
SM
11516 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11517 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11518
4b1ec863 115192011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11520
1714f52b 11521 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11522
4b1ec863
PE
11523 * fringe.c (update_window_fringes): Mark locals as initialized
11524 (Bug#8227).
11525 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11526
524c7aa6
PE
11527 * alloc.c (mark_fringe_data): Move decl from here ...
11528 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11529 to check its interface.
11530 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11531
a5c0af81 11532 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11533 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11534 (fontset_font): Mark local as initialized.
a9a06e0b 11535 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11536
b4716021
PE
11537 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11538
811e9bac 11539 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11540 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11541 (x_own_selection, Fx_disown_selection_internal): Rename locals
11542 to avoid shadowing.
11543 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11544
7e3ab302
PE
11545 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11546 so that the caller can use some name other than gcpro1.
11547 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11548 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11549 (Fx_backspace_delete_keys_p):
11550 Use them to avoid shadowing, and rename vars to avoid shadowing.
11551 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11552 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11553 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11554 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11555 Remove unused locals.
7e3ab302
PE
11556 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11557 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11558 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11559 macros.
f78faa98 11560
e2b13473
PE
11561 * xterm.h (x_mouse_leave): New decl.
11562
77f23912
PE
11563 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11564 Remove unused functions.
cdf4ba58
PE
11565 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11566 (x_calc_absolute_position): Now static.
7411c686 11567 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11568 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11569 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11570 unless they are used.
38d0b34a
PE
11571 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11572 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11573 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11574 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11575 (x_error_catcher, x_connection_closed, x_error_handler):
11576 (x_error_quitter, xembed_send_message, x_iconify_frame):
11577 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11578 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11579 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11580
44f230aa
SM
11581 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11582 Rename or move locals to avoid shadowing.
6b463e58 11583 (tty_defined_color, merge_face_heights): Now static.
5967d051 11584 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11585 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11586 does not deduce is never used uninitialized.
73719eba
PE
11587 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11588 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11589
426994c3 11590 * terminal.c (store_terminal_param): Now static.
5489860b 11591
032f1620 11592 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11593 (set_frame_menubar): Remove unused local.
d4323972 11594 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11595 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11596 since they might point to immutable storage.
281585b0
PE
11597 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11598 since it's unused otherwise.
032f1620 11599
367c19e5 11600 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11601 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11602 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11603 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11604 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11605 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11606 does not deduce are never used uninitialized.
70739cbe 11607
07b48fa9
PE
11608 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11609
8868a238 11610 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11611 * window.c (window_loop, size_window):
11612 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11613
7e5cf297 11614 * window.c (display_buffer): Now static.
d6550a9f
PE
11615 (size_window): Mark variables that gcc -Wuninitialized
11616 does not deduce are never used uninitialized.
a586633d
PE
11617 * window.h (check_all_windows): New decl, to forestall
11618 gcc -Wmissing-prototypes diagnostic.
5b555da1 11619 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11620
f6095868
PE
11621 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11622 shadowing.
11623 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11624 Include <limits.h>.
11625 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11626 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11627 (load_charset_map): Mark variables that gcc -Wuninitialized
11628 does not deduce are never used uninitialized.
53df7c11 11629 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11630
f38b440c
PE
11631 * coding.c (coding_set_source, coding_set_destination):
11632 Use "else { /* comment */ }" rather than "else /* comment */;"
11633 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11634 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11635 a block, when the outer 'i' will do.
11636 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11637 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11638 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11639 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11640 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11641 Rename locals to avoid shadowing.
11642 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11643 * coding.c (emacs_mule_char, encode_invocation_designation):
11644 Now static, since they're not used elsewhere.
413bb2db 11645 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11646 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11647 (decode_coding_emacs_mule): Mark variables that gcc
11648 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11649 (detect_coding_iso_2022): Initialize a local variable that might
11650 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11651 this initialization is needed. (Bug#8211)
5f58e762
PE
11652 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11653 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11654 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11655 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11656 Remove unused macros.
f38b440c 11657
232b38b9 11658 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11659 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11660 * character.c (string_count_byte8): Likewise.
232b38b9 11661
fb90da1b
PE
11662 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11663 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11664
fb93dbc2
PE
11665 * chartab.c (copy_sub_char_table): Now static, since it's not used
11666 elsewhere.
5c156ace
PE
11667 (sub_char_table_ref_and_range, char_table_ref_and_range):
11668 Rename locals to avoid shadowing.
bbcd0949 11669 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11670
7d3b3862 11671 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11672 (BIDI_BOB): Remove unused macro.
7d3b3862 11673
6be7d3da
PE
11674 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11675 deduce are never used uninitialized.
c2ed9c8b 11676 * term.c (encode_terminal_code): Likewise.
6be7d3da 11677
75f8807f 11678 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11679
50938595
PE
11680 * tparam.h: New file.
11681 * term.c, tparam.h: Include it.
11682 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11683 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11684 Move these decls to tparam.h, and make them agree with what
11685 is actually in tparam.c. The previous trick of using incompatible
11686 decls in different modules does not conform to the C standard.
11687 All callers of tparam changed to use tparam's actual API.
11688 * tparam.c (tparam1, tparam, tgoto):
11689 Use const pointers where appropriate.
11690
fbceeba2
PE
11691 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11692 * cm.h (struct cm): Likewise.
11693 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11694 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11695 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11696 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11697 (turn_on_face, init_tty): Likewise.
11698 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11699
7f3f1250
PE
11700 * term.c (term_mouse_position): Rename local to avoid shadowing.
11701
e6ca6543
PE
11702 * alloc.c (mark_ttys): Move decl from here ...
11703 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11704
c40f8d15
AS
117052011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11706
11707 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11708
cfe0661d
JB
117092011-03-09 Juanma Barranquero <lekktu@gmail.com>
11710
11711 * search.c (compile_pattern_1): Remove argument regp, unused since
11712 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11713 (compile_pattern): Don't pass it.
11714
0afb4571
J
117152011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11716
11717 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11718 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11719 for ! HAVE_GTK3.
11720 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11721
11722 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11723
11724 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11725 gdk_window_get_screen, gdk_window_get_geometry,
11726 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11727 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11728 (xg_get_pixbuf_from_pixmap): New function.
11729 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11730 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11731 Call xg_get_pixbuf_from_pixmap instead of
11732 gdk_pixbuf_get_from_drawable.
11733 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11734 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11735 (xg_check_special_colors): Use GtkStyleContext and its functions
11736 for HAVE_GTK3.
11737 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11738 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11739 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11740 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11741 Call gtk_widget_get_preferred_size.
0afb4571
J
11742 (xg_frame_resized): gdk_window_get_geometry only takes 5
11743 parameters.
44f230aa
SM
11744 (xg_win_to_widget, xg_event_is_for_menubar):
11745 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11746 (xg_set_widget_bg): New function.
11747 (delete_cb): New function.
895009e1 11748 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11749 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11750 (xg_set_background_color): Call xg_set_widget_bg.
11751 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11752 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11753 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11754 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11755 if ! HAVE_GTK3.
11756 (update_frame_tool_bar): Call gtk_widget_hide.
11757 (xg_initialize): Use GDK_KEY_g.
11758
11759 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11760 if ! HAVE_GTK3
11761 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11762
11763 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11764 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11765 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11766
1c2cc4ef
JB
117672011-03-08 Juanma Barranquero <lekktu@gmail.com>
11768
11769 * w32xfns.c (select_palette): Check success of RealizePalette against
11770 GDI_ERROR, not zero.
11771
33383987 11772See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11773
11774;; Local Variables:
11775;; coding: utf-8
aac0c6e3
MR
11776;; End:
11777
2f097256 11778 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11779
11780 This file is part of GNU Emacs.
11781
11782 GNU Emacs is free software: you can redistribute it and/or modify
11783 it under the terms of the GNU General Public License as published by
11784 the Free Software Foundation, either version 3 of the License, or
11785 (at your option) any later version.
11786
11787 GNU Emacs is distributed in the hope that it will be useful,
11788 but WITHOUT ANY WARRANTY; without even the implied warranty of
11789 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11790 GNU General Public License for more details.
11791
11792 You should have received a copy of the GNU General Public License
11793 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.