Fix a typo that caused crashes in redisplay.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
aa36e4d2
EZ
12012-09-12 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (try_window_reusing_current_matrix): Under bidi
4 reordering, locate the cursor by calling set_cursor_from_row; if
5 that fails, clear the desired glyph matrix before returning a
6 failure indication to the caller. Fixes leaving garbled display
7 when fast scrolling with a down-key. (Bug#12403)
f2016bea
EZ
8 (compute_stop_pos_backwards): Fix a typo that caused crashes while
9 scrolling through multibyte text.
aa36e4d2 10
e0453b55
JD
112012-09-12 Jan Djärv <jan.h.d@swipnet.se>
12
13 * gtkutil.c (x_wm_set_size_hint): Use 1 col for base_width so it
14 does not become zero (Bug#12234). Backport from trunk.
15
19c17fc1
CY
162012-08-24 Chong Yidong <cyd@gnu.org>
17
18 * Version 24.2 released.
19
36c46f8e
EZ
202012-08-24 Eli Zaretskii <eliz@gnu.org>
21
22 * ralloc.c (free_bloc): Don't dereference a 'heap' structure if it
23 is not one of the heaps we manage. (Bug#12242)
24
8c95e664
GM
252012-08-14 Glenn Morris <rgm@gnu.org>
26
27 * eval.c (Fcalled_interactively_p): Doc fix. (Bug#11747)
28
7f654971
UM
292012-08-14 Ulrich Mueller <ulm@gentoo.org>
30
31 * systime.h (EMACS_TIME_CMP): Don't cast time_t values to long
32 (Bug#11712).
33
170aedb9
CY
342012-08-13 Eli Zaretskii <eliz@gnu.org>
35
b7f501c7
EZ
36 * w32menu.c: Include w32heap.h.
37 (add_menu_item): If the call to AppendMenuW (via
38 unicode_append_menu) fails, disable Unicode menus only if we are
39 running on Windows 9X/Me.
40
41 * makefile.w32-in ($(BLD)/w32menu.$(O)): Depend on w32heap.h.
42
170aedb9
CY
43 * window.c (Fdelete_other_windows_internal)
44 (Fdelete_window_internal): Don't access frame's mouse highlight
45 info of the initial frame. (Bug#11677)
46
c17d5a38
JD
472012-08-12 Jan Djärv <jan.h.d@swipnet.se>
48
49 * nsterm.m (ns_read_socket): Return early if there is a modal
50 window (Bug#12043).
51
52 * nsmenu.m (Popdown_data): New struct.
53 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
54 free Popdown_data.
55 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
56 (initWithContentRect): Make imgView and contentView non-static
57 and autorelease them. Also autorelease img and matrix (Bug#12005).
58 (dealloc): Remove (Bug#12005).
59
60 * nsterm.m (keyDown:): Interpret flags without left/right bits
61 as the left key (Bug#11670).
62
63 * nsmenu.m (ns_update_menubar): Add braces to ambigous if-else.
64
8ccd072a
YM
652012-08-08 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
66
67 * unexmacosx.c (copy_data_segment): Copy initialized data in
68 statically linked libraries from input file rather than memory.
69
db74a5fc
YM
702012-08-07 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
71
72 * unexmacosx.c (print_load_command_name): Add cases LC_MAIN,
73 LC_SOURCE_VERSION, and LC_DYLIB_CODE_SIGN_DRS.
74 (dump_it) [LC_DYLIB_CODE_SIGN_DRS]: Call copy_linkedit_data.
75
23dc7744
CY
762012-07-19 Chong Yidong <cyd@gnu.org>
77
78 * window.c (Fwindow_absolute_pixel_edges)
79 (Fdelete_other_windows_internal): Signal an error if the window is
80 on a dead frame (Bug#11984).
81
fbf31a9c
EZ
822012-07-14 Eli Zaretskii <eliz@gnu.org>
83
84 Remove FILE_SYSTEM_CASE.
85 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
86
87 * fileio.c (FILE_SYSTEM_CASE): Don't define.
88 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
89 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
90 call-process-region passes it through expand-file-name.
91
92 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
93
8a05d57a
AS
942012-07-12 Andreas Schwab <schwab@linux-m68k.org>
95
96 Fix crash when creating indirect buffer (Bug#11917)
97 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
98 Don't handle unbound variables specially if non-zero.
99 (Fbuffer_local_variables): Pass zero.
100 (clone_per_buffer_values): Pass non-zero.
101
57570cd3
AS
1022012-06-28 Andreas Schwab <schwab@linux-m68k.org>
103
104 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
105 to make the loop interruptible.
106
d01fd55f
AS
1072012-06-26 Andreas Schwab <schwab@linux-m68k.org>
108
109 * gnutls.c (emacs_gnutls_handshake): Only retry if
110 GNUTLS_E_INTERRUPTED.
111
c81b46f6
EZ
1122012-06-23 Eli Zaretskii <eliz@gnu.org>
113
114 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
115 in the logic of incrementing and decrementing the value of
116 use_relocatable_buffers.
117
63541ed8
GM
1182012-06-21 Glenn Morris <rgm@gnu.org>
119
120 * charset.c (init_charset): Make lack of etc/charsets fatal.
121
50a93863
JD
1222012-06-11 Jan Djärv <jan.h.d@swipnet.se>
123
124 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
125 referenced (Bug#11583).
126
94f0aa34
CY
1272012-06-01 Chong Yidong <cyd@gnu.org>
128
129 * Version 24.1 released.
130
d5fd2c54
EZ
1312012-05-30 Eli Zaretskii <eliz@gnu.org>
132
133 * xdisp.c (handle_stop): Detect whether we have overlay strings
134 loaded by testing it->current.overlay_string_index to be
135 non-negative, instead of checking whether n_overlay_strings is
136 positive. (Bug#11587)
137
353c87f6
CY
1382012-05-30 Chong Yidong <cyd@gnu.org>
139
140 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
141
142 * doc.c (Fsubstitute_command_keys): Doc fix.
143
a02ae4e5
EZ
1442012-05-29 Eli Zaretskii <eliz@gnu.org>
145
146 * search.c (search_buffer): Remove calls to
147 r_alloc_inhibit_buffer_relocation, as it is now called by
148 maybe_unify_char, which was the cause of relocation of buffer text
149 in bug#11519.
150
291d430f
EZ
1512012-05-23 Eli Zaretskii <eliz@gnu.org>
152
153 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
154 for the duration of call to load_charset, to avoid problems with
155 callers of maybe_unify_char that access buffer text through C
156 pointers.
157
158 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
159 decrement the inhibition flag, instead of just setting or
160 resetting it.
161
2f9b9adb
KB
1622012-05-24 Ken Brown <kbrown@cornell.edu>
163
164 * callproc.c (Fcall_process): Restore a line that was accidentally
165 commented out in the 2011-02-13 change (bug#11547).
166
52c55cc7
EZ
1672012-05-23 Eli Zaretskii <eliz@gnu.org>
168
169 * lisp.h [REL_ALLOC]: Add prototypes for external functions
170 defined on ralloc.c.
171
172 * buffer.c [REL_ALLOC]: Remove prototypes of
173 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
174 they are now on lisp.h.
175
176 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
177
178 * search.c (search_buffer): Use it to inhibit relocation of buffer
179 text while re_search_2 is doing its job, because re_search_2 is
180 passed C pointers to buffer text. (Bug#11519)
181
23415acf
EZ
1822012-05-21 Eli Zaretskii <eliz@gnu.org>
183
184 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
185 Update value to 24.
186
44e27368
EZ
1872012-05-19 Eli Zaretskii <eliz@gnu.org>
188
189 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
190 state after an additional call to move_it_in_display_line_to, keep
191 the values of it->max_ascent and it->max_descent found for the
192 entire line.
193 (pos_visible_p): Revert the comparison against bottom_y to what it
194 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
195 (Bug#11464)
196
ccbf309c
EZ
1972012-05-15 Eli Zaretskii <eliz@gnu.org>
198
199 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
200
ac268e67
EZ
2012012-05-13 Eli Zaretskii <eliz@gnu.org>
202
203 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
204 already have overlays loaded.
205 (handle_single_display_spec): Before returning without displaying
206 fringe bitmap, synchronize the bidi iterator with the main display
207 iterator, by calling iterate_out_of_display_property.
208 (iterate_out_of_display_property): Detect buffer iteration by
209 testing that it->string is a Lisp string.
210 (get_next_display_element): When the current object is exhausted,
211 and there's something on it->stack, call set_iterator_to_next to
212 proceed with what's on the stack, instead of returning zero.
213 (set_iterator_to_next): If called at the end of a Lisp string,
214 proceed to consider_string_end without incrementing string
215 position. Don't increment display vector index past the end of
216 the display vector. (Bug#11417)
c8fb9dc6
EZ
217 (pos_visible_p): Don't report a position visible when move_it_to
218 stopped at the last line of window, which happens to be scanned
219 backwards by the bidi iteration. (Bug#11464)
ac268e67 220
82f9b393
EZ
2212012-05-11 Eli Zaretskii <eliz@gnu.org>
222
223 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
224 and right-margin display specs even if the spec is invalid or we
225 are on a TTY, and thus unable to display on the fringes. That's
226 because the text with the property will not be displayed anyway,
227 so we need to signal to the caller that this is a "replacing"
228 display spec. This fixes display when the spec is invalid or we
229 are on a TTY.
230
297834cd
PE
2312012-05-09 Paul Eggert <eggert@cs.ucla.edu>
232
233 * unexaix.c (make_hdr): Fix typo in prototype.
234 This bug broke the build on AIX. Problem reported by Gilles Pion.
235
0d887c7d
EZ
2362012-05-05 Eli Zaretskii <eliz@gnu.org>
237
238 * w32proc.c (new_child): Force Windows to reserve only 64KB of
239 stack for each reader_thread, instead of defaulting to 8MB
240 determined by the linker. This avoids failures in creating
241 subprocesses on Windows 7, see the discussion in this thread:
242 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
243
bf98199c
JM
2442012-05-02 Jim Meyering <meyering@redhat.com>
245
246 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
247
2fa85638
EZ
2482012-04-29 Eli Zaretskii <eliz@gnu.org>
249
250 * xdisp.c (pos_visible_p): If already at a newline from the
251 display string before the 'while' loop, don't walk back the glyphs
252 from it3.glyph_row. Solves assertion violation when the display
253 string begins with a newline (egg.el). (Bug#11367)
254
9be2fd9b
CY
2552012-04-24 Chong Yidong <cyd@gnu.org>
256
257 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
258
f0ee99a0
EZ
2592012-04-23 Eli Zaretskii <eliz@gnu.org>
260
261 * xdisp.c (pos_visible_p): If the window start position is beyond
262 ZV, start the display from buffer beginning. Prevents assertion
263 violation in init_iterator when the minibuffer window is scrolled
264 via the scroll bar.
265
266 * window.c (window_scroll_pixel_based): Likewise.
267
9ec7751f
CY
2682012-04-23 Chong Yidong <cyd@gnu.org>
269
270 * keymap.c (where_is_internal): Doc fix (Bug#10872).
271
24c51a09
GM
2722012-04-20 Glenn Morris <rgm@gnu.org>
273
274 * fileio.c (Fcopy_file, Fset_file_selinux_context):
275 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
276
73055685
EZ
2772012-04-20 Eli Zaretskii <eliz@gnu.org>
278
279 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
280 overrun array limits of glyph row's used[] array. (Bug#11288)
281
f30d612a
CY
2822012-04-20 Chong Yidong <cyd@gnu.org>
283
284 * process.c (wait_reading_process_output): If EIO occurs on a pty,
285 set the status to "failed" and ensure that sentinel is run.
286
016a35df
GM
2872012-04-18 Glenn Morris <rgm@gnu.org>
288
289 * process.c (Fset_process_inherit_coding_system_flag)
290 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 291 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 292
20a68157
EZ
2932012-04-17 Eli Zaretskii <eliz@gnu.org>
294
295 * xdisp.c (string_buffer_position_lim): Limit starting position to
296 BEGV.
297 (set_cursor_from_row): If called for a mode-line or header-line
298 row, return zero immediately.
299 (try_cursor_movement): If inside continuation line, don't back up
300 farther than the first row after the header line, if any. Don't
301 consider the header-line row as "partially visible", even if
302 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
303
ad3a2b41
AO
3042012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
305
306 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
307
e63c261b
CY
3082012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
309
310 * process.c (make_process):
311 * process.h: Add integer `gnutls_handshakes_tried' member to
312 process struct.
313
ad3a2b41
AO
314 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
315 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
316
317 * gnutls.c (gnutls_log_function2i): Convenience log function.
318 (emacs_gnutls_read): Use new log functions,
319 `gnutls_handshakes_tried' process member, and
320 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
321 attempts per process (connection).
322
e53357c4
EZ
3232012-04-09 Eli Zaretskii <eliz@gnu.org>
324
325 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
326 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
327
aff67c82
JD
3282012-04-09 Jan Djärv <jan.h.d@swipnet.se>
329
330 * nsterm.m (constrainFrameRect): Always constrain when there is only
331 one screen (Bug#10962).
332
2f8e16b2
EZ
3332012-04-06 Eli Zaretskii <eliz@gnu.org>
334
335 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
336 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
337 about subtle differences between FETCH_CHAR* and STRING_CHAR*
338 macros related to unification of CJK characters. For the details,
339 see the discussion following the message here:
340 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
341
3d439cd1
CY
3422012-04-04 Chong Yidong <cyd@gnu.org>
343
344 * keyboard.c (Vdelayed_warnings_list): Doc fix.
345
8bc53d00
EZ
3462012-04-01 Eli Zaretskii <eliz@gnu.org>
347
348 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
349 instead of alloca. (Bug#11138)
350
3b0512a3
AS
3512012-04-01 Andreas Schwab <schwab@linux-m68k.org>
352
353 * w32menu.c (is_simple_dialog): Properly check lisp types.
354 (Bug#11141)
355
8427ddd2
EZ
3562012-03-31 Eli Zaretskii <eliz@gnu.org>
357
979022ef
EZ
358 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
359 position we get to after a call to move_it_to fails the
360 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
361 only if we wind up in a string from display property. (Bug#11063)
362
a6b1c7cc
EZ
363 * window.c (Fdelete_other_windows_internal): Invalidate the row
364 and column information about mouse highlight, so that redisplay
365 restores it after reallocating the glyph matrices. (Bug#7464)
366
8427ddd2
EZ
367 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
368 string comes from a `display' text property, use the buffer
369 position of that property as if we actually saw that position in
370 the row's glyphs.
697ba24b
EZ
371 (move_it_by_lines): Remove the assertion that
372 "it->current_x == 0 && it->hpos == 0" which can be legitimately
373 violated when there's a before-string at the beginning of a line.
374 (Bug#11063)
8427ddd2 375
65a0a738
EZ
3762012-03-30 Eli Zaretskii <eliz@gnu.org>
377
378 * xdisp.c (append_space_for_newline): If the default face was
379 remapped, use the remapped face for the appended newline.
380 (extend_face_to_end_of_line): Use the remapped default face for
381 extending the face to the end of the line.
382 (display_line): Call extend_face_to_end_of_line when the default
383 face was remapped. (Bug#11068)
384
581355cc
EZ
3852012-03-29 Eli Zaretskii <eliz@gnu.org>
386
387 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
388
e8fc049f
SM
3892012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
390
391 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
392
4fb9a543
GM
3932012-03-27 Glenn Morris <rgm@gnu.org>
394
395 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
396 Doc fixes.
397
679910f1
KH
3982012-03-26 Kenichi Handa <handa@m17n.org>
399
400 * dispextern.h (struct glyph): Fix previous change. Change the
401 bit length of glyphless.ch to 25 (Bug#11082).
402
90d49b7f
CY
4032012-03-26 Chong Yidong <cyd@gnu.org>
404
405 * keyboard.c (Vselection_inhibit_update_commands): New variable.
406 (command_loop_1): Use it; inhibit selection update for
407 handle-select-window too (Bug#8996).
408
f514f6f0
FP
4092012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
410
e8fc049f 411 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 412
bf43fa51
KH
4132012-03-25 Kenichi Handa <handa@m17n.org>
414
415 * dispextern.h (struct glyph): Change the bit length of
416 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
417
8a0c01dd
EZ
4182012-03-24 Eli Zaretskii <eliz@gnu.org>
419
420 * s/ms-w32.h (tzname): Include time.h before redirecting to
421 _tzname. Fixes the MSVC build. (Bug#9960)
422
7d1c3a76
AS
4232012-03-24 Andreas Schwab <schwab@linux-m68k.org>
424
8ed79523
AS
425 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
426 characters.
427
7d1c3a76
AS
428 * xterm.c (XTread_socket): Only modify handling_signal if
429 !SYNC_INPUT. (Bug#11080)
430
e99a9b8b
EZ
4312012-03-23 Eli Zaretskii <eliz@gnu.org>
432
433 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
434 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
435 when fetching a multibyte character consumes more bytes than
436 CHAR_BYTES returns, due to unification of CJK characters in
437 string_char. (Bug#11073)
438
5063c0e1
TN
4392012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
440
441 * process.c (wait_reading_process_output): Handle pty disconnect
442 by refraining from sending oneself a SIGCHLD (bug#10933).
443
9f851fbd
CY
4442012-03-22 Chong Yidong <cyd@gnu.org>
445
446 * dispextern.h (struct it): New member string_from_prefix_prop_p.
447
5063c0e1 448 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
449 Mark string as coming from a prefix property.
450 (handle_face_prop): Use default face for prefix strings (Bug#4281).
451 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
452
fb5b8aca
CY
4532012-03-21 Chong Yidong <cyd@gnu.org>
454
455 * xfaces.c (Vface_remapping_alist): Doc fix.
456
62356a1b
EZ
4572012-03-20 Eli Zaretskii <eliz@gnu.org>
458
459 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
460 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
461 Doc fixes.
62356a1b 462
025de85b
CY
4632012-03-20 Chong Yidong <cyd@gnu.org>
464
465 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
466 to reflect default non-nil value of redisplay-dont-pause.
467
4827f94e
KH
4682012-03-19 Kenichi Handa <handa@m17n.org>
469
470 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
471 it fit in a valid range (Bug#11003).
472
e50a24a2
EZ
4732012-03-18 Eli Zaretskii <eliz@gnu.org>
474
475 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
476 that is not from display property, accept the row as a "cursor
477 row" if one of the string's character has a non-nil `cursor'
478 property. Fixes cursor positioning when there are newlines in
479 overlay strings, e.g. in icomplete.el. (Bug#11035)
480
9af5ed87
PE
4812012-03-12 Paul Eggert <eggert@cs.ucla.edu>
482
483 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
484
d1f55f16
CY
4852012-03-12 Chong Yidong <cyd@gnu.org>
486
487 * eval.c (inhibit_lisp_code): Rename from
488 inhibit_window_configuration_change_hook; move from window.c.
489
490 * xfns.c (unwind_create_frame_1, Fx_create_frame):
491 * window.c (run_window_configuration_change_hook)
492 (syms_of_window): Callers changed.
493
66c5eebd
CY
4942012-03-11 Chong Yidong <cyd@gnu.org>
495
413df973
CY
496 * keymap.c (Fkey_description): Doc fix (Bug#9700).
497
66c5eebd
CY
498 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
499
1de11f56
CY
5002012-03-10 Chong Yidong <cyd@gnu.org>
501
502 * frame.c (other_visible_frames): Don't assume the selected frame
503 is visible (Bug#10955).
504
cae07000
SM
5052012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
506
507 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
508
89c94350
JD
5092012-03-08 Jan Djärv <jan.h.d@swipnet.se>
510
511 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
512 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
513 zero (Bug#10954).
514
999dd333
GM
5152012-03-03 Glenn Morris <rgm@gnu.org>
516
01a6dcc8 517 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 518
de0100f2
EZ
5192012-03-02 Eli Zaretskii <eliz@gnu.org>
520
521 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
522 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
523 (redisplay_window, next_element_from_string): Fix typos in
524 comments.
3e441275
EZ
525 (redisplay_window): Pass to move_it_vertically the margin in
526 pixels, not in screen lines.
de0100f2 527
96a72ee9
GM
5282012-03-02 Glenn Morris <rgm@gnu.org>
529
530 * buffer.c (buffer-list-update-hook): Doc fix.
531
312508d7
EZ
5322012-02-29 Eli Zaretskii <eliz@gnu.org>
533
534 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
535 push_it before setting up the iterator for the first overlay
536 string, even if we have an empty string loaded.
537 (next_overlay_string): If there's an empty string on the iterator
538 stack, pop the stack. (Bug#10903)
539
27f3c637
PE
5402012-02-25 Paul Eggert <eggert@cs.ucla.edu>
541
542 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
543 Suggested by Stefan Monnier in
544 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
545 * alloc.c (widen_to_Lisp_Object): New static function.
546 (mark_memory): Also mark Lisp_Objects by fetching pointer words
547 and widening them to Lisp_Objects. This would work even if
548 USE_LSB_TAG is defined and wide integers are used, which might
549 happen in a future version of Emacs.
550
3c9dfce6
CY
5512012-02-25 Chong Yidong <cyd@gnu.org>
552
fa74b241
CY
553 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
554 Doc fix.
555
3c9dfce6
CY
556 * xselect.c (Fx_selection_exists_p): Doc fix.
557 (x_clipboard_manager_save_all): Print an informative message
558 before saving to clipboard manager.
559
9486df08
CY
5602012-02-24 Chong Yidong <cyd@gnu.org>
561
562 * keyboard.c (process_special_events): Handle all X selection
563 requests in kbd_buffer, not just the next one (Bug#8869).
564
f01d3321
CY
5652012-02-23 Chong Yidong <cyd@gnu.org>
566
567 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
568 call when setting menu-bar-lines and tool-bar-lines parameters.
569 (unwind_create_frame_1): New helper function.
570
571 * window.c (inhibit_window_configuration_change_hook): New var.
572 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 573 (syms_of_window): Initialize it.
f01d3321 574
86b847b6
CY
5752012-02-22 Chong Yidong <cyd@gnu.org>
576
577 * xterm.c (x_draw_image_relief): Add missing type check for
578 Vtool_bar_button_margin (Bug#10743).
579
a59225b1
CY
5802012-02-21 Chong Yidong <cyd@gnu.org>
581
582 * fileio.c (Vfile_name_handler_alist): Doc fix.
583
584 * buffer.c (Fget_file_buffer): Protect against invalid file
585 handler return value.
586
310f5bd4
PE
5872012-02-20 Paul Eggert <eggert@cs.ucla.edu>
588
cb3a28cc
PE
589 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
590 when computing $valmask.
591
310f5bd4
PE
592 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
593 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
594 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
595 It's useless in that case, and it can cause problems on hosts
596 that allocate halves of EMACS_INT values separately.
597 Reported by Dan Horák. Diagnosed by Andreas Schwab in
598 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
599 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
600 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
601 it avoids undefined behavior on hosts where shifting right by more
602 than the word width has undefined behavior.
603
2375c96a
CY
6042012-02-19 Chong Yidong <cyd@gnu.org>
605
606 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
607 (Funhandled_file_name_directory, Ffile_name_as_directory)
608 (Fdirectory_file_name, Fexpand_file_name)
609 (Fsubstitute_in_file_name): Protect against invalid file handler
610 return values (Bug#10845).
611
3eb49e71
EZ
6122012-02-18 Eli Zaretskii <eliz@gnu.org>
613
614 * .gdbinit (pitx): Fix incorrect references to fields of the
615 iterator stack.
616
7b926f3f
CY
6172012-02-17 Chong Yidong <cyd@gnu.org>
618
619 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
620
11273115
PE
6212012-02-15 Paul Eggert <eggert@cs.ucla.edu>
622
623 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
624 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
625
c3a70e2b
CY
6262012-02-15 Chong Yidong <cyd@gnu.org>
627
628 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
629 marked as special. Also, starting docstrings with * is obsolete.
630
0ca43699
AS
6312012-02-13 Andreas Schwab <schwab@linux-m68k.org>
632
633 * gnutls.c (emacs_gnutls_write): Fix last change.
634
2e8f3c56
LI
6352012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
636
637 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
638 send_process.
639
af70074f
SM
6402012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
641
642 * keymap.c (Fsingle_key_description): Handle char ranges.
643
95986d52
CY
6442012-02-12 Chong Yidong <cyd@gnu.org>
645
afd83bd1
CY
646 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
647 as that creates a dangerous corner case.
648
95986d52
CY
649 * window.c (Fdelete_window_internal): Invalidate the mouse
650 highlight (Bug#9904).
651
bd7da63e
GM
6522012-02-12 Glenn Morris <rgm@gnu.org>
653
654 * xselect.c (Fx_own_selection_internal)
655 (Fx_get_selection_internal, Fx_disown_selection_internal)
656 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
657 * nsselect.m (Fx_own_selection_internal)
658 (Fx_disown_selection_internal, Fx_selection_exists_p)
659 (Fx_selection_owner_p, Fx_get_selection_internal):
660 Sync docs and argument specs with the xselect.c versions.
661
77abcbc2
LI
6622012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
663
664 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
665
90b671e2
EZ
6662012-02-11 Eli Zaretskii <eliz@gnu.org>
667
1c0ca0b7
EZ
668 * w32select.c (Fx_selection_exists_p): Sync doc string and
669 argument list with xselect.c. (Bug#10783)
670
671 * w16select.c (Fx_selection_exists_p): Sync doc string and
672 argument list with xselect.c. (Bug#10783)
90b671e2 673
49241268
GM
6742012-02-10 Glenn Morris <rgm@gnu.org>
675
676 * fns.c (Fsecure_hash): Doc fix.
677
f998bbe7 6782012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
679
680 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
681
0992bd9c
CY
6822012-02-07 Chong Yidong <cyd@gnu.org>
683
684 * buffer.c (Fbuffer_local_variables)
685 (buffer_lisp_local_variables): Handle unbound vars correctly;
686 don't let Qunbound leak into Lisp.
687
af008560
GM
6882012-02-07 Glenn Morris <rgm@gnu.org>
689
dd605cc4
GM
690 * image.c (Fimagemagick_types): Doc fix.
691
af008560
GM
692 * image.c (imagemagick-render-type): Change it from a lisp object
693 to an integer. Move the doc here from the lisp manual.
694 Treat all values not equal to 0 the same.
695
1449fa1d
CY
6962012-02-06 Chong Yidong <cyd@gnu.org>
697
698 * doc.c (store_function_docstring): Avoid applying docstring of
699 alias to base function (Bug#2603).
700
3723ec07
AS
7012012-02-04 Andreas Schwab <schwab@linux-m68k.org>
702
703 * .gdbinit (pp1, pv1): Remove redundant defines.
704 (pr): Use pp.
705
79c1cc1e
CY
7062012-02-04 Chong Yidong <cyd@gnu.org>
707
708 * nsterm.m: Declare a global (Bug#10694).
709
d7f29f8e
EZ
7102012-02-04 Eli Zaretskii <eliz@gnu.org>
711
cae07000
SM
712 * w32.c (get_emacs_configuration_options):
713 Include --enable-checking, if specified, in the return value.
d7f29f8e 714
3b95a6f9
MR
7152012-02-04 Martin Rudalics <rudalics@gmx.at>
716
717 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
718 after rounding frame sizes. (Bug#9723)
719
d6fa96a6
EZ
7202012-02-04 Eli Zaretskii <eliz@gnu.org>
721
722 * keyboard.c (adjust_point_for_property): Don't position point
723 before BEGV. (Bug#10696)
724
df0b2940
PE
7252012-02-03 Paul Eggert <eggert@cs.ucla.edu>
726
727 Handle overflow when computing char display width (Bug#9496).
728 * character.c (char_width): Return EMACS_INT, not int.
729 (char_width, c_string_width): Check for overflow when
730 computing the width; this is possible now that individual
731 characters can have unbounded width. Problem introduced
732 by merge from Emacs 23 on 2012-01-19.
733
6bee44d6
MA
7342012-02-02 Michael Albinus <michael.albinus@gmx.de>
735
736 * dbusbind.c (Fdbus_register_method): Mention the return value
737 :ignore in the docstring.
738
44f92739
GM
7392012-02-02 Glenn Morris <rgm@gnu.org>
740
1b9f60cc
GM
741 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
742
44f92739
GM
743 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
744 Unconditionally set to t. (Bug#10673)
745 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
746 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
747 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
748
c5d3843c
KH
7492012-02-02 Kenichi Handa <handa@m17n.org>
750
751 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
752 0, do not call append_composite_glyph.
753
159462d4 7542012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
755
756 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
757 NULL (Bug#6988).
758 (x_produce_glyphs): If the component of a composition is a null
759 string, set it->pixel_width to 1 to avoid zero-width glyph.
760
78cef877
EZ
7612012-02-01 Eli Zaretskii <eliz@gnu.org>
762
763 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
764 first 2 arguments are identical. This makes inserting large
765 output from a subprocess an order of magnitude faster on
766 MS-Windows, where all sbrk'ed memory is always contiguous.
767
97897668
GM
7682012-01-31 Glenn Morris <rgm@gnu.org>
769
770 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 771 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
772 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
773
31fd3586
GM
7742012-01-29 Glenn Morris <rgm@gnu.org>
775
776 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
777
0e24a8b2
CY
7782012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
779
780 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
781
cc0adcb0
CY
7822012-01-28 Chong Yidong <cyd@gnu.org>
783
784 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
785
acc28cb9
CY
7862012-01-26 Chong Yidong <cyd@gnu.org>
787
9c69cfb7
CY
788 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
789
acc28cb9
CY
790 * search.c (Fsearch_forward, Fsearch_backward): Document negative
791 repeat counts (Bug#10507).
792
48da7392
GM
7932012-01-26 Glenn Morris <rgm@gnu.org>
794
795 * lread.c (syms_of_lread): Doc fix.
796
14af5f7f
CY
7972012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
798
799 * coding.c (encode_designation_at_bol): Change return value to
800 EMACS_INT.
801
0b21c100
CY
8022012-01-25 Chong Yidong <cyd@gnu.org>
803
804 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
805
3c2907f7
CY
8062012-01-21 Chong Yidong <cyd@gnu.org>
807
808 * floatfns.c (Fcopysign): Make the second argument non-optional,
809 since nil is not allowed anyway.
810
959ad23f
AS
8112012-01-21 Andreas Schwab <schwab@linux-m68k.org>
812
813 * process.c (read_process_output): Use p instead of XPROCESS (proc).
814 (send_process): Likewise.
815
34a02f46
MR
8162012-01-19 Martin Rudalics <rudalics@gmx.at>
817
818 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
819 (Vwindow_persistent_parameters): Do not use Qstate.
820 Rewrite doc-strings.
34a02f46 821
1259009a 8222012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
823
824 * character.c (char_width): New function.
70d4fdf6
GM
825 (Fchar_width, c_string_width, lisp_string_width):
826 Use char_width (Bug#9496).
25ed9e61 827
6a6ee00d
MR
8282012-01-16 Martin Rudalics <rudalics@gmx.at>
829
830 * window.c (Vwindow_persistent_parameters): New variable.
831 (Fset_window_configuration, save_window_save): Handle persistent
832 window parameters.
833
c85efaf7
EZ
8342012-01-14 Eli Zaretskii <eliz@gnu.org>
835
836 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
837 thrashing the stack of the thread. (Bug#9087)
838
5944709e
PE
8392012-01-12 Paul Eggert <eggert@cs.ucla.edu>
840
841 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
842
e71f5d99
EZ
8432012-01-11 Eli Zaretskii <eliz@gnu.org>
844
845 * xdisp.c (rows_from_pos_range): Handle the case where the
846 highlight ends on a newline. (Bug#10464)
847 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
848 he end column for display of highlight that ends on a newline
849 before a R2L line.
850
ce316182
GM
8512012-01-11 Glenn Morris <rgm@gnu.org>
852
853 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
854 from load-path also when installation-directory is nil. (Bug#10208)
855
5b43da69
GM
8562012-01-10 Glenn Morris <rgm@gnu.org>
857
74cc8ff9
GM
858 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
859
7d8d6e4e
GM
860 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
861 Update template values to be closer to their typical values these days.
5b43da69 862
a0db8d43
EZ
8632012-01-09 Eli Zaretskii <eliz@gnu.org>
864
865 * xdisp.c (rows_from_pos_range): Accept additional argument
866 DISP_STRING, and accept any glyph in a row whose object is that
867 string as eligible for mouse highlight. Fixes mouse highlight of
868 display strings from overlays. (Bug#10464)
869
9a0115ab 8702012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 871
b9110d6a 872 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
873 * fileio.c (auto_saving_dir_umask): New static var.
874 (Fmake_directory_internal): Use it.
875 (do_auto_save_make_dir): Set it, instead of invoking chmod after
876 creating the directory. The old code temporarily assigns
877 too-generous permissions to the directory.
878 (do_auto_save_eh): Clear it.
b9110d6a 879 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
880 that the var is always cleared.
881
6c1bd3f3
EZ
8822012-01-07 Eli Zaretskii <eliz@gnu.org>
883
884 * search.c (scan_buffer): Pass character positions to
885 know_region_cache, not byte positions. (Bug#6540)
886
069d2b50
L
8872012-01-07 LynX <_LynX@bk.ru> (tiny change)
888
889 * w32.c (sys_rename): Report EXDEV when rename of a directory
890 fails because the target is on another logical disk. (Bug#10284)
891
75bf0d33
DB
8922012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
893
894 * xterm.c (x_embed_request_focus): New function.
895
896 * xterm.h: Add prototype.
897
898 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
899
1c6e5a32
GM
9002012-01-05 Glenn Morris <rgm@gnu.org>
901
902 * emacs.c (emacs_copyright): Update short copyright year to 2012.
903
651e947e
EZ
9042012-01-01 Eli Zaretskii <eliz@gnu.org>
905
906 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
907 Load gnutls_transport_set_lowat only if GnuTLS version is below
908 2.11.1.
909 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
910 GnuTLS versions below 2.11.1.
911
3778cdd8
AL
9122011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
913
914 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
915 to the doc string advising against its use for altering the way
916 windows are scrolled.
917
0e5317f7
KH
9182011-12-28 Kenichi Handa <handa@m17n.org>
919
920 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
921 coding-system ASCII compatible only when it does not produce BOM
922 on encoding (Bug#10383).
923
93d5ca1f
JD
9242011-12-26 Jan Djärv <jan.h.d@swipnet.se>
925
926 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
927 can scroll.
928 (create_and_show_popup_menu): Always use menu_position_func for
929 Gtk3 (Bug#10361).
930
ca22b785
AS
9312011-12-24 Andreas Schwab <schwab@linux-m68k.org>
932
933 * callint.c (Fcall_interactively): Don't truncate prompt string.
934
d048e1e6
EZ
9352011-12-23 Eli Zaretskii <eliz@gnu.org>
936
937 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
938 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 939 resumed from there (after widening). (Bug#10360)
d048e1e6 940
5ccaba1f
JD
9412011-12-22 Jan Djärv <jan.h.d@swipnet.se>
942
943 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
944
204ee57f
JD
9452011-12-21 Jan Djärv <jan.h.d@swipnet.se>
946
b81d40f0
JB
947 * nsterm.m (x_free_frame_resources):
948 Release f->output_data.ns->miniimage.
204ee57f
JD
949 (ns_index_color): Fix indentation. Do not retain
950 color_table->colors[i].
951
952 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
953 before returning.
954
955 * nsfns.m (x_set_background_color): Assign return value from
956 ns_index_color to face-background instead of NSColor*.
957 (ns_implicitly_set_icon_type): Fix indentation.
958 Change assignment in for loop to comparison.
959
960 * emacs.c (ns_pool): New variable.
961 (main): Assign ns_pool.
962 (Fkill_emacs): Call ns_release_autorelease_pool.
963
964 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
965 autorelease fdesc, release fdAttrs and tdict.
966 (ns_get_covering_families): Release charset.
967 (ns_findfonts): Release NSFontDescriptor created with new.
968 (ns_uni_to_glyphs): Fix indentation.
969 (setString): Release attrStr before assigning new value.
970
c803b2b7
JD
9712011-12-18 Jan Djärv <jan.h.d@swipnet.se>
972
678f4426
JD
973 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
974 and NS_IMPL_COCOA.
975 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
976 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
977
cd394be1 9782011-12-18 David Reitter <reitter@cmu.edu>
678f4426 979
5fecd5fc
JD
980 * nsterm.m (ns_term_init): Subscribe for notifications
981 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
982 to method trackingNotification in EmacsMenu.
983
984 * nsmenu.m (trackingMenu): New variable.
3771cb17 985 (trackingNotification): New method (from Aquamacs).
5fecd5fc 986 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 987 from Aquamacs (Bug#7030).
678f4426
JD
988
9892011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 990
c803b2b7
JD
991 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
992 (symbol_to_nsstring): Fix indentation.
993 (ns_symbol_to_pb): New function.
cae07000
SM
994 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
995 (Fns_rotate_cut_buffers_internal): Remove.
996 (Fns_store_selection_internal): Rename from
c803b2b7
JD
997 Fns_store_cut_buffer_internal.
998 (ns_get_foreign_selection, Fx_own_selection_internal)
999 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
1000 (Fns_get_selection_internal, Fns_store_selection_internal):
1001 Use ns_symbol_to_pb and check if return value is nil.
1002 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
1003 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
1004 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
1005 renamed to Sns_store_selection_internal.
1006 (ns_handle_selection_request): Move code to Fx_own_selection_internal
1007 and remove this function.
1008 (ns_handle_selection_clear): Remove, never used.
1009 (Fx_own_selection_internal): Move code from ns_handle_selection_request
1010 here.
1011
e1b01a3a
KB
10122011-12-17 Ken Brown <kbrown@cornell.edu>
1013
1014 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
1015 GID is unknown (Bug#10257).
1016
2adb6e85
PE
10172011-12-17 Paul Eggert <eggert@cs.ucla.edu>
1018
1019 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
1020 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
1021 which caused a build failure on GNU/Linux IA-64. This problem was
1022 introduced by my 2011-10-07 patch.
1023
d1d7b339
JL
10242011-12-15 Juri Linkov <juri@jurta.org>
1025
1026 * image.c (imagemagick_error): New function. (Bug#10112)
1027 (imagemagick_load_image): Comment out `MagickSetResolution' call.
1028 Use `imagemagick_error' where ImageMagick functions return
1029 `MagickFalse'.
1030 (Fimagemagick_types): Add `Fnreverse' to return the list in the
1031 proper order.
1032
100d5755
KH
10332011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1034
1035 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
1036 fill background (Bug#8992).
1037
454592a6
MR
10382011-12-13 Martin Rudalics <rudalics@gmx.at>
1039
1040 * window.c (Vwindow_combination_resize)
1041 (Vwindow_combination_limit): Use t instead of non-nil in
1042 doc-strings.
61d4b438
MR
1043 (Vrecenter_redisplay): Add first sentence of doc-string on
1044 separate line.
53524d93 1045 (Frecenter): Fix doc-string typo.
454592a6 1046
3633e3aa
KH
10472011-12-11 Kenichi Handa <handa@m17n.org>
1048
1049 * coding.c (Funencodable_char_position): Pay attention to the
1050 buffer text relocation (Bug#9389).
1051
7b9d523a
JD
10522011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1053
1054 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
1055 gtk_init (Bug#10100).
1056
b73189c6
EZ
10572011-12-10 Eli Zaretskii <eliz@gnu.org>
1058
1059 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
1060 IT->string is nil. (Bug#10263)
1061
f7dfe5d6
JD
10622011-12-10 Jan Djärv <jan.h.d@swipnet.se>
1063
83faebb4
JD
1064 * nsterm.h (x_free_frame_resources): Declare.
1065
f7dfe5d6
JD
1066 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
1067 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
1068
1069 * nsterm.h (ns_get_defaults_value): Declare.
1070
1071 * nsterm.m (ns_default): Call ns_get_defaults_value.
1072
7cd4e72c
EZ
10732011-12-09 Eli Zaretskii <eliz@gnu.org>
1074
1075 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
1076 (Bug#10170)
1077
b34d7317
YM
10782011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1079
1080 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
1081 that where the value of an _OBJC_* symbol points to is in the .bss
1082 section (Bug#10240).
1083
76470ad1
KH
10842011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1085
1086 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 1087 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 1088
745fff94
KH
10892011-12-08 Kenichi Handa <handa@m17n.org>
1090
1091 * ftfont.c (get_adstyle_property): Fix previous change
1092 (Bug#10233).
1093
6e44397c
JB
10942011-12-07 Juanma Barranquero <lekktu@gmail.com>
1095
1096 * w32.c (init_environment): If no_site_lisp, remove site-lisp
1097 dirs from the default value of EMACSLOADPATH (bug#10208).
1098
7efa6272
GM
10992011-12-07 Glenn Morris <rgm@gnu.org>
1100
1101 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
1102 installation and source directories as well. (Bug#10208)
1103
f6fc4d87
CY
11042011-12-06 Chong Yidong <cyd@gnu.org>
1105
1106 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
1107
2bf26180
GM
11082011-12-06 Glenn Morris <rgm@gnu.org>
1109
1110 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
1111 as an error, not just -1. (Bug#10217)
1112
3a6ad4f0
CY
11132011-12-05 Chong Yidong <cyd@gnu.org>
1114
1115 * keyboard.c (process_special_events): New function.
1116 (swallow_events, Finput_pending_p): Use it (Bug#10195).
1117
75a3b399
PE
11182011-12-05 Paul Eggert <eggert@cs.ucla.edu>
1119
1120 * coding.c (encode_designation_at_bol): Don't use uninitialized
1121 local variable (Bug#9318).
1122
c3c9e25e
KH
11232011-12-05 Kenichi Handa <handa@m17n.org>
1124
1125 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
1126 return Qnil (Bug#8046, Bug#10193).
1127
5eb05ea3
KH
11282011-12-05 Kenichi Handa <handa@m17n.org>
1129
1130 * coding.c (encode_designation_at_bol): New args charbuf_end and
1131 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
1132 (coding_set_source): Return how many bytes coding->source was
1133 relocated.
1134 (coding_set_destination): Return how many bytes
1135 coding->destination was relocated.
1136 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 1137 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
1138
11392011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
1140
1141 * coding.c (CODING_CHAR_CHARSET_P): New macro.
1142 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
1143 macro (Bug#9318).
1144
11452011-12-05 Andreas Schwab <schwab@linux-m68k.org>
1146
1147 The following changes are to fix Bug#9318.
1148
a79703f5 1149 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1150 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1151 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1152 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1153
7dbda6df
JB
11542011-12-05 Juanma Barranquero <lekktu@gmail.com>
1155
1156 * lisp.h (process_quit_flag): Fix external declaration.
1157
6d5eb5b0
SM
11582011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1159
1160 Don't macro-inline non-performance-critical code.
1161 * eval.c (process_quit_flag): New function.
1162 * lisp.h (QUIT): Use it.
1163
a0c3fad0
JD
11642011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1165
1166 * nsfns.m (get_geometry_from_preferences): New function.
1167 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1168
6c07aac2
AS
11692011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1170
1171 * emacs.c (Qkill_emacs): Define.
1172 (syms_of_emacs): Initialize it.
1173 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1174 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1175 (quit_throw_to_read_char): Add parameter `from_signal'.
1176 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1177 * lisp.h (QUIT): Call Fkill_emacs if requested.
1178
c052ead4
JD
11792011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1180
1181 * widget.c (update_wm_hints): Return if wmshell is null.
1182 (widget_update_wm_size_hints): New function.
1183
1184 * widget.h (widget_update_wm_size_hints): Declare.
1185
1186 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1187 widget_update_wm_size_hints (Bug#10104).
1188
9e49252b
EZ
11892011-12-03 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1192 before a newline, prepare the bidi iterator for consuming the
1193 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1194 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1195
02b16839
JL
11962011-12-02 Juri Linkov <juri@jurta.org>
1197
1198 * search.c (Fword_search_regexp): New Lisp function created from
1199 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1200 (Fword_search_backward, Fword_search_forward)
1201 (Fword_search_backward_lax, Fword_search_forward_lax):
1202 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1203 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1204
0068070e
SM
12052011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1206
1207 * fileio.c (Finsert_file_contents): Move after-change-function call
1208 to before the "handled:" label, since all "goto handled" appear in
1209 cases where the *-change-functions have already been properly called
1210 (bug#10117).
1211
3360a3fc
AS
12122011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1213
1214 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1215 waiting for input. (Bug#10169)
1216
73d6c093
EZ
12172011-11-30 Eli Zaretskii <eliz@gnu.org>
1218
1219 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1220 verifies glyph row's hash code--we have just reallocated the
1221 glyphs, so their contents can be complete garbage. (Bug#10164)
1222
febe6bea
JB
12232011-11-30 Juanma Barranquero <lekktu@gmail.com>
1224
1225 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1226
801a4313
EZ
12272011-11-30 Eli Zaretskii <eliz@gnu.org>
1228
1229 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1230 attributes are tested _before_ calling verify_row_hash, to protect
1231 against GCC re-ordering of the tests. (Bug#10164)
1232
2b56b87e
JD
12332011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1234
1235 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1236
1237 * xterm.c (handle_one_xevent): Only set async_visible and friends
1238 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1239 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1240 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1241
dbf31225
PE
12422011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1243
1244 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1245 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1246 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1247 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1248 All uses changed to use GCPRO1 etc.
1249 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1250 Revert to old implementation (i.e., before 2011-03-11).
1251
1305621b
YM
12522011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1253
1254 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1255 of scroll runs so as to avoid assigning disabled bogus rows and
1256 unnecessary graphics copy operations.
1257
8c9afb46
EZ
12582011-11-27 Eli Zaretskii <eliz@gnu.org>
1259
1260 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1261 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1262 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1263 (malloc, free, realloc, calloc): Redirect to e_* only when
1264 compiling Emacs.
1265
1266 * lisp.h (GCTYPEBITS): Move before first use.
1267 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1268 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1269 this macro definition.
1270
1271 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1272 _MSC_VER.
1273
54e9e3bf
JD
12742011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1275
6d5eb5b0
SM
1276 * gtkutil.c (xg_create_frame_widgets):
1277 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1278 present with Gtk+ 2.0.
1279
83aca1cb
PE
12802011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1281
1282 * fileio.c (Finsert_file_contents): Undo previous change; see
1283 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1284
5b76caa4
PE
12852011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1286
1287 Rename locals to avoid shadowing.
1288 * fileio.c (Finsert_file_contents):
1289 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1290 * process.c (wait_reading_process_output):
1291 Rename inner 'proc' to 'p' to avoid shadowing.
1292 Indent for consistency with usual Emacs style.
1293
8c535114
EZ
12942011-11-25 Eli Zaretskii <eliz@gnu.org>
1295
1296 * xdisp.c (redisplay_window): If cursor row is not fully visible
1297 after recentering, and scroll-conservatively is set to a large
1298 number, scroll window by a few more lines to make the cursor fully
1299 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1300 (start_display): Don't move to the next line if the display should
1301 start at a newline that is part of a display vector or an overlay
1302 string. (Bug#10119)
8c535114 1303
fa4fdb5c
JL
13042011-11-24 Juri Linkov <juri@jurta.org>
1305
1306 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1307 after the `MagickPingImage' call. (Bug#10112)
1308
90ec88df
CY
13092011-11-23 Chong Yidong <cyd@gnu.org>
1310
1311 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1312
56e2e794
MR
13132011-11-23 Martin Rudalics <rudalics@gmx.at>
1314
1315 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1316 making another buffer current. (Bug#10114)
1317
b6e64c41
GM
13182011-11-23 Glenn Morris <rgm@gnu.org>
1319
1320 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1321
6b21de18
CY
13222011-11-23 Chong Yidong <cyd@gnu.org>
1323
1324 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1325 using it (Bug#5984).
1326
b12cd789
EZ
13272011-11-22 Eli Zaretskii <eliz@gnu.org>
1328
1329 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1330 and header-lines, as they don't have one computed for them.
1331 (Bug#10098)
1332
1333 * .gdbinit (prow): Make displayed values more self-explaining.
1334 Add row's hash code.
1335
261b6fd4
LMI
13362011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1337
1338 * process.c (wait_reading_process_output): Fix asynchrounous
1339 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1340 (wait_reading_process_output): Add comment and URL.
261b6fd4 1341
e7cfd277
JD
13422011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1343
1344 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1345
a9b9b7f5
CY
13462011-11-21 Chong Yidong <cyd@gnu.org>
1347
1348 * window.c (Fnext_window, Fprevious_window): Doc fix.
1349
b0d15b4f
SM
13502011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1351
1352 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1353
fe7a3057
JB
13542011-11-20 Juanma Barranquero <lekktu@gmail.com>
1355
1356 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1357
d2999b1a
MR
13582011-11-20 Martin Rudalics <rudalics@gmx.at>
1359
1360 * window.c (Fset_window_combination_limit): Rename argument
1361 STATUS to LIMIT.
1362 (Vwindow_combination_limit): Remove "status" from doc-string.
1363
d5ff9cd0
AS
13642011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1365
1366 * m/ibms390.h: Remove.
1367 * m/ibms390x.h: Don't include "ibms390.h".
1368
a5bb9bd3
SM
13692011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1370
1371 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1372 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1373
cd1181db
JB
13742011-11-20 Juanma Barranquero <lekktu@gmail.com>
1375
1376 * casetab.c (Fset_case_table):
1377 * charset.c (Fcharset_after): Fix typos.
1378
615a3b8d 13792011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1380
17e845af
PE
1381 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1382 Otherwise, valgrind does not work on some platforms.
1383 Problem reported by Andreas Schwab in
6a0bf43d
PE
1384 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1385 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1386 is set, removing the need for VIRT_ADDRESS_VARIES.
1387 (PURE_P): Use a more-efficient implementation that needs just one
1388 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1389 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1390 to 4 (xorl, subq, cmpq, setbe).
1391 * alloc.c (pure): Always extern now, since that's the
1392 VIRT_ADDR_VARIES behavior.
1393 (PURE_POINTER_P): Use a single comparison, not two, for
1394 consistency with the new puresize.h.
1395 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1396 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1397 Remove VIRT_ADDR_VARIES no longer needed.
1398
f8fe6f96
EZ
13992011-11-19 Eli Zaretskii <eliz@gnu.org>
1400
1401 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1402 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1403 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1404 behave as if the cursor position were at the window margin.
1405
1406 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1407 and the cursor position is out of bounds, behave as if the cursor
1408 position were at the window margin. (Bug#10075)
1409
df05a53c
CY
14102011-11-18 Chong Yidong <cyd@gnu.org>
1411
1412 * window.c (Fwindow_combination_limit): Make first argument
1413 non-optional, since it is meaningless for live windows like the
1414 selected window.
1415
2071918e
DA
14162011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1417
1418 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1419
b50a28de
SM
14202011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1421
1422 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1423 (graft_intervals_into_buffer): Simplify.
1424
015137db
EZ
14252011-11-18 Eli Zaretskii <eliz@gnu.org>
1426
1427 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1428 hash values of the two rows.
1429 (copy_row_except_pointers): Preserve the used[] arrays and the
1430 hash values of the two rows. (Bug#10035)
68c95424 1431 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1432
1433 * xdisp.c (row_hash): New function, body extracted from
1434 compute_line_metrics.
1435 (compute_line_metrics): Call row_hash, instead of computing the
1436 hash code inline.
1437
1438 * dispnew.c (verify_row_hash): Call row_hash for computing the
1439 hash code of a row, instead of duplicating code from xdisp.c.
1440
1441 * dispextern.h (row_hash): Add prototype.
1442
a2addb04
TH
14432011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1444
1445 * frame.c (delete_frame): Don't delete the terminal when the last
1446 X frame is closed if emacs is built with GTK toolkit.
1447
df85d315
JB
14482011-11-17 Juanma Barranquero <lekktu@gmail.com>
1449
1450 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1451
a0c2d0ae
MR
14522011-11-17 Martin Rudalics <rudalics@gmx.at>
1453
1454 * window.c (Vwindow_splits): Rename to
1455 Vwindow_combination_resize. Suggested by Juri Linkov.
1456 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1457 of Vwindow_splits.
1458
58179cce
JB
14592011-11-16 Juanma Barranquero <lekktu@gmail.com>
1460
7877f373
JB
1461 * nsfns.m (Fns_font_name):
1462 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1463
b6f67890
MR
14642011-11-16 Martin Rudalics <rudalics@gmx.at>
1465
1466 * window.h (window): Rename slot "nest" to "combination_limit".
1467 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1468 (Fset_window_nest): Rename to Fset_window_combination_limit.
1469 (Vwindow_nest): Rename to Vwindow_combination_limit.
1470 (recombine_windows, make_parent_window, make_window)
1471 (Fsplit_window_internal, saved_window)
1472 (Fset_window_configuration, save_window_save): Rename all
1473 occurrences of window_nest to window_combination_limit.
1474
c7015153
JB
14752011-11-15 Juanma Barranquero <lekktu@gmail.com>
1476
1477 * image.c (imagemagick_load_image): Fix typo.
1478
322ad6ec
EZ
14792011-11-14 Eli Zaretskii <eliz@gnu.org>
1480
1481 * xdisp.c (display_line): Move the call to
1482 highlight_trailing_whitespace before the call to
1483 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1484 faces of all the glyphs to compute ROW's hash value.
1485 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1486
f067b8ec
JB
14872011-11-14 Juanma Barranquero <lekktu@gmail.com>
1488
1489 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1490 just return (bug#10044).
1491
1e5b2111
EZ
14922011-11-12 Eli Zaretskii <eliz@gnu.org>
1493
7ef3cbd5
EZ
1494 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1495 with user-defined heap size. Bump the default size of the temacs
1496 heap to 27MB, to avoid memory warning when running temacs.
1497 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1498
1e5b2111
EZ
1499 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1500 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1501 (verify_row_hash) [XASSERTS]: New function.
1502 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1503 that the hash value of glyph rows is correct.
1e5b2111 1504
89d61221
MR
15052011-11-12 Martin Rudalics <rudalics@gmx.at>
1506
1507 * window.h (window): Remove splits slot.
1508 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1509 (Fdelete_other_windows_internal, make_parent_window)
1510 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1511 (Fset_window_configuration, save_window_save): Don't deal with
1512 split status of windows.
1513 (saved_window): Remove splits slot.
1514 (Vwindow_splits): Rewrite doc-string.
1515
97f18cc8
JD
15162011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1517
1518 * xfns.c (unwind_create_frame):
1519 * nsfns.m (unwind_create_frame):
1520 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1521 Vframe_list (Bug#9999).
1522
22a648b4
DA
15232011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1524
0b381c7e 1525 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1526
659afede
KH
15272011-11-11 Kenichi Handa <handa@m17n.org>
1528
1529 * callproc.c (Fcall_process): Set the member dst_multibyte of
1530 process_coding.
1531
9ac0394b
KH
15322011-11-11 Johan Bockgård <bojohan@gnu.org>
1533
1534 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1535 avoid a crash (bug#9496).
1536
2fbdc249
CY
15372011-11-09 Chong Yidong <cyd@gnu.org>
1538
1539 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1540 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1541
ac6b1f81
PE
15422011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1543
1544 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1545
09db192c
PE
15462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 Avoid some portability problems by eschewing 'extern inline' functions.
1549 The trivial performance wins aren't worth the portability hassles; see
1550 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1551 et seq.
1552 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1553 (window_box_width, window_box_left, window_box_left_offset)
1554 (window_box_right, window_box_right_offset): Undo previous change,
1555 by removing the "extern"s.
1556 * intervals.c (adjust_intervals_for_insertion)
1557 (adjust_intervals_for_deletion): Undo previous change,
1558 making these static again.
1559 (offset_intervals, temp_set_point_both, temp_set_point)
1560 (copy_intervals_to_string): No longer inline.
1561 * xdisp.c (window_text_bottom_y, window_box_width)
1562 (window_box_height, window_box_left_offset)
1563 (window_box_right_offset, window_box_left, window_box_right)
1564 (window_box): No longer inline.
1565
105216ed
CY
15662011-11-08 Chong Yidong <cyd@gnu.org>
1567
1568 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1569 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1570 Signal an error if not a live window.
105216ed
CY
1571 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1572 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1573
ae9e237f
JB
15742011-11-07 Juanma Barranquero <lekktu@gmail.com>
1575
1576 * lisp.h (syms_of_abbrev): Remove declaration.
1577 Reported by CHENG Gao <chenggao@royau.me>.
1578
c7aa8333
EZ
15792011-11-07 Eli Zaretskii <eliz@gnu.org>
1580
1581 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1582 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1583 of temacs in GUI mode.
1584
be7f5545
MR
15852011-11-07 Martin Rudalics <rudalics@gmx.at>
1586
1587 * window.h: Declare delete_all_child_windows instead of
1588 delete_all_subwindows.
1589 * window.c (Fwindow_nest, Fset_window_nest)
1590 (Fset_window_new_total, Fset_window_new_normal)
1591 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1592 (delete_all_subwindows): Rename to delete_all_child_windows.
1593 (Fdelete_other_windows_internal, Fset_window_configuration):
1594 Call delete_all_child_windows instead of delete_all_subwindows.
1595 * frame.c (delete_frame): Call delete_all_child_windows instead
1596 of delete_all_subwindows.
1597
ca78dc43
PE
15982011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1599
1600 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1601 This is also needed for porting to any host where GC_MARK_STACK is
1602 not GC_MAKE_GCPROS_NOOPS.
1603 (which_symbols): Use it.
1604
a0241d01
KH
16052011-11-07 Kenichi Handa <handa@m17n.org>
1606
1607 * coding.c (coding_set_destination): Check coding->src_pos only
1608 when coding->src_object is a buffer (bug#9910).
1609
1610 * process.c (send_process): Set the member src_multibyte of coding
1611 to 0 (bug#9911) when sending a unibyte text.
1612
1613 * callproc.c (Fcall_process): Set the member src_multibyte of
1614 process_coding to 0 (bug#9912).
1615
a64bfdfa 16162011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1617
1618 * xmenu.c (cleanup_widget_value_tree): New function.
1619 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1620 calling free_menubar_widget_value_tree directly (Bug#9830).
1621
cb41b32a
PE
16222011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1623
1624 Fix some portability problems with 'inline'.
1625 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1626 (window_box_width, window_box_left, window_box_left_offset)
1627 (window_box_right, window_box_right_offset): Declare extern.
1628 Otherwise, these inline functions do not conform to C99 and
1629 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1630 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1631 * intervals.c (adjust_intervals_for_insertion)
1632 (adjust_intervals_for_deletion): Now extern, because otherwise the
1633 extern inline functions 'offset_intervals' couldn't refer to it.
1634 (static_offset_intervals): Remove.
1635 (offset_intervals): Rewrite using the old contents of
1636 static_offset_intervals. The old version didn't conform to C99
1637 because an extern inline function contained a reference to an
1638 identifier with static linkage.
1639
b7041366
AS
16402011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1641
1642 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1643 GC.
1644
88a37c4d
EZ
16452011-11-06 Eli Zaretskii <eliz@gnu.org>
1646
1647 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1648 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1649 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1650 return Qleft_to_right.
1651
49745b39
CY
16522011-11-06 Chong Yidong <cyd@gnu.org>
1653
1654 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1655 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1656 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1657 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1658 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1659 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1660 (Fwindow_vscroll): Doc fix.
1661 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1662 argument, since it makes no sense to pass a live window and for
1663 consistency with window-child.
1664
1f05cd82
CS
16652011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1666
1667 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1668 support MSVC.
1669
22610910
JR
16702011-11-05 Jason Rumney <jasonr@gnu.org>
1671
1672 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1673 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1674 fonts (Bug#6029).
1675 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1676 bitwise arithmetic preventing use of unicode-sip and non-truetype
1677 opentype fonts.
1678
a06776b2
EZ
16792011-11-05 Eli Zaretskii <eliz@gnu.org>
1680
3ad924ba
EZ
1681 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1682 "emacs"-only part.
1683
a06776b2
EZ
1684 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1685 initialization code to keep similarity to xfns.c after changes
1686 from 2011-11-05.
1687
c9e7db78
JD
16882011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1689
a97f8f3f
JD
1690 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1691 (unwind_create_frame): New function (Bug#9943).
1692 (Fx_create_frame): Restructure code to be more similar to the one in
1693 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1694 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1695 Move terminal->reference_count++ just before making the frame official
1696 (Bug#9943).
1697
1698 * nsterm.m (x_free_frame_resources): New function.
1699 (x_destroy_window): Move code to x_free_frame_resources.
1700
c9e7db78 1701 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1702 (Fx_create_frame, x_create_tip_frame):
1703 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1704 official. Move initialization of image_cache_refcount and
1705 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1706
a6fc3b5c
EZ
17072011-11-05 Eli Zaretskii <eliz@gnu.org>
1708
1709 Support MSVC build with newer versions of Visual Studio.
1710 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1711 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1712 nt/gmake.defs.
1713
1714 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1715 which are not supported by MSVC.
1716 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1717 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1718 bitfields.
1719 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1720 types in bitfields.
1721 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1722
1723 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1724
58179cce 17252011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1726
1727 Support MSVC build with newer versions of Visual Studio.
1728 * w32.c: Don't include w32api.h for MSVC.
1729 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1730
1731 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1732 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1733 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1734 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1735 e_* cousins.
1736 (alloca) [_MSC_VER]: Define to _alloca.
1737
1738 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1739
1740 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1741
a58c13ed
EZ
17422011-11-04 Eli Zaretskii <eliz@gnu.org>
1743
1744 * xdisp.c (note_mouse_highlight): If either of
1745 previous/next-single-property-change returns nil, treat that as
1746 the beginning or the end of the buffer. (Bug#9955)
1747
fe0b6370
JD
17482011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1749
a58c13ed 1750 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1751 label is not null (Bug#9951).
1752 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1753 may be NULL.
1754
89bd5ee1
EZ
17552011-11-04 Eli Zaretskii <eliz@gnu.org>
1756
1757 * window.c (Fwindow_body_size): Mention in the doc string that the
1758 return value is in frame's canonical units. (Bug#9949)
1759
84c3edb9
EZ
17602011-11-03 Eli Zaretskii <eliz@gnu.org>
1761
4e2fb5c7
EZ
1762 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1763
84c3edb9 1764 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1765 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1766 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1767
bc17a887
EZ
17682011-11-01 Eli Zaretskii <eliz@gnu.org>
1769
1770 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1771 Don't stop backward scan on the continuation glyph, even though
1772 its CHARPOS is positive.
6d5eb5b0
SM
1773 (mouse_face_from_buffer_pos, note_mouse_highlight):
1774 Rename cover_string to disp_string.
bc17a887 1775
4ee88440
MR
17762011-11-01 Martin Rudalics <rudalics@gmx.at>
1777
1778 * window.c (temp_output_buffer_show): Don't use
1779 Vtemp_buffer_show_specifiers.
1780 (Vtemp_buffer_show_specifiers): Remove unused variable.
1781
c2ff3c02
EZ
17822011-10-30 Eli Zaretskii <eliz@gnu.org>
1783
1784 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1785 past the beginning of the current glyph matrix.
1786
58179cce 17872011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1788
1789 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1790 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1791 HAVE_GTK3 (Bug#9869).
b77a6a7f 1792
3b574623
JD
1793 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1794 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1795
b77a6a7f
JD
1796 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1797
1798 * xterm.c: Declare x_handle_net_wm_state to return int.
1799 (handle_one_xevent): Check if we are iconified but don't have
1800 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1801 (get_current_wm_state): Return non-zero if not hidden,
1802 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1803 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1804 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1805 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1806
196e41e4
PE
18072011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1808
1809 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1810 so that this new function doesn't get optimized away by a
1811 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1812
021f2e1a
AS
18132011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1814
1815 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1816
8b058d44
EZ
18172011-10-29 Eli Zaretskii <eliz@gnu.org>
1818
1819 Fix the `xbytecode' command.
1820 * .gdbinit (xprintbytestr): New command.
b50a28de 1821 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1822 (xbytecode): Print the byte-code string as well.
1823
4452fb80
EZ
18242011-10-29 Kim Storm <storm@cua.dk>
1825
8b058d44
EZ
1826 * alloc.c (which_symbols): New function.
1827
21b72067
AS
18282011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1829
1830 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1831 line. (Bug#9903)
1832
83ed7b5c
GM
18332011-10-29 Glenn Morris <rgm@gnu.org>
1834
1835 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1836 Not clear what it was for, and it causes various bugs. (Bug#9839)
1837
5a7a728b
EZ
18382011-10-28 Eli Zaretskii <eliz@gnu.org>
1839
1840 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1841 possible random value that matches one of those tested as
1842 condition to clear the mouse face.
1843
d3d0842f
CY
18442011-10-28 Chong Yidong <cyd@gnu.org>
1845
1846 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1847
31b39d13
DN
18482011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1849
1850 * window.c (make_window): Initialize phys_cursor_on_p.
1851
9aba6043
SM
18522011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1853
1854 * lisp.h (struct Lisp_Symbol): Update comments.
1855
c20992f4
JB
18562011-10-28 Juanma Barranquero <lekktu@gmail.com>
1857
1858 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1859
db4f02f2
EZ
18602011-10-28 Eli Zaretskii <eliz@gnu.org>
1861
1862 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1863 <oslsachem@gmail.com> for helping to debug this.
1864
1865 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1866 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1867 (g_b_init_get_glyph_outline_w): New static variables.
1868 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1869 (GetGlyphOutlineW_Proc): New typedefs.
1870 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1871 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1872 New functions.
1873 (w32font_open_internal, compute_metrics):
1874 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1875 instead of calling the "wide" APIs directly.
1876
1877 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1878
1879 * w32.h (syms_of_w32font): Add prototype.
1880
87e68db4
JB
18812011-10-27 Juanma Barranquero <lekktu@gmail.com>
1882
1883 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1884 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1885 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1886 (Fmove_to_window_line): Doc fix.
1887
435c1d67
CY
18882011-10-27 Chong Yidong <cyd@gnu.org>
1889
1890 * process.c (make_process): Set gnutls_state to NULL.
1891
1892 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1893 non-NULL, regardless of GNUTLS_INITSTAGE.
1894 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1895 an error. Set process slots as soon as we allocate them.
1896
1897 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1898
9c6c6f49
CY
18992011-10-27 Chong Yidong <cyd@gnu.org>
1900
9aba6043
SM
1901 * gnutls.c (emacs_gnutls_deinit): New function.
1902 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1903 (Fgnutls_deinit, Fgnutls_boot): Use it.
1904
1905 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1906 (deactivate_process): Call emacs_gnutls_deinit.
1907
657d08d3
JB
19082011-10-27 Juanma Barranquero <lekktu@gmail.com>
1909
1910 * image.c (x_create_x_image_and_pixmap):
1911 * w32.c (sys_rename, w32_delayed_load):
1912 * w32font.c (fill_in_logfont):
1913 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1914
5430d399
JB
19152011-10-26 Juanma Barranquero <lekktu@gmail.com>
1916
1917 * w32fns.c (w32_default_color_map): New function,
1918 extracted from Fw32_default_color_map.
a7ef684b 1919 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1920
fe0055fa
PE
19212011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1922
1923 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1924
e6346438
SM
19252011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1926
1927 * keyboard.c (test_undefined): New function (bug#9751).
1928 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1929
e112cc37
ET
19302011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1931
1932 * sysdep.c (init_sys_modes): Fix the check for the controlling
1933 terminal (Bug#6649).
1934
7b5d6677
EZ
19352011-10-20 Eli Zaretskii <eliz@gnu.org>
1936
1937 * dispextern.h (struct bidi_it): New member next_en_type.
1938
1939 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1940 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1941 current character, check also for next_en_type being WEAK_EN.
1942 (bidi_resolve_weak): Don't enter the expensive loop if the current
1943 position is before next_en_pos. Record the bidi type of the first
1944 non-ET, non-BN character we find, in addition to its position.
1945 (bidi_level_of_next_char): Invalidate next_en_type when
1946 next_en_pos is over-stepped.
1947
7da0b018
PE
19482011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1951 * editfns.c: Rewrite current-time-zone so that it invokes
1952 the equivalent of (format-time-string "%Z") to get the time zone name.
1953 This fixes a bug when the time zone name contains characters that
1954 need converting from the system time locale to Emacs internal format.
1955 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1956 that patch fixed format-time-string to do the conversion, but
1957 I forgot to fix current-time-zone.
1958 (format_time_string): New function, containing most of
1959 what Fformat_time_string used to contain.
1960 (Fformat_time_string): Rewrite in terms of format_time_string.
1961 This doesn't change this function's behavior.
1962 (current-time-zone): Rewrite to use format_time_string.
1963 This fixes the bug reported by Michael Schierl in
1964 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1965 Jason Rumney's 2007-06-07 change worked around this bug, but
1966 didn't fix it.
1967 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1968
8547b010
EZ
19692011-10-19 Eli Zaretskii <eliz@gnu.org>
1970
1971 * xdisp.c (start_display): If the character at POS is displayed
1972 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1973 (try_window_reusing_current_matrix): If a line ends in a display
1974 vector or the next line starts in a display vector, continue
1975 redrawing the window even though the character position of
1976 start_row was reached.
8547b010
EZ
1977 (Bug#9771, part 2)
1978
4e948d15
CY
19792011-10-18 Chong Yidong <cyd@gnu.org>
1980
1981 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1982 with nobreak-char-display too.
1983
4787455f
EZ
19842011-10-18 Eli Zaretskii <eliz@gnu.org>
1985
1986 Fix part 3 of bug#9771.
1987 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1988 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1989 non-neutral characters if the current character is a paragraph
1990 separator (a.k.a. Newline). This avoids running the same
1991 expensive loop twice, once when we consume the preceding newline
1992 and the other time when the line actually needs to be displayed.
1993 Avoid the loop when we see neutrals on the base embedding level
1994 following a character whose directionality is the same as the
1995 paragraph's. This avoids running the expensive loop when a line
1996 ends in a long sequence of neutrals, like control characters.
1997 Add assertion against STRONG_AL type. Slightly rearrange code
1998 that determines the type of a neutral given the first non-neutral
1999 that follows it.
2000 (bidi_level_of_next_char): Set next_en_pos to zero when
2001 invalidating its info.
2002
2c91f553
EZ
20032011-10-17 Eli Zaretskii <eliz@gnu.org>
2004
2005 * xdisp.c (push_display_prop): Determine whether to record string
2006 or buffer position by IT->string, not by IT->method. Allow
2007 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
2008 (move_it_vertically_backward): Don't look for character position
2009 immediately after the newline when in a continuation line.
2010 (Bug#9771, part 1)
2c91f553 2011
c7b08b0d
MR
20122011-10-15 Martin Rudalics <rudalics@gmx.at>
2013
2014 * window.c (coordinates_in_window): Rewrite and delabelize
2015 vertical border check. (Bug#5357) (Bug#9618)
2016
6b02f655
SM
20172011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
2018
2019 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
2020 errors in XSetWindowBorder (bug#9310).
2021
81d40c92
DA
20222011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
2023
2024 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
2025 avoid crash when xmalloc overrun checking is enabled.
2026
d4172c3b
EZ
20272011-10-13 Eli Zaretskii <eliz@gnu.org>
2028
2029 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
2030 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
2031 cursor motion with <left> and <right> arrow keys.
2032
2033 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
2034 some callers set that themselves.
2035
b00eea75
EZ
20362011-10-12 Eli Zaretskii <eliz@gnu.org>
2037
2038 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
2039 display string and the previous row comes from the same string and
2040 is empty. (Bug#9739) (Bug#9738)
2041
8fe012c4
SM
20422011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
2043
2044 * doc.c (get_doc_string): Encode file name (bug#9735).
2045
0074aef2
EZ
20462011-10-12 Eli Zaretskii <eliz@gnu.org>
2047
79beb178
EZ
2048 * bidi.c (bidi_level_of_next_char):
2049 * xdisp.c (get_visually_first_element): Remove old incorrect
2050 comments regarding the Unicode Line Separator character.
2051
0074aef2
EZ
2052 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
2053
6e4b3fbe
DA
20542011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
2055
2056 * alloc.c (Fgc_status): Do not access beyond zombies array
2057 boundary if nzombies > MAX_ZOMBIES.
2058 * alloc.c (dump_zombies): Add missing format specifier.
2059
0324f3af
PE
20602011-10-12 Paul Eggert <eggert@cs.ucla.edu>
2061
b5525cac
PE
2062 * xdisp.c (set_cursor_from_row): Simplify conditionals,
2063 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
2064
0324f3af
PE
2065 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
2066 Some packages use them to denote characters with modifiers.
2067
e9b5f888
AS
20682011-10-11 Andreas Schwab <schwab@linux-m68k.org>
2069
2070 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
2071 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
2072 matching a pp-number. Rename parameter var to var1.
2073
127827c0
SM
20742011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
2075
2076 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
2077
c8fd3bd0
GM
20782011-10-08 Glenn Morris <rgm@gnu.org>
2079
2080 * callint.c (Fcall_interactively): Give a more explicit error for the
2081 'c' case with a non-character input. (Bug#8479)
2082
352ec8ff
EZ
20832011-10-08 Eli Zaretskii <eliz@gnu.org>
2084
03669ccb
EZ
2085 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
2086 lines.
7061c986
EZ
2087 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
2088 lines that are hscrolled on the left.
03669ccb 2089
352ec8ff
EZ
2090 * dispnew.c (buffer_posn_from_coords): Account for a possible
2091 presence of header-line. (Bug#4426)
2092
a66cfb1c
SM
20932011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
2094
6b02f655
SM
2095 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
2096 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 2097
7c5ee88e
PE
20982011-10-07 Paul Eggert <eggert@cs.ucla.edu>
2099
2100 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
2101 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
2102 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
2103 this makes Emacs dump core during garbage collection on rare
2104 occasions. sizeof is obviously inferior to offsetof here, so
2105 stick with offsetof.
2106 (GC_POINTER_ALIGNMENT): New macro.
2107 (mark_memory): Omit 3rd (offset) arg; caller changed.
2108 Don't assume EMACS_INT alignment is the same as pointer alignment.
2109
df1bbe5b
SM
21102011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
2111
2112 * keyboard.c (read_key_sequence_remapped): New var.
2113 (read_key_sequence): Compute remapping in the right buffer.
2114 (command_loop_1): Use read_key_sequence's remapping directly.
2115
51553db6
SM
21162011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
2117
32c1fffd
SM
2118 * dired.c (file_name_completion): Don't expand file name.
2119 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
2120 before checking file name handler.
2121
51553db6
SM
2122 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
2123 they've been requested explicitly (bug#9591).
2124
b6bd1599 21252011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
2126
2127 * keymap.c (Fsingle_key_description): Use make_specified_string
2128 instead of build_string to build string from push_key_description.
2129 (Bug#5193)
2130
f701dc2a
PE
21312011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2132
4222c55d
PE
2133 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
2134 This fixes a Y2038 bug on 64-bit hosts.
2135 * buffer.c (reset_buffer):
2136 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
2137 (Fclear_buffer_auto_save_failure):
2138 Use 0, not -1, to represent an unset failure time, since time_t
2139 might not be signed.
2140
f701dc2a
PE
2141 Remove dependency on glibc malloc internals.
2142 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2143 Move back here from lisp.h, but with their new implementations.
2144 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2145 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
2146 * charset.c (charset_table_init): New static var.
2147 (syms_of_charset): Use it instead of xmalloc. This removes a
2148 dependency on glibc malloc internals. See Eli Zaretskii's comment in
2149 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2150 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2151 Move back to alloc.c.
2152 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2153 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2154
9ceebf39
JD
21552011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2156
2157 * nsterm.m (windowDidResize): Call x_set_window_size only when
2158 ns_in_resize is true. Otherwise set pixelwidth/height and
2159 call change_frame_size (Bug#9628).
2160
cb993c58
PE
21612011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2162
3930c88b
PE
2163 Port --enable-checking=all to Fedora 14 x86-64.
2164 * charset.c (syms_of_charset): Also account for glibc malloc's
2165 internal overhead when calculating the initial malloc maximum.
2166
cb993c58
PE
2167 Port --enable-checking=all to Fedora 14 x86.
2168 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2169 Move to lisp.h.
2170 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2171 (overrun_check_realloc, overrun_check_free):
2172 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2173 That way, xmalloc returns a properly-aligned pointer even if
2174 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2175 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2176 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2177 into account when calculating the initial malloc maximum.
2178 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2179 Move here from alloc.c, so that charset.c can use it too.
2180 Properly align; the old code wasn't right for common 32-bit hosts
2181 when configured with --enable-checking=all.
2182 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2183 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2184
31bed486
EZ
21852011-09-29 Eli Zaretskii <eliz@gnu.org>
2186
04c70788 2187 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2188 use EDOM.
2189
fbcaa2f3
EZ
21902011-09-28 Eli Zaretskii <eliz@gnu.org>
2191
2192 * xdisp.c (compute_display_string_end): If there's no display
2193 string at CHARPOS, return -1.
2194
2195 * bidi.c (bidi_fetch_char): When compute_display_string_end
2196 returns a negative value, treat the character as a normal
2197 character not covered by a display string. (Bug#9624)
2198
a239d4e9
JB
21992011-09-28 Juanma Barranquero <lekktu@gmail.com>
2200
2201 * lread.c (Fread_from_string): Fix typo in docstring.
2202
88652fd5
EZ
22032011-09-27 Eli Zaretskii <eliz@gnu.org>
2204
2205 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2206 newline, reseat the iterator instead of bidi-iterating there one
2207 character at a time. (Bug#9610)
32c1fffd
SM
2208 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2209 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2210
ed497dd4
AS
22112011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2212
2213 * lread.c (readevalloop): Use correct code for NBSP.
2214 (read1): Likewise. (Bug#9608)
2215
b2bf61aa
MA
22162011-09-25 Michael Albinus <michael.albinus@gmx.de>
2217
2218 * dbusbind.c (Fdbus_register_signal): When service is not
2219 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2220
32bbb17c
GM
22212011-09-25 Glenn Morris <rgm@gnu.org>
2222
2223 * buffer.c (truncate-lines): Doc fix.
2224
94e0933e
CY
22252011-09-24 Chong Yidong <cyd@stupidchicken.com>
2226
2227 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2228 (Fset_window_next_buffers): Doc fix.
2229
cddde921
GM
22302011-09-24 Glenn Morris <rgm@gnu.org>
2231
2232 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2233
1260aef1
PE
22342011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2235
25b4bfa0
PE
2236 Fix minor problems found by static checking.
2237 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2238 * indent.c (Fvertical_motion): Fix == vs = typo.
2239
e3cbd34b
EZ
22402011-09-24 Eli Zaretskii <eliz@gnu.org>
2241
a66cfb1c
SM
2242 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2243 Default value is now t. Doc fix.
6bf7006f 2244
e3cbd34b 2245 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2246 logic when moving up, not only when moving down. Fix the
e3cbd34b 2247 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2248 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2249
2250 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2251 CHARPOS is covered by a display string which includes newlines.
2252 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2253 is covered by a display string with embedded newlines.
2254
a3de0cbd
MA
22552011-09-24 Michael Albinus <michael.albinus@gmx.de>
2256
2257 * dbusbind.c (Fdbus_register_signal): Add match rule to
2258 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2259 (Fdbus_register_method, Vdbus_registered_objects_table):
2260 Fix docstring.
a3de0cbd 2261
b260039d
JM
22622011-09-24 Jim Meyering <meyering@redhat.com>
2263
32c1fffd 2264 do not ignore write error for any output size
b260039d
JM
2265 The previous change was incomplete.
2266 While it makes emacs --batch detect the vast majority of stdout
2267 write failures, errors were still ignored whenever the output size is
2268 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2269 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2270 && echo FAIL: ignored write error
2271 FAIL: ignored write error
2272 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2273 && echo FAIL: ignored write error
2274 FAIL: ignored write error
2275 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2276
8eca8a7c
AS
22772011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2278
2279 * emacs.c (Fkill_emacs): In noninteractive mode exit
2280 non-successfully if a write error occurred on stdout. (Bug#9574)
2281
3341db62
EZ
22822011-09-21 Eli Zaretskii <eliz@gnu.org>
2283
2284 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2285 the xassert test.
2286
2287 * dispextern.h (struct it): Update the comment documenting what
2288 can it->OBJECT be.
2289
8c203dbf
EZ
22902011-09-20 Eli Zaretskii <eliz@gnu.org>
2291
2292 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2293 a display string, extend search for cursor position to end of row.
2294 (find_row_edges): If the row ends in a newline from a display
2295 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2296 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2297 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2298 non-empty line. Fixes confusing cursor motion with arrow keys at
2299 the beginning of a line that starts with whitespace.
8c203dbf 2300
a4824228
LMI
23012011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2302
2303 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2304 (bug#9493).
2305
33ed493b
CY
23062011-09-18 Chong Yidong <cyd@stupidchicken.com>
2307
2308 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2309 boolean (Bug#9154).
2310
56cd55c8
EZ
23112011-09-18 Eli Zaretskii <eliz@gnu.org>
2312
2313 * xdisp.c (display_line): Record maximum and minimum buffer
2314 positions even if no glyphs were produced (e.g., by a zero-width
2315 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2316 buffer positions that will be removed from the glyph row because
2317 they don't fit.
c02dcedf
EZ
2318 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2319 column is beyond frame width: don't subtract 1 "pixel" when
2320 computing width of the stretch.
3e62b7e0
EZ
2321 (reseat_at_next_visible_line_start): Undo the change made on
2322 2011-09-17 that saved paragraph information and restored it after
2323 the call to `reseat'. (Bug#9545)
56cd55c8 2324
5ed99d36 23252011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2326
2327 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2328 and turn window cursor on if cleared (Bug#9415).
2329
5ed99d36 23302011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2331
2332 * search.c (boyer_moore): Take unibyte characters from pattern
2333 literally. (Bug#9458)
2334
9bade7b2
EZ
23352011-09-18 Eli Zaretskii <eliz@gnu.org>
2336
2337 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2338
e5e9d610
PE
23392011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2340
87e4427a
PE
2341 Fix minor problem found by static checking.
2342 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2343 initialized, to pacify gcc -Wuninitialized.
2344
e5e9d610
PE
2345 * fileio.c: Report proper errno when syscall falls.
2346 (Finsert_file_contents): Save and restore errno,
2347 so that report_file_error outputs the correct diagnostic.
2348 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2349
a1674f0b
EZ
23502011-09-18 Eli Zaretskii <eliz@gnu.org>
2351
2352 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2353
fbfb6dd4
EZ
23542011-09-17 Eli Zaretskii <eliz@gnu.org>
2355
2356 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2357 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2358
bb187662
EZ
23592011-09-17 Eli Zaretskii <eliz@gnu.org>
2360
1137e8b8 2361 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2362 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2363
2364 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2365 (bidi_find_paragraph_start): Search back for paragraph beginning
2366 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2367 (bidi_move_to_visually_next): Only trigger paragraph-related
2368 computations when the last character is a newline or at EOB, not
2369 just any NEUTRAL_B. (Bug#9470)
2370
bb187662
EZ
2371 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2372 truncated lines if point is covered by a display string. (Bug#9524)
2373
2e621251
PE
23742011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2375
2376 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2377 (cons_to_x_long): New function.
2378 (lisp_data_to_selection_data): Use it. Correct the test for
2379 short-versus-long data; it was negated. Break out of vector
2380 loop, for efficiency, when a long datum is discovered.
2381
91a15bc6
SM
23822011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2383
2384 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2385
b41c3a35
EZ
23862011-09-16 Eli Zaretskii <eliz@gnu.org>
2387
2388 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2389 GCC PR/17406) by declaring this function with external scope.
2390
7812ba2d
PE
23912011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2392
2393 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2394 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2395
cf7edc2a
AS
23962011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2397
2398 * editfns.c (Fformat): Correctly handle text properties on "%%".
2399
bd01620e
EZ
24002011-09-15 Eli Zaretskii <eliz@gnu.org>
2401
2402 * xterm.c (x_draw_composite_glyph_string_foreground):
2403 * w32term.c (x_draw_composite_glyph_string_foreground):
2404 * term.c (encode_terminal_code):
2405 * composite.c (composition_update_it, get_composition_id):
2406 * xdisp.c (get_next_display_element)
2407 (fill_composite_glyph_string): Add comments about special meaning
2408 of TAB characters in a composition.
2409
a02719a3
PE
24102011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2411
2412 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2413 This occurs when processing a multibyte format.
2414 Problem reported by Wolfgang Jenker.
a02719a3 2415
72589a3c
JB
24162011-09-15 Johan Bockgård <bojohan@gnu.org>
2417
2418 * xdisp.c (try_cursor_movement): Only check for exact match if
2419 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2420
1c14176c
PE
24212011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2422
2423 Remove unused external symbols.
2424 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2425 * xdisp.c (calc_pixel_width_or_height): Now static.
2426 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2427 * indent.c (check_display_width):
2428 * w32term.c: Fix comment to match code.
2429 * xterm.c, xterm.h (x_catching_errors): Remove.
2430
d2eea5b5
PE
24312011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2432
2433 * xselect.c: Use signed conversions more consistently (Bug#9498).
2434 (selection_data_to_lisp_data): Assume incoming selection data are
2435 signed integers, not unsigned. This is to be consistent with
2436 outgoing selection data, which was modified to use signed integers
2437 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2438 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2439 expects long, not unsigned long.
2440
46888499
EZ
24412011-09-14 Eli Zaretskii <eliz@gnu.org>
2442
2443 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2444 computation of loop end. Reported by Johan Bockgård
2445 <bojohan@gnu.org>.
2446
ef8ef9fb
CY
24472011-09-13 Chong Yidong <cyd@stupidchicken.com>
2448
2449 * frame.c (Fother_visible_frames_p): Function deleted.
2450
fa819fed
EZ
24512011-09-12 Eli Zaretskii <eliz@gnu.org>
2452
2453 * indent.c (compute_motion): Process display vector front to back
2454 rather than the other way around. (Bug#2496)
2455
2ba8e008
SM
24562011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2457
2458 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2459
20f53c69
CY
24602011-09-11 Chong Yidong <cyd@stupidchicken.com>
2461
2462 * minibuf.c (Fread_from_minibuffer): Doc fix.
2463
d562d7a4
EZ
24642011-09-11 Eli Zaretskii <eliz@gnu.org>
2465
2466 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2467 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2468
1c4d7f3d
LMI
24692011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2470
2471 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2472 value for non-existent files.
2473
b885bf36
EZ
24742011-09-11 Eli Zaretskii <eliz@gnu.org>
2475
2476 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2477 set its "size" to -1. This will set the modtime_size field of
2478 the corresponding buffer to -1, which is what
2479 verify-visited-file-modtime expects for files that do not exist.
2480 (Bug#9139)
2481
6612f0bf
PE
24822011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2483
2484 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2485 here ...
2486 * lisp.h: ... from here. push_key_description is no longer
2487 defined in keyboard.c, so its declaration should not be in
2488 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2489 logically belongs with push_key_description.
2490
dfb3f755
PE
24912011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2492
2493 * buffer.h: Include <sys/types.h> instead of <time.h>.
2494 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2495 Problem reported by Herbert J. Skuhra.
2496
3134906c
LMI
24972011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2498
2499 * xml.c (parse_region): Make the parsing work for
2500 non-comment-starting XML files again (bug#9144).
2501
8d903f4e
AS
25022011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2503
2504 * image.c (gif_load): Fix calculation of bottom and right corner.
2505 (Bug#9468)
2506
80ad64f4
EZ
25072011-09-10 Eli Zaretskii <eliz@gnu.org>
2508
2509 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2510 redisplay in small windows.
2511
208a048d
EZ
25122011-09-09 Eli Zaretskii <eliz@gnu.org>
2513
2514 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2515
9b1c252e
MR
25162011-09-08 Martin Rudalics <rudalics@gmx.at>
2517
2518 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2519 Operate on live windows only.
2520
2949f33b
JB
25212011-09-08 Juanma Barranquero <lekktu@gmail.com>
2522
2523 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2524
e08dcafd
EZ
25252011-09-07 Eli Zaretskii <eliz@gnu.org>
2526
2527 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2528 only under bidi iteration.
2529
115b96bd
JD
25302011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2531
2532 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2533
c8199d0f
PE
25342011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2535
2536 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2537 Without this fix, the command to link temacs failed due to an
2538 undefined symbol __builtin_isnan. This is because
2539 /usr/include/iso/math_c99.h #defines isnan(x) to
2540 __builtin_isnan(x), but the bundled gcc, which identifies itself
2541 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2542 a __builtin_isnan.
2543 * floatfns.c (isnan): #undef, and then #define to a clone of
2544 what's in data.c.
2545 (Fisnan): Always define, since it's always available now.
2546 (syms_of_floatfns): Always define isnan at the Lisp level.
2547
e39b275c 25482011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2549
2550 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2551
b2db44d9 25522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2553
f4af5137 2554 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2555 The previous code assumed that file offsets (off_t values) fit in
2556 EMACS_INT variables, which is not true on typical 32-bit hosts.
2557 The code messed up by falsely reporting buffer overflow in cases
2558 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2559 when "big" contains more than 2**29 bytes, even though this
2560 inserts just one byte and does not overflow the buffer.
2561 (Finsert_file_contents): Store file offsets as off_t
2562 values, not as EMACS_INT values. Check for overflow when
2563 converting between EMACS_INT and off_t. When checking for
2564 buffer overflow or for overlap, take the offsets into account.
2565 Don't use EMACS_INT for small values where int suffices.
2566 When checking for overlap, fix a typo: ZV was used where
2567 ZV_BYTE was intended.
2568 (Fwrite_region): Don't assume off_t fits into 'long'.
2569 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2570
ecfc0a49
MA
25712011-09-05 Michael Albinus <michael.albinus@gmx.de>
2572
2573 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2574
6511acf2 25752011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2576
0999621a 2577 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2578
2579 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2580 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2581 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2582 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2583 (modify_event_symbol): Do not assume that the length of
2584 name_alist_or_stem is safe to alloca and fits in int.
2585 (Fexecute_extended_command): Likewise for function name and binding.
2586 (Frecursion_depth): Wrap around reliably on integer overflow.
2587 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2588 since some callers pass EMACS_INT values.
2589 (Fsingle_key_description): Don't crash if symbol name contains more
2590 than MAX_ALLOCA bytes.
2591 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2592 (get_minibuffer): Arg is now EMACS_INT, not int.
2593 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2594 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2595 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2596
2be7d702
PE
2597 * dbusbind.c (signature_cat): New function.
2598 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2599 Do not overrun buffer; instead, report string overflow.
2600
9d1df220
PE
2601 * dispnew.c (add_window_display_history): Don't overrun buffer.
2602 Truncate instead; this is OK since it's just a log.
2603
33ef5c64
PE
2604 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2605 even if the time zone offset is outlandishly large.
2606 Don't mishandle offset == INT_MIN.
2607
66c6fdd5
PE
2608 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2609 when creating daemon; the previous buffer-overflow check was incorrect.
2610
d749b01b
PE
2611 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2612 which has the guts of the old verror function.
2613
b5cd1905
PE
2614 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2615 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2616
6e1a67fb
PE
2617 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2618 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2619 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2620 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2621 length of string rather than counting it via multiple sprintfs;
2622 that's simpler and more reliable.
c21721cc
PE
2623 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2624 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2625 sprintf, in case result does not fit in int.
2626
c57b67fc
PE
2627 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2628 (fontset_from_font): Print it.
2629
8a401434
PE
2630 * frame.c (tty_frame_count): Now printmax_t, not int.
2631 (make_terminal_frame, set_term_frame_name): Print it.
2632 (x_report_frame_params): In X, window IDs are unsigned long,
2633 not signed long, so print them as unsigned.
2634 (validate_x_resource_name): Check for implausibly long names,
2635 and don't assume name length fits in 'int'.
2636 (x_get_resource_string): Don't blindly alloca invocation name;
2637 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2638 not fit in int.
2639
6e1a67fb
PE
2640 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2641 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2642 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2643
0df02bf3
PE
2644 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2645 Use esprintf, not sprintf, in case result does not fit in int.
2646
48e30793
PE
2647 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2648 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2649 it as a large positive number.
2650 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2651 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2652
a66ff6d8
PE
2653 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2654 in case result does not fit in int.
2655
aca216ff
PE
2656 * print.c (float_to_string): Detect width overflow more reliably.
2657 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2658 buffer overrun. Don't assume list length fits in 'int'. Treat
2659 print length of 0 as 0, not as infinity; to be consistent with other
2660 uses of print length in this function. Don't overflow print length
2661 index. Don't assume hash table size fits in 'long', or that
2662 vectorlike size fits in 'unsigned long'.
2663
31c286f7
PE
2664 * process.c (make_process): Use printmax_t, not int, to format
2665 process-name gensyms.
2666
55e5faa1
PE
2667 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2668
80f2e268
PE
2669 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2670 to avoid potential buffer overrun.
2671
670741ab
PE
2672 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2673 if X resource line is longer than 512 bytes.
2674
b7163a50
PE
2675 * xfns.c (x_window): Make sprintf buffer a bit bigger
2676 to avoid potential buffer overrun.
2677
ae58ff1f
PE
2678 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2679
c43c8a6a
PE
2680 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2681
3f8236f4
PE
26822011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2683
53e9fe90 2684 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2685 Without these, Emacs silently mishandles large integers sometimes.
2686 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2687 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2688
6511acf2
PE
2689 * xdisp.c (try_window_id): Check Emacs fixnum range before
2690 converting to 'int'.
806add1d 2691
6511acf2 2692 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2693 Check that an Emacs fixnum is in range before assigning it to 'int'.
2694 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2695 values converted from Emacs fixnums.
2696 (Frecenter): Don't wrap around a line count if it is out of 'int'
2697 range; instead, treat it as an extreme value.
2698 (Fset_window_configuration, compare_window_configurations):
2699 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2700
6511acf2
PE
2701 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2702 that can exceed INT_MAX. Check that EMACS_INT value is in range
2703 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2704 (match_limit): Don't assume that a fixnum can fit in 'int'.
2705
6511acf2 2706 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2707 exceed INT_MAX.
2708
6511acf2 2709 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2710 (Fvertical_motion): Don't wrap around LINES values that don't fit
2711 in 'int'. Instead, treat them as extreme values. This is good
2712 enough for windows, which can't have more than INT_MAX lines anyway.
2713
fcb901a7
LMI
27142011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2715
0f2f6b6d
LMI
2716 * Require libxml/parser.h to avoid compilation warning.
2717
fcb901a7
LMI
2718 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2719
2720 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2721 since this reportedly can destroy thread storage.
2722
6e20a0d4
CY
27232011-08-30 Chong Yidong <cyd@stupidchicken.com>
2724
2725 * syntax.c (find_defun_start): Update all cache variables if
2726 exiting early (Bug#9401).
2727
148ae00e
EZ
27282011-08-30 Eli Zaretskii <eliz@gnu.org>
2729
f6cfbd8f
EZ
2730 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2731
148ae00e
EZ
2732 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2733 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2734 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2735
2736 * term.c (tty_append_glyph): New function.
2737 (produce_stretch_glyph): Static function and its prototype deleted.
2738
a66cfb1c
SM
2739 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2740 Add prototypes.
148ae00e 2741
c4a07a4c
PE
27422011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2743
2744 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2745 when checking :margin (Bug#9390).
2746 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2747 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2748 so that the name doesn't mislead. All uses changed.
2749
6bc8cd65
JB
27502011-08-28 Johan Bockgård <bojohan@gnu.org>
2751
2752 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2753 set_tty_hooks.
2754
dca4927e
EZ
27552011-08-27 Eli Zaretskii <eliz@gnu.org>
2756
2757 * xdisp.c (move_it_to): Don't bail out early when reaching
2758 position beyond to_charpos, if we are scanning backwards.
2759 (move_it_vertically_backward): When DY == 0, make sure we get to
2760 the first character in the line after the newline.
2761
f2cad773
PE
27622011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2763
2764 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2765 (ccl_driver): Do not generate an out-of-range pointer.
2766 (Fccl_execute_on_string): Remove unnecessary check for
2767 integer overflow, noted by Stefan Monnier in
2768 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2769 Remove a FIXME that didn't need fixing.
2770 Simplify the newly-introduced buffer reallocation code.
2771
0cae2cdb
JB
27722011-08-27 Juanma Barranquero <lekktu@gmail.com>
2773
2774 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2775
5fc295a4 27762011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2777
70c60eb2 2778 Integer and memory overflow issues (Bug#9196).
726e0ab1 2779
d31850da
PE
2780 * doc.c (get_doc_string): Rework so that
2781 get_doc_string_buffer_size is the actual buffer size, rather than
2782 being 1 less than the actual buffer size; this makes xpalloc more
2783 convenient.
2784
a69fbedb
PE
2785 * image.c (x_allocate_bitmap_record, cache_image):
2786 * xselect.c (Fx_register_dnd_atom):
2787 Simplify previous changes by using xpalloc.
2788
fe5c5d37
PE
2789 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2790 since either will do and ptrdiff_t is convenient with xpalloc.
2791
0065d054
PE
2792 * charset.c (charset_table_size)
2793 (struct charset_sort_data.priority): Now ptrdiff_t.
2794 (charset_compare): Don't overflow if priorities differ greatly.
2795 (Fsort_charsets): Don't assume list length fits in int.
2796 Check for size-calculation overflow when allocating sort data.
2797 (syms_of_charset): Allocate an initial charset table that is
2798 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2799
2800 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2801
2802 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2803 The actual value is always <= INT_MAX, and leaving it unsigned made
2804 overflow checking harder.
2805
2806 * dispextern.h (struct glyph_matrix.rows_allocated)
2807 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2808 with xpalloc. The values are still always <= INT_MAX.
2809
2810 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2811
2812 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2813 (SAFE_NALLOCA): New macro.
2814
2815 * region-cache.c (struct boundary.pos, find_cache_boundary)
2816 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2817 (set_cache_region, invalidate_region_cache)
2818 (revalidate_region_cache, know_region_cache, region_cache_forward)
2819 (region_cache_backward, pp_cache):
2820 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2821 so that ptrdiff_t * can be passed to xpalloc.
2822 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2823 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2824 (pp_cache): Don't assume cache_len fits in int.
2825 * region-cache.h: Adjust extern decls to match.
2826
2827 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2828 EMACS_INT, since either will do, for xpalloc.
2829
2830 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2831 (xnmalloc, xnrealloc, xpalloc): New functions.
2832
726e0ab1
PE
2833 * bidi.c (bidi_shelve_header_size): New constant.
2834 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2835 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2836
51f30bc5 2837 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2838 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2839 (overlay_strings):
2840 Don't update size of array until after memory allocation succeeds,
2841 because xmalloc/xrealloc may not return.
0065d054
PE
2842 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2843 now that we have proper integer overflow checking.
2844 (record_overlay_string, overlay_strings): Catch overflows when
2845 calculating size of overlay_str_buf.
726e0ab1 2846
0065d054
PE
2847 * callproc.c (Fcall_process): Check for size overflow when
2848 calculating size of args2.
2849 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2850 Normally we prefer signed values, but sticking with ptrdiff_t would
2851 require adding more-complicated checks.
726e0ab1
PE
2852
2853 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2854 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2855 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2856 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2857
2858 * character.c (Fstring): Check for size-calculation overflow.
2859
2860 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2861 unnecessary integer overflow. Check for size overflow.
2862 (encode_coding_object): Don't update size until xmalloc succeeds.
2863
2864 * composite.c (get_composition_id): Check for overflow in glyph
2865 length calculations.
2866
2867 Integer and memory overflow fixes for display code.
2868 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2869 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2870 (scrolling_window): Check for overflow in size calculations.
2871 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2872 Don't assume glyph table len fits in int.
2873 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2874 (row_table_size): Now ptrdiff_t, not int.
2875 (scrolling_window): Avoid overflow in size calculations.
2876 Don't update size until allocation succeeds.
2877 * fns.c (concat): Check for overflow in size calculations.
2878 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2879 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2880 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2881
2882 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2883 (get_doc_string): Check for size calculation overflow.
2884 Don't update size until allocation succeeds.
2885 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2886 EMACS_INT, where ptrdiff_t will do.
2887 (Fsubstitute_command_keys): Check for string overflow.
2888
2889 * editfns.c (set_time_zone_rule): Don't assume environment length
2890 fits in int.
2891 (message_length): Now ptrdiff_t, not int.
2892 (Fmessage_box): Don't update size until allocation succeeds.
2893 Don't assume message length fits in int.
2894 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2895
0065d054
PE
2896 * emacs.c (main): Do not reallocate argv, since there is a null at
2897 the end that can be overwritten, and this way there's no need to
2898 worry about size-calculation overflow.
2899 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2900
2901 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2902 alloc succeeds.
2903 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2904
2905 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2906 (x_set_scroll_bar_width, x_figure_window_size):
2907 Check for integer overflow.
2908 (x_set_alpha): Do not assume XINT fits in int.
2909
2910 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2911 This is for the members text_lines, text_cols, total_lines, total_cols,
2912 where the system imposes an 'int' limit.
2913
2914 * fringe.c (Fdefine_fringe_bitmap):
2915 Don't update size until alloc works.
2916
2917 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2918 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2919
2920 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2921 Check for size-calculation overflow.
2922 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2923 do, as we prefer signed integers.
2924 (id_to_widget.max_size, id_to_widget.used)
2925 (xg_store_widget_in_map, xg_remove_widget_from_map)
2926 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2927 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2928 Use and return ptrdiff_t, not int.
2929 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2930 * gtkutil.h: Change prototypes to match the above.
2931
2932 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2933 are duplicate now that they've been promoted to lisp.h.
2934 (x_allocate_bitmap_record, x_alloc_image_color)
2935 (make_image_cache, cache_image, xpm_load):
2936 Don't update size until alloc is done.
2937 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2938 (x_detect_edges):
3256efce 2939 Check for size calculation overflow.
726e0ab1
PE
2940 (ct_colors_allocated_max): New constant.
2941 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2942 overflow.
3256efce 2943
726e0ab1
PE
2944 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2945 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2946 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2947 Use ptrdiff_t, not int, to count maps.
2948 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2949 calculations. Don't update size until allocation succeeds.
2950 Redo calculations to avoid overflow.
726e0ab1
PE
2951 * keyboard.h: Change prototypes to match the above.
2952
2953 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2954 to count maps.
2955 (current_minor_maps): Check for size calculation overflow.
2956 * keymap.h: Change prototypes to match the above.
2957
2958 * lread.c (read1, init_obarray): Don't update size until alloc done.
2959
2960 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2961 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2962
726e0ab1
PE
2963 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2964 Now ptrdiff_t, not int.
2965 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2966 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2967
2968 * process.c (Fnetwork_interface_list): Check for overflow
2969 in size calculation.
2970
2971 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2972
2973 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2974 overflow. Don't bother calling xmalloc when xrealloc will do.
2975
2976 * search.c (Freplace_match): Check for size calculation overflow.
2977 (Fset_match_data): Don't assume list lengths fit in 'int'.
2978
2979 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2980 for command line length. Do not attempt to address one before the
2981 beginning of an array, as that's not portable.
2982
2983 * term.c (max_frame_lines): Remove; unused.
2984 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2985 not int.
2986 (encode_terminal_code, calculate_costs): Check for size
2987 calculation overflow.
2988 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2989 table lengths and related sizes. Don't update size until alloc
2990 done. Redo calculations to avoid overflow.
2991 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2992
2993 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2994 subtracting pointers.
2995 (gobble_line): Check for overflow more carefully. Don't update size
2996 until alloc done.
2997
2998 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2999 Don't update size until alloc done.
3000 Redo size calculations to avoid overflow.
3001 Check for size calculation overflow.
0065d054 3002 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
3003
3004 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
3005 Use ptrdiff_t, not int, for sizes.
3006 (store_mode_line_noprop_char): Don't update size until alloc done.
3007
0065d054
PE
3008 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
3009 Use ptrdiff_t, not int, for sizes.
3010 (Finternal_make_lisp_face, cache_face):
3011 Check for size calculation overflow.
3012 (cache_face): Treat size calculation overflows as if they were
3013 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
3014
3015 * xfns.c (x_encode_text, x_set_name_internal)
3016 (Fx_change_window_property): Use ptrdiff_t, not int, to count
3017 sizes, since they can exceed INT_MAX in size. Check for size
3018 calculation overflow.
3019
0065d054
PE
3020 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
3021 (xg_select): Check for size calculation overflow.
726e0ab1
PE
3022 Don't update size until alloc done.
3023
0065d054 3024 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 3025 as sprintf is limited to int lengths.
1d526e2f 3026
252c5ee1
PE
3027 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
3028 (X_LONG_MIN): New macros.
864d7ce7
PE
3029 Use them to make the following changes clearer.
3030 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
3031 This change doesn't affect the value now, but it may help remind
3032 future maintainers not to raise the value too much later.
3033 (SELECTION_QUANTUM): Remove, replacing with ...
3034 (selection_quantum): ... new function, which avoids overflow.
3035 All uses changed.
3036 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
3037 assumption that selection length fits in 'int'.
3038 (x_reply_selection_request, x_handle_selection_request)
3039 (x_get_window_property, receive_incremental_selection)
3040 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
3041 (lisp_data_to_selection_data, clean_local_selection_data):
3042 Use ptrdiff_t, not int, to record length of selection.
3043 (x_reply_selection_request, x_get_window_property)
3044 (receive_incremental_selection, x_property_data_to_lisp):
3045 Redo calculations to avoid overflow.
3046 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 3047 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
3048 something.
3049 (x_get_window_property, receive_incremental_selection)
3050 (lisp_data_to_selection_data, x_property_data_to_lisp):
3051 Check for size-calculation overflow.
3052 (x_get_window_property, receive_incremental_selection)
3053 (lisp_data_to_selection_data, Fx_register_dnd_atom):
3054 Don't store size until memory allocation succeeds.
3055 (x_get_window_property): Plug memory leak on memory exhaustion.
3056 Don't double-block input; malloc is safe here. Don't assume 2**34
3057 - 4 fits in unsigned long. Add an xassert to check
3058 XGetWindowProperty overflow. Be more careful about overflow
3059 calculations, and distinguish size from memory overflow better.
3060 (receive_incremental_selection): When tracing, don't assume
3061 unsigned int is less than INT_MAX.
3062 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
3063 harmful) conversions of unsigned short to int.
3064 (lisp_data_to_selection_data): Don't assume that integers
3065 in the range -65535 through -1 fit in an X unsigned short.
3066 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
3067 result parameters unless successful. Rely on cons_to_unsigned
3068 to report problems with elements; the old code wasn't right anyway.
3069 (x_check_property_data): Check for int overflow; we cannot use
3070 a wider type due to X limits.
3071 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
3072
726e0ab1 3073 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 3074
0065d054
PE
3075 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
3076 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
3077 (x_color_cells): Don't store size until memory allocation succeeds.
3078 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 3079 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
3080 (x_term_init): Don't assume length fits in int (sprintf is limited
3081 to int size).
bc18e09d 3082
ebfa62c0
PE
3083 Use ptrdiff_t for composition IDs.
3084 * character.c (lisp_string_width):
3085 * composite.c (composition_table_size, n_compositions)
3086 (get_composition_id, composition_gstring_from_id):
3087 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
3088 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
3089 * window.c (Frecenter):
3090 Use ptrdiff_t, not int, for composition IDs.
3091 * composite.c (get_composition_id): Check for integer overflow.
3092 * composite.h: Adjust prototypes to match the above changes.
3093
d3411f89
PE
3094 Use ptrdiff_t for hash table indexes.
3095 * category.c (hash_get_category_set):
3096 * ccl.c (ccl_driver):
3097 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
3098 * coding.c (coding_system_charset_list, detect_coding_system):
3099 * coding.h (struct coding_system.id):
3100 * composite.c (get_composition_id, gstring_lookup_cache):
3101 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
3102 * image.c (xpm_get_color_table_h):
3103 * lisp.h (hash_lookup, hash_put):
3104 * minibuf.c (Ftest_completion):
3105 Use ptrdiff_t for hash table indexes, not int (which is too
3106 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
3107 32-bit --with-wide-int hosts).
3108
e097a6fa
PE
3109 * charset.c (Fdefine_charset_internal): Check for integer overflow.
3110 Add a FIXME comment about memory leaks.
3111 (syms_of_charset): Don't assume xmalloc returns.
3112
5637687f
PE
3113 Don't assume that stated character widths fit in int.
3114 * character.c (Fchar_width, c_string_width, lisp_string_width):
3115 * character.h (CHAR_WIDTH):
3116 * indent.c (MULTIBYTE_BYTES_WIDTH):
3117 Use sanitize_char_width to avoid undefined and/or bad behavior
3118 with outlandish widths.
a66cfb1c 3119 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
3120 now that we have two such functions. All uses changed.
3121 (sanitize_char_width): New inline function.
3122
a2271ba2
PE
3123 Don't assume that tab-width fits in int.
3124 * character.h (sanitize_width): New inline function.
3125 (SANE_TAB_WIDTH): New macro.
3126 (ASCII_CHAR_WIDTH): Use it.
3127 * indent.c (sane_tab_width): Remove. All uses replaced by
3128 SANE_TAB_WIDTH (current_buffer).
3129 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
3130
18c52557
PE
3131 * fileio.c: Integer overflow issues with file modes.
3132 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
3133
caeeedc1
PE
3134 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
3135 Remove unreachable code.
3136 (read_hex, load_charset_map_from_file): Check for integer overflow.
3137
6df6ae42 3138 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
3139 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
3140 (x_send_scroll_bar_event): Likewise. Check that the size does not
3141 exceed limits imposed by XClientMessageEvent, as well as the usual
3142 ptrdiff_t and size_t limits.
3143
b13995db
PE
3144 * keyboard.c: Overflow, signedness and related fixes.
3145 (make_lispy_movement): Use same integer type in forward decl
3146 that is used in the definition.
3147 (read_key_sequence, keyremap_step):
3148 Change bufsize argument back to int, undoing my 2011-03-30 change.
3149 We prefer signed types, and int is wide enough here.
3150 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3151 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3152 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3153 length, not size_t. Use ptrdiff_t for index, not int.
3154 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3155 possibility of integer overflow.
3156
13464394
PE
3157 Overflow, signedness and related fixes for images.
3158
3159 * dispextern.h (struct it.stack[0].u.image.image_id)
3160 (struct_it.image_id, struct image.id, struct image_cache.size)
3161 (struct image_cache.used, struct image_cache.ref_count):
3162 * gtkutil.c (update_frame_tool_bar):
3163 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3164 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3165 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3166 * nsmenu.m (update_frame_tool_bar):
3167 * xdisp.c (calc_pixel_width_or_height):
3168 * xfns.c (image_cache_refcount):
3169 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3170 on typical 64-bit hosts.
3171
3172 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3173 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3174 Omit unnecessary casts to int.
3175 (parse_image_spec): Check that integers fall into 'int' range
3176 when the callers expect that.
3177 (image_ascent): Redo ascent calculation to avoid int overflow.
3178 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3179 (lookup_image): Remove unnecessary tests.
3180 (xbm_image_p): Locals are now of int, not EMACS_INT,
3181 since parse_image_check makes sure they fit into int.
3182 (png_load, gif_load, svg_load_image):
3183 Prefer int to unsigned where either will do.
3184 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3185 old tiff_error_handler and tiff_warning_handler.
3186 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3187 stack buffer overflows. It uses only the features of vsnprintf
3188 that are common to both POSIX and native Microsoft.
3189 (tiff_error_handler, tiff_warning_handler): Use it.
3190 (tiff_load, gif_load, imagemagick_load_image):
3191 Don't assume :index value fits in 'int'.
3192 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3193 (imagemagick_load_image): Check that crop parameters fit into
3194 the integer types that MagickCropImage accepts. Don't assume
3195 Vimagemagick_render_type has a nonnegative value. Don't assume
3196 size_t fits in 'long'.
3197 (gs_load): Use printmax_t to print the widest integers possible.
3198 Check for integer overflow when computing image height and width.
3199
c11821d4
EZ
32002011-08-26 Eli Zaretskii <eliz@gnu.org>
3201
3202 * xdisp.c (redisplay_window): Don't force window start if point
3203 will be invisible in the resulting window. (Bug#9324)
3204
0c95fcf7
EZ
32052011-08-25 Eli Zaretskii <eliz@gnu.org>
3206
3207 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3208 the display spec is of the form `(space ...)'.
3209 (handle_display_spec): Return the value returned by
3210 handle_single_display_spec, not just 1 or zero.
3211 (handle_single_display_spec): If the display spec is of the form
3212 `(space ...)', and specifies display in the text area, return 2
3213 rather than 1.
fee65a97 3214 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3215 accurately, and prefer exact match for point under bidi.
3216 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3217
3218 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3219 into disp_prop; all users changed.
3220
3221 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3222 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3223 for the text covered by the display property.
3224
e4ed06f1
CY
32252011-08-25 Chong Yidong <cyd@stupidchicken.com>
3226
3227 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3228 Change return value to nil.
3229 (Frecord_buffer): Delete unused function.
3230
f67cdd7f
EZ
32312011-08-24 Eli Zaretskii <eliz@gnu.org>
3232
5980d4c6
EZ
3233 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3234 buffers, return left-to-right.
8610fe8b
EZ
3235 (set_cursor_from_row): Consider candidate row a win if its glyph
3236 represents a newline and point is on that newline. Fixes cursor
3237 positioning on the newline at EOL of R2L text within L2R
3238 paragraph, and vice versa.
3239 (try_cursor_movement): Check continued rows, in addition to
3240 continuation rows. Fixes unwarranted scroll when point enters a
3241 continued line of R2L text within an L2R paragraph, or vice versa.
3242 (cursor_row_p): Consider the case of point being equal to
3243 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3244 from the end of a short line to the beginning of a continued line
3245 of R2L text within L2R paragraph.
3246 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3247 composed characters.
5980d4c6 3248
f67cdd7f
EZ
3249 * bidi.c (bidi_check_type): Use xassert.
3250 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3251 members.
3252
bca633fb
EZ
32532011-08-23 Eli Zaretskii <eliz@gnu.org>
3254
3255 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3256 a character.
3257
4a5885a7
CY
32582011-08-23 Chong Yidong <cyd@stupidchicken.com>
3259
3260 * nsfont.m (ns_otf_to_script): Fix typo.
3261
0902a04e
KH
32622011-08-22 Kenichi Handa <handa@m17n.org>
3263
3264 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3265 extra slot even if the purpose is char-code-property-table.
3266
1a2e6670
EZ
32672011-08-23 Eli Zaretskii <eliz@gnu.org>
3268
8ddde651
EZ
3269 * xdisp.c (redisplay_window): When computing centering_position,
3270 account for the height of the header line. (Bug#8874)
3271
425cc014
EZ
3272 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3273 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3274 candidate is selected by the mouse, and that candidate has a
3275 composed character under the mouse.
3276
1a2e6670
EZ
3277 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3278 coordinates reported by pos-visible-in-window-p for a composed
3279 character in column zero.
3280
8b76d6f8
SM
32812011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3282
3283 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3284
dac347dd
EZ
32852011-08-22 Eli Zaretskii <eliz@gnu.org>
3286
3287 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3288 consider it a hit if to_charpos is anywhere in the range of the
3289 composed buffer positions.
3290
e013fb34
CY
32912011-08-22 Chong Yidong <cyd@stupidchicken.com>
3292
3293 * image.c (gif_load): Don't assume that each subimage has the same
3294 dimensions as the base image. Handle disposal method that is
3295 "undefined" by the gif spec (Bug#9335).
3296
bd1ba3e8
CY
32972011-08-20 Chong Yidong <cyd@stupidchicken.com>
3298
3299 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3300 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3301
54a1215b
EZ
33022011-08-19 Eli Zaretskii <eliz@gnu.org>
3303
823564e5
EZ
3304 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3305 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3306 from an Org mode buffer to a Speedbar frame.
3307
54a1215b
EZ
3308 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3309 a composition, take its buffer position from IT->cmp_it.charpos.
3310 Fixes cursor positioning at the beginning of a line that begins
3311 with a composed character.
3312
9778ebcc
EZ
33132011-08-18 Eli Zaretskii <eliz@gnu.org>
3314
0be6ee06
EZ
3315 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3316 character bidirectional type, use STRONG_L instead. Fixes crashes
3317 in a buffer produced by `describe-categories'.
3318
9778ebcc
EZ
3319 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3320 members before the level stack, so they would be saved and
3321 restored when copying iterator state. Fixes incorrect reordering
3322 around TABs covered by display properties.
3323
156bffbe
AS
33242011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3325
6b02f655 3326 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3327
72ad093b
CY
33282011-08-17 Chong Yidong <cyd@stupidchicken.com>
3329
3330 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3331 (internal_condition_case_2, internal_condition_case_n):
3332 Remove unnecessary aborts (Bug#9081).
72ad093b 3333
35774242
EZ
33342011-08-17 Eli Zaretskii <eliz@gnu.org>
3335
3336 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3337 has no `load' handler, try opening the file locally. (Bug#9311)
3338
db76dd85
KB
33392011-08-16 Ken Brown <kbrown@cornell.edu>
3340
3341 * gmalloc.c: Expand comment.
3342
b215eee5
EZ
33432011-08-16 Eli Zaretskii <eliz@gnu.org>
3344
3345 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3346 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3347
a4579d33
KB
33482011-08-16 Ken Brown <kbrown@cornell.edu>
3349
3350 Fix memory allocation problems in Cygwin build (Bug#9273).
3351
3352 * unexcw.c ( __malloc_initialized): Declare external variable.
3353 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3354
8b76d6f8
SM
3355 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3356 New variables.
a4579d33
KB
3357 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3358 dumped emacs.
3359 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3360 in the static heap.
3361 [CYGWIN] (special_realloc): New function.
3362 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3363 requests to realloc storage in the static heap.
3364
3ebec551
PE
33652011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3366
3367 * bidi.c (bidi_initialize): Remove unused local.
3368
9fd8be00
EZ
33692011-08-15 Eli Zaretskii <eliz@gnu.org>
3370
6b02f655
SM
3371 * bidimirror.h:
3372 * biditype.h: Remove file.
3373 * makefile.w32-in ($(BLD)/bidi.$(O)):
3374 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3375
3376 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3377
3378 * chartab.c: Improve commentary for the uniprop_table API.
3379
32413314
EZ
3380 * bidi.c (bidi_paragraph_init): Support zero value of
3381 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3382 (bidi_initialize): Use uniprop_table instead of including
3383 biditype.h and bidimirror.h.
32413314 3384
9fd8be00
EZ
3385 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3386 coordinates of the iterator when restoring from ppos_it.
3387 (Bug#9296)
3388
5cf2b69b
KH
33892011-08-14 Kenichi Handa <handa@m17n.org>
3390
3391 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3392 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3393
daf17d00
EZ
33942011-08-14 Eli Zaretskii <eliz@gnu.org>
3395
3396 * xdisp.c (move_it_in_display_line_to): Don't invoke
3397 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3398 ppos_it. Fixes vertical cursor motion when line beginning is
3399 covered by an image. (Bug#9296)
3400
08e3161a
JD
34012011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3402
3403 * nsterm.h (ns_run_ascript): Declare.
3404 (NSAPP_DATA2_RUNASSCRIPT): Define.
3405
3406 * nsfns.m (as_script, as_result, as_status): New static variables.
3407 (ns_run_ascript): New function.
5e617bc2 3408 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3409 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3410 the event loop. Get status from as_status (Bug#7276).
3411
3412 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3413 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3414 the event loop (Bug#7276).
3415
a3720aa2
AS
34162011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3417
3418 * gnutls.c (QCgnutls_bootprop_priority)
3419 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3420 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3421 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3422 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3423 (QCgnutls_bootprop_verify_hostname_error)
3424 (QCgnutls_bootprop_callbacks_verify): Rename from
3425 Qgnutls_bootprop_..., all uses changed.
3426
3427 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3428 uses changed.
3429
0a0d27fb
PE
34302011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3431
19d5c50c
PE
3432 * xfaces.c (Qframe_set_background_mode): Now static.
3433 * dispextern.h (Qframe_set_background_mode): Remove decl.
3434
0a0d27fb
PE
3435 * process.c (Fnetwork_interface_info): Declare local only if needed.
3436
377538cb
JD
34372011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3438
3439 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3440 (Fnetwork_interface_list): Allocate in increments of bytes instead
3441 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3442 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3443 sockaddr.
3444 (struct ifflag_def): notrailers is smart on OSX.
3445 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3446 Get hardware address with getifaddrs if available.
3447
08fff70c
EZ
34482011-08-12 Eli Zaretskii <eliz@gnu.org>
3449
3450 * xdisp.c (iterate_out_of_display_property): xassert that
3451 IT->position is set to within IT->object's boundaries. Break from
3452 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3453 when IT->position is set up wrongly due to some bug.
3454 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3455 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3456 entry. Force push_it to save on the stack the current
3457 buffer/string position, to be restored by pop_it. Fix flags in
3458 the iterator structure wrt the object coming from a display
3459 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3460 properties. (Bug#9284)
3461
7be1c708 34622011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3463
7be1c708
CY
3464 * fontset.c (fontset_get_font_group): Add proper type checks.
3465 (Bug#9172)
aac0c6e3 3466
7be1c708 34672011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3468
7be1c708
CY
3469 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3470 and LC_VERSION_MIN_MACOSX.
3471 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3472 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3473
97bb72a6
EZ
34742011-08-08 Eli Zaretskii <eliz@gnu.org>
3475
3476 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3477 no-display-properties-and-no-overlays under bidi display.
3478 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3479 properties and overlays.
97bb72a6 3480
d5617611
CY
34812011-08-08 Chong Yidong <cyd@stupidchicken.com>
3482
37e11a63
CY
3483 * editfns.c (Fset_time_zone_rule): Document relationship with the
3484 setenv function.
3485
d5617611
CY
3486 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3487 the font entity extracted from the cache (Bug#8109).
3488
58872834
CY
34892011-08-07 Chong Yidong <cyd@stupidchicken.com>
3490
3491 * composite.c (autocmp_chars): Don't reset point. That is done by
3492 restore_point_unwind (Bug#5984).
3493
75bfc667
JL
34942011-08-07 Juri Linkov <juri@jurta.org>
3495
3496 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3497 to show the arg `TIME' instead of `TIMEVAL'.
3498
d1410150
EZ
34992011-08-06 Eli Zaretskii <eliz@gnu.org>
3500
3501 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3502 display property strides EOL and includes a newline, as in
3503 longlines-mode. (Bug#9254)
75b771e4
EZ
3504 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3505 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3506
3507 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3508 is non-zero, even if the data buffer is NULL. Fixes a crash in
3509 vertical-motion with longlines-mode. (Bug#9254)
3510
35928349
EZ
35112011-08-05 Eli Zaretskii <eliz@gnu.org>
3512
ec7cc85b
EZ
3513 * bidi.c <bidi_cache_total_alloc>: Now static.
3514 (bidi_initialize): Initialize bidi_cache_total_alloc.
3515
8b76d6f8 3516 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3517 cache. (Bug#9221)
3518
3519 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3520 amount allocated this far in `bidi_cache_total_alloc'.
3521 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3522 non-zero, only free the data buffer without restoring the cache
3523 contents. All callers changed.
3524
3525 * dispextern.h (bidi_unshelve_cache): Update prototype.
3526
3527 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3528 (move_it_in_display_line, move_it_to)
3529 (move_it_vertically_backward, move_it_by_lines): Replace the call
3530 to xfree to an equivalent call to bidi_unshelve_cache.
3531 (move_it_in_display_line_to): Fix logic of returning
412b6358 3532 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3533
e2e2423b
EZ
35342011-08-05 Eli Zaretskii <eliz@gnu.org>
3535
3536 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3537 came from a string character with a `cursor' property. (Bug#9229)
3538
ae9e757a
JD
35392011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3540
3541 * Makefile.in (LIB_PTHREAD): New variable.
3542 (LIBES): Add LIB_PTHREAD (Bug#9216).
3543
3544 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3545 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3546
213bd7f2
AS
35472011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3548
6b02f655 3549 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3550
99aaf75f
JD
35512011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3552
3553 * xterm.c (x_find_topmost_parent): New function.
3554 (x_set_frame_alpha): Find topmost parent window with
3555 x_find_topmost_parent and set the property there also (bug#9181).
3556 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3557
c74e9d86
PE
35582011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3559
3560 * callproc.c (Fcall_process): Avoid vfork clobbering
3561 the local vars buffer, coding_systems, current_dir.
3562
640c8776
SM
35632011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3564
3565 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3566
f26d0e4c
PE
35672011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3568
8a10d76c
PE
3569 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3570 so that it is not optimized away.
3571
f26d0e4c
PE
3572 * xdisp.c (compute_display_string_pos): Remove unused local.
3573
55439c61
EZ
35742011-08-02 Eli Zaretskii <eliz@gnu.org>
3575
3576 Fix slow cursor motion and scrolling in large buffers with
3577 selective display, like Org Mode buffers. (Bug#9218)
3578
3579 * dispextern.h (struct bidi_it): New member disp_prop_p.
3580
3581 * xdisp.c: Remove one-slot cache of display string positions.
3582 (compute_display_string_pos): Accept an additional argument
5e617bc2 3583 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3584 for a display string or property. If found, set DISP_PROP_P
3585 non-zero.
3586
3587 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3588 DISP_PROP_P, and pass it to compute_display_string_pos.
3589 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3590 non-zero. All callers of bidi_fetch_char changed.
3591
fb33fa43
SM
35922011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3593
3594 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3595
b099e063
DM
35962010-12-03 Don March <don@ohspite.net>
3597
3598 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3599 last character M-[char] is translated to ESC [char] (bug#7541).
3600
5cc7f7af
KH
36012011-08-02 Kenichi Handa <handa@m17n.org>
3602
d0fffa3f 3603 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3604
3605 * chartab.c (uniprop_table): Make it non-static.
3606
525d5e6e
EZ
36072011-08-01 Eli Zaretskii <eliz@gnu.org>
3608
3609 * xdisp.c (forward_to_next_line_start): Accept additional argument
3610 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3611 on the newline.
3612 (reseat_at_next_visible_line_start): Use the bidi iterator state
3613 returned by forward_to_next_line_start to restore the state of
3614 it->bidi_it after backing up to previous newline. (Bug#9212)
3615
31011111
AS
36162011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3617
3618 * regex.c (re_comp): Protoize.
3619 (re_exec): Fix return type.
3620 (regexec): Fix type of `ret'. (Bug#9203)
3621
476371c4
PE
36222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3623
e5d76069
PE
3624 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3625 This is needed if max-image-size is a floating-point number.
3626
9a79b20c
AS
36272011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3628
3629 * print.c (print_object): Print empty symbol as ##.
3630
3631 * lread.c (read1): Read ## as empty symbol.
3632
d8c2fa78
AA
36332011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3634
3635 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3636 setting frame foreground color (Bug#9175).
3637 (x_set_background_color): Likewise.
3638
ffe57a7a
AA
3639 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3640 contents (Bug#9176).
3641 (EmacsTooltip -init): Remove bezels and add shadows to
3642 tooltip windows.
3643
bf3492a5
AA
3644 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3645 or scroll bar (Bug#8470).
3646
d55e9c53
AA
3647 * nsfont.m (nsfont_open): Remove assignment to voffset and
3648 unnecessary vars hshink, expand, hd, full_height, min_height.
3649 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3650
3651 * nsterm.h (nsfont_info): Remove voffset field.
3652
d8c2fa78 36532011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3654
3655 Implement strike-through and overline on NextStep (Bug#8863).
3656
3657 * nsfont.m (nsfont_open): Use underline position provided by font,
3658 instead of hard-coded value of 2.
3659 (nsfont_draw): Call ns_draw_text_decoration instead.
3660
3661 * nsterm.h: Add declaration for ns_draw_text_decoration.
3662
3663 * nsterm.m (ns_draw_text_decoration): New function for drawing
3664 underline, overline, and strike-through.
3665 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3666 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3667 accommodate underlining, etc.
4843aac3 3668
4cc60b9b
EZ
36692011-07-28 Eli Zaretskii <eliz@gnu.org>
3670
bc7ece87
EZ
3671 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3672 default.
4cc60b9b 3673
476371c4
PE
36742011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3675
66606eea
PE
3676 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3677 Without this fix, if a signal arrives just after memory fills up,
3678 'malloc' might be invoked reentrantly.
3679
476371c4
PE
3680 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3681 In other words, assume that every image size is allowed, on non-X
3682 hosts. This assumption is probably wrong, but it lets Emacs compile.
3683
f3fcc40d
AS
36842011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3685
3686 * regex.c (re_iswctype): Convert return values to boolean.
3687
350c992f
EZ
36882011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3689
3690 * xdisp.c (compute_display_string_pos): Don't use cached display
3691 string position if the buffer had its restriction changed.
3692 (Bug#9184)
3693
5266b4bb
PE
36942011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3695
3696 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3697
2573a837 36982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3699
41f55ccd 3700 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3701
39e378da
PE
3702 * bidi.c: Integer size and overflow fixes.
3703 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3704 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3705 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3706 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3707 (bidi_find_other_level_edge):
3708 Use ptrdiff_t instead of EMACS_INT where either will do.
3709 This works better on 32-bit hosts configured --with-wide-int.
3710 (bidi_cache_ensure_space): Check for size-calculation overflow.
3711 Use % rather than repeated addition, for better worst-case speed.
3712 Don't set bidi_cache_size until after xrealloc returns, because it
3713 might not return.
3714 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3715 (bidi_cache_ensure_space): Also check that the bidi cache size
3716 does not exceed that of the largest Lisp string or buffer. See Eli
3717 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3718
5e927815
PE
3719 * alloc.c (__malloc_size_t): Remove.
3720 All uses replaced by size_t. See Andreas Schwab's note
3721 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3722
ca4aa935
PE
3723 * image.c: Improve checking for integer overflow.
3724 (check_image_size): Assume that f is nonnull, since
3725 it is always nonnull in practice. This is one less thing to
3726 worry about when checking for integer overflow later.
3727 (x_check_image_size): New function, which checks for integer
3728 overflow issues inside X.
3729 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3730 This removes the need for a memory_full check.
3731 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3732 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3733 (xbm_read_bitmap_data): Change locals back to 'int', since
3734 their values must fit in 'int'.
3735 (xpm_load_image, png_load, tiff_load):
3736 Invoke x_create_x_image_and_pixmap earlier,
3737 to avoid much needless work if the image is too large.
3738 (tiff_load): Treat overly large images as if
3739 x_create_x_image_and_pixmap failed, not as malloc failures.
3740 (gs_load): Use x_check_image_size.
3741
5f8f9cc2
PE
3742 * gtkutil.c: Omit integer casts.
3743 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3744 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3745
5adf60bc
PE
3746 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3747
c8907a93
PE
3748 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3749 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3750 would wrongly return t on a 64-bit host.
3751
e3c25c68
PE
3752 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3753 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3754 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3755 and therefore cause GCC to emit a bogus diagnostic in some cases.
3756
3f791afe
PE
3757 * image.c: Integer signedness and overflow and related fixes.
3758 This is not an exhaustive set of fixes, but it's time to
3759 record what I've got.
3760 (lookup_pixel_color, check_image_size): Remove redundant decls.
3761 (check_image_size): Don't assume that arbitrary EMACS_INT values
3762 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3763 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3764 (tiff_load, imagemagick_load_image):
3765 Check for overflow in size calculations.
3766 (x_create_x_image_and_pixmap): Remove unnecessary test for
3767 xmalloc returning NULL; that can't happen.
3768 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3769 (xpm_color_bucket): Use better integer hashing function.
3770 (xpm_cache_color): Don't possibly over-allocate memory.
3771 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3772 (gif_memory_source):
3773 Use ptrdiff_t, not int or size_t, to record sizes.
3774 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3775 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3776 either works, as we prefer signed integers.
3777 (tiff_read_from_memory, tiff_write_from_memory):
3778 Return tsize_t, not size_t, since that's what the TIFF API wants.
3779 (tiff_read_from_memory): Don't fail simply because the read would
3780 go past EOF; instead, return a short read.
3781 (tiff_load): Omit no-longer-needed casts.
3782 (Fimagemagick_types): Don't assume size fits into 'int'.
3783
3cc5a532
PE
3784 Improve hashing quality when configured --with-wide-int.
3785 * fns.c (hash_string): New function, taken from sxhash_string.
3786 Do not discard information about ASCII character case; this
3787 discarding is no longer needed.
3788 (sxhash-string): Use it. Change sig to match it. Caller changed.
3789 * lisp.h: Declare it.
3790 * lread.c (hash_string): Remove, since we now use fns.c's version.
3791 The fns.c version returns a wider integer if --with-wide-int is
3792 specified, so this should help the quality of the hashing a bit.
3793
b312a492
PE
3794 * emacs.c: Integer overflow minor fix.
3795 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3796 Define only if GNU_LINUX.
3797 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3798
dfd153ae
PE
3799 * dispnew.c: Integer signedness and overflow fixes.
3800 Remove unnecessary forward decls, that were a maintenance hassle.
3801 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3802 All uses changed.
3803 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3804 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3805 (prepare_desired_row, line_draw_cost):
3806 Use int, not unsigned, where either works.
3807 (save_current_matrix, restore_current_matrix):
3808 Use ptrdiff_t, not size_t, where either works.
3809 (init_display): Check for overflow more accurately, and without
3810 relying on undefined behavior.
3811
a81d11a3
PE
3812 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3813 Remove, replacing with the new symbols in lisp.h. All uses changed.
3814 * fileio.c (make_temp_name):
3815 * filelock.c (lock_file_1, lock_file):
3816 * xdisp.c (message_dolog):
3817 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3818 Use pMd etc. instead.
3819 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3820 replacing the pWIDE etc. symbols removed from editfns.c.
3821
3300e6fd
PE
3822 * keyboard.h (num_input_events): Now uintmax_t.
3823 This is (very slightly) less likely to mess up due to wraparound.
3824 All uses changed.
3825
fd05c7e9
PE
3826 * buffer.c: Integer signedness fixes.
3827 (alloc_buffer_text, enlarge_buffer_text):
3828 Use ptrdiff_t rather than size_t when either will do, as we prefer
3829 signed integers.
3830
903fe15d
PE
3831 * alloc.c: Integer signedness and overflow fixes.
3832 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3833 (__malloc_size_t): Default to size_t, not to int.
3834 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3835 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3836 Prefer ptrdiff_t to size_t when either would do, as we prefer
3837 signed integers.
3838 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3839 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3840 Now const. Initialize with values that are in range even if char
3841 is signed.
3842 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3843 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3844 These functions do the right thing with sizes > 2**32.
3845 (check_depth): Now ptrdiff_t, not int.
3846 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3847 Adjust to new way of storing sizes. Check for size overflow bugs
3848 in rest of code.
3849 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3850 slightly wrong anyway, as it missed one instance of
3851 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3852 (refill_memory_reserve): Omit needless cast to size_t.
3853 (mark_object_loop_halt): Mark as externally visible.
3854
ac82cc6a
PE
3855 * xselect.c: Integer signedness and overflow fixes.
3856 (Fx_register_dnd_atom, x_handle_dnd_message):
3857 Use ptrdiff_t, not size_t, since we prefer signed.
3858 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3859 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3860 x_dnd_atoms_size and x_dnd_atoms_length.
3861
c2d1e36d
PE
3862 * doprnt.c: Prefer signed to unsigned when either works.
3863 * eval.c (verror):
3864 * doprnt.c (doprnt):
3865 * lisp.h (doprnt):
3866 * xdisp.c (vmessage):
3867 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3868 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3869 prefer signed arithmetic to avoid comparison confusion.
3870 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3871 but is a bit tricky.
3872
0e926e56
PE
3873 Assume freestanding C89 headers, string.h, stdlib.h.
3874 * data.c, doprnt.c, floatfns.c, print.c:
3875 Include float.h unconditionally.
3876 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3877 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3878 * regex.c: Likewise for stddef.h, string.h.
3879 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3880 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3881 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3882 (STDC_HEADERS): Remove obsolete defines.
3883 * sysdep.c: Include limits.h unconditionally.
3884
9cfdb3ec
PE
3885 Assume support for memcmp, memcpy, memmove, memset.
3886 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3887 * regex.c (memcmp, memcpy):
3888 Remove; we assume C89 now.
3889
3890 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3891 (__malloc_safe_bcopy): Remove; no longer needed.
3892
cf950e6b 3893 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3894 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3895 well either way, and we prefer signed to unsigned.
3896
dbf38e02
LMI
38972011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3898
3899 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3900 closes the connection while we're reading (bug#9182).
3901
d6f0886c 39022011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3903
d6f0886c
JD
3904 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3905 are specified (Bug#9168).
24e0f6b1 3906
2eb1f9e6
PE
39072011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3908
3909 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3910 Found by GCC static checking and --with-wide-int on a 32-bit host.
3911
22381272 39122011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3913
3914 * xdisp.c (compute_display_string_pos): Fix logic of caching
3915 previous display string position. Initialize cached_prev_pos to
3916 -1. Fixes slow-down at the beginning of a buffer.
3917
f25e39b4
EZ
39182011-07-24 Eli Zaretskii <eliz@gnu.org>
3919
3920 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3921 for attrs[LFACE_FONTSET_INDEX].
3922
04c4b52e
PE
39232011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3924
3925 * xml.c (parse_region): Remove unused local
3926 that was recently introduced.
3927
c1734fbd
EZ
39282011-07-23 Eli Zaretskii <eliz@gnu.org>
3929
be18c5a5
EZ
3930 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3931 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3932
c1734fbd
EZ
3933 * xdisp.c (move_it_in_display_line_to): Record the best matching
3934 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3935 exit if none of the characters scanned was an exact match.
3936 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3937 when exact match is impossible due to invisible text, and the
3938 lines are truncated.
3939
a258d627
JD
39402011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3941
3942 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3943 for OSX >= 10.7.
3944
b6d5a689
EZ
39452011-07-22 Eli Zaretskii <eliz@gnu.org>
3946
0f74f785
EZ
3947 Fix a significant slow-down of cursor motion with C-n, C-p,
3948 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3949 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3950 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3951 (next_element_from_buffer): Call compute_stop_pos_backwards to
3952 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3953 base_level_stop.
3954 (reseat): Don't look for prev_stop, as that could mean a very long
3955 run.
3956 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3957 <cached_disp_overlay_modiff>: Cache for last found display string
3958 position.
551918c1 3959 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3960 about the same buffer in the same area of character positions, and
3961 the buffer wasn't changed since the time the display string
3962 position was cached.
551918c1 3963
b2d0c91a
EZ
39642011-07-22 Eli Zaretskii <eliz@gnu.org>
3965
3966 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3967 is an integer, which is important for empty lines. (Bug#9149)
3968
043604ee
CY
39692011-07-22 Chong Yidong <cyd@stupidchicken.com>
3970
3971 * frame.c (Fmodify_frame_parameters): In tty case, update the
3972 default face if necessary (Bug#4238).
3973
da4adb04
CY
39742011-07-21 Chong Yidong <cyd@stupidchicken.com>
3975
3976 * editfns.c (Fstring_to_char): No need to explain what a character
3977 is in the docstring (Bug#6576).
3978
9abd0532
LMI
39792011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3980
3981 * xml.c (parse_region): Make sure we always return a tree.
3982
36881d16
HK
39832011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3984
3985 * xml.c (parse_region): If a document contains only comments,
3986 return that, too.
3987
1e98674d
LMI
39882011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3989
3990 * xml.c (make_dom): Return comments, too.
3991
590bd467
PE
39922011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3993
3994 Port to OpenBSD.
3995 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3996 and the surrounding thread.
3997 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3998 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3999 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
4000 timer goes off.
4001 * s/openbsd.h (BROKEN_SIGIO): Define.
4002 * unexelf.c (unexec) [__OpenBSD__]:
4003 Don't update the .mdebug section of the Alpha COFF symbol table.
4004
f41628b2
LMI
40052011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4006
4007 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
4008 (bug#8460).
4009
b59b67c5
PE
40102011-07-18 Paul Eggert <eggert@cs.ucla.edu>
4011
15e3a074
PE
4012 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
4013 This fixes some race conditions on the permissions of any newly
4014 created file.
4015
41bed37d
PE
4016 * alloc.c (valid_pointer_p): Use pipe, not open.
4017 This fixes some permissions issues when debugging.
4018
b59b67c5
PE
4019 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
4020 If fchown fails to set both uid and gid, try to set just gid,
4021 as that is sometimes allowed. Adjust the file's mode to eliminate
4022 setuid or setgid bits that are inappropriate if fchown fails.
4023
925a6be7
SM
40242011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
4025
4026 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
4027 to compare Lisp_Objects.
4028 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
4029 global_gnutls_log_level, don't mistake it for a Lisp_Object.
4030 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
4031
52968808
AS
40322011-07-17 Andreas Schwab <schwab@linux-m68k.org>
4033
0a6a104b
AS
4034 * lread.c (read_integer): Unread even EOF character.
4035 (read1): Likewise. Properly record start position of symbol.
4036
52968808
AS
4037 * lread.c (read1): Read `#:' as empty uninterned symbol if no
4038 symbol character follows.
4039
9e381cdd
PE
40402011-07-17 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
4043 This works around a problem with the previous change to Fcopy_file.
4044 Recent glibc declares fchown with __attribute__((warn_unused_result)),
4045 and without this change, GCC might complain about discarding
4046 fchown's return value.
4047
b5641435
JB
40482011-07-16 Juanma Barranquero <lekktu@gmail.com>
4049
4050 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
4051
a8031457
PE
40522011-07-16 Paul Eggert <eggert@cs.ucla.edu>
4053
4054 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
4055
dd889327
LMI
40562011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
4057
750c33f7
LMI
4058 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
4059 it's used from the C level.
4060
dd889327
LMI
4061 * process.c: Use the same condition for POLL_FOR_INPUT in both
4062 keyboard.c and process.c (bug#1858).
4063
87e86684
LM
40642011-07-09 Lawrence Mitchell <wence@gmx.li>
4065
4066 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
4067 (Fgnutls_boot): Use it.
4068
64348f40
AS
40692011-07-15 Andreas Schwab <schwab@linux-m68k.org>
4070
4071 * doc.c (Fsubstitute_command_keys): Revert last change.
4072
1d698799
LMI
40732011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
4074
f863868c
LMI
4075 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
4076 quotes the next character, and doesn't affect other longer
4077 sequences (bug#8935).
4078
1d698799
LMI
4079 * lread.c (syms_of_lread): Clarify that is isn't only
4080 `eval-buffer' and `eval-defun' that's affected by
4081 `lexical-binding' (bug#8460).
4082
aa4b6df6
EZ
40832011-07-15 Eli Zaretskii <eliz@gnu.org>
4084
4085 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 4086 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 4087
5d856da6
PE
40882011-07-14 Paul Eggert <eggert@cs.ucla.edu>
4089
ad6042bb
PE
4090 Fix minor problems found by static checking.
4091 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
4092 (elsz): Now a signed constant, not a size_t var. We prefer signed
4093 types to unsigned, to avoid integer comparison confusion. Without
4094 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
4095 "cannot optimize loop, the loop counter may overflow", a symptom
4096 of the confusion.
f00bbb22 4097 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
4098 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
4099
6468f31c
LMI
41002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4101
49080b10
LMI
4102 * search.c (Fre_search_backward): Mention `case-fold-search' in
4103 all the re_search_* functions (bug#8138).
4104
6468f31c
LMI
4105 * keyboard.c (Fopen_dribble_file): Document when the file is
4106 closed (bug#8056).
4107
c965adc5
EZ
41082011-07-14 Eli Zaretskii <eliz@gnu.org>
4109
df9733bf
EZ
4110 * bidi.c (bidi_dump_cached_states): Fix format of displaying
4111 bidi_cache_idx.
4112
0bb23927
EZ
4113 Support bidi reordering of display and overlay strings.
4114 * xdisp.c (compute_display_string_pos)
4115 (compute_display_string_end): Accept additional argument STRING.
4116 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
4117 (reseat_to_string): Initialize bidi_it->string.s and
4118 bidi_it->string.schars.
4119 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
4120 NULL (avoids a crash in bidi_paragraph_init).
4121 Initialize itb.string.lstring.
0bb23927
EZ
4122 (init_iterator): Call bidi_init_it only of a valid
4123 buffer position was specified. Initialize paragraph_embedding to
4124 L2R.
4125 (reseat_to_string): Initialize the bidi iterator.
4126 (display_string): If we need to ignore text properties of
4127 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
4128 original value of -1 will not work with bidi.)
4129 (compute_display_string_pos): First arg is now struct
4130 `text_pos *'; all callers changed. Support display properties on
4131 Lisp strings.
4132 (compute_display_string_end): Support display properties on Lisp
4133 strings.
4134 (init_iterator, reseat_1, reseat_to_string): Initialize the
4135 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
4136 when iterating on a string not from display properties).
640c8776
SM
4137 (compute_display_string_pos, compute_display_string_end):
4138 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
4139 arrow keys.
4140 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
4141 base_level_stop; instead, set base_level_stop to BEGV.
4142 Fixes crashes in vertical-motion.
0bb23927
EZ
4143 (next_element_from_buffer): Improve commentary for when
4144 the iterator is before prev_stop.
4145 (init_iterator): Initialize bidi_p from the default value of
4146 bidi-display-reordering, not from buffer-local value. Use the
4147 buffer-local value only if initializing for buffer iteration.
4148 (handle_invisible_prop): Support invisible properties on strings
4149 that are being bidi-reordered.
4150 (set_iterator_to_next): Support bidi reordering of C strings and
4151 Lisp strings.
4152 (next_element_from_string): Support bidi reordering of Lisp
4153 strings.
4154 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4155 (display_string): Support display of R2L glyph rows.
4156 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4157 (init_iterator): Don't initialize it->bidi_p for strings
4158 here.
4159 (reseat_to_string): Initialize it->bidi_p for strings here.
4160 (next_element_from_string, next_element_from_c_string)
4161 (next_element_from_buffer): Add xassert's for correspondence
4162 between IT's object being iterated and it->bidi_it.string
4163 structure.
4164 (face_before_or_after_it_pos): Support bidi iteration.
4165 (next_element_from_c_string): Handle the case of the first string
4166 character that is not the first one in the visual order.
4167 (get_visually_first_element): New function, refactored from common
4168 parts of next_element_from_buffer, next_element_from_string, and
4169 next_element_from_c_string.
4170 (tool_bar_lines_needed, redisplay_tool_bar)
4171 (display_menu_bar): Force left-to-right direction. Add a FIXME
4172 comment for making that be controlled by a user option.
4173 (push_it, pop_it): Save and restore the state of the
4174 bidi iterator. Save and restore the bidi_p flag.
4175 (pop_it): Iterate out of display property for string iteration as
4176 well.
4177 (iterate_out_of_display_property): Support iteration over strings.
4178 (handle_single_display_spec): Set up it->bidi_it for iteration
4179 over a display string, and call bidi_init_it.
4180 (handle_single_display_spec, next_overlay_string)
4181 (get_overlay_strings_1, push_display_prop): Set up the bidi
4182 iterator for displaying display or overlay strings.
4183 (forward_to_next_line_start): Don't use the shortcut if
4184 bidi-iterating.
4185 (back_to_previous_visible_line_start): If handle_display_prop
4186 pushed the iterator stack, restore the internal state of the bidi
4187 iterator by calling bidi_pop_it same number of times.
4188 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4189 and we are bidi-iterating, don't decrement the iterator position;
4190 instead, set the first_elt flag in the bidi iterator, to produce
4191 the same effect.
4192 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4193 (push_display_prop): xassert that we are iterating a buffer.
4194 (push_it, pop_it): Save and restore paragraph_embedding member.
4195 (handle_single_display_spec, next_overlay_string)
4196 (get_overlay_strings_1, reseat_1, reseat_to_string)
4197 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4198 correctly. Don't assume unibyte strings are not bidi-reordered.
4199 (compute_display_string_pos)
4200 (compute_display_string_end): Fix handling the case of C string.
4201 (push_it, pop_it): Save and restore from_disp_prop_p.
4202 (handle_single_display_spec, push_display_prop): Set the
4203 from_disp_prop_p flag.
4204 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4205 (pop_it): Call iterate_out_of_display_property only if we are
4206 popping after iteration over a string that came from a display
4207 property. Fix a typo in popping stretch info. Add an assertion
4208 for verifying that the iterator position is in sync with the bidi
4209 iterator.
4210 (handle_single_display_spec, get_overlay_strings_1)
4211 (push_display_prop): Fix initialization of paragraph direction for
4212 string when that of the parent object is not yet determined.
4213 (reseat_1): Call bidi_init_it to resync the bidi
4214 iterator with IT's position. (Bug#7616)
4215 (find_row_edges): If ROW->start.pos gives position
4216 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4217 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4218 Reset the from_disp_prop_p flag.
4219 (SAVE_IT, RESTORE_IT): New macros.
4220 (pos_visible_p, face_before_or_after_it_pos)
4221 (back_to_previous_visible_line_start)
4222 (move_it_in_display_line_to, move_it_in_display_line)
4223 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4224 (try_scrolling, redisplay_window, display_line): Use them when
4225 saving a temporary copy of the iterator and restoring it back.
4226 (back_to_previous_visible_line_start, reseat_1)
4227 (init_iterator): Empty the bidi cache "stack".
4228 (move_it_in_display_line_to): If iterator ended up at
4229 EOL, but we never saw any buffer positions smaller than
4230 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4231 motion in bidi-reordered lines.
4232 (move_it_in_display_line_to): Record prev_method and prev_pos
4233 immediately before the call to set_iterator_to_next. Fixes cursor
4234 motion in bidi-reordered lines with stretch glyphs and strings
4235 displayed in margins. (Bug#8133) (Bug#8867)
4236 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4237 TO_CHARPOS.
640c8776
SM
4238 (pos_visible_p): Support positions in bidi-reordered lines.
4239 Save and restore bidi cache.
0bb23927
EZ
4240
4241 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4242 (bidi_paragraph_info): Delete unused struct.
4243 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4244 (bidi_cache_start): New variable.
4245 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4246 to zero.
4247 (bidi_cache_fetch_state, bidi_cache_search)
4248 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4249 (bidi_cache_find, bidi_peek_at_next_level)
4250 (bidi_level_of_next_char, bidi_find_other_level_edge)
4251 (bidi_move_to_visually_next): Compare cache index with
4252 bidi_cache_start rather than with zero.
4253 (bidi_fetch_char): Accept new argument STRING; all callers
4254 changed. Support iteration over a string. Support strings with
4255 display properties. Support unibyte strings. Fix the type of
4256 `len' according to what STRING_CHAR_AND_LENGTH expects.
4257 (bidi_paragraph_init, bidi_resolve_explicit_1)
4258 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4259 (bidi_level_of_next_char, bidi_move_to_visually_next):
4260 Support iteration over a string.
0bb23927
EZ
4261 (bidi_set_sor_type, bidi_resolve_explicit_1)
4262 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4263 can now be zero (for strings); special values 0 and -1 were
4264 changed to -1 and -2, respectively.
4265 (bidi_char_at_pos): New function.
4266 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4267 Call it instead of FETCH_MULTIBYTE_CHAR.
4268 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4269 initialized to valid values.
4270 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4271 values.
4272 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4273 the test for valid cached positions. Fix the logic for looking up
4274 the sentinel state in the cache. GCPRO the Lisp string we are
4275 iterating.
4276 (bidi_push_it, bidi_pop_it): New functions.
4277 (bidi_initialize): Initialize the bidi cache start stack pointer.
4278 (bidi_cache_ensure_space): New function, refactored from part of
4279 bidi_cache_iterator_state. Don't assume the required size is just
4280 one BIDI_CACHE_CHUNK away.
4281 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4282 (bidi_count_bytes, bidi_char_at_pos): New functions.
4283 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4284 always valid if bidi_cache_idx is valid.
4285 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4286 is valid if it's going to be used.
4287 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4288 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4289 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4290 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4291 (bidi_find_other_level_edge, bidi_cache_start_stack):
4292 All variables related to cache indices are now EMACS_INT.
c965adc5 4293
0bb23927
EZ
4294 * dispextern.h (struct bidi_string_data): New structure.
4295 (struct bidi_it): New member `string'. Make flag members be 1-bit
4296 fields, and put them last in the struct.
640c8776
SM
4297 (compute_display_string_pos, compute_display_string_end):
4298 Update prototypes.
0bb23927
EZ
4299 (bidi_push_it, bidi_pop_it): Add prototypes.
4300 (struct iterator_stack_entry): New members bidi_p,
4301 paragraph_embedding, and from_disp_prop_p.
4302 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4303 (bidi_shelve_cache, bidi_unshelve_cache):
4304 Declare prototypes.
0bb23927
EZ
4305
4306 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4307 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4308 and vector-like objects.
4309
4310 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4311 cache around display iteration.
4312
4313 * window.c (Fwindow_end, window_scroll_pixel_based)
4314 (displayed_window_lines, Frecenter): Save and restore the bidi
4315 cache around display iteration.
4316
3bbd2265
LMI
43172011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4318
4319 * editfns.c (Fdelete_region): Clarify the use of the named
4320 parameters (bug#6788).
4321
adc47434
MR
43222011-07-14 Martin Rudalics <rudalics@gmx.at>
4323
4324 * indent.c (Fvertical_motion): Set and restore w->pointm when
4325 saving and restoring the window's buffer (Bug#9006).
4326
837c31f8
LMI
43272011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4328
4329 * editfns.c (Fstring_to_char): Clarify just what is returned
4330 (bug#6576). Text by Eli Zaretskii.
4331
ac389d0c
JB
43322011-07-13 Juanma Barranquero <lekktu@gmail.com>
4333
4334 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4335
0be0ce47
EZ
43362011-07-13 Eli Zaretskii <eliz@gnu.org>
4337
4338 * buffer.c (mmap_find): Fix a typo.
4339
cd18e7e3
JB
43402011-07-13 Johan Bockgård <bojohan@gnu.org>
4341
4342 Fix execution of x selection hooks.
4343 * xselect.c (Qx_lost_selection_functions)
4344 (Qx_sent_selection_functions): New vars.
4345 (syms_of_xselect): DEFSYM them.
4346 (x_handle_selection_request): Pass Qx_sent_selection_functions
4347 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4348 (x_handle_selection_clear,x_clear_frame_selections):
4349 Pass Qx_lost_selection_functions rather than
4350 Vx_lost_selection_functions to Frun_hook_with_args.
4351
47ea7f44
PE
43522011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4353
ac389d0c 4354 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4355 The old code sometimes used this field without initializing it.
4356
47ea7f44
PE
4357 * alloc.c (gc_sweep): Don't read past end of array.
4358 In theory, the old code could also have corrupted Emacs internals,
4359 though it'd be very unlikely.
4360
bc985c87
AS
43612011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4362
4363 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4364 argument. (Bug#4026)
bc985c87 4365
0cf34688
LMI
43662011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4367
b3dadd76
LMI
4368 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4369 key" (bug#4257).
4370
0cf34688
LMI
4371 * window.c (Fset_window_start): Doc fix (bug#4199).
4372 (Fset_window_hscroll): Ditto.
4373
270768cd
PE
43742011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4375
077e3dda 4376 Fix minor new problems caught by GCC 4.6.1.
270768cd 4377 * term.c (init_tty): Remove unused local.
490011a6 4378 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4379 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4380 not used otherwise.
270768cd 4381
b1f58454
CY
43822011-07-12 Chong Yidong <cyd@stupidchicken.com>
4383
4384 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4385
22b9578d
LMI
43862011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4387
6e70ab07
LMI
4388 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4389 are the mini-buffer and the echo area (bug#3320).
4390
22b9578d
LMI
4391 * term.c (init_tty): Remove support for supdup, c10 and perq
4392 terminals, which are no longer supported (bug#1482).
4393
8974cc9f
JB
43942011-07-10 Johan Bockgård <bojohan@gnu.org>
4395
4396 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4397
a560d974
JD
43982011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4399
4400 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4401 for non-popups (Bug#3642).
4402
1dae0f0a
AS
44032011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4404
268c2c36 4405 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4406 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4407 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4408 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4409 * data.c (fmod): Likewise.
4410 * dispnew.c (swap_glyphs_in_rows): Likewise.
4411 * emacs.c (memory_warning_signal): Likewise.
4412 * floatfns.c (float_error): Likewise.
4413 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4414 (otf_open, font_otf_capability, generate_otf_features)
4415 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4416 Likewise.
4417 * image.c (pbm_read_file): Likewise.
4418 * indent.c (string_display_width): Likewise.
4419 * intervals.c (check_for_interval, search_for_interval)
4420 (inc_interval_count, count_intervals, root_interval)
4421 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4422 * lread.c (defalias): Likewise.
268c2c36 4423 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4424 * regex.c (set_image_of_range_1, set_image_of_range)
4425 (regex_grow_registers): Likewise.
4426 * sysdep.c (strerror): Likewise.
4427 * termcap.c (valid_filename_p, tprint, main): Likewise.
4428 * tparam.c (main): Likewise.
4429 * unexhp9k800.c (run_time_remap, save_data_space)
4430 (update_file_ptrs, read_header, write_header, calculate_checksum)
4431 (copy_file, copy_rest, display_header): Likewise.
4432 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4433 Likewise.
4434 * xdisp.c (check_it): Likewise.
4435 * xfaces.c (register_color, unregister_color, unregister_colors):
4436 Likewise.
4437 * xfns.c (print_fontset_result): Likewise.
4438 * xrdb.c (member, fatal, main): Likewise.
4439
99033785
PE
44402011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4441
4442 Fix minor problems found by static checking (Bug#9031).
4443 * chartab.c (char_table_set_range, map_sub_char_table):
4444 Remove unused locals.
4445 (uniprop_table): Now static.
4446 * composite.c (_work_char): Remove unused static var.
4447
9cb2ac56
JB
44482011-07-09 Juanma Barranquero <lekktu@gmail.com>
4449
4450 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4451
f25661f0
JD
44522011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4453
4454 * gtkutil.c (qttip_cb): Remove code without function.
4455
8278c4fe
EZ
44562011-07-09 Eli Zaretskii <eliz@gnu.org>
4457
4458 * w32.c (pthread_sigmask): New stub.
4459
1692ae2d 44602011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4461
8a6ebd58 4462 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4463 sigprocmask is portable only for single-threaded applications, and
4464 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4465 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4466 (LIBES): Use it.
4467 * callproc.c (Fcall_process):
4468 * process.c (create_process):
4469 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4470 Use pthread_sigmask, not sigprocmask.
123403e4 4471
1b854618
JD
44722011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4473
4474 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4475 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4476 wrong (Bug#8591).
4477
3fe4b549
JD
44782011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4479
0ce7e563
JD
4480 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4481 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4482 (xg_hide_tooltip): Fix comment.
4483
3fe4b549
JD
4484 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4485 in registerServicesMenuSendTypes.
4486 (validRequestorForSendType): Don't check ns_return_types.
4487
4488 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4489 ns_return_type.
4490
5df75e47
JR
44912011-07-08 Jason Rumney <jasonr@gnu.org>
4492
22610910
JR
4493 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4494 SH_SHOW for hidden windows (Bug#5482).
4495
5df75e47
JR
4496 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4497 frame struct members of non-existent frames (Bug#6284).
4498
699c10bd
JD
44992011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4500
4393663b
JD
4501 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4502 variable firstTime not needed on OSX >= 10.6.
4503 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4504 >= 10.5. Use setKnobProportion, setDoubleValue.
4505
4506 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4507 (MAC_OS_X_VERSION_10_5): Define if not defined.
4508 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4509 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4510 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4511
4512 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4513 cString and lossyCString on OSX >= 10.4
4514
58179cce 4515 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4516 sizeToFit on OSX >= 10.2.
4517
4518 * nsimage.m (allocInitFromFile): Don't use deprecated method
4519 bestRepresentationForDevice on OSX >= 10.6.
4520
4521 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4522 to avoid warning.
4523
4524 * emacs.c: Declare unexec_init_emacs_zone.
4525
a63e0781
JD
4526 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4527
699c10bd
JD
4528 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4529
4530 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4531 on svcsMenu (Bug#8842).
4532
4533 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4534 ns_return_types.
4535 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4536
4537 * nsterm.m (QUTF8_STRING): Declare.
4538 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4539 (validRequestorForSendType): Return type is (id).
4540 Change indexOfObjectIdenticalTo to indexOfObject.
4541 Check if we have local selection before returning self (Bug#8842).
4542 (writeSelectionToPasteboard): Put local selection into paste board
4543 if we have a local selection (Bug#8842).
4544 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4545
4546 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4547 (ns_get_local_selection): Declare.
4548
54e10184
LMI
45492011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4550
9888ff71
LMI
4551 * keymap.c (describe_map_tree): Don't insert a double newline at
4552 the end of the buffer (bug#1169) and return whether we inserted
4553 something.
4554
54e10184
LMI
4555 * callint.c (Fcall_interactively): Change "reading args" to
4556 "providing args" to try to clarify what it does (bug#1010).
4557
15fa4783
KH
45582011-07-07 Kenichi Handa <handa@m17n.org>
4559
4560 * composite.c (composition_compute_stop_pos): Ignore a static
4561 composition starting before CHARPOS (Bug#8915).
4562
4563 * xdisp.c (handle_composition_prop): Likewise.
4564
a8815b00
EZ
45652011-07-07 Eli Zaretskii <eliz@gnu.org>
4566
4567 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4568 (Bug#9015)
4569
ef7b981d 45702011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4571
4572 * character.h (unicode_category_t): New enum type.
4573
4574 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4575 (Qchar_code_property_table): New variable.
4576 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4577 (UNIPROP_COMPRESSED_FORM_P): New macros.
4578 (char_table_ascii): Uncompress the compressed values.
4579 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4580 Uncompress the compressed values.
ac389d0c 4581 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4582 (char_table_ref_and_range): Uncompress the compressed values.
4583 (sub_char_table_set): New arg is_uniprop. Callers changed.
4584 Uncompress the compressed values.
4585 (sub_char_table_set_range): Args changed. Callers changed.
4586 (char_table_set_range): Adjuted for the above change.
4587 (map_sub_char_table): Delete args default_val and parent. Add arg
4588 top. Give decoded values to a Lisp function.
640c8776 4589 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4590 values to a Lisp function. Gcpro more variables.
4591 (uniprop_table_uncompress)
4592 (uniprop_decode_value_run_length): New functions.
4593 (uniprop_decoder, uniprop_decoder_count): New variables.
4594 (uniprop_get_decoder, uniprop_encode_value_character)
4595 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4596 New functions.
4597 (uniprop_encoder, uniprop_encoder_count): New variables.
4598 (uniprop_get_encoder, uniprop_table)
4599 (Funicode_property_table_internal, Fget_unicode_property_internal)
4600 (Fput_unicode_property_internal): New functions.
4601 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4602 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4603 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4604 char-code-property-alist.
4605
640c8776 4606 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4607 Vunicode_category_table.
4608
640c8776 4609 * font.c (font_range): Adjust for the change of
c805dec0
KH
4610 Vunicode_category_table.
4611
76b397fb
DN
46122011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4613
4614 * m/iris4d.h: Remove file, move contents ...
4615 * s/irix6-5.h: ... here.
4616
22b4128e
PE
46172011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4618
4619 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4620 * alloc.c (mark_buffer):
4621 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4622 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4623 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4624 This isn't true in general, and it's particularly not true
4625 if Emacs is configured with --with-wide-int.
4626 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4627 New macros, used in the buffer.c change.
4628
869795d6
JD
46292011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4630
4631 * xsettings.c: Use both GConf and GSettings if both are available.
4632 (store_config_changed_event): Add comment.
4633 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4634 (store_tool_bar_style_changed): New functions.
5e617bc2 4635 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4636 (struct xsettings): Move font inside HAVE_XFT.
4637 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4638 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4639 Move inside HAVE_XFT.
640c8776 4640 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4641 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4642 also.
4643 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4644 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4645 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4646 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4647 (parse_settings): Move check for font inside HAVE_XFT.
4648 (read_settings, apply_xft_settings): Add comment.
4649 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4650 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4651 call store_font_name_changed.
4652 (xft_settings_event): Add comment.
4653 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4654 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4655 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4656 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4657 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4658 (xsettings_get_system_font, xsettings_get_system_normal_font):
4659 Add comment.
869795d6 4660
d8ed26bd
PE
46612011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4662
4663 Random fixes. E.g., (random) never returned negative values.
4664 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4665 subseconds part to the entropy, as that's a bit more random.
4666 Prefer signed to unsigned, since the signedness doesn't matter and
4667 in general we prefer signed. When given a limit, use a
4668 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4669 latter isn't right if USE_2_TAGS_FOR_INTS.
4670 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4671 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4672
cabf1cac
SM
46732011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4674
4675 * textprop.c (text_property_stickiness):
4676 Obey Vtext_property_default_nonsticky.
4677 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4678 * w32fns.c (syms_of_w32fns):
4679 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4680
6e9b2be9
PE
46812011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4682
4683 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4684 This is more efficient than Ffile_directory_p and avoids a minor race.
4685
90186c68
LMI
46862011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4687
7c301272
LMI
4688 * buffer.c (Foverlay_put): Say what the return value is
4689 (bug#7835).
4690
c4f2d8d4
LMI
4691 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4692 is a directory before asking whether to use the file name
4693 (bug#7564).
ad637907
LMI
4694 (barf_or_query_if_file_exists): Make the "File is a directory"
4695 error be more correct.
c4f2d8d4 4696
90186c68
LMI
4697 * fns.c (Frequire): Remove the mention of the .gz files, since
4698 that's installation-specific, but keep the mention of
4699 `get-load-suffixes'.
4700
da64016e
PE
47012011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4702
4703 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4704 Report string overflow if the output is too long.
4705
7d47b580
JB
47062011-07-04 Juanma Barranquero <lekktu@gmail.com>
4707
a555cb87
JB
4708 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4709 (syms_of_gnutls): Remove duplicate DEFSYM for
4710 Qgnutls_bootprop_verify_hostname_error, an error for
4711 Qgnutls_bootprop_verify_error (which is no longer used).
4712
7d47b580
JB
4713 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4714 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4715 Also (re)move comments that are misplaced or no longer relevant.
4716
1e49bfab
LMI
47172011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4718
4719 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4720
1485f4c0
CY
47212011-07-03 Chong Yidong <cyd@stupidchicken.com>
4722
4723 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4724 and background color parameters if they have been changed.
4725
a9ab721e
LMI
47262011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4727
4728 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4729
cf7cff57
PE
47302011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4731
2e13213d
PE
4732 * xsettings.c (SYSTEM_FONT): Define only when used.
4733 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4734
cf7cff57
PE
4735 * keymap.c (access_keymap_1): Now static.
4736
7a8e04f7
CY
47372011-07-02 Chong Yidong <cyd@stupidchicken.com>
4738
4739 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4740 leave any prefix arg for the up event (Bug#1586).
4741
61352f62
LMI
47422011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4743
69bb1ef7
LMI
4744 * lread.c (syms_of_lread): Mention single symbols defined by
4745 `defvar' or `defconst' (bug#7154).
4746
61352f62 4747 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4748 (Frequire): Mention get-load-suffixes.
61352f62 4749
28545e04
MR
47502011-07-02 Martin Rudalics <rudalics@gmx.at>
4751
4752 * window.h (window): Remove clone_number slot.
4753 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4754 Remove.
4755 (make_parent_window, make_window, saved_window)
4756 (Fset_window_configuration, save_window_save): Don't deal with
4757 clone numbers.
4758 * buffer.c (Qclone_number): Remove declaration.
4759 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4760
3349e122
SM
47612011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4762
4763 Add multiple inheritance to keymaps.
4764 * keymap.c (Fmake_composed_keymap): New function.
4765 (Fset_keymap_parent): Simplify.
4766 (fix_submap_inheritance): Remove.
4767 (access_keymap_1): New function extracted from access_keymap to handle
4768 embedded parents and handle lists of maps.
4769 (access_keymap): Use it.
4770 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4771 (Fcopy_keymap): Handle embedded parents.
4772 (Fcommand_remapping, define_as_prefix): Simplify.
4773 (Fkey_binding): Simplify.
4774 (syms_of_keymap): Move minibuffer-local-completion-map,
4775 minibuffer-local-filename-completion-map,
4776 minibuffer-local-must-match-map, and
4777 minibuffer-local-filename-must-match-map to Elisp.
4778 (syms_of_keymap): Defsubr make-composed-keymap.
4779 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4780 (parse_menu_item): Trivial simplification.
4781
3279eb87
GM
47822011-07-01 Glenn Morris <rgm@gnu.org>
4783
4784 * Makefile.in (SETTINGS_LIBS): Fix typo.
4785
4550efdf
KI
47862011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4787
4788 * coding.c (Fencode_coding_string): Record the last coding system
4789 used, as the function doc string says (bug#8738).
4790
0949d2b6
JD
47912011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4792
4793 * xsettings.c (store_monospaced_changed): Take new font as arg and
4794 check for change against current_mono_font.
4795 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4796 (emacs_settings_constructor, emacs_settings_get_property)
4797 (emacs_settings_set_property, emacs_settings_class_init)
4798 (emacs_settings_init, gsettings_obj): Remove.
4799 (something_changedCB): New function for HAVE_GSETTINGS.
4800 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4801 with value as argument.
4802 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4803 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4804 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4805 "changed".
4806
4807 * xgselect.c: Add defined (HAVE_GSETTINGS).
4808 (xgselect_initialize): Ditto.
4809
4810 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4811 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4812 xg_select.
4813
bbc6b304
PE
48142011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4815
4816 * eval.c (struct backtrace): Simplify and port the data structure.
4817 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4818 signed bit field, as this assumption is not portable and it makes
4819 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4820 "char debug_on_exit : 1" as this is not portable either; instead,
4821 use the portable "unsigned int debug_on_exit : 1". Remove unused
4822 member evalargs. Remove obsolete comments about cc bombing out.
4823
9851bfc5
JD
48242011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4825
51bb811f 4826 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4827 Let HAVE_GSETTINGS override HAVE_GCONF.
4828 (store_monospaced_changed): New function.
4829 (EMACS_SETTINGS): A new type derived from GObject to handle
4830 GSettings notifications.
4831 (emacs_settings_constructor, emacs_settings_get_property)
4832 (emacs_settings_set_property, emacs_settings_class_init):
4833 New functions.
4834 (gsettings_client, gsettings_obj): New variables.
4835 (GSETTINGS_SCHEMA): New define.
4836 (something_changedCB): Call store_monospaced_changed.
4837 (init_gsettings): New function.
4838 (xsettings_initialize): Call init_gsettings.
4839 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4840 to NULL.
4841
640c8776 4842 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4843 GCONF_CFLAGS/LIBS.
4844
5386012d
MR
48452011-06-29 Martin Rudalics <rudalics@gmx.at>
4846
4847 * window.c (resize_root_window, grow_mini_window)
4848 (shrink_mini_window): Rename Qresize_root_window to
4849 Qwindow_resize_root_window and Qresize_root_window_vertically to
4850 Qwindow_resize_root_window_vertically.
4851
f13e0b08
PE
48522011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4853
4854 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4855
94515237
JB
48562011-06-27 Juanma Barranquero <lekktu@gmail.com>
4857
4858 * makefile.w32-in: Redesign dependencies so they reflect more
4859 clearly which files are directly included by each source file,
4860 and not through other includes.
4861
e43b6e43
MR
48622011-06-27 Martin Rudalics <rudalics@gmx.at>
4863
4864 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4865 (sort_overlays, overlay_strings): When an overlay's clone number
4866 matches the window's clone number process the overlay even if
4867 the overlay's window property doesn't match the current window.
4868
d68443dc
MR
4869 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4870 (Fwindow_hchild): Rename to Fwindow_left_child.
4871 (Fwindow_next): Rename to Fwindow_next_sibling.
4872 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4873 (resize_window_check): Rename to window_resize_check.
4874 (resize_window_apply): Rename to window_resize_apply.
4875 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4876 (Fdelete_other_windows_internal, resize_frame_windows)
4877 (Fsplit_window_internal, Fdelete_window_internal)
4878 (grow_mini_window, shrink_mini_window)
4879 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4880
c7e73be5
JD
48812011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4882
4883 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4884 (emacs_fixed_set_min_size): Remove.
4885 (emacs_fixed_new): Take frame as argument.
4886
4887 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4888 (_EmacsFixedPrivate): Remove minwidth/height.
4889 Add struct frame *f.
4890 (emacs_fixed_init): Initialize priv->f.
4891 (get_parent_class, emacs_fixed_set_min_size): Remove.
4892 (emacs_fixed_new): Set priv->f to argument.
4893 (emacs_fixed_get_preferred_width)
4894 (emacs_fixed_get_preferred_height): Use min_width/height from
4895 frames size_hint to set minimum and natural (Bug#8919).
4896 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4897 and use min_width/height from frames size_hint to set
4898 min_width/height (Bug#8919).
4899
4900 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4901 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4902 Fix indentation.
c7e73be5 4903
cf99dcf8
EZ
49042011-06-26 Eli Zaretskii <eliz@gnu.org>
4905
4906 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4907 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4908 called at ZV.
4909
029529ac
CY
49102011-06-26 Chong Yidong <cyd@stupidchicken.com>
4911
4912 * process.c (wait_reading_process_output): Bypass select if
4913 waiting for a cell while ignoring keyboard input, and input is
4914 pending. Suggested by Jan Djärv (Bug#8869).
4915
7a7ef429
PE
49162011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4917
4918 Use gnulib's dup2 module instead of rolling our own.
4919 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4920
11fdef7d 49212011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4922
4923 * dispnew.c (scrolling_window): Before scrolling, turn off a
4924 mouse-highlight in the window being scrolled.
4925
cd3520a4
JB
49262011-06-24 Juanma Barranquero <lekktu@gmail.com>
4927
4928 Move DEFSYM to lisp.h and use everywhere.
4929
4930 * character.h (DEFSYM): Move declaration...
4931 * lisp.h (DEFSYM): ...here.
4932
4933 * gnutls.c:
4934 * minibuf.c:
4935 * w32menu.c:
4936 * w32proc.c:
4937 * w32select.c: Don't include character.h.
4938
4939 * alloc.c (syms_of_alloc):
4940 * buffer.c (syms_of_buffer):
4941 * bytecode.c (syms_of_bytecode):
4942 * callint.c (syms_of_callint):
4943 * casefiddle.c (syms_of_casefiddle):
4944 * casetab.c (init_casetab_once):
4945 * category.c (init_category_once, syms_of_category):
4946 * ccl.c (syms_of_ccl):
4947 * cmds.c (syms_of_cmds):
4948 * composite.c (syms_of_composite):
4949 * dbusbind.c (syms_of_dbusbind):
4950 * dired.c (syms_of_dired):
4951 * dispnew.c (syms_of_display):
4952 * doc.c (syms_of_doc):
4953 * editfns.c (syms_of_editfns):
4954 * emacs.c (syms_of_emacs):
4955 * eval.c (syms_of_eval):
4956 * fileio.c (syms_of_fileio):
4957 * fns.c (syms_of_fns):
4958 * frame.c (syms_of_frame):
4959 * fringe.c (syms_of_fringe):
4960 * insdel.c (syms_of_insdel):
4961 * keymap.c (syms_of_keymap):
4962 * lread.c (init_obarray, syms_of_lread):
4963 * macros.c (syms_of_macros):
4964 * msdos.c (syms_of_msdos):
4965 * print.c (syms_of_print):
4966 * process.c (syms_of_process):
4967 * search.c (syms_of_search):
4968 * sound.c (syms_of_sound):
4969 * syntax.c (init_syntax_once, syms_of_syntax):
4970 * terminal.c (syms_of_terminal):
4971 * textprop.c (syms_of_textprop):
4972 * undo.c (syms_of_undo):
4973 * w32.c (globals_of_w32):
4974 * window.c (syms_of_window):
4975 * xdisp.c (syms_of_xdisp):
4976 * xfaces.c (syms_of_xfaces):
4977 * xfns.c (syms_of_xfns):
4978 * xmenu.c (syms_of_xmenu):
4979 * xsettings.c (syms_of_xsettings):
4980 * xterm.c (syms_of_xterm): Use DEFSYM.
4981
4228cf16
TZ
49822011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4983
cd3520a4 4984 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4985
7fcccf1e
PE
49862011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4987
7efb4e0e
PE
4988 Integer and buffer overflow fixes (Bug#8873).
4989
ff5844ad
PE
4990 * print.c (printchar, strout): Check for string overflow.
4991 (PRINTPREPARE, printchar, strout):
4992 Don't set size unless allocation succeeds.
4993
90532f02
PE
4994 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4995 for sizes. Check for string overflow more accurately.
4996 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4997
6d84508d
PE
4998 * macros.c: Integer and buffer overflow fixes.
4999 * keyboard.h (struct keyboard.kbd_macro_bufsize):
5000 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
5001 Use ptrdiff_t, not int, for sizes.
5002 Don't increment bufsize until after realloc succeeds.
5003 Check for size-calculation overflow.
5004 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
5005
437b2cb4
PE
5006 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
5007
8b9ac8b4
PE
5008 * lread.c: Integer overflow fixes.
5009 (read_integer): Radix is now EMACS_INT, not int,
5010 to improve quality of diagnostics for out-of-range radices.
5011 Calculate buffer size correctly for out-of-range radices.
5012 (read1): Check for integer overflow in radices, and in
5013 read-circle numbers.
82cb60d3
PE
5014 (read_escape): Avoid int overflow.
5015 (Fload, openp, read_buffer_size, read1)
5016 (substitute_object_recurse, read_vector, read_list, map_obarray):
5017 Use ptrdiff_t, not int, for sizes.
5018 (read1): Use EMACS_INT, not int, for sizes.
20270765 5019 Check for size overflow.
8b9ac8b4 5020
7fcccf1e
PE
5021 * image.c (cache_image): Check for size arithmetic overflow.
5022
bfbbd7e7
PE
5023 * lread.c: Integer overflow issues.
5024 (saved_doc_string_size, saved_doc_string_length)
5025 (prev_saved_doc_string_size, prev_saved_doc_string_length):
5026 Now ptrdiff_t, not int.
5027 (read1): Don't assume doc string length fits in int. Check for
5028 out-of-range doc string lengths.
5029 (read_list): Don't assume file position fits in int.
39019e54 5030 (read_escape): Check for hex character overflow.
bfbbd7e7 5031
4e323265
LL
50322011-06-22 Leo Liu <sdl.web@gmail.com>
5033
5034 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
5035 Move to minibuffer.el.
5036
85fece3e
PE
50372011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5038
20b84ce9 5039 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
5040 The following patches are for when GLYPH_DEBUG && !XASSERT.
5041 * dispextern.h (trace_redisplay_p, dump_glyph_string):
5042 * dispnew.c (flush_stdout):
5043 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
5044 Mark as externally visible.
5045 * dispnew.c (check_window_matrix_pointers): Now static.
5046 * dispnew.c (window_to_frame_vpos):
5047 * xfns.c (unwind_create_frame):
5048 * xterm.c (x_check_font): Remove unused local.
5049 * scroll.c (CHECK_BOUNDS):
5050 * xfaces.c (cache_fache): Rename local to avoid shadowing.
5051 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
5052 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
5053 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
5054 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
5055 Now static.
5056 (debug_method_add): Use va_list and vsprintf rather than relying
5057 on undefined behavior with wrong number of arguments.
5058 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
5059 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
5060 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
5061 since we're not interested in debugging glyphs with old libraries.
5062 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
5063 GCC 4.6.0's static checking.
5064
0766b489
PE
50652011-06-22 Paul Eggert <eggert@cs.ucla.edu>
5066
31fd4b32
PE
5067 Integer overflow and signedness fixes (Bug#8873).
5068 A few related buffer overrun fixes, too.
5069
b79e8648
PE
5070 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
5071
0766b489
PE
5072 * dispextern.h (struct face.stipple):
5073 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
5074 (x_bitmap_mask, x_allocate_bitmap_record)
5075 (x_create_bitmap_from_data, x_create_bitmap_from_file)
5076 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
5077 (x_create_bitmap_from_xpm_data):
5078 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
5079 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
5080 (.bitmaps_last):
5081 * xfaces.c (load_pixmap):
5082 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
5083 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
5084 (.bitmaps_last, struct x_output.icon_bitmap):
5085 Use ptrdiff_t, not int, for bitmap indexes.
5086 (x_allocate_bitmap_record): Check for size overflow.
5087 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
5088
b081724f
PE
5089 Use ptrdiff_t, not int, for overlay counts.
5090 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
5091 * editfns.c (overlays_around, get_pos_property):
5092 * textprop.c (get_char_property_and_overlay):
5093 * xdisp.c (next_overlay_change, note_mouse_highlight):
5094 * xfaces.c (face_at_buffer_position):
21514da7
PE
5095 * buffer.c (OVERLAY_COUNT_MAX): New macro.
5096 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
5097 (Fnext_overlay_change, Fprevious_overlay_change)
5098 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 5099 Use ptrdiff_t, not int, for sizes.
21514da7 5100 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 5101
3de73e5e
PE
5102 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
5103
2606c57b
PE
5104 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
5105 (x_session_initialize): Do not assume string length fits in int.
5106
aaafe47a
PE
5107 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
5108 This is unlikely, but can occur if DPI is outlandish.
5109
2674ddc8 5110 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
5111 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
5112
28154962
PE
5113 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
5114 * xrdb.c (magic_file_p, search_magic_path):
5115 Omit last arg SUFFIX; it was always 0. All callers changed.
5116 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
5117
7de51af5
PE
5118 * xfont.c (xfont_match): Avoid need for strlen.
5119
25ed6cc3
PE
5120 * xfns.c: Don't assume strlen fits in int.
5121 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
5122
4eab31dd
PE
5123 * xdisp.c (message_log_check_duplicate): Return intmax_t,
5124 not unsigned long, as we prefer signed integers. All callers changed.
5125 Detect integer overflow in repeat count.
5126 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 5127 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 5128
171e2a58
PE
5129 * termcap.c: Don't assume sizes fit in int and never overflow.
5130 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
5131 (gobble_line): Check for size-calculation overflow.
5132
ad39faca 5133 * minibuf.c (Fread_buffer):
6e5bb2dc 5134 * lread.c (intern, intern_c_string):
74ca2eb3
PE
5135 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
5136 Don't assume string length fits in int.
5137
52c61c22 5138 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
5139 * gtkutil.c (style_changed_cb): Avoid need for strlen.
5140
b5b8c9e5
PE
5141 * font.c: Don't assume string length fits in int.
5142 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
5143 Use ptrdiff_t, not int.
ccd6111c
PE
5144 (font_intern_prop): Don't assume string length fits in int.
5145 Don't assume integer property fits in fixnum.
5146 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 5147
882f0d81 5148 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 5149 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5150 Reformulate so as not to need the command string.
5151 Invoke gzip -cd rather than gunzip, as it's more portable.
5152 (lock_info_type, lock_file_1, lock_file):
5153 Don't assume pid_t and time_t fit in unsigned long.
5154 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5155 (current_lock_owner): Prefer signed type for sizes.
5156 Use memcpy, not strncpy, where memcpy is what is really wanted.
5157 Don't assume (via atoi) that time_t and pid_t fit in int.
5158 Check for time_t and/or pid_t out of range, e.g., via a network share.
5159 Don't alloca where an auto var works fine.
5160
93f4cf88
PE
5161 * fileio.c: Fix some integer overflow issues.
5162 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5163 Don't assume string length fits in int.
5164 (directory_file_name): Don't assume string length fits in long.
5165 (make_temp_name): Don't assume pid fits in int, or that its print
5166 length is less than 20.
5167
f3e92b69
PE
5168 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5169
1bfdaf10
PE
5170 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5171
35016e9a
PE
5172 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5173
3d1e65a1
PE
5174 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5175 We prefer signed integers, even for size calculations.
5176
0b963a93
PE
5177 * emacs.c: Don't assume string length fits in 'int'.
5178 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5179 (main): Don't invoke strlen when not needed.
5180
573f4b54
PE
5181 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5182 (XD_DEBUG_MESSAGE): Don't waste a byte.
5183
989f33ba
PE
5184 * callproc.c (getenv_internal_1, getenv_internal)
5185 (Fgetenv_internal):
965d34eb
PE
5186 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5187
e4d29b33
PE
5188 * lread.c (invalid_syntax): Omit length argument.
5189 All uses changed. This doesn't fix a bug, but it simplifies the
5190 code away from its former Hollerith-constant appearance, and it's
5191 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5192 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5193
eb49b136
PE
5194 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5195 This didn't break anything, but it didn't help either.
5196 It's confusing to put a bogus integer in a place where the actual
5197 value does not matter.
9f62aeb1 5198 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5199 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5200
15375a22
PE
5201 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5202 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5203 implementation.
b61cc01c
PE
5204 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5205 We prefer signed types, and the value cannot exceed the EMACS_INT
5206 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5207 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5208 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5209 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5210
53b2623d
PE
5211 * indent.c (sane_tab_width): New function.
5212 (current_column, scan_for_column, Findent_to, position_indentation)
5213 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5214 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5215
51cab52b 5216 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5217
f2ed8a70
PE
5218 * lisp.h (lint_assume): New macro.
5219 * composite.c (composition_gstring_put_cache):
5220 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5221
abe80cc6
PE
5222 * editfns.c, insdel.c:
5223 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5224
b02c740e
PE
5225 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5226
ebc96716
PE
5227 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5228
b4e50fa0 5229 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5230 Use much-faster test for byte-length change.
311d5d7c 5231 Don't assume string byte-length fits in 'int'.
a4cf38e4 5232 Check that character arg fits in 'int'.
85461888 5233 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5234
c0c1ee9f
PE
5235 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5236
a498d7f4
PE
5237 * fns.c (concat): Catch string overflow earlier.
5238 Do not rely on integer wraparound.
5239
51cab52b
PE
5240 * dispextern.h (struct it.overlay_strings_charpos)
5241 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5242 * xdisp.c (forward_to_next_line_start)
5243 (back_to_previous_visible_line_start)
5244 (reseat_at_next_visible_line_start, next_element_from_buffer):
5245 Don't arbitrarily truncate the value of 'selective' to int.
5246
76031fad
PE
5247 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5248
5eb55db9
PE
5249 * composite.c: Don't truncate sizes to 'int'.
5250 (composition_gstring_p, composition_reseat_it)
5251 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5252 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5253 not EMACS_UINT, for indexes.
5eb55db9 5254
0703a717
PE
5255 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5256
d6202519
PE
5257 * buffer.c: Include <verify.h>.
5258 (struct sortvec.priority, struct sortstr.priority):
8961a454 5259 Now EMACS_INT, not int.
c20998a7 5260 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5261 (struct sortstr.size, record_overlay_string)
5262 (struct sortstrlist.size, struct sortlist.used):
5263 Don't truncate size to int.
5264 (record_overlay_string): Check for size-calculation overflow.
d6202519 5265 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5266
d5a19415
JM
52672011-06-22 Jim Meyering <meyering@redhat.com>
5268
029529ac 5269 Don't leak an XBM-image-sized buffer
d5a19415
JM
5270 * image.c (xbm_load): Free the image buffer after using it.
5271
a9041e6c
PE
52722011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5273
5274 Port to Sun C.
5275 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5276 that Sun C diagnosed.
5277 * fns.c (secure_hash): Fix pointer signedness issue.
5278 * intervals.c (static_offset_intervals): New function.
5279 (offset_intervals): Use it.
5280
7f3f739f
LL
52812011-06-21 Leo Liu <sdl.web@gmail.com>
5282
5283 * deps.mk (fns.o):
5284 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5285 sha512.h.
5286
5287 * fns.c (secure_hash): Rename from crypto_hash_function and change
5288 the first arg to accept symbols.
5b66d427 5289 (Fsecure_hash): New primitive.
7f3f739f
LL
5290 (syms_of_fns): New symbols.
5291
76147d94
DD
52922011-06-20 Deniz Dogan <deniz@dogan.se>
5293
5294 * process.c (Fset_process_buffer): Clarify return value in
5295 docstring.
5296
7d7d0045
CY
52972011-06-18 Chong Yidong <cyd@stupidchicken.com>
5298
5299 * dispnew.c (add_window_display_history): Use BVAR.
5300
5301 * xdisp.c (debug_method_add): Use BVAR.
5302 (check_window_end, dump_glyph_matrix, dump_glyph)
5303 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5304
5305 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5306 Likewise.
5307
5308 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5309 check till after the cache is created in init_frame_faces.
5310
ff2bc410
SM
53112011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5312
5313 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5314
28177add
PE
53152011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5316
dd3482fe
PE
5317 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5318 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5319 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5320
393d71f3 5321 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5322 * fileio.c (Finsert_file_contents):
5323 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5324 Remove the old (too-loose) buffer overflow checks.
5325 They weren't needed, since make_gap checks for buffer overflow.
5326 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5327 The old code merely checked for Emacs fixnum overflow, and relied
5328 on undefined (wraparound) behavior. The new code avoids undefined
5329 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5330
2e6813b0 5331 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5332 Tune. Don't use wider integers than needed. Don't use alloca.
5333 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5334
599a9e4f
PE
5335 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5336
99561444
PE
5337 * insdel.c, lisp.h (buffer_overflow): New function.
5338 (insert_from_buffer_1, replace_range, replace_range_2):
5339 * insdel.c (make_gap_larger):
5340 * editfns.c (Finsert_char):
5341 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5342
28177add
PE
5343 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5344
e69dafad
PE
53452011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5346
4baa020d 5347 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5348
b1c46f02
PE
5349 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5350 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5351
e69dafad
PE
5352 * fileio.c: Don't assume EMACS_INT fits in off_t.
5353 (emacs_lseek): New static function.
5354 (Finsert_file_contents, Fwrite_region): Use it.
5355 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5356
566684ea
PE
5357 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5358
e6966cd6
PE
5359 * fns.c: Don't overflow int when computing a list length.
5360 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5361 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5362 truncation on 64-bit hosts. Check for QUIT every
5363 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5364 faster and is responsive enough.
5365 (Flength): Report an error instead of overflowing an integer.
5366 (Fsafe_length): Return a float if the value is not representable
5367 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5368 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5369 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5370
dd0b0efb
PE
5371 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5372 (header_size, word_size): New constants.
5373 (allocate_vectorlike): Don't check size overflow here.
5374 (allocate_vector): Check it here instead, since this is the only
5375 caller of allocate_vectorlike that could cause overflow.
5376 Check that the new vector's length is representable as a fixnum.
5377
86fe5cfe
PE
5378 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5379 The previous code was bogus. For example, next_almost_prime (32)
5380 returned 39, which is undesirable as it is a multiple of 3; and
5381 next_almost_prime (24) returned 25, which is a multiple of 5 so
5382 why was the code bothering to check for multiples of 7?
5383
80e88859
PE
5384 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5385
4a2f0ad6
PE
5386 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5387
f66c7cf8
PE
5388 Variadic C functions now count arguments with ptrdiff_t.
5389 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5390 Back then I didn't know that the Emacs coding style prefers signed int.
5391 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5392 were being counted with int, which may truncate counts on 64-bit
5393 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5394 * lisp.h (struct Lisp_Subr.function.aMANY)
5395 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5396 Arg counts are now ptrdiff_t, not size_t.
5397 All variadic functions and their callers changed accordingly.
5398 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5399 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5400 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5401 * callint.c (Fcall_interactively): Check arg count for overflow,
5402 to avoid potential buffer overrun. Use signed char, not 'int',
5403 for 'varies' array, so that we needn't bother to check its size
5404 calculation for overflow.
5405 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5406 * eval.c (apply_lambda):
5407 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5408 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5409 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5410
a1759b76
PE
5411 * callint.c (Fcall_interactively): Don't use index var as event count.
5412
d96be9fc
PE
5413 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5414 * mem-limits.h (SIZE): Remove; no longer used.
5415
a690a978 5416 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5417
578c21e6
PE
5418 Remove unnecessary casts.
5419 * xterm.c (x_term_init):
5420 * xfns.c (x_set_border_pixel):
5421 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5422 These aren't needed now that we assume ANSI C.
5423
96f53c6c
PE
5424 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5425 It's more likely to cause problems (due to unsigned overflow)
5426 than to cure them.
5427
83c77d31
PE
5428 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5429
ee2079f1
PE
5430 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5431
6da65536
PE
5432 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5433
7147c4a4
PE
5434 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5435
193e32d9
PE
5436 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5437
e5533da6
PE
5438 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5439
9910e595
PE
5440 GLYPH_CODE_FACE returns EMACS_INT, not int.
5441 * dispextern.h (merge_faces):
5442 * xfaces.c (merge_faces):
01103c44
PE
5443 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5444 Don't assume EMACS_INT fits in int.
9910e595 5445
2638320e
PE
5446 * character.h (CHAR_VALID_P): Remove unused parameter.
5447 * fontset.c, lisp.h, xdisp.c: All uses changed.
5448
045eb8d9
PE
5449 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5450
c1f134b5
PE
5451 * fns.c (concat): Minor tuning based on overflow analysis.
5452 This doesn't fix any bugs. Use int to hold character, instead
5453 of constantly refetching from Emacs object. Use XFASTINT, not
5454 XINT, for value known to be a character. Don't bother comparing
5455 a single byte to 0400, as it's always less.
5456
395fcb93 5457 * floatfns.c (Fexpt):
327eeec8
PE
5458 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5459
abbd3d23
PE
5460 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5461 for characters.
5462
684a03ef
PE
5463 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5464
0fed43f3
PE
5465 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5466 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5467 incorrectly succeed when S was a string, because 4294967386 was
5468 truncated before it was used.
5469
8fd02eb7
PE
5470 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5471 Otherwise, an out-of-range integer could cause undefined behavior
5472 on a 64-bit host.
5473
f8c86b69
PE
5474 * composite.c: Use int, not EMACS_INT, for characters.
5475 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5476 EMACS_INT, for values that are known to be in character range.
5477 This doesn't fix any bugs but is the usual style inside Emacs and
5478 may generate better code on 32-bit machines.
5479
34206dd2
PE
5480 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5481 This is for reasons similar to the recent CHAR_STRING fix.
5482 * charset.c (Fencode_char): Check that character arg is actually
5483 a character. Pass an int to ENCODE_CHAR.
5484 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5485 wider than 'int', as a compile-time check to prevent future regressions
5486 in this area.
5487
c5958d4c 5488 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5489
5490 Make sure a 64-bit char is never passed to CHAR_STRING.
5491 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5492 by silently ignoring the top 32 bits, allowing some values
5493 that were far too large to be valid characters.
5494 * character.h: Include <verify.h>.
5495 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5496 arguments are no wider than unsigned, as a compile-time check
5497 to prevent future regressions in this area.
5498 * data.c (Faset):
01103c44 5499 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5500 (Fsubst_char_in_region):
5501 * fns.c (concat):
5502 * xdisp.c (decode_mode_spec_coding):
5503 Adjust to CHAR_STRING's new requirement.
5504 * editfns.c (Finsert_char, Fsubst_char_in_region):
5505 * fns.c (concat): Check that character args are actually
5506 characters. Without this test, these functions did the wrong
5507 thing with wildly out-of-range values on 64-bit hosts.
5508
d37ca623
PE
5509 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5510 These casts should not be needed on 32-bit hosts, either.
5511 * keyboard.c (read_char):
5512 * lread.c (Fload): Remove casts to unsigned.
5513
ea204efb
PE
5514 * lisp.h (UNSIGNED_CMP): New macro.
5515 This fixes comparison bugs on 64-bit hosts.
5516 (ASCII_CHAR_P): Use it.
5517 * casefiddle.c (casify_object):
01103c44 5518 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5519 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5520 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5521 * dispextern.h (FACE_FROM_ID):
5522 * keyboard.c (read_char): Use UNSIGNED_CMP.
5523
41cb286c
PE
5524 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5525 not to EMACS_INT, to avoid GCC warning.
5526
4a1b9832
PE
5527 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5528
55daad71
PE
5529 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5530 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5531 isn't needed on 32-bit machines.
8f95c75c 5532
01103c44
PE
5533 * buffer.c (Fgenerate_new_buffer_name):
5534 Use EMACS_INT for count, not int.
0ceccced 5535 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5536
5537 * data.c (Qcompiled_function): Now static.
5538
c6f072e7
PE
5539 * window.c (window_body_lines): Now static.
5540
20ce5912
PE
5541 * image.c (gif_load): Rename local to avoid shadowing.
5542
9c4c5f81
PE
5543 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5544 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5545 * alloc.c (make_save_value): Integer argument is now of type
5546 ptrdiff_t, not int.
5547 (mark_object): Use ptrdiff_t, not int.
5548 * lisp.h (pD): New macro.
5549 * print.c (print_object): Use it.
5550
c0c5c8ae
PE
5551 * alloc.c: Use EMACS_INT, not int, to count objects.
5552 (total_conses, total_markers, total_symbols, total_vector_size)
5553 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5554 (total_free_floats, total_floats, total_free_intervals)
5555 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5556 Now EMACS_INT, not int. All uses changed.
5557 (Fgarbage_collect): Compute overall total using a double, so that
5558 integer overflow is less likely to be a problem. Check for overflow
5559 when converting back to an integer.
5a25e253
PE
5560 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5561 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5562 These were 'int' variables that could overflow on 64-bit hosts;
5563 they were never used, so remove them instead of repairing them.
211a0b2a 5564 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5565 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5566 Previously, this ceilinged at INT_MAX, but that doesn't work on
5567 64-bit machines.
e46bb31a 5568 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5569
c78baabf 5570 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5571 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5572 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5573 when a (possibly-narrower) signed value would do just as well.
5574 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5575
c9d624c6
PE
5576 * alloc.c: Catch some string size overflows that we were missing.
5577 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5578 for convenience in STRING_BYTES_MAX.
5579 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5580 The definition here is exact; the one in lisp.h was approximate.
5581 (allocate_string_data): Check for string overflow. This catches
5582 some instances we weren't catching before. Also, it catches
5583 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5584 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5585 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5586
c9d624c6
PE
5587 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5588 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5589 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5590
353032ce
PE
5591 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5592
2bccce07
PE
5593 * alloc.c (Fmake_string): Check for out-of-range init.
5594
0ac30604
SM
55952011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5596
5597 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5598
c195f2de
JD
55992011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5600
5601 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5602 xg_get_default_scrollbar_width.
5603
5604 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5605 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5606 (style_changed_cb): Call update_theme_scrollbar_width and call
5607 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5608 all frames (Bug#8505).
5609 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5610 Call gtk_window_set_resizable if HAVE_GTK3.
5611 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5612 and height if HAVE_GTK3 (Bug#8505).
5613 (scroll_bar_width_for_theme): New variable.
5614 (update_theme_scrollbar_width): New function.
5615 (xg_get_default_scrollbar_width): Move code to
5616 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5617 (xg_initialize): Call update_theme_scrollbar_width.
5618
5619 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5620
5621 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5622
e10ac9f1
MR
56232011-06-12 Martin Rudalics <rudalics@gmx.at>
5624
5625 * frame.c (make_frame): Call other_buffer_safely instead of
5626 other_buffer.
5627
5628 * window.c (temp_output_buffer_show): Call display_buffer with
5629 second argument Vtemp_buffer_show_specifiers and reset latter
5630 immediately after the call.
5631 (Vtemp_buffer_show_specifiers): New variable.
5632 (auto_window_vscroll_p, next_screen_context_lines)
5633 (Vscroll_preserve_screen_position): Remove leading asterisks from
5634 doc-strings.
5635
2d3c217e 56362011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5637
7b7f97e8 5638 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5639 * buffer.c (Qclone_number): Remove for now, as it's unused.
5640 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5641 (record_buffer): Remove unused local.
5642 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5643 (set_frame_buffer_list): Remove; unused.
5644 * frame.h (other_visible_frames): Remove decl.
5645 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5646 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5647 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5648 if HAVE_GPM.
5649 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5650 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5651 Define only if HAVE_GPM.
5652 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5653 (update_hints_inhibit): Remove; never set. All uses removed.
5654 * widgetprv.h (emacsFrameClassRec): Remove decl.
5655 * window.c (delete_deletable_window): Now returns void, since it
5656 wasn't returning anything.
5657 (compare_window_configurations): Remove unused locals.
5658 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5659 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5660 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5661 the same widths as pointers. This follows up on the 2011-05-06 patch.
5662 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5663 * xterm.h: Likewise.
5664 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5665
1384b89e
JB
56662011-06-12 Juanma Barranquero <lekktu@gmail.com>
5667
5668 * makefile.w32-in: Update dependencies.
5669 (LISP_H): Add lib/intprops.h.
5670
1100a63c
CY
56712011-06-11 Chong Yidong <cyd@stupidchicken.com>
5672
5673 * image.c (gif_load): Add animation frame delay to the metadata.
5674 (syms_of_image): Use DEFSYM. New symbol `delay'.
5675
6198ccd0
MR
56762011-06-11 Martin Rudalics <rudalics@gmx.at>
5677
5678 * window.c (delete_deletable_window): Re-add.
5679 (Fset_window_configuration): Rewrite to handle dead buffers and
5680 consequently deletable windows.
5681 (window_tree, Fwindow_tree): Remove. Supply functionality in
5682 window.el.
5683 (compare_window_configurations): Simplify code.
5684
b6e3633c
AS
56852011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5686
1ab0dee5
AS
5687 * image.c (imagemagick_load_image): Fix type mismatch.
5688 (Fimagemagick_types): Likewise.
5689
b6e3633c
AS
5690 * window.h (replace_buffer_in_windows): Declare.
5691
9397e56f
MR
56922011-06-11 Martin Rudalics <rudalics@gmx.at>
5693
5694 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5695 Qclone_number. Remove external declaration of Qdelete_window.
5696 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5697 code.
640c8776
SM
5698 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5699 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5700 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5701 buffer list implementation.
5702 (other_buffer_safely): New function.
5703 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5704 calls to replace_buffer_in_windows and
5705 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5706 if allowed.
5707 (record_buffer): Inhibit quitting and rewrite using quittable
5708 functions. Run Qbuffer_list_update_hook if allowed.
5709 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5710 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5711 Move switch-to-buffer to window.el.
9397e56f
MR
5712 (bury-buffer): Move to window.el.
5713 (Vbuffer_list_update_hook): New variable.
5714
5715 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5716 section.
5717
5718 * window.h (resize_frame_windows): Move up in code.
5719 (Fwindow_frame): Remove EXFUN.
5720 (replace_buffer_in_all_windows): Remove prototype.
5721 (replace_buffer_in_windows_safely): Add prototype.
5722
5723 * window.c: Declare Qdelete_window static again. Move down
5724 declaration of select_count.
5725 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5726 (Fother_window): Move to window.el.
5727 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5728 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5729 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5730 window.el.
5731 (replace_buffer_in_windows): Implement by calling
5732 Qreplace_buffer_in_windows.
5733 (replace_buffer_in_all_windows): Remove with some functionality
5734 moved into replace_buffer_in_windows_safely.
5735 (replace_buffer_in_windows_safely): New function.
5736 (select_window_norecord, select_frame_norecord): Move in front
5737 of run_window_configuration_change_hook. Remove now obsolete
5738 declarations.
640c8776
SM
5739 (Fset_window_buffer): Rewrite doc-string.
5740 Call Qrecord_window_buffer.
9397e56f
MR
5741 (keys_of_window): Move binding for other-window to window.el.
5742
b50691aa
CY
57432011-06-11 Chong Yidong <cyd@stupidchicken.com>
5744
5745 * dispextern.h (struct image): Replace data member, whose int_val
5746 and ptr_val fields were not used by anything, with a single
5747 lisp_val object.
5748
5749 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5750 (gif_clear_image, gif_load, imagemagick_load_image)
5751 (gs_clear_image, gs_load): Callers changed.
5752
3f754b86
PE
57532011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5754
cca69397
PE
5755 * buffer.h: Include <time.h>, for time_t.
5756 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5757
109e28d0
PE
5758 Fix minor problems found by static checking.
5759
60737f02
PE
5760 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5761
4b66faf3
PE
5762 Make identifiers static if they are not used in other modules.
5763 * data.c (Qcompiled_function, Qframe, Qvector):
5764 * image.c (QimageMagick, Qsvg):
5765 * minibuf.c (Qmetadata):
5766 * window.c (resize_window_check, resize_root_window): Now static.
5767 * window.h (resize_window_check, resize_root_window): Remove decls.
5768
109e28d0
PE
5769 * window.c (window_deletion_count, delete_deletable_window):
5770 Remove; unused.
46a4ce9e
PE
5771 (window_body_lines): Now static.
5772 (Fdelete_other_windows_internal): Mark vars as initialized.
5773 Make sure 'resize_failed' is initialized.
5774 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5775 (resize_window_apply): Remove unused local.
5776 * window.h (delete_deletable_window): Remove decl.
5777
109e28d0 5778 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5779 (imagemagick_load_image): Fix pointer signedness problem by changing
5780 last arg from unsigned char * to char *. All uses changed.
5781 Also, fix a local for similar reasons.
5782 Remove unused locals. Remove locals to avoid shadowing.
5783 (fn_rsvg_handle_free): Remove; unused.
5784 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5785 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5786
3f754b86
PE
5787 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5788
2547adb1
CY
57892011-06-10 Chong Yidong <cyd@stupidchicken.com>
5790
5791 * image.c (gif_load): Fix omitted cast error introduced by
5792 2011-06-06 change.
5793
2c8e37d4
MR
57942011-06-10 Martin Rudalics <rudalics@gmx.at>
5795
5796 * window.h (resize_proportionally, orig_total_lines)
5797 (orig_top_line): Remove from window structure.
5798 (set_window_height, set_window_width, change_window_heights)
5799 (Fdelete_window): Remove prototypes.
5800 (resize_frame_windows): Remove duplicate declaration.
5801
440a42e3
EZ
58022011-06-10 Eli Zaretskii <eliz@gnu.org>
5803
5804 * window.h (resize_frame_windows, resize_window_check)
5805 (delete_deletable_window, resize_root_window)
5806 (resize_frame_windows): Declare prototypes.
5807
5808 * window.c (resize_window_apply): Make definition be "static" to
5809 match the prototype.
5810
562dd5e9
MR
58112011-06-10 Martin Rudalics <rudalics@gmx.at>
5812
5813 * window.c: Remove declarations of Qwindow_size_fixed,
5814 window_min_size_1, window_min_size_2, window_min_size,
5815 size_window, window_fixed_size_p, enlarge_window, delete_window.
5816 Remove static from declaration of Qdelete_window, it's
5817 temporarily needed by Fbury_buffer.
5818 (replace_window): Don't assign orig_top_line and
5819 orig_total_lines.
5820 (Fdelete_window, delete_window): Remove. Window deletion is
5821 handled by window.el.
640c8776
SM
5822 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5823 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5824 (Fdelete_other_windows): Remove. Deleting other windows is
5825 handled by window.el.
5826 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5827 handled in window.el.
5828 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5829 Window minimum sizes are handled in window.el.
5830 (shrink_windows, size_window, set_window_height)
5831 (set_window_width, change_window_heights, window_height)
5832 (window_width, CURBEG, CURSIZE, enlarge_window)
5833 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5834 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5835 handled in window.el.
5836 (make_dummy_parent): Rename to make_parent_window and give it a
5837 second argument horflag.
5838 (make_window): Don't set resize_proportionally any more.
5839 (Fsplit_window): Remove. Windows are split in window.el.
5840 (save_restore_action, save_restore_orig_size)
5841 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5842 Resize mini windows in window.el.
5843 (grow_mini_window, shrink_mini_window): Implement by calling
5844 Qresize_root_window_vertically, resize_window_check and
5845 resize_window_apply.
640c8776
SM
5846 (saved_window, Fset_window_configuration, save_window_save):
5847 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5848 resize_proportionally.
5849 (window_min_height, window_min_width): Move to window.el.
5850 (keys_of_window): Move bindings for delete-other-windows,
5851 split-window, delete-window and enlarge-window to window.el.
5852
5853 * buffer.c: Temporarily extern Qdelete_window.
5854 (Fbury_buffer): Temporarily call Qdelete_window instead of
5855 Fdelete_window (Fbury_buffer will move to window.el soon).
5856
5857 * frame.c (set_menu_bar_lines_1): Remove code handling
5858 orig_top_line and orig_total_lines.
5859
5860 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5861 set_window_height but set heights directly.
5862 (change_frame_size_1): Use resize_frame_windows.
5863
5864 * xdisp.c (init_xdisp): Don't use set_window_height but set
5865 heights directly.
5866
640c8776
SM
5867 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5868 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5869 run_window_configuration_change_hook.
5870
5871 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5872 instead of change_window_heights and run
5873 run_window_configuration_change_hook.
5874
1a13852e
MR
58752011-06-09 Martin Rudalics <rudalics@gmx.at>
5876
5877 * window.c (replace_window): Rename second argument REPLACEMENT to
5878 NEW. New third argument SETFLAG. Rewrite.
5879 (delete_window, make_dummy_parent): Call replace_window with
5880 third argument 1.
5881 (window_list_1): Move down in code.
5882 (run_window_configuration_change_hook): Move set_buffer part
5883 before select_frame_norecord part in order to unwind correctly.
5884 Rename count1 to count.
5885 (recombine_windows, delete_deletable_window, resize_root_window)
5886 (Fdelete_other_windows_internal)
5887 (Frun_window_configuration_change_hook, make_parent_window)
5888 (resize_window_check, resize_window_apply, Fresize_window_apply)
5889 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5890 (Fdelete_window_internal, Fresize_mini_window_internal):
5891 New functions.
1a13852e
MR
5892 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5893
f3d1777e
MR
58942011-06-08 Martin Rudalics <rudalics@gmx.at>
5895
496e208e
MR
5896 * window.h (window): Add some new members to window structure -
5897 normal_lines, normal_cols, new_total, new_normal, clone_number,
5898 splits, nest, prev_buffers, next_buffers.
5899 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5900 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5901
f3d1777e
MR
5902 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5903 Remove.
496e208e
MR
5904 (make_dummy_parent): Set new members of windows structure.
5905 (make_window): Move down in code. Handle new members of window
5906 structure.
5907 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5908 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5909 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5910 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5911 (Fset_window_next_buffers, Fset_window_clone_number):
5912 New functions.
496e208e
MR
5913 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5914 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5915 Doc-string fixes.
5916 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5917 Argument WINDOW can be now internal window too.
5918 (Fwindow_use_time): Move up in code.
5919 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5920 Rewrite doc-string.
5921 (Fset_window_configuration, saved_window)
5922 (Fcurrent_window_configuration, save_window_save): Handle new
5923 members of window structure.
b9e809c2
MR
5924 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5925 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5926 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5927 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5928 Qget_mru_window, Qresize_root_window,
5929 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5930 Qauto_buffer_name; staticpro them.
f3d1777e 5931
abde8f8c
MR
59322011-06-07 Martin Rudalics <rudalics@gmx.at>
5933
5934 * window.c (Fwindow_total_size, Fwindow_left_column)
5935 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5936 (Fwindow_list_1): New functions.
5937 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5938 (Fwindow_width, Fscroll_left, Fscroll_right):
5939 Use window_body_cols instead of window_box_text_cols.
5940 (delete_window, Fset_window_configuration):
5941 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5942 (delete_all_subwindows): Take a window as argument and not a
5943 structure. Rewrite.
190b47e6
MR
5944 (window_loop): Remove handling of GET_LRU_WINDOW and
5945 GET_LARGEST_WINDOW.
5946 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5947
5948 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5949 window_box_text_cols. delete_all_subwindows now takes a
5950 Lisp_Object as argument.
abde8f8c 5951
640c8776
SM
5952 * indent.c (compute_motion, Fcompute_motion):
5953 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5954
fa8a67e6
MR
5955 * frame.c (delete_frame): Call delete_all_subwindows with root
5956 window as argument.
5957
a54e3482
DC
59582011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5959
5960 * fns.c (Fputhash): Document return value.
5961
60002bf5
CY
59622011-06-06 Chong Yidong <cyd@stupidchicken.com>
5963
5964 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5965
0c671da6 59662011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5967
b862a52a 5968 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5969
be44ca6c
PE
5970 Check for overflow when converting integer to cons and back.
5971 * charset.c (Fdefine_charset_internal, Fdecode_char):
5972 Use cons_to_unsigned to catch overflow.
5973 (Fencode_char): Use INTEGER_TO_CONS.
5974 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5975 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5976 * data.c (long_to_cons, cons_to_long): Remove.
5977 (cons_to_unsigned, cons_to_signed): New functions.
5978 These signal an error for invalid or out-of-range values.
5979 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5980 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5981 * font.c (Ffont_variation_glyphs):
5982 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5983 * lisp.h: Include <intprops.h>.
5984 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5985 (cons_to_signed, cons_to_unsigned): New decls.
5986 (long_to_cons, cons_to_long): Remove decls.
5987 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5988 (Fprimitive_undo): Use CONS_TO_INTEGER.
5989 * xfns.c (Fx_window_property): Likewise.
5990 * xselect.c: Include <limits.h>.
5991 (x_own_selection, selection_data_to_lisp_data):
5992 Use INTEGER_TO_CONS.
5993 (x_handle_selection_request, x_handle_selection_clear)
5994 (x_get_foreign_selection, Fx_disown_selection_internal)
5995 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5996 (lisp_data_to_selection_data): Use cons_to_unsigned.
5997 (x_fill_property_data): Use cons_to_signed.
5998 Report values out of range.
5999
d1f3d2af
PE
6000 Check for buffer and string overflow more precisely.
6001 * buffer.h (BUF_BYTES_MAX): New macro.
6002 * lisp.h (STRING_BYTES_MAX): New macro.
6003 * alloc.c (Fmake_string):
6004 * character.c (string_escape_byte8):
6005 * coding.c (coding_alloc_by_realloc):
6006 * doprnt.c (doprnt):
6007 * editfns.c (Fformat):
6008 * eval.c (verror):
6009 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
6010 since they may not be the same number.
6011 * editfns.c (Finsert_char):
6012 * fileio.c (Finsert_file_contents):
6013 Likewise for BUF_BYTES_MAX.
6014
dd52fcea
PE
6015 * image.c: Use ptrdiff_t, not int, for sizes.
6016 (slurp_file): Switch from int to ptrdiff_t.
6017 All uses changed.
6018 (slurp_file): Check that file size fits in both size_t (for
6019 malloc) and ptrdiff_t (for sanity and safety).
6020
7f9bbdbb
PE
6021 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
6022 if b->modtime has its maximal value.
6023
dfe18f82
PE
6024 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
6025
84acfcf0
PE
6026 Don't assume time_t can fit into int.
6027 * buffer.h (struct buffer.modtime): Now time_t, not int.
6028 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
6029 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
6030
ccd9a01a
PE
6031 Minor fixes for signed vs unsigned integers.
6032 * character.h (MAYBE_UNIFY_CHAR):
6033 * charset.c (maybe_unify_char):
6034 * keyboard.c (read_char, reorder_modifiers):
6035 XINT -> XFASTINT, since the integer must be nonnegative.
6036 * ftfont.c (ftfont_spec_pattern):
6037 * keymap.c (access_keymap, silly_event_symbol_error):
6038 XUINT -> XFASTINT, since the integer must be nonnegative.
6039 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
6040 since it makes no difference and we prefer signed.
6041 * keyboard.c (record_char): Use XUINT when all the neighbors do.
6042 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
6043 nonnegative.
6044
d6d100dd
SM
60452011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
6046
6047 * window.h (Fwindow_frame): Declare.
6048
2b6148e4
PE
60492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6050
6051 * alloc.c: Simplify handling of large-request failures (Bug#8800).
6052 (SPARE_MEMORY): Always define.
6053 (LARGE_REQUEST): Remove.
6054 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
6055
f230ecc9
MR
60562011-06-06 Martin Rudalics <rudalics@gmx.at>
6057
727e958e
MR
6058 * lisp.h: Move EXFUNS for Fframe_root_window,
6059 Fframe_first_window and Fset_frame_selected_window to window.h.
6060
6061 * window.h: Move EXFUNS for Fframe_root_window,
6062 Fframe_first_window and Fset_frame_selected_window here from
6063 lisp.h.
6064
6065 * frame.c (Fwindow_frame, Fframe_first_window)
6066 (Fframe_root_window, Fframe_selected_window)
6067 (Fset_frame_selected_window): Move to window.c.
6068 (Factive_minibuffer_window): Move to minibuf.c.
6069 (Fother_visible_frames_p): New function.
6070
6071 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
6072
f230ecc9
MR
6073 * window.c (decode_window, decode_any_window): Move up in code.
6074 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
6075 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
6076 (Fwindow_buffer): Move up and rewrite doc-string.
6077 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
6078 (Fwindow_prev): New functions.
727e958e
MR
6079 (Fwindow_frame): Move here from frame.c. Accept any window as
6080 argument.
6081 (Fframe_root_window, Fframe_first_window)
6082 (Fframe_selected_window): Move here from frame.c. Accept frame
6083 or arbitrary window as argument. Update doc-strings.
6084 (Fminibuffer_window): Move up in code.
6085 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
6086 (Fset_frame_selected_window): Move here from frame.c.
6087 Marginal rewrite.
727e958e
MR
6088 (Fselected_window, select_window, Fselect_window): Move up in
6089 code. Minor doc-string fixes.
f230ecc9 6090
4d09bcf6
PE
60912011-06-06 Paul Eggert <eggert@cs.ucla.edu>
6092
6093 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
6094 Do not assume that spare memory exists; that assumption is valid
6095 only if SYSTEM_MALLOC.
6096 (LARGE_REQUEST): New macro, so that the issue of large requests
6097 is separated from the issue of spare memory.
6098
810928a2
AS
60992011-06-05 Andreas Schwab <schwab@linux-m68k.org>
6100
172418ad
AS
6101 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
6102 format. (Bug#8806)
6103
43f862f7
AS
6104 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
6105
810928a2
AS
6106 * xfns.c (x_set_scroll_bar_default_width): Move declarations
6107 before statements.
6108
a059fe24
JD
61092011-06-05 Jan Djärv <jan.h.d@swipnet.se>
6110
6111 * gtkutil.c (xg_get_default_scrollbar_width): New function.
6112
6113 * gtkutil.h: Declare xg_get_default_scrollbar_width.
6114
6115 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
6116 min width by calling x_set_scroll_bar_default_width (Bug#8505).
6117
989bf368
JB
61182011-06-05 Juanma Barranquero <lekktu@gmail.com>
6119
6120 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
6121
4b80f674
CY
61222011-06-04 Chong Yidong <cyd@stupidchicken.com>
6123
6124 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
6125 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
6126 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
6127 New error handlers.
4b80f674
CY
6128 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
6129 Obey Vx_select_enable_clipboard_manager. Catch errors in
6130 x_clipboard_manager_save (Bug#8779).
6131 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 6132 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 6133
99a33b77 61342011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
6135
6136 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
6137
99a33b77 61382011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
6139
6140 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
6141 in the current matrix if keep_current_p is non-zero.
6142
8264569d
EZ
61432011-06-04 Eli Zaretskii <eliz@gnu.org>
6144
6145 * bidi.c (bidi_level_of_next_char): Fix last change.
6146
57f97249
EZ
61472011-06-03 Eli Zaretskii <eliz@gnu.org>
6148
fec2107c 6149 Support bidi reordering of text covered by display properties.
57f97249 6150
fec2107c
EZ
6151 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6152 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6153 (bidi_cache_search, bidi_cache_iterator_state)
6154 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6155 (bidi_level_of_next_char, bidi_move_to_visually_next):
6156 Support character positions inside a run of characters covered by a
fec2107c
EZ
6157 display string.
6158 (bidi_paragraph_init, bidi_resolve_explicit_1)
6159 (bidi_level_of_next_char): Call bidi_fetch_char and
6160 bidi_fetch_char_advance instead of FETCH_CHAR and
6161 FETCH_CHAR_ADVANCE.
6162 (bidi_init_it): Initialize new members.
6163 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6164 definitions.
6165 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6166 instead of using explicit *_CHAR codes.
d6d100dd
SM
6167 (bidi_resolve_explicit, bidi_resolve_weak):
6168 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6169 bidirectional text is supported only in multibyte buffers.
6170 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6171 it to initialize the frame_window_p member of struct bidi_it.
6172 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6173 (bidi_resolve_explicit, bidi_resolve_weak)
6174 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6175 bidi_it->nchars is non-positive.
6176 (bidi_level_of_next_char): Don't try to lookup the cache for the
6177 next/previous character if nothing is cached there yet, or if we
6178 were just reseat()'ed to a new position.
c40e2fb2 6179
0e14fe90
EZ
6180 * xdisp.c (set_cursor_from_row): Set start and stop points
6181 according to the row's direction when priming the loop that looks
6182 for the glyph on which to display cursor.
6183 (single_display_spec_intangible_p): Function deleted.
6184 (display_prop_intangible_p): Reimplement to call
6185 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6186 Accept 3 additional arguments needed by handle_display_spec.
6187 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6188 values: lists, `(when COND...)' forms, etc.
6189 (single_display_spec_string_p): Support property values that are
6190 lists with the argument STRING its top-level element.
6191 (display_prop_string_p): Fix the condition for processing a
6192 property that is a list to be consistent with handle_display_spec.
fec2107c 6193 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6194 last portion of handle_display_prop.
6195 (compute_display_string_pos): Accept additional argument
6196 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6197 value of a `display' property is a "replacing spec".
6198 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6199 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6200 the display property, but just return a value indicating whether
6201 the display property will replace the characters it covers.
6202 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6203 frame_window_p members of struct bidi_it.
d6d100dd
SM
6204 (compute_display_string_pos, compute_display_string_end):
6205 New functions.
fec2107c
EZ
6206 (push_it): Accept second argument POSITION, where pop_it should
6207 jump to continue iteration.
6208 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6209
fec2107c
EZ
6210 * keyboard.c (adjust_point_for_property): Adjust the call to
6211 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6212
6213 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6214 (bidi_init_it): Update prototypes.
6215 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6216 (compute_display_string_pos, compute_display_string_end):
6217 Declare prototypes.
fec2107c
EZ
6218 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6219 EMACS_INT.
fc6f18ce 6220
40087514 62212011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6222
57f53182
PE
6223 Malloc failure behavior now depends on size of allocation.
6224 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6225 * lisp.h: Change signatures accordingly.
6226 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6227 All callers changed. (Bug#8762)
6228
6229 * gnutls.c: Use Emacs's memory allocators.
6230 Without this change, the gnutls library would invoke malloc etc.
6231 directly, which causes problems on non-SYNC_INPUT hosts, and which
6232 runs afoul of improving memory_full behavior. (Bug#8761)
6233 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6234 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6235 xfree instead of the default malloc, realloc, free.
6236 (Fgnutls_boot): No need to check for memory allocation failure,
6237 since xmalloc does that for us.
6238
ac32cd99 6239 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6240 * category.c (hash_get_category_set):
6241 * ccl.c (ccl_driver):
6242 * charset.c (Fdefine_charset_internal):
6243 * charset.h (struct charset.hash_index):
6244 * composite.c (get_composition_id, gstring_lookup_cache)
6245 (composition_gstring_put_cache):
6246 * composite.h (struct composition.hash_index):
6247 * dispextern.h (struct image.hash):
6248 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6249 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6250 (hashfn_equal, hashfn_user_defined, make_hash_table)
6251 (maybe_resize_hash_table, hash_lookup, hash_put)
6252 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6253 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6254 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6255 * image.c (make_image, search_image_cache, lookup_image)
6256 (xpm_put_color_table_h):
6257 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6258 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6259 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6260 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6261 * alloc.c (allocate_vectorlike):
6262 Check for overflow in vector size calculations.
6263 * ccl.c (ccl_driver):
6264 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6265 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6266 need to be updated by these changes.
40087514
PE
6267 * fns.c (make_hash_table, maybe_resize_hash_table):
6268 Check for integer overflow with large hash tables.
0de4bb68
PE
6269 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6270 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6271 (SXHASH_REDUCE): New macro.
6272 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6273 Use it instead of discarding useful hash info with large hash values.
6274 (sxhash_float): New function.
6275 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6276 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6277 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6278 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6279 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6280 Adjust signatures to match updated version of code.
6281 (consing_since_gc): Now EMACS_INT, since a single hash table can
6282 use more than INT_MAX bytes.
6283
698d32e2
DN
62842011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6285
6286 Make it possible to build with GCC-4.6+ -O2 -flto.
6287
6288 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6289
fd6fa53f
SM
62902011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6291
6292 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6293 Call minibuffer-inactive-mode.
6294
864db017
JB
62952011-05-31 Juanma Barranquero <lekktu@gmail.com>
6296
6297 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6298 Update dependencies.
6299
2ad0baf4
DN
63002011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6301
6302 * data.c (init_data): Remove code for UTS, this system is not
6303 supported anymore.
6304
4fcc2638
DN
63052011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6306
6307 Don't force ./temacs to start in terminal mode.
6308
6309 * frame.c (make_initial_frame): Initialize faces in all cases, not
6310 only when CANNOT_DUMP is defined.
6311 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6312
c56e0fd5
DN
63132011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6314
6315 * dispnew.c (add_window_display_history): Use const for the string
6316 pointer. Remove declaration, not needed.
6317
333d54da 63182011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6319
55d4c1b2 6320 Use 'inline', not 'INLINE'.
333d54da 6321 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6322 * alloc.c, fontset.c (INLINE): Remove.
6323 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6324 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6325 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6326 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6327 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6328
738db178
DN
63292011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6330
6331 Make it possible to run ./temacs.
6332
6333 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6334 syms_of_callproc does the same thing. Remove test for
6335 "initialized", do it in the caller.
6336 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6337
620c53a6
SM
63382011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6339
6340 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6341 (read_minibuf): Use get_minibuffer.
6342 (syms_of_minibuf): Use DEFSYM.
6343 (Qmetadata): New var.
6344 * data.c (Qbuffer): Don't make it static.
6345 (syms_of_data): Use DEFSYM.
6346
e003a292
PE
63472011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6348
6349 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6350 (CCL_CODE_MIN): New macro.
6351
ed008a6d
PE
63522011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6353
3687c2ef
PE
6354 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6355
ed008a6d
PE
6356 * eval.c (Qdebug): Now static.
6357 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6358 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6359 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6360
d66c4c7c
CY
63612011-05-29 Chong Yidong <cyd@stupidchicken.com>
6362
6363 * image.c: Various fixes to ImageMagick code comments.
6364 (Fimagemagick_types): Doc fix.
6365
5fbc2025
PE
63662011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6367
0196f88a
PE
6368 Minor fixes prompted by GCC 4.6.0 warnings.
6369
6370 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6371
5fbc2025
PE
6372 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6373 (x_clipboard_manager_save_all): Move extern decl to ...
6374 * xterm.h: ... here, so that it can be checked for consistency.
6375
1dd3c2d9
CY
63762011-05-29 Chong Yidong <cyd@stupidchicken.com>
6377
6378 * xselect.c (x_clipboard_manager_save_frame)
6379 (x_clipboard_manager_save_all): New functions.
6380 (Fx_clipboard_manager_save): Lisp function deleted.
6381
6382 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6383 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6384
6385 * xterm.h: Update prototype.
6386
5ba6571d
WX
63872011-05-28 William Xu <william.xwl@gmail.com>
6388
6389 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6390 exiting (Bug#8239).
6391
3eaff834
JM
63922011-05-28 Jim Meyering <meyering@redhat.com>
6393
e1900994 6394 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6395 * fns.c (to_uchar): Define.
6396 (crypto_hash_function): Use it to convert some newly-signed
6397 variables to unsigned, to avoid sign-extension bugs. For example,
6398 without this change, (md5 "truc") would evaluate to
6399 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6400 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6401 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6402
0f6990a7
PE
64032011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6404
6405 Integer overflow fixes.
c8a9ca5a 6406
08686060
PE
6407 * dbusbind.c: Serial number integer overflow fixes.
6408 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6409 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6410 to hold a serial number that is too large for a fixnum.
6411 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6412 Check for serial numbers out of range. Decode any serial number
59568bf0 6413 that was so large that it became a float. (Bug#8722)
08686060 6414
2d1fc3c7
PE
6415 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6416 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6417 Use XFASTINT rather than XUINT when numbers are nonnegative.
6418 (xd_append_arg, Fdbus_method_return_internal):
6419 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6420 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6421 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6422 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6423 (Bug#8722)
2d1fc3c7 6424
c8a9ca5a
PE
6425 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6426
519e1d69
PE
6427 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6428
6df6ae42 6429 ccl: Add integer overflow checks.
30569699
PE
6430 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6431 (IN_INT_RANGE): New macros.
6432 (ccl_driver): Use them to check for integer overflow when
6433 decoding a CCL program. Many of the new checks are whether XINT (x)
6434 fits in int; it doesn't always, on 64-bit hosts. The new version
6435 doesn't catch all possible integer overflows, but it's an
847044ea 6436 improvement. (Bug#8719)
30569699 6437
c11285dc
PE
6438 * alloc.c (make_event_array): Use XINT, not XUINT.
6439 There's no need for unsigned here.
6440
fdccd48e
PE
6441 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6442 This follows up to the 2011-05-06 change that substituted uintptr_t
6443 for EMACS_INT. This case wasn't caught back then.
6444
37910ab2
PE
6445 Rework Fformat to avoid integer overflow issues.
6446 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6447 now (part of C89). Include <verify.h>.
6448 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6449 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6450 (Fformat): Avoid the prepass trying to compute sizes; it was only
6451 approximate and thus did not catch overflow reliably. Instead, walk
6452 through the format just once, formatting and computing sizes as we go,
6453 checking for integer overflow at every step, and allocating a larger
6454 buffer as needed. Keep track separately whether the format is
6455 multibyte. Keep only the most-recently calculated precision, rather
6456 than them all. Record whether each argument has been converted to
6457 string. Use EMACS_INT, not int, for byte and char and arg counts.
6458 Support field widths and precisions larger than INT_MAX. Avoid
6459 sprintf's undefined behavior with conversion specifications such as %#d
6460 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6461 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6462 formatting out-of-range floating point numbers with int
9173deec 6463 formats. (Bug#8668)
37910ab2 6464
2e6578fb
PE
6465 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6466
0ae6bdee
PE
6467 * data.c: Avoid integer truncation in expressions involving floats.
6468 * data.c: Include <intprops.h>.
6469 (arith_driver): When there's an integer overflow in an expression
6470 involving floating point, convert the integers to floating point
6471 so that the resulting value does not suffer from catastrophic
6472 integer truncation. For example, on a 64-bit host (* 4
6473 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6474 Do not rely on undefined behavior after integer overflow.
6475
de883a70
PE
6476 merge count_size_as_multibyte, parse_str_to_multibyte
6477 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6478 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6479 Check for integer overflow.
6480 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6481 since it's now a duplicate of the other. This is more of
6482 a character than a buffer op, so better that it's in character.c.
6483 * fns.c, print.c: Adjust to above changes.
6484
2ff916cb
PE
64852011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6486
6487 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6488
f1b54466
PE
64892011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6490
fb1ac845
PE
6491 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6492 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6493 (x_clipboard_manager_save): Now static.
6494 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6495
f1b54466
PE
6496 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6497 (crypto_hash_function): Now static.
6498 Fix pointer signedness problems. Avoid unnecessary initializations.
6499
a9f737ee
CY
65002011-05-27 Chong Yidong <cyd@stupidchicken.com>
6501
6502 * termhooks.h (Vselection_alist): Make it terminal-local.
6503
6504 * terminal.c (create_terminal): Initialize it.
6505
6506 * xselect.c: Support for clipboard managers.
6507 (Vselection_alist): Move to termhooks.h as terminal-local var.
6508 (LOCAL_SELECTION): New macro.
6509 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6510 (symbol_to_x_atom): Remove gratuitous arg.
6511 (x_handle_selection_request, lisp_data_to_selection_data)
6512 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6513 (x_own_selection, x_get_local_selection, x_convert_selection):
6514 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6515 (some_frame_on_display): Delete unused function.
6516 (Fx_own_selection_internal, Fx_get_selection_internal)
6517 (Fx_disown_selection_internal, Fx_selection_owner_p)
6518 (Fx_selection_exists_p): New optional frame arg.
6519 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6520 (x_handle_selection_clear): Don't treat other terminals with the
6521 same keyboard specially. Use the terminal-local Vselection_alist.
6522 (x_clear_frame_selections): Use Frun_hook_with_args.
6523
6524 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6525
6526 * xterm.h: Add support for those atoms.
6527
e067f0c1
CY
65282011-05-26 Chong Yidong <cyd@stupidchicken.com>
6529
6530 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6531 (converted_selections, conversion_fail_tag): New global variables.
6532 (x_selection_request_lisp_error): Free the above.
6533 (x_get_local_selection): Remove unnecessary code.
6534 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6535 of converted selections stored in converted_selections.
6536 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6537 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6538 (x_convert_selection): New function.
6539 (x_handle_selection_event): Simplify.
6540 (x_get_foreign_selection): Don't ignore incoming requests while
6541 waiting for an answer; this will fail when we implement
6542 SAVE_TARGETS, and seems unnecessary anyway.
6543 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6544 (Vx_sent_selection_functions): Doc fix.
6545
0f4aebc0
LL
65462011-05-26 Leo Liu <sdl.web@gmail.com>
6547
6548 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6549
e61124cd
YM
65502011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6551
6552 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6553
6554 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6555 for fringe update if it has periodic bitmap.
ac389d0c 6556 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6557 and fringe_bitmap_periodic_p.
6558
6559 * fringe.c (get_fringe_bitmap_data): New function.
6560 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6561 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6562 row. Mark glyph row for fringe update if periodicity changed.
6563
6564 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6565 for fringe update unless it has periodic bitmap.
6566
f16d9837
KH
65672011-05-25 Kenichi Handa <handa@m17n.org>
6568
6569 * xdisp.c (get_next_display_element): Set correct it->face_id for
6570 a static composition.
6571
e1b90ef6
LL
65722011-05-24 Leo Liu <sdl.web@gmail.com>
6573
6574 * deps.mk (fns.o):
6575 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6576
6577 * fns.c (crypto_hash_function, Fsha1): New function.
6578 (Fmd5): Use crypto_hash_function.
6579 (syms_of_fns): Add Ssha1.
6580
7400048f
PE
65812011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6582
6583 * gnutls.c: Remove unused macros.
6584 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6585 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6586 Remove macros that are defined and never used.
6587 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6588
abb71cf4
CY
65892011-05-22 Chong Yidong <cyd@stupidchicken.com>
6590
6591 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6592 (Fx_get_selection_internal): Minor cleanup.
6593 (Fx_own_selection_internal): Rename arguments for consistency with
6594 select.el.
6595
6307db39
PE
65962011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6597
6598 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6599
f3d4e0a4
CY
66002011-05-22 Chong Yidong <cyd@stupidchicken.com>
6601
6602 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6603
4d8ade89
YM
66042011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6605
6606 * dispnew.c (scrolling_window): Don't exclude the case that the
6607 last enabled row in the desired matrix touches the bottom boundary.
6608
32078c8d
GM
66092011-05-21 Glenn Morris <rgm@gnu.org>
6610
6611 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6612 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6613 and add some more files.
32078c8d 6614
7285dc67
EZ
66152011-05-20 Eli Zaretskii <eliz@gnu.org>
6616
6617 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6618 report_file_error introduced by the change from 2011-05-07.
6619
89d1bd22
PE
66202011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6621
6622 * systime.h (Time): Define only if emacs is defined.
6623 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6624 where the include path doesn't have X11/X.h by default. See
6625 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6626
cd394be1 66272011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6628
6629 * composite.c (find_automatic_composition): Fix previous change.
6630
b9704ad9
GM
66312011-05-20 Glenn Morris <rgm@gnu.org>
6632
6633 * lisp.mk: New file, split from Makefile.in.
6634 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6635 (shortlisp): Remove.
6636 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6637
4a720484
GM
66382011-05-19 Glenn Morris <rgm@gnu.org>
6639
6640 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6641 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6642 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6643 (lisp): Set the order to that of loadup.el.
6644 (shortlisp): Make it a copy of $lisp.
6645 (SOME_MACHINE_LISP): Remove.
6646 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6647 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6648
a28d4396
KH
66492011-05-18 Kenichi Handa <handa@m17n.org>
6650
6651 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6652 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6653 (find_automatic_composition): Mostly rewrite for efficiency.
6654
a2b1fa8e
JB
66552011-05-18 Juanma Barranquero <lekktu@gmail.com>
6656
6657 * makefile.w32-in: Update dependencies.
6658
8e1f5610
CS
66592011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6660
6661 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6662 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6663
7025ee00 66642011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6665
cdfa6eab
PE
6666 Fix some integer overflow issues, such as string length overflow.
6667
06d6db33
PE
6668 * insdel.c (count_size_as_multibyte): Check for string overflow.
6669
2b4560a8
PE
6670 * character.c (lisp_string_width): Check for string overflow.
6671 Use EMACS_INT, not int, for string indexes and lengths; in
6672 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6673 the resulting string length overflows an EMACS_INT; instead,
6674 report a string overflow if no precision given. When checking for
6675 precision exhaustion, use a check that cannot possibly have
6676 integer overflow. (Bug#8675)
6677 * character.h (lisp_string_width): Adjust to new signature.
6678
cb93f9be
PE
6679 * alloc.c (string_overflow): New function.
6680 (Fmake_string): Use it. This doesn't change behavior, but saves
6681 a few bytes and will simplify future changes.
6682 * character.c (string_escape_byte8): Likewise.
6683 * lisp.h (string_overflow): New decl.
6684
1a1f3366
PE
6685 Fixups, following up to the user-interface timestamp change.
6686 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6687 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6688 * msdos.c (mouse_get_pos): Likewise.
6689 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6690 * w32gui.h (Time): Define by including "systime.h" rather than by
6691 declaring it ourselves. (Bug#8664)
6692
d4e3e4d3
PE
6693 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6694 * image.c (clear_image_cache): Likewise.
6695
f6a24d19
PE
6696 * term.c (term_mouse_position): Don't assume time_t wraparound.
6697
08dc5ae6
PE
6698 Be more systematic about user-interface timestamps.
6699 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6700 and sometimes 'EMACS_UINT', to represent these timestamps.
6701 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6702 This makes the code easier to follow, and makes it easier to catch
6703 integer overflow bugs such as Bug#8664.
6704 * frame.c (Fmouse_position, Fmouse_pixel_position):
6705 Use Time, not unsigned long, for user-interface timestamps.
6706 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6707 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6708 * keyboard.h (last_event_timestamp): Likewise.
6709 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6710 * menu.h (xmenu_show): Likewise.
6711 * term.c (term_mouse_position): Likewise.
6712 * termhooks.h (struct input_event.timestamp): Likewise.
6713 (struct terminal.mouse_position_hook): Likewise.
6714 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6715 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6716 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6717 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6718 what it was before.
6719 * menu.h, termhooks.h: Include "systime.h", for Time.
6720
8e55734a
PE
6721 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6722 Don't assume that the difference between two unsigned long values
6723 can fit into an integer. At this point, we know button_down_time
6724 <= event->timestamp, so the difference must be nonnegative, so
6725 there's no need to cast the result if double-click-time is
6726 nonnegative, as it should be; check that it's nonnegative, just in
6727 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6728 apart (about 25 days). (Bug#8664)
8e55734a 6729
841f1b75 6730 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6731 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6732
3e26f69c
PE
6733 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6734 that always fit in int. Use a sentinel instead of a counter, to
6735 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6736 * frame.h (struct frame): Use int for menu_bar_items_used
6737 instead of EMACS_INT, since it always fits in int.
3e26f69c 6738
5cc152c0
PE
6739 * menu.c (grow_menu_items): Check for int overflow.
6740
d89eb65e
PE
6741 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6742
5235bd3e
PE
6743 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6744 Before, the code was not consistent. These values cannot exceed
6745 2**31 - 1 so there's no need to make them unsigned.
6746 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6747 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6748 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6749 as modifiers.
6750 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6751
bc827e23
PE
6752 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6753 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6754 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6755 presumably because the widths might not match.
6756
78eb494e
PE
6757 * window.c (size_window): Avoid needless test at loop start.
6758
04f2d78b
CB
67592011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6760
6761 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6762
d2fc7e3d 67632011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6764
6765 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6766
d2fc7e3d 67672011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6768
6769 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6770 `width' to `bar_area_x' and `bar_area_width', respectively.
6771 (x_scroll_run): Take account of fringe background extension.
6772
04f2d78b
CB
6773 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6774 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6775 `bar_area_width', respectively.
6776 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6777 background extension.
6778
79b70037
GM
67792011-05-10 Jim Meyering <meyering@redhat.com>
6780
6781 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6782
2f142cc5
JB
67832011-05-10 Juanma Barranquero <lekktu@gmail.com>
6784
6785 * image.c (Finit_image_library): Return t for built-in image types,
6786 like pbm and xbm. (Bug#8640)
6787
57679c86
AS
67882011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6789
6790 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6791
888c9e86
EZ
67922011-05-07 Eli Zaretskii <eliz@gnu.org>
6793
b0512a1d
EZ
6794 * w32console.c (Fset_screen_color): Doc fix.
6795 (Fget_screen_color): New function.
6796 (syms_of_ntterm): Defsubr it.
6797
7285dc67
EZ
6798 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6799 unlink the temporary file if Fcall_process didn't create it in the
6800 first place.
6801 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6802 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6803 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6804 cue to call_process_cleanup not to close that handle.
6805
4d3fcc8e
BK
68062011-05-07 Ben Key <bkey76@gmail.com>
6807
6808 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6809 one of two shell specific rules, either bootstrap-temacs-CMD or
6810 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6811 to the previous implementation of the bootstrap-temacs rule.
6812 The bootstrap-temacs-CMD rule is similar to the previous
6813 implementation of the bootstrap-temacs rule except that it
6814 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6815 variable.
6816
6817 These changes, along with some changes to nt/configure.bat,
6818 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6819 earlier fix to add support for --cflags and --ldflags options
6820 that include quotes so that it works whether make uses cmd or
6821 sh as the shell.
6822
b4289b64
MA
68232011-05-06 Michael Albinus <michael.albinus@gmx.de>
6824
6825 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6826 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6827 is a constant.
6828 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6829 a string. Handle both cases.
6830 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6831 (Fdbus_register_method): Use Qinvalid_function.
6832
af4c0e28
JB
68332011-05-06 Juanma Barranquero <lekktu@gmail.com>
6834
6835 * makefile.w32-in: Update dependencies.
6836 (LISP_H): Add inttypes.h and stdin.h.
6837 (PROCESS_H): Add unistd.h.
6838
c51453d9
EZ
68392011-05-06 Eli Zaretskii <eliz@gnu.org>
6840
6841 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6842 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6843
8ff0ac3c 68442011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6845
4c4b566b
PE
6846 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6847
aab2b9b5
PE
6848 * term.c (vfatal): Remove stray call to va_end.
6849 It's not needed and the C Standard doesn't allow it here anyway.
6850
c378da0b
PE
6851 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6852 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6853
288b08c7
PE
6854 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6855 bytes.
6856
e3601888
PE
6857 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6858
db6c0e74
PE
6859 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6860
dd5963ea
PE
6861 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6862
88c9450f
PE
6863 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6864
2f9442b8
PE
6865 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6866
c032b5f8
PE
6867 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6868 * charset.c (Fdefine_charset_internal): Don't initialize
6869 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6870 32-bit int (Bug#8600).
a108c10b
PE
6871
6872 * lread.c (read_integer): Be more consistent with string-to-number.
6873 Use string_to_number to do the actual conversion; this avoids
6874 rounding errors and fixes some other screwups. Without this fix,
6875 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6876 (digit_to_number): Move earlier, for benefit of read_integer.
6877 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6878 not a digit in any supported base. (Bug#8602)
a108c10b 6879
ad5f9eea
PE
6880 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6881
aec1708a
PE
6882 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6883 to match comment at start of function. This also removes a
6884 GCC warning about overflow in a 32+64-bit port.
6885
47be4ab5
PE
6886 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6887
371cac43
PE
6888 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6889 Reported by Stefan Monnier in
6890 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6891 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6892 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6893
d01a7826
PE
6894 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6895 (EMACS_UINTPTR): Likewise, with uintptr_t.
6896
7fd47d5c
PE
6897 * lisp.h: Prefer 64-bit EMACS_INT if available.
6898 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6899 on 32-bit hosts that have 64-bit int, so that they can access
6900 large files.
122b0c86
PE
6901 However, temporarily disable this change unless the temporary
6902 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6903
8727937b
PE
6904 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6905
8ac068ac
PE
6906 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6907 This removes an assumption that EMACS_INT and long are the same
6908 width as pointers. The assumption is true for Emacs porting targets
6909 now, but we want to make other targets possible.
6910 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6911 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6912 In the rest of the code, change types of integers that hold casted
6913 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6914 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6915 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6916 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6917 No need to cast type when ORing.
6918 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6919 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6920 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6921 assume EMACS_INT is the same width as char *.
6922 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6923 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6924 Remove no-longer-needed casts.
6925 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6926 (xg_tool_bar_help_callback, xg_make_tool_item):
6927 Use EMACS_INTPTR to hold an integer
6928 that will be cast to void *; this can avoid a GCC warning
6929 if EMACS_INT is not the same width as void *.
6930 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6931 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6932 (current_message_1, set_message_1):
6933 Use a local to convert to proper width without a cast.
6934 * xmenu.c (dialog_selection_callback): Likewise.
6935
ede49d71
PE
6936 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6937 Also, don't assume VALBITS / RAND_BITS is less than 5,
6938 and don't rely on undefined behavior when shifting a 1 left into
6939 the sign bit.
6940 * lisp.h (get_random): Change signature to match.
6941
2f30ecd0
PE
6942 * lread.c (hash_string): Use size_t, not int, for hash computation.
6943 Normally we prefer signed values; but hashing is special, because
6944 it's better to use unsigned division on hash table sizes so that
6945 the remainder is nonnegative. Also, size_t is the natural width
6946 for hashing into memory. The previous code used 'int', which doesn't
6947 retain enough info to hash well into very large tables.
6948 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6949
2a866e7b
PE
6950 * dbusbind.c: Don't possibly lose pointer info when converting.
6951 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6952 Use XPNTR rather than XHASH, so that the high-order bits of
6953 the pointer aren't lost when converting through void *.
6954
51639eac
PE
6955 * eval.c (Fautoload): Don't double-shift a pointer.
6956
92394119
PE
6957 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6958
dbdb9a7c
JB
69592011-05-06 Juanma Barranquero <lekktu@gmail.com>
6960
6961 * gnutls.c (DEF_GNUTLS_FN):
6962 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6963
db7a0b4f
AS
69642011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6965
6966 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6967 marker. (Bug#8610)
6968
cd394be1 69692011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6970
6971 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6972 New version that can reserve upto 2GB of heap space.
6973
f7ff1b0f 69742011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6975
6976 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6977
639c109b
TZ
69782011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6979
6980 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6981 `gnutls_certificate_set_x509_key_file'.
6982
d2127135
JB
69832011-05-05 Juanma Barranquero <lekktu@gmail.com>
6984
6985 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6986 Update dependencies.
6987
e968f4f3
JB
69882011-05-04 Juanma Barranquero <lekktu@gmail.com>
6989
6990 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6991 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6992 Remove unused parameter `fildes'.
6993 * process.c (read_process_output, send_process): Don't pass it.
6994
84d358f0
JB
69952011-05-04 Juanma Barranquero <lekktu@gmail.com>
6996
6997 Fix previous change: the library cache is defined in w32.c.
6998 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6999 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
7000
0898ca10
JB
70012011-05-04 Juanma Barranquero <lekktu@gmail.com>
7002
7003 Implement dynamic loading of GnuTLS on Windows.
7004
7005 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
7006 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
7007 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7008 Declare.
7009
7010 * gnutls.c (Qgnutls_dll): Define.
7011 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
7012 (gnutls_*): Declare function pointers.
7013 (init_gnutls_functions): New function to initialize function pointers.
7014 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
7015 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
7016 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
7017 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
7018 (emacs_gnutls_write, emacs_gnutls_read)
7019 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
7020 (Fgnutls_available_p): New function.
7021 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
7022 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
7023 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
7024
7025 * image.c: Include w32.h.
7026 (Vimage_type_cache): Delete.
7027 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
7028 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
7029 (w32_delayed_load): Move to w32.c.
7030
7031 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
7032
7033 * w32.c (QCloaded_from, Vlibrary_cache): Define.
7034 (w32_delayed_load): Move from image.c. When loading a library, record
7035 its filename in the :loaded-from property of the library id.
7036 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
7037 Initialize and staticpro them.
7038 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
7039
7040 * process.c: Include lisp.h before w32.h, not after.
7041 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
7042 instead of gnutls_record_check_pending.
7043
7044 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
7045
ff4de4aa
TZ
70462011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
7047
7048 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
7049 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
7050 as passed in.
7051
abe95abb
JD
70522011-05-03 Jan Djärv <jan.h.d@swipnet.se>
7053
7054 * xterm.c (x_set_frame_alpha): Do not set property on anything
7055 else than FRAME_X_OUTER_WINDOW (Bug#8608).
7056
e16e55d4
JB
70572011-05-02 Juanma Barranquero <lekktu@gmail.com>
7058
7059 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
7060
bafcf6a5
JB
70612011-05-02 Juanma Barranquero <lekktu@gmail.com>
7062
7063 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
7064 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
7065 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
7066 (gnutls_global_initialized, Qgnutls_bootprop_priority)
7067 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
7068 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
7069 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
7070 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
7071 (Qgnutls_bootprop_callbacks_verify): Make static.
7072
e7a6747f
AS
70732011-05-01 Andreas Schwab <schwab@linux-m68k.org>
7074
19ed11ba
AS
7075 * callproc.c: Indentation fixup.
7076
e7a6747f 7077 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
7078 (wait_for_termination, interruptible_wait_for_termination):
7079 Move after wait_for_termination_1.
e7a6747f 7080
1ef14cb4
LMI
70812011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
7082
7083 * sysdep.c (interruptible_wait_for_termination): New function
7084 which is like wait_for_termination, but allows keyboard
7085 interruptions.
7086
7087 * callproc.c (Fcall_process): Add (:file "file") as an option for
7088 the STDOUT buffer.
7089 (Fcall_process_region): Ditto.
7090
330d880c
EZ
70912011-04-30 Eli Zaretskii <eliz@gnu.org>
7092
8db90b73
EZ
7093 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
7094 rather than `XVECTOR (FOO)->size'.
7095
330d880c
EZ
7096 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
7097 inttypes.h, as a gnulib replacement is used if it not available in
7098 system headers.
7099
15cbd324
EZ
71002011-04-21 Eli Zaretskii <eliz@gnu.org>
7101
7102 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
7103 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
7104 of MOST_POSITIVE_FIXNUM. (Bug#8528)
7105
7106 * coding.c (coding_alloc_by_realloc): Error out if destination
7107 will grow beyond MOST_POSITIVE_FIXNUM.
7108 (decode_coding_emacs_mule): Abort if there isn't enough place in
7109 charbuf for the composition carryover bytes. Reserve an extra
7110 space for up to 2 characters produced in a loop.
7111 (decode_coding_iso_2022): Abort if there isn't enough place in
7112 charbuf for the composition carryover bytes.
7113
71142011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 7115
ae940cca
EZ
7116 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
7117 aborting when %lld or %lll format is passed.
7118 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
7119 %llo or %llx format is passed. (Bug#8545)
7120
03ab8921
EZ
7121 * window.c (window_scroll_line_based): Use a marker instead of
7122 simple variables to record original value of point. (Bug#7952)
7123
afda1437
EZ
7124 * doprnt.c (doprnt): Fix the case where a multibyte sequence
7125 produced by %s or %c overflows available buffer space. (Bug#8545)
7126
f76dee0c
PE
71272011-04-28 Paul Eggert <eggert@cs.ucla.edu>
7128
7129 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 7130 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 7131
fdc5744d
JB
71322011-04-28 Juanma Barranquero <lekktu@gmail.com>
7133
7134 * w32.c (init_environment): Warn about defaulting HOME to C:\.
7135
638f053a
JB
71362011-04-28 Juanma Barranquero <lekktu@gmail.com>
7137
7138 * keyboard.c (Qdelayed_warnings_hook): Define.
7139 (command_loop_1): Run `delayed-warnings-hook'
7140 if Vdelayed_warnings_list is non-nil.
7141 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
7142 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
7143
d178f871
EZ
71442011-04-28 Eli Zaretskii <eliz@gnu.org>
7145
7146 * doprnt.c (doprnt): Don't return value smaller than the buffer
7147 size if the message was truncated. (Bug#8545).
7148
b124fd93
JB
71492011-04-28 Juanma Barranquero <lekktu@gmail.com>
7150
7151 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7152 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7153
e810457d
PE
71542011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7155
7156 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7157
ea51cceb
JB
71582011-04-27 Juanma Barranquero <lekktu@gmail.com>
7159
7160 * makefile.w32-in: Update dependencies.
7161
94dcfacf
EZ
71622011-04-27 Eli Zaretskii <eliz@gnu.org>
7163
7164 Improve `doprnt' and its usage. (Bug#8545)
7165 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7166 `format_end'. Remove support for %l as a conversion specifier.
7167 Don't use xrealloc. Improve diagnostics when the %l size modifier
7168 is used. Update the commentary.
7169
7170 * eval.c (verror): Simplify calculation of size_t.
7171
7172 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7173 messages.
7174
f61f41d7
PE
71752011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7176
7177 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7178 change.
7179
96fb4434
PE
71802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7181
7182 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7183 This makes this file independent of the recent pseudovector change.
7184
671875da 71852011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7186
69e9b5a3
PE
7187 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7188
b5f869a7 7189 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7190 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7191 Remove unused local.
c8926152 7192 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7193
841a1577 7194 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7195 GCC 4.6.0 optimizes based on type-based alias analysis.
7196 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7197 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7198 != &v->size, and therefore "v->size = 1; b->size = 2; return
7199 v->size;" must therefore return 1. This assumption is incorrect
7200 for Emacs, since it type-puns struct Lisp_Vector * with many other
7201 types. To fix this problem, this patch adds a new type struct
f904488f 7202 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7203 and pseudovectors, and helps optimizing compilers not get fooled
7204 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7205 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7206 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7207 the size member.
eab3844f
PE
7208 (XSETPVECTYPE): Rewrite in terms of new macro.
7209 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7210 This is a bit clearer, and further avoids the possibility of
7211 undesirable aliasing.
7212 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7213 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7214 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7215 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7216 (ASIZE): Now uses header.size rather than size.
7217 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7218 to avoid the hassle of writing XVECTOR (foo)->header.size.
7219 (struct vectorlike_header): New type.
eab3844f
PE
7220 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7221 object, to help avoid aliasing.
7222 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7223 (SUBRP): Likewise, since Lisp_Subr is a special case.
7224 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7225 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7226 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7227 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7228 changed to be "header.size" and "header.next".
7229 * buffer.h (struct buffer): Likewise.
7230 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7231 * frame.h (struct frame): Likewise.
7232 * process.h (struct Lisp_Process): Likewise.
7233 * termhooks.h (struct terminal): Likewise.
7234 * window.c (struct save_window_data, struct saved_window): Likewise.
7235 * window.h (struct window): Likewise.
7236 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7237 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7238 * buffer.c (init_buffer_once): Likewise.
7239 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7240 special case.
7241 * process.c (Fformat_network_address): Use local var for size,
7242 for brevity.
7243
0df1eac5
PE
7244 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7245
847ab9d1 7246 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7247 * data.c (atof): Remove decl; no longer used or needed.
7248 (digit_to_number): Move to lread.c.
7249 (Fstring_to_number): Use new string_to_number function, to be
7250 consistent with how the Lisp reader treats infinities and NaNs.
7251 Do not assume that floating-point numbers represent EMACS_INT
7252 without losing information; this is not true on most 64-bit hosts.
7253 Avoid double-rounding errors, by insisting on integers when
7254 parsing non-base-10 numbers, as the documentation specifies.
7255 * lisp.h (string_to_number): New decl, replacing ...
7256 (isfloat_string): Remove.
bc0a5c13 7257 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7258 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7259 appears to have been a coding error. Similarly, do not accept
7260 strings like +-1e0 as floating point numbers. Do not report
7261 overflow for integer overflows unless the base is not 10 which
7262 means we have no simple and reliable way to continue.
7263 Break out the floating-point parsing into a new
7264 function string_to_number, so that Fstring_to_number parses
7265 floating point numbers consistently with the Lisp reader.
04f2d78b 7266 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7267 (E_CHAR, EXP_INT): Remove, replacing with ...
7268 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7269 (string_to_number): New function, replacing isfloat_string.
7270 This function checks for valid syntax and produces the resulting
7271 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7272 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7273 so that overflow for non-base-10 numbers is reported only when
7274 there's no portable and simple way to convert to floating point.
452f4150 7275
67769ffc
PE
7276 * textprop.c (set_text_properties_1): Rewrite for clarity,
7277 and to avoid GCC warning about integer overflow.
7278
c20db43f
PE
7279 * intervals.h (struct interval): Use EMACS_INT for members
7280 where EMACS_UINT might cause problems. See
7281 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7282 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7283 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7284 All uses changed.
37aa2f85
PE
7285 (offset_intervals): Tell GCC not to worry about length overflow
7286 when negating a negative length.
c20db43f 7287
2538aa2f
PE
7288 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7289 (overrun_check_free): Likewise.
7290
f2d3008d
PE
7291 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7292 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7293 word size.
7294
ec8df744
PE
7295 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7296 (gnutls_make_error): Rename local to avoid shadowing.
7297 (gnutls_emacs_global_deinit): ifdef out; not used.
7298 (Fgnutls_boot): Use const for pointer to readonly storage.
7299 Comment out unused local. Fix pointer signedness problems.
7300
640ee02d
PE
7301 * lread.c (openp): Don't stuff size_t into an 'int'.
7302 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7303 about possible signed overflow.
7304
6048fb2a
PE
7305 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7306 (GDK_KEY_g): Don't define if already defined.
7307 (xg_prepare_tooltip): Avoid pointer signedness problem.
7308 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7309
fa3c87e1
PE
7310 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7311 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7312
2172544b
PE
7313 * xfns.c (Fx_window_property): Simplify a bit,
7314 to make a bit faster and to avoid GCC 4.6.0 warning.
7315 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7316
9b821a21
PE
7317 * fns.c (internal_equal): Don't assume size_t fits in int.
7318
3c616cfa
PE
7319 * alloc.c (compact_small_strings): Tighten assertion a little.
7320
c2982e87
PE
7321 Replace pEd with more-general pI, and fix some printf arg casts.
7322 * lisp.h (pI): New macro, generalizing old pEd macro to other
7323 conversion specifiers. For example, use "...%"pI"d..." rather
7324 than "...%"pEd"...".
7325 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7326 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7327 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7328 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7329 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7330 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7331 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7332 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7333 64-bit hosts.
7334 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7335 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7336 * print.c (safe_debug_print, print_object): Likewise.
7337 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7338 to int.
6f04d126
PE
7339 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7340 avoiding the 0 flag, which is not portable.
c2982e87
PE
7341 * process.c (Fmake_network_process): Use pI to avoid cast.
7342 * region-cache.c (pp_cache): Likewise.
7343 * xdisp.c (decode_mode_spec): Likewise.
7344 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7345 behavior on 64-bit hosts with printf arg.
6f04d126 7346 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7347 (x_stop_queuing_selection_requests): Likewise.
7348 (x_get_window_property): Don't truncate byte count to an 'int'
7349 when tracing.
0b432f21 7350
5e073ec7
PE
7351 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7352 here, since it parses constructs like leading '-' and spaces,
7353 which are not wanted; and it overflows with large numbers.
7354 Instead, simply match F[0-9]+, which is what is wanted anyway.
7355
36372bf9
PE
7356 * alloc.c: Remove unportable assumptions about struct layout.
7357 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7358 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7359 (allocate_vectorlike, make_pure_vector): Use the new macros,
7360 plus offsetof, to remove unportable assumptions about struct layout.
7361 These assumptions hold on all porting targets that I know of, but
7362 they are not guaranteed, they're easy to remove, and removing them
7363 makes further changes easier.
7364
0b432f21
PE
7365 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7366 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7367 (string_overrun_cookie): Now const. Use initializers that
7368 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7369 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7370 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7371 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7372 multiple of sizeof (EMACS_INT); it need not be, if
7373 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7374 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7375
895009e1
JB
73762011-04-26 Juanma Barranquero <lekktu@gmail.com>
7377
7378 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7379
6a7a1b0b
TZ
73802011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7381
7382 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7383 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7384 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7385
841a1577 73862011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7387
7388 * lisp.h (Qdebug): List symbol.
895009e1 7389 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7390 * keyboard.c (debug-on-event): New variable.
7391 (handle_user_signal): Break into debugger when debug-on-event
7392 matches the current signal symbol.
7393
f2d3ba6f
DN
73942011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7395
7396 * alloc.c (check_sblock, check_string_bytes)
7397 (check_string_free_list): Convert to standard C.
7398
42ce4c63
TZ
73992011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7400
7401 * w32.c (emacs_gnutls_push): Fix typo.
7402
825cd63c
EZ
74032011-04-25 Eli Zaretskii <eliz@gnu.org>
7404
fb11d64d
EZ
7405 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7406 "cast to pointer from integer of different size".
7407
825cd63c
EZ
7408 Improve doprnt and its use in verror. (Bug#8545)
7409 * doprnt.c (doprnt): Document the set of format control sequences
7410 supported by the function. Use SAFE_ALLOCA instead of always
7411 using `alloca'.
7412
7413 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7414 is one byte too soon. Don't use xrealloc; instead xfree and
7415 xmalloc anew.
7416
e061a11b
TZ
74172011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7418
7419 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7420 callbacks stage.
7421
7422 * gnutls.c: Renamed global_initialized to
7423 gnutls_global_initialized. Added internals for the
7424 :verify-hostname-error, :verify-error, and :verify-flags
7425 parameters of `gnutls-boot' and documented those parameters in the
7426 docstring. Start callback support.
9173deec
JB
7427 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7428 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7429 on error. Return error code.
e061a11b
TZ
7430 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7431 (emacs_gnutls_read): Likewise.
7432 (Fgnutls_boot): Return handshake error code.
7433 (emacs_gnutls_handle_error): New function.
7434 (wsaerror_to_errno): Likewise.
7435
7436 * w32.h (emacs_gnutls_pull): Add prototype.
7437 (emacs_gnutls_push): Likewise.
7438
7439 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7440 (emacs_gnutls_push): Likewise.
7441
74422011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7443
7444 * process.c (wait_reading_process_output): Check if GnuTLS
7445 buffered some data internally if no FDs are set for TLS
7446 connections.
7447
7448 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7449 (LIBS): Link to USER_LIBS.
7450 ($(BLD)/gnutls.$(0)): New target.
7451
fa6996bc
EZ
74522011-04-24 Eli Zaretskii <eliz@gnu.org>
7453
eb35682e
EZ
7454 * xdisp.c (handle_single_display_spec): Rename the
7455 display_replaced_before_p argument into display_replaced_p, to
7456 make it consistent with the commentary. Fix typos in the
7457 commentary.
7458
e2ad650c
EZ
7459 * textprop.c (syms_of_textprop): Remove dead code.
7460 (copy_text_properties): Delete obsolete commentary about an
7461 interface that was deleted long ago. Fix typos in the description
7462 of arguments.
7463
1b2de274
EZ
7464 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7465 to changes in oldXMenu/XMenu.h from 2011-04-16.
7466 <menu_help_message, prev_menu_help_message>: Constify.
7467 (IT_menu_make_room): menu->help_text is now `const char **';
7468 adjust.
7469
7470 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7471 to changes in oldXMenu/XMenu.h from 2011-04-16.
7472 (struct XMenu): Declare `help_text' `const char **'.
7473
7474 * xfaces.c <Qunspecified>: Make extern again.
7475
7476 * syntax.c: Include sys/types.h before including regex.h, as
7477 required by Posix.
7478
762b15be
EZ
7479 * doc.c (get_doc_string): Improve the format passed to `error'.
7480
7481 * doprnt.c (doprnt): Improve commentary.
7482
7483 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7484
7485 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7486 them with etags.
7487
f1052e5d
EZ
7488 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7489 changes in globals.h immediately force recompilation.
762b15be
EZ
7490 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7491 $(CURDIR)/s/ms-w32.h.
7492 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7493
fa6996bc
EZ
7494 * character.c (Fchar_direction): Function deleted.
7495 (syms_of_character): Don't defsubr it.
7496 <char-direction-table>: Deleted.
7497
e6c3da20
EZ
74982011-04-23 Eli Zaretskii <eliz@gnu.org>
7499
7500 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7501 * doprnt.c: Include limits.h.
7502 (SIZE_MAX): New macro.
04f2d78b
CB
7503 (doprnt): Return a size_t value. 2nd arg is now size_t.
7504 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7505 Improve overflow protection. Support `l' modifier for integer
7506 conversions. Support %l conversion. Don't assume an EMACS_INT
7507 argument for integer conversions and for %c.
7508
7509 * lisp.h (doprnt): Restore prototype.
7510
7511 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7512 $(SRC)/character.h.
7513
7514 * Makefile.in (base_obj): Add back doprnt.o.
7515
7516 * deps.mk (doprnt.o): Add back prerequisites.
7517 (callint.o): Depend on character.h.
7518
7519 * eval.c (internal_lisp_condition_case): Include the handler
7520 representation in the error message.
7521 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7522 when breaking from the loop.
7523
7524 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7525
7526 * callint.c (Fcall_interactively): When displaying error message
7527 about invalid control letter, pass the character's codepoint, not
7528 a pointer to its multibyte form. Improve display of the character
7529 in octal and display also its hex code.
7530
7531 * character.c (char_string): Use %x to display the (unsigned)
7532 codepoint of an invalid character, to avoid displaying a bogus
7533 negative value.
7534
7535 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7536 `error', not SYMBOL_NAME itself.
7537
7538 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7539 character arguments to `error'.
7540
7541 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7542 to `error' in error message about FINAL_CHAR argument. Make sure
7543 FINAL_CHAR is a character, and use %c when it is passed as
7544 argument to `error'.
7545
4ffd0d6b 75462011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7547
7548 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7549
7550 * w32.c: Include <time.h>.
7551 (sys_localtime): New function.
7552
4ffd0d6b 75532011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7554
7555 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7556
4ffd0d6b 7557 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7558
4ffd0d6b 75592011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7560
4ffd0d6b
GM
7561 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7562 zombies (Bug#8467).
aac0c6e3 7563
04c56954
EZ
75642011-04-19 Eli Zaretskii <eliz@gnu.org>
7565
7566 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7567 gl_state.e_property when gl_state.object is Qt.
7568
7569 * insdel.c (make_gap_larger): Remove limitation of buffer size
7570 to <= INT_MAX.
7571
16a43933
CY
75722011-04-18 Chong Yidong <cyd@stupidchicken.com>
7573
7574 * xdisp.c (lookup_glyphless_char_display)
7575 (produce_glyphless_glyph): Handle cons cell entry in
7576 glyphless-char-display.
7577 (Vglyphless_char_display): Document it.
7578
7579 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7580 glyphless-char-display.
7581
4581706e
CY
75822011-04-17 Chong Yidong <cyd@stupidchicken.com>
7583
7584 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7585
7586 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7587
7588 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7589 definition for no-X builds.
7590
4887c6e2 75912011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7592
fd35b6f9
PE
7593 Static checks with GCC 4.6.0 and non-default toolkits.
7594
5c1ccb01
PE
7595 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7596
006c5daa
PE
7597 * process.c (keyboard_bit_set): Define only if SIGIO.
7598 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7599 (send_process): Repair possible setjmp clobbering.
7600
efc736d3
PE
7601 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7602
4e2fe2e6
PE
7603 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7604
f97334a2
PE
7605 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7606
4e75f29d
PE
7607 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7608 Define only if needed.
7609
90efadd1
PE
7610 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7611 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7612 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7613
3c647824
PE
7614 * dispextern.h (struct redisplay_interface): Rename param
7615 to avoid shadowing.
e264f262 7616 * termhooks.h (struct terminal): Likewise.
761383f4 7617 * xterm.c (xembed_send_message): Likewise.
3c647824 7618
b58c5c4a
PE
7619 * insdel.c (make_gap_smaller): Define only if
7620 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7621
cad59032
PE
7622 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7623 it.
7624
c339dc2e
PE
7625 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7626 so that we aren't warned about unused symbols.
7627
91a3e27b
PE
7628 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7629
399c71d3 7630 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7631
8ffc96f5
PE
7632 * xfns.c (x_real_positions): Mark locals as initialized.
7633
eef9bc79
PE
7634 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7635
098db9dd
PE
7636 * xterm.c: Fix problems found by static analysis with other toolkits.
7637 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7638 (x_dispatch_event): Declare static if USE_GTK, and
7639 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7640 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7641 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7642 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7643 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7644
eb18f6cc
PE
7645 * xmenu.c (menu_help_callback): Pointer type fixes.
7646 Use const pointers when pointing at readonly data. Avoid pointer
7647 signedness clashes.
7648 (FALSE): Remove unused macro.
7649 (update_frame_menubar): Remove unused decl.
7650
1fe72bf8
PE
7651 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7652
60d9e1db
PE
7653 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7654 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7655 (single_menu_item): Rename local to avoid shadowing.
7656
39261c26
PE
7657 * keyboard.c (make_lispy_event): Remove unused local var.
7658
018c5e19
PE
7659 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7660 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7661
63d2b86e
PE
7662 * bitmaps: Change bitmaps from unsigned char back to the X11
7663 compatible char. Avoid the old compiler warnings about
7664 out-of-range initializers by using, for example, '\xab' rather
7665 than 0xab.
7666
aefd87e1
PE
7667 * xgselect.c (xgselect_initialize): Check vs interface
7668 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7669
bf501fb9
PE
7670 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7671
e9829fdf
PE
7672 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7673 to read-only memory.
7674
1086c095
PE
7675 * fns.c (vector): Remove; this old hack is no longer needed.
7676
2baccd04 7677 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7678 Remove unused var.
dde42981 7679 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7680
72391843 7681 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7682
436c16df 7683 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7684 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7685 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7686
92bb796d 7687 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7688 (x_term_init): Remove local to avoid shadowing.
92bb796d 7689
764430a3 7690 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7691
7692 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7693 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7694
d1dfb56c
EZ
76952011-04-16 Eli Zaretskii <eliz@gnu.org>
7696
c4354cb4
EZ
7697 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7698
d1dfb56c
EZ
7699 Fix regex.c, syntax.c and friends for buffers > 2GB.
7700 * syntax.h (struct gl_state_s): Declare character position members
7701 EMACS_INT.
7702
7703 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7704
04f2d78b
CB
7705 * textprop.c (verify_interval_modification, interval_of):
7706 Declare arguments EMACS_INT.
d1dfb56c
EZ
7707
7708 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7709 EMACS_INT.
7710
7711 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7712
7713 * indent.c (Fvertical_motion): Local variable it_start is now
7714 EMACS_INT.
7715
7716 * regex.c (re_match, re_match_2, re_match_2_internal)
7717 (bcmp_translate, regcomp, regexec, print_double_string)
7718 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7719 (re_compile_pattern, re_exec): Declare arguments and local
7720 variables `size_t' and `ssize_t' and return values `regoff_t', as
7721 appropriate.
7722 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7723 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7724 <compile_stack_type>: `size' and `avail' are now `size_t'.
7725
7726 * regex.h <regoff_t>: Use ssize_t, not int.
7727 (re_search, re_search_2, re_match, re_match_2): Arguments that
7728 specify buffer/string position and length are now ssize_t and
7729 size_t. Return type is regoff_t.
7730
613052cd
BK
77312011-04-16 Ben Key <bkey76@gmail.com>
7732
7733 * nsfont.m: Fixed bugs in ns_get_family and
7734 ns_descriptor_to_entity that were caused by using free to
7735 deallocate memory blocks that were allocated by xmalloc (via
7736 xstrdup). This caused Emacs to crash when compiled with
7737 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7738 --enable-checking=xmallocoverrun). xfree is now used to
7739 deallocate these memory blocks.
7740
4170f62f 77412011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7742
71b41406
PE
7743 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7744
9587a89d
PE
7745 emacs_write: Accept and return EMACS_INT for sizes.
7746 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7747 et seq.
7748 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7749 Accept and return EMACS_INT.
7750 (emacs_gnutls_write): Return the number of bytes written on
7751 partial writes.
7752 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7753 (emacs_read, emacs_write): Remove check for negative size, as the
7754 Emacs source code has been audited now.
9587a89d
PE
7755 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7756 (emacs_read, emacs_write): Use it.
273a5f82
PE
7757 * process.c (send_process): Adjust to the new signatures of
7758 emacs_write and emacs_gnutls_write. Do not attempt to store
7759 a byte offset into an 'int'; it might overflow.
9587a89d 7760 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7761
3e047f51
PE
7762 * sound.c: Don't assume sizes fit in 'int'.
7763 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7764 Return EMACS_INT, not int.
3e047f51 7765 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7766 Accept EMACS_INT, not int.
7767 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7768 record read return values.
7769
cc39a9db
BK
77702011-04-15 Ben Key <bkey76@gmail.com>
7771
c9d0ec6d
JB
7772 * keyboard.c (Qundefined): Don't declare static since it is used
7773 in nsfns.m.
7774 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7775 static since they are used in nsfont.m.
cc39a9db 7776
6c60eb9f
SM
77772011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7778
7779 * process.c (Qprocessp): Don't declare static.
7780 * lisp.h (Qprocessp): Declare again.
7781
7990b61a
JB
77822011-04-15 Juanma Barranquero <lekktu@gmail.com>
7783
7784 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7785
5d4cb038
PE
77862011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7787
8bd7b830 7788 Improve C-level modularity by making more things 'static'.
cd64ea1d 7789
e3b27b31
PE
7790 Don't publish debugger-only interfaces to other modules.
7791 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7792 (verify_bytepos, count_markers): Move decls to the only modules
7793 that need them.
7794 * region-cache.h (pp_cache): Likewise.
7795 * window.h (check_all_windows): Likewise.
7796 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7797
5d4cb038
PE
7798 * sysdep.c (croak): Now static, if
7799 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7800 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7801
7802 * alloc.c (refill_memory_reserve): Now static if
7803 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7804 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7805
e87b6180
PE
7806 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7807 Define only if USE_LUCID.
7808
ac64929e
PE
7809 * xrdb.c (x_customization_string, x_rm_string): Now static.
7810
6f37259d
PE
7811 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7812 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7813
1683e3ab
PE
7814 * xdisp.c (draw_row_with_mouse_face): Now static.
7815 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7816
de9c2632
PE
7817 * window.h (check_all_windows): Mark externally visible.
7818
2b96acb7
PE
7819 * window.c (window_deletion_count): Now static.
7820
7821 * undo.c: Make symbols static if they're not exported.
7822 (last_undo_buffer, last_boundary_position, pending_boundary):
7823 Now static.
7824
50436f33
PE
7825 * textprop.c (interval_insert_behind_hooks): Now static.
7826 (interval_insert_in_front_hooks): Likewise.
7827
64520e5c
PE
7828 * term.c: Make symbols static if they're not exported.
7829 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7830 (max_frame_lines, tty_set_terminal_modes):
7831 (tty_reset_terminal_modes, tty_turn_off_highlight):
7832 (get_tty_terminal): Now static.
7833 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7834 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7835 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7836 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7837 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7838
1fa53021
PE
7839 * sysdep.c: Make symbols static if they're not exported.
7840 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7841 Now static.
7842 (sigprocmask_set, full_mask): Remove; unused.
7843 (wait_debugging): Mark as visible.
7844 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7845 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7846
d4b43b22
PE
7847 * syntax.c (syntax_temp): Define only if !__GNUC__.
7848
b7c513d0
PE
7849 * sound.c (current_sound_device, current_sound): Now static.
7850
989b29ad
PE
7851 * search.c (searchbufs, searchbuf_head): Now static.
7852
13a55a78
PE
7853 * scroll.c (scroll_cost): Remove; unused.
7854 * dispextern.h (scroll_cost): Remove decl.
7855
de68a1fc
PE
7856 * region-cache.h (pp_cache): Mark as externally visible.
7857
40ccffa6
PE
7858 * process.c: Make symbols static if they're not exported.
7859 (process_tick, update_tick, create_process, chan_process):
7860 (Vprocess_alist, proc_buffered_char, datagram_access):
7861 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7862 (deactivate_process): Mark defn as static, as well as decl.
7863 * lisp.h (create_process): Remove decl.
7864 * process.h (chan_process, Vprocess_alist): Remove decls.
7865
ad64fc97
PE
7866 * print.c: Make symbols static if they're not exported.
7867 (print_depth, new_backquote_output, being_printed, print_buffer):
7868 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7869 (print_interval, print_number_index, initial_stderr_stream):
7870 Now static.
7871 * lisp.h (Fprinc): Remove decl.
7872 (debug_output_compilation_hack): Mark as externally visible.
7873
adddb265
PE
7874 * sysdep.c (croak): Move decl from here to syssignal.h.
7875 * syssignal.h (croak): Put it here, so the API can be checked when
7876 'croak' is called from dissociate_if_controlling_tty.
7877
1717ede2
PE
7878 * minibuf.c: Make symbols static if they're not exported.
7879 (minibuf_save_list, choose_minibuf_frame): Now static.
7880 * lisp.h (choose_minibuf_frame): Remove decl.
7881
fa5fb2bc
PE
7882 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7883
1e3890d1
PE
7884 * lread.c: Make symbols static if they're not exported.
7885 (read_objects, initial_obarray, oblookup_last_bucket_number):
7886 Now static.
7887 (make_symbol): Remove; unused.
7888 * lisp.h (initial_obarray, make_symbol): Remove decls.
7889
8a1414fa
PE
7890 * keyboard.c: Make symbols static if they're not exported.
7891 (single_kboard, recent_keys_index, total_keys, recent_keys):
7892 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7893 (this_single_command_key_start, echoing, last_auto_save):
7894 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7895 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7896 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7897 (Vlispy_mouse_stem, double_click_count):
7898 Now static.
7899 (force_auto_save_soon): Define only if SIGDANGER.
7900 (ignore_mouse_drag_p): Now static if
7901 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7902 (print_help): Remove; unused.
7903 (stop_character, last_timer_event): Mark as externally visible.
7904 * keyboard.h (ignore_mouse_drag_p): Declare only if
7905 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7906 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7907 * lisp.h (echoing): Remove decl.
7908 (force_auto_save_soon): Declare only if SIGDANGER.
7909 * xdisp.c (redisplay_window): Simplify code, to make it more
7910 obvious that ignore_mouse_drag_p is not accessed if !defined
7911 USE_GTK && !defined HAVE_NS.
7912
93ea6e8f
PE
7913 * intervals.c: Make symbols static if they're not exported.
7914 (merge_properties_sticky, merge_interval_right, delete_interval):
7915 Now static.
7916 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7917
77382fcc
PE
7918 * insdel.c: Make symbols static if they're not exported.
7919 However, leave prepare_to_modify_buffer alone. It's never
7920 called from outside this function, but that appears to be a bug.
7921 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7922 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7923 (adjust_after_replace_noundo): Remove; unused.
7924 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7925 (signal_before_change): Remove decls.
77382fcc 7926
9306c32e
PE
7927 * indent.c (val_compute_motion, val_vmotion): Now static.
7928
cd44d2eb
PE
7929 * image.c: Make symbols static if they're not exported.
7930 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7931 if USE_GTK.
7932 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7933 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7934
ad9a7a06
PE
7935 * fringe.c (standard_bitmaps): Now static.
7936 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7937
81626931
PE
7938 * frame.c: Make symbols static if they're not exported.
7939 (x_report_frame_params, make_terminal_frame): Now static.
7940 (get_frame_param): Now static, unless HAVE_NS.
7941 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7942 (x_get_resource_string): Remove; not used.
7943 * frame.h (make_terminal_frame, x_report_frame_params):
7944 (x_get_resource_string); Remove decls.
7945 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7946 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7947
239f9db9
PE
7948 * font.c, fontset.c: Make symbols static if they're not exported.
7949 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7950 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7951 * font.c (font_close_object): Now static.
7952 * font.h (font_close_object): Remove.
7953 * fontset.c (FONTSET_OBJLIST): Remove.
7954 (free_realized_fontset) #if-0 the body, which does nothing.
7955 (face_suitable_for_char_p): #if-0, as it's never called.
7956 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7957 * xfaces.c (face_at_string_position):
7958 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7959 since 0 is always ASCII.
7960
dfcf3579
PE
7961 * fns.c (weak_hash_tables): Now static.
7962
5045092b
PE
7963 * fileio.c: Make symbols static if they're not exported.
7964 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7965 (Vwrite_region_annotation_buffers): Now static.
7966
57a96f5c
PE
7967 * eval.c: Make symbols static if they're not exported.
7968 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7969 * lisp.h (backtrace_list): Remove decl.
7970
35f08c38
PE
7971 * emacs.c: Make symbols static if they're not exported.
7972 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7973 (fatal_error_code, fatal_error_signal_hook, standard_args):
7974 Now static.
7975 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7976 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7977 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7978 * lisp.h (fatal_error_signal_hook): Remove decl.
7979 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7980
f44bd759
PE
7981 * editfns.c: Move a (normally-unused) function to its only use.
7982 * editfns.c, lisp.h (get_operating_system_release): Remove.
7983 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7984 worth the hassle of breaking this out.
7985
b532497d
PE
7986 * xterm.c: Make symbols static if they're not exported.
7987 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7988 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7989 (x_destroy_window, x_delete_display):
7990 Now static.
7991 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7992 (x_mouse_leave): Remove; unused.
7993 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7994 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7995 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7996 Remove decls.
7997 (x_mouse_leave): Declare only if WINDOWSNT.
7998 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7999 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
8000 USE_X_TOOLKIT.
8001
1675728f
PE
8002 * ftxfont.c: Make symbols static if they're not exported.
8003 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
8004 HAVE_FREETYPE.
8005 * font.h (ftxfont_driver): Likewise.
8006
e4cebfca
PE
8007 * xfns.c: Make symbols static if they're not exported.
8008 (x_last_font_name, x_display_info_for_name):
8009 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
8010 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
8011 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
8012 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
8013 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
8014 (last_show_tip_args): Now static.
8015 (xic_defaut_fontset, xic_create_fontsetname): Define only if
8016 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
8017 (x_screen_planes): Remove; unused.
8018 * dispextern.h (x_screen_planes): Remove decl.
8019
5bf46f05
PE
8020 * dispnew.c: Make symbols static if they're not exported.
8021 * dispextern.h (redraw_garbaged_frames, scrolling):
8022 (increment_row_positions): Remove.
8023 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
8024 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
8025 Now static.
8026 (redraw_garbaged_frames): Remove; unused.
8027
435f4c28
PE
8028 * xfaces.c: Make symbols static if they're not exported.
8029 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
8030 Remove decls.
8031 * xterm.h (defined_color): Remove decls.
8032 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
8033 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
8034 (menu_face_changed_default, defined_color, free_realized_face):
8035 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
8036 (ascii_face_of_lisp_face): Remove; unused.
8037
8524aef3
PE
8038 * xdisp.c: Make symbols static if they're not exported.
8039 * dispextern.h (scratch_glyph_row, window_box_edges):
8040 (glyph_to_pixel_coords, set_cursor_from_row):
8041 (get_next_display_element, set_iterator_to_next):
8042 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
8043 (show_mouse_face): Remove decls
8044 * frame.h (message_buf_print): Likewise.
8045 * lisp.h (pop_message, set_message, check_point_in_composition):
8046 Likewise.
8047 * xterm.h (set_vertical_scroll_bar): Likewise.
8048 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
8049 (message_buf_print, scratch_glyph_row, displayed_buffer):
8050 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
8051 (get_next_display_element, show_mouse_face, window_box_edges):
8052 (frame_to_window_pixel_xy, check_point_in_composition):
8053 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
8054 (glyph_to_pixel_coords): Remove; unused.
8055
16390cd2
PE
8056 * dired.c (file_name_completion): Now static.
8057
8058 * dbusbind.c (xd_in_read_queued_messages): Now static.
8059
a25f4dfa
PE
8060 * lisp.h (circular_list_error, FOREACH): Remove; unused.
8061 * data.c (circular_list_error): Remove.
8062
14a9c8df
PE
8063 * commands.h (last_point_position, last_point_position_buffer):
8064 (last_point_position_window): Remove decls.
8065 * keyboard.c: Make these variables static.
8066
04f2d78b
CB
8067 * coding.h (coding, code_convert_region, encode_coding_gap):
8068 Remove decls.
74ab6df5
PE
8069 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
8070 (iso_code_class, detect_coding, code_convert_region): Now static.
8071 (encode_coding_gap): Remove; unused.
8072
38dfbee1
PE
8073 * chartab.c (chartab_chars, chartab_bits): Now static.
8074
a2cb4e63
PE
8075 * charset.h (charset_iso_8859_1): Remove decl.
8076 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
8077 Now static.
8078
127198fd
PE
8079 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
8080 * ccl.c (Vccl_program_table): Now static.
8081 (check_ccl_update): Remove; unused.
8082
d85b608f
PE
8083 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
8084 * category.h: ... from here.
8085 * category.c (check_category_table, set_category_set): Now static.
8086
31cd66f3
PE
8087 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
8088 * lisp.h: Remove these decls.
8089
c358e587
PE
8090 * buffer.c (buffer_count): Remove unused var.
8091
e78aecca
PE
8092 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
8093 so that it's not optimized away.
8094 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
8095 * dispextern.h (bidi_dump_cached_states): Remove, since it's
8096 exported only to the debugger.
8097
e192d7d3 8098 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 8099 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 8100
92470028
PE
8101 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
8102 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
8103 was inaccessible from Lisp.
8104 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
8105 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
8106
244ed907
PE
8107 alloc.c: Import and export fewer symbols, and remove unused items.
8108 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
8109 is defined.
8110 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
8111 it's not optimized away by whole-program optimization.
8112 (message_enable_multibyte, free_misc): Remove.
8113 (catchlist, handlerlist, mark_backtrace):
8114 Declare only if BYTE_MARK_STACK.
8115 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
8116 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
8117 (message_enable_multibyte): Remove decl.
8118 (free_misc, interval_free_list, float_block, float_block_index):
8119 (n_float_blocks, float_free_list, cons_block, cons_block_index):
8120 (cons_free_list, last_marked_index):
8121 Now static.
8122 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
8123 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
8124 (mark_backtrace): Define only if BYTE_MARK_STACK.
8125 * xdisp.c (message_enable_multibyte): Now static.
8126
61c2b50e 8127 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
8128 This makes it easier for human readers (and static analyzers)
8129 to see whether these variables are used from other modules.
8130 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
8131 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
8132 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
8133 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
8134 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
8135 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
8136 * xmenu.c, xselect.c:
8137 Declare Q* vars static if they are not used in other modules.
8138 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
8139 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
8140 Remove decls of unexported vars.
8141 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
8142
95c82688
PE
8143 * lisp.h (DEFINE_FUNC): Make sname 'static'.
8144
16a97296
PE
8145 Make Emacs functions such as Fatom 'static' by default.
8146 This makes it easier for human readers (and static analyzers)
8147 to see whether these functions can be called from other modules.
8148 DEFUN now defines a static function. To make the function external
8149 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8150 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8151 (Finit_image_library):
16a97296
PE
8152 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8153 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8154 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8155 Remove decls, since these functions are now static.
8156 (Funintern, Fget_internal_run_time): New decls, since these functions
8157 were already external.
95c82688 8158
16a97296
PE
8159 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8160 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8161 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8162 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8163 * keyboard.c, keymap.c, lread.c:
8164 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8165 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8166 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8167 Mark functions with DEFUE instead of DEFUN,
8168 if they are used in other modules.
8169 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8170 decls for now-static functions.
8171 * buffer.h (Fdelete_overlay): Remove decl.
8172 * callproc.c (Fgetenv_internal): Mark as internal.
8173 * composite.c (Fremove_list_of_text_properties): Remove decl.
8174 (Fcomposition_get_gstring): New forward static decl.
8175 * composite.h (Fcomposite_get_gstring): Remove decl.
8176 * dired.c (Ffile_attributes): New forward static decl.
8177 * doc.c (Fdocumntation_property): New forward static decl.
8178 * eval.c (Ffetch_bytecode): New forward static decl.
8179 (Funintern): Remove extern decl; now in .h file where it belongs.
8180 * fileio.c (Fmake_symbolic_link): New forward static decl.
8181 * image.c (Finit_image_library): New forward static decl.
8182 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8183 * intervals.h (Fprevious_property_change):
8184 (Fremove_list_of_text_properties): Remove decls.
8185 * keyboard.c (Fthis_command_keys): Remove decl.
8186 (Fcommand_execute): New forward static decl.
8187 * keymap.c (Flookup_key): New forward static decl.
8188 (Fcopy_keymap): Now static.
8189 * keymap.h (Flookup_key): Remove decl.
8190 * process.c (Fget_process): New forward static decl.
8191 (Fprocess_datagram_address): Mark as internal.
8192 * syntax.c (Fsyntax_table_p): New forward static decl.
8193 (skip_chars): Remove duplicate decl.
8194 * textprop.c (Fprevious_property_change): New forward static decl.
8195 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8196 Now internal.
8197 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8198 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8199
785bbd42
PE
8200 * editfns.c (Fformat): Remove unreachable code.
8201
8b913b57
AS
82022011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8203
8204 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8205 change. (Bug#8496)
8206
a6744a35
EZ
82072011-04-13 Eli Zaretskii <eliz@gnu.org>
8208
8209 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8210 when at ZV. (Bug#8487)
8211
e7974947
AS
82122011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8213
baad03f0
AS
8214 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8215 (Bug#8437)
8216 * keyboard.c (parse_tool_bar_item): Likewise.
8217 * sound.c (sound_cleanup, alsa_close): Likewise.
8218 * termcap.c (tgetent): Likewise.
8219 * xfns.c (x_default_font_parameter): Likewise.
8220 * xsettings.c (read_and_apply_settings): Likewise.
8221
e7974947
AS
8222 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8223 (overrun_check_free): Protoize.
8224
28272684
PE
82252011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8226
8227 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8228 since callers should never pass a negative size.
8229 Change the signature to match that of plain 'read' and 'write'; see
8230 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8231 * lisp.h: Update prototypes of emacs_write and emacs_read.
8232
11997c76
EZ
82332011-04-11 Eli Zaretskii <eliz@gnu.org>
8234
8235 * xdisp.c (redisplay_window): Don't try to determine the character
8236 position of the scroll margin if the window start point w->startp
e896f03c 8237 is outside the buffer's accessible region. (Bug#8468)
11997c76 8238
8a2cbd72
EZ
82392011-04-10 Eli Zaretskii <eliz@gnu.org>
8240
8241 Fix write-region and its subroutines for buffers > 2GB.
8242 * fileio.c (a_write, e_write): Modify declaration of arguments and
8243 local variables to support buffers larger than 2GB.
8244 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8245
8246 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8247 argument, local variables, and return value.
8248
8249 * lisp.h: Update prototypes of emacs_write and emacs_read.
8250
8251 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8252
4073e537 82532011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8254
1ebfdcb6
PE
8255 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8256
b2ded58d
PE
8257 Fix more problems found by GCC 4.6.0's static checks.
8258
7d66342c
PE
8259 * xdisp.c (vmessage): Use a better test for character truncation.
8260
bbf47d44
PE
8261 * charset.c (load_charset_map): <, not <=, for optimization,
8262 and to avoid potential problems with integer overflow.
9248994d 8263 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8264 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8265 * editfns.c (Fformat): Likewise.
1e69125e 8266 * syntax.c (skip_chars): Likewise.
3befa583 8267
e3019616
PE
8268 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8269 This also lets GCC 4.6.0 generate slightly better loop code.
8270
becfa255
PE
8271 * callint.c (Fcall_interactively): <, not <=, for optimization.
8272 (Fcall_interactively): Count the number of arguments produced,
8273 not the number of arguments given. This is simpler and lets GCC
8274 4.6.0 generate slightly better code.
8275
dae0cd48
PE
8276 * ftfont.c: Distingish more carefully between FcChar8 and char.
8277 The previous code passed unsigned char * to a functions like
8278 strlen and xstrcasecmp that expect char *, which does not
8279 conform to the C standard.
8280 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8281 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8282 char * when the C standard requires it.
8283
76032d70
PE
8284 * keyboard.c (read_char): Remove unused var.
8285
eb3f1cc8
PE
8286 * eval.c: Port to Windows vsnprintf (Bug#8435).
8287 Include <limits.h>.
8288 (SIZE_MAX): Define if the headers do not.
8289 (verror): Do not give up if vsnprintf returns a negative count.
8290 Instead, grow the buffer. This ports to Windows vsnprintf, which
8291 does not conform to C99. Problem reported by Eli Zaretskii.
8292 Also, simplify the allocation scheme, by avoiding the need for
8293 calling realloc, and removing the ALLOCATED variable.
8294
70476b54
PE
8295 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8296
12020a9e
PE
8297 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8298 But keep the doprint source code for now, as we might revamp it
8299 and use it again (Bug#8435).
ea6c7ae6
PE
8300 * lisp.h (doprnt): Remove.
8301 * Makefile.in (base_obj): Remove doprnt.o.
8302 * deps.mk (doprnt.o): Remove.
8303
5fdb398c
PE
8304 error: Print 32- and 64-bit integers portably (Bug#8435).
8305 Without this change, on typical 64-bit hosts error ("...%d...", N)
8306 was used to print both 32- and 64-bit integers N, which relied on
8307 undefined behavior.
61bdb816 8308 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8309 * lisp.h (error, verror): Mark as printf-like functions.
8310 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8311 Report overflow in size calculations when allocating printf buffer.
8312 Do not truncate output string at its first null byte.
8313 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8314 Truncate the output at a character boundary, since vsnprintf does not
8315 do that.
8316 * charset.c (check_iso_charset_parameter): Convert internal
8317 character to string before calling 'error', since %c now has the
8318 printf meaning.
8319 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8320 overflow when computing char to be passed to 'error'. Do not
8321 pass Lisp_Object to 'error'; pass the integer instead.
8322 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8323 formatted with plain %d.
8324
b189fa66
PE
8325 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8326
bff87ef0
PE
8327 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8328
7e2cac20
PE
8329 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8330
ce4d90b5
PE
8331 * xterm.c (x_catch_errors): Remove duplicate declaration.
8332
266c9547
PE
8333 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8334
79c49ad2
PE
8335 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8336
368f4090
JM
83372011-04-10 Jim Meyering <meyering@redhat.com>
8338
8339 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8340 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8341 return ssize_t not "int", and use size_t as the buffer length.
8342 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8343 * gnutls.h: Update declarations.
8344 * process.c (read_process_output): Use ssize_t, to match.
8345 (send_process): Likewise.
8346
a32d4040
CY
83472011-04-09 Chong Yidong <cyd@stupidchicken.com>
8348
8349 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8350
8546720e 83512011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8352
04f2d78b
CB
8353 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8354 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8355
8546720e
GM
8356 * xterm.c (handle_one_xevent):
8357 * xmenu.c (create_and_show_popup_menu):
8358 * xselect.c (x_decline_selection_request)
8359 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8360
0a2f5c1a 83612011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8362
8363 Fix some uses of `int' instead of EMACS_INT.
8364 * search.c (string_match_1, fast_string_match)
8365 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8366 (scan_buffer, find_next_newline_no_quit)
8367 (find_before_next_newline, search_command, Freplace_match)
8368 (Fmatch_data): Make some `int' variables be EMACS_INT.
8369
8370 * xdisp.c (display_count_lines): 3rd argument and return value now
8371 EMACS_INT. All callers changed.
8372 (pint2hrstr): Last argument is now EMACS_INT.
8373
8374 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8375 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8376 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8377 (decode_coding_utf_16, decode_coding_emacs_mule)
8378 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8379 (decode_coding_ccl, decode_coding_charset)
8380 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8381 (decode_coding_iso_2022, decode_coding_emacs_mule)
8382 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8383 <char_offset, last_offset>: Declare EMACS_INT.
8384 (encode_coding_utf_8, encode_coding_utf_16)
8385 (encode_coding_emacs_mule, encode_invocation_designation)
8386 (encode_designation_at_bol, encode_coding_iso_2022)
8387 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8388 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8389 Declare EMACS_INT.
8390 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8391 (encode_invocation_designation): Last argument P_NCHARS is now
8392 EMACS_INT.
8393 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8394 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8395
8396 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8397 All users changed.
8398
8399 * ccl.c (Fccl_execute_on_string): Declare some variables
8400 EMACS_INT.
8401
8546720e 84022011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8403
8404 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8405
4e19a977
CS
84062011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8407
8408 * process.c (Fformat_network_address): Doc fix.
8409
87302331
R
84102011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8411
ee7683eb 8412 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8413
cbb59342
CY
84142011-04-08 Chong Yidong <cyd@stupidchicken.com>
8415
8416 * keyboard.c (read_char): Call Lisp function help-form-show,
8417 instead of using internal_with_output_to_temp_buffer.
8418 (Qhelp_form_show): New var.
e0d38eeb 8419 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8420
8421 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8422
8423 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8424
e67a13ab
CY
84252011-04-06 Chong Yidong <cyd@stupidchicken.com>
8426
04f2d78b
CB
8427 * process.c (Flist_processes): Remove to Lisp.
8428 (list_processes_1): Delete.
e67a13ab 8429
973f782d
EZ
84302011-04-06 Eli Zaretskii <eliz@gnu.org>
8431
7c106b1e
EZ
8432 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8433
973f782d
EZ
8434 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8435
41cf7d1a 84362011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8437
ca23cc88
PE
8438 Fix more problems found by GCC 4.6.0's static checks.
8439
f390e2d5
PE
8440 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8441
42eea0d0
PE
8442 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8443
b69769da 8444 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8445
f9541e84
PE
8446 * xdisp.c (vmessage): Mark as a printf-like function.
8447
13841b55
PE
8448 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8449
c136c10f
PE
8450 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8451
5e2d4a30
PE
8452 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8453 printf-like functions.
8454 (tiff_load): Add casts to remove these marks before passing them
8455 to system-supplied API.
8456
583f48b9
PE
8457 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8458
b25d760e
PE
8459 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8460 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8461 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8462 directly, rather than having caller test rule sign. This avoids
8463 some unnecessary tests.
8464 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8465 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8466 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8467
bc7b6697 8468 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8469 (xfont_open): Avoid unnecessary tests.
bc7b6697 8470
27ccc379
PE
8471 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8472
dcd5c89a
PE
8473 * composite.h, composite.c (composition_gstring_put_cache):
8474 Use EMACS_INT, not int, for length.
8475
b13a45c6
PE
8476 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8477 breaking out part of COMPOSITION_DECODE_RULE.
8478 (COMPOSITION_DECODE_RULE): Use it.
8479 * composite.c (get_composition_id): Remove unused local vars,
8480 by using the new macro.
8481
1e792e4d
PE
8482 * textprop.c (set_text_properties_1): Change while to do-while,
8483 since the condition is always true at first.
8484
dc6c6455 8485 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8486 (interval_deletion_adjustment): Return unsigned value.
8487 All uses changed.
dc6c6455 8488
aba7731a
PE
8489 * process.c (list_processes_1, create_pty, read_process_output):
8490 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8491 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8492 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8493 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8494 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8495
fdfc4bf3
PE
8496 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8497
fca8fe46 8498 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8499 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8500
06a0259a 8501 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8502 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8503 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8504
e7b9e80f
PE
8505 * print.c (print_error_message): Avoid int overflow.
8506
56201685
PE
8507 * font.c (font_list_entities): Redo for clarity,
8508 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8509
78834453 8510 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8511 (font_score): Avoid potential overflow in diff calculation.
78834453 8512
0bc0b309 8513 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8514 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8515
e610eaca
PE
8516 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8517
b895abce
PE
8518 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8519 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8520 can always succeed if overflow has undefined behavior.
8521
1f1d9321 8522 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8523 (wordify): Omit three unnecessary tests.
1f1d9321 8524
c59478bc
PE
8525 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8526 All callers changed. This avoids the need for an unused var.
8527
79b73827
PE
8528 * casefiddle.c (casify_region): Remove var that is set but not used.
8529
a4db5dfe
PE
8530 * dired.c (file_name_completion): Remove var that is set but not used.
8531
43aae36e
PE
8532 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8533
2a47c44d 8534 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8535 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8536
a37c69bf
PE
8537 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8538 Check for integer overflow on size calculations.
8539
328ab8e7
PE
8540 * buffer.c (Fprevious_overlay_change): Remove var that is set
8541 but not used.
8542
e5a2a5cb
PE
8543 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8544 Remove vars that are set but not used.
8d84a6eb 8545 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8546 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8547
a60e5f68
PE
8548 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8549
f661cb61 8550 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8551 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8552
f0397f5a
PE
8553 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8554 that are set but not used.
8555
8664db06 8556 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8557 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8558
6abdaa4a
PE
8559 * xselect.c (x_get_local_selection, x_handle_property_notify):
8560 Remove vars that are set but not used.
8561
0ce7538d 8562 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8563 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8564
9ae848fc
PE
8565 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8566 Remove var that is set but not used.
0b918413
PE
8567 (scroll_bar_windows_size): Now size_t, not int.
8568 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8569 Check for overflow.
9ae848fc 8570
a5a62657
PE
8571 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8572 (map_tty_color) [!defined MSDOS]: Likewise.
8573
5c5cdd39
PE
8574 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8575
66ebf983
PE
8576 * coding.c: Remove vars that are set but not used.
8577 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8578 All callers changed.
8579 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8580 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8581 (decode_coding_charset): Remove vars that are set but not used.
8582
1be4d761
PE
8583 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8584 that is set but not used.
8585
47553fa8
PE
8586 * print.c (print_object): Remove var that is set but not used.
8587
1f7196bf 8588 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8589 The gnulib version avoids calling malloc in the usual case,
8590 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8591 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8592 * filelock.c (current_lock_owner): Likewise.
8593 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8594 * sysdep.c: Include allocator.h, careadlinkat.h.
8595 (emacs_no_realloc_allocator): New static constant.
8596 (emacs_readlink): New function.
fdb61804
PE
8597 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8598 ../lib/careadlinkat.h.
d1fdcab7 8599
f84c17c7
SM
86002011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8601
8602 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8603 first non-nil return value).
8604
ef3862ad
JD
86052011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8606
8607 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8608 if not defined (Bug#8403).
8609
376a7006
JB
86102011-04-02 Juanma Barranquero <lekktu@gmail.com>
8611
8612 * xdisp.c (display_count_lines): Remove parameter `start',
8613 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8614 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8615 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8616 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8617 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8618 and thereabouts. All callers changed.
8619 (get_per_char_metric): Remove parameter `f', unused since
8620 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8621
6ca3801d
JM
86222011-04-02 Jim Meyering <meyering@redhat.com>
8623
8624 do not dereference NULL upon failed strdup
8625 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8626 (ns_get_family): Likewise.
8627
d8e2b5ba
JB
86282011-04-02 Juanma Barranquero <lekktu@gmail.com>
8629
8630 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8631
8c74fcbd
JD
86322011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8633
8634 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8635 later (Bug#8403).
8636
7200d79c
SM
86372011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8638
03408648 8639 Add lexical binding.
7200d79c 8640
03408648
SM
8641 * window.c (Ftemp_output_buffer_show): New fun.
8642 (Fsave_window_excursion):
8643 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8644
8645 * lread.c (lisp_file_lexically_bound_p): New function.
8646 (Fload): Bind Qlexical_binding.
8647 (readevalloop): Remove `evalfun' arg.
8648 Bind Qinternal_interpreter_environment.
8649 (Feval_buffer): Bind Qlexical_binding.
8650 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8651 Mark as dynamic.
8652 (syms_of_lread): Declare `lexical-binding'.
8653
8654 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8655
8656 * keyboard.c (eval_dyn): New fun.
8657 (menu_item_eval_property): Use it.
ca105506
SM
8658
8659 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8660
03408648
SM
8661 * fns.c (concat, mapcar1): Accept byte-code-functions.
8662
8663 * eval.c (Fsetq): Handle lexical vars.
8664 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8665 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8666 (FletX, Flet): Obey lexical binding.
8667 (Fcommandp): Handle closures.
8668 (Feval): New `lexical' arg.
8669 (eval_sub): New function extracted from Feval. Use it almost
8670 everywhere where Feval was used. Look up vars in lexical env.
8671 Handle closures.
8672 (Ffunctionp): Move from subr.el.
8673 (Ffuncall): Handle closures.
8674 (apply_lambda): Remove `eval_flags'.
8675 (funcall_lambda): Handle closures and new byte-code-functions.
8676 (Fspecial_variable_p): New function.
8677 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8678 but without exporting it to Lisp.
23aba0ea 8679
23aba0ea 8680 * doc.c (Fdocumentation, store_function_docstring):
03408648 8681 * data.c (Finteractive_form): Handle closures.
23aba0ea 8682
03408648
SM
8683 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8684 interactive spec.
ba83908c 8685
04f2d78b
CB
8686 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8687 New byte-codes.
03408648
SM
8688 (exec_byte_code): New function extracted from Fbyte_code to handle new
8689 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8690
03408648 8691 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8692
03408648 8693 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8694
e2abce01
JB
86952011-03-31 Juanma Barranquero <lekktu@gmail.com>
8696
8697 * xdisp.c (redisplay_internal): Fix prototype.
8698
63696a73 86992011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8700
63696a73 8701 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8702 (try_scrolling): Use it when setting scroll_limit.
8703 Limit scrolling to 100 screen lines.
63696a73
EZ
8704 (redisplay_window): Even when falling back on "recentering",
8705 position point in the window according to scroll-conservatively,
8706 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8707
8708 (try_scrolling): When point is above the window, allow searching
8709 as far as scroll_max, or one screenful, to compute vertical
8710 distance from PT to the scroll margin position. This prevents
8711 try_scrolling from unnecessarily failing when
8712 scroll-conservatively is set to a value slightly larger than the
8713 window height. Clean up the case of PT below the margin at bottom
8714 of window: scroll_max can no longer be INT_MAX. When aggressive
8715 scrolling is in use, don't let point enter the opposite scroll
8716 margin as result of the scroll.
8717 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8718 threshold of 100 lines for never-recentering scrolling.
8719
e4cc2dfc
JB
87202011-03-31 Juanma Barranquero <lekktu@gmail.com>
8721
8722 * dispextern.h (move_it_by_lines):
8723 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8724 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8725 (message_log_check_duplicate): Remove parameters `prev_bol' and
8726 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8727 (redisplay_internal): Remove parameter `preserve_echo_area',
8728 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8729
8730 * indent.c (Fvertical_motion):
8731 * window.c (window_scroll_pixel_based, Frecenter):
8732 Don't pass `need_y_p' to `move_it_by_lines'.
8733
1c470562
SM
87342011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8735
44f230aa
SM
8736 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8737 steal a few bits to be more compact.
8738 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8739 Remove unneeded casts.
8740
1c470562
SM
8741 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8742
888adce9
ZK
87432011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8744
8745 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8746 binding" message (bug#7967).
8747
f838ed7b
PE
87482011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8749
77861b95
PE
8750 Fix more problems found by GCC 4.6.0's static checks.
8751
de6dbc14
PE
8752 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8753 Remove unused local var.
8754
f838ed7b
PE
8755 * editfns.c (Fmessage_box): Remove unused local var.
8756
792c7b2b
PE
8757 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8758 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8759 Omit unused local vars.
c499e557 8760 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8761 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8762 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8763 Omit unused local var.
8764
ba0165e1
PE
8765 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8766 Don't assume string length fits in int.
32ad8845 8767 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8768 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8769
3c59b4c9
PE
8770 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8771 instead of alloca (Bug#8344).
8772
a3eed478 8773 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8774 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8775
eb4d412d
PE
8776 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8777
1658b401
PE
8778 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8779 concerns.
8780
8781 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8782
8783 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8784
9a2c6e05
PE
8785 * keyboard.c (syms_of_keyboard): Use the same style as later
8786 in this function when indexing through an array. This also
8787 works around GCC bug 48267.
8788
03d0a109
PE
8789 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8790
44f730c8
PE
8791 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8792
fe75f926
PE
8793 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8794 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8795
ffa8c828
PE
8796 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8797 This avoids undefined behavior on integer overflow, and is a bit
8798 more convenient anyway since it is compared to a size_t variable.
8799
c5101a77
PE
8800 Variadic C functions now count arguments with size_t, not int.
8801 This avoids an unnecessary limitation on 64-bit machines, which
8802 caused (substring ...) to crash on large vectors (Bug#8344).
8803 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8804 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8805 All variadic functions and their callers changed accordingly.
c5101a77
PE
8806 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8807 * data.c (arith_driver, float_arith_driver): Likewise.
8808 * editfns.c (general_insert_function): Likewise.
8809 * eval.c (struct backtrace.nargs, interactive_p)
8810 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8811 (funcall_lambda, mark_backtrace): Likewise.
8812 * fns.c (concat): Likewise.
8813 * frame.c (x_set_frame_parameters): Likewise.
8814 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8815 0 if not found, not -1. All callers changed.
8816
dd3f25f7
PE
8817 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8818 (stack_copy_size): Now size_t, not int.
8819 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8820
461c2ab9
JB
88212011-03-28 Juanma Barranquero <lekktu@gmail.com>
8822
8823 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8824 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8825 All callers changed.
8826
8827 * lisp.h (multibyte_char_to_unibyte):
8828 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8829 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8830 * character.h (CHAR_TO_BYTE8):
8831 * cmds.c (internal_self_insert):
8832 * editfns.c (general_insert_function):
8833 * keymap.c (push_key_description):
8834 * search.c (Freplace_match):
8835 * xdisp.c (message_dolog, set_message_1): All callers changed.
8836
f6d62986
SM
88372011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8838
8839 * keyboard.c (safe_run_hook_funcall): New function.
8840 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8841 don't set the hook to nil, but remove the offending function instead.
8842 (Qcommand_hook_internal): Remove, unused.
8843 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8844 Vcommand_hook_internal.
8845
8846 * eval.c (enum run_hooks_condition): Remove.
8847 (funcall_nil, funcall_not): New functions.
8848 (run_hook_with_args): Call each function through a `funcall' argument.
8849 Remove `cond' argument, now redundant.
8850 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8851 (Frun_hook_with_args_until_failure): Adjust accordingly.
8852 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8853
1db5b1ad
JB
88542011-03-28 Juanma Barranquero <lekktu@gmail.com>
8855
8856 * dispextern.h (string_buffer_position): Remove declaration.
8857
8858 * print.c (strout): Remove parameter `multibyte', unused since
8859 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8860
8861 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8862 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8863 All callers changed.
8864
8865 * w32.c (_wsa_errlist): Use braces for struct initializers.
8866
8867 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8868 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8869 All callers changed.
8870 (string_buffer_position): Likewise. Also, make static (it's never
8871 used outside xdisp.c).
8872 (cursor_row_p): Remove parameter `w', unused since
8873 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8874 (decode_mode_spec): Remove parameter `precision', introduced during
8875 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8876 All callers changed.
8877
5ffb62aa
JD
88782011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8879
8880 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8881
461c2ab9 88822011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8883
8884 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8885 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8886 (ns_update_auto_hide_menu_bar): New functions.
8887 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8888 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8889 ns_constrain_all_frames.
8890 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8891 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8892
5c380ffb
JD
88932011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8894
8895 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8896
9af30bdf
GM
88972011-03-27 Glenn Morris <rgm@gnu.org>
8898
8899 * syssignal.h: Replace RETSIGTYPE with void.
8900 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8901 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8902 Replace SIGTYPE with void everywhere.
8903 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8904 * s/template.h (SIGTYPE): Remove commented out definition.
8905
e2abce01
JB
89062011-03-26 Eli Zaretskii <eliz@gnu.org>
8907
8908 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8909 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8910
f868cd8a
JB
89112011-03-26 Juanma Barranquero <lekktu@gmail.com>
8912
59eb0929
JB
8913 * w32.c (read_unc_volume): Use parameter `henum', instead of
8914 global variable `wget_enum_handle'.
8915
8916 * keymap.c (describe_vector): Remove parameters `indices' and
8917 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8918 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8919
f868cd8a
JB
8920 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8921
8922 * keyboard.c (timer_check): Remove parameter `do_it_now',
8923 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8924 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8925 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8926
8927 * keyboard.c (read_char):
8928 * w32menu.c (w32_menu_display_help):
8929 * xmenu.c (show_help_event, menu_help_callback):
8930 Adjust calls to `show_help_echo'.
8931
8932 * gtkutil.c (xg_maybe_add_timer):
8933 * keyboard.c (readable_events):
8934 * process.c (wait_reading_process_output):
8935 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8936
8937 * insdel.c (adjust_markers_gap_motion):
8938 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8939 (gap_left, gap_right): Don't call it.
8940
2ecf6fdb
CY
89412011-03-25 Chong Yidong <cyd@stupidchicken.com>
8942
8943 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8944 incurred during fontification.
8945
6b1f9ba4
JB
89462011-03-25 Juanma Barranquero <lekktu@gmail.com>
8947
8948 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8949 (DEFVAR_PER_BUFFER): Don't pass it.
8950
8951 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8952 (scrolling_window): Don't pass it.
8953
0f4a96b5
JB
89542011-03-25 Juanma Barranquero <lekktu@gmail.com>
8955
8956 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8957
8958 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8959 and `suffix'.
8960 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8961 of variables specific to SELinux and computation of `encoded_absname'.
8962
8963 * image.c (XPutPixel): Remove unused variable `height'.
8964
8965 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8966
8967 * unexw32.c (get_section_info): Remove unused variable `section'.
8968
8969 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8970 (system_process_attributes): Remove unused variable `sess'.
8971 (sys_read): Remove unused variable `err'.
8972
8973 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8974 (w32_wnd_proc): Remove unused variable `isdead'.
8975 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8976 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8977 (x_create_tip_frame): Remove unused variable `tem'.
8978
8979 * w32inevt.c (w32_console_read_socket):
8980 Remove unused variable `no_events'.
8981
8982 * w32term.c (x_draw_composite_glyph_string_foreground):
8983 Remove unused variable `width'.
8984
1149507c
JB
89852011-03-24 Juanma Barranquero <lekktu@gmail.com>
8986
8987 * w32term.c (x_set_glyph_string_clipping):
8988 Don't pass uninitialized region to CombineRgn.
8989
9c88f339
JB
89902011-03-23 Juanma Barranquero <lekktu@gmail.com>
8991
8992 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8993 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8994 (Fx_close_connection): Remove unused variable `i'.
8995
8996 * w32font.c (w32font_draw): Return number of glyphs.
8997 (w32font_open_internal): Remove unused variable `i'.
8998 (w32font_driver): Add missing initializer.
8999
9000 * w32menu.c (utf8to16): Remove unused variable `utf16'.
9001 (fill_in_menu): Remove unused variable `items_added'.
9002
9003 * w32term.c (last_mouse_press_frame): Remove static global variable.
9004 (w32_clip_to_row): Remove unused variable `f'.
9005 (x_delete_terminal): Remove unused variable `i'.
9006
9007 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
9008 (NOTHING): Remove unused static global variable.
9009 (uniscribe_check_otf): Remove unused variable `table'.
9010 (uniscribe_font_driver): Add missing initializers.
9011
dee091a3
JD
90122011-03-23 Julien Danjou <julien@danjou.info>
9013
9014 * term.c (Fsuspend_tty, Fresume_tty):
9015 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
9016 * window.c (temp_output_buffer_show):
9017 * insdel.c (signal_before_change):
9018 * frame.c (Fhandle_switch_frame):
9019 * fileio.c (Fdo_auto_save):
9020 * emacs.c (Fkill_emacs):
9021 * editfns.c (save_excursion_restore):
9022 * cmds.c (internal_self_insert):
9023 * callint.c (Fcall_interactively):
9024 * buffer.c (Fkill_all_local_variables):
9025 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
9026 Use Frun_hooks.
0f4a96b5 9027 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 9028 unconditionally since it does the check itself.
dee091a3 9029
2c520ab5 90302011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 9031
c9c49752
PE
9032 Fix more problems found by GCC 4.5.2's static checks.
9033
8abc3f12
PE
9034 * coding.c (encode_coding_raw_text): Avoid unnecessary test
9035 the first time through the loop, since we know p0 < p1 then.
9036 This also avoids a gcc -Wstrict-overflow warning.
9037
a2d26660
PE
9038 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
9039 leading to a memory leak, possible in functions like
9040 load_charset_map_from_file that can allocate an unbounded number
b12ef411 9041 of objects (Bug#8318).
a2d26660 9042
916c72e9
PE
9043 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
9044 that could (at least in theory) be that large.
9045
19ab8a18
PE
9046 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
9047 This is less likely to overflow, and avoids undefined behavior if
9048 overflow does occur. All callers changed. Use strtoul to scan
9049 for the unsigned long integer.
b7cbbd6f
PE
9050 (pint2hrstr): Simplify and tune code slightly.
9051 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 9052
f0641eff
PE
9053 * scroll.c (do_scrolling): Work around GCC bug 48228.
9054 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
9055
7f650bb9
PE
9056 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
9057 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
9058 (validate_x_resource_name): Simplify count usage.
9059 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 9060
37dd57d1
PE
9061 * fileio.c (Fcopy_file): Report error if fchown or fchmod
9062 fail (Bug#8306).
81e56e61 9063
699979fc 9064 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 9065
401bf9b4
PE
9066 * process.c (Fmake_network_process): Use socklen_t, not int,
9067 where POSIX says socklen_t is required in portable programs.
9068 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 9069 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
9070 (Fmake_network_process, server_accept_connection):
9071 (wait_reading_process_output, read_process_output):
9072 Likewise.
9073
b93aacde
PE
9074 * process.c: Rename or move locals to avoid shadowing.
9075 (list_processes_1, Fmake_network_process):
9076 (read_process_output_error_handler, exec_sentinel_error_handler):
9077 Rename or move locals.
4dc343ee 9078 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 9079 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 9080 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 9081 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 9082 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 9083
af8a867c 9084 Make tparam.h and terminfo.c consistent.
44f230aa
SM
9085 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
9086 Include tparam.h instead, since it declares them.
af8a867c
PE
9087 * cm.h (PC): Remove extern decl; tparam.h now does this.
9088 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
9089 * terminfo.c: Include tparam.h, to check interfaces.
9090 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
9091 (tparam): Adjust signature to match interface in tparam.h;
9092 this removes some undefined behavior. Check that outstring and len
9093 are zero, which they always are with Emacs.
9094 * tparam.h (PC, BC, UP): New extern decls.
9095
0248044d 9096 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 9097 (xftfont_open): Rename locals to avoid shadowing.
0248044d 9098
8ff096c1 9099 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
9100 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
9101 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 9102 (ftfont_list): Remove unused local.
49eaafba
PE
9103 (get_adstyle_property, ftfont_pattern_entity):
9104 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
9105 Rename locals to avoid shadowing.
8ff096c1 9106
e2be39f6
PE
9107 * xfont.c (xfont_list_family): Mark var as initialized.
9108
c9735e30
PE
9109 * xml.c (make_dom): Now static.
9110
8f5201ae
PE
9111 * composite.c (composition_compute_stop_pos): Rename local to
9112 avoid shadowing.
b246f932
PE
9113 (composition_reseat_it): Remove unused locals.
9114 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 9115 (composition_update_it): Mark var as initialized.
11b61122
PE
9116 (find_automatic_composition): Mark vars as initialized,
9117 with a FIXME (Bug#8290).
8f5201ae 9118
760fbc2c
PE
9119 character.h: Rename locals to avoid shadowing.
9120 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
9121 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
9122 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
9123 (BUF_DEC_POS): Be more systematic about renaming local temporaries
9124 to avoid shadowing.
9125
ff08eb85
PE
9126 * textprop.c (property_change_between_p): Remove; unused.
9127
fc7bf025
PE
9128 * intervals.c (interval_start_pos): Now static.
9129
235d7abc
PE
9130 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
9131
44f230aa
SM
9132 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
9133 Rename locals to avoid shadowing.
3e7d6594 9134
50060332
PE
9135 * sound.c (wav_play, au_play, Fplay_sound_internal):
9136 Fix pointer signedness.
d01f234b 9137 (alsa_choose_format): Remove unused local var.
c83b8872
PE
9138 (wav_play): Initialize a variable to 0, to prevent undefined
9139 behavior (Bug#8278).
50060332 9140
c4fc4e30
PE
9141 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
9142
918436ed
PE
9143 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
9144
c939f91b
PE
9145 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
9146 clobbering (Bug#8298).
b9c7f648
PE
9147 * sysdep.c (sys_subshell): Likewise.
9148 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 9149
6bd8c144
PE
9150 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9151 This should get cleaned up, so that child_setup has the
9152 same signature on all platforms.
9153
7710357c 9154 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9155 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9156
c59da222
CY
91572011-03-22 Chong Yidong <cyd@stupidchicken.com>
9158
9159 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9160 not to be necessary, and produces flickering.
9161
66b87493
GM
91622011-03-20 Glenn Morris <rgm@gnu.org>
9163
9164 * config.in: Remove file.
9165
45b6f6d5
JB
91662011-03-20 Juanma Barranquero <lekktu@gmail.com>
9167
9168 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9169 are now in src/globals.h.
9170 (syms_of_minibuf): Remove spurious & from previous change.
9171
cd394be1 91722011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9173
9174 * minibuf.c (completing-read-function): New variable.
9175 (completing-read-default): Rename from completing-read.
9176 (completing-read): Call completing-read-function.
9177
b14e3e21
CY
91782011-03-19 Juanma Barranquero <lekktu@gmail.com>
9179
9180 * xfaces.c (Fx_load_color_file):
9181 Read color file from absolute filename (bug#8250).
9182
f2b726e6
JB
91832011-03-19 Juanma Barranquero <lekktu@gmail.com>
9184
9185 * makefile.w32-in: Update dependencies.
9186
09f6ff02
EZ
91872011-03-17 Eli Zaretskii <eliz@gnu.org>
9188
9189 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9190
29a6015a
PE
91912011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9192
a3a6c54e
PE
9193 Fix more problems found by GCC 4.5.2's static checks.
9194
b766f867
PE
9195 * process.c (make_serial_process_unwind, send_process_trap):
9196 (sigchld_handler): Now static.
9197
be02381c
PE
9198 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9199 That way, the code declares only the vars that it needs.
9200 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9201 * s/cygwin.h (PTY_ITERATION): Likewise.
9202 * s/darwin.h (PTY_ITERATION): Likewise.
9203 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9204
57048744
PE
9205 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9206 * process.c (allocate_pty): Don't declare stb unless it's needed.
9207
7914961c 9208 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9209 (CONSTANTLIM): Remove; unused.
9210 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9211 Define only if needed.
7914961c 9212
b3967b18
PE
9213 * unexelf.c (unexec): Name an expression,
9214 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9215 Use a different way to cause a compilation error if anyone uses
9216 n rather than nn, a way that does not involve shadowing.
73366a00 9217 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9218
29a6015a
PE
9219 * deps.mk (unexalpha.o): Remove; unused.
9220
43cfc33e 9221 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9222 * unexec.h: New file.
ce701a33
PE
9223 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9224 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9225 Depend on unexec.h.
9226 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9227 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9228 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9229 Change as necessary to match prototype in unexec.h.
ce701a33 9230
01f44d5a
PE
9231 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9232 shadowing.
4f63c6bb 9233 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9234
a6670b0b
PE
9235 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9236 Rename locals to avoid shadowing.
9237
cef2010d 9238 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9239 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9240
d4d7173a
PE
9241 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9242
f08b802a
PE
9243 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9244 warning when compiling print.c.
9245
3ddb0639
PE
9246 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9247 instead of using an uninitialized var.
5ad03b97 9248 (font_sort_entities): Mark var as initialized.
3ddb0639 9249
170a2692
PE
9250 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9251
e663c700
PE
9252 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9253 pointers to constants.
89bc529a 9254 (font_parse_fcname): Remove unused vars.
7b81e2d0 9255 (font_delete_unmatched): Now static.
ea838e10 9256 (font_get_spec): Remove; unused.
13a547c6
PE
9257 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9258 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9259 Rename or move locals to avoid shadowing.
e663c700 9260
2a80c887 9261 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9262 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9263
1384fa33 9264 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9265 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9266
8b2c52e9
PE
9267 * alloc.c (mark_backtrace): Move decl from here ...
9268 * lisp.h: ... to here, so that it can be checked.
9269
475545b5 9270 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9271 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9272 (lisp_indirect_variable): Name an expression,
9273 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9274 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9275
b1349114 9276 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9277 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9278 Use const pointer when appropriate.
b1349114 9279
a2928364
PE
9280 * lisp.h (get_system_name, get_operating_system_release):
9281 Move decls here, to check interfaces.
9282 * process.c (get_operating_system_release): Move decl to lisp.h.
9283 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9284 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9285 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9286 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9287 (Fformat_time_string, Fencode_time, Finsert_char):
9288 (Ftranslate_region_internal, Fformat):
9289 Rename or remove local vars to avoid shadowing.
9710023e 9290 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9291
a415e694
PE
9292 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9293 avoid shadowing.
9294
8ef4622d
PE
9295 * lisp.h (eassert): Check that the argument compiles, even if
9296 ENABLE_CHECKING is not defined.
9297
946f9a5b
PE
9298 * data.c (Findirect_variable): Name an expression, to avoid
9299 gcc -Wbad-function-cast warning.
112396d6 9300 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9301 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9302 (Fmake_variable_buffer_local, Fmake_local_variable):
9303 Mark variables as initialized.
52746918 9304 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9305
e5aab7e7 9306 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9307 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9308 Rename locals to avoid shadowing.
dff45157
PE
9309 (mark_stack): Move local variables into the #ifdef region where
9310 they're used.
7bc26fdb
PE
9311 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9312 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9313 needed otherwise.
9314 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9315 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9316 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9317
e5aab7e7
PE
9318 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9319 avoids undefined behavior in theory.
9320
4da60324
PE
9321 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9322
88043301
PE
9323 Use functions, not macros, for up- and down-casing (Bug#8254).
9324 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9325 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9326 to use the following functions instead of these macros.
9327 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9328 EMACS_INT, since callers assume the returned value fits in int.
9329 (upcase1): Likewise, for UPCASE_TABLE.
9330 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9331 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9332 the race-condition problem in the old DOWNCASE.
88043301 9333
19ed5445
PE
9334 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9335 Rename locals to avoid shadowing.
9336 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9337 (regex_compile, re_search_2, re_match_2_internal):
9338 Remove unused local vars.
952db0d7
PE
9339 (FREE_VAR): Rewrite so as not to use empty "else",
9340 which gcc can warn about.
da053e48 9341 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9342 (RETALLOC_IF): Define only if needed.
9343 (WORDCHAR_P): Likewise. This one is never needed, but is used
9344 only in a comment talking about a compiler bug, so put inside
9345 the #if 0 of that comment.
9346 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9347 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9348 Remove; unused.
19ed5445 9349
1f3561e4 9350 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9351 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9352 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9353
ded6f8f7
PE
9354 * search.c (simple_search): Remove unused var.
9355
dbd37a95
PE
9356 * dired.c (compile_pattern): Move decl from here ...
9357 * lisp.h: ... to here, so that it can be checked.
9358 (struct re_registers): New forward decl.
9359
7e47afad
PE
9360 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9361
85f24f61
PE
9362 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9363 All uses changed.
9364 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9365 Rename locals to avoid shadowing.
5671df8f 9366 (Fvertical_motion): Mark locals as initialized.
85f24f61 9367
181aa2be 9368 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9369 (casify_region): Mark local as initialized.
181aa2be 9370
930d429c
PE
9371 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9372
7082eac6
PE
9373 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9374 New macros, so that the caller can use some names other than
9375 gcpro1, gcpro2, etc.
9376 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9377 of the new macros.
9378 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9379 argument, for consistency with GCPRO2_VAR, etc: it is now the
9380 prefix of the variable, not the variable itself. All uses
9381 changed.
38b2c076
PE
9382 * dired.c (directory_files_internal, file_name_completion):
9383 Rename locals to avoid shadowing.
9384
15206ed9
PE
9385 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9386 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9387 dired.c's scmp function, had undefined behavior.
9388 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9389 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9390 * buffer.h: ... to here, because these macros use current_buffer,
9391 and the new implementation with inline functions needs to have
9392 current_buffer in scope now, rather than later when the macros
9393 are used.
9394 (downcase, upcase1): New static inline functions.
9395 (DOWNCASE, UPCASE1): Reimplement using these functions.
9396 This avoids undefined behavior in expressions like
9397 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9398 from race conditions in accessing the global variables
9399 case_temp1 and case_temp2.
9400 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9401 * lisp.h (case_temp1, case_temp2): Remove their decls.
9402 * character.h (ASCII_CHAR_P): Move from here ...
9403 * lisp.h: ... to here, so that the inline functions mentioned
9404 above can use them.
9405
4a6bea26
PE
9406 * dired.c (directory_files_internal_unwind): Now static.
9407
f14b7e14
PE
9408 * fileio.c (file_name_as_directory, directory_file_name):
9409 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9410 Now static.
2893f146
PE
9411 (file_name_as_directory): Use const pointers when appropriate.
9412 (Fexpand_file_name): Likewise. In particular, newdir might
9413 point at constant storage, so make it a const pointer.
fd4ead52 9414 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9415 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9416 signedness issues.
f839df0c
PE
9417 (Fset_file_times, Finsert_file_contents, auto_save_error):
9418 Rename locals to avoid shadowing.
f14b7e14 9419
5716756e 9420 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9421 (Ftry_completion, Fall_completions): Rename or remove locals
9422 to avoid shadowing.
5716756e 9423
b4c3046a
PE
9424 * marker.c (bytepos_to_charpos): Remove; unused.
9425
b45db522
PE
9426 * lisp.h (verify_bytepos, count_markers): New decls,
9427 so that gcc does not warn that these functions aren't declared.
9428
85876d07
PE
9429 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9430 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9431 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9432 (copy_text): Remove unused local var.
85876d07 9433
03d78a21 9434 * filelock.c (within_one_second): Now static.
b3dd38ab 9435 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9436
5df8f01b
PE
9437 * buffer.c (fix_overlays_before): Mark locals as initialized.
9438 (fix_start_end_in_overlays): Likewise. This function should be
9439 simplified by using pointers-to-pointers, but that's a different
9440 matter.
b1d876f1 9441 (switch_to_buffer_1): Now static.
8f54f30a
PE
9442 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9443 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9444
a70072c9 9445 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9446 Fix pointer signedness issue.
edced198
PE
9447 (sys_subshell): Mark local as volatile if checking for lint,
9448 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9449 (MAXPATHLEN): Define only if needed.
a70072c9 9450
a0977c44
PE
9451 * process.c (serial_open, serial_configure): Move decls from here ...
9452 * systty.h: ... to here, so that they can be checked.
9453
a884fdcc
PE
9454 * fns.c (get_random, seed_random): Move extern decls from here ...
9455 * lisp.h: ... to here, so that they can be checked.
9456
604efe86 9457 * sysdep.c (reset_io): Now static.
b8950c94 9458 (wait_for_termination_signal): Remove; unused.
604efe86 9459
38fc62d9
PE
9460 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9461 (copy_keymap_item, append_key, push_text_char_description):
9462 Now static.
1004a21a 9463 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9464 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9465 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9466 (describe_map_tree):
9467 Rename locals to avoid shadowing.
38fc62d9 9468
2f2650da
PE
9469 * keyboard.c: Declare functions static if they are not used elsewhere.
9470 (echo_char, echo_dash, cmd_error, top_level_2):
9471 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9472 (read_char, kbd_buffer_get_event, make_lispy_position):
9473 (make_lispy_event, make_lispy_movement, apply_modifiers):
9474 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9475 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9476 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9477 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9478 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9479
a053e86c 9480 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9481 (mark_kboards): Move decl here ...
9482 * alloc.c (mark_kboards): ... from here.
a053e86c 9483
4752793e
PE
9484 * lisp.h (force_auto_save_soon): New decl.
9485
74f10ca7 9486 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9487 (DEFINE_DUMMY_FUNCTION): New macro.
9488 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9489 Use it.
c03cd23f
PE
9490 (main): Add casts to avoid warnings
9491 if GCC considers string literals to be constants.
74f10ca7 9492
022e70d4
PE
9493 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9494
59d6fe83
PE
9495 * dbusbind.c: Pointer signedness fixes.
9496 (xd_signature, xd_append_arg, xd_initialize):
9497 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9498 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9499 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9500 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9501
78320123
PE
9502 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9503 if GCC considers string literals to be constants.
49cebcca 9504 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9505
35ac2a97
SM
95062011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9507
fb103ca9
SM
9508 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9509 (print_preprocess, print_object): New macro to fix last change.
9510
35ac2a97
SM
9511 * print.c (print_preprocess): Don't forget font objects.
9512
62973b41
JB
95132011-03-16 Juanma Barranquero <lekktu@gmail.com>
9514
9515 * emacs.c (USAGE3): Doc fixes.
9516
0e48bb22
AS
95172011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9518
9519 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9520 structure.
9521
7684e57b
JB
95222011-03-14 Juanma Barranquero <lekktu@gmail.com>
9523
9524 * lisp.h (VWindow_system, Qfile_name_history):
9525 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9526 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9527 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9528
9529 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9530 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9531
9532 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9533 * w32console.c (detect_input_pending, read_input_pending)
9534 (encode_terminal_code):
9535 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9536 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9537 (w32_system_caret_y, Qfile_name_history):
9538 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9539 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9540 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9541 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9542 * w32proc.c (Qlocal, report_file_error):
9543 * w32term.c (Vwindow_system, updating_frame):
9544 * w32uniscribe.c (initialized, uniscribe_font_driver):
9545 Remove unneeded extern declarations.
9546
2aa46d6c
CY
95472011-03-14 Chong Yidong <cyd@stupidchicken.com>
9548
c96bbc66 9549 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9550
cffc6f3b
CY
95512011-03-13 Chong Yidong <cyd@stupidchicken.com>
9552
9553 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9554 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9555 These macros can no longer be used for assignment.
9556
44f230aa
SM
9557 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9558 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9559 (record_buffer_markers, fetch_buffer_markers): New functions for
9560 recording and fetching special buffer markers.
9561 (set_buffer_internal_1, set_buffer_temp): Use them.
9562
9563 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9564
9565 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9566
9567 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9568 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9569
9570 * xdisp.c (hscroll_window_tree):
9571 (reconsider_clip_changes): Use PT instead of BUF_PT.
9572
d251f04b
EZ
95732011-03-13 Eli Zaretskii <eliz@gnu.org>
9574
9575 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9576 $(EMACS_ROOT)/lib/intprops.h.
9577
f0c77cd1
PE
95782011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9579
3eca4629
PE
9580 Fix more problems found by GCC 4.5.2's static checks.
9581
7c86ee98
PE
9582 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9583 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9584 (xg_free_frame_widgets): Make it clear that a local variable is
9585 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9586 (gdk_window_get_screen): Make it clear that this macro is needed
9587 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9588 (int_gtk_range_get_value): New function, which avoids a diagnostic
9589 from gcc -Wbad-function-cast.
9590 (xg_set_toolkit_scroll_bar_thumb): Use it.
9591 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9592 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9593 (get_utf8_string, xg_get_file_with_chooser):
9594 Rename locals to avoid shadowing.
9595 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9596
41729b81
PE
9597 * xgselect.c (xg_select): Remove unused var.
9598
f0c77cd1
PE
9599 * image.c (four_corners_best): Mark locals as initialized.
9600 (gif_load): Initialize transparent_p to zero (Bug#8238).
9601 Mark another local as initialized.
ec6cf4c6 9602 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9603
ce0ad53d 9604 * image.c (clear_image_cache): Now static.
d5d5a617 9605 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9606 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9607 (x_edge_detection): Remove unnecessary cast that
9608 gcc -Wbad-function-cast diagnoses.
2037898d 9609 (gif_load): Fix pointer signedness.
6ae141d6
PE
9610 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9611 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9612
33383987 96132011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9614
d32df629
PE
9615 Improve quality of tests for time stamp overflow.
9616 For example, without this patch (encode-time 0 0 0 1 1
9617 1152921504606846976) returns the obviously-bogus value (-948597
9618 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9619 reports time overflow. See
9620 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9621 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9622 * editfns.c: Include limits.h and intprops.h.
9623 (TIME_T_MIN, TIME_T_MAX): New macros.
9624 (time_overflow): Move earlier, to before first use.
9625 (hi_time, lo_time): New functions, for an accurate test for
9626 out-of-range times.
9627 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9628 (Fget_internal_run_time): Don't assume time_t fits in int.
9629 (make_time): Use list2 instead of Fcons twice.
9630 (Fdecode_time): More accurate test for out-of-range times.
9631 (check_tm_member): New function.
9632 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9633 (lisp_time_argument): Don't rely on undefined left-shift and
9634 right-shift behavior when checking for time stamp overflow.
8be6f318 9635
fe31d94c
PE
9636 * editfns.c (time_overflow): New function, refactoring common code.
9637 (Fformat_time_string, Fdecode_time, Fencode_time):
9638 (Fcurrent_time_string): Use it.
9639
8be6f318
PE
9640 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9641 * dired.c (make_time): Move to ...
9642 * editfns.c (make_time): ... here.
9643 * systime.h: Note the move.
9644
09d9db2c 96452011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9646
126bc0dc
YM
9647 * fringe.c (update_window_fringes): Remove unused variables.
9648
c47cbdfd
YM
9649 * unexmacosx.c (copy_data_segment): Also copy __got section.
9650 (Bug#8223)
9651
7ac80be9
EZ
96522011-03-12 Eli Zaretskii <eliz@gnu.org>
9653
c96bbc66 9654 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9655 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9656 Constify `char *' arguments and their references according to
9657 prototypes in tparam.h.
9658
ecb0f94d 9659 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9660
7ac80be9
EZ
9661 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9662 Adapt all references accordingly.
9663
9664 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9665
ef1fd07e
TT
96662011-03-11 Tom Tromey <tromey@redhat.com>
9667
9668 * buffer.c (syms_of_buffer): Remove obsolete comment.
9669
7ef4b50c
EZ
96702011-03-11 Eli Zaretskii <eliz@gnu.org>
9671
9672 * termhooks.h (encode_terminal_code): Declare prototype.
9673
9674 * msdos.c (encode_terminal_code): Don't declare prototype.
9675
9676 * term.c (encode_terminal_code): Now external again, used by
9677 w32console.c and msdos.c.
9678
44f230aa
SM
9679 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9680 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9681
4b1ec863 96822011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9683
1714f52b 9684 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9685
4b1ec863
PE
9686 * fringe.c (update_window_fringes): Mark locals as initialized
9687 (Bug#8227).
9688 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9689
524c7aa6
PE
9690 * alloc.c (mark_fringe_data): Move decl from here ...
9691 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9692 to check its interface.
9693 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9694
a5c0af81 9695 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9696 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9697 (fontset_font): Mark local as initialized.
a9a06e0b 9698 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9699
b4716021
PE
9700 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9701
811e9bac 9702 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9703 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9704 (x_own_selection, Fx_disown_selection_internal): Rename locals
9705 to avoid shadowing.
9706 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9707
7e3ab302
PE
9708 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9709 so that the caller can use some name other than gcpro1.
9710 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9711 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9712 (Fx_backspace_delete_keys_p):
9713 Use them to avoid shadowing, and rename vars to avoid shadowing.
9714 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9715 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9716 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9717 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9718 Remove unused locals.
7e3ab302
PE
9719 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9720 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9721 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9722 macros.
f78faa98 9723
e2b13473
PE
9724 * xterm.h (x_mouse_leave): New decl.
9725
77f23912
PE
9726 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9727 Remove unused functions.
cdf4ba58
PE
9728 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9729 (x_calc_absolute_position): Now static.
7411c686 9730 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9731 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9732 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9733 unless they are used.
38d0b34a
PE
9734 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9735 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9736 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9737 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9738 (x_error_catcher, x_connection_closed, x_error_handler):
9739 (x_error_quitter, xembed_send_message, x_iconify_frame):
9740 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9741 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9742 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9743
44f230aa
SM
9744 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9745 Rename or move locals to avoid shadowing.
6b463e58 9746 (tty_defined_color, merge_face_heights): Now static.
5967d051 9747 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9748 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9749 does not deduce is never used uninitialized.
73719eba
PE
9750 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9751 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9752
426994c3 9753 * terminal.c (store_terminal_param): Now static.
5489860b 9754
032f1620 9755 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9756 (set_frame_menubar): Remove unused local.
d4323972 9757 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9758 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9759 since they might point to immutable storage.
281585b0
PE
9760 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9761 since it's unused otherwise.
032f1620 9762
367c19e5 9763 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9764 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9765 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9766 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9767 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9768 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9769 does not deduce are never used uninitialized.
70739cbe 9770
07b48fa9
PE
9771 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9772
8868a238 9773 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9774 * window.c (window_loop, size_window):
9775 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9776
7e5cf297 9777 * window.c (display_buffer): Now static.
d6550a9f
PE
9778 (size_window): Mark variables that gcc -Wuninitialized
9779 does not deduce are never used uninitialized.
a586633d
PE
9780 * window.h (check_all_windows): New decl, to forestall
9781 gcc -Wmissing-prototypes diagnostic.
5b555da1 9782 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9783
f6095868
PE
9784 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9785 shadowing.
9786 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9787 Include <limits.h>.
9788 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9789 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9790 (load_charset_map): Mark variables that gcc -Wuninitialized
9791 does not deduce are never used uninitialized.
53df7c11 9792 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9793
f38b440c
PE
9794 * coding.c (coding_set_source, coding_set_destination):
9795 Use "else { /* comment */ }" rather than "else /* comment */;"
9796 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9797 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9798 a block, when the outer 'i' will do.
9799 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9800 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9801 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9802 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9803 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9804 Rename locals to avoid shadowing.
9805 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9806 * coding.c (emacs_mule_char, encode_invocation_designation):
9807 Now static, since they're not used elsewhere.
413bb2db 9808 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9809 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9810 (decode_coding_emacs_mule): Mark variables that gcc
9811 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9812 (detect_coding_iso_2022): Initialize a local variable that might
9813 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9814 this initialization is needed. (Bug#8211)
5f58e762
PE
9815 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9816 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9817 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9818 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9819 Remove unused macros.
f38b440c 9820
232b38b9 9821 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9822 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9823 * character.c (string_count_byte8): Likewise.
232b38b9 9824
fb90da1b
PE
9825 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9826 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9827
fb93dbc2
PE
9828 * chartab.c (copy_sub_char_table): Now static, since it's not used
9829 elsewhere.
5c156ace
PE
9830 (sub_char_table_ref_and_range, char_table_ref_and_range):
9831 Rename locals to avoid shadowing.
bbcd0949 9832 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9833
7d3b3862 9834 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9835 (BIDI_BOB): Remove unused macro.
7d3b3862 9836
6be7d3da
PE
9837 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9838 deduce are never used uninitialized.
c2ed9c8b 9839 * term.c (encode_terminal_code): Likewise.
6be7d3da 9840
75f8807f 9841 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9842
50938595
PE
9843 * tparam.h: New file.
9844 * term.c, tparam.h: Include it.
9845 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9846 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9847 Move these decls to tparam.h, and make them agree with what
9848 is actually in tparam.c. The previous trick of using incompatible
9849 decls in different modules does not conform to the C standard.
9850 All callers of tparam changed to use tparam's actual API.
9851 * tparam.c (tparam1, tparam, tgoto):
9852 Use const pointers where appropriate.
9853
fbceeba2
PE
9854 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9855 * cm.h (struct cm): Likewise.
9856 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9857 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9858 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9859 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9860 (turn_on_face, init_tty): Likewise.
9861 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9862
7f3f1250
PE
9863 * term.c (term_mouse_position): Rename local to avoid shadowing.
9864
e6ca6543
PE
9865 * alloc.c (mark_ttys): Move decl from here ...
9866 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9867
c40f8d15
AS
98682011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9869
9870 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9871
cfe0661d
JB
98722011-03-09 Juanma Barranquero <lekktu@gmail.com>
9873
9874 * search.c (compile_pattern_1): Remove argument regp, unused since
9875 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9876 (compile_pattern): Don't pass it.
9877
0afb4571
J
98782011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9879
9880 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9881 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9882 for ! HAVE_GTK3.
9883 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9884
9885 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9886
9887 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9888 gdk_window_get_screen, gdk_window_get_geometry,
9889 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9890 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9891 (xg_get_pixbuf_from_pixmap): New function.
9892 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9893 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9894 Call xg_get_pixbuf_from_pixmap instead of
9895 gdk_pixbuf_get_from_drawable.
9896 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9897 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9898 (xg_check_special_colors): Use GtkStyleContext and its functions
9899 for HAVE_GTK3.
9900 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9901 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9902 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9903 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9904 Call gtk_widget_get_preferred_size.
0afb4571
J
9905 (xg_frame_resized): gdk_window_get_geometry only takes 5
9906 parameters.
44f230aa
SM
9907 (xg_win_to_widget, xg_event_is_for_menubar):
9908 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9909 (xg_set_widget_bg): New function.
9910 (delete_cb): New function.
895009e1 9911 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9912 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9913 (xg_set_background_color): Call xg_set_widget_bg.
9914 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9915 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9916 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9917 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9918 if ! HAVE_GTK3.
9919 (update_frame_tool_bar): Call gtk_widget_hide.
9920 (xg_initialize): Use GDK_KEY_g.
9921
9922 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9923 if ! HAVE_GTK3
9924 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9925
9926 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9927 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9928 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9929
1c2cc4ef
JB
99302011-03-08 Juanma Barranquero <lekktu@gmail.com>
9931
9932 * w32xfns.c (select_palette): Check success of RealizePalette against
9933 GDI_ERROR, not zero.
9934
33383987 9935See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9936
9937;; Local Variables:
9938;; coding: utf-8
aac0c6e3
MR
9939;; End:
9940
acaf905b 9941 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9942
9943 This file is part of GNU Emacs.
9944
9945 GNU Emacs is free software: you can redistribute it and/or modify
9946 it under the terms of the GNU General Public License as published by
9947 the Free Software Foundation, either version 3 of the License, or
9948 (at your option) any later version.
9949
9950 GNU Emacs is distributed in the hope that it will be useful,
9951 but WITHOUT ANY WARRANTY; without even the implied warranty of
9952 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9953 GNU General Public License for more details.
9954
9955 You should have received a copy of the GNU General Public License
9956 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.