Make sure a 64-bit char is never passed to CHAR_STRING.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
13bdea59
PE
12011-06-13 Paul Eggert <eggert@cs.ucla.edu>
2
3
4 Make sure a 64-bit char is never passed to CHAR_STRING.
5 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
6 by silently ignoring the top 32 bits, allowing some values
7 that were far too large to be valid characters.
8 * character.h: Include <verify.h>.
9 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10 arguments are no wider than unsigned, as a compile-time check
11 to prevent future regressions in this area.
12 * data.c (Faset):
13 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char):
14 (Fsubst_char_in_region):
15 * fns.c (concat):
16 * xdisp.c (decode_mode_spec_coding):
17 Adjust to CHAR_STRING's new requirement.
18 * editfns.c (Finsert_char, Fsubst_char_in_region):
19 * fns.c (concat): Check that character args are actually
20 characters. Without this test, these functions did the wrong
21 thing with wildly out-of-range values on 64-bit hosts.
22
ea204efb
PE
232011-06-12 Paul Eggert <eggert@cs.ucla.edu>
24
d37ca623
PE
25 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
26 These casts should not be needed on 32-bit hosts, either.
27 * keyboard.c (read_char):
28 * lread.c (Fload): Remove casts to unsigned.
29
ea204efb
PE
30 * lisp.h (UNSIGNED_CMP): New macro.
31 This fixes comparison bugs on 64-bit hosts.
32 (ASCII_CHAR_P): Use it.
33 * casefiddle.c (casify_object):
34 * character.h (ASCII_BYTE_P, CHAR_VALID_P):
35 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
36 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
37 * dispextern.h (FACE_FROM_ID):
38 * keyboard.c (read_char): Use UNSIGNED_CMP.
39
fc83f7d3 402011-06-11 Paul Eggert <eggert@cs.ucla.edu>
666398f3 41
41cb286c
PE
42 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
43 not to EMACS_INT, to avoid GCC warning.
44
4a1b9832
PE
45 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
46
55daad71
PE
47 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
48 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
49 isn't needed on 32-bit machines.
8f95c75c 50
666398f3 51 * buffer.c (Fgenerate_new_buffer_name): Use EMACS_INT for count, not int.
0ceccced 52 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
53
54 * data.c (Qcompiled_function): Now static.
55
c6f072e7
PE
56 * window.c (window_body_lines): Now static.
57
20ce5912
PE
58 * image.c (gif_load): Rename local to avoid shadowing.
59
9c4c5f81
PE
60 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
61 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
62 * alloc.c (make_save_value): Integer argument is now of type
63 ptrdiff_t, not int.
64 (mark_object): Use ptrdiff_t, not int.
65 * lisp.h (pD): New macro.
66 * print.c (print_object): Use it.
67
c0c5c8ae
PE
68 * alloc.c: Use EMACS_INT, not int, to count objects.
69 (total_conses, total_markers, total_symbols, total_vector_size)
70 (total_free_conses, total_free_markers, total_free_symbols)
71 (total_free_floats, total_floats, total_free_intervals, total_intervals)
72 (total_strings, total_free_strings):
73 Now EMACS_INT, not int. All uses changed.
74 (Fgarbage_collect): Compute overall total using a double, so that
75 integer overflow is less likely to be a problem. Check for overflow
76 when converting back to an integer.
5a25e253
PE
77 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
78 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
79 These were 'int' variables that could overflow on 64-bit hosts;
80 they were never used, so remove them instead of repairing them.
211a0b2a 81 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
82 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
83 Previously, this ceilinged at INT_MAX, but that doesn't work on
84 64-bit machines.
e46bb31a 85 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 86
c78baabf 87 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 88 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
89 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
90 when a (possibly-narrower) signed value would do just as well.
91 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 92
c9d624c6
PE
93 * alloc.c: Catch some string size overflows that we were missing.
94 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
95 for convenience in STRING_BYTES_MAX.
96 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
97 The definition here is exact; the one in lisp.h was approximate.
98 (allocate_string_data): Check for string overflow. This catches
99 some instances we weren't catching before. Also, it catches
100 size_t overflow on (unusual) hosts where SIZE_MAX <= min
101 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
102 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 103
c9d624c6
PE
104 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
105 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
106 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
107
353032ce
PE
108 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
109
2bccce07
PE
110 * alloc.c (Fmake_string): Check for out-of-range init.
111
b50691aa
CY
1122011-06-11 Chong Yidong <cyd@stupidchicken.com>
113
114 * dispextern.h (struct image): Replace data member, whose int_val
115 and ptr_val fields were not used by anything, with a single
116 lisp_val object.
117
118 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
119 (gif_clear_image, gif_load, imagemagick_load_image)
120 (gs_clear_image, gs_load): Callers changed.
121
3f754b86
PE
1222011-06-10 Paul Eggert <eggert@cs.ucla.edu>
123
cca69397
PE
124 * buffer.h: Include <time.h>, for time_t.
125 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
126
109e28d0
PE
127 Fix minor problems found by static checking.
128
60737f02
PE
129 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
130
4b66faf3
PE
131 Make identifiers static if they are not used in other modules.
132 * data.c (Qcompiled_function, Qframe, Qvector):
133 * image.c (QimageMagick, Qsvg):
134 * minibuf.c (Qmetadata):
135 * window.c (resize_window_check, resize_root_window): Now static.
136 * window.h (resize_window_check, resize_root_window): Remove decls.
137
109e28d0
PE
138 * window.c (window_deletion_count, delete_deletable_window):
139 Remove; unused.
46a4ce9e
PE
140 (window_body_lines): Now static.
141 (Fdelete_other_windows_internal): Mark vars as initialized.
142 Make sure 'resize_failed' is initialized.
143 (run_window_configuration_change_hook): Rename local to avoid shadowing.
144 (resize_window_apply): Remove unused local.
145 * window.h (delete_deletable_window): Remove decl.
146
109e28d0 147 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
148 (imagemagick_load_image): Fix pointer signedness problem by changing
149 last arg from unsigned char * to char *. All uses changed.
150 Also, fix a local for similar reasons.
151 Remove unused locals. Remove locals to avoid shadowing.
152 (fn_rsvg_handle_free): Remove; unused.
153 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 154 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 155
3f754b86
PE
156 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
157
2547adb1
CY
1582011-06-10 Chong Yidong <cyd@stupidchicken.com>
159
160 * image.c (gif_load): Fix omitted cast error introduced by
161 2011-06-06 change.
162
2c8e37d4
MR
1632011-06-10 Martin Rudalics <rudalics@gmx.at>
164
165 * window.h (resize_proportionally, orig_total_lines)
166 (orig_top_line): Remove from window structure.
167 (set_window_height, set_window_width, change_window_heights)
168 (Fdelete_window): Remove prototypes.
169 (resize_frame_windows): Remove duplicate declaration.
170
440a42e3
EZ
1712011-06-10 Eli Zaretskii <eliz@gnu.org>
172
173 * window.h (resize_frame_windows, resize_window_check)
174 (delete_deletable_window, resize_root_window)
175 (resize_frame_windows): Declare prototypes.
176
177 * window.c (resize_window_apply): Make definition be "static" to
178 match the prototype.
179
562dd5e9
MR
1802011-06-10 Martin Rudalics <rudalics@gmx.at>
181
182 * window.c: Remove declarations of Qwindow_size_fixed,
183 window_min_size_1, window_min_size_2, window_min_size,
184 size_window, window_fixed_size_p, enlarge_window, delete_window.
185 Remove static from declaration of Qdelete_window, it's
186 temporarily needed by Fbury_buffer.
187 (replace_window): Don't assign orig_top_line and
188 orig_total_lines.
189 (Fdelete_window, delete_window): Remove. Window deletion is
190 handled by window.el.
191 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
192 Fdelete_window calls with calls to Qdelete_window.
193 (Fdelete_other_windows): Remove. Deleting other windows is
194 handled by window.el.
195 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
196 handled in window.el.
197 (window_min_size_2, window_min_size_1, window_min_size): Remove.
198 Window minimum sizes are handled in window.el.
199 (shrink_windows, size_window, set_window_height)
200 (set_window_width, change_window_heights, window_height)
201 (window_width, CURBEG, CURSIZE, enlarge_window)
202 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
203 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
204 handled in window.el.
205 (make_dummy_parent): Rename to make_parent_window and give it a
206 second argument horflag.
207 (make_window): Don't set resize_proportionally any more.
208 (Fsplit_window): Remove. Windows are split in window.el.
209 (save_restore_action, save_restore_orig_size)
210 (shrink_window_lowest_first, save_restore_orig_size): Remove.
211 Resize mini windows in window.el.
212 (grow_mini_window, shrink_mini_window): Implement by calling
213 Qresize_root_window_vertically, resize_window_check and
214 resize_window_apply.
215 (saved_window, Fset_window_configuration, save_window_save): Do
216 not handle orig_top_line, orig_total_lines, and
217 resize_proportionally.
218 (window_min_height, window_min_width): Move to window.el.
219 (keys_of_window): Move bindings for delete-other-windows,
220 split-window, delete-window and enlarge-window to window.el.
221
222 * buffer.c: Temporarily extern Qdelete_window.
223 (Fbury_buffer): Temporarily call Qdelete_window instead of
224 Fdelete_window (Fbury_buffer will move to window.el soon).
225
226 * frame.c (set_menu_bar_lines_1): Remove code handling
227 orig_top_line and orig_total_lines.
228
229 * dispnew.c (adjust_frame_glyphs_initially): Don't use
230 set_window_height but set heights directly.
231 (change_frame_size_1): Use resize_frame_windows.
232
233 * xdisp.c (init_xdisp): Don't use set_window_height but set
234 heights directly.
235
236 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
237 resize_frame_windows instead of change_window_heights and run
238 run_window_configuration_change_hook.
239
240 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
241 instead of change_window_heights and run
242 run_window_configuration_change_hook.
243
1a13852e
MR
2442011-06-09 Martin Rudalics <rudalics@gmx.at>
245
246 * window.c (replace_window): Rename second argument REPLACEMENT to
247 NEW. New third argument SETFLAG. Rewrite.
248 (delete_window, make_dummy_parent): Call replace_window with
249 third argument 1.
250 (window_list_1): Move down in code.
251 (run_window_configuration_change_hook): Move set_buffer part
252 before select_frame_norecord part in order to unwind correctly.
253 Rename count1 to count.
254 (recombine_windows, delete_deletable_window, resize_root_window)
255 (Fdelete_other_windows_internal)
256 (Frun_window_configuration_change_hook, make_parent_window)
257 (resize_window_check, resize_window_apply, Fresize_window_apply)
258 (resize_frame_windows, Fsplit_window_internal)
259 (Fdelete_window_internal, Fresize_mini_window_internal): New
260 functions.
261 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
262
f3d1777e
MR
2632011-06-08 Martin Rudalics <rudalics@gmx.at>
264
496e208e
MR
265 * window.h (window): Add some new members to window structure -
266 normal_lines, normal_cols, new_total, new_normal, clone_number,
267 splits, nest, prev_buffers, next_buffers.
268 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 269 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 270
f3d1777e
MR
271 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
272 Remove.
496e208e
MR
273 (make_dummy_parent): Set new members of windows structure.
274 (make_window): Move down in code. Handle new members of window
275 structure.
276 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
277 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
278 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
279 (Fset_window_prev_buffers, Fwindow_next_buffers)
280 (Fset_window_next_buffers, Fset_window_clone_number): New
281 functions.
282 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
283 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
284 Doc-string fixes.
285 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
286 Argument WINDOW can be now internal window too.
287 (Fwindow_use_time): Move up in code.
288 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
289 Rewrite doc-string.
290 (Fset_window_configuration, saved_window)
291 (Fcurrent_window_configuration, save_window_save): Handle new
292 members of window structure.
b9e809c2
MR
293 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
294 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
295 (syms_of_window): New Lisp objects Qrecord_window_buffer,
296 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
297 Qget_mru_window, Qresize_root_window,
298 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
299 Qauto_buffer_name; staticpro them.
f3d1777e 300
abde8f8c
MR
3012011-06-07 Martin Rudalics <rudalics@gmx.at>
302
303 * window.c (Fwindow_total_size, Fwindow_left_column)
304 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
305 (Fwindow_list_1): New functions.
306 (window_box_text_cols): Replace with window_body_cols.
307 (Fwindow_width, Fscroll_left, Fscroll_right): Use
308 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
309 (delete_window, Fset_window_configuration): Call
310 delete_all_subwindows with window as argument.
311 (delete_all_subwindows): Take a window as argument and not a
312 structure. Rewrite.
190b47e6
MR
313 (window_loop): Remove handling of GET_LRU_WINDOW and
314 GET_LARGEST_WINDOW.
315 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
316
317 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
318 window_box_text_cols. delete_all_subwindows now takes a
319 Lisp_Object as argument.
abde8f8c
MR
320
321 * indent.c (compute_motion, Fcompute_motion): Use
322 window_body_cols instead of window_box_text_cols.
323
fa8a67e6
MR
324 * frame.c (delete_frame): Call delete_all_subwindows with root
325 window as argument.
326
a54e3482
DC
3272011-06-07 Daniel Colascione <dan.colascione@gmail.com>
328
329 * fns.c (Fputhash): Document return value.
330
60002bf5
CY
3312011-06-06 Chong Yidong <cyd@stupidchicken.com>
332
333 * image.c (gif_load): Implement gif89a spec "no disposal" method.
334
0c671da6 3352011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 336
b862a52a 337 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 338
be44ca6c
PE
339 Check for overflow when converting integer to cons and back.
340 * charset.c (Fdefine_charset_internal, Fdecode_char):
341 Use cons_to_unsigned to catch overflow.
342 (Fencode_char): Use INTEGER_TO_CONS.
343 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
344 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
345 * data.c (long_to_cons, cons_to_long): Remove.
346 (cons_to_unsigned, cons_to_signed): New functions.
347 These signal an error for invalid or out-of-range values.
348 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
349 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
350 * font.c (Ffont_variation_glyphs):
351 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
352 * lisp.h: Include <intprops.h>.
353 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
354 (cons_to_signed, cons_to_unsigned): New decls.
355 (long_to_cons, cons_to_long): Remove decls.
356 * undo.c (record_first_change): Use INTEGER_TO_CONS.
357 (Fprimitive_undo): Use CONS_TO_INTEGER.
358 * xfns.c (Fx_window_property): Likewise.
359 * xselect.c: Include <limits.h>.
360 (x_own_selection, selection_data_to_lisp_data):
361 Use INTEGER_TO_CONS.
362 (x_handle_selection_request, x_handle_selection_clear)
363 (x_get_foreign_selection, Fx_disown_selection_internal)
364 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
365 (lisp_data_to_selection_data): Use cons_to_unsigned.
366 (x_fill_property_data): Use cons_to_signed.
367 Report values out of range.
368
d1f3d2af
PE
369 Check for buffer and string overflow more precisely.
370 * buffer.h (BUF_BYTES_MAX): New macro.
371 * lisp.h (STRING_BYTES_MAX): New macro.
372 * alloc.c (Fmake_string):
373 * character.c (string_escape_byte8):
374 * coding.c (coding_alloc_by_realloc):
375 * doprnt.c (doprnt):
376 * editfns.c (Fformat):
377 * eval.c (verror):
378 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
379 since they may not be the same number.
380 * editfns.c (Finsert_char):
381 * fileio.c (Finsert_file_contents):
382 Likewise for BUF_BYTES_MAX.
383
dd52fcea
PE
384 * image.c: Use ptrdiff_t, not int, for sizes.
385 (slurp_file): Switch from int to ptrdiff_t.
386 All uses changed.
387 (slurp_file): Check that file size fits in both size_t (for
388 malloc) and ptrdiff_t (for sanity and safety).
389
7f9bbdbb
PE
390 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
391 if b->modtime has its maximal value.
392
dfe18f82
PE
393 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
394
84acfcf0
PE
395 Don't assume time_t can fit into int.
396 * buffer.h (struct buffer.modtime): Now time_t, not int.
397 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
398 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
399
ccd9a01a
PE
400 Minor fixes for signed vs unsigned integers.
401 * character.h (MAYBE_UNIFY_CHAR):
402 * charset.c (maybe_unify_char):
403 * keyboard.c (read_char, reorder_modifiers):
404 XINT -> XFASTINT, since the integer must be nonnegative.
405 * ftfont.c (ftfont_spec_pattern):
406 * keymap.c (access_keymap, silly_event_symbol_error):
407 XUINT -> XFASTINT, since the integer must be nonnegative.
408 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
409 since it makes no difference and we prefer signed.
410 * keyboard.c (record_char): Use XUINT when all the neighbors do.
411 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
412 nonnegative.
413
d6d100dd
SM
4142011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
415
416 * window.h (Fwindow_frame): Declare.
417
2b6148e4
PE
4182011-06-06 Paul Eggert <eggert@cs.ucla.edu>
419
420 * alloc.c: Simplify handling of large-request failures (Bug#8800).
421 (SPARE_MEMORY): Always define.
422 (LARGE_REQUEST): Remove.
423 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
424
f230ecc9
MR
4252011-06-06 Martin Rudalics <rudalics@gmx.at>
426
727e958e
MR
427 * lisp.h: Move EXFUNS for Fframe_root_window,
428 Fframe_first_window and Fset_frame_selected_window to window.h.
429
430 * window.h: Move EXFUNS for Fframe_root_window,
431 Fframe_first_window and Fset_frame_selected_window here from
432 lisp.h.
433
434 * frame.c (Fwindow_frame, Fframe_first_window)
435 (Fframe_root_window, Fframe_selected_window)
436 (Fset_frame_selected_window): Move to window.c.
437 (Factive_minibuffer_window): Move to minibuf.c.
438 (Fother_visible_frames_p): New function.
439
440 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
441
f230ecc9
MR
442 * window.c (decode_window, decode_any_window): Move up in code.
443 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
444 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
445 (Fwindow_buffer): Move up and rewrite doc-string.
446 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
447 (Fwindow_prev): New functions.
727e958e
MR
448 (Fwindow_frame): Move here from frame.c. Accept any window as
449 argument.
450 (Fframe_root_window, Fframe_first_window)
451 (Fframe_selected_window): Move here from frame.c. Accept frame
452 or arbitrary window as argument. Update doc-strings.
453 (Fminibuffer_window): Move up in code.
454 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
455 (Fset_frame_selected_window): Move here from frame.c.
456 Marginal rewrite.
727e958e
MR
457 (Fselected_window, select_window, Fselect_window): Move up in
458 code. Minor doc-string fixes.
f230ecc9 459
4d09bcf6
PE
4602011-06-06 Paul Eggert <eggert@cs.ucla.edu>
461
462 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
463 Do not assume that spare memory exists; that assumption is valid
464 only if SYSTEM_MALLOC.
465 (LARGE_REQUEST): New macro, so that the issue of large requests
466 is separated from the issue of spare memory.
467
810928a2
AS
4682011-06-05 Andreas Schwab <schwab@linux-m68k.org>
469
172418ad
AS
470 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
471 format. (Bug#8806)
472
43f862f7
AS
473 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
474
810928a2
AS
475 * xfns.c (x_set_scroll_bar_default_width): Move declarations
476 before statements.
477
a059fe24
JD
4782011-06-05 Jan Djärv <jan.h.d@swipnet.se>
479
480 * gtkutil.c (xg_get_default_scrollbar_width): New function.
481
482 * gtkutil.h: Declare xg_get_default_scrollbar_width.
483
484 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
485 min width by calling x_set_scroll_bar_default_width (Bug#8505).
486
989bf368
JB
4872011-06-05 Juanma Barranquero <lekktu@gmail.com>
488
489 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
490
4b80f674
CY
4912011-06-04 Chong Yidong <cyd@stupidchicken.com>
492
493 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
494 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
495 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
496 New error handlers.
4b80f674
CY
497 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
498 Obey Vx_select_enable_clipboard_manager. Catch errors in
499 x_clipboard_manager_save (Bug#8779).
500 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 501 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 502
99a33b77 5032011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
504
505 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
506
99a33b77 5072011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
508
509 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
510 in the current matrix if keep_current_p is non-zero.
511
8264569d
EZ
5122011-06-04 Eli Zaretskii <eliz@gnu.org>
513
514 * bidi.c (bidi_level_of_next_char): Fix last change.
515
57f97249
EZ
5162011-06-03 Eli Zaretskii <eliz@gnu.org>
517
fec2107c 518 Support bidi reordering of text covered by display properties.
57f97249 519
fec2107c
EZ
520 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
521 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
522 (bidi_cache_search, bidi_cache_iterator_state)
523 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
524 (bidi_level_of_next_char, bidi_move_to_visually_next):
525 Support character positions inside a run of characters covered by a
fec2107c
EZ
526 display string.
527 (bidi_paragraph_init, bidi_resolve_explicit_1)
528 (bidi_level_of_next_char): Call bidi_fetch_char and
529 bidi_fetch_char_advance instead of FETCH_CHAR and
530 FETCH_CHAR_ADVANCE.
531 (bidi_init_it): Initialize new members.
532 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
533 definitions.
534 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
535 instead of using explicit *_CHAR codes.
d6d100dd
SM
536 (bidi_resolve_explicit, bidi_resolve_weak):
537 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
538 bidirectional text is supported only in multibyte buffers.
539 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
540 it to initialize the frame_window_p member of struct bidi_it.
541 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
542 (bidi_resolve_explicit, bidi_resolve_weak)
543 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
544 bidi_it->nchars is non-positive.
545 (bidi_level_of_next_char): Don't try to lookup the cache for the
546 next/previous character if nothing is cached there yet, or if we
547 were just reseat()'ed to a new position.
c40e2fb2 548
0e14fe90
EZ
549 * xdisp.c (set_cursor_from_row): Set start and stop points
550 according to the row's direction when priming the loop that looks
551 for the glyph on which to display cursor.
552 (single_display_spec_intangible_p): Function deleted.
553 (display_prop_intangible_p): Reimplement to call
554 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
555 Accept 3 additional arguments needed by handle_display_spec.
556 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
557 values: lists, `(when COND...)' forms, etc.
558 (single_display_spec_string_p): Support property values that are
559 lists with the argument STRING its top-level element.
560 (display_prop_string_p): Fix the condition for processing a
561 property that is a list to be consistent with handle_display_spec.
fec2107c 562 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
563 last portion of handle_display_prop.
564 (compute_display_string_pos): Accept additional argument
565 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
566 value of a `display' property is a "replacing spec".
567 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
568 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
569 the display property, but just return a value indicating whether
570 the display property will replace the characters it covers.
571 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
572 frame_window_p members of struct bidi_it.
d6d100dd
SM
573 (compute_display_string_pos, compute_display_string_end):
574 New functions.
fec2107c
EZ
575 (push_it): Accept second argument POSITION, where pop_it should
576 jump to continue iteration.
577 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 578
fec2107c
EZ
579 * keyboard.c (adjust_point_for_property): Adjust the call to
580 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
581
582 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
583 (bidi_init_it): Update prototypes.
584 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
585 (compute_display_string_pos, compute_display_string_end):
586 Declare prototypes.
fec2107c
EZ
587 (struct bidi_it): New members nchars and disp_pos. ch_len is now
588 EMACS_INT.
fc6f18ce 589
40087514 5902011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 591
57f53182
PE
592 Malloc failure behavior now depends on size of allocation.
593 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
594 * lisp.h: Change signatures accordingly.
595 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
596 All callers changed. (Bug#8762)
597
598 * gnutls.c: Use Emacs's memory allocators.
599 Without this change, the gnutls library would invoke malloc etc.
600 directly, which causes problems on non-SYNC_INPUT hosts, and which
601 runs afoul of improving memory_full behavior. (Bug#8761)
602 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
603 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
604 xfree instead of the default malloc, realloc, free.
605 (Fgnutls_boot): No need to check for memory allocation failure,
606 since xmalloc does that for us.
607
ac32cd99 608 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
609 * category.c (hash_get_category_set):
610 * ccl.c (ccl_driver):
611 * charset.c (Fdefine_charset_internal):
612 * charset.h (struct charset.hash_index):
613 * composite.c (get_composition_id, gstring_lookup_cache)
614 (composition_gstring_put_cache):
615 * composite.h (struct composition.hash_index):
616 * dispextern.h (struct image.hash):
617 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
618 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
619 (hashfn_equal, hashfn_user_defined, make_hash_table)
620 (maybe_resize_hash_table, hash_lookup, hash_put)
621 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
622 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
623 (Fsxhash, Fgethash, Fputhash, Fmaphash):
624 * image.c (make_image, search_image_cache, lookup_image)
625 (xpm_put_color_table_h):
626 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 627 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
628 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
629 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
630 * alloc.c (allocate_vectorlike):
631 Check for overflow in vector size calculations.
632 * ccl.c (ccl_driver):
633 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
634 * fns.c, image.c: Remove unnecessary static decls that would otherwise
635 need to be updated by these changes.
40087514
PE
636 * fns.c (make_hash_table, maybe_resize_hash_table):
637 Check for integer overflow with large hash tables.
0de4bb68
PE
638 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
639 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
640 (SXHASH_REDUCE): New macro.
641 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
642 Use it instead of discarding useful hash info with large hash values.
643 (sxhash_float): New function.
644 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
645 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
646 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
647 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
648 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
649 Adjust signatures to match updated version of code.
650 (consing_since_gc): Now EMACS_INT, since a single hash table can
651 use more than INT_MAX bytes.
652
698d32e2
DN
6532011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
654
655 Make it possible to build with GCC-4.6+ -O2 -flto.
656
657 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
658
fd6fa53f
SM
6592011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
660
661 * minibuf.c (get_minibuffer, read_minibuf_unwind):
662 Call minibuffer-inactive-mode.
663
864db017
JB
6642011-05-31 Juanma Barranquero <lekktu@gmail.com>
665
666 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
667 Update dependencies.
668
2ad0baf4
DN
6692011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
670
671 * data.c (init_data): Remove code for UTS, this system is not
672 supported anymore.
673
4fcc2638
DN
6742011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
675
676 Don't force ./temacs to start in terminal mode.
677
678 * frame.c (make_initial_frame): Initialize faces in all cases, not
679 only when CANNOT_DUMP is defined.
680 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
681
c56e0fd5
DN
6822011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
683
684 * dispnew.c (add_window_display_history): Use const for the string
685 pointer. Remove declaration, not needed.
686
333d54da 6872011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 688
55d4c1b2 689 Use 'inline', not 'INLINE'.
333d54da 690 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
691 * alloc.c, fontset.c (INLINE): Remove.
692 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
693 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
694 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
695 * gmalloc.c (register_heapinfo): Use inline unconditionally.
696 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
697
738db178
DN
6982011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
699
700 Make it possible to run ./temacs.
701
702 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
703 syms_of_callproc does the same thing. Remove test for
704 "initialized", do it in the caller.
705 * emacs.c (main): Avoid calling set_initial_environment when dumping.
706
620c53a6
SM
7072011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
708
709 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
710 (read_minibuf): Use get_minibuffer.
711 (syms_of_minibuf): Use DEFSYM.
712 (Qmetadata): New var.
713 * data.c (Qbuffer): Don't make it static.
714 (syms_of_data): Use DEFSYM.
715
e003a292
PE
7162011-05-31 Paul Eggert <eggert@cs.ucla.edu>
717
718 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
719 (CCL_CODE_MIN): New macro.
720
ed008a6d
PE
7212011-05-30 Paul Eggert <eggert@cs.ucla.edu>
722
3687c2ef
PE
723 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
724
ed008a6d
PE
725 * eval.c (Qdebug): Now static.
726 * lisp.h (Qdebug): Remove decl. This reverts a part of the
727 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
728 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
729
d66c4c7c
CY
7302011-05-29 Chong Yidong <cyd@stupidchicken.com>
731
732 * image.c: Various fixes to ImageMagick code comments.
733 (Fimagemagick_types): Doc fix.
734
5fbc2025
PE
7352011-05-29 Paul Eggert <eggert@cs.ucla.edu>
736
0196f88a
PE
737 Minor fixes prompted by GCC 4.6.0 warnings.
738
739 * xselect.c (converted_selections, conversion_fail_tag): Now static.
740
5fbc2025
PE
741 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
742 (x_clipboard_manager_save_all): Move extern decl to ...
743 * xterm.h: ... here, so that it can be checked for consistency.
744
1dd3c2d9
CY
7452011-05-29 Chong Yidong <cyd@stupidchicken.com>
746
747 * xselect.c (x_clipboard_manager_save_frame)
748 (x_clipboard_manager_save_all): New functions.
749 (Fx_clipboard_manager_save): Lisp function deleted.
750
751 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
752 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
753
754 * xterm.h: Update prototype.
755
5ba6571d
WX
7562011-05-28 William Xu <william.xwl@gmail.com>
757
758 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
759 exiting (Bug#8239).
760
3eaff834
JM
7612011-05-28 Jim Meyering <meyering@redhat.com>
762
e1900994 763 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
764 * fns.c (to_uchar): Define.
765 (crypto_hash_function): Use it to convert some newly-signed
766 variables to unsigned, to avoid sign-extension bugs. For example,
767 without this change, (md5 "truc") would evaluate to
768 45723a2aff78ff4fff7fff1114760e62 rather than the expected
769 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 770 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 771
0f6990a7
PE
7722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
773
774 Integer overflow fixes.
c8a9ca5a 775
08686060
PE
776 * dbusbind.c: Serial number integer overflow fixes.
777 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
778 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
779 to hold a serial number that is too large for a fixnum.
780 (Fdbus_method_return_internal, Fdbus_method_error_internal):
781 Check for serial numbers out of range. Decode any serial number
59568bf0 782 that was so large that it became a float. (Bug#8722)
08686060 783
2d1fc3c7
PE
784 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
785 (Fdbus_call_method, Fdbus_call_method_asynchronously):
786 Use XFASTINT rather than XUINT when numbers are nonnegative.
787 (xd_append_arg, Fdbus_method_return_internal):
788 (Fdbus_method_error_internal): Likewise. Also, for unsigned
789 arguments, check that Lisp number is nonnegative, rather than
59568bf0 790 silently wrapping negative numbers around. (Bug#8722)
30217ff0 791 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 792 (Bug#8722)
2d1fc3c7 793
c8a9ca5a
PE
794 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
795
519e1d69
PE
796 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
797
30569699
PE
798 ccl: add integer overflow checks
799 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
800 (IN_INT_RANGE): New macros.
801 (ccl_driver): Use them to check for integer overflow when
802 decoding a CCL program. Many of the new checks are whether XINT (x)
803 fits in int; it doesn't always, on 64-bit hosts. The new version
804 doesn't catch all possible integer overflows, but it's an
847044ea 805 improvement. (Bug#8719)
30569699 806
c11285dc
PE
807 * alloc.c (make_event_array): Use XINT, not XUINT.
808 There's no need for unsigned here.
809
fdccd48e
PE
810 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
811 This follows up to the 2011-05-06 change that substituted uintptr_t
812 for EMACS_INT. This case wasn't caught back then.
813
37910ab2
PE
814 Rework Fformat to avoid integer overflow issues.
815 * editfns.c: Include <float.h> unconditionally, as it's everywhere
816 now (part of C89). Include <verify.h>.
817 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
818 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
819 (Fformat): Avoid the prepass trying to compute sizes; it was only
820 approximate and thus did not catch overflow reliably. Instead, walk
821 through the format just once, formatting and computing sizes as we go,
822 checking for integer overflow at every step, and allocating a larger
823 buffer as needed. Keep track separately whether the format is
824 multibyte. Keep only the most-recently calculated precision, rather
825 than them all. Record whether each argument has been converted to
826 string. Use EMACS_INT, not int, for byte and char and arg counts.
827 Support field widths and precisions larger than INT_MAX. Avoid
828 sprintf's undefined behavior with conversion specifications such as %#d
829 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
830 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
831 formatting out-of-range floating point numbers with int
832 formats. (Bug#8668)
833
2e6578fb
PE
834 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
835
0ae6bdee
PE
836 * data.c: Avoid integer truncation in expressions involving floats.
837 * data.c: Include <intprops.h>.
838 (arith_driver): When there's an integer overflow in an expression
839 involving floating point, convert the integers to floating point
840 so that the resulting value does not suffer from catastrophic
841 integer truncation. For example, on a 64-bit host (* 4
842 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
843 Do not rely on undefined behavior after integer overflow.
844
de883a70
PE
845 merge count_size_as_multibyte, parse_str_to_multibyte
846 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 847 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
848 Check for integer overflow.
849 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
850 since it's now a duplicate of the other. This is more of
851 a character than a buffer op, so better that it's in character.c.
852 * fns.c, print.c: Adjust to above changes.
853
2ff916cb
PE
8542011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
855
856 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
857
f1b54466
PE
8582011-05-27 Paul Eggert <eggert@cs.ucla.edu>
859
fb1ac845
PE
860 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
861 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
862 (x_clipboard_manager_save): Now static.
863 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
864
f1b54466
PE
865 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
866 (crypto_hash_function): Now static.
867 Fix pointer signedness problems. Avoid unnecessary initializations.
868
a9f737ee
CY
8692011-05-27 Chong Yidong <cyd@stupidchicken.com>
870
871 * termhooks.h (Vselection_alist): Make it terminal-local.
872
873 * terminal.c (create_terminal): Initialize it.
874
875 * xselect.c: Support for clipboard managers.
876 (Vselection_alist): Move to termhooks.h as terminal-local var.
877 (LOCAL_SELECTION): New macro.
878 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
879 (symbol_to_x_atom): Remove gratuitous arg.
880 (x_handle_selection_request, lisp_data_to_selection_data)
881 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
882 (x_own_selection, x_get_local_selection, x_convert_selection):
883 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
884 (some_frame_on_display): Delete unused function.
885 (Fx_own_selection_internal, Fx_get_selection_internal)
886 (Fx_disown_selection_internal, Fx_selection_owner_p)
887 (Fx_selection_exists_p): New optional frame arg.
888 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
889 (x_handle_selection_clear): Don't treat other terminals with the
890 same keyboard specially. Use the terminal-local Vselection_alist.
891 (x_clear_frame_selections): Use Frun_hook_with_args.
892
893 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
894
895 * xterm.h: Add support for those atoms.
896
e067f0c1
CY
8972011-05-26 Chong Yidong <cyd@stupidchicken.com>
898
899 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
900 (converted_selections, conversion_fail_tag): New global variables.
901 (x_selection_request_lisp_error): Free the above.
902 (x_get_local_selection): Remove unnecessary code.
903 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
904 of converted selections stored in converted_selections.
905 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
906 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
907 (x_convert_selection): New function.
908 (x_handle_selection_event): Simplify.
909 (x_get_foreign_selection): Don't ignore incoming requests while
910 waiting for an answer; this will fail when we implement
911 SAVE_TARGETS, and seems unnecessary anyway.
912 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
913 (Vx_sent_selection_functions): Doc fix.
914
0f4aebc0
LL
9152011-05-26 Leo Liu <sdl.web@gmail.com>
916
917 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
918
e61124cd
YM
9192011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
920
921 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
922
923 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
924 for fringe update if it has periodic bitmap.
925 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
926 and fringe_bitmap_periodic_p.
927
928 * fringe.c (get_fringe_bitmap_data): New function.
929 (draw_fringe_bitmap_1, update_window_fringes): Use it.
930 (update_window_fringes): Record periodicity of fringe bitmap in glyph
931 row. Mark glyph row for fringe update if periodicity changed.
932
933 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
934 for fringe update unless it has periodic bitmap.
935
f16d9837
KH
9362011-05-25 Kenichi Handa <handa@m17n.org>
937
938 * xdisp.c (get_next_display_element): Set correct it->face_id for
939 a static composition.
940
e1b90ef6
LL
9412011-05-24 Leo Liu <sdl.web@gmail.com>
942
943 * deps.mk (fns.o):
944 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
945
946 * fns.c (crypto_hash_function, Fsha1): New function.
947 (Fmd5): Use crypto_hash_function.
948 (syms_of_fns): Add Ssha1.
949
7400048f
PE
9502011-05-22 Paul Eggert <eggert@cs.ucla.edu>
951
952 * gnutls.c: Remove unused macros.
953 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
954 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
955 Remove macros that are defined and never used.
956 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
957
abb71cf4
CY
9582011-05-22 Chong Yidong <cyd@stupidchicken.com>
959
960 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
961 (Fx_get_selection_internal): Minor cleanup.
962 (Fx_own_selection_internal): Rename arguments for consistency with
963 select.el.
964
6307db39
PE
9652011-05-22 Paul Eggert <eggert@cs.ucla.edu>
966
967 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
968
f3d4e0a4
CY
9692011-05-22 Chong Yidong <cyd@stupidchicken.com>
970
971 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
972
4d8ade89
YM
9732011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
974
975 * dispnew.c (scrolling_window): Don't exclude the case that the
976 last enabled row in the desired matrix touches the bottom boundary.
977
32078c8d
GM
9782011-05-21 Glenn Morris <rgm@gnu.org>
979
980 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
981 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
982 and add some more files.
32078c8d 983
7285dc67
EZ
9842011-05-20 Eli Zaretskii <eliz@gnu.org>
985
986 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
987 report_file_error introduced by the change from 2011-05-07.
988
89d1bd22
PE
9892011-05-20 Paul Eggert <eggert@cs.ucla.edu>
990
991 * systime.h (Time): Define only if emacs is defined.
992 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
993 where the include path doesn't have X11/X.h by default. See
994 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
995
e23640bb 9962011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
997
998 * composite.c (find_automatic_composition): Fix previous change.
999
b9704ad9
GM
10002011-05-20 Glenn Morris <rgm@gnu.org>
1001
1002 * lisp.mk: New file, split from Makefile.in.
1003 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
1004 (shortlisp): Remove.
1005 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
1006
4a720484
GM
10072011-05-19 Glenn Morris <rgm@gnu.org>
1008
1009 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
1010 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
1011 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
1012 (lisp): Set the order to that of loadup.el.
1013 (shortlisp): Make it a copy of $lisp.
1014 (SOME_MACHINE_LISP): Remove.
1015 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
1016 Use just $shortlisp, not $SOME_MACHINE_LISP too.
1017
a28d4396
KH
10182011-05-18 Kenichi Handa <handa@m17n.org>
1019
1020 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
1021 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
1022 (find_automatic_composition): Mostly rewrite for efficiency.
1023
a2b1fa8e
JB
10242011-05-18 Juanma Barranquero <lekktu@gmail.com>
1025
1026 * makefile.w32-in: Update dependencies.
1027
8e1f5610
CS
10282011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
1029
1030 * menu.c: Include limits.h (fixes the MS-Windows build broken by
1031 revision 104625).
1032
7025ee00 10332011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 1034
cdfa6eab
PE
1035 Fix some integer overflow issues, such as string length overflow.
1036
06d6db33
PE
1037 * insdel.c (count_size_as_multibyte): Check for string overflow.
1038
2b4560a8
PE
1039 * character.c (lisp_string_width): Check for string overflow.
1040 Use EMACS_INT, not int, for string indexes and lengths; in
1041 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
1042 the resulting string length overflows an EMACS_INT; instead,
1043 report a string overflow if no precision given. When checking for
1044 precision exhaustion, use a check that cannot possibly have
1045 integer overflow. (Bug#8675)
1046 * character.h (lisp_string_width): Adjust to new signature.
1047
cb93f9be
PE
1048 * alloc.c (string_overflow): New function.
1049 (Fmake_string): Use it. This doesn't change behavior, but saves
1050 a few bytes and will simplify future changes.
1051 * character.c (string_escape_byte8): Likewise.
1052 * lisp.h (string_overflow): New decl.
1053
1a1f3366
PE
1054 Fixups, following up to the user-interface timestamp change.
1055 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
1056 for UI timestamps, instead of unsigned long.
9fbd6841
PE
1057 * msdos.c (mouse_get_pos): Likewise.
1058 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
1059 * w32gui.h (Time): Define by including "systime.h" rather than by
1060 declaring it ourselves. (Bug#8664)
1061
d4e3e4d3
PE
1062 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
1063 * image.c (clear_image_cache): Likewise.
1064
f6a24d19
PE
1065 * term.c (term_mouse_position): Don't assume time_t wraparound.
1066
08dc5ae6
PE
1067 Be more systematic about user-interface timestamps.
1068 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
1069 and sometimes 'EMACS_UINT', to represent these timestamps.
1070 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
1071 This makes the code easier to follow, and makes it easier to catch
1072 integer overflow bugs such as Bug#8664.
1073 * frame.c (Fmouse_position, Fmouse_pixel_position):
1074 Use Time, not unsigned long, for user-interface timestamps.
1075 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
1076 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
1077 * keyboard.h (last_event_timestamp): Likewise.
1078 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
1079 * menu.h (xmenu_show): Likewise.
1080 * term.c (term_mouse_position): Likewise.
1081 * termhooks.h (struct input_event.timestamp): Likewise.
1082 (struct terminal.mouse_position_hook): Likewise.
1083 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
1084 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
1085 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
1086 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
1087 what it was before.
1088 * menu.h, termhooks.h: Include "systime.h", for Time.
1089
8e55734a
PE
1090 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
1091 Don't assume that the difference between two unsigned long values
1092 can fit into an integer. At this point, we know button_down_time
1093 <= event->timestamp, so the difference must be nonnegative, so
1094 there's no need to cast the result if double-click-time is
1095 nonnegative, as it should be; check that it's nonnegative, just in
1096 case. This bug is triggered when events are more than 2**31 ms
86db42d2 1097 apart (about 25 days). (Bug#8664)
8e55734a 1098
841f1b75 1099 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 1100 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 1101
3e26f69c
PE
1102 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
1103 that always fit in int. Use a sentinel instead of a counter, to
1104 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
1105 * frame.h (struct frame): Use int for menu_bar_items_used
1106 instead of EMACS_INT, since it always fits in int.
3e26f69c 1107
5cc152c0
PE
1108 * menu.c (grow_menu_items): Check for int overflow.
1109
d89eb65e
PE
1110 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
1111
5235bd3e
PE
1112 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
1113 Before, the code was not consistent. These values cannot exceed
1114 2**31 - 1 so there's no need to make them unsigned.
1115 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
1116 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
1117 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
1118 as modifiers.
1119 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
1120
bc827e23
PE
1121 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
1122 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
1123 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
1124 presumably because the widths might not match.
1125
78eb494e
PE
1126 * window.c (size_window): Avoid needless test at loop start.
1127
04f2d78b
CB
11282011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
1129
1130 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
1131
d2fc7e3d 11322011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
1133
1134 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
1135
d2fc7e3d 11362011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
1137
1138 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
1139 `width' to `bar_area_x' and `bar_area_width', respectively.
1140 (x_scroll_run): Take account of fringe background extension.
1141
04f2d78b
CB
1142 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
1143 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
1144 `bar_area_width', respectively.
1145 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
1146 background extension.
1147
79b70037
GM
11482011-05-10 Jim Meyering <meyering@redhat.com>
1149
1150 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
1151
2f142cc5
JB
11522011-05-10 Juanma Barranquero <lekktu@gmail.com>
1153
1154 * image.c (Finit_image_library): Return t for built-in image types,
1155 like pbm and xbm. (Bug#8640)
1156
57679c86
AS
11572011-05-09 Andreas Schwab <schwab@linux-m68k.org>
1158
1159 * w32menu.c (set_frame_menubar): Fix submenu allocation.
1160
888c9e86
EZ
11612011-05-07 Eli Zaretskii <eliz@gnu.org>
1162
b0512a1d
EZ
1163 * w32console.c (Fset_screen_color): Doc fix.
1164 (Fget_screen_color): New function.
1165 (syms_of_ntterm): Defsubr it.
1166
7285dc67
EZ
1167 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
1168 unlink the temporary file if Fcall_process didn't create it in the
1169 first place.
1170 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
1171 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
1172 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
1173 cue to call_process_cleanup not to close that handle.
1174
4d3fcc8e
BK
11752011-05-07 Ben Key <bkey76@gmail.com>
1176
1177 * makefile.w32-in: The bootstrap-temacs rule now makes use of
1178 one of two shell specific rules, either bootstrap-temacs-CMD or
1179 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
1180 to the previous implementation of the bootstrap-temacs rule.
1181 The bootstrap-temacs-CMD rule is similar to the previous
1182 implementation of the bootstrap-temacs rule except that it
1183 makes use of the ESC_CFLAGS variable instead of the CFLAGS
1184 variable.
1185
1186 These changes, along with some changes to nt/configure.bat,
1187 nt/gmake.defs, and nt/nmake.defs, are required to extend my
1188 earlier fix to add support for --cflags and --ldflags options
1189 that include quotes so that it works whether make uses cmd or
1190 sh as the shell.
1191
b4289b64
MA
11922011-05-06 Michael Albinus <michael.albinus@gmx.de>
1193
1194 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
1195 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
1196 is a constant.
1197 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
1198 a string. Handle both cases.
1199 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
1200 (Fdbus_register_method): Use Qinvalid_function.
1201
af4c0e28
JB
12022011-05-06 Juanma Barranquero <lekktu@gmail.com>
1203
1204 * makefile.w32-in: Update dependencies.
1205 (LISP_H): Add inttypes.h and stdin.h.
1206 (PROCESS_H): Add unistd.h.
1207
c51453d9
EZ
12082011-05-06 Eli Zaretskii <eliz@gnu.org>
1209
1210 * lread.c: Include limits.h (fixes the MS-Windows build broken by
1211 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
1212
8ff0ac3c 12132011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 1214
4c4b566b
PE
1215 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
1216
aab2b9b5
PE
1217 * term.c (vfatal): Remove stray call to va_end.
1218 It's not needed and the C Standard doesn't allow it here anyway.
1219
c378da0b
PE
1220 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
1221 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
1222
288b08c7
PE
1223 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
1224 bytes.
1225
e3601888
PE
1226 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
1227
db6c0e74
PE
1228 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1229
dd5963ea
PE
1230 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
1231
88c9450f
PE
1232 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
1233
2f9442b8
PE
1234 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
1235
c032b5f8
PE
1236 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
1237 * charset.c (Fdefine_charset_internal): Don't initialize
1238 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 1239 32-bit int (Bug#8600).
a108c10b
PE
1240
1241 * lread.c (read_integer): Be more consistent with string-to-number.
1242 Use string_to_number to do the actual conversion; this avoids
1243 rounding errors and fixes some other screwups. Without this fix,
1244 for example, #x1fffffffffffffff was misread as -2305843009213693952.
1245 (digit_to_number): Move earlier, for benefit of read_integer.
1246 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 1247 not a digit in any supported base. (Bug#8602)
a108c10b 1248
ad5f9eea
PE
1249 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
1250
aec1708a
PE
1251 * dispnew.c (scrolling_window): Return 1 if we scrolled,
1252 to match comment at start of function. This also removes a
1253 GCC warning about overflow in a 32+64-bit port.
1254
47be4ab5
PE
1255 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
1256
371cac43
PE
1257 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
1258 Reported by Stefan Monnier in
1259 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
1260 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1261 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 1262
d01a7826
PE
1263 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
1264 (EMACS_UINTPTR): Likewise, with uintptr_t.
1265
7fd47d5c
PE
1266 * lisp.h: Prefer 64-bit EMACS_INT if available.
1267 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
1268 on 32-bit hosts that have 64-bit int, so that they can access
1269 large files.
122b0c86
PE
1270 However, temporarily disable this change unless the temporary
1271 symbol WIDE_EMACS_INT is defined.
7fd47d5c 1272
8727937b
PE
1273 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
1274
8ac068ac
PE
1275 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
1276 This removes an assumption that EMACS_INT and long are the same
1277 width as pointers. The assumption is true for Emacs porting targets
1278 now, but we want to make other targets possible.
1279 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
1280 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
1281 In the rest of the code, change types of integers that hold casted
1282 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
1283 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
1284 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
1285 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
1286 No need to cast type when ORing.
1287 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
1288 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
1289 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
1290 assume EMACS_INT is the same width as char *.
1291 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
1292 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
1293 Remove no-longer-needed casts.
1294 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
1295 (xg_tool_bar_help_callback, xg_make_tool_item):
1296 Use EMACS_INTPTR to hold an integer
1297 that will be cast to void *; this can avoid a GCC warning
1298 if EMACS_INT is not the same width as void *.
1299 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
1300 * xdisp.c (display_echo_area_1, resize_mini_window_1):
1301 (current_message_1, set_message_1):
1302 Use a local to convert to proper width without a cast.
1303 * xmenu.c (dialog_selection_callback): Likewise.
1304
ede49d71
PE
1305 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
1306 Also, don't assume VALBITS / RAND_BITS is less than 5,
1307 and don't rely on undefined behavior when shifting a 1 left into
1308 the sign bit.
1309 * lisp.h (get_random): Change signature to match.
1310
2f30ecd0
PE
1311 * lread.c (hash_string): Use size_t, not int, for hash computation.
1312 Normally we prefer signed values; but hashing is special, because
1313 it's better to use unsigned division on hash table sizes so that
1314 the remainder is nonnegative. Also, size_t is the natural width
1315 for hashing into memory. The previous code used 'int', which doesn't
1316 retain enough info to hash well into very large tables.
1317 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
1318
2a866e7b
PE
1319 * dbusbind.c: Don't possibly lose pointer info when converting.
1320 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
1321 Use XPNTR rather than XHASH, so that the high-order bits of
1322 the pointer aren't lost when converting through void *.
1323
51639eac
PE
1324 * eval.c (Fautoload): Don't double-shift a pointer.
1325
92394119
PE
1326 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
1327
dbdb9a7c
JB
13282011-05-06 Juanma Barranquero <lekktu@gmail.com>
1329
1330 * gnutls.c (DEF_GNUTLS_FN):
1331 * image.c (DEF_IMGLIB_FN): Make function pointers static.
1332
db7a0b4f
AS
13332011-05-05 Andreas Schwab <schwab@linux-m68k.org>
1334
1335 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
1336 marker. (Bug#8610)
1337
f7ff1b0f 13382011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
1339
1340 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
1341 New version that can reserve upto 2GB of heap space.
1342
f7ff1b0f 13432011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
1344
1345 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
1346
639c109b
TZ
13472011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
1348
1349 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
1350 `gnutls_certificate_set_x509_key_file'.
1351
d2127135
JB
13522011-05-05 Juanma Barranquero <lekktu@gmail.com>
1353
1354 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
1355 Update dependencies.
1356
e968f4f3
JB
13572011-05-04 Juanma Barranquero <lekktu@gmail.com>
1358
1359 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
1360 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
1361 Remove unused parameter `fildes'.
1362 * process.c (read_process_output, send_process): Don't pass it.
1363
84d358f0
JB
13642011-05-04 Juanma Barranquero <lekktu@gmail.com>
1365
1366 Fix previous change: the library cache is defined in w32.c.
1367 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
1368 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
1369
0898ca10
JB
13702011-05-04 Juanma Barranquero <lekktu@gmail.com>
1371
1372 Implement dynamic loading of GnuTLS on Windows.
1373
1374 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
1375 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
1376 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1377 Declare.
1378
1379 * gnutls.c (Qgnutls_dll): Define.
1380 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
1381 (gnutls_*): Declare function pointers.
1382 (init_gnutls_functions): New function to initialize function pointers.
1383 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
1384 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
1385 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
1386 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
1387 (emacs_gnutls_write, emacs_gnutls_read)
1388 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
1389 (Fgnutls_available_p): New function.
1390 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
1391 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
1392 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
1393
1394 * image.c: Include w32.h.
1395 (Vimage_type_cache): Delete.
1396 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
1397 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
1398 (w32_delayed_load): Move to w32.c.
1399
1400 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
1401
1402 * w32.c (QCloaded_from, Vlibrary_cache): Define.
1403 (w32_delayed_load): Move from image.c. When loading a library, record
1404 its filename in the :loaded-from property of the library id.
1405 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
1406 Initialize and staticpro them.
1407 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
1408
1409 * process.c: Include lisp.h before w32.h, not after.
1410 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
1411 instead of gnutls_record_check_pending.
1412
1413 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
1414
ff4de4aa
TZ
14152011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
1416
1417 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
1418 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
1419 as passed in.
1420
abe95abb
JD
14212011-05-03 Jan Djärv <jan.h.d@swipnet.se>
1422
1423 * xterm.c (x_set_frame_alpha): Do not set property on anything
1424 else than FRAME_X_OUTER_WINDOW (Bug#8608).
1425
e16e55d4
JB
14262011-05-02 Juanma Barranquero <lekktu@gmail.com>
1427
1428 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
1429
bafcf6a5
JB
14302011-05-02 Juanma Barranquero <lekktu@gmail.com>
1431
1432 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
1433 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
1434 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
1435 (gnutls_global_initialized, Qgnutls_bootprop_priority)
1436 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
1437 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
1438 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
1439 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
1440 (Qgnutls_bootprop_callbacks_verify): Make static.
1441
e7a6747f
AS
14422011-05-01 Andreas Schwab <schwab@linux-m68k.org>
1443
19ed11ba
AS
1444 * callproc.c: Indentation fixup.
1445
e7a6747f 1446 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
1447 (wait_for_termination, interruptible_wait_for_termination):
1448 Move after wait_for_termination_1.
e7a6747f 1449
1ef14cb4
LMI
14502011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
1451
1452 * sysdep.c (interruptible_wait_for_termination): New function
1453 which is like wait_for_termination, but allows keyboard
1454 interruptions.
1455
1456 * callproc.c (Fcall_process): Add (:file "file") as an option for
1457 the STDOUT buffer.
1458 (Fcall_process_region): Ditto.
1459
330d880c
EZ
14602011-04-30 Eli Zaretskii <eliz@gnu.org>
1461
8db90b73
EZ
1462 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
1463 rather than `XVECTOR (FOO)->size'.
1464
330d880c
EZ
1465 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
1466 inttypes.h, as a gnulib replacement is used if it not available in
1467 system headers.
1468
15cbd324
EZ
14692011-04-21 Eli Zaretskii <eliz@gnu.org>
1470
1471 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
1472 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
1473 of MOST_POSITIVE_FIXNUM. (Bug#8528)
1474
1475 * coding.c (coding_alloc_by_realloc): Error out if destination
1476 will grow beyond MOST_POSITIVE_FIXNUM.
1477 (decode_coding_emacs_mule): Abort if there isn't enough place in
1478 charbuf for the composition carryover bytes. Reserve an extra
1479 space for up to 2 characters produced in a loop.
1480 (decode_coding_iso_2022): Abort if there isn't enough place in
1481 charbuf for the composition carryover bytes.
1482
14832011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 1484
ae940cca
EZ
1485 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
1486 aborting when %lld or %lll format is passed.
1487 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
1488 %llo or %llx format is passed. (Bug#8545)
1489
03ab8921
EZ
1490 * window.c (window_scroll_line_based): Use a marker instead of
1491 simple variables to record original value of point. (Bug#7952)
1492
afda1437
EZ
1493 * doprnt.c (doprnt): Fix the case where a multibyte sequence
1494 produced by %s or %c overflows available buffer space. (Bug#8545)
1495
f76dee0c
PE
14962011-04-28 Paul Eggert <eggert@cs.ucla.edu>
1497
1498 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 1499 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 1500
fdc5744d
JB
15012011-04-28 Juanma Barranquero <lekktu@gmail.com>
1502
1503 * w32.c (init_environment): Warn about defaulting HOME to C:\.
1504
638f053a
JB
15052011-04-28 Juanma Barranquero <lekktu@gmail.com>
1506
1507 * keyboard.c (Qdelayed_warnings_hook): Define.
1508 (command_loop_1): Run `delayed-warnings-hook'
1509 if Vdelayed_warnings_list is non-nil.
1510 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
1511 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
1512
d178f871
EZ
15132011-04-28 Eli Zaretskii <eliz@gnu.org>
1514
1515 * doprnt.c (doprnt): Don't return value smaller than the buffer
1516 size if the message was truncated. (Bug#8545).
1517
b124fd93
JB
15182011-04-28 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
1521 (Fx_window_property): #if-0 the whole functions, not just the bodies.
1522
e810457d
PE
15232011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1524
1525 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
1526
ea51cceb
JB
15272011-04-27 Juanma Barranquero <lekktu@gmail.com>
1528
1529 * makefile.w32-in: Update dependencies.
1530
94dcfacf
EZ
15312011-04-27 Eli Zaretskii <eliz@gnu.org>
1532
1533 Improve `doprnt' and its usage. (Bug#8545)
1534 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
1535 `format_end'. Remove support for %l as a conversion specifier.
1536 Don't use xrealloc. Improve diagnostics when the %l size modifier
1537 is used. Update the commentary.
1538
1539 * eval.c (verror): Simplify calculation of size_t.
1540
1541 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
1542 messages.
1543
f61f41d7
PE
15442011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
1545
1546 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
1547 change.
1548
96fb4434
PE
15492011-04-27 Paul Eggert <eggert@cs.ucla.edu>
1550
1551 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
1552 This makes this file independent of the recent pseudovector change.
1553
671875da 15542011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 1555
69e9b5a3
PE
1556 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
1557
b5f869a7 1558 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 1559 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 1560 Remove unused local.
c8926152 1561 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 1562
841a1577 1563 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
1564 GCC 4.6.0 optimizes based on type-based alias analysis.
1565 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
1566 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
1567 != &v->size, and therefore "v->size = 1; b->size = 2; return
1568 v->size;" must therefore return 1. This assumption is incorrect
1569 for Emacs, since it type-puns struct Lisp_Vector * with many other
1570 types. To fix this problem, this patch adds a new type struct
f904488f 1571 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
1572 and pseudovectors, and helps optimizing compilers not get fooled
1573 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
1574 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
1575 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
1576 the size member.
eab3844f
PE
1577 (XSETPVECTYPE): Rewrite in terms of new macro.
1578 (XSETPVECTYPESIZE): New macro, specifying both type and size.
1579 This is a bit clearer, and further avoids the possibility of
1580 undesirable aliasing.
1581 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 1582 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
1583 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
1584 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
1585 (ASIZE): Now uses header.size rather than size.
1586 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
1587 to avoid the hassle of writing XVECTOR (foo)->header.size.
1588 (struct vectorlike_header): New type.
eab3844f
PE
1589 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
1590 object, to help avoid aliasing.
1591 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
1592 (SUBRP): Likewise, since Lisp_Subr is a special case.
1593 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
1594 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
1595 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 1596 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
1597 changed to be "header.size" and "header.next".
1598 * buffer.h (struct buffer): Likewise.
1599 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
1600 * frame.h (struct frame): Likewise.
1601 * process.h (struct Lisp_Process): Likewise.
1602 * termhooks.h (struct terminal): Likewise.
1603 * window.c (struct save_window_data, struct saved_window): Likewise.
1604 * window.h (struct window): Likewise.
1605 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
1606 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
1607 * buffer.c (init_buffer_once): Likewise.
1608 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
1609 special case.
1610 * process.c (Fformat_network_address): Use local var for size,
1611 for brevity.
1612
0df1eac5
PE
1613 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
1614
847ab9d1 1615 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
1616 * data.c (atof): Remove decl; no longer used or needed.
1617 (digit_to_number): Move to lread.c.
1618 (Fstring_to_number): Use new string_to_number function, to be
1619 consistent with how the Lisp reader treats infinities and NaNs.
1620 Do not assume that floating-point numbers represent EMACS_INT
1621 without losing information; this is not true on most 64-bit hosts.
1622 Avoid double-rounding errors, by insisting on integers when
1623 parsing non-base-10 numbers, as the documentation specifies.
1624 * lisp.h (string_to_number): New decl, replacing ...
1625 (isfloat_string): Remove.
bc0a5c13 1626 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 1627 (read1): Do not accept +. and -. as integers; this
452f4150
PE
1628 appears to have been a coding error. Similarly, do not accept
1629 strings like +-1e0 as floating point numbers. Do not report
1630 overflow for integer overflows unless the base is not 10 which
1631 means we have no simple and reliable way to continue.
1632 Break out the floating-point parsing into a new
1633 function string_to_number, so that Fstring_to_number parses
1634 floating point numbers consistently with the Lisp reader.
04f2d78b 1635 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
1636 (E_CHAR, EXP_INT): Remove, replacing with ...
1637 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
1638 (string_to_number): New function, replacing isfloat_string.
1639 This function checks for valid syntax and produces the resulting
1640 Lisp float number too. Rework it so that string-to-number
bc0a5c13 1641 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
1642 so that overflow for non-base-10 numbers is reported only when
1643 there's no portable and simple way to convert to floating point.
452f4150 1644
67769ffc
PE
1645 * textprop.c (set_text_properties_1): Rewrite for clarity,
1646 and to avoid GCC warning about integer overflow.
1647
c20db43f
PE
1648 * intervals.h (struct interval): Use EMACS_INT for members
1649 where EMACS_UINT might cause problems. See
1650 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
1651 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
1652 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
1653 All uses changed.
37aa2f85
PE
1654 (offset_intervals): Tell GCC not to worry about length overflow
1655 when negating a negative length.
c20db43f 1656
2538aa2f
PE
1657 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
1658 (overrun_check_free): Likewise.
1659
f2d3008d
PE
1660 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
1661 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
1662 word size.
1663
ec8df744
PE
1664 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1665 (gnutls_make_error): Rename local to avoid shadowing.
1666 (gnutls_emacs_global_deinit): ifdef out; not used.
1667 (Fgnutls_boot): Use const for pointer to readonly storage.
1668 Comment out unused local. Fix pointer signedness problems.
1669
640ee02d
PE
1670 * lread.c (openp): Don't stuff size_t into an 'int'.
1671 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
1672 about possible signed overflow.
1673
6048fb2a
PE
1674 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
1675 (GDK_KEY_g): Don't define if already defined.
1676 (xg_prepare_tooltip): Avoid pointer signedness problem.
1677 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
1678
fa3c87e1
PE
1679 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
1680 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
1681
2172544b
PE
1682 * xfns.c (Fx_window_property): Simplify a bit,
1683 to make a bit faster and to avoid GCC 4.6.0 warning.
1684 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
1685
9b821a21
PE
1686 * fns.c (internal_equal): Don't assume size_t fits in int.
1687
3c616cfa
PE
1688 * alloc.c (compact_small_strings): Tighten assertion a little.
1689
c2982e87
PE
1690 Replace pEd with more-general pI, and fix some printf arg casts.
1691 * lisp.h (pI): New macro, generalizing old pEd macro to other
1692 conversion specifiers. For example, use "...%"pI"d..." rather
1693 than "...%"pEd"...".
1694 (pEd): Remove. All uses replaced with similar uses of pI.
1695 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
1696 * alloc.c (check_pure_size): Don't overflow by converting size to int.
1697 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
1698 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
1699 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
1700 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
1701 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
1702 64-bit hosts.
1703 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
1704 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
1705 * print.c (safe_debug_print, print_object): Likewise.
1706 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
1707 to int.
6f04d126
PE
1708 Use pI instead of if-then-else-abort. Use %p to avoid casts,
1709 avoiding the 0 flag, which is not portable.
c2982e87
PE
1710 * process.c (Fmake_network_process): Use pI to avoid cast.
1711 * region-cache.c (pp_cache): Likewise.
1712 * xdisp.c (decode_mode_spec): Likewise.
1713 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
1714 behavior on 64-bit hosts with printf arg.
6f04d126 1715 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
1716 (x_stop_queuing_selection_requests): Likewise.
1717 (x_get_window_property): Don't truncate byte count to an 'int'
1718 when tracing.
0b432f21 1719
5e073ec7
PE
1720 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
1721 here, since it parses constructs like leading '-' and spaces,
1722 which are not wanted; and it overflows with large numbers.
1723 Instead, simply match F[0-9]+, which is what is wanted anyway.
1724
36372bf9
PE
1725 * alloc.c: Remove unportable assumptions about struct layout.
1726 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
1727 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
1728 (allocate_vectorlike, make_pure_vector): Use the new macros,
1729 plus offsetof, to remove unportable assumptions about struct layout.
1730 These assumptions hold on all porting targets that I know of, but
1731 they are not guaranteed, they're easy to remove, and removing them
1732 makes further changes easier.
1733
0b432f21
PE
1734 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
1735 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
1736 (string_overrun_cookie): Now const. Use initializers that
1737 don't formally overflow signed char, to avoid warnings.
000098c1
PE
1738 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
1739 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
1740 (allocate_buffer): Don't assume sizeof (struct buffer) is a
1741 multiple of sizeof (EMACS_INT); it need not be, if
1742 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 1743 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 1744
895009e1
JB
17452011-04-26 Juanma Barranquero <lekktu@gmail.com>
1746
1747 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
1748
6a7a1b0b
TZ
17492011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
1750
1751 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 1752 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
1753 Reported by Paul Eggert <eggert@cs.ucla.edu>.
1754
841a1577 17552011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
1756
1757 * lisp.h (Qdebug): List symbol.
895009e1 1758 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
1759 * keyboard.c (debug-on-event): New variable.
1760 (handle_user_signal): Break into debugger when debug-on-event
1761 matches the current signal symbol.
1762
f2d3ba6f
DN
17632011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
1764
1765 * alloc.c (check_sblock, check_string_bytes)
1766 (check_string_free_list): Convert to standard C.
1767
42ce4c63
TZ
17682011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
1769
1770 * w32.c (emacs_gnutls_push): Fix typo.
1771
825cd63c
EZ
17722011-04-25 Eli Zaretskii <eliz@gnu.org>
1773
fb11d64d
EZ
1774 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
1775 "cast to pointer from integer of different size".
1776
825cd63c
EZ
1777 Improve doprnt and its use in verror. (Bug#8545)
1778 * doprnt.c (doprnt): Document the set of format control sequences
1779 supported by the function. Use SAFE_ALLOCA instead of always
1780 using `alloca'.
1781
1782 * eval.c (verror): Don't limit the buffer size at size_max-1, that
1783 is one byte too soon. Don't use xrealloc; instead xfree and
1784 xmalloc anew.
1785
e061a11b
TZ
17862011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
1787
1788 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
1789 callbacks stage.
1790
1791 * gnutls.c: Renamed global_initialized to
1792 gnutls_global_initialized. Added internals for the
1793 :verify-hostname-error, :verify-error, and :verify-flags
1794 parameters of `gnutls-boot' and documented those parameters in the
1795 docstring. Start callback support.
1796 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
1797 unless a fatal error occured. Call gnutls_alert_send_appropriate
1798 on error. Return error code.
1799 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
1800 (emacs_gnutls_read): Likewise.
1801 (Fgnutls_boot): Return handshake error code.
1802 (emacs_gnutls_handle_error): New function.
1803 (wsaerror_to_errno): Likewise.
1804
1805 * w32.h (emacs_gnutls_pull): Add prototype.
1806 (emacs_gnutls_push): Likewise.
1807
1808 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
1809 (emacs_gnutls_push): Likewise.
1810
18112011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
1812
1813 * process.c (wait_reading_process_output): Check if GnuTLS
1814 buffered some data internally if no FDs are set for TLS
1815 connections.
1816
1817 * makefile.w32-in (OBJ2): Add gnutls.$(O).
1818 (LIBS): Link to USER_LIBS.
1819 ($(BLD)/gnutls.$(0)): New target.
1820
fa6996bc
EZ
18212011-04-24 Eli Zaretskii <eliz@gnu.org>
1822
eb35682e
EZ
1823 * xdisp.c (handle_single_display_spec): Rename the
1824 display_replaced_before_p argument into display_replaced_p, to
1825 make it consistent with the commentary. Fix typos in the
1826 commentary.
1827
e2ad650c
EZ
1828 * textprop.c (syms_of_textprop): Remove dead code.
1829 (copy_text_properties): Delete obsolete commentary about an
1830 interface that was deleted long ago. Fix typos in the description
1831 of arguments.
1832
1b2de274
EZ
1833 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
1834 to changes in oldXMenu/XMenu.h from 2011-04-16.
1835 <menu_help_message, prev_menu_help_message>: Constify.
1836 (IT_menu_make_room): menu->help_text is now `const char **';
1837 adjust.
1838
1839 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
1840 to changes in oldXMenu/XMenu.h from 2011-04-16.
1841 (struct XMenu): Declare `help_text' `const char **'.
1842
1843 * xfaces.c <Qunspecified>: Make extern again.
1844
1845 * syntax.c: Include sys/types.h before including regex.h, as
1846 required by Posix.
1847
762b15be
EZ
1848 * doc.c (get_doc_string): Improve the format passed to `error'.
1849
1850 * doprnt.c (doprnt): Improve commentary.
1851
1852 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
1853
1854 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
1855 them with etags.
1856
f1052e5d
EZ
1857 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
1858 changes in globals.h immediately force recompilation.
762b15be
EZ
1859 (TAGS): Depend on $(CURDIR)/m/intel386.h and
1860 $(CURDIR)/s/ms-w32.h.
1861 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 1862
fa6996bc
EZ
1863 * character.c (Fchar_direction): Function deleted.
1864 (syms_of_character): Don't defsubr it.
1865 <char-direction-table>: Deleted.
1866
e6c3da20
EZ
18672011-04-23 Eli Zaretskii <eliz@gnu.org>
1868
1869 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
1870 * doprnt.c: Include limits.h.
1871 (SIZE_MAX): New macro.
04f2d78b
CB
1872 (doprnt): Return a size_t value. 2nd arg is now size_t.
1873 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
1874 Improve overflow protection. Support `l' modifier for integer
1875 conversions. Support %l conversion. Don't assume an EMACS_INT
1876 argument for integer conversions and for %c.
1877
1878 * lisp.h (doprnt): Restore prototype.
1879
1880 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
1881 $(SRC)/character.h.
1882
1883 * Makefile.in (base_obj): Add back doprnt.o.
1884
1885 * deps.mk (doprnt.o): Add back prerequisites.
1886 (callint.o): Depend on character.h.
1887
1888 * eval.c (internal_lisp_condition_case): Include the handler
1889 representation in the error message.
1890 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
1891 when breaking from the loop.
1892
1893 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
1894
1895 * callint.c (Fcall_interactively): When displaying error message
1896 about invalid control letter, pass the character's codepoint, not
1897 a pointer to its multibyte form. Improve display of the character
1898 in octal and display also its hex code.
1899
1900 * character.c (char_string): Use %x to display the (unsigned)
1901 codepoint of an invalid character, to avoid displaying a bogus
1902 negative value.
1903
1904 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
1905 `error', not SYMBOL_NAME itself.
1906
1907 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
1908 character arguments to `error'.
1909
1910 * charset.c (check_iso_charset_parameter): Fix incorrect argument
1911 to `error' in error message about FINAL_CHAR argument. Make sure
1912 FINAL_CHAR is a character, and use %c when it is passed as
1913 argument to `error'.
1914
4ffd0d6b 19152011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
1916
1917 * s/ms-w32.h (localtime): Redirect to sys_localtime.
1918
1919 * w32.c: Include <time.h>.
1920 (sys_localtime): New function.
1921
4ffd0d6b 19222011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
1923
1924 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
1925
4ffd0d6b 1926 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 1927
4ffd0d6b 19282011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 1929
4ffd0d6b
GM
1930 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
1931 zombies (Bug#8467).
aac0c6e3 1932
04c56954
EZ
19332011-04-19 Eli Zaretskii <eliz@gnu.org>
1934
1935 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
1936 gl_state.e_property when gl_state.object is Qt.
1937
1938 * insdel.c (make_gap_larger): Remove limitation of buffer size
1939 to <= INT_MAX.
1940
16a43933
CY
19412011-04-18 Chong Yidong <cyd@stupidchicken.com>
1942
1943 * xdisp.c (lookup_glyphless_char_display)
1944 (produce_glyphless_glyph): Handle cons cell entry in
1945 glyphless-char-display.
1946 (Vglyphless_char_display): Document it.
1947
1948 * term.c (produce_glyphless_glyph): Handle cons cell entry in
1949 glyphless-char-display.
1950
4581706e
CY
19512011-04-17 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
1954
1955 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
1956
1957 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
1958 definition for no-X builds.
1959
4887c6e2 19602011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 1961
fd35b6f9
PE
1962 Static checks with GCC 4.6.0 and non-default toolkits.
1963
5c1ccb01
PE
1964 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
1965
006c5daa
PE
1966 * process.c (keyboard_bit_set): Define only if SIGIO.
1967 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
1968 (send_process): Repair possible setjmp clobbering.
1969
efc736d3
PE
1970 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
1971
4e2fe2e6
PE
1972 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
1973
f97334a2
PE
1974 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
1975
4e75f29d
PE
1976 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
1977 Define only if needed.
1978
90efadd1
PE
1979 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
1980 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 1981 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 1982
3c647824
PE
1983 * dispextern.h (struct redisplay_interface): Rename param
1984 to avoid shadowing.
e264f262 1985 * termhooks.h (struct terminal): Likewise.
761383f4 1986 * xterm.c (xembed_send_message): Likewise.
3c647824 1987
b58c5c4a
PE
1988 * insdel.c (make_gap_smaller): Define only if
1989 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
1990
cad59032
PE
1991 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
1992 it.
1993
c339dc2e
PE
1994 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
1995 so that we aren't warned about unused symbols.
1996
91a3e27b
PE
1997 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
1998
399c71d3 1999 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 2000
8ffc96f5
PE
2001 * xfns.c (x_real_positions): Mark locals as initialized.
2002
eef9bc79
PE
2003 * xmenu.c (xmenu_show): Don't use uninitialized vars.
2004
098db9dd
PE
2005 * xterm.c: Fix problems found by static analysis with other toolkits.
2006 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
2007 (x_dispatch_event): Declare static if USE_GTK, and
2008 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 2009 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 2010 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
2011 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
2012 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 2013
eb18f6cc
PE
2014 * xmenu.c (menu_help_callback): Pointer type fixes.
2015 Use const pointers when pointing at readonly data. Avoid pointer
2016 signedness clashes.
2017 (FALSE): Remove unused macro.
2018 (update_frame_menubar): Remove unused decl.
2019
1fe72bf8
PE
2020 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
2021
60d9e1db
PE
2022 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
2023 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
2024 (single_menu_item): Rename local to avoid shadowing.
2025
39261c26
PE
2026 * keyboard.c (make_lispy_event): Remove unused local var.
2027
018c5e19
PE
2028 * frame.c, frame.h (x_get_resource_string): Bring this back, but
2029 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
2030
63d2b86e
PE
2031 * bitmaps: Change bitmaps from unsigned char back to the X11
2032 compatible char. Avoid the old compiler warnings about
2033 out-of-range initializers by using, for example, '\xab' rather
2034 than 0xab.
2035
aefd87e1
PE
2036 * xgselect.c (xgselect_initialize): Check vs interface
2037 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
2038
bf501fb9
PE
2039 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
2040
e9829fdf
PE
2041 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
2042 to read-only memory.
2043
1086c095
PE
2044 * fns.c (vector): Remove; this old hack is no longer needed.
2045
2baccd04 2046 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 2047 Remove unused var.
dde42981 2048 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 2049
72391843 2050 * xrdb.c (x_load_resources): Omit unused local.
3565b346 2051
436c16df 2052 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 2053 (x_window): Rename locals to avoid shadowing.
dc5ddd85 2054 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 2055
92bb796d 2056 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 2057 (x_term_init): Remove local to avoid shadowing.
92bb796d 2058
764430a3 2059 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
2060
2061 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
2062 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
2063
d1dfb56c
EZ
20642011-04-16 Eli Zaretskii <eliz@gnu.org>
2065
c4354cb4
EZ
2066 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
2067
d1dfb56c
EZ
2068 Fix regex.c, syntax.c and friends for buffers > 2GB.
2069 * syntax.h (struct gl_state_s): Declare character position members
2070 EMACS_INT.
2071
2072 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
2073
04f2d78b
CB
2074 * textprop.c (verify_interval_modification, interval_of):
2075 Declare arguments EMACS_INT.
d1dfb56c
EZ
2076
2077 * intervals.c (adjust_intervals_for_insertion): Declare arguments
2078 EMACS_INT.
2079
2080 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
2081
2082 * indent.c (Fvertical_motion): Local variable it_start is now
2083 EMACS_INT.
2084
2085 * regex.c (re_match, re_match_2, re_match_2_internal)
2086 (bcmp_translate, regcomp, regexec, print_double_string)
2087 (group_in_compile_stack, re_search, re_search_2, regex_compile)
2088 (re_compile_pattern, re_exec): Declare arguments and local
2089 variables `size_t' and `ssize_t' and return values `regoff_t', as
2090 appropriate.
2091 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
2092 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
2093 <compile_stack_type>: `size' and `avail' are now `size_t'.
2094
2095 * regex.h <regoff_t>: Use ssize_t, not int.
2096 (re_search, re_search_2, re_match, re_match_2): Arguments that
2097 specify buffer/string position and length are now ssize_t and
2098 size_t. Return type is regoff_t.
2099
613052cd
BK
21002011-04-16 Ben Key <bkey76@gmail.com>
2101
2102 * nsfont.m: Fixed bugs in ns_get_family and
2103 ns_descriptor_to_entity that were caused by using free to
2104 deallocate memory blocks that were allocated by xmalloc (via
2105 xstrdup). This caused Emacs to crash when compiled with
2106 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
2107 --enable-checking=xmallocoverrun). xfree is now used to
2108 deallocate these memory blocks.
2109
4170f62f 21102011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 2111
71b41406
PE
2112 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
2113
9587a89d
PE
2114 emacs_write: Accept and return EMACS_INT for sizes.
2115 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
2116 et seq.
2117 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
2118 Accept and return EMACS_INT.
2119 (emacs_gnutls_write): Return the number of bytes written on
2120 partial writes.
2121 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
2122 (emacs_read, emacs_write): Remove check for negative size, as the
2123 Emacs source code has been audited now.
9587a89d
PE
2124 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
2125 (emacs_read, emacs_write): Use it.
273a5f82
PE
2126 * process.c (send_process): Adjust to the new signatures of
2127 emacs_write and emacs_gnutls_write. Do not attempt to store
2128 a byte offset into an 'int'; it might overflow.
9587a89d 2129 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 2130
3e047f51
PE
2131 * sound.c: Don't assume sizes fit in 'int'.
2132 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 2133 Return EMACS_INT, not int.
3e047f51 2134 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
2135 Accept EMACS_INT, not int.
2136 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
2137 record read return values.
2138
cc39a9db
BK
21392011-04-15 Ben Key <bkey76@gmail.com>
2140
c9d0ec6d
JB
2141 * keyboard.c (Qundefined): Don't declare static since it is used
2142 in nsfns.m.
2143 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
2144 static since they are used in nsfont.m.
cc39a9db 2145
6c60eb9f
SM
21462011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
2147
2148 * process.c (Qprocessp): Don't declare static.
2149 * lisp.h (Qprocessp): Declare again.
2150
7990b61a
JB
21512011-04-15 Juanma Barranquero <lekktu@gmail.com>
2152
2153 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
2154
5d4cb038
PE
21552011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2156
8bd7b830 2157 Improve C-level modularity by making more things 'static'.
cd64ea1d 2158
e3b27b31
PE
2159 Don't publish debugger-only interfaces to other modules.
2160 * lisp.h (safe_debug_print, debug_output_compilation_hack):
2161 (verify_bytepos, count_markers): Move decls to the only modules
2162 that need them.
2163 * region-cache.h (pp_cache): Likewise.
2164 * window.h (check_all_windows): Likewise.
2165 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
2166
5d4cb038
PE
2167 * sysdep.c (croak): Now static, if
2168 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
2169 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
2170
2171 * alloc.c (refill_memory_reserve): Now static if
2172 !defined REL_ALLOC || defined SYSTEM_MALLOC.
2173 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 2174
e87b6180
PE
2175 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
2176 Define only if USE_LUCID.
2177
ac64929e
PE
2178 * xrdb.c (x_customization_string, x_rm_string): Now static.
2179
6f37259d
PE
2180 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
2181 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
2182
1683e3ab
PE
2183 * xdisp.c (draw_row_with_mouse_face): Now static.
2184 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
2185
de9c2632
PE
2186 * window.h (check_all_windows): Mark externally visible.
2187
2b96acb7
PE
2188 * window.c (window_deletion_count): Now static.
2189
2190 * undo.c: Make symbols static if they're not exported.
2191 (last_undo_buffer, last_boundary_position, pending_boundary):
2192 Now static.
2193
50436f33
PE
2194 * textprop.c (interval_insert_behind_hooks): Now static.
2195 (interval_insert_in_front_hooks): Likewise.
2196
64520e5c
PE
2197 * term.c: Make symbols static if they're not exported.
2198 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
2199 (max_frame_lines, tty_set_terminal_modes):
2200 (tty_reset_terminal_modes, tty_turn_off_highlight):
2201 (get_tty_terminal): Now static.
2202 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
2203 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 2204 HAVE_WINDOW_SYSTEM.
64520e5c
PE
2205 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
2206 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
2207
1fa53021
PE
2208 * sysdep.c: Make symbols static if they're not exported.
2209 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
2210 Now static.
2211 (sigprocmask_set, full_mask): Remove; unused.
2212 (wait_debugging): Mark as visible.
2213 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
2214 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
2215
d4b43b22
PE
2216 * syntax.c (syntax_temp): Define only if !__GNUC__.
2217
b7c513d0
PE
2218 * sound.c (current_sound_device, current_sound): Now static.
2219
989b29ad
PE
2220 * search.c (searchbufs, searchbuf_head): Now static.
2221
13a55a78
PE
2222 * scroll.c (scroll_cost): Remove; unused.
2223 * dispextern.h (scroll_cost): Remove decl.
2224
de68a1fc
PE
2225 * region-cache.h (pp_cache): Mark as externally visible.
2226
40ccffa6
PE
2227 * process.c: Make symbols static if they're not exported.
2228 (process_tick, update_tick, create_process, chan_process):
2229 (Vprocess_alist, proc_buffered_char, datagram_access):
2230 (fd_callback_data, send_process_frame, process_sent_to): Now static.
2231 (deactivate_process): Mark defn as static, as well as decl.
2232 * lisp.h (create_process): Remove decl.
2233 * process.h (chan_process, Vprocess_alist): Remove decls.
2234
ad64fc97
PE
2235 * print.c: Make symbols static if they're not exported.
2236 (print_depth, new_backquote_output, being_printed, print_buffer):
2237 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
2238 (print_interval, print_number_index, initial_stderr_stream):
2239 Now static.
2240 * lisp.h (Fprinc): Remove decl.
2241 (debug_output_compilation_hack): Mark as externally visible.
2242
adddb265
PE
2243 * sysdep.c (croak): Move decl from here to syssignal.h.
2244 * syssignal.h (croak): Put it here, so the API can be checked when
2245 'croak' is called from dissociate_if_controlling_tty.
2246
1717ede2
PE
2247 * minibuf.c: Make symbols static if they're not exported.
2248 (minibuf_save_list, choose_minibuf_frame): Now static.
2249 * lisp.h (choose_minibuf_frame): Remove decl.
2250
fa5fb2bc
PE
2251 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
2252
1e3890d1
PE
2253 * lread.c: Make symbols static if they're not exported.
2254 (read_objects, initial_obarray, oblookup_last_bucket_number):
2255 Now static.
2256 (make_symbol): Remove; unused.
2257 * lisp.h (initial_obarray, make_symbol): Remove decls.
2258
8a1414fa
PE
2259 * keyboard.c: Make symbols static if they're not exported.
2260 (single_kboard, recent_keys_index, total_keys, recent_keys):
2261 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
2262 (this_single_command_key_start, echoing, last_auto_save):
2263 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
2264 (command_loop, echo_now, keyboard_init_hook, help_char_p):
2265 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
2266 (Vlispy_mouse_stem, double_click_count):
2267 Now static.
2268 (force_auto_save_soon): Define only if SIGDANGER.
2269 (ignore_mouse_drag_p): Now static if
2270 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
2271 (print_help): Remove; unused.
2272 (stop_character, last_timer_event): Mark as externally visible.
2273 * keyboard.h (ignore_mouse_drag_p): Declare only if
2274 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
2275 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
2276 * lisp.h (echoing): Remove decl.
2277 (force_auto_save_soon): Declare only if SIGDANGER.
2278 * xdisp.c (redisplay_window): Simplify code, to make it more
2279 obvious that ignore_mouse_drag_p is not accessed if !defined
2280 USE_GTK && !defined HAVE_NS.
2281
93ea6e8f
PE
2282 * intervals.c: Make symbols static if they're not exported.
2283 (merge_properties_sticky, merge_interval_right, delete_interval):
2284 Now static.
2285 * intervals.h (merge_interval_right, delete_interval): Remove decls.
2286
77382fcc
PE
2287 * insdel.c: Make symbols static if they're not exported.
2288 However, leave prepare_to_modify_buffer alone. It's never
2289 called from outside this function, but that appears to be a bug.
2290 (combine_after_change_list, combine_after_change_buffer):
4889fc82 2291 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
2292 (adjust_after_replace_noundo): Remove; unused.
2293 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 2294 (signal_before_change): Remove decls.
77382fcc 2295
9306c32e
PE
2296 * indent.c (val_compute_motion, val_vmotion): Now static.
2297
cd44d2eb
PE
2298 * image.c: Make symbols static if they're not exported.
2299 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
2300 if USE_GTK.
2301 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
2302 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
2303
ad9a7a06
PE
2304 * fringe.c (standard_bitmaps): Now static.
2305 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
2306
81626931
PE
2307 * frame.c: Make symbols static if they're not exported.
2308 (x_report_frame_params, make_terminal_frame): Now static.
2309 (get_frame_param): Now static, unless HAVE_NS.
2310 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
2311 (x_get_resource_string): Remove; not used.
2312 * frame.h (make_terminal_frame, x_report_frame_params):
2313 (x_get_resource_string); Remove decls.
2314 (x_fullscreen_adjust): Declare only if WINDOWSNT.
2315 * lisp.h (get_frame_param): Declare only if HAVE_NS.
2316
239f9db9
PE
2317 * font.c, fontset.c: Make symbols static if they're not exported.
2318 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
2319 (FACE_SUITABLE_FOR_CHAR_P): Use it.
2320 * font.c (font_close_object): Now static.
2321 * font.h (font_close_object): Remove.
2322 * fontset.c (FONTSET_OBJLIST): Remove.
2323 (free_realized_fontset) #if-0 the body, which does nothing.
2324 (face_suitable_for_char_p): #if-0, as it's never called.
2325 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
2326 * xfaces.c (face_at_string_position):
2327 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
2328 since 0 is always ASCII.
2329
dfcf3579
PE
2330 * fns.c (weak_hash_tables): Now static.
2331
5045092b
PE
2332 * fileio.c: Make symbols static if they're not exported.
2333 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
2334 (Vwrite_region_annotation_buffers): Now static.
2335
57a96f5c
PE
2336 * eval.c: Make symbols static if they're not exported.
2337 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
2338 * lisp.h (backtrace_list): Remove decl.
2339
35f08c38
PE
2340 * emacs.c: Make symbols static if they're not exported.
2341 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
2342 (fatal_error_code, fatal_error_signal_hook, standard_args):
2343 Now static.
2344 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
2345 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
2346 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
2347 * lisp.h (fatal_error_signal_hook): Remove decl.
2348 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
2349
f44bd759
PE
2350 * editfns.c: Move a (normally-unused) function to its only use.
2351 * editfns.c, lisp.h (get_operating_system_release): Remove.
2352 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
2353 worth the hassle of breaking this out.
2354
b532497d
PE
2355 * xterm.c: Make symbols static if they're not exported.
2356 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
2357 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
2358 (x_destroy_window, x_delete_display):
2359 Now static.
2360 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
2361 (x_mouse_leave): Remove; unused.
2362 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
2363 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
2364 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
2365 Remove decls.
2366 (x_mouse_leave): Declare only if WINDOWSNT.
2367 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
2368 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
2369 USE_X_TOOLKIT.
2370
1675728f
PE
2371 * ftxfont.c: Make symbols static if they're not exported.
2372 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
2373 HAVE_FREETYPE.
2374 * font.h (ftxfont_driver): Likewise.
2375
e4cebfca
PE
2376 * xfns.c: Make symbols static if they're not exported.
2377 (x_last_font_name, x_display_info_for_name):
2378 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
2379 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
2380 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
2381 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
2382 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
2383 (last_show_tip_args): Now static.
2384 (xic_defaut_fontset, xic_create_fontsetname): Define only if
2385 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
2386 (x_screen_planes): Remove; unused.
2387 * dispextern.h (x_screen_planes): Remove decl.
2388
5bf46f05
PE
2389 * dispnew.c: Make symbols static if they're not exported.
2390 * dispextern.h (redraw_garbaged_frames, scrolling):
2391 (increment_row_positions): Remove.
2392 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
2393 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
2394 Now static.
2395 (redraw_garbaged_frames): Remove; unused.
2396
435f4c28
PE
2397 * xfaces.c: Make symbols static if they're not exported.
2398 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
2399 Remove decls.
2400 * xterm.h (defined_color): Remove decls.
2401 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
2402 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
2403 (menu_face_changed_default, defined_color, free_realized_face):
2404 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
2405 (ascii_face_of_lisp_face): Remove; unused.
2406
8524aef3
PE
2407 * xdisp.c: Make symbols static if they're not exported.
2408 * dispextern.h (scratch_glyph_row, window_box_edges):
2409 (glyph_to_pixel_coords, set_cursor_from_row):
2410 (get_next_display_element, set_iterator_to_next):
2411 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
2412 (show_mouse_face): Remove decls
2413 * frame.h (message_buf_print): Likewise.
2414 * lisp.h (pop_message, set_message, check_point_in_composition):
2415 Likewise.
2416 * xterm.h (set_vertical_scroll_bar): Likewise.
2417 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
2418 (message_buf_print, scratch_glyph_row, displayed_buffer):
2419 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
2420 (get_next_display_element, show_mouse_face, window_box_edges):
2421 (frame_to_window_pixel_xy, check_point_in_composition):
2422 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
2423 (glyph_to_pixel_coords): Remove; unused.
2424
16390cd2
PE
2425 * dired.c (file_name_completion): Now static.
2426
2427 * dbusbind.c (xd_in_read_queued_messages): Now static.
2428
a25f4dfa
PE
2429 * lisp.h (circular_list_error, FOREACH): Remove; unused.
2430 * data.c (circular_list_error): Remove.
2431
14a9c8df
PE
2432 * commands.h (last_point_position, last_point_position_buffer):
2433 (last_point_position_window): Remove decls.
2434 * keyboard.c: Make these variables static.
2435
04f2d78b
CB
2436 * coding.h (coding, code_convert_region, encode_coding_gap):
2437 Remove decls.
74ab6df5
PE
2438 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
2439 (iso_code_class, detect_coding, code_convert_region): Now static.
2440 (encode_coding_gap): Remove; unused.
2441
38dfbee1
PE
2442 * chartab.c (chartab_chars, chartab_bits): Now static.
2443
a2cb4e63
PE
2444 * charset.h (charset_iso_8859_1): Remove decl.
2445 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
2446 Now static.
2447
127198fd
PE
2448 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
2449 * ccl.c (Vccl_program_table): Now static.
2450 (check_ccl_update): Remove; unused.
2451
d85b608f
PE
2452 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
2453 * category.h: ... from here.
2454 * category.c (check_category_table, set_category_set): Now static.
2455
31cd66f3
PE
2456 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
2457 * lisp.h: Remove these decls.
2458
c358e587
PE
2459 * buffer.c (buffer_count): Remove unused var.
2460
e78aecca
PE
2461 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
2462 so that it's not optimized away.
2463 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
2464 * dispextern.h (bidi_dump_cached_states): Remove, since it's
2465 exported only to the debugger.
2466
e192d7d3 2467 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 2468 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 2469
92470028
PE
2470 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
2471 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
2472 was inaccessible from Lisp.
2473 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
2474 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
2475
244ed907
PE
2476 alloc.c: Import and export fewer symbols, and remove unused items.
2477 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
2478 is defined.
2479 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
2480 it's not optimized away by whole-program optimization.
2481 (message_enable_multibyte, free_misc): Remove.
2482 (catchlist, handlerlist, mark_backtrace):
2483 Declare only if BYTE_MARK_STACK.
2484 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
2485 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
2486 (message_enable_multibyte): Remove decl.
2487 (free_misc, interval_free_list, float_block, float_block_index):
2488 (n_float_blocks, float_free_list, cons_block, cons_block_index):
2489 (cons_free_list, last_marked_index):
2490 Now static.
2491 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
2492 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
2493 (mark_backtrace): Define only if BYTE_MARK_STACK.
2494 * xdisp.c (message_enable_multibyte): Now static.
2495
61c2b50e 2496 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
2497 This makes it easier for human readers (and static analyzers)
2498 to see whether these variables are used from other modules.
2499 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
2500 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
2501 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
2502 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
2503 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
2504 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
2505 * xmenu.c, xselect.c:
2506 Declare Q* vars static if they are not used in other modules.
2507 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
2508 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
2509 Remove decls of unexported vars.
2510 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
2511
95c82688
PE
2512 * lisp.h (DEFINE_FUNC): Make sname 'static'.
2513
16a97296
PE
2514 Make Emacs functions such as Fatom 'static' by default.
2515 This makes it easier for human readers (and static analyzers)
2516 to see whether these functions can be called from other modules.
2517 DEFUN now defines a static function. To make the function external
2518 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
2519 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
2520 (Finit_image_library):
16a97296
PE
2521 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
2522 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
2523 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
2524 Remove decls, since these functions are now static.
2525 (Funintern, Fget_internal_run_time): New decls, since these functions
2526 were already external.
95c82688 2527
16a97296
PE
2528 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
2529 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
2530 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
2531 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
2532 * keyboard.c, keymap.c, lread.c:
2533 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
2534 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
2535 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
2536 Mark functions with DEFUE instead of DEFUN,
2537 if they are used in other modules.
2538 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
2539 decls for now-static functions.
2540 * buffer.h (Fdelete_overlay): Remove decl.
2541 * callproc.c (Fgetenv_internal): Mark as internal.
2542 * composite.c (Fremove_list_of_text_properties): Remove decl.
2543 (Fcomposition_get_gstring): New forward static decl.
2544 * composite.h (Fcomposite_get_gstring): Remove decl.
2545 * dired.c (Ffile_attributes): New forward static decl.
2546 * doc.c (Fdocumntation_property): New forward static decl.
2547 * eval.c (Ffetch_bytecode): New forward static decl.
2548 (Funintern): Remove extern decl; now in .h file where it belongs.
2549 * fileio.c (Fmake_symbolic_link): New forward static decl.
2550 * image.c (Finit_image_library): New forward static decl.
2551 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
2552 * intervals.h (Fprevious_property_change):
2553 (Fremove_list_of_text_properties): Remove decls.
2554 * keyboard.c (Fthis_command_keys): Remove decl.
2555 (Fcommand_execute): New forward static decl.
2556 * keymap.c (Flookup_key): New forward static decl.
2557 (Fcopy_keymap): Now static.
2558 * keymap.h (Flookup_key): Remove decl.
2559 * process.c (Fget_process): New forward static decl.
2560 (Fprocess_datagram_address): Mark as internal.
2561 * syntax.c (Fsyntax_table_p): New forward static decl.
2562 (skip_chars): Remove duplicate decl.
2563 * textprop.c (Fprevious_property_change): New forward static decl.
2564 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
2565 Now internal.
2566 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
2567 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
2568
785bbd42
PE
2569 * editfns.c (Fformat): Remove unreachable code.
2570
8b913b57
AS
25712011-04-14 Andreas Schwab <schwab@linux-m68k.org>
2572
2573 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
2574 change. (Bug#8496)
2575
a6744a35
EZ
25762011-04-13 Eli Zaretskii <eliz@gnu.org>
2577
2578 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
2579 when at ZV. (Bug#8487)
2580
e7974947
AS
25812011-04-12 Andreas Schwab <schwab@linux-m68k.org>
2582
baad03f0
AS
2583 * charset.c (Fclear_charset_maps): Use xfree instead of free.
2584 (Bug#8437)
2585 * keyboard.c (parse_tool_bar_item): Likewise.
2586 * sound.c (sound_cleanup, alsa_close): Likewise.
2587 * termcap.c (tgetent): Likewise.
2588 * xfns.c (x_default_font_parameter): Likewise.
2589 * xsettings.c (read_and_apply_settings): Likewise.
2590
e7974947
AS
2591 * alloc.c (overrun_check_malloc, overrun_check_realloc)
2592 (overrun_check_free): Protoize.
2593
28272684
PE
25942011-04-12 Paul Eggert <eggert@cs.ucla.edu>
2595
2596 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
2597 since callers should never pass a negative size.
2598 Change the signature to match that of plain 'read' and 'write'; see
2599 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
2600 * lisp.h: Update prototypes of emacs_write and emacs_read.
2601
11997c76
EZ
26022011-04-11 Eli Zaretskii <eliz@gnu.org>
2603
2604 * xdisp.c (redisplay_window): Don't try to determine the character
2605 position of the scroll margin if the window start point w->startp
e896f03c 2606 is outside the buffer's accessible region. (Bug#8468)
11997c76 2607
8a2cbd72
EZ
26082011-04-10 Eli Zaretskii <eliz@gnu.org>
2609
2610 Fix write-region and its subroutines for buffers > 2GB.
2611 * fileio.c (a_write, e_write): Modify declaration of arguments and
2612 local variables to support buffers larger than 2GB.
2613 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
2614
2615 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
2616 argument, local variables, and return value.
2617
2618 * lisp.h: Update prototypes of emacs_write and emacs_read.
2619
2620 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
2621
4073e537 26222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 2623
1ebfdcb6
PE
2624 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
2625
b2ded58d
PE
2626 Fix more problems found by GCC 4.6.0's static checks.
2627
7d66342c
PE
2628 * xdisp.c (vmessage): Use a better test for character truncation.
2629
bbf47d44
PE
2630 * charset.c (load_charset_map): <, not <=, for optimization,
2631 and to avoid potential problems with integer overflow.
9248994d 2632 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 2633 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 2634 * editfns.c (Fformat): Likewise.
1e69125e 2635 * syntax.c (skip_chars): Likewise.
3befa583 2636
e3019616
PE
2637 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
2638 This also lets GCC 4.6.0 generate slightly better loop code.
2639
becfa255
PE
2640 * callint.c (Fcall_interactively): <, not <=, for optimization.
2641 (Fcall_interactively): Count the number of arguments produced,
2642 not the number of arguments given. This is simpler and lets GCC
2643 4.6.0 generate slightly better code.
2644
dae0cd48
PE
2645 * ftfont.c: Distingish more carefully between FcChar8 and char.
2646 The previous code passed unsigned char * to a functions like
2647 strlen and xstrcasecmp that expect char *, which does not
2648 conform to the C standard.
2649 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
2650 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
2651 char * when the C standard requires it.
2652
76032d70
PE
2653 * keyboard.c (read_char): Remove unused var.
2654
eb3f1cc8
PE
2655 * eval.c: Port to Windows vsnprintf (Bug#8435).
2656 Include <limits.h>.
2657 (SIZE_MAX): Define if the headers do not.
2658 (verror): Do not give up if vsnprintf returns a negative count.
2659 Instead, grow the buffer. This ports to Windows vsnprintf, which
2660 does not conform to C99. Problem reported by Eli Zaretskii.
2661 Also, simplify the allocation scheme, by avoiding the need for
2662 calling realloc, and removing the ALLOCATED variable.
2663
70476b54
PE
2664 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
2665
12020a9e
PE
2666 Remove invocations of doprnt, as Emacs now uses vsnprintf.
2667 But keep the doprint source code for now, as we might revamp it
2668 and use it again (Bug#8435).
ea6c7ae6
PE
2669 * lisp.h (doprnt): Remove.
2670 * Makefile.in (base_obj): Remove doprnt.o.
2671 * deps.mk (doprnt.o): Remove.
2672
5fdb398c
PE
2673 error: Print 32- and 64-bit integers portably (Bug#8435).
2674 Without this change, on typical 64-bit hosts error ("...%d...", N)
2675 was used to print both 32- and 64-bit integers N, which relied on
2676 undefined behavior.
2677 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
2678 New macro.
2679 * lisp.h (error, verror): Mark as printf-like functions.
2680 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
2681 Report overflow in size calculations when allocating printf buffer.
2682 Do not truncate output string at its first null byte.
2683 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
2684 Truncate the output at a character boundary, since vsnprintf does not
2685 do that.
2686 * charset.c (check_iso_charset_parameter): Convert internal
2687 character to string before calling 'error', since %c now has the
2688 printf meaning.
2689 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
2690 overflow when computing char to be passed to 'error'. Do not
2691 pass Lisp_Object to 'error'; pass the integer instead.
2692 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
2693 formatted with plain %d.
2694
b189fa66
PE
2695 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
2696
bff87ef0
PE
2697 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
2698
7e2cac20
PE
2699 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
2700
ce4d90b5
PE
2701 * xterm.c (x_catch_errors): Remove duplicate declaration.
2702
266c9547
PE
2703 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
2704
79c49ad2
PE
2705 * xdisp.c, lisp.h (message_nolog): Remove; unused.
2706
368f4090
JM
27072011-04-10 Jim Meyering <meyering@redhat.com>
2708
2709 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
2710 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
2711 return ssize_t not "int", and use size_t as the buffer length.
2712 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
2713 * gnutls.h: Update declarations.
2714 * process.c (read_process_output): Use ssize_t, to match.
2715 (send_process): Likewise.
2716
a32d4040
CY
27172011-04-09 Chong Yidong <cyd@stupidchicken.com>
2718
2719 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
2720
8546720e 27212011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 2722
04f2d78b
CB
2723 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
2724 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 2725
8546720e
GM
2726 * xterm.c (handle_one_xevent):
2727 * xmenu.c (create_and_show_popup_menu):
2728 * xselect.c (x_decline_selection_request)
2729 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 2730
0a2f5c1a 27312011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
2732
2733 Fix some uses of `int' instead of EMACS_INT.
2734 * search.c (string_match_1, fast_string_match)
2735 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
2736 (scan_buffer, find_next_newline_no_quit)
2737 (find_before_next_newline, search_command, Freplace_match)
2738 (Fmatch_data): Make some `int' variables be EMACS_INT.
2739
2740 * xdisp.c (display_count_lines): 3rd argument and return value now
2741 EMACS_INT. All callers changed.
2742 (pint2hrstr): Last argument is now EMACS_INT.
2743
2744 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
2745 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
2746 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
2747 (decode_coding_utf_16, decode_coding_emacs_mule)
2748 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
2749 (decode_coding_ccl, decode_coding_charset)
2750 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
2751 (decode_coding_iso_2022, decode_coding_emacs_mule)
2752 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
2753 <char_offset, last_offset>: Declare EMACS_INT.
2754 (encode_coding_utf_8, encode_coding_utf_16)
2755 (encode_coding_emacs_mule, encode_invocation_designation)
2756 (encode_designation_at_bol, encode_coding_iso_2022)
2757 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
2758 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
2759 Declare EMACS_INT.
2760 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
2761 (encode_invocation_designation): Last argument P_NCHARS is now
2762 EMACS_INT.
2763 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
2764 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
2765
2766 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
2767 All users changed.
2768
2769 * ccl.c (Fccl_execute_on_string): Declare some variables
2770 EMACS_INT.
2771
8546720e 27722011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
2773
2774 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
2775
4e19a977
CS
27762011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
2777
2778 * process.c (Fformat_network_address): Doc fix.
2779
87302331
R
27802011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
2781
2782 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
2783
cbb59342
CY
27842011-04-08 Chong Yidong <cyd@stupidchicken.com>
2785
2786 * keyboard.c (read_char): Call Lisp function help-form-show,
2787 instead of using internal_with_output_to_temp_buffer.
2788 (Qhelp_form_show): New var.
e0d38eeb 2789 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
2790
2791 * print.c (internal_with_output_to_temp_buffer): Function deleted.
2792
2793 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
2794
e67a13ab
CY
27952011-04-06 Chong Yidong <cyd@stupidchicken.com>
2796
04f2d78b
CB
2797 * process.c (Flist_processes): Remove to Lisp.
2798 (list_processes_1): Delete.
e67a13ab 2799
973f782d
EZ
28002011-04-06 Eli Zaretskii <eliz@gnu.org>
2801
7c106b1e
EZ
2802 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
2803
973f782d
EZ
2804 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
2805
41cf7d1a 28062011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 2807
ca23cc88
PE
2808 Fix more problems found by GCC 4.6.0's static checks.
2809
f390e2d5
PE
2810 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
2811
42eea0d0
PE
2812 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
2813
b69769da 2814 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 2815
f9541e84
PE
2816 * xdisp.c (vmessage): Mark as a printf-like function.
2817
13841b55
PE
2818 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
2819
c136c10f
PE
2820 * sound.c (sound_warning): Don't crash if arg contains a printf format.
2821
5e2d4a30
PE
2822 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
2823 printf-like functions.
2824 (tiff_load): Add casts to remove these marks before passing them
2825 to system-supplied API.
2826
583f48b9
PE
2827 * eval.c (Fsignal): Remove excess argument to 'fatal'.
2828
b25d760e
PE
2829 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
2830 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
2831 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
2832 directly, rather than having caller test rule sign. This avoids
2833 some unnecessary tests.
2834 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
2835 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
2836 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 2837
bc7b6697 2838 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 2839 (xfont_open): Avoid unnecessary tests.
bc7b6697 2840
27ccc379
PE
2841 * composite.c (composition_gstring_put_cache): Use unsigned integer.
2842
dcd5c89a
PE
2843 * composite.h, composite.c (composition_gstring_put_cache):
2844 Use EMACS_INT, not int, for length.
2845
b13a45c6
PE
2846 * composite.h (COMPOSITION_DECODE_REFS): New macro,
2847 breaking out part of COMPOSITION_DECODE_RULE.
2848 (COMPOSITION_DECODE_RULE): Use it.
2849 * composite.c (get_composition_id): Remove unused local vars,
2850 by using the new macro.
2851
1e792e4d
PE
2852 * textprop.c (set_text_properties_1): Change while to do-while,
2853 since the condition is always true at first.
2854
dc6c6455 2855 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
2856 (interval_deletion_adjustment): Return unsigned value.
2857 All uses changed.
dc6c6455 2858
aba7731a
PE
2859 * process.c (list_processes_1, create_pty, read_process_output):
2860 (exec_sentinel): Remove vars that were set but not used.
afd4052b 2861 (create_pty): Remove unnecessary "volatile"s.
bc57d757 2862 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 2863 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 2864 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 2865
fdfc4bf3
PE
2866 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
2867
fca8fe46 2868 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 2869 (update_syntax_table): Use unsigned instead of int.
fca8fe46 2870
06a0259a 2871 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 2872 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 2873 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 2874
e7b9e80f
PE
2875 * print.c (print_error_message): Avoid int overflow.
2876
56201685
PE
2877 * font.c (font_list_entities): Redo for clarity,
2878 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
2879
78834453 2880 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 2881 (font_score): Avoid potential overflow in diff calculation.
78834453 2882
0bc0b309 2883 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 2884 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 2885
e610eaca
PE
2886 * eval.c (funcall_lambda): Rename local to avoid shadowing.
2887
b895abce
PE
2888 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
2889 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
2890 can always succeed if overflow has undefined behavior.
2891
1f1d9321 2892 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 2893 (wordify): Omit three unnecessary tests.
1f1d9321 2894
c59478bc
PE
2895 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
2896 All callers changed. This avoids the need for an unused var.
2897
79b73827
PE
2898 * casefiddle.c (casify_region): Remove var that is set but not used.
2899
a4db5dfe
PE
2900 * dired.c (file_name_completion): Remove var that is set but not used.
2901
43aae36e
PE
2902 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
2903
2a47c44d 2904 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 2905 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 2906
a37c69bf
PE
2907 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
2908 Check for integer overflow on size calculations.
2909
328ab8e7
PE
2910 * buffer.c (Fprevious_overlay_change): Remove var that is set
2911 but not used.
2912
e5a2a5cb
PE
2913 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
2914 Remove vars that are set but not used.
8d84a6eb 2915 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 2916 (timer_check_2): Mark vars as initialized.
e5a2a5cb 2917
a60e5f68
PE
2918 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
2919
f661cb61 2920 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 2921 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 2922
f0397f5a
PE
2923 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
2924 that are set but not used.
2925
8664db06 2926 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 2927 if XCreateBitmapFromData fails (Bug#8410).
8664db06 2928
6abdaa4a
PE
2929 * xselect.c (x_get_local_selection, x_handle_property_notify):
2930 Remove vars that are set but not used.
2931
0ce7538d 2932 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 2933 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 2934
9ae848fc
PE
2935 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
2936 Remove var that is set but not used.
0b918413
PE
2937 (scroll_bar_windows_size): Now size_t, not int.
2938 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
2939 Check for overflow.
9ae848fc 2940
a5a62657
PE
2941 * xfaces.c (realize_named_face): Remove vars that are set but not used.
2942 (map_tty_color) [!defined MSDOS]: Likewise.
2943
5c5cdd39
PE
2944 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
2945
66ebf983
PE
2946 * coding.c: Remove vars that are set but not used.
2947 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
2948 All callers changed.
2949 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
2950 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
2951 (decode_coding_charset): Remove vars that are set but not used.
2952
1be4d761
PE
2953 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
2954 that is set but not used.
2955
47553fa8
PE
2956 * print.c (print_object): Remove var that is set but not used.
2957
1f7196bf 2958 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
2959 The gnulib version avoids calling malloc in the usual case,
2960 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
2961 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
2962 * filelock.c (current_lock_owner): Likewise.
2963 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
2964 * sysdep.c: Include allocator.h, careadlinkat.h.
2965 (emacs_no_realloc_allocator): New static constant.
2966 (emacs_readlink): New function.
fdb61804
PE
2967 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
2968 ../lib/careadlinkat.h.
d1fdcab7 2969
f84c17c7
SM
29702011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
2971
2972 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
2973 first non-nil return value).
2974
ef3862ad
JD
29752011-04-03 Jan Djärv <jan.h.d@swipnet.se>
2976
2977 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
2978 if not defined (Bug#8403).
2979
376a7006
JB
29802011-04-02 Juanma Barranquero <lekktu@gmail.com>
2981
2982 * xdisp.c (display_count_lines): Remove parameter `start',
2983 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
2984 (get_char_face_and_encoding): Remove parameter `multibyte_p',
2985 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2986 (fill_stretch_glyph_string): Remove parameters `row' and `area',
2987 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
2988 and thereabouts. All callers changed.
2989 (get_per_char_metric): Remove parameter `f', unused since
2990 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
2991
6ca3801d
JM
29922011-04-02 Jim Meyering <meyering@redhat.com>
2993
2994 do not dereference NULL upon failed strdup
2995 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
2996 (ns_get_family): Likewise.
2997
d8e2b5ba
JB
29982011-04-02 Juanma Barranquero <lekktu@gmail.com>
2999
3000 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
3001
8c74fcbd
JD
30022011-04-02 Jan Djärv <jan.h.d@swipnet.se>
3003
3004 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
3005 later (Bug#8403).
3006
7200d79c
SM
30072011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
3008
03408648 3009 Add lexical binding.
7200d79c 3010
03408648
SM
3011 * window.c (Ftemp_output_buffer_show): New fun.
3012 (Fsave_window_excursion):
3013 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
3014
3015 * lread.c (lisp_file_lexically_bound_p): New function.
3016 (Fload): Bind Qlexical_binding.
3017 (readevalloop): Remove `evalfun' arg.
3018 Bind Qinternal_interpreter_environment.
3019 (Feval_buffer): Bind Qlexical_binding.
3020 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
3021 Mark as dynamic.
3022 (syms_of_lread): Declare `lexical-binding'.
3023
3024 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
3025
3026 * keyboard.c (eval_dyn): New fun.
3027 (menu_item_eval_property): Use it.
ca105506
SM
3028
3029 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 3030
03408648
SM
3031 * fns.c (concat, mapcar1): Accept byte-code-functions.
3032
3033 * eval.c (Fsetq): Handle lexical vars.
3034 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
3035 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
3036 (FletX, Flet): Obey lexical binding.
3037 (Fcommandp): Handle closures.
3038 (Feval): New `lexical' arg.
3039 (eval_sub): New function extracted from Feval. Use it almost
3040 everywhere where Feval was used. Look up vars in lexical env.
3041 Handle closures.
3042 (Ffunctionp): Move from subr.el.
3043 (Ffuncall): Handle closures.
3044 (apply_lambda): Remove `eval_flags'.
3045 (funcall_lambda): Handle closures and new byte-code-functions.
3046 (Fspecial_variable_p): New function.
3047 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
3048 but without exporting it to Lisp.
23aba0ea 3049
23aba0ea 3050 * doc.c (Fdocumentation, store_function_docstring):
03408648 3051 * data.c (Finteractive_form): Handle closures.
23aba0ea 3052
03408648
SM
3053 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
3054 interactive spec.
ba83908c 3055
04f2d78b
CB
3056 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
3057 New byte-codes.
03408648
SM
3058 (exec_byte_code): New function extracted from Fbyte_code to handle new
3059 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 3060
03408648 3061 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 3062
03408648 3063 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 3064
e2abce01
JB
30652011-03-31 Juanma Barranquero <lekktu@gmail.com>
3066
3067 * xdisp.c (redisplay_internal): Fix prototype.
3068
63696a73 30692011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 3070
63696a73 3071 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
3072 (try_scrolling): Use it when setting scroll_limit.
3073 Limit scrolling to 100 screen lines.
63696a73
EZ
3074 (redisplay_window): Even when falling back on "recentering",
3075 position point in the window according to scroll-conservatively,
3076 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
3077
3078 (try_scrolling): When point is above the window, allow searching
3079 as far as scroll_max, or one screenful, to compute vertical
3080 distance from PT to the scroll margin position. This prevents
3081 try_scrolling from unnecessarily failing when
3082 scroll-conservatively is set to a value slightly larger than the
3083 window height. Clean up the case of PT below the margin at bottom
3084 of window: scroll_max can no longer be INT_MAX. When aggressive
3085 scrolling is in use, don't let point enter the opposite scroll
3086 margin as result of the scroll.
3087 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
3088 threshold of 100 lines for never-recentering scrolling.
3089
e4cc2dfc
JB
30902011-03-31 Juanma Barranquero <lekktu@gmail.com>
3091
3092 * dispextern.h (move_it_by_lines):
3093 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
3094 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
3095 (message_log_check_duplicate): Remove parameters `prev_bol' and
3096 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
3097 (redisplay_internal): Remove parameter `preserve_echo_area',
3098 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
3099
3100 * indent.c (Fvertical_motion):
3101 * window.c (window_scroll_pixel_based, Frecenter):
3102 Don't pass `need_y_p' to `move_it_by_lines'.
3103
1c470562
SM
31042011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
3105
44f230aa
SM
3106 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
3107 steal a few bits to be more compact.
3108 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
3109 Remove unneeded casts.
3110
1c470562
SM
3111 * bytecode.c (Fbyte_code): CAR and CDR can GC.
3112
888adce9
ZK
31132011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
3114
3115 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
3116 binding" message (bug#7967).
3117
f838ed7b
PE
31182011-03-30 Paul Eggert <eggert@cs.ucla.edu>
3119
77861b95
PE
3120 Fix more problems found by GCC 4.6.0's static checks.
3121
de6dbc14
PE
3122 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
3123 Remove unused local var.
3124
f838ed7b
PE
3125 * editfns.c (Fmessage_box): Remove unused local var.
3126
792c7b2b
PE
3127 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
3128 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3129 Omit unused local vars.
c499e557 3130 * window.c (shrink_windows): Omit unused local var.
b01a1c29 3131 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
3132 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
3133 Omit unused local var.
3134
ba0165e1
PE
3135 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
3136 Don't assume string length fits in int.
32ad8845 3137 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 3138 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 3139
3c59b4c9
PE
3140 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
3141 instead of alloca (Bug#8344).
3142
a3eed478 3143 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 3144 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 3145
eb4d412d
PE
3146 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
3147
1658b401
PE
3148 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
3149 concerns.
3150
3151 * term.c (produce_glyphless_glyph): Remove unnecessary test.
3152
3153 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 3154
9a2c6e05
PE
3155 * keyboard.c (syms_of_keyboard): Use the same style as later
3156 in this function when indexing through an array. This also
3157 works around GCC bug 48267.
3158
03d0a109
PE
3159 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
3160
44f730c8
PE
3161 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
3162
fe75f926
PE
3163 * chartab.c (sub_char_table_ref_and_range): Redo for slight
3164 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
3165
ffa8c828
PE
3166 * keyboard.c, keyboard.h (num_input_events): Now size_t.
3167 This avoids undefined behavior on integer overflow, and is a bit
3168 more convenient anyway since it is compared to a size_t variable.
3169
c5101a77
PE
3170 Variadic C functions now count arguments with size_t, not int.
3171 This avoids an unnecessary limitation on 64-bit machines, which
3172 caused (substring ...) to crash on large vectors (Bug#8344).
3173 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
3174 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 3175 All variadic functions and their callers changed accordingly.
c5101a77
PE
3176 (struct gcpro.nvars): Now size_t, not int. All uses changed.
3177 * data.c (arith_driver, float_arith_driver): Likewise.
3178 * editfns.c (general_insert_function): Likewise.
3179 * eval.c (struct backtrace.nargs, interactive_p)
3180 (internal_condition_case_n, run_hook_with_args, apply_lambda)
3181 (funcall_lambda, mark_backtrace): Likewise.
3182 * fns.c (concat): Likewise.
3183 * frame.c (x_set_frame_parameters): Likewise.
3184 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
3185 0 if not found, not -1. All callers changed.
3186
dd3f25f7
PE
3187 * alloc.c (garbage_collect): Don't assume stack size fits in int.
3188 (stack_copy_size): Now size_t, not int.
3189 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
3190
461c2ab9
JB
31912011-03-28 Juanma Barranquero <lekktu@gmail.com>
3192
3193 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
3194 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3195 All callers changed.
3196
3197 * lisp.h (multibyte_char_to_unibyte):
3198 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
3199 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
3200 * character.h (CHAR_TO_BYTE8):
3201 * cmds.c (internal_self_insert):
3202 * editfns.c (general_insert_function):
3203 * keymap.c (push_key_description):
3204 * search.c (Freplace_match):
3205 * xdisp.c (message_dolog, set_message_1): All callers changed.
3206
f6d62986
SM
32072011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
3208
3209 * keyboard.c (safe_run_hook_funcall): New function.
3210 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
3211 don't set the hook to nil, but remove the offending function instead.
3212 (Qcommand_hook_internal): Remove, unused.
3213 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
3214 Vcommand_hook_internal.
3215
3216 * eval.c (enum run_hooks_condition): Remove.
3217 (funcall_nil, funcall_not): New functions.
3218 (run_hook_with_args): Call each function through a `funcall' argument.
3219 Remove `cond' argument, now redundant.
3220 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
3221 (Frun_hook_with_args_until_failure): Adjust accordingly.
3222 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
3223
1db5b1ad
JB
32242011-03-28 Juanma Barranquero <lekktu@gmail.com>
3225
3226 * dispextern.h (string_buffer_position): Remove declaration.
3227
3228 * print.c (strout): Remove parameter `multibyte', unused since
3229 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
3230
3231 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
3232 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
3233 All callers changed.
3234
3235 * w32.c (_wsa_errlist): Use braces for struct initializers.
3236
3237 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
3238 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
3239 All callers changed.
3240 (string_buffer_position): Likewise. Also, make static (it's never
3241 used outside xdisp.c).
3242 (cursor_row_p): Remove parameter `w', unused since
3243 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
3244 (decode_mode_spec): Remove parameter `precision', introduced during
3245 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
3246 All callers changed.
3247
5ffb62aa
JD
32482011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3249
3250 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
3251
461c2ab9 32522011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
3253
3254 * nsterm.m (ns_menu_bar_is_hidden): New variable.
3255 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
3256 (ns_update_auto_hide_menu_bar): New functions.
3257 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
3258 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
3259 ns_constrain_all_frames.
3260 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
3261 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
3262
5c380ffb
JD
32632011-03-27 Jan Djärv <jan.h.d@swipnet.se>
3264
3265 * nsmenu.m (runDialogAt): Remove argument to timer_check.
3266
9af30bdf
GM
32672011-03-27 Glenn Morris <rgm@gnu.org>
3268
3269 * syssignal.h: Replace RETSIGTYPE with void.
3270 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
3271 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
3272 Replace SIGTYPE with void everywhere.
3273 * s/usg5-4-common.h (SIGTYPE): Remove definition.
3274 * s/template.h (SIGTYPE): Remove commented out definition.
3275
e2abce01
JB
32762011-03-26 Eli Zaretskii <eliz@gnu.org>
3277
3278 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
3279 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
3280
f868cd8a
JB
32812011-03-26 Juanma Barranquero <lekktu@gmail.com>
3282
59eb0929
JB
3283 * w32.c (read_unc_volume): Use parameter `henum', instead of
3284 global variable `wget_enum_handle'.
3285
3286 * keymap.c (describe_vector): Remove parameters `indices' and
3287 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
3288 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
3289
f868cd8a
JB
3290 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
3291
3292 * keyboard.c (timer_check): Remove parameter `do_it_now',
3293 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
3294 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
3295 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
3296
3297 * keyboard.c (read_char):
3298 * w32menu.c (w32_menu_display_help):
3299 * xmenu.c (show_help_event, menu_help_callback):
3300 Adjust calls to `show_help_echo'.
3301
3302 * gtkutil.c (xg_maybe_add_timer):
3303 * keyboard.c (readable_events):
3304 * process.c (wait_reading_process_output):
3305 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
3306
3307 * insdel.c (adjust_markers_gap_motion):
3308 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
3309 (gap_left, gap_right): Don't call it.
3310
2ecf6fdb
CY
33112011-03-25 Chong Yidong <cyd@stupidchicken.com>
3312
3313 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
3314 incurred during fontification.
3315
6b1f9ba4
JB
33162011-03-25 Juanma Barranquero <lekktu@gmail.com>
3317
3318 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
3319 (DEFVAR_PER_BUFFER): Don't pass it.
3320
3321 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
3322 (scrolling_window): Don't pass it.
3323
0f4a96b5
JB
33242011-03-25 Juanma Barranquero <lekktu@gmail.com>
3325
3326 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
3327
3328 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
3329 and `suffix'.
3330 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
3331 of variables specific to SELinux and computation of `encoded_absname'.
3332
3333 * image.c (XPutPixel): Remove unused variable `height'.
3334
3335 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
3336
3337 * unexw32.c (get_section_info): Remove unused variable `section'.
3338
3339 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
3340 (system_process_attributes): Remove unused variable `sess'.
3341 (sys_read): Remove unused variable `err'.
3342
3343 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
3344 (w32_wnd_proc): Remove unused variable `isdead'.
3345 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
3346 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
3347 (x_create_tip_frame): Remove unused variable `tem'.
3348
3349 * w32inevt.c (w32_console_read_socket):
3350 Remove unused variable `no_events'.
3351
3352 * w32term.c (x_draw_composite_glyph_string_foreground):
3353 Remove unused variable `width'.
3354
1149507c
JB
33552011-03-24 Juanma Barranquero <lekktu@gmail.com>
3356
3357 * w32term.c (x_set_glyph_string_clipping):
3358 Don't pass uninitialized region to CombineRgn.
3359
9c88f339
JB
33602011-03-23 Juanma Barranquero <lekktu@gmail.com>
3361
3362 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
3363 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
3364 (Fx_close_connection): Remove unused variable `i'.
3365
3366 * w32font.c (w32font_draw): Return number of glyphs.
3367 (w32font_open_internal): Remove unused variable `i'.
3368 (w32font_driver): Add missing initializer.
3369
3370 * w32menu.c (utf8to16): Remove unused variable `utf16'.
3371 (fill_in_menu): Remove unused variable `items_added'.
3372
3373 * w32term.c (last_mouse_press_frame): Remove static global variable.
3374 (w32_clip_to_row): Remove unused variable `f'.
3375 (x_delete_terminal): Remove unused variable `i'.
3376
3377 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
3378 (NOTHING): Remove unused static global variable.
3379 (uniscribe_check_otf): Remove unused variable `table'.
3380 (uniscribe_font_driver): Add missing initializers.
3381
dee091a3
JD
33822011-03-23 Julien Danjou <julien@danjou.info>
3383
3384 * term.c (Fsuspend_tty, Fresume_tty):
3385 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
3386 * window.c (temp_output_buffer_show):
3387 * insdel.c (signal_before_change):
3388 * frame.c (Fhandle_switch_frame):
3389 * fileio.c (Fdo_auto_save):
3390 * emacs.c (Fkill_emacs):
3391 * editfns.c (save_excursion_restore):
3392 * cmds.c (internal_self_insert):
3393 * callint.c (Fcall_interactively):
3394 * buffer.c (Fkill_all_local_variables):
3395 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
3396 Use Frun_hooks.
0f4a96b5 3397 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
3398 unconditionnaly since it does the check itself.
3399
2c520ab5 34002011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 3401
c9c49752
PE
3402 Fix more problems found by GCC 4.5.2's static checks.
3403
8abc3f12
PE
3404 * coding.c (encode_coding_raw_text): Avoid unnecessary test
3405 the first time through the loop, since we know p0 < p1 then.
3406 This also avoids a gcc -Wstrict-overflow warning.
3407
a2d26660
PE
3408 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
3409 leading to a memory leak, possible in functions like
3410 load_charset_map_from_file that can allocate an unbounded number
b12ef411 3411 of objects (Bug#8318).
a2d26660 3412
916c72e9
PE
3413 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
3414 that could (at least in theory) be that large.
3415
19ab8a18
PE
3416 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
3417 This is less likely to overflow, and avoids undefined behavior if
3418 overflow does occur. All callers changed. Use strtoul to scan
3419 for the unsigned long integer.
b7cbbd6f
PE
3420 (pint2hrstr): Simplify and tune code slightly.
3421 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 3422
f0641eff
PE
3423 * scroll.c (do_scrolling): Work around GCC bug 48228.
3424 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
3425
7f650bb9
PE
3426 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
3427 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
3428 (validate_x_resource_name): Simplify count usage.
3429 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 3430
37dd57d1
PE
3431 * fileio.c (Fcopy_file): Report error if fchown or fchmod
3432 fail (Bug#8306).
81e56e61 3433
699979fc 3434 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 3435
401bf9b4
PE
3436 * process.c (Fmake_network_process): Use socklen_t, not int,
3437 where POSIX says socklen_t is required in portable programs.
3438 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 3439 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
3440 (Fmake_network_process, server_accept_connection):
3441 (wait_reading_process_output, read_process_output):
3442 Likewise.
3443
b93aacde
PE
3444 * process.c: Rename or move locals to avoid shadowing.
3445 (list_processes_1, Fmake_network_process):
3446 (read_process_output_error_handler, exec_sentinel_error_handler):
3447 Rename or move locals.
4dc343ee 3448 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 3449 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 3450 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 3451 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 3452 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 3453
af8a867c 3454 Make tparam.h and terminfo.c consistent.
44f230aa
SM
3455 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
3456 Include tparam.h instead, since it declares them.
af8a867c
PE
3457 * cm.h (PC): Remove extern decl; tparam.h now does this.
3458 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
3459 * terminfo.c: Include tparam.h, to check interfaces.
3460 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
3461 (tparam): Adjust signature to match interface in tparam.h;
3462 this removes some undefined behavior. Check that outstring and len
3463 are zero, which they always are with Emacs.
3464 * tparam.h (PC, BC, UP): New extern decls.
3465
0248044d 3466 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 3467 (xftfont_open): Rename locals to avoid shadowing.
0248044d 3468
8ff096c1 3469 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
3470 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
3471 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 3472 (ftfont_list): Remove unused local.
49eaafba
PE
3473 (get_adstyle_property, ftfont_pattern_entity):
3474 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
3475 Rename locals to avoid shadowing.
8ff096c1 3476
e2be39f6
PE
3477 * xfont.c (xfont_list_family): Mark var as initialized.
3478
c9735e30
PE
3479 * xml.c (make_dom): Now static.
3480
8f5201ae
PE
3481 * composite.c (composition_compute_stop_pos): Rename local to
3482 avoid shadowing.
b246f932
PE
3483 (composition_reseat_it): Remove unused locals.
3484 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 3485 (composition_update_it): Mark var as initialized.
11b61122
PE
3486 (find_automatic_composition): Mark vars as initialized,
3487 with a FIXME (Bug#8290).
8f5201ae 3488
760fbc2c
PE
3489 character.h: Rename locals to avoid shadowing.
3490 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
3491 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
3492 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
3493 (BUF_DEC_POS): Be more systematic about renaming local temporaries
3494 to avoid shadowing.
3495
ff08eb85
PE
3496 * textprop.c (property_change_between_p): Remove; unused.
3497
fc7bf025
PE
3498 * intervals.c (interval_start_pos): Now static.
3499
235d7abc
PE
3500 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
3501
44f230aa
SM
3502 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
3503 Rename locals to avoid shadowing.
3e7d6594 3504
50060332
PE
3505 * sound.c (wav_play, au_play, Fplay_sound_internal):
3506 Fix pointer signedness.
d01f234b 3507 (alsa_choose_format): Remove unused local var.
c83b8872
PE
3508 (wav_play): Initialize a variable to 0, to prevent undefined
3509 behavior (Bug#8278).
50060332 3510
c4fc4e30
PE
3511 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
3512
918436ed
PE
3513 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
3514
c939f91b
PE
3515 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
3516 clobbering (Bug#8298).
b9c7f648
PE
3517 * sysdep.c (sys_subshell): Likewise.
3518 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 3519
6bd8c144
PE
3520 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
3521 This should get cleaned up, so that child_setup has the
3522 same signature on all platforms.
3523
7710357c 3524 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 3525 (relocate_fd): Rename locals to avoid shadowing.
7710357c 3526
c59da222
CY
35272011-03-22 Chong Yidong <cyd@stupidchicken.com>
3528
3529 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
3530 not to be necessary, and produces flickering.
3531
66b87493
GM
35322011-03-20 Glenn Morris <rgm@gnu.org>
3533
3534 * config.in: Remove file.
3535
45b6f6d5
JB
35362011-03-20 Juanma Barranquero <lekktu@gmail.com>
3537
3538 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
3539 are now in src/globals.h.
3540 (syms_of_minibuf): Remove spurious & from previous change.
3541
3ec03f7e
LL
35422011-03-20 Leo <sdl.web@gmail.com>
3543
3544 * minibuf.c (completing-read-function): New variable.
3545 (completing-read-default): Rename from completing-read.
3546 (completing-read): Call completing-read-function.
3547
b14e3e21
CY
35482011-03-19 Juanma Barranquero <lekktu@gmail.com>
3549
3550 * xfaces.c (Fx_load_color_file):
3551 Read color file from absolute filename (bug#8250).
3552
f2b726e6
JB
35532011-03-19 Juanma Barranquero <lekktu@gmail.com>
3554
3555 * makefile.w32-in: Update dependencies.
3556
09f6ff02
EZ
35572011-03-17 Eli Zaretskii <eliz@gnu.org>
3558
3559 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
3560
29a6015a
PE
35612011-03-17 Paul Eggert <eggert@cs.ucla.edu>
3562
a3a6c54e
PE
3563 Fix more problems found by GCC 4.5.2's static checks.
3564
b766f867
PE
3565 * process.c (make_serial_process_unwind, send_process_trap):
3566 (sigchld_handler): Now static.
3567
be02381c
PE
3568 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
3569 That way, the code declares only the vars that it needs.
3570 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
3571 * s/cygwin.h (PTY_ITERATION): Likewise.
3572 * s/darwin.h (PTY_ITERATION): Likewise.
3573 * s/gnu-linux.h (PTY_ITERATION): Likewise.
3574
57048744
PE
3575 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
3576 * process.c (allocate_pty): Don't declare stb unless it's needed.
3577
7914961c 3578 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
3579 (CONSTANTLIM): Remove; unused.
3580 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
3581 Define only if needed.
7914961c 3582
b3967b18
PE
3583 * unexelf.c (unexec): Name an expression,
3584 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
3585 Use a different way to cause a compilation error if anyone uses
3586 n rather than nn, a way that does not involve shadowing.
73366a00 3587 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 3588
29a6015a
PE
3589 * deps.mk (unexalpha.o): Remove; unused.
3590
43cfc33e 3591 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 3592 * unexec.h: New file.
ce701a33
PE
3593 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
3594 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
3595 Depend on unexec.h.
3596 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
3597 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
3598 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 3599 Change as necessary to match prototype in unexec.h.
ce701a33 3600
01f44d5a
PE
3601 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
3602 shadowing.
4f63c6bb 3603 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 3604
a6670b0b
PE
3605 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
3606 Rename locals to avoid shadowing.
3607
cef2010d 3608 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 3609 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 3610
d4d7173a
PE
3611 * print.c (Fredirect_debugging_output): Fix pointer signedess.
3612
f08b802a
PE
3613 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
3614 warning when compiling print.c.
3615
3ddb0639
PE
3616 * font.c (font_unparse_fcname): Abort in an "impossible" situation
3617 instead of using an uninitialized var.
5ad03b97 3618 (font_sort_entities): Mark var as initialized.
3ddb0639 3619
170a2692
PE
3620 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
3621
e663c700
PE
3622 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
3623 pointers to constants.
89bc529a 3624 (font_parse_fcname): Remove unused vars.
7b81e2d0 3625 (font_delete_unmatched): Now static.
ea838e10 3626 (font_get_spec): Remove; unused.
13a547c6
PE
3627 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
3628 (font_update_drivers, Ffont_get_glyphs, font_add_log):
3629 Rename or move locals to avoid shadowing.
e663c700 3630
2a80c887 3631 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 3632 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 3633
1384fa33 3634 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 3635 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 3636
8b2c52e9
PE
3637 * alloc.c (mark_backtrace): Move decl from here ...
3638 * lisp.h: ... to here, so that it can be checked.
3639
475545b5 3640 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 3641 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
3642 (lisp_indirect_variable): Name an expression,
3643 to avoid gcc -Wbad-function-cast warning.
1faed8ae 3644 (Fdefvar): Rename locals to avoid shadowing.
475545b5 3645
b1349114 3646 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 3647 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 3648 Use const pointer when appropriate.
b1349114 3649
a2928364
PE
3650 * lisp.h (get_system_name, get_operating_system_release):
3651 Move decls here, to check interfaces.
3652 * process.c (get_operating_system_release): Move decl to lisp.h.
3653 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
3654 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
3655 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
3656 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
3657 (Fformat_time_string, Fencode_time, Finsert_char):
3658 (Ftranslate_region_internal, Fformat):
3659 Rename or remove local vars to avoid shadowing.
9710023e 3660 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 3661
a415e694
PE
3662 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
3663 avoid shadowing.
3664
8ef4622d
PE
3665 * lisp.h (eassert): Check that the argument compiles, even if
3666 ENABLE_CHECKING is not defined.
3667
946f9a5b
PE
3668 * data.c (Findirect_variable): Name an expression, to avoid
3669 gcc -Wbad-function-cast warning.
112396d6 3670 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 3671 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
3672 (Fmake_variable_buffer_local, Fmake_local_variable):
3673 Mark variables as initialized.
52746918 3674 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 3675
e5aab7e7 3676 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
3677 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
3678 Rename locals to avoid shadowing.
dff45157
PE
3679 (mark_stack): Move local variables into the #ifdef region where
3680 they're used.
7bc26fdb
PE
3681 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
3682 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
3683 needed otherwise.
3684 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
3685 (GC_STRING_CHARS): Remove; not used.
d40d4be1 3686 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 3687
e5aab7e7
PE
3688 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
3689 avoids undefined behavior in theory.
3690
4da60324
PE
3691 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
3692
88043301
PE
3693 Use functions, not macros, for up- and down-casing (Bug#8254).
3694 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3695 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
3696 to use the following functions instead of these macros.
3697 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
3698 EMACS_INT, since callers assume the returned value fits in int.
3699 (upcase1): Likewise, for UPCASE_TABLE.
3700 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 3701 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 3702 the race-condition problem in the old DOWNCASE.
88043301 3703
19ed5445
PE
3704 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
3705 Rename locals to avoid shadowing.
3706 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
3707 (regex_compile, re_search_2, re_match_2_internal):
3708 Remove unused local vars.
952db0d7
PE
3709 (FREE_VAR): Rewrite so as not to use empty "else",
3710 which gcc can warn about.
da053e48 3711 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
3712 (RETALLOC_IF): Define only if needed.
3713 (WORDCHAR_P): Likewise. This one is never needed, but is used
3714 only in a comment talking about a compiler bug, so put inside
3715 the #if 0 of that comment.
3716 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
3717 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
3718 Remove; unused.
19ed5445 3719
1f3561e4 3720 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
3721 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
3722 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 3723
ded6f8f7
PE
3724 * search.c (simple_search): Remove unused var.
3725
dbd37a95
PE
3726 * dired.c (compile_pattern): Move decl from here ...
3727 * lisp.h: ... to here, so that it can be checked.
3728 (struct re_registers): New forward decl.
3729
7e47afad
PE
3730 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
3731
85f24f61
PE
3732 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
3733 All uses changed.
3734 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
3735 Rename locals to avoid shadowing.
5671df8f 3736 (Fvertical_motion): Mark locals as initialized.
85f24f61 3737
181aa2be 3738 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 3739 (casify_region): Mark local as initialized.
181aa2be 3740
930d429c
PE
3741 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
3742
7082eac6
PE
3743 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
3744 New macros, so that the caller can use some names other than
3745 gcpro1, gcpro2, etc.
3746 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
3747 of the new macros.
3748 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
3749 argument, for consistency with GCPRO2_VAR, etc: it is now the
3750 prefix of the variable, not the variable itself. All uses
3751 changed.
38b2c076
PE
3752 * dired.c (directory_files_internal, file_name_completion):
3753 Rename locals to avoid shadowing.
3754
15206ed9
PE
3755 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
3756 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
3757 dired.c's scmp function, had undefined behavior.
3758 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
3759 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
3760 * buffer.h: ... to here, because these macros use current_buffer,
3761 and the new implementation with inline functions needs to have
3762 current_buffer in scope now, rather than later when the macros
3763 are used.
3764 (downcase, upcase1): New static inline functions.
3765 (DOWNCASE, UPCASE1): Reimplement using these functions.
3766 This avoids undefined behavior in expressions like
3767 DOWNCASE (x) == DOWNCASE (y), which previously suffered
3768 from race conditions in accessing the global variables
3769 case_temp1 and case_temp2.
3770 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
3771 * lisp.h (case_temp1, case_temp2): Remove their decls.
3772 * character.h (ASCII_CHAR_P): Move from here ...
3773 * lisp.h: ... to here, so that the inline functions mentioned
3774 above can use them.
3775
4a6bea26
PE
3776 * dired.c (directory_files_internal_unwind): Now static.
3777
f14b7e14
PE
3778 * fileio.c (file_name_as_directory, directory_file_name):
3779 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
3780 Now static.
2893f146
PE
3781 (file_name_as_directory): Use const pointers when appropriate.
3782 (Fexpand_file_name): Likewise. In particular, newdir might
3783 point at constant storage, so make it a const pointer.
fd4ead52 3784 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
3785 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
3786 signedness issues.
f839df0c
PE
3787 (Fset_file_times, Finsert_file_contents, auto_save_error):
3788 Rename locals to avoid shadowing.
f14b7e14 3789
5716756e 3790 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
3791 (Ftry_completion, Fall_completions): Rename or remove locals
3792 to avoid shadowing.
5716756e 3793
b4c3046a
PE
3794 * marker.c (bytepos_to_charpos): Remove; unused.
3795
b45db522
PE
3796 * lisp.h (verify_bytepos, count_markers): New decls,
3797 so that gcc does not warn that these functions aren't declared.
3798
85876d07
PE
3799 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
3800 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 3801 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 3802 (copy_text): Remove unused local var.
85876d07 3803
03d78a21 3804 * filelock.c (within_one_second): Now static.
b3dd38ab 3805 (lock_file_1): Rename local to avoid shadowing.
03d78a21 3806
5df8f01b
PE
3807 * buffer.c (fix_overlays_before): Mark locals as initialized.
3808 (fix_start_end_in_overlays): Likewise. This function should be
3809 simplified by using pointers-to-pointers, but that's a different
3810 matter.
b1d876f1 3811 (switch_to_buffer_1): Now static.
8f54f30a
PE
3812 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
3813 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 3814
a70072c9 3815 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 3816 Fix pointer signedness issue.
edced198
PE
3817 (sys_subshell): Mark local as volatile if checking for lint,
3818 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 3819 (MAXPATHLEN): Define only if needed.
a70072c9 3820
a0977c44
PE
3821 * process.c (serial_open, serial_configure): Move decls from here ...
3822 * systty.h: ... to here, so that they can be checked.
3823
a884fdcc
PE
3824 * fns.c (get_random, seed_random): Move extern decls from here ...
3825 * lisp.h: ... to here, so that they can be checked.
3826
604efe86 3827 * sysdep.c (reset_io): Now static.
b8950c94 3828 (wait_for_termination_signal): Remove; unused.
604efe86 3829
38fc62d9
PE
3830 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
3831 (copy_keymap_item, append_key, push_text_char_description):
3832 Now static.
1004a21a 3833 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 3834 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
3835 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
3836 (describe_map_tree):
3837 Rename locals to avoid shadowing.
38fc62d9 3838
2f2650da
PE
3839 * keyboard.c: Declare functions static if they are not used elsewhere.
3840 (echo_char, echo_dash, cmd_error, top_level_2):
3841 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
3842 (read_char, kbd_buffer_get_event, make_lispy_position):
3843 (make_lispy_event, make_lispy_movement, apply_modifiers):
3844 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
3845 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
3846 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 3847 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 3848 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 3849
a053e86c 3850 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
3851 (mark_kboards): Move decl here ...
3852 * alloc.c (mark_kboards): ... from here.
a053e86c 3853
4752793e
PE
3854 * lisp.h (force_auto_save_soon): New decl.
3855
74f10ca7 3856 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
3857 (DEFINE_DUMMY_FUNCTION): New macro.
3858 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
3859 Use it.
c03cd23f
PE
3860 (main): Add casts to avoid warnings
3861 if GCC considers string literals to be constants.
74f10ca7 3862
022e70d4
PE
3863 * lisp.h (fatal_error_signal): Add decl, since it's exported.
3864
59d6fe83
PE
3865 * dbusbind.c: Pointer signedness fixes.
3866 (xd_signature, xd_append_arg, xd_initialize):
3867 (Fdbus_call_method, Fdbus_call_method_asynchronously):
3868 (Fdbus_method_return_internal, Fdbus_method_error_internal):
3869 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
3870 (Fdbus_register_signal): Use SSDATA when the context wants char *.
3871
78320123
PE
3872 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
3873 if GCC considers string literals to be constants.
49cebcca 3874 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 3875
35ac2a97
SM
38762011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
3877
fb103ca9
SM
3878 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
3879 (print_preprocess, print_object): New macro to fix last change.
3880
35ac2a97
SM
3881 * print.c (print_preprocess): Don't forget font objects.
3882
62973b41
JB
38832011-03-16 Juanma Barranquero <lekktu@gmail.com>
3884
3885 * emacs.c (USAGE3): Doc fixes.
3886
0e48bb22
AS
38872011-03-15 Andreas Schwab <schwab@linux-m68k.org>
3888
3889 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
3890 structure.
3891
7684e57b
JB
38922011-03-14 Juanma Barranquero <lekktu@gmail.com>
3893
3894 * lisp.h (VWindow_system, Qfile_name_history):
3895 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
3896 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
3897 (w32_system_caret_x, w32_system_caret_y): Declare extern.
3898
3899 * w32select.c: Don't #include "keyboard.h".
c96bbc66 3900 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
3901
3902 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
3903 * w32console.c (detect_input_pending, read_input_pending)
3904 (encode_terminal_code):
3905 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
3906 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
3907 (w32_system_caret_y, Qfile_name_history):
3908 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
3909 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
3910 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
3911 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
3912 * w32proc.c (Qlocal, report_file_error):
3913 * w32term.c (Vwindow_system, updating_frame):
3914 * w32uniscribe.c (initialized, uniscribe_font_driver):
3915 Remove unneeded extern declarations.
3916
2aa46d6c
CY
39172011-03-14 Chong Yidong <cyd@stupidchicken.com>
3918
c96bbc66 3919 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 3920
cffc6f3b
CY
39212011-03-13 Chong Yidong <cyd@stupidchicken.com>
3922
3923 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
3924 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
3925 These macros can no longer be used for assignment.
3926
44f230aa
SM
3927 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
3928 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
3929 (record_buffer_markers, fetch_buffer_markers): New functions for
3930 recording and fetching special buffer markers.
3931 (set_buffer_internal_1, set_buffer_temp): Use them.
3932
3933 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
3934
3935 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
3936
3937 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
3938 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
3939
3940 * xdisp.c (hscroll_window_tree):
3941 (reconsider_clip_changes): Use PT instead of BUF_PT.
3942
d251f04b
EZ
39432011-03-13 Eli Zaretskii <eliz@gnu.org>
3944
3945 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
3946 $(EMACS_ROOT)/lib/intprops.h.
3947
f0c77cd1
PE
39482011-03-13 Paul Eggert <eggert@cs.ucla.edu>
3949
3eca4629
PE
3950 Fix more problems found by GCC 4.5.2's static checks.
3951
7c86ee98
PE
3952 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
3953 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
3954 (xg_free_frame_widgets): Make it clear that a local variable is
3955 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
3956 (gdk_window_get_screen): Make it clear that this macro is needed
3957 only if USE_GTK_TOOLTIP.
1e5524e7
PE
3958 (int_gtk_range_get_value): New function, which avoids a diagnostic
3959 from gcc -Wbad-function-cast.
3960 (xg_set_toolkit_scroll_bar_thumb): Use it.
3961 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
3962 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
3963 (get_utf8_string, xg_get_file_with_chooser):
3964 Rename locals to avoid shadowing.
3965 (create_dialog): Move locals to avoid shadowing.
7c86ee98 3966
41729b81
PE
3967 * xgselect.c (xg_select): Remove unused var.
3968
f0c77cd1
PE
3969 * image.c (four_corners_best): Mark locals as initialized.
3970 (gif_load): Initialize transparent_p to zero (Bug#8238).
3971 Mark another local as initialized.
ec6cf4c6 3972 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 3973
ce0ad53d 3974 * image.c (clear_image_cache): Now static.
d5d5a617 3975 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 3976 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
3977 (x_edge_detection): Remove unnecessary cast that
3978 gcc -Wbad-function-cast diagnoses.
2037898d 3979 (gif_load): Fix pointer signedness.
6ae141d6
PE
3980 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
3981 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 3982
33383987 39832011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 3984
d32df629
PE
3985 Improve quality of tests for time stamp overflow.
3986 For example, without this patch (encode-time 0 0 0 1 1
3987 1152921504606846976) returns the obviously-bogus value (-948597
3988 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
3989 reports time overflow. See
3990 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
3991 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
3992 * editfns.c: Include limits.h and intprops.h.
3993 (TIME_T_MIN, TIME_T_MAX): New macros.
3994 (time_overflow): Move earlier, to before first use.
3995 (hi_time, lo_time): New functions, for an accurate test for
3996 out-of-range times.
3997 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
3998 (Fget_internal_run_time): Don't assume time_t fits in int.
3999 (make_time): Use list2 instead of Fcons twice.
4000 (Fdecode_time): More accurate test for out-of-range times.
4001 (check_tm_member): New function.
4002 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
4003 (lisp_time_argument): Don't rely on undefined left-shift and
4004 right-shift behavior when checking for time stamp overflow.
8be6f318 4005
fe31d94c
PE
4006 * editfns.c (time_overflow): New function, refactoring common code.
4007 (Fformat_time_string, Fdecode_time, Fencode_time):
4008 (Fcurrent_time_string): Use it.
4009
8be6f318
PE
4010 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
4011 * dired.c (make_time): Move to ...
4012 * editfns.c (make_time): ... here.
4013 * systime.h: Note the move.
4014
09d9db2c 40152011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 4016
126bc0dc
YM
4017 * fringe.c (update_window_fringes): Remove unused variables.
4018
c47cbdfd
YM
4019 * unexmacosx.c (copy_data_segment): Also copy __got section.
4020 (Bug#8223)
4021
7ac80be9
EZ
40222011-03-12 Eli Zaretskii <eliz@gnu.org>
4023
c96bbc66 4024 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
4025 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
4026 Constify `char *' arguments and their references according to
4027 prototypes in tparam.h.
4028
ecb0f94d 4029 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 4030
7ac80be9
EZ
4031 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
4032 Adapt all references accordingly.
4033
4034 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
4035
ef1fd07e
TT
40362011-03-11 Tom Tromey <tromey@redhat.com>
4037
4038 * buffer.c (syms_of_buffer): Remove obsolete comment.
4039
7ef4b50c
EZ
40402011-03-11 Eli Zaretskii <eliz@gnu.org>
4041
4042 * termhooks.h (encode_terminal_code): Declare prototype.
4043
4044 * msdos.c (encode_terminal_code): Don't declare prototype.
4045
4046 * term.c (encode_terminal_code): Now external again, used by
4047 w32console.c and msdos.c.
4048
44f230aa
SM
4049 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
4050 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 4051
4b1ec863 40522011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 4053
1714f52b 4054 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 4055
4b1ec863
PE
4056 * fringe.c (update_window_fringes): Mark locals as initialized
4057 (Bug#8227).
4058 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 4059
524c7aa6
PE
4060 * alloc.c (mark_fringe_data): Move decl from here ...
4061 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
4062 to check its interface.
4063 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
4064
a5c0af81 4065 * fontset.c (free_realized_fontset): Now static.
7519b8cd 4066 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 4067 (fontset_font): Mark local as initialized.
a9a06e0b 4068 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 4069
b4716021
PE
4070 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
4071
811e9bac 4072 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 4073 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
4074 (x_own_selection, Fx_disown_selection_internal): Rename locals
4075 to avoid shadowing.
4076 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 4077
7e3ab302
PE
4078 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
4079 so that the caller can use some name other than gcpro1.
4080 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
4081 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4082 (Fx_backspace_delete_keys_p):
4083 Use them to avoid shadowing, and rename vars to avoid shadowing.
4084 (x_decode_color, x_set_name, x_window): Now static.
6b437900 4085 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 4086 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
4087 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
4088 Remove unused locals.
7e3ab302
PE
4089 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
4090 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
4091 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
4092 macros.
f78faa98 4093
e2b13473
PE
4094 * xterm.h (x_mouse_leave): New decl.
4095
77f23912
PE
4096 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
4097 Remove unused functions.
cdf4ba58
PE
4098 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
4099 (x_calc_absolute_position): Now static.
7411c686 4100 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 4101 Don't declare local "event" unless it's used.
ed7bf3a5
PE
4102 (x_iconify_frame, x_free_frame_resources): Don't declare locals
4103 unless they are used.
38d0b34a
PE
4104 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
4105 (x_fatal_error_signal): Remove; not used.
a6067996
PE
4106 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
4107 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
4108 (x_error_catcher, x_connection_closed, x_error_handler):
4109 (x_error_quitter, xembed_send_message, x_iconify_frame):
4110 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 4111 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 4112 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 4113
44f230aa
SM
4114 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
4115 Rename or move locals to avoid shadowing.
6b463e58 4116 (tty_defined_color, merge_face_heights): Now static.
5967d051 4117 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
4118 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
4119 does not deduce is never used uninitialized.
73719eba
PE
4120 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
4121 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 4122
426994c3 4123 * terminal.c (store_terminal_param): Now static.
5489860b 4124
032f1620 4125 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 4126 (set_frame_menubar): Remove unused local.
d4323972 4127 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
4128 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
4129 since they might point to immutable storage.
281585b0
PE
4130 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
4131 since it's unused otherwise.
032f1620 4132
367c19e5 4133 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 4134 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
4135 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
4136 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 4137 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
4138 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
4139 does not deduce are never used uninitialized.
70739cbe 4140
07b48fa9
PE
4141 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
4142
8868a238 4143 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
4144 * window.c (window_loop, size_window):
4145 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 4146
7e5cf297 4147 * window.c (display_buffer): Now static.
d6550a9f
PE
4148 (size_window): Mark variables that gcc -Wuninitialized
4149 does not deduce are never used uninitialized.
a586633d
PE
4150 * window.h (check_all_windows): New decl, to forestall
4151 gcc -Wmissing-prototypes diagnostic.
5b555da1 4152 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 4153
f6095868
PE
4154 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
4155 shadowing.
4156 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
4157 Include <limits.h>.
4158 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
4159 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
4160 (load_charset_map): Mark variables that gcc -Wuninitialized
4161 does not deduce are never used uninitialized.
53df7c11 4162 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 4163
f38b440c
PE
4164 * coding.c (coding_set_source, coding_set_destination):
4165 Use "else { /* comment */ }" rather than "else /* comment */;"
4166 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
4167 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
4168 a block, when the outer 'i' will do.
4169 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
4170 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
4171 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
4172 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
4173 (Fdecode_sjis_char, Fdefine_coding_system_internal):
4174 Rename locals to avoid shadowing.
4175 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
4176 * coding.c (emacs_mule_char, encode_invocation_designation):
4177 Now static, since they're not used elsewhere.
413bb2db 4178 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 4179 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
4180 (decode_coding_emacs_mule): Mark variables that gcc
4181 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
4182 (detect_coding_iso_2022): Initialize a local variable that might
4183 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 4184 this initialization is needed. (Bug#8211)
5f58e762
PE
4185 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
4186 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
4187 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
4188 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
4189 Remove unused macros.
f38b440c 4190
232b38b9 4191 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 4192 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 4193 * character.c (string_count_byte8): Likewise.
232b38b9 4194
fb90da1b
PE
4195 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
4196 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
4197
fb93dbc2
PE
4198 * chartab.c (copy_sub_char_table): Now static, since it's not used
4199 elsewhere.
5c156ace
PE
4200 (sub_char_table_ref_and_range, char_table_ref_and_range):
4201 Rename locals to avoid shadowing.
bbcd0949 4202 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 4203
7d3b3862 4204 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 4205 (BIDI_BOB): Remove unused macro.
7d3b3862 4206
6be7d3da
PE
4207 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
4208 deduce are never used uninitialized.
c2ed9c8b 4209 * term.c (encode_terminal_code): Likewise.
6be7d3da 4210
75f8807f 4211 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 4212
50938595
PE
4213 * tparam.h: New file.
4214 * term.c, tparam.h: Include it.
4215 * deps.mk (term.o, tparam.o): Depend on tparam.h.
4216 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
4217 Move these decls to tparam.h, and make them agree with what
4218 is actually in tparam.c. The previous trick of using incompatible
4219 decls in different modules does not conform to the C standard.
4220 All callers of tparam changed to use tparam's actual API.
4221 * tparam.c (tparam1, tparam, tgoto):
4222 Use const pointers where appropriate.
4223
fbceeba2
PE
4224 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
4225 * cm.h (struct cm): Likewise.
4226 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
4227 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
4228 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
4229 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
4230 (turn_on_face, init_tty): Likewise.
4231 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 4232
7f3f1250
PE
4233 * term.c (term_mouse_position): Rename local to avoid shadowing.
4234
e6ca6543
PE
4235 * alloc.c (mark_ttys): Move decl from here ...
4236 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
4237
c40f8d15
AS
42382011-03-11 Andreas Schwab <schwab@linux-m68k.org>
4239
4240 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
4241
cfe0661d
JB
42422011-03-09 Juanma Barranquero <lekktu@gmail.com>
4243
4244 * search.c (compile_pattern_1): Remove argument regp, unused since
4245 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
4246 (compile_pattern): Don't pass it.
4247
0afb4571
J
42482011-03-08 Jan Djärv <jan.h.d@swipnet.se>
4249
4250 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
4251 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
4252 for ! HAVE_GTK3.
4253 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
4254
4255 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
4256
4257 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
4258 gdk_window_get_screen, gdk_window_get_geometry,
4259 gdk_x11_window_lookup_for_display and GDK_KEY_g.
4260 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
4261 (xg_get_pixbuf_from_pixmap): New function.
4262 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
4263 to Pixmap, take frame as parameter, remove GdkColormap parameter.
4264 Call xg_get_pixbuf_from_pixmap instead of
4265 gdk_pixbuf_get_from_drawable.
4266 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
4267 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
4268 (xg_check_special_colors): Use GtkStyleContext and its functions
4269 for HAVE_GTK3.
4270 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
4271 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
4272 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
4273 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
4274 Call gtk_widget_get_preferred_size.
0afb4571
J
4275 (xg_frame_resized): gdk_window_get_geometry only takes 5
4276 parameters.
44f230aa
SM
4277 (xg_win_to_widget, xg_event_is_for_menubar):
4278 Call gdk_x11_window_lookup_for_display.
0afb4571
J
4279 (xg_set_widget_bg): New function.
4280 (delete_cb): New function.
895009e1 4281 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
4282 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
4283 (xg_set_background_color): Call xg_set_widget_bg.
4284 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
4285 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
4286 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
4287 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
4288 if ! HAVE_GTK3.
4289 (update_frame_tool_bar): Call gtk_widget_hide.
4290 (xg_initialize): Use GDK_KEY_g.
4291
4292 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
4293 if ! HAVE_GTK3
4294 (x_session_initialize): Call gdk_x11_set_sm_client_id.
4295
4296 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
4297 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
4298 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
4299
1c2cc4ef
JB
43002011-03-08 Juanma Barranquero <lekktu@gmail.com>
4301
4302 * w32xfns.c (select_palette): Check success of RealizePalette against
4303 GDI_ERROR, not zero.
4304
33383987 4305See ChangeLog.11 for earlier changes.
aac0c6e3
MR
4306
4307;; Local Variables:
4308;; coding: utf-8
aac0c6e3
MR
4309;; End:
4310
33383987 4311 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
4312
4313 This file is part of GNU Emacs.
4314
4315 GNU Emacs is free software: you can redistribute it and/or modify
4316 it under the terms of the GNU General Public License as published by
4317 the Free Software Foundation, either version 3 of the License, or
4318 (at your option) any later version.
4319
4320 GNU Emacs is distributed in the hope that it will be useful,
4321 but WITHOUT ANY WARRANTY; without even the implied warranty of
4322 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
4323 GNU General Public License for more details.
4324
4325 You should have received a copy of the GNU General Public License
4326 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.