* fns.c (vector): Remove; this old hack is no longer needed.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
1086c095
PE
3 * fns.c (vector): Remove; this old hack is no longer needed.
4
2baccd04 5 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6 Remove unused var.
dde42981 7 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 8
3565b346
PE
9 * xrdb.c (x_load_resources) [!USE_MOTIF]: Omit unused local.
10
436c16df 11 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12 (x_window): Rename locals to avoid shadowing.
dc5ddd85 13 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 14
92bb796d 15 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 16 (x_term_init): Remove local to avoid shadowing.
92bb796d 17
764430a3 18 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
19
20 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
21 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
22
4170f62f 232011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 24
71b41406
PE
25 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
26
9587a89d
PE
27 emacs_write: Accept and return EMACS_INT for sizes.
28 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
29 et seq.
30 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
31 Accept and return EMACS_INT.
32 (emacs_gnutls_write): Return the number of bytes written on
33 partial writes.
34 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
35 (emacs_read, emacs_write): Remove check for negative size, as the
36 Emacs source code has been audited now.
9587a89d
PE
37 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
38 (emacs_read, emacs_write): Use it.
273a5f82
PE
39 * process.c (send_process): Adjust to the new signatures of
40 emacs_write and emacs_gnutls_write. Do not attempt to store
41 a byte offset into an 'int'; it might overflow.
9587a89d 42 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 43
3e047f51
PE
44 * sound.c: Don't assume sizes fit in 'int'.
45 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 46 Return EMACS_INT, not int.
3e047f51 47 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
48 Accept EMACS_INT, not int.
49 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
50 record read return values.
51
cc39a9db
BK
522011-04-15 Ben Key <bkey76@gmail.com>
53
54 * keyboard.c (Qundefined): Don't declare static since it is
55 used in nsfns.m.
56 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
57 declare static since they are used in nsfont.m.
58
6c60eb9f
SM
592011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
60
61 * process.c (Qprocessp): Don't declare static.
62 * lisp.h (Qprocessp): Declare again.
63
7990b61a
JB
642011-04-15 Juanma Barranquero <lekktu@gmail.com>
65
66 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
67
5d4cb038
PE
682011-04-14 Paul Eggert <eggert@cs.ucla.edu>
69
8bd7b830 70 Improve C-level modularity by making more things 'static'.
cd64ea1d 71
e3b27b31
PE
72 Don't publish debugger-only interfaces to other modules.
73 * lisp.h (safe_debug_print, debug_output_compilation_hack):
74 (verify_bytepos, count_markers): Move decls to the only modules
75 that need them.
76 * region-cache.h (pp_cache): Likewise.
77 * window.h (check_all_windows): Likewise.
78 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
79
5d4cb038
PE
80 * sysdep.c (croak): Now static, if
81 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
82 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
83
84 * alloc.c (refill_memory_reserve): Now static if
85 !defined REL_ALLOC || defined SYSTEM_MALLOC.
86 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 87
e87b6180
PE
88 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
89 Define only if USE_LUCID.
90
ac64929e
PE
91 * xrdb.c (x_customization_string, x_rm_string): Now static.
92
6f37259d
PE
93 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
94 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
95
1683e3ab
PE
96 * xdisp.c (draw_row_with_mouse_face): Now static.
97 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
98
de9c2632
PE
99 * window.h (check_all_windows): Mark externally visible.
100
2b96acb7
PE
101 * window.c (window_deletion_count): Now static.
102
103 * undo.c: Make symbols static if they're not exported.
104 (last_undo_buffer, last_boundary_position, pending_boundary):
105 Now static.
106
50436f33
PE
107 * textprop.c (interval_insert_behind_hooks): Now static.
108 (interval_insert_in_front_hooks): Likewise.
109
64520e5c
PE
110 * term.c: Make symbols static if they're not exported.
111 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
112 (max_frame_lines, tty_set_terminal_modes):
113 (tty_reset_terminal_modes, tty_turn_off_highlight):
114 (get_tty_terminal): Now static.
115 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
116 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 117 HAVE_WINDOW_SYSTEM.
64520e5c
PE
118 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
119 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
120
1fa53021
PE
121 * sysdep.c: Make symbols static if they're not exported.
122 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
123 Now static.
124 (sigprocmask_set, full_mask): Remove; unused.
125 (wait_debugging): Mark as visible.
126 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
127 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
128
d4b43b22
PE
129 * syntax.c (syntax_temp): Define only if !__GNUC__.
130
b7c513d0
PE
131 * sound.c (current_sound_device, current_sound): Now static.
132
989b29ad
PE
133 * search.c (searchbufs, searchbuf_head): Now static.
134
13a55a78
PE
135 * scroll.c (scroll_cost): Remove; unused.
136 * dispextern.h (scroll_cost): Remove decl.
137
de68a1fc
PE
138 * region-cache.h (pp_cache): Mark as externally visible.
139
40ccffa6
PE
140 * process.c: Make symbols static if they're not exported.
141 (process_tick, update_tick, create_process, chan_process):
142 (Vprocess_alist, proc_buffered_char, datagram_access):
143 (fd_callback_data, send_process_frame, process_sent_to): Now static.
144 (deactivate_process): Mark defn as static, as well as decl.
145 * lisp.h (create_process): Remove decl.
146 * process.h (chan_process, Vprocess_alist): Remove decls.
147
ad64fc97
PE
148 * print.c: Make symbols static if they're not exported.
149 (print_depth, new_backquote_output, being_printed, print_buffer):
150 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
151 (print_interval, print_number_index, initial_stderr_stream):
152 Now static.
153 * lisp.h (Fprinc): Remove decl.
154 (debug_output_compilation_hack): Mark as externally visible.
155
adddb265
PE
156 * sysdep.c (croak): Move decl from here to syssignal.h.
157 * syssignal.h (croak): Put it here, so the API can be checked when
158 'croak' is called from dissociate_if_controlling_tty.
159
1717ede2
PE
160 * minibuf.c: Make symbols static if they're not exported.
161 (minibuf_save_list, choose_minibuf_frame): Now static.
162 * lisp.h (choose_minibuf_frame): Remove decl.
163
fa5fb2bc
PE
164 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
165
1e3890d1
PE
166 * lread.c: Make symbols static if they're not exported.
167 (read_objects, initial_obarray, oblookup_last_bucket_number):
168 Now static.
169 (make_symbol): Remove; unused.
170 * lisp.h (initial_obarray, make_symbol): Remove decls.
171
8a1414fa
PE
172 * keyboard.c: Make symbols static if they're not exported.
173 (single_kboard, recent_keys_index, total_keys, recent_keys):
174 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
175 (this_single_command_key_start, echoing, last_auto_save):
176 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
177 (command_loop, echo_now, keyboard_init_hook, help_char_p):
178 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
179 (Vlispy_mouse_stem, double_click_count):
180 Now static.
181 (force_auto_save_soon): Define only if SIGDANGER.
182 (ignore_mouse_drag_p): Now static if
183 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
184 (print_help): Remove; unused.
185 (stop_character, last_timer_event): Mark as externally visible.
186 * keyboard.h (ignore_mouse_drag_p): Declare only if
187 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
188 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
189 * lisp.h (echoing): Remove decl.
190 (force_auto_save_soon): Declare only if SIGDANGER.
191 * xdisp.c (redisplay_window): Simplify code, to make it more
192 obvious that ignore_mouse_drag_p is not accessed if !defined
193 USE_GTK && !defined HAVE_NS.
194
93ea6e8f
PE
195 * intervals.c: Make symbols static if they're not exported.
196 (merge_properties_sticky, merge_interval_right, delete_interval):
197 Now static.
198 * intervals.h (merge_interval_right, delete_interval): Remove decls.
199
77382fcc
PE
200 * insdel.c: Make symbols static if they're not exported.
201 However, leave prepare_to_modify_buffer alone. It's never
202 called from outside this function, but that appears to be a bug.
203 (combine_after_change_list, combine_after_change_buffer):
4889fc82 204 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
205 (adjust_after_replace_noundo): Remove; unused.
206 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 207 (signal_before_change): Remove decls.
77382fcc 208
9306c32e
PE
209 * indent.c (val_compute_motion, val_vmotion): Now static.
210
cd44d2eb
PE
211 * image.c: Make symbols static if they're not exported.
212 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
213 if USE_GTK.
214 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
215 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
216
ad9a7a06
PE
217 * fringe.c (standard_bitmaps): Now static.
218 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
219
81626931
PE
220 * frame.c: Make symbols static if they're not exported.
221 (x_report_frame_params, make_terminal_frame): Now static.
222 (get_frame_param): Now static, unless HAVE_NS.
223 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
224 (x_get_resource_string): Remove; not used.
225 * frame.h (make_terminal_frame, x_report_frame_params):
226 (x_get_resource_string); Remove decls.
227 (x_fullscreen_adjust): Declare only if WINDOWSNT.
228 * lisp.h (get_frame_param): Declare only if HAVE_NS.
229
239f9db9
PE
230 * font.c, fontset.c: Make symbols static if they're not exported.
231 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
232 (FACE_SUITABLE_FOR_CHAR_P): Use it.
233 * font.c (font_close_object): Now static.
234 * font.h (font_close_object): Remove.
235 * fontset.c (FONTSET_OBJLIST): Remove.
236 (free_realized_fontset) #if-0 the body, which does nothing.
237 (face_suitable_for_char_p): #if-0, as it's never called.
238 * fontset.h (face_suitable_for_char_p): Remove decl.
239 * xfaces.c (face_at_string_position): Use
240 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
241 since 0 is always ASCII.
242
dfcf3579
PE
243 * fns.c (weak_hash_tables): Now static.
244
5045092b
PE
245 * fileio.c: Make symbols static if they're not exported.
246 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
247 (Vwrite_region_annotation_buffers): Now static.
248
57a96f5c
PE
249 * eval.c: Make symbols static if they're not exported.
250 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
251 * lisp.h (backtrace_list): Remove decl.
252
35f08c38
PE
253 * emacs.c: Make symbols static if they're not exported.
254 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
255 (fatal_error_code, fatal_error_signal_hook, standard_args):
256 Now static.
257 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
258 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
259 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
260 * lisp.h (fatal_error_signal_hook): Remove decl.
261 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
262
f44bd759
PE
263 * editfns.c: Move a (normally-unused) function to its only use.
264 * editfns.c, lisp.h (get_operating_system_release): Remove.
265 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
266 worth the hassle of breaking this out.
267
b532497d
PE
268 * xterm.c: Make symbols static if they're not exported.
269 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
270 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
271 (x_destroy_window, x_delete_display):
272 Now static.
273 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
274 (x_mouse_leave): Remove; unused.
275 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
276 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
277 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
278 Remove decls.
279 (x_mouse_leave): Declare only if WINDOWSNT.
280 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
281 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
282 USE_X_TOOLKIT.
283
1675728f
PE
284 * ftxfont.c: Make symbols static if they're not exported.
285 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
286 HAVE_FREETYPE.
287 * font.h (ftxfont_driver): Likewise.
288
e4cebfca
PE
289 * xfns.c: Make symbols static if they're not exported.
290 (x_last_font_name, x_display_info_for_name):
291 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
292 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
293 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
294 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
295 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
296 (last_show_tip_args): Now static.
297 (xic_defaut_fontset, xic_create_fontsetname): Define only if
298 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
299 (x_screen_planes): Remove; unused.
300 * dispextern.h (x_screen_planes): Remove decl.
301
5bf46f05
PE
302 * dispnew.c: Make symbols static if they're not exported.
303 * dispextern.h (redraw_garbaged_frames, scrolling):
304 (increment_row_positions): Remove.
305 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
306 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
307 Now static.
308 (redraw_garbaged_frames): Remove; unused.
309
435f4c28
PE
310 * xfaces.c: Make symbols static if they're not exported.
311 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
312 Remove decls.
313 * xterm.h (defined_color): Remove decls.
314 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
315 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
316 (menu_face_changed_default, defined_color, free_realized_face):
317 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
318 (ascii_face_of_lisp_face): Remove; unused.
319
8524aef3
PE
320 * xdisp.c: Make symbols static if they're not exported.
321 * dispextern.h (scratch_glyph_row, window_box_edges):
322 (glyph_to_pixel_coords, set_cursor_from_row):
323 (get_next_display_element, set_iterator_to_next):
324 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
325 (show_mouse_face): Remove decls
326 * frame.h (message_buf_print): Likewise.
327 * lisp.h (pop_message, set_message, check_point_in_composition):
328 Likewise.
329 * xterm.h (set_vertical_scroll_bar): Likewise.
330 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
331 (message_buf_print, scratch_glyph_row, displayed_buffer):
332 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
333 (get_next_display_element, show_mouse_face, window_box_edges):
334 (frame_to_window_pixel_xy, check_point_in_composition):
335 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
336 (glyph_to_pixel_coords): Remove; unused.
337
16390cd2
PE
338 * dired.c (file_name_completion): Now static.
339
340 * dbusbind.c (xd_in_read_queued_messages): Now static.
341
a25f4dfa
PE
342 * lisp.h (circular_list_error, FOREACH): Remove; unused.
343 * data.c (circular_list_error): Remove.
344
14a9c8df
PE
345 * commands.h (last_point_position, last_point_position_buffer):
346 (last_point_position_window): Remove decls.
347 * keyboard.c: Make these variables static.
348
74ab6df5
PE
349 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
350 decls.
351 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
352 (iso_code_class, detect_coding, code_convert_region): Now static.
353 (encode_coding_gap): Remove; unused.
354
38dfbee1
PE
355 * chartab.c (chartab_chars, chartab_bits): Now static.
356
a2cb4e63
PE
357 * charset.h (charset_iso_8859_1): Remove decl.
358 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
359 Now static.
360
127198fd
PE
361 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
362 * ccl.c (Vccl_program_table): Now static.
363 (check_ccl_update): Remove; unused.
364
d85b608f
PE
365 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
366 * category.h: ... from here.
367 * category.c (check_category_table, set_category_set): Now static.
368
31cd66f3
PE
369 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
370 * lisp.h: Remove these decls.
371
c358e587
PE
372 * buffer.c (buffer_count): Remove unused var.
373
e78aecca
PE
374 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
375 so that it's not optimized away.
376 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
377 * dispextern.h (bidi_dump_cached_states): Remove, since it's
378 exported only to the debugger.
379
e192d7d3
PE
380 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
381 * atimer.h (run_all_atimers): Removed; not exported.
382
92470028
PE
383 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
384 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
385 was inaccessible from Lisp.
386 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
387 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
388
244ed907
PE
389 alloc.c: Import and export fewer symbols, and remove unused items.
390 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
391 is defined.
392 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
393 it's not optimized away by whole-program optimization.
394 (message_enable_multibyte, free_misc): Remove.
395 (catchlist, handlerlist, mark_backtrace):
396 Declare only if BYTE_MARK_STACK.
397 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
398 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
399 (message_enable_multibyte): Remove decl.
400 (free_misc, interval_free_list, float_block, float_block_index):
401 (n_float_blocks, float_free_list, cons_block, cons_block_index):
402 (cons_free_list, last_marked_index):
403 Now static.
404 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
405 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
406 (mark_backtrace): Define only if BYTE_MARK_STACK.
407 * xdisp.c (message_enable_multibyte): Now static.
408
955cbe7b
PE
409 Declare Lisp_Object Q* variables to be 'static' if not exproted.
410 This makes it easier for human readers (and static analyzers)
411 to see whether these variables are used from other modules.
412 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
413 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
414 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
415 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
416 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
417 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
418 * xmenu.c, xselect.c:
419 Declare Q* vars static if they are not used in other modules.
420 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
421 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
422 Remove decls of unexported vars.
423 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
424
95c82688
PE
425 * lisp.h (DEFINE_FUNC): Make sname 'static'.
426
16a97296
PE
427 Make Emacs functions such as Fatom 'static' by default.
428 This makes it easier for human readers (and static analyzers)
429 to see whether these functions can be called from other modules.
430 DEFUN now defines a static function. To make the function external
431 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
432 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
433 (Finit_image_library):
16a97296
PE
434 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
435 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
436 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
437 Remove decls, since these functions are now static.
438 (Funintern, Fget_internal_run_time): New decls, since these functions
439 were already external.
95c82688 440
16a97296
PE
441 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
442 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
443 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
444 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
445 * keyboard.c, keymap.c, lread.c:
446 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
447 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
448 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
449 Mark functions with DEFUE instead of DEFUN,
450 if they are used in other modules.
451 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
452 decls for now-static functions.
453 * buffer.h (Fdelete_overlay): Remove decl.
454 * callproc.c (Fgetenv_internal): Mark as internal.
455 * composite.c (Fremove_list_of_text_properties): Remove decl.
456 (Fcomposition_get_gstring): New forward static decl.
457 * composite.h (Fcomposite_get_gstring): Remove decl.
458 * dired.c (Ffile_attributes): New forward static decl.
459 * doc.c (Fdocumntation_property): New forward static decl.
460 * eval.c (Ffetch_bytecode): New forward static decl.
461 (Funintern): Remove extern decl; now in .h file where it belongs.
462 * fileio.c (Fmake_symbolic_link): New forward static decl.
463 * image.c (Finit_image_library): New forward static decl.
464 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
465 * intervals.h (Fprevious_property_change):
466 (Fremove_list_of_text_properties): Remove decls.
467 * keyboard.c (Fthis_command_keys): Remove decl.
468 (Fcommand_execute): New forward static decl.
469 * keymap.c (Flookup_key): New forward static decl.
470 (Fcopy_keymap): Now static.
471 * keymap.h (Flookup_key): Remove decl.
472 * process.c (Fget_process): New forward static decl.
473 (Fprocess_datagram_address): Mark as internal.
474 * syntax.c (Fsyntax_table_p): New forward static decl.
475 (skip_chars): Remove duplicate decl.
476 * textprop.c (Fprevious_property_change): New forward static decl.
477 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
478 Now internal.
479 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
480 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
481
785bbd42
PE
482 * editfns.c (Fformat): Remove unreachable code.
483
8b913b57
AS
4842011-04-14 Andreas Schwab <schwab@linux-m68k.org>
485
486 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
487 change. (Bug#8496)
488
a6744a35
EZ
4892011-04-13 Eli Zaretskii <eliz@gnu.org>
490
491 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
492 when at ZV. (Bug#8487)
493
e7974947
AS
4942011-04-12 Andreas Schwab <schwab@linux-m68k.org>
495
baad03f0
AS
496 * charset.c (Fclear_charset_maps): Use xfree instead of free.
497 (Bug#8437)
498 * keyboard.c (parse_tool_bar_item): Likewise.
499 * sound.c (sound_cleanup, alsa_close): Likewise.
500 * termcap.c (tgetent): Likewise.
501 * xfns.c (x_default_font_parameter): Likewise.
502 * xsettings.c (read_and_apply_settings): Likewise.
503
e7974947
AS
504 * alloc.c (overrun_check_malloc, overrun_check_realloc)
505 (overrun_check_free): Protoize.
506
28272684
PE
5072011-04-12 Paul Eggert <eggert@cs.ucla.edu>
508
509 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
510 since callers should never pass a negative size.
511 Change the signature to match that of plain 'read' and 'write'; see
512 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
513 * lisp.h: Update prototypes of emacs_write and emacs_read.
514
11997c76
EZ
5152011-04-11 Eli Zaretskii <eliz@gnu.org>
516
517 * xdisp.c (redisplay_window): Don't try to determine the character
518 position of the scroll margin if the window start point w->startp
e896f03c 519 is outside the buffer's accessible region. (Bug#8468)
11997c76 520
8a2cbd72
EZ
5212011-04-10 Eli Zaretskii <eliz@gnu.org>
522
523 Fix write-region and its subroutines for buffers > 2GB.
524 * fileio.c (a_write, e_write): Modify declaration of arguments and
525 local variables to support buffers larger than 2GB.
526 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
527
528 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
529 argument, local variables, and return value.
530
531 * lisp.h: Update prototypes of emacs_write and emacs_read.
532
533 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
534
4073e537 5352011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 536
1ebfdcb6
PE
537 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
538
b2ded58d
PE
539 Fix more problems found by GCC 4.6.0's static checks.
540
7d66342c
PE
541 * xdisp.c (vmessage): Use a better test for character truncation.
542
bbf47d44
PE
543 * charset.c (load_charset_map): <, not <=, for optimization,
544 and to avoid potential problems with integer overflow.
9248994d 545 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 546 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 547 * editfns.c (Fformat): Likewise.
1e69125e 548 * syntax.c (skip_chars): Likewise.
3befa583 549
e3019616
PE
550 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
551 This also lets GCC 4.6.0 generate slightly better loop code.
552
becfa255
PE
553 * callint.c (Fcall_interactively): <, not <=, for optimization.
554 (Fcall_interactively): Count the number of arguments produced,
555 not the number of arguments given. This is simpler and lets GCC
556 4.6.0 generate slightly better code.
557
dae0cd48
PE
558 * ftfont.c: Distingish more carefully between FcChar8 and char.
559 The previous code passed unsigned char * to a functions like
560 strlen and xstrcasecmp that expect char *, which does not
561 conform to the C standard.
562 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
563 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
564 char * when the C standard requires it.
565
76032d70
PE
566 * keyboard.c (read_char): Remove unused var.
567
eb3f1cc8
PE
568 * eval.c: Port to Windows vsnprintf (Bug#8435).
569 Include <limits.h>.
570 (SIZE_MAX): Define if the headers do not.
571 (verror): Do not give up if vsnprintf returns a negative count.
572 Instead, grow the buffer. This ports to Windows vsnprintf, which
573 does not conform to C99. Problem reported by Eli Zaretskii.
574 Also, simplify the allocation scheme, by avoiding the need for
575 calling realloc, and removing the ALLOCATED variable.
576
70476b54
PE
577 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
578
12020a9e
PE
579 Remove invocations of doprnt, as Emacs now uses vsnprintf.
580 But keep the doprint source code for now, as we might revamp it
581 and use it again (Bug#8435).
ea6c7ae6
PE
582 * lisp.h (doprnt): Remove.
583 * Makefile.in (base_obj): Remove doprnt.o.
584 * deps.mk (doprnt.o): Remove.
585
5fdb398c
PE
586 error: Print 32- and 64-bit integers portably (Bug#8435).
587 Without this change, on typical 64-bit hosts error ("...%d...", N)
588 was used to print both 32- and 64-bit integers N, which relied on
589 undefined behavior.
590 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
591 New macro.
592 * lisp.h (error, verror): Mark as printf-like functions.
593 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
594 Report overflow in size calculations when allocating printf buffer.
595 Do not truncate output string at its first null byte.
596 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
597 Truncate the output at a character boundary, since vsnprintf does not
598 do that.
599 * charset.c (check_iso_charset_parameter): Convert internal
600 character to string before calling 'error', since %c now has the
601 printf meaning.
602 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
603 overflow when computing char to be passed to 'error'. Do not
604 pass Lisp_Object to 'error'; pass the integer instead.
605 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
606 formatted with plain %d.
607
b189fa66
PE
608 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
609
bff87ef0
PE
610 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
611
7e2cac20
PE
612 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
613
ce4d90b5
PE
614 * xterm.c (x_catch_errors): Remove duplicate declaration.
615
266c9547
PE
616 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
617
79c49ad2
PE
618 * xdisp.c, lisp.h (message_nolog): Remove; unused.
619
368f4090
JM
6202011-04-10 Jim Meyering <meyering@redhat.com>
621
622 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
623 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
624 return ssize_t not "int", and use size_t as the buffer length.
625 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
626 * gnutls.h: Update declarations.
627 * process.c (read_process_output): Use ssize_t, to match.
628 (send_process): Likewise.
629
a32d4040
CY
6302011-04-09 Chong Yidong <cyd@stupidchicken.com>
631
632 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
633
8546720e 6342011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 635
8546720e
GM
636 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
637 unsigned char, to match FcChar8 type definition.
aac0c6e3 638
8546720e
GM
639 * xterm.c (handle_one_xevent):
640 * xmenu.c (create_and_show_popup_menu):
641 * xselect.c (x_decline_selection_request)
642 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 643
0a2f5c1a 6442011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
645
646 Fix some uses of `int' instead of EMACS_INT.
647 * search.c (string_match_1, fast_string_match)
648 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
649 (scan_buffer, find_next_newline_no_quit)
650 (find_before_next_newline, search_command, Freplace_match)
651 (Fmatch_data): Make some `int' variables be EMACS_INT.
652
653 * xdisp.c (display_count_lines): 3rd argument and return value now
654 EMACS_INT. All callers changed.
655 (pint2hrstr): Last argument is now EMACS_INT.
656
657 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
658 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
659 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
660 (decode_coding_utf_16, decode_coding_emacs_mule)
661 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
662 (decode_coding_ccl, decode_coding_charset)
663 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
664 (decode_coding_iso_2022, decode_coding_emacs_mule)
665 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
666 <char_offset, last_offset>: Declare EMACS_INT.
667 (encode_coding_utf_8, encode_coding_utf_16)
668 (encode_coding_emacs_mule, encode_invocation_designation)
669 (encode_designation_at_bol, encode_coding_iso_2022)
670 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
671 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
672 Declare EMACS_INT.
673 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
674 (encode_invocation_designation): Last argument P_NCHARS is now
675 EMACS_INT.
676 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
677 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
678
679 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
680 All users changed.
681
682 * ccl.c (Fccl_execute_on_string): Declare some variables
683 EMACS_INT.
684
8546720e 6852011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
686
687 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
688
4e19a977
CS
6892011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
690
691 * process.c (Fformat_network_address): Doc fix.
692
87302331
R
6932011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
694
695 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
696
cbb59342
CY
6972011-04-08 Chong Yidong <cyd@stupidchicken.com>
698
699 * keyboard.c (read_char): Call Lisp function help-form-show,
700 instead of using internal_with_output_to_temp_buffer.
701 (Qhelp_form_show): New var.
e0d38eeb 702 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
703
704 * print.c (internal_with_output_to_temp_buffer): Function deleted.
705
706 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
707
e67a13ab
CY
7082011-04-06 Chong Yidong <cyd@stupidchicken.com>
709
710 * process.c (Flist_processes): Removed to Lisp.
711 (list_processes_1): Deleted.
712
973f782d
EZ
7132011-04-06 Eli Zaretskii <eliz@gnu.org>
714
7c106b1e
EZ
715 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
716
973f782d
EZ
717 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
718
41cf7d1a 7192011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 720
ca23cc88
PE
721 Fix more problems found by GCC 4.6.0's static checks.
722
f390e2d5
PE
723 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
724
42eea0d0
PE
725 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
726
b69769da 727 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 728
f9541e84
PE
729 * xdisp.c (vmessage): Mark as a printf-like function.
730
13841b55
PE
731 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
732
c136c10f
PE
733 * sound.c (sound_warning): Don't crash if arg contains a printf format.
734
5e2d4a30
PE
735 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
736 printf-like functions.
737 (tiff_load): Add casts to remove these marks before passing them
738 to system-supplied API.
739
583f48b9
PE
740 * eval.c (Fsignal): Remove excess argument to 'fatal'.
741
b25d760e
PE
742 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
743 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
744 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
745 directly, rather than having caller test rule sign. This avoids
746 some unnecessary tests.
747 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
748 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
749 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 750
bc7b6697 751 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 752 (xfont_open): Avoid unnecessary tests.
bc7b6697 753
27ccc379
PE
754 * composite.c (composition_gstring_put_cache): Use unsigned integer.
755
dcd5c89a
PE
756 * composite.h, composite.c (composition_gstring_put_cache):
757 Use EMACS_INT, not int, for length.
758
b13a45c6
PE
759 * composite.h (COMPOSITION_DECODE_REFS): New macro,
760 breaking out part of COMPOSITION_DECODE_RULE.
761 (COMPOSITION_DECODE_RULE): Use it.
762 * composite.c (get_composition_id): Remove unused local vars,
763 by using the new macro.
764
1e792e4d
PE
765 * textprop.c (set_text_properties_1): Change while to do-while,
766 since the condition is always true at first.
767
dc6c6455 768 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
769 (interval_deletion_adjustment): Return unsigned value.
770 All uses changed.
dc6c6455 771
aba7731a
PE
772 * process.c (list_processes_1, create_pty, read_process_output):
773 (exec_sentinel): Remove vars that were set but not used.
afd4052b 774 (create_pty): Remove unnecessary "volatile"s.
bc57d757 775 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 776 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 777 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 778
fdfc4bf3
PE
779 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
780
fca8fe46 781 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 782 (update_syntax_table): Use unsigned instead of int.
fca8fe46 783
06a0259a 784 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 785 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 786 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 787
e7b9e80f
PE
788 * print.c (print_error_message): Avoid int overflow.
789
56201685
PE
790 * font.c (font_list_entities): Redo for clarity,
791 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
792
78834453 793 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 794 (font_score): Avoid potential overflow in diff calculation.
78834453 795
0bc0b309 796 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 797 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 798
e610eaca
PE
799 * eval.c (funcall_lambda): Rename local to avoid shadowing.
800
b895abce
PE
801 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
802 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
803 can always succeed if overflow has undefined behavior.
804
1f1d9321 805 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 806 (wordify): Omit three unnecessary tests.
1f1d9321 807
c59478bc
PE
808 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
809 All callers changed. This avoids the need for an unused var.
810
79b73827
PE
811 * casefiddle.c (casify_region): Remove var that is set but not used.
812
a4db5dfe
PE
813 * dired.c (file_name_completion): Remove var that is set but not used.
814
43aae36e
PE
815 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
816
2a47c44d 817 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 818 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 819
a37c69bf
PE
820 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
821 Check for integer overflow on size calculations.
822
328ab8e7
PE
823 * buffer.c (Fprevious_overlay_change): Remove var that is set
824 but not used.
825
e5a2a5cb
PE
826 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
827 Remove vars that are set but not used.
8d84a6eb 828 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 829 (timer_check_2): Mark vars as initialized.
e5a2a5cb 830
a60e5f68
PE
831 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
832
f661cb61 833 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 834 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 835
f0397f5a
PE
836 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
837 that are set but not used.
838
8664db06 839 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 840 if XCreateBitmapFromData fails (Bug#8410).
8664db06 841
6abdaa4a
PE
842 * xselect.c (x_get_local_selection, x_handle_property_notify):
843 Remove vars that are set but not used.
844
0ce7538d 845 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 846 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 847
9ae848fc
PE
848 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
849 Remove var that is set but not used.
0b918413
PE
850 (scroll_bar_windows_size): Now size_t, not int.
851 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
852 Check for overflow.
9ae848fc 853
a5a62657
PE
854 * xfaces.c (realize_named_face): Remove vars that are set but not used.
855 (map_tty_color) [!defined MSDOS]: Likewise.
856
5c5cdd39
PE
857 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
858
66ebf983
PE
859 * coding.c: Remove vars that are set but not used.
860 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
861 All callers changed.
862 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
863 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
864 (decode_coding_charset): Remove vars that are set but not used.
865
1be4d761
PE
866 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
867 that is set but not used.
868
47553fa8
PE
869 * print.c (print_object): Remove var that is set but not used.
870
1f7196bf 871 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
872 The gnulib version avoids calling malloc in the usual case,
873 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
874 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
875 * filelock.c (current_lock_owner): Likewise.
876 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
877 * sysdep.c: Include allocator.h, careadlinkat.h.
878 (emacs_no_realloc_allocator): New static constant.
879 (emacs_readlink): New function.
fdb61804
PE
880 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
881 ../lib/careadlinkat.h.
d1fdcab7 882
f84c17c7
SM
8832011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
884
885 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
886 first non-nil return value).
887
ef3862ad
JD
8882011-04-03 Jan Djärv <jan.h.d@swipnet.se>
889
890 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
891 if not defined (Bug#8403).
892
376a7006
JB
8932011-04-02 Juanma Barranquero <lekktu@gmail.com>
894
895 * xdisp.c (display_count_lines): Remove parameter `start',
896 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
897 (get_char_face_and_encoding): Remove parameter `multibyte_p',
898 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
899 (fill_stretch_glyph_string): Remove parameters `row' and `area',
900 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
901 and thereabouts. All callers changed.
902 (get_per_char_metric): Remove parameter `f', unused since
903 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
904
6ca3801d
JM
9052011-04-02 Jim Meyering <meyering@redhat.com>
906
907 do not dereference NULL upon failed strdup
908 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
909 (ns_get_family): Likewise.
910
d8e2b5ba
JB
9112011-04-02 Juanma Barranquero <lekktu@gmail.com>
912
913 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
914
8c74fcbd
JD
9152011-04-02 Jan Djärv <jan.h.d@swipnet.se>
916
917 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
918 later (Bug#8403).
919
7200d79c
SM
9202011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
921
03408648 922 Add lexical binding.
7200d79c 923
03408648
SM
924 * window.c (Ftemp_output_buffer_show): New fun.
925 (Fsave_window_excursion):
926 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
927
928 * lread.c (lisp_file_lexically_bound_p): New function.
929 (Fload): Bind Qlexical_binding.
930 (readevalloop): Remove `evalfun' arg.
931 Bind Qinternal_interpreter_environment.
932 (Feval_buffer): Bind Qlexical_binding.
933 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
934 Mark as dynamic.
935 (syms_of_lread): Declare `lexical-binding'.
936
937 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
938
939 * keyboard.c (eval_dyn): New fun.
940 (menu_item_eval_property): Use it.
ca105506
SM
941
942 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 943
03408648
SM
944 * fns.c (concat, mapcar1): Accept byte-code-functions.
945
946 * eval.c (Fsetq): Handle lexical vars.
947 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
948 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
949 (FletX, Flet): Obey lexical binding.
950 (Fcommandp): Handle closures.
951 (Feval): New `lexical' arg.
952 (eval_sub): New function extracted from Feval. Use it almost
953 everywhere where Feval was used. Look up vars in lexical env.
954 Handle closures.
955 (Ffunctionp): Move from subr.el.
956 (Ffuncall): Handle closures.
957 (apply_lambda): Remove `eval_flags'.
958 (funcall_lambda): Handle closures and new byte-code-functions.
959 (Fspecial_variable_p): New function.
960 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
961 but without exporting it to Lisp.
23aba0ea 962
23aba0ea 963 * doc.c (Fdocumentation, store_function_docstring):
03408648 964 * data.c (Finteractive_form): Handle closures.
23aba0ea 965
03408648
SM
966 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
967 interactive spec.
ba83908c 968
03408648
SM
969 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
970 byte-codes.
971 (exec_byte_code): New function extracted from Fbyte_code to handle new
972 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 973
03408648 974 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 975
03408648 976 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 977
e2abce01
JB
9782011-03-31 Juanma Barranquero <lekktu@gmail.com>
979
980 * xdisp.c (redisplay_internal): Fix prototype.
981
63696a73 9822011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 983
63696a73
EZ
984 * xdisp.c (SCROLL_LIMIT): New macro.
985 (try_scrolling): Use it when setting scroll_limit. Limit
986 scrolling to 100 screen lines.
987 (redisplay_window): Even when falling back on "recentering",
988 position point in the window according to scroll-conservatively,
989 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
990
991 (try_scrolling): When point is above the window, allow searching
992 as far as scroll_max, or one screenful, to compute vertical
993 distance from PT to the scroll margin position. This prevents
994 try_scrolling from unnecessarily failing when
995 scroll-conservatively is set to a value slightly larger than the
996 window height. Clean up the case of PT below the margin at bottom
997 of window: scroll_max can no longer be INT_MAX. When aggressive
998 scrolling is in use, don't let point enter the opposite scroll
999 margin as result of the scroll.
1000 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1001 threshold of 100 lines for never-recentering scrolling.
1002
e4cc2dfc
JB
10032011-03-31 Juanma Barranquero <lekktu@gmail.com>
1004
1005 * dispextern.h (move_it_by_lines):
1006 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1007 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1008 (message_log_check_duplicate): Remove parameters `prev_bol' and
1009 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1010 (redisplay_internal): Remove parameter `preserve_echo_area',
1011 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1012
1013 * indent.c (Fvertical_motion):
1014 * window.c (window_scroll_pixel_based, Frecenter):
1015 Don't pass `need_y_p' to `move_it_by_lines'.
1016
1c470562
SM
10172011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1018
44f230aa
SM
1019 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1020 steal a few bits to be more compact.
1021 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1022 Remove unneeded casts.
1023
1c470562
SM
1024 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1025
888adce9
ZK
10262011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1027
1028 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1029 binding" message (bug#7967).
1030
f838ed7b
PE
10312011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1032
77861b95
PE
1033 Fix more problems found by GCC 4.6.0's static checks.
1034
de6dbc14
PE
1035 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1036 Remove unused local var.
1037
f838ed7b
PE
1038 * editfns.c (Fmessage_box): Remove unused local var.
1039
792c7b2b
PE
1040 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1041 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1042 Omit unused local vars.
c499e557 1043 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1044 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1045 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1046 Omit unused local var.
1047
ba0165e1
PE
1048 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1049 Don't assume string length fits in int.
32ad8845 1050 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1051 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1052
3c59b4c9
PE
1053 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1054 instead of alloca (Bug#8344).
1055
a3eed478 1056 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1057 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1058
eb4d412d
PE
1059 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1060
1658b401
PE
1061 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1062 concerns.
1063
1064 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1065
1066 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1067
9a2c6e05
PE
1068 * keyboard.c (syms_of_keyboard): Use the same style as later
1069 in this function when indexing through an array. This also
1070 works around GCC bug 48267.
1071
03d0a109
PE
1072 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1073
44f730c8
PE
1074 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1075
fe75f926
PE
1076 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1077 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1078
ffa8c828
PE
1079 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1080 This avoids undefined behavior on integer overflow, and is a bit
1081 more convenient anyway since it is compared to a size_t variable.
1082
c5101a77
PE
1083 Variadic C functions now count arguments with size_t, not int.
1084 This avoids an unnecessary limitation on 64-bit machines, which
1085 caused (substring ...) to crash on large vectors (Bug#8344).
1086 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1087 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1088 All variadic functions and their callers changed accordingly.
c5101a77
PE
1089 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1090 * data.c (arith_driver, float_arith_driver): Likewise.
1091 * editfns.c (general_insert_function): Likewise.
1092 * eval.c (struct backtrace.nargs, interactive_p)
1093 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1094 (funcall_lambda, mark_backtrace): Likewise.
1095 * fns.c (concat): Likewise.
1096 * frame.c (x_set_frame_parameters): Likewise.
1097 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1098 0 if not found, not -1. All callers changed.
1099
dd3f25f7
PE
1100 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1101 (stack_copy_size): Now size_t, not int.
1102 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1103
461c2ab9
JB
11042011-03-28 Juanma Barranquero <lekktu@gmail.com>
1105
1106 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1107 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1108 All callers changed.
1109
1110 * lisp.h (multibyte_char_to_unibyte):
1111 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1112 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1113 * character.h (CHAR_TO_BYTE8):
1114 * cmds.c (internal_self_insert):
1115 * editfns.c (general_insert_function):
1116 * keymap.c (push_key_description):
1117 * search.c (Freplace_match):
1118 * xdisp.c (message_dolog, set_message_1): All callers changed.
1119
f6d62986
SM
11202011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1121
1122 * keyboard.c (safe_run_hook_funcall): New function.
1123 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1124 don't set the hook to nil, but remove the offending function instead.
1125 (Qcommand_hook_internal): Remove, unused.
1126 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1127 Vcommand_hook_internal.
1128
1129 * eval.c (enum run_hooks_condition): Remove.
1130 (funcall_nil, funcall_not): New functions.
1131 (run_hook_with_args): Call each function through a `funcall' argument.
1132 Remove `cond' argument, now redundant.
1133 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1134 (Frun_hook_with_args_until_failure): Adjust accordingly.
1135 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1136
1db5b1ad
JB
11372011-03-28 Juanma Barranquero <lekktu@gmail.com>
1138
1139 * dispextern.h (string_buffer_position): Remove declaration.
1140
1141 * print.c (strout): Remove parameter `multibyte', unused since
1142 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1143
1144 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1145 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1146 All callers changed.
1147
1148 * w32.c (_wsa_errlist): Use braces for struct initializers.
1149
1150 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1151 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1152 All callers changed.
1153 (string_buffer_position): Likewise. Also, make static (it's never
1154 used outside xdisp.c).
1155 (cursor_row_p): Remove parameter `w', unused since
1156 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1157 (decode_mode_spec): Remove parameter `precision', introduced during
1158 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1159 All callers changed.
1160
5ffb62aa
JD
11612011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1162
1163 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1164
461c2ab9 11652011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1166
1167 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1168 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1169 (ns_update_auto_hide_menu_bar): New functions.
1170 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1171 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1172 ns_constrain_all_frames.
1173 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1174 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1175
5c380ffb
JD
11762011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1177
1178 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1179
9af30bdf
GM
11802011-03-27 Glenn Morris <rgm@gnu.org>
1181
1182 * syssignal.h: Replace RETSIGTYPE with void.
1183 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1184 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1185 Replace SIGTYPE with void everywhere.
1186 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1187 * s/template.h (SIGTYPE): Remove commented out definition.
1188
e2abce01
JB
11892011-03-26 Eli Zaretskii <eliz@gnu.org>
1190
1191 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1192 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1193
f868cd8a
JB
11942011-03-26 Juanma Barranquero <lekktu@gmail.com>
1195
59eb0929
JB
1196 * w32.c (read_unc_volume): Use parameter `henum', instead of
1197 global variable `wget_enum_handle'.
1198
1199 * keymap.c (describe_vector): Remove parameters `indices' and
1200 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1201 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1202
f868cd8a
JB
1203 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1204
1205 * keyboard.c (timer_check): Remove parameter `do_it_now',
1206 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1207 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1208 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1209
1210 * keyboard.c (read_char):
1211 * w32menu.c (w32_menu_display_help):
1212 * xmenu.c (show_help_event, menu_help_callback):
1213 Adjust calls to `show_help_echo'.
1214
1215 * gtkutil.c (xg_maybe_add_timer):
1216 * keyboard.c (readable_events):
1217 * process.c (wait_reading_process_output):
1218 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1219
1220 * insdel.c (adjust_markers_gap_motion):
1221 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1222 (gap_left, gap_right): Don't call it.
1223
2ecf6fdb
CY
12242011-03-25 Chong Yidong <cyd@stupidchicken.com>
1225
1226 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1227 incurred during fontification.
1228
6b1f9ba4
JB
12292011-03-25 Juanma Barranquero <lekktu@gmail.com>
1230
1231 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1232 (DEFVAR_PER_BUFFER): Don't pass it.
1233
1234 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1235 (scrolling_window): Don't pass it.
1236
0f4a96b5
JB
12372011-03-25 Juanma Barranquero <lekktu@gmail.com>
1238
1239 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1240
1241 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1242 and `suffix'.
1243 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1244 of variables specific to SELinux and computation of `encoded_absname'.
1245
1246 * image.c (XPutPixel): Remove unused variable `height'.
1247
1248 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1249
1250 * unexw32.c (get_section_info): Remove unused variable `section'.
1251
1252 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1253 (system_process_attributes): Remove unused variable `sess'.
1254 (sys_read): Remove unused variable `err'.
1255
1256 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1257 (w32_wnd_proc): Remove unused variable `isdead'.
1258 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1259 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1260 (x_create_tip_frame): Remove unused variable `tem'.
1261
1262 * w32inevt.c (w32_console_read_socket):
1263 Remove unused variable `no_events'.
1264
1265 * w32term.c (x_draw_composite_glyph_string_foreground):
1266 Remove unused variable `width'.
1267
1149507c
JB
12682011-03-24 Juanma Barranquero <lekktu@gmail.com>
1269
1270 * w32term.c (x_set_glyph_string_clipping):
1271 Don't pass uninitialized region to CombineRgn.
1272
9c88f339
JB
12732011-03-23 Juanma Barranquero <lekktu@gmail.com>
1274
1275 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1276 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1277 (Fx_close_connection): Remove unused variable `i'.
1278
1279 * w32font.c (w32font_draw): Return number of glyphs.
1280 (w32font_open_internal): Remove unused variable `i'.
1281 (w32font_driver): Add missing initializer.
1282
1283 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1284 (fill_in_menu): Remove unused variable `items_added'.
1285
1286 * w32term.c (last_mouse_press_frame): Remove static global variable.
1287 (w32_clip_to_row): Remove unused variable `f'.
1288 (x_delete_terminal): Remove unused variable `i'.
1289
1290 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1291 (NOTHING): Remove unused static global variable.
1292 (uniscribe_check_otf): Remove unused variable `table'.
1293 (uniscribe_font_driver): Add missing initializers.
1294
dee091a3
JD
12952011-03-23 Julien Danjou <julien@danjou.info>
1296
1297 * term.c (Fsuspend_tty, Fresume_tty):
1298 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1299 * window.c (temp_output_buffer_show):
1300 * insdel.c (signal_before_change):
1301 * frame.c (Fhandle_switch_frame):
1302 * fileio.c (Fdo_auto_save):
1303 * emacs.c (Fkill_emacs):
1304 * editfns.c (save_excursion_restore):
1305 * cmds.c (internal_self_insert):
1306 * callint.c (Fcall_interactively):
1307 * buffer.c (Fkill_all_local_variables):
1308 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1309 Use Frun_hooks.
0f4a96b5 1310 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1311 unconditionnaly since it does the check itself.
1312
2c520ab5 13132011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1314
c9c49752
PE
1315 Fix more problems found by GCC 4.5.2's static checks.
1316
8abc3f12
PE
1317 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1318 the first time through the loop, since we know p0 < p1 then.
1319 This also avoids a gcc -Wstrict-overflow warning.
1320
a2d26660
PE
1321 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1322 leading to a memory leak, possible in functions like
1323 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1324 of objects (Bug#8318).
a2d26660 1325
916c72e9
PE
1326 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1327 that could (at least in theory) be that large.
1328
19ab8a18
PE
1329 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1330 This is less likely to overflow, and avoids undefined behavior if
1331 overflow does occur. All callers changed. Use strtoul to scan
1332 for the unsigned long integer.
b7cbbd6f
PE
1333 (pint2hrstr): Simplify and tune code slightly.
1334 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1335
f0641eff
PE
1336 * scroll.c (do_scrolling): Work around GCC bug 48228.
1337 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1338
7f650bb9
PE
1339 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1340 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1341 (validate_x_resource_name): Simplify count usage.
1342 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1343
37dd57d1
PE
1344 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1345 fail (Bug#8306).
81e56e61 1346
699979fc 1347 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1348
401bf9b4
PE
1349 * process.c (Fmake_network_process): Use socklen_t, not int,
1350 where POSIX says socklen_t is required in portable programs.
1351 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1352 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1353 (Fmake_network_process, server_accept_connection):
1354 (wait_reading_process_output, read_process_output):
1355 Likewise.
1356
b93aacde
PE
1357 * process.c: Rename or move locals to avoid shadowing.
1358 (list_processes_1, Fmake_network_process):
1359 (read_process_output_error_handler, exec_sentinel_error_handler):
1360 Rename or move locals.
4dc343ee 1361 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1362 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1363 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1364 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1365 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1366
af8a867c 1367 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1368 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1369 Include tparam.h instead, since it declares them.
af8a867c
PE
1370 * cm.h (PC): Remove extern decl; tparam.h now does this.
1371 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1372 * terminfo.c: Include tparam.h, to check interfaces.
1373 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1374 (tparam): Adjust signature to match interface in tparam.h;
1375 this removes some undefined behavior. Check that outstring and len
1376 are zero, which they always are with Emacs.
1377 * tparam.h (PC, BC, UP): New extern decls.
1378
0248044d 1379 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1380 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1381
8ff096c1 1382 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1383 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1384 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1385 (ftfont_list): Remove unused local.
49eaafba
PE
1386 (get_adstyle_property, ftfont_pattern_entity):
1387 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1388 Rename locals to avoid shadowing.
8ff096c1 1389
e2be39f6
PE
1390 * xfont.c (xfont_list_family): Mark var as initialized.
1391
c9735e30
PE
1392 * xml.c (make_dom): Now static.
1393
8f5201ae
PE
1394 * composite.c (composition_compute_stop_pos): Rename local to
1395 avoid shadowing.
b246f932
PE
1396 (composition_reseat_it): Remove unused locals.
1397 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1398 (composition_update_it): Mark var as initialized.
11b61122
PE
1399 (find_automatic_composition): Mark vars as initialized,
1400 with a FIXME (Bug#8290).
8f5201ae 1401
760fbc2c
PE
1402 character.h: Rename locals to avoid shadowing.
1403 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1404 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1405 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1406 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1407 to avoid shadowing.
1408
ff08eb85
PE
1409 * textprop.c (property_change_between_p): Remove; unused.
1410
fc7bf025
PE
1411 * intervals.c (interval_start_pos): Now static.
1412
235d7abc
PE
1413 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1414
44f230aa
SM
1415 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1416 Rename locals to avoid shadowing.
3e7d6594 1417
50060332
PE
1418 * sound.c (wav_play, au_play, Fplay_sound_internal):
1419 Fix pointer signedness.
d01f234b 1420 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1421 (wav_play): Initialize a variable to 0, to prevent undefined
1422 behavior (Bug#8278).
50060332 1423
c4fc4e30
PE
1424 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1425
918436ed
PE
1426 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1427
c939f91b
PE
1428 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1429 clobbering (Bug#8298).
b9c7f648
PE
1430 * sysdep.c (sys_subshell): Likewise.
1431 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1432
6bd8c144
PE
1433 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1434 This should get cleaned up, so that child_setup has the
1435 same signature on all platforms.
1436
7710357c 1437 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1438 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1439
c59da222
CY
14402011-03-22 Chong Yidong <cyd@stupidchicken.com>
1441
1442 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1443 not to be necessary, and produces flickering.
1444
66b87493
GM
14452011-03-20 Glenn Morris <rgm@gnu.org>
1446
1447 * config.in: Remove file.
1448
45b6f6d5
JB
14492011-03-20 Juanma Barranquero <lekktu@gmail.com>
1450
1451 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1452 are now in src/globals.h.
1453 (syms_of_minibuf): Remove spurious & from previous change.
1454
3ec03f7e
LL
14552011-03-20 Leo <sdl.web@gmail.com>
1456
1457 * minibuf.c (completing-read-function): New variable.
1458 (completing-read-default): Rename from completing-read.
1459 (completing-read): Call completing-read-function.
1460
b14e3e21
CY
14612011-03-19 Juanma Barranquero <lekktu@gmail.com>
1462
1463 * xfaces.c (Fx_load_color_file):
1464 Read color file from absolute filename (bug#8250).
1465
f2b726e6
JB
14662011-03-19 Juanma Barranquero <lekktu@gmail.com>
1467
1468 * makefile.w32-in: Update dependencies.
1469
09f6ff02
EZ
14702011-03-17 Eli Zaretskii <eliz@gnu.org>
1471
1472 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1473
29a6015a
PE
14742011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1475
a3a6c54e
PE
1476 Fix more problems found by GCC 4.5.2's static checks.
1477
b766f867
PE
1478 * process.c (make_serial_process_unwind, send_process_trap):
1479 (sigchld_handler): Now static.
1480
be02381c
PE
1481 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1482 That way, the code declares only the vars that it needs.
1483 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1484 * s/cygwin.h (PTY_ITERATION): Likewise.
1485 * s/darwin.h (PTY_ITERATION): Likewise.
1486 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1487
57048744
PE
1488 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1489 * process.c (allocate_pty): Don't declare stb unless it's needed.
1490
7914961c 1491 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1492 (CONSTANTLIM): Remove; unused.
1493 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1494 Define only if needed.
7914961c 1495
b3967b18
PE
1496 * unexelf.c (unexec): Name an expression,
1497 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1498 Use a different way to cause a compilation error if anyone uses
1499 n rather than nn, a way that does not involve shadowing.
73366a00 1500 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1501
29a6015a
PE
1502 * deps.mk (unexalpha.o): Remove; unused.
1503
43cfc33e 1504 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1505 * unexec.h: New file.
ce701a33
PE
1506 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1507 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1508 Depend on unexec.h.
1509 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1510 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1511 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1512 Change as necessary to match prototype in unexec.h.
ce701a33 1513
01f44d5a
PE
1514 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1515 shadowing.
4f63c6bb 1516 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1517
a6670b0b
PE
1518 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1519 Rename locals to avoid shadowing.
1520
cef2010d 1521 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1522 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1523
d4d7173a
PE
1524 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1525
f08b802a
PE
1526 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1527 warning when compiling print.c.
1528
3ddb0639
PE
1529 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1530 instead of using an uninitialized var.
5ad03b97 1531 (font_sort_entities): Mark var as initialized.
3ddb0639 1532
170a2692
PE
1533 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1534
e663c700
PE
1535 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1536 pointers to constants.
89bc529a 1537 (font_parse_fcname): Remove unused vars.
7b81e2d0 1538 (font_delete_unmatched): Now static.
ea838e10 1539 (font_get_spec): Remove; unused.
13a547c6
PE
1540 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1541 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1542 Rename or move locals to avoid shadowing.
e663c700 1543
2a80c887 1544 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1545 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1546
1384fa33 1547 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1548 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1549
8b2c52e9
PE
1550 * alloc.c (mark_backtrace): Move decl from here ...
1551 * lisp.h: ... to here, so that it can be checked.
1552
475545b5 1553 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1554 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1555 (lisp_indirect_variable): Name an expression,
1556 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1557 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1558
b1349114 1559 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1560 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1561 Use const pointer when appropriate.
b1349114 1562
a2928364
PE
1563 * lisp.h (get_system_name, get_operating_system_release):
1564 Move decls here, to check interfaces.
1565 * process.c (get_operating_system_release): Move decl to lisp.h.
1566 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1567 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1568 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1569 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1570 (Fformat_time_string, Fencode_time, Finsert_char):
1571 (Ftranslate_region_internal, Fformat):
1572 Rename or remove local vars to avoid shadowing.
9710023e 1573 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1574
a415e694
PE
1575 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1576 avoid shadowing.
1577
8ef4622d
PE
1578 * lisp.h (eassert): Check that the argument compiles, even if
1579 ENABLE_CHECKING is not defined.
1580
946f9a5b
PE
1581 * data.c (Findirect_variable): Name an expression, to avoid
1582 gcc -Wbad-function-cast warning.
112396d6 1583 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1584 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1585 (Fmake_variable_buffer_local, Fmake_local_variable):
1586 Mark variables as initialized.
52746918 1587 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1588
e5aab7e7 1589 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1590 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1591 Rename locals to avoid shadowing.
dff45157
PE
1592 (mark_stack): Move local variables into the #ifdef region where
1593 they're used.
7bc26fdb
PE
1594 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1595 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1596 needed otherwise.
1597 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1598 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1599 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1600
e5aab7e7
PE
1601 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1602 avoids undefined behavior in theory.
1603
4da60324
PE
1604 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1605
88043301
PE
1606 Use functions, not macros, for up- and down-casing (Bug#8254).
1607 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1608 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1609 to use the following functions instead of these macros.
1610 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1611 EMACS_INT, since callers assume the returned value fits in int.
1612 (upcase1): Likewise, for UPCASE_TABLE.
1613 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1614 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1615 the race-condition problem in the old DOWNCASE.
88043301 1616
19ed5445
PE
1617 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1618 Rename locals to avoid shadowing.
1619 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1620 (regex_compile, re_search_2, re_match_2_internal):
1621 Remove unused local vars.
952db0d7
PE
1622 (FREE_VAR): Rewrite so as not to use empty "else",
1623 which gcc can warn about.
da053e48 1624 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1625 (RETALLOC_IF): Define only if needed.
1626 (WORDCHAR_P): Likewise. This one is never needed, but is used
1627 only in a comment talking about a compiler bug, so put inside
1628 the #if 0 of that comment.
1629 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1630 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1631 Remove; unused.
19ed5445 1632
1f3561e4 1633 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1634 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1635 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1636
ded6f8f7
PE
1637 * search.c (simple_search): Remove unused var.
1638
dbd37a95
PE
1639 * dired.c (compile_pattern): Move decl from here ...
1640 * lisp.h: ... to here, so that it can be checked.
1641 (struct re_registers): New forward decl.
1642
7e47afad
PE
1643 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1644
85f24f61
PE
1645 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1646 All uses changed.
1647 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1648 Rename locals to avoid shadowing.
5671df8f 1649 (Fvertical_motion): Mark locals as initialized.
85f24f61 1650
181aa2be 1651 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1652 (casify_region): Mark local as initialized.
181aa2be 1653
930d429c
PE
1654 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1655
7082eac6
PE
1656 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1657 New macros, so that the caller can use some names other than
1658 gcpro1, gcpro2, etc.
1659 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1660 of the new macros.
1661 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1662 argument, for consistency with GCPRO2_VAR, etc: it is now the
1663 prefix of the variable, not the variable itself. All uses
1664 changed.
38b2c076
PE
1665 * dired.c (directory_files_internal, file_name_completion):
1666 Rename locals to avoid shadowing.
1667
15206ed9
PE
1668 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1669 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1670 dired.c's scmp function, had undefined behavior.
1671 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1672 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1673 * buffer.h: ... to here, because these macros use current_buffer,
1674 and the new implementation with inline functions needs to have
1675 current_buffer in scope now, rather than later when the macros
1676 are used.
1677 (downcase, upcase1): New static inline functions.
1678 (DOWNCASE, UPCASE1): Reimplement using these functions.
1679 This avoids undefined behavior in expressions like
1680 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1681 from race conditions in accessing the global variables
1682 case_temp1 and case_temp2.
1683 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1684 * lisp.h (case_temp1, case_temp2): Remove their decls.
1685 * character.h (ASCII_CHAR_P): Move from here ...
1686 * lisp.h: ... to here, so that the inline functions mentioned
1687 above can use them.
1688
4a6bea26
PE
1689 * dired.c (directory_files_internal_unwind): Now static.
1690
f14b7e14
PE
1691 * fileio.c (file_name_as_directory, directory_file_name):
1692 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1693 Now static.
2893f146
PE
1694 (file_name_as_directory): Use const pointers when appropriate.
1695 (Fexpand_file_name): Likewise. In particular, newdir might
1696 point at constant storage, so make it a const pointer.
fd4ead52 1697 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1698 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1699 signedness issues.
f839df0c
PE
1700 (Fset_file_times, Finsert_file_contents, auto_save_error):
1701 Rename locals to avoid shadowing.
f14b7e14 1702
5716756e 1703 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1704 (Ftry_completion, Fall_completions): Rename or remove locals
1705 to avoid shadowing.
5716756e 1706
b4c3046a
PE
1707 * marker.c (bytepos_to_charpos): Remove; unused.
1708
b45db522
PE
1709 * lisp.h (verify_bytepos, count_markers): New decls,
1710 so that gcc does not warn that these functions aren't declared.
1711
85876d07
PE
1712 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1713 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1714 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1715 (copy_text): Remove unused local var.
85876d07 1716
03d78a21 1717 * filelock.c (within_one_second): Now static.
b3dd38ab 1718 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1719
5df8f01b
PE
1720 * buffer.c (fix_overlays_before): Mark locals as initialized.
1721 (fix_start_end_in_overlays): Likewise. This function should be
1722 simplified by using pointers-to-pointers, but that's a different
1723 matter.
b1d876f1 1724 (switch_to_buffer_1): Now static.
8f54f30a
PE
1725 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1726 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1727
a70072c9 1728 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1729 Fix pointer signedness issue.
edced198
PE
1730 (sys_subshell): Mark local as volatile if checking for lint,
1731 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1732 (MAXPATHLEN): Define only if needed.
a70072c9 1733
a0977c44
PE
1734 * process.c (serial_open, serial_configure): Move decls from here ...
1735 * systty.h: ... to here, so that they can be checked.
1736
a884fdcc
PE
1737 * fns.c (get_random, seed_random): Move extern decls from here ...
1738 * lisp.h: ... to here, so that they can be checked.
1739
604efe86 1740 * sysdep.c (reset_io): Now static.
b8950c94 1741 (wait_for_termination_signal): Remove; unused.
604efe86 1742
38fc62d9
PE
1743 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1744 (copy_keymap_item, append_key, push_text_char_description):
1745 Now static.
1004a21a 1746 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1747 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1748 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1749 (describe_map_tree):
1750 Rename locals to avoid shadowing.
38fc62d9 1751
2f2650da
PE
1752 * keyboard.c: Declare functions static if they are not used elsewhere.
1753 (echo_char, echo_dash, cmd_error, top_level_2):
1754 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1755 (read_char, kbd_buffer_get_event, make_lispy_position):
1756 (make_lispy_event, make_lispy_movement, apply_modifiers):
1757 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1758 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1759 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1760 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1761 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1762
a053e86c 1763 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1764 (mark_kboards): Move decl here ...
1765 * alloc.c (mark_kboards): ... from here.
a053e86c 1766
4752793e
PE
1767 * lisp.h (force_auto_save_soon): New decl.
1768
74f10ca7 1769 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1770 (DEFINE_DUMMY_FUNCTION): New macro.
1771 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1772 Use it.
c03cd23f
PE
1773 (main): Add casts to avoid warnings
1774 if GCC considers string literals to be constants.
74f10ca7 1775
022e70d4
PE
1776 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1777
59d6fe83
PE
1778 * dbusbind.c: Pointer signedness fixes.
1779 (xd_signature, xd_append_arg, xd_initialize):
1780 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1781 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1782 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1783 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1784
78320123
PE
1785 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1786 if GCC considers string literals to be constants.
49cebcca 1787 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1788
35ac2a97
SM
17892011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1790
fb103ca9
SM
1791 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1792 (print_preprocess, print_object): New macro to fix last change.
1793
35ac2a97
SM
1794 * print.c (print_preprocess): Don't forget font objects.
1795
62973b41
JB
17962011-03-16 Juanma Barranquero <lekktu@gmail.com>
1797
1798 * emacs.c (USAGE3): Doc fixes.
1799
0e48bb22
AS
18002011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1801
1802 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1803 structure.
1804
7684e57b
JB
18052011-03-14 Juanma Barranquero <lekktu@gmail.com>
1806
1807 * lisp.h (VWindow_system, Qfile_name_history):
1808 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1809 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1810 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1811
1812 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1813 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1814
1815 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1816 * w32console.c (detect_input_pending, read_input_pending)
1817 (encode_terminal_code):
1818 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1819 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1820 (w32_system_caret_y, Qfile_name_history):
1821 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1822 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1823 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1824 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1825 * w32proc.c (Qlocal, report_file_error):
1826 * w32term.c (Vwindow_system, updating_frame):
1827 * w32uniscribe.c (initialized, uniscribe_font_driver):
1828 Remove unneeded extern declarations.
1829
2aa46d6c
CY
18302011-03-14 Chong Yidong <cyd@stupidchicken.com>
1831
c96bbc66 1832 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1833
cffc6f3b
CY
18342011-03-13 Chong Yidong <cyd@stupidchicken.com>
1835
1836 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1837 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1838 These macros can no longer be used for assignment.
1839
44f230aa
SM
1840 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1841 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1842 (record_buffer_markers, fetch_buffer_markers): New functions for
1843 recording and fetching special buffer markers.
1844 (set_buffer_internal_1, set_buffer_temp): Use them.
1845
1846 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1847
1848 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1849
1850 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1851 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1852
1853 * xdisp.c (hscroll_window_tree):
1854 (reconsider_clip_changes): Use PT instead of BUF_PT.
1855
d251f04b
EZ
18562011-03-13 Eli Zaretskii <eliz@gnu.org>
1857
1858 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1859 $(EMACS_ROOT)/lib/intprops.h.
1860
f0c77cd1
PE
18612011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1862
3eca4629
PE
1863 Fix more problems found by GCC 4.5.2's static checks.
1864
7c86ee98
PE
1865 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1866 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1867 (xg_free_frame_widgets): Make it clear that a local variable is
1868 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1869 (gdk_window_get_screen): Make it clear that this macro is needed
1870 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1871 (int_gtk_range_get_value): New function, which avoids a diagnostic
1872 from gcc -Wbad-function-cast.
1873 (xg_set_toolkit_scroll_bar_thumb): Use it.
1874 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1875 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1876 (get_utf8_string, xg_get_file_with_chooser):
1877 Rename locals to avoid shadowing.
1878 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1879
41729b81
PE
1880 * xgselect.c (xg_select): Remove unused var.
1881
f0c77cd1
PE
1882 * image.c (four_corners_best): Mark locals as initialized.
1883 (gif_load): Initialize transparent_p to zero (Bug#8238).
1884 Mark another local as initialized.
ec6cf4c6 1885 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1886
ce0ad53d 1887 * image.c (clear_image_cache): Now static.
d5d5a617 1888 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1889 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1890 (x_edge_detection): Remove unnecessary cast that
1891 gcc -Wbad-function-cast diagnoses.
2037898d 1892 (gif_load): Fix pointer signedness.
6ae141d6
PE
1893 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1894 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1895
33383987 18962011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1897
d32df629
PE
1898 Improve quality of tests for time stamp overflow.
1899 For example, without this patch (encode-time 0 0 0 1 1
1900 1152921504606846976) returns the obviously-bogus value (-948597
1901 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1902 reports time overflow. See
1903 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1904 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1905 * editfns.c: Include limits.h and intprops.h.
1906 (TIME_T_MIN, TIME_T_MAX): New macros.
1907 (time_overflow): Move earlier, to before first use.
1908 (hi_time, lo_time): New functions, for an accurate test for
1909 out-of-range times.
1910 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1911 (Fget_internal_run_time): Don't assume time_t fits in int.
1912 (make_time): Use list2 instead of Fcons twice.
1913 (Fdecode_time): More accurate test for out-of-range times.
1914 (check_tm_member): New function.
1915 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1916 (lisp_time_argument): Don't rely on undefined left-shift and
1917 right-shift behavior when checking for time stamp overflow.
8be6f318 1918
fe31d94c
PE
1919 * editfns.c (time_overflow): New function, refactoring common code.
1920 (Fformat_time_string, Fdecode_time, Fencode_time):
1921 (Fcurrent_time_string): Use it.
1922
8be6f318
PE
1923 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1924 * dired.c (make_time): Move to ...
1925 * editfns.c (make_time): ... here.
1926 * systime.h: Note the move.
1927
09d9db2c 19282011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1929
126bc0dc
YM
1930 * fringe.c (update_window_fringes): Remove unused variables.
1931
c47cbdfd
YM
1932 * unexmacosx.c (copy_data_segment): Also copy __got section.
1933 (Bug#8223)
1934
7ac80be9
EZ
19352011-03-12 Eli Zaretskii <eliz@gnu.org>
1936
c96bbc66 1937 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1938 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1939 Constify `char *' arguments and their references according to
1940 prototypes in tparam.h.
1941
ecb0f94d 1942 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1943
7ac80be9
EZ
1944 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1945 Adapt all references accordingly.
1946
1947 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1948
ef1fd07e
TT
19492011-03-11 Tom Tromey <tromey@redhat.com>
1950
1951 * buffer.c (syms_of_buffer): Remove obsolete comment.
1952
7ef4b50c
EZ
19532011-03-11 Eli Zaretskii <eliz@gnu.org>
1954
1955 * termhooks.h (encode_terminal_code): Declare prototype.
1956
1957 * msdos.c (encode_terminal_code): Don't declare prototype.
1958
1959 * term.c (encode_terminal_code): Now external again, used by
1960 w32console.c and msdos.c.
1961
44f230aa
SM
1962 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1963 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1964
4b1ec863 19652011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1966
1714f52b 1967 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1968
4b1ec863
PE
1969 * fringe.c (update_window_fringes): Mark locals as initialized
1970 (Bug#8227).
1971 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1972
524c7aa6
PE
1973 * alloc.c (mark_fringe_data): Move decl from here ...
1974 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1975 to check its interface.
1976 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1977
a5c0af81 1978 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1979 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1980 (fontset_font): Mark local as initialized.
a9a06e0b 1981 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1982
b4716021
PE
1983 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1984
811e9bac 1985 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1986 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1987 (x_own_selection, Fx_disown_selection_internal): Rename locals
1988 to avoid shadowing.
1989 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1990
7e3ab302
PE
1991 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1992 so that the caller can use some name other than gcpro1.
1993 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1994 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1995 (Fx_backspace_delete_keys_p):
1996 Use them to avoid shadowing, and rename vars to avoid shadowing.
1997 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1998 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1999 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2000 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2001 Remove unused locals.
7e3ab302
PE
2002 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2003 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2004 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2005 macros.
f78faa98 2006
e2b13473
PE
2007 * xterm.h (x_mouse_leave): New decl.
2008
77f23912
PE
2009 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2010 Remove unused functions.
cdf4ba58
PE
2011 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2012 (x_calc_absolute_position): Now static.
7411c686 2013 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2014 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2015 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2016 unless they are used.
38d0b34a
PE
2017 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2018 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2019 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2020 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2021 (x_error_catcher, x_connection_closed, x_error_handler):
2022 (x_error_quitter, xembed_send_message, x_iconify_frame):
2023 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2024 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2025 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2026
44f230aa
SM
2027 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2028 Rename or move locals to avoid shadowing.
6b463e58 2029 (tty_defined_color, merge_face_heights): Now static.
5967d051 2030 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2031 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2032 does not deduce is never used uninitialized.
73719eba
PE
2033 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2034 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2035
426994c3 2036 * terminal.c (store_terminal_param): Now static.
5489860b 2037
032f1620 2038 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2039 (set_frame_menubar): Remove unused local.
d4323972 2040 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2041 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2042 since they might point to immutable storage.
281585b0
PE
2043 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2044 since it's unused otherwise.
032f1620 2045
367c19e5 2046 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2047 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2048 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2049 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2050 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2051 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2052 does not deduce are never used uninitialized.
70739cbe 2053
07b48fa9
PE
2054 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2055
8868a238 2056 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2057 * window.c (window_loop, size_window):
2058 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2059
7e5cf297 2060 * window.c (display_buffer): Now static.
d6550a9f
PE
2061 (size_window): Mark variables that gcc -Wuninitialized
2062 does not deduce are never used uninitialized.
a586633d
PE
2063 * window.h (check_all_windows): New decl, to forestall
2064 gcc -Wmissing-prototypes diagnostic.
5b555da1 2065 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2066
f6095868
PE
2067 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2068 shadowing.
2069 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2070 Include <limits.h>.
2071 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2072 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2073 (load_charset_map): Mark variables that gcc -Wuninitialized
2074 does not deduce are never used uninitialized.
53df7c11 2075 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2076
f38b440c
PE
2077 * coding.c (coding_set_source, coding_set_destination):
2078 Use "else { /* comment */ }" rather than "else /* comment */;"
2079 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2080 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2081 a block, when the outer 'i' will do.
2082 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2083 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2084 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2085 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2086 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2087 Rename locals to avoid shadowing.
2088 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2089 * coding.c (emacs_mule_char, encode_invocation_designation):
2090 Now static, since they're not used elsewhere.
413bb2db 2091 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2092 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2093 (decode_coding_emacs_mule): Mark variables that gcc
2094 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2095 (detect_coding_iso_2022): Initialize a local variable that might
2096 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2097 this initialization is needed. (Bug#8211)
5f58e762
PE
2098 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2099 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2100 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2101 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2102 Remove unused macros.
f38b440c 2103
232b38b9 2104 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2105 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2106 * character.c (string_count_byte8): Likewise.
232b38b9 2107
fb90da1b
PE
2108 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2109 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2110
fb93dbc2
PE
2111 * chartab.c (copy_sub_char_table): Now static, since it's not used
2112 elsewhere.
5c156ace
PE
2113 (sub_char_table_ref_and_range, char_table_ref_and_range):
2114 Rename locals to avoid shadowing.
bbcd0949 2115 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2116
7d3b3862 2117 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2118 (BIDI_BOB): Remove unused macro.
7d3b3862 2119
6be7d3da
PE
2120 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2121 deduce are never used uninitialized.
c2ed9c8b 2122 * term.c (encode_terminal_code): Likewise.
6be7d3da 2123
75f8807f 2124 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2125
50938595
PE
2126 * tparam.h: New file.
2127 * term.c, tparam.h: Include it.
2128 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2129 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2130 Move these decls to tparam.h, and make them agree with what
2131 is actually in tparam.c. The previous trick of using incompatible
2132 decls in different modules does not conform to the C standard.
2133 All callers of tparam changed to use tparam's actual API.
2134 * tparam.c (tparam1, tparam, tgoto):
2135 Use const pointers where appropriate.
2136
fbceeba2
PE
2137 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2138 * cm.h (struct cm): Likewise.
2139 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2140 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2141 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2142 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2143 (turn_on_face, init_tty): Likewise.
2144 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2145
7f3f1250
PE
2146 * term.c (term_mouse_position): Rename local to avoid shadowing.
2147
e6ca6543
PE
2148 * alloc.c (mark_ttys): Move decl from here ...
2149 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2150
c40f8d15
AS
21512011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2152
2153 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2154
cfe0661d
JB
21552011-03-09 Juanma Barranquero <lekktu@gmail.com>
2156
2157 * search.c (compile_pattern_1): Remove argument regp, unused since
2158 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2159 (compile_pattern): Don't pass it.
2160
0afb4571
J
21612011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2162
2163 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2164 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2165 for ! HAVE_GTK3.
2166 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2167
2168 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2169
2170 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2171 gdk_window_get_screen, gdk_window_get_geometry,
2172 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2173 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2174 (xg_get_pixbuf_from_pixmap): New function.
2175 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2176 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2177 Call xg_get_pixbuf_from_pixmap instead of
2178 gdk_pixbuf_get_from_drawable.
2179 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2180 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2181 (xg_check_special_colors): Use GtkStyleContext and its functions
2182 for HAVE_GTK3.
2183 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2184 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2185 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2186 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2187 Call gtk_widget_get_preferred_size.
0afb4571
J
2188 (xg_frame_resized): gdk_window_get_geometry only takes 5
2189 parameters.
44f230aa
SM
2190 (xg_win_to_widget, xg_event_is_for_menubar):
2191 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2192 (xg_set_widget_bg): New function.
2193 (delete_cb): New function.
2194 (xg_create_frame_widgets): connect delete-event to delete_cb.
2195 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2196 (xg_set_background_color): Call xg_set_widget_bg.
2197 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2198 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2199 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2200 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2201 if ! HAVE_GTK3.
2202 (update_frame_tool_bar): Call gtk_widget_hide.
2203 (xg_initialize): Use GDK_KEY_g.
2204
2205 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2206 if ! HAVE_GTK3
2207 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2208
2209 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2210 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2211 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2212
1c2cc4ef
JB
22132011-03-08 Juanma Barranquero <lekktu@gmail.com>
2214
2215 * w32xfns.c (select_palette): Check success of RealizePalette against
2216 GDI_ERROR, not zero.
2217
33383987 2218See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2219
2220;; Local Variables:
2221;; coding: utf-8
aac0c6e3
MR
2222;; End:
2223
33383987 2224 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2225
2226 This file is part of GNU Emacs.
2227
2228 GNU Emacs is free software: you can redistribute it and/or modify
2229 it under the terms of the GNU General Public License as published by
2230 the Free Software Foundation, either version 3 of the License, or
2231 (at your option) any later version.
2232
2233 GNU Emacs is distributed in the hope that it will be useful,
2234 but WITHOUT ANY WARRANTY; without even the implied warranty of
2235 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2236 GNU General Public License for more details.
2237
2238 You should have received a copy of the GNU General Public License
2239 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.