* lwlib-utils.c (XtCompositeChildren): Likewise.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
4887c6e2 12011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 2
b58c5c4a
PE
3 * insdel.c (make_gap_smaller): Define only if
4 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5
cad59032
PE
6 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7 it.
8
c339dc2e
PE
9 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
10 so that we aren't warned about unused symbols.
11
91a3e27b
PE
12 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
13
94578f9c
PE
14 * xdisp.c (x_produce_glyphs): Avoid possibly-uninitialized
15 var (Bug#8512).
7a3fb125 16
8ffc96f5
PE
17 * xfns.c (x_real_positions): Mark locals as initialized.
18
eef9bc79
PE
19 * xmenu.c (xmenu_show): Don't use uninitialized vars.
20
098db9dd
PE
21 * xterm.c: Fix problems found by static analysis with other toolkits.
22 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
23 (x_dispatch_event): Declare static if USE_GTK, and
24 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 25 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 26 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
098db9dd
PE
27 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only if
28 defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
29
eb18f6cc
PE
30 * xmenu.c (menu_help_callback): Pointer type fixes.
31 Use const pointers when pointing at readonly data. Avoid pointer
32 signedness clashes.
33 (FALSE): Remove unused macro.
34 (update_frame_menubar): Remove unused decl.
35
1fe72bf8
PE
36 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
37
60d9e1db
PE
38 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
39 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
40 (single_menu_item): Rename local to avoid shadowing.
41
39261c26
PE
42 * keyboard.c (make_lispy_event): Remove unused local var.
43
018c5e19
PE
44 * frame.c, frame.h (x_get_resource_string): Bring this back, but
45 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
46
63d2b86e
PE
47 * bitmaps: Change bitmaps from unsigned char back to the X11
48 compatible char. Avoid the old compiler warnings about
49 out-of-range initializers by using, for example, '\xab' rather
50 than 0xab.
51
aefd87e1
PE
52 * xgselect.c (xgselect_initialize): Check vs interface
53 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
54
bf501fb9
PE
55 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
56
e9829fdf
PE
57 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
58 to read-only memory.
59
1086c095
PE
60 * fns.c (vector): Remove; this old hack is no longer needed.
61
2baccd04 62 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 63 Remove unused var.
dde42981 64 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 65
72391843 66 * xrdb.c (x_load_resources): Omit unused local.
3565b346 67
436c16df 68 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 69 (x_window): Rename locals to avoid shadowing.
dc5ddd85 70 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 71
92bb796d 72 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 73 (x_term_init): Remove local to avoid shadowing.
92bb796d 74
764430a3 75 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
76
77 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
78 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
79
4170f62f 802011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 81
71b41406
PE
82 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
83
9587a89d
PE
84 emacs_write: Accept and return EMACS_INT for sizes.
85 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
86 et seq.
87 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
88 Accept and return EMACS_INT.
89 (emacs_gnutls_write): Return the number of bytes written on
90 partial writes.
91 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
92 (emacs_read, emacs_write): Remove check for negative size, as the
93 Emacs source code has been audited now.
9587a89d
PE
94 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
95 (emacs_read, emacs_write): Use it.
273a5f82
PE
96 * process.c (send_process): Adjust to the new signatures of
97 emacs_write and emacs_gnutls_write. Do not attempt to store
98 a byte offset into an 'int'; it might overflow.
9587a89d 99 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 100
3e047f51
PE
101 * sound.c: Don't assume sizes fit in 'int'.
102 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 103 Return EMACS_INT, not int.
3e047f51 104 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
105 Accept EMACS_INT, not int.
106 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
107 record read return values.
108
cc39a9db
BK
1092011-04-15 Ben Key <bkey76@gmail.com>
110
111 * keyboard.c (Qundefined): Don't declare static since it is
112 used in nsfns.m.
113 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't
114 declare static since they are used in nsfont.m.
115
6c60eb9f
SM
1162011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
117
118 * process.c (Qprocessp): Don't declare static.
119 * lisp.h (Qprocessp): Declare again.
120
7990b61a
JB
1212011-04-15 Juanma Barranquero <lekktu@gmail.com>
122
123 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
124
5d4cb038
PE
1252011-04-14 Paul Eggert <eggert@cs.ucla.edu>
126
8bd7b830 127 Improve C-level modularity by making more things 'static'.
cd64ea1d 128
e3b27b31
PE
129 Don't publish debugger-only interfaces to other modules.
130 * lisp.h (safe_debug_print, debug_output_compilation_hack):
131 (verify_bytepos, count_markers): Move decls to the only modules
132 that need them.
133 * region-cache.h (pp_cache): Likewise.
134 * window.h (check_all_windows): Likewise.
135 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
136
5d4cb038
PE
137 * sysdep.c (croak): Now static, if
138 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
139 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
140
141 * alloc.c (refill_memory_reserve): Now static if
142 !defined REL_ALLOC || defined SYSTEM_MALLOC.
143 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 144
e87b6180
PE
145 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
146 Define only if USE_LUCID.
147
ac64929e
PE
148 * xrdb.c (x_customization_string, x_rm_string): Now static.
149
6f37259d
PE
150 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
151 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
152
1683e3ab
PE
153 * xdisp.c (draw_row_with_mouse_face): Now static.
154 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
155
de9c2632
PE
156 * window.h (check_all_windows): Mark externally visible.
157
2b96acb7
PE
158 * window.c (window_deletion_count): Now static.
159
160 * undo.c: Make symbols static if they're not exported.
161 (last_undo_buffer, last_boundary_position, pending_boundary):
162 Now static.
163
50436f33
PE
164 * textprop.c (interval_insert_behind_hooks): Now static.
165 (interval_insert_in_front_hooks): Likewise.
166
64520e5c
PE
167 * term.c: Make symbols static if they're not exported.
168 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
169 (max_frame_lines, tty_set_terminal_modes):
170 (tty_reset_terminal_modes, tty_turn_off_highlight):
171 (get_tty_terminal): Now static.
172 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
173 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 174 HAVE_WINDOW_SYSTEM.
64520e5c
PE
175 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
176 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
177
1fa53021
PE
178 * sysdep.c: Make symbols static if they're not exported.
179 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
180 Now static.
181 (sigprocmask_set, full_mask): Remove; unused.
182 (wait_debugging): Mark as visible.
183 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
184 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
185
d4b43b22
PE
186 * syntax.c (syntax_temp): Define only if !__GNUC__.
187
b7c513d0
PE
188 * sound.c (current_sound_device, current_sound): Now static.
189
989b29ad
PE
190 * search.c (searchbufs, searchbuf_head): Now static.
191
13a55a78
PE
192 * scroll.c (scroll_cost): Remove; unused.
193 * dispextern.h (scroll_cost): Remove decl.
194
de68a1fc
PE
195 * region-cache.h (pp_cache): Mark as externally visible.
196
40ccffa6
PE
197 * process.c: Make symbols static if they're not exported.
198 (process_tick, update_tick, create_process, chan_process):
199 (Vprocess_alist, proc_buffered_char, datagram_access):
200 (fd_callback_data, send_process_frame, process_sent_to): Now static.
201 (deactivate_process): Mark defn as static, as well as decl.
202 * lisp.h (create_process): Remove decl.
203 * process.h (chan_process, Vprocess_alist): Remove decls.
204
ad64fc97
PE
205 * print.c: Make symbols static if they're not exported.
206 (print_depth, new_backquote_output, being_printed, print_buffer):
207 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
208 (print_interval, print_number_index, initial_stderr_stream):
209 Now static.
210 * lisp.h (Fprinc): Remove decl.
211 (debug_output_compilation_hack): Mark as externally visible.
212
adddb265
PE
213 * sysdep.c (croak): Move decl from here to syssignal.h.
214 * syssignal.h (croak): Put it here, so the API can be checked when
215 'croak' is called from dissociate_if_controlling_tty.
216
1717ede2
PE
217 * minibuf.c: Make symbols static if they're not exported.
218 (minibuf_save_list, choose_minibuf_frame): Now static.
219 * lisp.h (choose_minibuf_frame): Remove decl.
220
fa5fb2bc
PE
221 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
222
1e3890d1
PE
223 * lread.c: Make symbols static if they're not exported.
224 (read_objects, initial_obarray, oblookup_last_bucket_number):
225 Now static.
226 (make_symbol): Remove; unused.
227 * lisp.h (initial_obarray, make_symbol): Remove decls.
228
8a1414fa
PE
229 * keyboard.c: Make symbols static if they're not exported.
230 (single_kboard, recent_keys_index, total_keys, recent_keys):
231 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
232 (this_single_command_key_start, echoing, last_auto_save):
233 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
234 (command_loop, echo_now, keyboard_init_hook, help_char_p):
235 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
236 (Vlispy_mouse_stem, double_click_count):
237 Now static.
238 (force_auto_save_soon): Define only if SIGDANGER.
239 (ignore_mouse_drag_p): Now static if
240 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
241 (print_help): Remove; unused.
242 (stop_character, last_timer_event): Mark as externally visible.
243 * keyboard.h (ignore_mouse_drag_p): Declare only if
244 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
245 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
246 * lisp.h (echoing): Remove decl.
247 (force_auto_save_soon): Declare only if SIGDANGER.
248 * xdisp.c (redisplay_window): Simplify code, to make it more
249 obvious that ignore_mouse_drag_p is not accessed if !defined
250 USE_GTK && !defined HAVE_NS.
251
93ea6e8f
PE
252 * intervals.c: Make symbols static if they're not exported.
253 (merge_properties_sticky, merge_interval_right, delete_interval):
254 Now static.
255 * intervals.h (merge_interval_right, delete_interval): Remove decls.
256
77382fcc
PE
257 * insdel.c: Make symbols static if they're not exported.
258 However, leave prepare_to_modify_buffer alone. It's never
259 called from outside this function, but that appears to be a bug.
260 (combine_after_change_list, combine_after_change_buffer):
4889fc82 261 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
262 (adjust_after_replace_noundo): Remove; unused.
263 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 264 (signal_before_change): Remove decls.
77382fcc 265
9306c32e
PE
266 * indent.c (val_compute_motion, val_vmotion): Now static.
267
cd44d2eb
PE
268 * image.c: Make symbols static if they're not exported.
269 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
270 if USE_GTK.
271 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
272 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
273
ad9a7a06
PE
274 * fringe.c (standard_bitmaps): Now static.
275 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
276
81626931
PE
277 * frame.c: Make symbols static if they're not exported.
278 (x_report_frame_params, make_terminal_frame): Now static.
279 (get_frame_param): Now static, unless HAVE_NS.
280 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
281 (x_get_resource_string): Remove; not used.
282 * frame.h (make_terminal_frame, x_report_frame_params):
283 (x_get_resource_string); Remove decls.
284 (x_fullscreen_adjust): Declare only if WINDOWSNT.
285 * lisp.h (get_frame_param): Declare only if HAVE_NS.
286
239f9db9
PE
287 * font.c, fontset.c: Make symbols static if they're not exported.
288 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
289 (FACE_SUITABLE_FOR_CHAR_P): Use it.
290 * font.c (font_close_object): Now static.
291 * font.h (font_close_object): Remove.
292 * fontset.c (FONTSET_OBJLIST): Remove.
293 (free_realized_fontset) #if-0 the body, which does nothing.
294 (face_suitable_for_char_p): #if-0, as it's never called.
295 * fontset.h (face_suitable_for_char_p): Remove decl.
296 * xfaces.c (face_at_string_position): Use
297 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
298 since 0 is always ASCII.
299
dfcf3579
PE
300 * fns.c (weak_hash_tables): Now static.
301
5045092b
PE
302 * fileio.c: Make symbols static if they're not exported.
303 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
304 (Vwrite_region_annotation_buffers): Now static.
305
57a96f5c
PE
306 * eval.c: Make symbols static if they're not exported.
307 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
308 * lisp.h (backtrace_list): Remove decl.
309
35f08c38
PE
310 * emacs.c: Make symbols static if they're not exported.
311 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
312 (fatal_error_code, fatal_error_signal_hook, standard_args):
313 Now static.
314 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
315 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
316 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
317 * lisp.h (fatal_error_signal_hook): Remove decl.
318 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
319
f44bd759
PE
320 * editfns.c: Move a (normally-unused) function to its only use.
321 * editfns.c, lisp.h (get_operating_system_release): Remove.
322 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
323 worth the hassle of breaking this out.
324
b532497d
PE
325 * xterm.c: Make symbols static if they're not exported.
326 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
327 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
328 (x_destroy_window, x_delete_display):
329 Now static.
330 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
331 (x_mouse_leave): Remove; unused.
332 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
333 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
334 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
335 Remove decls.
336 (x_mouse_leave): Declare only if WINDOWSNT.
337 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
338 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
339 USE_X_TOOLKIT.
340
1675728f
PE
341 * ftxfont.c: Make symbols static if they're not exported.
342 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
343 HAVE_FREETYPE.
344 * font.h (ftxfont_driver): Likewise.
345
e4cebfca
PE
346 * xfns.c: Make symbols static if they're not exported.
347 (x_last_font_name, x_display_info_for_name):
348 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
349 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
350 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
351 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
352 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
353 (last_show_tip_args): Now static.
354 (xic_defaut_fontset, xic_create_fontsetname): Define only if
355 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
356 (x_screen_planes): Remove; unused.
357 * dispextern.h (x_screen_planes): Remove decl.
358
5bf46f05
PE
359 * dispnew.c: Make symbols static if they're not exported.
360 * dispextern.h (redraw_garbaged_frames, scrolling):
361 (increment_row_positions): Remove.
362 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
363 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
364 Now static.
365 (redraw_garbaged_frames): Remove; unused.
366
435f4c28
PE
367 * xfaces.c: Make symbols static if they're not exported.
368 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
369 Remove decls.
370 * xterm.h (defined_color): Remove decls.
371 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
372 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
373 (menu_face_changed_default, defined_color, free_realized_face):
374 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
375 (ascii_face_of_lisp_face): Remove; unused.
376
8524aef3
PE
377 * xdisp.c: Make symbols static if they're not exported.
378 * dispextern.h (scratch_glyph_row, window_box_edges):
379 (glyph_to_pixel_coords, set_cursor_from_row):
380 (get_next_display_element, set_iterator_to_next):
381 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
382 (show_mouse_face): Remove decls
383 * frame.h (message_buf_print): Likewise.
384 * lisp.h (pop_message, set_message, check_point_in_composition):
385 Likewise.
386 * xterm.h (set_vertical_scroll_bar): Likewise.
387 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
388 (message_buf_print, scratch_glyph_row, displayed_buffer):
389 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
390 (get_next_display_element, show_mouse_face, window_box_edges):
391 (frame_to_window_pixel_xy, check_point_in_composition):
392 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
393 (glyph_to_pixel_coords): Remove; unused.
394
16390cd2
PE
395 * dired.c (file_name_completion): Now static.
396
397 * dbusbind.c (xd_in_read_queued_messages): Now static.
398
a25f4dfa
PE
399 * lisp.h (circular_list_error, FOREACH): Remove; unused.
400 * data.c (circular_list_error): Remove.
401
14a9c8df
PE
402 * commands.h (last_point_position, last_point_position_buffer):
403 (last_point_position_window): Remove decls.
404 * keyboard.c: Make these variables static.
405
74ab6df5
PE
406 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
407 decls.
408 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
409 (iso_code_class, detect_coding, code_convert_region): Now static.
410 (encode_coding_gap): Remove; unused.
411
38dfbee1
PE
412 * chartab.c (chartab_chars, chartab_bits): Now static.
413
a2cb4e63
PE
414 * charset.h (charset_iso_8859_1): Remove decl.
415 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
416 Now static.
417
127198fd
PE
418 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
419 * ccl.c (Vccl_program_table): Now static.
420 (check_ccl_update): Remove; unused.
421
d85b608f
PE
422 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
423 * category.h: ... from here.
424 * category.c (check_category_table, set_category_set): Now static.
425
31cd66f3
PE
426 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
427 * lisp.h: Remove these decls.
428
c358e587
PE
429 * buffer.c (buffer_count): Remove unused var.
430
e78aecca
PE
431 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
432 so that it's not optimized away.
433 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
434 * dispextern.h (bidi_dump_cached_states): Remove, since it's
435 exported only to the debugger.
436
e192d7d3
PE
437 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
438 * atimer.h (run_all_atimers): Removed; not exported.
439
92470028
PE
440 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
441 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
442 was inaccessible from Lisp.
443 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
444 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
445
244ed907
PE
446 alloc.c: Import and export fewer symbols, and remove unused items.
447 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
448 is defined.
449 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
450 it's not optimized away by whole-program optimization.
451 (message_enable_multibyte, free_misc): Remove.
452 (catchlist, handlerlist, mark_backtrace):
453 Declare only if BYTE_MARK_STACK.
454 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
455 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
456 (message_enable_multibyte): Remove decl.
457 (free_misc, interval_free_list, float_block, float_block_index):
458 (n_float_blocks, float_free_list, cons_block, cons_block_index):
459 (cons_free_list, last_marked_index):
460 Now static.
461 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
462 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
463 (mark_backtrace): Define only if BYTE_MARK_STACK.
464 * xdisp.c (message_enable_multibyte): Now static.
465
955cbe7b
PE
466 Declare Lisp_Object Q* variables to be 'static' if not exproted.
467 This makes it easier for human readers (and static analyzers)
468 to see whether these variables are used from other modules.
469 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
470 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
471 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
472 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
473 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
474 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
475 * xmenu.c, xselect.c:
476 Declare Q* vars static if they are not used in other modules.
477 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
478 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
479 Remove decls of unexported vars.
480 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
481
95c82688
PE
482 * lisp.h (DEFINE_FUNC): Make sname 'static'.
483
16a97296
PE
484 Make Emacs functions such as Fatom 'static' by default.
485 This makes it easier for human readers (and static analyzers)
486 to see whether these functions can be called from other modules.
487 DEFUN now defines a static function. To make the function external
488 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
489 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
490 (Finit_image_library):
16a97296
PE
491 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
492 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
493 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
494 Remove decls, since these functions are now static.
495 (Funintern, Fget_internal_run_time): New decls, since these functions
496 were already external.
95c82688 497
16a97296
PE
498 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
499 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
500 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
501 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
502 * keyboard.c, keymap.c, lread.c:
503 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
504 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
505 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
506 Mark functions with DEFUE instead of DEFUN,
507 if they are used in other modules.
508 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
509 decls for now-static functions.
510 * buffer.h (Fdelete_overlay): Remove decl.
511 * callproc.c (Fgetenv_internal): Mark as internal.
512 * composite.c (Fremove_list_of_text_properties): Remove decl.
513 (Fcomposition_get_gstring): New forward static decl.
514 * composite.h (Fcomposite_get_gstring): Remove decl.
515 * dired.c (Ffile_attributes): New forward static decl.
516 * doc.c (Fdocumntation_property): New forward static decl.
517 * eval.c (Ffetch_bytecode): New forward static decl.
518 (Funintern): Remove extern decl; now in .h file where it belongs.
519 * fileio.c (Fmake_symbolic_link): New forward static decl.
520 * image.c (Finit_image_library): New forward static decl.
521 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
522 * intervals.h (Fprevious_property_change):
523 (Fremove_list_of_text_properties): Remove decls.
524 * keyboard.c (Fthis_command_keys): Remove decl.
525 (Fcommand_execute): New forward static decl.
526 * keymap.c (Flookup_key): New forward static decl.
527 (Fcopy_keymap): Now static.
528 * keymap.h (Flookup_key): Remove decl.
529 * process.c (Fget_process): New forward static decl.
530 (Fprocess_datagram_address): Mark as internal.
531 * syntax.c (Fsyntax_table_p): New forward static decl.
532 (skip_chars): Remove duplicate decl.
533 * textprop.c (Fprevious_property_change): New forward static decl.
534 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
535 Now internal.
536 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
537 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
538
785bbd42
PE
539 * editfns.c (Fformat): Remove unreachable code.
540
8b913b57
AS
5412011-04-14 Andreas Schwab <schwab@linux-m68k.org>
542
543 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
544 change. (Bug#8496)
545
a6744a35
EZ
5462011-04-13 Eli Zaretskii <eliz@gnu.org>
547
548 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
549 when at ZV. (Bug#8487)
550
e7974947
AS
5512011-04-12 Andreas Schwab <schwab@linux-m68k.org>
552
baad03f0
AS
553 * charset.c (Fclear_charset_maps): Use xfree instead of free.
554 (Bug#8437)
555 * keyboard.c (parse_tool_bar_item): Likewise.
556 * sound.c (sound_cleanup, alsa_close): Likewise.
557 * termcap.c (tgetent): Likewise.
558 * xfns.c (x_default_font_parameter): Likewise.
559 * xsettings.c (read_and_apply_settings): Likewise.
560
e7974947
AS
561 * alloc.c (overrun_check_malloc, overrun_check_realloc)
562 (overrun_check_free): Protoize.
563
28272684
PE
5642011-04-12 Paul Eggert <eggert@cs.ucla.edu>
565
566 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
567 since callers should never pass a negative size.
568 Change the signature to match that of plain 'read' and 'write'; see
569 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
570 * lisp.h: Update prototypes of emacs_write and emacs_read.
571
11997c76
EZ
5722011-04-11 Eli Zaretskii <eliz@gnu.org>
573
574 * xdisp.c (redisplay_window): Don't try to determine the character
575 position of the scroll margin if the window start point w->startp
e896f03c 576 is outside the buffer's accessible region. (Bug#8468)
11997c76 577
8a2cbd72
EZ
5782011-04-10 Eli Zaretskii <eliz@gnu.org>
579
580 Fix write-region and its subroutines for buffers > 2GB.
581 * fileio.c (a_write, e_write): Modify declaration of arguments and
582 local variables to support buffers larger than 2GB.
583 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
584
585 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
586 argument, local variables, and return value.
587
588 * lisp.h: Update prototypes of emacs_write and emacs_read.
589
590 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
591
4073e537 5922011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 593
1ebfdcb6
PE
594 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
595
b2ded58d
PE
596 Fix more problems found by GCC 4.6.0's static checks.
597
7d66342c
PE
598 * xdisp.c (vmessage): Use a better test for character truncation.
599
bbf47d44
PE
600 * charset.c (load_charset_map): <, not <=, for optimization,
601 and to avoid potential problems with integer overflow.
9248994d 602 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 603 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 604 * editfns.c (Fformat): Likewise.
1e69125e 605 * syntax.c (skip_chars): Likewise.
3befa583 606
e3019616
PE
607 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
608 This also lets GCC 4.6.0 generate slightly better loop code.
609
becfa255
PE
610 * callint.c (Fcall_interactively): <, not <=, for optimization.
611 (Fcall_interactively): Count the number of arguments produced,
612 not the number of arguments given. This is simpler and lets GCC
613 4.6.0 generate slightly better code.
614
dae0cd48
PE
615 * ftfont.c: Distingish more carefully between FcChar8 and char.
616 The previous code passed unsigned char * to a functions like
617 strlen and xstrcasecmp that expect char *, which does not
618 conform to the C standard.
619 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
620 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
621 char * when the C standard requires it.
622
76032d70
PE
623 * keyboard.c (read_char): Remove unused var.
624
eb3f1cc8
PE
625 * eval.c: Port to Windows vsnprintf (Bug#8435).
626 Include <limits.h>.
627 (SIZE_MAX): Define if the headers do not.
628 (verror): Do not give up if vsnprintf returns a negative count.
629 Instead, grow the buffer. This ports to Windows vsnprintf, which
630 does not conform to C99. Problem reported by Eli Zaretskii.
631 Also, simplify the allocation scheme, by avoiding the need for
632 calling realloc, and removing the ALLOCATED variable.
633
70476b54
PE
634 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
635
12020a9e
PE
636 Remove invocations of doprnt, as Emacs now uses vsnprintf.
637 But keep the doprint source code for now, as we might revamp it
638 and use it again (Bug#8435).
ea6c7ae6
PE
639 * lisp.h (doprnt): Remove.
640 * Makefile.in (base_obj): Remove doprnt.o.
641 * deps.mk (doprnt.o): Remove.
642
5fdb398c
PE
643 error: Print 32- and 64-bit integers portably (Bug#8435).
644 Without this change, on typical 64-bit hosts error ("...%d...", N)
645 was used to print both 32- and 64-bit integers N, which relied on
646 undefined behavior.
647 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
648 New macro.
649 * lisp.h (error, verror): Mark as printf-like functions.
650 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
651 Report overflow in size calculations when allocating printf buffer.
652 Do not truncate output string at its first null byte.
653 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
654 Truncate the output at a character boundary, since vsnprintf does not
655 do that.
656 * charset.c (check_iso_charset_parameter): Convert internal
657 character to string before calling 'error', since %c now has the
658 printf meaning.
659 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
660 overflow when computing char to be passed to 'error'. Do not
661 pass Lisp_Object to 'error'; pass the integer instead.
662 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
663 formatted with plain %d.
664
b189fa66
PE
665 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
666
bff87ef0
PE
667 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
668
7e2cac20
PE
669 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
670
ce4d90b5
PE
671 * xterm.c (x_catch_errors): Remove duplicate declaration.
672
266c9547
PE
673 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
674
79c49ad2
PE
675 * xdisp.c, lisp.h (message_nolog): Remove; unused.
676
368f4090
JM
6772011-04-10 Jim Meyering <meyering@redhat.com>
678
679 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
680 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
681 return ssize_t not "int", and use size_t as the buffer length.
682 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
683 * gnutls.h: Update declarations.
684 * process.c (read_process_output): Use ssize_t, to match.
685 (send_process): Likewise.
686
a32d4040
CY
6872011-04-09 Chong Yidong <cyd@stupidchicken.com>
688
689 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
690
8546720e 6912011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 692
8546720e
GM
693 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
694 unsigned char, to match FcChar8 type definition.
aac0c6e3 695
8546720e
GM
696 * xterm.c (handle_one_xevent):
697 * xmenu.c (create_and_show_popup_menu):
698 * xselect.c (x_decline_selection_request)
699 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 700
0a2f5c1a 7012011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
702
703 Fix some uses of `int' instead of EMACS_INT.
704 * search.c (string_match_1, fast_string_match)
705 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
706 (scan_buffer, find_next_newline_no_quit)
707 (find_before_next_newline, search_command, Freplace_match)
708 (Fmatch_data): Make some `int' variables be EMACS_INT.
709
710 * xdisp.c (display_count_lines): 3rd argument and return value now
711 EMACS_INT. All callers changed.
712 (pint2hrstr): Last argument is now EMACS_INT.
713
714 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
715 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
716 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
717 (decode_coding_utf_16, decode_coding_emacs_mule)
718 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
719 (decode_coding_ccl, decode_coding_charset)
720 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
721 (decode_coding_iso_2022, decode_coding_emacs_mule)
722 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
723 <char_offset, last_offset>: Declare EMACS_INT.
724 (encode_coding_utf_8, encode_coding_utf_16)
725 (encode_coding_emacs_mule, encode_invocation_designation)
726 (encode_designation_at_bol, encode_coding_iso_2022)
727 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
728 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
729 Declare EMACS_INT.
730 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
731 (encode_invocation_designation): Last argument P_NCHARS is now
732 EMACS_INT.
733 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
734 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
735
736 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
737 All users changed.
738
739 * ccl.c (Fccl_execute_on_string): Declare some variables
740 EMACS_INT.
741
8546720e 7422011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
743
744 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
745
4e19a977
CS
7462011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
747
748 * process.c (Fformat_network_address): Doc fix.
749
87302331
R
7502011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
751
752 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
753
cbb59342
CY
7542011-04-08 Chong Yidong <cyd@stupidchicken.com>
755
756 * keyboard.c (read_char): Call Lisp function help-form-show,
757 instead of using internal_with_output_to_temp_buffer.
758 (Qhelp_form_show): New var.
e0d38eeb 759 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
760
761 * print.c (internal_with_output_to_temp_buffer): Function deleted.
762
763 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
764
e67a13ab
CY
7652011-04-06 Chong Yidong <cyd@stupidchicken.com>
766
767 * process.c (Flist_processes): Removed to Lisp.
768 (list_processes_1): Deleted.
769
973f782d
EZ
7702011-04-06 Eli Zaretskii <eliz@gnu.org>
771
7c106b1e
EZ
772 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
773
973f782d
EZ
774 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
775
41cf7d1a 7762011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 777
ca23cc88
PE
778 Fix more problems found by GCC 4.6.0's static checks.
779
f390e2d5
PE
780 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
781
42eea0d0
PE
782 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
783
b69769da 784 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 785
f9541e84
PE
786 * xdisp.c (vmessage): Mark as a printf-like function.
787
13841b55
PE
788 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
789
c136c10f
PE
790 * sound.c (sound_warning): Don't crash if arg contains a printf format.
791
5e2d4a30
PE
792 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
793 printf-like functions.
794 (tiff_load): Add casts to remove these marks before passing them
795 to system-supplied API.
796
583f48b9
PE
797 * eval.c (Fsignal): Remove excess argument to 'fatal'.
798
b25d760e
PE
799 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
800 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
801 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
802 directly, rather than having caller test rule sign. This avoids
803 some unnecessary tests.
804 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
805 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
806 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 807
bc7b6697 808 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 809 (xfont_open): Avoid unnecessary tests.
bc7b6697 810
27ccc379
PE
811 * composite.c (composition_gstring_put_cache): Use unsigned integer.
812
dcd5c89a
PE
813 * composite.h, composite.c (composition_gstring_put_cache):
814 Use EMACS_INT, not int, for length.
815
b13a45c6
PE
816 * composite.h (COMPOSITION_DECODE_REFS): New macro,
817 breaking out part of COMPOSITION_DECODE_RULE.
818 (COMPOSITION_DECODE_RULE): Use it.
819 * composite.c (get_composition_id): Remove unused local vars,
820 by using the new macro.
821
1e792e4d
PE
822 * textprop.c (set_text_properties_1): Change while to do-while,
823 since the condition is always true at first.
824
dc6c6455 825 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
826 (interval_deletion_adjustment): Return unsigned value.
827 All uses changed.
dc6c6455 828
aba7731a
PE
829 * process.c (list_processes_1, create_pty, read_process_output):
830 (exec_sentinel): Remove vars that were set but not used.
afd4052b 831 (create_pty): Remove unnecessary "volatile"s.
bc57d757 832 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 833 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 834 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 835
fdfc4bf3
PE
836 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
837
fca8fe46 838 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 839 (update_syntax_table): Use unsigned instead of int.
fca8fe46 840
06a0259a 841 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 842 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 843 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 844
e7b9e80f
PE
845 * print.c (print_error_message): Avoid int overflow.
846
56201685
PE
847 * font.c (font_list_entities): Redo for clarity,
848 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
849
78834453 850 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 851 (font_score): Avoid potential overflow in diff calculation.
78834453 852
0bc0b309 853 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 854 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 855
e610eaca
PE
856 * eval.c (funcall_lambda): Rename local to avoid shadowing.
857
b895abce
PE
858 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
859 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
860 can always succeed if overflow has undefined behavior.
861
1f1d9321 862 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 863 (wordify): Omit three unnecessary tests.
1f1d9321 864
c59478bc
PE
865 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
866 All callers changed. This avoids the need for an unused var.
867
79b73827
PE
868 * casefiddle.c (casify_region): Remove var that is set but not used.
869
a4db5dfe
PE
870 * dired.c (file_name_completion): Remove var that is set but not used.
871
43aae36e
PE
872 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
873
2a47c44d 874 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 875 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 876
a37c69bf
PE
877 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
878 Check for integer overflow on size calculations.
879
328ab8e7
PE
880 * buffer.c (Fprevious_overlay_change): Remove var that is set
881 but not used.
882
e5a2a5cb
PE
883 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
884 Remove vars that are set but not used.
8d84a6eb 885 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 886 (timer_check_2): Mark vars as initialized.
e5a2a5cb 887
a60e5f68
PE
888 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
889
f661cb61 890 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 891 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 892
f0397f5a
PE
893 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
894 that are set but not used.
895
8664db06 896 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 897 if XCreateBitmapFromData fails (Bug#8410).
8664db06 898
6abdaa4a
PE
899 * xselect.c (x_get_local_selection, x_handle_property_notify):
900 Remove vars that are set but not used.
901
0ce7538d 902 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 903 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 904
9ae848fc
PE
905 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
906 Remove var that is set but not used.
0b918413
PE
907 (scroll_bar_windows_size): Now size_t, not int.
908 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
909 Check for overflow.
9ae848fc 910
a5a62657
PE
911 * xfaces.c (realize_named_face): Remove vars that are set but not used.
912 (map_tty_color) [!defined MSDOS]: Likewise.
913
5c5cdd39
PE
914 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
915
66ebf983
PE
916 * coding.c: Remove vars that are set but not used.
917 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
918 All callers changed.
919 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
920 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
921 (decode_coding_charset): Remove vars that are set but not used.
922
1be4d761
PE
923 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
924 that is set but not used.
925
47553fa8
PE
926 * print.c (print_object): Remove var that is set but not used.
927
1f7196bf 928 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
929 The gnulib version avoids calling malloc in the usual case,
930 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
931 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
932 * filelock.c (current_lock_owner): Likewise.
933 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
934 * sysdep.c: Include allocator.h, careadlinkat.h.
935 (emacs_no_realloc_allocator): New static constant.
936 (emacs_readlink): New function.
fdb61804
PE
937 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
938 ../lib/careadlinkat.h.
d1fdcab7 939
f84c17c7
SM
9402011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
941
942 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
943 first non-nil return value).
944
ef3862ad
JD
9452011-04-03 Jan Djärv <jan.h.d@swipnet.se>
946
947 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
948 if not defined (Bug#8403).
949
376a7006
JB
9502011-04-02 Juanma Barranquero <lekktu@gmail.com>
951
952 * xdisp.c (display_count_lines): Remove parameter `start',
953 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
954 (get_char_face_and_encoding): Remove parameter `multibyte_p',
955 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
956 (fill_stretch_glyph_string): Remove parameters `row' and `area',
957 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
958 and thereabouts. All callers changed.
959 (get_per_char_metric): Remove parameter `f', unused since
960 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
961
6ca3801d
JM
9622011-04-02 Jim Meyering <meyering@redhat.com>
963
964 do not dereference NULL upon failed strdup
965 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
966 (ns_get_family): Likewise.
967
d8e2b5ba
JB
9682011-04-02 Juanma Barranquero <lekktu@gmail.com>
969
970 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
971
8c74fcbd
JD
9722011-04-02 Jan Djärv <jan.h.d@swipnet.se>
973
974 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
975 later (Bug#8403).
976
7200d79c
SM
9772011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
978
03408648 979 Add lexical binding.
7200d79c 980
03408648
SM
981 * window.c (Ftemp_output_buffer_show): New fun.
982 (Fsave_window_excursion):
983 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
984
985 * lread.c (lisp_file_lexically_bound_p): New function.
986 (Fload): Bind Qlexical_binding.
987 (readevalloop): Remove `evalfun' arg.
988 Bind Qinternal_interpreter_environment.
989 (Feval_buffer): Bind Qlexical_binding.
990 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
991 Mark as dynamic.
992 (syms_of_lread): Declare `lexical-binding'.
993
994 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
995
996 * keyboard.c (eval_dyn): New fun.
997 (menu_item_eval_property): Use it.
ca105506
SM
998
999 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 1000
03408648
SM
1001 * fns.c (concat, mapcar1): Accept byte-code-functions.
1002
1003 * eval.c (Fsetq): Handle lexical vars.
1004 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
1005 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
1006 (FletX, Flet): Obey lexical binding.
1007 (Fcommandp): Handle closures.
1008 (Feval): New `lexical' arg.
1009 (eval_sub): New function extracted from Feval. Use it almost
1010 everywhere where Feval was used. Look up vars in lexical env.
1011 Handle closures.
1012 (Ffunctionp): Move from subr.el.
1013 (Ffuncall): Handle closures.
1014 (apply_lambda): Remove `eval_flags'.
1015 (funcall_lambda): Handle closures and new byte-code-functions.
1016 (Fspecial_variable_p): New function.
1017 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
1018 but without exporting it to Lisp.
23aba0ea 1019
23aba0ea 1020 * doc.c (Fdocumentation, store_function_docstring):
03408648 1021 * data.c (Finteractive_form): Handle closures.
23aba0ea 1022
03408648
SM
1023 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
1024 interactive spec.
ba83908c 1025
03408648
SM
1026 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
1027 byte-codes.
1028 (exec_byte_code): New function extracted from Fbyte_code to handle new
1029 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 1030
03408648 1031 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 1032
03408648 1033 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 1034
e2abce01
JB
10352011-03-31 Juanma Barranquero <lekktu@gmail.com>
1036
1037 * xdisp.c (redisplay_internal): Fix prototype.
1038
63696a73 10392011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 1040
63696a73
EZ
1041 * xdisp.c (SCROLL_LIMIT): New macro.
1042 (try_scrolling): Use it when setting scroll_limit. Limit
1043 scrolling to 100 screen lines.
1044 (redisplay_window): Even when falling back on "recentering",
1045 position point in the window according to scroll-conservatively,
1046 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
1047
1048 (try_scrolling): When point is above the window, allow searching
1049 as far as scroll_max, or one screenful, to compute vertical
1050 distance from PT to the scroll margin position. This prevents
1051 try_scrolling from unnecessarily failing when
1052 scroll-conservatively is set to a value slightly larger than the
1053 window height. Clean up the case of PT below the margin at bottom
1054 of window: scroll_max can no longer be INT_MAX. When aggressive
1055 scrolling is in use, don't let point enter the opposite scroll
1056 margin as result of the scroll.
1057 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
1058 threshold of 100 lines for never-recentering scrolling.
1059
e4cc2dfc
JB
10602011-03-31 Juanma Barranquero <lekktu@gmail.com>
1061
1062 * dispextern.h (move_it_by_lines):
1063 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
1064 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
1065 (message_log_check_duplicate): Remove parameters `prev_bol' and
1066 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
1067 (redisplay_internal): Remove parameter `preserve_echo_area',
1068 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
1069
1070 * indent.c (Fvertical_motion):
1071 * window.c (window_scroll_pixel_based, Frecenter):
1072 Don't pass `need_y_p' to `move_it_by_lines'.
1073
1c470562
SM
10742011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
1075
44f230aa
SM
1076 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
1077 steal a few bits to be more compact.
1078 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
1079 Remove unneeded casts.
1080
1c470562
SM
1081 * bytecode.c (Fbyte_code): CAR and CDR can GC.
1082
888adce9
ZK
10832011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
1084
1085 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
1086 binding" message (bug#7967).
1087
f838ed7b
PE
10882011-03-30 Paul Eggert <eggert@cs.ucla.edu>
1089
77861b95
PE
1090 Fix more problems found by GCC 4.6.0's static checks.
1091
de6dbc14
PE
1092 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
1093 Remove unused local var.
1094
f838ed7b
PE
1095 * editfns.c (Fmessage_box): Remove unused local var.
1096
792c7b2b
PE
1097 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
1098 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1099 Omit unused local vars.
c499e557 1100 * window.c (shrink_windows): Omit unused local var.
b01a1c29 1101 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
1102 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
1103 Omit unused local var.
1104
ba0165e1
PE
1105 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
1106 Don't assume string length fits in int.
32ad8845 1107 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 1108 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 1109
3c59b4c9
PE
1110 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
1111 instead of alloca (Bug#8344).
1112
a3eed478 1113 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 1114 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 1115
eb4d412d
PE
1116 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
1117
1658b401
PE
1118 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
1119 concerns.
1120
1121 * term.c (produce_glyphless_glyph): Remove unnecessary test.
1122
1123 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 1124
9a2c6e05
PE
1125 * keyboard.c (syms_of_keyboard): Use the same style as later
1126 in this function when indexing through an array. This also
1127 works around GCC bug 48267.
1128
03d0a109
PE
1129 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
1130
44f730c8
PE
1131 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
1132
fe75f926
PE
1133 * chartab.c (sub_char_table_ref_and_range): Redo for slight
1134 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
1135
ffa8c828
PE
1136 * keyboard.c, keyboard.h (num_input_events): Now size_t.
1137 This avoids undefined behavior on integer overflow, and is a bit
1138 more convenient anyway since it is compared to a size_t variable.
1139
c5101a77
PE
1140 Variadic C functions now count arguments with size_t, not int.
1141 This avoids an unnecessary limitation on 64-bit machines, which
1142 caused (substring ...) to crash on large vectors (Bug#8344).
1143 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
1144 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 1145 All variadic functions and their callers changed accordingly.
c5101a77
PE
1146 (struct gcpro.nvars): Now size_t, not int. All uses changed.
1147 * data.c (arith_driver, float_arith_driver): Likewise.
1148 * editfns.c (general_insert_function): Likewise.
1149 * eval.c (struct backtrace.nargs, interactive_p)
1150 (internal_condition_case_n, run_hook_with_args, apply_lambda)
1151 (funcall_lambda, mark_backtrace): Likewise.
1152 * fns.c (concat): Likewise.
1153 * frame.c (x_set_frame_parameters): Likewise.
1154 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
1155 0 if not found, not -1. All callers changed.
1156
dd3f25f7
PE
1157 * alloc.c (garbage_collect): Don't assume stack size fits in int.
1158 (stack_copy_size): Now size_t, not int.
1159 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
1160
461c2ab9
JB
11612011-03-28 Juanma Barranquero <lekktu@gmail.com>
1162
1163 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
1164 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1165 All callers changed.
1166
1167 * lisp.h (multibyte_char_to_unibyte):
1168 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1169 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1170 * character.h (CHAR_TO_BYTE8):
1171 * cmds.c (internal_self_insert):
1172 * editfns.c (general_insert_function):
1173 * keymap.c (push_key_description):
1174 * search.c (Freplace_match):
1175 * xdisp.c (message_dolog, set_message_1): All callers changed.
1176
f6d62986
SM
11772011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1178
1179 * keyboard.c (safe_run_hook_funcall): New function.
1180 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1181 don't set the hook to nil, but remove the offending function instead.
1182 (Qcommand_hook_internal): Remove, unused.
1183 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1184 Vcommand_hook_internal.
1185
1186 * eval.c (enum run_hooks_condition): Remove.
1187 (funcall_nil, funcall_not): New functions.
1188 (run_hook_with_args): Call each function through a `funcall' argument.
1189 Remove `cond' argument, now redundant.
1190 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1191 (Frun_hook_with_args_until_failure): Adjust accordingly.
1192 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1193
1db5b1ad
JB
11942011-03-28 Juanma Barranquero <lekktu@gmail.com>
1195
1196 * dispextern.h (string_buffer_position): Remove declaration.
1197
1198 * print.c (strout): Remove parameter `multibyte', unused since
1199 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1200
1201 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1202 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1203 All callers changed.
1204
1205 * w32.c (_wsa_errlist): Use braces for struct initializers.
1206
1207 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1208 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1209 All callers changed.
1210 (string_buffer_position): Likewise. Also, make static (it's never
1211 used outside xdisp.c).
1212 (cursor_row_p): Remove parameter `w', unused since
1213 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1214 (decode_mode_spec): Remove parameter `precision', introduced during
1215 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1216 All callers changed.
1217
5ffb62aa
JD
12182011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1219
1220 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1221
461c2ab9 12222011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1223
1224 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1225 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1226 (ns_update_auto_hide_menu_bar): New functions.
1227 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1228 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1229 ns_constrain_all_frames.
1230 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1231 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1232
5c380ffb
JD
12332011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1234
1235 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1236
9af30bdf
GM
12372011-03-27 Glenn Morris <rgm@gnu.org>
1238
1239 * syssignal.h: Replace RETSIGTYPE with void.
1240 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1241 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1242 Replace SIGTYPE with void everywhere.
1243 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1244 * s/template.h (SIGTYPE): Remove commented out definition.
1245
e2abce01
JB
12462011-03-26 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1249 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1250
f868cd8a
JB
12512011-03-26 Juanma Barranquero <lekktu@gmail.com>
1252
59eb0929
JB
1253 * w32.c (read_unc_volume): Use parameter `henum', instead of
1254 global variable `wget_enum_handle'.
1255
1256 * keymap.c (describe_vector): Remove parameters `indices' and
1257 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1258 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1259
f868cd8a
JB
1260 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1261
1262 * keyboard.c (timer_check): Remove parameter `do_it_now',
1263 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1264 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1265 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1266
1267 * keyboard.c (read_char):
1268 * w32menu.c (w32_menu_display_help):
1269 * xmenu.c (show_help_event, menu_help_callback):
1270 Adjust calls to `show_help_echo'.
1271
1272 * gtkutil.c (xg_maybe_add_timer):
1273 * keyboard.c (readable_events):
1274 * process.c (wait_reading_process_output):
1275 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1276
1277 * insdel.c (adjust_markers_gap_motion):
1278 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1279 (gap_left, gap_right): Don't call it.
1280
2ecf6fdb
CY
12812011-03-25 Chong Yidong <cyd@stupidchicken.com>
1282
1283 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1284 incurred during fontification.
1285
6b1f9ba4
JB
12862011-03-25 Juanma Barranquero <lekktu@gmail.com>
1287
1288 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1289 (DEFVAR_PER_BUFFER): Don't pass it.
1290
1291 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1292 (scrolling_window): Don't pass it.
1293
0f4a96b5
JB
12942011-03-25 Juanma Barranquero <lekktu@gmail.com>
1295
1296 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1297
1298 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1299 and `suffix'.
1300 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1301 of variables specific to SELinux and computation of `encoded_absname'.
1302
1303 * image.c (XPutPixel): Remove unused variable `height'.
1304
1305 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1306
1307 * unexw32.c (get_section_info): Remove unused variable `section'.
1308
1309 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1310 (system_process_attributes): Remove unused variable `sess'.
1311 (sys_read): Remove unused variable `err'.
1312
1313 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1314 (w32_wnd_proc): Remove unused variable `isdead'.
1315 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1316 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1317 (x_create_tip_frame): Remove unused variable `tem'.
1318
1319 * w32inevt.c (w32_console_read_socket):
1320 Remove unused variable `no_events'.
1321
1322 * w32term.c (x_draw_composite_glyph_string_foreground):
1323 Remove unused variable `width'.
1324
1149507c
JB
13252011-03-24 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * w32term.c (x_set_glyph_string_clipping):
1328 Don't pass uninitialized region to CombineRgn.
1329
9c88f339
JB
13302011-03-23 Juanma Barranquero <lekktu@gmail.com>
1331
1332 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1333 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1334 (Fx_close_connection): Remove unused variable `i'.
1335
1336 * w32font.c (w32font_draw): Return number of glyphs.
1337 (w32font_open_internal): Remove unused variable `i'.
1338 (w32font_driver): Add missing initializer.
1339
1340 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1341 (fill_in_menu): Remove unused variable `items_added'.
1342
1343 * w32term.c (last_mouse_press_frame): Remove static global variable.
1344 (w32_clip_to_row): Remove unused variable `f'.
1345 (x_delete_terminal): Remove unused variable `i'.
1346
1347 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1348 (NOTHING): Remove unused static global variable.
1349 (uniscribe_check_otf): Remove unused variable `table'.
1350 (uniscribe_font_driver): Add missing initializers.
1351
dee091a3
JD
13522011-03-23 Julien Danjou <julien@danjou.info>
1353
1354 * term.c (Fsuspend_tty, Fresume_tty):
1355 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1356 * window.c (temp_output_buffer_show):
1357 * insdel.c (signal_before_change):
1358 * frame.c (Fhandle_switch_frame):
1359 * fileio.c (Fdo_auto_save):
1360 * emacs.c (Fkill_emacs):
1361 * editfns.c (save_excursion_restore):
1362 * cmds.c (internal_self_insert):
1363 * callint.c (Fcall_interactively):
1364 * buffer.c (Fkill_all_local_variables):
1365 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1366 Use Frun_hooks.
0f4a96b5 1367 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1368 unconditionnaly since it does the check itself.
1369
2c520ab5 13702011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1371
c9c49752
PE
1372 Fix more problems found by GCC 4.5.2's static checks.
1373
8abc3f12
PE
1374 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1375 the first time through the loop, since we know p0 < p1 then.
1376 This also avoids a gcc -Wstrict-overflow warning.
1377
a2d26660
PE
1378 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1379 leading to a memory leak, possible in functions like
1380 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1381 of objects (Bug#8318).
a2d26660 1382
916c72e9
PE
1383 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1384 that could (at least in theory) be that large.
1385
19ab8a18
PE
1386 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1387 This is less likely to overflow, and avoids undefined behavior if
1388 overflow does occur. All callers changed. Use strtoul to scan
1389 for the unsigned long integer.
b7cbbd6f
PE
1390 (pint2hrstr): Simplify and tune code slightly.
1391 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1392
f0641eff
PE
1393 * scroll.c (do_scrolling): Work around GCC bug 48228.
1394 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1395
7f650bb9
PE
1396 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1397 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1398 (validate_x_resource_name): Simplify count usage.
1399 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1400
37dd57d1
PE
1401 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1402 fail (Bug#8306).
81e56e61 1403
699979fc 1404 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1405
401bf9b4
PE
1406 * process.c (Fmake_network_process): Use socklen_t, not int,
1407 where POSIX says socklen_t is required in portable programs.
1408 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1409 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1410 (Fmake_network_process, server_accept_connection):
1411 (wait_reading_process_output, read_process_output):
1412 Likewise.
1413
b93aacde
PE
1414 * process.c: Rename or move locals to avoid shadowing.
1415 (list_processes_1, Fmake_network_process):
1416 (read_process_output_error_handler, exec_sentinel_error_handler):
1417 Rename or move locals.
4dc343ee 1418 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1419 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1420 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1421 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1422 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1423
af8a867c 1424 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1425 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1426 Include tparam.h instead, since it declares them.
af8a867c
PE
1427 * cm.h (PC): Remove extern decl; tparam.h now does this.
1428 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1429 * terminfo.c: Include tparam.h, to check interfaces.
1430 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1431 (tparam): Adjust signature to match interface in tparam.h;
1432 this removes some undefined behavior. Check that outstring and len
1433 are zero, which they always are with Emacs.
1434 * tparam.h (PC, BC, UP): New extern decls.
1435
0248044d 1436 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1437 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1438
8ff096c1 1439 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1440 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1441 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1442 (ftfont_list): Remove unused local.
49eaafba
PE
1443 (get_adstyle_property, ftfont_pattern_entity):
1444 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1445 Rename locals to avoid shadowing.
8ff096c1 1446
e2be39f6
PE
1447 * xfont.c (xfont_list_family): Mark var as initialized.
1448
c9735e30
PE
1449 * xml.c (make_dom): Now static.
1450
8f5201ae
PE
1451 * composite.c (composition_compute_stop_pos): Rename local to
1452 avoid shadowing.
b246f932
PE
1453 (composition_reseat_it): Remove unused locals.
1454 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1455 (composition_update_it): Mark var as initialized.
11b61122
PE
1456 (find_automatic_composition): Mark vars as initialized,
1457 with a FIXME (Bug#8290).
8f5201ae 1458
760fbc2c
PE
1459 character.h: Rename locals to avoid shadowing.
1460 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1461 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1462 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1463 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1464 to avoid shadowing.
1465
ff08eb85
PE
1466 * textprop.c (property_change_between_p): Remove; unused.
1467
fc7bf025
PE
1468 * intervals.c (interval_start_pos): Now static.
1469
235d7abc
PE
1470 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1471
44f230aa
SM
1472 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1473 Rename locals to avoid shadowing.
3e7d6594 1474
50060332
PE
1475 * sound.c (wav_play, au_play, Fplay_sound_internal):
1476 Fix pointer signedness.
d01f234b 1477 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1478 (wav_play): Initialize a variable to 0, to prevent undefined
1479 behavior (Bug#8278).
50060332 1480
c4fc4e30
PE
1481 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1482
918436ed
PE
1483 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1484
c939f91b
PE
1485 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1486 clobbering (Bug#8298).
b9c7f648
PE
1487 * sysdep.c (sys_subshell): Likewise.
1488 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1489
6bd8c144
PE
1490 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1491 This should get cleaned up, so that child_setup has the
1492 same signature on all platforms.
1493
7710357c 1494 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1495 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1496
c59da222
CY
14972011-03-22 Chong Yidong <cyd@stupidchicken.com>
1498
1499 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1500 not to be necessary, and produces flickering.
1501
66b87493
GM
15022011-03-20 Glenn Morris <rgm@gnu.org>
1503
1504 * config.in: Remove file.
1505
45b6f6d5
JB
15062011-03-20 Juanma Barranquero <lekktu@gmail.com>
1507
1508 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1509 are now in src/globals.h.
1510 (syms_of_minibuf): Remove spurious & from previous change.
1511
3ec03f7e
LL
15122011-03-20 Leo <sdl.web@gmail.com>
1513
1514 * minibuf.c (completing-read-function): New variable.
1515 (completing-read-default): Rename from completing-read.
1516 (completing-read): Call completing-read-function.
1517
b14e3e21
CY
15182011-03-19 Juanma Barranquero <lekktu@gmail.com>
1519
1520 * xfaces.c (Fx_load_color_file):
1521 Read color file from absolute filename (bug#8250).
1522
f2b726e6
JB
15232011-03-19 Juanma Barranquero <lekktu@gmail.com>
1524
1525 * makefile.w32-in: Update dependencies.
1526
09f6ff02
EZ
15272011-03-17 Eli Zaretskii <eliz@gnu.org>
1528
1529 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1530
29a6015a
PE
15312011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1532
a3a6c54e
PE
1533 Fix more problems found by GCC 4.5.2's static checks.
1534
b766f867
PE
1535 * process.c (make_serial_process_unwind, send_process_trap):
1536 (sigchld_handler): Now static.
1537
be02381c
PE
1538 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1539 That way, the code declares only the vars that it needs.
1540 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1541 * s/cygwin.h (PTY_ITERATION): Likewise.
1542 * s/darwin.h (PTY_ITERATION): Likewise.
1543 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1544
57048744
PE
1545 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1546 * process.c (allocate_pty): Don't declare stb unless it's needed.
1547
7914961c 1548 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1549 (CONSTANTLIM): Remove; unused.
1550 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1551 Define only if needed.
7914961c 1552
b3967b18
PE
1553 * unexelf.c (unexec): Name an expression,
1554 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1555 Use a different way to cause a compilation error if anyone uses
1556 n rather than nn, a way that does not involve shadowing.
73366a00 1557 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1558
29a6015a
PE
1559 * deps.mk (unexalpha.o): Remove; unused.
1560
43cfc33e 1561 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1562 * unexec.h: New file.
ce701a33
PE
1563 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1564 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1565 Depend on unexec.h.
1566 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1567 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1568 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1569 Change as necessary to match prototype in unexec.h.
ce701a33 1570
01f44d5a
PE
1571 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1572 shadowing.
4f63c6bb 1573 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1574
a6670b0b
PE
1575 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1576 Rename locals to avoid shadowing.
1577
cef2010d 1578 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1579 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1580
d4d7173a
PE
1581 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1582
f08b802a
PE
1583 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1584 warning when compiling print.c.
1585
3ddb0639
PE
1586 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1587 instead of using an uninitialized var.
5ad03b97 1588 (font_sort_entities): Mark var as initialized.
3ddb0639 1589
170a2692
PE
1590 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1591
e663c700
PE
1592 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1593 pointers to constants.
89bc529a 1594 (font_parse_fcname): Remove unused vars.
7b81e2d0 1595 (font_delete_unmatched): Now static.
ea838e10 1596 (font_get_spec): Remove; unused.
13a547c6
PE
1597 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1598 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1599 Rename or move locals to avoid shadowing.
e663c700 1600
2a80c887 1601 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1602 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1603
1384fa33 1604 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1605 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1606
8b2c52e9
PE
1607 * alloc.c (mark_backtrace): Move decl from here ...
1608 * lisp.h: ... to here, so that it can be checked.
1609
475545b5 1610 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1611 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1612 (lisp_indirect_variable): Name an expression,
1613 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1614 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1615
b1349114 1616 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1617 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1618 Use const pointer when appropriate.
b1349114 1619
a2928364
PE
1620 * lisp.h (get_system_name, get_operating_system_release):
1621 Move decls here, to check interfaces.
1622 * process.c (get_operating_system_release): Move decl to lisp.h.
1623 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1624 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1625 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1626 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1627 (Fformat_time_string, Fencode_time, Finsert_char):
1628 (Ftranslate_region_internal, Fformat):
1629 Rename or remove local vars to avoid shadowing.
9710023e 1630 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1631
a415e694
PE
1632 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1633 avoid shadowing.
1634
8ef4622d
PE
1635 * lisp.h (eassert): Check that the argument compiles, even if
1636 ENABLE_CHECKING is not defined.
1637
946f9a5b
PE
1638 * data.c (Findirect_variable): Name an expression, to avoid
1639 gcc -Wbad-function-cast warning.
112396d6 1640 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1641 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1642 (Fmake_variable_buffer_local, Fmake_local_variable):
1643 Mark variables as initialized.
52746918 1644 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1645
e5aab7e7 1646 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1647 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1648 Rename locals to avoid shadowing.
dff45157
PE
1649 (mark_stack): Move local variables into the #ifdef region where
1650 they're used.
7bc26fdb
PE
1651 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1652 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1653 needed otherwise.
1654 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1655 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1656 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1657
e5aab7e7
PE
1658 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1659 avoids undefined behavior in theory.
1660
4da60324
PE
1661 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1662
88043301
PE
1663 Use functions, not macros, for up- and down-casing (Bug#8254).
1664 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1665 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1666 to use the following functions instead of these macros.
1667 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1668 EMACS_INT, since callers assume the returned value fits in int.
1669 (upcase1): Likewise, for UPCASE_TABLE.
1670 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1671 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1672 the race-condition problem in the old DOWNCASE.
88043301 1673
19ed5445
PE
1674 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1675 Rename locals to avoid shadowing.
1676 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1677 (regex_compile, re_search_2, re_match_2_internal):
1678 Remove unused local vars.
952db0d7
PE
1679 (FREE_VAR): Rewrite so as not to use empty "else",
1680 which gcc can warn about.
da053e48 1681 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1682 (RETALLOC_IF): Define only if needed.
1683 (WORDCHAR_P): Likewise. This one is never needed, but is used
1684 only in a comment talking about a compiler bug, so put inside
1685 the #if 0 of that comment.
1686 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1687 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1688 Remove; unused.
19ed5445 1689
1f3561e4 1690 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1691 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1692 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1693
ded6f8f7
PE
1694 * search.c (simple_search): Remove unused var.
1695
dbd37a95
PE
1696 * dired.c (compile_pattern): Move decl from here ...
1697 * lisp.h: ... to here, so that it can be checked.
1698 (struct re_registers): New forward decl.
1699
7e47afad
PE
1700 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1701
85f24f61
PE
1702 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1703 All uses changed.
1704 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1705 Rename locals to avoid shadowing.
5671df8f 1706 (Fvertical_motion): Mark locals as initialized.
85f24f61 1707
181aa2be 1708 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1709 (casify_region): Mark local as initialized.
181aa2be 1710
930d429c
PE
1711 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1712
7082eac6
PE
1713 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1714 New macros, so that the caller can use some names other than
1715 gcpro1, gcpro2, etc.
1716 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1717 of the new macros.
1718 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1719 argument, for consistency with GCPRO2_VAR, etc: it is now the
1720 prefix of the variable, not the variable itself. All uses
1721 changed.
38b2c076
PE
1722 * dired.c (directory_files_internal, file_name_completion):
1723 Rename locals to avoid shadowing.
1724
15206ed9
PE
1725 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1726 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1727 dired.c's scmp function, had undefined behavior.
1728 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1729 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1730 * buffer.h: ... to here, because these macros use current_buffer,
1731 and the new implementation with inline functions needs to have
1732 current_buffer in scope now, rather than later when the macros
1733 are used.
1734 (downcase, upcase1): New static inline functions.
1735 (DOWNCASE, UPCASE1): Reimplement using these functions.
1736 This avoids undefined behavior in expressions like
1737 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1738 from race conditions in accessing the global variables
1739 case_temp1 and case_temp2.
1740 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1741 * lisp.h (case_temp1, case_temp2): Remove their decls.
1742 * character.h (ASCII_CHAR_P): Move from here ...
1743 * lisp.h: ... to here, so that the inline functions mentioned
1744 above can use them.
1745
4a6bea26
PE
1746 * dired.c (directory_files_internal_unwind): Now static.
1747
f14b7e14
PE
1748 * fileio.c (file_name_as_directory, directory_file_name):
1749 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1750 Now static.
2893f146
PE
1751 (file_name_as_directory): Use const pointers when appropriate.
1752 (Fexpand_file_name): Likewise. In particular, newdir might
1753 point at constant storage, so make it a const pointer.
fd4ead52 1754 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1755 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1756 signedness issues.
f839df0c
PE
1757 (Fset_file_times, Finsert_file_contents, auto_save_error):
1758 Rename locals to avoid shadowing.
f14b7e14 1759
5716756e 1760 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1761 (Ftry_completion, Fall_completions): Rename or remove locals
1762 to avoid shadowing.
5716756e 1763
b4c3046a
PE
1764 * marker.c (bytepos_to_charpos): Remove; unused.
1765
b45db522
PE
1766 * lisp.h (verify_bytepos, count_markers): New decls,
1767 so that gcc does not warn that these functions aren't declared.
1768
85876d07
PE
1769 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1770 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1771 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1772 (copy_text): Remove unused local var.
85876d07 1773
03d78a21 1774 * filelock.c (within_one_second): Now static.
b3dd38ab 1775 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1776
5df8f01b
PE
1777 * buffer.c (fix_overlays_before): Mark locals as initialized.
1778 (fix_start_end_in_overlays): Likewise. This function should be
1779 simplified by using pointers-to-pointers, but that's a different
1780 matter.
b1d876f1 1781 (switch_to_buffer_1): Now static.
8f54f30a
PE
1782 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1783 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1784
a70072c9 1785 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1786 Fix pointer signedness issue.
edced198
PE
1787 (sys_subshell): Mark local as volatile if checking for lint,
1788 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1789 (MAXPATHLEN): Define only if needed.
a70072c9 1790
a0977c44
PE
1791 * process.c (serial_open, serial_configure): Move decls from here ...
1792 * systty.h: ... to here, so that they can be checked.
1793
a884fdcc
PE
1794 * fns.c (get_random, seed_random): Move extern decls from here ...
1795 * lisp.h: ... to here, so that they can be checked.
1796
604efe86 1797 * sysdep.c (reset_io): Now static.
b8950c94 1798 (wait_for_termination_signal): Remove; unused.
604efe86 1799
38fc62d9
PE
1800 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1801 (copy_keymap_item, append_key, push_text_char_description):
1802 Now static.
1004a21a 1803 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1804 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1805 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1806 (describe_map_tree):
1807 Rename locals to avoid shadowing.
38fc62d9 1808
2f2650da
PE
1809 * keyboard.c: Declare functions static if they are not used elsewhere.
1810 (echo_char, echo_dash, cmd_error, top_level_2):
1811 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1812 (read_char, kbd_buffer_get_event, make_lispy_position):
1813 (make_lispy_event, make_lispy_movement, apply_modifiers):
1814 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1815 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1816 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1817 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1818 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1819
a053e86c 1820 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1821 (mark_kboards): Move decl here ...
1822 * alloc.c (mark_kboards): ... from here.
a053e86c 1823
4752793e
PE
1824 * lisp.h (force_auto_save_soon): New decl.
1825
74f10ca7 1826 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1827 (DEFINE_DUMMY_FUNCTION): New macro.
1828 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1829 Use it.
c03cd23f
PE
1830 (main): Add casts to avoid warnings
1831 if GCC considers string literals to be constants.
74f10ca7 1832
022e70d4
PE
1833 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1834
59d6fe83
PE
1835 * dbusbind.c: Pointer signedness fixes.
1836 (xd_signature, xd_append_arg, xd_initialize):
1837 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1838 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1839 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1840 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1841
78320123
PE
1842 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1843 if GCC considers string literals to be constants.
49cebcca 1844 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1845
35ac2a97
SM
18462011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1847
fb103ca9
SM
1848 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1849 (print_preprocess, print_object): New macro to fix last change.
1850
35ac2a97
SM
1851 * print.c (print_preprocess): Don't forget font objects.
1852
62973b41
JB
18532011-03-16 Juanma Barranquero <lekktu@gmail.com>
1854
1855 * emacs.c (USAGE3): Doc fixes.
1856
0e48bb22
AS
18572011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1858
1859 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1860 structure.
1861
7684e57b
JB
18622011-03-14 Juanma Barranquero <lekktu@gmail.com>
1863
1864 * lisp.h (VWindow_system, Qfile_name_history):
1865 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1866 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1867 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1868
1869 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1870 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1871
1872 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1873 * w32console.c (detect_input_pending, read_input_pending)
1874 (encode_terminal_code):
1875 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1876 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1877 (w32_system_caret_y, Qfile_name_history):
1878 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1879 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1880 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1881 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1882 * w32proc.c (Qlocal, report_file_error):
1883 * w32term.c (Vwindow_system, updating_frame):
1884 * w32uniscribe.c (initialized, uniscribe_font_driver):
1885 Remove unneeded extern declarations.
1886
2aa46d6c
CY
18872011-03-14 Chong Yidong <cyd@stupidchicken.com>
1888
c96bbc66 1889 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1890
cffc6f3b
CY
18912011-03-13 Chong Yidong <cyd@stupidchicken.com>
1892
1893 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1894 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1895 These macros can no longer be used for assignment.
1896
44f230aa
SM
1897 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1898 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1899 (record_buffer_markers, fetch_buffer_markers): New functions for
1900 recording and fetching special buffer markers.
1901 (set_buffer_internal_1, set_buffer_temp): Use them.
1902
1903 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1904
1905 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1906
1907 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1908 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1909
1910 * xdisp.c (hscroll_window_tree):
1911 (reconsider_clip_changes): Use PT instead of BUF_PT.
1912
d251f04b
EZ
19132011-03-13 Eli Zaretskii <eliz@gnu.org>
1914
1915 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1916 $(EMACS_ROOT)/lib/intprops.h.
1917
f0c77cd1
PE
19182011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1919
3eca4629
PE
1920 Fix more problems found by GCC 4.5.2's static checks.
1921
7c86ee98
PE
1922 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1923 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1924 (xg_free_frame_widgets): Make it clear that a local variable is
1925 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1926 (gdk_window_get_screen): Make it clear that this macro is needed
1927 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1928 (int_gtk_range_get_value): New function, which avoids a diagnostic
1929 from gcc -Wbad-function-cast.
1930 (xg_set_toolkit_scroll_bar_thumb): Use it.
1931 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1932 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1933 (get_utf8_string, xg_get_file_with_chooser):
1934 Rename locals to avoid shadowing.
1935 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1936
41729b81
PE
1937 * xgselect.c (xg_select): Remove unused var.
1938
f0c77cd1
PE
1939 * image.c (four_corners_best): Mark locals as initialized.
1940 (gif_load): Initialize transparent_p to zero (Bug#8238).
1941 Mark another local as initialized.
ec6cf4c6 1942 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1943
ce0ad53d 1944 * image.c (clear_image_cache): Now static.
d5d5a617 1945 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1946 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1947 (x_edge_detection): Remove unnecessary cast that
1948 gcc -Wbad-function-cast diagnoses.
2037898d 1949 (gif_load): Fix pointer signedness.
6ae141d6
PE
1950 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1951 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1952
33383987 19532011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1954
d32df629
PE
1955 Improve quality of tests for time stamp overflow.
1956 For example, without this patch (encode-time 0 0 0 1 1
1957 1152921504606846976) returns the obviously-bogus value (-948597
1958 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1959 reports time overflow. See
1960 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1961 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1962 * editfns.c: Include limits.h and intprops.h.
1963 (TIME_T_MIN, TIME_T_MAX): New macros.
1964 (time_overflow): Move earlier, to before first use.
1965 (hi_time, lo_time): New functions, for an accurate test for
1966 out-of-range times.
1967 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1968 (Fget_internal_run_time): Don't assume time_t fits in int.
1969 (make_time): Use list2 instead of Fcons twice.
1970 (Fdecode_time): More accurate test for out-of-range times.
1971 (check_tm_member): New function.
1972 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1973 (lisp_time_argument): Don't rely on undefined left-shift and
1974 right-shift behavior when checking for time stamp overflow.
8be6f318 1975
fe31d94c
PE
1976 * editfns.c (time_overflow): New function, refactoring common code.
1977 (Fformat_time_string, Fdecode_time, Fencode_time):
1978 (Fcurrent_time_string): Use it.
1979
8be6f318
PE
1980 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1981 * dired.c (make_time): Move to ...
1982 * editfns.c (make_time): ... here.
1983 * systime.h: Note the move.
1984
09d9db2c 19852011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1986
126bc0dc
YM
1987 * fringe.c (update_window_fringes): Remove unused variables.
1988
c47cbdfd
YM
1989 * unexmacosx.c (copy_data_segment): Also copy __got section.
1990 (Bug#8223)
1991
7ac80be9
EZ
19922011-03-12 Eli Zaretskii <eliz@gnu.org>
1993
c96bbc66 1994 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1995 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1996 Constify `char *' arguments and their references according to
1997 prototypes in tparam.h.
1998
ecb0f94d 1999 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 2000
7ac80be9
EZ
2001 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
2002 Adapt all references accordingly.
2003
2004 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
2005
ef1fd07e
TT
20062011-03-11 Tom Tromey <tromey@redhat.com>
2007
2008 * buffer.c (syms_of_buffer): Remove obsolete comment.
2009
7ef4b50c
EZ
20102011-03-11 Eli Zaretskii <eliz@gnu.org>
2011
2012 * termhooks.h (encode_terminal_code): Declare prototype.
2013
2014 * msdos.c (encode_terminal_code): Don't declare prototype.
2015
2016 * term.c (encode_terminal_code): Now external again, used by
2017 w32console.c and msdos.c.
2018
44f230aa
SM
2019 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
2020 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 2021
4b1ec863 20222011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 2023
1714f52b 2024 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 2025
4b1ec863
PE
2026 * fringe.c (update_window_fringes): Mark locals as initialized
2027 (Bug#8227).
2028 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 2029
524c7aa6
PE
2030 * alloc.c (mark_fringe_data): Move decl from here ...
2031 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
2032 to check its interface.
2033 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
2034
a5c0af81 2035 * fontset.c (free_realized_fontset): Now static.
7519b8cd 2036 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 2037 (fontset_font): Mark local as initialized.
a9a06e0b 2038 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 2039
b4716021
PE
2040 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
2041
811e9bac 2042 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 2043 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
2044 (x_own_selection, Fx_disown_selection_internal): Rename locals
2045 to avoid shadowing.
2046 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 2047
7e3ab302
PE
2048 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
2049 so that the caller can use some name other than gcpro1.
2050 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
2051 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2052 (Fx_backspace_delete_keys_p):
2053 Use them to avoid shadowing, and rename vars to avoid shadowing.
2054 (x_decode_color, x_set_name, x_window): Now static.
6b437900 2055 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 2056 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
2057 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
2058 Remove unused locals.
7e3ab302
PE
2059 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
2060 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
2061 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
2062 macros.
f78faa98 2063
e2b13473
PE
2064 * xterm.h (x_mouse_leave): New decl.
2065
77f23912
PE
2066 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
2067 Remove unused functions.
cdf4ba58
PE
2068 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
2069 (x_calc_absolute_position): Now static.
7411c686 2070 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 2071 Don't declare local "event" unless it's used.
ed7bf3a5
PE
2072 (x_iconify_frame, x_free_frame_resources): Don't declare locals
2073 unless they are used.
38d0b34a
PE
2074 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
2075 (x_fatal_error_signal): Remove; not used.
a6067996
PE
2076 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
2077 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
2078 (x_error_catcher, x_connection_closed, x_error_handler):
2079 (x_error_quitter, xembed_send_message, x_iconify_frame):
2080 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 2081 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 2082 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 2083
44f230aa
SM
2084 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
2085 Rename or move locals to avoid shadowing.
6b463e58 2086 (tty_defined_color, merge_face_heights): Now static.
5967d051 2087 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
2088 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
2089 does not deduce is never used uninitialized.
73719eba
PE
2090 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
2091 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 2092
426994c3 2093 * terminal.c (store_terminal_param): Now static.
5489860b 2094
032f1620 2095 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 2096 (set_frame_menubar): Remove unused local.
d4323972 2097 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
2098 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
2099 since they might point to immutable storage.
281585b0
PE
2100 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
2101 since it's unused otherwise.
032f1620 2102
367c19e5 2103 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 2104 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
2105 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
2106 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 2107 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
2108 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
2109 does not deduce are never used uninitialized.
70739cbe 2110
07b48fa9
PE
2111 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
2112
8868a238 2113 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
2114 * window.c (window_loop, size_window):
2115 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 2116
7e5cf297 2117 * window.c (display_buffer): Now static.
d6550a9f
PE
2118 (size_window): Mark variables that gcc -Wuninitialized
2119 does not deduce are never used uninitialized.
a586633d
PE
2120 * window.h (check_all_windows): New decl, to forestall
2121 gcc -Wmissing-prototypes diagnostic.
5b555da1 2122 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 2123
f6095868
PE
2124 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
2125 shadowing.
2126 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
2127 Include <limits.h>.
2128 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
2129 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
2130 (load_charset_map): Mark variables that gcc -Wuninitialized
2131 does not deduce are never used uninitialized.
53df7c11 2132 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 2133
f38b440c
PE
2134 * coding.c (coding_set_source, coding_set_destination):
2135 Use "else { /* comment */ }" rather than "else /* comment */;"
2136 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
2137 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
2138 a block, when the outer 'i' will do.
2139 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
2140 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
2141 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
2142 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
2143 (Fdecode_sjis_char, Fdefine_coding_system_internal):
2144 Rename locals to avoid shadowing.
2145 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
2146 * coding.c (emacs_mule_char, encode_invocation_designation):
2147 Now static, since they're not used elsewhere.
413bb2db 2148 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 2149 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
2150 (decode_coding_emacs_mule): Mark variables that gcc
2151 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
2152 (detect_coding_iso_2022): Initialize a local variable that might
2153 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 2154 this initialization is needed. (Bug#8211)
5f58e762
PE
2155 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
2156 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
2157 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
2158 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
2159 Remove unused macros.
f38b440c 2160
232b38b9 2161 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 2162 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 2163 * character.c (string_count_byte8): Likewise.
232b38b9 2164
fb90da1b
PE
2165 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
2166 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
2167
fb93dbc2
PE
2168 * chartab.c (copy_sub_char_table): Now static, since it's not used
2169 elsewhere.
5c156ace
PE
2170 (sub_char_table_ref_and_range, char_table_ref_and_range):
2171 Rename locals to avoid shadowing.
bbcd0949 2172 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2173
7d3b3862 2174 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2175 (BIDI_BOB): Remove unused macro.
7d3b3862 2176
6be7d3da
PE
2177 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2178 deduce are never used uninitialized.
c2ed9c8b 2179 * term.c (encode_terminal_code): Likewise.
6be7d3da 2180
75f8807f 2181 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2182
50938595
PE
2183 * tparam.h: New file.
2184 * term.c, tparam.h: Include it.
2185 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2186 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2187 Move these decls to tparam.h, and make them agree with what
2188 is actually in tparam.c. The previous trick of using incompatible
2189 decls in different modules does not conform to the C standard.
2190 All callers of tparam changed to use tparam's actual API.
2191 * tparam.c (tparam1, tparam, tgoto):
2192 Use const pointers where appropriate.
2193
fbceeba2
PE
2194 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2195 * cm.h (struct cm): Likewise.
2196 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2197 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2198 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2199 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2200 (turn_on_face, init_tty): Likewise.
2201 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2202
7f3f1250
PE
2203 * term.c (term_mouse_position): Rename local to avoid shadowing.
2204
e6ca6543
PE
2205 * alloc.c (mark_ttys): Move decl from here ...
2206 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2207
c40f8d15
AS
22082011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2209
2210 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2211
cfe0661d
JB
22122011-03-09 Juanma Barranquero <lekktu@gmail.com>
2213
2214 * search.c (compile_pattern_1): Remove argument regp, unused since
2215 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2216 (compile_pattern): Don't pass it.
2217
0afb4571
J
22182011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2219
2220 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2221 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2222 for ! HAVE_GTK3.
2223 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2224
2225 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2226
2227 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2228 gdk_window_get_screen, gdk_window_get_geometry,
2229 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2230 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2231 (xg_get_pixbuf_from_pixmap): New function.
2232 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2233 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2234 Call xg_get_pixbuf_from_pixmap instead of
2235 gdk_pixbuf_get_from_drawable.
2236 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2237 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2238 (xg_check_special_colors): Use GtkStyleContext and its functions
2239 for HAVE_GTK3.
2240 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2241 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2242 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2243 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2244 Call gtk_widget_get_preferred_size.
0afb4571
J
2245 (xg_frame_resized): gdk_window_get_geometry only takes 5
2246 parameters.
44f230aa
SM
2247 (xg_win_to_widget, xg_event_is_for_menubar):
2248 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2249 (xg_set_widget_bg): New function.
2250 (delete_cb): New function.
2251 (xg_create_frame_widgets): connect delete-event to delete_cb.
2252 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2253 (xg_set_background_color): Call xg_set_widget_bg.
2254 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2255 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2256 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2257 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2258 if ! HAVE_GTK3.
2259 (update_frame_tool_bar): Call gtk_widget_hide.
2260 (xg_initialize): Use GDK_KEY_g.
2261
2262 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2263 if ! HAVE_GTK3
2264 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2265
2266 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2267 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2268 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2269
1c2cc4ef
JB
22702011-03-08 Juanma Barranquero <lekktu@gmail.com>
2271
2272 * w32xfns.c (select_palette): Check success of RealizePalette against
2273 GDI_ERROR, not zero.
2274
33383987 2275See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2276
2277;; Local Variables:
2278;; coding: utf-8
aac0c6e3
MR
2279;; End:
2280
33383987 2281 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2282
2283 This file is part of GNU Emacs.
2284
2285 GNU Emacs is free software: you can redistribute it and/or modify
2286 it under the terms of the GNU General Public License as published by
2287 the Free Software Foundation, either version 3 of the License, or
2288 (at your option) any later version.
2289
2290 GNU Emacs is distributed in the hope that it will be useful,
2291 but WITHOUT ANY WARRANTY; without even the implied warranty of
2292 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2293 GNU General Public License for more details.
2294
2295 You should have received a copy of the GNU General Public License
2296 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.