* doprnt.c: Prefer signed to unsigned when either works.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0e926e56
PE
12011-07-07 Paul Eggert <eggert@cs.ucla.edu>
2
c2d1e36d
PE
3 * doprnt.c: Prefer signed to unsigned when either works.
4 * eval.c (verror):
5 * doprnt.c (doprnt):
6 * lisp.h (doprnt):
7 * xdisp.c (vmessage):
8 Use ptrdiff_t, not size_t, when using or implementing doprnt,
9 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
10 prefer signed arithmetic to avoid comparison confusion.
11 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
12 but is a bit tricky.
13
0e926e56
PE
14 Assume freestanding C89 headers, string.h, stdlib.h.
15 * data.c, doprnt.c, floatfns.c, print.c:
16 Include float.h unconditionally.
17 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
18 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
19 * regex.c: Likewise for stddef.h, string.h.
20 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
21 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
22 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
23 (STDC_HEADERS): Remove obsolete defines.
24 * sysdep.c: Include limits.h unconditionally.
25
59361254 262011-07-06 Paul Eggert <eggert@cs.ucla.edu>
d8ed26bd 27
9cfdb3ec
PE
28 Assume support for memcmp, memcpy, memmove, memset.
29 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
30 * regex.c (memcmp, memcpy):
31 Remove; we assume C89 now.
32
33 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
34 (__malloc_safe_bcopy): Remove; no longer needed.
35
6089c567
PE
36 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
37 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
38 well either way, and we prefer signed to unsigned.
39
22b4128e
PE
402011-07-06 Paul Eggert <eggert@cs.ucla.edu>
41
42 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
43 * alloc.c (mark_buffer):
44 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
45 (clone_per_buffer_values): Don't assume that
22b4128e
PE
46 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
47 This isn't true in general, and it's particularly not true
48 if Emacs is configured with --with-wide-int.
49 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
50 New macros, used in the buffer.c change.
51
869795d6
JD
522011-07-05 Jan Djärv <jan.h.d@swipnet.se>
53
54 * xsettings.c: Use both GConf and GSettings if both are available.
55 (store_config_changed_event): Add comment.
56 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
57 (store_tool_bar_style_changed): New functions.
58 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
59 (struct xsettings): Move font inside HAVE_XFT.
60 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
61 (GSETTINGS_MONO_FONT): Renamed from SYSTEM_MONO_FONT.
62 Move inside HAVE_XFT.
63 (something_changed_gsettingsCB): Renamed from something_changedCB.
64 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
65 also.
66 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
67 (GCONF_MONO_FONT): Renamed from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
68 (something_changed_gconfCB): Renamed from something_changedCB.
69 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
70 (parse_settings): Move check for font inside HAVE_XFT.
71 (read_settings, apply_xft_settings): Add comment.
72 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
73 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
74 call store_font_name_changed.
75 (xft_settings_event): Add comment.
76 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
77 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
78 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
79 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
80 (xsettings_initialize): Call init_gsettings last.
81 (xsettings_get_system_font, xsettings_get_system_normal_font): Add
82 comment.
83
d8ed26bd
PE
842011-07-05 Paul Eggert <eggert@cs.ucla.edu>
85
86 Random fixes. E.g., (random) never returned negative values.
87 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
88 subseconds part to the entropy, as that's a bit more random.
89 Prefer signed to unsigned, since the signedness doesn't matter and
90 in general we prefer signed. When given a limit, use a
91 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
92 latter isn't right if USE_2_TAGS_FOR_INTS.
93 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
94 not 0..VALMASK. Don't discard "excess" bits that random () returns.
95
cabf1cac
SM
962011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
97
98 * textprop.c (text_property_stickiness):
99 Obey Vtext_property_default_nonsticky.
100 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
101 * w32fns.c (syms_of_w32fns):
102 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
103
6e9b2be9
PE
1042011-07-04 Paul Eggert <eggert@cs.ucla.edu>
105
106 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
107 This is more efficient than Ffile_directory_p and avoids a minor race.
108
90186c68
LMI
1092011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
110
7c301272
LMI
111 * buffer.c (Foverlay_put): Say what the return value is
112 (bug#7835).
113
c4f2d8d4
LMI
114 * fileio.c (barf_or_query_if_file_exists): Check first if the file
115 is a directory before asking whether to use the file name
116 (bug#7564).
ad637907
LMI
117 (barf_or_query_if_file_exists): Make the "File is a directory"
118 error be more correct.
c4f2d8d4 119
90186c68
LMI
120 * fns.c (Frequire): Remove the mention of the .gz files, since
121 that's installation-specific, but keep the mention of
122 `get-load-suffixes'.
123
da64016e
PE
1242011-07-04 Paul Eggert <eggert@cs.ucla.edu>
125
126 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
127 Report string overflow if the output is too long.
128
7d47b580
JB
1292011-07-04 Juanma Barranquero <lekktu@gmail.com>
130
a555cb87
JB
131 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
132 (syms_of_gnutls): Remove duplicate DEFSYM for
133 Qgnutls_bootprop_verify_hostname_error, an error for
134 Qgnutls_bootprop_verify_error (which is no longer used).
135
7d47b580
JB
136 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
137 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
138 Also (re)move comments that are misplaced or no longer relevant.
139
1e49bfab
LMI
1402011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
141
142 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
143
1485f4c0
CY
1442011-07-03 Chong Yidong <cyd@stupidchicken.com>
145
146 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
147 and background color parameters if they have been changed.
148
a9ab721e
LMI
1492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
150
151 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
152
cf7cff57
PE
1532011-07-03 Paul Eggert <eggert@cs.ucla.edu>
154
2e13213d
PE
155 * xsettings.c (SYSTEM_FONT): Define only when used.
156 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
157
cf7cff57
PE
158 * keymap.c (access_keymap_1): Now static.
159
7a8e04f7
CY
1602011-07-02 Chong Yidong <cyd@stupidchicken.com>
161
162 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
163 leave any prefix arg for the up event (Bug#1586).
164
61352f62
LMI
1652011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
166
69bb1ef7
LMI
167 * lread.c (syms_of_lread): Mention single symbols defined by
168 `defvar' or `defconst' (bug#7154).
169
61352f62 170 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 171 (Frequire): Mention get-load-suffixes.
61352f62 172
28545e04
MR
1732011-07-02 Martin Rudalics <rudalics@gmx.at>
174
175 * window.h (window): Remove clone_number slot.
176 * window.c (Fwindow_clone_number, Fset_window_clone_number):
177 Remove.
178 (make_parent_window, make_window, saved_window)
179 (Fset_window_configuration, save_window_save): Don't deal with
180 clone numbers.
181 * buffer.c (Qclone_number): Remove declaration.
182 (sort_overlays, overlay_strings): Don't deal with clone numbers.
183
3349e122
SM
1842011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
185
186 Add multiple inheritance to keymaps.
187 * keymap.c (Fmake_composed_keymap): New function.
188 (Fset_keymap_parent): Simplify.
189 (fix_submap_inheritance): Remove.
190 (access_keymap_1): New function extracted from access_keymap to handle
191 embedded parents and handle lists of maps.
192 (access_keymap): Use it.
193 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
194 (Fcopy_keymap): Handle embedded parents.
195 (Fcommand_remapping, define_as_prefix): Simplify.
196 (Fkey_binding): Simplify.
197 (syms_of_keymap): Move minibuffer-local-completion-map,
198 minibuffer-local-filename-completion-map,
199 minibuffer-local-must-match-map, and
200 minibuffer-local-filename-must-match-map to Elisp.
201 (syms_of_keymap): Defsubr make-composed-keymap.
202 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
203 (parse_menu_item): Trivial simplification.
204
3279eb87
GM
2052011-07-01 Glenn Morris <rgm@gnu.org>
206
207 * Makefile.in (SETTINGS_LIBS): Fix typo.
208
4550efdf
KI
2092011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
210
211 * coding.c (Fencode_coding_string): Record the last coding system
212 used, as the function doc string says (bug#8738).
213
0949d2b6
JD
2142011-07-01 Jan Djärv <jan.h.d@swipnet.se>
215
216 * xsettings.c (store_monospaced_changed): Take new font as arg and
217 check for change against current_mono_font.
218 (EMACS_TYPE_SETTINGS): Remove this and related defines.
219 (emacs_settings_constructor, emacs_settings_get_property)
220 (emacs_settings_set_property, emacs_settings_class_init)
221 (emacs_settings_init, gsettings_obj): Remove.
222 (something_changedCB): New function for HAVE_GSETTINGS.
223 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
224 with value as argument.
225 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
226 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 227 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
228 "changed".
229
230 * xgselect.c: Add defined (HAVE_GSETTINGS).
231 (xgselect_initialize): Ditto.
232
233 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
234 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
235 xg_select.
236
bbc6b304
PE
2372011-07-01 Paul Eggert <eggert@cs.ucla.edu>
238
239 * eval.c (struct backtrace): Simplify and port the data structure.
240 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
241 signed bit field, as this assumption is not portable and it makes
242 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
243 "char debug_on_exit : 1" as this is not portable either; instead,
244 use the portable "unsigned int debug_on_exit : 1". Remove unused
245 member evalargs. Remove obsolete comments about cc bombing out.
246
9851bfc5
JD
2472011-06-30 Jan Djärv <jan.h.d@swipnet.se>
248
51bb811f 249 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
250 Let HAVE_GSETTINGS override HAVE_GCONF.
251 (store_monospaced_changed): New function.
252 (EMACS_SETTINGS): A new type derived from GObject to handle
253 GSettings notifications.
254 (emacs_settings_constructor, emacs_settings_get_property)
255 (emacs_settings_set_property, emacs_settings_class_init):
256 New functions.
257 (gsettings_client, gsettings_obj): New variables.
258 (GSETTINGS_SCHEMA): New define.
259 (something_changedCB): Call store_monospaced_changed.
260 (init_gsettings): New function.
261 (xsettings_initialize): Call init_gsettings.
262 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
263 to NULL.
264
265 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Renamed from
266 GCONF_CFLAGS/LIBS.
267
5386012d
MR
2682011-06-29 Martin Rudalics <rudalics@gmx.at>
269
270 * window.c (resize_root_window, grow_mini_window)
271 (shrink_mini_window): Rename Qresize_root_window to
272 Qwindow_resize_root_window and Qresize_root_window_vertically to
273 Qwindow_resize_root_window_vertically.
274
f13e0b08
PE
2752011-06-28 Paul Eggert <eggert@cs.ucla.edu>
276
277 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
278
94515237
JB
2792011-06-27 Juanma Barranquero <lekktu@gmail.com>
280
281 * makefile.w32-in: Redesign dependencies so they reflect more
282 clearly which files are directly included by each source file,
283 and not through other includes.
284
e43b6e43
MR
2852011-06-27 Martin Rudalics <rudalics@gmx.at>
286
287 * buffer.c (Qclone_number): Declare static and DEFSYM it.
288 (sort_overlays, overlay_strings): When an overlay's clone number
289 matches the window's clone number process the overlay even if
290 the overlay's window property doesn't match the current window.
291
d68443dc
MR
292 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
293 (Fwindow_hchild): Rename to Fwindow_left_child.
294 (Fwindow_next): Rename to Fwindow_next_sibling.
295 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
296 (resize_window_check): Rename to window_resize_check.
297 (resize_window_apply): Rename to window_resize_apply.
298 (Fresize_window_apply): Rename to Fwindow_resize_apply.
299 (Fdelete_other_windows_internal, resize_frame_windows)
300 (Fsplit_window_internal, Fdelete_window_internal)
301 (grow_mini_window, shrink_mini_window)
302 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 303
c7e73be5
JD
3042011-06-26 Jan Djärv <jan.h.d@swipnet.se>
305
306 * emacsgtkfixed.h: State that this is only used with Gtk+3.
307 (emacs_fixed_set_min_size): Remove.
308 (emacs_fixed_new): Take frame as argument.
309
310 * emacsgtkfixed.c: State that this is only used with Gtk+3.
311 (_EmacsFixedPrivate): Remove minwidth/height.
312 Add struct frame *f.
313 (emacs_fixed_init): Initialize priv->f.
314 (get_parent_class, emacs_fixed_set_min_size): Remove.
315 (emacs_fixed_new): Set priv->f to argument.
316 (emacs_fixed_get_preferred_width)
317 (emacs_fixed_get_preferred_height): Use min_width/height from
318 frames size_hint to set minimum and natural (Bug#8919).
319 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
320 and use min_width/height from frames size_hint to set
321 min_width/height (Bug#8919).
322
323 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
324 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
325 Fix indentation.
c7e73be5 326
cf99dcf8
EZ
3272011-06-26 Eli Zaretskii <eliz@gnu.org>
328
329 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
330 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
331 called at ZV.
332
029529ac
CY
3332011-06-26 Chong Yidong <cyd@stupidchicken.com>
334
335 * process.c (wait_reading_process_output): Bypass select if
336 waiting for a cell while ignoring keyboard input, and input is
337 pending. Suggested by Jan Djärv (Bug#8869).
338
7a7ef429
PE
3392011-06-25 Paul Eggert <eggert@cs.ucla.edu>
340
341 Use gnulib's dup2 module instead of rolling our own.
342 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
343
11fdef7d 3442011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
345
346 * dispnew.c (scrolling_window): Before scrolling, turn off a
347 mouse-highlight in the window being scrolled.
348
cd3520a4
JB
3492011-06-24 Juanma Barranquero <lekktu@gmail.com>
350
351 Move DEFSYM to lisp.h and use everywhere.
352
353 * character.h (DEFSYM): Move declaration...
354 * lisp.h (DEFSYM): ...here.
355
356 * gnutls.c:
357 * minibuf.c:
358 * w32menu.c:
359 * w32proc.c:
360 * w32select.c: Don't include character.h.
361
362 * alloc.c (syms_of_alloc):
363 * buffer.c (syms_of_buffer):
364 * bytecode.c (syms_of_bytecode):
365 * callint.c (syms_of_callint):
366 * casefiddle.c (syms_of_casefiddle):
367 * casetab.c (init_casetab_once):
368 * category.c (init_category_once, syms_of_category):
369 * ccl.c (syms_of_ccl):
370 * cmds.c (syms_of_cmds):
371 * composite.c (syms_of_composite):
372 * dbusbind.c (syms_of_dbusbind):
373 * dired.c (syms_of_dired):
374 * dispnew.c (syms_of_display):
375 * doc.c (syms_of_doc):
376 * editfns.c (syms_of_editfns):
377 * emacs.c (syms_of_emacs):
378 * eval.c (syms_of_eval):
379 * fileio.c (syms_of_fileio):
380 * fns.c (syms_of_fns):
381 * frame.c (syms_of_frame):
382 * fringe.c (syms_of_fringe):
383 * insdel.c (syms_of_insdel):
384 * keymap.c (syms_of_keymap):
385 * lread.c (init_obarray, syms_of_lread):
386 * macros.c (syms_of_macros):
387 * msdos.c (syms_of_msdos):
388 * print.c (syms_of_print):
389 * process.c (syms_of_process):
390 * search.c (syms_of_search):
391 * sound.c (syms_of_sound):
392 * syntax.c (init_syntax_once, syms_of_syntax):
393 * terminal.c (syms_of_terminal):
394 * textprop.c (syms_of_textprop):
395 * undo.c (syms_of_undo):
396 * w32.c (globals_of_w32):
397 * window.c (syms_of_window):
398 * xdisp.c (syms_of_xdisp):
399 * xfaces.c (syms_of_xfaces):
400 * xfns.c (syms_of_xfns):
401 * xmenu.c (syms_of_xmenu):
402 * xsettings.c (syms_of_xsettings):
403 * xterm.c (syms_of_xterm): Use DEFSYM.
404
4228cf16
TZ
4052011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
406
cd3520a4 407 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 408
7fcccf1e
PE
4092011-06-23 Paul Eggert <eggert@cs.ucla.edu>
410
7efb4e0e
PE
411 Integer and buffer overflow fixes (Bug#8873).
412
ff5844ad
PE
413 * print.c (printchar, strout): Check for string overflow.
414 (PRINTPREPARE, printchar, strout):
415 Don't set size unless allocation succeeds.
416
90532f02
PE
417 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
418 for sizes. Check for string overflow more accurately.
419 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
420
6d84508d
PE
421 * macros.c: Integer and buffer overflow fixes.
422 * keyboard.h (struct keyboard.kbd_macro_bufsize):
423 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
424 Use ptrdiff_t, not int, for sizes.
425 Don't increment bufsize until after realloc succeeds.
426 Check for size-calculation overflow.
427 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
428
437b2cb4
PE
429 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
430
8b9ac8b4
PE
431 * lread.c: Integer overflow fixes.
432 (read_integer): Radix is now EMACS_INT, not int,
433 to improve quality of diagnostics for out-of-range radices.
434 Calculate buffer size correctly for out-of-range radices.
435 (read1): Check for integer overflow in radices, and in
436 read-circle numbers.
82cb60d3
PE
437 (read_escape): Avoid int overflow.
438 (Fload, openp, read_buffer_size, read1)
439 (substitute_object_recurse, read_vector, read_list, map_obarray):
440 Use ptrdiff_t, not int, for sizes.
441 (read1): Use EMACS_INT, not int, for sizes.
20270765 442 Check for size overflow.
8b9ac8b4 443
7fcccf1e
PE
444 * image.c (cache_image): Check for size arithmetic overflow.
445
bfbbd7e7
PE
446 * lread.c: Integer overflow issues.
447 (saved_doc_string_size, saved_doc_string_length)
448 (prev_saved_doc_string_size, prev_saved_doc_string_length):
449 Now ptrdiff_t, not int.
450 (read1): Don't assume doc string length fits in int. Check for
451 out-of-range doc string lengths.
452 (read_list): Don't assume file position fits in int.
39019e54 453 (read_escape): Check for hex character overflow.
bfbbd7e7 454
4e323265
LL
4552011-06-22 Leo Liu <sdl.web@gmail.com>
456
457 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
458 Move to minibuffer.el.
459
85fece3e
PE
4602011-06-22 Paul Eggert <eggert@cs.ucla.edu>
461
20b84ce9 462 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
463 The following patches are for when GLYPH_DEBUG && !XASSERT.
464 * dispextern.h (trace_redisplay_p, dump_glyph_string):
465 * dispnew.c (flush_stdout):
466 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
467 Mark as externally visible.
468 * dispnew.c (check_window_matrix_pointers): Now static.
469 * dispnew.c (window_to_frame_vpos):
470 * xfns.c (unwind_create_frame):
471 * xterm.c (x_check_font): Remove unused local.
472 * scroll.c (CHECK_BOUNDS):
473 * xfaces.c (cache_fache): Rename local to avoid shadowing.
474 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
475 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
476 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
477 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
478 Now static.
479 (debug_method_add): Use va_list and vsprintf rather than relying
480 on undefined behavior with wrong number of arguments.
481 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
482 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
483 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
484 since we're not interested in debugging glyphs with old libraries.
485 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
486 GCC 4.6.0's static checking.
487
0766b489
PE
4882011-06-22 Paul Eggert <eggert@cs.ucla.edu>
489
31fd4b32
PE
490 Integer overflow and signedness fixes (Bug#8873).
491 A few related buffer overrun fixes, too.
492
b79e8648
PE
493 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
494
0766b489
PE
495 * dispextern.h (struct face.stipple):
496 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
497 (x_bitmap_mask, x_allocate_bitmap_record)
498 (x_create_bitmap_from_data, x_create_bitmap_from_file)
499 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
500 (x_create_bitmap_from_xpm_data):
501 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
502 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
503 (.bitmaps_last):
504 * xfaces.c (load_pixmap):
505 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
506 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
507 (.bitmaps_last, struct x_output.icon_bitmap):
508 Use ptrdiff_t, not int, for bitmap indexes.
509 (x_allocate_bitmap_record): Check for size overflow.
510 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
511
b081724f
PE
512 Use ptrdiff_t, not int, for overlay counts.
513 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
514 * editfns.c (overlays_around, get_pos_property):
515 * textprop.c (get_char_property_and_overlay):
516 * xdisp.c (next_overlay_change, note_mouse_highlight):
517 * xfaces.c (face_at_buffer_position):
21514da7
PE
518 * buffer.c (OVERLAY_COUNT_MAX): New macro.
519 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
520 (Fnext_overlay_change, Fprevious_overlay_change)
521 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 522 Use ptrdiff_t, not int, for sizes.
21514da7 523 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 524
3de73e5e
PE
525 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
526
2606c57b
PE
527 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
528 (x_session_initialize): Do not assume string length fits in int.
529
aaafe47a
PE
530 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
531 This is unlikely, but can occur if DPI is outlandish.
532
2674ddc8 533 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
534 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
535
28154962
PE
536 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
537 * xrdb.c (magic_file_p, search_magic_path):
538 Omit last arg SUFFIX; it was always 0. All callers changed.
539 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
540
7de51af5
PE
541 * xfont.c (xfont_match): Avoid need for strlen.
542
25ed6cc3
PE
543 * xfns.c: Don't assume strlen fits in int.
544 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
545
4eab31dd
PE
546 * xdisp.c (message_log_check_duplicate): Return intmax_t,
547 not unsigned long, as we prefer signed integers. All callers changed.
548 Detect integer overflow in repeat count.
549 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 550 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 551
171e2a58
PE
552 * termcap.c: Don't assume sizes fit in int and never overflow.
553 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
554 (gobble_line): Check for size-calculation overflow.
555
ad39faca 556 * minibuf.c (Fread_buffer):
6e5bb2dc 557 * lread.c (intern, intern_c_string):
74ca2eb3
PE
558 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
559 Don't assume string length fits in int.
560
52c61c22 561 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
562 * gtkutil.c (style_changed_cb): Avoid need for strlen.
563
b5b8c9e5
PE
564 * font.c: Don't assume string length fits in int.
565 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
566 Use ptrdiff_t, not int.
ccd6111c
PE
567 (font_intern_prop): Don't assume string length fits in int.
568 Don't assume integer property fits in fixnum.
569 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 570
882f0d81 571 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 572 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
573 Reformulate so as not to need the command string.
574 Invoke gzip -cd rather than gunzip, as it's more portable.
575 (lock_info_type, lock_file_1, lock_file):
576 Don't assume pid_t and time_t fit in unsigned long.
577 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
578 (current_lock_owner): Prefer signed type for sizes.
579 Use memcpy, not strncpy, where memcpy is what is really wanted.
580 Don't assume (via atoi) that time_t and pid_t fit in int.
581 Check for time_t and/or pid_t out of range, e.g., via a network share.
582 Don't alloca where an auto var works fine.
583
93f4cf88
PE
584 * fileio.c: Fix some integer overflow issues.
585 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
586 Don't assume string length fits in int.
587 (directory_file_name): Don't assume string length fits in long.
588 (make_temp_name): Don't assume pid fits in int, or that its print
589 length is less than 20.
590
f3e92b69
PE
591 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
592
1bfdaf10
PE
593 * coding.c (make_subsidiaries): Don't assume string length fits in int.
594
35016e9a
PE
595 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
596
3d1e65a1
PE
597 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
598 We prefer signed integers, even for size calculations.
599
0b963a93
PE
600 * emacs.c: Don't assume string length fits in 'int'.
601 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
602 (main): Don't invoke strlen when not needed.
603
573f4b54
PE
604 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
605 (XD_DEBUG_MESSAGE): Don't waste a byte.
606
989f33ba
PE
607 * callproc.c (getenv_internal_1, getenv_internal)
608 (Fgetenv_internal):
965d34eb
PE
609 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
610
e4d29b33
PE
611 * lread.c (invalid_syntax): Omit length argument.
612 All uses changed. This doesn't fix a bug, but it simplifies the
613 code away from its former Hollerith-constant appearance, and it's
614 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 615 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 616
eb49b136
PE
617 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
618 This didn't break anything, but it didn't help either.
619 It's confusing to put a bogus integer in a place where the actual
620 value does not matter.
9f62aeb1 621 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 622 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 623
15375a22
PE
624 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
625 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
626 implementation.
b61cc01c
PE
627 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
628 We prefer signed types, and the value cannot exceed the EMACS_INT
629 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
630 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
631 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
632 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 633
53b2623d
PE
634 * indent.c (sane_tab_width): New function.
635 (current_column, scan_for_column, Findent_to, position_indentation)
636 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 637 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 638
51cab52b 639 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 640
f2ed8a70
PE
641 * lisp.h (lint_assume): New macro.
642 * composite.c (composition_gstring_put_cache):
643 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
644
abe80cc6
PE
645 * editfns.c, insdel.c:
646 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 647
b02c740e
PE
648 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
649
ebc96716
PE
650 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
651
b4e50fa0 652 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 653 Use much-faster test for byte-length change.
311d5d7c 654 Don't assume string byte-length fits in 'int'.
a4cf38e4 655 Check that character arg fits in 'int'.
85461888 656 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 657
c0c1ee9f
PE
658 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
659
a498d7f4
PE
660 * fns.c (concat): Catch string overflow earlier.
661 Do not rely on integer wraparound.
662
51cab52b
PE
663 * dispextern.h (struct it.overlay_strings_charpos)
664 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
665 * xdisp.c (forward_to_next_line_start)
666 (back_to_previous_visible_line_start)
667 (reseat_at_next_visible_line_start, next_element_from_buffer):
668 Don't arbitrarily truncate the value of 'selective' to int.
669
76031fad
PE
670 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
671
5eb55db9
PE
672 * composite.c: Don't truncate sizes to 'int'.
673 (composition_gstring_p, composition_reseat_it)
674 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
675 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
676 not EMACS_UINT, for indexes.
5eb55db9 677
0703a717
PE
678 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
679
d6202519
PE
680 * buffer.c: Include <verify.h>.
681 (struct sortvec.priority, struct sortstr.priority):
8961a454 682 Now EMACS_INT, not int.
c20998a7 683 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
684 (struct sortstr.size, record_overlay_string)
685 (struct sortstrlist.size, struct sortlist.used):
686 Don't truncate size to int.
687 (record_overlay_string): Check for size-calculation overflow.
d6202519 688 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 689
d5a19415
JM
6902011-06-22 Jim Meyering <meyering@redhat.com>
691
029529ac 692 Don't leak an XBM-image-sized buffer
d5a19415
JM
693 * image.c (xbm_load): Free the image buffer after using it.
694
a9041e6c
PE
6952011-06-21 Paul Eggert <eggert@cs.ucla.edu>
696
697 Port to Sun C.
698 * composite.c (find_automatic_composition): Omit needless 'return 0;'
699 that Sun C diagnosed.
700 * fns.c (secure_hash): Fix pointer signedness issue.
701 * intervals.c (static_offset_intervals): New function.
702 (offset_intervals): Use it.
703
7f3f739f
LL
7042011-06-21 Leo Liu <sdl.web@gmail.com>
705
706 * deps.mk (fns.o):
707 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
708 sha512.h.
709
710 * fns.c (secure_hash): Rename from crypto_hash_function and change
711 the first arg to accept symbols.
5b66d427 712 (Fsecure_hash): New primitive.
7f3f739f
LL
713 (syms_of_fns): New symbols.
714
76147d94
DD
7152011-06-20 Deniz Dogan <deniz@dogan.se>
716
717 * process.c (Fset_process_buffer): Clarify return value in
718 docstring.
719
7d7d0045
CY
7202011-06-18 Chong Yidong <cyd@stupidchicken.com>
721
722 * dispnew.c (add_window_display_history): Use BVAR.
723
724 * xdisp.c (debug_method_add): Use BVAR.
725 (check_window_end, dump_glyph_matrix, dump_glyph)
726 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
727
728 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
729 Likewise.
730
731 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
732 check till after the cache is created in init_frame_faces.
733
ff2bc410
SM
7342011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
735
736 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
737
28177add
PE
7382011-06-16 Paul Eggert <eggert@cs.ucla.edu>
739
dd3482fe
PE
740 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
741 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
742 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
743
393d71f3 744 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
745 * fileio.c (Finsert_file_contents):
746 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
747 Remove the old (too-loose) buffer overflow checks.
748 They weren't needed, since make_gap checks for buffer overflow.
749 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
750 The old code merely checked for Emacs fixnum overflow, and relied
751 on undefined (wraparound) behavior. The new code avoids undefined
752 behavior, and also checks for ptrdiff_t and/or size_t overflow.
753
2e6813b0 754 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
755 Tune. Don't use wider integers than needed. Don't use alloca.
756 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 757
599a9e4f
PE
758 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
759
99561444
PE
760 * insdel.c, lisp.h (buffer_overflow): New function.
761 (insert_from_buffer_1, replace_range, replace_range_2):
762 * insdel.c (make_gap_larger):
763 * editfns.c (Finsert_char):
764 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
765
28177add
PE
766 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
767
e69dafad
PE
7682011-06-15 Paul Eggert <eggert@cs.ucla.edu>
769
a7af7fde 770 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 771
b1c46f02
PE
772 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
773 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
774
e69dafad
PE
775 * fileio.c: Don't assume EMACS_INT fits in off_t.
776 (emacs_lseek): New static function.
777 (Finsert_file_contents, Fwrite_region): Use it.
778 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
779
566684ea
PE
780 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
781
e6966cd6
PE
782 * fns.c: Don't overflow int when computing a list length.
783 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
784 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
785 truncation on 64-bit hosts. Check for QUIT every
786 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
787 faster and is responsive enough.
788 (Flength): Report an error instead of overflowing an integer.
789 (Fsafe_length): Return a float if the value is not representable
790 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 791 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 792 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 793
dd0b0efb
PE
794 * alloc.c: Check that resized vectors' lengths fit in fixnums.
795 (header_size, word_size): New constants.
796 (allocate_vectorlike): Don't check size overflow here.
797 (allocate_vector): Check it here instead, since this is the only
798 caller of allocate_vectorlike that could cause overflow.
799 Check that the new vector's length is representable as a fixnum.
800
86fe5cfe
PE
801 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
802 The previous code was bogus. For example, next_almost_prime (32)
803 returned 39, which is undesirable as it is a multiple of 3; and
804 next_almost_prime (24) returned 25, which is a multiple of 5 so
805 why was the code bothering to check for multiples of 7?
806
80e88859
PE
807 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
808
4a2f0ad6
PE
809 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
810
f66c7cf8
PE
811 Variadic C functions now count arguments with ptrdiff_t.
812 This partly undoes my 2011-03-30 change, which replaced int with size_t.
813 Back then I didn't know that the Emacs coding style prefers signed int.
814 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
815 were being counted with int, which may truncate counts on 64-bit
816 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
817 * lisp.h (struct Lisp_Subr.function.aMANY)
818 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
819 Arg counts are now ptrdiff_t, not size_t.
820 All variadic functions and their callers changed accordingly.
821 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
822 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
823 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
824 * callint.c (Fcall_interactively): Check arg count for overflow,
825 to avoid potential buffer overrun. Use signed char, not 'int',
826 for 'varies' array, so that we needn't bother to check its size
827 calculation for overflow.
828 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
829 * eval.c (apply_lambda):
830 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
831 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
832 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
833
a1759b76
PE
834 * callint.c (Fcall_interactively): Don't use index var as event count.
835
d96be9fc
PE
836 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
837 * mem-limits.h (SIZE): Remove; no longer used.
838
a690a978 839 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 840
578c21e6
PE
841 Remove unnecessary casts.
842 * xterm.c (x_term_init):
843 * xfns.c (x_set_border_pixel):
844 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
845 These aren't needed now that we assume ANSI C.
846
96f53c6c
PE
847 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
848 It's more likely to cause problems (due to unsigned overflow)
849 than to cure them.
850
83c77d31
PE
851 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
852
ee2079f1
PE
853 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
854
6da65536
PE
855 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
856
7147c4a4
PE
857 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
858
193e32d9
PE
859 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
860
e5533da6
PE
861 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
862
9910e595
PE
863 GLYPH_CODE_FACE returns EMACS_INT, not int.
864 * dispextern.h (merge_faces):
865 * xfaces.c (merge_faces):
01103c44
PE
866 * xdisp.c (get_next_display_element, next_element_from_display_vector):
867 Don't assume EMACS_INT fits in int.
9910e595 868
2638320e
PE
869 * character.h (CHAR_VALID_P): Remove unused parameter.
870 * fontset.c, lisp.h, xdisp.c: All uses changed.
871
045eb8d9
PE
872 * editfns.c (Ftranslate_region_internal): Omit redundant test.
873
c1f134b5
PE
874 * fns.c (concat): Minor tuning based on overflow analysis.
875 This doesn't fix any bugs. Use int to hold character, instead
876 of constantly refetching from Emacs object. Use XFASTINT, not
877 XINT, for value known to be a character. Don't bother comparing
878 a single byte to 0400, as it's always less.
879
395fcb93 880 * floatfns.c (Fexpt):
327eeec8
PE
881 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
882
abbd3d23
PE
883 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
884 for characters.
885
684a03ef
PE
886 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
887
0fed43f3
PE
888 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
889 Without this fix, on a 64-bit host (aset S 0 4294967386) would
890 incorrectly succeed when S was a string, because 4294967386 was
891 truncated before it was used.
892
8fd02eb7
PE
893 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
894 Otherwise, an out-of-range integer could cause undefined behavior
895 on a 64-bit host.
896
f8c86b69
PE
897 * composite.c: Use int, not EMACS_INT, for characters.
898 (fill_gstring_body, composition_compute_stop_pos): Use int, not
899 EMACS_INT, for values that are known to be in character range.
900 This doesn't fix any bugs but is the usual style inside Emacs and
901 may generate better code on 32-bit machines.
902
34206dd2
PE
903 Make sure a 64-bit char is never passed to ENCODE_CHAR.
904 This is for reasons similar to the recent CHAR_STRING fix.
905 * charset.c (Fencode_char): Check that character arg is actually
906 a character. Pass an int to ENCODE_CHAR.
907 * charset.h (ENCODE_CHAR): Verify that the character argument is no
908 wider than 'int', as a compile-time check to prevent future regressions
909 in this area.
910
c5958d4c 911 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
912
913 Make sure a 64-bit char is never passed to CHAR_STRING.
914 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
915 by silently ignoring the top 32 bits, allowing some values
916 that were far too large to be valid characters.
917 * character.h: Include <verify.h>.
918 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
919 arguments are no wider than unsigned, as a compile-time check
920 to prevent future regressions in this area.
921 * data.c (Faset):
01103c44 922 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
923 (Fsubst_char_in_region):
924 * fns.c (concat):
925 * xdisp.c (decode_mode_spec_coding):
926 Adjust to CHAR_STRING's new requirement.
927 * editfns.c (Finsert_char, Fsubst_char_in_region):
928 * fns.c (concat): Check that character args are actually
929 characters. Without this test, these functions did the wrong
930 thing with wildly out-of-range values on 64-bit hosts.
931
d37ca623
PE
932 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
933 These casts should not be needed on 32-bit hosts, either.
934 * keyboard.c (read_char):
935 * lread.c (Fload): Remove casts to unsigned.
936
ea204efb
PE
937 * lisp.h (UNSIGNED_CMP): New macro.
938 This fixes comparison bugs on 64-bit hosts.
939 (ASCII_CHAR_P): Use it.
940 * casefiddle.c (casify_object):
01103c44 941 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
942 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
943 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
944 * dispextern.h (FACE_FROM_ID):
945 * keyboard.c (read_char): Use UNSIGNED_CMP.
946
41cb286c
PE
947 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
948 not to EMACS_INT, to avoid GCC warning.
949
4a1b9832
PE
950 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
951
55daad71
PE
952 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
953 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
954 isn't needed on 32-bit machines.
8f95c75c 955
01103c44
PE
956 * buffer.c (Fgenerate_new_buffer_name):
957 Use EMACS_INT for count, not int.
0ceccced 958 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
959
960 * data.c (Qcompiled_function): Now static.
961
c6f072e7
PE
962 * window.c (window_body_lines): Now static.
963
20ce5912
PE
964 * image.c (gif_load): Rename local to avoid shadowing.
965
9c4c5f81
PE
966 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
967 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
968 * alloc.c (make_save_value): Integer argument is now of type
969 ptrdiff_t, not int.
970 (mark_object): Use ptrdiff_t, not int.
971 * lisp.h (pD): New macro.
972 * print.c (print_object): Use it.
973
c0c5c8ae
PE
974 * alloc.c: Use EMACS_INT, not int, to count objects.
975 (total_conses, total_markers, total_symbols, total_vector_size)
976 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
977 (total_free_floats, total_floats, total_free_intervals)
978 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
979 Now EMACS_INT, not int. All uses changed.
980 (Fgarbage_collect): Compute overall total using a double, so that
981 integer overflow is less likely to be a problem. Check for overflow
982 when converting back to an integer.
5a25e253
PE
983 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
984 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
985 These were 'int' variables that could overflow on 64-bit hosts;
986 they were never used, so remove them instead of repairing them.
211a0b2a 987 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
988 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
989 Previously, this ceilinged at INT_MAX, but that doesn't work on
990 64-bit machines.
e46bb31a 991 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 992
c78baabf 993 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 994 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
995 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
996 when a (possibly-narrower) signed value would do just as well.
997 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 998
c9d624c6
PE
999 * alloc.c: Catch some string size overflows that we were missing.
1000 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
1001 for convenience in STRING_BYTES_MAX.
1002 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
1003 The definition here is exact; the one in lisp.h was approximate.
1004 (allocate_string_data): Check for string overflow. This catches
1005 some instances we weren't catching before. Also, it catches
1006 size_t overflow on (unusual) hosts where SIZE_MAX <= min
1007 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
1008 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 1009
c9d624c6
PE
1010 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
1011 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
1012 * lisp.h (STRING_BYTES_BOUND): Renamed from STRING_BYTES_MAX.
1013
353032ce
PE
1014 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
1015
2bccce07
PE
1016 * alloc.c (Fmake_string): Check for out-of-range init.
1017
0ac30604
SM
10182011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
1019
1020 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
1021
c195f2de
JD
10222011-06-14 Jan Djärv <jan.h.d@swipnet.se>
1023
1024 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
1025 xg_get_default_scrollbar_width.
1026
1027 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
1028 (int_gtk_range_get_value): Move to the scroll bar part of the file.
1029 (style_changed_cb): Call update_theme_scrollbar_width and call
1030 x_set_scroll_bar_default_width and xg_frame_set_char_size for
1031 all frames (Bug#8505).
1032 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
1033 Call gtk_window_set_resizable if HAVE_GTK3.
1034 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
1035 and height if HAVE_GTK3 (Bug#8505).
1036 (scroll_bar_width_for_theme): New variable.
1037 (update_theme_scrollbar_width): New function.
1038 (xg_get_default_scrollbar_width): Move code to
1039 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
1040 (xg_initialize): Call update_theme_scrollbar_width.
1041
1042 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
1043
1044 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
1045
e10ac9f1
MR
10462011-06-12 Martin Rudalics <rudalics@gmx.at>
1047
1048 * frame.c (make_frame): Call other_buffer_safely instead of
1049 other_buffer.
1050
1051 * window.c (temp_output_buffer_show): Call display_buffer with
1052 second argument Vtemp_buffer_show_specifiers and reset latter
1053 immediately after the call.
1054 (Vtemp_buffer_show_specifiers): New variable.
1055 (auto_window_vscroll_p, next_screen_context_lines)
1056 (Vscroll_preserve_screen_position): Remove leading asterisks from
1057 doc-strings.
1058
2d3c217e 10592011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 1060
7b7f97e8 1061 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
1062 * buffer.c (Qclone_number): Remove for now, as it's unused.
1063 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
1064 (record_buffer): Remove unused local.
1065 * frame.c (other_visible_frames, frame_buffer_list): Now static.
1066 (set_frame_buffer_list): Remove; unused.
1067 * frame.h (other_visible_frames): Remove decl.
1068 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
1069 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
1070 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
1071 if HAVE_GPM.
1072 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
1073 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
1074 Define only if HAVE_GPM.
1075 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
1076 (update_hints_inhibit): Remove; never set. All uses removed.
1077 * widgetprv.h (emacsFrameClassRec): Remove decl.
1078 * window.c (delete_deletable_window): Now returns void, since it
1079 wasn't returning anything.
1080 (compare_window_configurations): Remove unused locals.
1081 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
1082 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
1083 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
1084 the same widths as pointers. This follows up on the 2011-05-06 patch.
1085 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
1086 * xterm.h: Likewise.
1087 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
1088
1384b89e
JB
10892011-06-12 Juanma Barranquero <lekktu@gmail.com>
1090
1091 * makefile.w32-in: Update dependencies.
1092 (LISP_H): Add lib/intprops.h.
1093
1100a63c
CY
10942011-06-11 Chong Yidong <cyd@stupidchicken.com>
1095
1096 * image.c (gif_load): Add animation frame delay to the metadata.
1097 (syms_of_image): Use DEFSYM. New symbol `delay'.
1098
6198ccd0
MR
10992011-06-11 Martin Rudalics <rudalics@gmx.at>
1100
1101 * window.c (delete_deletable_window): Re-add.
1102 (Fset_window_configuration): Rewrite to handle dead buffers and
1103 consequently deletable windows.
1104 (window_tree, Fwindow_tree): Remove. Supply functionality in
1105 window.el.
1106 (compare_window_configurations): Simplify code.
1107
b6e3633c
AS
11082011-06-11 Andreas Schwab <schwab@linux-m68k.org>
1109
1ab0dee5
AS
1110 * image.c (imagemagick_load_image): Fix type mismatch.
1111 (Fimagemagick_types): Likewise.
1112
b6e3633c
AS
1113 * window.h (replace_buffer_in_windows): Declare.
1114
9397e56f
MR
11152011-06-11 Martin Rudalics <rudalics@gmx.at>
1116
1117 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
1118 Qclone_number. Remove external declaration of Qdelete_window.
1119 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
1120 code.
1121 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer): Run
1122 Qbuffer_list_update_hook if allowed.
1123 (Fother_buffer): Rewrite doc-string. Major rewrite for new
1124 buffer list implementation.
1125 (other_buffer_safely): New function.
1126 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
1127 calls to replace_buffer_in_windows and
1128 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
1129 if allowed.
1130 (record_buffer): Inhibit quitting and rewrite using quittable
1131 functions. Run Qbuffer_list_update_hook if allowed.
1132 (Frecord_buffer, Funrecord_buffer): New functions.
1133 (switch_to_buffer_1, Fswitch_to_buffer): Remove. Move
1134 switch-to-buffer to window.el.
1135 (bury-buffer): Move to window.el.
1136 (Vbuffer_list_update_hook): New variable.
1137
1138 * lisp.h (other_buffer_safely): Add prototype in buffer.c
1139 section.
1140
1141 * window.h (resize_frame_windows): Move up in code.
1142 (Fwindow_frame): Remove EXFUN.
1143 (replace_buffer_in_all_windows): Remove prototype.
1144 (replace_buffer_in_windows_safely): Add prototype.
1145
1146 * window.c: Declare Qdelete_window static again. Move down
1147 declaration of select_count.
1148 (Fnext_window, Fprevious_window): Rewrite doc-strings.
1149 (Fother_window): Move to window.el.
1150 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
1151 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
1152 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
1153 window.el.
1154 (replace_buffer_in_windows): Implement by calling
1155 Qreplace_buffer_in_windows.
1156 (replace_buffer_in_all_windows): Remove with some functionality
1157 moved into replace_buffer_in_windows_safely.
1158 (replace_buffer_in_windows_safely): New function.
1159 (select_window_norecord, select_frame_norecord): Move in front
1160 of run_window_configuration_change_hook. Remove now obsolete
1161 declarations.
1162 (Fset_window_buffer): Rewrite doc-string. Call
1163 Qrecord_window_buffer.
1164 (keys_of_window): Move binding for other-window to window.el.
1165
b50691aa
CY
11662011-06-11 Chong Yidong <cyd@stupidchicken.com>
1167
1168 * dispextern.h (struct image): Replace data member, whose int_val
1169 and ptr_val fields were not used by anything, with a single
1170 lisp_val object.
1171
1172 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
1173 (gif_clear_image, gif_load, imagemagick_load_image)
1174 (gs_clear_image, gs_load): Callers changed.
1175
3f754b86
PE
11762011-06-10 Paul Eggert <eggert@cs.ucla.edu>
1177
cca69397
PE
1178 * buffer.h: Include <time.h>, for time_t.
1179 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
1180
109e28d0
PE
1181 Fix minor problems found by static checking.
1182
60737f02
PE
1183 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
1184
4b66faf3
PE
1185 Make identifiers static if they are not used in other modules.
1186 * data.c (Qcompiled_function, Qframe, Qvector):
1187 * image.c (QimageMagick, Qsvg):
1188 * minibuf.c (Qmetadata):
1189 * window.c (resize_window_check, resize_root_window): Now static.
1190 * window.h (resize_window_check, resize_root_window): Remove decls.
1191
109e28d0
PE
1192 * window.c (window_deletion_count, delete_deletable_window):
1193 Remove; unused.
46a4ce9e
PE
1194 (window_body_lines): Now static.
1195 (Fdelete_other_windows_internal): Mark vars as initialized.
1196 Make sure 'resize_failed' is initialized.
1197 (run_window_configuration_change_hook): Rename local to avoid shadowing.
1198 (resize_window_apply): Remove unused local.
1199 * window.h (delete_deletable_window): Remove decl.
1200
109e28d0 1201 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
1202 (imagemagick_load_image): Fix pointer signedness problem by changing
1203 last arg from unsigned char * to char *. All uses changed.
1204 Also, fix a local for similar reasons.
1205 Remove unused locals. Remove locals to avoid shadowing.
1206 (fn_rsvg_handle_free): Remove; unused.
1207 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 1208 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 1209
3f754b86
PE
1210 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
1211
2547adb1
CY
12122011-06-10 Chong Yidong <cyd@stupidchicken.com>
1213
1214 * image.c (gif_load): Fix omitted cast error introduced by
1215 2011-06-06 change.
1216
2c8e37d4
MR
12172011-06-10 Martin Rudalics <rudalics@gmx.at>
1218
1219 * window.h (resize_proportionally, orig_total_lines)
1220 (orig_top_line): Remove from window structure.
1221 (set_window_height, set_window_width, change_window_heights)
1222 (Fdelete_window): Remove prototypes.
1223 (resize_frame_windows): Remove duplicate declaration.
1224
440a42e3
EZ
12252011-06-10 Eli Zaretskii <eliz@gnu.org>
1226
1227 * window.h (resize_frame_windows, resize_window_check)
1228 (delete_deletable_window, resize_root_window)
1229 (resize_frame_windows): Declare prototypes.
1230
1231 * window.c (resize_window_apply): Make definition be "static" to
1232 match the prototype.
1233
562dd5e9
MR
12342011-06-10 Martin Rudalics <rudalics@gmx.at>
1235
1236 * window.c: Remove declarations of Qwindow_size_fixed,
1237 window_min_size_1, window_min_size_2, window_min_size,
1238 size_window, window_fixed_size_p, enlarge_window, delete_window.
1239 Remove static from declaration of Qdelete_window, it's
1240 temporarily needed by Fbury_buffer.
1241 (replace_window): Don't assign orig_top_line and
1242 orig_total_lines.
1243 (Fdelete_window, delete_window): Remove. Window deletion is
1244 handled by window.el.
1245 (window_loop): Remove DELETE_OTHER_WINDOWS case. Replace
1246 Fdelete_window calls with calls to Qdelete_window.
1247 (Fdelete_other_windows): Remove. Deleting other windows is
1248 handled by window.el.
1249 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
1250 handled in window.el.
1251 (window_min_size_2, window_min_size_1, window_min_size): Remove.
1252 Window minimum sizes are handled in window.el.
1253 (shrink_windows, size_window, set_window_height)
1254 (set_window_width, change_window_heights, window_height)
1255 (window_width, CURBEG, CURSIZE, enlarge_window)
1256 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
1257 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
1258 handled in window.el.
1259 (make_dummy_parent): Rename to make_parent_window and give it a
1260 second argument horflag.
1261 (make_window): Don't set resize_proportionally any more.
1262 (Fsplit_window): Remove. Windows are split in window.el.
1263 (save_restore_action, save_restore_orig_size)
1264 (shrink_window_lowest_first, save_restore_orig_size): Remove.
1265 Resize mini windows in window.el.
1266 (grow_mini_window, shrink_mini_window): Implement by calling
1267 Qresize_root_window_vertically, resize_window_check and
1268 resize_window_apply.
1269 (saved_window, Fset_window_configuration, save_window_save): Do
1270 not handle orig_top_line, orig_total_lines, and
1271 resize_proportionally.
1272 (window_min_height, window_min_width): Move to window.el.
1273 (keys_of_window): Move bindings for delete-other-windows,
1274 split-window, delete-window and enlarge-window to window.el.
1275
1276 * buffer.c: Temporarily extern Qdelete_window.
1277 (Fbury_buffer): Temporarily call Qdelete_window instead of
1278 Fdelete_window (Fbury_buffer will move to window.el soon).
1279
1280 * frame.c (set_menu_bar_lines_1): Remove code handling
1281 orig_top_line and orig_total_lines.
1282
1283 * dispnew.c (adjust_frame_glyphs_initially): Don't use
1284 set_window_height but set heights directly.
1285 (change_frame_size_1): Use resize_frame_windows.
1286
1287 * xdisp.c (init_xdisp): Don't use set_window_height but set
1288 heights directly.
1289
1290 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines): Use
1291 resize_frame_windows instead of change_window_heights and run
1292 run_window_configuration_change_hook.
1293
1294 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
1295 instead of change_window_heights and run
1296 run_window_configuration_change_hook.
1297
1a13852e
MR
12982011-06-09 Martin Rudalics <rudalics@gmx.at>
1299
1300 * window.c (replace_window): Rename second argument REPLACEMENT to
1301 NEW. New third argument SETFLAG. Rewrite.
1302 (delete_window, make_dummy_parent): Call replace_window with
1303 third argument 1.
1304 (window_list_1): Move down in code.
1305 (run_window_configuration_change_hook): Move set_buffer part
1306 before select_frame_norecord part in order to unwind correctly.
1307 Rename count1 to count.
1308 (recombine_windows, delete_deletable_window, resize_root_window)
1309 (Fdelete_other_windows_internal)
1310 (Frun_window_configuration_change_hook, make_parent_window)
1311 (resize_window_check, resize_window_apply, Fresize_window_apply)
1312 (resize_frame_windows, Fsplit_window_internal)
1313 (Fdelete_window_internal, Fresize_mini_window_internal): New
1314 functions.
1315 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
1316
f3d1777e
MR
13172011-06-08 Martin Rudalics <rudalics@gmx.at>
1318
496e208e
MR
1319 * window.h (window): Add some new members to window structure -
1320 normal_lines, normal_cols, new_total, new_normal, clone_number,
1321 splits, nest, prev_buffers, next_buffers.
1322 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 1323 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 1324
f3d1777e
MR
1325 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
1326 Remove.
496e208e
MR
1327 (make_dummy_parent): Set new members of windows structure.
1328 (make_window): Move down in code. Handle new members of window
1329 structure.
1330 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
1331 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
1332 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
1333 (Fset_window_prev_buffers, Fwindow_next_buffers)
1334 (Fset_window_next_buffers, Fset_window_clone_number): New
1335 functions.
1336 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
1337 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
1338 Doc-string fixes.
1339 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
1340 Argument WINDOW can be now internal window too.
1341 (Fwindow_use_time): Move up in code.
1342 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
1343 Rewrite doc-string.
1344 (Fset_window_configuration, saved_window)
1345 (Fcurrent_window_configuration, save_window_save): Handle new
1346 members of window structure.
b9e809c2
MR
1347 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
1348 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
1349 (syms_of_window): New Lisp objects Qrecord_window_buffer,
1350 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
1351 Qget_mru_window, Qresize_root_window,
1352 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
1353 Qauto_buffer_name; staticpro them.
f3d1777e 1354
abde8f8c
MR
13552011-06-07 Martin Rudalics <rudalics@gmx.at>
1356
1357 * window.c (Fwindow_total_size, Fwindow_left_column)
1358 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
1359 (Fwindow_list_1): New functions.
1360 (window_box_text_cols): Replace with window_body_cols.
1361 (Fwindow_width, Fscroll_left, Fscroll_right): Use
1362 window_body_cols instead of window_box_text_cols.
fa8a67e6
MR
1363 (delete_window, Fset_window_configuration): Call
1364 delete_all_subwindows with window as argument.
1365 (delete_all_subwindows): Take a window as argument and not a
1366 structure. Rewrite.
190b47e6
MR
1367 (window_loop): Remove handling of GET_LRU_WINDOW and
1368 GET_LARGEST_WINDOW.
1369 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
1370
1371 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
1372 window_box_text_cols. delete_all_subwindows now takes a
1373 Lisp_Object as argument.
abde8f8c
MR
1374
1375 * indent.c (compute_motion, Fcompute_motion): Use
1376 window_body_cols instead of window_box_text_cols.
1377
fa8a67e6
MR
1378 * frame.c (delete_frame): Call delete_all_subwindows with root
1379 window as argument.
1380
a54e3482
DC
13812011-06-07 Daniel Colascione <dan.colascione@gmail.com>
1382
1383 * fns.c (Fputhash): Document return value.
1384
60002bf5
CY
13852011-06-06 Chong Yidong <cyd@stupidchicken.com>
1386
1387 * image.c (gif_load): Implement gif89a spec "no disposal" method.
1388
0c671da6 13892011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 1390
b862a52a 1391 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 1392
be44ca6c
PE
1393 Check for overflow when converting integer to cons and back.
1394 * charset.c (Fdefine_charset_internal, Fdecode_char):
1395 Use cons_to_unsigned to catch overflow.
1396 (Fencode_char): Use INTEGER_TO_CONS.
1397 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
1398 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
1399 * data.c (long_to_cons, cons_to_long): Remove.
1400 (cons_to_unsigned, cons_to_signed): New functions.
1401 These signal an error for invalid or out-of-range values.
1402 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
1403 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
1404 * font.c (Ffont_variation_glyphs):
1405 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
1406 * lisp.h: Include <intprops.h>.
1407 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
1408 (cons_to_signed, cons_to_unsigned): New decls.
1409 (long_to_cons, cons_to_long): Remove decls.
1410 * undo.c (record_first_change): Use INTEGER_TO_CONS.
1411 (Fprimitive_undo): Use CONS_TO_INTEGER.
1412 * xfns.c (Fx_window_property): Likewise.
1413 * xselect.c: Include <limits.h>.
1414 (x_own_selection, selection_data_to_lisp_data):
1415 Use INTEGER_TO_CONS.
1416 (x_handle_selection_request, x_handle_selection_clear)
1417 (x_get_foreign_selection, Fx_disown_selection_internal)
1418 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
1419 (lisp_data_to_selection_data): Use cons_to_unsigned.
1420 (x_fill_property_data): Use cons_to_signed.
1421 Report values out of range.
1422
d1f3d2af
PE
1423 Check for buffer and string overflow more precisely.
1424 * buffer.h (BUF_BYTES_MAX): New macro.
1425 * lisp.h (STRING_BYTES_MAX): New macro.
1426 * alloc.c (Fmake_string):
1427 * character.c (string_escape_byte8):
1428 * coding.c (coding_alloc_by_realloc):
1429 * doprnt.c (doprnt):
1430 * editfns.c (Fformat):
1431 * eval.c (verror):
1432 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
1433 since they may not be the same number.
1434 * editfns.c (Finsert_char):
1435 * fileio.c (Finsert_file_contents):
1436 Likewise for BUF_BYTES_MAX.
1437
dd52fcea
PE
1438 * image.c: Use ptrdiff_t, not int, for sizes.
1439 (slurp_file): Switch from int to ptrdiff_t.
1440 All uses changed.
1441 (slurp_file): Check that file size fits in both size_t (for
1442 malloc) and ptrdiff_t (for sanity and safety).
1443
7f9bbdbb
PE
1444 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
1445 if b->modtime has its maximal value.
1446
dfe18f82
PE
1447 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
1448
84acfcf0
PE
1449 Don't assume time_t can fit into int.
1450 * buffer.h (struct buffer.modtime): Now time_t, not int.
1451 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
1452 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
1453
ccd9a01a
PE
1454 Minor fixes for signed vs unsigned integers.
1455 * character.h (MAYBE_UNIFY_CHAR):
1456 * charset.c (maybe_unify_char):
1457 * keyboard.c (read_char, reorder_modifiers):
1458 XINT -> XFASTINT, since the integer must be nonnegative.
1459 * ftfont.c (ftfont_spec_pattern):
1460 * keymap.c (access_keymap, silly_event_symbol_error):
1461 XUINT -> XFASTINT, since the integer must be nonnegative.
1462 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
1463 since it makes no difference and we prefer signed.
1464 * keyboard.c (record_char): Use XUINT when all the neighbors do.
1465 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
1466 nonnegative.
1467
d6d100dd
SM
14682011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
1469
1470 * window.h (Fwindow_frame): Declare.
1471
2b6148e4
PE
14722011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 * alloc.c: Simplify handling of large-request failures (Bug#8800).
1475 (SPARE_MEMORY): Always define.
1476 (LARGE_REQUEST): Remove.
1477 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
1478
f230ecc9
MR
14792011-06-06 Martin Rudalics <rudalics@gmx.at>
1480
727e958e
MR
1481 * lisp.h: Move EXFUNS for Fframe_root_window,
1482 Fframe_first_window and Fset_frame_selected_window to window.h.
1483
1484 * window.h: Move EXFUNS for Fframe_root_window,
1485 Fframe_first_window and Fset_frame_selected_window here from
1486 lisp.h.
1487
1488 * frame.c (Fwindow_frame, Fframe_first_window)
1489 (Fframe_root_window, Fframe_selected_window)
1490 (Fset_frame_selected_window): Move to window.c.
1491 (Factive_minibuffer_window): Move to minibuf.c.
1492 (Fother_visible_frames_p): New function.
1493
1494 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
1495
f230ecc9
MR
1496 * window.c (decode_window, decode_any_window): Move up in code.
1497 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
1498 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
1499 (Fwindow_buffer): Move up and rewrite doc-string.
1500 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
1501 (Fwindow_prev): New functions.
727e958e
MR
1502 (Fwindow_frame): Move here from frame.c. Accept any window as
1503 argument.
1504 (Fframe_root_window, Fframe_first_window)
1505 (Fframe_selected_window): Move here from frame.c. Accept frame
1506 or arbitrary window as argument. Update doc-strings.
1507 (Fminibuffer_window): Move up in code.
1508 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
1509 (Fset_frame_selected_window): Move here from frame.c.
1510 Marginal rewrite.
727e958e
MR
1511 (Fselected_window, select_window, Fselect_window): Move up in
1512 code. Minor doc-string fixes.
f230ecc9 1513
4d09bcf6
PE
15142011-06-06 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
1517 Do not assume that spare memory exists; that assumption is valid
1518 only if SYSTEM_MALLOC.
1519 (LARGE_REQUEST): New macro, so that the issue of large requests
1520 is separated from the issue of spare memory.
1521
810928a2
AS
15222011-06-05 Andreas Schwab <schwab@linux-m68k.org>
1523
172418ad
AS
1524 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
1525 format. (Bug#8806)
1526
43f862f7
AS
1527 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
1528
810928a2
AS
1529 * xfns.c (x_set_scroll_bar_default_width): Move declarations
1530 before statements.
1531
a059fe24
JD
15322011-06-05 Jan Djärv <jan.h.d@swipnet.se>
1533
1534 * gtkutil.c (xg_get_default_scrollbar_width): New function.
1535
1536 * gtkutil.h: Declare xg_get_default_scrollbar_width.
1537
1538 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
1539 min width by calling x_set_scroll_bar_default_width (Bug#8505).
1540
989bf368
JB
15412011-06-05 Juanma Barranquero <lekktu@gmail.com>
1542
1543 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
1544
4b80f674
CY
15452011-06-04 Chong Yidong <cyd@stupidchicken.com>
1546
1547 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
1548 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
1549 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
1550 New error handlers.
4b80f674
CY
1551 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
1552 Obey Vx_select_enable_clipboard_manager. Catch errors in
1553 x_clipboard_manager_save (Bug#8779).
1554 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 1555 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 1556
99a33b77 15572011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
1558
1559 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
1560
99a33b77 15612011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
1562
1563 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
1564 in the current matrix if keep_current_p is non-zero.
1565
8264569d
EZ
15662011-06-04 Eli Zaretskii <eliz@gnu.org>
1567
1568 * bidi.c (bidi_level_of_next_char): Fix last change.
1569
57f97249
EZ
15702011-06-03 Eli Zaretskii <eliz@gnu.org>
1571
fec2107c 1572 Support bidi reordering of text covered by display properties.
57f97249 1573
fec2107c
EZ
1574 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
1575 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
1576 (bidi_cache_search, bidi_cache_iterator_state)
1577 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
1578 (bidi_level_of_next_char, bidi_move_to_visually_next):
1579 Support character positions inside a run of characters covered by a
fec2107c
EZ
1580 display string.
1581 (bidi_paragraph_init, bidi_resolve_explicit_1)
1582 (bidi_level_of_next_char): Call bidi_fetch_char and
1583 bidi_fetch_char_advance instead of FETCH_CHAR and
1584 FETCH_CHAR_ADVANCE.
1585 (bidi_init_it): Initialize new members.
1586 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
1587 definitions.
1588 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
1589 instead of using explicit *_CHAR codes.
d6d100dd
SM
1590 (bidi_resolve_explicit, bidi_resolve_weak):
1591 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
1592 bidirectional text is supported only in multibyte buffers.
1593 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
1594 it to initialize the frame_window_p member of struct bidi_it.
1595 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
1596 (bidi_resolve_explicit, bidi_resolve_weak)
1597 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
1598 bidi_it->nchars is non-positive.
1599 (bidi_level_of_next_char): Don't try to lookup the cache for the
1600 next/previous character if nothing is cached there yet, or if we
1601 were just reseat()'ed to a new position.
c40e2fb2 1602
0e14fe90
EZ
1603 * xdisp.c (set_cursor_from_row): Set start and stop points
1604 according to the row's direction when priming the loop that looks
1605 for the glyph on which to display cursor.
1606 (single_display_spec_intangible_p): Function deleted.
1607 (display_prop_intangible_p): Reimplement to call
1608 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
1609 Accept 3 additional arguments needed by handle_display_spec.
1610 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
1611 values: lists, `(when COND...)' forms, etc.
1612 (single_display_spec_string_p): Support property values that are
1613 lists with the argument STRING its top-level element.
1614 (display_prop_string_p): Fix the condition for processing a
1615 property that is a list to be consistent with handle_display_spec.
fec2107c 1616 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
1617 last portion of handle_display_prop.
1618 (compute_display_string_pos): Accept additional argument
1619 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
1620 value of a `display' property is a "replacing spec".
1621 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
1622 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
1623 the display property, but just return a value indicating whether
1624 the display property will replace the characters it covers.
1625 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
1626 frame_window_p members of struct bidi_it.
d6d100dd
SM
1627 (compute_display_string_pos, compute_display_string_end):
1628 New functions.
fec2107c
EZ
1629 (push_it): Accept second argument POSITION, where pop_it should
1630 jump to continue iteration.
1631 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 1632
fec2107c
EZ
1633 * keyboard.c (adjust_point_for_property): Adjust the call to
1634 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
1635
1636 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
1637 (bidi_init_it): Update prototypes.
1638 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
1639 (compute_display_string_pos, compute_display_string_end):
1640 Declare prototypes.
fec2107c
EZ
1641 (struct bidi_it): New members nchars and disp_pos. ch_len is now
1642 EMACS_INT.
fc6f18ce 1643
40087514 16442011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 1645
57f53182
PE
1646 Malloc failure behavior now depends on size of allocation.
1647 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
1648 * lisp.h: Change signatures accordingly.
1649 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
1650 All callers changed. (Bug#8762)
1651
1652 * gnutls.c: Use Emacs's memory allocators.
1653 Without this change, the gnutls library would invoke malloc etc.
1654 directly, which causes problems on non-SYNC_INPUT hosts, and which
1655 runs afoul of improving memory_full behavior. (Bug#8761)
1656 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
1657 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
1658 xfree instead of the default malloc, realloc, free.
1659 (Fgnutls_boot): No need to check for memory allocation failure,
1660 since xmalloc does that for us.
1661
ac32cd99 1662 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
1663 * category.c (hash_get_category_set):
1664 * ccl.c (ccl_driver):
1665 * charset.c (Fdefine_charset_internal):
1666 * charset.h (struct charset.hash_index):
1667 * composite.c (get_composition_id, gstring_lookup_cache)
1668 (composition_gstring_put_cache):
1669 * composite.h (struct composition.hash_index):
1670 * dispextern.h (struct image.hash):
1671 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
1672 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
1673 (hashfn_equal, hashfn_user_defined, make_hash_table)
1674 (maybe_resize_hash_table, hash_lookup, hash_put)
1675 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
1676 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
1677 (Fsxhash, Fgethash, Fputhash, Fmaphash):
1678 * image.c (make_image, search_image_cache, lookup_image)
1679 (xpm_put_color_table_h):
1680 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 1681 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
3870d916
PE
1682 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
1683 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
1684 * alloc.c (allocate_vectorlike):
1685 Check for overflow in vector size calculations.
1686 * ccl.c (ccl_driver):
1687 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
1688 * fns.c, image.c: Remove unnecessary static decls that would otherwise
1689 need to be updated by these changes.
40087514
PE
1690 * fns.c (make_hash_table, maybe_resize_hash_table):
1691 Check for integer overflow with large hash tables.
0de4bb68
PE
1692 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
1693 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
1694 (SXHASH_REDUCE): New macro.
1695 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
1696 Use it instead of discarding useful hash info with large hash values.
1697 (sxhash_float): New function.
1698 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
1699 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
1700 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
1701 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
1702 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
1703 Adjust signatures to match updated version of code.
1704 (consing_since_gc): Now EMACS_INT, since a single hash table can
1705 use more than INT_MAX bytes.
1706
698d32e2
DN
17072011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
1708
1709 Make it possible to build with GCC-4.6+ -O2 -flto.
1710
1711 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
1712
fd6fa53f
SM
17132011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
1714
1715 * minibuf.c (get_minibuffer, read_minibuf_unwind):
1716 Call minibuffer-inactive-mode.
1717
864db017
JB
17182011-05-31 Juanma Barranquero <lekktu@gmail.com>
1719
1720 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
1721 Update dependencies.
1722
2ad0baf4
DN
17232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1724
1725 * data.c (init_data): Remove code for UTS, this system is not
1726 supported anymore.
1727
4fcc2638
DN
17282011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1729
1730 Don't force ./temacs to start in terminal mode.
1731
1732 * frame.c (make_initial_frame): Initialize faces in all cases, not
1733 only when CANNOT_DUMP is defined.
1734 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
1735
c56e0fd5
DN
17362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1737
1738 * dispnew.c (add_window_display_history): Use const for the string
1739 pointer. Remove declaration, not needed.
1740
333d54da 17412011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 1742
55d4c1b2 1743 Use 'inline', not 'INLINE'.
333d54da 1744 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
1745 * alloc.c, fontset.c (INLINE): Remove.
1746 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
1747 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
1748 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
1749 * gmalloc.c (register_heapinfo): Use inline unconditionally.
1750 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
1751
738db178
DN
17522011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
1753
1754 Make it possible to run ./temacs.
1755
1756 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
1757 syms_of_callproc does the same thing. Remove test for
1758 "initialized", do it in the caller.
1759 * emacs.c (main): Avoid calling set_initial_environment when dumping.
1760
620c53a6
SM
17612011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
1762
1763 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
1764 (read_minibuf): Use get_minibuffer.
1765 (syms_of_minibuf): Use DEFSYM.
1766 (Qmetadata): New var.
1767 * data.c (Qbuffer): Don't make it static.
1768 (syms_of_data): Use DEFSYM.
1769
e003a292
PE
17702011-05-31 Paul Eggert <eggert@cs.ucla.edu>
1771
1772 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
1773 (CCL_CODE_MIN): New macro.
1774
ed008a6d
PE
17752011-05-30 Paul Eggert <eggert@cs.ucla.edu>
1776
3687c2ef
PE
1777 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
1778
ed008a6d
PE
1779 * eval.c (Qdebug): Now static.
1780 * lisp.h (Qdebug): Remove decl. This reverts a part of the
1781 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
1782 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
1783
d66c4c7c
CY
17842011-05-29 Chong Yidong <cyd@stupidchicken.com>
1785
1786 * image.c: Various fixes to ImageMagick code comments.
1787 (Fimagemagick_types): Doc fix.
1788
5fbc2025
PE
17892011-05-29 Paul Eggert <eggert@cs.ucla.edu>
1790
0196f88a
PE
1791 Minor fixes prompted by GCC 4.6.0 warnings.
1792
1793 * xselect.c (converted_selections, conversion_fail_tag): Now static.
1794
5fbc2025
PE
1795 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
1796 (x_clipboard_manager_save_all): Move extern decl to ...
1797 * xterm.h: ... here, so that it can be checked for consistency.
1798
1dd3c2d9
CY
17992011-05-29 Chong Yidong <cyd@stupidchicken.com>
1800
1801 * xselect.c (x_clipboard_manager_save_frame)
1802 (x_clipboard_manager_save_all): New functions.
1803 (Fx_clipboard_manager_save): Lisp function deleted.
1804
1805 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
1806 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
1807
1808 * xterm.h: Update prototype.
1809
5ba6571d
WX
18102011-05-28 William Xu <william.xwl@gmail.com>
1811
1812 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
1813 exiting (Bug#8239).
1814
3eaff834
JM
18152011-05-28 Jim Meyering <meyering@redhat.com>
1816
e1900994 1817 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
1818 * fns.c (to_uchar): Define.
1819 (crypto_hash_function): Use it to convert some newly-signed
1820 variables to unsigned, to avoid sign-extension bugs. For example,
1821 without this change, (md5 "truc") would evaluate to
1822 45723a2aff78ff4fff7fff1114760e62 rather than the expected
1823 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 1824 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 1825
0f6990a7
PE
18262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1827
1828 Integer overflow fixes.
c8a9ca5a 1829
08686060
PE
1830 * dbusbind.c: Serial number integer overflow fixes.
1831 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
1832 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
1833 to hold a serial number that is too large for a fixnum.
1834 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1835 Check for serial numbers out of range. Decode any serial number
59568bf0 1836 that was so large that it became a float. (Bug#8722)
08686060 1837
2d1fc3c7
PE
1838 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
1839 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1840 Use XFASTINT rather than XUINT when numbers are nonnegative.
1841 (xd_append_arg, Fdbus_method_return_internal):
1842 (Fdbus_method_error_internal): Likewise. Also, for unsigned
1843 arguments, check that Lisp number is nonnegative, rather than
59568bf0 1844 silently wrapping negative numbers around. (Bug#8722)
30217ff0 1845 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 1846 (Bug#8722)
2d1fc3c7 1847
c8a9ca5a
PE
1848 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
1849
519e1d69
PE
1850 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
1851
30569699
PE
1852 ccl: add integer overflow checks
1853 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
1854 (IN_INT_RANGE): New macros.
1855 (ccl_driver): Use them to check for integer overflow when
1856 decoding a CCL program. Many of the new checks are whether XINT (x)
1857 fits in int; it doesn't always, on 64-bit hosts. The new version
1858 doesn't catch all possible integer overflows, but it's an
847044ea 1859 improvement. (Bug#8719)
30569699 1860
c11285dc
PE
1861 * alloc.c (make_event_array): Use XINT, not XUINT.
1862 There's no need for unsigned here.
1863
fdccd48e
PE
1864 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
1865 This follows up to the 2011-05-06 change that substituted uintptr_t
1866 for EMACS_INT. This case wasn't caught back then.
1867
37910ab2
PE
1868 Rework Fformat to avoid integer overflow issues.
1869 * editfns.c: Include <float.h> unconditionally, as it's everywhere
1870 now (part of C89). Include <verify.h>.
1871 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
1872 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
1873 (Fformat): Avoid the prepass trying to compute sizes; it was only
1874 approximate and thus did not catch overflow reliably. Instead, walk
1875 through the format just once, formatting and computing sizes as we go,
1876 checking for integer overflow at every step, and allocating a larger
1877 buffer as needed. Keep track separately whether the format is
1878 multibyte. Keep only the most-recently calculated precision, rather
1879 than them all. Record whether each argument has been converted to
1880 string. Use EMACS_INT, not int, for byte and char and arg counts.
1881 Support field widths and precisions larger than INT_MAX. Avoid
1882 sprintf's undefined behavior with conversion specifications such as %#d
1883 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
1884 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
1885 formatting out-of-range floating point numbers with int
9173deec 1886 formats. (Bug#8668)
37910ab2 1887
2e6578fb
PE
1888 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
1889
0ae6bdee
PE
1890 * data.c: Avoid integer truncation in expressions involving floats.
1891 * data.c: Include <intprops.h>.
1892 (arith_driver): When there's an integer overflow in an expression
1893 involving floating point, convert the integers to floating point
1894 so that the resulting value does not suffer from catastrophic
1895 integer truncation. For example, on a 64-bit host (* 4
1896 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
1897 Do not rely on undefined behavior after integer overflow.
1898
de883a70
PE
1899 merge count_size_as_multibyte, parse_str_to_multibyte
1900 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 1901 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
1902 Check for integer overflow.
1903 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
1904 since it's now a duplicate of the other. This is more of
1905 a character than a buffer op, so better that it's in character.c.
1906 * fns.c, print.c: Adjust to above changes.
1907
2ff916cb
PE
19082011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
1909
1910 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
1911
f1b54466
PE
19122011-05-27 Paul Eggert <eggert@cs.ucla.edu>
1913
fb1ac845
PE
1914 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1915 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
1916 (x_clipboard_manager_save): Now static.
1917 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
1918
f1b54466
PE
1919 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
1920 (crypto_hash_function): Now static.
1921 Fix pointer signedness problems. Avoid unnecessary initializations.
1922
a9f737ee
CY
19232011-05-27 Chong Yidong <cyd@stupidchicken.com>
1924
1925 * termhooks.h (Vselection_alist): Make it terminal-local.
1926
1927 * terminal.c (create_terminal): Initialize it.
1928
1929 * xselect.c: Support for clipboard managers.
1930 (Vselection_alist): Move to termhooks.h as terminal-local var.
1931 (LOCAL_SELECTION): New macro.
1932 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
1933 (symbol_to_x_atom): Remove gratuitous arg.
1934 (x_handle_selection_request, lisp_data_to_selection_data)
1935 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
1936 (x_own_selection, x_get_local_selection, x_convert_selection):
1937 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
1938 (some_frame_on_display): Delete unused function.
1939 (Fx_own_selection_internal, Fx_get_selection_internal)
1940 (Fx_disown_selection_internal, Fx_selection_owner_p)
1941 (Fx_selection_exists_p): New optional frame arg.
1942 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
1943 (x_handle_selection_clear): Don't treat other terminals with the
1944 same keyboard specially. Use the terminal-local Vselection_alist.
1945 (x_clear_frame_selections): Use Frun_hook_with_args.
1946
1947 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
1948
1949 * xterm.h: Add support for those atoms.
1950
e067f0c1
CY
19512011-05-26 Chong Yidong <cyd@stupidchicken.com>
1952
1953 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
1954 (converted_selections, conversion_fail_tag): New global variables.
1955 (x_selection_request_lisp_error): Free the above.
1956 (x_get_local_selection): Remove unnecessary code.
1957 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
1958 of converted selections stored in converted_selections.
1959 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
1960 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
1961 (x_convert_selection): New function.
1962 (x_handle_selection_event): Simplify.
1963 (x_get_foreign_selection): Don't ignore incoming requests while
1964 waiting for an answer; this will fail when we implement
1965 SAVE_TARGETS, and seems unnecessary anyway.
1966 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
1967 (Vx_sent_selection_functions): Doc fix.
1968
0f4aebc0
LL
19692011-05-26 Leo Liu <sdl.web@gmail.com>
1970
1971 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
1972
e61124cd
YM
19732011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1974
1975 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
1976
1977 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
1978 for fringe update if it has periodic bitmap.
1979 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
1980 and fringe_bitmap_periodic_p.
1981
1982 * fringe.c (get_fringe_bitmap_data): New function.
1983 (draw_fringe_bitmap_1, update_window_fringes): Use it.
1984 (update_window_fringes): Record periodicity of fringe bitmap in glyph
1985 row. Mark glyph row for fringe update if periodicity changed.
1986
1987 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
1988 for fringe update unless it has periodic bitmap.
1989
f16d9837
KH
19902011-05-25 Kenichi Handa <handa@m17n.org>
1991
1992 * xdisp.c (get_next_display_element): Set correct it->face_id for
1993 a static composition.
1994
e1b90ef6
LL
19952011-05-24 Leo Liu <sdl.web@gmail.com>
1996
1997 * deps.mk (fns.o):
1998 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
1999
2000 * fns.c (crypto_hash_function, Fsha1): New function.
2001 (Fmd5): Use crypto_hash_function.
2002 (syms_of_fns): Add Ssha1.
2003
7400048f
PE
20042011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2005
2006 * gnutls.c: Remove unused macros.
2007 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
2008 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
2009 Remove macros that are defined and never used.
2010 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
2011
abb71cf4
CY
20122011-05-22 Chong Yidong <cyd@stupidchicken.com>
2013
2014 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
2015 (Fx_get_selection_internal): Minor cleanup.
2016 (Fx_own_selection_internal): Rename arguments for consistency with
2017 select.el.
2018
6307db39
PE
20192011-05-22 Paul Eggert <eggert@cs.ucla.edu>
2020
2021 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
2022
f3d4e0a4
CY
20232011-05-22 Chong Yidong <cyd@stupidchicken.com>
2024
2025 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
2026
4d8ade89
YM
20272011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2028
2029 * dispnew.c (scrolling_window): Don't exclude the case that the
2030 last enabled row in the desired matrix touches the bottom boundary.
2031
32078c8d
GM
20322011-05-21 Glenn Morris <rgm@gnu.org>
2033
2034 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
2035 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
2036 and add some more files.
32078c8d 2037
7285dc67
EZ
20382011-05-20 Eli Zaretskii <eliz@gnu.org>
2039
2040 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
2041 report_file_error introduced by the change from 2011-05-07.
2042
89d1bd22
PE
20432011-05-20 Paul Eggert <eggert@cs.ucla.edu>
2044
2045 * systime.h (Time): Define only if emacs is defined.
2046 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
2047 where the include path doesn't have X11/X.h by default. See
2048 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
2049
e23640bb 20502011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
2051
2052 * composite.c (find_automatic_composition): Fix previous change.
2053
b9704ad9
GM
20542011-05-20 Glenn Morris <rgm@gnu.org>
2055
2056 * lisp.mk: New file, split from Makefile.in.
2057 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
2058 (shortlisp): Remove.
2059 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
2060
4a720484
GM
20612011-05-19 Glenn Morris <rgm@gnu.org>
2062
2063 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
2064 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
2065 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
2066 (lisp): Set the order to that of loadup.el.
2067 (shortlisp): Make it a copy of $lisp.
2068 (SOME_MACHINE_LISP): Remove.
2069 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
2070 Use just $shortlisp, not $SOME_MACHINE_LISP too.
2071
a28d4396
KH
20722011-05-18 Kenichi Handa <handa@m17n.org>
2073
2074 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
2075 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
2076 (find_automatic_composition): Mostly rewrite for efficiency.
2077
a2b1fa8e
JB
20782011-05-18 Juanma Barranquero <lekktu@gmail.com>
2079
2080 * makefile.w32-in: Update dependencies.
2081
8e1f5610
CS
20822011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
2083
2084 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 2085 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 2086
7025ee00 20872011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 2088
cdfa6eab
PE
2089 Fix some integer overflow issues, such as string length overflow.
2090
06d6db33
PE
2091 * insdel.c (count_size_as_multibyte): Check for string overflow.
2092
2b4560a8
PE
2093 * character.c (lisp_string_width): Check for string overflow.
2094 Use EMACS_INT, not int, for string indexes and lengths; in
2095 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
2096 the resulting string length overflows an EMACS_INT; instead,
2097 report a string overflow if no precision given. When checking for
2098 precision exhaustion, use a check that cannot possibly have
2099 integer overflow. (Bug#8675)
2100 * character.h (lisp_string_width): Adjust to new signature.
2101
cb93f9be
PE
2102 * alloc.c (string_overflow): New function.
2103 (Fmake_string): Use it. This doesn't change behavior, but saves
2104 a few bytes and will simplify future changes.
2105 * character.c (string_escape_byte8): Likewise.
2106 * lisp.h (string_overflow): New decl.
2107
1a1f3366
PE
2108 Fixups, following up to the user-interface timestamp change.
2109 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
2110 for UI timestamps, instead of unsigned long.
9fbd6841
PE
2111 * msdos.c (mouse_get_pos): Likewise.
2112 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
2113 * w32gui.h (Time): Define by including "systime.h" rather than by
2114 declaring it ourselves. (Bug#8664)
2115
d4e3e4d3
PE
2116 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
2117 * image.c (clear_image_cache): Likewise.
2118
f6a24d19
PE
2119 * term.c (term_mouse_position): Don't assume time_t wraparound.
2120
08dc5ae6
PE
2121 Be more systematic about user-interface timestamps.
2122 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
2123 and sometimes 'EMACS_UINT', to represent these timestamps.
2124 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
2125 This makes the code easier to follow, and makes it easier to catch
2126 integer overflow bugs such as Bug#8664.
2127 * frame.c (Fmouse_position, Fmouse_pixel_position):
2128 Use Time, not unsigned long, for user-interface timestamps.
2129 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
2130 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
2131 * keyboard.h (last_event_timestamp): Likewise.
2132 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
2133 * menu.h (xmenu_show): Likewise.
2134 * term.c (term_mouse_position): Likewise.
2135 * termhooks.h (struct input_event.timestamp): Likewise.
2136 (struct terminal.mouse_position_hook): Likewise.
2137 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
2138 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
2139 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
2140 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
2141 what it was before.
2142 * menu.h, termhooks.h: Include "systime.h", for Time.
2143
8e55734a
PE
2144 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
2145 Don't assume that the difference between two unsigned long values
2146 can fit into an integer. At this point, we know button_down_time
2147 <= event->timestamp, so the difference must be nonnegative, so
2148 there's no need to cast the result if double-click-time is
2149 nonnegative, as it should be; check that it's nonnegative, just in
2150 case. This bug is triggered when events are more than 2**31 ms
86db42d2 2151 apart (about 25 days). (Bug#8664)
8e55734a 2152
841f1b75 2153 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 2154 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 2155
3e26f69c
PE
2156 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
2157 that always fit in int. Use a sentinel instead of a counter, to
2158 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
2159 * frame.h (struct frame): Use int for menu_bar_items_used
2160 instead of EMACS_INT, since it always fits in int.
3e26f69c 2161
5cc152c0
PE
2162 * menu.c (grow_menu_items): Check for int overflow.
2163
d89eb65e
PE
2164 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
2165
5235bd3e
PE
2166 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
2167 Before, the code was not consistent. These values cannot exceed
2168 2**31 - 1 so there's no need to make them unsigned.
2169 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
2170 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
2171 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
2172 as modifiers.
2173 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
2174
bc827e23
PE
2175 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
2176 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
2177 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
2178 presumably because the widths might not match.
2179
78eb494e
PE
2180 * window.c (size_window): Avoid needless test at loop start.
2181
04f2d78b
CB
21822011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
2183
2184 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
2185
d2fc7e3d 21862011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
2187
2188 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
2189
d2fc7e3d 21902011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
2191
2192 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
2193 `width' to `bar_area_x' and `bar_area_width', respectively.
2194 (x_scroll_run): Take account of fringe background extension.
2195
04f2d78b
CB
2196 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
2197 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
2198 `bar_area_width', respectively.
2199 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
2200 background extension.
2201
79b70037
GM
22022011-05-10 Jim Meyering <meyering@redhat.com>
2203
2204 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
2205
2f142cc5
JB
22062011-05-10 Juanma Barranquero <lekktu@gmail.com>
2207
2208 * image.c (Finit_image_library): Return t for built-in image types,
2209 like pbm and xbm. (Bug#8640)
2210
57679c86
AS
22112011-05-09 Andreas Schwab <schwab@linux-m68k.org>
2212
2213 * w32menu.c (set_frame_menubar): Fix submenu allocation.
2214
888c9e86
EZ
22152011-05-07 Eli Zaretskii <eliz@gnu.org>
2216
b0512a1d
EZ
2217 * w32console.c (Fset_screen_color): Doc fix.
2218 (Fget_screen_color): New function.
2219 (syms_of_ntterm): Defsubr it.
2220
7285dc67
EZ
2221 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
2222 unlink the temporary file if Fcall_process didn't create it in the
2223 first place.
2224 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
2225 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
2226 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
2227 cue to call_process_cleanup not to close that handle.
2228
4d3fcc8e
BK
22292011-05-07 Ben Key <bkey76@gmail.com>
2230
2231 * makefile.w32-in: The bootstrap-temacs rule now makes use of
2232 one of two shell specific rules, either bootstrap-temacs-CMD or
2233 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
2234 to the previous implementation of the bootstrap-temacs rule.
2235 The bootstrap-temacs-CMD rule is similar to the previous
2236 implementation of the bootstrap-temacs rule except that it
2237 makes use of the ESC_CFLAGS variable instead of the CFLAGS
2238 variable.
2239
2240 These changes, along with some changes to nt/configure.bat,
2241 nt/gmake.defs, and nt/nmake.defs, are required to extend my
2242 earlier fix to add support for --cflags and --ldflags options
2243 that include quotes so that it works whether make uses cmd or
2244 sh as the shell.
2245
b4289b64
MA
22462011-05-06 Michael Albinus <michael.albinus@gmx.de>
2247
2248 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
2249 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
2250 is a constant.
2251 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
2252 a string. Handle both cases.
2253 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
2254 (Fdbus_register_method): Use Qinvalid_function.
2255
af4c0e28
JB
22562011-05-06 Juanma Barranquero <lekktu@gmail.com>
2257
2258 * makefile.w32-in: Update dependencies.
2259 (LISP_H): Add inttypes.h and stdin.h.
2260 (PROCESS_H): Add unistd.h.
2261
c51453d9
EZ
22622011-05-06 Eli Zaretskii <eliz@gnu.org>
2263
2264 * lread.c: Include limits.h (fixes the MS-Windows build broken by
2265 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
2266
8ff0ac3c 22672011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 2268
4c4b566b
PE
2269 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
2270
aab2b9b5
PE
2271 * term.c (vfatal): Remove stray call to va_end.
2272 It's not needed and the C Standard doesn't allow it here anyway.
2273
c378da0b
PE
2274 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
2275 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
2276
288b08c7
PE
2277 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
2278 bytes.
2279
e3601888
PE
2280 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
2281
db6c0e74
PE
2282 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2283
dd5963ea
PE
2284 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
2285
88c9450f
PE
2286 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
2287
2f9442b8
PE
2288 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
2289
c032b5f8
PE
2290 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
2291 * charset.c (Fdefine_charset_internal): Don't initialize
2292 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 2293 32-bit int (Bug#8600).
a108c10b
PE
2294
2295 * lread.c (read_integer): Be more consistent with string-to-number.
2296 Use string_to_number to do the actual conversion; this avoids
2297 rounding errors and fixes some other screwups. Without this fix,
2298 for example, #x1fffffffffffffff was misread as -2305843009213693952.
2299 (digit_to_number): Move earlier, for benefit of read_integer.
2300 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 2301 not a digit in any supported base. (Bug#8602)
a108c10b 2302
ad5f9eea
PE
2303 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
2304
aec1708a
PE
2305 * dispnew.c (scrolling_window): Return 1 if we scrolled,
2306 to match comment at start of function. This also removes a
2307 GCC warning about overflow in a 32+64-bit port.
2308
47be4ab5
PE
2309 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
2310
371cac43
PE
2311 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
2312 Reported by Stefan Monnier in
2313 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
2314 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2315 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 2316
d01a7826
PE
2317 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
2318 (EMACS_UINTPTR): Likewise, with uintptr_t.
2319
7fd47d5c
PE
2320 * lisp.h: Prefer 64-bit EMACS_INT if available.
2321 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
2322 on 32-bit hosts that have 64-bit int, so that they can access
2323 large files.
122b0c86
PE
2324 However, temporarily disable this change unless the temporary
2325 symbol WIDE_EMACS_INT is defined.
7fd47d5c 2326
8727937b
PE
2327 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
2328
8ac068ac
PE
2329 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
2330 This removes an assumption that EMACS_INT and long are the same
2331 width as pointers. The assumption is true for Emacs porting targets
2332 now, but we want to make other targets possible.
2333 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
2334 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
2335 In the rest of the code, change types of integers that hold casted
2336 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
2337 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
2338 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
2339 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
2340 No need to cast type when ORing.
2341 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
2342 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
2343 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
2344 assume EMACS_INT is the same width as char *.
2345 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
2346 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
2347 Remove no-longer-needed casts.
2348 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
2349 (xg_tool_bar_help_callback, xg_make_tool_item):
2350 Use EMACS_INTPTR to hold an integer
2351 that will be cast to void *; this can avoid a GCC warning
2352 if EMACS_INT is not the same width as void *.
2353 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
2354 * xdisp.c (display_echo_area_1, resize_mini_window_1):
2355 (current_message_1, set_message_1):
2356 Use a local to convert to proper width without a cast.
2357 * xmenu.c (dialog_selection_callback): Likewise.
2358
ede49d71
PE
2359 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
2360 Also, don't assume VALBITS / RAND_BITS is less than 5,
2361 and don't rely on undefined behavior when shifting a 1 left into
2362 the sign bit.
2363 * lisp.h (get_random): Change signature to match.
2364
2f30ecd0
PE
2365 * lread.c (hash_string): Use size_t, not int, for hash computation.
2366 Normally we prefer signed values; but hashing is special, because
2367 it's better to use unsigned division on hash table sizes so that
2368 the remainder is nonnegative. Also, size_t is the natural width
2369 for hashing into memory. The previous code used 'int', which doesn't
2370 retain enough info to hash well into very large tables.
2371 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
2372
2a866e7b
PE
2373 * dbusbind.c: Don't possibly lose pointer info when converting.
2374 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
2375 Use XPNTR rather than XHASH, so that the high-order bits of
2376 the pointer aren't lost when converting through void *.
2377
51639eac
PE
2378 * eval.c (Fautoload): Don't double-shift a pointer.
2379
92394119
PE
2380 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
2381
dbdb9a7c
JB
23822011-05-06 Juanma Barranquero <lekktu@gmail.com>
2383
2384 * gnutls.c (DEF_GNUTLS_FN):
2385 * image.c (DEF_IMGLIB_FN): Make function pointers static.
2386
db7a0b4f
AS
23872011-05-05 Andreas Schwab <schwab@linux-m68k.org>
2388
2389 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
2390 marker. (Bug#8610)
2391
f7ff1b0f 23922011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
2393
2394 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
2395 New version that can reserve upto 2GB of heap space.
2396
f7ff1b0f 23972011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
2398
2399 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
2400
639c109b
TZ
24012011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
2402
2403 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
2404 `gnutls_certificate_set_x509_key_file'.
2405
d2127135
JB
24062011-05-05 Juanma Barranquero <lekktu@gmail.com>
2407
2408 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
2409 Update dependencies.
2410
e968f4f3
JB
24112011-05-04 Juanma Barranquero <lekktu@gmail.com>
2412
2413 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
2414 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
2415 Remove unused parameter `fildes'.
2416 * process.c (read_process_output, send_process): Don't pass it.
2417
84d358f0
JB
24182011-05-04 Juanma Barranquero <lekktu@gmail.com>
2419
2420 Fix previous change: the library cache is defined in w32.c.
2421 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
2422 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
2423
0898ca10
JB
24242011-05-04 Juanma Barranquero <lekktu@gmail.com>
2425
2426 Implement dynamic loading of GnuTLS on Windows.
2427
2428 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
2429 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
2430 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2431 Declare.
2432
2433 * gnutls.c (Qgnutls_dll): Define.
2434 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
2435 (gnutls_*): Declare function pointers.
2436 (init_gnutls_functions): New function to initialize function pointers.
2437 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
2438 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
2439 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
2440 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
2441 (emacs_gnutls_write, emacs_gnutls_read)
2442 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
2443 (Fgnutls_available_p): New function.
2444 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
2445 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
2446 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
2447
2448 * image.c: Include w32.h.
2449 (Vimage_type_cache): Delete.
2450 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
2451 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
2452 (w32_delayed_load): Move to w32.c.
2453
2454 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
2455
2456 * w32.c (QCloaded_from, Vlibrary_cache): Define.
2457 (w32_delayed_load): Move from image.c. When loading a library, record
2458 its filename in the :loaded-from property of the library id.
2459 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
2460 Initialize and staticpro them.
2461 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
2462
2463 * process.c: Include lisp.h before w32.h, not after.
2464 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
2465 instead of gnutls_record_check_pending.
2466
2467 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
2468
ff4de4aa
TZ
24692011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
2470
2471 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
2472 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
2473 as passed in.
2474
abe95abb
JD
24752011-05-03 Jan Djärv <jan.h.d@swipnet.se>
2476
2477 * xterm.c (x_set_frame_alpha): Do not set property on anything
2478 else than FRAME_X_OUTER_WINDOW (Bug#8608).
2479
e16e55d4
JB
24802011-05-02 Juanma Barranquero <lekktu@gmail.com>
2481
2482 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
2483
bafcf6a5
JB
24842011-05-02 Juanma Barranquero <lekktu@gmail.com>
2485
2486 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
2487 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
2488 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
2489 (gnutls_global_initialized, Qgnutls_bootprop_priority)
2490 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
2491 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
2492 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
2493 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
2494 (Qgnutls_bootprop_callbacks_verify): Make static.
2495
e7a6747f
AS
24962011-05-01 Andreas Schwab <schwab@linux-m68k.org>
2497
19ed11ba
AS
2498 * callproc.c: Indentation fixup.
2499
e7a6747f 2500 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
2501 (wait_for_termination, interruptible_wait_for_termination):
2502 Move after wait_for_termination_1.
e7a6747f 2503
1ef14cb4
LMI
25042011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
2505
2506 * sysdep.c (interruptible_wait_for_termination): New function
2507 which is like wait_for_termination, but allows keyboard
2508 interruptions.
2509
2510 * callproc.c (Fcall_process): Add (:file "file") as an option for
2511 the STDOUT buffer.
2512 (Fcall_process_region): Ditto.
2513
330d880c
EZ
25142011-04-30 Eli Zaretskii <eliz@gnu.org>
2515
8db90b73
EZ
2516 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
2517 rather than `XVECTOR (FOO)->size'.
2518
330d880c
EZ
2519 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
2520 inttypes.h, as a gnulib replacement is used if it not available in
2521 system headers.
2522
15cbd324
EZ
25232011-04-21 Eli Zaretskii <eliz@gnu.org>
2524
2525 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
2526 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
2527 of MOST_POSITIVE_FIXNUM. (Bug#8528)
2528
2529 * coding.c (coding_alloc_by_realloc): Error out if destination
2530 will grow beyond MOST_POSITIVE_FIXNUM.
2531 (decode_coding_emacs_mule): Abort if there isn't enough place in
2532 charbuf for the composition carryover bytes. Reserve an extra
2533 space for up to 2 characters produced in a loop.
2534 (decode_coding_iso_2022): Abort if there isn't enough place in
2535 charbuf for the composition carryover bytes.
2536
25372011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 2538
ae940cca
EZ
2539 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
2540 aborting when %lld or %lll format is passed.
2541 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
2542 %llo or %llx format is passed. (Bug#8545)
2543
03ab8921
EZ
2544 * window.c (window_scroll_line_based): Use a marker instead of
2545 simple variables to record original value of point. (Bug#7952)
2546
afda1437
EZ
2547 * doprnt.c (doprnt): Fix the case where a multibyte sequence
2548 produced by %s or %c overflows available buffer space. (Bug#8545)
2549
f76dee0c
PE
25502011-04-28 Paul Eggert <eggert@cs.ucla.edu>
2551
2552 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 2553 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 2554
fdc5744d
JB
25552011-04-28 Juanma Barranquero <lekktu@gmail.com>
2556
2557 * w32.c (init_environment): Warn about defaulting HOME to C:\.
2558
638f053a
JB
25592011-04-28 Juanma Barranquero <lekktu@gmail.com>
2560
2561 * keyboard.c (Qdelayed_warnings_hook): Define.
2562 (command_loop_1): Run `delayed-warnings-hook'
2563 if Vdelayed_warnings_list is non-nil.
2564 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
2565 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
2566
d178f871
EZ
25672011-04-28 Eli Zaretskii <eliz@gnu.org>
2568
2569 * doprnt.c (doprnt): Don't return value smaller than the buffer
2570 size if the message was truncated. (Bug#8545).
2571
b124fd93
JB
25722011-04-28 Juanma Barranquero <lekktu@gmail.com>
2573
2574 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
2575 (Fx_window_property): #if-0 the whole functions, not just the bodies.
2576
e810457d
PE
25772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2578
2579 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
2580
ea51cceb
JB
25812011-04-27 Juanma Barranquero <lekktu@gmail.com>
2582
2583 * makefile.w32-in: Update dependencies.
2584
94dcfacf
EZ
25852011-04-27 Eli Zaretskii <eliz@gnu.org>
2586
2587 Improve `doprnt' and its usage. (Bug#8545)
2588 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
2589 `format_end'. Remove support for %l as a conversion specifier.
2590 Don't use xrealloc. Improve diagnostics when the %l size modifier
2591 is used. Update the commentary.
2592
2593 * eval.c (verror): Simplify calculation of size_t.
2594
2595 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
2596 messages.
2597
f61f41d7
PE
25982011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
2599
2600 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
2601 change.
2602
96fb4434
PE
26032011-04-27 Paul Eggert <eggert@cs.ucla.edu>
2604
2605 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
2606 This makes this file independent of the recent pseudovector change.
2607
671875da 26082011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 2609
69e9b5a3
PE
2610 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
2611
b5f869a7 2612 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 2613 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 2614 Remove unused local.
c8926152 2615 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 2616
841a1577 2617 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
2618 GCC 4.6.0 optimizes based on type-based alias analysis.
2619 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
2620 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
2621 != &v->size, and therefore "v->size = 1; b->size = 2; return
2622 v->size;" must therefore return 1. This assumption is incorrect
2623 for Emacs, since it type-puns struct Lisp_Vector * with many other
2624 types. To fix this problem, this patch adds a new type struct
f904488f 2625 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
2626 and pseudovectors, and helps optimizing compilers not get fooled
2627 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
2628 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
2629 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
2630 the size member.
eab3844f
PE
2631 (XSETPVECTYPE): Rewrite in terms of new macro.
2632 (XSETPVECTYPESIZE): New macro, specifying both type and size.
2633 This is a bit clearer, and further avoids the possibility of
2634 undesirable aliasing.
2635 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 2636 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
2637 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
2638 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
2639 (ASIZE): Now uses header.size rather than size.
2640 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
2641 to avoid the hassle of writing XVECTOR (foo)->header.size.
2642 (struct vectorlike_header): New type.
eab3844f
PE
2643 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
2644 object, to help avoid aliasing.
2645 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
2646 (SUBRP): Likewise, since Lisp_Subr is a special case.
2647 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
2648 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
2649 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 2650 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
2651 changed to be "header.size" and "header.next".
2652 * buffer.h (struct buffer): Likewise.
2653 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
2654 * frame.h (struct frame): Likewise.
2655 * process.h (struct Lisp_Process): Likewise.
2656 * termhooks.h (struct terminal): Likewise.
2657 * window.c (struct save_window_data, struct saved_window): Likewise.
2658 * window.h (struct window): Likewise.
2659 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
2660 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
2661 * buffer.c (init_buffer_once): Likewise.
2662 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
2663 special case.
2664 * process.c (Fformat_network_address): Use local var for size,
2665 for brevity.
2666
0df1eac5
PE
2667 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
2668
847ab9d1 2669 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
2670 * data.c (atof): Remove decl; no longer used or needed.
2671 (digit_to_number): Move to lread.c.
2672 (Fstring_to_number): Use new string_to_number function, to be
2673 consistent with how the Lisp reader treats infinities and NaNs.
2674 Do not assume that floating-point numbers represent EMACS_INT
2675 without losing information; this is not true on most 64-bit hosts.
2676 Avoid double-rounding errors, by insisting on integers when
2677 parsing non-base-10 numbers, as the documentation specifies.
2678 * lisp.h (string_to_number): New decl, replacing ...
2679 (isfloat_string): Remove.
bc0a5c13 2680 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 2681 (read1): Do not accept +. and -. as integers; this
452f4150
PE
2682 appears to have been a coding error. Similarly, do not accept
2683 strings like +-1e0 as floating point numbers. Do not report
2684 overflow for integer overflows unless the base is not 10 which
2685 means we have no simple and reliable way to continue.
2686 Break out the floating-point parsing into a new
2687 function string_to_number, so that Fstring_to_number parses
2688 floating point numbers consistently with the Lisp reader.
04f2d78b 2689 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
2690 (E_CHAR, EXP_INT): Remove, replacing with ...
2691 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
2692 (string_to_number): New function, replacing isfloat_string.
2693 This function checks for valid syntax and produces the resulting
2694 Lisp float number too. Rework it so that string-to-number
bc0a5c13 2695 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
2696 so that overflow for non-base-10 numbers is reported only when
2697 there's no portable and simple way to convert to floating point.
452f4150 2698
67769ffc
PE
2699 * textprop.c (set_text_properties_1): Rewrite for clarity,
2700 and to avoid GCC warning about integer overflow.
2701
c20db43f
PE
2702 * intervals.h (struct interval): Use EMACS_INT for members
2703 where EMACS_UINT might cause problems. See
2704 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
2705 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
2706 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
2707 All uses changed.
37aa2f85
PE
2708 (offset_intervals): Tell GCC not to worry about length overflow
2709 when negating a negative length.
c20db43f 2710
2538aa2f
PE
2711 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
2712 (overrun_check_free): Likewise.
2713
f2d3008d
PE
2714 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
2715 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
2716 word size.
2717
ec8df744
PE
2718 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2719 (gnutls_make_error): Rename local to avoid shadowing.
2720 (gnutls_emacs_global_deinit): ifdef out; not used.
2721 (Fgnutls_boot): Use const for pointer to readonly storage.
2722 Comment out unused local. Fix pointer signedness problems.
2723
640ee02d
PE
2724 * lread.c (openp): Don't stuff size_t into an 'int'.
2725 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
2726 about possible signed overflow.
2727
6048fb2a
PE
2728 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
2729 (GDK_KEY_g): Don't define if already defined.
2730 (xg_prepare_tooltip): Avoid pointer signedness problem.
2731 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
2732
fa3c87e1
PE
2733 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
2734 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
2735
2172544b
PE
2736 * xfns.c (Fx_window_property): Simplify a bit,
2737 to make a bit faster and to avoid GCC 4.6.0 warning.
2738 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
2739
9b821a21
PE
2740 * fns.c (internal_equal): Don't assume size_t fits in int.
2741
3c616cfa
PE
2742 * alloc.c (compact_small_strings): Tighten assertion a little.
2743
c2982e87
PE
2744 Replace pEd with more-general pI, and fix some printf arg casts.
2745 * lisp.h (pI): New macro, generalizing old pEd macro to other
2746 conversion specifiers. For example, use "...%"pI"d..." rather
2747 than "...%"pEd"...".
2748 (pEd): Remove. All uses replaced with similar uses of pI.
2749 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
2750 * alloc.c (check_pure_size): Don't overflow by converting size to int.
2751 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
2752 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
2753 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
2754 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
2755 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
2756 64-bit hosts.
2757 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
2758 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
2759 * print.c (safe_debug_print, print_object): Likewise.
2760 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
2761 to int.
6f04d126
PE
2762 Use pI instead of if-then-else-abort. Use %p to avoid casts,
2763 avoiding the 0 flag, which is not portable.
c2982e87
PE
2764 * process.c (Fmake_network_process): Use pI to avoid cast.
2765 * region-cache.c (pp_cache): Likewise.
2766 * xdisp.c (decode_mode_spec): Likewise.
2767 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
2768 behavior on 64-bit hosts with printf arg.
6f04d126 2769 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
2770 (x_stop_queuing_selection_requests): Likewise.
2771 (x_get_window_property): Don't truncate byte count to an 'int'
2772 when tracing.
0b432f21 2773
5e073ec7
PE
2774 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
2775 here, since it parses constructs like leading '-' and spaces,
2776 which are not wanted; and it overflows with large numbers.
2777 Instead, simply match F[0-9]+, which is what is wanted anyway.
2778
36372bf9
PE
2779 * alloc.c: Remove unportable assumptions about struct layout.
2780 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
2781 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
2782 (allocate_vectorlike, make_pure_vector): Use the new macros,
2783 plus offsetof, to remove unportable assumptions about struct layout.
2784 These assumptions hold on all porting targets that I know of, but
2785 they are not guaranteed, they're easy to remove, and removing them
2786 makes further changes easier.
2787
0b432f21
PE
2788 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
2789 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
2790 (string_overrun_cookie): Now const. Use initializers that
2791 don't formally overflow signed char, to avoid warnings.
000098c1
PE
2792 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
2793 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
2794 (allocate_buffer): Don't assume sizeof (struct buffer) is a
2795 multiple of sizeof (EMACS_INT); it need not be, if
2796 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 2797 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 2798
895009e1
JB
27992011-04-26 Juanma Barranquero <lekktu@gmail.com>
2800
2801 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
2802
6a7a1b0b
TZ
28032011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
2804
2805 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 2806 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
2807 Reported by Paul Eggert <eggert@cs.ucla.edu>.
2808
841a1577 28092011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
2810
2811 * lisp.h (Qdebug): List symbol.
895009e1 2812 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
2813 * keyboard.c (debug-on-event): New variable.
2814 (handle_user_signal): Break into debugger when debug-on-event
2815 matches the current signal symbol.
2816
f2d3ba6f
DN
28172011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
2818
2819 * alloc.c (check_sblock, check_string_bytes)
2820 (check_string_free_list): Convert to standard C.
2821
42ce4c63
TZ
28222011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
2823
2824 * w32.c (emacs_gnutls_push): Fix typo.
2825
825cd63c
EZ
28262011-04-25 Eli Zaretskii <eliz@gnu.org>
2827
fb11d64d
EZ
2828 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
2829 "cast to pointer from integer of different size".
2830
825cd63c
EZ
2831 Improve doprnt and its use in verror. (Bug#8545)
2832 * doprnt.c (doprnt): Document the set of format control sequences
2833 supported by the function. Use SAFE_ALLOCA instead of always
2834 using `alloca'.
2835
2836 * eval.c (verror): Don't limit the buffer size at size_max-1, that
2837 is one byte too soon. Don't use xrealloc; instead xfree and
2838 xmalloc anew.
2839
e061a11b
TZ
28402011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
2841
2842 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
2843 callbacks stage.
2844
2845 * gnutls.c: Renamed global_initialized to
2846 gnutls_global_initialized. Added internals for the
2847 :verify-hostname-error, :verify-error, and :verify-flags
2848 parameters of `gnutls-boot' and documented those parameters in the
2849 docstring. Start callback support.
9173deec
JB
2850 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
2851 unless a fatal error occurred. Call gnutls_alert_send_appropriate
2852 on error. Return error code.
e061a11b
TZ
2853 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
2854 (emacs_gnutls_read): Likewise.
2855 (Fgnutls_boot): Return handshake error code.
2856 (emacs_gnutls_handle_error): New function.
2857 (wsaerror_to_errno): Likewise.
2858
2859 * w32.h (emacs_gnutls_pull): Add prototype.
2860 (emacs_gnutls_push): Likewise.
2861
2862 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
2863 (emacs_gnutls_push): Likewise.
2864
28652011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
2866
2867 * process.c (wait_reading_process_output): Check if GnuTLS
2868 buffered some data internally if no FDs are set for TLS
2869 connections.
2870
2871 * makefile.w32-in (OBJ2): Add gnutls.$(O).
2872 (LIBS): Link to USER_LIBS.
2873 ($(BLD)/gnutls.$(0)): New target.
2874
fa6996bc
EZ
28752011-04-24 Eli Zaretskii <eliz@gnu.org>
2876
eb35682e
EZ
2877 * xdisp.c (handle_single_display_spec): Rename the
2878 display_replaced_before_p argument into display_replaced_p, to
2879 make it consistent with the commentary. Fix typos in the
2880 commentary.
2881
e2ad650c
EZ
2882 * textprop.c (syms_of_textprop): Remove dead code.
2883 (copy_text_properties): Delete obsolete commentary about an
2884 interface that was deleted long ago. Fix typos in the description
2885 of arguments.
2886
1b2de274
EZ
2887 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
2888 to changes in oldXMenu/XMenu.h from 2011-04-16.
2889 <menu_help_message, prev_menu_help_message>: Constify.
2890 (IT_menu_make_room): menu->help_text is now `const char **';
2891 adjust.
2892
2893 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
2894 to changes in oldXMenu/XMenu.h from 2011-04-16.
2895 (struct XMenu): Declare `help_text' `const char **'.
2896
2897 * xfaces.c <Qunspecified>: Make extern again.
2898
2899 * syntax.c: Include sys/types.h before including regex.h, as
2900 required by Posix.
2901
762b15be
EZ
2902 * doc.c (get_doc_string): Improve the format passed to `error'.
2903
2904 * doprnt.c (doprnt): Improve commentary.
2905
2906 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
2907
2908 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
2909 them with etags.
2910
f1052e5d
EZ
2911 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
2912 changes in globals.h immediately force recompilation.
762b15be
EZ
2913 (TAGS): Depend on $(CURDIR)/m/intel386.h and
2914 $(CURDIR)/s/ms-w32.h.
2915 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 2916
fa6996bc
EZ
2917 * character.c (Fchar_direction): Function deleted.
2918 (syms_of_character): Don't defsubr it.
2919 <char-direction-table>: Deleted.
2920
e6c3da20
EZ
29212011-04-23 Eli Zaretskii <eliz@gnu.org>
2922
2923 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
2924 * doprnt.c: Include limits.h.
2925 (SIZE_MAX): New macro.
04f2d78b
CB
2926 (doprnt): Return a size_t value. 2nd arg is now size_t.
2927 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
2928 Improve overflow protection. Support `l' modifier for integer
2929 conversions. Support %l conversion. Don't assume an EMACS_INT
2930 argument for integer conversions and for %c.
2931
2932 * lisp.h (doprnt): Restore prototype.
2933
2934 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
2935 $(SRC)/character.h.
2936
2937 * Makefile.in (base_obj): Add back doprnt.o.
2938
2939 * deps.mk (doprnt.o): Add back prerequisites.
2940 (callint.o): Depend on character.h.
2941
2942 * eval.c (internal_lisp_condition_case): Include the handler
2943 representation in the error message.
2944 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
2945 when breaking from the loop.
2946
2947 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
2948
2949 * callint.c (Fcall_interactively): When displaying error message
2950 about invalid control letter, pass the character's codepoint, not
2951 a pointer to its multibyte form. Improve display of the character
2952 in octal and display also its hex code.
2953
2954 * character.c (char_string): Use %x to display the (unsigned)
2955 codepoint of an invalid character, to avoid displaying a bogus
2956 negative value.
2957
2958 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
2959 `error', not SYMBOL_NAME itself.
2960
2961 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
2962 character arguments to `error'.
2963
2964 * charset.c (check_iso_charset_parameter): Fix incorrect argument
2965 to `error' in error message about FINAL_CHAR argument. Make sure
2966 FINAL_CHAR is a character, and use %c when it is passed as
2967 argument to `error'.
2968
4ffd0d6b 29692011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
2970
2971 * s/ms-w32.h (localtime): Redirect to sys_localtime.
2972
2973 * w32.c: Include <time.h>.
2974 (sys_localtime): New function.
2975
4ffd0d6b 29762011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
2977
2978 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
2979
4ffd0d6b 2980 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 2981
4ffd0d6b 29822011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 2983
4ffd0d6b
GM
2984 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
2985 zombies (Bug#8467).
aac0c6e3 2986
04c56954
EZ
29872011-04-19 Eli Zaretskii <eliz@gnu.org>
2988
2989 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
2990 gl_state.e_property when gl_state.object is Qt.
2991
2992 * insdel.c (make_gap_larger): Remove limitation of buffer size
2993 to <= INT_MAX.
2994
16a43933
CY
29952011-04-18 Chong Yidong <cyd@stupidchicken.com>
2996
2997 * xdisp.c (lookup_glyphless_char_display)
2998 (produce_glyphless_glyph): Handle cons cell entry in
2999 glyphless-char-display.
3000 (Vglyphless_char_display): Document it.
3001
3002 * term.c (produce_glyphless_glyph): Handle cons cell entry in
3003 glyphless-char-display.
3004
4581706e
CY
30052011-04-17 Chong Yidong <cyd@stupidchicken.com>
3006
3007 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
3008
3009 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
3010
3011 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
3012 definition for no-X builds.
3013
4887c6e2 30142011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 3015
fd35b6f9
PE
3016 Static checks with GCC 4.6.0 and non-default toolkits.
3017
5c1ccb01
PE
3018 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
3019
006c5daa
PE
3020 * process.c (keyboard_bit_set): Define only if SIGIO.
3021 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
3022 (send_process): Repair possible setjmp clobbering.
3023
efc736d3
PE
3024 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
3025
4e2fe2e6
PE
3026 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
3027
f97334a2
PE
3028 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
3029
4e75f29d
PE
3030 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
3031 Define only if needed.
3032
90efadd1
PE
3033 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
3034 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 3035 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 3036
3c647824
PE
3037 * dispextern.h (struct redisplay_interface): Rename param
3038 to avoid shadowing.
e264f262 3039 * termhooks.h (struct terminal): Likewise.
761383f4 3040 * xterm.c (xembed_send_message): Likewise.
3c647824 3041
b58c5c4a
PE
3042 * insdel.c (make_gap_smaller): Define only if
3043 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
3044
cad59032
PE
3045 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
3046 it.
3047
c339dc2e
PE
3048 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
3049 so that we aren't warned about unused symbols.
3050
91a3e27b
PE
3051 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
3052
399c71d3 3053 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 3054
8ffc96f5
PE
3055 * xfns.c (x_real_positions): Mark locals as initialized.
3056
eef9bc79
PE
3057 * xmenu.c (xmenu_show): Don't use uninitialized vars.
3058
098db9dd
PE
3059 * xterm.c: Fix problems found by static analysis with other toolkits.
3060 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
3061 (x_dispatch_event): Declare static if USE_GTK, and
3062 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 3063 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 3064 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
3065 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
3066 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 3067
eb18f6cc
PE
3068 * xmenu.c (menu_help_callback): Pointer type fixes.
3069 Use const pointers when pointing at readonly data. Avoid pointer
3070 signedness clashes.
3071 (FALSE): Remove unused macro.
3072 (update_frame_menubar): Remove unused decl.
3073
1fe72bf8
PE
3074 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
3075
60d9e1db
PE
3076 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
3077 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
3078 (single_menu_item): Rename local to avoid shadowing.
3079
39261c26
PE
3080 * keyboard.c (make_lispy_event): Remove unused local var.
3081
018c5e19
PE
3082 * frame.c, frame.h (x_get_resource_string): Bring this back, but
3083 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
3084
63d2b86e
PE
3085 * bitmaps: Change bitmaps from unsigned char back to the X11
3086 compatible char. Avoid the old compiler warnings about
3087 out-of-range initializers by using, for example, '\xab' rather
3088 than 0xab.
3089
aefd87e1
PE
3090 * xgselect.c (xgselect_initialize): Check vs interface
3091 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
3092
bf501fb9
PE
3093 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
3094
e9829fdf
PE
3095 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
3096 to read-only memory.
3097
1086c095
PE
3098 * fns.c (vector): Remove; this old hack is no longer needed.
3099
2baccd04 3100 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 3101 Remove unused var.
dde42981 3102 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 3103
72391843 3104 * xrdb.c (x_load_resources): Omit unused local.
3565b346 3105
436c16df 3106 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 3107 (x_window): Rename locals to avoid shadowing.
dc5ddd85 3108 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 3109
92bb796d 3110 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 3111 (x_term_init): Remove local to avoid shadowing.
92bb796d 3112
764430a3 3113 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
3114
3115 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
3116 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
3117
d1dfb56c
EZ
31182011-04-16 Eli Zaretskii <eliz@gnu.org>
3119
c4354cb4
EZ
3120 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
3121
d1dfb56c
EZ
3122 Fix regex.c, syntax.c and friends for buffers > 2GB.
3123 * syntax.h (struct gl_state_s): Declare character position members
3124 EMACS_INT.
3125
3126 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
3127
04f2d78b
CB
3128 * textprop.c (verify_interval_modification, interval_of):
3129 Declare arguments EMACS_INT.
d1dfb56c
EZ
3130
3131 * intervals.c (adjust_intervals_for_insertion): Declare arguments
3132 EMACS_INT.
3133
3134 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
3135
3136 * indent.c (Fvertical_motion): Local variable it_start is now
3137 EMACS_INT.
3138
3139 * regex.c (re_match, re_match_2, re_match_2_internal)
3140 (bcmp_translate, regcomp, regexec, print_double_string)
3141 (group_in_compile_stack, re_search, re_search_2, regex_compile)
3142 (re_compile_pattern, re_exec): Declare arguments and local
3143 variables `size_t' and `ssize_t' and return values `regoff_t', as
3144 appropriate.
3145 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
3146 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
3147 <compile_stack_type>: `size' and `avail' are now `size_t'.
3148
3149 * regex.h <regoff_t>: Use ssize_t, not int.
3150 (re_search, re_search_2, re_match, re_match_2): Arguments that
3151 specify buffer/string position and length are now ssize_t and
3152 size_t. Return type is regoff_t.
3153
613052cd
BK
31542011-04-16 Ben Key <bkey76@gmail.com>
3155
3156 * nsfont.m: Fixed bugs in ns_get_family and
3157 ns_descriptor_to_entity that were caused by using free to
3158 deallocate memory blocks that were allocated by xmalloc (via
3159 xstrdup). This caused Emacs to crash when compiled with
3160 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
3161 --enable-checking=xmallocoverrun). xfree is now used to
3162 deallocate these memory blocks.
3163
4170f62f 31642011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 3165
71b41406
PE
3166 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
3167
9587a89d
PE
3168 emacs_write: Accept and return EMACS_INT for sizes.
3169 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
3170 et seq.
3171 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
3172 Accept and return EMACS_INT.
3173 (emacs_gnutls_write): Return the number of bytes written on
3174 partial writes.
3175 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
3176 (emacs_read, emacs_write): Remove check for negative size, as the
3177 Emacs source code has been audited now.
9587a89d
PE
3178 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
3179 (emacs_read, emacs_write): Use it.
273a5f82
PE
3180 * process.c (send_process): Adjust to the new signatures of
3181 emacs_write and emacs_gnutls_write. Do not attempt to store
3182 a byte offset into an 'int'; it might overflow.
9587a89d 3183 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 3184
3e047f51
PE
3185 * sound.c: Don't assume sizes fit in 'int'.
3186 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 3187 Return EMACS_INT, not int.
3e047f51 3188 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
3189 Accept EMACS_INT, not int.
3190 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
3191 record read return values.
3192
cc39a9db
BK
31932011-04-15 Ben Key <bkey76@gmail.com>
3194
c9d0ec6d
JB
3195 * keyboard.c (Qundefined): Don't declare static since it is used
3196 in nsfns.m.
3197 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
3198 static since they are used in nsfont.m.
cc39a9db 3199
6c60eb9f
SM
32002011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
3201
3202 * process.c (Qprocessp): Don't declare static.
3203 * lisp.h (Qprocessp): Declare again.
3204
7990b61a
JB
32052011-04-15 Juanma Barranquero <lekktu@gmail.com>
3206
3207 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
3208
5d4cb038
PE
32092011-04-14 Paul Eggert <eggert@cs.ucla.edu>
3210
8bd7b830 3211 Improve C-level modularity by making more things 'static'.
cd64ea1d 3212
e3b27b31
PE
3213 Don't publish debugger-only interfaces to other modules.
3214 * lisp.h (safe_debug_print, debug_output_compilation_hack):
3215 (verify_bytepos, count_markers): Move decls to the only modules
3216 that need them.
3217 * region-cache.h (pp_cache): Likewise.
3218 * window.h (check_all_windows): Likewise.
3219 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
3220
5d4cb038
PE
3221 * sysdep.c (croak): Now static, if
3222 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
3223 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
3224
3225 * alloc.c (refill_memory_reserve): Now static if
3226 !defined REL_ALLOC || defined SYSTEM_MALLOC.
3227 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 3228
e87b6180
PE
3229 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
3230 Define only if USE_LUCID.
3231
ac64929e
PE
3232 * xrdb.c (x_customization_string, x_rm_string): Now static.
3233
6f37259d
PE
3234 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
3235 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
3236
1683e3ab
PE
3237 * xdisp.c (draw_row_with_mouse_face): Now static.
3238 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
3239
de9c2632
PE
3240 * window.h (check_all_windows): Mark externally visible.
3241
2b96acb7
PE
3242 * window.c (window_deletion_count): Now static.
3243
3244 * undo.c: Make symbols static if they're not exported.
3245 (last_undo_buffer, last_boundary_position, pending_boundary):
3246 Now static.
3247
50436f33
PE
3248 * textprop.c (interval_insert_behind_hooks): Now static.
3249 (interval_insert_in_front_hooks): Likewise.
3250
64520e5c
PE
3251 * term.c: Make symbols static if they're not exported.
3252 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
3253 (max_frame_lines, tty_set_terminal_modes):
3254 (tty_reset_terminal_modes, tty_turn_off_highlight):
3255 (get_tty_terminal): Now static.
3256 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
3257 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 3258 HAVE_WINDOW_SYSTEM.
64520e5c
PE
3259 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
3260 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
3261
1fa53021
PE
3262 * sysdep.c: Make symbols static if they're not exported.
3263 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
3264 Now static.
3265 (sigprocmask_set, full_mask): Remove; unused.
3266 (wait_debugging): Mark as visible.
3267 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
3268 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
3269
d4b43b22
PE
3270 * syntax.c (syntax_temp): Define only if !__GNUC__.
3271
b7c513d0
PE
3272 * sound.c (current_sound_device, current_sound): Now static.
3273
989b29ad
PE
3274 * search.c (searchbufs, searchbuf_head): Now static.
3275
13a55a78
PE
3276 * scroll.c (scroll_cost): Remove; unused.
3277 * dispextern.h (scroll_cost): Remove decl.
3278
de68a1fc
PE
3279 * region-cache.h (pp_cache): Mark as externally visible.
3280
40ccffa6
PE
3281 * process.c: Make symbols static if they're not exported.
3282 (process_tick, update_tick, create_process, chan_process):
3283 (Vprocess_alist, proc_buffered_char, datagram_access):
3284 (fd_callback_data, send_process_frame, process_sent_to): Now static.
3285 (deactivate_process): Mark defn as static, as well as decl.
3286 * lisp.h (create_process): Remove decl.
3287 * process.h (chan_process, Vprocess_alist): Remove decls.
3288
ad64fc97
PE
3289 * print.c: Make symbols static if they're not exported.
3290 (print_depth, new_backquote_output, being_printed, print_buffer):
3291 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
3292 (print_interval, print_number_index, initial_stderr_stream):
3293 Now static.
3294 * lisp.h (Fprinc): Remove decl.
3295 (debug_output_compilation_hack): Mark as externally visible.
3296
adddb265
PE
3297 * sysdep.c (croak): Move decl from here to syssignal.h.
3298 * syssignal.h (croak): Put it here, so the API can be checked when
3299 'croak' is called from dissociate_if_controlling_tty.
3300
1717ede2
PE
3301 * minibuf.c: Make symbols static if they're not exported.
3302 (minibuf_save_list, choose_minibuf_frame): Now static.
3303 * lisp.h (choose_minibuf_frame): Remove decl.
3304
fa5fb2bc
PE
3305 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
3306
1e3890d1
PE
3307 * lread.c: Make symbols static if they're not exported.
3308 (read_objects, initial_obarray, oblookup_last_bucket_number):
3309 Now static.
3310 (make_symbol): Remove; unused.
3311 * lisp.h (initial_obarray, make_symbol): Remove decls.
3312
8a1414fa
PE
3313 * keyboard.c: Make symbols static if they're not exported.
3314 (single_kboard, recent_keys_index, total_keys, recent_keys):
3315 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
3316 (this_single_command_key_start, echoing, last_auto_save):
3317 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
3318 (command_loop, echo_now, keyboard_init_hook, help_char_p):
3319 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
3320 (Vlispy_mouse_stem, double_click_count):
3321 Now static.
3322 (force_auto_save_soon): Define only if SIGDANGER.
3323 (ignore_mouse_drag_p): Now static if
3324 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
3325 (print_help): Remove; unused.
3326 (stop_character, last_timer_event): Mark as externally visible.
3327 * keyboard.h (ignore_mouse_drag_p): Declare only if
3328 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
3329 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
3330 * lisp.h (echoing): Remove decl.
3331 (force_auto_save_soon): Declare only if SIGDANGER.
3332 * xdisp.c (redisplay_window): Simplify code, to make it more
3333 obvious that ignore_mouse_drag_p is not accessed if !defined
3334 USE_GTK && !defined HAVE_NS.
3335
93ea6e8f
PE
3336 * intervals.c: Make symbols static if they're not exported.
3337 (merge_properties_sticky, merge_interval_right, delete_interval):
3338 Now static.
3339 * intervals.h (merge_interval_right, delete_interval): Remove decls.
3340
77382fcc
PE
3341 * insdel.c: Make symbols static if they're not exported.
3342 However, leave prepare_to_modify_buffer alone. It's never
3343 called from outside this function, but that appears to be a bug.
3344 (combine_after_change_list, combine_after_change_buffer):
4889fc82 3345 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
3346 (adjust_after_replace_noundo): Remove; unused.
3347 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 3348 (signal_before_change): Remove decls.
77382fcc 3349
9306c32e
PE
3350 * indent.c (val_compute_motion, val_vmotion): Now static.
3351
cd44d2eb
PE
3352 * image.c: Make symbols static if they're not exported.
3353 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
3354 if USE_GTK.
3355 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
3356 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
3357
ad9a7a06
PE
3358 * fringe.c (standard_bitmaps): Now static.
3359 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
3360
81626931
PE
3361 * frame.c: Make symbols static if they're not exported.
3362 (x_report_frame_params, make_terminal_frame): Now static.
3363 (get_frame_param): Now static, unless HAVE_NS.
3364 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
3365 (x_get_resource_string): Remove; not used.
3366 * frame.h (make_terminal_frame, x_report_frame_params):
3367 (x_get_resource_string); Remove decls.
3368 (x_fullscreen_adjust): Declare only if WINDOWSNT.
3369 * lisp.h (get_frame_param): Declare only if HAVE_NS.
3370
239f9db9
PE
3371 * font.c, fontset.c: Make symbols static if they're not exported.
3372 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
3373 (FACE_SUITABLE_FOR_CHAR_P): Use it.
3374 * font.c (font_close_object): Now static.
3375 * font.h (font_close_object): Remove.
3376 * fontset.c (FONTSET_OBJLIST): Remove.
3377 (free_realized_fontset) #if-0 the body, which does nothing.
3378 (face_suitable_for_char_p): #if-0, as it's never called.
3379 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
3380 * xfaces.c (face_at_string_position):
3381 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
3382 since 0 is always ASCII.
3383
dfcf3579
PE
3384 * fns.c (weak_hash_tables): Now static.
3385
5045092b
PE
3386 * fileio.c: Make symbols static if they're not exported.
3387 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
3388 (Vwrite_region_annotation_buffers): Now static.
3389
57a96f5c
PE
3390 * eval.c: Make symbols static if they're not exported.
3391 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
3392 * lisp.h (backtrace_list): Remove decl.
3393
35f08c38
PE
3394 * emacs.c: Make symbols static if they're not exported.
3395 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
3396 (fatal_error_code, fatal_error_signal_hook, standard_args):
3397 Now static.
3398 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
3399 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
3400 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
3401 * lisp.h (fatal_error_signal_hook): Remove decl.
3402 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
3403
f44bd759
PE
3404 * editfns.c: Move a (normally-unused) function to its only use.
3405 * editfns.c, lisp.h (get_operating_system_release): Remove.
3406 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
3407 worth the hassle of breaking this out.
3408
b532497d
PE
3409 * xterm.c: Make symbols static if they're not exported.
3410 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
3411 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
3412 (x_destroy_window, x_delete_display):
3413 Now static.
3414 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
3415 (x_mouse_leave): Remove; unused.
3416 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
3417 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
3418 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
3419 Remove decls.
3420 (x_mouse_leave): Declare only if WINDOWSNT.
3421 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
3422 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
3423 USE_X_TOOLKIT.
3424
1675728f
PE
3425 * ftxfont.c: Make symbols static if they're not exported.
3426 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
3427 HAVE_FREETYPE.
3428 * font.h (ftxfont_driver): Likewise.
3429
e4cebfca
PE
3430 * xfns.c: Make symbols static if they're not exported.
3431 (x_last_font_name, x_display_info_for_name):
3432 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
3433 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
3434 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
3435 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
3436 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
3437 (last_show_tip_args): Now static.
3438 (xic_defaut_fontset, xic_create_fontsetname): Define only if
3439 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
3440 (x_screen_planes): Remove; unused.
3441 * dispextern.h (x_screen_planes): Remove decl.
3442
5bf46f05
PE
3443 * dispnew.c: Make symbols static if they're not exported.
3444 * dispextern.h (redraw_garbaged_frames, scrolling):
3445 (increment_row_positions): Remove.
3446 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
3447 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
3448 Now static.
3449 (redraw_garbaged_frames): Remove; unused.
3450
435f4c28
PE
3451 * xfaces.c: Make symbols static if they're not exported.
3452 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
3453 Remove decls.
3454 * xterm.h (defined_color): Remove decls.
3455 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
3456 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
3457 (menu_face_changed_default, defined_color, free_realized_face):
3458 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
3459 (ascii_face_of_lisp_face): Remove; unused.
3460
8524aef3
PE
3461 * xdisp.c: Make symbols static if they're not exported.
3462 * dispextern.h (scratch_glyph_row, window_box_edges):
3463 (glyph_to_pixel_coords, set_cursor_from_row):
3464 (get_next_display_element, set_iterator_to_next):
3465 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
3466 (show_mouse_face): Remove decls
3467 * frame.h (message_buf_print): Likewise.
3468 * lisp.h (pop_message, set_message, check_point_in_composition):
3469 Likewise.
3470 * xterm.h (set_vertical_scroll_bar): Likewise.
3471 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
3472 (message_buf_print, scratch_glyph_row, displayed_buffer):
3473 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
3474 (get_next_display_element, show_mouse_face, window_box_edges):
3475 (frame_to_window_pixel_xy, check_point_in_composition):
3476 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
3477 (glyph_to_pixel_coords): Remove; unused.
3478
16390cd2
PE
3479 * dired.c (file_name_completion): Now static.
3480
3481 * dbusbind.c (xd_in_read_queued_messages): Now static.
3482
a25f4dfa
PE
3483 * lisp.h (circular_list_error, FOREACH): Remove; unused.
3484 * data.c (circular_list_error): Remove.
3485
14a9c8df
PE
3486 * commands.h (last_point_position, last_point_position_buffer):
3487 (last_point_position_window): Remove decls.
3488 * keyboard.c: Make these variables static.
3489
04f2d78b
CB
3490 * coding.h (coding, code_convert_region, encode_coding_gap):
3491 Remove decls.
74ab6df5
PE
3492 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
3493 (iso_code_class, detect_coding, code_convert_region): Now static.
3494 (encode_coding_gap): Remove; unused.
3495
38dfbee1
PE
3496 * chartab.c (chartab_chars, chartab_bits): Now static.
3497
a2cb4e63
PE
3498 * charset.h (charset_iso_8859_1): Remove decl.
3499 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
3500 Now static.
3501
127198fd
PE
3502 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
3503 * ccl.c (Vccl_program_table): Now static.
3504 (check_ccl_update): Remove; unused.
3505
d85b608f
PE
3506 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
3507 * category.h: ... from here.
3508 * category.c (check_category_table, set_category_set): Now static.
3509
31cd66f3
PE
3510 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
3511 * lisp.h: Remove these decls.
3512
c358e587
PE
3513 * buffer.c (buffer_count): Remove unused var.
3514
e78aecca
PE
3515 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
3516 so that it's not optimized away.
3517 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
3518 * dispextern.h (bidi_dump_cached_states): Remove, since it's
3519 exported only to the debugger.
3520
e192d7d3 3521 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 3522 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 3523
92470028
PE
3524 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
3525 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
3526 was inaccessible from Lisp.
3527 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
3528 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
3529
244ed907
PE
3530 alloc.c: Import and export fewer symbols, and remove unused items.
3531 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
3532 is defined.
3533 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
3534 it's not optimized away by whole-program optimization.
3535 (message_enable_multibyte, free_misc): Remove.
3536 (catchlist, handlerlist, mark_backtrace):
3537 Declare only if BYTE_MARK_STACK.
3538 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
3539 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
3540 (message_enable_multibyte): Remove decl.
3541 (free_misc, interval_free_list, float_block, float_block_index):
3542 (n_float_blocks, float_free_list, cons_block, cons_block_index):
3543 (cons_free_list, last_marked_index):
3544 Now static.
3545 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
3546 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
3547 (mark_backtrace): Define only if BYTE_MARK_STACK.
3548 * xdisp.c (message_enable_multibyte): Now static.
3549
61c2b50e 3550 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
3551 This makes it easier for human readers (and static analyzers)
3552 to see whether these variables are used from other modules.
3553 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
3554 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
3555 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
3556 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
3557 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
3558 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
3559 * xmenu.c, xselect.c:
3560 Declare Q* vars static if they are not used in other modules.
3561 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
3562 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
3563 Remove decls of unexported vars.
3564 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
3565
95c82688
PE
3566 * lisp.h (DEFINE_FUNC): Make sname 'static'.
3567
16a97296
PE
3568 Make Emacs functions such as Fatom 'static' by default.
3569 This makes it easier for human readers (and static analyzers)
3570 to see whether these functions can be called from other modules.
3571 DEFUN now defines a static function. To make the function external
3572 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
3573 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
3574 (Finit_image_library):
16a97296
PE
3575 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
3576 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
3577 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
3578 Remove decls, since these functions are now static.
3579 (Funintern, Fget_internal_run_time): New decls, since these functions
3580 were already external.
95c82688 3581
16a97296
PE
3582 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
3583 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
3584 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
3585 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
3586 * keyboard.c, keymap.c, lread.c:
3587 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
3588 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
3589 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
3590 Mark functions with DEFUE instead of DEFUN,
3591 if they are used in other modules.
3592 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
3593 decls for now-static functions.
3594 * buffer.h (Fdelete_overlay): Remove decl.
3595 * callproc.c (Fgetenv_internal): Mark as internal.
3596 * composite.c (Fremove_list_of_text_properties): Remove decl.
3597 (Fcomposition_get_gstring): New forward static decl.
3598 * composite.h (Fcomposite_get_gstring): Remove decl.
3599 * dired.c (Ffile_attributes): New forward static decl.
3600 * doc.c (Fdocumntation_property): New forward static decl.
3601 * eval.c (Ffetch_bytecode): New forward static decl.
3602 (Funintern): Remove extern decl; now in .h file where it belongs.
3603 * fileio.c (Fmake_symbolic_link): New forward static decl.
3604 * image.c (Finit_image_library): New forward static decl.
3605 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
3606 * intervals.h (Fprevious_property_change):
3607 (Fremove_list_of_text_properties): Remove decls.
3608 * keyboard.c (Fthis_command_keys): Remove decl.
3609 (Fcommand_execute): New forward static decl.
3610 * keymap.c (Flookup_key): New forward static decl.
3611 (Fcopy_keymap): Now static.
3612 * keymap.h (Flookup_key): Remove decl.
3613 * process.c (Fget_process): New forward static decl.
3614 (Fprocess_datagram_address): Mark as internal.
3615 * syntax.c (Fsyntax_table_p): New forward static decl.
3616 (skip_chars): Remove duplicate decl.
3617 * textprop.c (Fprevious_property_change): New forward static decl.
3618 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
3619 Now internal.
3620 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
3621 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
3622
785bbd42
PE
3623 * editfns.c (Fformat): Remove unreachable code.
3624
8b913b57
AS
36252011-04-14 Andreas Schwab <schwab@linux-m68k.org>
3626
3627 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
3628 change. (Bug#8496)
3629
a6744a35
EZ
36302011-04-13 Eli Zaretskii <eliz@gnu.org>
3631
3632 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
3633 when at ZV. (Bug#8487)
3634
e7974947
AS
36352011-04-12 Andreas Schwab <schwab@linux-m68k.org>
3636
baad03f0
AS
3637 * charset.c (Fclear_charset_maps): Use xfree instead of free.
3638 (Bug#8437)
3639 * keyboard.c (parse_tool_bar_item): Likewise.
3640 * sound.c (sound_cleanup, alsa_close): Likewise.
3641 * termcap.c (tgetent): Likewise.
3642 * xfns.c (x_default_font_parameter): Likewise.
3643 * xsettings.c (read_and_apply_settings): Likewise.
3644
e7974947
AS
3645 * alloc.c (overrun_check_malloc, overrun_check_realloc)
3646 (overrun_check_free): Protoize.
3647
28272684
PE
36482011-04-12 Paul Eggert <eggert@cs.ucla.edu>
3649
3650 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
3651 since callers should never pass a negative size.
3652 Change the signature to match that of plain 'read' and 'write'; see
3653 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
3654 * lisp.h: Update prototypes of emacs_write and emacs_read.
3655
11997c76
EZ
36562011-04-11 Eli Zaretskii <eliz@gnu.org>
3657
3658 * xdisp.c (redisplay_window): Don't try to determine the character
3659 position of the scroll margin if the window start point w->startp
e896f03c 3660 is outside the buffer's accessible region. (Bug#8468)
11997c76 3661
8a2cbd72
EZ
36622011-04-10 Eli Zaretskii <eliz@gnu.org>
3663
3664 Fix write-region and its subroutines for buffers > 2GB.
3665 * fileio.c (a_write, e_write): Modify declaration of arguments and
3666 local variables to support buffers larger than 2GB.
3667 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
3668
3669 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
3670 argument, local variables, and return value.
3671
3672 * lisp.h: Update prototypes of emacs_write and emacs_read.
3673
3674 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
3675
4073e537 36762011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 3677
1ebfdcb6
PE
3678 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
3679
b2ded58d
PE
3680 Fix more problems found by GCC 4.6.0's static checks.
3681
7d66342c
PE
3682 * xdisp.c (vmessage): Use a better test for character truncation.
3683
bbf47d44
PE
3684 * charset.c (load_charset_map): <, not <=, for optimization,
3685 and to avoid potential problems with integer overflow.
9248994d 3686 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 3687 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 3688 * editfns.c (Fformat): Likewise.
1e69125e 3689 * syntax.c (skip_chars): Likewise.
3befa583 3690
e3019616
PE
3691 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
3692 This also lets GCC 4.6.0 generate slightly better loop code.
3693
becfa255
PE
3694 * callint.c (Fcall_interactively): <, not <=, for optimization.
3695 (Fcall_interactively): Count the number of arguments produced,
3696 not the number of arguments given. This is simpler and lets GCC
3697 4.6.0 generate slightly better code.
3698
dae0cd48
PE
3699 * ftfont.c: Distingish more carefully between FcChar8 and char.
3700 The previous code passed unsigned char * to a functions like
3701 strlen and xstrcasecmp that expect char *, which does not
3702 conform to the C standard.
3703 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
3704 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
3705 char * when the C standard requires it.
3706
76032d70
PE
3707 * keyboard.c (read_char): Remove unused var.
3708
eb3f1cc8
PE
3709 * eval.c: Port to Windows vsnprintf (Bug#8435).
3710 Include <limits.h>.
3711 (SIZE_MAX): Define if the headers do not.
3712 (verror): Do not give up if vsnprintf returns a negative count.
3713 Instead, grow the buffer. This ports to Windows vsnprintf, which
3714 does not conform to C99. Problem reported by Eli Zaretskii.
3715 Also, simplify the allocation scheme, by avoiding the need for
3716 calling realloc, and removing the ALLOCATED variable.
3717
70476b54
PE
3718 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
3719
12020a9e
PE
3720 Remove invocations of doprnt, as Emacs now uses vsnprintf.
3721 But keep the doprint source code for now, as we might revamp it
3722 and use it again (Bug#8435).
ea6c7ae6
PE
3723 * lisp.h (doprnt): Remove.
3724 * Makefile.in (base_obj): Remove doprnt.o.
3725 * deps.mk (doprnt.o): Remove.
3726
5fdb398c
PE
3727 error: Print 32- and 64-bit integers portably (Bug#8435).
3728 Without this change, on typical 64-bit hosts error ("...%d...", N)
3729 was used to print both 32- and 64-bit integers N, which relied on
3730 undefined behavior.
3731 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
3732 New macro.
3733 * lisp.h (error, verror): Mark as printf-like functions.
3734 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
3735 Report overflow in size calculations when allocating printf buffer.
3736 Do not truncate output string at its first null byte.
3737 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
3738 Truncate the output at a character boundary, since vsnprintf does not
3739 do that.
3740 * charset.c (check_iso_charset_parameter): Convert internal
3741 character to string before calling 'error', since %c now has the
3742 printf meaning.
3743 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
3744 overflow when computing char to be passed to 'error'. Do not
3745 pass Lisp_Object to 'error'; pass the integer instead.
3746 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
3747 formatted with plain %d.
3748
b189fa66
PE
3749 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
3750
bff87ef0
PE
3751 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
3752
7e2cac20
PE
3753 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
3754
ce4d90b5
PE
3755 * xterm.c (x_catch_errors): Remove duplicate declaration.
3756
266c9547
PE
3757 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
3758
79c49ad2
PE
3759 * xdisp.c, lisp.h (message_nolog): Remove; unused.
3760
368f4090
JM
37612011-04-10 Jim Meyering <meyering@redhat.com>
3762
3763 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
3764 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
3765 return ssize_t not "int", and use size_t as the buffer length.
3766 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
3767 * gnutls.h: Update declarations.
3768 * process.c (read_process_output): Use ssize_t, to match.
3769 (send_process): Likewise.
3770
a32d4040
CY
37712011-04-09 Chong Yidong <cyd@stupidchicken.com>
3772
3773 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
3774
8546720e 37752011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 3776
04f2d78b
CB
3777 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
3778 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 3779
8546720e
GM
3780 * xterm.c (handle_one_xevent):
3781 * xmenu.c (create_and_show_popup_menu):
3782 * xselect.c (x_decline_selection_request)
3783 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 3784
0a2f5c1a 37852011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
3786
3787 Fix some uses of `int' instead of EMACS_INT.
3788 * search.c (string_match_1, fast_string_match)
3789 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
3790 (scan_buffer, find_next_newline_no_quit)
3791 (find_before_next_newline, search_command, Freplace_match)
3792 (Fmatch_data): Make some `int' variables be EMACS_INT.
3793
3794 * xdisp.c (display_count_lines): 3rd argument and return value now
3795 EMACS_INT. All callers changed.
3796 (pint2hrstr): Last argument is now EMACS_INT.
3797
3798 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
3799 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3800 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
3801 (decode_coding_utf_16, decode_coding_emacs_mule)
3802 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
3803 (decode_coding_ccl, decode_coding_charset)
3804 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
3805 (decode_coding_iso_2022, decode_coding_emacs_mule)
3806 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
3807 <char_offset, last_offset>: Declare EMACS_INT.
3808 (encode_coding_utf_8, encode_coding_utf_16)
3809 (encode_coding_emacs_mule, encode_invocation_designation)
3810 (encode_designation_at_bol, encode_coding_iso_2022)
3811 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
3812 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
3813 Declare EMACS_INT.
3814 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
3815 (encode_invocation_designation): Last argument P_NCHARS is now
3816 EMACS_INT.
3817 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
3818 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
3819
3820 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
3821 All users changed.
3822
3823 * ccl.c (Fccl_execute_on_string): Declare some variables
3824 EMACS_INT.
3825
8546720e 38262011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
3827
3828 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
3829
4e19a977
CS
38302011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
3831
3832 * process.c (Fformat_network_address): Doc fix.
3833
87302331
R
38342011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
3835
3836 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
3837
cbb59342
CY
38382011-04-08 Chong Yidong <cyd@stupidchicken.com>
3839
3840 * keyboard.c (read_char): Call Lisp function help-form-show,
3841 instead of using internal_with_output_to_temp_buffer.
3842 (Qhelp_form_show): New var.
e0d38eeb 3843 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
3844
3845 * print.c (internal_with_output_to_temp_buffer): Function deleted.
3846
3847 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
3848
e67a13ab
CY
38492011-04-06 Chong Yidong <cyd@stupidchicken.com>
3850
04f2d78b
CB
3851 * process.c (Flist_processes): Remove to Lisp.
3852 (list_processes_1): Delete.
e67a13ab 3853
973f782d
EZ
38542011-04-06 Eli Zaretskii <eliz@gnu.org>
3855
7c106b1e
EZ
3856 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
3857
973f782d
EZ
3858 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
3859
41cf7d1a 38602011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 3861
ca23cc88
PE
3862 Fix more problems found by GCC 4.6.0's static checks.
3863
f390e2d5
PE
3864 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
3865
42eea0d0
PE
3866 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
3867
b69769da 3868 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 3869
f9541e84
PE
3870 * xdisp.c (vmessage): Mark as a printf-like function.
3871
13841b55
PE
3872 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
3873
c136c10f
PE
3874 * sound.c (sound_warning): Don't crash if arg contains a printf format.
3875
5e2d4a30
PE
3876 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
3877 printf-like functions.
3878 (tiff_load): Add casts to remove these marks before passing them
3879 to system-supplied API.
3880
583f48b9
PE
3881 * eval.c (Fsignal): Remove excess argument to 'fatal'.
3882
b25d760e
PE
3883 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
3884 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
3885 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
3886 directly, rather than having caller test rule sign. This avoids
3887 some unnecessary tests.
3888 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
3889 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
3890 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 3891
bc7b6697 3892 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 3893 (xfont_open): Avoid unnecessary tests.
bc7b6697 3894
27ccc379
PE
3895 * composite.c (composition_gstring_put_cache): Use unsigned integer.
3896
dcd5c89a
PE
3897 * composite.h, composite.c (composition_gstring_put_cache):
3898 Use EMACS_INT, not int, for length.
3899
b13a45c6
PE
3900 * composite.h (COMPOSITION_DECODE_REFS): New macro,
3901 breaking out part of COMPOSITION_DECODE_RULE.
3902 (COMPOSITION_DECODE_RULE): Use it.
3903 * composite.c (get_composition_id): Remove unused local vars,
3904 by using the new macro.
3905
1e792e4d
PE
3906 * textprop.c (set_text_properties_1): Change while to do-while,
3907 since the condition is always true at first.
3908
dc6c6455 3909 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
3910 (interval_deletion_adjustment): Return unsigned value.
3911 All uses changed.
dc6c6455 3912
aba7731a
PE
3913 * process.c (list_processes_1, create_pty, read_process_output):
3914 (exec_sentinel): Remove vars that were set but not used.
afd4052b 3915 (create_pty): Remove unnecessary "volatile"s.
bc57d757 3916 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 3917 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 3918 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 3919
fdfc4bf3
PE
3920 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
3921
fca8fe46 3922 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 3923 (update_syntax_table): Use unsigned instead of int.
fca8fe46 3924
06a0259a 3925 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 3926 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 3927 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 3928
e7b9e80f
PE
3929 * print.c (print_error_message): Avoid int overflow.
3930
56201685
PE
3931 * font.c (font_list_entities): Redo for clarity,
3932 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
3933
78834453 3934 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 3935 (font_score): Avoid potential overflow in diff calculation.
78834453 3936
0bc0b309 3937 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 3938 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 3939
e610eaca
PE
3940 * eval.c (funcall_lambda): Rename local to avoid shadowing.
3941
b895abce
PE
3942 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
3943 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
3944 can always succeed if overflow has undefined behavior.
3945
1f1d9321 3946 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 3947 (wordify): Omit three unnecessary tests.
1f1d9321 3948
c59478bc
PE
3949 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
3950 All callers changed. This avoids the need for an unused var.
3951
79b73827
PE
3952 * casefiddle.c (casify_region): Remove var that is set but not used.
3953
a4db5dfe
PE
3954 * dired.c (file_name_completion): Remove var that is set but not used.
3955
43aae36e
PE
3956 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
3957
2a47c44d 3958 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 3959 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 3960
a37c69bf
PE
3961 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
3962 Check for integer overflow on size calculations.
3963
328ab8e7
PE
3964 * buffer.c (Fprevious_overlay_change): Remove var that is set
3965 but not used.
3966
e5a2a5cb
PE
3967 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
3968 Remove vars that are set but not used.
8d84a6eb 3969 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 3970 (timer_check_2): Mark vars as initialized.
e5a2a5cb 3971
a60e5f68
PE
3972 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
3973
f661cb61 3974 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 3975 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 3976
f0397f5a
PE
3977 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
3978 that are set but not used.
3979
8664db06 3980 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 3981 if XCreateBitmapFromData fails (Bug#8410).
8664db06 3982
6abdaa4a
PE
3983 * xselect.c (x_get_local_selection, x_handle_property_notify):
3984 Remove vars that are set but not used.
3985
0ce7538d 3986 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 3987 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 3988
9ae848fc
PE
3989 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
3990 Remove var that is set but not used.
0b918413
PE
3991 (scroll_bar_windows_size): Now size_t, not int.
3992 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
3993 Check for overflow.
9ae848fc 3994
a5a62657
PE
3995 * xfaces.c (realize_named_face): Remove vars that are set but not used.
3996 (map_tty_color) [!defined MSDOS]: Likewise.
3997
5c5cdd39
PE
3998 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
3999
66ebf983
PE
4000 * coding.c: Remove vars that are set but not used.
4001 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
4002 All callers changed.
4003 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
4004 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
4005 (decode_coding_charset): Remove vars that are set but not used.
4006
1be4d761
PE
4007 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
4008 that is set but not used.
4009
47553fa8
PE
4010 * print.c (print_object): Remove var that is set but not used.
4011
1f7196bf 4012 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
4013 The gnulib version avoids calling malloc in the usual case,
4014 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
4015 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
4016 * filelock.c (current_lock_owner): Likewise.
4017 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
4018 * sysdep.c: Include allocator.h, careadlinkat.h.
4019 (emacs_no_realloc_allocator): New static constant.
4020 (emacs_readlink): New function.
fdb61804
PE
4021 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
4022 ../lib/careadlinkat.h.
d1fdcab7 4023
f84c17c7
SM
40242011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
4025
4026 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
4027 first non-nil return value).
4028
ef3862ad
JD
40292011-04-03 Jan Djärv <jan.h.d@swipnet.se>
4030
4031 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
4032 if not defined (Bug#8403).
4033
376a7006
JB
40342011-04-02 Juanma Barranquero <lekktu@gmail.com>
4035
4036 * xdisp.c (display_count_lines): Remove parameter `start',
4037 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4038 (get_char_face_and_encoding): Remove parameter `multibyte_p',
4039 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4040 (fill_stretch_glyph_string): Remove parameters `row' and `area',
4041 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
4042 and thereabouts. All callers changed.
4043 (get_per_char_metric): Remove parameter `f', unused since
4044 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
4045
6ca3801d
JM
40462011-04-02 Jim Meyering <meyering@redhat.com>
4047
4048 do not dereference NULL upon failed strdup
4049 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
4050 (ns_get_family): Likewise.
4051
d8e2b5ba
JB
40522011-04-02 Juanma Barranquero <lekktu@gmail.com>
4053
4054 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
4055
8c74fcbd
JD
40562011-04-02 Jan Djärv <jan.h.d@swipnet.se>
4057
4058 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
4059 later (Bug#8403).
4060
7200d79c
SM
40612011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
4062
03408648 4063 Add lexical binding.
7200d79c 4064
03408648
SM
4065 * window.c (Ftemp_output_buffer_show): New fun.
4066 (Fsave_window_excursion):
4067 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
4068
4069 * lread.c (lisp_file_lexically_bound_p): New function.
4070 (Fload): Bind Qlexical_binding.
4071 (readevalloop): Remove `evalfun' arg.
4072 Bind Qinternal_interpreter_environment.
4073 (Feval_buffer): Bind Qlexical_binding.
4074 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
4075 Mark as dynamic.
4076 (syms_of_lread): Declare `lexical-binding'.
4077
4078 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
4079
4080 * keyboard.c (eval_dyn): New fun.
4081 (menu_item_eval_property): Use it.
ca105506
SM
4082
4083 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 4084
03408648
SM
4085 * fns.c (concat, mapcar1): Accept byte-code-functions.
4086
4087 * eval.c (Fsetq): Handle lexical vars.
4088 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
4089 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
4090 (FletX, Flet): Obey lexical binding.
4091 (Fcommandp): Handle closures.
4092 (Feval): New `lexical' arg.
4093 (eval_sub): New function extracted from Feval. Use it almost
4094 everywhere where Feval was used. Look up vars in lexical env.
4095 Handle closures.
4096 (Ffunctionp): Move from subr.el.
4097 (Ffuncall): Handle closures.
4098 (apply_lambda): Remove `eval_flags'.
4099 (funcall_lambda): Handle closures and new byte-code-functions.
4100 (Fspecial_variable_p): New function.
4101 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
4102 but without exporting it to Lisp.
23aba0ea 4103
23aba0ea 4104 * doc.c (Fdocumentation, store_function_docstring):
03408648 4105 * data.c (Finteractive_form): Handle closures.
23aba0ea 4106
03408648
SM
4107 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
4108 interactive spec.
ba83908c 4109
04f2d78b
CB
4110 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
4111 New byte-codes.
03408648
SM
4112 (exec_byte_code): New function extracted from Fbyte_code to handle new
4113 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 4114
03408648 4115 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 4116
03408648 4117 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 4118
e2abce01
JB
41192011-03-31 Juanma Barranquero <lekktu@gmail.com>
4120
4121 * xdisp.c (redisplay_internal): Fix prototype.
4122
63696a73 41232011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 4124
63696a73 4125 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
4126 (try_scrolling): Use it when setting scroll_limit.
4127 Limit scrolling to 100 screen lines.
63696a73
EZ
4128 (redisplay_window): Even when falling back on "recentering",
4129 position point in the window according to scroll-conservatively,
4130 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
4131
4132 (try_scrolling): When point is above the window, allow searching
4133 as far as scroll_max, or one screenful, to compute vertical
4134 distance from PT to the scroll margin position. This prevents
4135 try_scrolling from unnecessarily failing when
4136 scroll-conservatively is set to a value slightly larger than the
4137 window height. Clean up the case of PT below the margin at bottom
4138 of window: scroll_max can no longer be INT_MAX. When aggressive
4139 scrolling is in use, don't let point enter the opposite scroll
4140 margin as result of the scroll.
4141 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
4142 threshold of 100 lines for never-recentering scrolling.
4143
e4cc2dfc
JB
41442011-03-31 Juanma Barranquero <lekktu@gmail.com>
4145
4146 * dispextern.h (move_it_by_lines):
4147 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
4148 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
4149 (message_log_check_duplicate): Remove parameters `prev_bol' and
4150 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
4151 (redisplay_internal): Remove parameter `preserve_echo_area',
4152 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
4153
4154 * indent.c (Fvertical_motion):
4155 * window.c (window_scroll_pixel_based, Frecenter):
4156 Don't pass `need_y_p' to `move_it_by_lines'.
4157
1c470562
SM
41582011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
4159
44f230aa
SM
4160 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
4161 steal a few bits to be more compact.
4162 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
4163 Remove unneeded casts.
4164
1c470562
SM
4165 * bytecode.c (Fbyte_code): CAR and CDR can GC.
4166
888adce9
ZK
41672011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
4168
4169 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
4170 binding" message (bug#7967).
4171
f838ed7b
PE
41722011-03-30 Paul Eggert <eggert@cs.ucla.edu>
4173
77861b95
PE
4174 Fix more problems found by GCC 4.6.0's static checks.
4175
de6dbc14
PE
4176 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
4177 Remove unused local var.
4178
f838ed7b
PE
4179 * editfns.c (Fmessage_box): Remove unused local var.
4180
792c7b2b
PE
4181 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
4182 (note_mode_line_or_margin_highlight, note_mouse_highlight):
4183 Omit unused local vars.
c499e557 4184 * window.c (shrink_windows): Omit unused local var.
b01a1c29 4185 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
4186 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
4187 Omit unused local var.
4188
ba0165e1
PE
4189 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
4190 Don't assume string length fits in int.
32ad8845 4191 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 4192 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 4193
3c59b4c9
PE
4194 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
4195 instead of alloca (Bug#8344).
4196
a3eed478 4197 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 4198 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 4199
eb4d412d
PE
4200 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
4201
1658b401
PE
4202 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
4203 concerns.
4204
4205 * term.c (produce_glyphless_glyph): Remove unnecessary test.
4206
4207 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 4208
9a2c6e05
PE
4209 * keyboard.c (syms_of_keyboard): Use the same style as later
4210 in this function when indexing through an array. This also
4211 works around GCC bug 48267.
4212
03d0a109
PE
4213 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
4214
44f730c8
PE
4215 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
4216
fe75f926
PE
4217 * chartab.c (sub_char_table_ref_and_range): Redo for slight
4218 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
4219
ffa8c828
PE
4220 * keyboard.c, keyboard.h (num_input_events): Now size_t.
4221 This avoids undefined behavior on integer overflow, and is a bit
4222 more convenient anyway since it is compared to a size_t variable.
4223
c5101a77
PE
4224 Variadic C functions now count arguments with size_t, not int.
4225 This avoids an unnecessary limitation on 64-bit machines, which
4226 caused (substring ...) to crash on large vectors (Bug#8344).
4227 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
4228 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 4229 All variadic functions and their callers changed accordingly.
c5101a77
PE
4230 (struct gcpro.nvars): Now size_t, not int. All uses changed.
4231 * data.c (arith_driver, float_arith_driver): Likewise.
4232 * editfns.c (general_insert_function): Likewise.
4233 * eval.c (struct backtrace.nargs, interactive_p)
4234 (internal_condition_case_n, run_hook_with_args, apply_lambda)
4235 (funcall_lambda, mark_backtrace): Likewise.
4236 * fns.c (concat): Likewise.
4237 * frame.c (x_set_frame_parameters): Likewise.
4238 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
4239 0 if not found, not -1. All callers changed.
4240
dd3f25f7
PE
4241 * alloc.c (garbage_collect): Don't assume stack size fits in int.
4242 (stack_copy_size): Now size_t, not int.
4243 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
4244
461c2ab9
JB
42452011-03-28 Juanma Barranquero <lekktu@gmail.com>
4246
4247 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
4248 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4249 All callers changed.
4250
4251 * lisp.h (multibyte_char_to_unibyte):
4252 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
4253 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
4254 * character.h (CHAR_TO_BYTE8):
4255 * cmds.c (internal_self_insert):
4256 * editfns.c (general_insert_function):
4257 * keymap.c (push_key_description):
4258 * search.c (Freplace_match):
4259 * xdisp.c (message_dolog, set_message_1): All callers changed.
4260
f6d62986
SM
42612011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4262
4263 * keyboard.c (safe_run_hook_funcall): New function.
4264 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
4265 don't set the hook to nil, but remove the offending function instead.
4266 (Qcommand_hook_internal): Remove, unused.
4267 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
4268 Vcommand_hook_internal.
4269
4270 * eval.c (enum run_hooks_condition): Remove.
4271 (funcall_nil, funcall_not): New functions.
4272 (run_hook_with_args): Call each function through a `funcall' argument.
4273 Remove `cond' argument, now redundant.
4274 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
4275 (Frun_hook_with_args_until_failure): Adjust accordingly.
4276 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
4277
1db5b1ad
JB
42782011-03-28 Juanma Barranquero <lekktu@gmail.com>
4279
4280 * dispextern.h (string_buffer_position): Remove declaration.
4281
4282 * print.c (strout): Remove parameter `multibyte', unused since
4283 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
4284
4285 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
4286 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
4287 All callers changed.
4288
4289 * w32.c (_wsa_errlist): Use braces for struct initializers.
4290
4291 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
4292 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
4293 All callers changed.
4294 (string_buffer_position): Likewise. Also, make static (it's never
4295 used outside xdisp.c).
4296 (cursor_row_p): Remove parameter `w', unused since
4297 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
4298 (decode_mode_spec): Remove parameter `precision', introduced during
4299 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
4300 All callers changed.
4301
5ffb62aa
JD
43022011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4303
4304 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
4305
461c2ab9 43062011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
4307
4308 * nsterm.m (ns_menu_bar_is_hidden): New variable.
4309 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
4310 (ns_update_auto_hide_menu_bar): New functions.
4311 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
4312 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
4313 ns_constrain_all_frames.
4314 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
4315 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
4316
5c380ffb
JD
43172011-03-27 Jan Djärv <jan.h.d@swipnet.se>
4318
4319 * nsmenu.m (runDialogAt): Remove argument to timer_check.
4320
9af30bdf
GM
43212011-03-27 Glenn Morris <rgm@gnu.org>
4322
4323 * syssignal.h: Replace RETSIGTYPE with void.
4324 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
4325 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
4326 Replace SIGTYPE with void everywhere.
4327 * s/usg5-4-common.h (SIGTYPE): Remove definition.
4328 * s/template.h (SIGTYPE): Remove commented out definition.
4329
e2abce01
JB
43302011-03-26 Eli Zaretskii <eliz@gnu.org>
4331
4332 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
4333 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
4334
f868cd8a
JB
43352011-03-26 Juanma Barranquero <lekktu@gmail.com>
4336
59eb0929
JB
4337 * w32.c (read_unc_volume): Use parameter `henum', instead of
4338 global variable `wget_enum_handle'.
4339
4340 * keymap.c (describe_vector): Remove parameters `indices' and
4341 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
4342 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
4343
f868cd8a
JB
4344 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
4345
4346 * keyboard.c (timer_check): Remove parameter `do_it_now',
4347 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
4348 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
4349 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
4350
4351 * keyboard.c (read_char):
4352 * w32menu.c (w32_menu_display_help):
4353 * xmenu.c (show_help_event, menu_help_callback):
4354 Adjust calls to `show_help_echo'.
4355
4356 * gtkutil.c (xg_maybe_add_timer):
4357 * keyboard.c (readable_events):
4358 * process.c (wait_reading_process_output):
4359 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
4360
4361 * insdel.c (adjust_markers_gap_motion):
4362 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
4363 (gap_left, gap_right): Don't call it.
4364
2ecf6fdb
CY
43652011-03-25 Chong Yidong <cyd@stupidchicken.com>
4366
4367 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
4368 incurred during fontification.
4369
6b1f9ba4
JB
43702011-03-25 Juanma Barranquero <lekktu@gmail.com>
4371
4372 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
4373 (DEFVAR_PER_BUFFER): Don't pass it.
4374
4375 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
4376 (scrolling_window): Don't pass it.
4377
0f4a96b5
JB
43782011-03-25 Juanma Barranquero <lekktu@gmail.com>
4379
4380 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
4381
4382 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
4383 and `suffix'.
4384 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
4385 of variables specific to SELinux and computation of `encoded_absname'.
4386
4387 * image.c (XPutPixel): Remove unused variable `height'.
4388
4389 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
4390
4391 * unexw32.c (get_section_info): Remove unused variable `section'.
4392
4393 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
4394 (system_process_attributes): Remove unused variable `sess'.
4395 (sys_read): Remove unused variable `err'.
4396
4397 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
4398 (w32_wnd_proc): Remove unused variable `isdead'.
4399 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
4400 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
4401 (x_create_tip_frame): Remove unused variable `tem'.
4402
4403 * w32inevt.c (w32_console_read_socket):
4404 Remove unused variable `no_events'.
4405
4406 * w32term.c (x_draw_composite_glyph_string_foreground):
4407 Remove unused variable `width'.
4408
1149507c
JB
44092011-03-24 Juanma Barranquero <lekktu@gmail.com>
4410
4411 * w32term.c (x_set_glyph_string_clipping):
4412 Don't pass uninitialized region to CombineRgn.
4413
9c88f339
JB
44142011-03-23 Juanma Barranquero <lekktu@gmail.com>
4415
4416 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
4417 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
4418 (Fx_close_connection): Remove unused variable `i'.
4419
4420 * w32font.c (w32font_draw): Return number of glyphs.
4421 (w32font_open_internal): Remove unused variable `i'.
4422 (w32font_driver): Add missing initializer.
4423
4424 * w32menu.c (utf8to16): Remove unused variable `utf16'.
4425 (fill_in_menu): Remove unused variable `items_added'.
4426
4427 * w32term.c (last_mouse_press_frame): Remove static global variable.
4428 (w32_clip_to_row): Remove unused variable `f'.
4429 (x_delete_terminal): Remove unused variable `i'.
4430
4431 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
4432 (NOTHING): Remove unused static global variable.
4433 (uniscribe_check_otf): Remove unused variable `table'.
4434 (uniscribe_font_driver): Add missing initializers.
4435
dee091a3
JD
44362011-03-23 Julien Danjou <julien@danjou.info>
4437
4438 * term.c (Fsuspend_tty, Fresume_tty):
4439 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
4440 * window.c (temp_output_buffer_show):
4441 * insdel.c (signal_before_change):
4442 * frame.c (Fhandle_switch_frame):
4443 * fileio.c (Fdo_auto_save):
4444 * emacs.c (Fkill_emacs):
4445 * editfns.c (save_excursion_restore):
4446 * cmds.c (internal_self_insert):
4447 * callint.c (Fcall_interactively):
4448 * buffer.c (Fkill_all_local_variables):
4449 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
4450 Use Frun_hooks.
0f4a96b5 4451 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
4452 unconditionnaly since it does the check itself.
4453
2c520ab5 44542011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 4455
c9c49752
PE
4456 Fix more problems found by GCC 4.5.2's static checks.
4457
8abc3f12
PE
4458 * coding.c (encode_coding_raw_text): Avoid unnecessary test
4459 the first time through the loop, since we know p0 < p1 then.
4460 This also avoids a gcc -Wstrict-overflow warning.
4461
a2d26660
PE
4462 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
4463 leading to a memory leak, possible in functions like
4464 load_charset_map_from_file that can allocate an unbounded number
b12ef411 4465 of objects (Bug#8318).
a2d26660 4466
916c72e9
PE
4467 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
4468 that could (at least in theory) be that large.
4469
19ab8a18
PE
4470 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
4471 This is less likely to overflow, and avoids undefined behavior if
4472 overflow does occur. All callers changed. Use strtoul to scan
4473 for the unsigned long integer.
b7cbbd6f
PE
4474 (pint2hrstr): Simplify and tune code slightly.
4475 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 4476
f0641eff
PE
4477 * scroll.c (do_scrolling): Work around GCC bug 48228.
4478 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
4479
7f650bb9
PE
4480 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
4481 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
4482 (validate_x_resource_name): Simplify count usage.
4483 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 4484
37dd57d1
PE
4485 * fileio.c (Fcopy_file): Report error if fchown or fchmod
4486 fail (Bug#8306).
81e56e61 4487
699979fc 4488 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 4489
401bf9b4
PE
4490 * process.c (Fmake_network_process): Use socklen_t, not int,
4491 where POSIX says socklen_t is required in portable programs.
4492 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 4493 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
4494 (Fmake_network_process, server_accept_connection):
4495 (wait_reading_process_output, read_process_output):
4496 Likewise.
4497
b93aacde
PE
4498 * process.c: Rename or move locals to avoid shadowing.
4499 (list_processes_1, Fmake_network_process):
4500 (read_process_output_error_handler, exec_sentinel_error_handler):
4501 Rename or move locals.
4dc343ee 4502 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 4503 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 4504 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 4505 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 4506 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 4507
af8a867c 4508 Make tparam.h and terminfo.c consistent.
44f230aa
SM
4509 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
4510 Include tparam.h instead, since it declares them.
af8a867c
PE
4511 * cm.h (PC): Remove extern decl; tparam.h now does this.
4512 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
4513 * terminfo.c: Include tparam.h, to check interfaces.
4514 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
4515 (tparam): Adjust signature to match interface in tparam.h;
4516 this removes some undefined behavior. Check that outstring and len
4517 are zero, which they always are with Emacs.
4518 * tparam.h (PC, BC, UP): New extern decls.
4519
0248044d 4520 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 4521 (xftfont_open): Rename locals to avoid shadowing.
0248044d 4522
8ff096c1 4523 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
4524 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
4525 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 4526 (ftfont_list): Remove unused local.
49eaafba
PE
4527 (get_adstyle_property, ftfont_pattern_entity):
4528 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
4529 Rename locals to avoid shadowing.
8ff096c1 4530
e2be39f6
PE
4531 * xfont.c (xfont_list_family): Mark var as initialized.
4532
c9735e30
PE
4533 * xml.c (make_dom): Now static.
4534
8f5201ae
PE
4535 * composite.c (composition_compute_stop_pos): Rename local to
4536 avoid shadowing.
b246f932
PE
4537 (composition_reseat_it): Remove unused locals.
4538 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 4539 (composition_update_it): Mark var as initialized.
11b61122
PE
4540 (find_automatic_composition): Mark vars as initialized,
4541 with a FIXME (Bug#8290).
8f5201ae 4542
760fbc2c
PE
4543 character.h: Rename locals to avoid shadowing.
4544 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
4545 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
4546 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
4547 (BUF_DEC_POS): Be more systematic about renaming local temporaries
4548 to avoid shadowing.
4549
ff08eb85
PE
4550 * textprop.c (property_change_between_p): Remove; unused.
4551
fc7bf025
PE
4552 * intervals.c (interval_start_pos): Now static.
4553
235d7abc
PE
4554 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
4555
44f230aa
SM
4556 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
4557 Rename locals to avoid shadowing.
3e7d6594 4558
50060332
PE
4559 * sound.c (wav_play, au_play, Fplay_sound_internal):
4560 Fix pointer signedness.
d01f234b 4561 (alsa_choose_format): Remove unused local var.
c83b8872
PE
4562 (wav_play): Initialize a variable to 0, to prevent undefined
4563 behavior (Bug#8278).
50060332 4564
c4fc4e30
PE
4565 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
4566
918436ed
PE
4567 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
4568
c939f91b
PE
4569 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
4570 clobbering (Bug#8298).
b9c7f648
PE
4571 * sysdep.c (sys_subshell): Likewise.
4572 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 4573
6bd8c144
PE
4574 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
4575 This should get cleaned up, so that child_setup has the
4576 same signature on all platforms.
4577
7710357c 4578 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 4579 (relocate_fd): Rename locals to avoid shadowing.
7710357c 4580
c59da222
CY
45812011-03-22 Chong Yidong <cyd@stupidchicken.com>
4582
4583 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
4584 not to be necessary, and produces flickering.
4585
66b87493
GM
45862011-03-20 Glenn Morris <rgm@gnu.org>
4587
4588 * config.in: Remove file.
4589
45b6f6d5
JB
45902011-03-20 Juanma Barranquero <lekktu@gmail.com>
4591
4592 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
4593 are now in src/globals.h.
4594 (syms_of_minibuf): Remove spurious & from previous change.
4595
3ec03f7e
LL
45962011-03-20 Leo <sdl.web@gmail.com>
4597
4598 * minibuf.c (completing-read-function): New variable.
4599 (completing-read-default): Rename from completing-read.
4600 (completing-read): Call completing-read-function.
4601
b14e3e21
CY
46022011-03-19 Juanma Barranquero <lekktu@gmail.com>
4603
4604 * xfaces.c (Fx_load_color_file):
4605 Read color file from absolute filename (bug#8250).
4606
f2b726e6
JB
46072011-03-19 Juanma Barranquero <lekktu@gmail.com>
4608
4609 * makefile.w32-in: Update dependencies.
4610
09f6ff02
EZ
46112011-03-17 Eli Zaretskii <eliz@gnu.org>
4612
4613 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
4614
29a6015a
PE
46152011-03-17 Paul Eggert <eggert@cs.ucla.edu>
4616
a3a6c54e
PE
4617 Fix more problems found by GCC 4.5.2's static checks.
4618
b766f867
PE
4619 * process.c (make_serial_process_unwind, send_process_trap):
4620 (sigchld_handler): Now static.
4621
be02381c
PE
4622 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
4623 That way, the code declares only the vars that it needs.
4624 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
4625 * s/cygwin.h (PTY_ITERATION): Likewise.
4626 * s/darwin.h (PTY_ITERATION): Likewise.
4627 * s/gnu-linux.h (PTY_ITERATION): Likewise.
4628
57048744
PE
4629 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
4630 * process.c (allocate_pty): Don't declare stb unless it's needed.
4631
7914961c 4632 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
4633 (CONSTANTLIM): Remove; unused.
4634 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
4635 Define only if needed.
7914961c 4636
b3967b18
PE
4637 * unexelf.c (unexec): Name an expression,
4638 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
4639 Use a different way to cause a compilation error if anyone uses
4640 n rather than nn, a way that does not involve shadowing.
73366a00 4641 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 4642
29a6015a
PE
4643 * deps.mk (unexalpha.o): Remove; unused.
4644
43cfc33e 4645 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 4646 * unexec.h: New file.
ce701a33
PE
4647 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
4648 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
4649 Depend on unexec.h.
4650 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
4651 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
4652 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 4653 Change as necessary to match prototype in unexec.h.
ce701a33 4654
01f44d5a
PE
4655 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
4656 shadowing.
4f63c6bb 4657 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 4658
a6670b0b
PE
4659 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
4660 Rename locals to avoid shadowing.
4661
cef2010d 4662 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 4663 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 4664
d4d7173a
PE
4665 * print.c (Fredirect_debugging_output): Fix pointer signedess.
4666
f08b802a
PE
4667 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
4668 warning when compiling print.c.
4669
3ddb0639
PE
4670 * font.c (font_unparse_fcname): Abort in an "impossible" situation
4671 instead of using an uninitialized var.
5ad03b97 4672 (font_sort_entities): Mark var as initialized.
3ddb0639 4673
170a2692
PE
4674 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
4675
e663c700
PE
4676 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
4677 pointers to constants.
89bc529a 4678 (font_parse_fcname): Remove unused vars.
7b81e2d0 4679 (font_delete_unmatched): Now static.
ea838e10 4680 (font_get_spec): Remove; unused.
13a547c6
PE
4681 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
4682 (font_update_drivers, Ffont_get_glyphs, font_add_log):
4683 Rename or move locals to avoid shadowing.
e663c700 4684
2a80c887 4685 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 4686 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 4687
1384fa33 4688 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 4689 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 4690
8b2c52e9
PE
4691 * alloc.c (mark_backtrace): Move decl from here ...
4692 * lisp.h: ... to here, so that it can be checked.
4693
475545b5 4694 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 4695 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
4696 (lisp_indirect_variable): Name an expression,
4697 to avoid gcc -Wbad-function-cast warning.
1faed8ae 4698 (Fdefvar): Rename locals to avoid shadowing.
475545b5 4699
b1349114 4700 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 4701 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 4702 Use const pointer when appropriate.
b1349114 4703
a2928364
PE
4704 * lisp.h (get_system_name, get_operating_system_release):
4705 Move decls here, to check interfaces.
4706 * process.c (get_operating_system_release): Move decl to lisp.h.
4707 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
4708 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
4709 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
4710 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
4711 (Fformat_time_string, Fencode_time, Finsert_char):
4712 (Ftranslate_region_internal, Fformat):
4713 Rename or remove local vars to avoid shadowing.
9710023e 4714 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 4715
a415e694
PE
4716 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
4717 avoid shadowing.
4718
8ef4622d
PE
4719 * lisp.h (eassert): Check that the argument compiles, even if
4720 ENABLE_CHECKING is not defined.
4721
946f9a5b
PE
4722 * data.c (Findirect_variable): Name an expression, to avoid
4723 gcc -Wbad-function-cast warning.
112396d6 4724 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 4725 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
4726 (Fmake_variable_buffer_local, Fmake_local_variable):
4727 Mark variables as initialized.
52746918 4728 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 4729
e5aab7e7 4730 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
4731 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
4732 Rename locals to avoid shadowing.
dff45157
PE
4733 (mark_stack): Move local variables into the #ifdef region where
4734 they're used.
7bc26fdb
PE
4735 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
4736 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
4737 needed otherwise.
4738 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
4739 (GC_STRING_CHARS): Remove; not used.
d40d4be1 4740 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 4741
e5aab7e7
PE
4742 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
4743 avoids undefined behavior in theory.
4744
4da60324
PE
4745 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
4746
88043301
PE
4747 Use functions, not macros, for up- and down-casing (Bug#8254).
4748 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4749 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
4750 to use the following functions instead of these macros.
4751 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
4752 EMACS_INT, since callers assume the returned value fits in int.
4753 (upcase1): Likewise, for UPCASE_TABLE.
4754 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 4755 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 4756 the race-condition problem in the old DOWNCASE.
88043301 4757
19ed5445
PE
4758 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
4759 Rename locals to avoid shadowing.
4760 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
4761 (regex_compile, re_search_2, re_match_2_internal):
4762 Remove unused local vars.
952db0d7
PE
4763 (FREE_VAR): Rewrite so as not to use empty "else",
4764 which gcc can warn about.
da053e48 4765 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
4766 (RETALLOC_IF): Define only if needed.
4767 (WORDCHAR_P): Likewise. This one is never needed, but is used
4768 only in a comment talking about a compiler bug, so put inside
4769 the #if 0 of that comment.
4770 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
4771 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
4772 Remove; unused.
19ed5445 4773
1f3561e4 4774 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
4775 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
4776 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 4777
ded6f8f7
PE
4778 * search.c (simple_search): Remove unused var.
4779
dbd37a95
PE
4780 * dired.c (compile_pattern): Move decl from here ...
4781 * lisp.h: ... to here, so that it can be checked.
4782 (struct re_registers): New forward decl.
4783
7e47afad
PE
4784 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
4785
85f24f61
PE
4786 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
4787 All uses changed.
4788 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
4789 Rename locals to avoid shadowing.
5671df8f 4790 (Fvertical_motion): Mark locals as initialized.
85f24f61 4791
181aa2be 4792 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 4793 (casify_region): Mark local as initialized.
181aa2be 4794
930d429c
PE
4795 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
4796
7082eac6
PE
4797 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
4798 New macros, so that the caller can use some names other than
4799 gcpro1, gcpro2, etc.
4800 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
4801 of the new macros.
4802 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
4803 argument, for consistency with GCPRO2_VAR, etc: it is now the
4804 prefix of the variable, not the variable itself. All uses
4805 changed.
38b2c076
PE
4806 * dired.c (directory_files_internal, file_name_completion):
4807 Rename locals to avoid shadowing.
4808
15206ed9
PE
4809 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
4810 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
4811 dired.c's scmp function, had undefined behavior.
4812 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
4813 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
4814 * buffer.h: ... to here, because these macros use current_buffer,
4815 and the new implementation with inline functions needs to have
4816 current_buffer in scope now, rather than later when the macros
4817 are used.
4818 (downcase, upcase1): New static inline functions.
4819 (DOWNCASE, UPCASE1): Reimplement using these functions.
4820 This avoids undefined behavior in expressions like
4821 DOWNCASE (x) == DOWNCASE (y), which previously suffered
4822 from race conditions in accessing the global variables
4823 case_temp1 and case_temp2.
4824 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
4825 * lisp.h (case_temp1, case_temp2): Remove their decls.
4826 * character.h (ASCII_CHAR_P): Move from here ...
4827 * lisp.h: ... to here, so that the inline functions mentioned
4828 above can use them.
4829
4a6bea26
PE
4830 * dired.c (directory_files_internal_unwind): Now static.
4831
f14b7e14
PE
4832 * fileio.c (file_name_as_directory, directory_file_name):
4833 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
4834 Now static.
2893f146
PE
4835 (file_name_as_directory): Use const pointers when appropriate.
4836 (Fexpand_file_name): Likewise. In particular, newdir might
4837 point at constant storage, so make it a const pointer.
fd4ead52 4838 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
4839 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
4840 signedness issues.
f839df0c
PE
4841 (Fset_file_times, Finsert_file_contents, auto_save_error):
4842 Rename locals to avoid shadowing.
f14b7e14 4843
5716756e 4844 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
4845 (Ftry_completion, Fall_completions): Rename or remove locals
4846 to avoid shadowing.
5716756e 4847
b4c3046a
PE
4848 * marker.c (bytepos_to_charpos): Remove; unused.
4849
b45db522
PE
4850 * lisp.h (verify_bytepos, count_markers): New decls,
4851 so that gcc does not warn that these functions aren't declared.
4852
85876d07
PE
4853 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
4854 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 4855 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 4856 (copy_text): Remove unused local var.
85876d07 4857
03d78a21 4858 * filelock.c (within_one_second): Now static.
b3dd38ab 4859 (lock_file_1): Rename local to avoid shadowing.
03d78a21 4860
5df8f01b
PE
4861 * buffer.c (fix_overlays_before): Mark locals as initialized.
4862 (fix_start_end_in_overlays): Likewise. This function should be
4863 simplified by using pointers-to-pointers, but that's a different
4864 matter.
b1d876f1 4865 (switch_to_buffer_1): Now static.
8f54f30a
PE
4866 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
4867 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 4868
a70072c9 4869 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 4870 Fix pointer signedness issue.
edced198
PE
4871 (sys_subshell): Mark local as volatile if checking for lint,
4872 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 4873 (MAXPATHLEN): Define only if needed.
a70072c9 4874
a0977c44
PE
4875 * process.c (serial_open, serial_configure): Move decls from here ...
4876 * systty.h: ... to here, so that they can be checked.
4877
a884fdcc
PE
4878 * fns.c (get_random, seed_random): Move extern decls from here ...
4879 * lisp.h: ... to here, so that they can be checked.
4880
604efe86 4881 * sysdep.c (reset_io): Now static.
b8950c94 4882 (wait_for_termination_signal): Remove; unused.
604efe86 4883
38fc62d9
PE
4884 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
4885 (copy_keymap_item, append_key, push_text_char_description):
4886 Now static.
1004a21a 4887 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 4888 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
4889 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
4890 (describe_map_tree):
4891 Rename locals to avoid shadowing.
38fc62d9 4892
2f2650da
PE
4893 * keyboard.c: Declare functions static if they are not used elsewhere.
4894 (echo_char, echo_dash, cmd_error, top_level_2):
4895 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
4896 (read_char, kbd_buffer_get_event, make_lispy_position):
4897 (make_lispy_event, make_lispy_movement, apply_modifiers):
4898 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
4899 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
4900 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 4901 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 4902 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 4903
a053e86c 4904 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
4905 (mark_kboards): Move decl here ...
4906 * alloc.c (mark_kboards): ... from here.
a053e86c 4907
4752793e
PE
4908 * lisp.h (force_auto_save_soon): New decl.
4909
74f10ca7 4910 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
4911 (DEFINE_DUMMY_FUNCTION): New macro.
4912 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
4913 Use it.
c03cd23f
PE
4914 (main): Add casts to avoid warnings
4915 if GCC considers string literals to be constants.
74f10ca7 4916
022e70d4
PE
4917 * lisp.h (fatal_error_signal): Add decl, since it's exported.
4918
59d6fe83
PE
4919 * dbusbind.c: Pointer signedness fixes.
4920 (xd_signature, xd_append_arg, xd_initialize):
4921 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4922 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4923 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
4924 (Fdbus_register_signal): Use SSDATA when the context wants char *.
4925
78320123
PE
4926 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
4927 if GCC considers string literals to be constants.
49cebcca 4928 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 4929
35ac2a97
SM
49302011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
4931
fb103ca9
SM
4932 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
4933 (print_preprocess, print_object): New macro to fix last change.
4934
35ac2a97
SM
4935 * print.c (print_preprocess): Don't forget font objects.
4936
62973b41
JB
49372011-03-16 Juanma Barranquero <lekktu@gmail.com>
4938
4939 * emacs.c (USAGE3): Doc fixes.
4940
0e48bb22
AS
49412011-03-15 Andreas Schwab <schwab@linux-m68k.org>
4942
4943 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
4944 structure.
4945
7684e57b
JB
49462011-03-14 Juanma Barranquero <lekktu@gmail.com>
4947
4948 * lisp.h (VWindow_system, Qfile_name_history):
4949 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
4950 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
4951 (w32_system_caret_x, w32_system_caret_y): Declare extern.
4952
4953 * w32select.c: Don't #include "keyboard.h".
c96bbc66 4954 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
4955
4956 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
4957 * w32console.c (detect_input_pending, read_input_pending)
4958 (encode_terminal_code):
4959 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
4960 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
4961 (w32_system_caret_y, Qfile_name_history):
4962 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
4963 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
4964 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
4965 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
4966 * w32proc.c (Qlocal, report_file_error):
4967 * w32term.c (Vwindow_system, updating_frame):
4968 * w32uniscribe.c (initialized, uniscribe_font_driver):
4969 Remove unneeded extern declarations.
4970
2aa46d6c
CY
49712011-03-14 Chong Yidong <cyd@stupidchicken.com>
4972
c96bbc66 4973 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 4974
cffc6f3b
CY
49752011-03-13 Chong Yidong <cyd@stupidchicken.com>
4976
4977 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
4978 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
4979 These macros can no longer be used for assignment.
4980
44f230aa
SM
4981 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4982 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
4983 (record_buffer_markers, fetch_buffer_markers): New functions for
4984 recording and fetching special buffer markers.
4985 (set_buffer_internal_1, set_buffer_temp): Use them.
4986
4987 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
4988
4989 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
4990
4991 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
4992 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
4993
4994 * xdisp.c (hscroll_window_tree):
4995 (reconsider_clip_changes): Use PT instead of BUF_PT.
4996
d251f04b
EZ
49972011-03-13 Eli Zaretskii <eliz@gnu.org>
4998
4999 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
5000 $(EMACS_ROOT)/lib/intprops.h.
5001
f0c77cd1
PE
50022011-03-13 Paul Eggert <eggert@cs.ucla.edu>
5003
3eca4629
PE
5004 Fix more problems found by GCC 4.5.2's static checks.
5005
7c86ee98
PE
5006 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
5007 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
5008 (xg_free_frame_widgets): Make it clear that a local variable is
5009 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
5010 (gdk_window_get_screen): Make it clear that this macro is needed
5011 only if USE_GTK_TOOLTIP.
1e5524e7
PE
5012 (int_gtk_range_get_value): New function, which avoids a diagnostic
5013 from gcc -Wbad-function-cast.
5014 (xg_set_toolkit_scroll_bar_thumb): Use it.
5015 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
5016 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
5017 (get_utf8_string, xg_get_file_with_chooser):
5018 Rename locals to avoid shadowing.
5019 (create_dialog): Move locals to avoid shadowing.
7c86ee98 5020
41729b81
PE
5021 * xgselect.c (xg_select): Remove unused var.
5022
f0c77cd1
PE
5023 * image.c (four_corners_best): Mark locals as initialized.
5024 (gif_load): Initialize transparent_p to zero (Bug#8238).
5025 Mark another local as initialized.
ec6cf4c6 5026 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 5027
ce0ad53d 5028 * image.c (clear_image_cache): Now static.
d5d5a617 5029 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 5030 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
5031 (x_edge_detection): Remove unnecessary cast that
5032 gcc -Wbad-function-cast diagnoses.
2037898d 5033 (gif_load): Fix pointer signedness.
6ae141d6
PE
5034 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
5035 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 5036
33383987 50372011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 5038
d32df629
PE
5039 Improve quality of tests for time stamp overflow.
5040 For example, without this patch (encode-time 0 0 0 1 1
5041 1152921504606846976) returns the obviously-bogus value (-948597
5042 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
5043 reports time overflow. See
5044 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
5045 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
5046 * editfns.c: Include limits.h and intprops.h.
5047 (TIME_T_MIN, TIME_T_MAX): New macros.
5048 (time_overflow): Move earlier, to before first use.
5049 (hi_time, lo_time): New functions, for an accurate test for
5050 out-of-range times.
5051 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
5052 (Fget_internal_run_time): Don't assume time_t fits in int.
5053 (make_time): Use list2 instead of Fcons twice.
5054 (Fdecode_time): More accurate test for out-of-range times.
5055 (check_tm_member): New function.
5056 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
5057 (lisp_time_argument): Don't rely on undefined left-shift and
5058 right-shift behavior when checking for time stamp overflow.
8be6f318 5059
fe31d94c
PE
5060 * editfns.c (time_overflow): New function, refactoring common code.
5061 (Fformat_time_string, Fdecode_time, Fencode_time):
5062 (Fcurrent_time_string): Use it.
5063
8be6f318
PE
5064 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
5065 * dired.c (make_time): Move to ...
5066 * editfns.c (make_time): ... here.
5067 * systime.h: Note the move.
5068
09d9db2c 50692011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 5070
126bc0dc
YM
5071 * fringe.c (update_window_fringes): Remove unused variables.
5072
c47cbdfd
YM
5073 * unexmacosx.c (copy_data_segment): Also copy __got section.
5074 (Bug#8223)
5075
7ac80be9
EZ
50762011-03-12 Eli Zaretskii <eliz@gnu.org>
5077
c96bbc66 5078 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
5079 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
5080 Constify `char *' arguments and their references according to
5081 prototypes in tparam.h.
5082
ecb0f94d 5083 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 5084
7ac80be9
EZ
5085 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
5086 Adapt all references accordingly.
5087
5088 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
5089
ef1fd07e
TT
50902011-03-11 Tom Tromey <tromey@redhat.com>
5091
5092 * buffer.c (syms_of_buffer): Remove obsolete comment.
5093
7ef4b50c
EZ
50942011-03-11 Eli Zaretskii <eliz@gnu.org>
5095
5096 * termhooks.h (encode_terminal_code): Declare prototype.
5097
5098 * msdos.c (encode_terminal_code): Don't declare prototype.
5099
5100 * term.c (encode_terminal_code): Now external again, used by
5101 w32console.c and msdos.c.
5102
44f230aa
SM
5103 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
5104 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 5105
4b1ec863 51062011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 5107
1714f52b 5108 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 5109
4b1ec863
PE
5110 * fringe.c (update_window_fringes): Mark locals as initialized
5111 (Bug#8227).
5112 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 5113
524c7aa6
PE
5114 * alloc.c (mark_fringe_data): Move decl from here ...
5115 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
5116 to check its interface.
5117 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
5118
a5c0af81 5119 * fontset.c (free_realized_fontset): Now static.
7519b8cd 5120 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 5121 (fontset_font): Mark local as initialized.
a9a06e0b 5122 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 5123
b4716021
PE
5124 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
5125
811e9bac 5126 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 5127 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
5128 (x_own_selection, Fx_disown_selection_internal): Rename locals
5129 to avoid shadowing.
5130 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 5131
7e3ab302
PE
5132 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
5133 so that the caller can use some name other than gcpro1.
5134 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
5135 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5136 (Fx_backspace_delete_keys_p):
5137 Use them to avoid shadowing, and rename vars to avoid shadowing.
5138 (x_decode_color, x_set_name, x_window): Now static.
6b437900 5139 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 5140 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
5141 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
5142 Remove unused locals.
7e3ab302
PE
5143 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
5144 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
5145 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
5146 macros.
f78faa98 5147
e2b13473
PE
5148 * xterm.h (x_mouse_leave): New decl.
5149
77f23912
PE
5150 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
5151 Remove unused functions.
cdf4ba58
PE
5152 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
5153 (x_calc_absolute_position): Now static.
7411c686 5154 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 5155 Don't declare local "event" unless it's used.
ed7bf3a5
PE
5156 (x_iconify_frame, x_free_frame_resources): Don't declare locals
5157 unless they are used.
38d0b34a
PE
5158 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
5159 (x_fatal_error_signal): Remove; not used.
a6067996
PE
5160 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
5161 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
5162 (x_error_catcher, x_connection_closed, x_error_handler):
5163 (x_error_quitter, xembed_send_message, x_iconify_frame):
5164 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 5165 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 5166 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 5167
44f230aa
SM
5168 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
5169 Rename or move locals to avoid shadowing.
6b463e58 5170 (tty_defined_color, merge_face_heights): Now static.
5967d051 5171 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
5172 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
5173 does not deduce is never used uninitialized.
73719eba
PE
5174 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
5175 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 5176
426994c3 5177 * terminal.c (store_terminal_param): Now static.
5489860b 5178
032f1620 5179 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 5180 (set_frame_menubar): Remove unused local.
d4323972 5181 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
5182 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
5183 since they might point to immutable storage.
281585b0
PE
5184 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
5185 since it's unused otherwise.
032f1620 5186
367c19e5 5187 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 5188 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
5189 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
5190 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 5191 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
5192 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
5193 does not deduce are never used uninitialized.
70739cbe 5194
07b48fa9
PE
5195 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
5196
8868a238 5197 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
5198 * window.c (window_loop, size_window):
5199 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 5200
7e5cf297 5201 * window.c (display_buffer): Now static.
d6550a9f
PE
5202 (size_window): Mark variables that gcc -Wuninitialized
5203 does not deduce are never used uninitialized.
a586633d
PE
5204 * window.h (check_all_windows): New decl, to forestall
5205 gcc -Wmissing-prototypes diagnostic.
5b555da1 5206 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 5207
f6095868
PE
5208 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
5209 shadowing.
5210 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
5211 Include <limits.h>.
5212 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
5213 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
5214 (load_charset_map): Mark variables that gcc -Wuninitialized
5215 does not deduce are never used uninitialized.
53df7c11 5216 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 5217
f38b440c
PE
5218 * coding.c (coding_set_source, coding_set_destination):
5219 Use "else { /* comment */ }" rather than "else /* comment */;"
5220 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
5221 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
5222 a block, when the outer 'i' will do.
5223 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
5224 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
5225 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
5226 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
5227 (Fdecode_sjis_char, Fdefine_coding_system_internal):
5228 Rename locals to avoid shadowing.
5229 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
5230 * coding.c (emacs_mule_char, encode_invocation_designation):
5231 Now static, since they're not used elsewhere.
413bb2db 5232 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 5233 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
5234 (decode_coding_emacs_mule): Mark variables that gcc
5235 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
5236 (detect_coding_iso_2022): Initialize a local variable that might
5237 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 5238 this initialization is needed. (Bug#8211)
5f58e762
PE
5239 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
5240 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
5241 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
5242 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
5243 Remove unused macros.
f38b440c 5244
232b38b9 5245 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 5246 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 5247 * character.c (string_count_byte8): Likewise.
232b38b9 5248
fb90da1b
PE
5249 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
5250 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
5251
fb93dbc2
PE
5252 * chartab.c (copy_sub_char_table): Now static, since it's not used
5253 elsewhere.
5c156ace
PE
5254 (sub_char_table_ref_and_range, char_table_ref_and_range):
5255 Rename locals to avoid shadowing.
bbcd0949 5256 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 5257
7d3b3862 5258 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 5259 (BIDI_BOB): Remove unused macro.
7d3b3862 5260
6be7d3da
PE
5261 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
5262 deduce are never used uninitialized.
c2ed9c8b 5263 * term.c (encode_terminal_code): Likewise.
6be7d3da 5264
75f8807f 5265 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 5266
50938595
PE
5267 * tparam.h: New file.
5268 * term.c, tparam.h: Include it.
5269 * deps.mk (term.o, tparam.o): Depend on tparam.h.
5270 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
5271 Move these decls to tparam.h, and make them agree with what
5272 is actually in tparam.c. The previous trick of using incompatible
5273 decls in different modules does not conform to the C standard.
5274 All callers of tparam changed to use tparam's actual API.
5275 * tparam.c (tparam1, tparam, tgoto):
5276 Use const pointers where appropriate.
5277
fbceeba2
PE
5278 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
5279 * cm.h (struct cm): Likewise.
5280 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
5281 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
5282 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
5283 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
5284 (turn_on_face, init_tty): Likewise.
5285 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 5286
7f3f1250
PE
5287 * term.c (term_mouse_position): Rename local to avoid shadowing.
5288
e6ca6543
PE
5289 * alloc.c (mark_ttys): Move decl from here ...
5290 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
5291
c40f8d15
AS
52922011-03-11 Andreas Schwab <schwab@linux-m68k.org>
5293
5294 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
5295
cfe0661d
JB
52962011-03-09 Juanma Barranquero <lekktu@gmail.com>
5297
5298 * search.c (compile_pattern_1): Remove argument regp, unused since
5299 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
5300 (compile_pattern): Don't pass it.
5301
0afb4571
J
53022011-03-08 Jan Djärv <jan.h.d@swipnet.se>
5303
5304 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
5305 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
5306 for ! HAVE_GTK3.
5307 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
5308
5309 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
5310
5311 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
5312 gdk_window_get_screen, gdk_window_get_geometry,
5313 gdk_x11_window_lookup_for_display and GDK_KEY_g.
5314 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
5315 (xg_get_pixbuf_from_pixmap): New function.
5316 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
5317 to Pixmap, take frame as parameter, remove GdkColormap parameter.
5318 Call xg_get_pixbuf_from_pixmap instead of
5319 gdk_pixbuf_get_from_drawable.
5320 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
5321 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
5322 (xg_check_special_colors): Use GtkStyleContext and its functions
5323 for HAVE_GTK3.
5324 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
5325 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
5326 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
5327 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
5328 Call gtk_widget_get_preferred_size.
0afb4571
J
5329 (xg_frame_resized): gdk_window_get_geometry only takes 5
5330 parameters.
44f230aa
SM
5331 (xg_win_to_widget, xg_event_is_for_menubar):
5332 Call gdk_x11_window_lookup_for_display.
0afb4571
J
5333 (xg_set_widget_bg): New function.
5334 (delete_cb): New function.
895009e1 5335 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
5336 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
5337 (xg_set_background_color): Call xg_set_widget_bg.
5338 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
5339 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
5340 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
5341 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
5342 if ! HAVE_GTK3.
5343 (update_frame_tool_bar): Call gtk_widget_hide.
5344 (xg_initialize): Use GDK_KEY_g.
5345
5346 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
5347 if ! HAVE_GTK3
5348 (x_session_initialize): Call gdk_x11_set_sm_client_id.
5349
5350 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
5351 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
5352 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
5353
1c2cc4ef
JB
53542011-03-08 Juanma Barranquero <lekktu@gmail.com>
5355
5356 * w32xfns.c (select_palette): Check success of RealizePalette against
5357 GDI_ERROR, not zero.
5358
33383987 5359See ChangeLog.11 for earlier changes.
aac0c6e3
MR
5360
5361;; Local Variables:
5362;; coding: utf-8
aac0c6e3
MR
5363;; End:
5364
33383987 5365 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
5366
5367 This file is part of GNU Emacs.
5368
5369 GNU Emacs is free software: you can redistribute it and/or modify
5370 it under the terms of the GNU General Public License as published by
5371 the Free Software Foundation, either version 3 of the License, or
5372 (at your option) any later version.
5373
5374 GNU Emacs is distributed in the hope that it will be useful,
5375 but WITHOUT ANY WARRANTY; without even the implied warranty of
5376 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
5377 GNU General Public License for more details.
5378
5379 You should have received a copy of the GNU General Public License
5380 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.