Spelling fixes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0e5317f7
KH
12011-12-28 Kenichi Handa <handa@m17n.org>
2
3 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
4 coding-system ASCII compatible only when it does not produce BOM
5 on encoding (Bug#10383).
6
93d5ca1f
JD
72011-12-26 Jan Djärv <jan.h.d@swipnet.se>
8
9 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
10 can scroll.
11 (create_and_show_popup_menu): Always use menu_position_func for
12 Gtk3 (Bug#10361).
13
ca22b785
AS
142011-12-24 Andreas Schwab <schwab@linux-m68k.org>
15
16 * callint.c (Fcall_interactively): Don't truncate prompt string.
17
d048e1e6
EZ
182011-12-23 Eli Zaretskii <eliz@gnu.org>
19
20 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
21 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 22 resumed from there (after widening). (Bug#10360)
d048e1e6 23
5ccaba1f
JD
242011-12-22 Jan Djärv <jan.h.d@swipnet.se>
25
26 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
27
204ee57f
JD
282011-12-21 Jan Djärv <jan.h.d@swipnet.se>
29
30 * nsterm.m (x_free_frame_resources): Release
31 f->output_data.ns->miniimage
32 (ns_index_color): Fix indentation. Do not retain
33 color_table->colors[i].
34
35 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
36 before returning.
37
38 * nsfns.m (x_set_background_color): Assign return value from
39 ns_index_color to face-background instead of NSColor*.
40 (ns_implicitly_set_icon_type): Fix indentation.
41 Change assignment in for loop to comparison.
42
43 * emacs.c (ns_pool): New variable.
44 (main): Assign ns_pool.
45 (Fkill_emacs): Call ns_release_autorelease_pool.
46
47 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
48 autorelease fdesc, release fdAttrs and tdict.
49 (ns_get_covering_families): Release charset.
50 (ns_findfonts): Release NSFontDescriptor created with new.
51 (ns_uni_to_glyphs): Fix indentation.
52 (setString): Release attrStr before assigning new value.
53
c803b2b7
JD
542011-12-18 Jan Djärv <jan.h.d@swipnet.se>
55
678f4426
JD
56 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
57 and NS_IMPL_COCOA.
58 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
59 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
60
612011-12-18 David Reitter <reitter@cmu.edu>
62
5fecd5fc
JD
63 * nsterm.m (ns_term_init): Subscribe for notifications
64 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
65 to method trackingNotification in EmacsMenu.
66
67 * nsmenu.m (trackingMenu): New variable.
3771cb17 68 (trackingNotification): New method (from Aquamacs).
5fecd5fc 69 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 70 from Aquamacs (Bug#7030).
678f4426
JD
71
722011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 73
c803b2b7
JD
74 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
75 (symbol_to_nsstring): Fix indentation.
76 (ns_symbol_to_pb): New function.
77 (Fns_get_selection_internal): Renamed from Fns_get_cut_buffer_internal.
78 (Fns_rotate_cut_buffers_internal): Removed.
79 (Fns_store_selection_internal): Renamed from
80 Fns_store_cut_buffer_internal.
81 (ns_get_foreign_selection, Fx_own_selection_internal)
82 (Fx_disown_selection_internal, Fx_selection_exists_p)
83 (Fns_get_selection_internal, Fns_store_selection_internal): Use
84 ns_symbol_to_pb and check if return value is nil.
85 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove
86 defsubr Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
87 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
88 renamed to Sns_store_selection_internal.
89 (ns_handle_selection_request): Move code to Fx_own_selection_internal
90 and remove this function.
91 (ns_handle_selection_clear): Remove, never used.
92 (Fx_own_selection_internal): Move code from ns_handle_selection_request
93 here.
94
e1b01a3a
KB
952011-12-17 Ken Brown <kbrown@cornell.edu>
96
97 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
98 GID is unknown (Bug#10257).
99
2adb6e85
PE
1002011-12-17 Paul Eggert <eggert@cs.ucla.edu>
101
102 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
103 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
104 which caused a build failure on GNU/Linux IA-64. This problem was
105 introduced by my 2011-10-07 patch.
106
d1d7b339
JL
1072011-12-15 Juri Linkov <juri@jurta.org>
108
109 * image.c (imagemagick_error): New function. (Bug#10112)
110 (imagemagick_load_image): Comment out `MagickSetResolution' call.
111 Use `imagemagick_error' where ImageMagick functions return
112 `MagickFalse'.
113 (Fimagemagick_types): Add `Fnreverse' to return the list in the
114 proper order.
115
100d5755
KH
1162011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
117
118 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
119 fill background (Bug#8992).
120
454592a6
MR
1212011-12-13 Martin Rudalics <rudalics@gmx.at>
122
123 * window.c (Vwindow_combination_resize)
124 (Vwindow_combination_limit): Use t instead of non-nil in
125 doc-strings.
61d4b438
MR
126 (Vrecenter_redisplay): Add first sentence of doc-string on
127 separate line.
53524d93 128 (Frecenter): Fix doc-string typo.
454592a6 129
3633e3aa
KH
1302011-12-11 Kenichi Handa <handa@m17n.org>
131
132 * coding.c (Funencodable_char_position): Pay attention to the
133 buffer text relocation (Bug#9389).
134
7b9d523a
JD
1352011-12-10 Jan Djärv <jan.h.d@swipnet.se>
136
137 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
138 gtk_init (Bug#10100).
139
b73189c6
EZ
1402011-12-10 Eli Zaretskii <eliz@gnu.org>
141
142 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
143 IT->string is nil. (Bug#10263)
144
f7dfe5d6
JD
1452011-12-10 Jan Djärv <jan.h.d@swipnet.se>
146
83faebb4
JD
147 * nsterm.h (x_free_frame_resources): Declare.
148
f7dfe5d6
JD
149 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
150 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
151
152 * nsterm.h (ns_get_defaults_value): Declare.
153
154 * nsterm.m (ns_default): Call ns_get_defaults_value.
155
7cd4e72c
EZ
1562011-12-09 Eli Zaretskii <eliz@gnu.org>
157
158 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
159 (Bug#10170)
160
b34d7317
YM
1612011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
162
163 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
164 that where the value of an _OBJC_* symbol points to is in the .bss
165 section (Bug#10240).
166
76470ad1
KH
1672011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
168
169 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 170 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 171
745fff94
KH
1722011-12-08 Kenichi Handa <handa@m17n.org>
173
174 * ftfont.c (get_adstyle_property): Fix previous change
175 (Bug#10233).
176
6e44397c
JB
1772011-12-07 Juanma Barranquero <lekktu@gmail.com>
178
179 * w32.c (init_environment): If no_site_lisp, remove site-lisp
180 dirs from the default value of EMACSLOADPATH (bug#10208).
181
7efa6272
GM
1822011-12-07 Glenn Morris <rgm@gnu.org>
183
184 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
185 installation and source directories as well. (Bug#10208)
186
f6fc4d87
CY
1872011-12-06 Chong Yidong <cyd@gnu.org>
188
189 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
190
2bf26180
GM
1912011-12-06 Glenn Morris <rgm@gnu.org>
192
193 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
194 as an error, not just -1. (Bug#10217)
195
3a6ad4f0
CY
1962011-12-05 Chong Yidong <cyd@gnu.org>
197
198 * keyboard.c (process_special_events): New function.
199 (swallow_events, Finput_pending_p): Use it (Bug#10195).
200
75a3b399
PE
2012011-12-05 Paul Eggert <eggert@cs.ucla.edu>
202
203 * coding.c (encode_designation_at_bol): Don't use uninitialized
204 local variable (Bug#9318).
205
c3c9e25e
KH
2062011-12-05 Kenichi Handa <handa@m17n.org>
207
208 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
209 return Qnil (Bug#8046, Bug#10193).
210
5eb05ea3
KH
2112011-12-05 Kenichi Handa <handa@m17n.org>
212
213 * coding.c (encode_designation_at_bol): New args charbuf_end and
214 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
215 (coding_set_source): Return how many bytes coding->source was
216 relocated.
217 (coding_set_destination): Return how many bytes
218 coding->destination was relocated.
219 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
220 (CODING_CHAR_CHARSET_P): Adjusted for the avove changes.
5eb05ea3
KH
221
2222011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
223
224 * coding.c (CODING_CHAR_CHARSET_P): New macro.
225 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
226 macro (Bug#9318).
227
2282011-12-05 Andreas Schwab <schwab@linux-m68k.org>
229
230 The following changes are to fix Bug#9318.
231
a79703f5 232 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
233 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
234 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 235 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 236
7dbda6df
JB
2372011-12-05 Juanma Barranquero <lekktu@gmail.com>
238
239 * lisp.h (process_quit_flag): Fix external declaration.
240
6d5eb5b0
SM
2412011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
242
243 Don't macro-inline non-performance-critical code.
244 * eval.c (process_quit_flag): New function.
245 * lisp.h (QUIT): Use it.
246
a0c3fad0
JD
2472011-12-04 Jan Djärv <jan.h.d@swipnet.se>
248
249 * nsfns.m (get_geometry_from_preferences): New function.
250 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
251
6c07aac2
AS
2522011-12-04 Andreas Schwab <schwab@linux-m68k.org>
253
254 * emacs.c (Qkill_emacs): Define.
255 (syms_of_emacs): Initialize it.
256 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
257 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
258 (quit_throw_to_read_char): Add parameter `from_signal'.
259 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
260 * lisp.h (QUIT): Call Fkill_emacs if requested.
261
c052ead4
JD
2622011-12-03 Jan Djärv <jan.h.d@swipnet.se>
263
264 * widget.c (update_wm_hints): Return if wmshell is null.
265 (widget_update_wm_size_hints): New function.
266
267 * widget.h (widget_update_wm_size_hints): Declare.
268
269 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
270 widget_update_wm_size_hints (Bug#10104).
271
9e49252b
EZ
2722011-12-03 Eli Zaretskii <eliz@gnu.org>
273
274 * xdisp.c (handle_invisible_prop): If the invisible text ends just
275 before a newline, prepare the bidi iterator for consuming the
276 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 277 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 278
02b16839
JL
2792011-12-02 Juri Linkov <juri@jurta.org>
280
281 * search.c (Fword_search_regexp): New Lisp function created from
282 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
283 (Fword_search_backward, Fword_search_forward)
284 (Fword_search_backward_lax, Fword_search_forward_lax):
285 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
286 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
287
0068070e
SM
2882011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
289
290 * fileio.c (Finsert_file_contents): Move after-change-function call
291 to before the "handled:" label, since all "goto handled" appear in
292 cases where the *-change-functions have already been properly called
293 (bug#10117).
294
3360a3fc
AS
2952011-12-01 Andreas Schwab <schwab@linux-m68k.org>
296
297 * keyboard.c (interrupt_signal): Don't call kill-emacs when
298 waiting for input. (Bug#10169)
299
73d6c093
EZ
3002011-11-30 Eli Zaretskii <eliz@gnu.org>
301
302 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
303 verifies glyph row's hash code--we have just reallocated the
304 glyphs, so their contents can be complete garbage. (Bug#10164)
305
febe6bea
JB
3062011-11-30 Juanma Barranquero <lekktu@gmail.com>
307
308 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
309
801a4313
EZ
3102011-11-30 Eli Zaretskii <eliz@gnu.org>
311
312 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
313 attributes are tested _before_ calling verify_row_hash, to protect
314 against GCC re-ordering of the tests. (Bug#10164)
315
2b56b87e
JD
3162011-11-29 Jan Djärv <jan.h.d@swipnet.se>
317
318 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
319
320 * xterm.c (handle_one_xevent): Only set async_visible and friends
321 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 322 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
323 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
324
dbf31225
PE
3252011-11-28 Paul Eggert <eggert@cs.ucla.edu>
326
327 Remove GCPRO-related macros that exist only to avoid shadowing locals.
328 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
329 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
330 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
331 All uses changed to use GCPRO1 etc.
332 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
333 Revert to old implementation (i.e., before 2011-03-11).
334
1305621b
YM
3352011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
336
337 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
338 of scroll runs so as to avoid assigning disabled bogus rows and
339 unnecessary graphics copy operations.
340
8c9afb46
EZ
3412011-11-27 Eli Zaretskii <eliz@gnu.org>
342
343 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
344 (snprintf) [_MSC_VER]: Redirect to _snprintf.
345 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
346 (malloc, free, realloc, calloc): Redirect to e_* only when
347 compiling Emacs.
348
349 * lisp.h (GCTYPEBITS): Move before first use.
350 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
351 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
352 this macro definition.
353
354 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
355 _MSC_VER.
356
54e9e3bf
JD
3572011-11-27 Jan Djärv <jan.h.d@swipnet.se>
358
6d5eb5b0
SM
359 * gtkutil.c (xg_create_frame_widgets):
360 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
361 present with Gtk+ 2.0.
362
83aca1cb
PE
3632011-11-26 Paul Eggert <eggert@cs.ucla.edu>
364
365 * fileio.c (Finsert_file_contents): Undo previous change; see
366 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
367
5b76caa4
PE
3682011-11-26 Paul Eggert <eggert@cs.ucla.edu>
369
370 Rename locals to avoid shadowing.
371 * fileio.c (Finsert_file_contents):
372 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
373 * process.c (wait_reading_process_output):
374 Rename inner 'proc' to 'p' to avoid shadowing.
375 Indent for consistency with usual Emacs style.
376
8c535114
EZ
3772011-11-25 Eli Zaretskii <eliz@gnu.org>
378
379 * xdisp.c (redisplay_window): If cursor row is not fully visible
380 after recentering, and scroll-conservatively is set to a large
381 number, scroll window by a few more lines to make the cursor fully
382 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
383 (start_display): Don't move to the next line if the display should
384 start at a newline that is part of a display vector or an overlay
385 string. (Bug#10119)
8c535114 386
fa4fdb5c
JL
3872011-11-24 Juri Linkov <juri@jurta.org>
388
389 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
390 after the `MagickPingImage' call. (Bug#10112)
391
90ec88df
CY
3922011-11-23 Chong Yidong <cyd@gnu.org>
393
394 * window.c (Fcoordinates_in_window_p): Accept only live windows.
395
56e2e794
MR
3962011-11-23 Martin Rudalics <rudalics@gmx.at>
397
398 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
399 making another buffer current. (Bug#10114)
400
b6e64c41
GM
4012011-11-23 Glenn Morris <rgm@gnu.org>
402
403 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
404
6b21de18
CY
4052011-11-23 Chong Yidong <cyd@gnu.org>
406
407 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
408 using it (Bug#5984).
409
b12cd789
EZ
4102011-11-22 Eli Zaretskii <eliz@gnu.org>
411
412 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
413 and header-lines, as they don't have one computed for them.
414 (Bug#10098)
415
416 * .gdbinit (prow): Make displayed values more self-explaining.
417 Add row's hash code.
418
261b6fd4
LMI
4192011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
420
421 * process.c (wait_reading_process_output): Fix asynchrounous
422 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 423 (wait_reading_process_output): Add comment and URL.
261b6fd4 424
e7cfd277
JD
4252011-11-21 Jan Djärv <jan.h.d@swipnet.se>
426
427 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
428
a9b9b7f5
CY
4292011-11-21 Chong Yidong <cyd@gnu.org>
430
431 * window.c (Fnext_window, Fprevious_window): Doc fix.
432
b0d15b4f
SM
4332011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
434
435 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
436
fe7a3057
JB
4372011-11-20 Juanma Barranquero <lekktu@gmail.com>
438
439 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
440
d2999b1a
MR
4412011-11-20 Martin Rudalics <rudalics@gmx.at>
442
443 * window.c (Fset_window_combination_limit): Rename argument
444 STATUS to LIMIT.
445 (Vwindow_combination_limit): Remove "status" from doc-string.
446
d5ff9cd0
AS
4472011-11-20 Andreas Schwab <schwab@linux-m68k.org>
448
449 * m/ibms390.h: Remove.
450 * m/ibms390x.h: Don't include "ibms390.h".
451
a5bb9bd3
SM
4522011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
453
454 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
455 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
456
cd1181db
JB
4572011-11-20 Juanma Barranquero <lekktu@gmail.com>
458
459 * casetab.c (Fset_case_table):
460 * charset.c (Fcharset_after): Fix typos.
461
615a3b8d 4622011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 463
17e845af
PE
464 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
465 Otherwise, valgrind does not work on some platforms.
466 Problem reported by Andreas Schwab in
6a0bf43d
PE
467 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
468 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
469 is set, removing the need for VIRT_ADDRESS_VARIES.
470 (PURE_P): Use a more-efficient implementation that needs just one
471 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
472 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
473 to 4 (xorl, subq, cmpq, setbe).
474 * alloc.c (pure): Always extern now, since that's the
475 VIRT_ADDR_VARIES behavior.
476 (PURE_POINTER_P): Use a single comparison, not two, for
477 consistency with the new puresize.h.
478 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
479 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
480 Remove VIRT_ADDR_VARIES no longer needed.
481
f8fe6f96
EZ
4822011-11-19 Eli Zaretskii <eliz@gnu.org>
483
484 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
485 (erase_phys_cursor, update_window_cursor, show_mouse_face)
486 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
487 behave as if the cursor position were at the window margin.
488
489 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
490 and the cursor position is out of bounds, behave as if the cursor
491 position were at the window margin. (Bug#10075)
492
df05a53c
CY
4932011-11-18 Chong Yidong <cyd@gnu.org>
494
495 * window.c (Fwindow_combination_limit): Make first argument
496 non-optional, since it is meaningless for live windows like the
497 selected window.
498
2071918e
DA
4992011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
500
501 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
502
b50a28de
SM
5032011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
504
505 * intervals.c: Fix grafting over the whole buffer (bug#10071).
506 (graft_intervals_into_buffer): Simplify.
507
015137db
EZ
5082011-11-18 Eli Zaretskii <eliz@gnu.org>
509
510 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
511 hash values of the two rows.
512 (copy_row_except_pointers): Preserve the used[] arrays and the
513 hash values of the two rows. (Bug#10035)
68c95424 514 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
515
516 * xdisp.c (row_hash): New function, body extracted from
517 compute_line_metrics.
518 (compute_line_metrics): Call row_hash, instead of computing the
519 hash code inline.
520
521 * dispnew.c (verify_row_hash): Call row_hash for computing the
522 hash code of a row, instead of duplicating code from xdisp.c.
523
524 * dispextern.h (row_hash): Add prototype.
525
a2addb04
TH
5262011-11-18 Tassilo Horn <tassilo@member.fsf.org>
527
528 * frame.c (delete_frame): Don't delete the terminal when the last
529 X frame is closed if emacs is built with GTK toolkit.
530
df85d315
JB
5312011-11-17 Juanma Barranquero <lekktu@gmail.com>
532
533 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
534
a0c2d0ae
MR
5352011-11-17 Martin Rudalics <rudalics@gmx.at>
536
537 * window.c (Vwindow_splits): Rename to
538 Vwindow_combination_resize. Suggested by Juri Linkov.
539 (Fsplit_window_internal): Use Vwindow_combination_resize instead
540 of Vwindow_splits.
541
58179cce
JB
5422011-11-16 Juanma Barranquero <lekktu@gmail.com>
543
7877f373
JB
544 * nsfns.m (Fns_font_name):
545 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 546
b6f67890
MR
5472011-11-16 Martin Rudalics <rudalics@gmx.at>
548
549 * window.h (window): Rename slot "nest" to "combination_limit".
550 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
551 (Fset_window_nest): Rename to Fset_window_combination_limit.
552 (Vwindow_nest): Rename to Vwindow_combination_limit.
553 (recombine_windows, make_parent_window, make_window)
554 (Fsplit_window_internal, saved_window)
555 (Fset_window_configuration, save_window_save): Rename all
556 occurrences of window_nest to window_combination_limit.
557
c7015153
JB
5582011-11-15 Juanma Barranquero <lekktu@gmail.com>
559
560 * image.c (imagemagick_load_image): Fix typo.
561
322ad6ec
EZ
5622011-11-14 Eli Zaretskii <eliz@gnu.org>
563
564 * xdisp.c (display_line): Move the call to
565 highlight_trailing_whitespace before the call to
566 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
567 faces of all the glyphs to compute ROW's hash value.
568 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 569
f067b8ec
JB
5702011-11-14 Juanma Barranquero <lekktu@gmail.com>
571
572 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
573 just return (bug#10044).
574
1e5b2111
EZ
5752011-11-12 Eli Zaretskii <eliz@gnu.org>
576
7ef3cbd5
EZ
577 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
578 with user-defined heap size. Bump the default size of the temacs
579 heap to 27MB, to avoid memory warning when running temacs.
580 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
581
1e5b2111
EZ
582 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
583 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
584 (verify_row_hash) [XASSERTS]: New function.
585 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
586 that the hash value of glyph rows is correct.
1e5b2111 587
89d61221
MR
5882011-11-12 Martin Rudalics <rudalics@gmx.at>
589
590 * window.h (window): Remove splits slot.
591 * window.c (Fwindow_splits, Fset_window_splits): Remove.
592 (Fdelete_other_windows_internal, make_parent_window)
593 (make_window, Fsplit_window_internal, Fdelete_window_internal)
594 (Fset_window_configuration, save_window_save): Don't deal with
595 split status of windows.
596 (saved_window): Remove splits slot.
597 (Vwindow_splits): Rewrite doc-string.
598
97f18cc8
JD
5992011-11-11 Jan Djärv <jan.h.d@swipnet.se>
600
601 * xfns.c (unwind_create_frame):
602 * nsfns.m (unwind_create_frame):
603 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
604 Vframe_list (Bug#9999).
605
22a648b4
DA
6062011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
607
0b381c7e 608 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 609
659afede
KH
6102011-11-11 Kenichi Handa <handa@m17n.org>
611
612 * callproc.c (Fcall_process): Set the member dst_multibyte of
613 process_coding.
614
9ac0394b
KH
6152011-11-11 Johan Bockgård <bojohan@gnu.org>
616
617 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
618 avoid a crash (bug#9496).
619
2fbdc249
CY
6202011-11-09 Chong Yidong <cyd@gnu.org>
621
622 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
623 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
624
ac6b1f81
PE
6252011-11-08 Paul Eggert <eggert@cs.ucla.edu>
626
627 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
628
09db192c
PE
6292011-11-08 Paul Eggert <eggert@cs.ucla.edu>
630
631 Avoid some portability problems by eschewing 'extern inline' functions.
632 The trivial performance wins aren't worth the portability hassles; see
633 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
634 et seq.
635 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
636 (window_box_width, window_box_left, window_box_left_offset)
637 (window_box_right, window_box_right_offset): Undo previous change,
638 by removing the "extern"s.
639 * intervals.c (adjust_intervals_for_insertion)
640 (adjust_intervals_for_deletion): Undo previous change,
641 making these static again.
642 (offset_intervals, temp_set_point_both, temp_set_point)
643 (copy_intervals_to_string): No longer inline.
644 * xdisp.c (window_text_bottom_y, window_box_width)
645 (window_box_height, window_box_left_offset)
646 (window_box_right_offset, window_box_left, window_box_right)
647 (window_box): No longer inline.
648
105216ed
CY
6492011-11-08 Chong Yidong <cyd@gnu.org>
650
651 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
652 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
653 Signal an error if not a live window.
105216ed
CY
654 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
655 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
656
ae9e237f
JB
6572011-11-07 Juanma Barranquero <lekktu@gmail.com>
658
659 * lisp.h (syms_of_abbrev): Remove declaration.
660 Reported by CHENG Gao <chenggao@royau.me>.
661
c7aa8333
EZ
6622011-11-07 Eli Zaretskii <eliz@gnu.org>
663
664 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
665 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
666 of temacs in GUI mode.
667
be7f5545
MR
6682011-11-07 Martin Rudalics <rudalics@gmx.at>
669
670 * window.h: Declare delete_all_child_windows instead of
671 delete_all_subwindows.
672 * window.c (Fwindow_nest, Fset_window_nest)
673 (Fset_window_new_total, Fset_window_new_normal)
674 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
675 (delete_all_subwindows): Rename to delete_all_child_windows.
676 (Fdelete_other_windows_internal, Fset_window_configuration):
677 Call delete_all_child_windows instead of delete_all_subwindows.
678 * frame.c (delete_frame): Call delete_all_child_windows instead
679 of delete_all_subwindows.
680
ca78dc43
PE
6812011-11-07 Paul Eggert <eggert@cs.ucla.edu>
682
683 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
684 This is also needed for porting to any host where GC_MARK_STACK is
685 not GC_MAKE_GCPROS_NOOPS.
686 (which_symbols): Use it.
687
a0241d01
KH
6882011-11-07 Kenichi Handa <handa@m17n.org>
689
690 * coding.c (coding_set_destination): Check coding->src_pos only
691 when coding->src_object is a buffer (bug#9910).
692
693 * process.c (send_process): Set the member src_multibyte of coding
694 to 0 (bug#9911) when sending a unibyte text.
695
696 * callproc.c (Fcall_process): Set the member src_multibyte of
697 process_coding to 0 (bug#9912).
698
a64bfdfa 6992011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
700
701 * xmenu.c (cleanup_widget_value_tree): New function.
702 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
703 calling free_menubar_widget_value_tree directly (Bug#9830).
704
cb41b32a
PE
7052011-11-06 Paul Eggert <eggert@cs.ucla.edu>
706
707 Fix some portability problems with 'inline'.
708 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
709 (window_box_width, window_box_left, window_box_left_offset)
710 (window_box_right, window_box_right_offset): Declare extern.
711 Otherwise, these inline functions do not conform to C99 and
712 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
713 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
714 * intervals.c (adjust_intervals_for_insertion)
715 (adjust_intervals_for_deletion): Now extern, because otherwise the
716 extern inline functions 'offset_intervals' couldn't refer to it.
717 (static_offset_intervals): Remove.
718 (offset_intervals): Rewrite using the old contents of
719 static_offset_intervals. The old version didn't conform to C99
720 because an extern inline function contained a reference to an
721 identifier with static linkage.
722
b7041366
AS
7232011-11-06 Andreas Schwab <schwab@linux-m68k.org>
724
725 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
726 GC.
727
88a37c4d
EZ
7282011-11-06 Eli Zaretskii <eliz@gnu.org>
729
730 * xdisp.c (init_iterator, reseat_to_string): Don't set the
731 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
732 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
733 return Qleft_to_right.
734
49745b39
CY
7352011-11-06 Chong Yidong <cyd@gnu.org>
736
737 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
738 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
739 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
740 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
741 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
742 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
743 (Fwindow_vscroll): Doc fix.
744 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
745 argument, since it makes no sense to pass a live window and for
746 consistency with window-child.
747
1f05cd82
CS
7482011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
749
750 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
751 support MSVC.
752
22610910
JR
7532011-11-05 Jason Rumney <jasonr@gnu.org>
754
755 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
756 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
757 fonts (Bug#6029).
758 (add_font_entity_to_list): Fix logic errors in mixed boolean and
759 bitwise arithmetic preventing use of unicode-sip and non-truetype
760 opentype fonts.
761
a06776b2
EZ
7622011-11-05 Eli Zaretskii <eliz@gnu.org>
763
3ad924ba
EZ
764 * s/ms-w32.h (fstat, stat, utime): Move redirections to
765 "emacs"-only part.
766
a06776b2
EZ
767 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
768 initialization code to keep similarity to xfns.c after changes
769 from 2011-11-05.
770
c9e7db78
JD
7712011-11-05 Jan Djärv <jan.h.d@swipnet.se>
772
a97f8f3f
JD
773 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
774 (unwind_create_frame): New function (Bug#9943).
775 (Fx_create_frame): Restructure code to be more similar to the one in
776 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
777 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
778 Move terminal->reference_count++ just before making the frame official
779 (Bug#9943).
780
781 * nsterm.m (x_free_frame_resources): New function.
782 (x_destroy_window): Move code to x_free_frame_resources.
783
c9e7db78 784 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
785 (Fx_create_frame, x_create_tip_frame):
786 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
787 official. Move initialization of image_cache_refcount and
788 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
789
a6fc3b5c
EZ
7902011-11-05 Eli Zaretskii <eliz@gnu.org>
791
792 Support MSVC build with newer versions of Visual Studio.
793 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
794 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
795 nt/gmake.defs.
796
797 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
798 which are not supported by MSVC.
799 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
800 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
801 bitfields.
802 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
803 types in bitfields.
804 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
805
806 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
807
58179cce 8082011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
809
810 Support MSVC build with newer versions of Visual Studio.
811 * w32.c: Don't include w32api.h for MSVC.
812 (init_environment) [_MSC_VER]: Call sys_access, not _access.
813
814 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
815 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
816 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
817 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
818 e_* cousins.
819 (alloca) [_MSC_VER]: Define to _alloca.
820
821 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
822
823 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
824
a58c13ed
EZ
8252011-11-04 Eli Zaretskii <eliz@gnu.org>
826
827 * xdisp.c (note_mouse_highlight): If either of
828 previous/next-single-property-change returns nil, treat that as
829 the beginning or the end of the buffer. (Bug#9955)
830
fe0b6370
JD
8312011-11-04 Jan Djärv <jan.h.d@swipnet.se>
832
a58c13ed 833 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
834 label is not null (Bug#9951).
835 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
836 may be NULL.
837
89bd5ee1
EZ
8382011-11-04 Eli Zaretskii <eliz@gnu.org>
839
840 * window.c (Fwindow_body_size): Mention in the doc string that the
841 return value is in frame's canonical units. (Bug#9949)
842
84c3edb9
EZ
8432011-11-03 Eli Zaretskii <eliz@gnu.org>
844
4e2fb5c7
EZ
845 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
846
84c3edb9 847 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 848 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 849 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 850
bc17a887
EZ
8512011-11-01 Eli Zaretskii <eliz@gnu.org>
852
853 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
854 Don't stop backward scan on the continuation glyph, even though
855 its CHARPOS is positive.
6d5eb5b0
SM
856 (mouse_face_from_buffer_pos, note_mouse_highlight):
857 Rename cover_string to disp_string.
bc17a887 858
4ee88440
MR
8592011-11-01 Martin Rudalics <rudalics@gmx.at>
860
861 * window.c (temp_output_buffer_show): Don't use
862 Vtemp_buffer_show_specifiers.
863 (Vtemp_buffer_show_specifiers): Remove unused variable.
864
c2ff3c02
EZ
8652011-10-30 Eli Zaretskii <eliz@gnu.org>
866
867 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
868 past the beginning of the current glyph matrix.
869
58179cce 8702011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
871
872 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
873 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
874 HAVE_GTK3 (Bug#9869).
b77a6a7f 875
3b574623
JD
876 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
877 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
878
b77a6a7f
JD
879 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
880
881 * xterm.c: Declare x_handle_net_wm_state to return int.
882 (handle_one_xevent): Check if we are iconified but don't have
883 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
884 (get_current_wm_state): Return non-zero if not hidden,
885 check for _NET_WM_STATE_HIDDEN (Bug#9893).
886 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
887 (x_handle_net_wm_state): Return what get_current_wm_state returns.
888 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
889
196e41e4
PE
8902011-10-29 Paul Eggert <eggert@cs.ucla.edu>
891
892 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
893 so that this new function doesn't get optimized away by a
894 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
895
021f2e1a
AS
8962011-10-29 Andreas Schwab <schwab@linux-m68k.org>
897
898 * frame.h (MOUSE_HL_INFO): Remove excess parens.
899
8b058d44
EZ
9002011-10-29 Eli Zaretskii <eliz@gnu.org>
901
902 Fix the `xbytecode' command.
903 * .gdbinit (xprintbytestr): New command.
b50a28de 904 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
905 (xbytecode): Print the byte-code string as well.
906
4452fb80
EZ
9072011-10-29 Kim Storm <storm@cua.dk>
908
8b058d44
EZ
909 * alloc.c (which_symbols): New function.
910
21b72067
AS
9112011-10-29 Andreas Schwab <schwab@linux-m68k.org>
912
913 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
914 line. (Bug#9903)
915
83ed7b5c
GM
9162011-10-29 Glenn Morris <rgm@gnu.org>
917
918 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
919 Not clear what it was for, and it causes various bugs. (Bug#9839)
920
5a7a728b
EZ
9212011-10-28 Eli Zaretskii <eliz@gnu.org>
922
923 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
924 possible random value that matches one of those tested as
925 condition to clear the mouse face.
926
d3d0842f
CY
9272011-10-28 Chong Yidong <cyd@gnu.org>
928
929 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
930
31b39d13
DN
9312011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
932
933 * window.c (make_window): Initialize phys_cursor_on_p.
934
9aba6043
SM
9352011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
936
937 * lisp.h (struct Lisp_Symbol): Update comments.
938
c20992f4
JB
9392011-10-28 Juanma Barranquero <lekktu@gmail.com>
940
941 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
942
db4f02f2
EZ
9432011-10-28 Eli Zaretskii <eliz@gnu.org>
944
945 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
946 <oslsachem@gmail.com> for helping to debug this.
947
948 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
949 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
950 (g_b_init_get_glyph_outline_w): New static variables.
951 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
952 (GetGlyphOutlineW_Proc): New typedefs.
953 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
954 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
955 New functions.
956 (w32font_open_internal, compute_metrics):
957 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
958 instead of calling the "wide" APIs directly.
959
960 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
961
962 * w32.h (syms_of_w32font): Add prototype.
963
87e68db4
JB
9642011-10-27 Juanma Barranquero <lekktu@gmail.com>
965
966 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
967 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
968 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
969 (Fmove_to_window_line): Doc fix.
970
435c1d67
CY
9712011-10-27 Chong Yidong <cyd@gnu.org>
972
973 * process.c (make_process): Set gnutls_state to NULL.
974
975 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
976 non-NULL, regardless of GNUTLS_INITSTAGE.
977 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
978 an error. Set process slots as soon as we allocate them.
979
980 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
981
9c6c6f49
CY
9822011-10-27 Chong Yidong <cyd@gnu.org>
983
9aba6043
SM
984 * gnutls.c (emacs_gnutls_deinit): New function.
985 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
986 (Fgnutls_deinit, Fgnutls_boot): Use it.
987
988 * process.c (make_process): Initialize GnuTLS credentials to NULL.
989 (deactivate_process): Call emacs_gnutls_deinit.
990
657d08d3
JB
9912011-10-27 Juanma Barranquero <lekktu@gmail.com>
992
993 * image.c (x_create_x_image_and_pixmap):
994 * w32.c (sys_rename, w32_delayed_load):
995 * w32font.c (fill_in_logfont):
996 * w32reg.c (x_get_string_resource): Silence compiler warnings.
997
5430d399
JB
9982011-10-26 Juanma Barranquero <lekktu@gmail.com>
999
1000 * w32fns.c (w32_default_color_map): New function,
1001 extracted from Fw32_default_color_map.
a7ef684b 1002 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1003
fe0055fa
PE
10042011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1005
1006 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1007
e6346438
SM
10082011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1009
1010 * keyboard.c (test_undefined): New function (bug#9751).
1011 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1012
e112cc37
ET
10132011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1014
1015 * sysdep.c (init_sys_modes): Fix the check for the controlling
1016 terminal (Bug#6649).
1017
7b5d6677
EZ
10182011-10-20 Eli Zaretskii <eliz@gnu.org>
1019
1020 * dispextern.h (struct bidi_it): New member next_en_type.
1021
1022 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1023 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1024 current character, check also for next_en_type being WEAK_EN.
1025 (bidi_resolve_weak): Don't enter the expensive loop if the current
1026 position is before next_en_pos. Record the bidi type of the first
1027 non-ET, non-BN character we find, in addition to its position.
1028 (bidi_level_of_next_char): Invalidate next_en_type when
1029 next_en_pos is over-stepped.
1030
7da0b018
PE
10312011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1032
1033 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1034 * editfns.c: Rewrite current-time-zone so that it invokes
1035 the equivalent of (format-time-string "%Z") to get the time zone name.
1036 This fixes a bug when the time zone name contains characters that
1037 need converting from the system time locale to Emacs internal format.
1038 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1039 that patch fixed format-time-string to do the conversion, but
1040 I forgot to fix current-time-zone.
1041 (format_time_string): New function, containing most of
1042 what Fformat_time_string used to contain.
1043 (Fformat_time_string): Rewrite in terms of format_time_string.
1044 This doesn't change this function's behavior.
1045 (current-time-zone): Rewrite to use format_time_string.
1046 This fixes the bug reported by Michael Schierl in
1047 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1048 Jason Rumney's 2007-06-07 change worked around this bug, but
1049 didn't fix it.
1050 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1051
8547b010
EZ
10522011-10-19 Eli Zaretskii <eliz@gnu.org>
1053
1054 * xdisp.c (start_display): If the character at POS is displayed
1055 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1056 (try_window_reusing_current_matrix): If a line ends in a display
1057 vector or the next line starts in a display vector, continue
1058 redrawing the window even though the character position of
1059 start_row was reached.
8547b010
EZ
1060 (Bug#9771, part 2)
1061
4e948d15
CY
10622011-10-18 Chong Yidong <cyd@gnu.org>
1063
1064 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1065 with nobreak-char-display too.
1066
4787455f
EZ
10672011-10-18 Eli Zaretskii <eliz@gnu.org>
1068
1069 Fix part 3 of bug#9771.
1070 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1071 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1072 non-neutral characters if the current character is a paragraph
1073 separator (a.k.a. Newline). This avoids running the same
1074 expensive loop twice, once when we consume the preceding newline
1075 and the other time when the line actually needs to be displayed.
1076 Avoid the loop when we see neutrals on the base embedding level
1077 following a character whose directionality is the same as the
1078 paragraph's. This avoids running the expensive loop when a line
1079 ends in a long sequence of neutrals, like control characters.
1080 Add assertion against STRONG_AL type. Slightly rearrange code
1081 that determines the type of a neutral given the first non-neutral
1082 that follows it.
1083 (bidi_level_of_next_char): Set next_en_pos to zero when
1084 invalidating its info.
1085
2c91f553
EZ
10862011-10-17 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (push_display_prop): Determine whether to record string
1089 or buffer position by IT->string, not by IT->method. Allow
1090 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1091 (move_it_vertically_backward): Don't look for character position
1092 immediately after the newline when in a continuation line.
1093 (Bug#9771, part 1)
2c91f553 1094
c7b08b0d
MR
10952011-10-15 Martin Rudalics <rudalics@gmx.at>
1096
1097 * window.c (coordinates_in_window): Rewrite and delabelize
1098 vertical border check. (Bug#5357) (Bug#9618)
1099
6b02f655
SM
11002011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1101
1102 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1103 errors in XSetWindowBorder (bug#9310).
1104
81d40c92
DA
11052011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1106
1107 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1108 avoid crash when xmalloc overrun checking is enabled.
1109
d4172c3b
EZ
11102011-10-13 Eli Zaretskii <eliz@gnu.org>
1111
1112 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1113 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1114 cursor motion with <left> and <right> arrow keys.
1115
1116 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1117 some callers set that themselves.
1118
b00eea75
EZ
11192011-10-12 Eli Zaretskii <eliz@gnu.org>
1120
1121 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1122 display string and the previous row comes from the same string and
1123 is empty. (Bug#9739) (Bug#9738)
1124
8fe012c4
SM
11252011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1126
1127 * doc.c (get_doc_string): Encode file name (bug#9735).
1128
0074aef2
EZ
11292011-10-12 Eli Zaretskii <eliz@gnu.org>
1130
79beb178
EZ
1131 * bidi.c (bidi_level_of_next_char):
1132 * xdisp.c (get_visually_first_element): Remove old incorrect
1133 comments regarding the Unicode Line Separator character.
1134
0074aef2
EZ
1135 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1136
6e4b3fbe
DA
11372011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1138
1139 * alloc.c (Fgc_status): Do not access beyond zombies array
1140 boundary if nzombies > MAX_ZOMBIES.
1141 * alloc.c (dump_zombies): Add missing format specifier.
1142
0324f3af
PE
11432011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1144
b5525cac
PE
1145 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1146 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1147
0324f3af
PE
1148 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1149 Some packages use them to denote characters with modifiers.
1150
e9b5f888
AS
11512011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1152
1153 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1154 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1155 matching a pp-number. Rename parameter var to var1.
1156
127827c0
SM
11572011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1158
1159 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1160
c8fd3bd0
GM
11612011-10-08 Glenn Morris <rgm@gnu.org>
1162
1163 * callint.c (Fcall_interactively): Give a more explicit error for the
1164 'c' case with a non-character input. (Bug#8479)
1165
352ec8ff
EZ
11662011-10-08 Eli Zaretskii <eliz@gnu.org>
1167
03669ccb
EZ
1168 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1169 lines.
7061c986
EZ
1170 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1171 lines that are hscrolled on the left.
03669ccb 1172
352ec8ff
EZ
1173 * dispnew.c (buffer_posn_from_coords): Account for a possible
1174 presence of header-line. (Bug#4426)
1175
a66cfb1c
SM
11762011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1177
6b02f655
SM
1178 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1179 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1180
7c5ee88e
PE
11812011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1182
1183 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1184 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1185 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1186 this makes Emacs dump core during garbage collection on rare
1187 occasions. sizeof is obviously inferior to offsetof here, so
1188 stick with offsetof.
1189 (GC_POINTER_ALIGNMENT): New macro.
1190 (mark_memory): Omit 3rd (offset) arg; caller changed.
1191 Don't assume EMACS_INT alignment is the same as pointer alignment.
1192
df1bbe5b
SM
11932011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1194
1195 * keyboard.c (read_key_sequence_remapped): New var.
1196 (read_key_sequence): Compute remapping in the right buffer.
1197 (command_loop_1): Use read_key_sequence's remapping directly.
1198
51553db6
SM
11992011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1200
32c1fffd
SM
1201 * dired.c (file_name_completion): Don't expand file name.
1202 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1203 before checking file name handler.
1204
51553db6
SM
1205 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1206 they've been requested explicitly (bug#9591).
1207
b6bd1599 12082011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1209
1210 * keymap.c (Fsingle_key_description): Use make_specified_string
1211 instead of build_string to build string from push_key_description.
1212 (Bug#5193)
1213
f701dc2a
PE
12142011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1215
4222c55d
PE
1216 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1217 This fixes a Y2038 bug on 64-bit hosts.
1218 * buffer.c (reset_buffer):
1219 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1220 (Fclear_buffer_auto_save_failure):
1221 Use 0, not -1, to represent an unset failure time, since time_t
1222 might not be signed.
1223
f701dc2a
PE
1224 Remove dependency on glibc malloc internals.
1225 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1226 Move back here from lisp.h, but with their new implementations.
1227 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1228 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1229 * charset.c (charset_table_init): New static var.
1230 (syms_of_charset): Use it instead of xmalloc. This removes a
1231 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1232 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1233 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1234 Move back to alloc.c.
1235 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1236 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1237
9ceebf39
JD
12382011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1239
1240 * nsterm.m (windowDidResize): Call x_set_window_size only when
1241 ns_in_resize is true. Otherwise set pixelwidth/height and
1242 call change_frame_size (Bug#9628).
1243
cb993c58
PE
12442011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1245
3930c88b
PE
1246 Port --enable-checking=all to Fedora 14 x86-64.
1247 * charset.c (syms_of_charset): Also account for glibc malloc's
1248 internal overhead when calculating the initial malloc maximum.
1249
cb993c58
PE
1250 Port --enable-checking=all to Fedora 14 x86.
1251 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1252 Move to lisp.h.
1253 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1254 (overrun_check_realloc, overrun_check_free):
1255 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1256 That way, xmalloc returns a properly-aligned pointer even if
1257 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1258 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1259 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1260 into account when calculating the initial malloc maximum.
1261 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1262 Move here from alloc.c, so that charset.c can use it too.
1263 Properly align; the old code wasn't right for common 32-bit hosts
1264 when configured with --enable-checking=all.
1265 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1266 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
1267
31bed486
EZ
12682011-09-29 Eli Zaretskii <eliz@gnu.org>
1269
04c70788 1270 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
1271 use EDOM.
1272
fbcaa2f3
EZ
12732011-09-28 Eli Zaretskii <eliz@gnu.org>
1274
1275 * xdisp.c (compute_display_string_end): If there's no display
1276 string at CHARPOS, return -1.
1277
1278 * bidi.c (bidi_fetch_char): When compute_display_string_end
1279 returns a negative value, treat the character as a normal
1280 character not covered by a display string. (Bug#9624)
1281
a239d4e9
JB
12822011-09-28 Juanma Barranquero <lekktu@gmail.com>
1283
1284 * lread.c (Fread_from_string): Fix typo in docstring.
1285
88652fd5
EZ
12862011-09-27 Eli Zaretskii <eliz@gnu.org>
1287
1288 * xdisp.c (handle_invisible_prop): If invisible text ends on a
1289 newline, reseat the iterator instead of bidi-iterating there one
1290 character at a time. (Bug#9610)
32c1fffd
SM
1291 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
1292 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 1293
ed497dd4
AS
12942011-09-27 Andreas Schwab <schwab@linux-m68k.org>
1295
1296 * lread.c (readevalloop): Use correct code for NBSP.
1297 (read1): Likewise. (Bug#9608)
1298
b2bf61aa
MA
12992011-09-25 Michael Albinus <michael.albinus@gmx.de>
1300
1301 * dbusbind.c (Fdbus_register_signal): When service is not
1302 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
1303
32bbb17c
GM
13042011-09-25 Glenn Morris <rgm@gnu.org>
1305
1306 * buffer.c (truncate-lines): Doc fix.
1307
94e0933e
CY
13082011-09-24 Chong Yidong <cyd@stupidchicken.com>
1309
1310 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
1311 (Fset_window_next_buffers): Doc fix.
1312
cddde921
GM
13132011-09-24 Glenn Morris <rgm@gnu.org>
1314
1315 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
1316
1260aef1
PE
13172011-09-24 Paul Eggert <eggert@cs.ucla.edu>
1318
25b4bfa0
PE
1319 Fix minor problems found by static checking.
1320 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
1321 * indent.c (Fvertical_motion): Fix == vs = typo.
1322
e3cbd34b
EZ
13232011-09-24 Eli Zaretskii <eliz@gnu.org>
1324
a66cfb1c
SM
1325 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1326 Default value is now t. Doc fix.
6bf7006f 1327
e3cbd34b 1328 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1329 logic when moving up, not only when moving down. Fix the
e3cbd34b 1330 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1331 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1332
1333 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1334 CHARPOS is covered by a display string which includes newlines.
1335 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1336 is covered by a display string with embedded newlines.
1337
a3de0cbd
MA
13382011-09-24 Michael Albinus <michael.albinus@gmx.de>
1339
1340 * dbusbind.c (Fdbus_register_signal): Add match rule to
1341 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1342 (Fdbus_register_method, Vdbus_registered_objects_table):
1343 Fix docstring.
a3de0cbd 1344
b260039d
JM
13452011-09-24 Jim Meyering <meyering@redhat.com>
1346
32c1fffd 1347 do not ignore write error for any output size
b260039d
JM
1348 The previous change was incomplete.
1349 While it makes emacs --batch detect the vast majority of stdout
1350 write failures, errors were still ignored whenever the output size is
1351 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1352 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1353 && echo FAIL: ignored write error
1354 FAIL: ignored write error
1355 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1356 && echo FAIL: ignored write error
1357 FAIL: ignored write error
1358 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1359
8eca8a7c
AS
13602011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1361
1362 * emacs.c (Fkill_emacs): In noninteractive mode exit
1363 non-successfully if a write error occurred on stdout. (Bug#9574)
1364
3341db62
EZ
13652011-09-21 Eli Zaretskii <eliz@gnu.org>
1366
1367 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1368 the xassert test.
1369
1370 * dispextern.h (struct it): Update the comment documenting what
1371 can it->OBJECT be.
1372
8c203dbf
EZ
13732011-09-20 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1376 a display string, extend search for cursor position to end of row.
1377 (find_row_edges): If the row ends in a newline from a display
1378 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1379 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1380 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1381 non-empty line. Fixes confusing cursor motion with arrow keys at
1382 the beginning of a line that starts with whitespace.
8c203dbf 1383
a4824228
LMI
13842011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1385
1386 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1387 (bug#9493).
1388
33ed493b
CY
13892011-09-18 Chong Yidong <cyd@stupidchicken.com>
1390
1391 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1392 boolean (Bug#9154).
1393
56cd55c8
EZ
13942011-09-18 Eli Zaretskii <eliz@gnu.org>
1395
1396 * xdisp.c (display_line): Record maximum and minimum buffer
1397 positions even if no glyphs were produced (e.g., by a zero-width
1398 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1399 buffer positions that will be removed from the glyph row because
1400 they don't fit.
c02dcedf
EZ
1401 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1402 column is beyond frame width: don't subtract 1 "pixel" when
1403 computing width of the stretch.
3e62b7e0
EZ
1404 (reseat_at_next_visible_line_start): Undo the change made on
1405 2011-09-17 that saved paragraph information and restored it after
1406 the call to `reseat'. (Bug#9545)
56cd55c8 1407
5ed99d36 14082011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1409
1410 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1411 and turn window cursor on if cleared (Bug#9415).
1412
5ed99d36 14132011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1414
1415 * search.c (boyer_moore): Take unibyte characters from pattern
1416 literally. (Bug#9458)
1417
9bade7b2
EZ
14182011-09-18 Eli Zaretskii <eliz@gnu.org>
1419
1420 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1421
e5e9d610
PE
14222011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1423
87e4427a
PE
1424 Fix minor problem found by static checking.
1425 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1426 initialized, to pacify gcc -Wuninitialized.
1427
e5e9d610
PE
1428 * fileio.c: Report proper errno when syscall falls.
1429 (Finsert_file_contents): Save and restore errno,
1430 so that report_file_error outputs the correct diagnostic.
1431 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1432
a1674f0b
EZ
14332011-09-18 Eli Zaretskii <eliz@gnu.org>
1434
1435 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1436
fbfb6dd4
EZ
14372011-09-17 Eli Zaretskii <eliz@gnu.org>
1438
1439 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1440 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1441
bb187662
EZ
14422011-09-17 Eli Zaretskii <eliz@gnu.org>
1443
1137e8b8 1444 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1445 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1446
1447 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1448 (bidi_find_paragraph_start): Search back for paragraph beginning
1449 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1450 (bidi_move_to_visually_next): Only trigger paragraph-related
1451 computations when the last character is a newline or at EOB, not
1452 just any NEUTRAL_B. (Bug#9470)
1453
bb187662
EZ
1454 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1455 truncated lines if point is covered by a display string. (Bug#9524)
1456
2e621251
PE
14572011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1458
1459 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1460 (cons_to_x_long): New function.
1461 (lisp_data_to_selection_data): Use it. Correct the test for
1462 short-versus-long data; it was negated. Break out of vector
1463 loop, for efficiency, when a long datum is discovered.
1464
91a15bc6
SM
14652011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1466
1467 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1468
b41c3a35
EZ
14692011-09-16 Eli Zaretskii <eliz@gnu.org>
1470
1471 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1472 GCC PR/17406) by declaring this function with external scope.
1473
7812ba2d
PE
14742011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1475
1476 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1477 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1478
cf7edc2a
AS
14792011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1480
1481 * editfns.c (Fformat): Correctly handle text properties on "%%".
1482
bd01620e
EZ
14832011-09-15 Eli Zaretskii <eliz@gnu.org>
1484
1485 * xterm.c (x_draw_composite_glyph_string_foreground):
1486 * w32term.c (x_draw_composite_glyph_string_foreground):
1487 * term.c (encode_terminal_code):
1488 * composite.c (composition_update_it, get_composition_id):
1489 * xdisp.c (get_next_display_element)
1490 (fill_composite_glyph_string): Add comments about special meaning
1491 of TAB characters in a composition.
1492
a02719a3
PE
14932011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1494
1495 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1496 This occurs when processing a multibyte format.
1497 Problem reported by Wolfgang Jenker.
a02719a3 1498
72589a3c
JB
14992011-09-15 Johan Bockgård <bojohan@gnu.org>
1500
1501 * xdisp.c (try_cursor_movement): Only check for exact match if
1502 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1503
1c14176c
PE
15042011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1505
1506 Remove unused external symbols.
1507 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1508 * xdisp.c (calc_pixel_width_or_height): Now static.
1509 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1510 * indent.c (check_display_width):
1511 * w32term.c: Fix comment to match code.
1512 * xterm.c, xterm.h (x_catching_errors): Remove.
1513
d2eea5b5
PE
15142011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1515
1516 * xselect.c: Use signed conversions more consistently (Bug#9498).
1517 (selection_data_to_lisp_data): Assume incoming selection data are
1518 signed integers, not unsigned. This is to be consistent with
1519 outgoing selection data, which was modified to use signed integers
1520 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1521 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1522 expects long, not unsigned long.
1523
46888499
EZ
15242011-09-14 Eli Zaretskii <eliz@gnu.org>
1525
1526 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1527 computation of loop end. Reported by Johan Bockgård
1528 <bojohan@gnu.org>.
1529
ef8ef9fb
CY
15302011-09-13 Chong Yidong <cyd@stupidchicken.com>
1531
1532 * frame.c (Fother_visible_frames_p): Function deleted.
1533
fa819fed
EZ
15342011-09-12 Eli Zaretskii <eliz@gnu.org>
1535
1536 * indent.c (compute_motion): Process display vector front to back
1537 rather than the other way around. (Bug#2496)
1538
2ba8e008
SM
15392011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1540
1541 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1542
20f53c69
CY
15432011-09-11 Chong Yidong <cyd@stupidchicken.com>
1544
1545 * minibuf.c (Fread_from_minibuffer): Doc fix.
1546
d562d7a4
EZ
15472011-09-11 Eli Zaretskii <eliz@gnu.org>
1548
1549 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1550 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1551
1c4d7f3d
LMI
15522011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1553
1554 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1555 value for non-existent files.
1556
b885bf36
EZ
15572011-09-11 Eli Zaretskii <eliz@gnu.org>
1558
1559 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1560 set its "size" to -1. This will set the modtime_size field of
1561 the corresponding buffer to -1, which is what
1562 verify-visited-file-modtime expects for files that do not exist.
1563 (Bug#9139)
1564
6612f0bf
PE
15652011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1566
1567 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1568 here ...
1569 * lisp.h: ... from here. push_key_description is no longer
1570 defined in keyboard.c, so its declaration should not be in
1571 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1572 logically belongs with push_key_description.
1573
dfb3f755
PE
15742011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1575
1576 * buffer.h: Include <sys/types.h> instead of <time.h>.
1577 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1578 Problem reported by Herbert J. Skuhra.
1579
3134906c
LMI
15802011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1581
1582 * xml.c (parse_region): Make the parsing work for
1583 non-comment-starting XML files again (bug#9144).
1584
8d903f4e
AS
15852011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1586
1587 * image.c (gif_load): Fix calculation of bottom and right corner.
1588 (Bug#9468)
1589
80ad64f4
EZ
15902011-09-10 Eli Zaretskii <eliz@gnu.org>
1591
1592 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1593 redisplay in small windows.
1594
208a048d
EZ
15952011-09-09 Eli Zaretskii <eliz@gnu.org>
1596
1597 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1598
9b1c252e
MR
15992011-09-08 Martin Rudalics <rudalics@gmx.at>
1600
1601 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1602 Operate on live windows only.
1603
2949f33b
JB
16042011-09-08 Juanma Barranquero <lekktu@gmail.com>
1605
1606 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1607
e08dcafd
EZ
16082011-09-07 Eli Zaretskii <eliz@gnu.org>
1609
1610 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1611 only under bidi iteration.
1612
115b96bd
JD
16132011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1614
1615 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1616
c8199d0f
PE
16172011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1618
1619 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1620 Without this fix, the command to link temacs failed due to an
1621 undefined symbol __builtin_isnan. This is because
1622 /usr/include/iso/math_c99.h #defines isnan(x) to
1623 __builtin_isnan(x), but the bundled gcc, which identifies itself
1624 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1625 a __builtin_isnan.
1626 * floatfns.c (isnan): #undef, and then #define to a clone of
1627 what's in data.c.
1628 (Fisnan): Always define, since it's always available now.
1629 (syms_of_floatfns): Always define isnan at the Lisp level.
1630
e39b275c 16312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1632
1633 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1634
b2db44d9 16352011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1636
f4af5137 1637 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1638 The previous code assumed that file offsets (off_t values) fit in
1639 EMACS_INT variables, which is not true on typical 32-bit hosts.
1640 The code messed up by falsely reporting buffer overflow in cases
1641 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1642 when "big" contains more than 2**29 bytes, even though this
1643 inserts just one byte and does not overflow the buffer.
1644 (Finsert_file_contents): Store file offsets as off_t
1645 values, not as EMACS_INT values. Check for overflow when
1646 converting between EMACS_INT and off_t. When checking for
1647 buffer overflow or for overlap, take the offsets into account.
1648 Don't use EMACS_INT for small values where int suffices.
1649 When checking for overlap, fix a typo: ZV was used where
1650 ZV_BYTE was intended.
1651 (Fwrite_region): Don't assume off_t fits into 'long'.
1652 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1653
ecfc0a49
MA
16542011-09-05 Michael Albinus <michael.albinus@gmx.de>
1655
1656 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1657
6511acf2 16582011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1659
0999621a 1660 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1661
1662 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1663 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1664 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1665 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1666 (modify_event_symbol): Do not assume that the length of
1667 name_alist_or_stem is safe to alloca and fits in int.
1668 (Fexecute_extended_command): Likewise for function name and binding.
1669 (Frecursion_depth): Wrap around reliably on integer overflow.
1670 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1671 since some callers pass EMACS_INT values.
1672 (Fsingle_key_description): Don't crash if symbol name contains more
1673 than MAX_ALLOCA bytes.
1674 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1675 (get_minibuffer): Arg is now EMACS_INT, not int.
1676 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1677 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1678 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1679
2be7d702
PE
1680 * dbusbind.c (signature_cat): New function.
1681 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1682 Do not overrun buffer; instead, report string overflow.
1683
9d1df220
PE
1684 * dispnew.c (add_window_display_history): Don't overrun buffer.
1685 Truncate instead; this is OK since it's just a log.
1686
33ef5c64
PE
1687 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1688 even if the time zone offset is outlandishly large.
1689 Don't mishandle offset == INT_MIN.
1690
66c6fdd5
PE
1691 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1692 when creating daemon; the previous buffer-overflow check was incorrect.
1693
d749b01b
PE
1694 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1695 which has the guts of the old verror function.
1696
b5cd1905
PE
1697 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1698 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1699
6e1a67fb
PE
1700 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1701 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1702 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1703 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1704 length of string rather than counting it via multiple sprintfs;
1705 that's simpler and more reliable.
c21721cc
PE
1706 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1707 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1708 sprintf, in case result does not fit in int.
1709
c57b67fc
PE
1710 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1711 (fontset_from_font): Print it.
1712
8a401434
PE
1713 * frame.c (tty_frame_count): Now printmax_t, not int.
1714 (make_terminal_frame, set_term_frame_name): Print it.
1715 (x_report_frame_params): In X, window IDs are unsigned long,
1716 not signed long, so print them as unsigned.
1717 (validate_x_resource_name): Check for implausibly long names,
1718 and don't assume name length fits in 'int'.
1719 (x_get_resource_string): Don't blindly alloca invocation name;
1720 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1721 not fit in int.
1722
6e1a67fb
PE
1723 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1724 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1725 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1726
0df02bf3
PE
1727 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1728 Use esprintf, not sprintf, in case result does not fit in int.
1729
48e30793
PE
1730 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1731 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1732 it as a large positive number.
1733 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1734 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1735
a66ff6d8
PE
1736 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1737 in case result does not fit in int.
1738
aca216ff
PE
1739 * print.c (float_to_string): Detect width overflow more reliably.
1740 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1741 buffer overrun. Don't assume list length fits in 'int'. Treat
1742 print length of 0 as 0, not as infinity; to be consistent with other
1743 uses of print length in this function. Don't overflow print length
1744 index. Don't assume hash table size fits in 'long', or that
1745 vectorlike size fits in 'unsigned long'.
1746
31c286f7
PE
1747 * process.c (make_process): Use printmax_t, not int, to format
1748 process-name gensyms.
1749
55e5faa1
PE
1750 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1751
80f2e268
PE
1752 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1753 to avoid potential buffer overrun.
1754
670741ab
PE
1755 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1756 if X resource line is longer than 512 bytes.
1757
b7163a50
PE
1758 * xfns.c (x_window): Make sprintf buffer a bit bigger
1759 to avoid potential buffer overrun.
1760
ae58ff1f
PE
1761 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1762
c43c8a6a
PE
1763 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1764
3f8236f4
PE
17652011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1766
53e9fe90 1767 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1768 Without these, Emacs silently mishandles large integers sometimes.
1769 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1770 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1771
6511acf2
PE
1772 * xdisp.c (try_window_id): Check Emacs fixnum range before
1773 converting to 'int'.
806add1d 1774
6511acf2 1775 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1776 Check that an Emacs fixnum is in range before assigning it to 'int'.
1777 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1778 values converted from Emacs fixnums.
1779 (Frecenter): Don't wrap around a line count if it is out of 'int'
1780 range; instead, treat it as an extreme value.
1781 (Fset_window_configuration, compare_window_configurations):
1782 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1783
6511acf2
PE
1784 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1785 that can exceed INT_MAX. Check that EMACS_INT value is in range
1786 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1787 (match_limit): Don't assume that a fixnum can fit in 'int'.
1788
6511acf2 1789 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1790 exceed INT_MAX.
1791
6511acf2 1792 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1793 (Fvertical_motion): Don't wrap around LINES values that don't fit
1794 in 'int'. Instead, treat them as extreme values. This is good
1795 enough for windows, which can't have more than INT_MAX lines anyway.
1796
fcb901a7
LMI
17972011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1798
0f2f6b6d
LMI
1799 * Require libxml/parser.h to avoid compilation warning.
1800
fcb901a7
LMI
1801 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1802
1803 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1804 since this reportedly can destroy thread storage.
1805
6e20a0d4
CY
18062011-08-30 Chong Yidong <cyd@stupidchicken.com>
1807
1808 * syntax.c (find_defun_start): Update all cache variables if
1809 exiting early (Bug#9401).
1810
148ae00e
EZ
18112011-08-30 Eli Zaretskii <eliz@gnu.org>
1812
f6cfbd8f
EZ
1813 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1814
148ae00e
EZ
1815 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1816 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1817 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1818
1819 * term.c (tty_append_glyph): New function.
1820 (produce_stretch_glyph): Static function and its prototype deleted.
1821
a66cfb1c
SM
1822 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1823 Add prototypes.
148ae00e 1824
c4a07a4c
PE
18252011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1826
1827 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1828 when checking :margin (Bug#9390).
1829 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1830 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1831 so that the name doesn't mislead. All uses changed.
1832
6bc8cd65
JB
18332011-08-28 Johan Bockgård <bojohan@gnu.org>
1834
1835 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1836 set_tty_hooks.
1837
dca4927e
EZ
18382011-08-27 Eli Zaretskii <eliz@gnu.org>
1839
1840 * xdisp.c (move_it_to): Don't bail out early when reaching
1841 position beyond to_charpos, if we are scanning backwards.
1842 (move_it_vertically_backward): When DY == 0, make sure we get to
1843 the first character in the line after the newline.
1844
f2cad773
PE
18452011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1846
1847 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1848 (ccl_driver): Do not generate an out-of-range pointer.
1849 (Fccl_execute_on_string): Remove unnecessary check for
1850 integer overflow, noted by Stefan Monnier in
1851 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1852 Remove a FIXME that didn't need fixing.
1853 Simplify the newly-introduced buffer reallocation code.
1854
0cae2cdb
JB
18552011-08-27 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1858
5fc295a4 18592011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1860
70c60eb2 1861 Integer and memory overflow issues (Bug#9196).
726e0ab1 1862
d31850da
PE
1863 * doc.c (get_doc_string): Rework so that
1864 get_doc_string_buffer_size is the actual buffer size, rather than
1865 being 1 less than the actual buffer size; this makes xpalloc more
1866 convenient.
1867
a69fbedb
PE
1868 * image.c (x_allocate_bitmap_record, cache_image):
1869 * xselect.c (Fx_register_dnd_atom):
1870 Simplify previous changes by using xpalloc.
1871
fe5c5d37
PE
1872 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1873 since either will do and ptrdiff_t is convenient with xpalloc.
1874
0065d054
PE
1875 * charset.c (charset_table_size)
1876 (struct charset_sort_data.priority): Now ptrdiff_t.
1877 (charset_compare): Don't overflow if priorities differ greatly.
1878 (Fsort_charsets): Don't assume list length fits in int.
1879 Check for size-calculation overflow when allocating sort data.
1880 (syms_of_charset): Allocate an initial charset table that is
1881 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1882
1883 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1884
1885 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1886 The actual value is always <= INT_MAX, and leaving it unsigned made
1887 overflow checking harder.
1888
1889 * dispextern.h (struct glyph_matrix.rows_allocated)
1890 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1891 with xpalloc. The values are still always <= INT_MAX.
1892
1893 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1894
1895 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1896 (SAFE_NALLOCA): New macro.
1897
1898 * region-cache.c (struct boundary.pos, find_cache_boundary)
1899 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1900 (set_cache_region, invalidate_region_cache)
1901 (revalidate_region_cache, know_region_cache, region_cache_forward)
1902 (region_cache_backward, pp_cache):
1903 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1904 so that ptrdiff_t * can be passed to xpalloc.
1905 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1906 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1907 (pp_cache): Don't assume cache_len fits in int.
1908 * region-cache.h: Adjust extern decls to match.
1909
1910 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1911 EMACS_INT, since either will do, for xpalloc.
1912
1913 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1914 (xnmalloc, xnrealloc, xpalloc): New functions.
1915
726e0ab1
PE
1916 * bidi.c (bidi_shelve_header_size): New constant.
1917 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1918 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1919
51f30bc5 1920 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1921 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1922 (overlay_strings):
1923 Don't update size of array until after memory allocation succeeds,
1924 because xmalloc/xrealloc may not return.
0065d054
PE
1925 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1926 now that we have proper integer overflow checking.
1927 (record_overlay_string, overlay_strings): Catch overflows when
1928 calculating size of overlay_str_buf.
726e0ab1 1929
0065d054
PE
1930 * callproc.c (Fcall_process): Check for size overflow when
1931 calculating size of args2.
1932 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1933 Normally we prefer signed values, but sticking with ptrdiff_t would
1934 require adding more-complicated checks.
726e0ab1
PE
1935
1936 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1937 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1938 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1939 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1940
1941 * character.c (Fstring): Check for size-calculation overflow.
1942
1943 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1944 unnecessary integer overflow. Check for size overflow.
1945 (encode_coding_object): Don't update size until xmalloc succeeds.
1946
1947 * composite.c (get_composition_id): Check for overflow in glyph
1948 length calculations.
1949
1950 Integer and memory overflow fixes for display code.
1951 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1952 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1953 (scrolling_window): Check for overflow in size calculations.
1954 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1955 Don't assume glyph table len fits in int.
1956 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1957 (row_table_size): Now ptrdiff_t, not int.
1958 (scrolling_window): Avoid overflow in size calculations.
1959 Don't update size until allocation succeeds.
1960 * fns.c (concat): Check for overflow in size calculations.
1961 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1962 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1963 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1964
1965 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1966 (get_doc_string): Check for size calculation overflow.
1967 Don't update size until allocation succeeds.
1968 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1969 EMACS_INT, where ptrdiff_t will do.
1970 (Fsubstitute_command_keys): Check for string overflow.
1971
1972 * editfns.c (set_time_zone_rule): Don't assume environment length
1973 fits in int.
1974 (message_length): Now ptrdiff_t, not int.
1975 (Fmessage_box): Don't update size until allocation succeeds.
1976 Don't assume message length fits in int.
1977 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1978
0065d054
PE
1979 * emacs.c (main): Do not reallocate argv, since there is a null at
1980 the end that can be overwritten, and this way there's no need to
1981 worry about size-calculation overflow.
1982 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1983
1984 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1985 alloc succeeds.
1986 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1987
1988 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1989 (x_set_scroll_bar_width, x_figure_window_size):
1990 Check for integer overflow.
1991 (x_set_alpha): Do not assume XINT fits in int.
1992
1993 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1994 This is for the members text_lines, text_cols, total_lines, total_cols,
1995 where the system imposes an 'int' limit.
1996
1997 * fringe.c (Fdefine_fringe_bitmap):
1998 Don't update size until alloc works.
1999
2000 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2001 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2002
2003 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2004 Check for size-calculation overflow.
2005 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2006 do, as we prefer signed integers.
2007 (id_to_widget.max_size, id_to_widget.used)
2008 (xg_store_widget_in_map, xg_remove_widget_from_map)
2009 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2010 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2011 Use and return ptrdiff_t, not int.
2012 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2013 * gtkutil.h: Change prototypes to match the above.
2014
2015 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2016 are duplicate now that they've been promoted to lisp.h.
2017 (x_allocate_bitmap_record, x_alloc_image_color)
2018 (make_image_cache, cache_image, xpm_load):
2019 Don't update size until alloc is done.
2020 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2021 (x_detect_edges):
3256efce 2022 Check for size calculation overflow.
726e0ab1
PE
2023 (ct_colors_allocated_max): New constant.
2024 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2025 overflow.
3256efce 2026
726e0ab1
PE
2027 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2028 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2029 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2030 Use ptrdiff_t, not int, to count maps.
2031 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2032 calculations. Don't update size until allocation succeeds.
2033 Redo calculations to avoid overflow.
726e0ab1
PE
2034 * keyboard.h: Change prototypes to match the above.
2035
2036 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2037 to count maps.
2038 (current_minor_maps): Check for size calculation overflow.
2039 * keymap.h: Change prototypes to match the above.
2040
2041 * lread.c (read1, init_obarray): Don't update size until alloc done.
2042
2043 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2044 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2045
726e0ab1
PE
2046 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2047 Now ptrdiff_t, not int.
2048 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2049 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2050
2051 * process.c (Fnetwork_interface_list): Check for overflow
2052 in size calculation.
2053
2054 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2055
2056 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2057 overflow. Don't bother calling xmalloc when xrealloc will do.
2058
2059 * search.c (Freplace_match): Check for size calculation overflow.
2060 (Fset_match_data): Don't assume list lengths fit in 'int'.
2061
2062 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2063 for command line length. Do not attempt to address one before the
2064 beginning of an array, as that's not portable.
2065
2066 * term.c (max_frame_lines): Remove; unused.
2067 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2068 not int.
2069 (encode_terminal_code, calculate_costs): Check for size
2070 calculation overflow.
2071 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2072 table lengths and related sizes. Don't update size until alloc
2073 done. Redo calculations to avoid overflow.
2074 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2075
2076 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2077 subtracting pointers.
2078 (gobble_line): Check for overflow more carefully. Don't update size
2079 until alloc done.
2080
2081 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2082 Don't update size until alloc done.
2083 Redo size calculations to avoid overflow.
2084 Check for size calculation overflow.
0065d054 2085 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2086
2087 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2088 Use ptrdiff_t, not int, for sizes.
2089 (store_mode_line_noprop_char): Don't update size until alloc done.
2090
0065d054
PE
2091 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2092 Use ptrdiff_t, not int, for sizes.
2093 (Finternal_make_lisp_face, cache_face):
2094 Check for size calculation overflow.
2095 (cache_face): Treat size calculation overflows as if they were
2096 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2097
2098 * xfns.c (x_encode_text, x_set_name_internal)
2099 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2100 sizes, since they can exceed INT_MAX in size. Check for size
2101 calculation overflow.
2102
0065d054
PE
2103 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2104 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2105 Don't update size until alloc done.
2106
0065d054 2107 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2108 as sprintf is limited to int lengths.
1d526e2f 2109
252c5ee1
PE
2110 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2111 (X_LONG_MIN): New macros.
864d7ce7
PE
2112 Use them to make the following changes clearer.
2113 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2114 This change doesn't affect the value now, but it may help remind
2115 future maintainers not to raise the value too much later.
2116 (SELECTION_QUANTUM): Remove, replacing with ...
2117 (selection_quantum): ... new function, which avoids overflow.
2118 All uses changed.
2119 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2120 assumption that selection length fits in 'int'.
2121 (x_reply_selection_request, x_handle_selection_request)
2122 (x_get_window_property, receive_incremental_selection)
2123 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2124 (lisp_data_to_selection_data, clean_local_selection_data):
2125 Use ptrdiff_t, not int, to record length of selection.
2126 (x_reply_selection_request, x_get_window_property)
2127 (receive_incremental_selection, x_property_data_to_lisp):
2128 Redo calculations to avoid overflow.
2129 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2130 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2131 something.
2132 (x_get_window_property, receive_incremental_selection)
2133 (lisp_data_to_selection_data, x_property_data_to_lisp):
2134 Check for size-calculation overflow.
2135 (x_get_window_property, receive_incremental_selection)
2136 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2137 Don't store size until memory allocation succeeds.
2138 (x_get_window_property): Plug memory leak on memory exhaustion.
2139 Don't double-block input; malloc is safe here. Don't assume 2**34
2140 - 4 fits in unsigned long. Add an xassert to check
2141 XGetWindowProperty overflow. Be more careful about overflow
2142 calculations, and distinguish size from memory overflow better.
2143 (receive_incremental_selection): When tracing, don't assume
2144 unsigned int is less than INT_MAX.
2145 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2146 harmful) conversions of unsigned short to int.
2147 (lisp_data_to_selection_data): Don't assume that integers
2148 in the range -65535 through -1 fit in an X unsigned short.
2149 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2150 result parameters unless successful. Rely on cons_to_unsigned
2151 to report problems with elements; the old code wasn't right anyway.
2152 (x_check_property_data): Check for int overflow; we cannot use
2153 a wider type due to X limits.
2154 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2155
726e0ab1 2156 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2157
0065d054
PE
2158 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2159 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2160 (x_color_cells): Don't store size until memory allocation succeeds.
2161 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2162 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2163 (x_term_init): Don't assume length fits in int (sprintf is limited
2164 to int size).
bc18e09d 2165
ebfa62c0
PE
2166 Use ptrdiff_t for composition IDs.
2167 * character.c (lisp_string_width):
2168 * composite.c (composition_table_size, n_compositions)
2169 (get_composition_id, composition_gstring_from_id):
2170 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2171 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2172 * window.c (Frecenter):
2173 Use ptrdiff_t, not int, for composition IDs.
2174 * composite.c (get_composition_id): Check for integer overflow.
2175 * composite.h: Adjust prototypes to match the above changes.
2176
d3411f89
PE
2177 Use ptrdiff_t for hash table indexes.
2178 * category.c (hash_get_category_set):
2179 * ccl.c (ccl_driver):
2180 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2181 * coding.c (coding_system_charset_list, detect_coding_system):
2182 * coding.h (struct coding_system.id):
2183 * composite.c (get_composition_id, gstring_lookup_cache):
2184 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2185 * image.c (xpm_get_color_table_h):
2186 * lisp.h (hash_lookup, hash_put):
2187 * minibuf.c (Ftest_completion):
2188 Use ptrdiff_t for hash table indexes, not int (which is too
2189 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2190 32-bit --with-wide-int hosts).
2191
e097a6fa
PE
2192 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2193 Add a FIXME comment about memory leaks.
2194 (syms_of_charset): Don't assume xmalloc returns.
2195
5637687f
PE
2196 Don't assume that stated character widths fit in int.
2197 * character.c (Fchar_width, c_string_width, lisp_string_width):
2198 * character.h (CHAR_WIDTH):
2199 * indent.c (MULTIBYTE_BYTES_WIDTH):
2200 Use sanitize_char_width to avoid undefined and/or bad behavior
2201 with outlandish widths.
a66cfb1c 2202 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2203 now that we have two such functions. All uses changed.
2204 (sanitize_char_width): New inline function.
2205
a2271ba2
PE
2206 Don't assume that tab-width fits in int.
2207 * character.h (sanitize_width): New inline function.
2208 (SANE_TAB_WIDTH): New macro.
2209 (ASCII_CHAR_WIDTH): Use it.
2210 * indent.c (sane_tab_width): Remove. All uses replaced by
2211 SANE_TAB_WIDTH (current_buffer).
2212 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2213
18c52557
PE
2214 * fileio.c: Integer overflow issues with file modes.
2215 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2216
caeeedc1
PE
2217 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2218 Remove unreachable code.
2219 (read_hex, load_charset_map_from_file): Check for integer overflow.
2220
50849c52
PE
2221 * xterm.c: don't go over XClientMessageEvent limit
2222 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2223 (x_send_scroll_bar_event): Likewise. Check that the size does not
2224 exceed limits imposed by XClientMessageEvent, as well as the usual
2225 ptrdiff_t and size_t limits.
2226
b13995db
PE
2227 * keyboard.c: Overflow, signedness and related fixes.
2228 (make_lispy_movement): Use same integer type in forward decl
2229 that is used in the definition.
2230 (read_key_sequence, keyremap_step):
2231 Change bufsize argument back to int, undoing my 2011-03-30 change.
2232 We prefer signed types, and int is wide enough here.
2233 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2234 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2235 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2236 length, not size_t. Use ptrdiff_t for index, not int.
2237 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2238 possibility of integer overflow.
2239
13464394
PE
2240 Overflow, signedness and related fixes for images.
2241
2242 * dispextern.h (struct it.stack[0].u.image.image_id)
2243 (struct_it.image_id, struct image.id, struct image_cache.size)
2244 (struct image_cache.used, struct image_cache.ref_count):
2245 * gtkutil.c (update_frame_tool_bar):
2246 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2247 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2248 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2249 * nsmenu.m (update_frame_tool_bar):
2250 * xdisp.c (calc_pixel_width_or_height):
2251 * xfns.c (image_cache_refcount):
2252 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2253 on typical 64-bit hosts.
2254
2255 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2256 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2257 Omit unnecessary casts to int.
2258 (parse_image_spec): Check that integers fall into 'int' range
2259 when the callers expect that.
2260 (image_ascent): Redo ascent calculation to avoid int overflow.
2261 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2262 (lookup_image): Remove unnecessary tests.
2263 (xbm_image_p): Locals are now of int, not EMACS_INT,
2264 since parse_image_check makes sure they fit into int.
2265 (png_load, gif_load, svg_load_image):
2266 Prefer int to unsigned where either will do.
2267 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
2268 old tiff_error_handler and tiff_warning_handler.
2269 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
2270 stack buffer overflows. It uses only the features of vsnprintf
2271 that are common to both POSIX and native Microsoft.
2272 (tiff_error_handler, tiff_warning_handler): Use it.
2273 (tiff_load, gif_load, imagemagick_load_image):
2274 Don't assume :index value fits in 'int'.
2275 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
2276 (imagemagick_load_image): Check that crop parameters fit into
2277 the integer types that MagickCropImage accepts. Don't assume
2278 Vimagemagick_render_type has a nonnegative value. Don't assume
2279 size_t fits in 'long'.
2280 (gs_load): Use printmax_t to print the widest integers possible.
2281 Check for integer overflow when computing image height and width.
2282
c11821d4
EZ
22832011-08-26 Eli Zaretskii <eliz@gnu.org>
2284
2285 * xdisp.c (redisplay_window): Don't force window start if point
2286 will be invisible in the resulting window. (Bug#9324)
2287
0c95fcf7
EZ
22882011-08-25 Eli Zaretskii <eliz@gnu.org>
2289
2290 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
2291 the display spec is of the form `(space ...)'.
2292 (handle_display_spec): Return the value returned by
2293 handle_single_display_spec, not just 1 or zero.
2294 (handle_single_display_spec): If the display spec is of the form
2295 `(space ...)', and specifies display in the text area, return 2
2296 rather than 1.
fee65a97 2297 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
2298 accurately, and prefer exact match for point under bidi.
2299 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
2300
2301 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
2302 into disp_prop; all users changed.
2303
2304 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
2305 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
2306 for the text covered by the display property.
2307
e4ed06f1
CY
23082011-08-25 Chong Yidong <cyd@stupidchicken.com>
2309
2310 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
2311 Change return value to nil.
2312 (Frecord_buffer): Delete unused function.
2313
f67cdd7f
EZ
23142011-08-24 Eli Zaretskii <eliz@gnu.org>
2315
5980d4c6
EZ
2316 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
2317 buffers, return left-to-right.
8610fe8b
EZ
2318 (set_cursor_from_row): Consider candidate row a win if its glyph
2319 represents a newline and point is on that newline. Fixes cursor
2320 positioning on the newline at EOL of R2L text within L2R
2321 paragraph, and vice versa.
2322 (try_cursor_movement): Check continued rows, in addition to
2323 continuation rows. Fixes unwarranted scroll when point enters a
2324 continued line of R2L text within an L2R paragraph, or vice versa.
2325 (cursor_row_p): Consider the case of point being equal to
2326 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2327 from the end of a short line to the beginning of a continued line
2328 of R2L text within L2R paragraph.
2329 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2330 composed characters.
5980d4c6 2331
f67cdd7f
EZ
2332 * bidi.c (bidi_check_type): Use xassert.
2333 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2334 members.
2335
bca633fb
EZ
23362011-08-23 Eli Zaretskii <eliz@gnu.org>
2337
2338 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2339 a character.
2340
4a5885a7
CY
23412011-08-23 Chong Yidong <cyd@stupidchicken.com>
2342
2343 * nsfont.m (ns_otf_to_script): Fix typo.
2344
0902a04e
KH
23452011-08-22 Kenichi Handa <handa@m17n.org>
2346
2347 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2348 extra slot even if the purpose is char-code-property-table.
2349
1a2e6670
EZ
23502011-08-23 Eli Zaretskii <eliz@gnu.org>
2351
8ddde651
EZ
2352 * xdisp.c (redisplay_window): When computing centering_position,
2353 account for the height of the header line. (Bug#8874)
2354
425cc014
EZ
2355 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2356 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2357 candidate is selected by the mouse, and that candidate has a
2358 composed character under the mouse.
2359
1a2e6670
EZ
2360 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2361 coordinates reported by pos-visible-in-window-p for a composed
2362 character in column zero.
2363
8b76d6f8
SM
23642011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2365
2366 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2367
dac347dd
EZ
23682011-08-22 Eli Zaretskii <eliz@gnu.org>
2369
2370 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2371 consider it a hit if to_charpos is anywhere in the range of the
2372 composed buffer positions.
2373
e013fb34
CY
23742011-08-22 Chong Yidong <cyd@stupidchicken.com>
2375
2376 * image.c (gif_load): Don't assume that each subimage has the same
2377 dimensions as the base image. Handle disposal method that is
2378 "undefined" by the gif spec (Bug#9335).
2379
bd1ba3e8
CY
23802011-08-20 Chong Yidong <cyd@stupidchicken.com>
2381
2382 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2383 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2384
54a1215b
EZ
23852011-08-19 Eli Zaretskii <eliz@gnu.org>
2386
823564e5
EZ
2387 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2388 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2389 from an Org mode buffer to a Speedbar frame.
2390
54a1215b
EZ
2391 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2392 a composition, take its buffer position from IT->cmp_it.charpos.
2393 Fixes cursor positioning at the beginning of a line that begins
2394 with a composed character.
2395
9778ebcc
EZ
23962011-08-18 Eli Zaretskii <eliz@gnu.org>
2397
0be6ee06
EZ
2398 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2399 character bidirectional type, use STRONG_L instead. Fixes crashes
2400 in a buffer produced by `describe-categories'.
2401
9778ebcc
EZ
2402 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2403 members before the level stack, so they would be saved and
2404 restored when copying iterator state. Fixes incorrect reordering
2405 around TABs covered by display properties.
2406
156bffbe
AS
24072011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2408
6b02f655 2409 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2410
72ad093b
CY
24112011-08-17 Chong Yidong <cyd@stupidchicken.com>
2412
2413 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2414 (internal_condition_case_2, internal_condition_case_n):
2415 Remove unnecessary aborts (Bug#9081).
72ad093b 2416
35774242
EZ
24172011-08-17 Eli Zaretskii <eliz@gnu.org>
2418
2419 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2420 has no `load' handler, try opening the file locally. (Bug#9311)
2421
db76dd85
KB
24222011-08-16 Ken Brown <kbrown@cornell.edu>
2423
2424 * gmalloc.c: Expand comment.
2425
b215eee5
EZ
24262011-08-16 Eli Zaretskii <eliz@gnu.org>
2427
2428 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2429 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2430
a4579d33
KB
24312011-08-16 Ken Brown <kbrown@cornell.edu>
2432
2433 Fix memory allocation problems in Cygwin build (Bug#9273).
2434
2435 * unexcw.c ( __malloc_initialized): Declare external variable.
2436 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2437
8b76d6f8
SM
2438 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2439 New variables.
a4579d33
KB
2440 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2441 dumped emacs.
2442 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2443 in the static heap.
2444 [CYGWIN] (special_realloc): New function.
2445 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2446 requests to realloc storage in the static heap.
2447
3ebec551
PE
24482011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2449
2450 * bidi.c (bidi_initialize): Remove unused local.
2451
9fd8be00
EZ
24522011-08-15 Eli Zaretskii <eliz@gnu.org>
2453
6b02f655
SM
2454 * bidimirror.h:
2455 * biditype.h: Remove file.
2456 * makefile.w32-in ($(BLD)/bidi.$(O)):
2457 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2458
2459 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2460
2461 * chartab.c: Improve commentary for the uniprop_table API.
2462
32413314
EZ
2463 * bidi.c (bidi_paragraph_init): Support zero value of
2464 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2465 (bidi_initialize): Use uniprop_table instead of including
2466 biditype.h and bidimirror.h.
32413314 2467
9fd8be00
EZ
2468 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2469 coordinates of the iterator when restoring from ppos_it.
2470 (Bug#9296)
2471
5cf2b69b
KH
24722011-08-14 Kenichi Handa <handa@m17n.org>
2473
2474 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2475 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2476
daf17d00
EZ
24772011-08-14 Eli Zaretskii <eliz@gnu.org>
2478
2479 * xdisp.c (move_it_in_display_line_to): Don't invoke
2480 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2481 ppos_it. Fixes vertical cursor motion when line beginning is
2482 covered by an image. (Bug#9296)
2483
08e3161a
JD
24842011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2485
2486 * nsterm.h (ns_run_ascript): Declare.
2487 (NSAPP_DATA2_RUNASSCRIPT): Define.
2488
2489 * nsfns.m (as_script, as_result, as_status): New static variables.
2490 (ns_run_ascript): New function.
5e617bc2 2491 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2492 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2493 the event loop. Get status from as_status (Bug#7276).
2494
2495 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2496 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2497 the event loop (Bug#7276).
2498
a3720aa2
AS
24992011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2500
2501 * gnutls.c (QCgnutls_bootprop_priority)
2502 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2503 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2504 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2505 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2506 (QCgnutls_bootprop_verify_hostname_error)
2507 (QCgnutls_bootprop_callbacks_verify): Rename from
2508 Qgnutls_bootprop_..., all uses changed.
2509
2510 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2511 uses changed.
2512
0a0d27fb
PE
25132011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2514
19d5c50c
PE
2515 * xfaces.c (Qframe_set_background_mode): Now static.
2516 * dispextern.h (Qframe_set_background_mode): Remove decl.
2517
0a0d27fb
PE
2518 * process.c (Fnetwork_interface_info): Declare local only if needed.
2519
377538cb
JD
25202011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2521
2522 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2523 (Fnetwork_interface_list): Allocate in increments of bytes instead
2524 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2525 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2526 sockaddr.
2527 (struct ifflag_def): notrailers is smart on OSX.
2528 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2529 Get hardware address with getifaddrs if available.
2530
08fff70c
EZ
25312011-08-12 Eli Zaretskii <eliz@gnu.org>
2532
2533 * xdisp.c (iterate_out_of_display_property): xassert that
2534 IT->position is set to within IT->object's boundaries. Break from
2535 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2536 when IT->position is set up wrongly due to some bug.
2537 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2538 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2539 entry. Force push_it to save on the stack the current
2540 buffer/string position, to be restored by pop_it. Fix flags in
2541 the iterator structure wrt the object coming from a display
2542 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2543 properties. (Bug#9284)
2544
7be1c708 25452011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2546
7be1c708
CY
2547 * fontset.c (fontset_get_font_group): Add proper type checks.
2548 (Bug#9172)
aac0c6e3 2549
7be1c708 25502011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2551
7be1c708
CY
2552 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2553 and LC_VERSION_MIN_MACOSX.
2554 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2555 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2556
97bb72a6
EZ
25572011-08-08 Eli Zaretskii <eliz@gnu.org>
2558
2559 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2560 no-display-properties-and-no-overlays under bidi display.
2561 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2562 properties and overlays.
97bb72a6 2563
d5617611
CY
25642011-08-08 Chong Yidong <cyd@stupidchicken.com>
2565
37e11a63
CY
2566 * editfns.c (Fset_time_zone_rule): Document relationship with the
2567 setenv function.
2568
d5617611
CY
2569 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2570 the font entity extracted from the cache (Bug#8109).
2571
58872834
CY
25722011-08-07 Chong Yidong <cyd@stupidchicken.com>
2573
2574 * composite.c (autocmp_chars): Don't reset point. That is done by
2575 restore_point_unwind (Bug#5984).
2576
75bfc667
JL
25772011-08-07 Juri Linkov <juri@jurta.org>
2578
2579 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2580 to show the arg `TIME' instead of `TIMEVAL'.
2581
d1410150
EZ
25822011-08-06 Eli Zaretskii <eliz@gnu.org>
2583
2584 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2585 display property strides EOL and includes a newline, as in
2586 longlines-mode. (Bug#9254)
75b771e4
EZ
2587 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2588 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2589
2590 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2591 is non-zero, even if the data buffer is NULL. Fixes a crash in
2592 vertical-motion with longlines-mode. (Bug#9254)
2593
35928349
EZ
25942011-08-05 Eli Zaretskii <eliz@gnu.org>
2595
ec7cc85b
EZ
2596 * bidi.c <bidi_cache_total_alloc>: Now static.
2597 (bidi_initialize): Initialize bidi_cache_total_alloc.
2598
8b76d6f8 2599 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2600 cache. (Bug#9221)
2601
2602 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2603 amount allocated this far in `bidi_cache_total_alloc'.
2604 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2605 non-zero, only free the data buffer without restoring the cache
2606 contents. All callers changed.
2607
2608 * dispextern.h (bidi_unshelve_cache): Update prototype.
2609
2610 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2611 (move_it_in_display_line, move_it_to)
2612 (move_it_vertically_backward, move_it_by_lines): Replace the call
2613 to xfree to an equivalent call to bidi_unshelve_cache.
2614 (move_it_in_display_line_to): Fix logic of returning
412b6358 2615 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2616
e2e2423b
EZ
26172011-08-05 Eli Zaretskii <eliz@gnu.org>
2618
2619 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2620 came from a string character with a `cursor' property. (Bug#9229)
2621
ae9e757a
JD
26222011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2623
2624 * Makefile.in (LIB_PTHREAD): New variable.
2625 (LIBES): Add LIB_PTHREAD (Bug#9216).
2626
2627 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2628 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2629
213bd7f2
AS
26302011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2631
6b02f655 2632 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2633
99aaf75f
JD
26342011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2635
2636 * xterm.c (x_find_topmost_parent): New function.
2637 (x_set_frame_alpha): Find topmost parent window with
2638 x_find_topmost_parent and set the property there also (bug#9181).
2639 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2640
c74e9d86
PE
26412011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2642
2643 * callproc.c (Fcall_process): Avoid vfork clobbering
2644 the local vars buffer, coding_systems, current_dir.
2645
640c8776
SM
26462011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2647
2648 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2649
f26d0e4c
PE
26502011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2651
8a10d76c
PE
2652 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2653 so that it is not optimized away.
2654
f26d0e4c
PE
2655 * xdisp.c (compute_display_string_pos): Remove unused local.
2656
55439c61
EZ
26572011-08-02 Eli Zaretskii <eliz@gnu.org>
2658
2659 Fix slow cursor motion and scrolling in large buffers with
2660 selective display, like Org Mode buffers. (Bug#9218)
2661
2662 * dispextern.h (struct bidi_it): New member disp_prop_p.
2663
2664 * xdisp.c: Remove one-slot cache of display string positions.
2665 (compute_display_string_pos): Accept an additional argument
5e617bc2 2666 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2667 for a display string or property. If found, set DISP_PROP_P
2668 non-zero.
2669
2670 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2671 DISP_PROP_P, and pass it to compute_display_string_pos.
2672 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2673 non-zero. All callers of bidi_fetch_char changed.
2674
fb33fa43
SM
26752011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2676
2677 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2678
b099e063
DM
26792010-12-03 Don March <don@ohspite.net>
2680
2681 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2682 last character M-[char] is translated to ESC [char] (bug#7541).
2683
5cc7f7af
KH
26842011-08-02 Kenichi Handa <handa@m17n.org>
2685
d0fffa3f 2686 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2687
2688 * chartab.c (uniprop_table): Make it non-static.
2689
525d5e6e
EZ
26902011-08-01 Eli Zaretskii <eliz@gnu.org>
2691
2692 * xdisp.c (forward_to_next_line_start): Accept additional argument
2693 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2694 on the newline.
2695 (reseat_at_next_visible_line_start): Use the bidi iterator state
2696 returned by forward_to_next_line_start to restore the state of
2697 it->bidi_it after backing up to previous newline. (Bug#9212)
2698
31011111
AS
26992011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2700
2701 * regex.c (re_comp): Protoize.
2702 (re_exec): Fix return type.
2703 (regexec): Fix type of `ret'. (Bug#9203)
2704
476371c4
PE
27052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2706
e5d76069
PE
2707 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2708 This is needed if max-image-size is a floating-point number.
2709
9a79b20c
AS
27102011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2711
2712 * print.c (print_object): Print empty symbol as ##.
2713
2714 * lread.c (read1): Read ## as empty symbol.
2715
d8c2fa78
AA
27162011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2717
2718 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2719 setting frame foreground color (Bug#9175).
2720 (x_set_background_color): Likewise.
2721
ffe57a7a
AA
2722 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2723 contents (Bug#9176).
2724 (EmacsTooltip -init): Remove bezels and add shadows to
2725 tooltip windows.
2726
bf3492a5
AA
2727 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2728 or scroll bar (Bug#8470).
2729
d55e9c53
AA
2730 * nsfont.m (nsfont_open): Remove assignment to voffset and
2731 unnecessary vars hshink, expand, hd, full_height, min_height.
2732 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2733
2734 * nsterm.h (nsfont_info): Remove voffset field.
2735
d8c2fa78 27362011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2737
2738 Implement strike-through and overline on NextStep (Bug#8863).
2739
2740 * nsfont.m (nsfont_open): Use underline position provided by font,
2741 instead of hard-coded value of 2.
2742 (nsfont_draw): Call ns_draw_text_decoration instead.
2743
2744 * nsterm.h: Add declaration for ns_draw_text_decoration.
2745
2746 * nsterm.m (ns_draw_text_decoration): New function for drawing
2747 underline, overline, and strike-through.
2748 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2749 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2750 accommodate underlining, etc.
4843aac3 2751
4cc60b9b
EZ
27522011-07-28 Eli Zaretskii <eliz@gnu.org>
2753
bc7ece87
EZ
2754 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2755 default.
4cc60b9b 2756
476371c4
PE
27572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2758
66606eea
PE
2759 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2760 Without this fix, if a signal arrives just after memory fills up,
2761 'malloc' might be invoked reentrantly.
2762
476371c4
PE
2763 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2764 In other words, assume that every image size is allowed, on non-X
2765 hosts. This assumption is probably wrong, but it lets Emacs compile.
2766
f3fcc40d
AS
27672011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2768
2769 * regex.c (re_iswctype): Convert return values to boolean.
2770
350c992f
EZ
27712011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2772
2773 * xdisp.c (compute_display_string_pos): Don't use cached display
2774 string position if the buffer had its restriction changed.
2775 (Bug#9184)
2776
5266b4bb
PE
27772011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2778
2779 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2780
2573a837 27812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2782
41f55ccd 2783 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2784
39e378da
PE
2785 * bidi.c: Integer size and overflow fixes.
2786 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2787 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2788 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2789 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2790 (bidi_find_other_level_edge):
2791 Use ptrdiff_t instead of EMACS_INT where either will do.
2792 This works better on 32-bit hosts configured --with-wide-int.
2793 (bidi_cache_ensure_space): Check for size-calculation overflow.
2794 Use % rather than repeated addition, for better worst-case speed.
2795 Don't set bidi_cache_size until after xrealloc returns, because it
2796 might not return.
2797 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2798 (bidi_cache_ensure_space): Also check that the bidi cache size
2799 does not exceed that of the largest Lisp string or buffer. See Eli
2800 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2801
5e927815
PE
2802 * alloc.c (__malloc_size_t): Remove.
2803 All uses replaced by size_t. See Andreas Schwab's note
2804 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2805
ca4aa935
PE
2806 * image.c: Improve checking for integer overflow.
2807 (check_image_size): Assume that f is nonnull, since
2808 it is always nonnull in practice. This is one less thing to
2809 worry about when checking for integer overflow later.
2810 (x_check_image_size): New function, which checks for integer
2811 overflow issues inside X.
2812 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2813 This removes the need for a memory_full check.
2814 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2815 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2816 (xbm_read_bitmap_data): Change locals back to 'int', since
2817 their values must fit in 'int'.
2818 (xpm_load_image, png_load, tiff_load):
2819 Invoke x_create_x_image_and_pixmap earlier,
2820 to avoid much needless work if the image is too large.
2821 (tiff_load): Treat overly large images as if
2822 x_create_x_image_and_pixmap failed, not as malloc failures.
2823 (gs_load): Use x_check_image_size.
2824
5f8f9cc2
PE
2825 * gtkutil.c: Omit integer casts.
2826 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2827 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2828
5adf60bc
PE
2829 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2830
c8907a93
PE
2831 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2832 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2833 would wrongly return t on a 64-bit host.
2834
e3c25c68
PE
2835 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2836 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2837 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2838 and therefore cause GCC to emit a bogus diagnostic in some cases.
2839
3f791afe
PE
2840 * image.c: Integer signedness and overflow and related fixes.
2841 This is not an exhaustive set of fixes, but it's time to
2842 record what I've got.
2843 (lookup_pixel_color, check_image_size): Remove redundant decls.
2844 (check_image_size): Don't assume that arbitrary EMACS_INT values
2845 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2846 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2847 (tiff_load, imagemagick_load_image):
2848 Check for overflow in size calculations.
2849 (x_create_x_image_and_pixmap): Remove unnecessary test for
2850 xmalloc returning NULL; that can't happen.
2851 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2852 (xpm_color_bucket): Use better integer hashing function.
2853 (xpm_cache_color): Don't possibly over-allocate memory.
2854 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2855 (gif_memory_source):
2856 Use ptrdiff_t, not int or size_t, to record sizes.
2857 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2858 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2859 either works, as we prefer signed integers.
2860 (tiff_read_from_memory, tiff_write_from_memory):
2861 Return tsize_t, not size_t, since that's what the TIFF API wants.
2862 (tiff_read_from_memory): Don't fail simply because the read would
2863 go past EOF; instead, return a short read.
2864 (tiff_load): Omit no-longer-needed casts.
2865 (Fimagemagick_types): Don't assume size fits into 'int'.
2866
3cc5a532
PE
2867 Improve hashing quality when configured --with-wide-int.
2868 * fns.c (hash_string): New function, taken from sxhash_string.
2869 Do not discard information about ASCII character case; this
2870 discarding is no longer needed.
2871 (sxhash-string): Use it. Change sig to match it. Caller changed.
2872 * lisp.h: Declare it.
2873 * lread.c (hash_string): Remove, since we now use fns.c's version.
2874 The fns.c version returns a wider integer if --with-wide-int is
2875 specified, so this should help the quality of the hashing a bit.
2876
b312a492
PE
2877 * emacs.c: Integer overflow minor fix.
2878 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2879 Define only if GNU_LINUX.
2880 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2881
dfd153ae
PE
2882 * dispnew.c: Integer signedness and overflow fixes.
2883 Remove unnecessary forward decls, that were a maintenance hassle.
2884 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2885 All uses changed.
2886 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2887 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2888 (prepare_desired_row, line_draw_cost):
2889 Use int, not unsigned, where either works.
2890 (save_current_matrix, restore_current_matrix):
2891 Use ptrdiff_t, not size_t, where either works.
2892 (init_display): Check for overflow more accurately, and without
2893 relying on undefined behavior.
2894
a81d11a3
PE
2895 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2896 Remove, replacing with the new symbols in lisp.h. All uses changed.
2897 * fileio.c (make_temp_name):
2898 * filelock.c (lock_file_1, lock_file):
2899 * xdisp.c (message_dolog):
2900 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2901 Use pMd etc. instead.
2902 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2903 replacing the pWIDE etc. symbols removed from editfns.c.
2904
3300e6fd
PE
2905 * keyboard.h (num_input_events): Now uintmax_t.
2906 This is (very slightly) less likely to mess up due to wraparound.
2907 All uses changed.
2908
fd05c7e9
PE
2909 * buffer.c: Integer signedness fixes.
2910 (alloc_buffer_text, enlarge_buffer_text):
2911 Use ptrdiff_t rather than size_t when either will do, as we prefer
2912 signed integers.
2913
903fe15d
PE
2914 * alloc.c: Integer signedness and overflow fixes.
2915 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2916 (__malloc_size_t): Default to size_t, not to int.
2917 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2918 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2919 Prefer ptrdiff_t to size_t when either would do, as we prefer
2920 signed integers.
2921 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2922 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2923 Now const. Initialize with values that are in range even if char
2924 is signed.
2925 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2926 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2927 These functions do the right thing with sizes > 2**32.
2928 (check_depth): Now ptrdiff_t, not int.
2929 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2930 Adjust to new way of storing sizes. Check for size overflow bugs
2931 in rest of code.
2932 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2933 slightly wrong anyway, as it missed one instance of
2934 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2935 (refill_memory_reserve): Omit needless cast to size_t.
2936 (mark_object_loop_halt): Mark as externally visible.
2937
ac82cc6a
PE
2938 * xselect.c: Integer signedness and overflow fixes.
2939 (Fx_register_dnd_atom, x_handle_dnd_message):
2940 Use ptrdiff_t, not size_t, since we prefer signed.
2941 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2942 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2943 x_dnd_atoms_size and x_dnd_atoms_length.
2944
c2d1e36d
PE
2945 * doprnt.c: Prefer signed to unsigned when either works.
2946 * eval.c (verror):
2947 * doprnt.c (doprnt):
2948 * lisp.h (doprnt):
2949 * xdisp.c (vmessage):
2950 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2951 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2952 prefer signed arithmetic to avoid comparison confusion.
2953 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2954 but is a bit tricky.
2955
0e926e56
PE
2956 Assume freestanding C89 headers, string.h, stdlib.h.
2957 * data.c, doprnt.c, floatfns.c, print.c:
2958 Include float.h unconditionally.
2959 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2960 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2961 * regex.c: Likewise for stddef.h, string.h.
2962 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2963 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2964 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2965 (STDC_HEADERS): Remove obsolete defines.
2966 * sysdep.c: Include limits.h unconditionally.
2967
9cfdb3ec
PE
2968 Assume support for memcmp, memcpy, memmove, memset.
2969 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2970 * regex.c (memcmp, memcpy):
2971 Remove; we assume C89 now.
2972
2973 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2974 (__malloc_safe_bcopy): Remove; no longer needed.
2975
cf950e6b 2976 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2977 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2978 well either way, and we prefer signed to unsigned.
2979
dbf38e02
LMI
29802011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2981
2982 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2983 closes the connection while we're reading (bug#9182).
2984
d6f0886c 29852011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2986
d6f0886c
JD
2987 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2988 are specified (Bug#9168).
24e0f6b1 2989
2eb1f9e6
PE
29902011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2991
2992 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2993 Found by GCC static checking and --with-wide-int on a 32-bit host.
2994
22381272 29952011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2996
2997 * xdisp.c (compute_display_string_pos): Fix logic of caching
2998 previous display string position. Initialize cached_prev_pos to
2999 -1. Fixes slow-down at the beginning of a buffer.
3000
f25e39b4
EZ
30012011-07-24 Eli Zaretskii <eliz@gnu.org>
3002
3003 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3004 for attrs[LFACE_FONTSET_INDEX].
3005
04c4b52e
PE
30062011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3007
3008 * xml.c (parse_region): Remove unused local
3009 that was recently introduced.
3010
c1734fbd
EZ
30112011-07-23 Eli Zaretskii <eliz@gnu.org>
3012
be18c5a5
EZ
3013 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3014 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3015
c1734fbd
EZ
3016 * xdisp.c (move_it_in_display_line_to): Record the best matching
3017 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3018 exit if none of the characters scanned was an exact match.
3019 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3020 when exact match is impossible due to invisible text, and the
3021 lines are truncated.
3022
a258d627
JD
30232011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3024
3025 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3026 for OSX >= 10.7.
3027
b6d5a689
EZ
30282011-07-22 Eli Zaretskii <eliz@gnu.org>
3029
0f74f785
EZ
3030 Fix a significant slow-down of cursor motion with C-n, C-p,
3031 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3032 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3033 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3034 (next_element_from_buffer): Call compute_stop_pos_backwards to
3035 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3036 base_level_stop.
3037 (reseat): Don't look for prev_stop, as that could mean a very long
3038 run.
3039 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3040 <cached_disp_overlay_modiff>: Cache for last found display string
3041 position.
551918c1 3042 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3043 about the same buffer in the same area of character positions, and
3044 the buffer wasn't changed since the time the display string
3045 position was cached.
551918c1 3046
b2d0c91a
EZ
30472011-07-22 Eli Zaretskii <eliz@gnu.org>
3048
3049 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3050 is an integer, which is important for empty lines. (Bug#9149)
3051
043604ee
CY
30522011-07-22 Chong Yidong <cyd@stupidchicken.com>
3053
3054 * frame.c (Fmodify_frame_parameters): In tty case, update the
3055 default face if necessary (Bug#4238).
3056
da4adb04
CY
30572011-07-21 Chong Yidong <cyd@stupidchicken.com>
3058
3059 * editfns.c (Fstring_to_char): No need to explain what a character
3060 is in the docstring (Bug#6576).
3061
9abd0532
LMI
30622011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3063
3064 * xml.c (parse_region): Make sure we always return a tree.
3065
36881d16
HK
30662011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3067
3068 * xml.c (parse_region): If a document contains only comments,
3069 return that, too.
3070
1e98674d
LMI
30712011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3072
3073 * xml.c (make_dom): Return comments, too.
3074
590bd467
PE
30752011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3076
3077 Port to OpenBSD.
3078 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3079 and the surrounding thread.
3080 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3081 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3082 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3083 timer goes off.
3084 * s/openbsd.h (BROKEN_SIGIO): Define.
3085 * unexelf.c (unexec) [__OpenBSD__]:
3086 Don't update the .mdebug section of the Alpha COFF symbol table.
3087
f41628b2
LMI
30882011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3089
3090 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3091 (bug#8460).
3092
b59b67c5
PE
30932011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3094
15e3a074
PE
3095 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3096 This fixes some race conditions on the permissions of any newly
3097 created file.
3098
41bed37d
PE
3099 * alloc.c (valid_pointer_p): Use pipe, not open.
3100 This fixes some permissions issues when debugging.
3101
b59b67c5
PE
3102 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3103 If fchown fails to set both uid and gid, try to set just gid,
3104 as that is sometimes allowed. Adjust the file's mode to eliminate
3105 setuid or setgid bits that are inappropriate if fchown fails.
3106
925a6be7
SM
31072011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3108
3109 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3110 to compare Lisp_Objects.
3111 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3112 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3113 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3114
52968808
AS
31152011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3116
0a6a104b
AS
3117 * lread.c (read_integer): Unread even EOF character.
3118 (read1): Likewise. Properly record start position of symbol.
3119
52968808
AS
3120 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3121 symbol character follows.
3122
9e381cdd
PE
31232011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3124
3125 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3126 This works around a problem with the previous change to Fcopy_file.
3127 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3128 and without this change, GCC might complain about discarding
3129 fchown's return value.
3130
b5641435
JB
31312011-07-16 Juanma Barranquero <lekktu@gmail.com>
3132
3133 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3134
a8031457
PE
31352011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3136
3137 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3138
dd889327
LMI
31392011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3140
750c33f7
LMI
3141 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3142 it's used from the C level.
3143
dd889327
LMI
3144 * process.c: Use the same condition for POLL_FOR_INPUT in both
3145 keyboard.c and process.c (bug#1858).
3146
87e86684
LM
31472011-07-09 Lawrence Mitchell <wence@gmx.li>
3148
3149 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3150 (Fgnutls_boot): Use it.
3151
64348f40
AS
31522011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3153
3154 * doc.c (Fsubstitute_command_keys): Revert last change.
3155
1d698799
LMI
31562011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3157
f863868c
LMI
3158 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3159 quotes the next character, and doesn't affect other longer
3160 sequences (bug#8935).
3161
1d698799
LMI
3162 * lread.c (syms_of_lread): Clarify that is isn't only
3163 `eval-buffer' and `eval-defun' that's affected by
3164 `lexical-binding' (bug#8460).
3165
aa4b6df6
EZ
31662011-07-15 Eli Zaretskii <eliz@gnu.org>
3167
3168 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3169 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3170
5d856da6
PE
31712011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3172
ad6042bb
PE
3173 Fix minor problems found by static checking.
3174 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3175 (elsz): Now a signed constant, not a size_t var. We prefer signed
3176 types to unsigned, to avoid integer comparison confusion. Without
3177 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3178 "cannot optimize loop, the loop counter may overflow", a symptom
3179 of the confusion.
f00bbb22 3180 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3181 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3182
6468f31c
LMI
31832011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3184
49080b10
LMI
3185 * search.c (Fre_search_backward): Mention `case-fold-search' in
3186 all the re_search_* functions (bug#8138).
3187
6468f31c
LMI
3188 * keyboard.c (Fopen_dribble_file): Document when the file is
3189 closed (bug#8056).
3190
c965adc5
EZ
31912011-07-14 Eli Zaretskii <eliz@gnu.org>
3192
df9733bf
EZ
3193 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3194 bidi_cache_idx.
3195
0bb23927
EZ
3196 Support bidi reordering of display and overlay strings.
3197 * xdisp.c (compute_display_string_pos)
3198 (compute_display_string_end): Accept additional argument STRING.
3199 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3200 (reseat_to_string): Initialize bidi_it->string.s and
3201 bidi_it->string.schars.
3202 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3203 NULL (avoids a crash in bidi_paragraph_init).
3204 Initialize itb.string.lstring.
0bb23927
EZ
3205 (init_iterator): Call bidi_init_it only of a valid
3206 buffer position was specified. Initialize paragraph_embedding to
3207 L2R.
3208 (reseat_to_string): Initialize the bidi iterator.
3209 (display_string): If we need to ignore text properties of
3210 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3211 original value of -1 will not work with bidi.)
3212 (compute_display_string_pos): First arg is now struct
3213 `text_pos *'; all callers changed. Support display properties on
3214 Lisp strings.
3215 (compute_display_string_end): Support display properties on Lisp
3216 strings.
3217 (init_iterator, reseat_1, reseat_to_string): Initialize the
3218 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3219 when iterating on a string not from display properties).
640c8776
SM
3220 (compute_display_string_pos, compute_display_string_end):
3221 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3222 arrow keys.
3223 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3224 base_level_stop; instead, set base_level_stop to BEGV.
3225 Fixes crashes in vertical-motion.
0bb23927
EZ
3226 (next_element_from_buffer): Improve commentary for when
3227 the iterator is before prev_stop.
3228 (init_iterator): Initialize bidi_p from the default value of
3229 bidi-display-reordering, not from buffer-local value. Use the
3230 buffer-local value only if initializing for buffer iteration.
3231 (handle_invisible_prop): Support invisible properties on strings
3232 that are being bidi-reordered.
3233 (set_iterator_to_next): Support bidi reordering of C strings and
3234 Lisp strings.
3235 (next_element_from_string): Support bidi reordering of Lisp
3236 strings.
3237 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3238 (display_string): Support display of R2L glyph rows.
3239 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3240 (init_iterator): Don't initialize it->bidi_p for strings
3241 here.
3242 (reseat_to_string): Initialize it->bidi_p for strings here.
3243 (next_element_from_string, next_element_from_c_string)
3244 (next_element_from_buffer): Add xassert's for correspondence
3245 between IT's object being iterated and it->bidi_it.string
3246 structure.
3247 (face_before_or_after_it_pos): Support bidi iteration.
3248 (next_element_from_c_string): Handle the case of the first string
3249 character that is not the first one in the visual order.
3250 (get_visually_first_element): New function, refactored from common
3251 parts of next_element_from_buffer, next_element_from_string, and
3252 next_element_from_c_string.
3253 (tool_bar_lines_needed, redisplay_tool_bar)
3254 (display_menu_bar): Force left-to-right direction. Add a FIXME
3255 comment for making that be controlled by a user option.
3256 (push_it, pop_it): Save and restore the state of the
3257 bidi iterator. Save and restore the bidi_p flag.
3258 (pop_it): Iterate out of display property for string iteration as
3259 well.
3260 (iterate_out_of_display_property): Support iteration over strings.
3261 (handle_single_display_spec): Set up it->bidi_it for iteration
3262 over a display string, and call bidi_init_it.
3263 (handle_single_display_spec, next_overlay_string)
3264 (get_overlay_strings_1, push_display_prop): Set up the bidi
3265 iterator for displaying display or overlay strings.
3266 (forward_to_next_line_start): Don't use the shortcut if
3267 bidi-iterating.
3268 (back_to_previous_visible_line_start): If handle_display_prop
3269 pushed the iterator stack, restore the internal state of the bidi
3270 iterator by calling bidi_pop_it same number of times.
3271 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
3272 and we are bidi-iterating, don't decrement the iterator position;
3273 instead, set the first_elt flag in the bidi iterator, to produce
3274 the same effect.
3275 (reseat_1): Remove redundant setting of string_from_display_prop_p.
3276 (push_display_prop): xassert that we are iterating a buffer.
3277 (push_it, pop_it): Save and restore paragraph_embedding member.
3278 (handle_single_display_spec, next_overlay_string)
3279 (get_overlay_strings_1, reseat_1, reseat_to_string)
3280 (push_display_prop): Set up the `unibyte' member of bidi_it.string
3281 correctly. Don't assume unibyte strings are not bidi-reordered.
3282 (compute_display_string_pos)
3283 (compute_display_string_end): Fix handling the case of C string.
3284 (push_it, pop_it): Save and restore from_disp_prop_p.
3285 (handle_single_display_spec, push_display_prop): Set the
3286 from_disp_prop_p flag.
3287 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
3288 (pop_it): Call iterate_out_of_display_property only if we are
3289 popping after iteration over a string that came from a display
3290 property. Fix a typo in popping stretch info. Add an assertion
3291 for verifying that the iterator position is in sync with the bidi
3292 iterator.
3293 (handle_single_display_spec, get_overlay_strings_1)
3294 (push_display_prop): Fix initialization of paragraph direction for
3295 string when that of the parent object is not yet determined.
3296 (reseat_1): Call bidi_init_it to resync the bidi
3297 iterator with IT's position. (Bug#7616)
3298 (find_row_edges): If ROW->start.pos gives position
3299 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
3300 (handle_stop, back_to_previous_visible_line_start, reseat_1):
3301 Reset the from_disp_prop_p flag.
3302 (SAVE_IT, RESTORE_IT): New macros.
3303 (pos_visible_p, face_before_or_after_it_pos)
3304 (back_to_previous_visible_line_start)
3305 (move_it_in_display_line_to, move_it_in_display_line)
3306 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3307 (try_scrolling, redisplay_window, display_line): Use them when
3308 saving a temporary copy of the iterator and restoring it back.
3309 (back_to_previous_visible_line_start, reseat_1)
3310 (init_iterator): Empty the bidi cache "stack".
3311 (move_it_in_display_line_to): If iterator ended up at
3312 EOL, but we never saw any buffer positions smaller than
3313 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
3314 motion in bidi-reordered lines.
3315 (move_it_in_display_line_to): Record prev_method and prev_pos
3316 immediately before the call to set_iterator_to_next. Fixes cursor
3317 motion in bidi-reordered lines with stretch glyphs and strings
3318 displayed in margins. (Bug#8133) (Bug#8867)
3319 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
3320 TO_CHARPOS.
640c8776
SM
3321 (pos_visible_p): Support positions in bidi-reordered lines.
3322 Save and restore bidi cache.
0bb23927
EZ
3323
3324 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3325 (bidi_paragraph_info): Delete unused struct.
3326 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3327 (bidi_cache_start): New variable.
3328 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3329 to zero.
3330 (bidi_cache_fetch_state, bidi_cache_search)
3331 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3332 (bidi_cache_find, bidi_peek_at_next_level)
3333 (bidi_level_of_next_char, bidi_find_other_level_edge)
3334 (bidi_move_to_visually_next): Compare cache index with
3335 bidi_cache_start rather than with zero.
3336 (bidi_fetch_char): Accept new argument STRING; all callers
3337 changed. Support iteration over a string. Support strings with
3338 display properties. Support unibyte strings. Fix the type of
3339 `len' according to what STRING_CHAR_AND_LENGTH expects.
3340 (bidi_paragraph_init, bidi_resolve_explicit_1)
3341 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3342 (bidi_level_of_next_char, bidi_move_to_visually_next):
3343 Support iteration over a string.
0bb23927
EZ
3344 (bidi_set_sor_type, bidi_resolve_explicit_1)
3345 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3346 can now be zero (for strings); special values 0 and -1 were
3347 changed to -1 and -2, respectively.
3348 (bidi_char_at_pos): New function.
3349 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3350 Call it instead of FETCH_MULTIBYTE_CHAR.
3351 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3352 initialized to valid values.
3353 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3354 values.
3355 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3356 the test for valid cached positions. Fix the logic for looking up
3357 the sentinel state in the cache. GCPRO the Lisp string we are
3358 iterating.
3359 (bidi_push_it, bidi_pop_it): New functions.
3360 (bidi_initialize): Initialize the bidi cache start stack pointer.
3361 (bidi_cache_ensure_space): New function, refactored from part of
3362 bidi_cache_iterator_state. Don't assume the required size is just
3363 one BIDI_CACHE_CHUNK away.
3364 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3365 (bidi_count_bytes, bidi_char_at_pos): New functions.
3366 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3367 always valid if bidi_cache_idx is valid.
3368 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3369 is valid if it's going to be used.
3370 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3371 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3372 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3373 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3374 (bidi_find_other_level_edge, bidi_cache_start_stack):
3375 All variables related to cache indices are now EMACS_INT.
c965adc5 3376
0bb23927
EZ
3377 * dispextern.h (struct bidi_string_data): New structure.
3378 (struct bidi_it): New member `string'. Make flag members be 1-bit
3379 fields, and put them last in the struct.
640c8776
SM
3380 (compute_display_string_pos, compute_display_string_end):
3381 Update prototypes.
0bb23927
EZ
3382 (bidi_push_it, bidi_pop_it): Add prototypes.
3383 (struct iterator_stack_entry): New members bidi_p,
3384 paragraph_embedding, and from_disp_prop_p.
3385 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3386 (bidi_shelve_cache, bidi_unshelve_cache):
3387 Declare prototypes.
0bb23927
EZ
3388
3389 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3390 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3391 and vector-like objects.
3392
3393 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3394 cache around display iteration.
3395
3396 * window.c (Fwindow_end, window_scroll_pixel_based)
3397 (displayed_window_lines, Frecenter): Save and restore the bidi
3398 cache around display iteration.
3399
3bbd2265
LMI
34002011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3401
3402 * editfns.c (Fdelete_region): Clarify the use of the named
3403 parameters (bug#6788).
3404
adc47434
MR
34052011-07-14 Martin Rudalics <rudalics@gmx.at>
3406
3407 * indent.c (Fvertical_motion): Set and restore w->pointm when
3408 saving and restoring the window's buffer (Bug#9006).
3409
837c31f8
LMI
34102011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3411
3412 * editfns.c (Fstring_to_char): Clarify just what is returned
3413 (bug#6576). Text by Eli Zaretskii.
3414
ac389d0c
JB
34152011-07-13 Juanma Barranquero <lekktu@gmail.com>
3416
3417 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3418
0be0ce47
EZ
34192011-07-13 Eli Zaretskii <eliz@gnu.org>
3420
3421 * buffer.c (mmap_find): Fix a typo.
3422
cd18e7e3
JB
34232011-07-13 Johan Bockgård <bojohan@gnu.org>
3424
3425 Fix execution of x selection hooks.
3426 * xselect.c (Qx_lost_selection_functions)
3427 (Qx_sent_selection_functions): New vars.
3428 (syms_of_xselect): DEFSYM them.
3429 (x_handle_selection_request): Pass Qx_sent_selection_functions
3430 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3431 (x_handle_selection_clear,x_clear_frame_selections):
3432 Pass Qx_lost_selection_functions rather than
3433 Vx_lost_selection_functions to Frun_hook_with_args.
3434
47ea7f44
PE
34352011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3436
ac389d0c 3437 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3438 The old code sometimes used this field without initializing it.
3439
47ea7f44
PE
3440 * alloc.c (gc_sweep): Don't read past end of array.
3441 In theory, the old code could also have corrupted Emacs internals,
3442 though it'd be very unlikely.
3443
bc985c87
AS
34442011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3445
3446 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3447 argument. (Bug#4026)
bc985c87 3448
0cf34688
LMI
34492011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3450
b3dadd76
LMI
3451 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3452 key" (bug#4257).
3453
0cf34688
LMI
3454 * window.c (Fset_window_start): Doc fix (bug#4199).
3455 (Fset_window_hscroll): Ditto.
3456
270768cd
PE
34572011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3458
077e3dda 3459 Fix minor new problems caught by GCC 4.6.1.
270768cd 3460 * term.c (init_tty): Remove unused local.
490011a6 3461 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3462 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3463 not used otherwise.
270768cd 3464
b1f58454
CY
34652011-07-12 Chong Yidong <cyd@stupidchicken.com>
3466
3467 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3468
22b9578d
LMI
34692011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3470
6e70ab07
LMI
3471 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3472 are the mini-buffer and the echo area (bug#3320).
3473
22b9578d
LMI
3474 * term.c (init_tty): Remove support for supdup, c10 and perq
3475 terminals, which are no longer supported (bug#1482).
3476
8974cc9f
JB
34772011-07-10 Johan Bockgård <bojohan@gnu.org>
3478
3479 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3480
a560d974
JD
34812011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3482
3483 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3484 for non-popups (Bug#3642).
3485
1dae0f0a
AS
34862011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3487
268c2c36 3488 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3489 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3490 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3491 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3492 * data.c (fmod): Likewise.
3493 * dispnew.c (swap_glyphs_in_rows): Likewise.
3494 * emacs.c (memory_warning_signal): Likewise.
3495 * floatfns.c (float_error): Likewise.
3496 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3497 (otf_open, font_otf_capability, generate_otf_features)
3498 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3499 Likewise.
3500 * image.c (pbm_read_file): Likewise.
3501 * indent.c (string_display_width): Likewise.
3502 * intervals.c (check_for_interval, search_for_interval)
3503 (inc_interval_count, count_intervals, root_interval)
3504 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3505 * lread.c (defalias): Likewise.
268c2c36 3506 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3507 * regex.c (set_image_of_range_1, set_image_of_range)
3508 (regex_grow_registers): Likewise.
3509 * sysdep.c (strerror): Likewise.
3510 * termcap.c (valid_filename_p, tprint, main): Likewise.
3511 * tparam.c (main): Likewise.
3512 * unexhp9k800.c (run_time_remap, save_data_space)
3513 (update_file_ptrs, read_header, write_header, calculate_checksum)
3514 (copy_file, copy_rest, display_header): Likewise.
3515 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3516 Likewise.
3517 * xdisp.c (check_it): Likewise.
3518 * xfaces.c (register_color, unregister_color, unregister_colors):
3519 Likewise.
3520 * xfns.c (print_fontset_result): Likewise.
3521 * xrdb.c (member, fatal, main): Likewise.
3522
99033785
PE
35232011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3524
3525 Fix minor problems found by static checking (Bug#9031).
3526 * chartab.c (char_table_set_range, map_sub_char_table):
3527 Remove unused locals.
3528 (uniprop_table): Now static.
3529 * composite.c (_work_char): Remove unused static var.
3530
9cb2ac56
JB
35312011-07-09 Juanma Barranquero <lekktu@gmail.com>
3532
3533 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3534
f25661f0
JD
35352011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3536
3537 * gtkutil.c (qttip_cb): Remove code without function.
3538
8278c4fe
EZ
35392011-07-09 Eli Zaretskii <eliz@gnu.org>
3540
3541 * w32.c (pthread_sigmask): New stub.
3542
1692ae2d 35432011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3544
8a6ebd58 3545 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3546 sigprocmask is portable only for single-threaded applications, and
3547 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3548 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3549 (LIBES): Use it.
3550 * callproc.c (Fcall_process):
3551 * process.c (create_process):
3552 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3553 Use pthread_sigmask, not sigprocmask.
123403e4 3554
1b854618
JD
35552011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3556
3557 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3558 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3559 wrong (Bug#8591).
3560
3fe4b549
JD
35612011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3562
0ce7e563
JD
3563 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3564 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3565 (xg_hide_tooltip): Fix comment.
3566
3fe4b549
JD
3567 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3568 in registerServicesMenuSendTypes.
3569 (validRequestorForSendType): Don't check ns_return_types.
3570
3571 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3572 ns_return_type.
3573
5df75e47
JR
35742011-07-08 Jason Rumney <jasonr@gnu.org>
3575
22610910
JR
3576 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3577 SH_SHOW for hidden windows (Bug#5482).
3578
5df75e47
JR
3579 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3580 frame struct members of non-existent frames (Bug#6284).
3581
699c10bd
JD
35822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3583
4393663b
JD
3584 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3585 variable firstTime not needed on OSX >= 10.6.
3586 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3587 >= 10.5. Use setKnobProportion, setDoubleValue.
3588
3589 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3590 (MAC_OS_X_VERSION_10_5): Define if not defined.
3591 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3592 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3593 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3594
3595 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3596 cString and lossyCString on OSX >= 10.4
3597
58179cce 3598 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3599 sizeToFit on OSX >= 10.2.
3600
3601 * nsimage.m (allocInitFromFile): Don't use deprecated method
3602 bestRepresentationForDevice on OSX >= 10.6.
3603
3604 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3605 to avoid warning.
3606
3607 * emacs.c: Declare unexec_init_emacs_zone.
3608
a63e0781
JD
3609 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3610
699c10bd
JD
3611 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3612
3613 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3614 on svcsMenu (Bug#8842).
3615
3616 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3617 ns_return_types.
3618 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3619
3620 * nsterm.m (QUTF8_STRING): Declare.
3621 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3622 (validRequestorForSendType): Return type is (id).
3623 Change indexOfObjectIdenticalTo to indexOfObject.
3624 Check if we have local selection before returning self (Bug#8842).
3625 (writeSelectionToPasteboard): Put local selection into paste board
3626 if we have a local selection (Bug#8842).
3627 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3628
3629 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3630 (ns_get_local_selection): Declare.
3631
54e10184
LMI
36322011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3633
9888ff71
LMI
3634 * keymap.c (describe_map_tree): Don't insert a double newline at
3635 the end of the buffer (bug#1169) and return whether we inserted
3636 something.
3637
54e10184
LMI
3638 * callint.c (Fcall_interactively): Change "reading args" to
3639 "providing args" to try to clarify what it does (bug#1010).
3640
15fa4783
KH
36412011-07-07 Kenichi Handa <handa@m17n.org>
3642
3643 * composite.c (composition_compute_stop_pos): Ignore a static
3644 composition starting before CHARPOS (Bug#8915).
3645
3646 * xdisp.c (handle_composition_prop): Likewise.
3647
a8815b00
EZ
36482011-07-07 Eli Zaretskii <eliz@gnu.org>
3649
3650 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3651 (Bug#9015)
3652
ef7b981d 36532011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3654
3655 * character.h (unicode_category_t): New enum type.
3656
3657 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3658 (Qchar_code_property_table): New variable.
3659 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3660 (UNIPROP_COMPRESSED_FORM_P): New macros.
3661 (char_table_ascii): Uncompress the compressed values.
3662 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3663 Uncompress the compressed values.
ac389d0c 3664 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3665 (char_table_ref_and_range): Uncompress the compressed values.
3666 (sub_char_table_set): New arg is_uniprop. Callers changed.
3667 Uncompress the compressed values.
3668 (sub_char_table_set_range): Args changed. Callers changed.
3669 (char_table_set_range): Adjuted for the above change.
3670 (map_sub_char_table): Delete args default_val and parent. Add arg
3671 top. Give decoded values to a Lisp function.
640c8776 3672 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3673 values to a Lisp function. Gcpro more variables.
3674 (uniprop_table_uncompress)
3675 (uniprop_decode_value_run_length): New functions.
3676 (uniprop_decoder, uniprop_decoder_count): New variables.
3677 (uniprop_get_decoder, uniprop_encode_value_character)
3678 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3679 New functions.
3680 (uniprop_encoder, uniprop_encoder_count): New variables.
3681 (uniprop_get_encoder, uniprop_table)
3682 (Funicode_property_table_internal, Fget_unicode_property_internal)
3683 (Fput_unicode_property_internal): New functions.
3684 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3685 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3686 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3687 char-code-property-alist.
3688
640c8776 3689 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3690 Vunicode_category_table.
3691
640c8776 3692 * font.c (font_range): Adjust for the change of
c805dec0
KH
3693 Vunicode_category_table.
3694
76b397fb
DN
36952011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3696
3697 * m/iris4d.h: Remove file, move contents ...
3698 * s/irix6-5.h: ... here.
3699
22b4128e
PE
37002011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3701
3702 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3703 * alloc.c (mark_buffer):
3704 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3705 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3706 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3707 This isn't true in general, and it's particularly not true
3708 if Emacs is configured with --with-wide-int.
3709 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3710 New macros, used in the buffer.c change.
3711
869795d6
JD
37122011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3713
3714 * xsettings.c: Use both GConf and GSettings if both are available.
3715 (store_config_changed_event): Add comment.
3716 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3717 (store_tool_bar_style_changed): New functions.
5e617bc2 3718 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3719 (struct xsettings): Move font inside HAVE_XFT.
3720 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3721 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3722 Move inside HAVE_XFT.
640c8776 3723 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3724 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3725 also.
3726 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3727 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3728 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3729 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3730 (parse_settings): Move check for font inside HAVE_XFT.
3731 (read_settings, apply_xft_settings): Add comment.
3732 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3733 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3734 call store_font_name_changed.
3735 (xft_settings_event): Add comment.
3736 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3737 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3738 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3739 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3740 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3741 (xsettings_get_system_font, xsettings_get_system_normal_font):
3742 Add comment.
869795d6 3743
d8ed26bd
PE
37442011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3745
3746 Random fixes. E.g., (random) never returned negative values.
3747 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3748 subseconds part to the entropy, as that's a bit more random.
3749 Prefer signed to unsigned, since the signedness doesn't matter and
3750 in general we prefer signed. When given a limit, use a
3751 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3752 latter isn't right if USE_2_TAGS_FOR_INTS.
3753 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3754 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3755
cabf1cac
SM
37562011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3757
3758 * textprop.c (text_property_stickiness):
3759 Obey Vtext_property_default_nonsticky.
3760 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3761 * w32fns.c (syms_of_w32fns):
3762 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3763
6e9b2be9
PE
37642011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3765
3766 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3767 This is more efficient than Ffile_directory_p and avoids a minor race.
3768
90186c68
LMI
37692011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3770
7c301272
LMI
3771 * buffer.c (Foverlay_put): Say what the return value is
3772 (bug#7835).
3773
c4f2d8d4
LMI
3774 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3775 is a directory before asking whether to use the file name
3776 (bug#7564).
ad637907
LMI
3777 (barf_or_query_if_file_exists): Make the "File is a directory"
3778 error be more correct.
c4f2d8d4 3779
90186c68
LMI
3780 * fns.c (Frequire): Remove the mention of the .gz files, since
3781 that's installation-specific, but keep the mention of
3782 `get-load-suffixes'.
3783
da64016e
PE
37842011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3785
3786 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3787 Report string overflow if the output is too long.
3788
7d47b580
JB
37892011-07-04 Juanma Barranquero <lekktu@gmail.com>
3790
a555cb87
JB
3791 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3792 (syms_of_gnutls): Remove duplicate DEFSYM for
3793 Qgnutls_bootprop_verify_hostname_error, an error for
3794 Qgnutls_bootprop_verify_error (which is no longer used).
3795
7d47b580
JB
3796 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3797 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3798 Also (re)move comments that are misplaced or no longer relevant.
3799
1e49bfab
LMI
38002011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3801
3802 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3803
1485f4c0
CY
38042011-07-03 Chong Yidong <cyd@stupidchicken.com>
3805
3806 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3807 and background color parameters if they have been changed.
3808
a9ab721e
LMI
38092011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3810
3811 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3812
cf7cff57
PE
38132011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3814
2e13213d
PE
3815 * xsettings.c (SYSTEM_FONT): Define only when used.
3816 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3817
cf7cff57
PE
3818 * keymap.c (access_keymap_1): Now static.
3819
7a8e04f7
CY
38202011-07-02 Chong Yidong <cyd@stupidchicken.com>
3821
3822 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3823 leave any prefix arg for the up event (Bug#1586).
3824
61352f62
LMI
38252011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3826
69bb1ef7
LMI
3827 * lread.c (syms_of_lread): Mention single symbols defined by
3828 `defvar' or `defconst' (bug#7154).
3829
61352f62 3830 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3831 (Frequire): Mention get-load-suffixes.
61352f62 3832
28545e04
MR
38332011-07-02 Martin Rudalics <rudalics@gmx.at>
3834
3835 * window.h (window): Remove clone_number slot.
3836 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3837 Remove.
3838 (make_parent_window, make_window, saved_window)
3839 (Fset_window_configuration, save_window_save): Don't deal with
3840 clone numbers.
3841 * buffer.c (Qclone_number): Remove declaration.
3842 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3843
3349e122
SM
38442011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3845
3846 Add multiple inheritance to keymaps.
3847 * keymap.c (Fmake_composed_keymap): New function.
3848 (Fset_keymap_parent): Simplify.
3849 (fix_submap_inheritance): Remove.
3850 (access_keymap_1): New function extracted from access_keymap to handle
3851 embedded parents and handle lists of maps.
3852 (access_keymap): Use it.
3853 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3854 (Fcopy_keymap): Handle embedded parents.
3855 (Fcommand_remapping, define_as_prefix): Simplify.
3856 (Fkey_binding): Simplify.
3857 (syms_of_keymap): Move minibuffer-local-completion-map,
3858 minibuffer-local-filename-completion-map,
3859 minibuffer-local-must-match-map, and
3860 minibuffer-local-filename-must-match-map to Elisp.
3861 (syms_of_keymap): Defsubr make-composed-keymap.
3862 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3863 (parse_menu_item): Trivial simplification.
3864
3279eb87
GM
38652011-07-01 Glenn Morris <rgm@gnu.org>
3866
3867 * Makefile.in (SETTINGS_LIBS): Fix typo.
3868
4550efdf
KI
38692011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3870
3871 * coding.c (Fencode_coding_string): Record the last coding system
3872 used, as the function doc string says (bug#8738).
3873
0949d2b6
JD
38742011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3875
3876 * xsettings.c (store_monospaced_changed): Take new font as arg and
3877 check for change against current_mono_font.
3878 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3879 (emacs_settings_constructor, emacs_settings_get_property)
3880 (emacs_settings_set_property, emacs_settings_class_init)
3881 (emacs_settings_init, gsettings_obj): Remove.
3882 (something_changedCB): New function for HAVE_GSETTINGS.
3883 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3884 with value as argument.
3885 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3886 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3887 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3888 "changed".
3889
3890 * xgselect.c: Add defined (HAVE_GSETTINGS).
3891 (xgselect_initialize): Ditto.
3892
3893 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3894 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3895 xg_select.
3896
bbc6b304
PE
38972011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3898
3899 * eval.c (struct backtrace): Simplify and port the data structure.
3900 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3901 signed bit field, as this assumption is not portable and it makes
3902 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3903 "char debug_on_exit : 1" as this is not portable either; instead,
3904 use the portable "unsigned int debug_on_exit : 1". Remove unused
3905 member evalargs. Remove obsolete comments about cc bombing out.
3906
9851bfc5
JD
39072011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3908
51bb811f 3909 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3910 Let HAVE_GSETTINGS override HAVE_GCONF.
3911 (store_monospaced_changed): New function.
3912 (EMACS_SETTINGS): A new type derived from GObject to handle
3913 GSettings notifications.
3914 (emacs_settings_constructor, emacs_settings_get_property)
3915 (emacs_settings_set_property, emacs_settings_class_init):
3916 New functions.
3917 (gsettings_client, gsettings_obj): New variables.
3918 (GSETTINGS_SCHEMA): New define.
3919 (something_changedCB): Call store_monospaced_changed.
3920 (init_gsettings): New function.
3921 (xsettings_initialize): Call init_gsettings.
3922 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3923 to NULL.
3924
640c8776 3925 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3926 GCONF_CFLAGS/LIBS.
3927
5386012d
MR
39282011-06-29 Martin Rudalics <rudalics@gmx.at>
3929
3930 * window.c (resize_root_window, grow_mini_window)
3931 (shrink_mini_window): Rename Qresize_root_window to
3932 Qwindow_resize_root_window and Qresize_root_window_vertically to
3933 Qwindow_resize_root_window_vertically.
3934
f13e0b08
PE
39352011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3936
3937 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3938
94515237
JB
39392011-06-27 Juanma Barranquero <lekktu@gmail.com>
3940
3941 * makefile.w32-in: Redesign dependencies so they reflect more
3942 clearly which files are directly included by each source file,
3943 and not through other includes.
3944
e43b6e43
MR
39452011-06-27 Martin Rudalics <rudalics@gmx.at>
3946
3947 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3948 (sort_overlays, overlay_strings): When an overlay's clone number
3949 matches the window's clone number process the overlay even if
3950 the overlay's window property doesn't match the current window.
3951
d68443dc
MR
3952 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3953 (Fwindow_hchild): Rename to Fwindow_left_child.
3954 (Fwindow_next): Rename to Fwindow_next_sibling.
3955 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3956 (resize_window_check): Rename to window_resize_check.
3957 (resize_window_apply): Rename to window_resize_apply.
3958 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3959 (Fdelete_other_windows_internal, resize_frame_windows)
3960 (Fsplit_window_internal, Fdelete_window_internal)
3961 (grow_mini_window, shrink_mini_window)
3962 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3963
c7e73be5
JD
39642011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3965
3966 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3967 (emacs_fixed_set_min_size): Remove.
3968 (emacs_fixed_new): Take frame as argument.
3969
3970 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3971 (_EmacsFixedPrivate): Remove minwidth/height.
3972 Add struct frame *f.
3973 (emacs_fixed_init): Initialize priv->f.
3974 (get_parent_class, emacs_fixed_set_min_size): Remove.
3975 (emacs_fixed_new): Set priv->f to argument.
3976 (emacs_fixed_get_preferred_width)
3977 (emacs_fixed_get_preferred_height): Use min_width/height from
3978 frames size_hint to set minimum and natural (Bug#8919).
3979 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3980 and use min_width/height from frames size_hint to set
3981 min_width/height (Bug#8919).
3982
3983 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3984 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3985 Fix indentation.
c7e73be5 3986
cf99dcf8
EZ
39872011-06-26 Eli Zaretskii <eliz@gnu.org>
3988
3989 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3990 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3991 called at ZV.
3992
029529ac
CY
39932011-06-26 Chong Yidong <cyd@stupidchicken.com>
3994
3995 * process.c (wait_reading_process_output): Bypass select if
3996 waiting for a cell while ignoring keyboard input, and input is
3997 pending. Suggested by Jan Djärv (Bug#8869).
3998
7a7ef429
PE
39992011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4000
4001 Use gnulib's dup2 module instead of rolling our own.
4002 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4003
11fdef7d 40042011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4005
4006 * dispnew.c (scrolling_window): Before scrolling, turn off a
4007 mouse-highlight in the window being scrolled.
4008
cd3520a4
JB
40092011-06-24 Juanma Barranquero <lekktu@gmail.com>
4010
4011 Move DEFSYM to lisp.h and use everywhere.
4012
4013 * character.h (DEFSYM): Move declaration...
4014 * lisp.h (DEFSYM): ...here.
4015
4016 * gnutls.c:
4017 * minibuf.c:
4018 * w32menu.c:
4019 * w32proc.c:
4020 * w32select.c: Don't include character.h.
4021
4022 * alloc.c (syms_of_alloc):
4023 * buffer.c (syms_of_buffer):
4024 * bytecode.c (syms_of_bytecode):
4025 * callint.c (syms_of_callint):
4026 * casefiddle.c (syms_of_casefiddle):
4027 * casetab.c (init_casetab_once):
4028 * category.c (init_category_once, syms_of_category):
4029 * ccl.c (syms_of_ccl):
4030 * cmds.c (syms_of_cmds):
4031 * composite.c (syms_of_composite):
4032 * dbusbind.c (syms_of_dbusbind):
4033 * dired.c (syms_of_dired):
4034 * dispnew.c (syms_of_display):
4035 * doc.c (syms_of_doc):
4036 * editfns.c (syms_of_editfns):
4037 * emacs.c (syms_of_emacs):
4038 * eval.c (syms_of_eval):
4039 * fileio.c (syms_of_fileio):
4040 * fns.c (syms_of_fns):
4041 * frame.c (syms_of_frame):
4042 * fringe.c (syms_of_fringe):
4043 * insdel.c (syms_of_insdel):
4044 * keymap.c (syms_of_keymap):
4045 * lread.c (init_obarray, syms_of_lread):
4046 * macros.c (syms_of_macros):
4047 * msdos.c (syms_of_msdos):
4048 * print.c (syms_of_print):
4049 * process.c (syms_of_process):
4050 * search.c (syms_of_search):
4051 * sound.c (syms_of_sound):
4052 * syntax.c (init_syntax_once, syms_of_syntax):
4053 * terminal.c (syms_of_terminal):
4054 * textprop.c (syms_of_textprop):
4055 * undo.c (syms_of_undo):
4056 * w32.c (globals_of_w32):
4057 * window.c (syms_of_window):
4058 * xdisp.c (syms_of_xdisp):
4059 * xfaces.c (syms_of_xfaces):
4060 * xfns.c (syms_of_xfns):
4061 * xmenu.c (syms_of_xmenu):
4062 * xsettings.c (syms_of_xsettings):
4063 * xterm.c (syms_of_xterm): Use DEFSYM.
4064
4228cf16
TZ
40652011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4066
cd3520a4 4067 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4068
7fcccf1e
PE
40692011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4070
7efb4e0e
PE
4071 Integer and buffer overflow fixes (Bug#8873).
4072
ff5844ad
PE
4073 * print.c (printchar, strout): Check for string overflow.
4074 (PRINTPREPARE, printchar, strout):
4075 Don't set size unless allocation succeeds.
4076
90532f02
PE
4077 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4078 for sizes. Check for string overflow more accurately.
4079 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4080
6d84508d
PE
4081 * macros.c: Integer and buffer overflow fixes.
4082 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4083 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4084 Use ptrdiff_t, not int, for sizes.
4085 Don't increment bufsize until after realloc succeeds.
4086 Check for size-calculation overflow.
4087 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4088
437b2cb4
PE
4089 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4090
8b9ac8b4
PE
4091 * lread.c: Integer overflow fixes.
4092 (read_integer): Radix is now EMACS_INT, not int,
4093 to improve quality of diagnostics for out-of-range radices.
4094 Calculate buffer size correctly for out-of-range radices.
4095 (read1): Check for integer overflow in radices, and in
4096 read-circle numbers.
82cb60d3
PE
4097 (read_escape): Avoid int overflow.
4098 (Fload, openp, read_buffer_size, read1)
4099 (substitute_object_recurse, read_vector, read_list, map_obarray):
4100 Use ptrdiff_t, not int, for sizes.
4101 (read1): Use EMACS_INT, not int, for sizes.
20270765 4102 Check for size overflow.
8b9ac8b4 4103
7fcccf1e
PE
4104 * image.c (cache_image): Check for size arithmetic overflow.
4105
bfbbd7e7
PE
4106 * lread.c: Integer overflow issues.
4107 (saved_doc_string_size, saved_doc_string_length)
4108 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4109 Now ptrdiff_t, not int.
4110 (read1): Don't assume doc string length fits in int. Check for
4111 out-of-range doc string lengths.
4112 (read_list): Don't assume file position fits in int.
39019e54 4113 (read_escape): Check for hex character overflow.
bfbbd7e7 4114
4e323265
LL
41152011-06-22 Leo Liu <sdl.web@gmail.com>
4116
4117 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4118 Move to minibuffer.el.
4119
85fece3e
PE
41202011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4121
20b84ce9 4122 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4123 The following patches are for when GLYPH_DEBUG && !XASSERT.
4124 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4125 * dispnew.c (flush_stdout):
4126 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4127 Mark as externally visible.
4128 * dispnew.c (check_window_matrix_pointers): Now static.
4129 * dispnew.c (window_to_frame_vpos):
4130 * xfns.c (unwind_create_frame):
4131 * xterm.c (x_check_font): Remove unused local.
4132 * scroll.c (CHECK_BOUNDS):
4133 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4134 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4135 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4136 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4137 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4138 Now static.
4139 (debug_method_add): Use va_list and vsprintf rather than relying
4140 on undefined behavior with wrong number of arguments.
4141 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4142 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4143 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4144 since we're not interested in debugging glyphs with old libraries.
4145 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4146 GCC 4.6.0's static checking.
4147
0766b489
PE
41482011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4149
31fd4b32
PE
4150 Integer overflow and signedness fixes (Bug#8873).
4151 A few related buffer overrun fixes, too.
4152
b79e8648
PE
4153 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4154
0766b489
PE
4155 * dispextern.h (struct face.stipple):
4156 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4157 (x_bitmap_mask, x_allocate_bitmap_record)
4158 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4159 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4160 (x_create_bitmap_from_xpm_data):
4161 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4162 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4163 (.bitmaps_last):
4164 * xfaces.c (load_pixmap):
4165 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4166 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4167 (.bitmaps_last, struct x_output.icon_bitmap):
4168 Use ptrdiff_t, not int, for bitmap indexes.
4169 (x_allocate_bitmap_record): Check for size overflow.
4170 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4171
b081724f
PE
4172 Use ptrdiff_t, not int, for overlay counts.
4173 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4174 * editfns.c (overlays_around, get_pos_property):
4175 * textprop.c (get_char_property_and_overlay):
4176 * xdisp.c (next_overlay_change, note_mouse_highlight):
4177 * xfaces.c (face_at_buffer_position):
21514da7
PE
4178 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4179 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4180 (Fnext_overlay_change, Fprevious_overlay_change)
4181 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4182 Use ptrdiff_t, not int, for sizes.
21514da7 4183 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4184
3de73e5e
PE
4185 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4186
2606c57b
PE
4187 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4188 (x_session_initialize): Do not assume string length fits in int.
4189
aaafe47a
PE
4190 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4191 This is unlikely, but can occur if DPI is outlandish.
4192
2674ddc8 4193 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4194 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4195
28154962
PE
4196 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4197 * xrdb.c (magic_file_p, search_magic_path):
4198 Omit last arg SUFFIX; it was always 0. All callers changed.
4199 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4200
7de51af5
PE
4201 * xfont.c (xfont_match): Avoid need for strlen.
4202
25ed6cc3
PE
4203 * xfns.c: Don't assume strlen fits in int.
4204 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4205
4eab31dd
PE
4206 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4207 not unsigned long, as we prefer signed integers. All callers changed.
4208 Detect integer overflow in repeat count.
4209 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4210 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4211
171e2a58
PE
4212 * termcap.c: Don't assume sizes fit in int and never overflow.
4213 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4214 (gobble_line): Check for size-calculation overflow.
4215
ad39faca 4216 * minibuf.c (Fread_buffer):
6e5bb2dc 4217 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4218 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4219 Don't assume string length fits in int.
4220
52c61c22 4221 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4222 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4223
b5b8c9e5
PE
4224 * font.c: Don't assume string length fits in int.
4225 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4226 Use ptrdiff_t, not int.
ccd6111c
PE
4227 (font_intern_prop): Don't assume string length fits in int.
4228 Don't assume integer property fits in fixnum.
4229 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4230
882f0d81 4231 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4232 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4233 Reformulate so as not to need the command string.
4234 Invoke gzip -cd rather than gunzip, as it's more portable.
4235 (lock_info_type, lock_file_1, lock_file):
4236 Don't assume pid_t and time_t fit in unsigned long.
4237 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4238 (current_lock_owner): Prefer signed type for sizes.
4239 Use memcpy, not strncpy, where memcpy is what is really wanted.
4240 Don't assume (via atoi) that time_t and pid_t fit in int.
4241 Check for time_t and/or pid_t out of range, e.g., via a network share.
4242 Don't alloca where an auto var works fine.
4243
93f4cf88
PE
4244 * fileio.c: Fix some integer overflow issues.
4245 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4246 Don't assume string length fits in int.
4247 (directory_file_name): Don't assume string length fits in long.
4248 (make_temp_name): Don't assume pid fits in int, or that its print
4249 length is less than 20.
4250
f3e92b69
PE
4251 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4252
1bfdaf10
PE
4253 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4254
35016e9a
PE
4255 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4256
3d1e65a1
PE
4257 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4258 We prefer signed integers, even for size calculations.
4259
0b963a93
PE
4260 * emacs.c: Don't assume string length fits in 'int'.
4261 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4262 (main): Don't invoke strlen when not needed.
4263
573f4b54
PE
4264 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
4265 (XD_DEBUG_MESSAGE): Don't waste a byte.
4266
989f33ba
PE
4267 * callproc.c (getenv_internal_1, getenv_internal)
4268 (Fgetenv_internal):
965d34eb
PE
4269 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
4270
e4d29b33
PE
4271 * lread.c (invalid_syntax): Omit length argument.
4272 All uses changed. This doesn't fix a bug, but it simplifies the
4273 code away from its former Hollerith-constant appearance, and it's
4274 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 4275 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 4276
eb49b136
PE
4277 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
4278 This didn't break anything, but it didn't help either.
4279 It's confusing to put a bogus integer in a place where the actual
4280 value does not matter.
9f62aeb1 4281 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 4282 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 4283
15375a22
PE
4284 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
4285 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
4286 implementation.
b61cc01c
PE
4287 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
4288 We prefer signed types, and the value cannot exceed the EMACS_INT
4289 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
4290 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
4291 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
4292 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 4293
53b2623d
PE
4294 * indent.c (sane_tab_width): New function.
4295 (current_column, scan_for_column, Findent_to, position_indentation)
4296 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 4297 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 4298
51cab52b 4299 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 4300
f2ed8a70
PE
4301 * lisp.h (lint_assume): New macro.
4302 * composite.c (composition_gstring_put_cache):
4303 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
4304
abe80cc6
PE
4305 * editfns.c, insdel.c:
4306 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 4307
b02c740e
PE
4308 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
4309
ebc96716
PE
4310 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
4311
b4e50fa0 4312 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 4313 Use much-faster test for byte-length change.
311d5d7c 4314 Don't assume string byte-length fits in 'int'.
a4cf38e4 4315 Check that character arg fits in 'int'.
85461888 4316 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 4317
c0c1ee9f
PE
4318 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
4319
a498d7f4
PE
4320 * fns.c (concat): Catch string overflow earlier.
4321 Do not rely on integer wraparound.
4322
51cab52b
PE
4323 * dispextern.h (struct it.overlay_strings_charpos)
4324 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4325 * xdisp.c (forward_to_next_line_start)
4326 (back_to_previous_visible_line_start)
4327 (reseat_at_next_visible_line_start, next_element_from_buffer):
4328 Don't arbitrarily truncate the value of 'selective' to int.
4329
76031fad
PE
4330 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4331
5eb55db9
PE
4332 * composite.c: Don't truncate sizes to 'int'.
4333 (composition_gstring_p, composition_reseat_it)
4334 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4335 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4336 not EMACS_UINT, for indexes.
5eb55db9 4337
0703a717
PE
4338 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4339
d6202519
PE
4340 * buffer.c: Include <verify.h>.
4341 (struct sortvec.priority, struct sortstr.priority):
8961a454 4342 Now EMACS_INT, not int.
c20998a7 4343 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4344 (struct sortstr.size, record_overlay_string)
4345 (struct sortstrlist.size, struct sortlist.used):
4346 Don't truncate size to int.
4347 (record_overlay_string): Check for size-calculation overflow.
d6202519 4348 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4349
d5a19415
JM
43502011-06-22 Jim Meyering <meyering@redhat.com>
4351
029529ac 4352 Don't leak an XBM-image-sized buffer
d5a19415
JM
4353 * image.c (xbm_load): Free the image buffer after using it.
4354
a9041e6c
PE
43552011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4356
4357 Port to Sun C.
4358 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4359 that Sun C diagnosed.
4360 * fns.c (secure_hash): Fix pointer signedness issue.
4361 * intervals.c (static_offset_intervals): New function.
4362 (offset_intervals): Use it.
4363
7f3f739f
LL
43642011-06-21 Leo Liu <sdl.web@gmail.com>
4365
4366 * deps.mk (fns.o):
4367 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4368 sha512.h.
4369
4370 * fns.c (secure_hash): Rename from crypto_hash_function and change
4371 the first arg to accept symbols.
5b66d427 4372 (Fsecure_hash): New primitive.
7f3f739f
LL
4373 (syms_of_fns): New symbols.
4374
76147d94
DD
43752011-06-20 Deniz Dogan <deniz@dogan.se>
4376
4377 * process.c (Fset_process_buffer): Clarify return value in
4378 docstring.
4379
7d7d0045
CY
43802011-06-18 Chong Yidong <cyd@stupidchicken.com>
4381
4382 * dispnew.c (add_window_display_history): Use BVAR.
4383
4384 * xdisp.c (debug_method_add): Use BVAR.
4385 (check_window_end, dump_glyph_matrix, dump_glyph)
4386 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4387
4388 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4389 Likewise.
4390
4391 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4392 check till after the cache is created in init_frame_faces.
4393
ff2bc410
SM
43942011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4395
4396 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4397
28177add
PE
43982011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4399
dd3482fe
PE
4400 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4401 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4402 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4403
393d71f3 4404 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4405 * fileio.c (Finsert_file_contents):
4406 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4407 Remove the old (too-loose) buffer overflow checks.
4408 They weren't needed, since make_gap checks for buffer overflow.
4409 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4410 The old code merely checked for Emacs fixnum overflow, and relied
4411 on undefined (wraparound) behavior. The new code avoids undefined
4412 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4413
2e6813b0 4414 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4415 Tune. Don't use wider integers than needed. Don't use alloca.
4416 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4417
599a9e4f
PE
4418 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4419
99561444
PE
4420 * insdel.c, lisp.h (buffer_overflow): New function.
4421 (insert_from_buffer_1, replace_range, replace_range_2):
4422 * insdel.c (make_gap_larger):
4423 * editfns.c (Finsert_char):
4424 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4425
28177add
PE
4426 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4427
e69dafad
PE
44282011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4429
a7af7fde 4430 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4431
b1c46f02
PE
4432 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4433 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4434
e69dafad
PE
4435 * fileio.c: Don't assume EMACS_INT fits in off_t.
4436 (emacs_lseek): New static function.
4437 (Finsert_file_contents, Fwrite_region): Use it.
4438 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4439
566684ea
PE
4440 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4441
e6966cd6
PE
4442 * fns.c: Don't overflow int when computing a list length.
4443 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4444 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4445 truncation on 64-bit hosts. Check for QUIT every
4446 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4447 faster and is responsive enough.
4448 (Flength): Report an error instead of overflowing an integer.
4449 (Fsafe_length): Return a float if the value is not representable
4450 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4451 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4452 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4453
dd0b0efb
PE
4454 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4455 (header_size, word_size): New constants.
4456 (allocate_vectorlike): Don't check size overflow here.
4457 (allocate_vector): Check it here instead, since this is the only
4458 caller of allocate_vectorlike that could cause overflow.
4459 Check that the new vector's length is representable as a fixnum.
4460
86fe5cfe
PE
4461 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4462 The previous code was bogus. For example, next_almost_prime (32)
4463 returned 39, which is undesirable as it is a multiple of 3; and
4464 next_almost_prime (24) returned 25, which is a multiple of 5 so
4465 why was the code bothering to check for multiples of 7?
4466
80e88859
PE
4467 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4468
4a2f0ad6
PE
4469 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4470
f66c7cf8
PE
4471 Variadic C functions now count arguments with ptrdiff_t.
4472 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4473 Back then I didn't know that the Emacs coding style prefers signed int.
4474 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4475 were being counted with int, which may truncate counts on 64-bit
4476 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4477 * lisp.h (struct Lisp_Subr.function.aMANY)
4478 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4479 Arg counts are now ptrdiff_t, not size_t.
4480 All variadic functions and their callers changed accordingly.
4481 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4482 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4483 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4484 * callint.c (Fcall_interactively): Check arg count for overflow,
4485 to avoid potential buffer overrun. Use signed char, not 'int',
4486 for 'varies' array, so that we needn't bother to check its size
4487 calculation for overflow.
4488 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4489 * eval.c (apply_lambda):
4490 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4491 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4492 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4493
a1759b76
PE
4494 * callint.c (Fcall_interactively): Don't use index var as event count.
4495
d96be9fc
PE
4496 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4497 * mem-limits.h (SIZE): Remove; no longer used.
4498
a690a978 4499 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4500
578c21e6
PE
4501 Remove unnecessary casts.
4502 * xterm.c (x_term_init):
4503 * xfns.c (x_set_border_pixel):
4504 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4505 These aren't needed now that we assume ANSI C.
4506
96f53c6c
PE
4507 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4508 It's more likely to cause problems (due to unsigned overflow)
4509 than to cure them.
4510
83c77d31
PE
4511 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4512
ee2079f1
PE
4513 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4514
6da65536
PE
4515 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4516
7147c4a4
PE
4517 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4518
193e32d9
PE
4519 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4520
e5533da6
PE
4521 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4522
9910e595
PE
4523 GLYPH_CODE_FACE returns EMACS_INT, not int.
4524 * dispextern.h (merge_faces):
4525 * xfaces.c (merge_faces):
01103c44
PE
4526 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4527 Don't assume EMACS_INT fits in int.
9910e595 4528
2638320e
PE
4529 * character.h (CHAR_VALID_P): Remove unused parameter.
4530 * fontset.c, lisp.h, xdisp.c: All uses changed.
4531
045eb8d9
PE
4532 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4533
c1f134b5
PE
4534 * fns.c (concat): Minor tuning based on overflow analysis.
4535 This doesn't fix any bugs. Use int to hold character, instead
4536 of constantly refetching from Emacs object. Use XFASTINT, not
4537 XINT, for value known to be a character. Don't bother comparing
4538 a single byte to 0400, as it's always less.
4539
395fcb93 4540 * floatfns.c (Fexpt):
327eeec8
PE
4541 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4542
abbd3d23
PE
4543 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4544 for characters.
4545
684a03ef
PE
4546 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4547
0fed43f3
PE
4548 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4549 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4550 incorrectly succeed when S was a string, because 4294967386 was
4551 truncated before it was used.
4552
8fd02eb7
PE
4553 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4554 Otherwise, an out-of-range integer could cause undefined behavior
4555 on a 64-bit host.
4556
f8c86b69
PE
4557 * composite.c: Use int, not EMACS_INT, for characters.
4558 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4559 EMACS_INT, for values that are known to be in character range.
4560 This doesn't fix any bugs but is the usual style inside Emacs and
4561 may generate better code on 32-bit machines.
4562
34206dd2
PE
4563 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4564 This is for reasons similar to the recent CHAR_STRING fix.
4565 * charset.c (Fencode_char): Check that character arg is actually
4566 a character. Pass an int to ENCODE_CHAR.
4567 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4568 wider than 'int', as a compile-time check to prevent future regressions
4569 in this area.
4570
c5958d4c 4571 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4572
4573 Make sure a 64-bit char is never passed to CHAR_STRING.
4574 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4575 by silently ignoring the top 32 bits, allowing some values
4576 that were far too large to be valid characters.
4577 * character.h: Include <verify.h>.
4578 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4579 arguments are no wider than unsigned, as a compile-time check
4580 to prevent future regressions in this area.
4581 * data.c (Faset):
01103c44 4582 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4583 (Fsubst_char_in_region):
4584 * fns.c (concat):
4585 * xdisp.c (decode_mode_spec_coding):
4586 Adjust to CHAR_STRING's new requirement.
4587 * editfns.c (Finsert_char, Fsubst_char_in_region):
4588 * fns.c (concat): Check that character args are actually
4589 characters. Without this test, these functions did the wrong
4590 thing with wildly out-of-range values on 64-bit hosts.
4591
d37ca623
PE
4592 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4593 These casts should not be needed on 32-bit hosts, either.
4594 * keyboard.c (read_char):
4595 * lread.c (Fload): Remove casts to unsigned.
4596
ea204efb
PE
4597 * lisp.h (UNSIGNED_CMP): New macro.
4598 This fixes comparison bugs on 64-bit hosts.
4599 (ASCII_CHAR_P): Use it.
4600 * casefiddle.c (casify_object):
01103c44 4601 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4602 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4603 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4604 * dispextern.h (FACE_FROM_ID):
4605 * keyboard.c (read_char): Use UNSIGNED_CMP.
4606
41cb286c
PE
4607 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4608 not to EMACS_INT, to avoid GCC warning.
4609
4a1b9832
PE
4610 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4611
55daad71
PE
4612 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4613 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4614 isn't needed on 32-bit machines.
8f95c75c 4615
01103c44
PE
4616 * buffer.c (Fgenerate_new_buffer_name):
4617 Use EMACS_INT for count, not int.
0ceccced 4618 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4619
4620 * data.c (Qcompiled_function): Now static.
4621
c6f072e7
PE
4622 * window.c (window_body_lines): Now static.
4623
20ce5912
PE
4624 * image.c (gif_load): Rename local to avoid shadowing.
4625
9c4c5f81
PE
4626 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4627 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4628 * alloc.c (make_save_value): Integer argument is now of type
4629 ptrdiff_t, not int.
4630 (mark_object): Use ptrdiff_t, not int.
4631 * lisp.h (pD): New macro.
4632 * print.c (print_object): Use it.
4633
c0c5c8ae
PE
4634 * alloc.c: Use EMACS_INT, not int, to count objects.
4635 (total_conses, total_markers, total_symbols, total_vector_size)
4636 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4637 (total_free_floats, total_floats, total_free_intervals)
4638 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4639 Now EMACS_INT, not int. All uses changed.
4640 (Fgarbage_collect): Compute overall total using a double, so that
4641 integer overflow is less likely to be a problem. Check for overflow
4642 when converting back to an integer.
5a25e253
PE
4643 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4644 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4645 These were 'int' variables that could overflow on 64-bit hosts;
4646 they were never used, so remove them instead of repairing them.
211a0b2a 4647 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4648 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4649 Previously, this ceilinged at INT_MAX, but that doesn't work on
4650 64-bit machines.
e46bb31a 4651 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4652
c78baabf 4653 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4654 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4655 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4656 when a (possibly-narrower) signed value would do just as well.
4657 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4658
c9d624c6
PE
4659 * alloc.c: Catch some string size overflows that we were missing.
4660 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4661 for convenience in STRING_BYTES_MAX.
4662 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4663 The definition here is exact; the one in lisp.h was approximate.
4664 (allocate_string_data): Check for string overflow. This catches
4665 some instances we weren't catching before. Also, it catches
4666 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4667 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4668 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4669
c9d624c6
PE
4670 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4671 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4672 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4673
353032ce
PE
4674 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4675
2bccce07
PE
4676 * alloc.c (Fmake_string): Check for out-of-range init.
4677
0ac30604
SM
46782011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4679
4680 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4681
c195f2de
JD
46822011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4683
4684 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4685 xg_get_default_scrollbar_width.
4686
4687 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4688 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4689 (style_changed_cb): Call update_theme_scrollbar_width and call
4690 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4691 all frames (Bug#8505).
4692 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4693 Call gtk_window_set_resizable if HAVE_GTK3.
4694 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4695 and height if HAVE_GTK3 (Bug#8505).
4696 (scroll_bar_width_for_theme): New variable.
4697 (update_theme_scrollbar_width): New function.
4698 (xg_get_default_scrollbar_width): Move code to
4699 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4700 (xg_initialize): Call update_theme_scrollbar_width.
4701
4702 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4703
4704 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4705
e10ac9f1
MR
47062011-06-12 Martin Rudalics <rudalics@gmx.at>
4707
4708 * frame.c (make_frame): Call other_buffer_safely instead of
4709 other_buffer.
4710
4711 * window.c (temp_output_buffer_show): Call display_buffer with
4712 second argument Vtemp_buffer_show_specifiers and reset latter
4713 immediately after the call.
4714 (Vtemp_buffer_show_specifiers): New variable.
4715 (auto_window_vscroll_p, next_screen_context_lines)
4716 (Vscroll_preserve_screen_position): Remove leading asterisks from
4717 doc-strings.
4718
2d3c217e 47192011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4720
7b7f97e8 4721 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4722 * buffer.c (Qclone_number): Remove for now, as it's unused.
4723 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4724 (record_buffer): Remove unused local.
4725 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4726 (set_frame_buffer_list): Remove; unused.
4727 * frame.h (other_visible_frames): Remove decl.
4728 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4729 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4730 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4731 if HAVE_GPM.
4732 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4733 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4734 Define only if HAVE_GPM.
4735 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4736 (update_hints_inhibit): Remove; never set. All uses removed.
4737 * widgetprv.h (emacsFrameClassRec): Remove decl.
4738 * window.c (delete_deletable_window): Now returns void, since it
4739 wasn't returning anything.
4740 (compare_window_configurations): Remove unused locals.
4741 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4742 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4743 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4744 the same widths as pointers. This follows up on the 2011-05-06 patch.
4745 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4746 * xterm.h: Likewise.
4747 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4748
1384b89e
JB
47492011-06-12 Juanma Barranquero <lekktu@gmail.com>
4750
4751 * makefile.w32-in: Update dependencies.
4752 (LISP_H): Add lib/intprops.h.
4753
1100a63c
CY
47542011-06-11 Chong Yidong <cyd@stupidchicken.com>
4755
4756 * image.c (gif_load): Add animation frame delay to the metadata.
4757 (syms_of_image): Use DEFSYM. New symbol `delay'.
4758
6198ccd0
MR
47592011-06-11 Martin Rudalics <rudalics@gmx.at>
4760
4761 * window.c (delete_deletable_window): Re-add.
4762 (Fset_window_configuration): Rewrite to handle dead buffers and
4763 consequently deletable windows.
4764 (window_tree, Fwindow_tree): Remove. Supply functionality in
4765 window.el.
4766 (compare_window_configurations): Simplify code.
4767
b6e3633c
AS
47682011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4769
1ab0dee5
AS
4770 * image.c (imagemagick_load_image): Fix type mismatch.
4771 (Fimagemagick_types): Likewise.
4772
b6e3633c
AS
4773 * window.h (replace_buffer_in_windows): Declare.
4774
9397e56f
MR
47752011-06-11 Martin Rudalics <rudalics@gmx.at>
4776
4777 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4778 Qclone_number. Remove external declaration of Qdelete_window.
4779 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4780 code.
640c8776
SM
4781 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4782 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4783 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4784 buffer list implementation.
4785 (other_buffer_safely): New function.
4786 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4787 calls to replace_buffer_in_windows and
4788 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4789 if allowed.
4790 (record_buffer): Inhibit quitting and rewrite using quittable
4791 functions. Run Qbuffer_list_update_hook if allowed.
4792 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4793 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4794 Move switch-to-buffer to window.el.
9397e56f
MR
4795 (bury-buffer): Move to window.el.
4796 (Vbuffer_list_update_hook): New variable.
4797
4798 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4799 section.
4800
4801 * window.h (resize_frame_windows): Move up in code.
4802 (Fwindow_frame): Remove EXFUN.
4803 (replace_buffer_in_all_windows): Remove prototype.
4804 (replace_buffer_in_windows_safely): Add prototype.
4805
4806 * window.c: Declare Qdelete_window static again. Move down
4807 declaration of select_count.
4808 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4809 (Fother_window): Move to window.el.
4810 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4811 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4812 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4813 window.el.
4814 (replace_buffer_in_windows): Implement by calling
4815 Qreplace_buffer_in_windows.
4816 (replace_buffer_in_all_windows): Remove with some functionality
4817 moved into replace_buffer_in_windows_safely.
4818 (replace_buffer_in_windows_safely): New function.
4819 (select_window_norecord, select_frame_norecord): Move in front
4820 of run_window_configuration_change_hook. Remove now obsolete
4821 declarations.
640c8776
SM
4822 (Fset_window_buffer): Rewrite doc-string.
4823 Call Qrecord_window_buffer.
9397e56f
MR
4824 (keys_of_window): Move binding for other-window to window.el.
4825
b50691aa
CY
48262011-06-11 Chong Yidong <cyd@stupidchicken.com>
4827
4828 * dispextern.h (struct image): Replace data member, whose int_val
4829 and ptr_val fields were not used by anything, with a single
4830 lisp_val object.
4831
4832 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4833 (gif_clear_image, gif_load, imagemagick_load_image)
4834 (gs_clear_image, gs_load): Callers changed.
4835
3f754b86
PE
48362011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4837
cca69397
PE
4838 * buffer.h: Include <time.h>, for time_t.
4839 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4840
109e28d0
PE
4841 Fix minor problems found by static checking.
4842
60737f02
PE
4843 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4844
4b66faf3
PE
4845 Make identifiers static if they are not used in other modules.
4846 * data.c (Qcompiled_function, Qframe, Qvector):
4847 * image.c (QimageMagick, Qsvg):
4848 * minibuf.c (Qmetadata):
4849 * window.c (resize_window_check, resize_root_window): Now static.
4850 * window.h (resize_window_check, resize_root_window): Remove decls.
4851
109e28d0
PE
4852 * window.c (window_deletion_count, delete_deletable_window):
4853 Remove; unused.
46a4ce9e
PE
4854 (window_body_lines): Now static.
4855 (Fdelete_other_windows_internal): Mark vars as initialized.
4856 Make sure 'resize_failed' is initialized.
4857 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4858 (resize_window_apply): Remove unused local.
4859 * window.h (delete_deletable_window): Remove decl.
4860
109e28d0 4861 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4862 (imagemagick_load_image): Fix pointer signedness problem by changing
4863 last arg from unsigned char * to char *. All uses changed.
4864 Also, fix a local for similar reasons.
4865 Remove unused locals. Remove locals to avoid shadowing.
4866 (fn_rsvg_handle_free): Remove; unused.
4867 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4868 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4869
3f754b86
PE
4870 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4871
2547adb1
CY
48722011-06-10 Chong Yidong <cyd@stupidchicken.com>
4873
4874 * image.c (gif_load): Fix omitted cast error introduced by
4875 2011-06-06 change.
4876
2c8e37d4
MR
48772011-06-10 Martin Rudalics <rudalics@gmx.at>
4878
4879 * window.h (resize_proportionally, orig_total_lines)
4880 (orig_top_line): Remove from window structure.
4881 (set_window_height, set_window_width, change_window_heights)
4882 (Fdelete_window): Remove prototypes.
4883 (resize_frame_windows): Remove duplicate declaration.
4884
440a42e3
EZ
48852011-06-10 Eli Zaretskii <eliz@gnu.org>
4886
4887 * window.h (resize_frame_windows, resize_window_check)
4888 (delete_deletable_window, resize_root_window)
4889 (resize_frame_windows): Declare prototypes.
4890
4891 * window.c (resize_window_apply): Make definition be "static" to
4892 match the prototype.
4893
562dd5e9
MR
48942011-06-10 Martin Rudalics <rudalics@gmx.at>
4895
4896 * window.c: Remove declarations of Qwindow_size_fixed,
4897 window_min_size_1, window_min_size_2, window_min_size,
4898 size_window, window_fixed_size_p, enlarge_window, delete_window.
4899 Remove static from declaration of Qdelete_window, it's
4900 temporarily needed by Fbury_buffer.
4901 (replace_window): Don't assign orig_top_line and
4902 orig_total_lines.
4903 (Fdelete_window, delete_window): Remove. Window deletion is
4904 handled by window.el.
640c8776
SM
4905 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4906 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4907 (Fdelete_other_windows): Remove. Deleting other windows is
4908 handled by window.el.
4909 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4910 handled in window.el.
4911 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4912 Window minimum sizes are handled in window.el.
4913 (shrink_windows, size_window, set_window_height)
4914 (set_window_width, change_window_heights, window_height)
4915 (window_width, CURBEG, CURSIZE, enlarge_window)
4916 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4917 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4918 handled in window.el.
4919 (make_dummy_parent): Rename to make_parent_window and give it a
4920 second argument horflag.
4921 (make_window): Don't set resize_proportionally any more.
4922 (Fsplit_window): Remove. Windows are split in window.el.
4923 (save_restore_action, save_restore_orig_size)
4924 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4925 Resize mini windows in window.el.
4926 (grow_mini_window, shrink_mini_window): Implement by calling
4927 Qresize_root_window_vertically, resize_window_check and
4928 resize_window_apply.
640c8776
SM
4929 (saved_window, Fset_window_configuration, save_window_save):
4930 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4931 resize_proportionally.
4932 (window_min_height, window_min_width): Move to window.el.
4933 (keys_of_window): Move bindings for delete-other-windows,
4934 split-window, delete-window and enlarge-window to window.el.
4935
4936 * buffer.c: Temporarily extern Qdelete_window.
4937 (Fbury_buffer): Temporarily call Qdelete_window instead of
4938 Fdelete_window (Fbury_buffer will move to window.el soon).
4939
4940 * frame.c (set_menu_bar_lines_1): Remove code handling
4941 orig_top_line and orig_total_lines.
4942
4943 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4944 set_window_height but set heights directly.
4945 (change_frame_size_1): Use resize_frame_windows.
4946
4947 * xdisp.c (init_xdisp): Don't use set_window_height but set
4948 heights directly.
4949
640c8776
SM
4950 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4951 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4952 run_window_configuration_change_hook.
4953
4954 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4955 instead of change_window_heights and run
4956 run_window_configuration_change_hook.
4957
1a13852e
MR
49582011-06-09 Martin Rudalics <rudalics@gmx.at>
4959
4960 * window.c (replace_window): Rename second argument REPLACEMENT to
4961 NEW. New third argument SETFLAG. Rewrite.
4962 (delete_window, make_dummy_parent): Call replace_window with
4963 third argument 1.
4964 (window_list_1): Move down in code.
4965 (run_window_configuration_change_hook): Move set_buffer part
4966 before select_frame_norecord part in order to unwind correctly.
4967 Rename count1 to count.
4968 (recombine_windows, delete_deletable_window, resize_root_window)
4969 (Fdelete_other_windows_internal)
4970 (Frun_window_configuration_change_hook, make_parent_window)
4971 (resize_window_check, resize_window_apply, Fresize_window_apply)
4972 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4973 (Fdelete_window_internal, Fresize_mini_window_internal):
4974 New functions.
1a13852e
MR
4975 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4976
f3d1777e
MR
49772011-06-08 Martin Rudalics <rudalics@gmx.at>
4978
496e208e
MR
4979 * window.h (window): Add some new members to window structure -
4980 normal_lines, normal_cols, new_total, new_normal, clone_number,
4981 splits, nest, prev_buffers, next_buffers.
4982 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4983 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4984
f3d1777e
MR
4985 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4986 Remove.
496e208e
MR
4987 (make_dummy_parent): Set new members of windows structure.
4988 (make_window): Move down in code. Handle new members of window
4989 structure.
4990 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4991 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4992 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4993 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4994 (Fset_window_next_buffers, Fset_window_clone_number):
4995 New functions.
496e208e
MR
4996 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4997 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4998 Doc-string fixes.
4999 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5000 Argument WINDOW can be now internal window too.
5001 (Fwindow_use_time): Move up in code.
5002 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5003 Rewrite doc-string.
5004 (Fset_window_configuration, saved_window)
5005 (Fcurrent_window_configuration, save_window_save): Handle new
5006 members of window structure.
b9e809c2
MR
5007 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5008 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5009 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5010 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5011 Qget_mru_window, Qresize_root_window,
5012 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5013 Qauto_buffer_name; staticpro them.
f3d1777e 5014
abde8f8c
MR
50152011-06-07 Martin Rudalics <rudalics@gmx.at>
5016
5017 * window.c (Fwindow_total_size, Fwindow_left_column)
5018 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5019 (Fwindow_list_1): New functions.
5020 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5021 (Fwindow_width, Fscroll_left, Fscroll_right):
5022 Use window_body_cols instead of window_box_text_cols.
5023 (delete_window, Fset_window_configuration):
5024 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5025 (delete_all_subwindows): Take a window as argument and not a
5026 structure. Rewrite.
190b47e6
MR
5027 (window_loop): Remove handling of GET_LRU_WINDOW and
5028 GET_LARGEST_WINDOW.
5029 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5030
5031 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5032 window_box_text_cols. delete_all_subwindows now takes a
5033 Lisp_Object as argument.
abde8f8c 5034
640c8776
SM
5035 * indent.c (compute_motion, Fcompute_motion):
5036 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5037
fa8a67e6
MR
5038 * frame.c (delete_frame): Call delete_all_subwindows with root
5039 window as argument.
5040
a54e3482
DC
50412011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5042
5043 * fns.c (Fputhash): Document return value.
5044
60002bf5
CY
50452011-06-06 Chong Yidong <cyd@stupidchicken.com>
5046
5047 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5048
0c671da6 50492011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5050
b862a52a 5051 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5052
be44ca6c
PE
5053 Check for overflow when converting integer to cons and back.
5054 * charset.c (Fdefine_charset_internal, Fdecode_char):
5055 Use cons_to_unsigned to catch overflow.
5056 (Fencode_char): Use INTEGER_TO_CONS.
5057 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5058 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5059 * data.c (long_to_cons, cons_to_long): Remove.
5060 (cons_to_unsigned, cons_to_signed): New functions.
5061 These signal an error for invalid or out-of-range values.
5062 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5063 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5064 * font.c (Ffont_variation_glyphs):
5065 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5066 * lisp.h: Include <intprops.h>.
5067 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5068 (cons_to_signed, cons_to_unsigned): New decls.
5069 (long_to_cons, cons_to_long): Remove decls.
5070 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5071 (Fprimitive_undo): Use CONS_TO_INTEGER.
5072 * xfns.c (Fx_window_property): Likewise.
5073 * xselect.c: Include <limits.h>.
5074 (x_own_selection, selection_data_to_lisp_data):
5075 Use INTEGER_TO_CONS.
5076 (x_handle_selection_request, x_handle_selection_clear)
5077 (x_get_foreign_selection, Fx_disown_selection_internal)
5078 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5079 (lisp_data_to_selection_data): Use cons_to_unsigned.
5080 (x_fill_property_data): Use cons_to_signed.
5081 Report values out of range.
5082
d1f3d2af
PE
5083 Check for buffer and string overflow more precisely.
5084 * buffer.h (BUF_BYTES_MAX): New macro.
5085 * lisp.h (STRING_BYTES_MAX): New macro.
5086 * alloc.c (Fmake_string):
5087 * character.c (string_escape_byte8):
5088 * coding.c (coding_alloc_by_realloc):
5089 * doprnt.c (doprnt):
5090 * editfns.c (Fformat):
5091 * eval.c (verror):
5092 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5093 since they may not be the same number.
5094 * editfns.c (Finsert_char):
5095 * fileio.c (Finsert_file_contents):
5096 Likewise for BUF_BYTES_MAX.
5097
dd52fcea
PE
5098 * image.c: Use ptrdiff_t, not int, for sizes.
5099 (slurp_file): Switch from int to ptrdiff_t.
5100 All uses changed.
5101 (slurp_file): Check that file size fits in both size_t (for
5102 malloc) and ptrdiff_t (for sanity and safety).
5103
7f9bbdbb
PE
5104 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5105 if b->modtime has its maximal value.
5106
dfe18f82
PE
5107 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5108
84acfcf0
PE
5109 Don't assume time_t can fit into int.
5110 * buffer.h (struct buffer.modtime): Now time_t, not int.
5111 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5112 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5113
ccd9a01a
PE
5114 Minor fixes for signed vs unsigned integers.
5115 * character.h (MAYBE_UNIFY_CHAR):
5116 * charset.c (maybe_unify_char):
5117 * keyboard.c (read_char, reorder_modifiers):
5118 XINT -> XFASTINT, since the integer must be nonnegative.
5119 * ftfont.c (ftfont_spec_pattern):
5120 * keymap.c (access_keymap, silly_event_symbol_error):
5121 XUINT -> XFASTINT, since the integer must be nonnegative.
5122 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5123 since it makes no difference and we prefer signed.
5124 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5125 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5126 nonnegative.
5127
d6d100dd
SM
51282011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5129
5130 * window.h (Fwindow_frame): Declare.
5131
2b6148e4
PE
51322011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5133
5134 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5135 (SPARE_MEMORY): Always define.
5136 (LARGE_REQUEST): Remove.
5137 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5138
f230ecc9
MR
51392011-06-06 Martin Rudalics <rudalics@gmx.at>
5140
727e958e
MR
5141 * lisp.h: Move EXFUNS for Fframe_root_window,
5142 Fframe_first_window and Fset_frame_selected_window to window.h.
5143
5144 * window.h: Move EXFUNS for Fframe_root_window,
5145 Fframe_first_window and Fset_frame_selected_window here from
5146 lisp.h.
5147
5148 * frame.c (Fwindow_frame, Fframe_first_window)
5149 (Fframe_root_window, Fframe_selected_window)
5150 (Fset_frame_selected_window): Move to window.c.
5151 (Factive_minibuffer_window): Move to minibuf.c.
5152 (Fother_visible_frames_p): New function.
5153
5154 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5155
f230ecc9
MR
5156 * window.c (decode_window, decode_any_window): Move up in code.
5157 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5158 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5159 (Fwindow_buffer): Move up and rewrite doc-string.
5160 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5161 (Fwindow_prev): New functions.
727e958e
MR
5162 (Fwindow_frame): Move here from frame.c. Accept any window as
5163 argument.
5164 (Fframe_root_window, Fframe_first_window)
5165 (Fframe_selected_window): Move here from frame.c. Accept frame
5166 or arbitrary window as argument. Update doc-strings.
5167 (Fminibuffer_window): Move up in code.
5168 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5169 (Fset_frame_selected_window): Move here from frame.c.
5170 Marginal rewrite.
727e958e
MR
5171 (Fselected_window, select_window, Fselect_window): Move up in
5172 code. Minor doc-string fixes.
f230ecc9 5173
4d09bcf6
PE
51742011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5175
5176 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5177 Do not assume that spare memory exists; that assumption is valid
5178 only if SYSTEM_MALLOC.
5179 (LARGE_REQUEST): New macro, so that the issue of large requests
5180 is separated from the issue of spare memory.
5181
810928a2
AS
51822011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5183
172418ad
AS
5184 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5185 format. (Bug#8806)
5186
43f862f7
AS
5187 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5188
810928a2
AS
5189 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5190 before statements.
5191
a059fe24
JD
51922011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5193
5194 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5195
5196 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5197
5198 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5199 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5200
989bf368
JB
52012011-06-05 Juanma Barranquero <lekktu@gmail.com>
5202
5203 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5204
4b80f674
CY
52052011-06-04 Chong Yidong <cyd@stupidchicken.com>
5206
5207 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5208 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5209 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5210 New error handlers.
4b80f674
CY
5211 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5212 Obey Vx_select_enable_clipboard_manager. Catch errors in
5213 x_clipboard_manager_save (Bug#8779).
5214 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5215 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5216
99a33b77 52172011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5218
5219 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5220
99a33b77 52212011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5222
5223 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5224 in the current matrix if keep_current_p is non-zero.
5225
8264569d
EZ
52262011-06-04 Eli Zaretskii <eliz@gnu.org>
5227
5228 * bidi.c (bidi_level_of_next_char): Fix last change.
5229
57f97249
EZ
52302011-06-03 Eli Zaretskii <eliz@gnu.org>
5231
fec2107c 5232 Support bidi reordering of text covered by display properties.
57f97249 5233
fec2107c
EZ
5234 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5235 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5236 (bidi_cache_search, bidi_cache_iterator_state)
5237 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5238 (bidi_level_of_next_char, bidi_move_to_visually_next):
5239 Support character positions inside a run of characters covered by a
fec2107c
EZ
5240 display string.
5241 (bidi_paragraph_init, bidi_resolve_explicit_1)
5242 (bidi_level_of_next_char): Call bidi_fetch_char and
5243 bidi_fetch_char_advance instead of FETCH_CHAR and
5244 FETCH_CHAR_ADVANCE.
5245 (bidi_init_it): Initialize new members.
5246 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5247 definitions.
5248 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5249 instead of using explicit *_CHAR codes.
d6d100dd
SM
5250 (bidi_resolve_explicit, bidi_resolve_weak):
5251 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5252 bidirectional text is supported only in multibyte buffers.
5253 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5254 it to initialize the frame_window_p member of struct bidi_it.
5255 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5256 (bidi_resolve_explicit, bidi_resolve_weak)
5257 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5258 bidi_it->nchars is non-positive.
5259 (bidi_level_of_next_char): Don't try to lookup the cache for the
5260 next/previous character if nothing is cached there yet, or if we
5261 were just reseat()'ed to a new position.
c40e2fb2 5262
0e14fe90
EZ
5263 * xdisp.c (set_cursor_from_row): Set start and stop points
5264 according to the row's direction when priming the loop that looks
5265 for the glyph on which to display cursor.
5266 (single_display_spec_intangible_p): Function deleted.
5267 (display_prop_intangible_p): Reimplement to call
5268 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
5269 Accept 3 additional arguments needed by handle_display_spec.
5270 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
5271 values: lists, `(when COND...)' forms, etc.
5272 (single_display_spec_string_p): Support property values that are
5273 lists with the argument STRING its top-level element.
5274 (display_prop_string_p): Fix the condition for processing a
5275 property that is a list to be consistent with handle_display_spec.
fec2107c 5276 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
5277 last portion of handle_display_prop.
5278 (compute_display_string_pos): Accept additional argument
5279 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
5280 value of a `display' property is a "replacing spec".
5281 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
5282 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
5283 the display property, but just return a value indicating whether
5284 the display property will replace the characters it covers.
5285 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
5286 frame_window_p members of struct bidi_it.
d6d100dd
SM
5287 (compute_display_string_pos, compute_display_string_end):
5288 New functions.
fec2107c
EZ
5289 (push_it): Accept second argument POSITION, where pop_it should
5290 jump to continue iteration.
5291 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 5292
fec2107c
EZ
5293 * keyboard.c (adjust_point_for_property): Adjust the call to
5294 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
5295
5296 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
5297 (bidi_init_it): Update prototypes.
5298 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
5299 (compute_display_string_pos, compute_display_string_end):
5300 Declare prototypes.
fec2107c
EZ
5301 (struct bidi_it): New members nchars and disp_pos. ch_len is now
5302 EMACS_INT.
fc6f18ce 5303
40087514 53042011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 5305
57f53182
PE
5306 Malloc failure behavior now depends on size of allocation.
5307 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
5308 * lisp.h: Change signatures accordingly.
5309 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
5310 All callers changed. (Bug#8762)
5311
5312 * gnutls.c: Use Emacs's memory allocators.
5313 Without this change, the gnutls library would invoke malloc etc.
5314 directly, which causes problems on non-SYNC_INPUT hosts, and which
5315 runs afoul of improving memory_full behavior. (Bug#8761)
5316 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
5317 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
5318 xfree instead of the default malloc, realloc, free.
5319 (Fgnutls_boot): No need to check for memory allocation failure,
5320 since xmalloc does that for us.
5321
ac32cd99 5322 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
5323 * category.c (hash_get_category_set):
5324 * ccl.c (ccl_driver):
5325 * charset.c (Fdefine_charset_internal):
5326 * charset.h (struct charset.hash_index):
5327 * composite.c (get_composition_id, gstring_lookup_cache)
5328 (composition_gstring_put_cache):
5329 * composite.h (struct composition.hash_index):
5330 * dispextern.h (struct image.hash):
5331 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5332 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5333 (hashfn_equal, hashfn_user_defined, make_hash_table)
5334 (maybe_resize_hash_table, hash_lookup, hash_put)
5335 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5336 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5337 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5338 * image.c (make_image, search_image_cache, lookup_image)
5339 (xpm_put_color_table_h):
5340 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5341 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5342 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5343 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5344 * alloc.c (allocate_vectorlike):
5345 Check for overflow in vector size calculations.
5346 * ccl.c (ccl_driver):
5347 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5348 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5349 need to be updated by these changes.
40087514
PE
5350 * fns.c (make_hash_table, maybe_resize_hash_table):
5351 Check for integer overflow with large hash tables.
0de4bb68
PE
5352 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5353 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5354 (SXHASH_REDUCE): New macro.
5355 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5356 Use it instead of discarding useful hash info with large hash values.
5357 (sxhash_float): New function.
5358 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5359 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5360 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5361 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5362 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5363 Adjust signatures to match updated version of code.
5364 (consing_since_gc): Now EMACS_INT, since a single hash table can
5365 use more than INT_MAX bytes.
5366
698d32e2
DN
53672011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5368
5369 Make it possible to build with GCC-4.6+ -O2 -flto.
5370
5371 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5372
fd6fa53f
SM
53732011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5374
5375 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5376 Call minibuffer-inactive-mode.
5377
864db017
JB
53782011-05-31 Juanma Barranquero <lekktu@gmail.com>
5379
5380 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5381 Update dependencies.
5382
2ad0baf4
DN
53832011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5384
5385 * data.c (init_data): Remove code for UTS, this system is not
5386 supported anymore.
5387
4fcc2638
DN
53882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5389
5390 Don't force ./temacs to start in terminal mode.
5391
5392 * frame.c (make_initial_frame): Initialize faces in all cases, not
5393 only when CANNOT_DUMP is defined.
5394 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5395
c56e0fd5
DN
53962011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5397
5398 * dispnew.c (add_window_display_history): Use const for the string
5399 pointer. Remove declaration, not needed.
5400
333d54da 54012011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5402
55d4c1b2 5403 Use 'inline', not 'INLINE'.
333d54da 5404 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5405 * alloc.c, fontset.c (INLINE): Remove.
5406 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5407 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5408 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5409 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5410 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5411
738db178
DN
54122011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5413
5414 Make it possible to run ./temacs.
5415
5416 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5417 syms_of_callproc does the same thing. Remove test for
5418 "initialized", do it in the caller.
5419 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5420
620c53a6
SM
54212011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5422
5423 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5424 (read_minibuf): Use get_minibuffer.
5425 (syms_of_minibuf): Use DEFSYM.
5426 (Qmetadata): New var.
5427 * data.c (Qbuffer): Don't make it static.
5428 (syms_of_data): Use DEFSYM.
5429
e003a292
PE
54302011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5431
5432 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5433 (CCL_CODE_MIN): New macro.
5434
ed008a6d
PE
54352011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5436
3687c2ef
PE
5437 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5438
ed008a6d
PE
5439 * eval.c (Qdebug): Now static.
5440 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5441 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5442 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5443
d66c4c7c
CY
54442011-05-29 Chong Yidong <cyd@stupidchicken.com>
5445
5446 * image.c: Various fixes to ImageMagick code comments.
5447 (Fimagemagick_types): Doc fix.
5448
5fbc2025
PE
54492011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5450
0196f88a
PE
5451 Minor fixes prompted by GCC 4.6.0 warnings.
5452
5453 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5454
5fbc2025
PE
5455 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5456 (x_clipboard_manager_save_all): Move extern decl to ...
5457 * xterm.h: ... here, so that it can be checked for consistency.
5458
1dd3c2d9
CY
54592011-05-29 Chong Yidong <cyd@stupidchicken.com>
5460
5461 * xselect.c (x_clipboard_manager_save_frame)
5462 (x_clipboard_manager_save_all): New functions.
5463 (Fx_clipboard_manager_save): Lisp function deleted.
5464
5465 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5466 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5467
5468 * xterm.h: Update prototype.
5469
5ba6571d
WX
54702011-05-28 William Xu <william.xwl@gmail.com>
5471
5472 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5473 exiting (Bug#8239).
5474
3eaff834
JM
54752011-05-28 Jim Meyering <meyering@redhat.com>
5476
e1900994 5477 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5478 * fns.c (to_uchar): Define.
5479 (crypto_hash_function): Use it to convert some newly-signed
5480 variables to unsigned, to avoid sign-extension bugs. For example,
5481 without this change, (md5 "truc") would evaluate to
5482 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5483 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5484 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5485
0f6990a7
PE
54862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5487
5488 Integer overflow fixes.
c8a9ca5a 5489
08686060
PE
5490 * dbusbind.c: Serial number integer overflow fixes.
5491 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5492 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5493 to hold a serial number that is too large for a fixnum.
5494 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5495 Check for serial numbers out of range. Decode any serial number
59568bf0 5496 that was so large that it became a float. (Bug#8722)
08686060 5497
2d1fc3c7
PE
5498 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5499 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5500 Use XFASTINT rather than XUINT when numbers are nonnegative.
5501 (xd_append_arg, Fdbus_method_return_internal):
5502 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5503 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5504 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5505 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5506 (Bug#8722)
2d1fc3c7 5507
c8a9ca5a
PE
5508 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5509
519e1d69
PE
5510 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5511
30569699
PE
5512 ccl: add integer overflow checks
5513 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5514 (IN_INT_RANGE): New macros.
5515 (ccl_driver): Use them to check for integer overflow when
5516 decoding a CCL program. Many of the new checks are whether XINT (x)
5517 fits in int; it doesn't always, on 64-bit hosts. The new version
5518 doesn't catch all possible integer overflows, but it's an
847044ea 5519 improvement. (Bug#8719)
30569699 5520
c11285dc
PE
5521 * alloc.c (make_event_array): Use XINT, not XUINT.
5522 There's no need for unsigned here.
5523
fdccd48e
PE
5524 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5525 This follows up to the 2011-05-06 change that substituted uintptr_t
5526 for EMACS_INT. This case wasn't caught back then.
5527
37910ab2
PE
5528 Rework Fformat to avoid integer overflow issues.
5529 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5530 now (part of C89). Include <verify.h>.
5531 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5532 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5533 (Fformat): Avoid the prepass trying to compute sizes; it was only
5534 approximate and thus did not catch overflow reliably. Instead, walk
5535 through the format just once, formatting and computing sizes as we go,
5536 checking for integer overflow at every step, and allocating a larger
5537 buffer as needed. Keep track separately whether the format is
5538 multibyte. Keep only the most-recently calculated precision, rather
5539 than them all. Record whether each argument has been converted to
5540 string. Use EMACS_INT, not int, for byte and char and arg counts.
5541 Support field widths and precisions larger than INT_MAX. Avoid
5542 sprintf's undefined behavior with conversion specifications such as %#d
5543 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5544 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5545 formatting out-of-range floating point numbers with int
9173deec 5546 formats. (Bug#8668)
37910ab2 5547
2e6578fb
PE
5548 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5549
0ae6bdee
PE
5550 * data.c: Avoid integer truncation in expressions involving floats.
5551 * data.c: Include <intprops.h>.
5552 (arith_driver): When there's an integer overflow in an expression
5553 involving floating point, convert the integers to floating point
5554 so that the resulting value does not suffer from catastrophic
5555 integer truncation. For example, on a 64-bit host (* 4
5556 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5557 Do not rely on undefined behavior after integer overflow.
5558
de883a70
PE
5559 merge count_size_as_multibyte, parse_str_to_multibyte
5560 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5561 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5562 Check for integer overflow.
5563 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5564 since it's now a duplicate of the other. This is more of
5565 a character than a buffer op, so better that it's in character.c.
5566 * fns.c, print.c: Adjust to above changes.
5567
2ff916cb
PE
55682011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5569
5570 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5571
f1b54466
PE
55722011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5573
fb1ac845
PE
5574 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5575 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5576 (x_clipboard_manager_save): Now static.
5577 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5578
f1b54466
PE
5579 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5580 (crypto_hash_function): Now static.
5581 Fix pointer signedness problems. Avoid unnecessary initializations.
5582
a9f737ee
CY
55832011-05-27 Chong Yidong <cyd@stupidchicken.com>
5584
5585 * termhooks.h (Vselection_alist): Make it terminal-local.
5586
5587 * terminal.c (create_terminal): Initialize it.
5588
5589 * xselect.c: Support for clipboard managers.
5590 (Vselection_alist): Move to termhooks.h as terminal-local var.
5591 (LOCAL_SELECTION): New macro.
5592 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5593 (symbol_to_x_atom): Remove gratuitous arg.
5594 (x_handle_selection_request, lisp_data_to_selection_data)
5595 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5596 (x_own_selection, x_get_local_selection, x_convert_selection):
5597 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5598 (some_frame_on_display): Delete unused function.
5599 (Fx_own_selection_internal, Fx_get_selection_internal)
5600 (Fx_disown_selection_internal, Fx_selection_owner_p)
5601 (Fx_selection_exists_p): New optional frame arg.
5602 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5603 (x_handle_selection_clear): Don't treat other terminals with the
5604 same keyboard specially. Use the terminal-local Vselection_alist.
5605 (x_clear_frame_selections): Use Frun_hook_with_args.
5606
5607 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5608
5609 * xterm.h: Add support for those atoms.
5610
e067f0c1
CY
56112011-05-26 Chong Yidong <cyd@stupidchicken.com>
5612
5613 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5614 (converted_selections, conversion_fail_tag): New global variables.
5615 (x_selection_request_lisp_error): Free the above.
5616 (x_get_local_selection): Remove unnecessary code.
5617 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5618 of converted selections stored in converted_selections.
5619 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5620 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5621 (x_convert_selection): New function.
5622 (x_handle_selection_event): Simplify.
5623 (x_get_foreign_selection): Don't ignore incoming requests while
5624 waiting for an answer; this will fail when we implement
5625 SAVE_TARGETS, and seems unnecessary anyway.
5626 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5627 (Vx_sent_selection_functions): Doc fix.
5628
0f4aebc0
LL
56292011-05-26 Leo Liu <sdl.web@gmail.com>
5630
5631 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5632
e61124cd
YM
56332011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5634
5635 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5636
5637 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5638 for fringe update if it has periodic bitmap.
ac389d0c 5639 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5640 and fringe_bitmap_periodic_p.
5641
5642 * fringe.c (get_fringe_bitmap_data): New function.
5643 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5644 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5645 row. Mark glyph row for fringe update if periodicity changed.
5646
5647 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5648 for fringe update unless it has periodic bitmap.
5649
f16d9837
KH
56502011-05-25 Kenichi Handa <handa@m17n.org>
5651
5652 * xdisp.c (get_next_display_element): Set correct it->face_id for
5653 a static composition.
5654
e1b90ef6
LL
56552011-05-24 Leo Liu <sdl.web@gmail.com>
5656
5657 * deps.mk (fns.o):
5658 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5659
5660 * fns.c (crypto_hash_function, Fsha1): New function.
5661 (Fmd5): Use crypto_hash_function.
5662 (syms_of_fns): Add Ssha1.
5663
7400048f
PE
56642011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5665
5666 * gnutls.c: Remove unused macros.
5667 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5668 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5669 Remove macros that are defined and never used.
5670 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5671
abb71cf4
CY
56722011-05-22 Chong Yidong <cyd@stupidchicken.com>
5673
5674 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5675 (Fx_get_selection_internal): Minor cleanup.
5676 (Fx_own_selection_internal): Rename arguments for consistency with
5677 select.el.
5678
6307db39
PE
56792011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5680
5681 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5682
f3d4e0a4
CY
56832011-05-22 Chong Yidong <cyd@stupidchicken.com>
5684
5685 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5686
4d8ade89
YM
56872011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5688
5689 * dispnew.c (scrolling_window): Don't exclude the case that the
5690 last enabled row in the desired matrix touches the bottom boundary.
5691
32078c8d
GM
56922011-05-21 Glenn Morris <rgm@gnu.org>
5693
5694 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5695 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5696 and add some more files.
32078c8d 5697
7285dc67
EZ
56982011-05-20 Eli Zaretskii <eliz@gnu.org>
5699
5700 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5701 report_file_error introduced by the change from 2011-05-07.
5702
89d1bd22
PE
57032011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5704
5705 * systime.h (Time): Define only if emacs is defined.
5706 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5707 where the include path doesn't have X11/X.h by default. See
5708 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5709
e23640bb 57102011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5711
5712 * composite.c (find_automatic_composition): Fix previous change.
5713
b9704ad9
GM
57142011-05-20 Glenn Morris <rgm@gnu.org>
5715
5716 * lisp.mk: New file, split from Makefile.in.
5717 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5718 (shortlisp): Remove.
5719 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5720
4a720484
GM
57212011-05-19 Glenn Morris <rgm@gnu.org>
5722
5723 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5724 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5725 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5726 (lisp): Set the order to that of loadup.el.
5727 (shortlisp): Make it a copy of $lisp.
5728 (SOME_MACHINE_LISP): Remove.
5729 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5730 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5731
a28d4396
KH
57322011-05-18 Kenichi Handa <handa@m17n.org>
5733
5734 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5735 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5736 (find_automatic_composition): Mostly rewrite for efficiency.
5737
a2b1fa8e
JB
57382011-05-18 Juanma Barranquero <lekktu@gmail.com>
5739
5740 * makefile.w32-in: Update dependencies.
5741
8e1f5610
CS
57422011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5743
5744 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5745 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5746
7025ee00 57472011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5748
cdfa6eab
PE
5749 Fix some integer overflow issues, such as string length overflow.
5750
06d6db33
PE
5751 * insdel.c (count_size_as_multibyte): Check for string overflow.
5752
2b4560a8
PE
5753 * character.c (lisp_string_width): Check for string overflow.
5754 Use EMACS_INT, not int, for string indexes and lengths; in
5755 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5756 the resulting string length overflows an EMACS_INT; instead,
5757 report a string overflow if no precision given. When checking for
5758 precision exhaustion, use a check that cannot possibly have
5759 integer overflow. (Bug#8675)
5760 * character.h (lisp_string_width): Adjust to new signature.
5761
cb93f9be
PE
5762 * alloc.c (string_overflow): New function.
5763 (Fmake_string): Use it. This doesn't change behavior, but saves
5764 a few bytes and will simplify future changes.
5765 * character.c (string_escape_byte8): Likewise.
5766 * lisp.h (string_overflow): New decl.
5767
1a1f3366
PE
5768 Fixups, following up to the user-interface timestamp change.
5769 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5770 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5771 * msdos.c (mouse_get_pos): Likewise.
5772 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5773 * w32gui.h (Time): Define by including "systime.h" rather than by
5774 declaring it ourselves. (Bug#8664)
5775
d4e3e4d3
PE
5776 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5777 * image.c (clear_image_cache): Likewise.
5778
f6a24d19
PE
5779 * term.c (term_mouse_position): Don't assume time_t wraparound.
5780
08dc5ae6
PE
5781 Be more systematic about user-interface timestamps.
5782 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5783 and sometimes 'EMACS_UINT', to represent these timestamps.
5784 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5785 This makes the code easier to follow, and makes it easier to catch
5786 integer overflow bugs such as Bug#8664.
5787 * frame.c (Fmouse_position, Fmouse_pixel_position):
5788 Use Time, not unsigned long, for user-interface timestamps.
5789 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5790 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5791 * keyboard.h (last_event_timestamp): Likewise.
5792 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5793 * menu.h (xmenu_show): Likewise.
5794 * term.c (term_mouse_position): Likewise.
5795 * termhooks.h (struct input_event.timestamp): Likewise.
5796 (struct terminal.mouse_position_hook): Likewise.
5797 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5798 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5799 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5800 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5801 what it was before.
5802 * menu.h, termhooks.h: Include "systime.h", for Time.
5803
8e55734a
PE
5804 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5805 Don't assume that the difference between two unsigned long values
5806 can fit into an integer. At this point, we know button_down_time
5807 <= event->timestamp, so the difference must be nonnegative, so
5808 there's no need to cast the result if double-click-time is
5809 nonnegative, as it should be; check that it's nonnegative, just in
5810 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5811 apart (about 25 days). (Bug#8664)
8e55734a 5812
841f1b75 5813 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5814 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5815
3e26f69c
PE
5816 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5817 that always fit in int. Use a sentinel instead of a counter, to
5818 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5819 * frame.h (struct frame): Use int for menu_bar_items_used
5820 instead of EMACS_INT, since it always fits in int.
3e26f69c 5821
5cc152c0
PE
5822 * menu.c (grow_menu_items): Check for int overflow.
5823
d89eb65e
PE
5824 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5825
5235bd3e
PE
5826 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5827 Before, the code was not consistent. These values cannot exceed
5828 2**31 - 1 so there's no need to make them unsigned.
5829 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5830 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5831 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5832 as modifiers.
5833 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5834
bc827e23
PE
5835 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5836 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5837 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5838 presumably because the widths might not match.
5839
78eb494e
PE
5840 * window.c (size_window): Avoid needless test at loop start.
5841
04f2d78b
CB
58422011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5843
5844 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5845
d2fc7e3d 58462011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5847
5848 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5849
d2fc7e3d 58502011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5851
5852 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5853 `width' to `bar_area_x' and `bar_area_width', respectively.
5854 (x_scroll_run): Take account of fringe background extension.
5855
04f2d78b
CB
5856 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5857 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5858 `bar_area_width', respectively.
5859 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5860 background extension.
5861
79b70037
GM
58622011-05-10 Jim Meyering <meyering@redhat.com>
5863
5864 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5865
2f142cc5
JB
58662011-05-10 Juanma Barranquero <lekktu@gmail.com>
5867
5868 * image.c (Finit_image_library): Return t for built-in image types,
5869 like pbm and xbm. (Bug#8640)
5870
57679c86
AS
58712011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5872
5873 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5874
888c9e86
EZ
58752011-05-07 Eli Zaretskii <eliz@gnu.org>
5876
b0512a1d
EZ
5877 * w32console.c (Fset_screen_color): Doc fix.
5878 (Fget_screen_color): New function.
5879 (syms_of_ntterm): Defsubr it.
5880
7285dc67
EZ
5881 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5882 unlink the temporary file if Fcall_process didn't create it in the
5883 first place.
5884 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5885 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5886 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5887 cue to call_process_cleanup not to close that handle.
5888
4d3fcc8e
BK
58892011-05-07 Ben Key <bkey76@gmail.com>
5890
5891 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5892 one of two shell specific rules, either bootstrap-temacs-CMD or
5893 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5894 to the previous implementation of the bootstrap-temacs rule.
5895 The bootstrap-temacs-CMD rule is similar to the previous
5896 implementation of the bootstrap-temacs rule except that it
5897 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5898 variable.
5899
5900 These changes, along with some changes to nt/configure.bat,
5901 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5902 earlier fix to add support for --cflags and --ldflags options
5903 that include quotes so that it works whether make uses cmd or
5904 sh as the shell.
5905
b4289b64
MA
59062011-05-06 Michael Albinus <michael.albinus@gmx.de>
5907
5908 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5909 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5910 is a constant.
5911 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5912 a string. Handle both cases.
5913 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5914 (Fdbus_register_method): Use Qinvalid_function.
5915
af4c0e28
JB
59162011-05-06 Juanma Barranquero <lekktu@gmail.com>
5917
5918 * makefile.w32-in: Update dependencies.
5919 (LISP_H): Add inttypes.h and stdin.h.
5920 (PROCESS_H): Add unistd.h.
5921
c51453d9
EZ
59222011-05-06 Eli Zaretskii <eliz@gnu.org>
5923
5924 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5925 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5926
8ff0ac3c 59272011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5928
4c4b566b
PE
5929 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5930
aab2b9b5
PE
5931 * term.c (vfatal): Remove stray call to va_end.
5932 It's not needed and the C Standard doesn't allow it here anyway.
5933
c378da0b
PE
5934 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5935 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5936
288b08c7
PE
5937 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5938 bytes.
5939
e3601888
PE
5940 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5941
db6c0e74
PE
5942 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5943
dd5963ea
PE
5944 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5945
88c9450f
PE
5946 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5947
2f9442b8
PE
5948 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5949
c032b5f8
PE
5950 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5951 * charset.c (Fdefine_charset_internal): Don't initialize
5952 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5953 32-bit int (Bug#8600).
a108c10b
PE
5954
5955 * lread.c (read_integer): Be more consistent with string-to-number.
5956 Use string_to_number to do the actual conversion; this avoids
5957 rounding errors and fixes some other screwups. Without this fix,
5958 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5959 (digit_to_number): Move earlier, for benefit of read_integer.
5960 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5961 not a digit in any supported base. (Bug#8602)
a108c10b 5962
ad5f9eea
PE
5963 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5964
aec1708a
PE
5965 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5966 to match comment at start of function. This also removes a
5967 GCC warning about overflow in a 32+64-bit port.
5968
47be4ab5
PE
5969 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5970
371cac43
PE
5971 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5972 Reported by Stefan Monnier in
5973 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5974 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5975 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5976
d01a7826
PE
5977 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5978 (EMACS_UINTPTR): Likewise, with uintptr_t.
5979
7fd47d5c
PE
5980 * lisp.h: Prefer 64-bit EMACS_INT if available.
5981 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5982 on 32-bit hosts that have 64-bit int, so that they can access
5983 large files.
122b0c86
PE
5984 However, temporarily disable this change unless the temporary
5985 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5986
8727937b
PE
5987 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5988
8ac068ac
PE
5989 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5990 This removes an assumption that EMACS_INT and long are the same
5991 width as pointers. The assumption is true for Emacs porting targets
5992 now, but we want to make other targets possible.
5993 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5994 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5995 In the rest of the code, change types of integers that hold casted
5996 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5997 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5998 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5999 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6000 No need to cast type when ORing.
6001 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6002 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6003 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6004 assume EMACS_INT is the same width as char *.
6005 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6006 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6007 Remove no-longer-needed casts.
6008 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6009 (xg_tool_bar_help_callback, xg_make_tool_item):
6010 Use EMACS_INTPTR to hold an integer
6011 that will be cast to void *; this can avoid a GCC warning
6012 if EMACS_INT is not the same width as void *.
6013 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6014 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6015 (current_message_1, set_message_1):
6016 Use a local to convert to proper width without a cast.
6017 * xmenu.c (dialog_selection_callback): Likewise.
6018
ede49d71
PE
6019 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6020 Also, don't assume VALBITS / RAND_BITS is less than 5,
6021 and don't rely on undefined behavior when shifting a 1 left into
6022 the sign bit.
6023 * lisp.h (get_random): Change signature to match.
6024
2f30ecd0
PE
6025 * lread.c (hash_string): Use size_t, not int, for hash computation.
6026 Normally we prefer signed values; but hashing is special, because
6027 it's better to use unsigned division on hash table sizes so that
6028 the remainder is nonnegative. Also, size_t is the natural width
6029 for hashing into memory. The previous code used 'int', which doesn't
6030 retain enough info to hash well into very large tables.
6031 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6032
2a866e7b
PE
6033 * dbusbind.c: Don't possibly lose pointer info when converting.
6034 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6035 Use XPNTR rather than XHASH, so that the high-order bits of
6036 the pointer aren't lost when converting through void *.
6037
51639eac
PE
6038 * eval.c (Fautoload): Don't double-shift a pointer.
6039
92394119
PE
6040 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6041
dbdb9a7c
JB
60422011-05-06 Juanma Barranquero <lekktu@gmail.com>
6043
6044 * gnutls.c (DEF_GNUTLS_FN):
6045 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6046
db7a0b4f
AS
60472011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6048
6049 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6050 marker. (Bug#8610)
6051
f7ff1b0f 60522011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6053
6054 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6055 New version that can reserve upto 2GB of heap space.
6056
f7ff1b0f 60572011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6058
6059 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6060
639c109b
TZ
60612011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6062
6063 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6064 `gnutls_certificate_set_x509_key_file'.
6065
d2127135
JB
60662011-05-05 Juanma Barranquero <lekktu@gmail.com>
6067
6068 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6069 Update dependencies.
6070
e968f4f3
JB
60712011-05-04 Juanma Barranquero <lekktu@gmail.com>
6072
6073 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6074 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6075 Remove unused parameter `fildes'.
6076 * process.c (read_process_output, send_process): Don't pass it.
6077
84d358f0
JB
60782011-05-04 Juanma Barranquero <lekktu@gmail.com>
6079
6080 Fix previous change: the library cache is defined in w32.c.
6081 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6082 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6083
0898ca10
JB
60842011-05-04 Juanma Barranquero <lekktu@gmail.com>
6085
6086 Implement dynamic loading of GnuTLS on Windows.
6087
6088 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6089 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6090 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6091 Declare.
6092
6093 * gnutls.c (Qgnutls_dll): Define.
6094 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6095 (gnutls_*): Declare function pointers.
6096 (init_gnutls_functions): New function to initialize function pointers.
6097 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6098 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6099 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6100 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6101 (emacs_gnutls_write, emacs_gnutls_read)
6102 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6103 (Fgnutls_available_p): New function.
6104 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6105 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6106 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6107
6108 * image.c: Include w32.h.
6109 (Vimage_type_cache): Delete.
6110 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6111 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6112 (w32_delayed_load): Move to w32.c.
6113
6114 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6115
6116 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6117 (w32_delayed_load): Move from image.c. When loading a library, record
6118 its filename in the :loaded-from property of the library id.
6119 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6120 Initialize and staticpro them.
6121 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6122
6123 * process.c: Include lisp.h before w32.h, not after.
6124 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6125 instead of gnutls_record_check_pending.
6126
6127 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6128
ff4de4aa
TZ
61292011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6130
6131 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6132 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6133 as passed in.
6134
abe95abb
JD
61352011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6136
6137 * xterm.c (x_set_frame_alpha): Do not set property on anything
6138 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6139
e16e55d4
JB
61402011-05-02 Juanma Barranquero <lekktu@gmail.com>
6141
6142 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6143
bafcf6a5
JB
61442011-05-02 Juanma Barranquero <lekktu@gmail.com>
6145
6146 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6147 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6148 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6149 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6150 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6151 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6152 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6153 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6154 (Qgnutls_bootprop_callbacks_verify): Make static.
6155
e7a6747f
AS
61562011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6157
19ed11ba
AS
6158 * callproc.c: Indentation fixup.
6159
e7a6747f 6160 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6161 (wait_for_termination, interruptible_wait_for_termination):
6162 Move after wait_for_termination_1.
e7a6747f 6163
1ef14cb4
LMI
61642011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6165
6166 * sysdep.c (interruptible_wait_for_termination): New function
6167 which is like wait_for_termination, but allows keyboard
6168 interruptions.
6169
6170 * callproc.c (Fcall_process): Add (:file "file") as an option for
6171 the STDOUT buffer.
6172 (Fcall_process_region): Ditto.
6173
330d880c
EZ
61742011-04-30 Eli Zaretskii <eliz@gnu.org>
6175
8db90b73
EZ
6176 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6177 rather than `XVECTOR (FOO)->size'.
6178
330d880c
EZ
6179 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6180 inttypes.h, as a gnulib replacement is used if it not available in
6181 system headers.
6182
15cbd324
EZ
61832011-04-21 Eli Zaretskii <eliz@gnu.org>
6184
6185 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6186 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6187 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6188
6189 * coding.c (coding_alloc_by_realloc): Error out if destination
6190 will grow beyond MOST_POSITIVE_FIXNUM.
6191 (decode_coding_emacs_mule): Abort if there isn't enough place in
6192 charbuf for the composition carryover bytes. Reserve an extra
6193 space for up to 2 characters produced in a loop.
6194 (decode_coding_iso_2022): Abort if there isn't enough place in
6195 charbuf for the composition carryover bytes.
6196
61972011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6198
ae940cca
EZ
6199 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6200 aborting when %lld or %lll format is passed.
6201 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6202 %llo or %llx format is passed. (Bug#8545)
6203
03ab8921
EZ
6204 * window.c (window_scroll_line_based): Use a marker instead of
6205 simple variables to record original value of point. (Bug#7952)
6206
afda1437
EZ
6207 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6208 produced by %s or %c overflows available buffer space. (Bug#8545)
6209
f76dee0c
PE
62102011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6211
6212 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6213 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6214
fdc5744d
JB
62152011-04-28 Juanma Barranquero <lekktu@gmail.com>
6216
6217 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6218
638f053a
JB
62192011-04-28 Juanma Barranquero <lekktu@gmail.com>
6220
6221 * keyboard.c (Qdelayed_warnings_hook): Define.
6222 (command_loop_1): Run `delayed-warnings-hook'
6223 if Vdelayed_warnings_list is non-nil.
6224 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6225 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6226
d178f871
EZ
62272011-04-28 Eli Zaretskii <eliz@gnu.org>
6228
6229 * doprnt.c (doprnt): Don't return value smaller than the buffer
6230 size if the message was truncated. (Bug#8545).
6231
b124fd93
JB
62322011-04-28 Juanma Barranquero <lekktu@gmail.com>
6233
6234 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6235 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6236
e810457d
PE
62372011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6238
6239 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6240
ea51cceb
JB
62412011-04-27 Juanma Barranquero <lekktu@gmail.com>
6242
6243 * makefile.w32-in: Update dependencies.
6244
94dcfacf
EZ
62452011-04-27 Eli Zaretskii <eliz@gnu.org>
6246
6247 Improve `doprnt' and its usage. (Bug#8545)
6248 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6249 `format_end'. Remove support for %l as a conversion specifier.
6250 Don't use xrealloc. Improve diagnostics when the %l size modifier
6251 is used. Update the commentary.
6252
6253 * eval.c (verror): Simplify calculation of size_t.
6254
6255 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6256 messages.
6257
f61f41d7
PE
62582011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6259
6260 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6261 change.
6262
96fb4434
PE
62632011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6264
6265 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
6266 This makes this file independent of the recent pseudovector change.
6267
671875da 62682011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 6269
69e9b5a3
PE
6270 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
6271
b5f869a7 6272 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 6273 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 6274 Remove unused local.
c8926152 6275 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 6276
841a1577 6277 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
6278 GCC 4.6.0 optimizes based on type-based alias analysis.
6279 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
6280 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
6281 != &v->size, and therefore "v->size = 1; b->size = 2; return
6282 v->size;" must therefore return 1. This assumption is incorrect
6283 for Emacs, since it type-puns struct Lisp_Vector * with many other
6284 types. To fix this problem, this patch adds a new type struct
f904488f 6285 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
6286 and pseudovectors, and helps optimizing compilers not get fooled
6287 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
6288 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
6289 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
6290 the size member.
eab3844f
PE
6291 (XSETPVECTYPE): Rewrite in terms of new macro.
6292 (XSETPVECTYPESIZE): New macro, specifying both type and size.
6293 This is a bit clearer, and further avoids the possibility of
6294 undesirable aliasing.
6295 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 6296 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
6297 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
6298 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
6299 (ASIZE): Now uses header.size rather than size.
6300 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
6301 to avoid the hassle of writing XVECTOR (foo)->header.size.
6302 (struct vectorlike_header): New type.
eab3844f
PE
6303 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
6304 object, to help avoid aliasing.
6305 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
6306 (SUBRP): Likewise, since Lisp_Subr is a special case.
6307 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
6308 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
6309 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 6310 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
6311 changed to be "header.size" and "header.next".
6312 * buffer.h (struct buffer): Likewise.
6313 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
6314 * frame.h (struct frame): Likewise.
6315 * process.h (struct Lisp_Process): Likewise.
6316 * termhooks.h (struct terminal): Likewise.
6317 * window.c (struct save_window_data, struct saved_window): Likewise.
6318 * window.h (struct window): Likewise.
6319 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
6320 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
6321 * buffer.c (init_buffer_once): Likewise.
6322 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
6323 special case.
6324 * process.c (Fformat_network_address): Use local var for size,
6325 for brevity.
6326
0df1eac5
PE
6327 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6328
847ab9d1 6329 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6330 * data.c (atof): Remove decl; no longer used or needed.
6331 (digit_to_number): Move to lread.c.
6332 (Fstring_to_number): Use new string_to_number function, to be
6333 consistent with how the Lisp reader treats infinities and NaNs.
6334 Do not assume that floating-point numbers represent EMACS_INT
6335 without losing information; this is not true on most 64-bit hosts.
6336 Avoid double-rounding errors, by insisting on integers when
6337 parsing non-base-10 numbers, as the documentation specifies.
6338 * lisp.h (string_to_number): New decl, replacing ...
6339 (isfloat_string): Remove.
bc0a5c13 6340 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6341 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6342 appears to have been a coding error. Similarly, do not accept
6343 strings like +-1e0 as floating point numbers. Do not report
6344 overflow for integer overflows unless the base is not 10 which
6345 means we have no simple and reliable way to continue.
6346 Break out the floating-point parsing into a new
6347 function string_to_number, so that Fstring_to_number parses
6348 floating point numbers consistently with the Lisp reader.
04f2d78b 6349 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6350 (E_CHAR, EXP_INT): Remove, replacing with ...
6351 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6352 (string_to_number): New function, replacing isfloat_string.
6353 This function checks for valid syntax and produces the resulting
6354 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6355 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6356 so that overflow for non-base-10 numbers is reported only when
6357 there's no portable and simple way to convert to floating point.
452f4150 6358
67769ffc
PE
6359 * textprop.c (set_text_properties_1): Rewrite for clarity,
6360 and to avoid GCC warning about integer overflow.
6361
c20db43f
PE
6362 * intervals.h (struct interval): Use EMACS_INT for members
6363 where EMACS_UINT might cause problems. See
6364 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6365 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6366 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6367 All uses changed.
37aa2f85
PE
6368 (offset_intervals): Tell GCC not to worry about length overflow
6369 when negating a negative length.
c20db43f 6370
2538aa2f
PE
6371 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6372 (overrun_check_free): Likewise.
6373
f2d3008d
PE
6374 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6375 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6376 word size.
6377
ec8df744
PE
6378 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6379 (gnutls_make_error): Rename local to avoid shadowing.
6380 (gnutls_emacs_global_deinit): ifdef out; not used.
6381 (Fgnutls_boot): Use const for pointer to readonly storage.
6382 Comment out unused local. Fix pointer signedness problems.
6383
640ee02d
PE
6384 * lread.c (openp): Don't stuff size_t into an 'int'.
6385 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6386 about possible signed overflow.
6387
6048fb2a
PE
6388 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6389 (GDK_KEY_g): Don't define if already defined.
6390 (xg_prepare_tooltip): Avoid pointer signedness problem.
6391 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6392
fa3c87e1
PE
6393 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6394 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6395
2172544b
PE
6396 * xfns.c (Fx_window_property): Simplify a bit,
6397 to make a bit faster and to avoid GCC 4.6.0 warning.
6398 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6399
9b821a21
PE
6400 * fns.c (internal_equal): Don't assume size_t fits in int.
6401
3c616cfa
PE
6402 * alloc.c (compact_small_strings): Tighten assertion a little.
6403
c2982e87
PE
6404 Replace pEd with more-general pI, and fix some printf arg casts.
6405 * lisp.h (pI): New macro, generalizing old pEd macro to other
6406 conversion specifiers. For example, use "...%"pI"d..." rather
6407 than "...%"pEd"...".
6408 (pEd): Remove. All uses replaced with similar uses of pI.
6409 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6410 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6411 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6412 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6413 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6414 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6415 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6416 64-bit hosts.
6417 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6418 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6419 * print.c (safe_debug_print, print_object): Likewise.
6420 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6421 to int.
6f04d126
PE
6422 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6423 avoiding the 0 flag, which is not portable.
c2982e87
PE
6424 * process.c (Fmake_network_process): Use pI to avoid cast.
6425 * region-cache.c (pp_cache): Likewise.
6426 * xdisp.c (decode_mode_spec): Likewise.
6427 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6428 behavior on 64-bit hosts with printf arg.
6f04d126 6429 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6430 (x_stop_queuing_selection_requests): Likewise.
6431 (x_get_window_property): Don't truncate byte count to an 'int'
6432 when tracing.
0b432f21 6433
5e073ec7
PE
6434 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6435 here, since it parses constructs like leading '-' and spaces,
6436 which are not wanted; and it overflows with large numbers.
6437 Instead, simply match F[0-9]+, which is what is wanted anyway.
6438
36372bf9
PE
6439 * alloc.c: Remove unportable assumptions about struct layout.
6440 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6441 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6442 (allocate_vectorlike, make_pure_vector): Use the new macros,
6443 plus offsetof, to remove unportable assumptions about struct layout.
6444 These assumptions hold on all porting targets that I know of, but
6445 they are not guaranteed, they're easy to remove, and removing them
6446 makes further changes easier.
6447
0b432f21
PE
6448 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6449 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6450 (string_overrun_cookie): Now const. Use initializers that
6451 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6452 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6453 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6454 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6455 multiple of sizeof (EMACS_INT); it need not be, if
6456 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6457 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6458
895009e1
JB
64592011-04-26 Juanma Barranquero <lekktu@gmail.com>
6460
6461 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6462
6a7a1b0b
TZ
64632011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6464
6465 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6466 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6467 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6468
841a1577 64692011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6470
6471 * lisp.h (Qdebug): List symbol.
895009e1 6472 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6473 * keyboard.c (debug-on-event): New variable.
6474 (handle_user_signal): Break into debugger when debug-on-event
6475 matches the current signal symbol.
6476
f2d3ba6f
DN
64772011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6478
6479 * alloc.c (check_sblock, check_string_bytes)
6480 (check_string_free_list): Convert to standard C.
6481
42ce4c63
TZ
64822011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6483
6484 * w32.c (emacs_gnutls_push): Fix typo.
6485
825cd63c
EZ
64862011-04-25 Eli Zaretskii <eliz@gnu.org>
6487
fb11d64d
EZ
6488 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6489 "cast to pointer from integer of different size".
6490
825cd63c
EZ
6491 Improve doprnt and its use in verror. (Bug#8545)
6492 * doprnt.c (doprnt): Document the set of format control sequences
6493 supported by the function. Use SAFE_ALLOCA instead of always
6494 using `alloca'.
6495
6496 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6497 is one byte too soon. Don't use xrealloc; instead xfree and
6498 xmalloc anew.
6499
e061a11b
TZ
65002011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6501
6502 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6503 callbacks stage.
6504
6505 * gnutls.c: Renamed global_initialized to
6506 gnutls_global_initialized. Added internals for the
6507 :verify-hostname-error, :verify-error, and :verify-flags
6508 parameters of `gnutls-boot' and documented those parameters in the
6509 docstring. Start callback support.
9173deec
JB
6510 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6511 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6512 on error. Return error code.
e061a11b
TZ
6513 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6514 (emacs_gnutls_read): Likewise.
6515 (Fgnutls_boot): Return handshake error code.
6516 (emacs_gnutls_handle_error): New function.
6517 (wsaerror_to_errno): Likewise.
6518
6519 * w32.h (emacs_gnutls_pull): Add prototype.
6520 (emacs_gnutls_push): Likewise.
6521
6522 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6523 (emacs_gnutls_push): Likewise.
6524
65252011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6526
6527 * process.c (wait_reading_process_output): Check if GnuTLS
6528 buffered some data internally if no FDs are set for TLS
6529 connections.
6530
6531 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6532 (LIBS): Link to USER_LIBS.
6533 ($(BLD)/gnutls.$(0)): New target.
6534
fa6996bc
EZ
65352011-04-24 Eli Zaretskii <eliz@gnu.org>
6536
eb35682e
EZ
6537 * xdisp.c (handle_single_display_spec): Rename the
6538 display_replaced_before_p argument into display_replaced_p, to
6539 make it consistent with the commentary. Fix typos in the
6540 commentary.
6541
e2ad650c
EZ
6542 * textprop.c (syms_of_textprop): Remove dead code.
6543 (copy_text_properties): Delete obsolete commentary about an
6544 interface that was deleted long ago. Fix typos in the description
6545 of arguments.
6546
1b2de274
EZ
6547 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6548 to changes in oldXMenu/XMenu.h from 2011-04-16.
6549 <menu_help_message, prev_menu_help_message>: Constify.
6550 (IT_menu_make_room): menu->help_text is now `const char **';
6551 adjust.
6552
6553 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6554 to changes in oldXMenu/XMenu.h from 2011-04-16.
6555 (struct XMenu): Declare `help_text' `const char **'.
6556
6557 * xfaces.c <Qunspecified>: Make extern again.
6558
6559 * syntax.c: Include sys/types.h before including regex.h, as
6560 required by Posix.
6561
762b15be
EZ
6562 * doc.c (get_doc_string): Improve the format passed to `error'.
6563
6564 * doprnt.c (doprnt): Improve commentary.
6565
6566 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6567
6568 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6569 them with etags.
6570
f1052e5d
EZ
6571 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6572 changes in globals.h immediately force recompilation.
762b15be
EZ
6573 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6574 $(CURDIR)/s/ms-w32.h.
6575 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6576
fa6996bc
EZ
6577 * character.c (Fchar_direction): Function deleted.
6578 (syms_of_character): Don't defsubr it.
6579 <char-direction-table>: Deleted.
6580
e6c3da20
EZ
65812011-04-23 Eli Zaretskii <eliz@gnu.org>
6582
6583 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6584 * doprnt.c: Include limits.h.
6585 (SIZE_MAX): New macro.
04f2d78b
CB
6586 (doprnt): Return a size_t value. 2nd arg is now size_t.
6587 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6588 Improve overflow protection. Support `l' modifier for integer
6589 conversions. Support %l conversion. Don't assume an EMACS_INT
6590 argument for integer conversions and for %c.
6591
6592 * lisp.h (doprnt): Restore prototype.
6593
6594 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6595 $(SRC)/character.h.
6596
6597 * Makefile.in (base_obj): Add back doprnt.o.
6598
6599 * deps.mk (doprnt.o): Add back prerequisites.
6600 (callint.o): Depend on character.h.
6601
6602 * eval.c (internal_lisp_condition_case): Include the handler
6603 representation in the error message.
6604 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6605 when breaking from the loop.
6606
6607 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6608
6609 * callint.c (Fcall_interactively): When displaying error message
6610 about invalid control letter, pass the character's codepoint, not
6611 a pointer to its multibyte form. Improve display of the character
6612 in octal and display also its hex code.
6613
6614 * character.c (char_string): Use %x to display the (unsigned)
6615 codepoint of an invalid character, to avoid displaying a bogus
6616 negative value.
6617
6618 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6619 `error', not SYMBOL_NAME itself.
6620
6621 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6622 character arguments to `error'.
6623
6624 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6625 to `error' in error message about FINAL_CHAR argument. Make sure
6626 FINAL_CHAR is a character, and use %c when it is passed as
6627 argument to `error'.
6628
4ffd0d6b 66292011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6630
6631 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6632
6633 * w32.c: Include <time.h>.
6634 (sys_localtime): New function.
6635
4ffd0d6b 66362011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6637
6638 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6639
4ffd0d6b 6640 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6641
4ffd0d6b 66422011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6643
4ffd0d6b
GM
6644 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6645 zombies (Bug#8467).
aac0c6e3 6646
04c56954
EZ
66472011-04-19 Eli Zaretskii <eliz@gnu.org>
6648
6649 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6650 gl_state.e_property when gl_state.object is Qt.
6651
6652 * insdel.c (make_gap_larger): Remove limitation of buffer size
6653 to <= INT_MAX.
6654
16a43933
CY
66552011-04-18 Chong Yidong <cyd@stupidchicken.com>
6656
6657 * xdisp.c (lookup_glyphless_char_display)
6658 (produce_glyphless_glyph): Handle cons cell entry in
6659 glyphless-char-display.
6660 (Vglyphless_char_display): Document it.
6661
6662 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6663 glyphless-char-display.
6664
4581706e
CY
66652011-04-17 Chong Yidong <cyd@stupidchicken.com>
6666
6667 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6668
6669 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6670
6671 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6672 definition for no-X builds.
6673
4887c6e2 66742011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6675
fd35b6f9
PE
6676 Static checks with GCC 4.6.0 and non-default toolkits.
6677
5c1ccb01
PE
6678 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6679
006c5daa
PE
6680 * process.c (keyboard_bit_set): Define only if SIGIO.
6681 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6682 (send_process): Repair possible setjmp clobbering.
6683
efc736d3
PE
6684 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6685
4e2fe2e6
PE
6686 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6687
f97334a2
PE
6688 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6689
4e75f29d
PE
6690 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6691 Define only if needed.
6692
90efadd1
PE
6693 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6694 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6695 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6696
3c647824
PE
6697 * dispextern.h (struct redisplay_interface): Rename param
6698 to avoid shadowing.
e264f262 6699 * termhooks.h (struct terminal): Likewise.
761383f4 6700 * xterm.c (xembed_send_message): Likewise.
3c647824 6701
b58c5c4a
PE
6702 * insdel.c (make_gap_smaller): Define only if
6703 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6704
cad59032
PE
6705 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6706 it.
6707
c339dc2e
PE
6708 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6709 so that we aren't warned about unused symbols.
6710
91a3e27b
PE
6711 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6712
399c71d3 6713 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6714
8ffc96f5
PE
6715 * xfns.c (x_real_positions): Mark locals as initialized.
6716
eef9bc79
PE
6717 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6718
098db9dd
PE
6719 * xterm.c: Fix problems found by static analysis with other toolkits.
6720 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6721 (x_dispatch_event): Declare static if USE_GTK, and
6722 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6723 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6724 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6725 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6726 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6727
eb18f6cc
PE
6728 * xmenu.c (menu_help_callback): Pointer type fixes.
6729 Use const pointers when pointing at readonly data. Avoid pointer
6730 signedness clashes.
6731 (FALSE): Remove unused macro.
6732 (update_frame_menubar): Remove unused decl.
6733
1fe72bf8
PE
6734 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6735
60d9e1db
PE
6736 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6737 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6738 (single_menu_item): Rename local to avoid shadowing.
6739
39261c26
PE
6740 * keyboard.c (make_lispy_event): Remove unused local var.
6741
018c5e19
PE
6742 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6743 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6744
63d2b86e
PE
6745 * bitmaps: Change bitmaps from unsigned char back to the X11
6746 compatible char. Avoid the old compiler warnings about
6747 out-of-range initializers by using, for example, '\xab' rather
6748 than 0xab.
6749
aefd87e1
PE
6750 * xgselect.c (xgselect_initialize): Check vs interface
6751 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6752
bf501fb9
PE
6753 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6754
e9829fdf
PE
6755 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6756 to read-only memory.
6757
1086c095
PE
6758 * fns.c (vector): Remove; this old hack is no longer needed.
6759
2baccd04 6760 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6761 Remove unused var.
dde42981 6762 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6763
72391843 6764 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6765
436c16df 6766 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6767 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6768 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6769
92bb796d 6770 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6771 (x_term_init): Remove local to avoid shadowing.
92bb796d 6772
764430a3 6773 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6774
6775 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6776 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6777
d1dfb56c
EZ
67782011-04-16 Eli Zaretskii <eliz@gnu.org>
6779
c4354cb4
EZ
6780 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6781
d1dfb56c
EZ
6782 Fix regex.c, syntax.c and friends for buffers > 2GB.
6783 * syntax.h (struct gl_state_s): Declare character position members
6784 EMACS_INT.
6785
6786 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6787
04f2d78b
CB
6788 * textprop.c (verify_interval_modification, interval_of):
6789 Declare arguments EMACS_INT.
d1dfb56c
EZ
6790
6791 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6792 EMACS_INT.
6793
6794 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6795
6796 * indent.c (Fvertical_motion): Local variable it_start is now
6797 EMACS_INT.
6798
6799 * regex.c (re_match, re_match_2, re_match_2_internal)
6800 (bcmp_translate, regcomp, regexec, print_double_string)
6801 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6802 (re_compile_pattern, re_exec): Declare arguments and local
6803 variables `size_t' and `ssize_t' and return values `regoff_t', as
6804 appropriate.
6805 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6806 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6807 <compile_stack_type>: `size' and `avail' are now `size_t'.
6808
6809 * regex.h <regoff_t>: Use ssize_t, not int.
6810 (re_search, re_search_2, re_match, re_match_2): Arguments that
6811 specify buffer/string position and length are now ssize_t and
6812 size_t. Return type is regoff_t.
6813
613052cd
BK
68142011-04-16 Ben Key <bkey76@gmail.com>
6815
6816 * nsfont.m: Fixed bugs in ns_get_family and
6817 ns_descriptor_to_entity that were caused by using free to
6818 deallocate memory blocks that were allocated by xmalloc (via
6819 xstrdup). This caused Emacs to crash when compiled with
6820 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6821 --enable-checking=xmallocoverrun). xfree is now used to
6822 deallocate these memory blocks.
6823
4170f62f 68242011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6825
71b41406
PE
6826 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6827
9587a89d
PE
6828 emacs_write: Accept and return EMACS_INT for sizes.
6829 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6830 et seq.
6831 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6832 Accept and return EMACS_INT.
6833 (emacs_gnutls_write): Return the number of bytes written on
6834 partial writes.
6835 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6836 (emacs_read, emacs_write): Remove check for negative size, as the
6837 Emacs source code has been audited now.
9587a89d
PE
6838 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6839 (emacs_read, emacs_write): Use it.
273a5f82
PE
6840 * process.c (send_process): Adjust to the new signatures of
6841 emacs_write and emacs_gnutls_write. Do not attempt to store
6842 a byte offset into an 'int'; it might overflow.
9587a89d 6843 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6844
3e047f51
PE
6845 * sound.c: Don't assume sizes fit in 'int'.
6846 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6847 Return EMACS_INT, not int.
3e047f51 6848 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6849 Accept EMACS_INT, not int.
6850 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6851 record read return values.
6852
cc39a9db
BK
68532011-04-15 Ben Key <bkey76@gmail.com>
6854
c9d0ec6d
JB
6855 * keyboard.c (Qundefined): Don't declare static since it is used
6856 in nsfns.m.
6857 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6858 static since they are used in nsfont.m.
cc39a9db 6859
6c60eb9f
SM
68602011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6861
6862 * process.c (Qprocessp): Don't declare static.
6863 * lisp.h (Qprocessp): Declare again.
6864
7990b61a
JB
68652011-04-15 Juanma Barranquero <lekktu@gmail.com>
6866
6867 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6868
5d4cb038
PE
68692011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6870
8bd7b830 6871 Improve C-level modularity by making more things 'static'.
cd64ea1d 6872
e3b27b31
PE
6873 Don't publish debugger-only interfaces to other modules.
6874 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6875 (verify_bytepos, count_markers): Move decls to the only modules
6876 that need them.
6877 * region-cache.h (pp_cache): Likewise.
6878 * window.h (check_all_windows): Likewise.
6879 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6880
5d4cb038
PE
6881 * sysdep.c (croak): Now static, if
6882 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6883 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6884
6885 * alloc.c (refill_memory_reserve): Now static if
6886 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6887 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6888
e87b6180
PE
6889 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6890 Define only if USE_LUCID.
6891
ac64929e
PE
6892 * xrdb.c (x_customization_string, x_rm_string): Now static.
6893
6f37259d
PE
6894 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6895 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6896
1683e3ab
PE
6897 * xdisp.c (draw_row_with_mouse_face): Now static.
6898 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6899
de9c2632
PE
6900 * window.h (check_all_windows): Mark externally visible.
6901
2b96acb7
PE
6902 * window.c (window_deletion_count): Now static.
6903
6904 * undo.c: Make symbols static if they're not exported.
6905 (last_undo_buffer, last_boundary_position, pending_boundary):
6906 Now static.
6907
50436f33
PE
6908 * textprop.c (interval_insert_behind_hooks): Now static.
6909 (interval_insert_in_front_hooks): Likewise.
6910
64520e5c
PE
6911 * term.c: Make symbols static if they're not exported.
6912 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6913 (max_frame_lines, tty_set_terminal_modes):
6914 (tty_reset_terminal_modes, tty_turn_off_highlight):
6915 (get_tty_terminal): Now static.
6916 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6917 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6918 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6919 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6920 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6921
1fa53021
PE
6922 * sysdep.c: Make symbols static if they're not exported.
6923 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6924 Now static.
6925 (sigprocmask_set, full_mask): Remove; unused.
6926 (wait_debugging): Mark as visible.
6927 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6928 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6929
d4b43b22
PE
6930 * syntax.c (syntax_temp): Define only if !__GNUC__.
6931
b7c513d0
PE
6932 * sound.c (current_sound_device, current_sound): Now static.
6933
989b29ad
PE
6934 * search.c (searchbufs, searchbuf_head): Now static.
6935
13a55a78
PE
6936 * scroll.c (scroll_cost): Remove; unused.
6937 * dispextern.h (scroll_cost): Remove decl.
6938
de68a1fc
PE
6939 * region-cache.h (pp_cache): Mark as externally visible.
6940
40ccffa6
PE
6941 * process.c: Make symbols static if they're not exported.
6942 (process_tick, update_tick, create_process, chan_process):
6943 (Vprocess_alist, proc_buffered_char, datagram_access):
6944 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6945 (deactivate_process): Mark defn as static, as well as decl.
6946 * lisp.h (create_process): Remove decl.
6947 * process.h (chan_process, Vprocess_alist): Remove decls.
6948
ad64fc97
PE
6949 * print.c: Make symbols static if they're not exported.
6950 (print_depth, new_backquote_output, being_printed, print_buffer):
6951 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6952 (print_interval, print_number_index, initial_stderr_stream):
6953 Now static.
6954 * lisp.h (Fprinc): Remove decl.
6955 (debug_output_compilation_hack): Mark as externally visible.
6956
adddb265
PE
6957 * sysdep.c (croak): Move decl from here to syssignal.h.
6958 * syssignal.h (croak): Put it here, so the API can be checked when
6959 'croak' is called from dissociate_if_controlling_tty.
6960
1717ede2
PE
6961 * minibuf.c: Make symbols static if they're not exported.
6962 (minibuf_save_list, choose_minibuf_frame): Now static.
6963 * lisp.h (choose_minibuf_frame): Remove decl.
6964
fa5fb2bc
PE
6965 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6966
1e3890d1
PE
6967 * lread.c: Make symbols static if they're not exported.
6968 (read_objects, initial_obarray, oblookup_last_bucket_number):
6969 Now static.
6970 (make_symbol): Remove; unused.
6971 * lisp.h (initial_obarray, make_symbol): Remove decls.
6972
8a1414fa
PE
6973 * keyboard.c: Make symbols static if they're not exported.
6974 (single_kboard, recent_keys_index, total_keys, recent_keys):
6975 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6976 (this_single_command_key_start, echoing, last_auto_save):
6977 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6978 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6979 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6980 (Vlispy_mouse_stem, double_click_count):
6981 Now static.
6982 (force_auto_save_soon): Define only if SIGDANGER.
6983 (ignore_mouse_drag_p): Now static if
6984 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6985 (print_help): Remove; unused.
6986 (stop_character, last_timer_event): Mark as externally visible.
6987 * keyboard.h (ignore_mouse_drag_p): Declare only if
6988 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6989 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6990 * lisp.h (echoing): Remove decl.
6991 (force_auto_save_soon): Declare only if SIGDANGER.
6992 * xdisp.c (redisplay_window): Simplify code, to make it more
6993 obvious that ignore_mouse_drag_p is not accessed if !defined
6994 USE_GTK && !defined HAVE_NS.
6995
93ea6e8f
PE
6996 * intervals.c: Make symbols static if they're not exported.
6997 (merge_properties_sticky, merge_interval_right, delete_interval):
6998 Now static.
6999 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7000
77382fcc
PE
7001 * insdel.c: Make symbols static if they're not exported.
7002 However, leave prepare_to_modify_buffer alone. It's never
7003 called from outside this function, but that appears to be a bug.
7004 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7005 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7006 (adjust_after_replace_noundo): Remove; unused.
7007 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7008 (signal_before_change): Remove decls.
77382fcc 7009
9306c32e
PE
7010 * indent.c (val_compute_motion, val_vmotion): Now static.
7011
cd44d2eb
PE
7012 * image.c: Make symbols static if they're not exported.
7013 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7014 if USE_GTK.
7015 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7016 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7017
ad9a7a06
PE
7018 * fringe.c (standard_bitmaps): Now static.
7019 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7020
81626931
PE
7021 * frame.c: Make symbols static if they're not exported.
7022 (x_report_frame_params, make_terminal_frame): Now static.
7023 (get_frame_param): Now static, unless HAVE_NS.
7024 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7025 (x_get_resource_string): Remove; not used.
7026 * frame.h (make_terminal_frame, x_report_frame_params):
7027 (x_get_resource_string); Remove decls.
7028 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7029 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7030
239f9db9
PE
7031 * font.c, fontset.c: Make symbols static if they're not exported.
7032 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7033 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7034 * font.c (font_close_object): Now static.
7035 * font.h (font_close_object): Remove.
7036 * fontset.c (FONTSET_OBJLIST): Remove.
7037 (free_realized_fontset) #if-0 the body, which does nothing.
7038 (face_suitable_for_char_p): #if-0, as it's never called.
7039 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7040 * xfaces.c (face_at_string_position):
7041 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7042 since 0 is always ASCII.
7043
dfcf3579
PE
7044 * fns.c (weak_hash_tables): Now static.
7045
5045092b
PE
7046 * fileio.c: Make symbols static if they're not exported.
7047 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7048 (Vwrite_region_annotation_buffers): Now static.
7049
57a96f5c
PE
7050 * eval.c: Make symbols static if they're not exported.
7051 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7052 * lisp.h (backtrace_list): Remove decl.
7053
35f08c38
PE
7054 * emacs.c: Make symbols static if they're not exported.
7055 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7056 (fatal_error_code, fatal_error_signal_hook, standard_args):
7057 Now static.
7058 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7059 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7060 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7061 * lisp.h (fatal_error_signal_hook): Remove decl.
7062 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7063
f44bd759
PE
7064 * editfns.c: Move a (normally-unused) function to its only use.
7065 * editfns.c, lisp.h (get_operating_system_release): Remove.
7066 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7067 worth the hassle of breaking this out.
7068
b532497d
PE
7069 * xterm.c: Make symbols static if they're not exported.
7070 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7071 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7072 (x_destroy_window, x_delete_display):
7073 Now static.
7074 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7075 (x_mouse_leave): Remove; unused.
7076 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7077 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7078 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7079 Remove decls.
7080 (x_mouse_leave): Declare only if WINDOWSNT.
7081 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7082 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7083 USE_X_TOOLKIT.
7084
1675728f
PE
7085 * ftxfont.c: Make symbols static if they're not exported.
7086 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7087 HAVE_FREETYPE.
7088 * font.h (ftxfont_driver): Likewise.
7089
e4cebfca
PE
7090 * xfns.c: Make symbols static if they're not exported.
7091 (x_last_font_name, x_display_info_for_name):
7092 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7093 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7094 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7095 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7096 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7097 (last_show_tip_args): Now static.
7098 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7099 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7100 (x_screen_planes): Remove; unused.
7101 * dispextern.h (x_screen_planes): Remove decl.
7102
5bf46f05
PE
7103 * dispnew.c: Make symbols static if they're not exported.
7104 * dispextern.h (redraw_garbaged_frames, scrolling):
7105 (increment_row_positions): Remove.
7106 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7107 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7108 Now static.
7109 (redraw_garbaged_frames): Remove; unused.
7110
435f4c28
PE
7111 * xfaces.c: Make symbols static if they're not exported.
7112 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7113 Remove decls.
7114 * xterm.h (defined_color): Remove decls.
7115 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7116 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7117 (menu_face_changed_default, defined_color, free_realized_face):
7118 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7119 (ascii_face_of_lisp_face): Remove; unused.
7120
8524aef3
PE
7121 * xdisp.c: Make symbols static if they're not exported.
7122 * dispextern.h (scratch_glyph_row, window_box_edges):
7123 (glyph_to_pixel_coords, set_cursor_from_row):
7124 (get_next_display_element, set_iterator_to_next):
7125 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7126 (show_mouse_face): Remove decls
7127 * frame.h (message_buf_print): Likewise.
7128 * lisp.h (pop_message, set_message, check_point_in_composition):
7129 Likewise.
7130 * xterm.h (set_vertical_scroll_bar): Likewise.
7131 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7132 (message_buf_print, scratch_glyph_row, displayed_buffer):
7133 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7134 (get_next_display_element, show_mouse_face, window_box_edges):
7135 (frame_to_window_pixel_xy, check_point_in_composition):
7136 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7137 (glyph_to_pixel_coords): Remove; unused.
7138
16390cd2
PE
7139 * dired.c (file_name_completion): Now static.
7140
7141 * dbusbind.c (xd_in_read_queued_messages): Now static.
7142
a25f4dfa
PE
7143 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7144 * data.c (circular_list_error): Remove.
7145
14a9c8df
PE
7146 * commands.h (last_point_position, last_point_position_buffer):
7147 (last_point_position_window): Remove decls.
7148 * keyboard.c: Make these variables static.
7149
04f2d78b
CB
7150 * coding.h (coding, code_convert_region, encode_coding_gap):
7151 Remove decls.
74ab6df5
PE
7152 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7153 (iso_code_class, detect_coding, code_convert_region): Now static.
7154 (encode_coding_gap): Remove; unused.
7155
38dfbee1
PE
7156 * chartab.c (chartab_chars, chartab_bits): Now static.
7157
a2cb4e63
PE
7158 * charset.h (charset_iso_8859_1): Remove decl.
7159 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7160 Now static.
7161
127198fd
PE
7162 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7163 * ccl.c (Vccl_program_table): Now static.
7164 (check_ccl_update): Remove; unused.
7165
d85b608f
PE
7166 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7167 * category.h: ... from here.
7168 * category.c (check_category_table, set_category_set): Now static.
7169
31cd66f3
PE
7170 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7171 * lisp.h: Remove these decls.
7172
c358e587
PE
7173 * buffer.c (buffer_count): Remove unused var.
7174
e78aecca
PE
7175 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7176 so that it's not optimized away.
7177 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7178 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7179 exported only to the debugger.
7180
e192d7d3 7181 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7182 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7183
92470028
PE
7184 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7185 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7186 was inaccessible from Lisp.
7187 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7188 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7189
244ed907
PE
7190 alloc.c: Import and export fewer symbols, and remove unused items.
7191 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7192 is defined.
7193 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7194 it's not optimized away by whole-program optimization.
7195 (message_enable_multibyte, free_misc): Remove.
7196 (catchlist, handlerlist, mark_backtrace):
7197 Declare only if BYTE_MARK_STACK.
7198 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7199 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7200 (message_enable_multibyte): Remove decl.
7201 (free_misc, interval_free_list, float_block, float_block_index):
7202 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7203 (cons_free_list, last_marked_index):
7204 Now static.
7205 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7206 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7207 (mark_backtrace): Define only if BYTE_MARK_STACK.
7208 * xdisp.c (message_enable_multibyte): Now static.
7209
61c2b50e 7210 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7211 This makes it easier for human readers (and static analyzers)
7212 to see whether these variables are used from other modules.
7213 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7214 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7215 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7216 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7217 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7218 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7219 * xmenu.c, xselect.c:
7220 Declare Q* vars static if they are not used in other modules.
7221 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7222 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7223 Remove decls of unexported vars.
7224 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7225
95c82688
PE
7226 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7227
16a97296
PE
7228 Make Emacs functions such as Fatom 'static' by default.
7229 This makes it easier for human readers (and static analyzers)
7230 to see whether these functions can be called from other modules.
7231 DEFUN now defines a static function. To make the function external
7232 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7233 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7234 (Finit_image_library):
16a97296
PE
7235 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7236 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7237 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7238 Remove decls, since these functions are now static.
7239 (Funintern, Fget_internal_run_time): New decls, since these functions
7240 were already external.
95c82688 7241
16a97296
PE
7242 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7243 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7244 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7245 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7246 * keyboard.c, keymap.c, lread.c:
7247 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7248 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7249 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7250 Mark functions with DEFUE instead of DEFUN,
7251 if they are used in other modules.
7252 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7253 decls for now-static functions.
7254 * buffer.h (Fdelete_overlay): Remove decl.
7255 * callproc.c (Fgetenv_internal): Mark as internal.
7256 * composite.c (Fremove_list_of_text_properties): Remove decl.
7257 (Fcomposition_get_gstring): New forward static decl.
7258 * composite.h (Fcomposite_get_gstring): Remove decl.
7259 * dired.c (Ffile_attributes): New forward static decl.
7260 * doc.c (Fdocumntation_property): New forward static decl.
7261 * eval.c (Ffetch_bytecode): New forward static decl.
7262 (Funintern): Remove extern decl; now in .h file where it belongs.
7263 * fileio.c (Fmake_symbolic_link): New forward static decl.
7264 * image.c (Finit_image_library): New forward static decl.
7265 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
7266 * intervals.h (Fprevious_property_change):
7267 (Fremove_list_of_text_properties): Remove decls.
7268 * keyboard.c (Fthis_command_keys): Remove decl.
7269 (Fcommand_execute): New forward static decl.
7270 * keymap.c (Flookup_key): New forward static decl.
7271 (Fcopy_keymap): Now static.
7272 * keymap.h (Flookup_key): Remove decl.
7273 * process.c (Fget_process): New forward static decl.
7274 (Fprocess_datagram_address): Mark as internal.
7275 * syntax.c (Fsyntax_table_p): New forward static decl.
7276 (skip_chars): Remove duplicate decl.
7277 * textprop.c (Fprevious_property_change): New forward static decl.
7278 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
7279 Now internal.
7280 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
7281 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
7282
785bbd42
PE
7283 * editfns.c (Fformat): Remove unreachable code.
7284
8b913b57
AS
72852011-04-14 Andreas Schwab <schwab@linux-m68k.org>
7286
7287 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
7288 change. (Bug#8496)
7289
a6744a35
EZ
72902011-04-13 Eli Zaretskii <eliz@gnu.org>
7291
7292 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
7293 when at ZV. (Bug#8487)
7294
e7974947
AS
72952011-04-12 Andreas Schwab <schwab@linux-m68k.org>
7296
baad03f0
AS
7297 * charset.c (Fclear_charset_maps): Use xfree instead of free.
7298 (Bug#8437)
7299 * keyboard.c (parse_tool_bar_item): Likewise.
7300 * sound.c (sound_cleanup, alsa_close): Likewise.
7301 * termcap.c (tgetent): Likewise.
7302 * xfns.c (x_default_font_parameter): Likewise.
7303 * xsettings.c (read_and_apply_settings): Likewise.
7304
e7974947
AS
7305 * alloc.c (overrun_check_malloc, overrun_check_realloc)
7306 (overrun_check_free): Protoize.
7307
28272684
PE
73082011-04-12 Paul Eggert <eggert@cs.ucla.edu>
7309
7310 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
7311 since callers should never pass a negative size.
7312 Change the signature to match that of plain 'read' and 'write'; see
7313 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
7314 * lisp.h: Update prototypes of emacs_write and emacs_read.
7315
11997c76
EZ
73162011-04-11 Eli Zaretskii <eliz@gnu.org>
7317
7318 * xdisp.c (redisplay_window): Don't try to determine the character
7319 position of the scroll margin if the window start point w->startp
e896f03c 7320 is outside the buffer's accessible region. (Bug#8468)
11997c76 7321
8a2cbd72
EZ
73222011-04-10 Eli Zaretskii <eliz@gnu.org>
7323
7324 Fix write-region and its subroutines for buffers > 2GB.
7325 * fileio.c (a_write, e_write): Modify declaration of arguments and
7326 local variables to support buffers larger than 2GB.
7327 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7328
7329 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7330 argument, local variables, and return value.
7331
7332 * lisp.h: Update prototypes of emacs_write and emacs_read.
7333
7334 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7335
4073e537 73362011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7337
1ebfdcb6
PE
7338 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7339
b2ded58d
PE
7340 Fix more problems found by GCC 4.6.0's static checks.
7341
7d66342c
PE
7342 * xdisp.c (vmessage): Use a better test for character truncation.
7343
bbf47d44
PE
7344 * charset.c (load_charset_map): <, not <=, for optimization,
7345 and to avoid potential problems with integer overflow.
9248994d 7346 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7347 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7348 * editfns.c (Fformat): Likewise.
1e69125e 7349 * syntax.c (skip_chars): Likewise.
3befa583 7350
e3019616
PE
7351 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7352 This also lets GCC 4.6.0 generate slightly better loop code.
7353
becfa255
PE
7354 * callint.c (Fcall_interactively): <, not <=, for optimization.
7355 (Fcall_interactively): Count the number of arguments produced,
7356 not the number of arguments given. This is simpler and lets GCC
7357 4.6.0 generate slightly better code.
7358
dae0cd48
PE
7359 * ftfont.c: Distingish more carefully between FcChar8 and char.
7360 The previous code passed unsigned char * to a functions like
7361 strlen and xstrcasecmp that expect char *, which does not
7362 conform to the C standard.
7363 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7364 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7365 char * when the C standard requires it.
7366
76032d70
PE
7367 * keyboard.c (read_char): Remove unused var.
7368
eb3f1cc8
PE
7369 * eval.c: Port to Windows vsnprintf (Bug#8435).
7370 Include <limits.h>.
7371 (SIZE_MAX): Define if the headers do not.
7372 (verror): Do not give up if vsnprintf returns a negative count.
7373 Instead, grow the buffer. This ports to Windows vsnprintf, which
7374 does not conform to C99. Problem reported by Eli Zaretskii.
7375 Also, simplify the allocation scheme, by avoiding the need for
7376 calling realloc, and removing the ALLOCATED variable.
7377
70476b54
PE
7378 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7379
12020a9e
PE
7380 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7381 But keep the doprint source code for now, as we might revamp it
7382 and use it again (Bug#8435).
ea6c7ae6
PE
7383 * lisp.h (doprnt): Remove.
7384 * Makefile.in (base_obj): Remove doprnt.o.
7385 * deps.mk (doprnt.o): Remove.
7386
5fdb398c
PE
7387 error: Print 32- and 64-bit integers portably (Bug#8435).
7388 Without this change, on typical 64-bit hosts error ("...%d...", N)
7389 was used to print both 32- and 64-bit integers N, which relied on
7390 undefined behavior.
7391 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7392 New macro.
7393 * lisp.h (error, verror): Mark as printf-like functions.
7394 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7395 Report overflow in size calculations when allocating printf buffer.
7396 Do not truncate output string at its first null byte.
7397 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7398 Truncate the output at a character boundary, since vsnprintf does not
7399 do that.
7400 * charset.c (check_iso_charset_parameter): Convert internal
7401 character to string before calling 'error', since %c now has the
7402 printf meaning.
7403 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7404 overflow when computing char to be passed to 'error'. Do not
7405 pass Lisp_Object to 'error'; pass the integer instead.
7406 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7407 formatted with plain %d.
7408
b189fa66
PE
7409 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7410
bff87ef0
PE
7411 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7412
7e2cac20
PE
7413 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7414
ce4d90b5
PE
7415 * xterm.c (x_catch_errors): Remove duplicate declaration.
7416
266c9547
PE
7417 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7418
79c49ad2
PE
7419 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7420
368f4090
JM
74212011-04-10 Jim Meyering <meyering@redhat.com>
7422
7423 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7424 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7425 return ssize_t not "int", and use size_t as the buffer length.
7426 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7427 * gnutls.h: Update declarations.
7428 * process.c (read_process_output): Use ssize_t, to match.
7429 (send_process): Likewise.
7430
a32d4040
CY
74312011-04-09 Chong Yidong <cyd@stupidchicken.com>
7432
7433 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7434
8546720e 74352011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7436
04f2d78b
CB
7437 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7438 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7439
8546720e
GM
7440 * xterm.c (handle_one_xevent):
7441 * xmenu.c (create_and_show_popup_menu):
7442 * xselect.c (x_decline_selection_request)
7443 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7444
0a2f5c1a 74452011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7446
7447 Fix some uses of `int' instead of EMACS_INT.
7448 * search.c (string_match_1, fast_string_match)
7449 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7450 (scan_buffer, find_next_newline_no_quit)
7451 (find_before_next_newline, search_command, Freplace_match)
7452 (Fmatch_data): Make some `int' variables be EMACS_INT.
7453
7454 * xdisp.c (display_count_lines): 3rd argument and return value now
7455 EMACS_INT. All callers changed.
7456 (pint2hrstr): Last argument is now EMACS_INT.
7457
7458 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7459 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7460 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7461 (decode_coding_utf_16, decode_coding_emacs_mule)
7462 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7463 (decode_coding_ccl, decode_coding_charset)
7464 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7465 (decode_coding_iso_2022, decode_coding_emacs_mule)
7466 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7467 <char_offset, last_offset>: Declare EMACS_INT.
7468 (encode_coding_utf_8, encode_coding_utf_16)
7469 (encode_coding_emacs_mule, encode_invocation_designation)
7470 (encode_designation_at_bol, encode_coding_iso_2022)
7471 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7472 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7473 Declare EMACS_INT.
7474 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7475 (encode_invocation_designation): Last argument P_NCHARS is now
7476 EMACS_INT.
7477 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7478 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7479
7480 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7481 All users changed.
7482
7483 * ccl.c (Fccl_execute_on_string): Declare some variables
7484 EMACS_INT.
7485
8546720e 74862011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7487
7488 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7489
4e19a977
CS
74902011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7491
7492 * process.c (Fformat_network_address): Doc fix.
7493
87302331
R
74942011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7495
ee7683eb 7496 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7497
cbb59342
CY
74982011-04-08 Chong Yidong <cyd@stupidchicken.com>
7499
7500 * keyboard.c (read_char): Call Lisp function help-form-show,
7501 instead of using internal_with_output_to_temp_buffer.
7502 (Qhelp_form_show): New var.
e0d38eeb 7503 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7504
7505 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7506
7507 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7508
e67a13ab
CY
75092011-04-06 Chong Yidong <cyd@stupidchicken.com>
7510
04f2d78b
CB
7511 * process.c (Flist_processes): Remove to Lisp.
7512 (list_processes_1): Delete.
e67a13ab 7513
973f782d
EZ
75142011-04-06 Eli Zaretskii <eliz@gnu.org>
7515
7c106b1e
EZ
7516 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7517
973f782d
EZ
7518 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7519
41cf7d1a 75202011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7521
ca23cc88
PE
7522 Fix more problems found by GCC 4.6.0's static checks.
7523
f390e2d5
PE
7524 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7525
42eea0d0
PE
7526 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7527
b69769da 7528 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7529
f9541e84
PE
7530 * xdisp.c (vmessage): Mark as a printf-like function.
7531
13841b55
PE
7532 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7533
c136c10f
PE
7534 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7535
5e2d4a30
PE
7536 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7537 printf-like functions.
7538 (tiff_load): Add casts to remove these marks before passing them
7539 to system-supplied API.
7540
583f48b9
PE
7541 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7542
b25d760e
PE
7543 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7544 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7545 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7546 directly, rather than having caller test rule sign. This avoids
7547 some unnecessary tests.
7548 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7549 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7550 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7551
bc7b6697 7552 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7553 (xfont_open): Avoid unnecessary tests.
bc7b6697 7554
27ccc379
PE
7555 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7556
dcd5c89a
PE
7557 * composite.h, composite.c (composition_gstring_put_cache):
7558 Use EMACS_INT, not int, for length.
7559
b13a45c6
PE
7560 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7561 breaking out part of COMPOSITION_DECODE_RULE.
7562 (COMPOSITION_DECODE_RULE): Use it.
7563 * composite.c (get_composition_id): Remove unused local vars,
7564 by using the new macro.
7565
1e792e4d
PE
7566 * textprop.c (set_text_properties_1): Change while to do-while,
7567 since the condition is always true at first.
7568
dc6c6455 7569 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7570 (interval_deletion_adjustment): Return unsigned value.
7571 All uses changed.
dc6c6455 7572
aba7731a
PE
7573 * process.c (list_processes_1, create_pty, read_process_output):
7574 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7575 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7576 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7577 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7578 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7579
fdfc4bf3
PE
7580 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7581
fca8fe46 7582 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7583 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7584
06a0259a 7585 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7586 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7587 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7588
e7b9e80f
PE
7589 * print.c (print_error_message): Avoid int overflow.
7590
56201685
PE
7591 * font.c (font_list_entities): Redo for clarity,
7592 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7593
78834453 7594 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7595 (font_score): Avoid potential overflow in diff calculation.
78834453 7596
0bc0b309 7597 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7598 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7599
e610eaca
PE
7600 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7601
b895abce
PE
7602 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7603 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7604 can always succeed if overflow has undefined behavior.
7605
1f1d9321 7606 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7607 (wordify): Omit three unnecessary tests.
1f1d9321 7608
c59478bc
PE
7609 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7610 All callers changed. This avoids the need for an unused var.
7611
79b73827
PE
7612 * casefiddle.c (casify_region): Remove var that is set but not used.
7613
a4db5dfe
PE
7614 * dired.c (file_name_completion): Remove var that is set but not used.
7615
43aae36e
PE
7616 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7617
2a47c44d 7618 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7619 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7620
a37c69bf
PE
7621 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7622 Check for integer overflow on size calculations.
7623
328ab8e7
PE
7624 * buffer.c (Fprevious_overlay_change): Remove var that is set
7625 but not used.
7626
e5a2a5cb
PE
7627 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7628 Remove vars that are set but not used.
8d84a6eb 7629 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7630 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7631
a60e5f68
PE
7632 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7633
f661cb61 7634 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7635 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7636
f0397f5a
PE
7637 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7638 that are set but not used.
7639
8664db06 7640 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7641 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7642
6abdaa4a
PE
7643 * xselect.c (x_get_local_selection, x_handle_property_notify):
7644 Remove vars that are set but not used.
7645
0ce7538d 7646 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7647 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7648
9ae848fc
PE
7649 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7650 Remove var that is set but not used.
0b918413
PE
7651 (scroll_bar_windows_size): Now size_t, not int.
7652 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7653 Check for overflow.
9ae848fc 7654
a5a62657
PE
7655 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7656 (map_tty_color) [!defined MSDOS]: Likewise.
7657
5c5cdd39
PE
7658 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7659
66ebf983
PE
7660 * coding.c: Remove vars that are set but not used.
7661 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7662 All callers changed.
7663 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7664 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7665 (decode_coding_charset): Remove vars that are set but not used.
7666
1be4d761
PE
7667 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7668 that is set but not used.
7669
47553fa8
PE
7670 * print.c (print_object): Remove var that is set but not used.
7671
1f7196bf 7672 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7673 The gnulib version avoids calling malloc in the usual case,
7674 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7675 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7676 * filelock.c (current_lock_owner): Likewise.
7677 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7678 * sysdep.c: Include allocator.h, careadlinkat.h.
7679 (emacs_no_realloc_allocator): New static constant.
7680 (emacs_readlink): New function.
fdb61804
PE
7681 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7682 ../lib/careadlinkat.h.
d1fdcab7 7683
f84c17c7
SM
76842011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7685
7686 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7687 first non-nil return value).
7688
ef3862ad
JD
76892011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7690
7691 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7692 if not defined (Bug#8403).
7693
376a7006
JB
76942011-04-02 Juanma Barranquero <lekktu@gmail.com>
7695
7696 * xdisp.c (display_count_lines): Remove parameter `start',
7697 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7698 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7699 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7700 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7701 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7702 and thereabouts. All callers changed.
7703 (get_per_char_metric): Remove parameter `f', unused since
7704 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7705
6ca3801d
JM
77062011-04-02 Jim Meyering <meyering@redhat.com>
7707
7708 do not dereference NULL upon failed strdup
7709 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7710 (ns_get_family): Likewise.
7711
d8e2b5ba
JB
77122011-04-02 Juanma Barranquero <lekktu@gmail.com>
7713
7714 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7715
8c74fcbd
JD
77162011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7717
7718 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7719 later (Bug#8403).
7720
7200d79c
SM
77212011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7722
03408648 7723 Add lexical binding.
7200d79c 7724
03408648
SM
7725 * window.c (Ftemp_output_buffer_show): New fun.
7726 (Fsave_window_excursion):
7727 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7728
7729 * lread.c (lisp_file_lexically_bound_p): New function.
7730 (Fload): Bind Qlexical_binding.
7731 (readevalloop): Remove `evalfun' arg.
7732 Bind Qinternal_interpreter_environment.
7733 (Feval_buffer): Bind Qlexical_binding.
7734 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7735 Mark as dynamic.
7736 (syms_of_lread): Declare `lexical-binding'.
7737
7738 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7739
7740 * keyboard.c (eval_dyn): New fun.
7741 (menu_item_eval_property): Use it.
ca105506
SM
7742
7743 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7744
03408648
SM
7745 * fns.c (concat, mapcar1): Accept byte-code-functions.
7746
7747 * eval.c (Fsetq): Handle lexical vars.
7748 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7749 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7750 (FletX, Flet): Obey lexical binding.
7751 (Fcommandp): Handle closures.
7752 (Feval): New `lexical' arg.
7753 (eval_sub): New function extracted from Feval. Use it almost
7754 everywhere where Feval was used. Look up vars in lexical env.
7755 Handle closures.
7756 (Ffunctionp): Move from subr.el.
7757 (Ffuncall): Handle closures.
7758 (apply_lambda): Remove `eval_flags'.
7759 (funcall_lambda): Handle closures and new byte-code-functions.
7760 (Fspecial_variable_p): New function.
7761 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7762 but without exporting it to Lisp.
23aba0ea 7763
23aba0ea 7764 * doc.c (Fdocumentation, store_function_docstring):
03408648 7765 * data.c (Finteractive_form): Handle closures.
23aba0ea 7766
03408648
SM
7767 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7768 interactive spec.
ba83908c 7769
04f2d78b
CB
7770 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7771 New byte-codes.
03408648
SM
7772 (exec_byte_code): New function extracted from Fbyte_code to handle new
7773 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7774
03408648 7775 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7776
03408648 7777 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7778
e2abce01
JB
77792011-03-31 Juanma Barranquero <lekktu@gmail.com>
7780
7781 * xdisp.c (redisplay_internal): Fix prototype.
7782
63696a73 77832011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7784
63696a73 7785 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7786 (try_scrolling): Use it when setting scroll_limit.
7787 Limit scrolling to 100 screen lines.
63696a73
EZ
7788 (redisplay_window): Even when falling back on "recentering",
7789 position point in the window according to scroll-conservatively,
7790 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7791
7792 (try_scrolling): When point is above the window, allow searching
7793 as far as scroll_max, or one screenful, to compute vertical
7794 distance from PT to the scroll margin position. This prevents
7795 try_scrolling from unnecessarily failing when
7796 scroll-conservatively is set to a value slightly larger than the
7797 window height. Clean up the case of PT below the margin at bottom
7798 of window: scroll_max can no longer be INT_MAX. When aggressive
7799 scrolling is in use, don't let point enter the opposite scroll
7800 margin as result of the scroll.
7801 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7802 threshold of 100 lines for never-recentering scrolling.
7803
e4cc2dfc
JB
78042011-03-31 Juanma Barranquero <lekktu@gmail.com>
7805
7806 * dispextern.h (move_it_by_lines):
7807 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7808 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7809 (message_log_check_duplicate): Remove parameters `prev_bol' and
7810 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7811 (redisplay_internal): Remove parameter `preserve_echo_area',
7812 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7813
7814 * indent.c (Fvertical_motion):
7815 * window.c (window_scroll_pixel_based, Frecenter):
7816 Don't pass `need_y_p' to `move_it_by_lines'.
7817
1c470562
SM
78182011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7819
44f230aa
SM
7820 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7821 steal a few bits to be more compact.
7822 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7823 Remove unneeded casts.
7824
1c470562
SM
7825 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7826
888adce9
ZK
78272011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7828
7829 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7830 binding" message (bug#7967).
7831
f838ed7b
PE
78322011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7833
77861b95
PE
7834 Fix more problems found by GCC 4.6.0's static checks.
7835
de6dbc14
PE
7836 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7837 Remove unused local var.
7838
f838ed7b
PE
7839 * editfns.c (Fmessage_box): Remove unused local var.
7840
792c7b2b
PE
7841 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7842 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7843 Omit unused local vars.
c499e557 7844 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7845 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7846 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7847 Omit unused local var.
7848
ba0165e1
PE
7849 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7850 Don't assume string length fits in int.
32ad8845 7851 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7852 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7853
3c59b4c9
PE
7854 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7855 instead of alloca (Bug#8344).
7856
a3eed478 7857 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7858 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7859
eb4d412d
PE
7860 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7861
1658b401
PE
7862 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7863 concerns.
7864
7865 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7866
7867 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7868
9a2c6e05
PE
7869 * keyboard.c (syms_of_keyboard): Use the same style as later
7870 in this function when indexing through an array. This also
7871 works around GCC bug 48267.
7872
03d0a109
PE
7873 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7874
44f730c8
PE
7875 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7876
fe75f926
PE
7877 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7878 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7879
ffa8c828
PE
7880 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7881 This avoids undefined behavior on integer overflow, and is a bit
7882 more convenient anyway since it is compared to a size_t variable.
7883
c5101a77
PE
7884 Variadic C functions now count arguments with size_t, not int.
7885 This avoids an unnecessary limitation on 64-bit machines, which
7886 caused (substring ...) to crash on large vectors (Bug#8344).
7887 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7888 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7889 All variadic functions and their callers changed accordingly.
c5101a77
PE
7890 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7891 * data.c (arith_driver, float_arith_driver): Likewise.
7892 * editfns.c (general_insert_function): Likewise.
7893 * eval.c (struct backtrace.nargs, interactive_p)
7894 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7895 (funcall_lambda, mark_backtrace): Likewise.
7896 * fns.c (concat): Likewise.
7897 * frame.c (x_set_frame_parameters): Likewise.
7898 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7899 0 if not found, not -1. All callers changed.
7900
dd3f25f7
PE
7901 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7902 (stack_copy_size): Now size_t, not int.
7903 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7904
461c2ab9
JB
79052011-03-28 Juanma Barranquero <lekktu@gmail.com>
7906
7907 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7908 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7909 All callers changed.
7910
7911 * lisp.h (multibyte_char_to_unibyte):
7912 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7913 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7914 * character.h (CHAR_TO_BYTE8):
7915 * cmds.c (internal_self_insert):
7916 * editfns.c (general_insert_function):
7917 * keymap.c (push_key_description):
7918 * search.c (Freplace_match):
7919 * xdisp.c (message_dolog, set_message_1): All callers changed.
7920
f6d62986
SM
79212011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7922
7923 * keyboard.c (safe_run_hook_funcall): New function.
7924 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7925 don't set the hook to nil, but remove the offending function instead.
7926 (Qcommand_hook_internal): Remove, unused.
7927 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7928 Vcommand_hook_internal.
7929
7930 * eval.c (enum run_hooks_condition): Remove.
7931 (funcall_nil, funcall_not): New functions.
7932 (run_hook_with_args): Call each function through a `funcall' argument.
7933 Remove `cond' argument, now redundant.
7934 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7935 (Frun_hook_with_args_until_failure): Adjust accordingly.
7936 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7937
1db5b1ad
JB
79382011-03-28 Juanma Barranquero <lekktu@gmail.com>
7939
7940 * dispextern.h (string_buffer_position): Remove declaration.
7941
7942 * print.c (strout): Remove parameter `multibyte', unused since
7943 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7944
7945 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7946 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7947 All callers changed.
7948
7949 * w32.c (_wsa_errlist): Use braces for struct initializers.
7950
7951 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7952 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7953 All callers changed.
7954 (string_buffer_position): Likewise. Also, make static (it's never
7955 used outside xdisp.c).
7956 (cursor_row_p): Remove parameter `w', unused since
7957 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7958 (decode_mode_spec): Remove parameter `precision', introduced during
7959 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7960 All callers changed.
7961
5ffb62aa
JD
79622011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7963
7964 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7965
461c2ab9 79662011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7967
7968 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7969 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7970 (ns_update_auto_hide_menu_bar): New functions.
7971 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7972 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7973 ns_constrain_all_frames.
7974 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7975 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7976
5c380ffb
JD
79772011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7978
7979 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7980
9af30bdf
GM
79812011-03-27 Glenn Morris <rgm@gnu.org>
7982
7983 * syssignal.h: Replace RETSIGTYPE with void.
7984 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7985 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7986 Replace SIGTYPE with void everywhere.
7987 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7988 * s/template.h (SIGTYPE): Remove commented out definition.
7989
e2abce01
JB
79902011-03-26 Eli Zaretskii <eliz@gnu.org>
7991
7992 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7993 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7994
f868cd8a
JB
79952011-03-26 Juanma Barranquero <lekktu@gmail.com>
7996
59eb0929
JB
7997 * w32.c (read_unc_volume): Use parameter `henum', instead of
7998 global variable `wget_enum_handle'.
7999
8000 * keymap.c (describe_vector): Remove parameters `indices' and
8001 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8002 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8003
f868cd8a
JB
8004 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8005
8006 * keyboard.c (timer_check): Remove parameter `do_it_now',
8007 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8008 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8009 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8010
8011 * keyboard.c (read_char):
8012 * w32menu.c (w32_menu_display_help):
8013 * xmenu.c (show_help_event, menu_help_callback):
8014 Adjust calls to `show_help_echo'.
8015
8016 * gtkutil.c (xg_maybe_add_timer):
8017 * keyboard.c (readable_events):
8018 * process.c (wait_reading_process_output):
8019 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8020
8021 * insdel.c (adjust_markers_gap_motion):
8022 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8023 (gap_left, gap_right): Don't call it.
8024
2ecf6fdb
CY
80252011-03-25 Chong Yidong <cyd@stupidchicken.com>
8026
8027 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8028 incurred during fontification.
8029
6b1f9ba4
JB
80302011-03-25 Juanma Barranquero <lekktu@gmail.com>
8031
8032 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8033 (DEFVAR_PER_BUFFER): Don't pass it.
8034
8035 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8036 (scrolling_window): Don't pass it.
8037
0f4a96b5
JB
80382011-03-25 Juanma Barranquero <lekktu@gmail.com>
8039
8040 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8041
8042 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8043 and `suffix'.
8044 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8045 of variables specific to SELinux and computation of `encoded_absname'.
8046
8047 * image.c (XPutPixel): Remove unused variable `height'.
8048
8049 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8050
8051 * unexw32.c (get_section_info): Remove unused variable `section'.
8052
8053 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8054 (system_process_attributes): Remove unused variable `sess'.
8055 (sys_read): Remove unused variable `err'.
8056
8057 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8058 (w32_wnd_proc): Remove unused variable `isdead'.
8059 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8060 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8061 (x_create_tip_frame): Remove unused variable `tem'.
8062
8063 * w32inevt.c (w32_console_read_socket):
8064 Remove unused variable `no_events'.
8065
8066 * w32term.c (x_draw_composite_glyph_string_foreground):
8067 Remove unused variable `width'.
8068
1149507c
JB
80692011-03-24 Juanma Barranquero <lekktu@gmail.com>
8070
8071 * w32term.c (x_set_glyph_string_clipping):
8072 Don't pass uninitialized region to CombineRgn.
8073
9c88f339
JB
80742011-03-23 Juanma Barranquero <lekktu@gmail.com>
8075
8076 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8077 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8078 (Fx_close_connection): Remove unused variable `i'.
8079
8080 * w32font.c (w32font_draw): Return number of glyphs.
8081 (w32font_open_internal): Remove unused variable `i'.
8082 (w32font_driver): Add missing initializer.
8083
8084 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8085 (fill_in_menu): Remove unused variable `items_added'.
8086
8087 * w32term.c (last_mouse_press_frame): Remove static global variable.
8088 (w32_clip_to_row): Remove unused variable `f'.
8089 (x_delete_terminal): Remove unused variable `i'.
8090
8091 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8092 (NOTHING): Remove unused static global variable.
8093 (uniscribe_check_otf): Remove unused variable `table'.
8094 (uniscribe_font_driver): Add missing initializers.
8095
dee091a3
JD
80962011-03-23 Julien Danjou <julien@danjou.info>
8097
8098 * term.c (Fsuspend_tty, Fresume_tty):
8099 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8100 * window.c (temp_output_buffer_show):
8101 * insdel.c (signal_before_change):
8102 * frame.c (Fhandle_switch_frame):
8103 * fileio.c (Fdo_auto_save):
8104 * emacs.c (Fkill_emacs):
8105 * editfns.c (save_excursion_restore):
8106 * cmds.c (internal_self_insert):
8107 * callint.c (Fcall_interactively):
8108 * buffer.c (Fkill_all_local_variables):
8109 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8110 Use Frun_hooks.
0f4a96b5 8111 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8112 unconditionally since it does the check itself.
dee091a3 8113
2c520ab5 81142011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8115
c9c49752
PE
8116 Fix more problems found by GCC 4.5.2's static checks.
8117
8abc3f12
PE
8118 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8119 the first time through the loop, since we know p0 < p1 then.
8120 This also avoids a gcc -Wstrict-overflow warning.
8121
a2d26660
PE
8122 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8123 leading to a memory leak, possible in functions like
8124 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8125 of objects (Bug#8318).
a2d26660 8126
916c72e9
PE
8127 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8128 that could (at least in theory) be that large.
8129
19ab8a18
PE
8130 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8131 This is less likely to overflow, and avoids undefined behavior if
8132 overflow does occur. All callers changed. Use strtoul to scan
8133 for the unsigned long integer.
b7cbbd6f
PE
8134 (pint2hrstr): Simplify and tune code slightly.
8135 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8136
f0641eff
PE
8137 * scroll.c (do_scrolling): Work around GCC bug 48228.
8138 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8139
7f650bb9
PE
8140 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8141 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8142 (validate_x_resource_name): Simplify count usage.
8143 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8144
37dd57d1
PE
8145 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8146 fail (Bug#8306).
81e56e61 8147
699979fc 8148 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8149
401bf9b4
PE
8150 * process.c (Fmake_network_process): Use socklen_t, not int,
8151 where POSIX says socklen_t is required in portable programs.
8152 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8153 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8154 (Fmake_network_process, server_accept_connection):
8155 (wait_reading_process_output, read_process_output):
8156 Likewise.
8157
b93aacde
PE
8158 * process.c: Rename or move locals to avoid shadowing.
8159 (list_processes_1, Fmake_network_process):
8160 (read_process_output_error_handler, exec_sentinel_error_handler):
8161 Rename or move locals.
4dc343ee 8162 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8163 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8164 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8165 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8166 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8167
af8a867c 8168 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8169 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8170 Include tparam.h instead, since it declares them.
af8a867c
PE
8171 * cm.h (PC): Remove extern decl; tparam.h now does this.
8172 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8173 * terminfo.c: Include tparam.h, to check interfaces.
8174 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8175 (tparam): Adjust signature to match interface in tparam.h;
8176 this removes some undefined behavior. Check that outstring and len
8177 are zero, which they always are with Emacs.
8178 * tparam.h (PC, BC, UP): New extern decls.
8179
0248044d 8180 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8181 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8182
8ff096c1 8183 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8184 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8185 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8186 (ftfont_list): Remove unused local.
49eaafba
PE
8187 (get_adstyle_property, ftfont_pattern_entity):
8188 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8189 Rename locals to avoid shadowing.
8ff096c1 8190
e2be39f6
PE
8191 * xfont.c (xfont_list_family): Mark var as initialized.
8192
c9735e30
PE
8193 * xml.c (make_dom): Now static.
8194
8f5201ae
PE
8195 * composite.c (composition_compute_stop_pos): Rename local to
8196 avoid shadowing.
b246f932
PE
8197 (composition_reseat_it): Remove unused locals.
8198 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8199 (composition_update_it): Mark var as initialized.
11b61122
PE
8200 (find_automatic_composition): Mark vars as initialized,
8201 with a FIXME (Bug#8290).
8f5201ae 8202
760fbc2c
PE
8203 character.h: Rename locals to avoid shadowing.
8204 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8205 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8206 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8207 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8208 to avoid shadowing.
8209
ff08eb85
PE
8210 * textprop.c (property_change_between_p): Remove; unused.
8211
fc7bf025
PE
8212 * intervals.c (interval_start_pos): Now static.
8213
235d7abc
PE
8214 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8215
44f230aa
SM
8216 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8217 Rename locals to avoid shadowing.
3e7d6594 8218
50060332
PE
8219 * sound.c (wav_play, au_play, Fplay_sound_internal):
8220 Fix pointer signedness.
d01f234b 8221 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8222 (wav_play): Initialize a variable to 0, to prevent undefined
8223 behavior (Bug#8278).
50060332 8224
c4fc4e30
PE
8225 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8226
918436ed
PE
8227 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8228
c939f91b
PE
8229 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8230 clobbering (Bug#8298).
b9c7f648
PE
8231 * sysdep.c (sys_subshell): Likewise.
8232 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8233
6bd8c144
PE
8234 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8235 This should get cleaned up, so that child_setup has the
8236 same signature on all platforms.
8237
7710357c 8238 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8239 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8240
c59da222
CY
82412011-03-22 Chong Yidong <cyd@stupidchicken.com>
8242
8243 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8244 not to be necessary, and produces flickering.
8245
66b87493
GM
82462011-03-20 Glenn Morris <rgm@gnu.org>
8247
8248 * config.in: Remove file.
8249
45b6f6d5
JB
82502011-03-20 Juanma Barranquero <lekktu@gmail.com>
8251
8252 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8253 are now in src/globals.h.
8254 (syms_of_minibuf): Remove spurious & from previous change.
8255
3ec03f7e
LL
82562011-03-20 Leo <sdl.web@gmail.com>
8257
8258 * minibuf.c (completing-read-function): New variable.
8259 (completing-read-default): Rename from completing-read.
8260 (completing-read): Call completing-read-function.
8261
b14e3e21
CY
82622011-03-19 Juanma Barranquero <lekktu@gmail.com>
8263
8264 * xfaces.c (Fx_load_color_file):
8265 Read color file from absolute filename (bug#8250).
8266
f2b726e6
JB
82672011-03-19 Juanma Barranquero <lekktu@gmail.com>
8268
8269 * makefile.w32-in: Update dependencies.
8270
09f6ff02
EZ
82712011-03-17 Eli Zaretskii <eliz@gnu.org>
8272
8273 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
8274
29a6015a
PE
82752011-03-17 Paul Eggert <eggert@cs.ucla.edu>
8276
a3a6c54e
PE
8277 Fix more problems found by GCC 4.5.2's static checks.
8278
b766f867
PE
8279 * process.c (make_serial_process_unwind, send_process_trap):
8280 (sigchld_handler): Now static.
8281
be02381c
PE
8282 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
8283 That way, the code declares only the vars that it needs.
8284 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
8285 * s/cygwin.h (PTY_ITERATION): Likewise.
8286 * s/darwin.h (PTY_ITERATION): Likewise.
8287 * s/gnu-linux.h (PTY_ITERATION): Likewise.
8288
57048744
PE
8289 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
8290 * process.c (allocate_pty): Don't declare stb unless it's needed.
8291
7914961c 8292 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
8293 (CONSTANTLIM): Remove; unused.
8294 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
8295 Define only if needed.
7914961c 8296
b3967b18
PE
8297 * unexelf.c (unexec): Name an expression,
8298 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
8299 Use a different way to cause a compilation error if anyone uses
8300 n rather than nn, a way that does not involve shadowing.
73366a00 8301 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 8302
29a6015a
PE
8303 * deps.mk (unexalpha.o): Remove; unused.
8304
43cfc33e 8305 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 8306 * unexec.h: New file.
ce701a33
PE
8307 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
8308 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
8309 Depend on unexec.h.
8310 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
8311 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
8312 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 8313 Change as necessary to match prototype in unexec.h.
ce701a33 8314
01f44d5a
PE
8315 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
8316 shadowing.
4f63c6bb 8317 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 8318
a6670b0b
PE
8319 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
8320 Rename locals to avoid shadowing.
8321
cef2010d 8322 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 8323 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8324
d4d7173a
PE
8325 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8326
f08b802a
PE
8327 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8328 warning when compiling print.c.
8329
3ddb0639
PE
8330 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8331 instead of using an uninitialized var.
5ad03b97 8332 (font_sort_entities): Mark var as initialized.
3ddb0639 8333
170a2692
PE
8334 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8335
e663c700
PE
8336 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8337 pointers to constants.
89bc529a 8338 (font_parse_fcname): Remove unused vars.
7b81e2d0 8339 (font_delete_unmatched): Now static.
ea838e10 8340 (font_get_spec): Remove; unused.
13a547c6
PE
8341 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8342 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8343 Rename or move locals to avoid shadowing.
e663c700 8344
2a80c887 8345 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8346 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8347
1384fa33 8348 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8349 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8350
8b2c52e9
PE
8351 * alloc.c (mark_backtrace): Move decl from here ...
8352 * lisp.h: ... to here, so that it can be checked.
8353
475545b5 8354 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8355 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8356 (lisp_indirect_variable): Name an expression,
8357 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8358 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8359
b1349114 8360 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8361 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8362 Use const pointer when appropriate.
b1349114 8363
a2928364
PE
8364 * lisp.h (get_system_name, get_operating_system_release):
8365 Move decls here, to check interfaces.
8366 * process.c (get_operating_system_release): Move decl to lisp.h.
8367 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8368 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8369 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8370 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8371 (Fformat_time_string, Fencode_time, Finsert_char):
8372 (Ftranslate_region_internal, Fformat):
8373 Rename or remove local vars to avoid shadowing.
9710023e 8374 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8375
a415e694
PE
8376 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8377 avoid shadowing.
8378
8ef4622d
PE
8379 * lisp.h (eassert): Check that the argument compiles, even if
8380 ENABLE_CHECKING is not defined.
8381
946f9a5b
PE
8382 * data.c (Findirect_variable): Name an expression, to avoid
8383 gcc -Wbad-function-cast warning.
112396d6 8384 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8385 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8386 (Fmake_variable_buffer_local, Fmake_local_variable):
8387 Mark variables as initialized.
52746918 8388 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8389
e5aab7e7 8390 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8391 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8392 Rename locals to avoid shadowing.
dff45157
PE
8393 (mark_stack): Move local variables into the #ifdef region where
8394 they're used.
7bc26fdb
PE
8395 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8396 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8397 needed otherwise.
8398 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8399 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8400 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8401
e5aab7e7
PE
8402 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8403 avoids undefined behavior in theory.
8404
4da60324
PE
8405 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8406
88043301
PE
8407 Use functions, not macros, for up- and down-casing (Bug#8254).
8408 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8409 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8410 to use the following functions instead of these macros.
8411 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8412 EMACS_INT, since callers assume the returned value fits in int.
8413 (upcase1): Likewise, for UPCASE_TABLE.
8414 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8415 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8416 the race-condition problem in the old DOWNCASE.
88043301 8417
19ed5445
PE
8418 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8419 Rename locals to avoid shadowing.
8420 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8421 (regex_compile, re_search_2, re_match_2_internal):
8422 Remove unused local vars.
952db0d7
PE
8423 (FREE_VAR): Rewrite so as not to use empty "else",
8424 which gcc can warn about.
da053e48 8425 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8426 (RETALLOC_IF): Define only if needed.
8427 (WORDCHAR_P): Likewise. This one is never needed, but is used
8428 only in a comment talking about a compiler bug, so put inside
8429 the #if 0 of that comment.
8430 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8431 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8432 Remove; unused.
19ed5445 8433
1f3561e4 8434 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8435 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8436 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8437
ded6f8f7
PE
8438 * search.c (simple_search): Remove unused var.
8439
dbd37a95
PE
8440 * dired.c (compile_pattern): Move decl from here ...
8441 * lisp.h: ... to here, so that it can be checked.
8442 (struct re_registers): New forward decl.
8443
7e47afad
PE
8444 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8445
85f24f61
PE
8446 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8447 All uses changed.
8448 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8449 Rename locals to avoid shadowing.
5671df8f 8450 (Fvertical_motion): Mark locals as initialized.
85f24f61 8451
181aa2be 8452 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8453 (casify_region): Mark local as initialized.
181aa2be 8454
930d429c
PE
8455 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8456
7082eac6
PE
8457 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8458 New macros, so that the caller can use some names other than
8459 gcpro1, gcpro2, etc.
8460 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8461 of the new macros.
8462 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8463 argument, for consistency with GCPRO2_VAR, etc: it is now the
8464 prefix of the variable, not the variable itself. All uses
8465 changed.
38b2c076
PE
8466 * dired.c (directory_files_internal, file_name_completion):
8467 Rename locals to avoid shadowing.
8468
15206ed9
PE
8469 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8470 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8471 dired.c's scmp function, had undefined behavior.
8472 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8473 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8474 * buffer.h: ... to here, because these macros use current_buffer,
8475 and the new implementation with inline functions needs to have
8476 current_buffer in scope now, rather than later when the macros
8477 are used.
8478 (downcase, upcase1): New static inline functions.
8479 (DOWNCASE, UPCASE1): Reimplement using these functions.
8480 This avoids undefined behavior in expressions like
8481 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8482 from race conditions in accessing the global variables
8483 case_temp1 and case_temp2.
8484 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8485 * lisp.h (case_temp1, case_temp2): Remove their decls.
8486 * character.h (ASCII_CHAR_P): Move from here ...
8487 * lisp.h: ... to here, so that the inline functions mentioned
8488 above can use them.
8489
4a6bea26
PE
8490 * dired.c (directory_files_internal_unwind): Now static.
8491
f14b7e14
PE
8492 * fileio.c (file_name_as_directory, directory_file_name):
8493 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8494 Now static.
2893f146
PE
8495 (file_name_as_directory): Use const pointers when appropriate.
8496 (Fexpand_file_name): Likewise. In particular, newdir might
8497 point at constant storage, so make it a const pointer.
fd4ead52 8498 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8499 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8500 signedness issues.
f839df0c
PE
8501 (Fset_file_times, Finsert_file_contents, auto_save_error):
8502 Rename locals to avoid shadowing.
f14b7e14 8503
5716756e 8504 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8505 (Ftry_completion, Fall_completions): Rename or remove locals
8506 to avoid shadowing.
5716756e 8507
b4c3046a
PE
8508 * marker.c (bytepos_to_charpos): Remove; unused.
8509
b45db522
PE
8510 * lisp.h (verify_bytepos, count_markers): New decls,
8511 so that gcc does not warn that these functions aren't declared.
8512
85876d07
PE
8513 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8514 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8515 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8516 (copy_text): Remove unused local var.
85876d07 8517
03d78a21 8518 * filelock.c (within_one_second): Now static.
b3dd38ab 8519 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8520
5df8f01b
PE
8521 * buffer.c (fix_overlays_before): Mark locals as initialized.
8522 (fix_start_end_in_overlays): Likewise. This function should be
8523 simplified by using pointers-to-pointers, but that's a different
8524 matter.
b1d876f1 8525 (switch_to_buffer_1): Now static.
8f54f30a
PE
8526 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8527 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8528
a70072c9 8529 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8530 Fix pointer signedness issue.
edced198
PE
8531 (sys_subshell): Mark local as volatile if checking for lint,
8532 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8533 (MAXPATHLEN): Define only if needed.
a70072c9 8534
a0977c44
PE
8535 * process.c (serial_open, serial_configure): Move decls from here ...
8536 * systty.h: ... to here, so that they can be checked.
8537
a884fdcc
PE
8538 * fns.c (get_random, seed_random): Move extern decls from here ...
8539 * lisp.h: ... to here, so that they can be checked.
8540
604efe86 8541 * sysdep.c (reset_io): Now static.
b8950c94 8542 (wait_for_termination_signal): Remove; unused.
604efe86 8543
38fc62d9
PE
8544 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8545 (copy_keymap_item, append_key, push_text_char_description):
8546 Now static.
1004a21a 8547 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8548 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8549 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8550 (describe_map_tree):
8551 Rename locals to avoid shadowing.
38fc62d9 8552
2f2650da
PE
8553 * keyboard.c: Declare functions static if they are not used elsewhere.
8554 (echo_char, echo_dash, cmd_error, top_level_2):
8555 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8556 (read_char, kbd_buffer_get_event, make_lispy_position):
8557 (make_lispy_event, make_lispy_movement, apply_modifiers):
8558 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8559 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8560 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8561 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8562 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8563
a053e86c 8564 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8565 (mark_kboards): Move decl here ...
8566 * alloc.c (mark_kboards): ... from here.
a053e86c 8567
4752793e
PE
8568 * lisp.h (force_auto_save_soon): New decl.
8569
74f10ca7 8570 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8571 (DEFINE_DUMMY_FUNCTION): New macro.
8572 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8573 Use it.
c03cd23f
PE
8574 (main): Add casts to avoid warnings
8575 if GCC considers string literals to be constants.
74f10ca7 8576
022e70d4
PE
8577 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8578
59d6fe83
PE
8579 * dbusbind.c: Pointer signedness fixes.
8580 (xd_signature, xd_append_arg, xd_initialize):
8581 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8582 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8583 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8584 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8585
78320123
PE
8586 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8587 if GCC considers string literals to be constants.
49cebcca 8588 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8589
35ac2a97
SM
85902011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8591
fb103ca9
SM
8592 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8593 (print_preprocess, print_object): New macro to fix last change.
8594
35ac2a97
SM
8595 * print.c (print_preprocess): Don't forget font objects.
8596
62973b41
JB
85972011-03-16 Juanma Barranquero <lekktu@gmail.com>
8598
8599 * emacs.c (USAGE3): Doc fixes.
8600
0e48bb22
AS
86012011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8602
8603 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8604 structure.
8605
7684e57b
JB
86062011-03-14 Juanma Barranquero <lekktu@gmail.com>
8607
8608 * lisp.h (VWindow_system, Qfile_name_history):
8609 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8610 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8611 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8612
8613 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8614 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8615
8616 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8617 * w32console.c (detect_input_pending, read_input_pending)
8618 (encode_terminal_code):
8619 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8620 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8621 (w32_system_caret_y, Qfile_name_history):
8622 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8623 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8624 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8625 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8626 * w32proc.c (Qlocal, report_file_error):
8627 * w32term.c (Vwindow_system, updating_frame):
8628 * w32uniscribe.c (initialized, uniscribe_font_driver):
8629 Remove unneeded extern declarations.
8630
2aa46d6c
CY
86312011-03-14 Chong Yidong <cyd@stupidchicken.com>
8632
c96bbc66 8633 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8634
cffc6f3b
CY
86352011-03-13 Chong Yidong <cyd@stupidchicken.com>
8636
8637 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8638 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8639 These macros can no longer be used for assignment.
8640
44f230aa
SM
8641 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8642 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8643 (record_buffer_markers, fetch_buffer_markers): New functions for
8644 recording and fetching special buffer markers.
8645 (set_buffer_internal_1, set_buffer_temp): Use them.
8646
8647 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8648
8649 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8650
8651 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8652 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8653
8654 * xdisp.c (hscroll_window_tree):
8655 (reconsider_clip_changes): Use PT instead of BUF_PT.
8656
d251f04b
EZ
86572011-03-13 Eli Zaretskii <eliz@gnu.org>
8658
8659 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8660 $(EMACS_ROOT)/lib/intprops.h.
8661
f0c77cd1
PE
86622011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8663
3eca4629
PE
8664 Fix more problems found by GCC 4.5.2's static checks.
8665
7c86ee98
PE
8666 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8667 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8668 (xg_free_frame_widgets): Make it clear that a local variable is
8669 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8670 (gdk_window_get_screen): Make it clear that this macro is needed
8671 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8672 (int_gtk_range_get_value): New function, which avoids a diagnostic
8673 from gcc -Wbad-function-cast.
8674 (xg_set_toolkit_scroll_bar_thumb): Use it.
8675 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8676 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8677 (get_utf8_string, xg_get_file_with_chooser):
8678 Rename locals to avoid shadowing.
8679 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8680
41729b81
PE
8681 * xgselect.c (xg_select): Remove unused var.
8682
f0c77cd1
PE
8683 * image.c (four_corners_best): Mark locals as initialized.
8684 (gif_load): Initialize transparent_p to zero (Bug#8238).
8685 Mark another local as initialized.
ec6cf4c6 8686 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8687
ce0ad53d 8688 * image.c (clear_image_cache): Now static.
d5d5a617 8689 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8690 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8691 (x_edge_detection): Remove unnecessary cast that
8692 gcc -Wbad-function-cast diagnoses.
2037898d 8693 (gif_load): Fix pointer signedness.
6ae141d6
PE
8694 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8695 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8696
33383987 86972011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8698
d32df629
PE
8699 Improve quality of tests for time stamp overflow.
8700 For example, without this patch (encode-time 0 0 0 1 1
8701 1152921504606846976) returns the obviously-bogus value (-948597
8702 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8703 reports time overflow. See
8704 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8705 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8706 * editfns.c: Include limits.h and intprops.h.
8707 (TIME_T_MIN, TIME_T_MAX): New macros.
8708 (time_overflow): Move earlier, to before first use.
8709 (hi_time, lo_time): New functions, for an accurate test for
8710 out-of-range times.
8711 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8712 (Fget_internal_run_time): Don't assume time_t fits in int.
8713 (make_time): Use list2 instead of Fcons twice.
8714 (Fdecode_time): More accurate test for out-of-range times.
8715 (check_tm_member): New function.
8716 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8717 (lisp_time_argument): Don't rely on undefined left-shift and
8718 right-shift behavior when checking for time stamp overflow.
8be6f318 8719
fe31d94c
PE
8720 * editfns.c (time_overflow): New function, refactoring common code.
8721 (Fformat_time_string, Fdecode_time, Fencode_time):
8722 (Fcurrent_time_string): Use it.
8723
8be6f318
PE
8724 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8725 * dired.c (make_time): Move to ...
8726 * editfns.c (make_time): ... here.
8727 * systime.h: Note the move.
8728
09d9db2c 87292011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8730
126bc0dc
YM
8731 * fringe.c (update_window_fringes): Remove unused variables.
8732
c47cbdfd
YM
8733 * unexmacosx.c (copy_data_segment): Also copy __got section.
8734 (Bug#8223)
8735
7ac80be9
EZ
87362011-03-12 Eli Zaretskii <eliz@gnu.org>
8737
c96bbc66 8738 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8739 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8740 Constify `char *' arguments and their references according to
8741 prototypes in tparam.h.
8742
ecb0f94d 8743 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8744
7ac80be9
EZ
8745 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8746 Adapt all references accordingly.
8747
8748 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8749
ef1fd07e
TT
87502011-03-11 Tom Tromey <tromey@redhat.com>
8751
8752 * buffer.c (syms_of_buffer): Remove obsolete comment.
8753
7ef4b50c
EZ
87542011-03-11 Eli Zaretskii <eliz@gnu.org>
8755
8756 * termhooks.h (encode_terminal_code): Declare prototype.
8757
8758 * msdos.c (encode_terminal_code): Don't declare prototype.
8759
8760 * term.c (encode_terminal_code): Now external again, used by
8761 w32console.c and msdos.c.
8762
44f230aa
SM
8763 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8764 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8765
4b1ec863 87662011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8767
1714f52b 8768 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8769
4b1ec863
PE
8770 * fringe.c (update_window_fringes): Mark locals as initialized
8771 (Bug#8227).
8772 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8773
524c7aa6
PE
8774 * alloc.c (mark_fringe_data): Move decl from here ...
8775 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8776 to check its interface.
8777 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8778
a5c0af81 8779 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8780 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8781 (fontset_font): Mark local as initialized.
a9a06e0b 8782 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8783
b4716021
PE
8784 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8785
811e9bac 8786 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8787 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8788 (x_own_selection, Fx_disown_selection_internal): Rename locals
8789 to avoid shadowing.
8790 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8791
7e3ab302
PE
8792 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8793 so that the caller can use some name other than gcpro1.
8794 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8795 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8796 (Fx_backspace_delete_keys_p):
8797 Use them to avoid shadowing, and rename vars to avoid shadowing.
8798 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8799 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8800 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8801 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8802 Remove unused locals.
7e3ab302
PE
8803 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8804 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8805 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8806 macros.
f78faa98 8807
e2b13473
PE
8808 * xterm.h (x_mouse_leave): New decl.
8809
77f23912
PE
8810 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8811 Remove unused functions.
cdf4ba58
PE
8812 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8813 (x_calc_absolute_position): Now static.
7411c686 8814 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8815 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8816 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8817 unless they are used.
38d0b34a
PE
8818 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8819 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8820 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8821 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8822 (x_error_catcher, x_connection_closed, x_error_handler):
8823 (x_error_quitter, xembed_send_message, x_iconify_frame):
8824 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8825 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8826 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8827
44f230aa
SM
8828 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8829 Rename or move locals to avoid shadowing.
6b463e58 8830 (tty_defined_color, merge_face_heights): Now static.
5967d051 8831 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8832 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8833 does not deduce is never used uninitialized.
73719eba
PE
8834 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8835 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8836
426994c3 8837 * terminal.c (store_terminal_param): Now static.
5489860b 8838
032f1620 8839 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8840 (set_frame_menubar): Remove unused local.
d4323972 8841 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8842 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8843 since they might point to immutable storage.
281585b0
PE
8844 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8845 since it's unused otherwise.
032f1620 8846
367c19e5 8847 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8848 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8849 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8850 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8851 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8852 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8853 does not deduce are never used uninitialized.
70739cbe 8854
07b48fa9
PE
8855 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8856
8868a238 8857 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8858 * window.c (window_loop, size_window):
8859 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8860
7e5cf297 8861 * window.c (display_buffer): Now static.
d6550a9f
PE
8862 (size_window): Mark variables that gcc -Wuninitialized
8863 does not deduce are never used uninitialized.
a586633d
PE
8864 * window.h (check_all_windows): New decl, to forestall
8865 gcc -Wmissing-prototypes diagnostic.
5b555da1 8866 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8867
f6095868
PE
8868 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8869 shadowing.
8870 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8871 Include <limits.h>.
8872 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8873 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8874 (load_charset_map): Mark variables that gcc -Wuninitialized
8875 does not deduce are never used uninitialized.
53df7c11 8876 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8877
f38b440c
PE
8878 * coding.c (coding_set_source, coding_set_destination):
8879 Use "else { /* comment */ }" rather than "else /* comment */;"
8880 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8881 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8882 a block, when the outer 'i' will do.
8883 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8884 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8885 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8886 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8887 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8888 Rename locals to avoid shadowing.
8889 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8890 * coding.c (emacs_mule_char, encode_invocation_designation):
8891 Now static, since they're not used elsewhere.
413bb2db 8892 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8893 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8894 (decode_coding_emacs_mule): Mark variables that gcc
8895 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8896 (detect_coding_iso_2022): Initialize a local variable that might
8897 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8898 this initialization is needed. (Bug#8211)
5f58e762
PE
8899 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8900 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8901 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8902 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8903 Remove unused macros.
f38b440c 8904
232b38b9 8905 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8906 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8907 * character.c (string_count_byte8): Likewise.
232b38b9 8908
fb90da1b
PE
8909 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8910 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8911
fb93dbc2
PE
8912 * chartab.c (copy_sub_char_table): Now static, since it's not used
8913 elsewhere.
5c156ace
PE
8914 (sub_char_table_ref_and_range, char_table_ref_and_range):
8915 Rename locals to avoid shadowing.
bbcd0949 8916 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8917
7d3b3862 8918 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8919 (BIDI_BOB): Remove unused macro.
7d3b3862 8920
6be7d3da
PE
8921 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8922 deduce are never used uninitialized.
c2ed9c8b 8923 * term.c (encode_terminal_code): Likewise.
6be7d3da 8924
75f8807f 8925 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8926
50938595
PE
8927 * tparam.h: New file.
8928 * term.c, tparam.h: Include it.
8929 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8930 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8931 Move these decls to tparam.h, and make them agree with what
8932 is actually in tparam.c. The previous trick of using incompatible
8933 decls in different modules does not conform to the C standard.
8934 All callers of tparam changed to use tparam's actual API.
8935 * tparam.c (tparam1, tparam, tgoto):
8936 Use const pointers where appropriate.
8937
fbceeba2
PE
8938 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8939 * cm.h (struct cm): Likewise.
8940 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8941 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8942 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8943 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8944 (turn_on_face, init_tty): Likewise.
8945 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8946
7f3f1250
PE
8947 * term.c (term_mouse_position): Rename local to avoid shadowing.
8948
e6ca6543
PE
8949 * alloc.c (mark_ttys): Move decl from here ...
8950 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8951
c40f8d15
AS
89522011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8953
8954 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8955
cfe0661d
JB
89562011-03-09 Juanma Barranquero <lekktu@gmail.com>
8957
8958 * search.c (compile_pattern_1): Remove argument regp, unused since
8959 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8960 (compile_pattern): Don't pass it.
8961
0afb4571
J
89622011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8963
8964 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8965 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8966 for ! HAVE_GTK3.
8967 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8968
8969 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8970
8971 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8972 gdk_window_get_screen, gdk_window_get_geometry,
8973 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8974 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8975 (xg_get_pixbuf_from_pixmap): New function.
8976 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8977 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8978 Call xg_get_pixbuf_from_pixmap instead of
8979 gdk_pixbuf_get_from_drawable.
8980 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8981 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8982 (xg_check_special_colors): Use GtkStyleContext and its functions
8983 for HAVE_GTK3.
8984 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8985 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8986 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8987 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8988 Call gtk_widget_get_preferred_size.
0afb4571
J
8989 (xg_frame_resized): gdk_window_get_geometry only takes 5
8990 parameters.
44f230aa
SM
8991 (xg_win_to_widget, xg_event_is_for_menubar):
8992 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8993 (xg_set_widget_bg): New function.
8994 (delete_cb): New function.
895009e1 8995 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 8996 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
8997 (xg_set_background_color): Call xg_set_widget_bg.
8998 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8999 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9000 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9001 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9002 if ! HAVE_GTK3.
9003 (update_frame_tool_bar): Call gtk_widget_hide.
9004 (xg_initialize): Use GDK_KEY_g.
9005
9006 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9007 if ! HAVE_GTK3
9008 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9009
9010 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9011 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9012 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9013
1c2cc4ef
JB
90142011-03-08 Juanma Barranquero <lekktu@gmail.com>
9015
9016 * w32xfns.c (select_palette): Check success of RealizePalette against
9017 GDI_ERROR, not zero.
9018
33383987 9019See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9020
9021;; Local Variables:
9022;; coding: utf-8
aac0c6e3
MR
9023;; End:
9024
33383987 9025 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
9026
9027 This file is part of GNU Emacs.
9028
9029 GNU Emacs is free software: you can redistribute it and/or modify
9030 it under the terms of the GNU General Public License as published by
9031 the Free Software Foundation, either version 3 of the License, or
9032 (at your option) any later version.
9033
9034 GNU Emacs is distributed in the hope that it will be useful,
9035 but WITHOUT ANY WARRANTY; without even the implied warranty of
9036 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9037 GNU General Public License for more details.
9038
9039 You should have received a copy of the GNU General Public License
9040 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.