Fix typo in previous comment.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
5d4cb038
PE
12011-04-14 Paul Eggert <eggert@cs.ucla.edu>
2
e3b27b31
PE
3 Don't publish debugger-only interfaces to other modules.
4 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5 (verify_bytepos, count_markers): Move decls to the only modules
6 that need them.
7 * region-cache.h (pp_cache): Likewise.
8 * window.h (check_all_windows): Likewise.
9 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
10
5d4cb038
PE
11 * sysdep.c (croak): Now static, if
12 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
13 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
14
15 * alloc.c (refill_memory_reserve): Now static if
16 !defined REL_ALLOC || defined SYSTEM_MALLOC.
17 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 18
e87b6180
PE
19 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
20 Define only if USE_LUCID.
21
ac64929e
PE
22 * xrdb.c (x_customization_string, x_rm_string): Now static.
23
6f37259d
PE
24 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
25 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
26
1683e3ab
PE
27 * xdisp.c (draw_row_with_mouse_face): Now static.
28 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
29
de9c2632
PE
30 * window.h (check_all_windows): Mark externally visible.
31
2b96acb7
PE
32 * window.c (window_deletion_count): Now static.
33
34 * undo.c: Make symbols static if they're not exported.
35 (last_undo_buffer, last_boundary_position, pending_boundary):
36 Now static.
37
50436f33
PE
38 * textprop.c (interval_insert_behind_hooks): Now static.
39 (interval_insert_in_front_hooks): Likewise.
40
64520e5c
PE
41 * term.c: Make symbols static if they're not exported.
42 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
43 (max_frame_lines, tty_set_terminal_modes):
44 (tty_reset_terminal_modes, tty_turn_off_highlight):
45 (get_tty_terminal): Now static.
46 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
47 * termhooks.h (term_mouse_moveto): Do not declare if
48 HAVE_WINDOW_SYSTEMM.
49 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
50 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
51
1fa53021
PE
52 * sysdep.c: Make symbols static if they're not exported.
53 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
54 Now static.
55 (sigprocmask_set, full_mask): Remove; unused.
56 (wait_debugging): Mark as visible.
57 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
58 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
59
d4b43b22
PE
60 * syntax.c (syntax_temp): Define only if !__GNUC__.
61
b7c513d0
PE
62 * sound.c (current_sound_device, current_sound): Now static.
63
989b29ad
PE
64 * search.c (searchbufs, searchbuf_head): Now static.
65
13a55a78
PE
66 * scroll.c (scroll_cost): Remove; unused.
67 * dispextern.h (scroll_cost): Remove decl.
68
de68a1fc
PE
69 * region-cache.h (pp_cache): Mark as externally visible.
70
40ccffa6
PE
71 * process.c: Make symbols static if they're not exported.
72 (process_tick, update_tick, create_process, chan_process):
73 (Vprocess_alist, proc_buffered_char, datagram_access):
74 (fd_callback_data, send_process_frame, process_sent_to): Now static.
75 (deactivate_process): Mark defn as static, as well as decl.
76 * lisp.h (create_process): Remove decl.
77 * process.h (chan_process, Vprocess_alist): Remove decls.
78
ad64fc97
PE
79 * print.c: Make symbols static if they're not exported.
80 (print_depth, new_backquote_output, being_printed, print_buffer):
81 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
82 (print_interval, print_number_index, initial_stderr_stream):
83 Now static.
84 * lisp.h (Fprinc): Remove decl.
85 (debug_output_compilation_hack): Mark as externally visible.
86
adddb265
PE
87 * sysdep.c (croak): Move decl from here to syssignal.h.
88 * syssignal.h (croak): Put it here, so the API can be checked when
89 'croak' is called from dissociate_if_controlling_tty.
90
1717ede2
PE
91 * minibuf.c: Make symbols static if they're not exported.
92 (minibuf_save_list, choose_minibuf_frame): Now static.
93 * lisp.h (choose_minibuf_frame): Remove decl.
94
fa5fb2bc
PE
95 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
96
1e3890d1
PE
97 * lread.c: Make symbols static if they're not exported.
98 (read_objects, initial_obarray, oblookup_last_bucket_number):
99 Now static.
100 (make_symbol): Remove; unused.
101 * lisp.h (initial_obarray, make_symbol): Remove decls.
102
8a1414fa
PE
103 * keyboard.c: Make symbols static if they're not exported.
104 (single_kboard, recent_keys_index, total_keys, recent_keys):
105 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
106 (this_single_command_key_start, echoing, last_auto_save):
107 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
108 (command_loop, echo_now, keyboard_init_hook, help_char_p):
109 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
110 (Vlispy_mouse_stem, double_click_count):
111 Now static.
112 (force_auto_save_soon): Define only if SIGDANGER.
113 (ignore_mouse_drag_p): Now static if
114 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
115 (print_help): Remove; unused.
116 (stop_character, last_timer_event): Mark as externally visible.
117 * keyboard.h (ignore_mouse_drag_p): Declare only if
118 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
119 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
120 * lisp.h (echoing): Remove decl.
121 (force_auto_save_soon): Declare only if SIGDANGER.
122 * xdisp.c (redisplay_window): Simplify code, to make it more
123 obvious that ignore_mouse_drag_p is not accessed if !defined
124 USE_GTK && !defined HAVE_NS.
125
93ea6e8f
PE
126 * intervals.c: Make symbols static if they're not exported.
127 (merge_properties_sticky, merge_interval_right, delete_interval):
128 Now static.
129 * intervals.h (merge_interval_right, delete_interval): Remove decls.
130
b532497d
PE
1312011-04-13 Paul Eggert <eggert@cs.ucla.edu>
132
77382fcc
PE
133 * insdel.c: Make symbols static if they're not exported.
134 However, leave prepare_to_modify_buffer alone. It's never
135 called from outside this function, but that appears to be a bug.
136 (combine_after_change_list, combine_after_change_buffer):
4889fc82 137 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
138 (adjust_after_replace_noundo): Remove; unused.
139 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 140 (signal_before_change): Remove decls.
77382fcc 141
9306c32e
PE
142 * indent.c (val_compute_motion, val_vmotion): Now static.
143
cd44d2eb
PE
144 * image.c: Make symbols static if they're not exported.
145 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
146 if USE_GTK.
147 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
148 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
149
ad9a7a06
PE
150 * fringe.c (standard_bitmaps): Now static.
151 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
152
81626931
PE
153 * frame.c: Make symbols static if they're not exported.
154 (x_report_frame_params, make_terminal_frame): Now static.
155 (get_frame_param): Now static, unless HAVE_NS.
156 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
157 (x_get_resource_string): Remove; not used.
158 * frame.h (make_terminal_frame, x_report_frame_params):
159 (x_get_resource_string); Remove decls.
160 (x_fullscreen_adjust): Declare only if WINDOWSNT.
161 * lisp.h (get_frame_param): Declare only if HAVE_NS.
162
239f9db9
PE
163 * font.c, fontset.c: Make symbols static if they're not exported.
164 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
165 (FACE_SUITABLE_FOR_CHAR_P): Use it.
166 * font.c (font_close_object): Now static.
167 * font.h (font_close_object): Remove.
168 * fontset.c (FONTSET_OBJLIST): Remove.
169 (free_realized_fontset) #if-0 the body, which does nothing.
170 (face_suitable_for_char_p): #if-0, as it's never called.
171 * fontset.h (face_suitable_for_char_p): Remove decl.
172 * xfaces.c (face_at_string_position): Use
173 FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
174 since 0 is always ASCII.
175
dfcf3579
PE
176 * fns.c (weak_hash_tables): Now static.
177
5045092b
PE
178 * fileio.c: Make symbols static if they're not exported.
179 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
180 (Vwrite_region_annotation_buffers): Now static.
181
57a96f5c
PE
182 * eval.c: Make symbols static if they're not exported.
183 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
184 * lisp.h (backtrace_list): Remove decl.
185
35f08c38
PE
186 * emacs.c: Make symbols static if they're not exported.
187 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
188 (fatal_error_code, fatal_error_signal_hook, standard_args):
189 Now static.
190 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
191 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
192 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
193 * lisp.h (fatal_error_signal_hook): Remove decl.
194 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
195
f44bd759
PE
196 * editfns.c: Move a (normally-unused) function to its only use.
197 * editfns.c, lisp.h (get_operating_system_release): Remove.
198 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
199 worth the hassle of breaking this out.
200
b532497d
PE
201 * xterm.c: Make symbols static if they're not exported.
202 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
203 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
204 (x_destroy_window, x_delete_display):
205 Now static.
206 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
207 (x_mouse_leave): Remove; unused.
208 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
209 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
210 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
211 Remove decls.
212 (x_mouse_leave): Declare only if WINDOWSNT.
213 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
214 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
215 USE_X_TOOLKIT.
216
a25f4dfa
PE
2172011-04-12 Paul Eggert <eggert@cs.ucla.edu>
218
1675728f
PE
219 * ftxfont.c: Make symbols static if they're not exported.
220 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
221 HAVE_FREETYPE.
222 * font.h (ftxfont_driver): Likewise.
223
e4cebfca
PE
224 * xfns.c: Make symbols static if they're not exported.
225 (x_last_font_name, x_display_info_for_name):
226 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
227 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
228 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
229 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
230 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
231 (last_show_tip_args): Now static.
232 (xic_defaut_fontset, xic_create_fontsetname): Define only if
233 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
234 (x_screen_planes): Remove; unused.
235 * dispextern.h (x_screen_planes): Remove decl.
236
5bf46f05
PE
237 * dispnew.c: Make symbols static if they're not exported.
238 * dispextern.h (redraw_garbaged_frames, scrolling):
239 (increment_row_positions): Remove.
240 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
241 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
242 Now static.
243 (redraw_garbaged_frames): Remove; unused.
244
435f4c28
PE
245 * xfaces.c: Make symbols static if they're not exported.
246 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
247 Remove decls.
248 * xterm.h (defined_color): Remove decls.
249 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
250 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
251 (menu_face_changed_default, defined_color, free_realized_face):
252 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
253 (ascii_face_of_lisp_face): Remove; unused.
254
8524aef3
PE
255 * xdisp.c: Make symbols static if they're not exported.
256 * dispextern.h (scratch_glyph_row, window_box_edges):
257 (glyph_to_pixel_coords, set_cursor_from_row):
258 (get_next_display_element, set_iterator_to_next):
259 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
260 (show_mouse_face): Remove decls
261 * frame.h (message_buf_print): Likewise.
262 * lisp.h (pop_message, set_message, check_point_in_composition):
263 Likewise.
264 * xterm.h (set_vertical_scroll_bar): Likewise.
265 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
266 (message_buf_print, scratch_glyph_row, displayed_buffer):
267 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
268 (get_next_display_element, show_mouse_face, window_box_edges):
269 (frame_to_window_pixel_xy, check_point_in_composition):
270 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
271 (glyph_to_pixel_coords): Remove; unused.
272
16390cd2
PE
273 * dired.c (file_name_completion): Now static.
274
275 * dbusbind.c (xd_in_read_queued_messages): Now static.
276
a25f4dfa
PE
277 * lisp.h (circular_list_error, FOREACH): Remove; unused.
278 * data.c (circular_list_error): Remove.
279
16a97296
PE
2802011-04-11 Paul Eggert <eggert@cs.ucla.edu>
281
14a9c8df
PE
282 * commands.h (last_point_position, last_point_position_buffer):
283 (last_point_position_window): Remove decls.
284 * keyboard.c: Make these variables static.
285
74ab6df5
PE
286 * coding.h (coding, code_convert_region, encode_coding_gap): Remove
287 decls.
288 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
289 (iso_code_class, detect_coding, code_convert_region): Now static.
290 (encode_coding_gap): Remove; unused.
291
38dfbee1
PE
292 * chartab.c (chartab_chars, chartab_bits): Now static.
293
a2cb4e63
PE
294 * charset.h (charset_iso_8859_1): Remove decl.
295 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
296 Now static.
297
127198fd
PE
298 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
299 * ccl.c (Vccl_program_table): Now static.
300 (check_ccl_update): Remove; unused.
301
d85b608f
PE
302 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
303 * category.h: ... from here.
304 * category.c (check_category_table, set_category_set): Now static.
305
31cd66f3
PE
306 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
307 * lisp.h: Remove these decls.
308
c358e587
PE
309 * buffer.c (buffer_count): Remove unused var.
310
e78aecca
PE
311 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
312 so that it's not optimized away.
313 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
314 * dispextern.h (bidi_dump_cached_states): Remove, since it's
315 exported only to the debugger.
316
e192d7d3
PE
317 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
318 * atimer.h (run_all_atimers): Removed; not exported.
319
92470028
PE
320 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
321 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
322 was inaccessible from Lisp.
323 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
324 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
325
244ed907
PE
326 alloc.c: Import and export fewer symbols, and remove unused items.
327 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
328 is defined.
329 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
330 it's not optimized away by whole-program optimization.
331 (message_enable_multibyte, free_misc): Remove.
332 (catchlist, handlerlist, mark_backtrace):
333 Declare only if BYTE_MARK_STACK.
334 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
335 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
336 (message_enable_multibyte): Remove decl.
337 (free_misc, interval_free_list, float_block, float_block_index):
338 (n_float_blocks, float_free_list, cons_block, cons_block_index):
339 (cons_free_list, last_marked_index):
340 Now static.
341 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
342 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
343 (mark_backtrace): Define only if BYTE_MARK_STACK.
344 * xdisp.c (message_enable_multibyte): Now static.
345
955cbe7b
PE
346 Declare Lisp_Object Q* variables to be 'static' if not exproted.
347 This makes it easier for human readers (and static analyzers)
348 to see whether these variables are used from other modules.
349 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
350 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
351 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
352 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
353 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
354 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
355 * xmenu.c, xselect.c:
356 Declare Q* vars static if they are not used in other modules.
357 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
358 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
359 Remove decls of unexported vars.
360 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
361
95c82688
PE
362 * lisp.h (DEFINE_FUNC): Make sname 'static'.
363
16a97296
PE
364 Make Emacs functions such as Fatom 'static' by default.
365 This makes it easier for human readers (and static analyzers)
366 to see whether these functions can be called from other modules.
367 DEFUN now defines a static function. To make the function external
368 so that it can be used in other C modules, use the new macro DEFUE.
369 * lisp.h (DEFINE_FUNC): New macro, with the old contents of DEFUN.
370 (DEFUN): Rewrite in terms of DEFINE_FUNC. It now generates a
371 static function definition. Use DEFUE if you want an extern one.
372 (DEFUE, INFUN): New macros.
373 (Funibyte_char_to_multibyte, Fsyntax_table_p, Finit_image_library):
374 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
375 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
376 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
377 Remove decls, since these functions are now static.
378 (Funintern, Fget_internal_run_time): New decls, since these functions
379 were already external.
95c82688 380
16a97296
PE
381 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
382 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
383 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
384 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
385 * keyboard.c, keymap.c, lread.c:
386 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
387 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
388 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
389 Mark functions with DEFUE instead of DEFUN,
390 if they are used in other modules.
391 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
392 decls for now-static functions.
393 * buffer.h (Fdelete_overlay): Remove decl.
394 * callproc.c (Fgetenv_internal): Mark as internal.
395 * composite.c (Fremove_list_of_text_properties): Remove decl.
396 (Fcomposition_get_gstring): New forward static decl.
397 * composite.h (Fcomposite_get_gstring): Remove decl.
398 * dired.c (Ffile_attributes): New forward static decl.
399 * doc.c (Fdocumntation_property): New forward static decl.
400 * eval.c (Ffetch_bytecode): New forward static decl.
401 (Funintern): Remove extern decl; now in .h file where it belongs.
402 * fileio.c (Fmake_symbolic_link): New forward static decl.
403 * image.c (Finit_image_library): New forward static decl.
404 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
405 * intervals.h (Fprevious_property_change):
406 (Fremove_list_of_text_properties): Remove decls.
407 * keyboard.c (Fthis_command_keys): Remove decl.
408 (Fcommand_execute): New forward static decl.
409 * keymap.c (Flookup_key): New forward static decl.
410 (Fcopy_keymap): Now static.
411 * keymap.h (Flookup_key): Remove decl.
412 * process.c (Fget_process): New forward static decl.
413 (Fprocess_datagram_address): Mark as internal.
414 * syntax.c (Fsyntax_table_p): New forward static decl.
415 (skip_chars): Remove duplicate decl.
416 * textprop.c (Fprevious_property_change): New forward static decl.
417 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
418 Now internal.
419 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
420 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
421
785bbd42
PE
4222011-04-10 Paul Eggert <eggert@cs.ucla.edu>
423
424 * editfns.c (Fformat): Remove unreachable code.
425
4073e537 4262011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 427
b2ded58d
PE
428 Fix more problems found by GCC 4.6.0's static checks.
429
7d66342c
PE
430 * xdisp.c (vmessage): Use a better test for character truncation.
431
bbf47d44
PE
432 * charset.c (load_charset_map): <, not <=, for optimization,
433 and to avoid potential problems with integer overflow.
9248994d 434 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 435 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 436 * editfns.c (Fformat): Likewise.
1e69125e 437 * syntax.c (skip_chars): Likewise.
3befa583 438
e3019616
PE
439 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
440 This also lets GCC 4.6.0 generate slightly better loop code.
441
becfa255
PE
442 * callint.c (Fcall_interactively): <, not <=, for optimization.
443 (Fcall_interactively): Count the number of arguments produced,
444 not the number of arguments given. This is simpler and lets GCC
445 4.6.0 generate slightly better code.
446
dae0cd48
PE
447 * ftfont.c: Distingish more carefully between FcChar8 and char.
448 The previous code passed unsigned char * to a functions like
449 strlen and xstrcasecmp that expect char *, which does not
450 conform to the C standard.
451 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
452 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
453 char * when the C standard requires it.
454
76032d70
PE
455 * keyboard.c (read_char): Remove unused var.
456
eb3f1cc8
PE
457 * eval.c: Port to Windows vsnprintf (Bug#8435).
458 Include <limits.h>.
459 (SIZE_MAX): Define if the headers do not.
460 (verror): Do not give up if vsnprintf returns a negative count.
461 Instead, grow the buffer. This ports to Windows vsnprintf, which
462 does not conform to C99. Problem reported by Eli Zaretskii.
463 Also, simplify the allocation scheme, by avoiding the need for
464 calling realloc, and removing the ALLOCATED variable.
465
70476b54
PE
466 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
467
12020a9e
PE
468 Remove invocations of doprnt, as Emacs now uses vsnprintf.
469 But keep the doprint source code for now, as we might revamp it
470 and use it again (Bug#8435).
ea6c7ae6
PE
471 * lisp.h (doprnt): Remove.
472 * Makefile.in (base_obj): Remove doprnt.o.
473 * deps.mk (doprnt.o): Remove.
474
5fdb398c
PE
475 error: Print 32- and 64-bit integers portably (Bug#8435).
476 Without this change, on typical 64-bit hosts error ("...%d...", N)
477 was used to print both 32- and 64-bit integers N, which relied on
478 undefined behavior.
479 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
480 New macro.
481 * lisp.h (error, verror): Mark as printf-like functions.
482 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
483 Report overflow in size calculations when allocating printf buffer.
484 Do not truncate output string at its first null byte.
485 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
486 Truncate the output at a character boundary, since vsnprintf does not
487 do that.
488 * charset.c (check_iso_charset_parameter): Convert internal
489 character to string before calling 'error', since %c now has the
490 printf meaning.
491 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
492 overflow when computing char to be passed to 'error'. Do not
493 pass Lisp_Object to 'error'; pass the integer instead.
494 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
495 formatted with plain %d.
496
b189fa66
PE
497 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
498
bff87ef0
PE
499 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
500
7e2cac20
PE
501 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
502
ce4d90b5
PE
503 * xterm.c (x_catch_errors): Remove duplicate declaration.
504
266c9547
PE
505 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
506
79c49ad2
PE
507 * xdisp.c, lisp.h (message_nolog): Remove; unused.
508
368f4090
JM
5092011-04-10 Jim Meyering <meyering@redhat.com>
510
511 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
512 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
513 return ssize_t not "int", and use size_t as the buffer length.
514 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
515 * gnutls.h: Update declarations.
516 * process.c (read_process_output): Use ssize_t, to match.
517 (send_process): Likewise.
518
a32d4040
CY
5192011-04-09 Chong Yidong <cyd@stupidchicken.com>
520
521 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
522
8546720e 5232011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 524
8546720e
GM
525 * ftfont.c (get_adstyle_property, ftfont_pattern_entity): Use
526 unsigned char, to match FcChar8 type definition.
aac0c6e3 527
8546720e
GM
528 * xterm.c (handle_one_xevent):
529 * xmenu.c (create_and_show_popup_menu):
530 * xselect.c (x_decline_selection_request)
531 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 532
a53e2e89
EZ
5332011-04-09 Eli Zaretskii <eliz@emacstest.gnu.org>
534
535 Fix some uses of `int' instead of EMACS_INT.
536 * search.c (string_match_1, fast_string_match)
537 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
538 (scan_buffer, find_next_newline_no_quit)
539 (find_before_next_newline, search_command, Freplace_match)
540 (Fmatch_data): Make some `int' variables be EMACS_INT.
541
542 * xdisp.c (display_count_lines): 3rd argument and return value now
543 EMACS_INT. All callers changed.
544 (pint2hrstr): Last argument is now EMACS_INT.
545
546 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
547 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
548 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
549 (decode_coding_utf_16, decode_coding_emacs_mule)
550 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
551 (decode_coding_ccl, decode_coding_charset)
552 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
553 (decode_coding_iso_2022, decode_coding_emacs_mule)
554 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
555 <char_offset, last_offset>: Declare EMACS_INT.
556 (encode_coding_utf_8, encode_coding_utf_16)
557 (encode_coding_emacs_mule, encode_invocation_designation)
558 (encode_designation_at_bol, encode_coding_iso_2022)
559 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
560 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
561 Declare EMACS_INT.
562 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
563 (encode_invocation_designation): Last argument P_NCHARS is now
564 EMACS_INT.
565 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
566 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
567
568 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
569 All users changed.
570
571 * ccl.c (Fccl_execute_on_string): Declare some variables
572 EMACS_INT.
573
8546720e 5742011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
575
576 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
577
4e19a977
CS
5782011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
579
580 * process.c (Fformat_network_address): Doc fix.
581
87302331
R
5822011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
583
584 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
585
cbb59342
CY
5862011-04-08 Chong Yidong <cyd@stupidchicken.com>
587
588 * keyboard.c (read_char): Call Lisp function help-form-show,
589 instead of using internal_with_output_to_temp_buffer.
590 (Qhelp_form_show): New var.
e0d38eeb 591 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
592
593 * print.c (internal_with_output_to_temp_buffer): Function deleted.
594
595 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
596
e67a13ab
CY
5972011-04-06 Chong Yidong <cyd@stupidchicken.com>
598
599 * process.c (Flist_processes): Removed to Lisp.
600 (list_processes_1): Deleted.
601
973f782d
EZ
6022011-04-06 Eli Zaretskii <eliz@gnu.org>
603
7c106b1e
EZ
604 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
605
973f782d
EZ
606 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
607
41cf7d1a 6082011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 609
ca23cc88
PE
610 Fix more problems found by GCC 4.6.0's static checks.
611
f390e2d5
PE
612 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
613
42eea0d0
PE
614 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
615
b69769da 616 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 617
f9541e84
PE
618 * xdisp.c (vmessage): Mark as a printf-like function.
619
13841b55
PE
620 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
621
c136c10f
PE
622 * sound.c (sound_warning): Don't crash if arg contains a printf format.
623
5e2d4a30
PE
624 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
625 printf-like functions.
626 (tiff_load): Add casts to remove these marks before passing them
627 to system-supplied API.
628
583f48b9
PE
629 * eval.c (Fsignal): Remove excess argument to 'fatal'.
630
b25d760e
PE
631 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
632 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
633 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
634 directly, rather than having caller test rule sign. This avoids
635 some unnecessary tests.
636 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
637 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
638 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 639
bc7b6697 640 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 641 (xfont_open): Avoid unnecessary tests.
bc7b6697 642
27ccc379
PE
643 * composite.c (composition_gstring_put_cache): Use unsigned integer.
644
dcd5c89a
PE
645 * composite.h, composite.c (composition_gstring_put_cache):
646 Use EMACS_INT, not int, for length.
647
b13a45c6
PE
648 * composite.h (COMPOSITION_DECODE_REFS): New macro,
649 breaking out part of COMPOSITION_DECODE_RULE.
650 (COMPOSITION_DECODE_RULE): Use it.
651 * composite.c (get_composition_id): Remove unused local vars,
652 by using the new macro.
653
1e792e4d
PE
654 * textprop.c (set_text_properties_1): Change while to do-while,
655 since the condition is always true at first.
656
dc6c6455 657 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
658 (interval_deletion_adjustment): Return unsigned value.
659 All uses changed.
dc6c6455 660
aba7731a
PE
661 * process.c (list_processes_1, create_pty, read_process_output):
662 (exec_sentinel): Remove vars that were set but not used.
afd4052b 663 (create_pty): Remove unnecessary "volatile"s.
bc57d757 664 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 665 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 666 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 667
fdfc4bf3
PE
668 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
669
fca8fe46 670 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 671 (update_syntax_table): Use unsigned instead of int.
fca8fe46 672
06a0259a 673 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 674 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 675 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 676
e7b9e80f
PE
677 * print.c (print_error_message): Avoid int overflow.
678
56201685
PE
679 * font.c (font_list_entities): Redo for clarity,
680 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
681
78834453 682 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 683 (font_score): Avoid potential overflow in diff calculation.
78834453 684
0bc0b309 685 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 686 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 687
e610eaca
PE
688 * eval.c (funcall_lambda): Rename local to avoid shadowing.
689
b895abce
PE
690 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
691 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
692 can always succeed if overflow has undefined behavior.
693
1f1d9321 694 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 695 (wordify): Omit three unnecessary tests.
1f1d9321 696
c59478bc
PE
697 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
698 All callers changed. This avoids the need for an unused var.
699
79b73827
PE
700 * casefiddle.c (casify_region): Remove var that is set but not used.
701
a4db5dfe
PE
702 * dired.c (file_name_completion): Remove var that is set but not used.
703
43aae36e
PE
704 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
705
2a47c44d 706 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 707 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 708
a37c69bf
PE
709 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
710 Check for integer overflow on size calculations.
711
328ab8e7
PE
712 * buffer.c (Fprevious_overlay_change): Remove var that is set
713 but not used.
714
e5a2a5cb
PE
715 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
716 Remove vars that are set but not used.
8d84a6eb 717 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 718 (timer_check_2): Mark vars as initialized.
e5a2a5cb 719
a60e5f68
PE
720 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
721
f661cb61 722 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 723 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 724
f0397f5a
PE
725 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
726 that are set but not used.
727
8664db06 728 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 729 if XCreateBitmapFromData fails (Bug#8410).
8664db06 730
6abdaa4a
PE
731 * xselect.c (x_get_local_selection, x_handle_property_notify):
732 Remove vars that are set but not used.
733
0ce7538d 734 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 735 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 736
9ae848fc
PE
737 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
738 Remove var that is set but not used.
0b918413
PE
739 (scroll_bar_windows_size): Now size_t, not int.
740 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
741 Check for overflow.
9ae848fc 742
a5a62657
PE
743 * xfaces.c (realize_named_face): Remove vars that are set but not used.
744 (map_tty_color) [!defined MSDOS]: Likewise.
745
5c5cdd39
PE
746 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
747
66ebf983
PE
748 * coding.c: Remove vars that are set but not used.
749 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
750 All callers changed.
751 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
752 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
753 (decode_coding_charset): Remove vars that are set but not used.
754
1be4d761
PE
755 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
756 that is set but not used.
757
47553fa8
PE
758 * print.c (print_object): Remove var that is set but not used.
759
1f7196bf 760 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
761 The gnulib version avoids calling malloc in the usual case,
762 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
763 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
764 * filelock.c (current_lock_owner): Likewise.
765 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
766 * sysdep.c: Include allocator.h, careadlinkat.h.
767 (emacs_no_realloc_allocator): New static constant.
768 (emacs_readlink): New function.
fdb61804
PE
769 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
770 ../lib/careadlinkat.h.
d1fdcab7 771
f84c17c7
SM
7722011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
773
774 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
775 first non-nil return value).
776
ef3862ad
JD
7772011-04-03 Jan Djärv <jan.h.d@swipnet.se>
778
779 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
780 if not defined (Bug#8403).
781
376a7006
JB
7822011-04-02 Juanma Barranquero <lekktu@gmail.com>
783
784 * xdisp.c (display_count_lines): Remove parameter `start',
785 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
786 (get_char_face_and_encoding): Remove parameter `multibyte_p',
787 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
788 (fill_stretch_glyph_string): Remove parameters `row' and `area',
789 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
790 and thereabouts. All callers changed.
791 (get_per_char_metric): Remove parameter `f', unused since
792 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
793
6ca3801d
JM
7942011-04-02 Jim Meyering <meyering@redhat.com>
795
796 do not dereference NULL upon failed strdup
797 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
798 (ns_get_family): Likewise.
799
d8e2b5ba
JB
8002011-04-02 Juanma Barranquero <lekktu@gmail.com>
801
802 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
803
8c74fcbd
JD
8042011-04-02 Jan Djärv <jan.h.d@swipnet.se>
805
806 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
807 later (Bug#8403).
808
7200d79c
SM
8092011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
810
03408648 811 Add lexical binding.
7200d79c 812
03408648
SM
813 * window.c (Ftemp_output_buffer_show): New fun.
814 (Fsave_window_excursion):
815 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
816
817 * lread.c (lisp_file_lexically_bound_p): New function.
818 (Fload): Bind Qlexical_binding.
819 (readevalloop): Remove `evalfun' arg.
820 Bind Qinternal_interpreter_environment.
821 (Feval_buffer): Bind Qlexical_binding.
822 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
823 Mark as dynamic.
824 (syms_of_lread): Declare `lexical-binding'.
825
826 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
827
828 * keyboard.c (eval_dyn): New fun.
829 (menu_item_eval_property): Use it.
ca105506
SM
830
831 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 832
03408648
SM
833 * fns.c (concat, mapcar1): Accept byte-code-functions.
834
835 * eval.c (Fsetq): Handle lexical vars.
836 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
837 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
838 (FletX, Flet): Obey lexical binding.
839 (Fcommandp): Handle closures.
840 (Feval): New `lexical' arg.
841 (eval_sub): New function extracted from Feval. Use it almost
842 everywhere where Feval was used. Look up vars in lexical env.
843 Handle closures.
844 (Ffunctionp): Move from subr.el.
845 (Ffuncall): Handle closures.
846 (apply_lambda): Remove `eval_flags'.
847 (funcall_lambda): Handle closures and new byte-code-functions.
848 (Fspecial_variable_p): New function.
849 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
850 but without exporting it to Lisp.
23aba0ea 851
23aba0ea 852 * doc.c (Fdocumentation, store_function_docstring):
03408648 853 * data.c (Finteractive_form): Handle closures.
23aba0ea 854
03408648
SM
855 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
856 interactive spec.
ba83908c 857
03408648
SM
858 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN): New
859 byte-codes.
860 (exec_byte_code): New function extracted from Fbyte_code to handle new
861 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 862
03408648 863 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 864
03408648 865 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 866
e2abce01
JB
8672011-03-31 Juanma Barranquero <lekktu@gmail.com>
868
869 * xdisp.c (redisplay_internal): Fix prototype.
870
63696a73 8712011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 872
63696a73
EZ
873 * xdisp.c (SCROLL_LIMIT): New macro.
874 (try_scrolling): Use it when setting scroll_limit. Limit
875 scrolling to 100 screen lines.
876 (redisplay_window): Even when falling back on "recentering",
877 position point in the window according to scroll-conservatively,
878 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
879
880 (try_scrolling): When point is above the window, allow searching
881 as far as scroll_max, or one screenful, to compute vertical
882 distance from PT to the scroll margin position. This prevents
883 try_scrolling from unnecessarily failing when
884 scroll-conservatively is set to a value slightly larger than the
885 window height. Clean up the case of PT below the margin at bottom
886 of window: scroll_max can no longer be INT_MAX. When aggressive
887 scrolling is in use, don't let point enter the opposite scroll
888 margin as result of the scroll.
889 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
890 threshold of 100 lines for never-recentering scrolling.
891
e4cc2dfc
JB
8922011-03-31 Juanma Barranquero <lekktu@gmail.com>
893
894 * dispextern.h (move_it_by_lines):
895 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
896 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
897 (message_log_check_duplicate): Remove parameters `prev_bol' and
898 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
899 (redisplay_internal): Remove parameter `preserve_echo_area',
900 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
901
902 * indent.c (Fvertical_motion):
903 * window.c (window_scroll_pixel_based, Frecenter):
904 Don't pass `need_y_p' to `move_it_by_lines'.
905
1c470562
SM
9062011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
907
44f230aa
SM
908 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
909 steal a few bits to be more compact.
910 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
911 Remove unneeded casts.
912
1c470562
SM
913 * bytecode.c (Fbyte_code): CAR and CDR can GC.
914
888adce9
ZK
9152011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
916
917 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
918 binding" message (bug#7967).
919
f838ed7b
PE
9202011-03-30 Paul Eggert <eggert@cs.ucla.edu>
921
77861b95
PE
922 Fix more problems found by GCC 4.6.0's static checks.
923
de6dbc14
PE
924 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
925 Remove unused local var.
926
f838ed7b
PE
927 * editfns.c (Fmessage_box): Remove unused local var.
928
792c7b2b
PE
929 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
930 (note_mode_line_or_margin_highlight, note_mouse_highlight):
931 Omit unused local vars.
c499e557 932 * window.c (shrink_windows): Omit unused local var.
b01a1c29 933 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
934 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
935 Omit unused local var.
936
ba0165e1
PE
937 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
938 Don't assume string length fits in int.
32ad8845 939 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 940 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 941
3c59b4c9
PE
942 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
943 instead of alloca (Bug#8344).
944
a3eed478 945 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 946 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 947
eb4d412d
PE
948 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
949
1658b401
PE
950 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
951 concerns.
952
953 * term.c (produce_glyphless_glyph): Remove unnecessary test.
954
955 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 956
9a2c6e05
PE
957 * keyboard.c (syms_of_keyboard): Use the same style as later
958 in this function when indexing through an array. This also
959 works around GCC bug 48267.
960
03d0a109
PE
961 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
962
44f730c8
PE
963 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
964
fe75f926
PE
965 * chartab.c (sub_char_table_ref_and_range): Redo for slight
966 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
967
ffa8c828
PE
968 * keyboard.c, keyboard.h (num_input_events): Now size_t.
969 This avoids undefined behavior on integer overflow, and is a bit
970 more convenient anyway since it is compared to a size_t variable.
971
c5101a77
PE
972 Variadic C functions now count arguments with size_t, not int.
973 This avoids an unnecessary limitation on 64-bit machines, which
974 caused (substring ...) to crash on large vectors (Bug#8344).
975 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
976 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 977 All variadic functions and their callers changed accordingly.
c5101a77
PE
978 (struct gcpro.nvars): Now size_t, not int. All uses changed.
979 * data.c (arith_driver, float_arith_driver): Likewise.
980 * editfns.c (general_insert_function): Likewise.
981 * eval.c (struct backtrace.nargs, interactive_p)
982 (internal_condition_case_n, run_hook_with_args, apply_lambda)
983 (funcall_lambda, mark_backtrace): Likewise.
984 * fns.c (concat): Likewise.
985 * frame.c (x_set_frame_parameters): Likewise.
986 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
987 0 if not found, not -1. All callers changed.
988
dd3f25f7
PE
989 * alloc.c (garbage_collect): Don't assume stack size fits in int.
990 (stack_copy_size): Now size_t, not int.
991 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
992
461c2ab9
JB
9932011-03-28 Juanma Barranquero <lekktu@gmail.com>
994
995 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
996 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
997 All callers changed.
998
999 * lisp.h (multibyte_char_to_unibyte):
1000 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
1001 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
1002 * character.h (CHAR_TO_BYTE8):
1003 * cmds.c (internal_self_insert):
1004 * editfns.c (general_insert_function):
1005 * keymap.c (push_key_description):
1006 * search.c (Freplace_match):
1007 * xdisp.c (message_dolog, set_message_1): All callers changed.
1008
f6d62986
SM
10092011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
1010
1011 * keyboard.c (safe_run_hook_funcall): New function.
1012 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
1013 don't set the hook to nil, but remove the offending function instead.
1014 (Qcommand_hook_internal): Remove, unused.
1015 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
1016 Vcommand_hook_internal.
1017
1018 * eval.c (enum run_hooks_condition): Remove.
1019 (funcall_nil, funcall_not): New functions.
1020 (run_hook_with_args): Call each function through a `funcall' argument.
1021 Remove `cond' argument, now redundant.
1022 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
1023 (Frun_hook_with_args_until_failure): Adjust accordingly.
1024 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
1025
1db5b1ad
JB
10262011-03-28 Juanma Barranquero <lekktu@gmail.com>
1027
1028 * dispextern.h (string_buffer_position): Remove declaration.
1029
1030 * print.c (strout): Remove parameter `multibyte', unused since
1031 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
1032
1033 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
1034 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
1035 All callers changed.
1036
1037 * w32.c (_wsa_errlist): Use braces for struct initializers.
1038
1039 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
1040 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
1041 All callers changed.
1042 (string_buffer_position): Likewise. Also, make static (it's never
1043 used outside xdisp.c).
1044 (cursor_row_p): Remove parameter `w', unused since
1045 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
1046 (decode_mode_spec): Remove parameter `precision', introduced during
1047 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
1048 All callers changed.
1049
5ffb62aa
JD
10502011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1051
1052 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
1053
461c2ab9 10542011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
1055
1056 * nsterm.m (ns_menu_bar_is_hidden): New variable.
1057 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
1058 (ns_update_auto_hide_menu_bar): New functions.
1059 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
1060 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
1061 ns_constrain_all_frames.
1062 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
1063 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
1064
5c380ffb
JD
10652011-03-27 Jan Djärv <jan.h.d@swipnet.se>
1066
1067 * nsmenu.m (runDialogAt): Remove argument to timer_check.
1068
9af30bdf
GM
10692011-03-27 Glenn Morris <rgm@gnu.org>
1070
1071 * syssignal.h: Replace RETSIGTYPE with void.
1072 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
1073 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
1074 Replace SIGTYPE with void everywhere.
1075 * s/usg5-4-common.h (SIGTYPE): Remove definition.
1076 * s/template.h (SIGTYPE): Remove commented out definition.
1077
e2abce01
JB
10782011-03-26 Eli Zaretskii <eliz@gnu.org>
1079
1080 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
1081 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
1082
f868cd8a
JB
10832011-03-26 Juanma Barranquero <lekktu@gmail.com>
1084
59eb0929
JB
1085 * w32.c (read_unc_volume): Use parameter `henum', instead of
1086 global variable `wget_enum_handle'.
1087
1088 * keymap.c (describe_vector): Remove parameters `indices' and
1089 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
1090 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
1091
f868cd8a
JB
1092 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
1093
1094 * keyboard.c (timer_check): Remove parameter `do_it_now',
1095 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
1096 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
1097 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
1098
1099 * keyboard.c (read_char):
1100 * w32menu.c (w32_menu_display_help):
1101 * xmenu.c (show_help_event, menu_help_callback):
1102 Adjust calls to `show_help_echo'.
1103
1104 * gtkutil.c (xg_maybe_add_timer):
1105 * keyboard.c (readable_events):
1106 * process.c (wait_reading_process_output):
1107 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
1108
1109 * insdel.c (adjust_markers_gap_motion):
1110 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
1111 (gap_left, gap_right): Don't call it.
1112
2ecf6fdb
CY
11132011-03-25 Chong Yidong <cyd@stupidchicken.com>
1114
1115 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
1116 incurred during fontification.
1117
6b1f9ba4
JB
11182011-03-25 Juanma Barranquero <lekktu@gmail.com>
1119
1120 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
1121 (DEFVAR_PER_BUFFER): Don't pass it.
1122
1123 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
1124 (scrolling_window): Don't pass it.
1125
0f4a96b5
JB
11262011-03-25 Juanma Barranquero <lekktu@gmail.com>
1127
1128 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
1129
1130 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
1131 and `suffix'.
1132 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
1133 of variables specific to SELinux and computation of `encoded_absname'.
1134
1135 * image.c (XPutPixel): Remove unused variable `height'.
1136
1137 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
1138
1139 * unexw32.c (get_section_info): Remove unused variable `section'.
1140
1141 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
1142 (system_process_attributes): Remove unused variable `sess'.
1143 (sys_read): Remove unused variable `err'.
1144
1145 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
1146 (w32_wnd_proc): Remove unused variable `isdead'.
1147 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
1148 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
1149 (x_create_tip_frame): Remove unused variable `tem'.
1150
1151 * w32inevt.c (w32_console_read_socket):
1152 Remove unused variable `no_events'.
1153
1154 * w32term.c (x_draw_composite_glyph_string_foreground):
1155 Remove unused variable `width'.
1156
1149507c
JB
11572011-03-24 Juanma Barranquero <lekktu@gmail.com>
1158
1159 * w32term.c (x_set_glyph_string_clipping):
1160 Don't pass uninitialized region to CombineRgn.
1161
9c88f339
JB
11622011-03-23 Juanma Barranquero <lekktu@gmail.com>
1163
1164 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
1165 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
1166 (Fx_close_connection): Remove unused variable `i'.
1167
1168 * w32font.c (w32font_draw): Return number of glyphs.
1169 (w32font_open_internal): Remove unused variable `i'.
1170 (w32font_driver): Add missing initializer.
1171
1172 * w32menu.c (utf8to16): Remove unused variable `utf16'.
1173 (fill_in_menu): Remove unused variable `items_added'.
1174
1175 * w32term.c (last_mouse_press_frame): Remove static global variable.
1176 (w32_clip_to_row): Remove unused variable `f'.
1177 (x_delete_terminal): Remove unused variable `i'.
1178
1179 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
1180 (NOTHING): Remove unused static global variable.
1181 (uniscribe_check_otf): Remove unused variable `table'.
1182 (uniscribe_font_driver): Add missing initializers.
1183
dee091a3
JD
11842011-03-23 Julien Danjou <julien@danjou.info>
1185
1186 * term.c (Fsuspend_tty, Fresume_tty):
1187 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
1188 * window.c (temp_output_buffer_show):
1189 * insdel.c (signal_before_change):
1190 * frame.c (Fhandle_switch_frame):
1191 * fileio.c (Fdo_auto_save):
1192 * emacs.c (Fkill_emacs):
1193 * editfns.c (save_excursion_restore):
1194 * cmds.c (internal_self_insert):
1195 * callint.c (Fcall_interactively):
1196 * buffer.c (Fkill_all_local_variables):
1197 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
1198 Use Frun_hooks.
0f4a96b5 1199 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
1200 unconditionnaly since it does the check itself.
1201
2c520ab5 12022011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 1203
c9c49752
PE
1204 Fix more problems found by GCC 4.5.2's static checks.
1205
8abc3f12
PE
1206 * coding.c (encode_coding_raw_text): Avoid unnecessary test
1207 the first time through the loop, since we know p0 < p1 then.
1208 This also avoids a gcc -Wstrict-overflow warning.
1209
a2d26660
PE
1210 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
1211 leading to a memory leak, possible in functions like
1212 load_charset_map_from_file that can allocate an unbounded number
b12ef411 1213 of objects (Bug#8318).
a2d26660 1214
916c72e9
PE
1215 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
1216 that could (at least in theory) be that large.
1217
19ab8a18
PE
1218 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
1219 This is less likely to overflow, and avoids undefined behavior if
1220 overflow does occur. All callers changed. Use strtoul to scan
1221 for the unsigned long integer.
b7cbbd6f
PE
1222 (pint2hrstr): Simplify and tune code slightly.
1223 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 1224
f0641eff
PE
1225 * scroll.c (do_scrolling): Work around GCC bug 48228.
1226 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
1227
7f650bb9
PE
1228 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
1229 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
1230 (validate_x_resource_name): Simplify count usage.
1231 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 1232
37dd57d1
PE
1233 * fileio.c (Fcopy_file): Report error if fchown or fchmod
1234 fail (Bug#8306).
81e56e61 1235
699979fc 1236 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 1237
401bf9b4
PE
1238 * process.c (Fmake_network_process): Use socklen_t, not int,
1239 where POSIX says socklen_t is required in portable programs.
1240 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 1241 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
1242 (Fmake_network_process, server_accept_connection):
1243 (wait_reading_process_output, read_process_output):
1244 Likewise.
1245
b93aacde
PE
1246 * process.c: Rename or move locals to avoid shadowing.
1247 (list_processes_1, Fmake_network_process):
1248 (read_process_output_error_handler, exec_sentinel_error_handler):
1249 Rename or move locals.
4dc343ee 1250 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 1251 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 1252 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 1253 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 1254 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 1255
af8a867c 1256 Make tparam.h and terminfo.c consistent.
44f230aa
SM
1257 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
1258 Include tparam.h instead, since it declares them.
af8a867c
PE
1259 * cm.h (PC): Remove extern decl; tparam.h now does this.
1260 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
1261 * terminfo.c: Include tparam.h, to check interfaces.
1262 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
1263 (tparam): Adjust signature to match interface in tparam.h;
1264 this removes some undefined behavior. Check that outstring and len
1265 are zero, which they always are with Emacs.
1266 * tparam.h (PC, BC, UP): New extern decls.
1267
0248044d 1268 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 1269 (xftfont_open): Rename locals to avoid shadowing.
0248044d 1270
8ff096c1 1271 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
1272 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
1273 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 1274 (ftfont_list): Remove unused local.
49eaafba
PE
1275 (get_adstyle_property, ftfont_pattern_entity):
1276 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
1277 Rename locals to avoid shadowing.
8ff096c1 1278
e2be39f6
PE
1279 * xfont.c (xfont_list_family): Mark var as initialized.
1280
c9735e30
PE
1281 * xml.c (make_dom): Now static.
1282
8f5201ae
PE
1283 * composite.c (composition_compute_stop_pos): Rename local to
1284 avoid shadowing.
b246f932
PE
1285 (composition_reseat_it): Remove unused locals.
1286 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 1287 (composition_update_it): Mark var as initialized.
11b61122
PE
1288 (find_automatic_composition): Mark vars as initialized,
1289 with a FIXME (Bug#8290).
8f5201ae 1290
760fbc2c
PE
1291 character.h: Rename locals to avoid shadowing.
1292 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
1293 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
1294 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
1295 (BUF_DEC_POS): Be more systematic about renaming local temporaries
1296 to avoid shadowing.
1297
ff08eb85
PE
1298 * textprop.c (property_change_between_p): Remove; unused.
1299
fc7bf025
PE
1300 * intervals.c (interval_start_pos): Now static.
1301
235d7abc
PE
1302 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
1303
44f230aa
SM
1304 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
1305 Rename locals to avoid shadowing.
3e7d6594 1306
50060332
PE
1307 * sound.c (wav_play, au_play, Fplay_sound_internal):
1308 Fix pointer signedness.
d01f234b 1309 (alsa_choose_format): Remove unused local var.
c83b8872
PE
1310 (wav_play): Initialize a variable to 0, to prevent undefined
1311 behavior (Bug#8278).
50060332 1312
c4fc4e30
PE
1313 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
1314
918436ed
PE
1315 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
1316
c939f91b
PE
1317 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
1318 clobbering (Bug#8298).
b9c7f648
PE
1319 * sysdep.c (sys_subshell): Likewise.
1320 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 1321
6bd8c144
PE
1322 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
1323 This should get cleaned up, so that child_setup has the
1324 same signature on all platforms.
1325
7710357c 1326 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 1327 (relocate_fd): Rename locals to avoid shadowing.
7710357c 1328
c59da222
CY
13292011-03-22 Chong Yidong <cyd@stupidchicken.com>
1330
1331 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
1332 not to be necessary, and produces flickering.
1333
66b87493
GM
13342011-03-20 Glenn Morris <rgm@gnu.org>
1335
1336 * config.in: Remove file.
1337
45b6f6d5
JB
13382011-03-20 Juanma Barranquero <lekktu@gmail.com>
1339
1340 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
1341 are now in src/globals.h.
1342 (syms_of_minibuf): Remove spurious & from previous change.
1343
3ec03f7e
LL
13442011-03-20 Leo <sdl.web@gmail.com>
1345
1346 * minibuf.c (completing-read-function): New variable.
1347 (completing-read-default): Rename from completing-read.
1348 (completing-read): Call completing-read-function.
1349
b14e3e21
CY
13502011-03-19 Juanma Barranquero <lekktu@gmail.com>
1351
1352 * xfaces.c (Fx_load_color_file):
1353 Read color file from absolute filename (bug#8250).
1354
f2b726e6
JB
13552011-03-19 Juanma Barranquero <lekktu@gmail.com>
1356
1357 * makefile.w32-in: Update dependencies.
1358
09f6ff02
EZ
13592011-03-17 Eli Zaretskii <eliz@gnu.org>
1360
1361 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
1362
29a6015a
PE
13632011-03-17 Paul Eggert <eggert@cs.ucla.edu>
1364
a3a6c54e
PE
1365 Fix more problems found by GCC 4.5.2's static checks.
1366
b766f867
PE
1367 * process.c (make_serial_process_unwind, send_process_trap):
1368 (sigchld_handler): Now static.
1369
be02381c
PE
1370 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
1371 That way, the code declares only the vars that it needs.
1372 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
1373 * s/cygwin.h (PTY_ITERATION): Likewise.
1374 * s/darwin.h (PTY_ITERATION): Likewise.
1375 * s/gnu-linux.h (PTY_ITERATION): Likewise.
1376
57048744
PE
1377 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
1378 * process.c (allocate_pty): Don't declare stb unless it's needed.
1379
7914961c 1380 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
1381 (CONSTANTLIM): Remove; unused.
1382 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
1383 Define only if needed.
7914961c 1384
b3967b18
PE
1385 * unexelf.c (unexec): Name an expression,
1386 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
1387 Use a different way to cause a compilation error if anyone uses
1388 n rather than nn, a way that does not involve shadowing.
73366a00 1389 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 1390
29a6015a
PE
1391 * deps.mk (unexalpha.o): Remove; unused.
1392
43cfc33e 1393 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 1394 * unexec.h: New file.
ce701a33
PE
1395 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
1396 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
1397 Depend on unexec.h.
1398 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
1399 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
1400 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 1401 Change as necessary to match prototype in unexec.h.
ce701a33 1402
01f44d5a
PE
1403 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
1404 shadowing.
4f63c6bb 1405 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 1406
a6670b0b
PE
1407 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
1408 Rename locals to avoid shadowing.
1409
cef2010d 1410 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 1411 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 1412
d4d7173a
PE
1413 * print.c (Fredirect_debugging_output): Fix pointer signedess.
1414
f08b802a
PE
1415 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
1416 warning when compiling print.c.
1417
3ddb0639
PE
1418 * font.c (font_unparse_fcname): Abort in an "impossible" situation
1419 instead of using an uninitialized var.
5ad03b97 1420 (font_sort_entities): Mark var as initialized.
3ddb0639 1421
170a2692
PE
1422 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
1423
e663c700
PE
1424 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
1425 pointers to constants.
89bc529a 1426 (font_parse_fcname): Remove unused vars.
7b81e2d0 1427 (font_delete_unmatched): Now static.
ea838e10 1428 (font_get_spec): Remove; unused.
13a547c6
PE
1429 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
1430 (font_update_drivers, Ffont_get_glyphs, font_add_log):
1431 Rename or move locals to avoid shadowing.
e663c700 1432
2a80c887 1433 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 1434 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 1435
1384fa33 1436 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 1437 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 1438
8b2c52e9
PE
1439 * alloc.c (mark_backtrace): Move decl from here ...
1440 * lisp.h: ... to here, so that it can be checked.
1441
475545b5 1442 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 1443 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
1444 (lisp_indirect_variable): Name an expression,
1445 to avoid gcc -Wbad-function-cast warning.
1faed8ae 1446 (Fdefvar): Rename locals to avoid shadowing.
475545b5 1447
b1349114 1448 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 1449 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 1450 Use const pointer when appropriate.
b1349114 1451
a2928364
PE
1452 * lisp.h (get_system_name, get_operating_system_release):
1453 Move decls here, to check interfaces.
1454 * process.c (get_operating_system_release): Move decl to lisp.h.
1455 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
1456 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
1457 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
1458 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
1459 (Fformat_time_string, Fencode_time, Finsert_char):
1460 (Ftranslate_region_internal, Fformat):
1461 Rename or remove local vars to avoid shadowing.
9710023e 1462 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 1463
a415e694
PE
1464 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
1465 avoid shadowing.
1466
8ef4622d
PE
1467 * lisp.h (eassert): Check that the argument compiles, even if
1468 ENABLE_CHECKING is not defined.
1469
946f9a5b
PE
1470 * data.c (Findirect_variable): Name an expression, to avoid
1471 gcc -Wbad-function-cast warning.
112396d6 1472 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 1473 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
1474 (Fmake_variable_buffer_local, Fmake_local_variable):
1475 Mark variables as initialized.
52746918 1476 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 1477
e5aab7e7 1478 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
1479 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
1480 Rename locals to avoid shadowing.
dff45157
PE
1481 (mark_stack): Move local variables into the #ifdef region where
1482 they're used.
7bc26fdb
PE
1483 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
1484 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
1485 needed otherwise.
1486 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
1487 (GC_STRING_CHARS): Remove; not used.
d40d4be1 1488 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 1489
e5aab7e7
PE
1490 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
1491 avoids undefined behavior in theory.
1492
4da60324
PE
1493 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
1494
88043301
PE
1495 Use functions, not macros, for up- and down-casing (Bug#8254).
1496 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1497 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
1498 to use the following functions instead of these macros.
1499 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
1500 EMACS_INT, since callers assume the returned value fits in int.
1501 (upcase1): Likewise, for UPCASE_TABLE.
1502 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 1503 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 1504 the race-condition problem in the old DOWNCASE.
88043301 1505
19ed5445
PE
1506 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
1507 Rename locals to avoid shadowing.
1508 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
1509 (regex_compile, re_search_2, re_match_2_internal):
1510 Remove unused local vars.
952db0d7
PE
1511 (FREE_VAR): Rewrite so as not to use empty "else",
1512 which gcc can warn about.
da053e48 1513 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
1514 (RETALLOC_IF): Define only if needed.
1515 (WORDCHAR_P): Likewise. This one is never needed, but is used
1516 only in a comment talking about a compiler bug, so put inside
1517 the #if 0 of that comment.
1518 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
1519 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
1520 Remove; unused.
19ed5445 1521
1f3561e4 1522 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
1523 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
1524 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 1525
ded6f8f7
PE
1526 * search.c (simple_search): Remove unused var.
1527
dbd37a95
PE
1528 * dired.c (compile_pattern): Move decl from here ...
1529 * lisp.h: ... to here, so that it can be checked.
1530 (struct re_registers): New forward decl.
1531
7e47afad
PE
1532 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
1533
85f24f61
PE
1534 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
1535 All uses changed.
1536 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
1537 Rename locals to avoid shadowing.
5671df8f 1538 (Fvertical_motion): Mark locals as initialized.
85f24f61 1539
181aa2be 1540 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 1541 (casify_region): Mark local as initialized.
181aa2be 1542
930d429c
PE
1543 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
1544
7082eac6
PE
1545 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
1546 New macros, so that the caller can use some names other than
1547 gcpro1, gcpro2, etc.
1548 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
1549 of the new macros.
1550 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
1551 argument, for consistency with GCPRO2_VAR, etc: it is now the
1552 prefix of the variable, not the variable itself. All uses
1553 changed.
38b2c076
PE
1554 * dired.c (directory_files_internal, file_name_completion):
1555 Rename locals to avoid shadowing.
1556
15206ed9
PE
1557 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
1558 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
1559 dired.c's scmp function, had undefined behavior.
1560 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
1561 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
1562 * buffer.h: ... to here, because these macros use current_buffer,
1563 and the new implementation with inline functions needs to have
1564 current_buffer in scope now, rather than later when the macros
1565 are used.
1566 (downcase, upcase1): New static inline functions.
1567 (DOWNCASE, UPCASE1): Reimplement using these functions.
1568 This avoids undefined behavior in expressions like
1569 DOWNCASE (x) == DOWNCASE (y), which previously suffered
1570 from race conditions in accessing the global variables
1571 case_temp1 and case_temp2.
1572 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
1573 * lisp.h (case_temp1, case_temp2): Remove their decls.
1574 * character.h (ASCII_CHAR_P): Move from here ...
1575 * lisp.h: ... to here, so that the inline functions mentioned
1576 above can use them.
1577
4a6bea26
PE
1578 * dired.c (directory_files_internal_unwind): Now static.
1579
f14b7e14
PE
1580 * fileio.c (file_name_as_directory, directory_file_name):
1581 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
1582 Now static.
2893f146
PE
1583 (file_name_as_directory): Use const pointers when appropriate.
1584 (Fexpand_file_name): Likewise. In particular, newdir might
1585 point at constant storage, so make it a const pointer.
fd4ead52 1586 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
1587 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
1588 signedness issues.
f839df0c
PE
1589 (Fset_file_times, Finsert_file_contents, auto_save_error):
1590 Rename locals to avoid shadowing.
f14b7e14 1591
5716756e 1592 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
1593 (Ftry_completion, Fall_completions): Rename or remove locals
1594 to avoid shadowing.
5716756e 1595
b4c3046a
PE
1596 * marker.c (bytepos_to_charpos): Remove; unused.
1597
b45db522
PE
1598 * lisp.h (verify_bytepos, count_markers): New decls,
1599 so that gcc does not warn that these functions aren't declared.
1600
85876d07
PE
1601 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
1602 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 1603 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 1604 (copy_text): Remove unused local var.
85876d07 1605
03d78a21 1606 * filelock.c (within_one_second): Now static.
b3dd38ab 1607 (lock_file_1): Rename local to avoid shadowing.
03d78a21 1608
5df8f01b
PE
1609 * buffer.c (fix_overlays_before): Mark locals as initialized.
1610 (fix_start_end_in_overlays): Likewise. This function should be
1611 simplified by using pointers-to-pointers, but that's a different
1612 matter.
b1d876f1 1613 (switch_to_buffer_1): Now static.
8f54f30a
PE
1614 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
1615 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 1616
a70072c9 1617 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 1618 Fix pointer signedness issue.
edced198
PE
1619 (sys_subshell): Mark local as volatile if checking for lint,
1620 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 1621 (MAXPATHLEN): Define only if needed.
a70072c9 1622
a0977c44
PE
1623 * process.c (serial_open, serial_configure): Move decls from here ...
1624 * systty.h: ... to here, so that they can be checked.
1625
a884fdcc
PE
1626 * fns.c (get_random, seed_random): Move extern decls from here ...
1627 * lisp.h: ... to here, so that they can be checked.
1628
604efe86 1629 * sysdep.c (reset_io): Now static.
b8950c94 1630 (wait_for_termination_signal): Remove; unused.
604efe86 1631
38fc62d9
PE
1632 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
1633 (copy_keymap_item, append_key, push_text_char_description):
1634 Now static.
1004a21a 1635 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 1636 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
1637 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
1638 (describe_map_tree):
1639 Rename locals to avoid shadowing.
38fc62d9 1640
2f2650da
PE
1641 * keyboard.c: Declare functions static if they are not used elsewhere.
1642 (echo_char, echo_dash, cmd_error, top_level_2):
1643 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
1644 (read_char, kbd_buffer_get_event, make_lispy_position):
1645 (make_lispy_event, make_lispy_movement, apply_modifiers):
1646 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
1647 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
1648 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 1649 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 1650 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 1651
a053e86c 1652 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
1653 (mark_kboards): Move decl here ...
1654 * alloc.c (mark_kboards): ... from here.
a053e86c 1655
4752793e
PE
1656 * lisp.h (force_auto_save_soon): New decl.
1657
74f10ca7 1658 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
1659 (DEFINE_DUMMY_FUNCTION): New macro.
1660 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
1661 Use it.
c03cd23f
PE
1662 (main): Add casts to avoid warnings
1663 if GCC considers string literals to be constants.
74f10ca7 1664
022e70d4
PE
1665 * lisp.h (fatal_error_signal): Add decl, since it's exported.
1666
59d6fe83
PE
1667 * dbusbind.c: Pointer signedness fixes.
1668 (xd_signature, xd_append_arg, xd_initialize):
1669 (Fdbus_call_method, Fdbus_call_method_asynchronously):
1670 (Fdbus_method_return_internal, Fdbus_method_error_internal):
1671 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
1672 (Fdbus_register_signal): Use SSDATA when the context wants char *.
1673
78320123
PE
1674 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
1675 if GCC considers string literals to be constants.
49cebcca 1676 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 1677
35ac2a97
SM
16782011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
1679
fb103ca9
SM
1680 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
1681 (print_preprocess, print_object): New macro to fix last change.
1682
35ac2a97
SM
1683 * print.c (print_preprocess): Don't forget font objects.
1684
62973b41
JB
16852011-03-16 Juanma Barranquero <lekktu@gmail.com>
1686
1687 * emacs.c (USAGE3): Doc fixes.
1688
0e48bb22
AS
16892011-03-15 Andreas Schwab <schwab@linux-m68k.org>
1690
1691 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
1692 structure.
1693
7684e57b
JB
16942011-03-14 Juanma Barranquero <lekktu@gmail.com>
1695
1696 * lisp.h (VWindow_system, Qfile_name_history):
1697 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
1698 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
1699 (w32_system_caret_x, w32_system_caret_y): Declare extern.
1700
1701 * w32select.c: Don't #include "keyboard.h".
c96bbc66 1702 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
1703
1704 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
1705 * w32console.c (detect_input_pending, read_input_pending)
1706 (encode_terminal_code):
1707 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
1708 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
1709 (w32_system_caret_y, Qfile_name_history):
1710 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
1711 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
1712 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
1713 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
1714 * w32proc.c (Qlocal, report_file_error):
1715 * w32term.c (Vwindow_system, updating_frame):
1716 * w32uniscribe.c (initialized, uniscribe_font_driver):
1717 Remove unneeded extern declarations.
1718
2aa46d6c
CY
17192011-03-14 Chong Yidong <cyd@stupidchicken.com>
1720
c96bbc66 1721 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 1722
cffc6f3b
CY
17232011-03-13 Chong Yidong <cyd@stupidchicken.com>
1724
1725 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
1726 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
1727 These macros can no longer be used for assignment.
1728
44f230aa
SM
1729 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1730 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
1731 (record_buffer_markers, fetch_buffer_markers): New functions for
1732 recording and fetching special buffer markers.
1733 (set_buffer_internal_1, set_buffer_temp): Use them.
1734
1735 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
1736
1737 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
1738
1739 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
1740 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
1741
1742 * xdisp.c (hscroll_window_tree):
1743 (reconsider_clip_changes): Use PT instead of BUF_PT.
1744
d251f04b
EZ
17452011-03-13 Eli Zaretskii <eliz@gnu.org>
1746
1747 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
1748 $(EMACS_ROOT)/lib/intprops.h.
1749
f0c77cd1
PE
17502011-03-13 Paul Eggert <eggert@cs.ucla.edu>
1751
3eca4629
PE
1752 Fix more problems found by GCC 4.5.2's static checks.
1753
7c86ee98
PE
1754 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
1755 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
1756 (xg_free_frame_widgets): Make it clear that a local variable is
1757 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
1758 (gdk_window_get_screen): Make it clear that this macro is needed
1759 only if USE_GTK_TOOLTIP.
1e5524e7
PE
1760 (int_gtk_range_get_value): New function, which avoids a diagnostic
1761 from gcc -Wbad-function-cast.
1762 (xg_set_toolkit_scroll_bar_thumb): Use it.
1763 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
1764 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
1765 (get_utf8_string, xg_get_file_with_chooser):
1766 Rename locals to avoid shadowing.
1767 (create_dialog): Move locals to avoid shadowing.
7c86ee98 1768
41729b81
PE
1769 * xgselect.c (xg_select): Remove unused var.
1770
f0c77cd1
PE
1771 * image.c (four_corners_best): Mark locals as initialized.
1772 (gif_load): Initialize transparent_p to zero (Bug#8238).
1773 Mark another local as initialized.
ec6cf4c6 1774 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 1775
ce0ad53d 1776 * image.c (clear_image_cache): Now static.
d5d5a617 1777 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 1778 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
1779 (x_edge_detection): Remove unnecessary cast that
1780 gcc -Wbad-function-cast diagnoses.
2037898d 1781 (gif_load): Fix pointer signedness.
6ae141d6
PE
1782 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
1783 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 1784
33383987 17852011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 1786
d32df629
PE
1787 Improve quality of tests for time stamp overflow.
1788 For example, without this patch (encode-time 0 0 0 1 1
1789 1152921504606846976) returns the obviously-bogus value (-948597
1790 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
1791 reports time overflow. See
1792 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
1793 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
1794 * editfns.c: Include limits.h and intprops.h.
1795 (TIME_T_MIN, TIME_T_MAX): New macros.
1796 (time_overflow): Move earlier, to before first use.
1797 (hi_time, lo_time): New functions, for an accurate test for
1798 out-of-range times.
1799 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
1800 (Fget_internal_run_time): Don't assume time_t fits in int.
1801 (make_time): Use list2 instead of Fcons twice.
1802 (Fdecode_time): More accurate test for out-of-range times.
1803 (check_tm_member): New function.
1804 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
1805 (lisp_time_argument): Don't rely on undefined left-shift and
1806 right-shift behavior when checking for time stamp overflow.
8be6f318 1807
fe31d94c
PE
1808 * editfns.c (time_overflow): New function, refactoring common code.
1809 (Fformat_time_string, Fdecode_time, Fencode_time):
1810 (Fcurrent_time_string): Use it.
1811
8be6f318
PE
1812 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
1813 * dired.c (make_time): Move to ...
1814 * editfns.c (make_time): ... here.
1815 * systime.h: Note the move.
1816
09d9db2c 18172011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 1818
126bc0dc
YM
1819 * fringe.c (update_window_fringes): Remove unused variables.
1820
c47cbdfd
YM
1821 * unexmacosx.c (copy_data_segment): Also copy __got section.
1822 (Bug#8223)
1823
7ac80be9
EZ
18242011-03-12 Eli Zaretskii <eliz@gnu.org>
1825
c96bbc66 1826 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
1827 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
1828 Constify `char *' arguments and their references according to
1829 prototypes in tparam.h.
1830
ecb0f94d 1831 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 1832
7ac80be9
EZ
1833 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
1834 Adapt all references accordingly.
1835
1836 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
1837
ef1fd07e
TT
18382011-03-11 Tom Tromey <tromey@redhat.com>
1839
1840 * buffer.c (syms_of_buffer): Remove obsolete comment.
1841
7ef4b50c
EZ
18422011-03-11 Eli Zaretskii <eliz@gnu.org>
1843
1844 * termhooks.h (encode_terminal_code): Declare prototype.
1845
1846 * msdos.c (encode_terminal_code): Don't declare prototype.
1847
1848 * term.c (encode_terminal_code): Now external again, used by
1849 w32console.c and msdos.c.
1850
44f230aa
SM
1851 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
1852 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 1853
4b1ec863 18542011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 1855
1714f52b 1856 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 1857
4b1ec863
PE
1858 * fringe.c (update_window_fringes): Mark locals as initialized
1859 (Bug#8227).
1860 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 1861
524c7aa6
PE
1862 * alloc.c (mark_fringe_data): Move decl from here ...
1863 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
1864 to check its interface.
1865 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
1866
a5c0af81 1867 * fontset.c (free_realized_fontset): Now static.
7519b8cd 1868 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 1869 (fontset_font): Mark local as initialized.
a9a06e0b 1870 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 1871
b4716021
PE
1872 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
1873
811e9bac 1874 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 1875 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
1876 (x_own_selection, Fx_disown_selection_internal): Rename locals
1877 to avoid shadowing.
1878 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 1879
7e3ab302
PE
1880 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
1881 so that the caller can use some name other than gcpro1.
1882 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
1883 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1884 (Fx_backspace_delete_keys_p):
1885 Use them to avoid shadowing, and rename vars to avoid shadowing.
1886 (x_decode_color, x_set_name, x_window): Now static.
6b437900 1887 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 1888 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
1889 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
1890 Remove unused locals.
7e3ab302
PE
1891 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
1892 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
1893 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
1894 macros.
f78faa98 1895
e2b13473
PE
1896 * xterm.h (x_mouse_leave): New decl.
1897
77f23912
PE
1898 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
1899 Remove unused functions.
cdf4ba58
PE
1900 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
1901 (x_calc_absolute_position): Now static.
7411c686 1902 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 1903 Don't declare local "event" unless it's used.
ed7bf3a5
PE
1904 (x_iconify_frame, x_free_frame_resources): Don't declare locals
1905 unless they are used.
38d0b34a
PE
1906 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
1907 (x_fatal_error_signal): Remove; not used.
a6067996
PE
1908 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
1909 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
1910 (x_error_catcher, x_connection_closed, x_error_handler):
1911 (x_error_quitter, xembed_send_message, x_iconify_frame):
1912 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 1913 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 1914 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 1915
44f230aa
SM
1916 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
1917 Rename or move locals to avoid shadowing.
6b463e58 1918 (tty_defined_color, merge_face_heights): Now static.
5967d051 1919 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
1920 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
1921 does not deduce is never used uninitialized.
73719eba
PE
1922 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
1923 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 1924
426994c3 1925 * terminal.c (store_terminal_param): Now static.
5489860b 1926
032f1620 1927 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 1928 (set_frame_menubar): Remove unused local.
d4323972 1929 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
1930 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
1931 since they might point to immutable storage.
281585b0
PE
1932 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
1933 since it's unused otherwise.
032f1620 1934
367c19e5 1935 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 1936 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
1937 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
1938 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 1939 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
1940 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
1941 does not deduce are never used uninitialized.
70739cbe 1942
07b48fa9
PE
1943 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
1944
8868a238 1945 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
1946 * window.c (window_loop, size_window):
1947 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 1948
7e5cf297 1949 * window.c (display_buffer): Now static.
d6550a9f
PE
1950 (size_window): Mark variables that gcc -Wuninitialized
1951 does not deduce are never used uninitialized.
a586633d
PE
1952 * window.h (check_all_windows): New decl, to forestall
1953 gcc -Wmissing-prototypes diagnostic.
5b555da1 1954 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 1955
f6095868
PE
1956 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
1957 shadowing.
1958 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
1959 Include <limits.h>.
1960 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
1961 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
1962 (load_charset_map): Mark variables that gcc -Wuninitialized
1963 does not deduce are never used uninitialized.
53df7c11 1964 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 1965
f38b440c
PE
1966 * coding.c (coding_set_source, coding_set_destination):
1967 Use "else { /* comment */ }" rather than "else /* comment */;"
1968 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
1969 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
1970 a block, when the outer 'i' will do.
1971 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
1972 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
1973 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
1974 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
1975 (Fdecode_sjis_char, Fdefine_coding_system_internal):
1976 Rename locals to avoid shadowing.
1977 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
1978 * coding.c (emacs_mule_char, encode_invocation_designation):
1979 Now static, since they're not used elsewhere.
413bb2db 1980 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 1981 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
1982 (decode_coding_emacs_mule): Mark variables that gcc
1983 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
1984 (detect_coding_iso_2022): Initialize a local variable that might
1985 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 1986 this initialization is needed. (Bug#8211)
5f58e762
PE
1987 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
1988 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
1989 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
1990 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
1991 Remove unused macros.
f38b440c 1992
232b38b9 1993 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 1994 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 1995 * character.c (string_count_byte8): Likewise.
232b38b9 1996
fb90da1b
PE
1997 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
1998 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
1999
fb93dbc2
PE
2000 * chartab.c (copy_sub_char_table): Now static, since it's not used
2001 elsewhere.
5c156ace
PE
2002 (sub_char_table_ref_and_range, char_table_ref_and_range):
2003 Rename locals to avoid shadowing.
bbcd0949 2004 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 2005
7d3b3862 2006 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 2007 (BIDI_BOB): Remove unused macro.
7d3b3862 2008
6be7d3da
PE
2009 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
2010 deduce are never used uninitialized.
c2ed9c8b 2011 * term.c (encode_terminal_code): Likewise.
6be7d3da 2012
75f8807f 2013 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 2014
50938595
PE
2015 * tparam.h: New file.
2016 * term.c, tparam.h: Include it.
2017 * deps.mk (term.o, tparam.o): Depend on tparam.h.
2018 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
2019 Move these decls to tparam.h, and make them agree with what
2020 is actually in tparam.c. The previous trick of using incompatible
2021 decls in different modules does not conform to the C standard.
2022 All callers of tparam changed to use tparam's actual API.
2023 * tparam.c (tparam1, tparam, tgoto):
2024 Use const pointers where appropriate.
2025
fbceeba2
PE
2026 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
2027 * cm.h (struct cm): Likewise.
2028 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
2029 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
2030 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
2031 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
2032 (turn_on_face, init_tty): Likewise.
2033 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 2034
7f3f1250
PE
2035 * term.c (term_mouse_position): Rename local to avoid shadowing.
2036
e6ca6543
PE
2037 * alloc.c (mark_ttys): Move decl from here ...
2038 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
2039
c40f8d15
AS
20402011-03-11 Andreas Schwab <schwab@linux-m68k.org>
2041
2042 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
2043
cfe0661d
JB
20442011-03-09 Juanma Barranquero <lekktu@gmail.com>
2045
2046 * search.c (compile_pattern_1): Remove argument regp, unused since
2047 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
2048 (compile_pattern): Don't pass it.
2049
0afb4571
J
20502011-03-08 Jan Djärv <jan.h.d@swipnet.se>
2051
2052 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
2053 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
2054 for ! HAVE_GTK3.
2055 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
2056
2057 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
2058
2059 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
2060 gdk_window_get_screen, gdk_window_get_geometry,
2061 gdk_x11_window_lookup_for_display and GDK_KEY_g.
2062 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
2063 (xg_get_pixbuf_from_pixmap): New function.
2064 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
2065 to Pixmap, take frame as parameter, remove GdkColormap parameter.
2066 Call xg_get_pixbuf_from_pixmap instead of
2067 gdk_pixbuf_get_from_drawable.
2068 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
2069 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
2070 (xg_check_special_colors): Use GtkStyleContext and its functions
2071 for HAVE_GTK3.
2072 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
2073 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
2074 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
2075 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
2076 Call gtk_widget_get_preferred_size.
0afb4571
J
2077 (xg_frame_resized): gdk_window_get_geometry only takes 5
2078 parameters.
44f230aa
SM
2079 (xg_win_to_widget, xg_event_is_for_menubar):
2080 Call gdk_x11_window_lookup_for_display.
0afb4571
J
2081 (xg_set_widget_bg): New function.
2082 (delete_cb): New function.
2083 (xg_create_frame_widgets): connect delete-event to delete_cb.
2084 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
2085 (xg_set_background_color): Call xg_set_widget_bg.
2086 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
2087 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
2088 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
2089 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
2090 if ! HAVE_GTK3.
2091 (update_frame_tool_bar): Call gtk_widget_hide.
2092 (xg_initialize): Use GDK_KEY_g.
2093
2094 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
2095 if ! HAVE_GTK3
2096 (x_session_initialize): Call gdk_x11_set_sm_client_id.
2097
2098 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
2099 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
2100 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
2101
1c2cc4ef
JB
21022011-03-08 Juanma Barranquero <lekktu@gmail.com>
2103
2104 * w32xfns.c (select_palette): Check success of RealizePalette against
2105 GDI_ERROR, not zero.
2106
33383987 2107See ChangeLog.11 for earlier changes.
aac0c6e3
MR
2108
2109;; Local Variables:
2110;; coding: utf-8
aac0c6e3
MR
2111;; End:
2112
33383987 2113 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
2114
2115 This file is part of GNU Emacs.
2116
2117 GNU Emacs is free software: you can redistribute it and/or modify
2118 it under the terms of the GNU General Public License as published by
2119 the Free Software Foundation, either version 3 of the License, or
2120 (at your option) any later version.
2121
2122 GNU Emacs is distributed in the hope that it will be useful,
2123 but WITHOUT ANY WARRANTY; without even the implied warranty of
2124 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
2125 GNU General Public License for more details.
2126
2127 You should have received a copy of the GNU General Public License
2128 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.