Update doc for behavior of TAB in Text based modes.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
dbf31225
PE
12011-11-28 Paul Eggert <eggert@cs.ucla.edu>
2
3 Remove GCPRO-related macros that exist only to avoid shadowing locals.
4 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
6 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
7 All uses changed to use GCPRO1 etc.
8 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
9 Revert to old implementation (i.e., before 2011-03-11).
10
1305621b
YM
112011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
12
13 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
14 of scroll runs so as to avoid assigning disabled bogus rows and
15 unnecessary graphics copy operations.
16
8c9afb46
EZ
172011-11-27 Eli Zaretskii <eliz@gnu.org>
18
19 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
20 (snprintf) [_MSC_VER]: Redirect to _snprintf.
21 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
22 (malloc, free, realloc, calloc): Redirect to e_* only when
23 compiling Emacs.
24
25 * lisp.h (GCTYPEBITS): Move before first use.
26 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
27 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
28 this macro definition.
29
30 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
31 _MSC_VER.
32
54e9e3bf
JD
332011-11-27 Jan Djärv <jan.h.d@swipnet.se>
34
35 * gtkutil.c (xg_create_frame_widgets): Call
36 gtk_window_set_has_resize_grip (FALSE) if that function is
37 present with Gtk+ 2.0.
38
83aca1cb
PE
392011-11-26 Paul Eggert <eggert@cs.ucla.edu>
40
41 * fileio.c (Finsert_file_contents): Undo previous change; see
42 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
43
5b76caa4
PE
442011-11-26 Paul Eggert <eggert@cs.ucla.edu>
45
46 Rename locals to avoid shadowing.
47 * fileio.c (Finsert_file_contents):
48 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
49 * process.c (wait_reading_process_output):
50 Rename inner 'proc' to 'p' to avoid shadowing.
51 Indent for consistency with usual Emacs style.
52
8c535114
EZ
532011-11-25 Eli Zaretskii <eliz@gnu.org>
54
55 * xdisp.c (redisplay_window): If cursor row is not fully visible
56 after recentering, and scroll-conservatively is set to a large
57 number, scroll window by a few more lines to make the cursor fully
58 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
59 (start_display): Don't move to the next line if the display should
60 start at a newline that is part of a display vector or an overlay
61 string. (Bug#10119)
8c535114 62
fa4fdb5c
JL
632011-11-24 Juri Linkov <juri@jurta.org>
64
65 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
66 after the `MagickPingImage' call. (Bug#10112)
67
90ec88df
CY
682011-11-23 Chong Yidong <cyd@gnu.org>
69
70 * window.c (Fcoordinates_in_window_p): Accept only live windows.
71
56e2e794
MR
722011-11-23 Martin Rudalics <rudalics@gmx.at>
73
74 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
75 making another buffer current. (Bug#10114)
76
b6e64c41
GM
772011-11-23 Glenn Morris <rgm@gnu.org>
78
79 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
80
6b21de18
CY
812011-11-23 Chong Yidong <cyd@gnu.org>
82
83 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
84 using it (Bug#5984).
85
b12cd789
EZ
862011-11-22 Eli Zaretskii <eliz@gnu.org>
87
88 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
89 and header-lines, as they don't have one computed for them.
90 (Bug#10098)
91
92 * .gdbinit (prow): Make displayed values more self-explaining.
93 Add row's hash code.
94
261b6fd4
LMI
952011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
96
97 * process.c (wait_reading_process_output): Fix asynchrounous
98 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 99 (wait_reading_process_output): Add comment and URL.
261b6fd4 100
e7cfd277
JD
1012011-11-21 Jan Djärv <jan.h.d@swipnet.se>
102
103 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
104
a9b9b7f5
CY
1052011-11-21 Chong Yidong <cyd@gnu.org>
106
107 * window.c (Fnext_window, Fprevious_window): Doc fix.
108
b0d15b4f
SM
1092011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
110
111 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
112
fe7a3057
JB
1132011-11-20 Juanma Barranquero <lekktu@gmail.com>
114
115 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
116
d2999b1a
MR
1172011-11-20 Martin Rudalics <rudalics@gmx.at>
118
119 * window.c (Fset_window_combination_limit): Rename argument
120 STATUS to LIMIT.
121 (Vwindow_combination_limit): Remove "status" from doc-string.
122
d5ff9cd0
AS
1232011-11-20 Andreas Schwab <schwab@linux-m68k.org>
124
125 * m/ibms390.h: Remove.
126 * m/ibms390x.h: Don't include "ibms390.h".
127
a5bb9bd3
SM
1282011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
129
130 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
131 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
132
cd1181db
JB
1332011-11-20 Juanma Barranquero <lekktu@gmail.com>
134
135 * casetab.c (Fset_case_table):
136 * charset.c (Fcharset_after): Fix typos.
137
615a3b8d 1382011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 139
17e845af
PE
140 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
141 Otherwise, valgrind does not work on some platforms.
142 Problem reported by Andreas Schwab in
6a0bf43d
PE
143 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
144 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
145 is set, removing the need for VIRT_ADDRESS_VARIES.
146 (PURE_P): Use a more-efficient implementation that needs just one
147 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
148 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
149 to 4 (xorl, subq, cmpq, setbe).
150 * alloc.c (pure): Always extern now, since that's the
151 VIRT_ADDR_VARIES behavior.
152 (PURE_POINTER_P): Use a single comparison, not two, for
153 consistency with the new puresize.h.
154 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
155 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
156 Remove VIRT_ADDR_VARIES no longer needed.
157
f8fe6f96
EZ
1582011-11-19 Eli Zaretskii <eliz@gnu.org>
159
160 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
161 (erase_phys_cursor, update_window_cursor, show_mouse_face)
162 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
163 behave as if the cursor position were at the window margin.
164
165 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
166 and the cursor position is out of bounds, behave as if the cursor
167 position were at the window margin. (Bug#10075)
168
df05a53c
CY
1692011-11-18 Chong Yidong <cyd@gnu.org>
170
171 * window.c (Fwindow_combination_limit): Make first argument
172 non-optional, since it is meaningless for live windows like the
173 selected window.
174
2071918e
DA
1752011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
176
177 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
178
b50a28de
SM
1792011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
180
181 * intervals.c: Fix grafting over the whole buffer (bug#10071).
182 (graft_intervals_into_buffer): Simplify.
183
015137db
EZ
1842011-11-18 Eli Zaretskii <eliz@gnu.org>
185
186 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
187 hash values of the two rows.
188 (copy_row_except_pointers): Preserve the used[] arrays and the
189 hash values of the two rows. (Bug#10035)
68c95424 190 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
191
192 * xdisp.c (row_hash): New function, body extracted from
193 compute_line_metrics.
194 (compute_line_metrics): Call row_hash, instead of computing the
195 hash code inline.
196
197 * dispnew.c (verify_row_hash): Call row_hash for computing the
198 hash code of a row, instead of duplicating code from xdisp.c.
199
200 * dispextern.h (row_hash): Add prototype.
201
a2addb04
TH
2022011-11-18 Tassilo Horn <tassilo@member.fsf.org>
203
204 * frame.c (delete_frame): Don't delete the terminal when the last
205 X frame is closed if emacs is built with GTK toolkit.
206
df85d315
JB
2072011-11-17 Juanma Barranquero <lekktu@gmail.com>
208
209 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
210
a0c2d0ae
MR
2112011-11-17 Martin Rudalics <rudalics@gmx.at>
212
213 * window.c (Vwindow_splits): Rename to
214 Vwindow_combination_resize. Suggested by Juri Linkov.
215 (Fsplit_window_internal): Use Vwindow_combination_resize instead
216 of Vwindow_splits.
217
58179cce
JB
2182011-11-16 Juanma Barranquero <lekktu@gmail.com>
219
7877f373
JB
220 * nsfns.m (Fns_font_name):
221 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 222
b6f67890
MR
2232011-11-16 Martin Rudalics <rudalics@gmx.at>
224
225 * window.h (window): Rename slot "nest" to "combination_limit".
226 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
227 (Fset_window_nest): Rename to Fset_window_combination_limit.
228 (Vwindow_nest): Rename to Vwindow_combination_limit.
229 (recombine_windows, make_parent_window, make_window)
230 (Fsplit_window_internal, saved_window)
231 (Fset_window_configuration, save_window_save): Rename all
232 occurrences of window_nest to window_combination_limit.
233
c7015153
JB
2342011-11-15 Juanma Barranquero <lekktu@gmail.com>
235
236 * image.c (imagemagick_load_image): Fix typo.
237
322ad6ec
EZ
2382011-11-14 Eli Zaretskii <eliz@gnu.org>
239
240 * xdisp.c (display_line): Move the call to
241 highlight_trailing_whitespace before the call to
242 compute_line_metrics, since the latter needs to see the final
243 faces of all the glyphs to compute ROW's hash value. Fixes
244 assertion violations in row_equal_p. (Bug#10035)
245
f067b8ec
JB
2462011-11-14 Juanma Barranquero <lekktu@gmail.com>
247
248 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
249 just return (bug#10044).
250
1e5b2111
EZ
2512011-11-12 Eli Zaretskii <eliz@gnu.org>
252
7ef3cbd5
EZ
253 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
254 with user-defined heap size. Bump the default size of the temacs
255 heap to 27MB, to avoid memory warning when running temacs.
256 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
257
1e5b2111
EZ
258 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
259 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
260 (verify_row_hash) [XASSERTS]: New function.
261 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
262 that the hash value of glyph rows is correct.
1e5b2111 263
89d61221
MR
2642011-11-12 Martin Rudalics <rudalics@gmx.at>
265
266 * window.h (window): Remove splits slot.
267 * window.c (Fwindow_splits, Fset_window_splits): Remove.
268 (Fdelete_other_windows_internal, make_parent_window)
269 (make_window, Fsplit_window_internal, Fdelete_window_internal)
270 (Fset_window_configuration, save_window_save): Don't deal with
271 split status of windows.
272 (saved_window): Remove splits slot.
273 (Vwindow_splits): Rewrite doc-string.
274
97f18cc8
JD
2752011-11-11 Jan Djärv <jan.h.d@swipnet.se>
276
277 * xfns.c (unwind_create_frame):
278 * nsfns.m (unwind_create_frame):
279 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
280 Vframe_list (Bug#9999).
281
22a648b4
DA
2822011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
283
0b381c7e 284 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 285
659afede
KH
2862011-11-11 Kenichi Handa <handa@m17n.org>
287
288 * callproc.c (Fcall_process): Set the member dst_multibyte of
289 process_coding.
290
9ac0394b
KH
2912011-11-11 Johan Bockgård <bojohan@gnu.org>
292
293 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
294 avoid a crash (bug#9496).
295
2fbdc249
CY
2962011-11-09 Chong Yidong <cyd@gnu.org>
297
298 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
299 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
300
ac6b1f81
PE
3012011-11-08 Paul Eggert <eggert@cs.ucla.edu>
302
303 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
304
09db192c
PE
3052011-11-08 Paul Eggert <eggert@cs.ucla.edu>
306
307 Avoid some portability problems by eschewing 'extern inline' functions.
308 The trivial performance wins aren't worth the portability hassles; see
309 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
310 et seq.
311 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
312 (window_box_width, window_box_left, window_box_left_offset)
313 (window_box_right, window_box_right_offset): Undo previous change,
314 by removing the "extern"s.
315 * intervals.c (adjust_intervals_for_insertion)
316 (adjust_intervals_for_deletion): Undo previous change,
317 making these static again.
318 (offset_intervals, temp_set_point_both, temp_set_point)
319 (copy_intervals_to_string): No longer inline.
320 * xdisp.c (window_text_bottom_y, window_box_width)
321 (window_box_height, window_box_left_offset)
322 (window_box_right_offset, window_box_left, window_box_right)
323 (window_box): No longer inline.
324
105216ed
CY
3252011-11-08 Chong Yidong <cyd@gnu.org>
326
327 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
328 (Fwindow_body_height, Fwindow_body_width): Move from Lisp. Signal
329 an error if not a live window.
330 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
331 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
332
ae9e237f
JB
3332011-11-07 Juanma Barranquero <lekktu@gmail.com>
334
335 * lisp.h (syms_of_abbrev): Remove declaration.
336 Reported by CHENG Gao <chenggao@royau.me>.
337
c7aa8333
EZ
3382011-11-07 Eli Zaretskii <eliz@gnu.org>
339
340 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
341 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
342 of temacs in GUI mode.
343
be7f5545
MR
3442011-11-07 Martin Rudalics <rudalics@gmx.at>
345
346 * window.h: Declare delete_all_child_windows instead of
347 delete_all_subwindows.
348 * window.c (Fwindow_nest, Fset_window_nest)
349 (Fset_window_new_total, Fset_window_new_normal)
350 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
351 (delete_all_subwindows): Rename to delete_all_child_windows.
352 (Fdelete_other_windows_internal, Fset_window_configuration):
353 Call delete_all_child_windows instead of delete_all_subwindows.
354 * frame.c (delete_frame): Call delete_all_child_windows instead
355 of delete_all_subwindows.
356
ca78dc43
PE
3572011-11-07 Paul Eggert <eggert@cs.ucla.edu>
358
359 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
360 This is also needed for porting to any host where GC_MARK_STACK is
361 not GC_MAKE_GCPROS_NOOPS.
362 (which_symbols): Use it.
363
a0241d01
KH
3642011-11-07 Kenichi Handa <handa@m17n.org>
365
366 * coding.c (coding_set_destination): Check coding->src_pos only
367 when coding->src_object is a buffer (bug#9910).
368
369 * process.c (send_process): Set the member src_multibyte of coding
370 to 0 (bug#9911) when sending a unibyte text.
371
372 * callproc.c (Fcall_process): Set the member src_multibyte of
373 process_coding to 0 (bug#9912).
374
a64bfdfa 3752011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
376
377 * xmenu.c (cleanup_widget_value_tree): New function.
378 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
379 calling free_menubar_widget_value_tree directly (Bug#9830).
380
cb41b32a
PE
3812011-11-06 Paul Eggert <eggert@cs.ucla.edu>
382
383 Fix some portability problems with 'inline'.
384 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
385 (window_box_width, window_box_left, window_box_left_offset)
386 (window_box_right, window_box_right_offset): Declare extern.
387 Otherwise, these inline functions do not conform to C99 and
388 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
389 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
390 * intervals.c (adjust_intervals_for_insertion)
391 (adjust_intervals_for_deletion): Now extern, because otherwise the
392 extern inline functions 'offset_intervals' couldn't refer to it.
393 (static_offset_intervals): Remove.
394 (offset_intervals): Rewrite using the old contents of
395 static_offset_intervals. The old version didn't conform to C99
396 because an extern inline function contained a reference to an
397 identifier with static linkage.
398
b7041366
AS
3992011-11-06 Andreas Schwab <schwab@linux-m68k.org>
400
401 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
402 GC.
403
88a37c4d
EZ
4042011-11-06 Eli Zaretskii <eliz@gnu.org>
405
406 * xdisp.c (init_iterator, reseat_to_string): Don't set the
407 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
408 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
409 return Qleft_to_right.
410
49745b39
CY
4112011-11-06 Chong Yidong <cyd@gnu.org>
412
413 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
414 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
415 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
416 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
417 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
418 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
419 (Fwindow_vscroll): Doc fix.
420 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
421 argument, since it makes no sense to pass a live window and for
422 consistency with window-child.
423
1f05cd82
CS
4242011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
425
426 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
427 support MSVC.
428
22610910
JR
4292011-11-05 Jason Rumney <jasonr@gnu.org>
430
431 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
432 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
433 fonts (Bug#6029).
434 (add_font_entity_to_list): Fix logic errors in mixed boolean and
435 bitwise arithmetic preventing use of unicode-sip and non-truetype
436 opentype fonts.
437
a06776b2
EZ
4382011-11-05 Eli Zaretskii <eliz@gnu.org>
439
3ad924ba
EZ
440 * s/ms-w32.h (fstat, stat, utime): Move redirections to
441 "emacs"-only part.
442
a06776b2
EZ
443 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
444 initialization code to keep similarity to xfns.c after changes
445 from 2011-11-05.
446
c9e7db78
JD
4472011-11-05 Jan Djärv <jan.h.d@swipnet.se>
448
a97f8f3f
JD
449 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
450 (unwind_create_frame): New function (Bug#9943).
451 (Fx_create_frame): Restructure code to be more similar to the one in
452 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
453 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
454 Move terminal->reference_count++ just before making the frame official
455 (Bug#9943).
456
457 * nsterm.m (x_free_frame_resources): New function.
458 (x_destroy_window): Move code to x_free_frame_resources.
459
c9e7db78
JD
460 * xfns.c (unwind_create_frame): Fix comment.
461 (Fx_create_frame, x_create_tip_frame): Move
462 terminal->reference_count++ just before making the frame
463 official. Move initialization of image_cache_refcount and
464 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
465
a6fc3b5c
EZ
4662011-11-05 Eli Zaretskii <eliz@gnu.org>
467
468 Support MSVC build with newer versions of Visual Studio.
469 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
470 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
471 nt/gmake.defs.
472
473 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
474 which are not supported by MSVC.
475 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
476 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
477 bitfields.
478 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
479 types in bitfields.
480 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
481
482 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
483
58179cce 4842011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
485
486 Support MSVC build with newer versions of Visual Studio.
487 * w32.c: Don't include w32api.h for MSVC.
488 (init_environment) [_MSC_VER]: Call sys_access, not _access.
489
490 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
491 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
492 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
493 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
494 e_* cousins.
495 (alloca) [_MSC_VER]: Define to _alloca.
496
497 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
498
499 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
500
a58c13ed
EZ
5012011-11-04 Eli Zaretskii <eliz@gnu.org>
502
503 * xdisp.c (note_mouse_highlight): If either of
504 previous/next-single-property-change returns nil, treat that as
505 the beginning or the end of the buffer. (Bug#9955)
506
fe0b6370
JD
5072011-11-04 Jan Djärv <jan.h.d@swipnet.se>
508
a58c13ed 509 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
510 label is not null (Bug#9951).
511 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
512 may be NULL.
513
89bd5ee1
EZ
5142011-11-04 Eli Zaretskii <eliz@gnu.org>
515
516 * window.c (Fwindow_body_size): Mention in the doc string that the
517 return value is in frame's canonical units. (Bug#9949)
518
84c3edb9
EZ
5192011-11-03 Eli Zaretskii <eliz@gnu.org>
520
4e2fb5c7
EZ
521 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
522
84c3edb9 523 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 524 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 525 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 526
bc17a887
EZ
5272011-11-01 Eli Zaretskii <eliz@gnu.org>
528
529 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
530 Don't stop backward scan on the continuation glyph, even though
531 its CHARPOS is positive.
26b46e51
EZ
532 (mouse_face_from_buffer_pos, note_mouse_highlight): Rename
533 cover_string to disp_string.
bc17a887 534
4ee88440
MR
5352011-11-01 Martin Rudalics <rudalics@gmx.at>
536
537 * window.c (temp_output_buffer_show): Don't use
538 Vtemp_buffer_show_specifiers.
539 (Vtemp_buffer_show_specifiers): Remove unused variable.
540
c2ff3c02
EZ
5412011-10-30 Eli Zaretskii <eliz@gnu.org>
542
543 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
544 past the beginning of the current glyph matrix.
545
58179cce 5462011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
547
548 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
549 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
550 HAVE_GTK3 (Bug#9869).
b77a6a7f 551
3b574623
JD
552 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
553 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
554
b77a6a7f
JD
555 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
556
557 * xterm.c: Declare x_handle_net_wm_state to return int.
558 (handle_one_xevent): Check if we are iconified but don't have
559 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
560 (get_current_wm_state): Return non-zero if not hidden,
561 check for _NET_WM_STATE_HIDDEN (Bug#9893).
562 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
563 (x_handle_net_wm_state): Return what get_current_wm_state returns.
564 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
565
196e41e4
PE
5662011-10-29 Paul Eggert <eggert@cs.ucla.edu>
567
568 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
569 so that this new function doesn't get optimized away by a
570 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
571
021f2e1a
AS
5722011-10-29 Andreas Schwab <schwab@linux-m68k.org>
573
574 * frame.h (MOUSE_HL_INFO): Remove excess parens.
575
8b058d44
EZ
5762011-10-29 Eli Zaretskii <eliz@gnu.org>
577
578 Fix the `xbytecode' command.
579 * .gdbinit (xprintbytestr): New command.
b50a28de 580 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
581 (xbytecode): Print the byte-code string as well.
582
4452fb80
EZ
5832011-10-29 Kim Storm <storm@cua.dk>
584
8b058d44
EZ
585 * alloc.c (which_symbols): New function.
586
21b72067
AS
5872011-10-29 Andreas Schwab <schwab@linux-m68k.org>
588
589 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
590 line. (Bug#9903)
591
83ed7b5c
GM
5922011-10-29 Glenn Morris <rgm@gnu.org>
593
594 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
595 Not clear what it was for, and it causes various bugs. (Bug#9839)
596
5a7a728b
EZ
5972011-10-28 Eli Zaretskii <eliz@gnu.org>
598
599 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
600 possible random value that matches one of those tested as
601 condition to clear the mouse face.
602
d3d0842f
CY
6032011-10-28 Chong Yidong <cyd@gnu.org>
604
605 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
606
31b39d13
DN
6072011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
608
609 * window.c (make_window): Initialize phys_cursor_on_p.
610
9aba6043
SM
6112011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
612
613 * lisp.h (struct Lisp_Symbol): Update comments.
614
c20992f4
JB
6152011-10-28 Juanma Barranquero <lekktu@gmail.com>
616
617 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
618
db4f02f2
EZ
6192011-10-28 Eli Zaretskii <eliz@gnu.org>
620
621 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
622 <oslsachem@gmail.com> for helping to debug this.
623
624 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
625 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
626 (g_b_init_get_glyph_outline_w): New static variables.
627 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
628 (GetGlyphOutlineW_Proc): New typedefs.
629 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
630 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
631 New functions.
632 (w32font_open_internal, compute_metrics):
633 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
634 instead of calling the "wide" APIs directly.
635
636 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
637
638 * w32.h (syms_of_w32font): Add prototype.
639
87e68db4
JB
6402011-10-27 Juanma Barranquero <lekktu@gmail.com>
641
642 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
643 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
644 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
645 (Fmove_to_window_line): Doc fix.
646
435c1d67
CY
6472011-10-27 Chong Yidong <cyd@gnu.org>
648
649 * process.c (make_process): Set gnutls_state to NULL.
650
651 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
652 non-NULL, regardless of GNUTLS_INITSTAGE.
653 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
654 an error. Set process slots as soon as we allocate them.
655
656 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
657
9c6c6f49
CY
6582011-10-27 Chong Yidong <cyd@gnu.org>
659
9aba6043
SM
660 * gnutls.c (emacs_gnutls_deinit): New function.
661 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
662 (Fgnutls_deinit, Fgnutls_boot): Use it.
663
664 * process.c (make_process): Initialize GnuTLS credentials to NULL.
665 (deactivate_process): Call emacs_gnutls_deinit.
666
657d08d3
JB
6672011-10-27 Juanma Barranquero <lekktu@gmail.com>
668
669 * image.c (x_create_x_image_and_pixmap):
670 * w32.c (sys_rename, w32_delayed_load):
671 * w32font.c (fill_in_logfont):
672 * w32reg.c (x_get_string_resource): Silence compiler warnings.
673
5430d399
JB
6742011-10-26 Juanma Barranquero <lekktu@gmail.com>
675
676 * w32fns.c (w32_default_color_map): New function,
677 extracted from Fw32_default_color_map.
a7ef684b 678 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 679
fe0055fa
PE
6802011-10-25 Paul Eggert <eggert@cs.ucla.edu>
681
682 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
683
e6346438
SM
6842011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
685
686 * keyboard.c (test_undefined): New function (bug#9751).
687 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
688
e112cc37
ET
6892011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
690
691 * sysdep.c (init_sys_modes): Fix the check for the controlling
692 terminal (Bug#6649).
693
7b5d6677
EZ
6942011-10-20 Eli Zaretskii <eliz@gnu.org>
695
696 * dispextern.h (struct bidi_it): New member next_en_type.
697
698 * bidi.c (bidi_line_init): Initialize the next_en_type member.
699 (bidi_resolve_explicit_1): When next_en_pos is valid for the
700 current character, check also for next_en_type being WEAK_EN.
701 (bidi_resolve_weak): Don't enter the expensive loop if the current
702 position is before next_en_pos. Record the bidi type of the first
703 non-ET, non-BN character we find, in addition to its position.
704 (bidi_level_of_next_char): Invalidate next_en_type when
705 next_en_pos is over-stepped.
706
7da0b018
PE
7072011-10-20 Paul Eggert <eggert@cs.ucla.edu>
708
709 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
710 * editfns.c: Rewrite current-time-zone so that it invokes
711 the equivalent of (format-time-string "%Z") to get the time zone name.
712 This fixes a bug when the time zone name contains characters that
713 need converting from the system time locale to Emacs internal format.
714 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
715 that patch fixed format-time-string to do the conversion, but
716 I forgot to fix current-time-zone.
717 (format_time_string): New function, containing most of
718 what Fformat_time_string used to contain.
719 (Fformat_time_string): Rewrite in terms of format_time_string.
720 This doesn't change this function's behavior.
721 (current-time-zone): Rewrite to use format_time_string.
722 This fixes the bug reported by Michael Schierl in
723 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
724 Jason Rumney's 2007-06-07 change worked around this bug, but
725 didn't fix it.
726 * systime.h (tzname, timezone): Remove no-longer-used declarations.
727
8547b010
EZ
7282011-10-19 Eli Zaretskii <eliz@gnu.org>
729
730 * xdisp.c (start_display): If the character at POS is displayed
731 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
732 (try_window_reusing_current_matrix): If a line ends in a display
733 vector or the next line starts in a display vector, continue
734 redrawing the window even though the character position of
735 start_row was reached.
8547b010
EZ
736 (Bug#9771, part 2)
737
4e948d15
CY
7382011-10-18 Chong Yidong <cyd@gnu.org>
739
740 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
741 with nobreak-char-display too.
742
4787455f
EZ
7432011-10-18 Eli Zaretskii <eliz@gnu.org>
744
745 Fix part 3 of bug#9771.
746 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
747 (bidi_resolve_neutral): Don't enter the expensive loop looking for
748 non-neutral characters if the current character is a paragraph
749 separator (a.k.a. Newline). This avoids running the same
750 expensive loop twice, once when we consume the preceding newline
751 and the other time when the line actually needs to be displayed.
752 Avoid the loop when we see neutrals on the base embedding level
753 following a character whose directionality is the same as the
754 paragraph's. This avoids running the expensive loop when a line
755 ends in a long sequence of neutrals, like control characters.
756 Add assertion against STRONG_AL type. Slightly rearrange code
757 that determines the type of a neutral given the first non-neutral
758 that follows it.
759 (bidi_level_of_next_char): Set next_en_pos to zero when
760 invalidating its info.
761
2c91f553
EZ
7622011-10-17 Eli Zaretskii <eliz@gnu.org>
763
764 * xdisp.c (push_display_prop): Determine whether to record string
765 or buffer position by IT->string, not by IT->method. Allow
766 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
767 (move_it_vertically_backward): Don't look for character position
768 immediately after the newline when in a continuation line.
769 (Bug#9771, part 1)
2c91f553 770
c7b08b0d
MR
7712011-10-15 Martin Rudalics <rudalics@gmx.at>
772
773 * window.c (coordinates_in_window): Rewrite and delabelize
774 vertical border check. (Bug#5357) (Bug#9618)
775
6b02f655
SM
7762011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
777
778 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
779 errors in XSetWindowBorder (bug#9310).
780
81d40c92
DA
7812011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
782
783 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
784 avoid crash when xmalloc overrun checking is enabled.
785
d4172c3b
EZ
7862011-10-13 Eli Zaretskii <eliz@gnu.org>
787
788 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
789 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
790 cursor motion with <left> and <right> arrow keys.
791
792 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
793 some callers set that themselves.
794
b00eea75
EZ
7952011-10-12 Eli Zaretskii <eliz@gnu.org>
796
797 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
798 display string and the previous row comes from the same string and
799 is empty. (Bug#9739) (Bug#9738)
800
8fe012c4
SM
8012011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
802
803 * doc.c (get_doc_string): Encode file name (bug#9735).
804
0074aef2
EZ
8052011-10-12 Eli Zaretskii <eliz@gnu.org>
806
79beb178
EZ
807 * bidi.c (bidi_level_of_next_char):
808 * xdisp.c (get_visually_first_element): Remove old incorrect
809 comments regarding the Unicode Line Separator character.
810
0074aef2
EZ
811 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
812
6e4b3fbe
DA
8132011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
814
815 * alloc.c (Fgc_status): Do not access beyond zombies array
816 boundary if nzombies > MAX_ZOMBIES.
817 * alloc.c (dump_zombies): Add missing format specifier.
818
0324f3af
PE
8192011-10-12 Paul Eggert <eggert@cs.ucla.edu>
820
b5525cac
PE
821 * xdisp.c (set_cursor_from_row): Simplify conditionals,
822 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
823
0324f3af
PE
824 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
825 Some packages use them to denote characters with modifiers.
826
e9b5f888
AS
8272011-10-11 Andreas Schwab <schwab@linux-m68k.org>
828
829 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
830 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
831 matching a pp-number. Rename parameter var to var1.
832
127827c0
SM
8332011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
834
835 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
836
c8fd3bd0
GM
8372011-10-08 Glenn Morris <rgm@gnu.org>
838
839 * callint.c (Fcall_interactively): Give a more explicit error for the
840 'c' case with a non-character input. (Bug#8479)
841
352ec8ff
EZ
8422011-10-08 Eli Zaretskii <eliz@gnu.org>
843
03669ccb
EZ
844 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
845 lines.
7061c986
EZ
846 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
847 lines that are hscrolled on the left.
03669ccb 848
352ec8ff
EZ
849 * dispnew.c (buffer_posn_from_coords): Account for a possible
850 presence of header-line. (Bug#4426)
851
a66cfb1c
SM
8522011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
853
6b02f655
SM
854 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
855 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 856
7c5ee88e
PE
8572011-10-07 Paul Eggert <eggert@cs.ucla.edu>
858
859 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
860 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
861 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
862 this makes Emacs dump core during garbage collection on rare
863 occasions. sizeof is obviously inferior to offsetof here, so
864 stick with offsetof.
865 (GC_POINTER_ALIGNMENT): New macro.
866 (mark_memory): Omit 3rd (offset) arg; caller changed.
867 Don't assume EMACS_INT alignment is the same as pointer alignment.
868
df1bbe5b
SM
8692011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
870
871 * keyboard.c (read_key_sequence_remapped): New var.
872 (read_key_sequence): Compute remapping in the right buffer.
873 (command_loop_1): Use read_key_sequence's remapping directly.
874
51553db6
SM
8752011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
876
32c1fffd
SM
877 * dired.c (file_name_completion): Don't expand file name.
878 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
879 before checking file name handler.
880
51553db6
SM
881 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
882 they've been requested explicitly (bug#9591).
883
b6bd1599 8842011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
885
886 * keymap.c (Fsingle_key_description): Use make_specified_string
887 instead of build_string to build string from push_key_description.
888 (Bug#5193)
889
f701dc2a
PE
8902011-09-30 Paul Eggert <eggert@cs.ucla.edu>
891
4222c55d
PE
892 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
893 This fixes a Y2038 bug on 64-bit hosts.
894 * buffer.c (reset_buffer):
895 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
896 (Fclear_buffer_auto_save_failure):
897 Use 0, not -1, to represent an unset failure time, since time_t
898 might not be signed.
899
f701dc2a
PE
900 Remove dependency on glibc malloc internals.
901 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
902 Move back here from lisp.h, but with their new implementations.
903 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
904 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
905 * charset.c (charset_table_init): New static var.
906 (syms_of_charset): Use it instead of xmalloc. This removes a
907 dependency on glibc malloc internals. See Eli Zaretskii's comment in
908 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
909 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
910 Move back to alloc.c.
911 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
912 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
913
9ceebf39
JD
9142011-09-30 Jan Djärv <jan.h.d@swipnet.se>
915
916 * nsterm.m (windowDidResize): Call x_set_window_size only when
917 ns_in_resize is true. Otherwise set pixelwidth/height and
918 call change_frame_size (Bug#9628).
919
cb993c58
PE
9202011-09-30 Paul Eggert <eggert@cs.ucla.edu>
921
3930c88b
PE
922 Port --enable-checking=all to Fedora 14 x86-64.
923 * charset.c (syms_of_charset): Also account for glibc malloc's
924 internal overhead when calculating the initial malloc maximum.
925
cb993c58
PE
926 Port --enable-checking=all to Fedora 14 x86.
927 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
928 Move to lisp.h.
929 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
930 (overrun_check_realloc, overrun_check_free):
931 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
932 That way, xmalloc returns a properly-aligned pointer even if
933 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
934 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
935 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
936 into account when calculating the initial malloc maximum.
937 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
938 Move here from alloc.c, so that charset.c can use it too.
939 Properly align; the old code wasn't right for common 32-bit hosts
940 when configured with --enable-checking=all.
941 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
942 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
943
31bed486
EZ
9442011-09-29 Eli Zaretskii <eliz@gnu.org>
945
04c70788 946 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
947 use EDOM.
948
fbcaa2f3
EZ
9492011-09-28 Eli Zaretskii <eliz@gnu.org>
950
951 * xdisp.c (compute_display_string_end): If there's no display
952 string at CHARPOS, return -1.
953
954 * bidi.c (bidi_fetch_char): When compute_display_string_end
955 returns a negative value, treat the character as a normal
956 character not covered by a display string. (Bug#9624)
957
a239d4e9
JB
9582011-09-28 Juanma Barranquero <lekktu@gmail.com>
959
960 * lread.c (Fread_from_string): Fix typo in docstring.
961
88652fd5
EZ
9622011-09-27 Eli Zaretskii <eliz@gnu.org>
963
964 * xdisp.c (handle_invisible_prop): If invisible text ends on a
965 newline, reseat the iterator instead of bidi-iterating there one
966 character at a time. (Bug#9610)
32c1fffd
SM
967 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
968 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 969
ed497dd4
AS
9702011-09-27 Andreas Schwab <schwab@linux-m68k.org>
971
972 * lread.c (readevalloop): Use correct code for NBSP.
973 (read1): Likewise. (Bug#9608)
974
b2bf61aa
MA
9752011-09-25 Michael Albinus <michael.albinus@gmx.de>
976
977 * dbusbind.c (Fdbus_register_signal): When service is not
978 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
979
32bbb17c
GM
9802011-09-25 Glenn Morris <rgm@gnu.org>
981
982 * buffer.c (truncate-lines): Doc fix.
983
94e0933e
CY
9842011-09-24 Chong Yidong <cyd@stupidchicken.com>
985
986 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
987 (Fset_window_next_buffers): Doc fix.
988
cddde921
GM
9892011-09-24 Glenn Morris <rgm@gnu.org>
990
991 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
992
1260aef1
PE
9932011-09-24 Paul Eggert <eggert@cs.ucla.edu>
994
25b4bfa0
PE
995 Fix minor problems found by static checking.
996 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
997 * indent.c (Fvertical_motion): Fix == vs = typo.
998
e3cbd34b
EZ
9992011-09-24 Eli Zaretskii <eliz@gnu.org>
1000
a66cfb1c
SM
1001 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
1002 Default value is now t. Doc fix.
6bf7006f 1003
e3cbd34b 1004 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 1005 logic when moving up, not only when moving down. Fix the
e3cbd34b 1006 confusing name and values of the it_overshoot_expected variable;
32c1fffd 1007 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
1008
1009 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
1010 CHARPOS is covered by a display string which includes newlines.
1011 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
1012 is covered by a display string with embedded newlines.
1013
a3de0cbd
MA
10142011-09-24 Michael Albinus <michael.albinus@gmx.de>
1015
1016 * dbusbind.c (Fdbus_register_signal): Add match rule to
1017 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
1018 (Fdbus_register_method, Vdbus_registered_objects_table):
1019 Fix docstring.
a3de0cbd 1020
b260039d
JM
10212011-09-24 Jim Meyering <meyering@redhat.com>
1022
32c1fffd 1023 do not ignore write error for any output size
b260039d
JM
1024 The previous change was incomplete.
1025 While it makes emacs --batch detect the vast majority of stdout
1026 write failures, errors were still ignored whenever the output size is
1027 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
1028 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
1029 && echo FAIL: ignored write error
1030 FAIL: ignored write error
1031 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
1032 && echo FAIL: ignored write error
1033 FAIL: ignored write error
1034 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
1035
8eca8a7c
AS
10362011-09-23 Andreas Schwab <schwab@linux-m68k.org>
1037
1038 * emacs.c (Fkill_emacs): In noninteractive mode exit
1039 non-successfully if a write error occurred on stdout. (Bug#9574)
1040
3341db62
EZ
10412011-09-21 Eli Zaretskii <eliz@gnu.org>
1042
1043 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
1044 the xassert test.
1045
1046 * dispextern.h (struct it): Update the comment documenting what
1047 can it->OBJECT be.
1048
8c203dbf
EZ
10492011-09-20 Eli Zaretskii <eliz@gnu.org>
1050
1051 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
1052 a display string, extend search for cursor position to end of row.
1053 (find_row_edges): If the row ends in a newline from a display
1054 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
1055 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
1056 (Fcurrent_bidi_paragraph_direction): Fix search for previous
1057 non-empty line. Fixes confusing cursor motion with arrow keys at
1058 the beginning of a line that starts with whitespace.
8c203dbf 1059
a4824228
LMI
10602011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1061
1062 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
1063 (bug#9493).
1064
33ed493b
CY
10652011-09-18 Chong Yidong <cyd@stupidchicken.com>
1066
1067 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
1068 boolean (Bug#9154).
1069
56cd55c8
EZ
10702011-09-18 Eli Zaretskii <eliz@gnu.org>
1071
1072 * xdisp.c (display_line): Record maximum and minimum buffer
1073 positions even if no glyphs were produced (e.g., by a zero-width
1074 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
1075 buffer positions that will be removed from the glyph row because
1076 they don't fit.
c02dcedf
EZ
1077 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
1078 column is beyond frame width: don't subtract 1 "pixel" when
1079 computing width of the stretch.
3e62b7e0
EZ
1080 (reseat_at_next_visible_line_start): Undo the change made on
1081 2011-09-17 that saved paragraph information and restored it after
1082 the call to `reseat'. (Bug#9545)
56cd55c8 1083
5ed99d36 10842011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
1085
1086 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
1087 and turn window cursor on if cleared (Bug#9415).
1088
5ed99d36 10892011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
1090
1091 * search.c (boyer_moore): Take unibyte characters from pattern
1092 literally. (Bug#9458)
1093
9bade7b2
EZ
10942011-09-18 Eli Zaretskii <eliz@gnu.org>
1095
1096 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
1097
e5e9d610
PE
10982011-09-18 Paul Eggert <eggert@cs.ucla.edu>
1099
87e4427a
PE
1100 Fix minor problem found by static checking.
1101 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
1102 initialized, to pacify gcc -Wuninitialized.
1103
e5e9d610
PE
1104 * fileio.c: Report proper errno when syscall falls.
1105 (Finsert_file_contents): Save and restore errno,
1106 so that report_file_error outputs the correct diagnostic.
1107 (Fwrite_region) [CLASH_DETECTION]: Likewise.
1108
a1674f0b
EZ
11092011-09-18 Eli Zaretskii <eliz@gnu.org>
1110
1111 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
1112
fbfb6dd4
EZ
11132011-09-17 Eli Zaretskii <eliz@gnu.org>
1114
1115 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
1116 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
1117
bb187662
EZ
11182011-09-17 Eli Zaretskii <eliz@gnu.org>
1119
1137e8b8 1120 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 1121 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
1122
1123 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
1124 (bidi_find_paragraph_start): Search back for paragraph beginning
1125 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
1126 (bidi_move_to_visually_next): Only trigger paragraph-related
1127 computations when the last character is a newline or at EOB, not
1128 just any NEUTRAL_B. (Bug#9470)
1129
bb187662
EZ
1130 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
1131 truncated lines if point is covered by a display string. (Bug#9524)
1132
2e621251
PE
11332011-09-16 Paul Eggert <eggert@cs.ucla.edu>
1134
1135 * xselect.c: Relax test for outgoing X longs (Bug#9498).
1136 (cons_to_x_long): New function.
1137 (lisp_data_to_selection_data): Use it. Correct the test for
1138 short-versus-long data; it was negated. Break out of vector
1139 loop, for efficiency, when a long datum is discovered.
1140
91a15bc6
SM
11412011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
1142
1143 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
1144
b41c3a35
EZ
11452011-09-16 Eli Zaretskii <eliz@gnu.org>
1146
1147 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
1148 GCC PR/17406) by declaring this function with external scope.
1149
7812ba2d
PE
11502011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1151
1152 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
1153 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
1154
cf7edc2a
AS
11552011-09-15 Andreas Schwab <schwab@linux-m68k.org>
1156
1157 * editfns.c (Fformat): Correctly handle text properties on "%%".
1158
bd01620e
EZ
11592011-09-15 Eli Zaretskii <eliz@gnu.org>
1160
1161 * xterm.c (x_draw_composite_glyph_string_foreground):
1162 * w32term.c (x_draw_composite_glyph_string_foreground):
1163 * term.c (encode_terminal_code):
1164 * composite.c (composition_update_it, get_composition_id):
1165 * xdisp.c (get_next_display_element)
1166 (fill_composite_glyph_string): Add comments about special meaning
1167 of TAB characters in a composition.
1168
a02719a3
PE
11692011-09-15 Paul Eggert <eggert@cs.ucla.edu>
1170
1171 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
1172 This occurs when processing a multibyte format.
1173 Problem reported by Wolfgang Jenker.
a02719a3 1174
72589a3c
JB
11752011-09-15 Johan Bockgård <bojohan@gnu.org>
1176
1177 * xdisp.c (try_cursor_movement): Only check for exact match if
1178 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
1179
1c14176c
PE
11802011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1181
1182 Remove unused external symbols.
1183 * dispextern.h (calc_pixel_width_or_height): Remove decl.
1184 * xdisp.c (calc_pixel_width_or_height): Now static.
1185 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
1186 * indent.c (check_display_width):
1187 * w32term.c: Fix comment to match code.
1188 * xterm.c, xterm.h (x_catching_errors): Remove.
1189
d2eea5b5
PE
11902011-09-14 Paul Eggert <eggert@cs.ucla.edu>
1191
1192 * xselect.c: Use signed conversions more consistently (Bug#9498).
1193 (selection_data_to_lisp_data): Assume incoming selection data are
1194 signed integers, not unsigned. This is to be consistent with
1195 outgoing selection data, which was modified to use signed integers
1196 in as part of the fix to Bug#9196 in response to Jan D.'s comment
1197 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
1198 expects long, not unsigned long.
1199
46888499
EZ
12002011-09-14 Eli Zaretskii <eliz@gnu.org>
1201
1202 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
1203 computation of loop end. Reported by Johan Bockgård
1204 <bojohan@gnu.org>.
1205
ef8ef9fb
CY
12062011-09-13 Chong Yidong <cyd@stupidchicken.com>
1207
1208 * frame.c (Fother_visible_frames_p): Function deleted.
1209
fa819fed
EZ
12102011-09-12 Eli Zaretskii <eliz@gnu.org>
1211
1212 * indent.c (compute_motion): Process display vector front to back
1213 rather than the other way around. (Bug#2496)
1214
2ba8e008
SM
12152011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
1216
1217 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
1218
20f53c69
CY
12192011-09-11 Chong Yidong <cyd@stupidchicken.com>
1220
1221 * minibuf.c (Fread_from_minibuffer): Doc fix.
1222
d562d7a4
EZ
12232011-09-11 Eli Zaretskii <eliz@gnu.org>
1224
1225 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
1226 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
1227
1c4d7f3d
LMI
12282011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
1229
1230 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
1231 value for non-existent files.
1232
b885bf36
EZ
12332011-09-11 Eli Zaretskii <eliz@gnu.org>
1234
1235 * fileio.c (Finsert_file_contents): If the file cannot be opened,
1236 set its "size" to -1. This will set the modtime_size field of
1237 the corresponding buffer to -1, which is what
1238 verify-visited-file-modtime expects for files that do not exist.
1239 (Bug#9139)
1240
6612f0bf
PE
12412011-09-11 Paul Eggert <eggert@cs.ucla.edu>
1242
1243 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
1244 here ...
1245 * lisp.h: ... from here. push_key_description is no longer
1246 defined in keyboard.c, so its declaration should not be in
1247 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
1248 logically belongs with push_key_description.
1249
dfb3f755
PE
12502011-09-10 Paul Eggert <eggert@cs.ucla.edu>
1251
1252 * buffer.h: Include <sys/types.h> instead of <time.h>.
1253 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
1254 Problem reported by Herbert J. Skuhra.
1255
3134906c
LMI
12562011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
1257
1258 * xml.c (parse_region): Make the parsing work for
1259 non-comment-starting XML files again (bug#9144).
1260
8d903f4e
AS
12612011-09-10 Andreas Schwab <schwab@linux-m68k.org>
1262
1263 * image.c (gif_load): Fix calculation of bottom and right corner.
1264 (Bug#9468)
1265
80ad64f4
EZ
12662011-09-10 Eli Zaretskii <eliz@gnu.org>
1267
1268 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
1269 redisplay in small windows.
1270
208a048d
EZ
12712011-09-09 Eli Zaretskii <eliz@gnu.org>
1272
1273 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
1274
9b1c252e
MR
12752011-09-08 Martin Rudalics <rudalics@gmx.at>
1276
1277 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
1278 Operate on live windows only.
1279
2949f33b
JB
12802011-09-08 Juanma Barranquero <lekktu@gmail.com>
1281
1282 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
1283
e08dcafd
EZ
12842011-09-07 Eli Zaretskii <eliz@gnu.org>
1285
1286 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
1287 only under bidi iteration.
1288
115b96bd
JD
12892011-09-07 Jan Djärv <jan.h.d@swipnet.se>
1290
1291 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
1292
c8199d0f
PE
12932011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1294
1295 isnan: Fix porting problem to Solaris 10 with bundled gcc.
1296 Without this fix, the command to link temacs failed due to an
1297 undefined symbol __builtin_isnan. This is because
1298 /usr/include/iso/math_c99.h #defines isnan(x) to
1299 __builtin_isnan(x), but the bundled gcc, which identifies itself
1300 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
1301 a __builtin_isnan.
1302 * floatfns.c (isnan): #undef, and then #define to a clone of
1303 what's in data.c.
1304 (Fisnan): Always define, since it's always available now.
1305 (syms_of_floatfns): Always define isnan at the Lisp level.
1306
e39b275c 13072011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
1308
1309 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
1310
b2db44d9 13112011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 1312
f4af5137 1313 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
1314 The previous code assumed that file offsets (off_t values) fit in
1315 EMACS_INT variables, which is not true on typical 32-bit hosts.
1316 The code messed up by falsely reporting buffer overflow in cases
1317 such as (insert-file-contents "big" nil 1 2) into an empty buffer
1318 when "big" contains more than 2**29 bytes, even though this
1319 inserts just one byte and does not overflow the buffer.
1320 (Finsert_file_contents): Store file offsets as off_t
1321 values, not as EMACS_INT values. Check for overflow when
1322 converting between EMACS_INT and off_t. When checking for
1323 buffer overflow or for overlap, take the offsets into account.
1324 Don't use EMACS_INT for small values where int suffices.
1325 When checking for overlap, fix a typo: ZV was used where
1326 ZV_BYTE was intended.
1327 (Fwrite_region): Don't assume off_t fits into 'long'.
1328 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
1329
ecfc0a49
MA
13302011-09-05 Michael Albinus <michael.albinus@gmx.de>
1331
1332 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
1333
6511acf2 13342011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 1335
0999621a 1336 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
1337
1338 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 1339 (esprintf, exprintf, evxprintf): New functions.
62f19c19 1340 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 1341 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
1342 (modify_event_symbol): Do not assume that the length of
1343 name_alist_or_stem is safe to alloca and fits in int.
1344 (Fexecute_extended_command): Likewise for function name and binding.
1345 (Frecursion_depth): Wrap around reliably on integer overflow.
1346 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
1347 since some callers pass EMACS_INT values.
1348 (Fsingle_key_description): Don't crash if symbol name contains more
1349 than MAX_ALLOCA bytes.
1350 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
1351 (get_minibuffer): Arg is now EMACS_INT, not int.
1352 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 1353 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
1354 * window.h (command_loop_level, minibuf_level): Reflect API changes.
1355
2be7d702
PE
1356 * dbusbind.c (signature_cat): New function.
1357 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
1358 Do not overrun buffer; instead, report string overflow.
1359
9d1df220
PE
1360 * dispnew.c (add_window_display_history): Don't overrun buffer.
1361 Truncate instead; this is OK since it's just a log.
1362
33ef5c64
PE
1363 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
1364 even if the time zone offset is outlandishly large.
1365 Don't mishandle offset == INT_MIN.
1366
66c6fdd5
PE
1367 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
1368 when creating daemon; the previous buffer-overflow check was incorrect.
1369
d749b01b
PE
1370 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
1371 which has the guts of the old verror function.
1372
b5cd1905
PE
1373 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
1374 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
1375
6e1a67fb
PE
1376 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
1377 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 1378 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 1379 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
1380 length of string rather than counting it via multiple sprintfs;
1381 that's simpler and more reliable.
c21721cc
PE
1382 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
1383 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
1384 sprintf, in case result does not fit in int.
1385
c57b67fc
PE
1386 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
1387 (fontset_from_font): Print it.
1388
8a401434
PE
1389 * frame.c (tty_frame_count): Now printmax_t, not int.
1390 (make_terminal_frame, set_term_frame_name): Print it.
1391 (x_report_frame_params): In X, window IDs are unsigned long,
1392 not signed long, so print them as unsigned.
1393 (validate_x_resource_name): Check for implausibly long names,
1394 and don't assume name length fits in 'int'.
1395 (x_get_resource_string): Don't blindly alloca invocation name;
1396 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
1397 not fit in int.
1398
6e1a67fb
PE
1399 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
1400 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
1401 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
1402
0df02bf3
PE
1403 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
1404 Use esprintf, not sprintf, in case result does not fit in int.
1405
48e30793
PE
1406 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1407 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
1408 it as a large positive number.
1409 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
1410 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
1411
a66ff6d8
PE
1412 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
1413 in case result does not fit in int.
1414
aca216ff
PE
1415 * print.c (float_to_string): Detect width overflow more reliably.
1416 (print_object): Make sprintf buffer a bit bigger, to avoid potential
1417 buffer overrun. Don't assume list length fits in 'int'. Treat
1418 print length of 0 as 0, not as infinity; to be consistent with other
1419 uses of print length in this function. Don't overflow print length
1420 index. Don't assume hash table size fits in 'long', or that
1421 vectorlike size fits in 'unsigned long'.
1422
31c286f7
PE
1423 * process.c (make_process): Use printmax_t, not int, to format
1424 process-name gensyms.
1425
55e5faa1
PE
1426 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
1427
80f2e268
PE
1428 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
1429 to avoid potential buffer overrun.
1430
670741ab
PE
1431 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
1432 if X resource line is longer than 512 bytes.
1433
b7163a50
PE
1434 * xfns.c (x_window): Make sprintf buffer a bit bigger
1435 to avoid potential buffer overrun.
1436
ae58ff1f
PE
1437 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
1438
c43c8a6a
PE
1439 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
1440
3f8236f4
PE
14412011-09-04 Paul Eggert <eggert@cs.ucla.edu>
1442
53e9fe90 1443 Integer overflow fixes for scrolling, etc.
6511acf2
PE
1444 Without these, Emacs silently mishandles large integers sometimes.
1445 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
1446 it were "C-u 1 M-x recenter" on a typical 64-bit host.
1447
6511acf2
PE
1448 * xdisp.c (try_window_id): Check Emacs fixnum range before
1449 converting to 'int'.
806add1d 1450
6511acf2 1451 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
1452 Check that an Emacs fixnum is in range before assigning it to 'int'.
1453 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
1454 values converted from Emacs fixnums.
1455 (Frecenter): Don't wrap around a line count if it is out of 'int'
1456 range; instead, treat it as an extreme value.
1457 (Fset_window_configuration, compare_window_configurations):
1458 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
1459
6511acf2
PE
1460 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
1461 that can exceed INT_MAX. Check that EMACS_INT value is in range
1462 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
1463 (match_limit): Don't assume that a fixnum can fit in 'int'.
1464
6511acf2 1465 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
1466 exceed INT_MAX.
1467
6511acf2 1468 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
1469 (Fvertical_motion): Don't wrap around LINES values that don't fit
1470 in 'int'. Instead, treat them as extreme values. This is good
1471 enough for windows, which can't have more than INT_MAX lines anyway.
1472
fcb901a7
LMI
14732011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1474
0f2f6b6d
LMI
1475 * Require libxml/parser.h to avoid compilation warning.
1476
fcb901a7
LMI
1477 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
1478
1479 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
1480 since this reportedly can destroy thread storage.
1481
6e20a0d4
CY
14822011-08-30 Chong Yidong <cyd@stupidchicken.com>
1483
1484 * syntax.c (find_defun_start): Update all cache variables if
1485 exiting early (Bug#9401).
1486
148ae00e
EZ
14872011-08-30 Eli Zaretskii <eliz@gnu.org>
1488
f6cfbd8f
EZ
1489 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
1490
148ae00e
EZ
1491 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
1492 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
1493 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
1494
1495 * term.c (tty_append_glyph): New function.
1496 (produce_stretch_glyph): Static function and its prototype deleted.
1497
a66cfb1c
SM
1498 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
1499 Add prototypes.
148ae00e 1500
c4a07a4c
PE
15012011-08-29 Paul Eggert <eggert@cs.ucla.edu>
1502
1503 * image.c (parse_image_spec): Check for nonnegative, not for positive,
1504 when checking :margin (Bug#9390).
1505 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 1506 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
1507 so that the name doesn't mislead. All uses changed.
1508
6bc8cd65
JB
15092011-08-28 Johan Bockgård <bojohan@gnu.org>
1510
1511 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
1512 set_tty_hooks.
1513
dca4927e
EZ
15142011-08-27 Eli Zaretskii <eliz@gnu.org>
1515
1516 * xdisp.c (move_it_to): Don't bail out early when reaching
1517 position beyond to_charpos, if we are scanning backwards.
1518 (move_it_vertically_backward): When DY == 0, make sure we get to
1519 the first character in the line after the newline.
1520
f2cad773
PE
15212011-08-27 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * ccl.c: Improve and simplify overflow checking (Bug#9196).
1524 (ccl_driver): Do not generate an out-of-range pointer.
1525 (Fccl_execute_on_string): Remove unnecessary check for
1526 integer overflow, noted by Stefan Monnier in
1527 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
1528 Remove a FIXME that didn't need fixing.
1529 Simplify the newly-introduced buffer reallocation code.
1530
0cae2cdb
JB
15312011-08-27 Juanma Barranquero <lekktu@gmail.com>
1532
1533 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
1534
5fc295a4 15352011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 1536
70c60eb2 1537 Integer and memory overflow issues (Bug#9196).
726e0ab1 1538
d31850da
PE
1539 * doc.c (get_doc_string): Rework so that
1540 get_doc_string_buffer_size is the actual buffer size, rather than
1541 being 1 less than the actual buffer size; this makes xpalloc more
1542 convenient.
1543
a69fbedb
PE
1544 * image.c (x_allocate_bitmap_record, cache_image):
1545 * xselect.c (Fx_register_dnd_atom):
1546 Simplify previous changes by using xpalloc.
1547
fe5c5d37
PE
1548 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
1549 since either will do and ptrdiff_t is convenient with xpalloc.
1550
0065d054
PE
1551 * charset.c (charset_table_size)
1552 (struct charset_sort_data.priority): Now ptrdiff_t.
1553 (charset_compare): Don't overflow if priorities differ greatly.
1554 (Fsort_charsets): Don't assume list length fits in int.
1555 Check for size-calculation overflow when allocating sort data.
1556 (syms_of_charset): Allocate an initial charset table that is
1557 just under 64 KiB, to avoid problems with glibc malloc and mmap.
1558
1559 * cmds.c (internal_self_insert): Check for size-calculation overflow.
1560
1561 * composite.h (struct composition.glyph_len): Now int, not unsigned.
1562 The actual value is always <= INT_MAX, and leaving it unsigned made
1563 overflow checking harder.
1564
1565 * dispextern.h (struct glyph_matrix.rows_allocated)
1566 (struct face_cache.size): Now ptrdiff_t, for convenience in use
1567 with xpalloc. The values are still always <= INT_MAX.
1568
1569 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
1570
1571 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
1572 (SAFE_NALLOCA): New macro.
1573
1574 * region-cache.c (struct boundary.pos, find_cache_boundary)
1575 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
1576 (set_cache_region, invalidate_region_cache)
1577 (revalidate_region_cache, know_region_cache, region_cache_forward)
1578 (region_cache_backward, pp_cache):
1579 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
1580 so that ptrdiff_t * can be passed to xpalloc.
1581 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
1582 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
1583 (pp_cache): Don't assume cache_len fits in int.
1584 * region-cache.h: Adjust extern decls to match.
1585
1586 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
1587 EMACS_INT, since either will do, for xpalloc.
1588
1589 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
1590 (xnmalloc, xnrealloc, xpalloc): New functions.
1591
726e0ab1
PE
1592 * bidi.c (bidi_shelve_header_size): New constant.
1593 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
1594 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
1595
51f30bc5 1596 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
1597 * buffer.c (overlays_at, overlays_in, record_overlay_string)
1598 (overlay_strings):
1599 Don't update size of array until after memory allocation succeeds,
1600 because xmalloc/xrealloc may not return.
0065d054
PE
1601 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
1602 now that we have proper integer overflow checking.
1603 (record_overlay_string, overlay_strings): Catch overflows when
1604 calculating size of overlay_str_buf.
726e0ab1 1605
0065d054
PE
1606 * callproc.c (Fcall_process): Check for size overflow when
1607 calculating size of args2.
1608 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
1609 Normally we prefer signed values, but sticking with ptrdiff_t would
1610 require adding more-complicated checks.
726e0ab1
PE
1611
1612 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
1613 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
1614 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 1615 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
1616
1617 * character.c (Fstring): Check for size-calculation overflow.
1618
1619 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
1620 unnecessary integer overflow. Check for size overflow.
1621 (encode_coding_object): Don't update size until xmalloc succeeds.
1622
1623 * composite.c (get_composition_id): Check for overflow in glyph
1624 length calculations.
1625
1626 Integer and memory overflow fixes for display code.
1627 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
1628 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
1629 (scrolling_window): Check for overflow in size calculations.
1630 (line_draw_cost, realloc_glyph_pool, add_row_entry):
1631 Don't assume glyph table len fits in int.
1632 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
1633 (row_table_size): Now ptrdiff_t, not int.
1634 (scrolling_window): Avoid overflow in size calculations.
1635 Don't update size until allocation succeeds.
1636 * fns.c (concat): Check for overflow in size calculations.
1637 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
1638 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1639 (NEXT_ALMOST_PRIME_LIMIT): New constant.
1640
1641 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
1642 (get_doc_string): Check for size calculation overflow.
1643 Don't update size until allocation succeeds.
1644 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
1645 EMACS_INT, where ptrdiff_t will do.
1646 (Fsubstitute_command_keys): Check for string overflow.
1647
1648 * editfns.c (set_time_zone_rule): Don't assume environment length
1649 fits in int.
1650 (message_length): Now ptrdiff_t, not int.
1651 (Fmessage_box): Don't update size until allocation succeeds.
1652 Don't assume message length fits in int.
1653 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
1654
0065d054
PE
1655 * emacs.c (main): Do not reallocate argv, since there is a null at
1656 the end that can be overwritten, and this way there's no need to
1657 worry about size-calculation overflow.
1658 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
1659
1660 * eval.c (init_eval_once, grow_specpdl): Don't update size until
1661 alloc succeeds.
1662 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
1663
1664 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
1665 (x_set_scroll_bar_width, x_figure_window_size):
1666 Check for integer overflow.
1667 (x_set_alpha): Do not assume XINT fits in int.
1668
1669 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
1670 This is for the members text_lines, text_cols, total_lines, total_cols,
1671 where the system imposes an 'int' limit.
1672
1673 * fringe.c (Fdefine_fringe_bitmap):
1674 Don't update size until alloc works.
1675
1676 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
1677 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
1678
1679 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
1680 Check for size-calculation overflow.
1681 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
1682 do, as we prefer signed integers.
1683 (id_to_widget.max_size, id_to_widget.used)
1684 (xg_store_widget_in_map, xg_remove_widget_from_map)
1685 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
1686 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
1687 Use and return ptrdiff_t, not int.
1688 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
1689 * gtkutil.h: Change prototypes to match the above.
1690
1691 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
1692 are duplicate now that they've been promoted to lisp.h.
1693 (x_allocate_bitmap_record, x_alloc_image_color)
1694 (make_image_cache, cache_image, xpm_load):
1695 Don't update size until alloc is done.
1696 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
1697 (x_detect_edges):
3256efce 1698 Check for size calculation overflow.
726e0ab1
PE
1699 (ct_colors_allocated_max): New constant.
1700 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
1701 overflow.
3256efce 1702
726e0ab1
PE
1703 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
1704 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
1705 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
1706 Use ptrdiff_t, not int, to count maps.
1707 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
1708 calculations. Don't update size until allocation succeeds.
1709 Redo calculations to avoid overflow.
726e0ab1
PE
1710 * keyboard.h: Change prototypes to match the above.
1711
1712 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
1713 to count maps.
1714 (current_minor_maps): Check for size calculation overflow.
1715 * keymap.h: Change prototypes to match the above.
1716
1717 * lread.c (read1, init_obarray): Don't update size until alloc done.
1718
1719 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
1720 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
1721
726e0ab1
PE
1722 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
1723 Now ptrdiff_t, not int.
1724 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
1725 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
1726
1727 * process.c (Fnetwork_interface_list): Check for overflow
1728 in size calculation.
1729
1730 * region-cache.c (move_cache_gap): Check for size calculation overflow.
1731
1732 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
1733 overflow. Don't bother calling xmalloc when xrealloc will do.
1734
1735 * search.c (Freplace_match): Check for size calculation overflow.
1736 (Fset_match_data): Don't assume list lengths fit in 'int'.
1737
1738 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
1739 for command line length. Do not attempt to address one before the
1740 beginning of an array, as that's not portable.
1741
1742 * term.c (max_frame_lines): Remove; unused.
1743 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
1744 not int.
1745 (encode_terminal_code, calculate_costs): Check for size
1746 calculation overflow.
1747 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
1748 table lengths and related sizes. Don't update size until alloc
1749 done. Redo calculations to avoid overflow.
1750 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
1751
1752 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
1753 subtracting pointers.
1754 (gobble_line): Check for overflow more carefully. Don't update size
1755 until alloc done.
1756
1757 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
1758 Don't update size until alloc done.
1759 Redo size calculations to avoid overflow.
1760 Check for size calculation overflow.
0065d054 1761 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
1762
1763 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
1764 Use ptrdiff_t, not int, for sizes.
1765 (store_mode_line_noprop_char): Don't update size until alloc done.
1766
0065d054
PE
1767 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
1768 Use ptrdiff_t, not int, for sizes.
1769 (Finternal_make_lisp_face, cache_face):
1770 Check for size calculation overflow.
1771 (cache_face): Treat size calculation overflows as if they were
1772 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
1773
1774 * xfns.c (x_encode_text, x_set_name_internal)
1775 (Fx_change_window_property): Use ptrdiff_t, not int, to count
1776 sizes, since they can exceed INT_MAX in size. Check for size
1777 calculation overflow.
1778
0065d054
PE
1779 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
1780 (xg_select): Check for size calculation overflow.
726e0ab1
PE
1781 Don't update size until alloc done.
1782
0065d054 1783 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 1784 as sprintf is limited to int lengths.
1d526e2f 1785
252c5ee1
PE
1786 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
1787 (X_LONG_MIN): New macros.
864d7ce7
PE
1788 Use them to make the following changes clearer.
1789 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
1790 This change doesn't affect the value now, but it may help remind
1791 future maintainers not to raise the value too much later.
1792 (SELECTION_QUANTUM): Remove, replacing with ...
1793 (selection_quantum): ... new function, which avoids overflow.
1794 All uses changed.
1795 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
1796 assumption that selection length fits in 'int'.
1797 (x_reply_selection_request, x_handle_selection_request)
1798 (x_get_window_property, receive_incremental_selection)
1799 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
1800 (lisp_data_to_selection_data, clean_local_selection_data):
1801 Use ptrdiff_t, not int, to record length of selection.
1802 (x_reply_selection_request, x_get_window_property)
1803 (receive_incremental_selection, x_property_data_to_lisp):
1804 Redo calculations to avoid overflow.
1805 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 1806 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
1807 something.
1808 (x_get_window_property, receive_incremental_selection)
1809 (lisp_data_to_selection_data, x_property_data_to_lisp):
1810 Check for size-calculation overflow.
1811 (x_get_window_property, receive_incremental_selection)
1812 (lisp_data_to_selection_data, Fx_register_dnd_atom):
1813 Don't store size until memory allocation succeeds.
1814 (x_get_window_property): Plug memory leak on memory exhaustion.
1815 Don't double-block input; malloc is safe here. Don't assume 2**34
1816 - 4 fits in unsigned long. Add an xassert to check
1817 XGetWindowProperty overflow. Be more careful about overflow
1818 calculations, and distinguish size from memory overflow better.
1819 (receive_incremental_selection): When tracing, don't assume
1820 unsigned int is less than INT_MAX.
1821 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
1822 harmful) conversions of unsigned short to int.
1823 (lisp_data_to_selection_data): Don't assume that integers
1824 in the range -65535 through -1 fit in an X unsigned short.
1825 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
1826 result parameters unless successful. Rely on cons_to_unsigned
1827 to report problems with elements; the old code wasn't right anyway.
1828 (x_check_property_data): Check for int overflow; we cannot use
1829 a wider type due to X limits.
1830 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
1831
726e0ab1 1832 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 1833
0065d054
PE
1834 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
1835 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
1836 (x_color_cells): Don't store size until memory allocation succeeds.
1837 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 1838 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
1839 (x_term_init): Don't assume length fits in int (sprintf is limited
1840 to int size).
bc18e09d 1841
ebfa62c0
PE
1842 Use ptrdiff_t for composition IDs.
1843 * character.c (lisp_string_width):
1844 * composite.c (composition_table_size, n_compositions)
1845 (get_composition_id, composition_gstring_from_id):
1846 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
1847 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
1848 * window.c (Frecenter):
1849 Use ptrdiff_t, not int, for composition IDs.
1850 * composite.c (get_composition_id): Check for integer overflow.
1851 * composite.h: Adjust prototypes to match the above changes.
1852
d3411f89
PE
1853 Use ptrdiff_t for hash table indexes.
1854 * category.c (hash_get_category_set):
1855 * ccl.c (ccl_driver):
1856 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
1857 * coding.c (coding_system_charset_list, detect_coding_system):
1858 * coding.h (struct coding_system.id):
1859 * composite.c (get_composition_id, gstring_lookup_cache):
1860 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
1861 * image.c (xpm_get_color_table_h):
1862 * lisp.h (hash_lookup, hash_put):
1863 * minibuf.c (Ftest_completion):
1864 Use ptrdiff_t for hash table indexes, not int (which is too
1865 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
1866 32-bit --with-wide-int hosts).
1867
e097a6fa
PE
1868 * charset.c (Fdefine_charset_internal): Check for integer overflow.
1869 Add a FIXME comment about memory leaks.
1870 (syms_of_charset): Don't assume xmalloc returns.
1871
5637687f
PE
1872 Don't assume that stated character widths fit in int.
1873 * character.c (Fchar_width, c_string_width, lisp_string_width):
1874 * character.h (CHAR_WIDTH):
1875 * indent.c (MULTIBYTE_BYTES_WIDTH):
1876 Use sanitize_char_width to avoid undefined and/or bad behavior
1877 with outlandish widths.
a66cfb1c 1878 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
1879 now that we have two such functions. All uses changed.
1880 (sanitize_char_width): New inline function.
1881
a2271ba2
PE
1882 Don't assume that tab-width fits in int.
1883 * character.h (sanitize_width): New inline function.
1884 (SANE_TAB_WIDTH): New macro.
1885 (ASCII_CHAR_WIDTH): Use it.
1886 * indent.c (sane_tab_width): Remove. All uses replaced by
1887 SANE_TAB_WIDTH (current_buffer).
1888 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
1889
18c52557
PE
1890 * fileio.c: Integer overflow issues with file modes.
1891 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
1892
caeeedc1
PE
1893 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
1894 Remove unreachable code.
1895 (read_hex, load_charset_map_from_file): Check for integer overflow.
1896
50849c52
PE
1897 * xterm.c: don't go over XClientMessageEvent limit
1898 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
1899 (x_send_scroll_bar_event): Likewise. Check that the size does not
1900 exceed limits imposed by XClientMessageEvent, as well as the usual
1901 ptrdiff_t and size_t limits.
1902
b13995db
PE
1903 * keyboard.c: Overflow, signedness and related fixes.
1904 (make_lispy_movement): Use same integer type in forward decl
1905 that is used in the definition.
1906 (read_key_sequence, keyremap_step):
1907 Change bufsize argument back to int, undoing my 2011-03-30 change.
1908 We prefer signed types, and int is wide enough here.
1909 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
1910 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
1911 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
1912 length, not size_t. Use ptrdiff_t for index, not int.
1913 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
1914 possibility of integer overflow.
1915
13464394
PE
1916 Overflow, signedness and related fixes for images.
1917
1918 * dispextern.h (struct it.stack[0].u.image.image_id)
1919 (struct_it.image_id, struct image.id, struct image_cache.size)
1920 (struct image_cache.used, struct image_cache.ref_count):
1921 * gtkutil.c (update_frame_tool_bar):
1922 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
1923 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
1924 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
1925 * nsmenu.m (update_frame_tool_bar):
1926 * xdisp.c (calc_pixel_width_or_height):
1927 * xfns.c (image_cache_refcount):
1928 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
1929 on typical 64-bit hosts.
1930
1931 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
1932 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
1933 Omit unnecessary casts to int.
1934 (parse_image_spec): Check that integers fall into 'int' range
1935 when the callers expect that.
1936 (image_ascent): Redo ascent calculation to avoid int overflow.
1937 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
1938 (lookup_image): Remove unnecessary tests.
1939 (xbm_image_p): Locals are now of int, not EMACS_INT,
1940 since parse_image_check makes sure they fit into int.
1941 (png_load, gif_load, svg_load_image):
1942 Prefer int to unsigned where either will do.
1943 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
1944 old tiff_error_handler and tiff_warning_handler.
1945 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
1946 stack buffer overflows. It uses only the features of vsnprintf
1947 that are common to both POSIX and native Microsoft.
1948 (tiff_error_handler, tiff_warning_handler): Use it.
1949 (tiff_load, gif_load, imagemagick_load_image):
1950 Don't assume :index value fits in 'int'.
1951 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
1952 (imagemagick_load_image): Check that crop parameters fit into
1953 the integer types that MagickCropImage accepts. Don't assume
1954 Vimagemagick_render_type has a nonnegative value. Don't assume
1955 size_t fits in 'long'.
1956 (gs_load): Use printmax_t to print the widest integers possible.
1957 Check for integer overflow when computing image height and width.
1958
c11821d4
EZ
19592011-08-26 Eli Zaretskii <eliz@gnu.org>
1960
1961 * xdisp.c (redisplay_window): Don't force window start if point
1962 will be invisible in the resulting window. (Bug#9324)
1963
0c95fcf7
EZ
19642011-08-25 Eli Zaretskii <eliz@gnu.org>
1965
1966 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
1967 the display spec is of the form `(space ...)'.
1968 (handle_display_spec): Return the value returned by
1969 handle_single_display_spec, not just 1 or zero.
1970 (handle_single_display_spec): If the display spec is of the form
1971 `(space ...)', and specifies display in the text area, return 2
1972 rather than 1.
fee65a97 1973 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
1974 accurately, and prefer exact match for point under bidi.
1975 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
1976
1977 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
1978 into disp_prop; all users changed.
1979
1980 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
1981 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
1982 for the text covered by the display property.
1983
e4ed06f1
CY
19842011-08-25 Chong Yidong <cyd@stupidchicken.com>
1985
1986 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
1987 Change return value to nil.
1988 (Frecord_buffer): Delete unused function.
1989
f67cdd7f
EZ
19902011-08-24 Eli Zaretskii <eliz@gnu.org>
1991
5980d4c6
EZ
1992 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
1993 buffers, return left-to-right.
8610fe8b
EZ
1994 (set_cursor_from_row): Consider candidate row a win if its glyph
1995 represents a newline and point is on that newline. Fixes cursor
1996 positioning on the newline at EOL of R2L text within L2R
1997 paragraph, and vice versa.
1998 (try_cursor_movement): Check continued rows, in addition to
1999 continuation rows. Fixes unwarranted scroll when point enters a
2000 continued line of R2L text within an L2R paragraph, or vice versa.
2001 (cursor_row_p): Consider the case of point being equal to
2002 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
2003 from the end of a short line to the beginning of a continued line
2004 of R2L text within L2R paragraph.
2005 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
2006 composed characters.
5980d4c6 2007
f67cdd7f
EZ
2008 * bidi.c (bidi_check_type): Use xassert.
2009 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
2010 members.
2011
bca633fb
EZ
20122011-08-23 Eli Zaretskii <eliz@gnu.org>
2013
2014 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
2015 a character.
2016
4a5885a7
CY
20172011-08-23 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * nsfont.m (ns_otf_to_script): Fix typo.
2020
0902a04e
KH
20212011-08-22 Kenichi Handa <handa@m17n.org>
2022
2023 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
2024 extra slot even if the purpose is char-code-property-table.
2025
1a2e6670
EZ
20262011-08-23 Eli Zaretskii <eliz@gnu.org>
2027
8ddde651
EZ
2028 * xdisp.c (redisplay_window): When computing centering_position,
2029 account for the height of the header line. (Bug#8874)
2030
425cc014
EZ
2031 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
2032 instead of CHAR_TO_BYTE. Fixes a crash when a completion
2033 candidate is selected by the mouse, and that candidate has a
2034 composed character under the mouse.
2035
1a2e6670
EZ
2036 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
2037 coordinates reported by pos-visible-in-window-p for a composed
2038 character in column zero.
2039
8b76d6f8
SM
20402011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
2041
2042 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
2043
dac347dd
EZ
20442011-08-22 Eli Zaretskii <eliz@gnu.org>
2045
2046 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
2047 consider it a hit if to_charpos is anywhere in the range of the
2048 composed buffer positions.
2049
e013fb34
CY
20502011-08-22 Chong Yidong <cyd@stupidchicken.com>
2051
2052 * image.c (gif_load): Don't assume that each subimage has the same
2053 dimensions as the base image. Handle disposal method that is
2054 "undefined" by the gif spec (Bug#9335).
2055
bd1ba3e8
CY
20562011-08-20 Chong Yidong <cyd@stupidchicken.com>
2057
2058 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 2059 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 2060
54a1215b
EZ
20612011-08-19 Eli Zaretskii <eliz@gnu.org>
2062
823564e5
EZ
2063 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
2064 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
2065 from an Org mode buffer to a Speedbar frame.
2066
54a1215b
EZ
2067 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
2068 a composition, take its buffer position from IT->cmp_it.charpos.
2069 Fixes cursor positioning at the beginning of a line that begins
2070 with a composed character.
2071
9778ebcc
EZ
20722011-08-18 Eli Zaretskii <eliz@gnu.org>
2073
0be6ee06
EZ
2074 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
2075 character bidirectional type, use STRONG_L instead. Fixes crashes
2076 in a buffer produced by `describe-categories'.
2077
9778ebcc
EZ
2078 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
2079 members before the level stack, so they would be saved and
2080 restored when copying iterator state. Fixes incorrect reordering
2081 around TABs covered by display properties.
2082
156bffbe
AS
20832011-08-18 Andreas Schwab <schwab@linux-m68k.org>
2084
6b02f655 2085 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 2086
72ad093b
CY
20872011-08-17 Chong Yidong <cyd@stupidchicken.com>
2088
2089 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
2090 (internal_condition_case_2, internal_condition_case_n):
2091 Remove unnecessary aborts (Bug#9081).
72ad093b 2092
35774242
EZ
20932011-08-17 Eli Zaretskii <eliz@gnu.org>
2094
2095 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
2096 has no `load' handler, try opening the file locally. (Bug#9311)
2097
db76dd85
KB
20982011-08-16 Ken Brown <kbrown@cornell.edu>
2099
2100 * gmalloc.c: Expand comment.
2101
b215eee5
EZ
21022011-08-16 Eli Zaretskii <eliz@gnu.org>
2103
2104 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
2105 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
2106
a4579d33
KB
21072011-08-16 Ken Brown <kbrown@cornell.edu>
2108
2109 Fix memory allocation problems in Cygwin build (Bug#9273).
2110
2111 * unexcw.c ( __malloc_initialized): Declare external variable.
2112 (fixup_executable): Force the dumped emacs to reinitialize malloc.
2113
8b76d6f8
SM
2114 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
2115 New variables.
a4579d33
KB
2116 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
2117 dumped emacs.
2118 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
2119 in the static heap.
2120 [CYGWIN] (special_realloc): New function.
2121 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
2122 requests to realloc storage in the static heap.
2123
3ebec551
PE
21242011-08-15 Paul Eggert <eggert@cs.ucla.edu>
2125
2126 * bidi.c (bidi_initialize): Remove unused local.
2127
9fd8be00
EZ
21282011-08-15 Eli Zaretskii <eliz@gnu.org>
2129
6b02f655
SM
2130 * bidimirror.h:
2131 * biditype.h: Remove file.
2132 * makefile.w32-in ($(BLD)/bidi.$(O)):
2133 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
2134
2135 * dispextern.h: Fix a typo in the comment to bidi_type_t.
2136
2137 * chartab.c: Improve commentary for the uniprop_table API.
2138
32413314
EZ
2139 * bidi.c (bidi_paragraph_init): Support zero value of
2140 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
2141 (bidi_initialize): Use uniprop_table instead of including
2142 biditype.h and bidimirror.h.
32413314 2143
9fd8be00
EZ
2144 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
2145 coordinates of the iterator when restoring from ppos_it.
2146 (Bug#9296)
2147
5cf2b69b
KH
21482011-08-14 Kenichi Handa <handa@m17n.org>
2149
2150 * process.c (create_process): Call setup_process_coding_systems
72ad093b 2151 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 2152
daf17d00
EZ
21532011-08-14 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xdisp.c (move_it_in_display_line_to): Don't invoke
2156 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
2157 ppos_it. Fixes vertical cursor motion when line beginning is
2158 covered by an image. (Bug#9296)
2159
08e3161a
JD
21602011-08-14 Jan Djärv <jan.h.d@swipnet.se>
2161
2162 * nsterm.h (ns_run_ascript): Declare.
2163 (NSAPP_DATA2_RUNASSCRIPT): Define.
2164
2165 * nsfns.m (as_script, as_result, as_status): New static variables.
2166 (ns_run_ascript): New function.
5e617bc2 2167 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
2168 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
2169 the event loop. Get status from as_status (Bug#7276).
2170
2171 * nsterm.m (sendEvent): If event is NSApplicationDefined and
2172 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
2173 the event loop (Bug#7276).
2174
a3720aa2
AS
21752011-08-14 Andreas Schwab <schwab@linux-m68k.org>
2176
2177 * gnutls.c (QCgnutls_bootprop_priority)
2178 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
2179 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
2180 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
2181 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
2182 (QCgnutls_bootprop_verify_hostname_error)
2183 (QCgnutls_bootprop_callbacks_verify): Rename from
2184 Qgnutls_bootprop_..., all uses changed.
2185
2186 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
2187 uses changed.
2188
0a0d27fb
PE
21892011-08-14 Paul Eggert <eggert@cs.ucla.edu>
2190
19d5c50c
PE
2191 * xfaces.c (Qframe_set_background_mode): Now static.
2192 * dispextern.h (Qframe_set_background_mode): Remove decl.
2193
0a0d27fb
PE
2194 * process.c (Fnetwork_interface_info): Declare local only if needed.
2195
377538cb
JD
21962011-08-13 Jan Djärv <jan.h.d@swipnet.se>
2197
2198 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
2199 (Fnetwork_interface_list): Allocate in increments of bytes instead
2200 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
2201 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
2202 sockaddr.
2203 (struct ifflag_def): notrailers is smart on OSX.
2204 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
2205 Get hardware address with getifaddrs if available.
2206
08fff70c
EZ
22072011-08-12 Eli Zaretskii <eliz@gnu.org>
2208
2209 * xdisp.c (iterate_out_of_display_property): xassert that
2210 IT->position is set to within IT->object's boundaries. Break from
2211 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
2212 when IT->position is set up wrongly due to some bug.
2213 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
2214 (push_display_prop): Allow GET_FROM_STRING as IT->method on
2215 entry. Force push_it to save on the stack the current
2216 buffer/string position, to be restored by pop_it. Fix flags in
2217 the iterator structure wrt the object coming from a display
2218 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
2219 properties. (Bug#9284)
2220
7be1c708 22212011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 2222
7be1c708
CY
2223 * fontset.c (fontset_get_font_group): Add proper type checks.
2224 (Bug#9172)
aac0c6e3 2225
7be1c708 22262011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 2227
7be1c708
CY
2228 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
2229 and LC_VERSION_MIN_MACOSX.
2230 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
2231 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 2232
97bb72a6
EZ
22332011-08-08 Eli Zaretskii <eliz@gnu.org>
2234
2235 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
2236 no-display-properties-and-no-overlays under bidi display.
2237 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 2238 properties and overlays.
97bb72a6 2239
d5617611
CY
22402011-08-08 Chong Yidong <cyd@stupidchicken.com>
2241
37e11a63
CY
2242 * editfns.c (Fset_time_zone_rule): Document relationship with the
2243 setenv function.
2244
d5617611
CY
2245 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
2246 the font entity extracted from the cache (Bug#8109).
2247
58872834
CY
22482011-08-07 Chong Yidong <cyd@stupidchicken.com>
2249
2250 * composite.c (autocmp_chars): Don't reset point. That is done by
2251 restore_point_unwind (Bug#5984).
2252
75bfc667
JL
22532011-08-07 Juri Linkov <juri@jurta.org>
2254
2255 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
2256 to show the arg `TIME' instead of `TIMEVAL'.
2257
d1410150
EZ
22582011-08-06 Eli Zaretskii <eliz@gnu.org>
2259
2260 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
2261 display property strides EOL and includes a newline, as in
2262 longlines-mode. (Bug#9254)
75b771e4
EZ
2263 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
2264 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
2265
2266 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
2267 is non-zero, even if the data buffer is NULL. Fixes a crash in
2268 vertical-motion with longlines-mode. (Bug#9254)
2269
35928349
EZ
22702011-08-05 Eli Zaretskii <eliz@gnu.org>
2271
ec7cc85b
EZ
2272 * bidi.c <bidi_cache_total_alloc>: Now static.
2273 (bidi_initialize): Initialize bidi_cache_total_alloc.
2274
8b76d6f8 2275 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
2276 cache. (Bug#9221)
2277
2278 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
2279 amount allocated this far in `bidi_cache_total_alloc'.
2280 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
2281 non-zero, only free the data buffer without restoring the cache
2282 contents. All callers changed.
2283
2284 * dispextern.h (bidi_unshelve_cache): Update prototype.
2285
2286 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
2287 (move_it_in_display_line, move_it_to)
2288 (move_it_vertically_backward, move_it_by_lines): Replace the call
2289 to xfree to an equivalent call to bidi_unshelve_cache.
2290 (move_it_in_display_line_to): Fix logic of returning
412b6358 2291 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 2292
e2e2423b
EZ
22932011-08-05 Eli Zaretskii <eliz@gnu.org>
2294
2295 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
2296 came from a string character with a `cursor' property. (Bug#9229)
2297
ae9e757a
JD
22982011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2299
2300 * Makefile.in (LIB_PTHREAD): New variable.
2301 (LIBES): Add LIB_PTHREAD (Bug#9216).
2302
2303 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
2304 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
2305
213bd7f2
AS
23062011-08-04 Andreas Schwab <schwab@linux-m68k.org>
2307
6b02f655 2308 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 2309
99aaf75f
JD
23102011-08-04 Jan Djärv <jan.h.d@swipnet.se>
2311
2312 * xterm.c (x_find_topmost_parent): New function.
2313 (x_set_frame_alpha): Find topmost parent window with
2314 x_find_topmost_parent and set the property there also (bug#9181).
2315 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
2316
c74e9d86
PE
23172011-08-04 Paul Eggert <eggert@cs.ucla.edu>
2318
2319 * callproc.c (Fcall_process): Avoid vfork clobbering
2320 the local vars buffer, coding_systems, current_dir.
2321
640c8776
SM
23222011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
2323
2324 * keymap.c (Fmake_composed_keymap): Move to subr.el.
2325
f26d0e4c
PE
23262011-08-03 Paul Eggert <eggert@cs.ucla.edu>
2327
8a10d76c
PE
2328 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
2329 so that it is not optimized away.
2330
f26d0e4c
PE
2331 * xdisp.c (compute_display_string_pos): Remove unused local.
2332
55439c61
EZ
23332011-08-02 Eli Zaretskii <eliz@gnu.org>
2334
2335 Fix slow cursor motion and scrolling in large buffers with
2336 selective display, like Org Mode buffers. (Bug#9218)
2337
2338 * dispextern.h (struct bidi_it): New member disp_prop_p.
2339
2340 * xdisp.c: Remove one-slot cache of display string positions.
2341 (compute_display_string_pos): Accept an additional argument
5e617bc2 2342 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
2343 for a display string or property. If found, set DISP_PROP_P
2344 non-zero.
2345
2346 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
2347 DISP_PROP_P, and pass it to compute_display_string_pos.
2348 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
2349 non-zero. All callers of bidi_fetch_char changed.
2350
fb33fa43
SM
23512011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
2352
2353 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
2354
b099e063
DM
23552010-12-03 Don March <don@ohspite.net>
2356
2357 * keymap.c (Fdefine_key): Fix non-prefix key error message when
2358 last character M-[char] is translated to ESC [char] (bug#7541).
2359
5cc7f7af
KH
23602011-08-02 Kenichi Handa <handa@m17n.org>
2361
d0fffa3f 2362 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
2363
2364 * chartab.c (uniprop_table): Make it non-static.
2365
525d5e6e
EZ
23662011-08-01 Eli Zaretskii <eliz@gnu.org>
2367
2368 * xdisp.c (forward_to_next_line_start): Accept additional argument
2369 BIDI_IT_PREV, and store into it the state of the bidi iterator had
2370 on the newline.
2371 (reseat_at_next_visible_line_start): Use the bidi iterator state
2372 returned by forward_to_next_line_start to restore the state of
2373 it->bidi_it after backing up to previous newline. (Bug#9212)
2374
31011111
AS
23752011-07-30 Andreas Schwab <schwab@linux-m68k.org>
2376
2377 * regex.c (re_comp): Protoize.
2378 (re_exec): Fix return type.
2379 (regexec): Fix type of `ret'. (Bug#9203)
2380
476371c4
PE
23812011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2382
e5d76069
PE
2383 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
2384 This is needed if max-image-size is a floating-point number.
2385
9a79b20c
AS
23862011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2387
2388 * print.c (print_object): Print empty symbol as ##.
2389
2390 * lread.c (read1): Read ## as empty symbol.
2391
d8c2fa78
AA
23922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
2393
2394 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
2395 setting frame foreground color (Bug#9175).
2396 (x_set_background_color): Likewise.
2397
ffe57a7a
AA
2398 * nsmenu.m (-setText): Size tooltip dimensions precisely to
2399 contents (Bug#9176).
2400 (EmacsTooltip -init): Remove bezels and add shadows to
2401 tooltip windows.
2402
bf3492a5
AA
2403 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
2404 or scroll bar (Bug#8470).
2405
d55e9c53
AA
2406 * nsfont.m (nsfont_open): Remove assignment to voffset and
2407 unnecessary vars hshink, expand, hd, full_height, min_height.
2408 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
2409
2410 * nsterm.h (nsfont_info): Remove voffset field.
2411
d8c2fa78 24122011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
2413
2414 Implement strike-through and overline on NextStep (Bug#8863).
2415
2416 * nsfont.m (nsfont_open): Use underline position provided by font,
2417 instead of hard-coded value of 2.
2418 (nsfont_draw): Call ns_draw_text_decoration instead.
2419
2420 * nsterm.h: Add declaration for ns_draw_text_decoration.
2421
2422 * nsterm.m (ns_draw_text_decoration): New function for drawing
2423 underline, overline, and strike-through.
2424 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
2425 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 2426 accommodate underlining, etc.
4843aac3 2427
4cc60b9b
EZ
24282011-07-28 Eli Zaretskii <eliz@gnu.org>
2429
bc7ece87
EZ
2430 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
2431 default.
4cc60b9b 2432
476371c4
PE
24332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2434
66606eea
PE
2435 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
2436 Without this fix, if a signal arrives just after memory fills up,
2437 'malloc' might be invoked reentrantly.
2438
476371c4
PE
2439 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
2440 In other words, assume that every image size is allowed, on non-X
2441 hosts. This assumption is probably wrong, but it lets Emacs compile.
2442
f3fcc40d
AS
24432011-07-28 Andreas Schwab <schwab@linux-m68k.org>
2444
2445 * regex.c (re_iswctype): Convert return values to boolean.
2446
350c992f
EZ
24472011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
2448
2449 * xdisp.c (compute_display_string_pos): Don't use cached display
2450 string position if the buffer had its restriction changed.
2451 (Bug#9184)
2452
5266b4bb
PE
24532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
2454
2455 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
2456
2573a837 24572011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 2458
41f55ccd 2459 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 2460
39e378da
PE
2461 * bidi.c: Integer size and overflow fixes.
2462 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
2463 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
2464 (bidi_cache_find_level_change, bidi_cache_ensure_space)
2465 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
2466 (bidi_find_other_level_edge):
2467 Use ptrdiff_t instead of EMACS_INT where either will do.
2468 This works better on 32-bit hosts configured --with-wide-int.
2469 (bidi_cache_ensure_space): Check for size-calculation overflow.
2470 Use % rather than repeated addition, for better worst-case speed.
2471 Don't set bidi_cache_size until after xrealloc returns, because it
2472 might not return.
2473 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
2474 (bidi_cache_ensure_space): Also check that the bidi cache size
2475 does not exceed that of the largest Lisp string or buffer. See Eli
2476 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 2477
5e927815
PE
2478 * alloc.c (__malloc_size_t): Remove.
2479 All uses replaced by size_t. See Andreas Schwab's note
2480 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
2481
ca4aa935
PE
2482 * image.c: Improve checking for integer overflow.
2483 (check_image_size): Assume that f is nonnull, since
2484 it is always nonnull in practice. This is one less thing to
2485 worry about when checking for integer overflow later.
2486 (x_check_image_size): New function, which checks for integer
2487 overflow issues inside X.
2488 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
2489 This removes the need for a memory_full check.
2490 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
2491 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
2492 (xbm_read_bitmap_data): Change locals back to 'int', since
2493 their values must fit in 'int'.
2494 (xpm_load_image, png_load, tiff_load):
2495 Invoke x_create_x_image_and_pixmap earlier,
2496 to avoid much needless work if the image is too large.
2497 (tiff_load): Treat overly large images as if
2498 x_create_x_image_and_pixmap failed, not as malloc failures.
2499 (gs_load): Use x_check_image_size.
2500
5f8f9cc2
PE
2501 * gtkutil.c: Omit integer casts.
2502 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
2503 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
2504
5adf60bc
PE
2505 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
2506
c8907a93
PE
2507 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
2508 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
2509 would wrongly return t on a 64-bit host.
2510
e3c25c68
PE
2511 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
2512 The plain *_OVERFLOW macros run afoul of GCC bug 49705
2513 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
2514 and therefore cause GCC to emit a bogus diagnostic in some cases.
2515
3f791afe
PE
2516 * image.c: Integer signedness and overflow and related fixes.
2517 This is not an exhaustive set of fixes, but it's time to
2518 record what I've got.
2519 (lookup_pixel_color, check_image_size): Remove redundant decls.
2520 (check_image_size): Don't assume that arbitrary EMACS_INT values
2521 fit in 'int', or that arbitrary 'double' values fit in 'int'.
2522 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
2523 (tiff_load, imagemagick_load_image):
2524 Check for overflow in size calculations.
2525 (x_create_x_image_and_pixmap): Remove unnecessary test for
2526 xmalloc returning NULL; that can't happen.
2527 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
2528 (xpm_color_bucket): Use better integer hashing function.
2529 (xpm_cache_color): Don't possibly over-allocate memory.
2530 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
2531 (gif_memory_source):
2532 Use ptrdiff_t, not int or size_t, to record sizes.
2533 (png_load): Don't assume values greater than 2**31 fit in 'int'.
2534 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
2535 either works, as we prefer signed integers.
2536 (tiff_read_from_memory, tiff_write_from_memory):
2537 Return tsize_t, not size_t, since that's what the TIFF API wants.
2538 (tiff_read_from_memory): Don't fail simply because the read would
2539 go past EOF; instead, return a short read.
2540 (tiff_load): Omit no-longer-needed casts.
2541 (Fimagemagick_types): Don't assume size fits into 'int'.
2542
3cc5a532
PE
2543 Improve hashing quality when configured --with-wide-int.
2544 * fns.c (hash_string): New function, taken from sxhash_string.
2545 Do not discard information about ASCII character case; this
2546 discarding is no longer needed.
2547 (sxhash-string): Use it. Change sig to match it. Caller changed.
2548 * lisp.h: Declare it.
2549 * lread.c (hash_string): Remove, since we now use fns.c's version.
2550 The fns.c version returns a wider integer if --with-wide-int is
2551 specified, so this should help the quality of the hashing a bit.
2552
b312a492
PE
2553 * emacs.c: Integer overflow minor fix.
2554 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
2555 Define only if GNU_LINUX.
2556 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
2557
dfd153ae
PE
2558 * dispnew.c: Integer signedness and overflow fixes.
2559 Remove unnecessary forward decls, that were a maintenance hassle.
2560 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
2561 All uses changed.
2562 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
2563 (scrolling_window): Use ptrdiff_t, not int, for byte count.
2564 (prepare_desired_row, line_draw_cost):
2565 Use int, not unsigned, where either works.
2566 (save_current_matrix, restore_current_matrix):
2567 Use ptrdiff_t, not size_t, where either works.
2568 (init_display): Check for overflow more accurately, and without
2569 relying on undefined behavior.
2570
a81d11a3
PE
2571 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
2572 Remove, replacing with the new symbols in lisp.h. All uses changed.
2573 * fileio.c (make_temp_name):
2574 * filelock.c (lock_file_1, lock_file):
2575 * xdisp.c (message_dolog):
2576 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
2577 Use pMd etc. instead.
2578 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
2579 replacing the pWIDE etc. symbols removed from editfns.c.
2580
3300e6fd
PE
2581 * keyboard.h (num_input_events): Now uintmax_t.
2582 This is (very slightly) less likely to mess up due to wraparound.
2583 All uses changed.
2584
fd05c7e9
PE
2585 * buffer.c: Integer signedness fixes.
2586 (alloc_buffer_text, enlarge_buffer_text):
2587 Use ptrdiff_t rather than size_t when either will do, as we prefer
2588 signed integers.
2589
903fe15d
PE
2590 * alloc.c: Integer signedness and overflow fixes.
2591 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
2592 (__malloc_size_t): Default to size_t, not to int.
2593 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
2594 (Fgarbage_collect, mark_object_loop_halt, mark_object):
2595 Prefer ptrdiff_t to size_t when either would do, as we prefer
2596 signed integers.
2597 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
2598 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
2599 Now const. Initialize with values that are in range even if char
2600 is signed.
2601 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
2602 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
2603 These functions do the right thing with sizes > 2**32.
2604 (check_depth): Now ptrdiff_t, not int.
2605 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
2606 Adjust to new way of storing sizes. Check for size overflow bugs
2607 in rest of code.
2608 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
2609 slightly wrong anyway, as it missed one instance of
2610 XMALLOC_OVERRUN_CHECK_OVERHEAD.
2611 (refill_memory_reserve): Omit needless cast to size_t.
2612 (mark_object_loop_halt): Mark as externally visible.
2613
ac82cc6a
PE
2614 * xselect.c: Integer signedness and overflow fixes.
2615 (Fx_register_dnd_atom, x_handle_dnd_message):
2616 Use ptrdiff_t, not size_t, since we prefer signed.
2617 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
2618 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
2619 x_dnd_atoms_size and x_dnd_atoms_length.
2620
c2d1e36d
PE
2621 * doprnt.c: Prefer signed to unsigned when either works.
2622 * eval.c (verror):
2623 * doprnt.c (doprnt):
2624 * lisp.h (doprnt):
2625 * xdisp.c (vmessage):
2626 Use ptrdiff_t, not size_t, when using or implementing doprnt,
2627 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
2628 prefer signed arithmetic to avoid comparison confusion.
2629 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
2630 but is a bit tricky.
2631
0e926e56
PE
2632 Assume freestanding C89 headers, string.h, stdlib.h.
2633 * data.c, doprnt.c, floatfns.c, print.c:
2634 Include float.h unconditionally.
2635 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
2636 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
2637 * regex.c: Likewise for stddef.h, string.h.
2638 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
2639 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
2640 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
2641 (STDC_HEADERS): Remove obsolete defines.
2642 * sysdep.c: Include limits.h unconditionally.
2643
9cfdb3ec
PE
2644 Assume support for memcmp, memcpy, memmove, memset.
2645 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
2646 * regex.c (memcmp, memcpy):
2647 Remove; we assume C89 now.
2648
2649 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
2650 (__malloc_safe_bcopy): Remove; no longer needed.
2651
cf950e6b 2652 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
2653 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
2654 well either way, and we prefer signed to unsigned.
2655
dbf38e02
LMI
26562011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
2657
2658 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
2659 closes the connection while we're reading (bug#9182).
2660
d6f0886c 26612011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 2662
d6f0886c
JD
2663 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
2664 are specified (Bug#9168).
24e0f6b1 2665
2eb1f9e6
PE
26662011-07-25 Paul Eggert <eggert@cs.ucla.edu>
2667
2668 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
2669 Found by GCC static checking and --with-wide-int on a 32-bit host.
2670
22381272 26712011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
2672
2673 * xdisp.c (compute_display_string_pos): Fix logic of caching
2674 previous display string position. Initialize cached_prev_pos to
2675 -1. Fixes slow-down at the beginning of a buffer.
2676
f25e39b4
EZ
26772011-07-24 Eli Zaretskii <eliz@gnu.org>
2678
2679 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
2680 for attrs[LFACE_FONTSET_INDEX].
2681
04c4b52e
PE
26822011-07-23 Paul Eggert <eggert@cs.ucla.edu>
2683
2684 * xml.c (parse_region): Remove unused local
2685 that was recently introduced.
2686
c1734fbd
EZ
26872011-07-23 Eli Zaretskii <eliz@gnu.org>
2688
be18c5a5
EZ
2689 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
2690 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
2691
c1734fbd
EZ
2692 * xdisp.c (move_it_in_display_line_to): Record the best matching
2693 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
2694 exit if none of the characters scanned was an exact match.
2695 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
2696 when exact match is impossible due to invisible text, and the
2697 lines are truncated.
2698
a258d627
JD
26992011-07-23 Jan Djärv <jan.h.d@swipnet.se>
2700
2701 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
2702 for OSX >= 10.7.
2703
b6d5a689
EZ
27042011-07-22 Eli Zaretskii <eliz@gnu.org>
2705
0f74f785
EZ
2706 Fix a significant slow-down of cursor motion with C-n, C-p,
2707 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
2708 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 2709 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
2710 (next_element_from_buffer): Call compute_stop_pos_backwards to
2711 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
2712 base_level_stop.
2713 (reseat): Don't look for prev_stop, as that could mean a very long
2714 run.
2715 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
2716 <cached_disp_overlay_modiff>: Cache for last found display string
2717 position.
551918c1 2718 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
2719 about the same buffer in the same area of character positions, and
2720 the buffer wasn't changed since the time the display string
2721 position was cached.
551918c1 2722
b2d0c91a
EZ
27232011-07-22 Eli Zaretskii <eliz@gnu.org>
2724
2725 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
2726 is an integer, which is important for empty lines. (Bug#9149)
2727
043604ee
CY
27282011-07-22 Chong Yidong <cyd@stupidchicken.com>
2729
2730 * frame.c (Fmodify_frame_parameters): In tty case, update the
2731 default face if necessary (Bug#4238).
2732
da4adb04
CY
27332011-07-21 Chong Yidong <cyd@stupidchicken.com>
2734
2735 * editfns.c (Fstring_to_char): No need to explain what a character
2736 is in the docstring (Bug#6576).
2737
9abd0532
LMI
27382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2739
2740 * xml.c (parse_region): Make sure we always return a tree.
2741
36881d16
HK
27422011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
2743
2744 * xml.c (parse_region): If a document contains only comments,
2745 return that, too.
2746
1e98674d
LMI
27472011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
2748
2749 * xml.c (make_dom): Return comments, too.
2750
590bd467
PE
27512011-07-19 Paul Eggert <eggert@cs.ucla.edu>
2752
2753 Port to OpenBSD.
2754 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
2755 and the surrounding thread.
2756 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
2757 rather than fgets, and retry after EINTR. Otherwise, 'emacs
2758 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
2759 timer goes off.
2760 * s/openbsd.h (BROKEN_SIGIO): Define.
2761 * unexelf.c (unexec) [__OpenBSD__]:
2762 Don't update the .mdebug section of the Alpha COFF symbol table.
2763
f41628b2
LMI
27642011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2765
2766 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
2767 (bug#8460).
2768
b59b67c5
PE
27692011-07-18 Paul Eggert <eggert@cs.ucla.edu>
2770
15e3a074
PE
2771 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
2772 This fixes some race conditions on the permissions of any newly
2773 created file.
2774
41bed37d
PE
2775 * alloc.c (valid_pointer_p): Use pipe, not open.
2776 This fixes some permissions issues when debugging.
2777
b59b67c5
PE
2778 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
2779 If fchown fails to set both uid and gid, try to set just gid,
2780 as that is sometimes allowed. Adjust the file's mode to eliminate
2781 setuid or setgid bits that are inappropriate if fchown fails.
2782
925a6be7
SM
27832011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
2784
2785 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
2786 to compare Lisp_Objects.
2787 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
2788 global_gnutls_log_level, don't mistake it for a Lisp_Object.
2789 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
2790
52968808
AS
27912011-07-17 Andreas Schwab <schwab@linux-m68k.org>
2792
0a6a104b
AS
2793 * lread.c (read_integer): Unread even EOF character.
2794 (read1): Likewise. Properly record start position of symbol.
2795
52968808
AS
2796 * lread.c (read1): Read `#:' as empty uninterned symbol if no
2797 symbol character follows.
2798
9e381cdd
PE
27992011-07-17 Paul Eggert <eggert@cs.ucla.edu>
2800
2801 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
2802 This works around a problem with the previous change to Fcopy_file.
2803 Recent glibc declares fchown with __attribute__((warn_unused_result)),
2804 and without this change, GCC might complain about discarding
2805 fchown's return value.
2806
b5641435
JB
28072011-07-16 Juanma Barranquero <lekktu@gmail.com>
2808
2809 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
2810
a8031457
PE
28112011-07-16 Paul Eggert <eggert@cs.ucla.edu>
2812
2813 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
2814
dd889327
LMI
28152011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
2816
750c33f7
LMI
2817 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
2818 it's used from the C level.
2819
dd889327
LMI
2820 * process.c: Use the same condition for POLL_FOR_INPUT in both
2821 keyboard.c and process.c (bug#1858).
2822
87e86684
LM
28232011-07-09 Lawrence Mitchell <wence@gmx.li>
2824
2825 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
2826 (Fgnutls_boot): Use it.
2827
64348f40
AS
28282011-07-15 Andreas Schwab <schwab@linux-m68k.org>
2829
2830 * doc.c (Fsubstitute_command_keys): Revert last change.
2831
1d698799
LMI
28322011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
2833
f863868c
LMI
2834 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
2835 quotes the next character, and doesn't affect other longer
2836 sequences (bug#8935).
2837
1d698799
LMI
2838 * lread.c (syms_of_lread): Clarify that is isn't only
2839 `eval-buffer' and `eval-defun' that's affected by
2840 `lexical-binding' (bug#8460).
2841
aa4b6df6
EZ
28422011-07-15 Eli Zaretskii <eliz@gnu.org>
2843
2844 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 2845 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 2846
5d856da6
PE
28472011-07-14 Paul Eggert <eggert@cs.ucla.edu>
2848
ad6042bb
PE
2849 Fix minor problems found by static checking.
2850 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
2851 (elsz): Now a signed constant, not a size_t var. We prefer signed
2852 types to unsigned, to avoid integer comparison confusion. Without
2853 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
2854 "cannot optimize loop, the loop counter may overflow", a symptom
2855 of the confusion.
f00bbb22 2856 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
2857 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
2858
6468f31c
LMI
28592011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
2860
49080b10
LMI
2861 * search.c (Fre_search_backward): Mention `case-fold-search' in
2862 all the re_search_* functions (bug#8138).
2863
6468f31c
LMI
2864 * keyboard.c (Fopen_dribble_file): Document when the file is
2865 closed (bug#8056).
2866
c965adc5
EZ
28672011-07-14 Eli Zaretskii <eliz@gnu.org>
2868
df9733bf
EZ
2869 * bidi.c (bidi_dump_cached_states): Fix format of displaying
2870 bidi_cache_idx.
2871
0bb23927
EZ
2872 Support bidi reordering of display and overlay strings.
2873 * xdisp.c (compute_display_string_pos)
2874 (compute_display_string_end): Accept additional argument STRING.
2875 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
2876 (reseat_to_string): Initialize bidi_it->string.s and
2877 bidi_it->string.schars.
2878 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
2879 NULL (avoids a crash in bidi_paragraph_init).
2880 Initialize itb.string.lstring.
0bb23927
EZ
2881 (init_iterator): Call bidi_init_it only of a valid
2882 buffer position was specified. Initialize paragraph_embedding to
2883 L2R.
2884 (reseat_to_string): Initialize the bidi iterator.
2885 (display_string): If we need to ignore text properties of
2886 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
2887 original value of -1 will not work with bidi.)
2888 (compute_display_string_pos): First arg is now struct
2889 `text_pos *'; all callers changed. Support display properties on
2890 Lisp strings.
2891 (compute_display_string_end): Support display properties on Lisp
2892 strings.
2893 (init_iterator, reseat_1, reseat_to_string): Initialize the
2894 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
2895 when iterating on a string not from display properties).
640c8776
SM
2896 (compute_display_string_pos, compute_display_string_end):
2897 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
2898 arrow keys.
2899 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
2900 base_level_stop; instead, set base_level_stop to BEGV.
2901 Fixes crashes in vertical-motion.
0bb23927
EZ
2902 (next_element_from_buffer): Improve commentary for when
2903 the iterator is before prev_stop.
2904 (init_iterator): Initialize bidi_p from the default value of
2905 bidi-display-reordering, not from buffer-local value. Use the
2906 buffer-local value only if initializing for buffer iteration.
2907 (handle_invisible_prop): Support invisible properties on strings
2908 that are being bidi-reordered.
2909 (set_iterator_to_next): Support bidi reordering of C strings and
2910 Lisp strings.
2911 (next_element_from_string): Support bidi reordering of Lisp
2912 strings.
2913 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
2914 (display_string): Support display of R2L glyph rows.
2915 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
2916 (init_iterator): Don't initialize it->bidi_p for strings
2917 here.
2918 (reseat_to_string): Initialize it->bidi_p for strings here.
2919 (next_element_from_string, next_element_from_c_string)
2920 (next_element_from_buffer): Add xassert's for correspondence
2921 between IT's object being iterated and it->bidi_it.string
2922 structure.
2923 (face_before_or_after_it_pos): Support bidi iteration.
2924 (next_element_from_c_string): Handle the case of the first string
2925 character that is not the first one in the visual order.
2926 (get_visually_first_element): New function, refactored from common
2927 parts of next_element_from_buffer, next_element_from_string, and
2928 next_element_from_c_string.
2929 (tool_bar_lines_needed, redisplay_tool_bar)
2930 (display_menu_bar): Force left-to-right direction. Add a FIXME
2931 comment for making that be controlled by a user option.
2932 (push_it, pop_it): Save and restore the state of the
2933 bidi iterator. Save and restore the bidi_p flag.
2934 (pop_it): Iterate out of display property for string iteration as
2935 well.
2936 (iterate_out_of_display_property): Support iteration over strings.
2937 (handle_single_display_spec): Set up it->bidi_it for iteration
2938 over a display string, and call bidi_init_it.
2939 (handle_single_display_spec, next_overlay_string)
2940 (get_overlay_strings_1, push_display_prop): Set up the bidi
2941 iterator for displaying display or overlay strings.
2942 (forward_to_next_line_start): Don't use the shortcut if
2943 bidi-iterating.
2944 (back_to_previous_visible_line_start): If handle_display_prop
2945 pushed the iterator stack, restore the internal state of the bidi
2946 iterator by calling bidi_pop_it same number of times.
2947 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
2948 and we are bidi-iterating, don't decrement the iterator position;
2949 instead, set the first_elt flag in the bidi iterator, to produce
2950 the same effect.
2951 (reseat_1): Remove redundant setting of string_from_display_prop_p.
2952 (push_display_prop): xassert that we are iterating a buffer.
2953 (push_it, pop_it): Save and restore paragraph_embedding member.
2954 (handle_single_display_spec, next_overlay_string)
2955 (get_overlay_strings_1, reseat_1, reseat_to_string)
2956 (push_display_prop): Set up the `unibyte' member of bidi_it.string
2957 correctly. Don't assume unibyte strings are not bidi-reordered.
2958 (compute_display_string_pos)
2959 (compute_display_string_end): Fix handling the case of C string.
2960 (push_it, pop_it): Save and restore from_disp_prop_p.
2961 (handle_single_display_spec, push_display_prop): Set the
2962 from_disp_prop_p flag.
2963 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
2964 (pop_it): Call iterate_out_of_display_property only if we are
2965 popping after iteration over a string that came from a display
2966 property. Fix a typo in popping stretch info. Add an assertion
2967 for verifying that the iterator position is in sync with the bidi
2968 iterator.
2969 (handle_single_display_spec, get_overlay_strings_1)
2970 (push_display_prop): Fix initialization of paragraph direction for
2971 string when that of the parent object is not yet determined.
2972 (reseat_1): Call bidi_init_it to resync the bidi
2973 iterator with IT's position. (Bug#7616)
2974 (find_row_edges): If ROW->start.pos gives position
2975 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
2976 (handle_stop, back_to_previous_visible_line_start, reseat_1):
2977 Reset the from_disp_prop_p flag.
2978 (SAVE_IT, RESTORE_IT): New macros.
2979 (pos_visible_p, face_before_or_after_it_pos)
2980 (back_to_previous_visible_line_start)
2981 (move_it_in_display_line_to, move_it_in_display_line)
2982 (move_it_to, move_it_vertically_backward, move_it_by_lines)
2983 (try_scrolling, redisplay_window, display_line): Use them when
2984 saving a temporary copy of the iterator and restoring it back.
2985 (back_to_previous_visible_line_start, reseat_1)
2986 (init_iterator): Empty the bidi cache "stack".
2987 (move_it_in_display_line_to): If iterator ended up at
2988 EOL, but we never saw any buffer positions smaller than
2989 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
2990 motion in bidi-reordered lines.
2991 (move_it_in_display_line_to): Record prev_method and prev_pos
2992 immediately before the call to set_iterator_to_next. Fixes cursor
2993 motion in bidi-reordered lines with stretch glyphs and strings
2994 displayed in margins. (Bug#8133) (Bug#8867)
2995 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
2996 TO_CHARPOS.
640c8776
SM
2997 (pos_visible_p): Support positions in bidi-reordered lines.
2998 Save and restore bidi cache.
0bb23927
EZ
2999
3000 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
3001 (bidi_paragraph_info): Delete unused struct.
3002 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
3003 (bidi_cache_start): New variable.
3004 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
3005 to zero.
3006 (bidi_cache_fetch_state, bidi_cache_search)
3007 (bidi_cache_find_level_change, bidi_cache_iterator_state)
3008 (bidi_cache_find, bidi_peek_at_next_level)
3009 (bidi_level_of_next_char, bidi_find_other_level_edge)
3010 (bidi_move_to_visually_next): Compare cache index with
3011 bidi_cache_start rather than with zero.
3012 (bidi_fetch_char): Accept new argument STRING; all callers
3013 changed. Support iteration over a string. Support strings with
3014 display properties. Support unibyte strings. Fix the type of
3015 `len' according to what STRING_CHAR_AND_LENGTH expects.
3016 (bidi_paragraph_init, bidi_resolve_explicit_1)
3017 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
3018 (bidi_level_of_next_char, bidi_move_to_visually_next):
3019 Support iteration over a string.
0bb23927
EZ
3020 (bidi_set_sor_type, bidi_resolve_explicit_1)
3021 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
3022 can now be zero (for strings); special values 0 and -1 were
3023 changed to -1 and -2, respectively.
3024 (bidi_char_at_pos): New function.
3025 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
3026 Call it instead of FETCH_MULTIBYTE_CHAR.
3027 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
3028 initialized to valid values.
3029 (bidi_init_it): Don't initialize charpos and bytepos with invalid
3030 values.
3031 (bidi_level_of_next_char): Allow the sentinel "position" to pass
3032 the test for valid cached positions. Fix the logic for looking up
3033 the sentinel state in the cache. GCPRO the Lisp string we are
3034 iterating.
3035 (bidi_push_it, bidi_pop_it): New functions.
3036 (bidi_initialize): Initialize the bidi cache start stack pointer.
3037 (bidi_cache_ensure_space): New function, refactored from part of
3038 bidi_cache_iterator_state. Don't assume the required size is just
3039 one BIDI_CACHE_CHUNK away.
3040 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
3041 (bidi_count_bytes, bidi_char_at_pos): New functions.
3042 (bidi_cache_search): Don't assume bidi_cache_last_idx is
3043 always valid if bidi_cache_idx is valid.
3044 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
3045 is valid if it's going to be used.
3046 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
3047 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
3048 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3049 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
3050 (bidi_find_other_level_edge, bidi_cache_start_stack):
3051 All variables related to cache indices are now EMACS_INT.
c965adc5 3052
0bb23927
EZ
3053 * dispextern.h (struct bidi_string_data): New structure.
3054 (struct bidi_it): New member `string'. Make flag members be 1-bit
3055 fields, and put them last in the struct.
640c8776
SM
3056 (compute_display_string_pos, compute_display_string_end):
3057 Update prototypes.
0bb23927
EZ
3058 (bidi_push_it, bidi_pop_it): Add prototypes.
3059 (struct iterator_stack_entry): New members bidi_p,
3060 paragraph_embedding, and from_disp_prop_p.
3061 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
3062 (bidi_shelve_cache, bidi_unshelve_cache):
3063 Declare prototypes.
0bb23927
EZ
3064
3065 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
3066 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
3067 and vector-like objects.
3068
3069 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
3070 cache around display iteration.
3071
3072 * window.c (Fwindow_end, window_scroll_pixel_based)
3073 (displayed_window_lines, Frecenter): Save and restore the bidi
3074 cache around display iteration.
3075
3bbd2265
LMI
30762011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3077
3078 * editfns.c (Fdelete_region): Clarify the use of the named
3079 parameters (bug#6788).
3080
adc47434
MR
30812011-07-14 Martin Rudalics <rudalics@gmx.at>
3082
3083 * indent.c (Fvertical_motion): Set and restore w->pointm when
3084 saving and restoring the window's buffer (Bug#9006).
3085
837c31f8
LMI
30862011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
3087
3088 * editfns.c (Fstring_to_char): Clarify just what is returned
3089 (bug#6576). Text by Eli Zaretskii.
3090
ac389d0c
JB
30912011-07-13 Juanma Barranquero <lekktu@gmail.com>
3092
3093 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
3094
0be0ce47
EZ
30952011-07-13 Eli Zaretskii <eliz@gnu.org>
3096
3097 * buffer.c (mmap_find): Fix a typo.
3098
cd18e7e3
JB
30992011-07-13 Johan Bockgård <bojohan@gnu.org>
3100
3101 Fix execution of x selection hooks.
3102 * xselect.c (Qx_lost_selection_functions)
3103 (Qx_sent_selection_functions): New vars.
3104 (syms_of_xselect): DEFSYM them.
3105 (x_handle_selection_request): Pass Qx_sent_selection_functions
3106 rather than Vx_sent_selection_functions to Frun_hook_with_args.
3107 (x_handle_selection_clear,x_clear_frame_selections):
3108 Pass Qx_lost_selection_functions rather than
3109 Vx_lost_selection_functions to Frun_hook_with_args.
3110
47ea7f44
PE
31112011-07-13 Paul Eggert <eggert@cs.ucla.edu>
3112
ac389d0c 3113 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
3114 The old code sometimes used this field without initializing it.
3115
47ea7f44
PE
3116 * alloc.c (gc_sweep): Don't read past end of array.
3117 In theory, the old code could also have corrupted Emacs internals,
3118 though it'd be very unlikely.
3119
bc985c87
AS
31202011-07-12 Andreas Schwab <schwab@linux-m68k.org>
3121
3122 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 3123 argument. (Bug#4026)
bc985c87 3124
0cf34688
LMI
31252011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
3126
b3dadd76
LMI
3127 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
3128 key" (bug#4257).
3129
0cf34688
LMI
3130 * window.c (Fset_window_start): Doc fix (bug#4199).
3131 (Fset_window_hscroll): Ditto.
3132
270768cd
PE
31332011-07-12 Paul Eggert <eggert@cs.ucla.edu>
3134
077e3dda 3135 Fix minor new problems caught by GCC 4.6.1.
270768cd 3136 * term.c (init_tty): Remove unused local.
490011a6 3137 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 3138 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 3139 not used otherwise.
270768cd 3140
b1f58454
CY
31412011-07-12 Chong Yidong <cyd@stupidchicken.com>
3142
3143 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
3144
22b9578d
LMI
31452011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
3146
6e70ab07
LMI
3147 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
3148 are the mini-buffer and the echo area (bug#3320).
3149
22b9578d
LMI
3150 * term.c (init_tty): Remove support for supdup, c10 and perq
3151 terminals, which are no longer supported (bug#1482).
3152
8974cc9f
JB
31532011-07-10 Johan Bockgård <bojohan@gnu.org>
3154
3155 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
3156
a560d974
JD
31572011-07-10 Jan Djärv <jan.h.d@swipnet.se>
3158
3159 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
3160 for non-popups (Bug#3642).
3161
1dae0f0a
AS
31622011-07-10 Andreas Schwab <schwab@linux-m68k.org>
3163
268c2c36 3164 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 3165 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
3166 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
3167 * cm.c (losecursor): Likewise.
1dae0f0a
AS
3168 * data.c (fmod): Likewise.
3169 * dispnew.c (swap_glyphs_in_rows): Likewise.
3170 * emacs.c (memory_warning_signal): Likewise.
3171 * floatfns.c (float_error): Likewise.
3172 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
3173 (otf_open, font_otf_capability, generate_otf_features)
3174 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
3175 Likewise.
3176 * image.c (pbm_read_file): Likewise.
3177 * indent.c (string_display_width): Likewise.
3178 * intervals.c (check_for_interval, search_for_interval)
3179 (inc_interval_count, count_intervals, root_interval)
3180 (adjust_intervals_for_insertion, make_new_interval): Likewise.
3181 * lread.c (defalias): Likewise.
268c2c36 3182 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
3183 * regex.c (set_image_of_range_1, set_image_of_range)
3184 (regex_grow_registers): Likewise.
3185 * sysdep.c (strerror): Likewise.
3186 * termcap.c (valid_filename_p, tprint, main): Likewise.
3187 * tparam.c (main): Likewise.
3188 * unexhp9k800.c (run_time_remap, save_data_space)
3189 (update_file_ptrs, read_header, write_header, calculate_checksum)
3190 (copy_file, copy_rest, display_header): Likewise.
3191 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
3192 Likewise.
3193 * xdisp.c (check_it): Likewise.
3194 * xfaces.c (register_color, unregister_color, unregister_colors):
3195 Likewise.
3196 * xfns.c (print_fontset_result): Likewise.
3197 * xrdb.c (member, fatal, main): Likewise.
3198
99033785
PE
31992011-07-10 Paul Eggert <eggert@cs.ucla.edu>
3200
3201 Fix minor problems found by static checking (Bug#9031).
3202 * chartab.c (char_table_set_range, map_sub_char_table):
3203 Remove unused locals.
3204 (uniprop_table): Now static.
3205 * composite.c (_work_char): Remove unused static var.
3206
9cb2ac56
JB
32072011-07-09 Juanma Barranquero <lekktu@gmail.com>
3208
3209 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
3210
f25661f0
JD
32112011-07-09 Jan Djärv <jan.h.d@swipnet.se>
3212
3213 * gtkutil.c (qttip_cb): Remove code without function.
3214
8278c4fe
EZ
32152011-07-09 Eli Zaretskii <eliz@gnu.org>
3216
3217 * w32.c (pthread_sigmask): New stub.
3218
1692ae2d 32192011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 3220
8a6ebd58 3221 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
3222 sigprocmask is portable only for single-threaded applications, and
3223 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
3224 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
3225 (LIBES): Use it.
3226 * callproc.c (Fcall_process):
3227 * process.c (create_process):
3228 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
3229 Use pthread_sigmask, not sigprocmask.
123403e4 3230
1b854618
JD
32312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3232
3233 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
3234 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
3235 wrong (Bug#8591).
3236
3fe4b549
JD
32372011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3238
0ce7e563
JD
3239 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
3240 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
3241 (xg_hide_tooltip): Fix comment.
3242
3fe4b549
JD
3243 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
3244 in registerServicesMenuSendTypes.
3245 (validRequestorForSendType): Don't check ns_return_types.
3246
3247 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
3248 ns_return_type.
3249
5df75e47
JR
32502011-07-08 Jason Rumney <jasonr@gnu.org>
3251
22610910
JR
3252 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
3253 SH_SHOW for hidden windows (Bug#5482).
3254
5df75e47
JR
3255 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
3256 frame struct members of non-existent frames (Bug#6284).
3257
699c10bd
JD
32582011-07-08 Jan Djärv <jan.h.d@swipnet.se>
3259
4393663b
JD
3260 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
3261 variable firstTime not needed on OSX >= 10.6.
3262 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
3263 >= 10.5. Use setKnobProportion, setDoubleValue.
3264
3265 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
3266 (MAC_OS_X_VERSION_10_5): Define if not defined.
3267 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
3268 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
3269 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
3270
3271 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
3272 cString and lossyCString on OSX >= 10.4
3273
58179cce 3274 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
3275 sizeToFit on OSX >= 10.2.
3276
3277 * nsimage.m (allocInitFromFile): Don't use deprecated method
3278 bestRepresentationForDevice on OSX >= 10.6.
3279
3280 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
3281 to avoid warning.
3282
3283 * emacs.c: Declare unexec_init_emacs_zone.
3284
a63e0781
JD
3285 * nsgui.h: Fix compiler warning about gnulib redefining verify.
3286
699c10bd
JD
3287 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
3288
3289 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
3290 on svcsMenu (Bug#8842).
3291
3292 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
3293 ns_return_types.
3294 (Fns_list_services): Just return Qnil on 10.6, code not working there.
3295
3296 * nsterm.m (QUTF8_STRING): Declare.
3297 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
3298 (validRequestorForSendType): Return type is (id).
3299 Change indexOfObjectIdenticalTo to indexOfObject.
3300 Check if we have local selection before returning self (Bug#8842).
3301 (writeSelectionToPasteboard): Put local selection into paste board
3302 if we have a local selection (Bug#8842).
3303 (syms_of_nsterm): DEFSYM QUTF8_STRING.
3304
3305 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
3306 (ns_get_local_selection): Declare.
3307
54e10184
LMI
33082011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
3309
9888ff71
LMI
3310 * keymap.c (describe_map_tree): Don't insert a double newline at
3311 the end of the buffer (bug#1169) and return whether we inserted
3312 something.
3313
54e10184
LMI
3314 * callint.c (Fcall_interactively): Change "reading args" to
3315 "providing args" to try to clarify what it does (bug#1010).
3316
15fa4783
KH
33172011-07-07 Kenichi Handa <handa@m17n.org>
3318
3319 * composite.c (composition_compute_stop_pos): Ignore a static
3320 composition starting before CHARPOS (Bug#8915).
3321
3322 * xdisp.c (handle_composition_prop): Likewise.
3323
a8815b00
EZ
33242011-07-07 Eli Zaretskii <eliz@gnu.org>
3325
3326 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
3327 (Bug#9015)
3328
ef7b981d 33292011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
3330
3331 * character.h (unicode_category_t): New enum type.
3332
3333 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
3334 (Qchar_code_property_table): New variable.
3335 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
3336 (UNIPROP_COMPRESSED_FORM_P): New macros.
3337 (char_table_ascii): Uncompress the compressed values.
3338 (sub_char_table_ref): New arg is_uniprop. Callers changed.
3339 Uncompress the compressed values.
ac389d0c 3340 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
3341 (char_table_ref_and_range): Uncompress the compressed values.
3342 (sub_char_table_set): New arg is_uniprop. Callers changed.
3343 Uncompress the compressed values.
3344 (sub_char_table_set_range): Args changed. Callers changed.
3345 (char_table_set_range): Adjuted for the above change.
3346 (map_sub_char_table): Delete args default_val and parent. Add arg
3347 top. Give decoded values to a Lisp function.
640c8776 3348 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
3349 values to a Lisp function. Gcpro more variables.
3350 (uniprop_table_uncompress)
3351 (uniprop_decode_value_run_length): New functions.
3352 (uniprop_decoder, uniprop_decoder_count): New variables.
3353 (uniprop_get_decoder, uniprop_encode_value_character)
3354 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
3355 New functions.
3356 (uniprop_encoder, uniprop_encoder_count): New variables.
3357 (uniprop_get_encoder, uniprop_table)
3358 (Funicode_property_table_internal, Fget_unicode_property_internal)
3359 (Fput_unicode_property_internal): New functions.
3360 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
3361 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 3362 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
3363 char-code-property-alist.
3364
640c8776 3365 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
3366 Vunicode_category_table.
3367
640c8776 3368 * font.c (font_range): Adjust for the change of
c805dec0
KH
3369 Vunicode_category_table.
3370
76b397fb
DN
33712011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
3372
3373 * m/iris4d.h: Remove file, move contents ...
3374 * s/irix6-5.h: ... here.
3375
22b4128e
PE
33762011-07-06 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
3379 * alloc.c (mark_buffer):
3380 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
3381 (clone_per_buffer_values): Don't assume that
22b4128e
PE
3382 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
3383 This isn't true in general, and it's particularly not true
3384 if Emacs is configured with --with-wide-int.
3385 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
3386 New macros, used in the buffer.c change.
3387
869795d6
JD
33882011-07-05 Jan Djärv <jan.h.d@swipnet.se>
3389
3390 * xsettings.c: Use both GConf and GSettings if both are available.
3391 (store_config_changed_event): Add comment.
3392 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
3393 (store_tool_bar_style_changed): New functions.
5e617bc2 3394 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
3395 (struct xsettings): Move font inside HAVE_XFT.
3396 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 3397 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 3398 Move inside HAVE_XFT.
640c8776 3399 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
3400 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
3401 also.
3402 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 3403 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 3404 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
3405 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
3406 (parse_settings): Move check for font inside HAVE_XFT.
3407 (read_settings, apply_xft_settings): Add comment.
3408 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
3409 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
3410 call store_font_name_changed.
3411 (xft_settings_event): Add comment.
3412 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
3413 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
3414 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
3415 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
3416 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
3417 (xsettings_get_system_font, xsettings_get_system_normal_font):
3418 Add comment.
869795d6 3419
d8ed26bd
PE
34202011-07-05 Paul Eggert <eggert@cs.ucla.edu>
3421
3422 Random fixes. E.g., (random) never returned negative values.
3423 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
3424 subseconds part to the entropy, as that's a bit more random.
3425 Prefer signed to unsigned, since the signedness doesn't matter and
3426 in general we prefer signed. When given a limit, use a
3427 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
3428 latter isn't right if USE_2_TAGS_FOR_INTS.
3429 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
3430 not 0..VALMASK. Don't discard "excess" bits that random () returns.
3431
cabf1cac
SM
34322011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
3433
3434 * textprop.c (text_property_stickiness):
3435 Obey Vtext_property_default_nonsticky.
3436 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
3437 * w32fns.c (syms_of_w32fns):
3438 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
3439
6e9b2be9
PE
34402011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3441
3442 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
3443 This is more efficient than Ffile_directory_p and avoids a minor race.
3444
90186c68
LMI
34452011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
3446
7c301272
LMI
3447 * buffer.c (Foverlay_put): Say what the return value is
3448 (bug#7835).
3449
c4f2d8d4
LMI
3450 * fileio.c (barf_or_query_if_file_exists): Check first if the file
3451 is a directory before asking whether to use the file name
3452 (bug#7564).
ad637907
LMI
3453 (barf_or_query_if_file_exists): Make the "File is a directory"
3454 error be more correct.
c4f2d8d4 3455
90186c68
LMI
3456 * fns.c (Frequire): Remove the mention of the .gz files, since
3457 that's installation-specific, but keep the mention of
3458 `get-load-suffixes'.
3459
da64016e
PE
34602011-07-04 Paul Eggert <eggert@cs.ucla.edu>
3461
3462 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
3463 Report string overflow if the output is too long.
3464
7d47b580
JB
34652011-07-04 Juanma Barranquero <lekktu@gmail.com>
3466
a555cb87
JB
3467 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
3468 (syms_of_gnutls): Remove duplicate DEFSYM for
3469 Qgnutls_bootprop_verify_hostname_error, an error for
3470 Qgnutls_bootprop_verify_error (which is no longer used).
3471
7d47b580
JB
3472 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
3473 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
3474 Also (re)move comments that are misplaced or no longer relevant.
3475
1e49bfab
LMI
34762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3477
3478 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
3479
1485f4c0
CY
34802011-07-03 Chong Yidong <cyd@stupidchicken.com>
3481
3482 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
3483 and background color parameters if they have been changed.
3484
a9ab721e
LMI
34852011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
3486
3487 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
3488
cf7cff57
PE
34892011-07-03 Paul Eggert <eggert@cs.ucla.edu>
3490
2e13213d
PE
3491 * xsettings.c (SYSTEM_FONT): Define only when used.
3492 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
3493
cf7cff57
PE
3494 * keymap.c (access_keymap_1): Now static.
3495
7a8e04f7
CY
34962011-07-02 Chong Yidong <cyd@stupidchicken.com>
3497
3498 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
3499 leave any prefix arg for the up event (Bug#1586).
3500
61352f62
LMI
35012011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
3502
69bb1ef7
LMI
3503 * lread.c (syms_of_lread): Mention single symbols defined by
3504 `defvar' or `defconst' (bug#7154).
3505
61352f62 3506 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 3507 (Frequire): Mention get-load-suffixes.
61352f62 3508
28545e04
MR
35092011-07-02 Martin Rudalics <rudalics@gmx.at>
3510
3511 * window.h (window): Remove clone_number slot.
3512 * window.c (Fwindow_clone_number, Fset_window_clone_number):
3513 Remove.
3514 (make_parent_window, make_window, saved_window)
3515 (Fset_window_configuration, save_window_save): Don't deal with
3516 clone numbers.
3517 * buffer.c (Qclone_number): Remove declaration.
3518 (sort_overlays, overlay_strings): Don't deal with clone numbers.
3519
3349e122
SM
35202011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
3521
3522 Add multiple inheritance to keymaps.
3523 * keymap.c (Fmake_composed_keymap): New function.
3524 (Fset_keymap_parent): Simplify.
3525 (fix_submap_inheritance): Remove.
3526 (access_keymap_1): New function extracted from access_keymap to handle
3527 embedded parents and handle lists of maps.
3528 (access_keymap): Use it.
3529 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
3530 (Fcopy_keymap): Handle embedded parents.
3531 (Fcommand_remapping, define_as_prefix): Simplify.
3532 (Fkey_binding): Simplify.
3533 (syms_of_keymap): Move minibuffer-local-completion-map,
3534 minibuffer-local-filename-completion-map,
3535 minibuffer-local-must-match-map, and
3536 minibuffer-local-filename-must-match-map to Elisp.
3537 (syms_of_keymap): Defsubr make-composed-keymap.
3538 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
3539 (parse_menu_item): Trivial simplification.
3540
3279eb87
GM
35412011-07-01 Glenn Morris <rgm@gnu.org>
3542
3543 * Makefile.in (SETTINGS_LIBS): Fix typo.
3544
4550efdf
KI
35452011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
3546
3547 * coding.c (Fencode_coding_string): Record the last coding system
3548 used, as the function doc string says (bug#8738).
3549
0949d2b6
JD
35502011-07-01 Jan Djärv <jan.h.d@swipnet.se>
3551
3552 * xsettings.c (store_monospaced_changed): Take new font as arg and
3553 check for change against current_mono_font.
3554 (EMACS_TYPE_SETTINGS): Remove this and related defines.
3555 (emacs_settings_constructor, emacs_settings_get_property)
3556 (emacs_settings_set_property, emacs_settings_class_init)
3557 (emacs_settings_init, gsettings_obj): Remove.
3558 (something_changedCB): New function for HAVE_GSETTINGS.
3559 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
3560 with value as argument.
3561 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
3562 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 3563 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
3564 "changed".
3565
3566 * xgselect.c: Add defined (HAVE_GSETTINGS).
3567 (xgselect_initialize): Ditto.
3568
3569 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
3570 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
3571 xg_select.
3572
bbc6b304
PE
35732011-07-01 Paul Eggert <eggert@cs.ucla.edu>
3574
3575 * eval.c (struct backtrace): Simplify and port the data structure.
3576 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
3577 signed bit field, as this assumption is not portable and it makes
3578 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
3579 "char debug_on_exit : 1" as this is not portable either; instead,
3580 use the portable "unsigned int debug_on_exit : 1". Remove unused
3581 member evalargs. Remove obsolete comments about cc bombing out.
3582
9851bfc5
JD
35832011-06-30 Jan Djärv <jan.h.d@swipnet.se>
3584
51bb811f 3585 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
3586 Let HAVE_GSETTINGS override HAVE_GCONF.
3587 (store_monospaced_changed): New function.
3588 (EMACS_SETTINGS): A new type derived from GObject to handle
3589 GSettings notifications.
3590 (emacs_settings_constructor, emacs_settings_get_property)
3591 (emacs_settings_set_property, emacs_settings_class_init):
3592 New functions.
3593 (gsettings_client, gsettings_obj): New variables.
3594 (GSETTINGS_SCHEMA): New define.
3595 (something_changedCB): Call store_monospaced_changed.
3596 (init_gsettings): New function.
3597 (xsettings_initialize): Call init_gsettings.
3598 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
3599 to NULL.
3600
640c8776 3601 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
3602 GCONF_CFLAGS/LIBS.
3603
5386012d
MR
36042011-06-29 Martin Rudalics <rudalics@gmx.at>
3605
3606 * window.c (resize_root_window, grow_mini_window)
3607 (shrink_mini_window): Rename Qresize_root_window to
3608 Qwindow_resize_root_window and Qresize_root_window_vertically to
3609 Qwindow_resize_root_window_vertically.
3610
f13e0b08
PE
36112011-06-28 Paul Eggert <eggert@cs.ucla.edu>
3612
3613 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
3614
94515237
JB
36152011-06-27 Juanma Barranquero <lekktu@gmail.com>
3616
3617 * makefile.w32-in: Redesign dependencies so they reflect more
3618 clearly which files are directly included by each source file,
3619 and not through other includes.
3620
e43b6e43
MR
36212011-06-27 Martin Rudalics <rudalics@gmx.at>
3622
3623 * buffer.c (Qclone_number): Declare static and DEFSYM it.
3624 (sort_overlays, overlay_strings): When an overlay's clone number
3625 matches the window's clone number process the overlay even if
3626 the overlay's window property doesn't match the current window.
3627
d68443dc
MR
3628 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
3629 (Fwindow_hchild): Rename to Fwindow_left_child.
3630 (Fwindow_next): Rename to Fwindow_next_sibling.
3631 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
3632 (resize_window_check): Rename to window_resize_check.
3633 (resize_window_apply): Rename to window_resize_apply.
3634 (Fresize_window_apply): Rename to Fwindow_resize_apply.
3635 (Fdelete_other_windows_internal, resize_frame_windows)
3636 (Fsplit_window_internal, Fdelete_window_internal)
3637 (grow_mini_window, shrink_mini_window)
3638 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 3639
c7e73be5
JD
36402011-06-26 Jan Djärv <jan.h.d@swipnet.se>
3641
3642 * emacsgtkfixed.h: State that this is only used with Gtk+3.
3643 (emacs_fixed_set_min_size): Remove.
3644 (emacs_fixed_new): Take frame as argument.
3645
3646 * emacsgtkfixed.c: State that this is only used with Gtk+3.
3647 (_EmacsFixedPrivate): Remove minwidth/height.
3648 Add struct frame *f.
3649 (emacs_fixed_init): Initialize priv->f.
3650 (get_parent_class, emacs_fixed_set_min_size): Remove.
3651 (emacs_fixed_new): Set priv->f to argument.
3652 (emacs_fixed_get_preferred_width)
3653 (emacs_fixed_get_preferred_height): Use min_width/height from
3654 frames size_hint to set minimum and natural (Bug#8919).
3655 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
3656 and use min_width/height from frames size_hint to set
3657 min_width/height (Bug#8919).
3658
3659 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
3660 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
3661 Fix indentation.
c7e73be5 3662
cf99dcf8
EZ
36632011-06-26 Eli Zaretskii <eliz@gnu.org>
3664
3665 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
3666 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
3667 called at ZV.
3668
029529ac
CY
36692011-06-26 Chong Yidong <cyd@stupidchicken.com>
3670
3671 * process.c (wait_reading_process_output): Bypass select if
3672 waiting for a cell while ignoring keyboard input, and input is
3673 pending. Suggested by Jan Djärv (Bug#8869).
3674
7a7ef429
PE
36752011-06-25 Paul Eggert <eggert@cs.ucla.edu>
3676
3677 Use gnulib's dup2 module instead of rolling our own.
3678 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
3679
11fdef7d 36802011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
3681
3682 * dispnew.c (scrolling_window): Before scrolling, turn off a
3683 mouse-highlight in the window being scrolled.
3684
cd3520a4
JB
36852011-06-24 Juanma Barranquero <lekktu@gmail.com>
3686
3687 Move DEFSYM to lisp.h and use everywhere.
3688
3689 * character.h (DEFSYM): Move declaration...
3690 * lisp.h (DEFSYM): ...here.
3691
3692 * gnutls.c:
3693 * minibuf.c:
3694 * w32menu.c:
3695 * w32proc.c:
3696 * w32select.c: Don't include character.h.
3697
3698 * alloc.c (syms_of_alloc):
3699 * buffer.c (syms_of_buffer):
3700 * bytecode.c (syms_of_bytecode):
3701 * callint.c (syms_of_callint):
3702 * casefiddle.c (syms_of_casefiddle):
3703 * casetab.c (init_casetab_once):
3704 * category.c (init_category_once, syms_of_category):
3705 * ccl.c (syms_of_ccl):
3706 * cmds.c (syms_of_cmds):
3707 * composite.c (syms_of_composite):
3708 * dbusbind.c (syms_of_dbusbind):
3709 * dired.c (syms_of_dired):
3710 * dispnew.c (syms_of_display):
3711 * doc.c (syms_of_doc):
3712 * editfns.c (syms_of_editfns):
3713 * emacs.c (syms_of_emacs):
3714 * eval.c (syms_of_eval):
3715 * fileio.c (syms_of_fileio):
3716 * fns.c (syms_of_fns):
3717 * frame.c (syms_of_frame):
3718 * fringe.c (syms_of_fringe):
3719 * insdel.c (syms_of_insdel):
3720 * keymap.c (syms_of_keymap):
3721 * lread.c (init_obarray, syms_of_lread):
3722 * macros.c (syms_of_macros):
3723 * msdos.c (syms_of_msdos):
3724 * print.c (syms_of_print):
3725 * process.c (syms_of_process):
3726 * search.c (syms_of_search):
3727 * sound.c (syms_of_sound):
3728 * syntax.c (init_syntax_once, syms_of_syntax):
3729 * terminal.c (syms_of_terminal):
3730 * textprop.c (syms_of_textprop):
3731 * undo.c (syms_of_undo):
3732 * w32.c (globals_of_w32):
3733 * window.c (syms_of_window):
3734 * xdisp.c (syms_of_xdisp):
3735 * xfaces.c (syms_of_xfaces):
3736 * xfns.c (syms_of_xfns):
3737 * xmenu.c (syms_of_xmenu):
3738 * xsettings.c (syms_of_xsettings):
3739 * xterm.c (syms_of_xterm): Use DEFSYM.
3740
4228cf16
TZ
37412011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
3742
cd3520a4 3743 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 3744
7fcccf1e
PE
37452011-06-23 Paul Eggert <eggert@cs.ucla.edu>
3746
7efb4e0e
PE
3747 Integer and buffer overflow fixes (Bug#8873).
3748
ff5844ad
PE
3749 * print.c (printchar, strout): Check for string overflow.
3750 (PRINTPREPARE, printchar, strout):
3751 Don't set size unless allocation succeeds.
3752
90532f02
PE
3753 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
3754 for sizes. Check for string overflow more accurately.
3755 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
3756
6d84508d
PE
3757 * macros.c: Integer and buffer overflow fixes.
3758 * keyboard.h (struct keyboard.kbd_macro_bufsize):
3759 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
3760 Use ptrdiff_t, not int, for sizes.
3761 Don't increment bufsize until after realloc succeeds.
3762 Check for size-calculation overflow.
3763 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
3764
437b2cb4
PE
3765 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
3766
8b9ac8b4
PE
3767 * lread.c: Integer overflow fixes.
3768 (read_integer): Radix is now EMACS_INT, not int,
3769 to improve quality of diagnostics for out-of-range radices.
3770 Calculate buffer size correctly for out-of-range radices.
3771 (read1): Check for integer overflow in radices, and in
3772 read-circle numbers.
82cb60d3
PE
3773 (read_escape): Avoid int overflow.
3774 (Fload, openp, read_buffer_size, read1)
3775 (substitute_object_recurse, read_vector, read_list, map_obarray):
3776 Use ptrdiff_t, not int, for sizes.
3777 (read1): Use EMACS_INT, not int, for sizes.
20270765 3778 Check for size overflow.
8b9ac8b4 3779
7fcccf1e
PE
3780 * image.c (cache_image): Check for size arithmetic overflow.
3781
bfbbd7e7
PE
3782 * lread.c: Integer overflow issues.
3783 (saved_doc_string_size, saved_doc_string_length)
3784 (prev_saved_doc_string_size, prev_saved_doc_string_length):
3785 Now ptrdiff_t, not int.
3786 (read1): Don't assume doc string length fits in int. Check for
3787 out-of-range doc string lengths.
3788 (read_list): Don't assume file position fits in int.
39019e54 3789 (read_escape): Check for hex character overflow.
bfbbd7e7 3790
4e323265
LL
37912011-06-22 Leo Liu <sdl.web@gmail.com>
3792
3793 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
3794 Move to minibuffer.el.
3795
85fece3e
PE
37962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3797
20b84ce9 3798 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
3799 The following patches are for when GLYPH_DEBUG && !XASSERT.
3800 * dispextern.h (trace_redisplay_p, dump_glyph_string):
3801 * dispnew.c (flush_stdout):
3802 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
3803 Mark as externally visible.
3804 * dispnew.c (check_window_matrix_pointers): Now static.
3805 * dispnew.c (window_to_frame_vpos):
3806 * xfns.c (unwind_create_frame):
3807 * xterm.c (x_check_font): Remove unused local.
3808 * scroll.c (CHECK_BOUNDS):
3809 * xfaces.c (cache_fache): Rename local to avoid shadowing.
3810 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
3811 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
3812 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
3813 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
3814 Now static.
3815 (debug_method_add): Use va_list and vsprintf rather than relying
3816 on undefined behavior with wrong number of arguments.
3817 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
3818 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
3819 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
3820 since we're not interested in debugging glyphs with old libraries.
3821 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
3822 GCC 4.6.0's static checking.
3823
0766b489
PE
38242011-06-22 Paul Eggert <eggert@cs.ucla.edu>
3825
31fd4b32
PE
3826 Integer overflow and signedness fixes (Bug#8873).
3827 A few related buffer overrun fixes, too.
3828
b79e8648
PE
3829 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
3830
0766b489
PE
3831 * dispextern.h (struct face.stipple):
3832 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
3833 (x_bitmap_mask, x_allocate_bitmap_record)
3834 (x_create_bitmap_from_data, x_create_bitmap_from_file)
3835 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
3836 (x_create_bitmap_from_xpm_data):
3837 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
3838 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
3839 (.bitmaps_last):
3840 * xfaces.c (load_pixmap):
3841 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
3842 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
3843 (.bitmaps_last, struct x_output.icon_bitmap):
3844 Use ptrdiff_t, not int, for bitmap indexes.
3845 (x_allocate_bitmap_record): Check for size overflow.
3846 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
3847
b081724f
PE
3848 Use ptrdiff_t, not int, for overlay counts.
3849 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
3850 * editfns.c (overlays_around, get_pos_property):
3851 * textprop.c (get_char_property_and_overlay):
3852 * xdisp.c (next_overlay_change, note_mouse_highlight):
3853 * xfaces.c (face_at_buffer_position):
21514da7
PE
3854 * buffer.c (OVERLAY_COUNT_MAX): New macro.
3855 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
3856 (Fnext_overlay_change, Fprevious_overlay_change)
3857 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 3858 Use ptrdiff_t, not int, for sizes.
21514da7 3859 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 3860
3de73e5e
PE
3861 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
3862
2606c57b
PE
3863 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
3864 (x_session_initialize): Do not assume string length fits in int.
3865
aaafe47a
PE
3866 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
3867 This is unlikely, but can occur if DPI is outlandish.
3868
2674ddc8 3869 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
3870 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
3871
28154962
PE
3872 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
3873 * xrdb.c (magic_file_p, search_magic_path):
3874 Omit last arg SUFFIX; it was always 0. All callers changed.
3875 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
3876
7de51af5
PE
3877 * xfont.c (xfont_match): Avoid need for strlen.
3878
25ed6cc3
PE
3879 * xfns.c: Don't assume strlen fits in int.
3880 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
3881
4eab31dd
PE
3882 * xdisp.c (message_log_check_duplicate): Return intmax_t,
3883 not unsigned long, as we prefer signed integers. All callers changed.
3884 Detect integer overflow in repeat count.
3885 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 3886 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 3887
171e2a58
PE
3888 * termcap.c: Don't assume sizes fit in int and never overflow.
3889 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
3890 (gobble_line): Check for size-calculation overflow.
3891
ad39faca 3892 * minibuf.c (Fread_buffer):
6e5bb2dc 3893 * lread.c (intern, intern_c_string):
74ca2eb3
PE
3894 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
3895 Don't assume string length fits in int.
3896
52c61c22 3897 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
3898 * gtkutil.c (style_changed_cb): Avoid need for strlen.
3899
b5b8c9e5
PE
3900 * font.c: Don't assume string length fits in int.
3901 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
3902 Use ptrdiff_t, not int.
ccd6111c
PE
3903 (font_intern_prop): Don't assume string length fits in int.
3904 Don't assume integer property fits in fixnum.
3905 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 3906
882f0d81 3907 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 3908 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
3909 Reformulate so as not to need the command string.
3910 Invoke gzip -cd rather than gunzip, as it's more portable.
3911 (lock_info_type, lock_file_1, lock_file):
3912 Don't assume pid_t and time_t fit in unsigned long.
3913 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
3914 (current_lock_owner): Prefer signed type for sizes.
3915 Use memcpy, not strncpy, where memcpy is what is really wanted.
3916 Don't assume (via atoi) that time_t and pid_t fit in int.
3917 Check for time_t and/or pid_t out of range, e.g., via a network share.
3918 Don't alloca where an auto var works fine.
3919
93f4cf88
PE
3920 * fileio.c: Fix some integer overflow issues.
3921 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
3922 Don't assume string length fits in int.
3923 (directory_file_name): Don't assume string length fits in long.
3924 (make_temp_name): Don't assume pid fits in int, or that its print
3925 length is less than 20.
3926
f3e92b69
PE
3927 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
3928
1bfdaf10
PE
3929 * coding.c (make_subsidiaries): Don't assume string length fits in int.
3930
35016e9a
PE
3931 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
3932
3d1e65a1
PE
3933 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
3934 We prefer signed integers, even for size calculations.
3935
0b963a93
PE
3936 * emacs.c: Don't assume string length fits in 'int'.
3937 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
3938 (main): Don't invoke strlen when not needed.
3939
573f4b54
PE
3940 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
3941 (XD_DEBUG_MESSAGE): Don't waste a byte.
3942
989f33ba
PE
3943 * callproc.c (getenv_internal_1, getenv_internal)
3944 (Fgetenv_internal):
965d34eb
PE
3945 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
3946
e4d29b33
PE
3947 * lread.c (invalid_syntax): Omit length argument.
3948 All uses changed. This doesn't fix a bug, but it simplifies the
3949 code away from its former Hollerith-constant appearance, and it's
3950 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 3951 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 3952
eb49b136
PE
3953 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
3954 This didn't break anything, but it didn't help either.
3955 It's confusing to put a bogus integer in a place where the actual
3956 value does not matter.
9f62aeb1 3957 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 3958 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 3959
15375a22
PE
3960 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
3961 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
3962 implementation.
b61cc01c
PE
3963 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
3964 We prefer signed types, and the value cannot exceed the EMACS_INT
3965 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
3966 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
3967 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
3968 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 3969
53b2623d
PE
3970 * indent.c (sane_tab_width): New function.
3971 (current_column, scan_for_column, Findent_to, position_indentation)
3972 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 3973 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 3974
51cab52b 3975 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 3976
f2ed8a70
PE
3977 * lisp.h (lint_assume): New macro.
3978 * composite.c (composition_gstring_put_cache):
3979 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
3980
abe80cc6
PE
3981 * editfns.c, insdel.c:
3982 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 3983
b02c740e
PE
3984 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
3985
ebc96716
PE
3986 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
3987
b4e50fa0 3988 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 3989 Use much-faster test for byte-length change.
311d5d7c 3990 Don't assume string byte-length fits in 'int'.
a4cf38e4 3991 Check that character arg fits in 'int'.
85461888 3992 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 3993
c0c1ee9f
PE
3994 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
3995
a498d7f4
PE
3996 * fns.c (concat): Catch string overflow earlier.
3997 Do not rely on integer wraparound.
3998
51cab52b
PE
3999 * dispextern.h (struct it.overlay_strings_charpos)
4000 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
4001 * xdisp.c (forward_to_next_line_start)
4002 (back_to_previous_visible_line_start)
4003 (reseat_at_next_visible_line_start, next_element_from_buffer):
4004 Don't arbitrarily truncate the value of 'selective' to int.
4005
76031fad
PE
4006 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
4007
5eb55db9
PE
4008 * composite.c: Don't truncate sizes to 'int'.
4009 (composition_gstring_p, composition_reseat_it)
4010 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
4011 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
4012 not EMACS_UINT, for indexes.
5eb55db9 4013
0703a717
PE
4014 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
4015
d6202519
PE
4016 * buffer.c: Include <verify.h>.
4017 (struct sortvec.priority, struct sortstr.priority):
8961a454 4018 Now EMACS_INT, not int.
c20998a7 4019 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
4020 (struct sortstr.size, record_overlay_string)
4021 (struct sortstrlist.size, struct sortlist.used):
4022 Don't truncate size to int.
4023 (record_overlay_string): Check for size-calculation overflow.
d6202519 4024 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 4025
d5a19415
JM
40262011-06-22 Jim Meyering <meyering@redhat.com>
4027
029529ac 4028 Don't leak an XBM-image-sized buffer
d5a19415
JM
4029 * image.c (xbm_load): Free the image buffer after using it.
4030
a9041e6c
PE
40312011-06-21 Paul Eggert <eggert@cs.ucla.edu>
4032
4033 Port to Sun C.
4034 * composite.c (find_automatic_composition): Omit needless 'return 0;'
4035 that Sun C diagnosed.
4036 * fns.c (secure_hash): Fix pointer signedness issue.
4037 * intervals.c (static_offset_intervals): New function.
4038 (offset_intervals): Use it.
4039
7f3f739f
LL
40402011-06-21 Leo Liu <sdl.web@gmail.com>
4041
4042 * deps.mk (fns.o):
4043 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
4044 sha512.h.
4045
4046 * fns.c (secure_hash): Rename from crypto_hash_function and change
4047 the first arg to accept symbols.
5b66d427 4048 (Fsecure_hash): New primitive.
7f3f739f
LL
4049 (syms_of_fns): New symbols.
4050
76147d94
DD
40512011-06-20 Deniz Dogan <deniz@dogan.se>
4052
4053 * process.c (Fset_process_buffer): Clarify return value in
4054 docstring.
4055
7d7d0045
CY
40562011-06-18 Chong Yidong <cyd@stupidchicken.com>
4057
4058 * dispnew.c (add_window_display_history): Use BVAR.
4059
4060 * xdisp.c (debug_method_add): Use BVAR.
4061 (check_window_end, dump_glyph_matrix, dump_glyph)
4062 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
4063
4064 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
4065 Likewise.
4066
4067 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
4068 check till after the cache is created in init_frame_faces.
4069
ff2bc410
SM
40702011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
4071
4072 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
4073
28177add
PE
40742011-06-16 Paul Eggert <eggert@cs.ucla.edu>
4075
dd3482fe
PE
4076 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
4077 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
4078 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
4079
393d71f3 4080 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
4081 * fileio.c (Finsert_file_contents):
4082 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
4083 Remove the old (too-loose) buffer overflow checks.
4084 They weren't needed, since make_gap checks for buffer overflow.
4085 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
4086 The old code merely checked for Emacs fixnum overflow, and relied
4087 on undefined (wraparound) behavior. The new code avoids undefined
4088 behavior, and also checks for ptrdiff_t and/or size_t overflow.
4089
2e6813b0 4090 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
4091 Tune. Don't use wider integers than needed. Don't use alloca.
4092 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 4093
599a9e4f
PE
4094 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
4095
99561444
PE
4096 * insdel.c, lisp.h (buffer_overflow): New function.
4097 (insert_from_buffer_1, replace_range, replace_range_2):
4098 * insdel.c (make_gap_larger):
4099 * editfns.c (Finsert_char):
4100 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
4101
28177add
PE
4102 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
4103
e69dafad
PE
41042011-06-15 Paul Eggert <eggert@cs.ucla.edu>
4105
a7af7fde 4106 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 4107
b1c46f02
PE
4108 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
4109 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
4110
e69dafad
PE
4111 * fileio.c: Don't assume EMACS_INT fits in off_t.
4112 (emacs_lseek): New static function.
4113 (Finsert_file_contents, Fwrite_region): Use it.
4114 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
4115
566684ea
PE
4116 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
4117
e6966cd6
PE
4118 * fns.c: Don't overflow int when computing a list length.
4119 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
4120 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
4121 truncation on 64-bit hosts. Check for QUIT every
4122 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
4123 faster and is responsive enough.
4124 (Flength): Report an error instead of overflowing an integer.
4125 (Fsafe_length): Return a float if the value is not representable
4126 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 4127 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 4128 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 4129
dd0b0efb
PE
4130 * alloc.c: Check that resized vectors' lengths fit in fixnums.
4131 (header_size, word_size): New constants.
4132 (allocate_vectorlike): Don't check size overflow here.
4133 (allocate_vector): Check it here instead, since this is the only
4134 caller of allocate_vectorlike that could cause overflow.
4135 Check that the new vector's length is representable as a fixnum.
4136
86fe5cfe
PE
4137 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
4138 The previous code was bogus. For example, next_almost_prime (32)
4139 returned 39, which is undesirable as it is a multiple of 3; and
4140 next_almost_prime (24) returned 25, which is a multiple of 5 so
4141 why was the code bothering to check for multiples of 7?
4142
80e88859
PE
4143 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
4144
4a2f0ad6
PE
4145 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
4146
f66c7cf8
PE
4147 Variadic C functions now count arguments with ptrdiff_t.
4148 This partly undoes my 2011-03-30 change, which replaced int with size_t.
4149 Back then I didn't know that the Emacs coding style prefers signed int.
4150 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
4151 were being counted with int, which may truncate counts on 64-bit
4152 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
4153 * lisp.h (struct Lisp_Subr.function.aMANY)
4154 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
4155 Arg counts are now ptrdiff_t, not size_t.
4156 All variadic functions and their callers changed accordingly.
4157 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
4158 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
4159 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
4160 * callint.c (Fcall_interactively): Check arg count for overflow,
4161 to avoid potential buffer overrun. Use signed char, not 'int',
4162 for 'varies' array, so that we needn't bother to check its size
4163 calculation for overflow.
4164 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
4165 * eval.c (apply_lambda):
4166 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
4167 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
4168 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
4169
a1759b76
PE
4170 * callint.c (Fcall_interactively): Don't use index var as event count.
4171
d96be9fc
PE
4172 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
4173 * mem-limits.h (SIZE): Remove; no longer used.
4174
a690a978 4175 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 4176
578c21e6
PE
4177 Remove unnecessary casts.
4178 * xterm.c (x_term_init):
4179 * xfns.c (x_set_border_pixel):
4180 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
4181 These aren't needed now that we assume ANSI C.
4182
96f53c6c
PE
4183 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
4184 It's more likely to cause problems (due to unsigned overflow)
4185 than to cure them.
4186
83c77d31
PE
4187 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
4188
ee2079f1
PE
4189 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
4190
6da65536
PE
4191 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
4192
7147c4a4
PE
4193 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
4194
193e32d9
PE
4195 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
4196
e5533da6
PE
4197 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
4198
9910e595
PE
4199 GLYPH_CODE_FACE returns EMACS_INT, not int.
4200 * dispextern.h (merge_faces):
4201 * xfaces.c (merge_faces):
01103c44
PE
4202 * xdisp.c (get_next_display_element, next_element_from_display_vector):
4203 Don't assume EMACS_INT fits in int.
9910e595 4204
2638320e
PE
4205 * character.h (CHAR_VALID_P): Remove unused parameter.
4206 * fontset.c, lisp.h, xdisp.c: All uses changed.
4207
045eb8d9
PE
4208 * editfns.c (Ftranslate_region_internal): Omit redundant test.
4209
c1f134b5
PE
4210 * fns.c (concat): Minor tuning based on overflow analysis.
4211 This doesn't fix any bugs. Use int to hold character, instead
4212 of constantly refetching from Emacs object. Use XFASTINT, not
4213 XINT, for value known to be a character. Don't bother comparing
4214 a single byte to 0400, as it's always less.
4215
395fcb93 4216 * floatfns.c (Fexpt):
327eeec8
PE
4217 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
4218
abbd3d23
PE
4219 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
4220 for characters.
4221
684a03ef
PE
4222 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
4223
0fed43f3
PE
4224 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
4225 Without this fix, on a 64-bit host (aset S 0 4294967386) would
4226 incorrectly succeed when S was a string, because 4294967386 was
4227 truncated before it was used.
4228
8fd02eb7
PE
4229 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
4230 Otherwise, an out-of-range integer could cause undefined behavior
4231 on a 64-bit host.
4232
f8c86b69
PE
4233 * composite.c: Use int, not EMACS_INT, for characters.
4234 (fill_gstring_body, composition_compute_stop_pos): Use int, not
4235 EMACS_INT, for values that are known to be in character range.
4236 This doesn't fix any bugs but is the usual style inside Emacs and
4237 may generate better code on 32-bit machines.
4238
34206dd2
PE
4239 Make sure a 64-bit char is never passed to ENCODE_CHAR.
4240 This is for reasons similar to the recent CHAR_STRING fix.
4241 * charset.c (Fencode_char): Check that character arg is actually
4242 a character. Pass an int to ENCODE_CHAR.
4243 * charset.h (ENCODE_CHAR): Verify that the character argument is no
4244 wider than 'int', as a compile-time check to prevent future regressions
4245 in this area.
4246
c5958d4c 4247 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
4248
4249 Make sure a 64-bit char is never passed to CHAR_STRING.
4250 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
4251 by silently ignoring the top 32 bits, allowing some values
4252 that were far too large to be valid characters.
4253 * character.h: Include <verify.h>.
4254 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
4255 arguments are no wider than unsigned, as a compile-time check
4256 to prevent future regressions in this area.
4257 * data.c (Faset):
01103c44 4258 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
4259 (Fsubst_char_in_region):
4260 * fns.c (concat):
4261 * xdisp.c (decode_mode_spec_coding):
4262 Adjust to CHAR_STRING's new requirement.
4263 * editfns.c (Finsert_char, Fsubst_char_in_region):
4264 * fns.c (concat): Check that character args are actually
4265 characters. Without this test, these functions did the wrong
4266 thing with wildly out-of-range values on 64-bit hosts.
4267
d37ca623
PE
4268 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
4269 These casts should not be needed on 32-bit hosts, either.
4270 * keyboard.c (read_char):
4271 * lread.c (Fload): Remove casts to unsigned.
4272
ea204efb
PE
4273 * lisp.h (UNSIGNED_CMP): New macro.
4274 This fixes comparison bugs on 64-bit hosts.
4275 (ASCII_CHAR_P): Use it.
4276 * casefiddle.c (casify_object):
01103c44 4277 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
4278 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
4279 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
4280 * dispextern.h (FACE_FROM_ID):
4281 * keyboard.c (read_char): Use UNSIGNED_CMP.
4282
41cb286c
PE
4283 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
4284 not to EMACS_INT, to avoid GCC warning.
4285
4a1b9832
PE
4286 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
4287
55daad71
PE
4288 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
4289 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
4290 isn't needed on 32-bit machines.
8f95c75c 4291
01103c44
PE
4292 * buffer.c (Fgenerate_new_buffer_name):
4293 Use EMACS_INT for count, not int.
0ceccced 4294 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
4295
4296 * data.c (Qcompiled_function): Now static.
4297
c6f072e7
PE
4298 * window.c (window_body_lines): Now static.
4299
20ce5912
PE
4300 * image.c (gif_load): Rename local to avoid shadowing.
4301
9c4c5f81
PE
4302 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
4303 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
4304 * alloc.c (make_save_value): Integer argument is now of type
4305 ptrdiff_t, not int.
4306 (mark_object): Use ptrdiff_t, not int.
4307 * lisp.h (pD): New macro.
4308 * print.c (print_object): Use it.
4309
c0c5c8ae
PE
4310 * alloc.c: Use EMACS_INT, not int, to count objects.
4311 (total_conses, total_markers, total_symbols, total_vector_size)
4312 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
4313 (total_free_floats, total_floats, total_free_intervals)
4314 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
4315 Now EMACS_INT, not int. All uses changed.
4316 (Fgarbage_collect): Compute overall total using a double, so that
4317 integer overflow is less likely to be a problem. Check for overflow
4318 when converting back to an integer.
5a25e253
PE
4319 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
4320 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
4321 These were 'int' variables that could overflow on 64-bit hosts;
4322 they were never used, so remove them instead of repairing them.
211a0b2a 4323 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
4324 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
4325 Previously, this ceilinged at INT_MAX, but that doesn't work on
4326 64-bit machines.
e46bb31a 4327 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 4328
c78baabf 4329 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 4330 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
4331 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
4332 when a (possibly-narrower) signed value would do just as well.
4333 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 4334
c9d624c6
PE
4335 * alloc.c: Catch some string size overflows that we were missing.
4336 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
4337 for convenience in STRING_BYTES_MAX.
4338 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
4339 The definition here is exact; the one in lisp.h was approximate.
4340 (allocate_string_data): Check for string overflow. This catches
4341 some instances we weren't catching before. Also, it catches
4342 size_t overflow on (unusual) hosts where SIZE_MAX <= min
4343 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
4344 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 4345
c9d624c6
PE
4346 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
4347 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 4348 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 4349
353032ce
PE
4350 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
4351
2bccce07
PE
4352 * alloc.c (Fmake_string): Check for out-of-range init.
4353
0ac30604
SM
43542011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
4355
4356 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
4357
c195f2de
JD
43582011-06-14 Jan Djärv <jan.h.d@swipnet.se>
4359
4360 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
4361 xg_get_default_scrollbar_width.
4362
4363 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
4364 (int_gtk_range_get_value): Move to the scroll bar part of the file.
4365 (style_changed_cb): Call update_theme_scrollbar_width and call
4366 x_set_scroll_bar_default_width and xg_frame_set_char_size for
4367 all frames (Bug#8505).
4368 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
4369 Call gtk_window_set_resizable if HAVE_GTK3.
4370 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
4371 and height if HAVE_GTK3 (Bug#8505).
4372 (scroll_bar_width_for_theme): New variable.
4373 (update_theme_scrollbar_width): New function.
4374 (xg_get_default_scrollbar_width): Move code to
4375 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
4376 (xg_initialize): Call update_theme_scrollbar_width.
4377
4378 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
4379
4380 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
4381
e10ac9f1
MR
43822011-06-12 Martin Rudalics <rudalics@gmx.at>
4383
4384 * frame.c (make_frame): Call other_buffer_safely instead of
4385 other_buffer.
4386
4387 * window.c (temp_output_buffer_show): Call display_buffer with
4388 second argument Vtemp_buffer_show_specifiers and reset latter
4389 immediately after the call.
4390 (Vtemp_buffer_show_specifiers): New variable.
4391 (auto_window_vscroll_p, next_screen_context_lines)
4392 (Vscroll_preserve_screen_position): Remove leading asterisks from
4393 doc-strings.
4394
2d3c217e 43952011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 4396
7b7f97e8 4397 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
4398 * buffer.c (Qclone_number): Remove for now, as it's unused.
4399 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
4400 (record_buffer): Remove unused local.
4401 * frame.c (other_visible_frames, frame_buffer_list): Now static.
4402 (set_frame_buffer_list): Remove; unused.
4403 * frame.h (other_visible_frames): Remove decl.
4404 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
4405 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
4406 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
4407 if HAVE_GPM.
4408 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
4409 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
4410 Define only if HAVE_GPM.
4411 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
4412 (update_hints_inhibit): Remove; never set. All uses removed.
4413 * widgetprv.h (emacsFrameClassRec): Remove decl.
4414 * window.c (delete_deletable_window): Now returns void, since it
4415 wasn't returning anything.
4416 (compare_window_configurations): Remove unused locals.
4417 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
4418 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
4419 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
4420 the same widths as pointers. This follows up on the 2011-05-06 patch.
4421 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
4422 * xterm.h: Likewise.
4423 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
4424
1384b89e
JB
44252011-06-12 Juanma Barranquero <lekktu@gmail.com>
4426
4427 * makefile.w32-in: Update dependencies.
4428 (LISP_H): Add lib/intprops.h.
4429
1100a63c
CY
44302011-06-11 Chong Yidong <cyd@stupidchicken.com>
4431
4432 * image.c (gif_load): Add animation frame delay to the metadata.
4433 (syms_of_image): Use DEFSYM. New symbol `delay'.
4434
6198ccd0
MR
44352011-06-11 Martin Rudalics <rudalics@gmx.at>
4436
4437 * window.c (delete_deletable_window): Re-add.
4438 (Fset_window_configuration): Rewrite to handle dead buffers and
4439 consequently deletable windows.
4440 (window_tree, Fwindow_tree): Remove. Supply functionality in
4441 window.el.
4442 (compare_window_configurations): Simplify code.
4443
b6e3633c
AS
44442011-06-11 Andreas Schwab <schwab@linux-m68k.org>
4445
1ab0dee5
AS
4446 * image.c (imagemagick_load_image): Fix type mismatch.
4447 (Fimagemagick_types): Likewise.
4448
b6e3633c
AS
4449 * window.h (replace_buffer_in_windows): Declare.
4450
9397e56f
MR
44512011-06-11 Martin Rudalics <rudalics@gmx.at>
4452
4453 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
4454 Qclone_number. Remove external declaration of Qdelete_window.
4455 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
4456 code.
640c8776
SM
4457 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
4458 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
4459 (Fother_buffer): Rewrite doc-string. Major rewrite for new
4460 buffer list implementation.
4461 (other_buffer_safely): New function.
4462 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
4463 calls to replace_buffer_in_windows and
4464 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
4465 if allowed.
4466 (record_buffer): Inhibit quitting and rewrite using quittable
4467 functions. Run Qbuffer_list_update_hook if allowed.
4468 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
4469 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
4470 Move switch-to-buffer to window.el.
9397e56f
MR
4471 (bury-buffer): Move to window.el.
4472 (Vbuffer_list_update_hook): New variable.
4473
4474 * lisp.h (other_buffer_safely): Add prototype in buffer.c
4475 section.
4476
4477 * window.h (resize_frame_windows): Move up in code.
4478 (Fwindow_frame): Remove EXFUN.
4479 (replace_buffer_in_all_windows): Remove prototype.
4480 (replace_buffer_in_windows_safely): Add prototype.
4481
4482 * window.c: Declare Qdelete_window static again. Move down
4483 declaration of select_count.
4484 (Fnext_window, Fprevious_window): Rewrite doc-strings.
4485 (Fother_window): Move to window.el.
4486 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
4487 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
4488 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
4489 window.el.
4490 (replace_buffer_in_windows): Implement by calling
4491 Qreplace_buffer_in_windows.
4492 (replace_buffer_in_all_windows): Remove with some functionality
4493 moved into replace_buffer_in_windows_safely.
4494 (replace_buffer_in_windows_safely): New function.
4495 (select_window_norecord, select_frame_norecord): Move in front
4496 of run_window_configuration_change_hook. Remove now obsolete
4497 declarations.
640c8776
SM
4498 (Fset_window_buffer): Rewrite doc-string.
4499 Call Qrecord_window_buffer.
9397e56f
MR
4500 (keys_of_window): Move binding for other-window to window.el.
4501
b50691aa
CY
45022011-06-11 Chong Yidong <cyd@stupidchicken.com>
4503
4504 * dispextern.h (struct image): Replace data member, whose int_val
4505 and ptr_val fields were not used by anything, with a single
4506 lisp_val object.
4507
4508 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
4509 (gif_clear_image, gif_load, imagemagick_load_image)
4510 (gs_clear_image, gs_load): Callers changed.
4511
3f754b86
PE
45122011-06-10 Paul Eggert <eggert@cs.ucla.edu>
4513
cca69397
PE
4514 * buffer.h: Include <time.h>, for time_t.
4515 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
4516
109e28d0
PE
4517 Fix minor problems found by static checking.
4518
60737f02
PE
4519 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
4520
4b66faf3
PE
4521 Make identifiers static if they are not used in other modules.
4522 * data.c (Qcompiled_function, Qframe, Qvector):
4523 * image.c (QimageMagick, Qsvg):
4524 * minibuf.c (Qmetadata):
4525 * window.c (resize_window_check, resize_root_window): Now static.
4526 * window.h (resize_window_check, resize_root_window): Remove decls.
4527
109e28d0
PE
4528 * window.c (window_deletion_count, delete_deletable_window):
4529 Remove; unused.
46a4ce9e
PE
4530 (window_body_lines): Now static.
4531 (Fdelete_other_windows_internal): Mark vars as initialized.
4532 Make sure 'resize_failed' is initialized.
4533 (run_window_configuration_change_hook): Rename local to avoid shadowing.
4534 (resize_window_apply): Remove unused local.
4535 * window.h (delete_deletable_window): Remove decl.
4536
109e28d0 4537 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
4538 (imagemagick_load_image): Fix pointer signedness problem by changing
4539 last arg from unsigned char * to char *. All uses changed.
4540 Also, fix a local for similar reasons.
4541 Remove unused locals. Remove locals to avoid shadowing.
4542 (fn_rsvg_handle_free): Remove; unused.
4543 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 4544 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 4545
3f754b86
PE
4546 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
4547
2547adb1
CY
45482011-06-10 Chong Yidong <cyd@stupidchicken.com>
4549
4550 * image.c (gif_load): Fix omitted cast error introduced by
4551 2011-06-06 change.
4552
2c8e37d4
MR
45532011-06-10 Martin Rudalics <rudalics@gmx.at>
4554
4555 * window.h (resize_proportionally, orig_total_lines)
4556 (orig_top_line): Remove from window structure.
4557 (set_window_height, set_window_width, change_window_heights)
4558 (Fdelete_window): Remove prototypes.
4559 (resize_frame_windows): Remove duplicate declaration.
4560
440a42e3
EZ
45612011-06-10 Eli Zaretskii <eliz@gnu.org>
4562
4563 * window.h (resize_frame_windows, resize_window_check)
4564 (delete_deletable_window, resize_root_window)
4565 (resize_frame_windows): Declare prototypes.
4566
4567 * window.c (resize_window_apply): Make definition be "static" to
4568 match the prototype.
4569
562dd5e9
MR
45702011-06-10 Martin Rudalics <rudalics@gmx.at>
4571
4572 * window.c: Remove declarations of Qwindow_size_fixed,
4573 window_min_size_1, window_min_size_2, window_min_size,
4574 size_window, window_fixed_size_p, enlarge_window, delete_window.
4575 Remove static from declaration of Qdelete_window, it's
4576 temporarily needed by Fbury_buffer.
4577 (replace_window): Don't assign orig_top_line and
4578 orig_total_lines.
4579 (Fdelete_window, delete_window): Remove. Window deletion is
4580 handled by window.el.
640c8776
SM
4581 (window_loop): Remove DELETE_OTHER_WINDOWS case.
4582 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
4583 (Fdelete_other_windows): Remove. Deleting other windows is
4584 handled by window.el.
4585 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
4586 handled in window.el.
4587 (window_min_size_2, window_min_size_1, window_min_size): Remove.
4588 Window minimum sizes are handled in window.el.
4589 (shrink_windows, size_window, set_window_height)
4590 (set_window_width, change_window_heights, window_height)
4591 (window_width, CURBEG, CURSIZE, enlarge_window)
4592 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
4593 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
4594 handled in window.el.
4595 (make_dummy_parent): Rename to make_parent_window and give it a
4596 second argument horflag.
4597 (make_window): Don't set resize_proportionally any more.
4598 (Fsplit_window): Remove. Windows are split in window.el.
4599 (save_restore_action, save_restore_orig_size)
4600 (shrink_window_lowest_first, save_restore_orig_size): Remove.
4601 Resize mini windows in window.el.
4602 (grow_mini_window, shrink_mini_window): Implement by calling
4603 Qresize_root_window_vertically, resize_window_check and
4604 resize_window_apply.
640c8776
SM
4605 (saved_window, Fset_window_configuration, save_window_save):
4606 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
4607 resize_proportionally.
4608 (window_min_height, window_min_width): Move to window.el.
4609 (keys_of_window): Move bindings for delete-other-windows,
4610 split-window, delete-window and enlarge-window to window.el.
4611
4612 * buffer.c: Temporarily extern Qdelete_window.
4613 (Fbury_buffer): Temporarily call Qdelete_window instead of
4614 Fdelete_window (Fbury_buffer will move to window.el soon).
4615
4616 * frame.c (set_menu_bar_lines_1): Remove code handling
4617 orig_top_line and orig_total_lines.
4618
4619 * dispnew.c (adjust_frame_glyphs_initially): Don't use
4620 set_window_height but set heights directly.
4621 (change_frame_size_1): Use resize_frame_windows.
4622
4623 * xdisp.c (init_xdisp): Don't use set_window_height but set
4624 heights directly.
4625
640c8776
SM
4626 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
4627 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
4628 run_window_configuration_change_hook.
4629
4630 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
4631 instead of change_window_heights and run
4632 run_window_configuration_change_hook.
4633
1a13852e
MR
46342011-06-09 Martin Rudalics <rudalics@gmx.at>
4635
4636 * window.c (replace_window): Rename second argument REPLACEMENT to
4637 NEW. New third argument SETFLAG. Rewrite.
4638 (delete_window, make_dummy_parent): Call replace_window with
4639 third argument 1.
4640 (window_list_1): Move down in code.
4641 (run_window_configuration_change_hook): Move set_buffer part
4642 before select_frame_norecord part in order to unwind correctly.
4643 Rename count1 to count.
4644 (recombine_windows, delete_deletable_window, resize_root_window)
4645 (Fdelete_other_windows_internal)
4646 (Frun_window_configuration_change_hook, make_parent_window)
4647 (resize_window_check, resize_window_apply, Fresize_window_apply)
4648 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
4649 (Fdelete_window_internal, Fresize_mini_window_internal):
4650 New functions.
1a13852e
MR
4651 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
4652
f3d1777e
MR
46532011-06-08 Martin Rudalics <rudalics@gmx.at>
4654
496e208e
MR
4655 * window.h (window): Add some new members to window structure -
4656 normal_lines, normal_cols, new_total, new_normal, clone_number,
4657 splits, nest, prev_buffers, next_buffers.
4658 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 4659 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 4660
f3d1777e
MR
4661 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
4662 Remove.
496e208e
MR
4663 (make_dummy_parent): Set new members of windows structure.
4664 (make_window): Move down in code. Handle new members of window
4665 structure.
4666 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
4667 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
4668 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
4669 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
4670 (Fset_window_next_buffers, Fset_window_clone_number):
4671 New functions.
496e208e
MR
4672 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
4673 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
4674 Doc-string fixes.
4675 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
4676 Argument WINDOW can be now internal window too.
4677 (Fwindow_use_time): Move up in code.
4678 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
4679 Rewrite doc-string.
4680 (Fset_window_configuration, saved_window)
4681 (Fcurrent_window_configuration, save_window_save): Handle new
4682 members of window structure.
b9e809c2
MR
4683 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
4684 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
4685 (syms_of_window): New Lisp objects Qrecord_window_buffer,
4686 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
4687 Qget_mru_window, Qresize_root_window,
4688 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
4689 Qauto_buffer_name; staticpro them.
f3d1777e 4690
abde8f8c
MR
46912011-06-07 Martin Rudalics <rudalics@gmx.at>
4692
4693 * window.c (Fwindow_total_size, Fwindow_left_column)
4694 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
4695 (Fwindow_list_1): New functions.
4696 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
4697 (Fwindow_width, Fscroll_left, Fscroll_right):
4698 Use window_body_cols instead of window_box_text_cols.
4699 (delete_window, Fset_window_configuration):
4700 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
4701 (delete_all_subwindows): Take a window as argument and not a
4702 structure. Rewrite.
190b47e6
MR
4703 (window_loop): Remove handling of GET_LRU_WINDOW and
4704 GET_LARGEST_WINDOW.
4705 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
4706
4707 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
4708 window_box_text_cols. delete_all_subwindows now takes a
4709 Lisp_Object as argument.
abde8f8c 4710
640c8776
SM
4711 * indent.c (compute_motion, Fcompute_motion):
4712 Use window_body_cols instead of window_box_text_cols.
abde8f8c 4713
fa8a67e6
MR
4714 * frame.c (delete_frame): Call delete_all_subwindows with root
4715 window as argument.
4716
a54e3482
DC
47172011-06-07 Daniel Colascione <dan.colascione@gmail.com>
4718
4719 * fns.c (Fputhash): Document return value.
4720
60002bf5
CY
47212011-06-06 Chong Yidong <cyd@stupidchicken.com>
4722
4723 * image.c (gif_load): Implement gif89a spec "no disposal" method.
4724
0c671da6 47252011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 4726
b862a52a 4727 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 4728
be44ca6c
PE
4729 Check for overflow when converting integer to cons and back.
4730 * charset.c (Fdefine_charset_internal, Fdecode_char):
4731 Use cons_to_unsigned to catch overflow.
4732 (Fencode_char): Use INTEGER_TO_CONS.
4733 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
4734 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
4735 * data.c (long_to_cons, cons_to_long): Remove.
4736 (cons_to_unsigned, cons_to_signed): New functions.
4737 These signal an error for invalid or out-of-range values.
4738 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
4739 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
4740 * font.c (Ffont_variation_glyphs):
4741 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
4742 * lisp.h: Include <intprops.h>.
4743 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
4744 (cons_to_signed, cons_to_unsigned): New decls.
4745 (long_to_cons, cons_to_long): Remove decls.
4746 * undo.c (record_first_change): Use INTEGER_TO_CONS.
4747 (Fprimitive_undo): Use CONS_TO_INTEGER.
4748 * xfns.c (Fx_window_property): Likewise.
4749 * xselect.c: Include <limits.h>.
4750 (x_own_selection, selection_data_to_lisp_data):
4751 Use INTEGER_TO_CONS.
4752 (x_handle_selection_request, x_handle_selection_clear)
4753 (x_get_foreign_selection, Fx_disown_selection_internal)
4754 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
4755 (lisp_data_to_selection_data): Use cons_to_unsigned.
4756 (x_fill_property_data): Use cons_to_signed.
4757 Report values out of range.
4758
d1f3d2af
PE
4759 Check for buffer and string overflow more precisely.
4760 * buffer.h (BUF_BYTES_MAX): New macro.
4761 * lisp.h (STRING_BYTES_MAX): New macro.
4762 * alloc.c (Fmake_string):
4763 * character.c (string_escape_byte8):
4764 * coding.c (coding_alloc_by_realloc):
4765 * doprnt.c (doprnt):
4766 * editfns.c (Fformat):
4767 * eval.c (verror):
4768 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
4769 since they may not be the same number.
4770 * editfns.c (Finsert_char):
4771 * fileio.c (Finsert_file_contents):
4772 Likewise for BUF_BYTES_MAX.
4773
dd52fcea
PE
4774 * image.c: Use ptrdiff_t, not int, for sizes.
4775 (slurp_file): Switch from int to ptrdiff_t.
4776 All uses changed.
4777 (slurp_file): Check that file size fits in both size_t (for
4778 malloc) and ptrdiff_t (for sanity and safety).
4779
7f9bbdbb
PE
4780 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
4781 if b->modtime has its maximal value.
4782
dfe18f82
PE
4783 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
4784
84acfcf0
PE
4785 Don't assume time_t can fit into int.
4786 * buffer.h (struct buffer.modtime): Now time_t, not int.
4787 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
4788 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
4789
ccd9a01a
PE
4790 Minor fixes for signed vs unsigned integers.
4791 * character.h (MAYBE_UNIFY_CHAR):
4792 * charset.c (maybe_unify_char):
4793 * keyboard.c (read_char, reorder_modifiers):
4794 XINT -> XFASTINT, since the integer must be nonnegative.
4795 * ftfont.c (ftfont_spec_pattern):
4796 * keymap.c (access_keymap, silly_event_symbol_error):
4797 XUINT -> XFASTINT, since the integer must be nonnegative.
4798 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
4799 since it makes no difference and we prefer signed.
4800 * keyboard.c (record_char): Use XUINT when all the neighbors do.
4801 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
4802 nonnegative.
4803
d6d100dd
SM
48042011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
4805
4806 * window.h (Fwindow_frame): Declare.
4807
2b6148e4
PE
48082011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4809
4810 * alloc.c: Simplify handling of large-request failures (Bug#8800).
4811 (SPARE_MEMORY): Always define.
4812 (LARGE_REQUEST): Remove.
4813 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
4814
f230ecc9
MR
48152011-06-06 Martin Rudalics <rudalics@gmx.at>
4816
727e958e
MR
4817 * lisp.h: Move EXFUNS for Fframe_root_window,
4818 Fframe_first_window and Fset_frame_selected_window to window.h.
4819
4820 * window.h: Move EXFUNS for Fframe_root_window,
4821 Fframe_first_window and Fset_frame_selected_window here from
4822 lisp.h.
4823
4824 * frame.c (Fwindow_frame, Fframe_first_window)
4825 (Fframe_root_window, Fframe_selected_window)
4826 (Fset_frame_selected_window): Move to window.c.
4827 (Factive_minibuffer_window): Move to minibuf.c.
4828 (Fother_visible_frames_p): New function.
4829
4830 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
4831
f230ecc9
MR
4832 * window.c (decode_window, decode_any_window): Move up in code.
4833 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
4834 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
4835 (Fwindow_buffer): Move up and rewrite doc-string.
4836 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
4837 (Fwindow_prev): New functions.
727e958e
MR
4838 (Fwindow_frame): Move here from frame.c. Accept any window as
4839 argument.
4840 (Fframe_root_window, Fframe_first_window)
4841 (Fframe_selected_window): Move here from frame.c. Accept frame
4842 or arbitrary window as argument. Update doc-strings.
4843 (Fminibuffer_window): Move up in code.
4844 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
4845 (Fset_frame_selected_window): Move here from frame.c.
4846 Marginal rewrite.
727e958e
MR
4847 (Fselected_window, select_window, Fselect_window): Move up in
4848 code. Minor doc-string fixes.
f230ecc9 4849
4d09bcf6
PE
48502011-06-06 Paul Eggert <eggert@cs.ucla.edu>
4851
4852 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
4853 Do not assume that spare memory exists; that assumption is valid
4854 only if SYSTEM_MALLOC.
4855 (LARGE_REQUEST): New macro, so that the issue of large requests
4856 is separated from the issue of spare memory.
4857
810928a2
AS
48582011-06-05 Andreas Schwab <schwab@linux-m68k.org>
4859
172418ad
AS
4860 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
4861 format. (Bug#8806)
4862
43f862f7
AS
4863 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
4864
810928a2
AS
4865 * xfns.c (x_set_scroll_bar_default_width): Move declarations
4866 before statements.
4867
a059fe24
JD
48682011-06-05 Jan Djärv <jan.h.d@swipnet.se>
4869
4870 * gtkutil.c (xg_get_default_scrollbar_width): New function.
4871
4872 * gtkutil.h: Declare xg_get_default_scrollbar_width.
4873
4874 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
4875 min width by calling x_set_scroll_bar_default_width (Bug#8505).
4876
989bf368
JB
48772011-06-05 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
4880
4b80f674
CY
48812011-06-04 Chong Yidong <cyd@stupidchicken.com>
4882
4883 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
4884 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
4885 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
4886 New error handlers.
4b80f674
CY
4887 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
4888 Obey Vx_select_enable_clipboard_manager. Catch errors in
4889 x_clipboard_manager_save (Bug#8779).
4890 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 4891 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 4892
99a33b77 48932011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
4894
4895 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
4896
99a33b77 48972011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
4898
4899 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
4900 in the current matrix if keep_current_p is non-zero.
4901
8264569d
EZ
49022011-06-04 Eli Zaretskii <eliz@gnu.org>
4903
4904 * bidi.c (bidi_level_of_next_char): Fix last change.
4905
57f97249
EZ
49062011-06-03 Eli Zaretskii <eliz@gnu.org>
4907
fec2107c 4908 Support bidi reordering of text covered by display properties.
57f97249 4909
fec2107c
EZ
4910 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
4911 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
4912 (bidi_cache_search, bidi_cache_iterator_state)
4913 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
4914 (bidi_level_of_next_char, bidi_move_to_visually_next):
4915 Support character positions inside a run of characters covered by a
fec2107c
EZ
4916 display string.
4917 (bidi_paragraph_init, bidi_resolve_explicit_1)
4918 (bidi_level_of_next_char): Call bidi_fetch_char and
4919 bidi_fetch_char_advance instead of FETCH_CHAR and
4920 FETCH_CHAR_ADVANCE.
4921 (bidi_init_it): Initialize new members.
4922 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
4923 definitions.
4924 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
4925 instead of using explicit *_CHAR codes.
d6d100dd
SM
4926 (bidi_resolve_explicit, bidi_resolve_weak):
4927 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
4928 bidirectional text is supported only in multibyte buffers.
4929 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
4930 it to initialize the frame_window_p member of struct bidi_it.
4931 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
4932 (bidi_resolve_explicit, bidi_resolve_weak)
4933 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
4934 bidi_it->nchars is non-positive.
4935 (bidi_level_of_next_char): Don't try to lookup the cache for the
4936 next/previous character if nothing is cached there yet, or if we
4937 were just reseat()'ed to a new position.
c40e2fb2 4938
0e14fe90
EZ
4939 * xdisp.c (set_cursor_from_row): Set start and stop points
4940 according to the row's direction when priming the loop that looks
4941 for the glyph on which to display cursor.
4942 (single_display_spec_intangible_p): Function deleted.
4943 (display_prop_intangible_p): Reimplement to call
4944 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
4945 Accept 3 additional arguments needed by handle_display_spec.
4946 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
4947 values: lists, `(when COND...)' forms, etc.
4948 (single_display_spec_string_p): Support property values that are
4949 lists with the argument STRING its top-level element.
4950 (display_prop_string_p): Fix the condition for processing a
4951 property that is a list to be consistent with handle_display_spec.
fec2107c 4952 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
4953 last portion of handle_display_prop.
4954 (compute_display_string_pos): Accept additional argument
4955 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
4956 value of a `display' property is a "replacing spec".
4957 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
4958 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
4959 the display property, but just return a value indicating whether
4960 the display property will replace the characters it covers.
4961 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
4962 frame_window_p members of struct bidi_it.
d6d100dd
SM
4963 (compute_display_string_pos, compute_display_string_end):
4964 New functions.
fec2107c
EZ
4965 (push_it): Accept second argument POSITION, where pop_it should
4966 jump to continue iteration.
4967 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 4968
fec2107c
EZ
4969 * keyboard.c (adjust_point_for_property): Adjust the call to
4970 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
4971
4972 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
4973 (bidi_init_it): Update prototypes.
4974 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
4975 (compute_display_string_pos, compute_display_string_end):
4976 Declare prototypes.
fec2107c
EZ
4977 (struct bidi_it): New members nchars and disp_pos. ch_len is now
4978 EMACS_INT.
fc6f18ce 4979
40087514 49802011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 4981
57f53182
PE
4982 Malloc failure behavior now depends on size of allocation.
4983 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
4984 * lisp.h: Change signatures accordingly.
4985 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
4986 All callers changed. (Bug#8762)
4987
4988 * gnutls.c: Use Emacs's memory allocators.
4989 Without this change, the gnutls library would invoke malloc etc.
4990 directly, which causes problems on non-SYNC_INPUT hosts, and which
4991 runs afoul of improving memory_full behavior. (Bug#8761)
4992 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
4993 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
4994 xfree instead of the default malloc, realloc, free.
4995 (Fgnutls_boot): No need to check for memory allocation failure,
4996 since xmalloc does that for us.
4997
ac32cd99 4998 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
4999 * category.c (hash_get_category_set):
5000 * ccl.c (ccl_driver):
5001 * charset.c (Fdefine_charset_internal):
5002 * charset.h (struct charset.hash_index):
5003 * composite.c (get_composition_id, gstring_lookup_cache)
5004 (composition_gstring_put_cache):
5005 * composite.h (struct composition.hash_index):
5006 * dispextern.h (struct image.hash):
5007 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
5008 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
5009 (hashfn_equal, hashfn_user_defined, make_hash_table)
5010 (maybe_resize_hash_table, hash_lookup, hash_put)
5011 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
5012 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
5013 (Fsxhash, Fgethash, Fputhash, Fmaphash):
5014 * image.c (make_image, search_image_cache, lookup_image)
5015 (xpm_put_color_table_h):
5016 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 5017 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 5018 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 5019 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
5020 * alloc.c (allocate_vectorlike):
5021 Check for overflow in vector size calculations.
5022 * ccl.c (ccl_driver):
5023 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
5024 * fns.c, image.c: Remove unnecessary static decls that would otherwise
5025 need to be updated by these changes.
40087514
PE
5026 * fns.c (make_hash_table, maybe_resize_hash_table):
5027 Check for integer overflow with large hash tables.
0de4bb68
PE
5028 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
5029 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
5030 (SXHASH_REDUCE): New macro.
5031 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
5032 Use it instead of discarding useful hash info with large hash values.
5033 (sxhash_float): New function.
5034 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
5035 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
5036 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
5037 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
5038 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
5039 Adjust signatures to match updated version of code.
5040 (consing_since_gc): Now EMACS_INT, since a single hash table can
5041 use more than INT_MAX bytes.
5042
698d32e2
DN
50432011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
5044
5045 Make it possible to build with GCC-4.6+ -O2 -flto.
5046
5047 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
5048
fd6fa53f
SM
50492011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
5050
5051 * minibuf.c (get_minibuffer, read_minibuf_unwind):
5052 Call minibuffer-inactive-mode.
5053
864db017
JB
50542011-05-31 Juanma Barranquero <lekktu@gmail.com>
5055
5056 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
5057 Update dependencies.
5058
2ad0baf4
DN
50592011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5060
5061 * data.c (init_data): Remove code for UTS, this system is not
5062 supported anymore.
5063
4fcc2638
DN
50642011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5065
5066 Don't force ./temacs to start in terminal mode.
5067
5068 * frame.c (make_initial_frame): Initialize faces in all cases, not
5069 only when CANNOT_DUMP is defined.
5070 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
5071
c56e0fd5
DN
50722011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5073
5074 * dispnew.c (add_window_display_history): Use const for the string
5075 pointer. Remove declaration, not needed.
5076
333d54da 50772011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 5078
55d4c1b2 5079 Use 'inline', not 'INLINE'.
333d54da 5080 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
5081 * alloc.c, fontset.c (INLINE): Remove.
5082 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
5083 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
5084 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
5085 * gmalloc.c (register_heapinfo): Use inline unconditionally.
5086 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
5087
738db178
DN
50882011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
5089
5090 Make it possible to run ./temacs.
5091
5092 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
5093 syms_of_callproc does the same thing. Remove test for
5094 "initialized", do it in the caller.
5095 * emacs.c (main): Avoid calling set_initial_environment when dumping.
5096
620c53a6
SM
50972011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
5098
5099 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
5100 (read_minibuf): Use get_minibuffer.
5101 (syms_of_minibuf): Use DEFSYM.
5102 (Qmetadata): New var.
5103 * data.c (Qbuffer): Don't make it static.
5104 (syms_of_data): Use DEFSYM.
5105
e003a292
PE
51062011-05-31 Paul Eggert <eggert@cs.ucla.edu>
5107
5108 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
5109 (CCL_CODE_MIN): New macro.
5110
ed008a6d
PE
51112011-05-30 Paul Eggert <eggert@cs.ucla.edu>
5112
3687c2ef
PE
5113 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
5114
ed008a6d
PE
5115 * eval.c (Qdebug): Now static.
5116 * lisp.h (Qdebug): Remove decl. This reverts a part of the
5117 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
5118 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
5119
d66c4c7c
CY
51202011-05-29 Chong Yidong <cyd@stupidchicken.com>
5121
5122 * image.c: Various fixes to ImageMagick code comments.
5123 (Fimagemagick_types): Doc fix.
5124
5fbc2025
PE
51252011-05-29 Paul Eggert <eggert@cs.ucla.edu>
5126
0196f88a
PE
5127 Minor fixes prompted by GCC 4.6.0 warnings.
5128
5129 * xselect.c (converted_selections, conversion_fail_tag): Now static.
5130
5fbc2025
PE
5131 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
5132 (x_clipboard_manager_save_all): Move extern decl to ...
5133 * xterm.h: ... here, so that it can be checked for consistency.
5134
1dd3c2d9
CY
51352011-05-29 Chong Yidong <cyd@stupidchicken.com>
5136
5137 * xselect.c (x_clipboard_manager_save_frame)
5138 (x_clipboard_manager_save_all): New functions.
5139 (Fx_clipboard_manager_save): Lisp function deleted.
5140
5141 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
5142 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
5143
5144 * xterm.h: Update prototype.
5145
5ba6571d
WX
51462011-05-28 William Xu <william.xwl@gmail.com>
5147
5148 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
5149 exiting (Bug#8239).
5150
3eaff834
JM
51512011-05-28 Jim Meyering <meyering@redhat.com>
5152
e1900994 5153 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
5154 * fns.c (to_uchar): Define.
5155 (crypto_hash_function): Use it to convert some newly-signed
5156 variables to unsigned, to avoid sign-extension bugs. For example,
5157 without this change, (md5 "truc") would evaluate to
5158 45723a2aff78ff4fff7fff1114760e62 rather than the expected
5159 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 5160 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 5161
0f6990a7
PE
51622011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5163
5164 Integer overflow fixes.
c8a9ca5a 5165
08686060
PE
5166 * dbusbind.c: Serial number integer overflow fixes.
5167 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
5168 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
5169 to hold a serial number that is too large for a fixnum.
5170 (Fdbus_method_return_internal, Fdbus_method_error_internal):
5171 Check for serial numbers out of range. Decode any serial number
59568bf0 5172 that was so large that it became a float. (Bug#8722)
08686060 5173
2d1fc3c7
PE
5174 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
5175 (Fdbus_call_method, Fdbus_call_method_asynchronously):
5176 Use XFASTINT rather than XUINT when numbers are nonnegative.
5177 (xd_append_arg, Fdbus_method_return_internal):
5178 (Fdbus_method_error_internal): Likewise. Also, for unsigned
5179 arguments, check that Lisp number is nonnegative, rather than
59568bf0 5180 silently wrapping negative numbers around. (Bug#8722)
30217ff0 5181 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 5182 (Bug#8722)
2d1fc3c7 5183
c8a9ca5a
PE
5184 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
5185
519e1d69
PE
5186 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
5187
30569699
PE
5188 ccl: add integer overflow checks
5189 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
5190 (IN_INT_RANGE): New macros.
5191 (ccl_driver): Use them to check for integer overflow when
5192 decoding a CCL program. Many of the new checks are whether XINT (x)
5193 fits in int; it doesn't always, on 64-bit hosts. The new version
5194 doesn't catch all possible integer overflows, but it's an
847044ea 5195 improvement. (Bug#8719)
30569699 5196
c11285dc
PE
5197 * alloc.c (make_event_array): Use XINT, not XUINT.
5198 There's no need for unsigned here.
5199
fdccd48e
PE
5200 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
5201 This follows up to the 2011-05-06 change that substituted uintptr_t
5202 for EMACS_INT. This case wasn't caught back then.
5203
37910ab2
PE
5204 Rework Fformat to avoid integer overflow issues.
5205 * editfns.c: Include <float.h> unconditionally, as it's everywhere
5206 now (part of C89). Include <verify.h>.
5207 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
5208 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
5209 (Fformat): Avoid the prepass trying to compute sizes; it was only
5210 approximate and thus did not catch overflow reliably. Instead, walk
5211 through the format just once, formatting and computing sizes as we go,
5212 checking for integer overflow at every step, and allocating a larger
5213 buffer as needed. Keep track separately whether the format is
5214 multibyte. Keep only the most-recently calculated precision, rather
5215 than them all. Record whether each argument has been converted to
5216 string. Use EMACS_INT, not int, for byte and char and arg counts.
5217 Support field widths and precisions larger than INT_MAX. Avoid
5218 sprintf's undefined behavior with conversion specifications such as %#d
5219 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
5220 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
5221 formatting out-of-range floating point numbers with int
9173deec 5222 formats. (Bug#8668)
37910ab2 5223
2e6578fb
PE
5224 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
5225
0ae6bdee
PE
5226 * data.c: Avoid integer truncation in expressions involving floats.
5227 * data.c: Include <intprops.h>.
5228 (arith_driver): When there's an integer overflow in an expression
5229 involving floating point, convert the integers to floating point
5230 so that the resulting value does not suffer from catastrophic
5231 integer truncation. For example, on a 64-bit host (* 4
5232 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
5233 Do not rely on undefined behavior after integer overflow.
5234
de883a70
PE
5235 merge count_size_as_multibyte, parse_str_to_multibyte
5236 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 5237 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
5238 Check for integer overflow.
5239 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
5240 since it's now a duplicate of the other. This is more of
5241 a character than a buffer op, so better that it's in character.c.
5242 * fns.c, print.c: Adjust to above changes.
5243
2ff916cb
PE
52442011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
5245
5246 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
5247
f1b54466
PE
52482011-05-27 Paul Eggert <eggert@cs.ucla.edu>
5249
fb1ac845
PE
5250 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5251 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
5252 (x_clipboard_manager_save): Now static.
5253 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
5254
f1b54466
PE
5255 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
5256 (crypto_hash_function): Now static.
5257 Fix pointer signedness problems. Avoid unnecessary initializations.
5258
a9f737ee
CY
52592011-05-27 Chong Yidong <cyd@stupidchicken.com>
5260
5261 * termhooks.h (Vselection_alist): Make it terminal-local.
5262
5263 * terminal.c (create_terminal): Initialize it.
5264
5265 * xselect.c: Support for clipboard managers.
5266 (Vselection_alist): Move to termhooks.h as terminal-local var.
5267 (LOCAL_SELECTION): New macro.
5268 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
5269 (symbol_to_x_atom): Remove gratuitous arg.
5270 (x_handle_selection_request, lisp_data_to_selection_data)
5271 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
5272 (x_own_selection, x_get_local_selection, x_convert_selection):
5273 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
5274 (some_frame_on_display): Delete unused function.
5275 (Fx_own_selection_internal, Fx_get_selection_internal)
5276 (Fx_disown_selection_internal, Fx_selection_owner_p)
5277 (Fx_selection_exists_p): New optional frame arg.
5278 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
5279 (x_handle_selection_clear): Don't treat other terminals with the
5280 same keyboard specially. Use the terminal-local Vselection_alist.
5281 (x_clear_frame_selections): Use Frun_hook_with_args.
5282
5283 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
5284
5285 * xterm.h: Add support for those atoms.
5286
e067f0c1
CY
52872011-05-26 Chong Yidong <cyd@stupidchicken.com>
5288
5289 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
5290 (converted_selections, conversion_fail_tag): New global variables.
5291 (x_selection_request_lisp_error): Free the above.
5292 (x_get_local_selection): Remove unnecessary code.
5293 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
5294 of converted selections stored in converted_selections.
5295 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
5296 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
5297 (x_convert_selection): New function.
5298 (x_handle_selection_event): Simplify.
5299 (x_get_foreign_selection): Don't ignore incoming requests while
5300 waiting for an answer; this will fail when we implement
5301 SAVE_TARGETS, and seems unnecessary anyway.
5302 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
5303 (Vx_sent_selection_functions): Doc fix.
5304
0f4aebc0
LL
53052011-05-26 Leo Liu <sdl.web@gmail.com>
5306
5307 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
5308
e61124cd
YM
53092011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5310
5311 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
5312
5313 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
5314 for fringe update if it has periodic bitmap.
ac389d0c 5315 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
5316 and fringe_bitmap_periodic_p.
5317
5318 * fringe.c (get_fringe_bitmap_data): New function.
5319 (draw_fringe_bitmap_1, update_window_fringes): Use it.
5320 (update_window_fringes): Record periodicity of fringe bitmap in glyph
5321 row. Mark glyph row for fringe update if periodicity changed.
5322
5323 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
5324 for fringe update unless it has periodic bitmap.
5325
f16d9837
KH
53262011-05-25 Kenichi Handa <handa@m17n.org>
5327
5328 * xdisp.c (get_next_display_element): Set correct it->face_id for
5329 a static composition.
5330
e1b90ef6
LL
53312011-05-24 Leo Liu <sdl.web@gmail.com>
5332
5333 * deps.mk (fns.o):
5334 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
5335
5336 * fns.c (crypto_hash_function, Fsha1): New function.
5337 (Fmd5): Use crypto_hash_function.
5338 (syms_of_fns): Add Ssha1.
5339
7400048f
PE
53402011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5341
5342 * gnutls.c: Remove unused macros.
5343 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
5344 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
5345 Remove macros that are defined and never used.
5346 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
5347
abb71cf4
CY
53482011-05-22 Chong Yidong <cyd@stupidchicken.com>
5349
5350 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
5351 (Fx_get_selection_internal): Minor cleanup.
5352 (Fx_own_selection_internal): Rename arguments for consistency with
5353 select.el.
5354
6307db39
PE
53552011-05-22 Paul Eggert <eggert@cs.ucla.edu>
5356
5357 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
5358
f3d4e0a4
CY
53592011-05-22 Chong Yidong <cyd@stupidchicken.com>
5360
5361 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
5362
4d8ade89
YM
53632011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5364
5365 * dispnew.c (scrolling_window): Don't exclude the case that the
5366 last enabled row in the desired matrix touches the bottom boundary.
5367
32078c8d
GM
53682011-05-21 Glenn Morris <rgm@gnu.org>
5369
5370 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
5371 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
5372 and add some more files.
32078c8d 5373
7285dc67
EZ
53742011-05-20 Eli Zaretskii <eliz@gnu.org>
5375
5376 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
5377 report_file_error introduced by the change from 2011-05-07.
5378
89d1bd22
PE
53792011-05-20 Paul Eggert <eggert@cs.ucla.edu>
5380
5381 * systime.h (Time): Define only if emacs is defined.
5382 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
5383 where the include path doesn't have X11/X.h by default. See
5384 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
5385
e23640bb 53862011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
5387
5388 * composite.c (find_automatic_composition): Fix previous change.
5389
b9704ad9
GM
53902011-05-20 Glenn Morris <rgm@gnu.org>
5391
5392 * lisp.mk: New file, split from Makefile.in.
5393 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
5394 (shortlisp): Remove.
5395 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
5396
4a720484
GM
53972011-05-19 Glenn Morris <rgm@gnu.org>
5398
5399 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
5400 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
5401 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
5402 (lisp): Set the order to that of loadup.el.
5403 (shortlisp): Make it a copy of $lisp.
5404 (SOME_MACHINE_LISP): Remove.
5405 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
5406 Use just $shortlisp, not $SOME_MACHINE_LISP too.
5407
a28d4396
KH
54082011-05-18 Kenichi Handa <handa@m17n.org>
5409
5410 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
5411 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
5412 (find_automatic_composition): Mostly rewrite for efficiency.
5413
a2b1fa8e
JB
54142011-05-18 Juanma Barranquero <lekktu@gmail.com>
5415
5416 * makefile.w32-in: Update dependencies.
5417
8e1f5610
CS
54182011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
5419
5420 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 5421 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 5422
7025ee00 54232011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 5424
cdfa6eab
PE
5425 Fix some integer overflow issues, such as string length overflow.
5426
06d6db33
PE
5427 * insdel.c (count_size_as_multibyte): Check for string overflow.
5428
2b4560a8
PE
5429 * character.c (lisp_string_width): Check for string overflow.
5430 Use EMACS_INT, not int, for string indexes and lengths; in
5431 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
5432 the resulting string length overflows an EMACS_INT; instead,
5433 report a string overflow if no precision given. When checking for
5434 precision exhaustion, use a check that cannot possibly have
5435 integer overflow. (Bug#8675)
5436 * character.h (lisp_string_width): Adjust to new signature.
5437
cb93f9be
PE
5438 * alloc.c (string_overflow): New function.
5439 (Fmake_string): Use it. This doesn't change behavior, but saves
5440 a few bytes and will simplify future changes.
5441 * character.c (string_escape_byte8): Likewise.
5442 * lisp.h (string_overflow): New decl.
5443
1a1f3366
PE
5444 Fixups, following up to the user-interface timestamp change.
5445 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
5446 for UI timestamps, instead of unsigned long.
9fbd6841
PE
5447 * msdos.c (mouse_get_pos): Likewise.
5448 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
5449 * w32gui.h (Time): Define by including "systime.h" rather than by
5450 declaring it ourselves. (Bug#8664)
5451
d4e3e4d3
PE
5452 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
5453 * image.c (clear_image_cache): Likewise.
5454
f6a24d19
PE
5455 * term.c (term_mouse_position): Don't assume time_t wraparound.
5456
08dc5ae6
PE
5457 Be more systematic about user-interface timestamps.
5458 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
5459 and sometimes 'EMACS_UINT', to represent these timestamps.
5460 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
5461 This makes the code easier to follow, and makes it easier to catch
5462 integer overflow bugs such as Bug#8664.
5463 * frame.c (Fmouse_position, Fmouse_pixel_position):
5464 Use Time, not unsigned long, for user-interface timestamps.
5465 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
5466 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
5467 * keyboard.h (last_event_timestamp): Likewise.
5468 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
5469 * menu.h (xmenu_show): Likewise.
5470 * term.c (term_mouse_position): Likewise.
5471 * termhooks.h (struct input_event.timestamp): Likewise.
5472 (struct terminal.mouse_position_hook): Likewise.
5473 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
5474 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
5475 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
5476 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
5477 what it was before.
5478 * menu.h, termhooks.h: Include "systime.h", for Time.
5479
8e55734a
PE
5480 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
5481 Don't assume that the difference between two unsigned long values
5482 can fit into an integer. At this point, we know button_down_time
5483 <= event->timestamp, so the difference must be nonnegative, so
5484 there's no need to cast the result if double-click-time is
5485 nonnegative, as it should be; check that it's nonnegative, just in
5486 case. This bug is triggered when events are more than 2**31 ms
86db42d2 5487 apart (about 25 days). (Bug#8664)
8e55734a 5488
841f1b75 5489 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 5490 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 5491
3e26f69c
PE
5492 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
5493 that always fit in int. Use a sentinel instead of a counter, to
5494 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
5495 * frame.h (struct frame): Use int for menu_bar_items_used
5496 instead of EMACS_INT, since it always fits in int.
3e26f69c 5497
5cc152c0
PE
5498 * menu.c (grow_menu_items): Check for int overflow.
5499
d89eb65e
PE
5500 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
5501
5235bd3e
PE
5502 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
5503 Before, the code was not consistent. These values cannot exceed
5504 2**31 - 1 so there's no need to make them unsigned.
5505 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
5506 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
5507 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
5508 as modifiers.
5509 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
5510
bc827e23
PE
5511 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
5512 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
5513 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
5514 presumably because the widths might not match.
5515
78eb494e
PE
5516 * window.c (size_window): Avoid needless test at loop start.
5517
04f2d78b
CB
55182011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
5519
5520 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
5521
d2fc7e3d 55222011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
5523
5524 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
5525
d2fc7e3d 55262011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
5527
5528 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
5529 `width' to `bar_area_x' and `bar_area_width', respectively.
5530 (x_scroll_run): Take account of fringe background extension.
5531
04f2d78b
CB
5532 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
5533 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
5534 `bar_area_width', respectively.
5535 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
5536 background extension.
5537
79b70037
GM
55382011-05-10 Jim Meyering <meyering@redhat.com>
5539
5540 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
5541
2f142cc5
JB
55422011-05-10 Juanma Barranquero <lekktu@gmail.com>
5543
5544 * image.c (Finit_image_library): Return t for built-in image types,
5545 like pbm and xbm. (Bug#8640)
5546
57679c86
AS
55472011-05-09 Andreas Schwab <schwab@linux-m68k.org>
5548
5549 * w32menu.c (set_frame_menubar): Fix submenu allocation.
5550
888c9e86
EZ
55512011-05-07 Eli Zaretskii <eliz@gnu.org>
5552
b0512a1d
EZ
5553 * w32console.c (Fset_screen_color): Doc fix.
5554 (Fget_screen_color): New function.
5555 (syms_of_ntterm): Defsubr it.
5556
7285dc67
EZ
5557 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
5558 unlink the temporary file if Fcall_process didn't create it in the
5559 first place.
5560 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
5561 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
5562 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
5563 cue to call_process_cleanup not to close that handle.
5564
4d3fcc8e
BK
55652011-05-07 Ben Key <bkey76@gmail.com>
5566
5567 * makefile.w32-in: The bootstrap-temacs rule now makes use of
5568 one of two shell specific rules, either bootstrap-temacs-CMD or
5569 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
5570 to the previous implementation of the bootstrap-temacs rule.
5571 The bootstrap-temacs-CMD rule is similar to the previous
5572 implementation of the bootstrap-temacs rule except that it
5573 makes use of the ESC_CFLAGS variable instead of the CFLAGS
5574 variable.
5575
5576 These changes, along with some changes to nt/configure.bat,
5577 nt/gmake.defs, and nt/nmake.defs, are required to extend my
5578 earlier fix to add support for --cflags and --ldflags options
5579 that include quotes so that it works whether make uses cmd or
5580 sh as the shell.
5581
b4289b64
MA
55822011-05-06 Michael Albinus <michael.albinus@gmx.de>
5583
5584 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
5585 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
5586 is a constant.
5587 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
5588 a string. Handle both cases.
5589 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
5590 (Fdbus_register_method): Use Qinvalid_function.
5591
af4c0e28
JB
55922011-05-06 Juanma Barranquero <lekktu@gmail.com>
5593
5594 * makefile.w32-in: Update dependencies.
5595 (LISP_H): Add inttypes.h and stdin.h.
5596 (PROCESS_H): Add unistd.h.
5597
c51453d9
EZ
55982011-05-06 Eli Zaretskii <eliz@gnu.org>
5599
5600 * lread.c: Include limits.h (fixes the MS-Windows build broken by
5601 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
5602
8ff0ac3c 56032011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 5604
4c4b566b
PE
5605 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
5606
aab2b9b5
PE
5607 * term.c (vfatal): Remove stray call to va_end.
5608 It's not needed and the C Standard doesn't allow it here anyway.
5609
c378da0b
PE
5610 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
5611 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
5612
288b08c7
PE
5613 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
5614 bytes.
5615
e3601888
PE
5616 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
5617
db6c0e74
PE
5618 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5619
dd5963ea
PE
5620 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
5621
88c9450f
PE
5622 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
5623
2f9442b8
PE
5624 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
5625
c032b5f8
PE
5626 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
5627 * charset.c (Fdefine_charset_internal): Don't initialize
5628 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 5629 32-bit int (Bug#8600).
a108c10b
PE
5630
5631 * lread.c (read_integer): Be more consistent with string-to-number.
5632 Use string_to_number to do the actual conversion; this avoids
5633 rounding errors and fixes some other screwups. Without this fix,
5634 for example, #x1fffffffffffffff was misread as -2305843009213693952.
5635 (digit_to_number): Move earlier, for benefit of read_integer.
5636 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 5637 not a digit in any supported base. (Bug#8602)
a108c10b 5638
ad5f9eea
PE
5639 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
5640
aec1708a
PE
5641 * dispnew.c (scrolling_window): Return 1 if we scrolled,
5642 to match comment at start of function. This also removes a
5643 GCC warning about overflow in a 32+64-bit port.
5644
47be4ab5
PE
5645 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
5646
371cac43
PE
5647 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
5648 Reported by Stefan Monnier in
5649 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
5650 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5651 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 5652
d01a7826
PE
5653 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
5654 (EMACS_UINTPTR): Likewise, with uintptr_t.
5655
7fd47d5c
PE
5656 * lisp.h: Prefer 64-bit EMACS_INT if available.
5657 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
5658 on 32-bit hosts that have 64-bit int, so that they can access
5659 large files.
122b0c86
PE
5660 However, temporarily disable this change unless the temporary
5661 symbol WIDE_EMACS_INT is defined.
7fd47d5c 5662
8727937b
PE
5663 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
5664
8ac068ac
PE
5665 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
5666 This removes an assumption that EMACS_INT and long are the same
5667 width as pointers. The assumption is true for Emacs porting targets
5668 now, but we want to make other targets possible.
5669 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
5670 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
5671 In the rest of the code, change types of integers that hold casted
5672 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
5673 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
5674 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
5675 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
5676 No need to cast type when ORing.
5677 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
5678 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
5679 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
5680 assume EMACS_INT is the same width as char *.
5681 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
5682 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
5683 Remove no-longer-needed casts.
5684 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
5685 (xg_tool_bar_help_callback, xg_make_tool_item):
5686 Use EMACS_INTPTR to hold an integer
5687 that will be cast to void *; this can avoid a GCC warning
5688 if EMACS_INT is not the same width as void *.
5689 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
5690 * xdisp.c (display_echo_area_1, resize_mini_window_1):
5691 (current_message_1, set_message_1):
5692 Use a local to convert to proper width without a cast.
5693 * xmenu.c (dialog_selection_callback): Likewise.
5694
ede49d71
PE
5695 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
5696 Also, don't assume VALBITS / RAND_BITS is less than 5,
5697 and don't rely on undefined behavior when shifting a 1 left into
5698 the sign bit.
5699 * lisp.h (get_random): Change signature to match.
5700
2f30ecd0
PE
5701 * lread.c (hash_string): Use size_t, not int, for hash computation.
5702 Normally we prefer signed values; but hashing is special, because
5703 it's better to use unsigned division on hash table sizes so that
5704 the remainder is nonnegative. Also, size_t is the natural width
5705 for hashing into memory. The previous code used 'int', which doesn't
5706 retain enough info to hash well into very large tables.
5707 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
5708
2a866e7b
PE
5709 * dbusbind.c: Don't possibly lose pointer info when converting.
5710 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
5711 Use XPNTR rather than XHASH, so that the high-order bits of
5712 the pointer aren't lost when converting through void *.
5713
51639eac
PE
5714 * eval.c (Fautoload): Don't double-shift a pointer.
5715
92394119
PE
5716 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
5717
dbdb9a7c
JB
57182011-05-06 Juanma Barranquero <lekktu@gmail.com>
5719
5720 * gnutls.c (DEF_GNUTLS_FN):
5721 * image.c (DEF_IMGLIB_FN): Make function pointers static.
5722
db7a0b4f
AS
57232011-05-05 Andreas Schwab <schwab@linux-m68k.org>
5724
5725 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
5726 marker. (Bug#8610)
5727
f7ff1b0f 57282011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
5729
5730 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
5731 New version that can reserve upto 2GB of heap space.
5732
f7ff1b0f 57332011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
5734
5735 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
5736
639c109b
TZ
57372011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
5738
5739 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
5740 `gnutls_certificate_set_x509_key_file'.
5741
d2127135
JB
57422011-05-05 Juanma Barranquero <lekktu@gmail.com>
5743
5744 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
5745 Update dependencies.
5746
e968f4f3
JB
57472011-05-04 Juanma Barranquero <lekktu@gmail.com>
5748
5749 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
5750 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
5751 Remove unused parameter `fildes'.
5752 * process.c (read_process_output, send_process): Don't pass it.
5753
84d358f0
JB
57542011-05-04 Juanma Barranquero <lekktu@gmail.com>
5755
5756 Fix previous change: the library cache is defined in w32.c.
5757 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
5758 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
5759
0898ca10
JB
57602011-05-04 Juanma Barranquero <lekktu@gmail.com>
5761
5762 Implement dynamic loading of GnuTLS on Windows.
5763
5764 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
5765 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
5766 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5767 Declare.
5768
5769 * gnutls.c (Qgnutls_dll): Define.
5770 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
5771 (gnutls_*): Declare function pointers.
5772 (init_gnutls_functions): New function to initialize function pointers.
5773 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
5774 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
5775 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
5776 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
5777 (emacs_gnutls_write, emacs_gnutls_read)
5778 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
5779 (Fgnutls_available_p): New function.
5780 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
5781 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
5782 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
5783
5784 * image.c: Include w32.h.
5785 (Vimage_type_cache): Delete.
5786 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
5787 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
5788 (w32_delayed_load): Move to w32.c.
5789
5790 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
5791
5792 * w32.c (QCloaded_from, Vlibrary_cache): Define.
5793 (w32_delayed_load): Move from image.c. When loading a library, record
5794 its filename in the :loaded-from property of the library id.
5795 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
5796 Initialize and staticpro them.
5797 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
5798
5799 * process.c: Include lisp.h before w32.h, not after.
5800 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
5801 instead of gnutls_record_check_pending.
5802
5803 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
5804
ff4de4aa
TZ
58052011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
5806
5807 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
5808 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
5809 as passed in.
5810
abe95abb
JD
58112011-05-03 Jan Djärv <jan.h.d@swipnet.se>
5812
5813 * xterm.c (x_set_frame_alpha): Do not set property on anything
5814 else than FRAME_X_OUTER_WINDOW (Bug#8608).
5815
e16e55d4
JB
58162011-05-02 Juanma Barranquero <lekktu@gmail.com>
5817
5818 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
5819
bafcf6a5
JB
58202011-05-02 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
5823 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
5824 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
5825 (gnutls_global_initialized, Qgnutls_bootprop_priority)
5826 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
5827 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
5828 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
5829 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
5830 (Qgnutls_bootprop_callbacks_verify): Make static.
5831
e7a6747f
AS
58322011-05-01 Andreas Schwab <schwab@linux-m68k.org>
5833
19ed11ba
AS
5834 * callproc.c: Indentation fixup.
5835
e7a6747f 5836 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
5837 (wait_for_termination, interruptible_wait_for_termination):
5838 Move after wait_for_termination_1.
e7a6747f 5839
1ef14cb4
LMI
58402011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
5841
5842 * sysdep.c (interruptible_wait_for_termination): New function
5843 which is like wait_for_termination, but allows keyboard
5844 interruptions.
5845
5846 * callproc.c (Fcall_process): Add (:file "file") as an option for
5847 the STDOUT buffer.
5848 (Fcall_process_region): Ditto.
5849
330d880c
EZ
58502011-04-30 Eli Zaretskii <eliz@gnu.org>
5851
8db90b73
EZ
5852 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
5853 rather than `XVECTOR (FOO)->size'.
5854
330d880c
EZ
5855 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
5856 inttypes.h, as a gnulib replacement is used if it not available in
5857 system headers.
5858
15cbd324
EZ
58592011-04-21 Eli Zaretskii <eliz@gnu.org>
5860
5861 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
5862 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
5863 of MOST_POSITIVE_FIXNUM. (Bug#8528)
5864
5865 * coding.c (coding_alloc_by_realloc): Error out if destination
5866 will grow beyond MOST_POSITIVE_FIXNUM.
5867 (decode_coding_emacs_mule): Abort if there isn't enough place in
5868 charbuf for the composition carryover bytes. Reserve an extra
5869 space for up to 2 characters produced in a loop.
5870 (decode_coding_iso_2022): Abort if there isn't enough place in
5871 charbuf for the composition carryover bytes.
5872
58732011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 5874
ae940cca
EZ
5875 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
5876 aborting when %lld or %lll format is passed.
5877 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
5878 %llo or %llx format is passed. (Bug#8545)
5879
03ab8921
EZ
5880 * window.c (window_scroll_line_based): Use a marker instead of
5881 simple variables to record original value of point. (Bug#7952)
5882
afda1437
EZ
5883 * doprnt.c (doprnt): Fix the case where a multibyte sequence
5884 produced by %s or %c overflows available buffer space. (Bug#8545)
5885
f76dee0c
PE
58862011-04-28 Paul Eggert <eggert@cs.ucla.edu>
5887
5888 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 5889 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 5890
fdc5744d
JB
58912011-04-28 Juanma Barranquero <lekktu@gmail.com>
5892
5893 * w32.c (init_environment): Warn about defaulting HOME to C:\.
5894
638f053a
JB
58952011-04-28 Juanma Barranquero <lekktu@gmail.com>
5896
5897 * keyboard.c (Qdelayed_warnings_hook): Define.
5898 (command_loop_1): Run `delayed-warnings-hook'
5899 if Vdelayed_warnings_list is non-nil.
5900 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
5901 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
5902
d178f871
EZ
59032011-04-28 Eli Zaretskii <eliz@gnu.org>
5904
5905 * doprnt.c (doprnt): Don't return value smaller than the buffer
5906 size if the message was truncated. (Bug#8545).
5907
b124fd93
JB
59082011-04-28 Juanma Barranquero <lekktu@gmail.com>
5909
5910 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
5911 (Fx_window_property): #if-0 the whole functions, not just the bodies.
5912
e810457d
PE
59132011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5914
5915 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
5916
ea51cceb
JB
59172011-04-27 Juanma Barranquero <lekktu@gmail.com>
5918
5919 * makefile.w32-in: Update dependencies.
5920
94dcfacf
EZ
59212011-04-27 Eli Zaretskii <eliz@gnu.org>
5922
5923 Improve `doprnt' and its usage. (Bug#8545)
5924 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
5925 `format_end'. Remove support for %l as a conversion specifier.
5926 Don't use xrealloc. Improve diagnostics when the %l size modifier
5927 is used. Update the commentary.
5928
5929 * eval.c (verror): Simplify calculation of size_t.
5930
5931 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
5932 messages.
5933
f61f41d7
PE
59342011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
5935
5936 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
5937 change.
5938
96fb4434
PE
59392011-04-27 Paul Eggert <eggert@cs.ucla.edu>
5940
5941 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
5942 This makes this file independent of the recent pseudovector change.
5943
671875da 59442011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 5945
69e9b5a3
PE
5946 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
5947
b5f869a7 5948 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 5949 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 5950 Remove unused local.
c8926152 5951 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 5952
841a1577 5953 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
5954 GCC 4.6.0 optimizes based on type-based alias analysis.
5955 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
5956 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
5957 != &v->size, and therefore "v->size = 1; b->size = 2; return
5958 v->size;" must therefore return 1. This assumption is incorrect
5959 for Emacs, since it type-puns struct Lisp_Vector * with many other
5960 types. To fix this problem, this patch adds a new type struct
f904488f 5961 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
5962 and pseudovectors, and helps optimizing compilers not get fooled
5963 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
5964 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
5965 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
5966 the size member.
eab3844f
PE
5967 (XSETPVECTYPE): Rewrite in terms of new macro.
5968 (XSETPVECTYPESIZE): New macro, specifying both type and size.
5969 This is a bit clearer, and further avoids the possibility of
5970 undesirable aliasing.
5971 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 5972 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
5973 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
5974 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
5975 (ASIZE): Now uses header.size rather than size.
5976 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
5977 to avoid the hassle of writing XVECTOR (foo)->header.size.
5978 (struct vectorlike_header): New type.
eab3844f
PE
5979 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
5980 object, to help avoid aliasing.
5981 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
5982 (SUBRP): Likewise, since Lisp_Subr is a special case.
5983 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
5984 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
5985 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 5986 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
5987 changed to be "header.size" and "header.next".
5988 * buffer.h (struct buffer): Likewise.
5989 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
5990 * frame.h (struct frame): Likewise.
5991 * process.h (struct Lisp_Process): Likewise.
5992 * termhooks.h (struct terminal): Likewise.
5993 * window.c (struct save_window_data, struct saved_window): Likewise.
5994 * window.h (struct window): Likewise.
5995 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
5996 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
5997 * buffer.c (init_buffer_once): Likewise.
5998 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
5999 special case.
6000 * process.c (Fformat_network_address): Use local var for size,
6001 for brevity.
6002
0df1eac5
PE
6003 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
6004
847ab9d1 6005 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
6006 * data.c (atof): Remove decl; no longer used or needed.
6007 (digit_to_number): Move to lread.c.
6008 (Fstring_to_number): Use new string_to_number function, to be
6009 consistent with how the Lisp reader treats infinities and NaNs.
6010 Do not assume that floating-point numbers represent EMACS_INT
6011 without losing information; this is not true on most 64-bit hosts.
6012 Avoid double-rounding errors, by insisting on integers when
6013 parsing non-base-10 numbers, as the documentation specifies.
6014 * lisp.h (string_to_number): New decl, replacing ...
6015 (isfloat_string): Remove.
bc0a5c13 6016 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 6017 (read1): Do not accept +. and -. as integers; this
452f4150
PE
6018 appears to have been a coding error. Similarly, do not accept
6019 strings like +-1e0 as floating point numbers. Do not report
6020 overflow for integer overflows unless the base is not 10 which
6021 means we have no simple and reliable way to continue.
6022 Break out the floating-point parsing into a new
6023 function string_to_number, so that Fstring_to_number parses
6024 floating point numbers consistently with the Lisp reader.
04f2d78b 6025 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
6026 (E_CHAR, EXP_INT): Remove, replacing with ...
6027 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
6028 (string_to_number): New function, replacing isfloat_string.
6029 This function checks for valid syntax and produces the resulting
6030 Lisp float number too. Rework it so that string-to-number
bc0a5c13 6031 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
6032 so that overflow for non-base-10 numbers is reported only when
6033 there's no portable and simple way to convert to floating point.
452f4150 6034
67769ffc
PE
6035 * textprop.c (set_text_properties_1): Rewrite for clarity,
6036 and to avoid GCC warning about integer overflow.
6037
c20db43f
PE
6038 * intervals.h (struct interval): Use EMACS_INT for members
6039 where EMACS_UINT might cause problems. See
6040 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
6041 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
6042 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
6043 All uses changed.
37aa2f85
PE
6044 (offset_intervals): Tell GCC not to worry about length overflow
6045 when negating a negative length.
c20db43f 6046
2538aa2f
PE
6047 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
6048 (overrun_check_free): Likewise.
6049
f2d3008d
PE
6050 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
6051 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
6052 word size.
6053
ec8df744
PE
6054 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6055 (gnutls_make_error): Rename local to avoid shadowing.
6056 (gnutls_emacs_global_deinit): ifdef out; not used.
6057 (Fgnutls_boot): Use const for pointer to readonly storage.
6058 Comment out unused local. Fix pointer signedness problems.
6059
640ee02d
PE
6060 * lread.c (openp): Don't stuff size_t into an 'int'.
6061 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
6062 about possible signed overflow.
6063
6048fb2a
PE
6064 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
6065 (GDK_KEY_g): Don't define if already defined.
6066 (xg_prepare_tooltip): Avoid pointer signedness problem.
6067 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
6068
fa3c87e1
PE
6069 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
6070 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
6071
2172544b
PE
6072 * xfns.c (Fx_window_property): Simplify a bit,
6073 to make a bit faster and to avoid GCC 4.6.0 warning.
6074 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
6075
9b821a21
PE
6076 * fns.c (internal_equal): Don't assume size_t fits in int.
6077
3c616cfa
PE
6078 * alloc.c (compact_small_strings): Tighten assertion a little.
6079
c2982e87
PE
6080 Replace pEd with more-general pI, and fix some printf arg casts.
6081 * lisp.h (pI): New macro, generalizing old pEd macro to other
6082 conversion specifiers. For example, use "...%"pI"d..." rather
6083 than "...%"pEd"...".
6084 (pEd): Remove. All uses replaced with similar uses of pI.
6085 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
6086 * alloc.c (check_pure_size): Don't overflow by converting size to int.
6087 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
6088 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
6089 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
6090 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
6091 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
6092 64-bit hosts.
6093 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
6094 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
6095 * print.c (safe_debug_print, print_object): Likewise.
6096 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
6097 to int.
6f04d126
PE
6098 Use pI instead of if-then-else-abort. Use %p to avoid casts,
6099 avoiding the 0 flag, which is not portable.
c2982e87
PE
6100 * process.c (Fmake_network_process): Use pI to avoid cast.
6101 * region-cache.c (pp_cache): Likewise.
6102 * xdisp.c (decode_mode_spec): Likewise.
6103 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
6104 behavior on 64-bit hosts with printf arg.
6f04d126 6105 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
6106 (x_stop_queuing_selection_requests): Likewise.
6107 (x_get_window_property): Don't truncate byte count to an 'int'
6108 when tracing.
0b432f21 6109
5e073ec7
PE
6110 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
6111 here, since it parses constructs like leading '-' and spaces,
6112 which are not wanted; and it overflows with large numbers.
6113 Instead, simply match F[0-9]+, which is what is wanted anyway.
6114
36372bf9
PE
6115 * alloc.c: Remove unportable assumptions about struct layout.
6116 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
6117 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
6118 (allocate_vectorlike, make_pure_vector): Use the new macros,
6119 plus offsetof, to remove unportable assumptions about struct layout.
6120 These assumptions hold on all porting targets that I know of, but
6121 they are not guaranteed, they're easy to remove, and removing them
6122 makes further changes easier.
6123
0b432f21
PE
6124 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
6125 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
6126 (string_overrun_cookie): Now const. Use initializers that
6127 don't formally overflow signed char, to avoid warnings.
000098c1
PE
6128 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
6129 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
6130 (allocate_buffer): Don't assume sizeof (struct buffer) is a
6131 multiple of sizeof (EMACS_INT); it need not be, if
6132 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 6133 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 6134
895009e1
JB
61352011-04-26 Juanma Barranquero <lekktu@gmail.com>
6136
6137 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
6138
6a7a1b0b
TZ
61392011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
6140
6141 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 6142 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
6143 Reported by Paul Eggert <eggert@cs.ucla.edu>.
6144
841a1577 61452011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
6146
6147 * lisp.h (Qdebug): List symbol.
895009e1 6148 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
6149 * keyboard.c (debug-on-event): New variable.
6150 (handle_user_signal): Break into debugger when debug-on-event
6151 matches the current signal symbol.
6152
f2d3ba6f
DN
61532011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
6154
6155 * alloc.c (check_sblock, check_string_bytes)
6156 (check_string_free_list): Convert to standard C.
6157
42ce4c63
TZ
61582011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
6159
6160 * w32.c (emacs_gnutls_push): Fix typo.
6161
825cd63c
EZ
61622011-04-25 Eli Zaretskii <eliz@gnu.org>
6163
fb11d64d
EZ
6164 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
6165 "cast to pointer from integer of different size".
6166
825cd63c
EZ
6167 Improve doprnt and its use in verror. (Bug#8545)
6168 * doprnt.c (doprnt): Document the set of format control sequences
6169 supported by the function. Use SAFE_ALLOCA instead of always
6170 using `alloca'.
6171
6172 * eval.c (verror): Don't limit the buffer size at size_max-1, that
6173 is one byte too soon. Don't use xrealloc; instead xfree and
6174 xmalloc anew.
6175
e061a11b
TZ
61762011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
6177
6178 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
6179 callbacks stage.
6180
6181 * gnutls.c: Renamed global_initialized to
6182 gnutls_global_initialized. Added internals for the
6183 :verify-hostname-error, :verify-error, and :verify-flags
6184 parameters of `gnutls-boot' and documented those parameters in the
6185 docstring. Start callback support.
9173deec
JB
6186 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
6187 unless a fatal error occurred. Call gnutls_alert_send_appropriate
6188 on error. Return error code.
e061a11b
TZ
6189 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
6190 (emacs_gnutls_read): Likewise.
6191 (Fgnutls_boot): Return handshake error code.
6192 (emacs_gnutls_handle_error): New function.
6193 (wsaerror_to_errno): Likewise.
6194
6195 * w32.h (emacs_gnutls_pull): Add prototype.
6196 (emacs_gnutls_push): Likewise.
6197
6198 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
6199 (emacs_gnutls_push): Likewise.
6200
62012011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
6202
6203 * process.c (wait_reading_process_output): Check if GnuTLS
6204 buffered some data internally if no FDs are set for TLS
6205 connections.
6206
6207 * makefile.w32-in (OBJ2): Add gnutls.$(O).
6208 (LIBS): Link to USER_LIBS.
6209 ($(BLD)/gnutls.$(0)): New target.
6210
fa6996bc
EZ
62112011-04-24 Eli Zaretskii <eliz@gnu.org>
6212
eb35682e
EZ
6213 * xdisp.c (handle_single_display_spec): Rename the
6214 display_replaced_before_p argument into display_replaced_p, to
6215 make it consistent with the commentary. Fix typos in the
6216 commentary.
6217
e2ad650c
EZ
6218 * textprop.c (syms_of_textprop): Remove dead code.
6219 (copy_text_properties): Delete obsolete commentary about an
6220 interface that was deleted long ago. Fix typos in the description
6221 of arguments.
6222
1b2de274
EZ
6223 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
6224 to changes in oldXMenu/XMenu.h from 2011-04-16.
6225 <menu_help_message, prev_menu_help_message>: Constify.
6226 (IT_menu_make_room): menu->help_text is now `const char **';
6227 adjust.
6228
6229 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
6230 to changes in oldXMenu/XMenu.h from 2011-04-16.
6231 (struct XMenu): Declare `help_text' `const char **'.
6232
6233 * xfaces.c <Qunspecified>: Make extern again.
6234
6235 * syntax.c: Include sys/types.h before including regex.h, as
6236 required by Posix.
6237
762b15be
EZ
6238 * doc.c (get_doc_string): Improve the format passed to `error'.
6239
6240 * doprnt.c (doprnt): Improve commentary.
6241
6242 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
6243
6244 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
6245 them with etags.
6246
f1052e5d
EZ
6247 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
6248 changes in globals.h immediately force recompilation.
762b15be
EZ
6249 (TAGS): Depend on $(CURDIR)/m/intel386.h and
6250 $(CURDIR)/s/ms-w32.h.
6251 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 6252
fa6996bc
EZ
6253 * character.c (Fchar_direction): Function deleted.
6254 (syms_of_character): Don't defsubr it.
6255 <char-direction-table>: Deleted.
6256
e6c3da20
EZ
62572011-04-23 Eli Zaretskii <eliz@gnu.org>
6258
6259 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
6260 * doprnt.c: Include limits.h.
6261 (SIZE_MAX): New macro.
04f2d78b
CB
6262 (doprnt): Return a size_t value. 2nd arg is now size_t.
6263 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
6264 Improve overflow protection. Support `l' modifier for integer
6265 conversions. Support %l conversion. Don't assume an EMACS_INT
6266 argument for integer conversions and for %c.
6267
6268 * lisp.h (doprnt): Restore prototype.
6269
6270 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
6271 $(SRC)/character.h.
6272
6273 * Makefile.in (base_obj): Add back doprnt.o.
6274
6275 * deps.mk (doprnt.o): Add back prerequisites.
6276 (callint.o): Depend on character.h.
6277
6278 * eval.c (internal_lisp_condition_case): Include the handler
6279 representation in the error message.
6280 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
6281 when breaking from the loop.
6282
6283 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
6284
6285 * callint.c (Fcall_interactively): When displaying error message
6286 about invalid control letter, pass the character's codepoint, not
6287 a pointer to its multibyte form. Improve display of the character
6288 in octal and display also its hex code.
6289
6290 * character.c (char_string): Use %x to display the (unsigned)
6291 codepoint of an invalid character, to avoid displaying a bogus
6292 negative value.
6293
6294 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
6295 `error', not SYMBOL_NAME itself.
6296
6297 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
6298 character arguments to `error'.
6299
6300 * charset.c (check_iso_charset_parameter): Fix incorrect argument
6301 to `error' in error message about FINAL_CHAR argument. Make sure
6302 FINAL_CHAR is a character, and use %c when it is passed as
6303 argument to `error'.
6304
4ffd0d6b 63052011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
6306
6307 * s/ms-w32.h (localtime): Redirect to sys_localtime.
6308
6309 * w32.c: Include <time.h>.
6310 (sys_localtime): New function.
6311
4ffd0d6b 63122011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
6313
6314 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
6315
4ffd0d6b 6316 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 6317
4ffd0d6b 63182011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 6319
4ffd0d6b
GM
6320 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
6321 zombies (Bug#8467).
aac0c6e3 6322
04c56954
EZ
63232011-04-19 Eli Zaretskii <eliz@gnu.org>
6324
6325 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
6326 gl_state.e_property when gl_state.object is Qt.
6327
6328 * insdel.c (make_gap_larger): Remove limitation of buffer size
6329 to <= INT_MAX.
6330
16a43933
CY
63312011-04-18 Chong Yidong <cyd@stupidchicken.com>
6332
6333 * xdisp.c (lookup_glyphless_char_display)
6334 (produce_glyphless_glyph): Handle cons cell entry in
6335 glyphless-char-display.
6336 (Vglyphless_char_display): Document it.
6337
6338 * term.c (produce_glyphless_glyph): Handle cons cell entry in
6339 glyphless-char-display.
6340
4581706e
CY
63412011-04-17 Chong Yidong <cyd@stupidchicken.com>
6342
6343 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
6344
6345 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
6346
6347 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
6348 definition for no-X builds.
6349
4887c6e2 63502011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 6351
fd35b6f9
PE
6352 Static checks with GCC 4.6.0 and non-default toolkits.
6353
5c1ccb01
PE
6354 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
6355
006c5daa
PE
6356 * process.c (keyboard_bit_set): Define only if SIGIO.
6357 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
6358 (send_process): Repair possible setjmp clobbering.
6359
efc736d3
PE
6360 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
6361
4e2fe2e6
PE
6362 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
6363
f97334a2
PE
6364 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
6365
4e75f29d
PE
6366 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
6367 Define only if needed.
6368
90efadd1
PE
6369 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
6370 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 6371 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 6372
3c647824
PE
6373 * dispextern.h (struct redisplay_interface): Rename param
6374 to avoid shadowing.
e264f262 6375 * termhooks.h (struct terminal): Likewise.
761383f4 6376 * xterm.c (xembed_send_message): Likewise.
3c647824 6377
b58c5c4a
PE
6378 * insdel.c (make_gap_smaller): Define only if
6379 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
6380
cad59032
PE
6381 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
6382 it.
6383
c339dc2e
PE
6384 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
6385 so that we aren't warned about unused symbols.
6386
91a3e27b
PE
6387 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
6388
399c71d3 6389 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 6390
8ffc96f5
PE
6391 * xfns.c (x_real_positions): Mark locals as initialized.
6392
eef9bc79
PE
6393 * xmenu.c (xmenu_show): Don't use uninitialized vars.
6394
098db9dd
PE
6395 * xterm.c: Fix problems found by static analysis with other toolkits.
6396 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
6397 (x_dispatch_event): Declare static if USE_GTK, and
6398 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 6399 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 6400 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
6401 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
6402 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 6403
eb18f6cc
PE
6404 * xmenu.c (menu_help_callback): Pointer type fixes.
6405 Use const pointers when pointing at readonly data. Avoid pointer
6406 signedness clashes.
6407 (FALSE): Remove unused macro.
6408 (update_frame_menubar): Remove unused decl.
6409
1fe72bf8
PE
6410 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
6411
60d9e1db
PE
6412 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
6413 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
6414 (single_menu_item): Rename local to avoid shadowing.
6415
39261c26
PE
6416 * keyboard.c (make_lispy_event): Remove unused local var.
6417
018c5e19
PE
6418 * frame.c, frame.h (x_get_resource_string): Bring this back, but
6419 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
6420
63d2b86e
PE
6421 * bitmaps: Change bitmaps from unsigned char back to the X11
6422 compatible char. Avoid the old compiler warnings about
6423 out-of-range initializers by using, for example, '\xab' rather
6424 than 0xab.
6425
aefd87e1
PE
6426 * xgselect.c (xgselect_initialize): Check vs interface
6427 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
6428
bf501fb9
PE
6429 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
6430
e9829fdf
PE
6431 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
6432 to read-only memory.
6433
1086c095
PE
6434 * fns.c (vector): Remove; this old hack is no longer needed.
6435
2baccd04 6436 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 6437 Remove unused var.
dde42981 6438 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 6439
72391843 6440 * xrdb.c (x_load_resources): Omit unused local.
3565b346 6441
436c16df 6442 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 6443 (x_window): Rename locals to avoid shadowing.
dc5ddd85 6444 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 6445
92bb796d 6446 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 6447 (x_term_init): Remove local to avoid shadowing.
92bb796d 6448
764430a3 6449 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
6450
6451 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
6452 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
6453
d1dfb56c
EZ
64542011-04-16 Eli Zaretskii <eliz@gnu.org>
6455
c4354cb4
EZ
6456 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
6457
d1dfb56c
EZ
6458 Fix regex.c, syntax.c and friends for buffers > 2GB.
6459 * syntax.h (struct gl_state_s): Declare character position members
6460 EMACS_INT.
6461
6462 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
6463
04f2d78b
CB
6464 * textprop.c (verify_interval_modification, interval_of):
6465 Declare arguments EMACS_INT.
d1dfb56c
EZ
6466
6467 * intervals.c (adjust_intervals_for_insertion): Declare arguments
6468 EMACS_INT.
6469
6470 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
6471
6472 * indent.c (Fvertical_motion): Local variable it_start is now
6473 EMACS_INT.
6474
6475 * regex.c (re_match, re_match_2, re_match_2_internal)
6476 (bcmp_translate, regcomp, regexec, print_double_string)
6477 (group_in_compile_stack, re_search, re_search_2, regex_compile)
6478 (re_compile_pattern, re_exec): Declare arguments and local
6479 variables `size_t' and `ssize_t' and return values `regoff_t', as
6480 appropriate.
6481 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
6482 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
6483 <compile_stack_type>: `size' and `avail' are now `size_t'.
6484
6485 * regex.h <regoff_t>: Use ssize_t, not int.
6486 (re_search, re_search_2, re_match, re_match_2): Arguments that
6487 specify buffer/string position and length are now ssize_t and
6488 size_t. Return type is regoff_t.
6489
613052cd
BK
64902011-04-16 Ben Key <bkey76@gmail.com>
6491
6492 * nsfont.m: Fixed bugs in ns_get_family and
6493 ns_descriptor_to_entity that were caused by using free to
6494 deallocate memory blocks that were allocated by xmalloc (via
6495 xstrdup). This caused Emacs to crash when compiled with
6496 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
6497 --enable-checking=xmallocoverrun). xfree is now used to
6498 deallocate these memory blocks.
6499
4170f62f 65002011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 6501
71b41406
PE
6502 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
6503
9587a89d
PE
6504 emacs_write: Accept and return EMACS_INT for sizes.
6505 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
6506 et seq.
6507 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
6508 Accept and return EMACS_INT.
6509 (emacs_gnutls_write): Return the number of bytes written on
6510 partial writes.
6511 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
6512 (emacs_read, emacs_write): Remove check for negative size, as the
6513 Emacs source code has been audited now.
9587a89d
PE
6514 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
6515 (emacs_read, emacs_write): Use it.
273a5f82
PE
6516 * process.c (send_process): Adjust to the new signatures of
6517 emacs_write and emacs_gnutls_write. Do not attempt to store
6518 a byte offset into an 'int'; it might overflow.
9587a89d 6519 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 6520
3e047f51
PE
6521 * sound.c: Don't assume sizes fit in 'int'.
6522 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 6523 Return EMACS_INT, not int.
3e047f51 6524 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
6525 Accept EMACS_INT, not int.
6526 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
6527 record read return values.
6528
cc39a9db
BK
65292011-04-15 Ben Key <bkey76@gmail.com>
6530
c9d0ec6d
JB
6531 * keyboard.c (Qundefined): Don't declare static since it is used
6532 in nsfns.m.
6533 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
6534 static since they are used in nsfont.m.
cc39a9db 6535
6c60eb9f
SM
65362011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
6537
6538 * process.c (Qprocessp): Don't declare static.
6539 * lisp.h (Qprocessp): Declare again.
6540
7990b61a
JB
65412011-04-15 Juanma Barranquero <lekktu@gmail.com>
6542
6543 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
6544
5d4cb038
PE
65452011-04-14 Paul Eggert <eggert@cs.ucla.edu>
6546
8bd7b830 6547 Improve C-level modularity by making more things 'static'.
cd64ea1d 6548
e3b27b31
PE
6549 Don't publish debugger-only interfaces to other modules.
6550 * lisp.h (safe_debug_print, debug_output_compilation_hack):
6551 (verify_bytepos, count_markers): Move decls to the only modules
6552 that need them.
6553 * region-cache.h (pp_cache): Likewise.
6554 * window.h (check_all_windows): Likewise.
6555 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
6556
5d4cb038
PE
6557 * sysdep.c (croak): Now static, if
6558 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
6559 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
6560
6561 * alloc.c (refill_memory_reserve): Now static if
6562 !defined REL_ALLOC || defined SYSTEM_MALLOC.
6563 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 6564
e87b6180
PE
6565 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
6566 Define only if USE_LUCID.
6567
ac64929e
PE
6568 * xrdb.c (x_customization_string, x_rm_string): Now static.
6569
6f37259d
PE
6570 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
6571 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
6572
1683e3ab
PE
6573 * xdisp.c (draw_row_with_mouse_face): Now static.
6574 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
6575
de9c2632
PE
6576 * window.h (check_all_windows): Mark externally visible.
6577
2b96acb7
PE
6578 * window.c (window_deletion_count): Now static.
6579
6580 * undo.c: Make symbols static if they're not exported.
6581 (last_undo_buffer, last_boundary_position, pending_boundary):
6582 Now static.
6583
50436f33
PE
6584 * textprop.c (interval_insert_behind_hooks): Now static.
6585 (interval_insert_in_front_hooks): Likewise.
6586
64520e5c
PE
6587 * term.c: Make symbols static if they're not exported.
6588 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
6589 (max_frame_lines, tty_set_terminal_modes):
6590 (tty_reset_terminal_modes, tty_turn_off_highlight):
6591 (get_tty_terminal): Now static.
6592 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
6593 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 6594 HAVE_WINDOW_SYSTEM.
64520e5c
PE
6595 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
6596 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
6597
1fa53021
PE
6598 * sysdep.c: Make symbols static if they're not exported.
6599 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
6600 Now static.
6601 (sigprocmask_set, full_mask): Remove; unused.
6602 (wait_debugging): Mark as visible.
6603 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
6604 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
6605
d4b43b22
PE
6606 * syntax.c (syntax_temp): Define only if !__GNUC__.
6607
b7c513d0
PE
6608 * sound.c (current_sound_device, current_sound): Now static.
6609
989b29ad
PE
6610 * search.c (searchbufs, searchbuf_head): Now static.
6611
13a55a78
PE
6612 * scroll.c (scroll_cost): Remove; unused.
6613 * dispextern.h (scroll_cost): Remove decl.
6614
de68a1fc
PE
6615 * region-cache.h (pp_cache): Mark as externally visible.
6616
40ccffa6
PE
6617 * process.c: Make symbols static if they're not exported.
6618 (process_tick, update_tick, create_process, chan_process):
6619 (Vprocess_alist, proc_buffered_char, datagram_access):
6620 (fd_callback_data, send_process_frame, process_sent_to): Now static.
6621 (deactivate_process): Mark defn as static, as well as decl.
6622 * lisp.h (create_process): Remove decl.
6623 * process.h (chan_process, Vprocess_alist): Remove decls.
6624
ad64fc97
PE
6625 * print.c: Make symbols static if they're not exported.
6626 (print_depth, new_backquote_output, being_printed, print_buffer):
6627 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
6628 (print_interval, print_number_index, initial_stderr_stream):
6629 Now static.
6630 * lisp.h (Fprinc): Remove decl.
6631 (debug_output_compilation_hack): Mark as externally visible.
6632
adddb265
PE
6633 * sysdep.c (croak): Move decl from here to syssignal.h.
6634 * syssignal.h (croak): Put it here, so the API can be checked when
6635 'croak' is called from dissociate_if_controlling_tty.
6636
1717ede2
PE
6637 * minibuf.c: Make symbols static if they're not exported.
6638 (minibuf_save_list, choose_minibuf_frame): Now static.
6639 * lisp.h (choose_minibuf_frame): Remove decl.
6640
fa5fb2bc
PE
6641 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
6642
1e3890d1
PE
6643 * lread.c: Make symbols static if they're not exported.
6644 (read_objects, initial_obarray, oblookup_last_bucket_number):
6645 Now static.
6646 (make_symbol): Remove; unused.
6647 * lisp.h (initial_obarray, make_symbol): Remove decls.
6648
8a1414fa
PE
6649 * keyboard.c: Make symbols static if they're not exported.
6650 (single_kboard, recent_keys_index, total_keys, recent_keys):
6651 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
6652 (this_single_command_key_start, echoing, last_auto_save):
6653 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
6654 (command_loop, echo_now, keyboard_init_hook, help_char_p):
6655 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
6656 (Vlispy_mouse_stem, double_click_count):
6657 Now static.
6658 (force_auto_save_soon): Define only if SIGDANGER.
6659 (ignore_mouse_drag_p): Now static if
6660 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
6661 (print_help): Remove; unused.
6662 (stop_character, last_timer_event): Mark as externally visible.
6663 * keyboard.h (ignore_mouse_drag_p): Declare only if
6664 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
6665 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
6666 * lisp.h (echoing): Remove decl.
6667 (force_auto_save_soon): Declare only if SIGDANGER.
6668 * xdisp.c (redisplay_window): Simplify code, to make it more
6669 obvious that ignore_mouse_drag_p is not accessed if !defined
6670 USE_GTK && !defined HAVE_NS.
6671
93ea6e8f
PE
6672 * intervals.c: Make symbols static if they're not exported.
6673 (merge_properties_sticky, merge_interval_right, delete_interval):
6674 Now static.
6675 * intervals.h (merge_interval_right, delete_interval): Remove decls.
6676
77382fcc
PE
6677 * insdel.c: Make symbols static if they're not exported.
6678 However, leave prepare_to_modify_buffer alone. It's never
6679 called from outside this function, but that appears to be a bug.
6680 (combine_after_change_list, combine_after_change_buffer):
4889fc82 6681 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
6682 (adjust_after_replace_noundo): Remove; unused.
6683 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 6684 (signal_before_change): Remove decls.
77382fcc 6685
9306c32e
PE
6686 * indent.c (val_compute_motion, val_vmotion): Now static.
6687
cd44d2eb
PE
6688 * image.c: Make symbols static if they're not exported.
6689 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
6690 if USE_GTK.
6691 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
6692 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
6693
ad9a7a06
PE
6694 * fringe.c (standard_bitmaps): Now static.
6695 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
6696
81626931
PE
6697 * frame.c: Make symbols static if they're not exported.
6698 (x_report_frame_params, make_terminal_frame): Now static.
6699 (get_frame_param): Now static, unless HAVE_NS.
6700 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
6701 (x_get_resource_string): Remove; not used.
6702 * frame.h (make_terminal_frame, x_report_frame_params):
6703 (x_get_resource_string); Remove decls.
6704 (x_fullscreen_adjust): Declare only if WINDOWSNT.
6705 * lisp.h (get_frame_param): Declare only if HAVE_NS.
6706
239f9db9
PE
6707 * font.c, fontset.c: Make symbols static if they're not exported.
6708 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
6709 (FACE_SUITABLE_FOR_CHAR_P): Use it.
6710 * font.c (font_close_object): Now static.
6711 * font.h (font_close_object): Remove.
6712 * fontset.c (FONTSET_OBJLIST): Remove.
6713 (free_realized_fontset) #if-0 the body, which does nothing.
6714 (face_suitable_for_char_p): #if-0, as it's never called.
6715 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
6716 * xfaces.c (face_at_string_position):
6717 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
6718 since 0 is always ASCII.
6719
dfcf3579
PE
6720 * fns.c (weak_hash_tables): Now static.
6721
5045092b
PE
6722 * fileio.c: Make symbols static if they're not exported.
6723 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
6724 (Vwrite_region_annotation_buffers): Now static.
6725
57a96f5c
PE
6726 * eval.c: Make symbols static if they're not exported.
6727 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
6728 * lisp.h (backtrace_list): Remove decl.
6729
35f08c38
PE
6730 * emacs.c: Make symbols static if they're not exported.
6731 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
6732 (fatal_error_code, fatal_error_signal_hook, standard_args):
6733 Now static.
6734 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
6735 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
6736 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
6737 * lisp.h (fatal_error_signal_hook): Remove decl.
6738 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
6739
f44bd759
PE
6740 * editfns.c: Move a (normally-unused) function to its only use.
6741 * editfns.c, lisp.h (get_operating_system_release): Remove.
6742 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
6743 worth the hassle of breaking this out.
6744
b532497d
PE
6745 * xterm.c: Make symbols static if they're not exported.
6746 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
6747 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
6748 (x_destroy_window, x_delete_display):
6749 Now static.
6750 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
6751 (x_mouse_leave): Remove; unused.
6752 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
6753 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
6754 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
6755 Remove decls.
6756 (x_mouse_leave): Declare only if WINDOWSNT.
6757 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
6758 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
6759 USE_X_TOOLKIT.
6760
1675728f
PE
6761 * ftxfont.c: Make symbols static if they're not exported.
6762 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
6763 HAVE_FREETYPE.
6764 * font.h (ftxfont_driver): Likewise.
6765
e4cebfca
PE
6766 * xfns.c: Make symbols static if they're not exported.
6767 (x_last_font_name, x_display_info_for_name):
6768 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
6769 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
6770 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
6771 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
6772 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
6773 (last_show_tip_args): Now static.
6774 (xic_defaut_fontset, xic_create_fontsetname): Define only if
6775 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
6776 (x_screen_planes): Remove; unused.
6777 * dispextern.h (x_screen_planes): Remove decl.
6778
5bf46f05
PE
6779 * dispnew.c: Make symbols static if they're not exported.
6780 * dispextern.h (redraw_garbaged_frames, scrolling):
6781 (increment_row_positions): Remove.
6782 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
6783 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
6784 Now static.
6785 (redraw_garbaged_frames): Remove; unused.
6786
435f4c28
PE
6787 * xfaces.c: Make symbols static if they're not exported.
6788 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
6789 Remove decls.
6790 * xterm.h (defined_color): Remove decls.
6791 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
6792 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
6793 (menu_face_changed_default, defined_color, free_realized_face):
6794 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
6795 (ascii_face_of_lisp_face): Remove; unused.
6796
8524aef3
PE
6797 * xdisp.c: Make symbols static if they're not exported.
6798 * dispextern.h (scratch_glyph_row, window_box_edges):
6799 (glyph_to_pixel_coords, set_cursor_from_row):
6800 (get_next_display_element, set_iterator_to_next):
6801 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
6802 (show_mouse_face): Remove decls
6803 * frame.h (message_buf_print): Likewise.
6804 * lisp.h (pop_message, set_message, check_point_in_composition):
6805 Likewise.
6806 * xterm.h (set_vertical_scroll_bar): Likewise.
6807 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
6808 (message_buf_print, scratch_glyph_row, displayed_buffer):
6809 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
6810 (get_next_display_element, show_mouse_face, window_box_edges):
6811 (frame_to_window_pixel_xy, check_point_in_composition):
6812 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
6813 (glyph_to_pixel_coords): Remove; unused.
6814
16390cd2
PE
6815 * dired.c (file_name_completion): Now static.
6816
6817 * dbusbind.c (xd_in_read_queued_messages): Now static.
6818
a25f4dfa
PE
6819 * lisp.h (circular_list_error, FOREACH): Remove; unused.
6820 * data.c (circular_list_error): Remove.
6821
14a9c8df
PE
6822 * commands.h (last_point_position, last_point_position_buffer):
6823 (last_point_position_window): Remove decls.
6824 * keyboard.c: Make these variables static.
6825
04f2d78b
CB
6826 * coding.h (coding, code_convert_region, encode_coding_gap):
6827 Remove decls.
74ab6df5
PE
6828 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
6829 (iso_code_class, detect_coding, code_convert_region): Now static.
6830 (encode_coding_gap): Remove; unused.
6831
38dfbee1
PE
6832 * chartab.c (chartab_chars, chartab_bits): Now static.
6833
a2cb4e63
PE
6834 * charset.h (charset_iso_8859_1): Remove decl.
6835 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
6836 Now static.
6837
127198fd
PE
6838 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
6839 * ccl.c (Vccl_program_table): Now static.
6840 (check_ccl_update): Remove; unused.
6841
d85b608f
PE
6842 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
6843 * category.h: ... from here.
6844 * category.c (check_category_table, set_category_set): Now static.
6845
31cd66f3
PE
6846 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
6847 * lisp.h: Remove these decls.
6848
c358e587
PE
6849 * buffer.c (buffer_count): Remove unused var.
6850
e78aecca
PE
6851 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
6852 so that it's not optimized away.
6853 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
6854 * dispextern.h (bidi_dump_cached_states): Remove, since it's
6855 exported only to the debugger.
6856
e192d7d3 6857 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 6858 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 6859
92470028
PE
6860 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
6861 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
6862 was inaccessible from Lisp.
6863 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
6864 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
6865
244ed907
PE
6866 alloc.c: Import and export fewer symbols, and remove unused items.
6867 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
6868 is defined.
6869 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
6870 it's not optimized away by whole-program optimization.
6871 (message_enable_multibyte, free_misc): Remove.
6872 (catchlist, handlerlist, mark_backtrace):
6873 Declare only if BYTE_MARK_STACK.
6874 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
6875 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
6876 (message_enable_multibyte): Remove decl.
6877 (free_misc, interval_free_list, float_block, float_block_index):
6878 (n_float_blocks, float_free_list, cons_block, cons_block_index):
6879 (cons_free_list, last_marked_index):
6880 Now static.
6881 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
6882 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
6883 (mark_backtrace): Define only if BYTE_MARK_STACK.
6884 * xdisp.c (message_enable_multibyte): Now static.
6885
61c2b50e 6886 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
6887 This makes it easier for human readers (and static analyzers)
6888 to see whether these variables are used from other modules.
6889 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
6890 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
6891 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
6892 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
6893 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
6894 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
6895 * xmenu.c, xselect.c:
6896 Declare Q* vars static if they are not used in other modules.
6897 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
6898 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
6899 Remove decls of unexported vars.
6900 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
6901
95c82688
PE
6902 * lisp.h (DEFINE_FUNC): Make sname 'static'.
6903
16a97296
PE
6904 Make Emacs functions such as Fatom 'static' by default.
6905 This makes it easier for human readers (and static analyzers)
6906 to see whether these functions can be called from other modules.
6907 DEFUN now defines a static function. To make the function external
6908 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
6909 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
6910 (Finit_image_library):
16a97296
PE
6911 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
6912 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
6913 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
6914 Remove decls, since these functions are now static.
6915 (Funintern, Fget_internal_run_time): New decls, since these functions
6916 were already external.
95c82688 6917
16a97296
PE
6918 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
6919 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
6920 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
6921 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
6922 * keyboard.c, keymap.c, lread.c:
6923 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
6924 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
6925 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
6926 Mark functions with DEFUE instead of DEFUN,
6927 if they are used in other modules.
6928 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
6929 decls for now-static functions.
6930 * buffer.h (Fdelete_overlay): Remove decl.
6931 * callproc.c (Fgetenv_internal): Mark as internal.
6932 * composite.c (Fremove_list_of_text_properties): Remove decl.
6933 (Fcomposition_get_gstring): New forward static decl.
6934 * composite.h (Fcomposite_get_gstring): Remove decl.
6935 * dired.c (Ffile_attributes): New forward static decl.
6936 * doc.c (Fdocumntation_property): New forward static decl.
6937 * eval.c (Ffetch_bytecode): New forward static decl.
6938 (Funintern): Remove extern decl; now in .h file where it belongs.
6939 * fileio.c (Fmake_symbolic_link): New forward static decl.
6940 * image.c (Finit_image_library): New forward static decl.
6941 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
6942 * intervals.h (Fprevious_property_change):
6943 (Fremove_list_of_text_properties): Remove decls.
6944 * keyboard.c (Fthis_command_keys): Remove decl.
6945 (Fcommand_execute): New forward static decl.
6946 * keymap.c (Flookup_key): New forward static decl.
6947 (Fcopy_keymap): Now static.
6948 * keymap.h (Flookup_key): Remove decl.
6949 * process.c (Fget_process): New forward static decl.
6950 (Fprocess_datagram_address): Mark as internal.
6951 * syntax.c (Fsyntax_table_p): New forward static decl.
6952 (skip_chars): Remove duplicate decl.
6953 * textprop.c (Fprevious_property_change): New forward static decl.
6954 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
6955 Now internal.
6956 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
6957 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
6958
785bbd42
PE
6959 * editfns.c (Fformat): Remove unreachable code.
6960
8b913b57
AS
69612011-04-14 Andreas Schwab <schwab@linux-m68k.org>
6962
6963 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
6964 change. (Bug#8496)
6965
a6744a35
EZ
69662011-04-13 Eli Zaretskii <eliz@gnu.org>
6967
6968 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
6969 when at ZV. (Bug#8487)
6970
e7974947
AS
69712011-04-12 Andreas Schwab <schwab@linux-m68k.org>
6972
baad03f0
AS
6973 * charset.c (Fclear_charset_maps): Use xfree instead of free.
6974 (Bug#8437)
6975 * keyboard.c (parse_tool_bar_item): Likewise.
6976 * sound.c (sound_cleanup, alsa_close): Likewise.
6977 * termcap.c (tgetent): Likewise.
6978 * xfns.c (x_default_font_parameter): Likewise.
6979 * xsettings.c (read_and_apply_settings): Likewise.
6980
e7974947
AS
6981 * alloc.c (overrun_check_malloc, overrun_check_realloc)
6982 (overrun_check_free): Protoize.
6983
28272684
PE
69842011-04-12 Paul Eggert <eggert@cs.ucla.edu>
6985
6986 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
6987 since callers should never pass a negative size.
6988 Change the signature to match that of plain 'read' and 'write'; see
6989 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
6990 * lisp.h: Update prototypes of emacs_write and emacs_read.
6991
11997c76
EZ
69922011-04-11 Eli Zaretskii <eliz@gnu.org>
6993
6994 * xdisp.c (redisplay_window): Don't try to determine the character
6995 position of the scroll margin if the window start point w->startp
e896f03c 6996 is outside the buffer's accessible region. (Bug#8468)
11997c76 6997
8a2cbd72
EZ
69982011-04-10 Eli Zaretskii <eliz@gnu.org>
6999
7000 Fix write-region and its subroutines for buffers > 2GB.
7001 * fileio.c (a_write, e_write): Modify declaration of arguments and
7002 local variables to support buffers larger than 2GB.
7003 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
7004
7005 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
7006 argument, local variables, and return value.
7007
7008 * lisp.h: Update prototypes of emacs_write and emacs_read.
7009
7010 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
7011
4073e537 70122011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 7013
1ebfdcb6
PE
7014 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
7015
b2ded58d
PE
7016 Fix more problems found by GCC 4.6.0's static checks.
7017
7d66342c
PE
7018 * xdisp.c (vmessage): Use a better test for character truncation.
7019
bbf47d44
PE
7020 * charset.c (load_charset_map): <, not <=, for optimization,
7021 and to avoid potential problems with integer overflow.
9248994d 7022 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 7023 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 7024 * editfns.c (Fformat): Likewise.
1e69125e 7025 * syntax.c (skip_chars): Likewise.
3befa583 7026
e3019616
PE
7027 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
7028 This also lets GCC 4.6.0 generate slightly better loop code.
7029
becfa255
PE
7030 * callint.c (Fcall_interactively): <, not <=, for optimization.
7031 (Fcall_interactively): Count the number of arguments produced,
7032 not the number of arguments given. This is simpler and lets GCC
7033 4.6.0 generate slightly better code.
7034
dae0cd48
PE
7035 * ftfont.c: Distingish more carefully between FcChar8 and char.
7036 The previous code passed unsigned char * to a functions like
7037 strlen and xstrcasecmp that expect char *, which does not
7038 conform to the C standard.
7039 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
7040 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
7041 char * when the C standard requires it.
7042
76032d70
PE
7043 * keyboard.c (read_char): Remove unused var.
7044
eb3f1cc8
PE
7045 * eval.c: Port to Windows vsnprintf (Bug#8435).
7046 Include <limits.h>.
7047 (SIZE_MAX): Define if the headers do not.
7048 (verror): Do not give up if vsnprintf returns a negative count.
7049 Instead, grow the buffer. This ports to Windows vsnprintf, which
7050 does not conform to C99. Problem reported by Eli Zaretskii.
7051 Also, simplify the allocation scheme, by avoiding the need for
7052 calling realloc, and removing the ALLOCATED variable.
7053
70476b54
PE
7054 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
7055
12020a9e
PE
7056 Remove invocations of doprnt, as Emacs now uses vsnprintf.
7057 But keep the doprint source code for now, as we might revamp it
7058 and use it again (Bug#8435).
ea6c7ae6
PE
7059 * lisp.h (doprnt): Remove.
7060 * Makefile.in (base_obj): Remove doprnt.o.
7061 * deps.mk (doprnt.o): Remove.
7062
5fdb398c
PE
7063 error: Print 32- and 64-bit integers portably (Bug#8435).
7064 Without this change, on typical 64-bit hosts error ("...%d...", N)
7065 was used to print both 32- and 64-bit integers N, which relied on
7066 undefined behavior.
7067 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
7068 New macro.
7069 * lisp.h (error, verror): Mark as printf-like functions.
7070 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
7071 Report overflow in size calculations when allocating printf buffer.
7072 Do not truncate output string at its first null byte.
7073 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
7074 Truncate the output at a character boundary, since vsnprintf does not
7075 do that.
7076 * charset.c (check_iso_charset_parameter): Convert internal
7077 character to string before calling 'error', since %c now has the
7078 printf meaning.
7079 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
7080 overflow when computing char to be passed to 'error'. Do not
7081 pass Lisp_Object to 'error'; pass the integer instead.
7082 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
7083 formatted with plain %d.
7084
b189fa66
PE
7085 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
7086
bff87ef0
PE
7087 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
7088
7e2cac20
PE
7089 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
7090
ce4d90b5
PE
7091 * xterm.c (x_catch_errors): Remove duplicate declaration.
7092
266c9547
PE
7093 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
7094
79c49ad2
PE
7095 * xdisp.c, lisp.h (message_nolog): Remove; unused.
7096
368f4090
JM
70972011-04-10 Jim Meyering <meyering@redhat.com>
7098
7099 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
7100 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
7101 return ssize_t not "int", and use size_t as the buffer length.
7102 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
7103 * gnutls.h: Update declarations.
7104 * process.c (read_process_output): Use ssize_t, to match.
7105 (send_process): Likewise.
7106
a32d4040
CY
71072011-04-09 Chong Yidong <cyd@stupidchicken.com>
7108
7109 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
7110
8546720e 71112011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 7112
04f2d78b
CB
7113 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
7114 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 7115
8546720e
GM
7116 * xterm.c (handle_one_xevent):
7117 * xmenu.c (create_and_show_popup_menu):
7118 * xselect.c (x_decline_selection_request)
7119 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 7120
0a2f5c1a 71212011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
7122
7123 Fix some uses of `int' instead of EMACS_INT.
7124 * search.c (string_match_1, fast_string_match)
7125 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
7126 (scan_buffer, find_next_newline_no_quit)
7127 (find_before_next_newline, search_command, Freplace_match)
7128 (Fmatch_data): Make some `int' variables be EMACS_INT.
7129
7130 * xdisp.c (display_count_lines): 3rd argument and return value now
7131 EMACS_INT. All callers changed.
7132 (pint2hrstr): Last argument is now EMACS_INT.
7133
7134 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
7135 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
7136 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
7137 (decode_coding_utf_16, decode_coding_emacs_mule)
7138 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
7139 (decode_coding_ccl, decode_coding_charset)
7140 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
7141 (decode_coding_iso_2022, decode_coding_emacs_mule)
7142 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
7143 <char_offset, last_offset>: Declare EMACS_INT.
7144 (encode_coding_utf_8, encode_coding_utf_16)
7145 (encode_coding_emacs_mule, encode_invocation_designation)
7146 (encode_designation_at_bol, encode_coding_iso_2022)
7147 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
7148 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
7149 Declare EMACS_INT.
7150 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
7151 (encode_invocation_designation): Last argument P_NCHARS is now
7152 EMACS_INT.
7153 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
7154 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
7155
7156 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
7157 All users changed.
7158
7159 * ccl.c (Fccl_execute_on_string): Declare some variables
7160 EMACS_INT.
7161
8546720e 71622011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
7163
7164 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
7165
4e19a977
CS
71662011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
7167
7168 * process.c (Fformat_network_address): Doc fix.
7169
87302331
R
71702011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
7171
ee7683eb 7172 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 7173
cbb59342
CY
71742011-04-08 Chong Yidong <cyd@stupidchicken.com>
7175
7176 * keyboard.c (read_char): Call Lisp function help-form-show,
7177 instead of using internal_with_output_to_temp_buffer.
7178 (Qhelp_form_show): New var.
e0d38eeb 7179 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
7180
7181 * print.c (internal_with_output_to_temp_buffer): Function deleted.
7182
7183 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
7184
e67a13ab
CY
71852011-04-06 Chong Yidong <cyd@stupidchicken.com>
7186
04f2d78b
CB
7187 * process.c (Flist_processes): Remove to Lisp.
7188 (list_processes_1): Delete.
e67a13ab 7189
973f782d
EZ
71902011-04-06 Eli Zaretskii <eliz@gnu.org>
7191
7c106b1e
EZ
7192 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
7193
973f782d
EZ
7194 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
7195
41cf7d1a 71962011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 7197
ca23cc88
PE
7198 Fix more problems found by GCC 4.6.0's static checks.
7199
f390e2d5
PE
7200 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
7201
42eea0d0
PE
7202 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
7203
b69769da 7204 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 7205
f9541e84
PE
7206 * xdisp.c (vmessage): Mark as a printf-like function.
7207
13841b55
PE
7208 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
7209
c136c10f
PE
7210 * sound.c (sound_warning): Don't crash if arg contains a printf format.
7211
5e2d4a30
PE
7212 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
7213 printf-like functions.
7214 (tiff_load): Add casts to remove these marks before passing them
7215 to system-supplied API.
7216
583f48b9
PE
7217 * eval.c (Fsignal): Remove excess argument to 'fatal'.
7218
b25d760e
PE
7219 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
7220 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
7221 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
7222 directly, rather than having caller test rule sign. This avoids
7223 some unnecessary tests.
7224 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
7225 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
7226 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 7227
bc7b6697 7228 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 7229 (xfont_open): Avoid unnecessary tests.
bc7b6697 7230
27ccc379
PE
7231 * composite.c (composition_gstring_put_cache): Use unsigned integer.
7232
dcd5c89a
PE
7233 * composite.h, composite.c (composition_gstring_put_cache):
7234 Use EMACS_INT, not int, for length.
7235
b13a45c6
PE
7236 * composite.h (COMPOSITION_DECODE_REFS): New macro,
7237 breaking out part of COMPOSITION_DECODE_RULE.
7238 (COMPOSITION_DECODE_RULE): Use it.
7239 * composite.c (get_composition_id): Remove unused local vars,
7240 by using the new macro.
7241
1e792e4d
PE
7242 * textprop.c (set_text_properties_1): Change while to do-while,
7243 since the condition is always true at first.
7244
dc6c6455 7245 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
7246 (interval_deletion_adjustment): Return unsigned value.
7247 All uses changed.
dc6c6455 7248
aba7731a
PE
7249 * process.c (list_processes_1, create_pty, read_process_output):
7250 (exec_sentinel): Remove vars that were set but not used.
afd4052b 7251 (create_pty): Remove unnecessary "volatile"s.
bc57d757 7252 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 7253 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 7254 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 7255
fdfc4bf3
PE
7256 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
7257
fca8fe46 7258 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 7259 (update_syntax_table): Use unsigned instead of int.
fca8fe46 7260
06a0259a 7261 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 7262 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 7263 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 7264
e7b9e80f
PE
7265 * print.c (print_error_message): Avoid int overflow.
7266
56201685
PE
7267 * font.c (font_list_entities): Redo for clarity,
7268 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
7269
78834453 7270 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 7271 (font_score): Avoid potential overflow in diff calculation.
78834453 7272
0bc0b309 7273 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 7274 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 7275
e610eaca
PE
7276 * eval.c (funcall_lambda): Rename local to avoid shadowing.
7277
b895abce
PE
7278 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
7279 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
7280 can always succeed if overflow has undefined behavior.
7281
1f1d9321 7282 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 7283 (wordify): Omit three unnecessary tests.
1f1d9321 7284
c59478bc
PE
7285 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
7286 All callers changed. This avoids the need for an unused var.
7287
79b73827
PE
7288 * casefiddle.c (casify_region): Remove var that is set but not used.
7289
a4db5dfe
PE
7290 * dired.c (file_name_completion): Remove var that is set but not used.
7291
43aae36e
PE
7292 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
7293
2a47c44d 7294 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 7295 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 7296
a37c69bf
PE
7297 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
7298 Check for integer overflow on size calculations.
7299
328ab8e7
PE
7300 * buffer.c (Fprevious_overlay_change): Remove var that is set
7301 but not used.
7302
e5a2a5cb
PE
7303 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
7304 Remove vars that are set but not used.
8d84a6eb 7305 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 7306 (timer_check_2): Mark vars as initialized.
e5a2a5cb 7307
a60e5f68
PE
7308 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
7309
f661cb61 7310 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 7311 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 7312
f0397f5a
PE
7313 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
7314 that are set but not used.
7315
8664db06 7316 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 7317 if XCreateBitmapFromData fails (Bug#8410).
8664db06 7318
6abdaa4a
PE
7319 * xselect.c (x_get_local_selection, x_handle_property_notify):
7320 Remove vars that are set but not used.
7321
0ce7538d 7322 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 7323 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 7324
9ae848fc
PE
7325 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
7326 Remove var that is set but not used.
0b918413
PE
7327 (scroll_bar_windows_size): Now size_t, not int.
7328 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
7329 Check for overflow.
9ae848fc 7330
a5a62657
PE
7331 * xfaces.c (realize_named_face): Remove vars that are set but not used.
7332 (map_tty_color) [!defined MSDOS]: Likewise.
7333
5c5cdd39
PE
7334 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
7335
66ebf983
PE
7336 * coding.c: Remove vars that are set but not used.
7337 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
7338 All callers changed.
7339 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
7340 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
7341 (decode_coding_charset): Remove vars that are set but not used.
7342
1be4d761
PE
7343 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
7344 that is set but not used.
7345
47553fa8
PE
7346 * print.c (print_object): Remove var that is set but not used.
7347
1f7196bf 7348 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
7349 The gnulib version avoids calling malloc in the usual case,
7350 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
7351 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
7352 * filelock.c (current_lock_owner): Likewise.
7353 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
7354 * sysdep.c: Include allocator.h, careadlinkat.h.
7355 (emacs_no_realloc_allocator): New static constant.
7356 (emacs_readlink): New function.
fdb61804
PE
7357 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
7358 ../lib/careadlinkat.h.
d1fdcab7 7359
f84c17c7
SM
73602011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
7361
7362 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
7363 first non-nil return value).
7364
ef3862ad
JD
73652011-04-03 Jan Djärv <jan.h.d@swipnet.se>
7366
7367 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
7368 if not defined (Bug#8403).
7369
376a7006
JB
73702011-04-02 Juanma Barranquero <lekktu@gmail.com>
7371
7372 * xdisp.c (display_count_lines): Remove parameter `start',
7373 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7374 (get_char_face_and_encoding): Remove parameter `multibyte_p',
7375 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7376 (fill_stretch_glyph_string): Remove parameters `row' and `area',
7377 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
7378 and thereabouts. All callers changed.
7379 (get_per_char_metric): Remove parameter `f', unused since
7380 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
7381
6ca3801d
JM
73822011-04-02 Jim Meyering <meyering@redhat.com>
7383
7384 do not dereference NULL upon failed strdup
7385 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
7386 (ns_get_family): Likewise.
7387
d8e2b5ba
JB
73882011-04-02 Juanma Barranquero <lekktu@gmail.com>
7389
7390 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
7391
8c74fcbd
JD
73922011-04-02 Jan Djärv <jan.h.d@swipnet.se>
7393
7394 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
7395 later (Bug#8403).
7396
7200d79c
SM
73972011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
7398
03408648 7399 Add lexical binding.
7200d79c 7400
03408648
SM
7401 * window.c (Ftemp_output_buffer_show): New fun.
7402 (Fsave_window_excursion):
7403 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
7404
7405 * lread.c (lisp_file_lexically_bound_p): New function.
7406 (Fload): Bind Qlexical_binding.
7407 (readevalloop): Remove `evalfun' arg.
7408 Bind Qinternal_interpreter_environment.
7409 (Feval_buffer): Bind Qlexical_binding.
7410 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
7411 Mark as dynamic.
7412 (syms_of_lread): Declare `lexical-binding'.
7413
7414 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
7415
7416 * keyboard.c (eval_dyn): New fun.
7417 (menu_item_eval_property): Use it.
ca105506
SM
7418
7419 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 7420
03408648
SM
7421 * fns.c (concat, mapcar1): Accept byte-code-functions.
7422
7423 * eval.c (Fsetq): Handle lexical vars.
7424 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
7425 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
7426 (FletX, Flet): Obey lexical binding.
7427 (Fcommandp): Handle closures.
7428 (Feval): New `lexical' arg.
7429 (eval_sub): New function extracted from Feval. Use it almost
7430 everywhere where Feval was used. Look up vars in lexical env.
7431 Handle closures.
7432 (Ffunctionp): Move from subr.el.
7433 (Ffuncall): Handle closures.
7434 (apply_lambda): Remove `eval_flags'.
7435 (funcall_lambda): Handle closures and new byte-code-functions.
7436 (Fspecial_variable_p): New function.
7437 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
7438 but without exporting it to Lisp.
23aba0ea 7439
23aba0ea 7440 * doc.c (Fdocumentation, store_function_docstring):
03408648 7441 * data.c (Finteractive_form): Handle closures.
23aba0ea 7442
03408648
SM
7443 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
7444 interactive spec.
ba83908c 7445
04f2d78b
CB
7446 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
7447 New byte-codes.
03408648
SM
7448 (exec_byte_code): New function extracted from Fbyte_code to handle new
7449 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 7450
03408648 7451 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 7452
03408648 7453 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 7454
e2abce01
JB
74552011-03-31 Juanma Barranquero <lekktu@gmail.com>
7456
7457 * xdisp.c (redisplay_internal): Fix prototype.
7458
63696a73 74592011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 7460
63696a73 7461 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
7462 (try_scrolling): Use it when setting scroll_limit.
7463 Limit scrolling to 100 screen lines.
63696a73
EZ
7464 (redisplay_window): Even when falling back on "recentering",
7465 position point in the window according to scroll-conservatively,
7466 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
7467
7468 (try_scrolling): When point is above the window, allow searching
7469 as far as scroll_max, or one screenful, to compute vertical
7470 distance from PT to the scroll margin position. This prevents
7471 try_scrolling from unnecessarily failing when
7472 scroll-conservatively is set to a value slightly larger than the
7473 window height. Clean up the case of PT below the margin at bottom
7474 of window: scroll_max can no longer be INT_MAX. When aggressive
7475 scrolling is in use, don't let point enter the opposite scroll
7476 margin as result of the scroll.
7477 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
7478 threshold of 100 lines for never-recentering scrolling.
7479
e4cc2dfc
JB
74802011-03-31 Juanma Barranquero <lekktu@gmail.com>
7481
7482 * dispextern.h (move_it_by_lines):
7483 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
7484 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
7485 (message_log_check_duplicate): Remove parameters `prev_bol' and
7486 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
7487 (redisplay_internal): Remove parameter `preserve_echo_area',
7488 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
7489
7490 * indent.c (Fvertical_motion):
7491 * window.c (window_scroll_pixel_based, Frecenter):
7492 Don't pass `need_y_p' to `move_it_by_lines'.
7493
1c470562
SM
74942011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
7495
44f230aa
SM
7496 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
7497 steal a few bits to be more compact.
7498 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
7499 Remove unneeded casts.
7500
1c470562
SM
7501 * bytecode.c (Fbyte_code): CAR and CDR can GC.
7502
888adce9
ZK
75032011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
7504
7505 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
7506 binding" message (bug#7967).
7507
f838ed7b
PE
75082011-03-30 Paul Eggert <eggert@cs.ucla.edu>
7509
77861b95
PE
7510 Fix more problems found by GCC 4.6.0's static checks.
7511
de6dbc14
PE
7512 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
7513 Remove unused local var.
7514
f838ed7b
PE
7515 * editfns.c (Fmessage_box): Remove unused local var.
7516
792c7b2b
PE
7517 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
7518 (note_mode_line_or_margin_highlight, note_mouse_highlight):
7519 Omit unused local vars.
c499e557 7520 * window.c (shrink_windows): Omit unused local var.
b01a1c29 7521 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
7522 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
7523 Omit unused local var.
7524
ba0165e1
PE
7525 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
7526 Don't assume string length fits in int.
32ad8845 7527 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 7528 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 7529
3c59b4c9
PE
7530 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
7531 instead of alloca (Bug#8344).
7532
a3eed478 7533 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 7534 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 7535
eb4d412d
PE
7536 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
7537
1658b401
PE
7538 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
7539 concerns.
7540
7541 * term.c (produce_glyphless_glyph): Remove unnecessary test.
7542
7543 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 7544
9a2c6e05
PE
7545 * keyboard.c (syms_of_keyboard): Use the same style as later
7546 in this function when indexing through an array. This also
7547 works around GCC bug 48267.
7548
03d0a109
PE
7549 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
7550
44f730c8
PE
7551 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
7552
fe75f926
PE
7553 * chartab.c (sub_char_table_ref_and_range): Redo for slight
7554 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
7555
ffa8c828
PE
7556 * keyboard.c, keyboard.h (num_input_events): Now size_t.
7557 This avoids undefined behavior on integer overflow, and is a bit
7558 more convenient anyway since it is compared to a size_t variable.
7559
c5101a77
PE
7560 Variadic C functions now count arguments with size_t, not int.
7561 This avoids an unnecessary limitation on 64-bit machines, which
7562 caused (substring ...) to crash on large vectors (Bug#8344).
7563 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
7564 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 7565 All variadic functions and their callers changed accordingly.
c5101a77
PE
7566 (struct gcpro.nvars): Now size_t, not int. All uses changed.
7567 * data.c (arith_driver, float_arith_driver): Likewise.
7568 * editfns.c (general_insert_function): Likewise.
7569 * eval.c (struct backtrace.nargs, interactive_p)
7570 (internal_condition_case_n, run_hook_with_args, apply_lambda)
7571 (funcall_lambda, mark_backtrace): Likewise.
7572 * fns.c (concat): Likewise.
7573 * frame.c (x_set_frame_parameters): Likewise.
7574 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
7575 0 if not found, not -1. All callers changed.
7576
dd3f25f7
PE
7577 * alloc.c (garbage_collect): Don't assume stack size fits in int.
7578 (stack_copy_size): Now size_t, not int.
7579 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
7580
461c2ab9
JB
75812011-03-28 Juanma Barranquero <lekktu@gmail.com>
7582
7583 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
7584 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7585 All callers changed.
7586
7587 * lisp.h (multibyte_char_to_unibyte):
7588 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
7589 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
7590 * character.h (CHAR_TO_BYTE8):
7591 * cmds.c (internal_self_insert):
7592 * editfns.c (general_insert_function):
7593 * keymap.c (push_key_description):
7594 * search.c (Freplace_match):
7595 * xdisp.c (message_dolog, set_message_1): All callers changed.
7596
f6d62986
SM
75972011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
7598
7599 * keyboard.c (safe_run_hook_funcall): New function.
7600 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
7601 don't set the hook to nil, but remove the offending function instead.
7602 (Qcommand_hook_internal): Remove, unused.
7603 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
7604 Vcommand_hook_internal.
7605
7606 * eval.c (enum run_hooks_condition): Remove.
7607 (funcall_nil, funcall_not): New functions.
7608 (run_hook_with_args): Call each function through a `funcall' argument.
7609 Remove `cond' argument, now redundant.
7610 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
7611 (Frun_hook_with_args_until_failure): Adjust accordingly.
7612 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
7613
1db5b1ad
JB
76142011-03-28 Juanma Barranquero <lekktu@gmail.com>
7615
7616 * dispextern.h (string_buffer_position): Remove declaration.
7617
7618 * print.c (strout): Remove parameter `multibyte', unused since
7619 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
7620
7621 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
7622 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
7623 All callers changed.
7624
7625 * w32.c (_wsa_errlist): Use braces for struct initializers.
7626
7627 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
7628 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
7629 All callers changed.
7630 (string_buffer_position): Likewise. Also, make static (it's never
7631 used outside xdisp.c).
7632 (cursor_row_p): Remove parameter `w', unused since
7633 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
7634 (decode_mode_spec): Remove parameter `precision', introduced during
7635 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
7636 All callers changed.
7637
5ffb62aa
JD
76382011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7639
7640 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
7641
461c2ab9 76422011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
7643
7644 * nsterm.m (ns_menu_bar_is_hidden): New variable.
7645 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
7646 (ns_update_auto_hide_menu_bar): New functions.
7647 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
7648 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
7649 ns_constrain_all_frames.
7650 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
7651 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
7652
5c380ffb
JD
76532011-03-27 Jan Djärv <jan.h.d@swipnet.se>
7654
7655 * nsmenu.m (runDialogAt): Remove argument to timer_check.
7656
9af30bdf
GM
76572011-03-27 Glenn Morris <rgm@gnu.org>
7658
7659 * syssignal.h: Replace RETSIGTYPE with void.
7660 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
7661 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
7662 Replace SIGTYPE with void everywhere.
7663 * s/usg5-4-common.h (SIGTYPE): Remove definition.
7664 * s/template.h (SIGTYPE): Remove commented out definition.
7665
e2abce01
JB
76662011-03-26 Eli Zaretskii <eliz@gnu.org>
7667
7668 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
7669 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
7670
f868cd8a
JB
76712011-03-26 Juanma Barranquero <lekktu@gmail.com>
7672
59eb0929
JB
7673 * w32.c (read_unc_volume): Use parameter `henum', instead of
7674 global variable `wget_enum_handle'.
7675
7676 * keymap.c (describe_vector): Remove parameters `indices' and
7677 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
7678 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
7679
f868cd8a
JB
7680 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
7681
7682 * keyboard.c (timer_check): Remove parameter `do_it_now',
7683 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
7684 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
7685 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
7686
7687 * keyboard.c (read_char):
7688 * w32menu.c (w32_menu_display_help):
7689 * xmenu.c (show_help_event, menu_help_callback):
7690 Adjust calls to `show_help_echo'.
7691
7692 * gtkutil.c (xg_maybe_add_timer):
7693 * keyboard.c (readable_events):
7694 * process.c (wait_reading_process_output):
7695 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
7696
7697 * insdel.c (adjust_markers_gap_motion):
7698 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
7699 (gap_left, gap_right): Don't call it.
7700
2ecf6fdb
CY
77012011-03-25 Chong Yidong <cyd@stupidchicken.com>
7702
7703 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
7704 incurred during fontification.
7705
6b1f9ba4
JB
77062011-03-25 Juanma Barranquero <lekktu@gmail.com>
7707
7708 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
7709 (DEFVAR_PER_BUFFER): Don't pass it.
7710
7711 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
7712 (scrolling_window): Don't pass it.
7713
0f4a96b5
JB
77142011-03-25 Juanma Barranquero <lekktu@gmail.com>
7715
7716 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
7717
7718 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
7719 and `suffix'.
7720 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
7721 of variables specific to SELinux and computation of `encoded_absname'.
7722
7723 * image.c (XPutPixel): Remove unused variable `height'.
7724
7725 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
7726
7727 * unexw32.c (get_section_info): Remove unused variable `section'.
7728
7729 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
7730 (system_process_attributes): Remove unused variable `sess'.
7731 (sys_read): Remove unused variable `err'.
7732
7733 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
7734 (w32_wnd_proc): Remove unused variable `isdead'.
7735 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
7736 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
7737 (x_create_tip_frame): Remove unused variable `tem'.
7738
7739 * w32inevt.c (w32_console_read_socket):
7740 Remove unused variable `no_events'.
7741
7742 * w32term.c (x_draw_composite_glyph_string_foreground):
7743 Remove unused variable `width'.
7744
1149507c
JB
77452011-03-24 Juanma Barranquero <lekktu@gmail.com>
7746
7747 * w32term.c (x_set_glyph_string_clipping):
7748 Don't pass uninitialized region to CombineRgn.
7749
9c88f339
JB
77502011-03-23 Juanma Barranquero <lekktu@gmail.com>
7751
7752 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
7753 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
7754 (Fx_close_connection): Remove unused variable `i'.
7755
7756 * w32font.c (w32font_draw): Return number of glyphs.
7757 (w32font_open_internal): Remove unused variable `i'.
7758 (w32font_driver): Add missing initializer.
7759
7760 * w32menu.c (utf8to16): Remove unused variable `utf16'.
7761 (fill_in_menu): Remove unused variable `items_added'.
7762
7763 * w32term.c (last_mouse_press_frame): Remove static global variable.
7764 (w32_clip_to_row): Remove unused variable `f'.
7765 (x_delete_terminal): Remove unused variable `i'.
7766
7767 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
7768 (NOTHING): Remove unused static global variable.
7769 (uniscribe_check_otf): Remove unused variable `table'.
7770 (uniscribe_font_driver): Add missing initializers.
7771
dee091a3
JD
77722011-03-23 Julien Danjou <julien@danjou.info>
7773
7774 * term.c (Fsuspend_tty, Fresume_tty):
7775 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
7776 * window.c (temp_output_buffer_show):
7777 * insdel.c (signal_before_change):
7778 * frame.c (Fhandle_switch_frame):
7779 * fileio.c (Fdo_auto_save):
7780 * emacs.c (Fkill_emacs):
7781 * editfns.c (save_excursion_restore):
7782 * cmds.c (internal_self_insert):
7783 * callint.c (Fcall_interactively):
7784 * buffer.c (Fkill_all_local_variables):
7785 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
7786 Use Frun_hooks.
0f4a96b5 7787 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 7788 unconditionally since it does the check itself.
dee091a3 7789
2c520ab5 77902011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 7791
c9c49752
PE
7792 Fix more problems found by GCC 4.5.2's static checks.
7793
8abc3f12
PE
7794 * coding.c (encode_coding_raw_text): Avoid unnecessary test
7795 the first time through the loop, since we know p0 < p1 then.
7796 This also avoids a gcc -Wstrict-overflow warning.
7797
a2d26660
PE
7798 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
7799 leading to a memory leak, possible in functions like
7800 load_charset_map_from_file that can allocate an unbounded number
b12ef411 7801 of objects (Bug#8318).
a2d26660 7802
916c72e9
PE
7803 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
7804 that could (at least in theory) be that large.
7805
19ab8a18
PE
7806 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
7807 This is less likely to overflow, and avoids undefined behavior if
7808 overflow does occur. All callers changed. Use strtoul to scan
7809 for the unsigned long integer.
b7cbbd6f
PE
7810 (pint2hrstr): Simplify and tune code slightly.
7811 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 7812
f0641eff
PE
7813 * scroll.c (do_scrolling): Work around GCC bug 48228.
7814 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
7815
7f650bb9
PE
7816 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
7817 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
7818 (validate_x_resource_name): Simplify count usage.
7819 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 7820
37dd57d1
PE
7821 * fileio.c (Fcopy_file): Report error if fchown or fchmod
7822 fail (Bug#8306).
81e56e61 7823
699979fc 7824 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 7825
401bf9b4
PE
7826 * process.c (Fmake_network_process): Use socklen_t, not int,
7827 where POSIX says socklen_t is required in portable programs.
7828 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 7829 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
7830 (Fmake_network_process, server_accept_connection):
7831 (wait_reading_process_output, read_process_output):
7832 Likewise.
7833
b93aacde
PE
7834 * process.c: Rename or move locals to avoid shadowing.
7835 (list_processes_1, Fmake_network_process):
7836 (read_process_output_error_handler, exec_sentinel_error_handler):
7837 Rename or move locals.
4dc343ee 7838 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 7839 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 7840 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 7841 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 7842 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 7843
af8a867c 7844 Make tparam.h and terminfo.c consistent.
44f230aa
SM
7845 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
7846 Include tparam.h instead, since it declares them.
af8a867c
PE
7847 * cm.h (PC): Remove extern decl; tparam.h now does this.
7848 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
7849 * terminfo.c: Include tparam.h, to check interfaces.
7850 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
7851 (tparam): Adjust signature to match interface in tparam.h;
7852 this removes some undefined behavior. Check that outstring and len
7853 are zero, which they always are with Emacs.
7854 * tparam.h (PC, BC, UP): New extern decls.
7855
0248044d 7856 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 7857 (xftfont_open): Rename locals to avoid shadowing.
0248044d 7858
8ff096c1 7859 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
7860 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
7861 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 7862 (ftfont_list): Remove unused local.
49eaafba
PE
7863 (get_adstyle_property, ftfont_pattern_entity):
7864 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
7865 Rename locals to avoid shadowing.
8ff096c1 7866
e2be39f6
PE
7867 * xfont.c (xfont_list_family): Mark var as initialized.
7868
c9735e30
PE
7869 * xml.c (make_dom): Now static.
7870
8f5201ae
PE
7871 * composite.c (composition_compute_stop_pos): Rename local to
7872 avoid shadowing.
b246f932
PE
7873 (composition_reseat_it): Remove unused locals.
7874 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 7875 (composition_update_it): Mark var as initialized.
11b61122
PE
7876 (find_automatic_composition): Mark vars as initialized,
7877 with a FIXME (Bug#8290).
8f5201ae 7878
760fbc2c
PE
7879 character.h: Rename locals to avoid shadowing.
7880 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
7881 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
7882 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
7883 (BUF_DEC_POS): Be more systematic about renaming local temporaries
7884 to avoid shadowing.
7885
ff08eb85
PE
7886 * textprop.c (property_change_between_p): Remove; unused.
7887
fc7bf025
PE
7888 * intervals.c (interval_start_pos): Now static.
7889
235d7abc
PE
7890 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
7891
44f230aa
SM
7892 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
7893 Rename locals to avoid shadowing.
3e7d6594 7894
50060332
PE
7895 * sound.c (wav_play, au_play, Fplay_sound_internal):
7896 Fix pointer signedness.
d01f234b 7897 (alsa_choose_format): Remove unused local var.
c83b8872
PE
7898 (wav_play): Initialize a variable to 0, to prevent undefined
7899 behavior (Bug#8278).
50060332 7900
c4fc4e30
PE
7901 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
7902
918436ed
PE
7903 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
7904
c939f91b
PE
7905 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
7906 clobbering (Bug#8298).
b9c7f648
PE
7907 * sysdep.c (sys_subshell): Likewise.
7908 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 7909
6bd8c144
PE
7910 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
7911 This should get cleaned up, so that child_setup has the
7912 same signature on all platforms.
7913
7710357c 7914 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 7915 (relocate_fd): Rename locals to avoid shadowing.
7710357c 7916
c59da222
CY
79172011-03-22 Chong Yidong <cyd@stupidchicken.com>
7918
7919 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
7920 not to be necessary, and produces flickering.
7921
66b87493
GM
79222011-03-20 Glenn Morris <rgm@gnu.org>
7923
7924 * config.in: Remove file.
7925
45b6f6d5
JB
79262011-03-20 Juanma Barranquero <lekktu@gmail.com>
7927
7928 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
7929 are now in src/globals.h.
7930 (syms_of_minibuf): Remove spurious & from previous change.
7931
3ec03f7e
LL
79322011-03-20 Leo <sdl.web@gmail.com>
7933
7934 * minibuf.c (completing-read-function): New variable.
7935 (completing-read-default): Rename from completing-read.
7936 (completing-read): Call completing-read-function.
7937
b14e3e21
CY
79382011-03-19 Juanma Barranquero <lekktu@gmail.com>
7939
7940 * xfaces.c (Fx_load_color_file):
7941 Read color file from absolute filename (bug#8250).
7942
f2b726e6
JB
79432011-03-19 Juanma Barranquero <lekktu@gmail.com>
7944
7945 * makefile.w32-in: Update dependencies.
7946
09f6ff02
EZ
79472011-03-17 Eli Zaretskii <eliz@gnu.org>
7948
7949 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
7950
29a6015a
PE
79512011-03-17 Paul Eggert <eggert@cs.ucla.edu>
7952
a3a6c54e
PE
7953 Fix more problems found by GCC 4.5.2's static checks.
7954
b766f867
PE
7955 * process.c (make_serial_process_unwind, send_process_trap):
7956 (sigchld_handler): Now static.
7957
be02381c
PE
7958 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
7959 That way, the code declares only the vars that it needs.
7960 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
7961 * s/cygwin.h (PTY_ITERATION): Likewise.
7962 * s/darwin.h (PTY_ITERATION): Likewise.
7963 * s/gnu-linux.h (PTY_ITERATION): Likewise.
7964
57048744
PE
7965 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
7966 * process.c (allocate_pty): Don't declare stb unless it's needed.
7967
7914961c 7968 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
7969 (CONSTANTLIM): Remove; unused.
7970 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
7971 Define only if needed.
7914961c 7972
b3967b18
PE
7973 * unexelf.c (unexec): Name an expression,
7974 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
7975 Use a different way to cause a compilation error if anyone uses
7976 n rather than nn, a way that does not involve shadowing.
73366a00 7977 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 7978
29a6015a
PE
7979 * deps.mk (unexalpha.o): Remove; unused.
7980
43cfc33e 7981 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 7982 * unexec.h: New file.
ce701a33
PE
7983 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
7984 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
7985 Depend on unexec.h.
7986 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
7987 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
7988 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 7989 Change as necessary to match prototype in unexec.h.
ce701a33 7990
01f44d5a
PE
7991 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
7992 shadowing.
4f63c6bb 7993 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 7994
a6670b0b
PE
7995 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
7996 Rename locals to avoid shadowing.
7997
cef2010d 7998 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 7999 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 8000
d4d7173a
PE
8001 * print.c (Fredirect_debugging_output): Fix pointer signedess.
8002
f08b802a
PE
8003 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
8004 warning when compiling print.c.
8005
3ddb0639
PE
8006 * font.c (font_unparse_fcname): Abort in an "impossible" situation
8007 instead of using an uninitialized var.
5ad03b97 8008 (font_sort_entities): Mark var as initialized.
3ddb0639 8009
170a2692
PE
8010 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
8011
e663c700
PE
8012 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
8013 pointers to constants.
89bc529a 8014 (font_parse_fcname): Remove unused vars.
7b81e2d0 8015 (font_delete_unmatched): Now static.
ea838e10 8016 (font_get_spec): Remove; unused.
13a547c6
PE
8017 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
8018 (font_update_drivers, Ffont_get_glyphs, font_add_log):
8019 Rename or move locals to avoid shadowing.
e663c700 8020
2a80c887 8021 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 8022 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 8023
1384fa33 8024 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 8025 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 8026
8b2c52e9
PE
8027 * alloc.c (mark_backtrace): Move decl from here ...
8028 * lisp.h: ... to here, so that it can be checked.
8029
475545b5 8030 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 8031 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
8032 (lisp_indirect_variable): Name an expression,
8033 to avoid gcc -Wbad-function-cast warning.
1faed8ae 8034 (Fdefvar): Rename locals to avoid shadowing.
475545b5 8035
b1349114 8036 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 8037 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 8038 Use const pointer when appropriate.
b1349114 8039
a2928364
PE
8040 * lisp.h (get_system_name, get_operating_system_release):
8041 Move decls here, to check interfaces.
8042 * process.c (get_operating_system_release): Move decl to lisp.h.
8043 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
8044 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
8045 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
8046 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
8047 (Fformat_time_string, Fencode_time, Finsert_char):
8048 (Ftranslate_region_internal, Fformat):
8049 Rename or remove local vars to avoid shadowing.
9710023e 8050 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 8051
a415e694
PE
8052 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
8053 avoid shadowing.
8054
8ef4622d
PE
8055 * lisp.h (eassert): Check that the argument compiles, even if
8056 ENABLE_CHECKING is not defined.
8057
946f9a5b
PE
8058 * data.c (Findirect_variable): Name an expression, to avoid
8059 gcc -Wbad-function-cast warning.
112396d6 8060 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 8061 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
8062 (Fmake_variable_buffer_local, Fmake_local_variable):
8063 Mark variables as initialized.
52746918 8064 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 8065
e5aab7e7 8066 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
8067 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
8068 Rename locals to avoid shadowing.
dff45157
PE
8069 (mark_stack): Move local variables into the #ifdef region where
8070 they're used.
7bc26fdb
PE
8071 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
8072 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
8073 needed otherwise.
8074 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
8075 (GC_STRING_CHARS): Remove; not used.
d40d4be1 8076 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 8077
e5aab7e7
PE
8078 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
8079 avoids undefined behavior in theory.
8080
4da60324
PE
8081 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
8082
88043301
PE
8083 Use functions, not macros, for up- and down-casing (Bug#8254).
8084 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8085 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
8086 to use the following functions instead of these macros.
8087 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
8088 EMACS_INT, since callers assume the returned value fits in int.
8089 (upcase1): Likewise, for UPCASE_TABLE.
8090 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 8091 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 8092 the race-condition problem in the old DOWNCASE.
88043301 8093
19ed5445
PE
8094 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
8095 Rename locals to avoid shadowing.
8096 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
8097 (regex_compile, re_search_2, re_match_2_internal):
8098 Remove unused local vars.
952db0d7
PE
8099 (FREE_VAR): Rewrite so as not to use empty "else",
8100 which gcc can warn about.
da053e48 8101 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
8102 (RETALLOC_IF): Define only if needed.
8103 (WORDCHAR_P): Likewise. This one is never needed, but is used
8104 only in a comment talking about a compiler bug, so put inside
8105 the #if 0 of that comment.
8106 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
8107 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
8108 Remove; unused.
19ed5445 8109
1f3561e4 8110 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
8111 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
8112 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 8113
ded6f8f7
PE
8114 * search.c (simple_search): Remove unused var.
8115
dbd37a95
PE
8116 * dired.c (compile_pattern): Move decl from here ...
8117 * lisp.h: ... to here, so that it can be checked.
8118 (struct re_registers): New forward decl.
8119
7e47afad
PE
8120 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
8121
85f24f61
PE
8122 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
8123 All uses changed.
8124 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
8125 Rename locals to avoid shadowing.
5671df8f 8126 (Fvertical_motion): Mark locals as initialized.
85f24f61 8127
181aa2be 8128 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 8129 (casify_region): Mark local as initialized.
181aa2be 8130
930d429c
PE
8131 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
8132
7082eac6
PE
8133 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
8134 New macros, so that the caller can use some names other than
8135 gcpro1, gcpro2, etc.
8136 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
8137 of the new macros.
8138 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
8139 argument, for consistency with GCPRO2_VAR, etc: it is now the
8140 prefix of the variable, not the variable itself. All uses
8141 changed.
38b2c076
PE
8142 * dired.c (directory_files_internal, file_name_completion):
8143 Rename locals to avoid shadowing.
8144
15206ed9
PE
8145 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
8146 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
8147 dired.c's scmp function, had undefined behavior.
8148 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
8149 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
8150 * buffer.h: ... to here, because these macros use current_buffer,
8151 and the new implementation with inline functions needs to have
8152 current_buffer in scope now, rather than later when the macros
8153 are used.
8154 (downcase, upcase1): New static inline functions.
8155 (DOWNCASE, UPCASE1): Reimplement using these functions.
8156 This avoids undefined behavior in expressions like
8157 DOWNCASE (x) == DOWNCASE (y), which previously suffered
8158 from race conditions in accessing the global variables
8159 case_temp1 and case_temp2.
8160 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
8161 * lisp.h (case_temp1, case_temp2): Remove their decls.
8162 * character.h (ASCII_CHAR_P): Move from here ...
8163 * lisp.h: ... to here, so that the inline functions mentioned
8164 above can use them.
8165
4a6bea26
PE
8166 * dired.c (directory_files_internal_unwind): Now static.
8167
f14b7e14
PE
8168 * fileio.c (file_name_as_directory, directory_file_name):
8169 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
8170 Now static.
2893f146
PE
8171 (file_name_as_directory): Use const pointers when appropriate.
8172 (Fexpand_file_name): Likewise. In particular, newdir might
8173 point at constant storage, so make it a const pointer.
fd4ead52 8174 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
8175 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
8176 signedness issues.
f839df0c
PE
8177 (Fset_file_times, Finsert_file_contents, auto_save_error):
8178 Rename locals to avoid shadowing.
f14b7e14 8179
5716756e 8180 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
8181 (Ftry_completion, Fall_completions): Rename or remove locals
8182 to avoid shadowing.
5716756e 8183
b4c3046a
PE
8184 * marker.c (bytepos_to_charpos): Remove; unused.
8185
b45db522
PE
8186 * lisp.h (verify_bytepos, count_markers): New decls,
8187 so that gcc does not warn that these functions aren't declared.
8188
85876d07
PE
8189 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
8190 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 8191 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 8192 (copy_text): Remove unused local var.
85876d07 8193
03d78a21 8194 * filelock.c (within_one_second): Now static.
b3dd38ab 8195 (lock_file_1): Rename local to avoid shadowing.
03d78a21 8196
5df8f01b
PE
8197 * buffer.c (fix_overlays_before): Mark locals as initialized.
8198 (fix_start_end_in_overlays): Likewise. This function should be
8199 simplified by using pointers-to-pointers, but that's a different
8200 matter.
b1d876f1 8201 (switch_to_buffer_1): Now static.
8f54f30a
PE
8202 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
8203 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 8204
a70072c9 8205 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 8206 Fix pointer signedness issue.
edced198
PE
8207 (sys_subshell): Mark local as volatile if checking for lint,
8208 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 8209 (MAXPATHLEN): Define only if needed.
a70072c9 8210
a0977c44
PE
8211 * process.c (serial_open, serial_configure): Move decls from here ...
8212 * systty.h: ... to here, so that they can be checked.
8213
a884fdcc
PE
8214 * fns.c (get_random, seed_random): Move extern decls from here ...
8215 * lisp.h: ... to here, so that they can be checked.
8216
604efe86 8217 * sysdep.c (reset_io): Now static.
b8950c94 8218 (wait_for_termination_signal): Remove; unused.
604efe86 8219
38fc62d9
PE
8220 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
8221 (copy_keymap_item, append_key, push_text_char_description):
8222 Now static.
1004a21a 8223 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 8224 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
8225 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
8226 (describe_map_tree):
8227 Rename locals to avoid shadowing.
38fc62d9 8228
2f2650da
PE
8229 * keyboard.c: Declare functions static if they are not used elsewhere.
8230 (echo_char, echo_dash, cmd_error, top_level_2):
8231 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
8232 (read_char, kbd_buffer_get_event, make_lispy_position):
8233 (make_lispy_event, make_lispy_movement, apply_modifiers):
8234 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
8235 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
8236 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 8237 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 8238 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 8239
a053e86c 8240 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
8241 (mark_kboards): Move decl here ...
8242 * alloc.c (mark_kboards): ... from here.
a053e86c 8243
4752793e
PE
8244 * lisp.h (force_auto_save_soon): New decl.
8245
74f10ca7 8246 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
8247 (DEFINE_DUMMY_FUNCTION): New macro.
8248 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
8249 Use it.
c03cd23f
PE
8250 (main): Add casts to avoid warnings
8251 if GCC considers string literals to be constants.
74f10ca7 8252
022e70d4
PE
8253 * lisp.h (fatal_error_signal): Add decl, since it's exported.
8254
59d6fe83
PE
8255 * dbusbind.c: Pointer signedness fixes.
8256 (xd_signature, xd_append_arg, xd_initialize):
8257 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8258 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8259 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
8260 (Fdbus_register_signal): Use SSDATA when the context wants char *.
8261
78320123
PE
8262 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
8263 if GCC considers string literals to be constants.
49cebcca 8264 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 8265
35ac2a97
SM
82662011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
8267
fb103ca9
SM
8268 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
8269 (print_preprocess, print_object): New macro to fix last change.
8270
35ac2a97
SM
8271 * print.c (print_preprocess): Don't forget font objects.
8272
62973b41
JB
82732011-03-16 Juanma Barranquero <lekktu@gmail.com>
8274
8275 * emacs.c (USAGE3): Doc fixes.
8276
0e48bb22
AS
82772011-03-15 Andreas Schwab <schwab@linux-m68k.org>
8278
8279 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
8280 structure.
8281
7684e57b
JB
82822011-03-14 Juanma Barranquero <lekktu@gmail.com>
8283
8284 * lisp.h (VWindow_system, Qfile_name_history):
8285 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
8286 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
8287 (w32_system_caret_x, w32_system_caret_y): Declare extern.
8288
8289 * w32select.c: Don't #include "keyboard.h".
c96bbc66 8290 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
8291
8292 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
8293 * w32console.c (detect_input_pending, read_input_pending)
8294 (encode_terminal_code):
8295 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
8296 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
8297 (w32_system_caret_y, Qfile_name_history):
8298 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
8299 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
8300 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
8301 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
8302 * w32proc.c (Qlocal, report_file_error):
8303 * w32term.c (Vwindow_system, updating_frame):
8304 * w32uniscribe.c (initialized, uniscribe_font_driver):
8305 Remove unneeded extern declarations.
8306
2aa46d6c
CY
83072011-03-14 Chong Yidong <cyd@stupidchicken.com>
8308
c96bbc66 8309 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 8310
cffc6f3b
CY
83112011-03-13 Chong Yidong <cyd@stupidchicken.com>
8312
8313 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
8314 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
8315 These macros can no longer be used for assignment.
8316
44f230aa
SM
8317 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
8318 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
8319 (record_buffer_markers, fetch_buffer_markers): New functions for
8320 recording and fetching special buffer markers.
8321 (set_buffer_internal_1, set_buffer_temp): Use them.
8322
8323 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
8324
8325 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
8326
8327 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
8328 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
8329
8330 * xdisp.c (hscroll_window_tree):
8331 (reconsider_clip_changes): Use PT instead of BUF_PT.
8332
d251f04b
EZ
83332011-03-13 Eli Zaretskii <eliz@gnu.org>
8334
8335 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
8336 $(EMACS_ROOT)/lib/intprops.h.
8337
f0c77cd1
PE
83382011-03-13 Paul Eggert <eggert@cs.ucla.edu>
8339
3eca4629
PE
8340 Fix more problems found by GCC 4.5.2's static checks.
8341
7c86ee98
PE
8342 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
8343 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
8344 (xg_free_frame_widgets): Make it clear that a local variable is
8345 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
8346 (gdk_window_get_screen): Make it clear that this macro is needed
8347 only if USE_GTK_TOOLTIP.
1e5524e7
PE
8348 (int_gtk_range_get_value): New function, which avoids a diagnostic
8349 from gcc -Wbad-function-cast.
8350 (xg_set_toolkit_scroll_bar_thumb): Use it.
8351 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
8352 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
8353 (get_utf8_string, xg_get_file_with_chooser):
8354 Rename locals to avoid shadowing.
8355 (create_dialog): Move locals to avoid shadowing.
7c86ee98 8356
41729b81
PE
8357 * xgselect.c (xg_select): Remove unused var.
8358
f0c77cd1
PE
8359 * image.c (four_corners_best): Mark locals as initialized.
8360 (gif_load): Initialize transparent_p to zero (Bug#8238).
8361 Mark another local as initialized.
ec6cf4c6 8362 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 8363
ce0ad53d 8364 * image.c (clear_image_cache): Now static.
d5d5a617 8365 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 8366 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
8367 (x_edge_detection): Remove unnecessary cast that
8368 gcc -Wbad-function-cast diagnoses.
2037898d 8369 (gif_load): Fix pointer signedness.
6ae141d6
PE
8370 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
8371 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 8372
33383987 83732011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 8374
d32df629
PE
8375 Improve quality of tests for time stamp overflow.
8376 For example, without this patch (encode-time 0 0 0 1 1
8377 1152921504606846976) returns the obviously-bogus value (-948597
8378 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
8379 reports time overflow. See
8380 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
8381 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
8382 * editfns.c: Include limits.h and intprops.h.
8383 (TIME_T_MIN, TIME_T_MAX): New macros.
8384 (time_overflow): Move earlier, to before first use.
8385 (hi_time, lo_time): New functions, for an accurate test for
8386 out-of-range times.
8387 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
8388 (Fget_internal_run_time): Don't assume time_t fits in int.
8389 (make_time): Use list2 instead of Fcons twice.
8390 (Fdecode_time): More accurate test for out-of-range times.
8391 (check_tm_member): New function.
8392 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
8393 (lisp_time_argument): Don't rely on undefined left-shift and
8394 right-shift behavior when checking for time stamp overflow.
8be6f318 8395
fe31d94c
PE
8396 * editfns.c (time_overflow): New function, refactoring common code.
8397 (Fformat_time_string, Fdecode_time, Fencode_time):
8398 (Fcurrent_time_string): Use it.
8399
8be6f318
PE
8400 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
8401 * dired.c (make_time): Move to ...
8402 * editfns.c (make_time): ... here.
8403 * systime.h: Note the move.
8404
09d9db2c 84052011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 8406
126bc0dc
YM
8407 * fringe.c (update_window_fringes): Remove unused variables.
8408
c47cbdfd
YM
8409 * unexmacosx.c (copy_data_segment): Also copy __got section.
8410 (Bug#8223)
8411
7ac80be9
EZ
84122011-03-12 Eli Zaretskii <eliz@gnu.org>
8413
c96bbc66 8414 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
8415 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
8416 Constify `char *' arguments and their references according to
8417 prototypes in tparam.h.
8418
ecb0f94d 8419 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 8420
7ac80be9
EZ
8421 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
8422 Adapt all references accordingly.
8423
8424 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
8425
ef1fd07e
TT
84262011-03-11 Tom Tromey <tromey@redhat.com>
8427
8428 * buffer.c (syms_of_buffer): Remove obsolete comment.
8429
7ef4b50c
EZ
84302011-03-11 Eli Zaretskii <eliz@gnu.org>
8431
8432 * termhooks.h (encode_terminal_code): Declare prototype.
8433
8434 * msdos.c (encode_terminal_code): Don't declare prototype.
8435
8436 * term.c (encode_terminal_code): Now external again, used by
8437 w32console.c and msdos.c.
8438
44f230aa
SM
8439 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
8440 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 8441
4b1ec863 84422011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 8443
1714f52b 8444 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 8445
4b1ec863
PE
8446 * fringe.c (update_window_fringes): Mark locals as initialized
8447 (Bug#8227).
8448 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 8449
524c7aa6
PE
8450 * alloc.c (mark_fringe_data): Move decl from here ...
8451 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
8452 to check its interface.
8453 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
8454
a5c0af81 8455 * fontset.c (free_realized_fontset): Now static.
7519b8cd 8456 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 8457 (fontset_font): Mark local as initialized.
a9a06e0b 8458 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 8459
b4716021
PE
8460 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
8461
811e9bac 8462 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 8463 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
8464 (x_own_selection, Fx_disown_selection_internal): Rename locals
8465 to avoid shadowing.
8466 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 8467
7e3ab302
PE
8468 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
8469 so that the caller can use some name other than gcpro1.
8470 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
8471 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8472 (Fx_backspace_delete_keys_p):
8473 Use them to avoid shadowing, and rename vars to avoid shadowing.
8474 (x_decode_color, x_set_name, x_window): Now static.
6b437900 8475 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 8476 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
8477 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
8478 Remove unused locals.
7e3ab302
PE
8479 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
8480 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
8481 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
8482 macros.
f78faa98 8483
e2b13473
PE
8484 * xterm.h (x_mouse_leave): New decl.
8485
77f23912
PE
8486 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
8487 Remove unused functions.
cdf4ba58
PE
8488 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
8489 (x_calc_absolute_position): Now static.
7411c686 8490 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 8491 Don't declare local "event" unless it's used.
ed7bf3a5
PE
8492 (x_iconify_frame, x_free_frame_resources): Don't declare locals
8493 unless they are used.
38d0b34a
PE
8494 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
8495 (x_fatal_error_signal): Remove; not used.
a6067996
PE
8496 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
8497 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
8498 (x_error_catcher, x_connection_closed, x_error_handler):
8499 (x_error_quitter, xembed_send_message, x_iconify_frame):
8500 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 8501 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 8502 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 8503
44f230aa
SM
8504 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
8505 Rename or move locals to avoid shadowing.
6b463e58 8506 (tty_defined_color, merge_face_heights): Now static.
5967d051 8507 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
8508 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
8509 does not deduce is never used uninitialized.
73719eba
PE
8510 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
8511 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 8512
426994c3 8513 * terminal.c (store_terminal_param): Now static.
5489860b 8514
032f1620 8515 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 8516 (set_frame_menubar): Remove unused local.
d4323972 8517 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
8518 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
8519 since they might point to immutable storage.
281585b0
PE
8520 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
8521 since it's unused otherwise.
032f1620 8522
367c19e5 8523 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 8524 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
8525 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
8526 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 8527 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
8528 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
8529 does not deduce are never used uninitialized.
70739cbe 8530
07b48fa9
PE
8531 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
8532
8868a238 8533 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
8534 * window.c (window_loop, size_window):
8535 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 8536
7e5cf297 8537 * window.c (display_buffer): Now static.
d6550a9f
PE
8538 (size_window): Mark variables that gcc -Wuninitialized
8539 does not deduce are never used uninitialized.
a586633d
PE
8540 * window.h (check_all_windows): New decl, to forestall
8541 gcc -Wmissing-prototypes diagnostic.
5b555da1 8542 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 8543
f6095868
PE
8544 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
8545 shadowing.
8546 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
8547 Include <limits.h>.
8548 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
8549 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
8550 (load_charset_map): Mark variables that gcc -Wuninitialized
8551 does not deduce are never used uninitialized.
53df7c11 8552 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 8553
f38b440c
PE
8554 * coding.c (coding_set_source, coding_set_destination):
8555 Use "else { /* comment */ }" rather than "else /* comment */;"
8556 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
8557 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
8558 a block, when the outer 'i' will do.
8559 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
8560 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
8561 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
8562 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
8563 (Fdecode_sjis_char, Fdefine_coding_system_internal):
8564 Rename locals to avoid shadowing.
8565 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
8566 * coding.c (emacs_mule_char, encode_invocation_designation):
8567 Now static, since they're not used elsewhere.
413bb2db 8568 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 8569 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
8570 (decode_coding_emacs_mule): Mark variables that gcc
8571 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
8572 (detect_coding_iso_2022): Initialize a local variable that might
8573 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 8574 this initialization is needed. (Bug#8211)
5f58e762
PE
8575 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
8576 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
8577 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
8578 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
8579 Remove unused macros.
f38b440c 8580
232b38b9 8581 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 8582 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 8583 * character.c (string_count_byte8): Likewise.
232b38b9 8584
fb90da1b
PE
8585 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
8586 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
8587
fb93dbc2
PE
8588 * chartab.c (copy_sub_char_table): Now static, since it's not used
8589 elsewhere.
5c156ace
PE
8590 (sub_char_table_ref_and_range, char_table_ref_and_range):
8591 Rename locals to avoid shadowing.
bbcd0949 8592 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 8593
7d3b3862 8594 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 8595 (BIDI_BOB): Remove unused macro.
7d3b3862 8596
6be7d3da
PE
8597 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
8598 deduce are never used uninitialized.
c2ed9c8b 8599 * term.c (encode_terminal_code): Likewise.
6be7d3da 8600
75f8807f 8601 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 8602
50938595
PE
8603 * tparam.h: New file.
8604 * term.c, tparam.h: Include it.
8605 * deps.mk (term.o, tparam.o): Depend on tparam.h.
8606 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
8607 Move these decls to tparam.h, and make them agree with what
8608 is actually in tparam.c. The previous trick of using incompatible
8609 decls in different modules does not conform to the C standard.
8610 All callers of tparam changed to use tparam's actual API.
8611 * tparam.c (tparam1, tparam, tgoto):
8612 Use const pointers where appropriate.
8613
fbceeba2
PE
8614 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
8615 * cm.h (struct cm): Likewise.
8616 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
8617 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
8618 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
8619 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
8620 (turn_on_face, init_tty): Likewise.
8621 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 8622
7f3f1250
PE
8623 * term.c (term_mouse_position): Rename local to avoid shadowing.
8624
e6ca6543
PE
8625 * alloc.c (mark_ttys): Move decl from here ...
8626 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
8627
c40f8d15
AS
86282011-03-11 Andreas Schwab <schwab@linux-m68k.org>
8629
8630 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
8631
cfe0661d
JB
86322011-03-09 Juanma Barranquero <lekktu@gmail.com>
8633
8634 * search.c (compile_pattern_1): Remove argument regp, unused since
8635 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
8636 (compile_pattern): Don't pass it.
8637
0afb4571
J
86382011-03-08 Jan Djärv <jan.h.d@swipnet.se>
8639
8640 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
8641 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
8642 for ! HAVE_GTK3.
8643 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
8644
8645 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
8646
8647 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
8648 gdk_window_get_screen, gdk_window_get_geometry,
8649 gdk_x11_window_lookup_for_display and GDK_KEY_g.
8650 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
8651 (xg_get_pixbuf_from_pixmap): New function.
8652 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
8653 to Pixmap, take frame as parameter, remove GdkColormap parameter.
8654 Call xg_get_pixbuf_from_pixmap instead of
8655 gdk_pixbuf_get_from_drawable.
8656 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
8657 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
8658 (xg_check_special_colors): Use GtkStyleContext and its functions
8659 for HAVE_GTK3.
8660 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
8661 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
8662 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
8663 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
8664 Call gtk_widget_get_preferred_size.
0afb4571
J
8665 (xg_frame_resized): gdk_window_get_geometry only takes 5
8666 parameters.
44f230aa
SM
8667 (xg_win_to_widget, xg_event_is_for_menubar):
8668 Call gdk_x11_window_lookup_for_display.
0afb4571
J
8669 (xg_set_widget_bg): New function.
8670 (delete_cb): New function.
895009e1 8671 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
8672 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
8673 (xg_set_background_color): Call xg_set_widget_bg.
8674 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
8675 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
8676 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
8677 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
8678 if ! HAVE_GTK3.
8679 (update_frame_tool_bar): Call gtk_widget_hide.
8680 (xg_initialize): Use GDK_KEY_g.
8681
8682 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
8683 if ! HAVE_GTK3
8684 (x_session_initialize): Call gdk_x11_set_sm_client_id.
8685
8686 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
8687 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
8688 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
8689
1c2cc4ef
JB
86902011-03-08 Juanma Barranquero <lekktu@gmail.com>
8691
8692 * w32xfns.c (select_palette): Check success of RealizePalette against
8693 GDI_ERROR, not zero.
8694
33383987 8695See ChangeLog.11 for earlier changes.
aac0c6e3
MR
8696
8697;; Local Variables:
8698;; coding: utf-8
aac0c6e3
MR
8699;; End:
8700
33383987 8701 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
8702
8703 This file is part of GNU Emacs.
8704
8705 GNU Emacs is free software: you can redistribute it and/or modify
8706 it under the terms of the GNU General Public License as published by
8707 the Free Software Foundation, either version 3 of the License, or
8708 (at your option) any later version.
8709
8710 GNU Emacs is distributed in the hope that it will be useful,
8711 but WITHOUT ANY WARRANTY; without even the implied warranty of
8712 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
8713 GNU General Public License for more details.
8714
8715 You should have received a copy of the GNU General Public License
8716 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.