NEWS fixes: positioning, copyedits
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0fb52f11
JB
12012-06-16 Juanma Barranquero <lekktu@gmail.com>
2
3 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
4 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
5 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
6 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
7 ($(BLD)/w32select.$(O)): Update dependencies.
8
e5560ff7
AS
92012-06-16 Andreas Schwab <schwab@linux-m68k.org>
10
11 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
12 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
13 * character.c (_fetch_multibyte_char_p): Remove.
14 * alloc.c: Include "character.h" before "buffer.h".
15 * bidi.c: Likewise.
16 * buffer.c: Likewise.
17 * bytecode.c: Likewise.
18 * callint.c: Likewise.
19 * callproc.c: Likewise.
20 * casefiddle.c: Likewise.
21 * casetab.c: Likewise.
22 * category.c: Likewise.
23 * cmds.c: Likewise.
24 * coding.c: Likewise.
25 * composite.c: Likewise.
26 * dired.c: Likewise.
27 * dispnew.c: Likewise.
28 * doc.c: Likewise.
29 * dosfns.c: Likewise.
30 * editfns.c: Likewise.
31 * emacs.c: Likewise.
32 * fileio.c: Likewise.
33 * filelock.c: Likewise.
34 * font.c: Likewise.
35 * fontset.c: Likewise.
36 * fringe.c: Likewise.
37 * indent.c: Likewise.
38 * insdel.c: Likewise.
39 * intervals.c: Likewise.
40 * keyboard.c: Likewise.
41 * keymap.c: Likewise.
42 * lread.c: Likewise.
43 * macros.c: Likewise.
44 * marker.c: Likewise.
45 * minibuf.c: Likewise.
46 * nsfns.m: Likewise.
47 * nsmenu.m: Likewise.
48 * print.c: Likewise.
49 * process.c: Likewise.
50 * regex.c: Likewise.
51 * region-cache.c: Likewise.
52 * search.c: Likewise.
53 * syntax.c: Likewise.
54 * term.c: Likewise.
55 * textprop.c: Likewise.
56 * undo.c: Likewise.
57 * unexsol.c: Likewise.
58 * w16select.c: Likewise.
59 * w32fns.c: Likewise.
60 * w32menu.c: Likewise.
61 * window.c: Likewise.
62 * xdisp.c: Likewise.
63 * xfns.c: Likewise.
64 * xmenu.c: Likewise.
65 * xml.c: Likewise.
66 * xselect.c: Likewise.
67
2f07e6af
EZ
682012-06-16 Eli Zaretskii <eliz@gnu.org>
69
70 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end. If
71 all the glyphs of the glyph row came from strings, and we have no
72 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
73 row.
74 (handle_face_prop): Use chunk-relative overlay string index when
75 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
76 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
77 the rightmost. (Bug#11720)
2f07e6af 78
29b83cec
AS
792012-06-16 Andreas Schwab <schwab@linux-m68k.org>
80
81 * category.h (CHAR_HAS_CATEGORY): Define as inline.
82 (CATEGORY_MEMBER): Enforce 1/0 value.
83 * category.c (_temp_category_set): Remove.
84
4c5501e9
EZ
852012-06-16 Eli Zaretskii <eliz@gnu.org>
86
87 * window.c (Fdelete_other_windows_internal)
88 (Fdelete_window_internal): Don't access frame's mouse highlight
89 info of the initial frame. (Bug#11677)
90
2b570124
PE
912012-06-14 Paul Eggert <eggert@cs.ucla.edu>
92
e93864f9
PE
93 * .gdbinit (xgetint): Fix recently-introduced paren typo.
94 Assume USE_2_TAGS_FOR_INTS.
95 (xreload): Adjust $tagmask width to match recent lisp.h change.
96
2b570124
PE
97 Simplify lisp.h in minor ways that should not affect code.
98 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
99 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
100 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
101 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
102 (INTTYPEBITS): New macro, for clarity.
103 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
104 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P): Simplify
105 now that USE_LSB_TAG is always defined.
106 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
107 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
108
81755f69
JB
1092012-06-13 Juanma Barranquero <lekktu@gmail.com>
110
111 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
112
16192a57
GM
1132012-06-13 Glenn Morris <rgm@gnu.org>
114
115 * s/bsd-common.h (BSD4_3):
116 * s/usg5-4-common.h (USG5_4): No longer define; unused.
117
646b5f55
AS
1182012-06-13 Andreas Schwab <schwab@linux-m68k.org>
119
120 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
121 instead of union.
122 (XLI, XIL): Define.
123 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG): Use
124 them.
125 * emacs.c (gdb_use_struct): Renamed from gdb_use_union.
126 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
127 * alloc.c (widen_to_Lisp_Object): Removed.
128 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
129 * frame.c (delete_frame): Remove outdated comment.
130 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
131 USE_LISP_UNION_TYPE.
132 (Fw32_unregister_hot_key): Likewise.
133 (Fw32_toggle_lock_key): Likewise.
134 * w32menu.c (add_menu_item): Likewise.
135 (w32_menu_display_help): Use XIL instead of checking
136 USE_LISP_UNION_TYPE.
137 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
138 (init_heap): Likewise.
139 * w32term.c (w32_read_socket): Update comment.
140
1d3823c9
GM
1412012-06-13 Glenn Morris <rgm@gnu.org>
142
c62ff706
GM
143 * s/usg5-4-common.h, src/s/unixware.h:
144 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
145
1d3823c9
GM
146 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
147
bfe3e0a2
PE
1482012-06-13 Paul Eggert <eggert@cs.ucla.edu>
149
150 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
151 * alloc.c (make_number) [!defined make_number]:
152 Remove, as lisp.h always defines this now.
153 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
154 (roundup_size): Verify that it is a power of 2.
155 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
156 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
157 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
158 -DUSE_LSB_TAG=0, to override the automatically-selected default.
159 USE_LSB_TAG now is always defined to be either 0 or 1.
160 All uses changed.
161 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
162 code works fine either way, and efficiency is not a concern here,
163 as the union type is for debugging, not for production.
164 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
165 Use an inline function on all platforms when using the union type,
166 since this is simpler and 'static inline' can be used portably
167 within Emacs now.
168 (LISP_INITIALLY_ZERO): New macro.
169 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
170 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
171
45fa9c0f
GM
1722012-06-12 Glenn Morris <rgm@gnu.org>
173
b4492cba
GM
174 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
175
176 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 177
45fa9c0f
GM
178 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
179 Move BROKEN_SIGIO to configure.
180
181 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
182 Move NO_TERMIO to configure.
183
0e25d334
CY
1842012-06-12 Chong Yidong <cyd@gnu.org>
185
186 * image.c (imagemagick_load_image): Use MagickFlattenImage if
187 MagickMergeImageLayers is undefined. Use pixel pusher loop if
188 MagickExportImagePixels is undefined.
189
43682bb6
PE
1902012-06-12 Paul Eggert <eggert@cs.ucla.edu>
191
192 * image.c (imagemagick_load_image): Remove unused label.
193
a9be7d2b
GM
1942012-06-11 Glenn Morris <rgm@gnu.org>
195
196 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
197 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
198 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
199 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
200
3017f87f
SM
2012012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
202
203 * alloc.c (make_byte_code): New function.
204 (Fmake_byte_code): Use it. Don't purify here.
205 * lread.c (read1): Use it as well to avoid extra allocation.
206
1b9b4cf4
CY
2072012-06-11 Chong Yidong <cyd@gnu.org>
208
209 * image.c (imagemagick_load_image): Implement transparency.
210
95988fcf
AS
2112012-06-10 Andreas Schwab <schwab@linux-m68k.org>
212
213 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
214 account for preceding backslashes. (Bug#11663)
215
cd4eb164
CY
2162012-06-09 Chong Yidong <cyd@gnu.org>
217
218 * term.c: Support italics in capable terminals (Bug#9652).
219 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
220 (turn_on_face): Output using TS_enter_italic_mode if available.
221 Don't handle unused blinking and alt-charset cases.
222 (turn_off_face): Handle italic case; discard unused tty_blinking_p
223 and tty_alt_charset_p cases.
224 (tty_capable_p, init_tty): Support italics.
225
226 * termchar.h (struct tty_display_info): Add field for italics.
227 Remove unused blink field.
228
229 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
230 Handle slant.
231
232 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
233 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
234 tty_alt_charset_p. Add tty_italic_p.
235
ff88beb8
MA
2362012-06-09 Michael Albinus <michael.albinus@gmx.de>
237
238 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
239 dbus_type_is_basic if available.
240 (xd_extract_signed, xd_extract_unsigned): Rename from
241 extract_signed and extract_unsigned, respectively. Adapt callers.
242
44286096
CY
2432012-06-09 Chong Yidong <cyd@gnu.org>
244
1682701f
CY
245 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
246
44286096
CY
247 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
248 case (Bug#9752).
249
d86feb17
PE
2502012-06-08 Paul Eggert <eggert@cs.ucla.edu>
251
252 * xdisp.c (vmessage): Treat frame message as multibyte.
253 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
254 would generate the diagnostic "Making \302\247 buffer-local while
255 let-bound!".
256
d5c20fe8
EZ
2572012-06-08 Eli Zaretskii <eliz@gnu.org>
258
259 * dispnew.c (showing_window_margins_p): Undo last change, which
260 was done due to an inadvertent commit.
261 (adjust_frame_glyphs_for_frame_redisplay): Do call
262 showing_window_margins_p.
263
513749ee
SM
2642012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
265
266 * eval.c (Fmake_var_non_special): New primitive.
267 (syms_of_eval): Defsubr it.
268 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
269
d4a8f5c1
JB
2702012-06-08 Juanma Barranquero <lekktu@gmail.com>
271
272 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
273 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
274
8bbbc977
EZ
2752012-06-08 Eli Zaretskii <eliz@gnu.org>
276
277 * alloc.c (allocate_vectorlike): Fix last change.
278
f3372c87
DA
2792012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
280
281 Block-based vector allocation of small vectors.
282 * lisp.h (struct vectorlike_header): New field `nbytes',
283 adjust comment accordingly.
284 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
285 to denote vector blocks. Adjust users (live_vector_p,
286 mark_maybe_pointer, valid_lisp_object_p) accordingly.
287 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
288 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
289 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
290 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
291 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
292 (roundup_size): New constant.
293 (struct vector_block): New data type.
294 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 295 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
296 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
297 (sweep_vectors): New functions.
298 (allocate_vectorlike): Return `zero_vector' as the only vector of
299 0 items. Allocate new vector from block if vector size is less than
300 or equal to VBLOCK_BYTES_MAX.
301 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
302 (init_alloc_once): Add call to init_vectors.
303
4f18a4ed
SM
3042012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
305
306 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
307
86f158bc
PE
3082012-06-07 Paul Eggert <eggert@cs.ucla.edu>
309
310 * doprnt.c (doprnt): Truncate multibyte char correctly.
311 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
312 would mishandle a string argument "Xc" if X was a multibyte
313 character of length 2: it would truncate after X's first byte
314 rather than including all of X.
315
c5cfcbe0
CY
3162012-06-06 Chong Yidong <cyd@gnu.org>
317
318 * buffer.c (word_wrap): Doc fix.
319
c05cf390
PE
3202012-06-04 Paul Eggert <eggert@cs.ucla.edu>
321
322 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
323
0c3461de
GM
3242012-06-03 Glenn Morris <rgm@gnu.org>
325
326 * xdisp.c (tool-bar-style): Doc fix.
327
c71232db
UM
3282012-06-03 Ulrich Müller <ulm@gentoo.org>
329
330 * Makefile.in (PAXCTL): Define.
331 (temacs$(EXEEXT)): Disable memory randomization for the temacs
332 binary via PaX flags if the paxctl utility is available.
333 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
334 Restore PaX flags to their default. (Bug#11398)
335
383f7350
CY
3362012-06-03 Chong Yidong <cyd@gnu.org>
337
338 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
339 buffer (Bug#11226).
340
5f2c76c6
CY
3412012-06-03 Chong Yidong <cyd@gnu.org>
342
343 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
344 (note_mode_line_or_margin_highlight): If there is no help echo,
345 use mode-line-default-help-echo. Handle the case where the mouse
346 position is past the end of the mode line string.
347
348 * buffer.c (buffer_local_value_1): New function, split from
349 Fbuffer_local_value; can return Qunbound.
350 (Fbuffer_local_value): Use it.
351 (Vmode_line_format): Docstring tweaks.
352
773d47f6
PE
3532012-06-02 Paul Eggert <eggert@cs.ucla.edu>
354
355 * sysdep.c (system_process_attributes): Improve comment.
356
f2d6a3df
SM
3572012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
358
359 * keyboard.c: Export real-this-command to Elisp.
360 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
361 and DEFVAR it. Update all users.
362
63810350
PE
3632012-06-02 Paul Eggert <eggert@cs.ucla.edu>
364
7bd5c1f4
PE
365 * minibuf.c (Fassoc_string): Remove duplicate declaration.
366
63810350
PE
367 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
368 Convert pctcpu and pctmem to Lisp float properly.
369 Let the compiler fold better, as 100.0/0x8000 is exact.
370
a2821611
AS
3712012-06-02 Andreas Schwab <schwab@linux-m68k.org>
372
373 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
374 cons_block.
375
5fceba1d
PE
3762012-06-01 Paul Eggert <eggert@cs.ucla.edu>
377
378 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
379
c98ff5dd
DA
3802012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
381
382 For a 'struct window', replace some Lisp_Object fields to
383 bitfields where appropriate, remove unused fields.
384 * window.h (struct window): Remove unused 'last_mark_x' and
385 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
386 change it's type from Lisp_Object to bitfield.
387 Change type of 'force_start', 'optional_new_start',
388 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
389 fields from Lisp_Object to bitfield. Adjust users accordingly.
390
ca34e0be
PE
3912012-05-31 Paul Eggert <eggert@cs.ucla.edu>
392
393 Pacify gcc -Wdouble-precision when using Xaw.
394 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
395 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
396 Use 'float' consistently, rather than 'float' in most places
397 and 'double' in a couple of places.
398
efc00ab1 3992012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
400
401 * xdisp.c (handle_stop): Detect whether we have overlay strings
402 loaded by testing it->current.overlay_string_index to be
403 non-negative, instead of checking whether n_overlay_strings is
404 positive. (Bug#11587)
405
efc00ab1 4062012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
407
408 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
409
410 * doc.c (Fsubstitute_command_keys): Doc fix.
411
efc00ab1 4122012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
413
414 * search.c (search_buffer): Remove calls to
415 r_alloc_inhibit_buffer_relocation, as it is now called by
416 maybe_unify_char, which was the cause of relocation of buffer text
417 in bug#11519.
418
efc00ab1 4192012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
420
421 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
422 for the duration of call to load_charset, to avoid problems with
423 callers of maybe_unify_char that access buffer text through C
424 pointers.
425
426 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
427 decrement the inhibition flag, instead of just setting or
428 resetting it.
429
ba93a187
PE
4302012-05-31 Paul Eggert <eggert@cs.ucla.edu>
431
432 Remove obsolete '#define static' cruft.
433 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
434 This #undef was "temporary" in 2000; it is no longer needed
435 now that '#define static' has gone away.
436 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
437 (gray_bitmap_bits): Remove; no longer needed.
438 All uses replaced with definiens.
439 * xterm.c: Include "bitmaps/gray.xbm".
440
9e4bf381
PE
4412012-05-30 Paul Eggert <eggert@cs.ucla.edu>
442
443 Clean up __executable_start, monstartup when --enable-profiling.
444 The following changes affect the code only when profiling.
445 * dispnew.c (__executable_start): Rename from safe_bcopy.
446 Define only on platforms that need it.
447 * emacs.c: Include <sys/gmon.h> when profiling.
448 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
449 (__executable_start): Remove decl, since lisp.h does it now.
450 (safe_bcopy): Remove decl; no longer has that name.
451 (main): Coalesce #if into single bit of code, for simplicity.
452 Cast pointers to uintptr_t, since standard libraries want integers
453 and not pointers.
454 * lisp.h (__executable_start): New decl.
455
32d72c2f
GM
4562012-05-31 Glenn Morris <rgm@gnu.org>
457
458 * image.c (Fimagemagick_types): Doc fix.
459
baac5bc7
JM
4602012-05-30 Jim Meyering <meyering@redhat.com>
461
462 * callproc.c (Fcall_process_region): Include directory component
463 in mkstemp error message (Bug#11586).
464
72cb32cf
PE
4652012-05-30 Paul Eggert <eggert@cs.ucla.edu>
466
467 * alloc.c, lisp.h (make_pure_vector): Now static.
468
61b108cc
SM
4692012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
470
471 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
472 Move to byte-run.el.
473 (Fautoload): Do the hash-doc more carefully.
474 * data.c (Fdefalias): Purify definition, except for keymaps.
475 (Qdefun): Move from eval.c.
476 * lisp.h (Qdefun): Remove.
477 * lread.c (read1): Tiny simplification.
478
471fe23d
TN
4792012-05-29 Troels Nielsen <bn.troels@gmail.com>
480
934f3f58 481 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
482 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
483 Bug#9642, but explicitly check that the buffer the overlay would
484 be moved to is live and rearrange lines to make sure that errors
485 will not put the overlay in an inconsistent state.
486 (Fdelete_overlay): Cosmetics.
487
85d0efd1
EZ
4882012-05-28 Eli Zaretskii <eliz@gnu.org>
489
490 * w32term.c (my_bring_window_to_top): New function.
491 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
492 could be different from the original one.
493 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
494 (Bug#11513)
495
496 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
497 by calling BringWindowToTop.
498
499 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
500 (WM_EMACS_END): Increase by one.
501
da92a98c
PE
5022012-05-28 Paul Eggert <eggert@cs.ucla.edu>
503
504 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
505 This avoids undefined behavior that might cause the eassert
506 to not catch an out-of-range value.
507
74d1f848
JB
5082012-05-28 Juanma Barranquero <lekktu@gmail.com>
509
510 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
511 Update dependencies.
512
9e1a06fc
EZ
5132012-05-27 Eli Zaretskii <eliz@gnu.org>
514
515 * bidi.c (bidi_mirror_char): Fix last change.
516
f3dd7312
AS
5172012-05-27 Andreas Schwab <schwab@linux-m68k.org>
518
519 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
520 when referring to sectname field in printf format.
521
81899c91
PE
5222012-05-27 Paul Eggert <eggert@cs.ucla.edu>
523
57b81a9f
PE
524 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
525 Only r_alloc_inhibit_buffer_relocation needed to be added;
526 the others were already declared.
527
81899c91
PE
528 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
529 before checking whether it's out of range. Put the check inside
530 eassert. See
531 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
532
33017faf 5332012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
534
535 * callproc.c (Fcall_process): Restore a line that was accidentally
536 commented out in the 2011-02-13 change (bug#11547).
537
33017faf 5382012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
539
540 * lisp.h [REL_ALLOC]: Add prototypes for external functions
541 defined on ralloc.c.
542
543 * buffer.c [REL_ALLOC]: Remove prototypes of
544 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
545 they are now on lisp.h.
546
547 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
548
549 * search.c (search_buffer): Use it to inhibit relocation of buffer
550 text while re_search_2 is doing its job, because re_search_2 is
551 passed C pointers to buffer text. (Bug#11519)
552
23415acf
EZ
553 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
554 Update value to 24.
555
44e27368
EZ
556 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
557 state after an additional call to move_it_in_display_line_to, keep
558 the values of it->max_ascent and it->max_descent found for the
559 entire line.
560 (pos_visible_p): Revert the comparison against bottom_y to what it
561 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
562 (Bug#11464)
563
c1892f11
PE
5642012-05-26 Paul Eggert <eggert@cs.ucla.edu>
565
566 Fix coding-related core dumps with gcc -ftrapv.
567 The code was computing A - B, where A and B are pointers, and B is
568 random garbage. This can lead to core dumps on platforms that
569 have special pointer registers, and it also leads to core dumps on
570 x86-64 when compiled with gcc -ftrapv. The fix is to compute
571 A - B only when B is initialized properly.
572 * coding.c (coding_set_source, coding_set_destination): Return void.
573 (coding_change_source, coding_change_destinations): New functions,
574 with the old behaviors of coding_set_source and coding_set_destination.
575 All callers that need an offset changed to use these new functions.
576
eb7afdad
GM
5772012-05-26 Glenn Morris <rgm@gnu.org>
578
579 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
580
f12fdf02
EZ
5812012-05-26 Eli Zaretskii <eliz@gnu.org>
582
53a63be6 583 Extend mouse support on W32 text-mode console.
61b108cc
SM
584 * xdisp.c (draw_row_with_mouse_face):
585 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 586
eb3f6f01 587 * w32console.c: Include window.h.
61b108cc
SM
588 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
589 New functions.
eb3f6f01
EZ
590 (initialize_w32_display): Initialize mouse-highlight data.
591
53a63be6
EZ
592 * w32inevt.c: Include termchar.h and window.h.
593 (do_mouse_event): Support mouse-autoselect-window. When the mouse
594 moves, call note_mouse_highlight. If help_echo changed, call
595 gen_help_event to produce help-echo message in the echo area.
596 Call clear_mouse_face if mouse_face_hidden is set in the mouse
597 highlight info.
598
4cfd81f6
PE
5992012-05-26 Paul Eggert <eggert@cs.ucla.edu>
600
601 * lread.c (read1): Simplify slightly to avoid an overflow warning
602 with GCC 4.7.0 on x86-64.
603
4446092a
EZ
6042012-05-26 Eli Zaretskii <eliz@gnu.org>
605
606 * bidi.c (bidi_mirror_char): Revert last change: an int is
607 definitely wide enough here.
608
42b2a986 6092012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 610
42b2a986 611 Fix integer width and related bugs (Bug#9874).
eb106a49 612 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
613 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
614 (string_bytes, check_sblock, allocate_string_data):
615 (compact_small_strings, Fmake_bool_vector, make_string)
616 (make_unibyte_string, make_multibyte_string)
617 (make_string_from_bytes, make_specified_string)
618 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
619 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
620 (mark_vectorlike):
621 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
622 (allocate_pseudovector):
623 Use int, not EMACS_INT, where int is wide enough.
624 (inhibit_garbage_collection, Fgarbage_collect):
625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
626 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
627 int might not be wide enough.
628 (bidi_cache_search, bidi_cache_find, bidi_init_it)
629 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
630 (bidi_at_paragraph_end, bidi_find_paragraph_start)
631 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
632 (bidi_level_of_next_char, bidi_move_to_visually_next):
633 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
634 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
635 (Fkill_buffer, Fset_buffer_major_mode)
636 (advance_to_char_boundary, Fbuffer_swap_text)
637 (Fset_buffer_multibyte, overlays_at, overlays_in)
638 (overlay_touches_p, struct sortvec, record_overlay_string)
639 (overlay_strings, recenter_overlay_lists)
640 (adjust_overlays_for_insert, adjust_overlays_for_delete)
641 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
642 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
643 (Foverlay_recenter, last_overlay_modification_hooks_used)
644 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
645 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
646 (validate_region): Omit unnecessary test for b <= e,
647 since that's guaranteed by the previous test.
d311d28c
PE
648 (adjust_overlays_for_delete): Avoid pos + length overflow.
649 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
650 (report_overlay_modification):
651 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
652 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
653 Omit pointer cast, which isn't needed anyway, and doesn't work
654 after the EMACS_INT -> ptrdiff_t change.
02481186 655 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
656 * buffer.h: Adjust decls to match defn changes elsewhere.
657 (struct buffer_text, struct buffer):
658 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
659 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
660 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
661 not int, to avoid needless 32-bit limit on 64-bit hosts.
662 (exec_byte_code): Use tighter memory-full test, one that checks
663 for alloca overflow. Don't compute the address of the object just
664 before an array, as that's not portable. Use EMACS_INT, not
665 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
666 * callint.c (Fcall_interactively):
667 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
668 * callproc.c (call_process_kill, Fcall_process):
669 Don't assume pid_t fits into an Emacs fixnum.
670 (call_process_cleanup, Fcall_process, child_setup):
671 Don't assume pid_t fits into int.
672 (call_process_cleanup, Fcall_process, delete_temp_file)
673 (Fcall_process_region):
674 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
675 (Fcall_process): Simplify handling of volatile integers.
676 Use int, not EMACS_INT, where int will do.
677 * casefiddle.c (casify_object, casify_region, operate_on_word)
678 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
679 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
680 (casify_object): Avoid integer overflow when overallocating buffer.
681 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 682 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
683 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
684 * category.h (CATEGORYP): Don't assume arg is nonnegative.
685 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
686 integers are now checked earlier. All uses replaced with XINT.
687 (ccl_driver):
688 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
689 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
690 (ccl_driver, Fregister_code_conversion_map):
691 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
692 (resolve_symbol_ccl_program): Check that vector header is in range.
693 Always copy the vector, so that we can check its contents reliably
694 now rather than having to recheck each instruction as it's being
695 executed. Check that vector words fit in 'int'.
696 (ccl_get_compiled_code, Fregister_ccl_program)
697 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
698 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
699 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
700 contents are in range.
701 (Fccl_execute_on_string): Check that status is in range.
702 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
703 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
704 Accept and return EMACS_INT, not int, because callers can pass values
705 out of 'int' range.
706 (c_string_width, strwidth, lisp_string_width, chars_in_text)
707 (multibyte_chars_in_text, parse_str_as_multibyte)
708 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
709 (str_as_unibyte, str_to_unibyte, string_count_byte8)
710 (string_escape_byte8, Fget_byte):
711 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 712 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
713 avoid mishandling large integers.
714 * character.h: Adjust decls to match defn changes elsewhere.
715 * charset.c (load_charset_map_from_file, find_charsets_in_text)
716 (Ffind_charset_region):
717 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
718 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
719 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 720 Don't assume fixnum fits in int.
d311d28c
PE
721 (load_charset_map_from_vector, Fmap_charset_chars):
722 Remove now-unnecessary CHECK_NATNUMs.
723 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
724 Don't rely on undefined behavior with signed left shift overflow.
725 Don't assume unsigned int fits into fixnum, or that fixnum fits
726 into unsigned int. Don't require max_code to be a valid fixnum;
727 that's not true for gb10830 4-byte on a 32-bit host. Allow
728 invalid_code to be a cons, for the same reason. Require code_offset
729 to be a character. Avoid int overflow if max_char is close
730 to INT_MAX.
731 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
732 this is intended anyway and avoids some undefined behavior.
733 (load_charset_map): Pass unsigned, not int, as 2nd arg of
734 INDEX_TO_CODE_POINT, as that's what it expects.
735 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
736 * charset.h (DECODE_CHAR): Return int, not unsigned;
737 this is what was intended anyway, and it avoids undefined behavior.
738 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
739 integer-overflow issues.
740 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
741 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
742 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
743 * chartab.c (Fmake_char_table, Fset_char_table_range)
744 (uniprop_get_decoder, uniprop_get_encoder):
745 Don't assume fixnum fits in int.
746 * cmds.c (move_point): New function, that does the gist of
747 Fforward_char and Fbackward_char, but does so while checking
748 for integer overflow more accurately.
c96e5d6a 749 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
750 (Fforward_line, Fend_of_line, internal_self_insert)
751 (internal_self_insert):
752 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
753 Fix a FIXME, by checking for integer overflow when calculating
754 target_clm and actual_clm.
755 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 756 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
757 (ASSURE_DESTINATION, coding_alloc_by_realloc)
758 (coding_alloc_by_making_gap, alloc_destination)
759 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
760 (encode_coding_utf_16, detect_coding_emacs_mule)
761 (decode_coding_emacs_mule, encode_coding_emacs_mule)
762 (detect_coding_iso_2022, decode_coding_iso_2022)
763 (encode_invocation_designation, encode_designation_at_bol)
764 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
765 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
766 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
767 (encode_coding_ccl, encode_coding_raw_text)
768 (detect_coding_charset, decode_coding_charset)
769 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
770 (produce_composition, produce_charset, produce_annotation)
771 (decode_coding, handle_composition_annotation)
772 (handle_charset_annotation, consume_chars, decode_coding_gap)
773 (decode_coding_object, encode_coding_object, detect_coding_system)
774 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
775 (code_convert_region, code_convert_string)
8f50130c
PE
776 (Fdefine_coding_system_internal)
777 (coding_set_source, coding_set_destination):
d311d28c
PE
778 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
779 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
780 (Fdefine_coding_system_internal):
781 Don't assume fixnums fit in int.
782 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 783 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
784 (Funencodable_char_position, Fcheck_coding_systems_region)
785 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 786 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 787 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 788 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 789 Don't access memory outside of the args array.
d311d28c 790 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
791 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
792 result of ENCODE_CHAR.
d311d28c
PE
793 * coding.h: Adjust decls to match defn changes elsewhere.
794 (struct coding_system):
795 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
796 * composite.c (get_composition_id, find_composition)
797 (run_composition_function, update_compositions)
798 (compose_text, composition_gstring_put_cache)
799 (composition_gstring_p, composition_gstring_width)
800 (fill_gstring_header, fill_gstring_body, autocmp_chars)
801 (composition_compute_stop_pos, composition_reseat_it)
802 (composition_update_it, struct position_record)
803 (find_automatic_composition, composition_adjust_point)
804 (Fcomposition_get_gstring, Ffind_composition_internal):
805 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
806 (update_compositions):
807 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
808 * composite.h: Adjust decls to match defn changes elsewhere.
809 (struct composition):
810 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
811 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
812 Do not attempt to compute the address of the object just before a
813 buffer; this is not portable.
814 (Faref, Faset):
815 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
816 (Faset): Use int, not EMACS_INT, where int is wide enough.
817 (Fstring_to_number): Don't assume fixnums fit in int.
818 (Frem): Don't assume arg is nonnegative.
819 * dbusbind.c (xd_append_arg): Check for integers out of range.
820 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 821 (extract_signed, extract_unsigned): New functions.
243e0530
PE
822 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
823 (xd_get_connection_references): Return ptrdiff_t, not int.
824 All uses changed.
825 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
826 (xd_read_message_1):
827 Use int, not unsigned, where the dbus API uses int.
828 (Fdbus_message_internal): Don't overflow mtype.
829 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
830 * dired.c (directory_files_internal, file_name_completion, scmp)
831 (file_name_completion_stat):
832 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
833 (file_name_completion): Don't overflow matchcount.
834 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
835 * dispextern.h: Adjust decls to match defn changes elsewhere.
836 (struct text_pos, struct glyph, struct bidi_saved_info)
837 (struct bidi_string_data, struct bidi_it, struct composition_it)
838 (struct it):
839 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
840 (struct display_pos, struct composition_it, struct it):
841 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
842 * dispnew.c (increment_matrix_positions)
843 (increment_row_positions, mode_line_string)
844 (marginal_area_string):
845 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 846 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
847 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
848 (duration_to_sec_usec): New function, to check for overflow better.
849 (Fsleep_for, sit_for): Use it.
850 * doc.c (get_doc_string, store_function_docstring):
851 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
852 (get_doc_string, Fsnarf_documentation):
853 Use int, not EMACS_INT, where int is wide enough.
854 (get_doc_string):
855 Use SAFE_ALLOCA, not alloca.
856 Check for overflow when converting EMACS_INT to off_t.
857 * doprnt.c (doprnt):
858 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
859 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
860 Don't assume uid_t fits into fixnum.
861 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
862 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
863 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
864 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
865 (general_insert_function)
866 (Finsert_char, make_buffer_string, make_buffer_string_both)
867 (update_buffer_properties, Fbuffer_substring)
868 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
869 (Fsubst_char_in_region, check_translation)
870 (Ftranslate_region_internal, save_restriction_restore, Fformat)
871 (transpose_markers, Ftranspose_regions):
872 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
873 (clip_to_bounds): Move to lisp.h as an inline function).
874 (Fconstrain_to_field): Don't assume integers are nonnegative.
875 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
876 (Fsubst_char_in_region, Fsave_restriction):
877 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
878 (Femacs_pid): Don't assume pid_t fits into fixnum.
879 (lo_time): Use int, not EMACS_INT, when int suffices.
880 (lisp_time_argument): Check for usec out of range.
881 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
882 (Fuser_login_name, Fuser_full_name): Signal an error
883 if a uid argument is out of range, rather than relying on
884 undefined behavior.
c8d5c857
PE
885 (Fformat_time_string): Remove now-unnecessary check.
886 lisp_time_argument checks for out-of-range usec now.
243e0530 887 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
888 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
889 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
890 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
891 (init_cmdargs, Fdump_emacs):
892 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
893 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
894 the bottom (typically) 32 bits of the fixnum.
895 * eval.c (specpdl_size, call_debugger):
896 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
897 (when_entered_debugger, Fbacktrace_debug):
898 Don't assume fixnum can fit in int.
899 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
900 the object just before a buffer; this is not portable.
901 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
902 (grow_specpdl, unbind_to):
903 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
904 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
905 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 906 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
907 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
908 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
909 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
910 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
911 (a_write, e_write):
912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
913 (Fcopy_file, non_regular_nbytes, read_non_regular)
914 (Finsert_file_contents):
915 Use int, not EMACS_INT, where int is wide enough.
916 (READ_BUF_SIZE): Verify that it fits in int.
917 (Finsert_file_contents): Check that counts are in proper range,
918 rather than assuming fixnums fit into ptrdiff_t etc.
919 Don't assume fixnums fit into int.
125b3835 920 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
921 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
922 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
923 (string_char_to_byte, string_byte_to_char)
924 (string_make_multibyte, string_to_multibyte)
925 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
926 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
927 (substring_both, Fdelete, internal_equal, Ffillarray)
928 (Fclear_string, mapcar1)
929 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
930 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
931 (larger_vector, make_hash_table, maybe_resize_hash_table)
932 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
933 (Fmaphash, secure_hash):
934 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
935 (concat): Check for string index and length overflow.
936 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
937 (Frequire):
938 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
939 (larger_vector): New API (vec, incr_min, size_max) replaces old
940 one (vec, new_size, init). This catches size overflow.
941 INIT was removed because it was always Qnil.
942 All callers changed.
943 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
944 the upper bound on a hash table index size.
945 (make_hash_table, maybe_resize_hash_table): Use it.
946 (secure_hash): Computer start_byte and end_byte only after
947 they're known to be in ptrdiff_t range.
948 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
949 (Ffont_get_glyphs, Ffont_at):
950 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
951 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
952 (Flist_fonts, Fopen_font):
953 Don't assume fixnum can fit in int.
954 (check_gstring): Don't assume index can fit in int.
955 (font_match_p): Check that fixnum is a character, not a nonnegative
956 fixnum, since the later code needs to stuff it into an int.
957 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
958 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
959 conversion overflow issues.
960 (Fopen_font): Check for integer out of range.
961 (Ffont_get_glyphs): Don't assume index can fit in int.
962 * font.h: Adjust decls to match defn changes elsewhere.
963 * fontset.c (reorder_font_vector): Redo score calculation to avoid
964 integer overflow.
965 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
966 printmax_t, where ptrdiff_t is wide enough.
967 (Finternal_char_font):
968 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
969 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
970 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
971 (Fset_frame_position, x_set_frame_parameters)
972 (x_set_line_spacing, x_set_border_width)
973 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
974 Check that fixnums are in proper range for system types.
975 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
976 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
978 Use SAFE_ALLOCA_LISP, not alloca.
979 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
980 intptr_t is wide enough.
981 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
982 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
983 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
984 Check for fixnum out of range.
985 * ftfont.c (ftfont_list): Don't assume index fits in int.
986 Check that fixnums are in proper range for system types.
987 (ftfont_shape_by_flt):
988 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
989 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
990 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
991 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
992 Check that fixnums are in proper range for system types.
993 * gnutls.h: Adjust decls to match defn changes elsewhere.
994 * gtkutil.c (xg_dialog_run):
995 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
996 (update_frame_tool_bar):
997 Check that fixnums are in proper range for system types.
998 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 999 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
1000 * indent.c (last_known_column, last_known_column_point):
1001 (current_column_bol_cache):
1002 (skip_invisible, current_column, check_display_width):
1003 (check_display_width, scan_for_column, current_column_1)
1004 (Findent_to, Fcurrent_indentation, position_indentation)
1005 (indented_beyond_p, Fmove_to_column, compute_motion):
1006 (Fcompute_motion, Fvertical_motion):
1007 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1008 (last_known_column_modified): Use EMACS_INT, not int.
1009 (check_display_width):
1010 (Fcompute_motion):
1011 Check that fixnums and floats are in proper range for system types.
1012 (compute_motion): Don't assume index or fixnum fits in int.
1013 (compute_motion, Fcompute_motion):
1014 Use int, not EMACS_INT, when it is wide enough.
1015 (vmotion): Omit local var start_hpos that is always 0; that way
1016 we don't need to worry about overflow in expressions involving it.
1017 * indent.h: Adjust decls to match defn changes elsewhere.
1018 (struct position):
1019 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1020 Use int, not EMACS_INT, where int is wide enough.
1021 Remove unused members ovstring_chars_done and tab_offset;
1022 all uses removed.
1023 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
1024 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
1025 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
1026 (make_gap, copy_text, insert, insert_and_inherit)
1027 (insert_before_markers, insert_before_markers_and_inherit)
1028 (insert_1, count_combining_before, count_combining_after)
1029 (insert_1_both, insert_from_string)
1030 (insert_from_string_before_markers, insert_from_string_1)
1031 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
1032 (adjust_after_replace, adjust_after_insert, replace_range)
1033 (replace_range_2, del_range, del_range_1, del_range_byte)
1034 (del_range_both, del_range_2, modify_region)
1035 (prepare_to_modify_buffer, signal_before_change)
1036 (signal_after_change, Fcombine_after_change_execute):
1037 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1038 * intervals.c (traverse_intervals, rotate_right, rotate_left)
1039 (balance_an_interval, split_interval_right, split_interval_left)
1040 (find_interval, next_interval, update_interval)
1041 (adjust_intervals_for_insertion, delete_node, delete_interval)
1042 (interval_deletion_adjustment, adjust_intervals_for_deletion)
1043 (static_offset_intervals, offset_intervals)
1044 (merge_interval_right, merge_interval_left, make_new_interval)
1045 (graft_intervals_into_buffer, temp_set_point_both)
1046 (temp_set_point, set_point, adjust_for_invis_intang)
1047 (set_point_both, move_if_not_intangible, get_property_and_range)
1048 (get_local_map, copy_intervals, copy_intervals_to_string)
1049 (compare_string_intervals, set_intervals_multibyte_1):
1050 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1051 * intervals.h: Adjust decls to match defn changes elsewhere.
1052 (struct interval):
1053 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1054 * keyboard.c (this_command_key_count, this_single_command_key_start)
1055 (before_command_key_count, before_command_echo_length, echo_now)
1056 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
1057 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
1058 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
1059 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
1060 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1061 (last_non_minibuf_size, last_point_position, echo_truncate)
1062 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
1063 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
1064 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
1065 (stuff_buffered_input):
1066 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1067 (last_auto_save, command_loop_1, read_char):
1068 Use EMACS_INT, not int, to avoid integer overflow.
1069 (record_char): Avoid overflow in total_keys computation.
1070 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
1071 * keyboard.h: Adjust decls to match defn changes elsewhere.
1072 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
1073 (Fkey_description, Fdescribe_vector, Flookup_key):
1074 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1075 (click_position): New function, to check that positions are in range.
1076 (Fcurrent_active_maps):
1077 (describe_command):
1078 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1079 (Faccessible_keymaps, Fkey_description):
1080 (preferred_sequence_p):
1081 Don't assume fixnum can fit into int.
1082 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
1083 Check for integer overflow in size calculations.
1084 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
1085 avoid mishandling large integers.
1086 * lisp.h: Adjust decls to match defn changes elsewhere.
1087 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
1088 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
1089 (struct Lisp_Marker):
1090 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1091 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
1092 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
1093 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
1094 All callers changed.
1095 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
1096 Assume the arg has valid form, since it always does.
1097 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
1098 unsigned integer system type.
1099 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
1100 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
1101 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1102 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
1103 (duration_to_sec_usec): New decl.
1104 * lread.c (read_from_string_index, read_from_string_index_byte)
1105 (read_from_string_limit, readchar, unreadchar, openp)
1106 (read_internal_start, read1, oblookup):
1107 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1108 (Fload, readevalloop, Feval_buffer, Feval_region):
1109 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1110 (openp): Check for out-of-range argument to 'access'.
1111 (read1): Use int, not EMACS_INT, where int is wide enough.
1112 Don't assume fixnum fits into int.
6efdadfd 1113 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
1114 (read_filtered_event): Use duration_to_sec_usec
1115 to do proper overflow checking on durations.
d311d28c
PE
1116 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
1117 in size calculation.
1118 (Fexecute_kbd_macro):
1119 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1120 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
1121 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
1122 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
1123 (set_marker_both, set_marker_restricted_both, marker_position)
1124 (marker_byte_position, Fbuffer_has_markers_at):
1125 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1126 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 1127 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
1128 It now merely ensures that the menu is large enough, without
1129 necessarily growing it, as this avoids some integer overflow issues.
1130 All callers changed.
1131 (keymap_panes, parse_single_submenu, Fx_popup_menu):
1132 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1133 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
1134 Use SAFE_ALLOCA_LISP, not alloca.
1135 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
1136 to EMACS_INT. Check that fixnums are in proper range for system types.
1137 * minibuf.c (minibuf_prompt_width, string_to_object)
1138 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
1139 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
1140 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1141 (get_minibuffer, read_minibuf_unwind):
1142 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1143 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
1144 this simplifies overflow checking. All callers changed.
1145 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
1146 (Ftest_completion):
1147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1148 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
1149 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
1150 Check that fixnums are in proper range for system types.
1151 (Fx_create_frame, Fx_show_tip):
1152 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1153 * nsfont.m (ns_findfonts, nsfont_list_family):
1154 Don't assume fixnum fits in long.
1155 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
1156 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1157 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
1158 wide enough.
17fdb222 1159 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
1160 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1161 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
1162 (PRINTDECLARE, PRINTPREPARE):
1163 (strout, print_string):
1164 (print, print_preprocess, print_check_string_charset_prop)
1165 (print_object):
1166 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1167 (PRINTDECLARE):
1168 (temp_output_buffer_setup, Fprin1_to_string, print_object):
1169 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1170 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 1171 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 1172 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
1173 (print_error_message): Use SAFE_ALLOCA, not alloca.
1174 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
1175 (print_depth, new_backquote_output, print_number_index):
1176 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
1177 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
1178 (Fset_process_window_size, Fformat_network_address)
1179 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 1180 (sigchld_handler):
d311d28c 1181 Check that fixnums are in proper range for system types.
d44287d4 1182 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
1183 Check for process-ids out of pid_t range rather than relying on
1184 undefined behavior.
e4d81efc 1185 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
1186 (Fformat_network_address, read_process_output, send_process)
1187 (Fprocess_send_region, status_notify):
1188 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1189 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
1190 (wait_reading_process_output, read_process_output, exec_sentinel):
1191 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1192 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
1193 (Faccept_process_output): Use duration_to_sec_usec to do proper
1194 overflow checking on durations.
dde14581
PE
1195 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
1196 Don't assume pid_t fits in int.
02481186
PE
1197 * process.h (struct Lisp_Process): Members tick and update_tick
1198 are now of type EMACS_INT, not int.
b62b53e8
PE
1199 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
1200 configured --with-wide-int.
d311d28c
PE
1201 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
1202 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
1203 * search.c (looking_at_1, string_match_1):
1204 (fast_string_match, fast_c_string_match_ignore_case)
1205 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
1206 (scan_newline, find_before_next_newline, search_command)
1207 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
1208 (set_search_regs, wordify):
1209 (Freplace_match):
1210 (Fmatch_data):
1211 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1212 (string_match_1, search_buffer, set_search_regs):
1213 (Fmatch_data):
1214 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1215 (wordify): Check for overflow in size calculation.
1216 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
1217 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
1218 Check that fixnums are in proper range for system types.
1219 * sound.c (struct sound_device)
1220 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
1221 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1222 (Fplay_sound_internal):
1223 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 1224 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
1225 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
1226 (Fparse_partial_sexp):
1227 Don't assume fixnums can fit in int.
1228 (struct lisp_parse_state, find_start_pos, find_start_value)
1229 (find_start_value_byte, find_start_begv)
1230 (update_syntax_table, char_quoted, dec_bytepos)
1231 (find_defun_start, prev_char_comend_first, back_comment):
1232 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
1233 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
1234 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1235 (Finternal_describe_syntax_value): Check that match_lisp is a
1236 character, not an integer, since the code stuffs it into int.
1237 (scan_words, scan_sexps_forward):
1238 Check that fixnums are in proper range for system types.
1239 (Fforward_word):
1240 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1241 (scan_sexps_forward):
1242 Use CHARACTERP, not INTEGERP, since the value must fit into int.
1243 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
1244 * syntax.h: Adjust decls to match defn changes elsewhere.
1245 (struct gl_state_s):
1246 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
1247 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
1248 MOST_POSITIVE_FIXNUM.
d311d28c
PE
1249 * sysdep.c (wait_for_termination_1, wait_for_termination)
1250 (interruptible_wait_for_termination, mkdir):
1251 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
1252 (emacs_read, emacs_write):
1253 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
1254 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
1255 and double all fit in int.
d311d28c
PE
1256 * term.c (set_tty_color_mode):
1257 Check that fixnums are in proper range for system types.
1258 * termhooks.h (struct input_event):
1259 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1260 * textprop.c (validate_interval_range, interval_of)
1261 (Fadd_text_properties, set_text_properties_1)
1262 (Fremove_text_properties, Fremove_list_of_text_properties)
1263 (Ftext_property_any, Ftext_property_not_all)
1264 (copy_text_properties, text_property_list, extend_property_ranges)
1265 (verify_interval_modification):
1266 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1267 (Fnext_single_char_property_change)
1268 (Fprevious_single_char_property_change):
1269 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
1270 (copy_text_properties):
1271 Check for integer overflow in index calculation.
d311d28c
PE
1272 * undo.c (last_boundary_position, record_point, record_insert)
1273 (record_delete, record_marker_adjustment, record_change)
1274 (record_property_change):
1275 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1276 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
1277 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1278 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1279 (Fx_hide_tip, Fx_file_dialog):
1280 * w32menu.c (set_frame_menubar):
1281 Use ptrdiff_t, not int, for consistency with rest of code.
1282 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
1283 (select_window, Fdelete_other_windows_internal)
1284 (window_scroll_pixel_based, window_scroll_line_based)
1285 (Frecenter, Fset_window_configuration):
1286 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1287 (Fset_window_hscroll, run_window_configuration_change_hook)
1288 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 1289 (Fscroll_other_window, Frecenter):
d311d28c
PE
1290 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1291 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
1292 Don't assume fixnum fits in int.
1293 (Fset_window_scroll_bars):
1294 Check that fixnums are in proper range for system types.
1295 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
1296 (string_pos, c_string_pos, number_of_chars, init_iterator)
1297 (in_ellipses_for_invisible_text_p, init_from_display_pos)
1298 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
1299 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
1300 (face_before_or_after_it_pos, handle_invisible_prop)
1301 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
1302 (display_prop_intangible_p, string_buffer_position_lim)
1303 (string_buffer_position, handle_composition_prop, load_overlay_strings)
1304 (get_overlay_strings_1, get_overlay_strings)
1305 (iterate_out_of_display_property, forward_to_next_line_start)
1306 (back_to_previous_visible_line_start, reseat, reseat_to_string)
1307 (get_next_display_element, set_iterator_to_next)
1308 (get_visually_first_element, compute_stop_pos_backwards)
1309 (handle_stop_backwards, next_element_from_buffer)
1310 (move_it_in_display_line_to, move_it_in_display_line)
1311 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1312 (add_to_log, message_dolog, message_log_check_duplicate)
1313 (message2, message2_nolog, message3, message3_nolog
1314 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
1315 (current_message_1, truncate_echo_area, truncate_message_1)
1316 (set_message, set_message_1, store_mode_line_noprop)
1317 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
1318 (text_outside_line_unchanged_p, check_point_in_composition)
1319 (reconsider_clip_changes)
1320 (redisplay_internal, set_cursor_from_row, try_scrolling)
1321 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
1322 (redisplay_window, find_last_unchanged_at_beg_row)
1323 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
1324 (trailing_whitespace_p, find_row_edges, display_line)
1325 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
1326 (display_mode_element, store_mode_line_string)
1327 (pint2str, pint2hrstr, decode_mode_spec)
1328 (display_count_lines, display_string, draw_glyphs)
1329 (x_produce_glyphs, x_insert_glyphs)
1330 (rows_from_pos_range, mouse_face_from_buffer_pos)
1331 (fast_find_string_pos, mouse_face_from_string_pos)
1332 (note_mode_line_or_margin_highlight, note_mouse_highlight):
1333 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1334 (safe_call, init_from_display_pos, handle_fontified_prop)
1335 (handle_single_display_spec, load_overlay_strings)
1336 (with_echo_area_buffer, setup_echo_area_for_printing)
1337 (display_echo_area, echo_area_display)
1338 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
1339 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
1340 (redisplay_window, dump_glyph_row, display_mode_line)
1341 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 1342 (handle_display_spec, display_prop_string_p):
d311d28c
PE
1343 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1344 (handle_single_display_spec, build_desired_tool_bar_string)
1345 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
1346 (get_specified_cursor_type):
1347 Check that fixnums are in proper range for system types.
1348 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
1349 (Flookup_image_map):
1350 Don't assume fixnums fit in int.
1351 (compare_overlay_entries):
1352 Avoid mishandling comparisons due to subtraction overflow.
1353 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
1354 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
1355 (handle_tool_bar_click):
1356 Use int, not unsigned, since we prefer signed and the signedness
1357 doesn't matter here.
1358 (get_next_display_element, next_element_from_display_vector):
1359 Use int, not EMACS_INT, when int is wide enough.
1360 (start_hourglass): Use duration_to_sec_usec to do proper
1361 overflow checking on durations.
1362 * xfaces.c (Fbitmap_spec_p):
1363 Check that fixnums are in proper range for system types.
1364 (compare_fonts_by_sort_order):
1365 Avoid mishandling comparisons due to subtraction overflow.
1366 (Fx_family_fonts, realize_basic_faces):
1367 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1368 (Fx_family_fonts):
1369 Don't assume fixnum fits in int.
1370 Use SAFE_ALLOCA_LISP, not alloca.
1371 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
1372 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
1373 (face_at_buffer_position, face_for_overlay_string)
1374 (face_at_string_position):
1375 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1376 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
1377 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
1378 (Fx_show_tip):
1379 Check that fixnums are in proper range for system types.
1380 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
1381 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
1382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1383 (Fx_change_window_property): Don't assume fixnums fit in int.
1384 * xfont.c (xfont_chars_supported):
1385 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1386 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
1387 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
1388 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1389 * xml.c (parse_region):
1390 * xrdb.c (magic_file_p):
1391 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
1392 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
1393 (x_get_local_selection, x_reply_selection_request)
1394 (x_handle_selection_request, wait_for_property_change):
1395 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1396 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
1397 short is wide enough.
1398 (x_send_client_event): Don't assume fixnum fits in int.
1399 * xterm.c (x_x_to_emacs_modifiers):
1400 Don't assume EMACS_INT overflows nicely into int.
1401 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
1402 may come from Lisp.
1403 (handle_one_xevent): NATNUMP can eval its arg twice.
1404 (x_connection_closed):
1405 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
1406 * xterm.h: Adjust decls to match defn changes elsewhere.
1407 (struct scroll_bar): Use struct vectorlike_header
1408 rather than rolling our own approximation.
1409 (SCROLL_BAR_VEC_SIZE): Remove; not used.
1410
c6574eb5
GM
14112012-05-25 Glenn Morris <rgm@gnu.org>
1412
1413 * lisp.mk (lisp): Update for more files being compiled now.
1414
e8d32c7e
SM
14152012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
1416
48def666
SM
1417 * lread.c: Remove `read_pure' which makes no difference.
1418 (read_pure): Remove var.
1419 (unreadpure): Remove function.
1420 (readevalloop): Don't call read_list with -1 flag.
1421 (read1, read_vector): Don't test read_pure any more.
1422 (read_list): Simplify.
1423
e8d32c7e
SM
1424 * fileio.c, character.h: Minor style tweaks.
1425
4b2addb7
DA
14262012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
1427
1428 * window.h (clip_changed): Remove useless declaration.
1429
584461b2
JB
14302012-05-22 Juanma Barranquero <lekktu@gmail.com>
1431
1432 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
1433 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
1434
34374650
PE
14352012-05-22 Paul Eggert <eggert@cs.ucla.edu>
1436
1437 Remove src/m/*.
1438 This directory predates autoconf and is no longer needed nowadays.
1439 Move its few remaining bits of functionality to where they're needed.
1440 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
1441 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
1442 * m/template.h: Remove.
1443 * Makefile.in (M_FILE): Remove. All uses removed.
1444 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
1445 * lisp.h (USE_LSB_TAG):
1446 * mem-limits.h (EXCEEDS_LISP_PTR):
1447 Use VAL_MAX, not VALBITS, in #if.
1448 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
1449 (EMACS_UINT): Define unconditionally now.
1450 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
1451 (BITS_PER_EMACS_INT): New constants, replacing
1452 what used to be in config.h, but not useful in #if.
1453 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
1454 define them any more.
1455 (VAL_MAX): New macro.
1456 (VALMASK): Use it.
1457 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
1458 BITS_PER_EMACS_INT, in #if.
1459 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
1460 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
1461 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
1462 * s/ms-w32.h (DATA_START):
1463 Move here from removed file m/intel386.h.
1464 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
1465 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
1466
261cb4bb
PE
14672012-05-21 Paul Eggert <eggert@cs.ucla.edu>
1468
1469 Assume C89 or later.
1470 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
1471 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
1472 (xrealloc):
1473 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
1474 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
1475 * textprop.c, tparam.c (NULL): Remove.
1476 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
1477 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
1478 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
1479 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
1480 * xterm.c (input_signal_count): Assume volatile works.
1481
ff23cd9f
KB
14822012-05-21 Ken Brown <kbrown@cornell.edu>
1483
1484 * xgselect.c (xg_select): Fix first argument in call to 'select'
1485 (bug#11508).
1486
1b170bc6
KB
14872012-05-20 Ken Brown <kbrown@cornell.edu>
1488
1489 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 1490 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 1491
b2f4d39f
KB
14922012-05-19 Ken Brown <kbrown@cornell.edu>
1493
1494 * xfns.c (x_in_use): Remove `static' qualifier.
1495 * xterm.h (x_in_use): Declare.
1496 * xgselect.c: Include xterm.h.
1497 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
1498 and `display_arg' (bug#9754).
1499
003fdae2
PE
15002012-05-19 Paul Eggert <eggert@cs.ucla.edu>
1501
9232a6d9
PE
1502 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
1503
003fdae2
PE
1504 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
1505 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
1506
784b56e2
EZ
15072012-05-18 Eli Zaretskii <eliz@gnu.org>
1508
1509 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
1510
1511 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
1512 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c
1513
1514 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
1515 reference to image_cache->refcount.
1516 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
1517
a0a79cde
JL
15182012-05-17 Juri Linkov <juri@jurta.org>
1519
1520 * search.c (Fword_search_regexp, Fword_search_backward)
1521 (Fword_search_forward, Fword_search_backward_lax)
1522 (Fword_search_forward_lax): Move functions to isearch.el
1523 (bug#10145, bug#11381).
1524
b0572523
PE
15252012-05-16 Paul Eggert <eggert@cs.ucla.edu>
1526
1527 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
1528
9660f5fc
SM
15292012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
1530
1531 * lread.c (init_obarray): Declare Qt and Qnil as special.
1532
4374de83
GM
15332012-05-14 Glenn Morris <rgm@gnu.org>
1534
1535 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 1536 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 1537
dc44c39a
PE
15382012-05-14 Paul Eggert <eggert@cs.ucla.edu>
1539
078c97cb
PE
1540 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
1541
dc44c39a
PE
1542 * unexaix.c: Port to more-recent AIX compilers.
1543 (report_error, report_error_1, make_hdr, copy_sym)
1544 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
1545 Make arguments const char *, not char *, to avoid violations of C
1546 standard and to fix some AIX warnings reported by Gilles Pion.
1547
e18afed7 15482012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
1549
1550 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
1551 already have overlays loaded.
1552 (handle_single_display_spec): Before returning without displaying
1553 fringe bitmap, synchronize the bidi iterator with the main display
1554 iterator, by calling iterate_out_of_display_property.
1555 (iterate_out_of_display_property): Detect buffer iteration by
1556 testing that it->string is a Lisp string.
1557 (get_next_display_element): When the current object is exhausted,
1558 and there's something on it->stack, call set_iterator_to_next to
1559 proceed with what's on the stack, instead of returning zero.
1560 (set_iterator_to_next): If called at the end of a Lisp string,
1561 proceed to consider_string_end without incrementing string
1562 position. Don't increment display vector index past the end of
1563 the display vector. (Bug#11417)
c8fb9dc6
EZ
1564 (pos_visible_p): Don't report a position visible when move_it_to
1565 stopped at the last line of window, which happens to be scanned
1566 backwards by the bidi iteration. (Bug#11464)
ac268e67 1567
e18afed7 15682012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
1569
1570 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
1571 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
1572 are on a TTY, and thus unable to display on the fringes.
1573 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
1574 so we need to signal to the caller that this is a "replacing"
1575 display spec. This fixes display when the spec is invalid or we
1576 are on a TTY.
1577
e18afed7 15782012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
1579
1580 * unexaix.c (make_hdr): Fix typo in prototype.
1581 This bug broke the build on AIX. Problem reported by Gilles Pion.
1582
9d0a235a
MA
15832012-05-14 Michael Albinus <michael.albinus@gmx.de>
1584
1585 * keyboard.c (kbd_buffer_get_event): Read special events also in
1586 batch mode. (Bug#11415)
1587
9e6b06ed
GM
15882012-05-12 Glenn Morris <rgm@gnu.org>
1589
1590 * ns.mk: Update for ns_appbindir no longer having trailing "/".
1591
c1a1d7a3
EZ
15922012-05-12 Eli Zaretskii <eliz@gnu.org>
1593
1594 * lisp.mk (lisp): Add newcomment.elc.
1595
3fe7cdc8
GM
15962012-05-12 Glenn Morris <rgm@gnu.org>
1597
1598 * Makefile.in (MKDIR_P): New, set by configure.
1599 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
1600
53f7d2c0
PE
16012012-05-11 Paul Eggert <eggert@cs.ucla.edu>
1602
1603 Remove unused function hourglass_started.
1604 * dispextern.h (hourglass_started):
1605 * w32fns.c (hourglass_started):
1606 * xdisp.c (hourglass_started): Remove.
1607
75aafb17
JB
16082012-05-10 Juanma Barranquero <lekktu@gmail.com>
1609
1610 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
1611 Update dependencies.
1612
12959e8e
PE
16132012-05-10 Paul Eggert <eggert@cs.ucla.edu>
1614
97107e2e
PE
1615 * xgselect.c (xg_select): Put maxfds+1 into a var.
1616 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
1617
12959e8e
PE
1618 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
1619
836d29b3
DA
16202012-05-10 Dave Abrahams <dave@boostpro.com>
1621
1622 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
1623 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
1624
5cb67954
MA
16252012-05-09 Michael Albinus <michael.albinus@gmx.de>
1626
1627 * dbusbind.c (xd_registered_buses): New internal Lisp object.
1628 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
1629 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
1630 Initialize xd_registered_buses.
1631
3478ec45
PE
16322012-05-09 Paul Eggert <eggert@cs.ucla.edu>
1633
b263a6b0
PE
1634 Untag more efficiently if USE_LSB_TAG.
1635 This is based on a proposal by YAMAMOTO Mitsuharu in
1636 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
1637 For an admittedly artificial (nth 8000 longlist) benchmark on
1638 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
1639 Emacs's overall text size by 1%.
1640 * lisp.h (XUNTAG): New macro.
1641 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
1642 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
1643 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
1644 * eval.c (Fautoload):
1645 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
1646 * frame.h (XFRAME): Use XUNTAG.
1647
3478ec45
PE
1648 Port recent dbusbind.c changes to 32-bit --with-wide-int.
1649 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
1650 Remove unportable assumptions about print widths of types like
1651 dbus_uint32_t.
1652 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
1653 intptr_t when converting between pointer and integer, to avoid GCC
1654 warnings about wrong width.
1655
666b903b 16562012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
1657
1658 * w32proc.c (new_child): Force Windows to reserve only 64KB of
1659 stack for each reader_thread, instead of defaulting to 8MB
1660 determined by the linker. This avoids failures in creating
1661 subprocesses on Windows 7, see the discussion in this thread:
1662 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
1663
b120cc17
JC
16642012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
1665
1666 Fix up display of the *Minibuf-0* buffer in the mini window.
1667 * keyboard.c (read_char): Don't clear the echo area if there's no
1668 message to clear.
1669 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 1670 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 1671
9a4b36f8
MA
16722012-05-07 Michael Albinus <michael.albinus@gmx.de>
1673
1674 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
1675 batch mode.
1676
e5f9458f
CY
16772012-05-06 Chong Yidong <cyd@gnu.org>
1678
1679 * lisp.mk (lisp): Update.
1680
eceeb5fc 16812012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
1682
1683 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
1684
71873e2b
SM
16852012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
1686
1687 * data.c (PUT_ERROR): New macro.
1688 (syms_of_data): Use it. Add new error type `user-error'.
1689 * undo.c (user_error): New function.
1690 (Fprimitive_undo): Use it.
1691 * print.c (print_error_message): Adjust print style for `user-error'.
1692 * keyboard.c (user_error): New function.
1693 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
1694
ab0fa4e4
PE
16952012-05-03 Paul Eggert <eggert@cs.ucla.edu>
1696
1697 Do not limit current-time-string to years 1000..9999.
1698 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
1699 (Fcurrent_time_string): Support any year that is supported by the
1700 underlying localtime representation. Don't use asctime, as it
1701 has undefined behavior for years outside the range -999..9999.
1702
7ed806a7
PE
17032012-05-02 Paul Eggert <eggert@cs.ucla.edu>
1704
1705 Fix race conditions involving setenv, gmtime, localtime, asctime.
1706 Without this fix, interrupts could mess up code that uses these
1707 nonreentrant functions, since setting TZ invalidates existing
1708 tm_zone or tzname values, and since most of these functions return
1709 pointers to static storage.
1710 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
1711 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
1712 Grow the critical sections to include not just invoking
1713 localtime/gmtime, but also accessing these functions' results
1714 including their tm_zone values if any, and any related TZ setting.
1715 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
1716 so that the struct tm is saved in the critical section.
1717 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
1718 motivated by the fact that memory allocation needs to be outside
1719 the critical section.
1720
0c16dfed
DA
17212012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
1722
1723 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
1724 with RESET_INTERVAL.
1725
1726 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
1727 Remove duplicated buffer name initialization.
1728
3f83ace8
JM
17292012-05-02 Jim Meyering <jim@meyering.net>
1730
1731 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
1732
c7b8541e
JM
1733 * xfns.c (x_window): Use xstrdup (Bug#11375).
1734
90207a15 17352012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
1736
1737 * xdisp.c (pos_visible_p): If already at a newline from the
1738 display string before the 'while' loop, don't walk back the glyphs
1739 from it3.glyph_row. Solves assertion violation when the display
1740 string begins with a newline (egg.el). (Bug#11367)
1741
b593d6a9
AH
17422012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
1743
1744 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
1745 Move to simple.el.
1746
4737362e
GM
17472012-05-01 Glenn Morris <rgm@gnu.org>
1748
99cf43f9
GM
1749 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
1750 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
1751 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
1752 All were removed before 23.1.
1753
9311dcff
GM
1754 * dispnew.c: Remove HAVE_LIBNCURSES test;
1755 it is always true on relevant platforms.
1756
4d5c6349
GM
1757 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
1758 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
1759
4737362e
GM
1760 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
1761
74dd3a6b
AS
17622012-04-30 Andreas Schwab <schwab@linux-m68k.org>
1763
1764 * .gdbinit (xpr): Remove checks for no longer existing misc types.
1765 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
1766 Remove.
1767
13c379ee
PE
17682012-04-28 Paul Eggert <eggert@cs.ucla.edu>
1769
1770 Do not avoid creating empty evaporating overlays (Bug#9642).
1771 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
1772 That is, do not delete an evaporating overlay if it becomes
1773 empty after its bounds are adjusted to fit within its buffer.
1774 This fix caused other problems, and I'm reverting it until we get
1775 to the bottom of them.
1776
a8e7d6d7 17772012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
1778
1779 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
1780
a8e7d6d7 17812012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
1782
1783 * xdisp.c (pos_visible_p): If the window start position is beyond
1784 ZV, start the display from buffer beginning. Prevents assertion
1785 violation in init_iterator when the minibuffer window is scrolled
1786 via the scroll bar.
1787
1788 * window.c (window_scroll_pixel_based): Likewise.
1789
a8e7d6d7 17902012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
1791
1792 * keymap.c (where_is_internal): Doc fix (Bug#10872).
1793
a8e7d6d7 17942012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
1795
1796 * fileio.c (Fcopy_file, Fset_file_selinux_context):
1797 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
1798
a8e7d6d7 17992012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 1800
b593d6a9
AH
1801 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
1802 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 1803
1c6900d9
EZ
18042012-04-26 Eli Zaretskii <eliz@gnu.org>
1805
4c3fa1d9
EZ
1806 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
1807 display element, check also the underlying string or buffer
1808 character. (Bug#11341)
1809
1c6900d9
EZ
1810 * w32menu.c: Include w32heap.h.
1811 (add_menu_item): If the call to AppendMenuW (via
1812 unicode_append_menu) fails, disable Unicode menus only if we are
1813 running on Windows 9X/Me.
1814
42bf8205
AS
18152012-04-24 Andreas Schwab <schwab@linux-m68k.org>
1816
1817 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
1818 (xgetint): Add missing shift for LSB tags.
1819
b1bac16e
MR
18202012-04-24 Martin Rudalics <rudalics@gmx.at>
1821
1822 * keyboard.c (read_char): Don't wipe echo area for select window
1823 events: These might get delayed via `mouse-autoselect-window'
1824 (Bug#11304).
1825
d69621cc
JB
18262012-04-24 Juanma Barranquero <lekktu@gmail.com>
1827
1828 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
1829 manipulation of :loaded-from data.
1830
02fd101b
JB
18312012-04-23 Juanma Barranquero <lekktu@gmail.com>
1832
1833 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
1834 now a cons (bug#11311).
1835
888bec30
PE
18362012-04-23 Paul Eggert <eggert@cs.ucla.edu>
1837
89a438bd
PE
1838 Do not create empty overlays with the evaporate property (Bug#9642).
1839 * buffer.c (Fmove_overlay): Delete an evaporating overlay
1840 if it becomes empty after its bounds are adjusted to fit within
1841 its buffer. Without this fix, in a nonempty buffer (let ((o
1842 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
1843 yields an empty overlay that has the evaporate property, which is
1844 not supposed to happen.
1845
1068fe4d
PE
1846 Fix minor GTK3 problems found by static checking.
1847 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1848 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1849 (struct _EmacsFixedClass, emacs_fixed_get_type):
1850 Move decls here from emacsgtkfixed.h, since they needn't be public.
1851 (emacs_fixed_get_type): Now static.
1852 (emacs_fixed_class_init): Omit unused local.
1853 (emacs_fixed_child_type): Remove; unused.
1854 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
1855 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
1856 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
1857 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
1858 (EMACS_FIXED_GET_CLASS): Remove; unused.
1859 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
1860
888bec30
PE
1861 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
1862 Problem reported by Juanma Barranquero for Windows -Wunused-function.
1863
de85e130
PE
18642012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1865
d0baac98 1866 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 1867 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
1868 (__malloc_size_t, __malloc_ptrdiff_t):
1869 Remove. All uses removed, replaced by the definiens if needed,
1870 since we can assume C89 or better now.
1871 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
1872 (protect_malloc_state, align, get_contiguous_space)
1873 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
1874 (malloc_atfork_handler_child, malloc_enable_thread)
1875 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
1876 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
1877 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
1878 (special_realloc, _realloc_internal_nolock, _realloc_internal)
1879 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
1880 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
1881 Define using prototypes, not old style.
1882 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
1883 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
1884 (align): Don't assume that signed integer overflow wraps around.
1885 Omit unused local var.
1886 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
1887 (_free_internal_nolock, memalign, mallochook, reallochook):
1888 Omit no-longer-needed casts.
1889 (valloc): Use getpagesize, not __getpagesize.
1890 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
1891 (struct hdr): The 'magic' member is now size_t, not unsigned long.
1892
de85e130
PE
1893 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
1894
dcbf5805
MA
18952012-04-22 Michael Albinus <michael.albinus@gmx.de>
1896
1897 Move functions from C to Lisp. Make non-blocking method calls
1898 the default. Implement further D-Bus standard interfaces.
1899
1900 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
1901 (QCdbus_request_name_allow_replacement)
1902 (QCdbus_request_name_replace_existing)
1903 (QCdbus_request_name_do_not_queue)
1904 (QCdbus_request_name_reply_primary_owner)
1905 (QCdbus_request_name_reply_in_queue)
1906 (QCdbus_request_name_reply_exists)
1907 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
1908 (QCdbus_registered_serial, QCdbus_registered_method)
1909 (QCdbus_registered_signal): New Lisp objects.
1910 (XD_DEBUG_MESSAGE): Use sizeof.
1911 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
1912 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
1913 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
1914 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
1915 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
1916 (xd_signature, xd_append_arg): Allow float for integer types.
1917 (xd_get_connection_references): New function.
b593d6a9
AH
1918 (xd_get_connection_address): Rename from xd_initialize.
1919 Return cached address.
dcbf5805
MA
1920 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
1921 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
1922 level.
1923 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 1924 Return number of refcounts.
dcbf5805
MA
1925 (Fdbus_get_unique_name): Make stronger parameter check.
1926 (Fdbus_message_internal): New defun.
1927 (Fdbus_call_method, Fdbus_call_method_asynchronously)
1928 (Fdbus_method_return_internal, Fdbus_method_error_internal)
1929 (Fdbus_send_signal, Fdbus_register_service)
1930 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
1931 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
1932 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
1933 (Vdbus_compiled_version, Vdbus_runtime_version)
1934 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
1935 (Vdbus_message_type_method_return, Vdbus_message_type_error)
1936 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
1937 (Vdbus_registered_buses, Vdbus_registered_objects_table):
1938 Adapt docstring.
dcbf5805 1939
52828e02
PE
19402012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1941
da05bc4c
PE
1942 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
1943 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
1944 Do not assume ptrdiff_t is the same width as 'int'.
1945
52828e02
PE
1946 * alloc.c: Handle unusual debugging option combinations.
1947 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
1948 since the two debugging options are incompatible.
1949 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
1950 is defined.
1951 (mem_init, mem_insert, mem_insert_fixup):
1952 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
1953 (NEED_MEM_INSERT): Remove; no longer needed.
1954
f01769f9
LL
19552012-04-22 Leo Liu <sdl.web@gmail.com>
1956
1957 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
1958
5790543d
PE
19592012-04-22 Paul Eggert <eggert@cs.ucla.edu>
1960
1961 * sysdep.c [__FreeBSD__]: Minor cleanups.
1962 (list_system_processes, system_process_attributes) [__FreeBSD__]:
1963 Use Emacs indenting style more consistently. Avoid some casts.
1964 Use 'double' consistently rather than mixing 'float' and 'double'.
1965
b91b7e4d
EW
19662012-04-21 Eduard Wiebe <usenet@pusto.de>
1967
b593d6a9
AH
1968 * sysdep.c (list_system_processes, system_process_attributes):
1969 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 1970
6114eb15
AS
19712012-04-21 Andreas Schwab <schwab@linux-m68k.org>
1972
1973 * lisp.mk (lisp): Update.
1974
2f38dff7
PE
19752012-04-20 Paul Eggert <eggert@cs.ucla.edu>
1976
1977 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
1978 It is never used otherwise.
1979
4ae29f89
SM
19802012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
1981
1982 * print.c (print_preprocess): Only check print_depth if print-circle
1983 is nil.
1984 (print_object): Check for cycles even when print-circle is nil and
1985 print-gensym is t, but only check print_depth if print-circle is nil.
1986
f30d612a
CY
19872012-04-20 Chong Yidong <cyd@gnu.org>
1988
1989 * process.c (wait_reading_process_output): If EIO occurs on a pty,
1990 set the status to "failed" and ensure that sentinel is run.
1991
c07a4c0b 19922012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
1993
1994 * process.c (Fset_process_inherit_coding_system_flag)
1995 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 1996 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 1997
c07a4c0b 19982012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
1999
2000 * xdisp.c (string_buffer_position_lim): Limit starting position to
2001 BEGV.
2002 (set_cursor_from_row): If called for a mode-line or header-line
2003 row, return zero immediately.
2004 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
2005 farther than the first row after the header line, if any.
2006 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
2007 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
2008
c07a4c0b 20092012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2010
4ae29f89
SM
2011 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
2012 (bug#11238).
ad3a2b41 2013
c07a4c0b 20142012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 20152012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
2016
2017 configure: new option --enable-gcc-warnings (Bug#11207)
2018 * Makefile.in (C_WARNINGS_SWITCH): Remove.
2019 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
2020 (ALL_CFLAGS): Use new macros rather than old.
2021 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
2022 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
2023 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
2024 -Wunused-result, -Wunused-variable. This should go away once
2025 the Emacs and Gnulib regex code is merged.
2026 (xmalloc, xrealloc): Now static.
2027
aba027e8
PE
20282012-04-17 Paul Eggert <eggert@cs.ucla.edu>
2029
2030 * dired.c (Fsystem_groups): Remove unused local.
2031
e5a36063
GM
20322012-04-17 Glenn Morris <rgm@gnu.org>
2033
2034 * dired.c (Fsystem_users): Doc fix.
2035
316411f0
DA
20362012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
2037
2038 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
2039 (syms_of_dired): Add them.
2040
9426aba4
PE
20412012-04-16 Paul Eggert <eggert@cs.ucla.edu>
2042
b62a57be
PE
2043 Fix minor alloc.c problems found by static checking.
2044 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
2045 New extern decls, to avoid calling undeclared functions.
2046 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
2047 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
2048 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
2049 (NEED_MEM_INSERT): New macro.
2050 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 2051 Remove one incorrect comment and fix another.
b62a57be 2052
3539f31f
PE
2053 Fix minor ralloc.c problems found by static checking.
2054 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2055 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
2056 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
2057 (r_alloc_sbrk): Now static.
2058
a041960a
PE
2059 Improve ralloc.c interface checking.
2060 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
2061 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
2062 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
2063 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
2064 [REL_ALLOC]: ... to here, to check interface.
2065 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
2066 Remove decls. This fixes an "It stinks!".
2067
9426aba4
PE
2068 * alloc.c (which_symbols): Fix alignment issue / type clash.
2069
d55c12ed
AS
20702012-04-15 Andreas Schwab <schwab@linux-m68k.org>
2071
2072 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
2073 (struct Lisp_Misc_Any): Likewise.
2074 (struct Lisp_Free): Likewise.
2075 * alloc.c (union aligned_Lisp_Symbol): Define.
2076 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
2077 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
2078 (union aligned_Lisp_Misc): Define.
2079 (MARKER_BLOCK_SIZE, struct marker_block): Use union
2080 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 2081 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 2082
b948ce8b
PE
20832012-04-14 Paul Eggert <eggert@cs.ucla.edu>
2084
2085 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
2086 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
2087 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
2088 * s/netbsd.h, s/sol2-6.h:
2089 Remove definition of GC_MARK_STACK, since the default now works.
2090 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
2091 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
2092 no longer the default.
2093 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
2094
35dc09a1 20952012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 2096
35dc09a1
GM
2097 * lread.c (lisp_file_lexically_bound_p):
2098 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 2099
35dc09a1
GM
21002012-04-14 Eli Zaretskii <eliz@gnu.org>
2101
2102 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
2103 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
2104
21052012-04-14 Jan Djärv <jan.h.d@swipnet.se>
2106
2107 * nsterm.m (constrainFrameRect): Always constrain when there is only
2108 one screen (Bug#10962).
2109
bcd86815
KB
21102012-04-13 Ken Brown <kbrown@cornell.edu>
2111
2112 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
2113
c25df26e
RT
21142012-04-13 Reuben Thomas <rrt@sc3d.org>
2115
2116 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
2117
0fc59f1e
DC
21182012-04-11 Daniel Colascione <dancol@dancol.org>
2119
2120 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
2121 against is gone. It's better to use vfork now so that when Cygwin
2122 gains a new, working vfork, we use it automatically (bug#10398).
2123
de8c03dc
SM
21242012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2125
2126 * window.c (save_window_save): Obey window-point-insertion-type.
2127
2f097256
GM
21282012-04-11 Glenn Morris <rgm@gnu.org>
2129
2130 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
2131
453b951e
SM
21322012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
2133
2134 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
2135
75f1671a 21362012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
2137
2138 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
2139 (force_quit_count): New var.
2140 (handle_interrupt): Use it.
2141
2a8ce227
JB
21422012-04-10 Juanma Barranquero <lekktu@gmail.com>
2143
2144 * w32.c (w32_delayed_load): Record the full path of the library
2145 being loaded (bug#10424).
2146
935396c0
GM
21472012-04-09 Glenn Morris <rgm@gnu.org>
2148
05920a43
GM
2149 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
2150 not just in the obarray, before snarfing them. (Bug#11036)
2151
935396c0
GM
2152 * Makefile.in ($(leimdir)/leim-list.el):
2153 Pass EMACS rather than BUILT_EMACS.
2154
a18ecafa
TZ
21552012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
2156
2157 * process.c (make_process):
2158 * process.h: Add integer `gnutls_handshakes_tried' member to
2159 process struct.
2160
6bbef4e5
JC
2161 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
2162 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
2163
2164 * gnutls.c (gnutls_log_function2i): Convenience log function.
2165 (emacs_gnutls_read): Use new log functions,
2166 `gnutls_handshakes_tried' process member, and
2167 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
2168 attempts per process (connection).
2169
b4d3bc10
CY
21702012-04-09 Chong Yidong <cyd@gnu.org>
2171
2172 * eval.c (Fuser_variable_p, user_variable_p_eh)
2173 (lisp_indirect_variable): Functions deleted.
2174 (Fdefvar): Caller changed.
2175
2176 * callint.c (Finteractive, Fcall_interactively):
2177 * minibuf.c (Fread_variable): Callers changed.
2178
70f4d973
EZ
21792012-04-09 Eli Zaretskii <eliz@gnu.org>
2180
2181 * xdisp.c (set_cursor_from_row): If the display string appears in
2182 the buffer at position that is closer to point than the position
2183 after the display string, display the cursor on the first glyph of
2184 the display string. Fixes cursor display when a 'display' text
2185 property immediately follows invisible text. (Bug#11094)
2186
cb3c2e3e
PE
21872012-04-09 Paul Eggert <eggert@cs.ucla.edu>
2188
2189 composite.c: use 'double' consistently
2190 * composite.c (get_composition_id): Use 'double' consistently
2191 instead of converting 'float' to 'double' and vice versa; this is
2192 easier to understand and avoids a GCC warning.
2193
fd06db5d
GM
21942012-04-09 Glenn Morris <rgm@gnu.org>
2195
50fe702a
GM
2196 * Makefile.in: Generate leim-list with bootstrap-emacs, in
2197 preparation for dumping it with emacs. (Bug#4789)
2198 (leimdir): New variable.
2199 ($(leimdir)/leim-list.el): New rule.
2200 (emacs$(EXEEXT)): Depend on leim-list.el.
2201
fd06db5d
GM
2202 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
2203 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
2204 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
2205
55c131ee
AS
22062012-04-08 Andreas Schwab <schwab@linux-m68k.org>
2207
2208 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
2209 proper alignment.
2210
9209588f
JB
22112012-04-07 Juanma Barranquero <lekktu@gmail.com>
2212
2213 * xml.c (init_libxml2_functions) [WINDOWSNT]:
2214 Remove unused local variable.
2215
e3fb2efb
PE
22162012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2217
2218 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
2219 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
2220 (mark_memory): Mark Lisp_Objects only if pointers might hide in
2221 objects, as mark_maybe_pointer will catch them otherwise.
2222 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
2223 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
2224
b5385551
PE
22252012-04-07 Paul Eggert <eggert@cs.ucla.edu>
2226
2227 Fix typo that broke non-Windows builds.
2228 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
2229
9078ead6
EZ
22302012-04-07 Eli Zaretskii <eliz@gnu.org>
2231
2232 Support building on MS-Windows with libxml2.
2233
2234 * makefile.w32-in (OBJ2): Add xml.$(O).
2235 (GLOBAL_SOURCES): Add xml.c.
2236 ($(BLD)/xml.$(O)): New dependency list.
2237
2238 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
2239 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
2240 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
2241 [!WINDOWSNT]: New macros.
2242 (init_libxml2_functions, libxml2_loaded_p): New functions.
2243 (parse_region): Call fn_xmlCheckVersion instead of using the macro
2244 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
2245 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
2246 Calls xmlCleanupParser only if libxml2 was loaded (or statically
2247 linked in).
6bbef4e5
JC
2248 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
2249 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
2250 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
2251
2252 * emacs.c: Don't include libxml/parser.h.
2253 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
2254 xmlCleanupParser directly.
2255
2256 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
2257
3811fdf3
EZ
22582012-04-07 Eli Zaretskii <eliz@gnu.org>
2259
2260 * indent.c (Fvertical_motion): If there is a display string at
2261 point, use it.vpos to compute how many lines to backtrack after
2262 move_it_to point. (Bug#11133)
2263
2f8e16b2
EZ
22642012-04-06 Eli Zaretskii <eliz@gnu.org>
2265
2266 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
2267 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
2268 about subtle differences between FETCH_CHAR* and STRING_CHAR*
2269 macros related to unification of CJK characters. For the details,
2270 see the discussion following the message here:
2271 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
2272
3d439cd1
CY
22732012-04-04 Chong Yidong <cyd@gnu.org>
2274
2275 * keyboard.c (Vdelayed_warnings_list): Doc fix.
2276
8bc53d00
EZ
22772012-04-01 Eli Zaretskii <eliz@gnu.org>
2278
2279 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
2280 instead of alloca. (Bug#11138)
2281
3b0512a3
AS
22822012-04-01 Andreas Schwab <schwab@linux-m68k.org>
2283
2284 * w32menu.c (is_simple_dialog): Properly check lisp types.
2285 (Bug#11141)
2286
8427ddd2
EZ
22872012-03-31 Eli Zaretskii <eliz@gnu.org>
2288
979022ef
EZ
2289 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
2290 position we get to after a call to move_it_to fails the
2291 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
2292 only if we wind up in a string from display property. (Bug#11063)
2293
a6b1c7cc
EZ
2294 * window.c (Fdelete_other_windows_internal): Invalidate the row
2295 and column information about mouse highlight, so that redisplay
2296 restores it after reallocating the glyph matrices. (Bug#7464)
2297
8427ddd2
EZ
2298 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
2299 string comes from a `display' text property, use the buffer
2300 position of that property as if we actually saw that position in
2301 the row's glyphs.
697ba24b
EZ
2302 (move_it_by_lines): Remove the assertion that
2303 "it->current_x == 0 && it->hpos == 0" which can be legitimately
2304 violated when there's a before-string at the beginning of a line.
2305 (Bug#11063)
8427ddd2 2306
65a0a738
EZ
23072012-03-30 Eli Zaretskii <eliz@gnu.org>
2308
2309 * xdisp.c (append_space_for_newline): If the default face was
2310 remapped, use the remapped face for the appended newline.
2311 (extend_face_to_end_of_line): Use the remapped default face for
2312 extending the face to the end of the line.
2313 (display_line): Call extend_face_to_end_of_line when the default
2314 face was remapped. (Bug#11068)
2315
581355cc
EZ
23162012-03-29 Eli Zaretskii <eliz@gnu.org>
2317
2318 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
2319
e8fc049f
SM
23202012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
2321
2322 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
2323
4fb9a543
GM
23242012-03-27 Glenn Morris <rgm@gnu.org>
2325
2326 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
2327 Doc fixes.
2328
679910f1
KH
23292012-03-26 Kenichi Handa <handa@m17n.org>
2330
2331 * dispextern.h (struct glyph): Fix previous change. Change the
2332 bit length of glyphless.ch to 25 (Bug#11082).
2333
90d49b7f
CY
23342012-03-26 Chong Yidong <cyd@gnu.org>
2335
2336 * keyboard.c (Vselection_inhibit_update_commands): New variable.
2337 (command_loop_1): Use it; inhibit selection update for
2338 handle-select-window too (Bug#8996).
2339
f514f6f0
FP
23402012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
2341
e8fc049f 2342 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 2343
bf43fa51
KH
23442012-03-25 Kenichi Handa <handa@m17n.org>
2345
2346 * dispextern.h (struct glyph): Change the bit length of
2347 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
2348
8a0c01dd
EZ
23492012-03-24 Eli Zaretskii <eliz@gnu.org>
2350
2351 * s/ms-w32.h (tzname): Include time.h before redirecting to
2352 _tzname. Fixes the MSVC build. (Bug#9960)
2353
7d1c3a76
AS
23542012-03-24 Andreas Schwab <schwab@linux-m68k.org>
2355
8ed79523
AS
2356 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
2357 characters.
2358
7d1c3a76
AS
2359 * xterm.c (XTread_socket): Only modify handling_signal if
2360 !SYNC_INPUT. (Bug#11080)
2361
e99a9b8b
EZ
23622012-03-23 Eli Zaretskii <eliz@gnu.org>
2363
2364 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
2365 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
2366 when fetching a multibyte character consumes more bytes than
2367 CHAR_BYTES returns, due to unification of CJK characters in
2368 string_char. (Bug#11073)
2369
5063c0e1
TN
23702012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
2371
2372 * process.c (wait_reading_process_output): Handle pty disconnect
2373 by refraining from sending oneself a SIGCHLD (bug#10933).
2374
9f851fbd
CY
23752012-03-22 Chong Yidong <cyd@gnu.org>
2376
2377 * dispextern.h (struct it): New member string_from_prefix_prop_p.
2378
5063c0e1 2379 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
2380 Mark string as coming from a prefix property.
2381 (handle_face_prop): Use default face for prefix strings (Bug#4281).
2382 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
2383
fb5b8aca
CY
23842012-03-21 Chong Yidong <cyd@gnu.org>
2385
2386 * xfaces.c (Vface_remapping_alist): Doc fix.
2387
62356a1b
EZ
23882012-03-20 Eli Zaretskii <eliz@gnu.org>
2389
2390 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
2391 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
2392 Doc fixes.
62356a1b 2393
025de85b
CY
23942012-03-20 Chong Yidong <cyd@gnu.org>
2395
2396 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
2397 to reflect default non-nil value of redisplay-dont-pause.
2398
4827f94e
KH
23992012-03-19 Kenichi Handa <handa@m17n.org>
2400
2401 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
2402 it fit in a valid range (Bug#11003).
2403
e50a24a2
EZ
24042012-03-18 Eli Zaretskii <eliz@gnu.org>
2405
2406 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
2407 that is not from display property, accept the row as a "cursor
2408 row" if one of the string's character has a non-nil `cursor'
2409 property. Fixes cursor positioning when there are newlines in
2410 overlay strings, e.g. in icomplete.el. (Bug#11035)
2411
9af5ed87
PE
24122012-03-12 Paul Eggert <eggert@cs.ucla.edu>
2413
2414 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
2415
d1f55f16
CY
24162012-03-12 Chong Yidong <cyd@gnu.org>
2417
2418 * eval.c (inhibit_lisp_code): Rename from
2419 inhibit_window_configuration_change_hook; move from window.c.
2420
2421 * xfns.c (unwind_create_frame_1, Fx_create_frame):
2422 * window.c (run_window_configuration_change_hook)
2423 (syms_of_window): Callers changed.
2424
66c5eebd
CY
24252012-03-11 Chong Yidong <cyd@gnu.org>
2426
413df973
CY
2427 * keymap.c (Fkey_description): Doc fix (Bug#9700).
2428
66c5eebd
CY
2429 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
2430
1de11f56
CY
24312012-03-10 Chong Yidong <cyd@gnu.org>
2432
2433 * frame.c (other_visible_frames): Don't assume the selected frame
2434 is visible (Bug#10955).
2435
cae07000
SM
24362012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
2437
2438 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
2439
89c94350
JD
24402012-03-08 Jan Djärv <jan.h.d@swipnet.se>
2441
2442 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
2443 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
2444 zero (Bug#10954).
2445
999dd333
GM
24462012-03-03 Glenn Morris <rgm@gnu.org>
2447
01a6dcc8 2448 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 2449
de0100f2
EZ
24502012-03-02 Eli Zaretskii <eliz@gnu.org>
2451
2452 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
2453 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
2454 (redisplay_window, next_element_from_string): Fix typos in
2455 comments.
3e441275
EZ
2456 (redisplay_window): Pass to move_it_vertically the margin in
2457 pixels, not in screen lines.
de0100f2 2458
96a72ee9
GM
24592012-03-02 Glenn Morris <rgm@gnu.org>
2460
2461 * buffer.c (buffer-list-update-hook): Doc fix.
2462
312508d7
EZ
24632012-02-29 Eli Zaretskii <eliz@gnu.org>
2464
2465 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
2466 push_it before setting up the iterator for the first overlay
2467 string, even if we have an empty string loaded.
2468 (next_overlay_string): If there's an empty string on the iterator
2469 stack, pop the stack. (Bug#10903)
2470
27f3c637
PE
24712012-02-25 Paul Eggert <eggert@cs.ucla.edu>
2472
2473 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
2474 Suggested by Stefan Monnier in
2475 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
2476 * alloc.c (widen_to_Lisp_Object): New static function.
2477 (mark_memory): Also mark Lisp_Objects by fetching pointer words
2478 and widening them to Lisp_Objects. This would work even if
2479 USE_LSB_TAG is defined and wide integers are used, which might
2480 happen in a future version of Emacs.
2481
3c9dfce6
CY
24822012-02-25 Chong Yidong <cyd@gnu.org>
2483
fa74b241
CY
2484 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
2485 Doc fix.
2486
3c9dfce6
CY
2487 * xselect.c (Fx_selection_exists_p): Doc fix.
2488 (x_clipboard_manager_save_all): Print an informative message
2489 before saving to clipboard manager.
2490
9486df08
CY
24912012-02-24 Chong Yidong <cyd@gnu.org>
2492
2493 * keyboard.c (process_special_events): Handle all X selection
2494 requests in kbd_buffer, not just the next one (Bug#8869).
2495
f01d3321
CY
24962012-02-23 Chong Yidong <cyd@gnu.org>
2497
2498 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
2499 call when setting menu-bar-lines and tool-bar-lines parameters.
2500 (unwind_create_frame_1): New helper function.
2501
2502 * window.c (inhibit_window_configuration_change_hook): New var.
2503 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 2504 (syms_of_window): Initialize it.
f01d3321 2505
86b847b6
CY
25062012-02-22 Chong Yidong <cyd@gnu.org>
2507
2508 * xterm.c (x_draw_image_relief): Add missing type check for
2509 Vtool_bar_button_margin (Bug#10743).
2510
a59225b1
CY
25112012-02-21 Chong Yidong <cyd@gnu.org>
2512
2513 * fileio.c (Vfile_name_handler_alist): Doc fix.
2514
2515 * buffer.c (Fget_file_buffer): Protect against invalid file
2516 handler return value.
2517
310f5bd4
PE
25182012-02-20 Paul Eggert <eggert@cs.ucla.edu>
2519
cb3a28cc
PE
2520 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
2521 when computing $valmask.
2522
310f5bd4
PE
2523 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
2524 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
2525 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
2526 It's useless in that case, and it can cause problems on hosts
2527 that allocate halves of EMACS_INT values separately.
2528 Reported by Dan Horák. Diagnosed by Andreas Schwab in
2529 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
2530 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
2531 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
2532 it avoids undefined behavior on hosts where shifting right by more
2533 than the word width has undefined behavior.
2534
2375c96a
CY
25352012-02-19 Chong Yidong <cyd@gnu.org>
2536
2537 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
2538 (Funhandled_file_name_directory, Ffile_name_as_directory)
2539 (Fdirectory_file_name, Fexpand_file_name)
2540 (Fsubstitute_in_file_name): Protect against invalid file handler
2541 return values (Bug#10845).
2542
3eb49e71
EZ
25432012-02-18 Eli Zaretskii <eliz@gnu.org>
2544
2545 * .gdbinit (pitx): Fix incorrect references to fields of the
2546 iterator stack.
2547
7b926f3f
CY
25482012-02-17 Chong Yidong <cyd@gnu.org>
2549
2550 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
2551
11273115
PE
25522012-02-15 Paul Eggert <eggert@cs.ucla.edu>
2553
2554 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
2555 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
2556
c3a70e2b
CY
25572012-02-15 Chong Yidong <cyd@gnu.org>
2558
2559 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
2560 marked as special. Also, starting docstrings with * is obsolete.
2561
0ca43699
AS
25622012-02-13 Andreas Schwab <schwab@linux-m68k.org>
2563
2564 * gnutls.c (emacs_gnutls_write): Fix last change.
2565
2e8f3c56
LI
25662012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
2567
2568 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
2569 send_process.
2570
af70074f
SM
25712012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
2572
2573 * keymap.c (Fsingle_key_description): Handle char ranges.
2574
95986d52
CY
25752012-02-12 Chong Yidong <cyd@gnu.org>
2576
afd83bd1
CY
2577 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
2578 as that creates a dangerous corner case.
2579
95986d52
CY
2580 * window.c (Fdelete_window_internal): Invalidate the mouse
2581 highlight (Bug#9904).
2582
bd7da63e
GM
25832012-02-12 Glenn Morris <rgm@gnu.org>
2584
2585 * xselect.c (Fx_own_selection_internal)
2586 (Fx_get_selection_internal, Fx_disown_selection_internal)
2587 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
2588 * nsselect.m (Fx_own_selection_internal)
2589 (Fx_disown_selection_internal, Fx_selection_exists_p)
2590 (Fx_selection_owner_p, Fx_get_selection_internal):
2591 Sync docs and argument specs with the xselect.c versions.
2592
77abcbc2
LI
25932012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
2594
2595 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
2596
90b671e2
EZ
25972012-02-11 Eli Zaretskii <eliz@gnu.org>
2598
1c0ca0b7
EZ
2599 * w32select.c (Fx_selection_exists_p): Sync doc string and
2600 argument list with xselect.c. (Bug#10783)
2601
2602 * w16select.c (Fx_selection_exists_p): Sync doc string and
2603 argument list with xselect.c. (Bug#10783)
90b671e2 2604
49241268
GM
26052012-02-10 Glenn Morris <rgm@gnu.org>
2606
2607 * fns.c (Fsecure_hash): Doc fix.
2608
f998bbe7 26092012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
2610
2611 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
2612
0992bd9c
CY
26132012-02-07 Chong Yidong <cyd@gnu.org>
2614
2615 * buffer.c (Fbuffer_local_variables)
2616 (buffer_lisp_local_variables): Handle unbound vars correctly;
2617 don't let Qunbound leak into Lisp.
2618
af008560
GM
26192012-02-07 Glenn Morris <rgm@gnu.org>
2620
dd605cc4
GM
2621 * image.c (Fimagemagick_types): Doc fix.
2622
af008560
GM
2623 * image.c (imagemagick-render-type): Change it from a lisp object
2624 to an integer. Move the doc here from the lisp manual.
2625 Treat all values not equal to 0 the same.
2626
1449fa1d
CY
26272012-02-06 Chong Yidong <cyd@gnu.org>
2628
2629 * doc.c (store_function_docstring): Avoid applying docstring of
2630 alias to base function (Bug#2603).
2631
3723ec07
AS
26322012-02-04 Andreas Schwab <schwab@linux-m68k.org>
2633
2634 * .gdbinit (pp1, pv1): Remove redundant defines.
2635 (pr): Use pp.
2636
79c1cc1e
CY
26372012-02-04 Chong Yidong <cyd@gnu.org>
2638
2639 * nsterm.m: Declare a global (Bug#10694).
2640
d7f29f8e
EZ
26412012-02-04 Eli Zaretskii <eliz@gnu.org>
2642
cae07000
SM
2643 * w32.c (get_emacs_configuration_options):
2644 Include --enable-checking, if specified, in the return value.
d7f29f8e 2645
3b95a6f9
MR
26462012-02-04 Martin Rudalics <rudalics@gmx.at>
2647
2648 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
2649 after rounding frame sizes. (Bug#9723)
2650
d6fa96a6
EZ
26512012-02-04 Eli Zaretskii <eliz@gnu.org>
2652
2653 * keyboard.c (adjust_point_for_property): Don't position point
2654 before BEGV. (Bug#10696)
2655
df0b2940
PE
26562012-02-03 Paul Eggert <eggert@cs.ucla.edu>
2657
2658 Handle overflow when computing char display width (Bug#9496).
2659 * character.c (char_width): Return EMACS_INT, not int.
2660 (char_width, c_string_width): Check for overflow when
2661 computing the width; this is possible now that individual
2662 characters can have unbounded width. Problem introduced
2663 by merge from Emacs 23 on 2012-01-19.
2664
6bee44d6
MA
26652012-02-02 Michael Albinus <michael.albinus@gmx.de>
2666
2667 * dbusbind.c (Fdbus_register_method): Mention the return value
2668 :ignore in the docstring.
2669
44f92739
GM
26702012-02-02 Glenn Morris <rgm@gnu.org>
2671
1b9f60cc
GM
2672 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
2673
44f92739
GM
2674 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2675 Unconditionally set to t. (Bug#10673)
2676 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
2677 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
2678 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
2679
c5d3843c
KH
26802012-02-02 Kenichi Handa <handa@m17n.org>
2681
2682 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
2683 0, do not call append_composite_glyph.
2684
159462d4 26852012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
2686
2687 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
2688 NULL (Bug#6988).
2689 (x_produce_glyphs): If the component of a composition is a null
2690 string, set it->pixel_width to 1 to avoid zero-width glyph.
2691
78cef877
EZ
26922012-02-01 Eli Zaretskii <eliz@gnu.org>
2693
2694 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
2695 first 2 arguments are identical. This makes inserting large
2696 output from a subprocess an order of magnitude faster on
2697 MS-Windows, where all sbrk'ed memory is always contiguous.
2698
97897668
GM
26992012-01-31 Glenn Morris <rgm@gnu.org>
2700
2701 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 2702 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
2703 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
2704
31fd3586
GM
27052012-01-29 Glenn Morris <rgm@gnu.org>
2706
2707 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
2708
0e24a8b2
CY
27092012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
2710
2711 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
2712
cc0adcb0
CY
27132012-01-28 Chong Yidong <cyd@gnu.org>
2714
2715 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
2716
acc28cb9
CY
27172012-01-26 Chong Yidong <cyd@gnu.org>
2718
9c69cfb7
CY
2719 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
2720
acc28cb9
CY
2721 * search.c (Fsearch_forward, Fsearch_backward): Document negative
2722 repeat counts (Bug#10507).
2723
48da7392
GM
27242012-01-26 Glenn Morris <rgm@gnu.org>
2725
2726 * lread.c (syms_of_lread): Doc fix.
2727
14af5f7f
CY
27282012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
2729
2730 * coding.c (encode_designation_at_bol): Change return value to
2731 EMACS_INT.
2732
0b21c100
CY
27332012-01-25 Chong Yidong <cyd@gnu.org>
2734
2735 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
2736
3c2907f7
CY
27372012-01-21 Chong Yidong <cyd@gnu.org>
2738
2739 * floatfns.c (Fcopysign): Make the second argument non-optional,
2740 since nil is not allowed anyway.
2741
959ad23f
AS
27422012-01-21 Andreas Schwab <schwab@linux-m68k.org>
2743
2744 * process.c (read_process_output): Use p instead of XPROCESS (proc).
2745 (send_process): Likewise.
2746
34a02f46
MR
27472012-01-19 Martin Rudalics <rudalics@gmx.at>
2748
2749 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
2750 (Vwindow_persistent_parameters): Do not use Qstate.
2751 Rewrite doc-strings.
34a02f46 2752
1259009a 27532012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
2754
2755 * character.c (char_width): New function.
70d4fdf6
GM
2756 (Fchar_width, c_string_width, lisp_string_width):
2757 Use char_width (Bug#9496).
25ed9e61 2758
6a6ee00d
MR
27592012-01-16 Martin Rudalics <rudalics@gmx.at>
2760
2761 * window.c (Vwindow_persistent_parameters): New variable.
2762 (Fset_window_configuration, save_window_save): Handle persistent
2763 window parameters.
2764
c85efaf7
EZ
27652012-01-14 Eli Zaretskii <eliz@gnu.org>
2766
2767 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
2768 thrashing the stack of the thread. (Bug#9087)
2769
5944709e
PE
27702012-01-12 Paul Eggert <eggert@cs.ucla.edu>
2771
2772 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
2773
e71f5d99
EZ
27742012-01-11 Eli Zaretskii <eliz@gnu.org>
2775
2776 * xdisp.c (rows_from_pos_range): Handle the case where the
2777 highlight ends on a newline. (Bug#10464)
2778 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
2779 he end column for display of highlight that ends on a newline
2780 before a R2L line.
2781
ce316182
GM
27822012-01-11 Glenn Morris <rgm@gnu.org>
2783
2784 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
2785 from load-path also when installation-directory is nil. (Bug#10208)
2786
5b43da69
GM
27872012-01-10 Glenn Morris <rgm@gnu.org>
2788
74cc8ff9
GM
2789 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
2790
7d8d6e4e
GM
2791 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
2792 Update template values to be closer to their typical values these days.
5b43da69 2793
a0db8d43
EZ
27942012-01-09 Eli Zaretskii <eliz@gnu.org>
2795
2796 * xdisp.c (rows_from_pos_range): Accept additional argument
2797 DISP_STRING, and accept any glyph in a row whose object is that
2798 string as eligible for mouse highlight. Fixes mouse highlight of
2799 display strings from overlays. (Bug#10464)
2800
9a0115ab 28012012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 2802
b9110d6a 2803 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
2804 * fileio.c (auto_saving_dir_umask): New static var.
2805 (Fmake_directory_internal): Use it.
2806 (do_auto_save_make_dir): Set it, instead of invoking chmod after
2807 creating the directory. The old code temporarily assigns
2808 too-generous permissions to the directory.
2809 (do_auto_save_eh): Clear it.
b9110d6a 2810 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
2811 that the var is always cleared.
2812
6c1bd3f3
EZ
28132012-01-07 Eli Zaretskii <eliz@gnu.org>
2814
2815 * search.c (scan_buffer): Pass character positions to
2816 know_region_cache, not byte positions. (Bug#6540)
2817
069d2b50
L
28182012-01-07 LynX <_LynX@bk.ru> (tiny change)
2819
2820 * w32.c (sys_rename): Report EXDEV when rename of a directory
2821 fails because the target is on another logical disk. (Bug#10284)
2822
75bf0d33
DB
28232012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
2824
2825 * xterm.c (x_embed_request_focus): New function.
2826
2827 * xterm.h: Add prototype.
2828
2829 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
2830
1c6e5a32
GM
28312012-01-05 Glenn Morris <rgm@gnu.org>
2832
2833 * emacs.c (emacs_copyright): Update short copyright year to 2012.
2834
651e947e
EZ
28352012-01-01 Eli Zaretskii <eliz@gnu.org>
2836
2837 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
2838 Load gnutls_transport_set_lowat only if GnuTLS version is below
2839 2.11.1.
2840 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
2841 GnuTLS versions below 2.11.1.
2842
3778cdd8
AL
28432011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
2844
2845 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
2846 to the doc string advising against its use for altering the way
2847 windows are scrolled.
2848
0e5317f7
KH
28492011-12-28 Kenichi Handa <handa@m17n.org>
2850
2851 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
2852 coding-system ASCII compatible only when it does not produce BOM
2853 on encoding (Bug#10383).
2854
93d5ca1f
JD
28552011-12-26 Jan Djärv <jan.h.d@swipnet.se>
2856
2857 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
2858 can scroll.
2859 (create_and_show_popup_menu): Always use menu_position_func for
2860 Gtk3 (Bug#10361).
2861
ca22b785
AS
28622011-12-24 Andreas Schwab <schwab@linux-m68k.org>
2863
2864 * callint.c (Fcall_interactively): Don't truncate prompt string.
2865
d048e1e6
EZ
28662011-12-23 Eli Zaretskii <eliz@gnu.org>
2867
2868 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
2869 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 2870 resumed from there (after widening). (Bug#10360)
d048e1e6 2871
5ccaba1f
JD
28722011-12-22 Jan Djärv <jan.h.d@swipnet.se>
2873
2874 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
2875
204ee57f
JD
28762011-12-21 Jan Djärv <jan.h.d@swipnet.se>
2877
b81d40f0
JB
2878 * nsterm.m (x_free_frame_resources):
2879 Release f->output_data.ns->miniimage.
204ee57f
JD
2880 (ns_index_color): Fix indentation. Do not retain
2881 color_table->colors[i].
2882
2883 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
2884 before returning.
2885
2886 * nsfns.m (x_set_background_color): Assign return value from
2887 ns_index_color to face-background instead of NSColor*.
2888 (ns_implicitly_set_icon_type): Fix indentation.
2889 Change assignment in for loop to comparison.
2890
2891 * emacs.c (ns_pool): New variable.
2892 (main): Assign ns_pool.
2893 (Fkill_emacs): Call ns_release_autorelease_pool.
2894
2895 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
2896 autorelease fdesc, release fdAttrs and tdict.
2897 (ns_get_covering_families): Release charset.
2898 (ns_findfonts): Release NSFontDescriptor created with new.
2899 (ns_uni_to_glyphs): Fix indentation.
2900 (setString): Release attrStr before assigning new value.
2901
c803b2b7
JD
29022011-12-18 Jan Djärv <jan.h.d@swipnet.se>
2903
678f4426
JD
2904 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
2905 and NS_IMPL_COCOA.
2906 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
2907 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
2908
cd394be1 29092011-12-18 David Reitter <reitter@cmu.edu>
678f4426 2910
5fecd5fc
JD
2911 * nsterm.m (ns_term_init): Subscribe for notifications
2912 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
2913 to method trackingNotification in EmacsMenu.
2914
2915 * nsmenu.m (trackingMenu): New variable.
3771cb17 2916 (trackingNotification): New method (from Aquamacs).
5fecd5fc 2917 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 2918 from Aquamacs (Bug#7030).
678f4426
JD
2919
29202011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 2921
c803b2b7
JD
2922 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
2923 (symbol_to_nsstring): Fix indentation.
2924 (ns_symbol_to_pb): New function.
cae07000
SM
2925 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
2926 (Fns_rotate_cut_buffers_internal): Remove.
2927 (Fns_store_selection_internal): Rename from
c803b2b7
JD
2928 Fns_store_cut_buffer_internal.
2929 (ns_get_foreign_selection, Fx_own_selection_internal)
2930 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
2931 (Fns_get_selection_internal, Fns_store_selection_internal):
2932 Use ns_symbol_to_pb and check if return value is nil.
2933 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
2934 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
2935 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
2936 renamed to Sns_store_selection_internal.
2937 (ns_handle_selection_request): Move code to Fx_own_selection_internal
2938 and remove this function.
2939 (ns_handle_selection_clear): Remove, never used.
2940 (Fx_own_selection_internal): Move code from ns_handle_selection_request
2941 here.
2942
e1b01a3a
KB
29432011-12-17 Ken Brown <kbrown@cornell.edu>
2944
2945 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
2946 GID is unknown (Bug#10257).
2947
2adb6e85
PE
29482011-12-17 Paul Eggert <eggert@cs.ucla.edu>
2949
2950 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
2951 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
2952 which caused a build failure on GNU/Linux IA-64. This problem was
2953 introduced by my 2011-10-07 patch.
2954
d1d7b339
JL
29552011-12-15 Juri Linkov <juri@jurta.org>
2956
2957 * image.c (imagemagick_error): New function. (Bug#10112)
2958 (imagemagick_load_image): Comment out `MagickSetResolution' call.
2959 Use `imagemagick_error' where ImageMagick functions return
2960 `MagickFalse'.
2961 (Fimagemagick_types): Add `Fnreverse' to return the list in the
2962 proper order.
2963
100d5755
KH
29642011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
2965
2966 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
2967 fill background (Bug#8992).
2968
454592a6
MR
29692011-12-13 Martin Rudalics <rudalics@gmx.at>
2970
2971 * window.c (Vwindow_combination_resize)
2972 (Vwindow_combination_limit): Use t instead of non-nil in
2973 doc-strings.
61d4b438
MR
2974 (Vrecenter_redisplay): Add first sentence of doc-string on
2975 separate line.
53524d93 2976 (Frecenter): Fix doc-string typo.
454592a6 2977
3633e3aa
KH
29782011-12-11 Kenichi Handa <handa@m17n.org>
2979
2980 * coding.c (Funencodable_char_position): Pay attention to the
2981 buffer text relocation (Bug#9389).
2982
7b9d523a 29832011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 2984
7b9d523a
JD
2985 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
2986 gtk_init (Bug#10100).
2987
b73189c6
EZ
29882011-12-10 Eli Zaretskii <eliz@gnu.org>
2989
2990 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
2991 IT->string is nil. (Bug#10263)
2992
f7dfe5d6
JD
29932011-12-10 Jan Djärv <jan.h.d@swipnet.se>
2994
83faebb4
JD
2995 * nsterm.h (x_free_frame_resources): Declare.
2996
f7dfe5d6
JD
2997 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
2998 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
2999
3000 * nsterm.h (ns_get_defaults_value): Declare.
3001
3002 * nsterm.m (ns_default): Call ns_get_defaults_value.
3003
7cd4e72c
EZ
30042011-12-09 Eli Zaretskii <eliz@gnu.org>
3005
3006 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
3007 (Bug#10170)
3008
b34d7317
YM
30092011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3010
3011 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
3012 that where the value of an _OBJC_* symbol points to is in the .bss
3013 section (Bug#10240).
3014
76470ad1
KH
30152011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3016
3017 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 3018 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 3019
745fff94
KH
30202011-12-08 Kenichi Handa <handa@m17n.org>
3021
3022 * ftfont.c (get_adstyle_property): Fix previous change
3023 (Bug#10233).
3024
6e44397c
JB
30252011-12-07 Juanma Barranquero <lekktu@gmail.com>
3026
3027 * w32.c (init_environment): If no_site_lisp, remove site-lisp
3028 dirs from the default value of EMACSLOADPATH (bug#10208).
3029
7efa6272
GM
30302011-12-07 Glenn Morris <rgm@gnu.org>
3031
3032 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
3033 installation and source directories as well. (Bug#10208)
3034
f6fc4d87
CY
30352011-12-06 Chong Yidong <cyd@gnu.org>
3036
3037 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
3038
2bf26180
GM
30392011-12-06 Glenn Morris <rgm@gnu.org>
3040
3041 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
3042 as an error, not just -1. (Bug#10217)
3043
3a6ad4f0
CY
30442011-12-05 Chong Yidong <cyd@gnu.org>
3045
3046 * keyboard.c (process_special_events): New function.
3047 (swallow_events, Finput_pending_p): Use it (Bug#10195).
3048
75a3b399
PE
30492011-12-05 Paul Eggert <eggert@cs.ucla.edu>
3050
3051 * coding.c (encode_designation_at_bol): Don't use uninitialized
3052 local variable (Bug#9318).
3053
c3c9e25e
KH
30542011-12-05 Kenichi Handa <handa@m17n.org>
3055
3056 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
3057 return Qnil (Bug#8046, Bug#10193).
3058
5eb05ea3
KH
30592011-12-05 Kenichi Handa <handa@m17n.org>
3060
3061 * coding.c (encode_designation_at_bol): New args charbuf_end and
3062 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
3063 (coding_set_source): Return how many bytes coding->source was
3064 relocated.
3065 (coding_set_destination): Return how many bytes
3066 coding->destination was relocated.
3067 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 3068 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
3069
30702011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
3071
3072 * coding.c (CODING_CHAR_CHARSET_P): New macro.
3073 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
3074 macro (Bug#9318).
3075
30762011-12-05 Andreas Schwab <schwab@linux-m68k.org>
3077
3078 The following changes are to fix Bug#9318.
3079
a79703f5 3080 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
3081 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
3082 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 3083 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 3084
7dbda6df
JB
30852011-12-05 Juanma Barranquero <lekktu@gmail.com>
3086
3087 * lisp.h (process_quit_flag): Fix external declaration.
3088
6d5eb5b0
SM
30892011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
3090
3091 Don't macro-inline non-performance-critical code.
3092 * eval.c (process_quit_flag): New function.
3093 * lisp.h (QUIT): Use it.
3094
a0c3fad0
JD
30952011-12-04 Jan Djärv <jan.h.d@swipnet.se>
3096
3097 * nsfns.m (get_geometry_from_preferences): New function.
3098 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
3099
6c07aac2
AS
31002011-12-04 Andreas Schwab <schwab@linux-m68k.org>
3101
3102 * emacs.c (Qkill_emacs): Define.
3103 (syms_of_emacs): Initialize it.
3104 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
3105 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
3106 (quit_throw_to_read_char): Add parameter `from_signal'.
3107 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
3108 * lisp.h (QUIT): Call Fkill_emacs if requested.
3109
c052ead4
JD
31102011-12-03 Jan Djärv <jan.h.d@swipnet.se>
3111
3112 * widget.c (update_wm_hints): Return if wmshell is null.
3113 (widget_update_wm_size_hints): New function.
3114
3115 * widget.h (widget_update_wm_size_hints): Declare.
3116
3117 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
3118 widget_update_wm_size_hints (Bug#10104).
3119
9e49252b
EZ
31202011-12-03 Eli Zaretskii <eliz@gnu.org>
3121
3122 * xdisp.c (handle_invisible_prop): If the invisible text ends just
3123 before a newline, prepare the bidi iterator for consuming the
3124 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 3125 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 3126
02b16839
JL
31272011-12-02 Juri Linkov <juri@jurta.org>
3128
3129 * search.c (Fword_search_regexp): New Lisp function created from
3130 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
3131 (Fword_search_backward, Fword_search_forward)
3132 (Fword_search_backward_lax, Fword_search_forward_lax):
3133 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
3134 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
3135
0068070e
SM
31362011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
3137
3138 * fileio.c (Finsert_file_contents): Move after-change-function call
3139 to before the "handled:" label, since all "goto handled" appear in
3140 cases where the *-change-functions have already been properly called
3141 (bug#10117).
3142
3360a3fc
AS
31432011-12-01 Andreas Schwab <schwab@linux-m68k.org>
3144
3145 * keyboard.c (interrupt_signal): Don't call kill-emacs when
3146 waiting for input. (Bug#10169)
3147
73d6c093
EZ
31482011-11-30 Eli Zaretskii <eliz@gnu.org>
3149
3150 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
3151 verifies glyph row's hash code--we have just reallocated the
3152 glyphs, so their contents can be complete garbage. (Bug#10164)
3153
febe6bea
JB
31542011-11-30 Juanma Barranquero <lekktu@gmail.com>
3155
3156 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
3157
801a4313
EZ
31582011-11-30 Eli Zaretskii <eliz@gnu.org>
3159
3160 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
3161 attributes are tested _before_ calling verify_row_hash, to protect
3162 against GCC re-ordering of the tests. (Bug#10164)
3163
2b56b87e
JD
31642011-11-29 Jan Djärv <jan.h.d@swipnet.se>
3165
3166 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
3167
3168 * xterm.c (handle_one_xevent): Only set async_visible and friends
3169 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 3170 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
3171 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
3172
dbf31225
PE
31732011-11-28 Paul Eggert <eggert@cs.ucla.edu>
3174
3175 Remove GCPRO-related macros that exist only to avoid shadowing locals.
3176 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
3177 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
3178 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3179 All uses changed to use GCPRO1 etc.
3180 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
3181 Revert to old implementation (i.e., before 2011-03-11).
3182
1305621b
YM
31832011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3184
3185 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
3186 of scroll runs so as to avoid assigning disabled bogus rows and
3187 unnecessary graphics copy operations.
3188
8c9afb46
EZ
31892011-11-27 Eli Zaretskii <eliz@gnu.org>
3190
3191 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
3192 (snprintf) [_MSC_VER]: Redirect to _snprintf.
3193 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
3194 (malloc, free, realloc, calloc): Redirect to e_* only when
3195 compiling Emacs.
3196
3197 * lisp.h (GCTYPEBITS): Move before first use.
3198 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
3199 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
3200 this macro definition.
3201
3202 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
3203 _MSC_VER.
3204
54e9e3bf
JD
32052011-11-27 Jan Djärv <jan.h.d@swipnet.se>
3206
6d5eb5b0
SM
3207 * gtkutil.c (xg_create_frame_widgets):
3208 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
3209 present with Gtk+ 2.0.
3210
83aca1cb
PE
32112011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3212
3213 * fileio.c (Finsert_file_contents): Undo previous change; see
3214 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
3215
5b76caa4
PE
32162011-11-26 Paul Eggert <eggert@cs.ucla.edu>
3217
3218 Rename locals to avoid shadowing.
3219 * fileio.c (Finsert_file_contents):
3220 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
3221 * process.c (wait_reading_process_output):
3222 Rename inner 'proc' to 'p' to avoid shadowing.
3223 Indent for consistency with usual Emacs style.
3224
8c535114
EZ
32252011-11-25 Eli Zaretskii <eliz@gnu.org>
3226
3227 * xdisp.c (redisplay_window): If cursor row is not fully visible
3228 after recentering, and scroll-conservatively is set to a large
3229 number, scroll window by a few more lines to make the cursor fully
3230 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
3231 (start_display): Don't move to the next line if the display should
3232 start at a newline that is part of a display vector or an overlay
3233 string. (Bug#10119)
8c535114 3234
fa4fdb5c
JL
32352011-11-24 Juri Linkov <juri@jurta.org>
3236
3237 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
3238 after the `MagickPingImage' call. (Bug#10112)
3239
90ec88df
CY
32402011-11-23 Chong Yidong <cyd@gnu.org>
3241
3242 * window.c (Fcoordinates_in_window_p): Accept only live windows.
3243
56e2e794
MR
32442011-11-23 Martin Rudalics <rudalics@gmx.at>
3245
3246 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
3247 making another buffer current. (Bug#10114)
3248
b6e64c41
GM
32492011-11-23 Glenn Morris <rgm@gnu.org>
3250
3251 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
3252
6b21de18
CY
32532011-11-23 Chong Yidong <cyd@gnu.org>
3254
3255 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
3256 using it (Bug#5984).
3257
b12cd789
EZ
32582011-11-22 Eli Zaretskii <eliz@gnu.org>
3259
3260 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
3261 and header-lines, as they don't have one computed for them.
3262 (Bug#10098)
3263
3264 * .gdbinit (prow): Make displayed values more self-explaining.
3265 Add row's hash code.
3266
261b6fd4
LMI
32672011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
3268
3269 * process.c (wait_reading_process_output): Fix asynchrounous
3270 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 3271 (wait_reading_process_output): Add comment and URL.
261b6fd4 3272
e7cfd277
JD
32732011-11-21 Jan Djärv <jan.h.d@swipnet.se>
3274
3275 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
3276
a9b9b7f5
CY
32772011-11-21 Chong Yidong <cyd@gnu.org>
3278
3279 * window.c (Fnext_window, Fprevious_window): Doc fix.
3280
b0d15b4f
SM
32812011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3282
3283 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
3284
fe7a3057
JB
32852011-11-20 Juanma Barranquero <lekktu@gmail.com>
3286
3287 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
3288
d2999b1a
MR
32892011-11-20 Martin Rudalics <rudalics@gmx.at>
3290
3291 * window.c (Fset_window_combination_limit): Rename argument
3292 STATUS to LIMIT.
3293 (Vwindow_combination_limit): Remove "status" from doc-string.
3294
d5ff9cd0
AS
32952011-11-20 Andreas Schwab <schwab@linux-m68k.org>
3296
3297 * m/ibms390.h: Remove.
3298 * m/ibms390x.h: Don't include "ibms390.h".
3299
a5bb9bd3
SM
33002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
3301
3302 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
3303 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
3304
cd1181db
JB
33052011-11-20 Juanma Barranquero <lekktu@gmail.com>
3306
3307 * casetab.c (Fset_case_table):
3308 * charset.c (Fcharset_after): Fix typos.
3309
615a3b8d 33102011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 3311
17e845af
PE
3312 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
3313 Otherwise, valgrind does not work on some platforms.
3314 Problem reported by Andreas Schwab in
6a0bf43d
PE
3315 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
3316 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
3317 is set, removing the need for VIRT_ADDRESS_VARIES.
3318 (PURE_P): Use a more-efficient implementation that needs just one
3319 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
3320 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
3321 to 4 (xorl, subq, cmpq, setbe).
3322 * alloc.c (pure): Always extern now, since that's the
3323 VIRT_ADDR_VARIES behavior.
3324 (PURE_POINTER_P): Use a single comparison, not two, for
3325 consistency with the new puresize.h.
3326 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
3327 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
3328 Remove VIRT_ADDR_VARIES no longer needed.
3329
f8fe6f96
EZ
33302011-11-19 Eli Zaretskii <eliz@gnu.org>
3331
3332 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
3333 (erase_phys_cursor, update_window_cursor, show_mouse_face)
3334 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
3335 behave as if the cursor position were at the window margin.
3336
3337 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
3338 and the cursor position is out of bounds, behave as if the cursor
3339 position were at the window margin. (Bug#10075)
3340
df05a53c
CY
33412011-11-18 Chong Yidong <cyd@gnu.org>
3342
3343 * window.c (Fwindow_combination_limit): Make first argument
3344 non-optional, since it is meaningless for live windows like the
3345 selected window.
61ccba97 3346
2071918e
DA
33472011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
3348
3349 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
3350
b50a28de
SM
33512011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
3352
3353 * intervals.c: Fix grafting over the whole buffer (bug#10071).
3354 (graft_intervals_into_buffer): Simplify.
3355
015137db
EZ
33562011-11-18 Eli Zaretskii <eliz@gnu.org>
3357
3358 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
3359 hash values of the two rows.
3360 (copy_row_except_pointers): Preserve the used[] arrays and the
3361 hash values of the two rows. (Bug#10035)
68c95424 3362 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
3363
3364 * xdisp.c (row_hash): New function, body extracted from
3365 compute_line_metrics.
3366 (compute_line_metrics): Call row_hash, instead of computing the
3367 hash code inline.
3368
3369 * dispnew.c (verify_row_hash): Call row_hash for computing the
3370 hash code of a row, instead of duplicating code from xdisp.c.
3371
3372 * dispextern.h (row_hash): Add prototype.
3373
a2addb04
TH
33742011-11-18 Tassilo Horn <tassilo@member.fsf.org>
3375
3376 * frame.c (delete_frame): Don't delete the terminal when the last
3377 X frame is closed if emacs is built with GTK toolkit.
3378
df85d315
JB
33792011-11-17 Juanma Barranquero <lekktu@gmail.com>
3380
3381 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
3382
a0c2d0ae
MR
33832011-11-17 Martin Rudalics <rudalics@gmx.at>
3384
3385 * window.c (Vwindow_splits): Rename to
3386 Vwindow_combination_resize. Suggested by Juri Linkov.
3387 (Fsplit_window_internal): Use Vwindow_combination_resize instead
3388 of Vwindow_splits.
3389
58179cce
JB
33902011-11-16 Juanma Barranquero <lekktu@gmail.com>
3391
7877f373
JB
3392 * nsfns.m (Fns_font_name):
3393 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 3394
b6f67890
MR
33952011-11-16 Martin Rudalics <rudalics@gmx.at>
3396
3397 * window.h (window): Rename slot "nest" to "combination_limit".
3398 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
3399 (Fset_window_nest): Rename to Fset_window_combination_limit.
3400 (Vwindow_nest): Rename to Vwindow_combination_limit.
3401 (recombine_windows, make_parent_window, make_window)
3402 (Fsplit_window_internal, saved_window)
3403 (Fset_window_configuration, save_window_save): Rename all
3404 occurrences of window_nest to window_combination_limit.
3405
c7015153
JB
34062011-11-15 Juanma Barranquero <lekktu@gmail.com>
3407
3408 * image.c (imagemagick_load_image): Fix typo.
3409
322ad6ec
EZ
34102011-11-14 Eli Zaretskii <eliz@gnu.org>
3411
3412 * xdisp.c (display_line): Move the call to
3413 highlight_trailing_whitespace before the call to
3414 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
3415 faces of all the glyphs to compute ROW's hash value.
3416 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 3417
f067b8ec
JB
34182011-11-14 Juanma Barranquero <lekktu@gmail.com>
3419
3420 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
3421 just return (bug#10044).
3422
1e5b2111
EZ
34232011-11-12 Eli Zaretskii <eliz@gnu.org>
3424
7ef3cbd5
EZ
3425 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
3426 with user-defined heap size. Bump the default size of the temacs
3427 heap to 27MB, to avoid memory warning when running temacs.
3428 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
3429
1e5b2111
EZ
3430 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
3431 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
3432 (verify_row_hash) [XASSERTS]: New function.
3433 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
3434 that the hash value of glyph rows is correct.
1e5b2111 3435
89d61221
MR
34362011-11-12 Martin Rudalics <rudalics@gmx.at>
3437
3438 * window.h (window): Remove splits slot.
3439 * window.c (Fwindow_splits, Fset_window_splits): Remove.
3440 (Fdelete_other_windows_internal, make_parent_window)
3441 (make_window, Fsplit_window_internal, Fdelete_window_internal)
3442 (Fset_window_configuration, save_window_save): Don't deal with
3443 split status of windows.
3444 (saved_window): Remove splits slot.
3445 (Vwindow_splits): Rewrite doc-string.
3446
97f18cc8
JD
34472011-11-11 Jan Djärv <jan.h.d@swipnet.se>
3448
3449 * xfns.c (unwind_create_frame):
3450 * nsfns.m (unwind_create_frame):
3451 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
3452 Vframe_list (Bug#9999).
3453
22a648b4
DA
34542011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
3455
0b381c7e 3456 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 3457
659afede
KH
34582011-11-11 Kenichi Handa <handa@m17n.org>
3459
3460 * callproc.c (Fcall_process): Set the member dst_multibyte of
3461 process_coding.
3462
9ac0394b
KH
34632011-11-11 Johan Bockgård <bojohan@gnu.org>
3464
3465 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
3466 avoid a crash (bug#9496).
3467
2fbdc249
CY
34682011-11-09 Chong Yidong <cyd@gnu.org>
3469
3470 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
3471 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
3472
ac6b1f81
PE
34732011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3474
3475 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
3476
09db192c
PE
34772011-11-08 Paul Eggert <eggert@cs.ucla.edu>
3478
3479 Avoid some portability problems by eschewing 'extern inline' functions.
3480 The trivial performance wins aren't worth the portability hassles; see
3481 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
3482 et seq.
3483 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3484 (window_box_width, window_box_left, window_box_left_offset)
3485 (window_box_right, window_box_right_offset): Undo previous change,
3486 by removing the "extern"s.
3487 * intervals.c (adjust_intervals_for_insertion)
3488 (adjust_intervals_for_deletion): Undo previous change,
3489 making these static again.
3490 (offset_intervals, temp_set_point_both, temp_set_point)
3491 (copy_intervals_to_string): No longer inline.
3492 * xdisp.c (window_text_bottom_y, window_box_width)
3493 (window_box_height, window_box_left_offset)
3494 (window_box_right_offset, window_box_left, window_box_right)
3495 (window_box): No longer inline.
3496
105216ed
CY
34972011-11-08 Chong Yidong <cyd@gnu.org>
3498
3499 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
3500 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
3501 Signal an error if not a live window.
105216ed
CY
3502 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
3503 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
3504
ae9e237f
JB
35052011-11-07 Juanma Barranquero <lekktu@gmail.com>
3506
3507 * lisp.h (syms_of_abbrev): Remove declaration.
3508 Reported by CHENG Gao <chenggao@royau.me>.
3509
c7aa8333
EZ
35102011-11-07 Eli Zaretskii <eliz@gnu.org>
3511
3512 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
3513 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
3514 of temacs in GUI mode.
3515
be7f5545
MR
35162011-11-07 Martin Rudalics <rudalics@gmx.at>
3517
3518 * window.h: Declare delete_all_child_windows instead of
3519 delete_all_subwindows.
3520 * window.c (Fwindow_nest, Fset_window_nest)
3521 (Fset_window_new_total, Fset_window_new_normal)
3522 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
3523 (delete_all_subwindows): Rename to delete_all_child_windows.
3524 (Fdelete_other_windows_internal, Fset_window_configuration):
3525 Call delete_all_child_windows instead of delete_all_subwindows.
3526 * frame.c (delete_frame): Call delete_all_child_windows instead
3527 of delete_all_subwindows.
3528
ca78dc43
PE
35292011-11-07 Paul Eggert <eggert@cs.ucla.edu>
3530
3531 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
3532 This is also needed for porting to any host where GC_MARK_STACK is
3533 not GC_MAKE_GCPROS_NOOPS.
3534 (which_symbols): Use it.
3535
a0241d01
KH
35362011-11-07 Kenichi Handa <handa@m17n.org>
3537
3538 * coding.c (coding_set_destination): Check coding->src_pos only
3539 when coding->src_object is a buffer (bug#9910).
3540
3541 * process.c (send_process): Set the member src_multibyte of coding
3542 to 0 (bug#9911) when sending a unibyte text.
3543
3544 * callproc.c (Fcall_process): Set the member src_multibyte of
3545 process_coding to 0 (bug#9912).
3546
a64bfdfa 35472011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
3548
3549 * xmenu.c (cleanup_widget_value_tree): New function.
3550 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
3551 calling free_menubar_widget_value_tree directly (Bug#9830).
3552
cb41b32a
PE
35532011-11-06 Paul Eggert <eggert@cs.ucla.edu>
3554
3555 Fix some portability problems with 'inline'.
3556 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
3557 (window_box_width, window_box_left, window_box_left_offset)
3558 (window_box_right, window_box_right_offset): Declare extern.
3559 Otherwise, these inline functions do not conform to C99 and
3560 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
3561 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
3562 * intervals.c (adjust_intervals_for_insertion)
3563 (adjust_intervals_for_deletion): Now extern, because otherwise the
3564 extern inline functions 'offset_intervals' couldn't refer to it.
3565 (static_offset_intervals): Remove.
3566 (offset_intervals): Rewrite using the old contents of
3567 static_offset_intervals. The old version didn't conform to C99
3568 because an extern inline function contained a reference to an
3569 identifier with static linkage.
3570
b7041366
AS
35712011-11-06 Andreas Schwab <schwab@linux-m68k.org>
3572
3573 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
3574 GC.
3575
88a37c4d
EZ
35762011-11-06 Eli Zaretskii <eliz@gnu.org>
3577
3578 * xdisp.c (init_iterator, reseat_to_string): Don't set the
3579 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
3580 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
3581 return Qleft_to_right.
3582
49745b39
CY
35832011-11-06 Chong Yidong <cyd@gnu.org>
3584
3585 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
3586 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
3587 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
3588 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
3589 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
3590 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
3591 (Fwindow_vscroll): Doc fix.
3592 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
3593 argument, since it makes no sense to pass a live window and for
3594 consistency with window-child.
3595
1f05cd82
CS
35962011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
3597
3598 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
3599 support MSVC.
3600
22610910
JR
36012011-11-05 Jason Rumney <jasonr@gnu.org>
3602
3603 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
3604 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
3605 fonts (Bug#6029).
3606 (add_font_entity_to_list): Fix logic errors in mixed boolean and
3607 bitwise arithmetic preventing use of unicode-sip and non-truetype
3608 opentype fonts.
3609
a06776b2
EZ
36102011-11-05 Eli Zaretskii <eliz@gnu.org>
3611
3ad924ba
EZ
3612 * s/ms-w32.h (fstat, stat, utime): Move redirections to
3613 "emacs"-only part.
3614
a06776b2
EZ
3615 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
3616 initialization code to keep similarity to xfns.c after changes
3617 from 2011-11-05.
3618
c9e7db78
JD
36192011-11-05 Jan Djärv <jan.h.d@swipnet.se>
3620
a97f8f3f
JD
3621 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
3622 (unwind_create_frame): New function (Bug#9943).
3623 (Fx_create_frame): Restructure code to be more similar to the one in
3624 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
3625 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
3626 Move terminal->reference_count++ just before making the frame official
3627 (Bug#9943).
3628
3629 * nsterm.m (x_free_frame_resources): New function.
3630 (x_destroy_window): Move code to x_free_frame_resources.
3631
c9e7db78 3632 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
3633 (Fx_create_frame, x_create_tip_frame):
3634 Move terminal->reference_count++ just before making the frame
75f1671a 3635 official. Move initialization of image_cache_refcount and
c9e7db78
JD
3636 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
3637
a6fc3b5c
EZ
36382011-11-05 Eli Zaretskii <eliz@gnu.org>
3639
3640 Support MSVC build with newer versions of Visual Studio.
3641 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
3642 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
3643 nt/gmake.defs.
3644
3645 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
3646 which are not supported by MSVC.
3647 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
3648 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
3649 bitfields.
3650 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
3651 types in bitfields.
3652 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
3653
3654 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
3655
58179cce 36562011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
3657
3658 Support MSVC build with newer versions of Visual Studio.
3659 * w32.c: Don't include w32api.h for MSVC.
3660 (init_environment) [_MSC_VER]: Call sys_access, not _access.
3661
3662 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
3663 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
3664 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
3665 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
3666 e_* cousins.
3667 (alloca) [_MSC_VER]: Define to _alloca.
3668
3669 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
3670
3671 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
3672
a58c13ed
EZ
36732011-11-04 Eli Zaretskii <eliz@gnu.org>
3674
3675 * xdisp.c (note_mouse_highlight): If either of
3676 previous/next-single-property-change returns nil, treat that as
3677 the beginning or the end of the buffer. (Bug#9955)
3678
fe0b6370
JD
36792011-11-04 Jan Djärv <jan.h.d@swipnet.se>
3680
a58c13ed 3681 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
3682 label is not null (Bug#9951).
3683 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
3684 may be NULL.
3685
89bd5ee1
EZ
36862011-11-04 Eli Zaretskii <eliz@gnu.org>
3687
3688 * window.c (Fwindow_body_size): Mention in the doc string that the
3689 return value is in frame's canonical units. (Bug#9949)
3690
84c3edb9
EZ
36912011-11-03 Eli Zaretskii <eliz@gnu.org>
3692
4e2fb5c7
EZ
3693 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
3694
84c3edb9 3695 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 3696 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 3697 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 3698
bc17a887
EZ
36992011-11-01 Eli Zaretskii <eliz@gnu.org>
3700
3701 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
3702 Don't stop backward scan on the continuation glyph, even though
3703 its CHARPOS is positive.
6d5eb5b0
SM
3704 (mouse_face_from_buffer_pos, note_mouse_highlight):
3705 Rename cover_string to disp_string.
bc17a887 3706
4ee88440
MR
37072011-11-01 Martin Rudalics <rudalics@gmx.at>
3708
3709 * window.c (temp_output_buffer_show): Don't use
3710 Vtemp_buffer_show_specifiers.
3711 (Vtemp_buffer_show_specifiers): Remove unused variable.
3712
c2ff3c02
EZ
37132011-10-30 Eli Zaretskii <eliz@gnu.org>
3714
3715 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
3716 past the beginning of the current glyph matrix.
3717
58179cce 37182011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
3719
3720 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
3721 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
3722 HAVE_GTK3 (Bug#9869).
b77a6a7f 3723
3b574623
JD
3724 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
3725 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
3726
b77a6a7f
JD
3727 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
3728
3729 * xterm.c: Declare x_handle_net_wm_state to return int.
3730 (handle_one_xevent): Check if we are iconified but don't have
3731 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
3732 (get_current_wm_state): Return non-zero if not hidden,
3733 check for _NET_WM_STATE_HIDDEN (Bug#9893).
3734 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
3735 (x_handle_net_wm_state): Return what get_current_wm_state returns.
3736 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
3737
196e41e4
PE
37382011-10-29 Paul Eggert <eggert@cs.ucla.edu>
3739
3740 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
3741 so that this new function doesn't get optimized away by a
3742 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
3743
021f2e1a
AS
37442011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3745
3746 * frame.h (MOUSE_HL_INFO): Remove excess parens.
3747
8b058d44
EZ
37482011-10-29 Eli Zaretskii <eliz@gnu.org>
3749
3750 Fix the `xbytecode' command.
3751 * .gdbinit (xprintbytestr): New command.
b50a28de 3752 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
3753 (xbytecode): Print the byte-code string as well.
3754
4452fb80
EZ
37552011-10-29 Kim Storm <storm@cua.dk>
3756
8b058d44
EZ
3757 * alloc.c (which_symbols): New function.
3758
21b72067
AS
37592011-10-29 Andreas Schwab <schwab@linux-m68k.org>
3760
3761 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
3762 line. (Bug#9903)
3763
83ed7b5c
GM
37642011-10-29 Glenn Morris <rgm@gnu.org>
3765
3766 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
3767 Not clear what it was for, and it causes various bugs. (Bug#9839)
3768
5a7a728b
EZ
37692011-10-28 Eli Zaretskii <eliz@gnu.org>
3770
3771 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
3772 possible random value that matches one of those tested as
3773 condition to clear the mouse face.
3774
d3d0842f
CY
37752011-10-28 Chong Yidong <cyd@gnu.org>
3776
3777 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
3778
31b39d13
DN
37792011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
3780
3781 * window.c (make_window): Initialize phys_cursor_on_p.
3782
9aba6043
SM
37832011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
3784
3785 * lisp.h (struct Lisp_Symbol): Update comments.
3786
c20992f4
JB
37872011-10-28 Juanma Barranquero <lekktu@gmail.com>
3788
3789 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
3790
db4f02f2
EZ
37912011-10-28 Eli Zaretskii <eliz@gnu.org>
3792
3793 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
3794 <oslsachem@gmail.com> for helping to debug this.
3795
3796 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
3797 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
3798 (g_b_init_get_glyph_outline_w): New static variables.
3799 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
3800 (GetGlyphOutlineW_Proc): New typedefs.
3801 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
3802 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
3803 New functions.
3804 (w32font_open_internal, compute_metrics):
3805 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
3806 instead of calling the "wide" APIs directly.
3807
3808 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
3809
3810 * w32.h (syms_of_w32font): Add prototype.
3811
87e68db4
JB
38122011-10-27 Juanma Barranquero <lekktu@gmail.com>
3813
3814 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
3815 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
3816 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
3817 (Fmove_to_window_line): Doc fix.
3818
435c1d67
CY
38192011-10-27 Chong Yidong <cyd@gnu.org>
3820
3821 * process.c (make_process): Set gnutls_state to NULL.
3822
3823 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
3824 non-NULL, regardless of GNUTLS_INITSTAGE.
3825 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
3826 an error. Set process slots as soon as we allocate them.
3827
3828 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
3829
9c6c6f49
CY
38302011-10-27 Chong Yidong <cyd@gnu.org>
3831
9aba6043
SM
3832 * gnutls.c (emacs_gnutls_deinit): New function.
3833 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
3834 (Fgnutls_deinit, Fgnutls_boot): Use it.
3835
3836 * process.c (make_process): Initialize GnuTLS credentials to NULL.
3837 (deactivate_process): Call emacs_gnutls_deinit.
3838
657d08d3
JB
38392011-10-27 Juanma Barranquero <lekktu@gmail.com>
3840
3841 * image.c (x_create_x_image_and_pixmap):
3842 * w32.c (sys_rename, w32_delayed_load):
3843 * w32font.c (fill_in_logfont):
3844 * w32reg.c (x_get_string_resource): Silence compiler warnings.
3845
5430d399
JB
38462011-10-26 Juanma Barranquero <lekktu@gmail.com>
3847
3848 * w32fns.c (w32_default_color_map): New function,
3849 extracted from Fw32_default_color_map.
a7ef684b 3850 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 3851
fe0055fa
PE
38522011-10-25 Paul Eggert <eggert@cs.ucla.edu>
3853
3854 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
3855
e6346438
SM
38562011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
3857
3858 * keyboard.c (test_undefined): New function (bug#9751).
3859 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
3860
e112cc37
ET
38612011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
3862
3863 * sysdep.c (init_sys_modes): Fix the check for the controlling
3864 terminal (Bug#6649).
3865
7b5d6677
EZ
38662011-10-20 Eli Zaretskii <eliz@gnu.org>
3867
3868 * dispextern.h (struct bidi_it): New member next_en_type.
3869
3870 * bidi.c (bidi_line_init): Initialize the next_en_type member.
3871 (bidi_resolve_explicit_1): When next_en_pos is valid for the
3872 current character, check also for next_en_type being WEAK_EN.
3873 (bidi_resolve_weak): Don't enter the expensive loop if the current
3874 position is before next_en_pos. Record the bidi type of the first
3875 non-ET, non-BN character we find, in addition to its position.
3876 (bidi_level_of_next_char): Invalidate next_en_type when
3877 next_en_pos is over-stepped.
3878
7da0b018
PE
38792011-10-20 Paul Eggert <eggert@cs.ucla.edu>
3880
3881 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
3882 * editfns.c: Rewrite current-time-zone so that it invokes
3883 the equivalent of (format-time-string "%Z") to get the time zone name.
3884 This fixes a bug when the time zone name contains characters that
3885 need converting from the system time locale to Emacs internal format.
3886 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
3887 that patch fixed format-time-string to do the conversion, but
3888 I forgot to fix current-time-zone.
3889 (format_time_string): New function, containing most of
3890 what Fformat_time_string used to contain.
3891 (Fformat_time_string): Rewrite in terms of format_time_string.
3892 This doesn't change this function's behavior.
3893 (current-time-zone): Rewrite to use format_time_string.
3894 This fixes the bug reported by Michael Schierl in
3895 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
3896 Jason Rumney's 2007-06-07 change worked around this bug, but
3897 didn't fix it.
3898 * systime.h (tzname, timezone): Remove no-longer-used declarations.
3899
8547b010
EZ
39002011-10-19 Eli Zaretskii <eliz@gnu.org>
3901
3902 * xdisp.c (start_display): If the character at POS is displayed
3903 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
3904 (try_window_reusing_current_matrix): If a line ends in a display
3905 vector or the next line starts in a display vector, continue
3906 redrawing the window even though the character position of
3907 start_row was reached.
8547b010
EZ
3908 (Bug#9771, part 2)
3909
4e948d15
CY
39102011-10-18 Chong Yidong <cyd@gnu.org>
3911
3912 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
3913 with nobreak-char-display too.
3914
4787455f
EZ
39152011-10-18 Eli Zaretskii <eliz@gnu.org>
3916
3917 Fix part 3 of bug#9771.
3918 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
3919 (bidi_resolve_neutral): Don't enter the expensive loop looking for
3920 non-neutral characters if the current character is a paragraph
3921 separator (a.k.a. Newline). This avoids running the same
3922 expensive loop twice, once when we consume the preceding newline
3923 and the other time when the line actually needs to be displayed.
3924 Avoid the loop when we see neutrals on the base embedding level
3925 following a character whose directionality is the same as the
3926 paragraph's. This avoids running the expensive loop when a line
3927 ends in a long sequence of neutrals, like control characters.
3928 Add assertion against STRONG_AL type. Slightly rearrange code
3929 that determines the type of a neutral given the first non-neutral
3930 that follows it.
3931 (bidi_level_of_next_char): Set next_en_pos to zero when
3932 invalidating its info.
3933
2c91f553
EZ
39342011-10-17 Eli Zaretskii <eliz@gnu.org>
3935
3936 * xdisp.c (push_display_prop): Determine whether to record string
3937 or buffer position by IT->string, not by IT->method. Allow
3938 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
3939 (move_it_vertically_backward): Don't look for character position
3940 immediately after the newline when in a continuation line.
3941 (Bug#9771, part 1)
2c91f553 3942
c7b08b0d
MR
39432011-10-15 Martin Rudalics <rudalics@gmx.at>
3944
3945 * window.c (coordinates_in_window): Rewrite and delabelize
3946 vertical border check. (Bug#5357) (Bug#9618)
3947
6b02f655
SM
39482011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
3949
3950 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
3951 errors in XSetWindowBorder (bug#9310).
3952
81d40c92
DA
39532011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
3954
3955 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
3956 avoid crash when xmalloc overrun checking is enabled.
3957
d4172c3b
EZ
39582011-10-13 Eli Zaretskii <eliz@gnu.org>
3959
3960 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
3961 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
3962 cursor motion with <left> and <right> arrow keys.
3963
3964 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
3965 some callers set that themselves.
3966
b00eea75
EZ
39672011-10-12 Eli Zaretskii <eliz@gnu.org>
3968
3969 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
3970 display string and the previous row comes from the same string and
3971 is empty. (Bug#9739) (Bug#9738)
3972
8fe012c4
SM
39732011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
3974
3975 * doc.c (get_doc_string): Encode file name (bug#9735).
3976
0074aef2
EZ
39772011-10-12 Eli Zaretskii <eliz@gnu.org>
3978
79beb178
EZ
3979 * bidi.c (bidi_level_of_next_char):
3980 * xdisp.c (get_visually_first_element): Remove old incorrect
3981 comments regarding the Unicode Line Separator character.
3982
0074aef2
EZ
3983 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
3984
6e4b3fbe
DA
39852011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
3986
3987 * alloc.c (Fgc_status): Do not access beyond zombies array
3988 boundary if nzombies > MAX_ZOMBIES.
3989 * alloc.c (dump_zombies): Add missing format specifier.
3990
0324f3af
PE
39912011-10-12 Paul Eggert <eggert@cs.ucla.edu>
3992
b5525cac
PE
3993 * xdisp.c (set_cursor_from_row): Simplify conditionals,
3994 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
3995
0324f3af
PE
3996 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
3997 Some packages use them to denote characters with modifiers.
3998
e9b5f888
AS
39992011-10-11 Andreas Schwab <schwab@linux-m68k.org>
4000
4001 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
4002 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
4003 matching a pp-number. Rename parameter var to var1.
4004
127827c0
SM
40052011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
4006
4007 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
4008
c8fd3bd0
GM
40092011-10-08 Glenn Morris <rgm@gnu.org>
4010
4011 * callint.c (Fcall_interactively): Give a more explicit error for the
4012 'c' case with a non-character input. (Bug#8479)
4013
352ec8ff
EZ
40142011-10-08 Eli Zaretskii <eliz@gnu.org>
4015
03669ccb
EZ
4016 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
4017 lines.
7061c986
EZ
4018 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
4019 lines that are hscrolled on the left.
03669ccb 4020
352ec8ff
EZ
4021 * dispnew.c (buffer_posn_from_coords): Account for a possible
4022 presence of header-line. (Bug#4426)
4023
a66cfb1c
SM
40242011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
4025
6b02f655
SM
4026 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
4027 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 4028
7c5ee88e
PE
40292011-10-07 Paul Eggert <eggert@cs.ucla.edu>
4030
4031 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
4032 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
4033 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
4034 this makes Emacs dump core during garbage collection on rare
4035 occasions. sizeof is obviously inferior to offsetof here, so
4036 stick with offsetof.
4037 (GC_POINTER_ALIGNMENT): New macro.
4038 (mark_memory): Omit 3rd (offset) arg; caller changed.
4039 Don't assume EMACS_INT alignment is the same as pointer alignment.
4040
df1bbe5b
SM
40412011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
4042
4043 * keyboard.c (read_key_sequence_remapped): New var.
4044 (read_key_sequence): Compute remapping in the right buffer.
4045 (command_loop_1): Use read_key_sequence's remapping directly.
4046
51553db6
SM
40472011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
4048
32c1fffd
SM
4049 * dired.c (file_name_completion): Don't expand file name.
4050 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
4051 before checking file name handler.
4052
51553db6
SM
4053 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
4054 they've been requested explicitly (bug#9591).
4055
b6bd1599 40562011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
4057
4058 * keymap.c (Fsingle_key_description): Use make_specified_string
4059 instead of build_string to build string from push_key_description.
4060 (Bug#5193)
4061
f701dc2a
PE
40622011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4063
4222c55d
PE
4064 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
4065 This fixes a Y2038 bug on 64-bit hosts.
4066 * buffer.c (reset_buffer):
4067 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
4068 (Fclear_buffer_auto_save_failure):
4069 Use 0, not -1, to represent an unset failure time, since time_t
4070 might not be signed.
4071
f701dc2a
PE
4072 Remove dependency on glibc malloc internals.
4073 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4074 Move back here from lisp.h, but with their new implementations.
4075 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4076 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
4077 * charset.c (charset_table_init): New static var.
4078 (syms_of_charset): Use it instead of xmalloc. This removes a
4079 dependency on glibc malloc internals. See Eli Zaretskii's comment in
4080 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
4081 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4082 Move back to alloc.c.
4083 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4084 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
4085
9ceebf39
JD
40862011-09-30 Jan Djärv <jan.h.d@swipnet.se>
4087
4088 * nsterm.m (windowDidResize): Call x_set_window_size only when
4089 ns_in_resize is true. Otherwise set pixelwidth/height and
4090 call change_frame_size (Bug#9628).
4091
cb993c58
PE
40922011-09-30 Paul Eggert <eggert@cs.ucla.edu>
4093
3930c88b
PE
4094 Port --enable-checking=all to Fedora 14 x86-64.
4095 * charset.c (syms_of_charset): Also account for glibc malloc's
4096 internal overhead when calculating the initial malloc maximum.
4097
cb993c58
PE
4098 Port --enable-checking=all to Fedora 14 x86.
4099 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4100 Move to lisp.h.
4101 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
4102 (overrun_check_realloc, overrun_check_free):
4103 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
4104 That way, xmalloc returns a properly-aligned pointer even if
4105 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
4106 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
4107 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
4108 into account when calculating the initial malloc maximum.
4109 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
4110 Move here from alloc.c, so that charset.c can use it too.
4111 Properly align; the old code wasn't right for common 32-bit hosts
4112 when configured with --enable-checking=all.
4113 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
4114 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
4115
31bed486
EZ
41162011-09-29 Eli Zaretskii <eliz@gnu.org>
4117
04c70788 4118 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
4119 use EDOM.
4120
fbcaa2f3
EZ
41212011-09-28 Eli Zaretskii <eliz@gnu.org>
4122
4123 * xdisp.c (compute_display_string_end): If there's no display
4124 string at CHARPOS, return -1.
4125
4126 * bidi.c (bidi_fetch_char): When compute_display_string_end
4127 returns a negative value, treat the character as a normal
4128 character not covered by a display string. (Bug#9624)
4129
a239d4e9
JB
41302011-09-28 Juanma Barranquero <lekktu@gmail.com>
4131
4132 * lread.c (Fread_from_string): Fix typo in docstring.
4133
88652fd5
EZ
41342011-09-27 Eli Zaretskii <eliz@gnu.org>
4135
4136 * xdisp.c (handle_invisible_prop): If invisible text ends on a
4137 newline, reseat the iterator instead of bidi-iterating there one
4138 character at a time. (Bug#9610)
32c1fffd
SM
4139 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
4140 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 4141
ed497dd4
AS
41422011-09-27 Andreas Schwab <schwab@linux-m68k.org>
4143
4144 * lread.c (readevalloop): Use correct code for NBSP.
4145 (read1): Likewise. (Bug#9608)
4146
b2bf61aa
MA
41472011-09-25 Michael Albinus <michael.albinus@gmx.de>
4148
4149 * dbusbind.c (Fdbus_register_signal): When service is not
4150 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
4151
32bbb17c
GM
41522011-09-25 Glenn Morris <rgm@gnu.org>
4153
4154 * buffer.c (truncate-lines): Doc fix.
4155
94e0933e
CY
41562011-09-24 Chong Yidong <cyd@stupidchicken.com>
4157
4158 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
4159 (Fset_window_next_buffers): Doc fix.
4160
cddde921
GM
41612011-09-24 Glenn Morris <rgm@gnu.org>
4162
4163 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
4164
1260aef1
PE
41652011-09-24 Paul Eggert <eggert@cs.ucla.edu>
4166
25b4bfa0
PE
4167 Fix minor problems found by static checking.
4168 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
4169 * indent.c (Fvertical_motion): Fix == vs = typo.
4170
e3cbd34b
EZ
41712011-09-24 Eli Zaretskii <eliz@gnu.org>
4172
a66cfb1c
SM
4173 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
4174 Default value is now t. Doc fix.
6bf7006f 4175
e3cbd34b 4176 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 4177 logic when moving up, not only when moving down. Fix the
e3cbd34b 4178 confusing name and values of the it_overshoot_expected variable;
32c1fffd 4179 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
4180
4181 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
4182 CHARPOS is covered by a display string which includes newlines.
4183 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
4184 is covered by a display string with embedded newlines.
4185
a3de0cbd
MA
41862011-09-24 Michael Albinus <michael.albinus@gmx.de>
4187
4188 * dbusbind.c (Fdbus_register_signal): Add match rule to
4189 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
4190 (Fdbus_register_method, Vdbus_registered_objects_table):
4191 Fix docstring.
a3de0cbd 4192
b260039d
JM
41932011-09-24 Jim Meyering <meyering@redhat.com>
4194
32c1fffd 4195 do not ignore write error for any output size
b260039d
JM
4196 The previous change was incomplete.
4197 While it makes emacs --batch detect the vast majority of stdout
4198 write failures, errors were still ignored whenever the output size is
4199 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
4200 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
4201 && echo FAIL: ignored write error
4202 FAIL: ignored write error
4203 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
4204 && echo FAIL: ignored write error
4205 FAIL: ignored write error
4206 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
4207
8eca8a7c
AS
42082011-09-23 Andreas Schwab <schwab@linux-m68k.org>
4209
4210 * emacs.c (Fkill_emacs): In noninteractive mode exit
4211 non-successfully if a write error occurred on stdout. (Bug#9574)
4212
3341db62
EZ
42132011-09-21 Eli Zaretskii <eliz@gnu.org>
4214
4215 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
4216 the xassert test.
4217
4218 * dispextern.h (struct it): Update the comment documenting what
4219 can it->OBJECT be.
4220
8c203dbf
EZ
42212011-09-20 Eli Zaretskii <eliz@gnu.org>
4222
4223 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
4224 a display string, extend search for cursor position to end of row.
4225 (find_row_edges): If the row ends in a newline from a display
4226 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
4227 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
4228 (Fcurrent_bidi_paragraph_direction): Fix search for previous
4229 non-empty line. Fixes confusing cursor motion with arrow keys at
4230 the beginning of a line that starts with whitespace.
8c203dbf 4231
a4824228
LMI
42322011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
4233
4234 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
4235 (bug#9493).
4236
33ed493b
CY
42372011-09-18 Chong Yidong <cyd@stupidchicken.com>
4238
4239 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
4240 boolean (Bug#9154).
4241
56cd55c8
EZ
42422011-09-18 Eli Zaretskii <eliz@gnu.org>
4243
4244 * xdisp.c (display_line): Record maximum and minimum buffer
4245 positions even if no glyphs were produced (e.g., by a zero-width
4246 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
4247 buffer positions that will be removed from the glyph row because
4248 they don't fit.
c02dcedf
EZ
4249 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
4250 column is beyond frame width: don't subtract 1 "pixel" when
4251 computing width of the stretch.
3e62b7e0
EZ
4252 (reseat_at_next_visible_line_start): Undo the change made on
4253 2011-09-17 that saved paragraph information and restored it after
4254 the call to `reseat'. (Bug#9545)
56cd55c8 4255
5ed99d36 42562011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
4257
4258 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
4259 and turn window cursor on if cleared (Bug#9415).
4260
5ed99d36 42612011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
4262
4263 * search.c (boyer_moore): Take unibyte characters from pattern
4264 literally. (Bug#9458)
4265
9bade7b2
EZ
42662011-09-18 Eli Zaretskii <eliz@gnu.org>
4267
4268 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
4269
e5e9d610
PE
42702011-09-18 Paul Eggert <eggert@cs.ucla.edu>
4271
87e4427a
PE
4272 Fix minor problem found by static checking.
4273 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
4274 initialized, to pacify gcc -Wuninitialized.
4275
e5e9d610
PE
4276 * fileio.c: Report proper errno when syscall falls.
4277 (Finsert_file_contents): Save and restore errno,
4278 so that report_file_error outputs the correct diagnostic.
4279 (Fwrite_region) [CLASH_DETECTION]: Likewise.
4280
a1674f0b
EZ
42812011-09-18 Eli Zaretskii <eliz@gnu.org>
4282
4283 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
4284
fbfb6dd4
EZ
42852011-09-17 Eli Zaretskii <eliz@gnu.org>
4286
4287 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
4288 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
4289
bb187662
EZ
42902011-09-17 Eli Zaretskii <eliz@gnu.org>
4291
1137e8b8 4292 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 4293 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
4294
4295 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
4296 (bidi_find_paragraph_start): Search back for paragraph beginning
4297 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
4298 (bidi_move_to_visually_next): Only trigger paragraph-related
4299 computations when the last character is a newline or at EOB, not
4300 just any NEUTRAL_B. (Bug#9470)
4301
bb187662
EZ
4302 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4303 truncated lines if point is covered by a display string. (Bug#9524)
4304
2e621251
PE
43052011-09-16 Paul Eggert <eggert@cs.ucla.edu>
4306
4307 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4308 (cons_to_x_long): New function.
4309 (lisp_data_to_selection_data): Use it. Correct the test for
4310 short-versus-long data; it was negated. Break out of vector
4311 loop, for efficiency, when a long datum is discovered.
4312
91a15bc6
SM
43132011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
4314
4315 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
4316
b41c3a35
EZ
43172011-09-16 Eli Zaretskii <eliz@gnu.org>
4318
4319 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
4320 GCC PR/17406) by declaring this function with external scope.
4321
7812ba2d
PE
43222011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4323
4324 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
4325 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
4326
cf7edc2a
AS
43272011-09-15 Andreas Schwab <schwab@linux-m68k.org>
4328
4329 * editfns.c (Fformat): Correctly handle text properties on "%%".
4330
bd01620e
EZ
43312011-09-15 Eli Zaretskii <eliz@gnu.org>
4332
4333 * xterm.c (x_draw_composite_glyph_string_foreground):
4334 * w32term.c (x_draw_composite_glyph_string_foreground):
4335 * term.c (encode_terminal_code):
4336 * composite.c (composition_update_it, get_composition_id):
4337 * xdisp.c (get_next_display_element)
4338 (fill_composite_glyph_string): Add comments about special meaning
4339 of TAB characters in a composition.
4340
a02719a3
PE
43412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
4342
4343 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
4344 This occurs when processing a multibyte format.
4345 Problem reported by Wolfgang Jenker.
a02719a3 4346
72589a3c
JB
43472011-09-15 Johan Bockgård <bojohan@gnu.org>
4348
4349 * xdisp.c (try_cursor_movement): Only check for exact match if
4350 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
4351
1c14176c
PE
43522011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4353
4354 Remove unused external symbols.
4355 * dispextern.h (calc_pixel_width_or_height): Remove decl.
4356 * xdisp.c (calc_pixel_width_or_height): Now static.
4357 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
4358 * indent.c (check_display_width):
4359 * w32term.c: Fix comment to match code.
4360 * xterm.c, xterm.h (x_catching_errors): Remove.
4361
d2eea5b5
PE
43622011-09-14 Paul Eggert <eggert@cs.ucla.edu>
4363
4364 * xselect.c: Use signed conversions more consistently (Bug#9498).
4365 (selection_data_to_lisp_data): Assume incoming selection data are
4366 signed integers, not unsigned. This is to be consistent with
4367 outgoing selection data, which was modified to use signed integers
4368 in as part of the fix to Bug#9196 in response to Jan D.'s comment
4369 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
4370 expects long, not unsigned long.
4371
46888499
EZ
43722011-09-14 Eli Zaretskii <eliz@gnu.org>
4373
4374 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
4375 computation of loop end. Reported by Johan Bockgård
4376 <bojohan@gnu.org>.
4377
ef8ef9fb
CY
43782011-09-13 Chong Yidong <cyd@stupidchicken.com>
4379
4380 * frame.c (Fother_visible_frames_p): Function deleted.
4381
fa819fed
EZ
43822011-09-12 Eli Zaretskii <eliz@gnu.org>
4383
4384 * indent.c (compute_motion): Process display vector front to back
4385 rather than the other way around. (Bug#2496)
4386
2ba8e008
SM
43872011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
4388
4389 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
4390
20f53c69
CY
43912011-09-11 Chong Yidong <cyd@stupidchicken.com>
4392
4393 * minibuf.c (Fread_from_minibuffer): Doc fix.
4394
d562d7a4
EZ
43952011-09-11 Eli Zaretskii <eliz@gnu.org>
4396
4397 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
4398 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
4399
1c4d7f3d
LMI
44002011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4401
4402 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
4403 value for non-existent files.
4404
b885bf36
EZ
44052011-09-11 Eli Zaretskii <eliz@gnu.org>
4406
4407 * fileio.c (Finsert_file_contents): If the file cannot be opened,
4408 set its "size" to -1. This will set the modtime_size field of
4409 the corresponding buffer to -1, which is what
4410 verify-visited-file-modtime expects for files that do not exist.
4411 (Bug#9139)
4412
6612f0bf
PE
44132011-09-11 Paul Eggert <eggert@cs.ucla.edu>
4414
4415 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
4416 here ...
4417 * lisp.h: ... from here. push_key_description is no longer
4418 defined in keyboard.c, so its declaration should not be in
4419 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
4420 logically belongs with push_key_description.
4421
dfb3f755
PE
44222011-09-10 Paul Eggert <eggert@cs.ucla.edu>
4423
4424 * buffer.h: Include <sys/types.h> instead of <time.h>.
4425 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
4426 Problem reported by Herbert J. Skuhra.
4427
3134906c
LMI
44282011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
4429
4430 * xml.c (parse_region): Make the parsing work for
4431 non-comment-starting XML files again (bug#9144).
4432
8d903f4e
AS
44332011-09-10 Andreas Schwab <schwab@linux-m68k.org>
4434
4435 * image.c (gif_load): Fix calculation of bottom and right corner.
4436 (Bug#9468)
4437
80ad64f4
EZ
44382011-09-10 Eli Zaretskii <eliz@gnu.org>
4439
4440 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
4441 redisplay in small windows.
4442
208a048d
EZ
44432011-09-09 Eli Zaretskii <eliz@gnu.org>
4444
4445 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
4446
9b1c252e
MR
44472011-09-08 Martin Rudalics <rudalics@gmx.at>
4448
4449 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
4450 Operate on live windows only.
4451
2949f33b
JB
44522011-09-08 Juanma Barranquero <lekktu@gmail.com>
4453
4454 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
4455
e08dcafd
EZ
44562011-09-07 Eli Zaretskii <eliz@gnu.org>
4457
4458 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
4459 only under bidi iteration.
4460
115b96bd
JD
44612011-09-07 Jan Djärv <jan.h.d@swipnet.se>
4462
4463 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
4464
c8199d0f
PE
44652011-09-06 Paul Eggert <eggert@cs.ucla.edu>
4466
4467 isnan: Fix porting problem to Solaris 10 with bundled gcc.
4468 Without this fix, the command to link temacs failed due to an
4469 undefined symbol __builtin_isnan. This is because
4470 /usr/include/iso/math_c99.h #defines isnan(x) to
4471 __builtin_isnan(x), but the bundled gcc, which identifies itself
4472 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
4473 a __builtin_isnan.
4474 * floatfns.c (isnan): #undef, and then #define to a clone of
4475 what's in data.c.
4476 (Fisnan): Always define, since it's always available now.
4477 (syms_of_floatfns): Always define isnan at the Lisp level.
4478
e39b275c 44792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
4480
4481 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
4482
b2db44d9 44832011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 4484
f4af5137 4485 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
4486 The previous code assumed that file offsets (off_t values) fit in
4487 EMACS_INT variables, which is not true on typical 32-bit hosts.
4488 The code messed up by falsely reporting buffer overflow in cases
4489 such as (insert-file-contents "big" nil 1 2) into an empty buffer
4490 when "big" contains more than 2**29 bytes, even though this
4491 inserts just one byte and does not overflow the buffer.
4492 (Finsert_file_contents): Store file offsets as off_t
4493 values, not as EMACS_INT values. Check for overflow when
4494 converting between EMACS_INT and off_t. When checking for
4495 buffer overflow or for overlap, take the offsets into account.
4496 Don't use EMACS_INT for small values where int suffices.
4497 When checking for overlap, fix a typo: ZV was used where
4498 ZV_BYTE was intended.
4499 (Fwrite_region): Don't assume off_t fits into 'long'.
4500 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
4501
ecfc0a49
MA
45022011-09-05 Michael Albinus <michael.albinus@gmx.de>
4503
4504 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
4505
6511acf2 45062011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 4507
0999621a 4508 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
4509
4510 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 4511 (esprintf, exprintf, evxprintf): New functions.
62f19c19 4512 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 4513 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
4514 (modify_event_symbol): Do not assume that the length of
4515 name_alist_or_stem is safe to alloca and fits in int.
4516 (Fexecute_extended_command): Likewise for function name and binding.
4517 (Frecursion_depth): Wrap around reliably on integer overflow.
4518 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
4519 since some callers pass EMACS_INT values.
4520 (Fsingle_key_description): Don't crash if symbol name contains more
4521 than MAX_ALLOCA bytes.
4522 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
4523 (get_minibuffer): Arg is now EMACS_INT, not int.
4524 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 4525 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
4526 * window.h (command_loop_level, minibuf_level): Reflect API changes.
4527
2be7d702
PE
4528 * dbusbind.c (signature_cat): New function.
4529 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
4530 Do not overrun buffer; instead, report string overflow.
4531
9d1df220
PE
4532 * dispnew.c (add_window_display_history): Don't overrun buffer.
4533 Truncate instead; this is OK since it's just a log.
4534
33ef5c64
PE
4535 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
4536 even if the time zone offset is outlandishly large.
4537 Don't mishandle offset == INT_MIN.
4538
66c6fdd5
PE
4539 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
4540 when creating daemon; the previous buffer-overflow check was incorrect.
4541
d749b01b
PE
4542 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
4543 which has the guts of the old verror function.
4544
b5cd1905
PE
4545 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
4546 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
4547
6e1a67fb
PE
4548 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
4549 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 4550 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 4551 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
4552 length of string rather than counting it via multiple sprintfs;
4553 that's simpler and more reliable.
c21721cc
PE
4554 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
4555 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
4556 sprintf, in case result does not fit in int.
4557
c57b67fc
PE
4558 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
4559 (fontset_from_font): Print it.
4560
8a401434
PE
4561 * frame.c (tty_frame_count): Now printmax_t, not int.
4562 (make_terminal_frame, set_term_frame_name): Print it.
4563 (x_report_frame_params): In X, window IDs are unsigned long,
4564 not signed long, so print them as unsigned.
4565 (validate_x_resource_name): Check for implausibly long names,
4566 and don't assume name length fits in 'int'.
4567 (x_get_resource_string): Don't blindly alloca invocation name;
4568 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
4569 not fit in int.
4570
6e1a67fb
PE
4571 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
4572 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
4573 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
4574
0df02bf3
PE
4575 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
4576 Use esprintf, not sprintf, in case result does not fit in int.
4577
48e30793
PE
4578 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4579 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
4580 it as a large positive number.
4581 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
4582 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
4583
a66ff6d8
PE
4584 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
4585 in case result does not fit in int.
4586
aca216ff
PE
4587 * print.c (float_to_string): Detect width overflow more reliably.
4588 (print_object): Make sprintf buffer a bit bigger, to avoid potential
4589 buffer overrun. Don't assume list length fits in 'int'. Treat
4590 print length of 0 as 0, not as infinity; to be consistent with other
4591 uses of print length in this function. Don't overflow print length
4592 index. Don't assume hash table size fits in 'long', or that
4593 vectorlike size fits in 'unsigned long'.
4594
31c286f7
PE
4595 * process.c (make_process): Use printmax_t, not int, to format
4596 process-name gensyms.
4597
55e5faa1
PE
4598 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
4599
80f2e268
PE
4600 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
4601 to avoid potential buffer overrun.
4602
670741ab
PE
4603 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
4604 if X resource line is longer than 512 bytes.
4605
b7163a50
PE
4606 * xfns.c (x_window): Make sprintf buffer a bit bigger
4607 to avoid potential buffer overrun.
4608
ae58ff1f
PE
4609 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
4610
c43c8a6a
PE
4611 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
4612
3f8236f4
PE
46132011-09-04 Paul Eggert <eggert@cs.ucla.edu>
4614
53e9fe90 4615 Integer overflow fixes for scrolling, etc.
6511acf2
PE
4616 Without these, Emacs silently mishandles large integers sometimes.
4617 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
4618 it were "C-u 1 M-x recenter" on a typical 64-bit host.
4619
6511acf2
PE
4620 * xdisp.c (try_window_id): Check Emacs fixnum range before
4621 converting to 'int'.
806add1d 4622
6511acf2 4623 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
4624 Check that an Emacs fixnum is in range before assigning it to 'int'.
4625 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
4626 values converted from Emacs fixnums.
4627 (Frecenter): Don't wrap around a line count if it is out of 'int'
4628 range; instead, treat it as an extreme value.
4629 (Fset_window_configuration, compare_window_configurations):
4630 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
4631
6511acf2
PE
4632 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
4633 that can exceed INT_MAX. Check that EMACS_INT value is in range
4634 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
4635 (match_limit): Don't assume that a fixnum can fit in 'int'.
4636
6511acf2 4637 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
4638 exceed INT_MAX.
4639
6511acf2 4640 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
4641 (Fvertical_motion): Don't wrap around LINES values that don't fit
4642 in 'int'. Instead, treat them as extreme values. This is good
4643 enough for windows, which can't have more than INT_MAX lines anyway.
4644
fcb901a7
LMI
46452011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4646
0f2f6b6d
LMI
4647 * Require libxml/parser.h to avoid compilation warning.
4648
fcb901a7
LMI
4649 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
4650
4651 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
4652 since this reportedly can destroy thread storage.
4653
6e20a0d4
CY
46542011-08-30 Chong Yidong <cyd@stupidchicken.com>
4655
4656 * syntax.c (find_defun_start): Update all cache variables if
4657 exiting early (Bug#9401).
4658
148ae00e
EZ
46592011-08-30 Eli Zaretskii <eliz@gnu.org>
4660
f6cfbd8f
EZ
4661 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
4662
148ae00e
EZ
4663 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
4664 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
4665 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
4666
4667 * term.c (tty_append_glyph): New function.
4668 (produce_stretch_glyph): Static function and its prototype deleted.
4669
a66cfb1c
SM
4670 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
4671 Add prototypes.
148ae00e 4672
c4a07a4c
PE
46732011-08-29 Paul Eggert <eggert@cs.ucla.edu>
4674
4675 * image.c (parse_image_spec): Check for nonnegative, not for positive,
4676 when checking :margin (Bug#9390).
4677 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 4678 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
4679 so that the name doesn't mislead. All uses changed.
4680
6bc8cd65
JB
46812011-08-28 Johan Bockgård <bojohan@gnu.org>
4682
4683 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
4684 set_tty_hooks.
4685
dca4927e
EZ
46862011-08-27 Eli Zaretskii <eliz@gnu.org>
4687
4688 * xdisp.c (move_it_to): Don't bail out early when reaching
4689 position beyond to_charpos, if we are scanning backwards.
4690 (move_it_vertically_backward): When DY == 0, make sure we get to
4691 the first character in the line after the newline.
4692
f2cad773
PE
46932011-08-27 Paul Eggert <eggert@cs.ucla.edu>
4694
4695 * ccl.c: Improve and simplify overflow checking (Bug#9196).
4696 (ccl_driver): Do not generate an out-of-range pointer.
4697 (Fccl_execute_on_string): Remove unnecessary check for
4698 integer overflow, noted by Stefan Monnier in
4699 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
4700 Remove a FIXME that didn't need fixing.
4701 Simplify the newly-introduced buffer reallocation code.
4702
0cae2cdb
JB
47032011-08-27 Juanma Barranquero <lekktu@gmail.com>
4704
4705 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
4706
5fc295a4 47072011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 4708
70c60eb2 4709 Integer and memory overflow issues (Bug#9196).
726e0ab1 4710
d31850da
PE
4711 * doc.c (get_doc_string): Rework so that
4712 get_doc_string_buffer_size is the actual buffer size, rather than
4713 being 1 less than the actual buffer size; this makes xpalloc more
4714 convenient.
4715
a69fbedb
PE
4716 * image.c (x_allocate_bitmap_record, cache_image):
4717 * xselect.c (Fx_register_dnd_atom):
4718 Simplify previous changes by using xpalloc.
4719
fe5c5d37
PE
4720 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
4721 since either will do and ptrdiff_t is convenient with xpalloc.
4722
0065d054
PE
4723 * charset.c (charset_table_size)
4724 (struct charset_sort_data.priority): Now ptrdiff_t.
4725 (charset_compare): Don't overflow if priorities differ greatly.
4726 (Fsort_charsets): Don't assume list length fits in int.
4727 Check for size-calculation overflow when allocating sort data.
4728 (syms_of_charset): Allocate an initial charset table that is
4729 just under 64 KiB, to avoid problems with glibc malloc and mmap.
4730
4731 * cmds.c (internal_self_insert): Check for size-calculation overflow.
4732
4733 * composite.h (struct composition.glyph_len): Now int, not unsigned.
4734 The actual value is always <= INT_MAX, and leaving it unsigned made
4735 overflow checking harder.
4736
4737 * dispextern.h (struct glyph_matrix.rows_allocated)
4738 (struct face_cache.size): Now ptrdiff_t, for convenience in use
4739 with xpalloc. The values are still always <= INT_MAX.
4740
4741 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
4742
4743 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
4744 (SAFE_NALLOCA): New macro.
4745
4746 * region-cache.c (struct boundary.pos, find_cache_boundary)
4747 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
4748 (set_cache_region, invalidate_region_cache)
4749 (revalidate_region_cache, know_region_cache, region_cache_forward)
4750 (region_cache_backward, pp_cache):
4751 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
4752 so that ptrdiff_t * can be passed to xpalloc.
4753 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
4754 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
4755 (pp_cache): Don't assume cache_len fits in int.
4756 * region-cache.h: Adjust extern decls to match.
4757
4758 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
4759 EMACS_INT, since either will do, for xpalloc.
4760
4761 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
4762 (xnmalloc, xnrealloc, xpalloc): New functions.
4763
726e0ab1
PE
4764 * bidi.c (bidi_shelve_header_size): New constant.
4765 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
4766 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
4767
51f30bc5 4768 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
4769 * buffer.c (overlays_at, overlays_in, record_overlay_string)
4770 (overlay_strings):
4771 Don't update size of array until after memory allocation succeeds,
4772 because xmalloc/xrealloc may not return.
0065d054
PE
4773 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
4774 now that we have proper integer overflow checking.
4775 (record_overlay_string, overlay_strings): Catch overflows when
4776 calculating size of overlay_str_buf.
726e0ab1 4777
0065d054
PE
4778 * callproc.c (Fcall_process): Check for size overflow when
4779 calculating size of args2.
4780 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
4781 Normally we prefer signed values, but sticking with ptrdiff_t would
4782 require adding more-complicated checks.
726e0ab1
PE
4783
4784 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
4785 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
4786 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 4787 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
4788
4789 * character.c (Fstring): Check for size-calculation overflow.
4790
4791 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
4792 unnecessary integer overflow. Check for size overflow.
4793 (encode_coding_object): Don't update size until xmalloc succeeds.
4794
4795 * composite.c (get_composition_id): Check for overflow in glyph
4796 length calculations.
4797
4798 Integer and memory overflow fixes for display code.
4799 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
4800 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
4801 (scrolling_window): Check for overflow in size calculations.
4802 (line_draw_cost, realloc_glyph_pool, add_row_entry):
4803 Don't assume glyph table len fits in int.
4804 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
4805 (row_table_size): Now ptrdiff_t, not int.
4806 (scrolling_window): Avoid overflow in size calculations.
4807 Don't update size until allocation succeeds.
4808 * fns.c (concat): Check for overflow in size calculations.
4809 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
4810 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
4811 (NEXT_ALMOST_PRIME_LIMIT): New constant.
4812
4813 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
4814 (get_doc_string): Check for size calculation overflow.
4815 Don't update size until allocation succeeds.
4816 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
4817 EMACS_INT, where ptrdiff_t will do.
4818 (Fsubstitute_command_keys): Check for string overflow.
4819
4820 * editfns.c (set_time_zone_rule): Don't assume environment length
4821 fits in int.
4822 (message_length): Now ptrdiff_t, not int.
4823 (Fmessage_box): Don't update size until allocation succeeds.
4824 Don't assume message length fits in int.
4825 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
4826
0065d054
PE
4827 * emacs.c (main): Do not reallocate argv, since there is a null at
4828 the end that can be overwritten, and this way there's no need to
4829 worry about size-calculation overflow.
4830 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
4831
4832 * eval.c (init_eval_once, grow_specpdl): Don't update size until
4833 alloc succeeds.
4834 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
4835
4836 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
4837 (x_set_scroll_bar_width, x_figure_window_size):
4838 Check for integer overflow.
4839 (x_set_alpha): Do not assume XINT fits in int.
4840
4841 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
4842 This is for the members text_lines, text_cols, total_lines, total_cols,
4843 where the system imposes an 'int' limit.
4844
4845 * fringe.c (Fdefine_fringe_bitmap):
4846 Don't update size until alloc works.
4847
4848 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
4849 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
4850
4851 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
4852 Check for size-calculation overflow.
4853 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
4854 do, as we prefer signed integers.
4855 (id_to_widget.max_size, id_to_widget.used)
4856 (xg_store_widget_in_map, xg_remove_widget_from_map)
4857 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
4858 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
4859 Use and return ptrdiff_t, not int.
4860 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
4861 * gtkutil.h: Change prototypes to match the above.
4862
4863 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
4864 are duplicate now that they've been promoted to lisp.h.
4865 (x_allocate_bitmap_record, x_alloc_image_color)
4866 (make_image_cache, cache_image, xpm_load):
4867 Don't update size until alloc is done.
4868 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
4869 (x_detect_edges):
3256efce 4870 Check for size calculation overflow.
726e0ab1
PE
4871 (ct_colors_allocated_max): New constant.
4872 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
4873 overflow.
3256efce 4874
726e0ab1
PE
4875 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
4876 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
4877 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
4878 Use ptrdiff_t, not int, to count maps.
4879 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
4880 calculations. Don't update size until allocation succeeds.
4881 Redo calculations to avoid overflow.
726e0ab1
PE
4882 * keyboard.h: Change prototypes to match the above.
4883
4884 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
4885 to count maps.
4886 (current_minor_maps): Check for size calculation overflow.
4887 * keymap.h: Change prototypes to match the above.
4888
4889 * lread.c (read1, init_obarray): Don't update size until alloc done.
4890
4891 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
4892 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
4893
726e0ab1
PE
4894 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
4895 Now ptrdiff_t, not int.
4896 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
4897 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
4898
4899 * process.c (Fnetwork_interface_list): Check for overflow
4900 in size calculation.
4901
4902 * region-cache.c (move_cache_gap): Check for size calculation overflow.
4903
4904 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
4905 overflow. Don't bother calling xmalloc when xrealloc will do.
4906
4907 * search.c (Freplace_match): Check for size calculation overflow.
4908 (Fset_match_data): Don't assume list lengths fit in 'int'.
4909
4910 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
4911 for command line length. Do not attempt to address one before the
4912 beginning of an array, as that's not portable.
4913
4914 * term.c (max_frame_lines): Remove; unused.
4915 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
4916 not int.
4917 (encode_terminal_code, calculate_costs): Check for size
4918 calculation overflow.
4919 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
4920 table lengths and related sizes. Don't update size until alloc
4921 done. Redo calculations to avoid overflow.
4922 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
4923
4924 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
4925 subtracting pointers.
4926 (gobble_line): Check for overflow more carefully. Don't update size
4927 until alloc done.
4928
4929 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
4930 Don't update size until alloc done.
4931 Redo size calculations to avoid overflow.
4932 Check for size calculation overflow.
0065d054 4933 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
4934
4935 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
4936 Use ptrdiff_t, not int, for sizes.
4937 (store_mode_line_noprop_char): Don't update size until alloc done.
4938
0065d054
PE
4939 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
4940 Use ptrdiff_t, not int, for sizes.
4941 (Finternal_make_lisp_face, cache_face):
4942 Check for size calculation overflow.
4943 (cache_face): Treat size calculation overflows as if they were
4944 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
4945
4946 * xfns.c (x_encode_text, x_set_name_internal)
4947 (Fx_change_window_property): Use ptrdiff_t, not int, to count
4948 sizes, since they can exceed INT_MAX in size. Check for size
4949 calculation overflow.
4950
0065d054
PE
4951 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
4952 (xg_select): Check for size calculation overflow.
726e0ab1
PE
4953 Don't update size until alloc done.
4954
0065d054 4955 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 4956 as sprintf is limited to int lengths.
1d526e2f 4957
252c5ee1
PE
4958 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
4959 (X_LONG_MIN): New macros.
864d7ce7
PE
4960 Use them to make the following changes clearer.
4961 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
4962 This change doesn't affect the value now, but it may help remind
4963 future maintainers not to raise the value too much later.
4964 (SELECTION_QUANTUM): Remove, replacing with ...
4965 (selection_quantum): ... new function, which avoids overflow.
4966 All uses changed.
4967 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
4968 assumption that selection length fits in 'int'.
4969 (x_reply_selection_request, x_handle_selection_request)
4970 (x_get_window_property, receive_incremental_selection)
4971 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
4972 (lisp_data_to_selection_data, clean_local_selection_data):
4973 Use ptrdiff_t, not int, to record length of selection.
4974 (x_reply_selection_request, x_get_window_property)
4975 (receive_incremental_selection, x_property_data_to_lisp):
4976 Redo calculations to avoid overflow.
4977 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 4978 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
4979 something.
4980 (x_get_window_property, receive_incremental_selection)
4981 (lisp_data_to_selection_data, x_property_data_to_lisp):
4982 Check for size-calculation overflow.
4983 (x_get_window_property, receive_incremental_selection)
4984 (lisp_data_to_selection_data, Fx_register_dnd_atom):
4985 Don't store size until memory allocation succeeds.
4986 (x_get_window_property): Plug memory leak on memory exhaustion.
4987 Don't double-block input; malloc is safe here. Don't assume 2**34
4988 - 4 fits in unsigned long. Add an xassert to check
4989 XGetWindowProperty overflow. Be more careful about overflow
4990 calculations, and distinguish size from memory overflow better.
4991 (receive_incremental_selection): When tracing, don't assume
4992 unsigned int is less than INT_MAX.
4993 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
4994 harmful) conversions of unsigned short to int.
4995 (lisp_data_to_selection_data): Don't assume that integers
4996 in the range -65535 through -1 fit in an X unsigned short.
4997 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
4998 result parameters unless successful. Rely on cons_to_unsigned
4999 to report problems with elements; the old code wasn't right anyway.
5000 (x_check_property_data): Check for int overflow; we cannot use
5001 a wider type due to X limits.
5002 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
5003
726e0ab1 5004 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 5005
0065d054
PE
5006 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
5007 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
5008 (x_color_cells): Don't store size until memory allocation succeeds.
5009 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 5010 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
5011 (x_term_init): Don't assume length fits in int (sprintf is limited
5012 to int size).
bc18e09d 5013
ebfa62c0
PE
5014 Use ptrdiff_t for composition IDs.
5015 * character.c (lisp_string_width):
5016 * composite.c (composition_table_size, n_compositions)
5017 (get_composition_id, composition_gstring_from_id):
5018 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
5019 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
5020 * window.c (Frecenter):
5021 Use ptrdiff_t, not int, for composition IDs.
5022 * composite.c (get_composition_id): Check for integer overflow.
5023 * composite.h: Adjust prototypes to match the above changes.
5024
d3411f89
PE
5025 Use ptrdiff_t for hash table indexes.
5026 * category.c (hash_get_category_set):
5027 * ccl.c (ccl_driver):
5028 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
5029 * coding.c (coding_system_charset_list, detect_coding_system):
5030 * coding.h (struct coding_system.id):
5031 * composite.c (get_composition_id, gstring_lookup_cache):
5032 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
5033 * image.c (xpm_get_color_table_h):
5034 * lisp.h (hash_lookup, hash_put):
5035 * minibuf.c (Ftest_completion):
5036 Use ptrdiff_t for hash table indexes, not int (which is too
5037 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
5038 32-bit --with-wide-int hosts).
5039
e097a6fa
PE
5040 * charset.c (Fdefine_charset_internal): Check for integer overflow.
5041 Add a FIXME comment about memory leaks.
5042 (syms_of_charset): Don't assume xmalloc returns.
5043
5637687f
PE
5044 Don't assume that stated character widths fit in int.
5045 * character.c (Fchar_width, c_string_width, lisp_string_width):
5046 * character.h (CHAR_WIDTH):
5047 * indent.c (MULTIBYTE_BYTES_WIDTH):
5048 Use sanitize_char_width to avoid undefined and/or bad behavior
5049 with outlandish widths.
a66cfb1c 5050 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
5051 now that we have two such functions. All uses changed.
5052 (sanitize_char_width): New inline function.
5053
a2271ba2
PE
5054 Don't assume that tab-width fits in int.
5055 * character.h (sanitize_width): New inline function.
5056 (SANE_TAB_WIDTH): New macro.
5057 (ASCII_CHAR_WIDTH): Use it.
5058 * indent.c (sane_tab_width): Remove. All uses replaced by
5059 SANE_TAB_WIDTH (current_buffer).
5060 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
5061
18c52557
PE
5062 * fileio.c: Integer overflow issues with file modes.
5063 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
5064
caeeedc1
PE
5065 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
5066 Remove unreachable code.
5067 (read_hex, load_charset_map_from_file): Check for integer overflow.
5068
6df6ae42 5069 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
5070 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
5071 (x_send_scroll_bar_event): Likewise. Check that the size does not
5072 exceed limits imposed by XClientMessageEvent, as well as the usual
5073 ptrdiff_t and size_t limits.
5074
b13995db
PE
5075 * keyboard.c: Overflow, signedness and related fixes.
5076 (make_lispy_movement): Use same integer type in forward decl
5077 that is used in the definition.
5078 (read_key_sequence, keyremap_step):
5079 Change bufsize argument back to int, undoing my 2011-03-30 change.
5080 We prefer signed types, and int is wide enough here.
5081 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
5082 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
5083 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
5084 length, not size_t. Use ptrdiff_t for index, not int.
5085 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
5086 possibility of integer overflow.
5087
13464394
PE
5088 Overflow, signedness and related fixes for images.
5089
5090 * dispextern.h (struct it.stack[0].u.image.image_id)
5091 (struct_it.image_id, struct image.id, struct image_cache.size)
5092 (struct image_cache.used, struct image_cache.ref_count):
5093 * gtkutil.c (update_frame_tool_bar):
5094 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
5095 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
5096 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
5097 * nsmenu.m (update_frame_tool_bar):
5098 * xdisp.c (calc_pixel_width_or_height):
5099 * xfns.c (image_cache_refcount):
5100 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
5101 on typical 64-bit hosts.
5102
5103 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
5104 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
5105 Omit unnecessary casts to int.
5106 (parse_image_spec): Check that integers fall into 'int' range
5107 when the callers expect that.
5108 (image_ascent): Redo ascent calculation to avoid int overflow.
5109 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
5110 (lookup_image): Remove unnecessary tests.
5111 (xbm_image_p): Locals are now of int, not EMACS_INT,
5112 since parse_image_check makes sure they fit into int.
5113 (png_load, gif_load, svg_load_image):
5114 Prefer int to unsigned where either will do.
5115 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
5116 old tiff_error_handler and tiff_warning_handler.
5117 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
5118 stack buffer overflows. It uses only the features of vsnprintf
5119 that are common to both POSIX and native Microsoft.
5120 (tiff_error_handler, tiff_warning_handler): Use it.
5121 (tiff_load, gif_load, imagemagick_load_image):
5122 Don't assume :index value fits in 'int'.
5123 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
5124 (imagemagick_load_image): Check that crop parameters fit into
5125 the integer types that MagickCropImage accepts. Don't assume
5126 Vimagemagick_render_type has a nonnegative value. Don't assume
5127 size_t fits in 'long'.
5128 (gs_load): Use printmax_t to print the widest integers possible.
5129 Check for integer overflow when computing image height and width.
5130
c11821d4
EZ
51312011-08-26 Eli Zaretskii <eliz@gnu.org>
5132
5133 * xdisp.c (redisplay_window): Don't force window start if point
5134 will be invisible in the resulting window. (Bug#9324)
5135
0c95fcf7
EZ
51362011-08-25 Eli Zaretskii <eliz@gnu.org>
5137
5138 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
5139 the display spec is of the form `(space ...)'.
5140 (handle_display_spec): Return the value returned by
5141 handle_single_display_spec, not just 1 or zero.
5142 (handle_single_display_spec): If the display spec is of the form
5143 `(space ...)', and specifies display in the text area, return 2
5144 rather than 1.
fee65a97 5145 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
5146 accurately, and prefer exact match for point under bidi.
5147 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
5148
5149 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
5150 into disp_prop; all users changed.
5151
5152 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
5153 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
5154 for the text covered by the display property.
5155
e4ed06f1
CY
51562011-08-25 Chong Yidong <cyd@stupidchicken.com>
5157
5158 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
5159 Change return value to nil.
5160 (Frecord_buffer): Delete unused function.
5161
f67cdd7f
EZ
51622011-08-24 Eli Zaretskii <eliz@gnu.org>
5163
5980d4c6
EZ
5164 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
5165 buffers, return left-to-right.
8610fe8b
EZ
5166 (set_cursor_from_row): Consider candidate row a win if its glyph
5167 represents a newline and point is on that newline. Fixes cursor
5168 positioning on the newline at EOL of R2L text within L2R
5169 paragraph, and vice versa.
5170 (try_cursor_movement): Check continued rows, in addition to
5171 continuation rows. Fixes unwarranted scroll when point enters a
5172 continued line of R2L text within an L2R paragraph, or vice versa.
5173 (cursor_row_p): Consider the case of point being equal to
5174 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
5175 from the end of a short line to the beginning of a continued line
5176 of R2L text within L2R paragraph.
5177 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
5178 composed characters.
5980d4c6 5179
f67cdd7f
EZ
5180 * bidi.c (bidi_check_type): Use xassert.
5181 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
5182 members.
5183
bca633fb
EZ
51842011-08-23 Eli Zaretskii <eliz@gnu.org>
5185
5186 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
5187 a character.
5188
4a5885a7
CY
51892011-08-23 Chong Yidong <cyd@stupidchicken.com>
5190
5191 * nsfont.m (ns_otf_to_script): Fix typo.
5192
0902a04e
KH
51932011-08-22 Kenichi Handa <handa@m17n.org>
5194
5195 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
5196 extra slot even if the purpose is char-code-property-table.
5197
1a2e6670
EZ
51982011-08-23 Eli Zaretskii <eliz@gnu.org>
5199
8ddde651
EZ
5200 * xdisp.c (redisplay_window): When computing centering_position,
5201 account for the height of the header line. (Bug#8874)
5202
425cc014
EZ
5203 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
5204 instead of CHAR_TO_BYTE. Fixes a crash when a completion
5205 candidate is selected by the mouse, and that candidate has a
5206 composed character under the mouse.
5207
1a2e6670
EZ
5208 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
5209 coordinates reported by pos-visible-in-window-p for a composed
5210 character in column zero.
5211
8b76d6f8
SM
52122011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
5213
5214 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
5215
dac347dd
EZ
52162011-08-22 Eli Zaretskii <eliz@gnu.org>
5217
5218 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
5219 consider it a hit if to_charpos is anywhere in the range of the
5220 composed buffer positions.
5221
e013fb34
CY
52222011-08-22 Chong Yidong <cyd@stupidchicken.com>
5223
5224 * image.c (gif_load): Don't assume that each subimage has the same
5225 dimensions as the base image. Handle disposal method that is
5226 "undefined" by the gif spec (Bug#9335).
5227
bd1ba3e8
CY
52282011-08-20 Chong Yidong <cyd@stupidchicken.com>
5229
5230 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 5231 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 5232
54a1215b
EZ
52332011-08-19 Eli Zaretskii <eliz@gnu.org>
5234
823564e5
EZ
5235 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
5236 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
5237 from an Org mode buffer to a Speedbar frame.
5238
54a1215b
EZ
5239 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
5240 a composition, take its buffer position from IT->cmp_it.charpos.
5241 Fixes cursor positioning at the beginning of a line that begins
5242 with a composed character.
5243
9778ebcc
EZ
52442011-08-18 Eli Zaretskii <eliz@gnu.org>
5245
0be6ee06
EZ
5246 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
5247 character bidirectional type, use STRONG_L instead. Fixes crashes
5248 in a buffer produced by `describe-categories'.
5249
9778ebcc
EZ
5250 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
5251 members before the level stack, so they would be saved and
5252 restored when copying iterator state. Fixes incorrect reordering
5253 around TABs covered by display properties.
5254
156bffbe
AS
52552011-08-18 Andreas Schwab <schwab@linux-m68k.org>
5256
6b02f655 5257 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 5258
72ad093b
CY
52592011-08-17 Chong Yidong <cyd@stupidchicken.com>
5260
5261 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
5262 (internal_condition_case_2, internal_condition_case_n):
5263 Remove unnecessary aborts (Bug#9081).
72ad093b 5264
35774242
EZ
52652011-08-17 Eli Zaretskii <eliz@gnu.org>
5266
5267 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
5268 has no `load' handler, try opening the file locally. (Bug#9311)
5269
db76dd85
KB
52702011-08-16 Ken Brown <kbrown@cornell.edu>
5271
5272 * gmalloc.c: Expand comment.
5273
b215eee5
EZ
52742011-08-16 Eli Zaretskii <eliz@gnu.org>
5275
5276 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
5277 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
5278
a4579d33
KB
52792011-08-16 Ken Brown <kbrown@cornell.edu>
5280
5281 Fix memory allocation problems in Cygwin build (Bug#9273).
5282
5283 * unexcw.c ( __malloc_initialized): Declare external variable.
5284 (fixup_executable): Force the dumped emacs to reinitialize malloc.
5285
8b76d6f8
SM
5286 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
5287 New variables.
a4579d33
KB
5288 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
5289 dumped emacs.
5290 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
5291 in the static heap.
5292 [CYGWIN] (special_realloc): New function.
5293 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
5294 requests to realloc storage in the static heap.
5295
3ebec551
PE
52962011-08-15 Paul Eggert <eggert@cs.ucla.edu>
5297
5298 * bidi.c (bidi_initialize): Remove unused local.
5299
9fd8be00
EZ
53002011-08-15 Eli Zaretskii <eliz@gnu.org>
5301
6b02f655
SM
5302 * bidimirror.h:
5303 * biditype.h: Remove file.
5304 * makefile.w32-in ($(BLD)/bidi.$(O)):
5305 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
5306
5307 * dispextern.h: Fix a typo in the comment to bidi_type_t.
5308
5309 * chartab.c: Improve commentary for the uniprop_table API.
5310
32413314
EZ
5311 * bidi.c (bidi_paragraph_init): Support zero value of
5312 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
5313 (bidi_initialize): Use uniprop_table instead of including
5314 biditype.h and bidimirror.h.
32413314 5315
9fd8be00
EZ
5316 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
5317 coordinates of the iterator when restoring from ppos_it.
5318 (Bug#9296)
5319
5cf2b69b
KH
53202011-08-14 Kenichi Handa <handa@m17n.org>
5321
5322 * process.c (create_process): Call setup_process_coding_systems
72ad093b 5323 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 5324
daf17d00
EZ
53252011-08-14 Eli Zaretskii <eliz@gnu.org>
5326
5327 * xdisp.c (move_it_in_display_line_to): Don't invoke
5328 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
5329 ppos_it. Fixes vertical cursor motion when line beginning is
5330 covered by an image. (Bug#9296)
5331
08e3161a
JD
53322011-08-14 Jan Djärv <jan.h.d@swipnet.se>
5333
5334 * nsterm.h (ns_run_ascript): Declare.
5335 (NSAPP_DATA2_RUNASSCRIPT): Define.
5336
5337 * nsfns.m (as_script, as_result, as_status): New static variables.
5338 (ns_run_ascript): New function.
5e617bc2 5339 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
5340 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
5341 the event loop. Get status from as_status (Bug#7276).
5342
5343 * nsterm.m (sendEvent): If event is NSApplicationDefined and
5344 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
5345 the event loop (Bug#7276).
5346
a3720aa2
AS
53472011-08-14 Andreas Schwab <schwab@linux-m68k.org>
5348
5349 * gnutls.c (QCgnutls_bootprop_priority)
5350 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
5351 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
5352 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
5353 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
5354 (QCgnutls_bootprop_verify_hostname_error)
5355 (QCgnutls_bootprop_callbacks_verify): Rename from
5356 Qgnutls_bootprop_..., all uses changed.
5357
5358 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
5359 uses changed.
5360
0a0d27fb
PE
53612011-08-14 Paul Eggert <eggert@cs.ucla.edu>
5362
19d5c50c
PE
5363 * xfaces.c (Qframe_set_background_mode): Now static.
5364 * dispextern.h (Qframe_set_background_mode): Remove decl.
5365
0a0d27fb
PE
5366 * process.c (Fnetwork_interface_info): Declare local only if needed.
5367
377538cb
JD
53682011-08-13 Jan Djärv <jan.h.d@swipnet.se>
5369
5370 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
5371 (Fnetwork_interface_list): Allocate in increments of bytes instead
5372 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
5373 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
5374 sockaddr.
5375 (struct ifflag_def): notrailers is smart on OSX.
5376 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
5377 Get hardware address with getifaddrs if available.
5378
08fff70c
EZ
53792011-08-12 Eli Zaretskii <eliz@gnu.org>
5380
5381 * xdisp.c (iterate_out_of_display_property): xassert that
5382 IT->position is set to within IT->object's boundaries. Break from
5383 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
5384 when IT->position is set up wrongly due to some bug.
5385 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
5386 (push_display_prop): Allow GET_FROM_STRING as IT->method on
5387 entry. Force push_it to save on the stack the current
5388 buffer/string position, to be restored by pop_it. Fix flags in
5389 the iterator structure wrt the object coming from a display
5390 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
5391 properties. (Bug#9284)
5392
7be1c708 53932011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 5394
7be1c708
CY
5395 * fontset.c (fontset_get_font_group): Add proper type checks.
5396 (Bug#9172)
aac0c6e3 5397
7be1c708 53982011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 5399
7be1c708
CY
5400 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
5401 and LC_VERSION_MIN_MACOSX.
5402 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
5403 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 5404
97bb72a6
EZ
54052011-08-08 Eli Zaretskii <eliz@gnu.org>
5406
5407 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
5408 no-display-properties-and-no-overlays under bidi display.
5409 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 5410 properties and overlays.
97bb72a6 5411
d5617611
CY
54122011-08-08 Chong Yidong <cyd@stupidchicken.com>
5413
37e11a63
CY
5414 * editfns.c (Fset_time_zone_rule): Document relationship with the
5415 setenv function.
5416
d5617611
CY
5417 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
5418 the font entity extracted from the cache (Bug#8109).
5419
58872834
CY
54202011-08-07 Chong Yidong <cyd@stupidchicken.com>
5421
5422 * composite.c (autocmp_chars): Don't reset point. That is done by
5423 restore_point_unwind (Bug#5984).
5424
75bfc667
JL
54252011-08-07 Juri Linkov <juri@jurta.org>
5426
5427 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
5428 to show the arg `TIME' instead of `TIMEVAL'.
5429
d1410150
EZ
54302011-08-06 Eli Zaretskii <eliz@gnu.org>
5431
5432 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
5433 display property strides EOL and includes a newline, as in
5434 longlines-mode. (Bug#9254)
75b771e4
EZ
5435 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
5436 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
5437
5438 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
5439 is non-zero, even if the data buffer is NULL. Fixes a crash in
5440 vertical-motion with longlines-mode. (Bug#9254)
5441
35928349
EZ
54422011-08-05 Eli Zaretskii <eliz@gnu.org>
5443
ec7cc85b
EZ
5444 * bidi.c <bidi_cache_total_alloc>: Now static.
5445 (bidi_initialize): Initialize bidi_cache_total_alloc.
5446
8b76d6f8 5447 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
5448 cache. (Bug#9221)
5449
5450 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
5451 amount allocated this far in `bidi_cache_total_alloc'.
5452 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
5453 non-zero, only free the data buffer without restoring the cache
5454 contents. All callers changed.
5455
5456 * dispextern.h (bidi_unshelve_cache): Update prototype.
5457
5458 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
5459 (move_it_in_display_line, move_it_to)
5460 (move_it_vertically_backward, move_it_by_lines): Replace the call
5461 to xfree to an equivalent call to bidi_unshelve_cache.
5462 (move_it_in_display_line_to): Fix logic of returning
412b6358 5463 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 5464
e2e2423b
EZ
54652011-08-05 Eli Zaretskii <eliz@gnu.org>
5466
5467 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
5468 came from a string character with a `cursor' property. (Bug#9229)
5469
ae9e757a
JD
54702011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5471
5472 * Makefile.in (LIB_PTHREAD): New variable.
5473 (LIBES): Add LIB_PTHREAD (Bug#9216).
5474
5475 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
5476 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
5477
213bd7f2
AS
54782011-08-04 Andreas Schwab <schwab@linux-m68k.org>
5479
6b02f655 5480 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 5481
99aaf75f
JD
54822011-08-04 Jan Djärv <jan.h.d@swipnet.se>
5483
5484 * xterm.c (x_find_topmost_parent): New function.
5485 (x_set_frame_alpha): Find topmost parent window with
5486 x_find_topmost_parent and set the property there also (bug#9181).
5487 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
5488
c74e9d86
PE
54892011-08-04 Paul Eggert <eggert@cs.ucla.edu>
5490
5491 * callproc.c (Fcall_process): Avoid vfork clobbering
5492 the local vars buffer, coding_systems, current_dir.
5493
640c8776
SM
54942011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
5495
5496 * keymap.c (Fmake_composed_keymap): Move to subr.el.
5497
f26d0e4c
PE
54982011-08-03 Paul Eggert <eggert@cs.ucla.edu>
5499
8a10d76c
PE
5500 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
5501 so that it is not optimized away.
5502
f26d0e4c
PE
5503 * xdisp.c (compute_display_string_pos): Remove unused local.
5504
55439c61
EZ
55052011-08-02 Eli Zaretskii <eliz@gnu.org>
5506
5507 Fix slow cursor motion and scrolling in large buffers with
5508 selective display, like Org Mode buffers. (Bug#9218)
5509
5510 * dispextern.h (struct bidi_it): New member disp_prop_p.
5511
5512 * xdisp.c: Remove one-slot cache of display string positions.
5513 (compute_display_string_pos): Accept an additional argument
5e617bc2 5514 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
5515 for a display string or property. If found, set DISP_PROP_P
5516 non-zero.
5517
5518 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
5519 DISP_PROP_P, and pass it to compute_display_string_pos.
5520 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
5521 non-zero. All callers of bidi_fetch_char changed.
5522
fb33fa43
SM
55232011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
5524
5525 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
5526
b099e063
DM
55272010-12-03 Don March <don@ohspite.net>
5528
5529 * keymap.c (Fdefine_key): Fix non-prefix key error message when
5530 last character M-[char] is translated to ESC [char] (bug#7541).
5531
5cc7f7af
KH
55322011-08-02 Kenichi Handa <handa@m17n.org>
5533
d0fffa3f 5534 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
5535
5536 * chartab.c (uniprop_table): Make it non-static.
5537
525d5e6e
EZ
55382011-08-01 Eli Zaretskii <eliz@gnu.org>
5539
5540 * xdisp.c (forward_to_next_line_start): Accept additional argument
5541 BIDI_IT_PREV, and store into it the state of the bidi iterator had
5542 on the newline.
5543 (reseat_at_next_visible_line_start): Use the bidi iterator state
5544 returned by forward_to_next_line_start to restore the state of
5545 it->bidi_it after backing up to previous newline. (Bug#9212)
5546
31011111
AS
55472011-07-30 Andreas Schwab <schwab@linux-m68k.org>
5548
5549 * regex.c (re_comp): Protoize.
5550 (re_exec): Fix return type.
5551 (regexec): Fix type of `ret'. (Bug#9203)
5552
476371c4
PE
55532011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5554
e5d76069
PE
5555 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
5556 This is needed if max-image-size is a floating-point number.
5557
9a79b20c
AS
55582011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5559
5560 * print.c (print_object): Print empty symbol as ##.
5561
5562 * lread.c (read1): Read ## as empty symbol.
5563
d8c2fa78
AA
55642011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
5565
5566 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
5567 setting frame foreground color (Bug#9175).
5568 (x_set_background_color): Likewise.
5569
ffe57a7a
AA
5570 * nsmenu.m (-setText): Size tooltip dimensions precisely to
5571 contents (Bug#9176).
5572 (EmacsTooltip -init): Remove bezels and add shadows to
5573 tooltip windows.
5574
bf3492a5
AA
5575 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
5576 or scroll bar (Bug#8470).
5577
d55e9c53
AA
5578 * nsfont.m (nsfont_open): Remove assignment to voffset and
5579 unnecessary vars hshink, expand, hd, full_height, min_height.
5580 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
5581
5582 * nsterm.h (nsfont_info): Remove voffset field.
5583
d8c2fa78 55842011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
5585
5586 Implement strike-through and overline on NextStep (Bug#8863).
5587
5588 * nsfont.m (nsfont_open): Use underline position provided by font,
5589 instead of hard-coded value of 2.
5590 (nsfont_draw): Call ns_draw_text_decoration instead.
5591
5592 * nsterm.h: Add declaration for ns_draw_text_decoration.
5593
5594 * nsterm.m (ns_draw_text_decoration): New function for drawing
5595 underline, overline, and strike-through.
5596 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
5597 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 5598 accommodate underlining, etc.
4843aac3 5599
4cc60b9b
EZ
56002011-07-28 Eli Zaretskii <eliz@gnu.org>
5601
bc7ece87
EZ
5602 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
5603 default.
4cc60b9b 5604
476371c4
PE
56052011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5606
66606eea
PE
5607 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
5608 Without this fix, if a signal arrives just after memory fills up,
5609 'malloc' might be invoked reentrantly.
5610
476371c4
PE
5611 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
5612 In other words, assume that every image size is allowed, on non-X
5613 hosts. This assumption is probably wrong, but it lets Emacs compile.
5614
f3fcc40d
AS
56152011-07-28 Andreas Schwab <schwab@linux-m68k.org>
5616
5617 * regex.c (re_iswctype): Convert return values to boolean.
5618
350c992f
EZ
56192011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
5620
5621 * xdisp.c (compute_display_string_pos): Don't use cached display
5622 string position if the buffer had its restriction changed.
5623 (Bug#9184)
5624
5266b4bb
PE
56252011-07-28 Paul Eggert <eggert@cs.ucla.edu>
5626
5627 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
5628
2573a837 56292011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 5630
41f55ccd 5631 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 5632
39e378da
PE
5633 * bidi.c: Integer size and overflow fixes.
5634 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
5635 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
5636 (bidi_cache_find_level_change, bidi_cache_ensure_space)
5637 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
5638 (bidi_find_other_level_edge):
5639 Use ptrdiff_t instead of EMACS_INT where either will do.
5640 This works better on 32-bit hosts configured --with-wide-int.
5641 (bidi_cache_ensure_space): Check for size-calculation overflow.
5642 Use % rather than repeated addition, for better worst-case speed.
5643 Don't set bidi_cache_size until after xrealloc returns, because it
5644 might not return.
5645 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
5646 (bidi_cache_ensure_space): Also check that the bidi cache size
5647 does not exceed that of the largest Lisp string or buffer. See Eli
5648 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 5649
5e927815
PE
5650 * alloc.c (__malloc_size_t): Remove.
5651 All uses replaced by size_t. See Andreas Schwab's note
5652 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
5653
ca4aa935
PE
5654 * image.c: Improve checking for integer overflow.
5655 (check_image_size): Assume that f is nonnull, since
5656 it is always nonnull in practice. This is one less thing to
5657 worry about when checking for integer overflow later.
5658 (x_check_image_size): New function, which checks for integer
5659 overflow issues inside X.
5660 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
5661 This removes the need for a memory_full check.
5662 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
5663 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
5664 (xbm_read_bitmap_data): Change locals back to 'int', since
5665 their values must fit in 'int'.
5666 (xpm_load_image, png_load, tiff_load):
5667 Invoke x_create_x_image_and_pixmap earlier,
5668 to avoid much needless work if the image is too large.
5669 (tiff_load): Treat overly large images as if
5670 x_create_x_image_and_pixmap failed, not as malloc failures.
5671 (gs_load): Use x_check_image_size.
5672
5f8f9cc2
PE
5673 * gtkutil.c: Omit integer casts.
5674 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
5675 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
5676
5adf60bc
PE
5677 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
5678
c8907a93
PE
5679 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
5680 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
5681 would wrongly return t on a 64-bit host.
5682
e3c25c68
PE
5683 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
5684 The plain *_OVERFLOW macros run afoul of GCC bug 49705
5685 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
5686 and therefore cause GCC to emit a bogus diagnostic in some cases.
5687
3f791afe
PE
5688 * image.c: Integer signedness and overflow and related fixes.
5689 This is not an exhaustive set of fixes, but it's time to
5690 record what I've got.
5691 (lookup_pixel_color, check_image_size): Remove redundant decls.
5692 (check_image_size): Don't assume that arbitrary EMACS_INT values
5693 fit in 'int', or that arbitrary 'double' values fit in 'int'.
5694 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
5695 (tiff_load, imagemagick_load_image):
5696 Check for overflow in size calculations.
5697 (x_create_x_image_and_pixmap): Remove unnecessary test for
5698 xmalloc returning NULL; that can't happen.
5699 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
5700 (xpm_color_bucket): Use better integer hashing function.
5701 (xpm_cache_color): Don't possibly over-allocate memory.
5702 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
5703 (gif_memory_source):
5704 Use ptrdiff_t, not int or size_t, to record sizes.
5705 (png_load): Don't assume values greater than 2**31 fit in 'int'.
5706 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
5707 either works, as we prefer signed integers.
5708 (tiff_read_from_memory, tiff_write_from_memory):
5709 Return tsize_t, not size_t, since that's what the TIFF API wants.
5710 (tiff_read_from_memory): Don't fail simply because the read would
5711 go past EOF; instead, return a short read.
5712 (tiff_load): Omit no-longer-needed casts.
5713 (Fimagemagick_types): Don't assume size fits into 'int'.
5714
3cc5a532
PE
5715 Improve hashing quality when configured --with-wide-int.
5716 * fns.c (hash_string): New function, taken from sxhash_string.
5717 Do not discard information about ASCII character case; this
5718 discarding is no longer needed.
5719 (sxhash-string): Use it. Change sig to match it. Caller changed.
5720 * lisp.h: Declare it.
5721 * lread.c (hash_string): Remove, since we now use fns.c's version.
5722 The fns.c version returns a wider integer if --with-wide-int is
5723 specified, so this should help the quality of the hashing a bit.
5724
b312a492
PE
5725 * emacs.c: Integer overflow minor fix.
5726 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
5727 Define only if GNU_LINUX.
5728 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
5729
dfd153ae
PE
5730 * dispnew.c: Integer signedness and overflow fixes.
5731 Remove unnecessary forward decls, that were a maintenance hassle.
5732 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
5733 All uses changed.
5734 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
5735 (scrolling_window): Use ptrdiff_t, not int, for byte count.
5736 (prepare_desired_row, line_draw_cost):
5737 Use int, not unsigned, where either works.
5738 (save_current_matrix, restore_current_matrix):
5739 Use ptrdiff_t, not size_t, where either works.
5740 (init_display): Check for overflow more accurately, and without
5741 relying on undefined behavior.
5742
a81d11a3
PE
5743 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
5744 Remove, replacing with the new symbols in lisp.h. All uses changed.
5745 * fileio.c (make_temp_name):
5746 * filelock.c (lock_file_1, lock_file):
5747 * xdisp.c (message_dolog):
5748 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
5749 Use pMd etc. instead.
5750 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
5751 replacing the pWIDE etc. symbols removed from editfns.c.
5752
3300e6fd
PE
5753 * keyboard.h (num_input_events): Now uintmax_t.
5754 This is (very slightly) less likely to mess up due to wraparound.
5755 All uses changed.
5756
fd05c7e9
PE
5757 * buffer.c: Integer signedness fixes.
5758 (alloc_buffer_text, enlarge_buffer_text):
5759 Use ptrdiff_t rather than size_t when either will do, as we prefer
5760 signed integers.
5761
903fe15d
PE
5762 * alloc.c: Integer signedness and overflow fixes.
5763 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
5764 (__malloc_size_t): Default to size_t, not to int.
5765 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
5766 (Fgarbage_collect, mark_object_loop_halt, mark_object):
5767 Prefer ptrdiff_t to size_t when either would do, as we prefer
5768 signed integers.
5769 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
5770 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
5771 Now const. Initialize with values that are in range even if char
5772 is signed.
5773 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
5774 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
5775 These functions do the right thing with sizes > 2**32.
5776 (check_depth): Now ptrdiff_t, not int.
5777 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
5778 Adjust to new way of storing sizes. Check for size overflow bugs
5779 in rest of code.
5780 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
5781 slightly wrong anyway, as it missed one instance of
5782 XMALLOC_OVERRUN_CHECK_OVERHEAD.
5783 (refill_memory_reserve): Omit needless cast to size_t.
5784 (mark_object_loop_halt): Mark as externally visible.
5785
ac82cc6a
PE
5786 * xselect.c: Integer signedness and overflow fixes.
5787 (Fx_register_dnd_atom, x_handle_dnd_message):
5788 Use ptrdiff_t, not size_t, since we prefer signed.
5789 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
5790 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
5791 x_dnd_atoms_size and x_dnd_atoms_length.
5792
c2d1e36d
PE
5793 * doprnt.c: Prefer signed to unsigned when either works.
5794 * eval.c (verror):
5795 * doprnt.c (doprnt):
5796 * lisp.h (doprnt):
5797 * xdisp.c (vmessage):
5798 Use ptrdiff_t, not size_t, when using or implementing doprnt,
5799 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
5800 prefer signed arithmetic to avoid comparison confusion.
5801 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
5802 but is a bit tricky.
5803
0e926e56
PE
5804 Assume freestanding C89 headers, string.h, stdlib.h.
5805 * data.c, doprnt.c, floatfns.c, print.c:
5806 Include float.h unconditionally.
5807 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
5808 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
5809 * regex.c: Likewise for stddef.h, string.h.
5810 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
5811 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
5812 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
5813 (STDC_HEADERS): Remove obsolete defines.
5814 * sysdep.c: Include limits.h unconditionally.
5815
9cfdb3ec
PE
5816 Assume support for memcmp, memcpy, memmove, memset.
5817 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
5818 * regex.c (memcmp, memcpy):
5819 Remove; we assume C89 now.
5820
5821 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
5822 (__malloc_safe_bcopy): Remove; no longer needed.
5823
cf950e6b 5824 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
5825 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
5826 well either way, and we prefer signed to unsigned.
5827
dbf38e02
LMI
58282011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
5829
5830 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
5831 closes the connection while we're reading (bug#9182).
5832
d6f0886c 58332011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 5834
d6f0886c
JD
5835 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
5836 are specified (Bug#9168).
24e0f6b1 5837
2eb1f9e6
PE
58382011-07-25 Paul Eggert <eggert@cs.ucla.edu>
5839
5840 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
5841 Found by GCC static checking and --with-wide-int on a 32-bit host.
5842
22381272 58432011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
5844
5845 * xdisp.c (compute_display_string_pos): Fix logic of caching
5846 previous display string position. Initialize cached_prev_pos to
5847 -1. Fixes slow-down at the beginning of a buffer.
5848
f25e39b4
EZ
58492011-07-24 Eli Zaretskii <eliz@gnu.org>
5850
5851 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
5852 for attrs[LFACE_FONTSET_INDEX].
5853
04c4b52e
PE
58542011-07-23 Paul Eggert <eggert@cs.ucla.edu>
5855
5856 * xml.c (parse_region): Remove unused local
5857 that was recently introduced.
5858
c1734fbd
EZ
58592011-07-23 Eli Zaretskii <eliz@gnu.org>
5860
be18c5a5
EZ
5861 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
5862 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
5863
c1734fbd
EZ
5864 * xdisp.c (move_it_in_display_line_to): Record the best matching
5865 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
5866 exit if none of the characters scanned was an exact match.
5867 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
5868 when exact match is impossible due to invisible text, and the
5869 lines are truncated.
5870
a258d627
JD
58712011-07-23 Jan Djärv <jan.h.d@swipnet.se>
5872
5873 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
5874 for OSX >= 10.7.
5875
b6d5a689
EZ
58762011-07-22 Eli Zaretskii <eliz@gnu.org>
5877
0f74f785
EZ
5878 Fix a significant slow-down of cursor motion with C-n, C-p,
5879 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
5880 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 5881 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
5882 (next_element_from_buffer): Call compute_stop_pos_backwards to
5883 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
5884 base_level_stop.
5885 (reseat): Don't look for prev_stop, as that could mean a very long
5886 run.
5887 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
5888 <cached_disp_overlay_modiff>: Cache for last found display string
5889 position.
551918c1 5890 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
5891 about the same buffer in the same area of character positions, and
5892 the buffer wasn't changed since the time the display string
5893 position was cached.
551918c1 5894
b2d0c91a
EZ
58952011-07-22 Eli Zaretskii <eliz@gnu.org>
5896
5897 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
5898 is an integer, which is important for empty lines. (Bug#9149)
5899
043604ee
CY
59002011-07-22 Chong Yidong <cyd@stupidchicken.com>
5901
5902 * frame.c (Fmodify_frame_parameters): In tty case, update the
5903 default face if necessary (Bug#4238).
5904
da4adb04
CY
59052011-07-21 Chong Yidong <cyd@stupidchicken.com>
5906
5907 * editfns.c (Fstring_to_char): No need to explain what a character
5908 is in the docstring (Bug#6576).
5909
9abd0532
LMI
59102011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5911
5912 * xml.c (parse_region): Make sure we always return a tree.
5913
36881d16
HK
59142011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
5915
5916 * xml.c (parse_region): If a document contains only comments,
5917 return that, too.
5918
1e98674d
LMI
59192011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
5920
5921 * xml.c (make_dom): Return comments, too.
5922
590bd467
PE
59232011-07-19 Paul Eggert <eggert@cs.ucla.edu>
5924
5925 Port to OpenBSD.
5926 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
5927 and the surrounding thread.
5928 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
5929 rather than fgets, and retry after EINTR. Otherwise, 'emacs
5930 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
5931 timer goes off.
5932 * s/openbsd.h (BROKEN_SIGIO): Define.
5933 * unexelf.c (unexec) [__OpenBSD__]:
5934 Don't update the .mdebug section of the Alpha COFF symbol table.
5935
f41628b2
LMI
59362011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
5937
5938 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
5939 (bug#8460).
5940
b59b67c5
PE
59412011-07-18 Paul Eggert <eggert@cs.ucla.edu>
5942
15e3a074
PE
5943 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
5944 This fixes some race conditions on the permissions of any newly
5945 created file.
5946
41bed37d
PE
5947 * alloc.c (valid_pointer_p): Use pipe, not open.
5948 This fixes some permissions issues when debugging.
5949
b59b67c5
PE
5950 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
5951 If fchown fails to set both uid and gid, try to set just gid,
5952 as that is sometimes allowed. Adjust the file's mode to eliminate
5953 setuid or setgid bits that are inappropriate if fchown fails.
5954
925a6be7
SM
59552011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
5956
5957 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
5958 to compare Lisp_Objects.
5959 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
5960 global_gnutls_log_level, don't mistake it for a Lisp_Object.
5961 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
5962
52968808
AS
59632011-07-17 Andreas Schwab <schwab@linux-m68k.org>
5964
0a6a104b
AS
5965 * lread.c (read_integer): Unread even EOF character.
5966 (read1): Likewise. Properly record start position of symbol.
5967
52968808
AS
5968 * lread.c (read1): Read `#:' as empty uninterned symbol if no
5969 symbol character follows.
5970
9e381cdd
PE
59712011-07-17 Paul Eggert <eggert@cs.ucla.edu>
5972
5973 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
5974 This works around a problem with the previous change to Fcopy_file.
5975 Recent glibc declares fchown with __attribute__((warn_unused_result)),
5976 and without this change, GCC might complain about discarding
5977 fchown's return value.
5978
b5641435
JB
59792011-07-16 Juanma Barranquero <lekktu@gmail.com>
5980
5981 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
5982
a8031457
PE
59832011-07-16 Paul Eggert <eggert@cs.ucla.edu>
5984
5985 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
5986
dd889327
LMI
59872011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
5988
750c33f7
LMI
5989 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
5990 it's used from the C level.
5991
dd889327
LMI
5992 * process.c: Use the same condition for POLL_FOR_INPUT in both
5993 keyboard.c and process.c (bug#1858).
5994
87e86684
LM
59952011-07-09 Lawrence Mitchell <wence@gmx.li>
5996
5997 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
5998 (Fgnutls_boot): Use it.
5999
64348f40
AS
60002011-07-15 Andreas Schwab <schwab@linux-m68k.org>
6001
6002 * doc.c (Fsubstitute_command_keys): Revert last change.
6003
1d698799
LMI
60042011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
6005
f863868c
LMI
6006 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
6007 quotes the next character, and doesn't affect other longer
6008 sequences (bug#8935).
6009
1d698799
LMI
6010 * lread.c (syms_of_lread): Clarify that is isn't only
6011 `eval-buffer' and `eval-defun' that's affected by
6012 `lexical-binding' (bug#8460).
6013
aa4b6df6
EZ
60142011-07-15 Eli Zaretskii <eliz@gnu.org>
6015
6016 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 6017 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 6018
5d856da6
PE
60192011-07-14 Paul Eggert <eggert@cs.ucla.edu>
6020
ad6042bb
PE
6021 Fix minor problems found by static checking.
6022 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
6023 (elsz): Now a signed constant, not a size_t var. We prefer signed
6024 types to unsigned, to avoid integer comparison confusion. Without
6025 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
6026 "cannot optimize loop, the loop counter may overflow", a symptom
6027 of the confusion.
f00bbb22 6028 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
6029 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
6030
6468f31c
LMI
60312011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6032
49080b10
LMI
6033 * search.c (Fre_search_backward): Mention `case-fold-search' in
6034 all the re_search_* functions (bug#8138).
6035
6468f31c
LMI
6036 * keyboard.c (Fopen_dribble_file): Document when the file is
6037 closed (bug#8056).
6038
c965adc5
EZ
60392011-07-14 Eli Zaretskii <eliz@gnu.org>
6040
df9733bf
EZ
6041 * bidi.c (bidi_dump_cached_states): Fix format of displaying
6042 bidi_cache_idx.
6043
0bb23927
EZ
6044 Support bidi reordering of display and overlay strings.
6045 * xdisp.c (compute_display_string_pos)
6046 (compute_display_string_end): Accept additional argument STRING.
6047 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
6048 (reseat_to_string): Initialize bidi_it->string.s and
6049 bidi_it->string.schars.
6050 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
6051 NULL (avoids a crash in bidi_paragraph_init).
6052 Initialize itb.string.lstring.
0bb23927
EZ
6053 (init_iterator): Call bidi_init_it only of a valid
6054 buffer position was specified. Initialize paragraph_embedding to
6055 L2R.
6056 (reseat_to_string): Initialize the bidi iterator.
6057 (display_string): If we need to ignore text properties of
6058 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
6059 original value of -1 will not work with bidi.)
6060 (compute_display_string_pos): First arg is now struct
6061 `text_pos *'; all callers changed. Support display properties on
6062 Lisp strings.
6063 (compute_display_string_end): Support display properties on Lisp
6064 strings.
6065 (init_iterator, reseat_1, reseat_to_string): Initialize the
6066 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
6067 when iterating on a string not from display properties).
640c8776
SM
6068 (compute_display_string_pos, compute_display_string_end):
6069 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
6070 arrow keys.
6071 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
6072 base_level_stop; instead, set base_level_stop to BEGV.
6073 Fixes crashes in vertical-motion.
0bb23927
EZ
6074 (next_element_from_buffer): Improve commentary for when
6075 the iterator is before prev_stop.
6076 (init_iterator): Initialize bidi_p from the default value of
6077 bidi-display-reordering, not from buffer-local value. Use the
6078 buffer-local value only if initializing for buffer iteration.
6079 (handle_invisible_prop): Support invisible properties on strings
6080 that are being bidi-reordered.
6081 (set_iterator_to_next): Support bidi reordering of C strings and
6082 Lisp strings.
6083 (next_element_from_string): Support bidi reordering of Lisp
6084 strings.
6085 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
6086 (display_string): Support display of R2L glyph rows.
6087 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
6088 (init_iterator): Don't initialize it->bidi_p for strings
6089 here.
6090 (reseat_to_string): Initialize it->bidi_p for strings here.
6091 (next_element_from_string, next_element_from_c_string)
6092 (next_element_from_buffer): Add xassert's for correspondence
6093 between IT's object being iterated and it->bidi_it.string
6094 structure.
6095 (face_before_or_after_it_pos): Support bidi iteration.
6096 (next_element_from_c_string): Handle the case of the first string
6097 character that is not the first one in the visual order.
6098 (get_visually_first_element): New function, refactored from common
6099 parts of next_element_from_buffer, next_element_from_string, and
6100 next_element_from_c_string.
6101 (tool_bar_lines_needed, redisplay_tool_bar)
6102 (display_menu_bar): Force left-to-right direction. Add a FIXME
6103 comment for making that be controlled by a user option.
6104 (push_it, pop_it): Save and restore the state of the
6105 bidi iterator. Save and restore the bidi_p flag.
6106 (pop_it): Iterate out of display property for string iteration as
6107 well.
6108 (iterate_out_of_display_property): Support iteration over strings.
6109 (handle_single_display_spec): Set up it->bidi_it for iteration
6110 over a display string, and call bidi_init_it.
6111 (handle_single_display_spec, next_overlay_string)
6112 (get_overlay_strings_1, push_display_prop): Set up the bidi
6113 iterator for displaying display or overlay strings.
6114 (forward_to_next_line_start): Don't use the shortcut if
6115 bidi-iterating.
6116 (back_to_previous_visible_line_start): If handle_display_prop
6117 pushed the iterator stack, restore the internal state of the bidi
6118 iterator by calling bidi_pop_it same number of times.
6119 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
6120 and we are bidi-iterating, don't decrement the iterator position;
6121 instead, set the first_elt flag in the bidi iterator, to produce
6122 the same effect.
6123 (reseat_1): Remove redundant setting of string_from_display_prop_p.
6124 (push_display_prop): xassert that we are iterating a buffer.
6125 (push_it, pop_it): Save and restore paragraph_embedding member.
6126 (handle_single_display_spec, next_overlay_string)
6127 (get_overlay_strings_1, reseat_1, reseat_to_string)
6128 (push_display_prop): Set up the `unibyte' member of bidi_it.string
6129 correctly. Don't assume unibyte strings are not bidi-reordered.
6130 (compute_display_string_pos)
6131 (compute_display_string_end): Fix handling the case of C string.
6132 (push_it, pop_it): Save and restore from_disp_prop_p.
6133 (handle_single_display_spec, push_display_prop): Set the
6134 from_disp_prop_p flag.
6135 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
6136 (pop_it): Call iterate_out_of_display_property only if we are
6137 popping after iteration over a string that came from a display
6138 property. Fix a typo in popping stretch info. Add an assertion
6139 for verifying that the iterator position is in sync with the bidi
6140 iterator.
6141 (handle_single_display_spec, get_overlay_strings_1)
6142 (push_display_prop): Fix initialization of paragraph direction for
6143 string when that of the parent object is not yet determined.
6144 (reseat_1): Call bidi_init_it to resync the bidi
6145 iterator with IT's position. (Bug#7616)
6146 (find_row_edges): If ROW->start.pos gives position
6147 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
6148 (handle_stop, back_to_previous_visible_line_start, reseat_1):
6149 Reset the from_disp_prop_p flag.
6150 (SAVE_IT, RESTORE_IT): New macros.
6151 (pos_visible_p, face_before_or_after_it_pos)
6152 (back_to_previous_visible_line_start)
6153 (move_it_in_display_line_to, move_it_in_display_line)
6154 (move_it_to, move_it_vertically_backward, move_it_by_lines)
6155 (try_scrolling, redisplay_window, display_line): Use them when
6156 saving a temporary copy of the iterator and restoring it back.
6157 (back_to_previous_visible_line_start, reseat_1)
6158 (init_iterator): Empty the bidi cache "stack".
6159 (move_it_in_display_line_to): If iterator ended up at
6160 EOL, but we never saw any buffer positions smaller than
6161 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
6162 motion in bidi-reordered lines.
6163 (move_it_in_display_line_to): Record prev_method and prev_pos
6164 immediately before the call to set_iterator_to_next. Fixes cursor
6165 motion in bidi-reordered lines with stretch glyphs and strings
6166 displayed in margins. (Bug#8133) (Bug#8867)
6167 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
6168 TO_CHARPOS.
640c8776
SM
6169 (pos_visible_p): Support positions in bidi-reordered lines.
6170 Save and restore bidi cache.
0bb23927
EZ
6171
6172 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
6173 (bidi_paragraph_info): Delete unused struct.
6174 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
6175 (bidi_cache_start): New variable.
6176 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
6177 to zero.
6178 (bidi_cache_fetch_state, bidi_cache_search)
6179 (bidi_cache_find_level_change, bidi_cache_iterator_state)
6180 (bidi_cache_find, bidi_peek_at_next_level)
6181 (bidi_level_of_next_char, bidi_find_other_level_edge)
6182 (bidi_move_to_visually_next): Compare cache index with
6183 bidi_cache_start rather than with zero.
6184 (bidi_fetch_char): Accept new argument STRING; all callers
6185 changed. Support iteration over a string. Support strings with
6186 display properties. Support unibyte strings. Fix the type of
6187 `len' according to what STRING_CHAR_AND_LENGTH expects.
6188 (bidi_paragraph_init, bidi_resolve_explicit_1)
6189 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
6190 (bidi_level_of_next_char, bidi_move_to_visually_next):
6191 Support iteration over a string.
0bb23927
EZ
6192 (bidi_set_sor_type, bidi_resolve_explicit_1)
6193 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
6194 can now be zero (for strings); special values 0 and -1 were
6195 changed to -1 and -2, respectively.
6196 (bidi_char_at_pos): New function.
6197 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
6198 Call it instead of FETCH_MULTIBYTE_CHAR.
6199 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
6200 initialized to valid values.
6201 (bidi_init_it): Don't initialize charpos and bytepos with invalid
6202 values.
6203 (bidi_level_of_next_char): Allow the sentinel "position" to pass
6204 the test for valid cached positions. Fix the logic for looking up
6205 the sentinel state in the cache. GCPRO the Lisp string we are
6206 iterating.
6207 (bidi_push_it, bidi_pop_it): New functions.
6208 (bidi_initialize): Initialize the bidi cache start stack pointer.
6209 (bidi_cache_ensure_space): New function, refactored from part of
6210 bidi_cache_iterator_state. Don't assume the required size is just
6211 one BIDI_CACHE_CHUNK away.
6212 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
6213 (bidi_count_bytes, bidi_char_at_pos): New functions.
6214 (bidi_cache_search): Don't assume bidi_cache_last_idx is
6215 always valid if bidi_cache_idx is valid.
6216 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
6217 is valid if it's going to be used.
6218 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
6219 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
6220 (bidi_cache_find_level_change, bidi_cache_ensure_space)
6221 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
6222 (bidi_find_other_level_edge, bidi_cache_start_stack):
6223 All variables related to cache indices are now EMACS_INT.
c965adc5 6224
0bb23927
EZ
6225 * dispextern.h (struct bidi_string_data): New structure.
6226 (struct bidi_it): New member `string'. Make flag members be 1-bit
6227 fields, and put them last in the struct.
640c8776
SM
6228 (compute_display_string_pos, compute_display_string_end):
6229 Update prototypes.
0bb23927
EZ
6230 (bidi_push_it, bidi_pop_it): Add prototypes.
6231 (struct iterator_stack_entry): New members bidi_p,
6232 paragraph_embedding, and from_disp_prop_p.
6233 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
6234 (bidi_shelve_cache, bidi_unshelve_cache):
6235 Declare prototypes.
0bb23927
EZ
6236
6237 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
6238 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
6239 and vector-like objects.
6240
6241 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
6242 cache around display iteration.
6243
6244 * window.c (Fwindow_end, window_scroll_pixel_based)
6245 (displayed_window_lines, Frecenter): Save and restore the bidi
6246 cache around display iteration.
6247
3bbd2265
LMI
62482011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
6249
6250 * editfns.c (Fdelete_region): Clarify the use of the named
6251 parameters (bug#6788).
6252
adc47434
MR
62532011-07-14 Martin Rudalics <rudalics@gmx.at>
6254
6255 * indent.c (Fvertical_motion): Set and restore w->pointm when
6256 saving and restoring the window's buffer (Bug#9006).
6257
837c31f8
LMI
62582011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
6259
6260 * editfns.c (Fstring_to_char): Clarify just what is returned
6261 (bug#6576). Text by Eli Zaretskii.
6262
ac389d0c
JB
62632011-07-13 Juanma Barranquero <lekktu@gmail.com>
6264
6265 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
6266
0be0ce47
EZ
62672011-07-13 Eli Zaretskii <eliz@gnu.org>
6268
6269 * buffer.c (mmap_find): Fix a typo.
6270
cd18e7e3
JB
62712011-07-13 Johan Bockgård <bojohan@gnu.org>
6272
6273 Fix execution of x selection hooks.
6274 * xselect.c (Qx_lost_selection_functions)
6275 (Qx_sent_selection_functions): New vars.
6276 (syms_of_xselect): DEFSYM them.
6277 (x_handle_selection_request): Pass Qx_sent_selection_functions
6278 rather than Vx_sent_selection_functions to Frun_hook_with_args.
6279 (x_handle_selection_clear,x_clear_frame_selections):
6280 Pass Qx_lost_selection_functions rather than
6281 Vx_lost_selection_functions to Frun_hook_with_args.
6282
47ea7f44
PE
62832011-07-13 Paul Eggert <eggert@cs.ucla.edu>
6284
ac389d0c 6285 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
6286 The old code sometimes used this field without initializing it.
6287
47ea7f44
PE
6288 * alloc.c (gc_sweep): Don't read past end of array.
6289 In theory, the old code could also have corrupted Emacs internals,
6290 though it'd be very unlikely.
6291
bc985c87
AS
62922011-07-12 Andreas Schwab <schwab@linux-m68k.org>
6293
6294 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 6295 argument. (Bug#4026)
bc985c87 6296
0cf34688
LMI
62972011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
6298
b3dadd76
LMI
6299 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
6300 key" (bug#4257).
6301
0cf34688
LMI
6302 * window.c (Fset_window_start): Doc fix (bug#4199).
6303 (Fset_window_hscroll): Ditto.
6304
270768cd
PE
63052011-07-12 Paul Eggert <eggert@cs.ucla.edu>
6306
077e3dda 6307 Fix minor new problems caught by GCC 4.6.1.
270768cd 6308 * term.c (init_tty): Remove unused local.
490011a6 6309 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 6310 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 6311 not used otherwise.
270768cd 6312
b1f58454
CY
63132011-07-12 Chong Yidong <cyd@stupidchicken.com>
6314
6315 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
6316
22b9578d
LMI
63172011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6318
6e70ab07
LMI
6319 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
6320 are the mini-buffer and the echo area (bug#3320).
6321
22b9578d
LMI
6322 * term.c (init_tty): Remove support for supdup, c10 and perq
6323 terminals, which are no longer supported (bug#1482).
6324
8974cc9f
JB
63252011-07-10 Johan Bockgård <bojohan@gnu.org>
6326
6327 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
6328
a560d974
JD
63292011-07-10 Jan Djärv <jan.h.d@swipnet.se>
6330
6331 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
6332 for non-popups (Bug#3642).
6333
1dae0f0a
AS
63342011-07-10 Andreas Schwab <schwab@linux-m68k.org>
6335
268c2c36 6336 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 6337 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
6338 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
6339 * cm.c (losecursor): Likewise.
1dae0f0a
AS
6340 * data.c (fmod): Likewise.
6341 * dispnew.c (swap_glyphs_in_rows): Likewise.
6342 * emacs.c (memory_warning_signal): Likewise.
6343 * floatfns.c (float_error): Likewise.
6344 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
6345 (otf_open, font_otf_capability, generate_otf_features)
6346 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
6347 Likewise.
6348 * image.c (pbm_read_file): Likewise.
6349 * indent.c (string_display_width): Likewise.
6350 * intervals.c (check_for_interval, search_for_interval)
6351 (inc_interval_count, count_intervals, root_interval)
6352 (adjust_intervals_for_insertion, make_new_interval): Likewise.
6353 * lread.c (defalias): Likewise.
268c2c36 6354 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
6355 * regex.c (set_image_of_range_1, set_image_of_range)
6356 (regex_grow_registers): Likewise.
6357 * sysdep.c (strerror): Likewise.
6358 * termcap.c (valid_filename_p, tprint, main): Likewise.
6359 * tparam.c (main): Likewise.
6360 * unexhp9k800.c (run_time_remap, save_data_space)
6361 (update_file_ptrs, read_header, write_header, calculate_checksum)
6362 (copy_file, copy_rest, display_header): Likewise.
6363 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
6364 Likewise.
6365 * xdisp.c (check_it): Likewise.
6366 * xfaces.c (register_color, unregister_color, unregister_colors):
6367 Likewise.
6368 * xfns.c (print_fontset_result): Likewise.
6369 * xrdb.c (member, fatal, main): Likewise.
6370
99033785
PE
63712011-07-10 Paul Eggert <eggert@cs.ucla.edu>
6372
6373 Fix minor problems found by static checking (Bug#9031).
6374 * chartab.c (char_table_set_range, map_sub_char_table):
6375 Remove unused locals.
6376 (uniprop_table): Now static.
6377 * composite.c (_work_char): Remove unused static var.
6378
9cb2ac56
JB
63792011-07-09 Juanma Barranquero <lekktu@gmail.com>
6380
6381 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
6382
f25661f0
JD
63832011-07-09 Jan Djärv <jan.h.d@swipnet.se>
6384
6385 * gtkutil.c (qttip_cb): Remove code without function.
6386
8278c4fe
EZ
63872011-07-09 Eli Zaretskii <eliz@gnu.org>
6388
6389 * w32.c (pthread_sigmask): New stub.
6390
1692ae2d 63912011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 6392
8a6ebd58 6393 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
6394 sigprocmask is portable only for single-threaded applications, and
6395 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
6396 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
6397 (LIBES): Use it.
6398 * callproc.c (Fcall_process):
6399 * process.c (create_process):
6400 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
6401 Use pthread_sigmask, not sigprocmask.
123403e4 6402
1b854618
JD
64032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6404
6405 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
6406 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
6407 wrong (Bug#8591).
6408
3fe4b549
JD
64092011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6410
0ce7e563
JD
6411 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
6412 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
6413 (xg_hide_tooltip): Fix comment.
6414
3fe4b549
JD
6415 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
6416 in registerServicesMenuSendTypes.
6417 (validRequestorForSendType): Don't check ns_return_types.
6418
6419 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
6420 ns_return_type.
6421
5df75e47
JR
64222011-07-08 Jason Rumney <jasonr@gnu.org>
6423
22610910
JR
6424 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
6425 SH_SHOW for hidden windows (Bug#5482).
6426
5df75e47
JR
6427 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
6428 frame struct members of non-existent frames (Bug#6284).
6429
699c10bd
JD
64302011-07-08 Jan Djärv <jan.h.d@swipnet.se>
6431
4393663b
JD
6432 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
6433 variable firstTime not needed on OSX >= 10.6.
6434 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
6435 >= 10.5. Use setKnobProportion, setDoubleValue.
6436
6437 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
6438 (MAC_OS_X_VERSION_10_5): Define if not defined.
6439 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
6440 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
6441 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
6442
6443 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
6444 cString and lossyCString on OSX >= 10.4
6445
58179cce 6446 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
6447 sizeToFit on OSX >= 10.2.
6448
6449 * nsimage.m (allocInitFromFile): Don't use deprecated method
6450 bestRepresentationForDevice on OSX >= 10.6.
6451
6452 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
6453 to avoid warning.
6454
6455 * emacs.c: Declare unexec_init_emacs_zone.
6456
a63e0781
JD
6457 * nsgui.h: Fix compiler warning about gnulib redefining verify.
6458
699c10bd
JD
6459 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
6460
6461 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
6462 on svcsMenu (Bug#8842).
6463
6464 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
6465 ns_return_types.
6466 (Fns_list_services): Just return Qnil on 10.6, code not working there.
6467
6468 * nsterm.m (QUTF8_STRING): Declare.
6469 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
6470 (validRequestorForSendType): Return type is (id).
6471 Change indexOfObjectIdenticalTo to indexOfObject.
6472 Check if we have local selection before returning self (Bug#8842).
6473 (writeSelectionToPasteboard): Put local selection into paste board
6474 if we have a local selection (Bug#8842).
6475 (syms_of_nsterm): DEFSYM QUTF8_STRING.
6476
6477 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
6478 (ns_get_local_selection): Declare.
6479
54e10184
LMI
64802011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
6481
9888ff71
LMI
6482 * keymap.c (describe_map_tree): Don't insert a double newline at
6483 the end of the buffer (bug#1169) and return whether we inserted
6484 something.
6485
54e10184
LMI
6486 * callint.c (Fcall_interactively): Change "reading args" to
6487 "providing args" to try to clarify what it does (bug#1010).
6488
15fa4783
KH
64892011-07-07 Kenichi Handa <handa@m17n.org>
6490
6491 * composite.c (composition_compute_stop_pos): Ignore a static
6492 composition starting before CHARPOS (Bug#8915).
6493
6494 * xdisp.c (handle_composition_prop): Likewise.
6495
a8815b00
EZ
64962011-07-07 Eli Zaretskii <eliz@gnu.org>
6497
6498 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
6499 (Bug#9015)
6500
ef7b981d 65012011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
6502
6503 * character.h (unicode_category_t): New enum type.
6504
6505 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
6506 (Qchar_code_property_table): New variable.
6507 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
6508 (UNIPROP_COMPRESSED_FORM_P): New macros.
6509 (char_table_ascii): Uncompress the compressed values.
6510 (sub_char_table_ref): New arg is_uniprop. Callers changed.
6511 Uncompress the compressed values.
ac389d0c 6512 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
6513 (char_table_ref_and_range): Uncompress the compressed values.
6514 (sub_char_table_set): New arg is_uniprop. Callers changed.
6515 Uncompress the compressed values.
6516 (sub_char_table_set_range): Args changed. Callers changed.
6517 (char_table_set_range): Adjuted for the above change.
6518 (map_sub_char_table): Delete args default_val and parent. Add arg
6519 top. Give decoded values to a Lisp function.
640c8776 6520 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
6521 values to a Lisp function. Gcpro more variables.
6522 (uniprop_table_uncompress)
6523 (uniprop_decode_value_run_length): New functions.
6524 (uniprop_decoder, uniprop_decoder_count): New variables.
6525 (uniprop_get_decoder, uniprop_encode_value_character)
6526 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
6527 New functions.
6528 (uniprop_encoder, uniprop_encoder_count): New variables.
6529 (uniprop_get_encoder, uniprop_table)
6530 (Funicode_property_table_internal, Fget_unicode_property_internal)
6531 (Fput_unicode_property_internal): New functions.
6532 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
6533 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 6534 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
6535 char-code-property-alist.
6536
640c8776 6537 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
6538 Vunicode_category_table.
6539
640c8776 6540 * font.c (font_range): Adjust for the change of
c805dec0
KH
6541 Vunicode_category_table.
6542
76b397fb
DN
65432011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
6544
6545 * m/iris4d.h: Remove file, move contents ...
6546 * s/irix6-5.h: ... here.
6547
22b4128e
PE
65482011-07-06 Paul Eggert <eggert@cs.ucla.edu>
6549
6550 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
6551 * alloc.c (mark_buffer):
6552 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
6553 (clone_per_buffer_values): Don't assume that
22b4128e
PE
6554 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
6555 This isn't true in general, and it's particularly not true
6556 if Emacs is configured with --with-wide-int.
6557 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
6558 New macros, used in the buffer.c change.
6559
869795d6
JD
65602011-07-05 Jan Djärv <jan.h.d@swipnet.se>
6561
6562 * xsettings.c: Use both GConf and GSettings if both are available.
6563 (store_config_changed_event): Add comment.
6564 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
6565 (store_tool_bar_style_changed): New functions.
5e617bc2 6566 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
6567 (struct xsettings): Move font inside HAVE_XFT.
6568 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 6569 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 6570 Move inside HAVE_XFT.
640c8776 6571 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
6572 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
6573 also.
6574 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 6575 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 6576 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
6577 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
6578 (parse_settings): Move check for font inside HAVE_XFT.
6579 (read_settings, apply_xft_settings): Add comment.
6580 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
6581 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
6582 call store_font_name_changed.
6583 (xft_settings_event): Add comment.
6584 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
6585 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
6586 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
6587 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
6588 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
6589 (xsettings_get_system_font, xsettings_get_system_normal_font):
6590 Add comment.
869795d6 6591
d8ed26bd
PE
65922011-07-05 Paul Eggert <eggert@cs.ucla.edu>
6593
6594 Random fixes. E.g., (random) never returned negative values.
6595 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
6596 subseconds part to the entropy, as that's a bit more random.
6597 Prefer signed to unsigned, since the signedness doesn't matter and
6598 in general we prefer signed. When given a limit, use a
6599 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
6600 latter isn't right if USE_2_TAGS_FOR_INTS.
6601 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
6602 not 0..VALMASK. Don't discard "excess" bits that random () returns.
6603
cabf1cac
SM
66042011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
6605
6606 * textprop.c (text_property_stickiness):
6607 Obey Vtext_property_default_nonsticky.
6608 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
6609 * w32fns.c (syms_of_w32fns):
6610 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
6611
6e9b2be9
PE
66122011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6613
6614 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
6615 This is more efficient than Ffile_directory_p and avoids a minor race.
6616
90186c68
LMI
66172011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
6618
7c301272
LMI
6619 * buffer.c (Foverlay_put): Say what the return value is
6620 (bug#7835).
6621
c4f2d8d4
LMI
6622 * fileio.c (barf_or_query_if_file_exists): Check first if the file
6623 is a directory before asking whether to use the file name
6624 (bug#7564).
ad637907
LMI
6625 (barf_or_query_if_file_exists): Make the "File is a directory"
6626 error be more correct.
c4f2d8d4 6627
90186c68
LMI
6628 * fns.c (Frequire): Remove the mention of the .gz files, since
6629 that's installation-specific, but keep the mention of
6630 `get-load-suffixes'.
6631
da64016e
PE
66322011-07-04 Paul Eggert <eggert@cs.ucla.edu>
6633
6634 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
6635 Report string overflow if the output is too long.
6636
7d47b580
JB
66372011-07-04 Juanma Barranquero <lekktu@gmail.com>
6638
a555cb87
JB
6639 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
6640 (syms_of_gnutls): Remove duplicate DEFSYM for
6641 Qgnutls_bootprop_verify_hostname_error, an error for
6642 Qgnutls_bootprop_verify_error (which is no longer used).
6643
7d47b580
JB
6644 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
6645 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
6646 Also (re)move comments that are misplaced or no longer relevant.
6647
1e49bfab
LMI
66482011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6649
6650 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
6651
1485f4c0
CY
66522011-07-03 Chong Yidong <cyd@stupidchicken.com>
6653
6654 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
6655 and background color parameters if they have been changed.
6656
a9ab721e
LMI
66572011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
6658
6659 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
6660
cf7cff57
PE
66612011-07-03 Paul Eggert <eggert@cs.ucla.edu>
6662
2e13213d
PE
6663 * xsettings.c (SYSTEM_FONT): Define only when used.
6664 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
6665
cf7cff57
PE
6666 * keymap.c (access_keymap_1): Now static.
6667
7a8e04f7
CY
66682011-07-02 Chong Yidong <cyd@stupidchicken.com>
6669
6670 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
6671 leave any prefix arg for the up event (Bug#1586).
6672
61352f62
LMI
66732011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
6674
69bb1ef7
LMI
6675 * lread.c (syms_of_lread): Mention single symbols defined by
6676 `defvar' or `defconst' (bug#7154).
6677
61352f62 6678 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 6679 (Frequire): Mention get-load-suffixes.
61352f62 6680
28545e04
MR
66812011-07-02 Martin Rudalics <rudalics@gmx.at>
6682
6683 * window.h (window): Remove clone_number slot.
6684 * window.c (Fwindow_clone_number, Fset_window_clone_number):
6685 Remove.
6686 (make_parent_window, make_window, saved_window)
6687 (Fset_window_configuration, save_window_save): Don't deal with
6688 clone numbers.
6689 * buffer.c (Qclone_number): Remove declaration.
6690 (sort_overlays, overlay_strings): Don't deal with clone numbers.
6691
3349e122
SM
66922011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
6693
6694 Add multiple inheritance to keymaps.
6695 * keymap.c (Fmake_composed_keymap): New function.
6696 (Fset_keymap_parent): Simplify.
6697 (fix_submap_inheritance): Remove.
6698 (access_keymap_1): New function extracted from access_keymap to handle
6699 embedded parents and handle lists of maps.
6700 (access_keymap): Use it.
6701 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
6702 (Fcopy_keymap): Handle embedded parents.
6703 (Fcommand_remapping, define_as_prefix): Simplify.
6704 (Fkey_binding): Simplify.
6705 (syms_of_keymap): Move minibuffer-local-completion-map,
6706 minibuffer-local-filename-completion-map,
6707 minibuffer-local-must-match-map, and
6708 minibuffer-local-filename-must-match-map to Elisp.
6709 (syms_of_keymap): Defsubr make-composed-keymap.
6710 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
6711 (parse_menu_item): Trivial simplification.
6712
3279eb87
GM
67132011-07-01 Glenn Morris <rgm@gnu.org>
6714
6715 * Makefile.in (SETTINGS_LIBS): Fix typo.
6716
4550efdf
KI
67172011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
6718
6719 * coding.c (Fencode_coding_string): Record the last coding system
6720 used, as the function doc string says (bug#8738).
6721
0949d2b6
JD
67222011-07-01 Jan Djärv <jan.h.d@swipnet.se>
6723
6724 * xsettings.c (store_monospaced_changed): Take new font as arg and
6725 check for change against current_mono_font.
6726 (EMACS_TYPE_SETTINGS): Remove this and related defines.
6727 (emacs_settings_constructor, emacs_settings_get_property)
6728 (emacs_settings_set_property, emacs_settings_class_init)
6729 (emacs_settings_init, gsettings_obj): Remove.
6730 (something_changedCB): New function for HAVE_GSETTINGS.
6731 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
6732 with value as argument.
6733 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
6734 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 6735 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
6736 "changed".
6737
6738 * xgselect.c: Add defined (HAVE_GSETTINGS).
6739 (xgselect_initialize): Ditto.
6740
6741 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
6742 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
6743 xg_select.
6744
bbc6b304
PE
67452011-07-01 Paul Eggert <eggert@cs.ucla.edu>
6746
6747 * eval.c (struct backtrace): Simplify and port the data structure.
6748 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
6749 signed bit field, as this assumption is not portable and it makes
6750 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
6751 "char debug_on_exit : 1" as this is not portable either; instead,
6752 use the portable "unsigned int debug_on_exit : 1". Remove unused
6753 member evalargs. Remove obsolete comments about cc bombing out.
6754
9851bfc5
JD
67552011-06-30 Jan Djärv <jan.h.d@swipnet.se>
6756
51bb811f 6757 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
6758 Let HAVE_GSETTINGS override HAVE_GCONF.
6759 (store_monospaced_changed): New function.
6760 (EMACS_SETTINGS): A new type derived from GObject to handle
6761 GSettings notifications.
6762 (emacs_settings_constructor, emacs_settings_get_property)
6763 (emacs_settings_set_property, emacs_settings_class_init):
6764 New functions.
6765 (gsettings_client, gsettings_obj): New variables.
6766 (GSETTINGS_SCHEMA): New define.
6767 (something_changedCB): Call store_monospaced_changed.
6768 (init_gsettings): New function.
6769 (xsettings_initialize): Call init_gsettings.
6770 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
6771 to NULL.
6772
640c8776 6773 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
6774 GCONF_CFLAGS/LIBS.
6775
5386012d
MR
67762011-06-29 Martin Rudalics <rudalics@gmx.at>
6777
6778 * window.c (resize_root_window, grow_mini_window)
6779 (shrink_mini_window): Rename Qresize_root_window to
6780 Qwindow_resize_root_window and Qresize_root_window_vertically to
6781 Qwindow_resize_root_window_vertically.
6782
f13e0b08
PE
67832011-06-28 Paul Eggert <eggert@cs.ucla.edu>
6784
6785 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
6786
94515237
JB
67872011-06-27 Juanma Barranquero <lekktu@gmail.com>
6788
6789 * makefile.w32-in: Redesign dependencies so they reflect more
6790 clearly which files are directly included by each source file,
6791 and not through other includes.
6792
e43b6e43
MR
67932011-06-27 Martin Rudalics <rudalics@gmx.at>
6794
6795 * buffer.c (Qclone_number): Declare static and DEFSYM it.
6796 (sort_overlays, overlay_strings): When an overlay's clone number
6797 matches the window's clone number process the overlay even if
6798 the overlay's window property doesn't match the current window.
6799
d68443dc
MR
6800 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
6801 (Fwindow_hchild): Rename to Fwindow_left_child.
6802 (Fwindow_next): Rename to Fwindow_next_sibling.
6803 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
6804 (resize_window_check): Rename to window_resize_check.
6805 (resize_window_apply): Rename to window_resize_apply.
6806 (Fresize_window_apply): Rename to Fwindow_resize_apply.
6807 (Fdelete_other_windows_internal, resize_frame_windows)
6808 (Fsplit_window_internal, Fdelete_window_internal)
6809 (grow_mini_window, shrink_mini_window)
6810 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 6811
c7e73be5
JD
68122011-06-26 Jan Djärv <jan.h.d@swipnet.se>
6813
6814 * emacsgtkfixed.h: State that this is only used with Gtk+3.
6815 (emacs_fixed_set_min_size): Remove.
6816 (emacs_fixed_new): Take frame as argument.
6817
6818 * emacsgtkfixed.c: State that this is only used with Gtk+3.
6819 (_EmacsFixedPrivate): Remove minwidth/height.
6820 Add struct frame *f.
6821 (emacs_fixed_init): Initialize priv->f.
6822 (get_parent_class, emacs_fixed_set_min_size): Remove.
6823 (emacs_fixed_new): Set priv->f to argument.
6824 (emacs_fixed_get_preferred_width)
6825 (emacs_fixed_get_preferred_height): Use min_width/height from
6826 frames size_hint to set minimum and natural (Bug#8919).
6827 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
6828 and use min_width/height from frames size_hint to set
6829 min_width/height (Bug#8919).
6830
6831 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
6832 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
6833 Fix indentation.
c7e73be5 6834
cf99dcf8
EZ
68352011-06-26 Eli Zaretskii <eliz@gnu.org>
6836
6837 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
6838 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
6839 called at ZV.
6840
029529ac
CY
68412011-06-26 Chong Yidong <cyd@stupidchicken.com>
6842
6843 * process.c (wait_reading_process_output): Bypass select if
6844 waiting for a cell while ignoring keyboard input, and input is
6845 pending. Suggested by Jan Djärv (Bug#8869).
6846
7a7ef429
PE
68472011-06-25 Paul Eggert <eggert@cs.ucla.edu>
6848
6849 Use gnulib's dup2 module instead of rolling our own.
6850 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
6851
11fdef7d 68522011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
6853
6854 * dispnew.c (scrolling_window): Before scrolling, turn off a
6855 mouse-highlight in the window being scrolled.
6856
cd3520a4
JB
68572011-06-24 Juanma Barranquero <lekktu@gmail.com>
6858
6859 Move DEFSYM to lisp.h and use everywhere.
6860
6861 * character.h (DEFSYM): Move declaration...
6862 * lisp.h (DEFSYM): ...here.
6863
6864 * gnutls.c:
6865 * minibuf.c:
6866 * w32menu.c:
6867 * w32proc.c:
6868 * w32select.c: Don't include character.h.
6869
6870 * alloc.c (syms_of_alloc):
6871 * buffer.c (syms_of_buffer):
6872 * bytecode.c (syms_of_bytecode):
6873 * callint.c (syms_of_callint):
6874 * casefiddle.c (syms_of_casefiddle):
6875 * casetab.c (init_casetab_once):
6876 * category.c (init_category_once, syms_of_category):
6877 * ccl.c (syms_of_ccl):
6878 * cmds.c (syms_of_cmds):
6879 * composite.c (syms_of_composite):
6880 * dbusbind.c (syms_of_dbusbind):
6881 * dired.c (syms_of_dired):
6882 * dispnew.c (syms_of_display):
6883 * doc.c (syms_of_doc):
6884 * editfns.c (syms_of_editfns):
6885 * emacs.c (syms_of_emacs):
6886 * eval.c (syms_of_eval):
6887 * fileio.c (syms_of_fileio):
6888 * fns.c (syms_of_fns):
6889 * frame.c (syms_of_frame):
6890 * fringe.c (syms_of_fringe):
6891 * insdel.c (syms_of_insdel):
6892 * keymap.c (syms_of_keymap):
6893 * lread.c (init_obarray, syms_of_lread):
6894 * macros.c (syms_of_macros):
6895 * msdos.c (syms_of_msdos):
6896 * print.c (syms_of_print):
6897 * process.c (syms_of_process):
6898 * search.c (syms_of_search):
6899 * sound.c (syms_of_sound):
6900 * syntax.c (init_syntax_once, syms_of_syntax):
6901 * terminal.c (syms_of_terminal):
6902 * textprop.c (syms_of_textprop):
6903 * undo.c (syms_of_undo):
6904 * w32.c (globals_of_w32):
6905 * window.c (syms_of_window):
6906 * xdisp.c (syms_of_xdisp):
6907 * xfaces.c (syms_of_xfaces):
6908 * xfns.c (syms_of_xfns):
6909 * xmenu.c (syms_of_xmenu):
6910 * xsettings.c (syms_of_xsettings):
6911 * xterm.c (syms_of_xterm): Use DEFSYM.
6912
4228cf16
TZ
69132011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
6914
cd3520a4 6915 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 6916
7fcccf1e
PE
69172011-06-23 Paul Eggert <eggert@cs.ucla.edu>
6918
7efb4e0e
PE
6919 Integer and buffer overflow fixes (Bug#8873).
6920
ff5844ad
PE
6921 * print.c (printchar, strout): Check for string overflow.
6922 (PRINTPREPARE, printchar, strout):
6923 Don't set size unless allocation succeeds.
6924
90532f02
PE
6925 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
6926 for sizes. Check for string overflow more accurately.
6927 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
6928
6d84508d
PE
6929 * macros.c: Integer and buffer overflow fixes.
6930 * keyboard.h (struct keyboard.kbd_macro_bufsize):
6931 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
6932 Use ptrdiff_t, not int, for sizes.
6933 Don't increment bufsize until after realloc succeeds.
6934 Check for size-calculation overflow.
6935 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
6936
437b2cb4
PE
6937 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
6938
8b9ac8b4
PE
6939 * lread.c: Integer overflow fixes.
6940 (read_integer): Radix is now EMACS_INT, not int,
6941 to improve quality of diagnostics for out-of-range radices.
6942 Calculate buffer size correctly for out-of-range radices.
6943 (read1): Check for integer overflow in radices, and in
6944 read-circle numbers.
82cb60d3
PE
6945 (read_escape): Avoid int overflow.
6946 (Fload, openp, read_buffer_size, read1)
6947 (substitute_object_recurse, read_vector, read_list, map_obarray):
6948 Use ptrdiff_t, not int, for sizes.
6949 (read1): Use EMACS_INT, not int, for sizes.
20270765 6950 Check for size overflow.
8b9ac8b4 6951
7fcccf1e
PE
6952 * image.c (cache_image): Check for size arithmetic overflow.
6953
bfbbd7e7
PE
6954 * lread.c: Integer overflow issues.
6955 (saved_doc_string_size, saved_doc_string_length)
6956 (prev_saved_doc_string_size, prev_saved_doc_string_length):
6957 Now ptrdiff_t, not int.
6958 (read1): Don't assume doc string length fits in int. Check for
6959 out-of-range doc string lengths.
6960 (read_list): Don't assume file position fits in int.
39019e54 6961 (read_escape): Check for hex character overflow.
bfbbd7e7 6962
4e323265
LL
69632011-06-22 Leo Liu <sdl.web@gmail.com>
6964
6965 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
6966 Move to minibuffer.el.
6967
85fece3e
PE
69682011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6969
20b84ce9 6970 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
6971 The following patches are for when GLYPH_DEBUG && !XASSERT.
6972 * dispextern.h (trace_redisplay_p, dump_glyph_string):
6973 * dispnew.c (flush_stdout):
6974 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
6975 Mark as externally visible.
6976 * dispnew.c (check_window_matrix_pointers): Now static.
6977 * dispnew.c (window_to_frame_vpos):
6978 * xfns.c (unwind_create_frame):
6979 * xterm.c (x_check_font): Remove unused local.
6980 * scroll.c (CHECK_BOUNDS):
6981 * xfaces.c (cache_fache): Rename local to avoid shadowing.
6982 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
6983 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
6984 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
6985 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
6986 Now static.
6987 (debug_method_add): Use va_list and vsprintf rather than relying
6988 on undefined behavior with wrong number of arguments.
6989 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
6990 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
6991 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
6992 since we're not interested in debugging glyphs with old libraries.
6993 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
6994 GCC 4.6.0's static checking.
6995
0766b489
PE
69962011-06-22 Paul Eggert <eggert@cs.ucla.edu>
6997
31fd4b32
PE
6998 Integer overflow and signedness fixes (Bug#8873).
6999 A few related buffer overrun fixes, too.
7000
b79e8648
PE
7001 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
7002
0766b489
PE
7003 * dispextern.h (struct face.stipple):
7004 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
7005 (x_bitmap_mask, x_allocate_bitmap_record)
7006 (x_create_bitmap_from_data, x_create_bitmap_from_file)
7007 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
7008 (x_create_bitmap_from_xpm_data):
7009 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
7010 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
7011 (.bitmaps_last):
7012 * xfaces.c (load_pixmap):
7013 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
7014 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
7015 (.bitmaps_last, struct x_output.icon_bitmap):
7016 Use ptrdiff_t, not int, for bitmap indexes.
7017 (x_allocate_bitmap_record): Check for size overflow.
7018 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
7019
b081724f
PE
7020 Use ptrdiff_t, not int, for overlay counts.
7021 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
7022 * editfns.c (overlays_around, get_pos_property):
7023 * textprop.c (get_char_property_and_overlay):
7024 * xdisp.c (next_overlay_change, note_mouse_highlight):
7025 * xfaces.c (face_at_buffer_position):
21514da7
PE
7026 * buffer.c (OVERLAY_COUNT_MAX): New macro.
7027 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
7028 (Fnext_overlay_change, Fprevious_overlay_change)
7029 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 7030 Use ptrdiff_t, not int, for sizes.
21514da7 7031 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 7032
3de73e5e
PE
7033 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
7034
2606c57b
PE
7035 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
7036 (x_session_initialize): Do not assume string length fits in int.
7037
aaafe47a
PE
7038 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
7039 This is unlikely, but can occur if DPI is outlandish.
7040
2674ddc8 7041 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
7042 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
7043
28154962
PE
7044 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
7045 * xrdb.c (magic_file_p, search_magic_path):
7046 Omit last arg SUFFIX; it was always 0. All callers changed.
7047 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
7048
7de51af5
PE
7049 * xfont.c (xfont_match): Avoid need for strlen.
7050
25ed6cc3
PE
7051 * xfns.c: Don't assume strlen fits in int.
7052 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
7053
4eab31dd
PE
7054 * xdisp.c (message_log_check_duplicate): Return intmax_t,
7055 not unsigned long, as we prefer signed integers. All callers changed.
7056 Detect integer overflow in repeat count.
7057 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 7058 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 7059
171e2a58
PE
7060 * termcap.c: Don't assume sizes fit in int and never overflow.
7061 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
7062 (gobble_line): Check for size-calculation overflow.
7063
ad39faca 7064 * minibuf.c (Fread_buffer):
6e5bb2dc 7065 * lread.c (intern, intern_c_string):
74ca2eb3
PE
7066 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
7067 Don't assume string length fits in int.
7068
52c61c22 7069 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
7070 * gtkutil.c (style_changed_cb): Avoid need for strlen.
7071
b5b8c9e5
PE
7072 * font.c: Don't assume string length fits in int.
7073 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
7074 Use ptrdiff_t, not int.
ccd6111c
PE
7075 (font_intern_prop): Don't assume string length fits in int.
7076 Don't assume integer property fits in fixnum.
7077 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 7078
882f0d81 7079 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 7080 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
7081 Reformulate so as not to need the command string.
7082 Invoke gzip -cd rather than gunzip, as it's more portable.
7083 (lock_info_type, lock_file_1, lock_file):
7084 Don't assume pid_t and time_t fit in unsigned long.
7085 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
7086 (current_lock_owner): Prefer signed type for sizes.
7087 Use memcpy, not strncpy, where memcpy is what is really wanted.
7088 Don't assume (via atoi) that time_t and pid_t fit in int.
7089 Check for time_t and/or pid_t out of range, e.g., via a network share.
7090 Don't alloca where an auto var works fine.
7091
93f4cf88
PE
7092 * fileio.c: Fix some integer overflow issues.
7093 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
7094 Don't assume string length fits in int.
7095 (directory_file_name): Don't assume string length fits in long.
7096 (make_temp_name): Don't assume pid fits in int, or that its print
7097 length is less than 20.
7098
f3e92b69
PE
7099 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
7100
1bfdaf10
PE
7101 * coding.c (make_subsidiaries): Don't assume string length fits in int.
7102
35016e9a
PE
7103 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
7104
3d1e65a1
PE
7105 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
7106 We prefer signed integers, even for size calculations.
7107
0b963a93
PE
7108 * emacs.c: Don't assume string length fits in 'int'.
7109 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
7110 (main): Don't invoke strlen when not needed.
7111
573f4b54
PE
7112 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
7113 (XD_DEBUG_MESSAGE): Don't waste a byte.
7114
989f33ba
PE
7115 * callproc.c (getenv_internal_1, getenv_internal)
7116 (Fgetenv_internal):
965d34eb
PE
7117 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
7118
e4d29b33
PE
7119 * lread.c (invalid_syntax): Omit length argument.
7120 All uses changed. This doesn't fix a bug, but it simplifies the
7121 code away from its former Hollerith-constant appearance, and it's
7122 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 7123 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 7124
eb49b136
PE
7125 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
7126 This didn't break anything, but it didn't help either.
7127 It's confusing to put a bogus integer in a place where the actual
7128 value does not matter.
9f62aeb1 7129 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 7130 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 7131
15375a22
PE
7132 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
7133 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
7134 implementation.
b61cc01c
PE
7135 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
7136 We prefer signed types, and the value cannot exceed the EMACS_INT
7137 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
7138 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
7139 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
7140 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 7141
53b2623d
PE
7142 * indent.c (sane_tab_width): New function.
7143 (current_column, scan_for_column, Findent_to, position_indentation)
7144 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 7145 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 7146
51cab52b 7147 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 7148
f2ed8a70
PE
7149 * lisp.h (lint_assume): New macro.
7150 * composite.c (composition_gstring_put_cache):
7151 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
7152
abe80cc6
PE
7153 * editfns.c, insdel.c:
7154 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 7155
b02c740e
PE
7156 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
7157
ebc96716
PE
7158 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
7159
b4e50fa0 7160 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 7161 Use much-faster test for byte-length change.
311d5d7c 7162 Don't assume string byte-length fits in 'int'.
a4cf38e4 7163 Check that character arg fits in 'int'.
85461888 7164 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 7165
c0c1ee9f
PE
7166 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
7167
a498d7f4
PE
7168 * fns.c (concat): Catch string overflow earlier.
7169 Do not rely on integer wraparound.
7170
51cab52b
PE
7171 * dispextern.h (struct it.overlay_strings_charpos)
7172 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
7173 * xdisp.c (forward_to_next_line_start)
7174 (back_to_previous_visible_line_start)
7175 (reseat_at_next_visible_line_start, next_element_from_buffer):
7176 Don't arbitrarily truncate the value of 'selective' to int.
7177
76031fad
PE
7178 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
7179
5eb55db9
PE
7180 * composite.c: Don't truncate sizes to 'int'.
7181 (composition_gstring_p, composition_reseat_it)
7182 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
7183 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
7184 not EMACS_UINT, for indexes.
5eb55db9 7185
0703a717
PE
7186 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
7187
d6202519
PE
7188 * buffer.c: Include <verify.h>.
7189 (struct sortvec.priority, struct sortstr.priority):
8961a454 7190 Now EMACS_INT, not int.
c20998a7 7191 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
7192 (struct sortstr.size, record_overlay_string)
7193 (struct sortstrlist.size, struct sortlist.used):
7194 Don't truncate size to int.
7195 (record_overlay_string): Check for size-calculation overflow.
d6202519 7196 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 7197
d5a19415
JM
71982011-06-22 Jim Meyering <meyering@redhat.com>
7199
029529ac 7200 Don't leak an XBM-image-sized buffer
d5a19415
JM
7201 * image.c (xbm_load): Free the image buffer after using it.
7202
a9041e6c
PE
72032011-06-21 Paul Eggert <eggert@cs.ucla.edu>
7204
7205 Port to Sun C.
7206 * composite.c (find_automatic_composition): Omit needless 'return 0;'
7207 that Sun C diagnosed.
7208 * fns.c (secure_hash): Fix pointer signedness issue.
7209 * intervals.c (static_offset_intervals): New function.
7210 (offset_intervals): Use it.
7211
7f3f739f
LL
72122011-06-21 Leo Liu <sdl.web@gmail.com>
7213
7214 * deps.mk (fns.o):
7215 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
7216 sha512.h.
7217
7218 * fns.c (secure_hash): Rename from crypto_hash_function and change
7219 the first arg to accept symbols.
5b66d427 7220 (Fsecure_hash): New primitive.
7f3f739f
LL
7221 (syms_of_fns): New symbols.
7222
76147d94
DD
72232011-06-20 Deniz Dogan <deniz@dogan.se>
7224
7225 * process.c (Fset_process_buffer): Clarify return value in
7226 docstring.
7227
7d7d0045
CY
72282011-06-18 Chong Yidong <cyd@stupidchicken.com>
7229
7230 * dispnew.c (add_window_display_history): Use BVAR.
7231
7232 * xdisp.c (debug_method_add): Use BVAR.
7233 (check_window_end, dump_glyph_matrix, dump_glyph)
7234 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
7235
7236 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
7237 Likewise.
7238
7239 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
7240 check till after the cache is created in init_frame_faces.
7241
ff2bc410
SM
72422011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
7243
7244 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
7245
28177add
PE
72462011-06-16 Paul Eggert <eggert@cs.ucla.edu>
7247
dd3482fe
PE
7248 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
7249 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
7250 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
7251
393d71f3 7252 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
7253 * fileio.c (Finsert_file_contents):
7254 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
7255 Remove the old (too-loose) buffer overflow checks.
7256 They weren't needed, since make_gap checks for buffer overflow.
7257 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
7258 The old code merely checked for Emacs fixnum overflow, and relied
7259 on undefined (wraparound) behavior. The new code avoids undefined
7260 behavior, and also checks for ptrdiff_t and/or size_t overflow.
7261
2e6813b0 7262 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
7263 Tune. Don't use wider integers than needed. Don't use alloca.
7264 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 7265
599a9e4f
PE
7266 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
7267
99561444
PE
7268 * insdel.c, lisp.h (buffer_overflow): New function.
7269 (insert_from_buffer_1, replace_range, replace_range_2):
7270 * insdel.c (make_gap_larger):
7271 * editfns.c (Finsert_char):
7272 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
7273
28177add
PE
7274 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
7275
e69dafad
PE
72762011-06-15 Paul Eggert <eggert@cs.ucla.edu>
7277
4baa020d 7278 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 7279
b1c46f02
PE
7280 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
7281 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
7282
e69dafad
PE
7283 * fileio.c: Don't assume EMACS_INT fits in off_t.
7284 (emacs_lseek): New static function.
7285 (Finsert_file_contents, Fwrite_region): Use it.
7286 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
7287
566684ea
PE
7288 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
7289
e6966cd6
PE
7290 * fns.c: Don't overflow int when computing a list length.
7291 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
7292 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
7293 truncation on 64-bit hosts. Check for QUIT every
7294 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
7295 faster and is responsive enough.
7296 (Flength): Report an error instead of overflowing an integer.
7297 (Fsafe_length): Return a float if the value is not representable
7298 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 7299 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 7300 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 7301
dd0b0efb
PE
7302 * alloc.c: Check that resized vectors' lengths fit in fixnums.
7303 (header_size, word_size): New constants.
7304 (allocate_vectorlike): Don't check size overflow here.
7305 (allocate_vector): Check it here instead, since this is the only
7306 caller of allocate_vectorlike that could cause overflow.
7307 Check that the new vector's length is representable as a fixnum.
7308
86fe5cfe
PE
7309 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
7310 The previous code was bogus. For example, next_almost_prime (32)
7311 returned 39, which is undesirable as it is a multiple of 3; and
7312 next_almost_prime (24) returned 25, which is a multiple of 5 so
7313 why was the code bothering to check for multiples of 7?
7314
80e88859
PE
7315 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
7316
4a2f0ad6
PE
7317 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
7318
f66c7cf8
PE
7319 Variadic C functions now count arguments with ptrdiff_t.
7320 This partly undoes my 2011-03-30 change, which replaced int with size_t.
7321 Back then I didn't know that the Emacs coding style prefers signed int.
7322 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
7323 were being counted with int, which may truncate counts on 64-bit
7324 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
7325 * lisp.h (struct Lisp_Subr.function.aMANY)
7326 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
7327 Arg counts are now ptrdiff_t, not size_t.
7328 All variadic functions and their callers changed accordingly.
7329 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
7330 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
7331 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
7332 * callint.c (Fcall_interactively): Check arg count for overflow,
7333 to avoid potential buffer overrun. Use signed char, not 'int',
7334 for 'varies' array, so that we needn't bother to check its size
7335 calculation for overflow.
7336 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
7337 * eval.c (apply_lambda):
7338 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
7339 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
7340 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
7341
a1759b76
PE
7342 * callint.c (Fcall_interactively): Don't use index var as event count.
7343
d96be9fc
PE
7344 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
7345 * mem-limits.h (SIZE): Remove; no longer used.
7346
a690a978 7347 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 7348
578c21e6
PE
7349 Remove unnecessary casts.
7350 * xterm.c (x_term_init):
7351 * xfns.c (x_set_border_pixel):
7352 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
7353 These aren't needed now that we assume ANSI C.
7354
96f53c6c
PE
7355 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
7356 It's more likely to cause problems (due to unsigned overflow)
7357 than to cure them.
7358
83c77d31
PE
7359 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
7360
ee2079f1
PE
7361 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
7362
6da65536
PE
7363 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
7364
7147c4a4
PE
7365 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
7366
193e32d9
PE
7367 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
7368
e5533da6
PE
7369 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
7370
9910e595
PE
7371 GLYPH_CODE_FACE returns EMACS_INT, not int.
7372 * dispextern.h (merge_faces):
7373 * xfaces.c (merge_faces):
01103c44
PE
7374 * xdisp.c (get_next_display_element, next_element_from_display_vector):
7375 Don't assume EMACS_INT fits in int.
9910e595 7376
2638320e
PE
7377 * character.h (CHAR_VALID_P): Remove unused parameter.
7378 * fontset.c, lisp.h, xdisp.c: All uses changed.
7379
045eb8d9
PE
7380 * editfns.c (Ftranslate_region_internal): Omit redundant test.
7381
c1f134b5
PE
7382 * fns.c (concat): Minor tuning based on overflow analysis.
7383 This doesn't fix any bugs. Use int to hold character, instead
7384 of constantly refetching from Emacs object. Use XFASTINT, not
7385 XINT, for value known to be a character. Don't bother comparing
7386 a single byte to 0400, as it's always less.
7387
395fcb93 7388 * floatfns.c (Fexpt):
327eeec8
PE
7389 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
7390
abbd3d23
PE
7391 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
7392 for characters.
7393
684a03ef
PE
7394 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
7395
0fed43f3
PE
7396 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
7397 Without this fix, on a 64-bit host (aset S 0 4294967386) would
7398 incorrectly succeed when S was a string, because 4294967386 was
7399 truncated before it was used.
7400
8fd02eb7
PE
7401 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
7402 Otherwise, an out-of-range integer could cause undefined behavior
7403 on a 64-bit host.
7404
f8c86b69
PE
7405 * composite.c: Use int, not EMACS_INT, for characters.
7406 (fill_gstring_body, composition_compute_stop_pos): Use int, not
7407 EMACS_INT, for values that are known to be in character range.
7408 This doesn't fix any bugs but is the usual style inside Emacs and
7409 may generate better code on 32-bit machines.
7410
34206dd2
PE
7411 Make sure a 64-bit char is never passed to ENCODE_CHAR.
7412 This is for reasons similar to the recent CHAR_STRING fix.
7413 * charset.c (Fencode_char): Check that character arg is actually
7414 a character. Pass an int to ENCODE_CHAR.
7415 * charset.h (ENCODE_CHAR): Verify that the character argument is no
7416 wider than 'int', as a compile-time check to prevent future regressions
7417 in this area.
7418
c5958d4c 7419 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
7420
7421 Make sure a 64-bit char is never passed to CHAR_STRING.
7422 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
7423 by silently ignoring the top 32 bits, allowing some values
7424 that were far too large to be valid characters.
7425 * character.h: Include <verify.h>.
7426 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
7427 arguments are no wider than unsigned, as a compile-time check
7428 to prevent future regressions in this area.
7429 * data.c (Faset):
01103c44 7430 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
7431 (Fsubst_char_in_region):
7432 * fns.c (concat):
7433 * xdisp.c (decode_mode_spec_coding):
7434 Adjust to CHAR_STRING's new requirement.
7435 * editfns.c (Finsert_char, Fsubst_char_in_region):
7436 * fns.c (concat): Check that character args are actually
7437 characters. Without this test, these functions did the wrong
7438 thing with wildly out-of-range values on 64-bit hosts.
7439
d37ca623
PE
7440 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
7441 These casts should not be needed on 32-bit hosts, either.
7442 * keyboard.c (read_char):
7443 * lread.c (Fload): Remove casts to unsigned.
7444
ea204efb
PE
7445 * lisp.h (UNSIGNED_CMP): New macro.
7446 This fixes comparison bugs on 64-bit hosts.
7447 (ASCII_CHAR_P): Use it.
7448 * casefiddle.c (casify_object):
01103c44 7449 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
7450 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
7451 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
7452 * dispextern.h (FACE_FROM_ID):
7453 * keyboard.c (read_char): Use UNSIGNED_CMP.
7454
41cb286c
PE
7455 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
7456 not to EMACS_INT, to avoid GCC warning.
7457
4a1b9832
PE
7458 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
7459
55daad71
PE
7460 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
7461 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
7462 isn't needed on 32-bit machines.
8f95c75c 7463
01103c44
PE
7464 * buffer.c (Fgenerate_new_buffer_name):
7465 Use EMACS_INT for count, not int.
0ceccced 7466 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
7467
7468 * data.c (Qcompiled_function): Now static.
7469
c6f072e7
PE
7470 * window.c (window_body_lines): Now static.
7471
20ce5912
PE
7472 * image.c (gif_load): Rename local to avoid shadowing.
7473
9c4c5f81
PE
7474 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
7475 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
7476 * alloc.c (make_save_value): Integer argument is now of type
7477 ptrdiff_t, not int.
7478 (mark_object): Use ptrdiff_t, not int.
7479 * lisp.h (pD): New macro.
7480 * print.c (print_object): Use it.
7481
c0c5c8ae
PE
7482 * alloc.c: Use EMACS_INT, not int, to count objects.
7483 (total_conses, total_markers, total_symbols, total_vector_size)
7484 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
7485 (total_free_floats, total_floats, total_free_intervals)
7486 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
7487 Now EMACS_INT, not int. All uses changed.
7488 (Fgarbage_collect): Compute overall total using a double, so that
7489 integer overflow is less likely to be a problem. Check for overflow
7490 when converting back to an integer.
5a25e253
PE
7491 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
7492 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
7493 These were 'int' variables that could overflow on 64-bit hosts;
7494 they were never used, so remove them instead of repairing them.
211a0b2a 7495 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
7496 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
7497 Previously, this ceilinged at INT_MAX, but that doesn't work on
7498 64-bit machines.
e46bb31a 7499 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 7500
c78baabf 7501 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 7502 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
7503 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
7504 when a (possibly-narrower) signed value would do just as well.
7505 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 7506
c9d624c6
PE
7507 * alloc.c: Catch some string size overflows that we were missing.
7508 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
7509 for convenience in STRING_BYTES_MAX.
7510 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
7511 The definition here is exact; the one in lisp.h was approximate.
7512 (allocate_string_data): Check for string overflow. This catches
7513 some instances we weren't catching before. Also, it catches
7514 size_t overflow on (unusual) hosts where SIZE_MAX <= min
7515 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
7516 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 7517
c9d624c6
PE
7518 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
7519 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 7520 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 7521
353032ce
PE
7522 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
7523
2bccce07
PE
7524 * alloc.c (Fmake_string): Check for out-of-range init.
7525
0ac30604
SM
75262011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
7527
7528 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
7529
c195f2de
JD
75302011-06-14 Jan Djärv <jan.h.d@swipnet.se>
7531
7532 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
7533 xg_get_default_scrollbar_width.
7534
7535 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
7536 (int_gtk_range_get_value): Move to the scroll bar part of the file.
7537 (style_changed_cb): Call update_theme_scrollbar_width and call
7538 x_set_scroll_bar_default_width and xg_frame_set_char_size for
7539 all frames (Bug#8505).
7540 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
7541 Call gtk_window_set_resizable if HAVE_GTK3.
7542 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
7543 and height if HAVE_GTK3 (Bug#8505).
7544 (scroll_bar_width_for_theme): New variable.
7545 (update_theme_scrollbar_width): New function.
7546 (xg_get_default_scrollbar_width): Move code to
7547 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
7548 (xg_initialize): Call update_theme_scrollbar_width.
7549
7550 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
7551
7552 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
7553
e10ac9f1
MR
75542011-06-12 Martin Rudalics <rudalics@gmx.at>
7555
7556 * frame.c (make_frame): Call other_buffer_safely instead of
7557 other_buffer.
7558
7559 * window.c (temp_output_buffer_show): Call display_buffer with
7560 second argument Vtemp_buffer_show_specifiers and reset latter
7561 immediately after the call.
7562 (Vtemp_buffer_show_specifiers): New variable.
7563 (auto_window_vscroll_p, next_screen_context_lines)
7564 (Vscroll_preserve_screen_position): Remove leading asterisks from
7565 doc-strings.
7566
2d3c217e 75672011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 7568
7b7f97e8 7569 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
7570 * buffer.c (Qclone_number): Remove for now, as it's unused.
7571 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
7572 (record_buffer): Remove unused local.
7573 * frame.c (other_visible_frames, frame_buffer_list): Now static.
7574 (set_frame_buffer_list): Remove; unused.
7575 * frame.h (other_visible_frames): Remove decl.
7576 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
7577 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
7578 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
7579 if HAVE_GPM.
7580 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
7581 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
7582 Define only if HAVE_GPM.
7583 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
7584 (update_hints_inhibit): Remove; never set. All uses removed.
7585 * widgetprv.h (emacsFrameClassRec): Remove decl.
7586 * window.c (delete_deletable_window): Now returns void, since it
7587 wasn't returning anything.
7588 (compare_window_configurations): Remove unused locals.
7589 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
7590 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
7591 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
7592 the same widths as pointers. This follows up on the 2011-05-06 patch.
7593 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
7594 * xterm.h: Likewise.
7595 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
7596
1384b89e
JB
75972011-06-12 Juanma Barranquero <lekktu@gmail.com>
7598
7599 * makefile.w32-in: Update dependencies.
7600 (LISP_H): Add lib/intprops.h.
7601
1100a63c
CY
76022011-06-11 Chong Yidong <cyd@stupidchicken.com>
7603
7604 * image.c (gif_load): Add animation frame delay to the metadata.
7605 (syms_of_image): Use DEFSYM. New symbol `delay'.
7606
6198ccd0
MR
76072011-06-11 Martin Rudalics <rudalics@gmx.at>
7608
7609 * window.c (delete_deletable_window): Re-add.
7610 (Fset_window_configuration): Rewrite to handle dead buffers and
7611 consequently deletable windows.
7612 (window_tree, Fwindow_tree): Remove. Supply functionality in
7613 window.el.
7614 (compare_window_configurations): Simplify code.
7615
b6e3633c
AS
76162011-06-11 Andreas Schwab <schwab@linux-m68k.org>
7617
1ab0dee5
AS
7618 * image.c (imagemagick_load_image): Fix type mismatch.
7619 (Fimagemagick_types): Likewise.
7620
b6e3633c
AS
7621 * window.h (replace_buffer_in_windows): Declare.
7622
9397e56f
MR
76232011-06-11 Martin Rudalics <rudalics@gmx.at>
7624
7625 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
7626 Qclone_number. Remove external declaration of Qdelete_window.
7627 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
7628 code.
640c8776
SM
7629 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
7630 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
7631 (Fother_buffer): Rewrite doc-string. Major rewrite for new
7632 buffer list implementation.
7633 (other_buffer_safely): New function.
7634 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
7635 calls to replace_buffer_in_windows and
7636 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
7637 if allowed.
7638 (record_buffer): Inhibit quitting and rewrite using quittable
7639 functions. Run Qbuffer_list_update_hook if allowed.
7640 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
7641 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
7642 Move switch-to-buffer to window.el.
9397e56f
MR
7643 (bury-buffer): Move to window.el.
7644 (Vbuffer_list_update_hook): New variable.
7645
7646 * lisp.h (other_buffer_safely): Add prototype in buffer.c
7647 section.
7648
7649 * window.h (resize_frame_windows): Move up in code.
7650 (Fwindow_frame): Remove EXFUN.
7651 (replace_buffer_in_all_windows): Remove prototype.
7652 (replace_buffer_in_windows_safely): Add prototype.
7653
7654 * window.c: Declare Qdelete_window static again. Move down
7655 declaration of select_count.
7656 (Fnext_window, Fprevious_window): Rewrite doc-strings.
7657 (Fother_window): Move to window.el.
7658 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
7659 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
7660 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
7661 window.el.
7662 (replace_buffer_in_windows): Implement by calling
7663 Qreplace_buffer_in_windows.
7664 (replace_buffer_in_all_windows): Remove with some functionality
7665 moved into replace_buffer_in_windows_safely.
7666 (replace_buffer_in_windows_safely): New function.
7667 (select_window_norecord, select_frame_norecord): Move in front
7668 of run_window_configuration_change_hook. Remove now obsolete
7669 declarations.
640c8776
SM
7670 (Fset_window_buffer): Rewrite doc-string.
7671 Call Qrecord_window_buffer.
9397e56f
MR
7672 (keys_of_window): Move binding for other-window to window.el.
7673
b50691aa
CY
76742011-06-11 Chong Yidong <cyd@stupidchicken.com>
7675
7676 * dispextern.h (struct image): Replace data member, whose int_val
7677 and ptr_val fields were not used by anything, with a single
7678 lisp_val object.
7679
7680 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
7681 (gif_clear_image, gif_load, imagemagick_load_image)
7682 (gs_clear_image, gs_load): Callers changed.
7683
3f754b86
PE
76842011-06-10 Paul Eggert <eggert@cs.ucla.edu>
7685
cca69397
PE
7686 * buffer.h: Include <time.h>, for time_t.
7687 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
7688
109e28d0
PE
7689 Fix minor problems found by static checking.
7690
60737f02
PE
7691 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
7692
4b66faf3
PE
7693 Make identifiers static if they are not used in other modules.
7694 * data.c (Qcompiled_function, Qframe, Qvector):
7695 * image.c (QimageMagick, Qsvg):
7696 * minibuf.c (Qmetadata):
7697 * window.c (resize_window_check, resize_root_window): Now static.
7698 * window.h (resize_window_check, resize_root_window): Remove decls.
7699
109e28d0
PE
7700 * window.c (window_deletion_count, delete_deletable_window):
7701 Remove; unused.
46a4ce9e
PE
7702 (window_body_lines): Now static.
7703 (Fdelete_other_windows_internal): Mark vars as initialized.
7704 Make sure 'resize_failed' is initialized.
7705 (run_window_configuration_change_hook): Rename local to avoid shadowing.
7706 (resize_window_apply): Remove unused local.
7707 * window.h (delete_deletable_window): Remove decl.
7708
109e28d0 7709 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
7710 (imagemagick_load_image): Fix pointer signedness problem by changing
7711 last arg from unsigned char * to char *. All uses changed.
7712 Also, fix a local for similar reasons.
7713 Remove unused locals. Remove locals to avoid shadowing.
7714 (fn_rsvg_handle_free): Remove; unused.
7715 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 7716 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 7717
3f754b86
PE
7718 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
7719
2547adb1
CY
77202011-06-10 Chong Yidong <cyd@stupidchicken.com>
7721
7722 * image.c (gif_load): Fix omitted cast error introduced by
7723 2011-06-06 change.
7724
2c8e37d4
MR
77252011-06-10 Martin Rudalics <rudalics@gmx.at>
7726
7727 * window.h (resize_proportionally, orig_total_lines)
7728 (orig_top_line): Remove from window structure.
7729 (set_window_height, set_window_width, change_window_heights)
7730 (Fdelete_window): Remove prototypes.
7731 (resize_frame_windows): Remove duplicate declaration.
7732
440a42e3
EZ
77332011-06-10 Eli Zaretskii <eliz@gnu.org>
7734
7735 * window.h (resize_frame_windows, resize_window_check)
7736 (delete_deletable_window, resize_root_window)
7737 (resize_frame_windows): Declare prototypes.
7738
7739 * window.c (resize_window_apply): Make definition be "static" to
7740 match the prototype.
7741
562dd5e9
MR
77422011-06-10 Martin Rudalics <rudalics@gmx.at>
7743
7744 * window.c: Remove declarations of Qwindow_size_fixed,
7745 window_min_size_1, window_min_size_2, window_min_size,
7746 size_window, window_fixed_size_p, enlarge_window, delete_window.
7747 Remove static from declaration of Qdelete_window, it's
7748 temporarily needed by Fbury_buffer.
7749 (replace_window): Don't assign orig_top_line and
7750 orig_total_lines.
7751 (Fdelete_window, delete_window): Remove. Window deletion is
7752 handled by window.el.
640c8776
SM
7753 (window_loop): Remove DELETE_OTHER_WINDOWS case.
7754 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
7755 (Fdelete_other_windows): Remove. Deleting other windows is
7756 handled by window.el.
7757 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
7758 handled in window.el.
7759 (window_min_size_2, window_min_size_1, window_min_size): Remove.
7760 Window minimum sizes are handled in window.el.
7761 (shrink_windows, size_window, set_window_height)
7762 (set_window_width, change_window_heights, window_height)
7763 (window_width, CURBEG, CURSIZE, enlarge_window)
7764 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
7765 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
7766 handled in window.el.
7767 (make_dummy_parent): Rename to make_parent_window and give it a
7768 second argument horflag.
7769 (make_window): Don't set resize_proportionally any more.
7770 (Fsplit_window): Remove. Windows are split in window.el.
7771 (save_restore_action, save_restore_orig_size)
7772 (shrink_window_lowest_first, save_restore_orig_size): Remove.
7773 Resize mini windows in window.el.
7774 (grow_mini_window, shrink_mini_window): Implement by calling
7775 Qresize_root_window_vertically, resize_window_check and
7776 resize_window_apply.
640c8776
SM
7777 (saved_window, Fset_window_configuration, save_window_save):
7778 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
7779 resize_proportionally.
7780 (window_min_height, window_min_width): Move to window.el.
7781 (keys_of_window): Move bindings for delete-other-windows,
7782 split-window, delete-window and enlarge-window to window.el.
7783
7784 * buffer.c: Temporarily extern Qdelete_window.
7785 (Fbury_buffer): Temporarily call Qdelete_window instead of
7786 Fdelete_window (Fbury_buffer will move to window.el soon).
7787
7788 * frame.c (set_menu_bar_lines_1): Remove code handling
7789 orig_top_line and orig_total_lines.
7790
7791 * dispnew.c (adjust_frame_glyphs_initially): Don't use
7792 set_window_height but set heights directly.
7793 (change_frame_size_1): Use resize_frame_windows.
7794
7795 * xdisp.c (init_xdisp): Don't use set_window_height but set
7796 heights directly.
7797
640c8776
SM
7798 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
7799 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
7800 run_window_configuration_change_hook.
7801
7802 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
7803 instead of change_window_heights and run
7804 run_window_configuration_change_hook.
7805
1a13852e
MR
78062011-06-09 Martin Rudalics <rudalics@gmx.at>
7807
7808 * window.c (replace_window): Rename second argument REPLACEMENT to
7809 NEW. New third argument SETFLAG. Rewrite.
7810 (delete_window, make_dummy_parent): Call replace_window with
7811 third argument 1.
7812 (window_list_1): Move down in code.
7813 (run_window_configuration_change_hook): Move set_buffer part
7814 before select_frame_norecord part in order to unwind correctly.
7815 Rename count1 to count.
7816 (recombine_windows, delete_deletable_window, resize_root_window)
7817 (Fdelete_other_windows_internal)
7818 (Frun_window_configuration_change_hook, make_parent_window)
7819 (resize_window_check, resize_window_apply, Fresize_window_apply)
7820 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
7821 (Fdelete_window_internal, Fresize_mini_window_internal):
7822 New functions.
1a13852e
MR
7823 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
7824
f3d1777e
MR
78252011-06-08 Martin Rudalics <rudalics@gmx.at>
7826
496e208e
MR
7827 * window.h (window): Add some new members to window structure -
7828 normal_lines, normal_cols, new_total, new_normal, clone_number,
7829 splits, nest, prev_buffers, next_buffers.
7830 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 7831 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 7832
f3d1777e
MR
7833 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
7834 Remove.
496e208e
MR
7835 (make_dummy_parent): Set new members of windows structure.
7836 (make_window): Move down in code. Handle new members of window
7837 structure.
7838 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
7839 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
7840 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
7841 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
7842 (Fset_window_next_buffers, Fset_window_clone_number):
7843 New functions.
496e208e
MR
7844 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
7845 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
7846 Doc-string fixes.
7847 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
7848 Argument WINDOW can be now internal window too.
7849 (Fwindow_use_time): Move up in code.
7850 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
7851 Rewrite doc-string.
7852 (Fset_window_configuration, saved_window)
7853 (Fcurrent_window_configuration, save_window_save): Handle new
7854 members of window structure.
b9e809c2
MR
7855 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
7856 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
7857 (syms_of_window): New Lisp objects Qrecord_window_buffer,
7858 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
7859 Qget_mru_window, Qresize_root_window,
7860 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
7861 Qauto_buffer_name; staticpro them.
f3d1777e 7862
abde8f8c
MR
78632011-06-07 Martin Rudalics <rudalics@gmx.at>
7864
7865 * window.c (Fwindow_total_size, Fwindow_left_column)
7866 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
7867 (Fwindow_list_1): New functions.
7868 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
7869 (Fwindow_width, Fscroll_left, Fscroll_right):
7870 Use window_body_cols instead of window_box_text_cols.
7871 (delete_window, Fset_window_configuration):
7872 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
7873 (delete_all_subwindows): Take a window as argument and not a
7874 structure. Rewrite.
190b47e6
MR
7875 (window_loop): Remove handling of GET_LRU_WINDOW and
7876 GET_LARGEST_WINDOW.
7877 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
7878
7879 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
7880 window_box_text_cols. delete_all_subwindows now takes a
7881 Lisp_Object as argument.
abde8f8c 7882
640c8776
SM
7883 * indent.c (compute_motion, Fcompute_motion):
7884 Use window_body_cols instead of window_box_text_cols.
abde8f8c 7885
fa8a67e6
MR
7886 * frame.c (delete_frame): Call delete_all_subwindows with root
7887 window as argument.
7888
a54e3482
DC
78892011-06-07 Daniel Colascione <dan.colascione@gmail.com>
7890
7891 * fns.c (Fputhash): Document return value.
7892
60002bf5
CY
78932011-06-06 Chong Yidong <cyd@stupidchicken.com>
7894
7895 * image.c (gif_load): Implement gif89a spec "no disposal" method.
7896
0c671da6 78972011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 7898
b862a52a 7899 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 7900
be44ca6c
PE
7901 Check for overflow when converting integer to cons and back.
7902 * charset.c (Fdefine_charset_internal, Fdecode_char):
7903 Use cons_to_unsigned to catch overflow.
7904 (Fencode_char): Use INTEGER_TO_CONS.
7905 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
7906 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
7907 * data.c (long_to_cons, cons_to_long): Remove.
7908 (cons_to_unsigned, cons_to_signed): New functions.
7909 These signal an error for invalid or out-of-range values.
7910 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
7911 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
7912 * font.c (Ffont_variation_glyphs):
7913 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
7914 * lisp.h: Include <intprops.h>.
7915 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
7916 (cons_to_signed, cons_to_unsigned): New decls.
7917 (long_to_cons, cons_to_long): Remove decls.
7918 * undo.c (record_first_change): Use INTEGER_TO_CONS.
7919 (Fprimitive_undo): Use CONS_TO_INTEGER.
7920 * xfns.c (Fx_window_property): Likewise.
7921 * xselect.c: Include <limits.h>.
7922 (x_own_selection, selection_data_to_lisp_data):
7923 Use INTEGER_TO_CONS.
7924 (x_handle_selection_request, x_handle_selection_clear)
7925 (x_get_foreign_selection, Fx_disown_selection_internal)
7926 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
7927 (lisp_data_to_selection_data): Use cons_to_unsigned.
7928 (x_fill_property_data): Use cons_to_signed.
7929 Report values out of range.
7930
d1f3d2af
PE
7931 Check for buffer and string overflow more precisely.
7932 * buffer.h (BUF_BYTES_MAX): New macro.
7933 * lisp.h (STRING_BYTES_MAX): New macro.
7934 * alloc.c (Fmake_string):
7935 * character.c (string_escape_byte8):
7936 * coding.c (coding_alloc_by_realloc):
7937 * doprnt.c (doprnt):
7938 * editfns.c (Fformat):
7939 * eval.c (verror):
7940 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
7941 since they may not be the same number.
7942 * editfns.c (Finsert_char):
7943 * fileio.c (Finsert_file_contents):
7944 Likewise for BUF_BYTES_MAX.
7945
dd52fcea
PE
7946 * image.c: Use ptrdiff_t, not int, for sizes.
7947 (slurp_file): Switch from int to ptrdiff_t.
7948 All uses changed.
7949 (slurp_file): Check that file size fits in both size_t (for
7950 malloc) and ptrdiff_t (for sanity and safety).
7951
7f9bbdbb
PE
7952 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
7953 if b->modtime has its maximal value.
7954
dfe18f82
PE
7955 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
7956
84acfcf0
PE
7957 Don't assume time_t can fit into int.
7958 * buffer.h (struct buffer.modtime): Now time_t, not int.
7959 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
7960 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
7961
ccd9a01a
PE
7962 Minor fixes for signed vs unsigned integers.
7963 * character.h (MAYBE_UNIFY_CHAR):
7964 * charset.c (maybe_unify_char):
7965 * keyboard.c (read_char, reorder_modifiers):
7966 XINT -> XFASTINT, since the integer must be nonnegative.
7967 * ftfont.c (ftfont_spec_pattern):
7968 * keymap.c (access_keymap, silly_event_symbol_error):
7969 XUINT -> XFASTINT, since the integer must be nonnegative.
7970 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
7971 since it makes no difference and we prefer signed.
7972 * keyboard.c (record_char): Use XUINT when all the neighbors do.
7973 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
7974 nonnegative.
7975
d6d100dd
SM
79762011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
7977
7978 * window.h (Fwindow_frame): Declare.
7979
2b6148e4
PE
79802011-06-06 Paul Eggert <eggert@cs.ucla.edu>
7981
7982 * alloc.c: Simplify handling of large-request failures (Bug#8800).
7983 (SPARE_MEMORY): Always define.
7984 (LARGE_REQUEST): Remove.
7985 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
7986
f230ecc9
MR
79872011-06-06 Martin Rudalics <rudalics@gmx.at>
7988
727e958e
MR
7989 * lisp.h: Move EXFUNS for Fframe_root_window,
7990 Fframe_first_window and Fset_frame_selected_window to window.h.
7991
7992 * window.h: Move EXFUNS for Fframe_root_window,
7993 Fframe_first_window and Fset_frame_selected_window here from
7994 lisp.h.
7995
7996 * frame.c (Fwindow_frame, Fframe_first_window)
7997 (Fframe_root_window, Fframe_selected_window)
7998 (Fset_frame_selected_window): Move to window.c.
7999 (Factive_minibuffer_window): Move to minibuf.c.
8000 (Fother_visible_frames_p): New function.
8001
8002 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
8003
f230ecc9
MR
8004 * window.c (decode_window, decode_any_window): Move up in code.
8005 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
8006 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
8007 (Fwindow_buffer): Move up and rewrite doc-string.
8008 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
8009 (Fwindow_prev): New functions.
727e958e
MR
8010 (Fwindow_frame): Move here from frame.c. Accept any window as
8011 argument.
8012 (Fframe_root_window, Fframe_first_window)
8013 (Fframe_selected_window): Move here from frame.c. Accept frame
8014 or arbitrary window as argument. Update doc-strings.
8015 (Fminibuffer_window): Move up in code.
8016 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
8017 (Fset_frame_selected_window): Move here from frame.c.
8018 Marginal rewrite.
727e958e
MR
8019 (Fselected_window, select_window, Fselect_window): Move up in
8020 code. Minor doc-string fixes.
f230ecc9 8021
4d09bcf6
PE
80222011-06-06 Paul Eggert <eggert@cs.ucla.edu>
8023
8024 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
8025 Do not assume that spare memory exists; that assumption is valid
8026 only if SYSTEM_MALLOC.
8027 (LARGE_REQUEST): New macro, so that the issue of large requests
8028 is separated from the issue of spare memory.
8029
810928a2
AS
80302011-06-05 Andreas Schwab <schwab@linux-m68k.org>
8031
172418ad
AS
8032 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
8033 format. (Bug#8806)
8034
43f862f7
AS
8035 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
8036
810928a2
AS
8037 * xfns.c (x_set_scroll_bar_default_width): Move declarations
8038 before statements.
8039
a059fe24
JD
80402011-06-05 Jan Djärv <jan.h.d@swipnet.se>
8041
8042 * gtkutil.c (xg_get_default_scrollbar_width): New function.
8043
8044 * gtkutil.h: Declare xg_get_default_scrollbar_width.
8045
8046 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
8047 min width by calling x_set_scroll_bar_default_width (Bug#8505).
8048
989bf368
JB
80492011-06-05 Juanma Barranquero <lekktu@gmail.com>
8050
8051 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
8052
4b80f674
CY
80532011-06-04 Chong Yidong <cyd@stupidchicken.com>
8054
8055 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
8056 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
8057 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
8058 New error handlers.
4b80f674
CY
8059 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
8060 Obey Vx_select_enable_clipboard_manager. Catch errors in
8061 x_clipboard_manager_save (Bug#8779).
8062 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 8063 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 8064
99a33b77 80652011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
8066
8067 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
8068
99a33b77 80692011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
8070
8071 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
8072 in the current matrix if keep_current_p is non-zero.
8073
8264569d
EZ
80742011-06-04 Eli Zaretskii <eliz@gnu.org>
8075
8076 * bidi.c (bidi_level_of_next_char): Fix last change.
8077
57f97249
EZ
80782011-06-03 Eli Zaretskii <eliz@gnu.org>
8079
fec2107c 8080 Support bidi reordering of text covered by display properties.
57f97249 8081
fec2107c
EZ
8082 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
8083 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
8084 (bidi_cache_search, bidi_cache_iterator_state)
8085 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
8086 (bidi_level_of_next_char, bidi_move_to_visually_next):
8087 Support character positions inside a run of characters covered by a
fec2107c
EZ
8088 display string.
8089 (bidi_paragraph_init, bidi_resolve_explicit_1)
8090 (bidi_level_of_next_char): Call bidi_fetch_char and
8091 bidi_fetch_char_advance instead of FETCH_CHAR and
8092 FETCH_CHAR_ADVANCE.
8093 (bidi_init_it): Initialize new members.
8094 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
8095 definitions.
8096 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
8097 instead of using explicit *_CHAR codes.
d6d100dd
SM
8098 (bidi_resolve_explicit, bidi_resolve_weak):
8099 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
8100 bidirectional text is supported only in multibyte buffers.
8101 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
8102 it to initialize the frame_window_p member of struct bidi_it.
8103 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
8104 (bidi_resolve_explicit, bidi_resolve_weak)
8105 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
8106 bidi_it->nchars is non-positive.
8107 (bidi_level_of_next_char): Don't try to lookup the cache for the
8108 next/previous character if nothing is cached there yet, or if we
8109 were just reseat()'ed to a new position.
c40e2fb2 8110
0e14fe90
EZ
8111 * xdisp.c (set_cursor_from_row): Set start and stop points
8112 according to the row's direction when priming the loop that looks
8113 for the glyph on which to display cursor.
8114 (single_display_spec_intangible_p): Function deleted.
8115 (display_prop_intangible_p): Reimplement to call
8116 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
8117 Accept 3 additional arguments needed by handle_display_spec.
8118 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
8119 values: lists, `(when COND...)' forms, etc.
8120 (single_display_spec_string_p): Support property values that are
8121 lists with the argument STRING its top-level element.
8122 (display_prop_string_p): Fix the condition for processing a
8123 property that is a list to be consistent with handle_display_spec.
fec2107c 8124 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
8125 last portion of handle_display_prop.
8126 (compute_display_string_pos): Accept additional argument
8127 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
8128 value of a `display' property is a "replacing spec".
8129 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
8130 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
8131 the display property, but just return a value indicating whether
8132 the display property will replace the characters it covers.
8133 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
8134 frame_window_p members of struct bidi_it.
d6d100dd
SM
8135 (compute_display_string_pos, compute_display_string_end):
8136 New functions.
fec2107c
EZ
8137 (push_it): Accept second argument POSITION, where pop_it should
8138 jump to continue iteration.
8139 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 8140
fec2107c
EZ
8141 * keyboard.c (adjust_point_for_property): Adjust the call to
8142 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
8143
8144 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
8145 (bidi_init_it): Update prototypes.
8146 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
8147 (compute_display_string_pos, compute_display_string_end):
8148 Declare prototypes.
fec2107c
EZ
8149 (struct bidi_it): New members nchars and disp_pos. ch_len is now
8150 EMACS_INT.
fc6f18ce 8151
40087514 81522011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 8153
57f53182
PE
8154 Malloc failure behavior now depends on size of allocation.
8155 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
8156 * lisp.h: Change signatures accordingly.
8157 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
8158 All callers changed. (Bug#8762)
8159
8160 * gnutls.c: Use Emacs's memory allocators.
8161 Without this change, the gnutls library would invoke malloc etc.
8162 directly, which causes problems on non-SYNC_INPUT hosts, and which
8163 runs afoul of improving memory_full behavior. (Bug#8761)
8164 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
8165 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
8166 xfree instead of the default malloc, realloc, free.
8167 (Fgnutls_boot): No need to check for memory allocation failure,
8168 since xmalloc does that for us.
8169
ac32cd99 8170 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
8171 * category.c (hash_get_category_set):
8172 * ccl.c (ccl_driver):
8173 * charset.c (Fdefine_charset_internal):
8174 * charset.h (struct charset.hash_index):
8175 * composite.c (get_composition_id, gstring_lookup_cache)
8176 (composition_gstring_put_cache):
8177 * composite.h (struct composition.hash_index):
8178 * dispextern.h (struct image.hash):
8179 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
8180 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
8181 (hashfn_equal, hashfn_user_defined, make_hash_table)
8182 (maybe_resize_hash_table, hash_lookup, hash_put)
8183 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
8184 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
8185 (Fsxhash, Fgethash, Fputhash, Fmaphash):
8186 * image.c (make_image, search_image_cache, lookup_image)
8187 (xpm_put_color_table_h):
8188 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 8189 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 8190 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 8191 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
8192 * alloc.c (allocate_vectorlike):
8193 Check for overflow in vector size calculations.
8194 * ccl.c (ccl_driver):
8195 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
8196 * fns.c, image.c: Remove unnecessary static decls that would otherwise
8197 need to be updated by these changes.
40087514
PE
8198 * fns.c (make_hash_table, maybe_resize_hash_table):
8199 Check for integer overflow with large hash tables.
0de4bb68
PE
8200 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
8201 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
8202 (SXHASH_REDUCE): New macro.
8203 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
8204 Use it instead of discarding useful hash info with large hash values.
8205 (sxhash_float): New function.
8206 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
8207 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
8208 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
8209 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
8210 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
8211 Adjust signatures to match updated version of code.
8212 (consing_since_gc): Now EMACS_INT, since a single hash table can
8213 use more than INT_MAX bytes.
8214
698d32e2
DN
82152011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
8216
8217 Make it possible to build with GCC-4.6+ -O2 -flto.
8218
8219 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
8220
fd6fa53f
SM
82212011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
8222
8223 * minibuf.c (get_minibuffer, read_minibuf_unwind):
8224 Call minibuffer-inactive-mode.
8225
864db017
JB
82262011-05-31 Juanma Barranquero <lekktu@gmail.com>
8227
8228 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
8229 Update dependencies.
8230
2ad0baf4
DN
82312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8232
8233 * data.c (init_data): Remove code for UTS, this system is not
8234 supported anymore.
8235
4fcc2638
DN
82362011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8237
8238 Don't force ./temacs to start in terminal mode.
8239
8240 * frame.c (make_initial_frame): Initialize faces in all cases, not
8241 only when CANNOT_DUMP is defined.
8242 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
8243
c56e0fd5
DN
82442011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8245
8246 * dispnew.c (add_window_display_history): Use const for the string
8247 pointer. Remove declaration, not needed.
8248
333d54da 82492011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 8250
55d4c1b2 8251 Use 'inline', not 'INLINE'.
333d54da 8252 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
8253 * alloc.c, fontset.c (INLINE): Remove.
8254 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
8255 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
8256 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
8257 * gmalloc.c (register_heapinfo): Use inline unconditionally.
8258 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
8259
738db178
DN
82602011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
8261
8262 Make it possible to run ./temacs.
8263
8264 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
8265 syms_of_callproc does the same thing. Remove test for
8266 "initialized", do it in the caller.
8267 * emacs.c (main): Avoid calling set_initial_environment when dumping.
8268
620c53a6
SM
82692011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
8270
8271 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
8272 (read_minibuf): Use get_minibuffer.
8273 (syms_of_minibuf): Use DEFSYM.
8274 (Qmetadata): New var.
8275 * data.c (Qbuffer): Don't make it static.
8276 (syms_of_data): Use DEFSYM.
8277
e003a292
PE
82782011-05-31 Paul Eggert <eggert@cs.ucla.edu>
8279
8280 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
8281 (CCL_CODE_MIN): New macro.
8282
ed008a6d
PE
82832011-05-30 Paul Eggert <eggert@cs.ucla.edu>
8284
3687c2ef
PE
8285 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
8286
ed008a6d
PE
8287 * eval.c (Qdebug): Now static.
8288 * lisp.h (Qdebug): Remove decl. This reverts a part of the
8289 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
8290 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
8291
d66c4c7c
CY
82922011-05-29 Chong Yidong <cyd@stupidchicken.com>
8293
8294 * image.c: Various fixes to ImageMagick code comments.
8295 (Fimagemagick_types): Doc fix.
8296
5fbc2025
PE
82972011-05-29 Paul Eggert <eggert@cs.ucla.edu>
8298
0196f88a
PE
8299 Minor fixes prompted by GCC 4.6.0 warnings.
8300
8301 * xselect.c (converted_selections, conversion_fail_tag): Now static.
8302
5fbc2025
PE
8303 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
8304 (x_clipboard_manager_save_all): Move extern decl to ...
8305 * xterm.h: ... here, so that it can be checked for consistency.
8306
1dd3c2d9
CY
83072011-05-29 Chong Yidong <cyd@stupidchicken.com>
8308
8309 * xselect.c (x_clipboard_manager_save_frame)
8310 (x_clipboard_manager_save_all): New functions.
8311 (Fx_clipboard_manager_save): Lisp function deleted.
8312
8313 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
8314 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
8315
8316 * xterm.h: Update prototype.
8317
5ba6571d
WX
83182011-05-28 William Xu <william.xwl@gmail.com>
8319
8320 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
8321 exiting (Bug#8239).
8322
3eaff834
JM
83232011-05-28 Jim Meyering <meyering@redhat.com>
8324
e1900994 8325 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
8326 * fns.c (to_uchar): Define.
8327 (crypto_hash_function): Use it to convert some newly-signed
8328 variables to unsigned, to avoid sign-extension bugs. For example,
8329 without this change, (md5 "truc") would evaluate to
8330 45723a2aff78ff4fff7fff1114760e62 rather than the expected
8331 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 8332 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 8333
0f6990a7
PE
83342011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8335
8336 Integer overflow fixes.
c8a9ca5a 8337
08686060
PE
8338 * dbusbind.c: Serial number integer overflow fixes.
8339 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
8340 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
8341 to hold a serial number that is too large for a fixnum.
8342 (Fdbus_method_return_internal, Fdbus_method_error_internal):
8343 Check for serial numbers out of range. Decode any serial number
59568bf0 8344 that was so large that it became a float. (Bug#8722)
08686060 8345
2d1fc3c7
PE
8346 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
8347 (Fdbus_call_method, Fdbus_call_method_asynchronously):
8348 Use XFASTINT rather than XUINT when numbers are nonnegative.
8349 (xd_append_arg, Fdbus_method_return_internal):
8350 (Fdbus_method_error_internal): Likewise. Also, for unsigned
8351 arguments, check that Lisp number is nonnegative, rather than
59568bf0 8352 silently wrapping negative numbers around. (Bug#8722)
30217ff0 8353 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 8354 (Bug#8722)
2d1fc3c7 8355
c8a9ca5a
PE
8356 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
8357
519e1d69
PE
8358 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
8359
6df6ae42 8360 ccl: Add integer overflow checks.
30569699
PE
8361 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
8362 (IN_INT_RANGE): New macros.
8363 (ccl_driver): Use them to check for integer overflow when
8364 decoding a CCL program. Many of the new checks are whether XINT (x)
8365 fits in int; it doesn't always, on 64-bit hosts. The new version
8366 doesn't catch all possible integer overflows, but it's an
847044ea 8367 improvement. (Bug#8719)
30569699 8368
c11285dc
PE
8369 * alloc.c (make_event_array): Use XINT, not XUINT.
8370 There's no need for unsigned here.
8371
fdccd48e
PE
8372 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
8373 This follows up to the 2011-05-06 change that substituted uintptr_t
8374 for EMACS_INT. This case wasn't caught back then.
8375
37910ab2
PE
8376 Rework Fformat to avoid integer overflow issues.
8377 * editfns.c: Include <float.h> unconditionally, as it's everywhere
8378 now (part of C89). Include <verify.h>.
8379 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
8380 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
8381 (Fformat): Avoid the prepass trying to compute sizes; it was only
8382 approximate and thus did not catch overflow reliably. Instead, walk
8383 through the format just once, formatting and computing sizes as we go,
8384 checking for integer overflow at every step, and allocating a larger
8385 buffer as needed. Keep track separately whether the format is
8386 multibyte. Keep only the most-recently calculated precision, rather
8387 than them all. Record whether each argument has been converted to
8388 string. Use EMACS_INT, not int, for byte and char and arg counts.
8389 Support field widths and precisions larger than INT_MAX. Avoid
8390 sprintf's undefined behavior with conversion specifications such as %#d
8391 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
8392 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
8393 formatting out-of-range floating point numbers with int
9173deec 8394 formats. (Bug#8668)
37910ab2 8395
2e6578fb
PE
8396 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
8397
0ae6bdee
PE
8398 * data.c: Avoid integer truncation in expressions involving floats.
8399 * data.c: Include <intprops.h>.
8400 (arith_driver): When there's an integer overflow in an expression
8401 involving floating point, convert the integers to floating point
8402 so that the resulting value does not suffer from catastrophic
8403 integer truncation. For example, on a 64-bit host (* 4
8404 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
8405 Do not rely on undefined behavior after integer overflow.
8406
de883a70
PE
8407 merge count_size_as_multibyte, parse_str_to_multibyte
8408 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 8409 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
8410 Check for integer overflow.
8411 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
8412 since it's now a duplicate of the other. This is more of
8413 a character than a buffer op, so better that it's in character.c.
8414 * fns.c, print.c: Adjust to above changes.
8415
2ff916cb
PE
84162011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
8417
8418 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
8419
f1b54466
PE
84202011-05-27 Paul Eggert <eggert@cs.ucla.edu>
8421
fb1ac845
PE
8422 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8423 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
8424 (x_clipboard_manager_save): Now static.
8425 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
8426
f1b54466
PE
8427 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
8428 (crypto_hash_function): Now static.
8429 Fix pointer signedness problems. Avoid unnecessary initializations.
8430
a9f737ee
CY
84312011-05-27 Chong Yidong <cyd@stupidchicken.com>
8432
8433 * termhooks.h (Vselection_alist): Make it terminal-local.
8434
8435 * terminal.c (create_terminal): Initialize it.
8436
8437 * xselect.c: Support for clipboard managers.
8438 (Vselection_alist): Move to termhooks.h as terminal-local var.
8439 (LOCAL_SELECTION): New macro.
8440 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
8441 (symbol_to_x_atom): Remove gratuitous arg.
8442 (x_handle_selection_request, lisp_data_to_selection_data)
8443 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
8444 (x_own_selection, x_get_local_selection, x_convert_selection):
8445 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
8446 (some_frame_on_display): Delete unused function.
8447 (Fx_own_selection_internal, Fx_get_selection_internal)
8448 (Fx_disown_selection_internal, Fx_selection_owner_p)
8449 (Fx_selection_exists_p): New optional frame arg.
8450 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
8451 (x_handle_selection_clear): Don't treat other terminals with the
8452 same keyboard specially. Use the terminal-local Vselection_alist.
8453 (x_clear_frame_selections): Use Frun_hook_with_args.
8454
8455 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
8456
8457 * xterm.h: Add support for those atoms.
8458
e067f0c1
CY
84592011-05-26 Chong Yidong <cyd@stupidchicken.com>
8460
8461 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
8462 (converted_selections, conversion_fail_tag): New global variables.
8463 (x_selection_request_lisp_error): Free the above.
8464 (x_get_local_selection): Remove unnecessary code.
8465 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
8466 of converted selections stored in converted_selections.
8467 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
8468 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
8469 (x_convert_selection): New function.
8470 (x_handle_selection_event): Simplify.
8471 (x_get_foreign_selection): Don't ignore incoming requests while
8472 waiting for an answer; this will fail when we implement
8473 SAVE_TARGETS, and seems unnecessary anyway.
8474 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
8475 (Vx_sent_selection_functions): Doc fix.
8476
0f4aebc0
LL
84772011-05-26 Leo Liu <sdl.web@gmail.com>
8478
8479 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
8480
e61124cd
YM
84812011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8482
8483 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
8484
8485 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
8486 for fringe update if it has periodic bitmap.
ac389d0c 8487 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
8488 and fringe_bitmap_periodic_p.
8489
8490 * fringe.c (get_fringe_bitmap_data): New function.
8491 (draw_fringe_bitmap_1, update_window_fringes): Use it.
8492 (update_window_fringes): Record periodicity of fringe bitmap in glyph
8493 row. Mark glyph row for fringe update if periodicity changed.
8494
8495 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
8496 for fringe update unless it has periodic bitmap.
8497
f16d9837
KH
84982011-05-25 Kenichi Handa <handa@m17n.org>
8499
8500 * xdisp.c (get_next_display_element): Set correct it->face_id for
8501 a static composition.
8502
e1b90ef6
LL
85032011-05-24 Leo Liu <sdl.web@gmail.com>
8504
8505 * deps.mk (fns.o):
8506 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
8507
8508 * fns.c (crypto_hash_function, Fsha1): New function.
8509 (Fmd5): Use crypto_hash_function.
8510 (syms_of_fns): Add Ssha1.
8511
7400048f
PE
85122011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8513
8514 * gnutls.c: Remove unused macros.
8515 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
8516 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
8517 Remove macros that are defined and never used.
8518 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
8519
abb71cf4
CY
85202011-05-22 Chong Yidong <cyd@stupidchicken.com>
8521
8522 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
8523 (Fx_get_selection_internal): Minor cleanup.
8524 (Fx_own_selection_internal): Rename arguments for consistency with
8525 select.el.
8526
6307db39
PE
85272011-05-22 Paul Eggert <eggert@cs.ucla.edu>
8528
8529 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
8530
f3d4e0a4
CY
85312011-05-22 Chong Yidong <cyd@stupidchicken.com>
8532
8533 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
8534
4d8ade89
YM
85352011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
8536
8537 * dispnew.c (scrolling_window): Don't exclude the case that the
8538 last enabled row in the desired matrix touches the bottom boundary.
8539
32078c8d
GM
85402011-05-21 Glenn Morris <rgm@gnu.org>
8541
8542 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
8543 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
8544 and add some more files.
32078c8d 8545
7285dc67
EZ
85462011-05-20 Eli Zaretskii <eliz@gnu.org>
8547
8548 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
8549 report_file_error introduced by the change from 2011-05-07.
8550
89d1bd22
PE
85512011-05-20 Paul Eggert <eggert@cs.ucla.edu>
8552
8553 * systime.h (Time): Define only if emacs is defined.
8554 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
8555 where the include path doesn't have X11/X.h by default. See
8556 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
8557
cd394be1 85582011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
8559
8560 * composite.c (find_automatic_composition): Fix previous change.
8561
b9704ad9
GM
85622011-05-20 Glenn Morris <rgm@gnu.org>
8563
8564 * lisp.mk: New file, split from Makefile.in.
8565 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
8566 (shortlisp): Remove.
8567 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
8568
4a720484
GM
85692011-05-19 Glenn Morris <rgm@gnu.org>
8570
8571 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
8572 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
8573 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
8574 (lisp): Set the order to that of loadup.el.
8575 (shortlisp): Make it a copy of $lisp.
8576 (SOME_MACHINE_LISP): Remove.
8577 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
8578 Use just $shortlisp, not $SOME_MACHINE_LISP too.
8579
a28d4396
KH
85802011-05-18 Kenichi Handa <handa@m17n.org>
8581
8582 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
8583 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
8584 (find_automatic_composition): Mostly rewrite for efficiency.
8585
a2b1fa8e
JB
85862011-05-18 Juanma Barranquero <lekktu@gmail.com>
8587
8588 * makefile.w32-in: Update dependencies.
8589
8e1f5610
CS
85902011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
8591
8592 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 8593 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 8594
7025ee00 85952011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 8596
cdfa6eab
PE
8597 Fix some integer overflow issues, such as string length overflow.
8598
06d6db33
PE
8599 * insdel.c (count_size_as_multibyte): Check for string overflow.
8600
2b4560a8
PE
8601 * character.c (lisp_string_width): Check for string overflow.
8602 Use EMACS_INT, not int, for string indexes and lengths; in
8603 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
8604 the resulting string length overflows an EMACS_INT; instead,
8605 report a string overflow if no precision given. When checking for
8606 precision exhaustion, use a check that cannot possibly have
8607 integer overflow. (Bug#8675)
8608 * character.h (lisp_string_width): Adjust to new signature.
8609
cb93f9be
PE
8610 * alloc.c (string_overflow): New function.
8611 (Fmake_string): Use it. This doesn't change behavior, but saves
8612 a few bytes and will simplify future changes.
8613 * character.c (string_escape_byte8): Likewise.
8614 * lisp.h (string_overflow): New decl.
8615
1a1f3366
PE
8616 Fixups, following up to the user-interface timestamp change.
8617 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
8618 for UI timestamps, instead of unsigned long.
9fbd6841
PE
8619 * msdos.c (mouse_get_pos): Likewise.
8620 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
8621 * w32gui.h (Time): Define by including "systime.h" rather than by
8622 declaring it ourselves. (Bug#8664)
8623
d4e3e4d3
PE
8624 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
8625 * image.c (clear_image_cache): Likewise.
8626
f6a24d19
PE
8627 * term.c (term_mouse_position): Don't assume time_t wraparound.
8628
08dc5ae6
PE
8629 Be more systematic about user-interface timestamps.
8630 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
8631 and sometimes 'EMACS_UINT', to represent these timestamps.
8632 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
8633 This makes the code easier to follow, and makes it easier to catch
8634 integer overflow bugs such as Bug#8664.
8635 * frame.c (Fmouse_position, Fmouse_pixel_position):
8636 Use Time, not unsigned long, for user-interface timestamps.
8637 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
8638 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
8639 * keyboard.h (last_event_timestamp): Likewise.
8640 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
8641 * menu.h (xmenu_show): Likewise.
8642 * term.c (term_mouse_position): Likewise.
8643 * termhooks.h (struct input_event.timestamp): Likewise.
8644 (struct terminal.mouse_position_hook): Likewise.
8645 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
8646 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
8647 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
8648 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
8649 what it was before.
8650 * menu.h, termhooks.h: Include "systime.h", for Time.
8651
8e55734a
PE
8652 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
8653 Don't assume that the difference between two unsigned long values
8654 can fit into an integer. At this point, we know button_down_time
8655 <= event->timestamp, so the difference must be nonnegative, so
8656 there's no need to cast the result if double-click-time is
8657 nonnegative, as it should be; check that it's nonnegative, just in
8658 case. This bug is triggered when events are more than 2**31 ms
86db42d2 8659 apart (about 25 days). (Bug#8664)
8e55734a 8660
841f1b75 8661 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 8662 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 8663
3e26f69c
PE
8664 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
8665 that always fit in int. Use a sentinel instead of a counter, to
8666 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
8667 * frame.h (struct frame): Use int for menu_bar_items_used
8668 instead of EMACS_INT, since it always fits in int.
3e26f69c 8669
5cc152c0
PE
8670 * menu.c (grow_menu_items): Check for int overflow.
8671
d89eb65e
PE
8672 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
8673
5235bd3e
PE
8674 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
8675 Before, the code was not consistent. These values cannot exceed
8676 2**31 - 1 so there's no need to make them unsigned.
8677 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
8678 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
8679 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
8680 as modifiers.
8681 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
8682
bc827e23
PE
8683 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
8684 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
8685 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
8686 presumably because the widths might not match.
8687
78eb494e
PE
8688 * window.c (size_window): Avoid needless test at loop start.
8689
04f2d78b
CB
86902011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
8691
8692 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
8693
d2fc7e3d 86942011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
8695
8696 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
8697
d2fc7e3d 86982011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
8699
8700 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
8701 `width' to `bar_area_x' and `bar_area_width', respectively.
8702 (x_scroll_run): Take account of fringe background extension.
8703
04f2d78b
CB
8704 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
8705 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
8706 `bar_area_width', respectively.
8707 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
8708 background extension.
8709
79b70037
GM
87102011-05-10 Jim Meyering <meyering@redhat.com>
8711
8712 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
8713
2f142cc5
JB
87142011-05-10 Juanma Barranquero <lekktu@gmail.com>
8715
8716 * image.c (Finit_image_library): Return t for built-in image types,
8717 like pbm and xbm. (Bug#8640)
8718
57679c86
AS
87192011-05-09 Andreas Schwab <schwab@linux-m68k.org>
8720
8721 * w32menu.c (set_frame_menubar): Fix submenu allocation.
8722
888c9e86
EZ
87232011-05-07 Eli Zaretskii <eliz@gnu.org>
8724
b0512a1d
EZ
8725 * w32console.c (Fset_screen_color): Doc fix.
8726 (Fget_screen_color): New function.
8727 (syms_of_ntterm): Defsubr it.
8728
7285dc67
EZ
8729 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
8730 unlink the temporary file if Fcall_process didn't create it in the
8731 first place.
8732 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
8733 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
8734 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
8735 cue to call_process_cleanup not to close that handle.
8736
4d3fcc8e
BK
87372011-05-07 Ben Key <bkey76@gmail.com>
8738
8739 * makefile.w32-in: The bootstrap-temacs rule now makes use of
8740 one of two shell specific rules, either bootstrap-temacs-CMD or
8741 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
8742 to the previous implementation of the bootstrap-temacs rule.
8743 The bootstrap-temacs-CMD rule is similar to the previous
8744 implementation of the bootstrap-temacs rule except that it
8745 makes use of the ESC_CFLAGS variable instead of the CFLAGS
8746 variable.
8747
8748 These changes, along with some changes to nt/configure.bat,
8749 nt/gmake.defs, and nt/nmake.defs, are required to extend my
8750 earlier fix to add support for --cflags and --ldflags options
8751 that include quotes so that it works whether make uses cmd or
8752 sh as the shell.
8753
b4289b64
MA
87542011-05-06 Michael Albinus <michael.albinus@gmx.de>
8755
8756 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
8757 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
8758 is a constant.
8759 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
8760 a string. Handle both cases.
8761 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
8762 (Fdbus_register_method): Use Qinvalid_function.
8763
af4c0e28
JB
87642011-05-06 Juanma Barranquero <lekktu@gmail.com>
8765
8766 * makefile.w32-in: Update dependencies.
8767 (LISP_H): Add inttypes.h and stdin.h.
8768 (PROCESS_H): Add unistd.h.
8769
c51453d9
EZ
87702011-05-06 Eli Zaretskii <eliz@gnu.org>
8771
8772 * lread.c: Include limits.h (fixes the MS-Windows build broken by
8773 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
8774
8ff0ac3c 87752011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 8776
4c4b566b
PE
8777 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
8778
aab2b9b5
PE
8779 * term.c (vfatal): Remove stray call to va_end.
8780 It's not needed and the C Standard doesn't allow it here anyway.
8781
c378da0b
PE
8782 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
8783 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
8784
288b08c7
PE
8785 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
8786 bytes.
8787
e3601888
PE
8788 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
8789
db6c0e74
PE
8790 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8791
dd5963ea
PE
8792 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
8793
88c9450f
PE
8794 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
8795
2f9442b8
PE
8796 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
8797
c032b5f8
PE
8798 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
8799 * charset.c (Fdefine_charset_internal): Don't initialize
8800 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 8801 32-bit int (Bug#8600).
a108c10b
PE
8802
8803 * lread.c (read_integer): Be more consistent with string-to-number.
8804 Use string_to_number to do the actual conversion; this avoids
8805 rounding errors and fixes some other screwups. Without this fix,
8806 for example, #x1fffffffffffffff was misread as -2305843009213693952.
8807 (digit_to_number): Move earlier, for benefit of read_integer.
8808 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 8809 not a digit in any supported base. (Bug#8602)
a108c10b 8810
ad5f9eea
PE
8811 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
8812
aec1708a
PE
8813 * dispnew.c (scrolling_window): Return 1 if we scrolled,
8814 to match comment at start of function. This also removes a
8815 GCC warning about overflow in a 32+64-bit port.
8816
47be4ab5
PE
8817 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
8818
371cac43
PE
8819 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
8820 Reported by Stefan Monnier in
8821 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
8822 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8823 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 8824
d01a7826
PE
8825 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
8826 (EMACS_UINTPTR): Likewise, with uintptr_t.
8827
7fd47d5c
PE
8828 * lisp.h: Prefer 64-bit EMACS_INT if available.
8829 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
8830 on 32-bit hosts that have 64-bit int, so that they can access
8831 large files.
122b0c86
PE
8832 However, temporarily disable this change unless the temporary
8833 symbol WIDE_EMACS_INT is defined.
7fd47d5c 8834
8727937b
PE
8835 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
8836
8ac068ac
PE
8837 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
8838 This removes an assumption that EMACS_INT and long are the same
8839 width as pointers. The assumption is true for Emacs porting targets
8840 now, but we want to make other targets possible.
8841 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
8842 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
8843 In the rest of the code, change types of integers that hold casted
8844 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
8845 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
8846 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
8847 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
8848 No need to cast type when ORing.
8849 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
8850 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
8851 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
8852 assume EMACS_INT is the same width as char *.
8853 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
8854 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
8855 Remove no-longer-needed casts.
8856 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
8857 (xg_tool_bar_help_callback, xg_make_tool_item):
8858 Use EMACS_INTPTR to hold an integer
8859 that will be cast to void *; this can avoid a GCC warning
8860 if EMACS_INT is not the same width as void *.
8861 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
8862 * xdisp.c (display_echo_area_1, resize_mini_window_1):
8863 (current_message_1, set_message_1):
8864 Use a local to convert to proper width without a cast.
8865 * xmenu.c (dialog_selection_callback): Likewise.
8866
ede49d71
PE
8867 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
8868 Also, don't assume VALBITS / RAND_BITS is less than 5,
8869 and don't rely on undefined behavior when shifting a 1 left into
8870 the sign bit.
8871 * lisp.h (get_random): Change signature to match.
8872
2f30ecd0
PE
8873 * lread.c (hash_string): Use size_t, not int, for hash computation.
8874 Normally we prefer signed values; but hashing is special, because
8875 it's better to use unsigned division on hash table sizes so that
8876 the remainder is nonnegative. Also, size_t is the natural width
8877 for hashing into memory. The previous code used 'int', which doesn't
8878 retain enough info to hash well into very large tables.
8879 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
8880
2a866e7b
PE
8881 * dbusbind.c: Don't possibly lose pointer info when converting.
8882 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
8883 Use XPNTR rather than XHASH, so that the high-order bits of
8884 the pointer aren't lost when converting through void *.
8885
51639eac
PE
8886 * eval.c (Fautoload): Don't double-shift a pointer.
8887
92394119
PE
8888 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
8889
dbdb9a7c
JB
88902011-05-06 Juanma Barranquero <lekktu@gmail.com>
8891
8892 * gnutls.c (DEF_GNUTLS_FN):
8893 * image.c (DEF_IMGLIB_FN): Make function pointers static.
8894
db7a0b4f
AS
88952011-05-05 Andreas Schwab <schwab@linux-m68k.org>
8896
8897 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
8898 marker. (Bug#8610)
8899
cd394be1 89002011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
8901
8902 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
8903 New version that can reserve upto 2GB of heap space.
8904
f7ff1b0f 89052011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
8906
8907 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
8908
639c109b
TZ
89092011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
8910
8911 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
8912 `gnutls_certificate_set_x509_key_file'.
8913
d2127135
JB
89142011-05-05 Juanma Barranquero <lekktu@gmail.com>
8915
8916 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
8917 Update dependencies.
8918
e968f4f3
JB
89192011-05-04 Juanma Barranquero <lekktu@gmail.com>
8920
8921 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
8922 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
8923 Remove unused parameter `fildes'.
8924 * process.c (read_process_output, send_process): Don't pass it.
8925
84d358f0
JB
89262011-05-04 Juanma Barranquero <lekktu@gmail.com>
8927
8928 Fix previous change: the library cache is defined in w32.c.
8929 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
8930 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
8931
0898ca10
JB
89322011-05-04 Juanma Barranquero <lekktu@gmail.com>
8933
8934 Implement dynamic loading of GnuTLS on Windows.
8935
8936 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
8937 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
8938 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8939 Declare.
8940
8941 * gnutls.c (Qgnutls_dll): Define.
8942 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
8943 (gnutls_*): Declare function pointers.
8944 (init_gnutls_functions): New function to initialize function pointers.
8945 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
8946 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
8947 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
8948 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
8949 (emacs_gnutls_write, emacs_gnutls_read)
8950 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
8951 (Fgnutls_available_p): New function.
8952 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
8953 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
8954 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
8955
8956 * image.c: Include w32.h.
8957 (Vimage_type_cache): Delete.
8958 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
8959 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
8960 (w32_delayed_load): Move to w32.c.
8961
8962 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
8963
8964 * w32.c (QCloaded_from, Vlibrary_cache): Define.
8965 (w32_delayed_load): Move from image.c. When loading a library, record
8966 its filename in the :loaded-from property of the library id.
8967 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
8968 Initialize and staticpro them.
8969 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
8970
8971 * process.c: Include lisp.h before w32.h, not after.
8972 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
8973 instead of gnutls_record_check_pending.
8974
8975 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
8976
ff4de4aa
TZ
89772011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
8978
8979 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
8980 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
8981 as passed in.
8982
abe95abb
JD
89832011-05-03 Jan Djärv <jan.h.d@swipnet.se>
8984
8985 * xterm.c (x_set_frame_alpha): Do not set property on anything
8986 else than FRAME_X_OUTER_WINDOW (Bug#8608).
8987
e16e55d4
JB
89882011-05-02 Juanma Barranquero <lekktu@gmail.com>
8989
8990 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
8991
bafcf6a5
JB
89922011-05-02 Juanma Barranquero <lekktu@gmail.com>
8993
8994 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
8995 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
8996 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
8997 (gnutls_global_initialized, Qgnutls_bootprop_priority)
8998 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
8999 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
9000 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
9001 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
9002 (Qgnutls_bootprop_callbacks_verify): Make static.
9003
e7a6747f
AS
90042011-05-01 Andreas Schwab <schwab@linux-m68k.org>
9005
19ed11ba
AS
9006 * callproc.c: Indentation fixup.
9007
e7a6747f 9008 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
9009 (wait_for_termination, interruptible_wait_for_termination):
9010 Move after wait_for_termination_1.
e7a6747f 9011
1ef14cb4
LMI
90122011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
9013
9014 * sysdep.c (interruptible_wait_for_termination): New function
9015 which is like wait_for_termination, but allows keyboard
9016 interruptions.
9017
9018 * callproc.c (Fcall_process): Add (:file "file") as an option for
9019 the STDOUT buffer.
9020 (Fcall_process_region): Ditto.
9021
330d880c
EZ
90222011-04-30 Eli Zaretskii <eliz@gnu.org>
9023
8db90b73
EZ
9024 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
9025 rather than `XVECTOR (FOO)->size'.
9026
330d880c
EZ
9027 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
9028 inttypes.h, as a gnulib replacement is used if it not available in
9029 system headers.
9030
15cbd324
EZ
90312011-04-21 Eli Zaretskii <eliz@gnu.org>
9032
9033 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
9034 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
9035 of MOST_POSITIVE_FIXNUM. (Bug#8528)
9036
9037 * coding.c (coding_alloc_by_realloc): Error out if destination
9038 will grow beyond MOST_POSITIVE_FIXNUM.
9039 (decode_coding_emacs_mule): Abort if there isn't enough place in
9040 charbuf for the composition carryover bytes. Reserve an extra
9041 space for up to 2 characters produced in a loop.
9042 (decode_coding_iso_2022): Abort if there isn't enough place in
9043 charbuf for the composition carryover bytes.
9044
90452011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 9046
ae940cca
EZ
9047 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
9048 aborting when %lld or %lll format is passed.
9049 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
9050 %llo or %llx format is passed. (Bug#8545)
9051
03ab8921
EZ
9052 * window.c (window_scroll_line_based): Use a marker instead of
9053 simple variables to record original value of point. (Bug#7952)
9054
afda1437
EZ
9055 * doprnt.c (doprnt): Fix the case where a multibyte sequence
9056 produced by %s or %c overflows available buffer space. (Bug#8545)
9057
f76dee0c
PE
90582011-04-28 Paul Eggert <eggert@cs.ucla.edu>
9059
9060 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 9061 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 9062
fdc5744d
JB
90632011-04-28 Juanma Barranquero <lekktu@gmail.com>
9064
9065 * w32.c (init_environment): Warn about defaulting HOME to C:\.
9066
638f053a
JB
90672011-04-28 Juanma Barranquero <lekktu@gmail.com>
9068
9069 * keyboard.c (Qdelayed_warnings_hook): Define.
9070 (command_loop_1): Run `delayed-warnings-hook'
9071 if Vdelayed_warnings_list is non-nil.
9072 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
9073 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
9074
d178f871
EZ
90752011-04-28 Eli Zaretskii <eliz@gnu.org>
9076
9077 * doprnt.c (doprnt): Don't return value smaller than the buffer
9078 size if the message was truncated. (Bug#8545).
9079
b124fd93
JB
90802011-04-28 Juanma Barranquero <lekktu@gmail.com>
9081
9082 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
9083 (Fx_window_property): #if-0 the whole functions, not just the bodies.
9084
e810457d
PE
90852011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9086
9087 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
9088
ea51cceb
JB
90892011-04-27 Juanma Barranquero <lekktu@gmail.com>
9090
9091 * makefile.w32-in: Update dependencies.
9092
94dcfacf
EZ
90932011-04-27 Eli Zaretskii <eliz@gnu.org>
9094
9095 Improve `doprnt' and its usage. (Bug#8545)
9096 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
9097 `format_end'. Remove support for %l as a conversion specifier.
9098 Don't use xrealloc. Improve diagnostics when the %l size modifier
9099 is used. Update the commentary.
9100
9101 * eval.c (verror): Simplify calculation of size_t.
9102
9103 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
9104 messages.
9105
f61f41d7
PE
91062011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
9107
9108 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
9109 change.
9110
96fb4434
PE
91112011-04-27 Paul Eggert <eggert@cs.ucla.edu>
9112
9113 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
9114 This makes this file independent of the recent pseudovector change.
9115
671875da 91162011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 9117
69e9b5a3
PE
9118 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
9119
b5f869a7 9120 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 9121 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 9122 Remove unused local.
c8926152 9123 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 9124
841a1577 9125 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
9126 GCC 4.6.0 optimizes based on type-based alias analysis.
9127 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
9128 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
9129 != &v->size, and therefore "v->size = 1; b->size = 2; return
9130 v->size;" must therefore return 1. This assumption is incorrect
9131 for Emacs, since it type-puns struct Lisp_Vector * with many other
9132 types. To fix this problem, this patch adds a new type struct
f904488f 9133 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
9134 and pseudovectors, and helps optimizing compilers not get fooled
9135 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
9136 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
9137 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
9138 the size member.
eab3844f
PE
9139 (XSETPVECTYPE): Rewrite in terms of new macro.
9140 (XSETPVECTYPESIZE): New macro, specifying both type and size.
9141 This is a bit clearer, and further avoids the possibility of
9142 undesirable aliasing.
9143 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 9144 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
9145 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
9146 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
9147 (ASIZE): Now uses header.size rather than size.
9148 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
9149 to avoid the hassle of writing XVECTOR (foo)->header.size.
9150 (struct vectorlike_header): New type.
eab3844f
PE
9151 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
9152 object, to help avoid aliasing.
9153 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
9154 (SUBRP): Likewise, since Lisp_Subr is a special case.
9155 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
9156 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
9157 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 9158 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
9159 changed to be "header.size" and "header.next".
9160 * buffer.h (struct buffer): Likewise.
9161 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
9162 * frame.h (struct frame): Likewise.
9163 * process.h (struct Lisp_Process): Likewise.
9164 * termhooks.h (struct terminal): Likewise.
9165 * window.c (struct save_window_data, struct saved_window): Likewise.
9166 * window.h (struct window): Likewise.
9167 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
9168 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
9169 * buffer.c (init_buffer_once): Likewise.
9170 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
9171 special case.
9172 * process.c (Fformat_network_address): Use local var for size,
9173 for brevity.
9174
0df1eac5
PE
9175 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
9176
847ab9d1 9177 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
9178 * data.c (atof): Remove decl; no longer used or needed.
9179 (digit_to_number): Move to lread.c.
9180 (Fstring_to_number): Use new string_to_number function, to be
9181 consistent with how the Lisp reader treats infinities and NaNs.
9182 Do not assume that floating-point numbers represent EMACS_INT
9183 without losing information; this is not true on most 64-bit hosts.
9184 Avoid double-rounding errors, by insisting on integers when
9185 parsing non-base-10 numbers, as the documentation specifies.
9186 * lisp.h (string_to_number): New decl, replacing ...
9187 (isfloat_string): Remove.
bc0a5c13 9188 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 9189 (read1): Do not accept +. and -. as integers; this
452f4150
PE
9190 appears to have been a coding error. Similarly, do not accept
9191 strings like +-1e0 as floating point numbers. Do not report
9192 overflow for integer overflows unless the base is not 10 which
9193 means we have no simple and reliable way to continue.
9194 Break out the floating-point parsing into a new
9195 function string_to_number, so that Fstring_to_number parses
9196 floating point numbers consistently with the Lisp reader.
04f2d78b 9197 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
9198 (E_CHAR, EXP_INT): Remove, replacing with ...
9199 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
9200 (string_to_number): New function, replacing isfloat_string.
9201 This function checks for valid syntax and produces the resulting
9202 Lisp float number too. Rework it so that string-to-number
bc0a5c13 9203 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
9204 so that overflow for non-base-10 numbers is reported only when
9205 there's no portable and simple way to convert to floating point.
452f4150 9206
67769ffc
PE
9207 * textprop.c (set_text_properties_1): Rewrite for clarity,
9208 and to avoid GCC warning about integer overflow.
9209
c20db43f
PE
9210 * intervals.h (struct interval): Use EMACS_INT for members
9211 where EMACS_UINT might cause problems. See
9212 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
9213 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
9214 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
9215 All uses changed.
37aa2f85
PE
9216 (offset_intervals): Tell GCC not to worry about length overflow
9217 when negating a negative length.
c20db43f 9218
2538aa2f
PE
9219 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
9220 (overrun_check_free): Likewise.
9221
f2d3008d
PE
9222 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
9223 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
9224 word size.
9225
ec8df744
PE
9226 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9227 (gnutls_make_error): Rename local to avoid shadowing.
9228 (gnutls_emacs_global_deinit): ifdef out; not used.
9229 (Fgnutls_boot): Use const for pointer to readonly storage.
9230 Comment out unused local. Fix pointer signedness problems.
9231
640ee02d
PE
9232 * lread.c (openp): Don't stuff size_t into an 'int'.
9233 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
9234 about possible signed overflow.
9235
6048fb2a
PE
9236 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
9237 (GDK_KEY_g): Don't define if already defined.
9238 (xg_prepare_tooltip): Avoid pointer signedness problem.
9239 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
9240
fa3c87e1
PE
9241 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
9242 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
9243
2172544b
PE
9244 * xfns.c (Fx_window_property): Simplify a bit,
9245 to make a bit faster and to avoid GCC 4.6.0 warning.
9246 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
9247
9b821a21
PE
9248 * fns.c (internal_equal): Don't assume size_t fits in int.
9249
3c616cfa
PE
9250 * alloc.c (compact_small_strings): Tighten assertion a little.
9251
c2982e87
PE
9252 Replace pEd with more-general pI, and fix some printf arg casts.
9253 * lisp.h (pI): New macro, generalizing old pEd macro to other
9254 conversion specifiers. For example, use "...%"pI"d..." rather
9255 than "...%"pEd"...".
9256 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 9257 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
9258 * alloc.c (check_pure_size): Don't overflow by converting size to int.
9259 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
9260 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
9261 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
9262 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
9263 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
9264 64-bit hosts.
9265 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
9266 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
9267 * print.c (safe_debug_print, print_object): Likewise.
9268 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
9269 to int.
6f04d126
PE
9270 Use pI instead of if-then-else-abort. Use %p to avoid casts,
9271 avoiding the 0 flag, which is not portable.
c2982e87
PE
9272 * process.c (Fmake_network_process): Use pI to avoid cast.
9273 * region-cache.c (pp_cache): Likewise.
9274 * xdisp.c (decode_mode_spec): Likewise.
9275 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
9276 behavior on 64-bit hosts with printf arg.
6f04d126 9277 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
9278 (x_stop_queuing_selection_requests): Likewise.
9279 (x_get_window_property): Don't truncate byte count to an 'int'
9280 when tracing.
0b432f21 9281
5e073ec7
PE
9282 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
9283 here, since it parses constructs like leading '-' and spaces,
9284 which are not wanted; and it overflows with large numbers.
9285 Instead, simply match F[0-9]+, which is what is wanted anyway.
9286
36372bf9
PE
9287 * alloc.c: Remove unportable assumptions about struct layout.
9288 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
9289 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
9290 (allocate_vectorlike, make_pure_vector): Use the new macros,
9291 plus offsetof, to remove unportable assumptions about struct layout.
9292 These assumptions hold on all porting targets that I know of, but
9293 they are not guaranteed, they're easy to remove, and removing them
9294 makes further changes easier.
9295
0b432f21
PE
9296 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
9297 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
9298 (string_overrun_cookie): Now const. Use initializers that
9299 don't formally overflow signed char, to avoid warnings.
000098c1
PE
9300 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
9301 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
9302 (allocate_buffer): Don't assume sizeof (struct buffer) is a
9303 multiple of sizeof (EMACS_INT); it need not be, if
9304 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 9305 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 9306
895009e1
JB
93072011-04-26 Juanma Barranquero <lekktu@gmail.com>
9308
9309 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
9310
6a7a1b0b
TZ
93112011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
9312
9313 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 9314 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
9315 Reported by Paul Eggert <eggert@cs.ucla.edu>.
9316
841a1577 93172011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
9318
9319 * lisp.h (Qdebug): List symbol.
895009e1 9320 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
9321 * keyboard.c (debug-on-event): New variable.
9322 (handle_user_signal): Break into debugger when debug-on-event
9323 matches the current signal symbol.
9324
f2d3ba6f
DN
93252011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
9326
9327 * alloc.c (check_sblock, check_string_bytes)
9328 (check_string_free_list): Convert to standard C.
9329
42ce4c63
TZ
93302011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
9331
9332 * w32.c (emacs_gnutls_push): Fix typo.
9333
825cd63c
EZ
93342011-04-25 Eli Zaretskii <eliz@gnu.org>
9335
fb11d64d
EZ
9336 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
9337 "cast to pointer from integer of different size".
9338
825cd63c
EZ
9339 Improve doprnt and its use in verror. (Bug#8545)
9340 * doprnt.c (doprnt): Document the set of format control sequences
9341 supported by the function. Use SAFE_ALLOCA instead of always
9342 using `alloca'.
9343
9344 * eval.c (verror): Don't limit the buffer size at size_max-1, that
9345 is one byte too soon. Don't use xrealloc; instead xfree and
9346 xmalloc anew.
9347
e061a11b
TZ
93482011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
9349
9350 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
9351 callbacks stage.
9352
9353 * gnutls.c: Renamed global_initialized to
9354 gnutls_global_initialized. Added internals for the
9355 :verify-hostname-error, :verify-error, and :verify-flags
9356 parameters of `gnutls-boot' and documented those parameters in the
9357 docstring. Start callback support.
9173deec
JB
9358 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
9359 unless a fatal error occurred. Call gnutls_alert_send_appropriate
9360 on error. Return error code.
e061a11b
TZ
9361 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
9362 (emacs_gnutls_read): Likewise.
9363 (Fgnutls_boot): Return handshake error code.
9364 (emacs_gnutls_handle_error): New function.
9365 (wsaerror_to_errno): Likewise.
9366
9367 * w32.h (emacs_gnutls_pull): Add prototype.
9368 (emacs_gnutls_push): Likewise.
9369
9370 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
9371 (emacs_gnutls_push): Likewise.
9372
93732011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
9374
9375 * process.c (wait_reading_process_output): Check if GnuTLS
9376 buffered some data internally if no FDs are set for TLS
9377 connections.
9378
9379 * makefile.w32-in (OBJ2): Add gnutls.$(O).
9380 (LIBS): Link to USER_LIBS.
9381 ($(BLD)/gnutls.$(0)): New target.
9382
fa6996bc
EZ
93832011-04-24 Eli Zaretskii <eliz@gnu.org>
9384
eb35682e
EZ
9385 * xdisp.c (handle_single_display_spec): Rename the
9386 display_replaced_before_p argument into display_replaced_p, to
9387 make it consistent with the commentary. Fix typos in the
9388 commentary.
9389
e2ad650c
EZ
9390 * textprop.c (syms_of_textprop): Remove dead code.
9391 (copy_text_properties): Delete obsolete commentary about an
9392 interface that was deleted long ago. Fix typos in the description
9393 of arguments.
9394
1b2de274
EZ
9395 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
9396 to changes in oldXMenu/XMenu.h from 2011-04-16.
9397 <menu_help_message, prev_menu_help_message>: Constify.
9398 (IT_menu_make_room): menu->help_text is now `const char **';
9399 adjust.
9400
9401 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
9402 to changes in oldXMenu/XMenu.h from 2011-04-16.
9403 (struct XMenu): Declare `help_text' `const char **'.
9404
9405 * xfaces.c <Qunspecified>: Make extern again.
9406
9407 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 9408 required by POSIX.
1b2de274 9409
762b15be
EZ
9410 * doc.c (get_doc_string): Improve the format passed to `error'.
9411
9412 * doprnt.c (doprnt): Improve commentary.
9413
9414 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
9415
9416 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
9417 them with etags.
9418
f1052e5d
EZ
9419 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
9420 changes in globals.h immediately force recompilation.
762b15be
EZ
9421 (TAGS): Depend on $(CURDIR)/m/intel386.h and
9422 $(CURDIR)/s/ms-w32.h.
9423 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 9424
fa6996bc
EZ
9425 * character.c (Fchar_direction): Function deleted.
9426 (syms_of_character): Don't defsubr it.
9427 <char-direction-table>: Deleted.
9428
e6c3da20
EZ
94292011-04-23 Eli Zaretskii <eliz@gnu.org>
9430
9431 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
9432 * doprnt.c: Include limits.h.
9433 (SIZE_MAX): New macro.
04f2d78b
CB
9434 (doprnt): Return a size_t value. 2nd arg is now size_t.
9435 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
9436 Improve overflow protection. Support `l' modifier for integer
9437 conversions. Support %l conversion. Don't assume an EMACS_INT
9438 argument for integer conversions and for %c.
9439
9440 * lisp.h (doprnt): Restore prototype.
9441
9442 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
9443 $(SRC)/character.h.
9444
9445 * Makefile.in (base_obj): Add back doprnt.o.
9446
9447 * deps.mk (doprnt.o): Add back prerequisites.
9448 (callint.o): Depend on character.h.
9449
9450 * eval.c (internal_lisp_condition_case): Include the handler
9451 representation in the error message.
9452 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
9453 when breaking from the loop.
9454
9455 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
9456
9457 * callint.c (Fcall_interactively): When displaying error message
9458 about invalid control letter, pass the character's codepoint, not
9459 a pointer to its multibyte form. Improve display of the character
9460 in octal and display also its hex code.
9461
9462 * character.c (char_string): Use %x to display the (unsigned)
9463 codepoint of an invalid character, to avoid displaying a bogus
9464 negative value.
9465
9466 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
9467 `error', not SYMBOL_NAME itself.
9468
9469 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
9470 character arguments to `error'.
9471
9472 * charset.c (check_iso_charset_parameter): Fix incorrect argument
9473 to `error' in error message about FINAL_CHAR argument. Make sure
9474 FINAL_CHAR is a character, and use %c when it is passed as
9475 argument to `error'.
9476
4ffd0d6b 94772011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
9478
9479 * s/ms-w32.h (localtime): Redirect to sys_localtime.
9480
9481 * w32.c: Include <time.h>.
9482 (sys_localtime): New function.
9483
4ffd0d6b 94842011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
9485
9486 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
9487
4ffd0d6b 9488 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 9489
4ffd0d6b 94902011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 9491
4ffd0d6b
GM
9492 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
9493 zombies (Bug#8467).
aac0c6e3 9494
04c56954
EZ
94952011-04-19 Eli Zaretskii <eliz@gnu.org>
9496
9497 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
9498 gl_state.e_property when gl_state.object is Qt.
9499
9500 * insdel.c (make_gap_larger): Remove limitation of buffer size
9501 to <= INT_MAX.
9502
16a43933
CY
95032011-04-18 Chong Yidong <cyd@stupidchicken.com>
9504
9505 * xdisp.c (lookup_glyphless_char_display)
9506 (produce_glyphless_glyph): Handle cons cell entry in
9507 glyphless-char-display.
9508 (Vglyphless_char_display): Document it.
9509
9510 * term.c (produce_glyphless_glyph): Handle cons cell entry in
9511 glyphless-char-display.
9512
4581706e
CY
95132011-04-17 Chong Yidong <cyd@stupidchicken.com>
9514
9515 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
9516
9517 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
9518
9519 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
9520 definition for no-X builds.
9521
4887c6e2 95222011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 9523
fd35b6f9
PE
9524 Static checks with GCC 4.6.0 and non-default toolkits.
9525
5c1ccb01
PE
9526 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
9527
006c5daa
PE
9528 * process.c (keyboard_bit_set): Define only if SIGIO.
9529 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
9530 (send_process): Repair possible setjmp clobbering.
9531
efc736d3
PE
9532 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
9533
4e2fe2e6
PE
9534 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
9535
f97334a2
PE
9536 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
9537
4e75f29d
PE
9538 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
9539 Define only if needed.
9540
90efadd1
PE
9541 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
9542 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 9543 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 9544
3c647824
PE
9545 * dispextern.h (struct redisplay_interface): Rename param
9546 to avoid shadowing.
e264f262 9547 * termhooks.h (struct terminal): Likewise.
761383f4 9548 * xterm.c (xembed_send_message): Likewise.
3c647824 9549
b58c5c4a
PE
9550 * insdel.c (make_gap_smaller): Define only if
9551 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
9552
cad59032
PE
9553 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
9554 it.
9555
c339dc2e
PE
9556 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
9557 so that we aren't warned about unused symbols.
9558
91a3e27b
PE
9559 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
9560
399c71d3 9561 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 9562
8ffc96f5
PE
9563 * xfns.c (x_real_positions): Mark locals as initialized.
9564
eef9bc79
PE
9565 * xmenu.c (xmenu_show): Don't use uninitialized vars.
9566
098db9dd
PE
9567 * xterm.c: Fix problems found by static analysis with other toolkits.
9568 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
9569 (x_dispatch_event): Declare static if USE_GTK, and
9570 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 9571 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 9572 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
9573 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
9574 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 9575
eb18f6cc
PE
9576 * xmenu.c (menu_help_callback): Pointer type fixes.
9577 Use const pointers when pointing at readonly data. Avoid pointer
9578 signedness clashes.
9579 (FALSE): Remove unused macro.
9580 (update_frame_menubar): Remove unused decl.
9581
1fe72bf8
PE
9582 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
9583
60d9e1db
PE
9584 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
9585 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
9586 (single_menu_item): Rename local to avoid shadowing.
9587
39261c26
PE
9588 * keyboard.c (make_lispy_event): Remove unused local var.
9589
018c5e19
PE
9590 * frame.c, frame.h (x_get_resource_string): Bring this back, but
9591 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
9592
63d2b86e
PE
9593 * bitmaps: Change bitmaps from unsigned char back to the X11
9594 compatible char. Avoid the old compiler warnings about
9595 out-of-range initializers by using, for example, '\xab' rather
9596 than 0xab.
9597
aefd87e1
PE
9598 * xgselect.c (xgselect_initialize): Check vs interface
9599 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
9600
bf501fb9
PE
9601 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
9602
e9829fdf
PE
9603 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
9604 to read-only memory.
9605
1086c095
PE
9606 * fns.c (vector): Remove; this old hack is no longer needed.
9607
2baccd04 9608 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 9609 Remove unused var.
dde42981 9610 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 9611
72391843 9612 * xrdb.c (x_load_resources): Omit unused local.
3565b346 9613
436c16df 9614 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 9615 (x_window): Rename locals to avoid shadowing.
dc5ddd85 9616 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 9617
92bb796d 9618 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 9619 (x_term_init): Remove local to avoid shadowing.
92bb796d 9620
764430a3 9621 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
9622
9623 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
9624 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
9625
d1dfb56c
EZ
96262011-04-16 Eli Zaretskii <eliz@gnu.org>
9627
c4354cb4
EZ
9628 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
9629
d1dfb56c
EZ
9630 Fix regex.c, syntax.c and friends for buffers > 2GB.
9631 * syntax.h (struct gl_state_s): Declare character position members
9632 EMACS_INT.
9633
9634 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
9635
04f2d78b
CB
9636 * textprop.c (verify_interval_modification, interval_of):
9637 Declare arguments EMACS_INT.
d1dfb56c
EZ
9638
9639 * intervals.c (adjust_intervals_for_insertion): Declare arguments
9640 EMACS_INT.
9641
9642 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
9643
9644 * indent.c (Fvertical_motion): Local variable it_start is now
9645 EMACS_INT.
9646
9647 * regex.c (re_match, re_match_2, re_match_2_internal)
9648 (bcmp_translate, regcomp, regexec, print_double_string)
9649 (group_in_compile_stack, re_search, re_search_2, regex_compile)
9650 (re_compile_pattern, re_exec): Declare arguments and local
9651 variables `size_t' and `ssize_t' and return values `regoff_t', as
9652 appropriate.
9653 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
9654 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
9655 <compile_stack_type>: `size' and `avail' are now `size_t'.
9656
9657 * regex.h <regoff_t>: Use ssize_t, not int.
9658 (re_search, re_search_2, re_match, re_match_2): Arguments that
9659 specify buffer/string position and length are now ssize_t and
9660 size_t. Return type is regoff_t.
9661
613052cd
BK
96622011-04-16 Ben Key <bkey76@gmail.com>
9663
9664 * nsfont.m: Fixed bugs in ns_get_family and
9665 ns_descriptor_to_entity that were caused by using free to
9666 deallocate memory blocks that were allocated by xmalloc (via
9667 xstrdup). This caused Emacs to crash when compiled with
9668 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
9669 --enable-checking=xmallocoverrun). xfree is now used to
9670 deallocate these memory blocks.
9671
4170f62f 96722011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 9673
71b41406
PE
9674 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
9675
9587a89d
PE
9676 emacs_write: Accept and return EMACS_INT for sizes.
9677 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
9678 et seq.
9679 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
9680 Accept and return EMACS_INT.
9681 (emacs_gnutls_write): Return the number of bytes written on
9682 partial writes.
9683 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
9684 (emacs_read, emacs_write): Remove check for negative size, as the
9685 Emacs source code has been audited now.
9587a89d
PE
9686 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
9687 (emacs_read, emacs_write): Use it.
273a5f82
PE
9688 * process.c (send_process): Adjust to the new signatures of
9689 emacs_write and emacs_gnutls_write. Do not attempt to store
9690 a byte offset into an 'int'; it might overflow.
9587a89d 9691 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 9692
3e047f51
PE
9693 * sound.c: Don't assume sizes fit in 'int'.
9694 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 9695 Return EMACS_INT, not int.
3e047f51 9696 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
9697 Accept EMACS_INT, not int.
9698 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
9699 record read return values.
9700
cc39a9db
BK
97012011-04-15 Ben Key <bkey76@gmail.com>
9702
c9d0ec6d
JB
9703 * keyboard.c (Qundefined): Don't declare static since it is used
9704 in nsfns.m.
9705 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
9706 static since they are used in nsfont.m.
cc39a9db 9707
6c60eb9f
SM
97082011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
9709
9710 * process.c (Qprocessp): Don't declare static.
9711 * lisp.h (Qprocessp): Declare again.
9712
7990b61a
JB
97132011-04-15 Juanma Barranquero <lekktu@gmail.com>
9714
9715 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
9716
5d4cb038
PE
97172011-04-14 Paul Eggert <eggert@cs.ucla.edu>
9718
8bd7b830 9719 Improve C-level modularity by making more things 'static'.
cd64ea1d 9720
e3b27b31
PE
9721 Don't publish debugger-only interfaces to other modules.
9722 * lisp.h (safe_debug_print, debug_output_compilation_hack):
9723 (verify_bytepos, count_markers): Move decls to the only modules
9724 that need them.
9725 * region-cache.h (pp_cache): Likewise.
9726 * window.h (check_all_windows): Likewise.
9727 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
9728
5d4cb038
PE
9729 * sysdep.c (croak): Now static, if
9730 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
9731 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
9732
9733 * alloc.c (refill_memory_reserve): Now static if
9734 !defined REL_ALLOC || defined SYSTEM_MALLOC.
9735 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 9736
e87b6180
PE
9737 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
9738 Define only if USE_LUCID.
9739
ac64929e
PE
9740 * xrdb.c (x_customization_string, x_rm_string): Now static.
9741
6f37259d
PE
9742 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
9743 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
9744
1683e3ab
PE
9745 * xdisp.c (draw_row_with_mouse_face): Now static.
9746 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
9747
de9c2632
PE
9748 * window.h (check_all_windows): Mark externally visible.
9749
2b96acb7
PE
9750 * window.c (window_deletion_count): Now static.
9751
9752 * undo.c: Make symbols static if they're not exported.
9753 (last_undo_buffer, last_boundary_position, pending_boundary):
9754 Now static.
9755
50436f33
PE
9756 * textprop.c (interval_insert_behind_hooks): Now static.
9757 (interval_insert_in_front_hooks): Likewise.
9758
64520e5c
PE
9759 * term.c: Make symbols static if they're not exported.
9760 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
9761 (max_frame_lines, tty_set_terminal_modes):
9762 (tty_reset_terminal_modes, tty_turn_off_highlight):
9763 (get_tty_terminal): Now static.
9764 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
9765 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 9766 HAVE_WINDOW_SYSTEM.
64520e5c
PE
9767 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
9768 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
9769
1fa53021
PE
9770 * sysdep.c: Make symbols static if they're not exported.
9771 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
9772 Now static.
9773 (sigprocmask_set, full_mask): Remove; unused.
9774 (wait_debugging): Mark as visible.
9775 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
9776 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
9777
d4b43b22
PE
9778 * syntax.c (syntax_temp): Define only if !__GNUC__.
9779
b7c513d0
PE
9780 * sound.c (current_sound_device, current_sound): Now static.
9781
989b29ad
PE
9782 * search.c (searchbufs, searchbuf_head): Now static.
9783
13a55a78
PE
9784 * scroll.c (scroll_cost): Remove; unused.
9785 * dispextern.h (scroll_cost): Remove decl.
9786
de68a1fc
PE
9787 * region-cache.h (pp_cache): Mark as externally visible.
9788
40ccffa6
PE
9789 * process.c: Make symbols static if they're not exported.
9790 (process_tick, update_tick, create_process, chan_process):
9791 (Vprocess_alist, proc_buffered_char, datagram_access):
9792 (fd_callback_data, send_process_frame, process_sent_to): Now static.
9793 (deactivate_process): Mark defn as static, as well as decl.
9794 * lisp.h (create_process): Remove decl.
9795 * process.h (chan_process, Vprocess_alist): Remove decls.
9796
ad64fc97
PE
9797 * print.c: Make symbols static if they're not exported.
9798 (print_depth, new_backquote_output, being_printed, print_buffer):
9799 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
9800 (print_interval, print_number_index, initial_stderr_stream):
9801 Now static.
9802 * lisp.h (Fprinc): Remove decl.
9803 (debug_output_compilation_hack): Mark as externally visible.
9804
adddb265
PE
9805 * sysdep.c (croak): Move decl from here to syssignal.h.
9806 * syssignal.h (croak): Put it here, so the API can be checked when
9807 'croak' is called from dissociate_if_controlling_tty.
9808
1717ede2
PE
9809 * minibuf.c: Make symbols static if they're not exported.
9810 (minibuf_save_list, choose_minibuf_frame): Now static.
9811 * lisp.h (choose_minibuf_frame): Remove decl.
9812
fa5fb2bc
PE
9813 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
9814
1e3890d1
PE
9815 * lread.c: Make symbols static if they're not exported.
9816 (read_objects, initial_obarray, oblookup_last_bucket_number):
9817 Now static.
9818 (make_symbol): Remove; unused.
9819 * lisp.h (initial_obarray, make_symbol): Remove decls.
9820
8a1414fa
PE
9821 * keyboard.c: Make symbols static if they're not exported.
9822 (single_kboard, recent_keys_index, total_keys, recent_keys):
9823 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
9824 (this_single_command_key_start, echoing, last_auto_save):
9825 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
9826 (command_loop, echo_now, keyboard_init_hook, help_char_p):
9827 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
9828 (Vlispy_mouse_stem, double_click_count):
9829 Now static.
9830 (force_auto_save_soon): Define only if SIGDANGER.
9831 (ignore_mouse_drag_p): Now static if
9832 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
9833 (print_help): Remove; unused.
9834 (stop_character, last_timer_event): Mark as externally visible.
9835 * keyboard.h (ignore_mouse_drag_p): Declare only if
9836 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
9837 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
9838 * lisp.h (echoing): Remove decl.
9839 (force_auto_save_soon): Declare only if SIGDANGER.
9840 * xdisp.c (redisplay_window): Simplify code, to make it more
9841 obvious that ignore_mouse_drag_p is not accessed if !defined
9842 USE_GTK && !defined HAVE_NS.
9843
93ea6e8f
PE
9844 * intervals.c: Make symbols static if they're not exported.
9845 (merge_properties_sticky, merge_interval_right, delete_interval):
9846 Now static.
9847 * intervals.h (merge_interval_right, delete_interval): Remove decls.
9848
77382fcc
PE
9849 * insdel.c: Make symbols static if they're not exported.
9850 However, leave prepare_to_modify_buffer alone. It's never
9851 called from outside this function, but that appears to be a bug.
9852 (combine_after_change_list, combine_after_change_buffer):
4889fc82 9853 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
9854 (adjust_after_replace_noundo): Remove; unused.
9855 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 9856 (signal_before_change): Remove decls.
77382fcc 9857
9306c32e
PE
9858 * indent.c (val_compute_motion, val_vmotion): Now static.
9859
cd44d2eb
PE
9860 * image.c: Make symbols static if they're not exported.
9861 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
9862 if USE_GTK.
9863 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
9864 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
9865
ad9a7a06
PE
9866 * fringe.c (standard_bitmaps): Now static.
9867 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
9868
81626931
PE
9869 * frame.c: Make symbols static if they're not exported.
9870 (x_report_frame_params, make_terminal_frame): Now static.
9871 (get_frame_param): Now static, unless HAVE_NS.
9872 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
9873 (x_get_resource_string): Remove; not used.
9874 * frame.h (make_terminal_frame, x_report_frame_params):
9875 (x_get_resource_string); Remove decls.
9876 (x_fullscreen_adjust): Declare only if WINDOWSNT.
9877 * lisp.h (get_frame_param): Declare only if HAVE_NS.
9878
239f9db9
PE
9879 * font.c, fontset.c: Make symbols static if they're not exported.
9880 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
9881 (FACE_SUITABLE_FOR_CHAR_P): Use it.
9882 * font.c (font_close_object): Now static.
9883 * font.h (font_close_object): Remove.
9884 * fontset.c (FONTSET_OBJLIST): Remove.
9885 (free_realized_fontset) #if-0 the body, which does nothing.
9886 (face_suitable_for_char_p): #if-0, as it's never called.
9887 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
9888 * xfaces.c (face_at_string_position):
9889 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
9890 since 0 is always ASCII.
9891
dfcf3579
PE
9892 * fns.c (weak_hash_tables): Now static.
9893
5045092b
PE
9894 * fileio.c: Make symbols static if they're not exported.
9895 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
9896 (Vwrite_region_annotation_buffers): Now static.
9897
57a96f5c
PE
9898 * eval.c: Make symbols static if they're not exported.
9899 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
9900 * lisp.h (backtrace_list): Remove decl.
9901
35f08c38
PE
9902 * emacs.c: Make symbols static if they're not exported.
9903 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
9904 (fatal_error_code, fatal_error_signal_hook, standard_args):
9905 Now static.
9906 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
9907 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
9908 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
9909 * lisp.h (fatal_error_signal_hook): Remove decl.
9910 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
9911
f44bd759
PE
9912 * editfns.c: Move a (normally-unused) function to its only use.
9913 * editfns.c, lisp.h (get_operating_system_release): Remove.
9914 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
9915 worth the hassle of breaking this out.
9916
b532497d
PE
9917 * xterm.c: Make symbols static if they're not exported.
9918 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
9919 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
9920 (x_destroy_window, x_delete_display):
9921 Now static.
9922 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
9923 (x_mouse_leave): Remove; unused.
9924 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
9925 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
9926 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
9927 Remove decls.
9928 (x_mouse_leave): Declare only if WINDOWSNT.
9929 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
9930 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
9931 USE_X_TOOLKIT.
9932
1675728f
PE
9933 * ftxfont.c: Make symbols static if they're not exported.
9934 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
9935 HAVE_FREETYPE.
9936 * font.h (ftxfont_driver): Likewise.
9937
e4cebfca
PE
9938 * xfns.c: Make symbols static if they're not exported.
9939 (x_last_font_name, x_display_info_for_name):
9940 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
9941 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
9942 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
9943 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
9944 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
9945 (last_show_tip_args): Now static.
9946 (xic_defaut_fontset, xic_create_fontsetname): Define only if
9947 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
9948 (x_screen_planes): Remove; unused.
9949 * dispextern.h (x_screen_planes): Remove decl.
9950
5bf46f05
PE
9951 * dispnew.c: Make symbols static if they're not exported.
9952 * dispextern.h (redraw_garbaged_frames, scrolling):
9953 (increment_row_positions): Remove.
9954 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
9955 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
9956 Now static.
9957 (redraw_garbaged_frames): Remove; unused.
9958
435f4c28
PE
9959 * xfaces.c: Make symbols static if they're not exported.
9960 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
9961 Remove decls.
9962 * xterm.h (defined_color): Remove decls.
9963 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
9964 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
9965 (menu_face_changed_default, defined_color, free_realized_face):
9966 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
9967 (ascii_face_of_lisp_face): Remove; unused.
9968
8524aef3
PE
9969 * xdisp.c: Make symbols static if they're not exported.
9970 * dispextern.h (scratch_glyph_row, window_box_edges):
9971 (glyph_to_pixel_coords, set_cursor_from_row):
9972 (get_next_display_element, set_iterator_to_next):
9973 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
9974 (show_mouse_face): Remove decls
9975 * frame.h (message_buf_print): Likewise.
9976 * lisp.h (pop_message, set_message, check_point_in_composition):
9977 Likewise.
9978 * xterm.h (set_vertical_scroll_bar): Likewise.
9979 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
9980 (message_buf_print, scratch_glyph_row, displayed_buffer):
9981 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
9982 (get_next_display_element, show_mouse_face, window_box_edges):
9983 (frame_to_window_pixel_xy, check_point_in_composition):
9984 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
9985 (glyph_to_pixel_coords): Remove; unused.
9986
16390cd2
PE
9987 * dired.c (file_name_completion): Now static.
9988
9989 * dbusbind.c (xd_in_read_queued_messages): Now static.
9990
a25f4dfa
PE
9991 * lisp.h (circular_list_error, FOREACH): Remove; unused.
9992 * data.c (circular_list_error): Remove.
9993
14a9c8df
PE
9994 * commands.h (last_point_position, last_point_position_buffer):
9995 (last_point_position_window): Remove decls.
9996 * keyboard.c: Make these variables static.
9997
04f2d78b
CB
9998 * coding.h (coding, code_convert_region, encode_coding_gap):
9999 Remove decls.
74ab6df5
PE
10000 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
10001 (iso_code_class, detect_coding, code_convert_region): Now static.
10002 (encode_coding_gap): Remove; unused.
10003
38dfbee1
PE
10004 * chartab.c (chartab_chars, chartab_bits): Now static.
10005
a2cb4e63
PE
10006 * charset.h (charset_iso_8859_1): Remove decl.
10007 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
10008 Now static.
10009
127198fd
PE
10010 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
10011 * ccl.c (Vccl_program_table): Now static.
10012 (check_ccl_update): Remove; unused.
10013
d85b608f
PE
10014 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
10015 * category.h: ... from here.
10016 * category.c (check_category_table, set_category_set): Now static.
10017
31cd66f3
PE
10018 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
10019 * lisp.h: Remove these decls.
10020
c358e587
PE
10021 * buffer.c (buffer_count): Remove unused var.
10022
e78aecca
PE
10023 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
10024 so that it's not optimized away.
10025 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
10026 * dispextern.h (bidi_dump_cached_states): Remove, since it's
10027 exported only to the debugger.
10028
e192d7d3 10029 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 10030 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 10031
92470028
PE
10032 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
10033 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
10034 was inaccessible from Lisp.
10035 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
10036 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
10037
244ed907
PE
10038 alloc.c: Import and export fewer symbols, and remove unused items.
10039 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
10040 is defined.
10041 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
10042 it's not optimized away by whole-program optimization.
10043 (message_enable_multibyte, free_misc): Remove.
10044 (catchlist, handlerlist, mark_backtrace):
10045 Declare only if BYTE_MARK_STACK.
10046 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
10047 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
10048 (message_enable_multibyte): Remove decl.
10049 (free_misc, interval_free_list, float_block, float_block_index):
10050 (n_float_blocks, float_free_list, cons_block, cons_block_index):
10051 (cons_free_list, last_marked_index):
10052 Now static.
10053 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
10054 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
10055 (mark_backtrace): Define only if BYTE_MARK_STACK.
10056 * xdisp.c (message_enable_multibyte): Now static.
10057
61c2b50e 10058 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
10059 This makes it easier for human readers (and static analyzers)
10060 to see whether these variables are used from other modules.
10061 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
10062 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
10063 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
10064 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
10065 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
10066 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
10067 * xmenu.c, xselect.c:
10068 Declare Q* vars static if they are not used in other modules.
10069 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
10070 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
10071 Remove decls of unexported vars.
10072 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
10073
95c82688
PE
10074 * lisp.h (DEFINE_FUNC): Make sname 'static'.
10075
16a97296
PE
10076 Make Emacs functions such as Fatom 'static' by default.
10077 This makes it easier for human readers (and static analyzers)
10078 to see whether these functions can be called from other modules.
10079 DEFUN now defines a static function. To make the function external
10080 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
10081 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
10082 (Finit_image_library):
16a97296
PE
10083 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
10084 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
10085 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
10086 Remove decls, since these functions are now static.
10087 (Funintern, Fget_internal_run_time): New decls, since these functions
10088 were already external.
95c82688 10089
16a97296
PE
10090 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
10091 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
10092 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
10093 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
10094 * keyboard.c, keymap.c, lread.c:
10095 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
10096 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
10097 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
10098 Mark functions with DEFUE instead of DEFUN,
10099 if they are used in other modules.
10100 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
10101 decls for now-static functions.
10102 * buffer.h (Fdelete_overlay): Remove decl.
10103 * callproc.c (Fgetenv_internal): Mark as internal.
10104 * composite.c (Fremove_list_of_text_properties): Remove decl.
10105 (Fcomposition_get_gstring): New forward static decl.
10106 * composite.h (Fcomposite_get_gstring): Remove decl.
10107 * dired.c (Ffile_attributes): New forward static decl.
10108 * doc.c (Fdocumntation_property): New forward static decl.
10109 * eval.c (Ffetch_bytecode): New forward static decl.
10110 (Funintern): Remove extern decl; now in .h file where it belongs.
10111 * fileio.c (Fmake_symbolic_link): New forward static decl.
10112 * image.c (Finit_image_library): New forward static decl.
10113 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
10114 * intervals.h (Fprevious_property_change):
10115 (Fremove_list_of_text_properties): Remove decls.
10116 * keyboard.c (Fthis_command_keys): Remove decl.
10117 (Fcommand_execute): New forward static decl.
10118 * keymap.c (Flookup_key): New forward static decl.
10119 (Fcopy_keymap): Now static.
10120 * keymap.h (Flookup_key): Remove decl.
10121 * process.c (Fget_process): New forward static decl.
10122 (Fprocess_datagram_address): Mark as internal.
10123 * syntax.c (Fsyntax_table_p): New forward static decl.
10124 (skip_chars): Remove duplicate decl.
10125 * textprop.c (Fprevious_property_change): New forward static decl.
10126 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
10127 Now internal.
10128 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
10129 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
10130
785bbd42
PE
10131 * editfns.c (Fformat): Remove unreachable code.
10132
8b913b57
AS
101332011-04-14 Andreas Schwab <schwab@linux-m68k.org>
10134
10135 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
10136 change. (Bug#8496)
10137
a6744a35
EZ
101382011-04-13 Eli Zaretskii <eliz@gnu.org>
10139
10140 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
10141 when at ZV. (Bug#8487)
10142
e7974947
AS
101432011-04-12 Andreas Schwab <schwab@linux-m68k.org>
10144
baad03f0
AS
10145 * charset.c (Fclear_charset_maps): Use xfree instead of free.
10146 (Bug#8437)
10147 * keyboard.c (parse_tool_bar_item): Likewise.
10148 * sound.c (sound_cleanup, alsa_close): Likewise.
10149 * termcap.c (tgetent): Likewise.
10150 * xfns.c (x_default_font_parameter): Likewise.
10151 * xsettings.c (read_and_apply_settings): Likewise.
10152
e7974947
AS
10153 * alloc.c (overrun_check_malloc, overrun_check_realloc)
10154 (overrun_check_free): Protoize.
10155
28272684
PE
101562011-04-12 Paul Eggert <eggert@cs.ucla.edu>
10157
10158 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
10159 since callers should never pass a negative size.
10160 Change the signature to match that of plain 'read' and 'write'; see
10161 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
10162 * lisp.h: Update prototypes of emacs_write and emacs_read.
10163
11997c76
EZ
101642011-04-11 Eli Zaretskii <eliz@gnu.org>
10165
10166 * xdisp.c (redisplay_window): Don't try to determine the character
10167 position of the scroll margin if the window start point w->startp
e896f03c 10168 is outside the buffer's accessible region. (Bug#8468)
11997c76 10169
8a2cbd72
EZ
101702011-04-10 Eli Zaretskii <eliz@gnu.org>
10171
10172 Fix write-region and its subroutines for buffers > 2GB.
10173 * fileio.c (a_write, e_write): Modify declaration of arguments and
10174 local variables to support buffers larger than 2GB.
10175 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
10176
10177 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
10178 argument, local variables, and return value.
10179
10180 * lisp.h: Update prototypes of emacs_write and emacs_read.
10181
10182 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
10183
4073e537 101842011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 10185
1ebfdcb6
PE
10186 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
10187
b2ded58d
PE
10188 Fix more problems found by GCC 4.6.0's static checks.
10189
7d66342c
PE
10190 * xdisp.c (vmessage): Use a better test for character truncation.
10191
bbf47d44
PE
10192 * charset.c (load_charset_map): <, not <=, for optimization,
10193 and to avoid potential problems with integer overflow.
9248994d 10194 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 10195 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 10196 * editfns.c (Fformat): Likewise.
1e69125e 10197 * syntax.c (skip_chars): Likewise.
3befa583 10198
e3019616
PE
10199 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
10200 This also lets GCC 4.6.0 generate slightly better loop code.
10201
becfa255
PE
10202 * callint.c (Fcall_interactively): <, not <=, for optimization.
10203 (Fcall_interactively): Count the number of arguments produced,
10204 not the number of arguments given. This is simpler and lets GCC
10205 4.6.0 generate slightly better code.
10206
dae0cd48
PE
10207 * ftfont.c: Distingish more carefully between FcChar8 and char.
10208 The previous code passed unsigned char * to a functions like
10209 strlen and xstrcasecmp that expect char *, which does not
10210 conform to the C standard.
10211 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
10212 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
10213 char * when the C standard requires it.
10214
76032d70
PE
10215 * keyboard.c (read_char): Remove unused var.
10216
eb3f1cc8
PE
10217 * eval.c: Port to Windows vsnprintf (Bug#8435).
10218 Include <limits.h>.
10219 (SIZE_MAX): Define if the headers do not.
10220 (verror): Do not give up if vsnprintf returns a negative count.
10221 Instead, grow the buffer. This ports to Windows vsnprintf, which
10222 does not conform to C99. Problem reported by Eli Zaretskii.
10223 Also, simplify the allocation scheme, by avoiding the need for
10224 calling realloc, and removing the ALLOCATED variable.
10225
70476b54
PE
10226 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
10227
12020a9e
PE
10228 Remove invocations of doprnt, as Emacs now uses vsnprintf.
10229 But keep the doprint source code for now, as we might revamp it
10230 and use it again (Bug#8435).
ea6c7ae6
PE
10231 * lisp.h (doprnt): Remove.
10232 * Makefile.in (base_obj): Remove doprnt.o.
10233 * deps.mk (doprnt.o): Remove.
10234
5fdb398c
PE
10235 error: Print 32- and 64-bit integers portably (Bug#8435).
10236 Without this change, on typical 64-bit hosts error ("...%d...", N)
10237 was used to print both 32- and 64-bit integers N, which relied on
10238 undefined behavior.
61bdb816 10239 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
10240 * lisp.h (error, verror): Mark as printf-like functions.
10241 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
10242 Report overflow in size calculations when allocating printf buffer.
10243 Do not truncate output string at its first null byte.
10244 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
10245 Truncate the output at a character boundary, since vsnprintf does not
10246 do that.
10247 * charset.c (check_iso_charset_parameter): Convert internal
10248 character to string before calling 'error', since %c now has the
10249 printf meaning.
10250 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
10251 overflow when computing char to be passed to 'error'. Do not
10252 pass Lisp_Object to 'error'; pass the integer instead.
10253 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
10254 formatted with plain %d.
10255
b189fa66
PE
10256 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
10257
bff87ef0
PE
10258 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
10259
7e2cac20
PE
10260 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
10261
ce4d90b5
PE
10262 * xterm.c (x_catch_errors): Remove duplicate declaration.
10263
266c9547
PE
10264 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
10265
79c49ad2
PE
10266 * xdisp.c, lisp.h (message_nolog): Remove; unused.
10267
368f4090
JM
102682011-04-10 Jim Meyering <meyering@redhat.com>
10269
10270 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
10271 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
10272 return ssize_t not "int", and use size_t as the buffer length.
10273 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
10274 * gnutls.h: Update declarations.
10275 * process.c (read_process_output): Use ssize_t, to match.
10276 (send_process): Likewise.
10277
a32d4040
CY
102782011-04-09 Chong Yidong <cyd@stupidchicken.com>
10279
10280 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
10281
8546720e 102822011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 10283
04f2d78b
CB
10284 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
10285 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 10286
8546720e
GM
10287 * xterm.c (handle_one_xevent):
10288 * xmenu.c (create_and_show_popup_menu):
10289 * xselect.c (x_decline_selection_request)
10290 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 10291
0a2f5c1a 102922011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
10293
10294 Fix some uses of `int' instead of EMACS_INT.
10295 * search.c (string_match_1, fast_string_match)
10296 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
10297 (scan_buffer, find_next_newline_no_quit)
10298 (find_before_next_newline, search_command, Freplace_match)
10299 (Fmatch_data): Make some `int' variables be EMACS_INT.
10300
10301 * xdisp.c (display_count_lines): 3rd argument and return value now
10302 EMACS_INT. All callers changed.
10303 (pint2hrstr): Last argument is now EMACS_INT.
10304
10305 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
10306 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
10307 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
10308 (decode_coding_utf_16, decode_coding_emacs_mule)
10309 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
10310 (decode_coding_ccl, decode_coding_charset)
10311 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
10312 (decode_coding_iso_2022, decode_coding_emacs_mule)
10313 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
10314 <char_offset, last_offset>: Declare EMACS_INT.
10315 (encode_coding_utf_8, encode_coding_utf_16)
10316 (encode_coding_emacs_mule, encode_invocation_designation)
10317 (encode_designation_at_bol, encode_coding_iso_2022)
10318 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
10319 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
10320 Declare EMACS_INT.
10321 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
10322 (encode_invocation_designation): Last argument P_NCHARS is now
10323 EMACS_INT.
10324 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
10325 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
10326
10327 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
10328 All users changed.
10329
10330 * ccl.c (Fccl_execute_on_string): Declare some variables
10331 EMACS_INT.
10332
8546720e 103332011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
10334
10335 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
10336
4e19a977
CS
103372011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
10338
10339 * process.c (Fformat_network_address): Doc fix.
10340
87302331
R
103412011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
10342
ee7683eb 10343 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 10344
cbb59342
CY
103452011-04-08 Chong Yidong <cyd@stupidchicken.com>
10346
10347 * keyboard.c (read_char): Call Lisp function help-form-show,
10348 instead of using internal_with_output_to_temp_buffer.
10349 (Qhelp_form_show): New var.
e0d38eeb 10350 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
10351
10352 * print.c (internal_with_output_to_temp_buffer): Function deleted.
10353
10354 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
10355
e67a13ab
CY
103562011-04-06 Chong Yidong <cyd@stupidchicken.com>
10357
04f2d78b
CB
10358 * process.c (Flist_processes): Remove to Lisp.
10359 (list_processes_1): Delete.
e67a13ab 10360
973f782d
EZ
103612011-04-06 Eli Zaretskii <eliz@gnu.org>
10362
7c106b1e
EZ
10363 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
10364
973f782d
EZ
10365 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
10366
41cf7d1a 103672011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 10368
ca23cc88
PE
10369 Fix more problems found by GCC 4.6.0's static checks.
10370
f390e2d5
PE
10371 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
10372
42eea0d0
PE
10373 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
10374
b69769da 10375 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 10376
f9541e84
PE
10377 * xdisp.c (vmessage): Mark as a printf-like function.
10378
13841b55
PE
10379 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
10380
c136c10f
PE
10381 * sound.c (sound_warning): Don't crash if arg contains a printf format.
10382
5e2d4a30
PE
10383 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
10384 printf-like functions.
10385 (tiff_load): Add casts to remove these marks before passing them
10386 to system-supplied API.
10387
583f48b9
PE
10388 * eval.c (Fsignal): Remove excess argument to 'fatal'.
10389
b25d760e
PE
10390 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
10391 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
10392 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
10393 directly, rather than having caller test rule sign. This avoids
10394 some unnecessary tests.
10395 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
10396 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
10397 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 10398
bc7b6697 10399 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 10400 (xfont_open): Avoid unnecessary tests.
bc7b6697 10401
27ccc379
PE
10402 * composite.c (composition_gstring_put_cache): Use unsigned integer.
10403
dcd5c89a
PE
10404 * composite.h, composite.c (composition_gstring_put_cache):
10405 Use EMACS_INT, not int, for length.
10406
b13a45c6
PE
10407 * composite.h (COMPOSITION_DECODE_REFS): New macro,
10408 breaking out part of COMPOSITION_DECODE_RULE.
10409 (COMPOSITION_DECODE_RULE): Use it.
10410 * composite.c (get_composition_id): Remove unused local vars,
10411 by using the new macro.
10412
1e792e4d
PE
10413 * textprop.c (set_text_properties_1): Change while to do-while,
10414 since the condition is always true at first.
10415
dc6c6455 10416 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
10417 (interval_deletion_adjustment): Return unsigned value.
10418 All uses changed.
dc6c6455 10419
aba7731a
PE
10420 * process.c (list_processes_1, create_pty, read_process_output):
10421 (exec_sentinel): Remove vars that were set but not used.
afd4052b 10422 (create_pty): Remove unnecessary "volatile"s.
bc57d757 10423 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 10424 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 10425 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 10426
fdfc4bf3
PE
10427 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
10428
fca8fe46 10429 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 10430 (update_syntax_table): Use unsigned instead of int.
fca8fe46 10431
06a0259a 10432 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 10433 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 10434 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 10435
e7b9e80f
PE
10436 * print.c (print_error_message): Avoid int overflow.
10437
56201685
PE
10438 * font.c (font_list_entities): Redo for clarity,
10439 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
10440
78834453 10441 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 10442 (font_score): Avoid potential overflow in diff calculation.
78834453 10443
0bc0b309 10444 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 10445 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 10446
e610eaca
PE
10447 * eval.c (funcall_lambda): Rename local to avoid shadowing.
10448
b895abce
PE
10449 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
10450 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
10451 can always succeed if overflow has undefined behavior.
10452
1f1d9321 10453 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 10454 (wordify): Omit three unnecessary tests.
1f1d9321 10455
c59478bc
PE
10456 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
10457 All callers changed. This avoids the need for an unused var.
10458
79b73827
PE
10459 * casefiddle.c (casify_region): Remove var that is set but not used.
10460
a4db5dfe
PE
10461 * dired.c (file_name_completion): Remove var that is set but not used.
10462
43aae36e
PE
10463 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
10464
2a47c44d 10465 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 10466 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 10467
a37c69bf
PE
10468 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
10469 Check for integer overflow on size calculations.
10470
328ab8e7
PE
10471 * buffer.c (Fprevious_overlay_change): Remove var that is set
10472 but not used.
10473
e5a2a5cb
PE
10474 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
10475 Remove vars that are set but not used.
8d84a6eb 10476 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 10477 (timer_check_2): Mark vars as initialized.
e5a2a5cb 10478
a60e5f68
PE
10479 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
10480
f661cb61 10481 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 10482 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 10483
f0397f5a
PE
10484 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
10485 that are set but not used.
10486
8664db06 10487 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 10488 if XCreateBitmapFromData fails (Bug#8410).
8664db06 10489
6abdaa4a
PE
10490 * xselect.c (x_get_local_selection, x_handle_property_notify):
10491 Remove vars that are set but not used.
10492
0ce7538d 10493 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 10494 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 10495
9ae848fc
PE
10496 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
10497 Remove var that is set but not used.
0b918413
PE
10498 (scroll_bar_windows_size): Now size_t, not int.
10499 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
10500 Check for overflow.
9ae848fc 10501
a5a62657
PE
10502 * xfaces.c (realize_named_face): Remove vars that are set but not used.
10503 (map_tty_color) [!defined MSDOS]: Likewise.
10504
5c5cdd39
PE
10505 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
10506
66ebf983
PE
10507 * coding.c: Remove vars that are set but not used.
10508 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
10509 All callers changed.
10510 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
10511 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
10512 (decode_coding_charset): Remove vars that are set but not used.
10513
1be4d761
PE
10514 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
10515 that is set but not used.
10516
47553fa8
PE
10517 * print.c (print_object): Remove var that is set but not used.
10518
1f7196bf 10519 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
10520 The gnulib version avoids calling malloc in the usual case,
10521 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
10522 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
10523 * filelock.c (current_lock_owner): Likewise.
10524 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
10525 * sysdep.c: Include allocator.h, careadlinkat.h.
10526 (emacs_no_realloc_allocator): New static constant.
10527 (emacs_readlink): New function.
fdb61804
PE
10528 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
10529 ../lib/careadlinkat.h.
d1fdcab7 10530
f84c17c7
SM
105312011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
10532
10533 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
10534 first non-nil return value).
10535
ef3862ad
JD
105362011-04-03 Jan Djärv <jan.h.d@swipnet.se>
10537
10538 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
10539 if not defined (Bug#8403).
10540
376a7006
JB
105412011-04-02 Juanma Barranquero <lekktu@gmail.com>
10542
10543 * xdisp.c (display_count_lines): Remove parameter `start',
10544 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10545 (get_char_face_and_encoding): Remove parameter `multibyte_p',
10546 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10547 (fill_stretch_glyph_string): Remove parameters `row' and `area',
10548 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
10549 and thereabouts. All callers changed.
10550 (get_per_char_metric): Remove parameter `f', unused since
10551 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
10552
6ca3801d
JM
105532011-04-02 Jim Meyering <meyering@redhat.com>
10554
10555 do not dereference NULL upon failed strdup
10556 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
10557 (ns_get_family): Likewise.
10558
d8e2b5ba
JB
105592011-04-02 Juanma Barranquero <lekktu@gmail.com>
10560
10561 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
10562
8c74fcbd
JD
105632011-04-02 Jan Djärv <jan.h.d@swipnet.se>
10564
10565 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
10566 later (Bug#8403).
10567
7200d79c
SM
105682011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
10569
03408648 10570 Add lexical binding.
7200d79c 10571
03408648
SM
10572 * window.c (Ftemp_output_buffer_show): New fun.
10573 (Fsave_window_excursion):
10574 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
10575
10576 * lread.c (lisp_file_lexically_bound_p): New function.
10577 (Fload): Bind Qlexical_binding.
10578 (readevalloop): Remove `evalfun' arg.
10579 Bind Qinternal_interpreter_environment.
10580 (Feval_buffer): Bind Qlexical_binding.
10581 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
10582 Mark as dynamic.
10583 (syms_of_lread): Declare `lexical-binding'.
10584
10585 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
10586
10587 * keyboard.c (eval_dyn): New fun.
10588 (menu_item_eval_property): Use it.
ca105506
SM
10589
10590 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 10591
03408648
SM
10592 * fns.c (concat, mapcar1): Accept byte-code-functions.
10593
10594 * eval.c (Fsetq): Handle lexical vars.
10595 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
10596 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
10597 (FletX, Flet): Obey lexical binding.
10598 (Fcommandp): Handle closures.
10599 (Feval): New `lexical' arg.
10600 (eval_sub): New function extracted from Feval. Use it almost
10601 everywhere where Feval was used. Look up vars in lexical env.
10602 Handle closures.
10603 (Ffunctionp): Move from subr.el.
10604 (Ffuncall): Handle closures.
10605 (apply_lambda): Remove `eval_flags'.
10606 (funcall_lambda): Handle closures and new byte-code-functions.
10607 (Fspecial_variable_p): New function.
10608 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
10609 but without exporting it to Lisp.
23aba0ea 10610
23aba0ea 10611 * doc.c (Fdocumentation, store_function_docstring):
03408648 10612 * data.c (Finteractive_form): Handle closures.
23aba0ea 10613
03408648
SM
10614 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
10615 interactive spec.
ba83908c 10616
04f2d78b
CB
10617 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
10618 New byte-codes.
03408648
SM
10619 (exec_byte_code): New function extracted from Fbyte_code to handle new
10620 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 10621
03408648 10622 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 10623
03408648 10624 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 10625
e2abce01
JB
106262011-03-31 Juanma Barranquero <lekktu@gmail.com>
10627
10628 * xdisp.c (redisplay_internal): Fix prototype.
10629
63696a73 106302011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 10631
63696a73 10632 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
10633 (try_scrolling): Use it when setting scroll_limit.
10634 Limit scrolling to 100 screen lines.
63696a73
EZ
10635 (redisplay_window): Even when falling back on "recentering",
10636 position point in the window according to scroll-conservatively,
10637 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
10638
10639 (try_scrolling): When point is above the window, allow searching
10640 as far as scroll_max, or one screenful, to compute vertical
10641 distance from PT to the scroll margin position. This prevents
10642 try_scrolling from unnecessarily failing when
10643 scroll-conservatively is set to a value slightly larger than the
10644 window height. Clean up the case of PT below the margin at bottom
10645 of window: scroll_max can no longer be INT_MAX. When aggressive
10646 scrolling is in use, don't let point enter the opposite scroll
10647 margin as result of the scroll.
10648 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
10649 threshold of 100 lines for never-recentering scrolling.
10650
e4cc2dfc
JB
106512011-03-31 Juanma Barranquero <lekktu@gmail.com>
10652
10653 * dispextern.h (move_it_by_lines):
10654 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
10655 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
10656 (message_log_check_duplicate): Remove parameters `prev_bol' and
10657 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
10658 (redisplay_internal): Remove parameter `preserve_echo_area',
10659 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
10660
10661 * indent.c (Fvertical_motion):
10662 * window.c (window_scroll_pixel_based, Frecenter):
10663 Don't pass `need_y_p' to `move_it_by_lines'.
10664
1c470562
SM
106652011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
10666
44f230aa
SM
10667 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
10668 steal a few bits to be more compact.
10669 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
10670 Remove unneeded casts.
10671
1c470562
SM
10672 * bytecode.c (Fbyte_code): CAR and CDR can GC.
10673
888adce9
ZK
106742011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
10675
10676 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
10677 binding" message (bug#7967).
10678
f838ed7b
PE
106792011-03-30 Paul Eggert <eggert@cs.ucla.edu>
10680
77861b95
PE
10681 Fix more problems found by GCC 4.6.0's static checks.
10682
de6dbc14
PE
10683 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
10684 Remove unused local var.
10685
f838ed7b
PE
10686 * editfns.c (Fmessage_box): Remove unused local var.
10687
792c7b2b
PE
10688 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
10689 (note_mode_line_or_margin_highlight, note_mouse_highlight):
10690 Omit unused local vars.
c499e557 10691 * window.c (shrink_windows): Omit unused local var.
b01a1c29 10692 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
10693 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
10694 Omit unused local var.
10695
ba0165e1
PE
10696 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
10697 Don't assume string length fits in int.
32ad8845 10698 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 10699 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 10700
3c59b4c9
PE
10701 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
10702 instead of alloca (Bug#8344).
10703
a3eed478 10704 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 10705 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 10706
eb4d412d
PE
10707 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
10708
1658b401
PE
10709 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
10710 concerns.
10711
10712 * term.c (produce_glyphless_glyph): Remove unnecessary test.
10713
10714 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 10715
9a2c6e05
PE
10716 * keyboard.c (syms_of_keyboard): Use the same style as later
10717 in this function when indexing through an array. This also
10718 works around GCC bug 48267.
10719
03d0a109
PE
10720 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
10721
44f730c8
PE
10722 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
10723
fe75f926
PE
10724 * chartab.c (sub_char_table_ref_and_range): Redo for slight
10725 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
10726
ffa8c828
PE
10727 * keyboard.c, keyboard.h (num_input_events): Now size_t.
10728 This avoids undefined behavior on integer overflow, and is a bit
10729 more convenient anyway since it is compared to a size_t variable.
10730
c5101a77
PE
10731 Variadic C functions now count arguments with size_t, not int.
10732 This avoids an unnecessary limitation on 64-bit machines, which
10733 caused (substring ...) to crash on large vectors (Bug#8344).
10734 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
10735 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 10736 All variadic functions and their callers changed accordingly.
c5101a77
PE
10737 (struct gcpro.nvars): Now size_t, not int. All uses changed.
10738 * data.c (arith_driver, float_arith_driver): Likewise.
10739 * editfns.c (general_insert_function): Likewise.
10740 * eval.c (struct backtrace.nargs, interactive_p)
10741 (internal_condition_case_n, run_hook_with_args, apply_lambda)
10742 (funcall_lambda, mark_backtrace): Likewise.
10743 * fns.c (concat): Likewise.
10744 * frame.c (x_set_frame_parameters): Likewise.
10745 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
10746 0 if not found, not -1. All callers changed.
10747
dd3f25f7
PE
10748 * alloc.c (garbage_collect): Don't assume stack size fits in int.
10749 (stack_copy_size): Now size_t, not int.
10750 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
10751
461c2ab9
JB
107522011-03-28 Juanma Barranquero <lekktu@gmail.com>
10753
10754 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
10755 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10756 All callers changed.
10757
10758 * lisp.h (multibyte_char_to_unibyte):
10759 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
10760 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
10761 * character.h (CHAR_TO_BYTE8):
10762 * cmds.c (internal_self_insert):
10763 * editfns.c (general_insert_function):
10764 * keymap.c (push_key_description):
10765 * search.c (Freplace_match):
10766 * xdisp.c (message_dolog, set_message_1): All callers changed.
10767
f6d62986
SM
107682011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
10769
10770 * keyboard.c (safe_run_hook_funcall): New function.
10771 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
10772 don't set the hook to nil, but remove the offending function instead.
10773 (Qcommand_hook_internal): Remove, unused.
10774 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
10775 Vcommand_hook_internal.
10776
10777 * eval.c (enum run_hooks_condition): Remove.
10778 (funcall_nil, funcall_not): New functions.
10779 (run_hook_with_args): Call each function through a `funcall' argument.
10780 Remove `cond' argument, now redundant.
10781 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
10782 (Frun_hook_with_args_until_failure): Adjust accordingly.
10783 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
10784
1db5b1ad
JB
107852011-03-28 Juanma Barranquero <lekktu@gmail.com>
10786
10787 * dispextern.h (string_buffer_position): Remove declaration.
10788
10789 * print.c (strout): Remove parameter `multibyte', unused since
10790 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
10791
10792 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
10793 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
10794 All callers changed.
10795
10796 * w32.c (_wsa_errlist): Use braces for struct initializers.
10797
10798 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
10799 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
10800 All callers changed.
10801 (string_buffer_position): Likewise. Also, make static (it's never
10802 used outside xdisp.c).
10803 (cursor_row_p): Remove parameter `w', unused since
10804 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
10805 (decode_mode_spec): Remove parameter `precision', introduced during
10806 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
10807 All callers changed.
10808
5ffb62aa
JD
108092011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10810
10811 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
10812
461c2ab9 108132011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
10814
10815 * nsterm.m (ns_menu_bar_is_hidden): New variable.
10816 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
10817 (ns_update_auto_hide_menu_bar): New functions.
10818 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
10819 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
10820 ns_constrain_all_frames.
10821 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
10822 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
10823
5c380ffb
JD
108242011-03-27 Jan Djärv <jan.h.d@swipnet.se>
10825
10826 * nsmenu.m (runDialogAt): Remove argument to timer_check.
10827
9af30bdf
GM
108282011-03-27 Glenn Morris <rgm@gnu.org>
10829
10830 * syssignal.h: Replace RETSIGTYPE with void.
10831 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
10832 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
10833 Replace SIGTYPE with void everywhere.
10834 * s/usg5-4-common.h (SIGTYPE): Remove definition.
10835 * s/template.h (SIGTYPE): Remove commented out definition.
10836
e2abce01
JB
108372011-03-26 Eli Zaretskii <eliz@gnu.org>
10838
10839 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
10840 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
10841
f868cd8a
JB
108422011-03-26 Juanma Barranquero <lekktu@gmail.com>
10843
59eb0929
JB
10844 * w32.c (read_unc_volume): Use parameter `henum', instead of
10845 global variable `wget_enum_handle'.
10846
10847 * keymap.c (describe_vector): Remove parameters `indices' and
10848 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
10849 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
10850
f868cd8a
JB
10851 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
10852
10853 * keyboard.c (timer_check): Remove parameter `do_it_now',
10854 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
10855 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
10856 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
10857
10858 * keyboard.c (read_char):
10859 * w32menu.c (w32_menu_display_help):
10860 * xmenu.c (show_help_event, menu_help_callback):
10861 Adjust calls to `show_help_echo'.
10862
10863 * gtkutil.c (xg_maybe_add_timer):
10864 * keyboard.c (readable_events):
10865 * process.c (wait_reading_process_output):
10866 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
10867
10868 * insdel.c (adjust_markers_gap_motion):
10869 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
10870 (gap_left, gap_right): Don't call it.
10871
2ecf6fdb
CY
108722011-03-25 Chong Yidong <cyd@stupidchicken.com>
10873
10874 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
10875 incurred during fontification.
10876
6b1f9ba4
JB
108772011-03-25 Juanma Barranquero <lekktu@gmail.com>
10878
10879 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
10880 (DEFVAR_PER_BUFFER): Don't pass it.
10881
10882 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
10883 (scrolling_window): Don't pass it.
10884
0f4a96b5
JB
108852011-03-25 Juanma Barranquero <lekktu@gmail.com>
10886
10887 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
10888
10889 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
10890 and `suffix'.
10891 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
10892 of variables specific to SELinux and computation of `encoded_absname'.
10893
10894 * image.c (XPutPixel): Remove unused variable `height'.
10895
10896 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
10897
10898 * unexw32.c (get_section_info): Remove unused variable `section'.
10899
10900 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
10901 (system_process_attributes): Remove unused variable `sess'.
10902 (sys_read): Remove unused variable `err'.
10903
10904 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
10905 (w32_wnd_proc): Remove unused variable `isdead'.
10906 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
10907 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
10908 (x_create_tip_frame): Remove unused variable `tem'.
10909
10910 * w32inevt.c (w32_console_read_socket):
10911 Remove unused variable `no_events'.
10912
10913 * w32term.c (x_draw_composite_glyph_string_foreground):
10914 Remove unused variable `width'.
10915
1149507c
JB
109162011-03-24 Juanma Barranquero <lekktu@gmail.com>
10917
10918 * w32term.c (x_set_glyph_string_clipping):
10919 Don't pass uninitialized region to CombineRgn.
10920
9c88f339
JB
109212011-03-23 Juanma Barranquero <lekktu@gmail.com>
10922
10923 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
10924 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
10925 (Fx_close_connection): Remove unused variable `i'.
10926
10927 * w32font.c (w32font_draw): Return number of glyphs.
10928 (w32font_open_internal): Remove unused variable `i'.
10929 (w32font_driver): Add missing initializer.
10930
10931 * w32menu.c (utf8to16): Remove unused variable `utf16'.
10932 (fill_in_menu): Remove unused variable `items_added'.
10933
10934 * w32term.c (last_mouse_press_frame): Remove static global variable.
10935 (w32_clip_to_row): Remove unused variable `f'.
10936 (x_delete_terminal): Remove unused variable `i'.
10937
10938 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
10939 (NOTHING): Remove unused static global variable.
10940 (uniscribe_check_otf): Remove unused variable `table'.
10941 (uniscribe_font_driver): Add missing initializers.
10942
dee091a3
JD
109432011-03-23 Julien Danjou <julien@danjou.info>
10944
10945 * term.c (Fsuspend_tty, Fresume_tty):
10946 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
10947 * window.c (temp_output_buffer_show):
10948 * insdel.c (signal_before_change):
10949 * frame.c (Fhandle_switch_frame):
10950 * fileio.c (Fdo_auto_save):
10951 * emacs.c (Fkill_emacs):
10952 * editfns.c (save_excursion_restore):
10953 * cmds.c (internal_self_insert):
10954 * callint.c (Fcall_interactively):
10955 * buffer.c (Fkill_all_local_variables):
10956 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
10957 Use Frun_hooks.
0f4a96b5 10958 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 10959 unconditionally since it does the check itself.
dee091a3 10960
2c520ab5 109612011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 10962
c9c49752
PE
10963 Fix more problems found by GCC 4.5.2's static checks.
10964
8abc3f12
PE
10965 * coding.c (encode_coding_raw_text): Avoid unnecessary test
10966 the first time through the loop, since we know p0 < p1 then.
10967 This also avoids a gcc -Wstrict-overflow warning.
10968
a2d26660
PE
10969 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
10970 leading to a memory leak, possible in functions like
10971 load_charset_map_from_file that can allocate an unbounded number
b12ef411 10972 of objects (Bug#8318).
a2d26660 10973
916c72e9
PE
10974 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
10975 that could (at least in theory) be that large.
10976
19ab8a18
PE
10977 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
10978 This is less likely to overflow, and avoids undefined behavior if
10979 overflow does occur. All callers changed. Use strtoul to scan
10980 for the unsigned long integer.
b7cbbd6f
PE
10981 (pint2hrstr): Simplify and tune code slightly.
10982 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 10983
f0641eff
PE
10984 * scroll.c (do_scrolling): Work around GCC bug 48228.
10985 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
10986
7f650bb9
PE
10987 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
10988 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
10989 (validate_x_resource_name): Simplify count usage.
10990 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 10991
37dd57d1
PE
10992 * fileio.c (Fcopy_file): Report error if fchown or fchmod
10993 fail (Bug#8306).
81e56e61 10994
699979fc 10995 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 10996
401bf9b4
PE
10997 * process.c (Fmake_network_process): Use socklen_t, not int,
10998 where POSIX says socklen_t is required in portable programs.
10999 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 11000 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
11001 (Fmake_network_process, server_accept_connection):
11002 (wait_reading_process_output, read_process_output):
11003 Likewise.
11004
b93aacde
PE
11005 * process.c: Rename or move locals to avoid shadowing.
11006 (list_processes_1, Fmake_network_process):
11007 (read_process_output_error_handler, exec_sentinel_error_handler):
11008 Rename or move locals.
4dc343ee 11009 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 11010 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 11011 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 11012 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 11013 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 11014
af8a867c 11015 Make tparam.h and terminfo.c consistent.
44f230aa
SM
11016 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
11017 Include tparam.h instead, since it declares them.
af8a867c
PE
11018 * cm.h (PC): Remove extern decl; tparam.h now does this.
11019 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
11020 * terminfo.c: Include tparam.h, to check interfaces.
11021 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
11022 (tparam): Adjust signature to match interface in tparam.h;
11023 this removes some undefined behavior. Check that outstring and len
11024 are zero, which they always are with Emacs.
11025 * tparam.h (PC, BC, UP): New extern decls.
11026
0248044d 11027 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 11028 (xftfont_open): Rename locals to avoid shadowing.
0248044d 11029
8ff096c1 11030 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
11031 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
11032 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 11033 (ftfont_list): Remove unused local.
49eaafba
PE
11034 (get_adstyle_property, ftfont_pattern_entity):
11035 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
11036 Rename locals to avoid shadowing.
8ff096c1 11037
e2be39f6
PE
11038 * xfont.c (xfont_list_family): Mark var as initialized.
11039
c9735e30
PE
11040 * xml.c (make_dom): Now static.
11041
8f5201ae
PE
11042 * composite.c (composition_compute_stop_pos): Rename local to
11043 avoid shadowing.
b246f932
PE
11044 (composition_reseat_it): Remove unused locals.
11045 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 11046 (composition_update_it): Mark var as initialized.
11b61122
PE
11047 (find_automatic_composition): Mark vars as initialized,
11048 with a FIXME (Bug#8290).
8f5201ae 11049
760fbc2c
PE
11050 character.h: Rename locals to avoid shadowing.
11051 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
11052 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
11053 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
11054 (BUF_DEC_POS): Be more systematic about renaming local temporaries
11055 to avoid shadowing.
11056
ff08eb85
PE
11057 * textprop.c (property_change_between_p): Remove; unused.
11058
fc7bf025
PE
11059 * intervals.c (interval_start_pos): Now static.
11060
235d7abc
PE
11061 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
11062
44f230aa
SM
11063 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
11064 Rename locals to avoid shadowing.
3e7d6594 11065
50060332
PE
11066 * sound.c (wav_play, au_play, Fplay_sound_internal):
11067 Fix pointer signedness.
d01f234b 11068 (alsa_choose_format): Remove unused local var.
c83b8872
PE
11069 (wav_play): Initialize a variable to 0, to prevent undefined
11070 behavior (Bug#8278).
50060332 11071
c4fc4e30
PE
11072 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
11073
918436ed
PE
11074 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
11075
c939f91b
PE
11076 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
11077 clobbering (Bug#8298).
b9c7f648
PE
11078 * sysdep.c (sys_subshell): Likewise.
11079 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 11080
6bd8c144
PE
11081 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
11082 This should get cleaned up, so that child_setup has the
11083 same signature on all platforms.
11084
7710357c 11085 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 11086 (relocate_fd): Rename locals to avoid shadowing.
7710357c 11087
c59da222
CY
110882011-03-22 Chong Yidong <cyd@stupidchicken.com>
11089
11090 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
11091 not to be necessary, and produces flickering.
11092
66b87493
GM
110932011-03-20 Glenn Morris <rgm@gnu.org>
11094
11095 * config.in: Remove file.
11096
45b6f6d5
JB
110972011-03-20 Juanma Barranquero <lekktu@gmail.com>
11098
11099 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
11100 are now in src/globals.h.
11101 (syms_of_minibuf): Remove spurious & from previous change.
11102
cd394be1 111032011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
11104
11105 * minibuf.c (completing-read-function): New variable.
11106 (completing-read-default): Rename from completing-read.
11107 (completing-read): Call completing-read-function.
11108
b14e3e21
CY
111092011-03-19 Juanma Barranquero <lekktu@gmail.com>
11110
11111 * xfaces.c (Fx_load_color_file):
11112 Read color file from absolute filename (bug#8250).
11113
f2b726e6
JB
111142011-03-19 Juanma Barranquero <lekktu@gmail.com>
11115
11116 * makefile.w32-in: Update dependencies.
11117
09f6ff02
EZ
111182011-03-17 Eli Zaretskii <eliz@gnu.org>
11119
11120 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
11121
29a6015a
PE
111222011-03-17 Paul Eggert <eggert@cs.ucla.edu>
11123
a3a6c54e
PE
11124 Fix more problems found by GCC 4.5.2's static checks.
11125
b766f867
PE
11126 * process.c (make_serial_process_unwind, send_process_trap):
11127 (sigchld_handler): Now static.
11128
be02381c
PE
11129 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
11130 That way, the code declares only the vars that it needs.
11131 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
11132 * s/cygwin.h (PTY_ITERATION): Likewise.
11133 * s/darwin.h (PTY_ITERATION): Likewise.
11134 * s/gnu-linux.h (PTY_ITERATION): Likewise.
11135
57048744
PE
11136 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
11137 * process.c (allocate_pty): Don't declare stb unless it's needed.
11138
7914961c 11139 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
11140 (CONSTANTLIM): Remove; unused.
11141 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
11142 Define only if needed.
7914961c 11143
b3967b18
PE
11144 * unexelf.c (unexec): Name an expression,
11145 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
11146 Use a different way to cause a compilation error if anyone uses
11147 n rather than nn, a way that does not involve shadowing.
73366a00 11148 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 11149
29a6015a
PE
11150 * deps.mk (unexalpha.o): Remove; unused.
11151
43cfc33e 11152 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 11153 * unexec.h: New file.
ce701a33
PE
11154 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
11155 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
11156 Depend on unexec.h.
11157 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
11158 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
11159 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 11160 Change as necessary to match prototype in unexec.h.
ce701a33 11161
01f44d5a
PE
11162 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
11163 shadowing.
4f63c6bb 11164 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 11165
a6670b0b
PE
11166 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
11167 Rename locals to avoid shadowing.
11168
cef2010d 11169 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 11170 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 11171
d4d7173a
PE
11172 * print.c (Fredirect_debugging_output): Fix pointer signedess.
11173
f08b802a
PE
11174 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
11175 warning when compiling print.c.
11176
3ddb0639
PE
11177 * font.c (font_unparse_fcname): Abort in an "impossible" situation
11178 instead of using an uninitialized var.
5ad03b97 11179 (font_sort_entities): Mark var as initialized.
3ddb0639 11180
170a2692
PE
11181 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
11182
e663c700
PE
11183 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
11184 pointers to constants.
89bc529a 11185 (font_parse_fcname): Remove unused vars.
7b81e2d0 11186 (font_delete_unmatched): Now static.
ea838e10 11187 (font_get_spec): Remove; unused.
13a547c6
PE
11188 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
11189 (font_update_drivers, Ffont_get_glyphs, font_add_log):
11190 Rename or move locals to avoid shadowing.
e663c700 11191
2a80c887 11192 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 11193 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 11194
1384fa33 11195 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 11196 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 11197
8b2c52e9
PE
11198 * alloc.c (mark_backtrace): Move decl from here ...
11199 * lisp.h: ... to here, so that it can be checked.
11200
475545b5 11201 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 11202 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
11203 (lisp_indirect_variable): Name an expression,
11204 to avoid gcc -Wbad-function-cast warning.
1faed8ae 11205 (Fdefvar): Rename locals to avoid shadowing.
475545b5 11206
b1349114 11207 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 11208 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 11209 Use const pointer when appropriate.
b1349114 11210
a2928364
PE
11211 * lisp.h (get_system_name, get_operating_system_release):
11212 Move decls here, to check interfaces.
11213 * process.c (get_operating_system_release): Move decl to lisp.h.
11214 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
11215 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
11216 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
11217 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
11218 (Fformat_time_string, Fencode_time, Finsert_char):
11219 (Ftranslate_region_internal, Fformat):
11220 Rename or remove local vars to avoid shadowing.
9710023e 11221 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 11222
a415e694
PE
11223 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
11224 avoid shadowing.
11225
8ef4622d
PE
11226 * lisp.h (eassert): Check that the argument compiles, even if
11227 ENABLE_CHECKING is not defined.
11228
946f9a5b
PE
11229 * data.c (Findirect_variable): Name an expression, to avoid
11230 gcc -Wbad-function-cast warning.
112396d6 11231 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 11232 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
11233 (Fmake_variable_buffer_local, Fmake_local_variable):
11234 Mark variables as initialized.
52746918 11235 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 11236
e5aab7e7 11237 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
11238 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
11239 Rename locals to avoid shadowing.
dff45157
PE
11240 (mark_stack): Move local variables into the #ifdef region where
11241 they're used.
7bc26fdb
PE
11242 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
11243 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
11244 needed otherwise.
11245 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
11246 (GC_STRING_CHARS): Remove; not used.
d40d4be1 11247 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 11248
e5aab7e7
PE
11249 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
11250 avoids undefined behavior in theory.
11251
4da60324
PE
11252 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
11253
88043301
PE
11254 Use functions, not macros, for up- and down-casing (Bug#8254).
11255 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11256 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
11257 to use the following functions instead of these macros.
11258 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
11259 EMACS_INT, since callers assume the returned value fits in int.
11260 (upcase1): Likewise, for UPCASE_TABLE.
11261 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 11262 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 11263 the race-condition problem in the old DOWNCASE.
88043301 11264
19ed5445
PE
11265 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
11266 Rename locals to avoid shadowing.
11267 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
11268 (regex_compile, re_search_2, re_match_2_internal):
11269 Remove unused local vars.
952db0d7
PE
11270 (FREE_VAR): Rewrite so as not to use empty "else",
11271 which gcc can warn about.
da053e48 11272 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
11273 (RETALLOC_IF): Define only if needed.
11274 (WORDCHAR_P): Likewise. This one is never needed, but is used
11275 only in a comment talking about a compiler bug, so put inside
11276 the #if 0 of that comment.
11277 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
11278 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
11279 Remove; unused.
19ed5445 11280
1f3561e4 11281 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
11282 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
11283 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 11284
ded6f8f7
PE
11285 * search.c (simple_search): Remove unused var.
11286
dbd37a95
PE
11287 * dired.c (compile_pattern): Move decl from here ...
11288 * lisp.h: ... to here, so that it can be checked.
11289 (struct re_registers): New forward decl.
11290
7e47afad
PE
11291 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
11292
85f24f61
PE
11293 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
11294 All uses changed.
11295 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
11296 Rename locals to avoid shadowing.
5671df8f 11297 (Fvertical_motion): Mark locals as initialized.
85f24f61 11298
181aa2be 11299 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 11300 (casify_region): Mark local as initialized.
181aa2be 11301
930d429c
PE
11302 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
11303
7082eac6
PE
11304 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
11305 New macros, so that the caller can use some names other than
11306 gcpro1, gcpro2, etc.
11307 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
11308 of the new macros.
11309 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
11310 argument, for consistency with GCPRO2_VAR, etc: it is now the
11311 prefix of the variable, not the variable itself. All uses
11312 changed.
38b2c076
PE
11313 * dired.c (directory_files_internal, file_name_completion):
11314 Rename locals to avoid shadowing.
11315
15206ed9
PE
11316 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
11317 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
11318 dired.c's scmp function, had undefined behavior.
11319 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
11320 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
11321 * buffer.h: ... to here, because these macros use current_buffer,
11322 and the new implementation with inline functions needs to have
11323 current_buffer in scope now, rather than later when the macros
11324 are used.
11325 (downcase, upcase1): New static inline functions.
11326 (DOWNCASE, UPCASE1): Reimplement using these functions.
11327 This avoids undefined behavior in expressions like
11328 DOWNCASE (x) == DOWNCASE (y), which previously suffered
11329 from race conditions in accessing the global variables
11330 case_temp1 and case_temp2.
11331 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
11332 * lisp.h (case_temp1, case_temp2): Remove their decls.
11333 * character.h (ASCII_CHAR_P): Move from here ...
11334 * lisp.h: ... to here, so that the inline functions mentioned
11335 above can use them.
11336
4a6bea26
PE
11337 * dired.c (directory_files_internal_unwind): Now static.
11338
f14b7e14
PE
11339 * fileio.c (file_name_as_directory, directory_file_name):
11340 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
11341 Now static.
2893f146
PE
11342 (file_name_as_directory): Use const pointers when appropriate.
11343 (Fexpand_file_name): Likewise. In particular, newdir might
11344 point at constant storage, so make it a const pointer.
fd4ead52 11345 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
11346 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
11347 signedness issues.
f839df0c
PE
11348 (Fset_file_times, Finsert_file_contents, auto_save_error):
11349 Rename locals to avoid shadowing.
f14b7e14 11350
5716756e 11351 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
11352 (Ftry_completion, Fall_completions): Rename or remove locals
11353 to avoid shadowing.
5716756e 11354
b4c3046a
PE
11355 * marker.c (bytepos_to_charpos): Remove; unused.
11356
b45db522
PE
11357 * lisp.h (verify_bytepos, count_markers): New decls,
11358 so that gcc does not warn that these functions aren't declared.
11359
85876d07
PE
11360 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
11361 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 11362 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 11363 (copy_text): Remove unused local var.
85876d07 11364
03d78a21 11365 * filelock.c (within_one_second): Now static.
b3dd38ab 11366 (lock_file_1): Rename local to avoid shadowing.
03d78a21 11367
5df8f01b
PE
11368 * buffer.c (fix_overlays_before): Mark locals as initialized.
11369 (fix_start_end_in_overlays): Likewise. This function should be
11370 simplified by using pointers-to-pointers, but that's a different
11371 matter.
b1d876f1 11372 (switch_to_buffer_1): Now static.
8f54f30a
PE
11373 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
11374 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 11375
a70072c9 11376 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 11377 Fix pointer signedness issue.
edced198
PE
11378 (sys_subshell): Mark local as volatile if checking for lint,
11379 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 11380 (MAXPATHLEN): Define only if needed.
a70072c9 11381
a0977c44
PE
11382 * process.c (serial_open, serial_configure): Move decls from here ...
11383 * systty.h: ... to here, so that they can be checked.
11384
a884fdcc
PE
11385 * fns.c (get_random, seed_random): Move extern decls from here ...
11386 * lisp.h: ... to here, so that they can be checked.
11387
604efe86 11388 * sysdep.c (reset_io): Now static.
b8950c94 11389 (wait_for_termination_signal): Remove; unused.
604efe86 11390
38fc62d9
PE
11391 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
11392 (copy_keymap_item, append_key, push_text_char_description):
11393 Now static.
1004a21a 11394 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 11395 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
11396 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
11397 (describe_map_tree):
11398 Rename locals to avoid shadowing.
38fc62d9 11399
2f2650da
PE
11400 * keyboard.c: Declare functions static if they are not used elsewhere.
11401 (echo_char, echo_dash, cmd_error, top_level_2):
11402 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
11403 (read_char, kbd_buffer_get_event, make_lispy_position):
11404 (make_lispy_event, make_lispy_movement, apply_modifiers):
11405 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
11406 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
11407 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 11408 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 11409 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 11410
a053e86c 11411 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
11412 (mark_kboards): Move decl here ...
11413 * alloc.c (mark_kboards): ... from here.
a053e86c 11414
4752793e
PE
11415 * lisp.h (force_auto_save_soon): New decl.
11416
74f10ca7 11417 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
11418 (DEFINE_DUMMY_FUNCTION): New macro.
11419 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
11420 Use it.
c03cd23f
PE
11421 (main): Add casts to avoid warnings
11422 if GCC considers string literals to be constants.
74f10ca7 11423
022e70d4
PE
11424 * lisp.h (fatal_error_signal): Add decl, since it's exported.
11425
59d6fe83
PE
11426 * dbusbind.c: Pointer signedness fixes.
11427 (xd_signature, xd_append_arg, xd_initialize):
11428 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11429 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11430 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
11431 (Fdbus_register_signal): Use SSDATA when the context wants char *.
11432
78320123
PE
11433 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
11434 if GCC considers string literals to be constants.
49cebcca 11435 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 11436
35ac2a97
SM
114372011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
11438
fb103ca9
SM
11439 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
11440 (print_preprocess, print_object): New macro to fix last change.
11441
35ac2a97
SM
11442 * print.c (print_preprocess): Don't forget font objects.
11443
62973b41
JB
114442011-03-16 Juanma Barranquero <lekktu@gmail.com>
11445
11446 * emacs.c (USAGE3): Doc fixes.
11447
0e48bb22
AS
114482011-03-15 Andreas Schwab <schwab@linux-m68k.org>
11449
11450 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
11451 structure.
11452
7684e57b
JB
114532011-03-14 Juanma Barranquero <lekktu@gmail.com>
11454
11455 * lisp.h (VWindow_system, Qfile_name_history):
11456 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
11457 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
11458 (w32_system_caret_x, w32_system_caret_y): Declare extern.
11459
11460 * w32select.c: Don't #include "keyboard.h".
c96bbc66 11461 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
11462
11463 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
11464 * w32console.c (detect_input_pending, read_input_pending)
11465 (encode_terminal_code):
11466 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
11467 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
11468 (w32_system_caret_y, Qfile_name_history):
11469 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
11470 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
11471 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
11472 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
11473 * w32proc.c (Qlocal, report_file_error):
11474 * w32term.c (Vwindow_system, updating_frame):
11475 * w32uniscribe.c (initialized, uniscribe_font_driver):
11476 Remove unneeded extern declarations.
11477
2aa46d6c
CY
114782011-03-14 Chong Yidong <cyd@stupidchicken.com>
11479
c96bbc66 11480 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 11481
cffc6f3b
CY
114822011-03-13 Chong Yidong <cyd@stupidchicken.com>
11483
11484 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
11485 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
11486 These macros can no longer be used for assignment.
11487
44f230aa
SM
11488 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
11489 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
11490 (record_buffer_markers, fetch_buffer_markers): New functions for
11491 recording and fetching special buffer markers.
11492 (set_buffer_internal_1, set_buffer_temp): Use them.
11493
11494 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
11495
11496 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
11497
11498 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
11499 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
11500
11501 * xdisp.c (hscroll_window_tree):
11502 (reconsider_clip_changes): Use PT instead of BUF_PT.
11503
d251f04b
EZ
115042011-03-13 Eli Zaretskii <eliz@gnu.org>
11505
11506 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
11507 $(EMACS_ROOT)/lib/intprops.h.
11508
f0c77cd1
PE
115092011-03-13 Paul Eggert <eggert@cs.ucla.edu>
11510
3eca4629
PE
11511 Fix more problems found by GCC 4.5.2's static checks.
11512
7c86ee98
PE
11513 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
11514 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
11515 (xg_free_frame_widgets): Make it clear that a local variable is
11516 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
11517 (gdk_window_get_screen): Make it clear that this macro is needed
11518 only if USE_GTK_TOOLTIP.
1e5524e7
PE
11519 (int_gtk_range_get_value): New function, which avoids a diagnostic
11520 from gcc -Wbad-function-cast.
11521 (xg_set_toolkit_scroll_bar_thumb): Use it.
11522 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
11523 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
11524 (get_utf8_string, xg_get_file_with_chooser):
11525 Rename locals to avoid shadowing.
11526 (create_dialog): Move locals to avoid shadowing.
7c86ee98 11527
41729b81
PE
11528 * xgselect.c (xg_select): Remove unused var.
11529
f0c77cd1
PE
11530 * image.c (four_corners_best): Mark locals as initialized.
11531 (gif_load): Initialize transparent_p to zero (Bug#8238).
11532 Mark another local as initialized.
ec6cf4c6 11533 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 11534
ce0ad53d 11535 * image.c (clear_image_cache): Now static.
d5d5a617 11536 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 11537 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
11538 (x_edge_detection): Remove unnecessary cast that
11539 gcc -Wbad-function-cast diagnoses.
2037898d 11540 (gif_load): Fix pointer signedness.
6ae141d6
PE
11541 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
11542 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 11543
33383987 115442011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 11545
d32df629
PE
11546 Improve quality of tests for time stamp overflow.
11547 For example, without this patch (encode-time 0 0 0 1 1
11548 1152921504606846976) returns the obviously-bogus value (-948597
11549 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
11550 reports time overflow. See
11551 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
11552 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
11553 * editfns.c: Include limits.h and intprops.h.
11554 (TIME_T_MIN, TIME_T_MAX): New macros.
11555 (time_overflow): Move earlier, to before first use.
11556 (hi_time, lo_time): New functions, for an accurate test for
11557 out-of-range times.
11558 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
11559 (Fget_internal_run_time): Don't assume time_t fits in int.
11560 (make_time): Use list2 instead of Fcons twice.
11561 (Fdecode_time): More accurate test for out-of-range times.
11562 (check_tm_member): New function.
11563 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
11564 (lisp_time_argument): Don't rely on undefined left-shift and
11565 right-shift behavior when checking for time stamp overflow.
8be6f318 11566
fe31d94c
PE
11567 * editfns.c (time_overflow): New function, refactoring common code.
11568 (Fformat_time_string, Fdecode_time, Fencode_time):
11569 (Fcurrent_time_string): Use it.
11570
8be6f318
PE
11571 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
11572 * dired.c (make_time): Move to ...
11573 * editfns.c (make_time): ... here.
11574 * systime.h: Note the move.
11575
09d9db2c 115762011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 11577
126bc0dc
YM
11578 * fringe.c (update_window_fringes): Remove unused variables.
11579
c47cbdfd
YM
11580 * unexmacosx.c (copy_data_segment): Also copy __got section.
11581 (Bug#8223)
11582
7ac80be9
EZ
115832011-03-12 Eli Zaretskii <eliz@gnu.org>
11584
c96bbc66 11585 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
11586 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
11587 Constify `char *' arguments and their references according to
11588 prototypes in tparam.h.
11589
ecb0f94d 11590 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 11591
7ac80be9
EZ
11592 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
11593 Adapt all references accordingly.
11594
11595 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
11596
ef1fd07e
TT
115972011-03-11 Tom Tromey <tromey@redhat.com>
11598
11599 * buffer.c (syms_of_buffer): Remove obsolete comment.
11600
7ef4b50c
EZ
116012011-03-11 Eli Zaretskii <eliz@gnu.org>
11602
11603 * termhooks.h (encode_terminal_code): Declare prototype.
11604
11605 * msdos.c (encode_terminal_code): Don't declare prototype.
11606
11607 * term.c (encode_terminal_code): Now external again, used by
11608 w32console.c and msdos.c.
11609
44f230aa
SM
11610 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
11611 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 11612
4b1ec863 116132011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 11614
1714f52b 11615 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 11616
4b1ec863
PE
11617 * fringe.c (update_window_fringes): Mark locals as initialized
11618 (Bug#8227).
11619 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 11620
524c7aa6
PE
11621 * alloc.c (mark_fringe_data): Move decl from here ...
11622 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
11623 to check its interface.
11624 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
11625
a5c0af81 11626 * fontset.c (free_realized_fontset): Now static.
7519b8cd 11627 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 11628 (fontset_font): Mark local as initialized.
a9a06e0b 11629 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 11630
b4716021
PE
11631 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
11632
811e9bac 11633 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 11634 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
11635 (x_own_selection, Fx_disown_selection_internal): Rename locals
11636 to avoid shadowing.
11637 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 11638
7e3ab302
PE
11639 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
11640 so that the caller can use some name other than gcpro1.
11641 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
11642 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11643 (Fx_backspace_delete_keys_p):
11644 Use them to avoid shadowing, and rename vars to avoid shadowing.
11645 (x_decode_color, x_set_name, x_window): Now static.
6b437900 11646 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 11647 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
11648 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
11649 Remove unused locals.
7e3ab302
PE
11650 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
11651 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
11652 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
11653 macros.
f78faa98 11654
e2b13473
PE
11655 * xterm.h (x_mouse_leave): New decl.
11656
77f23912
PE
11657 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
11658 Remove unused functions.
cdf4ba58
PE
11659 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
11660 (x_calc_absolute_position): Now static.
7411c686 11661 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 11662 Don't declare local "event" unless it's used.
ed7bf3a5
PE
11663 (x_iconify_frame, x_free_frame_resources): Don't declare locals
11664 unless they are used.
38d0b34a
PE
11665 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
11666 (x_fatal_error_signal): Remove; not used.
a6067996
PE
11667 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
11668 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
11669 (x_error_catcher, x_connection_closed, x_error_handler):
11670 (x_error_quitter, xembed_send_message, x_iconify_frame):
11671 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 11672 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 11673 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 11674
44f230aa
SM
11675 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
11676 Rename or move locals to avoid shadowing.
6b463e58 11677 (tty_defined_color, merge_face_heights): Now static.
5967d051 11678 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
11679 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
11680 does not deduce is never used uninitialized.
73719eba
PE
11681 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
11682 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 11683
426994c3 11684 * terminal.c (store_terminal_param): Now static.
5489860b 11685
032f1620 11686 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 11687 (set_frame_menubar): Remove unused local.
d4323972 11688 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
11689 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
11690 since they might point to immutable storage.
281585b0
PE
11691 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
11692 since it's unused otherwise.
032f1620 11693
367c19e5 11694 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 11695 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
11696 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
11697 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 11698 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
11699 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
11700 does not deduce are never used uninitialized.
70739cbe 11701
07b48fa9
PE
11702 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
11703
8868a238 11704 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
11705 * window.c (window_loop, size_window):
11706 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 11707
7e5cf297 11708 * window.c (display_buffer): Now static.
d6550a9f
PE
11709 (size_window): Mark variables that gcc -Wuninitialized
11710 does not deduce are never used uninitialized.
a586633d
PE
11711 * window.h (check_all_windows): New decl, to forestall
11712 gcc -Wmissing-prototypes diagnostic.
5b555da1 11713 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 11714
f6095868
PE
11715 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
11716 shadowing.
11717 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
11718 Include <limits.h>.
11719 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
11720 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
11721 (load_charset_map): Mark variables that gcc -Wuninitialized
11722 does not deduce are never used uninitialized.
53df7c11 11723 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 11724
f38b440c
PE
11725 * coding.c (coding_set_source, coding_set_destination):
11726 Use "else { /* comment */ }" rather than "else /* comment */;"
11727 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
11728 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
11729 a block, when the outer 'i' will do.
11730 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
11731 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
11732 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
11733 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
11734 (Fdecode_sjis_char, Fdefine_coding_system_internal):
11735 Rename locals to avoid shadowing.
11736 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
11737 * coding.c (emacs_mule_char, encode_invocation_designation):
11738 Now static, since they're not used elsewhere.
413bb2db 11739 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 11740 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
11741 (decode_coding_emacs_mule): Mark variables that gcc
11742 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
11743 (detect_coding_iso_2022): Initialize a local variable that might
11744 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 11745 this initialization is needed. (Bug#8211)
5f58e762
PE
11746 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
11747 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
11748 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
11749 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
11750 Remove unused macros.
f38b440c 11751
232b38b9 11752 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 11753 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 11754 * character.c (string_count_byte8): Likewise.
232b38b9 11755
fb90da1b
PE
11756 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
11757 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
11758
fb93dbc2
PE
11759 * chartab.c (copy_sub_char_table): Now static, since it's not used
11760 elsewhere.
5c156ace
PE
11761 (sub_char_table_ref_and_range, char_table_ref_and_range):
11762 Rename locals to avoid shadowing.
bbcd0949 11763 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 11764
7d3b3862 11765 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 11766 (BIDI_BOB): Remove unused macro.
7d3b3862 11767
6be7d3da
PE
11768 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
11769 deduce are never used uninitialized.
c2ed9c8b 11770 * term.c (encode_terminal_code): Likewise.
6be7d3da 11771
75f8807f 11772 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 11773
50938595
PE
11774 * tparam.h: New file.
11775 * term.c, tparam.h: Include it.
11776 * deps.mk (term.o, tparam.o): Depend on tparam.h.
11777 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
11778 Move these decls to tparam.h, and make them agree with what
11779 is actually in tparam.c. The previous trick of using incompatible
11780 decls in different modules does not conform to the C standard.
11781 All callers of tparam changed to use tparam's actual API.
11782 * tparam.c (tparam1, tparam, tgoto):
11783 Use const pointers where appropriate.
11784
fbceeba2
PE
11785 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
11786 * cm.h (struct cm): Likewise.
11787 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
11788 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
11789 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
11790 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
11791 (turn_on_face, init_tty): Likewise.
11792 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 11793
7f3f1250
PE
11794 * term.c (term_mouse_position): Rename local to avoid shadowing.
11795
e6ca6543
PE
11796 * alloc.c (mark_ttys): Move decl from here ...
11797 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
11798
c40f8d15
AS
117992011-03-11 Andreas Schwab <schwab@linux-m68k.org>
11800
11801 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
11802
cfe0661d
JB
118032011-03-09 Juanma Barranquero <lekktu@gmail.com>
11804
11805 * search.c (compile_pattern_1): Remove argument regp, unused since
11806 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
11807 (compile_pattern): Don't pass it.
11808
0afb4571
J
118092011-03-08 Jan Djärv <jan.h.d@swipnet.se>
11810
11811 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
11812 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
11813 for ! HAVE_GTK3.
11814 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
11815
11816 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
11817
11818 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
11819 gdk_window_get_screen, gdk_window_get_geometry,
11820 gdk_x11_window_lookup_for_display and GDK_KEY_g.
11821 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
11822 (xg_get_pixbuf_from_pixmap): New function.
11823 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
11824 to Pixmap, take frame as parameter, remove GdkColormap parameter.
11825 Call xg_get_pixbuf_from_pixmap instead of
11826 gdk_pixbuf_get_from_drawable.
11827 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
11828 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
11829 (xg_check_special_colors): Use GtkStyleContext and its functions
11830 for HAVE_GTK3.
11831 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
11832 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
11833 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
11834 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
11835 Call gtk_widget_get_preferred_size.
0afb4571
J
11836 (xg_frame_resized): gdk_window_get_geometry only takes 5
11837 parameters.
44f230aa
SM
11838 (xg_win_to_widget, xg_event_is_for_menubar):
11839 Call gdk_x11_window_lookup_for_display.
0afb4571
J
11840 (xg_set_widget_bg): New function.
11841 (delete_cb): New function.
895009e1 11842 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 11843 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
11844 (xg_set_background_color): Call xg_set_widget_bg.
11845 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
11846 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
11847 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
11848 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
11849 if ! HAVE_GTK3.
11850 (update_frame_tool_bar): Call gtk_widget_hide.
11851 (xg_initialize): Use GDK_KEY_g.
11852
11853 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
11854 if ! HAVE_GTK3
11855 (x_session_initialize): Call gdk_x11_set_sm_client_id.
11856
11857 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
11858 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
11859 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
11860
1c2cc4ef
JB
118612011-03-08 Juanma Barranquero <lekktu@gmail.com>
11862
11863 * w32xfns.c (select_palette): Check success of RealizePalette against
11864 GDI_ERROR, not zero.
11865
33383987 11866See ChangeLog.11 for earlier changes.
aac0c6e3
MR
11867
11868;; Local Variables:
11869;; coding: utf-8
aac0c6e3
MR
11870;; End:
11871
2f097256 11872 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
11873
11874 This file is part of GNU Emacs.
11875
11876 GNU Emacs is free software: you can redistribute it and/or modify
11877 it under the terms of the GNU General Public License as published by
11878 the Free Software Foundation, either version 3 of the License, or
11879 (at your option) any later version.
11880
11881 GNU Emacs is distributed in the hope that it will be useful,
11882 but WITHOUT ANY WARRANTY; without even the implied warranty of
11883 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
11884 GNU General Public License for more details.
11885
11886 You should have received a copy of the GNU General Public License
11887 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.