Note in Lisp manual that mouse-face cannot change the text size.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
97bb72a6
EZ
12011-08-08 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (forward_to_next_line_start): Allow to use the
757664a4
EZ
4 no-display-properties-and-no-overlays under bidi display. Set
5 disp_pos in the bidi iterator to avoid searches for display
6 properties and overlays.
97bb72a6 7
d5617611
CY
82011-08-08 Chong Yidong <cyd@stupidchicken.com>
9
37e11a63
CY
10 * editfns.c (Fset_time_zone_rule): Document relationship with the
11 setenv function.
12
d5617611
CY
13 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
14 the font entity extracted from the cache (Bug#8109).
15
58872834
CY
162011-08-07 Chong Yidong <cyd@stupidchicken.com>
17
18 * composite.c (autocmp_chars): Don't reset point. That is done by
19 restore_point_unwind (Bug#5984).
20
75bfc667
JL
212011-08-07 Juri Linkov <juri@jurta.org>
22
23 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
24 to show the arg `TIME' instead of `TIMEVAL'.
25
d1410150
EZ
262011-08-06 Eli Zaretskii <eliz@gnu.org>
27
28 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
29 display property strides EOL and includes a newline, as in
30 longlines-mode. (Bug#9254)
75b771e4
EZ
31 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
32 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
33
34 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
35 is non-zero, even if the data buffer is NULL. Fixes a crash in
36 vertical-motion with longlines-mode. (Bug#9254)
37
35928349
EZ
382011-08-05 Eli Zaretskii <eliz@gnu.org>
39
ec7cc85b
EZ
40 * bidi.c <bidi_cache_total_alloc>: Now static.
41 (bidi_initialize): Initialize bidi_cache_total_alloc.
42
35928349
EZ
43 *xdisp.c (display_line): Release buffer allocated for shelved bidi
44 cache. (Bug#9221)
45
46 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
47 amount allocated this far in `bidi_cache_total_alloc'.
48 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
49 non-zero, only free the data buffer without restoring the cache
50 contents. All callers changed.
51
52 * dispextern.h (bidi_unshelve_cache): Update prototype.
53
54 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
55 (move_it_in_display_line, move_it_to)
56 (move_it_vertically_backward, move_it_by_lines): Replace the call
57 to xfree to an equivalent call to bidi_unshelve_cache.
58 (move_it_in_display_line_to): Fix logic of returning
412b6358 59 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 60
e2e2423b
EZ
612011-08-05 Eli Zaretskii <eliz@gnu.org>
62
63 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
64 came from a string character with a `cursor' property. (Bug#9229)
65
ae9e757a
JD
662011-08-04 Jan Djärv <jan.h.d@swipnet.se>
67
68 * Makefile.in (LIB_PTHREAD): New variable.
69 (LIBES): Add LIB_PTHREAD (Bug#9216).
70
71 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
72 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
73
213bd7f2
AS
742011-08-04 Andreas Schwab <schwab@linux-m68k.org>
75
76 * regex.c (re_iswctype): Remove some redundant boolean
77 conversions.
78
99aaf75f
JD
792011-08-04 Jan Djärv <jan.h.d@swipnet.se>
80
81 * xterm.c (x_find_topmost_parent): New function.
82 (x_set_frame_alpha): Find topmost parent window with
83 x_find_topmost_parent and set the property there also (bug#9181).
84 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
85
c74e9d86
PE
862011-08-04 Paul Eggert <eggert@cs.ucla.edu>
87
88 * callproc.c (Fcall_process): Avoid vfork clobbering
89 the local vars buffer, coding_systems, current_dir.
90
640c8776
SM
912011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
92
93 * keymap.c (Fmake_composed_keymap): Move to subr.el.
94
f26d0e4c
PE
952011-08-03 Paul Eggert <eggert@cs.ucla.edu>
96
8a10d76c
PE
97 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
98 so that it is not optimized away.
99
f26d0e4c
PE
100 * xdisp.c (compute_display_string_pos): Remove unused local.
101
55439c61
EZ
1022011-08-02 Eli Zaretskii <eliz@gnu.org>
103
104 Fix slow cursor motion and scrolling in large buffers with
105 selective display, like Org Mode buffers. (Bug#9218)
106
107 * dispextern.h (struct bidi_it): New member disp_prop_p.
108
109 * xdisp.c: Remove one-slot cache of display string positions.
110 (compute_display_string_pos): Accept an additional argument
111 DISP_PROP_P; callers changed. Scan at most 5K characters forward
112 for a display string or property. If found, set DISP_PROP_P
113 non-zero.
114
115 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
116 DISP_PROP_P, and pass it to compute_display_string_pos.
117 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
118 non-zero. All callers of bidi_fetch_char changed.
119
fb33fa43
SM
1202011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
121
122 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
123
b099e063
DM
1242010-12-03 Don March <don@ohspite.net>
125
126 * keymap.c (Fdefine_key): Fix non-prefix key error message when
127 last character M-[char] is translated to ESC [char] (bug#7541).
128
5cc7f7af
KH
1292011-08-02 Kenichi Handa <handa@m17n.org>
130
d0fffa3f 131 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
132
133 * chartab.c (uniprop_table): Make it non-static.
134
525d5e6e
EZ
1352011-08-01 Eli Zaretskii <eliz@gnu.org>
136
137 * xdisp.c (forward_to_next_line_start): Accept additional argument
138 BIDI_IT_PREV, and store into it the state of the bidi iterator had
139 on the newline.
140 (reseat_at_next_visible_line_start): Use the bidi iterator state
141 returned by forward_to_next_line_start to restore the state of
142 it->bidi_it after backing up to previous newline. (Bug#9212)
143
31011111
AS
1442011-07-30 Andreas Schwab <schwab@linux-m68k.org>
145
146 * regex.c (re_comp): Protoize.
147 (re_exec): Fix return type.
148 (regexec): Fix type of `ret'. (Bug#9203)
149
e5d76069
PE
1502011-07-29 Paul Eggert <eggert@cs.ucla.edu>
151
152 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
153 This is needed if max-image-size is a floating-point number.
154
9a79b20c
AS
1552011-07-28 Andreas Schwab <schwab@linux-m68k.org>
156
157 * print.c (print_object): Print empty symbol as ##.
158
159 * lread.c (read1): Read ## as empty symbol.
160
d8c2fa78
AA
1612011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
162
163 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
164 setting frame foreground color (Bug#9175).
165 (x_set_background_color): Likewise.
166
ffe57a7a
AA
167 * nsmenu.m (-setText): Size tooltip dimensions precisely to
168 contents (Bug#9176).
169 (EmacsTooltip -init): Remove bezels and add shadows to
170 tooltip windows.
171
bf3492a5
AA
172 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
173 or scroll bar (Bug#8470).
174
d55e9c53
AA
175 * nsfont.m (nsfont_open): Remove assignment to voffset and
176 unnecessary vars hshink, expand, hd, full_height, min_height.
177 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
178
179 * nsterm.h (nsfont_info): Remove voffset field.
180
d8c2fa78 1812011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
182
183 Implement strike-through and overline on NextStep (Bug#8863).
184
185 * nsfont.m (nsfont_open): Use underline position provided by font,
186 instead of hard-coded value of 2.
187 (nsfont_draw): Call ns_draw_text_decoration instead.
188
189 * nsterm.h: Add declaration for ns_draw_text_decoration.
190
191 * nsterm.m (ns_draw_text_decoration): New function for drawing
192 underline, overline, and strike-through.
193 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
194 ns_draw_text_decoration. Change treatment of cursor drawing to
195 accomodate underlining, etc.
196
4cc60b9b
EZ
1972011-07-28 Eli Zaretskii <eliz@gnu.org>
198
bc7ece87
EZ
199 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
200 default.
4cc60b9b 201
476371c4
PE
2022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
203
66606eea
PE
204 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
205 Without this fix, if a signal arrives just after memory fills up,
206 'malloc' might be invoked reentrantly.
207
476371c4
PE
208 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
209 In other words, assume that every image size is allowed, on non-X
210 hosts. This assumption is probably wrong, but it lets Emacs compile.
211
f3fcc40d
AS
2122011-07-28 Andreas Schwab <schwab@linux-m68k.org>
213
214 * regex.c (re_iswctype): Convert return values to boolean.
215
350c992f
EZ
2162011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
217
218 * xdisp.c (compute_display_string_pos): Don't use cached display
219 string position if the buffer had its restriction changed.
220 (Bug#9184)
221
5266b4bb
PE
2222011-07-28 Paul Eggert <eggert@cs.ucla.edu>
223
224 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
225
2573a837 2262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 227
41f55ccd 228 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 229
39e378da
PE
230 * bidi.c: Integer size and overflow fixes.
231 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
232 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
233 (bidi_cache_find_level_change, bidi_cache_ensure_space)
234 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
235 (bidi_find_other_level_edge):
236 Use ptrdiff_t instead of EMACS_INT where either will do.
237 This works better on 32-bit hosts configured --with-wide-int.
238 (bidi_cache_ensure_space): Check for size-calculation overflow.
239 Use % rather than repeated addition, for better worst-case speed.
240 Don't set bidi_cache_size until after xrealloc returns, because it
241 might not return.
242 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
243 (bidi_cache_ensure_space): Also check that the bidi cache size
244 does not exceed that of the largest Lisp string or buffer. See Eli
245 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 246
5e927815
PE
247 * alloc.c (__malloc_size_t): Remove.
248 All uses replaced by size_t. See Andreas Schwab's note
249 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
250
ca4aa935
PE
251 * image.c: Improve checking for integer overflow.
252 (check_image_size): Assume that f is nonnull, since
253 it is always nonnull in practice. This is one less thing to
254 worry about when checking for integer overflow later.
255 (x_check_image_size): New function, which checks for integer
256 overflow issues inside X.
257 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
258 This removes the need for a memory_full check.
259 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
260 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
261 (xbm_read_bitmap_data): Change locals back to 'int', since
262 their values must fit in 'int'.
263 (xpm_load_image, png_load, tiff_load):
264 Invoke x_create_x_image_and_pixmap earlier,
265 to avoid much needless work if the image is too large.
266 (tiff_load): Treat overly large images as if
267 x_create_x_image_and_pixmap failed, not as malloc failures.
268 (gs_load): Use x_check_image_size.
269
5f8f9cc2
PE
270 * gtkutil.c: Omit integer casts.
271 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
272 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
273
5adf60bc
PE
274 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
275
c8907a93
PE
276 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
277 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
278 would wrongly return t on a 64-bit host.
279
e3c25c68
PE
280 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
281 The plain *_OVERFLOW macros run afoul of GCC bug 49705
282 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
283 and therefore cause GCC to emit a bogus diagnostic in some cases.
284
3f791afe
PE
285 * image.c: Integer signedness and overflow and related fixes.
286 This is not an exhaustive set of fixes, but it's time to
287 record what I've got.
288 (lookup_pixel_color, check_image_size): Remove redundant decls.
289 (check_image_size): Don't assume that arbitrary EMACS_INT values
290 fit in 'int', or that arbitrary 'double' values fit in 'int'.
291 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
292 (tiff_load, imagemagick_load_image):
293 Check for overflow in size calculations.
294 (x_create_x_image_and_pixmap): Remove unnecessary test for
295 xmalloc returning NULL; that can't happen.
296 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
297 (xpm_color_bucket): Use better integer hashing function.
298 (xpm_cache_color): Don't possibly over-allocate memory.
299 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
300 (gif_memory_source):
301 Use ptrdiff_t, not int or size_t, to record sizes.
302 (png_load): Don't assume values greater than 2**31 fit in 'int'.
303 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
304 either works, as we prefer signed integers.
305 (tiff_read_from_memory, tiff_write_from_memory):
306 Return tsize_t, not size_t, since that's what the TIFF API wants.
307 (tiff_read_from_memory): Don't fail simply because the read would
308 go past EOF; instead, return a short read.
309 (tiff_load): Omit no-longer-needed casts.
310 (Fimagemagick_types): Don't assume size fits into 'int'.
311
3cc5a532
PE
312 Improve hashing quality when configured --with-wide-int.
313 * fns.c (hash_string): New function, taken from sxhash_string.
314 Do not discard information about ASCII character case; this
315 discarding is no longer needed.
316 (sxhash-string): Use it. Change sig to match it. Caller changed.
317 * lisp.h: Declare it.
318 * lread.c (hash_string): Remove, since we now use fns.c's version.
319 The fns.c version returns a wider integer if --with-wide-int is
320 specified, so this should help the quality of the hashing a bit.
321
b312a492
PE
322 * emacs.c: Integer overflow minor fix.
323 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
324 Define only if GNU_LINUX.
325 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
326
dfd153ae
PE
327 * dispnew.c: Integer signedness and overflow fixes.
328 Remove unnecessary forward decls, that were a maintenance hassle.
329 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
330 All uses changed.
331 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
332 (scrolling_window): Use ptrdiff_t, not int, for byte count.
333 (prepare_desired_row, line_draw_cost):
334 Use int, not unsigned, where either works.
335 (save_current_matrix, restore_current_matrix):
336 Use ptrdiff_t, not size_t, where either works.
337 (init_display): Check for overflow more accurately, and without
338 relying on undefined behavior.
339
a81d11a3
PE
340 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
341 Remove, replacing with the new symbols in lisp.h. All uses changed.
342 * fileio.c (make_temp_name):
343 * filelock.c (lock_file_1, lock_file):
344 * xdisp.c (message_dolog):
345 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
346 Use pMd etc. instead.
347 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
348 replacing the pWIDE etc. symbols removed from editfns.c.
349
3300e6fd
PE
350 * keyboard.h (num_input_events): Now uintmax_t.
351 This is (very slightly) less likely to mess up due to wraparound.
352 All uses changed.
353
fd05c7e9
PE
354 * buffer.c: Integer signedness fixes.
355 (alloc_buffer_text, enlarge_buffer_text):
356 Use ptrdiff_t rather than size_t when either will do, as we prefer
357 signed integers.
358
903fe15d
PE
359 * alloc.c: Integer signedness and overflow fixes.
360 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
361 (__malloc_size_t): Default to size_t, not to int.
362 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
363 (Fgarbage_collect, mark_object_loop_halt, mark_object):
364 Prefer ptrdiff_t to size_t when either would do, as we prefer
365 signed integers.
366 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
367 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
368 Now const. Initialize with values that are in range even if char
369 is signed.
370 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
371 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
372 These functions do the right thing with sizes > 2**32.
373 (check_depth): Now ptrdiff_t, not int.
374 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
375 Adjust to new way of storing sizes. Check for size overflow bugs
376 in rest of code.
377 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
378 slightly wrong anyway, as it missed one instance of
379 XMALLOC_OVERRUN_CHECK_OVERHEAD.
380 (refill_memory_reserve): Omit needless cast to size_t.
381 (mark_object_loop_halt): Mark as externally visible.
382
ac82cc6a
PE
383 * xselect.c: Integer signedness and overflow fixes.
384 (Fx_register_dnd_atom, x_handle_dnd_message):
385 Use ptrdiff_t, not size_t, since we prefer signed.
386 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
387 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
388 x_dnd_atoms_size and x_dnd_atoms_length.
389
c2d1e36d
PE
390 * doprnt.c: Prefer signed to unsigned when either works.
391 * eval.c (verror):
392 * doprnt.c (doprnt):
393 * lisp.h (doprnt):
394 * xdisp.c (vmessage):
395 Use ptrdiff_t, not size_t, when using or implementing doprnt,
396 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
397 prefer signed arithmetic to avoid comparison confusion.
398 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
399 but is a bit tricky.
400
0e926e56
PE
401 Assume freestanding C89 headers, string.h, stdlib.h.
402 * data.c, doprnt.c, floatfns.c, print.c:
403 Include float.h unconditionally.
404 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
405 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
406 * regex.c: Likewise for stddef.h, string.h.
407 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
408 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
409 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
410 (STDC_HEADERS): Remove obsolete defines.
411 * sysdep.c: Include limits.h unconditionally.
412
9cfdb3ec
PE
413 Assume support for memcmp, memcpy, memmove, memset.
414 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
415 * regex.c (memcmp, memcpy):
416 Remove; we assume C89 now.
417
418 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
419 (__malloc_safe_bcopy): Remove; no longer needed.
420
cf950e6b 421 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
422 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
423 well either way, and we prefer signed to unsigned.
424
dbf38e02
LMI
4252011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
426
427 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
428 closes the connection while we're reading (bug#9182).
429
d6f0886c
JD
4302011-07-25 Jan Djärv <jan.h.d@swipnet.se>
431
432 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
433 are specified (Bug#9168).
434
2eb1f9e6
PE
4352011-07-25 Paul Eggert <eggert@cs.ucla.edu>
436
437 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
438 Found by GCC static checking and --with-wide-int on a 32-bit host.
439
22381272 4402011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
441
442 * xdisp.c (compute_display_string_pos): Fix logic of caching
443 previous display string position. Initialize cached_prev_pos to
444 -1. Fixes slow-down at the beginning of a buffer.
445
f25e39b4
EZ
4462011-07-24 Eli Zaretskii <eliz@gnu.org>
447
448 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
449 for attrs[LFACE_FONTSET_INDEX].
450
04c4b52e
PE
4512011-07-23 Paul Eggert <eggert@cs.ucla.edu>
452
453 * xml.c (parse_region): Remove unused local
454 that was recently introduced.
455
c1734fbd
EZ
4562011-07-23 Eli Zaretskii <eliz@gnu.org>
457
be18c5a5
EZ
458 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
459 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
460
c1734fbd
EZ
461 * xdisp.c (move_it_in_display_line_to): Record the best matching
462 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
463 exit if none of the characters scanned was an exact match.
464 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
465 when exact match is impossible due to invisible text, and the
466 lines are truncated.
467
a258d627
JD
4682011-07-23 Jan Djärv <jan.h.d@swipnet.se>
469
470 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
471 for OSX >= 10.7.
472
b6d5a689
EZ
4732011-07-22 Eli Zaretskii <eliz@gnu.org>
474
0f74f785
EZ
475 Fix a significant slow-down of cursor motion with C-n, C-p,
476 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
477 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 478 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
479 (next_element_from_buffer): Call compute_stop_pos_backwards to
480 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
481 base_level_stop.
482 (reseat): Don't look for prev_stop, as that could mean a very long
483 run.
484 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
485 <cached_disp_overlay_modiff>: Cache for last found display string
486 position.
551918c1 487 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
488 about the same buffer in the same area of character positions, and
489 the buffer wasn't changed since the time the display string
490 position was cached.
551918c1 491
b2d0c91a
EZ
4922011-07-22 Eli Zaretskii <eliz@gnu.org>
493
494 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
495 is an integer, which is important for empty lines. (Bug#9149)
496
043604ee
CY
4972011-07-22 Chong Yidong <cyd@stupidchicken.com>
498
499 * frame.c (Fmodify_frame_parameters): In tty case, update the
500 default face if necessary (Bug#4238).
501
da4adb04
CY
5022011-07-21 Chong Yidong <cyd@stupidchicken.com>
503
504 * editfns.c (Fstring_to_char): No need to explain what a character
505 is in the docstring (Bug#6576).
506
9abd0532
LMI
5072011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
508
509 * xml.c (parse_region): Make sure we always return a tree.
510
36881d16
HK
5112011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
512
513 * xml.c (parse_region): If a document contains only comments,
514 return that, too.
515
1e98674d
LMI
5162011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
517
518 * xml.c (make_dom): Return comments, too.
519
590bd467
PE
5202011-07-19 Paul Eggert <eggert@cs.ucla.edu>
521
522 Port to OpenBSD.
523 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
524 and the surrounding thread.
525 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
526 rather than fgets, and retry after EINTR. Otherwise, 'emacs
527 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
528 timer goes off.
529 * s/openbsd.h (BROKEN_SIGIO): Define.
530 * unexelf.c (unexec) [__OpenBSD__]:
531 Don't update the .mdebug section of the Alpha COFF symbol table.
532
f41628b2
LMI
5332011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
534
535 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
536 (bug#8460).
537
b59b67c5
PE
5382011-07-18 Paul Eggert <eggert@cs.ucla.edu>
539
15e3a074
PE
540 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
541 This fixes some race conditions on the permissions of any newly
542 created file.
543
41bed37d
PE
544 * alloc.c (valid_pointer_p): Use pipe, not open.
545 This fixes some permissions issues when debugging.
546
b59b67c5
PE
547 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
548 If fchown fails to set both uid and gid, try to set just gid,
549 as that is sometimes allowed. Adjust the file's mode to eliminate
550 setuid or setgid bits that are inappropriate if fchown fails.
551
925a6be7
SM
5522011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
553
554 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
555 to compare Lisp_Objects.
556 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
557 global_gnutls_log_level, don't mistake it for a Lisp_Object.
558 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
559
52968808
AS
5602011-07-17 Andreas Schwab <schwab@linux-m68k.org>
561
0a6a104b
AS
562 * lread.c (read_integer): Unread even EOF character.
563 (read1): Likewise. Properly record start position of symbol.
564
52968808
AS
565 * lread.c (read1): Read `#:' as empty uninterned symbol if no
566 symbol character follows.
567
9e381cdd
PE
5682011-07-17 Paul Eggert <eggert@cs.ucla.edu>
569
570 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
571 This works around a problem with the previous change to Fcopy_file.
572 Recent glibc declares fchown with __attribute__((warn_unused_result)),
573 and without this change, GCC might complain about discarding
574 fchown's return value.
575
b5641435
JB
5762011-07-16 Juanma Barranquero <lekktu@gmail.com>
577
578 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
579
a8031457
PE
5802011-07-16 Paul Eggert <eggert@cs.ucla.edu>
581
582 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
583
dd889327
LMI
5842011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
585
750c33f7
LMI
586 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
587 it's used from the C level.
588
dd889327
LMI
589 * process.c: Use the same condition for POLL_FOR_INPUT in both
590 keyboard.c and process.c (bug#1858).
591
87e86684
LM
5922011-07-09 Lawrence Mitchell <wence@gmx.li>
593
594 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
595 (Fgnutls_boot): Use it.
596
64348f40
AS
5972011-07-15 Andreas Schwab <schwab@linux-m68k.org>
598
599 * doc.c (Fsubstitute_command_keys): Revert last change.
600
1d698799
LMI
6012011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
602
f863868c
LMI
603 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
604 quotes the next character, and doesn't affect other longer
605 sequences (bug#8935).
606
1d698799
LMI
607 * lread.c (syms_of_lread): Clarify that is isn't only
608 `eval-buffer' and `eval-defun' that's affected by
609 `lexical-binding' (bug#8460).
610
aa4b6df6
EZ
6112011-07-15 Eli Zaretskii <eliz@gnu.org>
612
613 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
614 bidi redisplay when a line includes both an image and is
615 truncated.
616
5d856da6
PE
6172011-07-14 Paul Eggert <eggert@cs.ucla.edu>
618
ad6042bb
PE
619 Fix minor problems found by static checking.
620 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
621 (elsz): Now a signed constant, not a size_t var. We prefer signed
622 types to unsigned, to avoid integer comparison confusion. Without
623 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
624 "cannot optimize loop, the loop counter may overflow", a symptom
625 of the confusion.
f00bbb22 626 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
627 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
628
6468f31c
LMI
6292011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
630
49080b10
LMI
631 * search.c (Fre_search_backward): Mention `case-fold-search' in
632 all the re_search_* functions (bug#8138).
633
6468f31c
LMI
634 * keyboard.c (Fopen_dribble_file): Document when the file is
635 closed (bug#8056).
636
c965adc5
EZ
6372011-07-14 Eli Zaretskii <eliz@gnu.org>
638
df9733bf
EZ
639 * bidi.c (bidi_dump_cached_states): Fix format of displaying
640 bidi_cache_idx.
641
0bb23927
EZ
642 Support bidi reordering of display and overlay strings.
643 * xdisp.c (compute_display_string_pos)
644 (compute_display_string_end): Accept additional argument STRING.
645 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
646 (reseat_to_string): Initialize bidi_it->string.s and
647 bidi_it->string.schars.
648 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
649 NULL (avoids a crash in bidi_paragraph_init).
650 Initialize itb.string.lstring.
0bb23927
EZ
651 (init_iterator): Call bidi_init_it only of a valid
652 buffer position was specified. Initialize paragraph_embedding to
653 L2R.
654 (reseat_to_string): Initialize the bidi iterator.
655 (display_string): If we need to ignore text properties of
656 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
657 original value of -1 will not work with bidi.)
658 (compute_display_string_pos): First arg is now struct
659 `text_pos *'; all callers changed. Support display properties on
660 Lisp strings.
661 (compute_display_string_end): Support display properties on Lisp
662 strings.
663 (init_iterator, reseat_1, reseat_to_string): Initialize the
664 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
665 when iterating on a string not from display properties).
640c8776
SM
666 (compute_display_string_pos, compute_display_string_end):
667 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
668 arrow keys.
669 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
670 base_level_stop; instead, set base_level_stop to BEGV.
671 Fixes crashes in vertical-motion.
0bb23927
EZ
672 (next_element_from_buffer): Improve commentary for when
673 the iterator is before prev_stop.
674 (init_iterator): Initialize bidi_p from the default value of
675 bidi-display-reordering, not from buffer-local value. Use the
676 buffer-local value only if initializing for buffer iteration.
677 (handle_invisible_prop): Support invisible properties on strings
678 that are being bidi-reordered.
679 (set_iterator_to_next): Support bidi reordering of C strings and
680 Lisp strings.
681 (next_element_from_string): Support bidi reordering of Lisp
682 strings.
683 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
684 (display_string): Support display of R2L glyph rows.
685 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
686 (init_iterator): Don't initialize it->bidi_p for strings
687 here.
688 (reseat_to_string): Initialize it->bidi_p for strings here.
689 (next_element_from_string, next_element_from_c_string)
690 (next_element_from_buffer): Add xassert's for correspondence
691 between IT's object being iterated and it->bidi_it.string
692 structure.
693 (face_before_or_after_it_pos): Support bidi iteration.
694 (next_element_from_c_string): Handle the case of the first string
695 character that is not the first one in the visual order.
696 (get_visually_first_element): New function, refactored from common
697 parts of next_element_from_buffer, next_element_from_string, and
698 next_element_from_c_string.
699 (tool_bar_lines_needed, redisplay_tool_bar)
700 (display_menu_bar): Force left-to-right direction. Add a FIXME
701 comment for making that be controlled by a user option.
702 (push_it, pop_it): Save and restore the state of the
703 bidi iterator. Save and restore the bidi_p flag.
704 (pop_it): Iterate out of display property for string iteration as
705 well.
706 (iterate_out_of_display_property): Support iteration over strings.
707 (handle_single_display_spec): Set up it->bidi_it for iteration
708 over a display string, and call bidi_init_it.
709 (handle_single_display_spec, next_overlay_string)
710 (get_overlay_strings_1, push_display_prop): Set up the bidi
711 iterator for displaying display or overlay strings.
712 (forward_to_next_line_start): Don't use the shortcut if
713 bidi-iterating.
714 (back_to_previous_visible_line_start): If handle_display_prop
715 pushed the iterator stack, restore the internal state of the bidi
716 iterator by calling bidi_pop_it same number of times.
717 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
718 and we are bidi-iterating, don't decrement the iterator position;
719 instead, set the first_elt flag in the bidi iterator, to produce
720 the same effect.
721 (reseat_1): Remove redundant setting of string_from_display_prop_p.
722 (push_display_prop): xassert that we are iterating a buffer.
723 (push_it, pop_it): Save and restore paragraph_embedding member.
724 (handle_single_display_spec, next_overlay_string)
725 (get_overlay_strings_1, reseat_1, reseat_to_string)
726 (push_display_prop): Set up the `unibyte' member of bidi_it.string
727 correctly. Don't assume unibyte strings are not bidi-reordered.
728 (compute_display_string_pos)
729 (compute_display_string_end): Fix handling the case of C string.
730 (push_it, pop_it): Save and restore from_disp_prop_p.
731 (handle_single_display_spec, push_display_prop): Set the
732 from_disp_prop_p flag.
733 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
734 (pop_it): Call iterate_out_of_display_property only if we are
735 popping after iteration over a string that came from a display
736 property. Fix a typo in popping stretch info. Add an assertion
737 for verifying that the iterator position is in sync with the bidi
738 iterator.
739 (handle_single_display_spec, get_overlay_strings_1)
740 (push_display_prop): Fix initialization of paragraph direction for
741 string when that of the parent object is not yet determined.
742 (reseat_1): Call bidi_init_it to resync the bidi
743 iterator with IT's position. (Bug#7616)
744 (find_row_edges): If ROW->start.pos gives position
745 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
746 (handle_stop, back_to_previous_visible_line_start, reseat_1):
747 Reset the from_disp_prop_p flag.
748 (SAVE_IT, RESTORE_IT): New macros.
749 (pos_visible_p, face_before_or_after_it_pos)
750 (back_to_previous_visible_line_start)
751 (move_it_in_display_line_to, move_it_in_display_line)
752 (move_it_to, move_it_vertically_backward, move_it_by_lines)
753 (try_scrolling, redisplay_window, display_line): Use them when
754 saving a temporary copy of the iterator and restoring it back.
755 (back_to_previous_visible_line_start, reseat_1)
756 (init_iterator): Empty the bidi cache "stack".
757 (move_it_in_display_line_to): If iterator ended up at
758 EOL, but we never saw any buffer positions smaller than
759 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
760 motion in bidi-reordered lines.
761 (move_it_in_display_line_to): Record prev_method and prev_pos
762 immediately before the call to set_iterator_to_next. Fixes cursor
763 motion in bidi-reordered lines with stretch glyphs and strings
764 displayed in margins. (Bug#8133) (Bug#8867)
765 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
766 TO_CHARPOS.
640c8776
SM
767 (pos_visible_p): Support positions in bidi-reordered lines.
768 Save and restore bidi cache.
0bb23927
EZ
769
770 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
771 (bidi_paragraph_info): Delete unused struct.
772 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
773 (bidi_cache_start): New variable.
774 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
775 to zero.
776 (bidi_cache_fetch_state, bidi_cache_search)
777 (bidi_cache_find_level_change, bidi_cache_iterator_state)
778 (bidi_cache_find, bidi_peek_at_next_level)
779 (bidi_level_of_next_char, bidi_find_other_level_edge)
780 (bidi_move_to_visually_next): Compare cache index with
781 bidi_cache_start rather than with zero.
782 (bidi_fetch_char): Accept new argument STRING; all callers
783 changed. Support iteration over a string. Support strings with
784 display properties. Support unibyte strings. Fix the type of
785 `len' according to what STRING_CHAR_AND_LENGTH expects.
786 (bidi_paragraph_init, bidi_resolve_explicit_1)
787 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
788 (bidi_level_of_next_char, bidi_move_to_visually_next):
789 Support iteration over a string.
0bb23927
EZ
790 (bidi_set_sor_type, bidi_resolve_explicit_1)
791 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
792 can now be zero (for strings); special values 0 and -1 were
793 changed to -1 and -2, respectively.
794 (bidi_char_at_pos): New function.
795 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
796 Call it instead of FETCH_MULTIBYTE_CHAR.
797 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
798 initialized to valid values.
799 (bidi_init_it): Don't initialize charpos and bytepos with invalid
800 values.
801 (bidi_level_of_next_char): Allow the sentinel "position" to pass
802 the test for valid cached positions. Fix the logic for looking up
803 the sentinel state in the cache. GCPRO the Lisp string we are
804 iterating.
805 (bidi_push_it, bidi_pop_it): New functions.
806 (bidi_initialize): Initialize the bidi cache start stack pointer.
807 (bidi_cache_ensure_space): New function, refactored from part of
808 bidi_cache_iterator_state. Don't assume the required size is just
809 one BIDI_CACHE_CHUNK away.
810 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
811 (bidi_count_bytes, bidi_char_at_pos): New functions.
812 (bidi_cache_search): Don't assume bidi_cache_last_idx is
813 always valid if bidi_cache_idx is valid.
814 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
815 is valid if it's going to be used.
816 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
817 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
818 (bidi_cache_find_level_change, bidi_cache_ensure_space)
819 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
820 (bidi_find_other_level_edge, bidi_cache_start_stack):
821 All variables related to cache indices are now EMACS_INT.
c965adc5 822
0bb23927
EZ
823 * dispextern.h (struct bidi_string_data): New structure.
824 (struct bidi_it): New member `string'. Make flag members be 1-bit
825 fields, and put them last in the struct.
640c8776
SM
826 (compute_display_string_pos, compute_display_string_end):
827 Update prototypes.
0bb23927
EZ
828 (bidi_push_it, bidi_pop_it): Add prototypes.
829 (struct iterator_stack_entry): New members bidi_p,
830 paragraph_embedding, and from_disp_prop_p.
831 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
832 (bidi_shelve_cache, bidi_unshelve_cache):
833 Declare prototypes.
0bb23927
EZ
834
835 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
836 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
837 and vector-like objects.
838
839 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
840 cache around display iteration.
841
842 * window.c (Fwindow_end, window_scroll_pixel_based)
843 (displayed_window_lines, Frecenter): Save and restore the bidi
844 cache around display iteration.
845
3bbd2265
LMI
8462011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
847
848 * editfns.c (Fdelete_region): Clarify the use of the named
849 parameters (bug#6788).
850
adc47434
MR
8512011-07-14 Martin Rudalics <rudalics@gmx.at>
852
853 * indent.c (Fvertical_motion): Set and restore w->pointm when
854 saving and restoring the window's buffer (Bug#9006).
855
837c31f8
LMI
8562011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
857
858 * editfns.c (Fstring_to_char): Clarify just what is returned
859 (bug#6576). Text by Eli Zaretskii.
860
ac389d0c
JB
8612011-07-13 Juanma Barranquero <lekktu@gmail.com>
862
863 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
864
0be0ce47
EZ
8652011-07-13 Eli Zaretskii <eliz@gnu.org>
866
867 * buffer.c (mmap_find): Fix a typo.
868
cd18e7e3
JB
8692011-07-13 Johan Bockgård <bojohan@gnu.org>
870
871 Fix execution of x selection hooks.
872 * xselect.c (Qx_lost_selection_functions)
873 (Qx_sent_selection_functions): New vars.
874 (syms_of_xselect): DEFSYM them.
875 (x_handle_selection_request): Pass Qx_sent_selection_functions
876 rather than Vx_sent_selection_functions to Frun_hook_with_args.
877 (x_handle_selection_clear,x_clear_frame_selections):
878 Pass Qx_lost_selection_functions rather than
879 Vx_lost_selection_functions to Frun_hook_with_args.
880
47ea7f44
PE
8812011-07-13 Paul Eggert <eggert@cs.ucla.edu>
882
ac389d0c 883 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
884 The old code sometimes used this field without initializing it.
885
47ea7f44
PE
886 * alloc.c (gc_sweep): Don't read past end of array.
887 In theory, the old code could also have corrupted Emacs internals,
888 though it'd be very unlikely.
889
bc985c87
AS
8902011-07-12 Andreas Schwab <schwab@linux-m68k.org>
891
892 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 893 argument. (Bug#4026)
bc985c87 894
0cf34688
LMI
8952011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
896
b3dadd76
LMI
897 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
898 key" (bug#4257).
899
0cf34688
LMI
900 * window.c (Fset_window_start): Doc fix (bug#4199).
901 (Fset_window_hscroll): Ditto.
902
270768cd
PE
9032011-07-12 Paul Eggert <eggert@cs.ucla.edu>
904
077e3dda 905 Fix minor new problems caught by GCC 4.6.1.
270768cd 906 * term.c (init_tty): Remove unused local.
490011a6 907 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 908 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 909 not used otherwise.
270768cd 910
b1f58454
CY
9112011-07-12 Chong Yidong <cyd@stupidchicken.com>
912
913 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
914
22b9578d
LMI
9152011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
916
6e70ab07
LMI
917 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
918 are the mini-buffer and the echo area (bug#3320).
919
22b9578d
LMI
920 * term.c (init_tty): Remove support for supdup, c10 and perq
921 terminals, which are no longer supported (bug#1482).
922
8974cc9f
JB
9232011-07-10 Johan Bockgård <bojohan@gnu.org>
924
925 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
926
a560d974
JD
9272011-07-10 Jan Djärv <jan.h.d@swipnet.se>
928
929 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
930 for non-popups (Bug#3642).
931
1dae0f0a
AS
9322011-07-10 Andreas Schwab <schwab@linux-m68k.org>
933
268c2c36 934 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 935 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
936 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
937 * cm.c (losecursor): Likewise.
1dae0f0a
AS
938 * data.c (fmod): Likewise.
939 * dispnew.c (swap_glyphs_in_rows): Likewise.
940 * emacs.c (memory_warning_signal): Likewise.
941 * floatfns.c (float_error): Likewise.
942 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
943 (otf_open, font_otf_capability, generate_otf_features)
944 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
945 Likewise.
946 * image.c (pbm_read_file): Likewise.
947 * indent.c (string_display_width): Likewise.
948 * intervals.c (check_for_interval, search_for_interval)
949 (inc_interval_count, count_intervals, root_interval)
950 (adjust_intervals_for_insertion, make_new_interval): Likewise.
951 * lread.c (defalias): Likewise.
268c2c36 952 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
953 * regex.c (set_image_of_range_1, set_image_of_range)
954 (regex_grow_registers): Likewise.
955 * sysdep.c (strerror): Likewise.
956 * termcap.c (valid_filename_p, tprint, main): Likewise.
957 * tparam.c (main): Likewise.
958 * unexhp9k800.c (run_time_remap, save_data_space)
959 (update_file_ptrs, read_header, write_header, calculate_checksum)
960 (copy_file, copy_rest, display_header): Likewise.
961 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
962 Likewise.
963 * xdisp.c (check_it): Likewise.
964 * xfaces.c (register_color, unregister_color, unregister_colors):
965 Likewise.
966 * xfns.c (print_fontset_result): Likewise.
967 * xrdb.c (member, fatal, main): Likewise.
968
99033785
PE
9692011-07-10 Paul Eggert <eggert@cs.ucla.edu>
970
971 Fix minor problems found by static checking (Bug#9031).
972 * chartab.c (char_table_set_range, map_sub_char_table):
973 Remove unused locals.
974 (uniprop_table): Now static.
975 * composite.c (_work_char): Remove unused static var.
976
9cb2ac56
JB
9772011-07-09 Juanma Barranquero <lekktu@gmail.com>
978
979 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
980
f25661f0
JD
9812011-07-09 Jan Djärv <jan.h.d@swipnet.se>
982
983 * gtkutil.c (qttip_cb): Remove code without function.
984
8278c4fe
EZ
9852011-07-09 Eli Zaretskii <eliz@gnu.org>
986
987 * w32.c (pthread_sigmask): New stub.
988
1692ae2d 9892011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 990
8a6ebd58 991 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
992 sigprocmask is portable only for single-threaded applications, and
993 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
994 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
995 (LIBES): Use it.
996 * callproc.c (Fcall_process):
997 * process.c (create_process):
998 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
999 Use pthread_sigmask, not sigprocmask.
123403e4 1000
1b854618
JD
10012011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1002
1003 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
1004 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
1005 wrong (Bug#8591).
1006
3fe4b549
JD
10072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1008
0ce7e563
JD
1009 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
1010 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
1011 (xg_hide_tooltip): Fix comment.
1012
3fe4b549
JD
1013 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
1014 in registerServicesMenuSendTypes.
1015 (validRequestorForSendType): Don't check ns_return_types.
1016
1017 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
1018 ns_return_type.
1019
5df75e47
JR
10202011-07-08 Jason Rumney <jasonr@gnu.org>
1021
1022 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
1023 frame struct members of non-existent frames (Bug#6284).
1024
699c10bd
JD
10252011-07-08 Jan Djärv <jan.h.d@swipnet.se>
1026
4393663b
JD
1027 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
1028 variable firstTime not needed on OSX >= 10.6.
1029 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
1030 >= 10.5. Use setKnobProportion, setDoubleValue.
1031
1032 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
1033 (MAC_OS_X_VERSION_10_5): Define if not defined.
1034 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
1035 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
1036 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
1037
1038 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
1039 cString and lossyCString on OSX >= 10.4
1040
1041 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
1042 sizeToFit on OSX >= 10.2.
1043
1044 * nsimage.m (allocInitFromFile): Don't use deprecated method
1045 bestRepresentationForDevice on OSX >= 10.6.
1046
1047 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
1048 to avoid warning.
1049
1050 * emacs.c: Declare unexec_init_emacs_zone.
1051
a63e0781
JD
1052 * nsgui.h: Fix compiler warning about gnulib redefining verify.
1053
699c10bd
JD
1054 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
1055
1056 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
1057 on svcsMenu (Bug#8842).
1058
1059 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
1060 ns_return_types.
1061 (Fns_list_services): Just return Qnil on 10.6, code not working there.
1062
1063 * nsterm.m (QUTF8_STRING): Declare.
1064 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
1065 (validRequestorForSendType): Return type is (id).
1066 Change indexOfObjectIdenticalTo to indexOfObject.
1067 Check if we have local selection before returning self (Bug#8842).
1068 (writeSelectionToPasteboard): Put local selection into paste board
1069 if we have a local selection (Bug#8842).
1070 (syms_of_nsterm): DEFSYM QUTF8_STRING.
1071
1072 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
1073 (ns_get_local_selection): Declare.
1074
54e10184
LMI
10752011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
1076
9888ff71
LMI
1077 * keymap.c (describe_map_tree): Don't insert a double newline at
1078 the end of the buffer (bug#1169) and return whether we inserted
1079 something.
1080
54e10184
LMI
1081 * callint.c (Fcall_interactively): Change "reading args" to
1082 "providing args" to try to clarify what it does (bug#1010).
1083
15fa4783
KH
10842011-07-07 Kenichi Handa <handa@m17n.org>
1085
1086 * composite.c (composition_compute_stop_pos): Ignore a static
1087 composition starting before CHARPOS (Bug#8915).
1088
1089 * xdisp.c (handle_composition_prop): Likewise.
1090
a8815b00
EZ
10912011-07-07 Eli Zaretskii <eliz@gnu.org>
1092
1093 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
1094 (Bug#9015)
1095
ef7b981d 10962011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
1097
1098 * character.h (unicode_category_t): New enum type.
1099
1100 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
1101 (Qchar_code_property_table): New variable.
1102 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
1103 (UNIPROP_COMPRESSED_FORM_P): New macros.
1104 (char_table_ascii): Uncompress the compressed values.
1105 (sub_char_table_ref): New arg is_uniprop. Callers changed.
1106 Uncompress the compressed values.
ac389d0c 1107 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
1108 (char_table_ref_and_range): Uncompress the compressed values.
1109 (sub_char_table_set): New arg is_uniprop. Callers changed.
1110 Uncompress the compressed values.
1111 (sub_char_table_set_range): Args changed. Callers changed.
1112 (char_table_set_range): Adjuted for the above change.
1113 (map_sub_char_table): Delete args default_val and parent. Add arg
1114 top. Give decoded values to a Lisp function.
640c8776 1115 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
1116 values to a Lisp function. Gcpro more variables.
1117 (uniprop_table_uncompress)
1118 (uniprop_decode_value_run_length): New functions.
1119 (uniprop_decoder, uniprop_decoder_count): New variables.
1120 (uniprop_get_decoder, uniprop_encode_value_character)
1121 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
1122 New functions.
1123 (uniprop_encoder, uniprop_encoder_count): New variables.
1124 (uniprop_get_encoder, uniprop_table)
1125 (Funicode_property_table_internal, Fget_unicode_property_internal)
1126 (Fput_unicode_property_internal): New functions.
1127 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
1128 Sunicode_property_table_internal, Sget_unicode_property_internal,
1129 and Sput_unicode_property_internal. Defvar_lisp
1130 char-code-property-alist.
1131
640c8776 1132 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
1133 Vunicode_category_table.
1134
640c8776 1135 * font.c (font_range): Adjust for the change of
c805dec0
KH
1136 Vunicode_category_table.
1137
76b397fb
DN
11382011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
1139
1140 * m/iris4d.h: Remove file, move contents ...
1141 * s/irix6-5.h: ... here.
1142
22b4128e
PE
11432011-07-06 Paul Eggert <eggert@cs.ucla.edu>
1144
1145 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
1146 * alloc.c (mark_buffer):
1147 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
1148 (clone_per_buffer_values): Don't assume that
22b4128e
PE
1149 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
1150 This isn't true in general, and it's particularly not true
1151 if Emacs is configured with --with-wide-int.
1152 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
1153 New macros, used in the buffer.c change.
1154
869795d6
JD
11552011-07-05 Jan Djärv <jan.h.d@swipnet.se>
1156
1157 * xsettings.c: Use both GConf and GSettings if both are available.
1158 (store_config_changed_event): Add comment.
1159 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
1160 (store_tool_bar_style_changed): New functions.
1161 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
1162 (struct xsettings): Move font inside HAVE_XFT.
1163 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 1164 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 1165 Move inside HAVE_XFT.
640c8776 1166 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
1167 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
1168 also.
1169 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
640c8776
SM
1170 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
1171 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
1172 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
1173 (parse_settings): Move check for font inside HAVE_XFT.
1174 (read_settings, apply_xft_settings): Add comment.
1175 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
1176 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
1177 call store_font_name_changed.
1178 (xft_settings_event): Add comment.
1179 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
1180 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
1181 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
1182 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
1183 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
1184 (xsettings_get_system_font, xsettings_get_system_normal_font):
1185 Add comment.
869795d6 1186
d8ed26bd
PE
11872011-07-05 Paul Eggert <eggert@cs.ucla.edu>
1188
1189 Random fixes. E.g., (random) never returned negative values.
1190 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
1191 subseconds part to the entropy, as that's a bit more random.
1192 Prefer signed to unsigned, since the signedness doesn't matter and
1193 in general we prefer signed. When given a limit, use a
1194 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
1195 latter isn't right if USE_2_TAGS_FOR_INTS.
1196 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
1197 not 0..VALMASK. Don't discard "excess" bits that random () returns.
1198
cabf1cac
SM
11992011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1200
1201 * textprop.c (text_property_stickiness):
1202 Obey Vtext_property_default_nonsticky.
1203 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
1204 * w32fns.c (syms_of_w32fns):
1205 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
1206
6e9b2be9
PE
12072011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1208
1209 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
1210 This is more efficient than Ffile_directory_p and avoids a minor race.
1211
90186c68
LMI
12122011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
1213
7c301272
LMI
1214 * buffer.c (Foverlay_put): Say what the return value is
1215 (bug#7835).
1216
c4f2d8d4
LMI
1217 * fileio.c (barf_or_query_if_file_exists): Check first if the file
1218 is a directory before asking whether to use the file name
1219 (bug#7564).
ad637907
LMI
1220 (barf_or_query_if_file_exists): Make the "File is a directory"
1221 error be more correct.
c4f2d8d4 1222
90186c68
LMI
1223 * fns.c (Frequire): Remove the mention of the .gz files, since
1224 that's installation-specific, but keep the mention of
1225 `get-load-suffixes'.
1226
da64016e
PE
12272011-07-04 Paul Eggert <eggert@cs.ucla.edu>
1228
1229 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
1230 Report string overflow if the output is too long.
1231
7d47b580
JB
12322011-07-04 Juanma Barranquero <lekktu@gmail.com>
1233
a555cb87
JB
1234 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
1235 (syms_of_gnutls): Remove duplicate DEFSYM for
1236 Qgnutls_bootprop_verify_hostname_error, an error for
1237 Qgnutls_bootprop_verify_error (which is no longer used).
1238
7d47b580
JB
1239 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
1240 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
1241 Also (re)move comments that are misplaced or no longer relevant.
1242
1e49bfab
LMI
12432011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1244
1245 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
1246
1485f4c0
CY
12472011-07-03 Chong Yidong <cyd@stupidchicken.com>
1248
1249 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
1250 and background color parameters if they have been changed.
1251
a9ab721e
LMI
12522011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
1253
1254 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
1255
cf7cff57
PE
12562011-07-03 Paul Eggert <eggert@cs.ucla.edu>
1257
2e13213d
PE
1258 * xsettings.c (SYSTEM_FONT): Define only when used.
1259 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
1260
cf7cff57
PE
1261 * keymap.c (access_keymap_1): Now static.
1262
7a8e04f7
CY
12632011-07-02 Chong Yidong <cyd@stupidchicken.com>
1264
1265 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
1266 leave any prefix arg for the up event (Bug#1586).
1267
61352f62
LMI
12682011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
1269
69bb1ef7
LMI
1270 * lread.c (syms_of_lread): Mention single symbols defined by
1271 `defvar' or `defconst' (bug#7154).
1272
61352f62 1273 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 1274 (Frequire): Mention get-load-suffixes.
61352f62 1275
28545e04
MR
12762011-07-02 Martin Rudalics <rudalics@gmx.at>
1277
1278 * window.h (window): Remove clone_number slot.
1279 * window.c (Fwindow_clone_number, Fset_window_clone_number):
1280 Remove.
1281 (make_parent_window, make_window, saved_window)
1282 (Fset_window_configuration, save_window_save): Don't deal with
1283 clone numbers.
1284 * buffer.c (Qclone_number): Remove declaration.
1285 (sort_overlays, overlay_strings): Don't deal with clone numbers.
1286
3349e122
SM
12872011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
1288
1289 Add multiple inheritance to keymaps.
1290 * keymap.c (Fmake_composed_keymap): New function.
1291 (Fset_keymap_parent): Simplify.
1292 (fix_submap_inheritance): Remove.
1293 (access_keymap_1): New function extracted from access_keymap to handle
1294 embedded parents and handle lists of maps.
1295 (access_keymap): Use it.
1296 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
1297 (Fcopy_keymap): Handle embedded parents.
1298 (Fcommand_remapping, define_as_prefix): Simplify.
1299 (Fkey_binding): Simplify.
1300 (syms_of_keymap): Move minibuffer-local-completion-map,
1301 minibuffer-local-filename-completion-map,
1302 minibuffer-local-must-match-map, and
1303 minibuffer-local-filename-must-match-map to Elisp.
1304 (syms_of_keymap): Defsubr make-composed-keymap.
1305 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
1306 (parse_menu_item): Trivial simplification.
1307
3279eb87
GM
13082011-07-01 Glenn Morris <rgm@gnu.org>
1309
1310 * Makefile.in (SETTINGS_LIBS): Fix typo.
1311
4550efdf
KI
13122011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
1313
1314 * coding.c (Fencode_coding_string): Record the last coding system
1315 used, as the function doc string says (bug#8738).
1316
0949d2b6
JD
13172011-07-01 Jan Djärv <jan.h.d@swipnet.se>
1318
1319 * xsettings.c (store_monospaced_changed): Take new font as arg and
1320 check for change against current_mono_font.
1321 (EMACS_TYPE_SETTINGS): Remove this and related defines.
1322 (emacs_settings_constructor, emacs_settings_get_property)
1323 (emacs_settings_set_property, emacs_settings_class_init)
1324 (emacs_settings_init, gsettings_obj): Remove.
1325 (something_changedCB): New function for HAVE_GSETTINGS.
1326 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
1327 with value as argument.
1328 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
1329 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 1330 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
1331 "changed".
1332
1333 * xgselect.c: Add defined (HAVE_GSETTINGS).
1334 (xgselect_initialize): Ditto.
1335
1336 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
1337 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
1338 xg_select.
1339
bbc6b304
PE
13402011-07-01 Paul Eggert <eggert@cs.ucla.edu>
1341
1342 * eval.c (struct backtrace): Simplify and port the data structure.
1343 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
1344 signed bit field, as this assumption is not portable and it makes
1345 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
1346 "char debug_on_exit : 1" as this is not portable either; instead,
1347 use the portable "unsigned int debug_on_exit : 1". Remove unused
1348 member evalargs. Remove obsolete comments about cc bombing out.
1349
9851bfc5
JD
13502011-06-30 Jan Djärv <jan.h.d@swipnet.se>
1351
51bb811f 1352 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
1353 Let HAVE_GSETTINGS override HAVE_GCONF.
1354 (store_monospaced_changed): New function.
1355 (EMACS_SETTINGS): A new type derived from GObject to handle
1356 GSettings notifications.
1357 (emacs_settings_constructor, emacs_settings_get_property)
1358 (emacs_settings_set_property, emacs_settings_class_init):
1359 New functions.
1360 (gsettings_client, gsettings_obj): New variables.
1361 (GSETTINGS_SCHEMA): New define.
1362 (something_changedCB): Call store_monospaced_changed.
1363 (init_gsettings): New function.
1364 (xsettings_initialize): Call init_gsettings.
1365 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
1366 to NULL.
1367
640c8776 1368 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
1369 GCONF_CFLAGS/LIBS.
1370
5386012d
MR
13712011-06-29 Martin Rudalics <rudalics@gmx.at>
1372
1373 * window.c (resize_root_window, grow_mini_window)
1374 (shrink_mini_window): Rename Qresize_root_window to
1375 Qwindow_resize_root_window and Qresize_root_window_vertically to
1376 Qwindow_resize_root_window_vertically.
1377
f13e0b08
PE
13782011-06-28 Paul Eggert <eggert@cs.ucla.edu>
1379
1380 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
1381
94515237
JB
13822011-06-27 Juanma Barranquero <lekktu@gmail.com>
1383
1384 * makefile.w32-in: Redesign dependencies so they reflect more
1385 clearly which files are directly included by each source file,
1386 and not through other includes.
1387
e43b6e43
MR
13882011-06-27 Martin Rudalics <rudalics@gmx.at>
1389
1390 * buffer.c (Qclone_number): Declare static and DEFSYM it.
1391 (sort_overlays, overlay_strings): When an overlay's clone number
1392 matches the window's clone number process the overlay even if
1393 the overlay's window property doesn't match the current window.
1394
d68443dc
MR
1395 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
1396 (Fwindow_hchild): Rename to Fwindow_left_child.
1397 (Fwindow_next): Rename to Fwindow_next_sibling.
1398 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
1399 (resize_window_check): Rename to window_resize_check.
1400 (resize_window_apply): Rename to window_resize_apply.
1401 (Fresize_window_apply): Rename to Fwindow_resize_apply.
1402 (Fdelete_other_windows_internal, resize_frame_windows)
1403 (Fsplit_window_internal, Fdelete_window_internal)
1404 (grow_mini_window, shrink_mini_window)
1405 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 1406
c7e73be5
JD
14072011-06-26 Jan Djärv <jan.h.d@swipnet.se>
1408
1409 * emacsgtkfixed.h: State that this is only used with Gtk+3.
1410 (emacs_fixed_set_min_size): Remove.
1411 (emacs_fixed_new): Take frame as argument.
1412
1413 * emacsgtkfixed.c: State that this is only used with Gtk+3.
1414 (_EmacsFixedPrivate): Remove minwidth/height.
1415 Add struct frame *f.
1416 (emacs_fixed_init): Initialize priv->f.
1417 (get_parent_class, emacs_fixed_set_min_size): Remove.
1418 (emacs_fixed_new): Set priv->f to argument.
1419 (emacs_fixed_get_preferred_width)
1420 (emacs_fixed_get_preferred_height): Use min_width/height from
1421 frames size_hint to set minimum and natural (Bug#8919).
1422 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
1423 and use min_width/height from frames size_hint to set
1424 min_width/height (Bug#8919).
1425
1426 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
1427 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
1428 Fix indentation.
c7e73be5 1429
cf99dcf8
EZ
14302011-06-26 Eli Zaretskii <eliz@gnu.org>
1431
1432 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
1433 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
1434 called at ZV.
1435
029529ac
CY
14362011-06-26 Chong Yidong <cyd@stupidchicken.com>
1437
1438 * process.c (wait_reading_process_output): Bypass select if
1439 waiting for a cell while ignoring keyboard input, and input is
1440 pending. Suggested by Jan Djärv (Bug#8869).
1441
7a7ef429
PE
14422011-06-25 Paul Eggert <eggert@cs.ucla.edu>
1443
1444 Use gnulib's dup2 module instead of rolling our own.
1445 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
1446
11fdef7d 14472011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
1448
1449 * dispnew.c (scrolling_window): Before scrolling, turn off a
1450 mouse-highlight in the window being scrolled.
1451
cd3520a4
JB
14522011-06-24 Juanma Barranquero <lekktu@gmail.com>
1453
1454 Move DEFSYM to lisp.h and use everywhere.
1455
1456 * character.h (DEFSYM): Move declaration...
1457 * lisp.h (DEFSYM): ...here.
1458
1459 * gnutls.c:
1460 * minibuf.c:
1461 * w32menu.c:
1462 * w32proc.c:
1463 * w32select.c: Don't include character.h.
1464
1465 * alloc.c (syms_of_alloc):
1466 * buffer.c (syms_of_buffer):
1467 * bytecode.c (syms_of_bytecode):
1468 * callint.c (syms_of_callint):
1469 * casefiddle.c (syms_of_casefiddle):
1470 * casetab.c (init_casetab_once):
1471 * category.c (init_category_once, syms_of_category):
1472 * ccl.c (syms_of_ccl):
1473 * cmds.c (syms_of_cmds):
1474 * composite.c (syms_of_composite):
1475 * dbusbind.c (syms_of_dbusbind):
1476 * dired.c (syms_of_dired):
1477 * dispnew.c (syms_of_display):
1478 * doc.c (syms_of_doc):
1479 * editfns.c (syms_of_editfns):
1480 * emacs.c (syms_of_emacs):
1481 * eval.c (syms_of_eval):
1482 * fileio.c (syms_of_fileio):
1483 * fns.c (syms_of_fns):
1484 * frame.c (syms_of_frame):
1485 * fringe.c (syms_of_fringe):
1486 * insdel.c (syms_of_insdel):
1487 * keymap.c (syms_of_keymap):
1488 * lread.c (init_obarray, syms_of_lread):
1489 * macros.c (syms_of_macros):
1490 * msdos.c (syms_of_msdos):
1491 * print.c (syms_of_print):
1492 * process.c (syms_of_process):
1493 * search.c (syms_of_search):
1494 * sound.c (syms_of_sound):
1495 * syntax.c (init_syntax_once, syms_of_syntax):
1496 * terminal.c (syms_of_terminal):
1497 * textprop.c (syms_of_textprop):
1498 * undo.c (syms_of_undo):
1499 * w32.c (globals_of_w32):
1500 * window.c (syms_of_window):
1501 * xdisp.c (syms_of_xdisp):
1502 * xfaces.c (syms_of_xfaces):
1503 * xfns.c (syms_of_xfns):
1504 * xmenu.c (syms_of_xmenu):
1505 * xsettings.c (syms_of_xsettings):
1506 * xterm.c (syms_of_xterm): Use DEFSYM.
1507
4228cf16
TZ
15082011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
1509
cd3520a4 1510 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 1511
7fcccf1e
PE
15122011-06-23 Paul Eggert <eggert@cs.ucla.edu>
1513
7efb4e0e
PE
1514 Integer and buffer overflow fixes (Bug#8873).
1515
ff5844ad
PE
1516 * print.c (printchar, strout): Check for string overflow.
1517 (PRINTPREPARE, printchar, strout):
1518 Don't set size unless allocation succeeds.
1519
90532f02
PE
1520 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
1521 for sizes. Check for string overflow more accurately.
1522 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
1523
6d84508d
PE
1524 * macros.c: Integer and buffer overflow fixes.
1525 * keyboard.h (struct keyboard.kbd_macro_bufsize):
1526 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
1527 Use ptrdiff_t, not int, for sizes.
1528 Don't increment bufsize until after realloc succeeds.
1529 Check for size-calculation overflow.
1530 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
1531
437b2cb4
PE
1532 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
1533
8b9ac8b4
PE
1534 * lread.c: Integer overflow fixes.
1535 (read_integer): Radix is now EMACS_INT, not int,
1536 to improve quality of diagnostics for out-of-range radices.
1537 Calculate buffer size correctly for out-of-range radices.
1538 (read1): Check for integer overflow in radices, and in
1539 read-circle numbers.
82cb60d3
PE
1540 (read_escape): Avoid int overflow.
1541 (Fload, openp, read_buffer_size, read1)
1542 (substitute_object_recurse, read_vector, read_list, map_obarray):
1543 Use ptrdiff_t, not int, for sizes.
1544 (read1): Use EMACS_INT, not int, for sizes.
20270765 1545 Check for size overflow.
8b9ac8b4 1546
7fcccf1e
PE
1547 * image.c (cache_image): Check for size arithmetic overflow.
1548
bfbbd7e7
PE
1549 * lread.c: Integer overflow issues.
1550 (saved_doc_string_size, saved_doc_string_length)
1551 (prev_saved_doc_string_size, prev_saved_doc_string_length):
1552 Now ptrdiff_t, not int.
1553 (read1): Don't assume doc string length fits in int. Check for
1554 out-of-range doc string lengths.
1555 (read_list): Don't assume file position fits in int.
39019e54 1556 (read_escape): Check for hex character overflow.
bfbbd7e7 1557
4e323265
LL
15582011-06-22 Leo Liu <sdl.web@gmail.com>
1559
1560 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
1561 Move to minibuffer.el.
1562
85fece3e
PE
15632011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1564
20b84ce9 1565 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
1566 The following patches are for when GLYPH_DEBUG && !XASSERT.
1567 * dispextern.h (trace_redisplay_p, dump_glyph_string):
1568 * dispnew.c (flush_stdout):
1569 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
1570 Mark as externally visible.
1571 * dispnew.c (check_window_matrix_pointers): Now static.
1572 * dispnew.c (window_to_frame_vpos):
1573 * xfns.c (unwind_create_frame):
1574 * xterm.c (x_check_font): Remove unused local.
1575 * scroll.c (CHECK_BOUNDS):
1576 * xfaces.c (cache_fache): Rename local to avoid shadowing.
1577 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
1578 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
1579 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
1580 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
1581 Now static.
1582 (debug_method_add): Use va_list and vsprintf rather than relying
1583 on undefined behavior with wrong number of arguments.
1584 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
1585 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
1586 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
1587 since we're not interested in debugging glyphs with old libraries.
1588 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
1589 GCC 4.6.0's static checking.
1590
0766b489
PE
15912011-06-22 Paul Eggert <eggert@cs.ucla.edu>
1592
31fd4b32
PE
1593 Integer overflow and signedness fixes (Bug#8873).
1594 A few related buffer overrun fixes, too.
1595
b79e8648
PE
1596 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
1597
0766b489
PE
1598 * dispextern.h (struct face.stipple):
1599 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
1600 (x_bitmap_mask, x_allocate_bitmap_record)
1601 (x_create_bitmap_from_data, x_create_bitmap_from_file)
1602 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
1603 (x_create_bitmap_from_xpm_data):
1604 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
1605 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
1606 (.bitmaps_last):
1607 * xfaces.c (load_pixmap):
1608 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
1609 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
1610 (.bitmaps_last, struct x_output.icon_bitmap):
1611 Use ptrdiff_t, not int, for bitmap indexes.
1612 (x_allocate_bitmap_record): Check for size overflow.
1613 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
1614
b081724f
PE
1615 Use ptrdiff_t, not int, for overlay counts.
1616 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
1617 * editfns.c (overlays_around, get_pos_property):
1618 * textprop.c (get_char_property_and_overlay):
1619 * xdisp.c (next_overlay_change, note_mouse_highlight):
1620 * xfaces.c (face_at_buffer_position):
21514da7
PE
1621 * buffer.c (OVERLAY_COUNT_MAX): New macro.
1622 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
1623 (Fnext_overlay_change, Fprevious_overlay_change)
1624 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 1625 Use ptrdiff_t, not int, for sizes.
21514da7 1626 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 1627
3de73e5e
PE
1628 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
1629
2606c57b
PE
1630 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
1631 (x_session_initialize): Do not assume string length fits in int.
1632
aaafe47a
PE
1633 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
1634 This is unlikely, but can occur if DPI is outlandish.
1635
2674ddc8 1636 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
1637 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
1638
28154962
PE
1639 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
1640 * xrdb.c (magic_file_p, search_magic_path):
1641 Omit last arg SUFFIX; it was always 0. All callers changed.
1642 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
1643
7de51af5
PE
1644 * xfont.c (xfont_match): Avoid need for strlen.
1645
25ed6cc3
PE
1646 * xfns.c: Don't assume strlen fits in int.
1647 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
1648
4eab31dd
PE
1649 * xdisp.c (message_log_check_duplicate): Return intmax_t,
1650 not unsigned long, as we prefer signed integers. All callers changed.
1651 Detect integer overflow in repeat count.
1652 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 1653 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 1654
171e2a58
PE
1655 * termcap.c: Don't assume sizes fit in int and never overflow.
1656 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
1657 (gobble_line): Check for size-calculation overflow.
1658
ad39faca 1659 * minibuf.c (Fread_buffer):
6e5bb2dc 1660 * lread.c (intern, intern_c_string):
74ca2eb3
PE
1661 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
1662 Don't assume string length fits in int.
1663
52c61c22 1664 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
1665 * gtkutil.c (style_changed_cb): Avoid need for strlen.
1666
b5b8c9e5
PE
1667 * font.c: Don't assume string length fits in int.
1668 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
1669 Use ptrdiff_t, not int.
ccd6111c
PE
1670 (font_intern_prop): Don't assume string length fits in int.
1671 Don't assume integer property fits in fixnum.
1672 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 1673
882f0d81 1674 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 1675 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
1676 Reformulate so as not to need the command string.
1677 Invoke gzip -cd rather than gunzip, as it's more portable.
1678 (lock_info_type, lock_file_1, lock_file):
1679 Don't assume pid_t and time_t fit in unsigned long.
1680 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
1681 (current_lock_owner): Prefer signed type for sizes.
1682 Use memcpy, not strncpy, where memcpy is what is really wanted.
1683 Don't assume (via atoi) that time_t and pid_t fit in int.
1684 Check for time_t and/or pid_t out of range, e.g., via a network share.
1685 Don't alloca where an auto var works fine.
1686
93f4cf88
PE
1687 * fileio.c: Fix some integer overflow issues.
1688 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
1689 Don't assume string length fits in int.
1690 (directory_file_name): Don't assume string length fits in long.
1691 (make_temp_name): Don't assume pid fits in int, or that its print
1692 length is less than 20.
1693
f3e92b69
PE
1694 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
1695
1bfdaf10
PE
1696 * coding.c (make_subsidiaries): Don't assume string length fits in int.
1697
35016e9a
PE
1698 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
1699
3d1e65a1
PE
1700 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
1701 We prefer signed integers, even for size calculations.
1702
0b963a93
PE
1703 * emacs.c: Don't assume string length fits in 'int'.
1704 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
1705 (main): Don't invoke strlen when not needed.
1706
573f4b54
PE
1707 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
1708 (XD_DEBUG_MESSAGE): Don't waste a byte.
1709
989f33ba
PE
1710 * callproc.c (getenv_internal_1, getenv_internal)
1711 (Fgetenv_internal):
965d34eb
PE
1712 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
1713
e4d29b33
PE
1714 * lread.c (invalid_syntax): Omit length argument.
1715 All uses changed. This doesn't fix a bug, but it simplifies the
1716 code away from its former Hollerith-constant appearance, and it's
1717 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 1718 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 1719
eb49b136
PE
1720 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
1721 This didn't break anything, but it didn't help either.
1722 It's confusing to put a bogus integer in a place where the actual
1723 value does not matter.
9f62aeb1 1724 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 1725 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 1726
15375a22
PE
1727 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
1728 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
1729 implementation.
b61cc01c
PE
1730 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
1731 We prefer signed types, and the value cannot exceed the EMACS_INT
1732 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
1733 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
1734 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
1735 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 1736
53b2623d
PE
1737 * indent.c (sane_tab_width): New function.
1738 (current_column, scan_for_column, Findent_to, position_indentation)
1739 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 1740 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 1741
51cab52b 1742 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 1743
f2ed8a70
PE
1744 * lisp.h (lint_assume): New macro.
1745 * composite.c (composition_gstring_put_cache):
1746 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
1747
abe80cc6
PE
1748 * editfns.c, insdel.c:
1749 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 1750
b02c740e
PE
1751 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
1752
ebc96716
PE
1753 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
1754
b4e50fa0 1755 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 1756 Use much-faster test for byte-length change.
311d5d7c 1757 Don't assume string byte-length fits in 'int'.
a4cf38e4 1758 Check that character arg fits in 'int'.
85461888 1759 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 1760
c0c1ee9f
PE
1761 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
1762
a498d7f4
PE
1763 * fns.c (concat): Catch string overflow earlier.
1764 Do not rely on integer wraparound.
1765
51cab52b
PE
1766 * dispextern.h (struct it.overlay_strings_charpos)
1767 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
1768 * xdisp.c (forward_to_next_line_start)
1769 (back_to_previous_visible_line_start)
1770 (reseat_at_next_visible_line_start, next_element_from_buffer):
1771 Don't arbitrarily truncate the value of 'selective' to int.
1772
76031fad
PE
1773 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
1774
5eb55db9
PE
1775 * composite.c: Don't truncate sizes to 'int'.
1776 (composition_gstring_p, composition_reseat_it)
1777 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
1778 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
1779 not EMACS_UINT, for indexes.
5eb55db9 1780
0703a717
PE
1781 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
1782
d6202519
PE
1783 * buffer.c: Include <verify.h>.
1784 (struct sortvec.priority, struct sortstr.priority):
8961a454 1785 Now EMACS_INT, not int.
c20998a7 1786 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
1787 (struct sortstr.size, record_overlay_string)
1788 (struct sortstrlist.size, struct sortlist.used):
1789 Don't truncate size to int.
1790 (record_overlay_string): Check for size-calculation overflow.
d6202519 1791 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 1792
d5a19415
JM
17932011-06-22 Jim Meyering <meyering@redhat.com>
1794
029529ac 1795 Don't leak an XBM-image-sized buffer
d5a19415
JM
1796 * image.c (xbm_load): Free the image buffer after using it.
1797
a9041e6c
PE
17982011-06-21 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 Port to Sun C.
1801 * composite.c (find_automatic_composition): Omit needless 'return 0;'
1802 that Sun C diagnosed.
1803 * fns.c (secure_hash): Fix pointer signedness issue.
1804 * intervals.c (static_offset_intervals): New function.
1805 (offset_intervals): Use it.
1806
7f3f739f
LL
18072011-06-21 Leo Liu <sdl.web@gmail.com>
1808
1809 * deps.mk (fns.o):
1810 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
1811 sha512.h.
1812
1813 * fns.c (secure_hash): Rename from crypto_hash_function and change
1814 the first arg to accept symbols.
5b66d427 1815 (Fsecure_hash): New primitive.
7f3f739f
LL
1816 (syms_of_fns): New symbols.
1817
76147d94
DD
18182011-06-20 Deniz Dogan <deniz@dogan.se>
1819
1820 * process.c (Fset_process_buffer): Clarify return value in
1821 docstring.
1822
7d7d0045
CY
18232011-06-18 Chong Yidong <cyd@stupidchicken.com>
1824
1825 * dispnew.c (add_window_display_history): Use BVAR.
1826
1827 * xdisp.c (debug_method_add): Use BVAR.
1828 (check_window_end, dump_glyph_matrix, dump_glyph)
1829 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
1830
1831 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
1832 Likewise.
1833
1834 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
1835 check till after the cache is created in init_frame_faces.
1836
ff2bc410
SM
18372011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
1838
1839 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
1840
28177add
PE
18412011-06-16 Paul Eggert <eggert@cs.ucla.edu>
1842
dd3482fe
PE
1843 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
1844 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
1845 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
1846
393d71f3 1847 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
1848 * fileio.c (Finsert_file_contents):
1849 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
1850 Remove the old (too-loose) buffer overflow checks.
1851 They weren't needed, since make_gap checks for buffer overflow.
1852 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
1853 The old code merely checked for Emacs fixnum overflow, and relied
1854 on undefined (wraparound) behavior. The new code avoids undefined
1855 behavior, and also checks for ptrdiff_t and/or size_t overflow.
1856
2e6813b0 1857 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
1858 Tune. Don't use wider integers than needed. Don't use alloca.
1859 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 1860
599a9e4f
PE
1861 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
1862
99561444
PE
1863 * insdel.c, lisp.h (buffer_overflow): New function.
1864 (insert_from_buffer_1, replace_range, replace_range_2):
1865 * insdel.c (make_gap_larger):
1866 * editfns.c (Finsert_char):
1867 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
1868
28177add
PE
1869 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
1870
e69dafad
PE
18712011-06-15 Paul Eggert <eggert@cs.ucla.edu>
1872
a7af7fde 1873 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 1874
b1c46f02
PE
1875 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
1876 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
1877
e69dafad
PE
1878 * fileio.c: Don't assume EMACS_INT fits in off_t.
1879 (emacs_lseek): New static function.
1880 (Finsert_file_contents, Fwrite_region): Use it.
1881 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
1882
566684ea
PE
1883 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
1884
e6966cd6
PE
1885 * fns.c: Don't overflow int when computing a list length.
1886 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
1887 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
1888 truncation on 64-bit hosts. Check for QUIT every
1889 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
1890 faster and is responsive enough.
1891 (Flength): Report an error instead of overflowing an integer.
1892 (Fsafe_length): Return a float if the value is not representable
1893 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 1894 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 1895 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 1896
dd0b0efb
PE
1897 * alloc.c: Check that resized vectors' lengths fit in fixnums.
1898 (header_size, word_size): New constants.
1899 (allocate_vectorlike): Don't check size overflow here.
1900 (allocate_vector): Check it here instead, since this is the only
1901 caller of allocate_vectorlike that could cause overflow.
1902 Check that the new vector's length is representable as a fixnum.
1903
86fe5cfe
PE
1904 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
1905 The previous code was bogus. For example, next_almost_prime (32)
1906 returned 39, which is undesirable as it is a multiple of 3; and
1907 next_almost_prime (24) returned 25, which is a multiple of 5 so
1908 why was the code bothering to check for multiples of 7?
1909
80e88859
PE
1910 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
1911
4a2f0ad6
PE
1912 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
1913
f66c7cf8
PE
1914 Variadic C functions now count arguments with ptrdiff_t.
1915 This partly undoes my 2011-03-30 change, which replaced int with size_t.
1916 Back then I didn't know that the Emacs coding style prefers signed int.
1917 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
1918 were being counted with int, which may truncate counts on 64-bit
1919 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
1920 * lisp.h (struct Lisp_Subr.function.aMANY)
1921 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
1922 Arg counts are now ptrdiff_t, not size_t.
1923 All variadic functions and their callers changed accordingly.
1924 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
1925 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
1926 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
1927 * callint.c (Fcall_interactively): Check arg count for overflow,
1928 to avoid potential buffer overrun. Use signed char, not 'int',
1929 for 'varies' array, so that we needn't bother to check its size
1930 calculation for overflow.
1931 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
1932 * eval.c (apply_lambda):
1933 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
1934 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
1935 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
1936
a1759b76
PE
1937 * callint.c (Fcall_interactively): Don't use index var as event count.
1938
d96be9fc
PE
1939 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
1940 * mem-limits.h (SIZE): Remove; no longer used.
1941
a690a978 1942 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 1943
578c21e6
PE
1944 Remove unnecessary casts.
1945 * xterm.c (x_term_init):
1946 * xfns.c (x_set_border_pixel):
1947 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
1948 These aren't needed now that we assume ANSI C.
1949
96f53c6c
PE
1950 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
1951 It's more likely to cause problems (due to unsigned overflow)
1952 than to cure them.
1953
83c77d31
PE
1954 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
1955
ee2079f1
PE
1956 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
1957
6da65536
PE
1958 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
1959
7147c4a4
PE
1960 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
1961
193e32d9
PE
1962 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
1963
e5533da6
PE
1964 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
1965
9910e595
PE
1966 GLYPH_CODE_FACE returns EMACS_INT, not int.
1967 * dispextern.h (merge_faces):
1968 * xfaces.c (merge_faces):
01103c44
PE
1969 * xdisp.c (get_next_display_element, next_element_from_display_vector):
1970 Don't assume EMACS_INT fits in int.
9910e595 1971
2638320e
PE
1972 * character.h (CHAR_VALID_P): Remove unused parameter.
1973 * fontset.c, lisp.h, xdisp.c: All uses changed.
1974
045eb8d9
PE
1975 * editfns.c (Ftranslate_region_internal): Omit redundant test.
1976
c1f134b5
PE
1977 * fns.c (concat): Minor tuning based on overflow analysis.
1978 This doesn't fix any bugs. Use int to hold character, instead
1979 of constantly refetching from Emacs object. Use XFASTINT, not
1980 XINT, for value known to be a character. Don't bother comparing
1981 a single byte to 0400, as it's always less.
1982
395fcb93 1983 * floatfns.c (Fexpt):
327eeec8
PE
1984 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
1985
abbd3d23
PE
1986 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
1987 for characters.
1988
684a03ef
PE
1989 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
1990
0fed43f3
PE
1991 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
1992 Without this fix, on a 64-bit host (aset S 0 4294967386) would
1993 incorrectly succeed when S was a string, because 4294967386 was
1994 truncated before it was used.
1995
8fd02eb7
PE
1996 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
1997 Otherwise, an out-of-range integer could cause undefined behavior
1998 on a 64-bit host.
1999
f8c86b69
PE
2000 * composite.c: Use int, not EMACS_INT, for characters.
2001 (fill_gstring_body, composition_compute_stop_pos): Use int, not
2002 EMACS_INT, for values that are known to be in character range.
2003 This doesn't fix any bugs but is the usual style inside Emacs and
2004 may generate better code on 32-bit machines.
2005
34206dd2
PE
2006 Make sure a 64-bit char is never passed to ENCODE_CHAR.
2007 This is for reasons similar to the recent CHAR_STRING fix.
2008 * charset.c (Fencode_char): Check that character arg is actually
2009 a character. Pass an int to ENCODE_CHAR.
2010 * charset.h (ENCODE_CHAR): Verify that the character argument is no
2011 wider than 'int', as a compile-time check to prevent future regressions
2012 in this area.
2013
c5958d4c 2014 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
2015
2016 Make sure a 64-bit char is never passed to CHAR_STRING.
2017 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
2018 by silently ignoring the top 32 bits, allowing some values
2019 that were far too large to be valid characters.
2020 * character.h: Include <verify.h>.
2021 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
2022 arguments are no wider than unsigned, as a compile-time check
2023 to prevent future regressions in this area.
2024 * data.c (Faset):
01103c44 2025 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
2026 (Fsubst_char_in_region):
2027 * fns.c (concat):
2028 * xdisp.c (decode_mode_spec_coding):
2029 Adjust to CHAR_STRING's new requirement.
2030 * editfns.c (Finsert_char, Fsubst_char_in_region):
2031 * fns.c (concat): Check that character args are actually
2032 characters. Without this test, these functions did the wrong
2033 thing with wildly out-of-range values on 64-bit hosts.
2034
d37ca623
PE
2035 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
2036 These casts should not be needed on 32-bit hosts, either.
2037 * keyboard.c (read_char):
2038 * lread.c (Fload): Remove casts to unsigned.
2039
ea204efb
PE
2040 * lisp.h (UNSIGNED_CMP): New macro.
2041 This fixes comparison bugs on 64-bit hosts.
2042 (ASCII_CHAR_P): Use it.
2043 * casefiddle.c (casify_object):
01103c44 2044 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
2045 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
2046 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
2047 * dispextern.h (FACE_FROM_ID):
2048 * keyboard.c (read_char): Use UNSIGNED_CMP.
2049
41cb286c
PE
2050 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
2051 not to EMACS_INT, to avoid GCC warning.
2052
4a1b9832
PE
2053 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
2054
55daad71
PE
2055 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
2056 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
2057 isn't needed on 32-bit machines.
8f95c75c 2058
01103c44
PE
2059 * buffer.c (Fgenerate_new_buffer_name):
2060 Use EMACS_INT for count, not int.
0ceccced 2061 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
2062
2063 * data.c (Qcompiled_function): Now static.
2064
c6f072e7
PE
2065 * window.c (window_body_lines): Now static.
2066
20ce5912
PE
2067 * image.c (gif_load): Rename local to avoid shadowing.
2068
9c4c5f81
PE
2069 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
2070 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
2071 * alloc.c (make_save_value): Integer argument is now of type
2072 ptrdiff_t, not int.
2073 (mark_object): Use ptrdiff_t, not int.
2074 * lisp.h (pD): New macro.
2075 * print.c (print_object): Use it.
2076
c0c5c8ae
PE
2077 * alloc.c: Use EMACS_INT, not int, to count objects.
2078 (total_conses, total_markers, total_symbols, total_vector_size)
2079 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
2080 (total_free_floats, total_floats, total_free_intervals)
2081 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
2082 Now EMACS_INT, not int. All uses changed.
2083 (Fgarbage_collect): Compute overall total using a double, so that
2084 integer overflow is less likely to be a problem. Check for overflow
2085 when converting back to an integer.
5a25e253
PE
2086 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
2087 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
2088 These were 'int' variables that could overflow on 64-bit hosts;
2089 they were never used, so remove them instead of repairing them.
211a0b2a 2090 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
2091 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
2092 Previously, this ceilinged at INT_MAX, but that doesn't work on
2093 64-bit machines.
e46bb31a 2094 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 2095
c78baabf 2096 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 2097 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
2098 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
2099 when a (possibly-narrower) signed value would do just as well.
2100 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 2101
c9d624c6
PE
2102 * alloc.c: Catch some string size overflows that we were missing.
2103 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
2104 for convenience in STRING_BYTES_MAX.
2105 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
2106 The definition here is exact; the one in lisp.h was approximate.
2107 (allocate_string_data): Check for string overflow. This catches
2108 some instances we weren't catching before. Also, it catches
2109 size_t overflow on (unusual) hosts where SIZE_MAX <= min
2110 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
2111 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 2112
c9d624c6
PE
2113 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
2114 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 2115 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 2116
353032ce
PE
2117 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
2118
2bccce07
PE
2119 * alloc.c (Fmake_string): Check for out-of-range init.
2120
0ac30604
SM
21212011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
2122
2123 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
2124
c195f2de
JD
21252011-06-14 Jan Djärv <jan.h.d@swipnet.se>
2126
2127 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
2128 xg_get_default_scrollbar_width.
2129
2130 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
2131 (int_gtk_range_get_value): Move to the scroll bar part of the file.
2132 (style_changed_cb): Call update_theme_scrollbar_width and call
2133 x_set_scroll_bar_default_width and xg_frame_set_char_size for
2134 all frames (Bug#8505).
2135 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
2136 Call gtk_window_set_resizable if HAVE_GTK3.
2137 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
2138 and height if HAVE_GTK3 (Bug#8505).
2139 (scroll_bar_width_for_theme): New variable.
2140 (update_theme_scrollbar_width): New function.
2141 (xg_get_default_scrollbar_width): Move code to
2142 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
2143 (xg_initialize): Call update_theme_scrollbar_width.
2144
2145 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
2146
2147 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
2148
e10ac9f1
MR
21492011-06-12 Martin Rudalics <rudalics@gmx.at>
2150
2151 * frame.c (make_frame): Call other_buffer_safely instead of
2152 other_buffer.
2153
2154 * window.c (temp_output_buffer_show): Call display_buffer with
2155 second argument Vtemp_buffer_show_specifiers and reset latter
2156 immediately after the call.
2157 (Vtemp_buffer_show_specifiers): New variable.
2158 (auto_window_vscroll_p, next_screen_context_lines)
2159 (Vscroll_preserve_screen_position): Remove leading asterisks from
2160 doc-strings.
2161
2d3c217e 21622011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 2163
7b7f97e8 2164 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
2165 * buffer.c (Qclone_number): Remove for now, as it's unused.
2166 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
2167 (record_buffer): Remove unused local.
2168 * frame.c (other_visible_frames, frame_buffer_list): Now static.
2169 (set_frame_buffer_list): Remove; unused.
2170 * frame.h (other_visible_frames): Remove decl.
2171 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
2172 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
2173 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
2174 if HAVE_GPM.
2175 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
2176 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
2177 Define only if HAVE_GPM.
2178 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
2179 (update_hints_inhibit): Remove; never set. All uses removed.
2180 * widgetprv.h (emacsFrameClassRec): Remove decl.
2181 * window.c (delete_deletable_window): Now returns void, since it
2182 wasn't returning anything.
2183 (compare_window_configurations): Remove unused locals.
2184 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
2185 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
2186 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
2187 the same widths as pointers. This follows up on the 2011-05-06 patch.
2188 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
2189 * xterm.h: Likewise.
2190 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
2191
1384b89e
JB
21922011-06-12 Juanma Barranquero <lekktu@gmail.com>
2193
2194 * makefile.w32-in: Update dependencies.
2195 (LISP_H): Add lib/intprops.h.
2196
1100a63c
CY
21972011-06-11 Chong Yidong <cyd@stupidchicken.com>
2198
2199 * image.c (gif_load): Add animation frame delay to the metadata.
2200 (syms_of_image): Use DEFSYM. New symbol `delay'.
2201
6198ccd0
MR
22022011-06-11 Martin Rudalics <rudalics@gmx.at>
2203
2204 * window.c (delete_deletable_window): Re-add.
2205 (Fset_window_configuration): Rewrite to handle dead buffers and
2206 consequently deletable windows.
2207 (window_tree, Fwindow_tree): Remove. Supply functionality in
2208 window.el.
2209 (compare_window_configurations): Simplify code.
2210
b6e3633c
AS
22112011-06-11 Andreas Schwab <schwab@linux-m68k.org>
2212
1ab0dee5
AS
2213 * image.c (imagemagick_load_image): Fix type mismatch.
2214 (Fimagemagick_types): Likewise.
2215
b6e3633c
AS
2216 * window.h (replace_buffer_in_windows): Declare.
2217
9397e56f
MR
22182011-06-11 Martin Rudalics <rudalics@gmx.at>
2219
2220 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
2221 Qclone_number. Remove external declaration of Qdelete_window.
2222 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
2223 code.
640c8776
SM
2224 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
2225 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
2226 (Fother_buffer): Rewrite doc-string. Major rewrite for new
2227 buffer list implementation.
2228 (other_buffer_safely): New function.
2229 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
2230 calls to replace_buffer_in_windows and
2231 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
2232 if allowed.
2233 (record_buffer): Inhibit quitting and rewrite using quittable
2234 functions. Run Qbuffer_list_update_hook if allowed.
2235 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
2236 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
2237 Move switch-to-buffer to window.el.
9397e56f
MR
2238 (bury-buffer): Move to window.el.
2239 (Vbuffer_list_update_hook): New variable.
2240
2241 * lisp.h (other_buffer_safely): Add prototype in buffer.c
2242 section.
2243
2244 * window.h (resize_frame_windows): Move up in code.
2245 (Fwindow_frame): Remove EXFUN.
2246 (replace_buffer_in_all_windows): Remove prototype.
2247 (replace_buffer_in_windows_safely): Add prototype.
2248
2249 * window.c: Declare Qdelete_window static again. Move down
2250 declaration of select_count.
2251 (Fnext_window, Fprevious_window): Rewrite doc-strings.
2252 (Fother_window): Move to window.el.
2253 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
2254 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
2255 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
2256 window.el.
2257 (replace_buffer_in_windows): Implement by calling
2258 Qreplace_buffer_in_windows.
2259 (replace_buffer_in_all_windows): Remove with some functionality
2260 moved into replace_buffer_in_windows_safely.
2261 (replace_buffer_in_windows_safely): New function.
2262 (select_window_norecord, select_frame_norecord): Move in front
2263 of run_window_configuration_change_hook. Remove now obsolete
2264 declarations.
640c8776
SM
2265 (Fset_window_buffer): Rewrite doc-string.
2266 Call Qrecord_window_buffer.
9397e56f
MR
2267 (keys_of_window): Move binding for other-window to window.el.
2268
b50691aa
CY
22692011-06-11 Chong Yidong <cyd@stupidchicken.com>
2270
2271 * dispextern.h (struct image): Replace data member, whose int_val
2272 and ptr_val fields were not used by anything, with a single
2273 lisp_val object.
2274
2275 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
2276 (gif_clear_image, gif_load, imagemagick_load_image)
2277 (gs_clear_image, gs_load): Callers changed.
2278
3f754b86
PE
22792011-06-10 Paul Eggert <eggert@cs.ucla.edu>
2280
cca69397
PE
2281 * buffer.h: Include <time.h>, for time_t.
2282 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
2283
109e28d0
PE
2284 Fix minor problems found by static checking.
2285
60737f02
PE
2286 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
2287
4b66faf3
PE
2288 Make identifiers static if they are not used in other modules.
2289 * data.c (Qcompiled_function, Qframe, Qvector):
2290 * image.c (QimageMagick, Qsvg):
2291 * minibuf.c (Qmetadata):
2292 * window.c (resize_window_check, resize_root_window): Now static.
2293 * window.h (resize_window_check, resize_root_window): Remove decls.
2294
109e28d0
PE
2295 * window.c (window_deletion_count, delete_deletable_window):
2296 Remove; unused.
46a4ce9e
PE
2297 (window_body_lines): Now static.
2298 (Fdelete_other_windows_internal): Mark vars as initialized.
2299 Make sure 'resize_failed' is initialized.
2300 (run_window_configuration_change_hook): Rename local to avoid shadowing.
2301 (resize_window_apply): Remove unused local.
2302 * window.h (delete_deletable_window): Remove decl.
2303
109e28d0 2304 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
2305 (imagemagick_load_image): Fix pointer signedness problem by changing
2306 last arg from unsigned char * to char *. All uses changed.
2307 Also, fix a local for similar reasons.
2308 Remove unused locals. Remove locals to avoid shadowing.
2309 (fn_rsvg_handle_free): Remove; unused.
2310 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 2311 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 2312
3f754b86
PE
2313 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
2314
2547adb1
CY
23152011-06-10 Chong Yidong <cyd@stupidchicken.com>
2316
2317 * image.c (gif_load): Fix omitted cast error introduced by
2318 2011-06-06 change.
2319
2c8e37d4
MR
23202011-06-10 Martin Rudalics <rudalics@gmx.at>
2321
2322 * window.h (resize_proportionally, orig_total_lines)
2323 (orig_top_line): Remove from window structure.
2324 (set_window_height, set_window_width, change_window_heights)
2325 (Fdelete_window): Remove prototypes.
2326 (resize_frame_windows): Remove duplicate declaration.
2327
440a42e3
EZ
23282011-06-10 Eli Zaretskii <eliz@gnu.org>
2329
2330 * window.h (resize_frame_windows, resize_window_check)
2331 (delete_deletable_window, resize_root_window)
2332 (resize_frame_windows): Declare prototypes.
2333
2334 * window.c (resize_window_apply): Make definition be "static" to
2335 match the prototype.
2336
562dd5e9
MR
23372011-06-10 Martin Rudalics <rudalics@gmx.at>
2338
2339 * window.c: Remove declarations of Qwindow_size_fixed,
2340 window_min_size_1, window_min_size_2, window_min_size,
2341 size_window, window_fixed_size_p, enlarge_window, delete_window.
2342 Remove static from declaration of Qdelete_window, it's
2343 temporarily needed by Fbury_buffer.
2344 (replace_window): Don't assign orig_top_line and
2345 orig_total_lines.
2346 (Fdelete_window, delete_window): Remove. Window deletion is
2347 handled by window.el.
640c8776
SM
2348 (window_loop): Remove DELETE_OTHER_WINDOWS case.
2349 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
2350 (Fdelete_other_windows): Remove. Deleting other windows is
2351 handled by window.el.
2352 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
2353 handled in window.el.
2354 (window_min_size_2, window_min_size_1, window_min_size): Remove.
2355 Window minimum sizes are handled in window.el.
2356 (shrink_windows, size_window, set_window_height)
2357 (set_window_width, change_window_heights, window_height)
2358 (window_width, CURBEG, CURSIZE, enlarge_window)
2359 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
2360 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
2361 handled in window.el.
2362 (make_dummy_parent): Rename to make_parent_window and give it a
2363 second argument horflag.
2364 (make_window): Don't set resize_proportionally any more.
2365 (Fsplit_window): Remove. Windows are split in window.el.
2366 (save_restore_action, save_restore_orig_size)
2367 (shrink_window_lowest_first, save_restore_orig_size): Remove.
2368 Resize mini windows in window.el.
2369 (grow_mini_window, shrink_mini_window): Implement by calling
2370 Qresize_root_window_vertically, resize_window_check and
2371 resize_window_apply.
640c8776
SM
2372 (saved_window, Fset_window_configuration, save_window_save):
2373 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
2374 resize_proportionally.
2375 (window_min_height, window_min_width): Move to window.el.
2376 (keys_of_window): Move bindings for delete-other-windows,
2377 split-window, delete-window and enlarge-window to window.el.
2378
2379 * buffer.c: Temporarily extern Qdelete_window.
2380 (Fbury_buffer): Temporarily call Qdelete_window instead of
2381 Fdelete_window (Fbury_buffer will move to window.el soon).
2382
2383 * frame.c (set_menu_bar_lines_1): Remove code handling
2384 orig_top_line and orig_total_lines.
2385
2386 * dispnew.c (adjust_frame_glyphs_initially): Don't use
2387 set_window_height but set heights directly.
2388 (change_frame_size_1): Use resize_frame_windows.
2389
2390 * xdisp.c (init_xdisp): Don't use set_window_height but set
2391 heights directly.
2392
640c8776
SM
2393 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
2394 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
2395 run_window_configuration_change_hook.
2396
2397 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
2398 instead of change_window_heights and run
2399 run_window_configuration_change_hook.
2400
1a13852e
MR
24012011-06-09 Martin Rudalics <rudalics@gmx.at>
2402
2403 * window.c (replace_window): Rename second argument REPLACEMENT to
2404 NEW. New third argument SETFLAG. Rewrite.
2405 (delete_window, make_dummy_parent): Call replace_window with
2406 third argument 1.
2407 (window_list_1): Move down in code.
2408 (run_window_configuration_change_hook): Move set_buffer part
2409 before select_frame_norecord part in order to unwind correctly.
2410 Rename count1 to count.
2411 (recombine_windows, delete_deletable_window, resize_root_window)
2412 (Fdelete_other_windows_internal)
2413 (Frun_window_configuration_change_hook, make_parent_window)
2414 (resize_window_check, resize_window_apply, Fresize_window_apply)
2415 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
2416 (Fdelete_window_internal, Fresize_mini_window_internal):
2417 New functions.
1a13852e
MR
2418 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
2419
f3d1777e
MR
24202011-06-08 Martin Rudalics <rudalics@gmx.at>
2421
496e208e
MR
2422 * window.h (window): Add some new members to window structure -
2423 normal_lines, normal_cols, new_total, new_normal, clone_number,
2424 splits, nest, prev_buffers, next_buffers.
2425 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 2426 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 2427
f3d1777e
MR
2428 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
2429 Remove.
496e208e
MR
2430 (make_dummy_parent): Set new members of windows structure.
2431 (make_window): Move down in code. Handle new members of window
2432 structure.
2433 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
2434 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
2435 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
2436 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
2437 (Fset_window_next_buffers, Fset_window_clone_number):
2438 New functions.
496e208e
MR
2439 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
2440 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
2441 Doc-string fixes.
2442 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
2443 Argument WINDOW can be now internal window too.
2444 (Fwindow_use_time): Move up in code.
2445 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
2446 Rewrite doc-string.
2447 (Fset_window_configuration, saved_window)
2448 (Fcurrent_window_configuration, save_window_save): Handle new
2449 members of window structure.
b9e809c2
MR
2450 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
2451 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
2452 (syms_of_window): New Lisp objects Qrecord_window_buffer,
2453 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
2454 Qget_mru_window, Qresize_root_window,
2455 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
2456 Qauto_buffer_name; staticpro them.
f3d1777e 2457
abde8f8c
MR
24582011-06-07 Martin Rudalics <rudalics@gmx.at>
2459
2460 * window.c (Fwindow_total_size, Fwindow_left_column)
2461 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
2462 (Fwindow_list_1): New functions.
2463 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
2464 (Fwindow_width, Fscroll_left, Fscroll_right):
2465 Use window_body_cols instead of window_box_text_cols.
2466 (delete_window, Fset_window_configuration):
2467 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
2468 (delete_all_subwindows): Take a window as argument and not a
2469 structure. Rewrite.
190b47e6
MR
2470 (window_loop): Remove handling of GET_LRU_WINDOW and
2471 GET_LARGEST_WINDOW.
2472 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
2473
2474 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
2475 window_box_text_cols. delete_all_subwindows now takes a
2476 Lisp_Object as argument.
abde8f8c 2477
640c8776
SM
2478 * indent.c (compute_motion, Fcompute_motion):
2479 Use window_body_cols instead of window_box_text_cols.
abde8f8c 2480
fa8a67e6
MR
2481 * frame.c (delete_frame): Call delete_all_subwindows with root
2482 window as argument.
2483
a54e3482
DC
24842011-06-07 Daniel Colascione <dan.colascione@gmail.com>
2485
2486 * fns.c (Fputhash): Document return value.
2487
60002bf5
CY
24882011-06-06 Chong Yidong <cyd@stupidchicken.com>
2489
2490 * image.c (gif_load): Implement gif89a spec "no disposal" method.
2491
0c671da6 24922011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 2493
b862a52a 2494 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 2495
be44ca6c
PE
2496 Check for overflow when converting integer to cons and back.
2497 * charset.c (Fdefine_charset_internal, Fdecode_char):
2498 Use cons_to_unsigned to catch overflow.
2499 (Fencode_char): Use INTEGER_TO_CONS.
2500 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
2501 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
2502 * data.c (long_to_cons, cons_to_long): Remove.
2503 (cons_to_unsigned, cons_to_signed): New functions.
2504 These signal an error for invalid or out-of-range values.
2505 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
2506 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
2507 * font.c (Ffont_variation_glyphs):
2508 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
2509 * lisp.h: Include <intprops.h>.
2510 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
2511 (cons_to_signed, cons_to_unsigned): New decls.
2512 (long_to_cons, cons_to_long): Remove decls.
2513 * undo.c (record_first_change): Use INTEGER_TO_CONS.
2514 (Fprimitive_undo): Use CONS_TO_INTEGER.
2515 * xfns.c (Fx_window_property): Likewise.
2516 * xselect.c: Include <limits.h>.
2517 (x_own_selection, selection_data_to_lisp_data):
2518 Use INTEGER_TO_CONS.
2519 (x_handle_selection_request, x_handle_selection_clear)
2520 (x_get_foreign_selection, Fx_disown_selection_internal)
2521 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
2522 (lisp_data_to_selection_data): Use cons_to_unsigned.
2523 (x_fill_property_data): Use cons_to_signed.
2524 Report values out of range.
2525
d1f3d2af
PE
2526 Check for buffer and string overflow more precisely.
2527 * buffer.h (BUF_BYTES_MAX): New macro.
2528 * lisp.h (STRING_BYTES_MAX): New macro.
2529 * alloc.c (Fmake_string):
2530 * character.c (string_escape_byte8):
2531 * coding.c (coding_alloc_by_realloc):
2532 * doprnt.c (doprnt):
2533 * editfns.c (Fformat):
2534 * eval.c (verror):
2535 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
2536 since they may not be the same number.
2537 * editfns.c (Finsert_char):
2538 * fileio.c (Finsert_file_contents):
2539 Likewise for BUF_BYTES_MAX.
2540
dd52fcea
PE
2541 * image.c: Use ptrdiff_t, not int, for sizes.
2542 (slurp_file): Switch from int to ptrdiff_t.
2543 All uses changed.
2544 (slurp_file): Check that file size fits in both size_t (for
2545 malloc) and ptrdiff_t (for sanity and safety).
2546
7f9bbdbb
PE
2547 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
2548 if b->modtime has its maximal value.
2549
dfe18f82
PE
2550 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
2551
84acfcf0
PE
2552 Don't assume time_t can fit into int.
2553 * buffer.h (struct buffer.modtime): Now time_t, not int.
2554 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
2555 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
2556
ccd9a01a
PE
2557 Minor fixes for signed vs unsigned integers.
2558 * character.h (MAYBE_UNIFY_CHAR):
2559 * charset.c (maybe_unify_char):
2560 * keyboard.c (read_char, reorder_modifiers):
2561 XINT -> XFASTINT, since the integer must be nonnegative.
2562 * ftfont.c (ftfont_spec_pattern):
2563 * keymap.c (access_keymap, silly_event_symbol_error):
2564 XUINT -> XFASTINT, since the integer must be nonnegative.
2565 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
2566 since it makes no difference and we prefer signed.
2567 * keyboard.c (record_char): Use XUINT when all the neighbors do.
2568 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
2569 nonnegative.
2570
d6d100dd
SM
25712011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
2572
2573 * window.h (Fwindow_frame): Declare.
2574
2b6148e4
PE
25752011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2576
2577 * alloc.c: Simplify handling of large-request failures (Bug#8800).
2578 (SPARE_MEMORY): Always define.
2579 (LARGE_REQUEST): Remove.
2580 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
2581
f230ecc9
MR
25822011-06-06 Martin Rudalics <rudalics@gmx.at>
2583
727e958e
MR
2584 * lisp.h: Move EXFUNS for Fframe_root_window,
2585 Fframe_first_window and Fset_frame_selected_window to window.h.
2586
2587 * window.h: Move EXFUNS for Fframe_root_window,
2588 Fframe_first_window and Fset_frame_selected_window here from
2589 lisp.h.
2590
2591 * frame.c (Fwindow_frame, Fframe_first_window)
2592 (Fframe_root_window, Fframe_selected_window)
2593 (Fset_frame_selected_window): Move to window.c.
2594 (Factive_minibuffer_window): Move to minibuf.c.
2595 (Fother_visible_frames_p): New function.
2596
2597 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
2598
f230ecc9
MR
2599 * window.c (decode_window, decode_any_window): Move up in code.
2600 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
2601 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
2602 (Fwindow_buffer): Move up and rewrite doc-string.
2603 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
2604 (Fwindow_prev): New functions.
727e958e
MR
2605 (Fwindow_frame): Move here from frame.c. Accept any window as
2606 argument.
2607 (Fframe_root_window, Fframe_first_window)
2608 (Fframe_selected_window): Move here from frame.c. Accept frame
2609 or arbitrary window as argument. Update doc-strings.
2610 (Fminibuffer_window): Move up in code.
2611 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
2612 (Fset_frame_selected_window): Move here from frame.c.
2613 Marginal rewrite.
727e958e
MR
2614 (Fselected_window, select_window, Fselect_window): Move up in
2615 code. Minor doc-string fixes.
f230ecc9 2616
4d09bcf6
PE
26172011-06-06 Paul Eggert <eggert@cs.ucla.edu>
2618
2619 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
2620 Do not assume that spare memory exists; that assumption is valid
2621 only if SYSTEM_MALLOC.
2622 (LARGE_REQUEST): New macro, so that the issue of large requests
2623 is separated from the issue of spare memory.
2624
810928a2
AS
26252011-06-05 Andreas Schwab <schwab@linux-m68k.org>
2626
172418ad
AS
2627 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
2628 format. (Bug#8806)
2629
43f862f7
AS
2630 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
2631
810928a2
AS
2632 * xfns.c (x_set_scroll_bar_default_width): Move declarations
2633 before statements.
2634
a059fe24
JD
26352011-06-05 Jan Djärv <jan.h.d@swipnet.se>
2636
2637 * gtkutil.c (xg_get_default_scrollbar_width): New function.
2638
2639 * gtkutil.h: Declare xg_get_default_scrollbar_width.
2640
2641 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
2642 min width by calling x_set_scroll_bar_default_width (Bug#8505).
2643
989bf368
JB
26442011-06-05 Juanma Barranquero <lekktu@gmail.com>
2645
2646 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
2647
4b80f674
CY
26482011-06-04 Chong Yidong <cyd@stupidchicken.com>
2649
2650 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
2651 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
2652 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
2653 New error handlers.
4b80f674
CY
2654 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
2655 Obey Vx_select_enable_clipboard_manager. Catch errors in
2656 x_clipboard_manager_save (Bug#8779).
2657 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 2658 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 2659
99a33b77 26602011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
2661
2662 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
2663
99a33b77 26642011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
2665
2666 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
2667 in the current matrix if keep_current_p is non-zero.
2668
8264569d
EZ
26692011-06-04 Eli Zaretskii <eliz@gnu.org>
2670
2671 * bidi.c (bidi_level_of_next_char): Fix last change.
2672
57f97249
EZ
26732011-06-03 Eli Zaretskii <eliz@gnu.org>
2674
fec2107c 2675 Support bidi reordering of text covered by display properties.
57f97249 2676
fec2107c
EZ
2677 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
2678 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
2679 (bidi_cache_search, bidi_cache_iterator_state)
2680 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
2681 (bidi_level_of_next_char, bidi_move_to_visually_next):
2682 Support character positions inside a run of characters covered by a
fec2107c
EZ
2683 display string.
2684 (bidi_paragraph_init, bidi_resolve_explicit_1)
2685 (bidi_level_of_next_char): Call bidi_fetch_char and
2686 bidi_fetch_char_advance instead of FETCH_CHAR and
2687 FETCH_CHAR_ADVANCE.
2688 (bidi_init_it): Initialize new members.
2689 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
2690 definitions.
2691 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
2692 instead of using explicit *_CHAR codes.
d6d100dd
SM
2693 (bidi_resolve_explicit, bidi_resolve_weak):
2694 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
2695 bidirectional text is supported only in multibyte buffers.
2696 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
2697 it to initialize the frame_window_p member of struct bidi_it.
2698 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
2699 (bidi_resolve_explicit, bidi_resolve_weak)
2700 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
2701 bidi_it->nchars is non-positive.
2702 (bidi_level_of_next_char): Don't try to lookup the cache for the
2703 next/previous character if nothing is cached there yet, or if we
2704 were just reseat()'ed to a new position.
c40e2fb2 2705
0e14fe90
EZ
2706 * xdisp.c (set_cursor_from_row): Set start and stop points
2707 according to the row's direction when priming the loop that looks
2708 for the glyph on which to display cursor.
2709 (single_display_spec_intangible_p): Function deleted.
2710 (display_prop_intangible_p): Reimplement to call
2711 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
2712 Accept 3 additional arguments needed by handle_display_spec.
2713 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
2714 values: lists, `(when COND...)' forms, etc.
2715 (single_display_spec_string_p): Support property values that are
2716 lists with the argument STRING its top-level element.
2717 (display_prop_string_p): Fix the condition for processing a
2718 property that is a list to be consistent with handle_display_spec.
fec2107c 2719 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
2720 last portion of handle_display_prop.
2721 (compute_display_string_pos): Accept additional argument
2722 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
2723 value of a `display' property is a "replacing spec".
2724 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
2725 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
2726 the display property, but just return a value indicating whether
2727 the display property will replace the characters it covers.
2728 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
2729 frame_window_p members of struct bidi_it.
d6d100dd
SM
2730 (compute_display_string_pos, compute_display_string_end):
2731 New functions.
fec2107c
EZ
2732 (push_it): Accept second argument POSITION, where pop_it should
2733 jump to continue iteration.
2734 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 2735
fec2107c
EZ
2736 * keyboard.c (adjust_point_for_property): Adjust the call to
2737 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
2738
2739 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
2740 (bidi_init_it): Update prototypes.
2741 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
2742 (compute_display_string_pos, compute_display_string_end):
2743 Declare prototypes.
fec2107c
EZ
2744 (struct bidi_it): New members nchars and disp_pos. ch_len is now
2745 EMACS_INT.
fc6f18ce 2746
40087514 27472011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 2748
57f53182
PE
2749 Malloc failure behavior now depends on size of allocation.
2750 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
2751 * lisp.h: Change signatures accordingly.
2752 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
2753 All callers changed. (Bug#8762)
2754
2755 * gnutls.c: Use Emacs's memory allocators.
2756 Without this change, the gnutls library would invoke malloc etc.
2757 directly, which causes problems on non-SYNC_INPUT hosts, and which
2758 runs afoul of improving memory_full behavior. (Bug#8761)
2759 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
2760 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
2761 xfree instead of the default malloc, realloc, free.
2762 (Fgnutls_boot): No need to check for memory allocation failure,
2763 since xmalloc does that for us.
2764
ac32cd99 2765 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
2766 * category.c (hash_get_category_set):
2767 * ccl.c (ccl_driver):
2768 * charset.c (Fdefine_charset_internal):
2769 * charset.h (struct charset.hash_index):
2770 * composite.c (get_composition_id, gstring_lookup_cache)
2771 (composition_gstring_put_cache):
2772 * composite.h (struct composition.hash_index):
2773 * dispextern.h (struct image.hash):
2774 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
2775 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
2776 (hashfn_equal, hashfn_user_defined, make_hash_table)
2777 (maybe_resize_hash_table, hash_lookup, hash_put)
2778 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
2779 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
2780 (Fsxhash, Fgethash, Fputhash, Fmaphash):
2781 * image.c (make_image, search_image_cache, lookup_image)
2782 (xpm_put_color_table_h):
2783 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 2784 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 2785 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 2786 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
2787 * alloc.c (allocate_vectorlike):
2788 Check for overflow in vector size calculations.
2789 * ccl.c (ccl_driver):
2790 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
2791 * fns.c, image.c: Remove unnecessary static decls that would otherwise
2792 need to be updated by these changes.
40087514
PE
2793 * fns.c (make_hash_table, maybe_resize_hash_table):
2794 Check for integer overflow with large hash tables.
0de4bb68
PE
2795 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
2796 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
2797 (SXHASH_REDUCE): New macro.
2798 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
2799 Use it instead of discarding useful hash info with large hash values.
2800 (sxhash_float): New function.
2801 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
2802 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
2803 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
2804 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
2805 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
2806 Adjust signatures to match updated version of code.
2807 (consing_since_gc): Now EMACS_INT, since a single hash table can
2808 use more than INT_MAX bytes.
2809
698d32e2
DN
28102011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
2811
2812 Make it possible to build with GCC-4.6+ -O2 -flto.
2813
2814 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
2815
fd6fa53f
SM
28162011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
2817
2818 * minibuf.c (get_minibuffer, read_minibuf_unwind):
2819 Call minibuffer-inactive-mode.
2820
864db017
JB
28212011-05-31 Juanma Barranquero <lekktu@gmail.com>
2822
2823 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
2824 Update dependencies.
2825
2ad0baf4
DN
28262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2827
2828 * data.c (init_data): Remove code for UTS, this system is not
2829 supported anymore.
2830
4fcc2638
DN
28312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2832
2833 Don't force ./temacs to start in terminal mode.
2834
2835 * frame.c (make_initial_frame): Initialize faces in all cases, not
2836 only when CANNOT_DUMP is defined.
2837 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
2838
c56e0fd5
DN
28392011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2840
2841 * dispnew.c (add_window_display_history): Use const for the string
2842 pointer. Remove declaration, not needed.
2843
333d54da 28442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 2845
55d4c1b2 2846 Use 'inline', not 'INLINE'.
333d54da 2847 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
2848 * alloc.c, fontset.c (INLINE): Remove.
2849 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
2850 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
2851 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
2852 * gmalloc.c (register_heapinfo): Use inline unconditionally.
2853 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
2854
738db178
DN
28552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
2856
2857 Make it possible to run ./temacs.
2858
2859 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
2860 syms_of_callproc does the same thing. Remove test for
2861 "initialized", do it in the caller.
2862 * emacs.c (main): Avoid calling set_initial_environment when dumping.
2863
620c53a6
SM
28642011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
2865
2866 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
2867 (read_minibuf): Use get_minibuffer.
2868 (syms_of_minibuf): Use DEFSYM.
2869 (Qmetadata): New var.
2870 * data.c (Qbuffer): Don't make it static.
2871 (syms_of_data): Use DEFSYM.
2872
e003a292
PE
28732011-05-31 Paul Eggert <eggert@cs.ucla.edu>
2874
2875 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
2876 (CCL_CODE_MIN): New macro.
2877
ed008a6d
PE
28782011-05-30 Paul Eggert <eggert@cs.ucla.edu>
2879
3687c2ef
PE
2880 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
2881
ed008a6d
PE
2882 * eval.c (Qdebug): Now static.
2883 * lisp.h (Qdebug): Remove decl. This reverts a part of the
2884 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
2885 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
2886
d66c4c7c
CY
28872011-05-29 Chong Yidong <cyd@stupidchicken.com>
2888
2889 * image.c: Various fixes to ImageMagick code comments.
2890 (Fimagemagick_types): Doc fix.
2891
5fbc2025
PE
28922011-05-29 Paul Eggert <eggert@cs.ucla.edu>
2893
0196f88a
PE
2894 Minor fixes prompted by GCC 4.6.0 warnings.
2895
2896 * xselect.c (converted_selections, conversion_fail_tag): Now static.
2897
5fbc2025
PE
2898 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
2899 (x_clipboard_manager_save_all): Move extern decl to ...
2900 * xterm.h: ... here, so that it can be checked for consistency.
2901
1dd3c2d9
CY
29022011-05-29 Chong Yidong <cyd@stupidchicken.com>
2903
2904 * xselect.c (x_clipboard_manager_save_frame)
2905 (x_clipboard_manager_save_all): New functions.
2906 (Fx_clipboard_manager_save): Lisp function deleted.
2907
2908 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
2909 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
2910
2911 * xterm.h: Update prototype.
2912
5ba6571d
WX
29132011-05-28 William Xu <william.xwl@gmail.com>
2914
2915 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
2916 exiting (Bug#8239).
2917
3eaff834
JM
29182011-05-28 Jim Meyering <meyering@redhat.com>
2919
e1900994 2920 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
2921 * fns.c (to_uchar): Define.
2922 (crypto_hash_function): Use it to convert some newly-signed
2923 variables to unsigned, to avoid sign-extension bugs. For example,
2924 without this change, (md5 "truc") would evaluate to
2925 45723a2aff78ff4fff7fff1114760e62 rather than the expected
2926 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 2927 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 2928
0f6990a7
PE
29292011-05-27 Paul Eggert <eggert@cs.ucla.edu>
2930
2931 Integer overflow fixes.
c8a9ca5a 2932
08686060
PE
2933 * dbusbind.c: Serial number integer overflow fixes.
2934 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
2935 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
2936 to hold a serial number that is too large for a fixnum.
2937 (Fdbus_method_return_internal, Fdbus_method_error_internal):
2938 Check for serial numbers out of range. Decode any serial number
59568bf0 2939 that was so large that it became a float. (Bug#8722)
08686060 2940
2d1fc3c7
PE
2941 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
2942 (Fdbus_call_method, Fdbus_call_method_asynchronously):
2943 Use XFASTINT rather than XUINT when numbers are nonnegative.
2944 (xd_append_arg, Fdbus_method_return_internal):
2945 (Fdbus_method_error_internal): Likewise. Also, for unsigned
2946 arguments, check that Lisp number is nonnegative, rather than
59568bf0 2947 silently wrapping negative numbers around. (Bug#8722)
30217ff0 2948 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 2949 (Bug#8722)
2d1fc3c7 2950
c8a9ca5a
PE
2951 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
2952
519e1d69
PE
2953 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
2954
30569699
PE
2955 ccl: add integer overflow checks
2956 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
2957 (IN_INT_RANGE): New macros.
2958 (ccl_driver): Use them to check for integer overflow when
2959 decoding a CCL program. Many of the new checks are whether XINT (x)
2960 fits in int; it doesn't always, on 64-bit hosts. The new version
2961 doesn't catch all possible integer overflows, but it's an
847044ea 2962 improvement. (Bug#8719)
30569699 2963
c11285dc
PE
2964 * alloc.c (make_event_array): Use XINT, not XUINT.
2965 There's no need for unsigned here.
2966
fdccd48e
PE
2967 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
2968 This follows up to the 2011-05-06 change that substituted uintptr_t
2969 for EMACS_INT. This case wasn't caught back then.
2970
37910ab2
PE
2971 Rework Fformat to avoid integer overflow issues.
2972 * editfns.c: Include <float.h> unconditionally, as it's everywhere
2973 now (part of C89). Include <verify.h>.
2974 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
2975 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
2976 (Fformat): Avoid the prepass trying to compute sizes; it was only
2977 approximate and thus did not catch overflow reliably. Instead, walk
2978 through the format just once, formatting and computing sizes as we go,
2979 checking for integer overflow at every step, and allocating a larger
2980 buffer as needed. Keep track separately whether the format is
2981 multibyte. Keep only the most-recently calculated precision, rather
2982 than them all. Record whether each argument has been converted to
2983 string. Use EMACS_INT, not int, for byte and char and arg counts.
2984 Support field widths and precisions larger than INT_MAX. Avoid
2985 sprintf's undefined behavior with conversion specifications such as %#d
2986 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
2987 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
2988 formatting out-of-range floating point numbers with int
9173deec 2989 formats. (Bug#8668)
37910ab2 2990
2e6578fb
PE
2991 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
2992
0ae6bdee
PE
2993 * data.c: Avoid integer truncation in expressions involving floats.
2994 * data.c: Include <intprops.h>.
2995 (arith_driver): When there's an integer overflow in an expression
2996 involving floating point, convert the integers to floating point
2997 so that the resulting value does not suffer from catastrophic
2998 integer truncation. For example, on a 64-bit host (* 4
2999 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
3000 Do not rely on undefined behavior after integer overflow.
3001
de883a70
PE
3002 merge count_size_as_multibyte, parse_str_to_multibyte
3003 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 3004 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
3005 Check for integer overflow.
3006 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
3007 since it's now a duplicate of the other. This is more of
3008 a character than a buffer op, so better that it's in character.c.
3009 * fns.c, print.c: Adjust to above changes.
3010
2ff916cb
PE
30112011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
3012
3013 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
3014
f1b54466
PE
30152011-05-27 Paul Eggert <eggert@cs.ucla.edu>
3016
fb1ac845
PE
3017 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3018 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
3019 (x_clipboard_manager_save): Now static.
3020 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
3021
f1b54466
PE
3022 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
3023 (crypto_hash_function): Now static.
3024 Fix pointer signedness problems. Avoid unnecessary initializations.
3025
a9f737ee
CY
30262011-05-27 Chong Yidong <cyd@stupidchicken.com>
3027
3028 * termhooks.h (Vselection_alist): Make it terminal-local.
3029
3030 * terminal.c (create_terminal): Initialize it.
3031
3032 * xselect.c: Support for clipboard managers.
3033 (Vselection_alist): Move to termhooks.h as terminal-local var.
3034 (LOCAL_SELECTION): New macro.
3035 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
3036 (symbol_to_x_atom): Remove gratuitous arg.
3037 (x_handle_selection_request, lisp_data_to_selection_data)
3038 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
3039 (x_own_selection, x_get_local_selection, x_convert_selection):
3040 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
3041 (some_frame_on_display): Delete unused function.
3042 (Fx_own_selection_internal, Fx_get_selection_internal)
3043 (Fx_disown_selection_internal, Fx_selection_owner_p)
3044 (Fx_selection_exists_p): New optional frame arg.
3045 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
3046 (x_handle_selection_clear): Don't treat other terminals with the
3047 same keyboard specially. Use the terminal-local Vselection_alist.
3048 (x_clear_frame_selections): Use Frun_hook_with_args.
3049
3050 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
3051
3052 * xterm.h: Add support for those atoms.
3053
e067f0c1
CY
30542011-05-26 Chong Yidong <cyd@stupidchicken.com>
3055
3056 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
3057 (converted_selections, conversion_fail_tag): New global variables.
3058 (x_selection_request_lisp_error): Free the above.
3059 (x_get_local_selection): Remove unnecessary code.
3060 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
3061 of converted selections stored in converted_selections.
3062 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
3063 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
3064 (x_convert_selection): New function.
3065 (x_handle_selection_event): Simplify.
3066 (x_get_foreign_selection): Don't ignore incoming requests while
3067 waiting for an answer; this will fail when we implement
3068 SAVE_TARGETS, and seems unnecessary anyway.
3069 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
3070 (Vx_sent_selection_functions): Doc fix.
3071
0f4aebc0
LL
30722011-05-26 Leo Liu <sdl.web@gmail.com>
3073
3074 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
3075
e61124cd
YM
30762011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3077
3078 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
3079
3080 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
3081 for fringe update if it has periodic bitmap.
ac389d0c 3082 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
3083 and fringe_bitmap_periodic_p.
3084
3085 * fringe.c (get_fringe_bitmap_data): New function.
3086 (draw_fringe_bitmap_1, update_window_fringes): Use it.
3087 (update_window_fringes): Record periodicity of fringe bitmap in glyph
3088 row. Mark glyph row for fringe update if periodicity changed.
3089
3090 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
3091 for fringe update unless it has periodic bitmap.
3092
f16d9837
KH
30932011-05-25 Kenichi Handa <handa@m17n.org>
3094
3095 * xdisp.c (get_next_display_element): Set correct it->face_id for
3096 a static composition.
3097
e1b90ef6
LL
30982011-05-24 Leo Liu <sdl.web@gmail.com>
3099
3100 * deps.mk (fns.o):
3101 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
3102
3103 * fns.c (crypto_hash_function, Fsha1): New function.
3104 (Fmd5): Use crypto_hash_function.
3105 (syms_of_fns): Add Ssha1.
3106
7400048f
PE
31072011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 * gnutls.c: Remove unused macros.
3110 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
3111 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
3112 Remove macros that are defined and never used.
3113 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
3114
abb71cf4
CY
31152011-05-22 Chong Yidong <cyd@stupidchicken.com>
3116
3117 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
3118 (Fx_get_selection_internal): Minor cleanup.
3119 (Fx_own_selection_internal): Rename arguments for consistency with
3120 select.el.
3121
6307db39
PE
31222011-05-22 Paul Eggert <eggert@cs.ucla.edu>
3123
3124 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
3125
f3d4e0a4
CY
31262011-05-22 Chong Yidong <cyd@stupidchicken.com>
3127
3128 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
3129
4d8ade89
YM
31302011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3131
3132 * dispnew.c (scrolling_window): Don't exclude the case that the
3133 last enabled row in the desired matrix touches the bottom boundary.
3134
32078c8d
GM
31352011-05-21 Glenn Morris <rgm@gnu.org>
3136
3137 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
3138 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
3139 and add some more files.
32078c8d 3140
7285dc67
EZ
31412011-05-20 Eli Zaretskii <eliz@gnu.org>
3142
3143 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
3144 report_file_error introduced by the change from 2011-05-07.
3145
89d1bd22
PE
31462011-05-20 Paul Eggert <eggert@cs.ucla.edu>
3147
3148 * systime.h (Time): Define only if emacs is defined.
3149 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
3150 where the include path doesn't have X11/X.h by default. See
3151 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
3152
e23640bb 31532011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
3154
3155 * composite.c (find_automatic_composition): Fix previous change.
3156
b9704ad9
GM
31572011-05-20 Glenn Morris <rgm@gnu.org>
3158
3159 * lisp.mk: New file, split from Makefile.in.
3160 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
3161 (shortlisp): Remove.
3162 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
3163
4a720484
GM
31642011-05-19 Glenn Morris <rgm@gnu.org>
3165
3166 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
3167 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
3168 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
3169 (lisp): Set the order to that of loadup.el.
3170 (shortlisp): Make it a copy of $lisp.
3171 (SOME_MACHINE_LISP): Remove.
3172 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
3173 Use just $shortlisp, not $SOME_MACHINE_LISP too.
3174
a28d4396
KH
31752011-05-18 Kenichi Handa <handa@m17n.org>
3176
3177 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
3178 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
3179 (find_automatic_composition): Mostly rewrite for efficiency.
3180
a2b1fa8e
JB
31812011-05-18 Juanma Barranquero <lekktu@gmail.com>
3182
3183 * makefile.w32-in: Update dependencies.
3184
8e1f5610
CS
31852011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
3186
3187 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 3188 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 3189
7025ee00 31902011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 3191
cdfa6eab
PE
3192 Fix some integer overflow issues, such as string length overflow.
3193
06d6db33
PE
3194 * insdel.c (count_size_as_multibyte): Check for string overflow.
3195
2b4560a8
PE
3196 * character.c (lisp_string_width): Check for string overflow.
3197 Use EMACS_INT, not int, for string indexes and lengths; in
3198 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
3199 the resulting string length overflows an EMACS_INT; instead,
3200 report a string overflow if no precision given. When checking for
3201 precision exhaustion, use a check that cannot possibly have
3202 integer overflow. (Bug#8675)
3203 * character.h (lisp_string_width): Adjust to new signature.
3204
cb93f9be
PE
3205 * alloc.c (string_overflow): New function.
3206 (Fmake_string): Use it. This doesn't change behavior, but saves
3207 a few bytes and will simplify future changes.
3208 * character.c (string_escape_byte8): Likewise.
3209 * lisp.h (string_overflow): New decl.
3210
1a1f3366
PE
3211 Fixups, following up to the user-interface timestamp change.
3212 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
3213 for UI timestamps, instead of unsigned long.
9fbd6841
PE
3214 * msdos.c (mouse_get_pos): Likewise.
3215 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
3216 * w32gui.h (Time): Define by including "systime.h" rather than by
3217 declaring it ourselves. (Bug#8664)
3218
d4e3e4d3
PE
3219 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
3220 * image.c (clear_image_cache): Likewise.
3221
f6a24d19
PE
3222 * term.c (term_mouse_position): Don't assume time_t wraparound.
3223
08dc5ae6
PE
3224 Be more systematic about user-interface timestamps.
3225 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
3226 and sometimes 'EMACS_UINT', to represent these timestamps.
3227 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
3228 This makes the code easier to follow, and makes it easier to catch
3229 integer overflow bugs such as Bug#8664.
3230 * frame.c (Fmouse_position, Fmouse_pixel_position):
3231 Use Time, not unsigned long, for user-interface timestamps.
3232 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
3233 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
3234 * keyboard.h (last_event_timestamp): Likewise.
3235 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
3236 * menu.h (xmenu_show): Likewise.
3237 * term.c (term_mouse_position): Likewise.
3238 * termhooks.h (struct input_event.timestamp): Likewise.
3239 (struct terminal.mouse_position_hook): Likewise.
3240 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
3241 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
3242 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
3243 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
3244 what it was before.
3245 * menu.h, termhooks.h: Include "systime.h", for Time.
3246
8e55734a
PE
3247 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
3248 Don't assume that the difference between two unsigned long values
3249 can fit into an integer. At this point, we know button_down_time
3250 <= event->timestamp, so the difference must be nonnegative, so
3251 there's no need to cast the result if double-click-time is
3252 nonnegative, as it should be; check that it's nonnegative, just in
3253 case. This bug is triggered when events are more than 2**31 ms
86db42d2 3254 apart (about 25 days). (Bug#8664)
8e55734a 3255
841f1b75 3256 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 3257 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 3258
3e26f69c
PE
3259 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
3260 that always fit in int. Use a sentinel instead of a counter, to
3261 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
3262 * frame.h (struct frame): Use int for menu_bar_items_used
3263 instead of EMACS_INT, since it always fits in int.
3e26f69c 3264
5cc152c0
PE
3265 * menu.c (grow_menu_items): Check for int overflow.
3266
d89eb65e
PE
3267 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
3268
5235bd3e
PE
3269 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
3270 Before, the code was not consistent. These values cannot exceed
3271 2**31 - 1 so there's no need to make them unsigned.
3272 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
3273 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
3274 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
3275 as modifiers.
3276 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
3277
bc827e23
PE
3278 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
3279 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
3280 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
3281 presumably because the widths might not match.
3282
78eb494e
PE
3283 * window.c (size_window): Avoid needless test at loop start.
3284
04f2d78b
CB
32852011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
3286
3287 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
3288
d2fc7e3d 32892011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
3290
3291 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
3292
d2fc7e3d 32932011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
3294
3295 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
3296 `width' to `bar_area_x' and `bar_area_width', respectively.
3297 (x_scroll_run): Take account of fringe background extension.
3298
04f2d78b
CB
3299 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
3300 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
3301 `bar_area_width', respectively.
3302 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
3303 background extension.
3304
79b70037
GM
33052011-05-10 Jim Meyering <meyering@redhat.com>
3306
3307 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
3308
2f142cc5
JB
33092011-05-10 Juanma Barranquero <lekktu@gmail.com>
3310
3311 * image.c (Finit_image_library): Return t for built-in image types,
3312 like pbm and xbm. (Bug#8640)
3313
57679c86
AS
33142011-05-09 Andreas Schwab <schwab@linux-m68k.org>
3315
3316 * w32menu.c (set_frame_menubar): Fix submenu allocation.
3317
888c9e86
EZ
33182011-05-07 Eli Zaretskii <eliz@gnu.org>
3319
b0512a1d
EZ
3320 * w32console.c (Fset_screen_color): Doc fix.
3321 (Fget_screen_color): New function.
3322 (syms_of_ntterm): Defsubr it.
3323
7285dc67
EZ
3324 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
3325 unlink the temporary file if Fcall_process didn't create it in the
3326 first place.
3327 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
3328 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
3329 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
3330 cue to call_process_cleanup not to close that handle.
3331
4d3fcc8e
BK
33322011-05-07 Ben Key <bkey76@gmail.com>
3333
3334 * makefile.w32-in: The bootstrap-temacs rule now makes use of
3335 one of two shell specific rules, either bootstrap-temacs-CMD or
3336 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
3337 to the previous implementation of the bootstrap-temacs rule.
3338 The bootstrap-temacs-CMD rule is similar to the previous
3339 implementation of the bootstrap-temacs rule except that it
3340 makes use of the ESC_CFLAGS variable instead of the CFLAGS
3341 variable.
3342
3343 These changes, along with some changes to nt/configure.bat,
3344 nt/gmake.defs, and nt/nmake.defs, are required to extend my
3345 earlier fix to add support for --cflags and --ldflags options
3346 that include quotes so that it works whether make uses cmd or
3347 sh as the shell.
3348
b4289b64
MA
33492011-05-06 Michael Albinus <michael.albinus@gmx.de>
3350
3351 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
3352 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
3353 is a constant.
3354 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
3355 a string. Handle both cases.
3356 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
3357 (Fdbus_register_method): Use Qinvalid_function.
3358
af4c0e28
JB
33592011-05-06 Juanma Barranquero <lekktu@gmail.com>
3360
3361 * makefile.w32-in: Update dependencies.
3362 (LISP_H): Add inttypes.h and stdin.h.
3363 (PROCESS_H): Add unistd.h.
3364
c51453d9
EZ
33652011-05-06 Eli Zaretskii <eliz@gnu.org>
3366
3367 * lread.c: Include limits.h (fixes the MS-Windows build broken by
3368 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
3369
8ff0ac3c 33702011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 3371
4c4b566b
PE
3372 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
3373
aab2b9b5
PE
3374 * term.c (vfatal): Remove stray call to va_end.
3375 It's not needed and the C Standard doesn't allow it here anyway.
3376
c378da0b
PE
3377 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
3378 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
3379
288b08c7
PE
3380 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
3381 bytes.
3382
e3601888
PE
3383 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
3384
db6c0e74
PE
3385 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3386
dd5963ea
PE
3387 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
3388
88c9450f
PE
3389 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
3390
2f9442b8
PE
3391 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
3392
c032b5f8
PE
3393 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
3394 * charset.c (Fdefine_charset_internal): Don't initialize
3395 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 3396 32-bit int (Bug#8600).
a108c10b
PE
3397
3398 * lread.c (read_integer): Be more consistent with string-to-number.
3399 Use string_to_number to do the actual conversion; this avoids
3400 rounding errors and fixes some other screwups. Without this fix,
3401 for example, #x1fffffffffffffff was misread as -2305843009213693952.
3402 (digit_to_number): Move earlier, for benefit of read_integer.
3403 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 3404 not a digit in any supported base. (Bug#8602)
a108c10b 3405
ad5f9eea
PE
3406 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
3407
aec1708a
PE
3408 * dispnew.c (scrolling_window): Return 1 if we scrolled,
3409 to match comment at start of function. This also removes a
3410 GCC warning about overflow in a 32+64-bit port.
3411
47be4ab5
PE
3412 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
3413
371cac43
PE
3414 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
3415 Reported by Stefan Monnier in
3416 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
3417 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3418 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 3419
d01a7826
PE
3420 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
3421 (EMACS_UINTPTR): Likewise, with uintptr_t.
3422
7fd47d5c
PE
3423 * lisp.h: Prefer 64-bit EMACS_INT if available.
3424 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
3425 on 32-bit hosts that have 64-bit int, so that they can access
3426 large files.
122b0c86
PE
3427 However, temporarily disable this change unless the temporary
3428 symbol WIDE_EMACS_INT is defined.
7fd47d5c 3429
8727937b
PE
3430 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
3431
8ac068ac
PE
3432 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
3433 This removes an assumption that EMACS_INT and long are the same
3434 width as pointers. The assumption is true for Emacs porting targets
3435 now, but we want to make other targets possible.
3436 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
3437 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
3438 In the rest of the code, change types of integers that hold casted
3439 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
3440 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
3441 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
3442 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
3443 No need to cast type when ORing.
3444 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
3445 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
3446 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
3447 assume EMACS_INT is the same width as char *.
3448 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
3449 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
3450 Remove no-longer-needed casts.
3451 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
3452 (xg_tool_bar_help_callback, xg_make_tool_item):
3453 Use EMACS_INTPTR to hold an integer
3454 that will be cast to void *; this can avoid a GCC warning
3455 if EMACS_INT is not the same width as void *.
3456 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
3457 * xdisp.c (display_echo_area_1, resize_mini_window_1):
3458 (current_message_1, set_message_1):
3459 Use a local to convert to proper width without a cast.
3460 * xmenu.c (dialog_selection_callback): Likewise.
3461
ede49d71
PE
3462 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
3463 Also, don't assume VALBITS / RAND_BITS is less than 5,
3464 and don't rely on undefined behavior when shifting a 1 left into
3465 the sign bit.
3466 * lisp.h (get_random): Change signature to match.
3467
2f30ecd0
PE
3468 * lread.c (hash_string): Use size_t, not int, for hash computation.
3469 Normally we prefer signed values; but hashing is special, because
3470 it's better to use unsigned division on hash table sizes so that
3471 the remainder is nonnegative. Also, size_t is the natural width
3472 for hashing into memory. The previous code used 'int', which doesn't
3473 retain enough info to hash well into very large tables.
3474 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
3475
2a866e7b
PE
3476 * dbusbind.c: Don't possibly lose pointer info when converting.
3477 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
3478 Use XPNTR rather than XHASH, so that the high-order bits of
3479 the pointer aren't lost when converting through void *.
3480
51639eac
PE
3481 * eval.c (Fautoload): Don't double-shift a pointer.
3482
92394119
PE
3483 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
3484
dbdb9a7c
JB
34852011-05-06 Juanma Barranquero <lekktu@gmail.com>
3486
3487 * gnutls.c (DEF_GNUTLS_FN):
3488 * image.c (DEF_IMGLIB_FN): Make function pointers static.
3489
db7a0b4f
AS
34902011-05-05 Andreas Schwab <schwab@linux-m68k.org>
3491
3492 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
3493 marker. (Bug#8610)
3494
f7ff1b0f 34952011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
3496
3497 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
3498 New version that can reserve upto 2GB of heap space.
3499
f7ff1b0f 35002011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
3501
3502 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
3503
639c109b
TZ
35042011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
3505
3506 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
3507 `gnutls_certificate_set_x509_key_file'.
3508
d2127135
JB
35092011-05-05 Juanma Barranquero <lekktu@gmail.com>
3510
3511 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
3512 Update dependencies.
3513
e968f4f3
JB
35142011-05-04 Juanma Barranquero <lekktu@gmail.com>
3515
3516 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
3517 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3518 Remove unused parameter `fildes'.
3519 * process.c (read_process_output, send_process): Don't pass it.
3520
84d358f0
JB
35212011-05-04 Juanma Barranquero <lekktu@gmail.com>
3522
3523 Fix previous change: the library cache is defined in w32.c.
3524 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
3525 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
3526
0898ca10
JB
35272011-05-04 Juanma Barranquero <lekktu@gmail.com>
3528
3529 Implement dynamic loading of GnuTLS on Windows.
3530
3531 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
3532 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
3533 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3534 Declare.
3535
3536 * gnutls.c (Qgnutls_dll): Define.
3537 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
3538 (gnutls_*): Declare function pointers.
3539 (init_gnutls_functions): New function to initialize function pointers.
3540 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
3541 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
3542 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
3543 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
3544 (emacs_gnutls_write, emacs_gnutls_read)
3545 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
3546 (Fgnutls_available_p): New function.
3547 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
3548 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
3549 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
3550
3551 * image.c: Include w32.h.
3552 (Vimage_type_cache): Delete.
3553 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
3554 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
3555 (w32_delayed_load): Move to w32.c.
3556
3557 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
3558
3559 * w32.c (QCloaded_from, Vlibrary_cache): Define.
3560 (w32_delayed_load): Move from image.c. When loading a library, record
3561 its filename in the :loaded-from property of the library id.
3562 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
3563 Initialize and staticpro them.
3564 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
3565
3566 * process.c: Include lisp.h before w32.h, not after.
3567 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
3568 instead of gnutls_record_check_pending.
3569
3570 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
3571
ff4de4aa
TZ
35722011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
3573
3574 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
3575 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
3576 as passed in.
3577
abe95abb
JD
35782011-05-03 Jan Djärv <jan.h.d@swipnet.se>
3579
3580 * xterm.c (x_set_frame_alpha): Do not set property on anything
3581 else than FRAME_X_OUTER_WINDOW (Bug#8608).
3582
e16e55d4
JB
35832011-05-02 Juanma Barranquero <lekktu@gmail.com>
3584
3585 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
3586
bafcf6a5
JB
35872011-05-02 Juanma Barranquero <lekktu@gmail.com>
3588
3589 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
3590 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
3591 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
3592 (gnutls_global_initialized, Qgnutls_bootprop_priority)
3593 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
3594 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
3595 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
3596 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
3597 (Qgnutls_bootprop_callbacks_verify): Make static.
3598
e7a6747f
AS
35992011-05-01 Andreas Schwab <schwab@linux-m68k.org>
3600
19ed11ba
AS
3601 * callproc.c: Indentation fixup.
3602
e7a6747f 3603 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
3604 (wait_for_termination, interruptible_wait_for_termination):
3605 Move after wait_for_termination_1.
e7a6747f 3606
1ef14cb4
LMI
36072011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
3608
3609 * sysdep.c (interruptible_wait_for_termination): New function
3610 which is like wait_for_termination, but allows keyboard
3611 interruptions.
3612
3613 * callproc.c (Fcall_process): Add (:file "file") as an option for
3614 the STDOUT buffer.
3615 (Fcall_process_region): Ditto.
3616
330d880c
EZ
36172011-04-30 Eli Zaretskii <eliz@gnu.org>
3618
8db90b73
EZ
3619 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
3620 rather than `XVECTOR (FOO)->size'.
3621
330d880c
EZ
3622 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
3623 inttypes.h, as a gnulib replacement is used if it not available in
3624 system headers.
3625
15cbd324
EZ
36262011-04-21 Eli Zaretskii <eliz@gnu.org>
3627
3628 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
3629 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
3630 of MOST_POSITIVE_FIXNUM. (Bug#8528)
3631
3632 * coding.c (coding_alloc_by_realloc): Error out if destination
3633 will grow beyond MOST_POSITIVE_FIXNUM.
3634 (decode_coding_emacs_mule): Abort if there isn't enough place in
3635 charbuf for the composition carryover bytes. Reserve an extra
3636 space for up to 2 characters produced in a loop.
3637 (decode_coding_iso_2022): Abort if there isn't enough place in
3638 charbuf for the composition carryover bytes.
3639
36402011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 3641
ae940cca
EZ
3642 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
3643 aborting when %lld or %lll format is passed.
3644 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
3645 %llo or %llx format is passed. (Bug#8545)
3646
03ab8921
EZ
3647 * window.c (window_scroll_line_based): Use a marker instead of
3648 simple variables to record original value of point. (Bug#7952)
3649
afda1437
EZ
3650 * doprnt.c (doprnt): Fix the case where a multibyte sequence
3651 produced by %s or %c overflows available buffer space. (Bug#8545)
3652
f76dee0c
PE
36532011-04-28 Paul Eggert <eggert@cs.ucla.edu>
3654
3655 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 3656 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 3657
fdc5744d
JB
36582011-04-28 Juanma Barranquero <lekktu@gmail.com>
3659
3660 * w32.c (init_environment): Warn about defaulting HOME to C:\.
3661
638f053a
JB
36622011-04-28 Juanma Barranquero <lekktu@gmail.com>
3663
3664 * keyboard.c (Qdelayed_warnings_hook): Define.
3665 (command_loop_1): Run `delayed-warnings-hook'
3666 if Vdelayed_warnings_list is non-nil.
3667 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
3668 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
3669
d178f871
EZ
36702011-04-28 Eli Zaretskii <eliz@gnu.org>
3671
3672 * doprnt.c (doprnt): Don't return value smaller than the buffer
3673 size if the message was truncated. (Bug#8545).
3674
b124fd93
JB
36752011-04-28 Juanma Barranquero <lekktu@gmail.com>
3676
3677 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
3678 (Fx_window_property): #if-0 the whole functions, not just the bodies.
3679
e810457d
PE
36802011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3681
3682 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
3683
ea51cceb
JB
36842011-04-27 Juanma Barranquero <lekktu@gmail.com>
3685
3686 * makefile.w32-in: Update dependencies.
3687
94dcfacf
EZ
36882011-04-27 Eli Zaretskii <eliz@gnu.org>
3689
3690 Improve `doprnt' and its usage. (Bug#8545)
3691 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
3692 `format_end'. Remove support for %l as a conversion specifier.
3693 Don't use xrealloc. Improve diagnostics when the %l size modifier
3694 is used. Update the commentary.
3695
3696 * eval.c (verror): Simplify calculation of size_t.
3697
3698 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
3699 messages.
3700
f61f41d7
PE
37012011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
3702
3703 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
3704 change.
3705
96fb4434
PE
37062011-04-27 Paul Eggert <eggert@cs.ucla.edu>
3707
3708 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
3709 This makes this file independent of the recent pseudovector change.
3710
671875da 37112011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 3712
69e9b5a3
PE
3713 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
3714
b5f869a7 3715 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 3716 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 3717 Remove unused local.
c8926152 3718 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 3719
841a1577 3720 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
3721 GCC 4.6.0 optimizes based on type-based alias analysis.
3722 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
3723 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
3724 != &v->size, and therefore "v->size = 1; b->size = 2; return
3725 v->size;" must therefore return 1. This assumption is incorrect
3726 for Emacs, since it type-puns struct Lisp_Vector * with many other
3727 types. To fix this problem, this patch adds a new type struct
f904488f 3728 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
3729 and pseudovectors, and helps optimizing compilers not get fooled
3730 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
3731 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
3732 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
3733 the size member.
eab3844f
PE
3734 (XSETPVECTYPE): Rewrite in terms of new macro.
3735 (XSETPVECTYPESIZE): New macro, specifying both type and size.
3736 This is a bit clearer, and further avoids the possibility of
3737 undesirable aliasing.
3738 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 3739 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
3740 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
3741 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
3742 (ASIZE): Now uses header.size rather than size.
3743 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
3744 to avoid the hassle of writing XVECTOR (foo)->header.size.
3745 (struct vectorlike_header): New type.
eab3844f
PE
3746 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
3747 object, to help avoid aliasing.
3748 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
3749 (SUBRP): Likewise, since Lisp_Subr is a special case.
3750 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
3751 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
3752 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 3753 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
3754 changed to be "header.size" and "header.next".
3755 * buffer.h (struct buffer): Likewise.
3756 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
3757 * frame.h (struct frame): Likewise.
3758 * process.h (struct Lisp_Process): Likewise.
3759 * termhooks.h (struct terminal): Likewise.
3760 * window.c (struct save_window_data, struct saved_window): Likewise.
3761 * window.h (struct window): Likewise.
3762 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
3763 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
3764 * buffer.c (init_buffer_once): Likewise.
3765 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
3766 special case.
3767 * process.c (Fformat_network_address): Use local var for size,
3768 for brevity.
3769
0df1eac5
PE
3770 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
3771
847ab9d1 3772 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
3773 * data.c (atof): Remove decl; no longer used or needed.
3774 (digit_to_number): Move to lread.c.
3775 (Fstring_to_number): Use new string_to_number function, to be
3776 consistent with how the Lisp reader treats infinities and NaNs.
3777 Do not assume that floating-point numbers represent EMACS_INT
3778 without losing information; this is not true on most 64-bit hosts.
3779 Avoid double-rounding errors, by insisting on integers when
3780 parsing non-base-10 numbers, as the documentation specifies.
3781 * lisp.h (string_to_number): New decl, replacing ...
3782 (isfloat_string): Remove.
bc0a5c13 3783 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 3784 (read1): Do not accept +. and -. as integers; this
452f4150
PE
3785 appears to have been a coding error. Similarly, do not accept
3786 strings like +-1e0 as floating point numbers. Do not report
3787 overflow for integer overflows unless the base is not 10 which
3788 means we have no simple and reliable way to continue.
3789 Break out the floating-point parsing into a new
3790 function string_to_number, so that Fstring_to_number parses
3791 floating point numbers consistently with the Lisp reader.
04f2d78b 3792 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
3793 (E_CHAR, EXP_INT): Remove, replacing with ...
3794 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
3795 (string_to_number): New function, replacing isfloat_string.
3796 This function checks for valid syntax and produces the resulting
3797 Lisp float number too. Rework it so that string-to-number
bc0a5c13 3798 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
3799 so that overflow for non-base-10 numbers is reported only when
3800 there's no portable and simple way to convert to floating point.
452f4150 3801
67769ffc
PE
3802 * textprop.c (set_text_properties_1): Rewrite for clarity,
3803 and to avoid GCC warning about integer overflow.
3804
c20db43f
PE
3805 * intervals.h (struct interval): Use EMACS_INT for members
3806 where EMACS_UINT might cause problems. See
3807 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
3808 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
3809 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
3810 All uses changed.
37aa2f85
PE
3811 (offset_intervals): Tell GCC not to worry about length overflow
3812 when negating a negative length.
c20db43f 3813
2538aa2f
PE
3814 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
3815 (overrun_check_free): Likewise.
3816
f2d3008d
PE
3817 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
3818 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
3819 word size.
3820
ec8df744
PE
3821 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3822 (gnutls_make_error): Rename local to avoid shadowing.
3823 (gnutls_emacs_global_deinit): ifdef out; not used.
3824 (Fgnutls_boot): Use const for pointer to readonly storage.
3825 Comment out unused local. Fix pointer signedness problems.
3826
640ee02d
PE
3827 * lread.c (openp): Don't stuff size_t into an 'int'.
3828 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
3829 about possible signed overflow.
3830
6048fb2a
PE
3831 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
3832 (GDK_KEY_g): Don't define if already defined.
3833 (xg_prepare_tooltip): Avoid pointer signedness problem.
3834 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
3835
fa3c87e1
PE
3836 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
3837 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
3838
2172544b
PE
3839 * xfns.c (Fx_window_property): Simplify a bit,
3840 to make a bit faster and to avoid GCC 4.6.0 warning.
3841 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
3842
9b821a21
PE
3843 * fns.c (internal_equal): Don't assume size_t fits in int.
3844
3c616cfa
PE
3845 * alloc.c (compact_small_strings): Tighten assertion a little.
3846
c2982e87
PE
3847 Replace pEd with more-general pI, and fix some printf arg casts.
3848 * lisp.h (pI): New macro, generalizing old pEd macro to other
3849 conversion specifiers. For example, use "...%"pI"d..." rather
3850 than "...%"pEd"...".
3851 (pEd): Remove. All uses replaced with similar uses of pI.
3852 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
3853 * alloc.c (check_pure_size): Don't overflow by converting size to int.
3854 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
3855 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
3856 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
3857 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
3858 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
3859 64-bit hosts.
3860 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
3861 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
3862 * print.c (safe_debug_print, print_object): Likewise.
3863 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
3864 to int.
6f04d126
PE
3865 Use pI instead of if-then-else-abort. Use %p to avoid casts,
3866 avoiding the 0 flag, which is not portable.
c2982e87
PE
3867 * process.c (Fmake_network_process): Use pI to avoid cast.
3868 * region-cache.c (pp_cache): Likewise.
3869 * xdisp.c (decode_mode_spec): Likewise.
3870 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
3871 behavior on 64-bit hosts with printf arg.
6f04d126 3872 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
3873 (x_stop_queuing_selection_requests): Likewise.
3874 (x_get_window_property): Don't truncate byte count to an 'int'
3875 when tracing.
0b432f21 3876
5e073ec7
PE
3877 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
3878 here, since it parses constructs like leading '-' and spaces,
3879 which are not wanted; and it overflows with large numbers.
3880 Instead, simply match F[0-9]+, which is what is wanted anyway.
3881
36372bf9
PE
3882 * alloc.c: Remove unportable assumptions about struct layout.
3883 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
3884 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
3885 (allocate_vectorlike, make_pure_vector): Use the new macros,
3886 plus offsetof, to remove unportable assumptions about struct layout.
3887 These assumptions hold on all porting targets that I know of, but
3888 they are not guaranteed, they're easy to remove, and removing them
3889 makes further changes easier.
3890
0b432f21
PE
3891 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
3892 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
3893 (string_overrun_cookie): Now const. Use initializers that
3894 don't formally overflow signed char, to avoid warnings.
000098c1
PE
3895 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
3896 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
3897 (allocate_buffer): Don't assume sizeof (struct buffer) is a
3898 multiple of sizeof (EMACS_INT); it need not be, if
3899 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 3900 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 3901
895009e1
JB
39022011-04-26 Juanma Barranquero <lekktu@gmail.com>
3903
3904 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
3905
6a7a1b0b
TZ
39062011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
3907
3908 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 3909 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
3910 Reported by Paul Eggert <eggert@cs.ucla.edu>.
3911
841a1577 39122011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
3913
3914 * lisp.h (Qdebug): List symbol.
895009e1 3915 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
3916 * keyboard.c (debug-on-event): New variable.
3917 (handle_user_signal): Break into debugger when debug-on-event
3918 matches the current signal symbol.
3919
f2d3ba6f
DN
39202011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
3921
3922 * alloc.c (check_sblock, check_string_bytes)
3923 (check_string_free_list): Convert to standard C.
3924
42ce4c63
TZ
39252011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
3926
3927 * w32.c (emacs_gnutls_push): Fix typo.
3928
825cd63c
EZ
39292011-04-25 Eli Zaretskii <eliz@gnu.org>
3930
fb11d64d
EZ
3931 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
3932 "cast to pointer from integer of different size".
3933
825cd63c
EZ
3934 Improve doprnt and its use in verror. (Bug#8545)
3935 * doprnt.c (doprnt): Document the set of format control sequences
3936 supported by the function. Use SAFE_ALLOCA instead of always
3937 using `alloca'.
3938
3939 * eval.c (verror): Don't limit the buffer size at size_max-1, that
3940 is one byte too soon. Don't use xrealloc; instead xfree and
3941 xmalloc anew.
3942
e061a11b
TZ
39432011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
3944
3945 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
3946 callbacks stage.
3947
3948 * gnutls.c: Renamed global_initialized to
3949 gnutls_global_initialized. Added internals for the
3950 :verify-hostname-error, :verify-error, and :verify-flags
3951 parameters of `gnutls-boot' and documented those parameters in the
3952 docstring. Start callback support.
9173deec
JB
3953 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
3954 unless a fatal error occurred. Call gnutls_alert_send_appropriate
3955 on error. Return error code.
e061a11b
TZ
3956 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
3957 (emacs_gnutls_read): Likewise.
3958 (Fgnutls_boot): Return handshake error code.
3959 (emacs_gnutls_handle_error): New function.
3960 (wsaerror_to_errno): Likewise.
3961
3962 * w32.h (emacs_gnutls_pull): Add prototype.
3963 (emacs_gnutls_push): Likewise.
3964
3965 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
3966 (emacs_gnutls_push): Likewise.
3967
39682011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
3969
3970 * process.c (wait_reading_process_output): Check if GnuTLS
3971 buffered some data internally if no FDs are set for TLS
3972 connections.
3973
3974 * makefile.w32-in (OBJ2): Add gnutls.$(O).
3975 (LIBS): Link to USER_LIBS.
3976 ($(BLD)/gnutls.$(0)): New target.
3977
fa6996bc
EZ
39782011-04-24 Eli Zaretskii <eliz@gnu.org>
3979
eb35682e
EZ
3980 * xdisp.c (handle_single_display_spec): Rename the
3981 display_replaced_before_p argument into display_replaced_p, to
3982 make it consistent with the commentary. Fix typos in the
3983 commentary.
3984
e2ad650c
EZ
3985 * textprop.c (syms_of_textprop): Remove dead code.
3986 (copy_text_properties): Delete obsolete commentary about an
3987 interface that was deleted long ago. Fix typos in the description
3988 of arguments.
3989
1b2de274
EZ
3990 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
3991 to changes in oldXMenu/XMenu.h from 2011-04-16.
3992 <menu_help_message, prev_menu_help_message>: Constify.
3993 (IT_menu_make_room): menu->help_text is now `const char **';
3994 adjust.
3995
3996 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
3997 to changes in oldXMenu/XMenu.h from 2011-04-16.
3998 (struct XMenu): Declare `help_text' `const char **'.
3999
4000 * xfaces.c <Qunspecified>: Make extern again.
4001
4002 * syntax.c: Include sys/types.h before including regex.h, as
4003 required by Posix.
4004
762b15be
EZ
4005 * doc.c (get_doc_string): Improve the format passed to `error'.
4006
4007 * doprnt.c (doprnt): Improve commentary.
4008
4009 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
4010
4011 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
4012 them with etags.
4013
f1052e5d
EZ
4014 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
4015 changes in globals.h immediately force recompilation.
762b15be
EZ
4016 (TAGS): Depend on $(CURDIR)/m/intel386.h and
4017 $(CURDIR)/s/ms-w32.h.
4018 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 4019
fa6996bc
EZ
4020 * character.c (Fchar_direction): Function deleted.
4021 (syms_of_character): Don't defsubr it.
4022 <char-direction-table>: Deleted.
4023
e6c3da20
EZ
40242011-04-23 Eli Zaretskii <eliz@gnu.org>
4025
4026 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
4027 * doprnt.c: Include limits.h.
4028 (SIZE_MAX): New macro.
04f2d78b
CB
4029 (doprnt): Return a size_t value. 2nd arg is now size_t.
4030 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
4031 Improve overflow protection. Support `l' modifier for integer
4032 conversions. Support %l conversion. Don't assume an EMACS_INT
4033 argument for integer conversions and for %c.
4034
4035 * lisp.h (doprnt): Restore prototype.
4036
4037 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
4038 $(SRC)/character.h.
4039
4040 * Makefile.in (base_obj): Add back doprnt.o.
4041
4042 * deps.mk (doprnt.o): Add back prerequisites.
4043 (callint.o): Depend on character.h.
4044
4045 * eval.c (internal_lisp_condition_case): Include the handler
4046 representation in the error message.
4047 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
4048 when breaking from the loop.
4049
4050 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
4051
4052 * callint.c (Fcall_interactively): When displaying error message
4053 about invalid control letter, pass the character's codepoint, not
4054 a pointer to its multibyte form. Improve display of the character
4055 in octal and display also its hex code.
4056
4057 * character.c (char_string): Use %x to display the (unsigned)
4058 codepoint of an invalid character, to avoid displaying a bogus
4059 negative value.
4060
4061 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
4062 `error', not SYMBOL_NAME itself.
4063
4064 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
4065 character arguments to `error'.
4066
4067 * charset.c (check_iso_charset_parameter): Fix incorrect argument
4068 to `error' in error message about FINAL_CHAR argument. Make sure
4069 FINAL_CHAR is a character, and use %c when it is passed as
4070 argument to `error'.
4071
4ffd0d6b 40722011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
4073
4074 * s/ms-w32.h (localtime): Redirect to sys_localtime.
4075
4076 * w32.c: Include <time.h>.
4077 (sys_localtime): New function.
4078
4ffd0d6b 40792011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
4080
4081 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
4082
4ffd0d6b 4083 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 4084
4ffd0d6b 40852011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 4086
4ffd0d6b
GM
4087 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
4088 zombies (Bug#8467).
aac0c6e3 4089
04c56954
EZ
40902011-04-19 Eli Zaretskii <eliz@gnu.org>
4091
4092 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
4093 gl_state.e_property when gl_state.object is Qt.
4094
4095 * insdel.c (make_gap_larger): Remove limitation of buffer size
4096 to <= INT_MAX.
4097
16a43933
CY
40982011-04-18 Chong Yidong <cyd@stupidchicken.com>
4099
4100 * xdisp.c (lookup_glyphless_char_display)
4101 (produce_glyphless_glyph): Handle cons cell entry in
4102 glyphless-char-display.
4103 (Vglyphless_char_display): Document it.
4104
4105 * term.c (produce_glyphless_glyph): Handle cons cell entry in
4106 glyphless-char-display.
4107
4581706e
CY
41082011-04-17 Chong Yidong <cyd@stupidchicken.com>
4109
4110 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
4111
4112 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
4113
4114 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
4115 definition for no-X builds.
4116
4887c6e2 41172011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 4118
fd35b6f9
PE
4119 Static checks with GCC 4.6.0 and non-default toolkits.
4120
5c1ccb01
PE
4121 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
4122
006c5daa
PE
4123 * process.c (keyboard_bit_set): Define only if SIGIO.
4124 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
4125 (send_process): Repair possible setjmp clobbering.
4126
efc736d3
PE
4127 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
4128
4e2fe2e6
PE
4129 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
4130
f97334a2
PE
4131 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
4132
4e75f29d
PE
4133 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
4134 Define only if needed.
4135
90efadd1
PE
4136 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
4137 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 4138 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 4139
3c647824
PE
4140 * dispextern.h (struct redisplay_interface): Rename param
4141 to avoid shadowing.
e264f262 4142 * termhooks.h (struct terminal): Likewise.
761383f4 4143 * xterm.c (xembed_send_message): Likewise.
3c647824 4144
b58c5c4a
PE
4145 * insdel.c (make_gap_smaller): Define only if
4146 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
4147
cad59032
PE
4148 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
4149 it.
4150
c339dc2e
PE
4151 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
4152 so that we aren't warned about unused symbols.
4153
91a3e27b
PE
4154 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
4155
399c71d3 4156 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 4157
8ffc96f5
PE
4158 * xfns.c (x_real_positions): Mark locals as initialized.
4159
eef9bc79
PE
4160 * xmenu.c (xmenu_show): Don't use uninitialized vars.
4161
098db9dd
PE
4162 * xterm.c: Fix problems found by static analysis with other toolkits.
4163 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
4164 (x_dispatch_event): Declare static if USE_GTK, and
4165 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 4166 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 4167 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
4168 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
4169 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 4170
eb18f6cc
PE
4171 * xmenu.c (menu_help_callback): Pointer type fixes.
4172 Use const pointers when pointing at readonly data. Avoid pointer
4173 signedness clashes.
4174 (FALSE): Remove unused macro.
4175 (update_frame_menubar): Remove unused decl.
4176
1fe72bf8
PE
4177 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
4178
60d9e1db
PE
4179 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
4180 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
4181 (single_menu_item): Rename local to avoid shadowing.
4182
39261c26
PE
4183 * keyboard.c (make_lispy_event): Remove unused local var.
4184
018c5e19
PE
4185 * frame.c, frame.h (x_get_resource_string): Bring this back, but
4186 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
4187
63d2b86e
PE
4188 * bitmaps: Change bitmaps from unsigned char back to the X11
4189 compatible char. Avoid the old compiler warnings about
4190 out-of-range initializers by using, for example, '\xab' rather
4191 than 0xab.
4192
aefd87e1
PE
4193 * xgselect.c (xgselect_initialize): Check vs interface
4194 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
4195
bf501fb9
PE
4196 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
4197
e9829fdf
PE
4198 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
4199 to read-only memory.
4200
1086c095
PE
4201 * fns.c (vector): Remove; this old hack is no longer needed.
4202
2baccd04 4203 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 4204 Remove unused var.
dde42981 4205 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 4206
72391843 4207 * xrdb.c (x_load_resources): Omit unused local.
3565b346 4208
436c16df 4209 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 4210 (x_window): Rename locals to avoid shadowing.
dc5ddd85 4211 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 4212
92bb796d 4213 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 4214 (x_term_init): Remove local to avoid shadowing.
92bb796d 4215
764430a3 4216 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
4217
4218 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
4219 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
4220
d1dfb56c
EZ
42212011-04-16 Eli Zaretskii <eliz@gnu.org>
4222
c4354cb4
EZ
4223 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
4224
d1dfb56c
EZ
4225 Fix regex.c, syntax.c and friends for buffers > 2GB.
4226 * syntax.h (struct gl_state_s): Declare character position members
4227 EMACS_INT.
4228
4229 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
4230
04f2d78b
CB
4231 * textprop.c (verify_interval_modification, interval_of):
4232 Declare arguments EMACS_INT.
d1dfb56c
EZ
4233
4234 * intervals.c (adjust_intervals_for_insertion): Declare arguments
4235 EMACS_INT.
4236
4237 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
4238
4239 * indent.c (Fvertical_motion): Local variable it_start is now
4240 EMACS_INT.
4241
4242 * regex.c (re_match, re_match_2, re_match_2_internal)
4243 (bcmp_translate, regcomp, regexec, print_double_string)
4244 (group_in_compile_stack, re_search, re_search_2, regex_compile)
4245 (re_compile_pattern, re_exec): Declare arguments and local
4246 variables `size_t' and `ssize_t' and return values `regoff_t', as
4247 appropriate.
4248 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
4249 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
4250 <compile_stack_type>: `size' and `avail' are now `size_t'.
4251
4252 * regex.h <regoff_t>: Use ssize_t, not int.
4253 (re_search, re_search_2, re_match, re_match_2): Arguments that
4254 specify buffer/string position and length are now ssize_t and
4255 size_t. Return type is regoff_t.
4256
613052cd
BK
42572011-04-16 Ben Key <bkey76@gmail.com>
4258
4259 * nsfont.m: Fixed bugs in ns_get_family and
4260 ns_descriptor_to_entity that were caused by using free to
4261 deallocate memory blocks that were allocated by xmalloc (via
4262 xstrdup). This caused Emacs to crash when compiled with
4263 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
4264 --enable-checking=xmallocoverrun). xfree is now used to
4265 deallocate these memory blocks.
4266
4170f62f 42672011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 4268
71b41406
PE
4269 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
4270
9587a89d
PE
4271 emacs_write: Accept and return EMACS_INT for sizes.
4272 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
4273 et seq.
4274 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
4275 Accept and return EMACS_INT.
4276 (emacs_gnutls_write): Return the number of bytes written on
4277 partial writes.
4278 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
4279 (emacs_read, emacs_write): Remove check for negative size, as the
4280 Emacs source code has been audited now.
9587a89d
PE
4281 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
4282 (emacs_read, emacs_write): Use it.
273a5f82
PE
4283 * process.c (send_process): Adjust to the new signatures of
4284 emacs_write and emacs_gnutls_write. Do not attempt to store
4285 a byte offset into an 'int'; it might overflow.
9587a89d 4286 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 4287
3e047f51
PE
4288 * sound.c: Don't assume sizes fit in 'int'.
4289 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 4290 Return EMACS_INT, not int.
3e047f51 4291 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
4292 Accept EMACS_INT, not int.
4293 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
4294 record read return values.
4295
cc39a9db
BK
42962011-04-15 Ben Key <bkey76@gmail.com>
4297
c9d0ec6d
JB
4298 * keyboard.c (Qundefined): Don't declare static since it is used
4299 in nsfns.m.
4300 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
4301 static since they are used in nsfont.m.
cc39a9db 4302
6c60eb9f
SM
43032011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
4304
4305 * process.c (Qprocessp): Don't declare static.
4306 * lisp.h (Qprocessp): Declare again.
4307
7990b61a
JB
43082011-04-15 Juanma Barranquero <lekktu@gmail.com>
4309
4310 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
4311
5d4cb038
PE
43122011-04-14 Paul Eggert <eggert@cs.ucla.edu>
4313
8bd7b830 4314 Improve C-level modularity by making more things 'static'.
cd64ea1d 4315
e3b27b31
PE
4316 Don't publish debugger-only interfaces to other modules.
4317 * lisp.h (safe_debug_print, debug_output_compilation_hack):
4318 (verify_bytepos, count_markers): Move decls to the only modules
4319 that need them.
4320 * region-cache.h (pp_cache): Likewise.
4321 * window.h (check_all_windows): Likewise.
4322 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
4323
5d4cb038
PE
4324 * sysdep.c (croak): Now static, if
4325 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
4326 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
4327
4328 * alloc.c (refill_memory_reserve): Now static if
4329 !defined REL_ALLOC || defined SYSTEM_MALLOC.
4330 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 4331
e87b6180
PE
4332 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
4333 Define only if USE_LUCID.
4334
ac64929e
PE
4335 * xrdb.c (x_customization_string, x_rm_string): Now static.
4336
6f37259d
PE
4337 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
4338 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
4339
1683e3ab
PE
4340 * xdisp.c (draw_row_with_mouse_face): Now static.
4341 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
4342
de9c2632
PE
4343 * window.h (check_all_windows): Mark externally visible.
4344
2b96acb7
PE
4345 * window.c (window_deletion_count): Now static.
4346
4347 * undo.c: Make symbols static if they're not exported.
4348 (last_undo_buffer, last_boundary_position, pending_boundary):
4349 Now static.
4350
50436f33
PE
4351 * textprop.c (interval_insert_behind_hooks): Now static.
4352 (interval_insert_in_front_hooks): Likewise.
4353
64520e5c
PE
4354 * term.c: Make symbols static if they're not exported.
4355 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
4356 (max_frame_lines, tty_set_terminal_modes):
4357 (tty_reset_terminal_modes, tty_turn_off_highlight):
4358 (get_tty_terminal): Now static.
4359 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
4360 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 4361 HAVE_WINDOW_SYSTEM.
64520e5c
PE
4362 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
4363 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
4364
1fa53021
PE
4365 * sysdep.c: Make symbols static if they're not exported.
4366 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
4367 Now static.
4368 (sigprocmask_set, full_mask): Remove; unused.
4369 (wait_debugging): Mark as visible.
4370 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
4371 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
4372
d4b43b22
PE
4373 * syntax.c (syntax_temp): Define only if !__GNUC__.
4374
b7c513d0
PE
4375 * sound.c (current_sound_device, current_sound): Now static.
4376
989b29ad
PE
4377 * search.c (searchbufs, searchbuf_head): Now static.
4378
13a55a78
PE
4379 * scroll.c (scroll_cost): Remove; unused.
4380 * dispextern.h (scroll_cost): Remove decl.
4381
de68a1fc
PE
4382 * region-cache.h (pp_cache): Mark as externally visible.
4383
40ccffa6
PE
4384 * process.c: Make symbols static if they're not exported.
4385 (process_tick, update_tick, create_process, chan_process):
4386 (Vprocess_alist, proc_buffered_char, datagram_access):
4387 (fd_callback_data, send_process_frame, process_sent_to): Now static.
4388 (deactivate_process): Mark defn as static, as well as decl.
4389 * lisp.h (create_process): Remove decl.
4390 * process.h (chan_process, Vprocess_alist): Remove decls.
4391
ad64fc97
PE
4392 * print.c: Make symbols static if they're not exported.
4393 (print_depth, new_backquote_output, being_printed, print_buffer):
4394 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
4395 (print_interval, print_number_index, initial_stderr_stream):
4396 Now static.
4397 * lisp.h (Fprinc): Remove decl.
4398 (debug_output_compilation_hack): Mark as externally visible.
4399
adddb265
PE
4400 * sysdep.c (croak): Move decl from here to syssignal.h.
4401 * syssignal.h (croak): Put it here, so the API can be checked when
4402 'croak' is called from dissociate_if_controlling_tty.
4403
1717ede2
PE
4404 * minibuf.c: Make symbols static if they're not exported.
4405 (minibuf_save_list, choose_minibuf_frame): Now static.
4406 * lisp.h (choose_minibuf_frame): Remove decl.
4407
fa5fb2bc
PE
4408 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
4409
1e3890d1
PE
4410 * lread.c: Make symbols static if they're not exported.
4411 (read_objects, initial_obarray, oblookup_last_bucket_number):
4412 Now static.
4413 (make_symbol): Remove; unused.
4414 * lisp.h (initial_obarray, make_symbol): Remove decls.
4415
8a1414fa
PE
4416 * keyboard.c: Make symbols static if they're not exported.
4417 (single_kboard, recent_keys_index, total_keys, recent_keys):
4418 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
4419 (this_single_command_key_start, echoing, last_auto_save):
4420 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
4421 (command_loop, echo_now, keyboard_init_hook, help_char_p):
4422 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
4423 (Vlispy_mouse_stem, double_click_count):
4424 Now static.
4425 (force_auto_save_soon): Define only if SIGDANGER.
4426 (ignore_mouse_drag_p): Now static if
4427 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
4428 (print_help): Remove; unused.
4429 (stop_character, last_timer_event): Mark as externally visible.
4430 * keyboard.h (ignore_mouse_drag_p): Declare only if
4431 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
4432 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
4433 * lisp.h (echoing): Remove decl.
4434 (force_auto_save_soon): Declare only if SIGDANGER.
4435 * xdisp.c (redisplay_window): Simplify code, to make it more
4436 obvious that ignore_mouse_drag_p is not accessed if !defined
4437 USE_GTK && !defined HAVE_NS.
4438
93ea6e8f
PE
4439 * intervals.c: Make symbols static if they're not exported.
4440 (merge_properties_sticky, merge_interval_right, delete_interval):
4441 Now static.
4442 * intervals.h (merge_interval_right, delete_interval): Remove decls.
4443
77382fcc
PE
4444 * insdel.c: Make symbols static if they're not exported.
4445 However, leave prepare_to_modify_buffer alone. It's never
4446 called from outside this function, but that appears to be a bug.
4447 (combine_after_change_list, combine_after_change_buffer):
4889fc82 4448 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
4449 (adjust_after_replace_noundo): Remove; unused.
4450 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 4451 (signal_before_change): Remove decls.
77382fcc 4452
9306c32e
PE
4453 * indent.c (val_compute_motion, val_vmotion): Now static.
4454
cd44d2eb
PE
4455 * image.c: Make symbols static if they're not exported.
4456 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
4457 if USE_GTK.
4458 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
4459 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
4460
ad9a7a06
PE
4461 * fringe.c (standard_bitmaps): Now static.
4462 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
4463
81626931
PE
4464 * frame.c: Make symbols static if they're not exported.
4465 (x_report_frame_params, make_terminal_frame): Now static.
4466 (get_frame_param): Now static, unless HAVE_NS.
4467 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
4468 (x_get_resource_string): Remove; not used.
4469 * frame.h (make_terminal_frame, x_report_frame_params):
4470 (x_get_resource_string); Remove decls.
4471 (x_fullscreen_adjust): Declare only if WINDOWSNT.
4472 * lisp.h (get_frame_param): Declare only if HAVE_NS.
4473
239f9db9
PE
4474 * font.c, fontset.c: Make symbols static if they're not exported.
4475 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
4476 (FACE_SUITABLE_FOR_CHAR_P): Use it.
4477 * font.c (font_close_object): Now static.
4478 * font.h (font_close_object): Remove.
4479 * fontset.c (FONTSET_OBJLIST): Remove.
4480 (free_realized_fontset) #if-0 the body, which does nothing.
4481 (face_suitable_for_char_p): #if-0, as it's never called.
4482 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
4483 * xfaces.c (face_at_string_position):
4484 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
4485 since 0 is always ASCII.
4486
dfcf3579
PE
4487 * fns.c (weak_hash_tables): Now static.
4488
5045092b
PE
4489 * fileio.c: Make symbols static if they're not exported.
4490 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
4491 (Vwrite_region_annotation_buffers): Now static.
4492
57a96f5c
PE
4493 * eval.c: Make symbols static if they're not exported.
4494 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
4495 * lisp.h (backtrace_list): Remove decl.
4496
35f08c38
PE
4497 * emacs.c: Make symbols static if they're not exported.
4498 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
4499 (fatal_error_code, fatal_error_signal_hook, standard_args):
4500 Now static.
4501 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
4502 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
4503 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
4504 * lisp.h (fatal_error_signal_hook): Remove decl.
4505 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
4506
f44bd759
PE
4507 * editfns.c: Move a (normally-unused) function to its only use.
4508 * editfns.c, lisp.h (get_operating_system_release): Remove.
4509 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
4510 worth the hassle of breaking this out.
4511
b532497d
PE
4512 * xterm.c: Make symbols static if they're not exported.
4513 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
4514 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
4515 (x_destroy_window, x_delete_display):
4516 Now static.
4517 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
4518 (x_mouse_leave): Remove; unused.
4519 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
4520 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
4521 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
4522 Remove decls.
4523 (x_mouse_leave): Declare only if WINDOWSNT.
4524 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
4525 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
4526 USE_X_TOOLKIT.
4527
1675728f
PE
4528 * ftxfont.c: Make symbols static if they're not exported.
4529 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
4530 HAVE_FREETYPE.
4531 * font.h (ftxfont_driver): Likewise.
4532
e4cebfca
PE
4533 * xfns.c: Make symbols static if they're not exported.
4534 (x_last_font_name, x_display_info_for_name):
4535 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
4536 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
4537 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
4538 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
4539 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
4540 (last_show_tip_args): Now static.
4541 (xic_defaut_fontset, xic_create_fontsetname): Define only if
4542 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
4543 (x_screen_planes): Remove; unused.
4544 * dispextern.h (x_screen_planes): Remove decl.
4545
5bf46f05
PE
4546 * dispnew.c: Make symbols static if they're not exported.
4547 * dispextern.h (redraw_garbaged_frames, scrolling):
4548 (increment_row_positions): Remove.
4549 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
4550 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
4551 Now static.
4552 (redraw_garbaged_frames): Remove; unused.
4553
435f4c28
PE
4554 * xfaces.c: Make symbols static if they're not exported.
4555 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
4556 Remove decls.
4557 * xterm.h (defined_color): Remove decls.
4558 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
4559 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
4560 (menu_face_changed_default, defined_color, free_realized_face):
4561 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
4562 (ascii_face_of_lisp_face): Remove; unused.
4563
8524aef3
PE
4564 * xdisp.c: Make symbols static if they're not exported.
4565 * dispextern.h (scratch_glyph_row, window_box_edges):
4566 (glyph_to_pixel_coords, set_cursor_from_row):
4567 (get_next_display_element, set_iterator_to_next):
4568 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
4569 (show_mouse_face): Remove decls
4570 * frame.h (message_buf_print): Likewise.
4571 * lisp.h (pop_message, set_message, check_point_in_composition):
4572 Likewise.
4573 * xterm.h (set_vertical_scroll_bar): Likewise.
4574 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
4575 (message_buf_print, scratch_glyph_row, displayed_buffer):
4576 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
4577 (get_next_display_element, show_mouse_face, window_box_edges):
4578 (frame_to_window_pixel_xy, check_point_in_composition):
4579 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
4580 (glyph_to_pixel_coords): Remove; unused.
4581
16390cd2
PE
4582 * dired.c (file_name_completion): Now static.
4583
4584 * dbusbind.c (xd_in_read_queued_messages): Now static.
4585
a25f4dfa
PE
4586 * lisp.h (circular_list_error, FOREACH): Remove; unused.
4587 * data.c (circular_list_error): Remove.
4588
14a9c8df
PE
4589 * commands.h (last_point_position, last_point_position_buffer):
4590 (last_point_position_window): Remove decls.
4591 * keyboard.c: Make these variables static.
4592
04f2d78b
CB
4593 * coding.h (coding, code_convert_region, encode_coding_gap):
4594 Remove decls.
74ab6df5
PE
4595 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
4596 (iso_code_class, detect_coding, code_convert_region): Now static.
4597 (encode_coding_gap): Remove; unused.
4598
38dfbee1
PE
4599 * chartab.c (chartab_chars, chartab_bits): Now static.
4600
a2cb4e63
PE
4601 * charset.h (charset_iso_8859_1): Remove decl.
4602 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
4603 Now static.
4604
127198fd
PE
4605 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
4606 * ccl.c (Vccl_program_table): Now static.
4607 (check_ccl_update): Remove; unused.
4608
d85b608f
PE
4609 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
4610 * category.h: ... from here.
4611 * category.c (check_category_table, set_category_set): Now static.
4612
31cd66f3
PE
4613 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
4614 * lisp.h: Remove these decls.
4615
c358e587
PE
4616 * buffer.c (buffer_count): Remove unused var.
4617
e78aecca
PE
4618 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
4619 so that it's not optimized away.
4620 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
4621 * dispextern.h (bidi_dump_cached_states): Remove, since it's
4622 exported only to the debugger.
4623
e192d7d3 4624 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 4625 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 4626
92470028
PE
4627 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
4628 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
4629 was inaccessible from Lisp.
4630 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
4631 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
4632
244ed907
PE
4633 alloc.c: Import and export fewer symbols, and remove unused items.
4634 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
4635 is defined.
4636 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
4637 it's not optimized away by whole-program optimization.
4638 (message_enable_multibyte, free_misc): Remove.
4639 (catchlist, handlerlist, mark_backtrace):
4640 Declare only if BYTE_MARK_STACK.
4641 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
4642 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
4643 (message_enable_multibyte): Remove decl.
4644 (free_misc, interval_free_list, float_block, float_block_index):
4645 (n_float_blocks, float_free_list, cons_block, cons_block_index):
4646 (cons_free_list, last_marked_index):
4647 Now static.
4648 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
4649 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
4650 (mark_backtrace): Define only if BYTE_MARK_STACK.
4651 * xdisp.c (message_enable_multibyte): Now static.
4652
61c2b50e 4653 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
4654 This makes it easier for human readers (and static analyzers)
4655 to see whether these variables are used from other modules.
4656 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
4657 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
4658 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
4659 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
4660 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
4661 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
4662 * xmenu.c, xselect.c:
4663 Declare Q* vars static if they are not used in other modules.
4664 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
4665 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
4666 Remove decls of unexported vars.
4667 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
4668
95c82688
PE
4669 * lisp.h (DEFINE_FUNC): Make sname 'static'.
4670
16a97296
PE
4671 Make Emacs functions such as Fatom 'static' by default.
4672 This makes it easier for human readers (and static analyzers)
4673 to see whether these functions can be called from other modules.
4674 DEFUN now defines a static function. To make the function external
4675 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
4676 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
4677 (Finit_image_library):
16a97296
PE
4678 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
4679 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
4680 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
4681 Remove decls, since these functions are now static.
4682 (Funintern, Fget_internal_run_time): New decls, since these functions
4683 were already external.
95c82688 4684
16a97296
PE
4685 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
4686 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
4687 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
4688 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
4689 * keyboard.c, keymap.c, lread.c:
4690 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
4691 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
4692 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
4693 Mark functions with DEFUE instead of DEFUN,
4694 if they are used in other modules.
4695 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
4696 decls for now-static functions.
4697 * buffer.h (Fdelete_overlay): Remove decl.
4698 * callproc.c (Fgetenv_internal): Mark as internal.
4699 * composite.c (Fremove_list_of_text_properties): Remove decl.
4700 (Fcomposition_get_gstring): New forward static decl.
4701 * composite.h (Fcomposite_get_gstring): Remove decl.
4702 * dired.c (Ffile_attributes): New forward static decl.
4703 * doc.c (Fdocumntation_property): New forward static decl.
4704 * eval.c (Ffetch_bytecode): New forward static decl.
4705 (Funintern): Remove extern decl; now in .h file where it belongs.
4706 * fileio.c (Fmake_symbolic_link): New forward static decl.
4707 * image.c (Finit_image_library): New forward static decl.
4708 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
4709 * intervals.h (Fprevious_property_change):
4710 (Fremove_list_of_text_properties): Remove decls.
4711 * keyboard.c (Fthis_command_keys): Remove decl.
4712 (Fcommand_execute): New forward static decl.
4713 * keymap.c (Flookup_key): New forward static decl.
4714 (Fcopy_keymap): Now static.
4715 * keymap.h (Flookup_key): Remove decl.
4716 * process.c (Fget_process): New forward static decl.
4717 (Fprocess_datagram_address): Mark as internal.
4718 * syntax.c (Fsyntax_table_p): New forward static decl.
4719 (skip_chars): Remove duplicate decl.
4720 * textprop.c (Fprevious_property_change): New forward static decl.
4721 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
4722 Now internal.
4723 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
4724 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
4725
785bbd42
PE
4726 * editfns.c (Fformat): Remove unreachable code.
4727
8b913b57
AS
47282011-04-14 Andreas Schwab <schwab@linux-m68k.org>
4729
4730 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
4731 change. (Bug#8496)
4732
a6744a35
EZ
47332011-04-13 Eli Zaretskii <eliz@gnu.org>
4734
4735 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
4736 when at ZV. (Bug#8487)
4737
e7974947
AS
47382011-04-12 Andreas Schwab <schwab@linux-m68k.org>
4739
baad03f0
AS
4740 * charset.c (Fclear_charset_maps): Use xfree instead of free.
4741 (Bug#8437)
4742 * keyboard.c (parse_tool_bar_item): Likewise.
4743 * sound.c (sound_cleanup, alsa_close): Likewise.
4744 * termcap.c (tgetent): Likewise.
4745 * xfns.c (x_default_font_parameter): Likewise.
4746 * xsettings.c (read_and_apply_settings): Likewise.
4747
e7974947
AS
4748 * alloc.c (overrun_check_malloc, overrun_check_realloc)
4749 (overrun_check_free): Protoize.
4750
28272684
PE
47512011-04-12 Paul Eggert <eggert@cs.ucla.edu>
4752
4753 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
4754 since callers should never pass a negative size.
4755 Change the signature to match that of plain 'read' and 'write'; see
4756 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
4757 * lisp.h: Update prototypes of emacs_write and emacs_read.
4758
11997c76
EZ
47592011-04-11 Eli Zaretskii <eliz@gnu.org>
4760
4761 * xdisp.c (redisplay_window): Don't try to determine the character
4762 position of the scroll margin if the window start point w->startp
e896f03c 4763 is outside the buffer's accessible region. (Bug#8468)
11997c76 4764
8a2cbd72
EZ
47652011-04-10 Eli Zaretskii <eliz@gnu.org>
4766
4767 Fix write-region and its subroutines for buffers > 2GB.
4768 * fileio.c (a_write, e_write): Modify declaration of arguments and
4769 local variables to support buffers larger than 2GB.
4770 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
4771
4772 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
4773 argument, local variables, and return value.
4774
4775 * lisp.h: Update prototypes of emacs_write and emacs_read.
4776
4777 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
4778
4073e537 47792011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 4780
1ebfdcb6
PE
4781 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
4782
b2ded58d
PE
4783 Fix more problems found by GCC 4.6.0's static checks.
4784
7d66342c
PE
4785 * xdisp.c (vmessage): Use a better test for character truncation.
4786
bbf47d44
PE
4787 * charset.c (load_charset_map): <, not <=, for optimization,
4788 and to avoid potential problems with integer overflow.
9248994d 4789 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 4790 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 4791 * editfns.c (Fformat): Likewise.
1e69125e 4792 * syntax.c (skip_chars): Likewise.
3befa583 4793
e3019616
PE
4794 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
4795 This also lets GCC 4.6.0 generate slightly better loop code.
4796
becfa255
PE
4797 * callint.c (Fcall_interactively): <, not <=, for optimization.
4798 (Fcall_interactively): Count the number of arguments produced,
4799 not the number of arguments given. This is simpler and lets GCC
4800 4.6.0 generate slightly better code.
4801
dae0cd48
PE
4802 * ftfont.c: Distingish more carefully between FcChar8 and char.
4803 The previous code passed unsigned char * to a functions like
4804 strlen and xstrcasecmp that expect char *, which does not
4805 conform to the C standard.
4806 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
4807 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
4808 char * when the C standard requires it.
4809
76032d70
PE
4810 * keyboard.c (read_char): Remove unused var.
4811
eb3f1cc8
PE
4812 * eval.c: Port to Windows vsnprintf (Bug#8435).
4813 Include <limits.h>.
4814 (SIZE_MAX): Define if the headers do not.
4815 (verror): Do not give up if vsnprintf returns a negative count.
4816 Instead, grow the buffer. This ports to Windows vsnprintf, which
4817 does not conform to C99. Problem reported by Eli Zaretskii.
4818 Also, simplify the allocation scheme, by avoiding the need for
4819 calling realloc, and removing the ALLOCATED variable.
4820
70476b54
PE
4821 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
4822
12020a9e
PE
4823 Remove invocations of doprnt, as Emacs now uses vsnprintf.
4824 But keep the doprint source code for now, as we might revamp it
4825 and use it again (Bug#8435).
ea6c7ae6
PE
4826 * lisp.h (doprnt): Remove.
4827 * Makefile.in (base_obj): Remove doprnt.o.
4828 * deps.mk (doprnt.o): Remove.
4829
5fdb398c
PE
4830 error: Print 32- and 64-bit integers portably (Bug#8435).
4831 Without this change, on typical 64-bit hosts error ("...%d...", N)
4832 was used to print both 32- and 64-bit integers N, which relied on
4833 undefined behavior.
4834 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
4835 New macro.
4836 * lisp.h (error, verror): Mark as printf-like functions.
4837 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
4838 Report overflow in size calculations when allocating printf buffer.
4839 Do not truncate output string at its first null byte.
4840 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
4841 Truncate the output at a character boundary, since vsnprintf does not
4842 do that.
4843 * charset.c (check_iso_charset_parameter): Convert internal
4844 character to string before calling 'error', since %c now has the
4845 printf meaning.
4846 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
4847 overflow when computing char to be passed to 'error'. Do not
4848 pass Lisp_Object to 'error'; pass the integer instead.
4849 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
4850 formatted with plain %d.
4851
b189fa66
PE
4852 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
4853
bff87ef0
PE
4854 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
4855
7e2cac20
PE
4856 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
4857
ce4d90b5
PE
4858 * xterm.c (x_catch_errors): Remove duplicate declaration.
4859
266c9547
PE
4860 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
4861
79c49ad2
PE
4862 * xdisp.c, lisp.h (message_nolog): Remove; unused.
4863
368f4090
JM
48642011-04-10 Jim Meyering <meyering@redhat.com>
4865
4866 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
4867 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
4868 return ssize_t not "int", and use size_t as the buffer length.
4869 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
4870 * gnutls.h: Update declarations.
4871 * process.c (read_process_output): Use ssize_t, to match.
4872 (send_process): Likewise.
4873
a32d4040
CY
48742011-04-09 Chong Yidong <cyd@stupidchicken.com>
4875
4876 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
4877
8546720e 48782011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 4879
04f2d78b
CB
4880 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
4881 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 4882
8546720e
GM
4883 * xterm.c (handle_one_xevent):
4884 * xmenu.c (create_and_show_popup_menu):
4885 * xselect.c (x_decline_selection_request)
4886 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 4887
0a2f5c1a 48882011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
4889
4890 Fix some uses of `int' instead of EMACS_INT.
4891 * search.c (string_match_1, fast_string_match)
4892 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
4893 (scan_buffer, find_next_newline_no_quit)
4894 (find_before_next_newline, search_command, Freplace_match)
4895 (Fmatch_data): Make some `int' variables be EMACS_INT.
4896
4897 * xdisp.c (display_count_lines): 3rd argument and return value now
4898 EMACS_INT. All callers changed.
4899 (pint2hrstr): Last argument is now EMACS_INT.
4900
4901 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
4902 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
4903 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
4904 (decode_coding_utf_16, decode_coding_emacs_mule)
4905 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
4906 (decode_coding_ccl, decode_coding_charset)
4907 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
4908 (decode_coding_iso_2022, decode_coding_emacs_mule)
4909 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
4910 <char_offset, last_offset>: Declare EMACS_INT.
4911 (encode_coding_utf_8, encode_coding_utf_16)
4912 (encode_coding_emacs_mule, encode_invocation_designation)
4913 (encode_designation_at_bol, encode_coding_iso_2022)
4914 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
4915 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
4916 Declare EMACS_INT.
4917 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
4918 (encode_invocation_designation): Last argument P_NCHARS is now
4919 EMACS_INT.
4920 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
4921 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
4922
4923 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
4924 All users changed.
4925
4926 * ccl.c (Fccl_execute_on_string): Declare some variables
4927 EMACS_INT.
4928
8546720e 49292011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
4930
4931 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
4932
4e19a977
CS
49332011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
4934
4935 * process.c (Fformat_network_address): Doc fix.
4936
87302331
R
49372011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
4938
4939 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
4940
cbb59342
CY
49412011-04-08 Chong Yidong <cyd@stupidchicken.com>
4942
4943 * keyboard.c (read_char): Call Lisp function help-form-show,
4944 instead of using internal_with_output_to_temp_buffer.
4945 (Qhelp_form_show): New var.
e0d38eeb 4946 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
4947
4948 * print.c (internal_with_output_to_temp_buffer): Function deleted.
4949
4950 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
4951
e67a13ab
CY
49522011-04-06 Chong Yidong <cyd@stupidchicken.com>
4953
04f2d78b
CB
4954 * process.c (Flist_processes): Remove to Lisp.
4955 (list_processes_1): Delete.
e67a13ab 4956
973f782d
EZ
49572011-04-06 Eli Zaretskii <eliz@gnu.org>
4958
7c106b1e
EZ
4959 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
4960
973f782d
EZ
4961 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
4962
41cf7d1a 49632011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 4964
ca23cc88
PE
4965 Fix more problems found by GCC 4.6.0's static checks.
4966
f390e2d5
PE
4967 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
4968
42eea0d0
PE
4969 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
4970
b69769da 4971 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 4972
f9541e84
PE
4973 * xdisp.c (vmessage): Mark as a printf-like function.
4974
13841b55
PE
4975 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
4976
c136c10f
PE
4977 * sound.c (sound_warning): Don't crash if arg contains a printf format.
4978
5e2d4a30
PE
4979 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
4980 printf-like functions.
4981 (tiff_load): Add casts to remove these marks before passing them
4982 to system-supplied API.
4983
583f48b9
PE
4984 * eval.c (Fsignal): Remove excess argument to 'fatal'.
4985
b25d760e
PE
4986 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
4987 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
4988 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
4989 directly, rather than having caller test rule sign. This avoids
4990 some unnecessary tests.
4991 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
4992 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
4993 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 4994
bc7b6697 4995 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 4996 (xfont_open): Avoid unnecessary tests.
bc7b6697 4997
27ccc379
PE
4998 * composite.c (composition_gstring_put_cache): Use unsigned integer.
4999
dcd5c89a
PE
5000 * composite.h, composite.c (composition_gstring_put_cache):
5001 Use EMACS_INT, not int, for length.
5002
b13a45c6
PE
5003 * composite.h (COMPOSITION_DECODE_REFS): New macro,
5004 breaking out part of COMPOSITION_DECODE_RULE.
5005 (COMPOSITION_DECODE_RULE): Use it.
5006 * composite.c (get_composition_id): Remove unused local vars,
5007 by using the new macro.
5008
1e792e4d
PE
5009 * textprop.c (set_text_properties_1): Change while to do-while,
5010 since the condition is always true at first.
5011
dc6c6455 5012 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
5013 (interval_deletion_adjustment): Return unsigned value.
5014 All uses changed.
dc6c6455 5015
aba7731a
PE
5016 * process.c (list_processes_1, create_pty, read_process_output):
5017 (exec_sentinel): Remove vars that were set but not used.
afd4052b 5018 (create_pty): Remove unnecessary "volatile"s.
bc57d757 5019 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 5020 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 5021 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 5022
fdfc4bf3
PE
5023 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
5024
fca8fe46 5025 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 5026 (update_syntax_table): Use unsigned instead of int.
fca8fe46 5027
06a0259a 5028 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 5029 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 5030 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 5031
e7b9e80f
PE
5032 * print.c (print_error_message): Avoid int overflow.
5033
56201685
PE
5034 * font.c (font_list_entities): Redo for clarity,
5035 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
5036
78834453 5037 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 5038 (font_score): Avoid potential overflow in diff calculation.
78834453 5039
0bc0b309 5040 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 5041 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 5042
e610eaca
PE
5043 * eval.c (funcall_lambda): Rename local to avoid shadowing.
5044
b895abce
PE
5045 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
5046 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
5047 can always succeed if overflow has undefined behavior.
5048
1f1d9321 5049 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 5050 (wordify): Omit three unnecessary tests.
1f1d9321 5051
c59478bc
PE
5052 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
5053 All callers changed. This avoids the need for an unused var.
5054
79b73827
PE
5055 * casefiddle.c (casify_region): Remove var that is set but not used.
5056
a4db5dfe
PE
5057 * dired.c (file_name_completion): Remove var that is set but not used.
5058
43aae36e
PE
5059 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
5060
2a47c44d 5061 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 5062 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 5063
a37c69bf
PE
5064 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
5065 Check for integer overflow on size calculations.
5066
328ab8e7
PE
5067 * buffer.c (Fprevious_overlay_change): Remove var that is set
5068 but not used.
5069
e5a2a5cb
PE
5070 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
5071 Remove vars that are set but not used.
8d84a6eb 5072 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 5073 (timer_check_2): Mark vars as initialized.
e5a2a5cb 5074
a60e5f68
PE
5075 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
5076
f661cb61 5077 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 5078 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 5079
f0397f5a
PE
5080 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
5081 that are set but not used.
5082
8664db06 5083 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 5084 if XCreateBitmapFromData fails (Bug#8410).
8664db06 5085
6abdaa4a
PE
5086 * xselect.c (x_get_local_selection, x_handle_property_notify):
5087 Remove vars that are set but not used.
5088
0ce7538d 5089 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 5090 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 5091
9ae848fc
PE
5092 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
5093 Remove var that is set but not used.
0b918413
PE
5094 (scroll_bar_windows_size): Now size_t, not int.
5095 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
5096 Check for overflow.
9ae848fc 5097
a5a62657
PE
5098 * xfaces.c (realize_named_face): Remove vars that are set but not used.
5099 (map_tty_color) [!defined MSDOS]: Likewise.
5100
5c5cdd39
PE
5101 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
5102
66ebf983
PE
5103 * coding.c: Remove vars that are set but not used.
5104 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
5105 All callers changed.
5106 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
5107 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
5108 (decode_coding_charset): Remove vars that are set but not used.
5109
1be4d761
PE
5110 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
5111 that is set but not used.
5112
47553fa8
PE
5113 * print.c (print_object): Remove var that is set but not used.
5114
1f7196bf 5115 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
5116 The gnulib version avoids calling malloc in the usual case,
5117 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
5118 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
5119 * filelock.c (current_lock_owner): Likewise.
5120 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
5121 * sysdep.c: Include allocator.h, careadlinkat.h.
5122 (emacs_no_realloc_allocator): New static constant.
5123 (emacs_readlink): New function.
fdb61804
PE
5124 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
5125 ../lib/careadlinkat.h.
d1fdcab7 5126
f84c17c7
SM
51272011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
5128
5129 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
5130 first non-nil return value).
5131
ef3862ad
JD
51322011-04-03 Jan Djärv <jan.h.d@swipnet.se>
5133
5134 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
5135 if not defined (Bug#8403).
5136
376a7006
JB
51372011-04-02 Juanma Barranquero <lekktu@gmail.com>
5138
5139 * xdisp.c (display_count_lines): Remove parameter `start',
5140 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5141 (get_char_face_and_encoding): Remove parameter `multibyte_p',
5142 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5143 (fill_stretch_glyph_string): Remove parameters `row' and `area',
5144 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
5145 and thereabouts. All callers changed.
5146 (get_per_char_metric): Remove parameter `f', unused since
5147 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
5148
6ca3801d
JM
51492011-04-02 Jim Meyering <meyering@redhat.com>
5150
5151 do not dereference NULL upon failed strdup
5152 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
5153 (ns_get_family): Likewise.
5154
d8e2b5ba
JB
51552011-04-02 Juanma Barranquero <lekktu@gmail.com>
5156
5157 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
5158
8c74fcbd
JD
51592011-04-02 Jan Djärv <jan.h.d@swipnet.se>
5160
5161 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
5162 later (Bug#8403).
5163
7200d79c
SM
51642011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
5165
03408648 5166 Add lexical binding.
7200d79c 5167
03408648
SM
5168 * window.c (Ftemp_output_buffer_show): New fun.
5169 (Fsave_window_excursion):
5170 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
5171
5172 * lread.c (lisp_file_lexically_bound_p): New function.
5173 (Fload): Bind Qlexical_binding.
5174 (readevalloop): Remove `evalfun' arg.
5175 Bind Qinternal_interpreter_environment.
5176 (Feval_buffer): Bind Qlexical_binding.
5177 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
5178 Mark as dynamic.
5179 (syms_of_lread): Declare `lexical-binding'.
5180
5181 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
5182
5183 * keyboard.c (eval_dyn): New fun.
5184 (menu_item_eval_property): Use it.
ca105506
SM
5185
5186 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 5187
03408648
SM
5188 * fns.c (concat, mapcar1): Accept byte-code-functions.
5189
5190 * eval.c (Fsetq): Handle lexical vars.
5191 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
5192 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
5193 (FletX, Flet): Obey lexical binding.
5194 (Fcommandp): Handle closures.
5195 (Feval): New `lexical' arg.
5196 (eval_sub): New function extracted from Feval. Use it almost
5197 everywhere where Feval was used. Look up vars in lexical env.
5198 Handle closures.
5199 (Ffunctionp): Move from subr.el.
5200 (Ffuncall): Handle closures.
5201 (apply_lambda): Remove `eval_flags'.
5202 (funcall_lambda): Handle closures and new byte-code-functions.
5203 (Fspecial_variable_p): New function.
5204 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
5205 but without exporting it to Lisp.
23aba0ea 5206
23aba0ea 5207 * doc.c (Fdocumentation, store_function_docstring):
03408648 5208 * data.c (Finteractive_form): Handle closures.
23aba0ea 5209
03408648
SM
5210 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
5211 interactive spec.
ba83908c 5212
04f2d78b
CB
5213 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
5214 New byte-codes.
03408648
SM
5215 (exec_byte_code): New function extracted from Fbyte_code to handle new
5216 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 5217
03408648 5218 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 5219
03408648 5220 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 5221
e2abce01
JB
52222011-03-31 Juanma Barranquero <lekktu@gmail.com>
5223
5224 * xdisp.c (redisplay_internal): Fix prototype.
5225
63696a73 52262011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 5227
63696a73 5228 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
5229 (try_scrolling): Use it when setting scroll_limit.
5230 Limit scrolling to 100 screen lines.
63696a73
EZ
5231 (redisplay_window): Even when falling back on "recentering",
5232 position point in the window according to scroll-conservatively,
5233 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
5234
5235 (try_scrolling): When point is above the window, allow searching
5236 as far as scroll_max, or one screenful, to compute vertical
5237 distance from PT to the scroll margin position. This prevents
5238 try_scrolling from unnecessarily failing when
5239 scroll-conservatively is set to a value slightly larger than the
5240 window height. Clean up the case of PT below the margin at bottom
5241 of window: scroll_max can no longer be INT_MAX. When aggressive
5242 scrolling is in use, don't let point enter the opposite scroll
5243 margin as result of the scroll.
5244 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
5245 threshold of 100 lines for never-recentering scrolling.
5246
e4cc2dfc
JB
52472011-03-31 Juanma Barranquero <lekktu@gmail.com>
5248
5249 * dispextern.h (move_it_by_lines):
5250 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
5251 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
5252 (message_log_check_duplicate): Remove parameters `prev_bol' and
5253 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
5254 (redisplay_internal): Remove parameter `preserve_echo_area',
5255 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
5256
5257 * indent.c (Fvertical_motion):
5258 * window.c (window_scroll_pixel_based, Frecenter):
5259 Don't pass `need_y_p' to `move_it_by_lines'.
5260
1c470562
SM
52612011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
5262
44f230aa
SM
5263 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
5264 steal a few bits to be more compact.
5265 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
5266 Remove unneeded casts.
5267
1c470562
SM
5268 * bytecode.c (Fbyte_code): CAR and CDR can GC.
5269
888adce9
ZK
52702011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
5271
5272 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
5273 binding" message (bug#7967).
5274
f838ed7b
PE
52752011-03-30 Paul Eggert <eggert@cs.ucla.edu>
5276
77861b95
PE
5277 Fix more problems found by GCC 4.6.0's static checks.
5278
de6dbc14
PE
5279 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
5280 Remove unused local var.
5281
f838ed7b
PE
5282 * editfns.c (Fmessage_box): Remove unused local var.
5283
792c7b2b
PE
5284 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
5285 (note_mode_line_or_margin_highlight, note_mouse_highlight):
5286 Omit unused local vars.
c499e557 5287 * window.c (shrink_windows): Omit unused local var.
b01a1c29 5288 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
5289 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
5290 Omit unused local var.
5291
ba0165e1
PE
5292 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
5293 Don't assume string length fits in int.
32ad8845 5294 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 5295 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 5296
3c59b4c9
PE
5297 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
5298 instead of alloca (Bug#8344).
5299
a3eed478 5300 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 5301 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 5302
eb4d412d
PE
5303 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
5304
1658b401
PE
5305 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
5306 concerns.
5307
5308 * term.c (produce_glyphless_glyph): Remove unnecessary test.
5309
5310 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 5311
9a2c6e05
PE
5312 * keyboard.c (syms_of_keyboard): Use the same style as later
5313 in this function when indexing through an array. This also
5314 works around GCC bug 48267.
5315
03d0a109
PE
5316 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
5317
44f730c8
PE
5318 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
5319
fe75f926
PE
5320 * chartab.c (sub_char_table_ref_and_range): Redo for slight
5321 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
5322
ffa8c828
PE
5323 * keyboard.c, keyboard.h (num_input_events): Now size_t.
5324 This avoids undefined behavior on integer overflow, and is a bit
5325 more convenient anyway since it is compared to a size_t variable.
5326
c5101a77
PE
5327 Variadic C functions now count arguments with size_t, not int.
5328 This avoids an unnecessary limitation on 64-bit machines, which
5329 caused (substring ...) to crash on large vectors (Bug#8344).
5330 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
5331 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 5332 All variadic functions and their callers changed accordingly.
c5101a77
PE
5333 (struct gcpro.nvars): Now size_t, not int. All uses changed.
5334 * data.c (arith_driver, float_arith_driver): Likewise.
5335 * editfns.c (general_insert_function): Likewise.
5336 * eval.c (struct backtrace.nargs, interactive_p)
5337 (internal_condition_case_n, run_hook_with_args, apply_lambda)
5338 (funcall_lambda, mark_backtrace): Likewise.
5339 * fns.c (concat): Likewise.
5340 * frame.c (x_set_frame_parameters): Likewise.
5341 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
5342 0 if not found, not -1. All callers changed.
5343
dd3f25f7
PE
5344 * alloc.c (garbage_collect): Don't assume stack size fits in int.
5345 (stack_copy_size): Now size_t, not int.
5346 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
5347
461c2ab9
JB
53482011-03-28 Juanma Barranquero <lekktu@gmail.com>
5349
5350 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
5351 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5352 All callers changed.
5353
5354 * lisp.h (multibyte_char_to_unibyte):
5355 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
5356 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
5357 * character.h (CHAR_TO_BYTE8):
5358 * cmds.c (internal_self_insert):
5359 * editfns.c (general_insert_function):
5360 * keymap.c (push_key_description):
5361 * search.c (Freplace_match):
5362 * xdisp.c (message_dolog, set_message_1): All callers changed.
5363
f6d62986
SM
53642011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
5365
5366 * keyboard.c (safe_run_hook_funcall): New function.
5367 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
5368 don't set the hook to nil, but remove the offending function instead.
5369 (Qcommand_hook_internal): Remove, unused.
5370 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
5371 Vcommand_hook_internal.
5372
5373 * eval.c (enum run_hooks_condition): Remove.
5374 (funcall_nil, funcall_not): New functions.
5375 (run_hook_with_args): Call each function through a `funcall' argument.
5376 Remove `cond' argument, now redundant.
5377 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
5378 (Frun_hook_with_args_until_failure): Adjust accordingly.
5379 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
5380
1db5b1ad
JB
53812011-03-28 Juanma Barranquero <lekktu@gmail.com>
5382
5383 * dispextern.h (string_buffer_position): Remove declaration.
5384
5385 * print.c (strout): Remove parameter `multibyte', unused since
5386 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
5387
5388 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
5389 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
5390 All callers changed.
5391
5392 * w32.c (_wsa_errlist): Use braces for struct initializers.
5393
5394 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
5395 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
5396 All callers changed.
5397 (string_buffer_position): Likewise. Also, make static (it's never
5398 used outside xdisp.c).
5399 (cursor_row_p): Remove parameter `w', unused since
5400 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
5401 (decode_mode_spec): Remove parameter `precision', introduced during
5402 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
5403 All callers changed.
5404
5ffb62aa
JD
54052011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5406
5407 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
5408
461c2ab9 54092011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
5410
5411 * nsterm.m (ns_menu_bar_is_hidden): New variable.
5412 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
5413 (ns_update_auto_hide_menu_bar): New functions.
5414 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
5415 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
5416 ns_constrain_all_frames.
5417 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
5418 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
5419
5c380ffb
JD
54202011-03-27 Jan Djärv <jan.h.d@swipnet.se>
5421
5422 * nsmenu.m (runDialogAt): Remove argument to timer_check.
5423
9af30bdf
GM
54242011-03-27 Glenn Morris <rgm@gnu.org>
5425
5426 * syssignal.h: Replace RETSIGTYPE with void.
5427 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
5428 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
5429 Replace SIGTYPE with void everywhere.
5430 * s/usg5-4-common.h (SIGTYPE): Remove definition.
5431 * s/template.h (SIGTYPE): Remove commented out definition.
5432
e2abce01
JB
54332011-03-26 Eli Zaretskii <eliz@gnu.org>
5434
5435 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
5436 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
5437
f868cd8a
JB
54382011-03-26 Juanma Barranquero <lekktu@gmail.com>
5439
59eb0929
JB
5440 * w32.c (read_unc_volume): Use parameter `henum', instead of
5441 global variable `wget_enum_handle'.
5442
5443 * keymap.c (describe_vector): Remove parameters `indices' and
5444 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
5445 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
5446
f868cd8a
JB
5447 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
5448
5449 * keyboard.c (timer_check): Remove parameter `do_it_now',
5450 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
5451 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
5452 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
5453
5454 * keyboard.c (read_char):
5455 * w32menu.c (w32_menu_display_help):
5456 * xmenu.c (show_help_event, menu_help_callback):
5457 Adjust calls to `show_help_echo'.
5458
5459 * gtkutil.c (xg_maybe_add_timer):
5460 * keyboard.c (readable_events):
5461 * process.c (wait_reading_process_output):
5462 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
5463
5464 * insdel.c (adjust_markers_gap_motion):
5465 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
5466 (gap_left, gap_right): Don't call it.
5467
2ecf6fdb
CY
54682011-03-25 Chong Yidong <cyd@stupidchicken.com>
5469
5470 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
5471 incurred during fontification.
5472
6b1f9ba4
JB
54732011-03-25 Juanma Barranquero <lekktu@gmail.com>
5474
5475 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
5476 (DEFVAR_PER_BUFFER): Don't pass it.
5477
5478 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
5479 (scrolling_window): Don't pass it.
5480
0f4a96b5
JB
54812011-03-25 Juanma Barranquero <lekktu@gmail.com>
5482
5483 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
5484
5485 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
5486 and `suffix'.
5487 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
5488 of variables specific to SELinux and computation of `encoded_absname'.
5489
5490 * image.c (XPutPixel): Remove unused variable `height'.
5491
5492 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
5493
5494 * unexw32.c (get_section_info): Remove unused variable `section'.
5495
5496 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
5497 (system_process_attributes): Remove unused variable `sess'.
5498 (sys_read): Remove unused variable `err'.
5499
5500 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
5501 (w32_wnd_proc): Remove unused variable `isdead'.
5502 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
5503 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
5504 (x_create_tip_frame): Remove unused variable `tem'.
5505
5506 * w32inevt.c (w32_console_read_socket):
5507 Remove unused variable `no_events'.
5508
5509 * w32term.c (x_draw_composite_glyph_string_foreground):
5510 Remove unused variable `width'.
5511
1149507c
JB
55122011-03-24 Juanma Barranquero <lekktu@gmail.com>
5513
5514 * w32term.c (x_set_glyph_string_clipping):
5515 Don't pass uninitialized region to CombineRgn.
5516
9c88f339
JB
55172011-03-23 Juanma Barranquero <lekktu@gmail.com>
5518
5519 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
5520 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
5521 (Fx_close_connection): Remove unused variable `i'.
5522
5523 * w32font.c (w32font_draw): Return number of glyphs.
5524 (w32font_open_internal): Remove unused variable `i'.
5525 (w32font_driver): Add missing initializer.
5526
5527 * w32menu.c (utf8to16): Remove unused variable `utf16'.
5528 (fill_in_menu): Remove unused variable `items_added'.
5529
5530 * w32term.c (last_mouse_press_frame): Remove static global variable.
5531 (w32_clip_to_row): Remove unused variable `f'.
5532 (x_delete_terminal): Remove unused variable `i'.
5533
5534 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
5535 (NOTHING): Remove unused static global variable.
5536 (uniscribe_check_otf): Remove unused variable `table'.
5537 (uniscribe_font_driver): Add missing initializers.
5538
dee091a3
JD
55392011-03-23 Julien Danjou <julien@danjou.info>
5540
5541 * term.c (Fsuspend_tty, Fresume_tty):
5542 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
5543 * window.c (temp_output_buffer_show):
5544 * insdel.c (signal_before_change):
5545 * frame.c (Fhandle_switch_frame):
5546 * fileio.c (Fdo_auto_save):
5547 * emacs.c (Fkill_emacs):
5548 * editfns.c (save_excursion_restore):
5549 * cmds.c (internal_self_insert):
5550 * callint.c (Fcall_interactively):
5551 * buffer.c (Fkill_all_local_variables):
5552 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
5553 Use Frun_hooks.
0f4a96b5 5554 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
5555 unconditionnaly since it does the check itself.
5556
2c520ab5 55572011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 5558
c9c49752
PE
5559 Fix more problems found by GCC 4.5.2's static checks.
5560
8abc3f12
PE
5561 * coding.c (encode_coding_raw_text): Avoid unnecessary test
5562 the first time through the loop, since we know p0 < p1 then.
5563 This also avoids a gcc -Wstrict-overflow warning.
5564
a2d26660
PE
5565 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
5566 leading to a memory leak, possible in functions like
5567 load_charset_map_from_file that can allocate an unbounded number
b12ef411 5568 of objects (Bug#8318).
a2d26660 5569
916c72e9
PE
5570 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
5571 that could (at least in theory) be that large.
5572
19ab8a18
PE
5573 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
5574 This is less likely to overflow, and avoids undefined behavior if
5575 overflow does occur. All callers changed. Use strtoul to scan
5576 for the unsigned long integer.
b7cbbd6f
PE
5577 (pint2hrstr): Simplify and tune code slightly.
5578 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 5579
f0641eff
PE
5580 * scroll.c (do_scrolling): Work around GCC bug 48228.
5581 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
5582
7f650bb9
PE
5583 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
5584 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
5585 (validate_x_resource_name): Simplify count usage.
5586 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 5587
37dd57d1
PE
5588 * fileio.c (Fcopy_file): Report error if fchown or fchmod
5589 fail (Bug#8306).
81e56e61 5590
699979fc 5591 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 5592
401bf9b4
PE
5593 * process.c (Fmake_network_process): Use socklen_t, not int,
5594 where POSIX says socklen_t is required in portable programs.
5595 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 5596 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
5597 (Fmake_network_process, server_accept_connection):
5598 (wait_reading_process_output, read_process_output):
5599 Likewise.
5600
b93aacde
PE
5601 * process.c: Rename or move locals to avoid shadowing.
5602 (list_processes_1, Fmake_network_process):
5603 (read_process_output_error_handler, exec_sentinel_error_handler):
5604 Rename or move locals.
4dc343ee 5605 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 5606 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 5607 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 5608 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 5609 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 5610
af8a867c 5611 Make tparam.h and terminfo.c consistent.
44f230aa
SM
5612 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
5613 Include tparam.h instead, since it declares them.
af8a867c
PE
5614 * cm.h (PC): Remove extern decl; tparam.h now does this.
5615 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
5616 * terminfo.c: Include tparam.h, to check interfaces.
5617 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
5618 (tparam): Adjust signature to match interface in tparam.h;
5619 this removes some undefined behavior. Check that outstring and len
5620 are zero, which they always are with Emacs.
5621 * tparam.h (PC, BC, UP): New extern decls.
5622
0248044d 5623 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 5624 (xftfont_open): Rename locals to avoid shadowing.
0248044d 5625
8ff096c1 5626 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
5627 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
5628 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 5629 (ftfont_list): Remove unused local.
49eaafba
PE
5630 (get_adstyle_property, ftfont_pattern_entity):
5631 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
5632 Rename locals to avoid shadowing.
8ff096c1 5633
e2be39f6
PE
5634 * xfont.c (xfont_list_family): Mark var as initialized.
5635
c9735e30
PE
5636 * xml.c (make_dom): Now static.
5637
8f5201ae
PE
5638 * composite.c (composition_compute_stop_pos): Rename local to
5639 avoid shadowing.
b246f932
PE
5640 (composition_reseat_it): Remove unused locals.
5641 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 5642 (composition_update_it): Mark var as initialized.
11b61122
PE
5643 (find_automatic_composition): Mark vars as initialized,
5644 with a FIXME (Bug#8290).
8f5201ae 5645
760fbc2c
PE
5646 character.h: Rename locals to avoid shadowing.
5647 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
5648 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
5649 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
5650 (BUF_DEC_POS): Be more systematic about renaming local temporaries
5651 to avoid shadowing.
5652
ff08eb85
PE
5653 * textprop.c (property_change_between_p): Remove; unused.
5654
fc7bf025
PE
5655 * intervals.c (interval_start_pos): Now static.
5656
235d7abc
PE
5657 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
5658
44f230aa
SM
5659 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
5660 Rename locals to avoid shadowing.
3e7d6594 5661
50060332
PE
5662 * sound.c (wav_play, au_play, Fplay_sound_internal):
5663 Fix pointer signedness.
d01f234b 5664 (alsa_choose_format): Remove unused local var.
c83b8872
PE
5665 (wav_play): Initialize a variable to 0, to prevent undefined
5666 behavior (Bug#8278).
50060332 5667
c4fc4e30
PE
5668 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
5669
918436ed
PE
5670 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
5671
c939f91b
PE
5672 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
5673 clobbering (Bug#8298).
b9c7f648
PE
5674 * sysdep.c (sys_subshell): Likewise.
5675 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 5676
6bd8c144
PE
5677 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
5678 This should get cleaned up, so that child_setup has the
5679 same signature on all platforms.
5680
7710357c 5681 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 5682 (relocate_fd): Rename locals to avoid shadowing.
7710357c 5683
c59da222
CY
56842011-03-22 Chong Yidong <cyd@stupidchicken.com>
5685
5686 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
5687 not to be necessary, and produces flickering.
5688
66b87493
GM
56892011-03-20 Glenn Morris <rgm@gnu.org>
5690
5691 * config.in: Remove file.
5692
45b6f6d5
JB
56932011-03-20 Juanma Barranquero <lekktu@gmail.com>
5694
5695 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
5696 are now in src/globals.h.
5697 (syms_of_minibuf): Remove spurious & from previous change.
5698
3ec03f7e
LL
56992011-03-20 Leo <sdl.web@gmail.com>
5700
5701 * minibuf.c (completing-read-function): New variable.
5702 (completing-read-default): Rename from completing-read.
5703 (completing-read): Call completing-read-function.
5704
b14e3e21
CY
57052011-03-19 Juanma Barranquero <lekktu@gmail.com>
5706
5707 * xfaces.c (Fx_load_color_file):
5708 Read color file from absolute filename (bug#8250).
5709
f2b726e6
JB
57102011-03-19 Juanma Barranquero <lekktu@gmail.com>
5711
5712 * makefile.w32-in: Update dependencies.
5713
09f6ff02
EZ
57142011-03-17 Eli Zaretskii <eliz@gnu.org>
5715
5716 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
5717
29a6015a
PE
57182011-03-17 Paul Eggert <eggert@cs.ucla.edu>
5719
a3a6c54e
PE
5720 Fix more problems found by GCC 4.5.2's static checks.
5721
b766f867
PE
5722 * process.c (make_serial_process_unwind, send_process_trap):
5723 (sigchld_handler): Now static.
5724
be02381c
PE
5725 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
5726 That way, the code declares only the vars that it needs.
5727 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
5728 * s/cygwin.h (PTY_ITERATION): Likewise.
5729 * s/darwin.h (PTY_ITERATION): Likewise.
5730 * s/gnu-linux.h (PTY_ITERATION): Likewise.
5731
57048744
PE
5732 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
5733 * process.c (allocate_pty): Don't declare stb unless it's needed.
5734
7914961c 5735 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
5736 (CONSTANTLIM): Remove; unused.
5737 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
5738 Define only if needed.
7914961c 5739
b3967b18
PE
5740 * unexelf.c (unexec): Name an expression,
5741 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
5742 Use a different way to cause a compilation error if anyone uses
5743 n rather than nn, a way that does not involve shadowing.
73366a00 5744 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 5745
29a6015a
PE
5746 * deps.mk (unexalpha.o): Remove; unused.
5747
43cfc33e 5748 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 5749 * unexec.h: New file.
ce701a33
PE
5750 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
5751 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
5752 Depend on unexec.h.
5753 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
5754 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
5755 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 5756 Change as necessary to match prototype in unexec.h.
ce701a33 5757
01f44d5a
PE
5758 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
5759 shadowing.
4f63c6bb 5760 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 5761
a6670b0b
PE
5762 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
5763 Rename locals to avoid shadowing.
5764
cef2010d 5765 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 5766 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 5767
d4d7173a
PE
5768 * print.c (Fredirect_debugging_output): Fix pointer signedess.
5769
f08b802a
PE
5770 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
5771 warning when compiling print.c.
5772
3ddb0639
PE
5773 * font.c (font_unparse_fcname): Abort in an "impossible" situation
5774 instead of using an uninitialized var.
5ad03b97 5775 (font_sort_entities): Mark var as initialized.
3ddb0639 5776
170a2692
PE
5777 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
5778
e663c700
PE
5779 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
5780 pointers to constants.
89bc529a 5781 (font_parse_fcname): Remove unused vars.
7b81e2d0 5782 (font_delete_unmatched): Now static.
ea838e10 5783 (font_get_spec): Remove; unused.
13a547c6
PE
5784 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
5785 (font_update_drivers, Ffont_get_glyphs, font_add_log):
5786 Rename or move locals to avoid shadowing.
e663c700 5787
2a80c887 5788 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 5789 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 5790
1384fa33 5791 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 5792 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 5793
8b2c52e9
PE
5794 * alloc.c (mark_backtrace): Move decl from here ...
5795 * lisp.h: ... to here, so that it can be checked.
5796
475545b5 5797 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 5798 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
5799 (lisp_indirect_variable): Name an expression,
5800 to avoid gcc -Wbad-function-cast warning.
1faed8ae 5801 (Fdefvar): Rename locals to avoid shadowing.
475545b5 5802
b1349114 5803 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 5804 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 5805 Use const pointer when appropriate.
b1349114 5806
a2928364
PE
5807 * lisp.h (get_system_name, get_operating_system_release):
5808 Move decls here, to check interfaces.
5809 * process.c (get_operating_system_release): Move decl to lisp.h.
5810 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
5811 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
5812 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
5813 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
5814 (Fformat_time_string, Fencode_time, Finsert_char):
5815 (Ftranslate_region_internal, Fformat):
5816 Rename or remove local vars to avoid shadowing.
9710023e 5817 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 5818
a415e694
PE
5819 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
5820 avoid shadowing.
5821
8ef4622d
PE
5822 * lisp.h (eassert): Check that the argument compiles, even if
5823 ENABLE_CHECKING is not defined.
5824
946f9a5b
PE
5825 * data.c (Findirect_variable): Name an expression, to avoid
5826 gcc -Wbad-function-cast warning.
112396d6 5827 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 5828 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
5829 (Fmake_variable_buffer_local, Fmake_local_variable):
5830 Mark variables as initialized.
52746918 5831 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 5832
e5aab7e7 5833 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
5834 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
5835 Rename locals to avoid shadowing.
dff45157
PE
5836 (mark_stack): Move local variables into the #ifdef region where
5837 they're used.
7bc26fdb
PE
5838 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
5839 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
5840 needed otherwise.
5841 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
5842 (GC_STRING_CHARS): Remove; not used.
d40d4be1 5843 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 5844
e5aab7e7
PE
5845 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
5846 avoids undefined behavior in theory.
5847
4da60324
PE
5848 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
5849
88043301
PE
5850 Use functions, not macros, for up- and down-casing (Bug#8254).
5851 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5852 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
5853 to use the following functions instead of these macros.
5854 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
5855 EMACS_INT, since callers assume the returned value fits in int.
5856 (upcase1): Likewise, for UPCASE_TABLE.
5857 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 5858 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 5859 the race-condition problem in the old DOWNCASE.
88043301 5860
19ed5445
PE
5861 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
5862 Rename locals to avoid shadowing.
5863 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
5864 (regex_compile, re_search_2, re_match_2_internal):
5865 Remove unused local vars.
952db0d7
PE
5866 (FREE_VAR): Rewrite so as not to use empty "else",
5867 which gcc can warn about.
da053e48 5868 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
5869 (RETALLOC_IF): Define only if needed.
5870 (WORDCHAR_P): Likewise. This one is never needed, but is used
5871 only in a comment talking about a compiler bug, so put inside
5872 the #if 0 of that comment.
5873 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
5874 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
5875 Remove; unused.
19ed5445 5876
1f3561e4 5877 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
5878 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
5879 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 5880
ded6f8f7
PE
5881 * search.c (simple_search): Remove unused var.
5882
dbd37a95
PE
5883 * dired.c (compile_pattern): Move decl from here ...
5884 * lisp.h: ... to here, so that it can be checked.
5885 (struct re_registers): New forward decl.
5886
7e47afad
PE
5887 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
5888
85f24f61
PE
5889 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
5890 All uses changed.
5891 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
5892 Rename locals to avoid shadowing.
5671df8f 5893 (Fvertical_motion): Mark locals as initialized.
85f24f61 5894
181aa2be 5895 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 5896 (casify_region): Mark local as initialized.
181aa2be 5897
930d429c
PE
5898 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
5899
7082eac6
PE
5900 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
5901 New macros, so that the caller can use some names other than
5902 gcpro1, gcpro2, etc.
5903 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
5904 of the new macros.
5905 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
5906 argument, for consistency with GCPRO2_VAR, etc: it is now the
5907 prefix of the variable, not the variable itself. All uses
5908 changed.
38b2c076
PE
5909 * dired.c (directory_files_internal, file_name_completion):
5910 Rename locals to avoid shadowing.
5911
15206ed9
PE
5912 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
5913 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
5914 dired.c's scmp function, had undefined behavior.
5915 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
5916 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
5917 * buffer.h: ... to here, because these macros use current_buffer,
5918 and the new implementation with inline functions needs to have
5919 current_buffer in scope now, rather than later when the macros
5920 are used.
5921 (downcase, upcase1): New static inline functions.
5922 (DOWNCASE, UPCASE1): Reimplement using these functions.
5923 This avoids undefined behavior in expressions like
5924 DOWNCASE (x) == DOWNCASE (y), which previously suffered
5925 from race conditions in accessing the global variables
5926 case_temp1 and case_temp2.
5927 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
5928 * lisp.h (case_temp1, case_temp2): Remove their decls.
5929 * character.h (ASCII_CHAR_P): Move from here ...
5930 * lisp.h: ... to here, so that the inline functions mentioned
5931 above can use them.
5932
4a6bea26
PE
5933 * dired.c (directory_files_internal_unwind): Now static.
5934
f14b7e14
PE
5935 * fileio.c (file_name_as_directory, directory_file_name):
5936 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
5937 Now static.
2893f146
PE
5938 (file_name_as_directory): Use const pointers when appropriate.
5939 (Fexpand_file_name): Likewise. In particular, newdir might
5940 point at constant storage, so make it a const pointer.
fd4ead52 5941 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
5942 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
5943 signedness issues.
f839df0c
PE
5944 (Fset_file_times, Finsert_file_contents, auto_save_error):
5945 Rename locals to avoid shadowing.
f14b7e14 5946
5716756e 5947 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
5948 (Ftry_completion, Fall_completions): Rename or remove locals
5949 to avoid shadowing.
5716756e 5950
b4c3046a
PE
5951 * marker.c (bytepos_to_charpos): Remove; unused.
5952
b45db522
PE
5953 * lisp.h (verify_bytepos, count_markers): New decls,
5954 so that gcc does not warn that these functions aren't declared.
5955
85876d07
PE
5956 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
5957 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 5958 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 5959 (copy_text): Remove unused local var.
85876d07 5960
03d78a21 5961 * filelock.c (within_one_second): Now static.
b3dd38ab 5962 (lock_file_1): Rename local to avoid shadowing.
03d78a21 5963
5df8f01b
PE
5964 * buffer.c (fix_overlays_before): Mark locals as initialized.
5965 (fix_start_end_in_overlays): Likewise. This function should be
5966 simplified by using pointers-to-pointers, but that's a different
5967 matter.
b1d876f1 5968 (switch_to_buffer_1): Now static.
8f54f30a
PE
5969 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
5970 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 5971
a70072c9 5972 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 5973 Fix pointer signedness issue.
edced198
PE
5974 (sys_subshell): Mark local as volatile if checking for lint,
5975 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 5976 (MAXPATHLEN): Define only if needed.
a70072c9 5977
a0977c44
PE
5978 * process.c (serial_open, serial_configure): Move decls from here ...
5979 * systty.h: ... to here, so that they can be checked.
5980
a884fdcc
PE
5981 * fns.c (get_random, seed_random): Move extern decls from here ...
5982 * lisp.h: ... to here, so that they can be checked.
5983
604efe86 5984 * sysdep.c (reset_io): Now static.
b8950c94 5985 (wait_for_termination_signal): Remove; unused.
604efe86 5986
38fc62d9
PE
5987 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
5988 (copy_keymap_item, append_key, push_text_char_description):
5989 Now static.
1004a21a 5990 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 5991 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
5992 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
5993 (describe_map_tree):
5994 Rename locals to avoid shadowing.
38fc62d9 5995
2f2650da
PE
5996 * keyboard.c: Declare functions static if they are not used elsewhere.
5997 (echo_char, echo_dash, cmd_error, top_level_2):
5998 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
5999 (read_char, kbd_buffer_get_event, make_lispy_position):
6000 (make_lispy_event, make_lispy_movement, apply_modifiers):
6001 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
6002 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
6003 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 6004 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 6005 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 6006
a053e86c 6007 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
6008 (mark_kboards): Move decl here ...
6009 * alloc.c (mark_kboards): ... from here.
a053e86c 6010
4752793e
PE
6011 * lisp.h (force_auto_save_soon): New decl.
6012
74f10ca7 6013 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
6014 (DEFINE_DUMMY_FUNCTION): New macro.
6015 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
6016 Use it.
c03cd23f
PE
6017 (main): Add casts to avoid warnings
6018 if GCC considers string literals to be constants.
74f10ca7 6019
022e70d4
PE
6020 * lisp.h (fatal_error_signal): Add decl, since it's exported.
6021
59d6fe83
PE
6022 * dbusbind.c: Pointer signedness fixes.
6023 (xd_signature, xd_append_arg, xd_initialize):
6024 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6025 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6026 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
6027 (Fdbus_register_signal): Use SSDATA when the context wants char *.
6028
78320123
PE
6029 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
6030 if GCC considers string literals to be constants.
49cebcca 6031 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 6032
35ac2a97
SM
60332011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
6034
fb103ca9
SM
6035 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
6036 (print_preprocess, print_object): New macro to fix last change.
6037
35ac2a97
SM
6038 * print.c (print_preprocess): Don't forget font objects.
6039
62973b41
JB
60402011-03-16 Juanma Barranquero <lekktu@gmail.com>
6041
6042 * emacs.c (USAGE3): Doc fixes.
6043
0e48bb22
AS
60442011-03-15 Andreas Schwab <schwab@linux-m68k.org>
6045
6046 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
6047 structure.
6048
7684e57b
JB
60492011-03-14 Juanma Barranquero <lekktu@gmail.com>
6050
6051 * lisp.h (VWindow_system, Qfile_name_history):
6052 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
6053 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
6054 (w32_system_caret_x, w32_system_caret_y): Declare extern.
6055
6056 * w32select.c: Don't #include "keyboard.h".
c96bbc66 6057 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
6058
6059 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
6060 * w32console.c (detect_input_pending, read_input_pending)
6061 (encode_terminal_code):
6062 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
6063 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
6064 (w32_system_caret_y, Qfile_name_history):
6065 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
6066 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
6067 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
6068 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
6069 * w32proc.c (Qlocal, report_file_error):
6070 * w32term.c (Vwindow_system, updating_frame):
6071 * w32uniscribe.c (initialized, uniscribe_font_driver):
6072 Remove unneeded extern declarations.
6073
2aa46d6c
CY
60742011-03-14 Chong Yidong <cyd@stupidchicken.com>
6075
c96bbc66 6076 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 6077
cffc6f3b
CY
60782011-03-13 Chong Yidong <cyd@stupidchicken.com>
6079
6080 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
6081 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
6082 These macros can no longer be used for assignment.
6083
44f230aa
SM
6084 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
6085 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
6086 (record_buffer_markers, fetch_buffer_markers): New functions for
6087 recording and fetching special buffer markers.
6088 (set_buffer_internal_1, set_buffer_temp): Use them.
6089
6090 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
6091
6092 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
6093
6094 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
6095 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
6096
6097 * xdisp.c (hscroll_window_tree):
6098 (reconsider_clip_changes): Use PT instead of BUF_PT.
6099
d251f04b
EZ
61002011-03-13 Eli Zaretskii <eliz@gnu.org>
6101
6102 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
6103 $(EMACS_ROOT)/lib/intprops.h.
6104
f0c77cd1
PE
61052011-03-13 Paul Eggert <eggert@cs.ucla.edu>
6106
3eca4629
PE
6107 Fix more problems found by GCC 4.5.2's static checks.
6108
7c86ee98
PE
6109 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
6110 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
6111 (xg_free_frame_widgets): Make it clear that a local variable is
6112 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
6113 (gdk_window_get_screen): Make it clear that this macro is needed
6114 only if USE_GTK_TOOLTIP.
1e5524e7
PE
6115 (int_gtk_range_get_value): New function, which avoids a diagnostic
6116 from gcc -Wbad-function-cast.
6117 (xg_set_toolkit_scroll_bar_thumb): Use it.
6118 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
6119 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
6120 (get_utf8_string, xg_get_file_with_chooser):
6121 Rename locals to avoid shadowing.
6122 (create_dialog): Move locals to avoid shadowing.
7c86ee98 6123
41729b81
PE
6124 * xgselect.c (xg_select): Remove unused var.
6125
f0c77cd1
PE
6126 * image.c (four_corners_best): Mark locals as initialized.
6127 (gif_load): Initialize transparent_p to zero (Bug#8238).
6128 Mark another local as initialized.
ec6cf4c6 6129 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 6130
ce0ad53d 6131 * image.c (clear_image_cache): Now static.
d5d5a617 6132 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 6133 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
6134 (x_edge_detection): Remove unnecessary cast that
6135 gcc -Wbad-function-cast diagnoses.
2037898d 6136 (gif_load): Fix pointer signedness.
6ae141d6
PE
6137 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
6138 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 6139
33383987 61402011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 6141
d32df629
PE
6142 Improve quality of tests for time stamp overflow.
6143 For example, without this patch (encode-time 0 0 0 1 1
6144 1152921504606846976) returns the obviously-bogus value (-948597
6145 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
6146 reports time overflow. See
6147 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
6148 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
6149 * editfns.c: Include limits.h and intprops.h.
6150 (TIME_T_MIN, TIME_T_MAX): New macros.
6151 (time_overflow): Move earlier, to before first use.
6152 (hi_time, lo_time): New functions, for an accurate test for
6153 out-of-range times.
6154 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
6155 (Fget_internal_run_time): Don't assume time_t fits in int.
6156 (make_time): Use list2 instead of Fcons twice.
6157 (Fdecode_time): More accurate test for out-of-range times.
6158 (check_tm_member): New function.
6159 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
6160 (lisp_time_argument): Don't rely on undefined left-shift and
6161 right-shift behavior when checking for time stamp overflow.
8be6f318 6162
fe31d94c
PE
6163 * editfns.c (time_overflow): New function, refactoring common code.
6164 (Fformat_time_string, Fdecode_time, Fencode_time):
6165 (Fcurrent_time_string): Use it.
6166
8be6f318
PE
6167 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
6168 * dired.c (make_time): Move to ...
6169 * editfns.c (make_time): ... here.
6170 * systime.h: Note the move.
6171
09d9db2c 61722011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 6173
126bc0dc
YM
6174 * fringe.c (update_window_fringes): Remove unused variables.
6175
c47cbdfd
YM
6176 * unexmacosx.c (copy_data_segment): Also copy __got section.
6177 (Bug#8223)
6178
7ac80be9
EZ
61792011-03-12 Eli Zaretskii <eliz@gnu.org>
6180
c96bbc66 6181 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
6182 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
6183 Constify `char *' arguments and their references according to
6184 prototypes in tparam.h.
6185
ecb0f94d 6186 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 6187
7ac80be9
EZ
6188 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
6189 Adapt all references accordingly.
6190
6191 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
6192
ef1fd07e
TT
61932011-03-11 Tom Tromey <tromey@redhat.com>
6194
6195 * buffer.c (syms_of_buffer): Remove obsolete comment.
6196
7ef4b50c
EZ
61972011-03-11 Eli Zaretskii <eliz@gnu.org>
6198
6199 * termhooks.h (encode_terminal_code): Declare prototype.
6200
6201 * msdos.c (encode_terminal_code): Don't declare prototype.
6202
6203 * term.c (encode_terminal_code): Now external again, used by
6204 w32console.c and msdos.c.
6205
44f230aa
SM
6206 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
6207 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 6208
4b1ec863 62092011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 6210
1714f52b 6211 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 6212
4b1ec863
PE
6213 * fringe.c (update_window_fringes): Mark locals as initialized
6214 (Bug#8227).
6215 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 6216
524c7aa6
PE
6217 * alloc.c (mark_fringe_data): Move decl from here ...
6218 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
6219 to check its interface.
6220 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
6221
a5c0af81 6222 * fontset.c (free_realized_fontset): Now static.
7519b8cd 6223 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 6224 (fontset_font): Mark local as initialized.
a9a06e0b 6225 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 6226
b4716021
PE
6227 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
6228
811e9bac 6229 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 6230 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
6231 (x_own_selection, Fx_disown_selection_internal): Rename locals
6232 to avoid shadowing.
6233 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 6234
7e3ab302
PE
6235 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
6236 so that the caller can use some name other than gcpro1.
6237 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
6238 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6239 (Fx_backspace_delete_keys_p):
6240 Use them to avoid shadowing, and rename vars to avoid shadowing.
6241 (x_decode_color, x_set_name, x_window): Now static.
6b437900 6242 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 6243 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
6244 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
6245 Remove unused locals.
7e3ab302
PE
6246 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
6247 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
6248 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
6249 macros.
f78faa98 6250
e2b13473
PE
6251 * xterm.h (x_mouse_leave): New decl.
6252
77f23912
PE
6253 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
6254 Remove unused functions.
cdf4ba58
PE
6255 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
6256 (x_calc_absolute_position): Now static.
7411c686 6257 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 6258 Don't declare local "event" unless it's used.
ed7bf3a5
PE
6259 (x_iconify_frame, x_free_frame_resources): Don't declare locals
6260 unless they are used.
38d0b34a
PE
6261 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
6262 (x_fatal_error_signal): Remove; not used.
a6067996
PE
6263 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
6264 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
6265 (x_error_catcher, x_connection_closed, x_error_handler):
6266 (x_error_quitter, xembed_send_message, x_iconify_frame):
6267 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 6268 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 6269 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 6270
44f230aa
SM
6271 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
6272 Rename or move locals to avoid shadowing.
6b463e58 6273 (tty_defined_color, merge_face_heights): Now static.
5967d051 6274 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
6275 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
6276 does not deduce is never used uninitialized.
73719eba
PE
6277 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
6278 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 6279
426994c3 6280 * terminal.c (store_terminal_param): Now static.
5489860b 6281
032f1620 6282 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 6283 (set_frame_menubar): Remove unused local.
d4323972 6284 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
6285 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
6286 since they might point to immutable storage.
281585b0
PE
6287 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
6288 since it's unused otherwise.
032f1620 6289
367c19e5 6290 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 6291 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
6292 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
6293 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 6294 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
6295 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
6296 does not deduce are never used uninitialized.
70739cbe 6297
07b48fa9
PE
6298 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
6299
8868a238 6300 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
6301 * window.c (window_loop, size_window):
6302 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 6303
7e5cf297 6304 * window.c (display_buffer): Now static.
d6550a9f
PE
6305 (size_window): Mark variables that gcc -Wuninitialized
6306 does not deduce are never used uninitialized.
a586633d
PE
6307 * window.h (check_all_windows): New decl, to forestall
6308 gcc -Wmissing-prototypes diagnostic.
5b555da1 6309 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 6310
f6095868
PE
6311 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
6312 shadowing.
6313 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
6314 Include <limits.h>.
6315 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
6316 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
6317 (load_charset_map): Mark variables that gcc -Wuninitialized
6318 does not deduce are never used uninitialized.
53df7c11 6319 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 6320
f38b440c
PE
6321 * coding.c (coding_set_source, coding_set_destination):
6322 Use "else { /* comment */ }" rather than "else /* comment */;"
6323 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
6324 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
6325 a block, when the outer 'i' will do.
6326 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
6327 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
6328 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
6329 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
6330 (Fdecode_sjis_char, Fdefine_coding_system_internal):
6331 Rename locals to avoid shadowing.
6332 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
6333 * coding.c (emacs_mule_char, encode_invocation_designation):
6334 Now static, since they're not used elsewhere.
413bb2db 6335 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 6336 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
6337 (decode_coding_emacs_mule): Mark variables that gcc
6338 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
6339 (detect_coding_iso_2022): Initialize a local variable that might
6340 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 6341 this initialization is needed. (Bug#8211)
5f58e762
PE
6342 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
6343 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
6344 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
6345 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
6346 Remove unused macros.
f38b440c 6347
232b38b9 6348 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 6349 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 6350 * character.c (string_count_byte8): Likewise.
232b38b9 6351
fb90da1b
PE
6352 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
6353 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
6354
fb93dbc2
PE
6355 * chartab.c (copy_sub_char_table): Now static, since it's not used
6356 elsewhere.
5c156ace
PE
6357 (sub_char_table_ref_and_range, char_table_ref_and_range):
6358 Rename locals to avoid shadowing.
bbcd0949 6359 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 6360
7d3b3862 6361 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 6362 (BIDI_BOB): Remove unused macro.
7d3b3862 6363
6be7d3da
PE
6364 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
6365 deduce are never used uninitialized.
c2ed9c8b 6366 * term.c (encode_terminal_code): Likewise.
6be7d3da 6367
75f8807f 6368 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 6369
50938595
PE
6370 * tparam.h: New file.
6371 * term.c, tparam.h: Include it.
6372 * deps.mk (term.o, tparam.o): Depend on tparam.h.
6373 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
6374 Move these decls to tparam.h, and make them agree with what
6375 is actually in tparam.c. The previous trick of using incompatible
6376 decls in different modules does not conform to the C standard.
6377 All callers of tparam changed to use tparam's actual API.
6378 * tparam.c (tparam1, tparam, tgoto):
6379 Use const pointers where appropriate.
6380
fbceeba2
PE
6381 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
6382 * cm.h (struct cm): Likewise.
6383 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
6384 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
6385 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
6386 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
6387 (turn_on_face, init_tty): Likewise.
6388 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 6389
7f3f1250
PE
6390 * term.c (term_mouse_position): Rename local to avoid shadowing.
6391
e6ca6543
PE
6392 * alloc.c (mark_ttys): Move decl from here ...
6393 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
6394
c40f8d15
AS
63952011-03-11 Andreas Schwab <schwab@linux-m68k.org>
6396
6397 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
6398
cfe0661d
JB
63992011-03-09 Juanma Barranquero <lekktu@gmail.com>
6400
6401 * search.c (compile_pattern_1): Remove argument regp, unused since
6402 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
6403 (compile_pattern): Don't pass it.
6404
0afb4571
J
64052011-03-08 Jan Djärv <jan.h.d@swipnet.se>
6406
6407 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
6408 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
6409 for ! HAVE_GTK3.
6410 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
6411
6412 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
6413
6414 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
6415 gdk_window_get_screen, gdk_window_get_geometry,
6416 gdk_x11_window_lookup_for_display and GDK_KEY_g.
6417 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
6418 (xg_get_pixbuf_from_pixmap): New function.
6419 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
6420 to Pixmap, take frame as parameter, remove GdkColormap parameter.
6421 Call xg_get_pixbuf_from_pixmap instead of
6422 gdk_pixbuf_get_from_drawable.
6423 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
6424 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
6425 (xg_check_special_colors): Use GtkStyleContext and its functions
6426 for HAVE_GTK3.
6427 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
6428 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
6429 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
6430 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
6431 Call gtk_widget_get_preferred_size.
0afb4571
J
6432 (xg_frame_resized): gdk_window_get_geometry only takes 5
6433 parameters.
44f230aa
SM
6434 (xg_win_to_widget, xg_event_is_for_menubar):
6435 Call gdk_x11_window_lookup_for_display.
0afb4571
J
6436 (xg_set_widget_bg): New function.
6437 (delete_cb): New function.
895009e1 6438 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
6439 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
6440 (xg_set_background_color): Call xg_set_widget_bg.
6441 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
6442 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
6443 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
6444 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
6445 if ! HAVE_GTK3.
6446 (update_frame_tool_bar): Call gtk_widget_hide.
6447 (xg_initialize): Use GDK_KEY_g.
6448
6449 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
6450 if ! HAVE_GTK3
6451 (x_session_initialize): Call gdk_x11_set_sm_client_id.
6452
6453 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
6454 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
6455 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
6456
1c2cc4ef
JB
64572011-03-08 Juanma Barranquero <lekktu@gmail.com>
6458
6459 * w32xfns.c (select_palette): Check success of RealizePalette against
6460 GDI_ERROR, not zero.
6461
33383987 6462See ChangeLog.11 for earlier changes.
aac0c6e3
MR
6463
6464;; Local Variables:
6465;; coding: utf-8
aac0c6e3
MR
6466;; End:
6467
33383987 6468 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
6469
6470 This file is part of GNU Emacs.
6471
6472 GNU Emacs is free software: you can redistribute it and/or modify
6473 it under the terms of the GNU General Public License as published by
6474 the Free Software Foundation, either version 3 of the License, or
6475 (at your option) any later version.
6476
6477 GNU Emacs is distributed in the hope that it will be useful,
6478 but WITHOUT ANY WARRANTY; without even the implied warranty of
6479 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
6480 GNU General Public License for more details.
6481
6482 You should have received a copy of the GNU General Public License
6483 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.