message.el: Make header fill function work properly
[bpt/emacs.git] / src / ChangeLog
CommitLineData
eeaea515
DA
12012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
2
3 Revert last save_excursion_save and save_excursion_restore changes.
4 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
5 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
6
073c88c2
DA
72012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
8
9 Fix recently-introduced typos in Windows port.
10 Reported by Martin Rudalics <rudalics@gmx.at>.
11 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 12 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 13
4706125e
PE
142012-07-27 Paul Eggert <eggert@cs.ucla.edu>
15
16 Improve GDB symbol export (Bug#12036).
17 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
18 arms of an 'if', not using conditional expressions; otherwise GDB
19 complains about the types in the unevaluated arm when the argument
20 is an integer literal.
21 (xgetint): Simplify expression.
22 * alloc.c (gdb_make_enums_visible): New constant. This ports to
23 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
24 Zaretskii in <http://bugs.gnu.org/12036#13>.
25 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
26 needed now that we have gdb_make_enums_visible.
27 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
28 (enum enum_USE_LSB_TAG):
29 New enum types, packaging up enums that need to be exported to GDB.
30
694b6c97
DA
312012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
32
33 Utility function to make a list from specified amount of objects.
34 * lisp.h (enum constype): New datatype.
35 (listn): New prototype.
36 * alloc.c (listn): New function.
37 (Fmemory_use_count, syms_of_alloc): Use it.
38 * buffer.c (syms_of_buffer): Likewise.
39 * callint.c (syms_of_callint): Likewise.
40 * charset.c (define_charset_internal): Likewise.
41 * coding.c (syms_of_coding): Likewise.
42 * keymap.c (syms_of_keymap): Likewise.
43 * search.c (syms_of_search): Likewise.
44 * syntax.c (syms_of_syntax): Likewise.
45 * w32.c (init_environment): Likewise.
46 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
47 * xdisp.c (syms_of_xdisp): Likewise.
48 * xfns.c (syms_of_xfns): Likewise.
49
6195f384
DA
502012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
51
52 Fast save_excursion_save and save_excursion_restore.
53 * lisp.h (struct Lisp_Excursion): New data type.
54 (PVEC_EXCURSION): New pseudovector type.
55 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
56 to deal with it. Adjust comments.
57 (init_marker, attach_marker): New prototype.
58 (unchain_marker): Adjust prototype.
59 * marker.c (attach_marker): Change to global.
60 (init_marker): New function.
61 * alloc.c (Fmake_marker, build_marker): Use it.
62 (build_marker): More easserts.
63 (mark_object): Handle struct Lisp_Excursion.
64 * editfns.c (save_excursion_save, save_excursion_restore):
65 Reimplement to use struct Lisp_Excursion. Add comments.
66
5eceb8fb
PE
672012-07-26 Paul Eggert <eggert@cs.ucla.edu>
68
69 Fix export of symbols to GDB (Bug#12036).
70 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
71 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
72 emacs.c, as this is a more-suitable home. Had this been done earlier
73 the fix for 12036 would have avoided some of the problems noted in
74 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
75 would have been more obvious.
562157c8
PE
76 * emacs.c: Do not include <verify.h>; no longer needed.
77 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
78 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
79 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
80 Remove; now done in lisp.h.
81 * lisp.h (PUBLISH_TO_GDB): New macro.
82 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
83 (DATA_SEG_BITS): Use it.
84 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
85 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
86 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
87 not be usable in #if. This simplifies things.
88
d6749401
JB
892012-07-26 Juanma Barranquero <lekktu@gmail.com>
90
91 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
92
1781b9e9
PE
932012-07-26 Paul Eggert <eggert@cs.ucla.edu>
94
d89518db 95 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
96 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
97 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
98 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
99 Adjust to changes in lisp.h and emacs.c, by using
100 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
101 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
102 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
103 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
104 instead of gdb_valbits.
105 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
106 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
107 instead of gdb_array_mark_flag.
108 (xboolvector): Get size from $->size, not $->header.size.
109 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
110 (xreload, hook-run, hookpost-run): Remove.
111 * emacs.c: Include <verify.h>.
112 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
113 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
114 Remove.
115 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
116 (gdb_USE_LSB_TAG): New enum constants.
117 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
118 Also define these as enum constants, so they're visible to GDB.
119 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
120 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
121 as constants, so they're visible to GDB.
122 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
123 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
124 Now enum constants, not macros, so they're visible to GDB.
125 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
126 more convenient now. All uses changed.
127 (VALMASK) [USE_LSB_TAG]: Also define in this case.
128 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
129
3628596a
DA
1302012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
131
132 Explicitly free restriction data that are not needed anymore.
133 * editfns.c (save_restriction_restore): Free restriction data.
134
7abaf5cc
SM
1352012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
136
137 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
138 add argument, tune behavior, and adjust all callers.
139
71f88e00
PE
1402012-07-25 Paul Eggert <eggert@cs.ucla.edu>
141
142 Use typedef for EMACS_INT, EMACS_UINT.
143 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
144 than macros. This simplifies debugging in the usual case, since
145 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
146 and it allows expressions involving EMACS_INT casts.
147 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
148
57ec3034
JD
1492012-07-25 Jan Djärv <jan.h.d@swipnet.se>
150
151 * nsterm.m (ns_read_socket): Return early if there is a modal
152 window (Bug#12043).
153
8137e7b3
MR
1542012-07-25 Martin Rudalics <rudalics@gmx.at>
155
156 * frame.c (Fredirect_frame_focus): In doc-string don't mention
157 that FOCUS-FRAME can be omitted.
158
04e9897c
DA
1592012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
160
161 Adjust buffer text indirection counters at the end of Fkill_buffer.
162 * buffer.c (Fkill_buffer): Adjust indirection counters when the
163 buffer is definitely dead. This should really fix an issue reported
164 by Christoph Scholtes again. (Bug#12007).
165 (init_buffer_once): Initialize indirection counters of
166 buffer_defaults and buffer_local_symbols (for sanity and safety).
167
8a0484e1
EZ
1682012-07-24 Eli Zaretskii <eliz@gnu.org>
169
170 * xdisp.c (init_iterator): Don't compute dimensions of truncation
171 and continuation glyphs on tooltip frames, leave them at zero.
172 Avoids continued lines in tooltips. (Bug#11832)
173
fa691a83
DA
1742012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
175
176 Simplify copy_overlay.
04e9897c 177 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
178 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
179
436bc8e0
EZ
1802012-07-23 Eli Zaretskii <eliz@gnu.org>
181
182 * print.c (print_object): Don't crash when a frame's name is nil
183 or invalid. (Bug#12025)
184
185 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
186 it signals an error when a tooltip frame is being created.
187
d7a7fda3
DA
1882012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
189
190 Cleanup miscellaneous objects allocation and initialization.
191 * alloc.c (allocate_misc): Change to static. Add argument to
192 specify the subtype. Adjust comment and users.
193 (build_overlay): New function.
194 * buffer.c (copy_overlays, Fmake_overlay): Use it.
195 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
196 (allocate_misc): Remove prototype.
197 (build_overlay): Add prototype.
198
1992012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
200
201 Swap buffer text indirection counters in Fbuffer_swap_text.
202 * buffer.c (Fbuffer_swap_text): Swap indirections too.
203 This avoids crash reported by Christoph Scholtes at
204 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
205
9d7fa573
JD
2062012-07-22 Jan Djärv <jan.h.d@swipnet.se>
207
208 * nsmenu.m (Popdown_data): New struct.
209 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
210 free Popdown_data.
211 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
212 (initWithContentRect): Make imgView and contentView non-static
213 and autorelease them. Also autorelease img and matrix (Bug#12005).
214 (dealloc): Remove (Bug#12005).
215
0dd6d66d
DA
2162012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
217
218 Adjust consing_since_gc when objects are explicitly freed.
219 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
220 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
221 (free_cons, free_misc): Subtract object size from consing_since_gc.
222
d36d71df
DA
2232012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
224
225 Simplify and cleanup markers positioning code.
226 * marker.c (attach_marker): More useful eassert.
227 (live_buffer, set_marker_internal): New function.
228 (Fset_marker, set_marker_restricted): Use set_marker_internal.
229 (set_marker_both, set_marker_restricted_both): Use live_buffer.
230
fb9ea40f
PE
2312012-07-22 Paul Eggert <eggert@cs.ucla.edu>
232
233 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
234 as it's limited by the amount of memory, not by INT_MAX.
235
2d5c5f7d
EZ
2362012-07-21 Eli Zaretskii <eliz@gnu.org>
237
07fb592e
EZ
238 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
239 in special-event-map. See the discussion at
240 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
241 for the reasons.
242
37a9eac8 243 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
244 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
245 Fabrice Popineau <fabrice.popineau@supelec.fr>.
246
c4328746
JD
2472012-07-21 Jan Djärv <jan.h.d@swipnet.se>
248
249 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 250 (conversationIdentifier): Return value is NSInteger.
784051c4 251 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 252
6e5d1c12
CY
2532012-07-21 Chong Yidong <cyd@gnu.org>
254
255 * window.c (decode_any_window): Signal an error if the window is
256 on a dead frame (Bug#11984).
257
9928463d
DA
2582012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
259
260 Add indirection counting to speed up Fkill_buffer.
261 * buffer.h (struct buffer): New member.
262 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
263 (Fmake_indirect_buffer): Set indirection counter to -1, increment
264 base buffer indirection counter.
265 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
266 (Fkill_buffer): Adjust indirection counters as needed, don't walk
267 through buffer list if indirection counter is 0.
268
f8643a6b
DA
2692012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
270
271 Extend the value returned by Fgarbage_collect with heap statistics.
272 * alloc.c (Qheap): New symbol.
273 (syms_of_alloc): DEFSYM it.
274 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
275 (Fmemory_free): Remove.
276 (syms_of_alloc): Don't defsubr it.
277 * buffer.c (Fcompact_buffer): Remove.
278 (syms_of_buffer): Don't defsubr it.
279
dac616ff
DA
2802012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
281
282 Make maybe_gc inline.
283 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
284 * lisp.h (consing_since_gc, gc_relative_threshold)
285 (memory_full_cons_threshold): Revert declaration.
286 (maybe_gc): Remove prototype, define as inline.
287 * alloc.c: Remove old commented-out code.
288 (consing_since_gc, gc_relative_threshold)
289 (memory_full_cons_threshold): Revert to global.
290 (maybe_gc): Remove.
291
d7ea76b4
DA
2922012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
293
294 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
295 * lisp.h (build_unibyte_string): New function.
296 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
297 * sysdep.c, w32fns.c, xfns.c: Use it.
298 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
299 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
300 Adjust users accordingly.
301 * font.h (font_open_by_name): Adjust prototype.
302
765e61e3
DA
3032012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
304
305 Cleanup calls to Fgarbage_collect.
306 * lisp.h (maybe_gc): New prototype.
307 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
308 Remove declarations.
309 * alloc.c (maybe_gc): New function.
310 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
311 Make them static.
312 * bytecode.c (MAYBE_GC): Use maybe_gc.
313 * eval.c (eval_sub, Ffuncall): Likewise.
314 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
315 to avoid dependency from auto-save feature.
316
52b852c7
PE
3172012-07-19 Paul Eggert <eggert@cs.ucla.edu>
318
319 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
320 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
321 'for_each_per_buffer_object_at'.
322 All uses changed. It's better to use upper-case for macros that
323 cannot be implemented as functions, to give the reader a clue
324 that they're special.
325
5db81e33
SM
3262012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
327
328 * alloc.c (Fgarbage_collect): Tweak docstring.
329
5b835e1d
DA
3302012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
331
332 Tweak the value returned from Fgarbage_collect again.
333 * alloc.c (Fgarbage_collect): New return value, as confirmed in
334 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
335 Adjust documentation.
336 (total_vector_bytes): Rename to total_vector_slots, adjust
337 accounting.
338 (total_free_vector_bytes): Rename to total_free_vector_slots,
339 adjust accounting.
340 (Qstring_bytes, Qvector_slots): New symbols.
341 (syms_of_alloc): DEFSYM them.
342
9cd47b72
DA
3432012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
344
345 Buffer compaction primitive which may be used from Lisp.
346 * buffer.c (compact_buffer, Fcompact_buffer): New function.
347 (syms_of_buffer): Register Fcompact_buffer.
348 * alloc.c (Fgarbage_collect): Use compact_buffer.
349 * buffer.h (compact_buffer): New prototype.
350 (struct buffer_text): New member.
351
d17337e5
DA
3522012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
353
354 New macro to iterate over all buffers, miscellaneous cleanups.
355 * lisp.h (all_buffers): Remove declaration.
356 * buffer.h (all_buffers): Add declaration, with comment.
357 (for_each_buffer): New macro.
358 * alloc.c (Fgarbage_collect, mark_object): Use it.
359 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
360 (init_buffer): Likewise.
361 * data.c (Fset_default): Likewise.
362 * coding.c (code_conversion_restore): Remove redundant check
363 for dead buffer.
364 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
365
60cfd278
AS
3662012-07-18 Andreas Schwab <schwab@linux-m68k.org>
367
368 Fix bug that created negative-length intervals.
369 * intervals.c (merge_interval_right, merge_interval_left):
370 Do not zero out this interval if it is absorbed by its children,
371 as this interval's total length doesn't change in that case. See
372 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
373
d06714cb
PE
3742012-07-18 Paul Eggert <eggert@cs.ucla.edu>
375
83713154
PE
376 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
377 when invoking (make-bool-vector N t) and N is a positive
378 multiple of 8 -- the last 8 bits were mistakenly cleared.
379
d06714cb
PE
380 Remove some struct layout assumptions in bool vectors.
381 * alloc.c (bool_header_size): New constant.
382 (header_size, word_size): Move earlier, as they're now used earlier.
383 Use 'word_size' in a few more places, where it's appropriate.
384 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
385 padding before the data member of a bool vector.
386 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
387 than doing the check by hand with an abort ().
388
464d5a5e
SM
3892012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
390
5fbc0409
SM
391 * eval.c (Fdefvar): Don't check constants since we only set the var if
392 it's not yet defined anyway (bug#11904).
393
464d5a5e
SM
394 * lisp.h (last_undo_boundary): Declare new var.
395 * keyboard.c (command_loop_1): Set it.
396 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
397 were auto-added by the command loop (bug#11774).
398
8dc2e44a
AS
3992012-07-18 Andreas Schwab <schwab@linux-m68k.org>
400
401 * w32font.c (Qsymbol): Remove local definition.
402 (syms_of_w32font): Don't DEFSYM it.
403
169925ec
DA
4042012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
405
406 Fix sweep_vectors to handle large bool vectors correctly.
407 * alloc.c (sweep_vectors): Account total_vector_bytes for
408 bool vectors larger than VBLOCK_BYTES_MAX.
409
5fbfb018
CY
4102012-07-18 Chong Yidong <cyd@gnu.org>
411
412 * frame.c (x_set_frame_parameters): Revert bogus change introduced
413 in 2012-05-25 commit by Paul Eggert (Bug#11738).
414
3ab6e069
DA
4152012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
416
417 Return more descriptive data from Fgarbage_collect.
418 Suggested by Stefan Monnier in
419 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
420 * alloc.c (bounded_number): New function.
421 (total_buffers, total_vectors): New variable.
422 (total_string_size): Rename to total_string_bytes, adjust users.
423 (total_vector_size): Rename to total_vector_bytes, adjust users.
424 (sweep_vectors): Account total_vectors and total_vector_bytes.
425 (Fgarbage_collect): New return value. Adjust documentation.
426 (gc_sweep): Account total_buffers.
427 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
428 (VECTOR_SIZE): Remove.
429 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
430 (Qinterval, Qmisc): New symbols.
431 (syms_of_data): Initialize them.
432 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
433 (Qcons, Qbuffer): New declarations.
434
6d02fe5b
PE
4352012-07-17 Paul Eggert <eggert@cs.ucla.edu>
436
437 * alloc.c (Fmemory_free): Account for memory-free's own storage.
438 Round up, not down. Improve doc.
439
b7ffe040
DA
4402012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
441
442 Restore old code in allocate_string_data to avoid Faset breakage.
443 Reported by Julien Danjou <julien@danjou.info> in
444 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
445 * alloc.c (allocate_string_data): Restore old code with minor
446 adjustments, fix comment to explain this subtle issue.
447
4dc7c8d5
SM
4482012-07-17 Eli Zaretskii <eliz@gnu.org>
449
450 Remove FILE_SYSTEM_CASE.
451 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
452
453 * fileio.c (FILE_SYSTEM_CASE): Don't define.
454 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
455 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
456 call-process-region passes it through expand-file-name.
457
458 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
459
4602012-07-17 Andreas Schwab <schwab@linux-m68k.org>
461
462 Fix crash when creating indirect buffer (Bug#11917)
463 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
464 Don't handle unbound variables specially if non-zero.
465 (Fbuffer_local_variables): Pass zero.
466 (clone_per_buffer_values): Pass non-zero.
467
4682012-07-17 Andreas Schwab <schwab@linux-m68k.org>
469
470 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
471 to make the loop interruptible.
472
4732012-07-17 Andreas Schwab <schwab@linux-m68k.org>
474
475 * gnutls.c (emacs_gnutls_handshake): Only retry if
476 GNUTLS_E_INTERRUPTED.
477
cce7fefc
DA
4782012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
479
480 Cleanup and convert miscellaneous checks to eassert.
481 * alloc.c (mark_interval): Fix comment, partially rephrase
482 old comment from intervals.h (see below).
483 * intervals.c (find_interval, adjust_intervals_for_insertion)
484 (delete_interval, adjust_intervals_for_deletion)
485 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
486 Convert to eassert.
487 (adjust_intervals_for_insertion, make_new_interval):
488 Remove obsolete and unused code.
489 * intervals.h (struct interval): Remove obsolete comment.
490 * textprotp.c (erase_properties): Remove unused code.
491 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
492 (Fremove_list_of_text_properties): Convert to eassert.
493
9ea10cc3
CY
4942012-07-17 Chong Yidong <cyd@gnu.org>
495
496 * editfns.c (Finsert_char): Doc fix.
497
3900d5de
DA
4982012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
499
500 Fix previous change to make Fmemory_free always accurate.
501 * alloc.c (make_interval): Update total_free_intervals.
502 (make_float): Likewise for total_free_floats.
503 (free_cons, Fcons): Likewise for total_free_conses.
504 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
505 Likewise for total_free_vector_bytes.
506 (Fmake_symbol): Likewise for total_free_symbols.
507 (bytes_free): Remove.
508
7098646f
DA
5092012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
510
511 Simple free memory accounting feature.
512 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
513 (sweep_vectors): Accumulate size of free vectors.
514 (Fgarbage_collect): Setup bytes_free.
515 (Fmemory_free): New function.
516 (syms_of_alloc): Register it.
517
22657b40
DA
5182012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
519
520 Cleanup overlays checking.
521 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
522 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
523 eassert and OVERLAYP.
524 (sort_overlays): Change to use OVERLAYP.
525
ddfc8813
RK
5262012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
527
528 * editfns.c (Finsert_char): Make it interactive, and make the
529 second arg optional. Copy interactive spec and docstring from
530 ucs-insert.
531
7c26cf3c
PE
5322012-07-17 Paul Eggert <eggert@cs.ucla.edu>
533
534 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
535 Unlike the other wrapped functions, fabs has an unspecified
536 effect on errno.
537
5d127af9
JD
5382012-07-16 Jan Djärv <jan.h.d@swipnet.se>
539
540 * nsterm.m (keyDown): Interpret flags without left/right bits
541 as the left key (Bug#11670).
542
6a0dd1d7
DA
5432012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
544
545 Remove empty and useless init functions.
546 * lisp.h (init_character_once, init_fns, init_image)
547 (init_filelock, init_sound): Remove prototype.
548 * character.c (init_character_once): Remove.
549 * filelock.c (init_filelock): Likewise.
550 * fns.c (init_fns): Likewise.
551 * image.c (init_image): Likewise.
552 * sound.c (init_sound): Likewise.
553 * emacs.c (main): Adjust accordingly.
554
7a6136fd
DA
5552012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
556
557 * gtkutil.h: Tiny cleanups.
558 (use_old_gtk_file_dialog): Remove useless declaration.
559 (xg_uses_old_file_dialog): Add suggested const attribute.
560
ce811ad9
EZ
5612012-07-15 Eli Zaretskii <eliz@gnu.org>
562
563 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
564 (bidi_paragraph_init): Use it to limit search forward for a strong
565 directional character in abnormally large paragraphs full of
566 neutral or weak characters. (Bug#11943)
567
c9adfeaa
SF
5682012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
569
570 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
571 the toolbar (Bug#9451).
572 (xg_make_tool_item): Give the widget event box a transparent
573 background.
574
fff62aa9
DA
5752012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
576
577 Cleanup basic allocation variables and functions.
578 * alloc.c (ignore_warnings, init_intervals, init_float)
579 (init_cons, init_symbol, init_marker): Remove.
580 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
581 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
582 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
583 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
584 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
585 (staticidx, init_alloc_once, init_strings, free_ablock):
586 Remove redundant initialization.
587 * fns.c (init_weak_hash_tables): Remove.
588 * lisp.h (init_weak_hash_tables): Remove prototype.
589
9730daca
DA
5902012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
591
592 Use zero_vector where appropriate.
593 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
594 accordingly.
595 * lisp.h (zero_vector): New declaration.
596 * font.c (null_vector): Remove.
597 (syms_of_font): Remove initialization and staticpro.
598 (font_list_entities, font_find_for_lface): Change to use zero_vector.
599 * keymap.c (Faccessible_keymaps): Likewise.
600
2e2d2a13
LL
6012012-07-15 Leo Liu <sdl.web@gmail.com>
602
603 * fringe.c: Fix typo in comments.
604
cd276f6e
LL
6052012-07-14 Leo Liu <sdl.web@gmail.com>
606
607 * fringe.c: Add a new bitmap exclamation-mark.
608
5a1131d9
EZ
6092012-07-14 Eli Zaretskii <eliz@gnu.org>
610
611 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
612
613 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
614 (HAVE_MENUS): Don't define, defined by editing config.in with
615 msdos/sed2v2.inp.
616 (GMALLOC_INHIBIT_VALLOC): Don't define.
617 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
618
22e983b7
JB
6192012-07-14 Juanma Barranquero <lekktu@gmail.com>
620
621 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
622
5b3f250f
GM
6232012-07-14 Glenn Morris <rgm@gnu.org>
624
625 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
626 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
627 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
628
33d63ff4
GM
6292012-07-13 Glenn Morris <rgm@gnu.org>
630
5b633342
GM
631 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
632
33d63ff4
GM
633 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
634 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
635
b55b9f85
JD
6362012-07-13 Jan Djärv <jan.h.d@swipnet.se>
637
0dc8cf50
JD
638 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
639 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
640 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
641 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
642 where appropriate.
643 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
644 as boolean expression.
645 (x_set_window_size): Remove unused variable toolbar.
646 (ns_get_color_default, ns_mod_to_lisp): Remove.
647 (ns_mouse_position): Remove unused variables xchar and ychar.
648 (ns_compute_glyph_string_overhangs): Remove unused variable face.
649 (ns_set_vertical_scroll_bar): Remove unused variable count.
650 (ns_delete_terminal): Remove unused variable i.
651 (ns_term_init): Remove unused variables r, g and b.
652 (mouseDown): Remove unused variable window.
653 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
654 (initFrameFromEmacs): Remove unused variable vbextra.
655 (mouseEntered): Remove unused variables p and dpyinfo.
656 (mouseExited): Remove unused variables p and r.
657 (ns_define_frame_cursor, ns_clear_frame_area)
658 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
659 (menuDown): Assign [sender tag] to variable and cast the variable.
660
661 * nsterm.h (menuDown): Add id as type to argument sender.
662 (ns_display_info_for_name): Add Lisp_Object argument.
663 (ns_term_init): Add Lisp_Object argument.
664 (ns_map_event_to_object): Add void argument.
665 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
666 prototype with arguments and only declare if __OBJC__.
667 (nxatoms_of_nsselect): Add void argument.
668 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
669 (ns_alloc_autorelease_pool): Add void argument.
670 (ns_release_autorelease_pool): Add void* argument.
671 (ns_get_defaults_value): Add const char* argument.
672
673 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
674 (initFromContents): Use SSDATA where appropriate.
675 (ns_update_menubar): Add braces to ambigous if-else.
676 (initWithTitle): Put () around assignment in if statement.
677 (ns_menu_show): Remove unused variables window and keymap.
678 (update_frame_tool_bar): Remove unused variable selected_p.
679 (initWithContentRect): Remove unused variable this_cmd_name.
680
681 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
682 appropriate.
683 (setXBMColor): Remove unused variable len.
684 (setPixmapData): Put () around assignment in loop statement.
685
686 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
687 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
688 where appropriate.
689 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
690 around assignment in loop statement.
691 (nsfont_open): Remove unused variable i.
692 (nsfont_open): Remove unused variable len.
693 (nsfont_draw): Remove unused variable cs.
694
695 * nsfns.m (x_set_icon_name, ns_set_name_internal)
696 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
697 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
698 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
699 (Fns_font_name, Fns_perform_service)
700 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
701 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
702 (ns_set_name): Remove unused variable view.
703 (x_set_menu_bar_lines): Remove unused variable olines.
704 (x_set_tool_bar_lines): Remove unused variable root_window.
705 (Fns_list_colors): Put () around assignment in while statement.
706 (Fns_perform_service): Remove unused variable len.
707 (Fns_display_usable_bounds): Remove unused variable top.
708 (syms_of_nsfns): Remove unused variable i.
709
b55b9f85
JD
710 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
711 memcpy (Bug#11907).
712
ed9265fc 7132012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
714
715 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
716 and free it with DestroyExceptionInfo (Bug#11558).
717
ef099b57
JB
7182012-07-13 Juanma Barranquero <lekktu@gmail.com>
719
720 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
721 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
722 Set here, not in nt/config.nt.
723
ea814a5d
EZ
7242012-07-13 Eli Zaretskii <eliz@gnu.org>
725
726 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
727 cursor overflow into the last glyph on display line when the right
728 fringe is off. (Bug#11832)
729
1a952767
PE
7302012-07-13 Paul Eggert <eggert@cs.ucla.edu>
731
732 * xdisp.c (produce_special_glyphs): Now static.
733 * dispextern.h (produce_special_glyphs): Remove decl.
734
983188fd
GM
7352012-07-13 Glenn Morris <rgm@gnu.org>
736
32fb4bb6
GM
737 * s/bsd-common, s/cygwin.h: Remove empty files.
738 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
739
983188fd
GM
740 * s/usg5-4-common.h (USG, USG5):
741 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
742 * s/sol2-6.h (SOLARIS2):
743 * s/irix6-5.h (IRIX6_5):
744 * s/hpux10-20.h (USG, USG5, HPUX):
745 * s/gnu-linux.h (USG, GNU_LINUX):
746 * s/freebsd.h (BSD_SYSTEM):
747 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
748 * s/cygwin.h (CYGWIN):
749 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
750 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
751
d1e68667 7522012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
753
754 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 755
6de0e799
GM
7562012-07-13 Glenn Morris <rgm@gnu.org>
757
739ae010
GM
758 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
759
dbee5793
GM
760 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
761
6de0e799
GM
762 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
763 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
764
b82da769
GM
7652012-07-12 Glenn Morris <rgm@gnu.org>
766
4fae5a7a 767 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
768
769 * process.c (init_process_emacs): Rename from init_process.
770 The old name is also the name of a Mach system call.
771 * lisp.h, emacs.c: Update for this name change.
772 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
773 longer needed.
774
5a979817
EZ
7752012-07-12 Eli Zaretskii <eliz@gnu.org>
776
777 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
778 memmove call that removes glyphs covered by the left truncation
779 glyph. Improve commentary.
780 (display_line): Fix display of continuation glyphs on GUI frames
781 when the right fringe is turned off and variable-size fonts are
782 used in the window. Move the code that appends a stretch glyph to
783 produce_special_glyphs, so that it could be used for truncation
784 and continuation glyphs alike.
785 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
786 glyph of a suitably computed width, to align the special glyphs at
787 the window margin. Code moved from display_line. (Bug#11832)
788
3e91a053
GM
7892012-07-12 Glenn Morris <rgm@gnu.org>
790
ba9e4b84
GM
791 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
792
793 * s/gnu-linux.h, s/hpux10-20.h:
794 Do not unconditionally define HAVE_XRMSETDATABASE.
795
3e91a053
GM
796 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
797
b300b1f4
PE
7982012-07-12 Paul Eggert <eggert@cs.ucla.edu>
799
800 Fix typos that broke OS X build.
801 Reported by Randal L. Schwartz in
802 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
803 * nsterm.m (ns_timeout): Add missing local decl.
804 (ns_get_color): snprintf -> sprintf, to fix typo.
805
6e777848
GM
8062012-07-12 Glenn Morris <rgm@gnu.org>
807
3f922c37
GM
808 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
809 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
810 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
811 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
812
0ab7b23a
GM
813 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
814 Move PTY_OPEN to configure.
815
6e777848
GM
816 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
817 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
818 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
819
4a7edc24
DA
8202012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
821
822 Use empty_unibyte_string where applicable.
823 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
824 * lread.c (read1): Likewise.
825 * xsettings.c (syms_of_xsettings): Likewise.
826
308aab79
GM
8272012-07-12 Glenn Morris <rgm@gnu.org>
828
42bd1719
GM
829 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
830 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
831 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
832 * s/hpux10-20.h (RUN_TIME_REMAP):
833 * s/bsd-common.h (TABDLY): Move to configure.
834
835 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
836
837 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
838
ea0bbd17 839 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 840 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
841
842 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 843
308aab79
GM
844 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
845 * s/template.h: Move NARROWPROTO to configure.
846
ee1cf5cf
GM
8472012-07-11 Glenn Morris <rgm@gnu.org>
848
30fe9bf4
GM
849 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
850 unused since 2011-01-17 change to systty.h.
851
ee1cf5cf
GM
852 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
853 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
854 Move HAVE_PTYS and HAVE_SOCKETS to configure.
855
63e47e07
PE
8562012-07-11 Paul Eggert <eggert@cs.ucla.edu>
857
858 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
859
c43fb4c3
GM
8602012-07-11 Glenn Morris <rgm@gnu.org>
861
862 * s/darwin.h, s/gnu-linux.h, s/template.h:
863 Move INTERRUPT_INPUT to configure.
864
e8df9267
DA
8652012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
866
867 Minor adjustments to interning code.
868 * lisp.h (intern, intern_c_string): Redefine as static inline
869 wrappers for intern_1 and intern_c_string_1, respectively.
870 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
871 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
872 Vobarray checking.
e8df9267
DA
873 * font.c (font_intern_prop): Likewise. Adjust comment.
874 * w32font.c (intern_font_name): Likewise.
875
34348bd4
AS
8762012-07-11 Andreas Schwab <schwab@linux-m68k.org>
877
d96a1e0c
AS
878 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
879
34348bd4
AS
880 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
881 of Fcar/Fcdr if possible.
882 * font.c (check_otf_features): Likewise.
883 * fontset.c (Fnew_fontset): Likewise.
884 * gnutls.c (Fgnutls_boot): Likewise.
885 * minibuf.c (read_minibuf): Likewise.
886 * msdos.c (IT_set_frame_parameters): Likewise.
887 * xmenu.c (Fx_popup_dialog): Likewise.
888 * w32menu.c (Fx_popup_dialog): Likewise.
889
c8add24e
GM
8902012-07-11 Glenn Morris <rgm@gnu.org>
891
4b575b3c
GM
892 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
893 since nothing has defined it on these platforms.
894
09f4e3b0
GM
895 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
896 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
897
172bedef
GM
898 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
899 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
900 Move CLASH_DETECTION to configure.
901
249685df
GM
902 * s/gnu.h: Remove file, which is now empty.
903
c8add24e
GM
904 * s/gnu.h, s/gnu-linux.h:
905 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
906
b41253a3
JW
9072012-07-11 John Wiegley <johnw@newartisans.com>
908
909 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
910 function attribute, so we only use it if it exists in the
911 compiler.
912
d923b542
DA
9132012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
914
915 Avoid call to strlen in fast_c_string_match_ignore_case.
916 * search.c (fast_c_string_match_ignore_case): Change to use
917 length argument. Adjust users accordingly.
918 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
919
5ebbef1d
PE
9202012-07-11 Paul Eggert <eggert@cs.ucla.edu>
921
bb352260
PE
922 Assume mkdir, rmdir.
923 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
924 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
925
57054ddd
PE
926 Assume rename.
927 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
928
b747d3f7
PE
929 Assume perror.
930 * s/hpux10-20.h (HAVE_PERROR): Remove.
931 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
932 Remove dummy definition, as this problem was obsolete long ago.
933
5ebbef1d
PE
934 Assume strerror.
935 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
936
984e7f30
DA
9372012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
938
939 Avoid calls to strlen in font processing functions.
940 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 941 (font_open_by_name): Change to use length argument. Adjust
984e7f30 942 users accordingly.
d923b542
DA
943 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
944 Adjust prototypes.
945 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
946 Change to return ptrdiff_t.
984e7f30
DA
947 (xfont_list_pattern, xfont_match): Use length returned by
948 xfont_decode_coding_xlfd.
949 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
950
20e94fdd
GM
9512012-07-11 Glenn Morris <rgm@gnu.org>
952
9d596af3
GM
953 * s/darwin.h, s/freebsd.h, s/netbsd.h:
954 Move DONT_REOPEN_PTY to configure.
955
20e94fdd
GM
956 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
957 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
958
e99a530f
PE
9592012-07-10 Paul Eggert <eggert@cs.ucla.edu>
960
22ffb973
PE
961 Remove "#define unix" that is no longer needed (Bug#11905).
962 * s/aix4-2.h (unix): Remove; no longer needed.
963
e9a9ae03
PE
964 EMACS_TIME simplification (Bug#11875).
965 This replaces macros (which typically do not work in GDB)
966 with functions, typedefs and enums, making the code easier to debug.
967 The functional style also makes code easier to read and maintain.
968 * systime.h: Include <sys/time.h> on all hosts, not just if
969 WINDOWSNT, since 'struct timeval' is needed in general.
970 (EMACS_TIME): Now a typedef, not a macro.
971 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
972 not macros.
973 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
974 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
975 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
976 (EMACS_TIME_LE): Now functions, not macros.
977 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
978 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
979 which are not functions. All uses rewritten to use:
980 (make_emacs_time): New function.
981 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
982 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
983 not functions. All uses rewritten to use the following, respectively:
984 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
985 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 986 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
987 * fileio.c (Fcopy_file):
988 * xterm.c (XTflash): Get the current time closer to when it's used.
989 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
990
ffacb126
PE
991 * bytecode.c (targets): Suppress -Woverride-init warnings.
992
e99a530f
PE
993 Simplify by avoiding confusing use of strncpy etc.
994 * doc.c (Fsnarf_documentation):
995 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
996 * frame.c (Fmake_terminal_frame):
997 * gtkutil.c (get_utf8_string):
998 * lread.c (openp):
999 * nsmenu.m (ns_update_menubar):
1000 * regex.c (regerror):
1001 Prefer memcpy to strncpy and strncat when either will do.
1002 * fileio.c (Fsubstitute_in_file_name):
1003 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1004 (menu_separator_name_p):
1005 * nsmenu.m (ns_update_menubar):
1006 Prefer memcmp to strncmp when either will do.
1007 * nsterm.m: Include <ftoastr.h>.
1008 (ns_get_color):
1009 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1010 Prefer snprintf to strncpy.
1011 * nsterm.m (ns_term_init):
1012 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1013 * nsterm.m (ns_term_init):
1014 Avoid the need for strncpy, by using build_string or
1015 make_unibyte_string directly. Use dtoastr, not snprintf.
1016 * process.c (Fmake_network_process): Diagnose service names that
1017 are too long, rather than silently truncating them or creating
1018 non-null-terminated names.
1019 (Fnetwork_interface_info): Likewise, for interface names.
1020 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1021 Prefer sprintf to strncat.
1022 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1023 Prefer vsnprintf to vsprintf + strncpy.
1024
c59592b3
GM
10252012-07-10 Glenn Morris <rgm@gnu.org>
1026
1027 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1028 Clarify fallback case.
1029
7d7bbefd
DA
10302012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1031
1032 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1033 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1034 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1035 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1036 where argument type is known to be a Lisp_Cons.
1037
3a4c8000
TT
10382012-07-10 Tom Tromey <tromey@redhat.com>
1039
1040 * bytecode.c (BYTE_CODE_THREADED): New macro.
1041 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1042 (enum byte_code_op): New type.
1043 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1044 (exec_byte_code): Use them. Use token threading when applicable.
1045
2a0213a6
DA
10462012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1047
1048 Optimize pure C strings initialization.
1049 * lisp.h (make_pure_string): Fix prototype.
1050 (build_pure_c_string): New function, defined as static inline. This
1051 provides a better opportunity to optimize away calls to strlen when
1052 the function is called with compile-time constant argument.
1053 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1054 argument, adjust users accordingly. Use build_pure_c_string where
1055 appropriate.
1056 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1057 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1058 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1059
cb1caeaf
DA
10602012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1061
1062 Avoid calls to strlen in miscellaneous functions.
1063 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1064 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1065 * lread.c (openp): Likewise.
1066
c293e30c
DA
10672012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1068
1069 Avoid calls to strlen in path processing functions.
1070 * fileio.c (file_name_as_directory): Add comment. Change to add
1071 srclen argument and return the length of result. Adjust users
1072 accordingly.
1073 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1074 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1075 users accordingly.
1076 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1077
9e059e3f
GM
10782012-07-10 Glenn Morris <rgm@gnu.org>
1079
d02eb359
GM
1080 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1081 Move PENDING_OUTPUT_COUNT definition to configure.
1082
882cf227
GM
1083 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1084 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1085 * s/gnu.h (DATA_START): Move definitions to configure.
1086
af6e839f
GM
1087 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1088 We include usg5-4-common.h, which defines them both.
1089
40289a12
GM
1090 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1091 O_RDONLY already includes it).
1092
9e059e3f
GM
1093 Stop ns builds setting the EMACSLOADPATH environment variable.
1094 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1095 Now it does not set EMACSLOADPATH, just returns the load-path string.
1096 * nsterm.h: Update accordingly.
1097 * lread.c [HAVE_NS]: Include nsterm.h.
1098 (init_lread) [HAVE_NS]: Use ns_load_path.
1099 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1100
7c4e8ec0
GM
11012012-07-09 Glenn Morris <rgm@gnu.org>
1102
d4f600ff
GM
1103 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1104 since the included bsd-common.h does so.
1105
cbb31951
GM
1106 Stop ns builds setting the EMACSPATH environment variable.
1107 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1108 (ns_init_paths): Do not set EMACSPATH.
1109 * nsterm.h (ns_exec_path): Add it.
1110 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1111 Use ns_exec_path.
1112
7c4e8ec0
GM
1113 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1114
26bccfae
PE
11152012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1116
a0bee46f
PE
1117 * process.c (wait_reading_process_output): 'waitchannels' was unset
1118 when read_kbd || !NILP (wait_for_cell); fix this.
1119
5994c183
PE
1120 Add GCC-style 'const' attribute to functions that can use it.
1121 * character.h (char_resolve_modifier_mask):
1122 * keyboard.h (make_ctrl_char):
1123 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1124 (init_character_once, next_almost_prime, init_fns, init_image)
1125 (flush_pending_output, init_sound):
1126 * mem-limits.h (start_of_data):
1127 * menu.h (finish_menu_items):
1128 Add ATTRIBUTE_CONST.
1129 * emacs.c (DEFINE_DUMMY_FUNCTION):
1130 Declare the dummy function with ATTRIBUTE_CONST.
1131 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1132 Add decls with ATTRIBUTE_CONST.
1133
26bccfae
PE
1134 Minor improvements to make_formatted_string.
1135 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1136 where int is good enough, as vsprintf returns an int.
1137 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1138
a8290ec3
DA
11392012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1140
1141 Use make_formatted_string to avoid double length calculation.
1142 * lisp.h (make_formatted_string): New prototype.
1143 * alloc.c (make_formatted_string): New function.
1144 * buffer.c (Fgenerate_new_buffer_name): Use it.
1145 * dbus.c (syms_of_dbusbind): Likewise.
1146 * editfns.c (Fcurrent_time_zone): Likewise.
1147 * filelock.c (get_boot_time): Likewise.
1148 * frame.c (make_terminal_frame, set_term_frame_name)
1149 (x_report_frame_params): Likewise.
1150 * image.c (gs_load): Likewise.
1151 * minibuf.c (get_minibuffer): Likewise.
1152 * msdos.c (dos_set_window_size): Likewise.
1153 * process.c (make_process): Likewise.
1154 * xdisp.c (ensure_echo_area_buffers): Likewise.
1155 * xsettings.c (apply_xft_settings): Likewise.
1156
d01ba2f1
GM
11572012-07-09 Glenn Morris <rgm@gnu.org>
1158
1159 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1160 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1161 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1162 * nsterm.h (ns_etc_directory): Add it.
1163 * callproc.c [HAVE_NS]: Include nsterm.h.
1164 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1165
f1f924b6
DA
11662012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1167
1168 Move marker debugging code under MARKER_DEBUG.
1169 * marker.c (MARKER_DEBUG): Move marker debugging code under
1170 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1171 for bootstrap with --enable-checking (~3x slowdown reported
1172 by Juanma Barranquero <lekktu@gmail.com>).
1173 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1174
ab531b66
PE
11752012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1176
1177 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1178 See <http://bugs.gnu.org/11825#29>.
1179
c4b3bc8a
EZ
11802012-07-08 Eli Zaretskii <eliz@gnu.org>
1181
1182 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1183 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1184 (display_line): Add commentary about displaying truncation glyphs
1185 on GUI frames.
1186 (produce_special_glyphs): Move here from term.c.
1187
1188 * term.c (produce_special_glyphs): Move to xdisp.c.
1189
1190 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1191 section.
c4b3bc8a 1192
b676b881
AS
11932012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1194
f17c5273
AS
1195 * xdisp.c (display_line): Avoid warning about implicit declaration
1196 of FRAME_FONT.
1197
298819b9
AS
1198 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1199
b676b881
AS
1200 * lisp.h: Remove empty conditional.
1201
6045c4fd
PE
12022012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1203
b3350bf9
PE
1204 * lread.c (load_path_check): Now static.
1205
6045c4fd
PE
1206 Fix some minor --with-ns problems found by static checking.
1207 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1208 (x_set_font) [!HAVE_X_WINDOWS]:
1209 * image.c (xpm_load_image) [HAVE_NS]:
1210 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1211 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1212 Remove unused local.
1213 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1214 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1215 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1216 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1217 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1218 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1219 Fix pointer signedness problem.
1220 * xfaces.c (FRAME_X_FONT_TABLE):
1221 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1222
929e7845
GM
12232012-07-07 Glenn Morris <rgm@gnu.org>
1224
1225 * lread.c (load_path_check): New function, split from init_lread.
1226 (init_lread): Reorganize. Motivation:
1227 If EMACSLOADPATH is set, check/warn about that rather than the
1228 defaults, which we are not going to use. Hence we can remove
1229 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1230 Don't warn if site-lisp directories are missing.
1231 If not installed, start from a blank load-path, since
1232 PATH_LOADSEARCH refers to the eventual installation directories.
1233
58dd0aa4
EZ
12342012-07-07 Eli Zaretskii <eliz@gnu.org>
1235
1236 Support truncation and continuation glyphs on GUI frames, when
1237 fringes are disabled. (Bug#11832)
1238 * xdisp.c (init_iterator): Get dimensions of truncation and
1239 continuation glyphs even if on GUI frames. Adjust
1240 it->last_visible_x on GUI frames when the left or right fringes,
1241 or both, are absent.
1242 (start_display, move_it_in_display_line_to): Handle the case of a
1243 GUI frame without a fringe to display continuation or truncation
1244 glyphs.
1245 (insert_left_trunc_glyphs): Support GUI frames: make sure
1246 truncation glyphs overwrite enough glyphs from the current line to
1247 have sufficient space in pixels.
1248 (display_line): Support truncation and continuation glyphs on GUI
1249 frames. If some spare pixels are left on the line after inserting
1250 the truncation glyphs, fill that space with a stretch glyph of a
1251 suitably computed width.
1252
1253 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1254 produce_glyphs, to support GUI sessions.
1255
31571fd7
PE
12562012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1257
5a16b9bc
PE
1258 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1259
f3047c75
PE
1260 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1261
31571fd7
PE
1262 Do not require float-time's arg to fit in time_t (Bug#11825).
1263 This works better on hosts where time_t is unsigned, and where
1264 float-time is applied to the (negative) difference between two times.
1265 * editfns.c (decode_time_components): Last arg is now double *,
1266 not int *, and means to store all the result as a double, without
1267 worrying about whether the seconds part fits in time_t.
1268 All callers changed.
1269 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1270 All callers changed.
1271 (Ffloat_time): Do not fail merely because the specified time falls
1272 outside of time_t range.
1273
4516fbef
GM
12742012-07-07 Glenn Morris <rgm@gnu.org>
1275
1276 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1277 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1278 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1279
07adc2c6
JB
12802012-07-07 Juanma Barranquero <lekktu@gmail.com>
1281
1282 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1283 Update dependencies.
1284
1285 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1286
fd573f31
PE
12872012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1288
fee5959d
PE
1289 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1290 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1291 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1292 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1293 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1294 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1295
fd573f31
PE
1296 * xfont.c (compare_font_names): Redo to omit the need for casts.
1297
ddadbc0e
AS
12982012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1299
fca8d6b6
AS
1300 * xfns.c (Fx_change_window_property): Doc fix.
1301 * w32fns.c (Fx_change_window_property): Doc fix.
1302
ddadbc0e
AS
1303 * w32fns.c (Fx_window_property): Accept the same arguments as the
1304 X Windows version. Doc fix.
1305 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1306
ed9265fc 13072012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1308 Eli Zaretskii <eliz@gnu.org>
1309
1310 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1311 Windows-specific code from nt/config.nt moved here.
1312 Obsolete settings removed.
1313
216ee680
PE
13142012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1315
1316 * process.c: Avoid unnecessary calls to gettime.
1317 (wait_reading_process_output): Don't get the time of day
1318 when gobbling data immediately and not waiting, as there's no need
1319 for it in that case. This removes a FIXME.
1320
bdd091e4
JD
13212012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1322
1323 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1324 is defined (Bug#11768).
1325
9d44f8ce
DA
13262012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1327
1328 Fix marker debugging code.
1329 * marker.c (byte_char_debug_check): Do not perform the check
1330 if buffer is not multibyte.
090bd7cb
JB
1331 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1332 Call byte_char_debug_check with correct arguments.
9d44f8ce 1333
90fc4786
DA
13342012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1335
1336 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1337 * marker.c (byte_char_debug_check, count_markers):
1338 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1339 (byte_debug_flag): Remove.
1340 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1341 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1342
7b7ae965
DA
13432012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1344
4e57b342
DA
1345 Avoid code repetition in marker-related functions.
1346 * marker.c (attach_marker): New function.
1347 (Fset_marker, set_marker_restricted, set_marker_both)
1348 (set_marker_restricted_both): Use it.
1349 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1350 Consistently rename charno to charpos.
1351 (marker_position): Add eassert.
1352 (marker_byte_position): Convert to eassert.
1353
13542012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1355
1356 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1357 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1358 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1359
657924ff
DA
13602012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1361
1362 Introduce fast path for the widely used marker operation.
1363 * alloc.c (build_marker): New function.
1364 * lisp.h (build_marker): New prototype.
1365 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1366 * composite.c (autocmp_chars): Likewise.
1367 * editfns.c (buildmark): Remove.
1368 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1369 (save_restriction_save): Use build_marker.
1370 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1371 * window.c (save_window_save): Likewise.
1372
041a49a6
DA
13732012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1374
1375 Do not use Fdelete_overlay in delete_all_overlays
1376 to avoid redundant calls to unchain_overlay.
1377 * buffer.c (drop_overlay): New function.
1378 (delete_all_overlays, Fdelete_overlay): Use it.
1379 * minibuf.c (get_minibuffer): Fix comment.
1380
7dca65a4
PE
13812012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1382
1383 Port to OpenBSD 5.1 amd64.
1384 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1385 This is needed for OpenBSD, and should be harmless on all BSD systems.
1386 Also, include <sys/sysctl.h>, as it should be available on all
1387 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1388 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1389 use p_pid member, not kp_proc.pid.
1390
8eb876e2
GM
13912012-07-06 Glenn Morris <rgm@gnu.org>
1392
1393 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1394
38182d90
PE
13952012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1396
1397 More xmalloc and related cleanup.
1398 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1399 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1400 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1401 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1402 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1403 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1404 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1405 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1406 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1407 * xterm.c:
1408 Omit needless casts involving void * pointers and allocation.
1409 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1410 as the former is more robust if P's type is changed.
1411 Prefer xzalloc to xmalloc + memset 0.
1412 Simplify malloc-or-realloc to realloc.
1413 Don't worry about xmalloc returning a null pointer.
1414 Prefer xstrdup to xmalloc + strcpy.
1415 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1416 growing it.
1417 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1418 alloca of a constant.
1419
6dd5a677
EZ
14202012-07-05 Eli Zaretskii <eliz@gnu.org>
1421
1422 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1423 hscroll is larger than the line width. Fixes long and futile
1424 looping inside extend_face_to_end_of_line (on a TTY) producing
1425 glyphs that are not needed and thrown away.
1426
6b312f0f
DA
14272012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1428
1429 * marker.c (set_marker_restricted_both): Simplify by using
1430 clip_to_bounds.
1431
f520ef9b
PE
14322012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1433
1434 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1435
383b7c95
JD
14362012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1437
1438 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1439 not defined (Bug#11768).
1440 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1441 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1442 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1443 followed by gtk_box_set_homogeneous (Bug#11768).
1444 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1445 (update_theme_scrollbar_width, xg_create_scroll_bar):
1446 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1447 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1448 (is_box_type): New function (Bug#11768).
1449 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1450 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1451 with default display (Bug#11768).
1452
d6e7bf45
EZ
14532012-07-05 Eli Zaretskii <eliz@gnu.org>
1454
1455 * xdisp.c (window_hscroll_limited): New function.
1456 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1457 coordinates when window's hscroll is set to insanely large
1458 values. (Bug#11857)
1459
431391ec
JB
14602012-07-05 Juanma Barranquero <lekktu@gmail.com>
1461
1462 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1463 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1464
23f86fce
DA
14652012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1466
1467 Cleanup xmalloc.
1468 * lisp.h (xzalloc): New prototype. Omit needless casts.
1469 * alloc.c (xzalloc): New function. Omit needless casts.
1470 * charset.c: Omit needless casts. Convert all calls to
1471 xmalloc with following memset to xzalloc.
1472 * dispnew.c: Likewise.
1473 * fringe.c: Likewise.
1474 * image.c: Likewise.
1475 * sound.c: Likewise.
1476 * term.c: Likewise.
1477 * w32fns.c: Likewise.
1478 * w32font.c: Likewise.
1479 * w32term.c: Likewise.
1480 * xfaces.c: Likewise.
1481 * xfns.c: Likewise.
1482 * xterm.c: Likewise.
1483 * atimer.c: Omit needless casts.
1484 * buffer.c: Likewise.
1485 * callproc.c: Likewise.
1486 * ccl.c: Likewise.
1487 * coding.c: Likewise.
1488 * composite.c: Likewise.
1489 * doc.c: Likewise.
1490 * doprnt.c: Likewise.
1491 * editfns.c: Likewise.
1492 * emacs.c: Likewise.
1493 * eval.c: Likewise.
1494 * filelock.c: Likewise.
1495 * fns.c: Likewise.
1496 * gtkutil.c: Likewise.
1497 * keyboard.c: Likewise.
1498 * lisp.h: Likewise.
1499 * lread.c: Likewise.
1500 * minibuf.c: Likewise.
1501 * msdos.c: Likewise.
1502 * print.c: Likewise.
1503 * process.c: Likewise.
1504 * region-cache.c: Likewise.
1505 * search.c: Likewise.
1506 * sysdep.c: Likewise.
1507 * termcap.c: Likewise.
1508 * terminal.c: Likewise.
1509 * tparam.c: Likewise.
1510 * w16select.c: Likewise.
1511 * w32.c: Likewise.
1512 * w32reg.c: Likewise.
1513 * w32select.c: Likewise.
1514 * w32uniscribe.c: Likewise.
1515 * widget.c: Likewise.
1516 * xdisp.c: Likewise.
1517 * xmenu.c: Likewise.
1518 * xrdb.c: Likewise.
1519 * xselect.c: Likewise.
1520
0497dc44
PE
15212012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1522
1523 * fileio.c (time_error_value): Check the right error number.
1524 Problem reported by Troels Nielsen in
1525 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1526
356e7178
PE
15272012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1528
4e71fd89
PE
1529 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1530 This should be fixed in a better way; see Eli Zaretskii in
1531 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1532 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1533
f0941253
PE
1534 * fileio.c (time_error_value): Rename from special_mtime.
1535 The old name's problems were noted by Eli Zaretskii in
1536 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1537
065c9eb4
PE
1538 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1539 This variable's comment says Emacs needs at least one GDB-visible
1540 symbol of type enum pvec_type, to work around GDB problems.
1541 The symbol's value doesn't matter.
1542
356e7178
PE
1543 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1544 that causes compilation to fail on pre-C99 compilers.
1545
ed9265fc 15462012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1547
1548 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1549 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1550
3884d954
DA
15512012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1552
d209e2fb 1553 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1554 headers for buffer_defaults and buffer_local_symbols.
1555 Reported by Juanma Barranquero <lekktu@gmail.com>.
1556
ee28be33
SM
15572012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1558
1559 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1560 * lisp.h (enum pvec_type): Use fewer bits.
1561 (PSEUDOVECTOR_SIZE_BITS): New constant.
1562 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1563 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1564 change in pvec_type.
1565 (PSEUDOVECTOR_TYPEP): New macro.
1566 (TYPED_PSEUDOVECTORP): Use it.
1567 * fns.c (internal_equal): Adapt code to extract pvectype.
1568 * emacs.c (gdb_pvec_type): Update type.
1569 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1570 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1571 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1572 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1573 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1574 abusing vector->header.next.nbytes.
1575 (live_vector_p): Use PVEC_TYPE.
1576 (mark_object): Adapt code to extract pvectype. Use switch.
1577
c7f2cd7f
PE
15782012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1579
1580 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1581 Tighten new eassert a bit.
1582
8ce70ed2
DA
15832012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1584
1585 Fix compilation with --enable-gcc-warnings and -O1
1586 optimization level.
1587 * doprnt.c (doprnt): Change type of tem to int, initialize
1588 to avoid compiler warning. Add eassert.
1589 * search.c (simple_search): Initialize match_byte to avoid
1590 compiler warning. Add eassert.
1591
dea7f1e5
PE
15922012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1593
24a212eb
PE
1594 Avoid weird behavior with large horizontal scrolls.
1595 Without this change, for example, large hscroll values would
1596 mess up Emacs's display on Fedora 15 x86, presumably due to
1597 overflows in int calculations in the display code.
1598 Also, if buffers had long lines, Emacs would freeze.
1599 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1600 (set_window_hscroll): New function, containing the old guts of
1601 Fset_window_hscroll. Return the clipped value.
1602 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1603 This avoids the need to check against PTRDIFF_MAX.
1604
dea7f1e5
PE
1605 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1606
76046526
DA
16072012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1608
1609 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1610
39adff0d
PE
16112012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1612
63807d47
PE
1613 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1614 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1615 since GCC 4.4.6 issues a bogus warning for them.
1616
39adff0d
PE
1617 Fix bugs in file timestamp newness comparisons.
1618 * fileio.c (Ffile_newer_than_file_p):
1619 * lread.c (Fload): Use full timestamp resolution of files,
1620 not just the 1-second resolution, so that files that are only
1621 slightly newer still count as newer.
1622 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1623 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1624
dbeed9a6
PE
16252012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * fileio.c: Improve handling of file time marker. (Bug#11852)
1628 (special_mtime): New function.
1629 (Finsert_file_contents, Fverify_visited_file_modtime):
1630 Use it to set special mtime values consistently.
1631
636334d6
AS
16322012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1633
1634 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1635 marker for non-existing file. (Bug#11852)
1636
e2017fe2
GM
16372012-07-03 Glenn Morris <rgm@gnu.org>
1638
1639 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1640 and did not make it into globals.h).
1641
404dbd37
TT
16422012-07-03 Tom Tromey <tromey@redhat.com>
1643
1644 * window.c (Fset_window_margins, Fset_window_fringes)
1645 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1646 * textprop.c (Fprevious_property_change): No longer static.
1647 * syntax.c (Fsyntax_table_p): No longer static.
1648 * process.c (Fget_process, Fprocess_datagram_address): No longer
1649 static.
1650 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1651 * keyboard.c (Fcommand_execute): No longer static.
1652 Remove EXFUN.
1653 * insdel.c (Fcombine_after_change_execute): No longer static.
1654 * image.c (Finit_image_library): No longer static.
1655 * fileio.c (Fmake_symbolic_link): No longer static.
1656 * eval.c (Ffetch_bytecode): No longer static.
1657 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1658 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1659 No longer static.
404dbd37
TT
1660 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1661 static.
1662 * dired.c (Ffile_attributes): No longer static.
1663 * composite.c (Fcomposition_get_gstring): No longer static.
1664 * callproc.c (Fgetenv_internal): No longer static.
1665
1666 * ccl.h: Remove EXFUNs.
1667 * buffer.h: Remove EXFUNs.
1668 * dispextern.h: Remove EXFUNs.
1669 * intervals.h: Remove EXFUNs.
1670 * fontset.h: Remove EXFUN.
1671 * font.h: Remove EXFUNs.
1672 * dosfns.c (system_process_attributes): Remove EXFUN.
1673 * keymap.h: Remove EXFUNs.
1674 * lisp.h: Remove EXFUNs.
1675 * w32term.h: Remove EXFUNs.
1676 * window.h: Remove EXFUNs.
1677 * xsettings.h: Remove EXFUN.
1678 * xterm.h: Remove EXFUN.
1679
8e4fd1e1
GM
16802012-07-03 Glenn Morris <rgm@gnu.org>
1681
1682 * lisp.h (Frandom): Make it visible to C.
1683 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1684 buffer for invisible buffers. (Bug#1229)
1685
ca95b3eb
DA
16862012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1687
1688 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1689 values which aren't power of 2.
1690 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1691 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1692 accordingly.
1693
7555c33f
SM
16942012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1695
1696 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1697
1698 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1699
d12e8f5a
DA
17002012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1701
1702 * alloc.c (allocate_vector_block): Remove redundant
1703 calls to mallopt if DOUG_LEA_MALLOC is defined.
1704 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1705 avoid calls to mallopt if zero_vector is returned.
1706
296094c3
DA
17072012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1708
1709 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1710 is enabled, avoid dereferencing NULL current_sblock if
1711 running undumped.
1712
36429c89
DA
17132012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1714
1715 Cleanup basic buffer management.
1716 * buffer.h (struct buffer): Change layout to use generic vector
1717 marking code. Fix some comments. Change type of 'clip_changed'
1718 to bitfield. Remove unused #ifndef old.
1719 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1720 (GET_OVERLAYS_AT): Fix indentation.
1721 (for_each_per_buffer_object_at): New macro.
1722 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1723 (Fbuffer_local_variables): Use it.
1724 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1725 * alloc.c (allocate_buffer): Adjust to match new layout of
1726 struct buffer. Fix comment.
1727 (mark_overlay): New function.
1728 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1729 Lisp area of struct buffer.
1730 (mark_object): Use it. Adjust marking of misc objects
1731 and related comments.
1732
3b3e4cac
PE
17332012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1734
1735 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1736 wrapper that is not needed because the wrapped code is a no-op (zero
1737 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1738 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1739
cf5c0175
DA
17402012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1741
1742 * alloc.c (mark_buffer): Simplify. Remove prototype.
1743 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1744 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1745 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1746 redundant calls to mark_vectorlike for bool vectors.
1747
ca26824c
GM
17482012-06-30 Glenn Morris <rgm@gnu.org>
1749
2e4c5312
GM
1750 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1751
ca26824c
GM
1752 * epaths.in (PATH_SITELOADSEARCH): New.
1753 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1754 This is rather than relying on --enable-locallisppath elements
1755 having "site-lisp" in their names. (Bug#10208#25, 11658)
1756
0d23c240
EZ
17572012-06-30 Eli Zaretskii <eliz@gnu.org>
1758
c9240d7a
EZ
1759 * w32proc.c (sys_select): Accept and ignore one more argument.
1760
1761 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1762
0d23c240 1763 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1764 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1765
1766 * sysdep.c: Don't include dos.h and dosfns.h.
1767
1768 * process.c (sys_select):
1769 * msdos.c (sys_select): Accept one more argument and ignore it.
1770
1771 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1772 adapt data types and code to that.
1773
1774 * dosfns.c:
1775 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1776 which clashes with the gnulib function of the same name.
1777
af5a5a98
AS
17782012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1779
c5e4379c
AS
1780 * font.c (font_style_to_value, font_style_symbolic)
1781 (font_prop_validate_style): Add type checks for values in
1782 font_style_table.
1783
af5a5a98
AS
1784 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1785 argument.
1786 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1787 uses.
1788
8d38f461
EZ
17892012-06-29 Eli Zaretskii <eliz@gnu.org>
1790
2e5a6631
EZ
1791 * xdisp.c (try_window_id): Undo last change.
1792
8d38f461
EZ
1793 * w32.c (getwd): Adjust commentary about startup_dir.
1794 (init_environment): Always call sys_access, even in non-MSVC
1795 builds. Don't chdir to the directory of the Emacs executable.
1796 This undoes code from 1997 which was justified by the need to
1797 "avoid conflicts when removing and renaming directories". But its
1798 downside was that every relative file name was being interpreted
1799 relative to the directory of the Emacs executable, which can never
1800 be TRT. In particular, it broke sys_access when called with
1801 relative file names.
1802 (sys_access): Map GetLastError to errno.
1803
2af3565e
DA
18042012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1805
1806 * window.h (struct window): Change type of 'fringes_outside_margins'
1807 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 1808 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
1809 Adjust comment.
1810 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
1811 to ptrdiff_t.
1812
c8d3a25c 18132012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 1814
c8d3a25c
GM
1815 * gnutls.c (emacs_gnutls_handshake):
1816 Add QUIT to make the loop interruptible.
57570cd3 1817
c8d3a25c 18182012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 1819
c8d3a25c
GM
1820 * charset.c (init_charset): Make lack of etc/charsets fatal.
1821
3e984ee8
DA
18222012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1823
1824 * editfns.c (region_limit): Fix type mismatch.
1825
ef884f23
DA
18262012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1827
1828 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
1829 undefined. Convert from xassert to eassert.
1830 * nsmenu.m: Convert from xassert to eassert.
1831 * nsterm.m: Likewise.
1832
7d7e0027
SM
18332012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
1834
1835 * editfns.c (region_limit): Clip to narrowing (bug#11770).
1836
aa754e6a
PE
18372012-06-28 Paul Eggert <eggert@cs.ucla.edu>
1838
1839 Avoid integer overflow on scroll-left and scroll-right.
1840 * window.c (HSCROLL_MAX): New macro.
1841 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
1842 overflow when requested scroll falls outside ptrdiff_t range.
1843
80b00b08
DA
18442012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1845
1846 * window.h (struct window): Change type of 'hscroll',
1847 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
1848 'last_modified' and 'last_overlay_modified' to EMACS_INT.
1849 Adjust users accordingly.
1850 * xdisp.c (try_cursor_movement): Replace type check with eassert.
1851 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
1852 from EMACS_INT to ptrdiff_t.
1853 (make_window): Omit redundant initialization.
1854
62b2bcf6
JB
18552012-06-28 Juanma Barranquero <lekktu@gmail.com>
1856
1857 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
1858
45942c7d
DA
18592012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1860
1861 * window.h (struct window): Change type of 'use_time' and
1862 'sequence_number' from Lisp_Object to int.
1863 * frame.c (make_frame): Adjust users accordingly.
1864 * print.c (print_object): Likewise.
1865 * window.c (select_window, Fwindow_use_time, make_parent_window)
1866 (make_window): Likewise.
1867
e509cfa6
DA
18682012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1869
1870 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
1871 enabled with --enable-checking=[all,glyphs] configure option.
1872 Fix GLYPH_DEBUG usage assuming that it may be undefined,
1873 adjust comments accordingly.
1874 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
1875 undefined, adjust comments accordingly.
1876 * image.c: Likewise.
1877 * scroll.c: Likewise.
1878 * w32fns.c: Likewise.
1879 * w32term.c: Likewise.
1880 * xdisp.c: Likewise.
1881 * xfaces.c: Likewise.
1882 * xfns.c: Likewise.
1883 * xterm.c: Likewise.
1884
a54e2c05
DA
18852012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
1886
1887 Generalize run-time debugging checks.
1888 * dispextern.h (XASSERTS): Remove.
1889 * fontset.c (xassert): Remove.
1890 Convert from xassert to eassert.
1891 * alloc.c: Convert from xassert to eassert.
1892 * bidi.c: Likewise.
1893 * dispnew.c: Likewise.
1894 * fns.c: Likewise.
1895 * fringe.c: Likewise.
1896 * ftfont.c: Likewise.
1897 * gtkutil.c: Likewise.
1898 * image.c: Likewise.
1899 * keyboard.c: Likewise.
1900 * menu.c: Likewise.
1901 * process.c: Likewise.
1902 * scroll.c: Likewise.
1903 * sound.c: Likewise.
1904 * term.c: Likewise.
1905 * w32console.c: Likewise.
1906 * w32fns.c: Likewise.
1907 * w32term.c: Likewise.
1908 * window.c: Likewise.
1909 * xdisp.c: Likewise.
1910 * xfaces.c: Likewise.
1911 * xfns.c: Likewise.
1912 * xselect.c: Likewise.
1913 * xterm.c: Likewise.
1914
1ec4b7b2
SM
19152012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
1916
1917 * fns.c (maybe_resize_hash_table): Output message when growing the
1918 purify-hashtable.
1919
2014308a
DA
19202012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1921
1922 * alloc.c (allocate_string_data): Remove dead code.
1923 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
1924 avoid GCC warning about unused macro.
1925
246155eb
DA
19262012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1927
1928 * alloc.c (allocate_string): Omit intervals initialization.
1929 * alloc.c (make_uninit_multibyte_string): Initialize intervals
1930 as in make_pure_string and make_pure_c_string.
1931
43184b7b
DA
19322012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1933
d209e2fb 1934 * alloc.c (allocate_string): Fix last change.
43184b7b 1935
3fe6dd74
DA
19362012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
1937
d209e2fb 1938 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
1939 to memset, add explicit initialization where appropriate.
1940
1ba6038a
GM
19412012-06-27 Glenn Morris <rgm@gnu.org>
1942
1943 * lisp.mk (lisp): Remove paths.elc.
1944
c89926a5
CY
19452012-06-27 Chong Yidong <cyd@gnu.org>
1946
1947 * doc.c (Fsubstitute_command_keys): Fix punctuation.
1948
ed6b3510
JW
19492012-06-26 John Wiegley <johnw@newartisans.com>
1950
1ec4b7b2 1951 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
1952 on Mac OS X Lion: __mod_init_func and __mod_term_func.
1953
ed6b3510
JW
1954 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
1955 when building with Clang.
1956
8edd4a2b
SM
19572012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
1958
1959 * eval.c (Fapply): Allow calling it with a single argument.
1960
f6f62d1b
EZ
19612012-06-26 Eli Zaretskii <eliz@gnu.org>
1962
1963 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
1964 _stricmp and _strnicmp.
1965 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
1966
62efea5e
DA
19672012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1968
1969 * alloc.c (allocate_window): Zero out non-Lisp part of newly
1970 allocated window.
1971 (allocate_process): Likewise for new process.
8edd4a2b 1972 (allocate_terminal): Change to use offsetof.
62efea5e
DA
1973 (allocate_frame): Likewise.
1974 * frame.c (make_frame): Omit redundant initialization.
1975 * window.c (make_parent_window): Use memset.
1976 (make_window): Omit redundant initialization.
1977 * process.c (make_process): Omit redundant initialization.
1978 * terminal.c (create_terminal): Likewise.
1979
42997f4d
DA
19802012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1981
1982 * term.c (delete_tty): Remove redundant call to memset.
1983
1130ecfc
DA
19842012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
1985
1986 * alloc.c: Remove build_string.
1987 * lisp.h: Define build_string as static inline. This provides
1988 a better opportunity to optimize away calls to strlen when the
1989 function is called with compile-time constant argument.
1990 * image.c (imagemagick_error): Convert to build_string.
1991 * w32proc.c (sys_spawnve): Likewise.
1992 * xterm.c (x_term_init): Likewise.
1993
cf38a720
PE
19942012-06-26 Paul Eggert <eggert@cs.ucla.edu>
1995
99027bdd
PE
1996 Use sprintf return value instead of invoking strlen on result.
1997 In the old days this wasn't portable, since some sprintf
1998 implementations returned char *. But they died out years ago and
1999 Emacs already assumes sprintf returns int.
2000 Similarly for float_to_string.
2001 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2002 * ccl.c (ccl_driver):
2003 * character.c (string_escape_byte8):
2004 * data.c (Fnumber_to_string):
2005 * doprnt.c (doprnt):
2006 * print.c (print_object):
2007 * xdisp.c (message_dolog):
2008 * xfns.c (syms_of_xfns):
2009 Use sprintf or float_to_string result to avoid need to call strlen.
2010 * data.c (Fnumber_to_string):
2011 Use make_unibyte_string, since the string must be ASCII.
2012 * lisp.h, print.c (float_to_string): Now returns int length.
2013 * term.c (produce_glyphless_glyph):
2014 Use sprintf result rather than recomputing it.
2015
cf38a720
PE
2016 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2017 * Makefile.in (ALL_CFLAGS):
2018 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2019 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2020
3511c784
DA
20212012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2022
0a08eb21 2023 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2024 strcasecmp if available.
2025 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2026
fb7da12e
AS
20272012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2028
2029 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2030 Avoid comma operator.
2031 * menu.c (push_submenu_start, push_submenu_end)
2032 (push_left_right_boundary, push_menu_pane): Likewise.
2033 * msdos.c (dos_rawgetc): Likewise.
2034
afa2ffd8
DA
20352012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2036
2037 * xfns.c (xic_create_fontsetname): Remove redundant calls
2038 to memset.
2039
b3b4476b
PE
20402012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2041
4495ff38
PE
2042 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2043 sprintf already null-terminates its output.
2044
b3b4476b
PE
2045 * xfns.c (x_window): Remove redundant cast.
2046
b00876c9
DA
20472012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2048
2049 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2050 `const char *' to `char *' to avoid compiler warning.
2051
d188e26b
PE
20522012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2053
885d1d74
PE
2054 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2055 instead of truncating it to 63 (admittedly a generous limit).
2056
d188e26b
PE
2057 * process.c: Fix spelling and caps in comments.
2058
e2f560b1
DN
20592012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2060
e86db54b 2061 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2062 * sysdep.c (setpgrp): Remove definition, not used in this file.
2063
7583a3a1
JB
20642012-06-24 Juanma Barranquero <lekktu@gmail.com>
2065
2066 * makefile.w32-in: Update dependencies.
2067
696056c2
EZ
20682012-06-24 Eli Zaretskii <eliz@gnu.org>
2069
2070 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2071 (SYSTIME_H): Add nt/inc/sys/time.h.
2072
2073 * systime.h [WINDOWSNT]: Include sys/time.h.
2074
2075 * s/ms-w32.h (struct timespec): Definition moved from
2076 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2077
845ca893
PE
20782012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2079
2080 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2081 * buffer.h (buffer_slot_type_mismatch):
2082 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2083 * eval.c (unwind_to_catch):
2084 * image.c (my_png_error, my_error_exit):
2085 * keyboard.c (quit_throw_to_read_char, user_error)
2086 (Fexit_recursive_edit, Fabort_recursive_edit):
2087 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2088 (wrong_type_argument, buffer_overflow, __executable_start)
2089 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2090 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2091 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2092 (fatal):
2093 (child_setup) [!DOS_NT]:
2094 * lread.c (end_of_file_error, invalid_syntax):
2095 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2096 * puresize.h (pure_write_error):
2097 * search.c (matcher_overflow):
2098 * sound.c (sound_perror, alsa_sound_perror):
2099 * sysdep.c, syssignal.h (croak):
2100 * term.c (maybe_fatal, vfatal):
2101 * textprop.c (text_read_only):
2102 * undo.c (user_error):
2103 * unexmacosx.c (unexec_error):
2104 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2105 Use _Noreturn rather than NO_RETURN.
2106 No need for separate decl merely because of _Noreturn.
2107 * sound.c (sound_warning, parse_sound):
2108 Remove unnecessary forward decls.
2109
f1dd8073
PE
21102012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2111
2112 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2113 * lisp.h (WAIT_READING_MAX): New macro.
2114 * dispnew.c (Fsleep_for, sit_for):
2115 * keyboard.c (kbd_buffer_get_event):
2116 * process.c (Faccept_process_output):
2117 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2118 This improves on the previous patch, which introduced a bug
2119 when time_t is unsigned and as wide as intmax_t.
2120 See <http://bugs.gnu.org/9000#51>.
2121
b82c1755
EZ
21222012-06-23 Eli Zaretskii <eliz@gnu.org>
2123
2124 * dispnew.c (sit_for, Fsleep_for):
2125 * keyboard.c (kbd_buffer_get_event):
2126 * process.c (Faccept_process_output): Avoid compiler warnings when
2127 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2128
ca300656
JB
21292012-06-23 Juanma Barranquero <lekktu@gmail.com>
2130
049ec95b
JB
2131 * makefile.w32-in: Update dependencies.
2132
ca300656
JB
2133 * w32.c (ltime): Add return type and declare static.
2134 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2135
db7b8d06
PE
21362012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2137
2138 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2139 Privately reported by Herbert J. Skuhra.
2140 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2141 All uses changed.
2142 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2143 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2144
0bd8297f
EZ
21452012-06-23 Eli Zaretskii <eliz@gnu.org>
2146
96512555
EZ
2147 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2148 last argument of make_unibyte_string.
2149
0bd8297f
EZ
2150 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2151 language ID in the event parameters.
2152
2153 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2154 event.code, not the obscure "character set ID".
2155
63def6b6
CY
21562012-06-23 Chong Yidong <cyd@gnu.org>
2157
2158 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2159
e8a02204
EZ
21602012-06-23 Eli Zaretskii <eliz@gnu.org>
2161
388cdec0
EZ
2162 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2163 * w32.c (fdutimens): New function.
2164
2165 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2166
2167 * s/ms-w32.h (pselect): Redirect to sys_select.
2168
2169 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2170
e8a02204
EZ
2171 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2172 in the logic of incrementing and decrementing the value of
2173 use_relocatable_buffers.
2174
d054f3fb
PE
21752012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2176
2177 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2178 Privately reported by Herbert J. Skuhra.
2179 [__FreeBSD__]: Remove "*/" typo after "#include".
2180 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2181 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2182 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2183 Don't assume EMACS_TIME and struct timeval are the same type.
2184
d35af63c
PE
21852012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2186
2187 Support higher-resolution time stamps (Bug#9000).
2188 The time stamps are only nanosecond-resolution at the C level,
2189 since that's the best that any real-world system supports now.
2190 But they are picosecond-resolution at the Lisp level, as that's
2191 easy, and leaves room for future OS improvements.
2192
2193 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2194 (LIBES): Use it.
2195
2196 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2197 Don't get current time unless it's needed.
2198
2199 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2200 now provides it if it's absent.
2201 (start_atimer): Port to higher-res time stamps.
2202 Check for time stamp overflow. Don't get current time more
2203 often than is needed.
2204
2205 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2206 Include systime.h, not time.h.
2207 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2208
2209 * dired.c: Include stat-time.h.
2210 (Ffile-attributes): File times now have higher resolution.
2211
2212 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2213 (struct image): Timestamp now has higher resolution.
2214
2215 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2216 has at least microseconds now. All uses removed.
2217 (update_frame, update_single_window, update_window, update_frame_1)
2218 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2219
2220 * editfns.c (time_overflow): Now extern.
2221 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2222 (float-time, Fformat_time_string, Fcurrent_time_string)
2223 (Fcurrent_time_zone): Accept and generate higher-resolution
2224 time stamps.
2225 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2226 (decode_time_components, lisp_seconds_argument): New functions.
2227 (make_time): Now static.
2228 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2229 Report an error if the time is invalid, rather than having the caller
2230 do that.
2231
2232 * fileio.c: Include <stat-time.h>
2233 (Fcopy_file): Copy higher-resolution time stamps.
2234 Prefer to set the time stamp via a file descriptor if that works.
2235 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2236 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2237 (Fvisited_file_modtime, Fset_visited_file_modtime):
2238 Support higher-resolution time stamps.
2239
2240 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2241
2242 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2243
2244 * image.c (prepare_image_for_display, clear_image_cache)
2245 (lookup_image): Port to higer-resolution time stamps.
2246
2247 * keyboard.c (start_polling, bind_polling_period):
2248 Check for time stamp overflow.
2249 (read_char, kbd_buffer_get_event, timer_start_idle)
2250 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2251 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2252 Port to higher-resolution time stamps. Do not assume time_t is signed.
2253 (decode_timer): New function. Timers are now vectors of length 9,
2254 not 8, to accommodate the picosecond component.
2255 (timer_check_2): Use it.
2256
2257 * nsterm.m (select_timeout, timeval_subtract): Remove.
2258 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2259 as they're a bit more accurate and handle overflow better.
2260 (ns_select): Change prototype to be compatible with pselect.
2261 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2262 * nsterm.h (ns_select): Adjust prototype.
2263
2264 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2265 us-resolution time stamps.
2266 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2267
2268 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2269
2270 * lisp.h (time_overflow): New decl.
2271 (wait_reading_process_output): First arg is now intmax_t, not int,
2272 to accommodate larger waits.
2273
2274 * process.h (struct Lisp_Process.read_output_delay):
2275 Now counts nanoseconds, not microseconds.
2276 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2277 EMACS_HAS_USECS.
2278 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2279 (wait_reading_process_output):
2280 Port to ns-resolution time stamps.
2281 (Faccept_process_output, wait_reading_process_output):
2282 Check for time stamp overflow. Do not assume time_t is signed.
2283 (select_wrapper): Remove; we now use pselect.
2284 (Fprocess_attributes): Now generates ns-resolution time stamps.
2285
2286 * sysdep.c: Include utimens.h. Don't include utime.h
2287 or worry about struct utimbuf; gnulib does that for us now.
2288 (gettimeofday): Remove; gnulib provides a substitute.
2289 (make_timeval): New function.
2290 (set_file_times): Now sets ns-resolution time stamps.
2291 New arg FD; all uses changed.
2292 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2293 (system_process_attributes):
2294 Now returns ns-resolution time stamp. All uses changed.
2295 Check for time stamp overflow.
2296
2297 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2298 provides a substitute now.
2299
2300 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2301 since it guarantees struct timespec.
2302 (EMACS_TIME): Now struct timespec, so that we can support
2303 ns-resolution time stamps.
2304 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2305 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2306 (EMACS_USECS): Remove.
2307 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2308 so multiply the arg by 1000 before storing it.
2309 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2310 New macros.
2311 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2312 Port to ns-resolution time stamps.
2313 (EMACS_TIME_NEG_P): Remove; replaced by....
2314 (EMACS_TIME_SIGN): New macro.
2315 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2316 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2317 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2318 (make_timeval, make_lisp_time, decode_time_components): New decls.
2319 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2320 that it mishandled time_t overflow. You can't compare by subtracting!
2321 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2322 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2323
2324 * term.c: Include <sys/time.h>.
2325 (timeval_to_Time): New function, for proper overflow wraparound.
2326 (term_mouse_position, term_mouse_click): Use it.
2327
2328 * undo.c (record_first_change): Support higher-resolution time stamps
2329 in the undo buffer.
2330 (Fprimitive_undo): Use them when restoring time stamps.
2331
2332 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2333 (w32_get_internal_run_time):
2334 Port to higher-resolution Emacs time stamps.
2335 (ltime): Now accepts single 64-bit integer, as that's more convenient
2336 for callers.
2337
2338 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2339
2340 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2341 for compatibility with pselect. Support ns-resolution time stamps.
2342
2343 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2344
2345 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2346 Check for time stamp overflow, and support ns-resolution time stamps.
2347
2348 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2349 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2350 (timeval_subtract): Remove; no longer needed.
2351 (XTflash, XTring_bell, x_wait_for_event):
2352 Port to ns-resolution time stamps. Don't assume time_t is signed.
2353
b6a92dfe
CY
23542012-06-22 Chong Yidong <cyd@gnu.org>
2355
2356 * xdisp.c (x_consider_frame_title): Revert last change.
2357
d251c37c
EZ
23582012-06-22 Eli Zaretskii <eliz@gnu.org>
2359
2360 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2361 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2362 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2363 staticidx goes up to 1597 out of 1600 = 0x640.)
2364
f10deafb
PE
23652012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2366
2367 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2368 Otherwise, the umask might be mistakenly 0 while handling input signals.
2369
ec6de1e2
SM
23702012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2371
2372 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2373
28be1ada
DA
23742012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2375
2376 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2377 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2378 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2379 access to `contents' member of Lisp_Vector objects with AREF and ASET
2380 where appropriate.
2381
c6bf3022
CY
23822012-06-19 Chong Yidong <cyd@gnu.org>
2383
2384 * frame.c (delete_frame): When selecting a frame on a different
2385 text terminal, do not alter the terminal's top-frame.
2386
2387 * xdisp.c (format_mode_line_unwind_data): Record the target
2388 frame's selected window and its terminal's top-frame.
2389 (unwind_format_mode_line): Restore them.
2390 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2391 Callers changed.
2392 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2393 since tty frames can be explicitly named.
2394 (prepare_menu_bars): Likewise.
2395
2396 * term.c (Ftty_top_frame): New function.
2397
defd4196
PE
23982012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2399
2400 Port byte-code-meter to modern targets.
2401 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2402 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2403 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2404 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2405 (METER_1, METER_2): Simplify.
2406
1053a871
SM
24072012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2408
2409 * data.c (Fdefalias): Return `symbol' (bug#11686).
2410
b7e8d081
MR
24112012-06-18 Martin Rudalics <rudalics@gmx.at>
2412
2413 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2414 gets killed during executing of this function (Bug#11665).
2415 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2416 (Vkill_buffer_query_functions): In doc-string say that functions
2417 run by this hook should not change the current buffer.
2418
7ea2b339
PE
24192012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2420
2421 Fix recently-introduced process.c problems found by static checking.
2422 * process.c (write_queue_push, write_queue_pop, send_process):
2423 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2424 (write_queue_pop): Fix pointer signedness problem.
2425 (send_process): Remove unused local.
2426
96a313a1
CY
24272012-06-17 Chong Yidong <cyd@gnu.org>
2428
2429 * xdisp.c (redisplay_internal): No need to redisplay terminal
2430 frames that are not on top.
2431
20ca2e94
TN
24322012-06-17 Troels Nielsen <bn.troels@gmail.com>
2433
2434 * process.c (make_process): Initialize write_queue.
2435 (write_queue_push, write_queue_pop): New functions.
2436 (send_process): Use them to maintain correct ordering of process
2437 writes (Bug#10815).
2438
9a900ca9
PE
24392012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2440
310fbfa8
PE
2441 * lisp.h (eassert): Assume C89 or later.
2442 This removes the need for CHECK.
2443 (CHECK): Remove. Its comments about always evaluating its
2444 argument were confusing, as 'eassert' typically does not evaluate
2445 its argument.
2446
27bb1ca4
PE
2447 * coding.c (produce_chars): Use ptrdiff_t, not int.
2448
9a900ca9
PE
2449 * xterm.c (x_draw_underwave): Check for integer overflow.
2450 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2451
41b7f8bc 24522012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2453
2454 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2455 referenced (Bug#11583).
2456
9b0e3eba
AA
24572012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2458
2459 Implement wave-style variant of underlining.
2460 * dispextern.h (face_underline_type): New enum.
2461 (face): Add field for underline type.
2462 * nsterm.m (ns_draw_underwave): New function.
2463 (ns_draw_text_decoration): Use it.
2464 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2465 New functions.
2466 (x_draw_glyph_string): Use them.
2467 * xfaces.c (Qline, Qwave): New Lisp objects.
2468 (check_lface_attrs, merge_face_ref)
1053a871
SM
2469 (Finternal_set_lisp_face_attribute, realize_x_face):
2470 Handle wave-style underline face attributes.
9b0e3eba
AA
2471 * xterm.c (x_draw_underwave): New function.
2472 (x_draw_glyph_string): Use it.
2473
0fb52f11
JB
24742012-06-16 Juanma Barranquero <lekktu@gmail.com>
2475
2476 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2477 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2478 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2479 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2480 ($(BLD)/w32select.$(O)): Update dependencies.
2481
e5560ff7
AS
24822012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2483
2484 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2485 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2486 * character.c (_fetch_multibyte_char_p): Remove.
2487 * alloc.c: Include "character.h" before "buffer.h".
2488 * bidi.c: Likewise.
2489 * buffer.c: Likewise.
2490 * bytecode.c: Likewise.
2491 * callint.c: Likewise.
2492 * callproc.c: Likewise.
2493 * casefiddle.c: Likewise.
2494 * casetab.c: Likewise.
2495 * category.c: Likewise.
2496 * cmds.c: Likewise.
2497 * coding.c: Likewise.
2498 * composite.c: Likewise.
2499 * dired.c: Likewise.
2500 * dispnew.c: Likewise.
2501 * doc.c: Likewise.
2502 * dosfns.c: Likewise.
2503 * editfns.c: Likewise.
2504 * emacs.c: Likewise.
2505 * fileio.c: Likewise.
2506 * filelock.c: Likewise.
2507 * font.c: Likewise.
2508 * fontset.c: Likewise.
2509 * fringe.c: Likewise.
2510 * indent.c: Likewise.
2511 * insdel.c: Likewise.
2512 * intervals.c: Likewise.
2513 * keyboard.c: Likewise.
2514 * keymap.c: Likewise.
2515 * lread.c: Likewise.
2516 * macros.c: Likewise.
2517 * marker.c: Likewise.
2518 * minibuf.c: Likewise.
2519 * nsfns.m: Likewise.
2520 * nsmenu.m: Likewise.
2521 * print.c: Likewise.
2522 * process.c: Likewise.
2523 * regex.c: Likewise.
2524 * region-cache.c: Likewise.
2525 * search.c: Likewise.
2526 * syntax.c: Likewise.
2527 * term.c: Likewise.
2528 * textprop.c: Likewise.
2529 * undo.c: Likewise.
2530 * unexsol.c: Likewise.
2531 * w16select.c: Likewise.
2532 * w32fns.c: Likewise.
2533 * w32menu.c: Likewise.
2534 * window.c: Likewise.
2535 * xdisp.c: Likewise.
2536 * xfns.c: Likewise.
2537 * xmenu.c: Likewise.
2538 * xml.c: Likewise.
2539 * xselect.c: Likewise.
2540
2f07e6af
EZ
25412012-06-16 Eli Zaretskii <eliz@gnu.org>
2542
1053a871
SM
2543 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2544 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2545 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2546 row.
2547 (handle_face_prop): Use chunk-relative overlay string index when
2548 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2549 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2550 the rightmost. (Bug#11720)
2f07e6af 2551
29b83cec
AS
25522012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2553
2554 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2555 (CATEGORY_MEMBER): Enforce 1/0 value.
2556 * category.c (_temp_category_set): Remove.
2557
4c5501e9
EZ
25582012-06-16 Eli Zaretskii <eliz@gnu.org>
2559
2560 * window.c (Fdelete_other_windows_internal)
2561 (Fdelete_window_internal): Don't access frame's mouse highlight
2562 info of the initial frame. (Bug#11677)
2563
2b570124
PE
25642012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2565
e93864f9
PE
2566 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2567 Assume USE_2_TAGS_FOR_INTS.
2568 (xreload): Adjust $tagmask width to match recent lisp.h change.
2569
2b570124
PE
2570 Simplify lisp.h in minor ways that should not affect code.
2571 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2572 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2573 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2574 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2575 (INTTYPEBITS): New macro, for clarity.
2576 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2577 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2578 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2579 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2580 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2581
81755f69
JB
25822012-06-13 Juanma Barranquero <lekktu@gmail.com>
2583
2584 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2585
16192a57
GM
25862012-06-13 Glenn Morris <rgm@gnu.org>
2587
2588 * s/bsd-common.h (BSD4_3):
2589 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2590
646b5f55
AS
25912012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2592
2593 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2594 instead of union.
2595 (XLI, XIL): Define.
1053a871
SM
2596 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2597 Use them.
2598 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2599 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2600 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2601 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2602 * frame.c (delete_frame): Remove outdated comment.
2603 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2604 USE_LISP_UNION_TYPE.
2605 (Fw32_unregister_hot_key): Likewise.
2606 (Fw32_toggle_lock_key): Likewise.
2607 * w32menu.c (add_menu_item): Likewise.
2608 (w32_menu_display_help): Use XIL instead of checking
2609 USE_LISP_UNION_TYPE.
2610 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2611 (init_heap): Likewise.
2612 * w32term.c (w32_read_socket): Update comment.
2613
1d3823c9
GM
26142012-06-13 Glenn Morris <rgm@gnu.org>
2615
c62ff706
GM
2616 * s/usg5-4-common.h, src/s/unixware.h:
2617 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2618
1d3823c9
GM
2619 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2620
bfe3e0a2
PE
26212012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2622
2623 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2624 * alloc.c (make_number) [!defined make_number]:
2625 Remove, as lisp.h always defines this now.
2626 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2627 (roundup_size): Verify that it is a power of 2.
2628 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2629 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2630 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2631 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2632 USE_LSB_TAG now is always defined to be either 0 or 1.
2633 All uses changed.
2634 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2635 code works fine either way, and efficiency is not a concern here,
2636 as the union type is for debugging, not for production.
2637 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2638 Use an inline function on all platforms when using the union type,
2639 since this is simpler and 'static inline' can be used portably
2640 within Emacs now.
2641 (LISP_INITIALLY_ZERO): New macro.
2642 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2643 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2644
45fa9c0f
GM
26452012-06-12 Glenn Morris <rgm@gnu.org>
2646
b4492cba
GM
2647 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2648
2649 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2650
45fa9c0f
GM
2651 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2652 Move BROKEN_SIGIO to configure.
2653
2654 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2655 Move NO_TERMIO to configure.
2656
0e25d334
CY
26572012-06-12 Chong Yidong <cyd@gnu.org>
2658
2659 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2660 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2661 MagickExportImagePixels is undefined.
2662
43682bb6
PE
26632012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2664
2665 * image.c (imagemagick_load_image): Remove unused label.
2666
a9be7d2b
GM
26672012-06-11 Glenn Morris <rgm@gnu.org>
2668
2669 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2670 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2671 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2672 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2673
3017f87f
SM
26742012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2675
2676 * alloc.c (make_byte_code): New function.
2677 (Fmake_byte_code): Use it. Don't purify here.
2678 * lread.c (read1): Use it as well to avoid extra allocation.
2679
1b9b4cf4
CY
26802012-06-11 Chong Yidong <cyd@gnu.org>
2681
2682 * image.c (imagemagick_load_image): Implement transparency.
2683
95988fcf
AS
26842012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2685
2686 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2687 account for preceding backslashes. (Bug#11663)
2688
cd4eb164
CY
26892012-06-09 Chong Yidong <cyd@gnu.org>
2690
2691 * term.c: Support italics in capable terminals (Bug#9652).
2692 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2693 (turn_on_face): Output using TS_enter_italic_mode if available.
2694 Don't handle unused blinking and alt-charset cases.
2695 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2696 and tty_alt_charset_p cases.
2697 (tty_capable_p, init_tty): Support italics.
2698
2699 * termchar.h (struct tty_display_info): Add field for italics.
2700 Remove unused blink field.
2701
2702 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2703 Handle slant.
2704
2705 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2706 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2707 tty_alt_charset_p. Add tty_italic_p.
2708
ff88beb8
MA
27092012-06-09 Michael Albinus <michael.albinus@gmx.de>
2710
2711 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2712 dbus_type_is_basic if available.
2713 (xd_extract_signed, xd_extract_unsigned): Rename from
2714 extract_signed and extract_unsigned, respectively. Adapt callers.
2715
44286096
CY
27162012-06-09 Chong Yidong <cyd@gnu.org>
2717
1682701f
CY
2718 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2719
44286096
CY
2720 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2721 case (Bug#9752).
2722
d86feb17
PE
27232012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2724
2725 * xdisp.c (vmessage): Treat frame message as multibyte.
2726 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2727 would generate the diagnostic "Making \302\247 buffer-local while
2728 let-bound!".
2729
d5c20fe8
EZ
27302012-06-08 Eli Zaretskii <eliz@gnu.org>
2731
2732 * dispnew.c (showing_window_margins_p): Undo last change, which
2733 was done due to an inadvertent commit.
2734 (adjust_frame_glyphs_for_frame_redisplay): Do call
2735 showing_window_margins_p.
2736
513749ee
SM
27372012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2738
2739 * eval.c (Fmake_var_non_special): New primitive.
2740 (syms_of_eval): Defsubr it.
2741 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2742
d4a8f5c1
JB
27432012-06-08 Juanma Barranquero <lekktu@gmail.com>
2744
2745 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2746 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2747
8bbbc977
EZ
27482012-06-08 Eli Zaretskii <eliz@gnu.org>
2749
2750 * alloc.c (allocate_vectorlike): Fix last change.
2751
f3372c87
DA
27522012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2753
2754 Block-based vector allocation of small vectors.
2755 * lisp.h (struct vectorlike_header): New field `nbytes',
2756 adjust comment accordingly.
2757 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2758 to denote vector blocks. Adjust users (live_vector_p,
2759 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2760 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2761 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2762 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2763 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2764 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2765 (roundup_size): New constant.
2766 (struct vector_block): New data type.
2767 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2768 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2769 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2770 (sweep_vectors): New functions.
2771 (allocate_vectorlike): Return `zero_vector' as the only vector of
2772 0 items. Allocate new vector from block if vector size is less than
2773 or equal to VBLOCK_BYTES_MAX.
2774 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2775 (init_alloc_once): Add call to init_vectors.
2776
4f18a4ed
SM
27772012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2778
2779 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2780
86f158bc
PE
27812012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2782
2783 * doprnt.c (doprnt): Truncate multibyte char correctly.
2784 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2785 would mishandle a string argument "Xc" if X was a multibyte
2786 character of length 2: it would truncate after X's first byte
2787 rather than including all of X.
2788
c5cfcbe0
CY
27892012-06-06 Chong Yidong <cyd@gnu.org>
2790
2791 * buffer.c (word_wrap): Doc fix.
2792
c05cf390
PE
27932012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2794
2795 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2796
0c3461de
GM
27972012-06-03 Glenn Morris <rgm@gnu.org>
2798
2799 * xdisp.c (tool-bar-style): Doc fix.
2800
c71232db
UM
28012012-06-03 Ulrich Müller <ulm@gentoo.org>
2802
2803 * Makefile.in (PAXCTL): Define.
2804 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2805 binary via PaX flags if the paxctl utility is available.
2806 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
2807 Restore PaX flags to their default. (Bug#11398)
2808
383f7350
CY
28092012-06-03 Chong Yidong <cyd@gnu.org>
2810
2811 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
2812 buffer (Bug#11226).
2813
5f2c76c6
CY
28142012-06-03 Chong Yidong <cyd@gnu.org>
2815
2816 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
2817 (note_mode_line_or_margin_highlight): If there is no help echo,
2818 use mode-line-default-help-echo. Handle the case where the mouse
2819 position is past the end of the mode line string.
2820
2821 * buffer.c (buffer_local_value_1): New function, split from
2822 Fbuffer_local_value; can return Qunbound.
2823 (Fbuffer_local_value): Use it.
2824 (Vmode_line_format): Docstring tweaks.
2825
773d47f6
PE
28262012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2827
2828 * sysdep.c (system_process_attributes): Improve comment.
2829
f2d6a3df
SM
28302012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
2831
2832 * keyboard.c: Export real-this-command to Elisp.
2833 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
2834 and DEFVAR it. Update all users.
2835
63810350
PE
28362012-06-02 Paul Eggert <eggert@cs.ucla.edu>
2837
7bd5c1f4
PE
2838 * minibuf.c (Fassoc_string): Remove duplicate declaration.
2839
63810350
PE
2840 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
2841 Convert pctcpu and pctmem to Lisp float properly.
2842 Let the compiler fold better, as 100.0/0x8000 is exact.
2843
a2821611
AS
28442012-06-02 Andreas Schwab <schwab@linux-m68k.org>
2845
2846 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
2847 cons_block.
2848
5fceba1d
PE
28492012-06-01 Paul Eggert <eggert@cs.ucla.edu>
2850
2851 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
2852
c98ff5dd
DA
28532012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
2854
2855 For a 'struct window', replace some Lisp_Object fields to
2856 bitfields where appropriate, remove unused fields.
2857 * window.h (struct window): Remove unused 'last_mark_x' and
2858 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
2859 change it's type from Lisp_Object to bitfield.
2860 Change type of 'force_start', 'optional_new_start',
2861 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
2862 fields from Lisp_Object to bitfield. Adjust users accordingly.
2863
ca34e0be
PE
28642012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2865
2866 Pacify gcc -Wdouble-precision when using Xaw.
2867 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
2868 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
2869 Use 'float' consistently, rather than 'float' in most places
2870 and 'double' in a couple of places.
2871
efc00ab1 28722012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
2873
2874 * xdisp.c (handle_stop): Detect whether we have overlay strings
2875 loaded by testing it->current.overlay_string_index to be
2876 non-negative, instead of checking whether n_overlay_strings is
2877 positive. (Bug#11587)
2878
efc00ab1 28792012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
2880
2881 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
2882
2883 * doc.c (Fsubstitute_command_keys): Doc fix.
2884
efc00ab1 28852012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
2886
2887 * search.c (search_buffer): Remove calls to
2888 r_alloc_inhibit_buffer_relocation, as it is now called by
2889 maybe_unify_char, which was the cause of relocation of buffer text
2890 in bug#11519.
2891
efc00ab1 28922012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
2893
2894 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
2895 for the duration of call to load_charset, to avoid problems with
2896 callers of maybe_unify_char that access buffer text through C
2897 pointers.
2898
2899 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
2900 decrement the inhibition flag, instead of just setting or
2901 resetting it.
2902
ba93a187
PE
29032012-05-31 Paul Eggert <eggert@cs.ucla.edu>
2904
2905 Remove obsolete '#define static' cruft.
2906 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
2907 This #undef was "temporary" in 2000; it is no longer needed
2908 now that '#define static' has gone away.
2909 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
2910 (gray_bitmap_bits): Remove; no longer needed.
2911 All uses replaced with definiens.
2912 * xterm.c: Include "bitmaps/gray.xbm".
2913
9e4bf381
PE
29142012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2915
2916 Clean up __executable_start, monstartup when --enable-profiling.
2917 The following changes affect the code only when profiling.
2918 * dispnew.c (__executable_start): Rename from safe_bcopy.
2919 Define only on platforms that need it.
2920 * emacs.c: Include <sys/gmon.h> when profiling.
2921 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
2922 (__executable_start): Remove decl, since lisp.h does it now.
2923 (safe_bcopy): Remove decl; no longer has that name.
2924 (main): Coalesce #if into single bit of code, for simplicity.
2925 Cast pointers to uintptr_t, since standard libraries want integers
2926 and not pointers.
2927 * lisp.h (__executable_start): New decl.
2928
32d72c2f
GM
29292012-05-31 Glenn Morris <rgm@gnu.org>
2930
2931 * image.c (Fimagemagick_types): Doc fix.
2932
baac5bc7
JM
29332012-05-30 Jim Meyering <meyering@redhat.com>
2934
2935 * callproc.c (Fcall_process_region): Include directory component
2936 in mkstemp error message (Bug#11586).
2937
72cb32cf
PE
29382012-05-30 Paul Eggert <eggert@cs.ucla.edu>
2939
2940 * alloc.c, lisp.h (make_pure_vector): Now static.
2941
61b108cc
SM
29422012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
2943
2944 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
2945 Move to byte-run.el.
2946 (Fautoload): Do the hash-doc more carefully.
2947 * data.c (Fdefalias): Purify definition, except for keymaps.
2948 (Qdefun): Move from eval.c.
2949 * lisp.h (Qdefun): Remove.
2950 * lread.c (read1): Tiny simplification.
2951
471fe23d
TN
29522012-05-29 Troels Nielsen <bn.troels@gmail.com>
2953
934f3f58 2954 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
2955 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
2956 Bug#9642, but explicitly check that the buffer the overlay would
2957 be moved to is live and rearrange lines to make sure that errors
2958 will not put the overlay in an inconsistent state.
2959 (Fdelete_overlay): Cosmetics.
2960
85d0efd1
EZ
29612012-05-28 Eli Zaretskii <eliz@gnu.org>
2962
2963 * w32term.c (my_bring_window_to_top): New function.
2964 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
2965 could be different from the original one.
2966 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
2967 (Bug#11513)
2968
2969 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
2970 by calling BringWindowToTop.
2971
2972 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
2973 (WM_EMACS_END): Increase by one.
2974
da92a98c
PE
29752012-05-28 Paul Eggert <eggert@cs.ucla.edu>
2976
2977 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
2978 This avoids undefined behavior that might cause the eassert
2979 to not catch an out-of-range value.
2980
74d1f848
JB
29812012-05-28 Juanma Barranquero <lekktu@gmail.com>
2982
2983 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
2984 Update dependencies.
2985
9e1a06fc
EZ
29862012-05-27 Eli Zaretskii <eliz@gnu.org>
2987
2988 * bidi.c (bidi_mirror_char): Fix last change.
2989
f3dd7312
AS
29902012-05-27 Andreas Schwab <schwab@linux-m68k.org>
2991
2992 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
2993 when referring to sectname field in printf format.
2994
81899c91
PE
29952012-05-27 Paul Eggert <eggert@cs.ucla.edu>
2996
57b81a9f
PE
2997 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
2998 Only r_alloc_inhibit_buffer_relocation needed to be added;
2999 the others were already declared.
3000
81899c91
PE
3001 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3002 before checking whether it's out of range. Put the check inside
3003 eassert. See
3004 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3005
33017faf 30062012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3007
3008 * callproc.c (Fcall_process): Restore a line that was accidentally
3009 commented out in the 2011-02-13 change (bug#11547).
3010
33017faf 30112012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3012
3013 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3014 defined on ralloc.c.
3015
3016 * buffer.c [REL_ALLOC]: Remove prototypes of
3017 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3018 they are now on lisp.h.
3019
3020 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3021
3022 * search.c (search_buffer): Use it to inhibit relocation of buffer
3023 text while re_search_2 is doing its job, because re_search_2 is
3024 passed C pointers to buffer text. (Bug#11519)
3025
23415acf
EZ
3026 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3027 Update value to 24.
3028
44e27368
EZ
3029 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3030 state after an additional call to move_it_in_display_line_to, keep
3031 the values of it->max_ascent and it->max_descent found for the
3032 entire line.
3033 (pos_visible_p): Revert the comparison against bottom_y to what it
3034 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3035 (Bug#11464)
3036
c1892f11
PE
30372012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3038
3039 Fix coding-related core dumps with gcc -ftrapv.
3040 The code was computing A - B, where A and B are pointers, and B is
3041 random garbage. This can lead to core dumps on platforms that
3042 have special pointer registers, and it also leads to core dumps on
3043 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3044 A - B only when B is initialized properly.
3045 * coding.c (coding_set_source, coding_set_destination): Return void.
3046 (coding_change_source, coding_change_destinations): New functions,
3047 with the old behaviors of coding_set_source and coding_set_destination.
3048 All callers that need an offset changed to use these new functions.
3049
eb7afdad
GM
30502012-05-26 Glenn Morris <rgm@gnu.org>
3051
3052 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3053
f12fdf02
EZ
30542012-05-26 Eli Zaretskii <eliz@gnu.org>
3055
53a63be6 3056 Extend mouse support on W32 text-mode console.
61b108cc
SM
3057 * xdisp.c (draw_row_with_mouse_face):
3058 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3059
eb3f6f01 3060 * w32console.c: Include window.h.
61b108cc
SM
3061 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3062 New functions.
eb3f6f01
EZ
3063 (initialize_w32_display): Initialize mouse-highlight data.
3064
53a63be6
EZ
3065 * w32inevt.c: Include termchar.h and window.h.
3066 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3067 moves, call note_mouse_highlight. If help_echo changed, call
3068 gen_help_event to produce help-echo message in the echo area.
3069 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3070 highlight info.
3071
4cfd81f6
PE
30722012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3073
3074 * lread.c (read1): Simplify slightly to avoid an overflow warning
3075 with GCC 4.7.0 on x86-64.
3076
4446092a
EZ
30772012-05-26 Eli Zaretskii <eliz@gnu.org>
3078
3079 * bidi.c (bidi_mirror_char): Revert last change: an int is
3080 definitely wide enough here.
3081
42b2a986 30822012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3083
42b2a986 3084 Fix integer width and related bugs (Bug#9874).
eb106a49 3085 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3086 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3087 (string_bytes, check_sblock, allocate_string_data):
3088 (compact_small_strings, Fmake_bool_vector, make_string)
3089 (make_unibyte_string, make_multibyte_string)
3090 (make_string_from_bytes, make_specified_string)
3091 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3092 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3093 (mark_vectorlike):
3094 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3095 (allocate_pseudovector):
3096 Use int, not EMACS_INT, where int is wide enough.
3097 (inhibit_garbage_collection, Fgarbage_collect):
3098 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3099 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3100 int might not be wide enough.
3101 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3102 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3103 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3104 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3105 (bidi_level_of_next_char, bidi_move_to_visually_next):
3106 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3107 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3108 (Fkill_buffer, Fset_buffer_major_mode)
3109 (advance_to_char_boundary, Fbuffer_swap_text)
3110 (Fset_buffer_multibyte, overlays_at, overlays_in)
3111 (overlay_touches_p, struct sortvec, record_overlay_string)
3112 (overlay_strings, recenter_overlay_lists)
3113 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3114 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3115 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3116 (Foverlay_recenter, last_overlay_modification_hooks_used)
3117 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3118 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3119 (validate_region): Omit unnecessary test for b <= e,
3120 since that's guaranteed by the previous test.
d311d28c
PE
3121 (adjust_overlays_for_delete): Avoid pos + length overflow.
3122 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3123 (report_overlay_modification):
3124 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3125 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3126 Omit pointer cast, which isn't needed anyway, and doesn't work
3127 after the EMACS_INT -> ptrdiff_t change.
02481186 3128 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3129 * buffer.h: Adjust decls to match defn changes elsewhere.
3130 (struct buffer_text, struct buffer):
3131 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3132 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3133 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3134 not int, to avoid needless 32-bit limit on 64-bit hosts.
3135 (exec_byte_code): Use tighter memory-full test, one that checks
3136 for alloca overflow. Don't compute the address of the object just
3137 before an array, as that's not portable. Use EMACS_INT, not
3138 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3139 * callint.c (Fcall_interactively):
3140 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3141 * callproc.c (call_process_kill, Fcall_process):
3142 Don't assume pid_t fits into an Emacs fixnum.
3143 (call_process_cleanup, Fcall_process, child_setup):
3144 Don't assume pid_t fits into int.
3145 (call_process_cleanup, Fcall_process, delete_temp_file)
3146 (Fcall_process_region):
3147 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3148 (Fcall_process): Simplify handling of volatile integers.
3149 Use int, not EMACS_INT, where int will do.
3150 * casefiddle.c (casify_object, casify_region, operate_on_word)
3151 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3152 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3153 (casify_object): Avoid integer overflow when overallocating buffer.
3154 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3155 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3156 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3157 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3158 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3159 integers are now checked earlier. All uses replaced with XINT.
3160 (ccl_driver):
3161 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3162 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3163 (ccl_driver, Fregister_code_conversion_map):
3164 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3165 (resolve_symbol_ccl_program): Check that vector header is in range.
3166 Always copy the vector, so that we can check its contents reliably
3167 now rather than having to recheck each instruction as it's being
3168 executed. Check that vector words fit in 'int'.
3169 (ccl_get_compiled_code, Fregister_ccl_program)
3170 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3171 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3172 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3173 contents are in range.
3174 (Fccl_execute_on_string): Check that status is in range.
3175 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3176 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3177 Accept and return EMACS_INT, not int, because callers can pass values
3178 out of 'int' range.
3179 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3180 (multibyte_chars_in_text, parse_str_as_multibyte)
3181 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3182 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3183 (string_escape_byte8, Fget_byte):
3184 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3185 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3186 avoid mishandling large integers.
3187 * character.h: Adjust decls to match defn changes elsewhere.
3188 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3189 (Ffind_charset_region):
3190 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3191 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3192 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3193 Don't assume fixnum fits in int.
d311d28c
PE
3194 (load_charset_map_from_vector, Fmap_charset_chars):
3195 Remove now-unnecessary CHECK_NATNUMs.
3196 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3197 Don't rely on undefined behavior with signed left shift overflow.
3198 Don't assume unsigned int fits into fixnum, or that fixnum fits
3199 into unsigned int. Don't require max_code to be a valid fixnum;
3200 that's not true for gb10830 4-byte on a 32-bit host. Allow
3201 invalid_code to be a cons, for the same reason. Require code_offset
3202 to be a character. Avoid int overflow if max_char is close
3203 to INT_MAX.
3204 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3205 this is intended anyway and avoids some undefined behavior.
3206 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3207 INDEX_TO_CODE_POINT, as that's what it expects.
3208 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3209 * charset.h (DECODE_CHAR): Return int, not unsigned;
3210 this is what was intended anyway, and it avoids undefined behavior.
3211 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3212 integer-overflow issues.
3213 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3214 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3215 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3216 * chartab.c (Fmake_char_table, Fset_char_table_range)
3217 (uniprop_get_decoder, uniprop_get_encoder):
3218 Don't assume fixnum fits in int.
3219 * cmds.c (move_point): New function, that does the gist of
3220 Fforward_char and Fbackward_char, but does so while checking
3221 for integer overflow more accurately.
c96e5d6a 3222 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3223 (Fforward_line, Fend_of_line, internal_self_insert)
3224 (internal_self_insert):
3225 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3226 Fix a FIXME, by checking for integer overflow when calculating
3227 target_clm and actual_clm.
3228 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3229 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3230 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3231 (coding_alloc_by_making_gap, alloc_destination)
3232 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3233 (encode_coding_utf_16, detect_coding_emacs_mule)
3234 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3235 (detect_coding_iso_2022, decode_coding_iso_2022)
3236 (encode_invocation_designation, encode_designation_at_bol)
3237 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3238 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3239 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3240 (encode_coding_ccl, encode_coding_raw_text)
3241 (detect_coding_charset, decode_coding_charset)
3242 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3243 (produce_composition, produce_charset, produce_annotation)
3244 (decode_coding, handle_composition_annotation)
3245 (handle_charset_annotation, consume_chars, decode_coding_gap)
3246 (decode_coding_object, encode_coding_object, detect_coding_system)
3247 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3248 (code_convert_region, code_convert_string)
8f50130c
PE
3249 (Fdefine_coding_system_internal)
3250 (coding_set_source, coding_set_destination):
d311d28c
PE
3251 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3252 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3253 (Fdefine_coding_system_internal):
3254 Don't assume fixnums fit in int.
3255 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3256 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3257 (Funencodable_char_position, Fcheck_coding_systems_region)
3258 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3259 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3260 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3261 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3262 Don't access memory outside of the args array.
d311d28c 3263 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3264 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3265 result of ENCODE_CHAR.
d311d28c
PE
3266 * coding.h: Adjust decls to match defn changes elsewhere.
3267 (struct coding_system):
3268 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3269 * composite.c (get_composition_id, find_composition)
3270 (run_composition_function, update_compositions)
3271 (compose_text, composition_gstring_put_cache)
3272 (composition_gstring_p, composition_gstring_width)
3273 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3274 (composition_compute_stop_pos, composition_reseat_it)
3275 (composition_update_it, struct position_record)
3276 (find_automatic_composition, composition_adjust_point)
3277 (Fcomposition_get_gstring, Ffind_composition_internal):
3278 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3279 (update_compositions):
3280 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3281 * composite.h: Adjust decls to match defn changes elsewhere.
3282 (struct composition):
3283 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3284 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3285 Do not attempt to compute the address of the object just before a
3286 buffer; this is not portable.
3287 (Faref, Faset):
3288 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3289 (Faset): Use int, not EMACS_INT, where int is wide enough.
3290 (Fstring_to_number): Don't assume fixnums fit in int.
3291 (Frem): Don't assume arg is nonnegative.
3292 * dbusbind.c (xd_append_arg): Check for integers out of range.
3293 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3294 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3295 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3296 (xd_get_connection_references): Return ptrdiff_t, not int.
3297 All uses changed.
3298 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3299 (xd_read_message_1):
3300 Use int, not unsigned, where the dbus API uses int.
3301 (Fdbus_message_internal): Don't overflow mtype.
3302 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3303 * dired.c (directory_files_internal, file_name_completion, scmp)
3304 (file_name_completion_stat):
3305 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3306 (file_name_completion): Don't overflow matchcount.
3307 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3308 * dispextern.h: Adjust decls to match defn changes elsewhere.
3309 (struct text_pos, struct glyph, struct bidi_saved_info)
3310 (struct bidi_string_data, struct bidi_it, struct composition_it)
3311 (struct it):
3312 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3313 (struct display_pos, struct composition_it, struct it):
3314 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3315 * dispnew.c (increment_matrix_positions)
3316 (increment_row_positions, mode_line_string)
3317 (marginal_area_string):
3318 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3319 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3320 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3321 (duration_to_sec_usec): New function, to check for overflow better.
3322 (Fsleep_for, sit_for): Use it.
3323 * doc.c (get_doc_string, store_function_docstring):
3324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3325 (get_doc_string, Fsnarf_documentation):
3326 Use int, not EMACS_INT, where int is wide enough.
3327 (get_doc_string):
3328 Use SAFE_ALLOCA, not alloca.
3329 Check for overflow when converting EMACS_INT to off_t.
3330 * doprnt.c (doprnt):
3331 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3332 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3333 Don't assume uid_t fits into fixnum.
3334 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3335 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3336 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3337 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3338 (general_insert_function)
3339 (Finsert_char, make_buffer_string, make_buffer_string_both)
3340 (update_buffer_properties, Fbuffer_substring)
3341 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3342 (Fsubst_char_in_region, check_translation)
3343 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3344 (transpose_markers, Ftranspose_regions):
3345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3346 (clip_to_bounds): Move to lisp.h as an inline function).
3347 (Fconstrain_to_field): Don't assume integers are nonnegative.
3348 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3349 (Fsubst_char_in_region, Fsave_restriction):
3350 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3351 (Femacs_pid): Don't assume pid_t fits into fixnum.
3352 (lo_time): Use int, not EMACS_INT, when int suffices.
3353 (lisp_time_argument): Check for usec out of range.
3354 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3355 (Fuser_login_name, Fuser_full_name): Signal an error
3356 if a uid argument is out of range, rather than relying on
3357 undefined behavior.
c8d5c857
PE
3358 (Fformat_time_string): Remove now-unnecessary check.
3359 lisp_time_argument checks for out-of-range usec now.
243e0530 3360 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3361 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3362 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3363 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3364 (init_cmdargs, Fdump_emacs):
3365 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3366 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3367 the bottom (typically) 32 bits of the fixnum.
3368 * eval.c (specpdl_size, call_debugger):
3369 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3370 (when_entered_debugger, Fbacktrace_debug):
3371 Don't assume fixnum can fit in int.
3372 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3373 the object just before a buffer; this is not portable.
3374 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3375 (grow_specpdl, unbind_to):
3376 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3377 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3378 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3379 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3380 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3381 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3382 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3383 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3384 (a_write, e_write):
3385 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3386 (Fcopy_file, non_regular_nbytes, read_non_regular)
3387 (Finsert_file_contents):
3388 Use int, not EMACS_INT, where int is wide enough.
3389 (READ_BUF_SIZE): Verify that it fits in int.
3390 (Finsert_file_contents): Check that counts are in proper range,
3391 rather than assuming fixnums fit into ptrdiff_t etc.
3392 Don't assume fixnums fit into int.
125b3835 3393 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3394 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3395 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3396 (string_char_to_byte, string_byte_to_char)
3397 (string_make_multibyte, string_to_multibyte)
3398 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3399 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3400 (substring_both, Fdelete, internal_equal, Ffillarray)
3401 (Fclear_string, mapcar1)
3402 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3403 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3404 (larger_vector, make_hash_table, maybe_resize_hash_table)
3405 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3406 (Fmaphash, secure_hash):
3407 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3408 (concat): Check for string index and length overflow.
3409 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3410 (Frequire):
3411 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3412 (larger_vector): New API (vec, incr_min, size_max) replaces old
3413 one (vec, new_size, init). This catches size overflow.
3414 INIT was removed because it was always Qnil.
3415 All callers changed.
3416 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3417 the upper bound on a hash table index size.
3418 (make_hash_table, maybe_resize_hash_table): Use it.
3419 (secure_hash): Computer start_byte and end_byte only after
3420 they're known to be in ptrdiff_t range.
3421 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3422 (Ffont_get_glyphs, Ffont_at):
3423 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3424 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3425 (Flist_fonts, Fopen_font):
3426 Don't assume fixnum can fit in int.
3427 (check_gstring): Don't assume index can fit in int.
3428 (font_match_p): Check that fixnum is a character, not a nonnegative
3429 fixnum, since the later code needs to stuff it into an int.
3430 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3431 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3432 conversion overflow issues.
3433 (Fopen_font): Check for integer out of range.
3434 (Ffont_get_glyphs): Don't assume index can fit in int.
3435 * font.h: Adjust decls to match defn changes elsewhere.
3436 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3437 integer overflow.
3438 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3439 printmax_t, where ptrdiff_t is wide enough.
3440 (Finternal_char_font):
3441 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3442 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3443 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3444 (Fset_frame_position, x_set_frame_parameters)
3445 (x_set_line_spacing, x_set_border_width)
3446 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3447 Check that fixnums are in proper range for system types.
3448 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3449 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3450 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3451 Use SAFE_ALLOCA_LISP, not alloca.
3452 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3453 intptr_t is wide enough.
3454 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3455 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3456 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3457 Check for fixnum out of range.
3458 * ftfont.c (ftfont_list): Don't assume index fits in int.
3459 Check that fixnums are in proper range for system types.
3460 (ftfont_shape_by_flt):
3461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3462 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3463 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3464 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3465 Check that fixnums are in proper range for system types.
3466 * gnutls.h: Adjust decls to match defn changes elsewhere.
3467 * gtkutil.c (xg_dialog_run):
3468 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3469 (update_frame_tool_bar):
3470 Check that fixnums are in proper range for system types.
3471 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3472 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3473 * indent.c (last_known_column, last_known_column_point):
3474 (current_column_bol_cache):
3475 (skip_invisible, current_column, check_display_width):
3476 (check_display_width, scan_for_column, current_column_1)
3477 (Findent_to, Fcurrent_indentation, position_indentation)
3478 (indented_beyond_p, Fmove_to_column, compute_motion):
3479 (Fcompute_motion, Fvertical_motion):
3480 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3481 (last_known_column_modified): Use EMACS_INT, not int.
3482 (check_display_width):
3483 (Fcompute_motion):
3484 Check that fixnums and floats are in proper range for system types.
3485 (compute_motion): Don't assume index or fixnum fits in int.
3486 (compute_motion, Fcompute_motion):
3487 Use int, not EMACS_INT, when it is wide enough.
3488 (vmotion): Omit local var start_hpos that is always 0; that way
3489 we don't need to worry about overflow in expressions involving it.
3490 * indent.h: Adjust decls to match defn changes elsewhere.
3491 (struct position):
3492 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3493 Use int, not EMACS_INT, where int is wide enough.
3494 Remove unused members ovstring_chars_done and tab_offset;
3495 all uses removed.
3496 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3497 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3498 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3499 (make_gap, copy_text, insert, insert_and_inherit)
3500 (insert_before_markers, insert_before_markers_and_inherit)
3501 (insert_1, count_combining_before, count_combining_after)
3502 (insert_1_both, insert_from_string)
3503 (insert_from_string_before_markers, insert_from_string_1)
3504 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3505 (adjust_after_replace, adjust_after_insert, replace_range)
3506 (replace_range_2, del_range, del_range_1, del_range_byte)
3507 (del_range_both, del_range_2, modify_region)
3508 (prepare_to_modify_buffer, signal_before_change)
3509 (signal_after_change, Fcombine_after_change_execute):
3510 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3511 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3512 (balance_an_interval, split_interval_right, split_interval_left)
3513 (find_interval, next_interval, update_interval)
3514 (adjust_intervals_for_insertion, delete_node, delete_interval)
3515 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3516 (static_offset_intervals, offset_intervals)
3517 (merge_interval_right, merge_interval_left, make_new_interval)
3518 (graft_intervals_into_buffer, temp_set_point_both)
3519 (temp_set_point, set_point, adjust_for_invis_intang)
3520 (set_point_both, move_if_not_intangible, get_property_and_range)
3521 (get_local_map, copy_intervals, copy_intervals_to_string)
3522 (compare_string_intervals, set_intervals_multibyte_1):
3523 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3524 * intervals.h: Adjust decls to match defn changes elsewhere.
3525 (struct interval):
3526 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3527 * keyboard.c (this_command_key_count, this_single_command_key_start)
3528 (before_command_key_count, before_command_echo_length, echo_now)
3529 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3530 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3531 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3532 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3533 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3534 (last_non_minibuf_size, last_point_position, echo_truncate)
3535 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3536 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3537 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3538 (stuff_buffered_input):
3539 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3540 (last_auto_save, command_loop_1, read_char):
3541 Use EMACS_INT, not int, to avoid integer overflow.
3542 (record_char): Avoid overflow in total_keys computation.
3543 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3544 * keyboard.h: Adjust decls to match defn changes elsewhere.
3545 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3546 (Fkey_description, Fdescribe_vector, Flookup_key):
3547 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3548 (click_position): New function, to check that positions are in range.
3549 (Fcurrent_active_maps):
3550 (describe_command):
3551 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3552 (Faccessible_keymaps, Fkey_description):
3553 (preferred_sequence_p):
3554 Don't assume fixnum can fit into int.
3555 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3556 Check for integer overflow in size calculations.
3557 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3558 avoid mishandling large integers.
3559 * lisp.h: Adjust decls to match defn changes elsewhere.
3560 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3561 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3562 (struct Lisp_Marker):
3563 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3564 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3565 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3566 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3567 All callers changed.
3568 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3569 Assume the arg has valid form, since it always does.
3570 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3571 unsigned integer system type.
3572 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3573 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3574 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3575 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3576 (duration_to_sec_usec): New decl.
3577 * lread.c (read_from_string_index, read_from_string_index_byte)
3578 (read_from_string_limit, readchar, unreadchar, openp)
3579 (read_internal_start, read1, oblookup):
3580 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3581 (Fload, readevalloop, Feval_buffer, Feval_region):
3582 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3583 (openp): Check for out-of-range argument to 'access'.
3584 (read1): Use int, not EMACS_INT, where int is wide enough.
3585 Don't assume fixnum fits into int.
6efdadfd 3586 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3587 (read_filtered_event): Use duration_to_sec_usec
3588 to do proper overflow checking on durations.
d311d28c
PE
3589 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3590 in size calculation.
3591 (Fexecute_kbd_macro):
3592 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3593 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3594 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3595 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3596 (set_marker_both, set_marker_restricted_both, marker_position)
3597 (marker_byte_position, Fbuffer_has_markers_at):
3598 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3599 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3600 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3601 It now merely ensures that the menu is large enough, without
3602 necessarily growing it, as this avoids some integer overflow issues.
3603 All callers changed.
3604 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3605 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3606 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3607 Use SAFE_ALLOCA_LISP, not alloca.
3608 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3609 to EMACS_INT. Check that fixnums are in proper range for system types.
3610 * minibuf.c (minibuf_prompt_width, string_to_object)
3611 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3612 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3613 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3614 (get_minibuffer, read_minibuf_unwind):
3615 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3616 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3617 this simplifies overflow checking. All callers changed.
3618 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3619 (Ftest_completion):
3620 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3621 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3622 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3623 Check that fixnums are in proper range for system types.
3624 (Fx_create_frame, Fx_show_tip):
3625 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3626 * nsfont.m (ns_findfonts, nsfont_list_family):
3627 Don't assume fixnum fits in long.
3628 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3629 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3630 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3631 wide enough.
17fdb222 3632 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3633 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3634 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3635 (PRINTDECLARE, PRINTPREPARE):
3636 (strout, print_string):
3637 (print, print_preprocess, print_check_string_charset_prop)
3638 (print_object):
3639 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3640 (PRINTDECLARE):
3641 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3642 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3643 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3644 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3645 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3646 (print_error_message): Use SAFE_ALLOCA, not alloca.
3647 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3648 (print_depth, new_backquote_output, print_number_index):
3649 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3650 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3651 (Fset_process_window_size, Fformat_network_address)
3652 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3653 (sigchld_handler):
d311d28c 3654 Check that fixnums are in proper range for system types.
d44287d4 3655 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3656 Check for process-ids out of pid_t range rather than relying on
3657 undefined behavior.
e4d81efc 3658 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3659 (Fformat_network_address, read_process_output, send_process)
3660 (Fprocess_send_region, status_notify):
3661 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3662 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3663 (wait_reading_process_output, read_process_output, exec_sentinel):
3664 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3665 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3666 (Faccept_process_output): Use duration_to_sec_usec to do proper
3667 overflow checking on durations.
dde14581
PE
3668 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3669 Don't assume pid_t fits in int.
02481186
PE
3670 * process.h (struct Lisp_Process): Members tick and update_tick
3671 are now of type EMACS_INT, not int.
b62b53e8
PE
3672 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3673 configured --with-wide-int.
d311d28c
PE
3674 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3675 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3676 * search.c (looking_at_1, string_match_1):
3677 (fast_string_match, fast_c_string_match_ignore_case)
3678 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3679 (scan_newline, find_before_next_newline, search_command)
3680 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3681 (set_search_regs, wordify):
3682 (Freplace_match):
3683 (Fmatch_data):
3684 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3685 (string_match_1, search_buffer, set_search_regs):
3686 (Fmatch_data):
3687 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3688 (wordify): Check for overflow in size calculation.
3689 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3690 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3691 Check that fixnums are in proper range for system types.
3692 * sound.c (struct sound_device)
3693 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3694 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3695 (Fplay_sound_internal):
3696 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3697 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3698 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3699 (Fparse_partial_sexp):
3700 Don't assume fixnums can fit in int.
3701 (struct lisp_parse_state, find_start_pos, find_start_value)
3702 (find_start_value_byte, find_start_begv)
3703 (update_syntax_table, char_quoted, dec_bytepos)
3704 (find_defun_start, prev_char_comend_first, back_comment):
3705 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3706 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3707 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3708 (Finternal_describe_syntax_value): Check that match_lisp is a
3709 character, not an integer, since the code stuffs it into int.
3710 (scan_words, scan_sexps_forward):
3711 Check that fixnums are in proper range for system types.
3712 (Fforward_word):
3713 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3714 (scan_sexps_forward):
3715 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3716 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3717 * syntax.h: Adjust decls to match defn changes elsewhere.
3718 (struct gl_state_s):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3720 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3721 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3722 * sysdep.c (wait_for_termination_1, wait_for_termination)
3723 (interruptible_wait_for_termination, mkdir):
3724 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3725 (emacs_read, emacs_write):
3726 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3727 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3728 and double all fit in int.
d311d28c
PE
3729 * term.c (set_tty_color_mode):
3730 Check that fixnums are in proper range for system types.
3731 * termhooks.h (struct input_event):
3732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3733 * textprop.c (validate_interval_range, interval_of)
3734 (Fadd_text_properties, set_text_properties_1)
3735 (Fremove_text_properties, Fremove_list_of_text_properties)
3736 (Ftext_property_any, Ftext_property_not_all)
3737 (copy_text_properties, text_property_list, extend_property_ranges)
3738 (verify_interval_modification):
3739 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3740 (Fnext_single_char_property_change)
3741 (Fprevious_single_char_property_change):
3742 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3743 (copy_text_properties):
3744 Check for integer overflow in index calculation.
d311d28c
PE
3745 * undo.c (last_boundary_position, record_point, record_insert)
3746 (record_delete, record_marker_adjustment, record_change)
3747 (record_property_change):
3748 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3749 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3750 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3751 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3752 (Fx_hide_tip, Fx_file_dialog):
3753 * w32menu.c (set_frame_menubar):
3754 Use ptrdiff_t, not int, for consistency with rest of code.
3755 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3756 (select_window, Fdelete_other_windows_internal)
3757 (window_scroll_pixel_based, window_scroll_line_based)
3758 (Frecenter, Fset_window_configuration):
3759 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3760 (Fset_window_hscroll, run_window_configuration_change_hook)
3761 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3762 (Fscroll_other_window, Frecenter):
d311d28c
PE
3763 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3764 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3765 Don't assume fixnum fits in int.
3766 (Fset_window_scroll_bars):
3767 Check that fixnums are in proper range for system types.
3768 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3769 (string_pos, c_string_pos, number_of_chars, init_iterator)
3770 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3771 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3772 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3773 (face_before_or_after_it_pos, handle_invisible_prop)
3774 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3775 (display_prop_intangible_p, string_buffer_position_lim)
3776 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3777 (get_overlay_strings_1, get_overlay_strings)
3778 (iterate_out_of_display_property, forward_to_next_line_start)
3779 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3780 (get_next_display_element, set_iterator_to_next)
3781 (get_visually_first_element, compute_stop_pos_backwards)
3782 (handle_stop_backwards, next_element_from_buffer)
3783 (move_it_in_display_line_to, move_it_in_display_line)
3784 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3785 (add_to_log, message_dolog, message_log_check_duplicate)
3786 (message2, message2_nolog, message3, message3_nolog
3787 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3788 (current_message_1, truncate_echo_area, truncate_message_1)
3789 (set_message, set_message_1, store_mode_line_noprop)
3790 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3791 (text_outside_line_unchanged_p, check_point_in_composition)
3792 (reconsider_clip_changes)
3793 (redisplay_internal, set_cursor_from_row, try_scrolling)
3794 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3795 (redisplay_window, find_last_unchanged_at_beg_row)
3796 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3797 (trailing_whitespace_p, find_row_edges, display_line)
3798 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3799 (display_mode_element, store_mode_line_string)
3800 (pint2str, pint2hrstr, decode_mode_spec)
3801 (display_count_lines, display_string, draw_glyphs)
3802 (x_produce_glyphs, x_insert_glyphs)
3803 (rows_from_pos_range, mouse_face_from_buffer_pos)
3804 (fast_find_string_pos, mouse_face_from_string_pos)
3805 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 (safe_call, init_from_display_pos, handle_fontified_prop)
3808 (handle_single_display_spec, load_overlay_strings)
3809 (with_echo_area_buffer, setup_echo_area_for_printing)
3810 (display_echo_area, echo_area_display)
3811 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
3812 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
3813 (redisplay_window, dump_glyph_row, display_mode_line)
3814 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 3815 (handle_display_spec, display_prop_string_p):
d311d28c
PE
3816 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3817 (handle_single_display_spec, build_desired_tool_bar_string)
3818 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
3819 (get_specified_cursor_type):
3820 Check that fixnums are in proper range for system types.
3821 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
3822 (Flookup_image_map):
3823 Don't assume fixnums fit in int.
3824 (compare_overlay_entries):
3825 Avoid mishandling comparisons due to subtraction overflow.
3826 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
3827 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
3828 (handle_tool_bar_click):
3829 Use int, not unsigned, since we prefer signed and the signedness
3830 doesn't matter here.
3831 (get_next_display_element, next_element_from_display_vector):
3832 Use int, not EMACS_INT, when int is wide enough.
3833 (start_hourglass): Use duration_to_sec_usec to do proper
3834 overflow checking on durations.
3835 * xfaces.c (Fbitmap_spec_p):
3836 Check that fixnums are in proper range for system types.
3837 (compare_fonts_by_sort_order):
3838 Avoid mishandling comparisons due to subtraction overflow.
3839 (Fx_family_fonts, realize_basic_faces):
3840 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3841 (Fx_family_fonts):
3842 Don't assume fixnum fits in int.
3843 Use SAFE_ALLOCA_LISP, not alloca.
3844 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
3845 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
3846 (face_at_buffer_position, face_for_overlay_string)
3847 (face_at_string_position):
3848 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3849 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
3850 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
3851 (Fx_show_tip):
3852 Check that fixnums are in proper range for system types.
3853 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3854 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
3855 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3856 (Fx_change_window_property): Don't assume fixnums fit in int.
3857 * xfont.c (xfont_chars_supported):
3858 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3859 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
3860 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
3861 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3862 * xml.c (parse_region):
3863 * xrdb.c (magic_file_p):
3864 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3865 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
3866 (x_get_local_selection, x_reply_selection_request)
3867 (x_handle_selection_request, wait_for_property_change):
3868 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3869 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
3870 short is wide enough.
3871 (x_send_client_event): Don't assume fixnum fits in int.
3872 * xterm.c (x_x_to_emacs_modifiers):
3873 Don't assume EMACS_INT overflows nicely into int.
3874 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
3875 may come from Lisp.
3876 (handle_one_xevent): NATNUMP can eval its arg twice.
3877 (x_connection_closed):
3878 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3879 * xterm.h: Adjust decls to match defn changes elsewhere.
3880 (struct scroll_bar): Use struct vectorlike_header
3881 rather than rolling our own approximation.
3882 (SCROLL_BAR_VEC_SIZE): Remove; not used.
3883
c6574eb5
GM
38842012-05-25 Glenn Morris <rgm@gnu.org>
3885
3886 * lisp.mk (lisp): Update for more files being compiled now.
3887
e8d32c7e
SM
38882012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
3889
48def666
SM
3890 * lread.c: Remove `read_pure' which makes no difference.
3891 (read_pure): Remove var.
3892 (unreadpure): Remove function.
3893 (readevalloop): Don't call read_list with -1 flag.
3894 (read1, read_vector): Don't test read_pure any more.
3895 (read_list): Simplify.
3896
e8d32c7e
SM
3897 * fileio.c, character.h: Minor style tweaks.
3898
4b2addb7
DA
38992012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
3900
3901 * window.h (clip_changed): Remove useless declaration.
3902
584461b2
JB
39032012-05-22 Juanma Barranquero <lekktu@gmail.com>
3904
3905 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
3906 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
3907
34374650
PE
39082012-05-22 Paul Eggert <eggert@cs.ucla.edu>
3909
3910 Remove src/m/*.
3911 This directory predates autoconf and is no longer needed nowadays.
3912 Move its few remaining bits of functionality to where they're needed.
3913 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
3914 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
3915 * m/template.h: Remove.
3916 * Makefile.in (M_FILE): Remove. All uses removed.
3917 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
3918 * lisp.h (USE_LSB_TAG):
3919 * mem-limits.h (EXCEEDS_LISP_PTR):
3920 Use VAL_MAX, not VALBITS, in #if.
3921 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
3922 (EMACS_UINT): Define unconditionally now.
3923 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
3924 (BITS_PER_EMACS_INT): New constants, replacing
3925 what used to be in config.h, but not useful in #if.
3926 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
3927 define them any more.
3928 (VAL_MAX): New macro.
3929 (VALMASK): Use it.
3930 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
3931 BITS_PER_EMACS_INT, in #if.
3932 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
3933 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
3934 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
3935 * s/ms-w32.h (DATA_START):
3936 Move here from removed file m/intel386.h.
3937 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
3938 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
3939
261cb4bb
PE
39402012-05-21 Paul Eggert <eggert@cs.ucla.edu>
3941
3942 Assume C89 or later.
3943 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
3944 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
3945 (xrealloc):
3946 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
3947 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
3948 * textprop.c, tparam.c (NULL): Remove.
3949 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
3950 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
3951 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
3952 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
3953 * xterm.c (input_signal_count): Assume volatile works.
3954
ff23cd9f
KB
39552012-05-21 Ken Brown <kbrown@cornell.edu>
3956
3957 * xgselect.c (xg_select): Fix first argument in call to 'select'
3958 (bug#11508).
3959
1b170bc6
KB
39602012-05-20 Ken Brown <kbrown@cornell.edu>
3961
3962 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 3963 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 3964
b2f4d39f
KB
39652012-05-19 Ken Brown <kbrown@cornell.edu>
3966
3967 * xfns.c (x_in_use): Remove `static' qualifier.
3968 * xterm.h (x_in_use): Declare.
3969 * xgselect.c: Include xterm.h.
3970 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
3971 and `display_arg' (bug#9754).
3972
003fdae2
PE
39732012-05-19 Paul Eggert <eggert@cs.ucla.edu>
3974
9232a6d9
PE
3975 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
3976
003fdae2
PE
3977 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
3978 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
3979
784b56e2
EZ
39802012-05-18 Eli Zaretskii <eliz@gnu.org>
3981
3982 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
3983
3984 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 3985 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
3986
3987 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
3988 reference to image_cache->refcount.
3989 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
3990
a0a79cde
JL
39912012-05-17 Juri Linkov <juri@jurta.org>
3992
3993 * search.c (Fword_search_regexp, Fword_search_backward)
3994 (Fword_search_forward, Fword_search_backward_lax)
3995 (Fword_search_forward_lax): Move functions to isearch.el
3996 (bug#10145, bug#11381).
3997
b0572523
PE
39982012-05-16 Paul Eggert <eggert@cs.ucla.edu>
3999
4000 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4001
9660f5fc
SM
40022012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4003
4004 * lread.c (init_obarray): Declare Qt and Qnil as special.
4005
4374de83
GM
40062012-05-14 Glenn Morris <rgm@gnu.org>
4007
4008 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4009 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4010
dc44c39a
PE
40112012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4012
078c97cb
PE
4013 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4014
dc44c39a
PE
4015 * unexaix.c: Port to more-recent AIX compilers.
4016 (report_error, report_error_1, make_hdr, copy_sym)
4017 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4018 Make arguments const char *, not char *, to avoid violations of C
4019 standard and to fix some AIX warnings reported by Gilles Pion.
4020
e18afed7 40212012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4022
4023 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4024 already have overlays loaded.
4025 (handle_single_display_spec): Before returning without displaying
4026 fringe bitmap, synchronize the bidi iterator with the main display
4027 iterator, by calling iterate_out_of_display_property.
4028 (iterate_out_of_display_property): Detect buffer iteration by
4029 testing that it->string is a Lisp string.
4030 (get_next_display_element): When the current object is exhausted,
4031 and there's something on it->stack, call set_iterator_to_next to
4032 proceed with what's on the stack, instead of returning zero.
4033 (set_iterator_to_next): If called at the end of a Lisp string,
4034 proceed to consider_string_end without incrementing string
4035 position. Don't increment display vector index past the end of
4036 the display vector. (Bug#11417)
c8fb9dc6
EZ
4037 (pos_visible_p): Don't report a position visible when move_it_to
4038 stopped at the last line of window, which happens to be scanned
4039 backwards by the bidi iteration. (Bug#11464)
ac268e67 4040
e18afed7 40412012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4042
4043 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4044 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4045 are on a TTY, and thus unable to display on the fringes.
4046 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4047 so we need to signal to the caller that this is a "replacing"
4048 display spec. This fixes display when the spec is invalid or we
4049 are on a TTY.
4050
e18afed7 40512012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4052
4053 * unexaix.c (make_hdr): Fix typo in prototype.
4054 This bug broke the build on AIX. Problem reported by Gilles Pion.
4055
9d0a235a
MA
40562012-05-14 Michael Albinus <michael.albinus@gmx.de>
4057
4058 * keyboard.c (kbd_buffer_get_event): Read special events also in
4059 batch mode. (Bug#11415)
4060
9e6b06ed
GM
40612012-05-12 Glenn Morris <rgm@gnu.org>
4062
4063 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4064
c1a1d7a3
EZ
40652012-05-12 Eli Zaretskii <eliz@gnu.org>
4066
4067 * lisp.mk (lisp): Add newcomment.elc.
4068
3fe7cdc8
GM
40692012-05-12 Glenn Morris <rgm@gnu.org>
4070
4071 * Makefile.in (MKDIR_P): New, set by configure.
4072 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4073
53f7d2c0
PE
40742012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4075
4076 Remove unused function hourglass_started.
4077 * dispextern.h (hourglass_started):
4078 * w32fns.c (hourglass_started):
4079 * xdisp.c (hourglass_started): Remove.
4080
75aafb17
JB
40812012-05-10 Juanma Barranquero <lekktu@gmail.com>
4082
4083 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4084 Update dependencies.
4085
12959e8e
PE
40862012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4087
97107e2e
PE
4088 * xgselect.c (xg_select): Put maxfds+1 into a var.
4089 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4090
12959e8e
PE
4091 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4092
836d29b3
DA
40932012-05-10 Dave Abrahams <dave@boostpro.com>
4094
4095 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4096 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4097
5cb67954
MA
40982012-05-09 Michael Albinus <michael.albinus@gmx.de>
4099
4100 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4101 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4102 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4103 Initialize xd_registered_buses.
4104
3478ec45
PE
41052012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4106
b263a6b0
PE
4107 Untag more efficiently if USE_LSB_TAG.
4108 This is based on a proposal by YAMAMOTO Mitsuharu in
4109 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4110 For an admittedly artificial (nth 8000 longlist) benchmark on
4111 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4112 Emacs's overall text size by 1%.
4113 * lisp.h (XUNTAG): New macro.
4114 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4115 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4116 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4117 * eval.c (Fautoload):
4118 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4119 * frame.h (XFRAME): Use XUNTAG.
4120
3478ec45
PE
4121 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4122 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4123 Remove unportable assumptions about print widths of types like
4124 dbus_uint32_t.
4125 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4126 intptr_t when converting between pointer and integer, to avoid GCC
4127 warnings about wrong width.
4128
666b903b 41292012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4130
4131 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4132 stack for each reader_thread, instead of defaulting to 8MB
4133 determined by the linker. This avoids failures in creating
4134 subprocesses on Windows 7, see the discussion in this thread:
4135 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4136
b120cc17
JC
41372012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4138
4139 Fix up display of the *Minibuf-0* buffer in the mini window.
4140 * keyboard.c (read_char): Don't clear the echo area if there's no
4141 message to clear.
4142 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4143 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4144
9a4b36f8
MA
41452012-05-07 Michael Albinus <michael.albinus@gmx.de>
4146
4147 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4148 batch mode.
4149
e5f9458f
CY
41502012-05-06 Chong Yidong <cyd@gnu.org>
4151
4152 * lisp.mk (lisp): Update.
4153
eceeb5fc 41542012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4155
4156 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4157
71873e2b
SM
41582012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4159
4160 * data.c (PUT_ERROR): New macro.
4161 (syms_of_data): Use it. Add new error type `user-error'.
4162 * undo.c (user_error): New function.
4163 (Fprimitive_undo): Use it.
4164 * print.c (print_error_message): Adjust print style for `user-error'.
4165 * keyboard.c (user_error): New function.
4166 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4167
ab0fa4e4
PE
41682012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4169
4170 Do not limit current-time-string to years 1000..9999.
4171 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4172 (Fcurrent_time_string): Support any year that is supported by the
4173 underlying localtime representation. Don't use asctime, as it
4174 has undefined behavior for years outside the range -999..9999.
4175
7ed806a7
PE
41762012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4177
4178 Fix race conditions involving setenv, gmtime, localtime, asctime.
4179 Without this fix, interrupts could mess up code that uses these
4180 nonreentrant functions, since setting TZ invalidates existing
4181 tm_zone or tzname values, and since most of these functions return
4182 pointers to static storage.
4183 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4184 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4185 Grow the critical sections to include not just invoking
4186 localtime/gmtime, but also accessing these functions' results
4187 including their tm_zone values if any, and any related TZ setting.
4188 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4189 so that the struct tm is saved in the critical section.
4190 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4191 motivated by the fact that memory allocation needs to be outside
4192 the critical section.
4193
0c16dfed
DA
41942012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4195
4196 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4197 with RESET_INTERVAL.
4198
4199 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4200 Remove duplicated buffer name initialization.
4201
3f83ace8
JM
42022012-05-02 Jim Meyering <jim@meyering.net>
4203
4204 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4205
c7b8541e
JM
4206 * xfns.c (x_window): Use xstrdup (Bug#11375).
4207
90207a15 42082012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4209
4210 * xdisp.c (pos_visible_p): If already at a newline from the
4211 display string before the 'while' loop, don't walk back the glyphs
4212 from it3.glyph_row. Solves assertion violation when the display
4213 string begins with a newline (egg.el). (Bug#11367)
4214
b593d6a9
AH
42152012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4216
4217 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4218 Move to simple.el.
4219
4737362e
GM
42202012-05-01 Glenn Morris <rgm@gnu.org>
4221
99cf43f9
GM
4222 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4223 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4224 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4225 All were removed before 23.1.
4226
9311dcff
GM
4227 * dispnew.c: Remove HAVE_LIBNCURSES test;
4228 it is always true on relevant platforms.
4229
4d5c6349
GM
4230 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4231 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4232
4737362e
GM
4233 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4234
74dd3a6b
AS
42352012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4236
4237 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4238 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4239 Remove.
4240
13c379ee
PE
42412012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4242
4243 Do not avoid creating empty evaporating overlays (Bug#9642).
4244 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4245 That is, do not delete an evaporating overlay if it becomes
4246 empty after its bounds are adjusted to fit within its buffer.
4247 This fix caused other problems, and I'm reverting it until we get
4248 to the bottom of them.
4249
a8e7d6d7 42502012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4251
4252 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4253
a8e7d6d7 42542012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4255
4256 * xdisp.c (pos_visible_p): If the window start position is beyond
4257 ZV, start the display from buffer beginning. Prevents assertion
4258 violation in init_iterator when the minibuffer window is scrolled
4259 via the scroll bar.
4260
4261 * window.c (window_scroll_pixel_based): Likewise.
4262
a8e7d6d7 42632012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4264
4265 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4266
a8e7d6d7 42672012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4268
4269 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4270 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4271
a8e7d6d7 42722012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4273
b593d6a9
AH
4274 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4275 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4276
1c6900d9
EZ
42772012-04-26 Eli Zaretskii <eliz@gnu.org>
4278
4c3fa1d9
EZ
4279 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4280 display element, check also the underlying string or buffer
4281 character. (Bug#11341)
4282
1c6900d9
EZ
4283 * w32menu.c: Include w32heap.h.
4284 (add_menu_item): If the call to AppendMenuW (via
4285 unicode_append_menu) fails, disable Unicode menus only if we are
4286 running on Windows 9X/Me.
4287
42bf8205
AS
42882012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4289
4290 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4291 (xgetint): Add missing shift for LSB tags.
4292
b1bac16e
MR
42932012-04-24 Martin Rudalics <rudalics@gmx.at>
4294
4295 * keyboard.c (read_char): Don't wipe echo area for select window
4296 events: These might get delayed via `mouse-autoselect-window'
4297 (Bug#11304).
4298
d69621cc
JB
42992012-04-24 Juanma Barranquero <lekktu@gmail.com>
4300
4301 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4302 manipulation of :loaded-from data.
4303
02fd101b
JB
43042012-04-23 Juanma Barranquero <lekktu@gmail.com>
4305
4306 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4307 now a cons (bug#11311).
4308
888bec30
PE
43092012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4310
89a438bd
PE
4311 Do not create empty overlays with the evaporate property (Bug#9642).
4312 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4313 if it becomes empty after its bounds are adjusted to fit within
4314 its buffer. Without this fix, in a nonempty buffer (let ((o
4315 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4316 yields an empty overlay that has the evaporate property, which is
4317 not supposed to happen.
4318
1068fe4d
PE
4319 Fix minor GTK3 problems found by static checking.
4320 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4321 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4322 (struct _EmacsFixedClass, emacs_fixed_get_type):
4323 Move decls here from emacsgtkfixed.h, since they needn't be public.
4324 (emacs_fixed_get_type): Now static.
4325 (emacs_fixed_class_init): Omit unused local.
4326 (emacs_fixed_child_type): Remove; unused.
4327 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4328 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4329 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4330 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4331 (EMACS_FIXED_GET_CLASS): Remove; unused.
4332 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4333
888bec30
PE
4334 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4335 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4336
de85e130
PE
43372012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4338
d0baac98 4339 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4340 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4341 (__malloc_size_t, __malloc_ptrdiff_t):
4342 Remove. All uses removed, replaced by the definiens if needed,
4343 since we can assume C89 or better now.
4344 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4345 (protect_malloc_state, align, get_contiguous_space)
4346 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4347 (malloc_atfork_handler_child, malloc_enable_thread)
4348 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4349 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4350 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4351 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4352 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4353 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4354 Define using prototypes, not old style.
4355 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4356 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4357 (align): Don't assume that signed integer overflow wraps around.
4358 Omit unused local var.
4359 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4360 (_free_internal_nolock, memalign, mallochook, reallochook):
4361 Omit no-longer-needed casts.
4362 (valloc): Use getpagesize, not __getpagesize.
4363 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4364 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4365
de85e130
PE
4366 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4367
dcbf5805
MA
43682012-04-22 Michael Albinus <michael.albinus@gmx.de>
4369
4370 Move functions from C to Lisp. Make non-blocking method calls
4371 the default. Implement further D-Bus standard interfaces.
4372
4373 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4374 (QCdbus_request_name_allow_replacement)
4375 (QCdbus_request_name_replace_existing)
4376 (QCdbus_request_name_do_not_queue)
4377 (QCdbus_request_name_reply_primary_owner)
4378 (QCdbus_request_name_reply_in_queue)
4379 (QCdbus_request_name_reply_exists)
4380 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4381 (QCdbus_registered_serial, QCdbus_registered_method)
4382 (QCdbus_registered_signal): New Lisp objects.
4383 (XD_DEBUG_MESSAGE): Use sizeof.
4384 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4385 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4386 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4387 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4388 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4389 (xd_signature, xd_append_arg): Allow float for integer types.
4390 (xd_get_connection_references): New function.
b593d6a9
AH
4391 (xd_get_connection_address): Rename from xd_initialize.
4392 Return cached address.
dcbf5805
MA
4393 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4394 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4395 level.
4396 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4397 Return number of refcounts.
dcbf5805
MA
4398 (Fdbus_get_unique_name): Make stronger parameter check.
4399 (Fdbus_message_internal): New defun.
4400 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4401 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4402 (Fdbus_send_signal, Fdbus_register_service)
4403 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4404 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4405 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4406 (Vdbus_compiled_version, Vdbus_runtime_version)
4407 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4408 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4409 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4410 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4411 Adapt docstring.
dcbf5805 4412
52828e02
PE
44132012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4414
da05bc4c
PE
4415 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4416 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4417 Do not assume ptrdiff_t is the same width as 'int'.
4418
52828e02
PE
4419 * alloc.c: Handle unusual debugging option combinations.
4420 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4421 since the two debugging options are incompatible.
4422 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4423 is defined.
4424 (mem_init, mem_insert, mem_insert_fixup):
4425 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4426 (NEED_MEM_INSERT): Remove; no longer needed.
4427
f01769f9
LL
44282012-04-22 Leo Liu <sdl.web@gmail.com>
4429
4430 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4431
5790543d
PE
44322012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4433
4434 * sysdep.c [__FreeBSD__]: Minor cleanups.
4435 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4436 Use Emacs indenting style more consistently. Avoid some casts.
4437 Use 'double' consistently rather than mixing 'float' and 'double'.
4438
b91b7e4d
EW
44392012-04-21 Eduard Wiebe <usenet@pusto.de>
4440
b593d6a9
AH
4441 * sysdep.c (list_system_processes, system_process_attributes):
4442 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4443
6114eb15
AS
44442012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4445
4446 * lisp.mk (lisp): Update.
4447
2f38dff7
PE
44482012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4449
4450 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4451 It is never used otherwise.
4452
4ae29f89
SM
44532012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4454
4455 * print.c (print_preprocess): Only check print_depth if print-circle
4456 is nil.
4457 (print_object): Check for cycles even when print-circle is nil and
4458 print-gensym is t, but only check print_depth if print-circle is nil.
4459
f30d612a
CY
44602012-04-20 Chong Yidong <cyd@gnu.org>
4461
4462 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4463 set the status to "failed" and ensure that sentinel is run.
4464
c07a4c0b 44652012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4466
4467 * process.c (Fset_process_inherit_coding_system_flag)
4468 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4469 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4470
c07a4c0b 44712012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4472
4473 * xdisp.c (string_buffer_position_lim): Limit starting position to
4474 BEGV.
4475 (set_cursor_from_row): If called for a mode-line or header-line
4476 row, return zero immediately.
4477 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4478 farther than the first row after the header line, if any.
4479 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4480 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4481
c07a4c0b 44822012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4483
4ae29f89
SM
4484 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4485 (bug#11238).
ad3a2b41 4486
c07a4c0b 44872012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 44882012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4489
4490 configure: new option --enable-gcc-warnings (Bug#11207)
4491 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4492 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4493 (ALL_CFLAGS): Use new macros rather than old.
4494 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4495 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4496 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4497 -Wunused-result, -Wunused-variable. This should go away once
4498 the Emacs and Gnulib regex code is merged.
4499 (xmalloc, xrealloc): Now static.
4500
aba027e8
PE
45012012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4502
4503 * dired.c (Fsystem_groups): Remove unused local.
4504
e5a36063
GM
45052012-04-17 Glenn Morris <rgm@gnu.org>
4506
4507 * dired.c (Fsystem_users): Doc fix.
4508
316411f0
DA
45092012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4510
4511 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4512 (syms_of_dired): Add them.
4513
9426aba4
PE
45142012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4515
b62a57be
PE
4516 Fix minor alloc.c problems found by static checking.
4517 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4518 New extern decls, to avoid calling undeclared functions.
4519 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4520 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4521 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4522 (NEED_MEM_INSERT): New macro.
4523 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4524 Remove one incorrect comment and fix another.
b62a57be 4525
3539f31f
PE
4526 Fix minor ralloc.c problems found by static checking.
4527 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4528 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4529 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4530 (r_alloc_sbrk): Now static.
4531
a041960a
PE
4532 Improve ralloc.c interface checking.
4533 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4534 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4535 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4536 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4537 [REL_ALLOC]: ... to here, to check interface.
4538 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4539 Remove decls. This fixes an "It stinks!".
4540
9426aba4
PE
4541 * alloc.c (which_symbols): Fix alignment issue / type clash.
4542
d55c12ed
AS
45432012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4544
4545 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4546 (struct Lisp_Misc_Any): Likewise.
4547 (struct Lisp_Free): Likewise.
4548 * alloc.c (union aligned_Lisp_Symbol): Define.
4549 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4550 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4551 (union aligned_Lisp_Misc): Define.
4552 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4553 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4554 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4555
b948ce8b
PE
45562012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4557
4558 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4559 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4560 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4561 * s/netbsd.h, s/sol2-6.h:
4562 Remove definition of GC_MARK_STACK, since the default now works.
4563 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4564 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4565 no longer the default.
4566 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4567
35dc09a1 45682012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4569
35dc09a1
GM
4570 * lread.c (lisp_file_lexically_bound_p):
4571 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4572
35dc09a1
GM
45732012-04-14 Eli Zaretskii <eliz@gnu.org>
4574
4575 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4576 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4577
45782012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4579
4580 * nsterm.m (constrainFrameRect): Always constrain when there is only
4581 one screen (Bug#10962).
4582
bcd86815
KB
45832012-04-13 Ken Brown <kbrown@cornell.edu>
4584
4585 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4586
c25df26e
RT
45872012-04-13 Reuben Thomas <rrt@sc3d.org>
4588
4589 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4590
0fc59f1e
DC
45912012-04-11 Daniel Colascione <dancol@dancol.org>
4592
4593 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4594 against is gone. It's better to use vfork now so that when Cygwin
4595 gains a new, working vfork, we use it automatically (bug#10398).
4596
de8c03dc
SM
45972012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4598
4599 * window.c (save_window_save): Obey window-point-insertion-type.
4600
2f097256
GM
46012012-04-11 Glenn Morris <rgm@gnu.org>
4602
4603 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4604
453b951e
SM
46052012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4606
4607 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4608
75f1671a 46092012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4610
4611 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4612 (force_quit_count): New var.
4613 (handle_interrupt): Use it.
4614
2a8ce227
JB
46152012-04-10 Juanma Barranquero <lekktu@gmail.com>
4616
4617 * w32.c (w32_delayed_load): Record the full path of the library
4618 being loaded (bug#10424).
4619
935396c0
GM
46202012-04-09 Glenn Morris <rgm@gnu.org>
4621
05920a43
GM
4622 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4623 not just in the obarray, before snarfing them. (Bug#11036)
4624
935396c0
GM
4625 * Makefile.in ($(leimdir)/leim-list.el):
4626 Pass EMACS rather than BUILT_EMACS.
4627
a18ecafa
TZ
46282012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4629
4630 * process.c (make_process):
4631 * process.h: Add integer `gnutls_handshakes_tried' member to
4632 process struct.
4633
6bbef4e5
JC
4634 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4635 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4636
4637 * gnutls.c (gnutls_log_function2i): Convenience log function.
4638 (emacs_gnutls_read): Use new log functions,
4639 `gnutls_handshakes_tried' process member, and
4640 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4641 attempts per process (connection).
4642
b4d3bc10
CY
46432012-04-09 Chong Yidong <cyd@gnu.org>
4644
4645 * eval.c (Fuser_variable_p, user_variable_p_eh)
4646 (lisp_indirect_variable): Functions deleted.
4647 (Fdefvar): Caller changed.
4648
4649 * callint.c (Finteractive, Fcall_interactively):
4650 * minibuf.c (Fread_variable): Callers changed.
4651
70f4d973
EZ
46522012-04-09 Eli Zaretskii <eliz@gnu.org>
4653
4654 * xdisp.c (set_cursor_from_row): If the display string appears in
4655 the buffer at position that is closer to point than the position
4656 after the display string, display the cursor on the first glyph of
4657 the display string. Fixes cursor display when a 'display' text
4658 property immediately follows invisible text. (Bug#11094)
4659
cb3c2e3e
PE
46602012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4661
4662 composite.c: use 'double' consistently
4663 * composite.c (get_composition_id): Use 'double' consistently
4664 instead of converting 'float' to 'double' and vice versa; this is
4665 easier to understand and avoids a GCC warning.
4666
fd06db5d
GM
46672012-04-09 Glenn Morris <rgm@gnu.org>
4668
50fe702a
GM
4669 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4670 preparation for dumping it with emacs. (Bug#4789)
4671 (leimdir): New variable.
4672 ($(leimdir)/leim-list.el): New rule.
4673 (emacs$(EXEEXT)): Depend on leim-list.el.
4674
fd06db5d
GM
4675 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4676 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4677 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4678
55c131ee
AS
46792012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4680
4681 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4682 proper alignment.
4683
9209588f
JB
46842012-04-07 Juanma Barranquero <lekktu@gmail.com>
4685
4686 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4687 Remove unused local variable.
4688
e3fb2efb
PE
46892012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4690
4691 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4692 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4693 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4694 objects, as mark_maybe_pointer will catch them otherwise.
4695 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4696 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4697
b5385551
PE
46982012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4699
4700 Fix typo that broke non-Windows builds.
4701 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4702
9078ead6
EZ
47032012-04-07 Eli Zaretskii <eliz@gnu.org>
4704
4705 Support building on MS-Windows with libxml2.
4706
4707 * makefile.w32-in (OBJ2): Add xml.$(O).
4708 (GLOBAL_SOURCES): Add xml.c.
4709 ($(BLD)/xml.$(O)): New dependency list.
4710
4711 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4712 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4713 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4714 [!WINDOWSNT]: New macros.
4715 (init_libxml2_functions, libxml2_loaded_p): New functions.
4716 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4717 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4718 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4719 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4720 linked in).
6bbef4e5
JC
4721 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4722 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4723 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4724
4725 * emacs.c: Don't include libxml/parser.h.
4726 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4727 xmlCleanupParser directly.
4728
4729 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4730
3811fdf3
EZ
47312012-04-07 Eli Zaretskii <eliz@gnu.org>
4732
4733 * indent.c (Fvertical_motion): If there is a display string at
4734 point, use it.vpos to compute how many lines to backtrack after
4735 move_it_to point. (Bug#11133)
4736
2f8e16b2
EZ
47372012-04-06 Eli Zaretskii <eliz@gnu.org>
4738
4739 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4740 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4741 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4742 macros related to unification of CJK characters. For the details,
4743 see the discussion following the message here:
4744 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4745
3d439cd1
CY
47462012-04-04 Chong Yidong <cyd@gnu.org>
4747
4748 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4749
8bc53d00
EZ
47502012-04-01 Eli Zaretskii <eliz@gnu.org>
4751
4752 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4753 instead of alloca. (Bug#11138)
4754
3b0512a3
AS
47552012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4756
4757 * w32menu.c (is_simple_dialog): Properly check lisp types.
4758 (Bug#11141)
4759
8427ddd2
EZ
47602012-03-31 Eli Zaretskii <eliz@gnu.org>
4761
979022ef
EZ
4762 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4763 position we get to after a call to move_it_to fails the
4764 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4765 only if we wind up in a string from display property. (Bug#11063)
4766
a6b1c7cc
EZ
4767 * window.c (Fdelete_other_windows_internal): Invalidate the row
4768 and column information about mouse highlight, so that redisplay
4769 restores it after reallocating the glyph matrices. (Bug#7464)
4770
8427ddd2
EZ
4771 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4772 string comes from a `display' text property, use the buffer
4773 position of that property as if we actually saw that position in
4774 the row's glyphs.
697ba24b
EZ
4775 (move_it_by_lines): Remove the assertion that
4776 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4777 violated when there's a before-string at the beginning of a line.
4778 (Bug#11063)
8427ddd2 4779
65a0a738
EZ
47802012-03-30 Eli Zaretskii <eliz@gnu.org>
4781
4782 * xdisp.c (append_space_for_newline): If the default face was
4783 remapped, use the remapped face for the appended newline.
4784 (extend_face_to_end_of_line): Use the remapped default face for
4785 extending the face to the end of the line.
4786 (display_line): Call extend_face_to_end_of_line when the default
4787 face was remapped. (Bug#11068)
4788
581355cc
EZ
47892012-03-29 Eli Zaretskii <eliz@gnu.org>
4790
4791 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4792
e8fc049f
SM
47932012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4794
4795 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4796
4fb9a543
GM
47972012-03-27 Glenn Morris <rgm@gnu.org>
4798
4799 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4800 Doc fixes.
4801
679910f1
KH
48022012-03-26 Kenichi Handa <handa@m17n.org>
4803
4804 * dispextern.h (struct glyph): Fix previous change. Change the
4805 bit length of glyphless.ch to 25 (Bug#11082).
4806
90d49b7f
CY
48072012-03-26 Chong Yidong <cyd@gnu.org>
4808
4809 * keyboard.c (Vselection_inhibit_update_commands): New variable.
4810 (command_loop_1): Use it; inhibit selection update for
4811 handle-select-window too (Bug#8996).
4812
f514f6f0
FP
48132012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
4814
e8fc049f 4815 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 4816
bf43fa51
KH
48172012-03-25 Kenichi Handa <handa@m17n.org>
4818
4819 * dispextern.h (struct glyph): Change the bit length of
4820 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
4821
8a0c01dd
EZ
48222012-03-24 Eli Zaretskii <eliz@gnu.org>
4823
4824 * s/ms-w32.h (tzname): Include time.h before redirecting to
4825 _tzname. Fixes the MSVC build. (Bug#9960)
4826
7d1c3a76
AS
48272012-03-24 Andreas Schwab <schwab@linux-m68k.org>
4828
8ed79523
AS
4829 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
4830 characters.
4831
7d1c3a76
AS
4832 * xterm.c (XTread_socket): Only modify handling_signal if
4833 !SYNC_INPUT. (Bug#11080)
4834
e99a9b8b
EZ
48352012-03-23 Eli Zaretskii <eliz@gnu.org>
4836
4837 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
4838 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
4839 when fetching a multibyte character consumes more bytes than
4840 CHAR_BYTES returns, due to unification of CJK characters in
4841 string_char. (Bug#11073)
4842
5063c0e1
TN
48432012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
4844
4845 * process.c (wait_reading_process_output): Handle pty disconnect
4846 by refraining from sending oneself a SIGCHLD (bug#10933).
4847
9f851fbd
CY
48482012-03-22 Chong Yidong <cyd@gnu.org>
4849
4850 * dispextern.h (struct it): New member string_from_prefix_prop_p.
4851
5063c0e1 4852 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
4853 Mark string as coming from a prefix property.
4854 (handle_face_prop): Use default face for prefix strings (Bug#4281).
4855 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
4856
fb5b8aca
CY
48572012-03-21 Chong Yidong <cyd@gnu.org>
4858
4859 * xfaces.c (Vface_remapping_alist): Doc fix.
4860
62356a1b
EZ
48612012-03-20 Eli Zaretskii <eliz@gnu.org>
4862
4863 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
4864 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
4865 Doc fixes.
62356a1b 4866
025de85b
CY
48672012-03-20 Chong Yidong <cyd@gnu.org>
4868
4869 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
4870 to reflect default non-nil value of redisplay-dont-pause.
4871
4827f94e
KH
48722012-03-19 Kenichi Handa <handa@m17n.org>
4873
4874 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
4875 it fit in a valid range (Bug#11003).
4876
e50a24a2
EZ
48772012-03-18 Eli Zaretskii <eliz@gnu.org>
4878
4879 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
4880 that is not from display property, accept the row as a "cursor
4881 row" if one of the string's character has a non-nil `cursor'
4882 property. Fixes cursor positioning when there are newlines in
4883 overlay strings, e.g. in icomplete.el. (Bug#11035)
4884
9af5ed87
PE
48852012-03-12 Paul Eggert <eggert@cs.ucla.edu>
4886
4887 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
4888
d1f55f16
CY
48892012-03-12 Chong Yidong <cyd@gnu.org>
4890
4891 * eval.c (inhibit_lisp_code): Rename from
4892 inhibit_window_configuration_change_hook; move from window.c.
4893
4894 * xfns.c (unwind_create_frame_1, Fx_create_frame):
4895 * window.c (run_window_configuration_change_hook)
4896 (syms_of_window): Callers changed.
4897
66c5eebd
CY
48982012-03-11 Chong Yidong <cyd@gnu.org>
4899
413df973
CY
4900 * keymap.c (Fkey_description): Doc fix (Bug#9700).
4901
66c5eebd
CY
4902 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
4903
1de11f56
CY
49042012-03-10 Chong Yidong <cyd@gnu.org>
4905
4906 * frame.c (other_visible_frames): Don't assume the selected frame
4907 is visible (Bug#10955).
4908
cae07000
SM
49092012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
4910
4911 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
4912
89c94350
JD
49132012-03-08 Jan Djärv <jan.h.d@swipnet.se>
4914
4915 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
4916 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
4917 zero (Bug#10954).
4918
999dd333
GM
49192012-03-03 Glenn Morris <rgm@gnu.org>
4920
01a6dcc8 4921 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 4922
de0100f2
EZ
49232012-03-02 Eli Zaretskii <eliz@gnu.org>
4924
4925 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
4926 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
4927 (redisplay_window, next_element_from_string): Fix typos in
4928 comments.
3e441275
EZ
4929 (redisplay_window): Pass to move_it_vertically the margin in
4930 pixels, not in screen lines.
de0100f2 4931
96a72ee9
GM
49322012-03-02 Glenn Morris <rgm@gnu.org>
4933
4934 * buffer.c (buffer-list-update-hook): Doc fix.
4935
312508d7
EZ
49362012-02-29 Eli Zaretskii <eliz@gnu.org>
4937
4938 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
4939 push_it before setting up the iterator for the first overlay
4940 string, even if we have an empty string loaded.
4941 (next_overlay_string): If there's an empty string on the iterator
4942 stack, pop the stack. (Bug#10903)
4943
27f3c637
PE
49442012-02-25 Paul Eggert <eggert@cs.ucla.edu>
4945
4946 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
4947 Suggested by Stefan Monnier in
4948 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
4949 * alloc.c (widen_to_Lisp_Object): New static function.
4950 (mark_memory): Also mark Lisp_Objects by fetching pointer words
4951 and widening them to Lisp_Objects. This would work even if
4952 USE_LSB_TAG is defined and wide integers are used, which might
4953 happen in a future version of Emacs.
4954
3c9dfce6
CY
49552012-02-25 Chong Yidong <cyd@gnu.org>
4956
fa74b241
CY
4957 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
4958 Doc fix.
4959
3c9dfce6
CY
4960 * xselect.c (Fx_selection_exists_p): Doc fix.
4961 (x_clipboard_manager_save_all): Print an informative message
4962 before saving to clipboard manager.
4963
9486df08
CY
49642012-02-24 Chong Yidong <cyd@gnu.org>
4965
4966 * keyboard.c (process_special_events): Handle all X selection
4967 requests in kbd_buffer, not just the next one (Bug#8869).
4968
f01d3321
CY
49692012-02-23 Chong Yidong <cyd@gnu.org>
4970
4971 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
4972 call when setting menu-bar-lines and tool-bar-lines parameters.
4973 (unwind_create_frame_1): New helper function.
4974
4975 * window.c (inhibit_window_configuration_change_hook): New var.
4976 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 4977 (syms_of_window): Initialize it.
f01d3321 4978
86b847b6
CY
49792012-02-22 Chong Yidong <cyd@gnu.org>
4980
4981 * xterm.c (x_draw_image_relief): Add missing type check for
4982 Vtool_bar_button_margin (Bug#10743).
4983
a59225b1
CY
49842012-02-21 Chong Yidong <cyd@gnu.org>
4985
4986 * fileio.c (Vfile_name_handler_alist): Doc fix.
4987
4988 * buffer.c (Fget_file_buffer): Protect against invalid file
4989 handler return value.
4990
310f5bd4
PE
49912012-02-20 Paul Eggert <eggert@cs.ucla.edu>
4992
cb3a28cc
PE
4993 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
4994 when computing $valmask.
4995
310f5bd4
PE
4996 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
4997 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
4998 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
4999 It's useless in that case, and it can cause problems on hosts
5000 that allocate halves of EMACS_INT values separately.
5001 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5002 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5003 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5004 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5005 it avoids undefined behavior on hosts where shifting right by more
5006 than the word width has undefined behavior.
5007
2375c96a
CY
50082012-02-19 Chong Yidong <cyd@gnu.org>
5009
5010 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5011 (Funhandled_file_name_directory, Ffile_name_as_directory)
5012 (Fdirectory_file_name, Fexpand_file_name)
5013 (Fsubstitute_in_file_name): Protect against invalid file handler
5014 return values (Bug#10845).
5015
3eb49e71
EZ
50162012-02-18 Eli Zaretskii <eliz@gnu.org>
5017
5018 * .gdbinit (pitx): Fix incorrect references to fields of the
5019 iterator stack.
5020
7b926f3f
CY
50212012-02-17 Chong Yidong <cyd@gnu.org>
5022
5023 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5024
11273115
PE
50252012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5026
5027 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5028 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5029
c3a70e2b
CY
50302012-02-15 Chong Yidong <cyd@gnu.org>
5031
5032 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5033 marked as special. Also, starting docstrings with * is obsolete.
5034
0ca43699
AS
50352012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5036
5037 * gnutls.c (emacs_gnutls_write): Fix last change.
5038
2e8f3c56
LI
50392012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5040
5041 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5042 send_process.
5043
af70074f
SM
50442012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5045
5046 * keymap.c (Fsingle_key_description): Handle char ranges.
5047
95986d52
CY
50482012-02-12 Chong Yidong <cyd@gnu.org>
5049
afd83bd1
CY
5050 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5051 as that creates a dangerous corner case.
5052
95986d52
CY
5053 * window.c (Fdelete_window_internal): Invalidate the mouse
5054 highlight (Bug#9904).
5055
bd7da63e
GM
50562012-02-12 Glenn Morris <rgm@gnu.org>
5057
5058 * xselect.c (Fx_own_selection_internal)
5059 (Fx_get_selection_internal, Fx_disown_selection_internal)
5060 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5061 * nsselect.m (Fx_own_selection_internal)
5062 (Fx_disown_selection_internal, Fx_selection_exists_p)
5063 (Fx_selection_owner_p, Fx_get_selection_internal):
5064 Sync docs and argument specs with the xselect.c versions.
5065
77abcbc2
LI
50662012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5067
5068 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5069
90b671e2
EZ
50702012-02-11 Eli Zaretskii <eliz@gnu.org>
5071
1c0ca0b7
EZ
5072 * w32select.c (Fx_selection_exists_p): Sync doc string and
5073 argument list with xselect.c. (Bug#10783)
5074
5075 * w16select.c (Fx_selection_exists_p): Sync doc string and
5076 argument list with xselect.c. (Bug#10783)
90b671e2 5077
49241268
GM
50782012-02-10 Glenn Morris <rgm@gnu.org>
5079
5080 * fns.c (Fsecure_hash): Doc fix.
5081
f998bbe7 50822012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5083
5084 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5085
0992bd9c
CY
50862012-02-07 Chong Yidong <cyd@gnu.org>
5087
5088 * buffer.c (Fbuffer_local_variables)
5089 (buffer_lisp_local_variables): Handle unbound vars correctly;
5090 don't let Qunbound leak into Lisp.
5091
af008560
GM
50922012-02-07 Glenn Morris <rgm@gnu.org>
5093
dd605cc4
GM
5094 * image.c (Fimagemagick_types): Doc fix.
5095
af008560
GM
5096 * image.c (imagemagick-render-type): Change it from a lisp object
5097 to an integer. Move the doc here from the lisp manual.
5098 Treat all values not equal to 0 the same.
5099
1449fa1d
CY
51002012-02-06 Chong Yidong <cyd@gnu.org>
5101
5102 * doc.c (store_function_docstring): Avoid applying docstring of
5103 alias to base function (Bug#2603).
5104
3723ec07
AS
51052012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5106
5107 * .gdbinit (pp1, pv1): Remove redundant defines.
5108 (pr): Use pp.
5109
79c1cc1e
CY
51102012-02-04 Chong Yidong <cyd@gnu.org>
5111
5112 * nsterm.m: Declare a global (Bug#10694).
5113
d7f29f8e
EZ
51142012-02-04 Eli Zaretskii <eliz@gnu.org>
5115
cae07000
SM
5116 * w32.c (get_emacs_configuration_options):
5117 Include --enable-checking, if specified, in the return value.
d7f29f8e 5118
3b95a6f9
MR
51192012-02-04 Martin Rudalics <rudalics@gmx.at>
5120
5121 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5122 after rounding frame sizes. (Bug#9723)
5123
d6fa96a6
EZ
51242012-02-04 Eli Zaretskii <eliz@gnu.org>
5125
5126 * keyboard.c (adjust_point_for_property): Don't position point
5127 before BEGV. (Bug#10696)
5128
df0b2940
PE
51292012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5130
5131 Handle overflow when computing char display width (Bug#9496).
5132 * character.c (char_width): Return EMACS_INT, not int.
5133 (char_width, c_string_width): Check for overflow when
5134 computing the width; this is possible now that individual
5135 characters can have unbounded width. Problem introduced
5136 by merge from Emacs 23 on 2012-01-19.
5137
6bee44d6
MA
51382012-02-02 Michael Albinus <michael.albinus@gmx.de>
5139
5140 * dbusbind.c (Fdbus_register_method): Mention the return value
5141 :ignore in the docstring.
5142
44f92739
GM
51432012-02-02 Glenn Morris <rgm@gnu.org>
5144
1b9f60cc
GM
5145 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5146
44f92739
GM
5147 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5148 Unconditionally set to t. (Bug#10673)
5149 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5150 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5151 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5152
c5d3843c
KH
51532012-02-02 Kenichi Handa <handa@m17n.org>
5154
5155 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5156 0, do not call append_composite_glyph.
5157
159462d4 51582012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5159
5160 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5161 NULL (Bug#6988).
5162 (x_produce_glyphs): If the component of a composition is a null
5163 string, set it->pixel_width to 1 to avoid zero-width glyph.
5164
78cef877
EZ
51652012-02-01 Eli Zaretskii <eliz@gnu.org>
5166
5167 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5168 first 2 arguments are identical. This makes inserting large
5169 output from a subprocess an order of magnitude faster on
5170 MS-Windows, where all sbrk'ed memory is always contiguous.
5171
97897668
GM
51722012-01-31 Glenn Morris <rgm@gnu.org>
5173
5174 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5175 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5176 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5177
31fd3586
GM
51782012-01-29 Glenn Morris <rgm@gnu.org>
5179
5180 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5181
0e24a8b2
CY
51822012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5183
5184 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5185
cc0adcb0
CY
51862012-01-28 Chong Yidong <cyd@gnu.org>
5187
5188 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5189
acc28cb9
CY
51902012-01-26 Chong Yidong <cyd@gnu.org>
5191
9c69cfb7
CY
5192 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5193
acc28cb9
CY
5194 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5195 repeat counts (Bug#10507).
5196
48da7392
GM
51972012-01-26 Glenn Morris <rgm@gnu.org>
5198
5199 * lread.c (syms_of_lread): Doc fix.
5200
14af5f7f
CY
52012012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5202
5203 * coding.c (encode_designation_at_bol): Change return value to
5204 EMACS_INT.
5205
0b21c100
CY
52062012-01-25 Chong Yidong <cyd@gnu.org>
5207
5208 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5209
3c2907f7
CY
52102012-01-21 Chong Yidong <cyd@gnu.org>
5211
5212 * floatfns.c (Fcopysign): Make the second argument non-optional,
5213 since nil is not allowed anyway.
5214
959ad23f
AS
52152012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5216
5217 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5218 (send_process): Likewise.
5219
34a02f46
MR
52202012-01-19 Martin Rudalics <rudalics@gmx.at>
5221
5222 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5223 (Vwindow_persistent_parameters): Do not use Qstate.
5224 Rewrite doc-strings.
34a02f46 5225
1259009a 52262012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5227
5228 * character.c (char_width): New function.
70d4fdf6
GM
5229 (Fchar_width, c_string_width, lisp_string_width):
5230 Use char_width (Bug#9496).
25ed9e61 5231
6a6ee00d
MR
52322012-01-16 Martin Rudalics <rudalics@gmx.at>
5233
5234 * window.c (Vwindow_persistent_parameters): New variable.
5235 (Fset_window_configuration, save_window_save): Handle persistent
5236 window parameters.
5237
c85efaf7
EZ
52382012-01-14 Eli Zaretskii <eliz@gnu.org>
5239
5240 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5241 thrashing the stack of the thread. (Bug#9087)
5242
5944709e
PE
52432012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5244
5245 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5246
e71f5d99
EZ
52472012-01-11 Eli Zaretskii <eliz@gnu.org>
5248
5249 * xdisp.c (rows_from_pos_range): Handle the case where the
5250 highlight ends on a newline. (Bug#10464)
5251 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5252 he end column for display of highlight that ends on a newline
5253 before a R2L line.
5254
ce316182
GM
52552012-01-11 Glenn Morris <rgm@gnu.org>
5256
5257 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5258 from load-path also when installation-directory is nil. (Bug#10208)
5259
5b43da69
GM
52602012-01-10 Glenn Morris <rgm@gnu.org>
5261
74cc8ff9
GM
5262 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5263
7d8d6e4e
GM
5264 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5265 Update template values to be closer to their typical values these days.
5b43da69 5266
a0db8d43
EZ
52672012-01-09 Eli Zaretskii <eliz@gnu.org>
5268
5269 * xdisp.c (rows_from_pos_range): Accept additional argument
5270 DISP_STRING, and accept any glyph in a row whose object is that
5271 string as eligible for mouse highlight. Fixes mouse highlight of
5272 display strings from overlays. (Bug#10464)
5273
9a0115ab 52742012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5275
b9110d6a 5276 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5277 * fileio.c (auto_saving_dir_umask): New static var.
5278 (Fmake_directory_internal): Use it.
5279 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5280 creating the directory. The old code temporarily assigns
5281 too-generous permissions to the directory.
5282 (do_auto_save_eh): Clear it.
b9110d6a 5283 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5284 that the var is always cleared.
5285
6c1bd3f3
EZ
52862012-01-07 Eli Zaretskii <eliz@gnu.org>
5287
5288 * search.c (scan_buffer): Pass character positions to
5289 know_region_cache, not byte positions. (Bug#6540)
5290
069d2b50
L
52912012-01-07 LynX <_LynX@bk.ru> (tiny change)
5292
5293 * w32.c (sys_rename): Report EXDEV when rename of a directory
5294 fails because the target is on another logical disk. (Bug#10284)
5295
75bf0d33
DB
52962012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5297
5298 * xterm.c (x_embed_request_focus): New function.
5299
5300 * xterm.h: Add prototype.
5301
5302 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5303
1c6e5a32
GM
53042012-01-05 Glenn Morris <rgm@gnu.org>
5305
5306 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5307
651e947e
EZ
53082012-01-01 Eli Zaretskii <eliz@gnu.org>
5309
5310 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5311 Load gnutls_transport_set_lowat only if GnuTLS version is below
5312 2.11.1.
5313 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5314 GnuTLS versions below 2.11.1.
5315
3778cdd8
AL
53162011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5317
5318 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5319 to the doc string advising against its use for altering the way
5320 windows are scrolled.
5321
0e5317f7
KH
53222011-12-28 Kenichi Handa <handa@m17n.org>
5323
5324 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5325 coding-system ASCII compatible only when it does not produce BOM
5326 on encoding (Bug#10383).
5327
93d5ca1f
JD
53282011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5329
5330 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5331 can scroll.
5332 (create_and_show_popup_menu): Always use menu_position_func for
5333 Gtk3 (Bug#10361).
5334
ca22b785
AS
53352011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5336
5337 * callint.c (Fcall_interactively): Don't truncate prompt string.
5338
d048e1e6
EZ
53392011-12-23 Eli Zaretskii <eliz@gnu.org>
5340
5341 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5342 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5343 resumed from there (after widening). (Bug#10360)
d048e1e6 5344
5ccaba1f
JD
53452011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5346
5347 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5348
204ee57f
JD
53492011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5350
b81d40f0
JB
5351 * nsterm.m (x_free_frame_resources):
5352 Release f->output_data.ns->miniimage.
204ee57f
JD
5353 (ns_index_color): Fix indentation. Do not retain
5354 color_table->colors[i].
5355
5356 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5357 before returning.
5358
5359 * nsfns.m (x_set_background_color): Assign return value from
5360 ns_index_color to face-background instead of NSColor*.
5361 (ns_implicitly_set_icon_type): Fix indentation.
5362 Change assignment in for loop to comparison.
5363
5364 * emacs.c (ns_pool): New variable.
5365 (main): Assign ns_pool.
5366 (Fkill_emacs): Call ns_release_autorelease_pool.
5367
5368 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5369 autorelease fdesc, release fdAttrs and tdict.
5370 (ns_get_covering_families): Release charset.
5371 (ns_findfonts): Release NSFontDescriptor created with new.
5372 (ns_uni_to_glyphs): Fix indentation.
5373 (setString): Release attrStr before assigning new value.
5374
c803b2b7
JD
53752011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5376
678f4426
JD
5377 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5378 and NS_IMPL_COCOA.
5379 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5380 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5381
cd394be1 53822011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5383
5fecd5fc
JD
5384 * nsterm.m (ns_term_init): Subscribe for notifications
5385 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5386 to method trackingNotification in EmacsMenu.
5387
5388 * nsmenu.m (trackingMenu): New variable.
3771cb17 5389 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5390 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5391 from Aquamacs (Bug#7030).
678f4426
JD
5392
53932011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5394
c803b2b7
JD
5395 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5396 (symbol_to_nsstring): Fix indentation.
5397 (ns_symbol_to_pb): New function.
cae07000
SM
5398 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5399 (Fns_rotate_cut_buffers_internal): Remove.
5400 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5401 Fns_store_cut_buffer_internal.
5402 (ns_get_foreign_selection, Fx_own_selection_internal)
5403 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5404 (Fns_get_selection_internal, Fns_store_selection_internal):
5405 Use ns_symbol_to_pb and check if return value is nil.
5406 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5407 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5408 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5409 renamed to Sns_store_selection_internal.
5410 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5411 and remove this function.
5412 (ns_handle_selection_clear): Remove, never used.
5413 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5414 here.
5415
e1b01a3a
KB
54162011-12-17 Ken Brown <kbrown@cornell.edu>
5417
5418 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5419 GID is unknown (Bug#10257).
5420
2adb6e85
PE
54212011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5422
5423 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5424 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5425 which caused a build failure on GNU/Linux IA-64. This problem was
5426 introduced by my 2011-10-07 patch.
5427
d1d7b339
JL
54282011-12-15 Juri Linkov <juri@jurta.org>
5429
5430 * image.c (imagemagick_error): New function. (Bug#10112)
5431 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5432 Use `imagemagick_error' where ImageMagick functions return
5433 `MagickFalse'.
5434 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5435 proper order.
5436
100d5755
KH
54372011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5438
5439 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5440 fill background (Bug#8992).
5441
454592a6
MR
54422011-12-13 Martin Rudalics <rudalics@gmx.at>
5443
5444 * window.c (Vwindow_combination_resize)
5445 (Vwindow_combination_limit): Use t instead of non-nil in
5446 doc-strings.
61d4b438
MR
5447 (Vrecenter_redisplay): Add first sentence of doc-string on
5448 separate line.
53524d93 5449 (Frecenter): Fix doc-string typo.
454592a6 5450
3633e3aa
KH
54512011-12-11 Kenichi Handa <handa@m17n.org>
5452
5453 * coding.c (Funencodable_char_position): Pay attention to the
5454 buffer text relocation (Bug#9389).
5455
7b9d523a 54562011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5457
7b9d523a
JD
5458 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5459 gtk_init (Bug#10100).
5460
b73189c6
EZ
54612011-12-10 Eli Zaretskii <eliz@gnu.org>
5462
5463 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5464 IT->string is nil. (Bug#10263)
5465
f7dfe5d6
JD
54662011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5467
83faebb4
JD
5468 * nsterm.h (x_free_frame_resources): Declare.
5469
f7dfe5d6
JD
5470 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5471 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5472
5473 * nsterm.h (ns_get_defaults_value): Declare.
5474
5475 * nsterm.m (ns_default): Call ns_get_defaults_value.
5476
7cd4e72c
EZ
54772011-12-09 Eli Zaretskii <eliz@gnu.org>
5478
5479 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5480 (Bug#10170)
5481
b34d7317
YM
54822011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5483
5484 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5485 that where the value of an _OBJC_* symbol points to is in the .bss
5486 section (Bug#10240).
5487
76470ad1
KH
54882011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5489
5490 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5491 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5492
745fff94
KH
54932011-12-08 Kenichi Handa <handa@m17n.org>
5494
5495 * ftfont.c (get_adstyle_property): Fix previous change
5496 (Bug#10233).
5497
6e44397c
JB
54982011-12-07 Juanma Barranquero <lekktu@gmail.com>
5499
5500 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5501 dirs from the default value of EMACSLOADPATH (bug#10208).
5502
7efa6272
GM
55032011-12-07 Glenn Morris <rgm@gnu.org>
5504
5505 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5506 installation and source directories as well. (Bug#10208)
5507
f6fc4d87
CY
55082011-12-06 Chong Yidong <cyd@gnu.org>
5509
5510 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5511
2bf26180
GM
55122011-12-06 Glenn Morris <rgm@gnu.org>
5513
5514 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5515 as an error, not just -1. (Bug#10217)
5516
3a6ad4f0
CY
55172011-12-05 Chong Yidong <cyd@gnu.org>
5518
5519 * keyboard.c (process_special_events): New function.
5520 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5521
75a3b399
PE
55222011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5523
5524 * coding.c (encode_designation_at_bol): Don't use uninitialized
5525 local variable (Bug#9318).
5526
c3c9e25e
KH
55272011-12-05 Kenichi Handa <handa@m17n.org>
5528
5529 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5530 return Qnil (Bug#8046, Bug#10193).
5531
5eb05ea3
KH
55322011-12-05 Kenichi Handa <handa@m17n.org>
5533
5534 * coding.c (encode_designation_at_bol): New args charbuf_end and
5535 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5536 (coding_set_source): Return how many bytes coding->source was
5537 relocated.
5538 (coding_set_destination): Return how many bytes
5539 coding->destination was relocated.
5540 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5541 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5542
55432011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5544
5545 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5546 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5547 macro (Bug#9318).
5548
55492011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5550
5551 The following changes are to fix Bug#9318.
5552
a79703f5 5553 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5554 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5555 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5556 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5557
7dbda6df
JB
55582011-12-05 Juanma Barranquero <lekktu@gmail.com>
5559
5560 * lisp.h (process_quit_flag): Fix external declaration.
5561
6d5eb5b0
SM
55622011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5563
5564 Don't macro-inline non-performance-critical code.
5565 * eval.c (process_quit_flag): New function.
5566 * lisp.h (QUIT): Use it.
5567
a0c3fad0
JD
55682011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5569
5570 * nsfns.m (get_geometry_from_preferences): New function.
5571 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5572
6c07aac2
AS
55732011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5574
5575 * emacs.c (Qkill_emacs): Define.
5576 (syms_of_emacs): Initialize it.
5577 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5578 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5579 (quit_throw_to_read_char): Add parameter `from_signal'.
5580 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5581 * lisp.h (QUIT): Call Fkill_emacs if requested.
5582
c052ead4
JD
55832011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5584
5585 * widget.c (update_wm_hints): Return if wmshell is null.
5586 (widget_update_wm_size_hints): New function.
5587
5588 * widget.h (widget_update_wm_size_hints): Declare.
5589
5590 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5591 widget_update_wm_size_hints (Bug#10104).
5592
9e49252b
EZ
55932011-12-03 Eli Zaretskii <eliz@gnu.org>
5594
5595 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5596 before a newline, prepare the bidi iterator for consuming the
5597 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5598 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5599
02b16839
JL
56002011-12-02 Juri Linkov <juri@jurta.org>
5601
5602 * search.c (Fword_search_regexp): New Lisp function created from
5603 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5604 (Fword_search_backward, Fword_search_forward)
5605 (Fword_search_backward_lax, Fword_search_forward_lax):
5606 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5607 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5608
0068070e
SM
56092011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5610
5611 * fileio.c (Finsert_file_contents): Move after-change-function call
5612 to before the "handled:" label, since all "goto handled" appear in
5613 cases where the *-change-functions have already been properly called
5614 (bug#10117).
5615
3360a3fc
AS
56162011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5617
5618 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5619 waiting for input. (Bug#10169)
5620
73d6c093
EZ
56212011-11-30 Eli Zaretskii <eliz@gnu.org>
5622
5623 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5624 verifies glyph row's hash code--we have just reallocated the
5625 glyphs, so their contents can be complete garbage. (Bug#10164)
5626
febe6bea
JB
56272011-11-30 Juanma Barranquero <lekktu@gmail.com>
5628
5629 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5630
801a4313
EZ
56312011-11-30 Eli Zaretskii <eliz@gnu.org>
5632
5633 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5634 attributes are tested _before_ calling verify_row_hash, to protect
5635 against GCC re-ordering of the tests. (Bug#10164)
5636
2b56b87e
JD
56372011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5638
5639 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5640
5641 * xterm.c (handle_one_xevent): Only set async_visible and friends
5642 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5643 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5644 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5645
dbf31225
PE
56462011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5647
5648 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5649 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5650 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5651 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5652 All uses changed to use GCPRO1 etc.
5653 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5654 Revert to old implementation (i.e., before 2011-03-11).
5655
1305621b
YM
56562011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5657
5658 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5659 of scroll runs so as to avoid assigning disabled bogus rows and
5660 unnecessary graphics copy operations.
5661
8c9afb46
EZ
56622011-11-27 Eli Zaretskii <eliz@gnu.org>
5663
5664 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5665 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5666 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5667 (malloc, free, realloc, calloc): Redirect to e_* only when
5668 compiling Emacs.
5669
5670 * lisp.h (GCTYPEBITS): Move before first use.
5671 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5672 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5673 this macro definition.
5674
5675 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5676 _MSC_VER.
5677
54e9e3bf
JD
56782011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5679
6d5eb5b0
SM
5680 * gtkutil.c (xg_create_frame_widgets):
5681 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5682 present with Gtk+ 2.0.
5683
83aca1cb
PE
56842011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5685
5686 * fileio.c (Finsert_file_contents): Undo previous change; see
5687 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5688
5b76caa4
PE
56892011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5690
5691 Rename locals to avoid shadowing.
5692 * fileio.c (Finsert_file_contents):
5693 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5694 * process.c (wait_reading_process_output):
5695 Rename inner 'proc' to 'p' to avoid shadowing.
5696 Indent for consistency with usual Emacs style.
5697
8c535114
EZ
56982011-11-25 Eli Zaretskii <eliz@gnu.org>
5699
5700 * xdisp.c (redisplay_window): If cursor row is not fully visible
5701 after recentering, and scroll-conservatively is set to a large
5702 number, scroll window by a few more lines to make the cursor fully
5703 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5704 (start_display): Don't move to the next line if the display should
5705 start at a newline that is part of a display vector or an overlay
5706 string. (Bug#10119)
8c535114 5707
fa4fdb5c
JL
57082011-11-24 Juri Linkov <juri@jurta.org>
5709
5710 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5711 after the `MagickPingImage' call. (Bug#10112)
5712
90ec88df
CY
57132011-11-23 Chong Yidong <cyd@gnu.org>
5714
5715 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5716
56e2e794
MR
57172011-11-23 Martin Rudalics <rudalics@gmx.at>
5718
5719 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5720 making another buffer current. (Bug#10114)
5721
b6e64c41
GM
57222011-11-23 Glenn Morris <rgm@gnu.org>
5723
5724 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5725
6b21de18
CY
57262011-11-23 Chong Yidong <cyd@gnu.org>
5727
5728 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5729 using it (Bug#5984).
5730
b12cd789
EZ
57312011-11-22 Eli Zaretskii <eliz@gnu.org>
5732
5733 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5734 and header-lines, as they don't have one computed for them.
5735 (Bug#10098)
5736
5737 * .gdbinit (prow): Make displayed values more self-explaining.
5738 Add row's hash code.
5739
261b6fd4
LMI
57402011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5741
5742 * process.c (wait_reading_process_output): Fix asynchrounous
5743 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5744 (wait_reading_process_output): Add comment and URL.
261b6fd4 5745
e7cfd277
JD
57462011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5747
5748 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5749
a9b9b7f5
CY
57502011-11-21 Chong Yidong <cyd@gnu.org>
5751
5752 * window.c (Fnext_window, Fprevious_window): Doc fix.
5753
b0d15b4f
SM
57542011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5755
5756 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5757
fe7a3057
JB
57582011-11-20 Juanma Barranquero <lekktu@gmail.com>
5759
5760 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5761
d2999b1a
MR
57622011-11-20 Martin Rudalics <rudalics@gmx.at>
5763
5764 * window.c (Fset_window_combination_limit): Rename argument
5765 STATUS to LIMIT.
5766 (Vwindow_combination_limit): Remove "status" from doc-string.
5767
d5ff9cd0
AS
57682011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5769
5770 * m/ibms390.h: Remove.
5771 * m/ibms390x.h: Don't include "ibms390.h".
5772
a5bb9bd3
SM
57732011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5774
5775 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5776 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5777
cd1181db
JB
57782011-11-20 Juanma Barranquero <lekktu@gmail.com>
5779
5780 * casetab.c (Fset_case_table):
5781 * charset.c (Fcharset_after): Fix typos.
5782
615a3b8d 57832011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5784
17e845af
PE
5785 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5786 Otherwise, valgrind does not work on some platforms.
5787 Problem reported by Andreas Schwab in
6a0bf43d
PE
5788 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5789 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5790 is set, removing the need for VIRT_ADDRESS_VARIES.
5791 (PURE_P): Use a more-efficient implementation that needs just one
5792 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5793 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5794 to 4 (xorl, subq, cmpq, setbe).
5795 * alloc.c (pure): Always extern now, since that's the
5796 VIRT_ADDR_VARIES behavior.
5797 (PURE_POINTER_P): Use a single comparison, not two, for
5798 consistency with the new puresize.h.
5799 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5800 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5801 Remove VIRT_ADDR_VARIES no longer needed.
5802
f8fe6f96
EZ
58032011-11-19 Eli Zaretskii <eliz@gnu.org>
5804
5805 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5806 (erase_phys_cursor, update_window_cursor, show_mouse_face)
5807 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
5808 behave as if the cursor position were at the window margin.
5809
5810 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
5811 and the cursor position is out of bounds, behave as if the cursor
5812 position were at the window margin. (Bug#10075)
5813
df05a53c
CY
58142011-11-18 Chong Yidong <cyd@gnu.org>
5815
5816 * window.c (Fwindow_combination_limit): Make first argument
5817 non-optional, since it is meaningless for live windows like the
5818 selected window.
61ccba97 5819
2071918e
DA
58202011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
5821
5822 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
5823
b50a28de
SM
58242011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
5825
5826 * intervals.c: Fix grafting over the whole buffer (bug#10071).
5827 (graft_intervals_into_buffer): Simplify.
5828
015137db
EZ
58292011-11-18 Eli Zaretskii <eliz@gnu.org>
5830
5831 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
5832 hash values of the two rows.
5833 (copy_row_except_pointers): Preserve the used[] arrays and the
5834 hash values of the two rows. (Bug#10035)
68c95424 5835 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
5836
5837 * xdisp.c (row_hash): New function, body extracted from
5838 compute_line_metrics.
5839 (compute_line_metrics): Call row_hash, instead of computing the
5840 hash code inline.
5841
5842 * dispnew.c (verify_row_hash): Call row_hash for computing the
5843 hash code of a row, instead of duplicating code from xdisp.c.
5844
5845 * dispextern.h (row_hash): Add prototype.
5846
a2addb04
TH
58472011-11-18 Tassilo Horn <tassilo@member.fsf.org>
5848
5849 * frame.c (delete_frame): Don't delete the terminal when the last
5850 X frame is closed if emacs is built with GTK toolkit.
5851
df85d315
JB
58522011-11-17 Juanma Barranquero <lekktu@gmail.com>
5853
5854 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
5855
a0c2d0ae
MR
58562011-11-17 Martin Rudalics <rudalics@gmx.at>
5857
5858 * window.c (Vwindow_splits): Rename to
5859 Vwindow_combination_resize. Suggested by Juri Linkov.
5860 (Fsplit_window_internal): Use Vwindow_combination_resize instead
5861 of Vwindow_splits.
5862
58179cce
JB
58632011-11-16 Juanma Barranquero <lekktu@gmail.com>
5864
7877f373
JB
5865 * nsfns.m (Fns_font_name):
5866 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 5867
b6f67890
MR
58682011-11-16 Martin Rudalics <rudalics@gmx.at>
5869
5870 * window.h (window): Rename slot "nest" to "combination_limit".
5871 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
5872 (Fset_window_nest): Rename to Fset_window_combination_limit.
5873 (Vwindow_nest): Rename to Vwindow_combination_limit.
5874 (recombine_windows, make_parent_window, make_window)
5875 (Fsplit_window_internal, saved_window)
5876 (Fset_window_configuration, save_window_save): Rename all
5877 occurrences of window_nest to window_combination_limit.
5878
c7015153
JB
58792011-11-15 Juanma Barranquero <lekktu@gmail.com>
5880
5881 * image.c (imagemagick_load_image): Fix typo.
5882
322ad6ec
EZ
58832011-11-14 Eli Zaretskii <eliz@gnu.org>
5884
5885 * xdisp.c (display_line): Move the call to
5886 highlight_trailing_whitespace before the call to
5887 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
5888 faces of all the glyphs to compute ROW's hash value.
5889 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 5890
f067b8ec
JB
58912011-11-14 Juanma Barranquero <lekktu@gmail.com>
5892
5893 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
5894 just return (bug#10044).
5895
1e5b2111
EZ
58962011-11-12 Eli Zaretskii <eliz@gnu.org>
5897
7ef3cbd5
EZ
5898 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
5899 with user-defined heap size. Bump the default size of the temacs
5900 heap to 27MB, to avoid memory warning when running temacs.
5901 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
5902
1e5b2111
EZ
5903 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
5904 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
5905 (verify_row_hash) [XASSERTS]: New function.
5906 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
5907 that the hash value of glyph rows is correct.
1e5b2111 5908
89d61221
MR
59092011-11-12 Martin Rudalics <rudalics@gmx.at>
5910
5911 * window.h (window): Remove splits slot.
5912 * window.c (Fwindow_splits, Fset_window_splits): Remove.
5913 (Fdelete_other_windows_internal, make_parent_window)
5914 (make_window, Fsplit_window_internal, Fdelete_window_internal)
5915 (Fset_window_configuration, save_window_save): Don't deal with
5916 split status of windows.
5917 (saved_window): Remove splits slot.
5918 (Vwindow_splits): Rewrite doc-string.
5919
97f18cc8
JD
59202011-11-11 Jan Djärv <jan.h.d@swipnet.se>
5921
5922 * xfns.c (unwind_create_frame):
5923 * nsfns.m (unwind_create_frame):
5924 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
5925 Vframe_list (Bug#9999).
5926
22a648b4
DA
59272011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
5928
0b381c7e 5929 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 5930
659afede
KH
59312011-11-11 Kenichi Handa <handa@m17n.org>
5932
5933 * callproc.c (Fcall_process): Set the member dst_multibyte of
5934 process_coding.
5935
9ac0394b
KH
59362011-11-11 Johan Bockgård <bojohan@gnu.org>
5937
5938 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
5939 avoid a crash (bug#9496).
5940
2fbdc249
CY
59412011-11-09 Chong Yidong <cyd@gnu.org>
5942
5943 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
5944 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
5945
ac6b1f81
PE
59462011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5947
5948 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
5949
09db192c
PE
59502011-11-08 Paul Eggert <eggert@cs.ucla.edu>
5951
5952 Avoid some portability problems by eschewing 'extern inline' functions.
5953 The trivial performance wins aren't worth the portability hassles; see
5954 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
5955 et seq.
5956 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
5957 (window_box_width, window_box_left, window_box_left_offset)
5958 (window_box_right, window_box_right_offset): Undo previous change,
5959 by removing the "extern"s.
5960 * intervals.c (adjust_intervals_for_insertion)
5961 (adjust_intervals_for_deletion): Undo previous change,
5962 making these static again.
5963 (offset_intervals, temp_set_point_both, temp_set_point)
5964 (copy_intervals_to_string): No longer inline.
5965 * xdisp.c (window_text_bottom_y, window_box_width)
5966 (window_box_height, window_box_left_offset)
5967 (window_box_right_offset, window_box_left, window_box_right)
5968 (window_box): No longer inline.
5969
105216ed
CY
59702011-11-08 Chong Yidong <cyd@gnu.org>
5971
5972 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
5973 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
5974 Signal an error if not a live window.
105216ed
CY
5975 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
5976 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
5977
ae9e237f
JB
59782011-11-07 Juanma Barranquero <lekktu@gmail.com>
5979
5980 * lisp.h (syms_of_abbrev): Remove declaration.
5981 Reported by CHENG Gao <chenggao@royau.me>.
5982
c7aa8333
EZ
59832011-11-07 Eli Zaretskii <eliz@gnu.org>
5984
5985 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
5986 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
5987 of temacs in GUI mode.
5988
be7f5545
MR
59892011-11-07 Martin Rudalics <rudalics@gmx.at>
5990
5991 * window.h: Declare delete_all_child_windows instead of
5992 delete_all_subwindows.
5993 * window.c (Fwindow_nest, Fset_window_nest)
5994 (Fset_window_new_total, Fset_window_new_normal)
5995 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
5996 (delete_all_subwindows): Rename to delete_all_child_windows.
5997 (Fdelete_other_windows_internal, Fset_window_configuration):
5998 Call delete_all_child_windows instead of delete_all_subwindows.
5999 * frame.c (delete_frame): Call delete_all_child_windows instead
6000 of delete_all_subwindows.
6001
ca78dc43
PE
60022011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6003
6004 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6005 This is also needed for porting to any host where GC_MARK_STACK is
6006 not GC_MAKE_GCPROS_NOOPS.
6007 (which_symbols): Use it.
6008
a0241d01
KH
60092011-11-07 Kenichi Handa <handa@m17n.org>
6010
6011 * coding.c (coding_set_destination): Check coding->src_pos only
6012 when coding->src_object is a buffer (bug#9910).
6013
6014 * process.c (send_process): Set the member src_multibyte of coding
6015 to 0 (bug#9911) when sending a unibyte text.
6016
6017 * callproc.c (Fcall_process): Set the member src_multibyte of
6018 process_coding to 0 (bug#9912).
6019
a64bfdfa 60202011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6021
6022 * xmenu.c (cleanup_widget_value_tree): New function.
6023 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6024 calling free_menubar_widget_value_tree directly (Bug#9830).
6025
cb41b32a
PE
60262011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6027
6028 Fix some portability problems with 'inline'.
6029 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6030 (window_box_width, window_box_left, window_box_left_offset)
6031 (window_box_right, window_box_right_offset): Declare extern.
6032 Otherwise, these inline functions do not conform to C99 and
6033 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6034 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6035 * intervals.c (adjust_intervals_for_insertion)
6036 (adjust_intervals_for_deletion): Now extern, because otherwise the
6037 extern inline functions 'offset_intervals' couldn't refer to it.
6038 (static_offset_intervals): Remove.
6039 (offset_intervals): Rewrite using the old contents of
6040 static_offset_intervals. The old version didn't conform to C99
6041 because an extern inline function contained a reference to an
6042 identifier with static linkage.
6043
b7041366
AS
60442011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6045
6046 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6047 GC.
6048
88a37c4d
EZ
60492011-11-06 Eli Zaretskii <eliz@gnu.org>
6050
6051 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6052 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6053 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6054 return Qleft_to_right.
6055
49745b39
CY
60562011-11-06 Chong Yidong <cyd@gnu.org>
6057
6058 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6059 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6060 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6061 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6062 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6063 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6064 (Fwindow_vscroll): Doc fix.
6065 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6066 argument, since it makes no sense to pass a live window and for
6067 consistency with window-child.
6068
1f05cd82
CS
60692011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6070
6071 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6072 support MSVC.
6073
22610910
JR
60742011-11-05 Jason Rumney <jasonr@gnu.org>
6075
6076 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6077 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6078 fonts (Bug#6029).
6079 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6080 bitwise arithmetic preventing use of unicode-sip and non-truetype
6081 opentype fonts.
6082
a06776b2
EZ
60832011-11-05 Eli Zaretskii <eliz@gnu.org>
6084
3ad924ba
EZ
6085 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6086 "emacs"-only part.
6087
a06776b2
EZ
6088 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6089 initialization code to keep similarity to xfns.c after changes
6090 from 2011-11-05.
6091
c9e7db78
JD
60922011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6093
a97f8f3f
JD
6094 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6095 (unwind_create_frame): New function (Bug#9943).
6096 (Fx_create_frame): Restructure code to be more similar to the one in
6097 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6098 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6099 Move terminal->reference_count++ just before making the frame official
6100 (Bug#9943).
6101
6102 * nsterm.m (x_free_frame_resources): New function.
6103 (x_destroy_window): Move code to x_free_frame_resources.
6104
c9e7db78 6105 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6106 (Fx_create_frame, x_create_tip_frame):
6107 Move terminal->reference_count++ just before making the frame
75f1671a 6108 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6109 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6110
a6fc3b5c
EZ
61112011-11-05 Eli Zaretskii <eliz@gnu.org>
6112
6113 Support MSVC build with newer versions of Visual Studio.
6114 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6115 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6116 nt/gmake.defs.
6117
6118 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6119 which are not supported by MSVC.
6120 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6121 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6122 bitfields.
6123 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6124 types in bitfields.
6125 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6126
6127 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6128
58179cce 61292011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6130
6131 Support MSVC build with newer versions of Visual Studio.
6132 * w32.c: Don't include w32api.h for MSVC.
6133 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6134
6135 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6136 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6137 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6138 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6139 e_* cousins.
6140 (alloca) [_MSC_VER]: Define to _alloca.
6141
6142 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6143
6144 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6145
a58c13ed
EZ
61462011-11-04 Eli Zaretskii <eliz@gnu.org>
6147
6148 * xdisp.c (note_mouse_highlight): If either of
6149 previous/next-single-property-change returns nil, treat that as
6150 the beginning or the end of the buffer. (Bug#9955)
6151
fe0b6370
JD
61522011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6153
a58c13ed 6154 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6155 label is not null (Bug#9951).
6156 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6157 may be NULL.
6158
89bd5ee1
EZ
61592011-11-04 Eli Zaretskii <eliz@gnu.org>
6160
6161 * window.c (Fwindow_body_size): Mention in the doc string that the
6162 return value is in frame's canonical units. (Bug#9949)
6163
84c3edb9
EZ
61642011-11-03 Eli Zaretskii <eliz@gnu.org>
6165
4e2fb5c7
EZ
6166 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6167
84c3edb9 6168 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6169 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6170 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6171
bc17a887
EZ
61722011-11-01 Eli Zaretskii <eliz@gnu.org>
6173
6174 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6175 Don't stop backward scan on the continuation glyph, even though
6176 its CHARPOS is positive.
6d5eb5b0
SM
6177 (mouse_face_from_buffer_pos, note_mouse_highlight):
6178 Rename cover_string to disp_string.
bc17a887 6179
4ee88440
MR
61802011-11-01 Martin Rudalics <rudalics@gmx.at>
6181
6182 * window.c (temp_output_buffer_show): Don't use
6183 Vtemp_buffer_show_specifiers.
6184 (Vtemp_buffer_show_specifiers): Remove unused variable.
6185
c2ff3c02
EZ
61862011-10-30 Eli Zaretskii <eliz@gnu.org>
6187
6188 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6189 past the beginning of the current glyph matrix.
6190
58179cce 61912011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6192
6193 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6194 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6195 HAVE_GTK3 (Bug#9869).
b77a6a7f 6196
3b574623
JD
6197 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6198 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6199
b77a6a7f
JD
6200 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6201
6202 * xterm.c: Declare x_handle_net_wm_state to return int.
6203 (handle_one_xevent): Check if we are iconified but don't have
6204 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6205 (get_current_wm_state): Return non-zero if not hidden,
6206 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6207 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6208 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6209 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6210
196e41e4
PE
62112011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6212
6213 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6214 so that this new function doesn't get optimized away by a
6215 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6216
021f2e1a
AS
62172011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6218
6219 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6220
8b058d44
EZ
62212011-10-29 Eli Zaretskii <eliz@gnu.org>
6222
6223 Fix the `xbytecode' command.
6224 * .gdbinit (xprintbytestr): New command.
b50a28de 6225 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6226 (xbytecode): Print the byte-code string as well.
6227
4452fb80
EZ
62282011-10-29 Kim Storm <storm@cua.dk>
6229
8b058d44
EZ
6230 * alloc.c (which_symbols): New function.
6231
21b72067
AS
62322011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6233
6234 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6235 line. (Bug#9903)
6236
83ed7b5c
GM
62372011-10-29 Glenn Morris <rgm@gnu.org>
6238
6239 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6240 Not clear what it was for, and it causes various bugs. (Bug#9839)
6241
5a7a728b
EZ
62422011-10-28 Eli Zaretskii <eliz@gnu.org>
6243
6244 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6245 possible random value that matches one of those tested as
6246 condition to clear the mouse face.
6247
d3d0842f
CY
62482011-10-28 Chong Yidong <cyd@gnu.org>
6249
6250 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6251
31b39d13
DN
62522011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6253
6254 * window.c (make_window): Initialize phys_cursor_on_p.
6255
9aba6043
SM
62562011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6257
6258 * lisp.h (struct Lisp_Symbol): Update comments.
6259
c20992f4
JB
62602011-10-28 Juanma Barranquero <lekktu@gmail.com>
6261
6262 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6263
db4f02f2
EZ
62642011-10-28 Eli Zaretskii <eliz@gnu.org>
6265
6266 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6267 <oslsachem@gmail.com> for helping to debug this.
6268
6269 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6270 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6271 (g_b_init_get_glyph_outline_w): New static variables.
6272 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6273 (GetGlyphOutlineW_Proc): New typedefs.
6274 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6275 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6276 New functions.
6277 (w32font_open_internal, compute_metrics):
6278 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6279 instead of calling the "wide" APIs directly.
6280
6281 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6282
6283 * w32.h (syms_of_w32font): Add prototype.
6284
87e68db4
JB
62852011-10-27 Juanma Barranquero <lekktu@gmail.com>
6286
6287 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6288 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6289 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6290 (Fmove_to_window_line): Doc fix.
6291
435c1d67
CY
62922011-10-27 Chong Yidong <cyd@gnu.org>
6293
6294 * process.c (make_process): Set gnutls_state to NULL.
6295
6296 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6297 non-NULL, regardless of GNUTLS_INITSTAGE.
6298 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6299 an error. Set process slots as soon as we allocate them.
6300
6301 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6302
9c6c6f49
CY
63032011-10-27 Chong Yidong <cyd@gnu.org>
6304
9aba6043
SM
6305 * gnutls.c (emacs_gnutls_deinit): New function.
6306 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6307 (Fgnutls_deinit, Fgnutls_boot): Use it.
6308
6309 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6310 (deactivate_process): Call emacs_gnutls_deinit.
6311
657d08d3
JB
63122011-10-27 Juanma Barranquero <lekktu@gmail.com>
6313
6314 * image.c (x_create_x_image_and_pixmap):
6315 * w32.c (sys_rename, w32_delayed_load):
6316 * w32font.c (fill_in_logfont):
6317 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6318
5430d399
JB
63192011-10-26 Juanma Barranquero <lekktu@gmail.com>
6320
6321 * w32fns.c (w32_default_color_map): New function,
6322 extracted from Fw32_default_color_map.
a7ef684b 6323 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6324
fe0055fa
PE
63252011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6326
6327 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6328
e6346438
SM
63292011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6330
6331 * keyboard.c (test_undefined): New function (bug#9751).
6332 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6333
e112cc37
ET
63342011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6335
6336 * sysdep.c (init_sys_modes): Fix the check for the controlling
6337 terminal (Bug#6649).
6338
7b5d6677
EZ
63392011-10-20 Eli Zaretskii <eliz@gnu.org>
6340
6341 * dispextern.h (struct bidi_it): New member next_en_type.
6342
6343 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6344 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6345 current character, check also for next_en_type being WEAK_EN.
6346 (bidi_resolve_weak): Don't enter the expensive loop if the current
6347 position is before next_en_pos. Record the bidi type of the first
6348 non-ET, non-BN character we find, in addition to its position.
6349 (bidi_level_of_next_char): Invalidate next_en_type when
6350 next_en_pos is over-stepped.
6351
7da0b018
PE
63522011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6353
6354 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6355 * editfns.c: Rewrite current-time-zone so that it invokes
6356 the equivalent of (format-time-string "%Z") to get the time zone name.
6357 This fixes a bug when the time zone name contains characters that
6358 need converting from the system time locale to Emacs internal format.
6359 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6360 that patch fixed format-time-string to do the conversion, but
6361 I forgot to fix current-time-zone.
6362 (format_time_string): New function, containing most of
6363 what Fformat_time_string used to contain.
6364 (Fformat_time_string): Rewrite in terms of format_time_string.
6365 This doesn't change this function's behavior.
6366 (current-time-zone): Rewrite to use format_time_string.
6367 This fixes the bug reported by Michael Schierl in
6368 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6369 Jason Rumney's 2007-06-07 change worked around this bug, but
6370 didn't fix it.
6371 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6372
8547b010
EZ
63732011-10-19 Eli Zaretskii <eliz@gnu.org>
6374
6375 * xdisp.c (start_display): If the character at POS is displayed
6376 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6377 (try_window_reusing_current_matrix): If a line ends in a display
6378 vector or the next line starts in a display vector, continue
6379 redrawing the window even though the character position of
6380 start_row was reached.
8547b010
EZ
6381 (Bug#9771, part 2)
6382
4e948d15
CY
63832011-10-18 Chong Yidong <cyd@gnu.org>
6384
6385 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6386 with nobreak-char-display too.
6387
4787455f
EZ
63882011-10-18 Eli Zaretskii <eliz@gnu.org>
6389
6390 Fix part 3 of bug#9771.
6391 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6392 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6393 non-neutral characters if the current character is a paragraph
6394 separator (a.k.a. Newline). This avoids running the same
6395 expensive loop twice, once when we consume the preceding newline
6396 and the other time when the line actually needs to be displayed.
6397 Avoid the loop when we see neutrals on the base embedding level
6398 following a character whose directionality is the same as the
6399 paragraph's. This avoids running the expensive loop when a line
6400 ends in a long sequence of neutrals, like control characters.
6401 Add assertion against STRONG_AL type. Slightly rearrange code
6402 that determines the type of a neutral given the first non-neutral
6403 that follows it.
6404 (bidi_level_of_next_char): Set next_en_pos to zero when
6405 invalidating its info.
6406
2c91f553
EZ
64072011-10-17 Eli Zaretskii <eliz@gnu.org>
6408
6409 * xdisp.c (push_display_prop): Determine whether to record string
6410 or buffer position by IT->string, not by IT->method. Allow
6411 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6412 (move_it_vertically_backward): Don't look for character position
6413 immediately after the newline when in a continuation line.
6414 (Bug#9771, part 1)
2c91f553 6415
c7b08b0d
MR
64162011-10-15 Martin Rudalics <rudalics@gmx.at>
6417
6418 * window.c (coordinates_in_window): Rewrite and delabelize
6419 vertical border check. (Bug#5357) (Bug#9618)
6420
6b02f655
SM
64212011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6422
6423 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6424 errors in XSetWindowBorder (bug#9310).
6425
81d40c92
DA
64262011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6427
6428 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6429 avoid crash when xmalloc overrun checking is enabled.
6430
d4172c3b
EZ
64312011-10-13 Eli Zaretskii <eliz@gnu.org>
6432
6433 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6434 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6435 cursor motion with <left> and <right> arrow keys.
6436
6437 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6438 some callers set that themselves.
6439
b00eea75
EZ
64402011-10-12 Eli Zaretskii <eliz@gnu.org>
6441
6442 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6443 display string and the previous row comes from the same string and
6444 is empty. (Bug#9739) (Bug#9738)
6445
8fe012c4
SM
64462011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6447
6448 * doc.c (get_doc_string): Encode file name (bug#9735).
6449
0074aef2
EZ
64502011-10-12 Eli Zaretskii <eliz@gnu.org>
6451
79beb178
EZ
6452 * bidi.c (bidi_level_of_next_char):
6453 * xdisp.c (get_visually_first_element): Remove old incorrect
6454 comments regarding the Unicode Line Separator character.
6455
0074aef2
EZ
6456 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6457
6e4b3fbe
DA
64582011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6459
6460 * alloc.c (Fgc_status): Do not access beyond zombies array
6461 boundary if nzombies > MAX_ZOMBIES.
6462 * alloc.c (dump_zombies): Add missing format specifier.
6463
0324f3af
PE
64642011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6465
b5525cac
PE
6466 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6467 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6468
0324f3af
PE
6469 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6470 Some packages use them to denote characters with modifiers.
6471
e9b5f888
AS
64722011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6473
6474 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6475 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6476 matching a pp-number. Rename parameter var to var1.
6477
127827c0
SM
64782011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6479
6480 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6481
c8fd3bd0
GM
64822011-10-08 Glenn Morris <rgm@gnu.org>
6483
6484 * callint.c (Fcall_interactively): Give a more explicit error for the
6485 'c' case with a non-character input. (Bug#8479)
6486
352ec8ff
EZ
64872011-10-08 Eli Zaretskii <eliz@gnu.org>
6488
03669ccb
EZ
6489 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6490 lines.
7061c986
EZ
6491 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6492 lines that are hscrolled on the left.
03669ccb 6493
352ec8ff
EZ
6494 * dispnew.c (buffer_posn_from_coords): Account for a possible
6495 presence of header-line. (Bug#4426)
6496
a66cfb1c
SM
64972011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6498
6b02f655
SM
6499 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6500 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6501
7c5ee88e
PE
65022011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6503
6504 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6505 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6506 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6507 this makes Emacs dump core during garbage collection on rare
6508 occasions. sizeof is obviously inferior to offsetof here, so
6509 stick with offsetof.
6510 (GC_POINTER_ALIGNMENT): New macro.
6511 (mark_memory): Omit 3rd (offset) arg; caller changed.
6512 Don't assume EMACS_INT alignment is the same as pointer alignment.
6513
df1bbe5b
SM
65142011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6515
6516 * keyboard.c (read_key_sequence_remapped): New var.
6517 (read_key_sequence): Compute remapping in the right buffer.
6518 (command_loop_1): Use read_key_sequence's remapping directly.
6519
51553db6
SM
65202011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6521
32c1fffd
SM
6522 * dired.c (file_name_completion): Don't expand file name.
6523 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6524 before checking file name handler.
6525
51553db6
SM
6526 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6527 they've been requested explicitly (bug#9591).
6528
b6bd1599 65292011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6530
6531 * keymap.c (Fsingle_key_description): Use make_specified_string
6532 instead of build_string to build string from push_key_description.
6533 (Bug#5193)
6534
f701dc2a
PE
65352011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6536
4222c55d
PE
6537 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6538 This fixes a Y2038 bug on 64-bit hosts.
6539 * buffer.c (reset_buffer):
6540 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6541 (Fclear_buffer_auto_save_failure):
6542 Use 0, not -1, to represent an unset failure time, since time_t
6543 might not be signed.
6544
f701dc2a
PE
6545 Remove dependency on glibc malloc internals.
6546 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6547 Move back here from lisp.h, but with their new implementations.
6548 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6549 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6550 * charset.c (charset_table_init): New static var.
6551 (syms_of_charset): Use it instead of xmalloc. This removes a
6552 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6553 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6554 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6555 Move back to alloc.c.
6556 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6557 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6558
9ceebf39
JD
65592011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6560
6561 * nsterm.m (windowDidResize): Call x_set_window_size only when
6562 ns_in_resize is true. Otherwise set pixelwidth/height and
6563 call change_frame_size (Bug#9628).
6564
cb993c58
PE
65652011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6566
3930c88b
PE
6567 Port --enable-checking=all to Fedora 14 x86-64.
6568 * charset.c (syms_of_charset): Also account for glibc malloc's
6569 internal overhead when calculating the initial malloc maximum.
6570
cb993c58
PE
6571 Port --enable-checking=all to Fedora 14 x86.
6572 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6573 Move to lisp.h.
6574 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6575 (overrun_check_realloc, overrun_check_free):
6576 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6577 That way, xmalloc returns a properly-aligned pointer even if
6578 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6579 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6580 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6581 into account when calculating the initial malloc maximum.
6582 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6583 Move here from alloc.c, so that charset.c can use it too.
6584 Properly align; the old code wasn't right for common 32-bit hosts
6585 when configured with --enable-checking=all.
6586 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6587 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6588
31bed486
EZ
65892011-09-29 Eli Zaretskii <eliz@gnu.org>
6590
04c70788 6591 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6592 use EDOM.
6593
fbcaa2f3
EZ
65942011-09-28 Eli Zaretskii <eliz@gnu.org>
6595
6596 * xdisp.c (compute_display_string_end): If there's no display
6597 string at CHARPOS, return -1.
6598
6599 * bidi.c (bidi_fetch_char): When compute_display_string_end
6600 returns a negative value, treat the character as a normal
6601 character not covered by a display string. (Bug#9624)
6602
a239d4e9
JB
66032011-09-28 Juanma Barranquero <lekktu@gmail.com>
6604
6605 * lread.c (Fread_from_string): Fix typo in docstring.
6606
88652fd5
EZ
66072011-09-27 Eli Zaretskii <eliz@gnu.org>
6608
6609 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6610 newline, reseat the iterator instead of bidi-iterating there one
6611 character at a time. (Bug#9610)
32c1fffd
SM
6612 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6613 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6614
ed497dd4
AS
66152011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6616
6617 * lread.c (readevalloop): Use correct code for NBSP.
6618 (read1): Likewise. (Bug#9608)
6619
b2bf61aa
MA
66202011-09-25 Michael Albinus <michael.albinus@gmx.de>
6621
6622 * dbusbind.c (Fdbus_register_signal): When service is not
6623 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6624
32bbb17c
GM
66252011-09-25 Glenn Morris <rgm@gnu.org>
6626
6627 * buffer.c (truncate-lines): Doc fix.
6628
94e0933e
CY
66292011-09-24 Chong Yidong <cyd@stupidchicken.com>
6630
6631 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6632 (Fset_window_next_buffers): Doc fix.
6633
cddde921
GM
66342011-09-24 Glenn Morris <rgm@gnu.org>
6635
6636 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6637
1260aef1
PE
66382011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6639
25b4bfa0
PE
6640 Fix minor problems found by static checking.
6641 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6642 * indent.c (Fvertical_motion): Fix == vs = typo.
6643
e3cbd34b
EZ
66442011-09-24 Eli Zaretskii <eliz@gnu.org>
6645
a66cfb1c
SM
6646 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6647 Default value is now t. Doc fix.
6bf7006f 6648
e3cbd34b 6649 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6650 logic when moving up, not only when moving down. Fix the
e3cbd34b 6651 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6652 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6653
6654 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6655 CHARPOS is covered by a display string which includes newlines.
6656 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6657 is covered by a display string with embedded newlines.
6658
a3de0cbd
MA
66592011-09-24 Michael Albinus <michael.albinus@gmx.de>
6660
6661 * dbusbind.c (Fdbus_register_signal): Add match rule to
6662 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6663 (Fdbus_register_method, Vdbus_registered_objects_table):
6664 Fix docstring.
a3de0cbd 6665
b260039d
JM
66662011-09-24 Jim Meyering <meyering@redhat.com>
6667
32c1fffd 6668 do not ignore write error for any output size
b260039d
JM
6669 The previous change was incomplete.
6670 While it makes emacs --batch detect the vast majority of stdout
6671 write failures, errors were still ignored whenever the output size is
6672 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6673 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6674 && echo FAIL: ignored write error
6675 FAIL: ignored write error
6676 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6677 && echo FAIL: ignored write error
6678 FAIL: ignored write error
6679 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6680
8eca8a7c
AS
66812011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6682
6683 * emacs.c (Fkill_emacs): In noninteractive mode exit
6684 non-successfully if a write error occurred on stdout. (Bug#9574)
6685
3341db62
EZ
66862011-09-21 Eli Zaretskii <eliz@gnu.org>
6687
6688 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6689 the xassert test.
6690
6691 * dispextern.h (struct it): Update the comment documenting what
6692 can it->OBJECT be.
6693
8c203dbf
EZ
66942011-09-20 Eli Zaretskii <eliz@gnu.org>
6695
6696 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6697 a display string, extend search for cursor position to end of row.
6698 (find_row_edges): If the row ends in a newline from a display
6699 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6700 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6701 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6702 non-empty line. Fixes confusing cursor motion with arrow keys at
6703 the beginning of a line that starts with whitespace.
8c203dbf 6704
a4824228
LMI
67052011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6706
6707 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6708 (bug#9493).
6709
33ed493b
CY
67102011-09-18 Chong Yidong <cyd@stupidchicken.com>
6711
6712 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6713 boolean (Bug#9154).
6714
56cd55c8
EZ
67152011-09-18 Eli Zaretskii <eliz@gnu.org>
6716
6717 * xdisp.c (display_line): Record maximum and minimum buffer
6718 positions even if no glyphs were produced (e.g., by a zero-width
6719 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6720 buffer positions that will be removed from the glyph row because
6721 they don't fit.
c02dcedf
EZ
6722 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6723 column is beyond frame width: don't subtract 1 "pixel" when
6724 computing width of the stretch.
3e62b7e0
EZ
6725 (reseat_at_next_visible_line_start): Undo the change made on
6726 2011-09-17 that saved paragraph information and restored it after
6727 the call to `reseat'. (Bug#9545)
56cd55c8 6728
5ed99d36 67292011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6730
6731 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6732 and turn window cursor on if cleared (Bug#9415).
6733
5ed99d36 67342011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6735
6736 * search.c (boyer_moore): Take unibyte characters from pattern
6737 literally. (Bug#9458)
6738
9bade7b2
EZ
67392011-09-18 Eli Zaretskii <eliz@gnu.org>
6740
6741 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6742
e5e9d610
PE
67432011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6744
87e4427a
PE
6745 Fix minor problem found by static checking.
6746 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6747 initialized, to pacify gcc -Wuninitialized.
6748
e5e9d610
PE
6749 * fileio.c: Report proper errno when syscall falls.
6750 (Finsert_file_contents): Save and restore errno,
6751 so that report_file_error outputs the correct diagnostic.
6752 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6753
a1674f0b
EZ
67542011-09-18 Eli Zaretskii <eliz@gnu.org>
6755
6756 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6757
fbfb6dd4
EZ
67582011-09-17 Eli Zaretskii <eliz@gnu.org>
6759
6760 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6761 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6762
bb187662
EZ
67632011-09-17 Eli Zaretskii <eliz@gnu.org>
6764
1137e8b8 6765 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6766 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6767
6768 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6769 (bidi_find_paragraph_start): Search back for paragraph beginning
6770 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6771 (bidi_move_to_visually_next): Only trigger paragraph-related
6772 computations when the last character is a newline or at EOB, not
6773 just any NEUTRAL_B. (Bug#9470)
6774
bb187662
EZ
6775 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6776 truncated lines if point is covered by a display string. (Bug#9524)
6777
2e621251
PE
67782011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6779
6780 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6781 (cons_to_x_long): New function.
6782 (lisp_data_to_selection_data): Use it. Correct the test for
6783 short-versus-long data; it was negated. Break out of vector
6784 loop, for efficiency, when a long datum is discovered.
6785
91a15bc6
SM
67862011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6787
6788 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6789
b41c3a35
EZ
67902011-09-16 Eli Zaretskii <eliz@gnu.org>
6791
6792 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6793 GCC PR/17406) by declaring this function with external scope.
6794
7812ba2d
PE
67952011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6796
6797 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6798 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6799
cf7edc2a
AS
68002011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6801
6802 * editfns.c (Fformat): Correctly handle text properties on "%%".
6803
bd01620e
EZ
68042011-09-15 Eli Zaretskii <eliz@gnu.org>
6805
6806 * xterm.c (x_draw_composite_glyph_string_foreground):
6807 * w32term.c (x_draw_composite_glyph_string_foreground):
6808 * term.c (encode_terminal_code):
6809 * composite.c (composition_update_it, get_composition_id):
6810 * xdisp.c (get_next_display_element)
6811 (fill_composite_glyph_string): Add comments about special meaning
6812 of TAB characters in a composition.
6813
a02719a3
PE
68142011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6815
6816 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
6817 This occurs when processing a multibyte format.
6818 Problem reported by Wolfgang Jenker.
a02719a3 6819
72589a3c
JB
68202011-09-15 Johan Bockgård <bojohan@gnu.org>
6821
6822 * xdisp.c (try_cursor_movement): Only check for exact match if
6823 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
6824
1c14176c
PE
68252011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6826
6827 Remove unused external symbols.
6828 * dispextern.h (calc_pixel_width_or_height): Remove decl.
6829 * xdisp.c (calc_pixel_width_or_height): Now static.
6830 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
6831 * indent.c (check_display_width):
6832 * w32term.c: Fix comment to match code.
6833 * xterm.c, xterm.h (x_catching_errors): Remove.
6834
d2eea5b5
PE
68352011-09-14 Paul Eggert <eggert@cs.ucla.edu>
6836
6837 * xselect.c: Use signed conversions more consistently (Bug#9498).
6838 (selection_data_to_lisp_data): Assume incoming selection data are
6839 signed integers, not unsigned. This is to be consistent with
6840 outgoing selection data, which was modified to use signed integers
6841 in as part of the fix to Bug#9196 in response to Jan D.'s comment
6842 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
6843 expects long, not unsigned long.
6844
46888499
EZ
68452011-09-14 Eli Zaretskii <eliz@gnu.org>
6846
6847 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
6848 computation of loop end. Reported by Johan Bockgård
6849 <bojohan@gnu.org>.
6850
ef8ef9fb
CY
68512011-09-13 Chong Yidong <cyd@stupidchicken.com>
6852
6853 * frame.c (Fother_visible_frames_p): Function deleted.
6854
fa819fed
EZ
68552011-09-12 Eli Zaretskii <eliz@gnu.org>
6856
6857 * indent.c (compute_motion): Process display vector front to back
6858 rather than the other way around. (Bug#2496)
6859
2ba8e008
SM
68602011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
6861
6862 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
6863
20f53c69
CY
68642011-09-11 Chong Yidong <cyd@stupidchicken.com>
6865
6866 * minibuf.c (Fread_from_minibuffer): Doc fix.
6867
d562d7a4
EZ
68682011-09-11 Eli Zaretskii <eliz@gnu.org>
6869
6870 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
6871 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
6872
1c4d7f3d
LMI
68732011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
6874
6875 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
6876 value for non-existent files.
6877
b885bf36
EZ
68782011-09-11 Eli Zaretskii <eliz@gnu.org>
6879
6880 * fileio.c (Finsert_file_contents): If the file cannot be opened,
6881 set its "size" to -1. This will set the modtime_size field of
6882 the corresponding buffer to -1, which is what
6883 verify-visited-file-modtime expects for files that do not exist.
6884 (Bug#9139)
6885
6612f0bf
PE
68862011-09-11 Paul Eggert <eggert@cs.ucla.edu>
6887
6888 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
6889 here ...
6890 * lisp.h: ... from here. push_key_description is no longer
6891 defined in keyboard.c, so its declaration should not be in
6892 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
6893 logically belongs with push_key_description.
6894
dfb3f755
PE
68952011-09-10 Paul Eggert <eggert@cs.ucla.edu>
6896
6897 * buffer.h: Include <sys/types.h> instead of <time.h>.
6898 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
6899 Problem reported by Herbert J. Skuhra.
6900
3134906c
LMI
69012011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
6902
6903 * xml.c (parse_region): Make the parsing work for
6904 non-comment-starting XML files again (bug#9144).
6905
8d903f4e
AS
69062011-09-10 Andreas Schwab <schwab@linux-m68k.org>
6907
6908 * image.c (gif_load): Fix calculation of bottom and right corner.
6909 (Bug#9468)
6910
80ad64f4
EZ
69112011-09-10 Eli Zaretskii <eliz@gnu.org>
6912
6913 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
6914 redisplay in small windows.
6915
208a048d
EZ
69162011-09-09 Eli Zaretskii <eliz@gnu.org>
6917
6918 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
6919
9b1c252e
MR
69202011-09-08 Martin Rudalics <rudalics@gmx.at>
6921
6922 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
6923 Operate on live windows only.
6924
2949f33b
JB
69252011-09-08 Juanma Barranquero <lekktu@gmail.com>
6926
6927 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
6928
e08dcafd
EZ
69292011-09-07 Eli Zaretskii <eliz@gnu.org>
6930
6931 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
6932 only under bidi iteration.
6933
115b96bd
JD
69342011-09-07 Jan Djärv <jan.h.d@swipnet.se>
6935
6936 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
6937
c8199d0f
PE
69382011-09-06 Paul Eggert <eggert@cs.ucla.edu>
6939
6940 isnan: Fix porting problem to Solaris 10 with bundled gcc.
6941 Without this fix, the command to link temacs failed due to an
6942 undefined symbol __builtin_isnan. This is because
6943 /usr/include/iso/math_c99.h #defines isnan(x) to
6944 __builtin_isnan(x), but the bundled gcc, which identifies itself
6945 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
6946 a __builtin_isnan.
6947 * floatfns.c (isnan): #undef, and then #define to a clone of
6948 what's in data.c.
6949 (Fisnan): Always define, since it's always available now.
6950 (syms_of_floatfns): Always define isnan at the Lisp level.
6951
e39b275c 69522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
6953
6954 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
6955
b2db44d9 69562011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 6957
f4af5137 6958 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
6959 The previous code assumed that file offsets (off_t values) fit in
6960 EMACS_INT variables, which is not true on typical 32-bit hosts.
6961 The code messed up by falsely reporting buffer overflow in cases
6962 such as (insert-file-contents "big" nil 1 2) into an empty buffer
6963 when "big" contains more than 2**29 bytes, even though this
6964 inserts just one byte and does not overflow the buffer.
6965 (Finsert_file_contents): Store file offsets as off_t
6966 values, not as EMACS_INT values. Check for overflow when
6967 converting between EMACS_INT and off_t. When checking for
6968 buffer overflow or for overlap, take the offsets into account.
6969 Don't use EMACS_INT for small values where int suffices.
6970 When checking for overlap, fix a typo: ZV was used where
6971 ZV_BYTE was intended.
6972 (Fwrite_region): Don't assume off_t fits into 'long'.
6973 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
6974
ecfc0a49
MA
69752011-09-05 Michael Albinus <michael.albinus@gmx.de>
6976
6977 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
6978
6511acf2 69792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 6980
0999621a 6981 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
6982
6983 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 6984 (esprintf, exprintf, evxprintf): New functions.
62f19c19 6985 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 6986 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
6987 (modify_event_symbol): Do not assume that the length of
6988 name_alist_or_stem is safe to alloca and fits in int.
6989 (Fexecute_extended_command): Likewise for function name and binding.
6990 (Frecursion_depth): Wrap around reliably on integer overflow.
6991 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
6992 since some callers pass EMACS_INT values.
6993 (Fsingle_key_description): Don't crash if symbol name contains more
6994 than MAX_ALLOCA bytes.
6995 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
6996 (get_minibuffer): Arg is now EMACS_INT, not int.
6997 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 6998 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
6999 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7000
2be7d702
PE
7001 * dbusbind.c (signature_cat): New function.
7002 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7003 Do not overrun buffer; instead, report string overflow.
7004
9d1df220
PE
7005 * dispnew.c (add_window_display_history): Don't overrun buffer.
7006 Truncate instead; this is OK since it's just a log.
7007
33ef5c64
PE
7008 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7009 even if the time zone offset is outlandishly large.
7010 Don't mishandle offset == INT_MIN.
7011
66c6fdd5
PE
7012 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7013 when creating daemon; the previous buffer-overflow check was incorrect.
7014
d749b01b
PE
7015 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7016 which has the guts of the old verror function.
7017
b5cd1905
PE
7018 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7019 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7020
6e1a67fb
PE
7021 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7022 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7023 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7024 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7025 length of string rather than counting it via multiple sprintfs;
7026 that's simpler and more reliable.
c21721cc
PE
7027 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7028 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7029 sprintf, in case result does not fit in int.
7030
c57b67fc
PE
7031 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7032 (fontset_from_font): Print it.
7033
8a401434
PE
7034 * frame.c (tty_frame_count): Now printmax_t, not int.
7035 (make_terminal_frame, set_term_frame_name): Print it.
7036 (x_report_frame_params): In X, window IDs are unsigned long,
7037 not signed long, so print them as unsigned.
7038 (validate_x_resource_name): Check for implausibly long names,
7039 and don't assume name length fits in 'int'.
7040 (x_get_resource_string): Don't blindly alloca invocation name;
7041 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7042 not fit in int.
7043
6e1a67fb
PE
7044 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7045 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7046 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7047
0df02bf3
PE
7048 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7049 Use esprintf, not sprintf, in case result does not fit in int.
7050
48e30793
PE
7051 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7052 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7053 it as a large positive number.
7054 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7055 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7056
a66ff6d8
PE
7057 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7058 in case result does not fit in int.
7059
aca216ff
PE
7060 * print.c (float_to_string): Detect width overflow more reliably.
7061 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7062 buffer overrun. Don't assume list length fits in 'int'. Treat
7063 print length of 0 as 0, not as infinity; to be consistent with other
7064 uses of print length in this function. Don't overflow print length
7065 index. Don't assume hash table size fits in 'long', or that
7066 vectorlike size fits in 'unsigned long'.
7067
31c286f7
PE
7068 * process.c (make_process): Use printmax_t, not int, to format
7069 process-name gensyms.
7070
55e5faa1
PE
7071 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7072
80f2e268
PE
7073 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7074 to avoid potential buffer overrun.
7075
670741ab
PE
7076 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7077 if X resource line is longer than 512 bytes.
7078
b7163a50
PE
7079 * xfns.c (x_window): Make sprintf buffer a bit bigger
7080 to avoid potential buffer overrun.
7081
ae58ff1f
PE
7082 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7083
c43c8a6a
PE
7084 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7085
3f8236f4
PE
70862011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7087
53e9fe90 7088 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7089 Without these, Emacs silently mishandles large integers sometimes.
7090 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7091 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7092
6511acf2
PE
7093 * xdisp.c (try_window_id): Check Emacs fixnum range before
7094 converting to 'int'.
806add1d 7095
6511acf2 7096 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7097 Check that an Emacs fixnum is in range before assigning it to 'int'.
7098 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7099 values converted from Emacs fixnums.
7100 (Frecenter): Don't wrap around a line count if it is out of 'int'
7101 range; instead, treat it as an extreme value.
7102 (Fset_window_configuration, compare_window_configurations):
7103 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7104
6511acf2
PE
7105 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7106 that can exceed INT_MAX. Check that EMACS_INT value is in range
7107 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7108 (match_limit): Don't assume that a fixnum can fit in 'int'.
7109
6511acf2 7110 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7111 exceed INT_MAX.
7112
6511acf2 7113 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7114 (Fvertical_motion): Don't wrap around LINES values that don't fit
7115 in 'int'. Instead, treat them as extreme values. This is good
7116 enough for windows, which can't have more than INT_MAX lines anyway.
7117
fcb901a7
LMI
71182011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7119
0f2f6b6d
LMI
7120 * Require libxml/parser.h to avoid compilation warning.
7121
fcb901a7
LMI
7122 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7123
7124 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7125 since this reportedly can destroy thread storage.
7126
6e20a0d4
CY
71272011-08-30 Chong Yidong <cyd@stupidchicken.com>
7128
7129 * syntax.c (find_defun_start): Update all cache variables if
7130 exiting early (Bug#9401).
7131
148ae00e
EZ
71322011-08-30 Eli Zaretskii <eliz@gnu.org>
7133
f6cfbd8f
EZ
7134 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7135
148ae00e
EZ
7136 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7137 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7138 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7139
7140 * term.c (tty_append_glyph): New function.
7141 (produce_stretch_glyph): Static function and its prototype deleted.
7142
a66cfb1c
SM
7143 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7144 Add prototypes.
148ae00e 7145
c4a07a4c
PE
71462011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7147
7148 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7149 when checking :margin (Bug#9390).
7150 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7151 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7152 so that the name doesn't mislead. All uses changed.
7153
6bc8cd65
JB
71542011-08-28 Johan Bockgård <bojohan@gnu.org>
7155
7156 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7157 set_tty_hooks.
7158
dca4927e
EZ
71592011-08-27 Eli Zaretskii <eliz@gnu.org>
7160
7161 * xdisp.c (move_it_to): Don't bail out early when reaching
7162 position beyond to_charpos, if we are scanning backwards.
7163 (move_it_vertically_backward): When DY == 0, make sure we get to
7164 the first character in the line after the newline.
7165
f2cad773
PE
71662011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7167
7168 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7169 (ccl_driver): Do not generate an out-of-range pointer.
7170 (Fccl_execute_on_string): Remove unnecessary check for
7171 integer overflow, noted by Stefan Monnier in
7172 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7173 Remove a FIXME that didn't need fixing.
7174 Simplify the newly-introduced buffer reallocation code.
7175
0cae2cdb
JB
71762011-08-27 Juanma Barranquero <lekktu@gmail.com>
7177
7178 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7179
5fc295a4 71802011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7181
70c60eb2 7182 Integer and memory overflow issues (Bug#9196).
726e0ab1 7183
d31850da
PE
7184 * doc.c (get_doc_string): Rework so that
7185 get_doc_string_buffer_size is the actual buffer size, rather than
7186 being 1 less than the actual buffer size; this makes xpalloc more
7187 convenient.
7188
a69fbedb
PE
7189 * image.c (x_allocate_bitmap_record, cache_image):
7190 * xselect.c (Fx_register_dnd_atom):
7191 Simplify previous changes by using xpalloc.
7192
fe5c5d37
PE
7193 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7194 since either will do and ptrdiff_t is convenient with xpalloc.
7195
0065d054
PE
7196 * charset.c (charset_table_size)
7197 (struct charset_sort_data.priority): Now ptrdiff_t.
7198 (charset_compare): Don't overflow if priorities differ greatly.
7199 (Fsort_charsets): Don't assume list length fits in int.
7200 Check for size-calculation overflow when allocating sort data.
7201 (syms_of_charset): Allocate an initial charset table that is
7202 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7203
7204 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7205
7206 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7207 The actual value is always <= INT_MAX, and leaving it unsigned made
7208 overflow checking harder.
7209
7210 * dispextern.h (struct glyph_matrix.rows_allocated)
7211 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7212 with xpalloc. The values are still always <= INT_MAX.
7213
7214 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7215
7216 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7217 (SAFE_NALLOCA): New macro.
7218
7219 * region-cache.c (struct boundary.pos, find_cache_boundary)
7220 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7221 (set_cache_region, invalidate_region_cache)
7222 (revalidate_region_cache, know_region_cache, region_cache_forward)
7223 (region_cache_backward, pp_cache):
7224 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7225 so that ptrdiff_t * can be passed to xpalloc.
7226 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7227 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7228 (pp_cache): Don't assume cache_len fits in int.
7229 * region-cache.h: Adjust extern decls to match.
7230
7231 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7232 EMACS_INT, since either will do, for xpalloc.
7233
7234 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7235 (xnmalloc, xnrealloc, xpalloc): New functions.
7236
726e0ab1
PE
7237 * bidi.c (bidi_shelve_header_size): New constant.
7238 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7239 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7240
51f30bc5 7241 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7242 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7243 (overlay_strings):
7244 Don't update size of array until after memory allocation succeeds,
7245 because xmalloc/xrealloc may not return.
0065d054
PE
7246 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7247 now that we have proper integer overflow checking.
7248 (record_overlay_string, overlay_strings): Catch overflows when
7249 calculating size of overlay_str_buf.
726e0ab1 7250
0065d054
PE
7251 * callproc.c (Fcall_process): Check for size overflow when
7252 calculating size of args2.
7253 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7254 Normally we prefer signed values, but sticking with ptrdiff_t would
7255 require adding more-complicated checks.
726e0ab1
PE
7256
7257 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7258 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7259 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7260 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7261
7262 * character.c (Fstring): Check for size-calculation overflow.
7263
7264 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7265 unnecessary integer overflow. Check for size overflow.
7266 (encode_coding_object): Don't update size until xmalloc succeeds.
7267
7268 * composite.c (get_composition_id): Check for overflow in glyph
7269 length calculations.
7270
7271 Integer and memory overflow fixes for display code.
7272 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7273 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7274 (scrolling_window): Check for overflow in size calculations.
7275 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7276 Don't assume glyph table len fits in int.
7277 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7278 (row_table_size): Now ptrdiff_t, not int.
7279 (scrolling_window): Avoid overflow in size calculations.
7280 Don't update size until allocation succeeds.
7281 * fns.c (concat): Check for overflow in size calculations.
7282 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7283 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7284 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7285
7286 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7287 (get_doc_string): Check for size calculation overflow.
7288 Don't update size until allocation succeeds.
7289 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7290 EMACS_INT, where ptrdiff_t will do.
7291 (Fsubstitute_command_keys): Check for string overflow.
7292
7293 * editfns.c (set_time_zone_rule): Don't assume environment length
7294 fits in int.
7295 (message_length): Now ptrdiff_t, not int.
7296 (Fmessage_box): Don't update size until allocation succeeds.
7297 Don't assume message length fits in int.
7298 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7299
0065d054
PE
7300 * emacs.c (main): Do not reallocate argv, since there is a null at
7301 the end that can be overwritten, and this way there's no need to
7302 worry about size-calculation overflow.
7303 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7304
7305 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7306 alloc succeeds.
7307 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7308
7309 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7310 (x_set_scroll_bar_width, x_figure_window_size):
7311 Check for integer overflow.
7312 (x_set_alpha): Do not assume XINT fits in int.
7313
7314 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7315 This is for the members text_lines, text_cols, total_lines, total_cols,
7316 where the system imposes an 'int' limit.
7317
7318 * fringe.c (Fdefine_fringe_bitmap):
7319 Don't update size until alloc works.
7320
7321 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7322 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7323
7324 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7325 Check for size-calculation overflow.
7326 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7327 do, as we prefer signed integers.
7328 (id_to_widget.max_size, id_to_widget.used)
7329 (xg_store_widget_in_map, xg_remove_widget_from_map)
7330 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7331 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7332 Use and return ptrdiff_t, not int.
7333 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7334 * gtkutil.h: Change prototypes to match the above.
7335
7336 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7337 are duplicate now that they've been promoted to lisp.h.
7338 (x_allocate_bitmap_record, x_alloc_image_color)
7339 (make_image_cache, cache_image, xpm_load):
7340 Don't update size until alloc is done.
7341 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7342 (x_detect_edges):
3256efce 7343 Check for size calculation overflow.
726e0ab1
PE
7344 (ct_colors_allocated_max): New constant.
7345 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7346 overflow.
3256efce 7347
726e0ab1
PE
7348 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7349 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7350 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7351 Use ptrdiff_t, not int, to count maps.
7352 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7353 calculations. Don't update size until allocation succeeds.
7354 Redo calculations to avoid overflow.
726e0ab1
PE
7355 * keyboard.h: Change prototypes to match the above.
7356
7357 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7358 to count maps.
7359 (current_minor_maps): Check for size calculation overflow.
7360 * keymap.h: Change prototypes to match the above.
7361
7362 * lread.c (read1, init_obarray): Don't update size until alloc done.
7363
7364 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7365 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7366
726e0ab1
PE
7367 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7368 Now ptrdiff_t, not int.
7369 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7370 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7371
7372 * process.c (Fnetwork_interface_list): Check for overflow
7373 in size calculation.
7374
7375 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7376
7377 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7378 overflow. Don't bother calling xmalloc when xrealloc will do.
7379
7380 * search.c (Freplace_match): Check for size calculation overflow.
7381 (Fset_match_data): Don't assume list lengths fit in 'int'.
7382
7383 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7384 for command line length. Do not attempt to address one before the
7385 beginning of an array, as that's not portable.
7386
7387 * term.c (max_frame_lines): Remove; unused.
7388 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7389 not int.
7390 (encode_terminal_code, calculate_costs): Check for size
7391 calculation overflow.
7392 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7393 table lengths and related sizes. Don't update size until alloc
7394 done. Redo calculations to avoid overflow.
7395 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7396
7397 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7398 subtracting pointers.
7399 (gobble_line): Check for overflow more carefully. Don't update size
7400 until alloc done.
7401
7402 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7403 Don't update size until alloc done.
7404 Redo size calculations to avoid overflow.
7405 Check for size calculation overflow.
0065d054 7406 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7407
7408 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7409 Use ptrdiff_t, not int, for sizes.
7410 (store_mode_line_noprop_char): Don't update size until alloc done.
7411
0065d054
PE
7412 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7413 Use ptrdiff_t, not int, for sizes.
7414 (Finternal_make_lisp_face, cache_face):
7415 Check for size calculation overflow.
7416 (cache_face): Treat size calculation overflows as if they were
7417 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7418
7419 * xfns.c (x_encode_text, x_set_name_internal)
7420 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7421 sizes, since they can exceed INT_MAX in size. Check for size
7422 calculation overflow.
7423
0065d054
PE
7424 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7425 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7426 Don't update size until alloc done.
7427
0065d054 7428 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7429 as sprintf is limited to int lengths.
1d526e2f 7430
252c5ee1
PE
7431 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7432 (X_LONG_MIN): New macros.
864d7ce7
PE
7433 Use them to make the following changes clearer.
7434 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7435 This change doesn't affect the value now, but it may help remind
7436 future maintainers not to raise the value too much later.
7437 (SELECTION_QUANTUM): Remove, replacing with ...
7438 (selection_quantum): ... new function, which avoids overflow.
7439 All uses changed.
7440 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7441 assumption that selection length fits in 'int'.
7442 (x_reply_selection_request, x_handle_selection_request)
7443 (x_get_window_property, receive_incremental_selection)
7444 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7445 (lisp_data_to_selection_data, clean_local_selection_data):
7446 Use ptrdiff_t, not int, to record length of selection.
7447 (x_reply_selection_request, x_get_window_property)
7448 (receive_incremental_selection, x_property_data_to_lisp):
7449 Redo calculations to avoid overflow.
7450 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7451 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7452 something.
7453 (x_get_window_property, receive_incremental_selection)
7454 (lisp_data_to_selection_data, x_property_data_to_lisp):
7455 Check for size-calculation overflow.
7456 (x_get_window_property, receive_incremental_selection)
7457 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7458 Don't store size until memory allocation succeeds.
7459 (x_get_window_property): Plug memory leak on memory exhaustion.
7460 Don't double-block input; malloc is safe here. Don't assume 2**34
7461 - 4 fits in unsigned long. Add an xassert to check
7462 XGetWindowProperty overflow. Be more careful about overflow
7463 calculations, and distinguish size from memory overflow better.
7464 (receive_incremental_selection): When tracing, don't assume
7465 unsigned int is less than INT_MAX.
7466 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7467 harmful) conversions of unsigned short to int.
7468 (lisp_data_to_selection_data): Don't assume that integers
7469 in the range -65535 through -1 fit in an X unsigned short.
7470 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7471 result parameters unless successful. Rely on cons_to_unsigned
7472 to report problems with elements; the old code wasn't right anyway.
7473 (x_check_property_data): Check for int overflow; we cannot use
7474 a wider type due to X limits.
7475 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7476
726e0ab1 7477 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7478
0065d054
PE
7479 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7480 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7481 (x_color_cells): Don't store size until memory allocation succeeds.
7482 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7483 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7484 (x_term_init): Don't assume length fits in int (sprintf is limited
7485 to int size).
bc18e09d 7486
ebfa62c0
PE
7487 Use ptrdiff_t for composition IDs.
7488 * character.c (lisp_string_width):
7489 * composite.c (composition_table_size, n_compositions)
7490 (get_composition_id, composition_gstring_from_id):
7491 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7492 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7493 * window.c (Frecenter):
7494 Use ptrdiff_t, not int, for composition IDs.
7495 * composite.c (get_composition_id): Check for integer overflow.
7496 * composite.h: Adjust prototypes to match the above changes.
7497
d3411f89
PE
7498 Use ptrdiff_t for hash table indexes.
7499 * category.c (hash_get_category_set):
7500 * ccl.c (ccl_driver):
7501 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7502 * coding.c (coding_system_charset_list, detect_coding_system):
7503 * coding.h (struct coding_system.id):
7504 * composite.c (get_composition_id, gstring_lookup_cache):
7505 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7506 * image.c (xpm_get_color_table_h):
7507 * lisp.h (hash_lookup, hash_put):
7508 * minibuf.c (Ftest_completion):
7509 Use ptrdiff_t for hash table indexes, not int (which is too
7510 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7511 32-bit --with-wide-int hosts).
7512
e097a6fa
PE
7513 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7514 Add a FIXME comment about memory leaks.
7515 (syms_of_charset): Don't assume xmalloc returns.
7516
5637687f
PE
7517 Don't assume that stated character widths fit in int.
7518 * character.c (Fchar_width, c_string_width, lisp_string_width):
7519 * character.h (CHAR_WIDTH):
7520 * indent.c (MULTIBYTE_BYTES_WIDTH):
7521 Use sanitize_char_width to avoid undefined and/or bad behavior
7522 with outlandish widths.
a66cfb1c 7523 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7524 now that we have two such functions. All uses changed.
7525 (sanitize_char_width): New inline function.
7526
a2271ba2
PE
7527 Don't assume that tab-width fits in int.
7528 * character.h (sanitize_width): New inline function.
7529 (SANE_TAB_WIDTH): New macro.
7530 (ASCII_CHAR_WIDTH): Use it.
7531 * indent.c (sane_tab_width): Remove. All uses replaced by
7532 SANE_TAB_WIDTH (current_buffer).
7533 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7534
18c52557
PE
7535 * fileio.c: Integer overflow issues with file modes.
7536 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7537
caeeedc1
PE
7538 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7539 Remove unreachable code.
7540 (read_hex, load_charset_map_from_file): Check for integer overflow.
7541
6df6ae42 7542 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7543 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7544 (x_send_scroll_bar_event): Likewise. Check that the size does not
7545 exceed limits imposed by XClientMessageEvent, as well as the usual
7546 ptrdiff_t and size_t limits.
7547
b13995db
PE
7548 * keyboard.c: Overflow, signedness and related fixes.
7549 (make_lispy_movement): Use same integer type in forward decl
7550 that is used in the definition.
7551 (read_key_sequence, keyremap_step):
7552 Change bufsize argument back to int, undoing my 2011-03-30 change.
7553 We prefer signed types, and int is wide enough here.
7554 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7555 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7556 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7557 length, not size_t. Use ptrdiff_t for index, not int.
7558 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7559 possibility of integer overflow.
7560
13464394
PE
7561 Overflow, signedness and related fixes for images.
7562
7563 * dispextern.h (struct it.stack[0].u.image.image_id)
7564 (struct_it.image_id, struct image.id, struct image_cache.size)
7565 (struct image_cache.used, struct image_cache.ref_count):
7566 * gtkutil.c (update_frame_tool_bar):
7567 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7568 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7569 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7570 * nsmenu.m (update_frame_tool_bar):
7571 * xdisp.c (calc_pixel_width_or_height):
7572 * xfns.c (image_cache_refcount):
7573 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7574 on typical 64-bit hosts.
7575
7576 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7577 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7578 Omit unnecessary casts to int.
7579 (parse_image_spec): Check that integers fall into 'int' range
7580 when the callers expect that.
7581 (image_ascent): Redo ascent calculation to avoid int overflow.
7582 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7583 (lookup_image): Remove unnecessary tests.
7584 (xbm_image_p): Locals are now of int, not EMACS_INT,
7585 since parse_image_check makes sure they fit into int.
7586 (png_load, gif_load, svg_load_image):
7587 Prefer int to unsigned where either will do.
7588 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7589 old tiff_error_handler and tiff_warning_handler.
7590 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7591 stack buffer overflows. It uses only the features of vsnprintf
7592 that are common to both POSIX and native Microsoft.
7593 (tiff_error_handler, tiff_warning_handler): Use it.
7594 (tiff_load, gif_load, imagemagick_load_image):
7595 Don't assume :index value fits in 'int'.
7596 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7597 (imagemagick_load_image): Check that crop parameters fit into
7598 the integer types that MagickCropImage accepts. Don't assume
7599 Vimagemagick_render_type has a nonnegative value. Don't assume
7600 size_t fits in 'long'.
7601 (gs_load): Use printmax_t to print the widest integers possible.
7602 Check for integer overflow when computing image height and width.
7603
c11821d4
EZ
76042011-08-26 Eli Zaretskii <eliz@gnu.org>
7605
7606 * xdisp.c (redisplay_window): Don't force window start if point
7607 will be invisible in the resulting window. (Bug#9324)
7608
0c95fcf7
EZ
76092011-08-25 Eli Zaretskii <eliz@gnu.org>
7610
7611 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7612 the display spec is of the form `(space ...)'.
7613 (handle_display_spec): Return the value returned by
7614 handle_single_display_spec, not just 1 or zero.
7615 (handle_single_display_spec): If the display spec is of the form
7616 `(space ...)', and specifies display in the text area, return 2
7617 rather than 1.
fee65a97 7618 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7619 accurately, and prefer exact match for point under bidi.
7620 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7621
7622 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7623 into disp_prop; all users changed.
7624
7625 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7626 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7627 for the text covered by the display property.
7628
e4ed06f1
CY
76292011-08-25 Chong Yidong <cyd@stupidchicken.com>
7630
7631 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7632 Change return value to nil.
7633 (Frecord_buffer): Delete unused function.
7634
f67cdd7f
EZ
76352011-08-24 Eli Zaretskii <eliz@gnu.org>
7636
5980d4c6
EZ
7637 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7638 buffers, return left-to-right.
8610fe8b
EZ
7639 (set_cursor_from_row): Consider candidate row a win if its glyph
7640 represents a newline and point is on that newline. Fixes cursor
7641 positioning on the newline at EOL of R2L text within L2R
7642 paragraph, and vice versa.
7643 (try_cursor_movement): Check continued rows, in addition to
7644 continuation rows. Fixes unwarranted scroll when point enters a
7645 continued line of R2L text within an L2R paragraph, or vice versa.
7646 (cursor_row_p): Consider the case of point being equal to
7647 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7648 from the end of a short line to the beginning of a continued line
7649 of R2L text within L2R paragraph.
7650 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7651 composed characters.
5980d4c6 7652
f67cdd7f
EZ
7653 * bidi.c (bidi_check_type): Use xassert.
7654 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7655 members.
7656
bca633fb
EZ
76572011-08-23 Eli Zaretskii <eliz@gnu.org>
7658
7659 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7660 a character.
7661
4a5885a7
CY
76622011-08-23 Chong Yidong <cyd@stupidchicken.com>
7663
7664 * nsfont.m (ns_otf_to_script): Fix typo.
7665
0902a04e
KH
76662011-08-22 Kenichi Handa <handa@m17n.org>
7667
7668 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7669 extra slot even if the purpose is char-code-property-table.
7670
1a2e6670
EZ
76712011-08-23 Eli Zaretskii <eliz@gnu.org>
7672
8ddde651
EZ
7673 * xdisp.c (redisplay_window): When computing centering_position,
7674 account for the height of the header line. (Bug#8874)
7675
425cc014
EZ
7676 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7677 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7678 candidate is selected by the mouse, and that candidate has a
7679 composed character under the mouse.
7680
1a2e6670
EZ
7681 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7682 coordinates reported by pos-visible-in-window-p for a composed
7683 character in column zero.
7684
8b76d6f8
SM
76852011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7686
7687 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7688
dac347dd
EZ
76892011-08-22 Eli Zaretskii <eliz@gnu.org>
7690
7691 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7692 consider it a hit if to_charpos is anywhere in the range of the
7693 composed buffer positions.
7694
e013fb34
CY
76952011-08-22 Chong Yidong <cyd@stupidchicken.com>
7696
7697 * image.c (gif_load): Don't assume that each subimage has the same
7698 dimensions as the base image. Handle disposal method that is
7699 "undefined" by the gif spec (Bug#9335).
7700
bd1ba3e8
CY
77012011-08-20 Chong Yidong <cyd@stupidchicken.com>
7702
7703 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7704 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7705
54a1215b
EZ
77062011-08-19 Eli Zaretskii <eliz@gnu.org>
7707
823564e5
EZ
7708 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7709 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7710 from an Org mode buffer to a Speedbar frame.
7711
54a1215b
EZ
7712 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7713 a composition, take its buffer position from IT->cmp_it.charpos.
7714 Fixes cursor positioning at the beginning of a line that begins
7715 with a composed character.
7716
9778ebcc
EZ
77172011-08-18 Eli Zaretskii <eliz@gnu.org>
7718
0be6ee06
EZ
7719 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7720 character bidirectional type, use STRONG_L instead. Fixes crashes
7721 in a buffer produced by `describe-categories'.
7722
9778ebcc
EZ
7723 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7724 members before the level stack, so they would be saved and
7725 restored when copying iterator state. Fixes incorrect reordering
7726 around TABs covered by display properties.
7727
156bffbe
AS
77282011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7729
6b02f655 7730 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7731
72ad093b
CY
77322011-08-17 Chong Yidong <cyd@stupidchicken.com>
7733
7734 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7735 (internal_condition_case_2, internal_condition_case_n):
7736 Remove unnecessary aborts (Bug#9081).
72ad093b 7737
35774242
EZ
77382011-08-17 Eli Zaretskii <eliz@gnu.org>
7739
7740 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7741 has no `load' handler, try opening the file locally. (Bug#9311)
7742
db76dd85
KB
77432011-08-16 Ken Brown <kbrown@cornell.edu>
7744
7745 * gmalloc.c: Expand comment.
7746
b215eee5
EZ
77472011-08-16 Eli Zaretskii <eliz@gnu.org>
7748
7749 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7750 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7751
a4579d33
KB
77522011-08-16 Ken Brown <kbrown@cornell.edu>
7753
7754 Fix memory allocation problems in Cygwin build (Bug#9273).
7755
7756 * unexcw.c ( __malloc_initialized): Declare external variable.
7757 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7758
8b76d6f8
SM
7759 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7760 New variables.
a4579d33
KB
7761 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7762 dumped emacs.
7763 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7764 in the static heap.
7765 [CYGWIN] (special_realloc): New function.
7766 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7767 requests to realloc storage in the static heap.
7768
3ebec551
PE
77692011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7770
7771 * bidi.c (bidi_initialize): Remove unused local.
7772
9fd8be00
EZ
77732011-08-15 Eli Zaretskii <eliz@gnu.org>
7774
6b02f655
SM
7775 * bidimirror.h:
7776 * biditype.h: Remove file.
7777 * makefile.w32-in ($(BLD)/bidi.$(O)):
7778 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7779
7780 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7781
7782 * chartab.c: Improve commentary for the uniprop_table API.
7783
32413314
EZ
7784 * bidi.c (bidi_paragraph_init): Support zero value of
7785 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7786 (bidi_initialize): Use uniprop_table instead of including
7787 biditype.h and bidimirror.h.
32413314 7788
9fd8be00
EZ
7789 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7790 coordinates of the iterator when restoring from ppos_it.
7791 (Bug#9296)
7792
5cf2b69b
KH
77932011-08-14 Kenichi Handa <handa@m17n.org>
7794
7795 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7796 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7797
daf17d00
EZ
77982011-08-14 Eli Zaretskii <eliz@gnu.org>
7799
7800 * xdisp.c (move_it_in_display_line_to): Don't invoke
7801 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7802 ppos_it. Fixes vertical cursor motion when line beginning is
7803 covered by an image. (Bug#9296)
7804
08e3161a
JD
78052011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7806
7807 * nsterm.h (ns_run_ascript): Declare.
7808 (NSAPP_DATA2_RUNASSCRIPT): Define.
7809
7810 * nsfns.m (as_script, as_result, as_status): New static variables.
7811 (ns_run_ascript): New function.
5e617bc2 7812 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
7813 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
7814 the event loop. Get status from as_status (Bug#7276).
7815
7816 * nsterm.m (sendEvent): If event is NSApplicationDefined and
7817 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
7818 the event loop (Bug#7276).
7819
a3720aa2
AS
78202011-08-14 Andreas Schwab <schwab@linux-m68k.org>
7821
7822 * gnutls.c (QCgnutls_bootprop_priority)
7823 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
7824 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
7825 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
7826 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
7827 (QCgnutls_bootprop_verify_hostname_error)
7828 (QCgnutls_bootprop_callbacks_verify): Rename from
7829 Qgnutls_bootprop_..., all uses changed.
7830
7831 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
7832 uses changed.
7833
0a0d27fb
PE
78342011-08-14 Paul Eggert <eggert@cs.ucla.edu>
7835
19d5c50c
PE
7836 * xfaces.c (Qframe_set_background_mode): Now static.
7837 * dispextern.h (Qframe_set_background_mode): Remove decl.
7838
0a0d27fb
PE
7839 * process.c (Fnetwork_interface_info): Declare local only if needed.
7840
377538cb
JD
78412011-08-13 Jan Djärv <jan.h.d@swipnet.se>
7842
7843 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
7844 (Fnetwork_interface_list): Allocate in increments of bytes instead
7845 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
7846 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
7847 sockaddr.
7848 (struct ifflag_def): notrailers is smart on OSX.
7849 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
7850 Get hardware address with getifaddrs if available.
7851
08fff70c
EZ
78522011-08-12 Eli Zaretskii <eliz@gnu.org>
7853
7854 * xdisp.c (iterate_out_of_display_property): xassert that
7855 IT->position is set to within IT->object's boundaries. Break from
7856 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
7857 when IT->position is set up wrongly due to some bug.
7858 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
7859 (push_display_prop): Allow GET_FROM_STRING as IT->method on
7860 entry. Force push_it to save on the stack the current
7861 buffer/string position, to be restored by pop_it. Fix flags in
7862 the iterator structure wrt the object coming from a display
7863 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
7864 properties. (Bug#9284)
7865
7be1c708 78662011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 7867
7be1c708
CY
7868 * fontset.c (fontset_get_font_group): Add proper type checks.
7869 (Bug#9172)
aac0c6e3 7870
7be1c708 78712011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 7872
7be1c708
CY
7873 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
7874 and LC_VERSION_MIN_MACOSX.
7875 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
7876 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 7877
97bb72a6
EZ
78782011-08-08 Eli Zaretskii <eliz@gnu.org>
7879
7880 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
7881 no-display-properties-and-no-overlays under bidi display.
7882 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 7883 properties and overlays.
97bb72a6 7884
d5617611
CY
78852011-08-08 Chong Yidong <cyd@stupidchicken.com>
7886
37e11a63
CY
7887 * editfns.c (Fset_time_zone_rule): Document relationship with the
7888 setenv function.
7889
d5617611
CY
7890 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
7891 the font entity extracted from the cache (Bug#8109).
7892
58872834
CY
78932011-08-07 Chong Yidong <cyd@stupidchicken.com>
7894
7895 * composite.c (autocmp_chars): Don't reset point. That is done by
7896 restore_point_unwind (Bug#5984).
7897
75bfc667
JL
78982011-08-07 Juri Linkov <juri@jurta.org>
7899
7900 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
7901 to show the arg `TIME' instead of `TIMEVAL'.
7902
d1410150
EZ
79032011-08-06 Eli Zaretskii <eliz@gnu.org>
7904
7905 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
7906 display property strides EOL and includes a newline, as in
7907 longlines-mode. (Bug#9254)
75b771e4
EZ
7908 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
7909 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
7910
7911 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
7912 is non-zero, even if the data buffer is NULL. Fixes a crash in
7913 vertical-motion with longlines-mode. (Bug#9254)
7914
35928349
EZ
79152011-08-05 Eli Zaretskii <eliz@gnu.org>
7916
ec7cc85b
EZ
7917 * bidi.c <bidi_cache_total_alloc>: Now static.
7918 (bidi_initialize): Initialize bidi_cache_total_alloc.
7919
8b76d6f8 7920 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
7921 cache. (Bug#9221)
7922
7923 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
7924 amount allocated this far in `bidi_cache_total_alloc'.
7925 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
7926 non-zero, only free the data buffer without restoring the cache
7927 contents. All callers changed.
7928
7929 * dispextern.h (bidi_unshelve_cache): Update prototype.
7930
7931 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
7932 (move_it_in_display_line, move_it_to)
7933 (move_it_vertically_backward, move_it_by_lines): Replace the call
7934 to xfree to an equivalent call to bidi_unshelve_cache.
7935 (move_it_in_display_line_to): Fix logic of returning
412b6358 7936 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 7937
e2e2423b
EZ
79382011-08-05 Eli Zaretskii <eliz@gnu.org>
7939
7940 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
7941 came from a string character with a `cursor' property. (Bug#9229)
7942
ae9e757a
JD
79432011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7944
7945 * Makefile.in (LIB_PTHREAD): New variable.
7946 (LIBES): Add LIB_PTHREAD (Bug#9216).
7947
7948 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
7949 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
7950
213bd7f2
AS
79512011-08-04 Andreas Schwab <schwab@linux-m68k.org>
7952
6b02f655 7953 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 7954
99aaf75f
JD
79552011-08-04 Jan Djärv <jan.h.d@swipnet.se>
7956
7957 * xterm.c (x_find_topmost_parent): New function.
7958 (x_set_frame_alpha): Find topmost parent window with
7959 x_find_topmost_parent and set the property there also (bug#9181).
7960 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
7961
c74e9d86
PE
79622011-08-04 Paul Eggert <eggert@cs.ucla.edu>
7963
7964 * callproc.c (Fcall_process): Avoid vfork clobbering
7965 the local vars buffer, coding_systems, current_dir.
7966
640c8776
SM
79672011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
7968
7969 * keymap.c (Fmake_composed_keymap): Move to subr.el.
7970
f26d0e4c
PE
79712011-08-03 Paul Eggert <eggert@cs.ucla.edu>
7972
8a10d76c
PE
7973 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
7974 so that it is not optimized away.
7975
f26d0e4c
PE
7976 * xdisp.c (compute_display_string_pos): Remove unused local.
7977
55439c61
EZ
79782011-08-02 Eli Zaretskii <eliz@gnu.org>
7979
7980 Fix slow cursor motion and scrolling in large buffers with
7981 selective display, like Org Mode buffers. (Bug#9218)
7982
7983 * dispextern.h (struct bidi_it): New member disp_prop_p.
7984
7985 * xdisp.c: Remove one-slot cache of display string positions.
7986 (compute_display_string_pos): Accept an additional argument
5e617bc2 7987 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
7988 for a display string or property. If found, set DISP_PROP_P
7989 non-zero.
7990
7991 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
7992 DISP_PROP_P, and pass it to compute_display_string_pos.
7993 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
7994 non-zero. All callers of bidi_fetch_char changed.
7995
fb33fa43
SM
79962011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
7997
7998 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
7999
b099e063
DM
80002010-12-03 Don March <don@ohspite.net>
8001
8002 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8003 last character M-[char] is translated to ESC [char] (bug#7541).
8004
5cc7f7af
KH
80052011-08-02 Kenichi Handa <handa@m17n.org>
8006
d0fffa3f 8007 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8008
8009 * chartab.c (uniprop_table): Make it non-static.
8010
525d5e6e
EZ
80112011-08-01 Eli Zaretskii <eliz@gnu.org>
8012
8013 * xdisp.c (forward_to_next_line_start): Accept additional argument
8014 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8015 on the newline.
8016 (reseat_at_next_visible_line_start): Use the bidi iterator state
8017 returned by forward_to_next_line_start to restore the state of
8018 it->bidi_it after backing up to previous newline. (Bug#9212)
8019
31011111
AS
80202011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8021
8022 * regex.c (re_comp): Protoize.
8023 (re_exec): Fix return type.
8024 (regexec): Fix type of `ret'. (Bug#9203)
8025
476371c4
PE
80262011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8027
e5d76069
PE
8028 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8029 This is needed if max-image-size is a floating-point number.
8030
9a79b20c
AS
80312011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8032
8033 * print.c (print_object): Print empty symbol as ##.
8034
8035 * lread.c (read1): Read ## as empty symbol.
8036
d8c2fa78
AA
80372011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8038
8039 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8040 setting frame foreground color (Bug#9175).
8041 (x_set_background_color): Likewise.
8042
ffe57a7a
AA
8043 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8044 contents (Bug#9176).
8045 (EmacsTooltip -init): Remove bezels and add shadows to
8046 tooltip windows.
8047
bf3492a5
AA
8048 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8049 or scroll bar (Bug#8470).
8050
d55e9c53
AA
8051 * nsfont.m (nsfont_open): Remove assignment to voffset and
8052 unnecessary vars hshink, expand, hd, full_height, min_height.
8053 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8054
8055 * nsterm.h (nsfont_info): Remove voffset field.
8056
d8c2fa78 80572011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8058
8059 Implement strike-through and overline on NextStep (Bug#8863).
8060
8061 * nsfont.m (nsfont_open): Use underline position provided by font,
8062 instead of hard-coded value of 2.
8063 (nsfont_draw): Call ns_draw_text_decoration instead.
8064
8065 * nsterm.h: Add declaration for ns_draw_text_decoration.
8066
8067 * nsterm.m (ns_draw_text_decoration): New function for drawing
8068 underline, overline, and strike-through.
8069 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8070 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8071 accommodate underlining, etc.
4843aac3 8072
4cc60b9b
EZ
80732011-07-28 Eli Zaretskii <eliz@gnu.org>
8074
bc7ece87
EZ
8075 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8076 default.
4cc60b9b 8077
476371c4
PE
80782011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8079
66606eea
PE
8080 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8081 Without this fix, if a signal arrives just after memory fills up,
8082 'malloc' might be invoked reentrantly.
8083
476371c4
PE
8084 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8085 In other words, assume that every image size is allowed, on non-X
8086 hosts. This assumption is probably wrong, but it lets Emacs compile.
8087
f3fcc40d
AS
80882011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8089
8090 * regex.c (re_iswctype): Convert return values to boolean.
8091
350c992f
EZ
80922011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8093
8094 * xdisp.c (compute_display_string_pos): Don't use cached display
8095 string position if the buffer had its restriction changed.
8096 (Bug#9184)
8097
5266b4bb
PE
80982011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8099
8100 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8101
2573a837 81022011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8103
41f55ccd 8104 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8105
39e378da
PE
8106 * bidi.c: Integer size and overflow fixes.
8107 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8108 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8109 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8110 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8111 (bidi_find_other_level_edge):
8112 Use ptrdiff_t instead of EMACS_INT where either will do.
8113 This works better on 32-bit hosts configured --with-wide-int.
8114 (bidi_cache_ensure_space): Check for size-calculation overflow.
8115 Use % rather than repeated addition, for better worst-case speed.
8116 Don't set bidi_cache_size until after xrealloc returns, because it
8117 might not return.
8118 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8119 (bidi_cache_ensure_space): Also check that the bidi cache size
8120 does not exceed that of the largest Lisp string or buffer. See Eli
8121 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8122
5e927815
PE
8123 * alloc.c (__malloc_size_t): Remove.
8124 All uses replaced by size_t. See Andreas Schwab's note
8125 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8126
ca4aa935
PE
8127 * image.c: Improve checking for integer overflow.
8128 (check_image_size): Assume that f is nonnull, since
8129 it is always nonnull in practice. This is one less thing to
8130 worry about when checking for integer overflow later.
8131 (x_check_image_size): New function, which checks for integer
8132 overflow issues inside X.
8133 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8134 This removes the need for a memory_full check.
8135 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8136 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8137 (xbm_read_bitmap_data): Change locals back to 'int', since
8138 their values must fit in 'int'.
8139 (xpm_load_image, png_load, tiff_load):
8140 Invoke x_create_x_image_and_pixmap earlier,
8141 to avoid much needless work if the image is too large.
8142 (tiff_load): Treat overly large images as if
8143 x_create_x_image_and_pixmap failed, not as malloc failures.
8144 (gs_load): Use x_check_image_size.
8145
5f8f9cc2
PE
8146 * gtkutil.c: Omit integer casts.
8147 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8148 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8149
5adf60bc
PE
8150 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8151
c8907a93
PE
8152 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8153 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8154 would wrongly return t on a 64-bit host.
8155
e3c25c68
PE
8156 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8157 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8158 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8159 and therefore cause GCC to emit a bogus diagnostic in some cases.
8160
3f791afe
PE
8161 * image.c: Integer signedness and overflow and related fixes.
8162 This is not an exhaustive set of fixes, but it's time to
8163 record what I've got.
8164 (lookup_pixel_color, check_image_size): Remove redundant decls.
8165 (check_image_size): Don't assume that arbitrary EMACS_INT values
8166 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8167 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8168 (tiff_load, imagemagick_load_image):
8169 Check for overflow in size calculations.
8170 (x_create_x_image_and_pixmap): Remove unnecessary test for
8171 xmalloc returning NULL; that can't happen.
8172 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8173 (xpm_color_bucket): Use better integer hashing function.
8174 (xpm_cache_color): Don't possibly over-allocate memory.
8175 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8176 (gif_memory_source):
8177 Use ptrdiff_t, not int or size_t, to record sizes.
8178 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8179 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8180 either works, as we prefer signed integers.
8181 (tiff_read_from_memory, tiff_write_from_memory):
8182 Return tsize_t, not size_t, since that's what the TIFF API wants.
8183 (tiff_read_from_memory): Don't fail simply because the read would
8184 go past EOF; instead, return a short read.
8185 (tiff_load): Omit no-longer-needed casts.
8186 (Fimagemagick_types): Don't assume size fits into 'int'.
8187
3cc5a532
PE
8188 Improve hashing quality when configured --with-wide-int.
8189 * fns.c (hash_string): New function, taken from sxhash_string.
8190 Do not discard information about ASCII character case; this
8191 discarding is no longer needed.
8192 (sxhash-string): Use it. Change sig to match it. Caller changed.
8193 * lisp.h: Declare it.
8194 * lread.c (hash_string): Remove, since we now use fns.c's version.
8195 The fns.c version returns a wider integer if --with-wide-int is
8196 specified, so this should help the quality of the hashing a bit.
8197
b312a492
PE
8198 * emacs.c: Integer overflow minor fix.
8199 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8200 Define only if GNU_LINUX.
8201 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8202
dfd153ae
PE
8203 * dispnew.c: Integer signedness and overflow fixes.
8204 Remove unnecessary forward decls, that were a maintenance hassle.
8205 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8206 All uses changed.
8207 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8208 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8209 (prepare_desired_row, line_draw_cost):
8210 Use int, not unsigned, where either works.
8211 (save_current_matrix, restore_current_matrix):
8212 Use ptrdiff_t, not size_t, where either works.
8213 (init_display): Check for overflow more accurately, and without
8214 relying on undefined behavior.
8215
a81d11a3
PE
8216 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8217 Remove, replacing with the new symbols in lisp.h. All uses changed.
8218 * fileio.c (make_temp_name):
8219 * filelock.c (lock_file_1, lock_file):
8220 * xdisp.c (message_dolog):
8221 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8222 Use pMd etc. instead.
8223 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8224 replacing the pWIDE etc. symbols removed from editfns.c.
8225
3300e6fd
PE
8226 * keyboard.h (num_input_events): Now uintmax_t.
8227 This is (very slightly) less likely to mess up due to wraparound.
8228 All uses changed.
8229
fd05c7e9
PE
8230 * buffer.c: Integer signedness fixes.
8231 (alloc_buffer_text, enlarge_buffer_text):
8232 Use ptrdiff_t rather than size_t when either will do, as we prefer
8233 signed integers.
8234
903fe15d
PE
8235 * alloc.c: Integer signedness and overflow fixes.
8236 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8237 (__malloc_size_t): Default to size_t, not to int.
8238 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8239 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8240 Prefer ptrdiff_t to size_t when either would do, as we prefer
8241 signed integers.
8242 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8243 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8244 Now const. Initialize with values that are in range even if char
8245 is signed.
8246 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8247 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8248 These functions do the right thing with sizes > 2**32.
8249 (check_depth): Now ptrdiff_t, not int.
8250 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8251 Adjust to new way of storing sizes. Check for size overflow bugs
8252 in rest of code.
8253 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8254 slightly wrong anyway, as it missed one instance of
8255 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8256 (refill_memory_reserve): Omit needless cast to size_t.
8257 (mark_object_loop_halt): Mark as externally visible.
8258
ac82cc6a
PE
8259 * xselect.c: Integer signedness and overflow fixes.
8260 (Fx_register_dnd_atom, x_handle_dnd_message):
8261 Use ptrdiff_t, not size_t, since we prefer signed.
8262 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8263 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8264 x_dnd_atoms_size and x_dnd_atoms_length.
8265
c2d1e36d
PE
8266 * doprnt.c: Prefer signed to unsigned when either works.
8267 * eval.c (verror):
8268 * doprnt.c (doprnt):
8269 * lisp.h (doprnt):
8270 * xdisp.c (vmessage):
8271 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8272 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8273 prefer signed arithmetic to avoid comparison confusion.
8274 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8275 but is a bit tricky.
8276
0e926e56
PE
8277 Assume freestanding C89 headers, string.h, stdlib.h.
8278 * data.c, doprnt.c, floatfns.c, print.c:
8279 Include float.h unconditionally.
8280 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8281 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8282 * regex.c: Likewise for stddef.h, string.h.
8283 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8284 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8285 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8286 (STDC_HEADERS): Remove obsolete defines.
8287 * sysdep.c: Include limits.h unconditionally.
8288
9cfdb3ec
PE
8289 Assume support for memcmp, memcpy, memmove, memset.
8290 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8291 * regex.c (memcmp, memcpy):
8292 Remove; we assume C89 now.
8293
8294 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8295 (__malloc_safe_bcopy): Remove; no longer needed.
8296
cf950e6b 8297 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8298 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8299 well either way, and we prefer signed to unsigned.
8300
dbf38e02
LMI
83012011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8302
8303 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8304 closes the connection while we're reading (bug#9182).
8305
d6f0886c 83062011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8307
d6f0886c
JD
8308 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8309 are specified (Bug#9168).
24e0f6b1 8310
2eb1f9e6
PE
83112011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8312
8313 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8314 Found by GCC static checking and --with-wide-int on a 32-bit host.
8315
22381272 83162011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8317
8318 * xdisp.c (compute_display_string_pos): Fix logic of caching
8319 previous display string position. Initialize cached_prev_pos to
8320 -1. Fixes slow-down at the beginning of a buffer.
8321
f25e39b4
EZ
83222011-07-24 Eli Zaretskii <eliz@gnu.org>
8323
8324 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8325 for attrs[LFACE_FONTSET_INDEX].
8326
04c4b52e
PE
83272011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8328
8329 * xml.c (parse_region): Remove unused local
8330 that was recently introduced.
8331
c1734fbd
EZ
83322011-07-23 Eli Zaretskii <eliz@gnu.org>
8333
be18c5a5
EZ
8334 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8335 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8336
c1734fbd
EZ
8337 * xdisp.c (move_it_in_display_line_to): Record the best matching
8338 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8339 exit if none of the characters scanned was an exact match.
8340 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8341 when exact match is impossible due to invisible text, and the
8342 lines are truncated.
8343
a258d627
JD
83442011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8345
8346 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8347 for OSX >= 10.7.
8348
b6d5a689
EZ
83492011-07-22 Eli Zaretskii <eliz@gnu.org>
8350
0f74f785
EZ
8351 Fix a significant slow-down of cursor motion with C-n, C-p,
8352 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8353 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8354 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8355 (next_element_from_buffer): Call compute_stop_pos_backwards to
8356 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8357 base_level_stop.
8358 (reseat): Don't look for prev_stop, as that could mean a very long
8359 run.
8360 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8361 <cached_disp_overlay_modiff>: Cache for last found display string
8362 position.
551918c1 8363 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8364 about the same buffer in the same area of character positions, and
8365 the buffer wasn't changed since the time the display string
8366 position was cached.
551918c1 8367
b2d0c91a
EZ
83682011-07-22 Eli Zaretskii <eliz@gnu.org>
8369
8370 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8371 is an integer, which is important for empty lines. (Bug#9149)
8372
043604ee
CY
83732011-07-22 Chong Yidong <cyd@stupidchicken.com>
8374
8375 * frame.c (Fmodify_frame_parameters): In tty case, update the
8376 default face if necessary (Bug#4238).
8377
da4adb04
CY
83782011-07-21 Chong Yidong <cyd@stupidchicken.com>
8379
8380 * editfns.c (Fstring_to_char): No need to explain what a character
8381 is in the docstring (Bug#6576).
8382
9abd0532
LMI
83832011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8384
8385 * xml.c (parse_region): Make sure we always return a tree.
8386
36881d16
HK
83872011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8388
8389 * xml.c (parse_region): If a document contains only comments,
8390 return that, too.
8391
1e98674d
LMI
83922011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8393
8394 * xml.c (make_dom): Return comments, too.
8395
590bd467
PE
83962011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8397
8398 Port to OpenBSD.
8399 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8400 and the surrounding thread.
8401 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8402 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8403 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8404 timer goes off.
8405 * s/openbsd.h (BROKEN_SIGIO): Define.
8406 * unexelf.c (unexec) [__OpenBSD__]:
8407 Don't update the .mdebug section of the Alpha COFF symbol table.
8408
f41628b2
LMI
84092011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8410
8411 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8412 (bug#8460).
8413
b59b67c5
PE
84142011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8415
15e3a074
PE
8416 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8417 This fixes some race conditions on the permissions of any newly
8418 created file.
8419
41bed37d
PE
8420 * alloc.c (valid_pointer_p): Use pipe, not open.
8421 This fixes some permissions issues when debugging.
8422
b59b67c5
PE
8423 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8424 If fchown fails to set both uid and gid, try to set just gid,
8425 as that is sometimes allowed. Adjust the file's mode to eliminate
8426 setuid or setgid bits that are inappropriate if fchown fails.
8427
925a6be7
SM
84282011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8429
8430 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8431 to compare Lisp_Objects.
8432 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8433 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8434 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8435
52968808
AS
84362011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8437
0a6a104b
AS
8438 * lread.c (read_integer): Unread even EOF character.
8439 (read1): Likewise. Properly record start position of symbol.
8440
52968808
AS
8441 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8442 symbol character follows.
8443
9e381cdd
PE
84442011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8445
8446 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8447 This works around a problem with the previous change to Fcopy_file.
8448 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8449 and without this change, GCC might complain about discarding
8450 fchown's return value.
8451
b5641435
JB
84522011-07-16 Juanma Barranquero <lekktu@gmail.com>
8453
8454 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8455
a8031457
PE
84562011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8457
8458 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8459
dd889327
LMI
84602011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8461
750c33f7
LMI
8462 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8463 it's used from the C level.
8464
dd889327
LMI
8465 * process.c: Use the same condition for POLL_FOR_INPUT in both
8466 keyboard.c and process.c (bug#1858).
8467
87e86684
LM
84682011-07-09 Lawrence Mitchell <wence@gmx.li>
8469
8470 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8471 (Fgnutls_boot): Use it.
8472
64348f40
AS
84732011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8474
8475 * doc.c (Fsubstitute_command_keys): Revert last change.
8476
1d698799
LMI
84772011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8478
f863868c
LMI
8479 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8480 quotes the next character, and doesn't affect other longer
8481 sequences (bug#8935).
8482
1d698799
LMI
8483 * lread.c (syms_of_lread): Clarify that is isn't only
8484 `eval-buffer' and `eval-defun' that's affected by
8485 `lexical-binding' (bug#8460).
8486
aa4b6df6
EZ
84872011-07-15 Eli Zaretskii <eliz@gnu.org>
8488
8489 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8490 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8491
5d856da6
PE
84922011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8493
ad6042bb
PE
8494 Fix minor problems found by static checking.
8495 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8496 (elsz): Now a signed constant, not a size_t var. We prefer signed
8497 types to unsigned, to avoid integer comparison confusion. Without
8498 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8499 "cannot optimize loop, the loop counter may overflow", a symptom
8500 of the confusion.
f00bbb22 8501 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8502 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8503
6468f31c
LMI
85042011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8505
49080b10
LMI
8506 * search.c (Fre_search_backward): Mention `case-fold-search' in
8507 all the re_search_* functions (bug#8138).
8508
6468f31c
LMI
8509 * keyboard.c (Fopen_dribble_file): Document when the file is
8510 closed (bug#8056).
8511
c965adc5
EZ
85122011-07-14 Eli Zaretskii <eliz@gnu.org>
8513
df9733bf
EZ
8514 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8515 bidi_cache_idx.
8516
0bb23927
EZ
8517 Support bidi reordering of display and overlay strings.
8518 * xdisp.c (compute_display_string_pos)
8519 (compute_display_string_end): Accept additional argument STRING.
8520 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8521 (reseat_to_string): Initialize bidi_it->string.s and
8522 bidi_it->string.schars.
8523 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8524 NULL (avoids a crash in bidi_paragraph_init).
8525 Initialize itb.string.lstring.
0bb23927
EZ
8526 (init_iterator): Call bidi_init_it only of a valid
8527 buffer position was specified. Initialize paragraph_embedding to
8528 L2R.
8529 (reseat_to_string): Initialize the bidi iterator.
8530 (display_string): If we need to ignore text properties of
8531 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8532 original value of -1 will not work with bidi.)
8533 (compute_display_string_pos): First arg is now struct
8534 `text_pos *'; all callers changed. Support display properties on
8535 Lisp strings.
8536 (compute_display_string_end): Support display properties on Lisp
8537 strings.
8538 (init_iterator, reseat_1, reseat_to_string): Initialize the
8539 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8540 when iterating on a string not from display properties).
640c8776
SM
8541 (compute_display_string_pos, compute_display_string_end):
8542 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8543 arrow keys.
8544 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8545 base_level_stop; instead, set base_level_stop to BEGV.
8546 Fixes crashes in vertical-motion.
0bb23927
EZ
8547 (next_element_from_buffer): Improve commentary for when
8548 the iterator is before prev_stop.
8549 (init_iterator): Initialize bidi_p from the default value of
8550 bidi-display-reordering, not from buffer-local value. Use the
8551 buffer-local value only if initializing for buffer iteration.
8552 (handle_invisible_prop): Support invisible properties on strings
8553 that are being bidi-reordered.
8554 (set_iterator_to_next): Support bidi reordering of C strings and
8555 Lisp strings.
8556 (next_element_from_string): Support bidi reordering of Lisp
8557 strings.
8558 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8559 (display_string): Support display of R2L glyph rows.
8560 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8561 (init_iterator): Don't initialize it->bidi_p for strings
8562 here.
8563 (reseat_to_string): Initialize it->bidi_p for strings here.
8564 (next_element_from_string, next_element_from_c_string)
8565 (next_element_from_buffer): Add xassert's for correspondence
8566 between IT's object being iterated and it->bidi_it.string
8567 structure.
8568 (face_before_or_after_it_pos): Support bidi iteration.
8569 (next_element_from_c_string): Handle the case of the first string
8570 character that is not the first one in the visual order.
8571 (get_visually_first_element): New function, refactored from common
8572 parts of next_element_from_buffer, next_element_from_string, and
8573 next_element_from_c_string.
8574 (tool_bar_lines_needed, redisplay_tool_bar)
8575 (display_menu_bar): Force left-to-right direction. Add a FIXME
8576 comment for making that be controlled by a user option.
8577 (push_it, pop_it): Save and restore the state of the
8578 bidi iterator. Save and restore the bidi_p flag.
8579 (pop_it): Iterate out of display property for string iteration as
8580 well.
8581 (iterate_out_of_display_property): Support iteration over strings.
8582 (handle_single_display_spec): Set up it->bidi_it for iteration
8583 over a display string, and call bidi_init_it.
8584 (handle_single_display_spec, next_overlay_string)
8585 (get_overlay_strings_1, push_display_prop): Set up the bidi
8586 iterator for displaying display or overlay strings.
8587 (forward_to_next_line_start): Don't use the shortcut if
8588 bidi-iterating.
8589 (back_to_previous_visible_line_start): If handle_display_prop
8590 pushed the iterator stack, restore the internal state of the bidi
8591 iterator by calling bidi_pop_it same number of times.
8592 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8593 and we are bidi-iterating, don't decrement the iterator position;
8594 instead, set the first_elt flag in the bidi iterator, to produce
8595 the same effect.
8596 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8597 (push_display_prop): xassert that we are iterating a buffer.
8598 (push_it, pop_it): Save and restore paragraph_embedding member.
8599 (handle_single_display_spec, next_overlay_string)
8600 (get_overlay_strings_1, reseat_1, reseat_to_string)
8601 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8602 correctly. Don't assume unibyte strings are not bidi-reordered.
8603 (compute_display_string_pos)
8604 (compute_display_string_end): Fix handling the case of C string.
8605 (push_it, pop_it): Save and restore from_disp_prop_p.
8606 (handle_single_display_spec, push_display_prop): Set the
8607 from_disp_prop_p flag.
8608 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8609 (pop_it): Call iterate_out_of_display_property only if we are
8610 popping after iteration over a string that came from a display
8611 property. Fix a typo in popping stretch info. Add an assertion
8612 for verifying that the iterator position is in sync with the bidi
8613 iterator.
8614 (handle_single_display_spec, get_overlay_strings_1)
8615 (push_display_prop): Fix initialization of paragraph direction for
8616 string when that of the parent object is not yet determined.
8617 (reseat_1): Call bidi_init_it to resync the bidi
8618 iterator with IT's position. (Bug#7616)
8619 (find_row_edges): If ROW->start.pos gives position
8620 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8621 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8622 Reset the from_disp_prop_p flag.
8623 (SAVE_IT, RESTORE_IT): New macros.
8624 (pos_visible_p, face_before_or_after_it_pos)
8625 (back_to_previous_visible_line_start)
8626 (move_it_in_display_line_to, move_it_in_display_line)
8627 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8628 (try_scrolling, redisplay_window, display_line): Use them when
8629 saving a temporary copy of the iterator and restoring it back.
8630 (back_to_previous_visible_line_start, reseat_1)
8631 (init_iterator): Empty the bidi cache "stack".
8632 (move_it_in_display_line_to): If iterator ended up at
8633 EOL, but we never saw any buffer positions smaller than
8634 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8635 motion in bidi-reordered lines.
8636 (move_it_in_display_line_to): Record prev_method and prev_pos
8637 immediately before the call to set_iterator_to_next. Fixes cursor
8638 motion in bidi-reordered lines with stretch glyphs and strings
8639 displayed in margins. (Bug#8133) (Bug#8867)
8640 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8641 TO_CHARPOS.
640c8776
SM
8642 (pos_visible_p): Support positions in bidi-reordered lines.
8643 Save and restore bidi cache.
0bb23927
EZ
8644
8645 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8646 (bidi_paragraph_info): Delete unused struct.
8647 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8648 (bidi_cache_start): New variable.
8649 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8650 to zero.
8651 (bidi_cache_fetch_state, bidi_cache_search)
8652 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8653 (bidi_cache_find, bidi_peek_at_next_level)
8654 (bidi_level_of_next_char, bidi_find_other_level_edge)
8655 (bidi_move_to_visually_next): Compare cache index with
8656 bidi_cache_start rather than with zero.
8657 (bidi_fetch_char): Accept new argument STRING; all callers
8658 changed. Support iteration over a string. Support strings with
8659 display properties. Support unibyte strings. Fix the type of
8660 `len' according to what STRING_CHAR_AND_LENGTH expects.
8661 (bidi_paragraph_init, bidi_resolve_explicit_1)
8662 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8663 (bidi_level_of_next_char, bidi_move_to_visually_next):
8664 Support iteration over a string.
0bb23927
EZ
8665 (bidi_set_sor_type, bidi_resolve_explicit_1)
8666 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8667 can now be zero (for strings); special values 0 and -1 were
8668 changed to -1 and -2, respectively.
8669 (bidi_char_at_pos): New function.
8670 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8671 Call it instead of FETCH_MULTIBYTE_CHAR.
8672 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8673 initialized to valid values.
8674 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8675 values.
8676 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8677 the test for valid cached positions. Fix the logic for looking up
8678 the sentinel state in the cache. GCPRO the Lisp string we are
8679 iterating.
8680 (bidi_push_it, bidi_pop_it): New functions.
8681 (bidi_initialize): Initialize the bidi cache start stack pointer.
8682 (bidi_cache_ensure_space): New function, refactored from part of
8683 bidi_cache_iterator_state. Don't assume the required size is just
8684 one BIDI_CACHE_CHUNK away.
8685 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8686 (bidi_count_bytes, bidi_char_at_pos): New functions.
8687 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8688 always valid if bidi_cache_idx is valid.
8689 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8690 is valid if it's going to be used.
8691 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8692 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8693 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8694 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8695 (bidi_find_other_level_edge, bidi_cache_start_stack):
8696 All variables related to cache indices are now EMACS_INT.
c965adc5 8697
0bb23927
EZ
8698 * dispextern.h (struct bidi_string_data): New structure.
8699 (struct bidi_it): New member `string'. Make flag members be 1-bit
8700 fields, and put them last in the struct.
640c8776
SM
8701 (compute_display_string_pos, compute_display_string_end):
8702 Update prototypes.
0bb23927
EZ
8703 (bidi_push_it, bidi_pop_it): Add prototypes.
8704 (struct iterator_stack_entry): New members bidi_p,
8705 paragraph_embedding, and from_disp_prop_p.
8706 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8707 (bidi_shelve_cache, bidi_unshelve_cache):
8708 Declare prototypes.
0bb23927
EZ
8709
8710 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8711 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8712 and vector-like objects.
8713
8714 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8715 cache around display iteration.
8716
8717 * window.c (Fwindow_end, window_scroll_pixel_based)
8718 (displayed_window_lines, Frecenter): Save and restore the bidi
8719 cache around display iteration.
8720
3bbd2265
LMI
87212011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8722
8723 * editfns.c (Fdelete_region): Clarify the use of the named
8724 parameters (bug#6788).
8725
adc47434
MR
87262011-07-14 Martin Rudalics <rudalics@gmx.at>
8727
8728 * indent.c (Fvertical_motion): Set and restore w->pointm when
8729 saving and restoring the window's buffer (Bug#9006).
8730
837c31f8
LMI
87312011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8732
8733 * editfns.c (Fstring_to_char): Clarify just what is returned
8734 (bug#6576). Text by Eli Zaretskii.
8735
ac389d0c
JB
87362011-07-13 Juanma Barranquero <lekktu@gmail.com>
8737
8738 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8739
0be0ce47
EZ
87402011-07-13 Eli Zaretskii <eliz@gnu.org>
8741
8742 * buffer.c (mmap_find): Fix a typo.
8743
cd18e7e3
JB
87442011-07-13 Johan Bockgård <bojohan@gnu.org>
8745
8746 Fix execution of x selection hooks.
8747 * xselect.c (Qx_lost_selection_functions)
8748 (Qx_sent_selection_functions): New vars.
8749 (syms_of_xselect): DEFSYM them.
8750 (x_handle_selection_request): Pass Qx_sent_selection_functions
8751 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8752 (x_handle_selection_clear,x_clear_frame_selections):
8753 Pass Qx_lost_selection_functions rather than
8754 Vx_lost_selection_functions to Frun_hook_with_args.
8755
47ea7f44
PE
87562011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8757
ac389d0c 8758 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8759 The old code sometimes used this field without initializing it.
8760
47ea7f44
PE
8761 * alloc.c (gc_sweep): Don't read past end of array.
8762 In theory, the old code could also have corrupted Emacs internals,
8763 though it'd be very unlikely.
8764
bc985c87
AS
87652011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8766
8767 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8768 argument. (Bug#4026)
bc985c87 8769
0cf34688
LMI
87702011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8771
b3dadd76
LMI
8772 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8773 key" (bug#4257).
8774
0cf34688
LMI
8775 * window.c (Fset_window_start): Doc fix (bug#4199).
8776 (Fset_window_hscroll): Ditto.
8777
270768cd
PE
87782011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8779
077e3dda 8780 Fix minor new problems caught by GCC 4.6.1.
270768cd 8781 * term.c (init_tty): Remove unused local.
490011a6 8782 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8783 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8784 not used otherwise.
270768cd 8785
b1f58454
CY
87862011-07-12 Chong Yidong <cyd@stupidchicken.com>
8787
8788 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8789
22b9578d
LMI
87902011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8791
6e70ab07
LMI
8792 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8793 are the mini-buffer and the echo area (bug#3320).
8794
22b9578d
LMI
8795 * term.c (init_tty): Remove support for supdup, c10 and perq
8796 terminals, which are no longer supported (bug#1482).
8797
8974cc9f
JB
87982011-07-10 Johan Bockgård <bojohan@gnu.org>
8799
8800 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8801
a560d974
JD
88022011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8803
8804 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8805 for non-popups (Bug#3642).
8806
1dae0f0a
AS
88072011-07-10 Andreas Schwab <schwab@linux-m68k.org>
8808
268c2c36 8809 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 8810 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
8811 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
8812 * cm.c (losecursor): Likewise.
1dae0f0a
AS
8813 * data.c (fmod): Likewise.
8814 * dispnew.c (swap_glyphs_in_rows): Likewise.
8815 * emacs.c (memory_warning_signal): Likewise.
8816 * floatfns.c (float_error): Likewise.
8817 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
8818 (otf_open, font_otf_capability, generate_otf_features)
8819 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
8820 Likewise.
8821 * image.c (pbm_read_file): Likewise.
8822 * indent.c (string_display_width): Likewise.
8823 * intervals.c (check_for_interval, search_for_interval)
8824 (inc_interval_count, count_intervals, root_interval)
8825 (adjust_intervals_for_insertion, make_new_interval): Likewise.
8826 * lread.c (defalias): Likewise.
268c2c36 8827 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
8828 * regex.c (set_image_of_range_1, set_image_of_range)
8829 (regex_grow_registers): Likewise.
8830 * sysdep.c (strerror): Likewise.
8831 * termcap.c (valid_filename_p, tprint, main): Likewise.
8832 * tparam.c (main): Likewise.
8833 * unexhp9k800.c (run_time_remap, save_data_space)
8834 (update_file_ptrs, read_header, write_header, calculate_checksum)
8835 (copy_file, copy_rest, display_header): Likewise.
8836 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
8837 Likewise.
8838 * xdisp.c (check_it): Likewise.
8839 * xfaces.c (register_color, unregister_color, unregister_colors):
8840 Likewise.
8841 * xfns.c (print_fontset_result): Likewise.
8842 * xrdb.c (member, fatal, main): Likewise.
8843
99033785
PE
88442011-07-10 Paul Eggert <eggert@cs.ucla.edu>
8845
8846 Fix minor problems found by static checking (Bug#9031).
8847 * chartab.c (char_table_set_range, map_sub_char_table):
8848 Remove unused locals.
8849 (uniprop_table): Now static.
8850 * composite.c (_work_char): Remove unused static var.
8851
9cb2ac56
JB
88522011-07-09 Juanma Barranquero <lekktu@gmail.com>
8853
8854 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
8855
f25661f0
JD
88562011-07-09 Jan Djärv <jan.h.d@swipnet.se>
8857
8858 * gtkutil.c (qttip_cb): Remove code without function.
8859
8278c4fe
EZ
88602011-07-09 Eli Zaretskii <eliz@gnu.org>
8861
8862 * w32.c (pthread_sigmask): New stub.
8863
1692ae2d 88642011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 8865
8a6ebd58 8866 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
8867 sigprocmask is portable only for single-threaded applications, and
8868 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
8869 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
8870 (LIBES): Use it.
8871 * callproc.c (Fcall_process):
8872 * process.c (create_process):
8873 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
8874 Use pthread_sigmask, not sigprocmask.
123403e4 8875
1b854618
JD
88762011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8877
8878 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
8879 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
8880 wrong (Bug#8591).
8881
3fe4b549
JD
88822011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8883
0ce7e563
JD
8884 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
8885 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
8886 (xg_hide_tooltip): Fix comment.
8887
3fe4b549
JD
8888 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
8889 in registerServicesMenuSendTypes.
8890 (validRequestorForSendType): Don't check ns_return_types.
8891
8892 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
8893 ns_return_type.
8894
5df75e47
JR
88952011-07-08 Jason Rumney <jasonr@gnu.org>
8896
22610910
JR
8897 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
8898 SH_SHOW for hidden windows (Bug#5482).
8899
5df75e47
JR
8900 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
8901 frame struct members of non-existent frames (Bug#6284).
8902
699c10bd
JD
89032011-07-08 Jan Djärv <jan.h.d@swipnet.se>
8904
4393663b
JD
8905 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
8906 variable firstTime not needed on OSX >= 10.6.
8907 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
8908 >= 10.5. Use setKnobProportion, setDoubleValue.
8909
8910 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
8911 (MAC_OS_X_VERSION_10_5): Define if not defined.
8912 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
8913 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
8914 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
8915
8916 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 8917 cString and lossyCString on OSX >= 10.4.
4393663b 8918
58179cce 8919 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
8920 sizeToFit on OSX >= 10.2.
8921
8922 * nsimage.m (allocInitFromFile): Don't use deprecated method
8923 bestRepresentationForDevice on OSX >= 10.6.
8924
8925 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
8926 to avoid warning.
8927
8928 * emacs.c: Declare unexec_init_emacs_zone.
8929
a63e0781
JD
8930 * nsgui.h: Fix compiler warning about gnulib redefining verify.
8931
699c10bd
JD
8932 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
8933
8934 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
8935 on svcsMenu (Bug#8842).
8936
8937 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
8938 ns_return_types.
8939 (Fns_list_services): Just return Qnil on 10.6, code not working there.
8940
8941 * nsterm.m (QUTF8_STRING): Declare.
8942 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
8943 (validRequestorForSendType): Return type is (id).
8944 Change indexOfObjectIdenticalTo to indexOfObject.
8945 Check if we have local selection before returning self (Bug#8842).
8946 (writeSelectionToPasteboard): Put local selection into paste board
8947 if we have a local selection (Bug#8842).
8948 (syms_of_nsterm): DEFSYM QUTF8_STRING.
8949
8950 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
8951 (ns_get_local_selection): Declare.
8952
54e10184
LMI
89532011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
8954
9888ff71
LMI
8955 * keymap.c (describe_map_tree): Don't insert a double newline at
8956 the end of the buffer (bug#1169) and return whether we inserted
8957 something.
8958
54e10184
LMI
8959 * callint.c (Fcall_interactively): Change "reading args" to
8960 "providing args" to try to clarify what it does (bug#1010).
8961
15fa4783
KH
89622011-07-07 Kenichi Handa <handa@m17n.org>
8963
8964 * composite.c (composition_compute_stop_pos): Ignore a static
8965 composition starting before CHARPOS (Bug#8915).
8966
8967 * xdisp.c (handle_composition_prop): Likewise.
8968
a8815b00
EZ
89692011-07-07 Eli Zaretskii <eliz@gnu.org>
8970
8971 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
8972 (Bug#9015)
8973
ef7b981d 89742011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
8975
8976 * character.h (unicode_category_t): New enum type.
8977
8978 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
8979 (Qchar_code_property_table): New variable.
8980 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
8981 (UNIPROP_COMPRESSED_FORM_P): New macros.
8982 (char_table_ascii): Uncompress the compressed values.
8983 (sub_char_table_ref): New arg is_uniprop. Callers changed.
8984 Uncompress the compressed values.
ac389d0c 8985 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
8986 (char_table_ref_and_range): Uncompress the compressed values.
8987 (sub_char_table_set): New arg is_uniprop. Callers changed.
8988 Uncompress the compressed values.
8989 (sub_char_table_set_range): Args changed. Callers changed.
8990 (char_table_set_range): Adjuted for the above change.
8991 (map_sub_char_table): Delete args default_val and parent. Add arg
8992 top. Give decoded values to a Lisp function.
640c8776 8993 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
8994 values to a Lisp function. Gcpro more variables.
8995 (uniprop_table_uncompress)
8996 (uniprop_decode_value_run_length): New functions.
8997 (uniprop_decoder, uniprop_decoder_count): New variables.
8998 (uniprop_get_decoder, uniprop_encode_value_character)
8999 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9000 New functions.
9001 (uniprop_encoder, uniprop_encoder_count): New variables.
9002 (uniprop_get_encoder, uniprop_table)
9003 (Funicode_property_table_internal, Fget_unicode_property_internal)
9004 (Fput_unicode_property_internal): New functions.
9005 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9006 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9007 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9008 char-code-property-alist.
9009
640c8776 9010 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9011 Vunicode_category_table.
9012
640c8776 9013 * font.c (font_range): Adjust for the change of
c805dec0
KH
9014 Vunicode_category_table.
9015
76b397fb
DN
90162011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9017
9018 * m/iris4d.h: Remove file, move contents ...
9019 * s/irix6-5.h: ... here.
9020
22b4128e
PE
90212011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9022
9023 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9024 * alloc.c (mark_buffer):
9025 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9026 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9027 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9028 This isn't true in general, and it's particularly not true
9029 if Emacs is configured with --with-wide-int.
9030 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9031 New macros, used in the buffer.c change.
9032
869795d6
JD
90332011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9034
9035 * xsettings.c: Use both GConf and GSettings if both are available.
9036 (store_config_changed_event): Add comment.
9037 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9038 (store_tool_bar_style_changed): New functions.
5e617bc2 9039 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9040 (struct xsettings): Move font inside HAVE_XFT.
9041 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9042 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9043 Move inside HAVE_XFT.
640c8776 9044 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9045 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9046 also.
9047 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9048 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9049 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9050 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9051 (parse_settings): Move check for font inside HAVE_XFT.
9052 (read_settings, apply_xft_settings): Add comment.
9053 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9054 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9055 call store_font_name_changed.
9056 (xft_settings_event): Add comment.
9057 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9058 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9059 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9060 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9061 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9062 (xsettings_get_system_font, xsettings_get_system_normal_font):
9063 Add comment.
869795d6 9064
d8ed26bd
PE
90652011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9066
9067 Random fixes. E.g., (random) never returned negative values.
9068 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9069 subseconds part to the entropy, as that's a bit more random.
9070 Prefer signed to unsigned, since the signedness doesn't matter and
9071 in general we prefer signed. When given a limit, use a
9072 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9073 latter isn't right if USE_2_TAGS_FOR_INTS.
9074 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9075 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9076
cabf1cac
SM
90772011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9078
9079 * textprop.c (text_property_stickiness):
9080 Obey Vtext_property_default_nonsticky.
9081 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9082 * w32fns.c (syms_of_w32fns):
9083 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9084
6e9b2be9
PE
90852011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9086
9087 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9088 This is more efficient than Ffile_directory_p and avoids a minor race.
9089
90186c68
LMI
90902011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9091
7c301272
LMI
9092 * buffer.c (Foverlay_put): Say what the return value is
9093 (bug#7835).
9094
c4f2d8d4
LMI
9095 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9096 is a directory before asking whether to use the file name
9097 (bug#7564).
ad637907
LMI
9098 (barf_or_query_if_file_exists): Make the "File is a directory"
9099 error be more correct.
c4f2d8d4 9100
90186c68
LMI
9101 * fns.c (Frequire): Remove the mention of the .gz files, since
9102 that's installation-specific, but keep the mention of
9103 `get-load-suffixes'.
9104
da64016e
PE
91052011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9106
9107 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9108 Report string overflow if the output is too long.
9109
7d47b580
JB
91102011-07-04 Juanma Barranquero <lekktu@gmail.com>
9111
a555cb87
JB
9112 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9113 (syms_of_gnutls): Remove duplicate DEFSYM for
9114 Qgnutls_bootprop_verify_hostname_error, an error for
9115 Qgnutls_bootprop_verify_error (which is no longer used).
9116
7d47b580
JB
9117 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9118 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9119 Also (re)move comments that are misplaced or no longer relevant.
9120
1e49bfab
LMI
91212011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9122
9123 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9124
1485f4c0
CY
91252011-07-03 Chong Yidong <cyd@stupidchicken.com>
9126
9127 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9128 and background color parameters if they have been changed.
9129
a9ab721e
LMI
91302011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9131
9132 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9133
cf7cff57
PE
91342011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9135
2e13213d
PE
9136 * xsettings.c (SYSTEM_FONT): Define only when used.
9137 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9138
cf7cff57
PE
9139 * keymap.c (access_keymap_1): Now static.
9140
7a8e04f7
CY
91412011-07-02 Chong Yidong <cyd@stupidchicken.com>
9142
9143 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9144 leave any prefix arg for the up event (Bug#1586).
9145
61352f62
LMI
91462011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9147
69bb1ef7
LMI
9148 * lread.c (syms_of_lread): Mention single symbols defined by
9149 `defvar' or `defconst' (bug#7154).
9150
61352f62 9151 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9152 (Frequire): Mention get-load-suffixes.
61352f62 9153
28545e04
MR
91542011-07-02 Martin Rudalics <rudalics@gmx.at>
9155
9156 * window.h (window): Remove clone_number slot.
9157 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9158 Remove.
9159 (make_parent_window, make_window, saved_window)
9160 (Fset_window_configuration, save_window_save): Don't deal with
9161 clone numbers.
9162 * buffer.c (Qclone_number): Remove declaration.
9163 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9164
3349e122
SM
91652011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9166
9167 Add multiple inheritance to keymaps.
9168 * keymap.c (Fmake_composed_keymap): New function.
9169 (Fset_keymap_parent): Simplify.
9170 (fix_submap_inheritance): Remove.
9171 (access_keymap_1): New function extracted from access_keymap to handle
9172 embedded parents and handle lists of maps.
9173 (access_keymap): Use it.
9174 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9175 (Fcopy_keymap): Handle embedded parents.
9176 (Fcommand_remapping, define_as_prefix): Simplify.
9177 (Fkey_binding): Simplify.
9178 (syms_of_keymap): Move minibuffer-local-completion-map,
9179 minibuffer-local-filename-completion-map,
9180 minibuffer-local-must-match-map, and
9181 minibuffer-local-filename-must-match-map to Elisp.
9182 (syms_of_keymap): Defsubr make-composed-keymap.
9183 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9184 (parse_menu_item): Trivial simplification.
9185
3279eb87
GM
91862011-07-01 Glenn Morris <rgm@gnu.org>
9187
9188 * Makefile.in (SETTINGS_LIBS): Fix typo.
9189
4550efdf
KI
91902011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9191
9192 * coding.c (Fencode_coding_string): Record the last coding system
9193 used, as the function doc string says (bug#8738).
9194
0949d2b6
JD
91952011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9196
9197 * xsettings.c (store_monospaced_changed): Take new font as arg and
9198 check for change against current_mono_font.
9199 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9200 (emacs_settings_constructor, emacs_settings_get_property)
9201 (emacs_settings_set_property, emacs_settings_class_init)
9202 (emacs_settings_init, gsettings_obj): Remove.
9203 (something_changedCB): New function for HAVE_GSETTINGS.
9204 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9205 with value as argument.
9206 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9207 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9208 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9209 "changed".
9210
9211 * xgselect.c: Add defined (HAVE_GSETTINGS).
9212 (xgselect_initialize): Ditto.
9213
9214 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9215 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9216 xg_select.
9217
bbc6b304
PE
92182011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9219
9220 * eval.c (struct backtrace): Simplify and port the data structure.
9221 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9222 signed bit field, as this assumption is not portable and it makes
9223 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9224 "char debug_on_exit : 1" as this is not portable either; instead,
9225 use the portable "unsigned int debug_on_exit : 1". Remove unused
9226 member evalargs. Remove obsolete comments about cc bombing out.
9227
9851bfc5
JD
92282011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9229
51bb811f 9230 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9231 Let HAVE_GSETTINGS override HAVE_GCONF.
9232 (store_monospaced_changed): New function.
9233 (EMACS_SETTINGS): A new type derived from GObject to handle
9234 GSettings notifications.
9235 (emacs_settings_constructor, emacs_settings_get_property)
9236 (emacs_settings_set_property, emacs_settings_class_init):
9237 New functions.
9238 (gsettings_client, gsettings_obj): New variables.
9239 (GSETTINGS_SCHEMA): New define.
9240 (something_changedCB): Call store_monospaced_changed.
9241 (init_gsettings): New function.
9242 (xsettings_initialize): Call init_gsettings.
9243 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9244 to NULL.
9245
640c8776 9246 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9247 GCONF_CFLAGS/LIBS.
9248
5386012d
MR
92492011-06-29 Martin Rudalics <rudalics@gmx.at>
9250
9251 * window.c (resize_root_window, grow_mini_window)
9252 (shrink_mini_window): Rename Qresize_root_window to
9253 Qwindow_resize_root_window and Qresize_root_window_vertically to
9254 Qwindow_resize_root_window_vertically.
9255
f13e0b08
PE
92562011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9257
9258 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9259
94515237
JB
92602011-06-27 Juanma Barranquero <lekktu@gmail.com>
9261
9262 * makefile.w32-in: Redesign dependencies so they reflect more
9263 clearly which files are directly included by each source file,
9264 and not through other includes.
9265
e43b6e43
MR
92662011-06-27 Martin Rudalics <rudalics@gmx.at>
9267
9268 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9269 (sort_overlays, overlay_strings): When an overlay's clone number
9270 matches the window's clone number process the overlay even if
9271 the overlay's window property doesn't match the current window.
9272
d68443dc
MR
9273 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9274 (Fwindow_hchild): Rename to Fwindow_left_child.
9275 (Fwindow_next): Rename to Fwindow_next_sibling.
9276 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9277 (resize_window_check): Rename to window_resize_check.
9278 (resize_window_apply): Rename to window_resize_apply.
9279 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9280 (Fdelete_other_windows_internal, resize_frame_windows)
9281 (Fsplit_window_internal, Fdelete_window_internal)
9282 (grow_mini_window, shrink_mini_window)
9283 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9284
c7e73be5
JD
92852011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9286
9287 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9288 (emacs_fixed_set_min_size): Remove.
9289 (emacs_fixed_new): Take frame as argument.
9290
9291 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9292 (_EmacsFixedPrivate): Remove minwidth/height.
9293 Add struct frame *f.
9294 (emacs_fixed_init): Initialize priv->f.
9295 (get_parent_class, emacs_fixed_set_min_size): Remove.
9296 (emacs_fixed_new): Set priv->f to argument.
9297 (emacs_fixed_get_preferred_width)
9298 (emacs_fixed_get_preferred_height): Use min_width/height from
9299 frames size_hint to set minimum and natural (Bug#8919).
9300 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9301 and use min_width/height from frames size_hint to set
9302 min_width/height (Bug#8919).
9303
9304 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9305 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9306 Fix indentation.
c7e73be5 9307
cf99dcf8
EZ
93082011-06-26 Eli Zaretskii <eliz@gnu.org>
9309
9310 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9311 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9312 called at ZV.
9313
029529ac
CY
93142011-06-26 Chong Yidong <cyd@stupidchicken.com>
9315
9316 * process.c (wait_reading_process_output): Bypass select if
9317 waiting for a cell while ignoring keyboard input, and input is
9318 pending. Suggested by Jan Djärv (Bug#8869).
9319
7a7ef429
PE
93202011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9321
9322 Use gnulib's dup2 module instead of rolling our own.
9323 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9324
11fdef7d 93252011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9326
9327 * dispnew.c (scrolling_window): Before scrolling, turn off a
9328 mouse-highlight in the window being scrolled.
9329
cd3520a4
JB
93302011-06-24 Juanma Barranquero <lekktu@gmail.com>
9331
9332 Move DEFSYM to lisp.h and use everywhere.
9333
9334 * character.h (DEFSYM): Move declaration...
9335 * lisp.h (DEFSYM): ...here.
9336
9337 * gnutls.c:
9338 * minibuf.c:
9339 * w32menu.c:
9340 * w32proc.c:
9341 * w32select.c: Don't include character.h.
9342
9343 * alloc.c (syms_of_alloc):
9344 * buffer.c (syms_of_buffer):
9345 * bytecode.c (syms_of_bytecode):
9346 * callint.c (syms_of_callint):
9347 * casefiddle.c (syms_of_casefiddle):
9348 * casetab.c (init_casetab_once):
9349 * category.c (init_category_once, syms_of_category):
9350 * ccl.c (syms_of_ccl):
9351 * cmds.c (syms_of_cmds):
9352 * composite.c (syms_of_composite):
9353 * dbusbind.c (syms_of_dbusbind):
9354 * dired.c (syms_of_dired):
9355 * dispnew.c (syms_of_display):
9356 * doc.c (syms_of_doc):
9357 * editfns.c (syms_of_editfns):
9358 * emacs.c (syms_of_emacs):
9359 * eval.c (syms_of_eval):
9360 * fileio.c (syms_of_fileio):
9361 * fns.c (syms_of_fns):
9362 * frame.c (syms_of_frame):
9363 * fringe.c (syms_of_fringe):
9364 * insdel.c (syms_of_insdel):
9365 * keymap.c (syms_of_keymap):
9366 * lread.c (init_obarray, syms_of_lread):
9367 * macros.c (syms_of_macros):
9368 * msdos.c (syms_of_msdos):
9369 * print.c (syms_of_print):
9370 * process.c (syms_of_process):
9371 * search.c (syms_of_search):
9372 * sound.c (syms_of_sound):
9373 * syntax.c (init_syntax_once, syms_of_syntax):
9374 * terminal.c (syms_of_terminal):
9375 * textprop.c (syms_of_textprop):
9376 * undo.c (syms_of_undo):
9377 * w32.c (globals_of_w32):
9378 * window.c (syms_of_window):
9379 * xdisp.c (syms_of_xdisp):
9380 * xfaces.c (syms_of_xfaces):
9381 * xfns.c (syms_of_xfns):
9382 * xmenu.c (syms_of_xmenu):
9383 * xsettings.c (syms_of_xsettings):
9384 * xterm.c (syms_of_xterm): Use DEFSYM.
9385
4228cf16
TZ
93862011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9387
cd3520a4 9388 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9389
7fcccf1e
PE
93902011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9391
7efb4e0e
PE
9392 Integer and buffer overflow fixes (Bug#8873).
9393
ff5844ad
PE
9394 * print.c (printchar, strout): Check for string overflow.
9395 (PRINTPREPARE, printchar, strout):
9396 Don't set size unless allocation succeeds.
9397
90532f02
PE
9398 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9399 for sizes. Check for string overflow more accurately.
9400 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9401
6d84508d
PE
9402 * macros.c: Integer and buffer overflow fixes.
9403 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9404 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9405 Use ptrdiff_t, not int, for sizes.
9406 Don't increment bufsize until after realloc succeeds.
9407 Check for size-calculation overflow.
9408 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9409
437b2cb4
PE
9410 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9411
8b9ac8b4
PE
9412 * lread.c: Integer overflow fixes.
9413 (read_integer): Radix is now EMACS_INT, not int,
9414 to improve quality of diagnostics for out-of-range radices.
9415 Calculate buffer size correctly for out-of-range radices.
9416 (read1): Check for integer overflow in radices, and in
9417 read-circle numbers.
82cb60d3
PE
9418 (read_escape): Avoid int overflow.
9419 (Fload, openp, read_buffer_size, read1)
9420 (substitute_object_recurse, read_vector, read_list, map_obarray):
9421 Use ptrdiff_t, not int, for sizes.
9422 (read1): Use EMACS_INT, not int, for sizes.
20270765 9423 Check for size overflow.
8b9ac8b4 9424
7fcccf1e
PE
9425 * image.c (cache_image): Check for size arithmetic overflow.
9426
bfbbd7e7
PE
9427 * lread.c: Integer overflow issues.
9428 (saved_doc_string_size, saved_doc_string_length)
9429 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9430 Now ptrdiff_t, not int.
9431 (read1): Don't assume doc string length fits in int. Check for
9432 out-of-range doc string lengths.
9433 (read_list): Don't assume file position fits in int.
39019e54 9434 (read_escape): Check for hex character overflow.
bfbbd7e7 9435
4e323265
LL
94362011-06-22 Leo Liu <sdl.web@gmail.com>
9437
9438 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9439 Move to minibuffer.el.
9440
85fece3e
PE
94412011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9442
20b84ce9 9443 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9444 The following patches are for when GLYPH_DEBUG && !XASSERT.
9445 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9446 * dispnew.c (flush_stdout):
9447 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9448 Mark as externally visible.
9449 * dispnew.c (check_window_matrix_pointers): Now static.
9450 * dispnew.c (window_to_frame_vpos):
9451 * xfns.c (unwind_create_frame):
9452 * xterm.c (x_check_font): Remove unused local.
9453 * scroll.c (CHECK_BOUNDS):
9454 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9455 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9456 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9457 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9458 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9459 Now static.
9460 (debug_method_add): Use va_list and vsprintf rather than relying
9461 on undefined behavior with wrong number of arguments.
9462 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9463 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9464 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9465 since we're not interested in debugging glyphs with old libraries.
9466 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9467 GCC 4.6.0's static checking.
9468
0766b489
PE
94692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9470
31fd4b32
PE
9471 Integer overflow and signedness fixes (Bug#8873).
9472 A few related buffer overrun fixes, too.
9473
b79e8648
PE
9474 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9475
0766b489
PE
9476 * dispextern.h (struct face.stipple):
9477 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9478 (x_bitmap_mask, x_allocate_bitmap_record)
9479 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9480 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9481 (x_create_bitmap_from_xpm_data):
9482 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9483 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9484 (.bitmaps_last):
9485 * xfaces.c (load_pixmap):
9486 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9487 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9488 (.bitmaps_last, struct x_output.icon_bitmap):
9489 Use ptrdiff_t, not int, for bitmap indexes.
9490 (x_allocate_bitmap_record): Check for size overflow.
9491 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9492
b081724f
PE
9493 Use ptrdiff_t, not int, for overlay counts.
9494 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9495 * editfns.c (overlays_around, get_pos_property):
9496 * textprop.c (get_char_property_and_overlay):
9497 * xdisp.c (next_overlay_change, note_mouse_highlight):
9498 * xfaces.c (face_at_buffer_position):
21514da7
PE
9499 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9500 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9501 (Fnext_overlay_change, Fprevious_overlay_change)
9502 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9503 Use ptrdiff_t, not int, for sizes.
21514da7 9504 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9505
3de73e5e
PE
9506 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9507
2606c57b
PE
9508 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9509 (x_session_initialize): Do not assume string length fits in int.
9510
aaafe47a
PE
9511 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9512 This is unlikely, but can occur if DPI is outlandish.
9513
2674ddc8 9514 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9515 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9516
28154962
PE
9517 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9518 * xrdb.c (magic_file_p, search_magic_path):
9519 Omit last arg SUFFIX; it was always 0. All callers changed.
9520 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9521
7de51af5
PE
9522 * xfont.c (xfont_match): Avoid need for strlen.
9523
25ed6cc3
PE
9524 * xfns.c: Don't assume strlen fits in int.
9525 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9526
4eab31dd
PE
9527 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9528 not unsigned long, as we prefer signed integers. All callers changed.
9529 Detect integer overflow in repeat count.
9530 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9531 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9532
171e2a58
PE
9533 * termcap.c: Don't assume sizes fit in int and never overflow.
9534 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9535 (gobble_line): Check for size-calculation overflow.
9536
ad39faca 9537 * minibuf.c (Fread_buffer):
6e5bb2dc 9538 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9539 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9540 Don't assume string length fits in int.
9541
52c61c22 9542 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9543 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9544
b5b8c9e5
PE
9545 * font.c: Don't assume string length fits in int.
9546 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9547 Use ptrdiff_t, not int.
ccd6111c
PE
9548 (font_intern_prop): Don't assume string length fits in int.
9549 Don't assume integer property fits in fixnum.
9550 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9551
882f0d81 9552 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9553 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9554 Reformulate so as not to need the command string.
9555 Invoke gzip -cd rather than gunzip, as it's more portable.
9556 (lock_info_type, lock_file_1, lock_file):
9557 Don't assume pid_t and time_t fit in unsigned long.
9558 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9559 (current_lock_owner): Prefer signed type for sizes.
9560 Use memcpy, not strncpy, where memcpy is what is really wanted.
9561 Don't assume (via atoi) that time_t and pid_t fit in int.
9562 Check for time_t and/or pid_t out of range, e.g., via a network share.
9563 Don't alloca where an auto var works fine.
9564
93f4cf88
PE
9565 * fileio.c: Fix some integer overflow issues.
9566 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9567 Don't assume string length fits in int.
9568 (directory_file_name): Don't assume string length fits in long.
9569 (make_temp_name): Don't assume pid fits in int, or that its print
9570 length is less than 20.
9571
f3e92b69
PE
9572 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9573
1bfdaf10
PE
9574 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9575
35016e9a
PE
9576 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9577
3d1e65a1
PE
9578 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9579 We prefer signed integers, even for size calculations.
9580
0b963a93
PE
9581 * emacs.c: Don't assume string length fits in 'int'.
9582 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9583 (main): Don't invoke strlen when not needed.
9584
573f4b54
PE
9585 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9586 (XD_DEBUG_MESSAGE): Don't waste a byte.
9587
989f33ba
PE
9588 * callproc.c (getenv_internal_1, getenv_internal)
9589 (Fgetenv_internal):
965d34eb
PE
9590 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9591
e4d29b33
PE
9592 * lread.c (invalid_syntax): Omit length argument.
9593 All uses changed. This doesn't fix a bug, but it simplifies the
9594 code away from its former Hollerith-constant appearance, and it's
9595 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9596 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9597
eb49b136
PE
9598 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9599 This didn't break anything, but it didn't help either.
9600 It's confusing to put a bogus integer in a place where the actual
9601 value does not matter.
9f62aeb1 9602 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9603 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9604
15375a22
PE
9605 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9606 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9607 implementation.
b61cc01c
PE
9608 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9609 We prefer signed types, and the value cannot exceed the EMACS_INT
9610 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9611 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9612 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9613 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9614
53b2623d
PE
9615 * indent.c (sane_tab_width): New function.
9616 (current_column, scan_for_column, Findent_to, position_indentation)
9617 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9618 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9619
51cab52b 9620 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9621
f2ed8a70
PE
9622 * lisp.h (lint_assume): New macro.
9623 * composite.c (composition_gstring_put_cache):
9624 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9625
abe80cc6
PE
9626 * editfns.c, insdel.c:
9627 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9628
b02c740e
PE
9629 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9630
ebc96716
PE
9631 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9632
b4e50fa0 9633 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9634 Use much-faster test for byte-length change.
311d5d7c 9635 Don't assume string byte-length fits in 'int'.
a4cf38e4 9636 Check that character arg fits in 'int'.
85461888 9637 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9638
c0c1ee9f
PE
9639 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9640
a498d7f4
PE
9641 * fns.c (concat): Catch string overflow earlier.
9642 Do not rely on integer wraparound.
9643
51cab52b
PE
9644 * dispextern.h (struct it.overlay_strings_charpos)
9645 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9646 * xdisp.c (forward_to_next_line_start)
9647 (back_to_previous_visible_line_start)
9648 (reseat_at_next_visible_line_start, next_element_from_buffer):
9649 Don't arbitrarily truncate the value of 'selective' to int.
9650
76031fad
PE
9651 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9652
5eb55db9
PE
9653 * composite.c: Don't truncate sizes to 'int'.
9654 (composition_gstring_p, composition_reseat_it)
9655 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9656 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9657 not EMACS_UINT, for indexes.
5eb55db9 9658
0703a717
PE
9659 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9660
d6202519
PE
9661 * buffer.c: Include <verify.h>.
9662 (struct sortvec.priority, struct sortstr.priority):
8961a454 9663 Now EMACS_INT, not int.
c20998a7 9664 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9665 (struct sortstr.size, record_overlay_string)
9666 (struct sortstrlist.size, struct sortlist.used):
9667 Don't truncate size to int.
9668 (record_overlay_string): Check for size-calculation overflow.
d6202519 9669 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9670
d5a19415
JM
96712011-06-22 Jim Meyering <meyering@redhat.com>
9672
029529ac 9673 Don't leak an XBM-image-sized buffer
d5a19415
JM
9674 * image.c (xbm_load): Free the image buffer after using it.
9675
a9041e6c
PE
96762011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9677
9678 Port to Sun C.
9679 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9680 that Sun C diagnosed.
9681 * fns.c (secure_hash): Fix pointer signedness issue.
9682 * intervals.c (static_offset_intervals): New function.
9683 (offset_intervals): Use it.
9684
7f3f739f
LL
96852011-06-21 Leo Liu <sdl.web@gmail.com>
9686
9687 * deps.mk (fns.o):
9688 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9689 sha512.h.
9690
9691 * fns.c (secure_hash): Rename from crypto_hash_function and change
9692 the first arg to accept symbols.
5b66d427 9693 (Fsecure_hash): New primitive.
7f3f739f
LL
9694 (syms_of_fns): New symbols.
9695
76147d94
DD
96962011-06-20 Deniz Dogan <deniz@dogan.se>
9697
9698 * process.c (Fset_process_buffer): Clarify return value in
9699 docstring.
9700
7d7d0045
CY
97012011-06-18 Chong Yidong <cyd@stupidchicken.com>
9702
9703 * dispnew.c (add_window_display_history): Use BVAR.
9704
9705 * xdisp.c (debug_method_add): Use BVAR.
9706 (check_window_end, dump_glyph_matrix, dump_glyph)
9707 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9708
9709 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9710 Likewise.
9711
9712 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9713 check till after the cache is created in init_frame_faces.
9714
ff2bc410
SM
97152011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9716
9717 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9718
28177add
PE
97192011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9720
dd3482fe
PE
9721 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9722 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9723 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9724
393d71f3 9725 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9726 * fileio.c (Finsert_file_contents):
9727 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9728 Remove the old (too-loose) buffer overflow checks.
9729 They weren't needed, since make_gap checks for buffer overflow.
9730 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9731 The old code merely checked for Emacs fixnum overflow, and relied
9732 on undefined (wraparound) behavior. The new code avoids undefined
9733 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9734
2e6813b0 9735 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9736 Tune. Don't use wider integers than needed. Don't use alloca.
9737 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9738
599a9e4f
PE
9739 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9740
99561444
PE
9741 * insdel.c, lisp.h (buffer_overflow): New function.
9742 (insert_from_buffer_1, replace_range, replace_range_2):
9743 * insdel.c (make_gap_larger):
9744 * editfns.c (Finsert_char):
9745 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9746
28177add
PE
9747 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9748
e69dafad
PE
97492011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9750
4baa020d 9751 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9752
b1c46f02
PE
9753 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9754 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9755
e69dafad
PE
9756 * fileio.c: Don't assume EMACS_INT fits in off_t.
9757 (emacs_lseek): New static function.
9758 (Finsert_file_contents, Fwrite_region): Use it.
9759 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9760
566684ea
PE
9761 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9762
e6966cd6
PE
9763 * fns.c: Don't overflow int when computing a list length.
9764 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9765 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9766 truncation on 64-bit hosts. Check for QUIT every
9767 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9768 faster and is responsive enough.
9769 (Flength): Report an error instead of overflowing an integer.
9770 (Fsafe_length): Return a float if the value is not representable
9771 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9772 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9773 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9774
dd0b0efb
PE
9775 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9776 (header_size, word_size): New constants.
9777 (allocate_vectorlike): Don't check size overflow here.
9778 (allocate_vector): Check it here instead, since this is the only
9779 caller of allocate_vectorlike that could cause overflow.
9780 Check that the new vector's length is representable as a fixnum.
9781
86fe5cfe
PE
9782 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9783 The previous code was bogus. For example, next_almost_prime (32)
9784 returned 39, which is undesirable as it is a multiple of 3; and
9785 next_almost_prime (24) returned 25, which is a multiple of 5 so
9786 why was the code bothering to check for multiples of 7?
9787
80e88859
PE
9788 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9789
4a2f0ad6
PE
9790 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9791
f66c7cf8
PE
9792 Variadic C functions now count arguments with ptrdiff_t.
9793 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9794 Back then I didn't know that the Emacs coding style prefers signed int.
9795 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9796 were being counted with int, which may truncate counts on 64-bit
9797 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9798 * lisp.h (struct Lisp_Subr.function.aMANY)
9799 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9800 Arg counts are now ptrdiff_t, not size_t.
9801 All variadic functions and their callers changed accordingly.
9802 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9803 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9804 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9805 * callint.c (Fcall_interactively): Check arg count for overflow,
9806 to avoid potential buffer overrun. Use signed char, not 'int',
9807 for 'varies' array, so that we needn't bother to check its size
9808 calculation for overflow.
9809 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
9810 * eval.c (apply_lambda):
9811 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
9812 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
9813 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
9814
a1759b76
PE
9815 * callint.c (Fcall_interactively): Don't use index var as event count.
9816
d96be9fc
PE
9817 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
9818 * mem-limits.h (SIZE): Remove; no longer used.
9819
a690a978 9820 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 9821
578c21e6
PE
9822 Remove unnecessary casts.
9823 * xterm.c (x_term_init):
9824 * xfns.c (x_set_border_pixel):
9825 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
9826 These aren't needed now that we assume ANSI C.
9827
96f53c6c
PE
9828 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
9829 It's more likely to cause problems (due to unsigned overflow)
9830 than to cure them.
9831
83c77d31
PE
9832 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
9833
ee2079f1
PE
9834 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
9835
6da65536
PE
9836 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
9837
7147c4a4
PE
9838 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
9839
193e32d9
PE
9840 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
9841
e5533da6
PE
9842 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
9843
9910e595
PE
9844 GLYPH_CODE_FACE returns EMACS_INT, not int.
9845 * dispextern.h (merge_faces):
9846 * xfaces.c (merge_faces):
01103c44
PE
9847 * xdisp.c (get_next_display_element, next_element_from_display_vector):
9848 Don't assume EMACS_INT fits in int.
9910e595 9849
2638320e
PE
9850 * character.h (CHAR_VALID_P): Remove unused parameter.
9851 * fontset.c, lisp.h, xdisp.c: All uses changed.
9852
045eb8d9
PE
9853 * editfns.c (Ftranslate_region_internal): Omit redundant test.
9854
c1f134b5
PE
9855 * fns.c (concat): Minor tuning based on overflow analysis.
9856 This doesn't fix any bugs. Use int to hold character, instead
9857 of constantly refetching from Emacs object. Use XFASTINT, not
9858 XINT, for value known to be a character. Don't bother comparing
9859 a single byte to 0400, as it's always less.
9860
395fcb93 9861 * floatfns.c (Fexpt):
327eeec8
PE
9862 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
9863
abbd3d23
PE
9864 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
9865 for characters.
9866
684a03ef
PE
9867 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
9868
0fed43f3
PE
9869 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
9870 Without this fix, on a 64-bit host (aset S 0 4294967386) would
9871 incorrectly succeed when S was a string, because 4294967386 was
9872 truncated before it was used.
9873
8fd02eb7
PE
9874 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
9875 Otherwise, an out-of-range integer could cause undefined behavior
9876 on a 64-bit host.
9877
f8c86b69
PE
9878 * composite.c: Use int, not EMACS_INT, for characters.
9879 (fill_gstring_body, composition_compute_stop_pos): Use int, not
9880 EMACS_INT, for values that are known to be in character range.
9881 This doesn't fix any bugs but is the usual style inside Emacs and
9882 may generate better code on 32-bit machines.
9883
34206dd2
PE
9884 Make sure a 64-bit char is never passed to ENCODE_CHAR.
9885 This is for reasons similar to the recent CHAR_STRING fix.
9886 * charset.c (Fencode_char): Check that character arg is actually
9887 a character. Pass an int to ENCODE_CHAR.
9888 * charset.h (ENCODE_CHAR): Verify that the character argument is no
9889 wider than 'int', as a compile-time check to prevent future regressions
9890 in this area.
9891
c5958d4c 9892 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
9893
9894 Make sure a 64-bit char is never passed to CHAR_STRING.
9895 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
9896 by silently ignoring the top 32 bits, allowing some values
9897 that were far too large to be valid characters.
9898 * character.h: Include <verify.h>.
9899 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
9900 arguments are no wider than unsigned, as a compile-time check
9901 to prevent future regressions in this area.
9902 * data.c (Faset):
01103c44 9903 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
9904 (Fsubst_char_in_region):
9905 * fns.c (concat):
9906 * xdisp.c (decode_mode_spec_coding):
9907 Adjust to CHAR_STRING's new requirement.
9908 * editfns.c (Finsert_char, Fsubst_char_in_region):
9909 * fns.c (concat): Check that character args are actually
9910 characters. Without this test, these functions did the wrong
9911 thing with wildly out-of-range values on 64-bit hosts.
9912
d37ca623
PE
9913 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
9914 These casts should not be needed on 32-bit hosts, either.
9915 * keyboard.c (read_char):
9916 * lread.c (Fload): Remove casts to unsigned.
9917
ea204efb
PE
9918 * lisp.h (UNSIGNED_CMP): New macro.
9919 This fixes comparison bugs on 64-bit hosts.
9920 (ASCII_CHAR_P): Use it.
9921 * casefiddle.c (casify_object):
01103c44 9922 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
9923 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
9924 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
9925 * dispextern.h (FACE_FROM_ID):
9926 * keyboard.c (read_char): Use UNSIGNED_CMP.
9927
41cb286c
PE
9928 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
9929 not to EMACS_INT, to avoid GCC warning.
9930
4a1b9832
PE
9931 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
9932
55daad71
PE
9933 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
9934 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
9935 isn't needed on 32-bit machines.
8f95c75c 9936
01103c44
PE
9937 * buffer.c (Fgenerate_new_buffer_name):
9938 Use EMACS_INT for count, not int.
0ceccced 9939 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
9940
9941 * data.c (Qcompiled_function): Now static.
9942
c6f072e7
PE
9943 * window.c (window_body_lines): Now static.
9944
20ce5912
PE
9945 * image.c (gif_load): Rename local to avoid shadowing.
9946
9c4c5f81
PE
9947 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
9948 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
9949 * alloc.c (make_save_value): Integer argument is now of type
9950 ptrdiff_t, not int.
9951 (mark_object): Use ptrdiff_t, not int.
9952 * lisp.h (pD): New macro.
9953 * print.c (print_object): Use it.
9954
c0c5c8ae
PE
9955 * alloc.c: Use EMACS_INT, not int, to count objects.
9956 (total_conses, total_markers, total_symbols, total_vector_size)
9957 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
9958 (total_free_floats, total_floats, total_free_intervals)
9959 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
9960 Now EMACS_INT, not int. All uses changed.
9961 (Fgarbage_collect): Compute overall total using a double, so that
9962 integer overflow is less likely to be a problem. Check for overflow
9963 when converting back to an integer.
5a25e253
PE
9964 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
9965 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
9966 These were 'int' variables that could overflow on 64-bit hosts;
9967 they were never used, so remove them instead of repairing them.
211a0b2a 9968 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
9969 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
9970 Previously, this ceilinged at INT_MAX, but that doesn't work on
9971 64-bit machines.
e46bb31a 9972 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 9973
c78baabf 9974 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 9975 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
9976 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
9977 when a (possibly-narrower) signed value would do just as well.
9978 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 9979
c9d624c6
PE
9980 * alloc.c: Catch some string size overflows that we were missing.
9981 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
9982 for convenience in STRING_BYTES_MAX.
9983 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
9984 The definition here is exact; the one in lisp.h was approximate.
9985 (allocate_string_data): Check for string overflow. This catches
9986 some instances we weren't catching before. Also, it catches
9987 size_t overflow on (unusual) hosts where SIZE_MAX <= min
9988 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
9989 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 9990
c9d624c6
PE
9991 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
9992 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 9993 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 9994
353032ce
PE
9995 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
9996
2bccce07
PE
9997 * alloc.c (Fmake_string): Check for out-of-range init.
9998
0ac30604
SM
99992011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10000
10001 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10002
c195f2de
JD
100032011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10004
10005 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10006 xg_get_default_scrollbar_width.
10007
10008 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10009 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10010 (style_changed_cb): Call update_theme_scrollbar_width and call
10011 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10012 all frames (Bug#8505).
10013 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10014 Call gtk_window_set_resizable if HAVE_GTK3.
10015 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10016 and height if HAVE_GTK3 (Bug#8505).
10017 (scroll_bar_width_for_theme): New variable.
10018 (update_theme_scrollbar_width): New function.
10019 (xg_get_default_scrollbar_width): Move code to
10020 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10021 (xg_initialize): Call update_theme_scrollbar_width.
10022
10023 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10024
10025 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10026
e10ac9f1
MR
100272011-06-12 Martin Rudalics <rudalics@gmx.at>
10028
10029 * frame.c (make_frame): Call other_buffer_safely instead of
10030 other_buffer.
10031
10032 * window.c (temp_output_buffer_show): Call display_buffer with
10033 second argument Vtemp_buffer_show_specifiers and reset latter
10034 immediately after the call.
10035 (Vtemp_buffer_show_specifiers): New variable.
10036 (auto_window_vscroll_p, next_screen_context_lines)
10037 (Vscroll_preserve_screen_position): Remove leading asterisks from
10038 doc-strings.
10039
2d3c217e 100402011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10041
7b7f97e8 10042 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10043 * buffer.c (Qclone_number): Remove for now, as it's unused.
10044 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10045 (record_buffer): Remove unused local.
10046 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10047 (set_frame_buffer_list): Remove; unused.
10048 * frame.h (other_visible_frames): Remove decl.
10049 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10050 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10051 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10052 if HAVE_GPM.
10053 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10054 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10055 Define only if HAVE_GPM.
10056 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10057 (update_hints_inhibit): Remove; never set. All uses removed.
10058 * widgetprv.h (emacsFrameClassRec): Remove decl.
10059 * window.c (delete_deletable_window): Now returns void, since it
10060 wasn't returning anything.
10061 (compare_window_configurations): Remove unused locals.
10062 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10063 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10064 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10065 the same widths as pointers. This follows up on the 2011-05-06 patch.
10066 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10067 * xterm.h: Likewise.
10068 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10069
1384b89e
JB
100702011-06-12 Juanma Barranquero <lekktu@gmail.com>
10071
10072 * makefile.w32-in: Update dependencies.
10073 (LISP_H): Add lib/intprops.h.
10074
1100a63c
CY
100752011-06-11 Chong Yidong <cyd@stupidchicken.com>
10076
10077 * image.c (gif_load): Add animation frame delay to the metadata.
10078 (syms_of_image): Use DEFSYM. New symbol `delay'.
10079
6198ccd0
MR
100802011-06-11 Martin Rudalics <rudalics@gmx.at>
10081
10082 * window.c (delete_deletable_window): Re-add.
10083 (Fset_window_configuration): Rewrite to handle dead buffers and
10084 consequently deletable windows.
10085 (window_tree, Fwindow_tree): Remove. Supply functionality in
10086 window.el.
10087 (compare_window_configurations): Simplify code.
10088
b6e3633c
AS
100892011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10090
1ab0dee5
AS
10091 * image.c (imagemagick_load_image): Fix type mismatch.
10092 (Fimagemagick_types): Likewise.
10093
b6e3633c
AS
10094 * window.h (replace_buffer_in_windows): Declare.
10095
9397e56f
MR
100962011-06-11 Martin Rudalics <rudalics@gmx.at>
10097
10098 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10099 Qclone_number. Remove external declaration of Qdelete_window.
10100 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10101 code.
640c8776
SM
10102 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10103 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10104 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10105 buffer list implementation.
10106 (other_buffer_safely): New function.
10107 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10108 calls to replace_buffer_in_windows and
10109 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10110 if allowed.
10111 (record_buffer): Inhibit quitting and rewrite using quittable
10112 functions. Run Qbuffer_list_update_hook if allowed.
10113 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10114 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10115 Move switch-to-buffer to window.el.
9397e56f
MR
10116 (bury-buffer): Move to window.el.
10117 (Vbuffer_list_update_hook): New variable.
10118
10119 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10120 section.
10121
10122 * window.h (resize_frame_windows): Move up in code.
10123 (Fwindow_frame): Remove EXFUN.
10124 (replace_buffer_in_all_windows): Remove prototype.
10125 (replace_buffer_in_windows_safely): Add prototype.
10126
10127 * window.c: Declare Qdelete_window static again. Move down
10128 declaration of select_count.
10129 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10130 (Fother_window): Move to window.el.
10131 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10132 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10133 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10134 window.el.
10135 (replace_buffer_in_windows): Implement by calling
10136 Qreplace_buffer_in_windows.
10137 (replace_buffer_in_all_windows): Remove with some functionality
10138 moved into replace_buffer_in_windows_safely.
10139 (replace_buffer_in_windows_safely): New function.
10140 (select_window_norecord, select_frame_norecord): Move in front
10141 of run_window_configuration_change_hook. Remove now obsolete
10142 declarations.
640c8776
SM
10143 (Fset_window_buffer): Rewrite doc-string.
10144 Call Qrecord_window_buffer.
9397e56f
MR
10145 (keys_of_window): Move binding for other-window to window.el.
10146
b50691aa
CY
101472011-06-11 Chong Yidong <cyd@stupidchicken.com>
10148
10149 * dispextern.h (struct image): Replace data member, whose int_val
10150 and ptr_val fields were not used by anything, with a single
10151 lisp_val object.
10152
10153 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10154 (gif_clear_image, gif_load, imagemagick_load_image)
10155 (gs_clear_image, gs_load): Callers changed.
10156
3f754b86
PE
101572011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10158
cca69397
PE
10159 * buffer.h: Include <time.h>, for time_t.
10160 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10161
109e28d0
PE
10162 Fix minor problems found by static checking.
10163
60737f02
PE
10164 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10165
4b66faf3
PE
10166 Make identifiers static if they are not used in other modules.
10167 * data.c (Qcompiled_function, Qframe, Qvector):
10168 * image.c (QimageMagick, Qsvg):
10169 * minibuf.c (Qmetadata):
10170 * window.c (resize_window_check, resize_root_window): Now static.
10171 * window.h (resize_window_check, resize_root_window): Remove decls.
10172
109e28d0
PE
10173 * window.c (window_deletion_count, delete_deletable_window):
10174 Remove; unused.
46a4ce9e
PE
10175 (window_body_lines): Now static.
10176 (Fdelete_other_windows_internal): Mark vars as initialized.
10177 Make sure 'resize_failed' is initialized.
10178 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10179 (resize_window_apply): Remove unused local.
10180 * window.h (delete_deletable_window): Remove decl.
10181
109e28d0 10182 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10183 (imagemagick_load_image): Fix pointer signedness problem by changing
10184 last arg from unsigned char * to char *. All uses changed.
10185 Also, fix a local for similar reasons.
10186 Remove unused locals. Remove locals to avoid shadowing.
10187 (fn_rsvg_handle_free): Remove; unused.
10188 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10189 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10190
3f754b86
PE
10191 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10192
2547adb1
CY
101932011-06-10 Chong Yidong <cyd@stupidchicken.com>
10194
10195 * image.c (gif_load): Fix omitted cast error introduced by
10196 2011-06-06 change.
10197
2c8e37d4
MR
101982011-06-10 Martin Rudalics <rudalics@gmx.at>
10199
10200 * window.h (resize_proportionally, orig_total_lines)
10201 (orig_top_line): Remove from window structure.
10202 (set_window_height, set_window_width, change_window_heights)
10203 (Fdelete_window): Remove prototypes.
10204 (resize_frame_windows): Remove duplicate declaration.
10205
440a42e3
EZ
102062011-06-10 Eli Zaretskii <eliz@gnu.org>
10207
10208 * window.h (resize_frame_windows, resize_window_check)
10209 (delete_deletable_window, resize_root_window)
10210 (resize_frame_windows): Declare prototypes.
10211
10212 * window.c (resize_window_apply): Make definition be "static" to
10213 match the prototype.
10214
562dd5e9
MR
102152011-06-10 Martin Rudalics <rudalics@gmx.at>
10216
10217 * window.c: Remove declarations of Qwindow_size_fixed,
10218 window_min_size_1, window_min_size_2, window_min_size,
10219 size_window, window_fixed_size_p, enlarge_window, delete_window.
10220 Remove static from declaration of Qdelete_window, it's
10221 temporarily needed by Fbury_buffer.
10222 (replace_window): Don't assign orig_top_line and
10223 orig_total_lines.
10224 (Fdelete_window, delete_window): Remove. Window deletion is
10225 handled by window.el.
640c8776
SM
10226 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10227 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10228 (Fdelete_other_windows): Remove. Deleting other windows is
10229 handled by window.el.
10230 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10231 handled in window.el.
10232 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10233 Window minimum sizes are handled in window.el.
10234 (shrink_windows, size_window, set_window_height)
10235 (set_window_width, change_window_heights, window_height)
10236 (window_width, CURBEG, CURSIZE, enlarge_window)
10237 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10238 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10239 handled in window.el.
10240 (make_dummy_parent): Rename to make_parent_window and give it a
10241 second argument horflag.
10242 (make_window): Don't set resize_proportionally any more.
10243 (Fsplit_window): Remove. Windows are split in window.el.
10244 (save_restore_action, save_restore_orig_size)
10245 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10246 Resize mini windows in window.el.
10247 (grow_mini_window, shrink_mini_window): Implement by calling
10248 Qresize_root_window_vertically, resize_window_check and
10249 resize_window_apply.
640c8776
SM
10250 (saved_window, Fset_window_configuration, save_window_save):
10251 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10252 resize_proportionally.
10253 (window_min_height, window_min_width): Move to window.el.
10254 (keys_of_window): Move bindings for delete-other-windows,
10255 split-window, delete-window and enlarge-window to window.el.
10256
10257 * buffer.c: Temporarily extern Qdelete_window.
10258 (Fbury_buffer): Temporarily call Qdelete_window instead of
10259 Fdelete_window (Fbury_buffer will move to window.el soon).
10260
10261 * frame.c (set_menu_bar_lines_1): Remove code handling
10262 orig_top_line and orig_total_lines.
10263
10264 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10265 set_window_height but set heights directly.
10266 (change_frame_size_1): Use resize_frame_windows.
10267
10268 * xdisp.c (init_xdisp): Don't use set_window_height but set
10269 heights directly.
10270
640c8776
SM
10271 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10272 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10273 run_window_configuration_change_hook.
10274
10275 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10276 instead of change_window_heights and run
10277 run_window_configuration_change_hook.
10278
1a13852e
MR
102792011-06-09 Martin Rudalics <rudalics@gmx.at>
10280
10281 * window.c (replace_window): Rename second argument REPLACEMENT to
10282 NEW. New third argument SETFLAG. Rewrite.
10283 (delete_window, make_dummy_parent): Call replace_window with
10284 third argument 1.
10285 (window_list_1): Move down in code.
10286 (run_window_configuration_change_hook): Move set_buffer part
10287 before select_frame_norecord part in order to unwind correctly.
10288 Rename count1 to count.
10289 (recombine_windows, delete_deletable_window, resize_root_window)
10290 (Fdelete_other_windows_internal)
10291 (Frun_window_configuration_change_hook, make_parent_window)
10292 (resize_window_check, resize_window_apply, Fresize_window_apply)
10293 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10294 (Fdelete_window_internal, Fresize_mini_window_internal):
10295 New functions.
1a13852e
MR
10296 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10297
f3d1777e
MR
102982011-06-08 Martin Rudalics <rudalics@gmx.at>
10299
496e208e
MR
10300 * window.h (window): Add some new members to window structure -
10301 normal_lines, normal_cols, new_total, new_normal, clone_number,
10302 splits, nest, prev_buffers, next_buffers.
10303 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10304 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10305
f3d1777e
MR
10306 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10307 Remove.
496e208e
MR
10308 (make_dummy_parent): Set new members of windows structure.
10309 (make_window): Move down in code. Handle new members of window
10310 structure.
10311 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10312 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10313 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10314 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10315 (Fset_window_next_buffers, Fset_window_clone_number):
10316 New functions.
496e208e
MR
10317 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10318 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10319 Doc-string fixes.
10320 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10321 Argument WINDOW can be now internal window too.
10322 (Fwindow_use_time): Move up in code.
10323 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10324 Rewrite doc-string.
10325 (Fset_window_configuration, saved_window)
10326 (Fcurrent_window_configuration, save_window_save): Handle new
10327 members of window structure.
b9e809c2
MR
10328 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10329 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10330 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10331 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10332 Qget_mru_window, Qresize_root_window,
10333 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10334 Qauto_buffer_name; staticpro them.
f3d1777e 10335
abde8f8c
MR
103362011-06-07 Martin Rudalics <rudalics@gmx.at>
10337
10338 * window.c (Fwindow_total_size, Fwindow_left_column)
10339 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10340 (Fwindow_list_1): New functions.
10341 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10342 (Fwindow_width, Fscroll_left, Fscroll_right):
10343 Use window_body_cols instead of window_box_text_cols.
10344 (delete_window, Fset_window_configuration):
10345 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10346 (delete_all_subwindows): Take a window as argument and not a
10347 structure. Rewrite.
190b47e6
MR
10348 (window_loop): Remove handling of GET_LRU_WINDOW and
10349 GET_LARGEST_WINDOW.
10350 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10351
10352 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10353 window_box_text_cols. delete_all_subwindows now takes a
10354 Lisp_Object as argument.
abde8f8c 10355
640c8776
SM
10356 * indent.c (compute_motion, Fcompute_motion):
10357 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10358
fa8a67e6
MR
10359 * frame.c (delete_frame): Call delete_all_subwindows with root
10360 window as argument.
10361
a54e3482
DC
103622011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10363
10364 * fns.c (Fputhash): Document return value.
10365
60002bf5
CY
103662011-06-06 Chong Yidong <cyd@stupidchicken.com>
10367
10368 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10369
0c671da6 103702011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10371
b862a52a 10372 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10373
be44ca6c
PE
10374 Check for overflow when converting integer to cons and back.
10375 * charset.c (Fdefine_charset_internal, Fdecode_char):
10376 Use cons_to_unsigned to catch overflow.
10377 (Fencode_char): Use INTEGER_TO_CONS.
10378 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10379 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10380 * data.c (long_to_cons, cons_to_long): Remove.
10381 (cons_to_unsigned, cons_to_signed): New functions.
10382 These signal an error for invalid or out-of-range values.
10383 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10384 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10385 * font.c (Ffont_variation_glyphs):
10386 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10387 * lisp.h: Include <intprops.h>.
10388 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10389 (cons_to_signed, cons_to_unsigned): New decls.
10390 (long_to_cons, cons_to_long): Remove decls.
10391 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10392 (Fprimitive_undo): Use CONS_TO_INTEGER.
10393 * xfns.c (Fx_window_property): Likewise.
10394 * xselect.c: Include <limits.h>.
10395 (x_own_selection, selection_data_to_lisp_data):
10396 Use INTEGER_TO_CONS.
10397 (x_handle_selection_request, x_handle_selection_clear)
10398 (x_get_foreign_selection, Fx_disown_selection_internal)
10399 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10400 (lisp_data_to_selection_data): Use cons_to_unsigned.
10401 (x_fill_property_data): Use cons_to_signed.
10402 Report values out of range.
10403
d1f3d2af
PE
10404 Check for buffer and string overflow more precisely.
10405 * buffer.h (BUF_BYTES_MAX): New macro.
10406 * lisp.h (STRING_BYTES_MAX): New macro.
10407 * alloc.c (Fmake_string):
10408 * character.c (string_escape_byte8):
10409 * coding.c (coding_alloc_by_realloc):
10410 * doprnt.c (doprnt):
10411 * editfns.c (Fformat):
10412 * eval.c (verror):
10413 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10414 since they may not be the same number.
10415 * editfns.c (Finsert_char):
10416 * fileio.c (Finsert_file_contents):
10417 Likewise for BUF_BYTES_MAX.
10418
dd52fcea
PE
10419 * image.c: Use ptrdiff_t, not int, for sizes.
10420 (slurp_file): Switch from int to ptrdiff_t.
10421 All uses changed.
10422 (slurp_file): Check that file size fits in both size_t (for
10423 malloc) and ptrdiff_t (for sanity and safety).
10424
7f9bbdbb
PE
10425 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10426 if b->modtime has its maximal value.
10427
dfe18f82
PE
10428 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10429
84acfcf0
PE
10430 Don't assume time_t can fit into int.
10431 * buffer.h (struct buffer.modtime): Now time_t, not int.
10432 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10433 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10434
ccd9a01a
PE
10435 Minor fixes for signed vs unsigned integers.
10436 * character.h (MAYBE_UNIFY_CHAR):
10437 * charset.c (maybe_unify_char):
10438 * keyboard.c (read_char, reorder_modifiers):
10439 XINT -> XFASTINT, since the integer must be nonnegative.
10440 * ftfont.c (ftfont_spec_pattern):
10441 * keymap.c (access_keymap, silly_event_symbol_error):
10442 XUINT -> XFASTINT, since the integer must be nonnegative.
10443 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10444 since it makes no difference and we prefer signed.
10445 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10446 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10447 nonnegative.
10448
d6d100dd
SM
104492011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10450
10451 * window.h (Fwindow_frame): Declare.
10452
2b6148e4
PE
104532011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10454
10455 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10456 (SPARE_MEMORY): Always define.
10457 (LARGE_REQUEST): Remove.
10458 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10459
f230ecc9
MR
104602011-06-06 Martin Rudalics <rudalics@gmx.at>
10461
727e958e
MR
10462 * lisp.h: Move EXFUNS for Fframe_root_window,
10463 Fframe_first_window and Fset_frame_selected_window to window.h.
10464
10465 * window.h: Move EXFUNS for Fframe_root_window,
10466 Fframe_first_window and Fset_frame_selected_window here from
10467 lisp.h.
10468
10469 * frame.c (Fwindow_frame, Fframe_first_window)
10470 (Fframe_root_window, Fframe_selected_window)
10471 (Fset_frame_selected_window): Move to window.c.
10472 (Factive_minibuffer_window): Move to minibuf.c.
10473 (Fother_visible_frames_p): New function.
10474
10475 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10476
f230ecc9
MR
10477 * window.c (decode_window, decode_any_window): Move up in code.
10478 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10479 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10480 (Fwindow_buffer): Move up and rewrite doc-string.
10481 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10482 (Fwindow_prev): New functions.
727e958e
MR
10483 (Fwindow_frame): Move here from frame.c. Accept any window as
10484 argument.
10485 (Fframe_root_window, Fframe_first_window)
10486 (Fframe_selected_window): Move here from frame.c. Accept frame
10487 or arbitrary window as argument. Update doc-strings.
10488 (Fminibuffer_window): Move up in code.
10489 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10490 (Fset_frame_selected_window): Move here from frame.c.
10491 Marginal rewrite.
727e958e
MR
10492 (Fselected_window, select_window, Fselect_window): Move up in
10493 code. Minor doc-string fixes.
f230ecc9 10494
4d09bcf6
PE
104952011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10496
10497 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10498 Do not assume that spare memory exists; that assumption is valid
10499 only if SYSTEM_MALLOC.
10500 (LARGE_REQUEST): New macro, so that the issue of large requests
10501 is separated from the issue of spare memory.
10502
810928a2
AS
105032011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10504
172418ad
AS
10505 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10506 format. (Bug#8806)
10507
43f862f7
AS
10508 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10509
810928a2
AS
10510 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10511 before statements.
10512
a059fe24
JD
105132011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10514
10515 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10516
10517 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10518
10519 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10520 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10521
989bf368
JB
105222011-06-05 Juanma Barranquero <lekktu@gmail.com>
10523
10524 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10525
4b80f674
CY
105262011-06-04 Chong Yidong <cyd@stupidchicken.com>
10527
10528 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10529 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10530 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10531 New error handlers.
4b80f674
CY
10532 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10533 Obey Vx_select_enable_clipboard_manager. Catch errors in
10534 x_clipboard_manager_save (Bug#8779).
10535 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10536 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10537
99a33b77 105382011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10539
10540 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10541
99a33b77 105422011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10543
10544 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10545 in the current matrix if keep_current_p is non-zero.
10546
8264569d
EZ
105472011-06-04 Eli Zaretskii <eliz@gnu.org>
10548
10549 * bidi.c (bidi_level_of_next_char): Fix last change.
10550
57f97249
EZ
105512011-06-03 Eli Zaretskii <eliz@gnu.org>
10552
fec2107c 10553 Support bidi reordering of text covered by display properties.
57f97249 10554
fec2107c
EZ
10555 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10556 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10557 (bidi_cache_search, bidi_cache_iterator_state)
10558 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10559 (bidi_level_of_next_char, bidi_move_to_visually_next):
10560 Support character positions inside a run of characters covered by a
fec2107c
EZ
10561 display string.
10562 (bidi_paragraph_init, bidi_resolve_explicit_1)
10563 (bidi_level_of_next_char): Call bidi_fetch_char and
10564 bidi_fetch_char_advance instead of FETCH_CHAR and
10565 FETCH_CHAR_ADVANCE.
10566 (bidi_init_it): Initialize new members.
10567 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10568 definitions.
10569 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10570 instead of using explicit *_CHAR codes.
d6d100dd
SM
10571 (bidi_resolve_explicit, bidi_resolve_weak):
10572 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10573 bidirectional text is supported only in multibyte buffers.
10574 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10575 it to initialize the frame_window_p member of struct bidi_it.
10576 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10577 (bidi_resolve_explicit, bidi_resolve_weak)
10578 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10579 bidi_it->nchars is non-positive.
10580 (bidi_level_of_next_char): Don't try to lookup the cache for the
10581 next/previous character if nothing is cached there yet, or if we
10582 were just reseat()'ed to a new position.
c40e2fb2 10583
0e14fe90
EZ
10584 * xdisp.c (set_cursor_from_row): Set start and stop points
10585 according to the row's direction when priming the loop that looks
10586 for the glyph on which to display cursor.
10587 (single_display_spec_intangible_p): Function deleted.
10588 (display_prop_intangible_p): Reimplement to call
10589 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10590 Accept 3 additional arguments needed by handle_display_spec.
10591 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10592 values: lists, `(when COND...)' forms, etc.
10593 (single_display_spec_string_p): Support property values that are
10594 lists with the argument STRING its top-level element.
10595 (display_prop_string_p): Fix the condition for processing a
10596 property that is a list to be consistent with handle_display_spec.
fec2107c 10597 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10598 last portion of handle_display_prop.
10599 (compute_display_string_pos): Accept additional argument
10600 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10601 value of a `display' property is a "replacing spec".
10602 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10603 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10604 the display property, but just return a value indicating whether
10605 the display property will replace the characters it covers.
10606 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10607 frame_window_p members of struct bidi_it.
d6d100dd
SM
10608 (compute_display_string_pos, compute_display_string_end):
10609 New functions.
fec2107c
EZ
10610 (push_it): Accept second argument POSITION, where pop_it should
10611 jump to continue iteration.
10612 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10613
fec2107c
EZ
10614 * keyboard.c (adjust_point_for_property): Adjust the call to
10615 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10616
10617 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10618 (bidi_init_it): Update prototypes.
10619 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10620 (compute_display_string_pos, compute_display_string_end):
10621 Declare prototypes.
fec2107c
EZ
10622 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10623 EMACS_INT.
fc6f18ce 10624
40087514 106252011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10626
57f53182
PE
10627 Malloc failure behavior now depends on size of allocation.
10628 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10629 * lisp.h: Change signatures accordingly.
10630 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10631 All callers changed. (Bug#8762)
10632
10633 * gnutls.c: Use Emacs's memory allocators.
10634 Without this change, the gnutls library would invoke malloc etc.
10635 directly, which causes problems on non-SYNC_INPUT hosts, and which
10636 runs afoul of improving memory_full behavior. (Bug#8761)
10637 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10638 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10639 xfree instead of the default malloc, realloc, free.
10640 (Fgnutls_boot): No need to check for memory allocation failure,
10641 since xmalloc does that for us.
10642
ac32cd99 10643 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10644 * category.c (hash_get_category_set):
10645 * ccl.c (ccl_driver):
10646 * charset.c (Fdefine_charset_internal):
10647 * charset.h (struct charset.hash_index):
10648 * composite.c (get_composition_id, gstring_lookup_cache)
10649 (composition_gstring_put_cache):
10650 * composite.h (struct composition.hash_index):
10651 * dispextern.h (struct image.hash):
10652 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10653 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10654 (hashfn_equal, hashfn_user_defined, make_hash_table)
10655 (maybe_resize_hash_table, hash_lookup, hash_put)
10656 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10657 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10658 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10659 * image.c (make_image, search_image_cache, lookup_image)
10660 (xpm_put_color_table_h):
10661 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10662 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10663 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10664 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10665 * alloc.c (allocate_vectorlike):
10666 Check for overflow in vector size calculations.
10667 * ccl.c (ccl_driver):
10668 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10669 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10670 need to be updated by these changes.
40087514
PE
10671 * fns.c (make_hash_table, maybe_resize_hash_table):
10672 Check for integer overflow with large hash tables.
0de4bb68
PE
10673 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10674 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10675 (SXHASH_REDUCE): New macro.
10676 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10677 Use it instead of discarding useful hash info with large hash values.
10678 (sxhash_float): New function.
10679 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10680 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10681 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10682 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10683 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10684 Adjust signatures to match updated version of code.
10685 (consing_since_gc): Now EMACS_INT, since a single hash table can
10686 use more than INT_MAX bytes.
10687
698d32e2
DN
106882011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10689
10690 Make it possible to build with GCC-4.6+ -O2 -flto.
10691
10692 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10693
fd6fa53f
SM
106942011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10695
10696 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10697 Call minibuffer-inactive-mode.
10698
864db017
JB
106992011-05-31 Juanma Barranquero <lekktu@gmail.com>
10700
10701 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10702 Update dependencies.
10703
2ad0baf4
DN
107042011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10705
10706 * data.c (init_data): Remove code for UTS, this system is not
10707 supported anymore.
10708
4fcc2638
DN
107092011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10710
10711 Don't force ./temacs to start in terminal mode.
10712
10713 * frame.c (make_initial_frame): Initialize faces in all cases, not
10714 only when CANNOT_DUMP is defined.
10715 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10716
c56e0fd5
DN
107172011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10718
10719 * dispnew.c (add_window_display_history): Use const for the string
10720 pointer. Remove declaration, not needed.
10721
333d54da 107222011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10723
55d4c1b2 10724 Use 'inline', not 'INLINE'.
333d54da 10725 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10726 * alloc.c, fontset.c (INLINE): Remove.
10727 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10728 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10729 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10730 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10731 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10732
738db178
DN
107332011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10734
10735 Make it possible to run ./temacs.
10736
10737 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10738 syms_of_callproc does the same thing. Remove test for
10739 "initialized", do it in the caller.
10740 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10741
620c53a6
SM
107422011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10743
10744 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10745 (read_minibuf): Use get_minibuffer.
10746 (syms_of_minibuf): Use DEFSYM.
10747 (Qmetadata): New var.
10748 * data.c (Qbuffer): Don't make it static.
10749 (syms_of_data): Use DEFSYM.
10750
e003a292
PE
107512011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10752
10753 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10754 (CCL_CODE_MIN): New macro.
10755
ed008a6d
PE
107562011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10757
3687c2ef
PE
10758 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10759
ed008a6d
PE
10760 * eval.c (Qdebug): Now static.
10761 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10762 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10763 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10764
d66c4c7c
CY
107652011-05-29 Chong Yidong <cyd@stupidchicken.com>
10766
10767 * image.c: Various fixes to ImageMagick code comments.
10768 (Fimagemagick_types): Doc fix.
10769
5fbc2025
PE
107702011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10771
0196f88a
PE
10772 Minor fixes prompted by GCC 4.6.0 warnings.
10773
10774 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10775
5fbc2025
PE
10776 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10777 (x_clipboard_manager_save_all): Move extern decl to ...
10778 * xterm.h: ... here, so that it can be checked for consistency.
10779
1dd3c2d9
CY
107802011-05-29 Chong Yidong <cyd@stupidchicken.com>
10781
10782 * xselect.c (x_clipboard_manager_save_frame)
10783 (x_clipboard_manager_save_all): New functions.
10784 (Fx_clipboard_manager_save): Lisp function deleted.
10785
10786 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10787 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10788
10789 * xterm.h: Update prototype.
10790
5ba6571d
WX
107912011-05-28 William Xu <william.xwl@gmail.com>
10792
10793 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10794 exiting (Bug#8239).
10795
3eaff834
JM
107962011-05-28 Jim Meyering <meyering@redhat.com>
10797
e1900994 10798 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10799 * fns.c (to_uchar): Define.
10800 (crypto_hash_function): Use it to convert some newly-signed
10801 variables to unsigned, to avoid sign-extension bugs. For example,
10802 without this change, (md5 "truc") would evaluate to
10803 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10804 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10805 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10806
0f6990a7
PE
108072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10808
10809 Integer overflow fixes.
c8a9ca5a 10810
08686060
PE
10811 * dbusbind.c: Serial number integer overflow fixes.
10812 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
10813 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
10814 to hold a serial number that is too large for a fixnum.
10815 (Fdbus_method_return_internal, Fdbus_method_error_internal):
10816 Check for serial numbers out of range. Decode any serial number
59568bf0 10817 that was so large that it became a float. (Bug#8722)
08686060 10818
2d1fc3c7
PE
10819 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
10820 (Fdbus_call_method, Fdbus_call_method_asynchronously):
10821 Use XFASTINT rather than XUINT when numbers are nonnegative.
10822 (xd_append_arg, Fdbus_method_return_internal):
10823 (Fdbus_method_error_internal): Likewise. Also, for unsigned
10824 arguments, check that Lisp number is nonnegative, rather than
59568bf0 10825 silently wrapping negative numbers around. (Bug#8722)
30217ff0 10826 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 10827 (Bug#8722)
2d1fc3c7 10828
c8a9ca5a
PE
10829 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
10830
519e1d69
PE
10831 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
10832
6df6ae42 10833 ccl: Add integer overflow checks.
30569699
PE
10834 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
10835 (IN_INT_RANGE): New macros.
10836 (ccl_driver): Use them to check for integer overflow when
10837 decoding a CCL program. Many of the new checks are whether XINT (x)
10838 fits in int; it doesn't always, on 64-bit hosts. The new version
10839 doesn't catch all possible integer overflows, but it's an
847044ea 10840 improvement. (Bug#8719)
30569699 10841
c11285dc
PE
10842 * alloc.c (make_event_array): Use XINT, not XUINT.
10843 There's no need for unsigned here.
10844
fdccd48e
PE
10845 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
10846 This follows up to the 2011-05-06 change that substituted uintptr_t
10847 for EMACS_INT. This case wasn't caught back then.
10848
37910ab2
PE
10849 Rework Fformat to avoid integer overflow issues.
10850 * editfns.c: Include <float.h> unconditionally, as it's everywhere
10851 now (part of C89). Include <verify.h>.
10852 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
10853 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
10854 (Fformat): Avoid the prepass trying to compute sizes; it was only
10855 approximate and thus did not catch overflow reliably. Instead, walk
10856 through the format just once, formatting and computing sizes as we go,
10857 checking for integer overflow at every step, and allocating a larger
10858 buffer as needed. Keep track separately whether the format is
10859 multibyte. Keep only the most-recently calculated precision, rather
10860 than them all. Record whether each argument has been converted to
10861 string. Use EMACS_INT, not int, for byte and char and arg counts.
10862 Support field widths and precisions larger than INT_MAX. Avoid
10863 sprintf's undefined behavior with conversion specifications such as %#d
10864 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
10865 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
10866 formatting out-of-range floating point numbers with int
9173deec 10867 formats. (Bug#8668)
37910ab2 10868
2e6578fb
PE
10869 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
10870
0ae6bdee
PE
10871 * data.c: Avoid integer truncation in expressions involving floats.
10872 * data.c: Include <intprops.h>.
10873 (arith_driver): When there's an integer overflow in an expression
10874 involving floating point, convert the integers to floating point
10875 so that the resulting value does not suffer from catastrophic
10876 integer truncation. For example, on a 64-bit host (* 4
10877 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
10878 Do not rely on undefined behavior after integer overflow.
10879
de883a70
PE
10880 merge count_size_as_multibyte, parse_str_to_multibyte
10881 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 10882 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
10883 Check for integer overflow.
10884 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
10885 since it's now a duplicate of the other. This is more of
10886 a character than a buffer op, so better that it's in character.c.
10887 * fns.c, print.c: Adjust to above changes.
10888
2ff916cb
PE
108892011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
10890
10891 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
10892
f1b54466
PE
108932011-05-27 Paul Eggert <eggert@cs.ucla.edu>
10894
fb1ac845
PE
10895 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10896 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
10897 (x_clipboard_manager_save): Now static.
10898 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
10899
f1b54466
PE
10900 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
10901 (crypto_hash_function): Now static.
10902 Fix pointer signedness problems. Avoid unnecessary initializations.
10903
a9f737ee
CY
109042011-05-27 Chong Yidong <cyd@stupidchicken.com>
10905
10906 * termhooks.h (Vselection_alist): Make it terminal-local.
10907
10908 * terminal.c (create_terminal): Initialize it.
10909
10910 * xselect.c: Support for clipboard managers.
10911 (Vselection_alist): Move to termhooks.h as terminal-local var.
10912 (LOCAL_SELECTION): New macro.
10913 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
10914 (symbol_to_x_atom): Remove gratuitous arg.
10915 (x_handle_selection_request, lisp_data_to_selection_data)
10916 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
10917 (x_own_selection, x_get_local_selection, x_convert_selection):
10918 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
10919 (some_frame_on_display): Delete unused function.
10920 (Fx_own_selection_internal, Fx_get_selection_internal)
10921 (Fx_disown_selection_internal, Fx_selection_owner_p)
10922 (Fx_selection_exists_p): New optional frame arg.
10923 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
10924 (x_handle_selection_clear): Don't treat other terminals with the
10925 same keyboard specially. Use the terminal-local Vselection_alist.
10926 (x_clear_frame_selections): Use Frun_hook_with_args.
10927
10928 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
10929
10930 * xterm.h: Add support for those atoms.
10931
e067f0c1
CY
109322011-05-26 Chong Yidong <cyd@stupidchicken.com>
10933
10934 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
10935 (converted_selections, conversion_fail_tag): New global variables.
10936 (x_selection_request_lisp_error): Free the above.
10937 (x_get_local_selection): Remove unnecessary code.
10938 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
10939 of converted selections stored in converted_selections.
10940 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
10941 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
10942 (x_convert_selection): New function.
10943 (x_handle_selection_event): Simplify.
10944 (x_get_foreign_selection): Don't ignore incoming requests while
10945 waiting for an answer; this will fail when we implement
10946 SAVE_TARGETS, and seems unnecessary anyway.
10947 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
10948 (Vx_sent_selection_functions): Doc fix.
10949
0f4aebc0
LL
109502011-05-26 Leo Liu <sdl.web@gmail.com>
10951
10952 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
10953
e61124cd
YM
109542011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
10955
10956 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
10957
10958 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
10959 for fringe update if it has periodic bitmap.
ac389d0c 10960 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
10961 and fringe_bitmap_periodic_p.
10962
10963 * fringe.c (get_fringe_bitmap_data): New function.
10964 (draw_fringe_bitmap_1, update_window_fringes): Use it.
10965 (update_window_fringes): Record periodicity of fringe bitmap in glyph
10966 row. Mark glyph row for fringe update if periodicity changed.
10967
10968 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
10969 for fringe update unless it has periodic bitmap.
10970
f16d9837
KH
109712011-05-25 Kenichi Handa <handa@m17n.org>
10972
10973 * xdisp.c (get_next_display_element): Set correct it->face_id for
10974 a static composition.
10975
e1b90ef6
LL
109762011-05-24 Leo Liu <sdl.web@gmail.com>
10977
10978 * deps.mk (fns.o):
10979 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
10980
10981 * fns.c (crypto_hash_function, Fsha1): New function.
10982 (Fmd5): Use crypto_hash_function.
10983 (syms_of_fns): Add Ssha1.
10984
7400048f
PE
109852011-05-22 Paul Eggert <eggert@cs.ucla.edu>
10986
10987 * gnutls.c: Remove unused macros.
10988 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
10989 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
10990 Remove macros that are defined and never used.
10991 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
10992
abb71cf4
CY
109932011-05-22 Chong Yidong <cyd@stupidchicken.com>
10994
10995 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
10996 (Fx_get_selection_internal): Minor cleanup.
10997 (Fx_own_selection_internal): Rename arguments for consistency with
10998 select.el.
10999
6307db39
PE
110002011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11001
11002 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11003
f3d4e0a4
CY
110042011-05-22 Chong Yidong <cyd@stupidchicken.com>
11005
11006 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11007
4d8ade89
YM
110082011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11009
11010 * dispnew.c (scrolling_window): Don't exclude the case that the
11011 last enabled row in the desired matrix touches the bottom boundary.
11012
32078c8d
GM
110132011-05-21 Glenn Morris <rgm@gnu.org>
11014
11015 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11016 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11017 and add some more files.
32078c8d 11018
7285dc67
EZ
110192011-05-20 Eli Zaretskii <eliz@gnu.org>
11020
11021 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11022 report_file_error introduced by the change from 2011-05-07.
11023
89d1bd22
PE
110242011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11025
11026 * systime.h (Time): Define only if emacs is defined.
11027 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11028 where the include path doesn't have X11/X.h by default. See
11029 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11030
cd394be1 110312011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11032
11033 * composite.c (find_automatic_composition): Fix previous change.
11034
b9704ad9
GM
110352011-05-20 Glenn Morris <rgm@gnu.org>
11036
11037 * lisp.mk: New file, split from Makefile.in.
11038 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11039 (shortlisp): Remove.
11040 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11041
4a720484
GM
110422011-05-19 Glenn Morris <rgm@gnu.org>
11043
11044 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11045 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11046 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11047 (lisp): Set the order to that of loadup.el.
11048 (shortlisp): Make it a copy of $lisp.
11049 (SOME_MACHINE_LISP): Remove.
11050 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11051 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11052
a28d4396
KH
110532011-05-18 Kenichi Handa <handa@m17n.org>
11054
11055 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11056 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11057 (find_automatic_composition): Mostly rewrite for efficiency.
11058
a2b1fa8e
JB
110592011-05-18 Juanma Barranquero <lekktu@gmail.com>
11060
11061 * makefile.w32-in: Update dependencies.
11062
8e1f5610
CS
110632011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11064
11065 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11066 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11067
7025ee00 110682011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11069
cdfa6eab
PE
11070 Fix some integer overflow issues, such as string length overflow.
11071
06d6db33
PE
11072 * insdel.c (count_size_as_multibyte): Check for string overflow.
11073
2b4560a8
PE
11074 * character.c (lisp_string_width): Check for string overflow.
11075 Use EMACS_INT, not int, for string indexes and lengths; in
11076 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11077 the resulting string length overflows an EMACS_INT; instead,
11078 report a string overflow if no precision given. When checking for
11079 precision exhaustion, use a check that cannot possibly have
11080 integer overflow. (Bug#8675)
11081 * character.h (lisp_string_width): Adjust to new signature.
11082
cb93f9be
PE
11083 * alloc.c (string_overflow): New function.
11084 (Fmake_string): Use it. This doesn't change behavior, but saves
11085 a few bytes and will simplify future changes.
11086 * character.c (string_escape_byte8): Likewise.
11087 * lisp.h (string_overflow): New decl.
11088
1a1f3366
PE
11089 Fixups, following up to the user-interface timestamp change.
11090 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11091 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11092 * msdos.c (mouse_get_pos): Likewise.
11093 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11094 * w32gui.h (Time): Define by including "systime.h" rather than by
11095 declaring it ourselves. (Bug#8664)
11096
d4e3e4d3
PE
11097 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11098 * image.c (clear_image_cache): Likewise.
11099
f6a24d19
PE
11100 * term.c (term_mouse_position): Don't assume time_t wraparound.
11101
08dc5ae6
PE
11102 Be more systematic about user-interface timestamps.
11103 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11104 and sometimes 'EMACS_UINT', to represent these timestamps.
11105 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11106 This makes the code easier to follow, and makes it easier to catch
11107 integer overflow bugs such as Bug#8664.
11108 * frame.c (Fmouse_position, Fmouse_pixel_position):
11109 Use Time, not unsigned long, for user-interface timestamps.
11110 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11111 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11112 * keyboard.h (last_event_timestamp): Likewise.
11113 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11114 * menu.h (xmenu_show): Likewise.
11115 * term.c (term_mouse_position): Likewise.
11116 * termhooks.h (struct input_event.timestamp): Likewise.
11117 (struct terminal.mouse_position_hook): Likewise.
11118 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11119 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11120 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11121 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11122 what it was before.
11123 * menu.h, termhooks.h: Include "systime.h", for Time.
11124
8e55734a
PE
11125 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11126 Don't assume that the difference between two unsigned long values
11127 can fit into an integer. At this point, we know button_down_time
11128 <= event->timestamp, so the difference must be nonnegative, so
11129 there's no need to cast the result if double-click-time is
11130 nonnegative, as it should be; check that it's nonnegative, just in
11131 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11132 apart (about 25 days). (Bug#8664)
8e55734a 11133
841f1b75 11134 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11135 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11136
3e26f69c
PE
11137 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11138 that always fit in int. Use a sentinel instead of a counter, to
11139 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11140 * frame.h (struct frame): Use int for menu_bar_items_used
11141 instead of EMACS_INT, since it always fits in int.
3e26f69c 11142
5cc152c0
PE
11143 * menu.c (grow_menu_items): Check for int overflow.
11144
d89eb65e
PE
11145 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11146
5235bd3e
PE
11147 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11148 Before, the code was not consistent. These values cannot exceed
11149 2**31 - 1 so there's no need to make them unsigned.
11150 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11151 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11152 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11153 as modifiers.
11154 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11155
bc827e23
PE
11156 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11157 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11158 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11159 presumably because the widths might not match.
11160
78eb494e
PE
11161 * window.c (size_window): Avoid needless test at loop start.
11162
04f2d78b
CB
111632011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11164
11165 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11166
d2fc7e3d 111672011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11168
11169 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11170
d2fc7e3d 111712011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11172
11173 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11174 `width' to `bar_area_x' and `bar_area_width', respectively.
11175 (x_scroll_run): Take account of fringe background extension.
11176
04f2d78b
CB
11177 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11178 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11179 `bar_area_width', respectively.
11180 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11181 background extension.
11182
79b70037
GM
111832011-05-10 Jim Meyering <meyering@redhat.com>
11184
11185 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11186
2f142cc5
JB
111872011-05-10 Juanma Barranquero <lekktu@gmail.com>
11188
11189 * image.c (Finit_image_library): Return t for built-in image types,
11190 like pbm and xbm. (Bug#8640)
11191
57679c86
AS
111922011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11193
11194 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11195
888c9e86
EZ
111962011-05-07 Eli Zaretskii <eliz@gnu.org>
11197
b0512a1d
EZ
11198 * w32console.c (Fset_screen_color): Doc fix.
11199 (Fget_screen_color): New function.
11200 (syms_of_ntterm): Defsubr it.
11201
7285dc67
EZ
11202 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11203 unlink the temporary file if Fcall_process didn't create it in the
11204 first place.
11205 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11206 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11207 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11208 cue to call_process_cleanup not to close that handle.
11209
4d3fcc8e
BK
112102011-05-07 Ben Key <bkey76@gmail.com>
11211
11212 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11213 one of two shell specific rules, either bootstrap-temacs-CMD or
11214 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11215 to the previous implementation of the bootstrap-temacs rule.
11216 The bootstrap-temacs-CMD rule is similar to the previous
11217 implementation of the bootstrap-temacs rule except that it
11218 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11219 variable.
11220
11221 These changes, along with some changes to nt/configure.bat,
11222 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11223 earlier fix to add support for --cflags and --ldflags options
11224 that include quotes so that it works whether make uses cmd or
11225 sh as the shell.
11226
b4289b64
MA
112272011-05-06 Michael Albinus <michael.albinus@gmx.de>
11228
11229 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11230 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11231 is a constant.
11232 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11233 a string. Handle both cases.
11234 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11235 (Fdbus_register_method): Use Qinvalid_function.
11236
af4c0e28
JB
112372011-05-06 Juanma Barranquero <lekktu@gmail.com>
11238
11239 * makefile.w32-in: Update dependencies.
11240 (LISP_H): Add inttypes.h and stdin.h.
11241 (PROCESS_H): Add unistd.h.
11242
c51453d9
EZ
112432011-05-06 Eli Zaretskii <eliz@gnu.org>
11244
11245 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11246 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11247
8ff0ac3c 112482011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11249
4c4b566b
PE
11250 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11251
aab2b9b5
PE
11252 * term.c (vfatal): Remove stray call to va_end.
11253 It's not needed and the C Standard doesn't allow it here anyway.
11254
c378da0b
PE
11255 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11256 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11257
288b08c7
PE
11258 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11259 bytes.
11260
e3601888
PE
11261 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11262
db6c0e74
PE
11263 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11264
dd5963ea
PE
11265 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11266
88c9450f
PE
11267 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11268
2f9442b8
PE
11269 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11270
c032b5f8
PE
11271 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11272 * charset.c (Fdefine_charset_internal): Don't initialize
11273 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11274 32-bit int (Bug#8600).
a108c10b
PE
11275
11276 * lread.c (read_integer): Be more consistent with string-to-number.
11277 Use string_to_number to do the actual conversion; this avoids
11278 rounding errors and fixes some other screwups. Without this fix,
11279 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11280 (digit_to_number): Move earlier, for benefit of read_integer.
11281 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11282 not a digit in any supported base. (Bug#8602)
a108c10b 11283
ad5f9eea
PE
11284 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11285
aec1708a
PE
11286 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11287 to match comment at start of function. This also removes a
11288 GCC warning about overflow in a 32+64-bit port.
11289
47be4ab5
PE
11290 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11291
371cac43
PE
11292 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11293 Reported by Stefan Monnier in
11294 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11295 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11296 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11297
d01a7826
PE
11298 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11299 (EMACS_UINTPTR): Likewise, with uintptr_t.
11300
7fd47d5c
PE
11301 * lisp.h: Prefer 64-bit EMACS_INT if available.
11302 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11303 on 32-bit hosts that have 64-bit int, so that they can access
11304 large files.
122b0c86
PE
11305 However, temporarily disable this change unless the temporary
11306 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11307
8727937b
PE
11308 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11309
8ac068ac
PE
11310 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11311 This removes an assumption that EMACS_INT and long are the same
11312 width as pointers. The assumption is true for Emacs porting targets
11313 now, but we want to make other targets possible.
11314 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11315 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11316 In the rest of the code, change types of integers that hold casted
11317 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11318 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11319 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11320 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11321 No need to cast type when ORing.
11322 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11323 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11324 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11325 assume EMACS_INT is the same width as char *.
11326 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11327 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11328 Remove no-longer-needed casts.
11329 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11330 (xg_tool_bar_help_callback, xg_make_tool_item):
11331 Use EMACS_INTPTR to hold an integer
11332 that will be cast to void *; this can avoid a GCC warning
11333 if EMACS_INT is not the same width as void *.
11334 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11335 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11336 (current_message_1, set_message_1):
11337 Use a local to convert to proper width without a cast.
11338 * xmenu.c (dialog_selection_callback): Likewise.
11339
ede49d71
PE
11340 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11341 Also, don't assume VALBITS / RAND_BITS is less than 5,
11342 and don't rely on undefined behavior when shifting a 1 left into
11343 the sign bit.
11344 * lisp.h (get_random): Change signature to match.
11345
2f30ecd0
PE
11346 * lread.c (hash_string): Use size_t, not int, for hash computation.
11347 Normally we prefer signed values; but hashing is special, because
11348 it's better to use unsigned division on hash table sizes so that
11349 the remainder is nonnegative. Also, size_t is the natural width
11350 for hashing into memory. The previous code used 'int', which doesn't
11351 retain enough info to hash well into very large tables.
11352 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11353
2a866e7b
PE
11354 * dbusbind.c: Don't possibly lose pointer info when converting.
11355 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11356 Use XPNTR rather than XHASH, so that the high-order bits of
11357 the pointer aren't lost when converting through void *.
11358
51639eac
PE
11359 * eval.c (Fautoload): Don't double-shift a pointer.
11360
92394119
PE
11361 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11362
dbdb9a7c
JB
113632011-05-06 Juanma Barranquero <lekktu@gmail.com>
11364
11365 * gnutls.c (DEF_GNUTLS_FN):
11366 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11367
db7a0b4f
AS
113682011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11369
11370 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11371 marker. (Bug#8610)
11372
cd394be1 113732011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11374
11375 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11376 New version that can reserve upto 2GB of heap space.
11377
f7ff1b0f 113782011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11379
11380 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11381
639c109b
TZ
113822011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11383
11384 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11385 `gnutls_certificate_set_x509_key_file'.
11386
d2127135
JB
113872011-05-05 Juanma Barranquero <lekktu@gmail.com>
11388
11389 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11390 Update dependencies.
11391
e968f4f3
JB
113922011-05-04 Juanma Barranquero <lekktu@gmail.com>
11393
11394 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11395 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11396 Remove unused parameter `fildes'.
11397 * process.c (read_process_output, send_process): Don't pass it.
11398
84d358f0
JB
113992011-05-04 Juanma Barranquero <lekktu@gmail.com>
11400
11401 Fix previous change: the library cache is defined in w32.c.
11402 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11403 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11404
0898ca10
JB
114052011-05-04 Juanma Barranquero <lekktu@gmail.com>
11406
11407 Implement dynamic loading of GnuTLS on Windows.
11408
11409 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11410 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11411 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11412 Declare.
11413
11414 * gnutls.c (Qgnutls_dll): Define.
11415 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11416 (gnutls_*): Declare function pointers.
11417 (init_gnutls_functions): New function to initialize function pointers.
11418 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11419 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11420 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11421 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11422 (emacs_gnutls_write, emacs_gnutls_read)
11423 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11424 (Fgnutls_available_p): New function.
11425 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11426 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11427 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11428
11429 * image.c: Include w32.h.
11430 (Vimage_type_cache): Delete.
11431 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11432 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11433 (w32_delayed_load): Move to w32.c.
11434
11435 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11436
11437 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11438 (w32_delayed_load): Move from image.c. When loading a library, record
11439 its filename in the :loaded-from property of the library id.
11440 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11441 Initialize and staticpro them.
11442 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11443
11444 * process.c: Include lisp.h before w32.h, not after.
11445 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11446 instead of gnutls_record_check_pending.
11447
11448 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11449
ff4de4aa
TZ
114502011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11451
11452 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11453 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11454 as passed in.
11455
abe95abb
JD
114562011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11457
11458 * xterm.c (x_set_frame_alpha): Do not set property on anything
11459 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11460
e16e55d4
JB
114612011-05-02 Juanma Barranquero <lekktu@gmail.com>
11462
11463 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11464
bafcf6a5
JB
114652011-05-02 Juanma Barranquero <lekktu@gmail.com>
11466
11467 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11468 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11469 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11470 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11471 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11472 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11473 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11474 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11475 (Qgnutls_bootprop_callbacks_verify): Make static.
11476
e7a6747f
AS
114772011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11478
19ed11ba
AS
11479 * callproc.c: Indentation fixup.
11480
e7a6747f 11481 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11482 (wait_for_termination, interruptible_wait_for_termination):
11483 Move after wait_for_termination_1.
e7a6747f 11484
1ef14cb4
LMI
114852011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11486
11487 * sysdep.c (interruptible_wait_for_termination): New function
11488 which is like wait_for_termination, but allows keyboard
11489 interruptions.
11490
11491 * callproc.c (Fcall_process): Add (:file "file") as an option for
11492 the STDOUT buffer.
11493 (Fcall_process_region): Ditto.
11494
330d880c
EZ
114952011-04-30 Eli Zaretskii <eliz@gnu.org>
11496
8db90b73
EZ
11497 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11498 rather than `XVECTOR (FOO)->size'.
11499
330d880c
EZ
11500 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11501 inttypes.h, as a gnulib replacement is used if it not available in
11502 system headers.
11503
15cbd324
EZ
115042011-04-21 Eli Zaretskii <eliz@gnu.org>
11505
11506 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11507 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11508 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11509
11510 * coding.c (coding_alloc_by_realloc): Error out if destination
11511 will grow beyond MOST_POSITIVE_FIXNUM.
11512 (decode_coding_emacs_mule): Abort if there isn't enough place in
11513 charbuf for the composition carryover bytes. Reserve an extra
11514 space for up to 2 characters produced in a loop.
11515 (decode_coding_iso_2022): Abort if there isn't enough place in
11516 charbuf for the composition carryover bytes.
11517
115182011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11519
ae940cca
EZ
11520 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11521 aborting when %lld or %lll format is passed.
11522 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11523 %llo or %llx format is passed. (Bug#8545)
11524
03ab8921
EZ
11525 * window.c (window_scroll_line_based): Use a marker instead of
11526 simple variables to record original value of point. (Bug#7952)
11527
afda1437
EZ
11528 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11529 produced by %s or %c overflows available buffer space. (Bug#8545)
11530
f76dee0c
PE
115312011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11532
11533 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11534 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11535
fdc5744d
JB
115362011-04-28 Juanma Barranquero <lekktu@gmail.com>
11537
11538 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11539
638f053a
JB
115402011-04-28 Juanma Barranquero <lekktu@gmail.com>
11541
11542 * keyboard.c (Qdelayed_warnings_hook): Define.
11543 (command_loop_1): Run `delayed-warnings-hook'
11544 if Vdelayed_warnings_list is non-nil.
11545 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11546 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11547
d178f871
EZ
115482011-04-28 Eli Zaretskii <eliz@gnu.org>
11549
11550 * doprnt.c (doprnt): Don't return value smaller than the buffer
11551 size if the message was truncated. (Bug#8545).
11552
b124fd93
JB
115532011-04-28 Juanma Barranquero <lekktu@gmail.com>
11554
11555 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11556 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11557
e810457d
PE
115582011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11559
11560 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11561
ea51cceb
JB
115622011-04-27 Juanma Barranquero <lekktu@gmail.com>
11563
11564 * makefile.w32-in: Update dependencies.
11565
94dcfacf
EZ
115662011-04-27 Eli Zaretskii <eliz@gnu.org>
11567
11568 Improve `doprnt' and its usage. (Bug#8545)
11569 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11570 `format_end'. Remove support for %l as a conversion specifier.
11571 Don't use xrealloc. Improve diagnostics when the %l size modifier
11572 is used. Update the commentary.
11573
11574 * eval.c (verror): Simplify calculation of size_t.
11575
11576 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11577 messages.
11578
f61f41d7
PE
115792011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11580
11581 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11582 change.
11583
96fb4434
PE
115842011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11585
11586 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11587 This makes this file independent of the recent pseudovector change.
11588
671875da 115892011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11590
69e9b5a3
PE
11591 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11592
b5f869a7 11593 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11594 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11595 Remove unused local.
c8926152 11596 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11597
841a1577 11598 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11599 GCC 4.6.0 optimizes based on type-based alias analysis.
11600 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11601 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11602 != &v->size, and therefore "v->size = 1; b->size = 2; return
11603 v->size;" must therefore return 1. This assumption is incorrect
11604 for Emacs, since it type-puns struct Lisp_Vector * with many other
11605 types. To fix this problem, this patch adds a new type struct
f904488f 11606 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11607 and pseudovectors, and helps optimizing compilers not get fooled
11608 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11609 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11610 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11611 the size member.
eab3844f
PE
11612 (XSETPVECTYPE): Rewrite in terms of new macro.
11613 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11614 This is a bit clearer, and further avoids the possibility of
11615 undesirable aliasing.
11616 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11617 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11618 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11619 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11620 (ASIZE): Now uses header.size rather than size.
11621 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11622 to avoid the hassle of writing XVECTOR (foo)->header.size.
11623 (struct vectorlike_header): New type.
eab3844f
PE
11624 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11625 object, to help avoid aliasing.
11626 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11627 (SUBRP): Likewise, since Lisp_Subr is a special case.
11628 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11629 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11630 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11631 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11632 changed to be "header.size" and "header.next".
11633 * buffer.h (struct buffer): Likewise.
11634 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11635 * frame.h (struct frame): Likewise.
11636 * process.h (struct Lisp_Process): Likewise.
11637 * termhooks.h (struct terminal): Likewise.
11638 * window.c (struct save_window_data, struct saved_window): Likewise.
11639 * window.h (struct window): Likewise.
11640 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11641 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11642 * buffer.c (init_buffer_once): Likewise.
11643 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11644 special case.
11645 * process.c (Fformat_network_address): Use local var for size,
11646 for brevity.
11647
0df1eac5
PE
11648 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11649
847ab9d1 11650 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11651 * data.c (atof): Remove decl; no longer used or needed.
11652 (digit_to_number): Move to lread.c.
11653 (Fstring_to_number): Use new string_to_number function, to be
11654 consistent with how the Lisp reader treats infinities and NaNs.
11655 Do not assume that floating-point numbers represent EMACS_INT
11656 without losing information; this is not true on most 64-bit hosts.
11657 Avoid double-rounding errors, by insisting on integers when
11658 parsing non-base-10 numbers, as the documentation specifies.
11659 * lisp.h (string_to_number): New decl, replacing ...
11660 (isfloat_string): Remove.
bc0a5c13 11661 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11662 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11663 appears to have been a coding error. Similarly, do not accept
11664 strings like +-1e0 as floating point numbers. Do not report
11665 overflow for integer overflows unless the base is not 10 which
11666 means we have no simple and reliable way to continue.
11667 Break out the floating-point parsing into a new
11668 function string_to_number, so that Fstring_to_number parses
11669 floating point numbers consistently with the Lisp reader.
04f2d78b 11670 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11671 (E_CHAR, EXP_INT): Remove, replacing with ...
11672 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11673 (string_to_number): New function, replacing isfloat_string.
11674 This function checks for valid syntax and produces the resulting
11675 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11676 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11677 so that overflow for non-base-10 numbers is reported only when
11678 there's no portable and simple way to convert to floating point.
452f4150 11679
67769ffc
PE
11680 * textprop.c (set_text_properties_1): Rewrite for clarity,
11681 and to avoid GCC warning about integer overflow.
11682
c20db43f
PE
11683 * intervals.h (struct interval): Use EMACS_INT for members
11684 where EMACS_UINT might cause problems. See
11685 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11686 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11687 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11688 All uses changed.
37aa2f85
PE
11689 (offset_intervals): Tell GCC not to worry about length overflow
11690 when negating a negative length.
c20db43f 11691
2538aa2f
PE
11692 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11693 (overrun_check_free): Likewise.
11694
f2d3008d
PE
11695 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11696 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11697 word size.
11698
ec8df744
PE
11699 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11700 (gnutls_make_error): Rename local to avoid shadowing.
11701 (gnutls_emacs_global_deinit): ifdef out; not used.
11702 (Fgnutls_boot): Use const for pointer to readonly storage.
11703 Comment out unused local. Fix pointer signedness problems.
11704
640ee02d
PE
11705 * lread.c (openp): Don't stuff size_t into an 'int'.
11706 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11707 about possible signed overflow.
11708
6048fb2a
PE
11709 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11710 (GDK_KEY_g): Don't define if already defined.
11711 (xg_prepare_tooltip): Avoid pointer signedness problem.
11712 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11713
fa3c87e1
PE
11714 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11715 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11716
2172544b
PE
11717 * xfns.c (Fx_window_property): Simplify a bit,
11718 to make a bit faster and to avoid GCC 4.6.0 warning.
11719 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11720
9b821a21
PE
11721 * fns.c (internal_equal): Don't assume size_t fits in int.
11722
3c616cfa
PE
11723 * alloc.c (compact_small_strings): Tighten assertion a little.
11724
c2982e87
PE
11725 Replace pEd with more-general pI, and fix some printf arg casts.
11726 * lisp.h (pI): New macro, generalizing old pEd macro to other
11727 conversion specifiers. For example, use "...%"pI"d..." rather
11728 than "...%"pEd"...".
11729 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11730 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11731 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11732 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11733 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11734 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11735 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11736 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11737 64-bit hosts.
11738 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11739 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11740 * print.c (safe_debug_print, print_object): Likewise.
11741 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11742 to int.
6f04d126
PE
11743 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11744 avoiding the 0 flag, which is not portable.
c2982e87
PE
11745 * process.c (Fmake_network_process): Use pI to avoid cast.
11746 * region-cache.c (pp_cache): Likewise.
11747 * xdisp.c (decode_mode_spec): Likewise.
11748 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11749 behavior on 64-bit hosts with printf arg.
6f04d126 11750 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11751 (x_stop_queuing_selection_requests): Likewise.
11752 (x_get_window_property): Don't truncate byte count to an 'int'
11753 when tracing.
0b432f21 11754
5e073ec7
PE
11755 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11756 here, since it parses constructs like leading '-' and spaces,
11757 which are not wanted; and it overflows with large numbers.
11758 Instead, simply match F[0-9]+, which is what is wanted anyway.
11759
36372bf9
PE
11760 * alloc.c: Remove unportable assumptions about struct layout.
11761 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11762 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11763 (allocate_vectorlike, make_pure_vector): Use the new macros,
11764 plus offsetof, to remove unportable assumptions about struct layout.
11765 These assumptions hold on all porting targets that I know of, but
11766 they are not guaranteed, they're easy to remove, and removing them
11767 makes further changes easier.
11768
0b432f21
PE
11769 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11770 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11771 (string_overrun_cookie): Now const. Use initializers that
11772 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11773 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11774 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11775 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11776 multiple of sizeof (EMACS_INT); it need not be, if
11777 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11778 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11779
895009e1
JB
117802011-04-26 Juanma Barranquero <lekktu@gmail.com>
11781
11782 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11783
6a7a1b0b
TZ
117842011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11785
11786 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11787 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11788 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11789
841a1577 117902011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11791
11792 * lisp.h (Qdebug): List symbol.
895009e1 11793 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11794 * keyboard.c (debug-on-event): New variable.
11795 (handle_user_signal): Break into debugger when debug-on-event
11796 matches the current signal symbol.
11797
f2d3ba6f
DN
117982011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11799
11800 * alloc.c (check_sblock, check_string_bytes)
11801 (check_string_free_list): Convert to standard C.
11802
42ce4c63
TZ
118032011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11804
11805 * w32.c (emacs_gnutls_push): Fix typo.
11806
825cd63c
EZ
118072011-04-25 Eli Zaretskii <eliz@gnu.org>
11808
fb11d64d
EZ
11809 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
11810 "cast to pointer from integer of different size".
11811
825cd63c
EZ
11812 Improve doprnt and its use in verror. (Bug#8545)
11813 * doprnt.c (doprnt): Document the set of format control sequences
11814 supported by the function. Use SAFE_ALLOCA instead of always
11815 using `alloca'.
11816
11817 * eval.c (verror): Don't limit the buffer size at size_max-1, that
11818 is one byte too soon. Don't use xrealloc; instead xfree and
11819 xmalloc anew.
11820
e061a11b
TZ
118212011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
11822
11823 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
11824 callbacks stage.
11825
11826 * gnutls.c: Renamed global_initialized to
11827 gnutls_global_initialized. Added internals for the
11828 :verify-hostname-error, :verify-error, and :verify-flags
11829 parameters of `gnutls-boot' and documented those parameters in the
11830 docstring. Start callback support.
9173deec
JB
11831 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
11832 unless a fatal error occurred. Call gnutls_alert_send_appropriate
11833 on error. Return error code.
e061a11b
TZ
11834 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
11835 (emacs_gnutls_read): Likewise.
11836 (Fgnutls_boot): Return handshake error code.
11837 (emacs_gnutls_handle_error): New function.
11838 (wsaerror_to_errno): Likewise.
11839
11840 * w32.h (emacs_gnutls_pull): Add prototype.
11841 (emacs_gnutls_push): Likewise.
11842
11843 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
11844 (emacs_gnutls_push): Likewise.
11845
118462011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
11847
11848 * process.c (wait_reading_process_output): Check if GnuTLS
11849 buffered some data internally if no FDs are set for TLS
11850 connections.
11851
11852 * makefile.w32-in (OBJ2): Add gnutls.$(O).
11853 (LIBS): Link to USER_LIBS.
11854 ($(BLD)/gnutls.$(0)): New target.
11855
fa6996bc
EZ
118562011-04-24 Eli Zaretskii <eliz@gnu.org>
11857
eb35682e
EZ
11858 * xdisp.c (handle_single_display_spec): Rename the
11859 display_replaced_before_p argument into display_replaced_p, to
11860 make it consistent with the commentary. Fix typos in the
11861 commentary.
11862
e2ad650c
EZ
11863 * textprop.c (syms_of_textprop): Remove dead code.
11864 (copy_text_properties): Delete obsolete commentary about an
11865 interface that was deleted long ago. Fix typos in the description
11866 of arguments.
11867
1b2de274
EZ
11868 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
11869 to changes in oldXMenu/XMenu.h from 2011-04-16.
11870 <menu_help_message, prev_menu_help_message>: Constify.
11871 (IT_menu_make_room): menu->help_text is now `const char **';
11872 adjust.
11873
11874 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
11875 to changes in oldXMenu/XMenu.h from 2011-04-16.
11876 (struct XMenu): Declare `help_text' `const char **'.
11877
11878 * xfaces.c <Qunspecified>: Make extern again.
11879
11880 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 11881 required by POSIX.
1b2de274 11882
762b15be
EZ
11883 * doc.c (get_doc_string): Improve the format passed to `error'.
11884
11885 * doprnt.c (doprnt): Improve commentary.
11886
11887 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
11888
11889 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
11890 them with etags.
11891
f1052e5d
EZ
11892 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
11893 changes in globals.h immediately force recompilation.
762b15be
EZ
11894 (TAGS): Depend on $(CURDIR)/m/intel386.h and
11895 $(CURDIR)/s/ms-w32.h.
11896 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 11897
fa6996bc
EZ
11898 * character.c (Fchar_direction): Function deleted.
11899 (syms_of_character): Don't defsubr it.
11900 <char-direction-table>: Deleted.
11901
e6c3da20
EZ
119022011-04-23 Eli Zaretskii <eliz@gnu.org>
11903
11904 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
11905 * doprnt.c: Include limits.h.
11906 (SIZE_MAX): New macro.
04f2d78b
CB
11907 (doprnt): Return a size_t value. 2nd arg is now size_t.
11908 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
11909 Improve overflow protection. Support `l' modifier for integer
11910 conversions. Support %l conversion. Don't assume an EMACS_INT
11911 argument for integer conversions and for %c.
11912
11913 * lisp.h (doprnt): Restore prototype.
11914
11915 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
11916 $(SRC)/character.h.
11917
11918 * Makefile.in (base_obj): Add back doprnt.o.
11919
11920 * deps.mk (doprnt.o): Add back prerequisites.
11921 (callint.o): Depend on character.h.
11922
11923 * eval.c (internal_lisp_condition_case): Include the handler
11924 representation in the error message.
11925 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
11926 when breaking from the loop.
11927
11928 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
11929
11930 * callint.c (Fcall_interactively): When displaying error message
11931 about invalid control letter, pass the character's codepoint, not
11932 a pointer to its multibyte form. Improve display of the character
11933 in octal and display also its hex code.
11934
11935 * character.c (char_string): Use %x to display the (unsigned)
11936 codepoint of an invalid character, to avoid displaying a bogus
11937 negative value.
11938
11939 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
11940 `error', not SYMBOL_NAME itself.
11941
11942 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
11943 character arguments to `error'.
11944
11945 * charset.c (check_iso_charset_parameter): Fix incorrect argument
11946 to `error' in error message about FINAL_CHAR argument. Make sure
11947 FINAL_CHAR is a character, and use %c when it is passed as
11948 argument to `error'.
11949
4ffd0d6b 119502011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
11951
11952 * s/ms-w32.h (localtime): Redirect to sys_localtime.
11953
11954 * w32.c: Include <time.h>.
11955 (sys_localtime): New function.
11956
4ffd0d6b 119572011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
11958
11959 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
11960
4ffd0d6b 11961 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 11962
4ffd0d6b 119632011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 11964
4ffd0d6b
GM
11965 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
11966 zombies (Bug#8467).
aac0c6e3 11967
04c56954
EZ
119682011-04-19 Eli Zaretskii <eliz@gnu.org>
11969
11970 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
11971 gl_state.e_property when gl_state.object is Qt.
11972
11973 * insdel.c (make_gap_larger): Remove limitation of buffer size
11974 to <= INT_MAX.
11975
16a43933
CY
119762011-04-18 Chong Yidong <cyd@stupidchicken.com>
11977
11978 * xdisp.c (lookup_glyphless_char_display)
11979 (produce_glyphless_glyph): Handle cons cell entry in
11980 glyphless-char-display.
11981 (Vglyphless_char_display): Document it.
11982
11983 * term.c (produce_glyphless_glyph): Handle cons cell entry in
11984 glyphless-char-display.
11985
4581706e
CY
119862011-04-17 Chong Yidong <cyd@stupidchicken.com>
11987
11988 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
11989
11990 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
11991
11992 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
11993 definition for no-X builds.
11994
4887c6e2 119952011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 11996
fd35b6f9
PE
11997 Static checks with GCC 4.6.0 and non-default toolkits.
11998
5c1ccb01
PE
11999 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12000
006c5daa
PE
12001 * process.c (keyboard_bit_set): Define only if SIGIO.
12002 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12003 (send_process): Repair possible setjmp clobbering.
12004
efc736d3
PE
12005 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12006
4e2fe2e6
PE
12007 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12008
f97334a2
PE
12009 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12010
4e75f29d
PE
12011 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12012 Define only if needed.
12013
90efadd1
PE
12014 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12015 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12016 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12017
3c647824
PE
12018 * dispextern.h (struct redisplay_interface): Rename param
12019 to avoid shadowing.
e264f262 12020 * termhooks.h (struct terminal): Likewise.
761383f4 12021 * xterm.c (xembed_send_message): Likewise.
3c647824 12022
b58c5c4a
PE
12023 * insdel.c (make_gap_smaller): Define only if
12024 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12025
cad59032
PE
12026 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12027 it.
12028
c339dc2e
PE
12029 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12030 so that we aren't warned about unused symbols.
12031
91a3e27b
PE
12032 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12033
399c71d3 12034 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12035
8ffc96f5
PE
12036 * xfns.c (x_real_positions): Mark locals as initialized.
12037
eef9bc79
PE
12038 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12039
098db9dd
PE
12040 * xterm.c: Fix problems found by static analysis with other toolkits.
12041 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12042 (x_dispatch_event): Declare static if USE_GTK, and
12043 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12044 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12045 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12046 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12047 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12048
eb18f6cc
PE
12049 * xmenu.c (menu_help_callback): Pointer type fixes.
12050 Use const pointers when pointing at readonly data. Avoid pointer
12051 signedness clashes.
12052 (FALSE): Remove unused macro.
12053 (update_frame_menubar): Remove unused decl.
12054
1fe72bf8
PE
12055 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12056
60d9e1db
PE
12057 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12058 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12059 (single_menu_item): Rename local to avoid shadowing.
12060
39261c26
PE
12061 * keyboard.c (make_lispy_event): Remove unused local var.
12062
018c5e19
PE
12063 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12064 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12065
63d2b86e
PE
12066 * bitmaps: Change bitmaps from unsigned char back to the X11
12067 compatible char. Avoid the old compiler warnings about
12068 out-of-range initializers by using, for example, '\xab' rather
12069 than 0xab.
12070
aefd87e1
PE
12071 * xgselect.c (xgselect_initialize): Check vs interface
12072 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12073
bf501fb9
PE
12074 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12075
e9829fdf
PE
12076 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12077 to read-only memory.
12078
1086c095
PE
12079 * fns.c (vector): Remove; this old hack is no longer needed.
12080
2baccd04 12081 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12082 Remove unused var.
dde42981 12083 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12084
72391843 12085 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12086
436c16df 12087 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12088 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12089 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12090
92bb796d 12091 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12092 (x_term_init): Remove local to avoid shadowing.
92bb796d 12093
764430a3 12094 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12095
12096 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12097 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12098
d1dfb56c
EZ
120992011-04-16 Eli Zaretskii <eliz@gnu.org>
12100
c4354cb4
EZ
12101 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12102
d1dfb56c
EZ
12103 Fix regex.c, syntax.c and friends for buffers > 2GB.
12104 * syntax.h (struct gl_state_s): Declare character position members
12105 EMACS_INT.
12106
12107 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12108
04f2d78b
CB
12109 * textprop.c (verify_interval_modification, interval_of):
12110 Declare arguments EMACS_INT.
d1dfb56c
EZ
12111
12112 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12113 EMACS_INT.
12114
12115 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12116
12117 * indent.c (Fvertical_motion): Local variable it_start is now
12118 EMACS_INT.
12119
12120 * regex.c (re_match, re_match_2, re_match_2_internal)
12121 (bcmp_translate, regcomp, regexec, print_double_string)
12122 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12123 (re_compile_pattern, re_exec): Declare arguments and local
12124 variables `size_t' and `ssize_t' and return values `regoff_t', as
12125 appropriate.
12126 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12127 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12128 <compile_stack_type>: `size' and `avail' are now `size_t'.
12129
12130 * regex.h <regoff_t>: Use ssize_t, not int.
12131 (re_search, re_search_2, re_match, re_match_2): Arguments that
12132 specify buffer/string position and length are now ssize_t and
12133 size_t. Return type is regoff_t.
12134
613052cd
BK
121352011-04-16 Ben Key <bkey76@gmail.com>
12136
12137 * nsfont.m: Fixed bugs in ns_get_family and
12138 ns_descriptor_to_entity that were caused by using free to
12139 deallocate memory blocks that were allocated by xmalloc (via
12140 xstrdup). This caused Emacs to crash when compiled with
12141 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12142 --enable-checking=xmallocoverrun). xfree is now used to
12143 deallocate these memory blocks.
12144
4170f62f 121452011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12146
71b41406
PE
12147 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12148
9587a89d
PE
12149 emacs_write: Accept and return EMACS_INT for sizes.
12150 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12151 et seq.
12152 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12153 Accept and return EMACS_INT.
12154 (emacs_gnutls_write): Return the number of bytes written on
12155 partial writes.
12156 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12157 (emacs_read, emacs_write): Remove check for negative size, as the
12158 Emacs source code has been audited now.
9587a89d
PE
12159 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12160 (emacs_read, emacs_write): Use it.
273a5f82
PE
12161 * process.c (send_process): Adjust to the new signatures of
12162 emacs_write and emacs_gnutls_write. Do not attempt to store
12163 a byte offset into an 'int'; it might overflow.
9587a89d 12164 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12165
3e047f51
PE
12166 * sound.c: Don't assume sizes fit in 'int'.
12167 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12168 Return EMACS_INT, not int.
3e047f51 12169 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12170 Accept EMACS_INT, not int.
12171 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12172 record read return values.
12173
cc39a9db
BK
121742011-04-15 Ben Key <bkey76@gmail.com>
12175
c9d0ec6d
JB
12176 * keyboard.c (Qundefined): Don't declare static since it is used
12177 in nsfns.m.
12178 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12179 static since they are used in nsfont.m.
cc39a9db 12180
6c60eb9f
SM
121812011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12182
12183 * process.c (Qprocessp): Don't declare static.
12184 * lisp.h (Qprocessp): Declare again.
12185
7990b61a
JB
121862011-04-15 Juanma Barranquero <lekktu@gmail.com>
12187
12188 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12189
5d4cb038
PE
121902011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12191
8bd7b830 12192 Improve C-level modularity by making more things 'static'.
cd64ea1d 12193
e3b27b31
PE
12194 Don't publish debugger-only interfaces to other modules.
12195 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12196 (verify_bytepos, count_markers): Move decls to the only modules
12197 that need them.
12198 * region-cache.h (pp_cache): Likewise.
12199 * window.h (check_all_windows): Likewise.
12200 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12201
5d4cb038
PE
12202 * sysdep.c (croak): Now static, if
12203 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12204 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12205
12206 * alloc.c (refill_memory_reserve): Now static if
12207 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12208 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12209
e87b6180
PE
12210 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12211 Define only if USE_LUCID.
12212
ac64929e
PE
12213 * xrdb.c (x_customization_string, x_rm_string): Now static.
12214
6f37259d
PE
12215 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12216 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12217
1683e3ab
PE
12218 * xdisp.c (draw_row_with_mouse_face): Now static.
12219 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12220
de9c2632
PE
12221 * window.h (check_all_windows): Mark externally visible.
12222
2b96acb7
PE
12223 * window.c (window_deletion_count): Now static.
12224
12225 * undo.c: Make symbols static if they're not exported.
12226 (last_undo_buffer, last_boundary_position, pending_boundary):
12227 Now static.
12228
50436f33
PE
12229 * textprop.c (interval_insert_behind_hooks): Now static.
12230 (interval_insert_in_front_hooks): Likewise.
12231
64520e5c
PE
12232 * term.c: Make symbols static if they're not exported.
12233 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12234 (max_frame_lines, tty_set_terminal_modes):
12235 (tty_reset_terminal_modes, tty_turn_off_highlight):
12236 (get_tty_terminal): Now static.
12237 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12238 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12239 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12240 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12241 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12242
1fa53021
PE
12243 * sysdep.c: Make symbols static if they're not exported.
12244 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12245 Now static.
12246 (sigprocmask_set, full_mask): Remove; unused.
12247 (wait_debugging): Mark as visible.
12248 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12249 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12250
d4b43b22
PE
12251 * syntax.c (syntax_temp): Define only if !__GNUC__.
12252
b7c513d0
PE
12253 * sound.c (current_sound_device, current_sound): Now static.
12254
989b29ad
PE
12255 * search.c (searchbufs, searchbuf_head): Now static.
12256
13a55a78
PE
12257 * scroll.c (scroll_cost): Remove; unused.
12258 * dispextern.h (scroll_cost): Remove decl.
12259
de68a1fc
PE
12260 * region-cache.h (pp_cache): Mark as externally visible.
12261
40ccffa6
PE
12262 * process.c: Make symbols static if they're not exported.
12263 (process_tick, update_tick, create_process, chan_process):
12264 (Vprocess_alist, proc_buffered_char, datagram_access):
12265 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12266 (deactivate_process): Mark defn as static, as well as decl.
12267 * lisp.h (create_process): Remove decl.
12268 * process.h (chan_process, Vprocess_alist): Remove decls.
12269
ad64fc97
PE
12270 * print.c: Make symbols static if they're not exported.
12271 (print_depth, new_backquote_output, being_printed, print_buffer):
12272 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12273 (print_interval, print_number_index, initial_stderr_stream):
12274 Now static.
12275 * lisp.h (Fprinc): Remove decl.
12276 (debug_output_compilation_hack): Mark as externally visible.
12277
adddb265
PE
12278 * sysdep.c (croak): Move decl from here to syssignal.h.
12279 * syssignal.h (croak): Put it here, so the API can be checked when
12280 'croak' is called from dissociate_if_controlling_tty.
12281
1717ede2
PE
12282 * minibuf.c: Make symbols static if they're not exported.
12283 (minibuf_save_list, choose_minibuf_frame): Now static.
12284 * lisp.h (choose_minibuf_frame): Remove decl.
12285
fa5fb2bc
PE
12286 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12287
1e3890d1
PE
12288 * lread.c: Make symbols static if they're not exported.
12289 (read_objects, initial_obarray, oblookup_last_bucket_number):
12290 Now static.
12291 (make_symbol): Remove; unused.
12292 * lisp.h (initial_obarray, make_symbol): Remove decls.
12293
8a1414fa
PE
12294 * keyboard.c: Make symbols static if they're not exported.
12295 (single_kboard, recent_keys_index, total_keys, recent_keys):
12296 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12297 (this_single_command_key_start, echoing, last_auto_save):
12298 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12299 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12300 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12301 (Vlispy_mouse_stem, double_click_count):
12302 Now static.
12303 (force_auto_save_soon): Define only if SIGDANGER.
12304 (ignore_mouse_drag_p): Now static if
12305 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12306 (print_help): Remove; unused.
12307 (stop_character, last_timer_event): Mark as externally visible.
12308 * keyboard.h (ignore_mouse_drag_p): Declare only if
12309 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12310 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12311 * lisp.h (echoing): Remove decl.
12312 (force_auto_save_soon): Declare only if SIGDANGER.
12313 * xdisp.c (redisplay_window): Simplify code, to make it more
12314 obvious that ignore_mouse_drag_p is not accessed if !defined
12315 USE_GTK && !defined HAVE_NS.
12316
93ea6e8f
PE
12317 * intervals.c: Make symbols static if they're not exported.
12318 (merge_properties_sticky, merge_interval_right, delete_interval):
12319 Now static.
12320 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12321
77382fcc
PE
12322 * insdel.c: Make symbols static if they're not exported.
12323 However, leave prepare_to_modify_buffer alone. It's never
12324 called from outside this function, but that appears to be a bug.
12325 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12326 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12327 (adjust_after_replace_noundo): Remove; unused.
12328 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12329 (signal_before_change): Remove decls.
77382fcc 12330
9306c32e
PE
12331 * indent.c (val_compute_motion, val_vmotion): Now static.
12332
cd44d2eb
PE
12333 * image.c: Make symbols static if they're not exported.
12334 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12335 if USE_GTK.
12336 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12337 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12338
ad9a7a06
PE
12339 * fringe.c (standard_bitmaps): Now static.
12340 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12341
81626931
PE
12342 * frame.c: Make symbols static if they're not exported.
12343 (x_report_frame_params, make_terminal_frame): Now static.
12344 (get_frame_param): Now static, unless HAVE_NS.
12345 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12346 (x_get_resource_string): Remove; not used.
12347 * frame.h (make_terminal_frame, x_report_frame_params):
12348 (x_get_resource_string); Remove decls.
12349 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12350 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12351
239f9db9
PE
12352 * font.c, fontset.c: Make symbols static if they're not exported.
12353 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12354 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12355 * font.c (font_close_object): Now static.
12356 * font.h (font_close_object): Remove.
12357 * fontset.c (FONTSET_OBJLIST): Remove.
12358 (free_realized_fontset) #if-0 the body, which does nothing.
12359 (face_suitable_for_char_p): #if-0, as it's never called.
12360 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12361 * xfaces.c (face_at_string_position):
12362 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12363 since 0 is always ASCII.
12364
dfcf3579
PE
12365 * fns.c (weak_hash_tables): Now static.
12366
5045092b
PE
12367 * fileio.c: Make symbols static if they're not exported.
12368 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12369 (Vwrite_region_annotation_buffers): Now static.
12370
57a96f5c
PE
12371 * eval.c: Make symbols static if they're not exported.
12372 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12373 * lisp.h (backtrace_list): Remove decl.
12374
35f08c38
PE
12375 * emacs.c: Make symbols static if they're not exported.
12376 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12377 (fatal_error_code, fatal_error_signal_hook, standard_args):
12378 Now static.
12379 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12380 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12381 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12382 * lisp.h (fatal_error_signal_hook): Remove decl.
12383 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12384
f44bd759
PE
12385 * editfns.c: Move a (normally-unused) function to its only use.
12386 * editfns.c, lisp.h (get_operating_system_release): Remove.
12387 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12388 worth the hassle of breaking this out.
12389
b532497d
PE
12390 * xterm.c: Make symbols static if they're not exported.
12391 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12392 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12393 (x_destroy_window, x_delete_display):
12394 Now static.
12395 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12396 (x_mouse_leave): Remove; unused.
12397 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12398 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12399 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12400 Remove decls.
12401 (x_mouse_leave): Declare only if WINDOWSNT.
12402 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12403 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12404 USE_X_TOOLKIT.
12405
1675728f
PE
12406 * ftxfont.c: Make symbols static if they're not exported.
12407 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12408 HAVE_FREETYPE.
12409 * font.h (ftxfont_driver): Likewise.
12410
e4cebfca
PE
12411 * xfns.c: Make symbols static if they're not exported.
12412 (x_last_font_name, x_display_info_for_name):
12413 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12414 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12415 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12416 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12417 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12418 (last_show_tip_args): Now static.
12419 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12420 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12421 (x_screen_planes): Remove; unused.
12422 * dispextern.h (x_screen_planes): Remove decl.
12423
5bf46f05
PE
12424 * dispnew.c: Make symbols static if they're not exported.
12425 * dispextern.h (redraw_garbaged_frames, scrolling):
12426 (increment_row_positions): Remove.
12427 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12428 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12429 Now static.
12430 (redraw_garbaged_frames): Remove; unused.
12431
435f4c28
PE
12432 * xfaces.c: Make symbols static if they're not exported.
12433 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12434 Remove decls.
12435 * xterm.h (defined_color): Remove decls.
12436 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12437 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12438 (menu_face_changed_default, defined_color, free_realized_face):
12439 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12440 (ascii_face_of_lisp_face): Remove; unused.
12441
8524aef3
PE
12442 * xdisp.c: Make symbols static if they're not exported.
12443 * dispextern.h (scratch_glyph_row, window_box_edges):
12444 (glyph_to_pixel_coords, set_cursor_from_row):
12445 (get_next_display_element, set_iterator_to_next):
12446 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12447 (show_mouse_face): Remove decls
12448 * frame.h (message_buf_print): Likewise.
12449 * lisp.h (pop_message, set_message, check_point_in_composition):
12450 Likewise.
12451 * xterm.h (set_vertical_scroll_bar): Likewise.
12452 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12453 (message_buf_print, scratch_glyph_row, displayed_buffer):
12454 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12455 (get_next_display_element, show_mouse_face, window_box_edges):
12456 (frame_to_window_pixel_xy, check_point_in_composition):
12457 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12458 (glyph_to_pixel_coords): Remove; unused.
12459
16390cd2
PE
12460 * dired.c (file_name_completion): Now static.
12461
12462 * dbusbind.c (xd_in_read_queued_messages): Now static.
12463
a25f4dfa
PE
12464 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12465 * data.c (circular_list_error): Remove.
12466
14a9c8df
PE
12467 * commands.h (last_point_position, last_point_position_buffer):
12468 (last_point_position_window): Remove decls.
12469 * keyboard.c: Make these variables static.
12470
04f2d78b
CB
12471 * coding.h (coding, code_convert_region, encode_coding_gap):
12472 Remove decls.
74ab6df5
PE
12473 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12474 (iso_code_class, detect_coding, code_convert_region): Now static.
12475 (encode_coding_gap): Remove; unused.
12476
38dfbee1
PE
12477 * chartab.c (chartab_chars, chartab_bits): Now static.
12478
a2cb4e63
PE
12479 * charset.h (charset_iso_8859_1): Remove decl.
12480 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12481 Now static.
12482
127198fd
PE
12483 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12484 * ccl.c (Vccl_program_table): Now static.
12485 (check_ccl_update): Remove; unused.
12486
d85b608f
PE
12487 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12488 * category.h: ... from here.
12489 * category.c (check_category_table, set_category_set): Now static.
12490
31cd66f3
PE
12491 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12492 * lisp.h: Remove these decls.
12493
c358e587
PE
12494 * buffer.c (buffer_count): Remove unused var.
12495
e78aecca
PE
12496 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12497 so that it's not optimized away.
12498 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12499 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12500 exported only to the debugger.
12501
e192d7d3 12502 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12503 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12504
92470028
PE
12505 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12506 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12507 was inaccessible from Lisp.
12508 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12509 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12510
244ed907
PE
12511 alloc.c: Import and export fewer symbols, and remove unused items.
12512 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12513 is defined.
12514 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12515 it's not optimized away by whole-program optimization.
12516 (message_enable_multibyte, free_misc): Remove.
12517 (catchlist, handlerlist, mark_backtrace):
12518 Declare only if BYTE_MARK_STACK.
12519 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12520 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12521 (message_enable_multibyte): Remove decl.
12522 (free_misc, interval_free_list, float_block, float_block_index):
12523 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12524 (cons_free_list, last_marked_index):
12525 Now static.
12526 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12527 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12528 (mark_backtrace): Define only if BYTE_MARK_STACK.
12529 * xdisp.c (message_enable_multibyte): Now static.
12530
61c2b50e 12531 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12532 This makes it easier for human readers (and static analyzers)
12533 to see whether these variables are used from other modules.
12534 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12535 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12536 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12537 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12538 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12539 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12540 * xmenu.c, xselect.c:
12541 Declare Q* vars static if they are not used in other modules.
12542 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12543 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12544 Remove decls of unexported vars.
12545 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12546
95c82688
PE
12547 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12548
16a97296
PE
12549 Make Emacs functions such as Fatom 'static' by default.
12550 This makes it easier for human readers (and static analyzers)
12551 to see whether these functions can be called from other modules.
12552 DEFUN now defines a static function. To make the function external
12553 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12554 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12555 (Finit_image_library):
16a97296
PE
12556 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12557 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12558 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12559 Remove decls, since these functions are now static.
12560 (Funintern, Fget_internal_run_time): New decls, since these functions
12561 were already external.
95c82688 12562
16a97296
PE
12563 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12564 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12565 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12566 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12567 * keyboard.c, keymap.c, lread.c:
12568 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12569 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12570 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12571 Mark functions with DEFUE instead of DEFUN,
12572 if they are used in other modules.
12573 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12574 decls for now-static functions.
12575 * buffer.h (Fdelete_overlay): Remove decl.
12576 * callproc.c (Fgetenv_internal): Mark as internal.
12577 * composite.c (Fremove_list_of_text_properties): Remove decl.
12578 (Fcomposition_get_gstring): New forward static decl.
12579 * composite.h (Fcomposite_get_gstring): Remove decl.
12580 * dired.c (Ffile_attributes): New forward static decl.
12581 * doc.c (Fdocumntation_property): New forward static decl.
12582 * eval.c (Ffetch_bytecode): New forward static decl.
12583 (Funintern): Remove extern decl; now in .h file where it belongs.
12584 * fileio.c (Fmake_symbolic_link): New forward static decl.
12585 * image.c (Finit_image_library): New forward static decl.
12586 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12587 * intervals.h (Fprevious_property_change):
12588 (Fremove_list_of_text_properties): Remove decls.
12589 * keyboard.c (Fthis_command_keys): Remove decl.
12590 (Fcommand_execute): New forward static decl.
12591 * keymap.c (Flookup_key): New forward static decl.
12592 (Fcopy_keymap): Now static.
12593 * keymap.h (Flookup_key): Remove decl.
12594 * process.c (Fget_process): New forward static decl.
12595 (Fprocess_datagram_address): Mark as internal.
12596 * syntax.c (Fsyntax_table_p): New forward static decl.
12597 (skip_chars): Remove duplicate decl.
12598 * textprop.c (Fprevious_property_change): New forward static decl.
12599 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12600 Now internal.
12601 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12602 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12603
785bbd42
PE
12604 * editfns.c (Fformat): Remove unreachable code.
12605
8b913b57
AS
126062011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12607
12608 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12609 change. (Bug#8496)
12610
a6744a35
EZ
126112011-04-13 Eli Zaretskii <eliz@gnu.org>
12612
12613 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12614 when at ZV. (Bug#8487)
12615
e7974947
AS
126162011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12617
baad03f0
AS
12618 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12619 (Bug#8437)
12620 * keyboard.c (parse_tool_bar_item): Likewise.
12621 * sound.c (sound_cleanup, alsa_close): Likewise.
12622 * termcap.c (tgetent): Likewise.
12623 * xfns.c (x_default_font_parameter): Likewise.
12624 * xsettings.c (read_and_apply_settings): Likewise.
12625
e7974947
AS
12626 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12627 (overrun_check_free): Protoize.
12628
28272684
PE
126292011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12630
12631 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12632 since callers should never pass a negative size.
12633 Change the signature to match that of plain 'read' and 'write'; see
12634 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12635 * lisp.h: Update prototypes of emacs_write and emacs_read.
12636
11997c76
EZ
126372011-04-11 Eli Zaretskii <eliz@gnu.org>
12638
12639 * xdisp.c (redisplay_window): Don't try to determine the character
12640 position of the scroll margin if the window start point w->startp
e896f03c 12641 is outside the buffer's accessible region. (Bug#8468)
11997c76 12642
8a2cbd72
EZ
126432011-04-10 Eli Zaretskii <eliz@gnu.org>
12644
12645 Fix write-region and its subroutines for buffers > 2GB.
12646 * fileio.c (a_write, e_write): Modify declaration of arguments and
12647 local variables to support buffers larger than 2GB.
12648 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12649
12650 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12651 argument, local variables, and return value.
12652
12653 * lisp.h: Update prototypes of emacs_write and emacs_read.
12654
12655 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12656
4073e537 126572011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12658
1ebfdcb6
PE
12659 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12660
b2ded58d
PE
12661 Fix more problems found by GCC 4.6.0's static checks.
12662
7d66342c
PE
12663 * xdisp.c (vmessage): Use a better test for character truncation.
12664
bbf47d44
PE
12665 * charset.c (load_charset_map): <, not <=, for optimization,
12666 and to avoid potential problems with integer overflow.
9248994d 12667 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12668 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12669 * editfns.c (Fformat): Likewise.
1e69125e 12670 * syntax.c (skip_chars): Likewise.
3befa583 12671
e3019616
PE
12672 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12673 This also lets GCC 4.6.0 generate slightly better loop code.
12674
becfa255
PE
12675 * callint.c (Fcall_interactively): <, not <=, for optimization.
12676 (Fcall_interactively): Count the number of arguments produced,
12677 not the number of arguments given. This is simpler and lets GCC
12678 4.6.0 generate slightly better code.
12679
dae0cd48
PE
12680 * ftfont.c: Distingish more carefully between FcChar8 and char.
12681 The previous code passed unsigned char * to a functions like
12682 strlen and xstrcasecmp that expect char *, which does not
12683 conform to the C standard.
12684 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12685 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12686 char * when the C standard requires it.
12687
76032d70
PE
12688 * keyboard.c (read_char): Remove unused var.
12689
eb3f1cc8
PE
12690 * eval.c: Port to Windows vsnprintf (Bug#8435).
12691 Include <limits.h>.
12692 (SIZE_MAX): Define if the headers do not.
12693 (verror): Do not give up if vsnprintf returns a negative count.
12694 Instead, grow the buffer. This ports to Windows vsnprintf, which
12695 does not conform to C99. Problem reported by Eli Zaretskii.
12696 Also, simplify the allocation scheme, by avoiding the need for
12697 calling realloc, and removing the ALLOCATED variable.
12698
70476b54
PE
12699 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12700
12020a9e
PE
12701 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12702 But keep the doprint source code for now, as we might revamp it
12703 and use it again (Bug#8435).
ea6c7ae6
PE
12704 * lisp.h (doprnt): Remove.
12705 * Makefile.in (base_obj): Remove doprnt.o.
12706 * deps.mk (doprnt.o): Remove.
12707
5fdb398c
PE
12708 error: Print 32- and 64-bit integers portably (Bug#8435).
12709 Without this change, on typical 64-bit hosts error ("...%d...", N)
12710 was used to print both 32- and 64-bit integers N, which relied on
12711 undefined behavior.
61bdb816 12712 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12713 * lisp.h (error, verror): Mark as printf-like functions.
12714 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12715 Report overflow in size calculations when allocating printf buffer.
12716 Do not truncate output string at its first null byte.
12717 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12718 Truncate the output at a character boundary, since vsnprintf does not
12719 do that.
12720 * charset.c (check_iso_charset_parameter): Convert internal
12721 character to string before calling 'error', since %c now has the
12722 printf meaning.
12723 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12724 overflow when computing char to be passed to 'error'. Do not
12725 pass Lisp_Object to 'error'; pass the integer instead.
12726 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12727 formatted with plain %d.
12728
b189fa66
PE
12729 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12730
bff87ef0
PE
12731 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12732
7e2cac20
PE
12733 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12734
ce4d90b5
PE
12735 * xterm.c (x_catch_errors): Remove duplicate declaration.
12736
266c9547
PE
12737 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12738
79c49ad2
PE
12739 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12740
368f4090
JM
127412011-04-10 Jim Meyering <meyering@redhat.com>
12742
12743 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12744 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12745 return ssize_t not "int", and use size_t as the buffer length.
12746 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12747 * gnutls.h: Update declarations.
12748 * process.c (read_process_output): Use ssize_t, to match.
12749 (send_process): Likewise.
12750
a32d4040
CY
127512011-04-09 Chong Yidong <cyd@stupidchicken.com>
12752
12753 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12754
8546720e 127552011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12756
04f2d78b
CB
12757 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12758 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12759
8546720e
GM
12760 * xterm.c (handle_one_xevent):
12761 * xmenu.c (create_and_show_popup_menu):
12762 * xselect.c (x_decline_selection_request)
12763 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12764
0a2f5c1a 127652011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12766
12767 Fix some uses of `int' instead of EMACS_INT.
12768 * search.c (string_match_1, fast_string_match)
12769 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12770 (scan_buffer, find_next_newline_no_quit)
12771 (find_before_next_newline, search_command, Freplace_match)
12772 (Fmatch_data): Make some `int' variables be EMACS_INT.
12773
12774 * xdisp.c (display_count_lines): 3rd argument and return value now
12775 EMACS_INT. All callers changed.
12776 (pint2hrstr): Last argument is now EMACS_INT.
12777
12778 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12779 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12780 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12781 (decode_coding_utf_16, decode_coding_emacs_mule)
12782 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12783 (decode_coding_ccl, decode_coding_charset)
12784 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12785 (decode_coding_iso_2022, decode_coding_emacs_mule)
12786 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12787 <char_offset, last_offset>: Declare EMACS_INT.
12788 (encode_coding_utf_8, encode_coding_utf_16)
12789 (encode_coding_emacs_mule, encode_invocation_designation)
12790 (encode_designation_at_bol, encode_coding_iso_2022)
12791 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12792 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12793 Declare EMACS_INT.
12794 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12795 (encode_invocation_designation): Last argument P_NCHARS is now
12796 EMACS_INT.
12797 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12798 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12799
12800 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12801 All users changed.
12802
12803 * ccl.c (Fccl_execute_on_string): Declare some variables
12804 EMACS_INT.
12805
8546720e 128062011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
12807
12808 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
12809
4e19a977
CS
128102011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
12811
12812 * process.c (Fformat_network_address): Doc fix.
12813
87302331
R
128142011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
12815
ee7683eb 12816 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 12817
cbb59342
CY
128182011-04-08 Chong Yidong <cyd@stupidchicken.com>
12819
12820 * keyboard.c (read_char): Call Lisp function help-form-show,
12821 instead of using internal_with_output_to_temp_buffer.
12822 (Qhelp_form_show): New var.
e0d38eeb 12823 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
12824
12825 * print.c (internal_with_output_to_temp_buffer): Function deleted.
12826
12827 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
12828
e67a13ab
CY
128292011-04-06 Chong Yidong <cyd@stupidchicken.com>
12830
04f2d78b
CB
12831 * process.c (Flist_processes): Remove to Lisp.
12832 (list_processes_1): Delete.
e67a13ab 12833
973f782d
EZ
128342011-04-06 Eli Zaretskii <eliz@gnu.org>
12835
7c106b1e
EZ
12836 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
12837
973f782d
EZ
12838 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
12839
41cf7d1a 128402011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 12841
ca23cc88
PE
12842 Fix more problems found by GCC 4.6.0's static checks.
12843
f390e2d5
PE
12844 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
12845
42eea0d0
PE
12846 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
12847
b69769da 12848 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 12849
f9541e84
PE
12850 * xdisp.c (vmessage): Mark as a printf-like function.
12851
13841b55
PE
12852 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
12853
c136c10f
PE
12854 * sound.c (sound_warning): Don't crash if arg contains a printf format.
12855
5e2d4a30
PE
12856 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
12857 printf-like functions.
12858 (tiff_load): Add casts to remove these marks before passing them
12859 to system-supplied API.
12860
583f48b9
PE
12861 * eval.c (Fsignal): Remove excess argument to 'fatal'.
12862
b25d760e
PE
12863 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
12864 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
12865 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
12866 directly, rather than having caller test rule sign. This avoids
12867 some unnecessary tests.
12868 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
12869 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
12870 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 12871
bc7b6697 12872 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 12873 (xfont_open): Avoid unnecessary tests.
bc7b6697 12874
27ccc379
PE
12875 * composite.c (composition_gstring_put_cache): Use unsigned integer.
12876
dcd5c89a
PE
12877 * composite.h, composite.c (composition_gstring_put_cache):
12878 Use EMACS_INT, not int, for length.
12879
b13a45c6
PE
12880 * composite.h (COMPOSITION_DECODE_REFS): New macro,
12881 breaking out part of COMPOSITION_DECODE_RULE.
12882 (COMPOSITION_DECODE_RULE): Use it.
12883 * composite.c (get_composition_id): Remove unused local vars,
12884 by using the new macro.
12885
1e792e4d
PE
12886 * textprop.c (set_text_properties_1): Change while to do-while,
12887 since the condition is always true at first.
12888
dc6c6455 12889 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
12890 (interval_deletion_adjustment): Return unsigned value.
12891 All uses changed.
dc6c6455 12892
aba7731a
PE
12893 * process.c (list_processes_1, create_pty, read_process_output):
12894 (exec_sentinel): Remove vars that were set but not used.
afd4052b 12895 (create_pty): Remove unnecessary "volatile"s.
bc57d757 12896 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 12897 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 12898 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 12899
fdfc4bf3
PE
12900 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
12901
fca8fe46 12902 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 12903 (update_syntax_table): Use unsigned instead of int.
fca8fe46 12904
06a0259a 12905 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 12906 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 12907 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 12908
e7b9e80f
PE
12909 * print.c (print_error_message): Avoid int overflow.
12910
56201685
PE
12911 * font.c (font_list_entities): Redo for clarity,
12912 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
12913
78834453 12914 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 12915 (font_score): Avoid potential overflow in diff calculation.
78834453 12916
0bc0b309 12917 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 12918 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 12919
e610eaca
PE
12920 * eval.c (funcall_lambda): Rename local to avoid shadowing.
12921
b895abce
PE
12922 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
12923 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
12924 can always succeed if overflow has undefined behavior.
12925
1f1d9321 12926 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 12927 (wordify): Omit three unnecessary tests.
1f1d9321 12928
c59478bc
PE
12929 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
12930 All callers changed. This avoids the need for an unused var.
12931
79b73827
PE
12932 * casefiddle.c (casify_region): Remove var that is set but not used.
12933
a4db5dfe
PE
12934 * dired.c (file_name_completion): Remove var that is set but not used.
12935
43aae36e
PE
12936 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
12937
2a47c44d 12938 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 12939 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 12940
a37c69bf
PE
12941 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
12942 Check for integer overflow on size calculations.
12943
328ab8e7
PE
12944 * buffer.c (Fprevious_overlay_change): Remove var that is set
12945 but not used.
12946
e5a2a5cb
PE
12947 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
12948 Remove vars that are set but not used.
8d84a6eb 12949 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 12950 (timer_check_2): Mark vars as initialized.
e5a2a5cb 12951
a60e5f68
PE
12952 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
12953
f661cb61 12954 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 12955 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 12956
f0397f5a
PE
12957 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
12958 that are set but not used.
12959
8664db06 12960 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 12961 if XCreateBitmapFromData fails (Bug#8410).
8664db06 12962
6abdaa4a
PE
12963 * xselect.c (x_get_local_selection, x_handle_property_notify):
12964 Remove vars that are set but not used.
12965
0ce7538d 12966 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 12967 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 12968
9ae848fc
PE
12969 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
12970 Remove var that is set but not used.
0b918413
PE
12971 (scroll_bar_windows_size): Now size_t, not int.
12972 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
12973 Check for overflow.
9ae848fc 12974
a5a62657
PE
12975 * xfaces.c (realize_named_face): Remove vars that are set but not used.
12976 (map_tty_color) [!defined MSDOS]: Likewise.
12977
5c5cdd39
PE
12978 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
12979
66ebf983
PE
12980 * coding.c: Remove vars that are set but not used.
12981 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
12982 All callers changed.
12983 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
12984 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
12985 (decode_coding_charset): Remove vars that are set but not used.
12986
1be4d761
PE
12987 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
12988 that is set but not used.
12989
47553fa8
PE
12990 * print.c (print_object): Remove var that is set but not used.
12991
1f7196bf 12992 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
12993 The gnulib version avoids calling malloc in the usual case,
12994 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
12995 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
12996 * filelock.c (current_lock_owner): Likewise.
12997 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
12998 * sysdep.c: Include allocator.h, careadlinkat.h.
12999 (emacs_no_realloc_allocator): New static constant.
13000 (emacs_readlink): New function.
fdb61804
PE
13001 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13002 ../lib/careadlinkat.h.
d1fdcab7 13003
f84c17c7
SM
130042011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13005
13006 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13007 first non-nil return value).
13008
ef3862ad
JD
130092011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13010
13011 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13012 if not defined (Bug#8403).
13013
376a7006
JB
130142011-04-02 Juanma Barranquero <lekktu@gmail.com>
13015
13016 * xdisp.c (display_count_lines): Remove parameter `start',
13017 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13018 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13019 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13020 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13021 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13022 and thereabouts. All callers changed.
13023 (get_per_char_metric): Remove parameter `f', unused since
13024 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13025
6ca3801d
JM
130262011-04-02 Jim Meyering <meyering@redhat.com>
13027
13028 do not dereference NULL upon failed strdup
13029 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13030 (ns_get_family): Likewise.
13031
d8e2b5ba
JB
130322011-04-02 Juanma Barranquero <lekktu@gmail.com>
13033
13034 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13035
8c74fcbd
JD
130362011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13037
13038 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13039 later (Bug#8403).
13040
7200d79c
SM
130412011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13042
03408648 13043 Add lexical binding.
7200d79c 13044
03408648
SM
13045 * window.c (Ftemp_output_buffer_show): New fun.
13046 (Fsave_window_excursion):
13047 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13048
13049 * lread.c (lisp_file_lexically_bound_p): New function.
13050 (Fload): Bind Qlexical_binding.
13051 (readevalloop): Remove `evalfun' arg.
13052 Bind Qinternal_interpreter_environment.
13053 (Feval_buffer): Bind Qlexical_binding.
13054 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13055 Mark as dynamic.
13056 (syms_of_lread): Declare `lexical-binding'.
13057
13058 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13059
13060 * keyboard.c (eval_dyn): New fun.
13061 (menu_item_eval_property): Use it.
ca105506
SM
13062
13063 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13064
03408648
SM
13065 * fns.c (concat, mapcar1): Accept byte-code-functions.
13066
13067 * eval.c (Fsetq): Handle lexical vars.
13068 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13069 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13070 (FletX, Flet): Obey lexical binding.
13071 (Fcommandp): Handle closures.
13072 (Feval): New `lexical' arg.
13073 (eval_sub): New function extracted from Feval. Use it almost
13074 everywhere where Feval was used. Look up vars in lexical env.
13075 Handle closures.
13076 (Ffunctionp): Move from subr.el.
13077 (Ffuncall): Handle closures.
13078 (apply_lambda): Remove `eval_flags'.
13079 (funcall_lambda): Handle closures and new byte-code-functions.
13080 (Fspecial_variable_p): New function.
13081 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13082 but without exporting it to Lisp.
23aba0ea 13083
23aba0ea 13084 * doc.c (Fdocumentation, store_function_docstring):
03408648 13085 * data.c (Finteractive_form): Handle closures.
23aba0ea 13086
03408648
SM
13087 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13088 interactive spec.
ba83908c 13089
04f2d78b
CB
13090 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13091 New byte-codes.
03408648
SM
13092 (exec_byte_code): New function extracted from Fbyte_code to handle new
13093 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13094
03408648 13095 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13096
03408648 13097 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13098
e2abce01
JB
130992011-03-31 Juanma Barranquero <lekktu@gmail.com>
13100
13101 * xdisp.c (redisplay_internal): Fix prototype.
13102
63696a73 131032011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13104
63696a73 13105 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13106 (try_scrolling): Use it when setting scroll_limit.
13107 Limit scrolling to 100 screen lines.
63696a73
EZ
13108 (redisplay_window): Even when falling back on "recentering",
13109 position point in the window according to scroll-conservatively,
13110 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13111
13112 (try_scrolling): When point is above the window, allow searching
13113 as far as scroll_max, or one screenful, to compute vertical
13114 distance from PT to the scroll margin position. This prevents
13115 try_scrolling from unnecessarily failing when
13116 scroll-conservatively is set to a value slightly larger than the
13117 window height. Clean up the case of PT below the margin at bottom
13118 of window: scroll_max can no longer be INT_MAX. When aggressive
13119 scrolling is in use, don't let point enter the opposite scroll
13120 margin as result of the scroll.
13121 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13122 threshold of 100 lines for never-recentering scrolling.
13123
e4cc2dfc
JB
131242011-03-31 Juanma Barranquero <lekktu@gmail.com>
13125
13126 * dispextern.h (move_it_by_lines):
13127 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13128 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13129 (message_log_check_duplicate): Remove parameters `prev_bol' and
13130 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13131 (redisplay_internal): Remove parameter `preserve_echo_area',
13132 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13133
13134 * indent.c (Fvertical_motion):
13135 * window.c (window_scroll_pixel_based, Frecenter):
13136 Don't pass `need_y_p' to `move_it_by_lines'.
13137
1c470562
SM
131382011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13139
44f230aa
SM
13140 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13141 steal a few bits to be more compact.
13142 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13143 Remove unneeded casts.
13144
1c470562
SM
13145 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13146
888adce9
ZK
131472011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13148
13149 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13150 binding" message (bug#7967).
13151
f838ed7b
PE
131522011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13153
77861b95
PE
13154 Fix more problems found by GCC 4.6.0's static checks.
13155
de6dbc14
PE
13156 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13157 Remove unused local var.
13158
f838ed7b
PE
13159 * editfns.c (Fmessage_box): Remove unused local var.
13160
792c7b2b
PE
13161 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13162 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13163 Omit unused local vars.
c499e557 13164 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13165 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13166 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13167 Omit unused local var.
13168
ba0165e1
PE
13169 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13170 Don't assume string length fits in int.
32ad8845 13171 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13172 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13173
3c59b4c9
PE
13174 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13175 instead of alloca (Bug#8344).
13176
a3eed478 13177 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13178 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13179
eb4d412d
PE
13180 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13181
1658b401
PE
13182 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13183 concerns.
13184
13185 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13186
13187 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13188
9a2c6e05
PE
13189 * keyboard.c (syms_of_keyboard): Use the same style as later
13190 in this function when indexing through an array. This also
13191 works around GCC bug 48267.
13192
03d0a109
PE
13193 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13194
44f730c8
PE
13195 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13196
fe75f926
PE
13197 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13198 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13199
ffa8c828
PE
13200 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13201 This avoids undefined behavior on integer overflow, and is a bit
13202 more convenient anyway since it is compared to a size_t variable.
13203
c5101a77
PE
13204 Variadic C functions now count arguments with size_t, not int.
13205 This avoids an unnecessary limitation on 64-bit machines, which
13206 caused (substring ...) to crash on large vectors (Bug#8344).
13207 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13208 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13209 All variadic functions and their callers changed accordingly.
c5101a77
PE
13210 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13211 * data.c (arith_driver, float_arith_driver): Likewise.
13212 * editfns.c (general_insert_function): Likewise.
13213 * eval.c (struct backtrace.nargs, interactive_p)
13214 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13215 (funcall_lambda, mark_backtrace): Likewise.
13216 * fns.c (concat): Likewise.
13217 * frame.c (x_set_frame_parameters): Likewise.
13218 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13219 0 if not found, not -1. All callers changed.
13220
dd3f25f7
PE
13221 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13222 (stack_copy_size): Now size_t, not int.
13223 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13224
461c2ab9
JB
132252011-03-28 Juanma Barranquero <lekktu@gmail.com>
13226
13227 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13228 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13229 All callers changed.
13230
13231 * lisp.h (multibyte_char_to_unibyte):
13232 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13233 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13234 * character.h (CHAR_TO_BYTE8):
13235 * cmds.c (internal_self_insert):
13236 * editfns.c (general_insert_function):
13237 * keymap.c (push_key_description):
13238 * search.c (Freplace_match):
13239 * xdisp.c (message_dolog, set_message_1): All callers changed.
13240
f6d62986
SM
132412011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13242
13243 * keyboard.c (safe_run_hook_funcall): New function.
13244 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13245 don't set the hook to nil, but remove the offending function instead.
13246 (Qcommand_hook_internal): Remove, unused.
13247 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13248 Vcommand_hook_internal.
13249
13250 * eval.c (enum run_hooks_condition): Remove.
13251 (funcall_nil, funcall_not): New functions.
13252 (run_hook_with_args): Call each function through a `funcall' argument.
13253 Remove `cond' argument, now redundant.
13254 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13255 (Frun_hook_with_args_until_failure): Adjust accordingly.
13256 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13257
1db5b1ad
JB
132582011-03-28 Juanma Barranquero <lekktu@gmail.com>
13259
13260 * dispextern.h (string_buffer_position): Remove declaration.
13261
13262 * print.c (strout): Remove parameter `multibyte', unused since
13263 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13264
13265 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13266 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13267 All callers changed.
13268
13269 * w32.c (_wsa_errlist): Use braces for struct initializers.
13270
13271 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13272 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13273 All callers changed.
13274 (string_buffer_position): Likewise. Also, make static (it's never
13275 used outside xdisp.c).
13276 (cursor_row_p): Remove parameter `w', unused since
13277 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13278 (decode_mode_spec): Remove parameter `precision', introduced during
13279 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13280 All callers changed.
13281
5ffb62aa
JD
132822011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13283
13284 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13285
461c2ab9 132862011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13287
13288 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13289 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13290 (ns_update_auto_hide_menu_bar): New functions.
13291 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13292 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13293 ns_constrain_all_frames.
13294 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13295 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13296
5c380ffb
JD
132972011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13298
13299 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13300
9af30bdf
GM
133012011-03-27 Glenn Morris <rgm@gnu.org>
13302
13303 * syssignal.h: Replace RETSIGTYPE with void.
13304 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13305 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13306 Replace SIGTYPE with void everywhere.
13307 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13308 * s/template.h (SIGTYPE): Remove commented out definition.
13309
e2abce01
JB
133102011-03-26 Eli Zaretskii <eliz@gnu.org>
13311
13312 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13313 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13314
f868cd8a
JB
133152011-03-26 Juanma Barranquero <lekktu@gmail.com>
13316
59eb0929
JB
13317 * w32.c (read_unc_volume): Use parameter `henum', instead of
13318 global variable `wget_enum_handle'.
13319
13320 * keymap.c (describe_vector): Remove parameters `indices' and
13321 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13322 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13323
f868cd8a
JB
13324 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13325
13326 * keyboard.c (timer_check): Remove parameter `do_it_now',
13327 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13328 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13329 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13330
13331 * keyboard.c (read_char):
13332 * w32menu.c (w32_menu_display_help):
13333 * xmenu.c (show_help_event, menu_help_callback):
13334 Adjust calls to `show_help_echo'.
13335
13336 * gtkutil.c (xg_maybe_add_timer):
13337 * keyboard.c (readable_events):
13338 * process.c (wait_reading_process_output):
13339 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13340
13341 * insdel.c (adjust_markers_gap_motion):
13342 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13343 (gap_left, gap_right): Don't call it.
13344
2ecf6fdb
CY
133452011-03-25 Chong Yidong <cyd@stupidchicken.com>
13346
13347 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13348 incurred during fontification.
13349
6b1f9ba4
JB
133502011-03-25 Juanma Barranquero <lekktu@gmail.com>
13351
13352 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13353 (DEFVAR_PER_BUFFER): Don't pass it.
13354
13355 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13356 (scrolling_window): Don't pass it.
13357
0f4a96b5
JB
133582011-03-25 Juanma Barranquero <lekktu@gmail.com>
13359
13360 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13361
13362 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13363 and `suffix'.
13364 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13365 of variables specific to SELinux and computation of `encoded_absname'.
13366
13367 * image.c (XPutPixel): Remove unused variable `height'.
13368
13369 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13370
13371 * unexw32.c (get_section_info): Remove unused variable `section'.
13372
13373 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13374 (system_process_attributes): Remove unused variable `sess'.
13375 (sys_read): Remove unused variable `err'.
13376
13377 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13378 (w32_wnd_proc): Remove unused variable `isdead'.
13379 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13380 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13381 (x_create_tip_frame): Remove unused variable `tem'.
13382
13383 * w32inevt.c (w32_console_read_socket):
13384 Remove unused variable `no_events'.
13385
13386 * w32term.c (x_draw_composite_glyph_string_foreground):
13387 Remove unused variable `width'.
13388
1149507c
JB
133892011-03-24 Juanma Barranquero <lekktu@gmail.com>
13390
13391 * w32term.c (x_set_glyph_string_clipping):
13392 Don't pass uninitialized region to CombineRgn.
13393
9c88f339
JB
133942011-03-23 Juanma Barranquero <lekktu@gmail.com>
13395
13396 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13397 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13398 (Fx_close_connection): Remove unused variable `i'.
13399
13400 * w32font.c (w32font_draw): Return number of glyphs.
13401 (w32font_open_internal): Remove unused variable `i'.
13402 (w32font_driver): Add missing initializer.
13403
13404 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13405 (fill_in_menu): Remove unused variable `items_added'.
13406
13407 * w32term.c (last_mouse_press_frame): Remove static global variable.
13408 (w32_clip_to_row): Remove unused variable `f'.
13409 (x_delete_terminal): Remove unused variable `i'.
13410
13411 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13412 (NOTHING): Remove unused static global variable.
13413 (uniscribe_check_otf): Remove unused variable `table'.
13414 (uniscribe_font_driver): Add missing initializers.
13415
dee091a3
JD
134162011-03-23 Julien Danjou <julien@danjou.info>
13417
13418 * term.c (Fsuspend_tty, Fresume_tty):
13419 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13420 * window.c (temp_output_buffer_show):
13421 * insdel.c (signal_before_change):
13422 * frame.c (Fhandle_switch_frame):
13423 * fileio.c (Fdo_auto_save):
13424 * emacs.c (Fkill_emacs):
13425 * editfns.c (save_excursion_restore):
13426 * cmds.c (internal_self_insert):
13427 * callint.c (Fcall_interactively):
13428 * buffer.c (Fkill_all_local_variables):
13429 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13430 Use Frun_hooks.
0f4a96b5 13431 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13432 unconditionally since it does the check itself.
dee091a3 13433
2c520ab5 134342011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13435
c9c49752
PE
13436 Fix more problems found by GCC 4.5.2's static checks.
13437
8abc3f12
PE
13438 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13439 the first time through the loop, since we know p0 < p1 then.
13440 This also avoids a gcc -Wstrict-overflow warning.
13441
a2d26660
PE
13442 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13443 leading to a memory leak, possible in functions like
13444 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13445 of objects (Bug#8318).
a2d26660 13446
916c72e9
PE
13447 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13448 that could (at least in theory) be that large.
13449
19ab8a18
PE
13450 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13451 This is less likely to overflow, and avoids undefined behavior if
13452 overflow does occur. All callers changed. Use strtoul to scan
13453 for the unsigned long integer.
b7cbbd6f
PE
13454 (pint2hrstr): Simplify and tune code slightly.
13455 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13456
f0641eff
PE
13457 * scroll.c (do_scrolling): Work around GCC bug 48228.
13458 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13459
7f650bb9
PE
13460 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13461 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13462 (validate_x_resource_name): Simplify count usage.
13463 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13464
37dd57d1
PE
13465 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13466 fail (Bug#8306).
81e56e61 13467
699979fc 13468 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13469
401bf9b4
PE
13470 * process.c (Fmake_network_process): Use socklen_t, not int,
13471 where POSIX says socklen_t is required in portable programs.
13472 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13473 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13474 (Fmake_network_process, server_accept_connection):
13475 (wait_reading_process_output, read_process_output):
13476 Likewise.
13477
b93aacde
PE
13478 * process.c: Rename or move locals to avoid shadowing.
13479 (list_processes_1, Fmake_network_process):
13480 (read_process_output_error_handler, exec_sentinel_error_handler):
13481 Rename or move locals.
4dc343ee 13482 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13483 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13484 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13485 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13486 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13487
af8a867c 13488 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13489 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13490 Include tparam.h instead, since it declares them.
af8a867c
PE
13491 * cm.h (PC): Remove extern decl; tparam.h now does this.
13492 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13493 * terminfo.c: Include tparam.h, to check interfaces.
13494 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13495 (tparam): Adjust signature to match interface in tparam.h;
13496 this removes some undefined behavior. Check that outstring and len
13497 are zero, which they always are with Emacs.
13498 * tparam.h (PC, BC, UP): New extern decls.
13499
0248044d 13500 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13501 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13502
8ff096c1 13503 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13504 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13505 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13506 (ftfont_list): Remove unused local.
49eaafba
PE
13507 (get_adstyle_property, ftfont_pattern_entity):
13508 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13509 Rename locals to avoid shadowing.
8ff096c1 13510
e2be39f6
PE
13511 * xfont.c (xfont_list_family): Mark var as initialized.
13512
c9735e30
PE
13513 * xml.c (make_dom): Now static.
13514
8f5201ae
PE
13515 * composite.c (composition_compute_stop_pos): Rename local to
13516 avoid shadowing.
b246f932
PE
13517 (composition_reseat_it): Remove unused locals.
13518 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13519 (composition_update_it): Mark var as initialized.
11b61122
PE
13520 (find_automatic_composition): Mark vars as initialized,
13521 with a FIXME (Bug#8290).
8f5201ae 13522
760fbc2c
PE
13523 character.h: Rename locals to avoid shadowing.
13524 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13525 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13526 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13527 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13528 to avoid shadowing.
13529
ff08eb85
PE
13530 * textprop.c (property_change_between_p): Remove; unused.
13531
fc7bf025
PE
13532 * intervals.c (interval_start_pos): Now static.
13533
235d7abc
PE
13534 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13535
44f230aa
SM
13536 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13537 Rename locals to avoid shadowing.
3e7d6594 13538
50060332
PE
13539 * sound.c (wav_play, au_play, Fplay_sound_internal):
13540 Fix pointer signedness.
d01f234b 13541 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13542 (wav_play): Initialize a variable to 0, to prevent undefined
13543 behavior (Bug#8278).
50060332 13544
c4fc4e30
PE
13545 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13546
918436ed
PE
13547 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13548
c939f91b
PE
13549 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13550 clobbering (Bug#8298).
b9c7f648
PE
13551 * sysdep.c (sys_subshell): Likewise.
13552 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13553
6bd8c144
PE
13554 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13555 This should get cleaned up, so that child_setup has the
13556 same signature on all platforms.
13557
7710357c 13558 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13559 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13560
c59da222
CY
135612011-03-22 Chong Yidong <cyd@stupidchicken.com>
13562
13563 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13564 not to be necessary, and produces flickering.
13565
66b87493
GM
135662011-03-20 Glenn Morris <rgm@gnu.org>
13567
13568 * config.in: Remove file.
13569
45b6f6d5
JB
135702011-03-20 Juanma Barranquero <lekktu@gmail.com>
13571
13572 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13573 are now in src/globals.h.
13574 (syms_of_minibuf): Remove spurious & from previous change.
13575
cd394be1 135762011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13577
13578 * minibuf.c (completing-read-function): New variable.
13579 (completing-read-default): Rename from completing-read.
13580 (completing-read): Call completing-read-function.
13581
b14e3e21
CY
135822011-03-19 Juanma Barranquero <lekktu@gmail.com>
13583
13584 * xfaces.c (Fx_load_color_file):
13585 Read color file from absolute filename (bug#8250).
13586
f2b726e6
JB
135872011-03-19 Juanma Barranquero <lekktu@gmail.com>
13588
13589 * makefile.w32-in: Update dependencies.
13590
09f6ff02
EZ
135912011-03-17 Eli Zaretskii <eliz@gnu.org>
13592
13593 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13594
29a6015a
PE
135952011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13596
a3a6c54e
PE
13597 Fix more problems found by GCC 4.5.2's static checks.
13598
b766f867
PE
13599 * process.c (make_serial_process_unwind, send_process_trap):
13600 (sigchld_handler): Now static.
13601
be02381c
PE
13602 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13603 That way, the code declares only the vars that it needs.
13604 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13605 * s/cygwin.h (PTY_ITERATION): Likewise.
13606 * s/darwin.h (PTY_ITERATION): Likewise.
13607 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13608
57048744
PE
13609 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13610 * process.c (allocate_pty): Don't declare stb unless it's needed.
13611
7914961c 13612 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13613 (CONSTANTLIM): Remove; unused.
13614 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13615 Define only if needed.
7914961c 13616
b3967b18
PE
13617 * unexelf.c (unexec): Name an expression,
13618 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13619 Use a different way to cause a compilation error if anyone uses
13620 n rather than nn, a way that does not involve shadowing.
73366a00 13621 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13622
29a6015a
PE
13623 * deps.mk (unexalpha.o): Remove; unused.
13624
43cfc33e 13625 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13626 * unexec.h: New file.
ce701a33
PE
13627 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13628 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13629 Depend on unexec.h.
13630 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13631 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13632 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13633 Change as necessary to match prototype in unexec.h.
ce701a33 13634
01f44d5a
PE
13635 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13636 shadowing.
4f63c6bb 13637 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13638
a6670b0b
PE
13639 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13640 Rename locals to avoid shadowing.
13641
cef2010d 13642 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13643 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13644
d4d7173a
PE
13645 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13646
f08b802a
PE
13647 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13648 warning when compiling print.c.
13649
3ddb0639
PE
13650 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13651 instead of using an uninitialized var.
5ad03b97 13652 (font_sort_entities): Mark var as initialized.
3ddb0639 13653
170a2692
PE
13654 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13655
e663c700
PE
13656 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13657 pointers to constants.
89bc529a 13658 (font_parse_fcname): Remove unused vars.
7b81e2d0 13659 (font_delete_unmatched): Now static.
ea838e10 13660 (font_get_spec): Remove; unused.
13a547c6
PE
13661 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13662 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13663 Rename or move locals to avoid shadowing.
e663c700 13664
2a80c887 13665 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13666 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13667
1384fa33 13668 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13669 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13670
8b2c52e9
PE
13671 * alloc.c (mark_backtrace): Move decl from here ...
13672 * lisp.h: ... to here, so that it can be checked.
13673
475545b5 13674 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13675 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13676 (lisp_indirect_variable): Name an expression,
13677 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13678 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13679
b1349114 13680 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13681 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13682 Use const pointer when appropriate.
b1349114 13683
a2928364
PE
13684 * lisp.h (get_system_name, get_operating_system_release):
13685 Move decls here, to check interfaces.
13686 * process.c (get_operating_system_release): Move decl to lisp.h.
13687 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13688 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13689 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13690 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13691 (Fformat_time_string, Fencode_time, Finsert_char):
13692 (Ftranslate_region_internal, Fformat):
13693 Rename or remove local vars to avoid shadowing.
9710023e 13694 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13695
a415e694
PE
13696 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13697 avoid shadowing.
13698
8ef4622d
PE
13699 * lisp.h (eassert): Check that the argument compiles, even if
13700 ENABLE_CHECKING is not defined.
13701
946f9a5b
PE
13702 * data.c (Findirect_variable): Name an expression, to avoid
13703 gcc -Wbad-function-cast warning.
112396d6 13704 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13705 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13706 (Fmake_variable_buffer_local, Fmake_local_variable):
13707 Mark variables as initialized.
52746918 13708 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13709
e5aab7e7 13710 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13711 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13712 Rename locals to avoid shadowing.
dff45157
PE
13713 (mark_stack): Move local variables into the #ifdef region where
13714 they're used.
7bc26fdb
PE
13715 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13716 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13717 needed otherwise.
13718 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13719 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13720 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13721
e5aab7e7
PE
13722 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13723 avoids undefined behavior in theory.
13724
4da60324
PE
13725 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13726
88043301
PE
13727 Use functions, not macros, for up- and down-casing (Bug#8254).
13728 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13729 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13730 to use the following functions instead of these macros.
13731 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13732 EMACS_INT, since callers assume the returned value fits in int.
13733 (upcase1): Likewise, for UPCASE_TABLE.
13734 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13735 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13736 the race-condition problem in the old DOWNCASE.
88043301 13737
19ed5445
PE
13738 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13739 Rename locals to avoid shadowing.
13740 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13741 (regex_compile, re_search_2, re_match_2_internal):
13742 Remove unused local vars.
952db0d7
PE
13743 (FREE_VAR): Rewrite so as not to use empty "else",
13744 which gcc can warn about.
da053e48 13745 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13746 (RETALLOC_IF): Define only if needed.
13747 (WORDCHAR_P): Likewise. This one is never needed, but is used
13748 only in a comment talking about a compiler bug, so put inside
13749 the #if 0 of that comment.
13750 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13751 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13752 Remove; unused.
19ed5445 13753
1f3561e4 13754 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13755 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13756 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13757
ded6f8f7
PE
13758 * search.c (simple_search): Remove unused var.
13759
dbd37a95
PE
13760 * dired.c (compile_pattern): Move decl from here ...
13761 * lisp.h: ... to here, so that it can be checked.
13762 (struct re_registers): New forward decl.
13763
7e47afad
PE
13764 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13765
85f24f61
PE
13766 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13767 All uses changed.
13768 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13769 Rename locals to avoid shadowing.
5671df8f 13770 (Fvertical_motion): Mark locals as initialized.
85f24f61 13771
181aa2be 13772 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13773 (casify_region): Mark local as initialized.
181aa2be 13774
930d429c
PE
13775 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13776
7082eac6
PE
13777 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13778 New macros, so that the caller can use some names other than
13779 gcpro1, gcpro2, etc.
13780 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13781 of the new macros.
13782 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13783 argument, for consistency with GCPRO2_VAR, etc: it is now the
13784 prefix of the variable, not the variable itself. All uses
13785 changed.
38b2c076
PE
13786 * dired.c (directory_files_internal, file_name_completion):
13787 Rename locals to avoid shadowing.
13788
15206ed9
PE
13789 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13790 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13791 dired.c's scmp function, had undefined behavior.
13792 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13793 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13794 * buffer.h: ... to here, because these macros use current_buffer,
13795 and the new implementation with inline functions needs to have
13796 current_buffer in scope now, rather than later when the macros
13797 are used.
13798 (downcase, upcase1): New static inline functions.
13799 (DOWNCASE, UPCASE1): Reimplement using these functions.
13800 This avoids undefined behavior in expressions like
13801 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13802 from race conditions in accessing the global variables
13803 case_temp1 and case_temp2.
13804 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13805 * lisp.h (case_temp1, case_temp2): Remove their decls.
13806 * character.h (ASCII_CHAR_P): Move from here ...
13807 * lisp.h: ... to here, so that the inline functions mentioned
13808 above can use them.
13809
4a6bea26
PE
13810 * dired.c (directory_files_internal_unwind): Now static.
13811
f14b7e14
PE
13812 * fileio.c (file_name_as_directory, directory_file_name):
13813 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
13814 Now static.
2893f146
PE
13815 (file_name_as_directory): Use const pointers when appropriate.
13816 (Fexpand_file_name): Likewise. In particular, newdir might
13817 point at constant storage, so make it a const pointer.
fd4ead52 13818 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
13819 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
13820 signedness issues.
f839df0c
PE
13821 (Fset_file_times, Finsert_file_contents, auto_save_error):
13822 Rename locals to avoid shadowing.
f14b7e14 13823
5716756e 13824 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
13825 (Ftry_completion, Fall_completions): Rename or remove locals
13826 to avoid shadowing.
5716756e 13827
b4c3046a
PE
13828 * marker.c (bytepos_to_charpos): Remove; unused.
13829
b45db522
PE
13830 * lisp.h (verify_bytepos, count_markers): New decls,
13831 so that gcc does not warn that these functions aren't declared.
13832
85876d07
PE
13833 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
13834 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 13835 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 13836 (copy_text): Remove unused local var.
85876d07 13837
03d78a21 13838 * filelock.c (within_one_second): Now static.
b3dd38ab 13839 (lock_file_1): Rename local to avoid shadowing.
03d78a21 13840
5df8f01b
PE
13841 * buffer.c (fix_overlays_before): Mark locals as initialized.
13842 (fix_start_end_in_overlays): Likewise. This function should be
13843 simplified by using pointers-to-pointers, but that's a different
13844 matter.
b1d876f1 13845 (switch_to_buffer_1): Now static.
8f54f30a
PE
13846 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
13847 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 13848
a70072c9 13849 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 13850 Fix pointer signedness issue.
edced198
PE
13851 (sys_subshell): Mark local as volatile if checking for lint,
13852 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 13853 (MAXPATHLEN): Define only if needed.
a70072c9 13854
a0977c44
PE
13855 * process.c (serial_open, serial_configure): Move decls from here ...
13856 * systty.h: ... to here, so that they can be checked.
13857
a884fdcc
PE
13858 * fns.c (get_random, seed_random): Move extern decls from here ...
13859 * lisp.h: ... to here, so that they can be checked.
13860
604efe86 13861 * sysdep.c (reset_io): Now static.
b8950c94 13862 (wait_for_termination_signal): Remove; unused.
604efe86 13863
38fc62d9
PE
13864 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
13865 (copy_keymap_item, append_key, push_text_char_description):
13866 Now static.
1004a21a 13867 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 13868 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
13869 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
13870 (describe_map_tree):
13871 Rename locals to avoid shadowing.
38fc62d9 13872
2f2650da
PE
13873 * keyboard.c: Declare functions static if they are not used elsewhere.
13874 (echo_char, echo_dash, cmd_error, top_level_2):
13875 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
13876 (read_char, kbd_buffer_get_event, make_lispy_position):
13877 (make_lispy_event, make_lispy_movement, apply_modifiers):
13878 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
13879 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
13880 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 13881 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 13882 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 13883
a053e86c 13884 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
13885 (mark_kboards): Move decl here ...
13886 * alloc.c (mark_kboards): ... from here.
a053e86c 13887
4752793e
PE
13888 * lisp.h (force_auto_save_soon): New decl.
13889
74f10ca7 13890 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
13891 (DEFINE_DUMMY_FUNCTION): New macro.
13892 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
13893 Use it.
c03cd23f
PE
13894 (main): Add casts to avoid warnings
13895 if GCC considers string literals to be constants.
74f10ca7 13896
022e70d4
PE
13897 * lisp.h (fatal_error_signal): Add decl, since it's exported.
13898
59d6fe83
PE
13899 * dbusbind.c: Pointer signedness fixes.
13900 (xd_signature, xd_append_arg, xd_initialize):
13901 (Fdbus_call_method, Fdbus_call_method_asynchronously):
13902 (Fdbus_method_return_internal, Fdbus_method_error_internal):
13903 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
13904 (Fdbus_register_signal): Use SSDATA when the context wants char *.
13905
78320123
PE
13906 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
13907 if GCC considers string literals to be constants.
49cebcca 13908 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 13909
35ac2a97
SM
139102011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
13911
fb103ca9
SM
13912 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
13913 (print_preprocess, print_object): New macro to fix last change.
13914
35ac2a97
SM
13915 * print.c (print_preprocess): Don't forget font objects.
13916
62973b41
JB
139172011-03-16 Juanma Barranquero <lekktu@gmail.com>
13918
13919 * emacs.c (USAGE3): Doc fixes.
13920
0e48bb22
AS
139212011-03-15 Andreas Schwab <schwab@linux-m68k.org>
13922
13923 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
13924 structure.
13925
7684e57b
JB
139262011-03-14 Juanma Barranquero <lekktu@gmail.com>
13927
13928 * lisp.h (VWindow_system, Qfile_name_history):
13929 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
13930 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
13931 (w32_system_caret_x, w32_system_caret_y): Declare extern.
13932
13933 * w32select.c: Don't #include "keyboard.h".
c96bbc66 13934 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
13935
13936 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
13937 * w32console.c (detect_input_pending, read_input_pending)
13938 (encode_terminal_code):
13939 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
13940 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
13941 (w32_system_caret_y, Qfile_name_history):
13942 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
13943 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
13944 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
13945 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
13946 * w32proc.c (Qlocal, report_file_error):
13947 * w32term.c (Vwindow_system, updating_frame):
13948 * w32uniscribe.c (initialized, uniscribe_font_driver):
13949 Remove unneeded extern declarations.
13950
2aa46d6c
CY
139512011-03-14 Chong Yidong <cyd@stupidchicken.com>
13952
c96bbc66 13953 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 13954
cffc6f3b
CY
139552011-03-13 Chong Yidong <cyd@stupidchicken.com>
13956
13957 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
13958 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
13959 These macros can no longer be used for assignment.
13960
44f230aa
SM
13961 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
13962 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
13963 (record_buffer_markers, fetch_buffer_markers): New functions for
13964 recording and fetching special buffer markers.
13965 (set_buffer_internal_1, set_buffer_temp): Use them.
13966
13967 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
13968
13969 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
13970
13971 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
13972 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
13973
13974 * xdisp.c (hscroll_window_tree):
13975 (reconsider_clip_changes): Use PT instead of BUF_PT.
13976
d251f04b
EZ
139772011-03-13 Eli Zaretskii <eliz@gnu.org>
13978
13979 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
13980 $(EMACS_ROOT)/lib/intprops.h.
13981
f0c77cd1
PE
139822011-03-13 Paul Eggert <eggert@cs.ucla.edu>
13983
3eca4629
PE
13984 Fix more problems found by GCC 4.5.2's static checks.
13985
7c86ee98
PE
13986 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
13987 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
13988 (xg_free_frame_widgets): Make it clear that a local variable is
13989 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
13990 (gdk_window_get_screen): Make it clear that this macro is needed
13991 only if USE_GTK_TOOLTIP.
1e5524e7
PE
13992 (int_gtk_range_get_value): New function, which avoids a diagnostic
13993 from gcc -Wbad-function-cast.
13994 (xg_set_toolkit_scroll_bar_thumb): Use it.
13995 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
13996 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
13997 (get_utf8_string, xg_get_file_with_chooser):
13998 Rename locals to avoid shadowing.
13999 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14000
41729b81
PE
14001 * xgselect.c (xg_select): Remove unused var.
14002
f0c77cd1
PE
14003 * image.c (four_corners_best): Mark locals as initialized.
14004 (gif_load): Initialize transparent_p to zero (Bug#8238).
14005 Mark another local as initialized.
ec6cf4c6 14006 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14007
ce0ad53d 14008 * image.c (clear_image_cache): Now static.
d5d5a617 14009 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14010 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14011 (x_edge_detection): Remove unnecessary cast that
14012 gcc -Wbad-function-cast diagnoses.
2037898d 14013 (gif_load): Fix pointer signedness.
6ae141d6
PE
14014 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14015 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14016
33383987 140172011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14018
d32df629
PE
14019 Improve quality of tests for time stamp overflow.
14020 For example, without this patch (encode-time 0 0 0 1 1
14021 1152921504606846976) returns the obviously-bogus value (-948597
14022 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14023 reports time overflow. See
14024 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14025 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14026 * editfns.c: Include limits.h and intprops.h.
14027 (TIME_T_MIN, TIME_T_MAX): New macros.
14028 (time_overflow): Move earlier, to before first use.
14029 (hi_time, lo_time): New functions, for an accurate test for
14030 out-of-range times.
14031 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14032 (Fget_internal_run_time): Don't assume time_t fits in int.
14033 (make_time): Use list2 instead of Fcons twice.
14034 (Fdecode_time): More accurate test for out-of-range times.
14035 (check_tm_member): New function.
14036 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14037 (lisp_time_argument): Don't rely on undefined left-shift and
14038 right-shift behavior when checking for time stamp overflow.
8be6f318 14039
fe31d94c
PE
14040 * editfns.c (time_overflow): New function, refactoring common code.
14041 (Fformat_time_string, Fdecode_time, Fencode_time):
14042 (Fcurrent_time_string): Use it.
14043
8be6f318
PE
14044 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14045 * dired.c (make_time): Move to ...
14046 * editfns.c (make_time): ... here.
14047 * systime.h: Note the move.
14048
09d9db2c 140492011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14050
126bc0dc
YM
14051 * fringe.c (update_window_fringes): Remove unused variables.
14052
c47cbdfd
YM
14053 * unexmacosx.c (copy_data_segment): Also copy __got section.
14054 (Bug#8223)
14055
7ac80be9
EZ
140562011-03-12 Eli Zaretskii <eliz@gnu.org>
14057
c96bbc66 14058 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14059 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14060 Constify `char *' arguments and their references according to
14061 prototypes in tparam.h.
14062
ecb0f94d 14063 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14064
7ac80be9
EZ
14065 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14066 Adapt all references accordingly.
14067
14068 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14069
ef1fd07e
TT
140702011-03-11 Tom Tromey <tromey@redhat.com>
14071
14072 * buffer.c (syms_of_buffer): Remove obsolete comment.
14073
7ef4b50c
EZ
140742011-03-11 Eli Zaretskii <eliz@gnu.org>
14075
14076 * termhooks.h (encode_terminal_code): Declare prototype.
14077
14078 * msdos.c (encode_terminal_code): Don't declare prototype.
14079
14080 * term.c (encode_terminal_code): Now external again, used by
14081 w32console.c and msdos.c.
14082
44f230aa
SM
14083 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14084 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14085
4b1ec863 140862011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14087
1714f52b 14088 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14089
4b1ec863
PE
14090 * fringe.c (update_window_fringes): Mark locals as initialized
14091 (Bug#8227).
14092 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14093
524c7aa6
PE
14094 * alloc.c (mark_fringe_data): Move decl from here ...
14095 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14096 to check its interface.
14097 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14098
a5c0af81 14099 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14100 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14101 (fontset_font): Mark local as initialized.
a9a06e0b 14102 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14103
b4716021
PE
14104 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14105
811e9bac 14106 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14107 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14108 (x_own_selection, Fx_disown_selection_internal): Rename locals
14109 to avoid shadowing.
14110 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14111
7e3ab302
PE
14112 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14113 so that the caller can use some name other than gcpro1.
14114 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14115 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14116 (Fx_backspace_delete_keys_p):
14117 Use them to avoid shadowing, and rename vars to avoid shadowing.
14118 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14119 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14120 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14121 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14122 Remove unused locals.
7e3ab302
PE
14123 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14124 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14125 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14126 macros.
f78faa98 14127
e2b13473
PE
14128 * xterm.h (x_mouse_leave): New decl.
14129
77f23912
PE
14130 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14131 Remove unused functions.
cdf4ba58
PE
14132 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14133 (x_calc_absolute_position): Now static.
7411c686 14134 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14135 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14136 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14137 unless they are used.
38d0b34a
PE
14138 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14139 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14140 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14141 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14142 (x_error_catcher, x_connection_closed, x_error_handler):
14143 (x_error_quitter, xembed_send_message, x_iconify_frame):
14144 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14145 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14146 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14147
44f230aa
SM
14148 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14149 Rename or move locals to avoid shadowing.
6b463e58 14150 (tty_defined_color, merge_face_heights): Now static.
5967d051 14151 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14152 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14153 does not deduce is never used uninitialized.
73719eba
PE
14154 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14155 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14156
426994c3 14157 * terminal.c (store_terminal_param): Now static.
5489860b 14158
032f1620 14159 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14160 (set_frame_menubar): Remove unused local.
d4323972 14161 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14162 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14163 since they might point to immutable storage.
281585b0
PE
14164 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14165 since it's unused otherwise.
032f1620 14166
367c19e5 14167 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14168 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14169 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14170 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14171 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14172 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14173 does not deduce are never used uninitialized.
70739cbe 14174
07b48fa9
PE
14175 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14176
8868a238 14177 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14178 * window.c (window_loop, size_window):
14179 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14180
7e5cf297 14181 * window.c (display_buffer): Now static.
d6550a9f
PE
14182 (size_window): Mark variables that gcc -Wuninitialized
14183 does not deduce are never used uninitialized.
a586633d
PE
14184 * window.h (check_all_windows): New decl, to forestall
14185 gcc -Wmissing-prototypes diagnostic.
5b555da1 14186 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14187
f6095868
PE
14188 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14189 shadowing.
14190 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14191 Include <limits.h>.
14192 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14193 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14194 (load_charset_map): Mark variables that gcc -Wuninitialized
14195 does not deduce are never used uninitialized.
53df7c11 14196 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14197
f38b440c
PE
14198 * coding.c (coding_set_source, coding_set_destination):
14199 Use "else { /* comment */ }" rather than "else /* comment */;"
14200 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14201 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14202 a block, when the outer 'i' will do.
14203 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14204 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14205 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14206 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14207 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14208 Rename locals to avoid shadowing.
14209 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14210 * coding.c (emacs_mule_char, encode_invocation_designation):
14211 Now static, since they're not used elsewhere.
413bb2db 14212 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14213 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14214 (decode_coding_emacs_mule): Mark variables that gcc
14215 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14216 (detect_coding_iso_2022): Initialize a local variable that might
14217 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14218 this initialization is needed. (Bug#8211)
5f58e762
PE
14219 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14220 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14221 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14222 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14223 Remove unused macros.
f38b440c 14224
232b38b9 14225 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14226 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14227 * character.c (string_count_byte8): Likewise.
232b38b9 14228
fb90da1b
PE
14229 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14230 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14231
fb93dbc2
PE
14232 * chartab.c (copy_sub_char_table): Now static, since it's not used
14233 elsewhere.
5c156ace
PE
14234 (sub_char_table_ref_and_range, char_table_ref_and_range):
14235 Rename locals to avoid shadowing.
bbcd0949 14236 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14237
7d3b3862 14238 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14239 (BIDI_BOB): Remove unused macro.
7d3b3862 14240
6be7d3da
PE
14241 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14242 deduce are never used uninitialized.
c2ed9c8b 14243 * term.c (encode_terminal_code): Likewise.
6be7d3da 14244
75f8807f 14245 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14246
50938595
PE
14247 * tparam.h: New file.
14248 * term.c, tparam.h: Include it.
14249 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14250 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14251 Move these decls to tparam.h, and make them agree with what
14252 is actually in tparam.c. The previous trick of using incompatible
14253 decls in different modules does not conform to the C standard.
14254 All callers of tparam changed to use tparam's actual API.
14255 * tparam.c (tparam1, tparam, tgoto):
14256 Use const pointers where appropriate.
14257
fbceeba2
PE
14258 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14259 * cm.h (struct cm): Likewise.
14260 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14261 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14262 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14263 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14264 (turn_on_face, init_tty): Likewise.
14265 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14266
7f3f1250
PE
14267 * term.c (term_mouse_position): Rename local to avoid shadowing.
14268
e6ca6543
PE
14269 * alloc.c (mark_ttys): Move decl from here ...
14270 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14271
c40f8d15
AS
142722011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14273
14274 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14275
cfe0661d
JB
142762011-03-09 Juanma Barranquero <lekktu@gmail.com>
14277
14278 * search.c (compile_pattern_1): Remove argument regp, unused since
14279 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14280 (compile_pattern): Don't pass it.
14281
0afb4571
J
142822011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14283
14284 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14285 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14286 for ! HAVE_GTK3.
14287 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14288
14289 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14290
14291 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14292 gdk_window_get_screen, gdk_window_get_geometry,
14293 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14294 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14295 (xg_get_pixbuf_from_pixmap): New function.
14296 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14297 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14298 Call xg_get_pixbuf_from_pixmap instead of
14299 gdk_pixbuf_get_from_drawable.
14300 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14301 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14302 (xg_check_special_colors): Use GtkStyleContext and its functions
14303 for HAVE_GTK3.
14304 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14305 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14306 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14307 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14308 Call gtk_widget_get_preferred_size.
0afb4571
J
14309 (xg_frame_resized): gdk_window_get_geometry only takes 5
14310 parameters.
44f230aa
SM
14311 (xg_win_to_widget, xg_event_is_for_menubar):
14312 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14313 (xg_set_widget_bg): New function.
14314 (delete_cb): New function.
895009e1 14315 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14316 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14317 (xg_set_background_color): Call xg_set_widget_bg.
14318 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14319 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14320 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14321 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14322 if ! HAVE_GTK3.
14323 (update_frame_tool_bar): Call gtk_widget_hide.
14324 (xg_initialize): Use GDK_KEY_g.
14325
14326 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14327 if ! HAVE_GTK3
14328 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14329
14330 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14331 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14332 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14333
1c2cc4ef
JB
143342011-03-08 Juanma Barranquero <lekktu@gmail.com>
14335
14336 * w32xfns.c (select_palette): Check success of RealizePalette against
14337 GDI_ERROR, not zero.
14338
33383987 14339See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14340
14341;; Local Variables:
14342;; coding: utf-8
aac0c6e3
MR
14343;; End:
14344
2f097256 14345 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14346
14347 This file is part of GNU Emacs.
14348
14349 GNU Emacs is free software: you can redistribute it and/or modify
14350 it under the terms of the GNU General Public License as published by
14351 the Free Software Foundation, either version 3 of the License, or
14352 (at your option) any later version.
14353
14354 GNU Emacs is distributed in the hope that it will be useful,
14355 but WITHOUT ANY WARRANTY; without even the implied warranty of
14356 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14357 GNU General Public License for more details.
14358
14359 You should have received a copy of the GNU General Public License
14360 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.