Move TIOCSIGSEND from src/s to configure
[bpt/emacs.git] / src / ChangeLog
CommitLineData
0a763bd1
GM
12012-07-30 Glenn Morris <rgm@gnu.org>
2
32bac6d6
GM
3 * s/netbsd.h: Let configure include signal.h if needed.
4 Remove file, which is now empty.
5
b65e7c46
GM
6 * s/usg5-4-common.h (_longjmp, _setjmp, TIOCSIGSEND):
7 Let configure set them.
8 * s/irix6-5.h (_longjmp, _setjmp, TIOCSIGSEND):
9 No more need to undefine.
0a763bd1 10
169304bd
AS
112012-07-30 Andreas Schwab <schwab@linux-m68k.org>
12
13 * keymap.c (Fkey_description): Don't remove 0x80 bit from
14 non-single-byte char when adding meta modifier. (Bug#12090)
15
6cd7a139
DA
162012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
17
18 Convert safe_call to use variable number of arguments.
19 * xdisp.c (safe_call): Convert to use varargs. Adjust users.
20 (safe_call2): Fix comment.
21 * lisp.h (safe_call): Adjust prototype.
22 * coding.c (encode_coding_object): Change to use safe_call2.
23 * xfaces.c (merge_face_heights): Change to use safe_call1.
24
d34d6ffc
GM
252012-07-30 Glenn Morris <rgm@gnu.org>
26
7b8a48e4 27 * s/aix4-2.h (sigmask): No need to undefine it, since syssignal.h
227f5bd0 28 does that unconditionally. Remove file, which is now empty.
7b8a48e4 29
d34d6ffc
GM
30 * s/freebsd.h, s/gnu-linux.h, s/sol2-6.h, s/unixware.h:
31 Remove empty files.
32
03a660a6
PE
332012-07-30 Paul Eggert <eggert@cs.ucla.edu>
34
35 Export to GDB most of lisp.h's remaining object-like macros.
36 * lisp.h (min, max): Move earlier, because they're used earlier now.
37 (INTMASK, ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK)
38 (CHAR_TABLE_STANDARD_SLOTS, CHARTAB_SIZE_BITS_0)
39 (CHARTAB_SIZE_BITS_1, CHARTAB_SIZE_BITS_2, CHARTAB_SIZE_BITS_3)
40 (DEFAULT_HASH_SIZE, COMPILED_ARGLIST, COMPILED_BYTECODE)
41 (COMPILED_CONSTANTS, COMPILED_STACK_DEPTH, COMPILED_DOC_STRING)
42 (COMPILED_INTERACTIVE, CHAR_ALT, CHAR_SUPER, CHAR_HYPER, CHAR_SHIFT)
43 (CHAR_CTL, CHAR_META, CHAR_MODIFIER_MASK, CHARACTERBITS)
44 (MANY, UNEVALLED, FLOAT_TO_STRING_BUFSIZE, MAX_ALLOCA):
45 Now constants, for GDB. They need not be macros.
46 (MOST_POSITIVE_FIXNUM, MOST_NEGATIVE_FIXNUM, STRING_BYTES_BOUND):
47 Now constants, for GDB, as well as macros, for static initializers.
48 (CHAR_TABLE_STANDARD_SLOTS, CHAR_TABLE_EXTRA_SLOTS):
49 Move to after the definition of struct Lisp_Char_Table,
50 since the former now needs that type defined.
51 (enum CHARTAB_SIZE_BITS, enum CHAR_TABLE_STANDARD_SLOTS)
52 (enum DEFAULT_HASH_SIZE, enum Lisp_Compiled, enum char_bits)
53 (enum maxargs, enum FLOAT_TO_STRING_BUFSIZE, enum MAX_ALLOCA):
54 New enums, for gdb_make_enums_visible.
55 (GLYPH_MODE_LINE_FACE): Remove; unused.
56 * alloc.c (STRING_BYTES_MAX): Now a constant, now a macro.
57 (gdb_make_enums_visible): Add enum CHARTAB_SIZE_BITS, enum
58 CHAR_TABLE_STANDARD_SLOTS, enum char_bits, enum DEFAULT_HASH_SIZE,
59 enum FLOAT_TO_STRING_BUFSIZE, enum Lisp_Bits, enum Lisp_Compiled,
60 enum maxargs, enum MAX_ALLOCA.
61 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): Remove.
62 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Remove;
63 no longer needed, now that they are done in lisp.h.
64
e499d0ee
DA
652012-07-30 Dmitry Antipov <dmantipov@yandex.ru>
66
67 Cleanup string bytes checking.
68 * alloc.c (GC_STRING_BYTES, CHECK_STRING_BYTES): Remove. Convert
69 all users to STRING_BYTES or string_bytes if GC_CHECK_STRING_BYTES.
70 (check_string_bytes): Define to empty if not GC_CHECK_STRING_BYTES.
71 (check_sblock, compact_small_strings): Simplify.
72
d5040d2d
PE
732012-07-29 Paul Eggert <eggert@cs.ucla.edu>
74
75 * lisp.h (LISP_INT_TAG, LISP_INT1_TAG, LISP_STRING_TAG): Remove.
76 These macros are confusing and no longer need to be defined, as
77 the enum values now suffice. All uses replaced with definiens.
78 (Lisp_Int1, Lisp_String): Define directly; this is clearer.
79
7f259ae6
JB
802012-07-29 Juanma Barranquero <lekktu@gmail.com>
81
82 * makefile.w32-in (LISP_H, $(BLD)/emacs.$(O), $(BLD)/w32inevt.$(O))
83 ($(BLD)/w32console.$(O)): Update dependencies.
84
7e63e0c3
DA
852012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
86
87 Remove HIDE_LISP_IMPLEMENTATION and cleanup cons free list check.
88 * lisp.h (HIDE_LISP_IMPLEMENTATION): Remove as useless for a long
89 time. Adjust users.
90 (CHECK_CONS_LIST): Remove. Convert all users to check_cons_list.
91
ffd817eb
JD
922012-07-29 Jan Djärv <jan.h.d@swipnet.se>
93
94 * lread.c (init_lread): Remove if-statement in ifdef HAVE_NS before
95 setting sitelisp (Bug#12010).
96
417a7a0e
EZ
972012-07-29 Eli Zaretskii <eliz@gnu.org>
98
99 * w32heap.h (OS_9X): Renamed from OS_WINDOWS_95.
100
101 * w32heap.c (cache_system_info):
102 * w32.c (sys_rename):
103 * w32proc.c (find_child_console, sys_kill): All users changed.
104
387d4d92
PE
1052012-07-29 Paul Eggert <eggert@cs.ucla.edu>
106
107 * alloc.c (Fgarbage_collect): Indent as per usual Emacs style.
108
55a6cca6
EZ
1092012-07-29 Eli Zaretskii <eliz@gnu.org>
110
111 * makefile.w32-in (LISP_H): Add $(NT_INC)/stdalign.h.
112
dbcf001c
DA
1132012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
114
115 Cleanup statistics calculation in Fgarbage_collect.
116 * alloc.c (Fgarbage_collect): Rename t1 to meaningful start. Fix
117 zombies percentage calculation. Simplify elapsed time calculation.
118
e2688e4a
DA
1192012-07-29 Dmitry Antipov <dmantipov@yandex.ru>
120
121 Generalize marker debugging code under MARKER_DEBUG and use eassert.
122 * insdel.c (CHECK_MARKERS, check_markers_debug_flag): Remove.
123 (gap_left, gap_right, adjust_markers_for_delete, insert_1_both)
124 (insert_from_string_1, insert_from_gap, insert_from_buffer_1)
125 (replace_range, replace_range_2, del_range_2): Change to eassert.
126 * marker.c (byte_char_debug_check): Adjust style.
127
b46a6a83
PE
1282012-07-29 Paul Eggert <eggert@cs.ucla.edu>
129
130 Don't use the abbreviation "win" to refer to Windows (Bug#10421).
131 * regex.c (MAX_BUF_SIZE): Remove some incorrect and
132 long-ago-commented-out code that talks about "WIN32".
133 * w32heap.h (OS_WINDOWS_95): Rename from OS_WIN95.
134 All uses changed.
135
e32a5799
PE
1362012-07-28 Paul Eggert <eggert@cs.ucla.edu>
137
138 Use Gnulib stdalign module (Bug#9772, Bug#9960).
139 * alloc.c (XMALLOC_BASE_ALIGNMENT, GC_POINTER_ALIGNMENT, pure_alloc):
140 Simplify by using alignof.
141 (pure_alloc) [! USE_LSB_TAG]: Don't over-align EMACS_INT values.
142 * lisp.h: Include <stdalign.h>.
143 (GCALIGNMENT): New macro and constant.
144 (DECL_ALIGN): Remove. All uses replaced by alignas (GCALIGNMENT).
145 (USE_LSB_TAG): ifdef on alignas, not on DECL_ALIGN.
146 (stdalign): New macro, if not already defined.
147
df81cd29
EZ
1482012-07-28 Eli Zaretskii <eliz@gnu.org>
149
01bd1b0d
EZ
150 Fix non-ASCII input in non-GUI frames on MS-Windows. (Bug#12055)
151 * w32inevt.c: Include w32inevt.h.
152 (w32_read_console_input): New inline function, calls either
153 ReadConsoleInputA or ReadConsoleInputW, depending on the value of
154 w32_console_unicode_input.
155 (fill_queue): Call w32_read_console_input instead of ReadConsoleInput.
156 (w32_kbd_patch_key, key_event): Use the codepage returned by
157 GetConsoleCP, rather than the ANSI codepage returned by GetLocaleInfo.
158 (key_event): use uChar.UnicodeChar only if
159 w32_console_unicode_input is non-zero.
160
161 * w32console.c: Include w32heap.h.
162 <w32_console_unicode_input>: New global variable.
163 (initialize_w32_display): Set w32_console_unicode_input to 1 on NT
164 family of Windows, zero otherwise.
165
166 * w32inevt.h: Declare w32_console_unicode_input.
167
df81cd29
EZ
168 * xdisp.c (init_iterator): Don't reference tip_frame in a build
169 --without-x. (Bug#11742)
170
c20fdd9e
PE
1712012-07-27 Paul Eggert <eggert@cs.ucla.edu>
172
173 Adjust GDB to reflect pvec_type changes (Bug#12036).
174 * .gdbinit (xvectype, xpr, xbacktrace): Adjust to reflect the
175 2012-07-04 changes to pseudovector representation. Problem
176 reported by Eli Zaretskii in <http://bugs.gnu.org/12036#30>.
177
32770973 1782012-07-27 Michael Albinus <michael.albinus@gmx.de>
e518bc71
MA
179
180 * dbusbind.c (XD_DBUS_VALIDATE_BUS_ADDRESS): Canonicalize session
181 bus address.
182 (xd_close_bus, Fdbus_init_bus): Handle reference counter properly.
183
3438fe21
EZ
1842012-07-27 Eli Zaretskii <eliz@gnu.org>
185
bcfbc9de
EZ
186 * alloc.c (listn): Fix the order the arguments are consed onto the
187 list.
188
3438fe21
EZ
189 * lisp.h (enum constype): Use CONSTYPE_HEAP and CONSTYPE_PURE for
190 enumeration constants, as PURE and HEAP are too general, and clash
191 with other headers and sources, such as gmalloc.c and the
192 MS-Windows system headers. All users changed.
193
eeaea515
DA
1942012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
195
196 Revert last save_excursion_save and save_excursion_restore changes.
197 * alloc.c, editfns.c, marker.c, lisp.h: Revert.
198 Lots of crashes reported by Chong Yidong <cyd@gnu.org>.
199
073c88c2
DA
2002012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
201
202 Fix recently-introduced typos in Windows port.
203 Reported by Martin Rudalics <rudalics@gmx.at>.
204 * w32.c (init_environment): Replace comma with semicolon.
eeaea515 205 * w32fns.c (syms_of_w32fns): Add missing parenthesis.
073c88c2 206
4706125e
PE
2072012-07-27 Paul Eggert <eggert@cs.ucla.edu>
208
209 Improve GDB symbol export (Bug#12036).
210 * .gdbinit (xgetptr, xgetint, xgettype): Set $bugfix in different
211 arms of an 'if', not using conditional expressions; otherwise GDB
212 complains about the types in the unevaluated arm when the argument
213 is an integer literal.
214 (xgetint): Simplify expression.
215 * alloc.c (gdb_make_enums_visible): New constant. This ports to
216 GCC 3.4.2 the export of symbols to GDB. Problem reported by Eli
217 Zaretskii in <http://bugs.gnu.org/12036#13>.
218 * lisp.h (PUBLISH_TO_GDB): Remove. All uses removed. No longer
219 needed now that we have gdb_make_enums_visible.
220 (enum CHECK_LISP_OBJECT_TYPE, enum Lisp_Bits, enum More_Lisp_Bits)
221 (enum enum_USE_LSB_TAG):
222 New enum types, packaging up enums that need to be exported to GDB.
223
694b6c97
DA
2242012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
225
226 Utility function to make a list from specified amount of objects.
227 * lisp.h (enum constype): New datatype.
228 (listn): New prototype.
229 * alloc.c (listn): New function.
230 (Fmemory_use_count, syms_of_alloc): Use it.
231 * buffer.c (syms_of_buffer): Likewise.
232 * callint.c (syms_of_callint): Likewise.
233 * charset.c (define_charset_internal): Likewise.
234 * coding.c (syms_of_coding): Likewise.
235 * keymap.c (syms_of_keymap): Likewise.
236 * search.c (syms_of_search): Likewise.
237 * syntax.c (syms_of_syntax): Likewise.
238 * w32.c (init_environment): Likewise.
239 * w32fns.c (Fw32_battery_status, syms_of_w32fns): Likewise.
240 * xdisp.c (syms_of_xdisp): Likewise.
241 * xfns.c (syms_of_xfns): Likewise.
242
6195f384
DA
2432012-07-27 Dmitry Antipov <dmantipov@yandex.ru>
244
245 Fast save_excursion_save and save_excursion_restore.
246 * lisp.h (struct Lisp_Excursion): New data type.
247 (PVEC_EXCURSION): New pseudovector type.
248 (XEXCURSION, XSETEXCURSION, EXCURSIONP): Convenient macros
249 to deal with it. Adjust comments.
250 (init_marker, attach_marker): New prototype.
251 (unchain_marker): Adjust prototype.
252 * marker.c (attach_marker): Change to global.
253 (init_marker): New function.
254 * alloc.c (Fmake_marker, build_marker): Use it.
255 (build_marker): More easserts.
256 (mark_object): Handle struct Lisp_Excursion.
257 * editfns.c (save_excursion_save, save_excursion_restore):
258 Reimplement to use struct Lisp_Excursion. Add comments.
259
5eceb8fb
PE
2602012-07-26 Paul Eggert <eggert@cs.ucla.edu>
261
262 Fix export of symbols to GDB (Bug#12036).
263 * alloc.c (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL)
264 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Move these here from
265 emacs.c, as this is a more-suitable home. Had this been done earlier
266 the fix for 12036 would have avoided some of the problems noted in
267 <http://bugs.gnu.org/12036#13> by Eli Zaretskii, as the scope problems
268 would have been more obvious.
562157c8
PE
269 * emacs.c: Do not include <verify.h>; no longer needed.
270 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS)
5eceb8fb
PE
271 (gdb_GCTYPEBITS, gdb_USE_LSB_TAG)
272 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
273 Remove; now done in lisp.h.
274 * lisp.h (PUBLISH_TO_GDB): New macro.
275 (GCTYPEBITS, USE_LSB_TAG, CHECK_LISP_OBJECT_TYPE, enum pvec_type)
276 (DATA_SEG_BITS): Use it.
277 (GCTYPEBITS, USE_LSB_TAG): Now also an enum, for GDB.
278 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Now just an enum, for GDB.
279 * mem-limits.h (EXCEEDS_LISP_PTR): Redo so that DATA_SEG_BITS need
280 not be usable in #if. This simplifies things.
281
d6749401
JB
2822012-07-26 Juanma Barranquero <lekktu@gmail.com>
283
284 * makefile.w32-in ($(BLD)/emacs.$(O)): Update dependencies.
285
1781b9e9
PE
2862012-07-26 Paul Eggert <eggert@cs.ucla.edu>
287
d89518db 288 Simplify export of symbols to GDB (Bug#12036).
1781b9e9
PE
289 * .gdbinit (xgetptr, xgetint, xgettype): Don't use "set $bugfix =
290 $bugfix.i", as this doesn't work (with GDB 7.4.1, anyway).
291 (xgetptr, xgetint, xgettype, xcoding, xcharset, xprintbytestr):
292 Adjust to changes in lisp.h and emacs.c, by using
293 CHECK_LISP_OBJECT_TYPE rather than gdb_use_struct, VALMASK instead
294 of $valmask, DATA_SEG_BITS instead of gdb_data_seg_bits,
295 INTTYPEBITS instead of gdb_gctypebits - 1, USE_LSB_TAG instead of
296 gdb_use_lsb, (1 << GCTYPEBITS) - 1 instead of $tagmask, VALBITS
297 instead of gdb_valbits.
298 (xvectype, xvector, xpr, xprintstr, xbacktrace): Similarly, use
299 PSEUDOVECTOR_FLAG instead of PVEC_FLAG, and ARRAY_MARK_FLAG
300 instead of gdb_array_mark_flag.
301 (xboolvector): Get size from $->size, not $->header.size.
302 Use BOOL_VECTOR_BITS_PER_CHAR rather than mystery constants.
303 (xreload, hook-run, hookpost-run): Remove.
304 * emacs.c: Include <verify.h>.
305 (gdb_use_lsb, gdb_use_struct, gdb_valbits, gdb_gctypebits)
306 (gdb_data_seg_bits, PVEC_FLAG, gdb_array_mark_flag, gdb_pvec_type):
307 Remove.
308 (gdb_CHECK_LISP_OBJECT_TYPE, gdb_DATA_SEG_BITS, gdb_GCTYPEBITS)
309 (gdb_USE_LSB_TAG): New enum constants.
310 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS, GCTYPEBITS, USE_LSB_TAG):
311 Also define these as enum constants, so they're visible to GDB.
312 (ARRAY_MARK_FLAG_VAL, PSEUDOVECTOR_FLAG_VAL, VALMASK_VAL): New macros.
313 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, VALMASK): Also define these
314 as constants, so they're visible to GDB.
315 * lisp.h (VALBITS, INTTYPEBITS, FIXNUM_BITS, PSEUDOVECTOR_SIZE_BITS)
316 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK, BOOL_VECTOR_BITS_PER_CHAR):
317 Now enum constants, not macros, so they're visible to GDB.
318 (CHECK_LISP_OBJECT_TYPE, DATA_SEG_BITS): Default to 0, as this is
319 more convenient now. All uses changed.
320 (VALMASK) [USE_LSB_TAG]: Also define in this case.
321 * mem-limits.h (EXCEEDS_LISP_PTR): Adjust to DATA_SEG_BITS change.
322
3628596a
DA
3232012-07-26 Dmitry Antipov <dmantipov@yandex.ru>
324
325 Explicitly free restriction data that are not needed anymore.
326 * editfns.c (save_restriction_restore): Free restriction data.
327
7abaf5cc
SM
3282012-07-26 Stefan Monnier <monnier@iro.umontreal.ca>
329
330 * eval.c (Fautoload_do_load): Rename from do_autoload, export to Lisp,
331 add argument, tune behavior, and adjust all callers.
332
71f88e00
PE
3332012-07-25 Paul Eggert <eggert@cs.ucla.edu>
334
335 Use typedef for EMACS_INT, EMACS_UINT.
336 * lisp.h, s/ms-w32.h (EMACS_INT, EMACS_UINT): Use typedefs rather
337 than macros. This simplifies debugging in the usual case, since
338 it lets GDB show addresses as 'EMACS_INT *' rather than 'long int *'
339 and it allows expressions involving EMACS_INT casts.
340 * .gdbinit (xreload): Simplify by using EMACS_INT cast.
341
57ec3034
JD
3422012-07-25 Jan Djärv <jan.h.d@swipnet.se>
343
344 * nsterm.m (ns_read_socket): Return early if there is a modal
345 window (Bug#12043).
346
8137e7b3
MR
3472012-07-25 Martin Rudalics <rudalics@gmx.at>
348
349 * frame.c (Fredirect_frame_focus): In doc-string don't mention
350 that FOCUS-FRAME can be omitted.
351
04e9897c
DA
3522012-07-25 Dmitry Antipov <dmantipov@yandex.ru>
353
354 Adjust buffer text indirection counters at the end of Fkill_buffer.
355 * buffer.c (Fkill_buffer): Adjust indirection counters when the
356 buffer is definitely dead. This should really fix an issue reported
357 by Christoph Scholtes again. (Bug#12007).
358 (init_buffer_once): Initialize indirection counters of
359 buffer_defaults and buffer_local_symbols (for sanity and safety).
360
8a0484e1
EZ
3612012-07-24 Eli Zaretskii <eliz@gnu.org>
362
363 * xdisp.c (init_iterator): Don't compute dimensions of truncation
364 and continuation glyphs on tooltip frames, leave them at zero.
365 Avoids continued lines in tooltips. (Bug#11832)
366
fa691a83
DA
3672012-07-24 Dmitry Antipov <dmantipov@yandex.ru>
368
369 Simplify copy_overlay.
04e9897c 370 * buffer.c (copy_overlay): Simplify. Use build_marker.
fa691a83
DA
371 * lisp.h (struct Lisp_Overlay): Restore comment with minor tweaks.
372
436bc8e0
EZ
3732012-07-23 Eli Zaretskii <eliz@gnu.org>
374
375 * print.c (print_object): Don't crash when a frame's name is nil
376 or invalid. (Bug#12025)
377
378 * window.c (decode_any_window): Disable CHECK_LIVE_FRAME test, as
379 it signals an error when a tooltip frame is being created.
380
d7a7fda3
DA
3812012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
382
383 Cleanup miscellaneous objects allocation and initialization.
384 * alloc.c (allocate_misc): Change to static. Add argument to
385 specify the subtype. Adjust comment and users.
386 (build_overlay): New function.
387 * buffer.c (copy_overlays, Fmake_overlay): Use it.
388 * lisp.h (struct Lisp_Overlay): Remove obsolete comment.
389 (allocate_misc): Remove prototype.
390 (build_overlay): Add prototype.
391
3922012-07-23 Dmitry Antipov <dmantipov@yandex.ru>
372f8ffc
DA
393
394 Swap buffer text indirection counters in Fbuffer_swap_text.
395 * buffer.c (Fbuffer_swap_text): Swap indirections too.
396 This avoids crash reported by Christoph Scholtes at
397 http://lists.gnu.org/archive/html/bug-gnu-emacs/2012-07/msg00785.html.
398
9d7fa573
JD
3992012-07-22 Jan Djärv <jan.h.d@swipnet.se>
400
401 * nsmenu.m (Popdown_data): New struct.
402 (pop_down_menu): p->pointer is Popdown_data. Release the pool and
403 free Popdown_data.
404 (ns_popup_dialog): Use NSAutoreleasePool and pass it to pop_down_menu.
405 (initWithContentRect): Make imgView and contentView non-static
406 and autorelease them. Also autorelease img and matrix (Bug#12005).
407 (dealloc): Remove (Bug#12005).
408
0dd6d66d
DA
4092012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
410
411 Adjust consing_since_gc when objects are explicitly freed.
412 * alloc.c (GC_DEFAULT_THRESHOLD): New macro.
413 (Fgarbage_collect): Use it. Change minimum to 1/10 of default.
414 (free_cons, free_misc): Subtract object size from consing_since_gc.
415
d36d71df
DA
4162012-07-22 Dmitry Antipov <dmantipov@yandex.ru>
417
418 Simplify and cleanup markers positioning code.
419 * marker.c (attach_marker): More useful eassert.
420 (live_buffer, set_marker_internal): New function.
421 (Fset_marker, set_marker_restricted): Use set_marker_internal.
422 (set_marker_both, set_marker_restricted_both): Use live_buffer.
423
fb9ea40f
PE
4242012-07-22 Paul Eggert <eggert@cs.ucla.edu>
425
426 * buffer.h (struct buffer.indirections): Now ptrdiff_t, not int,
427 as it's limited by the amount of memory, not by INT_MAX.
428
2d5c5f7d
EZ
4292012-07-21 Eli Zaretskii <eliz@gnu.org>
430
07fb592e
EZ
431 * keyboard.c (keys_of_keyboard): Bind language-change to 'ignore'
432 in special-event-map. See the discussion at
433 http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00417.html
434 for the reasons.
435
37a9eac8 436 * w32menu.c (add_menu_item): Cast to ULONG_PTR when assigning
2d5c5f7d
EZ
437 info.dwItemData. Fixes crashes on 64-bit Windows. Suggested by
438 Fabrice Popineau <fabrice.popineau@supelec.fr>.
439
c4328746
JD
4402012-07-21 Jan Djärv <jan.h.d@swipnet.se>
441
442 * nsterm.m (accessibilityAttributeValue): New function. (Bug#11134).
4b17afa7 443 (conversationIdentifier): Return value is NSInteger.
784051c4 444 * nsterm.m (accessibilityAttributeValue): Surround with NS_IMPL_COCOA.
c4328746 445
6e5d1c12
CY
4462012-07-21 Chong Yidong <cyd@gnu.org>
447
448 * window.c (decode_any_window): Signal an error if the window is
449 on a dead frame (Bug#11984).
450
9928463d
DA
4512012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
452
453 Add indirection counting to speed up Fkill_buffer.
454 * buffer.h (struct buffer): New member.
455 * buffer.c (Fget_buffer_create): Set indirection counter to 0.
456 (Fmake_indirect_buffer): Set indirection counter to -1, increment
457 base buffer indirection counter.
458 (compact_buffer): If ENABLE_CHECKING, verify indirection counters.
459 (Fkill_buffer): Adjust indirection counters as needed, don't walk
460 through buffer list if indirection counter is 0.
461
f8643a6b
DA
4622012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
463
464 Extend the value returned by Fgarbage_collect with heap statistics.
465 * alloc.c (Qheap): New symbol.
466 (syms_of_alloc): DEFSYM it.
467 (Fgarbage_collect): If DOUG_LEA_MALLOC, add mallinfo data.
468 (Fmemory_free): Remove.
469 (syms_of_alloc): Don't defsubr it.
470 * buffer.c (Fcompact_buffer): Remove.
471 (syms_of_buffer): Don't defsubr it.
472
dac616ff
DA
4732012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
474
475 Make maybe_gc inline.
476 Verify that inlining is always possible (GCC 4.7.1, -O3 -Winline).
477 * lisp.h (consing_since_gc, gc_relative_threshold)
478 (memory_full_cons_threshold): Revert declaration.
479 (maybe_gc): Remove prototype, define as inline.
480 * alloc.c: Remove old commented-out code.
481 (consing_since_gc, gc_relative_threshold)
482 (memory_full_cons_threshold): Revert to global.
483 (maybe_gc): Remove.
484
d7ea76b4
DA
4852012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
486
487 Simple wrapper for make_unibyte_string, adjust font_open_by_name.
488 * lisp.h (build_unibyte_string): New function.
489 * dosfns.c, fileio.c, fns.c, ftfont.c, process.c:
490 * sysdep.c, w32fns.c, xfns.c: Use it.
491 * font.c (font_open_by_name): Change 2nd and 3rd args to the only arg
492 of type Lisp_Object to avoid redundant calls to make_unibyte_string.
493 Adjust users accordingly.
494 * font.h (font_open_by_name): Adjust prototype.
495
765e61e3
DA
4962012-07-20 Dmitry Antipov <dmantipov@yandex.ru>
497
498 Cleanup calls to Fgarbage_collect.
499 * lisp.h (maybe_gc): New prototype.
500 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
501 Remove declarations.
502 * alloc.c (maybe_gc): New function.
503 (consing_since_gc, gc_relative_threshold, memory_full_cons_threshold):
504 Make them static.
505 * bytecode.c (MAYBE_GC): Use maybe_gc.
506 * eval.c (eval_sub, Ffuncall): Likewise.
507 * keyboard.c (read_char): Likewise. Adjust call to maybe_gc
508 to avoid dependency from auto-save feature.
509
52b852c7
PE
5102012-07-19 Paul Eggert <eggert@cs.ucla.edu>
511
512 * buffer.h (FOR_EACH_BUFFER): Rename from 'for_each_buffer'.
513 (FOR_EACH_PER_BUFFER_OBJECT_AT): Rename from
514 'for_each_per_buffer_object_at'.
515 All uses changed. It's better to use upper-case for macros that
516 cannot be implemented as functions, to give the reader a clue
517 that they're special.
518
5db81e33
SM
5192012-07-19 Stefan Monnier <monnier@iro.umontreal.ca>
520
521 * alloc.c (Fgarbage_collect): Tweak docstring.
522
5b835e1d
DA
5232012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
524
525 Tweak the value returned from Fgarbage_collect again.
526 * alloc.c (Fgarbage_collect): New return value, as confirmed in
527 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00418.html.
528 Adjust documentation.
529 (total_vector_bytes): Rename to total_vector_slots, adjust
530 accounting.
531 (total_free_vector_bytes): Rename to total_free_vector_slots,
532 adjust accounting.
533 (Qstring_bytes, Qvector_slots): New symbols.
534 (syms_of_alloc): DEFSYM them.
535
9cd47b72
DA
5362012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
537
538 Buffer compaction primitive which may be used from Lisp.
539 * buffer.c (compact_buffer, Fcompact_buffer): New function.
540 (syms_of_buffer): Register Fcompact_buffer.
541 * alloc.c (Fgarbage_collect): Use compact_buffer.
542 * buffer.h (compact_buffer): New prototype.
543 (struct buffer_text): New member.
544
d17337e5
DA
5452012-07-19 Dmitry Antipov <dmantipov@yandex.ru>
546
547 New macro to iterate over all buffers, miscellaneous cleanups.
548 * lisp.h (all_buffers): Remove declaration.
549 * buffer.h (all_buffers): Add declaration, with comment.
550 (for_each_buffer): New macro.
551 * alloc.c (Fgarbage_collect, mark_object): Use it.
552 * buffer.c (Fkill_buffer, Fbuffer_swap_text, Fset_buffer_multibyte)
553 (init_buffer): Likewise.
554 * data.c (Fset_default): Likewise.
555 * coding.c (code_conversion_restore): Remove redundant check
556 for dead buffer.
557 * buffer.c (Fkill_buffer): Likewise. Remove obsolete comment.
558
60cfd278
AS
5592012-07-18 Andreas Schwab <schwab@linux-m68k.org>
560
561 Fix bug that created negative-length intervals.
562 * intervals.c (merge_interval_right, merge_interval_left):
563 Do not zero out this interval if it is absorbed by its children,
564 as this interval's total length doesn't change in that case. See
565 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00403.html>.
566
d06714cb
PE
5672012-07-18 Paul Eggert <eggert@cs.ucla.edu>
568
83713154
PE
569 * alloc.c (Fmake_bool_vector): Fix off-by-8 bug
570 when invoking (make-bool-vector N t) and N is a positive
571 multiple of 8 -- the last 8 bits were mistakenly cleared.
572
d06714cb
PE
573 Remove some struct layout assumptions in bool vectors.
574 * alloc.c (bool_header_size): New constant.
575 (header_size, word_size): Move earlier, as they're now used earlier.
576 Use 'word_size' in a few more places, where it's appropriate.
577 (Fmake_bool_vector, sweep_vectors): Don't assume that there is no
578 padding before the data member of a bool vector.
579 (sweep_vectors): Use PSEUDOVECTOR_TYPEP, in an eassert, rather
580 than doing the check by hand with an abort ().
581
464d5a5e
SM
5822012-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
583
5fbc0409
SM
584 * eval.c (Fdefvar): Don't check constants since we only set the var if
585 it's not yet defined anyway (bug#11904).
586
464d5a5e
SM
587 * lisp.h (last_undo_boundary): Declare new var.
588 * keyboard.c (command_loop_1): Set it.
589 * cmds.c (Fself_insert_command): Use it to only remove boundaries that
590 were auto-added by the command loop (bug#11774).
591
8dc2e44a
AS
5922012-07-18 Andreas Schwab <schwab@linux-m68k.org>
593
594 * w32font.c (Qsymbol): Remove local definition.
595 (syms_of_w32font): Don't DEFSYM it.
596
169925ec
DA
5972012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
598
599 Fix sweep_vectors to handle large bool vectors correctly.
600 * alloc.c (sweep_vectors): Account total_vector_bytes for
601 bool vectors larger than VBLOCK_BYTES_MAX.
602
5fbfb018
CY
6032012-07-18 Chong Yidong <cyd@gnu.org>
604
605 * frame.c (x_set_frame_parameters): Revert bogus change introduced
606 in 2012-05-25 commit by Paul Eggert (Bug#11738).
607
3ab6e069
DA
6082012-07-18 Dmitry Antipov <dmantipov@yandex.ru>
609
610 Return more descriptive data from Fgarbage_collect.
611 Suggested by Stefan Monnier in
612 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00369.html.
613 * alloc.c (bounded_number): New function.
614 (total_buffers, total_vectors): New variable.
615 (total_string_size): Rename to total_string_bytes, adjust users.
616 (total_vector_size): Rename to total_vector_bytes, adjust users.
617 (sweep_vectors): Account total_vectors and total_vector_bytes.
618 (Fgarbage_collect): New return value. Adjust documentation.
619 (gc_sweep): Account total_buffers.
620 (Fmemory_free, Fmemory_use_counts): Use bounded_number.
621 (VECTOR_SIZE): Remove.
622 * data.c (Qfloat, Qvector, Qsymbol, Qstring, Qcons): Make global.
623 (Qinterval, Qmisc): New symbols.
624 (syms_of_data): Initialize them.
625 * lisp.h (Qinterval, Qsymbol, Qstring, Qmisc, Qvector, Qfloat)
626 (Qcons, Qbuffer): New declarations.
627
6d02fe5b
PE
6282012-07-17 Paul Eggert <eggert@cs.ucla.edu>
629
630 * alloc.c (Fmemory_free): Account for memory-free's own storage.
631 Round up, not down. Improve doc.
632
b7ffe040
DA
6332012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
634
635 Restore old code in allocate_string_data to avoid Faset breakage.
636 Reported by Julien Danjou <julien@danjou.info> in
637 http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00371.html.
638 * alloc.c (allocate_string_data): Restore old code with minor
639 adjustments, fix comment to explain this subtle issue.
640
4dc7c8d5
SM
6412012-07-17 Eli Zaretskii <eliz@gnu.org>
642
643 Remove FILE_SYSTEM_CASE.
644 * s/msdos.h (FILE_SYSTEM_CASE): Don't define.
645
646 * fileio.c (FILE_SYSTEM_CASE): Don't define.
647 (Ffile_name_directory, Fexpand_file_name): Don't use FILE_SYSTEM_CASE.
648 Fixes problems on MS-DOS with Vtemp_file_name_pattern when
649 call-process-region passes it through expand-file-name.
650
651 * dired.c (file_name_completion): Don't use FILE_SYSTEM_CASE.
652
6532012-07-17 Andreas Schwab <schwab@linux-m68k.org>
654
655 Fix crash when creating indirect buffer (Bug#11917)
656 * buffer.c (buffer_lisp_local_variables): Add argument CLONE.
657 Don't handle unbound variables specially if non-zero.
658 (Fbuffer_local_variables): Pass zero.
659 (clone_per_buffer_values): Pass non-zero.
660
6612012-07-17 Andreas Schwab <schwab@linux-m68k.org>
662
663 * gnutls.c (emacs_gnutls_handshake): Revert last change. Add QUIT
664 to make the loop interruptible.
665
6662012-07-17 Andreas Schwab <schwab@linux-m68k.org>
667
668 * gnutls.c (emacs_gnutls_handshake): Only retry if
669 GNUTLS_E_INTERRUPTED.
670
cce7fefc
DA
6712012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
672
673 Cleanup and convert miscellaneous checks to eassert.
674 * alloc.c (mark_interval): Fix comment, partially rephrase
675 old comment from intervals.h (see below).
676 * intervals.c (find_interval, adjust_intervals_for_insertion)
677 (delete_interval, adjust_intervals_for_deletion)
678 (graft_intervals_into_buffer, temp_set_point_both, copy_intervals):
679 Convert to eassert.
680 (adjust_intervals_for_insertion, make_new_interval):
681 Remove obsolete and unused code.
682 * intervals.h (struct interval): Remove obsolete comment.
683 * textprotp.c (erase_properties): Remove unused code.
684 (Fadd_text_properties, set_text_properties_1, Fremove_text_properties)
685 (Fremove_list_of_text_properties): Convert to eassert.
686
9ea10cc3
CY
6872012-07-17 Chong Yidong <cyd@gnu.org>
688
689 * editfns.c (Finsert_char): Doc fix.
690
3900d5de
DA
6912012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
692
693 Fix previous change to make Fmemory_free always accurate.
694 * alloc.c (make_interval): Update total_free_intervals.
695 (make_float): Likewise for total_free_floats.
696 (free_cons, Fcons): Likewise for total_free_conses.
697 (SETUP_ON_FREE_LIST, allocate_vector_from_block):
698 Likewise for total_free_vector_bytes.
699 (Fmake_symbol): Likewise for total_free_symbols.
700 (bytes_free): Remove.
701
7098646f
DA
7022012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
703
704 Simple free memory accounting feature.
705 * alloc.c (bytes_free, total_free_vector_bytes): New variable.
706 (sweep_vectors): Accumulate size of free vectors.
707 (Fgarbage_collect): Setup bytes_free.
708 (Fmemory_free): New function.
709 (syms_of_alloc): Register it.
710
22657b40
DA
7112012-07-17 Dmitry Antipov <dmantipov@yandex.ru>
712
713 Cleanup overlays checking.
714 * buffer.h (OVERLAY_VALID): Remove as useless synonym of OVERLAYP.
715 * buffer.c (overlay_touches_p, recenter_overlay_lists): Change to
716 eassert and OVERLAYP.
717 (sort_overlays): Change to use OVERLAYP.
718
ddfc8813
RK
7192012-07-16 René Kyllingstad <Rene@Kyllingstad.com> (tiny change)
720
721 * editfns.c (Finsert_char): Make it interactive, and make the
722 second arg optional. Copy interactive spec and docstring from
723 ucs-insert.
724
7c26cf3c
PE
7252012-07-17 Paul Eggert <eggert@cs.ucla.edu>
726
727 * floatfns.c (Fabs): Do not wrap fabs inside IN_FLOAT (Bug#11913).
728 Unlike the other wrapped functions, fabs has an unspecified
729 effect on errno.
730
5d127af9
JD
7312012-07-16 Jan Djärv <jan.h.d@swipnet.se>
732
733 * nsterm.m (keyDown): Interpret flags without left/right bits
734 as the left key (Bug#11670).
735
6a0dd1d7
DA
7362012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
737
738 Remove empty and useless init functions.
739 * lisp.h (init_character_once, init_fns, init_image)
740 (init_filelock, init_sound): Remove prototype.
741 * character.c (init_character_once): Remove.
742 * filelock.c (init_filelock): Likewise.
743 * fns.c (init_fns): Likewise.
744 * image.c (init_image): Likewise.
745 * sound.c (init_sound): Likewise.
746 * emacs.c (main): Adjust accordingly.
747
7a6136fd
DA
7482012-07-16 Dmitry Antipov <dmantipov@yandex.ru>
749
750 * gtkutil.h: Tiny cleanups.
751 (use_old_gtk_file_dialog): Remove useless declaration.
752 (xg_uses_old_file_dialog): Add suggested const attribute.
753
ce811ad9
EZ
7542012-07-15 Eli Zaretskii <eliz@gnu.org>
755
756 * bidi.c (MAX_STRONG_CHAR_SEARCH): New macro.
757 (bidi_paragraph_init): Use it to limit search forward for a strong
758 directional character in abnormally large paragraphs full of
759 neutral or weak characters. (Bug#11943)
760
c9adfeaa
SF
7612012-07-15 Stefano Facchini <stefano.facchini@gmail.com> (tiny change)
762
763 * gtkutil.c (xg_create_tool_bar): Apply "primary-toolbar" style to
764 the toolbar (Bug#9451).
765 (xg_make_tool_item): Give the widget event box a transparent
766 background.
767
fff62aa9
DA
7682012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
769
770 Cleanup basic allocation variables and functions.
771 * alloc.c (ignore_warnings, init_intervals, init_float)
772 (init_cons, init_symbol, init_marker): Remove.
773 (interval_block_index): Initialize to INTERVAL_BLOCK_SIZE.
774 (float_block_index): Initialize to FLOAT_BLOCK_SIZE.
775 (cons_block_index): Initialize to CONS_BLOCK_SIZE.
776 (symbol_block_size): Initialize to SYMBOL_BLOCK_SIZE.
777 (marker_block_index): Initialize to MARKER_BLOCK_SIZE.
778 (staticidx, init_alloc_once, init_strings, free_ablock):
779 Remove redundant initialization.
780 * fns.c (init_weak_hash_tables): Remove.
781 * lisp.h (init_weak_hash_tables): Remove prototype.
782
9730daca
DA
7832012-07-15 Dmitry Antipov <dmantipov@yandex.ru>
784
785 Use zero_vector where appropriate.
786 * alloc.c (zero_vector): Define as Lisp_Object. Adjust users
787 accordingly.
788 * lisp.h (zero_vector): New declaration.
789 * font.c (null_vector): Remove.
790 (syms_of_font): Remove initialization and staticpro.
791 (font_list_entities, font_find_for_lface): Change to use zero_vector.
792 * keymap.c (Faccessible_keymaps): Likewise.
793
2e2d2a13
LL
7942012-07-15 Leo Liu <sdl.web@gmail.com>
795
796 * fringe.c: Fix typo in comments.
797
cd276f6e
LL
7982012-07-14 Leo Liu <sdl.web@gmail.com>
799
800 * fringe.c: Add a new bitmap exclamation-mark.
801
5a1131d9
EZ
8022012-07-14 Eli Zaretskii <eliz@gnu.org>
803
804 * gmalloc.c (GMALLOC_INHIBIT_VALLOC): Don't reference.
805
806 * s/msdos.h (BSD_SYSTEM, DATA_START, GC_SETJMP_WORKS, HAVE_MOUSE)
807 (HAVE_MENUS): Don't define, defined by editing config.in with
808 msdos/sed2v2.inp.
809 (GMALLOC_INHIBIT_VALLOC): Don't define.
810 (MODE_LINE_BINARY_TEXT): Remove, not used anymore.
811
22e983b7
JB
8122012-07-14 Juanma Barranquero <lekktu@gmail.com>
813
814 * s/ms-w32.h (GC_SETJMP_WORKS, GC_MARK_STACK): Set in nt/config.nt.
815
5b3f250f
GM
8162012-07-14 Glenn Morris <rgm@gnu.org>
817
818 * s/aix4-2.h, s/freebsd.h, s/gnu-linux.h, s/hpux10-20.h:
819 * s/irix6-5.h, s/netbsd.h, s/sol2-6.h, s/unixware.h:
820 Let configure set GC_SETJMP_WORKS, GC_MARK_STACK.
821
33d63ff4
GM
8222012-07-13 Glenn Morris <rgm@gnu.org>
823
5b633342
GM
824 * s/gnu-linux.h (GC_MARK_SECONDARY_STACK): Let configure set it.
825
33d63ff4
GM
826 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Let configure set it.
827 * s/irix6-5.h (SETUP_SLAVE_PTY): No more need to unset it.
828
b55b9f85
JD
8292012-07-13 Jan Djärv <jan.h.d@swipnet.se>
830
0dc8cf50
JD
831 * nsterm.m (uRect): Only define if NS_IMPL_GNUSTEP.
832 (x_free_frame_resources): Pass x_free_frame_resources to NSTRACE.
833 (ns_lisp_to_color, ns_string_to_lispmod, ns_term_init)
834 (ns_term_shutdown, requestService, initFrameFromEmacs): Use SSDATA
835 where appropriate.
836 (ns_exec_path, ns_load_path, changeFont): Put () around assignment used
837 as boolean expression.
838 (x_set_window_size): Remove unused variable toolbar.
839 (ns_get_color_default, ns_mod_to_lisp): Remove.
840 (ns_mouse_position): Remove unused variables xchar and ychar.
841 (ns_compute_glyph_string_overhangs): Remove unused variable face.
842 (ns_set_vertical_scroll_bar): Remove unused variable count.
843 (ns_delete_terminal): Remove unused variable i.
844 (ns_term_init): Remove unused variables r, g and b.
845 (mouseDown): Remove unused variable window.
846 (windowDidResize): Move definition of theWindow inside NS_IMPL_GNUSTEP.
847 (initFrameFromEmacs): Remove unused variable vbextra.
848 (mouseEntered): Remove unused variables p and dpyinfo.
849 (mouseExited): Remove unused variables p and r.
850 (ns_define_frame_cursor, ns_clear_frame_area)
851 (ns_draw_window_cursor, ns_initialize_display_info): Make static.
852 (menuDown): Assign [sender tag] to variable and cast the variable.
853
854 * nsterm.h (menuDown): Add id as type to argument sender.
855 (ns_display_info_for_name): Add Lisp_Object argument.
856 (ns_term_init): Add Lisp_Object argument.
857 (ns_map_event_to_object): Add void argument.
858 (ns_string_from_pasteboard, ns_string_to_pasteboard): Add correct
859 prototype with arguments and only declare if __OBJC__.
860 (nxatoms_of_nsselect): Add void argument.
861 (ns_lisp_to_cursor_type): Add Lisp_Object argument.
862 (ns_alloc_autorelease_pool): Add void argument.
863 (ns_release_autorelease_pool): Add void* argument.
864 (ns_get_defaults_value): Add const char* argument.
865
866 * nsmenu.m (ns_update_menubar, ns_menu_show, process_dialog)
867 (initFromContents): Use SSDATA where appropriate.
868 (ns_update_menubar): Add braces to ambigous if-else.
869 (initWithTitle): Put () around assignment in if statement.
870 (ns_menu_show): Remove unused variables window and keymap.
871 (update_frame_tool_bar): Remove unused variable selected_p.
872 (initWithContentRect): Remove unused variable this_cmd_name.
873
874 * nsimage.m (ns_load_image, allocInitFromFile): Use SSDATA where
875 appropriate.
876 (setXBMColor): Remove unused variable len.
877 (setPixmapData): Put () around assignment in loop statement.
878
879 * nsfont.m (ns_get_family, ns_lang_to_script, ns_otf_to_script)
880 (ns_registry_to_script, ns_get_req_script, nsfont_open): Use SSDATA
881 where appropriate.
882 (ns_get_covering_families, ns_findfonts, nsfont_list_family): Put ()
883 around assignment in loop statement.
884 (nsfont_open): Remove unused variable i.
885 (nsfont_open): Remove unused variable len.
886 (nsfont_draw): Remove unused variable cs.
887
888 * nsfns.m (x_set_icon_name, ns_set_name_internal)
889 (ns_set_name_as_filename, ns_implicitly_set_icon_type)
890 (x_set_icon_type, ns_lisp_to_cursor_type, Fns_read_file_name)
891 (Fns_get_resource, Fns_set_resource, Fx_open_connection)
892 (Fns_font_name, Fns_perform_service)
893 (Fns_convert_utf8_nfd_to_nfc, ns_do_applescript)
894 (Fns_do_applescript, Fx_show_tip): Use SSDATA where appropriate.
895 (ns_set_name): Remove unused variable view.
896 (x_set_menu_bar_lines): Remove unused variable olines.
897 (x_set_tool_bar_lines): Remove unused variable root_window.
898 (Fns_list_colors): Put () around assignment in while statement.
899 (Fns_perform_service): Remove unused variable len.
900 (Fns_display_usable_bounds): Remove unused variable top.
901 (syms_of_nsfns): Remove unused variable i.
902
b55b9f85
JD
903 * nsmenu.m (ns_update_menubar): Exchange place of argument 2 and 3 to
904 memcpy (Bug#11907).
905
ed9265fc 9062012-07-13 Kalle Kankare <kalle.kankare@iki.fi> (tiny change)
2277de02
JD
907
908 * image.c (Fimagemagick_types): Initialize ex with GetExceptionInfo
909 and free it with DestroyExceptionInfo (Bug#11558).
910
ef099b57
JB
9112012-07-13 Juanma Barranquero <lekktu@gmail.com>
912
913 * s/ms-w32.h (FIRST_PTY_LETTER, HAVE_SOCKETS): Move to nt/config.nt.
914 (HAVE_ATTRIBUTE_ALIGNED, HAVE_C99_STRTOLD, HAVE___BUILTIN_UNWIND_INIT):
915 Set here, not in nt/config.nt.
916
ea814a5d
EZ
9172012-07-13 Eli Zaretskii <eliz@gnu.org>
918
919 * xdisp.c (move_it_in_display_line_to): On GUI terminals, allow
920 cursor overflow into the last glyph on display line when the right
921 fringe is off. (Bug#11832)
922
1a952767
PE
9232012-07-13 Paul Eggert <eggert@cs.ucla.edu>
924
925 * xdisp.c (produce_special_glyphs): Now static.
926 * dispextern.h (produce_special_glyphs): Remove decl.
927
983188fd
GM
9282012-07-13 Glenn Morris <rgm@gnu.org>
929
32fb4bb6
GM
930 * s/bsd-common, s/cygwin.h: Remove empty files.
931 * s/freebsd.h, s/netbsd.h: Do not include bsd-common.h.
932
983188fd
GM
933 * s/usg5-4-common.h (USG, USG5):
934 * s/template.h (USG5, USG, HPUX, BSD4_2, BSD_SYSTEM):
935 * s/sol2-6.h (SOLARIS2):
936 * s/irix6-5.h (IRIX6_5):
937 * s/hpux10-20.h (USG, USG5, HPUX):
938 * s/gnu-linux.h (USG, GNU_LINUX):
939 * s/freebsd.h (BSD_SYSTEM):
940 * s/darwin.h (BSD4_2, BSD_SYSTEM, DARWIN_OS):
941 * s/cygwin.h (CYGWIN):
942 * s/bsd-common.h (BSD_SYSTEM, BSD4_2):
943 * s/aix4-2.h (USG, USG5, _AIX): Move "system type" macros to configure.
944
d1e68667 9452012-07-13 BT Templeton <bpt@hcoop.net> (tiny change)
24ef80ae
PE
946
947 * nsfont.m (ns_charset_covers): Don't abort if no bitmap (Bug#11853).
24ef80ae 948
6de0e799
GM
9492012-07-13 Glenn Morris <rgm@gnu.org>
950
739ae010
GM
951 * s/usg5-4-common.h (NSIG_MINIMUM): Let configure set it.
952
dbee5793
GM
953 * s/gnu-linux.h, s/irix6-5.h: Let configure set ULIMIT_BREAK_VALUE.
954
6de0e799
GM
955 * process.c (init_process_emacs): Replace MIN_PTY_KERNEL_VERSION.
956 * s/darwin.h (MIN_PTY_KERNEL_VERSION): Remove single-use macro.
957
b82da769
GM
9582012-07-12 Glenn Morris <rgm@gnu.org>
959
4fae5a7a 960 * s/darwin.h (SYSTEM_PURESIZE_EXTRA): Move to configure.
b82da769
GM
961
962 * process.c (init_process_emacs): Rename from init_process.
963 The old name is also the name of a Mach system call.
964 * lisp.h, emacs.c: Update for this name change.
965 * nsgui.h, sysselect.h, s/darwin.h: Remove workaround that is no
966 longer needed.
967
5a979817
EZ
9682012-07-12 Eli Zaretskii <eliz@gnu.org>
969
970 * xdisp.c (insert_left_trunc_glyphs): Fix incorrect size in
971 memmove call that removes glyphs covered by the left truncation
972 glyph. Improve commentary.
973 (display_line): Fix display of continuation glyphs on GUI frames
974 when the right fringe is turned off and variable-size fonts are
975 used in the window. Move the code that appends a stretch glyph to
976 produce_special_glyphs, so that it could be used for truncation
977 and continuation glyphs alike.
978 (produce_special_glyphs) [HAVE_WINDOW_SYSTEM]: Produce a stretch
979 glyph of a suitably computed width, to align the special glyphs at
980 the window margin. Code moved from display_line. (Bug#11832)
981
3e91a053
GM
9822012-07-12 Glenn Morris <rgm@gnu.org>
983
ba9e4b84
GM
984 * s/aix4-2.h, s/hpux10-20.h: Let configure set NO_EDITRES.
985
986 * s/gnu-linux.h, s/hpux10-20.h:
987 Do not unconditionally define HAVE_XRMSETDATABASE.
988
3e91a053
GM
989 * s/gnu-linux.h (UNIX98_PTYS): Let configure set it.
990
b300b1f4
PE
9912012-07-12 Paul Eggert <eggert@cs.ucla.edu>
992
993 Fix typos that broke OS X build.
994 Reported by Randal L. Schwartz in
995 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00225.html>.
996 * nsterm.m (ns_timeout): Add missing local decl.
997 (ns_get_color): snprintf -> sprintf, to fix typo.
998
6e777848
GM
9992012-07-12 Glenn Morris <rgm@gnu.org>
1000
3f922c37
GM
1001 * src/s/aix4-2.h, src/s/cygwin.h, src/s/darwin.h:
1002 * src/s/gnu-linux.h, src/s/hpux10-20.h, src/s/irix6-5.h:
1003 * src/s/sol2-6.h, src/s/unixware.h, src/s/usg5-4-common.h:
1004 Move PTY_NAME_SPRINTF, PTY_TTY_NAME_SPRINTF to configure.
1005
0ab7b23a
GM
1006 * s/cygwin.h, s/darwin.h, s/gnu-linux.h, s/irix6-5.h:
1007 Move PTY_OPEN to configure.
1008
6e777848
GM
1009 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1010 * s/gnu-linux.h, s/hpux10-20.h, s/irix6-5.h, s/template.h:
1011 * s/usg5-4-common.h: Move FIRST_PTY_LETTER, PTY_ITERATION to configure.
1012
4a7edc24
DA
10132012-07-12 Dmitry Antipov <dmantipov@yandex.ru>
1014
1015 Use empty_unibyte_string where applicable.
1016 * keyboard.c (parse_tool_bar_item): Use empty_unibyte_string.
1017 * lread.c (read1): Likewise.
1018 * xsettings.c (syms_of_xsettings): Likewise.
1019
308aab79
GM
10202012-07-12 Glenn Morris <rgm@gnu.org>
1021
42bd1719
GM
1022 * s/cygwin.h (G_SLICE_ALWAYS_MALLOC):
1023 * s/freebsd.h (BROKEN_PTY_READ_AFTER_EAGAIN):
7ccad002
GM
1024 * s/irix6-5.h (SETPGRP_RELEASES_CTTY, PREFER_VSUSP):
1025 * s/hpux10-20.h (RUN_TIME_REMAP):
1026 * s/bsd-common.h (TABDLY): Move to configure.
1027
1028 * s/hpux10-20.h, s/sol2-6.h: Move XOS_NEEDS_TIME_H to configure.
1029
1030 * s/bsd-common.h, s/darwin.h: Move TAB3 to configure.
1031
ea0bbd17 1032 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
42bd1719 1033 (BROKEN_SIGPOLL, BROKEN_GET_CURRENT_DIR_NAME): Let configure set them.
ea0bbd17
GM
1034
1035 * s/darwin.h (NO_ABORT, NO_MATHERR): Let configure set them.
51c3b9b4 1036
308aab79
GM
1037 * s/bsd-common.h, s/cygwin.h, s/gnu-linux.h, s/irix6-5.h:
1038 * s/template.h: Move NARROWPROTO to configure.
1039
ee1cf5cf
GM
10402012-07-11 Glenn Morris <rgm@gnu.org>
1041
30fe9bf4
GM
1042 * s/gnu-linux.h, s/sol2-6.h: No longer define POSIX,
1043 unused since 2011-01-17 change to systty.h.
1044
ee1cf5cf
GM
1045 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h, s/gnu-linux.h:
1046 * s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1047 Move HAVE_PTYS and HAVE_SOCKETS to configure.
1048
63e47e07
PE
10492012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1050
1051 * s/sol2-6.h (HAVE_LIBKSTAT): Remove. (Bug#11914)
1052
c43fb4c3
GM
10532012-07-11 Glenn Morris <rgm@gnu.org>
1054
1055 * s/darwin.h, s/gnu-linux.h, s/template.h:
1056 Move INTERRUPT_INPUT to configure.
1057
e8df9267
DA
10582012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1059
1060 Minor adjustments to interning code.
1061 * lisp.h (intern, intern_c_string): Redefine as static inline
1062 wrappers for intern_1 and intern_c_string_1, respectively.
1063 (intern_1, intern_c_string_1): Rename prototypes.
2bce5643
DA
1064 * lread.c (intern_1, intern_c_string_1, oblookup): Simplify
1065 Vobarray checking.
e8df9267
DA
1066 * font.c (font_intern_prop): Likewise. Adjust comment.
1067 * w32font.c (intern_font_name): Likewise.
1068
34348bd4
AS
10692012-07-11 Andreas Schwab <schwab@linux-m68k.org>
1070
d96a1e0c
AS
1071 * gnutls.c (Fgnutls_boot): Properly parse :keylist argument.
1072
34348bd4
AS
1073 * coding.c (Fdefine_coding_system_internal): Use XCAR/XCDR instead
1074 of Fcar/Fcdr if possible.
1075 * font.c (check_otf_features): Likewise.
1076 * fontset.c (Fnew_fontset): Likewise.
1077 * gnutls.c (Fgnutls_boot): Likewise.
1078 * minibuf.c (read_minibuf): Likewise.
1079 * msdos.c (IT_set_frame_parameters): Likewise.
1080 * xmenu.c (Fx_popup_dialog): Likewise.
1081 * w32menu.c (Fx_popup_dialog): Likewise.
1082
c8add24e
GM
10832012-07-11 Glenn Morris <rgm@gnu.org>
1084
4b575b3c
GM
1085 * s/bsd-common.h, s/cygwin.h: No need to undefine INTERRUPT_INPUT,
1086 since nothing has defined it on these platforms.
1087
09f4e3b0
GM
1088 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/gnu-linux.h:
1089 * s/irix6-5.h: Move SIGNALS_VIA_CHARACTERS to configure.
1090
172bedef
GM
1091 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
1092 * s/gnu-linux.h, s/hpux10-20.h, s/template.h, s/usg5-4-common.h:
1093 Move CLASH_DETECTION to configure.
1094
249685df
GM
1095 * s/gnu.h: Remove file, which is now empty.
1096
c8add24e
GM
1097 * s/gnu.h, s/gnu-linux.h:
1098 Move GNU_LIBRARY_PENDING_OUTPUT_COUNT to configure.
1099
b41253a3
JW
11002012-07-11 John Wiegley <johnw@newartisans.com>
1101
1102 * alloc.c (mark_memory): Guard the "no_address_safety_analysis"
1103 function attribute, so we only use it if it exists in the
1104 compiler.
1105
d923b542
DA
11062012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1107
1108 Avoid call to strlen in fast_c_string_match_ignore_case.
1109 * search.c (fast_c_string_match_ignore_case): Change to use
1110 length argument. Adjust users accordingly.
1111 * lisp.h (fast_c_string_match_ignore_case): Adjust prototype.
1112
5ebbef1d
PE
11132012-07-11 Paul Eggert <eggert@cs.ucla.edu>
1114
bb352260
PE
1115 Assume mkdir, rmdir.
1116 * sysdep.c (mkdir) [!HAVE_MKDIR]: Remove.
1117 * sysdep.c (rmdir) [!HAVE_RMDIR]: Remove.
1118
57054ddd
PE
1119 Assume rename.
1120 * sysdep.c (rename) [!HAVE_RENAME]: Remove.
1121
b747d3f7
PE
1122 Assume perror.
1123 * s/hpux10-20.h (HAVE_PERROR): Remove.
1124 * sysdep.c (perror) [HPUX && !HAVE_PERROR]:
1125 Remove dummy definition, as this problem was obsolete long ago.
1126
5ebbef1d
PE
1127 Assume strerror.
1128 * sysdep.c (strerror) [!HAVE_STRERROR && !WINDOWSNT]: Remove.
1129
984e7f30
DA
11302012-07-11 Dmitry Antipov <dmantipov@yandex.ru>
1131
1132 Avoid calls to strlen in font processing functions.
1133 * font.c (font_parse_name, font_parse_xlfd, font_parse_fcname)
d923b542 1134 (font_open_by_name): Change to use length argument. Adjust
984e7f30 1135 users accordingly.
d923b542
DA
1136 * font.h (font_open_by_name, font_parse_xlfd, font_unparse_xlfd):
1137 Adjust prototypes.
1138 * xfont.c (xfont_decode_coding_xlfd, font_unparse_xlfd):
1139 Change to return ptrdiff_t.
984e7f30
DA
1140 (xfont_list_pattern, xfont_match): Use length returned by
1141 xfont_decode_coding_xlfd.
1142 * xfns.c (x_default_font_parameter): Omit useless xstrdup.
1143
20e94fdd
GM
11442012-07-11 Glenn Morris <rgm@gnu.org>
1145
9d596af3
GM
1146 * s/darwin.h, s/freebsd.h, s/netbsd.h:
1147 Move DONT_REOPEN_PTY to configure.
1148
20e94fdd
GM
1149 * sound.c (DEFAULT_SOUND_DEVICE) [!WINDOWSNT]:
1150 * s/netbsd.h (DEFAULT_SOUND_DEVICE): Let configure set it.
1151
e99a530f
PE
11522012-07-10 Paul Eggert <eggert@cs.ucla.edu>
1153
22ffb973
PE
1154 Remove "#define unix" that is no longer needed (Bug#11905).
1155 * s/aix4-2.h (unix): Remove; no longer needed.
1156
e9a9ae03
PE
1157 EMACS_TIME simplification (Bug#11875).
1158 This replaces macros (which typically do not work in GDB)
1159 with functions, typedefs and enums, making the code easier to debug.
1160 The functional style also makes code easier to read and maintain.
1161 * systime.h: Include <sys/time.h> on all hosts, not just if
1162 WINDOWSNT, since 'struct timeval' is needed in general.
1163 (EMACS_TIME): Now a typedef, not a macro.
1164 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): Now constants,
1165 not macros.
1166 (EMACS_SECS, EMACS_NSECS, EMACS_TIME_SIGN, EMACS_TIME_VALID_P)
1167 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE, EMACS_TIME_EQ)
1168 (EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE, EMACS_TIME_LT)
1169 (EMACS_TIME_LE): Now functions, not macros.
1170 (EMACS_SET_SECS, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS)
1171 (EMACS_SET_USECS, EMACS_SET_SECS_USECS): Remove these macros,
1172 which are not functions. All uses rewritten to use:
1173 (make_emacs_time): New function.
1174 (EMACS_SECS_ADDR, EMACS_SET_INVALID_TIME, EMACS_GET_TIME)
1175 (EMACS_ADD_TIME, EMACS_SUB_TIME): Remove these macros, which are
1176 not functions. All uses rewritten to use the following, respectively:
1177 (emacs_secs_addr, invalid_emacs_time, get_emacs_time)
1178 (add_emacs_time, sub_emacs_time): New functions.
ed9265fc 1179 * atimer.c: Don't include <sys/time.h>, as "systime.h" does this.
e9a9ae03
PE
1180 * fileio.c (Fcopy_file):
1181 * xterm.c (XTflash): Get the current time closer to when it's used.
1182 * makefile.w32-in ($(BLD)/atimer.$(O)): Update dependencies.
1183
ffacb126
PE
1184 * bytecode.c (targets): Suppress -Woverride-init warnings.
1185
e99a530f
PE
1186 Simplify by avoiding confusing use of strncpy etc.
1187 * doc.c (Fsnarf_documentation):
1188 * fileio.c (Ffile_name_directory, Fsubstitute_in_file_name):
1189 * frame.c (Fmake_terminal_frame):
1190 * gtkutil.c (get_utf8_string):
1191 * lread.c (openp):
1192 * nsmenu.m (ns_update_menubar):
1193 * regex.c (regerror):
1194 Prefer memcpy to strncpy and strncat when either will do.
1195 * fileio.c (Fsubstitute_in_file_name):
1196 * keyboard.c (MULTI_LETTER_MOD, parse_modifiers_uncached)
1197 (menu_separator_name_p):
1198 * nsmenu.m (ns_update_menubar):
1199 Prefer memcmp to strncmp when either will do.
1200 * nsterm.m: Include <ftoastr.h>.
1201 (ns_get_color):
1202 * s/gnu-linux.h, s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF):
1203 Prefer snprintf to strncpy.
1204 * nsterm.m (ns_term_init):
1205 * widget.c (set_frame_size) [0]: Prefer xstrdup to xmalloc + strncpy.
1206 * nsterm.m (ns_term_init):
1207 Avoid the need for strncpy, by using build_string or
1208 make_unibyte_string directly. Use dtoastr, not snprintf.
1209 * process.c (Fmake_network_process): Diagnose service names that
1210 are too long, rather than silently truncating them or creating
1211 non-null-terminated names.
1212 (Fnetwork_interface_info): Likewise, for interface names.
1213 * sysdep.c (system_process_attributes) [GNU_LINUX]:
1214 Prefer sprintf to strncat.
1215 * xdisp.c (debug_method_add) [GLYPH_DEBUG]:
1216 Prefer vsnprintf to vsprintf + strncpy.
1217
c59592b3
GM
12182012-07-10 Glenn Morris <rgm@gnu.org>
1219
1220 * dispnew.c (PENDING_OUTPUT_COUNT) [!__GNU_LIBRARY__]:
1221 Clarify fallback case.
1222
7d7bbefd
DA
12232012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1224
1225 Use XCAR and XCDR instead of Fcar and Fcdr where possible.
1226 * callint.c, coding.c, doc.c, editfns.c, eval.c, font.c, fontset.c,
1227 * frame.c, gnutls.c, minibuf.c, msdos.c, textprop.c, w32fns.c,
d923b542 1228 * w32menu.c, window.c, xmenu.c: Change to use XCAR and XCDR
7d7bbefd
DA
1229 where argument type is known to be a Lisp_Cons.
1230
3a4c8000
TT
12312012-07-10 Tom Tromey <tromey@redhat.com>
1232
1233 * bytecode.c (BYTE_CODE_THREADED): New macro.
1234 (BYTE_CODES): New macro. Replaces all old byte-code defines.
1235 (enum byte_code_op): New type.
1236 (CASE, NEXT, FIRST, CASE_DEFAULT, CASE_ABORT): New macros.
1237 (exec_byte_code): Use them. Use token threading when applicable.
1238
2a0213a6
DA
12392012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1240
1241 Optimize pure C strings initialization.
1242 * lisp.h (make_pure_string): Fix prototype.
1243 (build_pure_c_string): New function, defined as static inline. This
1244 provides a better opportunity to optimize away calls to strlen when
1245 the function is called with compile-time constant argument.
1246 * alloc.c (make_pure_c_string): Fix comment. Change to add nchars
1247 argument, adjust users accordingly. Use build_pure_c_string where
1248 appropriate.
1249 * buffer.c, coding.c, data.c, dbusbind.c, fileio.c, fontset.c, frame.c,
1250 * keyboard.c, keymap.c, lread.c, search.c, syntax.c, w32fns.c, xdisp.c,
1251 * xfaces.c, xfns.c, xterm.c: Use build_pure_c_string where appropriate.
1252
cb1caeaf
DA
12532012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1254
1255 Avoid calls to strlen in miscellaneous functions.
1256 * buffer.c (init_buffer): Use precalculated len, adjust if needed.
1257 * font.c (Ffont_xlfd_name): Likewise. Change to call make_string.
1258 * lread.c (openp): Likewise.
1259
c293e30c
DA
12602012-07-10 Dmitry Antipov <dmantipov@yandex.ru>
1261
1262 Avoid calls to strlen in path processing functions.
1263 * fileio.c (file_name_as_directory): Add comment. Change to add
1264 srclen argument and return the length of result. Adjust users
1265 accordingly.
1266 (directory_file_name): Fix comment. Change to add srclen argument,
cb1caeaf 1267 swap 1st and 2nd arguments to obey the common convention. Adjust
c293e30c
DA
1268 users accordingly.
1269 * filelock.c (fill_in_lock_file_name): Avoid calls to strlen.
1270
9e059e3f
GM
12712012-07-10 Glenn Morris <rgm@gnu.org>
1272
d02eb359
GM
1273 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/netbsd.h, s/unixware.h:
1274 Move PENDING_OUTPUT_COUNT definition to configure.
1275
882cf227
GM
1276 * s/irix6-5.h (DATA_START, DATA_SEG_BITS):
1277 * s/hpux10-20.h (DATA_SEG_BITS, DATA_START):
1278 * s/gnu.h (DATA_START): Move definitions to configure.
1279
af6e839f
GM
1280 * s/irix6-5.h (SETUP_SLAVE_PTY, PTY_NAME_SPRINTF): Drop ifdef guards.
1281 We include usg5-4-common.h, which defines them both.
1282
40289a12
GM
1283 * s/gnu.h: Don't include fcntl.h (every file in Emacs that uses
1284 O_RDONLY already includes it).
1285
9e059e3f
GM
1286 Stop ns builds setting the EMACSLOADPATH environment variable.
1287 * nsterm.m (ns_load_path): Rename from ns_init_paths.
1288 Now it does not set EMACSLOADPATH, just returns the load-path string.
1289 * nsterm.h: Update accordingly.
1290 * lread.c [HAVE_NS]: Include nsterm.h.
1291 (init_lread) [HAVE_NS]: Use ns_load_path.
1292 * emacs.c (main) [HAVE_NS]: No longer call ns_init_paths.
1293
7c4e8ec0
GM
12942012-07-09 Glenn Morris <rgm@gnu.org>
1295
d4f600ff
GM
1296 * s/gnu.h (SIGNALS_VIA_CHARACTERS): No need to define it here,
1297 since the included bsd-common.h does so.
1298
cbb31951
GM
1299 Stop ns builds setting the EMACSPATH environment variable.
1300 * nsterm.m (ns_exec_path): New function, split from ns_init_paths.
1301 (ns_init_paths): Do not set EMACSPATH.
1302 * nsterm.h (ns_exec_path): Add it.
1303 * callproc.c (init_callproc_1, init_callproc) [HAVE_NS]:
1304 Use ns_exec_path.
1305
7c4e8ec0
GM
1306 * nsterm.m, nsterm.h (ns_etc_directory): Fix type, empty return.
1307
26bccfae
PE
13082012-07-09 Paul Eggert <eggert@cs.ucla.edu>
1309
a0bee46f
PE
1310 * process.c (wait_reading_process_output): 'waitchannels' was unset
1311 when read_kbd || !NILP (wait_for_cell); fix this.
1312
5994c183
PE
1313 Add GCC-style 'const' attribute to functions that can use it.
1314 * character.h (char_resolve_modifier_mask):
1315 * keyboard.h (make_ctrl_char):
1316 * lisp.h (multibyte_char_to_unibyte, multibyte_char_to_unibyte_safe)
1317 (init_character_once, next_almost_prime, init_fns, init_image)
1318 (flush_pending_output, init_sound):
1319 * mem-limits.h (start_of_data):
1320 * menu.h (finish_menu_items):
1321 Add ATTRIBUTE_CONST.
1322 * emacs.c (DEFINE_DUMMY_FUNCTION):
1323 Declare the dummy function with ATTRIBUTE_CONST.
1324 * lisp.h (Fbyteorder, Fmax_char, Fidentity):
1325 Add decls with ATTRIBUTE_CONST.
1326
26bccfae
PE
1327 Minor improvements to make_formatted_string.
1328 * alloc.c (make_formatted_string): Prefer int to ptrdiff_t
1329 where int is good enough, as vsprintf returns an int.
1330 * lisp.h (make_formatted_string): Add ATTRIBUTE_FORMAT_PRINTF.
1331
a8290ec3
DA
13322012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1333
1334 Use make_formatted_string to avoid double length calculation.
1335 * lisp.h (make_formatted_string): New prototype.
1336 * alloc.c (make_formatted_string): New function.
1337 * buffer.c (Fgenerate_new_buffer_name): Use it.
1338 * dbus.c (syms_of_dbusbind): Likewise.
1339 * editfns.c (Fcurrent_time_zone): Likewise.
1340 * filelock.c (get_boot_time): Likewise.
1341 * frame.c (make_terminal_frame, set_term_frame_name)
1342 (x_report_frame_params): Likewise.
1343 * image.c (gs_load): Likewise.
1344 * minibuf.c (get_minibuffer): Likewise.
1345 * msdos.c (dos_set_window_size): Likewise.
1346 * process.c (make_process): Likewise.
1347 * xdisp.c (ensure_echo_area_buffers): Likewise.
1348 * xsettings.c (apply_xft_settings): Likewise.
1349
d01ba2f1
GM
13502012-07-09 Glenn Morris <rgm@gnu.org>
1351
1352 Stop ns builds polluting the environment with EMACSDATA, EMACSDOC.
1353 * nsterm.m (ns_etc_directory): New function, split from ns_init_paths.
1354 (ns_init_paths): Do not set EMACSDATA, EMACSDOC.
1355 * nsterm.h (ns_etc_directory): Add it.
1356 * callproc.c [HAVE_NS]: Include nsterm.h.
1357 (init_callproc_1, init_callproc) [HAVE_NS]: Use ns_etc_directory.
1358
f1f924b6
DA
13592012-07-09 Dmitry Antipov <dmantipov@yandex.ru>
1360
1361 Move marker debugging code under MARKER_DEBUG.
1362 * marker.c (MARKER_DEBUG): Move marker debugging code under
1363 #ifdef MARKER_DEBUG because byte_char_debug_check is too slow
1364 for bootstrap with --enable-checking (~3x slowdown reported
1365 by Juanma Barranquero <lekktu@gmail.com>).
1366 (verify_bytepos): Move under #ifdef MARKER_DEBUG.
1367
ab531b66
PE
13682012-07-08 Paul Eggert <eggert@cs.ucla.edu>
1369
1370 * systime.h (EMACS_SUB_TIME): Clarify behavior with unsigned time_t.
1371 See <http://bugs.gnu.org/11825#29>.
1372
c4b3bc8a
EZ
13732012-07-08 Eli Zaretskii <eliz@gnu.org>
1374
1375 * xdisp.c (fill_glyphless_glyph_string): If the face of the glyph
1376 has no font, use the frame's font. (Bug#11813)
3434fe8a
EZ
1377 (display_line): Add commentary about displaying truncation glyphs
1378 on GUI frames.
1379 (produce_special_glyphs): Move here from term.c.
1380
1381 * term.c (produce_special_glyphs): Move to xdisp.c.
1382
1383 * dispextern.h (produce_special_glyphs): Move prototype to xdisp.c
1384 section.
c4b3bc8a 1385
b676b881
AS
13862012-07-07 Andreas Schwab <schwab@linux-m68k.org>
1387
f17c5273
AS
1388 * xdisp.c (display_line): Avoid warning about implicit declaration
1389 of FRAME_FONT.
1390
298819b9
AS
1391 * frame.c (get_frame_param): Define only if HAVE_WINDOW_SYSTEM.
1392
b676b881
AS
1393 * lisp.h: Remove empty conditional.
1394
6045c4fd
PE
13952012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1396
b3350bf9
PE
1397 * lread.c (load_path_check): Now static.
1398
6045c4fd
PE
1399 Fix some minor --with-ns problems found by static checking.
1400 * frame.c (Ftool_bar_pixel_width) [!FRAME_TOOLBAR_WIDTH]:
1401 (x_set_font) [!HAVE_X_WINDOWS]:
1402 * image.c (xpm_load_image) [HAVE_NS]:
1403 (x_to_xcolors) [!HAVE_X_WINDOWS && !HAVE_NTGUI]:
1404 (x_disable_image) [!HAVE_NS && !HAVE_NTGUI]:
1405 Remove unused local.
1406 (Fx_parse_geometry) [HAVE_NS]: Don't return garbage.
1407 (xpm_load_image) [HAVE_NS && !HAVE_XPM]: Remove unused label.
1408 * image.c (x_create_bitmap_from_file) [HAVE_NS]:
1409 (xpm_load_image, xpm_load) [HAVE_NS && !HAVE_XPM]:
1410 * nsselect.m (symbol_to_nsstring, ns_string_to_pasteboard_internal):
1411 * xfaces.c (Fx_load_color_file) [!HAVE_X_WINDOWS]:
1412 Fix pointer signedness problem.
1413 * xfaces.c (FRAME_X_FONT_TABLE):
1414 * xterm.h (FRAME_X_FONT_TABLE): Remove unused, incompatible macros.
1415
929e7845
GM
14162012-07-07 Glenn Morris <rgm@gnu.org>
1417
1418 * lread.c (load_path_check): New function, split from init_lread.
1419 (init_lread): Reorganize. Motivation:
1420 If EMACSLOADPATH is set, check/warn about that rather than the
1421 defaults, which we are not going to use. Hence we can remove
1422 the turn_off_warning and WINDOWSNT || HAVE_NS tests.
1423 Don't warn if site-lisp directories are missing.
1424 If not installed, start from a blank load-path, since
1425 PATH_LOADSEARCH refers to the eventual installation directories.
1426
58dd0aa4
EZ
14272012-07-07 Eli Zaretskii <eliz@gnu.org>
1428
1429 Support truncation and continuation glyphs on GUI frames, when
1430 fringes are disabled. (Bug#11832)
1431 * xdisp.c (init_iterator): Get dimensions of truncation and
1432 continuation glyphs even if on GUI frames. Adjust
1433 it->last_visible_x on GUI frames when the left or right fringes,
1434 or both, are absent.
1435 (start_display, move_it_in_display_line_to): Handle the case of a
1436 GUI frame without a fringe to display continuation or truncation
1437 glyphs.
1438 (insert_left_trunc_glyphs): Support GUI frames: make sure
1439 truncation glyphs overwrite enough glyphs from the current line to
1440 have sufficient space in pixels.
1441 (display_line): Support truncation and continuation glyphs on GUI
1442 frames. If some spare pixels are left on the line after inserting
1443 the truncation glyphs, fill that space with a stretch glyph of a
1444 suitably computed width.
1445
1446 * term.c (produce_special_glyphs): Call PRODUCE_GLYPHS, not
1447 produce_glyphs, to support GUI sessions.
1448
31571fd7
PE
14492012-07-07 Paul Eggert <eggert@cs.ucla.edu>
1450
5a16b9bc
PE
1451 * sysdep.c (ULLONG_MAX): Define if not already defined (Bug#11781).
1452
f3047c75
PE
1453 * sysdep.c (list_system_processes): Port to NetBSD-current (Bug#11797).
1454
31571fd7
PE
1455 Do not require float-time's arg to fit in time_t (Bug#11825).
1456 This works better on hosts where time_t is unsigned, and where
1457 float-time is applied to the (negative) difference between two times.
1458 * editfns.c (decode_time_components): Last arg is now double *,
1459 not int *, and means to store all the result as a double, without
1460 worrying about whether the seconds part fits in time_t.
1461 All callers changed.
1462 (lisp_time_argument): Remove last int * arg, as it's no longer needed.
1463 All callers changed.
1464 (Ffloat_time): Do not fail merely because the specified time falls
1465 outside of time_t range.
1466
4516fbef
GM
14672012-07-07 Glenn Morris <rgm@gnu.org>
1468
1469 * s/darwin.h (HAVE_RES_INIT, HAVE_LIBRESOLV):
1470 * s/hpux10-20.h (HAVE_RINT, HAVE_RANDOM):
1471 * s/unixware.h (HAVE_GETWD): Move undefs to configure (effectively).
1472
07adc2c6
JB
14732012-07-07 Juanma Barranquero <lekktu@gmail.com>
1474
1475 * makefile.w32-in (DISPEXTERN_H, $(BLD)/regex.$(O)):
1476 Update dependencies.
1477
1478 * s/ms-w32.h [_MSC_VER]: Remove strcasecmp, strncasecmp.
1479
fd573f31
PE
14802012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1481
fee5959d
PE
1482 Use c_strcasecmp for ASCII case-insensitive comparison (Bug#11786).
1483 * dispextern.h, nsfns.m, nsterm.m: Include <c-strcase.h>.
1484 * dispextern.h (xstrcasecmp): Rewrite using c_strcasecmp.
1485 * nsfns.m (x_get_string_resource): Use c_strncasecmp, not strncasecmp.
1486 * nsterm.m (ns_default): Use c_strcasecmp, not strcasecmp.
1487 * xfaces.c (xstrcasecmp) [!HAVE_STRCASECMP]: Remove.
1488
fd573f31
PE
1489 * xfont.c (compare_font_names): Redo to omit the need for casts.
1490
ddadbc0e
AS
14912012-07-06 Andreas Schwab <schwab@linux-m68k.org>
1492
fca8d6b6
AS
1493 * xfns.c (Fx_change_window_property): Doc fix.
1494 * w32fns.c (Fx_change_window_property): Doc fix.
1495
ddadbc0e
AS
1496 * w32fns.c (Fx_window_property): Accept the same arguments as the
1497 X Windows version. Doc fix.
1498 * xfns.c (Fx_window_property): Doc fix. (Bug#11870)
1499
ed9265fc 15002012-07-06 Juanma Barranquero <lekktu@gmail.com>
f247498e
JB
1501 Eli Zaretskii <eliz@gnu.org>
1502
1503 * s/ms-w32.h: Settings not specific to Windows moved to nt/config.nt.
1504 Windows-specific code from nt/config.nt moved here.
1505 Obsolete settings removed.
1506
216ee680
PE
15072012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1508
1509 * process.c: Avoid unnecessary calls to gettime.
1510 (wait_reading_process_output): Don't get the time of day
1511 when gobbling data immediately and not waiting, as there's no need
1512 for it in that case. This removes a FIXME.
1513
bdd091e4
JD
15142012-07-06 Jan Djärv <jan.h.d@swipnet.se>
1515
1516 * gtkutil.c (xg_event_is_for_scrollbar): Assign gwin when HAVE_GTK3
1517 is defined (Bug#11768).
1518
9d44f8ce
DA
15192012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1520
1521 Fix marker debugging code.
1522 * marker.c (byte_char_debug_check): Do not perform the check
1523 if buffer is not multibyte.
090bd7cb
JB
1524 (buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1525 Call byte_char_debug_check with correct arguments.
9d44f8ce 1526
90fc4786
DA
15272012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1528
1529 Compile marker debugging code only if ENABLE_CHECKING is defined.
090bd7cb
JB
1530 * marker.c (byte_char_debug_check, count_markers):
1531 Use only if ENABLE_CHECKING is defined.
90fc4786
DA
1532 (byte_debug_flag): Remove.
1533 (CONSIDER, buf_charpos_to_bytepos, buf_bytepos_to_charpos):
1534 Always call byte_char_debug_check if ENABLE_CHECKING is defined.
1535
7b7ae965
DA
15362012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1537
4e57b342
DA
1538 Avoid code repetition in marker-related functions.
1539 * marker.c (attach_marker): New function.
1540 (Fset_marker, set_marker_restricted, set_marker_both)
1541 (set_marker_restricted_both): Use it.
1542 (Fset_marker, set_marker_restricted, Fbuffer_has_markers_at):
1543 Consistently rename charno to charpos.
1544 (marker_position): Add eassert.
1545 (marker_byte_position): Convert to eassert.
1546
15472012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1548
1549 Simplify list operations in unchain_overlay and unchain_marker.
7b7ae965 1550 * buffer.c (unchain_overlay): Simplify. Add comment.
4e57b342 1551 * marker.c (unchain_marker): Simplify. Fix comments.
7b7ae965 1552
657924ff
DA
15532012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1554
1555 Introduce fast path for the widely used marker operation.
1556 * alloc.c (build_marker): New function.
1557 * lisp.h (build_marker): New prototype.
1558 * buffer.c (clone_per_buffer_values, Fmake_indirect_buffer): Use it.
1559 * composite.c (autocmp_chars): Likewise.
1560 * editfns.c (buildmark): Remove.
1561 (Fpoint_marker, Fpoint_min_marker, Fpoint_max_marker)
1562 (save_restriction_save): Use build_marker.
1563 * marker.c (buf_charpos_to_bytepos, buf_bytepos_to_charpos): Likewise.
1564 * window.c (save_window_save): Likewise.
1565
041a49a6
DA
15662012-07-06 Dmitry Antipov <dmantipov@yandex.ru>
1567
1568 Do not use Fdelete_overlay in delete_all_overlays
1569 to avoid redundant calls to unchain_overlay.
1570 * buffer.c (drop_overlay): New function.
1571 (delete_all_overlays, Fdelete_overlay): Use it.
1572 * minibuf.c (get_minibuffer): Fix comment.
1573
7dca65a4
PE
15742012-07-06 Paul Eggert <eggert@cs.ucla.edu>
1575
1576 Port to OpenBSD 5.1 amd64.
1577 * sysdep.c [BSD_SYSTEM]: Include <sys/param.h> before <sys/sysctl.h>.
1578 This is needed for OpenBSD, and should be harmless on all BSD systems.
1579 Also, include <sys/sysctl.h>, as it should be available on all
1580 BSD_SYSTEM hosts given that we're already calling sysctl in that case.
1581 (list_system_processes) [__OpenBSD__]: Use DARWIN_OS style mib, but
1582 use p_pid member, not kp_proc.pid.
1583
8eb876e2
GM
15842012-07-06 Glenn Morris <rgm@gnu.org>
1585
1586 * Makefile.in (emacs$(EXEEXT)): Don't check for load-path shadows.
1587
38182d90
PE
15882012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1589
1590 More xmalloc and related cleanup.
1591 * alloc.c, bidi.c, buffer.c, buffer.h, bytecode.c, callint.c:
1592 * callproc.c, charset.c, coding.c, composite.c, data.c, dispnew.c:
1593 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, fns.c:
1594 * font.c, fontset.c, frame.c, fringe.c, ftfont.c, ftxfont.c, gmalloc.c:
1595 * gtkutil.c, image.c, keyboard.c, keymap.c, lread.c, macros.c, menu.c:
1596 * nsfns.m, nsfont.m, nsmenu.m, nsterm.m, print.c, process.c, ralloc.c:
1597 * regex.c, region-cache.c, scroll.c, search.c, sound.c, syntax.c:
1598 * sysdep.c, term.c, termcap.c, unexmacosx.c, window.c, xdisp.c:
1599 * xfaces.c, xfns.c, xftfont.c, xgselect.c, xmenu.c, xrdb.c, xselect.c:
1600 * xterm.c:
1601 Omit needless casts involving void * pointers and allocation.
1602 Prefer "P = xmalloc (sizeof *P)" to "P = xmalloc (sizeof (TYPE_OF_P))",
1603 as the former is more robust if P's type is changed.
1604 Prefer xzalloc to xmalloc + memset 0.
1605 Simplify malloc-or-realloc to realloc.
1606 Don't worry about xmalloc returning a null pointer.
1607 Prefer xstrdup to xmalloc + strcpy.
1608 * editfns.c (Fmessage_box): Grow message_text by at least 80 when
1609 growing it.
1610 * keyboard.c (apply_modifiers_uncached): Prefer local array to
1611 alloca of a constant.
1612
6dd5a677
EZ
16132012-07-05 Eli Zaretskii <eliz@gnu.org>
1614
1615 * xdisp.c (display_line): Fix horizontal pixel coordinates when
1616 hscroll is larger than the line width. Fixes long and futile
1617 looping inside extend_face_to_end_of_line (on a TTY) producing
1618 glyphs that are not needed and thrown away.
1619
6b312f0f
DA
16202012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1621
1622 * marker.c (set_marker_restricted_both): Simplify by using
1623 clip_to_bounds.
1624
f520ef9b
PE
16252012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * editfns.c (region_limit): Simplify by using clip_to_bounds.
1628
383b7c95
JD
16292012-07-05 Jan Djärv <jan.h.d@swipnet.se>
1630
1631 * gtkutil.c (gtk_scrollbar_new, gtk_box_new): Define when HAVE_GTK3 is
1632 not defined (Bug#11768).
1633 (xg_create_frame_widgets): Use gtk_plug_new_for_display (Bug#11768).
1634 (xg_create_frame_widgets, create_dialog, xg_get_file_with_chooser)
1635 (make_widget_for_menu_item, xg_make_tool_item): Use gtk_box_new
1636 followed by gtk_box_set_homogeneous (Bug#11768).
1637 (xg_update_menu_item): Use GTK_IS_BOX (Bug#11768).
090bd7cb
JB
1638 (update_theme_scrollbar_width, xg_create_scroll_bar):
1639 Use gtk_scrollbar_new (Bug#11768).
383b7c95
JD
1640 (xg_event_is_for_scrollbar): Use Gdk Device functions for HAVE_GTK3.
1641 (is_box_type): New function (Bug#11768).
1642 (xg_tool_item_stale_p): Call is_box_type.
5293d758 1643 (xg_initialize): Get settings by calling gtk_settings_get_for_screen
383b7c95
JD
1644 with default display (Bug#11768).
1645
d6e7bf45
EZ
16462012-07-05 Eli Zaretskii <eliz@gnu.org>
1647
1648 * xdisp.c (window_hscroll_limited): New function.
1649 (pos_visible_p, init_iterator): Use it to avoid overflow of pixel
1650 coordinates when window's hscroll is set to insanely large
1651 values. (Bug#11857)
1652
431391ec
JB
16532012-07-05 Juanma Barranquero <lekktu@gmail.com>
1654
1655 * makefile.w32-in ($(BLD)/dired.$(O), $(BLD)/fileio.$(O)): Fix typo.
1656 ($(BLD)/terminal.$(O), $(BLD)/syntax.$(O)): Update dependencies.
1657
23f86fce
DA
16582012-07-05 Dmitry Antipov <dmantipov@yandex.ru>
1659
1660 Cleanup xmalloc.
1661 * lisp.h (xzalloc): New prototype. Omit needless casts.
1662 * alloc.c (xzalloc): New function. Omit needless casts.
1663 * charset.c: Omit needless casts. Convert all calls to
1664 xmalloc with following memset to xzalloc.
1665 * dispnew.c: Likewise.
1666 * fringe.c: Likewise.
1667 * image.c: Likewise.
1668 * sound.c: Likewise.
1669 * term.c: Likewise.
1670 * w32fns.c: Likewise.
1671 * w32font.c: Likewise.
1672 * w32term.c: Likewise.
1673 * xfaces.c: Likewise.
1674 * xfns.c: Likewise.
1675 * xterm.c: Likewise.
1676 * atimer.c: Omit needless casts.
1677 * buffer.c: Likewise.
1678 * callproc.c: Likewise.
1679 * ccl.c: Likewise.
1680 * coding.c: Likewise.
1681 * composite.c: Likewise.
1682 * doc.c: Likewise.
1683 * doprnt.c: Likewise.
1684 * editfns.c: Likewise.
1685 * emacs.c: Likewise.
1686 * eval.c: Likewise.
1687 * filelock.c: Likewise.
1688 * fns.c: Likewise.
1689 * gtkutil.c: Likewise.
1690 * keyboard.c: Likewise.
1691 * lisp.h: Likewise.
1692 * lread.c: Likewise.
1693 * minibuf.c: Likewise.
1694 * msdos.c: Likewise.
1695 * print.c: Likewise.
1696 * process.c: Likewise.
1697 * region-cache.c: Likewise.
1698 * search.c: Likewise.
1699 * sysdep.c: Likewise.
1700 * termcap.c: Likewise.
1701 * terminal.c: Likewise.
1702 * tparam.c: Likewise.
1703 * w16select.c: Likewise.
1704 * w32.c: Likewise.
1705 * w32reg.c: Likewise.
1706 * w32select.c: Likewise.
1707 * w32uniscribe.c: Likewise.
1708 * widget.c: Likewise.
1709 * xdisp.c: Likewise.
1710 * xmenu.c: Likewise.
1711 * xrdb.c: Likewise.
1712 * xselect.c: Likewise.
1713
0497dc44
PE
17142012-07-05 Paul Eggert <eggert@cs.ucla.edu>
1715
1716 * fileio.c (time_error_value): Check the right error number.
1717 Problem reported by Troels Nielsen in
1718 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00095.html>.
1719
356e7178
PE
17202012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1721
4e71fd89
PE
1722 * window.c (set_window_hscroll): Revert the 100000 hscroll limit.
1723 This should be fixed in a better way; see Eli Zaretskii in
1724 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00088.html>.
1725 (HSCROLL_MAX): Remove; this is now internal to set_window_hscroll.
1726
f0941253
PE
1727 * fileio.c (time_error_value): Rename from special_mtime.
1728 The old name's problems were noted by Eli Zaretskii in
1729 <http://lists.gnu.org/archive/html/emacs-devel/2012-07/msg00087.html>.
1730
065c9eb4
PE
1731 * emacs.c (gdb_pvec_type): Change it back to enum pvec_type.
1732 This variable's comment says Emacs needs at least one GDB-visible
1733 symbol of type enum pvec_type, to work around GDB problems.
1734 The symbol's value doesn't matter.
1735
356e7178
PE
1736 * alloc.c (PSEUDOVECTOR_NBYTES): Remove stray ';'
1737 that causes compilation to fail on pre-C99 compilers.
1738
ed9265fc 17392012-07-04 Juanma Barranquero <lekktu@gmail.com>
95f61aa2
JB
1740
1741 * s/ms-w32.h (LISP_FLOAT_TYPE, HAVE_MEMCMP, HAVE_MEMCPY)
1742 (HAVE_MEMMOVE, HAVE_MEMSET): Don't set, obsolete.
1743
3884d954
DA
17442012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1745
d209e2fb 1746 * buffer.c (init_buffer_once): Fix initialization of
3884d954
DA
1747 headers for buffer_defaults and buffer_local_symbols.
1748 Reported by Juanma Barranquero <lekktu@gmail.com>.
1749
ee28be33
SM
17502012-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
1751
1752 Turn VECTOR_FREE_LIST_FLAG into PVEC_FREE.
1753 * lisp.h (enum pvec_type): Use fewer bits.
1754 (PSEUDOVECTOR_SIZE_BITS): New constant.
1755 (PSEUDOVECTOR_SIZE_MASK, PVEC_TYPE_MASK): Use it.
1756 (XSETPVECTYPESIZE, XSETTYPED_PSEUDOVECTOR, DEFUN): Adapt code to
1757 change in pvec_type.
1758 (PSEUDOVECTOR_TYPEP): New macro.
1759 (TYPED_PSEUDOVECTORP): Use it.
1760 * fns.c (internal_equal): Adapt code to extract pvectype.
1761 * emacs.c (gdb_pvec_type): Update type.
1762 * alloc.c (PSEUDOVECTOR_NBYTES): New macro.
1763 (VECTOR_FREE_LIST_SIZE_MASK): Remove (=> PSEUDOVECTOR_SIZE_MASK).
1764 (VECTOR_FREE_LIST_FLAG): Remove (=> PVEC_FREE).
1765 (SETUP_ON_FREE_LIST): Use XSETPVECTYPESIZE.
1766 (sweep_vectors): Use it. Use local var `total_bytes' instead of
1767 abusing vector->header.next.nbytes.
1768 (live_vector_p): Use PVEC_TYPE.
1769 (mark_object): Adapt code to extract pvectype. Use switch.
1770
c7f2cd7f
PE
17712012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * doprnt.c (doprnt): Don't assume string length fits in 'int'.
1774 Tighten new eassert a bit.
1775
8ce70ed2
DA
17762012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1777
1778 Fix compilation with --enable-gcc-warnings and -O1
1779 optimization level.
1780 * doprnt.c (doprnt): Change type of tem to int, initialize
1781 to avoid compiler warning. Add eassert.
1782 * search.c (simple_search): Initialize match_byte to avoid
1783 compiler warning. Add eassert.
1784
dea7f1e5
PE
17852012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1786
24a212eb
PE
1787 Avoid weird behavior with large horizontal scrolls.
1788 Without this change, for example, large hscroll values would
1789 mess up Emacs's display on Fedora 15 x86, presumably due to
1790 overflows in int calculations in the display code.
1791 Also, if buffers had long lines, Emacs would freeze.
1792 * window.c (HSCROLL_MAX): Reduce to 100000, and make it visible to GDB.
1793 (set_window_hscroll): New function, containing the old guts of
1794 Fset_window_hscroll. Return the clipped value.
1795 (Fset_window_hscroll, Fscroll_left, Fscroll_right): Use it.
1796 This avoids the need to check against PTRDIFF_MAX.
1797
dea7f1e5
PE
1798 * buffer.c (Fgenerate_new_buffer_name): Fix sprintf format mismatch.
1799
76046526
DA
18002012-07-04 Dmitry Antipov <dmantipov@yandex.ru>
1801
1802 * buffer.c (Fgenerate_new_buffer_name): Fix type mismatch.
1803
39adff0d
PE
18042012-07-04 Paul Eggert <eggert@cs.ucla.edu>
1805
63807d47
PE
1806 * regex.c: Suppress GCC warning on RHEL 6. (Bug#11207)
1807 Conditionalize the pragmas on GCC 4.5 or later, not GCC 4.3 or later,
1808 since GCC 4.4.6 issues a bogus warning for them.
1809
39adff0d
PE
1810 Fix bugs in file timestamp newness comparisons.
1811 * fileio.c (Ffile_newer_than_file_p):
1812 * lread.c (Fload): Use full timestamp resolution of files,
1813 not just the 1-second resolution, so that files that are only
1814 slightly newer still count as newer.
1815 * fileio.c (Ffile_newer_than_file_p): Don't assume file
1816 timestamps fit in 'int'; this fixes a Y2038 bug on most hosts.
1817
dbeed9a6
PE
18182012-07-03 Paul Eggert <eggert@cs.ucla.edu>
1819
1820 * fileio.c: Improve handling of file time marker. (Bug#11852)
1821 (special_mtime): New function.
1822 (Finsert_file_contents, Fverify_visited_file_modtime):
1823 Use it to set special mtime values consistently.
1824
636334d6
AS
18252012-07-03 Andreas Schwab <schwab@linux-m68k.org>
1826
1827 * fileio.c (Finsert_file_contents): Properly handle st_mtime
1828 marker for non-existing file. (Bug#11852)
1829
e2017fe2
GM
18302012-07-03 Glenn Morris <rgm@gnu.org>
1831
1832 * lisp.h (Fread_file_name): Restore EXFUN (it's not a normal DEFUN
1833 and did not make it into globals.h).
1834
404dbd37
TT
18352012-07-03 Tom Tromey <tromey@redhat.com>
1836
1837 * window.c (Fset_window_margins, Fset_window_fringes)
1838 (Fset_window_scroll_bars, Fset_window_vscroll): No longer static.
1839 * textprop.c (Fprevious_property_change): No longer static.
1840 * syntax.c (Fsyntax_table_p): No longer static.
1841 * process.c (Fget_process, Fprocess_datagram_address): No longer
1842 static.
1843 * keymap.c (Flookup_key, Fcopy_keymap): No longer static.
1844 * keyboard.c (Fcommand_execute): No longer static.
1845 Remove EXFUN.
1846 * insdel.c (Fcombine_after_change_execute): No longer static.
1847 * image.c (Finit_image_library): No longer static.
1848 * fileio.c (Fmake_symbolic_link): No longer static.
1849 * eval.c (Ffetch_bytecode): No longer static.
1850 * editfns.c (Fuser_full_name): No longer static.
d209e2fb
JB
1851 * doc.c (Fdocumentation_property, Fsnarf_documentation):
1852 No longer static.
404dbd37
TT
1853 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): No longer
1854 static.
1855 * dired.c (Ffile_attributes): No longer static.
1856 * composite.c (Fcomposition_get_gstring): No longer static.
1857 * callproc.c (Fgetenv_internal): No longer static.
1858
1859 * ccl.h: Remove EXFUNs.
1860 * buffer.h: Remove EXFUNs.
1861 * dispextern.h: Remove EXFUNs.
1862 * intervals.h: Remove EXFUNs.
1863 * fontset.h: Remove EXFUN.
1864 * font.h: Remove EXFUNs.
1865 * dosfns.c (system_process_attributes): Remove EXFUN.
1866 * keymap.h: Remove EXFUNs.
1867 * lisp.h: Remove EXFUNs.
1868 * w32term.h: Remove EXFUNs.
1869 * window.h: Remove EXFUNs.
1870 * xsettings.h: Remove EXFUN.
1871 * xterm.h: Remove EXFUN.
1872
8e4fd1e1
GM
18732012-07-03 Glenn Morris <rgm@gnu.org>
1874
1875 * lisp.h (Frandom): Make it visible to C.
1876 * buffer.c (Fgenerate_new_buffer_name): Speed up finding a new
1877 buffer for invisible buffers. (Bug#1229)
1878
ca95b3eb
DA
18792012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1880
1881 Fix block vector allocation code to allow VECTOR_BLOCK_SIZE
1882 values which aren't power of 2.
1883 * alloc.c (VECTOR_FREE_LIST_SIZE_MASK): New macro. Verify
1884 it's value and the value of VECTOR_BLOCK_SIZE. Adjust users
1885 accordingly.
1886
7555c33f
SM
18872012-07-03 Stefan Monnier <monnier@iro.umontreal.ca>
1888
1889 * lisp.h (Lisp_Misc, Lisp_Fwd): Move around to group better.
1890
1891 * alloc.c (mark_object): Revert part of last patch to use `switch'.
1892
d12e8f5a
DA
18932012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1894
1895 * alloc.c (allocate_vector_block): Remove redundant
1896 calls to mallopt if DOUG_LEA_MALLOC is defined.
1897 (allocate_vectorlike): If DOUG_LEA_MALLOC is defined,
1898 avoid calls to mallopt if zero_vector is returned.
1899
296094c3
DA
19002012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1901
1902 * alloc.c (check_string_bytes): If GC_CHECK_STRING_BYTES
1903 is enabled, avoid dereferencing NULL current_sblock if
1904 running undumped.
1905
36429c89
DA
19062012-07-03 Dmitry Antipov <dmantipov@yandex.ru>
1907
1908 Cleanup basic buffer management.
1909 * buffer.h (struct buffer): Change layout to use generic vector
1910 marking code. Fix some comments. Change type of 'clip_changed'
1911 to bitfield. Remove unused #ifndef old.
1912 (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER): Remove.
1913 (GET_OVERLAYS_AT): Fix indentation.
1914 (for_each_per_buffer_object_at): New macro.
1915 * buffer.c (clone_per_buffer_values, reset_buffer_local_variables)
1916 (Fbuffer_local_variables): Use it.
1917 (init_buffer_once, syms_of_buffer): Remove unused #ifndef old.
1918 * alloc.c (allocate_buffer): Adjust to match new layout of
1919 struct buffer. Fix comment.
1920 (mark_overlay): New function.
1921 (mark_buffer): Use it. Use mark_vectorlike to mark normal
1922 Lisp area of struct buffer.
1923 (mark_object): Use it. Adjust marking of misc objects
1924 and related comments.
1925
3b3e4cac
PE
19262012-07-02 Paul Eggert <eggert@cs.ucla.edu>
1927
1928 * alloc.c (mark_object): Remove "#ifdef GC_CHECK_MARKED_OBJECTS"
1929 wrapper that is not needed because the wrapped code is a no-op (zero
1930 machine instructions) when GC_CHECK_MARKED_OBJECTS is not defined.
1931 This avoids a -Wunused-macros diagnostic with GCC 4.7.1 x86-64.
1932
cf5c0175
DA
19332012-07-02 Dmitry Antipov <dmantipov@yandex.ru>
1934
1935 * alloc.c (mark_buffer): Simplify. Remove prototype.
1936 (mark_object): Add comment. Reorganize marking of vector-like
faf611c7 1937 objects. Use CHECK_LIVE for all vector-like objects except buffers
cf5c0175
DA
1938 and subroutines when GC_CHECK_MARKED_OBJECTS is defined. Avoid
1939 redundant calls to mark_vectorlike for bool vectors.
1940
ca26824c
GM
19412012-06-30 Glenn Morris <rgm@gnu.org>
1942
2e4c5312
GM
1943 * nsterm.m (ns_init_paths): Ignore site-lisp if --no-site-lisp.
1944
ca26824c
GM
1945 * epaths.in (PATH_SITELOADSEARCH): New.
1946 * lread.c (init_lread): Use PATH_SITELOADSEARCH.
1947 This is rather than relying on --enable-locallisppath elements
1948 having "site-lisp" in their names. (Bug#10208#25, 11658)
1949
0d23c240
EZ
19502012-06-30 Eli Zaretskii <eliz@gnu.org>
1951
c9240d7a
EZ
1952 * w32proc.c (sys_select): Accept and ignore one more argument.
1953
1954 * w32.c (emacs_gnutls_pull): Call select with one more argument.
1955
0d23c240 1956 * sysselect.h [DOS_NT]: Don't include sys/select.h.
9ff8f76b 1957 (pselect) [!MS_DOS]: Redirect to sys_select.
0d23c240
EZ
1958
1959 * sysdep.c: Don't include dos.h and dosfns.h.
1960
1961 * process.c (sys_select):
1962 * msdos.c (sys_select): Accept one more argument and ignore it.
1963
1964 * msdos.c (event_timestamp, sys_select): Use gnulib's gettime;
1965 adapt data types and code to that.
1966
1967 * dosfns.c:
1968 * msdos.c (gettime, settime): Define away the prototypes in dos.h,
1969 which clashes with the gnulib function of the same name.
1970
af5a5a98
AS
19712012-06-30 Andreas Schwab <schwab@linux-m68k.org>
1972
c5e4379c
AS
1973 * font.c (font_style_to_value, font_style_symbolic)
1974 (font_prop_validate_style): Add type checks for values in
1975 font_style_table.
1976
af5a5a98
AS
1977 * lisp.h (CHECK_RANGED_INTEGER): Make value to check the first
1978 argument.
1979 * character.c, charset.c, menu.c, process.c, window.c: Adjust all
1980 uses.
1981
8d38f461
EZ
19822012-06-29 Eli Zaretskii <eliz@gnu.org>
1983
2e5a6631
EZ
1984 * xdisp.c (try_window_id): Undo last change.
1985
8d38f461
EZ
1986 * w32.c (getwd): Adjust commentary about startup_dir.
1987 (init_environment): Always call sys_access, even in non-MSVC
1988 builds. Don't chdir to the directory of the Emacs executable.
1989 This undoes code from 1997 which was justified by the need to
1990 "avoid conflicts when removing and renaming directories". But its
1991 downside was that every relative file name was being interpreted
1992 relative to the directory of the Emacs executable, which can never
1993 be TRT. In particular, it broke sys_access when called with
1994 relative file names.
1995 (sys_access): Map GetLastError to errno.
1996
2af3565e
DA
19972012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
1998
1999 * window.h (struct window): Change type of 'fringes_outside_margins'
2000 to bitfield. Fix comment. Adjust users accordingly.
cf5c0175 2001 (struct window): Change type of 'window_end_bytepos' to ptrdiff_t.
2af3565e
DA
2002 Adjust comment.
2003 * xdisp.c (try_window_id): Change type of 'first_vpos' and 'vpos'
2004 to ptrdiff_t.
2005
c8d3a25c 20062012-06-29 Andreas Schwab <schwab@linux-m68k.org>
57570cd3 2007
c8d3a25c
GM
2008 * gnutls.c (emacs_gnutls_handshake):
2009 Add QUIT to make the loop interruptible.
57570cd3 2010
c8d3a25c 20112012-06-29 Glenn Morris <rgm@gnu.org>
d01fd55f 2012
c8d3a25c
GM
2013 * charset.c (init_charset): Make lack of etc/charsets fatal.
2014
3e984ee8
DA
20152012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2016
2017 * editfns.c (region_limit): Fix type mismatch.
2018
ef884f23
DA
20192012-06-29 Dmitry Antipov <dmantipov@yandex.ru>
2020
2021 * nsfns.m: Fix GLYPH_DEBUG usage assuming that it may be
2022 undefined. Convert from xassert to eassert.
2023 * nsmenu.m: Convert from xassert to eassert.
2024 * nsterm.m: Likewise.
2025
7d7e0027
SM
20262012-06-28 Stefan Monnier <monnier@iro.umontreal.ca>
2027
2028 * editfns.c (region_limit): Clip to narrowing (bug#11770).
2029
aa754e6a
PE
20302012-06-28 Paul Eggert <eggert@cs.ucla.edu>
2031
2032 Avoid integer overflow on scroll-left and scroll-right.
2033 * window.c (HSCROLL_MAX): New macro.
2034 (Fscroll_left, Fscroll_right): Avoid undefined behavior on integer
2035 overflow when requested scroll falls outside ptrdiff_t range.
2036
80b00b08
DA
20372012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2038
2039 * window.h (struct window): Change type of 'hscroll',
2040 'min_hscroll' and 'last_point' from Lisp_Object to ptrdiff_t,
2041 'last_modified' and 'last_overlay_modified' to EMACS_INT.
2042 Adjust users accordingly.
2043 * xdisp.c (try_cursor_movement): Replace type check with eassert.
2044 * window.c (Fscroll_left, Fscroll_right): Change type of 'hscroll'
2045 from EMACS_INT to ptrdiff_t.
2046 (make_window): Omit redundant initialization.
2047
62b2bcf6
JB
20482012-06-28 Juanma Barranquero <lekktu@gmail.com>
2049
2050 * makefile.w32-in ($(BLD)/regex.$(O)): Update dependencies.
2051
45942c7d
DA
20522012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2053
2054 * window.h (struct window): Change type of 'use_time' and
2055 'sequence_number' from Lisp_Object to int.
2056 * frame.c (make_frame): Adjust users accordingly.
2057 * print.c (print_object): Likewise.
2058 * window.c (select_window, Fwindow_use_time, make_parent_window)
2059 (make_window): Likewise.
2060
e509cfa6
DA
20612012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2062
2063 * dispextern.h (GLYPH_DEBUG): Now defined in config.h if
2064 enabled with --enable-checking=[all,glyphs] configure option.
2065 Fix GLYPH_DEBUG usage assuming that it may be undefined,
2066 adjust comments accordingly.
2067 * dispnew.c: Fix GLYPH_DEBUG usage assuming that it may be
2068 undefined, adjust comments accordingly.
2069 * image.c: Likewise.
2070 * scroll.c: Likewise.
2071 * w32fns.c: Likewise.
2072 * w32term.c: Likewise.
2073 * xdisp.c: Likewise.
2074 * xfaces.c: Likewise.
2075 * xfns.c: Likewise.
2076 * xterm.c: Likewise.
2077
a54e2c05
DA
20782012-06-28 Dmitry Antipov <dmantipov@yandex.ru>
2079
2080 Generalize run-time debugging checks.
2081 * dispextern.h (XASSERTS): Remove.
2082 * fontset.c (xassert): Remove.
2083 Convert from xassert to eassert.
2084 * alloc.c: Convert from xassert to eassert.
2085 * bidi.c: Likewise.
2086 * dispnew.c: Likewise.
2087 * fns.c: Likewise.
2088 * fringe.c: Likewise.
2089 * ftfont.c: Likewise.
2090 * gtkutil.c: Likewise.
2091 * image.c: Likewise.
2092 * keyboard.c: Likewise.
2093 * menu.c: Likewise.
2094 * process.c: Likewise.
2095 * scroll.c: Likewise.
2096 * sound.c: Likewise.
2097 * term.c: Likewise.
2098 * w32console.c: Likewise.
2099 * w32fns.c: Likewise.
2100 * w32term.c: Likewise.
2101 * window.c: Likewise.
2102 * xdisp.c: Likewise.
2103 * xfaces.c: Likewise.
2104 * xfns.c: Likewise.
2105 * xselect.c: Likewise.
2106 * xterm.c: Likewise.
2107
1ec4b7b2
SM
21082012-06-27 Stefan Monnier <monnier@iro.umontreal.ca>
2109
2110 * fns.c (maybe_resize_hash_table): Output message when growing the
2111 purify-hashtable.
2112
2014308a
DA
21132012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2114
2115 * alloc.c (allocate_string_data): Remove dead code.
2116 * xsettings.c (XSETTINGS_FONT_NAME): Move under HAVE_XFT to
2117 avoid GCC warning about unused macro.
2118
246155eb
DA
21192012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2120
2121 * alloc.c (allocate_string): Omit intervals initialization.
2122 * alloc.c (make_uninit_multibyte_string): Initialize intervals
2123 as in make_pure_string and make_pure_c_string.
2124
43184b7b
DA
21252012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2126
d209e2fb 2127 * alloc.c (allocate_string): Fix last change.
43184b7b 2128
3fe6dd74
DA
21292012-06-27 Dmitry Antipov <dmantipov@yandex.ru>
2130
d209e2fb 2131 * alloc.c (allocate_string): Remove two redundant calls
3fe6dd74
DA
2132 to memset, add explicit initialization where appropriate.
2133
1ba6038a
GM
21342012-06-27 Glenn Morris <rgm@gnu.org>
2135
2136 * lisp.mk (lisp): Remove paths.elc.
2137
c89926a5
CY
21382012-06-27 Chong Yidong <cyd@gnu.org>
2139
2140 * doc.c (Fsubstitute_command_keys): Fix punctuation.
2141
ed6b3510
JW
21422012-06-26 John Wiegley <johnw@newartisans.com>
2143
1ec4b7b2 2144 * unexmacosx.c (copy_data_segment): Add two section names used
157e99e4
JW
2145 on Mac OS X Lion: __mod_init_func and __mod_term_func.
2146
ed6b3510
JW
2147 * alloc.c (mark_memory): Do not check with -faddress-sanitizer
2148 when building with Clang.
2149
8edd4a2b
SM
21502012-06-26 Stefan Monnier <monnier@iro.umontreal.ca>
2151
2152 * eval.c (Fapply): Allow calling it with a single argument.
2153
f6f62d1b
EZ
21542012-06-26 Eli Zaretskii <eliz@gnu.org>
2155
2156 * s/ms-w32.h (strcasecmp, strncasecmp) [_MSC_VER]: Redirect to
2157 _stricmp and _strnicmp.
2158 (HAVE_STRCASECMP, HAVE_STRNCASECMP): Define to 1.
2159
62efea5e
DA
21602012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2161
2162 * alloc.c (allocate_window): Zero out non-Lisp part of newly
2163 allocated window.
2164 (allocate_process): Likewise for new process.
8edd4a2b 2165 (allocate_terminal): Change to use offsetof.
62efea5e
DA
2166 (allocate_frame): Likewise.
2167 * frame.c (make_frame): Omit redundant initialization.
2168 * window.c (make_parent_window): Use memset.
2169 (make_window): Omit redundant initialization.
2170 * process.c (make_process): Omit redundant initialization.
2171 * terminal.c (create_terminal): Likewise.
2172
42997f4d
DA
21732012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2174
2175 * term.c (delete_tty): Remove redundant call to memset.
2176
1130ecfc
DA
21772012-06-26 Dmitry Antipov <dmantipov@yandex.ru>
2178
2179 * alloc.c: Remove build_string.
2180 * lisp.h: Define build_string as static inline. This provides
2181 a better opportunity to optimize away calls to strlen when the
2182 function is called with compile-time constant argument.
2183 * image.c (imagemagick_error): Convert to build_string.
2184 * w32proc.c (sys_spawnve): Likewise.
2185 * xterm.c (x_term_init): Likewise.
2186
cf38a720
PE
21872012-06-26 Paul Eggert <eggert@cs.ucla.edu>
2188
99027bdd
PE
2189 Use sprintf return value instead of invoking strlen on result.
2190 In the old days this wasn't portable, since some sprintf
2191 implementations returned char *. But they died out years ago and
2192 Emacs already assumes sprintf returns int.
2193 Similarly for float_to_string.
2194 This patch speeds up (number-to-string 1000) by 3% on Fedora 15 x86-64.
2195 * ccl.c (ccl_driver):
2196 * character.c (string_escape_byte8):
2197 * data.c (Fnumber_to_string):
2198 * doprnt.c (doprnt):
2199 * print.c (print_object):
2200 * xdisp.c (message_dolog):
2201 * xfns.c (syms_of_xfns):
2202 Use sprintf or float_to_string result to avoid need to call strlen.
2203 * data.c (Fnumber_to_string):
2204 Use make_unibyte_string, since the string must be ASCII.
2205 * lisp.h, print.c (float_to_string): Now returns int length.
2206 * term.c (produce_glyphless_glyph):
2207 Use sprintf result rather than recomputing it.
2208
cf38a720
PE
2209 Clean out last vestiges of the old HAVE_CONFIG_H stuff.
2210 * Makefile.in (ALL_CFLAGS):
2211 * makefile.w32-in (LOCAL_FLAGS): Remove -DHAVE_CONFIG_H.
2212 * gmalloc.c, regex.c: Include <config.h> unconditionally.
2213
3511c784
DA
22142012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2215
0a08eb21 2216 * dispextern.h (xstrcasecmp): Define to library function
3511c784
DA
2217 strcasecmp if available.
2218 * xfaces.c: Do not use xstrcasecmp if strcasecmp is available.
2219
fb7da12e
AS
22202012-06-25 Andreas Schwab <schwab@linux-m68k.org>
2221
2222 * keyboard.c (menu_bar_items, menu_bar_item, read_key_sequence):
2223 Avoid comma operator.
2224 * menu.c (push_submenu_start, push_submenu_end)
2225 (push_left_right_boundary, push_menu_pane): Likewise.
2226 * msdos.c (dos_rawgetc): Likewise.
2227
afa2ffd8
DA
22282012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2229
2230 * xfns.c (xic_create_fontsetname): Remove redundant calls
2231 to memset.
2232
b3b4476b
PE
22332012-06-25 Paul Eggert <eggert@cs.ucla.edu>
2234
4495ff38
PE
2235 * gtkutil.c (get_utf8_string): Remove redundant assignment.
2236 sprintf already null-terminates its output.
2237
b3b4476b
PE
2238 * xfns.c (x_window): Remove redundant cast.
2239
b00876c9
DA
22402012-06-25 Dmitry Antipov <dmantipov@yandex.ru>
2241
2242 * xmenu.c (xmenu_show, xdialog_show): Explicit cast from
2243 `const char *' to `char *' to avoid compiler warning.
2244
d188e26b
PE
22452012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2246
885d1d74
PE
2247 * xterm.c (x_term_init): Build proper-sized _XSETTINGS_Snnn string
2248 instead of truncating it to 63 (admittedly a generous limit).
2249
d188e26b
PE
2250 * process.c: Fix spelling and caps in comments.
2251
e2f560b1
DN
22522012-06-24 Dan Nicolaescu <dann@ics.uci.edu>
2253
e86db54b 2254 * emacs.c (setpgrp): Remove definition, unused.
e2f560b1
DN
2255 * sysdep.c (setpgrp): Remove definition, not used in this file.
2256
7583a3a1
JB
22572012-06-24 Juanma Barranquero <lekktu@gmail.com>
2258
2259 * makefile.w32-in: Update dependencies.
2260
696056c2
EZ
22612012-06-24 Eli Zaretskii <eliz@gnu.org>
2262
2263 * makefile.w32-in (TIMESPEC_H): Remove nt/inc/sys/time.h.
2264 (SYSTIME_H): Add nt/inc/sys/time.h.
2265
2266 * systime.h [WINDOWSNT]: Include sys/time.h.
2267
2268 * s/ms-w32.h (struct timespec): Definition moved from
2269 nt/inc/sys/time.h. Suggested by Paul Eggert <eggert@cs.ucla.edu>.
2270
845ca893
PE
22712012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 Switch from NO_RETURN to C11's _Noreturn (Bug#11750).
2274 * buffer.h (buffer_slot_type_mismatch):
2275 * data.c (arith_error) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2276 * eval.c (unwind_to_catch):
2277 * image.c (my_png_error, my_error_exit):
2278 * keyboard.c (quit_throw_to_read_char, user_error)
2279 (Fexit_recursive_edit, Fabort_recursive_edit):
2280 * lisp.h (die, args_out_of_range, args_out_of_range_3)
2281 (wrong_type_argument, buffer_overflow, __executable_start)
2282 (memory_full, buffer_memory_full, string_overflow, Fthrow)
2283 (xsignal, xsignal0, xsignal1, xsignal2, xsignal3, signal_error)
2284 (error, verror, nsberror, report_file_error, Ftop_level, Fkill_emacs)
2285 (fatal):
2286 (child_setup) [!DOS_NT]:
2287 * lread.c (end_of_file_error, invalid_syntax):
2288 * process.c (send_process_trap) [!FORWARD_SIGNAL_TO_MAIN_THREAD]:
2289 * puresize.h (pure_write_error):
2290 * search.c (matcher_overflow):
2291 * sound.c (sound_perror, alsa_sound_perror):
2292 * sysdep.c, syssignal.h (croak):
2293 * term.c (maybe_fatal, vfatal):
2294 * textprop.c (text_read_only):
2295 * undo.c (user_error):
2296 * unexmacosx.c (unexec_error):
2297 * xterm.c (x_ins_del_lines, x_delete_glyphs):
2298 Use _Noreturn rather than NO_RETURN.
2299 No need for separate decl merely because of _Noreturn.
2300 * sound.c (sound_warning, parse_sound):
2301 Remove unnecessary forward decls.
2302
f1dd8073
PE
23032012-06-24 Paul Eggert <eggert@cs.ucla.edu>
2304
2305 Fix bug when time_t is unsigned and as wide as intmax_t (Bug#9000).
2306 * lisp.h (WAIT_READING_MAX): New macro.
2307 * dispnew.c (Fsleep_for, sit_for):
2308 * keyboard.c (kbd_buffer_get_event):
2309 * process.c (Faccept_process_output):
2310 Use it to avoid bogus compiler warnings with obsolescent GCC versions.
2311 This improves on the previous patch, which introduced a bug
2312 when time_t is unsigned and as wide as intmax_t.
2313 See <http://bugs.gnu.org/9000#51>.
2314
b82c1755
EZ
23152012-06-23 Eli Zaretskii <eliz@gnu.org>
2316
2317 * dispnew.c (sit_for, Fsleep_for):
2318 * keyboard.c (kbd_buffer_get_event):
2319 * process.c (Faccept_process_output): Avoid compiler warnings when
2320 comparing a 32-bit time_t with a 64-bit INTMAX_MAX.
2321
ca300656
JB
23222012-06-23 Juanma Barranquero <lekktu@gmail.com>
2323
049ec95b
JB
2324 * makefile.w32-in: Update dependencies.
2325
ca300656
JB
2326 * w32.c (ltime): Add return type and declare static.
2327 (w32_get_internal_run_time): Remove usused variable `time_100ns'.
2328
db7b8d06
PE
23292012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2330
2331 * sysdep.c [__FreeBSD__]: Fix more recently-introduced typos.
2332 Privately reported by Herbert J. Skuhra.
2333 (make_lisp_timeval) [__FreeBSD__]: Rename from TIMELIST.
2334 All uses changed.
2335 (system_process_attributes) [__FreeBSD__]: Invoke make_lisp_time,
2336 not make_lisp_timeval, when the argument is of type EMACS_TIME.
2337
0bd8297f
EZ
23382012-06-23 Eli Zaretskii <eliz@gnu.org>
2339
96512555
EZ
2340 * w32proc.c (Fw32_get_locale_info): Fix an off-by-one error in
2341 last argument of make_unibyte_string.
2342
0bd8297f
EZ
2343 * keyboard.c (kbd_buffer_get_event): Include the codepage and the
2344 language ID in the event parameters.
2345
2346 * w32term.c (w32_read_socket): Put the new keyboard codepage into
2347 event.code, not the obscure "character set ID".
2348
63def6b6
CY
23492012-06-23 Chong Yidong <cyd@gnu.org>
2350
2351 * xmenu.c (x_menu_wait_for_event): Adapt GTK3 to new xg_select.
2352
e8a02204
EZ
23532012-06-23 Eli Zaretskii <eliz@gnu.org>
2354
388cdec0
EZ
2355 Fix the MS-Windows build broken by 2012-06-22T21:17:42Z!eggert@cs.ucla.edu.
2356 * w32.c (fdutimens): New function.
2357
2358 * w32proc.c (sys_select): Adapt to change in the EMACS_TIME type.
2359
2360 * s/ms-w32.h (pselect): Redirect to sys_select.
2361
2362 * sysselect.h [WINDOWSNT]: Don't include sys/select.h.
2363
e8a02204
EZ
2364 * ralloc.c (r_alloc_inhibit_buffer_relocation): Fix stupid thinko
2365 in the logic of incrementing and decrementing the value of
2366 use_relocatable_buffers.
2367
d054f3fb
PE
23682012-06-23 Paul Eggert <eggert@cs.ucla.edu>
2369
2370 * sysdep.c [__FreeBSD__]: Fix recently-introduced typos.
2371 Privately reported by Herbert J. Skuhra.
2372 [__FreeBSD__]: Remove "*/" typo after "#include".
2373 (timeval_to_EMACS_TIME) [__FreeBSD__]: New static function.
2374 (TIMEVAL) [__FreeBSD__]: Now a static function rather than a macro.
2375 (TIMEVAL, system_process_attributes) [__FreeBSD__]:
2376 Don't assume EMACS_TIME and struct timeval are the same type.
2377
d35af63c
PE
23782012-06-22 Paul Eggert <eggert@cs.ucla.edu>
2379
2380 Support higher-resolution time stamps (Bug#9000).
2381 The time stamps are only nanosecond-resolution at the C level,
2382 since that's the best that any real-world system supports now.
2383 But they are picosecond-resolution at the Lisp level, as that's
2384 easy, and leaves room for future OS improvements.
2385
2386 * Makefile.in (LIB_CLOCK_GETTIME): New macro.
2387 (LIBES): Use it.
2388
2389 * alloc.c (Fgarbage_collect): Port to higher-res time stamps.
2390 Don't get current time unless it's needed.
2391
2392 * atimer.c: Include <sys/time.h> unconditionally, since gnulib
2393 now provides it if it's absent.
2394 (start_atimer): Port to higher-res time stamps.
2395 Check for time stamp overflow. Don't get current time more
2396 often than is needed.
2397
2398 * buffer.h (struct buffer): Buffer modtime now has high resolution.
2399 Include systime.h, not time.h.
2400 (NONEXISTENT_MODTIME_NSECS, UNKNOWN_MODTIME_NSECS): New macros.
2401
2402 * dired.c: Include stat-time.h.
2403 (Ffile-attributes): File times now have higher resolution.
2404
2405 * dispextern.h [HAVE_WINDOW_SYSTEM]: Include systime.h.
2406 (struct image): Timestamp now has higher resolution.
2407
2408 * dispnew.c (PERIODIC_PREEMPTION_CHECKING): Remove, as Emacs always
2409 has at least microseconds now. All uses removed.
2410 (update_frame, update_single_window, update_window, update_frame_1)
2411 (Fsleep_for, sit_for): Port to higher-resolution time stamps.
2412
2413 * editfns.c (time_overflow): Now extern.
2414 (Fcurrent_time, Fget_internal_run_time, make_time, lisp_time_argument)
2415 (float-time, Fformat_time_string, Fcurrent_time_string)
2416 (Fcurrent_time_zone): Accept and generate higher-resolution
2417 time stamps.
2418 (make_time_tail, make_lisp_time, dissassemble_lisp_time)
2419 (decode_time_components, lisp_seconds_argument): New functions.
2420 (make_time): Now static.
2421 (lisp_time_argument): Now returns EMACS_TIME. New arg ppsec.
2422 Report an error if the time is invalid, rather than having the caller
2423 do that.
2424
2425 * fileio.c: Include <stat-time.h>
2426 (Fcopy_file): Copy higher-resolution time stamps.
2427 Prefer to set the time stamp via a file descriptor if that works.
2428 (Fset_file_times, Finsert_file_contents, Fwrite_region)
2429 (Fverify_visited_file_modtime, Fclear_visited_file_modtime)
2430 (Fvisited_file_modtime, Fset_visited_file_modtime):
2431 Support higher-resolution time stamps.
2432
2433 * fns.c (Frandom): Use nanoseconds, not microseconds, for seed.
2434
2435 * gtkutil.c (xg_maybe_add_timer): Port to higher-res time stamps.
2436
2437 * image.c (prepare_image_for_display, clear_image_cache)
2438 (lookup_image): Port to higer-resolution time stamps.
2439
2440 * keyboard.c (start_polling, bind_polling_period):
2441 Check for time stamp overflow.
2442 (read_char, kbd_buffer_get_event, timer_start_idle)
2443 (timer_stop_idle, timer_resume_idle, timer_check_2, timer_check)
2444 (Fcurrent_idle_time, init_keyboard, set_waiting_for_input):
2445 Port to higher-resolution time stamps. Do not assume time_t is signed.
2446 (decode_timer): New function. Timers are now vectors of length 9,
2447 not 8, to accommodate the picosecond component.
2448 (timer_check_2): Use it.
2449
2450 * nsterm.m (select_timeout, timeval_subtract): Remove.
2451 (ns_timeout): Use Emacs's facilities for time stamp arithmetic,
2452 as they're a bit more accurate and handle overflow better.
2453 (ns_select): Change prototype to be compatible with pselect.
2454 (ns_select, ns_term_shutdown): Port to ns-resolution time stamps.
2455 * nsterm.h (ns_select): Adjust prototype.
2456
2457 * msdos.c (EMACS_TIME_ZERO_OR_NEG_P): Remove, as it assumes
2458 us-resolution time stamps.
2459 (sys_select): Use the new EMACS_TIME_SIGN macro instead.
2460
2461 * lread.c (read_filtered_event): Port to ns-resolution time stamps.
2462
2463 * lisp.h (time_overflow): New decl.
2464 (wait_reading_process_output): First arg is now intmax_t, not int,
2465 to accommodate larger waits.
2466
2467 * process.h (struct Lisp_Process.read_output_delay):
2468 Now counts nanoseconds, not microseconds.
2469 * process.c (ADAPTIVE_READ_BUFFERING): Don't worry about
2470 EMACS_HAS_USECS.
2471 (READ_OUTPUT_DELAY_INCREMENT, Faccept_process_output)
2472 (wait_reading_process_output):
2473 Port to ns-resolution time stamps.
2474 (Faccept_process_output, wait_reading_process_output):
2475 Check for time stamp overflow. Do not assume time_t is signed.
2476 (select_wrapper): Remove; we now use pselect.
2477 (Fprocess_attributes): Now generates ns-resolution time stamps.
2478
2479 * sysdep.c: Include utimens.h. Don't include utime.h
2480 or worry about struct utimbuf; gnulib does that for us now.
2481 (gettimeofday): Remove; gnulib provides a substitute.
2482 (make_timeval): New function.
2483 (set_file_times): Now sets ns-resolution time stamps.
2484 New arg FD; all uses changed.
2485 (time_from_jiffies, ltime_from_jiffies, get_up_time)
2486 (system_process_attributes):
2487 Now returns ns-resolution time stamp. All uses changed.
2488 Check for time stamp overflow.
2489
2490 * sysselect.h: Don't depend on HAVE_SYS_SELECT_H; gnulib
2491 provides a substitute now.
2492
2493 * systime.h: Include timespec.h rather than sys/time.h and time.h,
2494 since it guarantees struct timespec.
2495 (EMACS_TIME): Now struct timespec, so that we can support
2496 ns-resolution time stamps.
2497 (EMACS_TIME_RESOLUTION, LOG10_EMACS_TIME_RESOLUTION): New macros.
2498 (EMACS_HAS_USECS): Remove; Emacs always has sub-second time stamps now.
2499 (EMACS_USECS): Remove.
2500 (EMACS_SET_USECS): The underlying time stamp now has ns resolution,
2501 so multiply the arg by 1000 before storing it.
2502 (EMACS_NSECS, EMACS_SECS_ADDR, EMACS_SET_NSECS, EMACS_SET_SECS_NSECS):
2503 New macros.
2504 (EMACS_GET_TIME, EMACS_ADD_TIME, EMACS_SUB_TIME):
2505 Port to ns-resolution time stamps.
2506 (EMACS_TIME_NEG_P): Remove; replaced by....
2507 (EMACS_TIME_SIGN): New macro.
2508 (EMACS_SET_INVALID_TIME, EMACS_TIME_VALID_P)
2509 (EMACS_TIME_FROM_DOUBLE, EMACS_TIME_TO_DOUBLE): New macros.
2510 (set_file_times, make_time, lisp_time_argument): Adjust signature.
2511 (make_timeval, make_lisp_time, decode_time_components): New decls.
2512 (EMACS_TIME_CMP): Remove; no longer used. Plus, it was buggy, in
2513 that it mishandled time_t overflow. You can't compare by subtracting!
2514 (EMACS_TIME_EQ, EMACS_TIME_NE, EMACS_TIME_GT, EMACS_TIME_GE)
2515 (EMACS_TIME_LT, EMACS_TIME_LE): Rewrite in terms of timespec_cmp.
2516
2517 * term.c: Include <sys/time.h>.
2518 (timeval_to_Time): New function, for proper overflow wraparound.
2519 (term_mouse_position, term_mouse_click): Use it.
2520
2521 * undo.c (record_first_change): Support higher-resolution time stamps
2522 in the undo buffer.
2523 (Fprimitive_undo): Use them when restoring time stamps.
2524
2525 * w32.c (ltime, U64_TO_LISP_TIME, process_times, emacs_gnutls_pull)
2526 (w32_get_internal_run_time):
2527 Port to higher-resolution Emacs time stamps.
2528 (ltime): Now accepts single 64-bit integer, as that's more convenient
2529 for callers.
2530
2531 * xdisp.c (start_hourglass): Port to ns-resolution time stamps.
2532
2533 * xgselect.c, xgselect.h (xg_select): Add sigmask argument,
2534 for compatibility with pselect. Support ns-resolution time stamps.
2535
2536 * xmenu.c (x_menu_wait_for_event): Support ns-resolution time stamps.
2537
2538 * xselect.c (wait_for_property_change, x_get_foreign_selection):
2539 Check for time stamp overflow, and support ns-resolution time stamps.
2540
2541 * xterm.c: Don't include sys/time.h; gnulib does that for us now.
2542 Don't worry about whether HAVE_TIMEVAL and HAVE_SELECT are set.
2543 (timeval_subtract): Remove; no longer needed.
2544 (XTflash, XTring_bell, x_wait_for_event):
2545 Port to ns-resolution time stamps. Don't assume time_t is signed.
2546
b6a92dfe
CY
25472012-06-22 Chong Yidong <cyd@gnu.org>
2548
2549 * xdisp.c (x_consider_frame_title): Revert last change.
2550
d251c37c
EZ
25512012-06-22 Eli Zaretskii <eliz@gnu.org>
2552
2553 * alloc.c (NSTATICS): Enlarge to 0x650. Otherwise, Emacs compiled
2554 with -DENABLE_CHECKING -DXASSERTS -DGLYPH_DEBUG=1 -DBYTE_CODE_METER
2555 aborts in staticpro during startup. (Without -DBYTE_CODE_METER,
2556 staticidx goes up to 1597 out of 1600 = 0x640.)
2557
f10deafb
PE
25582012-06-20 Paul Eggert <eggert@cs.ucla.edu>
2559
2560 * fileio.c (Fdefault_file_modes): Block input while fiddling with umask.
2561 Otherwise, the umask might be mistakenly 0 while handling input signals.
2562
ec6de1e2
SM
25632012-06-19 Stefan Monnier <monnier@iro.umontreal.ca>
2564
2565 * minibuf.c (Fread_string): Bind minibuffer-completion-table.
2566
28be1ada
DA
25672012-06-19 Dmitry Antipov <dmantipov@yandex.ru>
2568
2569 * alloc.c, bytecode.c, ccl.c, coding.c, composite.c, data.c, dosfns.c:
2570 * font.c, image.c, keyboard.c, lread.c, menu.c, minibuf.c, msdos.c:
2571 * print.c, syntax.c, window.c, xmenu.c, xselect.c: Replace direct
2572 access to `contents' member of Lisp_Vector objects with AREF and ASET
2573 where appropriate.
2574
c6bf3022
CY
25752012-06-19 Chong Yidong <cyd@gnu.org>
2576
2577 * frame.c (delete_frame): When selecting a frame on a different
2578 text terminal, do not alter the terminal's top-frame.
2579
2580 * xdisp.c (format_mode_line_unwind_data): Record the target
2581 frame's selected window and its terminal's top-frame.
2582 (unwind_format_mode_line): Restore them.
2583 (x_consider_frame_title, display_mode_line, Fformat_mode_line):
2584 Callers changed.
2585 (x_consider_frame_title): Do not condition on HAVE_WINDOW_SYSTEM,
2586 since tty frames can be explicitly named.
2587 (prepare_menu_bars): Likewise.
2588
2589 * term.c (Ftty_top_frame): New function.
2590
defd4196
PE
25912012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2592
2593 Port byte-code-meter to modern targets.
2594 * bytecode.c (METER_CODE) [BYTE_CODE_METER]: Don't assume
2595 !CHECK_LISP_OBJECT_TYPE && !USE_LSB_TAG. Problem with
8b5257e1 2596 CHECK_LISP_OBJECT_TYPE reported by Dmitry Antipov in
defd4196
PE
2597 <http://lists.gnu.org/archive/html/emacs-devel/2012-06/msg00282.html>.
2598 (METER_1, METER_2): Simplify.
2599
1053a871
SM
26002012-06-18 Stefan Monnier <monnier@iro.umontreal.ca>
2601
2602 * data.c (Fdefalias): Return `symbol' (bug#11686).
2603
b7e8d081
MR
26042012-06-18 Martin Rudalics <rudalics@gmx.at>
2605
2606 * buffer.c (Fkill_buffer): Don't throw an error when the buffer
1053a871
SM
2607 gets killed during executing of this function (Bug#11665).
2608 Try to always return Qt when the buffer has been actually killed.
b7e8d081
MR
2609 (Vkill_buffer_query_functions): In doc-string say that functions
2610 run by this hook should not change the current buffer.
2611
7ea2b339
PE
26122012-06-18 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 Fix recently-introduced process.c problems found by static checking.
2615 * process.c (write_queue_push, write_queue_pop, send_process):
2616 Use ptrdiff_t, not int or EMACS_INT, for buffer lengths and offsets.
2617 (write_queue_pop): Fix pointer signedness problem.
2618 (send_process): Remove unused local.
2619
96a313a1
CY
26202012-06-17 Chong Yidong <cyd@gnu.org>
2621
2622 * xdisp.c (redisplay_internal): No need to redisplay terminal
2623 frames that are not on top.
2624
20ca2e94
TN
26252012-06-17 Troels Nielsen <bn.troels@gmail.com>
2626
2627 * process.c (make_process): Initialize write_queue.
2628 (write_queue_push, write_queue_pop): New functions.
2629 (send_process): Use them to maintain correct ordering of process
2630 writes (Bug#10815).
2631
9a900ca9
PE
26322012-06-17 Paul Eggert <eggert@cs.ucla.edu>
2633
310fbfa8
PE
2634 * lisp.h (eassert): Assume C89 or later.
2635 This removes the need for CHECK.
2636 (CHECK): Remove. Its comments about always evaluating its
2637 argument were confusing, as 'eassert' typically does not evaluate
2638 its argument.
2639
27bb1ca4
PE
2640 * coding.c (produce_chars): Use ptrdiff_t, not int.
2641
9a900ca9
PE
2642 * xterm.c (x_draw_underwave): Check for integer overflow.
2643 This pacifies gcc 4.7.0 -Wunsafe-loop-optimizations on x86-64.
2644
41b7f8bc 26452012-06-17 Jan Djärv <jan.h.d@swipnet.se>
50a93863
JD
2646
2647 * nsterm.m (x_free_frame_resources): Move xfree so freed memory isn't
2648 referenced (Bug#11583).
2649
9b0e3eba
AA
26502012-06-16 Aurelien Aptel <aurelien.aptel@gmail.com>
2651
2652 Implement wave-style variant of underlining.
2653 * dispextern.h (face_underline_type): New enum.
2654 (face): Add field for underline type.
2655 * nsterm.m (ns_draw_underwave): New function.
2656 (ns_draw_text_decoration): Use it.
2657 * w32term.c (w32_restore_glyph_string_clip, w32_draw_underwave):
2658 New functions.
2659 (x_draw_glyph_string): Use them.
2660 * xfaces.c (Qline, Qwave): New Lisp objects.
2661 (check_lface_attrs, merge_face_ref)
1053a871
SM
2662 (Finternal_set_lisp_face_attribute, realize_x_face):
2663 Handle wave-style underline face attributes.
9b0e3eba
AA
2664 * xterm.c (x_draw_underwave): New function.
2665 (x_draw_glyph_string): Use it.
2666
0fb52f11
JB
26672012-06-16 Juanma Barranquero <lekktu@gmail.com>
2668
2669 * makefile.w32-in ($(BLD)/emacs.$(O), $(BLD)/fringe.$(O))
2670 ($(BLD)/xml.$(O), $(BLD)/intervals.$(O), $(BLD)/macros.$(O))
2671 ($(BLD)/minibuf.$(O), $(BLD)/regex.$(O), $(BLD)/region-cache.$(O))
2672 ($(BLD)/textprop.$(O), $(BLD)/undo.$(O), $(BLD)/window.$(O))
2673 ($(BLD)/w32select.$(O)): Update dependencies.
2674
e5560ff7
AS
26752012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2676
2677 * buffer.h (FETCH_MULTIBYTE_CHAR): Define as inline.
2678 (BUF_FETCH_MULTIBYTE_CHAR): Likewise.
2679 * character.c (_fetch_multibyte_char_p): Remove.
2680 * alloc.c: Include "character.h" before "buffer.h".
2681 * bidi.c: Likewise.
2682 * buffer.c: Likewise.
2683 * bytecode.c: Likewise.
2684 * callint.c: Likewise.
2685 * callproc.c: Likewise.
2686 * casefiddle.c: Likewise.
2687 * casetab.c: Likewise.
2688 * category.c: Likewise.
2689 * cmds.c: Likewise.
2690 * coding.c: Likewise.
2691 * composite.c: Likewise.
2692 * dired.c: Likewise.
2693 * dispnew.c: Likewise.
2694 * doc.c: Likewise.
2695 * dosfns.c: Likewise.
2696 * editfns.c: Likewise.
2697 * emacs.c: Likewise.
2698 * fileio.c: Likewise.
2699 * filelock.c: Likewise.
2700 * font.c: Likewise.
2701 * fontset.c: Likewise.
2702 * fringe.c: Likewise.
2703 * indent.c: Likewise.
2704 * insdel.c: Likewise.
2705 * intervals.c: Likewise.
2706 * keyboard.c: Likewise.
2707 * keymap.c: Likewise.
2708 * lread.c: Likewise.
2709 * macros.c: Likewise.
2710 * marker.c: Likewise.
2711 * minibuf.c: Likewise.
2712 * nsfns.m: Likewise.
2713 * nsmenu.m: Likewise.
2714 * print.c: Likewise.
2715 * process.c: Likewise.
2716 * regex.c: Likewise.
2717 * region-cache.c: Likewise.
2718 * search.c: Likewise.
2719 * syntax.c: Likewise.
2720 * term.c: Likewise.
2721 * textprop.c: Likewise.
2722 * undo.c: Likewise.
2723 * unexsol.c: Likewise.
2724 * w16select.c: Likewise.
2725 * w32fns.c: Likewise.
2726 * w32menu.c: Likewise.
2727 * window.c: Likewise.
2728 * xdisp.c: Likewise.
2729 * xfns.c: Likewise.
2730 * xmenu.c: Likewise.
2731 * xml.c: Likewise.
2732 * xselect.c: Likewise.
2733
2f07e6af
EZ
27342012-06-16 Eli Zaretskii <eliz@gnu.org>
2735
1053a871
SM
2736 * xdisp.c (set_cursor_from_row): Don't dereference glyphs_end.
2737 If all the glyphs of the glyph row came from strings, and we have no
2f07e6af 2738 cursor positioning clues, put the cursor on the first glyph of the
1097afe4
EZ
2739 row.
2740 (handle_face_prop): Use chunk-relative overlay string index when
2741 indexing into it->string_overlays array. (Bug#11653)
946fdb73
EZ
2742 (set_cursor_from_row): Use the leftmost glyph as GLYPH_BEFORE, not
2743 the rightmost. (Bug#11720)
2f07e6af 2744
29b83cec
AS
27452012-06-16 Andreas Schwab <schwab@linux-m68k.org>
2746
2747 * category.h (CHAR_HAS_CATEGORY): Define as inline.
2748 (CATEGORY_MEMBER): Enforce 1/0 value.
2749 * category.c (_temp_category_set): Remove.
2750
4c5501e9
EZ
27512012-06-16 Eli Zaretskii <eliz@gnu.org>
2752
2753 * window.c (Fdelete_other_windows_internal)
2754 (Fdelete_window_internal): Don't access frame's mouse highlight
2755 info of the initial frame. (Bug#11677)
2756
2b570124
PE
27572012-06-14 Paul Eggert <eggert@cs.ucla.edu>
2758
e93864f9
PE
2759 * .gdbinit (xgetint): Fix recently-introduced paren typo.
2760 Assume USE_2_TAGS_FOR_INTS.
2761 (xreload): Adjust $tagmask width to match recent lisp.h change.
2762
2b570124
PE
2763 Simplify lisp.h in minor ways that should not affect code.
2764 * lisp.h (USE_2_TAGS_FOR_INTS): Remove, as it was always defined.
2765 (LISP_INT_TAG, case_Lisp_Int, LISP_STRING_TAG, LISP_INT_TAG_P)
2766 (LISP_INT1_TAG, enum Lisp_Type, XINT, XUINT, make_number):
2767 Simplify under the assumption that USE_2_TAGS_FOR_INTS is defined.
2768 (INTTYPEBITS): New macro, for clarity.
2769 (INTMASK, MOST_POSITIVE_FIXNUM): Use it.
1053a871
SM
2770 (LISP_INT1_TAG, LISP_STRING_TAG, LISP_INT_TAG_P):
2771 Simplify now that USE_LSB_TAG is always defined.
2b570124
PE
2772 (TYPEMASK, XINT) [USE_LSB_TAG]: Remove unnecessary cast.
2773 (make_number) [!USE_LSB_TAG]: Use INTMASK; that's simpler.
2774
81755f69
JB
27752012-06-13 Juanma Barranquero <lekktu@gmail.com>
2776
2777 * makefile.w32-in ($(BLD)/data.$(O)): Update dependencies.
2778
16192a57
GM
27792012-06-13 Glenn Morris <rgm@gnu.org>
2780
2781 * s/bsd-common.h (BSD4_3):
2782 * s/usg5-4-common.h (USG5_4): No longer define; unused.
2783
646b5f55
AS
27842012-06-13 Andreas Schwab <schwab@linux-m68k.org>
2785
2786 * lisp.h (Lisp_Object) [CHECK_LISP_OBJECT_TYPE]: Define as struct
2787 instead of union.
2788 (XLI, XIL): Define.
1053a871
SM
2789 (XHASH, XTYPE, XINT, XUINT, make_number, XSET, XPNTR, XUNTAG):
2790 Use them.
2791 * emacs.c (gdb_use_struct): Rename from gdb_use_union.
646b5f55 2792 * .gdbinit: Check gdb_use_struct instead of gdb_use_union.
1053a871 2793 * alloc.c (widen_to_Lisp_Object): Remove.
646b5f55
AS
2794 (mark_memory): Use XIL instead of widen_to_Lisp_Object.
2795 * frame.c (delete_frame): Remove outdated comment.
2796 * w32fns.c (Fw32_register_hot_key): Use XLI instead of checking
2797 USE_LISP_UNION_TYPE.
2798 (Fw32_unregister_hot_key): Likewise.
2799 (Fw32_toggle_lock_key): Likewise.
2800 * w32menu.c (add_menu_item): Likewise.
2801 (w32_menu_display_help): Use XIL instead of checking
2802 USE_LISP_UNION_TYPE.
2803 * w32heap.c (allocate_heap): Don't check USE_LISP_UNION_TYPE.
2804 (init_heap): Likewise.
2805 * w32term.c (w32_read_socket): Update comment.
2806
1d3823c9
GM
28072012-06-13 Glenn Morris <rgm@gnu.org>
2808
c62ff706
GM
2809 * s/usg5-4-common.h, src/s/unixware.h:
2810 Remove define/undef of HAVE_SYSV_SIGPAUSE (not used since 2010-05-04).
2811
1d3823c9
GM
2812 * s/gnu.h (POSIX_SIGNALS): Remove (not used since 2010-05-04).
2813
bfe3e0a2
PE
28142012-06-13 Paul Eggert <eggert@cs.ucla.edu>
2815
2816 USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup (Bug#11604)
2817 * alloc.c (make_number) [!defined make_number]:
2818 Remove, as lisp.h always defines this now.
2819 (mark_maybe_pointer): Simplify since USE_LSB_TAG is always defined now.
2820 (roundup_size): Verify that it is a power of 2.
2821 * data.c (Fmake_variable_buffer_local, Fmake_local_variable):
2822 * ftfont.c (ftfont_driver): Use LISP_INITIALLY_ZERO.
2823 * lisp.h (USE_LSB_TAG): Allow the builder to compile with
2824 -DUSE_LSB_TAG=0, to override the automatically-selected default.
2825 USE_LSB_TAG now is always defined to be either 0 or 1.
2826 All uses changed.
2827 (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the
2828 code works fine either way, and efficiency is not a concern here,
2829 as the union type is for debugging, not for production.
2830 (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]:
2831 Use an inline function on all platforms when using the union type,
2832 since this is simpler and 'static inline' can be used portably
2833 within Emacs now.
2834 (LISP_INITIALLY_ZERO): New macro.
2835 (XFASTINT, XSETFASTINT) [USE_LISP_UNION_TYPE]: Remove.
2836 (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize.
2837
45fa9c0f
GM
28382012-06-12 Glenn Morris <rgm@gnu.org>
2839
b4492cba
GM
2840 * s/gnu-kfreebsd.h, s/hpux11.h, s/openbsd.h, s/sol2-10.h: Remove files.
2841
2842 * s/gnu-linux.h (HAVE_PROCFS): Move to configure.
0d369729 2843
45fa9c0f
GM
2844 * s/hpux10-20.h, s/openbsd.h, s/usg5-4-common.h:
2845 Move BROKEN_SIGIO to configure.
2846
2847 * s/bsd-common.h, s/darwin.h, s/gnu-kfreebsd.h, s/hpux10-20.h:
2848 Move NO_TERMIO to configure.
2849
0e25d334
CY
28502012-06-12 Chong Yidong <cyd@gnu.org>
2851
2852 * image.c (imagemagick_load_image): Use MagickFlattenImage if
2853 MagickMergeImageLayers is undefined. Use pixel pusher loop if
2854 MagickExportImagePixels is undefined.
2855
43682bb6
PE
28562012-06-12 Paul Eggert <eggert@cs.ucla.edu>
2857
2858 * image.c (imagemagick_load_image): Remove unused label.
2859
a9be7d2b
GM
28602012-06-11 Glenn Morris <rgm@gnu.org>
2861
2862 * s/aix4-2.h, s/bsd-common.h, s/cygwin.h, s/darwin.h:
2863 * s/gnu-kfreebsd.h, s/gnu-linux.h, s/gnu.h, s/hpux10-20.h:
2864 * s/irix6-5.h, s/ms-w32.h, s/msdos.h, s/template.h:
2865 * s/usg5-4-common.h: Move SYSTEM_TYPE to configure.
2866
3017f87f
SM
28672012-06-11 Stefan Monnier <monnier@iro.umontreal.ca>
2868
2869 * alloc.c (make_byte_code): New function.
2870 (Fmake_byte_code): Use it. Don't purify here.
2871 * lread.c (read1): Use it as well to avoid extra allocation.
2872
1b9b4cf4
CY
28732012-06-11 Chong Yidong <cyd@gnu.org>
2874
2875 * image.c (imagemagick_load_image): Implement transparency.
2876
95988fcf
AS
28772012-06-10 Andreas Schwab <schwab@linux-m68k.org>
2878
2879 * regex.c (at_begline_loc_p): Also recognize `(?N:' and correctly
2880 account for preceding backslashes. (Bug#11663)
2881
cd4eb164
CY
28822012-06-09 Chong Yidong <cyd@gnu.org>
2883
2884 * term.c: Support italics in capable terminals (Bug#9652).
2885 (no_color_bit): Replace unused NC_BLINK with NC_ITALIC.
2886 (turn_on_face): Output using TS_enter_italic_mode if available.
2887 Don't handle unused blinking and alt-charset cases.
2888 (turn_off_face): Handle italic case; discard unused tty_blinking_p
2889 and tty_alt_charset_p cases.
2890 (tty_capable_p, init_tty): Support italics.
2891
2892 * termchar.h (struct tty_display_info): Add field for italics.
2893 Remove unused blink field.
2894
2895 * xfaces.c (tty_supports_face_attributes_p, realize_tty_face):
2896 Handle slant.
2897
2898 * dispextern.h: Replace unused TTY_CAP_BLINK with TTY_CAP_ITALIC.
2899 (struct face): Remove unused fields tty_dim_p, tty_blinking_p, and
2900 tty_alt_charset_p. Add tty_italic_p.
2901
ff88beb8
MA
29022012-06-09 Michael Albinus <michael.albinus@gmx.de>
2903
2904 * dbusbind.c (XD_BASIC_DBUS_TYPE): Use dbus_type_is_valid and
2905 dbus_type_is_basic if available.
2906 (xd_extract_signed, xd_extract_unsigned): Rename from
2907 extract_signed and extract_unsigned, respectively. Adapt callers.
2908
44286096
CY
29092012-06-09 Chong Yidong <cyd@gnu.org>
2910
1682701f
CY
2911 * xfaces.c (face_for_overlay_string): Handle face remapping (Bug#2066).
2912
44286096
CY
2913 * fringe.c (Fset_fringe_bitmap_face): Handle the noninteractive
2914 case (Bug#9752).
2915
d86feb17
PE
29162012-06-08 Paul Eggert <eggert@cs.ucla.edu>
2917
2918 * xdisp.c (vmessage): Treat frame message as multibyte.
2919 Without this change, (let ((§ 1)) (make-variable-buffer-local '§))
2920 would generate the diagnostic "Making \302\247 buffer-local while
2921 let-bound!".
2922
d5c20fe8
EZ
29232012-06-08 Eli Zaretskii <eliz@gnu.org>
2924
2925 * dispnew.c (showing_window_margins_p): Undo last change, which
2926 was done due to an inadvertent commit.
2927 (adjust_frame_glyphs_for_frame_redisplay): Do call
2928 showing_window_margins_p.
2929
513749ee
SM
29302012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2931
2932 * eval.c (Fmake_var_non_special): New primitive.
2933 (syms_of_eval): Defsubr it.
2934 * lread.c (syms_of_lread): Mark `values' as lexically scoped.
2935
d4a8f5c1
JB
29362012-06-08 Juanma Barranquero <lekktu@gmail.com>
2937
2938 * dispnew.c (showing_window_margins_p): Wrap in #if 0 to prevent unused
2939 function warning (the only call is inside #if 0 since 2012-06-08T08:44:45Z!eliz@gnu.org).
2940
8bbbc977
EZ
29412012-06-08 Eli Zaretskii <eliz@gnu.org>
2942
2943 * alloc.c (allocate_vectorlike): Fix last change.
2944
f3372c87
DA
29452012-06-08 Dmitry Antipov <dmantipov@yandex.ru>
2946
2947 Block-based vector allocation of small vectors.
2948 * lisp.h (struct vectorlike_header): New field `nbytes',
2949 adjust comment accordingly.
2950 * alloc.c (enum mem_type): New type `MEM_TYPE_VECTOR_BLOCK'
2951 to denote vector blocks. Adjust users (live_vector_p,
2952 mark_maybe_pointer, valid_lisp_object_p) accordingly.
2953 (COMMON_MULTIPLE): Move outside #if USE_LSB_TAG.
2954 (VECTOR_BLOCK_SIZE, vroundup, VECTOR_BLOCK_BYTES),
2955 (VBLOCK_BYTES_MIN, VBLOCK_BYTES_MAX, VECTOR_MAX_FREE_LIST_INDEX),
2956 (VECTOR_FREE_LIST_FLAG, ADVANCE, VINDEX, SETUP_ON_FREE_LIST),
2957 (VECTOR_SIZE, VECTOR_IN_BLOCK): New macros.
2958 (roundup_size): New constant.
2959 (struct vector_block): New data type.
2960 (vector_blocks, vector_free_lists, zero_vector): New variables.
513749ee 2961 (all_vectors): Rename to `large_vectors'.
f3372c87
DA
2962 (allocate_vector_from_block, init_vectors, allocate_vector_from_block)
2963 (sweep_vectors): New functions.
2964 (allocate_vectorlike): Return `zero_vector' as the only vector of
2965 0 items. Allocate new vector from block if vector size is less than
2966 or equal to VBLOCK_BYTES_MAX.
2967 (Fgarbage_collect): Move all vector sweeping code to sweep_vectors.
2968 (init_alloc_once): Add call to init_vectors.
2969
4f18a4ed
SM
29702012-06-08 Stefan Monnier <monnier@iro.umontreal.ca>
2971
2972 * eval.c (Fmacroexpand): Stop if the macro returns the same form.
2973
86f158bc
PE
29742012-06-07 Paul Eggert <eggert@cs.ucla.edu>
2975
2976 * doprnt.c (doprnt): Truncate multibyte char correctly.
2977 Without this change, doprnt (buf, 2, "%s", FORMAT_END, AP)
2978 would mishandle a string argument "Xc" if X was a multibyte
2979 character of length 2: it would truncate after X's first byte
2980 rather than including all of X.
2981
c5cfcbe0
CY
29822012-06-06 Chong Yidong <cyd@gnu.org>
2983
2984 * buffer.c (word_wrap): Doc fix.
2985
c05cf390
PE
29862012-06-04 Paul Eggert <eggert@cs.ucla.edu>
2987
2988 * xdisp.c (note_mode_line_or_margin_highlight): Pacify gcc -Wall.
2989
0c3461de
GM
29902012-06-03 Glenn Morris <rgm@gnu.org>
2991
2992 * xdisp.c (tool-bar-style): Doc fix.
2993
c71232db
UM
29942012-06-03 Ulrich Müller <ulm@gentoo.org>
2995
2996 * Makefile.in (PAXCTL): Define.
2997 (temacs$(EXEEXT)): Disable memory randomization for the temacs
2998 binary via PaX flags if the paxctl utility is available.
2999 (emacs$(EXEEXT), bootstrap-emacs$(EXEEXT)):
3000 Restore PaX flags to their default. (Bug#11398)
3001
383f7350
CY
30022012-06-03 Chong Yidong <cyd@gnu.org>
3003
3004 * xdisp.c (decode_mode_spec_coding): Display a space for a unibyte
3005 buffer (Bug#11226).
3006
5f2c76c6
CY
30072012-06-03 Chong Yidong <cyd@gnu.org>
3008
3009 * xdisp.c (calc_pixel_width_or_height): Use Fbuffer_local_value.
3010 (note_mode_line_or_margin_highlight): If there is no help echo,
3011 use mode-line-default-help-echo. Handle the case where the mouse
3012 position is past the end of the mode line string.
3013
3014 * buffer.c (buffer_local_value_1): New function, split from
3015 Fbuffer_local_value; can return Qunbound.
3016 (Fbuffer_local_value): Use it.
3017 (Vmode_line_format): Docstring tweaks.
3018
773d47f6
PE
30192012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3020
3021 * sysdep.c (system_process_attributes): Improve comment.
3022
f2d6a3df
SM
30232012-06-02 Stefan Monnier <monnier@iro.umontreal.ca>
3024
3025 * keyboard.c: Export real-this-command to Elisp.
3026 (syms_of_keyboard): Rename real_this_command to Vreal_this_command
3027 and DEFVAR it. Update all users.
3028
63810350
PE
30292012-06-02 Paul Eggert <eggert@cs.ucla.edu>
3030
7bd5c1f4
PE
3031 * minibuf.c (Fassoc_string): Remove duplicate declaration.
3032
63810350
PE
3033 * sysdep.c (system_process_attributes) [SOLARIS2 && HAVE_PROCFS]:
3034 Convert pctcpu and pctmem to Lisp float properly.
3035 Let the compiler fold better, as 100.0/0x8000 is exact.
3036
a2821611
AS
30372012-06-02 Andreas Schwab <schwab@linux-m68k.org>
3038
3039 * alloc.c (CONS_BLOCK_SIZE): Account for padding at the end of
3040 cons_block.
3041
5fceba1d
PE
30422012-06-01 Paul Eggert <eggert@cs.ucla.edu>
3043
3044 * xfns.c (x_set_tool_bar_lines) [USE_GTK]: Adjust to bitfield change.
3045
c98ff5dd
DA
30462012-06-01 Dmitry Antipov <dmantipov@yandex.ru>
3047
3048 For a 'struct window', replace some Lisp_Object fields to
3049 bitfields where appropriate, remove unused fields.
3050 * window.h (struct window): Remove unused 'last_mark_x' and
3051 'last_mark_y' fields. Rename 'mini_p' field to 'mini',
3052 change it's type from Lisp_Object to bitfield.
3053 Change type of 'force_start', 'optional_new_start',
3054 'last_had_star', 'update_mode_line' and 'start_at_line_beg'
3055 fields from Lisp_Object to bitfield. Adjust users accordingly.
3056
ca34e0be
PE
30572012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3058
3059 Pacify gcc -Wdouble-precision when using Xaw.
3060 * xterm.c (xaw_jump_callback, x_set_toolkit_scroll_bar_thumb)
3061 [HAVE_X_WINDOWS && USE_TOOLKIT_SCROLL_BARS && !USE_MOTIF && !USE_GTK]:
3062 Use 'float' consistently, rather than 'float' in most places
3063 and 'double' in a couple of places.
3064
efc00ab1 30652012-05-31 Eli Zaretskii <eliz@gnu.org>
d5fd2c54
EZ
3066
3067 * xdisp.c (handle_stop): Detect whether we have overlay strings
3068 loaded by testing it->current.overlay_string_index to be
3069 non-negative, instead of checking whether n_overlay_strings is
3070 positive. (Bug#11587)
3071
efc00ab1 30722012-05-31 Chong Yidong <cyd@gnu.org>
353c87f6
CY
3073
3074 * keymap.c (describe_map_tree): Revert 2011-07-07 change (Bug#1169).
3075
3076 * doc.c (Fsubstitute_command_keys): Doc fix.
3077
efc00ab1 30782012-05-31 Eli Zaretskii <eliz@gnu.org>
a02ae4e5
EZ
3079
3080 * search.c (search_buffer): Remove calls to
3081 r_alloc_inhibit_buffer_relocation, as it is now called by
3082 maybe_unify_char, which was the cause of relocation of buffer text
3083 in bug#11519.
3084
efc00ab1 30852012-05-31 Eli Zaretskii <eliz@gnu.org>
291d430f
EZ
3086
3087 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
3088 for the duration of call to load_charset, to avoid problems with
3089 callers of maybe_unify_char that access buffer text through C
3090 pointers.
3091
3092 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
3093 decrement the inhibition flag, instead of just setting or
3094 resetting it.
3095
ba93a187
PE
30962012-05-31 Paul Eggert <eggert@cs.ucla.edu>
3097
3098 Remove obsolete '#define static' cruft.
3099 * s/hpux10-20.h (_FILE_OFFSET_BITS): Don't #undef.
3100 This #undef was "temporary" in 2000; it is no longer needed
3101 now that '#define static' has gone away.
3102 * xfns.c, xterm.h (gray_bitmap_width, gray_bitmap_height)
3103 (gray_bitmap_bits): Remove; no longer needed.
3104 All uses replaced with definiens.
3105 * xterm.c: Include "bitmaps/gray.xbm".
3106
9e4bf381
PE
31072012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3108
3109 Clean up __executable_start, monstartup when --enable-profiling.
3110 The following changes affect the code only when profiling.
3111 * dispnew.c (__executable_start): Rename from safe_bcopy.
3112 Define only on platforms that need it.
3113 * emacs.c: Include <sys/gmon.h> when profiling.
3114 (_mcleanup): Remove decl, since <sys/gmon.h> does it now.
3115 (__executable_start): Remove decl, since lisp.h does it now.
3116 (safe_bcopy): Remove decl; no longer has that name.
3117 (main): Coalesce #if into single bit of code, for simplicity.
3118 Cast pointers to uintptr_t, since standard libraries want integers
3119 and not pointers.
3120 * lisp.h (__executable_start): New decl.
3121
32d72c2f
GM
31222012-05-31 Glenn Morris <rgm@gnu.org>
3123
3124 * image.c (Fimagemagick_types): Doc fix.
3125
baac5bc7
JM
31262012-05-30 Jim Meyering <meyering@redhat.com>
3127
3128 * callproc.c (Fcall_process_region): Include directory component
3129 in mkstemp error message (Bug#11586).
3130
72cb32cf
PE
31312012-05-30 Paul Eggert <eggert@cs.ucla.edu>
3132
3133 * alloc.c, lisp.h (make_pure_vector): Now static.
3134
61b108cc
SM
31352012-05-30 Stefan Monnier <monnier@iro.umontreal.ca>
3136
3137 * eval.c (Fdefun, Fdefmacro, Vmacro_declaration_function):
3138 Move to byte-run.el.
3139 (Fautoload): Do the hash-doc more carefully.
3140 * data.c (Fdefalias): Purify definition, except for keymaps.
3141 (Qdefun): Move from eval.c.
3142 * lisp.h (Qdefun): Remove.
3143 * lread.c (read1): Tiny simplification.
3144
471fe23d
TN
31452012-05-29 Troels Nielsen <bn.troels@gmail.com>
3146
934f3f58 3147 Do not create empty overlays with the evaporate property (Bug#9642).
471fe23d
TN
3148 * buffer.c (Fmove_overlay): Reinstate the earlier fix for
3149 Bug#9642, but explicitly check that the buffer the overlay would
3150 be moved to is live and rearrange lines to make sure that errors
3151 will not put the overlay in an inconsistent state.
3152 (Fdelete_overlay): Cosmetics.
3153
85d0efd1
EZ
31542012-05-28 Eli Zaretskii <eliz@gnu.org>
3155
3156 * w32term.c (my_bring_window_to_top): New function.
3157 (x_raise_frame): Use handle returned by DeferWindowPos, which
61b108cc
SM
3158 could be different from the original one.
3159 Call my_bring_window_to_top instead of my_set_foreground_window.
85d0efd1
EZ
3160 (Bug#11513)
3161
3162 * w32fns.c (w32_wnd_proc): Accept and process WM_EMACS_BRINGTOTOP
3163 by calling BringWindowToTop.
3164
3165 * w32term.h (WM_EMACS_BRINGTOTOP): New message.
3166 (WM_EMACS_END): Increase by one.
3167
da92a98c
PE
31682012-05-28 Paul Eggert <eggert@cs.ucla.edu>
3169
3170 * bidi.c (bidi_mirror_char): Put eassert before conversion to int.
3171 This avoids undefined behavior that might cause the eassert
3172 to not catch an out-of-range value.
3173
74d1f848
JB
31742012-05-28 Juanma Barranquero <lekktu@gmail.com>
3175
3176 * makefile.w32-in ($(BLD)/w32inevt.$(O), $(BLD)/w32console.$(O)):
3177 Update dependencies.
3178
9e1a06fc
EZ
31792012-05-27 Eli Zaretskii <eliz@gnu.org>
3180
3181 * bidi.c (bidi_mirror_char): Fix last change.
3182
f3dd7312
AS
31832012-05-27 Andreas Schwab <schwab@linux-m68k.org>
3184
3185 * unexmacosx.c (copy_data_segment): Truncate after 16 characters
3186 when referring to sectname field in printf format.
3187
81899c91
PE
31882012-05-27 Paul Eggert <eggert@cs.ucla.edu>
3189
57b81a9f
PE
3190 * lisp.h [REL_ALLOC]: Omit duplicate prototypes.
3191 Only r_alloc_inhibit_buffer_relocation needed to be added;
3192 the others were already declared.
3193
81899c91
PE
3194 * bidi.c (bidi_mirror_char): Don't possibly truncate the integer
3195 before checking whether it's out of range. Put the check inside
3196 eassert. See
3197 <http://lists.gnu.org/archive/html/emacs-devel/2012-05/msg00485.html>.
3198
33017faf 31992012-05-27 Ken Brown <kbrown@cornell.edu>
2f9b9adb
KB
3200
3201 * callproc.c (Fcall_process): Restore a line that was accidentally
3202 commented out in the 2011-02-13 change (bug#11547).
3203
33017faf 32042012-05-27 Eli Zaretskii <eliz@gnu.org>
52c55cc7
EZ
3205
3206 * lisp.h [REL_ALLOC]: Add prototypes for external functions
3207 defined on ralloc.c.
3208
3209 * buffer.c [REL_ALLOC]: Remove prototypes of
3210 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
3211 they are now on lisp.h.
3212
3213 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
3214
3215 * search.c (search_buffer): Use it to inhibit relocation of buffer
3216 text while re_search_2 is doing its job, because re_search_2 is
3217 passed C pointers to buffer text. (Bug#11519)
3218
23415acf
EZ
3219 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
3220 Update value to 24.
3221
44e27368
EZ
3222 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
3223 state after an additional call to move_it_in_display_line_to, keep
3224 the values of it->max_ascent and it->max_descent found for the
3225 entire line.
3226 (pos_visible_p): Revert the comparison against bottom_y to what it
3227 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
3228 (Bug#11464)
3229
c1892f11
PE
32302012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3231
3232 Fix coding-related core dumps with gcc -ftrapv.
3233 The code was computing A - B, where A and B are pointers, and B is
3234 random garbage. This can lead to core dumps on platforms that
3235 have special pointer registers, and it also leads to core dumps on
3236 x86-64 when compiled with gcc -ftrapv. The fix is to compute
3237 A - B only when B is initialized properly.
3238 * coding.c (coding_set_source, coding_set_destination): Return void.
3239 (coding_change_source, coding_change_destinations): New functions,
3240 with the old behaviors of coding_set_source and coding_set_destination.
3241 All callers that need an offset changed to use these new functions.
3242
eb7afdad
GM
32432012-05-26 Glenn Morris <rgm@gnu.org>
3244
3245 * nsterm.m (ns_init_paths): Don't mess with INFOPATH. (Bug#2791)
3246
f12fdf02
EZ
32472012-05-26 Eli Zaretskii <eliz@gnu.org>
3248
53a63be6 3249 Extend mouse support on W32 text-mode console.
61b108cc
SM
3250 * xdisp.c (draw_row_with_mouse_face):
3251 Call tty_draw_row_with_mouse_face for WINDOWSNT as well.
eb3f6f01 3252
eb3f6f01 3253 * w32console.c: Include window.h.
61b108cc
SM
3254 (w32con_write_glyphs_with_face, tty_draw_row_with_mouse_face):
3255 New functions.
eb3f6f01
EZ
3256 (initialize_w32_display): Initialize mouse-highlight data.
3257
53a63be6
EZ
3258 * w32inevt.c: Include termchar.h and window.h.
3259 (do_mouse_event): Support mouse-autoselect-window. When the mouse
3260 moves, call note_mouse_highlight. If help_echo changed, call
3261 gen_help_event to produce help-echo message in the echo area.
3262 Call clear_mouse_face if mouse_face_hidden is set in the mouse
3263 highlight info.
3264
4cfd81f6
PE
32652012-05-26 Paul Eggert <eggert@cs.ucla.edu>
3266
3267 * lread.c (read1): Simplify slightly to avoid an overflow warning
3268 with GCC 4.7.0 on x86-64.
3269
4446092a
EZ
32702012-05-26 Eli Zaretskii <eliz@gnu.org>
3271
3272 * bidi.c (bidi_mirror_char): Revert last change: an int is
3273 definitely wide enough here.
3274
42b2a986 32752012-05-25 Paul Eggert <eggert@cs.ucla.edu>
3164aeac 3276
42b2a986 3277 Fix integer width and related bugs (Bug#9874).
eb106a49 3278 * alloc.c (pure_bytes_used_lisp, pure_bytes_used_non_lisp):
d311d28c
PE
3279 (allocate_vectorlike, buffer_memory_full, struct sdata, SDATA_SIZE)
3280 (string_bytes, check_sblock, allocate_string_data):
3281 (compact_small_strings, Fmake_bool_vector, make_string)
3282 (make_unibyte_string, make_multibyte_string)
3283 (make_string_from_bytes, make_specified_string)
3284 (allocate_vectorlike, Fmake_vector, find_string_data_in_pure)
3285 (make_pure_string, make_pure_c_string, make_pure_vector, Fpurecopy)
3286 (mark_vectorlike):
3287 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3288 (allocate_pseudovector):
3289 Use int, not EMACS_INT, where int is wide enough.
3290 (inhibit_garbage_collection, Fgarbage_collect):
3291 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3292 * bidi.c (bidi_mirror_char): Use EMACS_INT, not int, where
3293 int might not be wide enough.
3294 (bidi_cache_search, bidi_cache_find, bidi_init_it)
3295 (bidi_count_bytes, bidi_char_at_pos, bidi_fetch_char)
3296 (bidi_at_paragraph_end, bidi_find_paragraph_start)
3297 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
3298 (bidi_level_of_next_char, bidi_move_to_visually_next):
3299 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3300 * buffer.c (copy_overlays, Fgenerate_new_buffer_name)
3301 (Fkill_buffer, Fset_buffer_major_mode)
3302 (advance_to_char_boundary, Fbuffer_swap_text)
3303 (Fset_buffer_multibyte, overlays_at, overlays_in)
3304 (overlay_touches_p, struct sortvec, record_overlay_string)
3305 (overlay_strings, recenter_overlay_lists)
3306 (adjust_overlays_for_insert, adjust_overlays_for_delete)
3307 (fix_start_end_in_overlays, fix_overlays_before, modify_overlay)
3308 (Fmove_overlay, Fnext_overlay_change, Fprevious_overlay_change)
3309 (Foverlay_recenter, last_overlay_modification_hooks_used)
3310 (report_overlay_modification, evaporate_overlays, enlarge_buffer_text):
3311 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
977b0e45
PE
3312 (validate_region): Omit unnecessary test for b <= e,
3313 since that's guaranteed by the previous test.
d311d28c
PE
3314 (adjust_overlays_for_delete): Avoid pos + length overflow.
3315 (Fmove_overlay, Fdelete_overlay, add_overlay_mod_hooklist)
3316 (report_overlay_modification):
3317 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3318 (Foverlays_at, Fnext_overlay_change, Fprevious_overlay_change):
3319 Omit pointer cast, which isn't needed anyway, and doesn't work
3320 after the EMACS_INT -> ptrdiff_t change.
02481186 3321 (Fmove_overlay): Clip BEG and END to ptrdiff_t to avoid overflow.
d311d28c
PE
3322 * buffer.h: Adjust decls to match defn changes elsewhere.
3323 (struct buffer_text, struct buffer):
3324 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3325 Use EMACS_INT, not int, where int might not be wide enough.
39b5db3b
PE
3326 * bytecode.c (unmark_byte_stack, exec_byte_code): Use ptrdiff_t,
3327 not int, to avoid needless 32-bit limit on 64-bit hosts.
3328 (exec_byte_code): Use tighter memory-full test, one that checks
3329 for alloca overflow. Don't compute the address of the object just
3330 before an array, as that's not portable. Use EMACS_INT, not
3331 ptrdiff_t or int, where ptrdiff_t or int might not be wide enough.
d311d28c
PE
3332 * callint.c (Fcall_interactively):
3333 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3334 * callproc.c (call_process_kill, Fcall_process):
3335 Don't assume pid_t fits into an Emacs fixnum.
3336 (call_process_cleanup, Fcall_process, child_setup):
3337 Don't assume pid_t fits into int.
3338 (call_process_cleanup, Fcall_process, delete_temp_file)
3339 (Fcall_process_region):
3340 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3341 (Fcall_process): Simplify handling of volatile integers.
3342 Use int, not EMACS_INT, where int will do.
3343 * casefiddle.c (casify_object, casify_region, operate_on_word)
3344 (Fupcase_word, Fdowncase_word, Fcapitalize_word):
3345 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3346 (casify_object): Avoid integer overflow when overallocating buffer.
3347 * casetab.c (set_identity, shuffle): Prefer int to unsigned when
45c2afd6 3348 either works. Use lint_assume to convince GCC 4.6.1 that it's OK.
d311d28c
PE
3349 * category.c (Fchar_category_set): Don't assume fixnum fits in int.
3350 * category.h (CATEGORYP): Don't assume arg is nonnegative.
3351 * ccl.c (GET_CCL_INT): Remove; no longer needed, since the
3352 integers are now checked earlier. All uses replaced with XINT.
3353 (ccl_driver):
3354 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3355 For CCL_MapSingle, check that content and value are in int range.
c801946a
PE
3356 (ccl_driver, Fregister_code_conversion_map):
3357 Check that Vcode_version_map_vector is a vector.
d311d28c
PE
3358 (resolve_symbol_ccl_program): Check that vector header is in range.
3359 Always copy the vector, so that we can check its contents reliably
3360 now rather than having to recheck each instruction as it's being
3361 executed. Check that vector words fit in 'int'.
3362 (ccl_get_compiled_code, Fregister_ccl_program)
3363 (Fregister_code_conversion_map): Use ptrdiff_t, not int, for
3364 program indexes, to avoid needless 32-bit limit on 64-bit hosts.
3365 (Fccl_execute, Fccl_execute_on_string): Check that initial reg
3366 contents are in range.
3367 (Fccl_execute_on_string): Check that status is in range.
3368 * ccl.h (struct ccl_program.idx): Now ptrdiff_t, not int.
3369 * character.c (char_resolve_modifier_mask, Fchar_resolve_modifiers):
3370 Accept and return EMACS_INT, not int, because callers can pass values
3371 out of 'int' range.
3372 (c_string_width, strwidth, lisp_string_width, chars_in_text)
3373 (multibyte_chars_in_text, parse_str_as_multibyte)
3374 (str_as_multibyte, count_size_as_multibyte, str_to_multibyte)
3375 (str_as_unibyte, str_to_unibyte, string_count_byte8)
3376 (string_escape_byte8, Fget_byte):
3377 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
a14e1568 3378 (Funibyte_string): Use CHECK_RANGED_INTEGER, not CHECK_NATNUM, to
d311d28c
PE
3379 avoid mishandling large integers.
3380 * character.h: Adjust decls to match defn changes elsewhere.
3381 * charset.c (load_charset_map_from_file, find_charsets_in_text)
3382 (Ffind_charset_region):
3383 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3384 (load_charset_map_from_file): Redo idx calculation to avoid overflow.
3385 (load_charset_map_from_vector, Fdefine_charset_internal):
3c7649c1 3386 Don't assume fixnum fits in int.
d311d28c
PE
3387 (load_charset_map_from_vector, Fmap_charset_chars):
3388 Remove now-unnecessary CHECK_NATNUMs.
3389 (Fdefine_charset_internal): Check ranges here, more carefully.
3c7649c1
PE
3390 Don't rely on undefined behavior with signed left shift overflow.
3391 Don't assume unsigned int fits into fixnum, or that fixnum fits
3392 into unsigned int. Don't require max_code to be a valid fixnum;
3393 that's not true for gb10830 4-byte on a 32-bit host. Allow
3394 invalid_code to be a cons, for the same reason. Require code_offset
3395 to be a character. Avoid int overflow if max_char is close
3396 to INT_MAX.
3397 (CODE_POINT_TO_INDEX): On 32-bit hosts, return int, not unsigned;
3398 this is intended anyway and avoids some undefined behavior.
3399 (load_charset_map): Pass unsigned, not int, as 2nd arg of
3400 INDEX_TO_CODE_POINT, as that's what it expects.
3401 (Funify_charset, encode_char): Don't stuff unsigned vals into int vars.
60ad3eab
PE
3402 * charset.h (DECODE_CHAR): Return int, not unsigned;
3403 this is what was intended anyway, and it avoids undefined behavior.
3404 (CHARSET_OFFSET): Remove unused macro, instead of fixing its
3405 integer-overflow issues.
3406 (ENCODE_CHAR): Return unsigned on all hosts, not just on 32-bit hosts.
3407 Formerly, it returned EMACS_INT on 64-bit hosts in the common case
3408 where the argument is EMACS_INT, and this behavior is not intended.
d311d28c
PE
3409 * chartab.c (Fmake_char_table, Fset_char_table_range)
3410 (uniprop_get_decoder, uniprop_get_encoder):
3411 Don't assume fixnum fits in int.
3412 * cmds.c (move_point): New function, that does the gist of
3413 Fforward_char and Fbackward_char, but does so while checking
3414 for integer overflow more accurately.
c96e5d6a 3415 (Fforward_char, Fbackward_char): Use it.
d311d28c
PE
3416 (Fforward_line, Fend_of_line, internal_self_insert)
3417 (internal_self_insert):
3418 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3419 Fix a FIXME, by checking for integer overflow when calculating
3420 target_clm and actual_clm.
3421 * coding.c (detect_coding_XXX, encode_coding_XXX, CODING_DECODE_CHAR)
8f50130c 3422 (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET, CODING_CHAR_CHARSET_P)
d311d28c
PE
3423 (ASSURE_DESTINATION, coding_alloc_by_realloc)
3424 (coding_alloc_by_making_gap, alloc_destination)
3425 (detect_coding_utf_8, encode_coding_utf_8, decode_coding_utf_16)
3426 (encode_coding_utf_16, detect_coding_emacs_mule)
3427 (decode_coding_emacs_mule, encode_coding_emacs_mule)
3428 (detect_coding_iso_2022, decode_coding_iso_2022)
3429 (encode_invocation_designation, encode_designation_at_bol)
3430 (encode_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
3431 (decode_coding_sjis, decode_coding_big5, encode_coding_sjis)
3432 (encode_coding_big5, detect_coding_ccl, decode_coding_ccl)
3433 (encode_coding_ccl, encode_coding_raw_text)
3434 (detect_coding_charset, decode_coding_charset)
3435 (encode_coding_charset, detect_eol, decode_eol, produce_chars)
3436 (produce_composition, produce_charset, produce_annotation)
3437 (decode_coding, handle_composition_annotation)
3438 (handle_charset_annotation, consume_chars, decode_coding_gap)
3439 (decode_coding_object, encode_coding_object, detect_coding_system)
3440 (Ffind_coding_systems_region_internal, Fcheck_coding_systems_region)
3441 (code_convert_region, code_convert_string)
8f50130c
PE
3442 (Fdefine_coding_system_internal)
3443 (coding_set_source, coding_set_destination):
d311d28c
PE
3444 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3445 (setup_iso_safe_charsets, consume_chars, Funencodable_char_position)
3446 (Fdefine_coding_system_internal):
3447 Don't assume fixnums fit in int.
3448 (decode_coding_gap, decode_coding_object, encode_coding_object)
5895d7b9 3449 (Fread_coding_system, Fdetect_coding_region)
2c6a9faa
PE
3450 (Funencodable_char_position, Fcheck_coding_systems_region)
3451 (get_translation, handle_composition_annotation, consume_chars):
d311d28c 3452 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
977b0e45 3453 (consume_chars): Rewrite to not calculate an address outside buffer.
d311d28c 3454 (Ffind_operation_coding_system): NATNUMP can eval its arg twice.
7b09a37a 3455 Don't access memory outside of the args array.
d311d28c 3456 (Fdefine_coding_system_internal): Check for charset-id overflow.
47664caa
PE
3457 (ENCODE_ISO_CHARACTER): Use unsigned, not int, to store the unsigned
3458 result of ENCODE_CHAR.
d311d28c
PE
3459 * coding.h: Adjust decls to match defn changes elsewhere.
3460 (struct coding_system):
3461 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3462 * composite.c (get_composition_id, find_composition)
3463 (run_composition_function, update_compositions)
3464 (compose_text, composition_gstring_put_cache)
3465 (composition_gstring_p, composition_gstring_width)
3466 (fill_gstring_header, fill_gstring_body, autocmp_chars)
3467 (composition_compute_stop_pos, composition_reseat_it)
3468 (composition_update_it, struct position_record)
3469 (find_automatic_composition, composition_adjust_point)
3470 (Fcomposition_get_gstring, Ffind_composition_internal):
3471 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3472 (update_compositions):
3473 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3474 * composite.h: Adjust decls to match defn changes elsewhere.
3475 (struct composition):
3476 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3477 * data.c (let_shadows_buffer_binding_p, let_shadows_global_binding_p):
3478 Do not attempt to compute the address of the object just before a
3479 buffer; this is not portable.
3480 (Faref, Faset):
3481 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3482 (Faset): Use int, not EMACS_INT, where int is wide enough.
3483 (Fstring_to_number): Don't assume fixnums fit in int.
3484 (Frem): Don't assume arg is nonnegative.
3485 * dbusbind.c (xd_append_arg): Check for integers out of range.
3486 (Fdbus_call_method): Don't overflow the timeout int.
42b2a986 3487 (extract_signed, extract_unsigned): New functions.
243e0530
PE
3488 (XD_CHECK_DBUS_SERIAL): Remove; superseded by extract_unsigned.
3489 (xd_get_connection_references): Return ptrdiff_t, not int.
3490 All uses changed.
3491 (xd_signature, xd_append_arg, xd_retrieve_arg, Fdbus_message_internal)
3492 (xd_read_message_1):
3493 Use int, not unsigned, where the dbus API uses int.
3494 (Fdbus_message_internal): Don't overflow mtype.
3495 (syms_of_dbusbind): Allocate right-sized buffer for integers.
d311d28c
PE
3496 * dired.c (directory_files_internal, file_name_completion, scmp)
3497 (file_name_completion_stat):
3498 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3499 (file_name_completion): Don't overflow matchcount.
3500 (file_name_completion_stat): Use SAFE_ALLOCA, not alloca.
3501 * dispextern.h: Adjust decls to match defn changes elsewhere.
3502 (struct text_pos, struct glyph, struct bidi_saved_info)
3503 (struct bidi_string_data, struct bidi_it, struct composition_it)
3504 (struct it):
3505 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3506 (struct display_pos, struct composition_it, struct it):
3507 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3508 * dispnew.c (increment_matrix_positions)
3509 (increment_row_positions, mode_line_string)
3510 (marginal_area_string):
3511 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
54e1617f 3512 (change_frame_size_1, Fredisplay, Fframe_or_buffer_changed_p):
d311d28c
PE
3513 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3514 (duration_to_sec_usec): New function, to check for overflow better.
3515 (Fsleep_for, sit_for): Use it.
3516 * doc.c (get_doc_string, store_function_docstring):
3517 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3518 (get_doc_string, Fsnarf_documentation):
3519 Use int, not EMACS_INT, where int is wide enough.
3520 (get_doc_string):
3521 Use SAFE_ALLOCA, not alloca.
3522 Check for overflow when converting EMACS_INT to off_t.
3523 * doprnt.c (doprnt):
3524 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3525 * editfns.c (init_editfns, Fuser_uid, Fuser_real_uid):
3526 Don't assume uid_t fits into fixnum.
3527 (buildmark, Fgoto_char, overlays_around, find_field, Fdelete_field)
3528 (Ffield_string, Ffield_string_no_properties, Ffield_beginning)
3529 (Ffield_end, Fconstrain_to_field, Fline_beginning_position)
3530 (Fline_end_position, Fprevious_char, Fchar_after, Fchar_before)
3531 (general_insert_function)
3532 (Finsert_char, make_buffer_string, make_buffer_string_both)
3533 (update_buffer_properties, Fbuffer_substring)
3534 (Fbuffer_substring_no_properties, Fcompare_buffer_substrings)
3535 (Fsubst_char_in_region, check_translation)
3536 (Ftranslate_region_internal, save_restriction_restore, Fformat)
3537 (transpose_markers, Ftranspose_regions):
3538 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3539 (clip_to_bounds): Move to lisp.h as an inline function).
3540 (Fconstrain_to_field): Don't assume integers are nonnegative.
3541 (Fline_beginning_position, Fsave_excursion, Fsave_current_buffer):
3542 (Fsubst_char_in_region, Fsave_restriction):
3543 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3544 (Femacs_pid): Don't assume pid_t fits into fixnum.
3545 (lo_time): Use int, not EMACS_INT, when int suffices.
3546 (lisp_time_argument): Check for usec out of range.
3547 (Fencode_time): Don't assume fixnum fits in int.
3f4eabd1
PE
3548 (Fuser_login_name, Fuser_full_name): Signal an error
3549 if a uid argument is out of range, rather than relying on
3550 undefined behavior.
c8d5c857
PE
3551 (Fformat_time_string): Remove now-unnecessary check.
3552 lisp_time_argument checks for out-of-range usec now.
243e0530 3553 Use ptrdiff_t, not size_t, where ptrdiff_t will do.
d311d28c
PE
3554 * emacs.c (gdb_valbits, gdb_gctypebits): Now int, not EMACS_INT.
3555 (gdb_data_seg_bits): Now uintptr_t, not EMACS_INT.
3556 (PVEC_FLAG, gdb_array_mark_flag): Now ptrdiff_t, not EMACS_INT.
3557 (init_cmdargs, Fdump_emacs):
3558 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3559 (Fkill_emacs): Don't assume fixnum fits in int; instead, take just
3560 the bottom (typically) 32 bits of the fixnum.
3561 * eval.c (specpdl_size, call_debugger):
3562 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3563 (when_entered_debugger, Fbacktrace_debug):
3564 Don't assume fixnum can fit in int.
3565 (Fdefvaralias, Fdefvar): Do not attempt to compute the address of
3566 the object just before a buffer; this is not portable.
3567 (FletX, Flet, Funwind_protect, do_autoload, Feval, funcall_lambda)
3568 (grow_specpdl, unbind_to):
3569 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3570 (Fapply, apply_lambda): Don't assume ptrdiff_t can hold fixnum.
3571 (grow_specpdl): Simplify allocation by using xpalloc.
856bbc81 3572 (Fprog1, Fprog2): Don't assume list length fits in int. Simplify.
d311d28c
PE
3573 * fileio.c (Ffind_file_name_handler, Fcopy_file, Frename_file)
3574 (Finsert_file_contents, Fwrite_region, Fdo_auto_save):
3575 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3576 (Ffind_file_name_handler, non_regular_inserted, Finsert_file_contents)
3577 (a_write, e_write):
3578 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3579 (Fcopy_file, non_regular_nbytes, read_non_regular)
3580 (Finsert_file_contents):
3581 Use int, not EMACS_INT, where int is wide enough.
3582 (READ_BUF_SIZE): Verify that it fits in int.
3583 (Finsert_file_contents): Check that counts are in proper range,
3584 rather than assuming fixnums fit into ptrdiff_t etc.
3585 Don't assume fixnums fit into int.
125b3835 3586 * floatfns.c (Fexpt): Avoid undefined signed * signed overflow.
5895d7b9
PE
3587 * fns.c (Fcompare_strings, Fstring_lessp, struct textprop_rec, concat)
3588 (string_char_byte_cache_charpos, string_char_byte_cache_bytepos)
d311d28c
PE
3589 (string_char_to_byte, string_byte_to_char)
3590 (string_make_multibyte, string_to_multibyte)
3591 (string_make_unibyte, Fstring_as_unibyte, Fstring_as_multibyte)
3592 (Fstring_to_unibyte, Fsubstring, Fsubstring_no_properties)
3593 (substring_both, Fdelete, internal_equal, Ffillarray)
3594 (Fclear_string, mapcar1)
3595 (Fbase64_encode_region, Fbase64_encode_string, base64_encode_1)
3596 (Fbase64_decode_region, Fbase64_decode_string, base64_decode_1)
3597 (larger_vector, make_hash_table, maybe_resize_hash_table)
3598 (hash_lookup, hash_remove_from_table, hash_clear, sweep_weak_table)
3599 (Fmaphash, secure_hash):
3600 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3601 (concat): Check for string index and length overflow.
3602 (Fmapconcat): Don't assume fixnums fit into ptrdiff_t.
3603 (Frequire):
3604 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3605 (larger_vector): New API (vec, incr_min, size_max) replaces old
3606 one (vec, new_size, init). This catches size overflow.
3607 INIT was removed because it was always Qnil.
3608 All callers changed.
3609 (INDEX_SIZE_BOUND): New macro, which calculates more precisely
3610 the upper bound on a hash table index size.
3611 (make_hash_table, maybe_resize_hash_table): Use it.
3612 (secure_hash): Computer start_byte and end_byte only after
3613 they're known to be in ptrdiff_t range.
3614 * font.c (font_intern_prop, font_at, font_range, Ffont_shape_gstring)
3615 (Ffont_get_glyphs, Ffont_at):
3616 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3617 (font_style_to_value, font_prop_validate_style, font_expand_wildcards)
3618 (Flist_fonts, Fopen_font):
3619 Don't assume fixnum can fit in int.
3620 (check_gstring): Don't assume index can fit in int.
3621 (font_match_p): Check that fixnum is a character, not a nonnegative
3622 fixnum, since the later code needs to stuff it into an int.
3623 (font_find_for_lface): Use SAFE_ALLOCA_LISP, not alloca.
3624 (font_fill_lglyph_metrics): Use unsigned, not EMACS_INT, to avoid
3625 conversion overflow issues.
3626 (Fopen_font): Check for integer out of range.
3627 (Ffont_get_glyphs): Don't assume index can fit in int.
3628 * font.h: Adjust decls to match defn changes elsewhere.
3629 * fontset.c (reorder_font_vector): Redo score calculation to avoid
3630 integer overflow.
3631 (num_auto_fontsets, fontset_from_font): Use ptrdiff_t, not
3632 printmax_t, where ptrdiff_t is wide enough.
3633 (Finternal_char_font):
3634 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3635 * frame.c (Fset_mouse_position, Fset_mouse_pixel_position)
3636 (Fset_frame_height, Fset_frame_width, Fset_frame_size)
3637 (Fset_frame_position, x_set_frame_parameters)
3638 (x_set_line_spacing, x_set_border_width)
3639 (x_set_internal_border_width, x_set_alpha, x_figure_window_size):
3640 Check that fixnums are in proper range for system types.
3641 (frame_name_fnn_p, Fframe_parameter, Fmodify_frame_parameters):
3642 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3643 (Fmodify_frame_parameters): Don't assume fixnum fits in int.
3644 Use SAFE_ALLOCA_LISP, not alloca.
3645 * frame.h (struct frame): Use intptr_t, not EMACS_INT, where
3646 intptr_t is wide enough.
3647 * fringe.c (lookup_fringe_bitmap, get_logical_fringe_bitmap)
3648 (Fdefine_fringe_bitmap): Don't assume fixnum fits in int.
3649 (Ffringe_bitmaps_at_pos): Don't assume index fits in int.
3650 Check for fixnum out of range.
3651 * ftfont.c (ftfont_list): Don't assume index fits in int.
3652 Check that fixnums are in proper range for system types.
3653 (ftfont_shape_by_flt):
3654 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
d311d28c
PE
3655 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
3656 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3657 (Fgnutls_error_fatalp, Fgnutls_error_string, Fgnutls_boot):
3658 Check that fixnums are in proper range for system types.
3659 * gnutls.h: Adjust decls to match defn changes elsewhere.
3660 * gtkutil.c (xg_dialog_run):
3661 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3662 (update_frame_tool_bar):
3663 Check that fixnums are in proper range for system types.
3664 * image.c (parse_image_spec): Redo count calculation to avoid overflow.
5895d7b9 3665 (lookup_image): Check that fixnums are in range for system types.
d311d28c
PE
3666 * indent.c (last_known_column, last_known_column_point):
3667 (current_column_bol_cache):
3668 (skip_invisible, current_column, check_display_width):
3669 (check_display_width, scan_for_column, current_column_1)
3670 (Findent_to, Fcurrent_indentation, position_indentation)
3671 (indented_beyond_p, Fmove_to_column, compute_motion):
3672 (Fcompute_motion, Fvertical_motion):
3673 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3674 (last_known_column_modified): Use EMACS_INT, not int.
3675 (check_display_width):
3676 (Fcompute_motion):
3677 Check that fixnums and floats are in proper range for system types.
3678 (compute_motion): Don't assume index or fixnum fits in int.
3679 (compute_motion, Fcompute_motion):
3680 Use int, not EMACS_INT, when it is wide enough.
3681 (vmotion): Omit local var start_hpos that is always 0; that way
3682 we don't need to worry about overflow in expressions involving it.
3683 * indent.h: Adjust decls to match defn changes elsewhere.
3684 (struct position):
3685 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3686 Use int, not EMACS_INT, where int is wide enough.
3687 Remove unused members ovstring_chars_done and tab_offset;
3688 all uses removed.
3689 * insdel.c (move_gap, move_gap_both, gap_left, gap_right)
3690 (adjust_markers_for_delete, adjust_markers_for_insert, adjust_point)
3691 (adjust_markers_for_replace, make_gap_larger, make_gap_smaller)
3692 (make_gap, copy_text, insert, insert_and_inherit)
3693 (insert_before_markers, insert_before_markers_and_inherit)
3694 (insert_1, count_combining_before, count_combining_after)
3695 (insert_1_both, insert_from_string)
3696 (insert_from_string_before_markers, insert_from_string_1)
3697 (insert_from_gap, insert_from_buffer, insert_from_buffer_1)
3698 (adjust_after_replace, adjust_after_insert, replace_range)
3699 (replace_range_2, del_range, del_range_1, del_range_byte)
3700 (del_range_both, del_range_2, modify_region)
3701 (prepare_to_modify_buffer, signal_before_change)
3702 (signal_after_change, Fcombine_after_change_execute):
3703 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3704 * intervals.c (traverse_intervals, rotate_right, rotate_left)
3705 (balance_an_interval, split_interval_right, split_interval_left)
3706 (find_interval, next_interval, update_interval)
3707 (adjust_intervals_for_insertion, delete_node, delete_interval)
3708 (interval_deletion_adjustment, adjust_intervals_for_deletion)
3709 (static_offset_intervals, offset_intervals)
3710 (merge_interval_right, merge_interval_left, make_new_interval)
3711 (graft_intervals_into_buffer, temp_set_point_both)
3712 (temp_set_point, set_point, adjust_for_invis_intang)
3713 (set_point_both, move_if_not_intangible, get_property_and_range)
3714 (get_local_map, copy_intervals, copy_intervals_to_string)
3715 (compare_string_intervals, set_intervals_multibyte_1):
3716 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3717 * intervals.h: Adjust decls to match defn changes elsewhere.
3718 (struct interval):
3719 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3720 * keyboard.c (this_command_key_count, this_single_command_key_start)
3721 (before_command_key_count, before_command_echo_length, echo_now)
3722 (echo_length, recursive_edit_1, Frecursive_edit, Ftrack_mouse)
3723 (command_loop_1, safe_run_hooks, read_char, timer_check_2)
3724 (menu_item_eval_property, read_key_sequence, Fread_key_sequence)
3725 (Fread_key_sequence_vector, Fexecute_extended_command, Fsuspend_emacs):
3726 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3727 (last_non_minibuf_size, last_point_position, echo_truncate)
3728 (command_loop_1, adjust_point_for_property, read_char, gen_help_event)
3729 (make_lispy_position, make_lispy_event, parse_modifiers_uncached)
3730 (parse_modifiers, modify_event_symbol, Fexecute_extended_command)
3731 (stuff_buffered_input):
3732 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3733 (last_auto_save, command_loop_1, read_char):
3734 Use EMACS_INT, not int, to avoid integer overflow.
3735 (record_char): Avoid overflow in total_keys computation.
3736 (parse_modifiers_uncached): Redo index calculation to avoid overflow.
3737 * keyboard.h: Adjust decls to match defn changes elsewhere.
3738 * keymap.c (Fdefine_key, Fcurrent_active_maps, accessible_keymaps_1)
3739 (Fkey_description, Fdescribe_vector, Flookup_key):
3740 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3741 (click_position): New function, to check that positions are in range.
3742 (Fcurrent_active_maps):
3743 (describe_command):
3744 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3745 (Faccessible_keymaps, Fkey_description):
3746 (preferred_sequence_p):
3747 Don't assume fixnum can fit into int.
3748 (Fkey_description): Use SAFE_ALLOCA_LISP, not alloca.
3749 Check for integer overflow in size calculations.
3750 (Ftext_char_description): Use CHECK_CHARACTER, not CHECK_NUMBER, to
3751 avoid mishandling large integers.
3752 * lisp.h: Adjust decls to match defn changes elsewhere.
3753 (ARRAY_MARK_FLAG, PSEUDOVECTOR_FLAG, struct Lisp_String)
3754 (struct vectorlike_header, struct Lisp_Subr, struct Lisp_Hash_Table)
3755 (struct Lisp_Marker):
3756 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3757 (clip_to_bounds): Now an inline function, moved here from editfns.c.
d311d28c
PE
3758 (GLYPH_CODE_P): Check for overflow in system types, subsuming the
3759 need for GLYPH_CODE_CHAR_VALID_P and doing proper checking ourselves.
3760 All callers changed.
3761 (GLYPH_CODE_CHAR, GLYPH_CODE_FACE):
3762 Assume the arg has valid form, since it always does.
3763 (TYPE_RANGED_INTEGERP): Avoid bug when checking against a wide
3764 unsigned integer system type.
3765 (CHECK_RANGED_INTEGER, CHECK_TYPE_RANGED_INTEGER): New macros.
3766 (struct catchtag, specpdl_size, SPECPDL_INDEX, USE_SAFE_ALLOCA):
3767 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3768 (struct catchtag): Use EMACS_INT, not int, since it may be a fixnum.
3769 (duration_to_sec_usec): New decl.
3770 * lread.c (read_from_string_index, read_from_string_index_byte)
3771 (read_from_string_limit, readchar, unreadchar, openp)
3772 (read_internal_start, read1, oblookup):
3773 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3774 (Fload, readevalloop, Feval_buffer, Feval_region):
3775 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3776 (openp): Check for out-of-range argument to 'access'.
3777 (read1): Use int, not EMACS_INT, where int is wide enough.
3778 Don't assume fixnum fits into int.
6efdadfd 3779 Fix off-by-one error that can read outside a buffer.
1ab7b8ac
PE
3780 (read_filtered_event): Use duration_to_sec_usec
3781 to do proper overflow checking on durations.
d311d28c
PE
3782 * macros.c (Fstart_kbd_macro): Use xpalloc to check for overflow
3783 in size calculation.
3784 (Fexecute_kbd_macro):
3785 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3786 * marker.c (cached_charpos, cached_bytepos, CONSIDER)
3787 (byte_char_debug_check, buf_charpos_to_bytepos, verify_bytepos)
3788 (buf_bytepos_to_charpos, Fset_marker, set_marker_restricted)
3789 (set_marker_both, set_marker_restricted_both, marker_position)
3790 (marker_byte_position, Fbuffer_has_markers_at):
3791 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3792 (Fset_marker, set_marker_restricted): Don't assume fixnum fits in int.
61b108cc 3793 * menu.c (ensure_menu_items): Rename from grow_menu_items.
d311d28c
PE
3794 It now merely ensures that the menu is large enough, without
3795 necessarily growing it, as this avoids some integer overflow issues.
3796 All callers changed.
3797 (keymap_panes, parse_single_submenu, Fx_popup_menu):
3798 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3799 (parse_single_submenu, Fx_popup_menu): Don't assume fixnum fits in int.
3800 Use SAFE_ALLOCA_LISP, not alloca.
3801 (find_and_return_menu_selection): Avoid unnecessary casts of pointers
3802 to EMACS_INT. Check that fixnums are in proper range for system types.
3803 * minibuf.c (minibuf_prompt_width, string_to_object)
3804 (Fminibuffer_contents, Fminibuffer_contents_no_properties)
3805 (Fminibuffer_completion_contents, Ftry_completion, Fall_completions):
3806 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3807 (get_minibuffer, read_minibuf_unwind):
3808 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3809 (read_minibuf): Omit unnecessary arg BACKUP_N, which is always nil;
3810 this simplifies overflow checking. All callers changed.
3811 (read_minibuf, Fread_buffer, Ftry_completion, Fall_completions)
3812 (Ftest_completion):
3813 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3814 * nsfns.m (check_ns_display_info): Don't assume fixnum fits in long.
3815 (x_set_menu_bar_lines, x_set_tool_bar_lines, Fx_create_frame):
3816 Check that fixnums are in proper range for system types.
3817 (Fx_create_frame, Fx_show_tip):
3818 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3819 * nsfont.m (ns_findfonts, nsfont_list_family):
3820 Don't assume fixnum fits in long.
3821 * nsmenu.m (ns_update_menubar, ns_menu_show, ns_popup_dialog):
3822 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3823 (ns_update_menubar): Use intptr_t, not EMACS_INT, when intptr_t is
3824 wide enough.
17fdb222 3825 * nsselect.m (ns_get_local_selection, clean_local_selection_data):
d311d28c
PE
3826 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3827 * print.c (print_buffer_size, print_buffer_pos, print_buffer_pos_byte)
3828 (PRINTDECLARE, PRINTPREPARE):
3829 (strout, print_string):
3830 (print, print_preprocess, print_check_string_charset_prop)
3831 (print_object):
3832 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3833 (PRINTDECLARE):
3834 (temp_output_buffer_setup, Fprin1_to_string, print_object):
3835 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3836 (PRINTPREPARE): Use int, not ptrdiff_t, where int is wide enough.
d311d28c 3837 (printchar, strout): Use xpalloc to catch size calculation overflow.
0fd11aa5 3838 (Fexternal_debugging_output): Don't overflow EMACS_INT->int conversion.
d311d28c
PE
3839 (print_error_message): Use SAFE_ALLOCA, not alloca.
3840 (print_object): Use int, not EMACS_INT, where int is wide enough.
a8b7caa3
PE
3841 (print_depth, new_backquote_output, print_number_index):
3842 Use ptrdiff_t, not int, where int might not be wide enough.
d311d28c
PE
3843 * process.c (Fdelete_process): Don't assume pid fits into EMACS_INT.
3844 (Fset_process_window_size, Fformat_network_address)
3845 (get_lisp_to_sockaddr_size, set_socket_option, Fmake_network_process)
d44287d4 3846 (sigchld_handler):
d311d28c 3847 Check that fixnums are in proper range for system types.
d44287d4 3848 (Fsignal_process): Simplify by avoiding a goto.
d83cf4cc
PE
3849 Check for process-ids out of pid_t range rather than relying on
3850 undefined behavior.
e4d81efc 3851 (process_tick, update_tick): Use EMACS_INT, not int.
d311d28c
PE
3852 (Fformat_network_address, read_process_output, send_process)
3853 (Fprocess_send_region, status_notify):
3854 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3855 (Fformat_network_address, Fmake_serial_process, Fmake_network_process)
3856 (wait_reading_process_output, read_process_output, exec_sentinel):
3857 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3858 (conv_lisp_to_sockaddr): Don't assume fixnums fit into int.
3859 (Faccept_process_output): Use duration_to_sec_usec to do proper
3860 overflow checking on durations.
dde14581
PE
3861 (emacs_get_tty_pgrp, Fprocess_running_child_p, process_send_signal):
3862 Don't assume pid_t fits in int.
02481186
PE
3863 * process.h (struct Lisp_Process): Members tick and update_tick
3864 are now of type EMACS_INT, not int.
b62b53e8
PE
3865 * puresize.h (PURESIZE_RATIO): Shrink this to 8/6 on 32-bit hosts
3866 configured --with-wide-int.
d311d28c
PE
3867 * scroll.c (calculate_scrolling, calculate_direct_scrolling)
3868 (line_ins_del): Use int, not EMACS_INT, where int is wide enough.
3869 * search.c (looking_at_1, string_match_1):
3870 (fast_string_match, fast_c_string_match_ignore_case)
3871 (fast_string_match_ignore_case, fast_looking_at, scan_buffer)
3872 (scan_newline, find_before_next_newline, search_command)
3873 (trivial_regexp_p, search_buffer, simple_search, boyer_moore)
3874 (set_search_regs, wordify):
3875 (Freplace_match):
3876 (Fmatch_data):
3877 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3878 (string_match_1, search_buffer, set_search_regs):
3879 (Fmatch_data):
3880 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3881 (wordify): Check for overflow in size calculation.
3882 (Freplace_match): Avoid potential buffer overflow in search_regs.start.
3883 (Fset_match_data): Don't assume fixnum fits in ptrdiff_t.
3884 Check that fixnums are in proper range for system types.
3885 * sound.c (struct sound_device)
3886 (wav_play, au_play, vox_write, alsa_period_size, alsa_write):
3887 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3888 (Fplay_sound_internal):
3889 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
eacd378d 3890 * syntax.c (struct lisp_parse_state, find_start_modiff)
d311d28c
PE
3891 (Finternal_describe_syntax_value, scan_lists, scan_sexps_forward):
3892 (Fparse_partial_sexp):
3893 Don't assume fixnums can fit in int.
3894 (struct lisp_parse_state, find_start_pos, find_start_value)
3895 (find_start_value_byte, find_start_begv)
3896 (update_syntax_table, char_quoted, dec_bytepos)
3897 (find_defun_start, prev_char_comend_first, back_comment):
3898 (scan_words, skip_chars, skip_syntaxes, forw_comment, Fforward_comment)
3899 (scan_lists, Fbackward_prefix_chars, scan_sexps_forward):
3900 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3901 (Finternal_describe_syntax_value): Check that match_lisp is a
3902 character, not an integer, since the code stuffs it into int.
3903 (scan_words, scan_sexps_forward):
3904 Check that fixnums are in proper range for system types.
3905 (Fforward_word):
3906 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3907 (scan_sexps_forward):
3908 Use CHARACTERP, not INTEGERP, since the value must fit into int.
3909 (Fparse_partial_sexp): Fix doc; element 8 is not ignored.
3910 * syntax.h: Adjust decls to match defn changes elsewhere.
3911 (struct gl_state_s):
3912 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
e4ecdc9c
PE
3913 (SETUP_SYNTAX_TABLE_FOR_OBJECT): Use PTRDIFF_MAX, not
3914 MOST_POSITIVE_FIXNUM.
d311d28c
PE
3915 * sysdep.c (wait_for_termination_1, wait_for_termination)
3916 (interruptible_wait_for_termination, mkdir):
3917 Don't assume pid_t fits in int; on 64-bit AIX pid_t is 64-bit.
3918 (emacs_read, emacs_write):
3919 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
225a2cff
PE
3920 (system_process_attributes): Don't assume uid_t, gid_t, EMACS_INT,
3921 and double all fit in int.
d311d28c
PE
3922 * term.c (set_tty_color_mode):
3923 Check that fixnums are in proper range for system types.
3924 * termhooks.h (struct input_event):
3925 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3926 * textprop.c (validate_interval_range, interval_of)
3927 (Fadd_text_properties, set_text_properties_1)
3928 (Fremove_text_properties, Fremove_list_of_text_properties)
3929 (Ftext_property_any, Ftext_property_not_all)
3930 (copy_text_properties, text_property_list, extend_property_ranges)
3931 (verify_interval_modification):
3932 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3933 (Fnext_single_char_property_change)
3934 (Fprevious_single_char_property_change):
3935 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
5895d7b9
PE
3936 (copy_text_properties):
3937 Check for integer overflow in index calculation.
d311d28c
PE
3938 * undo.c (last_boundary_position, record_point, record_insert)
3939 (record_delete, record_marker_adjustment, record_change)
3940 (record_property_change):
3941 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3942 (truncate_undo_list, Fprimitive_undo): Don't assume fixnum fits in int.
3943 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3944 * w32fns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
3945 (Fx_hide_tip, Fx_file_dialog):
3946 * w32menu.c (set_frame_menubar):
3947 Use ptrdiff_t, not int, for consistency with rest of code.
3948 * window.c (window_scroll_preserve_hpos, window_scroll_preserve_vpos)
3949 (select_window, Fdelete_other_windows_internal)
3950 (window_scroll_pixel_based, window_scroll_line_based)
3951 (Frecenter, Fset_window_configuration):
3952 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
3953 (Fset_window_hscroll, run_window_configuration_change_hook)
3954 (set_window_buffer, temp_output_buffer_show, scroll_command)
5895d7b9 3955 (Fscroll_other_window, Frecenter):
d311d28c
PE
3956 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
3957 (Fwindow_line_height, window_scroll, Fscroll_left, Fscroll_right):
3958 Don't assume fixnum fits in int.
3959 (Fset_window_scroll_bars):
3960 Check that fixnums are in proper range for system types.
3961 * xdisp.c (help_echo_pos, pos_visible_p, string_pos_nchars_ahead)
3962 (string_pos, c_string_pos, number_of_chars, init_iterator)
3963 (in_ellipses_for_invisible_text_p, init_from_display_pos)
3964 (compute_stop_pos, next_overlay_change, compute_display_string_pos)
3965 (compute_display_string_end, handle_face_prop)
5895d7b9
PE
3966 (face_before_or_after_it_pos, handle_invisible_prop)
3967 (handle_display_prop, handle_display_spec, handle_single_display_spec)
d311d28c
PE
3968 (display_prop_intangible_p, string_buffer_position_lim)
3969 (string_buffer_position, handle_composition_prop, load_overlay_strings)
3970 (get_overlay_strings_1, get_overlay_strings)
3971 (iterate_out_of_display_property, forward_to_next_line_start)
3972 (back_to_previous_visible_line_start, reseat, reseat_to_string)
3973 (get_next_display_element, set_iterator_to_next)
3974 (get_visually_first_element, compute_stop_pos_backwards)
3975 (handle_stop_backwards, next_element_from_buffer)
3976 (move_it_in_display_line_to, move_it_in_display_line)
3977 (move_it_to, move_it_vertically_backward, move_it_by_lines)
3978 (add_to_log, message_dolog, message_log_check_duplicate)
3979 (message2, message2_nolog, message3, message3_nolog
3980 (with_echo_area_buffer, display_echo_area_1, resize_mini_window_1)
3981 (current_message_1, truncate_echo_area, truncate_message_1)
3982 (set_message, set_message_1, store_mode_line_noprop)
3983 (hscroll_window_tree, debug_delta, debug_delta_bytes, debug_end_vpos)
3984 (text_outside_line_unchanged_p, check_point_in_composition)
3985 (reconsider_clip_changes)
3986 (redisplay_internal, set_cursor_from_row, try_scrolling)
3987 (try_cursor_movement, set_vertical_scroll_bar, redisplay_window)
3988 (redisplay_window, find_last_unchanged_at_beg_row)
3989 (find_first_unchanged_at_end_row, row_containing_pos, try_window_id)
3990 (trailing_whitespace_p, find_row_edges, display_line)
3991 (RECORD_MAX_MIN_POS, Fcurrent_bidi_paragraph_direction)
3992 (display_mode_element, store_mode_line_string)
3993 (pint2str, pint2hrstr, decode_mode_spec)
3994 (display_count_lines, display_string, draw_glyphs)
3995 (x_produce_glyphs, x_insert_glyphs)
3996 (rows_from_pos_range, mouse_face_from_buffer_pos)
3997 (fast_find_string_pos, mouse_face_from_string_pos)
3998 (note_mode_line_or_margin_highlight, note_mouse_highlight):
3999 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4000 (safe_call, init_from_display_pos, handle_fontified_prop)
4001 (handle_single_display_spec, load_overlay_strings)
4002 (with_echo_area_buffer, setup_echo_area_for_printing)
4003 (display_echo_area, echo_area_display)
4004 (x_consider_frame_title, prepare_menu_bars, update_menu_bar)
4005 (update_tool_bar, hscroll_window_tree, redisplay_internal)
5895d7b9
PE
4006 (redisplay_window, dump_glyph_row, display_mode_line)
4007 (Fformat_mode_line, decode_mode_spec, on_hot_spot_p):
43ad2e9a 4008 (handle_display_spec, display_prop_string_p):
d311d28c
PE
4009 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4010 (handle_single_display_spec, build_desired_tool_bar_string)
4011 (redisplay_tool_bar, scroll_window_tree, Fdump_glyph_matrix)
4012 (get_specified_cursor_type):
4013 Check that fixnums are in proper range for system types.
4014 (struct overlay_entry, resize_mini_window, Fdump_glyph_row)
4015 (Flookup_image_map):
4016 Don't assume fixnums fit in int.
4017 (compare_overlay_entries):
4018 Avoid mishandling comparisons due to subtraction overflow.
4019 (load_overlay_strings): Use SAFE_NALLOCA, not alloca.
4020 (last_escape_glyph_face_id, last_glyphless_glyph_face_id):
4021 (handle_tool_bar_click):
4022 Use int, not unsigned, since we prefer signed and the signedness
4023 doesn't matter here.
4024 (get_next_display_element, next_element_from_display_vector):
4025 Use int, not EMACS_INT, when int is wide enough.
4026 (start_hourglass): Use duration_to_sec_usec to do proper
4027 overflow checking on durations.
4028 * xfaces.c (Fbitmap_spec_p):
4029 Check that fixnums are in proper range for system types.
4030 (compare_fonts_by_sort_order):
4031 Avoid mishandling comparisons due to subtraction overflow.
4032 (Fx_family_fonts, realize_basic_faces):
4033 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4034 (Fx_family_fonts):
4035 Don't assume fixnum fits in int.
4036 Use SAFE_ALLOCA_LISP, not alloca.
4037 (merge_face_heights): Remove unnecessary cast to EMACS_INT.
4038 (Finternal_make_lisp_face): Don't allocate more than MAX_FACE_ID.
4039 (face_at_buffer_position, face_for_overlay_string)
4040 (face_at_string_position):
4041 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4042 (merge_faces): Use int, not EMACS_INT, where int is wide enough.
4043 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines, x_icon_verify)
4044 (Fx_show_tip):
4045 Check that fixnums are in proper range for system types.
4046 (Fx_create_frame, x_create_tip_frame, Fx_show_tip)
4047 (Fx_hide_tip, Fx_file_dialog, Fx_select_font):
4048 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4049 (Fx_change_window_property): Don't assume fixnums fit in int.
4050 * xfont.c (xfont_chars_supported):
4051 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4052 * xmenu.c (Fx_popup_dialog, set_frame_menubar)
4053 (create_and_show_popup_menu, create_and_show_dialog, xmenu_show):
4054 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4055 * xml.c (parse_region):
4056 * xrdb.c (magic_file_p):
4057 Use ptrdiff_t, not EMACS_INT, where ptrdiff_t is wide enough.
4058 * xselect.c (TRACE1): Don't assume pid_t promotes to int.
4059 (x_get_local_selection, x_reply_selection_request)
4060 (x_handle_selection_request, wait_for_property_change):
4061 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4062 (selection_data_to_lisp_data): Use short, not EMACS_INT, where
4063 short is wide enough.
4064 (x_send_client_event): Don't assume fixnum fits in int.
4065 * xterm.c (x_x_to_emacs_modifiers):
4066 Don't assume EMACS_INT overflows nicely into int.
4067 (x_emacs_to_x_modifiers): Use EMACS_INT, not int, because values
4068 may come from Lisp.
4069 (handle_one_xevent): NATNUMP can eval its arg twice.
4070 (x_connection_closed):
4071 Use ptrdiff_t, not int, to avoid needless 32-bit limit on 64-bit hosts.
4072 * xterm.h: Adjust decls to match defn changes elsewhere.
4073 (struct scroll_bar): Use struct vectorlike_header
4074 rather than rolling our own approximation.
4075 (SCROLL_BAR_VEC_SIZE): Remove; not used.
4076
c6574eb5
GM
40772012-05-25 Glenn Morris <rgm@gnu.org>
4078
4079 * lisp.mk (lisp): Update for more files being compiled now.
4080
e8d32c7e
SM
40812012-05-25 Stefan Monnier <monnier@iro.umontreal.ca>
4082
48def666
SM
4083 * lread.c: Remove `read_pure' which makes no difference.
4084 (read_pure): Remove var.
4085 (unreadpure): Remove function.
4086 (readevalloop): Don't call read_list with -1 flag.
4087 (read1, read_vector): Don't test read_pure any more.
4088 (read_list): Simplify.
4089
e8d32c7e
SM
4090 * fileio.c, character.h: Minor style tweaks.
4091
4b2addb7
DA
40922012-05-24 Dmitry Antipov <dmantipov@yandex.ru>
4093
4094 * window.h (clip_changed): Remove useless declaration.
4095
584461b2
JB
40962012-05-22 Juanma Barranquero <lekktu@gmail.com>
4097
4098 * makefile.w32-in: Follow-up to 2012-05-22T16:20:27Z!eggert@cs.ucla.edu.
4099 (TAGS, TAGS-gmake, CONFIG_H): Remove further references to m/intel386.h.
4100
34374650
PE
41012012-05-22 Paul Eggert <eggert@cs.ucla.edu>
4102
4103 Remove src/m/*.
4104 This directory predates autoconf and is no longer needed nowadays.
4105 Move its few remaining bits of functionality to where they're needed.
4106 * m/README, m/alpha.h, m/amdx86-64.h, m/ia64.h, m/ibmrs6000.h:
4107 * m/ibms390x.h, m/intel386.h, m/m68k.h, m/macppc.h, m/sparc.h:
4108 * m/template.h: Remove.
4109 * Makefile.in (M_FILE): Remove. All uses removed.
4110 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS):
4111 * lisp.h (USE_LSB_TAG):
4112 * mem-limits.h (EXCEEDS_LISP_PTR):
4113 Use VAL_MAX, not VALBITS, in #if.
4114 * lisp.h (EMACS_INT_MAX): New macro, useful in #if.
4115 (EMACS_UINT): Define unconditionally now.
4116 (BITS_PER_CHAR, BITS_PER_SHORT, BITS_PER_INT, BITS_PER_LONG)
4117 (BITS_PER_EMACS_INT): New constants, replacing
4118 what used to be in config.h, but not useful in #if.
4119 (GCTYPEBITS, VALBITS): Define unconditionally, since m/* files don't
4120 define them any more.
4121 (VAL_MAX): New macro.
4122 (VALMASK): Use it.
4123 * puresize.h (PURESIZE_RATIO): Use EMACS_INT_MAX, not
4124 BITS_PER_EMACS_INT, in #if.
4125 * s/aix4-2.h (BROKEN_FIONREAD, BROKEN_SIGAIO, BROKEN_SIGPTY)
4126 (BROKEN_SIGPOLL): Move here from m/ibmrs6000.h, which was removed.
4127 * s/gnu-linux.h (ULIMIT_BREAK_VALUE) [__i386__]:
4128 * s/ms-w32.h (DATA_START):
4129 Move here from removed file m/intel386.h.
4130 * s/gnu.h (NLIST_STRUCT): Remove undef; 'configure' does this.
4131 * s/irix6-5.h (_LP64): Remove; lisp.h no longer needs this.
4132
261cb4bb
PE
41332012-05-21 Paul Eggert <eggert@cs.ucla.edu>
4134
4135 Assume C89 or later.
4136 * alloc.c, buffer.c, lisp.h: Replace POINTER_TYPE with void.
4137 * alloc.c (overrun_check_malloc, overrun_check_realloc, xmalloc)
4138 (xrealloc):
4139 * buffer.c (mmap_free_1, mmap_enlarge): Omit needless casts.
4140 * editfns.c, fns.c, gmalloc.c, insdel.c, sysdep.c, termcap.c (NULL):
4141 * textprop.c, tparam.c (NULL): Remove.
4142 * ralloc.c, vm-limit.c (POINTER): Assume void * works.
4143 * regex.c (SIGN_EXTEND_CHAR): Assume signed char works.
4144 * regex.h (_RE_ARGS): Remove. All uses rewritten to use prototypes.
4145 * unexelf.c (ElfBitsW): Assume c89 preprocessor or better.
4146 * xterm.c (input_signal_count): Assume volatile works.
4147
ff23cd9f
KB
41482012-05-21 Ken Brown <kbrown@cornell.edu>
4149
4150 * xgselect.c (xg_select): Fix first argument in call to 'select'
4151 (bug#11508).
4152
1b170bc6
KB
41532012-05-20 Ken Brown <kbrown@cornell.edu>
4154
4155 * gmalloc.c (_free_internal_nolock, _realloc_internal_nolock)
bd7239f5 4156 [CYGWIN]: Cast ptr to (char *) before comparing to _heapbase.
1b170bc6 4157
b2f4d39f
KB
41582012-05-19 Ken Brown <kbrown@cornell.edu>
4159
4160 * xfns.c (x_in_use): Remove `static' qualifier.
4161 * xterm.h (x_in_use): Declare.
4162 * xgselect.c: Include xterm.h.
4163 (xg_select): Test `x_in_use' instead of `inhibit_window_system'
4164 and `display_arg' (bug#9754).
4165
003fdae2
PE
41662012-05-19 Paul Eggert <eggert@cs.ucla.edu>
4167
9232a6d9
PE
4168 * s/ms-w32.h (HAVE_GETDOMAINNAME): Remove; not needed.
4169
003fdae2
PE
4170 * m/vax.h: Remove; no longer needed since HAVE_FTIME is being removed.
4171 * s/ms-w32.h (HAVE_FTIME): Remove; not needed.
4172
784b56e2
EZ
41732012-05-18 Eli Zaretskii <eliz@gnu.org>
4174
4175 Fix compilation with -DGLYPH_DEBUG=1 on MS-Windows.
4176
4177 * w32term.c [GLYPH_DEBUG]: Add prototype for x_check_font.
090bd7cb 4178 (x_check_font) [GLYPH_DEBUG]: New function, copied from xterm.c.
784b56e2
EZ
4179
4180 * w32fns.c (unwind_create_frame) [GLYPH_DEBUG]: Fix broken
4181 reference to image_cache->refcount.
4182 (x_create_tip_frame): Fix broken use of FRAME_IMAGE_CACHE.
4183
a0a79cde
JL
41842012-05-17 Juri Linkov <juri@jurta.org>
4185
4186 * search.c (Fword_search_regexp, Fword_search_backward)
4187 (Fword_search_forward, Fword_search_backward_lax)
4188 (Fword_search_forward_lax): Move functions to isearch.el
4189 (bug#10145, bug#11381).
4190
b0572523
PE
41912012-05-16 Paul Eggert <eggert@cs.ucla.edu>
4192
4193 * xgselect.c (xg_select): Just invoke 'select' if -nw (Bug#9754).
4194
9660f5fc
SM
41952012-05-15 Stefan Monnier <monnier@iro.umontreal.ca>
4196
4197 * lread.c (init_obarray): Declare Qt and Qnil as special.
4198
4374de83
GM
41992012-05-14 Glenn Morris <rgm@gnu.org>
4200
4201 * nsterm.m (ns_init_paths): Fix typo ("libexec" not "lib-exec").
985584ae 4202 Put "libexec" before "bin", for the sake of init_callproc_1.
4374de83 4203
dc44c39a
PE
42042012-05-14 Paul Eggert <eggert@cs.ucla.edu>
4205
078c97cb
PE
4206 * keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
4207
dc44c39a
PE
4208 * unexaix.c: Port to more-recent AIX compilers.
4209 (report_error, report_error_1, make_hdr, copy_sym)
4210 (mark_x, adjust_lnnoptrs, unrelocate_symbols):
4211 Make arguments const char *, not char *, to avoid violations of C
4212 standard and to fix some AIX warnings reported by Gilles Pion.
4213
e18afed7 42142012-05-14 Eli Zaretskii <eliz@gnu.org>
ac268e67
EZ
4215
4216 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
4217 already have overlays loaded.
4218 (handle_single_display_spec): Before returning without displaying
4219 fringe bitmap, synchronize the bidi iterator with the main display
4220 iterator, by calling iterate_out_of_display_property.
4221 (iterate_out_of_display_property): Detect buffer iteration by
4222 testing that it->string is a Lisp string.
4223 (get_next_display_element): When the current object is exhausted,
4224 and there's something on it->stack, call set_iterator_to_next to
4225 proceed with what's on the stack, instead of returning zero.
4226 (set_iterator_to_next): If called at the end of a Lisp string,
4227 proceed to consider_string_end without incrementing string
4228 position. Don't increment display vector index past the end of
4229 the display vector. (Bug#11417)
c8fb9dc6
EZ
4230 (pos_visible_p): Don't report a position visible when move_it_to
4231 stopped at the last line of window, which happens to be scanned
4232 backwards by the bidi iteration. (Bug#11464)
ac268e67 4233
e18afed7 42342012-05-14 Eli Zaretskii <eliz@gnu.org>
82f9b393
EZ
4235
4236 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
4237 and right-margin display specs even if the spec is invalid or we
61b108cc
SM
4238 are on a TTY, and thus unable to display on the fringes.
4239 That's because the text with the property will not be displayed anyway,
82f9b393
EZ
4240 so we need to signal to the caller that this is a "replacing"
4241 display spec. This fixes display when the spec is invalid or we
4242 are on a TTY.
4243
e18afed7 42442012-05-14 Paul Eggert <eggert@cs.ucla.edu>
297834cd
PE
4245
4246 * unexaix.c (make_hdr): Fix typo in prototype.
4247 This bug broke the build on AIX. Problem reported by Gilles Pion.
4248
9d0a235a
MA
42492012-05-14 Michael Albinus <michael.albinus@gmx.de>
4250
4251 * keyboard.c (kbd_buffer_get_event): Read special events also in
4252 batch mode. (Bug#11415)
4253
9e6b06ed
GM
42542012-05-12 Glenn Morris <rgm@gnu.org>
4255
4256 * ns.mk: Update for ns_appbindir no longer having trailing "/".
4257
c1a1d7a3
EZ
42582012-05-12 Eli Zaretskii <eliz@gnu.org>
4259
4260 * lisp.mk (lisp): Add newcomment.elc.
4261
3fe7cdc8
GM
42622012-05-12 Glenn Morris <rgm@gnu.org>
4263
4264 * Makefile.in (MKDIR_P): New, set by configure.
4265 * ns.mk (${ns_appdir}, ${ns_appbindir}Emacs): Use $MKDIR_P.
4266
53f7d2c0
PE
42672012-05-11 Paul Eggert <eggert@cs.ucla.edu>
4268
4269 Remove unused function hourglass_started.
4270 * dispextern.h (hourglass_started):
4271 * w32fns.c (hourglass_started):
4272 * xdisp.c (hourglass_started): Remove.
4273
75aafb17
JB
42742012-05-10 Juanma Barranquero <lekktu@gmail.com>
4275
4276 * makefile.w32-in ($(BLD)/gmalloc.$(O), $(BLD)/w32menu.$(O)):
4277 Update dependencies.
4278
12959e8e
PE
42792012-05-10 Paul Eggert <eggert@cs.ucla.edu>
4280
97107e2e
PE
4281 * xgselect.c (xg_select): Put maxfds+1 into a var.
4282 This is slightly clearer, and pacifies Ubuntu 12.04 gcc.
4283
12959e8e
PE
4284 * sound.c (DEFAULT_ALSA_SOUND_DEVICE): Define only if HAVE_ALSA.
4285
836d29b3
DA
42862012-05-10 Dave Abrahams <dave@boostpro.com>
4287
4288 * filelock.c (syms_of_filelock): New boolean create-lockfiles.
4289 (lock_file): If create_lockfiles is 0, do nothing. (Bug#11227)
4290
5cb67954
MA
42912012-05-09 Michael Albinus <michael.albinus@gmx.de>
4292
4293 * dbusbind.c (xd_registered_buses): New internal Lisp object.
4294 Rename all occurences of Vdbus_registered_buses to xd_registered_buses.
4295 (syms_of_dbusbind): Remove declaration of Vdbus_registered_buses.
4296 Initialize xd_registered_buses.
4297
3478ec45
PE
42982012-05-09 Paul Eggert <eggert@cs.ucla.edu>
4299
b263a6b0
PE
4300 Untag more efficiently if USE_LSB_TAG.
4301 This is based on a proposal by YAMAMOTO Mitsuharu in
4302 <http://lists.gnu.org/archive/html/emacs-devel/2008-01/msg01876.html>.
4303 For an admittedly artificial (nth 8000 longlist) benchmark on
4304 Fedora 15 x86-64, this yields a 25% CPU speedup. Also, it shrinks
4305 Emacs's overall text size by 1%.
4306 * lisp.h (XUNTAG): New macro.
4307 (XCONS, XVECTOR, XSTRING, XSYMBOL, XFLOAT, XMISC, XPROCESS, XWINDOW)
4308 (XTERMINAL, XSUBR, XBUFFER, XCHAR_TABLE, XSUB_CHAR_TABLE, XBOOL_VECTOR)
4309 (XSETTYPED_PSEUDOVECTOR, XHASH_TABLE, TYPED_PSEUDOVECTORP): Use it.
4310 * eval.c (Fautoload):
4311 * font.h (XFONT_SPEC, XFONT_ENTITY, XFONT_OBJECT):
4312 * frame.h (XFRAME): Use XUNTAG.
4313
3478ec45
PE
4314 Port recent dbusbind.c changes to 32-bit --with-wide-int.
4315 * dbusbind.c (xd_append_arg, xd_retrieve_arg, Fdbus_message_internal):
4316 Remove unportable assumptions about print widths of types like
4317 dbus_uint32_t.
4318 (xd_get_connection_address, Fdbus_init_bus): Cast Emacs integer to
4319 intptr_t when converting between pointer and integer, to avoid GCC
4320 warnings about wrong width.
4321
666b903b 43222012-05-09 Eli Zaretskii <eliz@gnu.org>
0d887c7d
EZ
4323
4324 * w32proc.c (new_child): Force Windows to reserve only 64KB of
4325 stack for each reader_thread, instead of defaulting to 8MB
4326 determined by the linker. This avoids failures in creating
4327 subprocesses on Windows 7, see the discussion in this thread:
4328 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
4329
b120cc17
JC
43302012-05-07 Jérémy Compostella <jeremy.compostella@gmail.com>
4331
4332 Fix up display of the *Minibuf-0* buffer in the mini window.
4333 * keyboard.c (read_char): Don't clear the echo area if there's no
4334 message to clear.
4335 * xdisp.c (redisplay_internal): Redisplay the mini window (with the
2fed2689 4336 contents of *Minibuf-0*) if there's no message displayed in its stead.
b120cc17 4337
9a4b36f8
MA
43382012-05-07 Michael Albinus <michael.albinus@gmx.de>
4339
4340 * dbusbind.c (XD_DEBUG_MESSAGE): Don't print message twice in
4341 batch mode.
4342
e5f9458f
CY
43432012-05-06 Chong Yidong <cyd@gnu.org>
4344
4345 * lisp.mk (lisp): Update.
4346
eceeb5fc 43472012-05-05 Jim Meyering <meyering@redhat.com>
bf98199c
JM
4348
4349 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
4350
71873e2b
SM
43512012-05-04 Stefan Monnier <monnier@iro.umontreal.ca>
4352
4353 * data.c (PUT_ERROR): New macro.
4354 (syms_of_data): Use it. Add new error type `user-error'.
4355 * undo.c (user_error): New function.
4356 (Fprimitive_undo): Use it.
4357 * print.c (print_error_message): Adjust print style for `user-error'.
4358 * keyboard.c (user_error): New function.
4359 (Fexit_recursive_edit, Fabort_recursive_edit): Use it.
4360
ab0fa4e4
PE
43612012-05-03 Paul Eggert <eggert@cs.ucla.edu>
4362
4363 Do not limit current-time-string to years 1000..9999.
4364 * editfns.c (TM_YEAR_IN_ASCTIME_RANGE): Remove.
4365 (Fcurrent_time_string): Support any year that is supported by the
4366 underlying localtime representation. Don't use asctime, as it
4367 has undefined behavior for years outside the range -999..9999.
4368
7ed806a7
PE
43692012-05-02 Paul Eggert <eggert@cs.ucla.edu>
4370
4371 Fix race conditions involving setenv, gmtime, localtime, asctime.
4372 Without this fix, interrupts could mess up code that uses these
4373 nonreentrant functions, since setting TZ invalidates existing
4374 tm_zone or tzname values, and since most of these functions return
4375 pointers to static storage.
4376 * editfns.c (format_time_string, Fdecode_time, Fencode_time)
4377 (Fcurrent_time_string, Fcurrent_time_zone, Fset_time_zone_rule):
4378 Grow the critical sections to include not just invoking
4379 localtime/gmtime, but also accessing these functions' results
4380 including their tm_zone values if any, and any related TZ setting.
4381 (format_time_string): Last arg is now struct tm *, not struct tm **,
71873e2b
SM
4382 so that the struct tm is saved in the critical section.
4383 All callers changed. Simplify allocation of initial buffer, partly
7ed806a7
PE
4384 motivated by the fact that memory allocation needs to be outside
4385 the critical section.
4386
0c16dfed
DA
43872012-05-02 Dmitry Antipov <dmantipov@yandex.ru>
4388
4389 * intervals.c (adjust_intervals_for_insertion): Initialize `newi'
4390 with RESET_INTERVAL.
4391
4392 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
4393 Remove duplicated buffer name initialization.
4394
3f83ace8
JM
43952012-05-02 Jim Meyering <jim@meyering.net>
4396
4397 * xterm.c (x_term_init): Use memcpy instead of strncpy (Bug#11373).
4398
c7b8541e
JM
4399 * xfns.c (x_window): Use xstrdup (Bug#11375).
4400
90207a15 44012012-05-02 Eli Zaretskii <eliz@gnu.org>
2fa85638
EZ
4402
4403 * xdisp.c (pos_visible_p): If already at a newline from the
4404 display string before the 'while' loop, don't walk back the glyphs
4405 from it3.glyph_row. Solves assertion violation when the display
4406 string begins with a newline (egg.el). (Bug#11367)
4407
b593d6a9
AH
44082012-05-01 Stefan Monnier <monnier@iro.umontreal.ca>
4409
4410 * keyboard.c (Fexecute_extended_command, Vsuggest_key_bindings):
4411 Move to simple.el.
4412
4737362e
GM
44132012-05-01 Glenn Morris <rgm@gnu.org>
4414
99cf43f9
GM
4415 * syssignal.h: Remove reference to BROKEN_SIGINFO (last used in
4416 s/ptx4.h), BROKEN_SIGTSTP (last used in m/ustation.h, m/dpx2.h),
4417 and BROKEN_SIGURG (was in s/gnu-linux.h prior to 2008-02-10).
4418 All were removed before 23.1.
4419
9311dcff
GM
4420 * dispnew.c: Remove HAVE_LIBNCURSES test;
4421 it is always true on relevant platforms.
4422
4d5c6349
GM
4423 * Makefile.in (LD_SWITCH_X_SITE_RPATH):
4424 Rename from LD_SWITCH_X_SITE_AUX_RPATH.
4425
4737362e
GM
4426 * Makefile.in (LD_SWITCH_X_SITE_AUX): Remove; no longer used.
4427
74dd3a6b
AS
44282012-04-30 Andreas Schwab <schwab@linux-m68k.org>
4429
4430 * .gdbinit (xpr): Remove checks for no longer existing misc types.
4431 (xintfwd, xboolfwd, xobjfwd, xbufobjfwd, xkbobjfwd, xbuflocal):
4432 Remove.
4433
13c379ee
PE
44342012-04-28 Paul Eggert <eggert@cs.ucla.edu>
4435
4436 Do not avoid creating empty evaporating overlays (Bug#9642).
4437 * buffer.c (Fmove_overlay): Revert the change of 2012-04-23.
4438 That is, do not delete an evaporating overlay if it becomes
4439 empty after its bounds are adjusted to fit within its buffer.
4440 This fix caused other problems, and I'm reverting it until we get
4441 to the bottom of them.
4442
a8e7d6d7 44432012-04-27 Chong Yidong <cyd@gnu.org>
9be2fd9b
CY
4444
4445 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
4446
a8e7d6d7 44472012-04-27 Eli Zaretskii <eliz@gnu.org>
f0ee99a0
EZ
4448
4449 * xdisp.c (pos_visible_p): If the window start position is beyond
4450 ZV, start the display from buffer beginning. Prevents assertion
4451 violation in init_iterator when the minibuffer window is scrolled
4452 via the scroll bar.
4453
4454 * window.c (window_scroll_pixel_based): Likewise.
4455
a8e7d6d7 44562012-04-27 Chong Yidong <cyd@gnu.org>
9ec7751f
CY
4457
4458 * keymap.c (where_is_internal): Doc fix (Bug#10872).
4459
a8e7d6d7 44602012-04-27 Glenn Morris <rgm@gnu.org>
24c51a09
GM
4461
4462 * fileio.c (Fcopy_file, Fset_file_selinux_context):
4463 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
4464
a8e7d6d7 44652012-04-27 Eli Zaretskii <eliz@gnu.org>
73055685 4466
b593d6a9
AH
4467 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers):
4468 Don't overrun array limits of glyph row's used[] array. (Bug#11288)
73055685 4469
1c6900d9
EZ
44702012-04-26 Eli Zaretskii <eliz@gnu.org>
4471
4c3fa1d9
EZ
4472 * xdisp.c (IT_DISPLAYING_WHITESPACE): In addition to the loaded
4473 display element, check also the underlying string or buffer
4474 character. (Bug#11341)
4475
1c6900d9
EZ
4476 * w32menu.c: Include w32heap.h.
4477 (add_menu_item): If the call to AppendMenuW (via
4478 unicode_append_menu) fails, disable Unicode menus only if we are
4479 running on Windows 9X/Me.
4480
42bf8205
AS
44812012-04-24 Andreas Schwab <schwab@linux-m68k.org>
4482
4483 * .gdbinit (xpr): Handle USE_2_TAGS_FOR_INTS.
4484 (xgetint): Add missing shift for LSB tags.
4485
b1bac16e
MR
44862012-04-24 Martin Rudalics <rudalics@gmx.at>
4487
4488 * keyboard.c (read_char): Don't wipe echo area for select window
4489 events: These might get delayed via `mouse-autoselect-window'
4490 (Bug#11304).
4491
d69621cc
JB
44922012-04-24 Juanma Barranquero <lekktu@gmail.com>
4493
4494 * gnutls.c (init_gnutls_functions): Protect against (unlikely)
4495 manipulation of :loaded-from data.
4496
02fd101b
JB
44972012-04-23 Juanma Barranquero <lekktu@gmail.com>
4498
4499 * gnutls.c (init_gnutls_functions): The value of :loaded-from is
4500 now a cons (bug#11311).
4501
888bec30
PE
45022012-04-23 Paul Eggert <eggert@cs.ucla.edu>
4503
89a438bd
PE
4504 Do not create empty overlays with the evaporate property (Bug#9642).
4505 * buffer.c (Fmove_overlay): Delete an evaporating overlay
4506 if it becomes empty after its bounds are adjusted to fit within
4507 its buffer. Without this fix, in a nonempty buffer (let ((o
4508 (make-overlay 1 2))) (overlay-put o 'evaporate t) (move-overlay o 0 1))
4509 yields an empty overlay that has the evaporate property, which is
4510 not supposed to happen.
4511
1068fe4d
PE
4512 Fix minor GTK3 problems found by static checking.
4513 * emacsgtkfixed.c (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4514 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4515 (struct _EmacsFixedClass, emacs_fixed_get_type):
4516 Move decls here from emacsgtkfixed.h, since they needn't be public.
4517 (emacs_fixed_get_type): Now static.
4518 (emacs_fixed_class_init): Omit unused local.
4519 (emacs_fixed_child_type): Remove; unused.
4520 * emacsgtkfixed.h (EMACS_TYPE_FIXED, EMACS_FIXED, EmacsFixed)
4521 (EmacsFixedPrivate, EmacsFixedClass, struct _EmacsFixed)
4522 (struct _EmacsFixedClass): Move to emacsgtkfixed.c.
4523 (EMACS_FIXED_CLASS, EMACS_IS_FIXED, EMACS_IS_FIXED_CLASS)
4524 (EMACS_FIXED_GET_CLASS): Remove; unused.
4525 * gtkutil.c (xg_create_frame_widgets) [!HAVE_GTK3]: Omit unused local.
4526
888bec30
PE
4527 * keyboard.c (handle_async_input): Define only if SYNC_INPUT || SIGIO.
4528 Problem reported by Juanma Barranquero for Windows -Wunused-function.
4529
de85e130
PE
45302012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4531
d0baac98 4532 Modernize and clean up gmalloc.c to assume C89 (Bug#9119).
bd7239f5 4533 * gmalloc.c (_MALLOC_INTERNAL, _MALLOC_H, _PP, __ptr_t)
d0baac98
PE
4534 (__malloc_size_t, __malloc_ptrdiff_t):
4535 Remove. All uses removed, replaced by the definiens if needed,
4536 since we can assume C89 or better now.
4537 Include <stdint.h>, for PTRDIFF_MAX, uintptr_t.
4538 (protect_malloc_state, align, get_contiguous_space)
4539 (malloc_atfork_handler_prepare, malloc_atfork_handler_parent)
4540 (malloc_atfork_handler_child, malloc_enable_thread)
4541 (malloc_initialize_1, __malloc_initialize, morecore_nolock)
4542 (_malloc_internal_nolock, _malloc_internal, malloc, _malloc)
4543 (_free, _realloc, _free_internal_nolock, _free_internal, free, cfree)
4544 (special_realloc, _realloc_internal_nolock, _realloc_internal)
4545 (realloc, calloc, __default_morecore, memalign, valloc, checkhdr)
4546 (freehook, mallochook, reallochook, mabort, mcheck, mprobe):
4547 Define using prototypes, not old style.
4548 (align, _malloc_internal_nolock, _free_internal_nolock, memalign):
4549 Don't assume ptrdiff_t and uintptr_t are no wider than unsigned long.
4550 (align): Don't assume that signed integer overflow wraps around.
4551 Omit unused local var.
4552 (malloc_initialize_1, morecore_nolock, _malloc_internal_nolock)
4553 (_free_internal_nolock, memalign, mallochook, reallochook):
4554 Omit no-longer-needed casts.
4555 (valloc): Use getpagesize, not __getpagesize.
4556 (MAGICWORD, MAGICFREE): Now randomish size_t values, not 32-bit.
4557 (struct hdr): The 'magic' member is now size_t, not unsigned long.
4558
de85e130
PE
4559 * dbusbind.c (XD_DBUS_VALIDATE_OBJECT): Define only if needed.
4560
dcbf5805
MA
45612012-04-22 Michael Albinus <michael.albinus@gmx.de>
4562
4563 Move functions from C to Lisp. Make non-blocking method calls
4564 the default. Implement further D-Bus standard interfaces.
4565
4566 * dbusbind.c (DBUS_NUM_MESSAGE_TYPES): Declare.
4567 (QCdbus_request_name_allow_replacement)
4568 (QCdbus_request_name_replace_existing)
4569 (QCdbus_request_name_do_not_queue)
4570 (QCdbus_request_name_reply_primary_owner)
4571 (QCdbus_request_name_reply_in_queue)
4572 (QCdbus_request_name_reply_exists)
4573 (QCdbus_request_name_reply_already_owner): Move to dbus.el.
4574 (QCdbus_registered_serial, QCdbus_registered_method)
4575 (QCdbus_registered_signal): New Lisp objects.
4576 (XD_DEBUG_MESSAGE): Use sizeof.
4577 (XD_MESSAGE_TYPE_TO_STRING, XD_OBJECT_TO_STRING)
4578 (XD_DBUS_VALIDATE_BUS_ADDRESS, XD_DBUS_VALIDATE_OBJECT)
4579 (XD_DBUS_VALIDATE_BUS_NAME, XD_DBUS_VALIDATE_PATH)
4580 (XD_DBUS_VALIDATE_INTERFACE, XD_DBUS_VALIDATE_MEMBER): New macros.
4581 (XD_CHECK_DBUS_SERIAL): Rename from CHECK_DBUS_SERIAL_GET_SERIAL.
4582 (xd_signature, xd_append_arg): Allow float for integer types.
4583 (xd_get_connection_references): New function.
b593d6a9
AH
4584 (xd_get_connection_address): Rename from xd_initialize.
4585 Return cached address.
dcbf5805
MA
4586 (xd_remove_watch): Do not unset $DBUS_SESSION_BUS_ADDRESS.
4587 (xd_close_bus): Rename from Fdbus_close_bus. Not needed on Lisp
4588 level.
4589 (Fdbus_init_bus): New optional arg PRIVATE. Cache address.
9a4b36f8 4590 Return number of refcounts.
dcbf5805
MA
4591 (Fdbus_get_unique_name): Make stronger parameter check.
4592 (Fdbus_message_internal): New defun.
4593 (Fdbus_call_method, Fdbus_call_method_asynchronously)
4594 (Fdbus_method_return_internal, Fdbus_method_error_internal)
4595 (Fdbus_send_signal, Fdbus_register_service)
4596 (Fdbus_register_signal, Fdbus_register_method): Move to dbus.el.
4597 (xd_read_message_1): Obey new structure of Vdbus_registered_objects.
4598 (xd_read_queued_messages): Obey new structure of Vdbus_registered_buses.
4599 (Vdbus_compiled_version, Vdbus_runtime_version)
4600 (Vdbus_message_type_invalid, Vdbus_message_type_method_call)
4601 (Vdbus_message_type_method_return, Vdbus_message_type_error)
4602 (Vdbus_message_type_signal): New defvars.
b593d6a9
AH
4603 (Vdbus_registered_buses, Vdbus_registered_objects_table):
4604 Adapt docstring.
dcbf5805 4605
52828e02
PE
46062012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4607
da05bc4c
PE
4608 Fix GC_MALLOC_CHECK debugging output on 64-bit hosts.
4609 * alloc.c (emacs_blocked_malloc) [GC_MALLOC_CHECK]:
4610 Do not assume ptrdiff_t is the same width as 'int'.
4611
52828e02
PE
4612 * alloc.c: Handle unusual debugging option combinations.
4613 (GC_CHECK_MARKED_OBJECTS): Undef if ! GC_MARK_STACK,
4614 since the two debugging options are incompatible.
4615 (GC_MALLOC_CHECK): Similarly, undef if GC_CHECK_MARKED_OBJECTS
4616 is defined.
4617 (mem_init, mem_insert, mem_insert_fixup):
4618 Define if GC_MARK_STACK || GC_MALLOC_CHECK.
4619 (NEED_MEM_INSERT): Remove; no longer needed.
4620
f01769f9
LL
46212012-04-22 Leo Liu <sdl.web@gmail.com>
4622
4623 * sysdep.c (list_system_processes): Support Darwin (Bug#5725).
4624
5790543d
PE
46252012-04-22 Paul Eggert <eggert@cs.ucla.edu>
4626
4627 * sysdep.c [__FreeBSD__]: Minor cleanups.
4628 (list_system_processes, system_process_attributes) [__FreeBSD__]:
4629 Use Emacs indenting style more consistently. Avoid some casts.
4630 Use 'double' consistently rather than mixing 'float' and 'double'.
4631
b91b7e4d
EW
46322012-04-21 Eduard Wiebe <usenet@pusto.de>
4633
b593d6a9
AH
4634 * sysdep.c (list_system_processes, system_process_attributes):
4635 Add implementation for FreeBSD (Bug#5243).
b91b7e4d 4636
6114eb15
AS
46372012-04-21 Andreas Schwab <schwab@linux-m68k.org>
4638
4639 * lisp.mk (lisp): Update.
4640
2f38dff7
PE
46412012-04-20 Paul Eggert <eggert@cs.ucla.edu>
4642
4643 * keyboard.c (process_pending_signals): Define only if SYNC_INPUT.
4644 It is never used otherwise.
4645
4ae29f89
SM
46462012-04-20 Stefan Monnier <monnier@iro.umontreal.ca>
4647
4648 * print.c (print_preprocess): Only check print_depth if print-circle
4649 is nil.
4650 (print_object): Check for cycles even when print-circle is nil and
4651 print-gensym is t, but only check print_depth if print-circle is nil.
4652
f30d612a
CY
46532012-04-20 Chong Yidong <cyd@gnu.org>
4654
4655 * process.c (wait_reading_process_output): If EIO occurs on a pty,
4656 set the status to "failed" and ensure that sentinel is run.
4657
c07a4c0b 46582012-04-20 Glenn Morris <rgm@gnu.org>
016a35df
GM
4659
4660 * process.c (Fset_process_inherit_coding_system_flag)
4661 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 4662 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 4663
c07a4c0b 46642012-04-20 Eli Zaretskii <eliz@gnu.org>
20a68157
EZ
4665
4666 * xdisp.c (string_buffer_position_lim): Limit starting position to
4667 BEGV.
4668 (set_cursor_from_row): If called for a mode-line or header-line
4669 row, return zero immediately.
4670 (try_cursor_movement): If inside continuation line, don't back up
4ae29f89
SM
4671 farther than the first row after the header line, if any.
4672 Don't consider the header-line row as "partially visible", even if
20a68157
EZ
4673 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
4674
c07a4c0b 46752012-04-20 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4676
4ae29f89
SM
4677 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n"
4678 (bug#11238).
ad3a2b41 4679
c07a4c0b 46802012-04-20 Teodor Zlatanov <tzz@lifelogs.com>
6c94c34f 46812012-04-18 Paul Eggert <eggert@cs.ucla.edu>
ae6e112d
PE
4682
4683 configure: new option --enable-gcc-warnings (Bug#11207)
4684 * Makefile.in (C_WARNINGS_SWITCH): Remove.
4685 (WARN_CFLAGS, WERROR_CFLAGS): New macros.
4686 (ALL_CFLAGS): Use new macros rather than old.
4687 * process.c: Ignore -Wstrict-overflow to work around GCC bug 52904.
4688 * regex.c: Ignore -Wstrict-overflow. If !emacs, also ignore
4689 -Wunused-but-set-variable, -Wunused-function, -Wunused-macros,
4690 -Wunused-result, -Wunused-variable. This should go away once
4691 the Emacs and Gnulib regex code is merged.
4692 (xmalloc, xrealloc): Now static.
4693
aba027e8
PE
46942012-04-17 Paul Eggert <eggert@cs.ucla.edu>
4695
4696 * dired.c (Fsystem_groups): Remove unused local.
4697
e5a36063
GM
46982012-04-17 Glenn Morris <rgm@gnu.org>
4699
4700 * dired.c (Fsystem_users): Doc fix.
4701
316411f0
DA
47022012-04-17 Dmitry Antipov <dmantipov@yandex.ru>
4703
4704 * dired.c (Fsystem_users, Fsystem_groups): New functions. (Bug#7900)
4705 (syms_of_dired): Add them.
4706
9426aba4
PE
47072012-04-16 Paul Eggert <eggert@cs.ucla.edu>
4708
b62a57be
PE
4709 Fix minor alloc.c problems found by static checking.
4710 * alloc.c (_malloc_internal, _free_internal) [!DOUG_LEA_MALLOC]:
4711 New extern decls, to avoid calling undeclared functions.
4712 (dont_register_blocks): Define if ((!SYSTEM_MALLOC && !SYNC_INPUT)
4713 && GC_MALLOC_CHECK), not if ((GC_MARK_STACK || defined
4714 GC_MALLOC_CHECK) && GC_MALLOC_CHECK), to match when it's used.
4715 (NEED_MEM_INSERT): New macro.
4716 (mem_insert, mem_insert_fixup) [!NEED_MEM_INSERT]: Remove; unused.
4b5afbb0 4717 Remove one incorrect comment and fix another.
b62a57be 4718
3539f31f
PE
4719 Fix minor ralloc.c problems found by static checking.
4720 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4721 * ralloc.c (ALIGNED, ROUND_TO_PAGE, HEAP_PTR_SIZE)
4722 (r_alloc_size_in_use, r_alloc_freeze, r_alloc_thaw): Remove; unused.
4723 (r_alloc_sbrk): Now static.
4724
a041960a
PE
4725 Improve ralloc.c interface checking.
4726 See http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00720.html
4727 * buffer.c (ralloc_reset_variable, r_alloc, r_re_alloc)
4728 (r_alloc_free) [REL_ALLOC]: Move decls from here ...
4729 * lisp.h (r_alloc, r_alloc_free, r_re_alloc, r_alloc_reset_variable)
4730 [REL_ALLOC]: ... to here, to check interface.
4731 * m/ia64.h (r_alloc, r_alloc_free) [REL_ALLOC && !_MALLOC_INTERNAL]:
4732 Remove decls. This fixes an "It stinks!".
4733
9426aba4
PE
4734 * alloc.c (which_symbols): Fix alignment issue / type clash.
4735
d55c12ed
AS
47362012-04-15 Andreas Schwab <schwab@linux-m68k.org>
4737
4738 * lisp.h (struct Lisp_Symbol): Remove explicit padding.
4739 (struct Lisp_Misc_Any): Likewise.
4740 (struct Lisp_Free): Likewise.
4741 * alloc.c (union aligned_Lisp_Symbol): Define.
4742 (SYMBOL_BLOCK_SIZE, struct symbol_block): Use union
4743 aligned_Lisp_Symbol instead of struct Lisp_Symbol.
4744 (union aligned_Lisp_Misc): Define.
4745 (MARKER_BLOCK_SIZE, struct marker_block): Use union
4746 aligned_Lisp_Misc instead of union Lisp_Misc.
4ae29f89 4747 (Fmake_symbol, allocate_misc, gc_sweep): Adjust.
d55c12ed 4748
b948ce8b
PE
47492012-04-14 Paul Eggert <eggert@cs.ucla.edu>
4750
4751 Make GC_MAKE_GCPROS_NOOPS the default (Bug#9926).
4752 * lisp.h (GC_MARK_STACK): Default to GC_MAKE_GCPROS_NOOPS.
4753 * s/cygwin.h, s/darwin.h, s/freebsd.h, s/gnu.h, s/irix6-5.h, s/msdos.h:
4754 * s/netbsd.h, s/sol2-6.h:
4755 Remove definition of GC_MARK_STACK, since the default now works.
4756 * s/aix4-2.h, s/hpux10-20.h, s/unixware.h:
4757 Define GC_MARK_STACK to GC_USE_GCPROS_AS_BEFORE, since that's
4758 no longer the default.
4759 * s/gnu-linux.h (GC_MARK_STACK): Adjust to change in default.
4760
35dc09a1 47612012-04-14 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
ad3a2b41 4762
35dc09a1
GM
4763 * lread.c (lisp_file_lexically_bound_p):
4764 Fix hang at ";-*-\n" (bug#11238).
ad3a2b41 4765
35dc09a1
GM
47662012-04-14 Eli Zaretskii <eliz@gnu.org>
4767
4768 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
4769 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
4770
47712012-04-14 Jan Djärv <jan.h.d@swipnet.se>
4772
4773 * nsterm.m (constrainFrameRect): Always constrain when there is only
4774 one screen (Bug#10962).
4775
bcd86815
KB
47762012-04-13 Ken Brown <kbrown@cornell.edu>
4777
4778 * s/cygwin.h (PTY_OPEN): Don't try to close a bogus file descriptor.
4779
c25df26e
RT
47802012-04-13 Reuben Thomas <rrt@sc3d.org>
4781
4782 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4783
0fc59f1e
DC
47842012-04-11 Daniel Colascione <dancol@dancol.org>
4785
4786 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
4787 against is gone. It's better to use vfork now so that when Cygwin
4788 gains a new, working vfork, we use it automatically (bug#10398).
4789
de8c03dc
SM
47902012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4791
4792 * window.c (save_window_save): Obey window-point-insertion-type.
4793
2f097256
GM
47942012-04-11 Glenn Morris <rgm@gnu.org>
4795
4796 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
4797
453b951e
SM
47982012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
4799
4800 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
4801
75f1671a 48022012-04-10 Jason S. Cornez <jcornez@ravenpack.com> (tiny change)
6bbef4e5
JC
4803
4804 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
4805 (force_quit_count): New var.
4806 (handle_interrupt): Use it.
4807
2a8ce227
JB
48082012-04-10 Juanma Barranquero <lekktu@gmail.com>
4809
4810 * w32.c (w32_delayed_load): Record the full path of the library
4811 being loaded (bug#10424).
4812
935396c0
GM
48132012-04-09 Glenn Morris <rgm@gnu.org>
4814
05920a43
GM
4815 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
4816 not just in the obarray, before snarfing them. (Bug#11036)
4817
935396c0
GM
4818 * Makefile.in ($(leimdir)/leim-list.el):
4819 Pass EMACS rather than BUILT_EMACS.
4820
a18ecafa
TZ
48212012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
4822
4823 * process.c (make_process):
4824 * process.h: Add integer `gnutls_handshakes_tried' member to
4825 process struct.
4826
6bbef4e5
JC
4827 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
4828 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
4829
4830 * gnutls.c (gnutls_log_function2i): Convenience log function.
4831 (emacs_gnutls_read): Use new log functions,
4832 `gnutls_handshakes_tried' process member, and
4833 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
4834 attempts per process (connection).
4835
b4d3bc10
CY
48362012-04-09 Chong Yidong <cyd@gnu.org>
4837
4838 * eval.c (Fuser_variable_p, user_variable_p_eh)
4839 (lisp_indirect_variable): Functions deleted.
4840 (Fdefvar): Caller changed.
4841
4842 * callint.c (Finteractive, Fcall_interactively):
4843 * minibuf.c (Fread_variable): Callers changed.
4844
70f4d973
EZ
48452012-04-09 Eli Zaretskii <eliz@gnu.org>
4846
4847 * xdisp.c (set_cursor_from_row): If the display string appears in
4848 the buffer at position that is closer to point than the position
4849 after the display string, display the cursor on the first glyph of
4850 the display string. Fixes cursor display when a 'display' text
4851 property immediately follows invisible text. (Bug#11094)
4852
cb3c2e3e
PE
48532012-04-09 Paul Eggert <eggert@cs.ucla.edu>
4854
4855 composite.c: use 'double' consistently
4856 * composite.c (get_composition_id): Use 'double' consistently
4857 instead of converting 'float' to 'double' and vice versa; this is
4858 easier to understand and avoids a GCC warning.
4859
fd06db5d
GM
48602012-04-09 Glenn Morris <rgm@gnu.org>
4861
50fe702a
GM
4862 * Makefile.in: Generate leim-list with bootstrap-emacs, in
4863 preparation for dumping it with emacs. (Bug#4789)
4864 (leimdir): New variable.
4865 ($(leimdir)/leim-list.el): New rule.
4866 (emacs$(EXEEXT)): Depend on leim-list.el.
4867
fd06db5d
GM
4868 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
4869 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
4870 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
4871
55c131ee
AS
48722012-04-08 Andreas Schwab <schwab@linux-m68k.org>
4873
4874 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
4875 proper alignment.
4876
9209588f
JB
48772012-04-07 Juanma Barranquero <lekktu@gmail.com>
4878
4879 * xml.c (init_libxml2_functions) [WINDOWSNT]:
4880 Remove unused local variable.
4881
e3fb2efb
PE
48822012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4883
4884 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
4885 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
4886 (mark_memory): Mark Lisp_Objects only if pointers might hide in
4887 objects, as mark_maybe_pointer will catch them otherwise.
4888 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
4889 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
4890
b5385551
PE
48912012-04-07 Paul Eggert <eggert@cs.ucla.edu>
4892
4893 Fix typo that broke non-Windows builds.
4894 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
4895
9078ead6
EZ
48962012-04-07 Eli Zaretskii <eliz@gnu.org>
4897
4898 Support building on MS-Windows with libxml2.
4899
4900 * makefile.w32-in (OBJ2): Add xml.$(O).
4901 (GLOBAL_SOURCES): Add xml.c.
4902 ($(BLD)/xml.$(O)): New dependency list.
4903
4904 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
4905 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
4906 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
4907 [!WINDOWSNT]: New macros.
4908 (init_libxml2_functions, libxml2_loaded_p): New functions.
4909 (parse_region): Call fn_xmlCheckVersion instead of using the macro
4910 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
4911 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
4912 Calls xmlCleanupParser only if libxml2 was loaded (or statically
4913 linked in).
6bbef4e5
JC
4914 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
4915 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
4916 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
4917
4918 * emacs.c: Don't include libxml/parser.h.
4919 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
4920 xmlCleanupParser directly.
4921
4922 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
4923
3811fdf3
EZ
49242012-04-07 Eli Zaretskii <eliz@gnu.org>
4925
4926 * indent.c (Fvertical_motion): If there is a display string at
4927 point, use it.vpos to compute how many lines to backtrack after
4928 move_it_to point. (Bug#11133)
4929
2f8e16b2
EZ
49302012-04-06 Eli Zaretskii <eliz@gnu.org>
4931
4932 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
4933 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
4934 about subtle differences between FETCH_CHAR* and STRING_CHAR*
4935 macros related to unification of CJK characters. For the details,
4936 see the discussion following the message here:
4937 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
4938
3d439cd1
CY
49392012-04-04 Chong Yidong <cyd@gnu.org>
4940
4941 * keyboard.c (Vdelayed_warnings_list): Doc fix.
4942
8bc53d00
EZ
49432012-04-01 Eli Zaretskii <eliz@gnu.org>
4944
4945 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
4946 instead of alloca. (Bug#11138)
4947
3b0512a3
AS
49482012-04-01 Andreas Schwab <schwab@linux-m68k.org>
4949
4950 * w32menu.c (is_simple_dialog): Properly check lisp types.
4951 (Bug#11141)
4952
8427ddd2
EZ
49532012-03-31 Eli Zaretskii <eliz@gnu.org>
4954
979022ef
EZ
4955 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
4956 position we get to after a call to move_it_to fails the
4957 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
4958 only if we wind up in a string from display property. (Bug#11063)
4959
a6b1c7cc
EZ
4960 * window.c (Fdelete_other_windows_internal): Invalidate the row
4961 and column information about mouse highlight, so that redisplay
4962 restores it after reallocating the glyph matrices. (Bug#7464)
4963
8427ddd2
EZ
4964 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
4965 string comes from a `display' text property, use the buffer
4966 position of that property as if we actually saw that position in
4967 the row's glyphs.
697ba24b
EZ
4968 (move_it_by_lines): Remove the assertion that
4969 "it->current_x == 0 && it->hpos == 0" which can be legitimately
4970 violated when there's a before-string at the beginning of a line.
4971 (Bug#11063)
8427ddd2 4972
65a0a738
EZ
49732012-03-30 Eli Zaretskii <eliz@gnu.org>
4974
4975 * xdisp.c (append_space_for_newline): If the default face was
4976 remapped, use the remapped face for the appended newline.
4977 (extend_face_to_end_of_line): Use the remapped default face for
4978 extending the face to the end of the line.
4979 (display_line): Call extend_face_to_end_of_line when the default
4980 face was remapped. (Bug#11068)
4981
581355cc
EZ
49822012-03-29 Eli Zaretskii <eliz@gnu.org>
4983
4984 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
4985
e8fc049f
SM
49862012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
4987
4988 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
4989
4fb9a543
GM
49902012-03-27 Glenn Morris <rgm@gnu.org>
4991
4992 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
4993 Doc fixes.
4994
679910f1
KH
49952012-03-26 Kenichi Handa <handa@m17n.org>
4996
4997 * dispextern.h (struct glyph): Fix previous change. Change the
4998 bit length of glyphless.ch to 25 (Bug#11082).
4999
90d49b7f
CY
50002012-03-26 Chong Yidong <cyd@gnu.org>
5001
5002 * keyboard.c (Vselection_inhibit_update_commands): New variable.
5003 (command_loop_1): Use it; inhibit selection update for
5004 handle-select-window too (Bug#8996).
5005
f514f6f0
FP
50062012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
5007
e8fc049f 5008 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 5009
bf43fa51
KH
50102012-03-25 Kenichi Handa <handa@m17n.org>
5011
5012 * dispextern.h (struct glyph): Change the bit length of
5013 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
5014
8a0c01dd
EZ
50152012-03-24 Eli Zaretskii <eliz@gnu.org>
5016
5017 * s/ms-w32.h (tzname): Include time.h before redirecting to
5018 _tzname. Fixes the MSVC build. (Bug#9960)
5019
7d1c3a76
AS
50202012-03-24 Andreas Schwab <schwab@linux-m68k.org>
5021
8ed79523
AS
5022 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
5023 characters.
5024
7d1c3a76
AS
5025 * xterm.c (XTread_socket): Only modify handling_signal if
5026 !SYNC_INPUT. (Bug#11080)
5027
e99a9b8b
EZ
50282012-03-23 Eli Zaretskii <eliz@gnu.org>
5029
5030 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
5031 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
5032 when fetching a multibyte character consumes more bytes than
5033 CHAR_BYTES returns, due to unification of CJK characters in
5034 string_char. (Bug#11073)
5035
5063c0e1
TN
50362012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
5037
5038 * process.c (wait_reading_process_output): Handle pty disconnect
5039 by refraining from sending oneself a SIGCHLD (bug#10933).
5040
9f851fbd
CY
50412012-03-22 Chong Yidong <cyd@gnu.org>
5042
5043 * dispextern.h (struct it): New member string_from_prefix_prop_p.
5044
5063c0e1 5045 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
5046 Mark string as coming from a prefix property.
5047 (handle_face_prop): Use default face for prefix strings (Bug#4281).
5048 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
5049
fb5b8aca
CY
50502012-03-21 Chong Yidong <cyd@gnu.org>
5051
5052 * xfaces.c (Vface_remapping_alist): Doc fix.
5053
62356a1b
EZ
50542012-03-20 Eli Zaretskii <eliz@gnu.org>
5055
5056 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
5057 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
5058 Doc fixes.
62356a1b 5059
025de85b
CY
50602012-03-20 Chong Yidong <cyd@gnu.org>
5061
5062 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
5063 to reflect default non-nil value of redisplay-dont-pause.
5064
4827f94e
KH
50652012-03-19 Kenichi Handa <handa@m17n.org>
5066
5067 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
5068 it fit in a valid range (Bug#11003).
5069
e50a24a2
EZ
50702012-03-18 Eli Zaretskii <eliz@gnu.org>
5071
5072 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
5073 that is not from display property, accept the row as a "cursor
5074 row" if one of the string's character has a non-nil `cursor'
5075 property. Fixes cursor positioning when there are newlines in
5076 overlay strings, e.g. in icomplete.el. (Bug#11035)
5077
9af5ed87
PE
50782012-03-12 Paul Eggert <eggert@cs.ucla.edu>
5079
5080 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
5081
d1f55f16
CY
50822012-03-12 Chong Yidong <cyd@gnu.org>
5083
5084 * eval.c (inhibit_lisp_code): Rename from
5085 inhibit_window_configuration_change_hook; move from window.c.
5086
5087 * xfns.c (unwind_create_frame_1, Fx_create_frame):
5088 * window.c (run_window_configuration_change_hook)
5089 (syms_of_window): Callers changed.
5090
66c5eebd
CY
50912012-03-11 Chong Yidong <cyd@gnu.org>
5092
413df973
CY
5093 * keymap.c (Fkey_description): Doc fix (Bug#9700).
5094
66c5eebd
CY
5095 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
5096
1de11f56
CY
50972012-03-10 Chong Yidong <cyd@gnu.org>
5098
5099 * frame.c (other_visible_frames): Don't assume the selected frame
5100 is visible (Bug#10955).
5101
cae07000
SM
51022012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
5103
5104 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
5105
89c94350
JD
51062012-03-08 Jan Djärv <jan.h.d@swipnet.se>
5107
5108 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
5109 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
5110 zero (Bug#10954).
5111
999dd333
GM
51122012-03-03 Glenn Morris <rgm@gnu.org>
5113
01a6dcc8 5114 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 5115
de0100f2
EZ
51162012-03-02 Eli Zaretskii <eliz@gnu.org>
5117
5118 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
5119 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
5120 (redisplay_window, next_element_from_string): Fix typos in
5121 comments.
3e441275
EZ
5122 (redisplay_window): Pass to move_it_vertically the margin in
5123 pixels, not in screen lines.
de0100f2 5124
96a72ee9
GM
51252012-03-02 Glenn Morris <rgm@gnu.org>
5126
5127 * buffer.c (buffer-list-update-hook): Doc fix.
5128
312508d7
EZ
51292012-02-29 Eli Zaretskii <eliz@gnu.org>
5130
5131 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
5132 push_it before setting up the iterator for the first overlay
5133 string, even if we have an empty string loaded.
5134 (next_overlay_string): If there's an empty string on the iterator
5135 stack, pop the stack. (Bug#10903)
5136
27f3c637
PE
51372012-02-25 Paul Eggert <eggert@cs.ucla.edu>
5138
5139 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
5140 Suggested by Stefan Monnier in
5141 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
5142 * alloc.c (widen_to_Lisp_Object): New static function.
5143 (mark_memory): Also mark Lisp_Objects by fetching pointer words
5144 and widening them to Lisp_Objects. This would work even if
5145 USE_LSB_TAG is defined and wide integers are used, which might
5146 happen in a future version of Emacs.
5147
3c9dfce6
CY
51482012-02-25 Chong Yidong <cyd@gnu.org>
5149
fa74b241
CY
5150 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
5151 Doc fix.
5152
3c9dfce6
CY
5153 * xselect.c (Fx_selection_exists_p): Doc fix.
5154 (x_clipboard_manager_save_all): Print an informative message
5155 before saving to clipboard manager.
5156
9486df08
CY
51572012-02-24 Chong Yidong <cyd@gnu.org>
5158
5159 * keyboard.c (process_special_events): Handle all X selection
5160 requests in kbd_buffer, not just the next one (Bug#8869).
5161
f01d3321
CY
51622012-02-23 Chong Yidong <cyd@gnu.org>
5163
5164 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
5165 call when setting menu-bar-lines and tool-bar-lines parameters.
5166 (unwind_create_frame_1): New helper function.
5167
5168 * window.c (inhibit_window_configuration_change_hook): New var.
5169 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 5170 (syms_of_window): Initialize it.
f01d3321 5171
86b847b6
CY
51722012-02-22 Chong Yidong <cyd@gnu.org>
5173
5174 * xterm.c (x_draw_image_relief): Add missing type check for
5175 Vtool_bar_button_margin (Bug#10743).
5176
a59225b1
CY
51772012-02-21 Chong Yidong <cyd@gnu.org>
5178
5179 * fileio.c (Vfile_name_handler_alist): Doc fix.
5180
5181 * buffer.c (Fget_file_buffer): Protect against invalid file
5182 handler return value.
5183
310f5bd4
PE
51842012-02-20 Paul Eggert <eggert@cs.ucla.edu>
5185
cb3a28cc
PE
5186 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
5187 when computing $valmask.
5188
310f5bd4
PE
5189 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
5190 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
5191 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
5192 It's useless in that case, and it can cause problems on hosts
5193 that allocate halves of EMACS_INT values separately.
5194 Reported by Dan Horák. Diagnosed by Andreas Schwab in
5195 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
5196 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
5197 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
5198 it avoids undefined behavior on hosts where shifting right by more
5199 than the word width has undefined behavior.
5200
2375c96a
CY
52012012-02-19 Chong Yidong <cyd@gnu.org>
5202
5203 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
5204 (Funhandled_file_name_directory, Ffile_name_as_directory)
5205 (Fdirectory_file_name, Fexpand_file_name)
5206 (Fsubstitute_in_file_name): Protect against invalid file handler
5207 return values (Bug#10845).
5208
3eb49e71
EZ
52092012-02-18 Eli Zaretskii <eliz@gnu.org>
5210
5211 * .gdbinit (pitx): Fix incorrect references to fields of the
5212 iterator stack.
5213
7b926f3f
CY
52142012-02-17 Chong Yidong <cyd@gnu.org>
5215
5216 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
5217
11273115
PE
52182012-02-15 Paul Eggert <eggert@cs.ucla.edu>
5219
5220 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
5221 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
5222
c3a70e2b
CY
52232012-02-15 Chong Yidong <cyd@gnu.org>
5224
5225 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
5226 marked as special. Also, starting docstrings with * is obsolete.
5227
0ca43699
AS
52282012-02-13 Andreas Schwab <schwab@linux-m68k.org>
5229
5230 * gnutls.c (emacs_gnutls_write): Fix last change.
5231
2e8f3c56
LI
52322012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
5233
5234 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
5235 send_process.
5236
af70074f
SM
52372012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
5238
5239 * keymap.c (Fsingle_key_description): Handle char ranges.
5240
95986d52
CY
52412012-02-12 Chong Yidong <cyd@gnu.org>
5242
afd83bd1
CY
5243 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
5244 as that creates a dangerous corner case.
5245
95986d52
CY
5246 * window.c (Fdelete_window_internal): Invalidate the mouse
5247 highlight (Bug#9904).
5248
bd7da63e
GM
52492012-02-12 Glenn Morris <rgm@gnu.org>
5250
5251 * xselect.c (Fx_own_selection_internal)
5252 (Fx_get_selection_internal, Fx_disown_selection_internal)
5253 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
5254 * nsselect.m (Fx_own_selection_internal)
5255 (Fx_disown_selection_internal, Fx_selection_exists_p)
5256 (Fx_selection_owner_p, Fx_get_selection_internal):
5257 Sync docs and argument specs with the xselect.c versions.
5258
77abcbc2
LI
52592012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
5260
5261 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
5262
90b671e2
EZ
52632012-02-11 Eli Zaretskii <eliz@gnu.org>
5264
1c0ca0b7
EZ
5265 * w32select.c (Fx_selection_exists_p): Sync doc string and
5266 argument list with xselect.c. (Bug#10783)
5267
5268 * w16select.c (Fx_selection_exists_p): Sync doc string and
5269 argument list with xselect.c. (Bug#10783)
90b671e2 5270
49241268
GM
52712012-02-10 Glenn Morris <rgm@gnu.org>
5272
5273 * fns.c (Fsecure_hash): Doc fix.
5274
f998bbe7 52752012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
5276
5277 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
5278
0992bd9c
CY
52792012-02-07 Chong Yidong <cyd@gnu.org>
5280
5281 * buffer.c (Fbuffer_local_variables)
5282 (buffer_lisp_local_variables): Handle unbound vars correctly;
5283 don't let Qunbound leak into Lisp.
5284
af008560
GM
52852012-02-07 Glenn Morris <rgm@gnu.org>
5286
dd605cc4
GM
5287 * image.c (Fimagemagick_types): Doc fix.
5288
af008560
GM
5289 * image.c (imagemagick-render-type): Change it from a lisp object
5290 to an integer. Move the doc here from the lisp manual.
5291 Treat all values not equal to 0 the same.
5292
1449fa1d
CY
52932012-02-06 Chong Yidong <cyd@gnu.org>
5294
5295 * doc.c (store_function_docstring): Avoid applying docstring of
5296 alias to base function (Bug#2603).
5297
3723ec07
AS
52982012-02-04 Andreas Schwab <schwab@linux-m68k.org>
5299
5300 * .gdbinit (pp1, pv1): Remove redundant defines.
5301 (pr): Use pp.
5302
79c1cc1e
CY
53032012-02-04 Chong Yidong <cyd@gnu.org>
5304
5305 * nsterm.m: Declare a global (Bug#10694).
5306
d7f29f8e
EZ
53072012-02-04 Eli Zaretskii <eliz@gnu.org>
5308
cae07000
SM
5309 * w32.c (get_emacs_configuration_options):
5310 Include --enable-checking, if specified, in the return value.
d7f29f8e 5311
3b95a6f9
MR
53122012-02-04 Martin Rudalics <rudalics@gmx.at>
5313
5314 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
5315 after rounding frame sizes. (Bug#9723)
5316
d6fa96a6
EZ
53172012-02-04 Eli Zaretskii <eliz@gnu.org>
5318
5319 * keyboard.c (adjust_point_for_property): Don't position point
5320 before BEGV. (Bug#10696)
5321
df0b2940
PE
53222012-02-03 Paul Eggert <eggert@cs.ucla.edu>
5323
5324 Handle overflow when computing char display width (Bug#9496).
5325 * character.c (char_width): Return EMACS_INT, not int.
5326 (char_width, c_string_width): Check for overflow when
5327 computing the width; this is possible now that individual
5328 characters can have unbounded width. Problem introduced
5329 by merge from Emacs 23 on 2012-01-19.
5330
6bee44d6
MA
53312012-02-02 Michael Albinus <michael.albinus@gmx.de>
5332
5333 * dbusbind.c (Fdbus_register_method): Mention the return value
5334 :ignore in the docstring.
5335
44f92739
GM
53362012-02-02 Glenn Morris <rgm@gnu.org>
5337
1b9f60cc
GM
5338 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
5339
44f92739
GM
5340 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5341 Unconditionally set to t. (Bug#10673)
5342 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
5343 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
5344 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
5345
c5d3843c
KH
53462012-02-02 Kenichi Handa <handa@m17n.org>
5347
5348 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
5349 0, do not call append_composite_glyph.
5350
159462d4 53512012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
5352
5353 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
5354 NULL (Bug#6988).
5355 (x_produce_glyphs): If the component of a composition is a null
5356 string, set it->pixel_width to 1 to avoid zero-width glyph.
5357
78cef877
EZ
53582012-02-01 Eli Zaretskii <eliz@gnu.org>
5359
5360 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
5361 first 2 arguments are identical. This makes inserting large
5362 output from a subprocess an order of magnitude faster on
5363 MS-Windows, where all sbrk'ed memory is always contiguous.
5364
97897668
GM
53652012-01-31 Glenn Morris <rgm@gnu.org>
5366
5367 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 5368 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
5369 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
5370
31fd3586
GM
53712012-01-29 Glenn Morris <rgm@gnu.org>
5372
5373 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
5374
0e24a8b2
CY
53752012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
5376
5377 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
5378
cc0adcb0
CY
53792012-01-28 Chong Yidong <cyd@gnu.org>
5380
5381 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
5382
acc28cb9
CY
53832012-01-26 Chong Yidong <cyd@gnu.org>
5384
9c69cfb7
CY
5385 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
5386
acc28cb9
CY
5387 * search.c (Fsearch_forward, Fsearch_backward): Document negative
5388 repeat counts (Bug#10507).
5389
48da7392
GM
53902012-01-26 Glenn Morris <rgm@gnu.org>
5391
5392 * lread.c (syms_of_lread): Doc fix.
5393
14af5f7f
CY
53942012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
5395
5396 * coding.c (encode_designation_at_bol): Change return value to
5397 EMACS_INT.
5398
0b21c100
CY
53992012-01-25 Chong Yidong <cyd@gnu.org>
5400
5401 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
5402
3c2907f7
CY
54032012-01-21 Chong Yidong <cyd@gnu.org>
5404
5405 * floatfns.c (Fcopysign): Make the second argument non-optional,
5406 since nil is not allowed anyway.
5407
959ad23f
AS
54082012-01-21 Andreas Schwab <schwab@linux-m68k.org>
5409
5410 * process.c (read_process_output): Use p instead of XPROCESS (proc).
5411 (send_process): Likewise.
5412
34a02f46
MR
54132012-01-19 Martin Rudalics <rudalics@gmx.at>
5414
5415 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
5416 (Vwindow_persistent_parameters): Do not use Qstate.
5417 Rewrite doc-strings.
34a02f46 5418
1259009a 54192012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
5420
5421 * character.c (char_width): New function.
70d4fdf6
GM
5422 (Fchar_width, c_string_width, lisp_string_width):
5423 Use char_width (Bug#9496).
25ed9e61 5424
6a6ee00d
MR
54252012-01-16 Martin Rudalics <rudalics@gmx.at>
5426
5427 * window.c (Vwindow_persistent_parameters): New variable.
5428 (Fset_window_configuration, save_window_save): Handle persistent
5429 window parameters.
5430
c85efaf7
EZ
54312012-01-14 Eli Zaretskii <eliz@gnu.org>
5432
5433 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
5434 thrashing the stack of the thread. (Bug#9087)
5435
5944709e
PE
54362012-01-12 Paul Eggert <eggert@cs.ucla.edu>
5437
5438 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
5439
e71f5d99
EZ
54402012-01-11 Eli Zaretskii <eliz@gnu.org>
5441
5442 * xdisp.c (rows_from_pos_range): Handle the case where the
5443 highlight ends on a newline. (Bug#10464)
5444 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
5445 he end column for display of highlight that ends on a newline
5446 before a R2L line.
5447
ce316182
GM
54482012-01-11 Glenn Morris <rgm@gnu.org>
5449
5450 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
5451 from load-path also when installation-directory is nil. (Bug#10208)
5452
5b43da69
GM
54532012-01-10 Glenn Morris <rgm@gnu.org>
5454
74cc8ff9
GM
5455 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
5456
7d8d6e4e
GM
5457 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
5458 Update template values to be closer to their typical values these days.
5b43da69 5459
a0db8d43
EZ
54602012-01-09 Eli Zaretskii <eliz@gnu.org>
5461
5462 * xdisp.c (rows_from_pos_range): Accept additional argument
5463 DISP_STRING, and accept any glyph in a row whose object is that
5464 string as eligible for mouse highlight. Fixes mouse highlight of
5465 display strings from overlays. (Bug#10464)
5466
9a0115ab 54672012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 5468
b9110d6a 5469 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
5470 * fileio.c (auto_saving_dir_umask): New static var.
5471 (Fmake_directory_internal): Use it.
5472 (do_auto_save_make_dir): Set it, instead of invoking chmod after
5473 creating the directory. The old code temporarily assigns
5474 too-generous permissions to the directory.
5475 (do_auto_save_eh): Clear it.
b9110d6a 5476 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
5477 that the var is always cleared.
5478
6c1bd3f3
EZ
54792012-01-07 Eli Zaretskii <eliz@gnu.org>
5480
5481 * search.c (scan_buffer): Pass character positions to
5482 know_region_cache, not byte positions. (Bug#6540)
5483
069d2b50
L
54842012-01-07 LynX <_LynX@bk.ru> (tiny change)
5485
5486 * w32.c (sys_rename): Report EXDEV when rename of a directory
5487 fails because the target is on another logical disk. (Bug#10284)
5488
75bf0d33
DB
54892012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
5490
5491 * xterm.c (x_embed_request_focus): New function.
5492
5493 * xterm.h: Add prototype.
5494
5495 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
5496
1c6e5a32
GM
54972012-01-05 Glenn Morris <rgm@gnu.org>
5498
5499 * emacs.c (emacs_copyright): Update short copyright year to 2012.
5500
651e947e
EZ
55012012-01-01 Eli Zaretskii <eliz@gnu.org>
5502
5503 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
5504 Load gnutls_transport_set_lowat only if GnuTLS version is below
5505 2.11.1.
5506 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
5507 GnuTLS versions below 2.11.1.
5508
3778cdd8
AL
55092011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
5510
5511 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
5512 to the doc string advising against its use for altering the way
5513 windows are scrolled.
5514
0e5317f7
KH
55152011-12-28 Kenichi Handa <handa@m17n.org>
5516
5517 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
5518 coding-system ASCII compatible only when it does not produce BOM
5519 on encoding (Bug#10383).
5520
93d5ca1f
JD
55212011-12-26 Jan Djärv <jan.h.d@swipnet.se>
5522
5523 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
5524 can scroll.
5525 (create_and_show_popup_menu): Always use menu_position_func for
5526 Gtk3 (Bug#10361).
5527
ca22b785
AS
55282011-12-24 Andreas Schwab <schwab@linux-m68k.org>
5529
5530 * callint.c (Fcall_interactively): Don't truncate prompt string.
5531
d048e1e6
EZ
55322011-12-23 Eli Zaretskii <eliz@gnu.org>
5533
5534 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
5535 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 5536 resumed from there (after widening). (Bug#10360)
d048e1e6 5537
5ccaba1f
JD
55382011-12-22 Jan Djärv <jan.h.d@swipnet.se>
5539
5540 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
5541
204ee57f
JD
55422011-12-21 Jan Djärv <jan.h.d@swipnet.se>
5543
b81d40f0
JB
5544 * nsterm.m (x_free_frame_resources):
5545 Release f->output_data.ns->miniimage.
204ee57f
JD
5546 (ns_index_color): Fix indentation. Do not retain
5547 color_table->colors[i].
5548
5549 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
5550 before returning.
5551
5552 * nsfns.m (x_set_background_color): Assign return value from
5553 ns_index_color to face-background instead of NSColor*.
5554 (ns_implicitly_set_icon_type): Fix indentation.
5555 Change assignment in for loop to comparison.
5556
5557 * emacs.c (ns_pool): New variable.
5558 (main): Assign ns_pool.
5559 (Fkill_emacs): Call ns_release_autorelease_pool.
5560
5561 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
5562 autorelease fdesc, release fdAttrs and tdict.
5563 (ns_get_covering_families): Release charset.
5564 (ns_findfonts): Release NSFontDescriptor created with new.
5565 (ns_uni_to_glyphs): Fix indentation.
5566 (setString): Release attrStr before assigning new value.
5567
c803b2b7
JD
55682011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5569
678f4426
JD
5570 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
5571 and NS_IMPL_COCOA.
5572 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
5573 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
5574
cd394be1 55752011-12-18 David Reitter <reitter@cmu.edu>
678f4426 5576
5fecd5fc
JD
5577 * nsterm.m (ns_term_init): Subscribe for notifications
5578 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
5579 to method trackingNotification in EmacsMenu.
5580
5581 * nsmenu.m (trackingMenu): New variable.
3771cb17 5582 (trackingNotification): New method (from Aquamacs).
5fecd5fc 5583 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 5584 from Aquamacs (Bug#7030).
678f4426
JD
5585
55862011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 5587
c803b2b7
JD
5588 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
5589 (symbol_to_nsstring): Fix indentation.
5590 (ns_symbol_to_pb): New function.
cae07000
SM
5591 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
5592 (Fns_rotate_cut_buffers_internal): Remove.
5593 (Fns_store_selection_internal): Rename from
c803b2b7
JD
5594 Fns_store_cut_buffer_internal.
5595 (ns_get_foreign_selection, Fx_own_selection_internal)
5596 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
5597 (Fns_get_selection_internal, Fns_store_selection_internal):
5598 Use ns_symbol_to_pb and check if return value is nil.
5599 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
5600 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
5601 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
5602 renamed to Sns_store_selection_internal.
5603 (ns_handle_selection_request): Move code to Fx_own_selection_internal
5604 and remove this function.
5605 (ns_handle_selection_clear): Remove, never used.
5606 (Fx_own_selection_internal): Move code from ns_handle_selection_request
5607 here.
5608
e1b01a3a
KB
56092011-12-17 Ken Brown <kbrown@cornell.edu>
5610
5611 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
5612 GID is unknown (Bug#10257).
5613
2adb6e85
PE
56142011-12-17 Paul Eggert <eggert@cs.ucla.edu>
5615
5616 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
5617 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
5618 which caused a build failure on GNU/Linux IA-64. This problem was
5619 introduced by my 2011-10-07 patch.
5620
d1d7b339
JL
56212011-12-15 Juri Linkov <juri@jurta.org>
5622
5623 * image.c (imagemagick_error): New function. (Bug#10112)
5624 (imagemagick_load_image): Comment out `MagickSetResolution' call.
5625 Use `imagemagick_error' where ImageMagick functions return
5626 `MagickFalse'.
5627 (Fimagemagick_types): Add `Fnreverse' to return the list in the
5628 proper order.
5629
100d5755
KH
56302011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5631
5632 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
5633 fill background (Bug#8992).
5634
454592a6
MR
56352011-12-13 Martin Rudalics <rudalics@gmx.at>
5636
5637 * window.c (Vwindow_combination_resize)
5638 (Vwindow_combination_limit): Use t instead of non-nil in
5639 doc-strings.
61d4b438
MR
5640 (Vrecenter_redisplay): Add first sentence of doc-string on
5641 separate line.
53524d93 5642 (Frecenter): Fix doc-string typo.
454592a6 5643
3633e3aa
KH
56442011-12-11 Kenichi Handa <handa@m17n.org>
5645
5646 * coding.c (Funencodable_char_position): Pay attention to the
5647 buffer text relocation (Bug#9389).
5648
7b9d523a 56492011-12-10 Jan Djärv <jan.h.d@swipnet.se>
61ccba97 5650
7b9d523a
JD
5651 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
5652 gtk_init (Bug#10100).
5653
b73189c6
EZ
56542011-12-10 Eli Zaretskii <eliz@gnu.org>
5655
5656 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
5657 IT->string is nil. (Bug#10263)
5658
f7dfe5d6
JD
56592011-12-10 Jan Djärv <jan.h.d@swipnet.se>
5660
83faebb4
JD
5661 * nsterm.h (x_free_frame_resources): Declare.
5662
f7dfe5d6
JD
5663 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
5664 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
5665
5666 * nsterm.h (ns_get_defaults_value): Declare.
5667
5668 * nsterm.m (ns_default): Call ns_get_defaults_value.
5669
7cd4e72c
EZ
56702011-12-09 Eli Zaretskii <eliz@gnu.org>
5671
5672 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
5673 (Bug#10170)
5674
b34d7317
YM
56752011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5676
5677 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
5678 that where the value of an _OBJC_* symbol points to is in the .bss
5679 section (Bug#10240).
5680
76470ad1
KH
56812011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5682
5683 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 5684 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 5685
745fff94
KH
56862011-12-08 Kenichi Handa <handa@m17n.org>
5687
5688 * ftfont.c (get_adstyle_property): Fix previous change
5689 (Bug#10233).
5690
6e44397c
JB
56912011-12-07 Juanma Barranquero <lekktu@gmail.com>
5692
5693 * w32.c (init_environment): If no_site_lisp, remove site-lisp
5694 dirs from the default value of EMACSLOADPATH (bug#10208).
5695
7efa6272
GM
56962011-12-07 Glenn Morris <rgm@gnu.org>
5697
5698 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
5699 installation and source directories as well. (Bug#10208)
5700
f6fc4d87
CY
57012011-12-06 Chong Yidong <cyd@gnu.org>
5702
5703 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
5704
2bf26180
GM
57052011-12-06 Glenn Morris <rgm@gnu.org>
5706
5707 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
5708 as an error, not just -1. (Bug#10217)
5709
3a6ad4f0
CY
57102011-12-05 Chong Yidong <cyd@gnu.org>
5711
5712 * keyboard.c (process_special_events): New function.
5713 (swallow_events, Finput_pending_p): Use it (Bug#10195).
5714
75a3b399
PE
57152011-12-05 Paul Eggert <eggert@cs.ucla.edu>
5716
5717 * coding.c (encode_designation_at_bol): Don't use uninitialized
5718 local variable (Bug#9318).
5719
c3c9e25e
KH
57202011-12-05 Kenichi Handa <handa@m17n.org>
5721
5722 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
5723 return Qnil (Bug#8046, Bug#10193).
5724
5eb05ea3
KH
57252011-12-05 Kenichi Handa <handa@m17n.org>
5726
5727 * coding.c (encode_designation_at_bol): New args charbuf_end and
5728 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
5729 (coding_set_source): Return how many bytes coding->source was
5730 relocated.
5731 (coding_set_destination): Return how many bytes
5732 coding->destination was relocated.
5733 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 5734 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
5735
57362011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
5737
5738 * coding.c (CODING_CHAR_CHARSET_P): New macro.
5739 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
5740 macro (Bug#9318).
5741
57422011-12-05 Andreas Schwab <schwab@linux-m68k.org>
5743
5744 The following changes are to fix Bug#9318.
5745
a79703f5 5746 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
5747 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
5748 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 5749 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 5750
7dbda6df
JB
57512011-12-05 Juanma Barranquero <lekktu@gmail.com>
5752
5753 * lisp.h (process_quit_flag): Fix external declaration.
5754
6d5eb5b0
SM
57552011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
5756
5757 Don't macro-inline non-performance-critical code.
5758 * eval.c (process_quit_flag): New function.
5759 * lisp.h (QUIT): Use it.
5760
a0c3fad0
JD
57612011-12-04 Jan Djärv <jan.h.d@swipnet.se>
5762
5763 * nsfns.m (get_geometry_from_preferences): New function.
5764 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
5765
6c07aac2
AS
57662011-12-04 Andreas Schwab <schwab@linux-m68k.org>
5767
5768 * emacs.c (Qkill_emacs): Define.
5769 (syms_of_emacs): Initialize it.
5770 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
5771 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
5772 (quit_throw_to_read_char): Add parameter `from_signal'.
5773 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
5774 * lisp.h (QUIT): Call Fkill_emacs if requested.
5775
c052ead4
JD
57762011-12-03 Jan Djärv <jan.h.d@swipnet.se>
5777
5778 * widget.c (update_wm_hints): Return if wmshell is null.
5779 (widget_update_wm_size_hints): New function.
5780
5781 * widget.h (widget_update_wm_size_hints): Declare.
5782
5783 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
5784 widget_update_wm_size_hints (Bug#10104).
5785
9e49252b
EZ
57862011-12-03 Eli Zaretskii <eliz@gnu.org>
5787
5788 * xdisp.c (handle_invisible_prop): If the invisible text ends just
5789 before a newline, prepare the bidi iterator for consuming the
5790 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 5791 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 5792
02b16839
JL
57932011-12-02 Juri Linkov <juri@jurta.org>
5794
5795 * search.c (Fword_search_regexp): New Lisp function created from
5796 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
5797 (Fword_search_backward, Fword_search_forward)
5798 (Fword_search_backward_lax, Fword_search_forward_lax):
5799 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
5800 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
5801
0068070e
SM
58022011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
5803
5804 * fileio.c (Finsert_file_contents): Move after-change-function call
5805 to before the "handled:" label, since all "goto handled" appear in
5806 cases where the *-change-functions have already been properly called
5807 (bug#10117).
5808
3360a3fc
AS
58092011-12-01 Andreas Schwab <schwab@linux-m68k.org>
5810
5811 * keyboard.c (interrupt_signal): Don't call kill-emacs when
5812 waiting for input. (Bug#10169)
5813
73d6c093
EZ
58142011-11-30 Eli Zaretskii <eliz@gnu.org>
5815
5816 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
5817 verifies glyph row's hash code--we have just reallocated the
5818 glyphs, so their contents can be complete garbage. (Bug#10164)
5819
febe6bea
JB
58202011-11-30 Juanma Barranquero <lekktu@gmail.com>
5821
5822 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
5823
801a4313
EZ
58242011-11-30 Eli Zaretskii <eliz@gnu.org>
5825
5826 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
5827 attributes are tested _before_ calling verify_row_hash, to protect
5828 against GCC re-ordering of the tests. (Bug#10164)
5829
2b56b87e
JD
58302011-11-29 Jan Djärv <jan.h.d@swipnet.se>
5831
5832 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
5833
5834 * xterm.c (handle_one_xevent): Only set async_visible and friends
5835 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 5836 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
5837 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
5838
dbf31225
PE
58392011-11-28 Paul Eggert <eggert@cs.ucla.edu>
5840
5841 Remove GCPRO-related macros that exist only to avoid shadowing locals.
5842 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
5843 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
5844 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5845 All uses changed to use GCPRO1 etc.
5846 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
5847 Revert to old implementation (i.e., before 2011-03-11).
5848
1305621b
YM
58492011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
5850
5851 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
5852 of scroll runs so as to avoid assigning disabled bogus rows and
5853 unnecessary graphics copy operations.
5854
8c9afb46
EZ
58552011-11-27 Eli Zaretskii <eliz@gnu.org>
5856
5857 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
5858 (snprintf) [_MSC_VER]: Redirect to _snprintf.
5859 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
5860 (malloc, free, realloc, calloc): Redirect to e_* only when
5861 compiling Emacs.
5862
5863 * lisp.h (GCTYPEBITS): Move before first use.
5864 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
5865 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
5866 this macro definition.
5867
5868 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
5869 _MSC_VER.
5870
54e9e3bf
JD
58712011-11-27 Jan Djärv <jan.h.d@swipnet.se>
5872
6d5eb5b0
SM
5873 * gtkutil.c (xg_create_frame_widgets):
5874 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
5875 present with Gtk+ 2.0.
5876
83aca1cb
PE
58772011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5878
5879 * fileio.c (Finsert_file_contents): Undo previous change; see
5880 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
5881
5b76caa4
PE
58822011-11-26 Paul Eggert <eggert@cs.ucla.edu>
5883
5884 Rename locals to avoid shadowing.
5885 * fileio.c (Finsert_file_contents):
5886 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
5887 * process.c (wait_reading_process_output):
5888 Rename inner 'proc' to 'p' to avoid shadowing.
5889 Indent for consistency with usual Emacs style.
5890
8c535114
EZ
58912011-11-25 Eli Zaretskii <eliz@gnu.org>
5892
5893 * xdisp.c (redisplay_window): If cursor row is not fully visible
5894 after recentering, and scroll-conservatively is set to a large
5895 number, scroll window by a few more lines to make the cursor fully
5896 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
5897 (start_display): Don't move to the next line if the display should
5898 start at a newline that is part of a display vector or an overlay
5899 string. (Bug#10119)
8c535114 5900
fa4fdb5c
JL
59012011-11-24 Juri Linkov <juri@jurta.org>
5902
5903 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
5904 after the `MagickPingImage' call. (Bug#10112)
5905
90ec88df
CY
59062011-11-23 Chong Yidong <cyd@gnu.org>
5907
5908 * window.c (Fcoordinates_in_window_p): Accept only live windows.
5909
56e2e794
MR
59102011-11-23 Martin Rudalics <rudalics@gmx.at>
5911
5912 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
5913 making another buffer current. (Bug#10114)
5914
b6e64c41
GM
59152011-11-23 Glenn Morris <rgm@gnu.org>
5916
5917 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
5918
6b21de18
CY
59192011-11-23 Chong Yidong <cyd@gnu.org>
5920
5921 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
5922 using it (Bug#5984).
5923
b12cd789
EZ
59242011-11-22 Eli Zaretskii <eliz@gnu.org>
5925
5926 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
5927 and header-lines, as they don't have one computed for them.
5928 (Bug#10098)
5929
5930 * .gdbinit (prow): Make displayed values more self-explaining.
5931 Add row's hash code.
5932
261b6fd4
LMI
59332011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
5934
5935 * process.c (wait_reading_process_output): Fix asynchrounous
5936 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 5937 (wait_reading_process_output): Add comment and URL.
261b6fd4 5938
e7cfd277
JD
59392011-11-21 Jan Djärv <jan.h.d@swipnet.se>
5940
5941 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
5942
a9b9b7f5
CY
59432011-11-21 Chong Yidong <cyd@gnu.org>
5944
5945 * window.c (Fnext_window, Fprevious_window): Doc fix.
5946
b0d15b4f
SM
59472011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5948
5949 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
5950
fe7a3057
JB
59512011-11-20 Juanma Barranquero <lekktu@gmail.com>
5952
5953 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
5954
d2999b1a
MR
59552011-11-20 Martin Rudalics <rudalics@gmx.at>
5956
5957 * window.c (Fset_window_combination_limit): Rename argument
5958 STATUS to LIMIT.
5959 (Vwindow_combination_limit): Remove "status" from doc-string.
5960
d5ff9cd0
AS
59612011-11-20 Andreas Schwab <schwab@linux-m68k.org>
5962
5963 * m/ibms390.h: Remove.
5964 * m/ibms390x.h: Don't include "ibms390.h".
5965
a5bb9bd3
SM
59662011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
5967
5968 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
5969 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
5970
cd1181db
JB
59712011-11-20 Juanma Barranquero <lekktu@gmail.com>
5972
5973 * casetab.c (Fset_case_table):
5974 * charset.c (Fcharset_after): Fix typos.
5975
615a3b8d 59762011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 5977
17e845af
PE
5978 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
5979 Otherwise, valgrind does not work on some platforms.
5980 Problem reported by Andreas Schwab in
6a0bf43d
PE
5981 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
5982 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
5983 is set, removing the need for VIRT_ADDRESS_VARIES.
5984 (PURE_P): Use a more-efficient implementation that needs just one
5985 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
5986 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
5987 to 4 (xorl, subq, cmpq, setbe).
5988 * alloc.c (pure): Always extern now, since that's the
5989 VIRT_ADDR_VARIES behavior.
5990 (PURE_POINTER_P): Use a single comparison, not two, for
5991 consistency with the new puresize.h.
5992 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
5993 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
5994 Remove VIRT_ADDR_VARIES no longer needed.
5995
f8fe6f96
EZ
59962011-11-19 Eli Zaretskii <eliz@gnu.org>
5997
5998 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
5999 (erase_phys_cursor, update_window_cursor, show_mouse_face)
6000 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
6001 behave as if the cursor position were at the window margin.
6002
6003 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
6004 and the cursor position is out of bounds, behave as if the cursor
6005 position were at the window margin. (Bug#10075)
6006
df05a53c
CY
60072011-11-18 Chong Yidong <cyd@gnu.org>
6008
6009 * window.c (Fwindow_combination_limit): Make first argument
6010 non-optional, since it is meaningless for live windows like the
6011 selected window.
61ccba97 6012
2071918e
DA
60132011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
6014
6015 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
6016
b50a28de
SM
60172011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
6018
6019 * intervals.c: Fix grafting over the whole buffer (bug#10071).
6020 (graft_intervals_into_buffer): Simplify.
6021
015137db
EZ
60222011-11-18 Eli Zaretskii <eliz@gnu.org>
6023
6024 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
6025 hash values of the two rows.
6026 (copy_row_except_pointers): Preserve the used[] arrays and the
6027 hash values of the two rows. (Bug#10035)
68c95424 6028 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
6029
6030 * xdisp.c (row_hash): New function, body extracted from
6031 compute_line_metrics.
6032 (compute_line_metrics): Call row_hash, instead of computing the
6033 hash code inline.
6034
6035 * dispnew.c (verify_row_hash): Call row_hash for computing the
6036 hash code of a row, instead of duplicating code from xdisp.c.
6037
6038 * dispextern.h (row_hash): Add prototype.
6039
a2addb04
TH
60402011-11-18 Tassilo Horn <tassilo@member.fsf.org>
6041
6042 * frame.c (delete_frame): Don't delete the terminal when the last
6043 X frame is closed if emacs is built with GTK toolkit.
6044
df85d315
JB
60452011-11-17 Juanma Barranquero <lekktu@gmail.com>
6046
6047 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
6048
a0c2d0ae
MR
60492011-11-17 Martin Rudalics <rudalics@gmx.at>
6050
6051 * window.c (Vwindow_splits): Rename to
6052 Vwindow_combination_resize. Suggested by Juri Linkov.
6053 (Fsplit_window_internal): Use Vwindow_combination_resize instead
6054 of Vwindow_splits.
6055
58179cce
JB
60562011-11-16 Juanma Barranquero <lekktu@gmail.com>
6057
7877f373
JB
6058 * nsfns.m (Fns_font_name):
6059 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 6060
b6f67890
MR
60612011-11-16 Martin Rudalics <rudalics@gmx.at>
6062
6063 * window.h (window): Rename slot "nest" to "combination_limit".
6064 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
6065 (Fset_window_nest): Rename to Fset_window_combination_limit.
6066 (Vwindow_nest): Rename to Vwindow_combination_limit.
6067 (recombine_windows, make_parent_window, make_window)
6068 (Fsplit_window_internal, saved_window)
6069 (Fset_window_configuration, save_window_save): Rename all
6070 occurrences of window_nest to window_combination_limit.
6071
c7015153
JB
60722011-11-15 Juanma Barranquero <lekktu@gmail.com>
6073
6074 * image.c (imagemagick_load_image): Fix typo.
6075
322ad6ec
EZ
60762011-11-14 Eli Zaretskii <eliz@gnu.org>
6077
6078 * xdisp.c (display_line): Move the call to
6079 highlight_trailing_whitespace before the call to
6080 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
6081 faces of all the glyphs to compute ROW's hash value.
6082 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 6083
f067b8ec
JB
60842011-11-14 Juanma Barranquero <lekktu@gmail.com>
6085
6086 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
6087 just return (bug#10044).
6088
1e5b2111
EZ
60892011-11-12 Eli Zaretskii <eliz@gnu.org>
6090
7ef3cbd5
EZ
6091 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
6092 with user-defined heap size. Bump the default size of the temacs
6093 heap to 27MB, to avoid memory warning when running temacs.
6094 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
6095
1e5b2111
EZ
6096 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
6097 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
6098 (verify_row_hash) [XASSERTS]: New function.
6099 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
6100 that the hash value of glyph rows is correct.
1e5b2111 6101
89d61221
MR
61022011-11-12 Martin Rudalics <rudalics@gmx.at>
6103
6104 * window.h (window): Remove splits slot.
6105 * window.c (Fwindow_splits, Fset_window_splits): Remove.
6106 (Fdelete_other_windows_internal, make_parent_window)
6107 (make_window, Fsplit_window_internal, Fdelete_window_internal)
6108 (Fset_window_configuration, save_window_save): Don't deal with
6109 split status of windows.
6110 (saved_window): Remove splits slot.
6111 (Vwindow_splits): Rewrite doc-string.
6112
97f18cc8
JD
61132011-11-11 Jan Djärv <jan.h.d@swipnet.se>
6114
6115 * xfns.c (unwind_create_frame):
6116 * nsfns.m (unwind_create_frame):
6117 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
6118 Vframe_list (Bug#9999).
6119
22a648b4
DA
61202011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
6121
0b381c7e 6122 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 6123
659afede
KH
61242011-11-11 Kenichi Handa <handa@m17n.org>
6125
6126 * callproc.c (Fcall_process): Set the member dst_multibyte of
6127 process_coding.
6128
9ac0394b
KH
61292011-11-11 Johan Bockgård <bojohan@gnu.org>
6130
6131 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
6132 avoid a crash (bug#9496).
6133
2fbdc249
CY
61342011-11-09 Chong Yidong <cyd@gnu.org>
6135
6136 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
6137 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
6138
ac6b1f81
PE
61392011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6140
6141 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
6142
09db192c
PE
61432011-11-08 Paul Eggert <eggert@cs.ucla.edu>
6144
6145 Avoid some portability problems by eschewing 'extern inline' functions.
6146 The trivial performance wins aren't worth the portability hassles; see
6147 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
6148 et seq.
6149 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6150 (window_box_width, window_box_left, window_box_left_offset)
6151 (window_box_right, window_box_right_offset): Undo previous change,
6152 by removing the "extern"s.
6153 * intervals.c (adjust_intervals_for_insertion)
6154 (adjust_intervals_for_deletion): Undo previous change,
6155 making these static again.
6156 (offset_intervals, temp_set_point_both, temp_set_point)
6157 (copy_intervals_to_string): No longer inline.
6158 * xdisp.c (window_text_bottom_y, window_box_width)
6159 (window_box_height, window_box_left_offset)
6160 (window_box_right_offset, window_box_left, window_box_right)
6161 (window_box): No longer inline.
6162
105216ed
CY
61632011-11-08 Chong Yidong <cyd@gnu.org>
6164
6165 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
6166 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
6167 Signal an error if not a live window.
105216ed
CY
6168 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
6169 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
6170
ae9e237f
JB
61712011-11-07 Juanma Barranquero <lekktu@gmail.com>
6172
6173 * lisp.h (syms_of_abbrev): Remove declaration.
6174 Reported by CHENG Gao <chenggao@royau.me>.
6175
c7aa8333
EZ
61762011-11-07 Eli Zaretskii <eliz@gnu.org>
6177
6178 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
6179 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
6180 of temacs in GUI mode.
6181
be7f5545
MR
61822011-11-07 Martin Rudalics <rudalics@gmx.at>
6183
6184 * window.h: Declare delete_all_child_windows instead of
6185 delete_all_subwindows.
6186 * window.c (Fwindow_nest, Fset_window_nest)
6187 (Fset_window_new_total, Fset_window_new_normal)
6188 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
6189 (delete_all_subwindows): Rename to delete_all_child_windows.
6190 (Fdelete_other_windows_internal, Fset_window_configuration):
6191 Call delete_all_child_windows instead of delete_all_subwindows.
6192 * frame.c (delete_frame): Call delete_all_child_windows instead
6193 of delete_all_subwindows.
6194
ca78dc43
PE
61952011-11-07 Paul Eggert <eggert@cs.ucla.edu>
6196
6197 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
6198 This is also needed for porting to any host where GC_MARK_STACK is
6199 not GC_MAKE_GCPROS_NOOPS.
6200 (which_symbols): Use it.
6201
a0241d01
KH
62022011-11-07 Kenichi Handa <handa@m17n.org>
6203
6204 * coding.c (coding_set_destination): Check coding->src_pos only
6205 when coding->src_object is a buffer (bug#9910).
6206
6207 * process.c (send_process): Set the member src_multibyte of coding
6208 to 0 (bug#9911) when sending a unibyte text.
6209
6210 * callproc.c (Fcall_process): Set the member src_multibyte of
6211 process_coding to 0 (bug#9912).
6212
a64bfdfa 62132011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
6214
6215 * xmenu.c (cleanup_widget_value_tree): New function.
6216 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
6217 calling free_menubar_widget_value_tree directly (Bug#9830).
6218
cb41b32a
PE
62192011-11-06 Paul Eggert <eggert@cs.ucla.edu>
6220
6221 Fix some portability problems with 'inline'.
6222 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
6223 (window_box_width, window_box_left, window_box_left_offset)
6224 (window_box_right, window_box_right_offset): Declare extern.
6225 Otherwise, these inline functions do not conform to C99 and
6226 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
6227 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
6228 * intervals.c (adjust_intervals_for_insertion)
6229 (adjust_intervals_for_deletion): Now extern, because otherwise the
6230 extern inline functions 'offset_intervals' couldn't refer to it.
6231 (static_offset_intervals): Remove.
6232 (offset_intervals): Rewrite using the old contents of
6233 static_offset_intervals. The old version didn't conform to C99
6234 because an extern inline function contained a reference to an
6235 identifier with static linkage.
6236
b7041366
AS
62372011-11-06 Andreas Schwab <schwab@linux-m68k.org>
6238
6239 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
6240 GC.
6241
88a37c4d
EZ
62422011-11-06 Eli Zaretskii <eliz@gnu.org>
6243
6244 * xdisp.c (init_iterator, reseat_to_string): Don't set the
6245 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
6246 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
6247 return Qleft_to_right.
6248
49745b39
CY
62492011-11-06 Chong Yidong <cyd@gnu.org>
6250
6251 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
6252 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
6253 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
6254 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
6255 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
6256 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
6257 (Fwindow_vscroll): Doc fix.
6258 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
6259 argument, since it makes no sense to pass a live window and for
6260 consistency with window-child.
6261
1f05cd82
CS
62622011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
6263
6264 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
6265 support MSVC.
6266
22610910
JR
62672011-11-05 Jason Rumney <jasonr@gnu.org>
6268
6269 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
6270 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
6271 fonts (Bug#6029).
6272 (add_font_entity_to_list): Fix logic errors in mixed boolean and
6273 bitwise arithmetic preventing use of unicode-sip and non-truetype
6274 opentype fonts.
6275
a06776b2
EZ
62762011-11-05 Eli Zaretskii <eliz@gnu.org>
6277
3ad924ba
EZ
6278 * s/ms-w32.h (fstat, stat, utime): Move redirections to
6279 "emacs"-only part.
6280
a06776b2
EZ
6281 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
6282 initialization code to keep similarity to xfns.c after changes
6283 from 2011-11-05.
6284
c9e7db78
JD
62852011-11-05 Jan Djärv <jan.h.d@swipnet.se>
6286
a97f8f3f
JD
6287 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
6288 (unwind_create_frame): New function (Bug#9943).
6289 (Fx_create_frame): Restructure code to be more similar to the one in
6290 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
6291 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
6292 Move terminal->reference_count++ just before making the frame official
6293 (Bug#9943).
6294
6295 * nsterm.m (x_free_frame_resources): New function.
6296 (x_destroy_window): Move code to x_free_frame_resources.
6297
c9e7db78 6298 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
6299 (Fx_create_frame, x_create_tip_frame):
6300 Move terminal->reference_count++ just before making the frame
75f1671a 6301 official. Move initialization of image_cache_refcount and
c9e7db78
JD
6302 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
6303
a6fc3b5c
EZ
63042011-11-05 Eli Zaretskii <eliz@gnu.org>
6305
6306 Support MSVC build with newer versions of Visual Studio.
6307 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
6308 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
6309 nt/gmake.defs.
6310
6311 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
6312 which are not supported by MSVC.
6313 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
6314 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
6315 bitfields.
6316 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
6317 types in bitfields.
6318 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
6319
6320 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
6321
58179cce 63222011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
6323
6324 Support MSVC build with newer versions of Visual Studio.
6325 * w32.c: Don't include w32api.h for MSVC.
6326 (init_environment) [_MSC_VER]: Call sys_access, not _access.
6327
6328 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
6329 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
6330 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
6331 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
6332 e_* cousins.
6333 (alloca) [_MSC_VER]: Define to _alloca.
6334
6335 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
6336
6337 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
6338
a58c13ed
EZ
63392011-11-04 Eli Zaretskii <eliz@gnu.org>
6340
6341 * xdisp.c (note_mouse_highlight): If either of
6342 previous/next-single-property-change returns nil, treat that as
6343 the beginning or the end of the buffer. (Bug#9955)
6344
fe0b6370
JD
63452011-11-04 Jan Djärv <jan.h.d@swipnet.se>
6346
a58c13ed 6347 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
6348 label is not null (Bug#9951).
6349 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
6350 may be NULL.
6351
89bd5ee1
EZ
63522011-11-04 Eli Zaretskii <eliz@gnu.org>
6353
6354 * window.c (Fwindow_body_size): Mention in the doc string that the
6355 return value is in frame's canonical units. (Bug#9949)
6356
84c3edb9
EZ
63572011-11-03 Eli Zaretskii <eliz@gnu.org>
6358
4e2fb5c7
EZ
6359 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
6360
84c3edb9 6361 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 6362 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 6363 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 6364
bc17a887
EZ
63652011-11-01 Eli Zaretskii <eliz@gnu.org>
6366
6367 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
6368 Don't stop backward scan on the continuation glyph, even though
6369 its CHARPOS is positive.
6d5eb5b0
SM
6370 (mouse_face_from_buffer_pos, note_mouse_highlight):
6371 Rename cover_string to disp_string.
bc17a887 6372
4ee88440
MR
63732011-11-01 Martin Rudalics <rudalics@gmx.at>
6374
6375 * window.c (temp_output_buffer_show): Don't use
6376 Vtemp_buffer_show_specifiers.
6377 (Vtemp_buffer_show_specifiers): Remove unused variable.
6378
c2ff3c02
EZ
63792011-10-30 Eli Zaretskii <eliz@gnu.org>
6380
6381 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
6382 past the beginning of the current glyph matrix.
6383
58179cce 63842011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
6385
6386 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
6387 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
6388 HAVE_GTK3 (Bug#9869).
b77a6a7f 6389
3b574623
JD
6390 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
6391 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
6392
b77a6a7f
JD
6393 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
6394
6395 * xterm.c: Declare x_handle_net_wm_state to return int.
6396 (handle_one_xevent): Check if we are iconified but don't have
6397 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
6398 (get_current_wm_state): Return non-zero if not hidden,
6399 check for _NET_WM_STATE_HIDDEN (Bug#9893).
6400 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
6401 (x_handle_net_wm_state): Return what get_current_wm_state returns.
6402 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
6403
196e41e4
PE
64042011-10-29 Paul Eggert <eggert@cs.ucla.edu>
6405
6406 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
6407 so that this new function doesn't get optimized away by a
6408 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
6409
021f2e1a
AS
64102011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6411
6412 * frame.h (MOUSE_HL_INFO): Remove excess parens.
6413
8b058d44
EZ
64142011-10-29 Eli Zaretskii <eliz@gnu.org>
6415
6416 Fix the `xbytecode' command.
6417 * .gdbinit (xprintbytestr): New command.
b50a28de 6418 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
6419 (xbytecode): Print the byte-code string as well.
6420
4452fb80
EZ
64212011-10-29 Kim Storm <storm@cua.dk>
6422
8b058d44
EZ
6423 * alloc.c (which_symbols): New function.
6424
21b72067
AS
64252011-10-29 Andreas Schwab <schwab@linux-m68k.org>
6426
6427 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
6428 line. (Bug#9903)
6429
83ed7b5c
GM
64302011-10-29 Glenn Morris <rgm@gnu.org>
6431
6432 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
6433 Not clear what it was for, and it causes various bugs. (Bug#9839)
6434
5a7a728b
EZ
64352011-10-28 Eli Zaretskii <eliz@gnu.org>
6436
6437 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
6438 possible random value that matches one of those tested as
6439 condition to clear the mouse face.
6440
d3d0842f
CY
64412011-10-28 Chong Yidong <cyd@gnu.org>
6442
6443 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
6444
31b39d13
DN
64452011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
6446
6447 * window.c (make_window): Initialize phys_cursor_on_p.
6448
9aba6043
SM
64492011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
6450
6451 * lisp.h (struct Lisp_Symbol): Update comments.
6452
c20992f4
JB
64532011-10-28 Juanma Barranquero <lekktu@gmail.com>
6454
6455 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
6456
db4f02f2
EZ
64572011-10-28 Eli Zaretskii <eliz@gnu.org>
6458
6459 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
6460 <oslsachem@gmail.com> for helping to debug this.
6461
6462 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
6463 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
6464 (g_b_init_get_glyph_outline_w): New static variables.
6465 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
6466 (GetGlyphOutlineW_Proc): New typedefs.
6467 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
6468 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
6469 New functions.
6470 (w32font_open_internal, compute_metrics):
6471 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
6472 instead of calling the "wide" APIs directly.
6473
6474 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
6475
6476 * w32.h (syms_of_w32font): Add prototype.
6477
87e68db4
JB
64782011-10-27 Juanma Barranquero <lekktu@gmail.com>
6479
6480 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
6481 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
6482 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
6483 (Fmove_to_window_line): Doc fix.
6484
435c1d67
CY
64852011-10-27 Chong Yidong <cyd@gnu.org>
6486
6487 * process.c (make_process): Set gnutls_state to NULL.
6488
6489 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
6490 non-NULL, regardless of GNUTLS_INITSTAGE.
6491 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
6492 an error. Set process slots as soon as we allocate them.
6493
6494 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
6495
9c6c6f49
CY
64962011-10-27 Chong Yidong <cyd@gnu.org>
6497
9aba6043
SM
6498 * gnutls.c (emacs_gnutls_deinit): New function.
6499 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
6500 (Fgnutls_deinit, Fgnutls_boot): Use it.
6501
6502 * process.c (make_process): Initialize GnuTLS credentials to NULL.
6503 (deactivate_process): Call emacs_gnutls_deinit.
6504
657d08d3
JB
65052011-10-27 Juanma Barranquero <lekktu@gmail.com>
6506
6507 * image.c (x_create_x_image_and_pixmap):
6508 * w32.c (sys_rename, w32_delayed_load):
6509 * w32font.c (fill_in_logfont):
6510 * w32reg.c (x_get_string_resource): Silence compiler warnings.
6511
5430d399
JB
65122011-10-26 Juanma Barranquero <lekktu@gmail.com>
6513
6514 * w32fns.c (w32_default_color_map): New function,
6515 extracted from Fw32_default_color_map.
a7ef684b 6516 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 6517
fe0055fa
PE
65182011-10-25 Paul Eggert <eggert@cs.ucla.edu>
6519
6520 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
6521
e6346438
SM
65222011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
6523
6524 * keyboard.c (test_undefined): New function (bug#9751).
6525 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
6526
e112cc37
ET
65272011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
6528
6529 * sysdep.c (init_sys_modes): Fix the check for the controlling
6530 terminal (Bug#6649).
6531
7b5d6677
EZ
65322011-10-20 Eli Zaretskii <eliz@gnu.org>
6533
6534 * dispextern.h (struct bidi_it): New member next_en_type.
6535
6536 * bidi.c (bidi_line_init): Initialize the next_en_type member.
6537 (bidi_resolve_explicit_1): When next_en_pos is valid for the
6538 current character, check also for next_en_type being WEAK_EN.
6539 (bidi_resolve_weak): Don't enter the expensive loop if the current
6540 position is before next_en_pos. Record the bidi type of the first
6541 non-ET, non-BN character we find, in addition to its position.
6542 (bidi_level_of_next_char): Invalidate next_en_type when
6543 next_en_pos is over-stepped.
6544
7da0b018
PE
65452011-10-20 Paul Eggert <eggert@cs.ucla.edu>
6546
6547 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
6548 * editfns.c: Rewrite current-time-zone so that it invokes
6549 the equivalent of (format-time-string "%Z") to get the time zone name.
6550 This fixes a bug when the time zone name contains characters that
6551 need converting from the system time locale to Emacs internal format.
6552 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
6553 that patch fixed format-time-string to do the conversion, but
6554 I forgot to fix current-time-zone.
6555 (format_time_string): New function, containing most of
6556 what Fformat_time_string used to contain.
6557 (Fformat_time_string): Rewrite in terms of format_time_string.
6558 This doesn't change this function's behavior.
6559 (current-time-zone): Rewrite to use format_time_string.
6560 This fixes the bug reported by Michael Schierl in
6561 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
6562 Jason Rumney's 2007-06-07 change worked around this bug, but
6563 didn't fix it.
6564 * systime.h (tzname, timezone): Remove no-longer-used declarations.
6565
8547b010
EZ
65662011-10-19 Eli Zaretskii <eliz@gnu.org>
6567
6568 * xdisp.c (start_display): If the character at POS is displayed
6569 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
6570 (try_window_reusing_current_matrix): If a line ends in a display
6571 vector or the next line starts in a display vector, continue
6572 redrawing the window even though the character position of
6573 start_row was reached.
8547b010
EZ
6574 (Bug#9771, part 2)
6575
4e948d15
CY
65762011-10-18 Chong Yidong <cyd@gnu.org>
6577
6578 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
6579 with nobreak-char-display too.
6580
4787455f
EZ
65812011-10-18 Eli Zaretskii <eliz@gnu.org>
6582
6583 Fix part 3 of bug#9771.
6584 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
6585 (bidi_resolve_neutral): Don't enter the expensive loop looking for
6586 non-neutral characters if the current character is a paragraph
6587 separator (a.k.a. Newline). This avoids running the same
6588 expensive loop twice, once when we consume the preceding newline
6589 and the other time when the line actually needs to be displayed.
6590 Avoid the loop when we see neutrals on the base embedding level
6591 following a character whose directionality is the same as the
6592 paragraph's. This avoids running the expensive loop when a line
6593 ends in a long sequence of neutrals, like control characters.
6594 Add assertion against STRONG_AL type. Slightly rearrange code
6595 that determines the type of a neutral given the first non-neutral
6596 that follows it.
6597 (bidi_level_of_next_char): Set next_en_pos to zero when
6598 invalidating its info.
6599
2c91f553
EZ
66002011-10-17 Eli Zaretskii <eliz@gnu.org>
6601
6602 * xdisp.c (push_display_prop): Determine whether to record string
6603 or buffer position by IT->string, not by IT->method. Allow
6604 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
6605 (move_it_vertically_backward): Don't look for character position
6606 immediately after the newline when in a continuation line.
6607 (Bug#9771, part 1)
2c91f553 6608
c7b08b0d
MR
66092011-10-15 Martin Rudalics <rudalics@gmx.at>
6610
6611 * window.c (coordinates_in_window): Rewrite and delabelize
6612 vertical border check. (Bug#5357) (Bug#9618)
6613
6b02f655
SM
66142011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
6615
6616 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
6617 errors in XSetWindowBorder (bug#9310).
6618
81d40c92
DA
66192011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
6620
6621 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
6622 avoid crash when xmalloc overrun checking is enabled.
6623
d4172c3b
EZ
66242011-10-13 Eli Zaretskii <eliz@gnu.org>
6625
6626 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
6627 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
6628 cursor motion with <left> and <right> arrow keys.
6629
6630 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
6631 some callers set that themselves.
6632
b00eea75
EZ
66332011-10-12 Eli Zaretskii <eliz@gnu.org>
6634
6635 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
6636 display string and the previous row comes from the same string and
6637 is empty. (Bug#9739) (Bug#9738)
6638
8fe012c4
SM
66392011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
6640
6641 * doc.c (get_doc_string): Encode file name (bug#9735).
6642
0074aef2
EZ
66432011-10-12 Eli Zaretskii <eliz@gnu.org>
6644
79beb178
EZ
6645 * bidi.c (bidi_level_of_next_char):
6646 * xdisp.c (get_visually_first_element): Remove old incorrect
6647 comments regarding the Unicode Line Separator character.
6648
0074aef2
EZ
6649 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
6650
6e4b3fbe
DA
66512011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
6652
6653 * alloc.c (Fgc_status): Do not access beyond zombies array
6654 boundary if nzombies > MAX_ZOMBIES.
6655 * alloc.c (dump_zombies): Add missing format specifier.
6656
0324f3af
PE
66572011-10-12 Paul Eggert <eggert@cs.ucla.edu>
6658
b5525cac
PE
6659 * xdisp.c (set_cursor_from_row): Simplify conditionals,
6660 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
6661
0324f3af
PE
6662 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
6663 Some packages use them to denote characters with modifiers.
6664
e9b5f888
AS
66652011-10-11 Andreas Schwab <schwab@linux-m68k.org>
6666
6667 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
6668 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
6669 matching a pp-number. Rename parameter var to var1.
6670
127827c0
SM
66712011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
6672
6673 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
6674
c8fd3bd0
GM
66752011-10-08 Glenn Morris <rgm@gnu.org>
6676
6677 * callint.c (Fcall_interactively): Give a more explicit error for the
6678 'c' case with a non-character input. (Bug#8479)
6679
352ec8ff
EZ
66802011-10-08 Eli Zaretskii <eliz@gnu.org>
6681
03669ccb
EZ
6682 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
6683 lines.
7061c986
EZ
6684 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
6685 lines that are hscrolled on the left.
03669ccb 6686
352ec8ff
EZ
6687 * dispnew.c (buffer_posn_from_coords): Account for a possible
6688 presence of header-line. (Bug#4426)
6689
a66cfb1c
SM
66902011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
6691
6b02f655
SM
6692 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
6693 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 6694
7c5ee88e
PE
66952011-10-07 Paul Eggert <eggert@cs.ucla.edu>
6696
6697 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
6698 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
6699 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
6700 this makes Emacs dump core during garbage collection on rare
6701 occasions. sizeof is obviously inferior to offsetof here, so
6702 stick with offsetof.
6703 (GC_POINTER_ALIGNMENT): New macro.
6704 (mark_memory): Omit 3rd (offset) arg; caller changed.
6705 Don't assume EMACS_INT alignment is the same as pointer alignment.
6706
df1bbe5b
SM
67072011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
6708
6709 * keyboard.c (read_key_sequence_remapped): New var.
6710 (read_key_sequence): Compute remapping in the right buffer.
6711 (command_loop_1): Use read_key_sequence's remapping directly.
6712
51553db6
SM
67132011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
6714
32c1fffd
SM
6715 * dired.c (file_name_completion): Don't expand file name.
6716 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
6717 before checking file name handler.
6718
51553db6
SM
6719 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
6720 they've been requested explicitly (bug#9591).
6721
b6bd1599 67222011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
6723
6724 * keymap.c (Fsingle_key_description): Use make_specified_string
6725 instead of build_string to build string from push_key_description.
6726 (Bug#5193)
6727
f701dc2a
PE
67282011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6729
4222c55d
PE
6730 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
6731 This fixes a Y2038 bug on 64-bit hosts.
6732 * buffer.c (reset_buffer):
6733 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
6734 (Fclear_buffer_auto_save_failure):
6735 Use 0, not -1, to represent an unset failure time, since time_t
6736 might not be signed.
6737
f701dc2a
PE
6738 Remove dependency on glibc malloc internals.
6739 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6740 Move back here from lisp.h, but with their new implementations.
6741 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6742 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
6743 * charset.c (charset_table_init): New static var.
6744 (syms_of_charset): Use it instead of xmalloc. This removes a
6745 dependency on glibc malloc internals. See Eli Zaretskii's comment in
6746 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
6747 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6748 Move back to alloc.c.
6749 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6750 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
6751
9ceebf39
JD
67522011-09-30 Jan Djärv <jan.h.d@swipnet.se>
6753
6754 * nsterm.m (windowDidResize): Call x_set_window_size only when
6755 ns_in_resize is true. Otherwise set pixelwidth/height and
6756 call change_frame_size (Bug#9628).
6757
cb993c58
PE
67582011-09-30 Paul Eggert <eggert@cs.ucla.edu>
6759
3930c88b
PE
6760 Port --enable-checking=all to Fedora 14 x86-64.
6761 * charset.c (syms_of_charset): Also account for glibc malloc's
6762 internal overhead when calculating the initial malloc maximum.
6763
cb993c58
PE
6764 Port --enable-checking=all to Fedora 14 x86.
6765 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6766 Move to lisp.h.
6767 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
6768 (overrun_check_realloc, overrun_check_free):
6769 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
6770 That way, xmalloc returns a properly-aligned pointer even if
6771 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
6772 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
6773 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
6774 into account when calculating the initial malloc maximum.
6775 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
6776 Move here from alloc.c, so that charset.c can use it too.
6777 Properly align; the old code wasn't right for common 32-bit hosts
6778 when configured with --enable-checking=all.
6779 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
6780 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
6781
31bed486
EZ
67822011-09-29 Eli Zaretskii <eliz@gnu.org>
6783
04c70788 6784 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
6785 use EDOM.
6786
fbcaa2f3
EZ
67872011-09-28 Eli Zaretskii <eliz@gnu.org>
6788
6789 * xdisp.c (compute_display_string_end): If there's no display
6790 string at CHARPOS, return -1.
6791
6792 * bidi.c (bidi_fetch_char): When compute_display_string_end
6793 returns a negative value, treat the character as a normal
6794 character not covered by a display string. (Bug#9624)
6795
a239d4e9
JB
67962011-09-28 Juanma Barranquero <lekktu@gmail.com>
6797
6798 * lread.c (Fread_from_string): Fix typo in docstring.
6799
88652fd5
EZ
68002011-09-27 Eli Zaretskii <eliz@gnu.org>
6801
6802 * xdisp.c (handle_invisible_prop): If invisible text ends on a
6803 newline, reseat the iterator instead of bidi-iterating there one
6804 character at a time. (Bug#9610)
32c1fffd
SM
6805 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
6806 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 6807
ed497dd4
AS
68082011-09-27 Andreas Schwab <schwab@linux-m68k.org>
6809
6810 * lread.c (readevalloop): Use correct code for NBSP.
6811 (read1): Likewise. (Bug#9608)
6812
b2bf61aa
MA
68132011-09-25 Michael Albinus <michael.albinus@gmx.de>
6814
6815 * dbusbind.c (Fdbus_register_signal): When service is not
6816 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
6817
32bbb17c
GM
68182011-09-25 Glenn Morris <rgm@gnu.org>
6819
6820 * buffer.c (truncate-lines): Doc fix.
6821
94e0933e
CY
68222011-09-24 Chong Yidong <cyd@stupidchicken.com>
6823
6824 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
6825 (Fset_window_next_buffers): Doc fix.
6826
cddde921
GM
68272011-09-24 Glenn Morris <rgm@gnu.org>
6828
6829 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
6830
1260aef1
PE
68312011-09-24 Paul Eggert <eggert@cs.ucla.edu>
6832
25b4bfa0
PE
6833 Fix minor problems found by static checking.
6834 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
6835 * indent.c (Fvertical_motion): Fix == vs = typo.
6836
e3cbd34b
EZ
68372011-09-24 Eli Zaretskii <eliz@gnu.org>
6838
a66cfb1c
SM
6839 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
6840 Default value is now t. Doc fix.
6bf7006f 6841
e3cbd34b 6842 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 6843 logic when moving up, not only when moving down. Fix the
e3cbd34b 6844 confusing name and values of the it_overshoot_expected variable;
32c1fffd 6845 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
6846
6847 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
6848 CHARPOS is covered by a display string which includes newlines.
6849 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
6850 is covered by a display string with embedded newlines.
6851
a3de0cbd
MA
68522011-09-24 Michael Albinus <michael.albinus@gmx.de>
6853
6854 * dbusbind.c (Fdbus_register_signal): Add match rule to
6855 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
6856 (Fdbus_register_method, Vdbus_registered_objects_table):
6857 Fix docstring.
a3de0cbd 6858
b260039d
JM
68592011-09-24 Jim Meyering <meyering@redhat.com>
6860
32c1fffd 6861 do not ignore write error for any output size
b260039d
JM
6862 The previous change was incomplete.
6863 While it makes emacs --batch detect the vast majority of stdout
6864 write failures, errors were still ignored whenever the output size is
6865 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
6866 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
6867 && echo FAIL: ignored write error
6868 FAIL: ignored write error
6869 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
6870 && echo FAIL: ignored write error
6871 FAIL: ignored write error
6872 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
6873
8eca8a7c
AS
68742011-09-23 Andreas Schwab <schwab@linux-m68k.org>
6875
6876 * emacs.c (Fkill_emacs): In noninteractive mode exit
6877 non-successfully if a write error occurred on stdout. (Bug#9574)
6878
3341db62
EZ
68792011-09-21 Eli Zaretskii <eliz@gnu.org>
6880
6881 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
6882 the xassert test.
6883
6884 * dispextern.h (struct it): Update the comment documenting what
6885 can it->OBJECT be.
6886
8c203dbf
EZ
68872011-09-20 Eli Zaretskii <eliz@gnu.org>
6888
6889 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
6890 a display string, extend search for cursor position to end of row.
6891 (find_row_edges): If the row ends in a newline from a display
6892 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
6893 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
6894 (Fcurrent_bidi_paragraph_direction): Fix search for previous
6895 non-empty line. Fixes confusing cursor motion with arrow keys at
6896 the beginning of a line that starts with whitespace.
8c203dbf 6897
a4824228
LMI
68982011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
6899
6900 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
6901 (bug#9493).
6902
33ed493b
CY
69032011-09-18 Chong Yidong <cyd@stupidchicken.com>
6904
6905 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
6906 boolean (Bug#9154).
6907
56cd55c8
EZ
69082011-09-18 Eli Zaretskii <eliz@gnu.org>
6909
6910 * xdisp.c (display_line): Record maximum and minimum buffer
6911 positions even if no glyphs were produced (e.g., by a zero-width
6912 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
6913 buffer positions that will be removed from the glyph row because
6914 they don't fit.
c02dcedf
EZ
6915 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
6916 column is beyond frame width: don't subtract 1 "pixel" when
6917 computing width of the stretch.
3e62b7e0
EZ
6918 (reseat_at_next_visible_line_start): Undo the change made on
6919 2011-09-17 that saved paragraph information and restored it after
6920 the call to `reseat'. (Bug#9545)
56cd55c8 6921
5ed99d36 69222011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
6923
6924 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
6925 and turn window cursor on if cleared (Bug#9415).
6926
5ed99d36 69272011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
6928
6929 * search.c (boyer_moore): Take unibyte characters from pattern
6930 literally. (Bug#9458)
6931
9bade7b2
EZ
69322011-09-18 Eli Zaretskii <eliz@gnu.org>
6933
6934 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
6935
e5e9d610
PE
69362011-09-18 Paul Eggert <eggert@cs.ucla.edu>
6937
87e4427a
PE
6938 Fix minor problem found by static checking.
6939 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
6940 initialized, to pacify gcc -Wuninitialized.
6941
e5e9d610
PE
6942 * fileio.c: Report proper errno when syscall falls.
6943 (Finsert_file_contents): Save and restore errno,
6944 so that report_file_error outputs the correct diagnostic.
6945 (Fwrite_region) [CLASH_DETECTION]: Likewise.
6946
a1674f0b
EZ
69472011-09-18 Eli Zaretskii <eliz@gnu.org>
6948
6949 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
6950
fbfb6dd4
EZ
69512011-09-17 Eli Zaretskii <eliz@gnu.org>
6952
6953 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
6954 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
6955
bb187662
EZ
69562011-09-17 Eli Zaretskii <eliz@gnu.org>
6957
1137e8b8 6958 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 6959 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
6960
6961 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
6962 (bidi_find_paragraph_start): Search back for paragraph beginning
6963 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
6964 (bidi_move_to_visually_next): Only trigger paragraph-related
6965 computations when the last character is a newline or at EOB, not
6966 just any NEUTRAL_B. (Bug#9470)
6967
bb187662
EZ
6968 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
6969 truncated lines if point is covered by a display string. (Bug#9524)
6970
2e621251
PE
69712011-09-16 Paul Eggert <eggert@cs.ucla.edu>
6972
6973 * xselect.c: Relax test for outgoing X longs (Bug#9498).
6974 (cons_to_x_long): New function.
6975 (lisp_data_to_selection_data): Use it. Correct the test for
6976 short-versus-long data; it was negated. Break out of vector
6977 loop, for efficiency, when a long datum is discovered.
6978
91a15bc6
SM
69792011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
6980
6981 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
6982
b41c3a35
EZ
69832011-09-16 Eli Zaretskii <eliz@gnu.org>
6984
6985 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
6986 GCC PR/17406) by declaring this function with external scope.
6987
7812ba2d
PE
69882011-09-15 Paul Eggert <eggert@cs.ucla.edu>
6989
6990 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
6991 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
6992
cf7edc2a
AS
69932011-09-15 Andreas Schwab <schwab@linux-m68k.org>
6994
6995 * editfns.c (Fformat): Correctly handle text properties on "%%".
6996
bd01620e
EZ
69972011-09-15 Eli Zaretskii <eliz@gnu.org>
6998
6999 * xterm.c (x_draw_composite_glyph_string_foreground):
7000 * w32term.c (x_draw_composite_glyph_string_foreground):
7001 * term.c (encode_terminal_code):
7002 * composite.c (composition_update_it, get_composition_id):
7003 * xdisp.c (get_next_display_element)
7004 (fill_composite_glyph_string): Add comments about special meaning
7005 of TAB characters in a composition.
7006
a02719a3
PE
70072011-09-15 Paul Eggert <eggert@cs.ucla.edu>
7008
7009 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
7010 This occurs when processing a multibyte format.
7011 Problem reported by Wolfgang Jenker.
a02719a3 7012
72589a3c
JB
70132011-09-15 Johan Bockgård <bojohan@gnu.org>
7014
7015 * xdisp.c (try_cursor_movement): Only check for exact match if
7016 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
7017
1c14176c
PE
70182011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7019
7020 Remove unused external symbols.
7021 * dispextern.h (calc_pixel_width_or_height): Remove decl.
7022 * xdisp.c (calc_pixel_width_or_height): Now static.
7023 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
7024 * indent.c (check_display_width):
7025 * w32term.c: Fix comment to match code.
7026 * xterm.c, xterm.h (x_catching_errors): Remove.
7027
d2eea5b5
PE
70282011-09-14 Paul Eggert <eggert@cs.ucla.edu>
7029
7030 * xselect.c: Use signed conversions more consistently (Bug#9498).
7031 (selection_data_to_lisp_data): Assume incoming selection data are
7032 signed integers, not unsigned. This is to be consistent with
7033 outgoing selection data, which was modified to use signed integers
7034 in as part of the fix to Bug#9196 in response to Jan D.'s comment
7035 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
7036 expects long, not unsigned long.
7037
46888499
EZ
70382011-09-14 Eli Zaretskii <eliz@gnu.org>
7039
7040 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
7041 computation of loop end. Reported by Johan Bockgård
7042 <bojohan@gnu.org>.
7043
ef8ef9fb
CY
70442011-09-13 Chong Yidong <cyd@stupidchicken.com>
7045
7046 * frame.c (Fother_visible_frames_p): Function deleted.
7047
fa819fed
EZ
70482011-09-12 Eli Zaretskii <eliz@gnu.org>
7049
7050 * indent.c (compute_motion): Process display vector front to back
7051 rather than the other way around. (Bug#2496)
7052
2ba8e008
SM
70532011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
7054
7055 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
7056
20f53c69
CY
70572011-09-11 Chong Yidong <cyd@stupidchicken.com>
7058
7059 * minibuf.c (Fread_from_minibuffer): Doc fix.
7060
d562d7a4
EZ
70612011-09-11 Eli Zaretskii <eliz@gnu.org>
7062
7063 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
7064 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
7065
1c4d7f3d
LMI
70662011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
7067
7068 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
7069 value for non-existent files.
7070
b885bf36
EZ
70712011-09-11 Eli Zaretskii <eliz@gnu.org>
7072
7073 * fileio.c (Finsert_file_contents): If the file cannot be opened,
7074 set its "size" to -1. This will set the modtime_size field of
7075 the corresponding buffer to -1, which is what
7076 verify-visited-file-modtime expects for files that do not exist.
7077 (Bug#9139)
7078
6612f0bf
PE
70792011-09-11 Paul Eggert <eggert@cs.ucla.edu>
7080
7081 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
7082 here ...
7083 * lisp.h: ... from here. push_key_description is no longer
7084 defined in keyboard.c, so its declaration should not be in
7085 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
7086 logically belongs with push_key_description.
7087
dfb3f755
PE
70882011-09-10 Paul Eggert <eggert@cs.ucla.edu>
7089
7090 * buffer.h: Include <sys/types.h> instead of <time.h>.
7091 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
7092 Problem reported by Herbert J. Skuhra.
7093
3134906c
LMI
70942011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
7095
7096 * xml.c (parse_region): Make the parsing work for
7097 non-comment-starting XML files again (bug#9144).
7098
8d903f4e
AS
70992011-09-10 Andreas Schwab <schwab@linux-m68k.org>
7100
7101 * image.c (gif_load): Fix calculation of bottom and right corner.
7102 (Bug#9468)
7103
80ad64f4
EZ
71042011-09-10 Eli Zaretskii <eliz@gnu.org>
7105
7106 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
7107 redisplay in small windows.
7108
208a048d
EZ
71092011-09-09 Eli Zaretskii <eliz@gnu.org>
7110
7111 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
7112
9b1c252e
MR
71132011-09-08 Martin Rudalics <rudalics@gmx.at>
7114
7115 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
7116 Operate on live windows only.
7117
2949f33b
JB
71182011-09-08 Juanma Barranquero <lekktu@gmail.com>
7119
7120 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
7121
e08dcafd
EZ
71222011-09-07 Eli Zaretskii <eliz@gnu.org>
7123
7124 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
7125 only under bidi iteration.
7126
115b96bd
JD
71272011-09-07 Jan Djärv <jan.h.d@swipnet.se>
7128
7129 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
7130
c8199d0f
PE
71312011-09-06 Paul Eggert <eggert@cs.ucla.edu>
7132
7133 isnan: Fix porting problem to Solaris 10 with bundled gcc.
7134 Without this fix, the command to link temacs failed due to an
7135 undefined symbol __builtin_isnan. This is because
7136 /usr/include/iso/math_c99.h #defines isnan(x) to
7137 __builtin_isnan(x), but the bundled gcc, which identifies itself
7138 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
7139 a __builtin_isnan.
7140 * floatfns.c (isnan): #undef, and then #define to a clone of
7141 what's in data.c.
7142 (Fisnan): Always define, since it's always available now.
7143 (syms_of_floatfns): Always define isnan at the Lisp level.
7144
e39b275c 71452011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
7146
7147 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
7148
b2db44d9 71492011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 7150
f4af5137 7151 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
7152 The previous code assumed that file offsets (off_t values) fit in
7153 EMACS_INT variables, which is not true on typical 32-bit hosts.
7154 The code messed up by falsely reporting buffer overflow in cases
7155 such as (insert-file-contents "big" nil 1 2) into an empty buffer
7156 when "big" contains more than 2**29 bytes, even though this
7157 inserts just one byte and does not overflow the buffer.
7158 (Finsert_file_contents): Store file offsets as off_t
7159 values, not as EMACS_INT values. Check for overflow when
7160 converting between EMACS_INT and off_t. When checking for
7161 buffer overflow or for overlap, take the offsets into account.
7162 Don't use EMACS_INT for small values where int suffices.
7163 When checking for overlap, fix a typo: ZV was used where
7164 ZV_BYTE was intended.
7165 (Fwrite_region): Don't assume off_t fits into 'long'.
7166 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
7167
ecfc0a49
MA
71682011-09-05 Michael Albinus <michael.albinus@gmx.de>
7169
7170 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
7171
6511acf2 71722011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 7173
0999621a 7174 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
7175
7176 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 7177 (esprintf, exprintf, evxprintf): New functions.
62f19c19 7178 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 7179 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
7180 (modify_event_symbol): Do not assume that the length of
7181 name_alist_or_stem is safe to alloca and fits in int.
7182 (Fexecute_extended_command): Likewise for function name and binding.
7183 (Frecursion_depth): Wrap around reliably on integer overflow.
7184 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
7185 since some callers pass EMACS_INT values.
7186 (Fsingle_key_description): Don't crash if symbol name contains more
7187 than MAX_ALLOCA bytes.
7188 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
7189 (get_minibuffer): Arg is now EMACS_INT, not int.
7190 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 7191 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
7192 * window.h (command_loop_level, minibuf_level): Reflect API changes.
7193
2be7d702
PE
7194 * dbusbind.c (signature_cat): New function.
7195 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
7196 Do not overrun buffer; instead, report string overflow.
7197
9d1df220
PE
7198 * dispnew.c (add_window_display_history): Don't overrun buffer.
7199 Truncate instead; this is OK since it's just a log.
7200
33ef5c64
PE
7201 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
7202 even if the time zone offset is outlandishly large.
7203 Don't mishandle offset == INT_MIN.
7204
66c6fdd5
PE
7205 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
7206 when creating daemon; the previous buffer-overflow check was incorrect.
7207
d749b01b
PE
7208 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
7209 which has the guts of the old verror function.
7210
b5cd1905
PE
7211 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
7212 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
7213
6e1a67fb
PE
7214 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
7215 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 7216 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 7217 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
7218 length of string rather than counting it via multiple sprintfs;
7219 that's simpler and more reliable.
c21721cc
PE
7220 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
7221 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
7222 sprintf, in case result does not fit in int.
7223
c57b67fc
PE
7224 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
7225 (fontset_from_font): Print it.
7226
8a401434
PE
7227 * frame.c (tty_frame_count): Now printmax_t, not int.
7228 (make_terminal_frame, set_term_frame_name): Print it.
7229 (x_report_frame_params): In X, window IDs are unsigned long,
7230 not signed long, so print them as unsigned.
7231 (validate_x_resource_name): Check for implausibly long names,
7232 and don't assume name length fits in 'int'.
7233 (x_get_resource_string): Don't blindly alloca invocation name;
7234 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
7235 not fit in int.
7236
6e1a67fb
PE
7237 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
7238 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
7239 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
7240
0df02bf3
PE
7241 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
7242 Use esprintf, not sprintf, in case result does not fit in int.
7243
48e30793
PE
7244 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7245 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
7246 it as a large positive number.
7247 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
7248 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
7249
a66ff6d8
PE
7250 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
7251 in case result does not fit in int.
7252
aca216ff
PE
7253 * print.c (float_to_string): Detect width overflow more reliably.
7254 (print_object): Make sprintf buffer a bit bigger, to avoid potential
7255 buffer overrun. Don't assume list length fits in 'int'. Treat
7256 print length of 0 as 0, not as infinity; to be consistent with other
7257 uses of print length in this function. Don't overflow print length
7258 index. Don't assume hash table size fits in 'long', or that
7259 vectorlike size fits in 'unsigned long'.
7260
31c286f7
PE
7261 * process.c (make_process): Use printmax_t, not int, to format
7262 process-name gensyms.
7263
55e5faa1
PE
7264 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
7265
80f2e268
PE
7266 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
7267 to avoid potential buffer overrun.
7268
670741ab
PE
7269 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
7270 if X resource line is longer than 512 bytes.
7271
b7163a50
PE
7272 * xfns.c (x_window): Make sprintf buffer a bit bigger
7273 to avoid potential buffer overrun.
7274
ae58ff1f
PE
7275 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
7276
c43c8a6a
PE
7277 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
7278
3f8236f4
PE
72792011-09-04 Paul Eggert <eggert@cs.ucla.edu>
7280
53e9fe90 7281 Integer overflow fixes for scrolling, etc.
6511acf2
PE
7282 Without these, Emacs silently mishandles large integers sometimes.
7283 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
7284 it were "C-u 1 M-x recenter" on a typical 64-bit host.
7285
6511acf2
PE
7286 * xdisp.c (try_window_id): Check Emacs fixnum range before
7287 converting to 'int'.
806add1d 7288
6511acf2 7289 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
7290 Check that an Emacs fixnum is in range before assigning it to 'int'.
7291 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
7292 values converted from Emacs fixnums.
7293 (Frecenter): Don't wrap around a line count if it is out of 'int'
7294 range; instead, treat it as an extreme value.
7295 (Fset_window_configuration, compare_window_configurations):
7296 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
7297
6511acf2
PE
7298 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
7299 that can exceed INT_MAX. Check that EMACS_INT value is in range
7300 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
7301 (match_limit): Don't assume that a fixnum can fit in 'int'.
7302
6511acf2 7303 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
7304 exceed INT_MAX.
7305
6511acf2 7306 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
7307 (Fvertical_motion): Don't wrap around LINES values that don't fit
7308 in 'int'. Instead, treat them as extreme values. This is good
7309 enough for windows, which can't have more than INT_MAX lines anyway.
7310
fcb901a7
LMI
73112011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
7312
0f2f6b6d
LMI
7313 * Require libxml/parser.h to avoid compilation warning.
7314
fcb901a7
LMI
7315 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
7316
7317 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
7318 since this reportedly can destroy thread storage.
7319
6e20a0d4
CY
73202011-08-30 Chong Yidong <cyd@stupidchicken.com>
7321
7322 * syntax.c (find_defun_start): Update all cache variables if
7323 exiting early (Bug#9401).
7324
148ae00e
EZ
73252011-08-30 Eli Zaretskii <eliz@gnu.org>
7326
f6cfbd8f
EZ
7327 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
7328
148ae00e
EZ
7329 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
7330 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
7331 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
7332
7333 * term.c (tty_append_glyph): New function.
7334 (produce_stretch_glyph): Static function and its prototype deleted.
7335
a66cfb1c
SM
7336 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
7337 Add prototypes.
148ae00e 7338
c4a07a4c
PE
73392011-08-29 Paul Eggert <eggert@cs.ucla.edu>
7340
7341 * image.c (parse_image_spec): Check for nonnegative, not for positive,
7342 when checking :margin (Bug#9390).
7343 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 7344 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
7345 so that the name doesn't mislead. All uses changed.
7346
6bc8cd65
JB
73472011-08-28 Johan Bockgård <bojohan@gnu.org>
7348
7349 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
7350 set_tty_hooks.
7351
dca4927e
EZ
73522011-08-27 Eli Zaretskii <eliz@gnu.org>
7353
7354 * xdisp.c (move_it_to): Don't bail out early when reaching
7355 position beyond to_charpos, if we are scanning backwards.
7356 (move_it_vertically_backward): When DY == 0, make sure we get to
7357 the first character in the line after the newline.
7358
f2cad773
PE
73592011-08-27 Paul Eggert <eggert@cs.ucla.edu>
7360
7361 * ccl.c: Improve and simplify overflow checking (Bug#9196).
7362 (ccl_driver): Do not generate an out-of-range pointer.
7363 (Fccl_execute_on_string): Remove unnecessary check for
7364 integer overflow, noted by Stefan Monnier in
7365 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
7366 Remove a FIXME that didn't need fixing.
7367 Simplify the newly-introduced buffer reallocation code.
7368
0cae2cdb
JB
73692011-08-27 Juanma Barranquero <lekktu@gmail.com>
7370
7371 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
7372
5fc295a4 73732011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 7374
70c60eb2 7375 Integer and memory overflow issues (Bug#9196).
726e0ab1 7376
d31850da
PE
7377 * doc.c (get_doc_string): Rework so that
7378 get_doc_string_buffer_size is the actual buffer size, rather than
7379 being 1 less than the actual buffer size; this makes xpalloc more
7380 convenient.
7381
a69fbedb
PE
7382 * image.c (x_allocate_bitmap_record, cache_image):
7383 * xselect.c (Fx_register_dnd_atom):
7384 Simplify previous changes by using xpalloc.
7385
fe5c5d37
PE
7386 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
7387 since either will do and ptrdiff_t is convenient with xpalloc.
7388
0065d054
PE
7389 * charset.c (charset_table_size)
7390 (struct charset_sort_data.priority): Now ptrdiff_t.
7391 (charset_compare): Don't overflow if priorities differ greatly.
7392 (Fsort_charsets): Don't assume list length fits in int.
7393 Check for size-calculation overflow when allocating sort data.
7394 (syms_of_charset): Allocate an initial charset table that is
7395 just under 64 KiB, to avoid problems with glibc malloc and mmap.
7396
7397 * cmds.c (internal_self_insert): Check for size-calculation overflow.
7398
7399 * composite.h (struct composition.glyph_len): Now int, not unsigned.
7400 The actual value is always <= INT_MAX, and leaving it unsigned made
7401 overflow checking harder.
7402
7403 * dispextern.h (struct glyph_matrix.rows_allocated)
7404 (struct face_cache.size): Now ptrdiff_t, for convenience in use
7405 with xpalloc. The values are still always <= INT_MAX.
7406
7407 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
7408
7409 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
7410 (SAFE_NALLOCA): New macro.
7411
7412 * region-cache.c (struct boundary.pos, find_cache_boundary)
7413 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
7414 (set_cache_region, invalidate_region_cache)
7415 (revalidate_region_cache, know_region_cache, region_cache_forward)
7416 (region_cache_backward, pp_cache):
7417 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
7418 so that ptrdiff_t * can be passed to xpalloc.
7419 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
7420 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
7421 (pp_cache): Don't assume cache_len fits in int.
7422 * region-cache.h: Adjust extern decls to match.
7423
7424 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
7425 EMACS_INT, since either will do, for xpalloc.
7426
7427 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
7428 (xnmalloc, xnrealloc, xpalloc): New functions.
7429
726e0ab1
PE
7430 * bidi.c (bidi_shelve_header_size): New constant.
7431 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
7432 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
7433
51f30bc5 7434 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
7435 * buffer.c (overlays_at, overlays_in, record_overlay_string)
7436 (overlay_strings):
7437 Don't update size of array until after memory allocation succeeds,
7438 because xmalloc/xrealloc may not return.
0065d054
PE
7439 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
7440 now that we have proper integer overflow checking.
7441 (record_overlay_string, overlay_strings): Catch overflows when
7442 calculating size of overlay_str_buf.
726e0ab1 7443
0065d054
PE
7444 * callproc.c (Fcall_process): Check for size overflow when
7445 calculating size of args2.
7446 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
7447 Normally we prefer signed values, but sticking with ptrdiff_t would
7448 require adding more-complicated checks.
726e0ab1
PE
7449
7450 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
7451 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
7452 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 7453 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
7454
7455 * character.c (Fstring): Check for size-calculation overflow.
7456
7457 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
7458 unnecessary integer overflow. Check for size overflow.
7459 (encode_coding_object): Don't update size until xmalloc succeeds.
7460
7461 * composite.c (get_composition_id): Check for overflow in glyph
7462 length calculations.
7463
7464 Integer and memory overflow fixes for display code.
7465 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
7466 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
7467 (scrolling_window): Check for overflow in size calculations.
7468 (line_draw_cost, realloc_glyph_pool, add_row_entry):
7469 Don't assume glyph table len fits in int.
7470 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
7471 (row_table_size): Now ptrdiff_t, not int.
7472 (scrolling_window): Avoid overflow in size calculations.
7473 Don't update size until allocation succeeds.
7474 * fns.c (concat): Check for overflow in size calculations.
7475 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
7476 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7477 (NEXT_ALMOST_PRIME_LIMIT): New constant.
7478
7479 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
7480 (get_doc_string): Check for size calculation overflow.
7481 Don't update size until allocation succeeds.
7482 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
7483 EMACS_INT, where ptrdiff_t will do.
7484 (Fsubstitute_command_keys): Check for string overflow.
7485
7486 * editfns.c (set_time_zone_rule): Don't assume environment length
7487 fits in int.
7488 (message_length): Now ptrdiff_t, not int.
7489 (Fmessage_box): Don't update size until allocation succeeds.
7490 Don't assume message length fits in int.
7491 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
7492
0065d054
PE
7493 * emacs.c (main): Do not reallocate argv, since there is a null at
7494 the end that can be overwritten, and this way there's no need to
7495 worry about size-calculation overflow.
7496 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
7497
7498 * eval.c (init_eval_once, grow_specpdl): Don't update size until
7499 alloc succeeds.
7500 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
7501
7502 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
7503 (x_set_scroll_bar_width, x_figure_window_size):
7504 Check for integer overflow.
7505 (x_set_alpha): Do not assume XINT fits in int.
7506
7507 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
7508 This is for the members text_lines, text_cols, total_lines, total_cols,
7509 where the system imposes an 'int' limit.
7510
7511 * fringe.c (Fdefine_fringe_bitmap):
7512 Don't update size until alloc works.
7513
7514 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
7515 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
7516
7517 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
7518 Check for size-calculation overflow.
7519 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
7520 do, as we prefer signed integers.
7521 (id_to_widget.max_size, id_to_widget.used)
7522 (xg_store_widget_in_map, xg_remove_widget_from_map)
7523 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
7524 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
7525 Use and return ptrdiff_t, not int.
7526 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
7527 * gtkutil.h: Change prototypes to match the above.
7528
7529 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
7530 are duplicate now that they've been promoted to lisp.h.
7531 (x_allocate_bitmap_record, x_alloc_image_color)
7532 (make_image_cache, cache_image, xpm_load):
7533 Don't update size until alloc is done.
7534 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
7535 (x_detect_edges):
3256efce 7536 Check for size calculation overflow.
726e0ab1
PE
7537 (ct_colors_allocated_max): New constant.
7538 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
7539 overflow.
3256efce 7540
726e0ab1
PE
7541 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
7542 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
7543 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
7544 Use ptrdiff_t, not int, to count maps.
7545 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
7546 calculations. Don't update size until allocation succeeds.
7547 Redo calculations to avoid overflow.
726e0ab1
PE
7548 * keyboard.h: Change prototypes to match the above.
7549
7550 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
7551 to count maps.
7552 (current_minor_maps): Check for size calculation overflow.
7553 * keymap.h: Change prototypes to match the above.
7554
7555 * lread.c (read1, init_obarray): Don't update size until alloc done.
7556
7557 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
7558 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
7559
726e0ab1
PE
7560 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
7561 Now ptrdiff_t, not int.
7562 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
7563 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
7564
7565 * process.c (Fnetwork_interface_list): Check for overflow
7566 in size calculation.
7567
7568 * region-cache.c (move_cache_gap): Check for size calculation overflow.
7569
7570 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
7571 overflow. Don't bother calling xmalloc when xrealloc will do.
7572
7573 * search.c (Freplace_match): Check for size calculation overflow.
7574 (Fset_match_data): Don't assume list lengths fit in 'int'.
7575
7576 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
7577 for command line length. Do not attempt to address one before the
7578 beginning of an array, as that's not portable.
7579
7580 * term.c (max_frame_lines): Remove; unused.
7581 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
7582 not int.
7583 (encode_terminal_code, calculate_costs): Check for size
7584 calculation overflow.
7585 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
7586 table lengths and related sizes. Don't update size until alloc
7587 done. Redo calculations to avoid overflow.
7588 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
7589
7590 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
7591 subtracting pointers.
7592 (gobble_line): Check for overflow more carefully. Don't update size
7593 until alloc done.
7594
7595 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
7596 Don't update size until alloc done.
7597 Redo size calculations to avoid overflow.
7598 Check for size calculation overflow.
0065d054 7599 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
7600
7601 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
7602 Use ptrdiff_t, not int, for sizes.
7603 (store_mode_line_noprop_char): Don't update size until alloc done.
7604
0065d054
PE
7605 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
7606 Use ptrdiff_t, not int, for sizes.
7607 (Finternal_make_lisp_face, cache_face):
7608 Check for size calculation overflow.
7609 (cache_face): Treat size calculation overflows as if they were
7610 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
7611
7612 * xfns.c (x_encode_text, x_set_name_internal)
7613 (Fx_change_window_property): Use ptrdiff_t, not int, to count
7614 sizes, since they can exceed INT_MAX in size. Check for size
7615 calculation overflow.
7616
0065d054
PE
7617 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
7618 (xg_select): Check for size calculation overflow.
726e0ab1
PE
7619 Don't update size until alloc done.
7620
0065d054 7621 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 7622 as sprintf is limited to int lengths.
1d526e2f 7623
252c5ee1
PE
7624 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
7625 (X_LONG_MIN): New macros.
864d7ce7
PE
7626 Use them to make the following changes clearer.
7627 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
7628 This change doesn't affect the value now, but it may help remind
7629 future maintainers not to raise the value too much later.
7630 (SELECTION_QUANTUM): Remove, replacing with ...
7631 (selection_quantum): ... new function, which avoids overflow.
7632 All uses changed.
7633 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
7634 assumption that selection length fits in 'int'.
7635 (x_reply_selection_request, x_handle_selection_request)
7636 (x_get_window_property, receive_incremental_selection)
7637 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
7638 (lisp_data_to_selection_data, clean_local_selection_data):
7639 Use ptrdiff_t, not int, to record length of selection.
7640 (x_reply_selection_request, x_get_window_property)
7641 (receive_incremental_selection, x_property_data_to_lisp):
7642 Redo calculations to avoid overflow.
7643 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 7644 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
7645 something.
7646 (x_get_window_property, receive_incremental_selection)
7647 (lisp_data_to_selection_data, x_property_data_to_lisp):
7648 Check for size-calculation overflow.
7649 (x_get_window_property, receive_incremental_selection)
7650 (lisp_data_to_selection_data, Fx_register_dnd_atom):
7651 Don't store size until memory allocation succeeds.
7652 (x_get_window_property): Plug memory leak on memory exhaustion.
7653 Don't double-block input; malloc is safe here. Don't assume 2**34
7654 - 4 fits in unsigned long. Add an xassert to check
7655 XGetWindowProperty overflow. Be more careful about overflow
7656 calculations, and distinguish size from memory overflow better.
7657 (receive_incremental_selection): When tracing, don't assume
7658 unsigned int is less than INT_MAX.
7659 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
7660 harmful) conversions of unsigned short to int.
7661 (lisp_data_to_selection_data): Don't assume that integers
7662 in the range -65535 through -1 fit in an X unsigned short.
7663 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
7664 result parameters unless successful. Rely on cons_to_unsigned
7665 to report problems with elements; the old code wasn't right anyway.
7666 (x_check_property_data): Check for int overflow; we cannot use
7667 a wider type due to X limits.
7668 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
7669
726e0ab1 7670 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 7671
0065d054
PE
7672 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
7673 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
7674 (x_color_cells): Don't store size until memory allocation succeeds.
7675 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 7676 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
7677 (x_term_init): Don't assume length fits in int (sprintf is limited
7678 to int size).
bc18e09d 7679
ebfa62c0
PE
7680 Use ptrdiff_t for composition IDs.
7681 * character.c (lisp_string_width):
7682 * composite.c (composition_table_size, n_compositions)
7683 (get_composition_id, composition_gstring_from_id):
7684 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
7685 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
7686 * window.c (Frecenter):
7687 Use ptrdiff_t, not int, for composition IDs.
7688 * composite.c (get_composition_id): Check for integer overflow.
7689 * composite.h: Adjust prototypes to match the above changes.
7690
d3411f89
PE
7691 Use ptrdiff_t for hash table indexes.
7692 * category.c (hash_get_category_set):
7693 * ccl.c (ccl_driver):
7694 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
7695 * coding.c (coding_system_charset_list, detect_coding_system):
7696 * coding.h (struct coding_system.id):
7697 * composite.c (get_composition_id, gstring_lookup_cache):
7698 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
7699 * image.c (xpm_get_color_table_h):
7700 * lisp.h (hash_lookup, hash_put):
7701 * minibuf.c (Ftest_completion):
7702 Use ptrdiff_t for hash table indexes, not int (which is too
7703 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
7704 32-bit --with-wide-int hosts).
7705
e097a6fa
PE
7706 * charset.c (Fdefine_charset_internal): Check for integer overflow.
7707 Add a FIXME comment about memory leaks.
7708 (syms_of_charset): Don't assume xmalloc returns.
7709
5637687f
PE
7710 Don't assume that stated character widths fit in int.
7711 * character.c (Fchar_width, c_string_width, lisp_string_width):
7712 * character.h (CHAR_WIDTH):
7713 * indent.c (MULTIBYTE_BYTES_WIDTH):
7714 Use sanitize_char_width to avoid undefined and/or bad behavior
7715 with outlandish widths.
a66cfb1c 7716 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
7717 now that we have two such functions. All uses changed.
7718 (sanitize_char_width): New inline function.
7719
a2271ba2
PE
7720 Don't assume that tab-width fits in int.
7721 * character.h (sanitize_width): New inline function.
7722 (SANE_TAB_WIDTH): New macro.
7723 (ASCII_CHAR_WIDTH): Use it.
7724 * indent.c (sane_tab_width): Remove. All uses replaced by
7725 SANE_TAB_WIDTH (current_buffer).
7726 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
7727
18c52557
PE
7728 * fileio.c: Integer overflow issues with file modes.
7729 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
7730
caeeedc1
PE
7731 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
7732 Remove unreachable code.
7733 (read_hex, load_charset_map_from_file): Check for integer overflow.
7734
6df6ae42 7735 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
7736 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
7737 (x_send_scroll_bar_event): Likewise. Check that the size does not
7738 exceed limits imposed by XClientMessageEvent, as well as the usual
7739 ptrdiff_t and size_t limits.
7740
b13995db
PE
7741 * keyboard.c: Overflow, signedness and related fixes.
7742 (make_lispy_movement): Use same integer type in forward decl
7743 that is used in the definition.
7744 (read_key_sequence, keyremap_step):
7745 Change bufsize argument back to int, undoing my 2011-03-30 change.
7746 We prefer signed types, and int is wide enough here.
7747 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
7748 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
7749 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
7750 length, not size_t. Use ptrdiff_t for index, not int.
7751 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
7752 possibility of integer overflow.
7753
13464394
PE
7754 Overflow, signedness and related fixes for images.
7755
7756 * dispextern.h (struct it.stack[0].u.image.image_id)
7757 (struct_it.image_id, struct image.id, struct image_cache.size)
7758 (struct image_cache.used, struct image_cache.ref_count):
7759 * gtkutil.c (update_frame_tool_bar):
7760 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
7761 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
7762 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
7763 * nsmenu.m (update_frame_tool_bar):
7764 * xdisp.c (calc_pixel_width_or_height):
7765 * xfns.c (image_cache_refcount):
7766 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
7767 on typical 64-bit hosts.
7768
7769 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
7770 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
7771 Omit unnecessary casts to int.
7772 (parse_image_spec): Check that integers fall into 'int' range
7773 when the callers expect that.
7774 (image_ascent): Redo ascent calculation to avoid int overflow.
7775 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
7776 (lookup_image): Remove unnecessary tests.
7777 (xbm_image_p): Locals are now of int, not EMACS_INT,
7778 since parse_image_check makes sure they fit into int.
7779 (png_load, gif_load, svg_load_image):
7780 Prefer int to unsigned where either will do.
7781 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
7782 old tiff_error_handler and tiff_warning_handler.
7783 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
7784 stack buffer overflows. It uses only the features of vsnprintf
7785 that are common to both POSIX and native Microsoft.
7786 (tiff_error_handler, tiff_warning_handler): Use it.
7787 (tiff_load, gif_load, imagemagick_load_image):
7788 Don't assume :index value fits in 'int'.
7789 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
7790 (imagemagick_load_image): Check that crop parameters fit into
7791 the integer types that MagickCropImage accepts. Don't assume
7792 Vimagemagick_render_type has a nonnegative value. Don't assume
7793 size_t fits in 'long'.
7794 (gs_load): Use printmax_t to print the widest integers possible.
7795 Check for integer overflow when computing image height and width.
7796
c11821d4
EZ
77972011-08-26 Eli Zaretskii <eliz@gnu.org>
7798
7799 * xdisp.c (redisplay_window): Don't force window start if point
7800 will be invisible in the resulting window. (Bug#9324)
7801
0c95fcf7
EZ
78022011-08-25 Eli Zaretskii <eliz@gnu.org>
7803
7804 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
7805 the display spec is of the form `(space ...)'.
7806 (handle_display_spec): Return the value returned by
7807 handle_single_display_spec, not just 1 or zero.
7808 (handle_single_display_spec): If the display spec is of the form
7809 `(space ...)', and specifies display in the text area, return 2
7810 rather than 1.
fee65a97 7811 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
7812 accurately, and prefer exact match for point under bidi.
7813 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
7814
7815 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
7816 into disp_prop; all users changed.
7817
7818 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
7819 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
7820 for the text covered by the display property.
7821
e4ed06f1
CY
78222011-08-25 Chong Yidong <cyd@stupidchicken.com>
7823
7824 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
7825 Change return value to nil.
7826 (Frecord_buffer): Delete unused function.
7827
f67cdd7f
EZ
78282011-08-24 Eli Zaretskii <eliz@gnu.org>
7829
5980d4c6
EZ
7830 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
7831 buffers, return left-to-right.
8610fe8b
EZ
7832 (set_cursor_from_row): Consider candidate row a win if its glyph
7833 represents a newline and point is on that newline. Fixes cursor
7834 positioning on the newline at EOL of R2L text within L2R
7835 paragraph, and vice versa.
7836 (try_cursor_movement): Check continued rows, in addition to
7837 continuation rows. Fixes unwarranted scroll when point enters a
7838 continued line of R2L text within an L2R paragraph, or vice versa.
7839 (cursor_row_p): Consider the case of point being equal to
7840 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
7841 from the end of a short line to the beginning of a continued line
7842 of R2L text within L2R paragraph.
7843 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
7844 composed characters.
5980d4c6 7845
f67cdd7f
EZ
7846 * bidi.c (bidi_check_type): Use xassert.
7847 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
7848 members.
7849
bca633fb
EZ
78502011-08-23 Eli Zaretskii <eliz@gnu.org>
7851
7852 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
7853 a character.
7854
4a5885a7
CY
78552011-08-23 Chong Yidong <cyd@stupidchicken.com>
7856
7857 * nsfont.m (ns_otf_to_script): Fix typo.
7858
0902a04e
KH
78592011-08-22 Kenichi Handa <handa@m17n.org>
7860
7861 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
7862 extra slot even if the purpose is char-code-property-table.
7863
1a2e6670
EZ
78642011-08-23 Eli Zaretskii <eliz@gnu.org>
7865
8ddde651
EZ
7866 * xdisp.c (redisplay_window): When computing centering_position,
7867 account for the height of the header line. (Bug#8874)
7868
425cc014
EZ
7869 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
7870 instead of CHAR_TO_BYTE. Fixes a crash when a completion
7871 candidate is selected by the mouse, and that candidate has a
7872 composed character under the mouse.
7873
1a2e6670
EZ
7874 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
7875 coordinates reported by pos-visible-in-window-p for a composed
7876 character in column zero.
7877
8b76d6f8
SM
78782011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
7879
7880 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
7881
dac347dd
EZ
78822011-08-22 Eli Zaretskii <eliz@gnu.org>
7883
7884 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
7885 consider it a hit if to_charpos is anywhere in the range of the
7886 composed buffer positions.
7887
e013fb34
CY
78882011-08-22 Chong Yidong <cyd@stupidchicken.com>
7889
7890 * image.c (gif_load): Don't assume that each subimage has the same
7891 dimensions as the base image. Handle disposal method that is
7892 "undefined" by the gif spec (Bug#9335).
7893
bd1ba3e8
CY
78942011-08-20 Chong Yidong <cyd@stupidchicken.com>
7895
7896 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 7897 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 7898
54a1215b
EZ
78992011-08-19 Eli Zaretskii <eliz@gnu.org>
7900
823564e5
EZ
7901 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
7902 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
7903 from an Org mode buffer to a Speedbar frame.
7904
54a1215b
EZ
7905 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
7906 a composition, take its buffer position from IT->cmp_it.charpos.
7907 Fixes cursor positioning at the beginning of a line that begins
7908 with a composed character.
7909
9778ebcc
EZ
79102011-08-18 Eli Zaretskii <eliz@gnu.org>
7911
0be6ee06
EZ
7912 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
7913 character bidirectional type, use STRONG_L instead. Fixes crashes
7914 in a buffer produced by `describe-categories'.
7915
9778ebcc
EZ
7916 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
7917 members before the level stack, so they would be saved and
7918 restored when copying iterator state. Fixes incorrect reordering
7919 around TABs covered by display properties.
7920
156bffbe
AS
79212011-08-18 Andreas Schwab <schwab@linux-m68k.org>
7922
6b02f655 7923 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 7924
72ad093b
CY
79252011-08-17 Chong Yidong <cyd@stupidchicken.com>
7926
7927 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
7928 (internal_condition_case_2, internal_condition_case_n):
7929 Remove unnecessary aborts (Bug#9081).
72ad093b 7930
35774242
EZ
79312011-08-17 Eli Zaretskii <eliz@gnu.org>
7932
7933 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
7934 has no `load' handler, try opening the file locally. (Bug#9311)
7935
db76dd85
KB
79362011-08-16 Ken Brown <kbrown@cornell.edu>
7937
7938 * gmalloc.c: Expand comment.
7939
b215eee5
EZ
79402011-08-16 Eli Zaretskii <eliz@gnu.org>
7941
7942 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
7943 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
7944
a4579d33
KB
79452011-08-16 Ken Brown <kbrown@cornell.edu>
7946
7947 Fix memory allocation problems in Cygwin build (Bug#9273).
7948
7949 * unexcw.c ( __malloc_initialized): Declare external variable.
7950 (fixup_executable): Force the dumped emacs to reinitialize malloc.
7951
8b76d6f8
SM
7952 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
7953 New variables.
a4579d33
KB
7954 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
7955 dumped emacs.
7956 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
7957 in the static heap.
7958 [CYGWIN] (special_realloc): New function.
7959 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
7960 requests to realloc storage in the static heap.
7961
3ebec551
PE
79622011-08-15 Paul Eggert <eggert@cs.ucla.edu>
7963
7964 * bidi.c (bidi_initialize): Remove unused local.
7965
9fd8be00
EZ
79662011-08-15 Eli Zaretskii <eliz@gnu.org>
7967
6b02f655
SM
7968 * bidimirror.h:
7969 * biditype.h: Remove file.
7970 * makefile.w32-in ($(BLD)/bidi.$(O)):
7971 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
7972
7973 * dispextern.h: Fix a typo in the comment to bidi_type_t.
7974
7975 * chartab.c: Improve commentary for the uniprop_table API.
7976
32413314
EZ
7977 * bidi.c (bidi_paragraph_init): Support zero value of
7978 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
7979 (bidi_initialize): Use uniprop_table instead of including
7980 biditype.h and bidimirror.h.
32413314 7981
9fd8be00
EZ
7982 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
7983 coordinates of the iterator when restoring from ppos_it.
7984 (Bug#9296)
7985
5cf2b69b
KH
79862011-08-14 Kenichi Handa <handa@m17n.org>
7987
7988 * process.c (create_process): Call setup_process_coding_systems
72ad093b 7989 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 7990
daf17d00
EZ
79912011-08-14 Eli Zaretskii <eliz@gnu.org>
7992
7993 * xdisp.c (move_it_in_display_line_to): Don't invoke
7994 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
7995 ppos_it. Fixes vertical cursor motion when line beginning is
7996 covered by an image. (Bug#9296)
7997
08e3161a
JD
79982011-08-14 Jan Djärv <jan.h.d@swipnet.se>
7999
8000 * nsterm.h (ns_run_ascript): Declare.
8001 (NSAPP_DATA2_RUNASSCRIPT): Define.
8002
8003 * nsfns.m (as_script, as_result, as_status): New static variables.
8004 (ns_run_ascript): New function.
5e617bc2 8005 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
8006 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
8007 the event loop. Get status from as_status (Bug#7276).
8008
8009 * nsterm.m (sendEvent): If event is NSApplicationDefined and
8010 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
8011 the event loop (Bug#7276).
8012
a3720aa2
AS
80132011-08-14 Andreas Schwab <schwab@linux-m68k.org>
8014
8015 * gnutls.c (QCgnutls_bootprop_priority)
8016 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
8017 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
8018 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
8019 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
8020 (QCgnutls_bootprop_verify_hostname_error)
8021 (QCgnutls_bootprop_callbacks_verify): Rename from
8022 Qgnutls_bootprop_..., all uses changed.
8023
8024 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
8025 uses changed.
8026
0a0d27fb
PE
80272011-08-14 Paul Eggert <eggert@cs.ucla.edu>
8028
19d5c50c
PE
8029 * xfaces.c (Qframe_set_background_mode): Now static.
8030 * dispextern.h (Qframe_set_background_mode): Remove decl.
8031
0a0d27fb
PE
8032 * process.c (Fnetwork_interface_info): Declare local only if needed.
8033
377538cb
JD
80342011-08-13 Jan Djärv <jan.h.d@swipnet.se>
8035
8036 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
8037 (Fnetwork_interface_list): Allocate in increments of bytes instead
8038 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
8039 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
8040 sockaddr.
8041 (struct ifflag_def): notrailers is smart on OSX.
8042 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
8043 Get hardware address with getifaddrs if available.
8044
08fff70c
EZ
80452011-08-12 Eli Zaretskii <eliz@gnu.org>
8046
8047 * xdisp.c (iterate_out_of_display_property): xassert that
8048 IT->position is set to within IT->object's boundaries. Break from
8049 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
8050 when IT->position is set up wrongly due to some bug.
8051 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
8052 (push_display_prop): Allow GET_FROM_STRING as IT->method on
8053 entry. Force push_it to save on the stack the current
8054 buffer/string position, to be restored by pop_it. Fix flags in
8055 the iterator structure wrt the object coming from a display
8056 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
8057 properties. (Bug#9284)
8058
7be1c708 80592011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 8060
7be1c708
CY
8061 * fontset.c (fontset_get_font_group): Add proper type checks.
8062 (Bug#9172)
aac0c6e3 8063
7be1c708 80642011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 8065
7be1c708
CY
8066 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
8067 and LC_VERSION_MIN_MACOSX.
8068 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
8069 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 8070
97bb72a6
EZ
80712011-08-08 Eli Zaretskii <eliz@gnu.org>
8072
8073 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
8074 no-display-properties-and-no-overlays under bidi display.
8075 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 8076 properties and overlays.
97bb72a6 8077
d5617611
CY
80782011-08-08 Chong Yidong <cyd@stupidchicken.com>
8079
37e11a63
CY
8080 * editfns.c (Fset_time_zone_rule): Document relationship with the
8081 setenv function.
8082
d5617611
CY
8083 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
8084 the font entity extracted from the cache (Bug#8109).
8085
58872834
CY
80862011-08-07 Chong Yidong <cyd@stupidchicken.com>
8087
8088 * composite.c (autocmp_chars): Don't reset point. That is done by
8089 restore_point_unwind (Bug#5984).
8090
75bfc667
JL
80912011-08-07 Juri Linkov <juri@jurta.org>
8092
8093 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
8094 to show the arg `TIME' instead of `TIMEVAL'.
8095
d1410150
EZ
80962011-08-06 Eli Zaretskii <eliz@gnu.org>
8097
8098 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
8099 display property strides EOL and includes a newline, as in
8100 longlines-mode. (Bug#9254)
75b771e4
EZ
8101 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
8102 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
8103
8104 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
8105 is non-zero, even if the data buffer is NULL. Fixes a crash in
8106 vertical-motion with longlines-mode. (Bug#9254)
8107
35928349
EZ
81082011-08-05 Eli Zaretskii <eliz@gnu.org>
8109
ec7cc85b
EZ
8110 * bidi.c <bidi_cache_total_alloc>: Now static.
8111 (bidi_initialize): Initialize bidi_cache_total_alloc.
8112
8b76d6f8 8113 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
8114 cache. (Bug#9221)
8115
8116 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
8117 amount allocated this far in `bidi_cache_total_alloc'.
8118 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
8119 non-zero, only free the data buffer without restoring the cache
8120 contents. All callers changed.
8121
8122 * dispextern.h (bidi_unshelve_cache): Update prototype.
8123
8124 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
8125 (move_it_in_display_line, move_it_to)
8126 (move_it_vertically_backward, move_it_by_lines): Replace the call
8127 to xfree to an equivalent call to bidi_unshelve_cache.
8128 (move_it_in_display_line_to): Fix logic of returning
412b6358 8129 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 8130
e2e2423b
EZ
81312011-08-05 Eli Zaretskii <eliz@gnu.org>
8132
8133 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
8134 came from a string character with a `cursor' property. (Bug#9229)
8135
ae9e757a
JD
81362011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8137
8138 * Makefile.in (LIB_PTHREAD): New variable.
8139 (LIBES): Add LIB_PTHREAD (Bug#9216).
8140
8141 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
8142 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
8143
213bd7f2
AS
81442011-08-04 Andreas Schwab <schwab@linux-m68k.org>
8145
6b02f655 8146 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 8147
99aaf75f
JD
81482011-08-04 Jan Djärv <jan.h.d@swipnet.se>
8149
8150 * xterm.c (x_find_topmost_parent): New function.
8151 (x_set_frame_alpha): Find topmost parent window with
8152 x_find_topmost_parent and set the property there also (bug#9181).
8153 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
8154
c74e9d86
PE
81552011-08-04 Paul Eggert <eggert@cs.ucla.edu>
8156
8157 * callproc.c (Fcall_process): Avoid vfork clobbering
8158 the local vars buffer, coding_systems, current_dir.
8159
640c8776
SM
81602011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
8161
8162 * keymap.c (Fmake_composed_keymap): Move to subr.el.
8163
f26d0e4c
PE
81642011-08-03 Paul Eggert <eggert@cs.ucla.edu>
8165
8a10d76c
PE
8166 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
8167 so that it is not optimized away.
8168
f26d0e4c
PE
8169 * xdisp.c (compute_display_string_pos): Remove unused local.
8170
55439c61
EZ
81712011-08-02 Eli Zaretskii <eliz@gnu.org>
8172
8173 Fix slow cursor motion and scrolling in large buffers with
8174 selective display, like Org Mode buffers. (Bug#9218)
8175
8176 * dispextern.h (struct bidi_it): New member disp_prop_p.
8177
8178 * xdisp.c: Remove one-slot cache of display string positions.
8179 (compute_display_string_pos): Accept an additional argument
5e617bc2 8180 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
8181 for a display string or property. If found, set DISP_PROP_P
8182 non-zero.
8183
8184 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
8185 DISP_PROP_P, and pass it to compute_display_string_pos.
8186 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
8187 non-zero. All callers of bidi_fetch_char changed.
8188
fb33fa43
SM
81892011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
8190
8191 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
8192
b099e063
DM
81932010-12-03 Don March <don@ohspite.net>
8194
8195 * keymap.c (Fdefine_key): Fix non-prefix key error message when
8196 last character M-[char] is translated to ESC [char] (bug#7541).
8197
5cc7f7af
KH
81982011-08-02 Kenichi Handa <handa@m17n.org>
8199
d0fffa3f 8200 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
8201
8202 * chartab.c (uniprop_table): Make it non-static.
8203
525d5e6e
EZ
82042011-08-01 Eli Zaretskii <eliz@gnu.org>
8205
8206 * xdisp.c (forward_to_next_line_start): Accept additional argument
8207 BIDI_IT_PREV, and store into it the state of the bidi iterator had
8208 on the newline.
8209 (reseat_at_next_visible_line_start): Use the bidi iterator state
8210 returned by forward_to_next_line_start to restore the state of
8211 it->bidi_it after backing up to previous newline. (Bug#9212)
8212
31011111
AS
82132011-07-30 Andreas Schwab <schwab@linux-m68k.org>
8214
8215 * regex.c (re_comp): Protoize.
8216 (re_exec): Fix return type.
8217 (regexec): Fix type of `ret'. (Bug#9203)
8218
476371c4
PE
82192011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8220
e5d76069
PE
8221 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
8222 This is needed if max-image-size is a floating-point number.
8223
9a79b20c
AS
82242011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8225
8226 * print.c (print_object): Print empty symbol as ##.
8227
8228 * lread.c (read1): Read ## as empty symbol.
8229
d8c2fa78
AA
82302011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
8231
8232 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
8233 setting frame foreground color (Bug#9175).
8234 (x_set_background_color): Likewise.
8235
ffe57a7a
AA
8236 * nsmenu.m (-setText): Size tooltip dimensions precisely to
8237 contents (Bug#9176).
8238 (EmacsTooltip -init): Remove bezels and add shadows to
8239 tooltip windows.
8240
bf3492a5
AA
8241 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
8242 or scroll bar (Bug#8470).
8243
d55e9c53
AA
8244 * nsfont.m (nsfont_open): Remove assignment to voffset and
8245 unnecessary vars hshink, expand, hd, full_height, min_height.
8246 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
8247
8248 * nsterm.h (nsfont_info): Remove voffset field.
8249
d8c2fa78 82502011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
8251
8252 Implement strike-through and overline on NextStep (Bug#8863).
8253
8254 * nsfont.m (nsfont_open): Use underline position provided by font,
8255 instead of hard-coded value of 2.
8256 (nsfont_draw): Call ns_draw_text_decoration instead.
8257
8258 * nsterm.h: Add declaration for ns_draw_text_decoration.
8259
8260 * nsterm.m (ns_draw_text_decoration): New function for drawing
8261 underline, overline, and strike-through.
8262 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
8263 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 8264 accommodate underlining, etc.
4843aac3 8265
4cc60b9b
EZ
82662011-07-28 Eli Zaretskii <eliz@gnu.org>
8267
bc7ece87
EZ
8268 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
8269 default.
4cc60b9b 8270
476371c4
PE
82712011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8272
66606eea
PE
8273 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
8274 Without this fix, if a signal arrives just after memory fills up,
8275 'malloc' might be invoked reentrantly.
8276
476371c4
PE
8277 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
8278 In other words, assume that every image size is allowed, on non-X
8279 hosts. This assumption is probably wrong, but it lets Emacs compile.
8280
f3fcc40d
AS
82812011-07-28 Andreas Schwab <schwab@linux-m68k.org>
8282
8283 * regex.c (re_iswctype): Convert return values to boolean.
8284
350c992f
EZ
82852011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
8286
8287 * xdisp.c (compute_display_string_pos): Don't use cached display
8288 string position if the buffer had its restriction changed.
8289 (Bug#9184)
8290
5266b4bb
PE
82912011-07-28 Paul Eggert <eggert@cs.ucla.edu>
8292
8293 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
8294
2573a837 82952011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 8296
41f55ccd 8297 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 8298
39e378da
PE
8299 * bidi.c: Integer size and overflow fixes.
8300 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
8301 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
8302 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8303 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
8304 (bidi_find_other_level_edge):
8305 Use ptrdiff_t instead of EMACS_INT where either will do.
8306 This works better on 32-bit hosts configured --with-wide-int.
8307 (bidi_cache_ensure_space): Check for size-calculation overflow.
8308 Use % rather than repeated addition, for better worst-case speed.
8309 Don't set bidi_cache_size until after xrealloc returns, because it
8310 might not return.
8311 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
8312 (bidi_cache_ensure_space): Also check that the bidi cache size
8313 does not exceed that of the largest Lisp string or buffer. See Eli
8314 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 8315
5e927815
PE
8316 * alloc.c (__malloc_size_t): Remove.
8317 All uses replaced by size_t. See Andreas Schwab's note
8318 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
8319
ca4aa935
PE
8320 * image.c: Improve checking for integer overflow.
8321 (check_image_size): Assume that f is nonnull, since
8322 it is always nonnull in practice. This is one less thing to
8323 worry about when checking for integer overflow later.
8324 (x_check_image_size): New function, which checks for integer
8325 overflow issues inside X.
8326 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
8327 This removes the need for a memory_full check.
8328 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
8329 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
8330 (xbm_read_bitmap_data): Change locals back to 'int', since
8331 their values must fit in 'int'.
8332 (xpm_load_image, png_load, tiff_load):
8333 Invoke x_create_x_image_and_pixmap earlier,
8334 to avoid much needless work if the image is too large.
8335 (tiff_load): Treat overly large images as if
8336 x_create_x_image_and_pixmap failed, not as malloc failures.
8337 (gs_load): Use x_check_image_size.
8338
5f8f9cc2
PE
8339 * gtkutil.c: Omit integer casts.
8340 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
8341 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
8342
5adf60bc
PE
8343 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
8344
c8907a93
PE
8345 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
8346 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
8347 would wrongly return t on a 64-bit host.
8348
e3c25c68
PE
8349 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
8350 The plain *_OVERFLOW macros run afoul of GCC bug 49705
8351 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
8352 and therefore cause GCC to emit a bogus diagnostic in some cases.
8353
3f791afe
PE
8354 * image.c: Integer signedness and overflow and related fixes.
8355 This is not an exhaustive set of fixes, but it's time to
8356 record what I've got.
8357 (lookup_pixel_color, check_image_size): Remove redundant decls.
8358 (check_image_size): Don't assume that arbitrary EMACS_INT values
8359 fit in 'int', or that arbitrary 'double' values fit in 'int'.
8360 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
8361 (tiff_load, imagemagick_load_image):
8362 Check for overflow in size calculations.
8363 (x_create_x_image_and_pixmap): Remove unnecessary test for
8364 xmalloc returning NULL; that can't happen.
8365 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
8366 (xpm_color_bucket): Use better integer hashing function.
8367 (xpm_cache_color): Don't possibly over-allocate memory.
8368 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
8369 (gif_memory_source):
8370 Use ptrdiff_t, not int or size_t, to record sizes.
8371 (png_load): Don't assume values greater than 2**31 fit in 'int'.
8372 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
8373 either works, as we prefer signed integers.
8374 (tiff_read_from_memory, tiff_write_from_memory):
8375 Return tsize_t, not size_t, since that's what the TIFF API wants.
8376 (tiff_read_from_memory): Don't fail simply because the read would
8377 go past EOF; instead, return a short read.
8378 (tiff_load): Omit no-longer-needed casts.
8379 (Fimagemagick_types): Don't assume size fits into 'int'.
8380
3cc5a532
PE
8381 Improve hashing quality when configured --with-wide-int.
8382 * fns.c (hash_string): New function, taken from sxhash_string.
8383 Do not discard information about ASCII character case; this
8384 discarding is no longer needed.
8385 (sxhash-string): Use it. Change sig to match it. Caller changed.
8386 * lisp.h: Declare it.
8387 * lread.c (hash_string): Remove, since we now use fns.c's version.
8388 The fns.c version returns a wider integer if --with-wide-int is
8389 specified, so this should help the quality of the hashing a bit.
8390
b312a492
PE
8391 * emacs.c: Integer overflow minor fix.
8392 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
8393 Define only if GNU_LINUX.
8394 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
8395
dfd153ae
PE
8396 * dispnew.c: Integer signedness and overflow fixes.
8397 Remove unnecessary forward decls, that were a maintenance hassle.
8398 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
8399 All uses changed.
8400 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
8401 (scrolling_window): Use ptrdiff_t, not int, for byte count.
8402 (prepare_desired_row, line_draw_cost):
8403 Use int, not unsigned, where either works.
8404 (save_current_matrix, restore_current_matrix):
8405 Use ptrdiff_t, not size_t, where either works.
8406 (init_display): Check for overflow more accurately, and without
8407 relying on undefined behavior.
8408
a81d11a3
PE
8409 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
8410 Remove, replacing with the new symbols in lisp.h. All uses changed.
8411 * fileio.c (make_temp_name):
8412 * filelock.c (lock_file_1, lock_file):
8413 * xdisp.c (message_dolog):
8414 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
8415 Use pMd etc. instead.
8416 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
8417 replacing the pWIDE etc. symbols removed from editfns.c.
8418
3300e6fd
PE
8419 * keyboard.h (num_input_events): Now uintmax_t.
8420 This is (very slightly) less likely to mess up due to wraparound.
8421 All uses changed.
8422
fd05c7e9
PE
8423 * buffer.c: Integer signedness fixes.
8424 (alloc_buffer_text, enlarge_buffer_text):
8425 Use ptrdiff_t rather than size_t when either will do, as we prefer
8426 signed integers.
8427
903fe15d
PE
8428 * alloc.c: Integer signedness and overflow fixes.
8429 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
8430 (__malloc_size_t): Default to size_t, not to int.
8431 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
8432 (Fgarbage_collect, mark_object_loop_halt, mark_object):
8433 Prefer ptrdiff_t to size_t when either would do, as we prefer
8434 signed integers.
8435 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
8436 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
8437 Now const. Initialize with values that are in range even if char
8438 is signed.
8439 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
8440 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
8441 These functions do the right thing with sizes > 2**32.
8442 (check_depth): Now ptrdiff_t, not int.
8443 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
8444 Adjust to new way of storing sizes. Check for size overflow bugs
8445 in rest of code.
8446 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
8447 slightly wrong anyway, as it missed one instance of
8448 XMALLOC_OVERRUN_CHECK_OVERHEAD.
8449 (refill_memory_reserve): Omit needless cast to size_t.
8450 (mark_object_loop_halt): Mark as externally visible.
8451
ac82cc6a
PE
8452 * xselect.c: Integer signedness and overflow fixes.
8453 (Fx_register_dnd_atom, x_handle_dnd_message):
8454 Use ptrdiff_t, not size_t, since we prefer signed.
8455 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
8456 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
8457 x_dnd_atoms_size and x_dnd_atoms_length.
8458
c2d1e36d
PE
8459 * doprnt.c: Prefer signed to unsigned when either works.
8460 * eval.c (verror):
8461 * doprnt.c (doprnt):
8462 * lisp.h (doprnt):
8463 * xdisp.c (vmessage):
8464 Use ptrdiff_t, not size_t, when using or implementing doprnt,
8465 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
8466 prefer signed arithmetic to avoid comparison confusion.
8467 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
8468 but is a bit tricky.
8469
0e926e56
PE
8470 Assume freestanding C89 headers, string.h, stdlib.h.
8471 * data.c, doprnt.c, floatfns.c, print.c:
8472 Include float.h unconditionally.
8473 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
8474 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
8475 * regex.c: Likewise for stddef.h, string.h.
8476 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
8477 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
8478 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
8479 (STDC_HEADERS): Remove obsolete defines.
8480 * sysdep.c: Include limits.h unconditionally.
8481
9cfdb3ec
PE
8482 Assume support for memcmp, memcpy, memmove, memset.
8483 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
8484 * regex.c (memcmp, memcpy):
8485 Remove; we assume C89 now.
8486
8487 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
8488 (__malloc_safe_bcopy): Remove; no longer needed.
8489
cf950e6b 8490 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
8491 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
8492 well either way, and we prefer signed to unsigned.
8493
dbf38e02
LMI
84942011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
8495
8496 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
8497 closes the connection while we're reading (bug#9182).
8498
d6f0886c 84992011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 8500
d6f0886c
JD
8501 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
8502 are specified (Bug#9168).
24e0f6b1 8503
2eb1f9e6
PE
85042011-07-25 Paul Eggert <eggert@cs.ucla.edu>
8505
8506 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
8507 Found by GCC static checking and --with-wide-int on a 32-bit host.
8508
22381272 85092011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
8510
8511 * xdisp.c (compute_display_string_pos): Fix logic of caching
8512 previous display string position. Initialize cached_prev_pos to
8513 -1. Fixes slow-down at the beginning of a buffer.
8514
f25e39b4
EZ
85152011-07-24 Eli Zaretskii <eliz@gnu.org>
8516
8517 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
8518 for attrs[LFACE_FONTSET_INDEX].
8519
04c4b52e
PE
85202011-07-23 Paul Eggert <eggert@cs.ucla.edu>
8521
8522 * xml.c (parse_region): Remove unused local
8523 that was recently introduced.
8524
c1734fbd
EZ
85252011-07-23 Eli Zaretskii <eliz@gnu.org>
8526
be18c5a5
EZ
8527 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
8528 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
8529
c1734fbd
EZ
8530 * xdisp.c (move_it_in_display_line_to): Record the best matching
8531 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
8532 exit if none of the characters scanned was an exact match.
8533 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
8534 when exact match is impossible due to invisible text, and the
8535 lines are truncated.
8536
a258d627
JD
85372011-07-23 Jan Djärv <jan.h.d@swipnet.se>
8538
8539 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
8540 for OSX >= 10.7.
8541
b6d5a689
EZ
85422011-07-22 Eli Zaretskii <eliz@gnu.org>
8543
0f74f785
EZ
8544 Fix a significant slow-down of cursor motion with C-n, C-p,
8545 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
8546 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 8547 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
8548 (next_element_from_buffer): Call compute_stop_pos_backwards to
8549 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
8550 base_level_stop.
8551 (reseat): Don't look for prev_stop, as that could mean a very long
8552 run.
8553 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
8554 <cached_disp_overlay_modiff>: Cache for last found display string
8555 position.
551918c1 8556 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
8557 about the same buffer in the same area of character positions, and
8558 the buffer wasn't changed since the time the display string
8559 position was cached.
551918c1 8560
b2d0c91a
EZ
85612011-07-22 Eli Zaretskii <eliz@gnu.org>
8562
8563 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
8564 is an integer, which is important for empty lines. (Bug#9149)
8565
043604ee
CY
85662011-07-22 Chong Yidong <cyd@stupidchicken.com>
8567
8568 * frame.c (Fmodify_frame_parameters): In tty case, update the
8569 default face if necessary (Bug#4238).
8570
da4adb04
CY
85712011-07-21 Chong Yidong <cyd@stupidchicken.com>
8572
8573 * editfns.c (Fstring_to_char): No need to explain what a character
8574 is in the docstring (Bug#6576).
8575
9abd0532
LMI
85762011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8577
8578 * xml.c (parse_region): Make sure we always return a tree.
8579
36881d16
HK
85802011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
8581
8582 * xml.c (parse_region): If a document contains only comments,
8583 return that, too.
8584
1e98674d
LMI
85852011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
8586
8587 * xml.c (make_dom): Return comments, too.
8588
590bd467
PE
85892011-07-19 Paul Eggert <eggert@cs.ucla.edu>
8590
8591 Port to OpenBSD.
8592 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
8593 and the surrounding thread.
8594 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
8595 rather than fgets, and retry after EINTR. Otherwise, 'emacs
8596 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
8597 timer goes off.
8598 * s/openbsd.h (BROKEN_SIGIO): Define.
8599 * unexelf.c (unexec) [__OpenBSD__]:
8600 Don't update the .mdebug section of the Alpha COFF symbol table.
8601
f41628b2
LMI
86022011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
8603
8604 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
8605 (bug#8460).
8606
b59b67c5
PE
86072011-07-18 Paul Eggert <eggert@cs.ucla.edu>
8608
15e3a074
PE
8609 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
8610 This fixes some race conditions on the permissions of any newly
8611 created file.
8612
41bed37d
PE
8613 * alloc.c (valid_pointer_p): Use pipe, not open.
8614 This fixes some permissions issues when debugging.
8615
b59b67c5
PE
8616 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
8617 If fchown fails to set both uid and gid, try to set just gid,
8618 as that is sometimes allowed. Adjust the file's mode to eliminate
8619 setuid or setgid bits that are inappropriate if fchown fails.
8620
925a6be7
SM
86212011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
8622
8623 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
8624 to compare Lisp_Objects.
8625 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
8626 global_gnutls_log_level, don't mistake it for a Lisp_Object.
8627 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
8628
52968808
AS
86292011-07-17 Andreas Schwab <schwab@linux-m68k.org>
8630
0a6a104b
AS
8631 * lread.c (read_integer): Unread even EOF character.
8632 (read1): Likewise. Properly record start position of symbol.
8633
52968808
AS
8634 * lread.c (read1): Read `#:' as empty uninterned symbol if no
8635 symbol character follows.
8636
9e381cdd
PE
86372011-07-17 Paul Eggert <eggert@cs.ucla.edu>
8638
8639 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
8640 This works around a problem with the previous change to Fcopy_file.
8641 Recent glibc declares fchown with __attribute__((warn_unused_result)),
8642 and without this change, GCC might complain about discarding
8643 fchown's return value.
8644
b5641435
JB
86452011-07-16 Juanma Barranquero <lekktu@gmail.com>
8646
8647 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
8648
a8031457
PE
86492011-07-16 Paul Eggert <eggert@cs.ucla.edu>
8650
8651 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
8652
dd889327
LMI
86532011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
8654
750c33f7
LMI
8655 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
8656 it's used from the C level.
8657
dd889327
LMI
8658 * process.c: Use the same condition for POLL_FOR_INPUT in both
8659 keyboard.c and process.c (bug#1858).
8660
87e86684
LM
86612011-07-09 Lawrence Mitchell <wence@gmx.li>
8662
8663 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
8664 (Fgnutls_boot): Use it.
8665
64348f40
AS
86662011-07-15 Andreas Schwab <schwab@linux-m68k.org>
8667
8668 * doc.c (Fsubstitute_command_keys): Revert last change.
8669
1d698799
LMI
86702011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
8671
f863868c
LMI
8672 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
8673 quotes the next character, and doesn't affect other longer
8674 sequences (bug#8935).
8675
1d698799
LMI
8676 * lread.c (syms_of_lread): Clarify that is isn't only
8677 `eval-buffer' and `eval-defun' that's affected by
8678 `lexical-binding' (bug#8460).
8679
aa4b6df6
EZ
86802011-07-15 Eli Zaretskii <eliz@gnu.org>
8681
8682 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 8683 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 8684
5d856da6
PE
86852011-07-14 Paul Eggert <eggert@cs.ucla.edu>
8686
ad6042bb
PE
8687 Fix minor problems found by static checking.
8688 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
8689 (elsz): Now a signed constant, not a size_t var. We prefer signed
8690 types to unsigned, to avoid integer comparison confusion. Without
8691 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
8692 "cannot optimize loop, the loop counter may overflow", a symptom
8693 of the confusion.
f00bbb22 8694 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
8695 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
8696
6468f31c
LMI
86972011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8698
49080b10
LMI
8699 * search.c (Fre_search_backward): Mention `case-fold-search' in
8700 all the re_search_* functions (bug#8138).
8701
6468f31c
LMI
8702 * keyboard.c (Fopen_dribble_file): Document when the file is
8703 closed (bug#8056).
8704
c965adc5
EZ
87052011-07-14 Eli Zaretskii <eliz@gnu.org>
8706
df9733bf
EZ
8707 * bidi.c (bidi_dump_cached_states): Fix format of displaying
8708 bidi_cache_idx.
8709
0bb23927
EZ
8710 Support bidi reordering of display and overlay strings.
8711 * xdisp.c (compute_display_string_pos)
8712 (compute_display_string_end): Accept additional argument STRING.
8713 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
8714 (reseat_to_string): Initialize bidi_it->string.s and
8715 bidi_it->string.schars.
8716 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
8717 NULL (avoids a crash in bidi_paragraph_init).
8718 Initialize itb.string.lstring.
0bb23927
EZ
8719 (init_iterator): Call bidi_init_it only of a valid
8720 buffer position was specified. Initialize paragraph_embedding to
8721 L2R.
8722 (reseat_to_string): Initialize the bidi iterator.
8723 (display_string): If we need to ignore text properties of
8724 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
8725 original value of -1 will not work with bidi.)
8726 (compute_display_string_pos): First arg is now struct
8727 `text_pos *'; all callers changed. Support display properties on
8728 Lisp strings.
8729 (compute_display_string_end): Support display properties on Lisp
8730 strings.
8731 (init_iterator, reseat_1, reseat_to_string): Initialize the
8732 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
8733 when iterating on a string not from display properties).
640c8776
SM
8734 (compute_display_string_pos, compute_display_string_end):
8735 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
8736 arrow keys.
8737 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
8738 base_level_stop; instead, set base_level_stop to BEGV.
8739 Fixes crashes in vertical-motion.
0bb23927
EZ
8740 (next_element_from_buffer): Improve commentary for when
8741 the iterator is before prev_stop.
8742 (init_iterator): Initialize bidi_p from the default value of
8743 bidi-display-reordering, not from buffer-local value. Use the
8744 buffer-local value only if initializing for buffer iteration.
8745 (handle_invisible_prop): Support invisible properties on strings
8746 that are being bidi-reordered.
8747 (set_iterator_to_next): Support bidi reordering of C strings and
8748 Lisp strings.
8749 (next_element_from_string): Support bidi reordering of Lisp
8750 strings.
8751 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
8752 (display_string): Support display of R2L glyph rows.
8753 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
8754 (init_iterator): Don't initialize it->bidi_p for strings
8755 here.
8756 (reseat_to_string): Initialize it->bidi_p for strings here.
8757 (next_element_from_string, next_element_from_c_string)
8758 (next_element_from_buffer): Add xassert's for correspondence
8759 between IT's object being iterated and it->bidi_it.string
8760 structure.
8761 (face_before_or_after_it_pos): Support bidi iteration.
8762 (next_element_from_c_string): Handle the case of the first string
8763 character that is not the first one in the visual order.
8764 (get_visually_first_element): New function, refactored from common
8765 parts of next_element_from_buffer, next_element_from_string, and
8766 next_element_from_c_string.
8767 (tool_bar_lines_needed, redisplay_tool_bar)
8768 (display_menu_bar): Force left-to-right direction. Add a FIXME
8769 comment for making that be controlled by a user option.
8770 (push_it, pop_it): Save and restore the state of the
8771 bidi iterator. Save and restore the bidi_p flag.
8772 (pop_it): Iterate out of display property for string iteration as
8773 well.
8774 (iterate_out_of_display_property): Support iteration over strings.
8775 (handle_single_display_spec): Set up it->bidi_it for iteration
8776 over a display string, and call bidi_init_it.
8777 (handle_single_display_spec, next_overlay_string)
8778 (get_overlay_strings_1, push_display_prop): Set up the bidi
8779 iterator for displaying display or overlay strings.
8780 (forward_to_next_line_start): Don't use the shortcut if
8781 bidi-iterating.
8782 (back_to_previous_visible_line_start): If handle_display_prop
8783 pushed the iterator stack, restore the internal state of the bidi
8784 iterator by calling bidi_pop_it same number of times.
8785 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
8786 and we are bidi-iterating, don't decrement the iterator position;
8787 instead, set the first_elt flag in the bidi iterator, to produce
8788 the same effect.
8789 (reseat_1): Remove redundant setting of string_from_display_prop_p.
8790 (push_display_prop): xassert that we are iterating a buffer.
8791 (push_it, pop_it): Save and restore paragraph_embedding member.
8792 (handle_single_display_spec, next_overlay_string)
8793 (get_overlay_strings_1, reseat_1, reseat_to_string)
8794 (push_display_prop): Set up the `unibyte' member of bidi_it.string
8795 correctly. Don't assume unibyte strings are not bidi-reordered.
8796 (compute_display_string_pos)
8797 (compute_display_string_end): Fix handling the case of C string.
8798 (push_it, pop_it): Save and restore from_disp_prop_p.
8799 (handle_single_display_spec, push_display_prop): Set the
8800 from_disp_prop_p flag.
8801 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
8802 (pop_it): Call iterate_out_of_display_property only if we are
8803 popping after iteration over a string that came from a display
8804 property. Fix a typo in popping stretch info. Add an assertion
8805 for verifying that the iterator position is in sync with the bidi
8806 iterator.
8807 (handle_single_display_spec, get_overlay_strings_1)
8808 (push_display_prop): Fix initialization of paragraph direction for
8809 string when that of the parent object is not yet determined.
8810 (reseat_1): Call bidi_init_it to resync the bidi
8811 iterator with IT's position. (Bug#7616)
8812 (find_row_edges): If ROW->start.pos gives position
8813 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
8814 (handle_stop, back_to_previous_visible_line_start, reseat_1):
8815 Reset the from_disp_prop_p flag.
8816 (SAVE_IT, RESTORE_IT): New macros.
8817 (pos_visible_p, face_before_or_after_it_pos)
8818 (back_to_previous_visible_line_start)
8819 (move_it_in_display_line_to, move_it_in_display_line)
8820 (move_it_to, move_it_vertically_backward, move_it_by_lines)
8821 (try_scrolling, redisplay_window, display_line): Use them when
8822 saving a temporary copy of the iterator and restoring it back.
8823 (back_to_previous_visible_line_start, reseat_1)
8824 (init_iterator): Empty the bidi cache "stack".
8825 (move_it_in_display_line_to): If iterator ended up at
8826 EOL, but we never saw any buffer positions smaller than
8827 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
8828 motion in bidi-reordered lines.
8829 (move_it_in_display_line_to): Record prev_method and prev_pos
8830 immediately before the call to set_iterator_to_next. Fixes cursor
8831 motion in bidi-reordered lines with stretch glyphs and strings
8832 displayed in margins. (Bug#8133) (Bug#8867)
8833 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
8834 TO_CHARPOS.
640c8776
SM
8835 (pos_visible_p): Support positions in bidi-reordered lines.
8836 Save and restore bidi cache.
0bb23927
EZ
8837
8838 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
8839 (bidi_paragraph_info): Delete unused struct.
8840 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
8841 (bidi_cache_start): New variable.
8842 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
8843 to zero.
8844 (bidi_cache_fetch_state, bidi_cache_search)
8845 (bidi_cache_find_level_change, bidi_cache_iterator_state)
8846 (bidi_cache_find, bidi_peek_at_next_level)
8847 (bidi_level_of_next_char, bidi_find_other_level_edge)
8848 (bidi_move_to_visually_next): Compare cache index with
8849 bidi_cache_start rather than with zero.
8850 (bidi_fetch_char): Accept new argument STRING; all callers
8851 changed. Support iteration over a string. Support strings with
8852 display properties. Support unibyte strings. Fix the type of
8853 `len' according to what STRING_CHAR_AND_LENGTH expects.
8854 (bidi_paragraph_init, bidi_resolve_explicit_1)
8855 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
8856 (bidi_level_of_next_char, bidi_move_to_visually_next):
8857 Support iteration over a string.
0bb23927
EZ
8858 (bidi_set_sor_type, bidi_resolve_explicit_1)
8859 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
8860 can now be zero (for strings); special values 0 and -1 were
8861 changed to -1 and -2, respectively.
8862 (bidi_char_at_pos): New function.
8863 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
8864 Call it instead of FETCH_MULTIBYTE_CHAR.
8865 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
8866 initialized to valid values.
8867 (bidi_init_it): Don't initialize charpos and bytepos with invalid
8868 values.
8869 (bidi_level_of_next_char): Allow the sentinel "position" to pass
8870 the test for valid cached positions. Fix the logic for looking up
8871 the sentinel state in the cache. GCPRO the Lisp string we are
8872 iterating.
8873 (bidi_push_it, bidi_pop_it): New functions.
8874 (bidi_initialize): Initialize the bidi cache start stack pointer.
8875 (bidi_cache_ensure_space): New function, refactored from part of
8876 bidi_cache_iterator_state. Don't assume the required size is just
8877 one BIDI_CACHE_CHUNK away.
8878 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
8879 (bidi_count_bytes, bidi_char_at_pos): New functions.
8880 (bidi_cache_search): Don't assume bidi_cache_last_idx is
8881 always valid if bidi_cache_idx is valid.
8882 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
8883 is valid if it's going to be used.
8884 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
8885 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
8886 (bidi_cache_find_level_change, bidi_cache_ensure_space)
8887 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
8888 (bidi_find_other_level_edge, bidi_cache_start_stack):
8889 All variables related to cache indices are now EMACS_INT.
c965adc5 8890
0bb23927
EZ
8891 * dispextern.h (struct bidi_string_data): New structure.
8892 (struct bidi_it): New member `string'. Make flag members be 1-bit
8893 fields, and put them last in the struct.
640c8776
SM
8894 (compute_display_string_pos, compute_display_string_end):
8895 Update prototypes.
0bb23927
EZ
8896 (bidi_push_it, bidi_pop_it): Add prototypes.
8897 (struct iterator_stack_entry): New members bidi_p,
8898 paragraph_embedding, and from_disp_prop_p.
8899 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
8900 (bidi_shelve_cache, bidi_unshelve_cache):
8901 Declare prototypes.
0bb23927
EZ
8902
8903 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
8904 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
8905 and vector-like objects.
8906
8907 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
8908 cache around display iteration.
8909
8910 * window.c (Fwindow_end, window_scroll_pixel_based)
8911 (displayed_window_lines, Frecenter): Save and restore the bidi
8912 cache around display iteration.
8913
3bbd2265
LMI
89142011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
8915
8916 * editfns.c (Fdelete_region): Clarify the use of the named
8917 parameters (bug#6788).
8918
adc47434
MR
89192011-07-14 Martin Rudalics <rudalics@gmx.at>
8920
8921 * indent.c (Fvertical_motion): Set and restore w->pointm when
8922 saving and restoring the window's buffer (Bug#9006).
8923
837c31f8
LMI
89242011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
8925
8926 * editfns.c (Fstring_to_char): Clarify just what is returned
8927 (bug#6576). Text by Eli Zaretskii.
8928
ac389d0c
JB
89292011-07-13 Juanma Barranquero <lekktu@gmail.com>
8930
8931 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
8932
0be0ce47
EZ
89332011-07-13 Eli Zaretskii <eliz@gnu.org>
8934
8935 * buffer.c (mmap_find): Fix a typo.
8936
cd18e7e3
JB
89372011-07-13 Johan Bockgård <bojohan@gnu.org>
8938
8939 Fix execution of x selection hooks.
8940 * xselect.c (Qx_lost_selection_functions)
8941 (Qx_sent_selection_functions): New vars.
8942 (syms_of_xselect): DEFSYM them.
8943 (x_handle_selection_request): Pass Qx_sent_selection_functions
8944 rather than Vx_sent_selection_functions to Frun_hook_with_args.
8945 (x_handle_selection_clear,x_clear_frame_selections):
8946 Pass Qx_lost_selection_functions rather than
8947 Vx_lost_selection_functions to Frun_hook_with_args.
8948
47ea7f44
PE
89492011-07-13 Paul Eggert <eggert@cs.ucla.edu>
8950
ac389d0c 8951 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
8952 The old code sometimes used this field without initializing it.
8953
47ea7f44
PE
8954 * alloc.c (gc_sweep): Don't read past end of array.
8955 In theory, the old code could also have corrupted Emacs internals,
8956 though it'd be very unlikely.
8957
bc985c87
AS
89582011-07-12 Andreas Schwab <schwab@linux-m68k.org>
8959
8960 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 8961 argument. (Bug#4026)
bc985c87 8962
0cf34688
LMI
89632011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
8964
b3dadd76
LMI
8965 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
8966 key" (bug#4257).
8967
0cf34688
LMI
8968 * window.c (Fset_window_start): Doc fix (bug#4199).
8969 (Fset_window_hscroll): Ditto.
8970
270768cd
PE
89712011-07-12 Paul Eggert <eggert@cs.ucla.edu>
8972
077e3dda 8973 Fix minor new problems caught by GCC 4.6.1.
270768cd 8974 * term.c (init_tty): Remove unused local.
490011a6 8975 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 8976 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 8977 not used otherwise.
270768cd 8978
b1f58454
CY
89792011-07-12 Chong Yidong <cyd@stupidchicken.com>
8980
8981 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
8982
22b9578d
LMI
89832011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
8984
6e70ab07
LMI
8985 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
8986 are the mini-buffer and the echo area (bug#3320).
8987
22b9578d
LMI
8988 * term.c (init_tty): Remove support for supdup, c10 and perq
8989 terminals, which are no longer supported (bug#1482).
8990
8974cc9f
JB
89912011-07-10 Johan Bockgård <bojohan@gnu.org>
8992
8993 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
8994
a560d974
JD
89952011-07-10 Jan Djärv <jan.h.d@swipnet.se>
8996
8997 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
8998 for non-popups (Bug#3642).
8999
1dae0f0a
AS
90002011-07-10 Andreas Schwab <schwab@linux-m68k.org>
9001
268c2c36 9002 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 9003 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
9004 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
9005 * cm.c (losecursor): Likewise.
1dae0f0a
AS
9006 * data.c (fmod): Likewise.
9007 * dispnew.c (swap_glyphs_in_rows): Likewise.
9008 * emacs.c (memory_warning_signal): Likewise.
9009 * floatfns.c (float_error): Likewise.
9010 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
9011 (otf_open, font_otf_capability, generate_otf_features)
9012 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
9013 Likewise.
9014 * image.c (pbm_read_file): Likewise.
9015 * indent.c (string_display_width): Likewise.
9016 * intervals.c (check_for_interval, search_for_interval)
9017 (inc_interval_count, count_intervals, root_interval)
9018 (adjust_intervals_for_insertion, make_new_interval): Likewise.
9019 * lread.c (defalias): Likewise.
268c2c36 9020 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
9021 * regex.c (set_image_of_range_1, set_image_of_range)
9022 (regex_grow_registers): Likewise.
9023 * sysdep.c (strerror): Likewise.
9024 * termcap.c (valid_filename_p, tprint, main): Likewise.
9025 * tparam.c (main): Likewise.
9026 * unexhp9k800.c (run_time_remap, save_data_space)
9027 (update_file_ptrs, read_header, write_header, calculate_checksum)
9028 (copy_file, copy_rest, display_header): Likewise.
9029 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
9030 Likewise.
9031 * xdisp.c (check_it): Likewise.
9032 * xfaces.c (register_color, unregister_color, unregister_colors):
9033 Likewise.
9034 * xfns.c (print_fontset_result): Likewise.
9035 * xrdb.c (member, fatal, main): Likewise.
9036
99033785
PE
90372011-07-10 Paul Eggert <eggert@cs.ucla.edu>
9038
9039 Fix minor problems found by static checking (Bug#9031).
9040 * chartab.c (char_table_set_range, map_sub_char_table):
9041 Remove unused locals.
9042 (uniprop_table): Now static.
9043 * composite.c (_work_char): Remove unused static var.
9044
9cb2ac56
JB
90452011-07-09 Juanma Barranquero <lekktu@gmail.com>
9046
9047 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
9048
f25661f0
JD
90492011-07-09 Jan Djärv <jan.h.d@swipnet.se>
9050
9051 * gtkutil.c (qttip_cb): Remove code without function.
9052
8278c4fe
EZ
90532011-07-09 Eli Zaretskii <eliz@gnu.org>
9054
9055 * w32.c (pthread_sigmask): New stub.
9056
1692ae2d 90572011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 9058
8a6ebd58 9059 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
9060 sigprocmask is portable only for single-threaded applications, and
9061 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
9062 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
9063 (LIBES): Use it.
9064 * callproc.c (Fcall_process):
9065 * process.c (create_process):
9066 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
9067 Use pthread_sigmask, not sigprocmask.
123403e4 9068
1b854618
JD
90692011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9070
9071 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
9072 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
9073 wrong (Bug#8591).
9074
3fe4b549
JD
90752011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9076
0ce7e563
JD
9077 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
9078 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
9079 (xg_hide_tooltip): Fix comment.
9080
3fe4b549
JD
9081 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
9082 in registerServicesMenuSendTypes.
9083 (validRequestorForSendType): Don't check ns_return_types.
9084
9085 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
9086 ns_return_type.
9087
5df75e47
JR
90882011-07-08 Jason Rumney <jasonr@gnu.org>
9089
22610910
JR
9090 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
9091 SH_SHOW for hidden windows (Bug#5482).
9092
5df75e47
JR
9093 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
9094 frame struct members of non-existent frames (Bug#6284).
9095
699c10bd
JD
90962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
9097
4393663b
JD
9098 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
9099 variable firstTime not needed on OSX >= 10.6.
9100 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
9101 >= 10.5. Use setKnobProportion, setDoubleValue.
9102
9103 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
9104 (MAC_OS_X_VERSION_10_5): Define if not defined.
9105 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
9106 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
9107 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
9108
9109 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
090bd7cb 9110 cString and lossyCString on OSX >= 10.4.
4393663b 9111
58179cce 9112 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
9113 sizeToFit on OSX >= 10.2.
9114
9115 * nsimage.m (allocInitFromFile): Don't use deprecated method
9116 bestRepresentationForDevice on OSX >= 10.6.
9117
9118 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
9119 to avoid warning.
9120
9121 * emacs.c: Declare unexec_init_emacs_zone.
9122
a63e0781
JD
9123 * nsgui.h: Fix compiler warning about gnulib redefining verify.
9124
699c10bd
JD
9125 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
9126
9127 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
9128 on svcsMenu (Bug#8842).
9129
9130 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
9131 ns_return_types.
9132 (Fns_list_services): Just return Qnil on 10.6, code not working there.
9133
9134 * nsterm.m (QUTF8_STRING): Declare.
9135 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
9136 (validRequestorForSendType): Return type is (id).
9137 Change indexOfObjectIdenticalTo to indexOfObject.
9138 Check if we have local selection before returning self (Bug#8842).
9139 (writeSelectionToPasteboard): Put local selection into paste board
9140 if we have a local selection (Bug#8842).
9141 (syms_of_nsterm): DEFSYM QUTF8_STRING.
9142
9143 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
9144 (ns_get_local_selection): Declare.
9145
54e10184
LMI
91462011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
9147
9888ff71
LMI
9148 * keymap.c (describe_map_tree): Don't insert a double newline at
9149 the end of the buffer (bug#1169) and return whether we inserted
9150 something.
9151
54e10184
LMI
9152 * callint.c (Fcall_interactively): Change "reading args" to
9153 "providing args" to try to clarify what it does (bug#1010).
9154
15fa4783
KH
91552011-07-07 Kenichi Handa <handa@m17n.org>
9156
9157 * composite.c (composition_compute_stop_pos): Ignore a static
9158 composition starting before CHARPOS (Bug#8915).
9159
9160 * xdisp.c (handle_composition_prop): Likewise.
9161
a8815b00
EZ
91622011-07-07 Eli Zaretskii <eliz@gnu.org>
9163
9164 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
9165 (Bug#9015)
9166
ef7b981d 91672011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
9168
9169 * character.h (unicode_category_t): New enum type.
9170
9171 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
9172 (Qchar_code_property_table): New variable.
9173 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
9174 (UNIPROP_COMPRESSED_FORM_P): New macros.
9175 (char_table_ascii): Uncompress the compressed values.
9176 (sub_char_table_ref): New arg is_uniprop. Callers changed.
9177 Uncompress the compressed values.
ac389d0c 9178 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
9179 (char_table_ref_and_range): Uncompress the compressed values.
9180 (sub_char_table_set): New arg is_uniprop. Callers changed.
9181 Uncompress the compressed values.
9182 (sub_char_table_set_range): Args changed. Callers changed.
9183 (char_table_set_range): Adjuted for the above change.
9184 (map_sub_char_table): Delete args default_val and parent. Add arg
9185 top. Give decoded values to a Lisp function.
640c8776 9186 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
9187 values to a Lisp function. Gcpro more variables.
9188 (uniprop_table_uncompress)
9189 (uniprop_decode_value_run_length): New functions.
9190 (uniprop_decoder, uniprop_decoder_count): New variables.
9191 (uniprop_get_decoder, uniprop_encode_value_character)
9192 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
9193 New functions.
9194 (uniprop_encoder, uniprop_encoder_count): New variables.
9195 (uniprop_get_encoder, uniprop_table)
9196 (Funicode_property_table_internal, Fget_unicode_property_internal)
9197 (Fput_unicode_property_internal): New functions.
9198 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
9199 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 9200 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
9201 char-code-property-alist.
9202
640c8776 9203 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
9204 Vunicode_category_table.
9205
640c8776 9206 * font.c (font_range): Adjust for the change of
c805dec0
KH
9207 Vunicode_category_table.
9208
76b397fb
DN
92092011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
9210
9211 * m/iris4d.h: Remove file, move contents ...
9212 * s/irix6-5.h: ... here.
9213
22b4128e
PE
92142011-07-06 Paul Eggert <eggert@cs.ucla.edu>
9215
9216 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
9217 * alloc.c (mark_buffer):
9218 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
9219 (clone_per_buffer_values): Don't assume that
22b4128e
PE
9220 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
9221 This isn't true in general, and it's particularly not true
9222 if Emacs is configured with --with-wide-int.
9223 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
9224 New macros, used in the buffer.c change.
9225
869795d6
JD
92262011-07-05 Jan Djärv <jan.h.d@swipnet.se>
9227
9228 * xsettings.c: Use both GConf and GSettings if both are available.
9229 (store_config_changed_event): Add comment.
9230 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
9231 (store_tool_bar_style_changed): New functions.
5e617bc2 9232 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
9233 (struct xsettings): Move font inside HAVE_XFT.
9234 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 9235 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 9236 Move inside HAVE_XFT.
640c8776 9237 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
9238 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
9239 also.
9240 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 9241 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 9242 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
9243 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
9244 (parse_settings): Move check for font inside HAVE_XFT.
9245 (read_settings, apply_xft_settings): Add comment.
9246 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
9247 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
9248 call store_font_name_changed.
9249 (xft_settings_event): Add comment.
9250 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
9251 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
9252 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
9253 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
9254 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
9255 (xsettings_get_system_font, xsettings_get_system_normal_font):
9256 Add comment.
869795d6 9257
d8ed26bd
PE
92582011-07-05 Paul Eggert <eggert@cs.ucla.edu>
9259
9260 Random fixes. E.g., (random) never returned negative values.
9261 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
9262 subseconds part to the entropy, as that's a bit more random.
9263 Prefer signed to unsigned, since the signedness doesn't matter and
9264 in general we prefer signed. When given a limit, use a
9265 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
9266 latter isn't right if USE_2_TAGS_FOR_INTS.
9267 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
9268 not 0..VALMASK. Don't discard "excess" bits that random () returns.
9269
cabf1cac
SM
92702011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
9271
9272 * textprop.c (text_property_stickiness):
9273 Obey Vtext_property_default_nonsticky.
9274 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
9275 * w32fns.c (syms_of_w32fns):
9276 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
9277
6e9b2be9
PE
92782011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9279
9280 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
9281 This is more efficient than Ffile_directory_p and avoids a minor race.
9282
90186c68
LMI
92832011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
9284
7c301272
LMI
9285 * buffer.c (Foverlay_put): Say what the return value is
9286 (bug#7835).
9287
c4f2d8d4
LMI
9288 * fileio.c (barf_or_query_if_file_exists): Check first if the file
9289 is a directory before asking whether to use the file name
9290 (bug#7564).
ad637907
LMI
9291 (barf_or_query_if_file_exists): Make the "File is a directory"
9292 error be more correct.
c4f2d8d4 9293
90186c68
LMI
9294 * fns.c (Frequire): Remove the mention of the .gz files, since
9295 that's installation-specific, but keep the mention of
9296 `get-load-suffixes'.
9297
da64016e
PE
92982011-07-04 Paul Eggert <eggert@cs.ucla.edu>
9299
9300 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
9301 Report string overflow if the output is too long.
9302
7d47b580
JB
93032011-07-04 Juanma Barranquero <lekktu@gmail.com>
9304
a555cb87
JB
9305 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
9306 (syms_of_gnutls): Remove duplicate DEFSYM for
9307 Qgnutls_bootprop_verify_hostname_error, an error for
9308 Qgnutls_bootprop_verify_error (which is no longer used).
9309
7d47b580
JB
9310 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
9311 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
9312 Also (re)move comments that are misplaced or no longer relevant.
9313
1e49bfab
LMI
93142011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9315
9316 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
9317
1485f4c0
CY
93182011-07-03 Chong Yidong <cyd@stupidchicken.com>
9319
9320 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
9321 and background color parameters if they have been changed.
9322
a9ab721e
LMI
93232011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
9324
9325 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
9326
cf7cff57
PE
93272011-07-03 Paul Eggert <eggert@cs.ucla.edu>
9328
2e13213d
PE
9329 * xsettings.c (SYSTEM_FONT): Define only when used.
9330 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
9331
cf7cff57
PE
9332 * keymap.c (access_keymap_1): Now static.
9333
7a8e04f7
CY
93342011-07-02 Chong Yidong <cyd@stupidchicken.com>
9335
9336 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
9337 leave any prefix arg for the up event (Bug#1586).
9338
61352f62
LMI
93392011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
9340
69bb1ef7
LMI
9341 * lread.c (syms_of_lread): Mention single symbols defined by
9342 `defvar' or `defconst' (bug#7154).
9343
61352f62 9344 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 9345 (Frequire): Mention get-load-suffixes.
61352f62 9346
28545e04
MR
93472011-07-02 Martin Rudalics <rudalics@gmx.at>
9348
9349 * window.h (window): Remove clone_number slot.
9350 * window.c (Fwindow_clone_number, Fset_window_clone_number):
9351 Remove.
9352 (make_parent_window, make_window, saved_window)
9353 (Fset_window_configuration, save_window_save): Don't deal with
9354 clone numbers.
9355 * buffer.c (Qclone_number): Remove declaration.
9356 (sort_overlays, overlay_strings): Don't deal with clone numbers.
9357
3349e122
SM
93582011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
9359
9360 Add multiple inheritance to keymaps.
9361 * keymap.c (Fmake_composed_keymap): New function.
9362 (Fset_keymap_parent): Simplify.
9363 (fix_submap_inheritance): Remove.
9364 (access_keymap_1): New function extracted from access_keymap to handle
9365 embedded parents and handle lists of maps.
9366 (access_keymap): Use it.
9367 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
9368 (Fcopy_keymap): Handle embedded parents.
9369 (Fcommand_remapping, define_as_prefix): Simplify.
9370 (Fkey_binding): Simplify.
9371 (syms_of_keymap): Move minibuffer-local-completion-map,
9372 minibuffer-local-filename-completion-map,
9373 minibuffer-local-must-match-map, and
9374 minibuffer-local-filename-must-match-map to Elisp.
9375 (syms_of_keymap): Defsubr make-composed-keymap.
9376 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
9377 (parse_menu_item): Trivial simplification.
9378
3279eb87
GM
93792011-07-01 Glenn Morris <rgm@gnu.org>
9380
9381 * Makefile.in (SETTINGS_LIBS): Fix typo.
9382
4550efdf
KI
93832011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
9384
9385 * coding.c (Fencode_coding_string): Record the last coding system
9386 used, as the function doc string says (bug#8738).
9387
0949d2b6
JD
93882011-07-01 Jan Djärv <jan.h.d@swipnet.se>
9389
9390 * xsettings.c (store_monospaced_changed): Take new font as arg and
9391 check for change against current_mono_font.
9392 (EMACS_TYPE_SETTINGS): Remove this and related defines.
9393 (emacs_settings_constructor, emacs_settings_get_property)
9394 (emacs_settings_set_property, emacs_settings_class_init)
9395 (emacs_settings_init, gsettings_obj): Remove.
9396 (something_changedCB): New function for HAVE_GSETTINGS.
9397 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
9398 with value as argument.
9399 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
9400 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 9401 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
9402 "changed".
9403
9404 * xgselect.c: Add defined (HAVE_GSETTINGS).
9405 (xgselect_initialize): Ditto.
9406
9407 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
9408 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
9409 xg_select.
9410
bbc6b304
PE
94112011-07-01 Paul Eggert <eggert@cs.ucla.edu>
9412
9413 * eval.c (struct backtrace): Simplify and port the data structure.
9414 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
9415 signed bit field, as this assumption is not portable and it makes
9416 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
9417 "char debug_on_exit : 1" as this is not portable either; instead,
9418 use the portable "unsigned int debug_on_exit : 1". Remove unused
9419 member evalargs. Remove obsolete comments about cc bombing out.
9420
9851bfc5
JD
94212011-06-30 Jan Djärv <jan.h.d@swipnet.se>
9422
51bb811f 9423 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
9424 Let HAVE_GSETTINGS override HAVE_GCONF.
9425 (store_monospaced_changed): New function.
9426 (EMACS_SETTINGS): A new type derived from GObject to handle
9427 GSettings notifications.
9428 (emacs_settings_constructor, emacs_settings_get_property)
9429 (emacs_settings_set_property, emacs_settings_class_init):
9430 New functions.
9431 (gsettings_client, gsettings_obj): New variables.
9432 (GSETTINGS_SCHEMA): New define.
9433 (something_changedCB): Call store_monospaced_changed.
9434 (init_gsettings): New function.
9435 (xsettings_initialize): Call init_gsettings.
9436 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
9437 to NULL.
9438
640c8776 9439 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
9440 GCONF_CFLAGS/LIBS.
9441
5386012d
MR
94422011-06-29 Martin Rudalics <rudalics@gmx.at>
9443
9444 * window.c (resize_root_window, grow_mini_window)
9445 (shrink_mini_window): Rename Qresize_root_window to
9446 Qwindow_resize_root_window and Qresize_root_window_vertically to
9447 Qwindow_resize_root_window_vertically.
9448
f13e0b08
PE
94492011-06-28 Paul Eggert <eggert@cs.ucla.edu>
9450
9451 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
9452
94515237
JB
94532011-06-27 Juanma Barranquero <lekktu@gmail.com>
9454
9455 * makefile.w32-in: Redesign dependencies so they reflect more
9456 clearly which files are directly included by each source file,
9457 and not through other includes.
9458
e43b6e43
MR
94592011-06-27 Martin Rudalics <rudalics@gmx.at>
9460
9461 * buffer.c (Qclone_number): Declare static and DEFSYM it.
9462 (sort_overlays, overlay_strings): When an overlay's clone number
9463 matches the window's clone number process the overlay even if
9464 the overlay's window property doesn't match the current window.
9465
d68443dc
MR
9466 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
9467 (Fwindow_hchild): Rename to Fwindow_left_child.
9468 (Fwindow_next): Rename to Fwindow_next_sibling.
9469 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
9470 (resize_window_check): Rename to window_resize_check.
9471 (resize_window_apply): Rename to window_resize_apply.
9472 (Fresize_window_apply): Rename to Fwindow_resize_apply.
9473 (Fdelete_other_windows_internal, resize_frame_windows)
9474 (Fsplit_window_internal, Fdelete_window_internal)
9475 (grow_mini_window, shrink_mini_window)
9476 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 9477
c7e73be5
JD
94782011-06-26 Jan Djärv <jan.h.d@swipnet.se>
9479
9480 * emacsgtkfixed.h: State that this is only used with Gtk+3.
9481 (emacs_fixed_set_min_size): Remove.
9482 (emacs_fixed_new): Take frame as argument.
9483
9484 * emacsgtkfixed.c: State that this is only used with Gtk+3.
9485 (_EmacsFixedPrivate): Remove minwidth/height.
9486 Add struct frame *f.
9487 (emacs_fixed_init): Initialize priv->f.
9488 (get_parent_class, emacs_fixed_set_min_size): Remove.
9489 (emacs_fixed_new): Set priv->f to argument.
9490 (emacs_fixed_get_preferred_width)
9491 (emacs_fixed_get_preferred_height): Use min_width/height from
9492 frames size_hint to set minimum and natural (Bug#8919).
9493 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
9494 and use min_width/height from frames size_hint to set
9495 min_width/height (Bug#8919).
9496
9497 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
9498 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
9499 Fix indentation.
c7e73be5 9500
cf99dcf8
EZ
95012011-06-26 Eli Zaretskii <eliz@gnu.org>
9502
9503 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
9504 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
9505 called at ZV.
9506
029529ac
CY
95072011-06-26 Chong Yidong <cyd@stupidchicken.com>
9508
9509 * process.c (wait_reading_process_output): Bypass select if
9510 waiting for a cell while ignoring keyboard input, and input is
9511 pending. Suggested by Jan Djärv (Bug#8869).
9512
7a7ef429
PE
95132011-06-25 Paul Eggert <eggert@cs.ucla.edu>
9514
9515 Use gnulib's dup2 module instead of rolling our own.
9516 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
9517
11fdef7d 95182011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
9519
9520 * dispnew.c (scrolling_window): Before scrolling, turn off a
9521 mouse-highlight in the window being scrolled.
9522
cd3520a4
JB
95232011-06-24 Juanma Barranquero <lekktu@gmail.com>
9524
9525 Move DEFSYM to lisp.h and use everywhere.
9526
9527 * character.h (DEFSYM): Move declaration...
9528 * lisp.h (DEFSYM): ...here.
9529
9530 * gnutls.c:
9531 * minibuf.c:
9532 * w32menu.c:
9533 * w32proc.c:
9534 * w32select.c: Don't include character.h.
9535
9536 * alloc.c (syms_of_alloc):
9537 * buffer.c (syms_of_buffer):
9538 * bytecode.c (syms_of_bytecode):
9539 * callint.c (syms_of_callint):
9540 * casefiddle.c (syms_of_casefiddle):
9541 * casetab.c (init_casetab_once):
9542 * category.c (init_category_once, syms_of_category):
9543 * ccl.c (syms_of_ccl):
9544 * cmds.c (syms_of_cmds):
9545 * composite.c (syms_of_composite):
9546 * dbusbind.c (syms_of_dbusbind):
9547 * dired.c (syms_of_dired):
9548 * dispnew.c (syms_of_display):
9549 * doc.c (syms_of_doc):
9550 * editfns.c (syms_of_editfns):
9551 * emacs.c (syms_of_emacs):
9552 * eval.c (syms_of_eval):
9553 * fileio.c (syms_of_fileio):
9554 * fns.c (syms_of_fns):
9555 * frame.c (syms_of_frame):
9556 * fringe.c (syms_of_fringe):
9557 * insdel.c (syms_of_insdel):
9558 * keymap.c (syms_of_keymap):
9559 * lread.c (init_obarray, syms_of_lread):
9560 * macros.c (syms_of_macros):
9561 * msdos.c (syms_of_msdos):
9562 * print.c (syms_of_print):
9563 * process.c (syms_of_process):
9564 * search.c (syms_of_search):
9565 * sound.c (syms_of_sound):
9566 * syntax.c (init_syntax_once, syms_of_syntax):
9567 * terminal.c (syms_of_terminal):
9568 * textprop.c (syms_of_textprop):
9569 * undo.c (syms_of_undo):
9570 * w32.c (globals_of_w32):
9571 * window.c (syms_of_window):
9572 * xdisp.c (syms_of_xdisp):
9573 * xfaces.c (syms_of_xfaces):
9574 * xfns.c (syms_of_xfns):
9575 * xmenu.c (syms_of_xmenu):
9576 * xsettings.c (syms_of_xsettings):
9577 * xterm.c (syms_of_xterm): Use DEFSYM.
9578
4228cf16
TZ
95792011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
9580
cd3520a4 9581 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 9582
7fcccf1e
PE
95832011-06-23 Paul Eggert <eggert@cs.ucla.edu>
9584
7efb4e0e
PE
9585 Integer and buffer overflow fixes (Bug#8873).
9586
ff5844ad
PE
9587 * print.c (printchar, strout): Check for string overflow.
9588 (PRINTPREPARE, printchar, strout):
9589 Don't set size unless allocation succeeds.
9590
90532f02
PE
9591 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
9592 for sizes. Check for string overflow more accurately.
9593 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
9594
6d84508d
PE
9595 * macros.c: Integer and buffer overflow fixes.
9596 * keyboard.h (struct keyboard.kbd_macro_bufsize):
9597 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
9598 Use ptrdiff_t, not int, for sizes.
9599 Don't increment bufsize until after realloc succeeds.
9600 Check for size-calculation overflow.
9601 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
9602
437b2cb4
PE
9603 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
9604
8b9ac8b4
PE
9605 * lread.c: Integer overflow fixes.
9606 (read_integer): Radix is now EMACS_INT, not int,
9607 to improve quality of diagnostics for out-of-range radices.
9608 Calculate buffer size correctly for out-of-range radices.
9609 (read1): Check for integer overflow in radices, and in
9610 read-circle numbers.
82cb60d3
PE
9611 (read_escape): Avoid int overflow.
9612 (Fload, openp, read_buffer_size, read1)
9613 (substitute_object_recurse, read_vector, read_list, map_obarray):
9614 Use ptrdiff_t, not int, for sizes.
9615 (read1): Use EMACS_INT, not int, for sizes.
20270765 9616 Check for size overflow.
8b9ac8b4 9617
7fcccf1e
PE
9618 * image.c (cache_image): Check for size arithmetic overflow.
9619
bfbbd7e7
PE
9620 * lread.c: Integer overflow issues.
9621 (saved_doc_string_size, saved_doc_string_length)
9622 (prev_saved_doc_string_size, prev_saved_doc_string_length):
9623 Now ptrdiff_t, not int.
9624 (read1): Don't assume doc string length fits in int. Check for
9625 out-of-range doc string lengths.
9626 (read_list): Don't assume file position fits in int.
39019e54 9627 (read_escape): Check for hex character overflow.
bfbbd7e7 9628
4e323265
LL
96292011-06-22 Leo Liu <sdl.web@gmail.com>
9630
9631 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
9632 Move to minibuffer.el.
9633
85fece3e
PE
96342011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9635
20b84ce9 9636 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
9637 The following patches are for when GLYPH_DEBUG && !XASSERT.
9638 * dispextern.h (trace_redisplay_p, dump_glyph_string):
9639 * dispnew.c (flush_stdout):
9640 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
9641 Mark as externally visible.
9642 * dispnew.c (check_window_matrix_pointers): Now static.
9643 * dispnew.c (window_to_frame_vpos):
9644 * xfns.c (unwind_create_frame):
9645 * xterm.c (x_check_font): Remove unused local.
9646 * scroll.c (CHECK_BOUNDS):
9647 * xfaces.c (cache_fache): Rename local to avoid shadowing.
9648 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
9649 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
9650 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
9651 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
9652 Now static.
9653 (debug_method_add): Use va_list and vsprintf rather than relying
9654 on undefined behavior with wrong number of arguments.
9655 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
9656 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
9657 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
9658 since we're not interested in debugging glyphs with old libraries.
9659 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
9660 GCC 4.6.0's static checking.
9661
0766b489
PE
96622011-06-22 Paul Eggert <eggert@cs.ucla.edu>
9663
31fd4b32
PE
9664 Integer overflow and signedness fixes (Bug#8873).
9665 A few related buffer overrun fixes, too.
9666
b79e8648
PE
9667 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
9668
0766b489
PE
9669 * dispextern.h (struct face.stipple):
9670 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
9671 (x_bitmap_mask, x_allocate_bitmap_record)
9672 (x_create_bitmap_from_data, x_create_bitmap_from_file)
9673 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
9674 (x_create_bitmap_from_xpm_data):
9675 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
9676 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
9677 (.bitmaps_last):
9678 * xfaces.c (load_pixmap):
9679 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
9680 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
9681 (.bitmaps_last, struct x_output.icon_bitmap):
9682 Use ptrdiff_t, not int, for bitmap indexes.
9683 (x_allocate_bitmap_record): Check for size overflow.
9684 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
9685
b081724f
PE
9686 Use ptrdiff_t, not int, for overlay counts.
9687 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
9688 * editfns.c (overlays_around, get_pos_property):
9689 * textprop.c (get_char_property_and_overlay):
9690 * xdisp.c (next_overlay_change, note_mouse_highlight):
9691 * xfaces.c (face_at_buffer_position):
21514da7
PE
9692 * buffer.c (OVERLAY_COUNT_MAX): New macro.
9693 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
9694 (Fnext_overlay_change, Fprevious_overlay_change)
9695 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 9696 Use ptrdiff_t, not int, for sizes.
21514da7 9697 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 9698
3de73e5e
PE
9699 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
9700
2606c57b
PE
9701 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
9702 (x_session_initialize): Do not assume string length fits in int.
9703
aaafe47a
PE
9704 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
9705 This is unlikely, but can occur if DPI is outlandish.
9706
2674ddc8 9707 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
9708 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
9709
28154962
PE
9710 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
9711 * xrdb.c (magic_file_p, search_magic_path):
9712 Omit last arg SUFFIX; it was always 0. All callers changed.
9713 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
9714
7de51af5
PE
9715 * xfont.c (xfont_match): Avoid need for strlen.
9716
25ed6cc3
PE
9717 * xfns.c: Don't assume strlen fits in int.
9718 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
9719
4eab31dd
PE
9720 * xdisp.c (message_log_check_duplicate): Return intmax_t,
9721 not unsigned long, as we prefer signed integers. All callers changed.
9722 Detect integer overflow in repeat count.
9723 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 9724 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 9725
171e2a58
PE
9726 * termcap.c: Don't assume sizes fit in int and never overflow.
9727 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
9728 (gobble_line): Check for size-calculation overflow.
9729
ad39faca 9730 * minibuf.c (Fread_buffer):
6e5bb2dc 9731 * lread.c (intern, intern_c_string):
74ca2eb3
PE
9732 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
9733 Don't assume string length fits in int.
9734
52c61c22 9735 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
9736 * gtkutil.c (style_changed_cb): Avoid need for strlen.
9737
b5b8c9e5
PE
9738 * font.c: Don't assume string length fits in int.
9739 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
9740 Use ptrdiff_t, not int.
ccd6111c
PE
9741 (font_intern_prop): Don't assume string length fits in int.
9742 Don't assume integer property fits in fixnum.
9743 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 9744
882f0d81 9745 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 9746 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
9747 Reformulate so as not to need the command string.
9748 Invoke gzip -cd rather than gunzip, as it's more portable.
9749 (lock_info_type, lock_file_1, lock_file):
9750 Don't assume pid_t and time_t fit in unsigned long.
9751 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
9752 (current_lock_owner): Prefer signed type for sizes.
9753 Use memcpy, not strncpy, where memcpy is what is really wanted.
9754 Don't assume (via atoi) that time_t and pid_t fit in int.
9755 Check for time_t and/or pid_t out of range, e.g., via a network share.
9756 Don't alloca where an auto var works fine.
9757
93f4cf88
PE
9758 * fileio.c: Fix some integer overflow issues.
9759 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
9760 Don't assume string length fits in int.
9761 (directory_file_name): Don't assume string length fits in long.
9762 (make_temp_name): Don't assume pid fits in int, or that its print
9763 length is less than 20.
9764
f3e92b69
PE
9765 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
9766
1bfdaf10
PE
9767 * coding.c (make_subsidiaries): Don't assume string length fits in int.
9768
35016e9a
PE
9769 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
9770
3d1e65a1
PE
9771 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
9772 We prefer signed integers, even for size calculations.
9773
0b963a93
PE
9774 * emacs.c: Don't assume string length fits in 'int'.
9775 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
9776 (main): Don't invoke strlen when not needed.
9777
573f4b54
PE
9778 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
9779 (XD_DEBUG_MESSAGE): Don't waste a byte.
9780
989f33ba
PE
9781 * callproc.c (getenv_internal_1, getenv_internal)
9782 (Fgetenv_internal):
965d34eb
PE
9783 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
9784
e4d29b33
PE
9785 * lread.c (invalid_syntax): Omit length argument.
9786 All uses changed. This doesn't fix a bug, but it simplifies the
9787 code away from its former Hollerith-constant appearance, and it's
9788 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 9789 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 9790
eb49b136
PE
9791 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
9792 This didn't break anything, but it didn't help either.
9793 It's confusing to put a bogus integer in a place where the actual
9794 value does not matter.
9f62aeb1 9795 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 9796 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 9797
15375a22
PE
9798 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
9799 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
9800 implementation.
b61cc01c
PE
9801 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
9802 We prefer signed types, and the value cannot exceed the EMACS_INT
9803 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
9804 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
9805 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
9806 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 9807
53b2623d
PE
9808 * indent.c (sane_tab_width): New function.
9809 (current_column, scan_for_column, Findent_to, position_indentation)
9810 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 9811 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 9812
51cab52b 9813 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 9814
f2ed8a70
PE
9815 * lisp.h (lint_assume): New macro.
9816 * composite.c (composition_gstring_put_cache):
9817 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
9818
abe80cc6
PE
9819 * editfns.c, insdel.c:
9820 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 9821
b02c740e
PE
9822 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
9823
ebc96716
PE
9824 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
9825
b4e50fa0 9826 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 9827 Use much-faster test for byte-length change.
311d5d7c 9828 Don't assume string byte-length fits in 'int'.
a4cf38e4 9829 Check that character arg fits in 'int'.
85461888 9830 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 9831
c0c1ee9f
PE
9832 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
9833
a498d7f4
PE
9834 * fns.c (concat): Catch string overflow earlier.
9835 Do not rely on integer wraparound.
9836
51cab52b
PE
9837 * dispextern.h (struct it.overlay_strings_charpos)
9838 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
9839 * xdisp.c (forward_to_next_line_start)
9840 (back_to_previous_visible_line_start)
9841 (reseat_at_next_visible_line_start, next_element_from_buffer):
9842 Don't arbitrarily truncate the value of 'selective' to int.
9843
76031fad
PE
9844 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
9845
5eb55db9
PE
9846 * composite.c: Don't truncate sizes to 'int'.
9847 (composition_gstring_p, composition_reseat_it)
9848 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
9849 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
9850 not EMACS_UINT, for indexes.
5eb55db9 9851
0703a717
PE
9852 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
9853
d6202519
PE
9854 * buffer.c: Include <verify.h>.
9855 (struct sortvec.priority, struct sortstr.priority):
8961a454 9856 Now EMACS_INT, not int.
c20998a7 9857 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
9858 (struct sortstr.size, record_overlay_string)
9859 (struct sortstrlist.size, struct sortlist.used):
9860 Don't truncate size to int.
9861 (record_overlay_string): Check for size-calculation overflow.
d6202519 9862 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 9863
d5a19415
JM
98642011-06-22 Jim Meyering <meyering@redhat.com>
9865
029529ac 9866 Don't leak an XBM-image-sized buffer
d5a19415
JM
9867 * image.c (xbm_load): Free the image buffer after using it.
9868
a9041e6c
PE
98692011-06-21 Paul Eggert <eggert@cs.ucla.edu>
9870
9871 Port to Sun C.
9872 * composite.c (find_automatic_composition): Omit needless 'return 0;'
9873 that Sun C diagnosed.
9874 * fns.c (secure_hash): Fix pointer signedness issue.
9875 * intervals.c (static_offset_intervals): New function.
9876 (offset_intervals): Use it.
9877
7f3f739f
LL
98782011-06-21 Leo Liu <sdl.web@gmail.com>
9879
9880 * deps.mk (fns.o):
9881 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
9882 sha512.h.
9883
9884 * fns.c (secure_hash): Rename from crypto_hash_function and change
9885 the first arg to accept symbols.
5b66d427 9886 (Fsecure_hash): New primitive.
7f3f739f
LL
9887 (syms_of_fns): New symbols.
9888
76147d94
DD
98892011-06-20 Deniz Dogan <deniz@dogan.se>
9890
9891 * process.c (Fset_process_buffer): Clarify return value in
9892 docstring.
9893
7d7d0045
CY
98942011-06-18 Chong Yidong <cyd@stupidchicken.com>
9895
9896 * dispnew.c (add_window_display_history): Use BVAR.
9897
9898 * xdisp.c (debug_method_add): Use BVAR.
9899 (check_window_end, dump_glyph_matrix, dump_glyph)
9900 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
9901
9902 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
9903 Likewise.
9904
9905 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
9906 check till after the cache is created in init_frame_faces.
9907
ff2bc410
SM
99082011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
9909
9910 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
9911
28177add
PE
99122011-06-16 Paul Eggert <eggert@cs.ucla.edu>
9913
dd3482fe
PE
9914 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
9915 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
9916 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
9917
393d71f3 9918 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
9919 * fileio.c (Finsert_file_contents):
9920 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
9921 Remove the old (too-loose) buffer overflow checks.
9922 They weren't needed, since make_gap checks for buffer overflow.
9923 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
9924 The old code merely checked for Emacs fixnum overflow, and relied
9925 on undefined (wraparound) behavior. The new code avoids undefined
9926 behavior, and also checks for ptrdiff_t and/or size_t overflow.
9927
2e6813b0 9928 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
9929 Tune. Don't use wider integers than needed. Don't use alloca.
9930 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 9931
599a9e4f
PE
9932 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
9933
99561444
PE
9934 * insdel.c, lisp.h (buffer_overflow): New function.
9935 (insert_from_buffer_1, replace_range, replace_range_2):
9936 * insdel.c (make_gap_larger):
9937 * editfns.c (Finsert_char):
9938 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
9939
28177add
PE
9940 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
9941
e69dafad
PE
99422011-06-15 Paul Eggert <eggert@cs.ucla.edu>
9943
4baa020d 9944 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 9945
b1c46f02
PE
9946 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
9947 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
9948
e69dafad
PE
9949 * fileio.c: Don't assume EMACS_INT fits in off_t.
9950 (emacs_lseek): New static function.
9951 (Finsert_file_contents, Fwrite_region): Use it.
9952 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
9953
566684ea
PE
9954 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
9955
e6966cd6
PE
9956 * fns.c: Don't overflow int when computing a list length.
9957 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
9958 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
9959 truncation on 64-bit hosts. Check for QUIT every
9960 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
9961 faster and is responsive enough.
9962 (Flength): Report an error instead of overflowing an integer.
9963 (Fsafe_length): Return a float if the value is not representable
9964 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 9965 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 9966 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 9967
dd0b0efb
PE
9968 * alloc.c: Check that resized vectors' lengths fit in fixnums.
9969 (header_size, word_size): New constants.
9970 (allocate_vectorlike): Don't check size overflow here.
9971 (allocate_vector): Check it here instead, since this is the only
9972 caller of allocate_vectorlike that could cause overflow.
9973 Check that the new vector's length is representable as a fixnum.
9974
86fe5cfe
PE
9975 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
9976 The previous code was bogus. For example, next_almost_prime (32)
9977 returned 39, which is undesirable as it is a multiple of 3; and
9978 next_almost_prime (24) returned 25, which is a multiple of 5 so
9979 why was the code bothering to check for multiples of 7?
9980
80e88859
PE
9981 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
9982
4a2f0ad6
PE
9983 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
9984
f66c7cf8
PE
9985 Variadic C functions now count arguments with ptrdiff_t.
9986 This partly undoes my 2011-03-30 change, which replaced int with size_t.
9987 Back then I didn't know that the Emacs coding style prefers signed int.
9988 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
9989 were being counted with int, which may truncate counts on 64-bit
9990 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
9991 * lisp.h (struct Lisp_Subr.function.aMANY)
9992 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
9993 Arg counts are now ptrdiff_t, not size_t.
9994 All variadic functions and their callers changed accordingly.
9995 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
9996 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
9997 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
9998 * callint.c (Fcall_interactively): Check arg count for overflow,
9999 to avoid potential buffer overrun. Use signed char, not 'int',
10000 for 'varies' array, so that we needn't bother to check its size
10001 calculation for overflow.
10002 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
10003 * eval.c (apply_lambda):
10004 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
10005 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
10006 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
10007
a1759b76
PE
10008 * callint.c (Fcall_interactively): Don't use index var as event count.
10009
d96be9fc
PE
10010 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
10011 * mem-limits.h (SIZE): Remove; no longer used.
10012
a690a978 10013 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 10014
578c21e6
PE
10015 Remove unnecessary casts.
10016 * xterm.c (x_term_init):
10017 * xfns.c (x_set_border_pixel):
10018 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
10019 These aren't needed now that we assume ANSI C.
10020
96f53c6c
PE
10021 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
10022 It's more likely to cause problems (due to unsigned overflow)
10023 than to cure them.
10024
83c77d31
PE
10025 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
10026
ee2079f1
PE
10027 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
10028
6da65536
PE
10029 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
10030
7147c4a4
PE
10031 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
10032
193e32d9
PE
10033 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
10034
e5533da6
PE
10035 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
10036
9910e595
PE
10037 GLYPH_CODE_FACE returns EMACS_INT, not int.
10038 * dispextern.h (merge_faces):
10039 * xfaces.c (merge_faces):
01103c44
PE
10040 * xdisp.c (get_next_display_element, next_element_from_display_vector):
10041 Don't assume EMACS_INT fits in int.
9910e595 10042
2638320e
PE
10043 * character.h (CHAR_VALID_P): Remove unused parameter.
10044 * fontset.c, lisp.h, xdisp.c: All uses changed.
10045
045eb8d9
PE
10046 * editfns.c (Ftranslate_region_internal): Omit redundant test.
10047
c1f134b5
PE
10048 * fns.c (concat): Minor tuning based on overflow analysis.
10049 This doesn't fix any bugs. Use int to hold character, instead
10050 of constantly refetching from Emacs object. Use XFASTINT, not
10051 XINT, for value known to be a character. Don't bother comparing
10052 a single byte to 0400, as it's always less.
10053
395fcb93 10054 * floatfns.c (Fexpt):
327eeec8
PE
10055 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
10056
abbd3d23
PE
10057 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
10058 for characters.
10059
684a03ef
PE
10060 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
10061
0fed43f3
PE
10062 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
10063 Without this fix, on a 64-bit host (aset S 0 4294967386) would
10064 incorrectly succeed when S was a string, because 4294967386 was
10065 truncated before it was used.
10066
8fd02eb7
PE
10067 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
10068 Otherwise, an out-of-range integer could cause undefined behavior
10069 on a 64-bit host.
10070
f8c86b69
PE
10071 * composite.c: Use int, not EMACS_INT, for characters.
10072 (fill_gstring_body, composition_compute_stop_pos): Use int, not
10073 EMACS_INT, for values that are known to be in character range.
10074 This doesn't fix any bugs but is the usual style inside Emacs and
10075 may generate better code on 32-bit machines.
10076
34206dd2
PE
10077 Make sure a 64-bit char is never passed to ENCODE_CHAR.
10078 This is for reasons similar to the recent CHAR_STRING fix.
10079 * charset.c (Fencode_char): Check that character arg is actually
10080 a character. Pass an int to ENCODE_CHAR.
10081 * charset.h (ENCODE_CHAR): Verify that the character argument is no
10082 wider than 'int', as a compile-time check to prevent future regressions
10083 in this area.
10084
c5958d4c 10085 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
10086
10087 Make sure a 64-bit char is never passed to CHAR_STRING.
10088 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
10089 by silently ignoring the top 32 bits, allowing some values
10090 that were far too large to be valid characters.
10091 * character.h: Include <verify.h>.
10092 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
10093 arguments are no wider than unsigned, as a compile-time check
10094 to prevent future regressions in this area.
10095 * data.c (Faset):
01103c44 10096 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
10097 (Fsubst_char_in_region):
10098 * fns.c (concat):
10099 * xdisp.c (decode_mode_spec_coding):
10100 Adjust to CHAR_STRING's new requirement.
10101 * editfns.c (Finsert_char, Fsubst_char_in_region):
10102 * fns.c (concat): Check that character args are actually
10103 characters. Without this test, these functions did the wrong
10104 thing with wildly out-of-range values on 64-bit hosts.
10105
d37ca623
PE
10106 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
10107 These casts should not be needed on 32-bit hosts, either.
10108 * keyboard.c (read_char):
10109 * lread.c (Fload): Remove casts to unsigned.
10110
ea204efb
PE
10111 * lisp.h (UNSIGNED_CMP): New macro.
10112 This fixes comparison bugs on 64-bit hosts.
10113 (ASCII_CHAR_P): Use it.
10114 * casefiddle.c (casify_object):
01103c44 10115 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
10116 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
10117 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
10118 * dispextern.h (FACE_FROM_ID):
10119 * keyboard.c (read_char): Use UNSIGNED_CMP.
10120
41cb286c
PE
10121 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
10122 not to EMACS_INT, to avoid GCC warning.
10123
4a1b9832
PE
10124 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
10125
55daad71
PE
10126 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
10127 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
10128 isn't needed on 32-bit machines.
8f95c75c 10129
01103c44
PE
10130 * buffer.c (Fgenerate_new_buffer_name):
10131 Use EMACS_INT for count, not int.
0ceccced 10132 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
10133
10134 * data.c (Qcompiled_function): Now static.
10135
c6f072e7
PE
10136 * window.c (window_body_lines): Now static.
10137
20ce5912
PE
10138 * image.c (gif_load): Rename local to avoid shadowing.
10139
9c4c5f81
PE
10140 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
10141 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
10142 * alloc.c (make_save_value): Integer argument is now of type
10143 ptrdiff_t, not int.
10144 (mark_object): Use ptrdiff_t, not int.
10145 * lisp.h (pD): New macro.
10146 * print.c (print_object): Use it.
10147
c0c5c8ae
PE
10148 * alloc.c: Use EMACS_INT, not int, to count objects.
10149 (total_conses, total_markers, total_symbols, total_vector_size)
10150 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
10151 (total_free_floats, total_floats, total_free_intervals)
10152 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
10153 Now EMACS_INT, not int. All uses changed.
10154 (Fgarbage_collect): Compute overall total using a double, so that
10155 integer overflow is less likely to be a problem. Check for overflow
10156 when converting back to an integer.
5a25e253
PE
10157 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
10158 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
10159 These were 'int' variables that could overflow on 64-bit hosts;
10160 they were never used, so remove them instead of repairing them.
211a0b2a 10161 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
10162 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
10163 Previously, this ceilinged at INT_MAX, but that doesn't work on
10164 64-bit machines.
e46bb31a 10165 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 10166
c78baabf 10167 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 10168 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
10169 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
10170 when a (possibly-narrower) signed value would do just as well.
10171 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 10172
c9d624c6
PE
10173 * alloc.c: Catch some string size overflows that we were missing.
10174 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
10175 for convenience in STRING_BYTES_MAX.
10176 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
10177 The definition here is exact; the one in lisp.h was approximate.
10178 (allocate_string_data): Check for string overflow. This catches
10179 some instances we weren't catching before. Also, it catches
10180 size_t overflow on (unusual) hosts where SIZE_MAX <= min
10181 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
10182 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 10183
c9d624c6
PE
10184 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
10185 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 10186 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 10187
353032ce
PE
10188 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
10189
2bccce07
PE
10190 * alloc.c (Fmake_string): Check for out-of-range init.
10191
0ac30604
SM
101922011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
10193
10194 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
10195
c195f2de
JD
101962011-06-14 Jan Djärv <jan.h.d@swipnet.se>
10197
10198 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
10199 xg_get_default_scrollbar_width.
10200
10201 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
10202 (int_gtk_range_get_value): Move to the scroll bar part of the file.
10203 (style_changed_cb): Call update_theme_scrollbar_width and call
10204 x_set_scroll_bar_default_width and xg_frame_set_char_size for
10205 all frames (Bug#8505).
10206 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
10207 Call gtk_window_set_resizable if HAVE_GTK3.
10208 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
10209 and height if HAVE_GTK3 (Bug#8505).
10210 (scroll_bar_width_for_theme): New variable.
10211 (update_theme_scrollbar_width): New function.
10212 (xg_get_default_scrollbar_width): Move code to
10213 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
10214 (xg_initialize): Call update_theme_scrollbar_width.
10215
10216 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
10217
10218 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
10219
e10ac9f1
MR
102202011-06-12 Martin Rudalics <rudalics@gmx.at>
10221
10222 * frame.c (make_frame): Call other_buffer_safely instead of
10223 other_buffer.
10224
10225 * window.c (temp_output_buffer_show): Call display_buffer with
10226 second argument Vtemp_buffer_show_specifiers and reset latter
10227 immediately after the call.
10228 (Vtemp_buffer_show_specifiers): New variable.
10229 (auto_window_vscroll_p, next_screen_context_lines)
10230 (Vscroll_preserve_screen_position): Remove leading asterisks from
10231 doc-strings.
10232
2d3c217e 102332011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 10234
7b7f97e8 10235 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
10236 * buffer.c (Qclone_number): Remove for now, as it's unused.
10237 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
10238 (record_buffer): Remove unused local.
10239 * frame.c (other_visible_frames, frame_buffer_list): Now static.
10240 (set_frame_buffer_list): Remove; unused.
10241 * frame.h (other_visible_frames): Remove decl.
10242 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
10243 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
10244 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
10245 if HAVE_GPM.
10246 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
10247 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
10248 Define only if HAVE_GPM.
10249 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
10250 (update_hints_inhibit): Remove; never set. All uses removed.
10251 * widgetprv.h (emacsFrameClassRec): Remove decl.
10252 * window.c (delete_deletable_window): Now returns void, since it
10253 wasn't returning anything.
10254 (compare_window_configurations): Remove unused locals.
10255 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
10256 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
10257 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
10258 the same widths as pointers. This follows up on the 2011-05-06 patch.
10259 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
10260 * xterm.h: Likewise.
10261 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
10262
1384b89e
JB
102632011-06-12 Juanma Barranquero <lekktu@gmail.com>
10264
10265 * makefile.w32-in: Update dependencies.
10266 (LISP_H): Add lib/intprops.h.
10267
1100a63c
CY
102682011-06-11 Chong Yidong <cyd@stupidchicken.com>
10269
10270 * image.c (gif_load): Add animation frame delay to the metadata.
10271 (syms_of_image): Use DEFSYM. New symbol `delay'.
10272
6198ccd0
MR
102732011-06-11 Martin Rudalics <rudalics@gmx.at>
10274
10275 * window.c (delete_deletable_window): Re-add.
10276 (Fset_window_configuration): Rewrite to handle dead buffers and
10277 consequently deletable windows.
10278 (window_tree, Fwindow_tree): Remove. Supply functionality in
10279 window.el.
10280 (compare_window_configurations): Simplify code.
10281
b6e3633c
AS
102822011-06-11 Andreas Schwab <schwab@linux-m68k.org>
10283
1ab0dee5
AS
10284 * image.c (imagemagick_load_image): Fix type mismatch.
10285 (Fimagemagick_types): Likewise.
10286
b6e3633c
AS
10287 * window.h (replace_buffer_in_windows): Declare.
10288
9397e56f
MR
102892011-06-11 Martin Rudalics <rudalics@gmx.at>
10290
10291 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
10292 Qclone_number. Remove external declaration of Qdelete_window.
10293 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
10294 code.
640c8776
SM
10295 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
10296 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
10297 (Fother_buffer): Rewrite doc-string. Major rewrite for new
10298 buffer list implementation.
10299 (other_buffer_safely): New function.
10300 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
10301 calls to replace_buffer_in_windows and
10302 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
10303 if allowed.
10304 (record_buffer): Inhibit quitting and rewrite using quittable
10305 functions. Run Qbuffer_list_update_hook if allowed.
10306 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
10307 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
10308 Move switch-to-buffer to window.el.
9397e56f
MR
10309 (bury-buffer): Move to window.el.
10310 (Vbuffer_list_update_hook): New variable.
10311
10312 * lisp.h (other_buffer_safely): Add prototype in buffer.c
10313 section.
10314
10315 * window.h (resize_frame_windows): Move up in code.
10316 (Fwindow_frame): Remove EXFUN.
10317 (replace_buffer_in_all_windows): Remove prototype.
10318 (replace_buffer_in_windows_safely): Add prototype.
10319
10320 * window.c: Declare Qdelete_window static again. Move down
10321 declaration of select_count.
10322 (Fnext_window, Fprevious_window): Rewrite doc-strings.
10323 (Fother_window): Move to window.el.
10324 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
10325 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
10326 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
10327 window.el.
10328 (replace_buffer_in_windows): Implement by calling
10329 Qreplace_buffer_in_windows.
10330 (replace_buffer_in_all_windows): Remove with some functionality
10331 moved into replace_buffer_in_windows_safely.
10332 (replace_buffer_in_windows_safely): New function.
10333 (select_window_norecord, select_frame_norecord): Move in front
10334 of run_window_configuration_change_hook. Remove now obsolete
10335 declarations.
640c8776
SM
10336 (Fset_window_buffer): Rewrite doc-string.
10337 Call Qrecord_window_buffer.
9397e56f
MR
10338 (keys_of_window): Move binding for other-window to window.el.
10339
b50691aa
CY
103402011-06-11 Chong Yidong <cyd@stupidchicken.com>
10341
10342 * dispextern.h (struct image): Replace data member, whose int_val
10343 and ptr_val fields were not used by anything, with a single
10344 lisp_val object.
10345
10346 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
10347 (gif_clear_image, gif_load, imagemagick_load_image)
10348 (gs_clear_image, gs_load): Callers changed.
10349
3f754b86
PE
103502011-06-10 Paul Eggert <eggert@cs.ucla.edu>
10351
cca69397
PE
10352 * buffer.h: Include <time.h>, for time_t.
10353 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
10354
109e28d0
PE
10355 Fix minor problems found by static checking.
10356
60737f02
PE
10357 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
10358
4b66faf3
PE
10359 Make identifiers static if they are not used in other modules.
10360 * data.c (Qcompiled_function, Qframe, Qvector):
10361 * image.c (QimageMagick, Qsvg):
10362 * minibuf.c (Qmetadata):
10363 * window.c (resize_window_check, resize_root_window): Now static.
10364 * window.h (resize_window_check, resize_root_window): Remove decls.
10365
109e28d0
PE
10366 * window.c (window_deletion_count, delete_deletable_window):
10367 Remove; unused.
46a4ce9e
PE
10368 (window_body_lines): Now static.
10369 (Fdelete_other_windows_internal): Mark vars as initialized.
10370 Make sure 'resize_failed' is initialized.
10371 (run_window_configuration_change_hook): Rename local to avoid shadowing.
10372 (resize_window_apply): Remove unused local.
10373 * window.h (delete_deletable_window): Remove decl.
10374
109e28d0 10375 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
10376 (imagemagick_load_image): Fix pointer signedness problem by changing
10377 last arg from unsigned char * to char *. All uses changed.
10378 Also, fix a local for similar reasons.
10379 Remove unused locals. Remove locals to avoid shadowing.
10380 (fn_rsvg_handle_free): Remove; unused.
10381 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 10382 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 10383
3f754b86
PE
10384 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
10385
2547adb1
CY
103862011-06-10 Chong Yidong <cyd@stupidchicken.com>
10387
10388 * image.c (gif_load): Fix omitted cast error introduced by
10389 2011-06-06 change.
10390
2c8e37d4
MR
103912011-06-10 Martin Rudalics <rudalics@gmx.at>
10392
10393 * window.h (resize_proportionally, orig_total_lines)
10394 (orig_top_line): Remove from window structure.
10395 (set_window_height, set_window_width, change_window_heights)
10396 (Fdelete_window): Remove prototypes.
10397 (resize_frame_windows): Remove duplicate declaration.
10398
440a42e3
EZ
103992011-06-10 Eli Zaretskii <eliz@gnu.org>
10400
10401 * window.h (resize_frame_windows, resize_window_check)
10402 (delete_deletable_window, resize_root_window)
10403 (resize_frame_windows): Declare prototypes.
10404
10405 * window.c (resize_window_apply): Make definition be "static" to
10406 match the prototype.
10407
562dd5e9
MR
104082011-06-10 Martin Rudalics <rudalics@gmx.at>
10409
10410 * window.c: Remove declarations of Qwindow_size_fixed,
10411 window_min_size_1, window_min_size_2, window_min_size,
10412 size_window, window_fixed_size_p, enlarge_window, delete_window.
10413 Remove static from declaration of Qdelete_window, it's
10414 temporarily needed by Fbury_buffer.
10415 (replace_window): Don't assign orig_top_line and
10416 orig_total_lines.
10417 (Fdelete_window, delete_window): Remove. Window deletion is
10418 handled by window.el.
640c8776
SM
10419 (window_loop): Remove DELETE_OTHER_WINDOWS case.
10420 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
10421 (Fdelete_other_windows): Remove. Deleting other windows is
10422 handled by window.el.
10423 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
10424 handled in window.el.
10425 (window_min_size_2, window_min_size_1, window_min_size): Remove.
10426 Window minimum sizes are handled in window.el.
10427 (shrink_windows, size_window, set_window_height)
10428 (set_window_width, change_window_heights, window_height)
10429 (window_width, CURBEG, CURSIZE, enlarge_window)
10430 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
10431 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
10432 handled in window.el.
10433 (make_dummy_parent): Rename to make_parent_window and give it a
10434 second argument horflag.
10435 (make_window): Don't set resize_proportionally any more.
10436 (Fsplit_window): Remove. Windows are split in window.el.
10437 (save_restore_action, save_restore_orig_size)
10438 (shrink_window_lowest_first, save_restore_orig_size): Remove.
10439 Resize mini windows in window.el.
10440 (grow_mini_window, shrink_mini_window): Implement by calling
10441 Qresize_root_window_vertically, resize_window_check and
10442 resize_window_apply.
640c8776
SM
10443 (saved_window, Fset_window_configuration, save_window_save):
10444 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
10445 resize_proportionally.
10446 (window_min_height, window_min_width): Move to window.el.
10447 (keys_of_window): Move bindings for delete-other-windows,
10448 split-window, delete-window and enlarge-window to window.el.
10449
10450 * buffer.c: Temporarily extern Qdelete_window.
10451 (Fbury_buffer): Temporarily call Qdelete_window instead of
10452 Fdelete_window (Fbury_buffer will move to window.el soon).
10453
10454 * frame.c (set_menu_bar_lines_1): Remove code handling
10455 orig_top_line and orig_total_lines.
10456
10457 * dispnew.c (adjust_frame_glyphs_initially): Don't use
10458 set_window_height but set heights directly.
10459 (change_frame_size_1): Use resize_frame_windows.
10460
10461 * xdisp.c (init_xdisp): Don't use set_window_height but set
10462 heights directly.
10463
640c8776
SM
10464 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
10465 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
10466 run_window_configuration_change_hook.
10467
10468 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
10469 instead of change_window_heights and run
10470 run_window_configuration_change_hook.
10471
1a13852e
MR
104722011-06-09 Martin Rudalics <rudalics@gmx.at>
10473
10474 * window.c (replace_window): Rename second argument REPLACEMENT to
10475 NEW. New third argument SETFLAG. Rewrite.
10476 (delete_window, make_dummy_parent): Call replace_window with
10477 third argument 1.
10478 (window_list_1): Move down in code.
10479 (run_window_configuration_change_hook): Move set_buffer part
10480 before select_frame_norecord part in order to unwind correctly.
10481 Rename count1 to count.
10482 (recombine_windows, delete_deletable_window, resize_root_window)
10483 (Fdelete_other_windows_internal)
10484 (Frun_window_configuration_change_hook, make_parent_window)
10485 (resize_window_check, resize_window_apply, Fresize_window_apply)
10486 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
10487 (Fdelete_window_internal, Fresize_mini_window_internal):
10488 New functions.
1a13852e
MR
10489 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
10490
f3d1777e
MR
104912011-06-08 Martin Rudalics <rudalics@gmx.at>
10492
496e208e
MR
10493 * window.h (window): Add some new members to window structure -
10494 normal_lines, normal_cols, new_total, new_normal, clone_number,
10495 splits, nest, prev_buffers, next_buffers.
10496 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 10497 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 10498
f3d1777e
MR
10499 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
10500 Remove.
496e208e
MR
10501 (make_dummy_parent): Set new members of windows structure.
10502 (make_window): Move down in code. Handle new members of window
10503 structure.
10504 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
10505 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
10506 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
10507 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
10508 (Fset_window_next_buffers, Fset_window_clone_number):
10509 New functions.
496e208e
MR
10510 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
10511 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
10512 Doc-string fixes.
10513 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
10514 Argument WINDOW can be now internal window too.
10515 (Fwindow_use_time): Move up in code.
10516 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
10517 Rewrite doc-string.
10518 (Fset_window_configuration, saved_window)
10519 (Fcurrent_window_configuration, save_window_save): Handle new
10520 members of window structure.
b9e809c2
MR
10521 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
10522 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
10523 (syms_of_window): New Lisp objects Qrecord_window_buffer,
10524 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
10525 Qget_mru_window, Qresize_root_window,
10526 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
10527 Qauto_buffer_name; staticpro them.
f3d1777e 10528
abde8f8c
MR
105292011-06-07 Martin Rudalics <rudalics@gmx.at>
10530
10531 * window.c (Fwindow_total_size, Fwindow_left_column)
10532 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
10533 (Fwindow_list_1): New functions.
10534 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
10535 (Fwindow_width, Fscroll_left, Fscroll_right):
10536 Use window_body_cols instead of window_box_text_cols.
10537 (delete_window, Fset_window_configuration):
10538 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
10539 (delete_all_subwindows): Take a window as argument and not a
10540 structure. Rewrite.
190b47e6
MR
10541 (window_loop): Remove handling of GET_LRU_WINDOW and
10542 GET_LARGEST_WINDOW.
10543 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
10544
10545 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
10546 window_box_text_cols. delete_all_subwindows now takes a
10547 Lisp_Object as argument.
abde8f8c 10548
640c8776
SM
10549 * indent.c (compute_motion, Fcompute_motion):
10550 Use window_body_cols instead of window_box_text_cols.
abde8f8c 10551
fa8a67e6
MR
10552 * frame.c (delete_frame): Call delete_all_subwindows with root
10553 window as argument.
10554
a54e3482
DC
105552011-06-07 Daniel Colascione <dan.colascione@gmail.com>
10556
10557 * fns.c (Fputhash): Document return value.
10558
60002bf5
CY
105592011-06-06 Chong Yidong <cyd@stupidchicken.com>
10560
10561 * image.c (gif_load): Implement gif89a spec "no disposal" method.
10562
0c671da6 105632011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 10564
b862a52a 10565 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 10566
be44ca6c
PE
10567 Check for overflow when converting integer to cons and back.
10568 * charset.c (Fdefine_charset_internal, Fdecode_char):
10569 Use cons_to_unsigned to catch overflow.
10570 (Fencode_char): Use INTEGER_TO_CONS.
10571 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
10572 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
10573 * data.c (long_to_cons, cons_to_long): Remove.
10574 (cons_to_unsigned, cons_to_signed): New functions.
10575 These signal an error for invalid or out-of-range values.
10576 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
10577 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
10578 * font.c (Ffont_variation_glyphs):
10579 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
10580 * lisp.h: Include <intprops.h>.
10581 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
10582 (cons_to_signed, cons_to_unsigned): New decls.
10583 (long_to_cons, cons_to_long): Remove decls.
10584 * undo.c (record_first_change): Use INTEGER_TO_CONS.
10585 (Fprimitive_undo): Use CONS_TO_INTEGER.
10586 * xfns.c (Fx_window_property): Likewise.
10587 * xselect.c: Include <limits.h>.
10588 (x_own_selection, selection_data_to_lisp_data):
10589 Use INTEGER_TO_CONS.
10590 (x_handle_selection_request, x_handle_selection_clear)
10591 (x_get_foreign_selection, Fx_disown_selection_internal)
10592 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
10593 (lisp_data_to_selection_data): Use cons_to_unsigned.
10594 (x_fill_property_data): Use cons_to_signed.
10595 Report values out of range.
10596
d1f3d2af
PE
10597 Check for buffer and string overflow more precisely.
10598 * buffer.h (BUF_BYTES_MAX): New macro.
10599 * lisp.h (STRING_BYTES_MAX): New macro.
10600 * alloc.c (Fmake_string):
10601 * character.c (string_escape_byte8):
10602 * coding.c (coding_alloc_by_realloc):
10603 * doprnt.c (doprnt):
10604 * editfns.c (Fformat):
10605 * eval.c (verror):
10606 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
10607 since they may not be the same number.
10608 * editfns.c (Finsert_char):
10609 * fileio.c (Finsert_file_contents):
10610 Likewise for BUF_BYTES_MAX.
10611
dd52fcea
PE
10612 * image.c: Use ptrdiff_t, not int, for sizes.
10613 (slurp_file): Switch from int to ptrdiff_t.
10614 All uses changed.
10615 (slurp_file): Check that file size fits in both size_t (for
10616 malloc) and ptrdiff_t (for sanity and safety).
10617
7f9bbdbb
PE
10618 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
10619 if b->modtime has its maximal value.
10620
dfe18f82
PE
10621 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
10622
84acfcf0
PE
10623 Don't assume time_t can fit into int.
10624 * buffer.h (struct buffer.modtime): Now time_t, not int.
10625 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
10626 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
10627
ccd9a01a
PE
10628 Minor fixes for signed vs unsigned integers.
10629 * character.h (MAYBE_UNIFY_CHAR):
10630 * charset.c (maybe_unify_char):
10631 * keyboard.c (read_char, reorder_modifiers):
10632 XINT -> XFASTINT, since the integer must be nonnegative.
10633 * ftfont.c (ftfont_spec_pattern):
10634 * keymap.c (access_keymap, silly_event_symbol_error):
10635 XUINT -> XFASTINT, since the integer must be nonnegative.
10636 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
10637 since it makes no difference and we prefer signed.
10638 * keyboard.c (record_char): Use XUINT when all the neighbors do.
10639 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
10640 nonnegative.
10641
d6d100dd
SM
106422011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
10643
10644 * window.h (Fwindow_frame): Declare.
10645
2b6148e4
PE
106462011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10647
10648 * alloc.c: Simplify handling of large-request failures (Bug#8800).
10649 (SPARE_MEMORY): Always define.
10650 (LARGE_REQUEST): Remove.
10651 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
10652
f230ecc9
MR
106532011-06-06 Martin Rudalics <rudalics@gmx.at>
10654
727e958e
MR
10655 * lisp.h: Move EXFUNS for Fframe_root_window,
10656 Fframe_first_window and Fset_frame_selected_window to window.h.
10657
10658 * window.h: Move EXFUNS for Fframe_root_window,
10659 Fframe_first_window and Fset_frame_selected_window here from
10660 lisp.h.
10661
10662 * frame.c (Fwindow_frame, Fframe_first_window)
10663 (Fframe_root_window, Fframe_selected_window)
10664 (Fset_frame_selected_window): Move to window.c.
10665 (Factive_minibuffer_window): Move to minibuf.c.
10666 (Fother_visible_frames_p): New function.
10667
10668 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
10669
f230ecc9
MR
10670 * window.c (decode_window, decode_any_window): Move up in code.
10671 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
10672 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
10673 (Fwindow_buffer): Move up and rewrite doc-string.
10674 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
10675 (Fwindow_prev): New functions.
727e958e
MR
10676 (Fwindow_frame): Move here from frame.c. Accept any window as
10677 argument.
10678 (Fframe_root_window, Fframe_first_window)
10679 (Fframe_selected_window): Move here from frame.c. Accept frame
10680 or arbitrary window as argument. Update doc-strings.
10681 (Fminibuffer_window): Move up in code.
10682 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
10683 (Fset_frame_selected_window): Move here from frame.c.
10684 Marginal rewrite.
727e958e
MR
10685 (Fselected_window, select_window, Fselect_window): Move up in
10686 code. Minor doc-string fixes.
f230ecc9 10687
4d09bcf6
PE
106882011-06-06 Paul Eggert <eggert@cs.ucla.edu>
10689
10690 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
10691 Do not assume that spare memory exists; that assumption is valid
10692 only if SYSTEM_MALLOC.
10693 (LARGE_REQUEST): New macro, so that the issue of large requests
10694 is separated from the issue of spare memory.
10695
810928a2
AS
106962011-06-05 Andreas Schwab <schwab@linux-m68k.org>
10697
172418ad
AS
10698 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
10699 format. (Bug#8806)
10700
43f862f7
AS
10701 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
10702
810928a2
AS
10703 * xfns.c (x_set_scroll_bar_default_width): Move declarations
10704 before statements.
10705
a059fe24
JD
107062011-06-05 Jan Djärv <jan.h.d@swipnet.se>
10707
10708 * gtkutil.c (xg_get_default_scrollbar_width): New function.
10709
10710 * gtkutil.h: Declare xg_get_default_scrollbar_width.
10711
10712 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
10713 min width by calling x_set_scroll_bar_default_width (Bug#8505).
10714
989bf368
JB
107152011-06-05 Juanma Barranquero <lekktu@gmail.com>
10716
10717 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
10718
4b80f674
CY
107192011-06-04 Chong Yidong <cyd@stupidchicken.com>
10720
10721 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
10722 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
10723 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
10724 New error handlers.
4b80f674
CY
10725 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
10726 Obey Vx_select_enable_clipboard_manager. Catch errors in
10727 x_clipboard_manager_save (Bug#8779).
10728 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 10729 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 10730
99a33b77 107312011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
10732
10733 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
10734
99a33b77 107352011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
10736
10737 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
10738 in the current matrix if keep_current_p is non-zero.
10739
8264569d
EZ
107402011-06-04 Eli Zaretskii <eliz@gnu.org>
10741
10742 * bidi.c (bidi_level_of_next_char): Fix last change.
10743
57f97249
EZ
107442011-06-03 Eli Zaretskii <eliz@gnu.org>
10745
fec2107c 10746 Support bidi reordering of text covered by display properties.
57f97249 10747
fec2107c
EZ
10748 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
10749 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
10750 (bidi_cache_search, bidi_cache_iterator_state)
10751 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
10752 (bidi_level_of_next_char, bidi_move_to_visually_next):
10753 Support character positions inside a run of characters covered by a
fec2107c
EZ
10754 display string.
10755 (bidi_paragraph_init, bidi_resolve_explicit_1)
10756 (bidi_level_of_next_char): Call bidi_fetch_char and
10757 bidi_fetch_char_advance instead of FETCH_CHAR and
10758 FETCH_CHAR_ADVANCE.
10759 (bidi_init_it): Initialize new members.
10760 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
10761 definitions.
10762 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
10763 instead of using explicit *_CHAR codes.
d6d100dd
SM
10764 (bidi_resolve_explicit, bidi_resolve_weak):
10765 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
10766 bidirectional text is supported only in multibyte buffers.
10767 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
10768 it to initialize the frame_window_p member of struct bidi_it.
10769 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
10770 (bidi_resolve_explicit, bidi_resolve_weak)
10771 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
10772 bidi_it->nchars is non-positive.
10773 (bidi_level_of_next_char): Don't try to lookup the cache for the
10774 next/previous character if nothing is cached there yet, or if we
10775 were just reseat()'ed to a new position.
c40e2fb2 10776
0e14fe90
EZ
10777 * xdisp.c (set_cursor_from_row): Set start and stop points
10778 according to the row's direction when priming the loop that looks
10779 for the glyph on which to display cursor.
10780 (single_display_spec_intangible_p): Function deleted.
10781 (display_prop_intangible_p): Reimplement to call
10782 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
10783 Accept 3 additional arguments needed by handle_display_spec.
10784 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
10785 values: lists, `(when COND...)' forms, etc.
10786 (single_display_spec_string_p): Support property values that are
10787 lists with the argument STRING its top-level element.
10788 (display_prop_string_p): Fix the condition for processing a
10789 property that is a list to be consistent with handle_display_spec.
fec2107c 10790 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
10791 last portion of handle_display_prop.
10792 (compute_display_string_pos): Accept additional argument
10793 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
10794 value of a `display' property is a "replacing spec".
10795 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
10796 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
10797 the display property, but just return a value indicating whether
10798 the display property will replace the characters it covers.
10799 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
10800 frame_window_p members of struct bidi_it.
d6d100dd
SM
10801 (compute_display_string_pos, compute_display_string_end):
10802 New functions.
fec2107c
EZ
10803 (push_it): Accept second argument POSITION, where pop_it should
10804 jump to continue iteration.
10805 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 10806
fec2107c
EZ
10807 * keyboard.c (adjust_point_for_property): Adjust the call to
10808 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
10809
10810 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
10811 (bidi_init_it): Update prototypes.
10812 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
10813 (compute_display_string_pos, compute_display_string_end):
10814 Declare prototypes.
fec2107c
EZ
10815 (struct bidi_it): New members nchars and disp_pos. ch_len is now
10816 EMACS_INT.
fc6f18ce 10817
40087514 108182011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 10819
57f53182
PE
10820 Malloc failure behavior now depends on size of allocation.
10821 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
10822 * lisp.h: Change signatures accordingly.
10823 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
10824 All callers changed. (Bug#8762)
10825
10826 * gnutls.c: Use Emacs's memory allocators.
10827 Without this change, the gnutls library would invoke malloc etc.
10828 directly, which causes problems on non-SYNC_INPUT hosts, and which
10829 runs afoul of improving memory_full behavior. (Bug#8761)
10830 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
10831 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
10832 xfree instead of the default malloc, realloc, free.
10833 (Fgnutls_boot): No need to check for memory allocation failure,
10834 since xmalloc does that for us.
10835
ac32cd99 10836 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
10837 * category.c (hash_get_category_set):
10838 * ccl.c (ccl_driver):
10839 * charset.c (Fdefine_charset_internal):
10840 * charset.h (struct charset.hash_index):
10841 * composite.c (get_composition_id, gstring_lookup_cache)
10842 (composition_gstring_put_cache):
10843 * composite.h (struct composition.hash_index):
10844 * dispextern.h (struct image.hash):
10845 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
10846 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
10847 (hashfn_equal, hashfn_user_defined, make_hash_table)
10848 (maybe_resize_hash_table, hash_lookup, hash_put)
10849 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
10850 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
10851 (Fsxhash, Fgethash, Fputhash, Fmaphash):
10852 * image.c (make_image, search_image_cache, lookup_image)
10853 (xpm_put_color_table_h):
10854 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 10855 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 10856 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 10857 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
10858 * alloc.c (allocate_vectorlike):
10859 Check for overflow in vector size calculations.
10860 * ccl.c (ccl_driver):
10861 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
10862 * fns.c, image.c: Remove unnecessary static decls that would otherwise
10863 need to be updated by these changes.
40087514
PE
10864 * fns.c (make_hash_table, maybe_resize_hash_table):
10865 Check for integer overflow with large hash tables.
0de4bb68
PE
10866 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
10867 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
10868 (SXHASH_REDUCE): New macro.
10869 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
10870 Use it instead of discarding useful hash info with large hash values.
10871 (sxhash_float): New function.
10872 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
10873 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
10874 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
10875 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
10876 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
10877 Adjust signatures to match updated version of code.
10878 (consing_since_gc): Now EMACS_INT, since a single hash table can
10879 use more than INT_MAX bytes.
10880
698d32e2
DN
108812011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
10882
10883 Make it possible to build with GCC-4.6+ -O2 -flto.
10884
10885 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
10886
fd6fa53f
SM
108872011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
10888
10889 * minibuf.c (get_minibuffer, read_minibuf_unwind):
10890 Call minibuffer-inactive-mode.
10891
864db017
JB
108922011-05-31 Juanma Barranquero <lekktu@gmail.com>
10893
10894 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
10895 Update dependencies.
10896
2ad0baf4
DN
108972011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10898
10899 * data.c (init_data): Remove code for UTS, this system is not
10900 supported anymore.
10901
4fcc2638
DN
109022011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10903
10904 Don't force ./temacs to start in terminal mode.
10905
10906 * frame.c (make_initial_frame): Initialize faces in all cases, not
10907 only when CANNOT_DUMP is defined.
10908 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
10909
c56e0fd5
DN
109102011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10911
10912 * dispnew.c (add_window_display_history): Use const for the string
10913 pointer. Remove declaration, not needed.
10914
333d54da 109152011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 10916
55d4c1b2 10917 Use 'inline', not 'INLINE'.
333d54da 10918 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
10919 * alloc.c, fontset.c (INLINE): Remove.
10920 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
10921 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
10922 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
10923 * gmalloc.c (register_heapinfo): Use inline unconditionally.
10924 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
10925
738db178
DN
109262011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
10927
10928 Make it possible to run ./temacs.
10929
10930 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
10931 syms_of_callproc does the same thing. Remove test for
10932 "initialized", do it in the caller.
10933 * emacs.c (main): Avoid calling set_initial_environment when dumping.
10934
620c53a6
SM
109352011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
10936
10937 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
10938 (read_minibuf): Use get_minibuffer.
10939 (syms_of_minibuf): Use DEFSYM.
10940 (Qmetadata): New var.
10941 * data.c (Qbuffer): Don't make it static.
10942 (syms_of_data): Use DEFSYM.
10943
e003a292
PE
109442011-05-31 Paul Eggert <eggert@cs.ucla.edu>
10945
10946 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
10947 (CCL_CODE_MIN): New macro.
10948
ed008a6d
PE
109492011-05-30 Paul Eggert <eggert@cs.ucla.edu>
10950
3687c2ef
PE
10951 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
10952
ed008a6d
PE
10953 * eval.c (Qdebug): Now static.
10954 * lisp.h (Qdebug): Remove decl. This reverts a part of the
10955 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
10956 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
10957
d66c4c7c
CY
109582011-05-29 Chong Yidong <cyd@stupidchicken.com>
10959
10960 * image.c: Various fixes to ImageMagick code comments.
10961 (Fimagemagick_types): Doc fix.
10962
5fbc2025
PE
109632011-05-29 Paul Eggert <eggert@cs.ucla.edu>
10964
0196f88a
PE
10965 Minor fixes prompted by GCC 4.6.0 warnings.
10966
10967 * xselect.c (converted_selections, conversion_fail_tag): Now static.
10968
5fbc2025
PE
10969 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
10970 (x_clipboard_manager_save_all): Move extern decl to ...
10971 * xterm.h: ... here, so that it can be checked for consistency.
10972
1dd3c2d9
CY
109732011-05-29 Chong Yidong <cyd@stupidchicken.com>
10974
10975 * xselect.c (x_clipboard_manager_save_frame)
10976 (x_clipboard_manager_save_all): New functions.
10977 (Fx_clipboard_manager_save): Lisp function deleted.
10978
10979 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
10980 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
10981
10982 * xterm.h: Update prototype.
10983
5ba6571d
WX
109842011-05-28 William Xu <william.xwl@gmail.com>
10985
10986 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
10987 exiting (Bug#8239).
10988
3eaff834
JM
109892011-05-28 Jim Meyering <meyering@redhat.com>
10990
e1900994 10991 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
10992 * fns.c (to_uchar): Define.
10993 (crypto_hash_function): Use it to convert some newly-signed
10994 variables to unsigned, to avoid sign-extension bugs. For example,
10995 without this change, (md5 "truc") would evaluate to
10996 45723a2aff78ff4fff7fff1114760e62 rather than the expected
10997 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 10998 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 10999
0f6990a7
PE
110002011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11001
11002 Integer overflow fixes.
c8a9ca5a 11003
08686060
PE
11004 * dbusbind.c: Serial number integer overflow fixes.
11005 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
11006 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
11007 to hold a serial number that is too large for a fixnum.
11008 (Fdbus_method_return_internal, Fdbus_method_error_internal):
11009 Check for serial numbers out of range. Decode any serial number
59568bf0 11010 that was so large that it became a float. (Bug#8722)
08686060 11011
2d1fc3c7
PE
11012 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
11013 (Fdbus_call_method, Fdbus_call_method_asynchronously):
11014 Use XFASTINT rather than XUINT when numbers are nonnegative.
11015 (xd_append_arg, Fdbus_method_return_internal):
11016 (Fdbus_method_error_internal): Likewise. Also, for unsigned
11017 arguments, check that Lisp number is nonnegative, rather than
59568bf0 11018 silently wrapping negative numbers around. (Bug#8722)
30217ff0 11019 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 11020 (Bug#8722)
2d1fc3c7 11021
c8a9ca5a
PE
11022 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
11023
519e1d69
PE
11024 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
11025
6df6ae42 11026 ccl: Add integer overflow checks.
30569699
PE
11027 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
11028 (IN_INT_RANGE): New macros.
11029 (ccl_driver): Use them to check for integer overflow when
11030 decoding a CCL program. Many of the new checks are whether XINT (x)
11031 fits in int; it doesn't always, on 64-bit hosts. The new version
11032 doesn't catch all possible integer overflows, but it's an
847044ea 11033 improvement. (Bug#8719)
30569699 11034
c11285dc
PE
11035 * alloc.c (make_event_array): Use XINT, not XUINT.
11036 There's no need for unsigned here.
11037
fdccd48e
PE
11038 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
11039 This follows up to the 2011-05-06 change that substituted uintptr_t
11040 for EMACS_INT. This case wasn't caught back then.
11041
37910ab2
PE
11042 Rework Fformat to avoid integer overflow issues.
11043 * editfns.c: Include <float.h> unconditionally, as it's everywhere
11044 now (part of C89). Include <verify.h>.
11045 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
11046 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
11047 (Fformat): Avoid the prepass trying to compute sizes; it was only
11048 approximate and thus did not catch overflow reliably. Instead, walk
11049 through the format just once, formatting and computing sizes as we go,
11050 checking for integer overflow at every step, and allocating a larger
11051 buffer as needed. Keep track separately whether the format is
11052 multibyte. Keep only the most-recently calculated precision, rather
11053 than them all. Record whether each argument has been converted to
11054 string. Use EMACS_INT, not int, for byte and char and arg counts.
11055 Support field widths and precisions larger than INT_MAX. Avoid
11056 sprintf's undefined behavior with conversion specifications such as %#d
11057 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
11058 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
11059 formatting out-of-range floating point numbers with int
9173deec 11060 formats. (Bug#8668)
37910ab2 11061
2e6578fb
PE
11062 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
11063
0ae6bdee
PE
11064 * data.c: Avoid integer truncation in expressions involving floats.
11065 * data.c: Include <intprops.h>.
11066 (arith_driver): When there's an integer overflow in an expression
11067 involving floating point, convert the integers to floating point
11068 so that the resulting value does not suffer from catastrophic
11069 integer truncation. For example, on a 64-bit host (* 4
11070 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
11071 Do not rely on undefined behavior after integer overflow.
11072
de883a70
PE
11073 merge count_size_as_multibyte, parse_str_to_multibyte
11074 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 11075 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
11076 Check for integer overflow.
11077 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
11078 since it's now a duplicate of the other. This is more of
11079 a character than a buffer op, so better that it's in character.c.
11080 * fns.c, print.c: Adjust to above changes.
11081
2ff916cb
PE
110822011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
11083
11084 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
11085
f1b54466
PE
110862011-05-27 Paul Eggert <eggert@cs.ucla.edu>
11087
fb1ac845
PE
11088 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11089 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
11090 (x_clipboard_manager_save): Now static.
11091 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
11092
f1b54466
PE
11093 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
11094 (crypto_hash_function): Now static.
11095 Fix pointer signedness problems. Avoid unnecessary initializations.
11096
a9f737ee
CY
110972011-05-27 Chong Yidong <cyd@stupidchicken.com>
11098
11099 * termhooks.h (Vselection_alist): Make it terminal-local.
11100
11101 * terminal.c (create_terminal): Initialize it.
11102
11103 * xselect.c: Support for clipboard managers.
11104 (Vselection_alist): Move to termhooks.h as terminal-local var.
11105 (LOCAL_SELECTION): New macro.
11106 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
11107 (symbol_to_x_atom): Remove gratuitous arg.
11108 (x_handle_selection_request, lisp_data_to_selection_data)
11109 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
11110 (x_own_selection, x_get_local_selection, x_convert_selection):
11111 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
11112 (some_frame_on_display): Delete unused function.
11113 (Fx_own_selection_internal, Fx_get_selection_internal)
11114 (Fx_disown_selection_internal, Fx_selection_owner_p)
11115 (Fx_selection_exists_p): New optional frame arg.
11116 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
11117 (x_handle_selection_clear): Don't treat other terminals with the
11118 same keyboard specially. Use the terminal-local Vselection_alist.
11119 (x_clear_frame_selections): Use Frun_hook_with_args.
11120
11121 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
11122
11123 * xterm.h: Add support for those atoms.
11124
e067f0c1
CY
111252011-05-26 Chong Yidong <cyd@stupidchicken.com>
11126
11127 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
11128 (converted_selections, conversion_fail_tag): New global variables.
11129 (x_selection_request_lisp_error): Free the above.
11130 (x_get_local_selection): Remove unnecessary code.
11131 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
11132 of converted selections stored in converted_selections.
11133 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
11134 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
11135 (x_convert_selection): New function.
11136 (x_handle_selection_event): Simplify.
11137 (x_get_foreign_selection): Don't ignore incoming requests while
11138 waiting for an answer; this will fail when we implement
11139 SAVE_TARGETS, and seems unnecessary anyway.
11140 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
11141 (Vx_sent_selection_functions): Doc fix.
11142
0f4aebc0
LL
111432011-05-26 Leo Liu <sdl.web@gmail.com>
11144
11145 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
11146
e61124cd
YM
111472011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11148
11149 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
11150
11151 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
11152 for fringe update if it has periodic bitmap.
ac389d0c 11153 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
11154 and fringe_bitmap_periodic_p.
11155
11156 * fringe.c (get_fringe_bitmap_data): New function.
11157 (draw_fringe_bitmap_1, update_window_fringes): Use it.
11158 (update_window_fringes): Record periodicity of fringe bitmap in glyph
11159 row. Mark glyph row for fringe update if periodicity changed.
11160
11161 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
11162 for fringe update unless it has periodic bitmap.
11163
f16d9837
KH
111642011-05-25 Kenichi Handa <handa@m17n.org>
11165
11166 * xdisp.c (get_next_display_element): Set correct it->face_id for
11167 a static composition.
11168
e1b90ef6
LL
111692011-05-24 Leo Liu <sdl.web@gmail.com>
11170
11171 * deps.mk (fns.o):
11172 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
11173
11174 * fns.c (crypto_hash_function, Fsha1): New function.
11175 (Fmd5): Use crypto_hash_function.
11176 (syms_of_fns): Add Ssha1.
11177
7400048f
PE
111782011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11179
11180 * gnutls.c: Remove unused macros.
11181 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
11182 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
11183 Remove macros that are defined and never used.
11184 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
11185
abb71cf4
CY
111862011-05-22 Chong Yidong <cyd@stupidchicken.com>
11187
11188 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
11189 (Fx_get_selection_internal): Minor cleanup.
11190 (Fx_own_selection_internal): Rename arguments for consistency with
11191 select.el.
11192
6307db39
PE
111932011-05-22 Paul Eggert <eggert@cs.ucla.edu>
11194
11195 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
11196
f3d4e0a4
CY
111972011-05-22 Chong Yidong <cyd@stupidchicken.com>
11198
11199 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
11200
4d8ade89
YM
112012011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
11202
11203 * dispnew.c (scrolling_window): Don't exclude the case that the
11204 last enabled row in the desired matrix touches the bottom boundary.
11205
32078c8d
GM
112062011-05-21 Glenn Morris <rgm@gnu.org>
11207
11208 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
11209 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
11210 and add some more files.
32078c8d 11211
7285dc67
EZ
112122011-05-20 Eli Zaretskii <eliz@gnu.org>
11213
11214 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
11215 report_file_error introduced by the change from 2011-05-07.
11216
89d1bd22
PE
112172011-05-20 Paul Eggert <eggert@cs.ucla.edu>
11218
11219 * systime.h (Time): Define only if emacs is defined.
11220 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
11221 where the include path doesn't have X11/X.h by default. See
11222 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
11223
cd394be1 112242011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
11225
11226 * composite.c (find_automatic_composition): Fix previous change.
11227
b9704ad9
GM
112282011-05-20 Glenn Morris <rgm@gnu.org>
11229
11230 * lisp.mk: New file, split from Makefile.in.
11231 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
11232 (shortlisp): Remove.
11233 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
11234
4a720484
GM
112352011-05-19 Glenn Morris <rgm@gnu.org>
11236
11237 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
11238 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
11239 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
11240 (lisp): Set the order to that of loadup.el.
11241 (shortlisp): Make it a copy of $lisp.
11242 (SOME_MACHINE_LISP): Remove.
11243 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
11244 Use just $shortlisp, not $SOME_MACHINE_LISP too.
11245
a28d4396
KH
112462011-05-18 Kenichi Handa <handa@m17n.org>
11247
11248 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
11249 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
11250 (find_automatic_composition): Mostly rewrite for efficiency.
11251
a2b1fa8e
JB
112522011-05-18 Juanma Barranquero <lekktu@gmail.com>
11253
11254 * makefile.w32-in: Update dependencies.
11255
8e1f5610
CS
112562011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
11257
11258 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 11259 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 11260
7025ee00 112612011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 11262
cdfa6eab
PE
11263 Fix some integer overflow issues, such as string length overflow.
11264
06d6db33
PE
11265 * insdel.c (count_size_as_multibyte): Check for string overflow.
11266
2b4560a8
PE
11267 * character.c (lisp_string_width): Check for string overflow.
11268 Use EMACS_INT, not int, for string indexes and lengths; in
11269 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
11270 the resulting string length overflows an EMACS_INT; instead,
11271 report a string overflow if no precision given. When checking for
11272 precision exhaustion, use a check that cannot possibly have
11273 integer overflow. (Bug#8675)
11274 * character.h (lisp_string_width): Adjust to new signature.
11275
cb93f9be
PE
11276 * alloc.c (string_overflow): New function.
11277 (Fmake_string): Use it. This doesn't change behavior, but saves
11278 a few bytes and will simplify future changes.
11279 * character.c (string_escape_byte8): Likewise.
11280 * lisp.h (string_overflow): New decl.
11281
1a1f3366
PE
11282 Fixups, following up to the user-interface timestamp change.
11283 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
11284 for UI timestamps, instead of unsigned long.
9fbd6841
PE
11285 * msdos.c (mouse_get_pos): Likewise.
11286 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
11287 * w32gui.h (Time): Define by including "systime.h" rather than by
11288 declaring it ourselves. (Bug#8664)
11289
d4e3e4d3
PE
11290 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
11291 * image.c (clear_image_cache): Likewise.
11292
f6a24d19
PE
11293 * term.c (term_mouse_position): Don't assume time_t wraparound.
11294
08dc5ae6
PE
11295 Be more systematic about user-interface timestamps.
11296 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
11297 and sometimes 'EMACS_UINT', to represent these timestamps.
11298 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
11299 This makes the code easier to follow, and makes it easier to catch
11300 integer overflow bugs such as Bug#8664.
11301 * frame.c (Fmouse_position, Fmouse_pixel_position):
11302 Use Time, not unsigned long, for user-interface timestamps.
11303 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
11304 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
11305 * keyboard.h (last_event_timestamp): Likewise.
11306 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
11307 * menu.h (xmenu_show): Likewise.
11308 * term.c (term_mouse_position): Likewise.
11309 * termhooks.h (struct input_event.timestamp): Likewise.
11310 (struct terminal.mouse_position_hook): Likewise.
11311 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
11312 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
11313 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
11314 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
11315 what it was before.
11316 * menu.h, termhooks.h: Include "systime.h", for Time.
11317
8e55734a
PE
11318 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
11319 Don't assume that the difference between two unsigned long values
11320 can fit into an integer. At this point, we know button_down_time
11321 <= event->timestamp, so the difference must be nonnegative, so
11322 there's no need to cast the result if double-click-time is
11323 nonnegative, as it should be; check that it's nonnegative, just in
11324 case. This bug is triggered when events are more than 2**31 ms
86db42d2 11325 apart (about 25 days). (Bug#8664)
8e55734a 11326
841f1b75 11327 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 11328 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 11329
3e26f69c
PE
11330 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
11331 that always fit in int. Use a sentinel instead of a counter, to
11332 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
11333 * frame.h (struct frame): Use int for menu_bar_items_used
11334 instead of EMACS_INT, since it always fits in int.
3e26f69c 11335
5cc152c0
PE
11336 * menu.c (grow_menu_items): Check for int overflow.
11337
d89eb65e
PE
11338 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
11339
5235bd3e
PE
11340 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
11341 Before, the code was not consistent. These values cannot exceed
11342 2**31 - 1 so there's no need to make them unsigned.
11343 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
11344 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
11345 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
11346 as modifiers.
11347 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
11348
bc827e23
PE
11349 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
11350 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
11351 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
11352 presumably because the widths might not match.
11353
78eb494e
PE
11354 * window.c (size_window): Avoid needless test at loop start.
11355
04f2d78b
CB
113562011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
11357
11358 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
11359
d2fc7e3d 113602011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
11361
11362 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
11363
d2fc7e3d 113642011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
11365
11366 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
11367 `width' to `bar_area_x' and `bar_area_width', respectively.
11368 (x_scroll_run): Take account of fringe background extension.
11369
04f2d78b
CB
11370 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
11371 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
11372 `bar_area_width', respectively.
11373 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
11374 background extension.
11375
79b70037
GM
113762011-05-10 Jim Meyering <meyering@redhat.com>
11377
11378 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
11379
2f142cc5
JB
113802011-05-10 Juanma Barranquero <lekktu@gmail.com>
11381
11382 * image.c (Finit_image_library): Return t for built-in image types,
11383 like pbm and xbm. (Bug#8640)
11384
57679c86
AS
113852011-05-09 Andreas Schwab <schwab@linux-m68k.org>
11386
11387 * w32menu.c (set_frame_menubar): Fix submenu allocation.
11388
888c9e86
EZ
113892011-05-07 Eli Zaretskii <eliz@gnu.org>
11390
b0512a1d
EZ
11391 * w32console.c (Fset_screen_color): Doc fix.
11392 (Fget_screen_color): New function.
11393 (syms_of_ntterm): Defsubr it.
11394
7285dc67
EZ
11395 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
11396 unlink the temporary file if Fcall_process didn't create it in the
11397 first place.
11398 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
11399 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
11400 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
11401 cue to call_process_cleanup not to close that handle.
11402
4d3fcc8e
BK
114032011-05-07 Ben Key <bkey76@gmail.com>
11404
11405 * makefile.w32-in: The bootstrap-temacs rule now makes use of
11406 one of two shell specific rules, either bootstrap-temacs-CMD or
11407 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
11408 to the previous implementation of the bootstrap-temacs rule.
11409 The bootstrap-temacs-CMD rule is similar to the previous
11410 implementation of the bootstrap-temacs rule except that it
11411 makes use of the ESC_CFLAGS variable instead of the CFLAGS
11412 variable.
11413
11414 These changes, along with some changes to nt/configure.bat,
11415 nt/gmake.defs, and nt/nmake.defs, are required to extend my
11416 earlier fix to add support for --cflags and --ldflags options
11417 that include quotes so that it works whether make uses cmd or
11418 sh as the shell.
11419
b4289b64
MA
114202011-05-06 Michael Albinus <michael.albinus@gmx.de>
11421
11422 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
11423 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
11424 is a constant.
11425 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
11426 a string. Handle both cases.
11427 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
11428 (Fdbus_register_method): Use Qinvalid_function.
11429
af4c0e28
JB
114302011-05-06 Juanma Barranquero <lekktu@gmail.com>
11431
11432 * makefile.w32-in: Update dependencies.
11433 (LISP_H): Add inttypes.h and stdin.h.
11434 (PROCESS_H): Add unistd.h.
11435
c51453d9
EZ
114362011-05-06 Eli Zaretskii <eliz@gnu.org>
11437
11438 * lread.c: Include limits.h (fixes the MS-Windows build broken by
11439 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
11440
8ff0ac3c 114412011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 11442
4c4b566b
PE
11443 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
11444
aab2b9b5
PE
11445 * term.c (vfatal): Remove stray call to va_end.
11446 It's not needed and the C Standard doesn't allow it here anyway.
11447
c378da0b
PE
11448 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
11449 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
11450
288b08c7
PE
11451 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
11452 bytes.
11453
e3601888
PE
11454 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
11455
db6c0e74
PE
11456 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
11457
dd5963ea
PE
11458 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
11459
88c9450f
PE
11460 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
11461
2f9442b8
PE
11462 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
11463
c032b5f8
PE
11464 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
11465 * charset.c (Fdefine_charset_internal): Don't initialize
11466 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 11467 32-bit int (Bug#8600).
a108c10b
PE
11468
11469 * lread.c (read_integer): Be more consistent with string-to-number.
11470 Use string_to_number to do the actual conversion; this avoids
11471 rounding errors and fixes some other screwups. Without this fix,
11472 for example, #x1fffffffffffffff was misread as -2305843009213693952.
11473 (digit_to_number): Move earlier, for benefit of read_integer.
11474 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 11475 not a digit in any supported base. (Bug#8602)
a108c10b 11476
ad5f9eea
PE
11477 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
11478
aec1708a
PE
11479 * dispnew.c (scrolling_window): Return 1 if we scrolled,
11480 to match comment at start of function. This also removes a
11481 GCC warning about overflow in a 32+64-bit port.
11482
47be4ab5
PE
11483 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
11484
371cac43
PE
11485 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
11486 Reported by Stefan Monnier in
11487 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
11488 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11489 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 11490
d01a7826
PE
11491 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
11492 (EMACS_UINTPTR): Likewise, with uintptr_t.
11493
7fd47d5c
PE
11494 * lisp.h: Prefer 64-bit EMACS_INT if available.
11495 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
11496 on 32-bit hosts that have 64-bit int, so that they can access
11497 large files.
122b0c86
PE
11498 However, temporarily disable this change unless the temporary
11499 symbol WIDE_EMACS_INT is defined.
7fd47d5c 11500
8727937b
PE
11501 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
11502
8ac068ac
PE
11503 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
11504 This removes an assumption that EMACS_INT and long are the same
11505 width as pointers. The assumption is true for Emacs porting targets
11506 now, but we want to make other targets possible.
11507 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
11508 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
11509 In the rest of the code, change types of integers that hold casted
11510 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
11511 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
11512 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
11513 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
11514 No need to cast type when ORing.
11515 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
11516 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
11517 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
11518 assume EMACS_INT is the same width as char *.
11519 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
11520 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
11521 Remove no-longer-needed casts.
11522 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
11523 (xg_tool_bar_help_callback, xg_make_tool_item):
11524 Use EMACS_INTPTR to hold an integer
11525 that will be cast to void *; this can avoid a GCC warning
11526 if EMACS_INT is not the same width as void *.
11527 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
11528 * xdisp.c (display_echo_area_1, resize_mini_window_1):
11529 (current_message_1, set_message_1):
11530 Use a local to convert to proper width without a cast.
11531 * xmenu.c (dialog_selection_callback): Likewise.
11532
ede49d71
PE
11533 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
11534 Also, don't assume VALBITS / RAND_BITS is less than 5,
11535 and don't rely on undefined behavior when shifting a 1 left into
11536 the sign bit.
11537 * lisp.h (get_random): Change signature to match.
11538
2f30ecd0
PE
11539 * lread.c (hash_string): Use size_t, not int, for hash computation.
11540 Normally we prefer signed values; but hashing is special, because
11541 it's better to use unsigned division on hash table sizes so that
11542 the remainder is nonnegative. Also, size_t is the natural width
11543 for hashing into memory. The previous code used 'int', which doesn't
11544 retain enough info to hash well into very large tables.
11545 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
11546
2a866e7b
PE
11547 * dbusbind.c: Don't possibly lose pointer info when converting.
11548 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
11549 Use XPNTR rather than XHASH, so that the high-order bits of
11550 the pointer aren't lost when converting through void *.
11551
51639eac
PE
11552 * eval.c (Fautoload): Don't double-shift a pointer.
11553
92394119
PE
11554 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
11555
dbdb9a7c
JB
115562011-05-06 Juanma Barranquero <lekktu@gmail.com>
11557
11558 * gnutls.c (DEF_GNUTLS_FN):
11559 * image.c (DEF_IMGLIB_FN): Make function pointers static.
11560
db7a0b4f
AS
115612011-05-05 Andreas Schwab <schwab@linux-m68k.org>
11562
11563 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
11564 marker. (Bug#8610)
11565
cd394be1 115662011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
11567
11568 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
11569 New version that can reserve upto 2GB of heap space.
11570
f7ff1b0f 115712011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
11572
11573 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
11574
639c109b
TZ
115752011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
11576
11577 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
11578 `gnutls_certificate_set_x509_key_file'.
11579
d2127135
JB
115802011-05-05 Juanma Barranquero <lekktu@gmail.com>
11581
11582 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
11583 Update dependencies.
11584
e968f4f3
JB
115852011-05-04 Juanma Barranquero <lekktu@gmail.com>
11586
11587 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
11588 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
11589 Remove unused parameter `fildes'.
11590 * process.c (read_process_output, send_process): Don't pass it.
11591
84d358f0
JB
115922011-05-04 Juanma Barranquero <lekktu@gmail.com>
11593
11594 Fix previous change: the library cache is defined in w32.c.
11595 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
11596 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
11597
0898ca10
JB
115982011-05-04 Juanma Barranquero <lekktu@gmail.com>
11599
11600 Implement dynamic loading of GnuTLS on Windows.
11601
11602 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
11603 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
11604 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11605 Declare.
11606
11607 * gnutls.c (Qgnutls_dll): Define.
11608 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
11609 (gnutls_*): Declare function pointers.
11610 (init_gnutls_functions): New function to initialize function pointers.
11611 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
11612 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
11613 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
11614 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
11615 (emacs_gnutls_write, emacs_gnutls_read)
11616 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
11617 (Fgnutls_available_p): New function.
11618 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
11619 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
11620 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
11621
11622 * image.c: Include w32.h.
11623 (Vimage_type_cache): Delete.
11624 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
11625 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
11626 (w32_delayed_load): Move to w32.c.
11627
11628 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
11629
11630 * w32.c (QCloaded_from, Vlibrary_cache): Define.
11631 (w32_delayed_load): Move from image.c. When loading a library, record
11632 its filename in the :loaded-from property of the library id.
11633 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
11634 Initialize and staticpro them.
11635 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
11636
11637 * process.c: Include lisp.h before w32.h, not after.
11638 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
11639 instead of gnutls_record_check_pending.
11640
11641 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
11642
ff4de4aa
TZ
116432011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
11644
11645 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
11646 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
11647 as passed in.
11648
abe95abb
JD
116492011-05-03 Jan Djärv <jan.h.d@swipnet.se>
11650
11651 * xterm.c (x_set_frame_alpha): Do not set property on anything
11652 else than FRAME_X_OUTER_WINDOW (Bug#8608).
11653
e16e55d4
JB
116542011-05-02 Juanma Barranquero <lekktu@gmail.com>
11655
11656 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
11657
bafcf6a5
JB
116582011-05-02 Juanma Barranquero <lekktu@gmail.com>
11659
11660 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
11661 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
11662 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
11663 (gnutls_global_initialized, Qgnutls_bootprop_priority)
11664 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
11665 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
11666 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
11667 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
11668 (Qgnutls_bootprop_callbacks_verify): Make static.
11669
e7a6747f
AS
116702011-05-01 Andreas Schwab <schwab@linux-m68k.org>
11671
19ed11ba
AS
11672 * callproc.c: Indentation fixup.
11673
e7a6747f 11674 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
11675 (wait_for_termination, interruptible_wait_for_termination):
11676 Move after wait_for_termination_1.
e7a6747f 11677
1ef14cb4
LMI
116782011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
11679
11680 * sysdep.c (interruptible_wait_for_termination): New function
11681 which is like wait_for_termination, but allows keyboard
11682 interruptions.
11683
11684 * callproc.c (Fcall_process): Add (:file "file") as an option for
11685 the STDOUT buffer.
11686 (Fcall_process_region): Ditto.
11687
330d880c
EZ
116882011-04-30 Eli Zaretskii <eliz@gnu.org>
11689
8db90b73
EZ
11690 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
11691 rather than `XVECTOR (FOO)->size'.
11692
330d880c
EZ
11693 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
11694 inttypes.h, as a gnulib replacement is used if it not available in
11695 system headers.
11696
15cbd324
EZ
116972011-04-21 Eli Zaretskii <eliz@gnu.org>
11698
11699 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
11700 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
11701 of MOST_POSITIVE_FIXNUM. (Bug#8528)
11702
11703 * coding.c (coding_alloc_by_realloc): Error out if destination
11704 will grow beyond MOST_POSITIVE_FIXNUM.
11705 (decode_coding_emacs_mule): Abort if there isn't enough place in
11706 charbuf for the composition carryover bytes. Reserve an extra
11707 space for up to 2 characters produced in a loop.
11708 (decode_coding_iso_2022): Abort if there isn't enough place in
11709 charbuf for the composition carryover bytes.
11710
117112011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 11712
ae940cca
EZ
11713 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
11714 aborting when %lld or %lll format is passed.
11715 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
11716 %llo or %llx format is passed. (Bug#8545)
11717
03ab8921
EZ
11718 * window.c (window_scroll_line_based): Use a marker instead of
11719 simple variables to record original value of point. (Bug#7952)
11720
afda1437
EZ
11721 * doprnt.c (doprnt): Fix the case where a multibyte sequence
11722 produced by %s or %c overflows available buffer space. (Bug#8545)
11723
f76dee0c
PE
117242011-04-28 Paul Eggert <eggert@cs.ucla.edu>
11725
11726 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 11727 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 11728
fdc5744d
JB
117292011-04-28 Juanma Barranquero <lekktu@gmail.com>
11730
11731 * w32.c (init_environment): Warn about defaulting HOME to C:\.
11732
638f053a
JB
117332011-04-28 Juanma Barranquero <lekktu@gmail.com>
11734
11735 * keyboard.c (Qdelayed_warnings_hook): Define.
11736 (command_loop_1): Run `delayed-warnings-hook'
11737 if Vdelayed_warnings_list is non-nil.
11738 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
11739 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
11740
d178f871
EZ
117412011-04-28 Eli Zaretskii <eliz@gnu.org>
11742
11743 * doprnt.c (doprnt): Don't return value smaller than the buffer
11744 size if the message was truncated. (Bug#8545).
11745
b124fd93
JB
117462011-04-28 Juanma Barranquero <lekktu@gmail.com>
11747
11748 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
11749 (Fx_window_property): #if-0 the whole functions, not just the bodies.
11750
e810457d
PE
117512011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11752
11753 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
11754
ea51cceb
JB
117552011-04-27 Juanma Barranquero <lekktu@gmail.com>
11756
11757 * makefile.w32-in: Update dependencies.
11758
94dcfacf
EZ
117592011-04-27 Eli Zaretskii <eliz@gnu.org>
11760
11761 Improve `doprnt' and its usage. (Bug#8545)
11762 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
11763 `format_end'. Remove support for %l as a conversion specifier.
11764 Don't use xrealloc. Improve diagnostics when the %l size modifier
11765 is used. Update the commentary.
11766
11767 * eval.c (verror): Simplify calculation of size_t.
11768
11769 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
11770 messages.
11771
f61f41d7
PE
117722011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
11773
11774 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
11775 change.
11776
96fb4434
PE
117772011-04-27 Paul Eggert <eggert@cs.ucla.edu>
11778
11779 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
11780 This makes this file independent of the recent pseudovector change.
11781
671875da 117822011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 11783
69e9b5a3
PE
11784 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
11785
b5f869a7 11786 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 11787 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 11788 Remove unused local.
c8926152 11789 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 11790
841a1577 11791 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
11792 GCC 4.6.0 optimizes based on type-based alias analysis.
11793 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
11794 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
11795 != &v->size, and therefore "v->size = 1; b->size = 2; return
11796 v->size;" must therefore return 1. This assumption is incorrect
11797 for Emacs, since it type-puns struct Lisp_Vector * with many other
11798 types. To fix this problem, this patch adds a new type struct
f904488f 11799 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
11800 and pseudovectors, and helps optimizing compilers not get fooled
11801 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
11802 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
11803 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
11804 the size member.
eab3844f
PE
11805 (XSETPVECTYPE): Rewrite in terms of new macro.
11806 (XSETPVECTYPESIZE): New macro, specifying both type and size.
11807 This is a bit clearer, and further avoids the possibility of
11808 undesirable aliasing.
11809 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 11810 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
11811 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
11812 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
11813 (ASIZE): Now uses header.size rather than size.
11814 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
11815 to avoid the hassle of writing XVECTOR (foo)->header.size.
11816 (struct vectorlike_header): New type.
eab3844f
PE
11817 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
11818 object, to help avoid aliasing.
11819 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
11820 (SUBRP): Likewise, since Lisp_Subr is a special case.
11821 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
11822 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
11823 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 11824 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
11825 changed to be "header.size" and "header.next".
11826 * buffer.h (struct buffer): Likewise.
11827 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
11828 * frame.h (struct frame): Likewise.
11829 * process.h (struct Lisp_Process): Likewise.
11830 * termhooks.h (struct terminal): Likewise.
11831 * window.c (struct save_window_data, struct saved_window): Likewise.
11832 * window.h (struct window): Likewise.
11833 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
11834 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
11835 * buffer.c (init_buffer_once): Likewise.
11836 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
11837 special case.
11838 * process.c (Fformat_network_address): Use local var for size,
11839 for brevity.
11840
0df1eac5
PE
11841 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
11842
847ab9d1 11843 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
11844 * data.c (atof): Remove decl; no longer used or needed.
11845 (digit_to_number): Move to lread.c.
11846 (Fstring_to_number): Use new string_to_number function, to be
11847 consistent with how the Lisp reader treats infinities and NaNs.
11848 Do not assume that floating-point numbers represent EMACS_INT
11849 without losing information; this is not true on most 64-bit hosts.
11850 Avoid double-rounding errors, by insisting on integers when
11851 parsing non-base-10 numbers, as the documentation specifies.
11852 * lisp.h (string_to_number): New decl, replacing ...
11853 (isfloat_string): Remove.
bc0a5c13 11854 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 11855 (read1): Do not accept +. and -. as integers; this
452f4150
PE
11856 appears to have been a coding error. Similarly, do not accept
11857 strings like +-1e0 as floating point numbers. Do not report
11858 overflow for integer overflows unless the base is not 10 which
11859 means we have no simple and reliable way to continue.
11860 Break out the floating-point parsing into a new
11861 function string_to_number, so that Fstring_to_number parses
11862 floating point numbers consistently with the Lisp reader.
04f2d78b 11863 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
11864 (E_CHAR, EXP_INT): Remove, replacing with ...
11865 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
11866 (string_to_number): New function, replacing isfloat_string.
11867 This function checks for valid syntax and produces the resulting
11868 Lisp float number too. Rework it so that string-to-number
bc0a5c13 11869 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
11870 so that overflow for non-base-10 numbers is reported only when
11871 there's no portable and simple way to convert to floating point.
452f4150 11872
67769ffc
PE
11873 * textprop.c (set_text_properties_1): Rewrite for clarity,
11874 and to avoid GCC warning about integer overflow.
11875
c20db43f
PE
11876 * intervals.h (struct interval): Use EMACS_INT for members
11877 where EMACS_UINT might cause problems. See
11878 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
11879 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
11880 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
11881 All uses changed.
37aa2f85
PE
11882 (offset_intervals): Tell GCC not to worry about length overflow
11883 when negating a negative length.
c20db43f 11884
2538aa2f
PE
11885 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
11886 (overrun_check_free): Likewise.
11887
f2d3008d
PE
11888 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
11889 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
11890 word size.
11891
ec8df744
PE
11892 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11893 (gnutls_make_error): Rename local to avoid shadowing.
11894 (gnutls_emacs_global_deinit): ifdef out; not used.
11895 (Fgnutls_boot): Use const for pointer to readonly storage.
11896 Comment out unused local. Fix pointer signedness problems.
11897
640ee02d
PE
11898 * lread.c (openp): Don't stuff size_t into an 'int'.
11899 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
11900 about possible signed overflow.
11901
6048fb2a
PE
11902 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
11903 (GDK_KEY_g): Don't define if already defined.
11904 (xg_prepare_tooltip): Avoid pointer signedness problem.
11905 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
11906
fa3c87e1
PE
11907 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
11908 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
11909
2172544b
PE
11910 * xfns.c (Fx_window_property): Simplify a bit,
11911 to make a bit faster and to avoid GCC 4.6.0 warning.
11912 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
11913
9b821a21
PE
11914 * fns.c (internal_equal): Don't assume size_t fits in int.
11915
3c616cfa
PE
11916 * alloc.c (compact_small_strings): Tighten assertion a little.
11917
c2982e87
PE
11918 Replace pEd with more-general pI, and fix some printf arg casts.
11919 * lisp.h (pI): New macro, generalizing old pEd macro to other
11920 conversion specifiers. For example, use "...%"pI"d..." rather
11921 than "...%"pEd"...".
11922 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 11923 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
11924 * alloc.c (check_pure_size): Don't overflow by converting size to int.
11925 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
11926 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
11927 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
11928 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
11929 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
11930 64-bit hosts.
11931 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
11932 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
11933 * print.c (safe_debug_print, print_object): Likewise.
11934 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
11935 to int.
6f04d126
PE
11936 Use pI instead of if-then-else-abort. Use %p to avoid casts,
11937 avoiding the 0 flag, which is not portable.
c2982e87
PE
11938 * process.c (Fmake_network_process): Use pI to avoid cast.
11939 * region-cache.c (pp_cache): Likewise.
11940 * xdisp.c (decode_mode_spec): Likewise.
11941 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
11942 behavior on 64-bit hosts with printf arg.
6f04d126 11943 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
11944 (x_stop_queuing_selection_requests): Likewise.
11945 (x_get_window_property): Don't truncate byte count to an 'int'
11946 when tracing.
0b432f21 11947
5e073ec7
PE
11948 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
11949 here, since it parses constructs like leading '-' and spaces,
11950 which are not wanted; and it overflows with large numbers.
11951 Instead, simply match F[0-9]+, which is what is wanted anyway.
11952
36372bf9
PE
11953 * alloc.c: Remove unportable assumptions about struct layout.
11954 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
11955 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
11956 (allocate_vectorlike, make_pure_vector): Use the new macros,
11957 plus offsetof, to remove unportable assumptions about struct layout.
11958 These assumptions hold on all porting targets that I know of, but
11959 they are not guaranteed, they're easy to remove, and removing them
11960 makes further changes easier.
11961
0b432f21
PE
11962 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
11963 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
11964 (string_overrun_cookie): Now const. Use initializers that
11965 don't formally overflow signed char, to avoid warnings.
000098c1
PE
11966 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
11967 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
11968 (allocate_buffer): Don't assume sizeof (struct buffer) is a
11969 multiple of sizeof (EMACS_INT); it need not be, if
11970 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 11971 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 11972
895009e1
JB
119732011-04-26 Juanma Barranquero <lekktu@gmail.com>
11974
11975 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
11976
6a7a1b0b
TZ
119772011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
11978
11979 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 11980 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
11981 Reported by Paul Eggert <eggert@cs.ucla.edu>.
11982
841a1577 119832011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
11984
11985 * lisp.h (Qdebug): List symbol.
895009e1 11986 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
11987 * keyboard.c (debug-on-event): New variable.
11988 (handle_user_signal): Break into debugger when debug-on-event
11989 matches the current signal symbol.
11990
f2d3ba6f
DN
119912011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
11992
11993 * alloc.c (check_sblock, check_string_bytes)
11994 (check_string_free_list): Convert to standard C.
11995
42ce4c63
TZ
119962011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
11997
11998 * w32.c (emacs_gnutls_push): Fix typo.
11999
825cd63c
EZ
120002011-04-25 Eli Zaretskii <eliz@gnu.org>
12001
fb11d64d
EZ
12002 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
12003 "cast to pointer from integer of different size".
12004
825cd63c
EZ
12005 Improve doprnt and its use in verror. (Bug#8545)
12006 * doprnt.c (doprnt): Document the set of format control sequences
12007 supported by the function. Use SAFE_ALLOCA instead of always
12008 using `alloca'.
12009
12010 * eval.c (verror): Don't limit the buffer size at size_max-1, that
12011 is one byte too soon. Don't use xrealloc; instead xfree and
12012 xmalloc anew.
12013
e061a11b
TZ
120142011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
12015
12016 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
12017 callbacks stage.
12018
12019 * gnutls.c: Renamed global_initialized to
12020 gnutls_global_initialized. Added internals for the
12021 :verify-hostname-error, :verify-error, and :verify-flags
12022 parameters of `gnutls-boot' and documented those parameters in the
12023 docstring. Start callback support.
9173deec
JB
12024 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
12025 unless a fatal error occurred. Call gnutls_alert_send_appropriate
12026 on error. Return error code.
e061a11b
TZ
12027 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
12028 (emacs_gnutls_read): Likewise.
12029 (Fgnutls_boot): Return handshake error code.
12030 (emacs_gnutls_handle_error): New function.
12031 (wsaerror_to_errno): Likewise.
12032
12033 * w32.h (emacs_gnutls_pull): Add prototype.
12034 (emacs_gnutls_push): Likewise.
12035
12036 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
12037 (emacs_gnutls_push): Likewise.
12038
120392011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
12040
12041 * process.c (wait_reading_process_output): Check if GnuTLS
12042 buffered some data internally if no FDs are set for TLS
12043 connections.
12044
12045 * makefile.w32-in (OBJ2): Add gnutls.$(O).
12046 (LIBS): Link to USER_LIBS.
12047 ($(BLD)/gnutls.$(0)): New target.
12048
fa6996bc
EZ
120492011-04-24 Eli Zaretskii <eliz@gnu.org>
12050
eb35682e
EZ
12051 * xdisp.c (handle_single_display_spec): Rename the
12052 display_replaced_before_p argument into display_replaced_p, to
12053 make it consistent with the commentary. Fix typos in the
12054 commentary.
12055
e2ad650c
EZ
12056 * textprop.c (syms_of_textprop): Remove dead code.
12057 (copy_text_properties): Delete obsolete commentary about an
12058 interface that was deleted long ago. Fix typos in the description
12059 of arguments.
12060
1b2de274
EZ
12061 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
12062 to changes in oldXMenu/XMenu.h from 2011-04-16.
12063 <menu_help_message, prev_menu_help_message>: Constify.
12064 (IT_menu_make_room): menu->help_text is now `const char **';
12065 adjust.
12066
12067 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
12068 to changes in oldXMenu/XMenu.h from 2011-04-16.
12069 (struct XMenu): Declare `help_text' `const char **'.
12070
12071 * xfaces.c <Qunspecified>: Make extern again.
12072
12073 * syntax.c: Include sys/types.h before including regex.h, as
75f1671a 12074 required by POSIX.
1b2de274 12075
762b15be
EZ
12076 * doc.c (get_doc_string): Improve the format passed to `error'.
12077
12078 * doprnt.c (doprnt): Improve commentary.
12079
12080 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
12081
12082 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
12083 them with etags.
12084
f1052e5d
EZ
12085 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
12086 changes in globals.h immediately force recompilation.
762b15be
EZ
12087 (TAGS): Depend on $(CURDIR)/m/intel386.h and
12088 $(CURDIR)/s/ms-w32.h.
12089 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 12090
fa6996bc
EZ
12091 * character.c (Fchar_direction): Function deleted.
12092 (syms_of_character): Don't defsubr it.
12093 <char-direction-table>: Deleted.
12094
e6c3da20
EZ
120952011-04-23 Eli Zaretskii <eliz@gnu.org>
12096
12097 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
12098 * doprnt.c: Include limits.h.
12099 (SIZE_MAX): New macro.
04f2d78b
CB
12100 (doprnt): Return a size_t value. 2nd arg is now size_t.
12101 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
12102 Improve overflow protection. Support `l' modifier for integer
12103 conversions. Support %l conversion. Don't assume an EMACS_INT
12104 argument for integer conversions and for %c.
12105
12106 * lisp.h (doprnt): Restore prototype.
12107
12108 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
12109 $(SRC)/character.h.
12110
12111 * Makefile.in (base_obj): Add back doprnt.o.
12112
12113 * deps.mk (doprnt.o): Add back prerequisites.
12114 (callint.o): Depend on character.h.
12115
12116 * eval.c (internal_lisp_condition_case): Include the handler
12117 representation in the error message.
12118 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
12119 when breaking from the loop.
12120
12121 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
12122
12123 * callint.c (Fcall_interactively): When displaying error message
12124 about invalid control letter, pass the character's codepoint, not
12125 a pointer to its multibyte form. Improve display of the character
12126 in octal and display also its hex code.
12127
12128 * character.c (char_string): Use %x to display the (unsigned)
12129 codepoint of an invalid character, to avoid displaying a bogus
12130 negative value.
12131
12132 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
12133 `error', not SYMBOL_NAME itself.
12134
12135 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
12136 character arguments to `error'.
12137
12138 * charset.c (check_iso_charset_parameter): Fix incorrect argument
12139 to `error' in error message about FINAL_CHAR argument. Make sure
12140 FINAL_CHAR is a character, and use %c when it is passed as
12141 argument to `error'.
12142
4ffd0d6b 121432011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
12144
12145 * s/ms-w32.h (localtime): Redirect to sys_localtime.
12146
12147 * w32.c: Include <time.h>.
12148 (sys_localtime): New function.
12149
4ffd0d6b 121502011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
12151
12152 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
12153
4ffd0d6b 12154 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 12155
4ffd0d6b 121562011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 12157
4ffd0d6b
GM
12158 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
12159 zombies (Bug#8467).
aac0c6e3 12160
04c56954
EZ
121612011-04-19 Eli Zaretskii <eliz@gnu.org>
12162
12163 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
12164 gl_state.e_property when gl_state.object is Qt.
12165
12166 * insdel.c (make_gap_larger): Remove limitation of buffer size
12167 to <= INT_MAX.
12168
16a43933
CY
121692011-04-18 Chong Yidong <cyd@stupidchicken.com>
12170
12171 * xdisp.c (lookup_glyphless_char_display)
12172 (produce_glyphless_glyph): Handle cons cell entry in
12173 glyphless-char-display.
12174 (Vglyphless_char_display): Document it.
12175
12176 * term.c (produce_glyphless_glyph): Handle cons cell entry in
12177 glyphless-char-display.
12178
4581706e
CY
121792011-04-17 Chong Yidong <cyd@stupidchicken.com>
12180
12181 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
12182
12183 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
12184
12185 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
12186 definition for no-X builds.
12187
4887c6e2 121882011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 12189
fd35b6f9
PE
12190 Static checks with GCC 4.6.0 and non-default toolkits.
12191
5c1ccb01
PE
12192 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
12193
006c5daa
PE
12194 * process.c (keyboard_bit_set): Define only if SIGIO.
12195 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
12196 (send_process): Repair possible setjmp clobbering.
12197
efc736d3
PE
12198 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
12199
4e2fe2e6
PE
12200 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
12201
f97334a2
PE
12202 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
12203
4e75f29d
PE
12204 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
12205 Define only if needed.
12206
90efadd1
PE
12207 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
12208 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 12209 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 12210
3c647824
PE
12211 * dispextern.h (struct redisplay_interface): Rename param
12212 to avoid shadowing.
e264f262 12213 * termhooks.h (struct terminal): Likewise.
761383f4 12214 * xterm.c (xembed_send_message): Likewise.
3c647824 12215
b58c5c4a
PE
12216 * insdel.c (make_gap_smaller): Define only if
12217 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
12218
cad59032
PE
12219 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
12220 it.
12221
c339dc2e
PE
12222 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
12223 so that we aren't warned about unused symbols.
12224
91a3e27b
PE
12225 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
12226
399c71d3 12227 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 12228
8ffc96f5
PE
12229 * xfns.c (x_real_positions): Mark locals as initialized.
12230
eef9bc79
PE
12231 * xmenu.c (xmenu_show): Don't use uninitialized vars.
12232
098db9dd
PE
12233 * xterm.c: Fix problems found by static analysis with other toolkits.
12234 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
12235 (x_dispatch_event): Declare static if USE_GTK, and
12236 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 12237 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 12238 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
12239 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
12240 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 12241
eb18f6cc
PE
12242 * xmenu.c (menu_help_callback): Pointer type fixes.
12243 Use const pointers when pointing at readonly data. Avoid pointer
12244 signedness clashes.
12245 (FALSE): Remove unused macro.
12246 (update_frame_menubar): Remove unused decl.
12247
1fe72bf8
PE
12248 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
12249
60d9e1db
PE
12250 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
12251 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
12252 (single_menu_item): Rename local to avoid shadowing.
12253
39261c26
PE
12254 * keyboard.c (make_lispy_event): Remove unused local var.
12255
018c5e19
PE
12256 * frame.c, frame.h (x_get_resource_string): Bring this back, but
12257 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
12258
63d2b86e
PE
12259 * bitmaps: Change bitmaps from unsigned char back to the X11
12260 compatible char. Avoid the old compiler warnings about
12261 out-of-range initializers by using, for example, '\xab' rather
12262 than 0xab.
12263
aefd87e1
PE
12264 * xgselect.c (xgselect_initialize): Check vs interface
12265 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
12266
bf501fb9
PE
12267 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
12268
e9829fdf
PE
12269 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
12270 to read-only memory.
12271
1086c095
PE
12272 * fns.c (vector): Remove; this old hack is no longer needed.
12273
2baccd04 12274 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 12275 Remove unused var.
dde42981 12276 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 12277
72391843 12278 * xrdb.c (x_load_resources): Omit unused local.
3565b346 12279
436c16df 12280 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 12281 (x_window): Rename locals to avoid shadowing.
dc5ddd85 12282 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 12283
92bb796d 12284 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 12285 (x_term_init): Remove local to avoid shadowing.
92bb796d 12286
764430a3 12287 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
12288
12289 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
12290 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
12291
d1dfb56c
EZ
122922011-04-16 Eli Zaretskii <eliz@gnu.org>
12293
c4354cb4
EZ
12294 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
12295
d1dfb56c
EZ
12296 Fix regex.c, syntax.c and friends for buffers > 2GB.
12297 * syntax.h (struct gl_state_s): Declare character position members
12298 EMACS_INT.
12299
12300 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
12301
04f2d78b
CB
12302 * textprop.c (verify_interval_modification, interval_of):
12303 Declare arguments EMACS_INT.
d1dfb56c
EZ
12304
12305 * intervals.c (adjust_intervals_for_insertion): Declare arguments
12306 EMACS_INT.
12307
12308 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
12309
12310 * indent.c (Fvertical_motion): Local variable it_start is now
12311 EMACS_INT.
12312
12313 * regex.c (re_match, re_match_2, re_match_2_internal)
12314 (bcmp_translate, regcomp, regexec, print_double_string)
12315 (group_in_compile_stack, re_search, re_search_2, regex_compile)
12316 (re_compile_pattern, re_exec): Declare arguments and local
12317 variables `size_t' and `ssize_t' and return values `regoff_t', as
12318 appropriate.
12319 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
12320 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
12321 <compile_stack_type>: `size' and `avail' are now `size_t'.
12322
12323 * regex.h <regoff_t>: Use ssize_t, not int.
12324 (re_search, re_search_2, re_match, re_match_2): Arguments that
12325 specify buffer/string position and length are now ssize_t and
12326 size_t. Return type is regoff_t.
12327
613052cd
BK
123282011-04-16 Ben Key <bkey76@gmail.com>
12329
12330 * nsfont.m: Fixed bugs in ns_get_family and
12331 ns_descriptor_to_entity that were caused by using free to
12332 deallocate memory blocks that were allocated by xmalloc (via
12333 xstrdup). This caused Emacs to crash when compiled with
12334 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
12335 --enable-checking=xmallocoverrun). xfree is now used to
12336 deallocate these memory blocks.
12337
4170f62f 123382011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 12339
71b41406
PE
12340 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
12341
9587a89d
PE
12342 emacs_write: Accept and return EMACS_INT for sizes.
12343 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
12344 et seq.
12345 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
12346 Accept and return EMACS_INT.
12347 (emacs_gnutls_write): Return the number of bytes written on
12348 partial writes.
12349 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
12350 (emacs_read, emacs_write): Remove check for negative size, as the
12351 Emacs source code has been audited now.
9587a89d
PE
12352 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
12353 (emacs_read, emacs_write): Use it.
273a5f82
PE
12354 * process.c (send_process): Adjust to the new signatures of
12355 emacs_write and emacs_gnutls_write. Do not attempt to store
12356 a byte offset into an 'int'; it might overflow.
9587a89d 12357 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 12358
3e047f51
PE
12359 * sound.c: Don't assume sizes fit in 'int'.
12360 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 12361 Return EMACS_INT, not int.
3e047f51 12362 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
12363 Accept EMACS_INT, not int.
12364 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
12365 record read return values.
12366
cc39a9db
BK
123672011-04-15 Ben Key <bkey76@gmail.com>
12368
c9d0ec6d
JB
12369 * keyboard.c (Qundefined): Don't declare static since it is used
12370 in nsfns.m.
12371 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
12372 static since they are used in nsfont.m.
cc39a9db 12373
6c60eb9f
SM
123742011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
12375
12376 * process.c (Qprocessp): Don't declare static.
12377 * lisp.h (Qprocessp): Declare again.
12378
7990b61a
JB
123792011-04-15 Juanma Barranquero <lekktu@gmail.com>
12380
12381 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
12382
5d4cb038
PE
123832011-04-14 Paul Eggert <eggert@cs.ucla.edu>
12384
8bd7b830 12385 Improve C-level modularity by making more things 'static'.
cd64ea1d 12386
e3b27b31
PE
12387 Don't publish debugger-only interfaces to other modules.
12388 * lisp.h (safe_debug_print, debug_output_compilation_hack):
12389 (verify_bytepos, count_markers): Move decls to the only modules
12390 that need them.
12391 * region-cache.h (pp_cache): Likewise.
12392 * window.h (check_all_windows): Likewise.
12393 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
12394
5d4cb038
PE
12395 * sysdep.c (croak): Now static, if
12396 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
12397 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
12398
12399 * alloc.c (refill_memory_reserve): Now static if
12400 !defined REL_ALLOC || defined SYSTEM_MALLOC.
12401 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 12402
e87b6180
PE
12403 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
12404 Define only if USE_LUCID.
12405
ac64929e
PE
12406 * xrdb.c (x_customization_string, x_rm_string): Now static.
12407
6f37259d
PE
12408 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
12409 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
12410
1683e3ab
PE
12411 * xdisp.c (draw_row_with_mouse_face): Now static.
12412 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
12413
de9c2632
PE
12414 * window.h (check_all_windows): Mark externally visible.
12415
2b96acb7
PE
12416 * window.c (window_deletion_count): Now static.
12417
12418 * undo.c: Make symbols static if they're not exported.
12419 (last_undo_buffer, last_boundary_position, pending_boundary):
12420 Now static.
12421
50436f33
PE
12422 * textprop.c (interval_insert_behind_hooks): Now static.
12423 (interval_insert_in_front_hooks): Likewise.
12424
64520e5c
PE
12425 * term.c: Make symbols static if they're not exported.
12426 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
12427 (max_frame_lines, tty_set_terminal_modes):
12428 (tty_reset_terminal_modes, tty_turn_off_highlight):
12429 (get_tty_terminal): Now static.
12430 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
12431 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 12432 HAVE_WINDOW_SYSTEM.
64520e5c
PE
12433 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
12434 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
12435
1fa53021
PE
12436 * sysdep.c: Make symbols static if they're not exported.
12437 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
12438 Now static.
12439 (sigprocmask_set, full_mask): Remove; unused.
12440 (wait_debugging): Mark as visible.
12441 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
12442 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
12443
d4b43b22
PE
12444 * syntax.c (syntax_temp): Define only if !__GNUC__.
12445
b7c513d0
PE
12446 * sound.c (current_sound_device, current_sound): Now static.
12447
989b29ad
PE
12448 * search.c (searchbufs, searchbuf_head): Now static.
12449
13a55a78
PE
12450 * scroll.c (scroll_cost): Remove; unused.
12451 * dispextern.h (scroll_cost): Remove decl.
12452
de68a1fc
PE
12453 * region-cache.h (pp_cache): Mark as externally visible.
12454
40ccffa6
PE
12455 * process.c: Make symbols static if they're not exported.
12456 (process_tick, update_tick, create_process, chan_process):
12457 (Vprocess_alist, proc_buffered_char, datagram_access):
12458 (fd_callback_data, send_process_frame, process_sent_to): Now static.
12459 (deactivate_process): Mark defn as static, as well as decl.
12460 * lisp.h (create_process): Remove decl.
12461 * process.h (chan_process, Vprocess_alist): Remove decls.
12462
ad64fc97
PE
12463 * print.c: Make symbols static if they're not exported.
12464 (print_depth, new_backquote_output, being_printed, print_buffer):
12465 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
12466 (print_interval, print_number_index, initial_stderr_stream):
12467 Now static.
12468 * lisp.h (Fprinc): Remove decl.
12469 (debug_output_compilation_hack): Mark as externally visible.
12470
adddb265
PE
12471 * sysdep.c (croak): Move decl from here to syssignal.h.
12472 * syssignal.h (croak): Put it here, so the API can be checked when
12473 'croak' is called from dissociate_if_controlling_tty.
12474
1717ede2
PE
12475 * minibuf.c: Make symbols static if they're not exported.
12476 (minibuf_save_list, choose_minibuf_frame): Now static.
12477 * lisp.h (choose_minibuf_frame): Remove decl.
12478
fa5fb2bc
PE
12479 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
12480
1e3890d1
PE
12481 * lread.c: Make symbols static if they're not exported.
12482 (read_objects, initial_obarray, oblookup_last_bucket_number):
12483 Now static.
12484 (make_symbol): Remove; unused.
12485 * lisp.h (initial_obarray, make_symbol): Remove decls.
12486
8a1414fa
PE
12487 * keyboard.c: Make symbols static if they're not exported.
12488 (single_kboard, recent_keys_index, total_keys, recent_keys):
12489 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
12490 (this_single_command_key_start, echoing, last_auto_save):
12491 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
12492 (command_loop, echo_now, keyboard_init_hook, help_char_p):
12493 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
12494 (Vlispy_mouse_stem, double_click_count):
12495 Now static.
12496 (force_auto_save_soon): Define only if SIGDANGER.
12497 (ignore_mouse_drag_p): Now static if
12498 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
12499 (print_help): Remove; unused.
12500 (stop_character, last_timer_event): Mark as externally visible.
12501 * keyboard.h (ignore_mouse_drag_p): Declare only if
12502 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
12503 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
12504 * lisp.h (echoing): Remove decl.
12505 (force_auto_save_soon): Declare only if SIGDANGER.
12506 * xdisp.c (redisplay_window): Simplify code, to make it more
12507 obvious that ignore_mouse_drag_p is not accessed if !defined
12508 USE_GTK && !defined HAVE_NS.
12509
93ea6e8f
PE
12510 * intervals.c: Make symbols static if they're not exported.
12511 (merge_properties_sticky, merge_interval_right, delete_interval):
12512 Now static.
12513 * intervals.h (merge_interval_right, delete_interval): Remove decls.
12514
77382fcc
PE
12515 * insdel.c: Make symbols static if they're not exported.
12516 However, leave prepare_to_modify_buffer alone. It's never
12517 called from outside this function, but that appears to be a bug.
12518 (combine_after_change_list, combine_after_change_buffer):
4889fc82 12519 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
12520 (adjust_after_replace_noundo): Remove; unused.
12521 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 12522 (signal_before_change): Remove decls.
77382fcc 12523
9306c32e
PE
12524 * indent.c (val_compute_motion, val_vmotion): Now static.
12525
cd44d2eb
PE
12526 * image.c: Make symbols static if they're not exported.
12527 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
12528 if USE_GTK.
12529 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
12530 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
12531
ad9a7a06
PE
12532 * fringe.c (standard_bitmaps): Now static.
12533 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
12534
81626931
PE
12535 * frame.c: Make symbols static if they're not exported.
12536 (x_report_frame_params, make_terminal_frame): Now static.
12537 (get_frame_param): Now static, unless HAVE_NS.
12538 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
12539 (x_get_resource_string): Remove; not used.
12540 * frame.h (make_terminal_frame, x_report_frame_params):
12541 (x_get_resource_string); Remove decls.
12542 (x_fullscreen_adjust): Declare only if WINDOWSNT.
12543 * lisp.h (get_frame_param): Declare only if HAVE_NS.
12544
239f9db9
PE
12545 * font.c, fontset.c: Make symbols static if they're not exported.
12546 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
12547 (FACE_SUITABLE_FOR_CHAR_P): Use it.
12548 * font.c (font_close_object): Now static.
12549 * font.h (font_close_object): Remove.
12550 * fontset.c (FONTSET_OBJLIST): Remove.
12551 (free_realized_fontset) #if-0 the body, which does nothing.
12552 (face_suitable_for_char_p): #if-0, as it's never called.
12553 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
12554 * xfaces.c (face_at_string_position):
12555 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
12556 since 0 is always ASCII.
12557
dfcf3579
PE
12558 * fns.c (weak_hash_tables): Now static.
12559
5045092b
PE
12560 * fileio.c: Make symbols static if they're not exported.
12561 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
12562 (Vwrite_region_annotation_buffers): Now static.
12563
57a96f5c
PE
12564 * eval.c: Make symbols static if they're not exported.
12565 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
12566 * lisp.h (backtrace_list): Remove decl.
12567
35f08c38
PE
12568 * emacs.c: Make symbols static if they're not exported.
12569 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
12570 (fatal_error_code, fatal_error_signal_hook, standard_args):
12571 Now static.
12572 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
12573 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
12574 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
12575 * lisp.h (fatal_error_signal_hook): Remove decl.
12576 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
12577
f44bd759
PE
12578 * editfns.c: Move a (normally-unused) function to its only use.
12579 * editfns.c, lisp.h (get_operating_system_release): Remove.
12580 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
12581 worth the hassle of breaking this out.
12582
b532497d
PE
12583 * xterm.c: Make symbols static if they're not exported.
12584 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
12585 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
12586 (x_destroy_window, x_delete_display):
12587 Now static.
12588 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
12589 (x_mouse_leave): Remove; unused.
12590 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
12591 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
12592 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
12593 Remove decls.
12594 (x_mouse_leave): Declare only if WINDOWSNT.
12595 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
12596 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
12597 USE_X_TOOLKIT.
12598
1675728f
PE
12599 * ftxfont.c: Make symbols static if they're not exported.
12600 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
12601 HAVE_FREETYPE.
12602 * font.h (ftxfont_driver): Likewise.
12603
e4cebfca
PE
12604 * xfns.c: Make symbols static if they're not exported.
12605 (x_last_font_name, x_display_info_for_name):
12606 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
12607 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
12608 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
12609 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
12610 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
12611 (last_show_tip_args): Now static.
12612 (xic_defaut_fontset, xic_create_fontsetname): Define only if
12613 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
12614 (x_screen_planes): Remove; unused.
12615 * dispextern.h (x_screen_planes): Remove decl.
12616
5bf46f05
PE
12617 * dispnew.c: Make symbols static if they're not exported.
12618 * dispextern.h (redraw_garbaged_frames, scrolling):
12619 (increment_row_positions): Remove.
12620 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
12621 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
12622 Now static.
12623 (redraw_garbaged_frames): Remove; unused.
12624
435f4c28
PE
12625 * xfaces.c: Make symbols static if they're not exported.
12626 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
12627 Remove decls.
12628 * xterm.h (defined_color): Remove decls.
12629 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
12630 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
12631 (menu_face_changed_default, defined_color, free_realized_face):
12632 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
12633 (ascii_face_of_lisp_face): Remove; unused.
12634
8524aef3
PE
12635 * xdisp.c: Make symbols static if they're not exported.
12636 * dispextern.h (scratch_glyph_row, window_box_edges):
12637 (glyph_to_pixel_coords, set_cursor_from_row):
12638 (get_next_display_element, set_iterator_to_next):
12639 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
12640 (show_mouse_face): Remove decls
12641 * frame.h (message_buf_print): Likewise.
12642 * lisp.h (pop_message, set_message, check_point_in_composition):
12643 Likewise.
12644 * xterm.h (set_vertical_scroll_bar): Likewise.
12645 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
12646 (message_buf_print, scratch_glyph_row, displayed_buffer):
12647 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
12648 (get_next_display_element, show_mouse_face, window_box_edges):
12649 (frame_to_window_pixel_xy, check_point_in_composition):
12650 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
12651 (glyph_to_pixel_coords): Remove; unused.
12652
16390cd2
PE
12653 * dired.c (file_name_completion): Now static.
12654
12655 * dbusbind.c (xd_in_read_queued_messages): Now static.
12656
a25f4dfa
PE
12657 * lisp.h (circular_list_error, FOREACH): Remove; unused.
12658 * data.c (circular_list_error): Remove.
12659
14a9c8df
PE
12660 * commands.h (last_point_position, last_point_position_buffer):
12661 (last_point_position_window): Remove decls.
12662 * keyboard.c: Make these variables static.
12663
04f2d78b
CB
12664 * coding.h (coding, code_convert_region, encode_coding_gap):
12665 Remove decls.
74ab6df5
PE
12666 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
12667 (iso_code_class, detect_coding, code_convert_region): Now static.
12668 (encode_coding_gap): Remove; unused.
12669
38dfbee1
PE
12670 * chartab.c (chartab_chars, chartab_bits): Now static.
12671
a2cb4e63
PE
12672 * charset.h (charset_iso_8859_1): Remove decl.
12673 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
12674 Now static.
12675
127198fd
PE
12676 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
12677 * ccl.c (Vccl_program_table): Now static.
12678 (check_ccl_update): Remove; unused.
12679
d85b608f
PE
12680 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
12681 * category.h: ... from here.
12682 * category.c (check_category_table, set_category_set): Now static.
12683
31cd66f3
PE
12684 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
12685 * lisp.h: Remove these decls.
12686
c358e587
PE
12687 * buffer.c (buffer_count): Remove unused var.
12688
e78aecca
PE
12689 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
12690 so that it's not optimized away.
12691 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
12692 * dispextern.h (bidi_dump_cached_states): Remove, since it's
12693 exported only to the debugger.
12694
e192d7d3 12695 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 12696 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 12697
92470028
PE
12698 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
12699 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
12700 was inaccessible from Lisp.
12701 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
12702 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
12703
244ed907
PE
12704 alloc.c: Import and export fewer symbols, and remove unused items.
12705 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
12706 is defined.
12707 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
12708 it's not optimized away by whole-program optimization.
12709 (message_enable_multibyte, free_misc): Remove.
12710 (catchlist, handlerlist, mark_backtrace):
12711 Declare only if BYTE_MARK_STACK.
12712 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
12713 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
12714 (message_enable_multibyte): Remove decl.
12715 (free_misc, interval_free_list, float_block, float_block_index):
12716 (n_float_blocks, float_free_list, cons_block, cons_block_index):
12717 (cons_free_list, last_marked_index):
12718 Now static.
12719 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
12720 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
12721 (mark_backtrace): Define only if BYTE_MARK_STACK.
12722 * xdisp.c (message_enable_multibyte): Now static.
12723
61c2b50e 12724 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
12725 This makes it easier for human readers (and static analyzers)
12726 to see whether these variables are used from other modules.
12727 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
12728 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
12729 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
12730 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
12731 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
12732 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
12733 * xmenu.c, xselect.c:
12734 Declare Q* vars static if they are not used in other modules.
12735 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
12736 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
12737 Remove decls of unexported vars.
12738 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
12739
95c82688
PE
12740 * lisp.h (DEFINE_FUNC): Make sname 'static'.
12741
16a97296
PE
12742 Make Emacs functions such as Fatom 'static' by default.
12743 This makes it easier for human readers (and static analyzers)
12744 to see whether these functions can be called from other modules.
12745 DEFUN now defines a static function. To make the function external
12746 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
12747 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
12748 (Finit_image_library):
16a97296
PE
12749 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
12750 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
12751 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
12752 Remove decls, since these functions are now static.
12753 (Funintern, Fget_internal_run_time): New decls, since these functions
12754 were already external.
95c82688 12755
16a97296
PE
12756 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
12757 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
12758 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
12759 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
12760 * keyboard.c, keymap.c, lread.c:
12761 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
12762 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
12763 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
12764 Mark functions with DEFUE instead of DEFUN,
12765 if they are used in other modules.
12766 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
12767 decls for now-static functions.
12768 * buffer.h (Fdelete_overlay): Remove decl.
12769 * callproc.c (Fgetenv_internal): Mark as internal.
12770 * composite.c (Fremove_list_of_text_properties): Remove decl.
12771 (Fcomposition_get_gstring): New forward static decl.
12772 * composite.h (Fcomposite_get_gstring): Remove decl.
12773 * dired.c (Ffile_attributes): New forward static decl.
12774 * doc.c (Fdocumntation_property): New forward static decl.
12775 * eval.c (Ffetch_bytecode): New forward static decl.
12776 (Funintern): Remove extern decl; now in .h file where it belongs.
12777 * fileio.c (Fmake_symbolic_link): New forward static decl.
12778 * image.c (Finit_image_library): New forward static decl.
12779 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
12780 * intervals.h (Fprevious_property_change):
12781 (Fremove_list_of_text_properties): Remove decls.
12782 * keyboard.c (Fthis_command_keys): Remove decl.
12783 (Fcommand_execute): New forward static decl.
12784 * keymap.c (Flookup_key): New forward static decl.
12785 (Fcopy_keymap): Now static.
12786 * keymap.h (Flookup_key): Remove decl.
12787 * process.c (Fget_process): New forward static decl.
12788 (Fprocess_datagram_address): Mark as internal.
12789 * syntax.c (Fsyntax_table_p): New forward static decl.
12790 (skip_chars): Remove duplicate decl.
12791 * textprop.c (Fprevious_property_change): New forward static decl.
12792 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
12793 Now internal.
12794 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
12795 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
12796
785bbd42
PE
12797 * editfns.c (Fformat): Remove unreachable code.
12798
8b913b57
AS
127992011-04-14 Andreas Schwab <schwab@linux-m68k.org>
12800
12801 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
12802 change. (Bug#8496)
12803
a6744a35
EZ
128042011-04-13 Eli Zaretskii <eliz@gnu.org>
12805
12806 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
12807 when at ZV. (Bug#8487)
12808
e7974947
AS
128092011-04-12 Andreas Schwab <schwab@linux-m68k.org>
12810
baad03f0
AS
12811 * charset.c (Fclear_charset_maps): Use xfree instead of free.
12812 (Bug#8437)
12813 * keyboard.c (parse_tool_bar_item): Likewise.
12814 * sound.c (sound_cleanup, alsa_close): Likewise.
12815 * termcap.c (tgetent): Likewise.
12816 * xfns.c (x_default_font_parameter): Likewise.
12817 * xsettings.c (read_and_apply_settings): Likewise.
12818
e7974947
AS
12819 * alloc.c (overrun_check_malloc, overrun_check_realloc)
12820 (overrun_check_free): Protoize.
12821
28272684
PE
128222011-04-12 Paul Eggert <eggert@cs.ucla.edu>
12823
12824 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
12825 since callers should never pass a negative size.
12826 Change the signature to match that of plain 'read' and 'write'; see
12827 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
12828 * lisp.h: Update prototypes of emacs_write and emacs_read.
12829
11997c76
EZ
128302011-04-11 Eli Zaretskii <eliz@gnu.org>
12831
12832 * xdisp.c (redisplay_window): Don't try to determine the character
12833 position of the scroll margin if the window start point w->startp
e896f03c 12834 is outside the buffer's accessible region. (Bug#8468)
11997c76 12835
8a2cbd72
EZ
128362011-04-10 Eli Zaretskii <eliz@gnu.org>
12837
12838 Fix write-region and its subroutines for buffers > 2GB.
12839 * fileio.c (a_write, e_write): Modify declaration of arguments and
12840 local variables to support buffers larger than 2GB.
12841 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
12842
12843 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
12844 argument, local variables, and return value.
12845
12846 * lisp.h: Update prototypes of emacs_write and emacs_read.
12847
12848 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
12849
4073e537 128502011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 12851
1ebfdcb6
PE
12852 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
12853
b2ded58d
PE
12854 Fix more problems found by GCC 4.6.0's static checks.
12855
7d66342c
PE
12856 * xdisp.c (vmessage): Use a better test for character truncation.
12857
bbf47d44
PE
12858 * charset.c (load_charset_map): <, not <=, for optimization,
12859 and to avoid potential problems with integer overflow.
9248994d 12860 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 12861 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 12862 * editfns.c (Fformat): Likewise.
1e69125e 12863 * syntax.c (skip_chars): Likewise.
3befa583 12864
e3019616
PE
12865 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
12866 This also lets GCC 4.6.0 generate slightly better loop code.
12867
becfa255
PE
12868 * callint.c (Fcall_interactively): <, not <=, for optimization.
12869 (Fcall_interactively): Count the number of arguments produced,
12870 not the number of arguments given. This is simpler and lets GCC
12871 4.6.0 generate slightly better code.
12872
dae0cd48
PE
12873 * ftfont.c: Distingish more carefully between FcChar8 and char.
12874 The previous code passed unsigned char * to a functions like
12875 strlen and xstrcasecmp that expect char *, which does not
12876 conform to the C standard.
12877 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
12878 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
12879 char * when the C standard requires it.
12880
76032d70
PE
12881 * keyboard.c (read_char): Remove unused var.
12882
eb3f1cc8
PE
12883 * eval.c: Port to Windows vsnprintf (Bug#8435).
12884 Include <limits.h>.
12885 (SIZE_MAX): Define if the headers do not.
12886 (verror): Do not give up if vsnprintf returns a negative count.
12887 Instead, grow the buffer. This ports to Windows vsnprintf, which
12888 does not conform to C99. Problem reported by Eli Zaretskii.
12889 Also, simplify the allocation scheme, by avoiding the need for
12890 calling realloc, and removing the ALLOCATED variable.
12891
70476b54
PE
12892 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
12893
12020a9e
PE
12894 Remove invocations of doprnt, as Emacs now uses vsnprintf.
12895 But keep the doprint source code for now, as we might revamp it
12896 and use it again (Bug#8435).
ea6c7ae6
PE
12897 * lisp.h (doprnt): Remove.
12898 * Makefile.in (base_obj): Remove doprnt.o.
12899 * deps.mk (doprnt.o): Remove.
12900
5fdb398c
PE
12901 error: Print 32- and 64-bit integers portably (Bug#8435).
12902 Without this change, on typical 64-bit hosts error ("...%d...", N)
12903 was used to print both 32- and 64-bit integers N, which relied on
12904 undefined behavior.
61bdb816 12905 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
12906 * lisp.h (error, verror): Mark as printf-like functions.
12907 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
12908 Report overflow in size calculations when allocating printf buffer.
12909 Do not truncate output string at its first null byte.
12910 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
12911 Truncate the output at a character boundary, since vsnprintf does not
12912 do that.
12913 * charset.c (check_iso_charset_parameter): Convert internal
12914 character to string before calling 'error', since %c now has the
12915 printf meaning.
12916 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
12917 overflow when computing char to be passed to 'error'. Do not
12918 pass Lisp_Object to 'error'; pass the integer instead.
12919 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
12920 formatted with plain %d.
12921
b189fa66
PE
12922 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
12923
bff87ef0
PE
12924 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
12925
7e2cac20
PE
12926 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
12927
ce4d90b5
PE
12928 * xterm.c (x_catch_errors): Remove duplicate declaration.
12929
266c9547
PE
12930 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
12931
79c49ad2
PE
12932 * xdisp.c, lisp.h (message_nolog): Remove; unused.
12933
368f4090
JM
129342011-04-10 Jim Meyering <meyering@redhat.com>
12935
12936 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
12937 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
12938 return ssize_t not "int", and use size_t as the buffer length.
12939 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
12940 * gnutls.h: Update declarations.
12941 * process.c (read_process_output): Use ssize_t, to match.
12942 (send_process): Likewise.
12943
a32d4040
CY
129442011-04-09 Chong Yidong <cyd@stupidchicken.com>
12945
12946 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
12947
8546720e 129482011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 12949
04f2d78b
CB
12950 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
12951 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 12952
8546720e
GM
12953 * xterm.c (handle_one_xevent):
12954 * xmenu.c (create_and_show_popup_menu):
12955 * xselect.c (x_decline_selection_request)
12956 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 12957
0a2f5c1a 129582011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
12959
12960 Fix some uses of `int' instead of EMACS_INT.
12961 * search.c (string_match_1, fast_string_match)
12962 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
12963 (scan_buffer, find_next_newline_no_quit)
12964 (find_before_next_newline, search_command, Freplace_match)
12965 (Fmatch_data): Make some `int' variables be EMACS_INT.
12966
12967 * xdisp.c (display_count_lines): 3rd argument and return value now
12968 EMACS_INT. All callers changed.
12969 (pint2hrstr): Last argument is now EMACS_INT.
12970
12971 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
12972 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
12973 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
12974 (decode_coding_utf_16, decode_coding_emacs_mule)
12975 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
12976 (decode_coding_ccl, decode_coding_charset)
12977 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
12978 (decode_coding_iso_2022, decode_coding_emacs_mule)
12979 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
12980 <char_offset, last_offset>: Declare EMACS_INT.
12981 (encode_coding_utf_8, encode_coding_utf_16)
12982 (encode_coding_emacs_mule, encode_invocation_designation)
12983 (encode_designation_at_bol, encode_coding_iso_2022)
12984 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
12985 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
12986 Declare EMACS_INT.
12987 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
12988 (encode_invocation_designation): Last argument P_NCHARS is now
12989 EMACS_INT.
12990 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
12991 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
12992
12993 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
12994 All users changed.
12995
12996 * ccl.c (Fccl_execute_on_string): Declare some variables
12997 EMACS_INT.
12998
8546720e 129992011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
13000
13001 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
13002
4e19a977
CS
130032011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
13004
13005 * process.c (Fformat_network_address): Doc fix.
13006
87302331
R
130072011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
13008
ee7683eb 13009 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 13010
cbb59342
CY
130112011-04-08 Chong Yidong <cyd@stupidchicken.com>
13012
13013 * keyboard.c (read_char): Call Lisp function help-form-show,
13014 instead of using internal_with_output_to_temp_buffer.
13015 (Qhelp_form_show): New var.
e0d38eeb 13016 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
13017
13018 * print.c (internal_with_output_to_temp_buffer): Function deleted.
13019
13020 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
13021
e67a13ab
CY
130222011-04-06 Chong Yidong <cyd@stupidchicken.com>
13023
04f2d78b
CB
13024 * process.c (Flist_processes): Remove to Lisp.
13025 (list_processes_1): Delete.
e67a13ab 13026
973f782d
EZ
130272011-04-06 Eli Zaretskii <eliz@gnu.org>
13028
7c106b1e
EZ
13029 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
13030
973f782d
EZ
13031 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
13032
41cf7d1a 130332011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 13034
ca23cc88
PE
13035 Fix more problems found by GCC 4.6.0's static checks.
13036
f390e2d5
PE
13037 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
13038
42eea0d0
PE
13039 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
13040
b69769da 13041 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 13042
f9541e84
PE
13043 * xdisp.c (vmessage): Mark as a printf-like function.
13044
13841b55
PE
13045 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
13046
c136c10f
PE
13047 * sound.c (sound_warning): Don't crash if arg contains a printf format.
13048
5e2d4a30
PE
13049 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
13050 printf-like functions.
13051 (tiff_load): Add casts to remove these marks before passing them
13052 to system-supplied API.
13053
583f48b9
PE
13054 * eval.c (Fsignal): Remove excess argument to 'fatal'.
13055
b25d760e
PE
13056 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
13057 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
13058 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
13059 directly, rather than having caller test rule sign. This avoids
13060 some unnecessary tests.
13061 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
13062 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
13063 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 13064
bc7b6697 13065 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 13066 (xfont_open): Avoid unnecessary tests.
bc7b6697 13067
27ccc379
PE
13068 * composite.c (composition_gstring_put_cache): Use unsigned integer.
13069
dcd5c89a
PE
13070 * composite.h, composite.c (composition_gstring_put_cache):
13071 Use EMACS_INT, not int, for length.
13072
b13a45c6
PE
13073 * composite.h (COMPOSITION_DECODE_REFS): New macro,
13074 breaking out part of COMPOSITION_DECODE_RULE.
13075 (COMPOSITION_DECODE_RULE): Use it.
13076 * composite.c (get_composition_id): Remove unused local vars,
13077 by using the new macro.
13078
1e792e4d
PE
13079 * textprop.c (set_text_properties_1): Change while to do-while,
13080 since the condition is always true at first.
13081
dc6c6455 13082 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
13083 (interval_deletion_adjustment): Return unsigned value.
13084 All uses changed.
dc6c6455 13085
aba7731a
PE
13086 * process.c (list_processes_1, create_pty, read_process_output):
13087 (exec_sentinel): Remove vars that were set but not used.
afd4052b 13088 (create_pty): Remove unnecessary "volatile"s.
bc57d757 13089 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 13090 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 13091 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 13092
fdfc4bf3
PE
13093 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
13094
fca8fe46 13095 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 13096 (update_syntax_table): Use unsigned instead of int.
fca8fe46 13097
06a0259a 13098 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 13099 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 13100 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 13101
e7b9e80f
PE
13102 * print.c (print_error_message): Avoid int overflow.
13103
56201685
PE
13104 * font.c (font_list_entities): Redo for clarity,
13105 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
13106
78834453 13107 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 13108 (font_score): Avoid potential overflow in diff calculation.
78834453 13109
0bc0b309 13110 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 13111 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 13112
e610eaca
PE
13113 * eval.c (funcall_lambda): Rename local to avoid shadowing.
13114
b895abce
PE
13115 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
13116 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
13117 can always succeed if overflow has undefined behavior.
13118
1f1d9321 13119 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 13120 (wordify): Omit three unnecessary tests.
1f1d9321 13121
c59478bc
PE
13122 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
13123 All callers changed. This avoids the need for an unused var.
13124
79b73827
PE
13125 * casefiddle.c (casify_region): Remove var that is set but not used.
13126
a4db5dfe
PE
13127 * dired.c (file_name_completion): Remove var that is set but not used.
13128
43aae36e
PE
13129 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
13130
2a47c44d 13131 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 13132 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 13133
a37c69bf
PE
13134 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
13135 Check for integer overflow on size calculations.
13136
328ab8e7
PE
13137 * buffer.c (Fprevious_overlay_change): Remove var that is set
13138 but not used.
13139
e5a2a5cb
PE
13140 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
13141 Remove vars that are set but not used.
8d84a6eb 13142 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 13143 (timer_check_2): Mark vars as initialized.
e5a2a5cb 13144
a60e5f68
PE
13145 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
13146
f661cb61 13147 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 13148 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 13149
f0397f5a
PE
13150 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
13151 that are set but not used.
13152
8664db06 13153 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 13154 if XCreateBitmapFromData fails (Bug#8410).
8664db06 13155
6abdaa4a
PE
13156 * xselect.c (x_get_local_selection, x_handle_property_notify):
13157 Remove vars that are set but not used.
13158
0ce7538d 13159 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 13160 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 13161
9ae848fc
PE
13162 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
13163 Remove var that is set but not used.
0b918413
PE
13164 (scroll_bar_windows_size): Now size_t, not int.
13165 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
13166 Check for overflow.
9ae848fc 13167
a5a62657
PE
13168 * xfaces.c (realize_named_face): Remove vars that are set but not used.
13169 (map_tty_color) [!defined MSDOS]: Likewise.
13170
5c5cdd39
PE
13171 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
13172
66ebf983
PE
13173 * coding.c: Remove vars that are set but not used.
13174 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
13175 All callers changed.
13176 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
13177 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
13178 (decode_coding_charset): Remove vars that are set but not used.
13179
1be4d761
PE
13180 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
13181 that is set but not used.
13182
47553fa8
PE
13183 * print.c (print_object): Remove var that is set but not used.
13184
1f7196bf 13185 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
13186 The gnulib version avoids calling malloc in the usual case,
13187 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
13188 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
13189 * filelock.c (current_lock_owner): Likewise.
13190 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
13191 * sysdep.c: Include allocator.h, careadlinkat.h.
13192 (emacs_no_realloc_allocator): New static constant.
13193 (emacs_readlink): New function.
fdb61804
PE
13194 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
13195 ../lib/careadlinkat.h.
d1fdcab7 13196
f84c17c7
SM
131972011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
13198
13199 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
13200 first non-nil return value).
13201
ef3862ad
JD
132022011-04-03 Jan Djärv <jan.h.d@swipnet.se>
13203
13204 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
13205 if not defined (Bug#8403).
13206
376a7006
JB
132072011-04-02 Juanma Barranquero <lekktu@gmail.com>
13208
13209 * xdisp.c (display_count_lines): Remove parameter `start',
13210 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13211 (get_char_face_and_encoding): Remove parameter `multibyte_p',
13212 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13213 (fill_stretch_glyph_string): Remove parameters `row' and `area',
13214 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
13215 and thereabouts. All callers changed.
13216 (get_per_char_metric): Remove parameter `f', unused since
13217 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
13218
6ca3801d
JM
132192011-04-02 Jim Meyering <meyering@redhat.com>
13220
13221 do not dereference NULL upon failed strdup
13222 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
13223 (ns_get_family): Likewise.
13224
d8e2b5ba
JB
132252011-04-02 Juanma Barranquero <lekktu@gmail.com>
13226
13227 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
13228
8c74fcbd
JD
132292011-04-02 Jan Djärv <jan.h.d@swipnet.se>
13230
13231 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
13232 later (Bug#8403).
13233
7200d79c
SM
132342011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
13235
03408648 13236 Add lexical binding.
7200d79c 13237
03408648
SM
13238 * window.c (Ftemp_output_buffer_show): New fun.
13239 (Fsave_window_excursion):
13240 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
13241
13242 * lread.c (lisp_file_lexically_bound_p): New function.
13243 (Fload): Bind Qlexical_binding.
13244 (readevalloop): Remove `evalfun' arg.
13245 Bind Qinternal_interpreter_environment.
13246 (Feval_buffer): Bind Qlexical_binding.
13247 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
13248 Mark as dynamic.
13249 (syms_of_lread): Declare `lexical-binding'.
13250
13251 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
13252
13253 * keyboard.c (eval_dyn): New fun.
13254 (menu_item_eval_property): Use it.
ca105506
SM
13255
13256 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 13257
03408648
SM
13258 * fns.c (concat, mapcar1): Accept byte-code-functions.
13259
13260 * eval.c (Fsetq): Handle lexical vars.
13261 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
13262 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
13263 (FletX, Flet): Obey lexical binding.
13264 (Fcommandp): Handle closures.
13265 (Feval): New `lexical' arg.
13266 (eval_sub): New function extracted from Feval. Use it almost
13267 everywhere where Feval was used. Look up vars in lexical env.
13268 Handle closures.
13269 (Ffunctionp): Move from subr.el.
13270 (Ffuncall): Handle closures.
13271 (apply_lambda): Remove `eval_flags'.
13272 (funcall_lambda): Handle closures and new byte-code-functions.
13273 (Fspecial_variable_p): New function.
13274 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
13275 but without exporting it to Lisp.
23aba0ea 13276
23aba0ea 13277 * doc.c (Fdocumentation, store_function_docstring):
03408648 13278 * data.c (Finteractive_form): Handle closures.
23aba0ea 13279
03408648
SM
13280 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
13281 interactive spec.
ba83908c 13282
04f2d78b
CB
13283 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
13284 New byte-codes.
03408648
SM
13285 (exec_byte_code): New function extracted from Fbyte_code to handle new
13286 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 13287
03408648 13288 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 13289
03408648 13290 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 13291
e2abce01
JB
132922011-03-31 Juanma Barranquero <lekktu@gmail.com>
13293
13294 * xdisp.c (redisplay_internal): Fix prototype.
13295
63696a73 132962011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 13297
63696a73 13298 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
13299 (try_scrolling): Use it when setting scroll_limit.
13300 Limit scrolling to 100 screen lines.
63696a73
EZ
13301 (redisplay_window): Even when falling back on "recentering",
13302 position point in the window according to scroll-conservatively,
13303 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
13304
13305 (try_scrolling): When point is above the window, allow searching
13306 as far as scroll_max, or one screenful, to compute vertical
13307 distance from PT to the scroll margin position. This prevents
13308 try_scrolling from unnecessarily failing when
13309 scroll-conservatively is set to a value slightly larger than the
13310 window height. Clean up the case of PT below the margin at bottom
13311 of window: scroll_max can no longer be INT_MAX. When aggressive
13312 scrolling is in use, don't let point enter the opposite scroll
13313 margin as result of the scroll.
13314 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
13315 threshold of 100 lines for never-recentering scrolling.
13316
e4cc2dfc
JB
133172011-03-31 Juanma Barranquero <lekktu@gmail.com>
13318
13319 * dispextern.h (move_it_by_lines):
13320 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
13321 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
13322 (message_log_check_duplicate): Remove parameters `prev_bol' and
13323 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
13324 (redisplay_internal): Remove parameter `preserve_echo_area',
13325 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
13326
13327 * indent.c (Fvertical_motion):
13328 * window.c (window_scroll_pixel_based, Frecenter):
13329 Don't pass `need_y_p' to `move_it_by_lines'.
13330
1c470562
SM
133312011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
13332
44f230aa
SM
13333 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
13334 steal a few bits to be more compact.
13335 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
13336 Remove unneeded casts.
13337
1c470562
SM
13338 * bytecode.c (Fbyte_code): CAR and CDR can GC.
13339
888adce9
ZK
133402011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
13341
13342 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
13343 binding" message (bug#7967).
13344
f838ed7b
PE
133452011-03-30 Paul Eggert <eggert@cs.ucla.edu>
13346
77861b95
PE
13347 Fix more problems found by GCC 4.6.0's static checks.
13348
de6dbc14
PE
13349 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
13350 Remove unused local var.
13351
f838ed7b
PE
13352 * editfns.c (Fmessage_box): Remove unused local var.
13353
792c7b2b
PE
13354 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
13355 (note_mode_line_or_margin_highlight, note_mouse_highlight):
13356 Omit unused local vars.
c499e557 13357 * window.c (shrink_windows): Omit unused local var.
b01a1c29 13358 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
13359 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
13360 Omit unused local var.
13361
ba0165e1
PE
13362 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
13363 Don't assume string length fits in int.
32ad8845 13364 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 13365 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 13366
3c59b4c9
PE
13367 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
13368 instead of alloca (Bug#8344).
13369
a3eed478 13370 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 13371 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 13372
eb4d412d
PE
13373 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
13374
1658b401
PE
13375 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
13376 concerns.
13377
13378 * term.c (produce_glyphless_glyph): Remove unnecessary test.
13379
13380 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 13381
9a2c6e05
PE
13382 * keyboard.c (syms_of_keyboard): Use the same style as later
13383 in this function when indexing through an array. This also
13384 works around GCC bug 48267.
13385
03d0a109
PE
13386 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
13387
44f730c8
PE
13388 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
13389
fe75f926
PE
13390 * chartab.c (sub_char_table_ref_and_range): Redo for slight
13391 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
13392
ffa8c828
PE
13393 * keyboard.c, keyboard.h (num_input_events): Now size_t.
13394 This avoids undefined behavior on integer overflow, and is a bit
13395 more convenient anyway since it is compared to a size_t variable.
13396
c5101a77
PE
13397 Variadic C functions now count arguments with size_t, not int.
13398 This avoids an unnecessary limitation on 64-bit machines, which
13399 caused (substring ...) to crash on large vectors (Bug#8344).
13400 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
13401 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 13402 All variadic functions and their callers changed accordingly.
c5101a77
PE
13403 (struct gcpro.nvars): Now size_t, not int. All uses changed.
13404 * data.c (arith_driver, float_arith_driver): Likewise.
13405 * editfns.c (general_insert_function): Likewise.
13406 * eval.c (struct backtrace.nargs, interactive_p)
13407 (internal_condition_case_n, run_hook_with_args, apply_lambda)
13408 (funcall_lambda, mark_backtrace): Likewise.
13409 * fns.c (concat): Likewise.
13410 * frame.c (x_set_frame_parameters): Likewise.
13411 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
13412 0 if not found, not -1. All callers changed.
13413
dd3f25f7
PE
13414 * alloc.c (garbage_collect): Don't assume stack size fits in int.
13415 (stack_copy_size): Now size_t, not int.
13416 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
13417
461c2ab9
JB
134182011-03-28 Juanma Barranquero <lekktu@gmail.com>
13419
13420 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
13421 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13422 All callers changed.
13423
13424 * lisp.h (multibyte_char_to_unibyte):
13425 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
13426 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
13427 * character.h (CHAR_TO_BYTE8):
13428 * cmds.c (internal_self_insert):
13429 * editfns.c (general_insert_function):
13430 * keymap.c (push_key_description):
13431 * search.c (Freplace_match):
13432 * xdisp.c (message_dolog, set_message_1): All callers changed.
13433
f6d62986
SM
134342011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
13435
13436 * keyboard.c (safe_run_hook_funcall): New function.
13437 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
13438 don't set the hook to nil, but remove the offending function instead.
13439 (Qcommand_hook_internal): Remove, unused.
13440 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
13441 Vcommand_hook_internal.
13442
13443 * eval.c (enum run_hooks_condition): Remove.
13444 (funcall_nil, funcall_not): New functions.
13445 (run_hook_with_args): Call each function through a `funcall' argument.
13446 Remove `cond' argument, now redundant.
13447 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
13448 (Frun_hook_with_args_until_failure): Adjust accordingly.
13449 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
13450
1db5b1ad
JB
134512011-03-28 Juanma Barranquero <lekktu@gmail.com>
13452
13453 * dispextern.h (string_buffer_position): Remove declaration.
13454
13455 * print.c (strout): Remove parameter `multibyte', unused since
13456 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
13457
13458 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
13459 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
13460 All callers changed.
13461
13462 * w32.c (_wsa_errlist): Use braces for struct initializers.
13463
13464 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
13465 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
13466 All callers changed.
13467 (string_buffer_position): Likewise. Also, make static (it's never
13468 used outside xdisp.c).
13469 (cursor_row_p): Remove parameter `w', unused since
13470 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
13471 (decode_mode_spec): Remove parameter `precision', introduced during
13472 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
13473 All callers changed.
13474
5ffb62aa
JD
134752011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13476
13477 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
13478
461c2ab9 134792011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
13480
13481 * nsterm.m (ns_menu_bar_is_hidden): New variable.
13482 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
13483 (ns_update_auto_hide_menu_bar): New functions.
13484 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
13485 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
13486 ns_constrain_all_frames.
13487 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
13488 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
13489
5c380ffb
JD
134902011-03-27 Jan Djärv <jan.h.d@swipnet.se>
13491
13492 * nsmenu.m (runDialogAt): Remove argument to timer_check.
13493
9af30bdf
GM
134942011-03-27 Glenn Morris <rgm@gnu.org>
13495
13496 * syssignal.h: Replace RETSIGTYPE with void.
13497 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
13498 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
13499 Replace SIGTYPE with void everywhere.
13500 * s/usg5-4-common.h (SIGTYPE): Remove definition.
13501 * s/template.h (SIGTYPE): Remove commented out definition.
13502
e2abce01
JB
135032011-03-26 Eli Zaretskii <eliz@gnu.org>
13504
13505 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
13506 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
13507
f868cd8a
JB
135082011-03-26 Juanma Barranquero <lekktu@gmail.com>
13509
59eb0929
JB
13510 * w32.c (read_unc_volume): Use parameter `henum', instead of
13511 global variable `wget_enum_handle'.
13512
13513 * keymap.c (describe_vector): Remove parameters `indices' and
13514 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
13515 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
13516
f868cd8a
JB
13517 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
13518
13519 * keyboard.c (timer_check): Remove parameter `do_it_now',
13520 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
13521 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
13522 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
13523
13524 * keyboard.c (read_char):
13525 * w32menu.c (w32_menu_display_help):
13526 * xmenu.c (show_help_event, menu_help_callback):
13527 Adjust calls to `show_help_echo'.
13528
13529 * gtkutil.c (xg_maybe_add_timer):
13530 * keyboard.c (readable_events):
13531 * process.c (wait_reading_process_output):
13532 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
13533
13534 * insdel.c (adjust_markers_gap_motion):
13535 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
13536 (gap_left, gap_right): Don't call it.
13537
2ecf6fdb
CY
135382011-03-25 Chong Yidong <cyd@stupidchicken.com>
13539
13540 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
13541 incurred during fontification.
13542
6b1f9ba4
JB
135432011-03-25 Juanma Barranquero <lekktu@gmail.com>
13544
13545 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
13546 (DEFVAR_PER_BUFFER): Don't pass it.
13547
13548 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
13549 (scrolling_window): Don't pass it.
13550
0f4a96b5
JB
135512011-03-25 Juanma Barranquero <lekktu@gmail.com>
13552
13553 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
13554
13555 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
13556 and `suffix'.
13557 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
13558 of variables specific to SELinux and computation of `encoded_absname'.
13559
13560 * image.c (XPutPixel): Remove unused variable `height'.
13561
13562 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
13563
13564 * unexw32.c (get_section_info): Remove unused variable `section'.
13565
13566 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
13567 (system_process_attributes): Remove unused variable `sess'.
13568 (sys_read): Remove unused variable `err'.
13569
13570 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
13571 (w32_wnd_proc): Remove unused variable `isdead'.
13572 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
13573 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
13574 (x_create_tip_frame): Remove unused variable `tem'.
13575
13576 * w32inevt.c (w32_console_read_socket):
13577 Remove unused variable `no_events'.
13578
13579 * w32term.c (x_draw_composite_glyph_string_foreground):
13580 Remove unused variable `width'.
13581
1149507c
JB
135822011-03-24 Juanma Barranquero <lekktu@gmail.com>
13583
13584 * w32term.c (x_set_glyph_string_clipping):
13585 Don't pass uninitialized region to CombineRgn.
13586
9c88f339
JB
135872011-03-23 Juanma Barranquero <lekktu@gmail.com>
13588
13589 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
13590 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
13591 (Fx_close_connection): Remove unused variable `i'.
13592
13593 * w32font.c (w32font_draw): Return number of glyphs.
13594 (w32font_open_internal): Remove unused variable `i'.
13595 (w32font_driver): Add missing initializer.
13596
13597 * w32menu.c (utf8to16): Remove unused variable `utf16'.
13598 (fill_in_menu): Remove unused variable `items_added'.
13599
13600 * w32term.c (last_mouse_press_frame): Remove static global variable.
13601 (w32_clip_to_row): Remove unused variable `f'.
13602 (x_delete_terminal): Remove unused variable `i'.
13603
13604 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
13605 (NOTHING): Remove unused static global variable.
13606 (uniscribe_check_otf): Remove unused variable `table'.
13607 (uniscribe_font_driver): Add missing initializers.
13608
dee091a3
JD
136092011-03-23 Julien Danjou <julien@danjou.info>
13610
13611 * term.c (Fsuspend_tty, Fresume_tty):
13612 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
13613 * window.c (temp_output_buffer_show):
13614 * insdel.c (signal_before_change):
13615 * frame.c (Fhandle_switch_frame):
13616 * fileio.c (Fdo_auto_save):
13617 * emacs.c (Fkill_emacs):
13618 * editfns.c (save_excursion_restore):
13619 * cmds.c (internal_self_insert):
13620 * callint.c (Fcall_interactively):
13621 * buffer.c (Fkill_all_local_variables):
13622 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
13623 Use Frun_hooks.
0f4a96b5 13624 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 13625 unconditionally since it does the check itself.
dee091a3 13626
2c520ab5 136272011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 13628
c9c49752
PE
13629 Fix more problems found by GCC 4.5.2's static checks.
13630
8abc3f12
PE
13631 * coding.c (encode_coding_raw_text): Avoid unnecessary test
13632 the first time through the loop, since we know p0 < p1 then.
13633 This also avoids a gcc -Wstrict-overflow warning.
13634
a2d26660
PE
13635 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
13636 leading to a memory leak, possible in functions like
13637 load_charset_map_from_file that can allocate an unbounded number
b12ef411 13638 of objects (Bug#8318).
a2d26660 13639
916c72e9
PE
13640 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
13641 that could (at least in theory) be that large.
13642
19ab8a18
PE
13643 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
13644 This is less likely to overflow, and avoids undefined behavior if
13645 overflow does occur. All callers changed. Use strtoul to scan
13646 for the unsigned long integer.
b7cbbd6f
PE
13647 (pint2hrstr): Simplify and tune code slightly.
13648 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 13649
f0641eff
PE
13650 * scroll.c (do_scrolling): Work around GCC bug 48228.
13651 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
13652
7f650bb9
PE
13653 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
13654 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
13655 (validate_x_resource_name): Simplify count usage.
13656 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 13657
37dd57d1
PE
13658 * fileio.c (Fcopy_file): Report error if fchown or fchmod
13659 fail (Bug#8306).
81e56e61 13660
699979fc 13661 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 13662
401bf9b4
PE
13663 * process.c (Fmake_network_process): Use socklen_t, not int,
13664 where POSIX says socklen_t is required in portable programs.
13665 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 13666 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
13667 (Fmake_network_process, server_accept_connection):
13668 (wait_reading_process_output, read_process_output):
13669 Likewise.
13670
b93aacde
PE
13671 * process.c: Rename or move locals to avoid shadowing.
13672 (list_processes_1, Fmake_network_process):
13673 (read_process_output_error_handler, exec_sentinel_error_handler):
13674 Rename or move locals.
4dc343ee 13675 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 13676 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 13677 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 13678 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 13679 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 13680
af8a867c 13681 Make tparam.h and terminfo.c consistent.
44f230aa
SM
13682 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
13683 Include tparam.h instead, since it declares them.
af8a867c
PE
13684 * cm.h (PC): Remove extern decl; tparam.h now does this.
13685 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
13686 * terminfo.c: Include tparam.h, to check interfaces.
13687 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
13688 (tparam): Adjust signature to match interface in tparam.h;
13689 this removes some undefined behavior. Check that outstring and len
13690 are zero, which they always are with Emacs.
13691 * tparam.h (PC, BC, UP): New extern decls.
13692
0248044d 13693 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 13694 (xftfont_open): Rename locals to avoid shadowing.
0248044d 13695
8ff096c1 13696 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
13697 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
13698 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 13699 (ftfont_list): Remove unused local.
49eaafba
PE
13700 (get_adstyle_property, ftfont_pattern_entity):
13701 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
13702 Rename locals to avoid shadowing.
8ff096c1 13703
e2be39f6
PE
13704 * xfont.c (xfont_list_family): Mark var as initialized.
13705
c9735e30
PE
13706 * xml.c (make_dom): Now static.
13707
8f5201ae
PE
13708 * composite.c (composition_compute_stop_pos): Rename local to
13709 avoid shadowing.
b246f932
PE
13710 (composition_reseat_it): Remove unused locals.
13711 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 13712 (composition_update_it): Mark var as initialized.
11b61122
PE
13713 (find_automatic_composition): Mark vars as initialized,
13714 with a FIXME (Bug#8290).
8f5201ae 13715
760fbc2c
PE
13716 character.h: Rename locals to avoid shadowing.
13717 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
13718 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
13719 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
13720 (BUF_DEC_POS): Be more systematic about renaming local temporaries
13721 to avoid shadowing.
13722
ff08eb85
PE
13723 * textprop.c (property_change_between_p): Remove; unused.
13724
fc7bf025
PE
13725 * intervals.c (interval_start_pos): Now static.
13726
235d7abc
PE
13727 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
13728
44f230aa
SM
13729 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
13730 Rename locals to avoid shadowing.
3e7d6594 13731
50060332
PE
13732 * sound.c (wav_play, au_play, Fplay_sound_internal):
13733 Fix pointer signedness.
d01f234b 13734 (alsa_choose_format): Remove unused local var.
c83b8872
PE
13735 (wav_play): Initialize a variable to 0, to prevent undefined
13736 behavior (Bug#8278).
50060332 13737
c4fc4e30
PE
13738 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
13739
918436ed
PE
13740 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
13741
c939f91b
PE
13742 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
13743 clobbering (Bug#8298).
b9c7f648
PE
13744 * sysdep.c (sys_subshell): Likewise.
13745 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 13746
6bd8c144
PE
13747 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
13748 This should get cleaned up, so that child_setup has the
13749 same signature on all platforms.
13750
7710357c 13751 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 13752 (relocate_fd): Rename locals to avoid shadowing.
7710357c 13753
c59da222
CY
137542011-03-22 Chong Yidong <cyd@stupidchicken.com>
13755
13756 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
13757 not to be necessary, and produces flickering.
13758
66b87493
GM
137592011-03-20 Glenn Morris <rgm@gnu.org>
13760
13761 * config.in: Remove file.
13762
45b6f6d5
JB
137632011-03-20 Juanma Barranquero <lekktu@gmail.com>
13764
13765 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
13766 are now in src/globals.h.
13767 (syms_of_minibuf): Remove spurious & from previous change.
13768
cd394be1 137692011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
13770
13771 * minibuf.c (completing-read-function): New variable.
13772 (completing-read-default): Rename from completing-read.
13773 (completing-read): Call completing-read-function.
13774
b14e3e21
CY
137752011-03-19 Juanma Barranquero <lekktu@gmail.com>
13776
13777 * xfaces.c (Fx_load_color_file):
13778 Read color file from absolute filename (bug#8250).
13779
f2b726e6
JB
137802011-03-19 Juanma Barranquero <lekktu@gmail.com>
13781
13782 * makefile.w32-in: Update dependencies.
13783
09f6ff02
EZ
137842011-03-17 Eli Zaretskii <eliz@gnu.org>
13785
13786 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
13787
29a6015a
PE
137882011-03-17 Paul Eggert <eggert@cs.ucla.edu>
13789
a3a6c54e
PE
13790 Fix more problems found by GCC 4.5.2's static checks.
13791
b766f867
PE
13792 * process.c (make_serial_process_unwind, send_process_trap):
13793 (sigchld_handler): Now static.
13794
be02381c
PE
13795 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
13796 That way, the code declares only the vars that it needs.
13797 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
13798 * s/cygwin.h (PTY_ITERATION): Likewise.
13799 * s/darwin.h (PTY_ITERATION): Likewise.
13800 * s/gnu-linux.h (PTY_ITERATION): Likewise.
13801
57048744
PE
13802 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
13803 * process.c (allocate_pty): Don't declare stb unless it's needed.
13804
7914961c 13805 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
13806 (CONSTANTLIM): Remove; unused.
13807 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
13808 Define only if needed.
7914961c 13809
b3967b18
PE
13810 * unexelf.c (unexec): Name an expression,
13811 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
13812 Use a different way to cause a compilation error if anyone uses
13813 n rather than nn, a way that does not involve shadowing.
73366a00 13814 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 13815
29a6015a
PE
13816 * deps.mk (unexalpha.o): Remove; unused.
13817
43cfc33e 13818 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 13819 * unexec.h: New file.
ce701a33
PE
13820 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
13821 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
13822 Depend on unexec.h.
13823 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
13824 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
13825 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 13826 Change as necessary to match prototype in unexec.h.
ce701a33 13827
01f44d5a
PE
13828 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
13829 shadowing.
4f63c6bb 13830 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 13831
a6670b0b
PE
13832 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
13833 Rename locals to avoid shadowing.
13834
cef2010d 13835 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 13836 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 13837
d4d7173a
PE
13838 * print.c (Fredirect_debugging_output): Fix pointer signedess.
13839
f08b802a
PE
13840 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
13841 warning when compiling print.c.
13842
3ddb0639
PE
13843 * font.c (font_unparse_fcname): Abort in an "impossible" situation
13844 instead of using an uninitialized var.
5ad03b97 13845 (font_sort_entities): Mark var as initialized.
3ddb0639 13846
170a2692
PE
13847 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
13848
e663c700
PE
13849 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
13850 pointers to constants.
89bc529a 13851 (font_parse_fcname): Remove unused vars.
7b81e2d0 13852 (font_delete_unmatched): Now static.
ea838e10 13853 (font_get_spec): Remove; unused.
13a547c6
PE
13854 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
13855 (font_update_drivers, Ffont_get_glyphs, font_add_log):
13856 Rename or move locals to avoid shadowing.
e663c700 13857
2a80c887 13858 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 13859 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 13860
1384fa33 13861 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 13862 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 13863
8b2c52e9
PE
13864 * alloc.c (mark_backtrace): Move decl from here ...
13865 * lisp.h: ... to here, so that it can be checked.
13866
475545b5 13867 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 13868 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
13869 (lisp_indirect_variable): Name an expression,
13870 to avoid gcc -Wbad-function-cast warning.
1faed8ae 13871 (Fdefvar): Rename locals to avoid shadowing.
475545b5 13872
b1349114 13873 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 13874 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 13875 Use const pointer when appropriate.
b1349114 13876
a2928364
PE
13877 * lisp.h (get_system_name, get_operating_system_release):
13878 Move decls here, to check interfaces.
13879 * process.c (get_operating_system_release): Move decl to lisp.h.
13880 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
13881 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
13882 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
13883 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
13884 (Fformat_time_string, Fencode_time, Finsert_char):
13885 (Ftranslate_region_internal, Fformat):
13886 Rename or remove local vars to avoid shadowing.
9710023e 13887 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 13888
a415e694
PE
13889 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
13890 avoid shadowing.
13891
8ef4622d
PE
13892 * lisp.h (eassert): Check that the argument compiles, even if
13893 ENABLE_CHECKING is not defined.
13894
946f9a5b
PE
13895 * data.c (Findirect_variable): Name an expression, to avoid
13896 gcc -Wbad-function-cast warning.
112396d6 13897 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 13898 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
13899 (Fmake_variable_buffer_local, Fmake_local_variable):
13900 Mark variables as initialized.
52746918 13901 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 13902
e5aab7e7 13903 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
13904 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
13905 Rename locals to avoid shadowing.
dff45157
PE
13906 (mark_stack): Move local variables into the #ifdef region where
13907 they're used.
7bc26fdb
PE
13908 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
13909 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
13910 needed otherwise.
13911 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
13912 (GC_STRING_CHARS): Remove; not used.
d40d4be1 13913 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 13914
e5aab7e7
PE
13915 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
13916 avoids undefined behavior in theory.
13917
4da60324
PE
13918 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
13919
88043301
PE
13920 Use functions, not macros, for up- and down-casing (Bug#8254).
13921 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13922 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
13923 to use the following functions instead of these macros.
13924 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
13925 EMACS_INT, since callers assume the returned value fits in int.
13926 (upcase1): Likewise, for UPCASE_TABLE.
13927 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 13928 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 13929 the race-condition problem in the old DOWNCASE.
88043301 13930
19ed5445
PE
13931 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
13932 Rename locals to avoid shadowing.
13933 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
13934 (regex_compile, re_search_2, re_match_2_internal):
13935 Remove unused local vars.
952db0d7
PE
13936 (FREE_VAR): Rewrite so as not to use empty "else",
13937 which gcc can warn about.
da053e48 13938 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
13939 (RETALLOC_IF): Define only if needed.
13940 (WORDCHAR_P): Likewise. This one is never needed, but is used
13941 only in a comment talking about a compiler bug, so put inside
13942 the #if 0 of that comment.
13943 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
13944 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
13945 Remove; unused.
19ed5445 13946
1f3561e4 13947 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
13948 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
13949 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 13950
ded6f8f7
PE
13951 * search.c (simple_search): Remove unused var.
13952
dbd37a95
PE
13953 * dired.c (compile_pattern): Move decl from here ...
13954 * lisp.h: ... to here, so that it can be checked.
13955 (struct re_registers): New forward decl.
13956
7e47afad
PE
13957 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
13958
85f24f61
PE
13959 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
13960 All uses changed.
13961 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
13962 Rename locals to avoid shadowing.
5671df8f 13963 (Fvertical_motion): Mark locals as initialized.
85f24f61 13964
181aa2be 13965 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 13966 (casify_region): Mark local as initialized.
181aa2be 13967
930d429c
PE
13968 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
13969
7082eac6
PE
13970 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
13971 New macros, so that the caller can use some names other than
13972 gcpro1, gcpro2, etc.
13973 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
13974 of the new macros.
13975 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
13976 argument, for consistency with GCPRO2_VAR, etc: it is now the
13977 prefix of the variable, not the variable itself. All uses
13978 changed.
38b2c076
PE
13979 * dired.c (directory_files_internal, file_name_completion):
13980 Rename locals to avoid shadowing.
13981
15206ed9
PE
13982 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
13983 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
13984 dired.c's scmp function, had undefined behavior.
13985 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
13986 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
13987 * buffer.h: ... to here, because these macros use current_buffer,
13988 and the new implementation with inline functions needs to have
13989 current_buffer in scope now, rather than later when the macros
13990 are used.
13991 (downcase, upcase1): New static inline functions.
13992 (DOWNCASE, UPCASE1): Reimplement using these functions.
13993 This avoids undefined behavior in expressions like
13994 DOWNCASE (x) == DOWNCASE (y), which previously suffered
13995 from race conditions in accessing the global variables
13996 case_temp1 and case_temp2.
13997 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
13998 * lisp.h (case_temp1, case_temp2): Remove their decls.
13999 * character.h (ASCII_CHAR_P): Move from here ...
14000 * lisp.h: ... to here, so that the inline functions mentioned
14001 above can use them.
14002
4a6bea26
PE
14003 * dired.c (directory_files_internal_unwind): Now static.
14004
f14b7e14
PE
14005 * fileio.c (file_name_as_directory, directory_file_name):
14006 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
14007 Now static.
2893f146
PE
14008 (file_name_as_directory): Use const pointers when appropriate.
14009 (Fexpand_file_name): Likewise. In particular, newdir might
14010 point at constant storage, so make it a const pointer.
fd4ead52 14011 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
14012 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
14013 signedness issues.
f839df0c
PE
14014 (Fset_file_times, Finsert_file_contents, auto_save_error):
14015 Rename locals to avoid shadowing.
f14b7e14 14016
5716756e 14017 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
14018 (Ftry_completion, Fall_completions): Rename or remove locals
14019 to avoid shadowing.
5716756e 14020
b4c3046a
PE
14021 * marker.c (bytepos_to_charpos): Remove; unused.
14022
b45db522
PE
14023 * lisp.h (verify_bytepos, count_markers): New decls,
14024 so that gcc does not warn that these functions aren't declared.
14025
85876d07
PE
14026 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
14027 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 14028 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 14029 (copy_text): Remove unused local var.
85876d07 14030
03d78a21 14031 * filelock.c (within_one_second): Now static.
b3dd38ab 14032 (lock_file_1): Rename local to avoid shadowing.
03d78a21 14033
5df8f01b
PE
14034 * buffer.c (fix_overlays_before): Mark locals as initialized.
14035 (fix_start_end_in_overlays): Likewise. This function should be
14036 simplified by using pointers-to-pointers, but that's a different
14037 matter.
b1d876f1 14038 (switch_to_buffer_1): Now static.
8f54f30a
PE
14039 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
14040 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 14041
a70072c9 14042 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 14043 Fix pointer signedness issue.
edced198
PE
14044 (sys_subshell): Mark local as volatile if checking for lint,
14045 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 14046 (MAXPATHLEN): Define only if needed.
a70072c9 14047
a0977c44
PE
14048 * process.c (serial_open, serial_configure): Move decls from here ...
14049 * systty.h: ... to here, so that they can be checked.
14050
a884fdcc
PE
14051 * fns.c (get_random, seed_random): Move extern decls from here ...
14052 * lisp.h: ... to here, so that they can be checked.
14053
604efe86 14054 * sysdep.c (reset_io): Now static.
b8950c94 14055 (wait_for_termination_signal): Remove; unused.
604efe86 14056
38fc62d9
PE
14057 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
14058 (copy_keymap_item, append_key, push_text_char_description):
14059 Now static.
1004a21a 14060 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 14061 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
14062 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
14063 (describe_map_tree):
14064 Rename locals to avoid shadowing.
38fc62d9 14065
2f2650da
PE
14066 * keyboard.c: Declare functions static if they are not used elsewhere.
14067 (echo_char, echo_dash, cmd_error, top_level_2):
14068 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
14069 (read_char, kbd_buffer_get_event, make_lispy_position):
14070 (make_lispy_event, make_lispy_movement, apply_modifiers):
14071 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
14072 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
14073 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 14074 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 14075 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 14076
a053e86c 14077 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
14078 (mark_kboards): Move decl here ...
14079 * alloc.c (mark_kboards): ... from here.
a053e86c 14080
4752793e
PE
14081 * lisp.h (force_auto_save_soon): New decl.
14082
74f10ca7 14083 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
14084 (DEFINE_DUMMY_FUNCTION): New macro.
14085 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
14086 Use it.
c03cd23f
PE
14087 (main): Add casts to avoid warnings
14088 if GCC considers string literals to be constants.
74f10ca7 14089
022e70d4
PE
14090 * lisp.h (fatal_error_signal): Add decl, since it's exported.
14091
59d6fe83
PE
14092 * dbusbind.c: Pointer signedness fixes.
14093 (xd_signature, xd_append_arg, xd_initialize):
14094 (Fdbus_call_method, Fdbus_call_method_asynchronously):
14095 (Fdbus_method_return_internal, Fdbus_method_error_internal):
14096 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
14097 (Fdbus_register_signal): Use SSDATA when the context wants char *.
14098
78320123
PE
14099 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
14100 if GCC considers string literals to be constants.
49cebcca 14101 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 14102
35ac2a97
SM
141032011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
14104
fb103ca9
SM
14105 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
14106 (print_preprocess, print_object): New macro to fix last change.
14107
35ac2a97
SM
14108 * print.c (print_preprocess): Don't forget font objects.
14109
62973b41
JB
141102011-03-16 Juanma Barranquero <lekktu@gmail.com>
14111
14112 * emacs.c (USAGE3): Doc fixes.
14113
0e48bb22
AS
141142011-03-15 Andreas Schwab <schwab@linux-m68k.org>
14115
14116 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
14117 structure.
14118
7684e57b
JB
141192011-03-14 Juanma Barranquero <lekktu@gmail.com>
14120
14121 * lisp.h (VWindow_system, Qfile_name_history):
14122 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
14123 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
14124 (w32_system_caret_x, w32_system_caret_y): Declare extern.
14125
14126 * w32select.c: Don't #include "keyboard.h".
c96bbc66 14127 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
14128
14129 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
14130 * w32console.c (detect_input_pending, read_input_pending)
14131 (encode_terminal_code):
14132 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
14133 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
14134 (w32_system_caret_y, Qfile_name_history):
14135 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
14136 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
14137 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
14138 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
14139 * w32proc.c (Qlocal, report_file_error):
14140 * w32term.c (Vwindow_system, updating_frame):
14141 * w32uniscribe.c (initialized, uniscribe_font_driver):
14142 Remove unneeded extern declarations.
14143
2aa46d6c
CY
141442011-03-14 Chong Yidong <cyd@stupidchicken.com>
14145
c96bbc66 14146 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 14147
cffc6f3b
CY
141482011-03-13 Chong Yidong <cyd@stupidchicken.com>
14149
14150 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
14151 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
14152 These macros can no longer be used for assignment.
14153
44f230aa
SM
14154 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
14155 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
14156 (record_buffer_markers, fetch_buffer_markers): New functions for
14157 recording and fetching special buffer markers.
14158 (set_buffer_internal_1, set_buffer_temp): Use them.
14159
14160 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
14161
14162 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
14163
14164 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
14165 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
14166
14167 * xdisp.c (hscroll_window_tree):
14168 (reconsider_clip_changes): Use PT instead of BUF_PT.
14169
d251f04b
EZ
141702011-03-13 Eli Zaretskii <eliz@gnu.org>
14171
14172 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
14173 $(EMACS_ROOT)/lib/intprops.h.
14174
f0c77cd1
PE
141752011-03-13 Paul Eggert <eggert@cs.ucla.edu>
14176
3eca4629
PE
14177 Fix more problems found by GCC 4.5.2's static checks.
14178
7c86ee98
PE
14179 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
14180 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
14181 (xg_free_frame_widgets): Make it clear that a local variable is
14182 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
14183 (gdk_window_get_screen): Make it clear that this macro is needed
14184 only if USE_GTK_TOOLTIP.
1e5524e7
PE
14185 (int_gtk_range_get_value): New function, which avoids a diagnostic
14186 from gcc -Wbad-function-cast.
14187 (xg_set_toolkit_scroll_bar_thumb): Use it.
14188 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
14189 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
14190 (get_utf8_string, xg_get_file_with_chooser):
14191 Rename locals to avoid shadowing.
14192 (create_dialog): Move locals to avoid shadowing.
7c86ee98 14193
41729b81
PE
14194 * xgselect.c (xg_select): Remove unused var.
14195
f0c77cd1
PE
14196 * image.c (four_corners_best): Mark locals as initialized.
14197 (gif_load): Initialize transparent_p to zero (Bug#8238).
14198 Mark another local as initialized.
ec6cf4c6 14199 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 14200
ce0ad53d 14201 * image.c (clear_image_cache): Now static.
d5d5a617 14202 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 14203 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
14204 (x_edge_detection): Remove unnecessary cast that
14205 gcc -Wbad-function-cast diagnoses.
2037898d 14206 (gif_load): Fix pointer signedness.
6ae141d6
PE
14207 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
14208 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 14209
33383987 142102011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 14211
d32df629
PE
14212 Improve quality of tests for time stamp overflow.
14213 For example, without this patch (encode-time 0 0 0 1 1
14214 1152921504606846976) returns the obviously-bogus value (-948597
14215 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
14216 reports time overflow. See
14217 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
14218 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
14219 * editfns.c: Include limits.h and intprops.h.
14220 (TIME_T_MIN, TIME_T_MAX): New macros.
14221 (time_overflow): Move earlier, to before first use.
14222 (hi_time, lo_time): New functions, for an accurate test for
14223 out-of-range times.
14224 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
14225 (Fget_internal_run_time): Don't assume time_t fits in int.
14226 (make_time): Use list2 instead of Fcons twice.
14227 (Fdecode_time): More accurate test for out-of-range times.
14228 (check_tm_member): New function.
14229 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
14230 (lisp_time_argument): Don't rely on undefined left-shift and
14231 right-shift behavior when checking for time stamp overflow.
8be6f318 14232
fe31d94c
PE
14233 * editfns.c (time_overflow): New function, refactoring common code.
14234 (Fformat_time_string, Fdecode_time, Fencode_time):
14235 (Fcurrent_time_string): Use it.
14236
8be6f318
PE
14237 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
14238 * dired.c (make_time): Move to ...
14239 * editfns.c (make_time): ... here.
14240 * systime.h: Note the move.
14241
09d9db2c 142422011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 14243
126bc0dc
YM
14244 * fringe.c (update_window_fringes): Remove unused variables.
14245
c47cbdfd
YM
14246 * unexmacosx.c (copy_data_segment): Also copy __got section.
14247 (Bug#8223)
14248
7ac80be9
EZ
142492011-03-12 Eli Zaretskii <eliz@gnu.org>
14250
c96bbc66 14251 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
14252 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
14253 Constify `char *' arguments and their references according to
14254 prototypes in tparam.h.
14255
ecb0f94d 14256 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 14257
7ac80be9
EZ
14258 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
14259 Adapt all references accordingly.
14260
14261 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
14262
ef1fd07e
TT
142632011-03-11 Tom Tromey <tromey@redhat.com>
14264
14265 * buffer.c (syms_of_buffer): Remove obsolete comment.
14266
7ef4b50c
EZ
142672011-03-11 Eli Zaretskii <eliz@gnu.org>
14268
14269 * termhooks.h (encode_terminal_code): Declare prototype.
14270
14271 * msdos.c (encode_terminal_code): Don't declare prototype.
14272
14273 * term.c (encode_terminal_code): Now external again, used by
14274 w32console.c and msdos.c.
14275
44f230aa
SM
14276 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
14277 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 14278
4b1ec863 142792011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 14280
1714f52b 14281 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 14282
4b1ec863
PE
14283 * fringe.c (update_window_fringes): Mark locals as initialized
14284 (Bug#8227).
14285 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 14286
524c7aa6
PE
14287 * alloc.c (mark_fringe_data): Move decl from here ...
14288 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
14289 to check its interface.
14290 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
14291
a5c0af81 14292 * fontset.c (free_realized_fontset): Now static.
7519b8cd 14293 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 14294 (fontset_font): Mark local as initialized.
a9a06e0b 14295 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 14296
b4716021
PE
14297 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
14298
811e9bac 14299 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 14300 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
14301 (x_own_selection, Fx_disown_selection_internal): Rename locals
14302 to avoid shadowing.
14303 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 14304
7e3ab302
PE
14305 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
14306 so that the caller can use some name other than gcpro1.
14307 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
14308 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14309 (Fx_backspace_delete_keys_p):
14310 Use them to avoid shadowing, and rename vars to avoid shadowing.
14311 (x_decode_color, x_set_name, x_window): Now static.
6b437900 14312 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 14313 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
14314 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
14315 Remove unused locals.
7e3ab302
PE
14316 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
14317 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
14318 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
14319 macros.
f78faa98 14320
e2b13473
PE
14321 * xterm.h (x_mouse_leave): New decl.
14322
77f23912
PE
14323 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
14324 Remove unused functions.
cdf4ba58
PE
14325 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
14326 (x_calc_absolute_position): Now static.
7411c686 14327 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 14328 Don't declare local "event" unless it's used.
ed7bf3a5
PE
14329 (x_iconify_frame, x_free_frame_resources): Don't declare locals
14330 unless they are used.
38d0b34a
PE
14331 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
14332 (x_fatal_error_signal): Remove; not used.
a6067996
PE
14333 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
14334 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
14335 (x_error_catcher, x_connection_closed, x_error_handler):
14336 (x_error_quitter, xembed_send_message, x_iconify_frame):
14337 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 14338 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 14339 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 14340
44f230aa
SM
14341 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
14342 Rename or move locals to avoid shadowing.
6b463e58 14343 (tty_defined_color, merge_face_heights): Now static.
5967d051 14344 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
14345 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
14346 does not deduce is never used uninitialized.
73719eba
PE
14347 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
14348 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 14349
426994c3 14350 * terminal.c (store_terminal_param): Now static.
5489860b 14351
032f1620 14352 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 14353 (set_frame_menubar): Remove unused local.
d4323972 14354 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
14355 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
14356 since they might point to immutable storage.
281585b0
PE
14357 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
14358 since it's unused otherwise.
032f1620 14359
367c19e5 14360 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 14361 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
14362 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
14363 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 14364 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
14365 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
14366 does not deduce are never used uninitialized.
70739cbe 14367
07b48fa9
PE
14368 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
14369
8868a238 14370 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
14371 * window.c (window_loop, size_window):
14372 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 14373
7e5cf297 14374 * window.c (display_buffer): Now static.
d6550a9f
PE
14375 (size_window): Mark variables that gcc -Wuninitialized
14376 does not deduce are never used uninitialized.
a586633d
PE
14377 * window.h (check_all_windows): New decl, to forestall
14378 gcc -Wmissing-prototypes diagnostic.
5b555da1 14379 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 14380
f6095868
PE
14381 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
14382 shadowing.
14383 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
14384 Include <limits.h>.
14385 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
14386 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
14387 (load_charset_map): Mark variables that gcc -Wuninitialized
14388 does not deduce are never used uninitialized.
53df7c11 14389 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 14390
f38b440c
PE
14391 * coding.c (coding_set_source, coding_set_destination):
14392 Use "else { /* comment */ }" rather than "else /* comment */;"
14393 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
14394 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
14395 a block, when the outer 'i' will do.
14396 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
14397 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
14398 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
14399 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
14400 (Fdecode_sjis_char, Fdefine_coding_system_internal):
14401 Rename locals to avoid shadowing.
14402 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
14403 * coding.c (emacs_mule_char, encode_invocation_designation):
14404 Now static, since they're not used elsewhere.
413bb2db 14405 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 14406 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
14407 (decode_coding_emacs_mule): Mark variables that gcc
14408 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
14409 (detect_coding_iso_2022): Initialize a local variable that might
14410 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 14411 this initialization is needed. (Bug#8211)
5f58e762
PE
14412 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
14413 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
14414 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
14415 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
14416 Remove unused macros.
f38b440c 14417
232b38b9 14418 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 14419 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 14420 * character.c (string_count_byte8): Likewise.
232b38b9 14421
fb90da1b
PE
14422 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
14423 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
14424
fb93dbc2
PE
14425 * chartab.c (copy_sub_char_table): Now static, since it's not used
14426 elsewhere.
5c156ace
PE
14427 (sub_char_table_ref_and_range, char_table_ref_and_range):
14428 Rename locals to avoid shadowing.
bbcd0949 14429 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 14430
7d3b3862 14431 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 14432 (BIDI_BOB): Remove unused macro.
7d3b3862 14433
6be7d3da
PE
14434 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
14435 deduce are never used uninitialized.
c2ed9c8b 14436 * term.c (encode_terminal_code): Likewise.
6be7d3da 14437
75f8807f 14438 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 14439
50938595
PE
14440 * tparam.h: New file.
14441 * term.c, tparam.h: Include it.
14442 * deps.mk (term.o, tparam.o): Depend on tparam.h.
14443 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
14444 Move these decls to tparam.h, and make them agree with what
14445 is actually in tparam.c. The previous trick of using incompatible
14446 decls in different modules does not conform to the C standard.
14447 All callers of tparam changed to use tparam's actual API.
14448 * tparam.c (tparam1, tparam, tgoto):
14449 Use const pointers where appropriate.
14450
fbceeba2
PE
14451 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
14452 * cm.h (struct cm): Likewise.
14453 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
14454 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
14455 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
14456 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
14457 (turn_on_face, init_tty): Likewise.
14458 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 14459
7f3f1250
PE
14460 * term.c (term_mouse_position): Rename local to avoid shadowing.
14461
e6ca6543
PE
14462 * alloc.c (mark_ttys): Move decl from here ...
14463 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
14464
c40f8d15
AS
144652011-03-11 Andreas Schwab <schwab@linux-m68k.org>
14466
14467 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
14468
cfe0661d
JB
144692011-03-09 Juanma Barranquero <lekktu@gmail.com>
14470
14471 * search.c (compile_pattern_1): Remove argument regp, unused since
14472 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
14473 (compile_pattern): Don't pass it.
14474
0afb4571
J
144752011-03-08 Jan Djärv <jan.h.d@swipnet.se>
14476
14477 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
14478 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
14479 for ! HAVE_GTK3.
14480 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
14481
14482 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
14483
14484 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
14485 gdk_window_get_screen, gdk_window_get_geometry,
14486 gdk_x11_window_lookup_for_display and GDK_KEY_g.
14487 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
14488 (xg_get_pixbuf_from_pixmap): New function.
14489 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
14490 to Pixmap, take frame as parameter, remove GdkColormap parameter.
14491 Call xg_get_pixbuf_from_pixmap instead of
14492 gdk_pixbuf_get_from_drawable.
14493 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
14494 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
14495 (xg_check_special_colors): Use GtkStyleContext and its functions
14496 for HAVE_GTK3.
14497 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
14498 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
14499 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
14500 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
14501 Call gtk_widget_get_preferred_size.
0afb4571
J
14502 (xg_frame_resized): gdk_window_get_geometry only takes 5
14503 parameters.
44f230aa
SM
14504 (xg_win_to_widget, xg_event_is_for_menubar):
14505 Call gdk_x11_window_lookup_for_display.
0afb4571
J
14506 (xg_set_widget_bg): New function.
14507 (delete_cb): New function.
895009e1 14508 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 14509 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
14510 (xg_set_background_color): Call xg_set_widget_bg.
14511 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
14512 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
14513 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
14514 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
14515 if ! HAVE_GTK3.
14516 (update_frame_tool_bar): Call gtk_widget_hide.
14517 (xg_initialize): Use GDK_KEY_g.
14518
14519 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
14520 if ! HAVE_GTK3
14521 (x_session_initialize): Call gdk_x11_set_sm_client_id.
14522
14523 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
14524 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
14525 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
14526
1c2cc4ef
JB
145272011-03-08 Juanma Barranquero <lekktu@gmail.com>
14528
14529 * w32xfns.c (select_palette): Check success of RealizePalette against
14530 GDI_ERROR, not zero.
14531
33383987 14532See ChangeLog.11 for earlier changes.
aac0c6e3
MR
14533
14534;; Local Variables:
14535;; coding: utf-8
aac0c6e3
MR
14536;; End:
14537
2f097256 14538 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
14539
14540 This file is part of GNU Emacs.
14541
14542 GNU Emacs is free software: you can redistribute it and/or modify
14543 it under the terms of the GNU General Public License as published by
14544 the Free Software Foundation, either version 3 of the License, or
14545 (at your option) any later version.
14546
14547 GNU Emacs is distributed in the hope that it will be useful,
14548 but WITHOUT ANY WARRANTY; without even the implied warranty of
14549 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
14550 GNU General Public License for more details.
14551
14552 You should have received a copy of the GNU General Public License
14553 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.