Fix typos.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
bb187662
EZ
12011-09-17 Eli Zaretskii <eliz@gnu.org>
2
3 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
4 truncated lines if point is covered by a display string. (Bug#9524)
5
2e621251
PE
62011-09-16 Paul Eggert <eggert@cs.ucla.edu>
7
8 * xselect.c: Relax test for outgoing X longs (Bug#9498).
9 (cons_to_x_long): New function.
10 (lisp_data_to_selection_data): Use it. Correct the test for
11 short-versus-long data; it was negated. Break out of vector
12 loop, for efficiency, when a long datum is discovered.
13
91a15bc6
SM
142011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
15
16 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
17
b41c3a35
EZ
182011-09-16 Eli Zaretskii <eliz@gnu.org>
19
20 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
21 GCC PR/17406) by declaring this function with external scope.
22
7812ba2d
PE
232011-09-15 Paul Eggert <eggert@cs.ucla.edu>
24
25 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
26 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
27
cf7edc2a
AS
282011-09-15 Andreas Schwab <schwab@linux-m68k.org>
29
30 * editfns.c (Fformat): Correctly handle text properties on "%%".
31
bd01620e
EZ
322011-09-15 Eli Zaretskii <eliz@gnu.org>
33
34 * xterm.c (x_draw_composite_glyph_string_foreground):
35 * w32term.c (x_draw_composite_glyph_string_foreground):
36 * term.c (encode_terminal_code):
37 * composite.c (composition_update_it, get_composition_id):
38 * xdisp.c (get_next_display_element)
39 (fill_composite_glyph_string): Add comments about special meaning
40 of TAB characters in a composition.
41
a02719a3
PE
422011-09-15 Paul Eggert <eggert@cs.ucla.edu>
43
44 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
45 This occurs when processing a multibyte format.
46 Problem reported by Wolfgang Jenker.
a02719a3 47
72589a3c
JB
482011-09-15 Johan Bockgård <bojohan@gnu.org>
49
50 * xdisp.c (try_cursor_movement): Only check for exact match if
51 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
52
1c14176c
PE
532011-09-14 Paul Eggert <eggert@cs.ucla.edu>
54
55 Remove unused external symbols.
56 * dispextern.h (calc_pixel_width_or_height): Remove decl.
57 * xdisp.c (calc_pixel_width_or_height): Now static.
58 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
59 * indent.c (check_display_width):
60 * w32term.c: Fix comment to match code.
61 * xterm.c, xterm.h (x_catching_errors): Remove.
62
d2eea5b5
PE
632011-09-14 Paul Eggert <eggert@cs.ucla.edu>
64
65 * xselect.c: Use signed conversions more consistently (Bug#9498).
66 (selection_data_to_lisp_data): Assume incoming selection data are
67 signed integers, not unsigned. This is to be consistent with
68 outgoing selection data, which was modified to use signed integers
69 in as part of the fix to Bug#9196 in response to Jan D.'s comment
70 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
71 expects long, not unsigned long.
72
46888499
EZ
732011-09-14 Eli Zaretskii <eliz@gnu.org>
74
75 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
76 computation of loop end. Reported by Johan Bockgård
77 <bojohan@gnu.org>.
78
ef8ef9fb
CY
792011-09-13 Chong Yidong <cyd@stupidchicken.com>
80
81 * frame.c (Fother_visible_frames_p): Function deleted.
82
fa819fed
EZ
832011-09-12 Eli Zaretskii <eliz@gnu.org>
84
85 * indent.c (compute_motion): Process display vector front to back
86 rather than the other way around. (Bug#2496)
87
2ba8e008
SM
882011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
89
90 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
91
20f53c69
CY
922011-09-11 Chong Yidong <cyd@stupidchicken.com>
93
94 * minibuf.c (Fread_from_minibuffer): Doc fix.
95
d562d7a4
EZ
962011-09-11 Eli Zaretskii <eliz@gnu.org>
97
98 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
99 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
100
1c4d7f3d
LMI
1012011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
102
103 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
104 value for non-existent files.
105
b885bf36
EZ
1062011-09-11 Eli Zaretskii <eliz@gnu.org>
107
108 * fileio.c (Finsert_file_contents): If the file cannot be opened,
109 set its "size" to -1. This will set the modtime_size field of
110 the corresponding buffer to -1, which is what
111 verify-visited-file-modtime expects for files that do not exist.
112 (Bug#9139)
113
6612f0bf
PE
1142011-09-11 Paul Eggert <eggert@cs.ucla.edu>
115
116 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
117 here ...
118 * lisp.h: ... from here. push_key_description is no longer
119 defined in keyboard.c, so its declaration should not be in
120 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
121 logically belongs with push_key_description.
122
dfb3f755
PE
1232011-09-10 Paul Eggert <eggert@cs.ucla.edu>
124
125 * buffer.h: Include <sys/types.h> instead of <time.h>.
126 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
127 Problem reported by Herbert J. Skuhra.
128
3134906c
LMI
1292011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
130
131 * xml.c (parse_region): Make the parsing work for
132 non-comment-starting XML files again (bug#9144).
133
8d903f4e
AS
1342011-09-10 Andreas Schwab <schwab@linux-m68k.org>
135
136 * image.c (gif_load): Fix calculation of bottom and right corner.
137 (Bug#9468)
138
80ad64f4
EZ
1392011-09-10 Eli Zaretskii <eliz@gnu.org>
140
141 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
142 redisplay in small windows.
143
208a048d
EZ
1442011-09-09 Eli Zaretskii <eliz@gnu.org>
145
146 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
147
9b1c252e
MR
1482011-09-08 Martin Rudalics <rudalics@gmx.at>
149
150 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
151 Operate on live windows only.
152
2949f33b
JB
1532011-09-08 Juanma Barranquero <lekktu@gmail.com>
154
155 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
156
e08dcafd
EZ
1572011-09-07 Eli Zaretskii <eliz@gnu.org>
158
159 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
160 only under bidi iteration.
161
115b96bd
JD
1622011-09-07 Jan Djärv <jan.h.d@swipnet.se>
163
164 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
165
c8199d0f
PE
1662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
167
168 isnan: Fix porting problem to Solaris 10 with bundled gcc.
169 Without this fix, the command to link temacs failed due to an
170 undefined symbol __builtin_isnan. This is because
171 /usr/include/iso/math_c99.h #defines isnan(x) to
172 __builtin_isnan(x), but the bundled gcc, which identifies itself
173 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
174 a __builtin_isnan.
175 * floatfns.c (isnan): #undef, and then #define to a clone of
176 what's in data.c.
177 (Fisnan): Always define, since it's always available now.
178 (syms_of_floatfns): Always define isnan at the Lisp level.
179
e39b275c 1802011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
181
182 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
183
b2db44d9 1842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 185
f4af5137 186 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
187 The previous code assumed that file offsets (off_t values) fit in
188 EMACS_INT variables, which is not true on typical 32-bit hosts.
189 The code messed up by falsely reporting buffer overflow in cases
190 such as (insert-file-contents "big" nil 1 2) into an empty buffer
191 when "big" contains more than 2**29 bytes, even though this
192 inserts just one byte and does not overflow the buffer.
193 (Finsert_file_contents): Store file offsets as off_t
194 values, not as EMACS_INT values. Check for overflow when
195 converting between EMACS_INT and off_t. When checking for
196 buffer overflow or for overlap, take the offsets into account.
197 Don't use EMACS_INT for small values where int suffices.
198 When checking for overlap, fix a typo: ZV was used where
199 ZV_BYTE was intended.
200 (Fwrite_region): Don't assume off_t fits into 'long'.
201 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
202
ecfc0a49
MA
2032011-09-05 Michael Albinus <michael.albinus@gmx.de>
204
205 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
206
6511acf2 2072011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 208
0999621a 209 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
210
211 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 212 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
213 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
214 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
215 (modify_event_symbol): Do not assume that the length of
216 name_alist_or_stem is safe to alloca and fits in int.
217 (Fexecute_extended_command): Likewise for function name and binding.
218 (Frecursion_depth): Wrap around reliably on integer overflow.
219 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
220 since some callers pass EMACS_INT values.
221 (Fsingle_key_description): Don't crash if symbol name contains more
222 than MAX_ALLOCA bytes.
223 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
224 (get_minibuffer): Arg is now EMACS_INT, not int.
225 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 226 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
227 * window.h (command_loop_level, minibuf_level): Reflect API changes.
228
2be7d702
PE
229 * dbusbind.c (signature_cat): New function.
230 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
231 Do not overrun buffer; instead, report string overflow.
232
9d1df220
PE
233 * dispnew.c (add_window_display_history): Don't overrun buffer.
234 Truncate instead; this is OK since it's just a log.
235
33ef5c64
PE
236 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
237 even if the time zone offset is outlandishly large.
238 Don't mishandle offset == INT_MIN.
239
66c6fdd5
PE
240 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
241 when creating daemon; the previous buffer-overflow check was incorrect.
242
d749b01b
PE
243 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
244 which has the guts of the old verror function.
245
b5cd1905
PE
246 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
247 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
248
6e1a67fb
PE
249 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
250 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 251 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 252 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
253 length of string rather than counting it via multiple sprintfs;
254 that's simpler and more reliable.
c21721cc
PE
255 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
256 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
257 sprintf, in case result does not fit in int.
258
c57b67fc
PE
259 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
260 (fontset_from_font): Print it.
261
8a401434
PE
262 * frame.c (tty_frame_count): Now printmax_t, not int.
263 (make_terminal_frame, set_term_frame_name): Print it.
264 (x_report_frame_params): In X, window IDs are unsigned long,
265 not signed long, so print them as unsigned.
266 (validate_x_resource_name): Check for implausibly long names,
267 and don't assume name length fits in 'int'.
268 (x_get_resource_string): Don't blindly alloca invocation name;
269 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
270 not fit in int.
271
6e1a67fb
PE
272 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
273 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
274 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
275
0df02bf3
PE
276 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
277 Use esprintf, not sprintf, in case result does not fit in int.
278
48e30793
PE
279 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
280 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
281 it as a large positive number.
282 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
283 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
284
a66ff6d8
PE
285 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
286 in case result does not fit in int.
287
aca216ff
PE
288 * print.c (float_to_string): Detect width overflow more reliably.
289 (print_object): Make sprintf buffer a bit bigger, to avoid potential
290 buffer overrun. Don't assume list length fits in 'int'. Treat
291 print length of 0 as 0, not as infinity; to be consistent with other
292 uses of print length in this function. Don't overflow print length
293 index. Don't assume hash table size fits in 'long', or that
294 vectorlike size fits in 'unsigned long'.
295
31c286f7
PE
296 * process.c (make_process): Use printmax_t, not int, to format
297 process-name gensyms.
298
55e5faa1
PE
299 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
300
80f2e268
PE
301 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
302 to avoid potential buffer overrun.
303
670741ab
PE
304 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
305 if X resource line is longer than 512 bytes.
306
b7163a50
PE
307 * xfns.c (x_window): Make sprintf buffer a bit bigger
308 to avoid potential buffer overrun.
309
ae58ff1f
PE
310 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
311
c43c8a6a
PE
312 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
313
3f8236f4
PE
3142011-09-04 Paul Eggert <eggert@cs.ucla.edu>
315
53e9fe90 316 Integer overflow fixes for scrolling, etc.
6511acf2
PE
317 Without these, Emacs silently mishandles large integers sometimes.
318 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
319 it were "C-u 1 M-x recenter" on a typical 64-bit host.
320
6511acf2
PE
321 * xdisp.c (try_window_id): Check Emacs fixnum range before
322 converting to 'int'.
806add1d 323
6511acf2 324 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
325 Check that an Emacs fixnum is in range before assigning it to 'int'.
326 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
327 values converted from Emacs fixnums.
328 (Frecenter): Don't wrap around a line count if it is out of 'int'
329 range; instead, treat it as an extreme value.
330 (Fset_window_configuration, compare_window_configurations):
331 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
332
6511acf2
PE
333 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
334 that can exceed INT_MAX. Check that EMACS_INT value is in range
335 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
336 (match_limit): Don't assume that a fixnum can fit in 'int'.
337
6511acf2 338 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
339 exceed INT_MAX.
340
6511acf2 341 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
342 (Fvertical_motion): Don't wrap around LINES values that don't fit
343 in 'int'. Instead, treat them as extreme values. This is good
344 enough for windows, which can't have more than INT_MAX lines anyway.
345
fcb901a7
LMI
3462011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
347
0f2f6b6d
LMI
348 * Require libxml/parser.h to avoid compilation warning.
349
fcb901a7
LMI
350 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
351
352 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
353 since this reportedly can destroy thread storage.
354
6e20a0d4
CY
3552011-08-30 Chong Yidong <cyd@stupidchicken.com>
356
357 * syntax.c (find_defun_start): Update all cache variables if
358 exiting early (Bug#9401).
359
148ae00e
EZ
3602011-08-30 Eli Zaretskii <eliz@gnu.org>
361
f6cfbd8f
EZ
362 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
363
148ae00e
EZ
364 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
365 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
366 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
367
368 * term.c (tty_append_glyph): New function.
369 (produce_stretch_glyph): Static function and its prototype deleted.
370
371 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
372 prototypes.
373
c4a07a4c
PE
3742011-08-29 Paul Eggert <eggert@cs.ucla.edu>
375
376 * image.c (parse_image_spec): Check for nonnegative, not for positive,
377 when checking :margin (Bug#9390).
378 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
379 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
380 so that the name doesn't mislead. All uses changed.
381
6bc8cd65
JB
3822011-08-28 Johan Bockgård <bojohan@gnu.org>
383
384 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
385 set_tty_hooks.
386
dca4927e
EZ
3872011-08-27 Eli Zaretskii <eliz@gnu.org>
388
389 * xdisp.c (move_it_to): Don't bail out early when reaching
390 position beyond to_charpos, if we are scanning backwards.
391 (move_it_vertically_backward): When DY == 0, make sure we get to
392 the first character in the line after the newline.
393
f2cad773
PE
3942011-08-27 Paul Eggert <eggert@cs.ucla.edu>
395
396 * ccl.c: Improve and simplify overflow checking (Bug#9196).
397 (ccl_driver): Do not generate an out-of-range pointer.
398 (Fccl_execute_on_string): Remove unnecessary check for
399 integer overflow, noted by Stefan Monnier in
400 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
401 Remove a FIXME that didn't need fixing.
402 Simplify the newly-introduced buffer reallocation code.
403
0cae2cdb
JB
4042011-08-27 Juanma Barranquero <lekktu@gmail.com>
405
406 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
407
5fc295a4 4082011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 409
70c60eb2 410 Integer and memory overflow issues (Bug#9196).
726e0ab1 411
d31850da
PE
412 * doc.c (get_doc_string): Rework so that
413 get_doc_string_buffer_size is the actual buffer size, rather than
414 being 1 less than the actual buffer size; this makes xpalloc more
415 convenient.
416
a69fbedb
PE
417 * image.c (x_allocate_bitmap_record, cache_image):
418 * xselect.c (Fx_register_dnd_atom):
419 Simplify previous changes by using xpalloc.
420
fe5c5d37
PE
421 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
422 since either will do and ptrdiff_t is convenient with xpalloc.
423
0065d054
PE
424 * charset.c (charset_table_size)
425 (struct charset_sort_data.priority): Now ptrdiff_t.
426 (charset_compare): Don't overflow if priorities differ greatly.
427 (Fsort_charsets): Don't assume list length fits in int.
428 Check for size-calculation overflow when allocating sort data.
429 (syms_of_charset): Allocate an initial charset table that is
430 just under 64 KiB, to avoid problems with glibc malloc and mmap.
431
432 * cmds.c (internal_self_insert): Check for size-calculation overflow.
433
434 * composite.h (struct composition.glyph_len): Now int, not unsigned.
435 The actual value is always <= INT_MAX, and leaving it unsigned made
436 overflow checking harder.
437
438 * dispextern.h (struct glyph_matrix.rows_allocated)
439 (struct face_cache.size): Now ptrdiff_t, for convenience in use
440 with xpalloc. The values are still always <= INT_MAX.
441
442 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
443
444 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
445 (SAFE_NALLOCA): New macro.
446
447 * region-cache.c (struct boundary.pos, find_cache_boundary)
448 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
449 (set_cache_region, invalidate_region_cache)
450 (revalidate_region_cache, know_region_cache, region_cache_forward)
451 (region_cache_backward, pp_cache):
452 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
453 so that ptrdiff_t * can be passed to xpalloc.
454 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
455 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
456 (pp_cache): Don't assume cache_len fits in int.
457 * region-cache.h: Adjust extern decls to match.
458
459 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
460 EMACS_INT, since either will do, for xpalloc.
461
462 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
463 (xnmalloc, xnrealloc, xpalloc): New functions.
464
726e0ab1
PE
465 * bidi.c (bidi_shelve_header_size): New constant.
466 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
467 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
468
51f30bc5 469 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
470 * buffer.c (overlays_at, overlays_in, record_overlay_string)
471 (overlay_strings):
472 Don't update size of array until after memory allocation succeeds,
473 because xmalloc/xrealloc may not return.
0065d054
PE
474 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
475 now that we have proper integer overflow checking.
476 (record_overlay_string, overlay_strings): Catch overflows when
477 calculating size of overlay_str_buf.
726e0ab1 478
0065d054
PE
479 * callproc.c (Fcall_process): Check for size overflow when
480 calculating size of args2.
481 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
482 Normally we prefer signed values, but sticking with ptrdiff_t would
483 require adding more-complicated checks.
726e0ab1
PE
484
485 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
486 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
487 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 488 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
489
490 * character.c (Fstring): Check for size-calculation overflow.
491
492 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
493 unnecessary integer overflow. Check for size overflow.
494 (encode_coding_object): Don't update size until xmalloc succeeds.
495
496 * composite.c (get_composition_id): Check for overflow in glyph
497 length calculations.
498
499 Integer and memory overflow fixes for display code.
500 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
501 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
502 (scrolling_window): Check for overflow in size calculations.
503 (line_draw_cost, realloc_glyph_pool, add_row_entry):
504 Don't assume glyph table len fits in int.
505 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
506 (row_table_size): Now ptrdiff_t, not int.
507 (scrolling_window): Avoid overflow in size calculations.
508 Don't update size until allocation succeeds.
509 * fns.c (concat): Check for overflow in size calculations.
510 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
511 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
512 (NEXT_ALMOST_PRIME_LIMIT): New constant.
513
514 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
515 (get_doc_string): Check for size calculation overflow.
516 Don't update size until allocation succeeds.
517 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
518 EMACS_INT, where ptrdiff_t will do.
519 (Fsubstitute_command_keys): Check for string overflow.
520
521 * editfns.c (set_time_zone_rule): Don't assume environment length
522 fits in int.
523 (message_length): Now ptrdiff_t, not int.
524 (Fmessage_box): Don't update size until allocation succeeds.
525 Don't assume message length fits in int.
526 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
527
0065d054
PE
528 * emacs.c (main): Do not reallocate argv, since there is a null at
529 the end that can be overwritten, and this way there's no need to
530 worry about size-calculation overflow.
531 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
532
533 * eval.c (init_eval_once, grow_specpdl): Don't update size until
534 alloc succeeds.
535 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
536
537 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
538 (x_set_scroll_bar_width, x_figure_window_size):
539 Check for integer overflow.
540 (x_set_alpha): Do not assume XINT fits in int.
541
542 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
543 This is for the members text_lines, text_cols, total_lines, total_cols,
544 where the system imposes an 'int' limit.
545
546 * fringe.c (Fdefine_fringe_bitmap):
547 Don't update size until alloc works.
548
549 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
550 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
551
552 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
553 Check for size-calculation overflow.
554 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
555 do, as we prefer signed integers.
556 (id_to_widget.max_size, id_to_widget.used)
557 (xg_store_widget_in_map, xg_remove_widget_from_map)
558 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
559 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
560 Use and return ptrdiff_t, not int.
561 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
562 * gtkutil.h: Change prototypes to match the above.
563
564 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
565 are duplicate now that they've been promoted to lisp.h.
566 (x_allocate_bitmap_record, x_alloc_image_color)
567 (make_image_cache, cache_image, xpm_load):
568 Don't update size until alloc is done.
569 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
570 (x_detect_edges):
3256efce 571 Check for size calculation overflow.
726e0ab1
PE
572 (ct_colors_allocated_max): New constant.
573 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
574 overflow.
3256efce 575
726e0ab1
PE
576 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
577 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
578 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
579 Use ptrdiff_t, not int, to count maps.
580 (read_char_minibuf_menu_prompt): Check for overflow in size
581 calculations. Don't update size until allocation succeeds. Redo
582 calculations to avoid overflow.
583 * keyboard.h: Change prototypes to match the above.
584
585 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
586 to count maps.
587 (current_minor_maps): Check for size calculation overflow.
588 * keymap.h: Change prototypes to match the above.
589
590 * lread.c (read1, init_obarray): Don't update size until alloc done.
591
592 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
593 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
594
726e0ab1
PE
595 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
596 Now ptrdiff_t, not int.
597 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
598 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
599
600 * process.c (Fnetwork_interface_list): Check for overflow
601 in size calculation.
602
603 * region-cache.c (move_cache_gap): Check for size calculation overflow.
604
605 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
606 overflow. Don't bother calling xmalloc when xrealloc will do.
607
608 * search.c (Freplace_match): Check for size calculation overflow.
609 (Fset_match_data): Don't assume list lengths fit in 'int'.
610
611 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
612 for command line length. Do not attempt to address one before the
613 beginning of an array, as that's not portable.
614
615 * term.c (max_frame_lines): Remove; unused.
616 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
617 not int.
618 (encode_terminal_code, calculate_costs): Check for size
619 calculation overflow.
620 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
621 table lengths and related sizes. Don't update size until alloc
622 done. Redo calculations to avoid overflow.
623 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
624
625 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
626 subtracting pointers.
627 (gobble_line): Check for overflow more carefully. Don't update size
628 until alloc done.
629
630 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
631 Don't update size until alloc done.
632 Redo size calculations to avoid overflow.
633 Check for size calculation overflow.
0065d054 634 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
635
636 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
637 Use ptrdiff_t, not int, for sizes.
638 (store_mode_line_noprop_char): Don't update size until alloc done.
639
0065d054
PE
640 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
641 Use ptrdiff_t, not int, for sizes.
642 (Finternal_make_lisp_face, cache_face):
643 Check for size calculation overflow.
644 (cache_face): Treat size calculation overflows as if they were
645 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
646
647 * xfns.c (x_encode_text, x_set_name_internal)
648 (Fx_change_window_property): Use ptrdiff_t, not int, to count
649 sizes, since they can exceed INT_MAX in size. Check for size
650 calculation overflow.
651
0065d054
PE
652 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
653 (xg_select): Check for size calculation overflow.
726e0ab1
PE
654 Don't update size until alloc done.
655
0065d054 656 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 657 as sprintf is limited to int lengths.
1d526e2f 658
252c5ee1
PE
659 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
660 (X_LONG_MIN): New macros.
864d7ce7
PE
661 Use them to make the following changes clearer.
662 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
663 This change doesn't affect the value now, but it may help remind
664 future maintainers not to raise the value too much later.
665 (SELECTION_QUANTUM): Remove, replacing with ...
666 (selection_quantum): ... new function, which avoids overflow.
667 All uses changed.
668 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
669 assumption that selection length fits in 'int'.
670 (x_reply_selection_request, x_handle_selection_request)
671 (x_get_window_property, receive_incremental_selection)
672 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
673 (lisp_data_to_selection_data, clean_local_selection_data):
674 Use ptrdiff_t, not int, to record length of selection.
675 (x_reply_selection_request, x_get_window_property)
676 (receive_incremental_selection, x_property_data_to_lisp):
677 Redo calculations to avoid overflow.
678 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 679 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
680 something.
681 (x_get_window_property, receive_incremental_selection)
682 (lisp_data_to_selection_data, x_property_data_to_lisp):
683 Check for size-calculation overflow.
684 (x_get_window_property, receive_incremental_selection)
685 (lisp_data_to_selection_data, Fx_register_dnd_atom):
686 Don't store size until memory allocation succeeds.
687 (x_get_window_property): Plug memory leak on memory exhaustion.
688 Don't double-block input; malloc is safe here. Don't assume 2**34
689 - 4 fits in unsigned long. Add an xassert to check
690 XGetWindowProperty overflow. Be more careful about overflow
691 calculations, and distinguish size from memory overflow better.
692 (receive_incremental_selection): When tracing, don't assume
693 unsigned int is less than INT_MAX.
694 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
695 harmful) conversions of unsigned short to int.
696 (lisp_data_to_selection_data): Don't assume that integers
697 in the range -65535 through -1 fit in an X unsigned short.
698 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
699 result parameters unless successful. Rely on cons_to_unsigned
700 to report problems with elements; the old code wasn't right anyway.
701 (x_check_property_data): Check for int overflow; we cannot use
702 a wider type due to X limits.
703 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
704
726e0ab1 705 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 706
0065d054
PE
707 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
708 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
709 (x_color_cells): Don't store size until memory allocation succeeds.
710 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 711 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
712 (x_term_init): Don't assume length fits in int (sprintf is limited
713 to int size).
bc18e09d 714
ebfa62c0
PE
715 Use ptrdiff_t for composition IDs.
716 * character.c (lisp_string_width):
717 * composite.c (composition_table_size, n_compositions)
718 (get_composition_id, composition_gstring_from_id):
719 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
720 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
721 * window.c (Frecenter):
722 Use ptrdiff_t, not int, for composition IDs.
723 * composite.c (get_composition_id): Check for integer overflow.
724 * composite.h: Adjust prototypes to match the above changes.
725
d3411f89
PE
726 Use ptrdiff_t for hash table indexes.
727 * category.c (hash_get_category_set):
728 * ccl.c (ccl_driver):
729 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
730 * coding.c (coding_system_charset_list, detect_coding_system):
731 * coding.h (struct coding_system.id):
732 * composite.c (get_composition_id, gstring_lookup_cache):
733 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
734 * image.c (xpm_get_color_table_h):
735 * lisp.h (hash_lookup, hash_put):
736 * minibuf.c (Ftest_completion):
737 Use ptrdiff_t for hash table indexes, not int (which is too
738 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
739 32-bit --with-wide-int hosts).
740
e097a6fa
PE
741 * charset.c (Fdefine_charset_internal): Check for integer overflow.
742 Add a FIXME comment about memory leaks.
743 (syms_of_charset): Don't assume xmalloc returns.
744
5637687f
PE
745 Don't assume that stated character widths fit in int.
746 * character.c (Fchar_width, c_string_width, lisp_string_width):
747 * character.h (CHAR_WIDTH):
748 * indent.c (MULTIBYTE_BYTES_WIDTH):
749 Use sanitize_char_width to avoid undefined and/or bad behavior
750 with outlandish widths.
751 * character.h (sanitize_tab_width): Renamed from sanitize_width,
752 now that we have two such functions. All uses changed.
753 (sanitize_char_width): New inline function.
754
a2271ba2
PE
755 Don't assume that tab-width fits in int.
756 * character.h (sanitize_width): New inline function.
757 (SANE_TAB_WIDTH): New macro.
758 (ASCII_CHAR_WIDTH): Use it.
759 * indent.c (sane_tab_width): Remove. All uses replaced by
760 SANE_TAB_WIDTH (current_buffer).
761 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
762
18c52557
PE
763 * fileio.c: Integer overflow issues with file modes.
764 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
765
caeeedc1
PE
766 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
767 Remove unreachable code.
768 (read_hex, load_charset_map_from_file): Check for integer overflow.
769
50849c52
PE
770 * xterm.c: don't go over XClientMessageEvent limit
771 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
772 (x_send_scroll_bar_event): Likewise. Check that the size does not
773 exceed limits imposed by XClientMessageEvent, as well as the usual
774 ptrdiff_t and size_t limits.
775
b13995db
PE
776 * keyboard.c: Overflow, signedness and related fixes.
777 (make_lispy_movement): Use same integer type in forward decl
778 that is used in the definition.
779 (read_key_sequence, keyremap_step):
780 Change bufsize argument back to int, undoing my 2011-03-30 change.
781 We prefer signed types, and int is wide enough here.
782 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
783 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
784 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
785 length, not size_t. Use ptrdiff_t for index, not int.
786 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
787 possibility of integer overflow.
788
13464394
PE
789 Overflow, signedness and related fixes for images.
790
791 * dispextern.h (struct it.stack[0].u.image.image_id)
792 (struct_it.image_id, struct image.id, struct image_cache.size)
793 (struct image_cache.used, struct image_cache.ref_count):
794 * gtkutil.c (update_frame_tool_bar):
795 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
796 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
797 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
798 * nsmenu.m (update_frame_tool_bar):
799 * xdisp.c (calc_pixel_width_or_height):
800 * xfns.c (image_cache_refcount):
801 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
802 on typical 64-bit hosts.
803
804 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
805 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
806 Omit unnecessary casts to int.
807 (parse_image_spec): Check that integers fall into 'int' range
808 when the callers expect that.
809 (image_ascent): Redo ascent calculation to avoid int overflow.
810 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
811 (lookup_image): Remove unnecessary tests.
812 (xbm_image_p): Locals are now of int, not EMACS_INT,
813 since parse_image_check makes sure they fit into int.
814 (png_load, gif_load, svg_load_image):
815 Prefer int to unsigned where either will do.
816 (tiff_handler): New function, combining the cores of the
817 old tiff_error_handler and tiff_warning_handler. This
818 function is rewritten to use vsnprintf and thereby avoid
819 stack buffer overflows. It uses only the features of vsnprintf
820 that are common to both POSIX and native Microsoft.
821 (tiff_error_handler, tiff_warning_handler): Use it.
822 (tiff_load, gif_load, imagemagick_load_image):
823 Don't assume :index value fits in 'int'.
824 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
825 (imagemagick_load_image): Check that crop parameters fit into
826 the integer types that MagickCropImage accepts. Don't assume
827 Vimagemagick_render_type has a nonnegative value. Don't assume
828 size_t fits in 'long'.
829 (gs_load): Use printmax_t to print the widest integers possible.
830 Check for integer overflow when computing image height and width.
831
c11821d4
EZ
8322011-08-26 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (redisplay_window): Don't force window start if point
835 will be invisible in the resulting window. (Bug#9324)
836
0c95fcf7
EZ
8372011-08-25 Eli Zaretskii <eliz@gnu.org>
838
839 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
840 the display spec is of the form `(space ...)'.
841 (handle_display_spec): Return the value returned by
842 handle_single_display_spec, not just 1 or zero.
843 (handle_single_display_spec): If the display spec is of the form
844 `(space ...)', and specifies display in the text area, return 2
845 rather than 1.
fee65a97 846 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
847 accurately, and prefer exact match for point under bidi. Don't
848 advance `row' beyond the last row of the window.
0c95fcf7
EZ
849
850 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
851 into disp_prop; all users changed.
852
853 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
854 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
855 for the text covered by the display property.
856
e4ed06f1
CY
8572011-08-25 Chong Yidong <cyd@stupidchicken.com>
858
859 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
860 Change return value to nil.
861 (Frecord_buffer): Delete unused function.
862
f67cdd7f
EZ
8632011-08-24 Eli Zaretskii <eliz@gnu.org>
864
5980d4c6
EZ
865 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
866 buffers, return left-to-right.
8610fe8b
EZ
867 (set_cursor_from_row): Consider candidate row a win if its glyph
868 represents a newline and point is on that newline. Fixes cursor
869 positioning on the newline at EOL of R2L text within L2R
870 paragraph, and vice versa.
871 (try_cursor_movement): Check continued rows, in addition to
872 continuation rows. Fixes unwarranted scroll when point enters a
873 continued line of R2L text within an L2R paragraph, or vice versa.
874 (cursor_row_p): Consider the case of point being equal to
875 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
876 from the end of a short line to the beginning of a continued line
877 of R2L text within L2R paragraph.
878 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
879 composed characters.
5980d4c6 880
f67cdd7f
EZ
881 * bidi.c (bidi_check_type): Use xassert.
882 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
883 members.
884
bca633fb
EZ
8852011-08-23 Eli Zaretskii <eliz@gnu.org>
886
887 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
888 a character.
889
4a5885a7
CY
8902011-08-23 Chong Yidong <cyd@stupidchicken.com>
891
892 * nsfont.m (ns_otf_to_script): Fix typo.
893
0902a04e
KH
8942011-08-22 Kenichi Handa <handa@m17n.org>
895
896 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
897 extra slot even if the purpose is char-code-property-table.
898
1a2e6670
EZ
8992011-08-23 Eli Zaretskii <eliz@gnu.org>
900
8ddde651
EZ
901 * xdisp.c (redisplay_window): When computing centering_position,
902 account for the height of the header line. (Bug#8874)
903
425cc014
EZ
904 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
905 instead of CHAR_TO_BYTE. Fixes a crash when a completion
906 candidate is selected by the mouse, and that candidate has a
907 composed character under the mouse.
908
1a2e6670
EZ
909 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
910 coordinates reported by pos-visible-in-window-p for a composed
911 character in column zero.
912
8b76d6f8
SM
9132011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
914
915 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
916
dac347dd
EZ
9172011-08-22 Eli Zaretskii <eliz@gnu.org>
918
919 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
920 consider it a hit if to_charpos is anywhere in the range of the
921 composed buffer positions.
922
e013fb34
CY
9232011-08-22 Chong Yidong <cyd@stupidchicken.com>
924
925 * image.c (gif_load): Don't assume that each subimage has the same
926 dimensions as the base image. Handle disposal method that is
927 "undefined" by the gif spec (Bug#9335).
928
bd1ba3e8
CY
9292011-08-20 Chong Yidong <cyd@stupidchicken.com>
930
931 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 932 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 933
54a1215b
EZ
9342011-08-19 Eli Zaretskii <eliz@gnu.org>
935
823564e5
EZ
936 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
937 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
938 from an Org mode buffer to a Speedbar frame.
939
54a1215b
EZ
940 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
941 a composition, take its buffer position from IT->cmp_it.charpos.
942 Fixes cursor positioning at the beginning of a line that begins
943 with a composed character.
944
9778ebcc
EZ
9452011-08-18 Eli Zaretskii <eliz@gnu.org>
946
0be6ee06
EZ
947 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
948 character bidirectional type, use STRONG_L instead. Fixes crashes
949 in a buffer produced by `describe-categories'.
950
9778ebcc
EZ
951 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
952 members before the level stack, so they would be saved and
953 restored when copying iterator state. Fixes incorrect reordering
954 around TABs covered by display properties.
955
156bffbe
AS
9562011-08-18 Andreas Schwab <schwab@linux-m68k.org>
957
958 * process.c (Fnetwork_interface_list): Correctly determine buffer
959 size.
960
72ad093b
CY
9612011-08-17 Chong Yidong <cyd@stupidchicken.com>
962
963 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
964 (internal_condition_case_2, internal_condition_case_n):
965 Remove unnecessary aborts (Bug#9081).
72ad093b 966
35774242
EZ
9672011-08-17 Eli Zaretskii <eliz@gnu.org>
968
969 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
970 has no `load' handler, try opening the file locally. (Bug#9311)
971
db76dd85
KB
9722011-08-16 Ken Brown <kbrown@cornell.edu>
973
974 * gmalloc.c: Expand comment.
975
b215eee5
EZ
9762011-08-16 Eli Zaretskii <eliz@gnu.org>
977
978 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
979 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
980
a4579d33
KB
9812011-08-16 Ken Brown <kbrown@cornell.edu>
982
983 Fix memory allocation problems in Cygwin build (Bug#9273).
984
985 * unexcw.c ( __malloc_initialized): Declare external variable.
986 (fixup_executable): Force the dumped emacs to reinitialize malloc.
987
8b76d6f8
SM
988 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
989 New variables.
a4579d33
KB
990 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
991 dumped emacs.
992 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
993 in the static heap.
994 [CYGWIN] (special_realloc): New function.
995 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
996 requests to realloc storage in the static heap.
997
3ebec551
PE
9982011-08-15 Paul Eggert <eggert@cs.ucla.edu>
999
1000 * bidi.c (bidi_initialize): Remove unused local.
1001
9fd8be00
EZ
10022011-08-15 Eli Zaretskii <eliz@gnu.org>
1003
474a8465
EZ
1004 * biditype.h: File removed.
1005
1006 * bidimirror.h: File removed.
1007
1008 * deps.mk (bidi.o): Remove biditype.h and
1009 bidimirror.h.
1010
1011 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1012 bidimirror.h.
1013
1014 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1015
1016 * chartab.c: Improve commentary for the uniprop_table API.
1017
32413314
EZ
1018 * bidi.c (bidi_paragraph_init): Support zero value of
1019 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1020 (bidi_initialize): Use uniprop_table instead of including
1021 biditype.h and bidimirror.h.
32413314 1022
9fd8be00
EZ
1023 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1024 coordinates of the iterator when restoring from ppos_it.
1025 (Bug#9296)
1026
5cf2b69b
KH
10272011-08-14 Kenichi Handa <handa@m17n.org>
1028
1029 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1030 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1031
daf17d00
EZ
10322011-08-14 Eli Zaretskii <eliz@gnu.org>
1033
1034 * xdisp.c (move_it_in_display_line_to): Don't invoke
1035 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1036 ppos_it. Fixes vertical cursor motion when line beginning is
1037 covered by an image. (Bug#9296)
1038
08e3161a
JD
10392011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1040
1041 * nsterm.h (ns_run_ascript): Declare.
1042 (NSAPP_DATA2_RUNASSCRIPT): Define.
1043
1044 * nsfns.m (as_script, as_result, as_status): New static variables.
1045 (ns_run_ascript): New function.
5e617bc2 1046 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1047 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1048 the event loop. Get status from as_status (Bug#7276).
1049
1050 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1051 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1052 the event loop (Bug#7276).
1053
a3720aa2
AS
10542011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1055
1056 * gnutls.c (QCgnutls_bootprop_priority)
1057 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1058 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1059 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1060 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1061 (QCgnutls_bootprop_verify_hostname_error)
1062 (QCgnutls_bootprop_callbacks_verify): Rename from
1063 Qgnutls_bootprop_..., all uses changed.
1064
1065 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1066 uses changed.
1067
0a0d27fb
PE
10682011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1069
19d5c50c
PE
1070 * xfaces.c (Qframe_set_background_mode): Now static.
1071 * dispextern.h (Qframe_set_background_mode): Remove decl.
1072
0a0d27fb
PE
1073 * process.c (Fnetwork_interface_info): Declare local only if needed.
1074
377538cb
JD
10752011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1076
1077 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1078 (Fnetwork_interface_list): Allocate in increments of bytes instead
1079 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1080 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1081 sockaddr.
1082 (struct ifflag_def): notrailers is smart on OSX.
1083 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1084 Get hardware address with getifaddrs if available.
1085
08fff70c
EZ
10862011-08-12 Eli Zaretskii <eliz@gnu.org>
1087
1088 * xdisp.c (iterate_out_of_display_property): xassert that
1089 IT->position is set to within IT->object's boundaries. Break from
1090 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1091 when IT->position is set up wrongly due to some bug.
1092 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1093 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1094 entry. Force push_it to save on the stack the current
1095 buffer/string position, to be restored by pop_it. Fix flags in
1096 the iterator structure wrt the object coming from a display
1097 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1098 properties. (Bug#9284)
1099
7be1c708 11002011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1101
7be1c708
CY
1102 * fontset.c (fontset_get_font_group): Add proper type checks.
1103 (Bug#9172)
aac0c6e3 1104
7be1c708 11052011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1106
7be1c708
CY
1107 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1108 and LC_VERSION_MIN_MACOSX.
1109 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1110 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1111
97bb72a6
EZ
11122011-08-08 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1115 no-display-properties-and-no-overlays under bidi display.
1116 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1117 properties and overlays.
97bb72a6 1118
d5617611
CY
11192011-08-08 Chong Yidong <cyd@stupidchicken.com>
1120
37e11a63
CY
1121 * editfns.c (Fset_time_zone_rule): Document relationship with the
1122 setenv function.
1123
d5617611
CY
1124 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1125 the font entity extracted from the cache (Bug#8109).
1126
58872834
CY
11272011-08-07 Chong Yidong <cyd@stupidchicken.com>
1128
1129 * composite.c (autocmp_chars): Don't reset point. That is done by
1130 restore_point_unwind (Bug#5984).
1131
75bfc667
JL
11322011-08-07 Juri Linkov <juri@jurta.org>
1133
1134 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1135 to show the arg `TIME' instead of `TIMEVAL'.
1136
d1410150
EZ
11372011-08-06 Eli Zaretskii <eliz@gnu.org>
1138
1139 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1140 display property strides EOL and includes a newline, as in
1141 longlines-mode. (Bug#9254)
75b771e4
EZ
1142 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1143 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1144
1145 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1146 is non-zero, even if the data buffer is NULL. Fixes a crash in
1147 vertical-motion with longlines-mode. (Bug#9254)
1148
35928349
EZ
11492011-08-05 Eli Zaretskii <eliz@gnu.org>
1150
ec7cc85b
EZ
1151 * bidi.c <bidi_cache_total_alloc>: Now static.
1152 (bidi_initialize): Initialize bidi_cache_total_alloc.
1153
8b76d6f8 1154 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1155 cache. (Bug#9221)
1156
1157 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1158 amount allocated this far in `bidi_cache_total_alloc'.
1159 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1160 non-zero, only free the data buffer without restoring the cache
1161 contents. All callers changed.
1162
1163 * dispextern.h (bidi_unshelve_cache): Update prototype.
1164
1165 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1166 (move_it_in_display_line, move_it_to)
1167 (move_it_vertically_backward, move_it_by_lines): Replace the call
1168 to xfree to an equivalent call to bidi_unshelve_cache.
1169 (move_it_in_display_line_to): Fix logic of returning
412b6358 1170 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1171
e2e2423b
EZ
11722011-08-05 Eli Zaretskii <eliz@gnu.org>
1173
1174 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1175 came from a string character with a `cursor' property. (Bug#9229)
1176
ae9e757a
JD
11772011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1178
1179 * Makefile.in (LIB_PTHREAD): New variable.
1180 (LIBES): Add LIB_PTHREAD (Bug#9216).
1181
1182 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1183 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1184
213bd7f2
AS
11852011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1186
1187 * regex.c (re_iswctype): Remove some redundant boolean
1188 conversions.
1189
99aaf75f
JD
11902011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1191
1192 * xterm.c (x_find_topmost_parent): New function.
1193 (x_set_frame_alpha): Find topmost parent window with
1194 x_find_topmost_parent and set the property there also (bug#9181).
1195 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1196
c74e9d86
PE
11972011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1198
1199 * callproc.c (Fcall_process): Avoid vfork clobbering
1200 the local vars buffer, coding_systems, current_dir.
1201
640c8776
SM
12022011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1203
1204 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1205
f26d0e4c
PE
12062011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1207
8a10d76c
PE
1208 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1209 so that it is not optimized away.
1210
f26d0e4c
PE
1211 * xdisp.c (compute_display_string_pos): Remove unused local.
1212
55439c61
EZ
12132011-08-02 Eli Zaretskii <eliz@gnu.org>
1214
1215 Fix slow cursor motion and scrolling in large buffers with
1216 selective display, like Org Mode buffers. (Bug#9218)
1217
1218 * dispextern.h (struct bidi_it): New member disp_prop_p.
1219
1220 * xdisp.c: Remove one-slot cache of display string positions.
1221 (compute_display_string_pos): Accept an additional argument
5e617bc2 1222 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1223 for a display string or property. If found, set DISP_PROP_P
1224 non-zero.
1225
1226 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1227 DISP_PROP_P, and pass it to compute_display_string_pos.
1228 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1229 non-zero. All callers of bidi_fetch_char changed.
1230
fb33fa43
SM
12312011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1232
1233 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1234
b099e063
DM
12352010-12-03 Don March <don@ohspite.net>
1236
1237 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1238 last character M-[char] is translated to ESC [char] (bug#7541).
1239
5cc7f7af
KH
12402011-08-02 Kenichi Handa <handa@m17n.org>
1241
d0fffa3f 1242 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1243
1244 * chartab.c (uniprop_table): Make it non-static.
1245
525d5e6e
EZ
12462011-08-01 Eli Zaretskii <eliz@gnu.org>
1247
1248 * xdisp.c (forward_to_next_line_start): Accept additional argument
1249 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1250 on the newline.
1251 (reseat_at_next_visible_line_start): Use the bidi iterator state
1252 returned by forward_to_next_line_start to restore the state of
1253 it->bidi_it after backing up to previous newline. (Bug#9212)
1254
31011111
AS
12552011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1256
1257 * regex.c (re_comp): Protoize.
1258 (re_exec): Fix return type.
1259 (regexec): Fix type of `ret'. (Bug#9203)
1260
476371c4
PE
12612011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1262
e5d76069
PE
1263 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1264 This is needed if max-image-size is a floating-point number.
1265
9a79b20c
AS
12662011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1267
1268 * print.c (print_object): Print empty symbol as ##.
1269
1270 * lread.c (read1): Read ## as empty symbol.
1271
d8c2fa78
AA
12722011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1273
1274 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1275 setting frame foreground color (Bug#9175).
1276 (x_set_background_color): Likewise.
1277
ffe57a7a
AA
1278 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1279 contents (Bug#9176).
1280 (EmacsTooltip -init): Remove bezels and add shadows to
1281 tooltip windows.
1282
bf3492a5
AA
1283 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1284 or scroll bar (Bug#8470).
1285
d55e9c53
AA
1286 * nsfont.m (nsfont_open): Remove assignment to voffset and
1287 unnecessary vars hshink, expand, hd, full_height, min_height.
1288 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1289
1290 * nsterm.h (nsfont_info): Remove voffset field.
1291
d8c2fa78 12922011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1293
1294 Implement strike-through and overline on NextStep (Bug#8863).
1295
1296 * nsfont.m (nsfont_open): Use underline position provided by font,
1297 instead of hard-coded value of 2.
1298 (nsfont_draw): Call ns_draw_text_decoration instead.
1299
1300 * nsterm.h: Add declaration for ns_draw_text_decoration.
1301
1302 * nsterm.m (ns_draw_text_decoration): New function for drawing
1303 underline, overline, and strike-through.
1304 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1305 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 1306 accommodate underlining, etc.
4843aac3 1307
4cc60b9b
EZ
13082011-07-28 Eli Zaretskii <eliz@gnu.org>
1309
bc7ece87
EZ
1310 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1311 default.
4cc60b9b 1312
476371c4
PE
13132011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1314
66606eea
PE
1315 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1316 Without this fix, if a signal arrives just after memory fills up,
1317 'malloc' might be invoked reentrantly.
1318
476371c4
PE
1319 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1320 In other words, assume that every image size is allowed, on non-X
1321 hosts. This assumption is probably wrong, but it lets Emacs compile.
1322
f3fcc40d
AS
13232011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1324
1325 * regex.c (re_iswctype): Convert return values to boolean.
1326
350c992f
EZ
13272011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1328
1329 * xdisp.c (compute_display_string_pos): Don't use cached display
1330 string position if the buffer had its restriction changed.
1331 (Bug#9184)
1332
5266b4bb
PE
13332011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1334
1335 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1336
2573a837 13372011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1338
41f55ccd 1339 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1340
39e378da
PE
1341 * bidi.c: Integer size and overflow fixes.
1342 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1343 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1344 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1345 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1346 (bidi_find_other_level_edge):
1347 Use ptrdiff_t instead of EMACS_INT where either will do.
1348 This works better on 32-bit hosts configured --with-wide-int.
1349 (bidi_cache_ensure_space): Check for size-calculation overflow.
1350 Use % rather than repeated addition, for better worst-case speed.
1351 Don't set bidi_cache_size until after xrealloc returns, because it
1352 might not return.
1353 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1354 (bidi_cache_ensure_space): Also check that the bidi cache size
1355 does not exceed that of the largest Lisp string or buffer. See Eli
1356 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1357
5e927815
PE
1358 * alloc.c (__malloc_size_t): Remove.
1359 All uses replaced by size_t. See Andreas Schwab's note
1360 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1361
ca4aa935
PE
1362 * image.c: Improve checking for integer overflow.
1363 (check_image_size): Assume that f is nonnull, since
1364 it is always nonnull in practice. This is one less thing to
1365 worry about when checking for integer overflow later.
1366 (x_check_image_size): New function, which checks for integer
1367 overflow issues inside X.
1368 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1369 This removes the need for a memory_full check.
1370 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1371 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1372 (xbm_read_bitmap_data): Change locals back to 'int', since
1373 their values must fit in 'int'.
1374 (xpm_load_image, png_load, tiff_load):
1375 Invoke x_create_x_image_and_pixmap earlier,
1376 to avoid much needless work if the image is too large.
1377 (tiff_load): Treat overly large images as if
1378 x_create_x_image_and_pixmap failed, not as malloc failures.
1379 (gs_load): Use x_check_image_size.
1380
5f8f9cc2
PE
1381 * gtkutil.c: Omit integer casts.
1382 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1383 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1384
5adf60bc
PE
1385 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1386
c8907a93
PE
1387 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1388 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1389 would wrongly return t on a 64-bit host.
1390
e3c25c68
PE
1391 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1392 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1393 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1394 and therefore cause GCC to emit a bogus diagnostic in some cases.
1395
3f791afe
PE
1396 * image.c: Integer signedness and overflow and related fixes.
1397 This is not an exhaustive set of fixes, but it's time to
1398 record what I've got.
1399 (lookup_pixel_color, check_image_size): Remove redundant decls.
1400 (check_image_size): Don't assume that arbitrary EMACS_INT values
1401 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1402 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1403 (tiff_load, imagemagick_load_image):
1404 Check for overflow in size calculations.
1405 (x_create_x_image_and_pixmap): Remove unnecessary test for
1406 xmalloc returning NULL; that can't happen.
1407 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1408 (xpm_color_bucket): Use better integer hashing function.
1409 (xpm_cache_color): Don't possibly over-allocate memory.
1410 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1411 (gif_memory_source):
1412 Use ptrdiff_t, not int or size_t, to record sizes.
1413 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1414 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1415 either works, as we prefer signed integers.
1416 (tiff_read_from_memory, tiff_write_from_memory):
1417 Return tsize_t, not size_t, since that's what the TIFF API wants.
1418 (tiff_read_from_memory): Don't fail simply because the read would
1419 go past EOF; instead, return a short read.
1420 (tiff_load): Omit no-longer-needed casts.
1421 (Fimagemagick_types): Don't assume size fits into 'int'.
1422
3cc5a532
PE
1423 Improve hashing quality when configured --with-wide-int.
1424 * fns.c (hash_string): New function, taken from sxhash_string.
1425 Do not discard information about ASCII character case; this
1426 discarding is no longer needed.
1427 (sxhash-string): Use it. Change sig to match it. Caller changed.
1428 * lisp.h: Declare it.
1429 * lread.c (hash_string): Remove, since we now use fns.c's version.
1430 The fns.c version returns a wider integer if --with-wide-int is
1431 specified, so this should help the quality of the hashing a bit.
1432
b312a492
PE
1433 * emacs.c: Integer overflow minor fix.
1434 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1435 Define only if GNU_LINUX.
1436 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1437
dfd153ae
PE
1438 * dispnew.c: Integer signedness and overflow fixes.
1439 Remove unnecessary forward decls, that were a maintenance hassle.
1440 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1441 All uses changed.
1442 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1443 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1444 (prepare_desired_row, line_draw_cost):
1445 Use int, not unsigned, where either works.
1446 (save_current_matrix, restore_current_matrix):
1447 Use ptrdiff_t, not size_t, where either works.
1448 (init_display): Check for overflow more accurately, and without
1449 relying on undefined behavior.
1450
a81d11a3
PE
1451 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1452 Remove, replacing with the new symbols in lisp.h. All uses changed.
1453 * fileio.c (make_temp_name):
1454 * filelock.c (lock_file_1, lock_file):
1455 * xdisp.c (message_dolog):
1456 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1457 Use pMd etc. instead.
1458 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1459 replacing the pWIDE etc. symbols removed from editfns.c.
1460
3300e6fd
PE
1461 * keyboard.h (num_input_events): Now uintmax_t.
1462 This is (very slightly) less likely to mess up due to wraparound.
1463 All uses changed.
1464
fd05c7e9
PE
1465 * buffer.c: Integer signedness fixes.
1466 (alloc_buffer_text, enlarge_buffer_text):
1467 Use ptrdiff_t rather than size_t when either will do, as we prefer
1468 signed integers.
1469
903fe15d
PE
1470 * alloc.c: Integer signedness and overflow fixes.
1471 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1472 (__malloc_size_t): Default to size_t, not to int.
1473 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1474 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1475 Prefer ptrdiff_t to size_t when either would do, as we prefer
1476 signed integers.
1477 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1478 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1479 Now const. Initialize with values that are in range even if char
1480 is signed.
1481 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1482 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1483 These functions do the right thing with sizes > 2**32.
1484 (check_depth): Now ptrdiff_t, not int.
1485 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1486 Adjust to new way of storing sizes. Check for size overflow bugs
1487 in rest of code.
1488 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1489 slightly wrong anyway, as it missed one instance of
1490 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1491 (refill_memory_reserve): Omit needless cast to size_t.
1492 (mark_object_loop_halt): Mark as externally visible.
1493
ac82cc6a
PE
1494 * xselect.c: Integer signedness and overflow fixes.
1495 (Fx_register_dnd_atom, x_handle_dnd_message):
1496 Use ptrdiff_t, not size_t, since we prefer signed.
1497 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1498 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1499 x_dnd_atoms_size and x_dnd_atoms_length.
1500
c2d1e36d
PE
1501 * doprnt.c: Prefer signed to unsigned when either works.
1502 * eval.c (verror):
1503 * doprnt.c (doprnt):
1504 * lisp.h (doprnt):
1505 * xdisp.c (vmessage):
1506 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1507 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1508 prefer signed arithmetic to avoid comparison confusion.
1509 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1510 but is a bit tricky.
1511
0e926e56
PE
1512 Assume freestanding C89 headers, string.h, stdlib.h.
1513 * data.c, doprnt.c, floatfns.c, print.c:
1514 Include float.h unconditionally.
1515 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1516 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1517 * regex.c: Likewise for stddef.h, string.h.
1518 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1519 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1520 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1521 (STDC_HEADERS): Remove obsolete defines.
1522 * sysdep.c: Include limits.h unconditionally.
1523
9cfdb3ec
PE
1524 Assume support for memcmp, memcpy, memmove, memset.
1525 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1526 * regex.c (memcmp, memcpy):
1527 Remove; we assume C89 now.
1528
1529 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1530 (__malloc_safe_bcopy): Remove; no longer needed.
1531
cf950e6b 1532 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1533 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1534 well either way, and we prefer signed to unsigned.
1535
dbf38e02
LMI
15362011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1537
1538 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1539 closes the connection while we're reading (bug#9182).
1540
d6f0886c 15412011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1542
d6f0886c
JD
1543 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1544 are specified (Bug#9168).
24e0f6b1 1545
2eb1f9e6
PE
15462011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1547
1548 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1549 Found by GCC static checking and --with-wide-int on a 32-bit host.
1550
22381272 15512011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1552
1553 * xdisp.c (compute_display_string_pos): Fix logic of caching
1554 previous display string position. Initialize cached_prev_pos to
1555 -1. Fixes slow-down at the beginning of a buffer.
1556
f25e39b4
EZ
15572011-07-24 Eli Zaretskii <eliz@gnu.org>
1558
1559 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1560 for attrs[LFACE_FONTSET_INDEX].
1561
04c4b52e
PE
15622011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1563
1564 * xml.c (parse_region): Remove unused local
1565 that was recently introduced.
1566
c1734fbd
EZ
15672011-07-23 Eli Zaretskii <eliz@gnu.org>
1568
be18c5a5
EZ
1569 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1570 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1571
c1734fbd
EZ
1572 * xdisp.c (move_it_in_display_line_to): Record the best matching
1573 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1574 exit if none of the characters scanned was an exact match.
1575 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1576 when exact match is impossible due to invisible text, and the
1577 lines are truncated.
1578
a258d627
JD
15792011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1580
1581 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1582 for OSX >= 10.7.
1583
b6d5a689
EZ
15842011-07-22 Eli Zaretskii <eliz@gnu.org>
1585
0f74f785
EZ
1586 Fix a significant slow-down of cursor motion with C-n, C-p,
1587 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1588 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1589 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1590 (next_element_from_buffer): Call compute_stop_pos_backwards to
1591 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1592 base_level_stop.
1593 (reseat): Don't look for prev_stop, as that could mean a very long
1594 run.
1595 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1596 <cached_disp_overlay_modiff>: Cache for last found display string
1597 position.
551918c1 1598 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1599 about the same buffer in the same area of character positions, and
1600 the buffer wasn't changed since the time the display string
1601 position was cached.
551918c1 1602
b2d0c91a
EZ
16032011-07-22 Eli Zaretskii <eliz@gnu.org>
1604
1605 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1606 is an integer, which is important for empty lines. (Bug#9149)
1607
043604ee
CY
16082011-07-22 Chong Yidong <cyd@stupidchicken.com>
1609
1610 * frame.c (Fmodify_frame_parameters): In tty case, update the
1611 default face if necessary (Bug#4238).
1612
da4adb04
CY
16132011-07-21 Chong Yidong <cyd@stupidchicken.com>
1614
1615 * editfns.c (Fstring_to_char): No need to explain what a character
1616 is in the docstring (Bug#6576).
1617
9abd0532
LMI
16182011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1619
1620 * xml.c (parse_region): Make sure we always return a tree.
1621
36881d16
HK
16222011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1623
1624 * xml.c (parse_region): If a document contains only comments,
1625 return that, too.
1626
1e98674d
LMI
16272011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1628
1629 * xml.c (make_dom): Return comments, too.
1630
590bd467
PE
16312011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1632
1633 Port to OpenBSD.
1634 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1635 and the surrounding thread.
1636 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1637 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1638 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1639 timer goes off.
1640 * s/openbsd.h (BROKEN_SIGIO): Define.
1641 * unexelf.c (unexec) [__OpenBSD__]:
1642 Don't update the .mdebug section of the Alpha COFF symbol table.
1643
f41628b2
LMI
16442011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1645
1646 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1647 (bug#8460).
1648
b59b67c5
PE
16492011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1650
15e3a074
PE
1651 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1652 This fixes some race conditions on the permissions of any newly
1653 created file.
1654
41bed37d
PE
1655 * alloc.c (valid_pointer_p): Use pipe, not open.
1656 This fixes some permissions issues when debugging.
1657
b59b67c5
PE
1658 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1659 If fchown fails to set both uid and gid, try to set just gid,
1660 as that is sometimes allowed. Adjust the file's mode to eliminate
1661 setuid or setgid bits that are inappropriate if fchown fails.
1662
925a6be7
SM
16632011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1664
1665 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1666 to compare Lisp_Objects.
1667 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1668 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1669 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1670
52968808
AS
16712011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1672
0a6a104b
AS
1673 * lread.c (read_integer): Unread even EOF character.
1674 (read1): Likewise. Properly record start position of symbol.
1675
52968808
AS
1676 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1677 symbol character follows.
1678
9e381cdd
PE
16792011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1680
1681 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1682 This works around a problem with the previous change to Fcopy_file.
1683 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1684 and without this change, GCC might complain about discarding
1685 fchown's return value.
1686
b5641435
JB
16872011-07-16 Juanma Barranquero <lekktu@gmail.com>
1688
1689 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1690
a8031457
PE
16912011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1692
1693 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1694
dd889327
LMI
16952011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1696
750c33f7
LMI
1697 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1698 it's used from the C level.
1699
dd889327
LMI
1700 * process.c: Use the same condition for POLL_FOR_INPUT in both
1701 keyboard.c and process.c (bug#1858).
1702
87e86684
LM
17032011-07-09 Lawrence Mitchell <wence@gmx.li>
1704
1705 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1706 (Fgnutls_boot): Use it.
1707
64348f40
AS
17082011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1709
1710 * doc.c (Fsubstitute_command_keys): Revert last change.
1711
1d698799
LMI
17122011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1713
f863868c
LMI
1714 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1715 quotes the next character, and doesn't affect other longer
1716 sequences (bug#8935).
1717
1d698799
LMI
1718 * lread.c (syms_of_lread): Clarify that is isn't only
1719 `eval-buffer' and `eval-defun' that's affected by
1720 `lexical-binding' (bug#8460).
1721
aa4b6df6
EZ
17222011-07-15 Eli Zaretskii <eliz@gnu.org>
1723
1724 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1725 bidi redisplay when a line includes both an image and is
1726 truncated.
1727
5d856da6
PE
17282011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1729
ad6042bb
PE
1730 Fix minor problems found by static checking.
1731 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1732 (elsz): Now a signed constant, not a size_t var. We prefer signed
1733 types to unsigned, to avoid integer comparison confusion. Without
1734 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1735 "cannot optimize loop, the loop counter may overflow", a symptom
1736 of the confusion.
f00bbb22 1737 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1738 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1739
6468f31c
LMI
17402011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1741
49080b10
LMI
1742 * search.c (Fre_search_backward): Mention `case-fold-search' in
1743 all the re_search_* functions (bug#8138).
1744
6468f31c
LMI
1745 * keyboard.c (Fopen_dribble_file): Document when the file is
1746 closed (bug#8056).
1747
c965adc5
EZ
17482011-07-14 Eli Zaretskii <eliz@gnu.org>
1749
df9733bf
EZ
1750 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1751 bidi_cache_idx.
1752
0bb23927
EZ
1753 Support bidi reordering of display and overlay strings.
1754 * xdisp.c (compute_display_string_pos)
1755 (compute_display_string_end): Accept additional argument STRING.
1756 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1757 (reseat_to_string): Initialize bidi_it->string.s and
1758 bidi_it->string.schars.
1759 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1760 NULL (avoids a crash in bidi_paragraph_init).
1761 Initialize itb.string.lstring.
0bb23927
EZ
1762 (init_iterator): Call bidi_init_it only of a valid
1763 buffer position was specified. Initialize paragraph_embedding to
1764 L2R.
1765 (reseat_to_string): Initialize the bidi iterator.
1766 (display_string): If we need to ignore text properties of
1767 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1768 original value of -1 will not work with bidi.)
1769 (compute_display_string_pos): First arg is now struct
1770 `text_pos *'; all callers changed. Support display properties on
1771 Lisp strings.
1772 (compute_display_string_end): Support display properties on Lisp
1773 strings.
1774 (init_iterator, reseat_1, reseat_to_string): Initialize the
1775 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1776 when iterating on a string not from display properties).
640c8776
SM
1777 (compute_display_string_pos, compute_display_string_end):
1778 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1779 arrow keys.
1780 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1781 base_level_stop; instead, set base_level_stop to BEGV.
1782 Fixes crashes in vertical-motion.
0bb23927
EZ
1783 (next_element_from_buffer): Improve commentary for when
1784 the iterator is before prev_stop.
1785 (init_iterator): Initialize bidi_p from the default value of
1786 bidi-display-reordering, not from buffer-local value. Use the
1787 buffer-local value only if initializing for buffer iteration.
1788 (handle_invisible_prop): Support invisible properties on strings
1789 that are being bidi-reordered.
1790 (set_iterator_to_next): Support bidi reordering of C strings and
1791 Lisp strings.
1792 (next_element_from_string): Support bidi reordering of Lisp
1793 strings.
1794 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1795 (display_string): Support display of R2L glyph rows.
1796 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1797 (init_iterator): Don't initialize it->bidi_p for strings
1798 here.
1799 (reseat_to_string): Initialize it->bidi_p for strings here.
1800 (next_element_from_string, next_element_from_c_string)
1801 (next_element_from_buffer): Add xassert's for correspondence
1802 between IT's object being iterated and it->bidi_it.string
1803 structure.
1804 (face_before_or_after_it_pos): Support bidi iteration.
1805 (next_element_from_c_string): Handle the case of the first string
1806 character that is not the first one in the visual order.
1807 (get_visually_first_element): New function, refactored from common
1808 parts of next_element_from_buffer, next_element_from_string, and
1809 next_element_from_c_string.
1810 (tool_bar_lines_needed, redisplay_tool_bar)
1811 (display_menu_bar): Force left-to-right direction. Add a FIXME
1812 comment for making that be controlled by a user option.
1813 (push_it, pop_it): Save and restore the state of the
1814 bidi iterator. Save and restore the bidi_p flag.
1815 (pop_it): Iterate out of display property for string iteration as
1816 well.
1817 (iterate_out_of_display_property): Support iteration over strings.
1818 (handle_single_display_spec): Set up it->bidi_it for iteration
1819 over a display string, and call bidi_init_it.
1820 (handle_single_display_spec, next_overlay_string)
1821 (get_overlay_strings_1, push_display_prop): Set up the bidi
1822 iterator for displaying display or overlay strings.
1823 (forward_to_next_line_start): Don't use the shortcut if
1824 bidi-iterating.
1825 (back_to_previous_visible_line_start): If handle_display_prop
1826 pushed the iterator stack, restore the internal state of the bidi
1827 iterator by calling bidi_pop_it same number of times.
1828 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1829 and we are bidi-iterating, don't decrement the iterator position;
1830 instead, set the first_elt flag in the bidi iterator, to produce
1831 the same effect.
1832 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1833 (push_display_prop): xassert that we are iterating a buffer.
1834 (push_it, pop_it): Save and restore paragraph_embedding member.
1835 (handle_single_display_spec, next_overlay_string)
1836 (get_overlay_strings_1, reseat_1, reseat_to_string)
1837 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1838 correctly. Don't assume unibyte strings are not bidi-reordered.
1839 (compute_display_string_pos)
1840 (compute_display_string_end): Fix handling the case of C string.
1841 (push_it, pop_it): Save and restore from_disp_prop_p.
1842 (handle_single_display_spec, push_display_prop): Set the
1843 from_disp_prop_p flag.
1844 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1845 (pop_it): Call iterate_out_of_display_property only if we are
1846 popping after iteration over a string that came from a display
1847 property. Fix a typo in popping stretch info. Add an assertion
1848 for verifying that the iterator position is in sync with the bidi
1849 iterator.
1850 (handle_single_display_spec, get_overlay_strings_1)
1851 (push_display_prop): Fix initialization of paragraph direction for
1852 string when that of the parent object is not yet determined.
1853 (reseat_1): Call bidi_init_it to resync the bidi
1854 iterator with IT's position. (Bug#7616)
1855 (find_row_edges): If ROW->start.pos gives position
1856 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1857 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1858 Reset the from_disp_prop_p flag.
1859 (SAVE_IT, RESTORE_IT): New macros.
1860 (pos_visible_p, face_before_or_after_it_pos)
1861 (back_to_previous_visible_line_start)
1862 (move_it_in_display_line_to, move_it_in_display_line)
1863 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1864 (try_scrolling, redisplay_window, display_line): Use them when
1865 saving a temporary copy of the iterator and restoring it back.
1866 (back_to_previous_visible_line_start, reseat_1)
1867 (init_iterator): Empty the bidi cache "stack".
1868 (move_it_in_display_line_to): If iterator ended up at
1869 EOL, but we never saw any buffer positions smaller than
1870 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1871 motion in bidi-reordered lines.
1872 (move_it_in_display_line_to): Record prev_method and prev_pos
1873 immediately before the call to set_iterator_to_next. Fixes cursor
1874 motion in bidi-reordered lines with stretch glyphs and strings
1875 displayed in margins. (Bug#8133) (Bug#8867)
1876 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1877 TO_CHARPOS.
640c8776
SM
1878 (pos_visible_p): Support positions in bidi-reordered lines.
1879 Save and restore bidi cache.
0bb23927
EZ
1880
1881 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1882 (bidi_paragraph_info): Delete unused struct.
1883 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1884 (bidi_cache_start): New variable.
1885 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1886 to zero.
1887 (bidi_cache_fetch_state, bidi_cache_search)
1888 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1889 (bidi_cache_find, bidi_peek_at_next_level)
1890 (bidi_level_of_next_char, bidi_find_other_level_edge)
1891 (bidi_move_to_visually_next): Compare cache index with
1892 bidi_cache_start rather than with zero.
1893 (bidi_fetch_char): Accept new argument STRING; all callers
1894 changed. Support iteration over a string. Support strings with
1895 display properties. Support unibyte strings. Fix the type of
1896 `len' according to what STRING_CHAR_AND_LENGTH expects.
1897 (bidi_paragraph_init, bidi_resolve_explicit_1)
1898 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1899 (bidi_level_of_next_char, bidi_move_to_visually_next):
1900 Support iteration over a string.
0bb23927
EZ
1901 (bidi_set_sor_type, bidi_resolve_explicit_1)
1902 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1903 can now be zero (for strings); special values 0 and -1 were
1904 changed to -1 and -2, respectively.
1905 (bidi_char_at_pos): New function.
1906 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1907 Call it instead of FETCH_MULTIBYTE_CHAR.
1908 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1909 initialized to valid values.
1910 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1911 values.
1912 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1913 the test for valid cached positions. Fix the logic for looking up
1914 the sentinel state in the cache. GCPRO the Lisp string we are
1915 iterating.
1916 (bidi_push_it, bidi_pop_it): New functions.
1917 (bidi_initialize): Initialize the bidi cache start stack pointer.
1918 (bidi_cache_ensure_space): New function, refactored from part of
1919 bidi_cache_iterator_state. Don't assume the required size is just
1920 one BIDI_CACHE_CHUNK away.
1921 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1922 (bidi_count_bytes, bidi_char_at_pos): New functions.
1923 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1924 always valid if bidi_cache_idx is valid.
1925 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1926 is valid if it's going to be used.
1927 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1928 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1929 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1930 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1931 (bidi_find_other_level_edge, bidi_cache_start_stack):
1932 All variables related to cache indices are now EMACS_INT.
c965adc5 1933
0bb23927
EZ
1934 * dispextern.h (struct bidi_string_data): New structure.
1935 (struct bidi_it): New member `string'. Make flag members be 1-bit
1936 fields, and put them last in the struct.
640c8776
SM
1937 (compute_display_string_pos, compute_display_string_end):
1938 Update prototypes.
0bb23927
EZ
1939 (bidi_push_it, bidi_pop_it): Add prototypes.
1940 (struct iterator_stack_entry): New members bidi_p,
1941 paragraph_embedding, and from_disp_prop_p.
1942 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1943 (bidi_shelve_cache, bidi_unshelve_cache):
1944 Declare prototypes.
0bb23927
EZ
1945
1946 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1947 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1948 and vector-like objects.
1949
1950 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1951 cache around display iteration.
1952
1953 * window.c (Fwindow_end, window_scroll_pixel_based)
1954 (displayed_window_lines, Frecenter): Save and restore the bidi
1955 cache around display iteration.
1956
3bbd2265
LMI
19572011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1958
1959 * editfns.c (Fdelete_region): Clarify the use of the named
1960 parameters (bug#6788).
1961
adc47434
MR
19622011-07-14 Martin Rudalics <rudalics@gmx.at>
1963
1964 * indent.c (Fvertical_motion): Set and restore w->pointm when
1965 saving and restoring the window's buffer (Bug#9006).
1966
837c31f8
LMI
19672011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1968
1969 * editfns.c (Fstring_to_char): Clarify just what is returned
1970 (bug#6576). Text by Eli Zaretskii.
1971
ac389d0c
JB
19722011-07-13 Juanma Barranquero <lekktu@gmail.com>
1973
1974 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1975
0be0ce47
EZ
19762011-07-13 Eli Zaretskii <eliz@gnu.org>
1977
1978 * buffer.c (mmap_find): Fix a typo.
1979
cd18e7e3
JB
19802011-07-13 Johan Bockgård <bojohan@gnu.org>
1981
1982 Fix execution of x selection hooks.
1983 * xselect.c (Qx_lost_selection_functions)
1984 (Qx_sent_selection_functions): New vars.
1985 (syms_of_xselect): DEFSYM them.
1986 (x_handle_selection_request): Pass Qx_sent_selection_functions
1987 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1988 (x_handle_selection_clear,x_clear_frame_selections):
1989 Pass Qx_lost_selection_functions rather than
1990 Vx_lost_selection_functions to Frun_hook_with_args.
1991
47ea7f44
PE
19922011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1993
ac389d0c 1994 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1995 The old code sometimes used this field without initializing it.
1996
47ea7f44
PE
1997 * alloc.c (gc_sweep): Don't read past end of array.
1998 In theory, the old code could also have corrupted Emacs internals,
1999 though it'd be very unlikely.
2000
bc985c87
AS
20012011-07-12 Andreas Schwab <schwab@linux-m68k.org>
2002
2003 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 2004 argument. (Bug#4026)
bc985c87 2005
0cf34688
LMI
20062011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2007
b3dadd76
LMI
2008 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2009 key" (bug#4257).
2010
0cf34688
LMI
2011 * window.c (Fset_window_start): Doc fix (bug#4199).
2012 (Fset_window_hscroll): Ditto.
2013
270768cd
PE
20142011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2015
077e3dda 2016 Fix minor new problems caught by GCC 4.6.1.
270768cd 2017 * term.c (init_tty): Remove unused local.
490011a6 2018 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2019 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2020 not used otherwise.
270768cd 2021
b1f58454
CY
20222011-07-12 Chong Yidong <cyd@stupidchicken.com>
2023
2024 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2025
22b9578d
LMI
20262011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2027
6e70ab07
LMI
2028 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2029 are the mini-buffer and the echo area (bug#3320).
2030
22b9578d
LMI
2031 * term.c (init_tty): Remove support for supdup, c10 and perq
2032 terminals, which are no longer supported (bug#1482).
2033
8974cc9f
JB
20342011-07-10 Johan Bockgård <bojohan@gnu.org>
2035
2036 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2037
a560d974
JD
20382011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2039
2040 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2041 for non-popups (Bug#3642).
2042
1dae0f0a
AS
20432011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2044
268c2c36 2045 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2046 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2047 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2048 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2049 * data.c (fmod): Likewise.
2050 * dispnew.c (swap_glyphs_in_rows): Likewise.
2051 * emacs.c (memory_warning_signal): Likewise.
2052 * floatfns.c (float_error): Likewise.
2053 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2054 (otf_open, font_otf_capability, generate_otf_features)
2055 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2056 Likewise.
2057 * image.c (pbm_read_file): Likewise.
2058 * indent.c (string_display_width): Likewise.
2059 * intervals.c (check_for_interval, search_for_interval)
2060 (inc_interval_count, count_intervals, root_interval)
2061 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2062 * lread.c (defalias): Likewise.
268c2c36 2063 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2064 * regex.c (set_image_of_range_1, set_image_of_range)
2065 (regex_grow_registers): Likewise.
2066 * sysdep.c (strerror): Likewise.
2067 * termcap.c (valid_filename_p, tprint, main): Likewise.
2068 * tparam.c (main): Likewise.
2069 * unexhp9k800.c (run_time_remap, save_data_space)
2070 (update_file_ptrs, read_header, write_header, calculate_checksum)
2071 (copy_file, copy_rest, display_header): Likewise.
2072 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2073 Likewise.
2074 * xdisp.c (check_it): Likewise.
2075 * xfaces.c (register_color, unregister_color, unregister_colors):
2076 Likewise.
2077 * xfns.c (print_fontset_result): Likewise.
2078 * xrdb.c (member, fatal, main): Likewise.
2079
99033785
PE
20802011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2081
2082 Fix minor problems found by static checking (Bug#9031).
2083 * chartab.c (char_table_set_range, map_sub_char_table):
2084 Remove unused locals.
2085 (uniprop_table): Now static.
2086 * composite.c (_work_char): Remove unused static var.
2087
9cb2ac56
JB
20882011-07-09 Juanma Barranquero <lekktu@gmail.com>
2089
2090 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2091
f25661f0
JD
20922011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2093
2094 * gtkutil.c (qttip_cb): Remove code without function.
2095
8278c4fe
EZ
20962011-07-09 Eli Zaretskii <eliz@gnu.org>
2097
2098 * w32.c (pthread_sigmask): New stub.
2099
1692ae2d 21002011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2101
8a6ebd58 2102 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2103 sigprocmask is portable only for single-threaded applications, and
2104 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2105 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2106 (LIBES): Use it.
2107 * callproc.c (Fcall_process):
2108 * process.c (create_process):
2109 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2110 Use pthread_sigmask, not sigprocmask.
123403e4 2111
1b854618
JD
21122011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2113
2114 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2115 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2116 wrong (Bug#8591).
2117
3fe4b549
JD
21182011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2119
0ce7e563
JD
2120 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2121 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2122 (xg_hide_tooltip): Fix comment.
2123
3fe4b549
JD
2124 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2125 in registerServicesMenuSendTypes.
2126 (validRequestorForSendType): Don't check ns_return_types.
2127
2128 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2129 ns_return_type.
2130
5df75e47
JR
21312011-07-08 Jason Rumney <jasonr@gnu.org>
2132
2133 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2134 frame struct members of non-existent frames (Bug#6284).
2135
699c10bd
JD
21362011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2137
4393663b
JD
2138 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2139 variable firstTime not needed on OSX >= 10.6.
2140 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2141 >= 10.5. Use setKnobProportion, setDoubleValue.
2142
2143 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2144 (MAC_OS_X_VERSION_10_5): Define if not defined.
2145 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2146 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2147 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2148
2149 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2150 cString and lossyCString on OSX >= 10.4
2151
2152 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2153 sizeToFit on OSX >= 10.2.
2154
2155 * nsimage.m (allocInitFromFile): Don't use deprecated method
2156 bestRepresentationForDevice on OSX >= 10.6.
2157
2158 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2159 to avoid warning.
2160
2161 * emacs.c: Declare unexec_init_emacs_zone.
2162
a63e0781
JD
2163 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2164
699c10bd
JD
2165 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2166
2167 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2168 on svcsMenu (Bug#8842).
2169
2170 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2171 ns_return_types.
2172 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2173
2174 * nsterm.m (QUTF8_STRING): Declare.
2175 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2176 (validRequestorForSendType): Return type is (id).
2177 Change indexOfObjectIdenticalTo to indexOfObject.
2178 Check if we have local selection before returning self (Bug#8842).
2179 (writeSelectionToPasteboard): Put local selection into paste board
2180 if we have a local selection (Bug#8842).
2181 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2182
2183 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2184 (ns_get_local_selection): Declare.
2185
54e10184
LMI
21862011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2187
9888ff71
LMI
2188 * keymap.c (describe_map_tree): Don't insert a double newline at
2189 the end of the buffer (bug#1169) and return whether we inserted
2190 something.
2191
54e10184
LMI
2192 * callint.c (Fcall_interactively): Change "reading args" to
2193 "providing args" to try to clarify what it does (bug#1010).
2194
15fa4783
KH
21952011-07-07 Kenichi Handa <handa@m17n.org>
2196
2197 * composite.c (composition_compute_stop_pos): Ignore a static
2198 composition starting before CHARPOS (Bug#8915).
2199
2200 * xdisp.c (handle_composition_prop): Likewise.
2201
a8815b00
EZ
22022011-07-07 Eli Zaretskii <eliz@gnu.org>
2203
2204 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2205 (Bug#9015)
2206
ef7b981d 22072011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2208
2209 * character.h (unicode_category_t): New enum type.
2210
2211 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2212 (Qchar_code_property_table): New variable.
2213 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2214 (UNIPROP_COMPRESSED_FORM_P): New macros.
2215 (char_table_ascii): Uncompress the compressed values.
2216 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2217 Uncompress the compressed values.
ac389d0c 2218 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2219 (char_table_ref_and_range): Uncompress the compressed values.
2220 (sub_char_table_set): New arg is_uniprop. Callers changed.
2221 Uncompress the compressed values.
2222 (sub_char_table_set_range): Args changed. Callers changed.
2223 (char_table_set_range): Adjuted for the above change.
2224 (map_sub_char_table): Delete args default_val and parent. Add arg
2225 top. Give decoded values to a Lisp function.
640c8776 2226 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2227 values to a Lisp function. Gcpro more variables.
2228 (uniprop_table_uncompress)
2229 (uniprop_decode_value_run_length): New functions.
2230 (uniprop_decoder, uniprop_decoder_count): New variables.
2231 (uniprop_get_decoder, uniprop_encode_value_character)
2232 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2233 New functions.
2234 (uniprop_encoder, uniprop_encoder_count): New variables.
2235 (uniprop_get_encoder, uniprop_table)
2236 (Funicode_property_table_internal, Fget_unicode_property_internal)
2237 (Fput_unicode_property_internal): New functions.
2238 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2239 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2240 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2241 char-code-property-alist.
2242
640c8776 2243 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2244 Vunicode_category_table.
2245
640c8776 2246 * font.c (font_range): Adjust for the change of
c805dec0
KH
2247 Vunicode_category_table.
2248
76b397fb
DN
22492011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2250
2251 * m/iris4d.h: Remove file, move contents ...
2252 * s/irix6-5.h: ... here.
2253
22b4128e
PE
22542011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2255
2256 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2257 * alloc.c (mark_buffer):
2258 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2259 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2260 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2261 This isn't true in general, and it's particularly not true
2262 if Emacs is configured with --with-wide-int.
2263 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2264 New macros, used in the buffer.c change.
2265
869795d6
JD
22662011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2267
2268 * xsettings.c: Use both GConf and GSettings if both are available.
2269 (store_config_changed_event): Add comment.
2270 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2271 (store_tool_bar_style_changed): New functions.
5e617bc2 2272 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2273 (struct xsettings): Move font inside HAVE_XFT.
2274 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2275 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2276 Move inside HAVE_XFT.
640c8776 2277 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2278 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2279 also.
2280 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2281 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2282 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2283 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2284 (parse_settings): Move check for font inside HAVE_XFT.
2285 (read_settings, apply_xft_settings): Add comment.
2286 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2287 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2288 call store_font_name_changed.
2289 (xft_settings_event): Add comment.
2290 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2291 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2292 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2293 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2294 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2295 (xsettings_get_system_font, xsettings_get_system_normal_font):
2296 Add comment.
869795d6 2297
d8ed26bd
PE
22982011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2299
2300 Random fixes. E.g., (random) never returned negative values.
2301 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2302 subseconds part to the entropy, as that's a bit more random.
2303 Prefer signed to unsigned, since the signedness doesn't matter and
2304 in general we prefer signed. When given a limit, use a
2305 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2306 latter isn't right if USE_2_TAGS_FOR_INTS.
2307 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2308 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2309
cabf1cac
SM
23102011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2311
2312 * textprop.c (text_property_stickiness):
2313 Obey Vtext_property_default_nonsticky.
2314 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2315 * w32fns.c (syms_of_w32fns):
2316 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2317
6e9b2be9
PE
23182011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2319
2320 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2321 This is more efficient than Ffile_directory_p and avoids a minor race.
2322
90186c68
LMI
23232011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2324
7c301272
LMI
2325 * buffer.c (Foverlay_put): Say what the return value is
2326 (bug#7835).
2327
c4f2d8d4
LMI
2328 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2329 is a directory before asking whether to use the file name
2330 (bug#7564).
ad637907
LMI
2331 (barf_or_query_if_file_exists): Make the "File is a directory"
2332 error be more correct.
c4f2d8d4 2333
90186c68
LMI
2334 * fns.c (Frequire): Remove the mention of the .gz files, since
2335 that's installation-specific, but keep the mention of
2336 `get-load-suffixes'.
2337
da64016e
PE
23382011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2339
2340 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2341 Report string overflow if the output is too long.
2342
7d47b580
JB
23432011-07-04 Juanma Barranquero <lekktu@gmail.com>
2344
a555cb87
JB
2345 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2346 (syms_of_gnutls): Remove duplicate DEFSYM for
2347 Qgnutls_bootprop_verify_hostname_error, an error for
2348 Qgnutls_bootprop_verify_error (which is no longer used).
2349
7d47b580
JB
2350 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2351 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2352 Also (re)move comments that are misplaced or no longer relevant.
2353
1e49bfab
LMI
23542011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2355
2356 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2357
1485f4c0
CY
23582011-07-03 Chong Yidong <cyd@stupidchicken.com>
2359
2360 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2361 and background color parameters if they have been changed.
2362
a9ab721e
LMI
23632011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2364
2365 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2366
cf7cff57
PE
23672011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2368
2e13213d
PE
2369 * xsettings.c (SYSTEM_FONT): Define only when used.
2370 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2371
cf7cff57
PE
2372 * keymap.c (access_keymap_1): Now static.
2373
7a8e04f7
CY
23742011-07-02 Chong Yidong <cyd@stupidchicken.com>
2375
2376 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2377 leave any prefix arg for the up event (Bug#1586).
2378
61352f62
LMI
23792011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2380
69bb1ef7
LMI
2381 * lread.c (syms_of_lread): Mention single symbols defined by
2382 `defvar' or `defconst' (bug#7154).
2383
61352f62 2384 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2385 (Frequire): Mention get-load-suffixes.
61352f62 2386
28545e04
MR
23872011-07-02 Martin Rudalics <rudalics@gmx.at>
2388
2389 * window.h (window): Remove clone_number slot.
2390 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2391 Remove.
2392 (make_parent_window, make_window, saved_window)
2393 (Fset_window_configuration, save_window_save): Don't deal with
2394 clone numbers.
2395 * buffer.c (Qclone_number): Remove declaration.
2396 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2397
3349e122
SM
23982011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2399
2400 Add multiple inheritance to keymaps.
2401 * keymap.c (Fmake_composed_keymap): New function.
2402 (Fset_keymap_parent): Simplify.
2403 (fix_submap_inheritance): Remove.
2404 (access_keymap_1): New function extracted from access_keymap to handle
2405 embedded parents and handle lists of maps.
2406 (access_keymap): Use it.
2407 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2408 (Fcopy_keymap): Handle embedded parents.
2409 (Fcommand_remapping, define_as_prefix): Simplify.
2410 (Fkey_binding): Simplify.
2411 (syms_of_keymap): Move minibuffer-local-completion-map,
2412 minibuffer-local-filename-completion-map,
2413 minibuffer-local-must-match-map, and
2414 minibuffer-local-filename-must-match-map to Elisp.
2415 (syms_of_keymap): Defsubr make-composed-keymap.
2416 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2417 (parse_menu_item): Trivial simplification.
2418
3279eb87
GM
24192011-07-01 Glenn Morris <rgm@gnu.org>
2420
2421 * Makefile.in (SETTINGS_LIBS): Fix typo.
2422
4550efdf
KI
24232011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2424
2425 * coding.c (Fencode_coding_string): Record the last coding system
2426 used, as the function doc string says (bug#8738).
2427
0949d2b6
JD
24282011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2429
2430 * xsettings.c (store_monospaced_changed): Take new font as arg and
2431 check for change against current_mono_font.
2432 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2433 (emacs_settings_constructor, emacs_settings_get_property)
2434 (emacs_settings_set_property, emacs_settings_class_init)
2435 (emacs_settings_init, gsettings_obj): Remove.
2436 (something_changedCB): New function for HAVE_GSETTINGS.
2437 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2438 with value as argument.
2439 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2440 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2441 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2442 "changed".
2443
2444 * xgselect.c: Add defined (HAVE_GSETTINGS).
2445 (xgselect_initialize): Ditto.
2446
2447 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2448 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2449 xg_select.
2450
bbc6b304
PE
24512011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2452
2453 * eval.c (struct backtrace): Simplify and port the data structure.
2454 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2455 signed bit field, as this assumption is not portable and it makes
2456 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2457 "char debug_on_exit : 1" as this is not portable either; instead,
2458 use the portable "unsigned int debug_on_exit : 1". Remove unused
2459 member evalargs. Remove obsolete comments about cc bombing out.
2460
9851bfc5
JD
24612011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2462
51bb811f 2463 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2464 Let HAVE_GSETTINGS override HAVE_GCONF.
2465 (store_monospaced_changed): New function.
2466 (EMACS_SETTINGS): A new type derived from GObject to handle
2467 GSettings notifications.
2468 (emacs_settings_constructor, emacs_settings_get_property)
2469 (emacs_settings_set_property, emacs_settings_class_init):
2470 New functions.
2471 (gsettings_client, gsettings_obj): New variables.
2472 (GSETTINGS_SCHEMA): New define.
2473 (something_changedCB): Call store_monospaced_changed.
2474 (init_gsettings): New function.
2475 (xsettings_initialize): Call init_gsettings.
2476 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2477 to NULL.
2478
640c8776 2479 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2480 GCONF_CFLAGS/LIBS.
2481
5386012d
MR
24822011-06-29 Martin Rudalics <rudalics@gmx.at>
2483
2484 * window.c (resize_root_window, grow_mini_window)
2485 (shrink_mini_window): Rename Qresize_root_window to
2486 Qwindow_resize_root_window and Qresize_root_window_vertically to
2487 Qwindow_resize_root_window_vertically.
2488
f13e0b08
PE
24892011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2490
2491 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2492
94515237
JB
24932011-06-27 Juanma Barranquero <lekktu@gmail.com>
2494
2495 * makefile.w32-in: Redesign dependencies so they reflect more
2496 clearly which files are directly included by each source file,
2497 and not through other includes.
2498
e43b6e43
MR
24992011-06-27 Martin Rudalics <rudalics@gmx.at>
2500
2501 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2502 (sort_overlays, overlay_strings): When an overlay's clone number
2503 matches the window's clone number process the overlay even if
2504 the overlay's window property doesn't match the current window.
2505
d68443dc
MR
2506 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2507 (Fwindow_hchild): Rename to Fwindow_left_child.
2508 (Fwindow_next): Rename to Fwindow_next_sibling.
2509 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2510 (resize_window_check): Rename to window_resize_check.
2511 (resize_window_apply): Rename to window_resize_apply.
2512 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2513 (Fdelete_other_windows_internal, resize_frame_windows)
2514 (Fsplit_window_internal, Fdelete_window_internal)
2515 (grow_mini_window, shrink_mini_window)
2516 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2517
c7e73be5
JD
25182011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2519
2520 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2521 (emacs_fixed_set_min_size): Remove.
2522 (emacs_fixed_new): Take frame as argument.
2523
2524 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2525 (_EmacsFixedPrivate): Remove minwidth/height.
2526 Add struct frame *f.
2527 (emacs_fixed_init): Initialize priv->f.
2528 (get_parent_class, emacs_fixed_set_min_size): Remove.
2529 (emacs_fixed_new): Set priv->f to argument.
2530 (emacs_fixed_get_preferred_width)
2531 (emacs_fixed_get_preferred_height): Use min_width/height from
2532 frames size_hint to set minimum and natural (Bug#8919).
2533 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2534 and use min_width/height from frames size_hint to set
2535 min_width/height (Bug#8919).
2536
2537 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2538 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2539 Fix indentation.
c7e73be5 2540
cf99dcf8
EZ
25412011-06-26 Eli Zaretskii <eliz@gnu.org>
2542
2543 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2544 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2545 called at ZV.
2546
029529ac
CY
25472011-06-26 Chong Yidong <cyd@stupidchicken.com>
2548
2549 * process.c (wait_reading_process_output): Bypass select if
2550 waiting for a cell while ignoring keyboard input, and input is
2551 pending. Suggested by Jan Djärv (Bug#8869).
2552
7a7ef429
PE
25532011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2554
2555 Use gnulib's dup2 module instead of rolling our own.
2556 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2557
11fdef7d 25582011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2559
2560 * dispnew.c (scrolling_window): Before scrolling, turn off a
2561 mouse-highlight in the window being scrolled.
2562
cd3520a4
JB
25632011-06-24 Juanma Barranquero <lekktu@gmail.com>
2564
2565 Move DEFSYM to lisp.h and use everywhere.
2566
2567 * character.h (DEFSYM): Move declaration...
2568 * lisp.h (DEFSYM): ...here.
2569
2570 * gnutls.c:
2571 * minibuf.c:
2572 * w32menu.c:
2573 * w32proc.c:
2574 * w32select.c: Don't include character.h.
2575
2576 * alloc.c (syms_of_alloc):
2577 * buffer.c (syms_of_buffer):
2578 * bytecode.c (syms_of_bytecode):
2579 * callint.c (syms_of_callint):
2580 * casefiddle.c (syms_of_casefiddle):
2581 * casetab.c (init_casetab_once):
2582 * category.c (init_category_once, syms_of_category):
2583 * ccl.c (syms_of_ccl):
2584 * cmds.c (syms_of_cmds):
2585 * composite.c (syms_of_composite):
2586 * dbusbind.c (syms_of_dbusbind):
2587 * dired.c (syms_of_dired):
2588 * dispnew.c (syms_of_display):
2589 * doc.c (syms_of_doc):
2590 * editfns.c (syms_of_editfns):
2591 * emacs.c (syms_of_emacs):
2592 * eval.c (syms_of_eval):
2593 * fileio.c (syms_of_fileio):
2594 * fns.c (syms_of_fns):
2595 * frame.c (syms_of_frame):
2596 * fringe.c (syms_of_fringe):
2597 * insdel.c (syms_of_insdel):
2598 * keymap.c (syms_of_keymap):
2599 * lread.c (init_obarray, syms_of_lread):
2600 * macros.c (syms_of_macros):
2601 * msdos.c (syms_of_msdos):
2602 * print.c (syms_of_print):
2603 * process.c (syms_of_process):
2604 * search.c (syms_of_search):
2605 * sound.c (syms_of_sound):
2606 * syntax.c (init_syntax_once, syms_of_syntax):
2607 * terminal.c (syms_of_terminal):
2608 * textprop.c (syms_of_textprop):
2609 * undo.c (syms_of_undo):
2610 * w32.c (globals_of_w32):
2611 * window.c (syms_of_window):
2612 * xdisp.c (syms_of_xdisp):
2613 * xfaces.c (syms_of_xfaces):
2614 * xfns.c (syms_of_xfns):
2615 * xmenu.c (syms_of_xmenu):
2616 * xsettings.c (syms_of_xsettings):
2617 * xterm.c (syms_of_xterm): Use DEFSYM.
2618
4228cf16
TZ
26192011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2620
cd3520a4 2621 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2622
7fcccf1e
PE
26232011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2624
7efb4e0e
PE
2625 Integer and buffer overflow fixes (Bug#8873).
2626
ff5844ad
PE
2627 * print.c (printchar, strout): Check for string overflow.
2628 (PRINTPREPARE, printchar, strout):
2629 Don't set size unless allocation succeeds.
2630
90532f02
PE
2631 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2632 for sizes. Check for string overflow more accurately.
2633 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2634
6d84508d
PE
2635 * macros.c: Integer and buffer overflow fixes.
2636 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2637 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2638 Use ptrdiff_t, not int, for sizes.
2639 Don't increment bufsize until after realloc succeeds.
2640 Check for size-calculation overflow.
2641 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2642
437b2cb4
PE
2643 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2644
8b9ac8b4
PE
2645 * lread.c: Integer overflow fixes.
2646 (read_integer): Radix is now EMACS_INT, not int,
2647 to improve quality of diagnostics for out-of-range radices.
2648 Calculate buffer size correctly for out-of-range radices.
2649 (read1): Check for integer overflow in radices, and in
2650 read-circle numbers.
82cb60d3
PE
2651 (read_escape): Avoid int overflow.
2652 (Fload, openp, read_buffer_size, read1)
2653 (substitute_object_recurse, read_vector, read_list, map_obarray):
2654 Use ptrdiff_t, not int, for sizes.
2655 (read1): Use EMACS_INT, not int, for sizes.
20270765 2656 Check for size overflow.
8b9ac8b4 2657
7fcccf1e
PE
2658 * image.c (cache_image): Check for size arithmetic overflow.
2659
bfbbd7e7
PE
2660 * lread.c: Integer overflow issues.
2661 (saved_doc_string_size, saved_doc_string_length)
2662 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2663 Now ptrdiff_t, not int.
2664 (read1): Don't assume doc string length fits in int. Check for
2665 out-of-range doc string lengths.
2666 (read_list): Don't assume file position fits in int.
39019e54 2667 (read_escape): Check for hex character overflow.
bfbbd7e7 2668
4e323265
LL
26692011-06-22 Leo Liu <sdl.web@gmail.com>
2670
2671 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2672 Move to minibuffer.el.
2673
85fece3e
PE
26742011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2675
20b84ce9 2676 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2677 The following patches are for when GLYPH_DEBUG && !XASSERT.
2678 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2679 * dispnew.c (flush_stdout):
2680 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2681 Mark as externally visible.
2682 * dispnew.c (check_window_matrix_pointers): Now static.
2683 * dispnew.c (window_to_frame_vpos):
2684 * xfns.c (unwind_create_frame):
2685 * xterm.c (x_check_font): Remove unused local.
2686 * scroll.c (CHECK_BOUNDS):
2687 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2688 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2689 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2690 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2691 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2692 Now static.
2693 (debug_method_add): Use va_list and vsprintf rather than relying
2694 on undefined behavior with wrong number of arguments.
2695 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2696 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2697 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2698 since we're not interested in debugging glyphs with old libraries.
2699 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2700 GCC 4.6.0's static checking.
2701
0766b489
PE
27022011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2703
31fd4b32
PE
2704 Integer overflow and signedness fixes (Bug#8873).
2705 A few related buffer overrun fixes, too.
2706
b79e8648
PE
2707 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2708
0766b489
PE
2709 * dispextern.h (struct face.stipple):
2710 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2711 (x_bitmap_mask, x_allocate_bitmap_record)
2712 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2713 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2714 (x_create_bitmap_from_xpm_data):
2715 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2716 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2717 (.bitmaps_last):
2718 * xfaces.c (load_pixmap):
2719 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2720 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2721 (.bitmaps_last, struct x_output.icon_bitmap):
2722 Use ptrdiff_t, not int, for bitmap indexes.
2723 (x_allocate_bitmap_record): Check for size overflow.
2724 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2725
b081724f
PE
2726 Use ptrdiff_t, not int, for overlay counts.
2727 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2728 * editfns.c (overlays_around, get_pos_property):
2729 * textprop.c (get_char_property_and_overlay):
2730 * xdisp.c (next_overlay_change, note_mouse_highlight):
2731 * xfaces.c (face_at_buffer_position):
21514da7
PE
2732 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2733 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2734 (Fnext_overlay_change, Fprevious_overlay_change)
2735 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2736 Use ptrdiff_t, not int, for sizes.
21514da7 2737 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2738
3de73e5e
PE
2739 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2740
2606c57b
PE
2741 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2742 (x_session_initialize): Do not assume string length fits in int.
2743
aaafe47a
PE
2744 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2745 This is unlikely, but can occur if DPI is outlandish.
2746
2674ddc8 2747 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2748 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2749
28154962
PE
2750 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2751 * xrdb.c (magic_file_p, search_magic_path):
2752 Omit last arg SUFFIX; it was always 0. All callers changed.
2753 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2754
7de51af5
PE
2755 * xfont.c (xfont_match): Avoid need for strlen.
2756
25ed6cc3
PE
2757 * xfns.c: Don't assume strlen fits in int.
2758 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2759
4eab31dd
PE
2760 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2761 not unsigned long, as we prefer signed integers. All callers changed.
2762 Detect integer overflow in repeat count.
2763 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2764 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2765
171e2a58
PE
2766 * termcap.c: Don't assume sizes fit in int and never overflow.
2767 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2768 (gobble_line): Check for size-calculation overflow.
2769
ad39faca 2770 * minibuf.c (Fread_buffer):
6e5bb2dc 2771 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2772 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2773 Don't assume string length fits in int.
2774
52c61c22 2775 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2776 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2777
b5b8c9e5
PE
2778 * font.c: Don't assume string length fits in int.
2779 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2780 Use ptrdiff_t, not int.
ccd6111c
PE
2781 (font_intern_prop): Don't assume string length fits in int.
2782 Don't assume integer property fits in fixnum.
2783 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2784
882f0d81 2785 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2786 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2787 Reformulate so as not to need the command string.
2788 Invoke gzip -cd rather than gunzip, as it's more portable.
2789 (lock_info_type, lock_file_1, lock_file):
2790 Don't assume pid_t and time_t fit in unsigned long.
2791 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2792 (current_lock_owner): Prefer signed type for sizes.
2793 Use memcpy, not strncpy, where memcpy is what is really wanted.
2794 Don't assume (via atoi) that time_t and pid_t fit in int.
2795 Check for time_t and/or pid_t out of range, e.g., via a network share.
2796 Don't alloca where an auto var works fine.
2797
93f4cf88
PE
2798 * fileio.c: Fix some integer overflow issues.
2799 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2800 Don't assume string length fits in int.
2801 (directory_file_name): Don't assume string length fits in long.
2802 (make_temp_name): Don't assume pid fits in int, or that its print
2803 length is less than 20.
2804
f3e92b69
PE
2805 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2806
1bfdaf10
PE
2807 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2808
35016e9a
PE
2809 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2810
3d1e65a1
PE
2811 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2812 We prefer signed integers, even for size calculations.
2813
0b963a93
PE
2814 * emacs.c: Don't assume string length fits in 'int'.
2815 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2816 (main): Don't invoke strlen when not needed.
2817
573f4b54
PE
2818 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2819 (XD_DEBUG_MESSAGE): Don't waste a byte.
2820
989f33ba
PE
2821 * callproc.c (getenv_internal_1, getenv_internal)
2822 (Fgetenv_internal):
965d34eb
PE
2823 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2824
e4d29b33
PE
2825 * lread.c (invalid_syntax): Omit length argument.
2826 All uses changed. This doesn't fix a bug, but it simplifies the
2827 code away from its former Hollerith-constant appearance, and it's
2828 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2829 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2830
eb49b136
PE
2831 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2832 This didn't break anything, but it didn't help either.
2833 It's confusing to put a bogus integer in a place where the actual
2834 value does not matter.
9f62aeb1 2835 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2836 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2837
15375a22
PE
2838 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2839 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2840 implementation.
b61cc01c
PE
2841 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2842 We prefer signed types, and the value cannot exceed the EMACS_INT
2843 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2844 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2845 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2846 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2847
53b2623d
PE
2848 * indent.c (sane_tab_width): New function.
2849 (current_column, scan_for_column, Findent_to, position_indentation)
2850 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2851 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2852
51cab52b 2853 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2854
f2ed8a70
PE
2855 * lisp.h (lint_assume): New macro.
2856 * composite.c (composition_gstring_put_cache):
2857 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2858
abe80cc6
PE
2859 * editfns.c, insdel.c:
2860 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2861
b02c740e
PE
2862 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2863
ebc96716
PE
2864 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2865
b4e50fa0 2866 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2867 Use much-faster test for byte-length change.
311d5d7c 2868 Don't assume string byte-length fits in 'int'.
a4cf38e4 2869 Check that character arg fits in 'int'.
85461888 2870 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2871
c0c1ee9f
PE
2872 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2873
a498d7f4
PE
2874 * fns.c (concat): Catch string overflow earlier.
2875 Do not rely on integer wraparound.
2876
51cab52b
PE
2877 * dispextern.h (struct it.overlay_strings_charpos)
2878 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2879 * xdisp.c (forward_to_next_line_start)
2880 (back_to_previous_visible_line_start)
2881 (reseat_at_next_visible_line_start, next_element_from_buffer):
2882 Don't arbitrarily truncate the value of 'selective' to int.
2883
76031fad
PE
2884 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2885
5eb55db9
PE
2886 * composite.c: Don't truncate sizes to 'int'.
2887 (composition_gstring_p, composition_reseat_it)
2888 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2889 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2890 not EMACS_UINT, for indexes.
5eb55db9 2891
0703a717
PE
2892 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2893
d6202519
PE
2894 * buffer.c: Include <verify.h>.
2895 (struct sortvec.priority, struct sortstr.priority):
8961a454 2896 Now EMACS_INT, not int.
c20998a7 2897 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2898 (struct sortstr.size, record_overlay_string)
2899 (struct sortstrlist.size, struct sortlist.used):
2900 Don't truncate size to int.
2901 (record_overlay_string): Check for size-calculation overflow.
d6202519 2902 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2903
d5a19415
JM
29042011-06-22 Jim Meyering <meyering@redhat.com>
2905
029529ac 2906 Don't leak an XBM-image-sized buffer
d5a19415
JM
2907 * image.c (xbm_load): Free the image buffer after using it.
2908
a9041e6c
PE
29092011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2910
2911 Port to Sun C.
2912 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2913 that Sun C diagnosed.
2914 * fns.c (secure_hash): Fix pointer signedness issue.
2915 * intervals.c (static_offset_intervals): New function.
2916 (offset_intervals): Use it.
2917
7f3f739f
LL
29182011-06-21 Leo Liu <sdl.web@gmail.com>
2919
2920 * deps.mk (fns.o):
2921 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2922 sha512.h.
2923
2924 * fns.c (secure_hash): Rename from crypto_hash_function and change
2925 the first arg to accept symbols.
5b66d427 2926 (Fsecure_hash): New primitive.
7f3f739f
LL
2927 (syms_of_fns): New symbols.
2928
76147d94
DD
29292011-06-20 Deniz Dogan <deniz@dogan.se>
2930
2931 * process.c (Fset_process_buffer): Clarify return value in
2932 docstring.
2933
7d7d0045
CY
29342011-06-18 Chong Yidong <cyd@stupidchicken.com>
2935
2936 * dispnew.c (add_window_display_history): Use BVAR.
2937
2938 * xdisp.c (debug_method_add): Use BVAR.
2939 (check_window_end, dump_glyph_matrix, dump_glyph)
2940 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2941
2942 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2943 Likewise.
2944
2945 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2946 check till after the cache is created in init_frame_faces.
2947
ff2bc410
SM
29482011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2949
2950 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2951
28177add
PE
29522011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2953
dd3482fe
PE
2954 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2955 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2956 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2957
393d71f3 2958 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2959 * fileio.c (Finsert_file_contents):
2960 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2961 Remove the old (too-loose) buffer overflow checks.
2962 They weren't needed, since make_gap checks for buffer overflow.
2963 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2964 The old code merely checked for Emacs fixnum overflow, and relied
2965 on undefined (wraparound) behavior. The new code avoids undefined
2966 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2967
2e6813b0 2968 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2969 Tune. Don't use wider integers than needed. Don't use alloca.
2970 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2971
599a9e4f
PE
2972 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2973
99561444
PE
2974 * insdel.c, lisp.h (buffer_overflow): New function.
2975 (insert_from_buffer_1, replace_range, replace_range_2):
2976 * insdel.c (make_gap_larger):
2977 * editfns.c (Finsert_char):
2978 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2979
28177add
PE
2980 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2981
e69dafad
PE
29822011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2983
a7af7fde 2984 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2985
b1c46f02
PE
2986 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2987 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2988
e69dafad
PE
2989 * fileio.c: Don't assume EMACS_INT fits in off_t.
2990 (emacs_lseek): New static function.
2991 (Finsert_file_contents, Fwrite_region): Use it.
2992 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2993
566684ea
PE
2994 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2995
e6966cd6
PE
2996 * fns.c: Don't overflow int when computing a list length.
2997 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2998 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2999 truncation on 64-bit hosts. Check for QUIT every
3000 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
3001 faster and is responsive enough.
3002 (Flength): Report an error instead of overflowing an integer.
3003 (Fsafe_length): Return a float if the value is not representable
3004 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3005 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3006 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3007
dd0b0efb
PE
3008 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3009 (header_size, word_size): New constants.
3010 (allocate_vectorlike): Don't check size overflow here.
3011 (allocate_vector): Check it here instead, since this is the only
3012 caller of allocate_vectorlike that could cause overflow.
3013 Check that the new vector's length is representable as a fixnum.
3014
86fe5cfe
PE
3015 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3016 The previous code was bogus. For example, next_almost_prime (32)
3017 returned 39, which is undesirable as it is a multiple of 3; and
3018 next_almost_prime (24) returned 25, which is a multiple of 5 so
3019 why was the code bothering to check for multiples of 7?
3020
80e88859
PE
3021 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3022
4a2f0ad6
PE
3023 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3024
f66c7cf8
PE
3025 Variadic C functions now count arguments with ptrdiff_t.
3026 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3027 Back then I didn't know that the Emacs coding style prefers signed int.
3028 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3029 were being counted with int, which may truncate counts on 64-bit
3030 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3031 * lisp.h (struct Lisp_Subr.function.aMANY)
3032 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3033 Arg counts are now ptrdiff_t, not size_t.
3034 All variadic functions and their callers changed accordingly.
3035 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3036 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3037 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3038 * callint.c (Fcall_interactively): Check arg count for overflow,
3039 to avoid potential buffer overrun. Use signed char, not 'int',
3040 for 'varies' array, so that we needn't bother to check its size
3041 calculation for overflow.
3042 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3043 * eval.c (apply_lambda):
3044 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3045 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3046 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3047
a1759b76
PE
3048 * callint.c (Fcall_interactively): Don't use index var as event count.
3049
d96be9fc
PE
3050 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3051 * mem-limits.h (SIZE): Remove; no longer used.
3052
a690a978 3053 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3054
578c21e6
PE
3055 Remove unnecessary casts.
3056 * xterm.c (x_term_init):
3057 * xfns.c (x_set_border_pixel):
3058 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3059 These aren't needed now that we assume ANSI C.
3060
96f53c6c
PE
3061 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3062 It's more likely to cause problems (due to unsigned overflow)
3063 than to cure them.
3064
83c77d31
PE
3065 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3066
ee2079f1
PE
3067 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3068
6da65536
PE
3069 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3070
7147c4a4
PE
3071 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3072
193e32d9
PE
3073 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3074
e5533da6
PE
3075 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3076
9910e595
PE
3077 GLYPH_CODE_FACE returns EMACS_INT, not int.
3078 * dispextern.h (merge_faces):
3079 * xfaces.c (merge_faces):
01103c44
PE
3080 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3081 Don't assume EMACS_INT fits in int.
9910e595 3082
2638320e
PE
3083 * character.h (CHAR_VALID_P): Remove unused parameter.
3084 * fontset.c, lisp.h, xdisp.c: All uses changed.
3085
045eb8d9
PE
3086 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3087
c1f134b5
PE
3088 * fns.c (concat): Minor tuning based on overflow analysis.
3089 This doesn't fix any bugs. Use int to hold character, instead
3090 of constantly refetching from Emacs object. Use XFASTINT, not
3091 XINT, for value known to be a character. Don't bother comparing
3092 a single byte to 0400, as it's always less.
3093
395fcb93 3094 * floatfns.c (Fexpt):
327eeec8
PE
3095 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3096
abbd3d23
PE
3097 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3098 for characters.
3099
684a03ef
PE
3100 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3101
0fed43f3
PE
3102 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3103 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3104 incorrectly succeed when S was a string, because 4294967386 was
3105 truncated before it was used.
3106
8fd02eb7
PE
3107 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3108 Otherwise, an out-of-range integer could cause undefined behavior
3109 on a 64-bit host.
3110
f8c86b69
PE
3111 * composite.c: Use int, not EMACS_INT, for characters.
3112 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3113 EMACS_INT, for values that are known to be in character range.
3114 This doesn't fix any bugs but is the usual style inside Emacs and
3115 may generate better code on 32-bit machines.
3116
34206dd2
PE
3117 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3118 This is for reasons similar to the recent CHAR_STRING fix.
3119 * charset.c (Fencode_char): Check that character arg is actually
3120 a character. Pass an int to ENCODE_CHAR.
3121 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3122 wider than 'int', as a compile-time check to prevent future regressions
3123 in this area.
3124
c5958d4c 3125 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3126
3127 Make sure a 64-bit char is never passed to CHAR_STRING.
3128 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3129 by silently ignoring the top 32 bits, allowing some values
3130 that were far too large to be valid characters.
3131 * character.h: Include <verify.h>.
3132 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3133 arguments are no wider than unsigned, as a compile-time check
3134 to prevent future regressions in this area.
3135 * data.c (Faset):
01103c44 3136 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3137 (Fsubst_char_in_region):
3138 * fns.c (concat):
3139 * xdisp.c (decode_mode_spec_coding):
3140 Adjust to CHAR_STRING's new requirement.
3141 * editfns.c (Finsert_char, Fsubst_char_in_region):
3142 * fns.c (concat): Check that character args are actually
3143 characters. Without this test, these functions did the wrong
3144 thing with wildly out-of-range values on 64-bit hosts.
3145
d37ca623
PE
3146 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3147 These casts should not be needed on 32-bit hosts, either.
3148 * keyboard.c (read_char):
3149 * lread.c (Fload): Remove casts to unsigned.
3150
ea204efb
PE
3151 * lisp.h (UNSIGNED_CMP): New macro.
3152 This fixes comparison bugs on 64-bit hosts.
3153 (ASCII_CHAR_P): Use it.
3154 * casefiddle.c (casify_object):
01103c44 3155 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3156 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3157 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3158 * dispextern.h (FACE_FROM_ID):
3159 * keyboard.c (read_char): Use UNSIGNED_CMP.
3160
41cb286c
PE
3161 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3162 not to EMACS_INT, to avoid GCC warning.
3163
4a1b9832
PE
3164 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3165
55daad71
PE
3166 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3167 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3168 isn't needed on 32-bit machines.
8f95c75c 3169
01103c44
PE
3170 * buffer.c (Fgenerate_new_buffer_name):
3171 Use EMACS_INT for count, not int.
0ceccced 3172 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3173
3174 * data.c (Qcompiled_function): Now static.
3175
c6f072e7
PE
3176 * window.c (window_body_lines): Now static.
3177
20ce5912
PE
3178 * image.c (gif_load): Rename local to avoid shadowing.
3179
9c4c5f81
PE
3180 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3181 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3182 * alloc.c (make_save_value): Integer argument is now of type
3183 ptrdiff_t, not int.
3184 (mark_object): Use ptrdiff_t, not int.
3185 * lisp.h (pD): New macro.
3186 * print.c (print_object): Use it.
3187
c0c5c8ae
PE
3188 * alloc.c: Use EMACS_INT, not int, to count objects.
3189 (total_conses, total_markers, total_symbols, total_vector_size)
3190 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3191 (total_free_floats, total_floats, total_free_intervals)
3192 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3193 Now EMACS_INT, not int. All uses changed.
3194 (Fgarbage_collect): Compute overall total using a double, so that
3195 integer overflow is less likely to be a problem. Check for overflow
3196 when converting back to an integer.
5a25e253
PE
3197 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3198 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3199 These were 'int' variables that could overflow on 64-bit hosts;
3200 they were never used, so remove them instead of repairing them.
211a0b2a 3201 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3202 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3203 Previously, this ceilinged at INT_MAX, but that doesn't work on
3204 64-bit machines.
e46bb31a 3205 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3206
c78baabf 3207 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3208 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3209 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3210 when a (possibly-narrower) signed value would do just as well.
3211 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3212
c9d624c6
PE
3213 * alloc.c: Catch some string size overflows that we were missing.
3214 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3215 for convenience in STRING_BYTES_MAX.
3216 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3217 The definition here is exact; the one in lisp.h was approximate.
3218 (allocate_string_data): Check for string overflow. This catches
3219 some instances we weren't catching before. Also, it catches
3220 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3221 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3222 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3223
c9d624c6
PE
3224 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3225 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3226 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3227
353032ce
PE
3228 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3229
2bccce07
PE
3230 * alloc.c (Fmake_string): Check for out-of-range init.
3231
0ac30604
SM
32322011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3233
3234 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3235
c195f2de
JD
32362011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3237
3238 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3239 xg_get_default_scrollbar_width.
3240
3241 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3242 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3243 (style_changed_cb): Call update_theme_scrollbar_width and call
3244 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3245 all frames (Bug#8505).
3246 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3247 Call gtk_window_set_resizable if HAVE_GTK3.
3248 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3249 and height if HAVE_GTK3 (Bug#8505).
3250 (scroll_bar_width_for_theme): New variable.
3251 (update_theme_scrollbar_width): New function.
3252 (xg_get_default_scrollbar_width): Move code to
3253 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3254 (xg_initialize): Call update_theme_scrollbar_width.
3255
3256 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3257
3258 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3259
e10ac9f1
MR
32602011-06-12 Martin Rudalics <rudalics@gmx.at>
3261
3262 * frame.c (make_frame): Call other_buffer_safely instead of
3263 other_buffer.
3264
3265 * window.c (temp_output_buffer_show): Call display_buffer with
3266 second argument Vtemp_buffer_show_specifiers and reset latter
3267 immediately after the call.
3268 (Vtemp_buffer_show_specifiers): New variable.
3269 (auto_window_vscroll_p, next_screen_context_lines)
3270 (Vscroll_preserve_screen_position): Remove leading asterisks from
3271 doc-strings.
3272
2d3c217e 32732011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3274
7b7f97e8 3275 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3276 * buffer.c (Qclone_number): Remove for now, as it's unused.
3277 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3278 (record_buffer): Remove unused local.
3279 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3280 (set_frame_buffer_list): Remove; unused.
3281 * frame.h (other_visible_frames): Remove decl.
3282 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3283 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3284 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3285 if HAVE_GPM.
3286 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3287 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3288 Define only if HAVE_GPM.
3289 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3290 (update_hints_inhibit): Remove; never set. All uses removed.
3291 * widgetprv.h (emacsFrameClassRec): Remove decl.
3292 * window.c (delete_deletable_window): Now returns void, since it
3293 wasn't returning anything.
3294 (compare_window_configurations): Remove unused locals.
3295 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3296 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3297 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3298 the same widths as pointers. This follows up on the 2011-05-06 patch.
3299 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3300 * xterm.h: Likewise.
3301 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3302
1384b89e
JB
33032011-06-12 Juanma Barranquero <lekktu@gmail.com>
3304
3305 * makefile.w32-in: Update dependencies.
3306 (LISP_H): Add lib/intprops.h.
3307
1100a63c
CY
33082011-06-11 Chong Yidong <cyd@stupidchicken.com>
3309
3310 * image.c (gif_load): Add animation frame delay to the metadata.
3311 (syms_of_image): Use DEFSYM. New symbol `delay'.
3312
6198ccd0
MR
33132011-06-11 Martin Rudalics <rudalics@gmx.at>
3314
3315 * window.c (delete_deletable_window): Re-add.
3316 (Fset_window_configuration): Rewrite to handle dead buffers and
3317 consequently deletable windows.
3318 (window_tree, Fwindow_tree): Remove. Supply functionality in
3319 window.el.
3320 (compare_window_configurations): Simplify code.
3321
b6e3633c
AS
33222011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3323
1ab0dee5
AS
3324 * image.c (imagemagick_load_image): Fix type mismatch.
3325 (Fimagemagick_types): Likewise.
3326
b6e3633c
AS
3327 * window.h (replace_buffer_in_windows): Declare.
3328
9397e56f
MR
33292011-06-11 Martin Rudalics <rudalics@gmx.at>
3330
3331 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3332 Qclone_number. Remove external declaration of Qdelete_window.
3333 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3334 code.
640c8776
SM
3335 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3336 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3337 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3338 buffer list implementation.
3339 (other_buffer_safely): New function.
3340 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3341 calls to replace_buffer_in_windows and
3342 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3343 if allowed.
3344 (record_buffer): Inhibit quitting and rewrite using quittable
3345 functions. Run Qbuffer_list_update_hook if allowed.
3346 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3347 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3348 Move switch-to-buffer to window.el.
9397e56f
MR
3349 (bury-buffer): Move to window.el.
3350 (Vbuffer_list_update_hook): New variable.
3351
3352 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3353 section.
3354
3355 * window.h (resize_frame_windows): Move up in code.
3356 (Fwindow_frame): Remove EXFUN.
3357 (replace_buffer_in_all_windows): Remove prototype.
3358 (replace_buffer_in_windows_safely): Add prototype.
3359
3360 * window.c: Declare Qdelete_window static again. Move down
3361 declaration of select_count.
3362 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3363 (Fother_window): Move to window.el.
3364 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3365 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3366 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3367 window.el.
3368 (replace_buffer_in_windows): Implement by calling
3369 Qreplace_buffer_in_windows.
3370 (replace_buffer_in_all_windows): Remove with some functionality
3371 moved into replace_buffer_in_windows_safely.
3372 (replace_buffer_in_windows_safely): New function.
3373 (select_window_norecord, select_frame_norecord): Move in front
3374 of run_window_configuration_change_hook. Remove now obsolete
3375 declarations.
640c8776
SM
3376 (Fset_window_buffer): Rewrite doc-string.
3377 Call Qrecord_window_buffer.
9397e56f
MR
3378 (keys_of_window): Move binding for other-window to window.el.
3379
b50691aa
CY
33802011-06-11 Chong Yidong <cyd@stupidchicken.com>
3381
3382 * dispextern.h (struct image): Replace data member, whose int_val
3383 and ptr_val fields were not used by anything, with a single
3384 lisp_val object.
3385
3386 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3387 (gif_clear_image, gif_load, imagemagick_load_image)
3388 (gs_clear_image, gs_load): Callers changed.
3389
3f754b86
PE
33902011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3391
cca69397
PE
3392 * buffer.h: Include <time.h>, for time_t.
3393 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3394
109e28d0
PE
3395 Fix minor problems found by static checking.
3396
60737f02
PE
3397 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3398
4b66faf3
PE
3399 Make identifiers static if they are not used in other modules.
3400 * data.c (Qcompiled_function, Qframe, Qvector):
3401 * image.c (QimageMagick, Qsvg):
3402 * minibuf.c (Qmetadata):
3403 * window.c (resize_window_check, resize_root_window): Now static.
3404 * window.h (resize_window_check, resize_root_window): Remove decls.
3405
109e28d0
PE
3406 * window.c (window_deletion_count, delete_deletable_window):
3407 Remove; unused.
46a4ce9e
PE
3408 (window_body_lines): Now static.
3409 (Fdelete_other_windows_internal): Mark vars as initialized.
3410 Make sure 'resize_failed' is initialized.
3411 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3412 (resize_window_apply): Remove unused local.
3413 * window.h (delete_deletable_window): Remove decl.
3414
109e28d0 3415 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3416 (imagemagick_load_image): Fix pointer signedness problem by changing
3417 last arg from unsigned char * to char *. All uses changed.
3418 Also, fix a local for similar reasons.
3419 Remove unused locals. Remove locals to avoid shadowing.
3420 (fn_rsvg_handle_free): Remove; unused.
3421 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3422 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3423
3f754b86
PE
3424 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3425
2547adb1
CY
34262011-06-10 Chong Yidong <cyd@stupidchicken.com>
3427
3428 * image.c (gif_load): Fix omitted cast error introduced by
3429 2011-06-06 change.
3430
2c8e37d4
MR
34312011-06-10 Martin Rudalics <rudalics@gmx.at>
3432
3433 * window.h (resize_proportionally, orig_total_lines)
3434 (orig_top_line): Remove from window structure.
3435 (set_window_height, set_window_width, change_window_heights)
3436 (Fdelete_window): Remove prototypes.
3437 (resize_frame_windows): Remove duplicate declaration.
3438
440a42e3
EZ
34392011-06-10 Eli Zaretskii <eliz@gnu.org>
3440
3441 * window.h (resize_frame_windows, resize_window_check)
3442 (delete_deletable_window, resize_root_window)
3443 (resize_frame_windows): Declare prototypes.
3444
3445 * window.c (resize_window_apply): Make definition be "static" to
3446 match the prototype.
3447
562dd5e9
MR
34482011-06-10 Martin Rudalics <rudalics@gmx.at>
3449
3450 * window.c: Remove declarations of Qwindow_size_fixed,
3451 window_min_size_1, window_min_size_2, window_min_size,
3452 size_window, window_fixed_size_p, enlarge_window, delete_window.
3453 Remove static from declaration of Qdelete_window, it's
3454 temporarily needed by Fbury_buffer.
3455 (replace_window): Don't assign orig_top_line and
3456 orig_total_lines.
3457 (Fdelete_window, delete_window): Remove. Window deletion is
3458 handled by window.el.
640c8776
SM
3459 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3460 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3461 (Fdelete_other_windows): Remove. Deleting other windows is
3462 handled by window.el.
3463 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3464 handled in window.el.
3465 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3466 Window minimum sizes are handled in window.el.
3467 (shrink_windows, size_window, set_window_height)
3468 (set_window_width, change_window_heights, window_height)
3469 (window_width, CURBEG, CURSIZE, enlarge_window)
3470 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3471 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3472 handled in window.el.
3473 (make_dummy_parent): Rename to make_parent_window and give it a
3474 second argument horflag.
3475 (make_window): Don't set resize_proportionally any more.
3476 (Fsplit_window): Remove. Windows are split in window.el.
3477 (save_restore_action, save_restore_orig_size)
3478 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3479 Resize mini windows in window.el.
3480 (grow_mini_window, shrink_mini_window): Implement by calling
3481 Qresize_root_window_vertically, resize_window_check and
3482 resize_window_apply.
640c8776
SM
3483 (saved_window, Fset_window_configuration, save_window_save):
3484 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3485 resize_proportionally.
3486 (window_min_height, window_min_width): Move to window.el.
3487 (keys_of_window): Move bindings for delete-other-windows,
3488 split-window, delete-window and enlarge-window to window.el.
3489
3490 * buffer.c: Temporarily extern Qdelete_window.
3491 (Fbury_buffer): Temporarily call Qdelete_window instead of
3492 Fdelete_window (Fbury_buffer will move to window.el soon).
3493
3494 * frame.c (set_menu_bar_lines_1): Remove code handling
3495 orig_top_line and orig_total_lines.
3496
3497 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3498 set_window_height but set heights directly.
3499 (change_frame_size_1): Use resize_frame_windows.
3500
3501 * xdisp.c (init_xdisp): Don't use set_window_height but set
3502 heights directly.
3503
640c8776
SM
3504 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3505 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3506 run_window_configuration_change_hook.
3507
3508 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3509 instead of change_window_heights and run
3510 run_window_configuration_change_hook.
3511
1a13852e
MR
35122011-06-09 Martin Rudalics <rudalics@gmx.at>
3513
3514 * window.c (replace_window): Rename second argument REPLACEMENT to
3515 NEW. New third argument SETFLAG. Rewrite.
3516 (delete_window, make_dummy_parent): Call replace_window with
3517 third argument 1.
3518 (window_list_1): Move down in code.
3519 (run_window_configuration_change_hook): Move set_buffer part
3520 before select_frame_norecord part in order to unwind correctly.
3521 Rename count1 to count.
3522 (recombine_windows, delete_deletable_window, resize_root_window)
3523 (Fdelete_other_windows_internal)
3524 (Frun_window_configuration_change_hook, make_parent_window)
3525 (resize_window_check, resize_window_apply, Fresize_window_apply)
3526 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3527 (Fdelete_window_internal, Fresize_mini_window_internal):
3528 New functions.
1a13852e
MR
3529 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3530
f3d1777e
MR
35312011-06-08 Martin Rudalics <rudalics@gmx.at>
3532
496e208e
MR
3533 * window.h (window): Add some new members to window structure -
3534 normal_lines, normal_cols, new_total, new_normal, clone_number,
3535 splits, nest, prev_buffers, next_buffers.
3536 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3537 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3538
f3d1777e
MR
3539 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3540 Remove.
496e208e
MR
3541 (make_dummy_parent): Set new members of windows structure.
3542 (make_window): Move down in code. Handle new members of window
3543 structure.
3544 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3545 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3546 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3547 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3548 (Fset_window_next_buffers, Fset_window_clone_number):
3549 New functions.
496e208e
MR
3550 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3551 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3552 Doc-string fixes.
3553 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3554 Argument WINDOW can be now internal window too.
3555 (Fwindow_use_time): Move up in code.
3556 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3557 Rewrite doc-string.
3558 (Fset_window_configuration, saved_window)
3559 (Fcurrent_window_configuration, save_window_save): Handle new
3560 members of window structure.
b9e809c2
MR
3561 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3562 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3563 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3564 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3565 Qget_mru_window, Qresize_root_window,
3566 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3567 Qauto_buffer_name; staticpro them.
f3d1777e 3568
abde8f8c
MR
35692011-06-07 Martin Rudalics <rudalics@gmx.at>
3570
3571 * window.c (Fwindow_total_size, Fwindow_left_column)
3572 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3573 (Fwindow_list_1): New functions.
3574 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3575 (Fwindow_width, Fscroll_left, Fscroll_right):
3576 Use window_body_cols instead of window_box_text_cols.
3577 (delete_window, Fset_window_configuration):
3578 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3579 (delete_all_subwindows): Take a window as argument and not a
3580 structure. Rewrite.
190b47e6
MR
3581 (window_loop): Remove handling of GET_LRU_WINDOW and
3582 GET_LARGEST_WINDOW.
3583 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3584
3585 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3586 window_box_text_cols. delete_all_subwindows now takes a
3587 Lisp_Object as argument.
abde8f8c 3588
640c8776
SM
3589 * indent.c (compute_motion, Fcompute_motion):
3590 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3591
fa8a67e6
MR
3592 * frame.c (delete_frame): Call delete_all_subwindows with root
3593 window as argument.
3594
a54e3482
DC
35952011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3596
3597 * fns.c (Fputhash): Document return value.
3598
60002bf5
CY
35992011-06-06 Chong Yidong <cyd@stupidchicken.com>
3600
3601 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3602
0c671da6 36032011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3604
b862a52a 3605 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3606
be44ca6c
PE
3607 Check for overflow when converting integer to cons and back.
3608 * charset.c (Fdefine_charset_internal, Fdecode_char):
3609 Use cons_to_unsigned to catch overflow.
3610 (Fencode_char): Use INTEGER_TO_CONS.
3611 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3612 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3613 * data.c (long_to_cons, cons_to_long): Remove.
3614 (cons_to_unsigned, cons_to_signed): New functions.
3615 These signal an error for invalid or out-of-range values.
3616 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3617 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3618 * font.c (Ffont_variation_glyphs):
3619 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3620 * lisp.h: Include <intprops.h>.
3621 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3622 (cons_to_signed, cons_to_unsigned): New decls.
3623 (long_to_cons, cons_to_long): Remove decls.
3624 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3625 (Fprimitive_undo): Use CONS_TO_INTEGER.
3626 * xfns.c (Fx_window_property): Likewise.
3627 * xselect.c: Include <limits.h>.
3628 (x_own_selection, selection_data_to_lisp_data):
3629 Use INTEGER_TO_CONS.
3630 (x_handle_selection_request, x_handle_selection_clear)
3631 (x_get_foreign_selection, Fx_disown_selection_internal)
3632 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3633 (lisp_data_to_selection_data): Use cons_to_unsigned.
3634 (x_fill_property_data): Use cons_to_signed.
3635 Report values out of range.
3636
d1f3d2af
PE
3637 Check for buffer and string overflow more precisely.
3638 * buffer.h (BUF_BYTES_MAX): New macro.
3639 * lisp.h (STRING_BYTES_MAX): New macro.
3640 * alloc.c (Fmake_string):
3641 * character.c (string_escape_byte8):
3642 * coding.c (coding_alloc_by_realloc):
3643 * doprnt.c (doprnt):
3644 * editfns.c (Fformat):
3645 * eval.c (verror):
3646 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3647 since they may not be the same number.
3648 * editfns.c (Finsert_char):
3649 * fileio.c (Finsert_file_contents):
3650 Likewise for BUF_BYTES_MAX.
3651
dd52fcea
PE
3652 * image.c: Use ptrdiff_t, not int, for sizes.
3653 (slurp_file): Switch from int to ptrdiff_t.
3654 All uses changed.
3655 (slurp_file): Check that file size fits in both size_t (for
3656 malloc) and ptrdiff_t (for sanity and safety).
3657
7f9bbdbb
PE
3658 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3659 if b->modtime has its maximal value.
3660
dfe18f82
PE
3661 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3662
84acfcf0
PE
3663 Don't assume time_t can fit into int.
3664 * buffer.h (struct buffer.modtime): Now time_t, not int.
3665 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3666 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3667
ccd9a01a
PE
3668 Minor fixes for signed vs unsigned integers.
3669 * character.h (MAYBE_UNIFY_CHAR):
3670 * charset.c (maybe_unify_char):
3671 * keyboard.c (read_char, reorder_modifiers):
3672 XINT -> XFASTINT, since the integer must be nonnegative.
3673 * ftfont.c (ftfont_spec_pattern):
3674 * keymap.c (access_keymap, silly_event_symbol_error):
3675 XUINT -> XFASTINT, since the integer must be nonnegative.
3676 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3677 since it makes no difference and we prefer signed.
3678 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3679 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3680 nonnegative.
3681
d6d100dd
SM
36822011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3683
3684 * window.h (Fwindow_frame): Declare.
3685
2b6148e4
PE
36862011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3687
3688 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3689 (SPARE_MEMORY): Always define.
3690 (LARGE_REQUEST): Remove.
3691 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3692
f230ecc9
MR
36932011-06-06 Martin Rudalics <rudalics@gmx.at>
3694
727e958e
MR
3695 * lisp.h: Move EXFUNS for Fframe_root_window,
3696 Fframe_first_window and Fset_frame_selected_window to window.h.
3697
3698 * window.h: Move EXFUNS for Fframe_root_window,
3699 Fframe_first_window and Fset_frame_selected_window here from
3700 lisp.h.
3701
3702 * frame.c (Fwindow_frame, Fframe_first_window)
3703 (Fframe_root_window, Fframe_selected_window)
3704 (Fset_frame_selected_window): Move to window.c.
3705 (Factive_minibuffer_window): Move to minibuf.c.
3706 (Fother_visible_frames_p): New function.
3707
3708 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3709
f230ecc9
MR
3710 * window.c (decode_window, decode_any_window): Move up in code.
3711 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3712 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3713 (Fwindow_buffer): Move up and rewrite doc-string.
3714 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3715 (Fwindow_prev): New functions.
727e958e
MR
3716 (Fwindow_frame): Move here from frame.c. Accept any window as
3717 argument.
3718 (Fframe_root_window, Fframe_first_window)
3719 (Fframe_selected_window): Move here from frame.c. Accept frame
3720 or arbitrary window as argument. Update doc-strings.
3721 (Fminibuffer_window): Move up in code.
3722 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3723 (Fset_frame_selected_window): Move here from frame.c.
3724 Marginal rewrite.
727e958e
MR
3725 (Fselected_window, select_window, Fselect_window): Move up in
3726 code. Minor doc-string fixes.
f230ecc9 3727
4d09bcf6
PE
37282011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3729
3730 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3731 Do not assume that spare memory exists; that assumption is valid
3732 only if SYSTEM_MALLOC.
3733 (LARGE_REQUEST): New macro, so that the issue of large requests
3734 is separated from the issue of spare memory.
3735
810928a2
AS
37362011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3737
172418ad
AS
3738 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3739 format. (Bug#8806)
3740
43f862f7
AS
3741 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3742
810928a2
AS
3743 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3744 before statements.
3745
a059fe24
JD
37462011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3747
3748 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3749
3750 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3751
3752 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3753 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3754
989bf368
JB
37552011-06-05 Juanma Barranquero <lekktu@gmail.com>
3756
3757 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3758
4b80f674
CY
37592011-06-04 Chong Yidong <cyd@stupidchicken.com>
3760
3761 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3762 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3763 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3764 New error handlers.
4b80f674
CY
3765 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3766 Obey Vx_select_enable_clipboard_manager. Catch errors in
3767 x_clipboard_manager_save (Bug#8779).
3768 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3769 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3770
99a33b77 37712011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3772
3773 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3774
99a33b77 37752011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3776
3777 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3778 in the current matrix if keep_current_p is non-zero.
3779
8264569d
EZ
37802011-06-04 Eli Zaretskii <eliz@gnu.org>
3781
3782 * bidi.c (bidi_level_of_next_char): Fix last change.
3783
57f97249
EZ
37842011-06-03 Eli Zaretskii <eliz@gnu.org>
3785
fec2107c 3786 Support bidi reordering of text covered by display properties.
57f97249 3787
fec2107c
EZ
3788 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3789 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3790 (bidi_cache_search, bidi_cache_iterator_state)
3791 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3792 (bidi_level_of_next_char, bidi_move_to_visually_next):
3793 Support character positions inside a run of characters covered by a
fec2107c
EZ
3794 display string.
3795 (bidi_paragraph_init, bidi_resolve_explicit_1)
3796 (bidi_level_of_next_char): Call bidi_fetch_char and
3797 bidi_fetch_char_advance instead of FETCH_CHAR and
3798 FETCH_CHAR_ADVANCE.
3799 (bidi_init_it): Initialize new members.
3800 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3801 definitions.
3802 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3803 instead of using explicit *_CHAR codes.
d6d100dd
SM
3804 (bidi_resolve_explicit, bidi_resolve_weak):
3805 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3806 bidirectional text is supported only in multibyte buffers.
3807 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3808 it to initialize the frame_window_p member of struct bidi_it.
3809 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3810 (bidi_resolve_explicit, bidi_resolve_weak)
3811 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3812 bidi_it->nchars is non-positive.
3813 (bidi_level_of_next_char): Don't try to lookup the cache for the
3814 next/previous character if nothing is cached there yet, or if we
3815 were just reseat()'ed to a new position.
c40e2fb2 3816
0e14fe90
EZ
3817 * xdisp.c (set_cursor_from_row): Set start and stop points
3818 according to the row's direction when priming the loop that looks
3819 for the glyph on which to display cursor.
3820 (single_display_spec_intangible_p): Function deleted.
3821 (display_prop_intangible_p): Reimplement to call
3822 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3823 Accept 3 additional arguments needed by handle_display_spec.
3824 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3825 values: lists, `(when COND...)' forms, etc.
3826 (single_display_spec_string_p): Support property values that are
3827 lists with the argument STRING its top-level element.
3828 (display_prop_string_p): Fix the condition for processing a
3829 property that is a list to be consistent with handle_display_spec.
fec2107c 3830 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3831 last portion of handle_display_prop.
3832 (compute_display_string_pos): Accept additional argument
3833 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3834 value of a `display' property is a "replacing spec".
3835 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3836 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3837 the display property, but just return a value indicating whether
3838 the display property will replace the characters it covers.
3839 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3840 frame_window_p members of struct bidi_it.
d6d100dd
SM
3841 (compute_display_string_pos, compute_display_string_end):
3842 New functions.
fec2107c
EZ
3843 (push_it): Accept second argument POSITION, where pop_it should
3844 jump to continue iteration.
3845 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3846
fec2107c
EZ
3847 * keyboard.c (adjust_point_for_property): Adjust the call to
3848 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3849
3850 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3851 (bidi_init_it): Update prototypes.
3852 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3853 (compute_display_string_pos, compute_display_string_end):
3854 Declare prototypes.
fec2107c
EZ
3855 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3856 EMACS_INT.
fc6f18ce 3857
40087514 38582011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3859
57f53182
PE
3860 Malloc failure behavior now depends on size of allocation.
3861 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3862 * lisp.h: Change signatures accordingly.
3863 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3864 All callers changed. (Bug#8762)
3865
3866 * gnutls.c: Use Emacs's memory allocators.
3867 Without this change, the gnutls library would invoke malloc etc.
3868 directly, which causes problems on non-SYNC_INPUT hosts, and which
3869 runs afoul of improving memory_full behavior. (Bug#8761)
3870 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3871 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3872 xfree instead of the default malloc, realloc, free.
3873 (Fgnutls_boot): No need to check for memory allocation failure,
3874 since xmalloc does that for us.
3875
ac32cd99 3876 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3877 * category.c (hash_get_category_set):
3878 * ccl.c (ccl_driver):
3879 * charset.c (Fdefine_charset_internal):
3880 * charset.h (struct charset.hash_index):
3881 * composite.c (get_composition_id, gstring_lookup_cache)
3882 (composition_gstring_put_cache):
3883 * composite.h (struct composition.hash_index):
3884 * dispextern.h (struct image.hash):
3885 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3886 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3887 (hashfn_equal, hashfn_user_defined, make_hash_table)
3888 (maybe_resize_hash_table, hash_lookup, hash_put)
3889 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3890 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3891 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3892 * image.c (make_image, search_image_cache, lookup_image)
3893 (xpm_put_color_table_h):
3894 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3895 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3896 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3897 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3898 * alloc.c (allocate_vectorlike):
3899 Check for overflow in vector size calculations.
3900 * ccl.c (ccl_driver):
3901 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3902 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3903 need to be updated by these changes.
40087514
PE
3904 * fns.c (make_hash_table, maybe_resize_hash_table):
3905 Check for integer overflow with large hash tables.
0de4bb68
PE
3906 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3907 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3908 (SXHASH_REDUCE): New macro.
3909 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3910 Use it instead of discarding useful hash info with large hash values.
3911 (sxhash_float): New function.
3912 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3913 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3914 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3915 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3916 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3917 Adjust signatures to match updated version of code.
3918 (consing_since_gc): Now EMACS_INT, since a single hash table can
3919 use more than INT_MAX bytes.
3920
698d32e2
DN
39212011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3922
3923 Make it possible to build with GCC-4.6+ -O2 -flto.
3924
3925 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3926
fd6fa53f
SM
39272011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3928
3929 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3930 Call minibuffer-inactive-mode.
3931
864db017
JB
39322011-05-31 Juanma Barranquero <lekktu@gmail.com>
3933
3934 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3935 Update dependencies.
3936
2ad0baf4
DN
39372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3938
3939 * data.c (init_data): Remove code for UTS, this system is not
3940 supported anymore.
3941
4fcc2638
DN
39422011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3943
3944 Don't force ./temacs to start in terminal mode.
3945
3946 * frame.c (make_initial_frame): Initialize faces in all cases, not
3947 only when CANNOT_DUMP is defined.
3948 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3949
c56e0fd5
DN
39502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3951
3952 * dispnew.c (add_window_display_history): Use const for the string
3953 pointer. Remove declaration, not needed.
3954
333d54da 39552011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3956
55d4c1b2 3957 Use 'inline', not 'INLINE'.
333d54da 3958 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3959 * alloc.c, fontset.c (INLINE): Remove.
3960 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3961 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3962 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3963 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3964 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3965
738db178
DN
39662011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3967
3968 Make it possible to run ./temacs.
3969
3970 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3971 syms_of_callproc does the same thing. Remove test for
3972 "initialized", do it in the caller.
3973 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3974
620c53a6
SM
39752011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3976
3977 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3978 (read_minibuf): Use get_minibuffer.
3979 (syms_of_minibuf): Use DEFSYM.
3980 (Qmetadata): New var.
3981 * data.c (Qbuffer): Don't make it static.
3982 (syms_of_data): Use DEFSYM.
3983
e003a292
PE
39842011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3985
3986 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3987 (CCL_CODE_MIN): New macro.
3988
ed008a6d
PE
39892011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3990
3687c2ef
PE
3991 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3992
ed008a6d
PE
3993 * eval.c (Qdebug): Now static.
3994 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3995 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3996 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3997
d66c4c7c
CY
39982011-05-29 Chong Yidong <cyd@stupidchicken.com>
3999
4000 * image.c: Various fixes to ImageMagick code comments.
4001 (Fimagemagick_types): Doc fix.
4002
5fbc2025
PE
40032011-05-29 Paul Eggert <eggert@cs.ucla.edu>
4004
0196f88a
PE
4005 Minor fixes prompted by GCC 4.6.0 warnings.
4006
4007 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4008
5fbc2025
PE
4009 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4010 (x_clipboard_manager_save_all): Move extern decl to ...
4011 * xterm.h: ... here, so that it can be checked for consistency.
4012
1dd3c2d9
CY
40132011-05-29 Chong Yidong <cyd@stupidchicken.com>
4014
4015 * xselect.c (x_clipboard_manager_save_frame)
4016 (x_clipboard_manager_save_all): New functions.
4017 (Fx_clipboard_manager_save): Lisp function deleted.
4018
4019 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4020 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4021
4022 * xterm.h: Update prototype.
4023
5ba6571d
WX
40242011-05-28 William Xu <william.xwl@gmail.com>
4025
4026 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4027 exiting (Bug#8239).
4028
3eaff834
JM
40292011-05-28 Jim Meyering <meyering@redhat.com>
4030
e1900994 4031 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4032 * fns.c (to_uchar): Define.
4033 (crypto_hash_function): Use it to convert some newly-signed
4034 variables to unsigned, to avoid sign-extension bugs. For example,
4035 without this change, (md5 "truc") would evaluate to
4036 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4037 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4038 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4039
0f6990a7
PE
40402011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4041
4042 Integer overflow fixes.
c8a9ca5a 4043
08686060
PE
4044 * dbusbind.c: Serial number integer overflow fixes.
4045 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4046 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4047 to hold a serial number that is too large for a fixnum.
4048 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4049 Check for serial numbers out of range. Decode any serial number
59568bf0 4050 that was so large that it became a float. (Bug#8722)
08686060 4051
2d1fc3c7
PE
4052 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4053 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4054 Use XFASTINT rather than XUINT when numbers are nonnegative.
4055 (xd_append_arg, Fdbus_method_return_internal):
4056 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4057 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4058 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4059 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4060 (Bug#8722)
2d1fc3c7 4061
c8a9ca5a
PE
4062 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4063
519e1d69
PE
4064 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4065
30569699
PE
4066 ccl: add integer overflow checks
4067 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4068 (IN_INT_RANGE): New macros.
4069 (ccl_driver): Use them to check for integer overflow when
4070 decoding a CCL program. Many of the new checks are whether XINT (x)
4071 fits in int; it doesn't always, on 64-bit hosts. The new version
4072 doesn't catch all possible integer overflows, but it's an
847044ea 4073 improvement. (Bug#8719)
30569699 4074
c11285dc
PE
4075 * alloc.c (make_event_array): Use XINT, not XUINT.
4076 There's no need for unsigned here.
4077
fdccd48e
PE
4078 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4079 This follows up to the 2011-05-06 change that substituted uintptr_t
4080 for EMACS_INT. This case wasn't caught back then.
4081
37910ab2
PE
4082 Rework Fformat to avoid integer overflow issues.
4083 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4084 now (part of C89). Include <verify.h>.
4085 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4086 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4087 (Fformat): Avoid the prepass trying to compute sizes; it was only
4088 approximate and thus did not catch overflow reliably. Instead, walk
4089 through the format just once, formatting and computing sizes as we go,
4090 checking for integer overflow at every step, and allocating a larger
4091 buffer as needed. Keep track separately whether the format is
4092 multibyte. Keep only the most-recently calculated precision, rather
4093 than them all. Record whether each argument has been converted to
4094 string. Use EMACS_INT, not int, for byte and char and arg counts.
4095 Support field widths and precisions larger than INT_MAX. Avoid
4096 sprintf's undefined behavior with conversion specifications such as %#d
4097 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4098 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4099 formatting out-of-range floating point numbers with int
9173deec 4100 formats. (Bug#8668)
37910ab2 4101
2e6578fb
PE
4102 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4103
0ae6bdee
PE
4104 * data.c: Avoid integer truncation in expressions involving floats.
4105 * data.c: Include <intprops.h>.
4106 (arith_driver): When there's an integer overflow in an expression
4107 involving floating point, convert the integers to floating point
4108 so that the resulting value does not suffer from catastrophic
4109 integer truncation. For example, on a 64-bit host (* 4
4110 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4111 Do not rely on undefined behavior after integer overflow.
4112
de883a70
PE
4113 merge count_size_as_multibyte, parse_str_to_multibyte
4114 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4115 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4116 Check for integer overflow.
4117 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4118 since it's now a duplicate of the other. This is more of
4119 a character than a buffer op, so better that it's in character.c.
4120 * fns.c, print.c: Adjust to above changes.
4121
2ff916cb
PE
41222011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4123
4124 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4125
f1b54466
PE
41262011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4127
fb1ac845
PE
4128 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4129 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4130 (x_clipboard_manager_save): Now static.
4131 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4132
f1b54466
PE
4133 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4134 (crypto_hash_function): Now static.
4135 Fix pointer signedness problems. Avoid unnecessary initializations.
4136
a9f737ee
CY
41372011-05-27 Chong Yidong <cyd@stupidchicken.com>
4138
4139 * termhooks.h (Vselection_alist): Make it terminal-local.
4140
4141 * terminal.c (create_terminal): Initialize it.
4142
4143 * xselect.c: Support for clipboard managers.
4144 (Vselection_alist): Move to termhooks.h as terminal-local var.
4145 (LOCAL_SELECTION): New macro.
4146 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4147 (symbol_to_x_atom): Remove gratuitous arg.
4148 (x_handle_selection_request, lisp_data_to_selection_data)
4149 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4150 (x_own_selection, x_get_local_selection, x_convert_selection):
4151 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4152 (some_frame_on_display): Delete unused function.
4153 (Fx_own_selection_internal, Fx_get_selection_internal)
4154 (Fx_disown_selection_internal, Fx_selection_owner_p)
4155 (Fx_selection_exists_p): New optional frame arg.
4156 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4157 (x_handle_selection_clear): Don't treat other terminals with the
4158 same keyboard specially. Use the terminal-local Vselection_alist.
4159 (x_clear_frame_selections): Use Frun_hook_with_args.
4160
4161 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4162
4163 * xterm.h: Add support for those atoms.
4164
e067f0c1
CY
41652011-05-26 Chong Yidong <cyd@stupidchicken.com>
4166
4167 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4168 (converted_selections, conversion_fail_tag): New global variables.
4169 (x_selection_request_lisp_error): Free the above.
4170 (x_get_local_selection): Remove unnecessary code.
4171 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4172 of converted selections stored in converted_selections.
4173 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4174 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4175 (x_convert_selection): New function.
4176 (x_handle_selection_event): Simplify.
4177 (x_get_foreign_selection): Don't ignore incoming requests while
4178 waiting for an answer; this will fail when we implement
4179 SAVE_TARGETS, and seems unnecessary anyway.
4180 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4181 (Vx_sent_selection_functions): Doc fix.
4182
0f4aebc0
LL
41832011-05-26 Leo Liu <sdl.web@gmail.com>
4184
4185 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4186
e61124cd
YM
41872011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4188
4189 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4190
4191 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4192 for fringe update if it has periodic bitmap.
ac389d0c 4193 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4194 and fringe_bitmap_periodic_p.
4195
4196 * fringe.c (get_fringe_bitmap_data): New function.
4197 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4198 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4199 row. Mark glyph row for fringe update if periodicity changed.
4200
4201 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4202 for fringe update unless it has periodic bitmap.
4203
f16d9837
KH
42042011-05-25 Kenichi Handa <handa@m17n.org>
4205
4206 * xdisp.c (get_next_display_element): Set correct it->face_id for
4207 a static composition.
4208
e1b90ef6
LL
42092011-05-24 Leo Liu <sdl.web@gmail.com>
4210
4211 * deps.mk (fns.o):
4212 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4213
4214 * fns.c (crypto_hash_function, Fsha1): New function.
4215 (Fmd5): Use crypto_hash_function.
4216 (syms_of_fns): Add Ssha1.
4217
7400048f
PE
42182011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4219
4220 * gnutls.c: Remove unused macros.
4221 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4222 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4223 Remove macros that are defined and never used.
4224 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4225
abb71cf4
CY
42262011-05-22 Chong Yidong <cyd@stupidchicken.com>
4227
4228 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4229 (Fx_get_selection_internal): Minor cleanup.
4230 (Fx_own_selection_internal): Rename arguments for consistency with
4231 select.el.
4232
6307db39
PE
42332011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4234
4235 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4236
f3d4e0a4
CY
42372011-05-22 Chong Yidong <cyd@stupidchicken.com>
4238
4239 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4240
4d8ade89
YM
42412011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4242
4243 * dispnew.c (scrolling_window): Don't exclude the case that the
4244 last enabled row in the desired matrix touches the bottom boundary.
4245
32078c8d
GM
42462011-05-21 Glenn Morris <rgm@gnu.org>
4247
4248 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4249 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4250 and add some more files.
32078c8d 4251
7285dc67
EZ
42522011-05-20 Eli Zaretskii <eliz@gnu.org>
4253
4254 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4255 report_file_error introduced by the change from 2011-05-07.
4256
89d1bd22
PE
42572011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4258
4259 * systime.h (Time): Define only if emacs is defined.
4260 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4261 where the include path doesn't have X11/X.h by default. See
4262 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4263
e23640bb 42642011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4265
4266 * composite.c (find_automatic_composition): Fix previous change.
4267
b9704ad9
GM
42682011-05-20 Glenn Morris <rgm@gnu.org>
4269
4270 * lisp.mk: New file, split from Makefile.in.
4271 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4272 (shortlisp): Remove.
4273 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4274
4a720484
GM
42752011-05-19 Glenn Morris <rgm@gnu.org>
4276
4277 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4278 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4279 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4280 (lisp): Set the order to that of loadup.el.
4281 (shortlisp): Make it a copy of $lisp.
4282 (SOME_MACHINE_LISP): Remove.
4283 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4284 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4285
a28d4396
KH
42862011-05-18 Kenichi Handa <handa@m17n.org>
4287
4288 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4289 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4290 (find_automatic_composition): Mostly rewrite for efficiency.
4291
a2b1fa8e
JB
42922011-05-18 Juanma Barranquero <lekktu@gmail.com>
4293
4294 * makefile.w32-in: Update dependencies.
4295
8e1f5610
CS
42962011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4297
4298 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4299 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4300
7025ee00 43012011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4302
cdfa6eab
PE
4303 Fix some integer overflow issues, such as string length overflow.
4304
06d6db33
PE
4305 * insdel.c (count_size_as_multibyte): Check for string overflow.
4306
2b4560a8
PE
4307 * character.c (lisp_string_width): Check for string overflow.
4308 Use EMACS_INT, not int, for string indexes and lengths; in
4309 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4310 the resulting string length overflows an EMACS_INT; instead,
4311 report a string overflow if no precision given. When checking for
4312 precision exhaustion, use a check that cannot possibly have
4313 integer overflow. (Bug#8675)
4314 * character.h (lisp_string_width): Adjust to new signature.
4315
cb93f9be
PE
4316 * alloc.c (string_overflow): New function.
4317 (Fmake_string): Use it. This doesn't change behavior, but saves
4318 a few bytes and will simplify future changes.
4319 * character.c (string_escape_byte8): Likewise.
4320 * lisp.h (string_overflow): New decl.
4321
1a1f3366
PE
4322 Fixups, following up to the user-interface timestamp change.
4323 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4324 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4325 * msdos.c (mouse_get_pos): Likewise.
4326 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4327 * w32gui.h (Time): Define by including "systime.h" rather than by
4328 declaring it ourselves. (Bug#8664)
4329
d4e3e4d3
PE
4330 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4331 * image.c (clear_image_cache): Likewise.
4332
f6a24d19
PE
4333 * term.c (term_mouse_position): Don't assume time_t wraparound.
4334
08dc5ae6
PE
4335 Be more systematic about user-interface timestamps.
4336 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4337 and sometimes 'EMACS_UINT', to represent these timestamps.
4338 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4339 This makes the code easier to follow, and makes it easier to catch
4340 integer overflow bugs such as Bug#8664.
4341 * frame.c (Fmouse_position, Fmouse_pixel_position):
4342 Use Time, not unsigned long, for user-interface timestamps.
4343 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4344 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4345 * keyboard.h (last_event_timestamp): Likewise.
4346 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4347 * menu.h (xmenu_show): Likewise.
4348 * term.c (term_mouse_position): Likewise.
4349 * termhooks.h (struct input_event.timestamp): Likewise.
4350 (struct terminal.mouse_position_hook): Likewise.
4351 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4352 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4353 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4354 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4355 what it was before.
4356 * menu.h, termhooks.h: Include "systime.h", for Time.
4357
8e55734a
PE
4358 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4359 Don't assume that the difference between two unsigned long values
4360 can fit into an integer. At this point, we know button_down_time
4361 <= event->timestamp, so the difference must be nonnegative, so
4362 there's no need to cast the result if double-click-time is
4363 nonnegative, as it should be; check that it's nonnegative, just in
4364 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4365 apart (about 25 days). (Bug#8664)
8e55734a 4366
841f1b75 4367 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4368 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4369
3e26f69c
PE
4370 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4371 that always fit in int. Use a sentinel instead of a counter, to
4372 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4373 * frame.h (struct frame): Use int for menu_bar_items_used
4374 instead of EMACS_INT, since it always fits in int.
3e26f69c 4375
5cc152c0
PE
4376 * menu.c (grow_menu_items): Check for int overflow.
4377
d89eb65e
PE
4378 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4379
5235bd3e
PE
4380 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4381 Before, the code was not consistent. These values cannot exceed
4382 2**31 - 1 so there's no need to make them unsigned.
4383 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4384 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4385 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4386 as modifiers.
4387 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4388
bc827e23
PE
4389 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4390 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4391 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4392 presumably because the widths might not match.
4393
78eb494e
PE
4394 * window.c (size_window): Avoid needless test at loop start.
4395
04f2d78b
CB
43962011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4397
4398 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4399
d2fc7e3d 44002011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4401
4402 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4403
d2fc7e3d 44042011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4405
4406 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4407 `width' to `bar_area_x' and `bar_area_width', respectively.
4408 (x_scroll_run): Take account of fringe background extension.
4409
04f2d78b
CB
4410 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4411 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4412 `bar_area_width', respectively.
4413 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4414 background extension.
4415
79b70037
GM
44162011-05-10 Jim Meyering <meyering@redhat.com>
4417
4418 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4419
2f142cc5
JB
44202011-05-10 Juanma Barranquero <lekktu@gmail.com>
4421
4422 * image.c (Finit_image_library): Return t for built-in image types,
4423 like pbm and xbm. (Bug#8640)
4424
57679c86
AS
44252011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4426
4427 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4428
888c9e86
EZ
44292011-05-07 Eli Zaretskii <eliz@gnu.org>
4430
b0512a1d
EZ
4431 * w32console.c (Fset_screen_color): Doc fix.
4432 (Fget_screen_color): New function.
4433 (syms_of_ntterm): Defsubr it.
4434
7285dc67
EZ
4435 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4436 unlink the temporary file if Fcall_process didn't create it in the
4437 first place.
4438 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4439 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4440 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4441 cue to call_process_cleanup not to close that handle.
4442
4d3fcc8e
BK
44432011-05-07 Ben Key <bkey76@gmail.com>
4444
4445 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4446 one of two shell specific rules, either bootstrap-temacs-CMD or
4447 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4448 to the previous implementation of the bootstrap-temacs rule.
4449 The bootstrap-temacs-CMD rule is similar to the previous
4450 implementation of the bootstrap-temacs rule except that it
4451 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4452 variable.
4453
4454 These changes, along with some changes to nt/configure.bat,
4455 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4456 earlier fix to add support for --cflags and --ldflags options
4457 that include quotes so that it works whether make uses cmd or
4458 sh as the shell.
4459
b4289b64
MA
44602011-05-06 Michael Albinus <michael.albinus@gmx.de>
4461
4462 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4463 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4464 is a constant.
4465 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4466 a string. Handle both cases.
4467 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4468 (Fdbus_register_method): Use Qinvalid_function.
4469
af4c0e28
JB
44702011-05-06 Juanma Barranquero <lekktu@gmail.com>
4471
4472 * makefile.w32-in: Update dependencies.
4473 (LISP_H): Add inttypes.h and stdin.h.
4474 (PROCESS_H): Add unistd.h.
4475
c51453d9
EZ
44762011-05-06 Eli Zaretskii <eliz@gnu.org>
4477
4478 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4479 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4480
8ff0ac3c 44812011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4482
4c4b566b
PE
4483 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4484
aab2b9b5
PE
4485 * term.c (vfatal): Remove stray call to va_end.
4486 It's not needed and the C Standard doesn't allow it here anyway.
4487
c378da0b
PE
4488 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4489 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4490
288b08c7
PE
4491 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4492 bytes.
4493
e3601888
PE
4494 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4495
db6c0e74
PE
4496 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4497
dd5963ea
PE
4498 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4499
88c9450f
PE
4500 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4501
2f9442b8
PE
4502 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4503
c032b5f8
PE
4504 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4505 * charset.c (Fdefine_charset_internal): Don't initialize
4506 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4507 32-bit int (Bug#8600).
a108c10b
PE
4508
4509 * lread.c (read_integer): Be more consistent with string-to-number.
4510 Use string_to_number to do the actual conversion; this avoids
4511 rounding errors and fixes some other screwups. Without this fix,
4512 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4513 (digit_to_number): Move earlier, for benefit of read_integer.
4514 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4515 not a digit in any supported base. (Bug#8602)
a108c10b 4516
ad5f9eea
PE
4517 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4518
aec1708a
PE
4519 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4520 to match comment at start of function. This also removes a
4521 GCC warning about overflow in a 32+64-bit port.
4522
47be4ab5
PE
4523 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4524
371cac43
PE
4525 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4526 Reported by Stefan Monnier in
4527 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4528 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4529 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4530
d01a7826
PE
4531 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4532 (EMACS_UINTPTR): Likewise, with uintptr_t.
4533
7fd47d5c
PE
4534 * lisp.h: Prefer 64-bit EMACS_INT if available.
4535 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4536 on 32-bit hosts that have 64-bit int, so that they can access
4537 large files.
122b0c86
PE
4538 However, temporarily disable this change unless the temporary
4539 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4540
8727937b
PE
4541 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4542
8ac068ac
PE
4543 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4544 This removes an assumption that EMACS_INT and long are the same
4545 width as pointers. The assumption is true for Emacs porting targets
4546 now, but we want to make other targets possible.
4547 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4548 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4549 In the rest of the code, change types of integers that hold casted
4550 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4551 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4552 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4553 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4554 No need to cast type when ORing.
4555 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4556 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4557 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4558 assume EMACS_INT is the same width as char *.
4559 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4560 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4561 Remove no-longer-needed casts.
4562 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4563 (xg_tool_bar_help_callback, xg_make_tool_item):
4564 Use EMACS_INTPTR to hold an integer
4565 that will be cast to void *; this can avoid a GCC warning
4566 if EMACS_INT is not the same width as void *.
4567 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4568 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4569 (current_message_1, set_message_1):
4570 Use a local to convert to proper width without a cast.
4571 * xmenu.c (dialog_selection_callback): Likewise.
4572
ede49d71
PE
4573 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4574 Also, don't assume VALBITS / RAND_BITS is less than 5,
4575 and don't rely on undefined behavior when shifting a 1 left into
4576 the sign bit.
4577 * lisp.h (get_random): Change signature to match.
4578
2f30ecd0
PE
4579 * lread.c (hash_string): Use size_t, not int, for hash computation.
4580 Normally we prefer signed values; but hashing is special, because
4581 it's better to use unsigned division on hash table sizes so that
4582 the remainder is nonnegative. Also, size_t is the natural width
4583 for hashing into memory. The previous code used 'int', which doesn't
4584 retain enough info to hash well into very large tables.
4585 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4586
2a866e7b
PE
4587 * dbusbind.c: Don't possibly lose pointer info when converting.
4588 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4589 Use XPNTR rather than XHASH, so that the high-order bits of
4590 the pointer aren't lost when converting through void *.
4591
51639eac
PE
4592 * eval.c (Fautoload): Don't double-shift a pointer.
4593
92394119
PE
4594 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4595
dbdb9a7c
JB
45962011-05-06 Juanma Barranquero <lekktu@gmail.com>
4597
4598 * gnutls.c (DEF_GNUTLS_FN):
4599 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4600
db7a0b4f
AS
46012011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4602
4603 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4604 marker. (Bug#8610)
4605
f7ff1b0f 46062011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4607
4608 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4609 New version that can reserve upto 2GB of heap space.
4610
f7ff1b0f 46112011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4612
4613 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4614
639c109b
TZ
46152011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4616
4617 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4618 `gnutls_certificate_set_x509_key_file'.
4619
d2127135
JB
46202011-05-05 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4623 Update dependencies.
4624
e968f4f3
JB
46252011-05-04 Juanma Barranquero <lekktu@gmail.com>
4626
4627 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4628 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4629 Remove unused parameter `fildes'.
4630 * process.c (read_process_output, send_process): Don't pass it.
4631
84d358f0
JB
46322011-05-04 Juanma Barranquero <lekktu@gmail.com>
4633
4634 Fix previous change: the library cache is defined in w32.c.
4635 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4636 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4637
0898ca10
JB
46382011-05-04 Juanma Barranquero <lekktu@gmail.com>
4639
4640 Implement dynamic loading of GnuTLS on Windows.
4641
4642 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4643 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4644 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4645 Declare.
4646
4647 * gnutls.c (Qgnutls_dll): Define.
4648 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4649 (gnutls_*): Declare function pointers.
4650 (init_gnutls_functions): New function to initialize function pointers.
4651 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4652 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4653 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4654 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4655 (emacs_gnutls_write, emacs_gnutls_read)
4656 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4657 (Fgnutls_available_p): New function.
4658 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4659 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4660 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4661
4662 * image.c: Include w32.h.
4663 (Vimage_type_cache): Delete.
4664 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4665 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4666 (w32_delayed_load): Move to w32.c.
4667
4668 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4669
4670 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4671 (w32_delayed_load): Move from image.c. When loading a library, record
4672 its filename in the :loaded-from property of the library id.
4673 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4674 Initialize and staticpro them.
4675 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4676
4677 * process.c: Include lisp.h before w32.h, not after.
4678 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4679 instead of gnutls_record_check_pending.
4680
4681 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4682
ff4de4aa
TZ
46832011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4684
4685 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4686 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4687 as passed in.
4688
abe95abb
JD
46892011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4690
4691 * xterm.c (x_set_frame_alpha): Do not set property on anything
4692 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4693
e16e55d4
JB
46942011-05-02 Juanma Barranquero <lekktu@gmail.com>
4695
4696 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4697
bafcf6a5
JB
46982011-05-02 Juanma Barranquero <lekktu@gmail.com>
4699
4700 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4701 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4702 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4703 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4704 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4705 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4706 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4707 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4708 (Qgnutls_bootprop_callbacks_verify): Make static.
4709
e7a6747f
AS
47102011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4711
19ed11ba
AS
4712 * callproc.c: Indentation fixup.
4713
e7a6747f 4714 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4715 (wait_for_termination, interruptible_wait_for_termination):
4716 Move after wait_for_termination_1.
e7a6747f 4717
1ef14cb4
LMI
47182011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4719
4720 * sysdep.c (interruptible_wait_for_termination): New function
4721 which is like wait_for_termination, but allows keyboard
4722 interruptions.
4723
4724 * callproc.c (Fcall_process): Add (:file "file") as an option for
4725 the STDOUT buffer.
4726 (Fcall_process_region): Ditto.
4727
330d880c
EZ
47282011-04-30 Eli Zaretskii <eliz@gnu.org>
4729
8db90b73
EZ
4730 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4731 rather than `XVECTOR (FOO)->size'.
4732
330d880c
EZ
4733 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4734 inttypes.h, as a gnulib replacement is used if it not available in
4735 system headers.
4736
15cbd324
EZ
47372011-04-21 Eli Zaretskii <eliz@gnu.org>
4738
4739 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4740 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4741 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4742
4743 * coding.c (coding_alloc_by_realloc): Error out if destination
4744 will grow beyond MOST_POSITIVE_FIXNUM.
4745 (decode_coding_emacs_mule): Abort if there isn't enough place in
4746 charbuf for the composition carryover bytes. Reserve an extra
4747 space for up to 2 characters produced in a loop.
4748 (decode_coding_iso_2022): Abort if there isn't enough place in
4749 charbuf for the composition carryover bytes.
4750
47512011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4752
ae940cca
EZ
4753 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4754 aborting when %lld or %lll format is passed.
4755 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4756 %llo or %llx format is passed. (Bug#8545)
4757
03ab8921
EZ
4758 * window.c (window_scroll_line_based): Use a marker instead of
4759 simple variables to record original value of point. (Bug#7952)
4760
afda1437
EZ
4761 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4762 produced by %s or %c overflows available buffer space. (Bug#8545)
4763
f76dee0c
PE
47642011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4765
4766 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4767 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4768
fdc5744d
JB
47692011-04-28 Juanma Barranquero <lekktu@gmail.com>
4770
4771 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4772
638f053a
JB
47732011-04-28 Juanma Barranquero <lekktu@gmail.com>
4774
4775 * keyboard.c (Qdelayed_warnings_hook): Define.
4776 (command_loop_1): Run `delayed-warnings-hook'
4777 if Vdelayed_warnings_list is non-nil.
4778 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4779 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4780
d178f871
EZ
47812011-04-28 Eli Zaretskii <eliz@gnu.org>
4782
4783 * doprnt.c (doprnt): Don't return value smaller than the buffer
4784 size if the message was truncated. (Bug#8545).
4785
b124fd93
JB
47862011-04-28 Juanma Barranquero <lekktu@gmail.com>
4787
4788 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4789 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4790
e810457d
PE
47912011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4792
4793 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4794
ea51cceb
JB
47952011-04-27 Juanma Barranquero <lekktu@gmail.com>
4796
4797 * makefile.w32-in: Update dependencies.
4798
94dcfacf
EZ
47992011-04-27 Eli Zaretskii <eliz@gnu.org>
4800
4801 Improve `doprnt' and its usage. (Bug#8545)
4802 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4803 `format_end'. Remove support for %l as a conversion specifier.
4804 Don't use xrealloc. Improve diagnostics when the %l size modifier
4805 is used. Update the commentary.
4806
4807 * eval.c (verror): Simplify calculation of size_t.
4808
4809 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4810 messages.
4811
f61f41d7
PE
48122011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4813
4814 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4815 change.
4816
96fb4434
PE
48172011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4818
4819 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4820 This makes this file independent of the recent pseudovector change.
4821
671875da 48222011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4823
69e9b5a3
PE
4824 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4825
b5f869a7 4826 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4827 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4828 Remove unused local.
c8926152 4829 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4830
841a1577 4831 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4832 GCC 4.6.0 optimizes based on type-based alias analysis.
4833 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4834 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4835 != &v->size, and therefore "v->size = 1; b->size = 2; return
4836 v->size;" must therefore return 1. This assumption is incorrect
4837 for Emacs, since it type-puns struct Lisp_Vector * with many other
4838 types. To fix this problem, this patch adds a new type struct
f904488f 4839 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4840 and pseudovectors, and helps optimizing compilers not get fooled
4841 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4842 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4843 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4844 the size member.
eab3844f
PE
4845 (XSETPVECTYPE): Rewrite in terms of new macro.
4846 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4847 This is a bit clearer, and further avoids the possibility of
4848 undesirable aliasing.
4849 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4850 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4851 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4852 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4853 (ASIZE): Now uses header.size rather than size.
4854 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4855 to avoid the hassle of writing XVECTOR (foo)->header.size.
4856 (struct vectorlike_header): New type.
eab3844f
PE
4857 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4858 object, to help avoid aliasing.
4859 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4860 (SUBRP): Likewise, since Lisp_Subr is a special case.
4861 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4862 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4863 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4864 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4865 changed to be "header.size" and "header.next".
4866 * buffer.h (struct buffer): Likewise.
4867 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4868 * frame.h (struct frame): Likewise.
4869 * process.h (struct Lisp_Process): Likewise.
4870 * termhooks.h (struct terminal): Likewise.
4871 * window.c (struct save_window_data, struct saved_window): Likewise.
4872 * window.h (struct window): Likewise.
4873 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4874 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4875 * buffer.c (init_buffer_once): Likewise.
4876 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4877 special case.
4878 * process.c (Fformat_network_address): Use local var for size,
4879 for brevity.
4880
0df1eac5
PE
4881 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4882
847ab9d1 4883 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4884 * data.c (atof): Remove decl; no longer used or needed.
4885 (digit_to_number): Move to lread.c.
4886 (Fstring_to_number): Use new string_to_number function, to be
4887 consistent with how the Lisp reader treats infinities and NaNs.
4888 Do not assume that floating-point numbers represent EMACS_INT
4889 without losing information; this is not true on most 64-bit hosts.
4890 Avoid double-rounding errors, by insisting on integers when
4891 parsing non-base-10 numbers, as the documentation specifies.
4892 * lisp.h (string_to_number): New decl, replacing ...
4893 (isfloat_string): Remove.
bc0a5c13 4894 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4895 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4896 appears to have been a coding error. Similarly, do not accept
4897 strings like +-1e0 as floating point numbers. Do not report
4898 overflow for integer overflows unless the base is not 10 which
4899 means we have no simple and reliable way to continue.
4900 Break out the floating-point parsing into a new
4901 function string_to_number, so that Fstring_to_number parses
4902 floating point numbers consistently with the Lisp reader.
04f2d78b 4903 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4904 (E_CHAR, EXP_INT): Remove, replacing with ...
4905 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4906 (string_to_number): New function, replacing isfloat_string.
4907 This function checks for valid syntax and produces the resulting
4908 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4909 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4910 so that overflow for non-base-10 numbers is reported only when
4911 there's no portable and simple way to convert to floating point.
452f4150 4912
67769ffc
PE
4913 * textprop.c (set_text_properties_1): Rewrite for clarity,
4914 and to avoid GCC warning about integer overflow.
4915
c20db43f
PE
4916 * intervals.h (struct interval): Use EMACS_INT for members
4917 where EMACS_UINT might cause problems. See
4918 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4919 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4920 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4921 All uses changed.
37aa2f85
PE
4922 (offset_intervals): Tell GCC not to worry about length overflow
4923 when negating a negative length.
c20db43f 4924
2538aa2f
PE
4925 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4926 (overrun_check_free): Likewise.
4927
f2d3008d
PE
4928 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4929 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4930 word size.
4931
ec8df744
PE
4932 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4933 (gnutls_make_error): Rename local to avoid shadowing.
4934 (gnutls_emacs_global_deinit): ifdef out; not used.
4935 (Fgnutls_boot): Use const for pointer to readonly storage.
4936 Comment out unused local. Fix pointer signedness problems.
4937
640ee02d
PE
4938 * lread.c (openp): Don't stuff size_t into an 'int'.
4939 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4940 about possible signed overflow.
4941
6048fb2a
PE
4942 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4943 (GDK_KEY_g): Don't define if already defined.
4944 (xg_prepare_tooltip): Avoid pointer signedness problem.
4945 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4946
fa3c87e1
PE
4947 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4948 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4949
2172544b
PE
4950 * xfns.c (Fx_window_property): Simplify a bit,
4951 to make a bit faster and to avoid GCC 4.6.0 warning.
4952 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4953
9b821a21
PE
4954 * fns.c (internal_equal): Don't assume size_t fits in int.
4955
3c616cfa
PE
4956 * alloc.c (compact_small_strings): Tighten assertion a little.
4957
c2982e87
PE
4958 Replace pEd with more-general pI, and fix some printf arg casts.
4959 * lisp.h (pI): New macro, generalizing old pEd macro to other
4960 conversion specifiers. For example, use "...%"pI"d..." rather
4961 than "...%"pEd"...".
4962 (pEd): Remove. All uses replaced with similar uses of pI.
4963 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4964 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4965 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4966 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4967 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4968 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4969 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4970 64-bit hosts.
4971 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4972 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4973 * print.c (safe_debug_print, print_object): Likewise.
4974 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4975 to int.
6f04d126
PE
4976 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4977 avoiding the 0 flag, which is not portable.
c2982e87
PE
4978 * process.c (Fmake_network_process): Use pI to avoid cast.
4979 * region-cache.c (pp_cache): Likewise.
4980 * xdisp.c (decode_mode_spec): Likewise.
4981 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4982 behavior on 64-bit hosts with printf arg.
6f04d126 4983 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4984 (x_stop_queuing_selection_requests): Likewise.
4985 (x_get_window_property): Don't truncate byte count to an 'int'
4986 when tracing.
0b432f21 4987
5e073ec7
PE
4988 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4989 here, since it parses constructs like leading '-' and spaces,
4990 which are not wanted; and it overflows with large numbers.
4991 Instead, simply match F[0-9]+, which is what is wanted anyway.
4992
36372bf9
PE
4993 * alloc.c: Remove unportable assumptions about struct layout.
4994 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4995 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4996 (allocate_vectorlike, make_pure_vector): Use the new macros,
4997 plus offsetof, to remove unportable assumptions about struct layout.
4998 These assumptions hold on all porting targets that I know of, but
4999 they are not guaranteed, they're easy to remove, and removing them
5000 makes further changes easier.
5001
0b432f21
PE
5002 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
5003 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
5004 (string_overrun_cookie): Now const. Use initializers that
5005 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5006 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5007 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5008 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5009 multiple of sizeof (EMACS_INT); it need not be, if
5010 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5011 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5012
895009e1
JB
50132011-04-26 Juanma Barranquero <lekktu@gmail.com>
5014
5015 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5016
6a7a1b0b
TZ
50172011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5018
5019 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5020 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5021 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5022
841a1577 50232011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5024
5025 * lisp.h (Qdebug): List symbol.
895009e1 5026 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5027 * keyboard.c (debug-on-event): New variable.
5028 (handle_user_signal): Break into debugger when debug-on-event
5029 matches the current signal symbol.
5030
f2d3ba6f
DN
50312011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5032
5033 * alloc.c (check_sblock, check_string_bytes)
5034 (check_string_free_list): Convert to standard C.
5035
42ce4c63
TZ
50362011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5037
5038 * w32.c (emacs_gnutls_push): Fix typo.
5039
825cd63c
EZ
50402011-04-25 Eli Zaretskii <eliz@gnu.org>
5041
fb11d64d
EZ
5042 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5043 "cast to pointer from integer of different size".
5044
825cd63c
EZ
5045 Improve doprnt and its use in verror. (Bug#8545)
5046 * doprnt.c (doprnt): Document the set of format control sequences
5047 supported by the function. Use SAFE_ALLOCA instead of always
5048 using `alloca'.
5049
5050 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5051 is one byte too soon. Don't use xrealloc; instead xfree and
5052 xmalloc anew.
5053
e061a11b
TZ
50542011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5055
5056 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5057 callbacks stage.
5058
5059 * gnutls.c: Renamed global_initialized to
5060 gnutls_global_initialized. Added internals for the
5061 :verify-hostname-error, :verify-error, and :verify-flags
5062 parameters of `gnutls-boot' and documented those parameters in the
5063 docstring. Start callback support.
9173deec
JB
5064 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5065 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5066 on error. Return error code.
e061a11b
TZ
5067 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5068 (emacs_gnutls_read): Likewise.
5069 (Fgnutls_boot): Return handshake error code.
5070 (emacs_gnutls_handle_error): New function.
5071 (wsaerror_to_errno): Likewise.
5072
5073 * w32.h (emacs_gnutls_pull): Add prototype.
5074 (emacs_gnutls_push): Likewise.
5075
5076 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5077 (emacs_gnutls_push): Likewise.
5078
50792011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5080
5081 * process.c (wait_reading_process_output): Check if GnuTLS
5082 buffered some data internally if no FDs are set for TLS
5083 connections.
5084
5085 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5086 (LIBS): Link to USER_LIBS.
5087 ($(BLD)/gnutls.$(0)): New target.
5088
fa6996bc
EZ
50892011-04-24 Eli Zaretskii <eliz@gnu.org>
5090
eb35682e
EZ
5091 * xdisp.c (handle_single_display_spec): Rename the
5092 display_replaced_before_p argument into display_replaced_p, to
5093 make it consistent with the commentary. Fix typos in the
5094 commentary.
5095
e2ad650c
EZ
5096 * textprop.c (syms_of_textprop): Remove dead code.
5097 (copy_text_properties): Delete obsolete commentary about an
5098 interface that was deleted long ago. Fix typos in the description
5099 of arguments.
5100
1b2de274
EZ
5101 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5102 to changes in oldXMenu/XMenu.h from 2011-04-16.
5103 <menu_help_message, prev_menu_help_message>: Constify.
5104 (IT_menu_make_room): menu->help_text is now `const char **';
5105 adjust.
5106
5107 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5108 to changes in oldXMenu/XMenu.h from 2011-04-16.
5109 (struct XMenu): Declare `help_text' `const char **'.
5110
5111 * xfaces.c <Qunspecified>: Make extern again.
5112
5113 * syntax.c: Include sys/types.h before including regex.h, as
5114 required by Posix.
5115
762b15be
EZ
5116 * doc.c (get_doc_string): Improve the format passed to `error'.
5117
5118 * doprnt.c (doprnt): Improve commentary.
5119
5120 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5121
5122 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5123 them with etags.
5124
f1052e5d
EZ
5125 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5126 changes in globals.h immediately force recompilation.
762b15be
EZ
5127 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5128 $(CURDIR)/s/ms-w32.h.
5129 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5130
fa6996bc
EZ
5131 * character.c (Fchar_direction): Function deleted.
5132 (syms_of_character): Don't defsubr it.
5133 <char-direction-table>: Deleted.
5134
e6c3da20
EZ
51352011-04-23 Eli Zaretskii <eliz@gnu.org>
5136
5137 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5138 * doprnt.c: Include limits.h.
5139 (SIZE_MAX): New macro.
04f2d78b
CB
5140 (doprnt): Return a size_t value. 2nd arg is now size_t.
5141 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5142 Improve overflow protection. Support `l' modifier for integer
5143 conversions. Support %l conversion. Don't assume an EMACS_INT
5144 argument for integer conversions and for %c.
5145
5146 * lisp.h (doprnt): Restore prototype.
5147
5148 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5149 $(SRC)/character.h.
5150
5151 * Makefile.in (base_obj): Add back doprnt.o.
5152
5153 * deps.mk (doprnt.o): Add back prerequisites.
5154 (callint.o): Depend on character.h.
5155
5156 * eval.c (internal_lisp_condition_case): Include the handler
5157 representation in the error message.
5158 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5159 when breaking from the loop.
5160
5161 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5162
5163 * callint.c (Fcall_interactively): When displaying error message
5164 about invalid control letter, pass the character's codepoint, not
5165 a pointer to its multibyte form. Improve display of the character
5166 in octal and display also its hex code.
5167
5168 * character.c (char_string): Use %x to display the (unsigned)
5169 codepoint of an invalid character, to avoid displaying a bogus
5170 negative value.
5171
5172 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5173 `error', not SYMBOL_NAME itself.
5174
5175 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5176 character arguments to `error'.
5177
5178 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5179 to `error' in error message about FINAL_CHAR argument. Make sure
5180 FINAL_CHAR is a character, and use %c when it is passed as
5181 argument to `error'.
5182
4ffd0d6b 51832011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5184
5185 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5186
5187 * w32.c: Include <time.h>.
5188 (sys_localtime): New function.
5189
4ffd0d6b 51902011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5191
5192 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5193
4ffd0d6b 5194 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5195
4ffd0d6b 51962011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5197
4ffd0d6b
GM
5198 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5199 zombies (Bug#8467).
aac0c6e3 5200
04c56954
EZ
52012011-04-19 Eli Zaretskii <eliz@gnu.org>
5202
5203 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5204 gl_state.e_property when gl_state.object is Qt.
5205
5206 * insdel.c (make_gap_larger): Remove limitation of buffer size
5207 to <= INT_MAX.
5208
16a43933
CY
52092011-04-18 Chong Yidong <cyd@stupidchicken.com>
5210
5211 * xdisp.c (lookup_glyphless_char_display)
5212 (produce_glyphless_glyph): Handle cons cell entry in
5213 glyphless-char-display.
5214 (Vglyphless_char_display): Document it.
5215
5216 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5217 glyphless-char-display.
5218
4581706e
CY
52192011-04-17 Chong Yidong <cyd@stupidchicken.com>
5220
5221 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5222
5223 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5224
5225 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5226 definition for no-X builds.
5227
4887c6e2 52282011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5229
fd35b6f9
PE
5230 Static checks with GCC 4.6.0 and non-default toolkits.
5231
5c1ccb01
PE
5232 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5233
006c5daa
PE
5234 * process.c (keyboard_bit_set): Define only if SIGIO.
5235 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5236 (send_process): Repair possible setjmp clobbering.
5237
efc736d3
PE
5238 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5239
4e2fe2e6
PE
5240 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5241
f97334a2
PE
5242 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5243
4e75f29d
PE
5244 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5245 Define only if needed.
5246
90efadd1
PE
5247 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5248 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5249 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5250
3c647824
PE
5251 * dispextern.h (struct redisplay_interface): Rename param
5252 to avoid shadowing.
e264f262 5253 * termhooks.h (struct terminal): Likewise.
761383f4 5254 * xterm.c (xembed_send_message): Likewise.
3c647824 5255
b58c5c4a
PE
5256 * insdel.c (make_gap_smaller): Define only if
5257 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5258
cad59032
PE
5259 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5260 it.
5261
c339dc2e
PE
5262 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5263 so that we aren't warned about unused symbols.
5264
91a3e27b
PE
5265 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5266
399c71d3 5267 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5268
8ffc96f5
PE
5269 * xfns.c (x_real_positions): Mark locals as initialized.
5270
eef9bc79
PE
5271 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5272
098db9dd
PE
5273 * xterm.c: Fix problems found by static analysis with other toolkits.
5274 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5275 (x_dispatch_event): Declare static if USE_GTK, and
5276 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5277 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5278 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5279 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5280 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5281
eb18f6cc
PE
5282 * xmenu.c (menu_help_callback): Pointer type fixes.
5283 Use const pointers when pointing at readonly data. Avoid pointer
5284 signedness clashes.
5285 (FALSE): Remove unused macro.
5286 (update_frame_menubar): Remove unused decl.
5287
1fe72bf8
PE
5288 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5289
60d9e1db
PE
5290 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5291 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5292 (single_menu_item): Rename local to avoid shadowing.
5293
39261c26
PE
5294 * keyboard.c (make_lispy_event): Remove unused local var.
5295
018c5e19
PE
5296 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5297 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5298
63d2b86e
PE
5299 * bitmaps: Change bitmaps from unsigned char back to the X11
5300 compatible char. Avoid the old compiler warnings about
5301 out-of-range initializers by using, for example, '\xab' rather
5302 than 0xab.
5303
aefd87e1
PE
5304 * xgselect.c (xgselect_initialize): Check vs interface
5305 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5306
bf501fb9
PE
5307 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5308
e9829fdf
PE
5309 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5310 to read-only memory.
5311
1086c095
PE
5312 * fns.c (vector): Remove; this old hack is no longer needed.
5313
2baccd04 5314 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5315 Remove unused var.
dde42981 5316 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5317
72391843 5318 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5319
436c16df 5320 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5321 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5322 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5323
92bb796d 5324 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5325 (x_term_init): Remove local to avoid shadowing.
92bb796d 5326
764430a3 5327 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5328
5329 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5330 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5331
d1dfb56c
EZ
53322011-04-16 Eli Zaretskii <eliz@gnu.org>
5333
c4354cb4
EZ
5334 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5335
d1dfb56c
EZ
5336 Fix regex.c, syntax.c and friends for buffers > 2GB.
5337 * syntax.h (struct gl_state_s): Declare character position members
5338 EMACS_INT.
5339
5340 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5341
04f2d78b
CB
5342 * textprop.c (verify_interval_modification, interval_of):
5343 Declare arguments EMACS_INT.
d1dfb56c
EZ
5344
5345 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5346 EMACS_INT.
5347
5348 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5349
5350 * indent.c (Fvertical_motion): Local variable it_start is now
5351 EMACS_INT.
5352
5353 * regex.c (re_match, re_match_2, re_match_2_internal)
5354 (bcmp_translate, regcomp, regexec, print_double_string)
5355 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5356 (re_compile_pattern, re_exec): Declare arguments and local
5357 variables `size_t' and `ssize_t' and return values `regoff_t', as
5358 appropriate.
5359 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5360 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5361 <compile_stack_type>: `size' and `avail' are now `size_t'.
5362
5363 * regex.h <regoff_t>: Use ssize_t, not int.
5364 (re_search, re_search_2, re_match, re_match_2): Arguments that
5365 specify buffer/string position and length are now ssize_t and
5366 size_t. Return type is regoff_t.
5367
613052cd
BK
53682011-04-16 Ben Key <bkey76@gmail.com>
5369
5370 * nsfont.m: Fixed bugs in ns_get_family and
5371 ns_descriptor_to_entity that were caused by using free to
5372 deallocate memory blocks that were allocated by xmalloc (via
5373 xstrdup). This caused Emacs to crash when compiled with
5374 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5375 --enable-checking=xmallocoverrun). xfree is now used to
5376 deallocate these memory blocks.
5377
4170f62f 53782011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5379
71b41406
PE
5380 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5381
9587a89d
PE
5382 emacs_write: Accept and return EMACS_INT for sizes.
5383 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5384 et seq.
5385 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5386 Accept and return EMACS_INT.
5387 (emacs_gnutls_write): Return the number of bytes written on
5388 partial writes.
5389 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5390 (emacs_read, emacs_write): Remove check for negative size, as the
5391 Emacs source code has been audited now.
9587a89d
PE
5392 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5393 (emacs_read, emacs_write): Use it.
273a5f82
PE
5394 * process.c (send_process): Adjust to the new signatures of
5395 emacs_write and emacs_gnutls_write. Do not attempt to store
5396 a byte offset into an 'int'; it might overflow.
9587a89d 5397 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5398
3e047f51
PE
5399 * sound.c: Don't assume sizes fit in 'int'.
5400 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5401 Return EMACS_INT, not int.
3e047f51 5402 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5403 Accept EMACS_INT, not int.
5404 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5405 record read return values.
5406
cc39a9db
BK
54072011-04-15 Ben Key <bkey76@gmail.com>
5408
c9d0ec6d
JB
5409 * keyboard.c (Qundefined): Don't declare static since it is used
5410 in nsfns.m.
5411 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5412 static since they are used in nsfont.m.
cc39a9db 5413
6c60eb9f
SM
54142011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5415
5416 * process.c (Qprocessp): Don't declare static.
5417 * lisp.h (Qprocessp): Declare again.
5418
7990b61a
JB
54192011-04-15 Juanma Barranquero <lekktu@gmail.com>
5420
5421 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5422
5d4cb038
PE
54232011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5424
8bd7b830 5425 Improve C-level modularity by making more things 'static'.
cd64ea1d 5426
e3b27b31
PE
5427 Don't publish debugger-only interfaces to other modules.
5428 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5429 (verify_bytepos, count_markers): Move decls to the only modules
5430 that need them.
5431 * region-cache.h (pp_cache): Likewise.
5432 * window.h (check_all_windows): Likewise.
5433 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5434
5d4cb038
PE
5435 * sysdep.c (croak): Now static, if
5436 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5437 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5438
5439 * alloc.c (refill_memory_reserve): Now static if
5440 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5441 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5442
e87b6180
PE
5443 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5444 Define only if USE_LUCID.
5445
ac64929e
PE
5446 * xrdb.c (x_customization_string, x_rm_string): Now static.
5447
6f37259d
PE
5448 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5449 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5450
1683e3ab
PE
5451 * xdisp.c (draw_row_with_mouse_face): Now static.
5452 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5453
de9c2632
PE
5454 * window.h (check_all_windows): Mark externally visible.
5455
2b96acb7
PE
5456 * window.c (window_deletion_count): Now static.
5457
5458 * undo.c: Make symbols static if they're not exported.
5459 (last_undo_buffer, last_boundary_position, pending_boundary):
5460 Now static.
5461
50436f33
PE
5462 * textprop.c (interval_insert_behind_hooks): Now static.
5463 (interval_insert_in_front_hooks): Likewise.
5464
64520e5c
PE
5465 * term.c: Make symbols static if they're not exported.
5466 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5467 (max_frame_lines, tty_set_terminal_modes):
5468 (tty_reset_terminal_modes, tty_turn_off_highlight):
5469 (get_tty_terminal): Now static.
5470 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5471 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5472 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5473 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5474 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5475
1fa53021
PE
5476 * sysdep.c: Make symbols static if they're not exported.
5477 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5478 Now static.
5479 (sigprocmask_set, full_mask): Remove; unused.
5480 (wait_debugging): Mark as visible.
5481 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5482 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5483
d4b43b22
PE
5484 * syntax.c (syntax_temp): Define only if !__GNUC__.
5485
b7c513d0
PE
5486 * sound.c (current_sound_device, current_sound): Now static.
5487
989b29ad
PE
5488 * search.c (searchbufs, searchbuf_head): Now static.
5489
13a55a78
PE
5490 * scroll.c (scroll_cost): Remove; unused.
5491 * dispextern.h (scroll_cost): Remove decl.
5492
de68a1fc
PE
5493 * region-cache.h (pp_cache): Mark as externally visible.
5494
40ccffa6
PE
5495 * process.c: Make symbols static if they're not exported.
5496 (process_tick, update_tick, create_process, chan_process):
5497 (Vprocess_alist, proc_buffered_char, datagram_access):
5498 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5499 (deactivate_process): Mark defn as static, as well as decl.
5500 * lisp.h (create_process): Remove decl.
5501 * process.h (chan_process, Vprocess_alist): Remove decls.
5502
ad64fc97
PE
5503 * print.c: Make symbols static if they're not exported.
5504 (print_depth, new_backquote_output, being_printed, print_buffer):
5505 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5506 (print_interval, print_number_index, initial_stderr_stream):
5507 Now static.
5508 * lisp.h (Fprinc): Remove decl.
5509 (debug_output_compilation_hack): Mark as externally visible.
5510
adddb265
PE
5511 * sysdep.c (croak): Move decl from here to syssignal.h.
5512 * syssignal.h (croak): Put it here, so the API can be checked when
5513 'croak' is called from dissociate_if_controlling_tty.
5514
1717ede2
PE
5515 * minibuf.c: Make symbols static if they're not exported.
5516 (minibuf_save_list, choose_minibuf_frame): Now static.
5517 * lisp.h (choose_minibuf_frame): Remove decl.
5518
fa5fb2bc
PE
5519 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5520
1e3890d1
PE
5521 * lread.c: Make symbols static if they're not exported.
5522 (read_objects, initial_obarray, oblookup_last_bucket_number):
5523 Now static.
5524 (make_symbol): Remove; unused.
5525 * lisp.h (initial_obarray, make_symbol): Remove decls.
5526
8a1414fa
PE
5527 * keyboard.c: Make symbols static if they're not exported.
5528 (single_kboard, recent_keys_index, total_keys, recent_keys):
5529 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5530 (this_single_command_key_start, echoing, last_auto_save):
5531 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5532 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5533 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5534 (Vlispy_mouse_stem, double_click_count):
5535 Now static.
5536 (force_auto_save_soon): Define only if SIGDANGER.
5537 (ignore_mouse_drag_p): Now static if
5538 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5539 (print_help): Remove; unused.
5540 (stop_character, last_timer_event): Mark as externally visible.
5541 * keyboard.h (ignore_mouse_drag_p): Declare only if
5542 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5543 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5544 * lisp.h (echoing): Remove decl.
5545 (force_auto_save_soon): Declare only if SIGDANGER.
5546 * xdisp.c (redisplay_window): Simplify code, to make it more
5547 obvious that ignore_mouse_drag_p is not accessed if !defined
5548 USE_GTK && !defined HAVE_NS.
5549
93ea6e8f
PE
5550 * intervals.c: Make symbols static if they're not exported.
5551 (merge_properties_sticky, merge_interval_right, delete_interval):
5552 Now static.
5553 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5554
77382fcc
PE
5555 * insdel.c: Make symbols static if they're not exported.
5556 However, leave prepare_to_modify_buffer alone. It's never
5557 called from outside this function, but that appears to be a bug.
5558 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5559 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5560 (adjust_after_replace_noundo): Remove; unused.
5561 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5562 (signal_before_change): Remove decls.
77382fcc 5563
9306c32e
PE
5564 * indent.c (val_compute_motion, val_vmotion): Now static.
5565
cd44d2eb
PE
5566 * image.c: Make symbols static if they're not exported.
5567 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5568 if USE_GTK.
5569 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5570 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5571
ad9a7a06
PE
5572 * fringe.c (standard_bitmaps): Now static.
5573 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5574
81626931
PE
5575 * frame.c: Make symbols static if they're not exported.
5576 (x_report_frame_params, make_terminal_frame): Now static.
5577 (get_frame_param): Now static, unless HAVE_NS.
5578 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5579 (x_get_resource_string): Remove; not used.
5580 * frame.h (make_terminal_frame, x_report_frame_params):
5581 (x_get_resource_string); Remove decls.
5582 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5583 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5584
239f9db9
PE
5585 * font.c, fontset.c: Make symbols static if they're not exported.
5586 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5587 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5588 * font.c (font_close_object): Now static.
5589 * font.h (font_close_object): Remove.
5590 * fontset.c (FONTSET_OBJLIST): Remove.
5591 (free_realized_fontset) #if-0 the body, which does nothing.
5592 (face_suitable_for_char_p): #if-0, as it's never called.
5593 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5594 * xfaces.c (face_at_string_position):
5595 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5596 since 0 is always ASCII.
5597
dfcf3579
PE
5598 * fns.c (weak_hash_tables): Now static.
5599
5045092b
PE
5600 * fileio.c: Make symbols static if they're not exported.
5601 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5602 (Vwrite_region_annotation_buffers): Now static.
5603
57a96f5c
PE
5604 * eval.c: Make symbols static if they're not exported.
5605 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5606 * lisp.h (backtrace_list): Remove decl.
5607
35f08c38
PE
5608 * emacs.c: Make symbols static if they're not exported.
5609 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5610 (fatal_error_code, fatal_error_signal_hook, standard_args):
5611 Now static.
5612 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5613 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5614 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5615 * lisp.h (fatal_error_signal_hook): Remove decl.
5616 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5617
f44bd759
PE
5618 * editfns.c: Move a (normally-unused) function to its only use.
5619 * editfns.c, lisp.h (get_operating_system_release): Remove.
5620 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5621 worth the hassle of breaking this out.
5622
b532497d
PE
5623 * xterm.c: Make symbols static if they're not exported.
5624 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5625 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5626 (x_destroy_window, x_delete_display):
5627 Now static.
5628 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5629 (x_mouse_leave): Remove; unused.
5630 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5631 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5632 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5633 Remove decls.
5634 (x_mouse_leave): Declare only if WINDOWSNT.
5635 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5636 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5637 USE_X_TOOLKIT.
5638
1675728f
PE
5639 * ftxfont.c: Make symbols static if they're not exported.
5640 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5641 HAVE_FREETYPE.
5642 * font.h (ftxfont_driver): Likewise.
5643
e4cebfca
PE
5644 * xfns.c: Make symbols static if they're not exported.
5645 (x_last_font_name, x_display_info_for_name):
5646 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5647 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5648 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5649 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5650 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5651 (last_show_tip_args): Now static.
5652 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5653 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5654 (x_screen_planes): Remove; unused.
5655 * dispextern.h (x_screen_planes): Remove decl.
5656
5bf46f05
PE
5657 * dispnew.c: Make symbols static if they're not exported.
5658 * dispextern.h (redraw_garbaged_frames, scrolling):
5659 (increment_row_positions): Remove.
5660 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5661 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5662 Now static.
5663 (redraw_garbaged_frames): Remove; unused.
5664
435f4c28
PE
5665 * xfaces.c: Make symbols static if they're not exported.
5666 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5667 Remove decls.
5668 * xterm.h (defined_color): Remove decls.
5669 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5670 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5671 (menu_face_changed_default, defined_color, free_realized_face):
5672 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5673 (ascii_face_of_lisp_face): Remove; unused.
5674
8524aef3
PE
5675 * xdisp.c: Make symbols static if they're not exported.
5676 * dispextern.h (scratch_glyph_row, window_box_edges):
5677 (glyph_to_pixel_coords, set_cursor_from_row):
5678 (get_next_display_element, set_iterator_to_next):
5679 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5680 (show_mouse_face): Remove decls
5681 * frame.h (message_buf_print): Likewise.
5682 * lisp.h (pop_message, set_message, check_point_in_composition):
5683 Likewise.
5684 * xterm.h (set_vertical_scroll_bar): Likewise.
5685 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5686 (message_buf_print, scratch_glyph_row, displayed_buffer):
5687 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5688 (get_next_display_element, show_mouse_face, window_box_edges):
5689 (frame_to_window_pixel_xy, check_point_in_composition):
5690 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5691 (glyph_to_pixel_coords): Remove; unused.
5692
16390cd2
PE
5693 * dired.c (file_name_completion): Now static.
5694
5695 * dbusbind.c (xd_in_read_queued_messages): Now static.
5696
a25f4dfa
PE
5697 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5698 * data.c (circular_list_error): Remove.
5699
14a9c8df
PE
5700 * commands.h (last_point_position, last_point_position_buffer):
5701 (last_point_position_window): Remove decls.
5702 * keyboard.c: Make these variables static.
5703
04f2d78b
CB
5704 * coding.h (coding, code_convert_region, encode_coding_gap):
5705 Remove decls.
74ab6df5
PE
5706 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5707 (iso_code_class, detect_coding, code_convert_region): Now static.
5708 (encode_coding_gap): Remove; unused.
5709
38dfbee1
PE
5710 * chartab.c (chartab_chars, chartab_bits): Now static.
5711
a2cb4e63
PE
5712 * charset.h (charset_iso_8859_1): Remove decl.
5713 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5714 Now static.
5715
127198fd
PE
5716 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5717 * ccl.c (Vccl_program_table): Now static.
5718 (check_ccl_update): Remove; unused.
5719
d85b608f
PE
5720 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5721 * category.h: ... from here.
5722 * category.c (check_category_table, set_category_set): Now static.
5723
31cd66f3
PE
5724 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5725 * lisp.h: Remove these decls.
5726
c358e587
PE
5727 * buffer.c (buffer_count): Remove unused var.
5728
e78aecca
PE
5729 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5730 so that it's not optimized away.
5731 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5732 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5733 exported only to the debugger.
5734
e192d7d3 5735 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5736 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5737
92470028
PE
5738 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5739 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5740 was inaccessible from Lisp.
5741 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5742 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5743
244ed907
PE
5744 alloc.c: Import and export fewer symbols, and remove unused items.
5745 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5746 is defined.
5747 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5748 it's not optimized away by whole-program optimization.
5749 (message_enable_multibyte, free_misc): Remove.
5750 (catchlist, handlerlist, mark_backtrace):
5751 Declare only if BYTE_MARK_STACK.
5752 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5753 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5754 (message_enable_multibyte): Remove decl.
5755 (free_misc, interval_free_list, float_block, float_block_index):
5756 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5757 (cons_free_list, last_marked_index):
5758 Now static.
5759 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5760 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5761 (mark_backtrace): Define only if BYTE_MARK_STACK.
5762 * xdisp.c (message_enable_multibyte): Now static.
5763
61c2b50e 5764 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5765 This makes it easier for human readers (and static analyzers)
5766 to see whether these variables are used from other modules.
5767 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5768 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5769 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5770 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5771 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5772 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5773 * xmenu.c, xselect.c:
5774 Declare Q* vars static if they are not used in other modules.
5775 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5776 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5777 Remove decls of unexported vars.
5778 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5779
95c82688
PE
5780 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5781
16a97296
PE
5782 Make Emacs functions such as Fatom 'static' by default.
5783 This makes it easier for human readers (and static analyzers)
5784 to see whether these functions can be called from other modules.
5785 DEFUN now defines a static function. To make the function external
5786 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5787 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5788 (Finit_image_library):
16a97296
PE
5789 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5790 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5791 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5792 Remove decls, since these functions are now static.
5793 (Funintern, Fget_internal_run_time): New decls, since these functions
5794 were already external.
95c82688 5795
16a97296
PE
5796 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5797 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5798 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5799 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5800 * keyboard.c, keymap.c, lread.c:
5801 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5802 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5803 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5804 Mark functions with DEFUE instead of DEFUN,
5805 if they are used in other modules.
5806 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5807 decls for now-static functions.
5808 * buffer.h (Fdelete_overlay): Remove decl.
5809 * callproc.c (Fgetenv_internal): Mark as internal.
5810 * composite.c (Fremove_list_of_text_properties): Remove decl.
5811 (Fcomposition_get_gstring): New forward static decl.
5812 * composite.h (Fcomposite_get_gstring): Remove decl.
5813 * dired.c (Ffile_attributes): New forward static decl.
5814 * doc.c (Fdocumntation_property): New forward static decl.
5815 * eval.c (Ffetch_bytecode): New forward static decl.
5816 (Funintern): Remove extern decl; now in .h file where it belongs.
5817 * fileio.c (Fmake_symbolic_link): New forward static decl.
5818 * image.c (Finit_image_library): New forward static decl.
5819 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5820 * intervals.h (Fprevious_property_change):
5821 (Fremove_list_of_text_properties): Remove decls.
5822 * keyboard.c (Fthis_command_keys): Remove decl.
5823 (Fcommand_execute): New forward static decl.
5824 * keymap.c (Flookup_key): New forward static decl.
5825 (Fcopy_keymap): Now static.
5826 * keymap.h (Flookup_key): Remove decl.
5827 * process.c (Fget_process): New forward static decl.
5828 (Fprocess_datagram_address): Mark as internal.
5829 * syntax.c (Fsyntax_table_p): New forward static decl.
5830 (skip_chars): Remove duplicate decl.
5831 * textprop.c (Fprevious_property_change): New forward static decl.
5832 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5833 Now internal.
5834 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5835 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5836
785bbd42
PE
5837 * editfns.c (Fformat): Remove unreachable code.
5838
8b913b57
AS
58392011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5840
5841 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5842 change. (Bug#8496)
5843
a6744a35
EZ
58442011-04-13 Eli Zaretskii <eliz@gnu.org>
5845
5846 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5847 when at ZV. (Bug#8487)
5848
e7974947
AS
58492011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5850
baad03f0
AS
5851 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5852 (Bug#8437)
5853 * keyboard.c (parse_tool_bar_item): Likewise.
5854 * sound.c (sound_cleanup, alsa_close): Likewise.
5855 * termcap.c (tgetent): Likewise.
5856 * xfns.c (x_default_font_parameter): Likewise.
5857 * xsettings.c (read_and_apply_settings): Likewise.
5858
e7974947
AS
5859 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5860 (overrun_check_free): Protoize.
5861
28272684
PE
58622011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5863
5864 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5865 since callers should never pass a negative size.
5866 Change the signature to match that of plain 'read' and 'write'; see
5867 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5868 * lisp.h: Update prototypes of emacs_write and emacs_read.
5869
11997c76
EZ
58702011-04-11 Eli Zaretskii <eliz@gnu.org>
5871
5872 * xdisp.c (redisplay_window): Don't try to determine the character
5873 position of the scroll margin if the window start point w->startp
e896f03c 5874 is outside the buffer's accessible region. (Bug#8468)
11997c76 5875
8a2cbd72
EZ
58762011-04-10 Eli Zaretskii <eliz@gnu.org>
5877
5878 Fix write-region and its subroutines for buffers > 2GB.
5879 * fileio.c (a_write, e_write): Modify declaration of arguments and
5880 local variables to support buffers larger than 2GB.
5881 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5882
5883 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5884 argument, local variables, and return value.
5885
5886 * lisp.h: Update prototypes of emacs_write and emacs_read.
5887
5888 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5889
4073e537 58902011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5891
1ebfdcb6
PE
5892 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5893
b2ded58d
PE
5894 Fix more problems found by GCC 4.6.0's static checks.
5895
7d66342c
PE
5896 * xdisp.c (vmessage): Use a better test for character truncation.
5897
bbf47d44
PE
5898 * charset.c (load_charset_map): <, not <=, for optimization,
5899 and to avoid potential problems with integer overflow.
9248994d 5900 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5901 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5902 * editfns.c (Fformat): Likewise.
1e69125e 5903 * syntax.c (skip_chars): Likewise.
3befa583 5904
e3019616
PE
5905 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5906 This also lets GCC 4.6.0 generate slightly better loop code.
5907
becfa255
PE
5908 * callint.c (Fcall_interactively): <, not <=, for optimization.
5909 (Fcall_interactively): Count the number of arguments produced,
5910 not the number of arguments given. This is simpler and lets GCC
5911 4.6.0 generate slightly better code.
5912
dae0cd48
PE
5913 * ftfont.c: Distingish more carefully between FcChar8 and char.
5914 The previous code passed unsigned char * to a functions like
5915 strlen and xstrcasecmp that expect char *, which does not
5916 conform to the C standard.
5917 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5918 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5919 char * when the C standard requires it.
5920
76032d70
PE
5921 * keyboard.c (read_char): Remove unused var.
5922
eb3f1cc8
PE
5923 * eval.c: Port to Windows vsnprintf (Bug#8435).
5924 Include <limits.h>.
5925 (SIZE_MAX): Define if the headers do not.
5926 (verror): Do not give up if vsnprintf returns a negative count.
5927 Instead, grow the buffer. This ports to Windows vsnprintf, which
5928 does not conform to C99. Problem reported by Eli Zaretskii.
5929 Also, simplify the allocation scheme, by avoiding the need for
5930 calling realloc, and removing the ALLOCATED variable.
5931
70476b54
PE
5932 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5933
12020a9e
PE
5934 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5935 But keep the doprint source code for now, as we might revamp it
5936 and use it again (Bug#8435).
ea6c7ae6
PE
5937 * lisp.h (doprnt): Remove.
5938 * Makefile.in (base_obj): Remove doprnt.o.
5939 * deps.mk (doprnt.o): Remove.
5940
5fdb398c
PE
5941 error: Print 32- and 64-bit integers portably (Bug#8435).
5942 Without this change, on typical 64-bit hosts error ("...%d...", N)
5943 was used to print both 32- and 64-bit integers N, which relied on
5944 undefined behavior.
5945 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5946 New macro.
5947 * lisp.h (error, verror): Mark as printf-like functions.
5948 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5949 Report overflow in size calculations when allocating printf buffer.
5950 Do not truncate output string at its first null byte.
5951 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5952 Truncate the output at a character boundary, since vsnprintf does not
5953 do that.
5954 * charset.c (check_iso_charset_parameter): Convert internal
5955 character to string before calling 'error', since %c now has the
5956 printf meaning.
5957 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5958 overflow when computing char to be passed to 'error'. Do not
5959 pass Lisp_Object to 'error'; pass the integer instead.
5960 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5961 formatted with plain %d.
5962
b189fa66
PE
5963 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5964
bff87ef0
PE
5965 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5966
7e2cac20
PE
5967 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5968
ce4d90b5
PE
5969 * xterm.c (x_catch_errors): Remove duplicate declaration.
5970
266c9547
PE
5971 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5972
79c49ad2
PE
5973 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5974
368f4090
JM
59752011-04-10 Jim Meyering <meyering@redhat.com>
5976
5977 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5978 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5979 return ssize_t not "int", and use size_t as the buffer length.
5980 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5981 * gnutls.h: Update declarations.
5982 * process.c (read_process_output): Use ssize_t, to match.
5983 (send_process): Likewise.
5984
a32d4040
CY
59852011-04-09 Chong Yidong <cyd@stupidchicken.com>
5986
5987 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5988
8546720e 59892011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5990
04f2d78b
CB
5991 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5992 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5993
8546720e
GM
5994 * xterm.c (handle_one_xevent):
5995 * xmenu.c (create_and_show_popup_menu):
5996 * xselect.c (x_decline_selection_request)
5997 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5998
0a2f5c1a 59992011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
6000
6001 Fix some uses of `int' instead of EMACS_INT.
6002 * search.c (string_match_1, fast_string_match)
6003 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
6004 (scan_buffer, find_next_newline_no_quit)
6005 (find_before_next_newline, search_command, Freplace_match)
6006 (Fmatch_data): Make some `int' variables be EMACS_INT.
6007
6008 * xdisp.c (display_count_lines): 3rd argument and return value now
6009 EMACS_INT. All callers changed.
6010 (pint2hrstr): Last argument is now EMACS_INT.
6011
6012 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6013 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6014 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6015 (decode_coding_utf_16, decode_coding_emacs_mule)
6016 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6017 (decode_coding_ccl, decode_coding_charset)
6018 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6019 (decode_coding_iso_2022, decode_coding_emacs_mule)
6020 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6021 <char_offset, last_offset>: Declare EMACS_INT.
6022 (encode_coding_utf_8, encode_coding_utf_16)
6023 (encode_coding_emacs_mule, encode_invocation_designation)
6024 (encode_designation_at_bol, encode_coding_iso_2022)
6025 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6026 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6027 Declare EMACS_INT.
6028 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6029 (encode_invocation_designation): Last argument P_NCHARS is now
6030 EMACS_INT.
6031 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6032 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6033
6034 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6035 All users changed.
6036
6037 * ccl.c (Fccl_execute_on_string): Declare some variables
6038 EMACS_INT.
6039
8546720e 60402011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6041
6042 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6043
4e19a977
CS
60442011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6045
6046 * process.c (Fformat_network_address): Doc fix.
6047
87302331
R
60482011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6049
6050 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6051
cbb59342
CY
60522011-04-08 Chong Yidong <cyd@stupidchicken.com>
6053
6054 * keyboard.c (read_char): Call Lisp function help-form-show,
6055 instead of using internal_with_output_to_temp_buffer.
6056 (Qhelp_form_show): New var.
e0d38eeb 6057 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6058
6059 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6060
6061 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6062
e67a13ab
CY
60632011-04-06 Chong Yidong <cyd@stupidchicken.com>
6064
04f2d78b
CB
6065 * process.c (Flist_processes): Remove to Lisp.
6066 (list_processes_1): Delete.
e67a13ab 6067
973f782d
EZ
60682011-04-06 Eli Zaretskii <eliz@gnu.org>
6069
7c106b1e
EZ
6070 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6071
973f782d
EZ
6072 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6073
41cf7d1a 60742011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6075
ca23cc88
PE
6076 Fix more problems found by GCC 4.6.0's static checks.
6077
f390e2d5
PE
6078 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6079
42eea0d0
PE
6080 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6081
b69769da 6082 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6083
f9541e84
PE
6084 * xdisp.c (vmessage): Mark as a printf-like function.
6085
13841b55
PE
6086 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6087
c136c10f
PE
6088 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6089
5e2d4a30
PE
6090 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6091 printf-like functions.
6092 (tiff_load): Add casts to remove these marks before passing them
6093 to system-supplied API.
6094
583f48b9
PE
6095 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6096
b25d760e
PE
6097 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6098 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6099 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6100 directly, rather than having caller test rule sign. This avoids
6101 some unnecessary tests.
6102 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6103 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6104 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6105
bc7b6697 6106 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6107 (xfont_open): Avoid unnecessary tests.
bc7b6697 6108
27ccc379
PE
6109 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6110
dcd5c89a
PE
6111 * composite.h, composite.c (composition_gstring_put_cache):
6112 Use EMACS_INT, not int, for length.
6113
b13a45c6
PE
6114 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6115 breaking out part of COMPOSITION_DECODE_RULE.
6116 (COMPOSITION_DECODE_RULE): Use it.
6117 * composite.c (get_composition_id): Remove unused local vars,
6118 by using the new macro.
6119
1e792e4d
PE
6120 * textprop.c (set_text_properties_1): Change while to do-while,
6121 since the condition is always true at first.
6122
dc6c6455 6123 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6124 (interval_deletion_adjustment): Return unsigned value.
6125 All uses changed.
dc6c6455 6126
aba7731a
PE
6127 * process.c (list_processes_1, create_pty, read_process_output):
6128 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6129 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6130 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6131 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6132 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6133
fdfc4bf3
PE
6134 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6135
fca8fe46 6136 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6137 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6138
06a0259a 6139 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6140 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6141 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6142
e7b9e80f
PE
6143 * print.c (print_error_message): Avoid int overflow.
6144
56201685
PE
6145 * font.c (font_list_entities): Redo for clarity,
6146 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6147
78834453 6148 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6149 (font_score): Avoid potential overflow in diff calculation.
78834453 6150
0bc0b309 6151 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6152 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6153
e610eaca
PE
6154 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6155
b895abce
PE
6156 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6157 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6158 can always succeed if overflow has undefined behavior.
6159
1f1d9321 6160 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6161 (wordify): Omit three unnecessary tests.
1f1d9321 6162
c59478bc
PE
6163 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6164 All callers changed. This avoids the need for an unused var.
6165
79b73827
PE
6166 * casefiddle.c (casify_region): Remove var that is set but not used.
6167
a4db5dfe
PE
6168 * dired.c (file_name_completion): Remove var that is set but not used.
6169
43aae36e
PE
6170 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6171
2a47c44d 6172 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6173 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6174
a37c69bf
PE
6175 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6176 Check for integer overflow on size calculations.
6177
328ab8e7
PE
6178 * buffer.c (Fprevious_overlay_change): Remove var that is set
6179 but not used.
6180
e5a2a5cb
PE
6181 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6182 Remove vars that are set but not used.
8d84a6eb 6183 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6184 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6185
a60e5f68
PE
6186 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6187
f661cb61 6188 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6189 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6190
f0397f5a
PE
6191 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6192 that are set but not used.
6193
8664db06 6194 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6195 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6196
6abdaa4a
PE
6197 * xselect.c (x_get_local_selection, x_handle_property_notify):
6198 Remove vars that are set but not used.
6199
0ce7538d 6200 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6201 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6202
9ae848fc
PE
6203 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6204 Remove var that is set but not used.
0b918413
PE
6205 (scroll_bar_windows_size): Now size_t, not int.
6206 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6207 Check for overflow.
9ae848fc 6208
a5a62657
PE
6209 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6210 (map_tty_color) [!defined MSDOS]: Likewise.
6211
5c5cdd39
PE
6212 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6213
66ebf983
PE
6214 * coding.c: Remove vars that are set but not used.
6215 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6216 All callers changed.
6217 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6218 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6219 (decode_coding_charset): Remove vars that are set but not used.
6220
1be4d761
PE
6221 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6222 that is set but not used.
6223
47553fa8
PE
6224 * print.c (print_object): Remove var that is set but not used.
6225
1f7196bf 6226 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6227 The gnulib version avoids calling malloc in the usual case,
6228 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6229 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6230 * filelock.c (current_lock_owner): Likewise.
6231 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6232 * sysdep.c: Include allocator.h, careadlinkat.h.
6233 (emacs_no_realloc_allocator): New static constant.
6234 (emacs_readlink): New function.
fdb61804
PE
6235 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6236 ../lib/careadlinkat.h.
d1fdcab7 6237
f84c17c7
SM
62382011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6239
6240 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6241 first non-nil return value).
6242
ef3862ad
JD
62432011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6244
6245 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6246 if not defined (Bug#8403).
6247
376a7006
JB
62482011-04-02 Juanma Barranquero <lekktu@gmail.com>
6249
6250 * xdisp.c (display_count_lines): Remove parameter `start',
6251 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6252 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6253 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6254 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6255 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6256 and thereabouts. All callers changed.
6257 (get_per_char_metric): Remove parameter `f', unused since
6258 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6259
6ca3801d
JM
62602011-04-02 Jim Meyering <meyering@redhat.com>
6261
6262 do not dereference NULL upon failed strdup
6263 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6264 (ns_get_family): Likewise.
6265
d8e2b5ba
JB
62662011-04-02 Juanma Barranquero <lekktu@gmail.com>
6267
6268 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6269
8c74fcbd
JD
62702011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6271
6272 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6273 later (Bug#8403).
6274
7200d79c
SM
62752011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6276
03408648 6277 Add lexical binding.
7200d79c 6278
03408648
SM
6279 * window.c (Ftemp_output_buffer_show): New fun.
6280 (Fsave_window_excursion):
6281 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6282
6283 * lread.c (lisp_file_lexically_bound_p): New function.
6284 (Fload): Bind Qlexical_binding.
6285 (readevalloop): Remove `evalfun' arg.
6286 Bind Qinternal_interpreter_environment.
6287 (Feval_buffer): Bind Qlexical_binding.
6288 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6289 Mark as dynamic.
6290 (syms_of_lread): Declare `lexical-binding'.
6291
6292 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6293
6294 * keyboard.c (eval_dyn): New fun.
6295 (menu_item_eval_property): Use it.
ca105506
SM
6296
6297 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6298
03408648
SM
6299 * fns.c (concat, mapcar1): Accept byte-code-functions.
6300
6301 * eval.c (Fsetq): Handle lexical vars.
6302 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6303 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6304 (FletX, Flet): Obey lexical binding.
6305 (Fcommandp): Handle closures.
6306 (Feval): New `lexical' arg.
6307 (eval_sub): New function extracted from Feval. Use it almost
6308 everywhere where Feval was used. Look up vars in lexical env.
6309 Handle closures.
6310 (Ffunctionp): Move from subr.el.
6311 (Ffuncall): Handle closures.
6312 (apply_lambda): Remove `eval_flags'.
6313 (funcall_lambda): Handle closures and new byte-code-functions.
6314 (Fspecial_variable_p): New function.
6315 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6316 but without exporting it to Lisp.
23aba0ea 6317
23aba0ea 6318 * doc.c (Fdocumentation, store_function_docstring):
03408648 6319 * data.c (Finteractive_form): Handle closures.
23aba0ea 6320
03408648
SM
6321 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6322 interactive spec.
ba83908c 6323
04f2d78b
CB
6324 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6325 New byte-codes.
03408648
SM
6326 (exec_byte_code): New function extracted from Fbyte_code to handle new
6327 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6328
03408648 6329 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6330
03408648 6331 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6332
e2abce01
JB
63332011-03-31 Juanma Barranquero <lekktu@gmail.com>
6334
6335 * xdisp.c (redisplay_internal): Fix prototype.
6336
63696a73 63372011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6338
63696a73 6339 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6340 (try_scrolling): Use it when setting scroll_limit.
6341 Limit scrolling to 100 screen lines.
63696a73
EZ
6342 (redisplay_window): Even when falling back on "recentering",
6343 position point in the window according to scroll-conservatively,
6344 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6345
6346 (try_scrolling): When point is above the window, allow searching
6347 as far as scroll_max, or one screenful, to compute vertical
6348 distance from PT to the scroll margin position. This prevents
6349 try_scrolling from unnecessarily failing when
6350 scroll-conservatively is set to a value slightly larger than the
6351 window height. Clean up the case of PT below the margin at bottom
6352 of window: scroll_max can no longer be INT_MAX. When aggressive
6353 scrolling is in use, don't let point enter the opposite scroll
6354 margin as result of the scroll.
6355 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6356 threshold of 100 lines for never-recentering scrolling.
6357
e4cc2dfc
JB
63582011-03-31 Juanma Barranquero <lekktu@gmail.com>
6359
6360 * dispextern.h (move_it_by_lines):
6361 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6362 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6363 (message_log_check_duplicate): Remove parameters `prev_bol' and
6364 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6365 (redisplay_internal): Remove parameter `preserve_echo_area',
6366 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6367
6368 * indent.c (Fvertical_motion):
6369 * window.c (window_scroll_pixel_based, Frecenter):
6370 Don't pass `need_y_p' to `move_it_by_lines'.
6371
1c470562
SM
63722011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6373
44f230aa
SM
6374 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6375 steal a few bits to be more compact.
6376 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6377 Remove unneeded casts.
6378
1c470562
SM
6379 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6380
888adce9
ZK
63812011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6382
6383 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6384 binding" message (bug#7967).
6385
f838ed7b
PE
63862011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6387
77861b95
PE
6388 Fix more problems found by GCC 4.6.0's static checks.
6389
de6dbc14
PE
6390 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6391 Remove unused local var.
6392
f838ed7b
PE
6393 * editfns.c (Fmessage_box): Remove unused local var.
6394
792c7b2b
PE
6395 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6396 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6397 Omit unused local vars.
c499e557 6398 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6399 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6400 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6401 Omit unused local var.
6402
ba0165e1
PE
6403 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6404 Don't assume string length fits in int.
32ad8845 6405 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6406 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6407
3c59b4c9
PE
6408 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6409 instead of alloca (Bug#8344).
6410
a3eed478 6411 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6412 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6413
eb4d412d
PE
6414 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6415
1658b401
PE
6416 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6417 concerns.
6418
6419 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6420
6421 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6422
9a2c6e05
PE
6423 * keyboard.c (syms_of_keyboard): Use the same style as later
6424 in this function when indexing through an array. This also
6425 works around GCC bug 48267.
6426
03d0a109
PE
6427 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6428
44f730c8
PE
6429 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6430
fe75f926
PE
6431 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6432 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6433
ffa8c828
PE
6434 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6435 This avoids undefined behavior on integer overflow, and is a bit
6436 more convenient anyway since it is compared to a size_t variable.
6437
c5101a77
PE
6438 Variadic C functions now count arguments with size_t, not int.
6439 This avoids an unnecessary limitation on 64-bit machines, which
6440 caused (substring ...) to crash on large vectors (Bug#8344).
6441 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6442 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6443 All variadic functions and their callers changed accordingly.
c5101a77
PE
6444 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6445 * data.c (arith_driver, float_arith_driver): Likewise.
6446 * editfns.c (general_insert_function): Likewise.
6447 * eval.c (struct backtrace.nargs, interactive_p)
6448 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6449 (funcall_lambda, mark_backtrace): Likewise.
6450 * fns.c (concat): Likewise.
6451 * frame.c (x_set_frame_parameters): Likewise.
6452 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6453 0 if not found, not -1. All callers changed.
6454
dd3f25f7
PE
6455 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6456 (stack_copy_size): Now size_t, not int.
6457 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6458
461c2ab9
JB
64592011-03-28 Juanma Barranquero <lekktu@gmail.com>
6460
6461 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6462 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6463 All callers changed.
6464
6465 * lisp.h (multibyte_char_to_unibyte):
6466 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6467 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6468 * character.h (CHAR_TO_BYTE8):
6469 * cmds.c (internal_self_insert):
6470 * editfns.c (general_insert_function):
6471 * keymap.c (push_key_description):
6472 * search.c (Freplace_match):
6473 * xdisp.c (message_dolog, set_message_1): All callers changed.
6474
f6d62986
SM
64752011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6476
6477 * keyboard.c (safe_run_hook_funcall): New function.
6478 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6479 don't set the hook to nil, but remove the offending function instead.
6480 (Qcommand_hook_internal): Remove, unused.
6481 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6482 Vcommand_hook_internal.
6483
6484 * eval.c (enum run_hooks_condition): Remove.
6485 (funcall_nil, funcall_not): New functions.
6486 (run_hook_with_args): Call each function through a `funcall' argument.
6487 Remove `cond' argument, now redundant.
6488 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6489 (Frun_hook_with_args_until_failure): Adjust accordingly.
6490 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6491
1db5b1ad
JB
64922011-03-28 Juanma Barranquero <lekktu@gmail.com>
6493
6494 * dispextern.h (string_buffer_position): Remove declaration.
6495
6496 * print.c (strout): Remove parameter `multibyte', unused since
6497 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6498
6499 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6500 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6501 All callers changed.
6502
6503 * w32.c (_wsa_errlist): Use braces for struct initializers.
6504
6505 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6506 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6507 All callers changed.
6508 (string_buffer_position): Likewise. Also, make static (it's never
6509 used outside xdisp.c).
6510 (cursor_row_p): Remove parameter `w', unused since
6511 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6512 (decode_mode_spec): Remove parameter `precision', introduced during
6513 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6514 All callers changed.
6515
5ffb62aa
JD
65162011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6517
6518 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6519
461c2ab9 65202011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6521
6522 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6523 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6524 (ns_update_auto_hide_menu_bar): New functions.
6525 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6526 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6527 ns_constrain_all_frames.
6528 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6529 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6530
5c380ffb
JD
65312011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6532
6533 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6534
9af30bdf
GM
65352011-03-27 Glenn Morris <rgm@gnu.org>
6536
6537 * syssignal.h: Replace RETSIGTYPE with void.
6538 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6539 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6540 Replace SIGTYPE with void everywhere.
6541 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6542 * s/template.h (SIGTYPE): Remove commented out definition.
6543
e2abce01
JB
65442011-03-26 Eli Zaretskii <eliz@gnu.org>
6545
6546 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6547 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6548
f868cd8a
JB
65492011-03-26 Juanma Barranquero <lekktu@gmail.com>
6550
59eb0929
JB
6551 * w32.c (read_unc_volume): Use parameter `henum', instead of
6552 global variable `wget_enum_handle'.
6553
6554 * keymap.c (describe_vector): Remove parameters `indices' and
6555 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6556 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6557
f868cd8a
JB
6558 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6559
6560 * keyboard.c (timer_check): Remove parameter `do_it_now',
6561 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6562 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6563 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6564
6565 * keyboard.c (read_char):
6566 * w32menu.c (w32_menu_display_help):
6567 * xmenu.c (show_help_event, menu_help_callback):
6568 Adjust calls to `show_help_echo'.
6569
6570 * gtkutil.c (xg_maybe_add_timer):
6571 * keyboard.c (readable_events):
6572 * process.c (wait_reading_process_output):
6573 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6574
6575 * insdel.c (adjust_markers_gap_motion):
6576 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6577 (gap_left, gap_right): Don't call it.
6578
2ecf6fdb
CY
65792011-03-25 Chong Yidong <cyd@stupidchicken.com>
6580
6581 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6582 incurred during fontification.
6583
6b1f9ba4
JB
65842011-03-25 Juanma Barranquero <lekktu@gmail.com>
6585
6586 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6587 (DEFVAR_PER_BUFFER): Don't pass it.
6588
6589 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6590 (scrolling_window): Don't pass it.
6591
0f4a96b5
JB
65922011-03-25 Juanma Barranquero <lekktu@gmail.com>
6593
6594 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6595
6596 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6597 and `suffix'.
6598 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6599 of variables specific to SELinux and computation of `encoded_absname'.
6600
6601 * image.c (XPutPixel): Remove unused variable `height'.
6602
6603 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6604
6605 * unexw32.c (get_section_info): Remove unused variable `section'.
6606
6607 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6608 (system_process_attributes): Remove unused variable `sess'.
6609 (sys_read): Remove unused variable `err'.
6610
6611 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6612 (w32_wnd_proc): Remove unused variable `isdead'.
6613 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6614 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6615 (x_create_tip_frame): Remove unused variable `tem'.
6616
6617 * w32inevt.c (w32_console_read_socket):
6618 Remove unused variable `no_events'.
6619
6620 * w32term.c (x_draw_composite_glyph_string_foreground):
6621 Remove unused variable `width'.
6622
1149507c
JB
66232011-03-24 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * w32term.c (x_set_glyph_string_clipping):
6626 Don't pass uninitialized region to CombineRgn.
6627
9c88f339
JB
66282011-03-23 Juanma Barranquero <lekktu@gmail.com>
6629
6630 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6631 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6632 (Fx_close_connection): Remove unused variable `i'.
6633
6634 * w32font.c (w32font_draw): Return number of glyphs.
6635 (w32font_open_internal): Remove unused variable `i'.
6636 (w32font_driver): Add missing initializer.
6637
6638 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6639 (fill_in_menu): Remove unused variable `items_added'.
6640
6641 * w32term.c (last_mouse_press_frame): Remove static global variable.
6642 (w32_clip_to_row): Remove unused variable `f'.
6643 (x_delete_terminal): Remove unused variable `i'.
6644
6645 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6646 (NOTHING): Remove unused static global variable.
6647 (uniscribe_check_otf): Remove unused variable `table'.
6648 (uniscribe_font_driver): Add missing initializers.
6649
dee091a3
JD
66502011-03-23 Julien Danjou <julien@danjou.info>
6651
6652 * term.c (Fsuspend_tty, Fresume_tty):
6653 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6654 * window.c (temp_output_buffer_show):
6655 * insdel.c (signal_before_change):
6656 * frame.c (Fhandle_switch_frame):
6657 * fileio.c (Fdo_auto_save):
6658 * emacs.c (Fkill_emacs):
6659 * editfns.c (save_excursion_restore):
6660 * cmds.c (internal_self_insert):
6661 * callint.c (Fcall_interactively):
6662 * buffer.c (Fkill_all_local_variables):
6663 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6664 Use Frun_hooks.
0f4a96b5 6665 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6666 unconditionnaly since it does the check itself.
6667
2c520ab5 66682011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6669
c9c49752
PE
6670 Fix more problems found by GCC 4.5.2's static checks.
6671
8abc3f12
PE
6672 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6673 the first time through the loop, since we know p0 < p1 then.
6674 This also avoids a gcc -Wstrict-overflow warning.
6675
a2d26660
PE
6676 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6677 leading to a memory leak, possible in functions like
6678 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6679 of objects (Bug#8318).
a2d26660 6680
916c72e9
PE
6681 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6682 that could (at least in theory) be that large.
6683
19ab8a18
PE
6684 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6685 This is less likely to overflow, and avoids undefined behavior if
6686 overflow does occur. All callers changed. Use strtoul to scan
6687 for the unsigned long integer.
b7cbbd6f
PE
6688 (pint2hrstr): Simplify and tune code slightly.
6689 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6690
f0641eff
PE
6691 * scroll.c (do_scrolling): Work around GCC bug 48228.
6692 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6693
7f650bb9
PE
6694 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6695 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6696 (validate_x_resource_name): Simplify count usage.
6697 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6698
37dd57d1
PE
6699 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6700 fail (Bug#8306).
81e56e61 6701
699979fc 6702 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6703
401bf9b4
PE
6704 * process.c (Fmake_network_process): Use socklen_t, not int,
6705 where POSIX says socklen_t is required in portable programs.
6706 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6707 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6708 (Fmake_network_process, server_accept_connection):
6709 (wait_reading_process_output, read_process_output):
6710 Likewise.
6711
b93aacde
PE
6712 * process.c: Rename or move locals to avoid shadowing.
6713 (list_processes_1, Fmake_network_process):
6714 (read_process_output_error_handler, exec_sentinel_error_handler):
6715 Rename or move locals.
4dc343ee 6716 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6717 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6718 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6719 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6720 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6721
af8a867c 6722 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6723 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6724 Include tparam.h instead, since it declares them.
af8a867c
PE
6725 * cm.h (PC): Remove extern decl; tparam.h now does this.
6726 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6727 * terminfo.c: Include tparam.h, to check interfaces.
6728 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6729 (tparam): Adjust signature to match interface in tparam.h;
6730 this removes some undefined behavior. Check that outstring and len
6731 are zero, which they always are with Emacs.
6732 * tparam.h (PC, BC, UP): New extern decls.
6733
0248044d 6734 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6735 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6736
8ff096c1 6737 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6738 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6739 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6740 (ftfont_list): Remove unused local.
49eaafba
PE
6741 (get_adstyle_property, ftfont_pattern_entity):
6742 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6743 Rename locals to avoid shadowing.
8ff096c1 6744
e2be39f6
PE
6745 * xfont.c (xfont_list_family): Mark var as initialized.
6746
c9735e30
PE
6747 * xml.c (make_dom): Now static.
6748
8f5201ae
PE
6749 * composite.c (composition_compute_stop_pos): Rename local to
6750 avoid shadowing.
b246f932
PE
6751 (composition_reseat_it): Remove unused locals.
6752 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6753 (composition_update_it): Mark var as initialized.
11b61122
PE
6754 (find_automatic_composition): Mark vars as initialized,
6755 with a FIXME (Bug#8290).
8f5201ae 6756
760fbc2c
PE
6757 character.h: Rename locals to avoid shadowing.
6758 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6759 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6760 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6761 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6762 to avoid shadowing.
6763
ff08eb85
PE
6764 * textprop.c (property_change_between_p): Remove; unused.
6765
fc7bf025
PE
6766 * intervals.c (interval_start_pos): Now static.
6767
235d7abc
PE
6768 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6769
44f230aa
SM
6770 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6771 Rename locals to avoid shadowing.
3e7d6594 6772
50060332
PE
6773 * sound.c (wav_play, au_play, Fplay_sound_internal):
6774 Fix pointer signedness.
d01f234b 6775 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6776 (wav_play): Initialize a variable to 0, to prevent undefined
6777 behavior (Bug#8278).
50060332 6778
c4fc4e30
PE
6779 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6780
918436ed
PE
6781 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6782
c939f91b
PE
6783 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6784 clobbering (Bug#8298).
b9c7f648
PE
6785 * sysdep.c (sys_subshell): Likewise.
6786 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6787
6bd8c144
PE
6788 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6789 This should get cleaned up, so that child_setup has the
6790 same signature on all platforms.
6791
7710357c 6792 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6793 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6794
c59da222
CY
67952011-03-22 Chong Yidong <cyd@stupidchicken.com>
6796
6797 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6798 not to be necessary, and produces flickering.
6799
66b87493
GM
68002011-03-20 Glenn Morris <rgm@gnu.org>
6801
6802 * config.in: Remove file.
6803
45b6f6d5
JB
68042011-03-20 Juanma Barranquero <lekktu@gmail.com>
6805
6806 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6807 are now in src/globals.h.
6808 (syms_of_minibuf): Remove spurious & from previous change.
6809
3ec03f7e
LL
68102011-03-20 Leo <sdl.web@gmail.com>
6811
6812 * minibuf.c (completing-read-function): New variable.
6813 (completing-read-default): Rename from completing-read.
6814 (completing-read): Call completing-read-function.
6815
b14e3e21
CY
68162011-03-19 Juanma Barranquero <lekktu@gmail.com>
6817
6818 * xfaces.c (Fx_load_color_file):
6819 Read color file from absolute filename (bug#8250).
6820
f2b726e6
JB
68212011-03-19 Juanma Barranquero <lekktu@gmail.com>
6822
6823 * makefile.w32-in: Update dependencies.
6824
09f6ff02
EZ
68252011-03-17 Eli Zaretskii <eliz@gnu.org>
6826
6827 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6828
29a6015a
PE
68292011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6830
a3a6c54e
PE
6831 Fix more problems found by GCC 4.5.2's static checks.
6832
b766f867
PE
6833 * process.c (make_serial_process_unwind, send_process_trap):
6834 (sigchld_handler): Now static.
6835
be02381c
PE
6836 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6837 That way, the code declares only the vars that it needs.
6838 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6839 * s/cygwin.h (PTY_ITERATION): Likewise.
6840 * s/darwin.h (PTY_ITERATION): Likewise.
6841 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6842
57048744
PE
6843 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6844 * process.c (allocate_pty): Don't declare stb unless it's needed.
6845
7914961c 6846 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6847 (CONSTANTLIM): Remove; unused.
6848 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6849 Define only if needed.
7914961c 6850
b3967b18
PE
6851 * unexelf.c (unexec): Name an expression,
6852 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6853 Use a different way to cause a compilation error if anyone uses
6854 n rather than nn, a way that does not involve shadowing.
73366a00 6855 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6856
29a6015a
PE
6857 * deps.mk (unexalpha.o): Remove; unused.
6858
43cfc33e 6859 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6860 * unexec.h: New file.
ce701a33
PE
6861 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6862 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6863 Depend on unexec.h.
6864 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6865 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6866 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6867 Change as necessary to match prototype in unexec.h.
ce701a33 6868
01f44d5a
PE
6869 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6870 shadowing.
4f63c6bb 6871 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6872
a6670b0b
PE
6873 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6874 Rename locals to avoid shadowing.
6875
cef2010d 6876 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6877 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6878
d4d7173a
PE
6879 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6880
f08b802a
PE
6881 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6882 warning when compiling print.c.
6883
3ddb0639
PE
6884 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6885 instead of using an uninitialized var.
5ad03b97 6886 (font_sort_entities): Mark var as initialized.
3ddb0639 6887
170a2692
PE
6888 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6889
e663c700
PE
6890 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6891 pointers to constants.
89bc529a 6892 (font_parse_fcname): Remove unused vars.
7b81e2d0 6893 (font_delete_unmatched): Now static.
ea838e10 6894 (font_get_spec): Remove; unused.
13a547c6
PE
6895 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6896 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6897 Rename or move locals to avoid shadowing.
e663c700 6898
2a80c887 6899 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6900 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6901
1384fa33 6902 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6903 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6904
8b2c52e9
PE
6905 * alloc.c (mark_backtrace): Move decl from here ...
6906 * lisp.h: ... to here, so that it can be checked.
6907
475545b5 6908 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6909 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6910 (lisp_indirect_variable): Name an expression,
6911 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6912 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6913
b1349114 6914 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6915 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6916 Use const pointer when appropriate.
b1349114 6917
a2928364
PE
6918 * lisp.h (get_system_name, get_operating_system_release):
6919 Move decls here, to check interfaces.
6920 * process.c (get_operating_system_release): Move decl to lisp.h.
6921 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6922 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6923 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6924 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6925 (Fformat_time_string, Fencode_time, Finsert_char):
6926 (Ftranslate_region_internal, Fformat):
6927 Rename or remove local vars to avoid shadowing.
9710023e 6928 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6929
a415e694
PE
6930 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6931 avoid shadowing.
6932
8ef4622d
PE
6933 * lisp.h (eassert): Check that the argument compiles, even if
6934 ENABLE_CHECKING is not defined.
6935
946f9a5b
PE
6936 * data.c (Findirect_variable): Name an expression, to avoid
6937 gcc -Wbad-function-cast warning.
112396d6 6938 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6939 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6940 (Fmake_variable_buffer_local, Fmake_local_variable):
6941 Mark variables as initialized.
52746918 6942 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6943
e5aab7e7 6944 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6945 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6946 Rename locals to avoid shadowing.
dff45157
PE
6947 (mark_stack): Move local variables into the #ifdef region where
6948 they're used.
7bc26fdb
PE
6949 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6950 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6951 needed otherwise.
6952 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6953 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6954 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6955
e5aab7e7
PE
6956 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6957 avoids undefined behavior in theory.
6958
4da60324
PE
6959 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6960
88043301
PE
6961 Use functions, not macros, for up- and down-casing (Bug#8254).
6962 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6963 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6964 to use the following functions instead of these macros.
6965 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6966 EMACS_INT, since callers assume the returned value fits in int.
6967 (upcase1): Likewise, for UPCASE_TABLE.
6968 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6969 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6970 the race-condition problem in the old DOWNCASE.
88043301 6971
19ed5445
PE
6972 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6973 Rename locals to avoid shadowing.
6974 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6975 (regex_compile, re_search_2, re_match_2_internal):
6976 Remove unused local vars.
952db0d7
PE
6977 (FREE_VAR): Rewrite so as not to use empty "else",
6978 which gcc can warn about.
da053e48 6979 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6980 (RETALLOC_IF): Define only if needed.
6981 (WORDCHAR_P): Likewise. This one is never needed, but is used
6982 only in a comment talking about a compiler bug, so put inside
6983 the #if 0 of that comment.
6984 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6985 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6986 Remove; unused.
19ed5445 6987
1f3561e4 6988 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6989 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6990 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6991
ded6f8f7
PE
6992 * search.c (simple_search): Remove unused var.
6993
dbd37a95
PE
6994 * dired.c (compile_pattern): Move decl from here ...
6995 * lisp.h: ... to here, so that it can be checked.
6996 (struct re_registers): New forward decl.
6997
7e47afad
PE
6998 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6999
85f24f61
PE
7000 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
7001 All uses changed.
7002 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
7003 Rename locals to avoid shadowing.
5671df8f 7004 (Fvertical_motion): Mark locals as initialized.
85f24f61 7005
181aa2be 7006 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7007 (casify_region): Mark local as initialized.
181aa2be 7008
930d429c
PE
7009 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7010
7082eac6
PE
7011 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7012 New macros, so that the caller can use some names other than
7013 gcpro1, gcpro2, etc.
7014 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7015 of the new macros.
7016 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7017 argument, for consistency with GCPRO2_VAR, etc: it is now the
7018 prefix of the variable, not the variable itself. All uses
7019 changed.
38b2c076
PE
7020 * dired.c (directory_files_internal, file_name_completion):
7021 Rename locals to avoid shadowing.
7022
15206ed9
PE
7023 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7024 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7025 dired.c's scmp function, had undefined behavior.
7026 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7027 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7028 * buffer.h: ... to here, because these macros use current_buffer,
7029 and the new implementation with inline functions needs to have
7030 current_buffer in scope now, rather than later when the macros
7031 are used.
7032 (downcase, upcase1): New static inline functions.
7033 (DOWNCASE, UPCASE1): Reimplement using these functions.
7034 This avoids undefined behavior in expressions like
7035 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7036 from race conditions in accessing the global variables
7037 case_temp1 and case_temp2.
7038 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7039 * lisp.h (case_temp1, case_temp2): Remove their decls.
7040 * character.h (ASCII_CHAR_P): Move from here ...
7041 * lisp.h: ... to here, so that the inline functions mentioned
7042 above can use them.
7043
4a6bea26
PE
7044 * dired.c (directory_files_internal_unwind): Now static.
7045
f14b7e14
PE
7046 * fileio.c (file_name_as_directory, directory_file_name):
7047 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7048 Now static.
2893f146
PE
7049 (file_name_as_directory): Use const pointers when appropriate.
7050 (Fexpand_file_name): Likewise. In particular, newdir might
7051 point at constant storage, so make it a const pointer.
fd4ead52 7052 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7053 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7054 signedness issues.
f839df0c
PE
7055 (Fset_file_times, Finsert_file_contents, auto_save_error):
7056 Rename locals to avoid shadowing.
f14b7e14 7057
5716756e 7058 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7059 (Ftry_completion, Fall_completions): Rename or remove locals
7060 to avoid shadowing.
5716756e 7061
b4c3046a
PE
7062 * marker.c (bytepos_to_charpos): Remove; unused.
7063
b45db522
PE
7064 * lisp.h (verify_bytepos, count_markers): New decls,
7065 so that gcc does not warn that these functions aren't declared.
7066
85876d07
PE
7067 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7068 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7069 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7070 (copy_text): Remove unused local var.
85876d07 7071
03d78a21 7072 * filelock.c (within_one_second): Now static.
b3dd38ab 7073 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7074
5df8f01b
PE
7075 * buffer.c (fix_overlays_before): Mark locals as initialized.
7076 (fix_start_end_in_overlays): Likewise. This function should be
7077 simplified by using pointers-to-pointers, but that's a different
7078 matter.
b1d876f1 7079 (switch_to_buffer_1): Now static.
8f54f30a
PE
7080 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7081 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7082
a70072c9 7083 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7084 Fix pointer signedness issue.
edced198
PE
7085 (sys_subshell): Mark local as volatile if checking for lint,
7086 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7087 (MAXPATHLEN): Define only if needed.
a70072c9 7088
a0977c44
PE
7089 * process.c (serial_open, serial_configure): Move decls from here ...
7090 * systty.h: ... to here, so that they can be checked.
7091
a884fdcc
PE
7092 * fns.c (get_random, seed_random): Move extern decls from here ...
7093 * lisp.h: ... to here, so that they can be checked.
7094
604efe86 7095 * sysdep.c (reset_io): Now static.
b8950c94 7096 (wait_for_termination_signal): Remove; unused.
604efe86 7097
38fc62d9
PE
7098 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7099 (copy_keymap_item, append_key, push_text_char_description):
7100 Now static.
1004a21a 7101 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7102 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7103 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7104 (describe_map_tree):
7105 Rename locals to avoid shadowing.
38fc62d9 7106
2f2650da
PE
7107 * keyboard.c: Declare functions static if they are not used elsewhere.
7108 (echo_char, echo_dash, cmd_error, top_level_2):
7109 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7110 (read_char, kbd_buffer_get_event, make_lispy_position):
7111 (make_lispy_event, make_lispy_movement, apply_modifiers):
7112 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7113 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7114 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7115 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7116 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7117
a053e86c 7118 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7119 (mark_kboards): Move decl here ...
7120 * alloc.c (mark_kboards): ... from here.
a053e86c 7121
4752793e
PE
7122 * lisp.h (force_auto_save_soon): New decl.
7123
74f10ca7 7124 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7125 (DEFINE_DUMMY_FUNCTION): New macro.
7126 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7127 Use it.
c03cd23f
PE
7128 (main): Add casts to avoid warnings
7129 if GCC considers string literals to be constants.
74f10ca7 7130
022e70d4
PE
7131 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7132
59d6fe83
PE
7133 * dbusbind.c: Pointer signedness fixes.
7134 (xd_signature, xd_append_arg, xd_initialize):
7135 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7136 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7137 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7138 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7139
78320123
PE
7140 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7141 if GCC considers string literals to be constants.
49cebcca 7142 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7143
35ac2a97
SM
71442011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7145
fb103ca9
SM
7146 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7147 (print_preprocess, print_object): New macro to fix last change.
7148
35ac2a97
SM
7149 * print.c (print_preprocess): Don't forget font objects.
7150
62973b41
JB
71512011-03-16 Juanma Barranquero <lekktu@gmail.com>
7152
7153 * emacs.c (USAGE3): Doc fixes.
7154
0e48bb22
AS
71552011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7156
7157 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7158 structure.
7159
7684e57b
JB
71602011-03-14 Juanma Barranquero <lekktu@gmail.com>
7161
7162 * lisp.h (VWindow_system, Qfile_name_history):
7163 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7164 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7165 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7166
7167 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7168 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7169
7170 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7171 * w32console.c (detect_input_pending, read_input_pending)
7172 (encode_terminal_code):
7173 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7174 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7175 (w32_system_caret_y, Qfile_name_history):
7176 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7177 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7178 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7179 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7180 * w32proc.c (Qlocal, report_file_error):
7181 * w32term.c (Vwindow_system, updating_frame):
7182 * w32uniscribe.c (initialized, uniscribe_font_driver):
7183 Remove unneeded extern declarations.
7184
2aa46d6c
CY
71852011-03-14 Chong Yidong <cyd@stupidchicken.com>
7186
c96bbc66 7187 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7188
cffc6f3b
CY
71892011-03-13 Chong Yidong <cyd@stupidchicken.com>
7190
7191 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7192 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7193 These macros can no longer be used for assignment.
7194
44f230aa
SM
7195 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7196 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7197 (record_buffer_markers, fetch_buffer_markers): New functions for
7198 recording and fetching special buffer markers.
7199 (set_buffer_internal_1, set_buffer_temp): Use them.
7200
7201 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7202
7203 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7204
7205 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7206 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7207
7208 * xdisp.c (hscroll_window_tree):
7209 (reconsider_clip_changes): Use PT instead of BUF_PT.
7210
d251f04b
EZ
72112011-03-13 Eli Zaretskii <eliz@gnu.org>
7212
7213 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7214 $(EMACS_ROOT)/lib/intprops.h.
7215
f0c77cd1
PE
72162011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7217
3eca4629
PE
7218 Fix more problems found by GCC 4.5.2's static checks.
7219
7c86ee98
PE
7220 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7221 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7222 (xg_free_frame_widgets): Make it clear that a local variable is
7223 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7224 (gdk_window_get_screen): Make it clear that this macro is needed
7225 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7226 (int_gtk_range_get_value): New function, which avoids a diagnostic
7227 from gcc -Wbad-function-cast.
7228 (xg_set_toolkit_scroll_bar_thumb): Use it.
7229 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7230 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7231 (get_utf8_string, xg_get_file_with_chooser):
7232 Rename locals to avoid shadowing.
7233 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7234
41729b81
PE
7235 * xgselect.c (xg_select): Remove unused var.
7236
f0c77cd1
PE
7237 * image.c (four_corners_best): Mark locals as initialized.
7238 (gif_load): Initialize transparent_p to zero (Bug#8238).
7239 Mark another local as initialized.
ec6cf4c6 7240 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7241
ce0ad53d 7242 * image.c (clear_image_cache): Now static.
d5d5a617 7243 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7244 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7245 (x_edge_detection): Remove unnecessary cast that
7246 gcc -Wbad-function-cast diagnoses.
2037898d 7247 (gif_load): Fix pointer signedness.
6ae141d6
PE
7248 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7249 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7250
33383987 72512011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7252
d32df629
PE
7253 Improve quality of tests for time stamp overflow.
7254 For example, without this patch (encode-time 0 0 0 1 1
7255 1152921504606846976) returns the obviously-bogus value (-948597
7256 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7257 reports time overflow. See
7258 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7259 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7260 * editfns.c: Include limits.h and intprops.h.
7261 (TIME_T_MIN, TIME_T_MAX): New macros.
7262 (time_overflow): Move earlier, to before first use.
7263 (hi_time, lo_time): New functions, for an accurate test for
7264 out-of-range times.
7265 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7266 (Fget_internal_run_time): Don't assume time_t fits in int.
7267 (make_time): Use list2 instead of Fcons twice.
7268 (Fdecode_time): More accurate test for out-of-range times.
7269 (check_tm_member): New function.
7270 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7271 (lisp_time_argument): Don't rely on undefined left-shift and
7272 right-shift behavior when checking for time stamp overflow.
8be6f318 7273
fe31d94c
PE
7274 * editfns.c (time_overflow): New function, refactoring common code.
7275 (Fformat_time_string, Fdecode_time, Fencode_time):
7276 (Fcurrent_time_string): Use it.
7277
8be6f318
PE
7278 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7279 * dired.c (make_time): Move to ...
7280 * editfns.c (make_time): ... here.
7281 * systime.h: Note the move.
7282
09d9db2c 72832011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7284
126bc0dc
YM
7285 * fringe.c (update_window_fringes): Remove unused variables.
7286
c47cbdfd
YM
7287 * unexmacosx.c (copy_data_segment): Also copy __got section.
7288 (Bug#8223)
7289
7ac80be9
EZ
72902011-03-12 Eli Zaretskii <eliz@gnu.org>
7291
c96bbc66 7292 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7293 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7294 Constify `char *' arguments and their references according to
7295 prototypes in tparam.h.
7296
ecb0f94d 7297 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7298
7ac80be9
EZ
7299 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7300 Adapt all references accordingly.
7301
7302 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7303
ef1fd07e
TT
73042011-03-11 Tom Tromey <tromey@redhat.com>
7305
7306 * buffer.c (syms_of_buffer): Remove obsolete comment.
7307
7ef4b50c
EZ
73082011-03-11 Eli Zaretskii <eliz@gnu.org>
7309
7310 * termhooks.h (encode_terminal_code): Declare prototype.
7311
7312 * msdos.c (encode_terminal_code): Don't declare prototype.
7313
7314 * term.c (encode_terminal_code): Now external again, used by
7315 w32console.c and msdos.c.
7316
44f230aa
SM
7317 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7318 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7319
4b1ec863 73202011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7321
1714f52b 7322 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7323
4b1ec863
PE
7324 * fringe.c (update_window_fringes): Mark locals as initialized
7325 (Bug#8227).
7326 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7327
524c7aa6
PE
7328 * alloc.c (mark_fringe_data): Move decl from here ...
7329 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7330 to check its interface.
7331 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7332
a5c0af81 7333 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7334 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7335 (fontset_font): Mark local as initialized.
a9a06e0b 7336 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7337
b4716021
PE
7338 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7339
811e9bac 7340 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7341 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7342 (x_own_selection, Fx_disown_selection_internal): Rename locals
7343 to avoid shadowing.
7344 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7345
7e3ab302
PE
7346 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7347 so that the caller can use some name other than gcpro1.
7348 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7349 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7350 (Fx_backspace_delete_keys_p):
7351 Use them to avoid shadowing, and rename vars to avoid shadowing.
7352 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7353 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7354 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7355 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7356 Remove unused locals.
7e3ab302
PE
7357 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7358 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7359 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7360 macros.
f78faa98 7361
e2b13473
PE
7362 * xterm.h (x_mouse_leave): New decl.
7363
77f23912
PE
7364 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7365 Remove unused functions.
cdf4ba58
PE
7366 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7367 (x_calc_absolute_position): Now static.
7411c686 7368 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7369 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7370 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7371 unless they are used.
38d0b34a
PE
7372 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7373 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7374 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7375 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7376 (x_error_catcher, x_connection_closed, x_error_handler):
7377 (x_error_quitter, xembed_send_message, x_iconify_frame):
7378 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7379 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7380 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7381
44f230aa
SM
7382 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7383 Rename or move locals to avoid shadowing.
6b463e58 7384 (tty_defined_color, merge_face_heights): Now static.
5967d051 7385 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7386 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7387 does not deduce is never used uninitialized.
73719eba
PE
7388 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7389 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7390
426994c3 7391 * terminal.c (store_terminal_param): Now static.
5489860b 7392
032f1620 7393 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7394 (set_frame_menubar): Remove unused local.
d4323972 7395 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7396 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7397 since they might point to immutable storage.
281585b0
PE
7398 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7399 since it's unused otherwise.
032f1620 7400
367c19e5 7401 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7402 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7403 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7404 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7405 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7406 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7407 does not deduce are never used uninitialized.
70739cbe 7408
07b48fa9
PE
7409 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7410
8868a238 7411 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7412 * window.c (window_loop, size_window):
7413 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7414
7e5cf297 7415 * window.c (display_buffer): Now static.
d6550a9f
PE
7416 (size_window): Mark variables that gcc -Wuninitialized
7417 does not deduce are never used uninitialized.
a586633d
PE
7418 * window.h (check_all_windows): New decl, to forestall
7419 gcc -Wmissing-prototypes diagnostic.
5b555da1 7420 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7421
f6095868
PE
7422 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7423 shadowing.
7424 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7425 Include <limits.h>.
7426 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7427 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7428 (load_charset_map): Mark variables that gcc -Wuninitialized
7429 does not deduce are never used uninitialized.
53df7c11 7430 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7431
f38b440c
PE
7432 * coding.c (coding_set_source, coding_set_destination):
7433 Use "else { /* comment */ }" rather than "else /* comment */;"
7434 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7435 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7436 a block, when the outer 'i' will do.
7437 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7438 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7439 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7440 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7441 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7442 Rename locals to avoid shadowing.
7443 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7444 * coding.c (emacs_mule_char, encode_invocation_designation):
7445 Now static, since they're not used elsewhere.
413bb2db 7446 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7447 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7448 (decode_coding_emacs_mule): Mark variables that gcc
7449 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7450 (detect_coding_iso_2022): Initialize a local variable that might
7451 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7452 this initialization is needed. (Bug#8211)
5f58e762
PE
7453 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7454 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7455 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7456 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7457 Remove unused macros.
f38b440c 7458
232b38b9 7459 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7460 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7461 * character.c (string_count_byte8): Likewise.
232b38b9 7462
fb90da1b
PE
7463 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7464 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7465
fb93dbc2
PE
7466 * chartab.c (copy_sub_char_table): Now static, since it's not used
7467 elsewhere.
5c156ace
PE
7468 (sub_char_table_ref_and_range, char_table_ref_and_range):
7469 Rename locals to avoid shadowing.
bbcd0949 7470 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7471
7d3b3862 7472 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7473 (BIDI_BOB): Remove unused macro.
7d3b3862 7474
6be7d3da
PE
7475 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7476 deduce are never used uninitialized.
c2ed9c8b 7477 * term.c (encode_terminal_code): Likewise.
6be7d3da 7478
75f8807f 7479 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7480
50938595
PE
7481 * tparam.h: New file.
7482 * term.c, tparam.h: Include it.
7483 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7484 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7485 Move these decls to tparam.h, and make them agree with what
7486 is actually in tparam.c. The previous trick of using incompatible
7487 decls in different modules does not conform to the C standard.
7488 All callers of tparam changed to use tparam's actual API.
7489 * tparam.c (tparam1, tparam, tgoto):
7490 Use const pointers where appropriate.
7491
fbceeba2
PE
7492 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7493 * cm.h (struct cm): Likewise.
7494 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7495 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7496 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7497 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7498 (turn_on_face, init_tty): Likewise.
7499 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7500
7f3f1250
PE
7501 * term.c (term_mouse_position): Rename local to avoid shadowing.
7502
e6ca6543
PE
7503 * alloc.c (mark_ttys): Move decl from here ...
7504 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7505
c40f8d15
AS
75062011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7507
7508 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7509
cfe0661d
JB
75102011-03-09 Juanma Barranquero <lekktu@gmail.com>
7511
7512 * search.c (compile_pattern_1): Remove argument regp, unused since
7513 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7514 (compile_pattern): Don't pass it.
7515
0afb4571
J
75162011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7517
7518 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7519 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7520 for ! HAVE_GTK3.
7521 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7522
7523 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7524
7525 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7526 gdk_window_get_screen, gdk_window_get_geometry,
7527 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7528 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7529 (xg_get_pixbuf_from_pixmap): New function.
7530 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7531 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7532 Call xg_get_pixbuf_from_pixmap instead of
7533 gdk_pixbuf_get_from_drawable.
7534 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7535 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7536 (xg_check_special_colors): Use GtkStyleContext and its functions
7537 for HAVE_GTK3.
7538 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7539 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7540 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7541 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7542 Call gtk_widget_get_preferred_size.
0afb4571
J
7543 (xg_frame_resized): gdk_window_get_geometry only takes 5
7544 parameters.
44f230aa
SM
7545 (xg_win_to_widget, xg_event_is_for_menubar):
7546 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7547 (xg_set_widget_bg): New function.
7548 (delete_cb): New function.
895009e1 7549 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7550 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7551 (xg_set_background_color): Call xg_set_widget_bg.
7552 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7553 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7554 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7555 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7556 if ! HAVE_GTK3.
7557 (update_frame_tool_bar): Call gtk_widget_hide.
7558 (xg_initialize): Use GDK_KEY_g.
7559
7560 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7561 if ! HAVE_GTK3
7562 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7563
7564 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7565 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7566 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7567
1c2cc4ef
JB
75682011-03-08 Juanma Barranquero <lekktu@gmail.com>
7569
7570 * w32xfns.c (select_palette): Check success of RealizePalette against
7571 GDI_ERROR, not zero.
7572
33383987 7573See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7574
7575;; Local Variables:
7576;; coding: utf-8
aac0c6e3
MR
7577;; End:
7578
33383987 7579 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7580
7581 This file is part of GNU Emacs.
7582
7583 GNU Emacs is free software: you can redistribute it and/or modify
7584 it under the terms of the GNU General Public License as published by
7585 the Free Software Foundation, either version 3 of the License, or
7586 (at your option) any later version.
7587
7588 GNU Emacs is distributed in the hope that it will be useful,
7589 but WITHOUT ANY WARRANTY; without even the implied warranty of
7590 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7591 GNU General Public License for more details.
7592
7593 You should have received a copy of the GNU General Public License
7594 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.