Remove inadvertent x permissions from 4 images.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
2e621251
PE
12011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2
3 * xselect.c: Relax test for outgoing X longs (Bug#9498).
4 (cons_to_x_long): New function.
5 (lisp_data_to_selection_data): Use it. Correct the test for
6 short-versus-long data; it was negated. Break out of vector
7 loop, for efficiency, when a long datum is discovered.
8
91a15bc6
SM
92011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
10
11 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
12
b41c3a35
EZ
132011-09-16 Eli Zaretskii <eliz@gnu.org>
14
15 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
16 GCC PR/17406) by declaring this function with external scope.
17
7812ba2d
PE
182011-09-15 Paul Eggert <eggert@cs.ucla.edu>
19
20 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
21 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
22
cf7edc2a
AS
232011-09-15 Andreas Schwab <schwab@linux-m68k.org>
24
25 * editfns.c (Fformat): Correctly handle text properties on "%%".
26
bd01620e
EZ
272011-09-15 Eli Zaretskii <eliz@gnu.org>
28
29 * xterm.c (x_draw_composite_glyph_string_foreground):
30 * w32term.c (x_draw_composite_glyph_string_foreground):
31 * term.c (encode_terminal_code):
32 * composite.c (composition_update_it, get_composition_id):
33 * xdisp.c (get_next_display_element)
34 (fill_composite_glyph_string): Add comments about special meaning
35 of TAB characters in a composition.
36
a02719a3
PE
372011-09-15 Paul Eggert <eggert@cs.ucla.edu>
38
39 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
40 This occurs when processing a multibyte format.
41 Problem reported by Wolfgang Jenker.
a02719a3 42
72589a3c
JB
432011-09-15 Johan Bockgård <bojohan@gnu.org>
44
45 * xdisp.c (try_cursor_movement): Only check for exact match if
46 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
47
1c14176c
PE
482011-09-14 Paul Eggert <eggert@cs.ucla.edu>
49
50 Remove unused external symbols.
51 * dispextern.h (calc_pixel_width_or_height): Remove decl.
52 * xdisp.c (calc_pixel_width_or_height): Now static.
53 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
54 * indent.c (check_display_width):
55 * w32term.c: Fix comment to match code.
56 * xterm.c, xterm.h (x_catching_errors): Remove.
57
d2eea5b5
PE
582011-09-14 Paul Eggert <eggert@cs.ucla.edu>
59
60 * xselect.c: Use signed conversions more consistently (Bug#9498).
61 (selection_data_to_lisp_data): Assume incoming selection data are
62 signed integers, not unsigned. This is to be consistent with
63 outgoing selection data, which was modified to use signed integers
64 in as part of the fix to Bug#9196 in response to Jan D.'s comment
65 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
66 expects long, not unsigned long.
67
46888499
EZ
682011-09-14 Eli Zaretskii <eliz@gnu.org>
69
70 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
71 computation of loop end. Reported by Johan Bockgård
72 <bojohan@gnu.org>.
73
ef8ef9fb
CY
742011-09-13 Chong Yidong <cyd@stupidchicken.com>
75
76 * frame.c (Fother_visible_frames_p): Function deleted.
77
fa819fed
EZ
782011-09-12 Eli Zaretskii <eliz@gnu.org>
79
80 * indent.c (compute_motion): Process display vector front to back
81 rather than the other way around. (Bug#2496)
82
2ba8e008
SM
832011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
84
85 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
86
20f53c69
CY
872011-09-11 Chong Yidong <cyd@stupidchicken.com>
88
89 * minibuf.c (Fread_from_minibuffer): Doc fix.
90
d562d7a4
EZ
912011-09-11 Eli Zaretskii <eliz@gnu.org>
92
93 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
94 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
95
1c4d7f3d
LMI
962011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
97
98 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
99 value for non-existent files.
100
b885bf36
EZ
1012011-09-11 Eli Zaretskii <eliz@gnu.org>
102
103 * fileio.c (Finsert_file_contents): If the file cannot be opened,
104 set its "size" to -1. This will set the modtime_size field of
105 the corresponding buffer to -1, which is what
106 verify-visited-file-modtime expects for files that do not exist.
107 (Bug#9139)
108
6612f0bf
PE
1092011-09-11 Paul Eggert <eggert@cs.ucla.edu>
110
111 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
112 here ...
113 * lisp.h: ... from here. push_key_description is no longer
114 defined in keyboard.c, so its declaration should not be in
115 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
116 logically belongs with push_key_description.
117
dfb3f755
PE
1182011-09-10 Paul Eggert <eggert@cs.ucla.edu>
119
120 * buffer.h: Include <sys/types.h> instead of <time.h>.
121 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
122 Problem reported by Herbert J. Skuhra.
123
3134906c
LMI
1242011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
125
126 * xml.c (parse_region): Make the parsing work for
127 non-comment-starting XML files again (bug#9144).
128
8d903f4e
AS
1292011-09-10 Andreas Schwab <schwab@linux-m68k.org>
130
131 * image.c (gif_load): Fix calculation of bottom and right corner.
132 (Bug#9468)
133
80ad64f4
EZ
1342011-09-10 Eli Zaretskii <eliz@gnu.org>
135
136 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
137 redisplay in small windows.
138
208a048d
EZ
1392011-09-09 Eli Zaretskii <eliz@gnu.org>
140
141 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
142
9b1c252e
MR
1432011-09-08 Martin Rudalics <rudalics@gmx.at>
144
145 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
146 Operate on live windows only.
147
2949f33b
JB
1482011-09-08 Juanma Barranquero <lekktu@gmail.com>
149
150 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
151
e08dcafd
EZ
1522011-09-07 Eli Zaretskii <eliz@gnu.org>
153
154 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
155 only under bidi iteration.
156
115b96bd
JD
1572011-09-07 Jan Djärv <jan.h.d@swipnet.se>
158
159 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
160
c8199d0f
PE
1612011-09-06 Paul Eggert <eggert@cs.ucla.edu>
162
163 isnan: Fix porting problem to Solaris 10 with bundled gcc.
164 Without this fix, the command to link temacs failed due to an
165 undefined symbol __builtin_isnan. This is because
166 /usr/include/iso/math_c99.h #defines isnan(x) to
167 __builtin_isnan(x), but the bundled gcc, which identifies itself
168 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
169 a __builtin_isnan.
170 * floatfns.c (isnan): #undef, and then #define to a clone of
171 what's in data.c.
172 (Fisnan): Always define, since it's always available now.
173 (syms_of_floatfns): Always define isnan at the Lisp level.
174
e39b275c 1752011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
176
177 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
178
b2db44d9 1792011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 180
f4af5137 181 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
182 The previous code assumed that file offsets (off_t values) fit in
183 EMACS_INT variables, which is not true on typical 32-bit hosts.
184 The code messed up by falsely reporting buffer overflow in cases
185 such as (insert-file-contents "big" nil 1 2) into an empty buffer
186 when "big" contains more than 2**29 bytes, even though this
187 inserts just one byte and does not overflow the buffer.
188 (Finsert_file_contents): Store file offsets as off_t
189 values, not as EMACS_INT values. Check for overflow when
190 converting between EMACS_INT and off_t. When checking for
191 buffer overflow or for overlap, take the offsets into account.
192 Don't use EMACS_INT for small values where int suffices.
193 When checking for overlap, fix a typo: ZV was used where
194 ZV_BYTE was intended.
195 (Fwrite_region): Don't assume off_t fits into 'long'.
196 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
197
ecfc0a49
MA
1982011-09-05 Michael Albinus <michael.albinus@gmx.de>
199
200 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
201
6511acf2 2022011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 203
0999621a 204 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
205
206 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 207 (esprintf, exprintf, evxprintf): New functions.
62f19c19
PE
208 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
209 (cmd_error): kbd macro iterations count is now EMACS_INT, not int.
210 (modify_event_symbol): Do not assume that the length of
211 name_alist_or_stem is safe to alloca and fits in int.
212 (Fexecute_extended_command): Likewise for function name and binding.
213 (Frecursion_depth): Wrap around reliably on integer overflow.
214 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
215 since some callers pass EMACS_INT values.
216 (Fsingle_key_description): Don't crash if symbol name contains more
217 than MAX_ALLOCA bytes.
218 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
219 (get_minibuffer): Arg is now EMACS_INT, not int.
220 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 221 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
222 * window.h (command_loop_level, minibuf_level): Reflect API changes.
223
2be7d702
PE
224 * dbusbind.c (signature_cat): New function.
225 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
226 Do not overrun buffer; instead, report string overflow.
227
9d1df220
PE
228 * dispnew.c (add_window_display_history): Don't overrun buffer.
229 Truncate instead; this is OK since it's just a log.
230
33ef5c64
PE
231 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
232 even if the time zone offset is outlandishly large.
233 Don't mishandle offset == INT_MIN.
234
66c6fdd5
PE
235 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
236 when creating daemon; the previous buffer-overflow check was incorrect.
237
d749b01b
PE
238 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
239 which has the guts of the old verror function.
240
b5cd1905
PE
241 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
242 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
243
6e1a67fb
PE
244 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
245 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 246 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 247 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
248 length of string rather than counting it via multiple sprintfs;
249 that's simpler and more reliable.
c21721cc
PE
250 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
251 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
252 sprintf, in case result does not fit in int.
253
c57b67fc
PE
254 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
255 (fontset_from_font): Print it.
256
8a401434
PE
257 * frame.c (tty_frame_count): Now printmax_t, not int.
258 (make_terminal_frame, set_term_frame_name): Print it.
259 (x_report_frame_params): In X, window IDs are unsigned long,
260 not signed long, so print them as unsigned.
261 (validate_x_resource_name): Check for implausibly long names,
262 and don't assume name length fits in 'int'.
263 (x_get_resource_string): Don't blindly alloca invocation name;
264 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
265 not fit in int.
266
6e1a67fb
PE
267 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
268 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
269 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
270
0df02bf3
PE
271 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
272 Use esprintf, not sprintf, in case result does not fit in int.
273
48e30793
PE
274 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
275 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
276 it as a large positive number.
277 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
278 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
279
a66ff6d8
PE
280 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
281 in case result does not fit in int.
282
aca216ff
PE
283 * print.c (float_to_string): Detect width overflow more reliably.
284 (print_object): Make sprintf buffer a bit bigger, to avoid potential
285 buffer overrun. Don't assume list length fits in 'int'. Treat
286 print length of 0 as 0, not as infinity; to be consistent with other
287 uses of print length in this function. Don't overflow print length
288 index. Don't assume hash table size fits in 'long', or that
289 vectorlike size fits in 'unsigned long'.
290
31c286f7
PE
291 * process.c (make_process): Use printmax_t, not int, to format
292 process-name gensyms.
293
55e5faa1
PE
294 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
295
80f2e268
PE
296 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
297 to avoid potential buffer overrun.
298
670741ab
PE
299 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
300 if X resource line is longer than 512 bytes.
301
b7163a50
PE
302 * xfns.c (x_window): Make sprintf buffer a bit bigger
303 to avoid potential buffer overrun.
304
ae58ff1f
PE
305 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
306
c43c8a6a
PE
307 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
308
3f8236f4
PE
3092011-09-04 Paul Eggert <eggert@cs.ucla.edu>
310
53e9fe90 311 Integer overflow fixes for scrolling, etc.
6511acf2
PE
312 Without these, Emacs silently mishandles large integers sometimes.
313 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
314 it were "C-u 1 M-x recenter" on a typical 64-bit host.
315
6511acf2
PE
316 * xdisp.c (try_window_id): Check Emacs fixnum range before
317 converting to 'int'.
806add1d 318
6511acf2 319 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
320 Check that an Emacs fixnum is in range before assigning it to 'int'.
321 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
322 values converted from Emacs fixnums.
323 (Frecenter): Don't wrap around a line count if it is out of 'int'
324 range; instead, treat it as an extreme value.
325 (Fset_window_configuration, compare_window_configurations):
326 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
327
6511acf2
PE
328 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
329 that can exceed INT_MAX. Check that EMACS_INT value is in range
330 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
331 (match_limit): Don't assume that a fixnum can fit in 'int'.
332
6511acf2 333 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
334 exceed INT_MAX.
335
6511acf2 336 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
337 (Fvertical_motion): Don't wrap around LINES values that don't fit
338 in 'int'. Instead, treat them as extreme values. This is good
339 enough for windows, which can't have more than INT_MAX lines anyway.
340
fcb901a7
LMI
3412011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
342
0f2f6b6d
LMI
343 * Require libxml/parser.h to avoid compilation warning.
344
fcb901a7
LMI
345 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
346
347 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
348 since this reportedly can destroy thread storage.
349
6e20a0d4
CY
3502011-08-30 Chong Yidong <cyd@stupidchicken.com>
351
352 * syntax.c (find_defun_start): Update all cache variables if
353 exiting early (Bug#9401).
354
148ae00e
EZ
3552011-08-30 Eli Zaretskii <eliz@gnu.org>
356
f6cfbd8f
EZ
357 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
358
148ae00e
EZ
359 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
360 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
361 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
362
363 * term.c (tty_append_glyph): New function.
364 (produce_stretch_glyph): Static function and its prototype deleted.
365
366 * dispextern.h (produce_stretch_glyph, tty_append_glyph): Add
367 prototypes.
368
c4a07a4c
PE
3692011-08-29 Paul Eggert <eggert@cs.ucla.edu>
370
371 * image.c (parse_image_spec): Check for nonnegative, not for positive,
372 when checking :margin (Bug#9390).
373 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
374 Renamed from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
375 so that the name doesn't mislead. All uses changed.
376
6bc8cd65
JB
3772011-08-28 Johan Bockgård <bojohan@gnu.org>
378
379 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
380 set_tty_hooks.
381
dca4927e
EZ
3822011-08-27 Eli Zaretskii <eliz@gnu.org>
383
384 * xdisp.c (move_it_to): Don't bail out early when reaching
385 position beyond to_charpos, if we are scanning backwards.
386 (move_it_vertically_backward): When DY == 0, make sure we get to
387 the first character in the line after the newline.
388
f2cad773
PE
3892011-08-27 Paul Eggert <eggert@cs.ucla.edu>
390
391 * ccl.c: Improve and simplify overflow checking (Bug#9196).
392 (ccl_driver): Do not generate an out-of-range pointer.
393 (Fccl_execute_on_string): Remove unnecessary check for
394 integer overflow, noted by Stefan Monnier in
395 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
396 Remove a FIXME that didn't need fixing.
397 Simplify the newly-introduced buffer reallocation code.
398
0cae2cdb
JB
3992011-08-27 Juanma Barranquero <lekktu@gmail.com>
400
401 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
402
5fc295a4 4032011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 404
70c60eb2 405 Integer and memory overflow issues (Bug#9196).
726e0ab1 406
d31850da
PE
407 * doc.c (get_doc_string): Rework so that
408 get_doc_string_buffer_size is the actual buffer size, rather than
409 being 1 less than the actual buffer size; this makes xpalloc more
410 convenient.
411
a69fbedb
PE
412 * image.c (x_allocate_bitmap_record, cache_image):
413 * xselect.c (Fx_register_dnd_atom):
414 Simplify previous changes by using xpalloc.
415
fe5c5d37
PE
416 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
417 since either will do and ptrdiff_t is convenient with xpalloc.
418
0065d054
PE
419 * charset.c (charset_table_size)
420 (struct charset_sort_data.priority): Now ptrdiff_t.
421 (charset_compare): Don't overflow if priorities differ greatly.
422 (Fsort_charsets): Don't assume list length fits in int.
423 Check for size-calculation overflow when allocating sort data.
424 (syms_of_charset): Allocate an initial charset table that is
425 just under 64 KiB, to avoid problems with glibc malloc and mmap.
426
427 * cmds.c (internal_self_insert): Check for size-calculation overflow.
428
429 * composite.h (struct composition.glyph_len): Now int, not unsigned.
430 The actual value is always <= INT_MAX, and leaving it unsigned made
431 overflow checking harder.
432
433 * dispextern.h (struct glyph_matrix.rows_allocated)
434 (struct face_cache.size): Now ptrdiff_t, for convenience in use
435 with xpalloc. The values are still always <= INT_MAX.
436
437 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
438
439 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
440 (SAFE_NALLOCA): New macro.
441
442 * region-cache.c (struct boundary.pos, find_cache_boundary)
443 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
444 (set_cache_region, invalidate_region_cache)
445 (revalidate_region_cache, know_region_cache, region_cache_forward)
446 (region_cache_backward, pp_cache):
447 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
448 so that ptrdiff_t * can be passed to xpalloc.
449 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
450 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
451 (pp_cache): Don't assume cache_len fits in int.
452 * region-cache.h: Adjust extern decls to match.
453
454 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
455 EMACS_INT, since either will do, for xpalloc.
456
457 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
458 (xnmalloc, xnrealloc, xpalloc): New functions.
459
726e0ab1
PE
460 * bidi.c (bidi_shelve_header_size): New constant.
461 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
462 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
463
51f30bc5 464 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
465 * buffer.c (overlays_at, overlays_in, record_overlay_string)
466 (overlay_strings):
467 Don't update size of array until after memory allocation succeeds,
468 because xmalloc/xrealloc may not return.
0065d054
PE
469 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
470 now that we have proper integer overflow checking.
471 (record_overlay_string, overlay_strings): Catch overflows when
472 calculating size of overlay_str_buf.
726e0ab1 473
0065d054
PE
474 * callproc.c (Fcall_process): Check for size overflow when
475 calculating size of args2.
476 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
477 Normally we prefer signed values, but sticking with ptrdiff_t would
478 require adding more-complicated checks.
726e0ab1
PE
479
480 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
481 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
482 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 483 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
484
485 * character.c (Fstring): Check for size-calculation overflow.
486
487 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
488 unnecessary integer overflow. Check for size overflow.
489 (encode_coding_object): Don't update size until xmalloc succeeds.
490
491 * composite.c (get_composition_id): Check for overflow in glyph
492 length calculations.
493
494 Integer and memory overflow fixes for display code.
495 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
496 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
497 (scrolling_window): Check for overflow in size calculations.
498 (line_draw_cost, realloc_glyph_pool, add_row_entry):
499 Don't assume glyph table len fits in int.
500 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
501 (row_table_size): Now ptrdiff_t, not int.
502 (scrolling_window): Avoid overflow in size calculations.
503 Don't update size until allocation succeeds.
504 * fns.c (concat): Check for overflow in size calculations.
505 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
506 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
507 (NEXT_ALMOST_PRIME_LIMIT): New constant.
508
509 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
510 (get_doc_string): Check for size calculation overflow.
511 Don't update size until allocation succeeds.
512 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
513 EMACS_INT, where ptrdiff_t will do.
514 (Fsubstitute_command_keys): Check for string overflow.
515
516 * editfns.c (set_time_zone_rule): Don't assume environment length
517 fits in int.
518 (message_length): Now ptrdiff_t, not int.
519 (Fmessage_box): Don't update size until allocation succeeds.
520 Don't assume message length fits in int.
521 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
522
0065d054
PE
523 * emacs.c (main): Do not reallocate argv, since there is a null at
524 the end that can be overwritten, and this way there's no need to
525 worry about size-calculation overflow.
526 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
527
528 * eval.c (init_eval_once, grow_specpdl): Don't update size until
529 alloc succeeds.
530 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
531
532 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
533 (x_set_scroll_bar_width, x_figure_window_size):
534 Check for integer overflow.
535 (x_set_alpha): Do not assume XINT fits in int.
536
537 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
538 This is for the members text_lines, text_cols, total_lines, total_cols,
539 where the system imposes an 'int' limit.
540
541 * fringe.c (Fdefine_fringe_bitmap):
542 Don't update size until alloc works.
543
544 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
545 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
546
547 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
548 Check for size-calculation overflow.
549 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
550 do, as we prefer signed integers.
551 (id_to_widget.max_size, id_to_widget.used)
552 (xg_store_widget_in_map, xg_remove_widget_from_map)
553 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
554 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
555 Use and return ptrdiff_t, not int.
556 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
557 * gtkutil.h: Change prototypes to match the above.
558
559 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
560 are duplicate now that they've been promoted to lisp.h.
561 (x_allocate_bitmap_record, x_alloc_image_color)
562 (make_image_cache, cache_image, xpm_load):
563 Don't update size until alloc is done.
564 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
565 (x_detect_edges):
3256efce 566 Check for size calculation overflow.
726e0ab1
PE
567 (ct_colors_allocated_max): New constant.
568 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
569 overflow.
3256efce 570
726e0ab1
PE
571 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
572 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
573 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
574 Use ptrdiff_t, not int, to count maps.
575 (read_char_minibuf_menu_prompt): Check for overflow in size
576 calculations. Don't update size until allocation succeeds. Redo
577 calculations to avoid overflow.
578 * keyboard.h: Change prototypes to match the above.
579
580 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
581 to count maps.
582 (current_minor_maps): Check for size calculation overflow.
583 * keymap.h: Change prototypes to match the above.
584
585 * lread.c (read1, init_obarray): Don't update size until alloc done.
586
587 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
588 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
589
726e0ab1
PE
590 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
591 Now ptrdiff_t, not int.
592 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
593 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
594
595 * process.c (Fnetwork_interface_list): Check for overflow
596 in size calculation.
597
598 * region-cache.c (move_cache_gap): Check for size calculation overflow.
599
600 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
601 overflow. Don't bother calling xmalloc when xrealloc will do.
602
603 * search.c (Freplace_match): Check for size calculation overflow.
604 (Fset_match_data): Don't assume list lengths fit in 'int'.
605
606 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
607 for command line length. Do not attempt to address one before the
608 beginning of an array, as that's not portable.
609
610 * term.c (max_frame_lines): Remove; unused.
611 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
612 not int.
613 (encode_terminal_code, calculate_costs): Check for size
614 calculation overflow.
615 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
616 table lengths and related sizes. Don't update size until alloc
617 done. Redo calculations to avoid overflow.
618 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
619
620 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
621 subtracting pointers.
622 (gobble_line): Check for overflow more carefully. Don't update size
623 until alloc done.
624
625 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
626 Don't update size until alloc done.
627 Redo size calculations to avoid overflow.
628 Check for size calculation overflow.
0065d054 629 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
630
631 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
632 Use ptrdiff_t, not int, for sizes.
633 (store_mode_line_noprop_char): Don't update size until alloc done.
634
0065d054
PE
635 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
636 Use ptrdiff_t, not int, for sizes.
637 (Finternal_make_lisp_face, cache_face):
638 Check for size calculation overflow.
639 (cache_face): Treat size calculation overflows as if they were
640 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
641
642 * xfns.c (x_encode_text, x_set_name_internal)
643 (Fx_change_window_property): Use ptrdiff_t, not int, to count
644 sizes, since they can exceed INT_MAX in size. Check for size
645 calculation overflow.
646
0065d054
PE
647 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
648 (xg_select): Check for size calculation overflow.
726e0ab1
PE
649 Don't update size until alloc done.
650
0065d054 651 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 652 as sprintf is limited to int lengths.
1d526e2f 653
252c5ee1
PE
654 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
655 (X_LONG_MIN): New macros.
864d7ce7
PE
656 Use them to make the following changes clearer.
657 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
658 This change doesn't affect the value now, but it may help remind
659 future maintainers not to raise the value too much later.
660 (SELECTION_QUANTUM): Remove, replacing with ...
661 (selection_quantum): ... new function, which avoids overflow.
662 All uses changed.
663 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
664 assumption that selection length fits in 'int'.
665 (x_reply_selection_request, x_handle_selection_request)
666 (x_get_window_property, receive_incremental_selection)
667 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
668 (lisp_data_to_selection_data, clean_local_selection_data):
669 Use ptrdiff_t, not int, to record length of selection.
670 (x_reply_selection_request, x_get_window_property)
671 (receive_incremental_selection, x_property_data_to_lisp):
672 Redo calculations to avoid overflow.
673 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 674 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
675 something.
676 (x_get_window_property, receive_incremental_selection)
677 (lisp_data_to_selection_data, x_property_data_to_lisp):
678 Check for size-calculation overflow.
679 (x_get_window_property, receive_incremental_selection)
680 (lisp_data_to_selection_data, Fx_register_dnd_atom):
681 Don't store size until memory allocation succeeds.
682 (x_get_window_property): Plug memory leak on memory exhaustion.
683 Don't double-block input; malloc is safe here. Don't assume 2**34
684 - 4 fits in unsigned long. Add an xassert to check
685 XGetWindowProperty overflow. Be more careful about overflow
686 calculations, and distinguish size from memory overflow better.
687 (receive_incremental_selection): When tracing, don't assume
688 unsigned int is less than INT_MAX.
689 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
690 harmful) conversions of unsigned short to int.
691 (lisp_data_to_selection_data): Don't assume that integers
692 in the range -65535 through -1 fit in an X unsigned short.
693 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
694 result parameters unless successful. Rely on cons_to_unsigned
695 to report problems with elements; the old code wasn't right anyway.
696 (x_check_property_data): Check for int overflow; we cannot use
697 a wider type due to X limits.
698 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
699
726e0ab1 700 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 701
0065d054
PE
702 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
703 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
704 (x_color_cells): Don't store size until memory allocation succeeds.
705 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 706 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
707 (x_term_init): Don't assume length fits in int (sprintf is limited
708 to int size).
bc18e09d 709
ebfa62c0
PE
710 Use ptrdiff_t for composition IDs.
711 * character.c (lisp_string_width):
712 * composite.c (composition_table_size, n_compositions)
713 (get_composition_id, composition_gstring_from_id):
714 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
715 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
716 * window.c (Frecenter):
717 Use ptrdiff_t, not int, for composition IDs.
718 * composite.c (get_composition_id): Check for integer overflow.
719 * composite.h: Adjust prototypes to match the above changes.
720
d3411f89
PE
721 Use ptrdiff_t for hash table indexes.
722 * category.c (hash_get_category_set):
723 * ccl.c (ccl_driver):
724 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
725 * coding.c (coding_system_charset_list, detect_coding_system):
726 * coding.h (struct coding_system.id):
727 * composite.c (get_composition_id, gstring_lookup_cache):
728 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
729 * image.c (xpm_get_color_table_h):
730 * lisp.h (hash_lookup, hash_put):
731 * minibuf.c (Ftest_completion):
732 Use ptrdiff_t for hash table indexes, not int (which is too
733 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
734 32-bit --with-wide-int hosts).
735
e097a6fa
PE
736 * charset.c (Fdefine_charset_internal): Check for integer overflow.
737 Add a FIXME comment about memory leaks.
738 (syms_of_charset): Don't assume xmalloc returns.
739
5637687f
PE
740 Don't assume that stated character widths fit in int.
741 * character.c (Fchar_width, c_string_width, lisp_string_width):
742 * character.h (CHAR_WIDTH):
743 * indent.c (MULTIBYTE_BYTES_WIDTH):
744 Use sanitize_char_width to avoid undefined and/or bad behavior
745 with outlandish widths.
746 * character.h (sanitize_tab_width): Renamed from sanitize_width,
747 now that we have two such functions. All uses changed.
748 (sanitize_char_width): New inline function.
749
a2271ba2
PE
750 Don't assume that tab-width fits in int.
751 * character.h (sanitize_width): New inline function.
752 (SANE_TAB_WIDTH): New macro.
753 (ASCII_CHAR_WIDTH): Use it.
754 * indent.c (sane_tab_width): Remove. All uses replaced by
755 SANE_TAB_WIDTH (current_buffer).
756 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
757
18c52557
PE
758 * fileio.c: Integer overflow issues with file modes.
759 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
760
caeeedc1
PE
761 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
762 Remove unreachable code.
763 (read_hex, load_charset_map_from_file): Check for integer overflow.
764
50849c52
PE
765 * xterm.c: don't go over XClientMessageEvent limit
766 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
767 (x_send_scroll_bar_event): Likewise. Check that the size does not
768 exceed limits imposed by XClientMessageEvent, as well as the usual
769 ptrdiff_t and size_t limits.
770
b13995db
PE
771 * keyboard.c: Overflow, signedness and related fixes.
772 (make_lispy_movement): Use same integer type in forward decl
773 that is used in the definition.
774 (read_key_sequence, keyremap_step):
775 Change bufsize argument back to int, undoing my 2011-03-30 change.
776 We prefer signed types, and int is wide enough here.
777 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
778 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
779 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
780 length, not size_t. Use ptrdiff_t for index, not int.
781 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
782 possibility of integer overflow.
783
13464394
PE
784 Overflow, signedness and related fixes for images.
785
786 * dispextern.h (struct it.stack[0].u.image.image_id)
787 (struct_it.image_id, struct image.id, struct image_cache.size)
788 (struct image_cache.used, struct image_cache.ref_count):
789 * gtkutil.c (update_frame_tool_bar):
790 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
791 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
792 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
793 * nsmenu.m (update_frame_tool_bar):
794 * xdisp.c (calc_pixel_width_or_height):
795 * xfns.c (image_cache_refcount):
796 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
797 on typical 64-bit hosts.
798
799 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
800 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
801 Omit unnecessary casts to int.
802 (parse_image_spec): Check that integers fall into 'int' range
803 when the callers expect that.
804 (image_ascent): Redo ascent calculation to avoid int overflow.
805 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
806 (lookup_image): Remove unnecessary tests.
807 (xbm_image_p): Locals are now of int, not EMACS_INT,
808 since parse_image_check makes sure they fit into int.
809 (png_load, gif_load, svg_load_image):
810 Prefer int to unsigned where either will do.
811 (tiff_handler): New function, combining the cores of the
812 old tiff_error_handler and tiff_warning_handler. This
813 function is rewritten to use vsnprintf and thereby avoid
814 stack buffer overflows. It uses only the features of vsnprintf
815 that are common to both POSIX and native Microsoft.
816 (tiff_error_handler, tiff_warning_handler): Use it.
817 (tiff_load, gif_load, imagemagick_load_image):
818 Don't assume :index value fits in 'int'.
819 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
820 (imagemagick_load_image): Check that crop parameters fit into
821 the integer types that MagickCropImage accepts. Don't assume
822 Vimagemagick_render_type has a nonnegative value. Don't assume
823 size_t fits in 'long'.
824 (gs_load): Use printmax_t to print the widest integers possible.
825 Check for integer overflow when computing image height and width.
826
c11821d4
EZ
8272011-08-26 Eli Zaretskii <eliz@gnu.org>
828
829 * xdisp.c (redisplay_window): Don't force window start if point
830 will be invisible in the resulting window. (Bug#9324)
831
0c95fcf7
EZ
8322011-08-25 Eli Zaretskii <eliz@gnu.org>
833
834 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
835 the display spec is of the form `(space ...)'.
836 (handle_display_spec): Return the value returned by
837 handle_single_display_spec, not just 1 or zero.
838 (handle_single_display_spec): If the display spec is of the form
839 `(space ...)', and specifies display in the text area, return 2
840 rather than 1.
fee65a97 841 (try_cursor_movement): Check for the need to scroll more
e25be792
EZ
842 accurately, and prefer exact match for point under bidi. Don't
843 advance `row' beyond the last row of the window.
0c95fcf7
EZ
844
845 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
846 into disp_prop; all users changed.
847
848 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
849 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
850 for the text covered by the display property.
851
e4ed06f1
CY
8522011-08-25 Chong Yidong <cyd@stupidchicken.com>
853
854 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
855 Change return value to nil.
856 (Frecord_buffer): Delete unused function.
857
f67cdd7f
EZ
8582011-08-24 Eli Zaretskii <eliz@gnu.org>
859
5980d4c6
EZ
860 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
861 buffers, return left-to-right.
8610fe8b
EZ
862 (set_cursor_from_row): Consider candidate row a win if its glyph
863 represents a newline and point is on that newline. Fixes cursor
864 positioning on the newline at EOL of R2L text within L2R
865 paragraph, and vice versa.
866 (try_cursor_movement): Check continued rows, in addition to
867 continuation rows. Fixes unwarranted scroll when point enters a
868 continued line of R2L text within an L2R paragraph, or vice versa.
869 (cursor_row_p): Consider the case of point being equal to
870 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
871 from the end of a short line to the beginning of a continued line
872 of R2L text within L2R paragraph.
873 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
874 composed characters.
5980d4c6 875
f67cdd7f
EZ
876 * bidi.c (bidi_check_type): Use xassert.
877 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
878 members.
879
bca633fb
EZ
8802011-08-23 Eli Zaretskii <eliz@gnu.org>
881
882 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
883 a character.
884
4a5885a7
CY
8852011-08-23 Chong Yidong <cyd@stupidchicken.com>
886
887 * nsfont.m (ns_otf_to_script): Fix typo.
888
0902a04e
KH
8892011-08-22 Kenichi Handa <handa@m17n.org>
890
891 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
892 extra slot even if the purpose is char-code-property-table.
893
1a2e6670
EZ
8942011-08-23 Eli Zaretskii <eliz@gnu.org>
895
8ddde651
EZ
896 * xdisp.c (redisplay_window): When computing centering_position,
897 account for the height of the header line. (Bug#8874)
898
425cc014
EZ
899 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
900 instead of CHAR_TO_BYTE. Fixes a crash when a completion
901 candidate is selected by the mouse, and that candidate has a
902 composed character under the mouse.
903
1a2e6670
EZ
904 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
905 coordinates reported by pos-visible-in-window-p for a composed
906 character in column zero.
907
8b76d6f8
SM
9082011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
909
910 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
911
dac347dd
EZ
9122011-08-22 Eli Zaretskii <eliz@gnu.org>
913
914 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
915 consider it a hit if to_charpos is anywhere in the range of the
916 composed buffer positions.
917
e013fb34
CY
9182011-08-22 Chong Yidong <cyd@stupidchicken.com>
919
920 * image.c (gif_load): Don't assume that each subimage has the same
921 dimensions as the base image. Handle disposal method that is
922 "undefined" by the gif spec (Bug#9335).
923
bd1ba3e8
CY
9242011-08-20 Chong Yidong <cyd@stupidchicken.com>
925
926 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 927 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 928
54a1215b
EZ
9292011-08-19 Eli Zaretskii <eliz@gnu.org>
930
823564e5
EZ
931 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
932 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
933 from an Org mode buffer to a Speedbar frame.
934
54a1215b
EZ
935 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
936 a composition, take its buffer position from IT->cmp_it.charpos.
937 Fixes cursor positioning at the beginning of a line that begins
938 with a composed character.
939
9778ebcc
EZ
9402011-08-18 Eli Zaretskii <eliz@gnu.org>
941
0be6ee06
EZ
942 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
943 character bidirectional type, use STRONG_L instead. Fixes crashes
944 in a buffer produced by `describe-categories'.
945
9778ebcc
EZ
946 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
947 members before the level stack, so they would be saved and
948 restored when copying iterator state. Fixes incorrect reordering
949 around TABs covered by display properties.
950
156bffbe
AS
9512011-08-18 Andreas Schwab <schwab@linux-m68k.org>
952
953 * process.c (Fnetwork_interface_list): Correctly determine buffer
954 size.
955
72ad093b
CY
9562011-08-17 Chong Yidong <cyd@stupidchicken.com>
957
958 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
959 (internal_condition_case_2, internal_condition_case_n):
960 Remove unnecessary aborts (Bug#9081).
72ad093b 961
35774242
EZ
9622011-08-17 Eli Zaretskii <eliz@gnu.org>
963
964 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
965 has no `load' handler, try opening the file locally. (Bug#9311)
966
db76dd85
KB
9672011-08-16 Ken Brown <kbrown@cornell.edu>
968
969 * gmalloc.c: Expand comment.
970
b215eee5
EZ
9712011-08-16 Eli Zaretskii <eliz@gnu.org>
972
973 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
974 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
975
a4579d33
KB
9762011-08-16 Ken Brown <kbrown@cornell.edu>
977
978 Fix memory allocation problems in Cygwin build (Bug#9273).
979
980 * unexcw.c ( __malloc_initialized): Declare external variable.
981 (fixup_executable): Force the dumped emacs to reinitialize malloc.
982
8b76d6f8
SM
983 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
984 New variables.
a4579d33
KB
985 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
986 dumped emacs.
987 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
988 in the static heap.
989 [CYGWIN] (special_realloc): New function.
990 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
991 requests to realloc storage in the static heap.
992
3ebec551
PE
9932011-08-15 Paul Eggert <eggert@cs.ucla.edu>
994
995 * bidi.c (bidi_initialize): Remove unused local.
996
9fd8be00
EZ
9972011-08-15 Eli Zaretskii <eliz@gnu.org>
998
474a8465
EZ
999 * biditype.h: File removed.
1000
1001 * bidimirror.h: File removed.
1002
1003 * deps.mk (bidi.o): Remove biditype.h and
1004 bidimirror.h.
1005
1006 * makefile.w32-in ($(BLD)/bidi.$(O)): Remove biditype.h and
1007 bidimirror.h.
1008
1009 * dispextern.h: Fix a typo in the comment to bidi_type_t.
1010
1011 * chartab.c: Improve commentary for the uniprop_table API.
1012
32413314
EZ
1013 * bidi.c (bidi_paragraph_init): Support zero value of
1014 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
1015 (bidi_initialize): Use uniprop_table instead of including
1016 biditype.h and bidimirror.h.
32413314 1017
9fd8be00
EZ
1018 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
1019 coordinates of the iterator when restoring from ppos_it.
1020 (Bug#9296)
1021
5cf2b69b
KH
10222011-08-14 Kenichi Handa <handa@m17n.org>
1023
1024 * process.c (create_process): Call setup_process_coding_systems
72ad093b 1025 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 1026
daf17d00
EZ
10272011-08-14 Eli Zaretskii <eliz@gnu.org>
1028
1029 * xdisp.c (move_it_in_display_line_to): Don't invoke
1030 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
1031 ppos_it. Fixes vertical cursor motion when line beginning is
1032 covered by an image. (Bug#9296)
1033
08e3161a
JD
10342011-08-14 Jan Djärv <jan.h.d@swipnet.se>
1035
1036 * nsterm.h (ns_run_ascript): Declare.
1037 (NSAPP_DATA2_RUNASSCRIPT): Define.
1038
1039 * nsfns.m (as_script, as_result, as_status): New static variables.
1040 (ns_run_ascript): New function.
5e617bc2 1041 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
1042 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
1043 the event loop. Get status from as_status (Bug#7276).
1044
1045 * nsterm.m (sendEvent): If event is NSApplicationDefined and
1046 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
1047 the event loop (Bug#7276).
1048
a3720aa2
AS
10492011-08-14 Andreas Schwab <schwab@linux-m68k.org>
1050
1051 * gnutls.c (QCgnutls_bootprop_priority)
1052 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
1053 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
1054 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
1055 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
1056 (QCgnutls_bootprop_verify_hostname_error)
1057 (QCgnutls_bootprop_callbacks_verify): Rename from
1058 Qgnutls_bootprop_..., all uses changed.
1059
1060 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
1061 uses changed.
1062
0a0d27fb
PE
10632011-08-14 Paul Eggert <eggert@cs.ucla.edu>
1064
19d5c50c
PE
1065 * xfaces.c (Qframe_set_background_mode): Now static.
1066 * dispextern.h (Qframe_set_background_mode): Remove decl.
1067
0a0d27fb
PE
1068 * process.c (Fnetwork_interface_info): Declare local only if needed.
1069
377538cb
JD
10702011-08-13 Jan Djärv <jan.h.d@swipnet.se>
1071
1072 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
1073 (Fnetwork_interface_list): Allocate in increments of bytes instead
1074 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
1075 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
1076 sockaddr.
1077 (struct ifflag_def): notrailers is smart on OSX.
1078 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
1079 Get hardware address with getifaddrs if available.
1080
08fff70c
EZ
10812011-08-12 Eli Zaretskii <eliz@gnu.org>
1082
1083 * xdisp.c (iterate_out_of_display_property): xassert that
1084 IT->position is set to within IT->object's boundaries. Break from
1085 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
1086 when IT->position is set up wrongly due to some bug.
1087 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
1088 (push_display_prop): Allow GET_FROM_STRING as IT->method on
1089 entry. Force push_it to save on the stack the current
1090 buffer/string position, to be restored by pop_it. Fix flags in
1091 the iterator structure wrt the object coming from a display
1092 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
1093 properties. (Bug#9284)
1094
7be1c708 10952011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 1096
7be1c708
CY
1097 * fontset.c (fontset_get_font_group): Add proper type checks.
1098 (Bug#9172)
aac0c6e3 1099
7be1c708 11002011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 1101
7be1c708
CY
1102 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
1103 and LC_VERSION_MIN_MACOSX.
1104 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
1105 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 1106
97bb72a6
EZ
11072011-08-08 Eli Zaretskii <eliz@gnu.org>
1108
1109 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
1110 no-display-properties-and-no-overlays under bidi display.
1111 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 1112 properties and overlays.
97bb72a6 1113
d5617611
CY
11142011-08-08 Chong Yidong <cyd@stupidchicken.com>
1115
37e11a63
CY
1116 * editfns.c (Fset_time_zone_rule): Document relationship with the
1117 setenv function.
1118
d5617611
CY
1119 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
1120 the font entity extracted from the cache (Bug#8109).
1121
58872834
CY
11222011-08-07 Chong Yidong <cyd@stupidchicken.com>
1123
1124 * composite.c (autocmp_chars): Don't reset point. That is done by
1125 restore_point_unwind (Bug#5984).
1126
75bfc667
JL
11272011-08-07 Juri Linkov <juri@jurta.org>
1128
1129 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
1130 to show the arg `TIME' instead of `TIMEVAL'.
1131
d1410150
EZ
11322011-08-06 Eli Zaretskii <eliz@gnu.org>
1133
1134 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
1135 display property strides EOL and includes a newline, as in
1136 longlines-mode. (Bug#9254)
75b771e4
EZ
1137 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
1138 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
1139
1140 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
1141 is non-zero, even if the data buffer is NULL. Fixes a crash in
1142 vertical-motion with longlines-mode. (Bug#9254)
1143
35928349
EZ
11442011-08-05 Eli Zaretskii <eliz@gnu.org>
1145
ec7cc85b
EZ
1146 * bidi.c <bidi_cache_total_alloc>: Now static.
1147 (bidi_initialize): Initialize bidi_cache_total_alloc.
1148
8b76d6f8 1149 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
1150 cache. (Bug#9221)
1151
1152 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
1153 amount allocated this far in `bidi_cache_total_alloc'.
1154 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
1155 non-zero, only free the data buffer without restoring the cache
1156 contents. All callers changed.
1157
1158 * dispextern.h (bidi_unshelve_cache): Update prototype.
1159
1160 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
1161 (move_it_in_display_line, move_it_to)
1162 (move_it_vertically_backward, move_it_by_lines): Replace the call
1163 to xfree to an equivalent call to bidi_unshelve_cache.
1164 (move_it_in_display_line_to): Fix logic of returning
412b6358 1165 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 1166
e2e2423b
EZ
11672011-08-05 Eli Zaretskii <eliz@gnu.org>
1168
1169 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
1170 came from a string character with a `cursor' property. (Bug#9229)
1171
ae9e757a
JD
11722011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1173
1174 * Makefile.in (LIB_PTHREAD): New variable.
1175 (LIBES): Add LIB_PTHREAD (Bug#9216).
1176
1177 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
1178 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
1179
213bd7f2
AS
11802011-08-04 Andreas Schwab <schwab@linux-m68k.org>
1181
1182 * regex.c (re_iswctype): Remove some redundant boolean
1183 conversions.
1184
99aaf75f
JD
11852011-08-04 Jan Djärv <jan.h.d@swipnet.se>
1186
1187 * xterm.c (x_find_topmost_parent): New function.
1188 (x_set_frame_alpha): Find topmost parent window with
1189 x_find_topmost_parent and set the property there also (bug#9181).
1190 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
1191
c74e9d86
PE
11922011-08-04 Paul Eggert <eggert@cs.ucla.edu>
1193
1194 * callproc.c (Fcall_process): Avoid vfork clobbering
1195 the local vars buffer, coding_systems, current_dir.
1196
640c8776
SM
11972011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
1198
1199 * keymap.c (Fmake_composed_keymap): Move to subr.el.
1200
f26d0e4c
PE
12012011-08-03 Paul Eggert <eggert@cs.ucla.edu>
1202
8a10d76c
PE
1203 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
1204 so that it is not optimized away.
1205
f26d0e4c
PE
1206 * xdisp.c (compute_display_string_pos): Remove unused local.
1207
55439c61
EZ
12082011-08-02 Eli Zaretskii <eliz@gnu.org>
1209
1210 Fix slow cursor motion and scrolling in large buffers with
1211 selective display, like Org Mode buffers. (Bug#9218)
1212
1213 * dispextern.h (struct bidi_it): New member disp_prop_p.
1214
1215 * xdisp.c: Remove one-slot cache of display string positions.
1216 (compute_display_string_pos): Accept an additional argument
5e617bc2 1217 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
1218 for a display string or property. If found, set DISP_PROP_P
1219 non-zero.
1220
1221 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
1222 DISP_PROP_P, and pass it to compute_display_string_pos.
1223 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
1224 non-zero. All callers of bidi_fetch_char changed.
1225
fb33fa43
SM
12262011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
1227
1228 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
1229
b099e063
DM
12302010-12-03 Don March <don@ohspite.net>
1231
1232 * keymap.c (Fdefine_key): Fix non-prefix key error message when
1233 last character M-[char] is translated to ESC [char] (bug#7541).
1234
5cc7f7af
KH
12352011-08-02 Kenichi Handa <handa@m17n.org>
1236
d0fffa3f 1237 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
1238
1239 * chartab.c (uniprop_table): Make it non-static.
1240
525d5e6e
EZ
12412011-08-01 Eli Zaretskii <eliz@gnu.org>
1242
1243 * xdisp.c (forward_to_next_line_start): Accept additional argument
1244 BIDI_IT_PREV, and store into it the state of the bidi iterator had
1245 on the newline.
1246 (reseat_at_next_visible_line_start): Use the bidi iterator state
1247 returned by forward_to_next_line_start to restore the state of
1248 it->bidi_it after backing up to previous newline. (Bug#9212)
1249
31011111
AS
12502011-07-30 Andreas Schwab <schwab@linux-m68k.org>
1251
1252 * regex.c (re_comp): Protoize.
1253 (re_exec): Fix return type.
1254 (regexec): Fix type of `ret'. (Bug#9203)
1255
476371c4
PE
12562011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1257
e5d76069
PE
1258 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
1259 This is needed if max-image-size is a floating-point number.
1260
9a79b20c
AS
12612011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1262
1263 * print.c (print_object): Print empty symbol as ##.
1264
1265 * lread.c (read1): Read ## as empty symbol.
1266
d8c2fa78
AA
12672011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
1268
1269 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
1270 setting frame foreground color (Bug#9175).
1271 (x_set_background_color): Likewise.
1272
ffe57a7a
AA
1273 * nsmenu.m (-setText): Size tooltip dimensions precisely to
1274 contents (Bug#9176).
1275 (EmacsTooltip -init): Remove bezels and add shadows to
1276 tooltip windows.
1277
bf3492a5
AA
1278 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
1279 or scroll bar (Bug#8470).
1280
d55e9c53
AA
1281 * nsfont.m (nsfont_open): Remove assignment to voffset and
1282 unnecessary vars hshink, expand, hd, full_height, min_height.
1283 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
1284
1285 * nsterm.h (nsfont_info): Remove voffset field.
1286
d8c2fa78 12872011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
1288
1289 Implement strike-through and overline on NextStep (Bug#8863).
1290
1291 * nsfont.m (nsfont_open): Use underline position provided by font,
1292 instead of hard-coded value of 2.
1293 (nsfont_draw): Call ns_draw_text_decoration instead.
1294
1295 * nsterm.h: Add declaration for ns_draw_text_decoration.
1296
1297 * nsterm.m (ns_draw_text_decoration): New function for drawing
1298 underline, overline, and strike-through.
1299 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
1300 ns_draw_text_decoration. Change treatment of cursor drawing to
1301 accomodate underlining, etc.
1302
4cc60b9b
EZ
13032011-07-28 Eli Zaretskii <eliz@gnu.org>
1304
bc7ece87
EZ
1305 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
1306 default.
4cc60b9b 1307
476371c4
PE
13082011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1309
66606eea
PE
1310 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
1311 Without this fix, if a signal arrives just after memory fills up,
1312 'malloc' might be invoked reentrantly.
1313
476371c4
PE
1314 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
1315 In other words, assume that every image size is allowed, on non-X
1316 hosts. This assumption is probably wrong, but it lets Emacs compile.
1317
f3fcc40d
AS
13182011-07-28 Andreas Schwab <schwab@linux-m68k.org>
1319
1320 * regex.c (re_iswctype): Convert return values to boolean.
1321
350c992f
EZ
13222011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
1323
1324 * xdisp.c (compute_display_string_pos): Don't use cached display
1325 string position if the buffer had its restriction changed.
1326 (Bug#9184)
1327
5266b4bb
PE
13282011-07-28 Paul Eggert <eggert@cs.ucla.edu>
1329
1330 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
1331
2573a837 13322011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 1333
41f55ccd 1334 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 1335
39e378da
PE
1336 * bidi.c: Integer size and overflow fixes.
1337 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
1338 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
1339 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1340 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
1341 (bidi_find_other_level_edge):
1342 Use ptrdiff_t instead of EMACS_INT where either will do.
1343 This works better on 32-bit hosts configured --with-wide-int.
1344 (bidi_cache_ensure_space): Check for size-calculation overflow.
1345 Use % rather than repeated addition, for better worst-case speed.
1346 Don't set bidi_cache_size until after xrealloc returns, because it
1347 might not return.
1348 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
1349 (bidi_cache_ensure_space): Also check that the bidi cache size
1350 does not exceed that of the largest Lisp string or buffer. See Eli
1351 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 1352
5e927815
PE
1353 * alloc.c (__malloc_size_t): Remove.
1354 All uses replaced by size_t. See Andreas Schwab's note
1355 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
1356
ca4aa935
PE
1357 * image.c: Improve checking for integer overflow.
1358 (check_image_size): Assume that f is nonnull, since
1359 it is always nonnull in practice. This is one less thing to
1360 worry about when checking for integer overflow later.
1361 (x_check_image_size): New function, which checks for integer
1362 overflow issues inside X.
1363 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
1364 This removes the need for a memory_full check.
1365 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
1366 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
1367 (xbm_read_bitmap_data): Change locals back to 'int', since
1368 their values must fit in 'int'.
1369 (xpm_load_image, png_load, tiff_load):
1370 Invoke x_create_x_image_and_pixmap earlier,
1371 to avoid much needless work if the image is too large.
1372 (tiff_load): Treat overly large images as if
1373 x_create_x_image_and_pixmap failed, not as malloc failures.
1374 (gs_load): Use x_check_image_size.
1375
5f8f9cc2
PE
1376 * gtkutil.c: Omit integer casts.
1377 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
1378 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
1379
5adf60bc
PE
1380 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
1381
c8907a93
PE
1382 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
1383 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
1384 would wrongly return t on a 64-bit host.
1385
e3c25c68
PE
1386 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
1387 The plain *_OVERFLOW macros run afoul of GCC bug 49705
1388 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
1389 and therefore cause GCC to emit a bogus diagnostic in some cases.
1390
3f791afe
PE
1391 * image.c: Integer signedness and overflow and related fixes.
1392 This is not an exhaustive set of fixes, but it's time to
1393 record what I've got.
1394 (lookup_pixel_color, check_image_size): Remove redundant decls.
1395 (check_image_size): Don't assume that arbitrary EMACS_INT values
1396 fit in 'int', or that arbitrary 'double' values fit in 'int'.
1397 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
1398 (tiff_load, imagemagick_load_image):
1399 Check for overflow in size calculations.
1400 (x_create_x_image_and_pixmap): Remove unnecessary test for
1401 xmalloc returning NULL; that can't happen.
1402 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
1403 (xpm_color_bucket): Use better integer hashing function.
1404 (xpm_cache_color): Don't possibly over-allocate memory.
1405 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
1406 (gif_memory_source):
1407 Use ptrdiff_t, not int or size_t, to record sizes.
1408 (png_load): Don't assume values greater than 2**31 fit in 'int'.
1409 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
1410 either works, as we prefer signed integers.
1411 (tiff_read_from_memory, tiff_write_from_memory):
1412 Return tsize_t, not size_t, since that's what the TIFF API wants.
1413 (tiff_read_from_memory): Don't fail simply because the read would
1414 go past EOF; instead, return a short read.
1415 (tiff_load): Omit no-longer-needed casts.
1416 (Fimagemagick_types): Don't assume size fits into 'int'.
1417
3cc5a532
PE
1418 Improve hashing quality when configured --with-wide-int.
1419 * fns.c (hash_string): New function, taken from sxhash_string.
1420 Do not discard information about ASCII character case; this
1421 discarding is no longer needed.
1422 (sxhash-string): Use it. Change sig to match it. Caller changed.
1423 * lisp.h: Declare it.
1424 * lread.c (hash_string): Remove, since we now use fns.c's version.
1425 The fns.c version returns a wider integer if --with-wide-int is
1426 specified, so this should help the quality of the hashing a bit.
1427
b312a492
PE
1428 * emacs.c: Integer overflow minor fix.
1429 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
1430 Define only if GNU_LINUX.
1431 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
1432
dfd153ae
PE
1433 * dispnew.c: Integer signedness and overflow fixes.
1434 Remove unnecessary forward decls, that were a maintenance hassle.
1435 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
1436 All uses changed.
1437 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
1438 (scrolling_window): Use ptrdiff_t, not int, for byte count.
1439 (prepare_desired_row, line_draw_cost):
1440 Use int, not unsigned, where either works.
1441 (save_current_matrix, restore_current_matrix):
1442 Use ptrdiff_t, not size_t, where either works.
1443 (init_display): Check for overflow more accurately, and without
1444 relying on undefined behavior.
1445
a81d11a3
PE
1446 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
1447 Remove, replacing with the new symbols in lisp.h. All uses changed.
1448 * fileio.c (make_temp_name):
1449 * filelock.c (lock_file_1, lock_file):
1450 * xdisp.c (message_dolog):
1451 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
1452 Use pMd etc. instead.
1453 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
1454 replacing the pWIDE etc. symbols removed from editfns.c.
1455
3300e6fd
PE
1456 * keyboard.h (num_input_events): Now uintmax_t.
1457 This is (very slightly) less likely to mess up due to wraparound.
1458 All uses changed.
1459
fd05c7e9
PE
1460 * buffer.c: Integer signedness fixes.
1461 (alloc_buffer_text, enlarge_buffer_text):
1462 Use ptrdiff_t rather than size_t when either will do, as we prefer
1463 signed integers.
1464
903fe15d
PE
1465 * alloc.c: Integer signedness and overflow fixes.
1466 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
1467 (__malloc_size_t): Default to size_t, not to int.
1468 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
1469 (Fgarbage_collect, mark_object_loop_halt, mark_object):
1470 Prefer ptrdiff_t to size_t when either would do, as we prefer
1471 signed integers.
1472 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
1473 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
1474 Now const. Initialize with values that are in range even if char
1475 is signed.
1476 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
1477 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
1478 These functions do the right thing with sizes > 2**32.
1479 (check_depth): Now ptrdiff_t, not int.
1480 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
1481 Adjust to new way of storing sizes. Check for size overflow bugs
1482 in rest of code.
1483 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
1484 slightly wrong anyway, as it missed one instance of
1485 XMALLOC_OVERRUN_CHECK_OVERHEAD.
1486 (refill_memory_reserve): Omit needless cast to size_t.
1487 (mark_object_loop_halt): Mark as externally visible.
1488
ac82cc6a
PE
1489 * xselect.c: Integer signedness and overflow fixes.
1490 (Fx_register_dnd_atom, x_handle_dnd_message):
1491 Use ptrdiff_t, not size_t, since we prefer signed.
1492 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
1493 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
1494 x_dnd_atoms_size and x_dnd_atoms_length.
1495
c2d1e36d
PE
1496 * doprnt.c: Prefer signed to unsigned when either works.
1497 * eval.c (verror):
1498 * doprnt.c (doprnt):
1499 * lisp.h (doprnt):
1500 * xdisp.c (vmessage):
1501 Use ptrdiff_t, not size_t, when using or implementing doprnt,
1502 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
1503 prefer signed arithmetic to avoid comparison confusion.
1504 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
1505 but is a bit tricky.
1506
0e926e56
PE
1507 Assume freestanding C89 headers, string.h, stdlib.h.
1508 * data.c, doprnt.c, floatfns.c, print.c:
1509 Include float.h unconditionally.
1510 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
1511 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
1512 * regex.c: Likewise for stddef.h, string.h.
1513 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
1514 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
1515 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
1516 (STDC_HEADERS): Remove obsolete defines.
1517 * sysdep.c: Include limits.h unconditionally.
1518
9cfdb3ec
PE
1519 Assume support for memcmp, memcpy, memmove, memset.
1520 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
1521 * regex.c (memcmp, memcpy):
1522 Remove; we assume C89 now.
1523
1524 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
1525 (__malloc_safe_bcopy): Remove; no longer needed.
1526
cf950e6b 1527 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
1528 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
1529 well either way, and we prefer signed to unsigned.
1530
dbf38e02
LMI
15312011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
1532
1533 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
1534 closes the connection while we're reading (bug#9182).
1535
d6f0886c 15362011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 1537
d6f0886c
JD
1538 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
1539 are specified (Bug#9168).
24e0f6b1 1540
2eb1f9e6
PE
15412011-07-25 Paul Eggert <eggert@cs.ucla.edu>
1542
1543 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
1544 Found by GCC static checking and --with-wide-int on a 32-bit host.
1545
22381272 15462011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
1547
1548 * xdisp.c (compute_display_string_pos): Fix logic of caching
1549 previous display string position. Initialize cached_prev_pos to
1550 -1. Fixes slow-down at the beginning of a buffer.
1551
f25e39b4
EZ
15522011-07-24 Eli Zaretskii <eliz@gnu.org>
1553
1554 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
1555 for attrs[LFACE_FONTSET_INDEX].
1556
04c4b52e
PE
15572011-07-23 Paul Eggert <eggert@cs.ucla.edu>
1558
1559 * xml.c (parse_region): Remove unused local
1560 that was recently introduced.
1561
c1734fbd
EZ
15622011-07-23 Eli Zaretskii <eliz@gnu.org>
1563
be18c5a5
EZ
1564 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
1565 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
1566
c1734fbd
EZ
1567 * xdisp.c (move_it_in_display_line_to): Record the best matching
1568 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
1569 exit if none of the characters scanned was an exact match.
1570 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
1571 when exact match is impossible due to invisible text, and the
1572 lines are truncated.
1573
a258d627
JD
15742011-07-23 Jan Djärv <jan.h.d@swipnet.se>
1575
1576 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
1577 for OSX >= 10.7.
1578
b6d5a689
EZ
15792011-07-22 Eli Zaretskii <eliz@gnu.org>
1580
0f74f785
EZ
1581 Fix a significant slow-down of cursor motion with C-n, C-p,
1582 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
1583 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 1584 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
1585 (next_element_from_buffer): Call compute_stop_pos_backwards to
1586 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
1587 base_level_stop.
1588 (reseat): Don't look for prev_stop, as that could mean a very long
1589 run.
1590 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
1591 <cached_disp_overlay_modiff>: Cache for last found display string
1592 position.
551918c1 1593 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
1594 about the same buffer in the same area of character positions, and
1595 the buffer wasn't changed since the time the display string
1596 position was cached.
551918c1 1597
b2d0c91a
EZ
15982011-07-22 Eli Zaretskii <eliz@gnu.org>
1599
1600 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
1601 is an integer, which is important for empty lines. (Bug#9149)
1602
043604ee
CY
16032011-07-22 Chong Yidong <cyd@stupidchicken.com>
1604
1605 * frame.c (Fmodify_frame_parameters): In tty case, update the
1606 default face if necessary (Bug#4238).
1607
da4adb04
CY
16082011-07-21 Chong Yidong <cyd@stupidchicken.com>
1609
1610 * editfns.c (Fstring_to_char): No need to explain what a character
1611 is in the docstring (Bug#6576).
1612
9abd0532
LMI
16132011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1614
1615 * xml.c (parse_region): Make sure we always return a tree.
1616
36881d16
HK
16172011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
1618
1619 * xml.c (parse_region): If a document contains only comments,
1620 return that, too.
1621
1e98674d
LMI
16222011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
1623
1624 * xml.c (make_dom): Return comments, too.
1625
590bd467
PE
16262011-07-19 Paul Eggert <eggert@cs.ucla.edu>
1627
1628 Port to OpenBSD.
1629 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
1630 and the surrounding thread.
1631 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
1632 rather than fgets, and retry after EINTR. Otherwise, 'emacs
1633 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
1634 timer goes off.
1635 * s/openbsd.h (BROKEN_SIGIO): Define.
1636 * unexelf.c (unexec) [__OpenBSD__]:
1637 Don't update the .mdebug section of the Alpha COFF symbol table.
1638
f41628b2
LMI
16392011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
1640
1641 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
1642 (bug#8460).
1643
b59b67c5
PE
16442011-07-18 Paul Eggert <eggert@cs.ucla.edu>
1645
15e3a074
PE
1646 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
1647 This fixes some race conditions on the permissions of any newly
1648 created file.
1649
41bed37d
PE
1650 * alloc.c (valid_pointer_p): Use pipe, not open.
1651 This fixes some permissions issues when debugging.
1652
b59b67c5
PE
1653 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
1654 If fchown fails to set both uid and gid, try to set just gid,
1655 as that is sometimes allowed. Adjust the file's mode to eliminate
1656 setuid or setgid bits that are inappropriate if fchown fails.
1657
925a6be7
SM
16582011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
1659
1660 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
1661 to compare Lisp_Objects.
1662 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
1663 global_gnutls_log_level, don't mistake it for a Lisp_Object.
1664 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
1665
52968808
AS
16662011-07-17 Andreas Schwab <schwab@linux-m68k.org>
1667
0a6a104b
AS
1668 * lread.c (read_integer): Unread even EOF character.
1669 (read1): Likewise. Properly record start position of symbol.
1670
52968808
AS
1671 * lread.c (read1): Read `#:' as empty uninterned symbol if no
1672 symbol character follows.
1673
9e381cdd
PE
16742011-07-17 Paul Eggert <eggert@cs.ucla.edu>
1675
1676 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
1677 This works around a problem with the previous change to Fcopy_file.
1678 Recent glibc declares fchown with __attribute__((warn_unused_result)),
1679 and without this change, GCC might complain about discarding
1680 fchown's return value.
1681
b5641435
JB
16822011-07-16 Juanma Barranquero <lekktu@gmail.com>
1683
1684 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
1685
a8031457
PE
16862011-07-16 Paul Eggert <eggert@cs.ucla.edu>
1687
1688 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
1689
dd889327
LMI
16902011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
1691
750c33f7
LMI
1692 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
1693 it's used from the C level.
1694
dd889327
LMI
1695 * process.c: Use the same condition for POLL_FOR_INPUT in both
1696 keyboard.c and process.c (bug#1858).
1697
87e86684
LM
16982011-07-09 Lawrence Mitchell <wence@gmx.li>
1699
1700 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
1701 (Fgnutls_boot): Use it.
1702
64348f40
AS
17032011-07-15 Andreas Schwab <schwab@linux-m68k.org>
1704
1705 * doc.c (Fsubstitute_command_keys): Revert last change.
1706
1d698799
LMI
17072011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
1708
f863868c
LMI
1709 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
1710 quotes the next character, and doesn't affect other longer
1711 sequences (bug#8935).
1712
1d698799
LMI
1713 * lread.c (syms_of_lread): Clarify that is isn't only
1714 `eval-buffer' and `eval-defun' that's affected by
1715 `lexical-binding' (bug#8460).
1716
aa4b6df6
EZ
17172011-07-15 Eli Zaretskii <eliz@gnu.org>
1718
1719 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
1720 bidi redisplay when a line includes both an image and is
1721 truncated.
1722
5d856da6
PE
17232011-07-14 Paul Eggert <eggert@cs.ucla.edu>
1724
ad6042bb
PE
1725 Fix minor problems found by static checking.
1726 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
1727 (elsz): Now a signed constant, not a size_t var. We prefer signed
1728 types to unsigned, to avoid integer comparison confusion. Without
1729 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
1730 "cannot optimize loop, the loop counter may overflow", a symptom
1731 of the confusion.
f00bbb22 1732 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
1733 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
1734
6468f31c
LMI
17352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1736
49080b10
LMI
1737 * search.c (Fre_search_backward): Mention `case-fold-search' in
1738 all the re_search_* functions (bug#8138).
1739
6468f31c
LMI
1740 * keyboard.c (Fopen_dribble_file): Document when the file is
1741 closed (bug#8056).
1742
c965adc5
EZ
17432011-07-14 Eli Zaretskii <eliz@gnu.org>
1744
df9733bf
EZ
1745 * bidi.c (bidi_dump_cached_states): Fix format of displaying
1746 bidi_cache_idx.
1747
0bb23927
EZ
1748 Support bidi reordering of display and overlay strings.
1749 * xdisp.c (compute_display_string_pos)
1750 (compute_display_string_end): Accept additional argument STRING.
1751 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
1752 (reseat_to_string): Initialize bidi_it->string.s and
1753 bidi_it->string.schars.
1754 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
1755 NULL (avoids a crash in bidi_paragraph_init).
1756 Initialize itb.string.lstring.
0bb23927
EZ
1757 (init_iterator): Call bidi_init_it only of a valid
1758 buffer position was specified. Initialize paragraph_embedding to
1759 L2R.
1760 (reseat_to_string): Initialize the bidi iterator.
1761 (display_string): If we need to ignore text properties of
1762 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
1763 original value of -1 will not work with bidi.)
1764 (compute_display_string_pos): First arg is now struct
1765 `text_pos *'; all callers changed. Support display properties on
1766 Lisp strings.
1767 (compute_display_string_end): Support display properties on Lisp
1768 strings.
1769 (init_iterator, reseat_1, reseat_to_string): Initialize the
1770 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
1771 when iterating on a string not from display properties).
640c8776
SM
1772 (compute_display_string_pos, compute_display_string_end):
1773 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
1774 arrow keys.
1775 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
1776 base_level_stop; instead, set base_level_stop to BEGV.
1777 Fixes crashes in vertical-motion.
0bb23927
EZ
1778 (next_element_from_buffer): Improve commentary for when
1779 the iterator is before prev_stop.
1780 (init_iterator): Initialize bidi_p from the default value of
1781 bidi-display-reordering, not from buffer-local value. Use the
1782 buffer-local value only if initializing for buffer iteration.
1783 (handle_invisible_prop): Support invisible properties on strings
1784 that are being bidi-reordered.
1785 (set_iterator_to_next): Support bidi reordering of C strings and
1786 Lisp strings.
1787 (next_element_from_string): Support bidi reordering of Lisp
1788 strings.
1789 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
1790 (display_string): Support display of R2L glyph rows.
1791 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
1792 (init_iterator): Don't initialize it->bidi_p for strings
1793 here.
1794 (reseat_to_string): Initialize it->bidi_p for strings here.
1795 (next_element_from_string, next_element_from_c_string)
1796 (next_element_from_buffer): Add xassert's for correspondence
1797 between IT's object being iterated and it->bidi_it.string
1798 structure.
1799 (face_before_or_after_it_pos): Support bidi iteration.
1800 (next_element_from_c_string): Handle the case of the first string
1801 character that is not the first one in the visual order.
1802 (get_visually_first_element): New function, refactored from common
1803 parts of next_element_from_buffer, next_element_from_string, and
1804 next_element_from_c_string.
1805 (tool_bar_lines_needed, redisplay_tool_bar)
1806 (display_menu_bar): Force left-to-right direction. Add a FIXME
1807 comment for making that be controlled by a user option.
1808 (push_it, pop_it): Save and restore the state of the
1809 bidi iterator. Save and restore the bidi_p flag.
1810 (pop_it): Iterate out of display property for string iteration as
1811 well.
1812 (iterate_out_of_display_property): Support iteration over strings.
1813 (handle_single_display_spec): Set up it->bidi_it for iteration
1814 over a display string, and call bidi_init_it.
1815 (handle_single_display_spec, next_overlay_string)
1816 (get_overlay_strings_1, push_display_prop): Set up the bidi
1817 iterator for displaying display or overlay strings.
1818 (forward_to_next_line_start): Don't use the shortcut if
1819 bidi-iterating.
1820 (back_to_previous_visible_line_start): If handle_display_prop
1821 pushed the iterator stack, restore the internal state of the bidi
1822 iterator by calling bidi_pop_it same number of times.
1823 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
1824 and we are bidi-iterating, don't decrement the iterator position;
1825 instead, set the first_elt flag in the bidi iterator, to produce
1826 the same effect.
1827 (reseat_1): Remove redundant setting of string_from_display_prop_p.
1828 (push_display_prop): xassert that we are iterating a buffer.
1829 (push_it, pop_it): Save and restore paragraph_embedding member.
1830 (handle_single_display_spec, next_overlay_string)
1831 (get_overlay_strings_1, reseat_1, reseat_to_string)
1832 (push_display_prop): Set up the `unibyte' member of bidi_it.string
1833 correctly. Don't assume unibyte strings are not bidi-reordered.
1834 (compute_display_string_pos)
1835 (compute_display_string_end): Fix handling the case of C string.
1836 (push_it, pop_it): Save and restore from_disp_prop_p.
1837 (handle_single_display_spec, push_display_prop): Set the
1838 from_disp_prop_p flag.
1839 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
1840 (pop_it): Call iterate_out_of_display_property only if we are
1841 popping after iteration over a string that came from a display
1842 property. Fix a typo in popping stretch info. Add an assertion
1843 for verifying that the iterator position is in sync with the bidi
1844 iterator.
1845 (handle_single_display_spec, get_overlay_strings_1)
1846 (push_display_prop): Fix initialization of paragraph direction for
1847 string when that of the parent object is not yet determined.
1848 (reseat_1): Call bidi_init_it to resync the bidi
1849 iterator with IT's position. (Bug#7616)
1850 (find_row_edges): If ROW->start.pos gives position
1851 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
1852 (handle_stop, back_to_previous_visible_line_start, reseat_1):
1853 Reset the from_disp_prop_p flag.
1854 (SAVE_IT, RESTORE_IT): New macros.
1855 (pos_visible_p, face_before_or_after_it_pos)
1856 (back_to_previous_visible_line_start)
1857 (move_it_in_display_line_to, move_it_in_display_line)
1858 (move_it_to, move_it_vertically_backward, move_it_by_lines)
1859 (try_scrolling, redisplay_window, display_line): Use them when
1860 saving a temporary copy of the iterator and restoring it back.
1861 (back_to_previous_visible_line_start, reseat_1)
1862 (init_iterator): Empty the bidi cache "stack".
1863 (move_it_in_display_line_to): If iterator ended up at
1864 EOL, but we never saw any buffer positions smaller than
1865 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
1866 motion in bidi-reordered lines.
1867 (move_it_in_display_line_to): Record prev_method and prev_pos
1868 immediately before the call to set_iterator_to_next. Fixes cursor
1869 motion in bidi-reordered lines with stretch glyphs and strings
1870 displayed in margins. (Bug#8133) (Bug#8867)
1871 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
1872 TO_CHARPOS.
640c8776
SM
1873 (pos_visible_p): Support positions in bidi-reordered lines.
1874 Save and restore bidi cache.
0bb23927
EZ
1875
1876 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
1877 (bidi_paragraph_info): Delete unused struct.
1878 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
1879 (bidi_cache_start): New variable.
1880 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
1881 to zero.
1882 (bidi_cache_fetch_state, bidi_cache_search)
1883 (bidi_cache_find_level_change, bidi_cache_iterator_state)
1884 (bidi_cache_find, bidi_peek_at_next_level)
1885 (bidi_level_of_next_char, bidi_find_other_level_edge)
1886 (bidi_move_to_visually_next): Compare cache index with
1887 bidi_cache_start rather than with zero.
1888 (bidi_fetch_char): Accept new argument STRING; all callers
1889 changed. Support iteration over a string. Support strings with
1890 display properties. Support unibyte strings. Fix the type of
1891 `len' according to what STRING_CHAR_AND_LENGTH expects.
1892 (bidi_paragraph_init, bidi_resolve_explicit_1)
1893 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
1894 (bidi_level_of_next_char, bidi_move_to_visually_next):
1895 Support iteration over a string.
0bb23927
EZ
1896 (bidi_set_sor_type, bidi_resolve_explicit_1)
1897 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
1898 can now be zero (for strings); special values 0 and -1 were
1899 changed to -1 and -2, respectively.
1900 (bidi_char_at_pos): New function.
1901 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
1902 Call it instead of FETCH_MULTIBYTE_CHAR.
1903 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
1904 initialized to valid values.
1905 (bidi_init_it): Don't initialize charpos and bytepos with invalid
1906 values.
1907 (bidi_level_of_next_char): Allow the sentinel "position" to pass
1908 the test for valid cached positions. Fix the logic for looking up
1909 the sentinel state in the cache. GCPRO the Lisp string we are
1910 iterating.
1911 (bidi_push_it, bidi_pop_it): New functions.
1912 (bidi_initialize): Initialize the bidi cache start stack pointer.
1913 (bidi_cache_ensure_space): New function, refactored from part of
1914 bidi_cache_iterator_state. Don't assume the required size is just
1915 one BIDI_CACHE_CHUNK away.
1916 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
1917 (bidi_count_bytes, bidi_char_at_pos): New functions.
1918 (bidi_cache_search): Don't assume bidi_cache_last_idx is
1919 always valid if bidi_cache_idx is valid.
1920 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
1921 is valid if it's going to be used.
1922 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
1923 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
1924 (bidi_cache_find_level_change, bidi_cache_ensure_space)
1925 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
1926 (bidi_find_other_level_edge, bidi_cache_start_stack):
1927 All variables related to cache indices are now EMACS_INT.
c965adc5 1928
0bb23927
EZ
1929 * dispextern.h (struct bidi_string_data): New structure.
1930 (struct bidi_it): New member `string'. Make flag members be 1-bit
1931 fields, and put them last in the struct.
640c8776
SM
1932 (compute_display_string_pos, compute_display_string_end):
1933 Update prototypes.
0bb23927
EZ
1934 (bidi_push_it, bidi_pop_it): Add prototypes.
1935 (struct iterator_stack_entry): New members bidi_p,
1936 paragraph_embedding, and from_disp_prop_p.
1937 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
1938 (bidi_shelve_cache, bidi_unshelve_cache):
1939 Declare prototypes.
0bb23927
EZ
1940
1941 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
1942 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
1943 and vector-like objects.
1944
1945 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
1946 cache around display iteration.
1947
1948 * window.c (Fwindow_end, window_scroll_pixel_based)
1949 (displayed_window_lines, Frecenter): Save and restore the bidi
1950 cache around display iteration.
1951
3bbd2265
LMI
19522011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
1953
1954 * editfns.c (Fdelete_region): Clarify the use of the named
1955 parameters (bug#6788).
1956
adc47434
MR
19572011-07-14 Martin Rudalics <rudalics@gmx.at>
1958
1959 * indent.c (Fvertical_motion): Set and restore w->pointm when
1960 saving and restoring the window's buffer (Bug#9006).
1961
837c31f8
LMI
19622011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
1963
1964 * editfns.c (Fstring_to_char): Clarify just what is returned
1965 (bug#6576). Text by Eli Zaretskii.
1966
ac389d0c
JB
19672011-07-13 Juanma Barranquero <lekktu@gmail.com>
1968
1969 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
1970
0be0ce47
EZ
19712011-07-13 Eli Zaretskii <eliz@gnu.org>
1972
1973 * buffer.c (mmap_find): Fix a typo.
1974
cd18e7e3
JB
19752011-07-13 Johan Bockgård <bojohan@gnu.org>
1976
1977 Fix execution of x selection hooks.
1978 * xselect.c (Qx_lost_selection_functions)
1979 (Qx_sent_selection_functions): New vars.
1980 (syms_of_xselect): DEFSYM them.
1981 (x_handle_selection_request): Pass Qx_sent_selection_functions
1982 rather than Vx_sent_selection_functions to Frun_hook_with_args.
1983 (x_handle_selection_clear,x_clear_frame_selections):
1984 Pass Qx_lost_selection_functions rather than
1985 Vx_lost_selection_functions to Frun_hook_with_args.
1986
47ea7f44
PE
19872011-07-13 Paul Eggert <eggert@cs.ucla.edu>
1988
ac389d0c 1989 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
1990 The old code sometimes used this field without initializing it.
1991
47ea7f44
PE
1992 * alloc.c (gc_sweep): Don't read past end of array.
1993 In theory, the old code could also have corrupted Emacs internals,
1994 though it'd be very unlikely.
1995
bc985c87
AS
19962011-07-12 Andreas Schwab <schwab@linux-m68k.org>
1997
1998 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 1999 argument. (Bug#4026)
bc985c87 2000
0cf34688
LMI
20012011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
2002
b3dadd76
LMI
2003 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
2004 key" (bug#4257).
2005
0cf34688
LMI
2006 * window.c (Fset_window_start): Doc fix (bug#4199).
2007 (Fset_window_hscroll): Ditto.
2008
270768cd
PE
20092011-07-12 Paul Eggert <eggert@cs.ucla.edu>
2010
077e3dda 2011 Fix minor new problems caught by GCC 4.6.1.
270768cd 2012 * term.c (init_tty): Remove unused local.
490011a6 2013 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 2014 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 2015 not used otherwise.
270768cd 2016
b1f58454
CY
20172011-07-12 Chong Yidong <cyd@stupidchicken.com>
2018
2019 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
2020
22b9578d
LMI
20212011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2022
6e70ab07
LMI
2023 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
2024 are the mini-buffer and the echo area (bug#3320).
2025
22b9578d
LMI
2026 * term.c (init_tty): Remove support for supdup, c10 and perq
2027 terminals, which are no longer supported (bug#1482).
2028
8974cc9f
JB
20292011-07-10 Johan Bockgård <bojohan@gnu.org>
2030
2031 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
2032
a560d974
JD
20332011-07-10 Jan Djärv <jan.h.d@swipnet.se>
2034
2035 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
2036 for non-popups (Bug#3642).
2037
1dae0f0a
AS
20382011-07-10 Andreas Schwab <schwab@linux-m68k.org>
2039
268c2c36 2040 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 2041 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
2042 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
2043 * cm.c (losecursor): Likewise.
1dae0f0a
AS
2044 * data.c (fmod): Likewise.
2045 * dispnew.c (swap_glyphs_in_rows): Likewise.
2046 * emacs.c (memory_warning_signal): Likewise.
2047 * floatfns.c (float_error): Likewise.
2048 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
2049 (otf_open, font_otf_capability, generate_otf_features)
2050 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
2051 Likewise.
2052 * image.c (pbm_read_file): Likewise.
2053 * indent.c (string_display_width): Likewise.
2054 * intervals.c (check_for_interval, search_for_interval)
2055 (inc_interval_count, count_intervals, root_interval)
2056 (adjust_intervals_for_insertion, make_new_interval): Likewise.
2057 * lread.c (defalias): Likewise.
268c2c36 2058 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
2059 * regex.c (set_image_of_range_1, set_image_of_range)
2060 (regex_grow_registers): Likewise.
2061 * sysdep.c (strerror): Likewise.
2062 * termcap.c (valid_filename_p, tprint, main): Likewise.
2063 * tparam.c (main): Likewise.
2064 * unexhp9k800.c (run_time_remap, save_data_space)
2065 (update_file_ptrs, read_header, write_header, calculate_checksum)
2066 (copy_file, copy_rest, display_header): Likewise.
2067 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
2068 Likewise.
2069 * xdisp.c (check_it): Likewise.
2070 * xfaces.c (register_color, unregister_color, unregister_colors):
2071 Likewise.
2072 * xfns.c (print_fontset_result): Likewise.
2073 * xrdb.c (member, fatal, main): Likewise.
2074
99033785
PE
20752011-07-10 Paul Eggert <eggert@cs.ucla.edu>
2076
2077 Fix minor problems found by static checking (Bug#9031).
2078 * chartab.c (char_table_set_range, map_sub_char_table):
2079 Remove unused locals.
2080 (uniprop_table): Now static.
2081 * composite.c (_work_char): Remove unused static var.
2082
9cb2ac56
JB
20832011-07-09 Juanma Barranquero <lekktu@gmail.com>
2084
2085 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
2086
f25661f0
JD
20872011-07-09 Jan Djärv <jan.h.d@swipnet.se>
2088
2089 * gtkutil.c (qttip_cb): Remove code without function.
2090
8278c4fe
EZ
20912011-07-09 Eli Zaretskii <eliz@gnu.org>
2092
2093 * w32.c (pthread_sigmask): New stub.
2094
1692ae2d 20952011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 2096
8a6ebd58 2097 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
2098 sigprocmask is portable only for single-threaded applications, and
2099 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
2100 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
2101 (LIBES): Use it.
2102 * callproc.c (Fcall_process):
2103 * process.c (create_process):
2104 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
2105 Use pthread_sigmask, not sigprocmask.
123403e4 2106
1b854618
JD
21072011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2108
2109 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
2110 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
2111 wrong (Bug#8591).
2112
3fe4b549
JD
21132011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2114
0ce7e563
JD
2115 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
2116 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
2117 (xg_hide_tooltip): Fix comment.
2118
3fe4b549
JD
2119 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
2120 in registerServicesMenuSendTypes.
2121 (validRequestorForSendType): Don't check ns_return_types.
2122
2123 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
2124 ns_return_type.
2125
5df75e47
JR
21262011-07-08 Jason Rumney <jasonr@gnu.org>
2127
2128 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
2129 frame struct members of non-existent frames (Bug#6284).
2130
699c10bd
JD
21312011-07-08 Jan Djärv <jan.h.d@swipnet.se>
2132
4393663b
JD
2133 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
2134 variable firstTime not needed on OSX >= 10.6.
2135 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
2136 >= 10.5. Use setKnobProportion, setDoubleValue.
2137
2138 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
2139 (MAC_OS_X_VERSION_10_5): Define if not defined.
2140 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
2141 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
2142 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
2143
2144 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
2145 cString and lossyCString on OSX >= 10.4
2146
2147 * nsmenu.m (fillWithWidgetValue): Don't use depercated method
2148 sizeToFit on OSX >= 10.2.
2149
2150 * nsimage.m (allocInitFromFile): Don't use deprecated method
2151 bestRepresentationForDevice on OSX >= 10.6.
2152
2153 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
2154 to avoid warning.
2155
2156 * emacs.c: Declare unexec_init_emacs_zone.
2157
a63e0781
JD
2158 * nsgui.h: Fix compiler warning about gnulib redefining verify.
2159
699c10bd
JD
2160 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
2161
2162 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
2163 on svcsMenu (Bug#8842).
2164
2165 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
2166 ns_return_types.
2167 (Fns_list_services): Just return Qnil on 10.6, code not working there.
2168
2169 * nsterm.m (QUTF8_STRING): Declare.
2170 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
2171 (validRequestorForSendType): Return type is (id).
2172 Change indexOfObjectIdenticalTo to indexOfObject.
2173 Check if we have local selection before returning self (Bug#8842).
2174 (writeSelectionToPasteboard): Put local selection into paste board
2175 if we have a local selection (Bug#8842).
2176 (syms_of_nsterm): DEFSYM QUTF8_STRING.
2177
2178 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
2179 (ns_get_local_selection): Declare.
2180
54e10184
LMI
21812011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
2182
9888ff71
LMI
2183 * keymap.c (describe_map_tree): Don't insert a double newline at
2184 the end of the buffer (bug#1169) and return whether we inserted
2185 something.
2186
54e10184
LMI
2187 * callint.c (Fcall_interactively): Change "reading args" to
2188 "providing args" to try to clarify what it does (bug#1010).
2189
15fa4783
KH
21902011-07-07 Kenichi Handa <handa@m17n.org>
2191
2192 * composite.c (composition_compute_stop_pos): Ignore a static
2193 composition starting before CHARPOS (Bug#8915).
2194
2195 * xdisp.c (handle_composition_prop): Likewise.
2196
a8815b00
EZ
21972011-07-07 Eli Zaretskii <eliz@gnu.org>
2198
2199 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
2200 (Bug#9015)
2201
ef7b981d 22022011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
2203
2204 * character.h (unicode_category_t): New enum type.
2205
2206 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
2207 (Qchar_code_property_table): New variable.
2208 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
2209 (UNIPROP_COMPRESSED_FORM_P): New macros.
2210 (char_table_ascii): Uncompress the compressed values.
2211 (sub_char_table_ref): New arg is_uniprop. Callers changed.
2212 Uncompress the compressed values.
ac389d0c 2213 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
2214 (char_table_ref_and_range): Uncompress the compressed values.
2215 (sub_char_table_set): New arg is_uniprop. Callers changed.
2216 Uncompress the compressed values.
2217 (sub_char_table_set_range): Args changed. Callers changed.
2218 (char_table_set_range): Adjuted for the above change.
2219 (map_sub_char_table): Delete args default_val and parent. Add arg
2220 top. Give decoded values to a Lisp function.
640c8776 2221 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
2222 values to a Lisp function. Gcpro more variables.
2223 (uniprop_table_uncompress)
2224 (uniprop_decode_value_run_length): New functions.
2225 (uniprop_decoder, uniprop_decoder_count): New variables.
2226 (uniprop_get_decoder, uniprop_encode_value_character)
2227 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
2228 New functions.
2229 (uniprop_encoder, uniprop_encoder_count): New variables.
2230 (uniprop_get_encoder, uniprop_table)
2231 (Funicode_property_table_internal, Fget_unicode_property_internal)
2232 (Fput_unicode_property_internal): New functions.
2233 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
2234 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 2235 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
2236 char-code-property-alist.
2237
640c8776 2238 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
2239 Vunicode_category_table.
2240
640c8776 2241 * font.c (font_range): Adjust for the change of
c805dec0
KH
2242 Vunicode_category_table.
2243
76b397fb
DN
22442011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
2245
2246 * m/iris4d.h: Remove file, move contents ...
2247 * s/irix6-5.h: ... here.
2248
22b4128e
PE
22492011-07-06 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
2252 * alloc.c (mark_buffer):
2253 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
2254 (clone_per_buffer_values): Don't assume that
22b4128e
PE
2255 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
2256 This isn't true in general, and it's particularly not true
2257 if Emacs is configured with --with-wide-int.
2258 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
2259 New macros, used in the buffer.c change.
2260
869795d6
JD
22612011-07-05 Jan Djärv <jan.h.d@swipnet.se>
2262
2263 * xsettings.c: Use both GConf and GSettings if both are available.
2264 (store_config_changed_event): Add comment.
2265 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
2266 (store_tool_bar_style_changed): New functions.
5e617bc2 2267 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
2268 (struct xsettings): Move font inside HAVE_XFT.
2269 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 2270 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 2271 Move inside HAVE_XFT.
640c8776 2272 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
2273 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
2274 also.
2275 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 2276 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 2277 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
2278 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
2279 (parse_settings): Move check for font inside HAVE_XFT.
2280 (read_settings, apply_xft_settings): Add comment.
2281 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
2282 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
2283 call store_font_name_changed.
2284 (xft_settings_event): Add comment.
2285 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
2286 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
2287 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
2288 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
2289 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
2290 (xsettings_get_system_font, xsettings_get_system_normal_font):
2291 Add comment.
869795d6 2292
d8ed26bd
PE
22932011-07-05 Paul Eggert <eggert@cs.ucla.edu>
2294
2295 Random fixes. E.g., (random) never returned negative values.
2296 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
2297 subseconds part to the entropy, as that's a bit more random.
2298 Prefer signed to unsigned, since the signedness doesn't matter and
2299 in general we prefer signed. When given a limit, use a
2300 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
2301 latter isn't right if USE_2_TAGS_FOR_INTS.
2302 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
2303 not 0..VALMASK. Don't discard "excess" bits that random () returns.
2304
cabf1cac
SM
23052011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
2306
2307 * textprop.c (text_property_stickiness):
2308 Obey Vtext_property_default_nonsticky.
2309 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
2310 * w32fns.c (syms_of_w32fns):
2311 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
2312
6e9b2be9
PE
23132011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2314
2315 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
2316 This is more efficient than Ffile_directory_p and avoids a minor race.
2317
90186c68
LMI
23182011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
2319
7c301272
LMI
2320 * buffer.c (Foverlay_put): Say what the return value is
2321 (bug#7835).
2322
c4f2d8d4
LMI
2323 * fileio.c (barf_or_query_if_file_exists): Check first if the file
2324 is a directory before asking whether to use the file name
2325 (bug#7564).
ad637907
LMI
2326 (barf_or_query_if_file_exists): Make the "File is a directory"
2327 error be more correct.
c4f2d8d4 2328
90186c68
LMI
2329 * fns.c (Frequire): Remove the mention of the .gz files, since
2330 that's installation-specific, but keep the mention of
2331 `get-load-suffixes'.
2332
da64016e
PE
23332011-07-04 Paul Eggert <eggert@cs.ucla.edu>
2334
2335 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
2336 Report string overflow if the output is too long.
2337
7d47b580
JB
23382011-07-04 Juanma Barranquero <lekktu@gmail.com>
2339
a555cb87
JB
2340 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
2341 (syms_of_gnutls): Remove duplicate DEFSYM for
2342 Qgnutls_bootprop_verify_hostname_error, an error for
2343 Qgnutls_bootprop_verify_error (which is no longer used).
2344
7d47b580
JB
2345 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
2346 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
2347 Also (re)move comments that are misplaced or no longer relevant.
2348
1e49bfab
LMI
23492011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2350
2351 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
2352
1485f4c0
CY
23532011-07-03 Chong Yidong <cyd@stupidchicken.com>
2354
2355 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
2356 and background color parameters if they have been changed.
2357
a9ab721e
LMI
23582011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2359
2360 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
2361
cf7cff57
PE
23622011-07-03 Paul Eggert <eggert@cs.ucla.edu>
2363
2e13213d
PE
2364 * xsettings.c (SYSTEM_FONT): Define only when used.
2365 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
2366
cf7cff57
PE
2367 * keymap.c (access_keymap_1): Now static.
2368
7a8e04f7
CY
23692011-07-02 Chong Yidong <cyd@stupidchicken.com>
2370
2371 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
2372 leave any prefix arg for the up event (Bug#1586).
2373
61352f62
LMI
23742011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
2375
69bb1ef7
LMI
2376 * lread.c (syms_of_lread): Mention single symbols defined by
2377 `defvar' or `defconst' (bug#7154).
2378
61352f62 2379 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 2380 (Frequire): Mention get-load-suffixes.
61352f62 2381
28545e04
MR
23822011-07-02 Martin Rudalics <rudalics@gmx.at>
2383
2384 * window.h (window): Remove clone_number slot.
2385 * window.c (Fwindow_clone_number, Fset_window_clone_number):
2386 Remove.
2387 (make_parent_window, make_window, saved_window)
2388 (Fset_window_configuration, save_window_save): Don't deal with
2389 clone numbers.
2390 * buffer.c (Qclone_number): Remove declaration.
2391 (sort_overlays, overlay_strings): Don't deal with clone numbers.
2392
3349e122
SM
23932011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
2394
2395 Add multiple inheritance to keymaps.
2396 * keymap.c (Fmake_composed_keymap): New function.
2397 (Fset_keymap_parent): Simplify.
2398 (fix_submap_inheritance): Remove.
2399 (access_keymap_1): New function extracted from access_keymap to handle
2400 embedded parents and handle lists of maps.
2401 (access_keymap): Use it.
2402 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
2403 (Fcopy_keymap): Handle embedded parents.
2404 (Fcommand_remapping, define_as_prefix): Simplify.
2405 (Fkey_binding): Simplify.
2406 (syms_of_keymap): Move minibuffer-local-completion-map,
2407 minibuffer-local-filename-completion-map,
2408 minibuffer-local-must-match-map, and
2409 minibuffer-local-filename-must-match-map to Elisp.
2410 (syms_of_keymap): Defsubr make-composed-keymap.
2411 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
2412 (parse_menu_item): Trivial simplification.
2413
3279eb87
GM
24142011-07-01 Glenn Morris <rgm@gnu.org>
2415
2416 * Makefile.in (SETTINGS_LIBS): Fix typo.
2417
4550efdf
KI
24182011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
2419
2420 * coding.c (Fencode_coding_string): Record the last coding system
2421 used, as the function doc string says (bug#8738).
2422
0949d2b6
JD
24232011-07-01 Jan Djärv <jan.h.d@swipnet.se>
2424
2425 * xsettings.c (store_monospaced_changed): Take new font as arg and
2426 check for change against current_mono_font.
2427 (EMACS_TYPE_SETTINGS): Remove this and related defines.
2428 (emacs_settings_constructor, emacs_settings_get_property)
2429 (emacs_settings_set_property, emacs_settings_class_init)
2430 (emacs_settings_init, gsettings_obj): Remove.
2431 (something_changedCB): New function for HAVE_GSETTINGS.
2432 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
2433 with value as argument.
2434 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
2435 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 2436 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
2437 "changed".
2438
2439 * xgselect.c: Add defined (HAVE_GSETTINGS).
2440 (xgselect_initialize): Ditto.
2441
2442 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
2443 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
2444 xg_select.
2445
bbc6b304
PE
24462011-07-01 Paul Eggert <eggert@cs.ucla.edu>
2447
2448 * eval.c (struct backtrace): Simplify and port the data structure.
2449 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
2450 signed bit field, as this assumption is not portable and it makes
2451 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
2452 "char debug_on_exit : 1" as this is not portable either; instead,
2453 use the portable "unsigned int debug_on_exit : 1". Remove unused
2454 member evalargs. Remove obsolete comments about cc bombing out.
2455
9851bfc5
JD
24562011-06-30 Jan Djärv <jan.h.d@swipnet.se>
2457
51bb811f 2458 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
2459 Let HAVE_GSETTINGS override HAVE_GCONF.
2460 (store_monospaced_changed): New function.
2461 (EMACS_SETTINGS): A new type derived from GObject to handle
2462 GSettings notifications.
2463 (emacs_settings_constructor, emacs_settings_get_property)
2464 (emacs_settings_set_property, emacs_settings_class_init):
2465 New functions.
2466 (gsettings_client, gsettings_obj): New variables.
2467 (GSETTINGS_SCHEMA): New define.
2468 (something_changedCB): Call store_monospaced_changed.
2469 (init_gsettings): New function.
2470 (xsettings_initialize): Call init_gsettings.
2471 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
2472 to NULL.
2473
640c8776 2474 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
2475 GCONF_CFLAGS/LIBS.
2476
5386012d
MR
24772011-06-29 Martin Rudalics <rudalics@gmx.at>
2478
2479 * window.c (resize_root_window, grow_mini_window)
2480 (shrink_mini_window): Rename Qresize_root_window to
2481 Qwindow_resize_root_window and Qresize_root_window_vertically to
2482 Qwindow_resize_root_window_vertically.
2483
f13e0b08
PE
24842011-06-28 Paul Eggert <eggert@cs.ucla.edu>
2485
2486 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
2487
94515237
JB
24882011-06-27 Juanma Barranquero <lekktu@gmail.com>
2489
2490 * makefile.w32-in: Redesign dependencies so they reflect more
2491 clearly which files are directly included by each source file,
2492 and not through other includes.
2493
e43b6e43
MR
24942011-06-27 Martin Rudalics <rudalics@gmx.at>
2495
2496 * buffer.c (Qclone_number): Declare static and DEFSYM it.
2497 (sort_overlays, overlay_strings): When an overlay's clone number
2498 matches the window's clone number process the overlay even if
2499 the overlay's window property doesn't match the current window.
2500
d68443dc
MR
2501 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
2502 (Fwindow_hchild): Rename to Fwindow_left_child.
2503 (Fwindow_next): Rename to Fwindow_next_sibling.
2504 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
2505 (resize_window_check): Rename to window_resize_check.
2506 (resize_window_apply): Rename to window_resize_apply.
2507 (Fresize_window_apply): Rename to Fwindow_resize_apply.
2508 (Fdelete_other_windows_internal, resize_frame_windows)
2509 (Fsplit_window_internal, Fdelete_window_internal)
2510 (grow_mini_window, shrink_mini_window)
2511 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 2512
c7e73be5
JD
25132011-06-26 Jan Djärv <jan.h.d@swipnet.se>
2514
2515 * emacsgtkfixed.h: State that this is only used with Gtk+3.
2516 (emacs_fixed_set_min_size): Remove.
2517 (emacs_fixed_new): Take frame as argument.
2518
2519 * emacsgtkfixed.c: State that this is only used with Gtk+3.
2520 (_EmacsFixedPrivate): Remove minwidth/height.
2521 Add struct frame *f.
2522 (emacs_fixed_init): Initialize priv->f.
2523 (get_parent_class, emacs_fixed_set_min_size): Remove.
2524 (emacs_fixed_new): Set priv->f to argument.
2525 (emacs_fixed_get_preferred_width)
2526 (emacs_fixed_get_preferred_height): Use min_width/height from
2527 frames size_hint to set minimum and natural (Bug#8919).
2528 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
2529 and use min_width/height from frames size_hint to set
2530 min_width/height (Bug#8919).
2531
2532 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
2533 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
2534 Fix indentation.
c7e73be5 2535
cf99dcf8
EZ
25362011-06-26 Eli Zaretskii <eliz@gnu.org>
2537
2538 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
2539 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
2540 called at ZV.
2541
029529ac
CY
25422011-06-26 Chong Yidong <cyd@stupidchicken.com>
2543
2544 * process.c (wait_reading_process_output): Bypass select if
2545 waiting for a cell while ignoring keyboard input, and input is
2546 pending. Suggested by Jan Djärv (Bug#8869).
2547
7a7ef429
PE
25482011-06-25 Paul Eggert <eggert@cs.ucla.edu>
2549
2550 Use gnulib's dup2 module instead of rolling our own.
2551 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
2552
11fdef7d 25532011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
2554
2555 * dispnew.c (scrolling_window): Before scrolling, turn off a
2556 mouse-highlight in the window being scrolled.
2557
cd3520a4
JB
25582011-06-24 Juanma Barranquero <lekktu@gmail.com>
2559
2560 Move DEFSYM to lisp.h and use everywhere.
2561
2562 * character.h (DEFSYM): Move declaration...
2563 * lisp.h (DEFSYM): ...here.
2564
2565 * gnutls.c:
2566 * minibuf.c:
2567 * w32menu.c:
2568 * w32proc.c:
2569 * w32select.c: Don't include character.h.
2570
2571 * alloc.c (syms_of_alloc):
2572 * buffer.c (syms_of_buffer):
2573 * bytecode.c (syms_of_bytecode):
2574 * callint.c (syms_of_callint):
2575 * casefiddle.c (syms_of_casefiddle):
2576 * casetab.c (init_casetab_once):
2577 * category.c (init_category_once, syms_of_category):
2578 * ccl.c (syms_of_ccl):
2579 * cmds.c (syms_of_cmds):
2580 * composite.c (syms_of_composite):
2581 * dbusbind.c (syms_of_dbusbind):
2582 * dired.c (syms_of_dired):
2583 * dispnew.c (syms_of_display):
2584 * doc.c (syms_of_doc):
2585 * editfns.c (syms_of_editfns):
2586 * emacs.c (syms_of_emacs):
2587 * eval.c (syms_of_eval):
2588 * fileio.c (syms_of_fileio):
2589 * fns.c (syms_of_fns):
2590 * frame.c (syms_of_frame):
2591 * fringe.c (syms_of_fringe):
2592 * insdel.c (syms_of_insdel):
2593 * keymap.c (syms_of_keymap):
2594 * lread.c (init_obarray, syms_of_lread):
2595 * macros.c (syms_of_macros):
2596 * msdos.c (syms_of_msdos):
2597 * print.c (syms_of_print):
2598 * process.c (syms_of_process):
2599 * search.c (syms_of_search):
2600 * sound.c (syms_of_sound):
2601 * syntax.c (init_syntax_once, syms_of_syntax):
2602 * terminal.c (syms_of_terminal):
2603 * textprop.c (syms_of_textprop):
2604 * undo.c (syms_of_undo):
2605 * w32.c (globals_of_w32):
2606 * window.c (syms_of_window):
2607 * xdisp.c (syms_of_xdisp):
2608 * xfaces.c (syms_of_xfaces):
2609 * xfns.c (syms_of_xfns):
2610 * xmenu.c (syms_of_xmenu):
2611 * xsettings.c (syms_of_xsettings):
2612 * xterm.c (syms_of_xterm): Use DEFSYM.
2613
4228cf16
TZ
26142011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
2615
cd3520a4 2616 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 2617
7fcccf1e
PE
26182011-06-23 Paul Eggert <eggert@cs.ucla.edu>
2619
7efb4e0e
PE
2620 Integer and buffer overflow fixes (Bug#8873).
2621
ff5844ad
PE
2622 * print.c (printchar, strout): Check for string overflow.
2623 (PRINTPREPARE, printchar, strout):
2624 Don't set size unless allocation succeeds.
2625
90532f02
PE
2626 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
2627 for sizes. Check for string overflow more accurately.
2628 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
2629
6d84508d
PE
2630 * macros.c: Integer and buffer overflow fixes.
2631 * keyboard.h (struct keyboard.kbd_macro_bufsize):
2632 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
2633 Use ptrdiff_t, not int, for sizes.
2634 Don't increment bufsize until after realloc succeeds.
2635 Check for size-calculation overflow.
2636 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
2637
437b2cb4
PE
2638 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
2639
8b9ac8b4
PE
2640 * lread.c: Integer overflow fixes.
2641 (read_integer): Radix is now EMACS_INT, not int,
2642 to improve quality of diagnostics for out-of-range radices.
2643 Calculate buffer size correctly for out-of-range radices.
2644 (read1): Check for integer overflow in radices, and in
2645 read-circle numbers.
82cb60d3
PE
2646 (read_escape): Avoid int overflow.
2647 (Fload, openp, read_buffer_size, read1)
2648 (substitute_object_recurse, read_vector, read_list, map_obarray):
2649 Use ptrdiff_t, not int, for sizes.
2650 (read1): Use EMACS_INT, not int, for sizes.
20270765 2651 Check for size overflow.
8b9ac8b4 2652
7fcccf1e
PE
2653 * image.c (cache_image): Check for size arithmetic overflow.
2654
bfbbd7e7
PE
2655 * lread.c: Integer overflow issues.
2656 (saved_doc_string_size, saved_doc_string_length)
2657 (prev_saved_doc_string_size, prev_saved_doc_string_length):
2658 Now ptrdiff_t, not int.
2659 (read1): Don't assume doc string length fits in int. Check for
2660 out-of-range doc string lengths.
2661 (read_list): Don't assume file position fits in int.
39019e54 2662 (read_escape): Check for hex character overflow.
bfbbd7e7 2663
4e323265
LL
26642011-06-22 Leo Liu <sdl.web@gmail.com>
2665
2666 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
2667 Move to minibuffer.el.
2668
85fece3e
PE
26692011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2670
20b84ce9 2671 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
2672 The following patches are for when GLYPH_DEBUG && !XASSERT.
2673 * dispextern.h (trace_redisplay_p, dump_glyph_string):
2674 * dispnew.c (flush_stdout):
2675 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
2676 Mark as externally visible.
2677 * dispnew.c (check_window_matrix_pointers): Now static.
2678 * dispnew.c (window_to_frame_vpos):
2679 * xfns.c (unwind_create_frame):
2680 * xterm.c (x_check_font): Remove unused local.
2681 * scroll.c (CHECK_BOUNDS):
2682 * xfaces.c (cache_fache): Rename local to avoid shadowing.
2683 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
2684 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
2685 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
2686 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
2687 Now static.
2688 (debug_method_add): Use va_list and vsprintf rather than relying
2689 on undefined behavior with wrong number of arguments.
2690 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
2691 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
2692 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
2693 since we're not interested in debugging glyphs with old libraries.
2694 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
2695 GCC 4.6.0's static checking.
2696
0766b489
PE
26972011-06-22 Paul Eggert <eggert@cs.ucla.edu>
2698
31fd4b32
PE
2699 Integer overflow and signedness fixes (Bug#8873).
2700 A few related buffer overrun fixes, too.
2701
b79e8648
PE
2702 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
2703
0766b489
PE
2704 * dispextern.h (struct face.stipple):
2705 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
2706 (x_bitmap_mask, x_allocate_bitmap_record)
2707 (x_create_bitmap_from_data, x_create_bitmap_from_file)
2708 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
2709 (x_create_bitmap_from_xpm_data):
2710 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
2711 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
2712 (.bitmaps_last):
2713 * xfaces.c (load_pixmap):
2714 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
2715 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
2716 (.bitmaps_last, struct x_output.icon_bitmap):
2717 Use ptrdiff_t, not int, for bitmap indexes.
2718 (x_allocate_bitmap_record): Check for size overflow.
2719 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
2720
b081724f
PE
2721 Use ptrdiff_t, not int, for overlay counts.
2722 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
2723 * editfns.c (overlays_around, get_pos_property):
2724 * textprop.c (get_char_property_and_overlay):
2725 * xdisp.c (next_overlay_change, note_mouse_highlight):
2726 * xfaces.c (face_at_buffer_position):
21514da7
PE
2727 * buffer.c (OVERLAY_COUNT_MAX): New macro.
2728 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
2729 (Fnext_overlay_change, Fprevious_overlay_change)
2730 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 2731 Use ptrdiff_t, not int, for sizes.
21514da7 2732 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 2733
3de73e5e
PE
2734 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
2735
2606c57b
PE
2736 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
2737 (x_session_initialize): Do not assume string length fits in int.
2738
aaafe47a
PE
2739 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
2740 This is unlikely, but can occur if DPI is outlandish.
2741
2674ddc8 2742 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
2743 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
2744
28154962
PE
2745 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
2746 * xrdb.c (magic_file_p, search_magic_path):
2747 Omit last arg SUFFIX; it was always 0. All callers changed.
2748 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
2749
7de51af5
PE
2750 * xfont.c (xfont_match): Avoid need for strlen.
2751
25ed6cc3
PE
2752 * xfns.c: Don't assume strlen fits in int.
2753 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
2754
4eab31dd
PE
2755 * xdisp.c (message_log_check_duplicate): Return intmax_t,
2756 not unsigned long, as we prefer signed integers. All callers changed.
2757 Detect integer overflow in repeat count.
2758 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 2759 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 2760
171e2a58
PE
2761 * termcap.c: Don't assume sizes fit in int and never overflow.
2762 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
2763 (gobble_line): Check for size-calculation overflow.
2764
ad39faca 2765 * minibuf.c (Fread_buffer):
6e5bb2dc 2766 * lread.c (intern, intern_c_string):
74ca2eb3
PE
2767 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
2768 Don't assume string length fits in int.
2769
52c61c22 2770 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
2771 * gtkutil.c (style_changed_cb): Avoid need for strlen.
2772
b5b8c9e5
PE
2773 * font.c: Don't assume string length fits in int.
2774 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
2775 Use ptrdiff_t, not int.
ccd6111c
PE
2776 (font_intern_prop): Don't assume string length fits in int.
2777 Don't assume integer property fits in fixnum.
2778 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 2779
882f0d81 2780 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 2781 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
2782 Reformulate so as not to need the command string.
2783 Invoke gzip -cd rather than gunzip, as it's more portable.
2784 (lock_info_type, lock_file_1, lock_file):
2785 Don't assume pid_t and time_t fit in unsigned long.
2786 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
2787 (current_lock_owner): Prefer signed type for sizes.
2788 Use memcpy, not strncpy, where memcpy is what is really wanted.
2789 Don't assume (via atoi) that time_t and pid_t fit in int.
2790 Check for time_t and/or pid_t out of range, e.g., via a network share.
2791 Don't alloca where an auto var works fine.
2792
93f4cf88
PE
2793 * fileio.c: Fix some integer overflow issues.
2794 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
2795 Don't assume string length fits in int.
2796 (directory_file_name): Don't assume string length fits in long.
2797 (make_temp_name): Don't assume pid fits in int, or that its print
2798 length is less than 20.
2799
f3e92b69
PE
2800 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
2801
1bfdaf10
PE
2802 * coding.c (make_subsidiaries): Don't assume string length fits in int.
2803
35016e9a
PE
2804 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
2805
3d1e65a1
PE
2806 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
2807 We prefer signed integers, even for size calculations.
2808
0b963a93
PE
2809 * emacs.c: Don't assume string length fits in 'int'.
2810 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
2811 (main): Don't invoke strlen when not needed.
2812
573f4b54
PE
2813 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
2814 (XD_DEBUG_MESSAGE): Don't waste a byte.
2815
989f33ba
PE
2816 * callproc.c (getenv_internal_1, getenv_internal)
2817 (Fgetenv_internal):
965d34eb
PE
2818 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
2819
e4d29b33
PE
2820 * lread.c (invalid_syntax): Omit length argument.
2821 All uses changed. This doesn't fix a bug, but it simplifies the
2822 code away from its former Hollerith-constant appearance, and it's
2823 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 2824 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 2825
eb49b136
PE
2826 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
2827 This didn't break anything, but it didn't help either.
2828 It's confusing to put a bogus integer in a place where the actual
2829 value does not matter.
9f62aeb1 2830 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 2831 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 2832
15375a22
PE
2833 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
2834 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
2835 implementation.
b61cc01c
PE
2836 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
2837 We prefer signed types, and the value cannot exceed the EMACS_INT
2838 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
2839 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
2840 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
2841 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 2842
53b2623d
PE
2843 * indent.c (sane_tab_width): New function.
2844 (current_column, scan_for_column, Findent_to, position_indentation)
2845 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 2846 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 2847
51cab52b 2848 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 2849
f2ed8a70
PE
2850 * lisp.h (lint_assume): New macro.
2851 * composite.c (composition_gstring_put_cache):
2852 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
2853
abe80cc6
PE
2854 * editfns.c, insdel.c:
2855 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 2856
b02c740e
PE
2857 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
2858
ebc96716
PE
2859 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
2860
b4e50fa0 2861 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 2862 Use much-faster test for byte-length change.
311d5d7c 2863 Don't assume string byte-length fits in 'int'.
a4cf38e4 2864 Check that character arg fits in 'int'.
85461888 2865 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 2866
c0c1ee9f
PE
2867 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
2868
a498d7f4
PE
2869 * fns.c (concat): Catch string overflow earlier.
2870 Do not rely on integer wraparound.
2871
51cab52b
PE
2872 * dispextern.h (struct it.overlay_strings_charpos)
2873 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
2874 * xdisp.c (forward_to_next_line_start)
2875 (back_to_previous_visible_line_start)
2876 (reseat_at_next_visible_line_start, next_element_from_buffer):
2877 Don't arbitrarily truncate the value of 'selective' to int.
2878
76031fad
PE
2879 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
2880
5eb55db9
PE
2881 * composite.c: Don't truncate sizes to 'int'.
2882 (composition_gstring_p, composition_reseat_it)
2883 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
2884 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
2885 not EMACS_UINT, for indexes.
5eb55db9 2886
0703a717
PE
2887 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
2888
d6202519
PE
2889 * buffer.c: Include <verify.h>.
2890 (struct sortvec.priority, struct sortstr.priority):
8961a454 2891 Now EMACS_INT, not int.
c20998a7 2892 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
2893 (struct sortstr.size, record_overlay_string)
2894 (struct sortstrlist.size, struct sortlist.used):
2895 Don't truncate size to int.
2896 (record_overlay_string): Check for size-calculation overflow.
d6202519 2897 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 2898
d5a19415
JM
28992011-06-22 Jim Meyering <meyering@redhat.com>
2900
029529ac 2901 Don't leak an XBM-image-sized buffer
d5a19415
JM
2902 * image.c (xbm_load): Free the image buffer after using it.
2903
a9041e6c
PE
29042011-06-21 Paul Eggert <eggert@cs.ucla.edu>
2905
2906 Port to Sun C.
2907 * composite.c (find_automatic_composition): Omit needless 'return 0;'
2908 that Sun C diagnosed.
2909 * fns.c (secure_hash): Fix pointer signedness issue.
2910 * intervals.c (static_offset_intervals): New function.
2911 (offset_intervals): Use it.
2912
7f3f739f
LL
29132011-06-21 Leo Liu <sdl.web@gmail.com>
2914
2915 * deps.mk (fns.o):
2916 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
2917 sha512.h.
2918
2919 * fns.c (secure_hash): Rename from crypto_hash_function and change
2920 the first arg to accept symbols.
5b66d427 2921 (Fsecure_hash): New primitive.
7f3f739f
LL
2922 (syms_of_fns): New symbols.
2923
76147d94
DD
29242011-06-20 Deniz Dogan <deniz@dogan.se>
2925
2926 * process.c (Fset_process_buffer): Clarify return value in
2927 docstring.
2928
7d7d0045
CY
29292011-06-18 Chong Yidong <cyd@stupidchicken.com>
2930
2931 * dispnew.c (add_window_display_history): Use BVAR.
2932
2933 * xdisp.c (debug_method_add): Use BVAR.
2934 (check_window_end, dump_glyph_matrix, dump_glyph)
2935 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
2936
2937 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
2938 Likewise.
2939
2940 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
2941 check till after the cache is created in init_frame_faces.
2942
ff2bc410
SM
29432011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
2944
2945 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
2946
28177add
PE
29472011-06-16 Paul Eggert <eggert@cs.ucla.edu>
2948
dd3482fe
PE
2949 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
2950 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
2951 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
2952
393d71f3 2953 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
2954 * fileio.c (Finsert_file_contents):
2955 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
2956 Remove the old (too-loose) buffer overflow checks.
2957 They weren't needed, since make_gap checks for buffer overflow.
2958 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
2959 The old code merely checked for Emacs fixnum overflow, and relied
2960 on undefined (wraparound) behavior. The new code avoids undefined
2961 behavior, and also checks for ptrdiff_t and/or size_t overflow.
2962
2e6813b0 2963 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
2964 Tune. Don't use wider integers than needed. Don't use alloca.
2965 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 2966
599a9e4f
PE
2967 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
2968
99561444
PE
2969 * insdel.c, lisp.h (buffer_overflow): New function.
2970 (insert_from_buffer_1, replace_range, replace_range_2):
2971 * insdel.c (make_gap_larger):
2972 * editfns.c (Finsert_char):
2973 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
2974
28177add
PE
2975 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
2976
e69dafad
PE
29772011-06-15 Paul Eggert <eggert@cs.ucla.edu>
2978
a7af7fde 2979 Integer overflow and signedness fixes (Bug#8873).
ff672d2c 2980
b1c46f02
PE
2981 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
2982 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
2983
e69dafad
PE
2984 * fileio.c: Don't assume EMACS_INT fits in off_t.
2985 (emacs_lseek): New static function.
2986 (Finsert_file_contents, Fwrite_region): Use it.
2987 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
2988
566684ea
PE
2989 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
2990
e6966cd6
PE
2991 * fns.c: Don't overflow int when computing a list length.
2992 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
2993 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
2994 truncation on 64-bit hosts. Check for QUIT every
2995 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
2996 faster and is responsive enough.
2997 (Flength): Report an error instead of overflowing an integer.
2998 (Fsafe_length): Return a float if the value is not representable
2999 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 3000 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 3001 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 3002
dd0b0efb
PE
3003 * alloc.c: Check that resized vectors' lengths fit in fixnums.
3004 (header_size, word_size): New constants.
3005 (allocate_vectorlike): Don't check size overflow here.
3006 (allocate_vector): Check it here instead, since this is the only
3007 caller of allocate_vectorlike that could cause overflow.
3008 Check that the new vector's length is representable as a fixnum.
3009
86fe5cfe
PE
3010 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
3011 The previous code was bogus. For example, next_almost_prime (32)
3012 returned 39, which is undesirable as it is a multiple of 3; and
3013 next_almost_prime (24) returned 25, which is a multiple of 5 so
3014 why was the code bothering to check for multiples of 7?
3015
80e88859
PE
3016 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
3017
4a2f0ad6
PE
3018 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
3019
f66c7cf8
PE
3020 Variadic C functions now count arguments with ptrdiff_t.
3021 This partly undoes my 2011-03-30 change, which replaced int with size_t.
3022 Back then I didn't know that the Emacs coding style prefers signed int.
3023 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
3024 were being counted with int, which may truncate counts on 64-bit
3025 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
3026 * lisp.h (struct Lisp_Subr.function.aMANY)
3027 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
3028 Arg counts are now ptrdiff_t, not size_t.
3029 All variadic functions and their callers changed accordingly.
3030 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
3031 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
3032 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
3033 * callint.c (Fcall_interactively): Check arg count for overflow,
3034 to avoid potential buffer overrun. Use signed char, not 'int',
3035 for 'varies' array, so that we needn't bother to check its size
3036 calculation for overflow.
3037 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
3038 * eval.c (apply_lambda):
3039 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
3040 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
3041 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
3042
a1759b76
PE
3043 * callint.c (Fcall_interactively): Don't use index var as event count.
3044
d96be9fc
PE
3045 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
3046 * mem-limits.h (SIZE): Remove; no longer used.
3047
a690a978 3048 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 3049
578c21e6
PE
3050 Remove unnecessary casts.
3051 * xterm.c (x_term_init):
3052 * xfns.c (x_set_border_pixel):
3053 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
3054 These aren't needed now that we assume ANSI C.
3055
96f53c6c
PE
3056 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
3057 It's more likely to cause problems (due to unsigned overflow)
3058 than to cure them.
3059
83c77d31
PE
3060 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
3061
ee2079f1
PE
3062 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
3063
6da65536
PE
3064 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
3065
7147c4a4
PE
3066 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
3067
193e32d9
PE
3068 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
3069
e5533da6
PE
3070 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
3071
9910e595
PE
3072 GLYPH_CODE_FACE returns EMACS_INT, not int.
3073 * dispextern.h (merge_faces):
3074 * xfaces.c (merge_faces):
01103c44
PE
3075 * xdisp.c (get_next_display_element, next_element_from_display_vector):
3076 Don't assume EMACS_INT fits in int.
9910e595 3077
2638320e
PE
3078 * character.h (CHAR_VALID_P): Remove unused parameter.
3079 * fontset.c, lisp.h, xdisp.c: All uses changed.
3080
045eb8d9
PE
3081 * editfns.c (Ftranslate_region_internal): Omit redundant test.
3082
c1f134b5
PE
3083 * fns.c (concat): Minor tuning based on overflow analysis.
3084 This doesn't fix any bugs. Use int to hold character, instead
3085 of constantly refetching from Emacs object. Use XFASTINT, not
3086 XINT, for value known to be a character. Don't bother comparing
3087 a single byte to 0400, as it's always less.
3088
395fcb93 3089 * floatfns.c (Fexpt):
327eeec8
PE
3090 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
3091
abbd3d23
PE
3092 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
3093 for characters.
3094
684a03ef
PE
3095 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
3096
0fed43f3
PE
3097 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
3098 Without this fix, on a 64-bit host (aset S 0 4294967386) would
3099 incorrectly succeed when S was a string, because 4294967386 was
3100 truncated before it was used.
3101
8fd02eb7
PE
3102 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
3103 Otherwise, an out-of-range integer could cause undefined behavior
3104 on a 64-bit host.
3105
f8c86b69
PE
3106 * composite.c: Use int, not EMACS_INT, for characters.
3107 (fill_gstring_body, composition_compute_stop_pos): Use int, not
3108 EMACS_INT, for values that are known to be in character range.
3109 This doesn't fix any bugs but is the usual style inside Emacs and
3110 may generate better code on 32-bit machines.
3111
34206dd2
PE
3112 Make sure a 64-bit char is never passed to ENCODE_CHAR.
3113 This is for reasons similar to the recent CHAR_STRING fix.
3114 * charset.c (Fencode_char): Check that character arg is actually
3115 a character. Pass an int to ENCODE_CHAR.
3116 * charset.h (ENCODE_CHAR): Verify that the character argument is no
3117 wider than 'int', as a compile-time check to prevent future regressions
3118 in this area.
3119
c5958d4c 3120 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
3121
3122 Make sure a 64-bit char is never passed to CHAR_STRING.
3123 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
3124 by silently ignoring the top 32 bits, allowing some values
3125 that were far too large to be valid characters.
3126 * character.h: Include <verify.h>.
3127 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
3128 arguments are no wider than unsigned, as a compile-time check
3129 to prevent future regressions in this area.
3130 * data.c (Faset):
01103c44 3131 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
3132 (Fsubst_char_in_region):
3133 * fns.c (concat):
3134 * xdisp.c (decode_mode_spec_coding):
3135 Adjust to CHAR_STRING's new requirement.
3136 * editfns.c (Finsert_char, Fsubst_char_in_region):
3137 * fns.c (concat): Check that character args are actually
3138 characters. Without this test, these functions did the wrong
3139 thing with wildly out-of-range values on 64-bit hosts.
3140
d37ca623
PE
3141 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
3142 These casts should not be needed on 32-bit hosts, either.
3143 * keyboard.c (read_char):
3144 * lread.c (Fload): Remove casts to unsigned.
3145
ea204efb
PE
3146 * lisp.h (UNSIGNED_CMP): New macro.
3147 This fixes comparison bugs on 64-bit hosts.
3148 (ASCII_CHAR_P): Use it.
3149 * casefiddle.c (casify_object):
01103c44 3150 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
3151 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
3152 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
3153 * dispextern.h (FACE_FROM_ID):
3154 * keyboard.c (read_char): Use UNSIGNED_CMP.
3155
41cb286c
PE
3156 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
3157 not to EMACS_INT, to avoid GCC warning.
3158
4a1b9832
PE
3159 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
3160
55daad71
PE
3161 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
3162 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
3163 isn't needed on 32-bit machines.
8f95c75c 3164
01103c44
PE
3165 * buffer.c (Fgenerate_new_buffer_name):
3166 Use EMACS_INT for count, not int.
0ceccced 3167 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
3168
3169 * data.c (Qcompiled_function): Now static.
3170
c6f072e7
PE
3171 * window.c (window_body_lines): Now static.
3172
20ce5912
PE
3173 * image.c (gif_load): Rename local to avoid shadowing.
3174
9c4c5f81
PE
3175 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
3176 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
3177 * alloc.c (make_save_value): Integer argument is now of type
3178 ptrdiff_t, not int.
3179 (mark_object): Use ptrdiff_t, not int.
3180 * lisp.h (pD): New macro.
3181 * print.c (print_object): Use it.
3182
c0c5c8ae
PE
3183 * alloc.c: Use EMACS_INT, not int, to count objects.
3184 (total_conses, total_markers, total_symbols, total_vector_size)
3185 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
3186 (total_free_floats, total_floats, total_free_intervals)
3187 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
3188 Now EMACS_INT, not int. All uses changed.
3189 (Fgarbage_collect): Compute overall total using a double, so that
3190 integer overflow is less likely to be a problem. Check for overflow
3191 when converting back to an integer.
5a25e253
PE
3192 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
3193 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
3194 These were 'int' variables that could overflow on 64-bit hosts;
3195 they were never used, so remove them instead of repairing them.
211a0b2a 3196 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
3197 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
3198 Previously, this ceilinged at INT_MAX, but that doesn't work on
3199 64-bit machines.
e46bb31a 3200 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 3201
c78baabf 3202 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 3203 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
3204 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
3205 when a (possibly-narrower) signed value would do just as well.
3206 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 3207
c9d624c6
PE
3208 * alloc.c: Catch some string size overflows that we were missing.
3209 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
3210 for convenience in STRING_BYTES_MAX.
3211 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
3212 The definition here is exact; the one in lisp.h was approximate.
3213 (allocate_string_data): Check for string overflow. This catches
3214 some instances we weren't catching before. Also, it catches
3215 size_t overflow on (unusual) hosts where SIZE_MAX <= min
3216 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
3217 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 3218
c9d624c6
PE
3219 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
3220 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 3221 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 3222
353032ce
PE
3223 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
3224
2bccce07
PE
3225 * alloc.c (Fmake_string): Check for out-of-range init.
3226
0ac30604
SM
32272011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
3228
3229 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
3230
c195f2de
JD
32312011-06-14 Jan Djärv <jan.h.d@swipnet.se>
3232
3233 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
3234 xg_get_default_scrollbar_width.
3235
3236 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
3237 (int_gtk_range_get_value): Move to the scroll bar part of the file.
3238 (style_changed_cb): Call update_theme_scrollbar_width and call
3239 x_set_scroll_bar_default_width and xg_frame_set_char_size for
3240 all frames (Bug#8505).
3241 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
3242 Call gtk_window_set_resizable if HAVE_GTK3.
3243 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
3244 and height if HAVE_GTK3 (Bug#8505).
3245 (scroll_bar_width_for_theme): New variable.
3246 (update_theme_scrollbar_width): New function.
3247 (xg_get_default_scrollbar_width): Move code to
3248 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
3249 (xg_initialize): Call update_theme_scrollbar_width.
3250
3251 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
3252
3253 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
3254
e10ac9f1
MR
32552011-06-12 Martin Rudalics <rudalics@gmx.at>
3256
3257 * frame.c (make_frame): Call other_buffer_safely instead of
3258 other_buffer.
3259
3260 * window.c (temp_output_buffer_show): Call display_buffer with
3261 second argument Vtemp_buffer_show_specifiers and reset latter
3262 immediately after the call.
3263 (Vtemp_buffer_show_specifiers): New variable.
3264 (auto_window_vscroll_p, next_screen_context_lines)
3265 (Vscroll_preserve_screen_position): Remove leading asterisks from
3266 doc-strings.
3267
2d3c217e 32682011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 3269
7b7f97e8 3270 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
3271 * buffer.c (Qclone_number): Remove for now, as it's unused.
3272 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
3273 (record_buffer): Remove unused local.
3274 * frame.c (other_visible_frames, frame_buffer_list): Now static.
3275 (set_frame_buffer_list): Remove; unused.
3276 * frame.h (other_visible_frames): Remove decl.
3277 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
3278 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
3279 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
3280 if HAVE_GPM.
3281 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
3282 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
3283 Define only if HAVE_GPM.
3284 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
3285 (update_hints_inhibit): Remove; never set. All uses removed.
3286 * widgetprv.h (emacsFrameClassRec): Remove decl.
3287 * window.c (delete_deletable_window): Now returns void, since it
3288 wasn't returning anything.
3289 (compare_window_configurations): Remove unused locals.
3290 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
3291 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
3292 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
3293 the same widths as pointers. This follows up on the 2011-05-06 patch.
3294 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
3295 * xterm.h: Likewise.
3296 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
3297
1384b89e
JB
32982011-06-12 Juanma Barranquero <lekktu@gmail.com>
3299
3300 * makefile.w32-in: Update dependencies.
3301 (LISP_H): Add lib/intprops.h.
3302
1100a63c
CY
33032011-06-11 Chong Yidong <cyd@stupidchicken.com>
3304
3305 * image.c (gif_load): Add animation frame delay to the metadata.
3306 (syms_of_image): Use DEFSYM. New symbol `delay'.
3307
6198ccd0
MR
33082011-06-11 Martin Rudalics <rudalics@gmx.at>
3309
3310 * window.c (delete_deletable_window): Re-add.
3311 (Fset_window_configuration): Rewrite to handle dead buffers and
3312 consequently deletable windows.
3313 (window_tree, Fwindow_tree): Remove. Supply functionality in
3314 window.el.
3315 (compare_window_configurations): Simplify code.
3316
b6e3633c
AS
33172011-06-11 Andreas Schwab <schwab@linux-m68k.org>
3318
1ab0dee5
AS
3319 * image.c (imagemagick_load_image): Fix type mismatch.
3320 (Fimagemagick_types): Likewise.
3321
b6e3633c
AS
3322 * window.h (replace_buffer_in_windows): Declare.
3323
9397e56f
MR
33242011-06-11 Martin Rudalics <rudalics@gmx.at>
3325
3326 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
3327 Qclone_number. Remove external declaration of Qdelete_window.
3328 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
3329 code.
640c8776
SM
3330 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
3331 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
3332 (Fother_buffer): Rewrite doc-string. Major rewrite for new
3333 buffer list implementation.
3334 (other_buffer_safely): New function.
3335 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
3336 calls to replace_buffer_in_windows and
3337 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
3338 if allowed.
3339 (record_buffer): Inhibit quitting and rewrite using quittable
3340 functions. Run Qbuffer_list_update_hook if allowed.
3341 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
3342 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
3343 Move switch-to-buffer to window.el.
9397e56f
MR
3344 (bury-buffer): Move to window.el.
3345 (Vbuffer_list_update_hook): New variable.
3346
3347 * lisp.h (other_buffer_safely): Add prototype in buffer.c
3348 section.
3349
3350 * window.h (resize_frame_windows): Move up in code.
3351 (Fwindow_frame): Remove EXFUN.
3352 (replace_buffer_in_all_windows): Remove prototype.
3353 (replace_buffer_in_windows_safely): Add prototype.
3354
3355 * window.c: Declare Qdelete_window static again. Move down
3356 declaration of select_count.
3357 (Fnext_window, Fprevious_window): Rewrite doc-strings.
3358 (Fother_window): Move to window.el.
3359 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
3360 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
3361 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
3362 window.el.
3363 (replace_buffer_in_windows): Implement by calling
3364 Qreplace_buffer_in_windows.
3365 (replace_buffer_in_all_windows): Remove with some functionality
3366 moved into replace_buffer_in_windows_safely.
3367 (replace_buffer_in_windows_safely): New function.
3368 (select_window_norecord, select_frame_norecord): Move in front
3369 of run_window_configuration_change_hook. Remove now obsolete
3370 declarations.
640c8776
SM
3371 (Fset_window_buffer): Rewrite doc-string.
3372 Call Qrecord_window_buffer.
9397e56f
MR
3373 (keys_of_window): Move binding for other-window to window.el.
3374
b50691aa
CY
33752011-06-11 Chong Yidong <cyd@stupidchicken.com>
3376
3377 * dispextern.h (struct image): Replace data member, whose int_val
3378 and ptr_val fields were not used by anything, with a single
3379 lisp_val object.
3380
3381 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
3382 (gif_clear_image, gif_load, imagemagick_load_image)
3383 (gs_clear_image, gs_load): Callers changed.
3384
3f754b86
PE
33852011-06-10 Paul Eggert <eggert@cs.ucla.edu>
3386
cca69397
PE
3387 * buffer.h: Include <time.h>, for time_t.
3388 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
3389
109e28d0
PE
3390 Fix minor problems found by static checking.
3391
60737f02
PE
3392 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
3393
4b66faf3
PE
3394 Make identifiers static if they are not used in other modules.
3395 * data.c (Qcompiled_function, Qframe, Qvector):
3396 * image.c (QimageMagick, Qsvg):
3397 * minibuf.c (Qmetadata):
3398 * window.c (resize_window_check, resize_root_window): Now static.
3399 * window.h (resize_window_check, resize_root_window): Remove decls.
3400
109e28d0
PE
3401 * window.c (window_deletion_count, delete_deletable_window):
3402 Remove; unused.
46a4ce9e
PE
3403 (window_body_lines): Now static.
3404 (Fdelete_other_windows_internal): Mark vars as initialized.
3405 Make sure 'resize_failed' is initialized.
3406 (run_window_configuration_change_hook): Rename local to avoid shadowing.
3407 (resize_window_apply): Remove unused local.
3408 * window.h (delete_deletable_window): Remove decl.
3409
109e28d0 3410 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
3411 (imagemagick_load_image): Fix pointer signedness problem by changing
3412 last arg from unsigned char * to char *. All uses changed.
3413 Also, fix a local for similar reasons.
3414 Remove unused locals. Remove locals to avoid shadowing.
3415 (fn_rsvg_handle_free): Remove; unused.
3416 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 3417 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 3418
3f754b86
PE
3419 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
3420
2547adb1
CY
34212011-06-10 Chong Yidong <cyd@stupidchicken.com>
3422
3423 * image.c (gif_load): Fix omitted cast error introduced by
3424 2011-06-06 change.
3425
2c8e37d4
MR
34262011-06-10 Martin Rudalics <rudalics@gmx.at>
3427
3428 * window.h (resize_proportionally, orig_total_lines)
3429 (orig_top_line): Remove from window structure.
3430 (set_window_height, set_window_width, change_window_heights)
3431 (Fdelete_window): Remove prototypes.
3432 (resize_frame_windows): Remove duplicate declaration.
3433
440a42e3
EZ
34342011-06-10 Eli Zaretskii <eliz@gnu.org>
3435
3436 * window.h (resize_frame_windows, resize_window_check)
3437 (delete_deletable_window, resize_root_window)
3438 (resize_frame_windows): Declare prototypes.
3439
3440 * window.c (resize_window_apply): Make definition be "static" to
3441 match the prototype.
3442
562dd5e9
MR
34432011-06-10 Martin Rudalics <rudalics@gmx.at>
3444
3445 * window.c: Remove declarations of Qwindow_size_fixed,
3446 window_min_size_1, window_min_size_2, window_min_size,
3447 size_window, window_fixed_size_p, enlarge_window, delete_window.
3448 Remove static from declaration of Qdelete_window, it's
3449 temporarily needed by Fbury_buffer.
3450 (replace_window): Don't assign orig_top_line and
3451 orig_total_lines.
3452 (Fdelete_window, delete_window): Remove. Window deletion is
3453 handled by window.el.
640c8776
SM
3454 (window_loop): Remove DELETE_OTHER_WINDOWS case.
3455 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
3456 (Fdelete_other_windows): Remove. Deleting other windows is
3457 handled by window.el.
3458 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
3459 handled in window.el.
3460 (window_min_size_2, window_min_size_1, window_min_size): Remove.
3461 Window minimum sizes are handled in window.el.
3462 (shrink_windows, size_window, set_window_height)
3463 (set_window_width, change_window_heights, window_height)
3464 (window_width, CURBEG, CURSIZE, enlarge_window)
3465 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
3466 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
3467 handled in window.el.
3468 (make_dummy_parent): Rename to make_parent_window and give it a
3469 second argument horflag.
3470 (make_window): Don't set resize_proportionally any more.
3471 (Fsplit_window): Remove. Windows are split in window.el.
3472 (save_restore_action, save_restore_orig_size)
3473 (shrink_window_lowest_first, save_restore_orig_size): Remove.
3474 Resize mini windows in window.el.
3475 (grow_mini_window, shrink_mini_window): Implement by calling
3476 Qresize_root_window_vertically, resize_window_check and
3477 resize_window_apply.
640c8776
SM
3478 (saved_window, Fset_window_configuration, save_window_save):
3479 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
3480 resize_proportionally.
3481 (window_min_height, window_min_width): Move to window.el.
3482 (keys_of_window): Move bindings for delete-other-windows,
3483 split-window, delete-window and enlarge-window to window.el.
3484
3485 * buffer.c: Temporarily extern Qdelete_window.
3486 (Fbury_buffer): Temporarily call Qdelete_window instead of
3487 Fdelete_window (Fbury_buffer will move to window.el soon).
3488
3489 * frame.c (set_menu_bar_lines_1): Remove code handling
3490 orig_top_line and orig_total_lines.
3491
3492 * dispnew.c (adjust_frame_glyphs_initially): Don't use
3493 set_window_height but set heights directly.
3494 (change_frame_size_1): Use resize_frame_windows.
3495
3496 * xdisp.c (init_xdisp): Don't use set_window_height but set
3497 heights directly.
3498
640c8776
SM
3499 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
3500 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
3501 run_window_configuration_change_hook.
3502
3503 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
3504 instead of change_window_heights and run
3505 run_window_configuration_change_hook.
3506
1a13852e
MR
35072011-06-09 Martin Rudalics <rudalics@gmx.at>
3508
3509 * window.c (replace_window): Rename second argument REPLACEMENT to
3510 NEW. New third argument SETFLAG. Rewrite.
3511 (delete_window, make_dummy_parent): Call replace_window with
3512 third argument 1.
3513 (window_list_1): Move down in code.
3514 (run_window_configuration_change_hook): Move set_buffer part
3515 before select_frame_norecord part in order to unwind correctly.
3516 Rename count1 to count.
3517 (recombine_windows, delete_deletable_window, resize_root_window)
3518 (Fdelete_other_windows_internal)
3519 (Frun_window_configuration_change_hook, make_parent_window)
3520 (resize_window_check, resize_window_apply, Fresize_window_apply)
3521 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
3522 (Fdelete_window_internal, Fresize_mini_window_internal):
3523 New functions.
1a13852e
MR
3524 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
3525
f3d1777e
MR
35262011-06-08 Martin Rudalics <rudalics@gmx.at>
3527
496e208e
MR
3528 * window.h (window): Add some new members to window structure -
3529 normal_lines, normal_cols, new_total, new_normal, clone_number,
3530 splits, nest, prev_buffers, next_buffers.
3531 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 3532 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 3533
f3d1777e
MR
3534 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
3535 Remove.
496e208e
MR
3536 (make_dummy_parent): Set new members of windows structure.
3537 (make_window): Move down in code. Handle new members of window
3538 structure.
3539 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
3540 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
3541 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
3542 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
3543 (Fset_window_next_buffers, Fset_window_clone_number):
3544 New functions.
496e208e
MR
3545 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
3546 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
3547 Doc-string fixes.
3548 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
3549 Argument WINDOW can be now internal window too.
3550 (Fwindow_use_time): Move up in code.
3551 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
3552 Rewrite doc-string.
3553 (Fset_window_configuration, saved_window)
3554 (Fcurrent_window_configuration, save_window_save): Handle new
3555 members of window structure.
b9e809c2
MR
3556 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
3557 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
3558 (syms_of_window): New Lisp objects Qrecord_window_buffer,
3559 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
3560 Qget_mru_window, Qresize_root_window,
3561 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
3562 Qauto_buffer_name; staticpro them.
f3d1777e 3563
abde8f8c
MR
35642011-06-07 Martin Rudalics <rudalics@gmx.at>
3565
3566 * window.c (Fwindow_total_size, Fwindow_left_column)
3567 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
3568 (Fwindow_list_1): New functions.
3569 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
3570 (Fwindow_width, Fscroll_left, Fscroll_right):
3571 Use window_body_cols instead of window_box_text_cols.
3572 (delete_window, Fset_window_configuration):
3573 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
3574 (delete_all_subwindows): Take a window as argument and not a
3575 structure. Rewrite.
190b47e6
MR
3576 (window_loop): Remove handling of GET_LRU_WINDOW and
3577 GET_LARGEST_WINDOW.
3578 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
3579
3580 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
3581 window_box_text_cols. delete_all_subwindows now takes a
3582 Lisp_Object as argument.
abde8f8c 3583
640c8776
SM
3584 * indent.c (compute_motion, Fcompute_motion):
3585 Use window_body_cols instead of window_box_text_cols.
abde8f8c 3586
fa8a67e6
MR
3587 * frame.c (delete_frame): Call delete_all_subwindows with root
3588 window as argument.
3589
a54e3482
DC
35902011-06-07 Daniel Colascione <dan.colascione@gmail.com>
3591
3592 * fns.c (Fputhash): Document return value.
3593
60002bf5
CY
35942011-06-06 Chong Yidong <cyd@stupidchicken.com>
3595
3596 * image.c (gif_load): Implement gif89a spec "no disposal" method.
3597
0c671da6 35982011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 3599
b862a52a 3600 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 3601
be44ca6c
PE
3602 Check for overflow when converting integer to cons and back.
3603 * charset.c (Fdefine_charset_internal, Fdecode_char):
3604 Use cons_to_unsigned to catch overflow.
3605 (Fencode_char): Use INTEGER_TO_CONS.
3606 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
3607 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
3608 * data.c (long_to_cons, cons_to_long): Remove.
3609 (cons_to_unsigned, cons_to_signed): New functions.
3610 These signal an error for invalid or out-of-range values.
3611 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
3612 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
3613 * font.c (Ffont_variation_glyphs):
3614 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
3615 * lisp.h: Include <intprops.h>.
3616 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
3617 (cons_to_signed, cons_to_unsigned): New decls.
3618 (long_to_cons, cons_to_long): Remove decls.
3619 * undo.c (record_first_change): Use INTEGER_TO_CONS.
3620 (Fprimitive_undo): Use CONS_TO_INTEGER.
3621 * xfns.c (Fx_window_property): Likewise.
3622 * xselect.c: Include <limits.h>.
3623 (x_own_selection, selection_data_to_lisp_data):
3624 Use INTEGER_TO_CONS.
3625 (x_handle_selection_request, x_handle_selection_clear)
3626 (x_get_foreign_selection, Fx_disown_selection_internal)
3627 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
3628 (lisp_data_to_selection_data): Use cons_to_unsigned.
3629 (x_fill_property_data): Use cons_to_signed.
3630 Report values out of range.
3631
d1f3d2af
PE
3632 Check for buffer and string overflow more precisely.
3633 * buffer.h (BUF_BYTES_MAX): New macro.
3634 * lisp.h (STRING_BYTES_MAX): New macro.
3635 * alloc.c (Fmake_string):
3636 * character.c (string_escape_byte8):
3637 * coding.c (coding_alloc_by_realloc):
3638 * doprnt.c (doprnt):
3639 * editfns.c (Fformat):
3640 * eval.c (verror):
3641 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
3642 since they may not be the same number.
3643 * editfns.c (Finsert_char):
3644 * fileio.c (Finsert_file_contents):
3645 Likewise for BUF_BYTES_MAX.
3646
dd52fcea
PE
3647 * image.c: Use ptrdiff_t, not int, for sizes.
3648 (slurp_file): Switch from int to ptrdiff_t.
3649 All uses changed.
3650 (slurp_file): Check that file size fits in both size_t (for
3651 malloc) and ptrdiff_t (for sanity and safety).
3652
7f9bbdbb
PE
3653 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
3654 if b->modtime has its maximal value.
3655
dfe18f82
PE
3656 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
3657
84acfcf0
PE
3658 Don't assume time_t can fit into int.
3659 * buffer.h (struct buffer.modtime): Now time_t, not int.
3660 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
3661 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
3662
ccd9a01a
PE
3663 Minor fixes for signed vs unsigned integers.
3664 * character.h (MAYBE_UNIFY_CHAR):
3665 * charset.c (maybe_unify_char):
3666 * keyboard.c (read_char, reorder_modifiers):
3667 XINT -> XFASTINT, since the integer must be nonnegative.
3668 * ftfont.c (ftfont_spec_pattern):
3669 * keymap.c (access_keymap, silly_event_symbol_error):
3670 XUINT -> XFASTINT, since the integer must be nonnegative.
3671 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
3672 since it makes no difference and we prefer signed.
3673 * keyboard.c (record_char): Use XUINT when all the neighbors do.
3674 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
3675 nonnegative.
3676
d6d100dd
SM
36772011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
3678
3679 * window.h (Fwindow_frame): Declare.
3680
2b6148e4
PE
36812011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3682
3683 * alloc.c: Simplify handling of large-request failures (Bug#8800).
3684 (SPARE_MEMORY): Always define.
3685 (LARGE_REQUEST): Remove.
3686 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
3687
f230ecc9
MR
36882011-06-06 Martin Rudalics <rudalics@gmx.at>
3689
727e958e
MR
3690 * lisp.h: Move EXFUNS for Fframe_root_window,
3691 Fframe_first_window and Fset_frame_selected_window to window.h.
3692
3693 * window.h: Move EXFUNS for Fframe_root_window,
3694 Fframe_first_window and Fset_frame_selected_window here from
3695 lisp.h.
3696
3697 * frame.c (Fwindow_frame, Fframe_first_window)
3698 (Fframe_root_window, Fframe_selected_window)
3699 (Fset_frame_selected_window): Move to window.c.
3700 (Factive_minibuffer_window): Move to minibuf.c.
3701 (Fother_visible_frames_p): New function.
3702
3703 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
3704
f230ecc9
MR
3705 * window.c (decode_window, decode_any_window): Move up in code.
3706 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
3707 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
3708 (Fwindow_buffer): Move up and rewrite doc-string.
3709 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
3710 (Fwindow_prev): New functions.
727e958e
MR
3711 (Fwindow_frame): Move here from frame.c. Accept any window as
3712 argument.
3713 (Fframe_root_window, Fframe_first_window)
3714 (Fframe_selected_window): Move here from frame.c. Accept frame
3715 or arbitrary window as argument. Update doc-strings.
3716 (Fminibuffer_window): Move up in code.
3717 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
3718 (Fset_frame_selected_window): Move here from frame.c.
3719 Marginal rewrite.
727e958e
MR
3720 (Fselected_window, select_window, Fselect_window): Move up in
3721 code. Minor doc-string fixes.
f230ecc9 3722
4d09bcf6
PE
37232011-06-06 Paul Eggert <eggert@cs.ucla.edu>
3724
3725 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
3726 Do not assume that spare memory exists; that assumption is valid
3727 only if SYSTEM_MALLOC.
3728 (LARGE_REQUEST): New macro, so that the issue of large requests
3729 is separated from the issue of spare memory.
3730
810928a2
AS
37312011-06-05 Andreas Schwab <schwab@linux-m68k.org>
3732
172418ad
AS
3733 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
3734 format. (Bug#8806)
3735
43f862f7
AS
3736 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
3737
810928a2
AS
3738 * xfns.c (x_set_scroll_bar_default_width): Move declarations
3739 before statements.
3740
a059fe24
JD
37412011-06-05 Jan Djärv <jan.h.d@swipnet.se>
3742
3743 * gtkutil.c (xg_get_default_scrollbar_width): New function.
3744
3745 * gtkutil.h: Declare xg_get_default_scrollbar_width.
3746
3747 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
3748 min width by calling x_set_scroll_bar_default_width (Bug#8505).
3749
989bf368
JB
37502011-06-05 Juanma Barranquero <lekktu@gmail.com>
3751
3752 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
3753
4b80f674
CY
37542011-06-04 Chong Yidong <cyd@stupidchicken.com>
3755
3756 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
3757 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
3758 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
3759 New error handlers.
4b80f674
CY
3760 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
3761 Obey Vx_select_enable_clipboard_manager. Catch errors in
3762 x_clipboard_manager_save (Bug#8779).
3763 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 3764 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 3765
99a33b77 37662011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
3767
3768 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
3769
99a33b77 37702011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
3771
3772 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
3773 in the current matrix if keep_current_p is non-zero.
3774
8264569d
EZ
37752011-06-04 Eli Zaretskii <eliz@gnu.org>
3776
3777 * bidi.c (bidi_level_of_next_char): Fix last change.
3778
57f97249
EZ
37792011-06-03 Eli Zaretskii <eliz@gnu.org>
3780
fec2107c 3781 Support bidi reordering of text covered by display properties.
57f97249 3782
fec2107c
EZ
3783 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
3784 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
3785 (bidi_cache_search, bidi_cache_iterator_state)
3786 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
3787 (bidi_level_of_next_char, bidi_move_to_visually_next):
3788 Support character positions inside a run of characters covered by a
fec2107c
EZ
3789 display string.
3790 (bidi_paragraph_init, bidi_resolve_explicit_1)
3791 (bidi_level_of_next_char): Call bidi_fetch_char and
3792 bidi_fetch_char_advance instead of FETCH_CHAR and
3793 FETCH_CHAR_ADVANCE.
3794 (bidi_init_it): Initialize new members.
3795 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
3796 definitions.
3797 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
3798 instead of using explicit *_CHAR codes.
d6d100dd
SM
3799 (bidi_resolve_explicit, bidi_resolve_weak):
3800 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
3801 bidirectional text is supported only in multibyte buffers.
3802 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
3803 it to initialize the frame_window_p member of struct bidi_it.
3804 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
3805 (bidi_resolve_explicit, bidi_resolve_weak)
3806 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
3807 bidi_it->nchars is non-positive.
3808 (bidi_level_of_next_char): Don't try to lookup the cache for the
3809 next/previous character if nothing is cached there yet, or if we
3810 were just reseat()'ed to a new position.
c40e2fb2 3811
0e14fe90
EZ
3812 * xdisp.c (set_cursor_from_row): Set start and stop points
3813 according to the row's direction when priming the loop that looks
3814 for the glyph on which to display cursor.
3815 (single_display_spec_intangible_p): Function deleted.
3816 (display_prop_intangible_p): Reimplement to call
3817 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
3818 Accept 3 additional arguments needed by handle_display_spec.
3819 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
3820 values: lists, `(when COND...)' forms, etc.
3821 (single_display_spec_string_p): Support property values that are
3822 lists with the argument STRING its top-level element.
3823 (display_prop_string_p): Fix the condition for processing a
3824 property that is a list to be consistent with handle_display_spec.
fec2107c 3825 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
3826 last portion of handle_display_prop.
3827 (compute_display_string_pos): Accept additional argument
3828 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
3829 value of a `display' property is a "replacing spec".
3830 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
3831 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
3832 the display property, but just return a value indicating whether
3833 the display property will replace the characters it covers.
3834 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
3835 frame_window_p members of struct bidi_it.
d6d100dd
SM
3836 (compute_display_string_pos, compute_display_string_end):
3837 New functions.
fec2107c
EZ
3838 (push_it): Accept second argument POSITION, where pop_it should
3839 jump to continue iteration.
3840 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 3841
fec2107c
EZ
3842 * keyboard.c (adjust_point_for_property): Adjust the call to
3843 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
3844
3845 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
3846 (bidi_init_it): Update prototypes.
3847 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
3848 (compute_display_string_pos, compute_display_string_end):
3849 Declare prototypes.
fec2107c
EZ
3850 (struct bidi_it): New members nchars and disp_pos. ch_len is now
3851 EMACS_INT.
fc6f18ce 3852
40087514 38532011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 3854
57f53182
PE
3855 Malloc failure behavior now depends on size of allocation.
3856 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
3857 * lisp.h: Change signatures accordingly.
3858 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
3859 All callers changed. (Bug#8762)
3860
3861 * gnutls.c: Use Emacs's memory allocators.
3862 Without this change, the gnutls library would invoke malloc etc.
3863 directly, which causes problems on non-SYNC_INPUT hosts, and which
3864 runs afoul of improving memory_full behavior. (Bug#8761)
3865 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
3866 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
3867 xfree instead of the default malloc, realloc, free.
3868 (Fgnutls_boot): No need to check for memory allocation failure,
3869 since xmalloc does that for us.
3870
ac32cd99 3871 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
3872 * category.c (hash_get_category_set):
3873 * ccl.c (ccl_driver):
3874 * charset.c (Fdefine_charset_internal):
3875 * charset.h (struct charset.hash_index):
3876 * composite.c (get_composition_id, gstring_lookup_cache)
3877 (composition_gstring_put_cache):
3878 * composite.h (struct composition.hash_index):
3879 * dispextern.h (struct image.hash):
3880 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
3881 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
3882 (hashfn_equal, hashfn_user_defined, make_hash_table)
3883 (maybe_resize_hash_table, hash_lookup, hash_put)
3884 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
3885 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
3886 (Fsxhash, Fgethash, Fputhash, Fmaphash):
3887 * image.c (make_image, search_image_cache, lookup_image)
3888 (xpm_put_color_table_h):
3889 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 3890 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 3891 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 3892 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
3893 * alloc.c (allocate_vectorlike):
3894 Check for overflow in vector size calculations.
3895 * ccl.c (ccl_driver):
3896 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
3897 * fns.c, image.c: Remove unnecessary static decls that would otherwise
3898 need to be updated by these changes.
40087514
PE
3899 * fns.c (make_hash_table, maybe_resize_hash_table):
3900 Check for integer overflow with large hash tables.
0de4bb68
PE
3901 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
3902 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
3903 (SXHASH_REDUCE): New macro.
3904 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
3905 Use it instead of discarding useful hash info with large hash values.
3906 (sxhash_float): New function.
3907 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
3908 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
3909 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
3910 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
3911 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
3912 Adjust signatures to match updated version of code.
3913 (consing_since_gc): Now EMACS_INT, since a single hash table can
3914 use more than INT_MAX bytes.
3915
698d32e2
DN
39162011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
3917
3918 Make it possible to build with GCC-4.6+ -O2 -flto.
3919
3920 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
3921
fd6fa53f
SM
39222011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
3923
3924 * minibuf.c (get_minibuffer, read_minibuf_unwind):
3925 Call minibuffer-inactive-mode.
3926
864db017
JB
39272011-05-31 Juanma Barranquero <lekktu@gmail.com>
3928
3929 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
3930 Update dependencies.
3931
2ad0baf4
DN
39322011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3933
3934 * data.c (init_data): Remove code for UTS, this system is not
3935 supported anymore.
3936
4fcc2638
DN
39372011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3938
3939 Don't force ./temacs to start in terminal mode.
3940
3941 * frame.c (make_initial_frame): Initialize faces in all cases, not
3942 only when CANNOT_DUMP is defined.
3943 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
3944
c56e0fd5
DN
39452011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3946
3947 * dispnew.c (add_window_display_history): Use const for the string
3948 pointer. Remove declaration, not needed.
3949
333d54da 39502011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 3951
55d4c1b2 3952 Use 'inline', not 'INLINE'.
333d54da 3953 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
3954 * alloc.c, fontset.c (INLINE): Remove.
3955 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
3956 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
3957 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
3958 * gmalloc.c (register_heapinfo): Use inline unconditionally.
3959 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
3960
738db178
DN
39612011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
3962
3963 Make it possible to run ./temacs.
3964
3965 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
3966 syms_of_callproc does the same thing. Remove test for
3967 "initialized", do it in the caller.
3968 * emacs.c (main): Avoid calling set_initial_environment when dumping.
3969
620c53a6
SM
39702011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
3971
3972 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
3973 (read_minibuf): Use get_minibuffer.
3974 (syms_of_minibuf): Use DEFSYM.
3975 (Qmetadata): New var.
3976 * data.c (Qbuffer): Don't make it static.
3977 (syms_of_data): Use DEFSYM.
3978
e003a292
PE
39792011-05-31 Paul Eggert <eggert@cs.ucla.edu>
3980
3981 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
3982 (CCL_CODE_MIN): New macro.
3983
ed008a6d
PE
39842011-05-30 Paul Eggert <eggert@cs.ucla.edu>
3985
3687c2ef
PE
3986 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
3987
ed008a6d
PE
3988 * eval.c (Qdebug): Now static.
3989 * lisp.h (Qdebug): Remove decl. This reverts a part of the
3990 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
3991 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
3992
d66c4c7c
CY
39932011-05-29 Chong Yidong <cyd@stupidchicken.com>
3994
3995 * image.c: Various fixes to ImageMagick code comments.
3996 (Fimagemagick_types): Doc fix.
3997
5fbc2025
PE
39982011-05-29 Paul Eggert <eggert@cs.ucla.edu>
3999
0196f88a
PE
4000 Minor fixes prompted by GCC 4.6.0 warnings.
4001
4002 * xselect.c (converted_selections, conversion_fail_tag): Now static.
4003
5fbc2025
PE
4004 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
4005 (x_clipboard_manager_save_all): Move extern decl to ...
4006 * xterm.h: ... here, so that it can be checked for consistency.
4007
1dd3c2d9
CY
40082011-05-29 Chong Yidong <cyd@stupidchicken.com>
4009
4010 * xselect.c (x_clipboard_manager_save_frame)
4011 (x_clipboard_manager_save_all): New functions.
4012 (Fx_clipboard_manager_save): Lisp function deleted.
4013
4014 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
4015 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
4016
4017 * xterm.h: Update prototype.
4018
5ba6571d
WX
40192011-05-28 William Xu <william.xwl@gmail.com>
4020
4021 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
4022 exiting (Bug#8239).
4023
3eaff834
JM
40242011-05-28 Jim Meyering <meyering@redhat.com>
4025
e1900994 4026 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
4027 * fns.c (to_uchar): Define.
4028 (crypto_hash_function): Use it to convert some newly-signed
4029 variables to unsigned, to avoid sign-extension bugs. For example,
4030 without this change, (md5 "truc") would evaluate to
4031 45723a2aff78ff4fff7fff1114760e62 rather than the expected
4032 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 4033 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 4034
0f6990a7
PE
40352011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4036
4037 Integer overflow fixes.
c8a9ca5a 4038
08686060
PE
4039 * dbusbind.c: Serial number integer overflow fixes.
4040 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
4041 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
4042 to hold a serial number that is too large for a fixnum.
4043 (Fdbus_method_return_internal, Fdbus_method_error_internal):
4044 Check for serial numbers out of range. Decode any serial number
59568bf0 4045 that was so large that it became a float. (Bug#8722)
08686060 4046
2d1fc3c7
PE
4047 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
4048 (Fdbus_call_method, Fdbus_call_method_asynchronously):
4049 Use XFASTINT rather than XUINT when numbers are nonnegative.
4050 (xd_append_arg, Fdbus_method_return_internal):
4051 (Fdbus_method_error_internal): Likewise. Also, for unsigned
4052 arguments, check that Lisp number is nonnegative, rather than
59568bf0 4053 silently wrapping negative numbers around. (Bug#8722)
30217ff0 4054 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 4055 (Bug#8722)
2d1fc3c7 4056
c8a9ca5a
PE
4057 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
4058
519e1d69
PE
4059 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
4060
30569699
PE
4061 ccl: add integer overflow checks
4062 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
4063 (IN_INT_RANGE): New macros.
4064 (ccl_driver): Use them to check for integer overflow when
4065 decoding a CCL program. Many of the new checks are whether XINT (x)
4066 fits in int; it doesn't always, on 64-bit hosts. The new version
4067 doesn't catch all possible integer overflows, but it's an
847044ea 4068 improvement. (Bug#8719)
30569699 4069
c11285dc
PE
4070 * alloc.c (make_event_array): Use XINT, not XUINT.
4071 There's no need for unsigned here.
4072
fdccd48e
PE
4073 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
4074 This follows up to the 2011-05-06 change that substituted uintptr_t
4075 for EMACS_INT. This case wasn't caught back then.
4076
37910ab2
PE
4077 Rework Fformat to avoid integer overflow issues.
4078 * editfns.c: Include <float.h> unconditionally, as it's everywhere
4079 now (part of C89). Include <verify.h>.
4080 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
4081 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
4082 (Fformat): Avoid the prepass trying to compute sizes; it was only
4083 approximate and thus did not catch overflow reliably. Instead, walk
4084 through the format just once, formatting and computing sizes as we go,
4085 checking for integer overflow at every step, and allocating a larger
4086 buffer as needed. Keep track separately whether the format is
4087 multibyte. Keep only the most-recently calculated precision, rather
4088 than them all. Record whether each argument has been converted to
4089 string. Use EMACS_INT, not int, for byte and char and arg counts.
4090 Support field widths and precisions larger than INT_MAX. Avoid
4091 sprintf's undefined behavior with conversion specifications such as %#d
4092 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
4093 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
4094 formatting out-of-range floating point numbers with int
9173deec 4095 formats. (Bug#8668)
37910ab2 4096
2e6578fb
PE
4097 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
4098
0ae6bdee
PE
4099 * data.c: Avoid integer truncation in expressions involving floats.
4100 * data.c: Include <intprops.h>.
4101 (arith_driver): When there's an integer overflow in an expression
4102 involving floating point, convert the integers to floating point
4103 so that the resulting value does not suffer from catastrophic
4104 integer truncation. For example, on a 64-bit host (* 4
4105 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
4106 Do not rely on undefined behavior after integer overflow.
4107
de883a70
PE
4108 merge count_size_as_multibyte, parse_str_to_multibyte
4109 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 4110 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
4111 Check for integer overflow.
4112 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
4113 since it's now a duplicate of the other. This is more of
4114 a character than a buffer op, so better that it's in character.c.
4115 * fns.c, print.c: Adjust to above changes.
4116
2ff916cb
PE
41172011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
4118
4119 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
4120
f1b54466
PE
41212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
4122
fb1ac845
PE
4123 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4124 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
4125 (x_clipboard_manager_save): Now static.
4126 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
4127
f1b54466
PE
4128 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
4129 (crypto_hash_function): Now static.
4130 Fix pointer signedness problems. Avoid unnecessary initializations.
4131
a9f737ee
CY
41322011-05-27 Chong Yidong <cyd@stupidchicken.com>
4133
4134 * termhooks.h (Vselection_alist): Make it terminal-local.
4135
4136 * terminal.c (create_terminal): Initialize it.
4137
4138 * xselect.c: Support for clipboard managers.
4139 (Vselection_alist): Move to termhooks.h as terminal-local var.
4140 (LOCAL_SELECTION): New macro.
4141 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
4142 (symbol_to_x_atom): Remove gratuitous arg.
4143 (x_handle_selection_request, lisp_data_to_selection_data)
4144 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
4145 (x_own_selection, x_get_local_selection, x_convert_selection):
4146 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
4147 (some_frame_on_display): Delete unused function.
4148 (Fx_own_selection_internal, Fx_get_selection_internal)
4149 (Fx_disown_selection_internal, Fx_selection_owner_p)
4150 (Fx_selection_exists_p): New optional frame arg.
4151 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
4152 (x_handle_selection_clear): Don't treat other terminals with the
4153 same keyboard specially. Use the terminal-local Vselection_alist.
4154 (x_clear_frame_selections): Use Frun_hook_with_args.
4155
4156 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
4157
4158 * xterm.h: Add support for those atoms.
4159
e067f0c1
CY
41602011-05-26 Chong Yidong <cyd@stupidchicken.com>
4161
4162 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
4163 (converted_selections, conversion_fail_tag): New global variables.
4164 (x_selection_request_lisp_error): Free the above.
4165 (x_get_local_selection): Remove unnecessary code.
4166 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
4167 of converted selections stored in converted_selections.
4168 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
4169 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
4170 (x_convert_selection): New function.
4171 (x_handle_selection_event): Simplify.
4172 (x_get_foreign_selection): Don't ignore incoming requests while
4173 waiting for an answer; this will fail when we implement
4174 SAVE_TARGETS, and seems unnecessary anyway.
4175 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
4176 (Vx_sent_selection_functions): Doc fix.
4177
0f4aebc0
LL
41782011-05-26 Leo Liu <sdl.web@gmail.com>
4179
4180 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
4181
e61124cd
YM
41822011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4183
4184 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
4185
4186 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
4187 for fringe update if it has periodic bitmap.
ac389d0c 4188 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
4189 and fringe_bitmap_periodic_p.
4190
4191 * fringe.c (get_fringe_bitmap_data): New function.
4192 (draw_fringe_bitmap_1, update_window_fringes): Use it.
4193 (update_window_fringes): Record periodicity of fringe bitmap in glyph
4194 row. Mark glyph row for fringe update if periodicity changed.
4195
4196 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
4197 for fringe update unless it has periodic bitmap.
4198
f16d9837
KH
41992011-05-25 Kenichi Handa <handa@m17n.org>
4200
4201 * xdisp.c (get_next_display_element): Set correct it->face_id for
4202 a static composition.
4203
e1b90ef6
LL
42042011-05-24 Leo Liu <sdl.web@gmail.com>
4205
4206 * deps.mk (fns.o):
4207 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
4208
4209 * fns.c (crypto_hash_function, Fsha1): New function.
4210 (Fmd5): Use crypto_hash_function.
4211 (syms_of_fns): Add Ssha1.
4212
7400048f
PE
42132011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4214
4215 * gnutls.c: Remove unused macros.
4216 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
4217 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
4218 Remove macros that are defined and never used.
4219 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
4220
abb71cf4
CY
42212011-05-22 Chong Yidong <cyd@stupidchicken.com>
4222
4223 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
4224 (Fx_get_selection_internal): Minor cleanup.
4225 (Fx_own_selection_internal): Rename arguments for consistency with
4226 select.el.
4227
6307db39
PE
42282011-05-22 Paul Eggert <eggert@cs.ucla.edu>
4229
4230 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
4231
f3d4e0a4
CY
42322011-05-22 Chong Yidong <cyd@stupidchicken.com>
4233
4234 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
4235
4d8ade89
YM
42362011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
4237
4238 * dispnew.c (scrolling_window): Don't exclude the case that the
4239 last enabled row in the desired matrix touches the bottom boundary.
4240
32078c8d
GM
42412011-05-21 Glenn Morris <rgm@gnu.org>
4242
4243 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
4244 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
4245 and add some more files.
32078c8d 4246
7285dc67
EZ
42472011-05-20 Eli Zaretskii <eliz@gnu.org>
4248
4249 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
4250 report_file_error introduced by the change from 2011-05-07.
4251
89d1bd22
PE
42522011-05-20 Paul Eggert <eggert@cs.ucla.edu>
4253
4254 * systime.h (Time): Define only if emacs is defined.
4255 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
4256 where the include path doesn't have X11/X.h by default. See
4257 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
4258
e23640bb 42592011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
4260
4261 * composite.c (find_automatic_composition): Fix previous change.
4262
b9704ad9
GM
42632011-05-20 Glenn Morris <rgm@gnu.org>
4264
4265 * lisp.mk: New file, split from Makefile.in.
4266 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
4267 (shortlisp): Remove.
4268 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
4269
4a720484
GM
42702011-05-19 Glenn Morris <rgm@gnu.org>
4271
4272 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
4273 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
4274 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
4275 (lisp): Set the order to that of loadup.el.
4276 (shortlisp): Make it a copy of $lisp.
4277 (SOME_MACHINE_LISP): Remove.
4278 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
4279 Use just $shortlisp, not $SOME_MACHINE_LISP too.
4280
a28d4396
KH
42812011-05-18 Kenichi Handa <handa@m17n.org>
4282
4283 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
4284 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
4285 (find_automatic_composition): Mostly rewrite for efficiency.
4286
a2b1fa8e
JB
42872011-05-18 Juanma Barranquero <lekktu@gmail.com>
4288
4289 * makefile.w32-in: Update dependencies.
4290
8e1f5610
CS
42912011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
4292
4293 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 4294 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 4295
7025ee00 42962011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 4297
cdfa6eab
PE
4298 Fix some integer overflow issues, such as string length overflow.
4299
06d6db33
PE
4300 * insdel.c (count_size_as_multibyte): Check for string overflow.
4301
2b4560a8
PE
4302 * character.c (lisp_string_width): Check for string overflow.
4303 Use EMACS_INT, not int, for string indexes and lengths; in
4304 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
4305 the resulting string length overflows an EMACS_INT; instead,
4306 report a string overflow if no precision given. When checking for
4307 precision exhaustion, use a check that cannot possibly have
4308 integer overflow. (Bug#8675)
4309 * character.h (lisp_string_width): Adjust to new signature.
4310
cb93f9be
PE
4311 * alloc.c (string_overflow): New function.
4312 (Fmake_string): Use it. This doesn't change behavior, but saves
4313 a few bytes and will simplify future changes.
4314 * character.c (string_escape_byte8): Likewise.
4315 * lisp.h (string_overflow): New decl.
4316
1a1f3366
PE
4317 Fixups, following up to the user-interface timestamp change.
4318 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
4319 for UI timestamps, instead of unsigned long.
9fbd6841
PE
4320 * msdos.c (mouse_get_pos): Likewise.
4321 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
4322 * w32gui.h (Time): Define by including "systime.h" rather than by
4323 declaring it ourselves. (Bug#8664)
4324
d4e3e4d3
PE
4325 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
4326 * image.c (clear_image_cache): Likewise.
4327
f6a24d19
PE
4328 * term.c (term_mouse_position): Don't assume time_t wraparound.
4329
08dc5ae6
PE
4330 Be more systematic about user-interface timestamps.
4331 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
4332 and sometimes 'EMACS_UINT', to represent these timestamps.
4333 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
4334 This makes the code easier to follow, and makes it easier to catch
4335 integer overflow bugs such as Bug#8664.
4336 * frame.c (Fmouse_position, Fmouse_pixel_position):
4337 Use Time, not unsigned long, for user-interface timestamps.
4338 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
4339 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
4340 * keyboard.h (last_event_timestamp): Likewise.
4341 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
4342 * menu.h (xmenu_show): Likewise.
4343 * term.c (term_mouse_position): Likewise.
4344 * termhooks.h (struct input_event.timestamp): Likewise.
4345 (struct terminal.mouse_position_hook): Likewise.
4346 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
4347 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
4348 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
4349 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
4350 what it was before.
4351 * menu.h, termhooks.h: Include "systime.h", for Time.
4352
8e55734a
PE
4353 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
4354 Don't assume that the difference between two unsigned long values
4355 can fit into an integer. At this point, we know button_down_time
4356 <= event->timestamp, so the difference must be nonnegative, so
4357 there's no need to cast the result if double-click-time is
4358 nonnegative, as it should be; check that it's nonnegative, just in
4359 case. This bug is triggered when events are more than 2**31 ms
86db42d2 4360 apart (about 25 days). (Bug#8664)
8e55734a 4361
841f1b75 4362 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 4363 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 4364
3e26f69c
PE
4365 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
4366 that always fit in int. Use a sentinel instead of a counter, to
4367 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
4368 * frame.h (struct frame): Use int for menu_bar_items_used
4369 instead of EMACS_INT, since it always fits in int.
3e26f69c 4370
5cc152c0
PE
4371 * menu.c (grow_menu_items): Check for int overflow.
4372
d89eb65e
PE
4373 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
4374
5235bd3e
PE
4375 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
4376 Before, the code was not consistent. These values cannot exceed
4377 2**31 - 1 so there's no need to make them unsigned.
4378 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
4379 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
4380 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
4381 as modifiers.
4382 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
4383
bc827e23
PE
4384 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
4385 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
4386 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
4387 presumably because the widths might not match.
4388
78eb494e
PE
4389 * window.c (size_window): Avoid needless test at loop start.
4390
04f2d78b
CB
43912011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
4392
4393 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
4394
d2fc7e3d 43952011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
4396
4397 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
4398
d2fc7e3d 43992011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
4400
4401 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
4402 `width' to `bar_area_x' and `bar_area_width', respectively.
4403 (x_scroll_run): Take account of fringe background extension.
4404
04f2d78b
CB
4405 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
4406 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
4407 `bar_area_width', respectively.
4408 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
4409 background extension.
4410
79b70037
GM
44112011-05-10 Jim Meyering <meyering@redhat.com>
4412
4413 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
4414
2f142cc5
JB
44152011-05-10 Juanma Barranquero <lekktu@gmail.com>
4416
4417 * image.c (Finit_image_library): Return t for built-in image types,
4418 like pbm and xbm. (Bug#8640)
4419
57679c86
AS
44202011-05-09 Andreas Schwab <schwab@linux-m68k.org>
4421
4422 * w32menu.c (set_frame_menubar): Fix submenu allocation.
4423
888c9e86
EZ
44242011-05-07 Eli Zaretskii <eliz@gnu.org>
4425
b0512a1d
EZ
4426 * w32console.c (Fset_screen_color): Doc fix.
4427 (Fget_screen_color): New function.
4428 (syms_of_ntterm): Defsubr it.
4429
7285dc67
EZ
4430 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
4431 unlink the temporary file if Fcall_process didn't create it in the
4432 first place.
4433 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
4434 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
4435 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
4436 cue to call_process_cleanup not to close that handle.
4437
4d3fcc8e
BK
44382011-05-07 Ben Key <bkey76@gmail.com>
4439
4440 * makefile.w32-in: The bootstrap-temacs rule now makes use of
4441 one of two shell specific rules, either bootstrap-temacs-CMD or
4442 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
4443 to the previous implementation of the bootstrap-temacs rule.
4444 The bootstrap-temacs-CMD rule is similar to the previous
4445 implementation of the bootstrap-temacs rule except that it
4446 makes use of the ESC_CFLAGS variable instead of the CFLAGS
4447 variable.
4448
4449 These changes, along with some changes to nt/configure.bat,
4450 nt/gmake.defs, and nt/nmake.defs, are required to extend my
4451 earlier fix to add support for --cflags and --ldflags options
4452 that include quotes so that it works whether make uses cmd or
4453 sh as the shell.
4454
b4289b64
MA
44552011-05-06 Michael Albinus <michael.albinus@gmx.de>
4456
4457 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
4458 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
4459 is a constant.
4460 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
4461 a string. Handle both cases.
4462 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
4463 (Fdbus_register_method): Use Qinvalid_function.
4464
af4c0e28
JB
44652011-05-06 Juanma Barranquero <lekktu@gmail.com>
4466
4467 * makefile.w32-in: Update dependencies.
4468 (LISP_H): Add inttypes.h and stdin.h.
4469 (PROCESS_H): Add unistd.h.
4470
c51453d9
EZ
44712011-05-06 Eli Zaretskii <eliz@gnu.org>
4472
4473 * lread.c: Include limits.h (fixes the MS-Windows build broken by
4474 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
4475
8ff0ac3c 44762011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 4477
4c4b566b
PE
4478 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
4479
aab2b9b5
PE
4480 * term.c (vfatal): Remove stray call to va_end.
4481 It's not needed and the C Standard doesn't allow it here anyway.
4482
c378da0b
PE
4483 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
4484 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
4485
288b08c7
PE
4486 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
4487 bytes.
4488
e3601888
PE
4489 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
4490
db6c0e74
PE
4491 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
4492
dd5963ea
PE
4493 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
4494
88c9450f
PE
4495 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
4496
2f9442b8
PE
4497 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
4498
c032b5f8
PE
4499 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
4500 * charset.c (Fdefine_charset_internal): Don't initialize
4501 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 4502 32-bit int (Bug#8600).
a108c10b
PE
4503
4504 * lread.c (read_integer): Be more consistent with string-to-number.
4505 Use string_to_number to do the actual conversion; this avoids
4506 rounding errors and fixes some other screwups. Without this fix,
4507 for example, #x1fffffffffffffff was misread as -2305843009213693952.
4508 (digit_to_number): Move earlier, for benefit of read_integer.
4509 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 4510 not a digit in any supported base. (Bug#8602)
a108c10b 4511
ad5f9eea
PE
4512 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
4513
aec1708a
PE
4514 * dispnew.c (scrolling_window): Return 1 if we scrolled,
4515 to match comment at start of function. This also removes a
4516 GCC warning about overflow in a 32+64-bit port.
4517
47be4ab5
PE
4518 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
4519
371cac43
PE
4520 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
4521 Reported by Stefan Monnier in
4522 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
4523 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4524 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 4525
d01a7826
PE
4526 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
4527 (EMACS_UINTPTR): Likewise, with uintptr_t.
4528
7fd47d5c
PE
4529 * lisp.h: Prefer 64-bit EMACS_INT if available.
4530 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
4531 on 32-bit hosts that have 64-bit int, so that they can access
4532 large files.
122b0c86
PE
4533 However, temporarily disable this change unless the temporary
4534 symbol WIDE_EMACS_INT is defined.
7fd47d5c 4535
8727937b
PE
4536 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
4537
8ac068ac
PE
4538 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
4539 This removes an assumption that EMACS_INT and long are the same
4540 width as pointers. The assumption is true for Emacs porting targets
4541 now, but we want to make other targets possible.
4542 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
4543 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
4544 In the rest of the code, change types of integers that hold casted
4545 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
4546 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
4547 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
4548 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
4549 No need to cast type when ORing.
4550 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
4551 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
4552 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
4553 assume EMACS_INT is the same width as char *.
4554 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
4555 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
4556 Remove no-longer-needed casts.
4557 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
4558 (xg_tool_bar_help_callback, xg_make_tool_item):
4559 Use EMACS_INTPTR to hold an integer
4560 that will be cast to void *; this can avoid a GCC warning
4561 if EMACS_INT is not the same width as void *.
4562 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
4563 * xdisp.c (display_echo_area_1, resize_mini_window_1):
4564 (current_message_1, set_message_1):
4565 Use a local to convert to proper width without a cast.
4566 * xmenu.c (dialog_selection_callback): Likewise.
4567
ede49d71
PE
4568 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
4569 Also, don't assume VALBITS / RAND_BITS is less than 5,
4570 and don't rely on undefined behavior when shifting a 1 left into
4571 the sign bit.
4572 * lisp.h (get_random): Change signature to match.
4573
2f30ecd0
PE
4574 * lread.c (hash_string): Use size_t, not int, for hash computation.
4575 Normally we prefer signed values; but hashing is special, because
4576 it's better to use unsigned division on hash table sizes so that
4577 the remainder is nonnegative. Also, size_t is the natural width
4578 for hashing into memory. The previous code used 'int', which doesn't
4579 retain enough info to hash well into very large tables.
4580 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
4581
2a866e7b
PE
4582 * dbusbind.c: Don't possibly lose pointer info when converting.
4583 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
4584 Use XPNTR rather than XHASH, so that the high-order bits of
4585 the pointer aren't lost when converting through void *.
4586
51639eac
PE
4587 * eval.c (Fautoload): Don't double-shift a pointer.
4588
92394119
PE
4589 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
4590
dbdb9a7c
JB
45912011-05-06 Juanma Barranquero <lekktu@gmail.com>
4592
4593 * gnutls.c (DEF_GNUTLS_FN):
4594 * image.c (DEF_IMGLIB_FN): Make function pointers static.
4595
db7a0b4f
AS
45962011-05-05 Andreas Schwab <schwab@linux-m68k.org>
4597
4598 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
4599 marker. (Bug#8610)
4600
f7ff1b0f 46012011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
4602
4603 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
4604 New version that can reserve upto 2GB of heap space.
4605
f7ff1b0f 46062011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
4607
4608 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
4609
639c109b
TZ
46102011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
4611
4612 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
4613 `gnutls_certificate_set_x509_key_file'.
4614
d2127135
JB
46152011-05-05 Juanma Barranquero <lekktu@gmail.com>
4616
4617 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
4618 Update dependencies.
4619
e968f4f3
JB
46202011-05-04 Juanma Barranquero <lekktu@gmail.com>
4621
4622 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
4623 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
4624 Remove unused parameter `fildes'.
4625 * process.c (read_process_output, send_process): Don't pass it.
4626
84d358f0
JB
46272011-05-04 Juanma Barranquero <lekktu@gmail.com>
4628
4629 Fix previous change: the library cache is defined in w32.c.
4630 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
4631 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
4632
0898ca10
JB
46332011-05-04 Juanma Barranquero <lekktu@gmail.com>
4634
4635 Implement dynamic loading of GnuTLS on Windows.
4636
4637 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
4638 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
4639 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4640 Declare.
4641
4642 * gnutls.c (Qgnutls_dll): Define.
4643 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
4644 (gnutls_*): Declare function pointers.
4645 (init_gnutls_functions): New function to initialize function pointers.
4646 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
4647 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
4648 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
4649 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
4650 (emacs_gnutls_write, emacs_gnutls_read)
4651 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
4652 (Fgnutls_available_p): New function.
4653 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
4654 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
4655 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
4656
4657 * image.c: Include w32.h.
4658 (Vimage_type_cache): Delete.
4659 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
4660 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
4661 (w32_delayed_load): Move to w32.c.
4662
4663 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
4664
4665 * w32.c (QCloaded_from, Vlibrary_cache): Define.
4666 (w32_delayed_load): Move from image.c. When loading a library, record
4667 its filename in the :loaded-from property of the library id.
4668 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
4669 Initialize and staticpro them.
4670 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
4671
4672 * process.c: Include lisp.h before w32.h, not after.
4673 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
4674 instead of gnutls_record_check_pending.
4675
4676 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
4677
ff4de4aa
TZ
46782011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
4679
4680 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
4681 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
4682 as passed in.
4683
abe95abb
JD
46842011-05-03 Jan Djärv <jan.h.d@swipnet.se>
4685
4686 * xterm.c (x_set_frame_alpha): Do not set property on anything
4687 else than FRAME_X_OUTER_WINDOW (Bug#8608).
4688
e16e55d4
JB
46892011-05-02 Juanma Barranquero <lekktu@gmail.com>
4690
4691 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
4692
bafcf6a5
JB
46932011-05-02 Juanma Barranquero <lekktu@gmail.com>
4694
4695 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
4696 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
4697 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
4698 (gnutls_global_initialized, Qgnutls_bootprop_priority)
4699 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
4700 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
4701 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
4702 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
4703 (Qgnutls_bootprop_callbacks_verify): Make static.
4704
e7a6747f
AS
47052011-05-01 Andreas Schwab <schwab@linux-m68k.org>
4706
19ed11ba
AS
4707 * callproc.c: Indentation fixup.
4708
e7a6747f 4709 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
4710 (wait_for_termination, interruptible_wait_for_termination):
4711 Move after wait_for_termination_1.
e7a6747f 4712
1ef14cb4
LMI
47132011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
4714
4715 * sysdep.c (interruptible_wait_for_termination): New function
4716 which is like wait_for_termination, but allows keyboard
4717 interruptions.
4718
4719 * callproc.c (Fcall_process): Add (:file "file") as an option for
4720 the STDOUT buffer.
4721 (Fcall_process_region): Ditto.
4722
330d880c
EZ
47232011-04-30 Eli Zaretskii <eliz@gnu.org>
4724
8db90b73
EZ
4725 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
4726 rather than `XVECTOR (FOO)->size'.
4727
330d880c
EZ
4728 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
4729 inttypes.h, as a gnulib replacement is used if it not available in
4730 system headers.
4731
15cbd324
EZ
47322011-04-21 Eli Zaretskii <eliz@gnu.org>
4733
4734 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
4735 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
4736 of MOST_POSITIVE_FIXNUM. (Bug#8528)
4737
4738 * coding.c (coding_alloc_by_realloc): Error out if destination
4739 will grow beyond MOST_POSITIVE_FIXNUM.
4740 (decode_coding_emacs_mule): Abort if there isn't enough place in
4741 charbuf for the composition carryover bytes. Reserve an extra
4742 space for up to 2 characters produced in a loop.
4743 (decode_coding_iso_2022): Abort if there isn't enough place in
4744 charbuf for the composition carryover bytes.
4745
47462011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 4747
ae940cca
EZ
4748 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
4749 aborting when %lld or %lll format is passed.
4750 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
4751 %llo or %llx format is passed. (Bug#8545)
4752
03ab8921
EZ
4753 * window.c (window_scroll_line_based): Use a marker instead of
4754 simple variables to record original value of point. (Bug#7952)
4755
afda1437
EZ
4756 * doprnt.c (doprnt): Fix the case where a multibyte sequence
4757 produced by %s or %c overflows available buffer space. (Bug#8545)
4758
f76dee0c
PE
47592011-04-28 Paul Eggert <eggert@cs.ucla.edu>
4760
4761 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 4762 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 4763
fdc5744d
JB
47642011-04-28 Juanma Barranquero <lekktu@gmail.com>
4765
4766 * w32.c (init_environment): Warn about defaulting HOME to C:\.
4767
638f053a
JB
47682011-04-28 Juanma Barranquero <lekktu@gmail.com>
4769
4770 * keyboard.c (Qdelayed_warnings_hook): Define.
4771 (command_loop_1): Run `delayed-warnings-hook'
4772 if Vdelayed_warnings_list is non-nil.
4773 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
4774 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
4775
d178f871
EZ
47762011-04-28 Eli Zaretskii <eliz@gnu.org>
4777
4778 * doprnt.c (doprnt): Don't return value smaller than the buffer
4779 size if the message was truncated. (Bug#8545).
4780
b124fd93
JB
47812011-04-28 Juanma Barranquero <lekktu@gmail.com>
4782
4783 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
4784 (Fx_window_property): #if-0 the whole functions, not just the bodies.
4785
e810457d
PE
47862011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4787
4788 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
4789
ea51cceb
JB
47902011-04-27 Juanma Barranquero <lekktu@gmail.com>
4791
4792 * makefile.w32-in: Update dependencies.
4793
94dcfacf
EZ
47942011-04-27 Eli Zaretskii <eliz@gnu.org>
4795
4796 Improve `doprnt' and its usage. (Bug#8545)
4797 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
4798 `format_end'. Remove support for %l as a conversion specifier.
4799 Don't use xrealloc. Improve diagnostics when the %l size modifier
4800 is used. Update the commentary.
4801
4802 * eval.c (verror): Simplify calculation of size_t.
4803
4804 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
4805 messages.
4806
f61f41d7
PE
48072011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
4808
4809 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
4810 change.
4811
96fb4434
PE
48122011-04-27 Paul Eggert <eggert@cs.ucla.edu>
4813
4814 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
4815 This makes this file independent of the recent pseudovector change.
4816
671875da 48172011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 4818
69e9b5a3
PE
4819 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
4820
b5f869a7 4821 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 4822 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 4823 Remove unused local.
c8926152 4824 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 4825
841a1577 4826 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
4827 GCC 4.6.0 optimizes based on type-based alias analysis.
4828 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
4829 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
4830 != &v->size, and therefore "v->size = 1; b->size = 2; return
4831 v->size;" must therefore return 1. This assumption is incorrect
4832 for Emacs, since it type-puns struct Lisp_Vector * with many other
4833 types. To fix this problem, this patch adds a new type struct
f904488f 4834 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
4835 and pseudovectors, and helps optimizing compilers not get fooled
4836 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
4837 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
4838 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
4839 the size member.
eab3844f
PE
4840 (XSETPVECTYPE): Rewrite in terms of new macro.
4841 (XSETPVECTYPESIZE): New macro, specifying both type and size.
4842 This is a bit clearer, and further avoids the possibility of
4843 undesirable aliasing.
4844 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 4845 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
4846 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
4847 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
4848 (ASIZE): Now uses header.size rather than size.
4849 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
4850 to avoid the hassle of writing XVECTOR (foo)->header.size.
4851 (struct vectorlike_header): New type.
eab3844f
PE
4852 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
4853 object, to help avoid aliasing.
4854 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
4855 (SUBRP): Likewise, since Lisp_Subr is a special case.
4856 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
4857 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
4858 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 4859 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
4860 changed to be "header.size" and "header.next".
4861 * buffer.h (struct buffer): Likewise.
4862 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
4863 * frame.h (struct frame): Likewise.
4864 * process.h (struct Lisp_Process): Likewise.
4865 * termhooks.h (struct terminal): Likewise.
4866 * window.c (struct save_window_data, struct saved_window): Likewise.
4867 * window.h (struct window): Likewise.
4868 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
4869 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
4870 * buffer.c (init_buffer_once): Likewise.
4871 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
4872 special case.
4873 * process.c (Fformat_network_address): Use local var for size,
4874 for brevity.
4875
0df1eac5
PE
4876 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
4877
847ab9d1 4878 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
4879 * data.c (atof): Remove decl; no longer used or needed.
4880 (digit_to_number): Move to lread.c.
4881 (Fstring_to_number): Use new string_to_number function, to be
4882 consistent with how the Lisp reader treats infinities and NaNs.
4883 Do not assume that floating-point numbers represent EMACS_INT
4884 without losing information; this is not true on most 64-bit hosts.
4885 Avoid double-rounding errors, by insisting on integers when
4886 parsing non-base-10 numbers, as the documentation specifies.
4887 * lisp.h (string_to_number): New decl, replacing ...
4888 (isfloat_string): Remove.
bc0a5c13 4889 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 4890 (read1): Do not accept +. and -. as integers; this
452f4150
PE
4891 appears to have been a coding error. Similarly, do not accept
4892 strings like +-1e0 as floating point numbers. Do not report
4893 overflow for integer overflows unless the base is not 10 which
4894 means we have no simple and reliable way to continue.
4895 Break out the floating-point parsing into a new
4896 function string_to_number, so that Fstring_to_number parses
4897 floating point numbers consistently with the Lisp reader.
04f2d78b 4898 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
4899 (E_CHAR, EXP_INT): Remove, replacing with ...
4900 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
4901 (string_to_number): New function, replacing isfloat_string.
4902 This function checks for valid syntax and produces the resulting
4903 Lisp float number too. Rework it so that string-to-number
bc0a5c13 4904 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
4905 so that overflow for non-base-10 numbers is reported only when
4906 there's no portable and simple way to convert to floating point.
452f4150 4907
67769ffc
PE
4908 * textprop.c (set_text_properties_1): Rewrite for clarity,
4909 and to avoid GCC warning about integer overflow.
4910
c20db43f
PE
4911 * intervals.h (struct interval): Use EMACS_INT for members
4912 where EMACS_UINT might cause problems. See
4913 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
4914 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
4915 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
4916 All uses changed.
37aa2f85
PE
4917 (offset_intervals): Tell GCC not to worry about length overflow
4918 when negating a negative length.
c20db43f 4919
2538aa2f
PE
4920 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
4921 (overrun_check_free): Likewise.
4922
f2d3008d
PE
4923 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
4924 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
4925 word size.
4926
ec8df744
PE
4927 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4928 (gnutls_make_error): Rename local to avoid shadowing.
4929 (gnutls_emacs_global_deinit): ifdef out; not used.
4930 (Fgnutls_boot): Use const for pointer to readonly storage.
4931 Comment out unused local. Fix pointer signedness problems.
4932
640ee02d
PE
4933 * lread.c (openp): Don't stuff size_t into an 'int'.
4934 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
4935 about possible signed overflow.
4936
6048fb2a
PE
4937 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
4938 (GDK_KEY_g): Don't define if already defined.
4939 (xg_prepare_tooltip): Avoid pointer signedness problem.
4940 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
4941
fa3c87e1
PE
4942 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
4943 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
4944
2172544b
PE
4945 * xfns.c (Fx_window_property): Simplify a bit,
4946 to make a bit faster and to avoid GCC 4.6.0 warning.
4947 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
4948
9b821a21
PE
4949 * fns.c (internal_equal): Don't assume size_t fits in int.
4950
3c616cfa
PE
4951 * alloc.c (compact_small_strings): Tighten assertion a little.
4952
c2982e87
PE
4953 Replace pEd with more-general pI, and fix some printf arg casts.
4954 * lisp.h (pI): New macro, generalizing old pEd macro to other
4955 conversion specifiers. For example, use "...%"pI"d..." rather
4956 than "...%"pEd"...".
4957 (pEd): Remove. All uses replaced with similar uses of pI.
4958 * src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h: Likewise.
4959 * alloc.c (check_pure_size): Don't overflow by converting size to int.
4960 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
4961 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
4962 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
4963 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
4964 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
4965 64-bit hosts.
4966 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
4967 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
4968 * print.c (safe_debug_print, print_object): Likewise.
4969 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
4970 to int.
6f04d126
PE
4971 Use pI instead of if-then-else-abort. Use %p to avoid casts,
4972 avoiding the 0 flag, which is not portable.
c2982e87
PE
4973 * process.c (Fmake_network_process): Use pI to avoid cast.
4974 * region-cache.c (pp_cache): Likewise.
4975 * xdisp.c (decode_mode_spec): Likewise.
4976 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
4977 behavior on 64-bit hosts with printf arg.
6f04d126 4978 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
4979 (x_stop_queuing_selection_requests): Likewise.
4980 (x_get_window_property): Don't truncate byte count to an 'int'
4981 when tracing.
0b432f21 4982
5e073ec7
PE
4983 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
4984 here, since it parses constructs like leading '-' and spaces,
4985 which are not wanted; and it overflows with large numbers.
4986 Instead, simply match F[0-9]+, which is what is wanted anyway.
4987
36372bf9
PE
4988 * alloc.c: Remove unportable assumptions about struct layout.
4989 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
4990 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
4991 (allocate_vectorlike, make_pure_vector): Use the new macros,
4992 plus offsetof, to remove unportable assumptions about struct layout.
4993 These assumptions hold on all porting targets that I know of, but
4994 they are not guaranteed, they're easy to remove, and removing them
4995 makes further changes easier.
4996
0b432f21
PE
4997 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
4998 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
4999 (string_overrun_cookie): Now const. Use initializers that
5000 don't formally overflow signed char, to avoid warnings.
000098c1
PE
5001 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
5002 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
5003 (allocate_buffer): Don't assume sizeof (struct buffer) is a
5004 multiple of sizeof (EMACS_INT); it need not be, if
5005 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 5006 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 5007
895009e1
JB
50082011-04-26 Juanma Barranquero <lekktu@gmail.com>
5009
5010 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
5011
6a7a1b0b
TZ
50122011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
5013
5014 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 5015 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
5016 Reported by Paul Eggert <eggert@cs.ucla.edu>.
5017
841a1577 50182011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
5019
5020 * lisp.h (Qdebug): List symbol.
895009e1 5021 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
5022 * keyboard.c (debug-on-event): New variable.
5023 (handle_user_signal): Break into debugger when debug-on-event
5024 matches the current signal symbol.
5025
f2d3ba6f
DN
50262011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
5027
5028 * alloc.c (check_sblock, check_string_bytes)
5029 (check_string_free_list): Convert to standard C.
5030
42ce4c63
TZ
50312011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
5032
5033 * w32.c (emacs_gnutls_push): Fix typo.
5034
825cd63c
EZ
50352011-04-25 Eli Zaretskii <eliz@gnu.org>
5036
fb11d64d
EZ
5037 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
5038 "cast to pointer from integer of different size".
5039
825cd63c
EZ
5040 Improve doprnt and its use in verror. (Bug#8545)
5041 * doprnt.c (doprnt): Document the set of format control sequences
5042 supported by the function. Use SAFE_ALLOCA instead of always
5043 using `alloca'.
5044
5045 * eval.c (verror): Don't limit the buffer size at size_max-1, that
5046 is one byte too soon. Don't use xrealloc; instead xfree and
5047 xmalloc anew.
5048
e061a11b
TZ
50492011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
5050
5051 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
5052 callbacks stage.
5053
5054 * gnutls.c: Renamed global_initialized to
5055 gnutls_global_initialized. Added internals for the
5056 :verify-hostname-error, :verify-error, and :verify-flags
5057 parameters of `gnutls-boot' and documented those parameters in the
5058 docstring. Start callback support.
9173deec
JB
5059 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
5060 unless a fatal error occurred. Call gnutls_alert_send_appropriate
5061 on error. Return error code.
e061a11b
TZ
5062 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
5063 (emacs_gnutls_read): Likewise.
5064 (Fgnutls_boot): Return handshake error code.
5065 (emacs_gnutls_handle_error): New function.
5066 (wsaerror_to_errno): Likewise.
5067
5068 * w32.h (emacs_gnutls_pull): Add prototype.
5069 (emacs_gnutls_push): Likewise.
5070
5071 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
5072 (emacs_gnutls_push): Likewise.
5073
50742011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
5075
5076 * process.c (wait_reading_process_output): Check if GnuTLS
5077 buffered some data internally if no FDs are set for TLS
5078 connections.
5079
5080 * makefile.w32-in (OBJ2): Add gnutls.$(O).
5081 (LIBS): Link to USER_LIBS.
5082 ($(BLD)/gnutls.$(0)): New target.
5083
fa6996bc
EZ
50842011-04-24 Eli Zaretskii <eliz@gnu.org>
5085
eb35682e
EZ
5086 * xdisp.c (handle_single_display_spec): Rename the
5087 display_replaced_before_p argument into display_replaced_p, to
5088 make it consistent with the commentary. Fix typos in the
5089 commentary.
5090
e2ad650c
EZ
5091 * textprop.c (syms_of_textprop): Remove dead code.
5092 (copy_text_properties): Delete obsolete commentary about an
5093 interface that was deleted long ago. Fix typos in the description
5094 of arguments.
5095
1b2de274
EZ
5096 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
5097 to changes in oldXMenu/XMenu.h from 2011-04-16.
5098 <menu_help_message, prev_menu_help_message>: Constify.
5099 (IT_menu_make_room): menu->help_text is now `const char **';
5100 adjust.
5101
5102 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
5103 to changes in oldXMenu/XMenu.h from 2011-04-16.
5104 (struct XMenu): Declare `help_text' `const char **'.
5105
5106 * xfaces.c <Qunspecified>: Make extern again.
5107
5108 * syntax.c: Include sys/types.h before including regex.h, as
5109 required by Posix.
5110
762b15be
EZ
5111 * doc.c (get_doc_string): Improve the format passed to `error'.
5112
5113 * doprnt.c (doprnt): Improve commentary.
5114
5115 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
5116
5117 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
5118 them with etags.
5119
f1052e5d
EZ
5120 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
5121 changes in globals.h immediately force recompilation.
762b15be
EZ
5122 (TAGS): Depend on $(CURDIR)/m/intel386.h and
5123 $(CURDIR)/s/ms-w32.h.
5124 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 5125
fa6996bc
EZ
5126 * character.c (Fchar_direction): Function deleted.
5127 (syms_of_character): Don't defsubr it.
5128 <char-direction-table>: Deleted.
5129
e6c3da20
EZ
51302011-04-23 Eli Zaretskii <eliz@gnu.org>
5131
5132 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
5133 * doprnt.c: Include limits.h.
5134 (SIZE_MAX): New macro.
04f2d78b
CB
5135 (doprnt): Return a size_t value. 2nd arg is now size_t.
5136 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
5137 Improve overflow protection. Support `l' modifier for integer
5138 conversions. Support %l conversion. Don't assume an EMACS_INT
5139 argument for integer conversions and for %c.
5140
5141 * lisp.h (doprnt): Restore prototype.
5142
5143 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
5144 $(SRC)/character.h.
5145
5146 * Makefile.in (base_obj): Add back doprnt.o.
5147
5148 * deps.mk (doprnt.o): Add back prerequisites.
5149 (callint.o): Depend on character.h.
5150
5151 * eval.c (internal_lisp_condition_case): Include the handler
5152 representation in the error message.
5153 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
5154 when breaking from the loop.
5155
5156 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
5157
5158 * callint.c (Fcall_interactively): When displaying error message
5159 about invalid control letter, pass the character's codepoint, not
5160 a pointer to its multibyte form. Improve display of the character
5161 in octal and display also its hex code.
5162
5163 * character.c (char_string): Use %x to display the (unsigned)
5164 codepoint of an invalid character, to avoid displaying a bogus
5165 negative value.
5166
5167 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
5168 `error', not SYMBOL_NAME itself.
5169
5170 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
5171 character arguments to `error'.
5172
5173 * charset.c (check_iso_charset_parameter): Fix incorrect argument
5174 to `error' in error message about FINAL_CHAR argument. Make sure
5175 FINAL_CHAR is a character, and use %c when it is passed as
5176 argument to `error'.
5177
4ffd0d6b 51782011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
5179
5180 * s/ms-w32.h (localtime): Redirect to sys_localtime.
5181
5182 * w32.c: Include <time.h>.
5183 (sys_localtime): New function.
5184
4ffd0d6b 51852011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
5186
5187 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
5188
4ffd0d6b 5189 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 5190
4ffd0d6b 51912011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 5192
4ffd0d6b
GM
5193 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
5194 zombies (Bug#8467).
aac0c6e3 5195
04c56954
EZ
51962011-04-19 Eli Zaretskii <eliz@gnu.org>
5197
5198 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
5199 gl_state.e_property when gl_state.object is Qt.
5200
5201 * insdel.c (make_gap_larger): Remove limitation of buffer size
5202 to <= INT_MAX.
5203
16a43933
CY
52042011-04-18 Chong Yidong <cyd@stupidchicken.com>
5205
5206 * xdisp.c (lookup_glyphless_char_display)
5207 (produce_glyphless_glyph): Handle cons cell entry in
5208 glyphless-char-display.
5209 (Vglyphless_char_display): Document it.
5210
5211 * term.c (produce_glyphless_glyph): Handle cons cell entry in
5212 glyphless-char-display.
5213
4581706e
CY
52142011-04-17 Chong Yidong <cyd@stupidchicken.com>
5215
5216 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
5217
5218 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
5219
5220 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
5221 definition for no-X builds.
5222
4887c6e2 52232011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 5224
fd35b6f9
PE
5225 Static checks with GCC 4.6.0 and non-default toolkits.
5226
5c1ccb01
PE
5227 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
5228
006c5daa
PE
5229 * process.c (keyboard_bit_set): Define only if SIGIO.
5230 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
5231 (send_process): Repair possible setjmp clobbering.
5232
efc736d3
PE
5233 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
5234
4e2fe2e6
PE
5235 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
5236
f97334a2
PE
5237 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
5238
4e75f29d
PE
5239 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
5240 Define only if needed.
5241
90efadd1
PE
5242 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
5243 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 5244 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 5245
3c647824
PE
5246 * dispextern.h (struct redisplay_interface): Rename param
5247 to avoid shadowing.
e264f262 5248 * termhooks.h (struct terminal): Likewise.
761383f4 5249 * xterm.c (xembed_send_message): Likewise.
3c647824 5250
b58c5c4a
PE
5251 * insdel.c (make_gap_smaller): Define only if
5252 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
5253
cad59032
PE
5254 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
5255 it.
5256
c339dc2e
PE
5257 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
5258 so that we aren't warned about unused symbols.
5259
91a3e27b
PE
5260 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
5261
399c71d3 5262 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 5263
8ffc96f5
PE
5264 * xfns.c (x_real_positions): Mark locals as initialized.
5265
eef9bc79
PE
5266 * xmenu.c (xmenu_show): Don't use uninitialized vars.
5267
098db9dd
PE
5268 * xterm.c: Fix problems found by static analysis with other toolkits.
5269 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
5270 (x_dispatch_event): Declare static if USE_GTK, and
5271 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 5272 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 5273 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
5274 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
5275 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 5276
eb18f6cc
PE
5277 * xmenu.c (menu_help_callback): Pointer type fixes.
5278 Use const pointers when pointing at readonly data. Avoid pointer
5279 signedness clashes.
5280 (FALSE): Remove unused macro.
5281 (update_frame_menubar): Remove unused decl.
5282
1fe72bf8
PE
5283 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
5284
60d9e1db
PE
5285 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
5286 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
5287 (single_menu_item): Rename local to avoid shadowing.
5288
39261c26
PE
5289 * keyboard.c (make_lispy_event): Remove unused local var.
5290
018c5e19
PE
5291 * frame.c, frame.h (x_get_resource_string): Bring this back, but
5292 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
5293
63d2b86e
PE
5294 * bitmaps: Change bitmaps from unsigned char back to the X11
5295 compatible char. Avoid the old compiler warnings about
5296 out-of-range initializers by using, for example, '\xab' rather
5297 than 0xab.
5298
aefd87e1
PE
5299 * xgselect.c (xgselect_initialize): Check vs interface
5300 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
5301
bf501fb9
PE
5302 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
5303
e9829fdf
PE
5304 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
5305 to read-only memory.
5306
1086c095
PE
5307 * fns.c (vector): Remove; this old hack is no longer needed.
5308
2baccd04 5309 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 5310 Remove unused var.
dde42981 5311 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 5312
72391843 5313 * xrdb.c (x_load_resources): Omit unused local.
3565b346 5314
436c16df 5315 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 5316 (x_window): Rename locals to avoid shadowing.
dc5ddd85 5317 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 5318
92bb796d 5319 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 5320 (x_term_init): Remove local to avoid shadowing.
92bb796d 5321
764430a3 5322 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
5323
5324 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
5325 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
5326
d1dfb56c
EZ
53272011-04-16 Eli Zaretskii <eliz@gnu.org>
5328
c4354cb4
EZ
5329 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
5330
d1dfb56c
EZ
5331 Fix regex.c, syntax.c and friends for buffers > 2GB.
5332 * syntax.h (struct gl_state_s): Declare character position members
5333 EMACS_INT.
5334
5335 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
5336
04f2d78b
CB
5337 * textprop.c (verify_interval_modification, interval_of):
5338 Declare arguments EMACS_INT.
d1dfb56c
EZ
5339
5340 * intervals.c (adjust_intervals_for_insertion): Declare arguments
5341 EMACS_INT.
5342
5343 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
5344
5345 * indent.c (Fvertical_motion): Local variable it_start is now
5346 EMACS_INT.
5347
5348 * regex.c (re_match, re_match_2, re_match_2_internal)
5349 (bcmp_translate, regcomp, regexec, print_double_string)
5350 (group_in_compile_stack, re_search, re_search_2, regex_compile)
5351 (re_compile_pattern, re_exec): Declare arguments and local
5352 variables `size_t' and `ssize_t' and return values `regoff_t', as
5353 appropriate.
5354 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
5355 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
5356 <compile_stack_type>: `size' and `avail' are now `size_t'.
5357
5358 * regex.h <regoff_t>: Use ssize_t, not int.
5359 (re_search, re_search_2, re_match, re_match_2): Arguments that
5360 specify buffer/string position and length are now ssize_t and
5361 size_t. Return type is regoff_t.
5362
613052cd
BK
53632011-04-16 Ben Key <bkey76@gmail.com>
5364
5365 * nsfont.m: Fixed bugs in ns_get_family and
5366 ns_descriptor_to_entity that were caused by using free to
5367 deallocate memory blocks that were allocated by xmalloc (via
5368 xstrdup). This caused Emacs to crash when compiled with
5369 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
5370 --enable-checking=xmallocoverrun). xfree is now used to
5371 deallocate these memory blocks.
5372
4170f62f 53732011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 5374
71b41406
PE
5375 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
5376
9587a89d
PE
5377 emacs_write: Accept and return EMACS_INT for sizes.
5378 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
5379 et seq.
5380 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
5381 Accept and return EMACS_INT.
5382 (emacs_gnutls_write): Return the number of bytes written on
5383 partial writes.
5384 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
5385 (emacs_read, emacs_write): Remove check for negative size, as the
5386 Emacs source code has been audited now.
9587a89d
PE
5387 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
5388 (emacs_read, emacs_write): Use it.
273a5f82
PE
5389 * process.c (send_process): Adjust to the new signatures of
5390 emacs_write and emacs_gnutls_write. Do not attempt to store
5391 a byte offset into an 'int'; it might overflow.
9587a89d 5392 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 5393
3e047f51
PE
5394 * sound.c: Don't assume sizes fit in 'int'.
5395 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 5396 Return EMACS_INT, not int.
3e047f51 5397 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
5398 Accept EMACS_INT, not int.
5399 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
5400 record read return values.
5401
cc39a9db
BK
54022011-04-15 Ben Key <bkey76@gmail.com>
5403
c9d0ec6d
JB
5404 * keyboard.c (Qundefined): Don't declare static since it is used
5405 in nsfns.m.
5406 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
5407 static since they are used in nsfont.m.
cc39a9db 5408
6c60eb9f
SM
54092011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
5410
5411 * process.c (Qprocessp): Don't declare static.
5412 * lisp.h (Qprocessp): Declare again.
5413
7990b61a
JB
54142011-04-15 Juanma Barranquero <lekktu@gmail.com>
5415
5416 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
5417
5d4cb038
PE
54182011-04-14 Paul Eggert <eggert@cs.ucla.edu>
5419
8bd7b830 5420 Improve C-level modularity by making more things 'static'.
cd64ea1d 5421
e3b27b31
PE
5422 Don't publish debugger-only interfaces to other modules.
5423 * lisp.h (safe_debug_print, debug_output_compilation_hack):
5424 (verify_bytepos, count_markers): Move decls to the only modules
5425 that need them.
5426 * region-cache.h (pp_cache): Likewise.
5427 * window.h (check_all_windows): Likewise.
5428 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
5429
5d4cb038
PE
5430 * sysdep.c (croak): Now static, if
5431 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
5432 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
5433
5434 * alloc.c (refill_memory_reserve): Now static if
5435 !defined REL_ALLOC || defined SYSTEM_MALLOC.
5436 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 5437
e87b6180
PE
5438 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
5439 Define only if USE_LUCID.
5440
ac64929e
PE
5441 * xrdb.c (x_customization_string, x_rm_string): Now static.
5442
6f37259d
PE
5443 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
5444 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
5445
1683e3ab
PE
5446 * xdisp.c (draw_row_with_mouse_face): Now static.
5447 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
5448
de9c2632
PE
5449 * window.h (check_all_windows): Mark externally visible.
5450
2b96acb7
PE
5451 * window.c (window_deletion_count): Now static.
5452
5453 * undo.c: Make symbols static if they're not exported.
5454 (last_undo_buffer, last_boundary_position, pending_boundary):
5455 Now static.
5456
50436f33
PE
5457 * textprop.c (interval_insert_behind_hooks): Now static.
5458 (interval_insert_in_front_hooks): Likewise.
5459
64520e5c
PE
5460 * term.c: Make symbols static if they're not exported.
5461 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
5462 (max_frame_lines, tty_set_terminal_modes):
5463 (tty_reset_terminal_modes, tty_turn_off_highlight):
5464 (get_tty_terminal): Now static.
5465 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
5466 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 5467 HAVE_WINDOW_SYSTEM.
64520e5c
PE
5468 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
5469 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
5470
1fa53021
PE
5471 * sysdep.c: Make symbols static if they're not exported.
5472 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
5473 Now static.
5474 (sigprocmask_set, full_mask): Remove; unused.
5475 (wait_debugging): Mark as visible.
5476 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
5477 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
5478
d4b43b22
PE
5479 * syntax.c (syntax_temp): Define only if !__GNUC__.
5480
b7c513d0
PE
5481 * sound.c (current_sound_device, current_sound): Now static.
5482
989b29ad
PE
5483 * search.c (searchbufs, searchbuf_head): Now static.
5484
13a55a78
PE
5485 * scroll.c (scroll_cost): Remove; unused.
5486 * dispextern.h (scroll_cost): Remove decl.
5487
de68a1fc
PE
5488 * region-cache.h (pp_cache): Mark as externally visible.
5489
40ccffa6
PE
5490 * process.c: Make symbols static if they're not exported.
5491 (process_tick, update_tick, create_process, chan_process):
5492 (Vprocess_alist, proc_buffered_char, datagram_access):
5493 (fd_callback_data, send_process_frame, process_sent_to): Now static.
5494 (deactivate_process): Mark defn as static, as well as decl.
5495 * lisp.h (create_process): Remove decl.
5496 * process.h (chan_process, Vprocess_alist): Remove decls.
5497
ad64fc97
PE
5498 * print.c: Make symbols static if they're not exported.
5499 (print_depth, new_backquote_output, being_printed, print_buffer):
5500 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
5501 (print_interval, print_number_index, initial_stderr_stream):
5502 Now static.
5503 * lisp.h (Fprinc): Remove decl.
5504 (debug_output_compilation_hack): Mark as externally visible.
5505
adddb265
PE
5506 * sysdep.c (croak): Move decl from here to syssignal.h.
5507 * syssignal.h (croak): Put it here, so the API can be checked when
5508 'croak' is called from dissociate_if_controlling_tty.
5509
1717ede2
PE
5510 * minibuf.c: Make symbols static if they're not exported.
5511 (minibuf_save_list, choose_minibuf_frame): Now static.
5512 * lisp.h (choose_minibuf_frame): Remove decl.
5513
fa5fb2bc
PE
5514 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
5515
1e3890d1
PE
5516 * lread.c: Make symbols static if they're not exported.
5517 (read_objects, initial_obarray, oblookup_last_bucket_number):
5518 Now static.
5519 (make_symbol): Remove; unused.
5520 * lisp.h (initial_obarray, make_symbol): Remove decls.
5521
8a1414fa
PE
5522 * keyboard.c: Make symbols static if they're not exported.
5523 (single_kboard, recent_keys_index, total_keys, recent_keys):
5524 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
5525 (this_single_command_key_start, echoing, last_auto_save):
5526 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
5527 (command_loop, echo_now, keyboard_init_hook, help_char_p):
5528 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
5529 (Vlispy_mouse_stem, double_click_count):
5530 Now static.
5531 (force_auto_save_soon): Define only if SIGDANGER.
5532 (ignore_mouse_drag_p): Now static if
5533 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
5534 (print_help): Remove; unused.
5535 (stop_character, last_timer_event): Mark as externally visible.
5536 * keyboard.h (ignore_mouse_drag_p): Declare only if
5537 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
5538 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
5539 * lisp.h (echoing): Remove decl.
5540 (force_auto_save_soon): Declare only if SIGDANGER.
5541 * xdisp.c (redisplay_window): Simplify code, to make it more
5542 obvious that ignore_mouse_drag_p is not accessed if !defined
5543 USE_GTK && !defined HAVE_NS.
5544
93ea6e8f
PE
5545 * intervals.c: Make symbols static if they're not exported.
5546 (merge_properties_sticky, merge_interval_right, delete_interval):
5547 Now static.
5548 * intervals.h (merge_interval_right, delete_interval): Remove decls.
5549
77382fcc
PE
5550 * insdel.c: Make symbols static if they're not exported.
5551 However, leave prepare_to_modify_buffer alone. It's never
5552 called from outside this function, but that appears to be a bug.
5553 (combine_after_change_list, combine_after_change_buffer):
4889fc82 5554 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
5555 (adjust_after_replace_noundo): Remove; unused.
5556 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 5557 (signal_before_change): Remove decls.
77382fcc 5558
9306c32e
PE
5559 * indent.c (val_compute_motion, val_vmotion): Now static.
5560
cd44d2eb
PE
5561 * image.c: Make symbols static if they're not exported.
5562 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
5563 if USE_GTK.
5564 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
5565 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
5566
ad9a7a06
PE
5567 * fringe.c (standard_bitmaps): Now static.
5568 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
5569
81626931
PE
5570 * frame.c: Make symbols static if they're not exported.
5571 (x_report_frame_params, make_terminal_frame): Now static.
5572 (get_frame_param): Now static, unless HAVE_NS.
5573 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
5574 (x_get_resource_string): Remove; not used.
5575 * frame.h (make_terminal_frame, x_report_frame_params):
5576 (x_get_resource_string); Remove decls.
5577 (x_fullscreen_adjust): Declare only if WINDOWSNT.
5578 * lisp.h (get_frame_param): Declare only if HAVE_NS.
5579
239f9db9
PE
5580 * font.c, fontset.c: Make symbols static if they're not exported.
5581 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
5582 (FACE_SUITABLE_FOR_CHAR_P): Use it.
5583 * font.c (font_close_object): Now static.
5584 * font.h (font_close_object): Remove.
5585 * fontset.c (FONTSET_OBJLIST): Remove.
5586 (free_realized_fontset) #if-0 the body, which does nothing.
5587 (face_suitable_for_char_p): #if-0, as it's never called.
5588 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
5589 * xfaces.c (face_at_string_position):
5590 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
5591 since 0 is always ASCII.
5592
dfcf3579
PE
5593 * fns.c (weak_hash_tables): Now static.
5594
5045092b
PE
5595 * fileio.c: Make symbols static if they're not exported.
5596 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
5597 (Vwrite_region_annotation_buffers): Now static.
5598
57a96f5c
PE
5599 * eval.c: Make symbols static if they're not exported.
5600 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
5601 * lisp.h (backtrace_list): Remove decl.
5602
35f08c38
PE
5603 * emacs.c: Make symbols static if they're not exported.
5604 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
5605 (fatal_error_code, fatal_error_signal_hook, standard_args):
5606 Now static.
5607 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
5608 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
5609 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
5610 * lisp.h (fatal_error_signal_hook): Remove decl.
5611 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
5612
f44bd759
PE
5613 * editfns.c: Move a (normally-unused) function to its only use.
5614 * editfns.c, lisp.h (get_operating_system_release): Remove.
5615 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
5616 worth the hassle of breaking this out.
5617
b532497d
PE
5618 * xterm.c: Make symbols static if they're not exported.
5619 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
5620 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
5621 (x_destroy_window, x_delete_display):
5622 Now static.
5623 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
5624 (x_mouse_leave): Remove; unused.
5625 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
5626 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
5627 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
5628 Remove decls.
5629 (x_mouse_leave): Declare only if WINDOWSNT.
5630 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
5631 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
5632 USE_X_TOOLKIT.
5633
1675728f
PE
5634 * ftxfont.c: Make symbols static if they're not exported.
5635 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
5636 HAVE_FREETYPE.
5637 * font.h (ftxfont_driver): Likewise.
5638
e4cebfca
PE
5639 * xfns.c: Make symbols static if they're not exported.
5640 (x_last_font_name, x_display_info_for_name):
5641 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
5642 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
5643 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
5644 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
5645 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
5646 (last_show_tip_args): Now static.
5647 (xic_defaut_fontset, xic_create_fontsetname): Define only if
5648 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
5649 (x_screen_planes): Remove; unused.
5650 * dispextern.h (x_screen_planes): Remove decl.
5651
5bf46f05
PE
5652 * dispnew.c: Make symbols static if they're not exported.
5653 * dispextern.h (redraw_garbaged_frames, scrolling):
5654 (increment_row_positions): Remove.
5655 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
5656 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
5657 Now static.
5658 (redraw_garbaged_frames): Remove; unused.
5659
435f4c28
PE
5660 * xfaces.c: Make symbols static if they're not exported.
5661 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
5662 Remove decls.
5663 * xterm.h (defined_color): Remove decls.
5664 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
5665 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
5666 (menu_face_changed_default, defined_color, free_realized_face):
5667 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
5668 (ascii_face_of_lisp_face): Remove; unused.
5669
8524aef3
PE
5670 * xdisp.c: Make symbols static if they're not exported.
5671 * dispextern.h (scratch_glyph_row, window_box_edges):
5672 (glyph_to_pixel_coords, set_cursor_from_row):
5673 (get_next_display_element, set_iterator_to_next):
5674 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
5675 (show_mouse_face): Remove decls
5676 * frame.h (message_buf_print): Likewise.
5677 * lisp.h (pop_message, set_message, check_point_in_composition):
5678 Likewise.
5679 * xterm.h (set_vertical_scroll_bar): Likewise.
5680 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
5681 (message_buf_print, scratch_glyph_row, displayed_buffer):
5682 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
5683 (get_next_display_element, show_mouse_face, window_box_edges):
5684 (frame_to_window_pixel_xy, check_point_in_composition):
5685 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
5686 (glyph_to_pixel_coords): Remove; unused.
5687
16390cd2
PE
5688 * dired.c (file_name_completion): Now static.
5689
5690 * dbusbind.c (xd_in_read_queued_messages): Now static.
5691
a25f4dfa
PE
5692 * lisp.h (circular_list_error, FOREACH): Remove; unused.
5693 * data.c (circular_list_error): Remove.
5694
14a9c8df
PE
5695 * commands.h (last_point_position, last_point_position_buffer):
5696 (last_point_position_window): Remove decls.
5697 * keyboard.c: Make these variables static.
5698
04f2d78b
CB
5699 * coding.h (coding, code_convert_region, encode_coding_gap):
5700 Remove decls.
74ab6df5
PE
5701 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
5702 (iso_code_class, detect_coding, code_convert_region): Now static.
5703 (encode_coding_gap): Remove; unused.
5704
38dfbee1
PE
5705 * chartab.c (chartab_chars, chartab_bits): Now static.
5706
a2cb4e63
PE
5707 * charset.h (charset_iso_8859_1): Remove decl.
5708 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
5709 Now static.
5710
127198fd
PE
5711 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
5712 * ccl.c (Vccl_program_table): Now static.
5713 (check_ccl_update): Remove; unused.
5714
d85b608f
PE
5715 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
5716 * category.h: ... from here.
5717 * category.c (check_category_table, set_category_set): Now static.
5718
31cd66f3
PE
5719 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
5720 * lisp.h: Remove these decls.
5721
c358e587
PE
5722 * buffer.c (buffer_count): Remove unused var.
5723
e78aecca
PE
5724 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
5725 so that it's not optimized away.
5726 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
5727 * dispextern.h (bidi_dump_cached_states): Remove, since it's
5728 exported only to the debugger.
5729
e192d7d3 5730 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 5731 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 5732
92470028
PE
5733 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
5734 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
5735 was inaccessible from Lisp.
5736 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
5737 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
5738
244ed907
PE
5739 alloc.c: Import and export fewer symbols, and remove unused items.
5740 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
5741 is defined.
5742 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
5743 it's not optimized away by whole-program optimization.
5744 (message_enable_multibyte, free_misc): Remove.
5745 (catchlist, handlerlist, mark_backtrace):
5746 Declare only if BYTE_MARK_STACK.
5747 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
5748 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
5749 (message_enable_multibyte): Remove decl.
5750 (free_misc, interval_free_list, float_block, float_block_index):
5751 (n_float_blocks, float_free_list, cons_block, cons_block_index):
5752 (cons_free_list, last_marked_index):
5753 Now static.
5754 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
5755 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
5756 (mark_backtrace): Define only if BYTE_MARK_STACK.
5757 * xdisp.c (message_enable_multibyte): Now static.
5758
61c2b50e 5759 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
5760 This makes it easier for human readers (and static analyzers)
5761 to see whether these variables are used from other modules.
5762 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
5763 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
5764 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
5765 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
5766 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
5767 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
5768 * xmenu.c, xselect.c:
5769 Declare Q* vars static if they are not used in other modules.
5770 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
5771 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
5772 Remove decls of unexported vars.
5773 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
5774
95c82688
PE
5775 * lisp.h (DEFINE_FUNC): Make sname 'static'.
5776
16a97296
PE
5777 Make Emacs functions such as Fatom 'static' by default.
5778 This makes it easier for human readers (and static analyzers)
5779 to see whether these functions can be called from other modules.
5780 DEFUN now defines a static function. To make the function external
5781 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
5782 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
5783 (Finit_image_library):
16a97296
PE
5784 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
5785 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
5786 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
5787 Remove decls, since these functions are now static.
5788 (Funintern, Fget_internal_run_time): New decls, since these functions
5789 were already external.
95c82688 5790
16a97296
PE
5791 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
5792 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
5793 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
5794 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
5795 * keyboard.c, keymap.c, lread.c:
5796 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
5797 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
5798 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
5799 Mark functions with DEFUE instead of DEFUN,
5800 if they are used in other modules.
5801 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
5802 decls for now-static functions.
5803 * buffer.h (Fdelete_overlay): Remove decl.
5804 * callproc.c (Fgetenv_internal): Mark as internal.
5805 * composite.c (Fremove_list_of_text_properties): Remove decl.
5806 (Fcomposition_get_gstring): New forward static decl.
5807 * composite.h (Fcomposite_get_gstring): Remove decl.
5808 * dired.c (Ffile_attributes): New forward static decl.
5809 * doc.c (Fdocumntation_property): New forward static decl.
5810 * eval.c (Ffetch_bytecode): New forward static decl.
5811 (Funintern): Remove extern decl; now in .h file where it belongs.
5812 * fileio.c (Fmake_symbolic_link): New forward static decl.
5813 * image.c (Finit_image_library): New forward static decl.
5814 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
5815 * intervals.h (Fprevious_property_change):
5816 (Fremove_list_of_text_properties): Remove decls.
5817 * keyboard.c (Fthis_command_keys): Remove decl.
5818 (Fcommand_execute): New forward static decl.
5819 * keymap.c (Flookup_key): New forward static decl.
5820 (Fcopy_keymap): Now static.
5821 * keymap.h (Flookup_key): Remove decl.
5822 * process.c (Fget_process): New forward static decl.
5823 (Fprocess_datagram_address): Mark as internal.
5824 * syntax.c (Fsyntax_table_p): New forward static decl.
5825 (skip_chars): Remove duplicate decl.
5826 * textprop.c (Fprevious_property_change): New forward static decl.
5827 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
5828 Now internal.
5829 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
5830 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
5831
785bbd42
PE
5832 * editfns.c (Fformat): Remove unreachable code.
5833
8b913b57
AS
58342011-04-14 Andreas Schwab <schwab@linux-m68k.org>
5835
5836 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
5837 change. (Bug#8496)
5838
a6744a35
EZ
58392011-04-13 Eli Zaretskii <eliz@gnu.org>
5840
5841 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
5842 when at ZV. (Bug#8487)
5843
e7974947
AS
58442011-04-12 Andreas Schwab <schwab@linux-m68k.org>
5845
baad03f0
AS
5846 * charset.c (Fclear_charset_maps): Use xfree instead of free.
5847 (Bug#8437)
5848 * keyboard.c (parse_tool_bar_item): Likewise.
5849 * sound.c (sound_cleanup, alsa_close): Likewise.
5850 * termcap.c (tgetent): Likewise.
5851 * xfns.c (x_default_font_parameter): Likewise.
5852 * xsettings.c (read_and_apply_settings): Likewise.
5853
e7974947
AS
5854 * alloc.c (overrun_check_malloc, overrun_check_realloc)
5855 (overrun_check_free): Protoize.
5856
28272684
PE
58572011-04-12 Paul Eggert <eggert@cs.ucla.edu>
5858
5859 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
5860 since callers should never pass a negative size.
5861 Change the signature to match that of plain 'read' and 'write'; see
5862 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
5863 * lisp.h: Update prototypes of emacs_write and emacs_read.
5864
11997c76
EZ
58652011-04-11 Eli Zaretskii <eliz@gnu.org>
5866
5867 * xdisp.c (redisplay_window): Don't try to determine the character
5868 position of the scroll margin if the window start point w->startp
e896f03c 5869 is outside the buffer's accessible region. (Bug#8468)
11997c76 5870
8a2cbd72
EZ
58712011-04-10 Eli Zaretskii <eliz@gnu.org>
5872
5873 Fix write-region and its subroutines for buffers > 2GB.
5874 * fileio.c (a_write, e_write): Modify declaration of arguments and
5875 local variables to support buffers larger than 2GB.
5876 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
5877
5878 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
5879 argument, local variables, and return value.
5880
5881 * lisp.h: Update prototypes of emacs_write and emacs_read.
5882
5883 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
5884
4073e537 58852011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 5886
1ebfdcb6
PE
5887 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
5888
b2ded58d
PE
5889 Fix more problems found by GCC 4.6.0's static checks.
5890
7d66342c
PE
5891 * xdisp.c (vmessage): Use a better test for character truncation.
5892
bbf47d44
PE
5893 * charset.c (load_charset_map): <, not <=, for optimization,
5894 and to avoid potential problems with integer overflow.
9248994d 5895 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 5896 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 5897 * editfns.c (Fformat): Likewise.
1e69125e 5898 * syntax.c (skip_chars): Likewise.
3befa583 5899
e3019616
PE
5900 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
5901 This also lets GCC 4.6.0 generate slightly better loop code.
5902
becfa255
PE
5903 * callint.c (Fcall_interactively): <, not <=, for optimization.
5904 (Fcall_interactively): Count the number of arguments produced,
5905 not the number of arguments given. This is simpler and lets GCC
5906 4.6.0 generate slightly better code.
5907
dae0cd48
PE
5908 * ftfont.c: Distingish more carefully between FcChar8 and char.
5909 The previous code passed unsigned char * to a functions like
5910 strlen and xstrcasecmp that expect char *, which does not
5911 conform to the C standard.
5912 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
5913 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
5914 char * when the C standard requires it.
5915
76032d70
PE
5916 * keyboard.c (read_char): Remove unused var.
5917
eb3f1cc8
PE
5918 * eval.c: Port to Windows vsnprintf (Bug#8435).
5919 Include <limits.h>.
5920 (SIZE_MAX): Define if the headers do not.
5921 (verror): Do not give up if vsnprintf returns a negative count.
5922 Instead, grow the buffer. This ports to Windows vsnprintf, which
5923 does not conform to C99. Problem reported by Eli Zaretskii.
5924 Also, simplify the allocation scheme, by avoiding the need for
5925 calling realloc, and removing the ALLOCATED variable.
5926
70476b54
PE
5927 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
5928
12020a9e
PE
5929 Remove invocations of doprnt, as Emacs now uses vsnprintf.
5930 But keep the doprint source code for now, as we might revamp it
5931 and use it again (Bug#8435).
ea6c7ae6
PE
5932 * lisp.h (doprnt): Remove.
5933 * Makefile.in (base_obj): Remove doprnt.o.
5934 * deps.mk (doprnt.o): Remove.
5935
5fdb398c
PE
5936 error: Print 32- and 64-bit integers portably (Bug#8435).
5937 Without this change, on typical 64-bit hosts error ("...%d...", N)
5938 was used to print both 32- and 64-bit integers N, which relied on
5939 undefined behavior.
5940 * lisp.h, src/m/amdx86-64.h, src/m/ia64.h, src/m/ibms390x.h (pEd):
5941 New macro.
5942 * lisp.h (error, verror): Mark as printf-like functions.
5943 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
5944 Report overflow in size calculations when allocating printf buffer.
5945 Do not truncate output string at its first null byte.
5946 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
5947 Truncate the output at a character boundary, since vsnprintf does not
5948 do that.
5949 * charset.c (check_iso_charset_parameter): Convert internal
5950 character to string before calling 'error', since %c now has the
5951 printf meaning.
5952 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
5953 overflow when computing char to be passed to 'error'. Do not
5954 pass Lisp_Object to 'error'; pass the integer instead.
5955 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
5956 formatted with plain %d.
5957
b189fa66
PE
5958 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
5959
bff87ef0
PE
5960 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
5961
7e2cac20
PE
5962 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
5963
ce4d90b5
PE
5964 * xterm.c (x_catch_errors): Remove duplicate declaration.
5965
266c9547
PE
5966 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
5967
79c49ad2
PE
5968 * xdisp.c, lisp.h (message_nolog): Remove; unused.
5969
368f4090
JM
59702011-04-10 Jim Meyering <meyering@redhat.com>
5971
5972 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
5973 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
5974 return ssize_t not "int", and use size_t as the buffer length.
5975 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
5976 * gnutls.h: Update declarations.
5977 * process.c (read_process_output): Use ssize_t, to match.
5978 (send_process): Likewise.
5979
a32d4040
CY
59802011-04-09 Chong Yidong <cyd@stupidchicken.com>
5981
5982 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
5983
8546720e 59842011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 5985
04f2d78b
CB
5986 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
5987 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 5988
8546720e
GM
5989 * xterm.c (handle_one_xevent):
5990 * xmenu.c (create_and_show_popup_menu):
5991 * xselect.c (x_decline_selection_request)
5992 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 5993
0a2f5c1a 59942011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
5995
5996 Fix some uses of `int' instead of EMACS_INT.
5997 * search.c (string_match_1, fast_string_match)
5998 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
5999 (scan_buffer, find_next_newline_no_quit)
6000 (find_before_next_newline, search_command, Freplace_match)
6001 (Fmatch_data): Make some `int' variables be EMACS_INT.
6002
6003 * xdisp.c (display_count_lines): 3rd argument and return value now
6004 EMACS_INT. All callers changed.
6005 (pint2hrstr): Last argument is now EMACS_INT.
6006
6007 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
6008 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
6009 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
6010 (decode_coding_utf_16, decode_coding_emacs_mule)
6011 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
6012 (decode_coding_ccl, decode_coding_charset)
6013 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
6014 (decode_coding_iso_2022, decode_coding_emacs_mule)
6015 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
6016 <char_offset, last_offset>: Declare EMACS_INT.
6017 (encode_coding_utf_8, encode_coding_utf_16)
6018 (encode_coding_emacs_mule, encode_invocation_designation)
6019 (encode_designation_at_bol, encode_coding_iso_2022)
6020 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
6021 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
6022 Declare EMACS_INT.
6023 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
6024 (encode_invocation_designation): Last argument P_NCHARS is now
6025 EMACS_INT.
6026 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
6027 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
6028
6029 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
6030 All users changed.
6031
6032 * ccl.c (Fccl_execute_on_string): Declare some variables
6033 EMACS_INT.
6034
8546720e 60352011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
6036
6037 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
6038
4e19a977
CS
60392011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
6040
6041 * process.c (Fformat_network_address): Doc fix.
6042
87302331
R
60432011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
6044
6045 * xml.c (parse_region): Avoid creating spurious whiespace nodes.
6046
cbb59342
CY
60472011-04-08 Chong Yidong <cyd@stupidchicken.com>
6048
6049 * keyboard.c (read_char): Call Lisp function help-form-show,
6050 instead of using internal_with_output_to_temp_buffer.
6051 (Qhelp_form_show): New var.
e0d38eeb 6052 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
6053
6054 * print.c (internal_with_output_to_temp_buffer): Function deleted.
6055
6056 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
6057
e67a13ab
CY
60582011-04-06 Chong Yidong <cyd@stupidchicken.com>
6059
04f2d78b
CB
6060 * process.c (Flist_processes): Remove to Lisp.
6061 (list_processes_1): Delete.
e67a13ab 6062
973f782d
EZ
60632011-04-06 Eli Zaretskii <eliz@gnu.org>
6064
7c106b1e
EZ
6065 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
6066
973f782d
EZ
6067 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
6068
41cf7d1a 60692011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 6070
ca23cc88
PE
6071 Fix more problems found by GCC 4.6.0's static checks.
6072
f390e2d5
PE
6073 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
6074
42eea0d0
PE
6075 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
6076
b69769da 6077 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 6078
f9541e84
PE
6079 * xdisp.c (vmessage): Mark as a printf-like function.
6080
13841b55
PE
6081 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
6082
c136c10f
PE
6083 * sound.c (sound_warning): Don't crash if arg contains a printf format.
6084
5e2d4a30
PE
6085 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
6086 printf-like functions.
6087 (tiff_load): Add casts to remove these marks before passing them
6088 to system-supplied API.
6089
583f48b9
PE
6090 * eval.c (Fsignal): Remove excess argument to 'fatal'.
6091
b25d760e
PE
6092 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
6093 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
6094 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
6095 directly, rather than having caller test rule sign. This avoids
6096 some unnecessary tests.
6097 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
6098 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
6099 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 6100
bc7b6697 6101 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 6102 (xfont_open): Avoid unnecessary tests.
bc7b6697 6103
27ccc379
PE
6104 * composite.c (composition_gstring_put_cache): Use unsigned integer.
6105
dcd5c89a
PE
6106 * composite.h, composite.c (composition_gstring_put_cache):
6107 Use EMACS_INT, not int, for length.
6108
b13a45c6
PE
6109 * composite.h (COMPOSITION_DECODE_REFS): New macro,
6110 breaking out part of COMPOSITION_DECODE_RULE.
6111 (COMPOSITION_DECODE_RULE): Use it.
6112 * composite.c (get_composition_id): Remove unused local vars,
6113 by using the new macro.
6114
1e792e4d
PE
6115 * textprop.c (set_text_properties_1): Change while to do-while,
6116 since the condition is always true at first.
6117
dc6c6455 6118 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
6119 (interval_deletion_adjustment): Return unsigned value.
6120 All uses changed.
dc6c6455 6121
aba7731a
PE
6122 * process.c (list_processes_1, create_pty, read_process_output):
6123 (exec_sentinel): Remove vars that were set but not used.
afd4052b 6124 (create_pty): Remove unnecessary "volatile"s.
bc57d757 6125 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 6126 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 6127 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 6128
fdfc4bf3
PE
6129 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
6130
fca8fe46 6131 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 6132 (update_syntax_table): Use unsigned instead of int.
fca8fe46 6133
06a0259a 6134 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 6135 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 6136 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 6137
e7b9e80f
PE
6138 * print.c (print_error_message): Avoid int overflow.
6139
56201685
PE
6140 * font.c (font_list_entities): Redo for clarity,
6141 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
6142
78834453 6143 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 6144 (font_score): Avoid potential overflow in diff calculation.
78834453 6145
0bc0b309 6146 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 6147 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 6148
e610eaca
PE
6149 * eval.c (funcall_lambda): Rename local to avoid shadowing.
6150
b895abce
PE
6151 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
6152 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
6153 can always succeed if overflow has undefined behavior.
6154
1f1d9321 6155 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 6156 (wordify): Omit three unnecessary tests.
1f1d9321 6157
c59478bc
PE
6158 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
6159 All callers changed. This avoids the need for an unused var.
6160
79b73827
PE
6161 * casefiddle.c (casify_region): Remove var that is set but not used.
6162
a4db5dfe
PE
6163 * dired.c (file_name_completion): Remove var that is set but not used.
6164
43aae36e
PE
6165 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
6166
2a47c44d 6167 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 6168 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 6169
a37c69bf
PE
6170 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
6171 Check for integer overflow on size calculations.
6172
328ab8e7
PE
6173 * buffer.c (Fprevious_overlay_change): Remove var that is set
6174 but not used.
6175
e5a2a5cb
PE
6176 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
6177 Remove vars that are set but not used.
8d84a6eb 6178 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 6179 (timer_check_2): Mark vars as initialized.
e5a2a5cb 6180
a60e5f68
PE
6181 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
6182
f661cb61 6183 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 6184 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 6185
f0397f5a
PE
6186 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
6187 that are set but not used.
6188
8664db06 6189 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 6190 if XCreateBitmapFromData fails (Bug#8410).
8664db06 6191
6abdaa4a
PE
6192 * xselect.c (x_get_local_selection, x_handle_property_notify):
6193 Remove vars that are set but not used.
6194
0ce7538d 6195 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 6196 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 6197
9ae848fc
PE
6198 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
6199 Remove var that is set but not used.
0b918413
PE
6200 (scroll_bar_windows_size): Now size_t, not int.
6201 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
6202 Check for overflow.
9ae848fc 6203
a5a62657
PE
6204 * xfaces.c (realize_named_face): Remove vars that are set but not used.
6205 (map_tty_color) [!defined MSDOS]: Likewise.
6206
5c5cdd39
PE
6207 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
6208
66ebf983
PE
6209 * coding.c: Remove vars that are set but not used.
6210 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
6211 All callers changed.
6212 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
6213 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
6214 (decode_coding_charset): Remove vars that are set but not used.
6215
1be4d761
PE
6216 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
6217 that is set but not used.
6218
47553fa8
PE
6219 * print.c (print_object): Remove var that is set but not used.
6220
1f7196bf 6221 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
6222 The gnulib version avoids calling malloc in the usual case,
6223 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
6224 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
6225 * filelock.c (current_lock_owner): Likewise.
6226 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
6227 * sysdep.c: Include allocator.h, careadlinkat.h.
6228 (emacs_no_realloc_allocator): New static constant.
6229 (emacs_readlink): New function.
fdb61804
PE
6230 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
6231 ../lib/careadlinkat.h.
d1fdcab7 6232
f84c17c7
SM
62332011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
6234
6235 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
6236 first non-nil return value).
6237
ef3862ad
JD
62382011-04-03 Jan Djärv <jan.h.d@swipnet.se>
6239
6240 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
6241 if not defined (Bug#8403).
6242
376a7006
JB
62432011-04-02 Juanma Barranquero <lekktu@gmail.com>
6244
6245 * xdisp.c (display_count_lines): Remove parameter `start',
6246 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6247 (get_char_face_and_encoding): Remove parameter `multibyte_p',
6248 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6249 (fill_stretch_glyph_string): Remove parameters `row' and `area',
6250 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
6251 and thereabouts. All callers changed.
6252 (get_per_char_metric): Remove parameter `f', unused since
6253 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
6254
6ca3801d
JM
62552011-04-02 Jim Meyering <meyering@redhat.com>
6256
6257 do not dereference NULL upon failed strdup
6258 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
6259 (ns_get_family): Likewise.
6260
d8e2b5ba
JB
62612011-04-02 Juanma Barranquero <lekktu@gmail.com>
6262
6263 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
6264
8c74fcbd
JD
62652011-04-02 Jan Djärv <jan.h.d@swipnet.se>
6266
6267 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
6268 later (Bug#8403).
6269
7200d79c
SM
62702011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
6271
03408648 6272 Add lexical binding.
7200d79c 6273
03408648
SM
6274 * window.c (Ftemp_output_buffer_show): New fun.
6275 (Fsave_window_excursion):
6276 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
6277
6278 * lread.c (lisp_file_lexically_bound_p): New function.
6279 (Fload): Bind Qlexical_binding.
6280 (readevalloop): Remove `evalfun' arg.
6281 Bind Qinternal_interpreter_environment.
6282 (Feval_buffer): Bind Qlexical_binding.
6283 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
6284 Mark as dynamic.
6285 (syms_of_lread): Declare `lexical-binding'.
6286
6287 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
6288
6289 * keyboard.c (eval_dyn): New fun.
6290 (menu_item_eval_property): Use it.
ca105506
SM
6291
6292 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 6293
03408648
SM
6294 * fns.c (concat, mapcar1): Accept byte-code-functions.
6295
6296 * eval.c (Fsetq): Handle lexical vars.
6297 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
6298 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
6299 (FletX, Flet): Obey lexical binding.
6300 (Fcommandp): Handle closures.
6301 (Feval): New `lexical' arg.
6302 (eval_sub): New function extracted from Feval. Use it almost
6303 everywhere where Feval was used. Look up vars in lexical env.
6304 Handle closures.
6305 (Ffunctionp): Move from subr.el.
6306 (Ffuncall): Handle closures.
6307 (apply_lambda): Remove `eval_flags'.
6308 (funcall_lambda): Handle closures and new byte-code-functions.
6309 (Fspecial_variable_p): New function.
6310 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
6311 but without exporting it to Lisp.
23aba0ea 6312
23aba0ea 6313 * doc.c (Fdocumentation, store_function_docstring):
03408648 6314 * data.c (Finteractive_form): Handle closures.
23aba0ea 6315
03408648
SM
6316 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
6317 interactive spec.
ba83908c 6318
04f2d78b
CB
6319 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
6320 New byte-codes.
03408648
SM
6321 (exec_byte_code): New function extracted from Fbyte_code to handle new
6322 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 6323
03408648 6324 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 6325
03408648 6326 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 6327
e2abce01
JB
63282011-03-31 Juanma Barranquero <lekktu@gmail.com>
6329
6330 * xdisp.c (redisplay_internal): Fix prototype.
6331
63696a73 63322011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 6333
63696a73 6334 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
6335 (try_scrolling): Use it when setting scroll_limit.
6336 Limit scrolling to 100 screen lines.
63696a73
EZ
6337 (redisplay_window): Even when falling back on "recentering",
6338 position point in the window according to scroll-conservatively,
6339 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
6340
6341 (try_scrolling): When point is above the window, allow searching
6342 as far as scroll_max, or one screenful, to compute vertical
6343 distance from PT to the scroll margin position. This prevents
6344 try_scrolling from unnecessarily failing when
6345 scroll-conservatively is set to a value slightly larger than the
6346 window height. Clean up the case of PT below the margin at bottom
6347 of window: scroll_max can no longer be INT_MAX. When aggressive
6348 scrolling is in use, don't let point enter the opposite scroll
6349 margin as result of the scroll.
6350 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
6351 threshold of 100 lines for never-recentering scrolling.
6352
e4cc2dfc
JB
63532011-03-31 Juanma Barranquero <lekktu@gmail.com>
6354
6355 * dispextern.h (move_it_by_lines):
6356 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
6357 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
6358 (message_log_check_duplicate): Remove parameters `prev_bol' and
6359 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
6360 (redisplay_internal): Remove parameter `preserve_echo_area',
6361 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
6362
6363 * indent.c (Fvertical_motion):
6364 * window.c (window_scroll_pixel_based, Frecenter):
6365 Don't pass `need_y_p' to `move_it_by_lines'.
6366
1c470562
SM
63672011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
6368
44f230aa
SM
6369 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
6370 steal a few bits to be more compact.
6371 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
6372 Remove unneeded casts.
6373
1c470562
SM
6374 * bytecode.c (Fbyte_code): CAR and CDR can GC.
6375
888adce9
ZK
63762011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
6377
6378 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
6379 binding" message (bug#7967).
6380
f838ed7b
PE
63812011-03-30 Paul Eggert <eggert@cs.ucla.edu>
6382
77861b95
PE
6383 Fix more problems found by GCC 4.6.0's static checks.
6384
de6dbc14
PE
6385 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
6386 Remove unused local var.
6387
f838ed7b
PE
6388 * editfns.c (Fmessage_box): Remove unused local var.
6389
792c7b2b
PE
6390 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
6391 (note_mode_line_or_margin_highlight, note_mouse_highlight):
6392 Omit unused local vars.
c499e557 6393 * window.c (shrink_windows): Omit unused local var.
b01a1c29 6394 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
6395 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
6396 Omit unused local var.
6397
ba0165e1
PE
6398 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
6399 Don't assume string length fits in int.
32ad8845 6400 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 6401 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 6402
3c59b4c9
PE
6403 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
6404 instead of alloca (Bug#8344).
6405
a3eed478 6406 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 6407 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 6408
eb4d412d
PE
6409 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
6410
1658b401
PE
6411 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
6412 concerns.
6413
6414 * term.c (produce_glyphless_glyph): Remove unnecessary test.
6415
6416 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 6417
9a2c6e05
PE
6418 * keyboard.c (syms_of_keyboard): Use the same style as later
6419 in this function when indexing through an array. This also
6420 works around GCC bug 48267.
6421
03d0a109
PE
6422 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
6423
44f730c8
PE
6424 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
6425
fe75f926
PE
6426 * chartab.c (sub_char_table_ref_and_range): Redo for slight
6427 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
6428
ffa8c828
PE
6429 * keyboard.c, keyboard.h (num_input_events): Now size_t.
6430 This avoids undefined behavior on integer overflow, and is a bit
6431 more convenient anyway since it is compared to a size_t variable.
6432
c5101a77
PE
6433 Variadic C functions now count arguments with size_t, not int.
6434 This avoids an unnecessary limitation on 64-bit machines, which
6435 caused (substring ...) to crash on large vectors (Bug#8344).
6436 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
6437 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 6438 All variadic functions and their callers changed accordingly.
c5101a77
PE
6439 (struct gcpro.nvars): Now size_t, not int. All uses changed.
6440 * data.c (arith_driver, float_arith_driver): Likewise.
6441 * editfns.c (general_insert_function): Likewise.
6442 * eval.c (struct backtrace.nargs, interactive_p)
6443 (internal_condition_case_n, run_hook_with_args, apply_lambda)
6444 (funcall_lambda, mark_backtrace): Likewise.
6445 * fns.c (concat): Likewise.
6446 * frame.c (x_set_frame_parameters): Likewise.
6447 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
6448 0 if not found, not -1. All callers changed.
6449
dd3f25f7
PE
6450 * alloc.c (garbage_collect): Don't assume stack size fits in int.
6451 (stack_copy_size): Now size_t, not int.
6452 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
6453
461c2ab9
JB
64542011-03-28 Juanma Barranquero <lekktu@gmail.com>
6455
6456 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
6457 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6458 All callers changed.
6459
6460 * lisp.h (multibyte_char_to_unibyte):
6461 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
6462 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
6463 * character.h (CHAR_TO_BYTE8):
6464 * cmds.c (internal_self_insert):
6465 * editfns.c (general_insert_function):
6466 * keymap.c (push_key_description):
6467 * search.c (Freplace_match):
6468 * xdisp.c (message_dolog, set_message_1): All callers changed.
6469
f6d62986
SM
64702011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
6471
6472 * keyboard.c (safe_run_hook_funcall): New function.
6473 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
6474 don't set the hook to nil, but remove the offending function instead.
6475 (Qcommand_hook_internal): Remove, unused.
6476 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
6477 Vcommand_hook_internal.
6478
6479 * eval.c (enum run_hooks_condition): Remove.
6480 (funcall_nil, funcall_not): New functions.
6481 (run_hook_with_args): Call each function through a `funcall' argument.
6482 Remove `cond' argument, now redundant.
6483 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
6484 (Frun_hook_with_args_until_failure): Adjust accordingly.
6485 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
6486
1db5b1ad
JB
64872011-03-28 Juanma Barranquero <lekktu@gmail.com>
6488
6489 * dispextern.h (string_buffer_position): Remove declaration.
6490
6491 * print.c (strout): Remove parameter `multibyte', unused since
6492 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
6493
6494 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
6495 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
6496 All callers changed.
6497
6498 * w32.c (_wsa_errlist): Use braces for struct initializers.
6499
6500 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
6501 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
6502 All callers changed.
6503 (string_buffer_position): Likewise. Also, make static (it's never
6504 used outside xdisp.c).
6505 (cursor_row_p): Remove parameter `w', unused since
6506 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
6507 (decode_mode_spec): Remove parameter `precision', introduced during
6508 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
6509 All callers changed.
6510
5ffb62aa
JD
65112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6512
6513 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
6514
461c2ab9 65152011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
6516
6517 * nsterm.m (ns_menu_bar_is_hidden): New variable.
6518 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
6519 (ns_update_auto_hide_menu_bar): New functions.
6520 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
6521 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
6522 ns_constrain_all_frames.
6523 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
6524 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
6525
5c380ffb
JD
65262011-03-27 Jan Djärv <jan.h.d@swipnet.se>
6527
6528 * nsmenu.m (runDialogAt): Remove argument to timer_check.
6529
9af30bdf
GM
65302011-03-27 Glenn Morris <rgm@gnu.org>
6531
6532 * syssignal.h: Replace RETSIGTYPE with void.
6533 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
6534 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
6535 Replace SIGTYPE with void everywhere.
6536 * s/usg5-4-common.h (SIGTYPE): Remove definition.
6537 * s/template.h (SIGTYPE): Remove commented out definition.
6538
e2abce01
JB
65392011-03-26 Eli Zaretskii <eliz@gnu.org>
6540
6541 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
6542 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
6543
f868cd8a
JB
65442011-03-26 Juanma Barranquero <lekktu@gmail.com>
6545
59eb0929
JB
6546 * w32.c (read_unc_volume): Use parameter `henum', instead of
6547 global variable `wget_enum_handle'.
6548
6549 * keymap.c (describe_vector): Remove parameters `indices' and
6550 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
6551 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
6552
f868cd8a
JB
6553 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
6554
6555 * keyboard.c (timer_check): Remove parameter `do_it_now',
6556 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
6557 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
6558 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
6559
6560 * keyboard.c (read_char):
6561 * w32menu.c (w32_menu_display_help):
6562 * xmenu.c (show_help_event, menu_help_callback):
6563 Adjust calls to `show_help_echo'.
6564
6565 * gtkutil.c (xg_maybe_add_timer):
6566 * keyboard.c (readable_events):
6567 * process.c (wait_reading_process_output):
6568 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
6569
6570 * insdel.c (adjust_markers_gap_motion):
6571 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
6572 (gap_left, gap_right): Don't call it.
6573
2ecf6fdb
CY
65742011-03-25 Chong Yidong <cyd@stupidchicken.com>
6575
6576 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
6577 incurred during fontification.
6578
6b1f9ba4
JB
65792011-03-25 Juanma Barranquero <lekktu@gmail.com>
6580
6581 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
6582 (DEFVAR_PER_BUFFER): Don't pass it.
6583
6584 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
6585 (scrolling_window): Don't pass it.
6586
0f4a96b5
JB
65872011-03-25 Juanma Barranquero <lekktu@gmail.com>
6588
6589 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
6590
6591 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
6592 and `suffix'.
6593 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
6594 of variables specific to SELinux and computation of `encoded_absname'.
6595
6596 * image.c (XPutPixel): Remove unused variable `height'.
6597
6598 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
6599
6600 * unexw32.c (get_section_info): Remove unused variable `section'.
6601
6602 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
6603 (system_process_attributes): Remove unused variable `sess'.
6604 (sys_read): Remove unused variable `err'.
6605
6606 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
6607 (w32_wnd_proc): Remove unused variable `isdead'.
6608 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
6609 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
6610 (x_create_tip_frame): Remove unused variable `tem'.
6611
6612 * w32inevt.c (w32_console_read_socket):
6613 Remove unused variable `no_events'.
6614
6615 * w32term.c (x_draw_composite_glyph_string_foreground):
6616 Remove unused variable `width'.
6617
1149507c
JB
66182011-03-24 Juanma Barranquero <lekktu@gmail.com>
6619
6620 * w32term.c (x_set_glyph_string_clipping):
6621 Don't pass uninitialized region to CombineRgn.
6622
9c88f339
JB
66232011-03-23 Juanma Barranquero <lekktu@gmail.com>
6624
6625 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
6626 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
6627 (Fx_close_connection): Remove unused variable `i'.
6628
6629 * w32font.c (w32font_draw): Return number of glyphs.
6630 (w32font_open_internal): Remove unused variable `i'.
6631 (w32font_driver): Add missing initializer.
6632
6633 * w32menu.c (utf8to16): Remove unused variable `utf16'.
6634 (fill_in_menu): Remove unused variable `items_added'.
6635
6636 * w32term.c (last_mouse_press_frame): Remove static global variable.
6637 (w32_clip_to_row): Remove unused variable `f'.
6638 (x_delete_terminal): Remove unused variable `i'.
6639
6640 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
6641 (NOTHING): Remove unused static global variable.
6642 (uniscribe_check_otf): Remove unused variable `table'.
6643 (uniscribe_font_driver): Add missing initializers.
6644
dee091a3
JD
66452011-03-23 Julien Danjou <julien@danjou.info>
6646
6647 * term.c (Fsuspend_tty, Fresume_tty):
6648 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
6649 * window.c (temp_output_buffer_show):
6650 * insdel.c (signal_before_change):
6651 * frame.c (Fhandle_switch_frame):
6652 * fileio.c (Fdo_auto_save):
6653 * emacs.c (Fkill_emacs):
6654 * editfns.c (save_excursion_restore):
6655 * cmds.c (internal_self_insert):
6656 * callint.c (Fcall_interactively):
6657 * buffer.c (Fkill_all_local_variables):
6658 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
6659 Use Frun_hooks.
0f4a96b5 6660 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
dee091a3
JD
6661 unconditionnaly since it does the check itself.
6662
2c520ab5 66632011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 6664
c9c49752
PE
6665 Fix more problems found by GCC 4.5.2's static checks.
6666
8abc3f12
PE
6667 * coding.c (encode_coding_raw_text): Avoid unnecessary test
6668 the first time through the loop, since we know p0 < p1 then.
6669 This also avoids a gcc -Wstrict-overflow warning.
6670
a2d26660
PE
6671 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
6672 leading to a memory leak, possible in functions like
6673 load_charset_map_from_file that can allocate an unbounded number
b12ef411 6674 of objects (Bug#8318).
a2d26660 6675
916c72e9
PE
6676 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
6677 that could (at least in theory) be that large.
6678
19ab8a18
PE
6679 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
6680 This is less likely to overflow, and avoids undefined behavior if
6681 overflow does occur. All callers changed. Use strtoul to scan
6682 for the unsigned long integer.
b7cbbd6f
PE
6683 (pint2hrstr): Simplify and tune code slightly.
6684 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 6685
f0641eff
PE
6686 * scroll.c (do_scrolling): Work around GCC bug 48228.
6687 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
6688
7f650bb9
PE
6689 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
6690 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
6691 (validate_x_resource_name): Simplify count usage.
6692 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 6693
37dd57d1
PE
6694 * fileio.c (Fcopy_file): Report error if fchown or fchmod
6695 fail (Bug#8306).
81e56e61 6696
699979fc 6697 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 6698
401bf9b4
PE
6699 * process.c (Fmake_network_process): Use socklen_t, not int,
6700 where POSIX says socklen_t is required in portable programs.
6701 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 6702 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
6703 (Fmake_network_process, server_accept_connection):
6704 (wait_reading_process_output, read_process_output):
6705 Likewise.
6706
b93aacde
PE
6707 * process.c: Rename or move locals to avoid shadowing.
6708 (list_processes_1, Fmake_network_process):
6709 (read_process_output_error_handler, exec_sentinel_error_handler):
6710 Rename or move locals.
4dc343ee 6711 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 6712 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 6713 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 6714 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 6715 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 6716
af8a867c 6717 Make tparam.h and terminfo.c consistent.
44f230aa
SM
6718 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
6719 Include tparam.h instead, since it declares them.
af8a867c
PE
6720 * cm.h (PC): Remove extern decl; tparam.h now does this.
6721 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
6722 * terminfo.c: Include tparam.h, to check interfaces.
6723 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
6724 (tparam): Adjust signature to match interface in tparam.h;
6725 this removes some undefined behavior. Check that outstring and len
6726 are zero, which they always are with Emacs.
6727 * tparam.h (PC, BC, UP): New extern decls.
6728
0248044d 6729 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 6730 (xftfont_open): Rename locals to avoid shadowing.
0248044d 6731
8ff096c1 6732 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
6733 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
6734 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 6735 (ftfont_list): Remove unused local.
49eaafba
PE
6736 (get_adstyle_property, ftfont_pattern_entity):
6737 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
6738 Rename locals to avoid shadowing.
8ff096c1 6739
e2be39f6
PE
6740 * xfont.c (xfont_list_family): Mark var as initialized.
6741
c9735e30
PE
6742 * xml.c (make_dom): Now static.
6743
8f5201ae
PE
6744 * composite.c (composition_compute_stop_pos): Rename local to
6745 avoid shadowing.
b246f932
PE
6746 (composition_reseat_it): Remove unused locals.
6747 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 6748 (composition_update_it): Mark var as initialized.
11b61122
PE
6749 (find_automatic_composition): Mark vars as initialized,
6750 with a FIXME (Bug#8290).
8f5201ae 6751
760fbc2c
PE
6752 character.h: Rename locals to avoid shadowing.
6753 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
6754 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
6755 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
6756 (BUF_DEC_POS): Be more systematic about renaming local temporaries
6757 to avoid shadowing.
6758
ff08eb85
PE
6759 * textprop.c (property_change_between_p): Remove; unused.
6760
fc7bf025
PE
6761 * intervals.c (interval_start_pos): Now static.
6762
235d7abc
PE
6763 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
6764
44f230aa
SM
6765 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
6766 Rename locals to avoid shadowing.
3e7d6594 6767
50060332
PE
6768 * sound.c (wav_play, au_play, Fplay_sound_internal):
6769 Fix pointer signedness.
d01f234b 6770 (alsa_choose_format): Remove unused local var.
c83b8872
PE
6771 (wav_play): Initialize a variable to 0, to prevent undefined
6772 behavior (Bug#8278).
50060332 6773
c4fc4e30
PE
6774 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
6775
918436ed
PE
6776 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
6777
c939f91b
PE
6778 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
6779 clobbering (Bug#8298).
b9c7f648
PE
6780 * sysdep.c (sys_subshell): Likewise.
6781 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 6782
6bd8c144
PE
6783 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
6784 This should get cleaned up, so that child_setup has the
6785 same signature on all platforms.
6786
7710357c 6787 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 6788 (relocate_fd): Rename locals to avoid shadowing.
7710357c 6789
c59da222
CY
67902011-03-22 Chong Yidong <cyd@stupidchicken.com>
6791
6792 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
6793 not to be necessary, and produces flickering.
6794
66b87493
GM
67952011-03-20 Glenn Morris <rgm@gnu.org>
6796
6797 * config.in: Remove file.
6798
45b6f6d5
JB
67992011-03-20 Juanma Barranquero <lekktu@gmail.com>
6800
6801 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
6802 are now in src/globals.h.
6803 (syms_of_minibuf): Remove spurious & from previous change.
6804
3ec03f7e
LL
68052011-03-20 Leo <sdl.web@gmail.com>
6806
6807 * minibuf.c (completing-read-function): New variable.
6808 (completing-read-default): Rename from completing-read.
6809 (completing-read): Call completing-read-function.
6810
b14e3e21
CY
68112011-03-19 Juanma Barranquero <lekktu@gmail.com>
6812
6813 * xfaces.c (Fx_load_color_file):
6814 Read color file from absolute filename (bug#8250).
6815
f2b726e6
JB
68162011-03-19 Juanma Barranquero <lekktu@gmail.com>
6817
6818 * makefile.w32-in: Update dependencies.
6819
09f6ff02
EZ
68202011-03-17 Eli Zaretskii <eliz@gnu.org>
6821
6822 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
6823
29a6015a
PE
68242011-03-17 Paul Eggert <eggert@cs.ucla.edu>
6825
a3a6c54e
PE
6826 Fix more problems found by GCC 4.5.2's static checks.
6827
b766f867
PE
6828 * process.c (make_serial_process_unwind, send_process_trap):
6829 (sigchld_handler): Now static.
6830
be02381c
PE
6831 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
6832 That way, the code declares only the vars that it needs.
6833 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
6834 * s/cygwin.h (PTY_ITERATION): Likewise.
6835 * s/darwin.h (PTY_ITERATION): Likewise.
6836 * s/gnu-linux.h (PTY_ITERATION): Likewise.
6837
57048744
PE
6838 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
6839 * process.c (allocate_pty): Don't declare stb unless it's needed.
6840
7914961c 6841 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
6842 (CONSTANTLIM): Remove; unused.
6843 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
6844 Define only if needed.
7914961c 6845
b3967b18
PE
6846 * unexelf.c (unexec): Name an expression,
6847 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
6848 Use a different way to cause a compilation error if anyone uses
6849 n rather than nn, a way that does not involve shadowing.
73366a00 6850 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 6851
29a6015a
PE
6852 * deps.mk (unexalpha.o): Remove; unused.
6853
43cfc33e 6854 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 6855 * unexec.h: New file.
ce701a33
PE
6856 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
6857 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
6858 Depend on unexec.h.
6859 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
6860 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
6861 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 6862 Change as necessary to match prototype in unexec.h.
ce701a33 6863
01f44d5a
PE
6864 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
6865 shadowing.
4f63c6bb 6866 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 6867
a6670b0b
PE
6868 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
6869 Rename locals to avoid shadowing.
6870
cef2010d 6871 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 6872 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 6873
d4d7173a
PE
6874 * print.c (Fredirect_debugging_output): Fix pointer signedess.
6875
f08b802a
PE
6876 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
6877 warning when compiling print.c.
6878
3ddb0639
PE
6879 * font.c (font_unparse_fcname): Abort in an "impossible" situation
6880 instead of using an uninitialized var.
5ad03b97 6881 (font_sort_entities): Mark var as initialized.
3ddb0639 6882
170a2692
PE
6883 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
6884
e663c700
PE
6885 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
6886 pointers to constants.
89bc529a 6887 (font_parse_fcname): Remove unused vars.
7b81e2d0 6888 (font_delete_unmatched): Now static.
ea838e10 6889 (font_get_spec): Remove; unused.
13a547c6
PE
6890 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
6891 (font_update_drivers, Ffont_get_glyphs, font_add_log):
6892 Rename or move locals to avoid shadowing.
e663c700 6893
2a80c887 6894 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 6895 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 6896
1384fa33 6897 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 6898 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 6899
8b2c52e9
PE
6900 * alloc.c (mark_backtrace): Move decl from here ...
6901 * lisp.h: ... to here, so that it can be checked.
6902
475545b5 6903 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 6904 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
6905 (lisp_indirect_variable): Name an expression,
6906 to avoid gcc -Wbad-function-cast warning.
1faed8ae 6907 (Fdefvar): Rename locals to avoid shadowing.
475545b5 6908
b1349114 6909 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 6910 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 6911 Use const pointer when appropriate.
b1349114 6912
a2928364
PE
6913 * lisp.h (get_system_name, get_operating_system_release):
6914 Move decls here, to check interfaces.
6915 * process.c (get_operating_system_release): Move decl to lisp.h.
6916 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
6917 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
6918 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
6919 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
6920 (Fformat_time_string, Fencode_time, Finsert_char):
6921 (Ftranslate_region_internal, Fformat):
6922 Rename or remove local vars to avoid shadowing.
9710023e 6923 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 6924
a415e694
PE
6925 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
6926 avoid shadowing.
6927
8ef4622d
PE
6928 * lisp.h (eassert): Check that the argument compiles, even if
6929 ENABLE_CHECKING is not defined.
6930
946f9a5b
PE
6931 * data.c (Findirect_variable): Name an expression, to avoid
6932 gcc -Wbad-function-cast warning.
112396d6 6933 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 6934 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
6935 (Fmake_variable_buffer_local, Fmake_local_variable):
6936 Mark variables as initialized.
52746918 6937 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 6938
e5aab7e7 6939 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
6940 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
6941 Rename locals to avoid shadowing.
dff45157
PE
6942 (mark_stack): Move local variables into the #ifdef region where
6943 they're used.
7bc26fdb
PE
6944 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
6945 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
6946 needed otherwise.
6947 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
6948 (GC_STRING_CHARS): Remove; not used.
d40d4be1 6949 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 6950
e5aab7e7
PE
6951 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
6952 avoids undefined behavior in theory.
6953
4da60324
PE
6954 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
6955
88043301
PE
6956 Use functions, not macros, for up- and down-casing (Bug#8254).
6957 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
6958 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
6959 to use the following functions instead of these macros.
6960 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
6961 EMACS_INT, since callers assume the returned value fits in int.
6962 (upcase1): Likewise, for UPCASE_TABLE.
6963 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 6964 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 6965 the race-condition problem in the old DOWNCASE.
88043301 6966
19ed5445
PE
6967 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
6968 Rename locals to avoid shadowing.
6969 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
6970 (regex_compile, re_search_2, re_match_2_internal):
6971 Remove unused local vars.
952db0d7
PE
6972 (FREE_VAR): Rewrite so as not to use empty "else",
6973 which gcc can warn about.
da053e48 6974 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
6975 (RETALLOC_IF): Define only if needed.
6976 (WORDCHAR_P): Likewise. This one is never needed, but is used
6977 only in a comment talking about a compiler bug, so put inside
6978 the #if 0 of that comment.
6979 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
6980 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
6981 Remove; unused.
19ed5445 6982
1f3561e4 6983 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
6984 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
6985 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 6986
ded6f8f7
PE
6987 * search.c (simple_search): Remove unused var.
6988
dbd37a95
PE
6989 * dired.c (compile_pattern): Move decl from here ...
6990 * lisp.h: ... to here, so that it can be checked.
6991 (struct re_registers): New forward decl.
6992
7e47afad
PE
6993 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
6994
85f24f61
PE
6995 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
6996 All uses changed.
6997 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
6998 Rename locals to avoid shadowing.
5671df8f 6999 (Fvertical_motion): Mark locals as initialized.
85f24f61 7000
181aa2be 7001 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 7002 (casify_region): Mark local as initialized.
181aa2be 7003
930d429c
PE
7004 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
7005
7082eac6
PE
7006 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
7007 New macros, so that the caller can use some names other than
7008 gcpro1, gcpro2, etc.
7009 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
7010 of the new macros.
7011 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
7012 argument, for consistency with GCPRO2_VAR, etc: it is now the
7013 prefix of the variable, not the variable itself. All uses
7014 changed.
38b2c076
PE
7015 * dired.c (directory_files_internal, file_name_completion):
7016 Rename locals to avoid shadowing.
7017
15206ed9
PE
7018 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
7019 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
7020 dired.c's scmp function, had undefined behavior.
7021 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
7022 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
7023 * buffer.h: ... to here, because these macros use current_buffer,
7024 and the new implementation with inline functions needs to have
7025 current_buffer in scope now, rather than later when the macros
7026 are used.
7027 (downcase, upcase1): New static inline functions.
7028 (DOWNCASE, UPCASE1): Reimplement using these functions.
7029 This avoids undefined behavior in expressions like
7030 DOWNCASE (x) == DOWNCASE (y), which previously suffered
7031 from race conditions in accessing the global variables
7032 case_temp1 and case_temp2.
7033 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
7034 * lisp.h (case_temp1, case_temp2): Remove their decls.
7035 * character.h (ASCII_CHAR_P): Move from here ...
7036 * lisp.h: ... to here, so that the inline functions mentioned
7037 above can use them.
7038
4a6bea26
PE
7039 * dired.c (directory_files_internal_unwind): Now static.
7040
f14b7e14
PE
7041 * fileio.c (file_name_as_directory, directory_file_name):
7042 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
7043 Now static.
2893f146
PE
7044 (file_name_as_directory): Use const pointers when appropriate.
7045 (Fexpand_file_name): Likewise. In particular, newdir might
7046 point at constant storage, so make it a const pointer.
fd4ead52 7047 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
7048 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
7049 signedness issues.
f839df0c
PE
7050 (Fset_file_times, Finsert_file_contents, auto_save_error):
7051 Rename locals to avoid shadowing.
f14b7e14 7052
5716756e 7053 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
7054 (Ftry_completion, Fall_completions): Rename or remove locals
7055 to avoid shadowing.
5716756e 7056
b4c3046a
PE
7057 * marker.c (bytepos_to_charpos): Remove; unused.
7058
b45db522
PE
7059 * lisp.h (verify_bytepos, count_markers): New decls,
7060 so that gcc does not warn that these functions aren't declared.
7061
85876d07
PE
7062 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
7063 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 7064 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 7065 (copy_text): Remove unused local var.
85876d07 7066
03d78a21 7067 * filelock.c (within_one_second): Now static.
b3dd38ab 7068 (lock_file_1): Rename local to avoid shadowing.
03d78a21 7069
5df8f01b
PE
7070 * buffer.c (fix_overlays_before): Mark locals as initialized.
7071 (fix_start_end_in_overlays): Likewise. This function should be
7072 simplified by using pointers-to-pointers, but that's a different
7073 matter.
b1d876f1 7074 (switch_to_buffer_1): Now static.
8f54f30a
PE
7075 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
7076 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 7077
a70072c9 7078 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 7079 Fix pointer signedness issue.
edced198
PE
7080 (sys_subshell): Mark local as volatile if checking for lint,
7081 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 7082 (MAXPATHLEN): Define only if needed.
a70072c9 7083
a0977c44
PE
7084 * process.c (serial_open, serial_configure): Move decls from here ...
7085 * systty.h: ... to here, so that they can be checked.
7086
a884fdcc
PE
7087 * fns.c (get_random, seed_random): Move extern decls from here ...
7088 * lisp.h: ... to here, so that they can be checked.
7089
604efe86 7090 * sysdep.c (reset_io): Now static.
b8950c94 7091 (wait_for_termination_signal): Remove; unused.
604efe86 7092
38fc62d9
PE
7093 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
7094 (copy_keymap_item, append_key, push_text_char_description):
7095 Now static.
1004a21a 7096 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 7097 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
7098 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
7099 (describe_map_tree):
7100 Rename locals to avoid shadowing.
38fc62d9 7101
2f2650da
PE
7102 * keyboard.c: Declare functions static if they are not used elsewhere.
7103 (echo_char, echo_dash, cmd_error, top_level_2):
7104 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
7105 (read_char, kbd_buffer_get_event, make_lispy_position):
7106 (make_lispy_event, make_lispy_movement, apply_modifiers):
7107 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
7108 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
7109 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 7110 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 7111 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 7112
a053e86c 7113 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
7114 (mark_kboards): Move decl here ...
7115 * alloc.c (mark_kboards): ... from here.
a053e86c 7116
4752793e
PE
7117 * lisp.h (force_auto_save_soon): New decl.
7118
74f10ca7 7119 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
7120 (DEFINE_DUMMY_FUNCTION): New macro.
7121 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
7122 Use it.
c03cd23f
PE
7123 (main): Add casts to avoid warnings
7124 if GCC considers string literals to be constants.
74f10ca7 7125
022e70d4
PE
7126 * lisp.h (fatal_error_signal): Add decl, since it's exported.
7127
59d6fe83
PE
7128 * dbusbind.c: Pointer signedness fixes.
7129 (xd_signature, xd_append_arg, xd_initialize):
7130 (Fdbus_call_method, Fdbus_call_method_asynchronously):
7131 (Fdbus_method_return_internal, Fdbus_method_error_internal):
7132 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
7133 (Fdbus_register_signal): Use SSDATA when the context wants char *.
7134
78320123
PE
7135 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
7136 if GCC considers string literals to be constants.
49cebcca 7137 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 7138
35ac2a97
SM
71392011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
7140
fb103ca9
SM
7141 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
7142 (print_preprocess, print_object): New macro to fix last change.
7143
35ac2a97
SM
7144 * print.c (print_preprocess): Don't forget font objects.
7145
62973b41
JB
71462011-03-16 Juanma Barranquero <lekktu@gmail.com>
7147
7148 * emacs.c (USAGE3): Doc fixes.
7149
0e48bb22
AS
71502011-03-15 Andreas Schwab <schwab@linux-m68k.org>
7151
7152 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
7153 structure.
7154
7684e57b
JB
71552011-03-14 Juanma Barranquero <lekktu@gmail.com>
7156
7157 * lisp.h (VWindow_system, Qfile_name_history):
7158 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
7159 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
7160 (w32_system_caret_x, w32_system_caret_y): Declare extern.
7161
7162 * w32select.c: Don't #include "keyboard.h".
c96bbc66 7163 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
7164
7165 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
7166 * w32console.c (detect_input_pending, read_input_pending)
7167 (encode_terminal_code):
7168 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
7169 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
7170 (w32_system_caret_y, Qfile_name_history):
7171 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
7172 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
7173 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
7174 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
7175 * w32proc.c (Qlocal, report_file_error):
7176 * w32term.c (Vwindow_system, updating_frame):
7177 * w32uniscribe.c (initialized, uniscribe_font_driver):
7178 Remove unneeded extern declarations.
7179
2aa46d6c
CY
71802011-03-14 Chong Yidong <cyd@stupidchicken.com>
7181
c96bbc66 7182 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 7183
cffc6f3b
CY
71842011-03-13 Chong Yidong <cyd@stupidchicken.com>
7185
7186 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
7187 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
7188 These macros can no longer be used for assignment.
7189
44f230aa
SM
7190 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
7191 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
7192 (record_buffer_markers, fetch_buffer_markers): New functions for
7193 recording and fetching special buffer markers.
7194 (set_buffer_internal_1, set_buffer_temp): Use them.
7195
7196 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
7197
7198 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
7199
7200 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
7201 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
7202
7203 * xdisp.c (hscroll_window_tree):
7204 (reconsider_clip_changes): Use PT instead of BUF_PT.
7205
d251f04b
EZ
72062011-03-13 Eli Zaretskii <eliz@gnu.org>
7207
7208 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
7209 $(EMACS_ROOT)/lib/intprops.h.
7210
f0c77cd1
PE
72112011-03-13 Paul Eggert <eggert@cs.ucla.edu>
7212
3eca4629
PE
7213 Fix more problems found by GCC 4.5.2's static checks.
7214
7c86ee98
PE
7215 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
7216 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
7217 (xg_free_frame_widgets): Make it clear that a local variable is
7218 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
7219 (gdk_window_get_screen): Make it clear that this macro is needed
7220 only if USE_GTK_TOOLTIP.
1e5524e7
PE
7221 (int_gtk_range_get_value): New function, which avoids a diagnostic
7222 from gcc -Wbad-function-cast.
7223 (xg_set_toolkit_scroll_bar_thumb): Use it.
7224 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
7225 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
7226 (get_utf8_string, xg_get_file_with_chooser):
7227 Rename locals to avoid shadowing.
7228 (create_dialog): Move locals to avoid shadowing.
7c86ee98 7229
41729b81
PE
7230 * xgselect.c (xg_select): Remove unused var.
7231
f0c77cd1
PE
7232 * image.c (four_corners_best): Mark locals as initialized.
7233 (gif_load): Initialize transparent_p to zero (Bug#8238).
7234 Mark another local as initialized.
ec6cf4c6 7235 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 7236
ce0ad53d 7237 * image.c (clear_image_cache): Now static.
d5d5a617 7238 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 7239 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
7240 (x_edge_detection): Remove unnecessary cast that
7241 gcc -Wbad-function-cast diagnoses.
2037898d 7242 (gif_load): Fix pointer signedness.
6ae141d6
PE
7243 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
7244 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 7245
33383987 72462011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 7247
d32df629
PE
7248 Improve quality of tests for time stamp overflow.
7249 For example, without this patch (encode-time 0 0 0 1 1
7250 1152921504606846976) returns the obviously-bogus value (-948597
7251 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
7252 reports time overflow. See
7253 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
7254 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
7255 * editfns.c: Include limits.h and intprops.h.
7256 (TIME_T_MIN, TIME_T_MAX): New macros.
7257 (time_overflow): Move earlier, to before first use.
7258 (hi_time, lo_time): New functions, for an accurate test for
7259 out-of-range times.
7260 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
7261 (Fget_internal_run_time): Don't assume time_t fits in int.
7262 (make_time): Use list2 instead of Fcons twice.
7263 (Fdecode_time): More accurate test for out-of-range times.
7264 (check_tm_member): New function.
7265 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
7266 (lisp_time_argument): Don't rely on undefined left-shift and
7267 right-shift behavior when checking for time stamp overflow.
8be6f318 7268
fe31d94c
PE
7269 * editfns.c (time_overflow): New function, refactoring common code.
7270 (Fformat_time_string, Fdecode_time, Fencode_time):
7271 (Fcurrent_time_string): Use it.
7272
8be6f318
PE
7273 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
7274 * dired.c (make_time): Move to ...
7275 * editfns.c (make_time): ... here.
7276 * systime.h: Note the move.
7277
09d9db2c 72782011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 7279
126bc0dc
YM
7280 * fringe.c (update_window_fringes): Remove unused variables.
7281
c47cbdfd
YM
7282 * unexmacosx.c (copy_data_segment): Also copy __got section.
7283 (Bug#8223)
7284
7ac80be9
EZ
72852011-03-12 Eli Zaretskii <eliz@gnu.org>
7286
c96bbc66 7287 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
7288 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
7289 Constify `char *' arguments and their references according to
7290 prototypes in tparam.h.
7291
ecb0f94d 7292 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 7293
7ac80be9
EZ
7294 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
7295 Adapt all references accordingly.
7296
7297 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
7298
ef1fd07e
TT
72992011-03-11 Tom Tromey <tromey@redhat.com>
7300
7301 * buffer.c (syms_of_buffer): Remove obsolete comment.
7302
7ef4b50c
EZ
73032011-03-11 Eli Zaretskii <eliz@gnu.org>
7304
7305 * termhooks.h (encode_terminal_code): Declare prototype.
7306
7307 * msdos.c (encode_terminal_code): Don't declare prototype.
7308
7309 * term.c (encode_terminal_code): Now external again, used by
7310 w32console.c and msdos.c.
7311
44f230aa
SM
7312 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
7313 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 7314
4b1ec863 73152011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 7316
1714f52b 7317 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 7318
4b1ec863
PE
7319 * fringe.c (update_window_fringes): Mark locals as initialized
7320 (Bug#8227).
7321 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 7322
524c7aa6
PE
7323 * alloc.c (mark_fringe_data): Move decl from here ...
7324 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
7325 to check its interface.
7326 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
7327
a5c0af81 7328 * fontset.c (free_realized_fontset): Now static.
7519b8cd 7329 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 7330 (fontset_font): Mark local as initialized.
a9a06e0b 7331 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 7332
b4716021
PE
7333 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
7334
811e9bac 7335 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 7336 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
7337 (x_own_selection, Fx_disown_selection_internal): Rename locals
7338 to avoid shadowing.
7339 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 7340
7e3ab302
PE
7341 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
7342 so that the caller can use some name other than gcpro1.
7343 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
7344 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7345 (Fx_backspace_delete_keys_p):
7346 Use them to avoid shadowing, and rename vars to avoid shadowing.
7347 (x_decode_color, x_set_name, x_window): Now static.
6b437900 7348 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 7349 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
7350 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
7351 Remove unused locals.
7e3ab302
PE
7352 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
7353 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
7354 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
7355 macros.
f78faa98 7356
e2b13473
PE
7357 * xterm.h (x_mouse_leave): New decl.
7358
77f23912
PE
7359 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
7360 Remove unused functions.
cdf4ba58
PE
7361 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
7362 (x_calc_absolute_position): Now static.
7411c686 7363 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 7364 Don't declare local "event" unless it's used.
ed7bf3a5
PE
7365 (x_iconify_frame, x_free_frame_resources): Don't declare locals
7366 unless they are used.
38d0b34a
PE
7367 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
7368 (x_fatal_error_signal): Remove; not used.
a6067996
PE
7369 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
7370 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
7371 (x_error_catcher, x_connection_closed, x_error_handler):
7372 (x_error_quitter, xembed_send_message, x_iconify_frame):
7373 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 7374 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 7375 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 7376
44f230aa
SM
7377 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
7378 Rename or move locals to avoid shadowing.
6b463e58 7379 (tty_defined_color, merge_face_heights): Now static.
5967d051 7380 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
7381 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
7382 does not deduce is never used uninitialized.
73719eba
PE
7383 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
7384 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 7385
426994c3 7386 * terminal.c (store_terminal_param): Now static.
5489860b 7387
032f1620 7388 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 7389 (set_frame_menubar): Remove unused local.
d4323972 7390 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
7391 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
7392 since they might point to immutable storage.
281585b0
PE
7393 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
7394 since it's unused otherwise.
032f1620 7395
367c19e5 7396 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 7397 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
7398 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
7399 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 7400 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
7401 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
7402 does not deduce are never used uninitialized.
70739cbe 7403
07b48fa9
PE
7404 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
7405
8868a238 7406 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
7407 * window.c (window_loop, size_window):
7408 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 7409
7e5cf297 7410 * window.c (display_buffer): Now static.
d6550a9f
PE
7411 (size_window): Mark variables that gcc -Wuninitialized
7412 does not deduce are never used uninitialized.
a586633d
PE
7413 * window.h (check_all_windows): New decl, to forestall
7414 gcc -Wmissing-prototypes diagnostic.
5b555da1 7415 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 7416
f6095868
PE
7417 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
7418 shadowing.
7419 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
7420 Include <limits.h>.
7421 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
7422 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
7423 (load_charset_map): Mark variables that gcc -Wuninitialized
7424 does not deduce are never used uninitialized.
53df7c11 7425 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 7426
f38b440c
PE
7427 * coding.c (coding_set_source, coding_set_destination):
7428 Use "else { /* comment */ }" rather than "else /* comment */;"
7429 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
7430 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
7431 a block, when the outer 'i' will do.
7432 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
7433 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
7434 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
7435 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
7436 (Fdecode_sjis_char, Fdefine_coding_system_internal):
7437 Rename locals to avoid shadowing.
7438 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
7439 * coding.c (emacs_mule_char, encode_invocation_designation):
7440 Now static, since they're not used elsewhere.
413bb2db 7441 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 7442 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
7443 (decode_coding_emacs_mule): Mark variables that gcc
7444 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
7445 (detect_coding_iso_2022): Initialize a local variable that might
7446 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 7447 this initialization is needed. (Bug#8211)
5f58e762
PE
7448 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
7449 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
7450 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
7451 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
7452 Remove unused macros.
f38b440c 7453
232b38b9 7454 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 7455 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 7456 * character.c (string_count_byte8): Likewise.
232b38b9 7457
fb90da1b
PE
7458 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
7459 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
7460
fb93dbc2
PE
7461 * chartab.c (copy_sub_char_table): Now static, since it's not used
7462 elsewhere.
5c156ace
PE
7463 (sub_char_table_ref_and_range, char_table_ref_and_range):
7464 Rename locals to avoid shadowing.
bbcd0949 7465 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 7466
7d3b3862 7467 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 7468 (BIDI_BOB): Remove unused macro.
7d3b3862 7469
6be7d3da
PE
7470 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
7471 deduce are never used uninitialized.
c2ed9c8b 7472 * term.c (encode_terminal_code): Likewise.
6be7d3da 7473
75f8807f 7474 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 7475
50938595
PE
7476 * tparam.h: New file.
7477 * term.c, tparam.h: Include it.
7478 * deps.mk (term.o, tparam.o): Depend on tparam.h.
7479 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
7480 Move these decls to tparam.h, and make them agree with what
7481 is actually in tparam.c. The previous trick of using incompatible
7482 decls in different modules does not conform to the C standard.
7483 All callers of tparam changed to use tparam's actual API.
7484 * tparam.c (tparam1, tparam, tgoto):
7485 Use const pointers where appropriate.
7486
fbceeba2
PE
7487 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
7488 * cm.h (struct cm): Likewise.
7489 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
7490 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
7491 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
7492 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
7493 (turn_on_face, init_tty): Likewise.
7494 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 7495
7f3f1250
PE
7496 * term.c (term_mouse_position): Rename local to avoid shadowing.
7497
e6ca6543
PE
7498 * alloc.c (mark_ttys): Move decl from here ...
7499 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
7500
c40f8d15
AS
75012011-03-11 Andreas Schwab <schwab@linux-m68k.org>
7502
7503 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
7504
cfe0661d
JB
75052011-03-09 Juanma Barranquero <lekktu@gmail.com>
7506
7507 * search.c (compile_pattern_1): Remove argument regp, unused since
7508 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
7509 (compile_pattern): Don't pass it.
7510
0afb4571
J
75112011-03-08 Jan Djärv <jan.h.d@swipnet.se>
7512
7513 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
7514 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
7515 for ! HAVE_GTK3.
7516 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
7517
7518 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
7519
7520 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
7521 gdk_window_get_screen, gdk_window_get_geometry,
7522 gdk_x11_window_lookup_for_display and GDK_KEY_g.
7523 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
7524 (xg_get_pixbuf_from_pixmap): New function.
7525 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
7526 to Pixmap, take frame as parameter, remove GdkColormap parameter.
7527 Call xg_get_pixbuf_from_pixmap instead of
7528 gdk_pixbuf_get_from_drawable.
7529 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
7530 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
7531 (xg_check_special_colors): Use GtkStyleContext and its functions
7532 for HAVE_GTK3.
7533 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
7534 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
7535 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
7536 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
7537 Call gtk_widget_get_preferred_size.
0afb4571
J
7538 (xg_frame_resized): gdk_window_get_geometry only takes 5
7539 parameters.
44f230aa
SM
7540 (xg_win_to_widget, xg_event_is_for_menubar):
7541 Call gdk_x11_window_lookup_for_display.
0afb4571
J
7542 (xg_set_widget_bg): New function.
7543 (delete_cb): New function.
895009e1 7544 (xg_create_frame_widgets): Connect delete-event to delete_cb.
0afb4571
J
7545 Call xg_set_widget_bg. Only set backgrund pixmap for ! HAVE_GTK3
7546 (xg_set_background_color): Call xg_set_widget_bg.
7547 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
7548 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
7549 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
7550 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
7551 if ! HAVE_GTK3.
7552 (update_frame_tool_bar): Call gtk_widget_hide.
7553 (xg_initialize): Use GDK_KEY_g.
7554
7555 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
7556 if ! HAVE_GTK3
7557 (x_session_initialize): Call gdk_x11_set_sm_client_id.
7558
7559 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
7560 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
7561 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
7562
1c2cc4ef
JB
75632011-03-08 Juanma Barranquero <lekktu@gmail.com>
7564
7565 * w32xfns.c (select_palette): Check success of RealizePalette against
7566 GDI_ERROR, not zero.
7567
33383987 7568See ChangeLog.11 for earlier changes.
aac0c6e3
MR
7569
7570;; Local Variables:
7571;; coding: utf-8
aac0c6e3
MR
7572;; End:
7573
33383987 7574 Copyright (C) 2011 Free Software Foundation, Inc.
aac0c6e3
MR
7575
7576 This file is part of GNU Emacs.
7577
7578 GNU Emacs is free software: you can redistribute it and/or modify
7579 it under the terms of the GNU General Public License as published by
7580 the Free Software Foundation, either version 3 of the License, or
7581 (at your option) any later version.
7582
7583 GNU Emacs is distributed in the hope that it will be useful,
7584 but WITHOUT ANY WARRANTY; without even the implied warranty of
7585 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
7586 GNU General Public License for more details.
7587
7588 You should have received a copy of the GNU General Public License
7589 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.