* lisp/emulation/cua-base.el (cua--pre-command-handler-1): Don't activate
[bpt/emacs.git] / src / ChangeLog
CommitLineData
c25df26e
RT
12012-04-13 Reuben Thomas <rrt@sc3d.org>
2
3 * indent.c (Fmove_to_column): Change interactive spec (Bug#739).
4
0fc59f1e
DC
52012-04-11 Daniel Colascione <dancol@dancol.org>
6
7 * s/cygwin.h: The vfork the #define in cygwin.h was protecting
8 against is gone. It's better to use vfork now so that when Cygwin
9 gains a new, working vfork, we use it automatically (bug#10398).
10
de8c03dc
SM
112012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
12
13 * window.c (save_window_save): Obey window-point-insertion-type.
14
2f097256
GM
152012-04-11 Glenn Morris <rgm@gnu.org>
16
17 * Makefile.in (GNUSTEP_CFLAGS): Rename from C_SWITCH_X_SYSTEM.
18
453b951e
SM
192012-04-11 Stefan Monnier <monnier@iro.umontreal.ca>
20
21 * alloc.c (lisp_align_malloc): Remove unneeded prototype.
22
6bbef4e5
JC
232012-04-10 "Jason S. Cornez" <jcornez@ravenpack.com> (tiny change)
24
25 * keyboard.c: Override inhibit-quit after the third C-g (bug#6585).
26 (force_quit_count): New var.
27 (handle_interrupt): Use it.
28
2a8ce227
JB
292012-04-10 Juanma Barranquero <lekktu@gmail.com>
30
31 * w32.c (w32_delayed_load): Record the full path of the library
32 being loaded (bug#10424).
33
935396c0
GM
342012-04-09 Glenn Morris <rgm@gnu.org>
35
05920a43
GM
36 * doc.c (Fsnarf_documentation): Check variables, functions are bound,
37 not just in the obarray, before snarfing them. (Bug#11036)
38
935396c0
GM
39 * Makefile.in ($(leimdir)/leim-list.el):
40 Pass EMACS rather than BUILT_EMACS.
41
a18ecafa
TZ
422012-04-09 Teodor Zlatanov <tzz@lifelogs.com>
43
44 * process.c (make_process):
45 * process.h: Add integer `gnutls_handshakes_tried' member to
46 process struct.
47
6bbef4e5
JC
48 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
49 Add convenience `GNUTLS_LOG2i' macro.
a18ecafa
TZ
50
51 * gnutls.c (gnutls_log_function2i): Convenience log function.
52 (emacs_gnutls_read): Use new log functions,
53 `gnutls_handshakes_tried' process member, and
54 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
55 attempts per process (connection).
56
b4d3bc10
CY
572012-04-09 Chong Yidong <cyd@gnu.org>
58
59 * eval.c (Fuser_variable_p, user_variable_p_eh)
60 (lisp_indirect_variable): Functions deleted.
61 (Fdefvar): Caller changed.
62
63 * callint.c (Finteractive, Fcall_interactively):
64 * minibuf.c (Fread_variable): Callers changed.
65
70f4d973
EZ
662012-04-09 Eli Zaretskii <eliz@gnu.org>
67
68 * xdisp.c (set_cursor_from_row): If the display string appears in
69 the buffer at position that is closer to point than the position
70 after the display string, display the cursor on the first glyph of
71 the display string. Fixes cursor display when a 'display' text
72 property immediately follows invisible text. (Bug#11094)
73
cb3c2e3e
PE
742012-04-09 Paul Eggert <eggert@cs.ucla.edu>
75
76 composite.c: use 'double' consistently
77 * composite.c (get_composition_id): Use 'double' consistently
78 instead of converting 'float' to 'double' and vice versa; this is
79 easier to understand and avoids a GCC warning.
80
fd06db5d
GM
812012-04-09 Glenn Morris <rgm@gnu.org>
82
50fe702a
GM
83 * Makefile.in: Generate leim-list with bootstrap-emacs, in
84 preparation for dumping it with emacs. (Bug#4789)
85 (leimdir): New variable.
86 ($(leimdir)/leim-list.el): New rule.
87 (emacs$(EXEEXT)): Depend on leim-list.el.
88
fd06db5d
GM
89 * buffer.c (Qucs_set_table_for_input): Remove. (Bug#9821)
90 (Fget_buffer_create): Don't call Qucs_set_table_for_input.
91 (init_buffer_once, syms_of_buffer): Remove Qucs_set_table_for_input.
92
55c131ee
AS
932012-04-08 Andreas Schwab <schwab@linux-m68k.org>
94
95 * lisp.h (struct Lisp_Symbol): Add explicit padding to ensure
96 proper alignment.
97
9209588f
JB
982012-04-07 Juanma Barranquero <lekktu@gmail.com>
99
100 * xml.c (init_libxml2_functions) [WINDOWSNT]:
101 Remove unused local variable.
102
e3fb2efb
PE
1032012-04-07 Paul Eggert <eggert@cs.ucla.edu>
104
105 Avoid unnecessary pointer scanning in garbage collection (Bug#10780).
106 * alloc.c (POINTERS_MIGHT_HIDE_IN_OBJECTS): New macro.
107 (mark_memory): Mark Lisp_Objects only if pointers might hide in
108 objects, as mark_maybe_pointer will catch them otherwise.
109 (GC_LISP_OBJECT_ALIGNMENT): Remove; no longer needed.
110 * s/gnu-linux.h (GC_LISP_OBJECT_ALIGNMENT) [__mc68000__]: Likewise.
111
b5385551
PE
1122012-04-07 Paul Eggert <eggert@cs.ucla.edu>
113
114 Fix typo that broke non-Windows builds.
115 * xml.c (libxml2_loaded_p) [!!WINDOWSNT]: 'inine' -> 'inline'.
116
9078ead6
EZ
1172012-04-07 Eli Zaretskii <eliz@gnu.org>
118
119 Support building on MS-Windows with libxml2.
120
121 * makefile.w32-in (OBJ2): Add xml.$(O).
122 (GLOBAL_SOURCES): Add xml.c.
123 ($(BLD)/xml.$(O)): New dependency list.
124
125 * xml.c (DEF_XML2_FN, LOAD_XML2_FN) [WINDOWSNT]: New macros.
126 (fn_htmlReadMemory, fn_xmlReadMemory, fn_xmlDocGetRootElement)
127 (fn_xmlFreeDoc, fn_xmlCleanupParser, fn_xmlCheckVersion)
128 [!WINDOWSNT]: New macros.
129 (init_libxml2_functions, libxml2_loaded_p): New functions.
130 (parse_region): Call fn_xmlCheckVersion instead of using the macro
131 LIBXML_TEST_VERSION. Call libxml2 functions via the fn_* macros.
132 (xml_cleanup_parser): New function, export for fn_xmlCleanupParser.
133 Calls xmlCleanupParser only if libxml2 was loaded (or statically
134 linked in).
6bbef4e5
JC
135 (Flibxml_parse_html_region, Flibxml_parse_xml_region):
136 Call init_libxml2_functions before calling libxml2 functions.
9078ead6
EZ
137 (syms_of_xml) <Qlibxml2_dll>: DEFSYM it.
138
139 * emacs.c: Don't include libxml/parser.h.
140 (shut_down_emacs): Call xml_cleanup_parser, instead of calling
141 xmlCleanupParser directly.
142
143 * lisp.h [HAVE_LIBXML2]: Add prototype for xml_cleanup_parser.
144
3811fdf3
EZ
1452012-04-07 Eli Zaretskii <eliz@gnu.org>
146
147 * indent.c (Fvertical_motion): If there is a display string at
148 point, use it.vpos to compute how many lines to backtrack after
149 move_it_to point. (Bug#11133)
150
2f8e16b2
EZ
1512012-04-06 Eli Zaretskii <eliz@gnu.org>
152
153 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
154 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
155 about subtle differences between FETCH_CHAR* and STRING_CHAR*
156 macros related to unification of CJK characters. For the details,
157 see the discussion following the message here:
158 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
159
3d439cd1
CY
1602012-04-04 Chong Yidong <cyd@gnu.org>
161
162 * keyboard.c (Vdelayed_warnings_list): Doc fix.
163
8bc53d00
EZ
1642012-04-01 Eli Zaretskii <eliz@gnu.org>
165
166 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
167 instead of alloca. (Bug#11138)
168
3b0512a3
AS
1692012-04-01 Andreas Schwab <schwab@linux-m68k.org>
170
171 * w32menu.c (is_simple_dialog): Properly check lisp types.
172 (Bug#11141)
173
8427ddd2
EZ
1742012-03-31 Eli Zaretskii <eliz@gnu.org>
175
979022ef
EZ
176 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
177 position we get to after a call to move_it_to fails the
178 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
179 only if we wind up in a string from display property. (Bug#11063)
180
a6b1c7cc
EZ
181 * window.c (Fdelete_other_windows_internal): Invalidate the row
182 and column information about mouse highlight, so that redisplay
183 restores it after reallocating the glyph matrices. (Bug#7464)
184
8427ddd2
EZ
185 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
186 string comes from a `display' text property, use the buffer
187 position of that property as if we actually saw that position in
188 the row's glyphs.
697ba24b
EZ
189 (move_it_by_lines): Remove the assertion that
190 "it->current_x == 0 && it->hpos == 0" which can be legitimately
191 violated when there's a before-string at the beginning of a line.
192 (Bug#11063)
8427ddd2 193
65a0a738
EZ
1942012-03-30 Eli Zaretskii <eliz@gnu.org>
195
196 * xdisp.c (append_space_for_newline): If the default face was
197 remapped, use the remapped face for the appended newline.
198 (extend_face_to_end_of_line): Use the remapped default face for
199 extending the face to the end of the line.
200 (display_line): Call extend_face_to_end_of_line when the default
201 face was remapped. (Bug#11068)
202
581355cc
EZ
2032012-03-29 Eli Zaretskii <eliz@gnu.org>
204
205 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
206
e8fc049f
SM
2072012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
208
209 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
210
4fb9a543
GM
2112012-03-27 Glenn Morris <rgm@gnu.org>
212
213 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
214 Doc fixes.
215
679910f1
KH
2162012-03-26 Kenichi Handa <handa@m17n.org>
217
218 * dispextern.h (struct glyph): Fix previous change. Change the
219 bit length of glyphless.ch to 25 (Bug#11082).
220
90d49b7f
CY
2212012-03-26 Chong Yidong <cyd@gnu.org>
222
223 * keyboard.c (Vselection_inhibit_update_commands): New variable.
224 (command_loop_1): Use it; inhibit selection update for
225 handle-select-window too (Bug#8996).
226
f514f6f0
FP
2272012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
228
e8fc049f 229 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 230
bf43fa51
KH
2312012-03-25 Kenichi Handa <handa@m17n.org>
232
233 * dispextern.h (struct glyph): Change the bit length of
234 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
235
8a0c01dd
EZ
2362012-03-24 Eli Zaretskii <eliz@gnu.org>
237
238 * s/ms-w32.h (tzname): Include time.h before redirecting to
239 _tzname. Fixes the MSVC build. (Bug#9960)
240
7d1c3a76
AS
2412012-03-24 Andreas Schwab <schwab@linux-m68k.org>
242
8ed79523
AS
243 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
244 characters.
245
7d1c3a76
AS
246 * xterm.c (XTread_socket): Only modify handling_signal if
247 !SYNC_INPUT. (Bug#11080)
248
e99a9b8b
EZ
2492012-03-23 Eli Zaretskii <eliz@gnu.org>
250
251 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
252 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
253 when fetching a multibyte character consumes more bytes than
254 CHAR_BYTES returns, due to unification of CJK characters in
255 string_char. (Bug#11073)
256
5063c0e1
TN
2572012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
258
259 * process.c (wait_reading_process_output): Handle pty disconnect
260 by refraining from sending oneself a SIGCHLD (bug#10933).
261
9f851fbd
CY
2622012-03-22 Chong Yidong <cyd@gnu.org>
263
264 * dispextern.h (struct it): New member string_from_prefix_prop_p.
265
5063c0e1 266 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
267 Mark string as coming from a prefix property.
268 (handle_face_prop): Use default face for prefix strings (Bug#4281).
269 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
270
fb5b8aca
CY
2712012-03-21 Chong Yidong <cyd@gnu.org>
272
273 * xfaces.c (Vface_remapping_alist): Doc fix.
274
62356a1b
EZ
2752012-03-20 Eli Zaretskii <eliz@gnu.org>
276
277 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
278 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
279 Doc fixes.
62356a1b 280
025de85b
CY
2812012-03-20 Chong Yidong <cyd@gnu.org>
282
283 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
284 to reflect default non-nil value of redisplay-dont-pause.
285
4827f94e
KH
2862012-03-19 Kenichi Handa <handa@m17n.org>
287
288 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
289 it fit in a valid range (Bug#11003).
290
e50a24a2
EZ
2912012-03-18 Eli Zaretskii <eliz@gnu.org>
292
293 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
294 that is not from display property, accept the row as a "cursor
295 row" if one of the string's character has a non-nil `cursor'
296 property. Fixes cursor positioning when there are newlines in
297 overlay strings, e.g. in icomplete.el. (Bug#11035)
298
9af5ed87
PE
2992012-03-12 Paul Eggert <eggert@cs.ucla.edu>
300
301 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
302
d1f55f16
CY
3032012-03-12 Chong Yidong <cyd@gnu.org>
304
305 * eval.c (inhibit_lisp_code): Rename from
306 inhibit_window_configuration_change_hook; move from window.c.
307
308 * xfns.c (unwind_create_frame_1, Fx_create_frame):
309 * window.c (run_window_configuration_change_hook)
310 (syms_of_window): Callers changed.
311
66c5eebd
CY
3122012-03-11 Chong Yidong <cyd@gnu.org>
313
413df973
CY
314 * keymap.c (Fkey_description): Doc fix (Bug#9700).
315
66c5eebd
CY
316 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
317
1de11f56
CY
3182012-03-10 Chong Yidong <cyd@gnu.org>
319
320 * frame.c (other_visible_frames): Don't assume the selected frame
321 is visible (Bug#10955).
322
cae07000
SM
3232012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
324
325 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
326
89c94350
JD
3272012-03-08 Jan Djärv <jan.h.d@swipnet.se>
328
329 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
330 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
331 zero (Bug#10954).
332
999dd333
GM
3332012-03-03 Glenn Morris <rgm@gnu.org>
334
01a6dcc8 335 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 336
de0100f2
EZ
3372012-03-02 Eli Zaretskii <eliz@gnu.org>
338
339 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
340 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
341 (redisplay_window, next_element_from_string): Fix typos in
342 comments.
3e441275
EZ
343 (redisplay_window): Pass to move_it_vertically the margin in
344 pixels, not in screen lines.
de0100f2 345
96a72ee9
GM
3462012-03-02 Glenn Morris <rgm@gnu.org>
347
348 * buffer.c (buffer-list-update-hook): Doc fix.
349
312508d7
EZ
3502012-02-29 Eli Zaretskii <eliz@gnu.org>
351
352 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
353 push_it before setting up the iterator for the first overlay
354 string, even if we have an empty string loaded.
355 (next_overlay_string): If there's an empty string on the iterator
356 stack, pop the stack. (Bug#10903)
357
27f3c637
PE
3582012-02-25 Paul Eggert <eggert@cs.ucla.edu>
359
360 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
361 Suggested by Stefan Monnier in
362 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
363 * alloc.c (widen_to_Lisp_Object): New static function.
364 (mark_memory): Also mark Lisp_Objects by fetching pointer words
365 and widening them to Lisp_Objects. This would work even if
366 USE_LSB_TAG is defined and wide integers are used, which might
367 happen in a future version of Emacs.
368
3c9dfce6
CY
3692012-02-25 Chong Yidong <cyd@gnu.org>
370
fa74b241
CY
371 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
372 Doc fix.
373
3c9dfce6
CY
374 * xselect.c (Fx_selection_exists_p): Doc fix.
375 (x_clipboard_manager_save_all): Print an informative message
376 before saving to clipboard manager.
377
9486df08
CY
3782012-02-24 Chong Yidong <cyd@gnu.org>
379
380 * keyboard.c (process_special_events): Handle all X selection
381 requests in kbd_buffer, not just the next one (Bug#8869).
382
f01d3321
CY
3832012-02-23 Chong Yidong <cyd@gnu.org>
384
385 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
386 call when setting menu-bar-lines and tool-bar-lines parameters.
387 (unwind_create_frame_1): New helper function.
388
389 * window.c (inhibit_window_configuration_change_hook): New var.
390 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 391 (syms_of_window): Initialize it.
f01d3321 392
86b847b6
CY
3932012-02-22 Chong Yidong <cyd@gnu.org>
394
395 * xterm.c (x_draw_image_relief): Add missing type check for
396 Vtool_bar_button_margin (Bug#10743).
397
a59225b1
CY
3982012-02-21 Chong Yidong <cyd@gnu.org>
399
400 * fileio.c (Vfile_name_handler_alist): Doc fix.
401
402 * buffer.c (Fget_file_buffer): Protect against invalid file
403 handler return value.
404
310f5bd4
PE
4052012-02-20 Paul Eggert <eggert@cs.ucla.edu>
406
cb3a28cc
PE
407 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
408 when computing $valmask.
409
310f5bd4
PE
410 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
411 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
412 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
413 It's useless in that case, and it can cause problems on hosts
414 that allocate halves of EMACS_INT values separately.
415 Reported by Dan Horák. Diagnosed by Andreas Schwab in
416 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
417 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
418 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
419 it avoids undefined behavior on hosts where shifting right by more
420 than the word width has undefined behavior.
421
2375c96a
CY
4222012-02-19 Chong Yidong <cyd@gnu.org>
423
424 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
425 (Funhandled_file_name_directory, Ffile_name_as_directory)
426 (Fdirectory_file_name, Fexpand_file_name)
427 (Fsubstitute_in_file_name): Protect against invalid file handler
428 return values (Bug#10845).
429
3eb49e71
EZ
4302012-02-18 Eli Zaretskii <eliz@gnu.org>
431
432 * .gdbinit (pitx): Fix incorrect references to fields of the
433 iterator stack.
434
7b926f3f
CY
4352012-02-17 Chong Yidong <cyd@gnu.org>
436
437 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
438
11273115
PE
4392012-02-15 Paul Eggert <eggert@cs.ucla.edu>
440
441 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
442 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
443
c3a70e2b
CY
4442012-02-15 Chong Yidong <cyd@gnu.org>
445
446 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
447 marked as special. Also, starting docstrings with * is obsolete.
448
0ca43699
AS
4492012-02-13 Andreas Schwab <schwab@linux-m68k.org>
450
451 * gnutls.c (emacs_gnutls_write): Fix last change.
452
2e8f3c56
LI
4532012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
454
455 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
456 send_process.
457
af70074f
SM
4582012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
459
460 * keymap.c (Fsingle_key_description): Handle char ranges.
461
95986d52
CY
4622012-02-12 Chong Yidong <cyd@gnu.org>
463
afd83bd1
CY
464 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
465 as that creates a dangerous corner case.
466
95986d52
CY
467 * window.c (Fdelete_window_internal): Invalidate the mouse
468 highlight (Bug#9904).
469
bd7da63e
GM
4702012-02-12 Glenn Morris <rgm@gnu.org>
471
472 * xselect.c (Fx_own_selection_internal)
473 (Fx_get_selection_internal, Fx_disown_selection_internal)
474 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
475 * nsselect.m (Fx_own_selection_internal)
476 (Fx_disown_selection_internal, Fx_selection_exists_p)
477 (Fx_selection_owner_p, Fx_get_selection_internal):
478 Sync docs and argument specs with the xselect.c versions.
479
77abcbc2
LI
4802012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
481
482 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
483
90b671e2
EZ
4842012-02-11 Eli Zaretskii <eliz@gnu.org>
485
1c0ca0b7
EZ
486 * w32select.c (Fx_selection_exists_p): Sync doc string and
487 argument list with xselect.c. (Bug#10783)
488
489 * w16select.c (Fx_selection_exists_p): Sync doc string and
490 argument list with xselect.c. (Bug#10783)
90b671e2 491
49241268
GM
4922012-02-10 Glenn Morris <rgm@gnu.org>
493
494 * fns.c (Fsecure_hash): Doc fix.
495
f998bbe7 4962012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
497
498 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
499
0992bd9c
CY
5002012-02-07 Chong Yidong <cyd@gnu.org>
501
502 * buffer.c (Fbuffer_local_variables)
503 (buffer_lisp_local_variables): Handle unbound vars correctly;
504 don't let Qunbound leak into Lisp.
505
af008560
GM
5062012-02-07 Glenn Morris <rgm@gnu.org>
507
dd605cc4
GM
508 * image.c (Fimagemagick_types): Doc fix.
509
af008560
GM
510 * image.c (imagemagick-render-type): Change it from a lisp object
511 to an integer. Move the doc here from the lisp manual.
512 Treat all values not equal to 0 the same.
513
1449fa1d
CY
5142012-02-06 Chong Yidong <cyd@gnu.org>
515
516 * doc.c (store_function_docstring): Avoid applying docstring of
517 alias to base function (Bug#2603).
518
3723ec07
AS
5192012-02-04 Andreas Schwab <schwab@linux-m68k.org>
520
521 * .gdbinit (pp1, pv1): Remove redundant defines.
522 (pr): Use pp.
523
79c1cc1e
CY
5242012-02-04 Chong Yidong <cyd@gnu.org>
525
526 * nsterm.m: Declare a global (Bug#10694).
527
d7f29f8e
EZ
5282012-02-04 Eli Zaretskii <eliz@gnu.org>
529
cae07000
SM
530 * w32.c (get_emacs_configuration_options):
531 Include --enable-checking, if specified, in the return value.
d7f29f8e 532
3b95a6f9
MR
5332012-02-04 Martin Rudalics <rudalics@gmx.at>
534
535 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
536 after rounding frame sizes. (Bug#9723)
537
d6fa96a6
EZ
5382012-02-04 Eli Zaretskii <eliz@gnu.org>
539
540 * keyboard.c (adjust_point_for_property): Don't position point
541 before BEGV. (Bug#10696)
542
df0b2940
PE
5432012-02-03 Paul Eggert <eggert@cs.ucla.edu>
544
545 Handle overflow when computing char display width (Bug#9496).
546 * character.c (char_width): Return EMACS_INT, not int.
547 (char_width, c_string_width): Check for overflow when
548 computing the width; this is possible now that individual
549 characters can have unbounded width. Problem introduced
550 by merge from Emacs 23 on 2012-01-19.
551
6bee44d6
MA
5522012-02-02 Michael Albinus <michael.albinus@gmx.de>
553
554 * dbusbind.c (Fdbus_register_method): Mention the return value
555 :ignore in the docstring.
556
44f92739
GM
5572012-02-02 Glenn Morris <rgm@gnu.org>
558
1b9f60cc
GM
559 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
560
44f92739
GM
561 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
562 Unconditionally set to t. (Bug#10673)
563 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
564 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
565 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
566
c5d3843c
KH
5672012-02-02 Kenichi Handa <handa@m17n.org>
568
569 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
570 0, do not call append_composite_glyph.
571
159462d4 5722012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
573
574 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
575 NULL (Bug#6988).
576 (x_produce_glyphs): If the component of a composition is a null
577 string, set it->pixel_width to 1 to avoid zero-width glyph.
578
78cef877
EZ
5792012-02-01 Eli Zaretskii <eliz@gnu.org>
580
581 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
582 first 2 arguments are identical. This makes inserting large
583 output from a subprocess an order of magnitude faster on
584 MS-Windows, where all sbrk'ed memory is always contiguous.
585
97897668
GM
5862012-01-31 Glenn Morris <rgm@gnu.org>
587
588 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 589 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
590 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
591
31fd3586
GM
5922012-01-29 Glenn Morris <rgm@gnu.org>
593
594 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
595
0e24a8b2
CY
5962012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
597
598 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
599
cc0adcb0
CY
6002012-01-28 Chong Yidong <cyd@gnu.org>
601
602 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
603
acc28cb9
CY
6042012-01-26 Chong Yidong <cyd@gnu.org>
605
9c69cfb7
CY
606 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
607
acc28cb9
CY
608 * search.c (Fsearch_forward, Fsearch_backward): Document negative
609 repeat counts (Bug#10507).
610
48da7392
GM
6112012-01-26 Glenn Morris <rgm@gnu.org>
612
613 * lread.c (syms_of_lread): Doc fix.
614
14af5f7f
CY
6152012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
616
617 * coding.c (encode_designation_at_bol): Change return value to
618 EMACS_INT.
619
0b21c100
CY
6202012-01-25 Chong Yidong <cyd@gnu.org>
621
622 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
623
3c2907f7
CY
6242012-01-21 Chong Yidong <cyd@gnu.org>
625
626 * floatfns.c (Fcopysign): Make the second argument non-optional,
627 since nil is not allowed anyway.
628
959ad23f
AS
6292012-01-21 Andreas Schwab <schwab@linux-m68k.org>
630
631 * process.c (read_process_output): Use p instead of XPROCESS (proc).
632 (send_process): Likewise.
633
34a02f46
MR
6342012-01-19 Martin Rudalics <rudalics@gmx.at>
635
636 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
637 (Vwindow_persistent_parameters): Do not use Qstate.
638 Rewrite doc-strings.
34a02f46 639
1259009a 6402012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
641
642 * character.c (char_width): New function.
70d4fdf6
GM
643 (Fchar_width, c_string_width, lisp_string_width):
644 Use char_width (Bug#9496).
25ed9e61 645
6a6ee00d
MR
6462012-01-16 Martin Rudalics <rudalics@gmx.at>
647
648 * window.c (Vwindow_persistent_parameters): New variable.
649 (Fset_window_configuration, save_window_save): Handle persistent
650 window parameters.
651
c85efaf7
EZ
6522012-01-14 Eli Zaretskii <eliz@gnu.org>
653
654 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
655 thrashing the stack of the thread. (Bug#9087)
656
5944709e
PE
6572012-01-12 Paul Eggert <eggert@cs.ucla.edu>
658
659 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
660
e71f5d99
EZ
6612012-01-11 Eli Zaretskii <eliz@gnu.org>
662
663 * xdisp.c (rows_from_pos_range): Handle the case where the
664 highlight ends on a newline. (Bug#10464)
665 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
666 he end column for display of highlight that ends on a newline
667 before a R2L line.
668
ce316182
GM
6692012-01-11 Glenn Morris <rgm@gnu.org>
670
671 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
672 from load-path also when installation-directory is nil. (Bug#10208)
673
5b43da69
GM
6742012-01-10 Glenn Morris <rgm@gnu.org>
675
74cc8ff9
GM
676 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
677
7d8d6e4e
GM
678 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
679 Update template values to be closer to their typical values these days.
5b43da69 680
a0db8d43
EZ
6812012-01-09 Eli Zaretskii <eliz@gnu.org>
682
683 * xdisp.c (rows_from_pos_range): Accept additional argument
684 DISP_STRING, and accept any glyph in a row whose object is that
685 string as eligible for mouse highlight. Fixes mouse highlight of
686 display strings from overlays. (Bug#10464)
687
9a0115ab 6882012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 689
b9110d6a 690 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
691 * fileio.c (auto_saving_dir_umask): New static var.
692 (Fmake_directory_internal): Use it.
693 (do_auto_save_make_dir): Set it, instead of invoking chmod after
694 creating the directory. The old code temporarily assigns
695 too-generous permissions to the directory.
696 (do_auto_save_eh): Clear it.
b9110d6a 697 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
698 that the var is always cleared.
699
6c1bd3f3
EZ
7002012-01-07 Eli Zaretskii <eliz@gnu.org>
701
702 * search.c (scan_buffer): Pass character positions to
703 know_region_cache, not byte positions. (Bug#6540)
704
069d2b50
L
7052012-01-07 LynX <_LynX@bk.ru> (tiny change)
706
707 * w32.c (sys_rename): Report EXDEV when rename of a directory
708 fails because the target is on another logical disk. (Bug#10284)
709
75bf0d33
DB
7102012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
711
712 * xterm.c (x_embed_request_focus): New function.
713
714 * xterm.h: Add prototype.
715
716 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
717
1c6e5a32
GM
7182012-01-05 Glenn Morris <rgm@gnu.org>
719
720 * emacs.c (emacs_copyright): Update short copyright year to 2012.
721
651e947e
EZ
7222012-01-01 Eli Zaretskii <eliz@gnu.org>
723
724 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
725 Load gnutls_transport_set_lowat only if GnuTLS version is below
726 2.11.1.
727 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
728 GnuTLS versions below 2.11.1.
729
3778cdd8
AL
7302011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
731
732 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
733 to the doc string advising against its use for altering the way
734 windows are scrolled.
735
0e5317f7
KH
7362011-12-28 Kenichi Handa <handa@m17n.org>
737
738 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
739 coding-system ASCII compatible only when it does not produce BOM
740 on encoding (Bug#10383).
741
93d5ca1f
JD
7422011-12-26 Jan Djärv <jan.h.d@swipnet.se>
743
744 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
745 can scroll.
746 (create_and_show_popup_menu): Always use menu_position_func for
747 Gtk3 (Bug#10361).
748
ca22b785
AS
7492011-12-24 Andreas Schwab <schwab@linux-m68k.org>
750
751 * callint.c (Fcall_interactively): Don't truncate prompt string.
752
d048e1e6
EZ
7532011-12-23 Eli Zaretskii <eliz@gnu.org>
754
755 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
756 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 757 resumed from there (after widening). (Bug#10360)
d048e1e6 758
5ccaba1f
JD
7592011-12-22 Jan Djärv <jan.h.d@swipnet.se>
760
761 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
762
204ee57f
JD
7632011-12-21 Jan Djärv <jan.h.d@swipnet.se>
764
b81d40f0
JB
765 * nsterm.m (x_free_frame_resources):
766 Release f->output_data.ns->miniimage.
204ee57f
JD
767 (ns_index_color): Fix indentation. Do not retain
768 color_table->colors[i].
769
770 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
771 before returning.
772
773 * nsfns.m (x_set_background_color): Assign return value from
774 ns_index_color to face-background instead of NSColor*.
775 (ns_implicitly_set_icon_type): Fix indentation.
776 Change assignment in for loop to comparison.
777
778 * emacs.c (ns_pool): New variable.
779 (main): Assign ns_pool.
780 (Fkill_emacs): Call ns_release_autorelease_pool.
781
782 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
783 autorelease fdesc, release fdAttrs and tdict.
784 (ns_get_covering_families): Release charset.
785 (ns_findfonts): Release NSFontDescriptor created with new.
786 (ns_uni_to_glyphs): Fix indentation.
787 (setString): Release attrStr before assigning new value.
788
c803b2b7
JD
7892011-12-18 Jan Djärv <jan.h.d@swipnet.se>
790
678f4426
JD
791 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
792 and NS_IMPL_COCOA.
793 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
794 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
795
cd394be1 7962011-12-18 David Reitter <reitter@cmu.edu>
678f4426 797
5fecd5fc
JD
798 * nsterm.m (ns_term_init): Subscribe for notifications
799 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
800 to method trackingNotification in EmacsMenu.
801
802 * nsmenu.m (trackingMenu): New variable.
3771cb17 803 (trackingNotification): New method (from Aquamacs).
5fecd5fc 804 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 805 from Aquamacs (Bug#7030).
678f4426
JD
806
8072011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 808
c803b2b7
JD
809 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
810 (symbol_to_nsstring): Fix indentation.
811 (ns_symbol_to_pb): New function.
cae07000
SM
812 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
813 (Fns_rotate_cut_buffers_internal): Remove.
814 (Fns_store_selection_internal): Rename from
c803b2b7
JD
815 Fns_store_cut_buffer_internal.
816 (ns_get_foreign_selection, Fx_own_selection_internal)
817 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
818 (Fns_get_selection_internal, Fns_store_selection_internal):
819 Use ns_symbol_to_pb and check if return value is nil.
820 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
821 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
822 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
823 renamed to Sns_store_selection_internal.
824 (ns_handle_selection_request): Move code to Fx_own_selection_internal
825 and remove this function.
826 (ns_handle_selection_clear): Remove, never used.
827 (Fx_own_selection_internal): Move code from ns_handle_selection_request
828 here.
829
e1b01a3a
KB
8302011-12-17 Ken Brown <kbrown@cornell.edu>
831
832 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
833 GID is unknown (Bug#10257).
834
2adb6e85
PE
8352011-12-17 Paul Eggert <eggert@cs.ucla.edu>
836
837 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
838 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
839 which caused a build failure on GNU/Linux IA-64. This problem was
840 introduced by my 2011-10-07 patch.
841
d1d7b339
JL
8422011-12-15 Juri Linkov <juri@jurta.org>
843
844 * image.c (imagemagick_error): New function. (Bug#10112)
845 (imagemagick_load_image): Comment out `MagickSetResolution' call.
846 Use `imagemagick_error' where ImageMagick functions return
847 `MagickFalse'.
848 (Fimagemagick_types): Add `Fnreverse' to return the list in the
849 proper order.
850
100d5755
KH
8512011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
852
853 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
854 fill background (Bug#8992).
855
454592a6
MR
8562011-12-13 Martin Rudalics <rudalics@gmx.at>
857
858 * window.c (Vwindow_combination_resize)
859 (Vwindow_combination_limit): Use t instead of non-nil in
860 doc-strings.
61d4b438
MR
861 (Vrecenter_redisplay): Add first sentence of doc-string on
862 separate line.
53524d93 863 (Frecenter): Fix doc-string typo.
454592a6 864
3633e3aa
KH
8652011-12-11 Kenichi Handa <handa@m17n.org>
866
867 * coding.c (Funencodable_char_position): Pay attention to the
868 buffer text relocation (Bug#9389).
869
7b9d523a
JD
8702011-12-10 Jan Djärv <jan.h.d@swipnet.se>
871
872 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
873 gtk_init (Bug#10100).
874
b73189c6
EZ
8752011-12-10 Eli Zaretskii <eliz@gnu.org>
876
877 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
878 IT->string is nil. (Bug#10263)
879
f7dfe5d6
JD
8802011-12-10 Jan Djärv <jan.h.d@swipnet.se>
881
83faebb4
JD
882 * nsterm.h (x_free_frame_resources): Declare.
883
f7dfe5d6
JD
884 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
885 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
886
887 * nsterm.h (ns_get_defaults_value): Declare.
888
889 * nsterm.m (ns_default): Call ns_get_defaults_value.
890
7cd4e72c
EZ
8912011-12-09 Eli Zaretskii <eliz@gnu.org>
892
893 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
894 (Bug#10170)
895
b34d7317
YM
8962011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
897
898 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
899 that where the value of an _OBJC_* symbol points to is in the .bss
900 section (Bug#10240).
901
76470ad1
KH
9022011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
903
904 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 905 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 906
745fff94
KH
9072011-12-08 Kenichi Handa <handa@m17n.org>
908
909 * ftfont.c (get_adstyle_property): Fix previous change
910 (Bug#10233).
911
6e44397c
JB
9122011-12-07 Juanma Barranquero <lekktu@gmail.com>
913
914 * w32.c (init_environment): If no_site_lisp, remove site-lisp
915 dirs from the default value of EMACSLOADPATH (bug#10208).
916
7efa6272
GM
9172011-12-07 Glenn Morris <rgm@gnu.org>
918
919 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
920 installation and source directories as well. (Bug#10208)
921
f6fc4d87
CY
9222011-12-06 Chong Yidong <cyd@gnu.org>
923
924 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
925
2bf26180
GM
9262011-12-06 Glenn Morris <rgm@gnu.org>
927
928 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
929 as an error, not just -1. (Bug#10217)
930
3a6ad4f0
CY
9312011-12-05 Chong Yidong <cyd@gnu.org>
932
933 * keyboard.c (process_special_events): New function.
934 (swallow_events, Finput_pending_p): Use it (Bug#10195).
935
75a3b399
PE
9362011-12-05 Paul Eggert <eggert@cs.ucla.edu>
937
938 * coding.c (encode_designation_at_bol): Don't use uninitialized
939 local variable (Bug#9318).
940
c3c9e25e
KH
9412011-12-05 Kenichi Handa <handa@m17n.org>
942
943 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
944 return Qnil (Bug#8046, Bug#10193).
945
5eb05ea3
KH
9462011-12-05 Kenichi Handa <handa@m17n.org>
947
948 * coding.c (encode_designation_at_bol): New args charbuf_end and
949 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
950 (coding_set_source): Return how many bytes coding->source was
951 relocated.
952 (coding_set_destination): Return how many bytes
953 coding->destination was relocated.
954 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 955 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
956
9572011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
958
959 * coding.c (CODING_CHAR_CHARSET_P): New macro.
960 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
961 macro (Bug#9318).
962
9632011-12-05 Andreas Schwab <schwab@linux-m68k.org>
964
965 The following changes are to fix Bug#9318.
966
a79703f5 967 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
968 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
969 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 970 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 971
7dbda6df
JB
9722011-12-05 Juanma Barranquero <lekktu@gmail.com>
973
974 * lisp.h (process_quit_flag): Fix external declaration.
975
6d5eb5b0
SM
9762011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
977
978 Don't macro-inline non-performance-critical code.
979 * eval.c (process_quit_flag): New function.
980 * lisp.h (QUIT): Use it.
981
a0c3fad0
JD
9822011-12-04 Jan Djärv <jan.h.d@swipnet.se>
983
984 * nsfns.m (get_geometry_from_preferences): New function.
985 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
986
6c07aac2
AS
9872011-12-04 Andreas Schwab <schwab@linux-m68k.org>
988
989 * emacs.c (Qkill_emacs): Define.
990 (syms_of_emacs): Initialize it.
991 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
992 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
993 (quit_throw_to_read_char): Add parameter `from_signal'.
994 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
995 * lisp.h (QUIT): Call Fkill_emacs if requested.
996
c052ead4
JD
9972011-12-03 Jan Djärv <jan.h.d@swipnet.se>
998
999 * widget.c (update_wm_hints): Return if wmshell is null.
1000 (widget_update_wm_size_hints): New function.
1001
1002 * widget.h (widget_update_wm_size_hints): Declare.
1003
1004 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1005 widget_update_wm_size_hints (Bug#10104).
1006
9e49252b
EZ
10072011-12-03 Eli Zaretskii <eliz@gnu.org>
1008
1009 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1010 before a newline, prepare the bidi iterator for consuming the
1011 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1012 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1013
02b16839
JL
10142011-12-02 Juri Linkov <juri@jurta.org>
1015
1016 * search.c (Fword_search_regexp): New Lisp function created from
1017 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1018 (Fword_search_backward, Fword_search_forward)
1019 (Fword_search_backward_lax, Fword_search_forward_lax):
1020 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1021 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1022
0068070e
SM
10232011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1024
1025 * fileio.c (Finsert_file_contents): Move after-change-function call
1026 to before the "handled:" label, since all "goto handled" appear in
1027 cases where the *-change-functions have already been properly called
1028 (bug#10117).
1029
3360a3fc
AS
10302011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1031
1032 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1033 waiting for input. (Bug#10169)
1034
73d6c093
EZ
10352011-11-30 Eli Zaretskii <eliz@gnu.org>
1036
1037 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1038 verifies glyph row's hash code--we have just reallocated the
1039 glyphs, so their contents can be complete garbage. (Bug#10164)
1040
febe6bea
JB
10412011-11-30 Juanma Barranquero <lekktu@gmail.com>
1042
1043 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1044
801a4313
EZ
10452011-11-30 Eli Zaretskii <eliz@gnu.org>
1046
1047 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1048 attributes are tested _before_ calling verify_row_hash, to protect
1049 against GCC re-ordering of the tests. (Bug#10164)
1050
2b56b87e
JD
10512011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1052
1053 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1054
1055 * xterm.c (handle_one_xevent): Only set async_visible and friends
1056 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1057 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1058 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1059
dbf31225
PE
10602011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1061
1062 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1063 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1064 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1065 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1066 All uses changed to use GCPRO1 etc.
1067 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1068 Revert to old implementation (i.e., before 2011-03-11).
1069
1305621b
YM
10702011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1071
1072 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1073 of scroll runs so as to avoid assigning disabled bogus rows and
1074 unnecessary graphics copy operations.
1075
8c9afb46
EZ
10762011-11-27 Eli Zaretskii <eliz@gnu.org>
1077
1078 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1079 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1080 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1081 (malloc, free, realloc, calloc): Redirect to e_* only when
1082 compiling Emacs.
1083
1084 * lisp.h (GCTYPEBITS): Move before first use.
1085 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1086 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1087 this macro definition.
1088
1089 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1090 _MSC_VER.
1091
54e9e3bf
JD
10922011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1093
6d5eb5b0
SM
1094 * gtkutil.c (xg_create_frame_widgets):
1095 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1096 present with Gtk+ 2.0.
1097
83aca1cb
PE
10982011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1099
1100 * fileio.c (Finsert_file_contents): Undo previous change; see
1101 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1102
5b76caa4
PE
11032011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1104
1105 Rename locals to avoid shadowing.
1106 * fileio.c (Finsert_file_contents):
1107 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1108 * process.c (wait_reading_process_output):
1109 Rename inner 'proc' to 'p' to avoid shadowing.
1110 Indent for consistency with usual Emacs style.
1111
8c535114
EZ
11122011-11-25 Eli Zaretskii <eliz@gnu.org>
1113
1114 * xdisp.c (redisplay_window): If cursor row is not fully visible
1115 after recentering, and scroll-conservatively is set to a large
1116 number, scroll window by a few more lines to make the cursor fully
1117 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1118 (start_display): Don't move to the next line if the display should
1119 start at a newline that is part of a display vector or an overlay
1120 string. (Bug#10119)
8c535114 1121
fa4fdb5c
JL
11222011-11-24 Juri Linkov <juri@jurta.org>
1123
1124 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1125 after the `MagickPingImage' call. (Bug#10112)
1126
90ec88df
CY
11272011-11-23 Chong Yidong <cyd@gnu.org>
1128
1129 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1130
56e2e794
MR
11312011-11-23 Martin Rudalics <rudalics@gmx.at>
1132
1133 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1134 making another buffer current. (Bug#10114)
1135
b6e64c41
GM
11362011-11-23 Glenn Morris <rgm@gnu.org>
1137
1138 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1139
6b21de18
CY
11402011-11-23 Chong Yidong <cyd@gnu.org>
1141
1142 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1143 using it (Bug#5984).
1144
b12cd789
EZ
11452011-11-22 Eli Zaretskii <eliz@gnu.org>
1146
1147 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1148 and header-lines, as they don't have one computed for them.
1149 (Bug#10098)
1150
1151 * .gdbinit (prow): Make displayed values more self-explaining.
1152 Add row's hash code.
1153
261b6fd4
LMI
11542011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1155
1156 * process.c (wait_reading_process_output): Fix asynchrounous
1157 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1158 (wait_reading_process_output): Add comment and URL.
261b6fd4 1159
e7cfd277
JD
11602011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1161
1162 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1163
a9b9b7f5
CY
11642011-11-21 Chong Yidong <cyd@gnu.org>
1165
1166 * window.c (Fnext_window, Fprevious_window): Doc fix.
1167
b0d15b4f
SM
11682011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1169
1170 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1171
fe7a3057
JB
11722011-11-20 Juanma Barranquero <lekktu@gmail.com>
1173
1174 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1175
d2999b1a
MR
11762011-11-20 Martin Rudalics <rudalics@gmx.at>
1177
1178 * window.c (Fset_window_combination_limit): Rename argument
1179 STATUS to LIMIT.
1180 (Vwindow_combination_limit): Remove "status" from doc-string.
1181
d5ff9cd0
AS
11822011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1183
1184 * m/ibms390.h: Remove.
1185 * m/ibms390x.h: Don't include "ibms390.h".
1186
a5bb9bd3
SM
11872011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1188
1189 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1190 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1191
cd1181db
JB
11922011-11-20 Juanma Barranquero <lekktu@gmail.com>
1193
1194 * casetab.c (Fset_case_table):
1195 * charset.c (Fcharset_after): Fix typos.
1196
615a3b8d 11972011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1198
17e845af
PE
1199 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1200 Otherwise, valgrind does not work on some platforms.
1201 Problem reported by Andreas Schwab in
6a0bf43d
PE
1202 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1203 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1204 is set, removing the need for VIRT_ADDRESS_VARIES.
1205 (PURE_P): Use a more-efficient implementation that needs just one
1206 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1207 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1208 to 4 (xorl, subq, cmpq, setbe).
1209 * alloc.c (pure): Always extern now, since that's the
1210 VIRT_ADDR_VARIES behavior.
1211 (PURE_POINTER_P): Use a single comparison, not two, for
1212 consistency with the new puresize.h.
1213 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1214 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1215 Remove VIRT_ADDR_VARIES no longer needed.
1216
f8fe6f96
EZ
12172011-11-19 Eli Zaretskii <eliz@gnu.org>
1218
1219 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1220 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1221 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1222 behave as if the cursor position were at the window margin.
1223
1224 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1225 and the cursor position is out of bounds, behave as if the cursor
1226 position were at the window margin. (Bug#10075)
1227
df05a53c
CY
12282011-11-18 Chong Yidong <cyd@gnu.org>
1229
1230 * window.c (Fwindow_combination_limit): Make first argument
1231 non-optional, since it is meaningless for live windows like the
1232 selected window.
1233
2071918e
DA
12342011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1235
1236 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1237
b50a28de
SM
12382011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1239
1240 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1241 (graft_intervals_into_buffer): Simplify.
1242
015137db
EZ
12432011-11-18 Eli Zaretskii <eliz@gnu.org>
1244
1245 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1246 hash values of the two rows.
1247 (copy_row_except_pointers): Preserve the used[] arrays and the
1248 hash values of the two rows. (Bug#10035)
68c95424 1249 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1250
1251 * xdisp.c (row_hash): New function, body extracted from
1252 compute_line_metrics.
1253 (compute_line_metrics): Call row_hash, instead of computing the
1254 hash code inline.
1255
1256 * dispnew.c (verify_row_hash): Call row_hash for computing the
1257 hash code of a row, instead of duplicating code from xdisp.c.
1258
1259 * dispextern.h (row_hash): Add prototype.
1260
a2addb04
TH
12612011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1262
1263 * frame.c (delete_frame): Don't delete the terminal when the last
1264 X frame is closed if emacs is built with GTK toolkit.
1265
df85d315
JB
12662011-11-17 Juanma Barranquero <lekktu@gmail.com>
1267
1268 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1269
a0c2d0ae
MR
12702011-11-17 Martin Rudalics <rudalics@gmx.at>
1271
1272 * window.c (Vwindow_splits): Rename to
1273 Vwindow_combination_resize. Suggested by Juri Linkov.
1274 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1275 of Vwindow_splits.
1276
58179cce
JB
12772011-11-16 Juanma Barranquero <lekktu@gmail.com>
1278
7877f373
JB
1279 * nsfns.m (Fns_font_name):
1280 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1281
b6f67890
MR
12822011-11-16 Martin Rudalics <rudalics@gmx.at>
1283
1284 * window.h (window): Rename slot "nest" to "combination_limit".
1285 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1286 (Fset_window_nest): Rename to Fset_window_combination_limit.
1287 (Vwindow_nest): Rename to Vwindow_combination_limit.
1288 (recombine_windows, make_parent_window, make_window)
1289 (Fsplit_window_internal, saved_window)
1290 (Fset_window_configuration, save_window_save): Rename all
1291 occurrences of window_nest to window_combination_limit.
1292
c7015153
JB
12932011-11-15 Juanma Barranquero <lekktu@gmail.com>
1294
1295 * image.c (imagemagick_load_image): Fix typo.
1296
322ad6ec
EZ
12972011-11-14 Eli Zaretskii <eliz@gnu.org>
1298
1299 * xdisp.c (display_line): Move the call to
1300 highlight_trailing_whitespace before the call to
1301 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1302 faces of all the glyphs to compute ROW's hash value.
1303 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1304
f067b8ec
JB
13052011-11-14 Juanma Barranquero <lekktu@gmail.com>
1306
1307 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1308 just return (bug#10044).
1309
1e5b2111
EZ
13102011-11-12 Eli Zaretskii <eliz@gnu.org>
1311
7ef3cbd5
EZ
1312 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1313 with user-defined heap size. Bump the default size of the temacs
1314 heap to 27MB, to avoid memory warning when running temacs.
1315 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1316
1e5b2111
EZ
1317 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1318 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1319 (verify_row_hash) [XASSERTS]: New function.
1320 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1321 that the hash value of glyph rows is correct.
1e5b2111 1322
89d61221
MR
13232011-11-12 Martin Rudalics <rudalics@gmx.at>
1324
1325 * window.h (window): Remove splits slot.
1326 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1327 (Fdelete_other_windows_internal, make_parent_window)
1328 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1329 (Fset_window_configuration, save_window_save): Don't deal with
1330 split status of windows.
1331 (saved_window): Remove splits slot.
1332 (Vwindow_splits): Rewrite doc-string.
1333
97f18cc8
JD
13342011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1335
1336 * xfns.c (unwind_create_frame):
1337 * nsfns.m (unwind_create_frame):
1338 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1339 Vframe_list (Bug#9999).
1340
22a648b4
DA
13412011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1342
0b381c7e 1343 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1344
659afede
KH
13452011-11-11 Kenichi Handa <handa@m17n.org>
1346
1347 * callproc.c (Fcall_process): Set the member dst_multibyte of
1348 process_coding.
1349
9ac0394b
KH
13502011-11-11 Johan Bockgård <bojohan@gnu.org>
1351
1352 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1353 avoid a crash (bug#9496).
1354
2fbdc249
CY
13552011-11-09 Chong Yidong <cyd@gnu.org>
1356
1357 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1358 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1359
ac6b1f81
PE
13602011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1361
1362 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1363
09db192c
PE
13642011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1365
1366 Avoid some portability problems by eschewing 'extern inline' functions.
1367 The trivial performance wins aren't worth the portability hassles; see
1368 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1369 et seq.
1370 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1371 (window_box_width, window_box_left, window_box_left_offset)
1372 (window_box_right, window_box_right_offset): Undo previous change,
1373 by removing the "extern"s.
1374 * intervals.c (adjust_intervals_for_insertion)
1375 (adjust_intervals_for_deletion): Undo previous change,
1376 making these static again.
1377 (offset_intervals, temp_set_point_both, temp_set_point)
1378 (copy_intervals_to_string): No longer inline.
1379 * xdisp.c (window_text_bottom_y, window_box_width)
1380 (window_box_height, window_box_left_offset)
1381 (window_box_right_offset, window_box_left, window_box_right)
1382 (window_box): No longer inline.
1383
105216ed
CY
13842011-11-08 Chong Yidong <cyd@gnu.org>
1385
1386 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1387 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1388 Signal an error if not a live window.
105216ed
CY
1389 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1390 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1391
ae9e237f
JB
13922011-11-07 Juanma Barranquero <lekktu@gmail.com>
1393
1394 * lisp.h (syms_of_abbrev): Remove declaration.
1395 Reported by CHENG Gao <chenggao@royau.me>.
1396
c7aa8333
EZ
13972011-11-07 Eli Zaretskii <eliz@gnu.org>
1398
1399 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1400 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1401 of temacs in GUI mode.
1402
be7f5545
MR
14032011-11-07 Martin Rudalics <rudalics@gmx.at>
1404
1405 * window.h: Declare delete_all_child_windows instead of
1406 delete_all_subwindows.
1407 * window.c (Fwindow_nest, Fset_window_nest)
1408 (Fset_window_new_total, Fset_window_new_normal)
1409 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1410 (delete_all_subwindows): Rename to delete_all_child_windows.
1411 (Fdelete_other_windows_internal, Fset_window_configuration):
1412 Call delete_all_child_windows instead of delete_all_subwindows.
1413 * frame.c (delete_frame): Call delete_all_child_windows instead
1414 of delete_all_subwindows.
1415
ca78dc43
PE
14162011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1417
1418 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1419 This is also needed for porting to any host where GC_MARK_STACK is
1420 not GC_MAKE_GCPROS_NOOPS.
1421 (which_symbols): Use it.
1422
a0241d01
KH
14232011-11-07 Kenichi Handa <handa@m17n.org>
1424
1425 * coding.c (coding_set_destination): Check coding->src_pos only
1426 when coding->src_object is a buffer (bug#9910).
1427
1428 * process.c (send_process): Set the member src_multibyte of coding
1429 to 0 (bug#9911) when sending a unibyte text.
1430
1431 * callproc.c (Fcall_process): Set the member src_multibyte of
1432 process_coding to 0 (bug#9912).
1433
a64bfdfa 14342011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1435
1436 * xmenu.c (cleanup_widget_value_tree): New function.
1437 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1438 calling free_menubar_widget_value_tree directly (Bug#9830).
1439
cb41b32a
PE
14402011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1441
1442 Fix some portability problems with 'inline'.
1443 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1444 (window_box_width, window_box_left, window_box_left_offset)
1445 (window_box_right, window_box_right_offset): Declare extern.
1446 Otherwise, these inline functions do not conform to C99 and
1447 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1448 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1449 * intervals.c (adjust_intervals_for_insertion)
1450 (adjust_intervals_for_deletion): Now extern, because otherwise the
1451 extern inline functions 'offset_intervals' couldn't refer to it.
1452 (static_offset_intervals): Remove.
1453 (offset_intervals): Rewrite using the old contents of
1454 static_offset_intervals. The old version didn't conform to C99
1455 because an extern inline function contained a reference to an
1456 identifier with static linkage.
1457
b7041366
AS
14582011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1459
1460 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1461 GC.
1462
88a37c4d
EZ
14632011-11-06 Eli Zaretskii <eliz@gnu.org>
1464
1465 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1466 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1467 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1468 return Qleft_to_right.
1469
49745b39
CY
14702011-11-06 Chong Yidong <cyd@gnu.org>
1471
1472 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1473 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1474 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1475 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1476 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1477 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1478 (Fwindow_vscroll): Doc fix.
1479 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1480 argument, since it makes no sense to pass a live window and for
1481 consistency with window-child.
1482
1f05cd82
CS
14832011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1484
1485 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1486 support MSVC.
1487
22610910
JR
14882011-11-05 Jason Rumney <jasonr@gnu.org>
1489
1490 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1491 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1492 fonts (Bug#6029).
1493 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1494 bitwise arithmetic preventing use of unicode-sip and non-truetype
1495 opentype fonts.
1496
a06776b2
EZ
14972011-11-05 Eli Zaretskii <eliz@gnu.org>
1498
3ad924ba
EZ
1499 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1500 "emacs"-only part.
1501
a06776b2
EZ
1502 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1503 initialization code to keep similarity to xfns.c after changes
1504 from 2011-11-05.
1505
c9e7db78
JD
15062011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1507
a97f8f3f
JD
1508 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1509 (unwind_create_frame): New function (Bug#9943).
1510 (Fx_create_frame): Restructure code to be more similar to the one in
1511 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1512 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1513 Move terminal->reference_count++ just before making the frame official
1514 (Bug#9943).
1515
1516 * nsterm.m (x_free_frame_resources): New function.
1517 (x_destroy_window): Move code to x_free_frame_resources.
1518
c9e7db78 1519 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1520 (Fx_create_frame, x_create_tip_frame):
1521 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1522 official. Move initialization of image_cache_refcount and
1523 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1524
a6fc3b5c
EZ
15252011-11-05 Eli Zaretskii <eliz@gnu.org>
1526
1527 Support MSVC build with newer versions of Visual Studio.
1528 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1529 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1530 nt/gmake.defs.
1531
1532 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1533 which are not supported by MSVC.
1534 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1535 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1536 bitfields.
1537 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1538 types in bitfields.
1539 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1540
1541 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1542
58179cce 15432011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1544
1545 Support MSVC build with newer versions of Visual Studio.
1546 * w32.c: Don't include w32api.h for MSVC.
1547 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1548
1549 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1550 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1551 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1552 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1553 e_* cousins.
1554 (alloca) [_MSC_VER]: Define to _alloca.
1555
1556 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1557
1558 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1559
a58c13ed
EZ
15602011-11-04 Eli Zaretskii <eliz@gnu.org>
1561
1562 * xdisp.c (note_mouse_highlight): If either of
1563 previous/next-single-property-change returns nil, treat that as
1564 the beginning or the end of the buffer. (Bug#9955)
1565
fe0b6370
JD
15662011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1567
a58c13ed 1568 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1569 label is not null (Bug#9951).
1570 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1571 may be NULL.
1572
89bd5ee1
EZ
15732011-11-04 Eli Zaretskii <eliz@gnu.org>
1574
1575 * window.c (Fwindow_body_size): Mention in the doc string that the
1576 return value is in frame's canonical units. (Bug#9949)
1577
84c3edb9
EZ
15782011-11-03 Eli Zaretskii <eliz@gnu.org>
1579
4e2fb5c7
EZ
1580 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1581
84c3edb9 1582 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1583 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1584 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1585
bc17a887
EZ
15862011-11-01 Eli Zaretskii <eliz@gnu.org>
1587
1588 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1589 Don't stop backward scan on the continuation glyph, even though
1590 its CHARPOS is positive.
6d5eb5b0
SM
1591 (mouse_face_from_buffer_pos, note_mouse_highlight):
1592 Rename cover_string to disp_string.
bc17a887 1593
4ee88440
MR
15942011-11-01 Martin Rudalics <rudalics@gmx.at>
1595
1596 * window.c (temp_output_buffer_show): Don't use
1597 Vtemp_buffer_show_specifiers.
1598 (Vtemp_buffer_show_specifiers): Remove unused variable.
1599
c2ff3c02
EZ
16002011-10-30 Eli Zaretskii <eliz@gnu.org>
1601
1602 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1603 past the beginning of the current glyph matrix.
1604
58179cce 16052011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1606
1607 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1608 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1609 HAVE_GTK3 (Bug#9869).
b77a6a7f 1610
3b574623
JD
1611 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1612 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1613
b77a6a7f
JD
1614 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1615
1616 * xterm.c: Declare x_handle_net_wm_state to return int.
1617 (handle_one_xevent): Check if we are iconified but don't have
1618 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1619 (get_current_wm_state): Return non-zero if not hidden,
1620 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1621 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1622 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1623 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1624
196e41e4
PE
16252011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1626
1627 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1628 so that this new function doesn't get optimized away by a
1629 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1630
021f2e1a
AS
16312011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1632
1633 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1634
8b058d44
EZ
16352011-10-29 Eli Zaretskii <eliz@gnu.org>
1636
1637 Fix the `xbytecode' command.
1638 * .gdbinit (xprintbytestr): New command.
b50a28de 1639 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1640 (xbytecode): Print the byte-code string as well.
1641
4452fb80
EZ
16422011-10-29 Kim Storm <storm@cua.dk>
1643
8b058d44
EZ
1644 * alloc.c (which_symbols): New function.
1645
21b72067
AS
16462011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1647
1648 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1649 line. (Bug#9903)
1650
83ed7b5c
GM
16512011-10-29 Glenn Morris <rgm@gnu.org>
1652
1653 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1654 Not clear what it was for, and it causes various bugs. (Bug#9839)
1655
5a7a728b
EZ
16562011-10-28 Eli Zaretskii <eliz@gnu.org>
1657
1658 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1659 possible random value that matches one of those tested as
1660 condition to clear the mouse face.
1661
d3d0842f
CY
16622011-10-28 Chong Yidong <cyd@gnu.org>
1663
1664 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1665
31b39d13
DN
16662011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1667
1668 * window.c (make_window): Initialize phys_cursor_on_p.
1669
9aba6043
SM
16702011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1671
1672 * lisp.h (struct Lisp_Symbol): Update comments.
1673
c20992f4
JB
16742011-10-28 Juanma Barranquero <lekktu@gmail.com>
1675
1676 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1677
db4f02f2
EZ
16782011-10-28 Eli Zaretskii <eliz@gnu.org>
1679
1680 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1681 <oslsachem@gmail.com> for helping to debug this.
1682
1683 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1684 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1685 (g_b_init_get_glyph_outline_w): New static variables.
1686 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1687 (GetGlyphOutlineW_Proc): New typedefs.
1688 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1689 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1690 New functions.
1691 (w32font_open_internal, compute_metrics):
1692 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1693 instead of calling the "wide" APIs directly.
1694
1695 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1696
1697 * w32.h (syms_of_w32font): Add prototype.
1698
87e68db4
JB
16992011-10-27 Juanma Barranquero <lekktu@gmail.com>
1700
1701 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1702 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1703 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1704 (Fmove_to_window_line): Doc fix.
1705
435c1d67
CY
17062011-10-27 Chong Yidong <cyd@gnu.org>
1707
1708 * process.c (make_process): Set gnutls_state to NULL.
1709
1710 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1711 non-NULL, regardless of GNUTLS_INITSTAGE.
1712 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1713 an error. Set process slots as soon as we allocate them.
1714
1715 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1716
9c6c6f49
CY
17172011-10-27 Chong Yidong <cyd@gnu.org>
1718
9aba6043
SM
1719 * gnutls.c (emacs_gnutls_deinit): New function.
1720 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1721 (Fgnutls_deinit, Fgnutls_boot): Use it.
1722
1723 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1724 (deactivate_process): Call emacs_gnutls_deinit.
1725
657d08d3
JB
17262011-10-27 Juanma Barranquero <lekktu@gmail.com>
1727
1728 * image.c (x_create_x_image_and_pixmap):
1729 * w32.c (sys_rename, w32_delayed_load):
1730 * w32font.c (fill_in_logfont):
1731 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1732
5430d399
JB
17332011-10-26 Juanma Barranquero <lekktu@gmail.com>
1734
1735 * w32fns.c (w32_default_color_map): New function,
1736 extracted from Fw32_default_color_map.
a7ef684b 1737 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1738
fe0055fa
PE
17392011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1740
1741 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1742
e6346438
SM
17432011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1744
1745 * keyboard.c (test_undefined): New function (bug#9751).
1746 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1747
e112cc37
ET
17482011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1749
1750 * sysdep.c (init_sys_modes): Fix the check for the controlling
1751 terminal (Bug#6649).
1752
7b5d6677
EZ
17532011-10-20 Eli Zaretskii <eliz@gnu.org>
1754
1755 * dispextern.h (struct bidi_it): New member next_en_type.
1756
1757 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1758 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1759 current character, check also for next_en_type being WEAK_EN.
1760 (bidi_resolve_weak): Don't enter the expensive loop if the current
1761 position is before next_en_pos. Record the bidi type of the first
1762 non-ET, non-BN character we find, in addition to its position.
1763 (bidi_level_of_next_char): Invalidate next_en_type when
1764 next_en_pos is over-stepped.
1765
7da0b018
PE
17662011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1767
1768 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1769 * editfns.c: Rewrite current-time-zone so that it invokes
1770 the equivalent of (format-time-string "%Z") to get the time zone name.
1771 This fixes a bug when the time zone name contains characters that
1772 need converting from the system time locale to Emacs internal format.
1773 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1774 that patch fixed format-time-string to do the conversion, but
1775 I forgot to fix current-time-zone.
1776 (format_time_string): New function, containing most of
1777 what Fformat_time_string used to contain.
1778 (Fformat_time_string): Rewrite in terms of format_time_string.
1779 This doesn't change this function's behavior.
1780 (current-time-zone): Rewrite to use format_time_string.
1781 This fixes the bug reported by Michael Schierl in
1782 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1783 Jason Rumney's 2007-06-07 change worked around this bug, but
1784 didn't fix it.
1785 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1786
8547b010
EZ
17872011-10-19 Eli Zaretskii <eliz@gnu.org>
1788
1789 * xdisp.c (start_display): If the character at POS is displayed
1790 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1791 (try_window_reusing_current_matrix): If a line ends in a display
1792 vector or the next line starts in a display vector, continue
1793 redrawing the window even though the character position of
1794 start_row was reached.
8547b010
EZ
1795 (Bug#9771, part 2)
1796
4e948d15
CY
17972011-10-18 Chong Yidong <cyd@gnu.org>
1798
1799 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1800 with nobreak-char-display too.
1801
4787455f
EZ
18022011-10-18 Eli Zaretskii <eliz@gnu.org>
1803
1804 Fix part 3 of bug#9771.
1805 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1806 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1807 non-neutral characters if the current character is a paragraph
1808 separator (a.k.a. Newline). This avoids running the same
1809 expensive loop twice, once when we consume the preceding newline
1810 and the other time when the line actually needs to be displayed.
1811 Avoid the loop when we see neutrals on the base embedding level
1812 following a character whose directionality is the same as the
1813 paragraph's. This avoids running the expensive loop when a line
1814 ends in a long sequence of neutrals, like control characters.
1815 Add assertion against STRONG_AL type. Slightly rearrange code
1816 that determines the type of a neutral given the first non-neutral
1817 that follows it.
1818 (bidi_level_of_next_char): Set next_en_pos to zero when
1819 invalidating its info.
1820
2c91f553
EZ
18212011-10-17 Eli Zaretskii <eliz@gnu.org>
1822
1823 * xdisp.c (push_display_prop): Determine whether to record string
1824 or buffer position by IT->string, not by IT->method. Allow
1825 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1826 (move_it_vertically_backward): Don't look for character position
1827 immediately after the newline when in a continuation line.
1828 (Bug#9771, part 1)
2c91f553 1829
c7b08b0d
MR
18302011-10-15 Martin Rudalics <rudalics@gmx.at>
1831
1832 * window.c (coordinates_in_window): Rewrite and delabelize
1833 vertical border check. (Bug#5357) (Bug#9618)
1834
6b02f655
SM
18352011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1836
1837 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1838 errors in XSetWindowBorder (bug#9310).
1839
81d40c92
DA
18402011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1841
1842 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1843 avoid crash when xmalloc overrun checking is enabled.
1844
d4172c3b
EZ
18452011-10-13 Eli Zaretskii <eliz@gnu.org>
1846
1847 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1848 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1849 cursor motion with <left> and <right> arrow keys.
1850
1851 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1852 some callers set that themselves.
1853
b00eea75
EZ
18542011-10-12 Eli Zaretskii <eliz@gnu.org>
1855
1856 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1857 display string and the previous row comes from the same string and
1858 is empty. (Bug#9739) (Bug#9738)
1859
8fe012c4
SM
18602011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1861
1862 * doc.c (get_doc_string): Encode file name (bug#9735).
1863
0074aef2
EZ
18642011-10-12 Eli Zaretskii <eliz@gnu.org>
1865
79beb178
EZ
1866 * bidi.c (bidi_level_of_next_char):
1867 * xdisp.c (get_visually_first_element): Remove old incorrect
1868 comments regarding the Unicode Line Separator character.
1869
0074aef2
EZ
1870 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1871
6e4b3fbe
DA
18722011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1873
1874 * alloc.c (Fgc_status): Do not access beyond zombies array
1875 boundary if nzombies > MAX_ZOMBIES.
1876 * alloc.c (dump_zombies): Add missing format specifier.
1877
0324f3af
PE
18782011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1879
b5525cac
PE
1880 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1881 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1882
0324f3af
PE
1883 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1884 Some packages use them to denote characters with modifiers.
1885
e9b5f888
AS
18862011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1887
1888 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1889 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1890 matching a pp-number. Rename parameter var to var1.
1891
127827c0
SM
18922011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1893
1894 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1895
c8fd3bd0
GM
18962011-10-08 Glenn Morris <rgm@gnu.org>
1897
1898 * callint.c (Fcall_interactively): Give a more explicit error for the
1899 'c' case with a non-character input. (Bug#8479)
1900
352ec8ff
EZ
19012011-10-08 Eli Zaretskii <eliz@gnu.org>
1902
03669ccb
EZ
1903 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1904 lines.
7061c986
EZ
1905 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1906 lines that are hscrolled on the left.
03669ccb 1907
352ec8ff
EZ
1908 * dispnew.c (buffer_posn_from_coords): Account for a possible
1909 presence of header-line. (Bug#4426)
1910
a66cfb1c
SM
19112011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1912
6b02f655
SM
1913 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1914 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1915
7c5ee88e
PE
19162011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1917
1918 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1919 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1920 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1921 this makes Emacs dump core during garbage collection on rare
1922 occasions. sizeof is obviously inferior to offsetof here, so
1923 stick with offsetof.
1924 (GC_POINTER_ALIGNMENT): New macro.
1925 (mark_memory): Omit 3rd (offset) arg; caller changed.
1926 Don't assume EMACS_INT alignment is the same as pointer alignment.
1927
df1bbe5b
SM
19282011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1929
1930 * keyboard.c (read_key_sequence_remapped): New var.
1931 (read_key_sequence): Compute remapping in the right buffer.
1932 (command_loop_1): Use read_key_sequence's remapping directly.
1933
51553db6
SM
19342011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1935
32c1fffd
SM
1936 * dired.c (file_name_completion): Don't expand file name.
1937 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1938 before checking file name handler.
1939
51553db6
SM
1940 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1941 they've been requested explicitly (bug#9591).
1942
b6bd1599 19432011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1944
1945 * keymap.c (Fsingle_key_description): Use make_specified_string
1946 instead of build_string to build string from push_key_description.
1947 (Bug#5193)
1948
f701dc2a
PE
19492011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1950
4222c55d
PE
1951 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1952 This fixes a Y2038 bug on 64-bit hosts.
1953 * buffer.c (reset_buffer):
1954 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1955 (Fclear_buffer_auto_save_failure):
1956 Use 0, not -1, to represent an unset failure time, since time_t
1957 might not be signed.
1958
f701dc2a
PE
1959 Remove dependency on glibc malloc internals.
1960 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1961 Move back here from lisp.h, but with their new implementations.
1962 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1963 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1964 * charset.c (charset_table_init): New static var.
1965 (syms_of_charset): Use it instead of xmalloc. This removes a
1966 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1967 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
1968 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1969 Move back to alloc.c.
1970 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1971 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
1972
9ceebf39
JD
19732011-09-30 Jan Djärv <jan.h.d@swipnet.se>
1974
1975 * nsterm.m (windowDidResize): Call x_set_window_size only when
1976 ns_in_resize is true. Otherwise set pixelwidth/height and
1977 call change_frame_size (Bug#9628).
1978
cb993c58
PE
19792011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1980
3930c88b
PE
1981 Port --enable-checking=all to Fedora 14 x86-64.
1982 * charset.c (syms_of_charset): Also account for glibc malloc's
1983 internal overhead when calculating the initial malloc maximum.
1984
cb993c58
PE
1985 Port --enable-checking=all to Fedora 14 x86.
1986 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1987 Move to lisp.h.
1988 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
1989 (overrun_check_realloc, overrun_check_free):
1990 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
1991 That way, xmalloc returns a properly-aligned pointer even if
1992 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
1993 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
1994 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
1995 into account when calculating the initial malloc maximum.
1996 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1997 Move here from alloc.c, so that charset.c can use it too.
1998 Properly align; the old code wasn't right for common 32-bit hosts
1999 when configured with --enable-checking=all.
2000 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2001 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2002
31bed486
EZ
20032011-09-29 Eli Zaretskii <eliz@gnu.org>
2004
04c70788 2005 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2006 use EDOM.
2007
fbcaa2f3
EZ
20082011-09-28 Eli Zaretskii <eliz@gnu.org>
2009
2010 * xdisp.c (compute_display_string_end): If there's no display
2011 string at CHARPOS, return -1.
2012
2013 * bidi.c (bidi_fetch_char): When compute_display_string_end
2014 returns a negative value, treat the character as a normal
2015 character not covered by a display string. (Bug#9624)
2016
a239d4e9
JB
20172011-09-28 Juanma Barranquero <lekktu@gmail.com>
2018
2019 * lread.c (Fread_from_string): Fix typo in docstring.
2020
88652fd5
EZ
20212011-09-27 Eli Zaretskii <eliz@gnu.org>
2022
2023 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2024 newline, reseat the iterator instead of bidi-iterating there one
2025 character at a time. (Bug#9610)
32c1fffd
SM
2026 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2027 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2028
ed497dd4
AS
20292011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2030
2031 * lread.c (readevalloop): Use correct code for NBSP.
2032 (read1): Likewise. (Bug#9608)
2033
b2bf61aa
MA
20342011-09-25 Michael Albinus <michael.albinus@gmx.de>
2035
2036 * dbusbind.c (Fdbus_register_signal): When service is not
2037 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2038
32bbb17c
GM
20392011-09-25 Glenn Morris <rgm@gnu.org>
2040
2041 * buffer.c (truncate-lines): Doc fix.
2042
94e0933e
CY
20432011-09-24 Chong Yidong <cyd@stupidchicken.com>
2044
2045 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2046 (Fset_window_next_buffers): Doc fix.
2047
cddde921
GM
20482011-09-24 Glenn Morris <rgm@gnu.org>
2049
2050 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2051
1260aef1
PE
20522011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2053
25b4bfa0
PE
2054 Fix minor problems found by static checking.
2055 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2056 * indent.c (Fvertical_motion): Fix == vs = typo.
2057
e3cbd34b
EZ
20582011-09-24 Eli Zaretskii <eliz@gnu.org>
2059
a66cfb1c
SM
2060 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2061 Default value is now t. Doc fix.
6bf7006f 2062
e3cbd34b 2063 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2064 logic when moving up, not only when moving down. Fix the
e3cbd34b 2065 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2066 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2067
2068 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2069 CHARPOS is covered by a display string which includes newlines.
2070 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2071 is covered by a display string with embedded newlines.
2072
a3de0cbd
MA
20732011-09-24 Michael Albinus <michael.albinus@gmx.de>
2074
2075 * dbusbind.c (Fdbus_register_signal): Add match rule to
2076 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2077 (Fdbus_register_method, Vdbus_registered_objects_table):
2078 Fix docstring.
a3de0cbd 2079
b260039d
JM
20802011-09-24 Jim Meyering <meyering@redhat.com>
2081
32c1fffd 2082 do not ignore write error for any output size
b260039d
JM
2083 The previous change was incomplete.
2084 While it makes emacs --batch detect the vast majority of stdout
2085 write failures, errors were still ignored whenever the output size is
2086 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2087 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2088 && echo FAIL: ignored write error
2089 FAIL: ignored write error
2090 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2091 && echo FAIL: ignored write error
2092 FAIL: ignored write error
2093 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2094
8eca8a7c
AS
20952011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2096
2097 * emacs.c (Fkill_emacs): In noninteractive mode exit
2098 non-successfully if a write error occurred on stdout. (Bug#9574)
2099
3341db62
EZ
21002011-09-21 Eli Zaretskii <eliz@gnu.org>
2101
2102 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2103 the xassert test.
2104
2105 * dispextern.h (struct it): Update the comment documenting what
2106 can it->OBJECT be.
2107
8c203dbf
EZ
21082011-09-20 Eli Zaretskii <eliz@gnu.org>
2109
2110 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2111 a display string, extend search for cursor position to end of row.
2112 (find_row_edges): If the row ends in a newline from a display
2113 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2114 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2115 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2116 non-empty line. Fixes confusing cursor motion with arrow keys at
2117 the beginning of a line that starts with whitespace.
8c203dbf 2118
a4824228
LMI
21192011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2120
2121 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2122 (bug#9493).
2123
33ed493b
CY
21242011-09-18 Chong Yidong <cyd@stupidchicken.com>
2125
2126 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2127 boolean (Bug#9154).
2128
56cd55c8
EZ
21292011-09-18 Eli Zaretskii <eliz@gnu.org>
2130
2131 * xdisp.c (display_line): Record maximum and minimum buffer
2132 positions even if no glyphs were produced (e.g., by a zero-width
2133 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2134 buffer positions that will be removed from the glyph row because
2135 they don't fit.
c02dcedf
EZ
2136 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2137 column is beyond frame width: don't subtract 1 "pixel" when
2138 computing width of the stretch.
3e62b7e0
EZ
2139 (reseat_at_next_visible_line_start): Undo the change made on
2140 2011-09-17 that saved paragraph information and restored it after
2141 the call to `reseat'. (Bug#9545)
56cd55c8 2142
5ed99d36 21432011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2144
2145 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2146 and turn window cursor on if cleared (Bug#9415).
2147
5ed99d36 21482011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2149
2150 * search.c (boyer_moore): Take unibyte characters from pattern
2151 literally. (Bug#9458)
2152
9bade7b2
EZ
21532011-09-18 Eli Zaretskii <eliz@gnu.org>
2154
2155 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2156
e5e9d610
PE
21572011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2158
87e4427a
PE
2159 Fix minor problem found by static checking.
2160 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2161 initialized, to pacify gcc -Wuninitialized.
2162
e5e9d610
PE
2163 * fileio.c: Report proper errno when syscall falls.
2164 (Finsert_file_contents): Save and restore errno,
2165 so that report_file_error outputs the correct diagnostic.
2166 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2167
a1674f0b
EZ
21682011-09-18 Eli Zaretskii <eliz@gnu.org>
2169
2170 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2171
fbfb6dd4
EZ
21722011-09-17 Eli Zaretskii <eliz@gnu.org>
2173
2174 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2175 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2176
bb187662
EZ
21772011-09-17 Eli Zaretskii <eliz@gnu.org>
2178
1137e8b8 2179 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2180 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2181
2182 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2183 (bidi_find_paragraph_start): Search back for paragraph beginning
2184 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2185 (bidi_move_to_visually_next): Only trigger paragraph-related
2186 computations when the last character is a newline or at EOB, not
2187 just any NEUTRAL_B. (Bug#9470)
2188
bb187662
EZ
2189 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2190 truncated lines if point is covered by a display string. (Bug#9524)
2191
2e621251
PE
21922011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2193
2194 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2195 (cons_to_x_long): New function.
2196 (lisp_data_to_selection_data): Use it. Correct the test for
2197 short-versus-long data; it was negated. Break out of vector
2198 loop, for efficiency, when a long datum is discovered.
2199
91a15bc6
SM
22002011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2201
2202 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2203
b41c3a35
EZ
22042011-09-16 Eli Zaretskii <eliz@gnu.org>
2205
2206 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2207 GCC PR/17406) by declaring this function with external scope.
2208
7812ba2d
PE
22092011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2210
2211 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2212 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2213
cf7edc2a
AS
22142011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2215
2216 * editfns.c (Fformat): Correctly handle text properties on "%%".
2217
bd01620e
EZ
22182011-09-15 Eli Zaretskii <eliz@gnu.org>
2219
2220 * xterm.c (x_draw_composite_glyph_string_foreground):
2221 * w32term.c (x_draw_composite_glyph_string_foreground):
2222 * term.c (encode_terminal_code):
2223 * composite.c (composition_update_it, get_composition_id):
2224 * xdisp.c (get_next_display_element)
2225 (fill_composite_glyph_string): Add comments about special meaning
2226 of TAB characters in a composition.
2227
a02719a3
PE
22282011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2229
2230 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2231 This occurs when processing a multibyte format.
2232 Problem reported by Wolfgang Jenker.
a02719a3 2233
72589a3c
JB
22342011-09-15 Johan Bockgård <bojohan@gnu.org>
2235
2236 * xdisp.c (try_cursor_movement): Only check for exact match if
2237 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2238
1c14176c
PE
22392011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2240
2241 Remove unused external symbols.
2242 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2243 * xdisp.c (calc_pixel_width_or_height): Now static.
2244 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2245 * indent.c (check_display_width):
2246 * w32term.c: Fix comment to match code.
2247 * xterm.c, xterm.h (x_catching_errors): Remove.
2248
d2eea5b5
PE
22492011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2250
2251 * xselect.c: Use signed conversions more consistently (Bug#9498).
2252 (selection_data_to_lisp_data): Assume incoming selection data are
2253 signed integers, not unsigned. This is to be consistent with
2254 outgoing selection data, which was modified to use signed integers
2255 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2256 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2257 expects long, not unsigned long.
2258
46888499
EZ
22592011-09-14 Eli Zaretskii <eliz@gnu.org>
2260
2261 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2262 computation of loop end. Reported by Johan Bockgård
2263 <bojohan@gnu.org>.
2264
ef8ef9fb
CY
22652011-09-13 Chong Yidong <cyd@stupidchicken.com>
2266
2267 * frame.c (Fother_visible_frames_p): Function deleted.
2268
fa819fed
EZ
22692011-09-12 Eli Zaretskii <eliz@gnu.org>
2270
2271 * indent.c (compute_motion): Process display vector front to back
2272 rather than the other way around. (Bug#2496)
2273
2ba8e008
SM
22742011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2275
2276 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2277
20f53c69
CY
22782011-09-11 Chong Yidong <cyd@stupidchicken.com>
2279
2280 * minibuf.c (Fread_from_minibuffer): Doc fix.
2281
d562d7a4
EZ
22822011-09-11 Eli Zaretskii <eliz@gnu.org>
2283
2284 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2285 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2286
1c4d7f3d
LMI
22872011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2288
2289 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2290 value for non-existent files.
2291
b885bf36
EZ
22922011-09-11 Eli Zaretskii <eliz@gnu.org>
2293
2294 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2295 set its "size" to -1. This will set the modtime_size field of
2296 the corresponding buffer to -1, which is what
2297 verify-visited-file-modtime expects for files that do not exist.
2298 (Bug#9139)
2299
6612f0bf
PE
23002011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2301
2302 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2303 here ...
2304 * lisp.h: ... from here. push_key_description is no longer
2305 defined in keyboard.c, so its declaration should not be in
2306 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2307 logically belongs with push_key_description.
2308
dfb3f755
PE
23092011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2310
2311 * buffer.h: Include <sys/types.h> instead of <time.h>.
2312 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2313 Problem reported by Herbert J. Skuhra.
2314
3134906c
LMI
23152011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2316
2317 * xml.c (parse_region): Make the parsing work for
2318 non-comment-starting XML files again (bug#9144).
2319
8d903f4e
AS
23202011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2321
2322 * image.c (gif_load): Fix calculation of bottom and right corner.
2323 (Bug#9468)
2324
80ad64f4
EZ
23252011-09-10 Eli Zaretskii <eliz@gnu.org>
2326
2327 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2328 redisplay in small windows.
2329
208a048d
EZ
23302011-09-09 Eli Zaretskii <eliz@gnu.org>
2331
2332 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2333
9b1c252e
MR
23342011-09-08 Martin Rudalics <rudalics@gmx.at>
2335
2336 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2337 Operate on live windows only.
2338
2949f33b
JB
23392011-09-08 Juanma Barranquero <lekktu@gmail.com>
2340
2341 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2342
e08dcafd
EZ
23432011-09-07 Eli Zaretskii <eliz@gnu.org>
2344
2345 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2346 only under bidi iteration.
2347
115b96bd
JD
23482011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2349
2350 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2351
c8199d0f
PE
23522011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2353
2354 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2355 Without this fix, the command to link temacs failed due to an
2356 undefined symbol __builtin_isnan. This is because
2357 /usr/include/iso/math_c99.h #defines isnan(x) to
2358 __builtin_isnan(x), but the bundled gcc, which identifies itself
2359 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2360 a __builtin_isnan.
2361 * floatfns.c (isnan): #undef, and then #define to a clone of
2362 what's in data.c.
2363 (Fisnan): Always define, since it's always available now.
2364 (syms_of_floatfns): Always define isnan at the Lisp level.
2365
e39b275c 23662011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2367
2368 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2369
b2db44d9 23702011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2371
f4af5137 2372 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2373 The previous code assumed that file offsets (off_t values) fit in
2374 EMACS_INT variables, which is not true on typical 32-bit hosts.
2375 The code messed up by falsely reporting buffer overflow in cases
2376 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2377 when "big" contains more than 2**29 bytes, even though this
2378 inserts just one byte and does not overflow the buffer.
2379 (Finsert_file_contents): Store file offsets as off_t
2380 values, not as EMACS_INT values. Check for overflow when
2381 converting between EMACS_INT and off_t. When checking for
2382 buffer overflow or for overlap, take the offsets into account.
2383 Don't use EMACS_INT for small values where int suffices.
2384 When checking for overlap, fix a typo: ZV was used where
2385 ZV_BYTE was intended.
2386 (Fwrite_region): Don't assume off_t fits into 'long'.
2387 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2388
ecfc0a49
MA
23892011-09-05 Michael Albinus <michael.albinus@gmx.de>
2390
2391 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2392
6511acf2 23932011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2394
0999621a 2395 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2396
2397 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2398 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2399 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2400 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2401 (modify_event_symbol): Do not assume that the length of
2402 name_alist_or_stem is safe to alloca and fits in int.
2403 (Fexecute_extended_command): Likewise for function name and binding.
2404 (Frecursion_depth): Wrap around reliably on integer overflow.
2405 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2406 since some callers pass EMACS_INT values.
2407 (Fsingle_key_description): Don't crash if symbol name contains more
2408 than MAX_ALLOCA bytes.
2409 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2410 (get_minibuffer): Arg is now EMACS_INT, not int.
2411 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2412 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2413 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2414
2be7d702
PE
2415 * dbusbind.c (signature_cat): New function.
2416 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2417 Do not overrun buffer; instead, report string overflow.
2418
9d1df220
PE
2419 * dispnew.c (add_window_display_history): Don't overrun buffer.
2420 Truncate instead; this is OK since it's just a log.
2421
33ef5c64
PE
2422 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2423 even if the time zone offset is outlandishly large.
2424 Don't mishandle offset == INT_MIN.
2425
66c6fdd5
PE
2426 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2427 when creating daemon; the previous buffer-overflow check was incorrect.
2428
d749b01b
PE
2429 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2430 which has the guts of the old verror function.
2431
b5cd1905
PE
2432 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2433 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2434
6e1a67fb
PE
2435 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2436 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2437 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2438 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2439 length of string rather than counting it via multiple sprintfs;
2440 that's simpler and more reliable.
c21721cc
PE
2441 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2442 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2443 sprintf, in case result does not fit in int.
2444
c57b67fc
PE
2445 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2446 (fontset_from_font): Print it.
2447
8a401434
PE
2448 * frame.c (tty_frame_count): Now printmax_t, not int.
2449 (make_terminal_frame, set_term_frame_name): Print it.
2450 (x_report_frame_params): In X, window IDs are unsigned long,
2451 not signed long, so print them as unsigned.
2452 (validate_x_resource_name): Check for implausibly long names,
2453 and don't assume name length fits in 'int'.
2454 (x_get_resource_string): Don't blindly alloca invocation name;
2455 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2456 not fit in int.
2457
6e1a67fb
PE
2458 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2459 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2460 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2461
0df02bf3
PE
2462 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2463 Use esprintf, not sprintf, in case result does not fit in int.
2464
48e30793
PE
2465 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2466 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2467 it as a large positive number.
2468 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2469 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2470
a66ff6d8
PE
2471 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2472 in case result does not fit in int.
2473
aca216ff
PE
2474 * print.c (float_to_string): Detect width overflow more reliably.
2475 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2476 buffer overrun. Don't assume list length fits in 'int'. Treat
2477 print length of 0 as 0, not as infinity; to be consistent with other
2478 uses of print length in this function. Don't overflow print length
2479 index. Don't assume hash table size fits in 'long', or that
2480 vectorlike size fits in 'unsigned long'.
2481
31c286f7
PE
2482 * process.c (make_process): Use printmax_t, not int, to format
2483 process-name gensyms.
2484
55e5faa1
PE
2485 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2486
80f2e268
PE
2487 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2488 to avoid potential buffer overrun.
2489
670741ab
PE
2490 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2491 if X resource line is longer than 512 bytes.
2492
b7163a50
PE
2493 * xfns.c (x_window): Make sprintf buffer a bit bigger
2494 to avoid potential buffer overrun.
2495
ae58ff1f
PE
2496 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2497
c43c8a6a
PE
2498 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2499
3f8236f4
PE
25002011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2501
53e9fe90 2502 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2503 Without these, Emacs silently mishandles large integers sometimes.
2504 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2505 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2506
6511acf2
PE
2507 * xdisp.c (try_window_id): Check Emacs fixnum range before
2508 converting to 'int'.
806add1d 2509
6511acf2 2510 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2511 Check that an Emacs fixnum is in range before assigning it to 'int'.
2512 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2513 values converted from Emacs fixnums.
2514 (Frecenter): Don't wrap around a line count if it is out of 'int'
2515 range; instead, treat it as an extreme value.
2516 (Fset_window_configuration, compare_window_configurations):
2517 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2518
6511acf2
PE
2519 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2520 that can exceed INT_MAX. Check that EMACS_INT value is in range
2521 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2522 (match_limit): Don't assume that a fixnum can fit in 'int'.
2523
6511acf2 2524 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2525 exceed INT_MAX.
2526
6511acf2 2527 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2528 (Fvertical_motion): Don't wrap around LINES values that don't fit
2529 in 'int'. Instead, treat them as extreme values. This is good
2530 enough for windows, which can't have more than INT_MAX lines anyway.
2531
fcb901a7
LMI
25322011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2533
0f2f6b6d
LMI
2534 * Require libxml/parser.h to avoid compilation warning.
2535
fcb901a7
LMI
2536 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2537
2538 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2539 since this reportedly can destroy thread storage.
2540
6e20a0d4
CY
25412011-08-30 Chong Yidong <cyd@stupidchicken.com>
2542
2543 * syntax.c (find_defun_start): Update all cache variables if
2544 exiting early (Bug#9401).
2545
148ae00e
EZ
25462011-08-30 Eli Zaretskii <eliz@gnu.org>
2547
f6cfbd8f
EZ
2548 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2549
148ae00e
EZ
2550 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2551 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2552 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2553
2554 * term.c (tty_append_glyph): New function.
2555 (produce_stretch_glyph): Static function and its prototype deleted.
2556
a66cfb1c
SM
2557 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2558 Add prototypes.
148ae00e 2559
c4a07a4c
PE
25602011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2561
2562 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2563 when checking :margin (Bug#9390).
2564 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2565 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2566 so that the name doesn't mislead. All uses changed.
2567
6bc8cd65
JB
25682011-08-28 Johan Bockgård <bojohan@gnu.org>
2569
2570 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2571 set_tty_hooks.
2572
dca4927e
EZ
25732011-08-27 Eli Zaretskii <eliz@gnu.org>
2574
2575 * xdisp.c (move_it_to): Don't bail out early when reaching
2576 position beyond to_charpos, if we are scanning backwards.
2577 (move_it_vertically_backward): When DY == 0, make sure we get to
2578 the first character in the line after the newline.
2579
f2cad773
PE
25802011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2581
2582 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2583 (ccl_driver): Do not generate an out-of-range pointer.
2584 (Fccl_execute_on_string): Remove unnecessary check for
2585 integer overflow, noted by Stefan Monnier in
2586 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2587 Remove a FIXME that didn't need fixing.
2588 Simplify the newly-introduced buffer reallocation code.
2589
0cae2cdb
JB
25902011-08-27 Juanma Barranquero <lekktu@gmail.com>
2591
2592 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2593
5fc295a4 25942011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2595
70c60eb2 2596 Integer and memory overflow issues (Bug#9196).
726e0ab1 2597
d31850da
PE
2598 * doc.c (get_doc_string): Rework so that
2599 get_doc_string_buffer_size is the actual buffer size, rather than
2600 being 1 less than the actual buffer size; this makes xpalloc more
2601 convenient.
2602
a69fbedb
PE
2603 * image.c (x_allocate_bitmap_record, cache_image):
2604 * xselect.c (Fx_register_dnd_atom):
2605 Simplify previous changes by using xpalloc.
2606
fe5c5d37
PE
2607 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2608 since either will do and ptrdiff_t is convenient with xpalloc.
2609
0065d054
PE
2610 * charset.c (charset_table_size)
2611 (struct charset_sort_data.priority): Now ptrdiff_t.
2612 (charset_compare): Don't overflow if priorities differ greatly.
2613 (Fsort_charsets): Don't assume list length fits in int.
2614 Check for size-calculation overflow when allocating sort data.
2615 (syms_of_charset): Allocate an initial charset table that is
2616 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2617
2618 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2619
2620 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2621 The actual value is always <= INT_MAX, and leaving it unsigned made
2622 overflow checking harder.
2623
2624 * dispextern.h (struct glyph_matrix.rows_allocated)
2625 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2626 with xpalloc. The values are still always <= INT_MAX.
2627
2628 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2629
2630 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2631 (SAFE_NALLOCA): New macro.
2632
2633 * region-cache.c (struct boundary.pos, find_cache_boundary)
2634 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2635 (set_cache_region, invalidate_region_cache)
2636 (revalidate_region_cache, know_region_cache, region_cache_forward)
2637 (region_cache_backward, pp_cache):
2638 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2639 so that ptrdiff_t * can be passed to xpalloc.
2640 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2641 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2642 (pp_cache): Don't assume cache_len fits in int.
2643 * region-cache.h: Adjust extern decls to match.
2644
2645 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2646 EMACS_INT, since either will do, for xpalloc.
2647
2648 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2649 (xnmalloc, xnrealloc, xpalloc): New functions.
2650
726e0ab1
PE
2651 * bidi.c (bidi_shelve_header_size): New constant.
2652 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2653 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2654
51f30bc5 2655 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2656 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2657 (overlay_strings):
2658 Don't update size of array until after memory allocation succeeds,
2659 because xmalloc/xrealloc may not return.
0065d054
PE
2660 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2661 now that we have proper integer overflow checking.
2662 (record_overlay_string, overlay_strings): Catch overflows when
2663 calculating size of overlay_str_buf.
726e0ab1 2664
0065d054
PE
2665 * callproc.c (Fcall_process): Check for size overflow when
2666 calculating size of args2.
2667 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2668 Normally we prefer signed values, but sticking with ptrdiff_t would
2669 require adding more-complicated checks.
726e0ab1
PE
2670
2671 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2672 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2673 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2674 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2675
2676 * character.c (Fstring): Check for size-calculation overflow.
2677
2678 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2679 unnecessary integer overflow. Check for size overflow.
2680 (encode_coding_object): Don't update size until xmalloc succeeds.
2681
2682 * composite.c (get_composition_id): Check for overflow in glyph
2683 length calculations.
2684
2685 Integer and memory overflow fixes for display code.
2686 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2687 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2688 (scrolling_window): Check for overflow in size calculations.
2689 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2690 Don't assume glyph table len fits in int.
2691 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2692 (row_table_size): Now ptrdiff_t, not int.
2693 (scrolling_window): Avoid overflow in size calculations.
2694 Don't update size until allocation succeeds.
2695 * fns.c (concat): Check for overflow in size calculations.
2696 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2697 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2698 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2699
2700 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2701 (get_doc_string): Check for size calculation overflow.
2702 Don't update size until allocation succeeds.
2703 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2704 EMACS_INT, where ptrdiff_t will do.
2705 (Fsubstitute_command_keys): Check for string overflow.
2706
2707 * editfns.c (set_time_zone_rule): Don't assume environment length
2708 fits in int.
2709 (message_length): Now ptrdiff_t, not int.
2710 (Fmessage_box): Don't update size until allocation succeeds.
2711 Don't assume message length fits in int.
2712 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2713
0065d054
PE
2714 * emacs.c (main): Do not reallocate argv, since there is a null at
2715 the end that can be overwritten, and this way there's no need to
2716 worry about size-calculation overflow.
2717 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2718
2719 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2720 alloc succeeds.
2721 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2722
2723 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2724 (x_set_scroll_bar_width, x_figure_window_size):
2725 Check for integer overflow.
2726 (x_set_alpha): Do not assume XINT fits in int.
2727
2728 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2729 This is for the members text_lines, text_cols, total_lines, total_cols,
2730 where the system imposes an 'int' limit.
2731
2732 * fringe.c (Fdefine_fringe_bitmap):
2733 Don't update size until alloc works.
2734
2735 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2736 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2737
2738 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2739 Check for size-calculation overflow.
2740 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2741 do, as we prefer signed integers.
2742 (id_to_widget.max_size, id_to_widget.used)
2743 (xg_store_widget_in_map, xg_remove_widget_from_map)
2744 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2745 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2746 Use and return ptrdiff_t, not int.
2747 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2748 * gtkutil.h: Change prototypes to match the above.
2749
2750 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2751 are duplicate now that they've been promoted to lisp.h.
2752 (x_allocate_bitmap_record, x_alloc_image_color)
2753 (make_image_cache, cache_image, xpm_load):
2754 Don't update size until alloc is done.
2755 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2756 (x_detect_edges):
3256efce 2757 Check for size calculation overflow.
726e0ab1
PE
2758 (ct_colors_allocated_max): New constant.
2759 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2760 overflow.
3256efce 2761
726e0ab1
PE
2762 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2763 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2764 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2765 Use ptrdiff_t, not int, to count maps.
2766 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2767 calculations. Don't update size until allocation succeeds.
2768 Redo calculations to avoid overflow.
726e0ab1
PE
2769 * keyboard.h: Change prototypes to match the above.
2770
2771 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2772 to count maps.
2773 (current_minor_maps): Check for size calculation overflow.
2774 * keymap.h: Change prototypes to match the above.
2775
2776 * lread.c (read1, init_obarray): Don't update size until alloc done.
2777
2778 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2779 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2780
726e0ab1
PE
2781 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2782 Now ptrdiff_t, not int.
2783 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2784 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2785
2786 * process.c (Fnetwork_interface_list): Check for overflow
2787 in size calculation.
2788
2789 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2790
2791 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2792 overflow. Don't bother calling xmalloc when xrealloc will do.
2793
2794 * search.c (Freplace_match): Check for size calculation overflow.
2795 (Fset_match_data): Don't assume list lengths fit in 'int'.
2796
2797 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2798 for command line length. Do not attempt to address one before the
2799 beginning of an array, as that's not portable.
2800
2801 * term.c (max_frame_lines): Remove; unused.
2802 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2803 not int.
2804 (encode_terminal_code, calculate_costs): Check for size
2805 calculation overflow.
2806 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2807 table lengths and related sizes. Don't update size until alloc
2808 done. Redo calculations to avoid overflow.
2809 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2810
2811 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2812 subtracting pointers.
2813 (gobble_line): Check for overflow more carefully. Don't update size
2814 until alloc done.
2815
2816 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2817 Don't update size until alloc done.
2818 Redo size calculations to avoid overflow.
2819 Check for size calculation overflow.
0065d054 2820 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2821
2822 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2823 Use ptrdiff_t, not int, for sizes.
2824 (store_mode_line_noprop_char): Don't update size until alloc done.
2825
0065d054
PE
2826 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2827 Use ptrdiff_t, not int, for sizes.
2828 (Finternal_make_lisp_face, cache_face):
2829 Check for size calculation overflow.
2830 (cache_face): Treat size calculation overflows as if they were
2831 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2832
2833 * xfns.c (x_encode_text, x_set_name_internal)
2834 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2835 sizes, since they can exceed INT_MAX in size. Check for size
2836 calculation overflow.
2837
0065d054
PE
2838 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2839 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2840 Don't update size until alloc done.
2841
0065d054 2842 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2843 as sprintf is limited to int lengths.
1d526e2f 2844
252c5ee1
PE
2845 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2846 (X_LONG_MIN): New macros.
864d7ce7
PE
2847 Use them to make the following changes clearer.
2848 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2849 This change doesn't affect the value now, but it may help remind
2850 future maintainers not to raise the value too much later.
2851 (SELECTION_QUANTUM): Remove, replacing with ...
2852 (selection_quantum): ... new function, which avoids overflow.
2853 All uses changed.
2854 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2855 assumption that selection length fits in 'int'.
2856 (x_reply_selection_request, x_handle_selection_request)
2857 (x_get_window_property, receive_incremental_selection)
2858 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2859 (lisp_data_to_selection_data, clean_local_selection_data):
2860 Use ptrdiff_t, not int, to record length of selection.
2861 (x_reply_selection_request, x_get_window_property)
2862 (receive_incremental_selection, x_property_data_to_lisp):
2863 Redo calculations to avoid overflow.
2864 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2865 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2866 something.
2867 (x_get_window_property, receive_incremental_selection)
2868 (lisp_data_to_selection_data, x_property_data_to_lisp):
2869 Check for size-calculation overflow.
2870 (x_get_window_property, receive_incremental_selection)
2871 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2872 Don't store size until memory allocation succeeds.
2873 (x_get_window_property): Plug memory leak on memory exhaustion.
2874 Don't double-block input; malloc is safe here. Don't assume 2**34
2875 - 4 fits in unsigned long. Add an xassert to check
2876 XGetWindowProperty overflow. Be more careful about overflow
2877 calculations, and distinguish size from memory overflow better.
2878 (receive_incremental_selection): When tracing, don't assume
2879 unsigned int is less than INT_MAX.
2880 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2881 harmful) conversions of unsigned short to int.
2882 (lisp_data_to_selection_data): Don't assume that integers
2883 in the range -65535 through -1 fit in an X unsigned short.
2884 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2885 result parameters unless successful. Rely on cons_to_unsigned
2886 to report problems with elements; the old code wasn't right anyway.
2887 (x_check_property_data): Check for int overflow; we cannot use
2888 a wider type due to X limits.
2889 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2890
726e0ab1 2891 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2892
0065d054
PE
2893 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2894 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2895 (x_color_cells): Don't store size until memory allocation succeeds.
2896 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2897 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2898 (x_term_init): Don't assume length fits in int (sprintf is limited
2899 to int size).
bc18e09d 2900
ebfa62c0
PE
2901 Use ptrdiff_t for composition IDs.
2902 * character.c (lisp_string_width):
2903 * composite.c (composition_table_size, n_compositions)
2904 (get_composition_id, composition_gstring_from_id):
2905 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2906 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2907 * window.c (Frecenter):
2908 Use ptrdiff_t, not int, for composition IDs.
2909 * composite.c (get_composition_id): Check for integer overflow.
2910 * composite.h: Adjust prototypes to match the above changes.
2911
d3411f89
PE
2912 Use ptrdiff_t for hash table indexes.
2913 * category.c (hash_get_category_set):
2914 * ccl.c (ccl_driver):
2915 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2916 * coding.c (coding_system_charset_list, detect_coding_system):
2917 * coding.h (struct coding_system.id):
2918 * composite.c (get_composition_id, gstring_lookup_cache):
2919 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2920 * image.c (xpm_get_color_table_h):
2921 * lisp.h (hash_lookup, hash_put):
2922 * minibuf.c (Ftest_completion):
2923 Use ptrdiff_t for hash table indexes, not int (which is too
2924 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2925 32-bit --with-wide-int hosts).
2926
e097a6fa
PE
2927 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2928 Add a FIXME comment about memory leaks.
2929 (syms_of_charset): Don't assume xmalloc returns.
2930
5637687f
PE
2931 Don't assume that stated character widths fit in int.
2932 * character.c (Fchar_width, c_string_width, lisp_string_width):
2933 * character.h (CHAR_WIDTH):
2934 * indent.c (MULTIBYTE_BYTES_WIDTH):
2935 Use sanitize_char_width to avoid undefined and/or bad behavior
2936 with outlandish widths.
a66cfb1c 2937 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2938 now that we have two such functions. All uses changed.
2939 (sanitize_char_width): New inline function.
2940
a2271ba2
PE
2941 Don't assume that tab-width fits in int.
2942 * character.h (sanitize_width): New inline function.
2943 (SANE_TAB_WIDTH): New macro.
2944 (ASCII_CHAR_WIDTH): Use it.
2945 * indent.c (sane_tab_width): Remove. All uses replaced by
2946 SANE_TAB_WIDTH (current_buffer).
2947 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2948
18c52557
PE
2949 * fileio.c: Integer overflow issues with file modes.
2950 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2951
caeeedc1
PE
2952 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2953 Remove unreachable code.
2954 (read_hex, load_charset_map_from_file): Check for integer overflow.
2955
6df6ae42 2956 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2957 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2958 (x_send_scroll_bar_event): Likewise. Check that the size does not
2959 exceed limits imposed by XClientMessageEvent, as well as the usual
2960 ptrdiff_t and size_t limits.
2961
b13995db
PE
2962 * keyboard.c: Overflow, signedness and related fixes.
2963 (make_lispy_movement): Use same integer type in forward decl
2964 that is used in the definition.
2965 (read_key_sequence, keyremap_step):
2966 Change bufsize argument back to int, undoing my 2011-03-30 change.
2967 We prefer signed types, and int is wide enough here.
2968 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
2969 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
2970 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
2971 length, not size_t. Use ptrdiff_t for index, not int.
2972 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
2973 possibility of integer overflow.
2974
13464394
PE
2975 Overflow, signedness and related fixes for images.
2976
2977 * dispextern.h (struct it.stack[0].u.image.image_id)
2978 (struct_it.image_id, struct image.id, struct image_cache.size)
2979 (struct image_cache.used, struct image_cache.ref_count):
2980 * gtkutil.c (update_frame_tool_bar):
2981 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
2982 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
2983 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
2984 * nsmenu.m (update_frame_tool_bar):
2985 * xdisp.c (calc_pixel_width_or_height):
2986 * xfns.c (image_cache_refcount):
2987 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
2988 on typical 64-bit hosts.
2989
2990 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2991 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
2992 Omit unnecessary casts to int.
2993 (parse_image_spec): Check that integers fall into 'int' range
2994 when the callers expect that.
2995 (image_ascent): Redo ascent calculation to avoid int overflow.
2996 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
2997 (lookup_image): Remove unnecessary tests.
2998 (xbm_image_p): Locals are now of int, not EMACS_INT,
2999 since parse_image_check makes sure they fit into int.
3000 (png_load, gif_load, svg_load_image):
3001 Prefer int to unsigned where either will do.
3002 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3003 old tiff_error_handler and tiff_warning_handler.
3004 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3005 stack buffer overflows. It uses only the features of vsnprintf
3006 that are common to both POSIX and native Microsoft.
3007 (tiff_error_handler, tiff_warning_handler): Use it.
3008 (tiff_load, gif_load, imagemagick_load_image):
3009 Don't assume :index value fits in 'int'.
3010 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3011 (imagemagick_load_image): Check that crop parameters fit into
3012 the integer types that MagickCropImage accepts. Don't assume
3013 Vimagemagick_render_type has a nonnegative value. Don't assume
3014 size_t fits in 'long'.
3015 (gs_load): Use printmax_t to print the widest integers possible.
3016 Check for integer overflow when computing image height and width.
3017
c11821d4
EZ
30182011-08-26 Eli Zaretskii <eliz@gnu.org>
3019
3020 * xdisp.c (redisplay_window): Don't force window start if point
3021 will be invisible in the resulting window. (Bug#9324)
3022
0c95fcf7
EZ
30232011-08-25 Eli Zaretskii <eliz@gnu.org>
3024
3025 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3026 the display spec is of the form `(space ...)'.
3027 (handle_display_spec): Return the value returned by
3028 handle_single_display_spec, not just 1 or zero.
3029 (handle_single_display_spec): If the display spec is of the form
3030 `(space ...)', and specifies display in the text area, return 2
3031 rather than 1.
fee65a97 3032 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3033 accurately, and prefer exact match for point under bidi.
3034 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3035
3036 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3037 into disp_prop; all users changed.
3038
3039 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3040 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3041 for the text covered by the display property.
3042
e4ed06f1
CY
30432011-08-25 Chong Yidong <cyd@stupidchicken.com>
3044
3045 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3046 Change return value to nil.
3047 (Frecord_buffer): Delete unused function.
3048
f67cdd7f
EZ
30492011-08-24 Eli Zaretskii <eliz@gnu.org>
3050
5980d4c6
EZ
3051 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3052 buffers, return left-to-right.
8610fe8b
EZ
3053 (set_cursor_from_row): Consider candidate row a win if its glyph
3054 represents a newline and point is on that newline. Fixes cursor
3055 positioning on the newline at EOL of R2L text within L2R
3056 paragraph, and vice versa.
3057 (try_cursor_movement): Check continued rows, in addition to
3058 continuation rows. Fixes unwarranted scroll when point enters a
3059 continued line of R2L text within an L2R paragraph, or vice versa.
3060 (cursor_row_p): Consider the case of point being equal to
3061 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3062 from the end of a short line to the beginning of a continued line
3063 of R2L text within L2R paragraph.
3064 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3065 composed characters.
5980d4c6 3066
f67cdd7f
EZ
3067 * bidi.c (bidi_check_type): Use xassert.
3068 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3069 members.
3070
bca633fb
EZ
30712011-08-23 Eli Zaretskii <eliz@gnu.org>
3072
3073 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3074 a character.
3075
4a5885a7
CY
30762011-08-23 Chong Yidong <cyd@stupidchicken.com>
3077
3078 * nsfont.m (ns_otf_to_script): Fix typo.
3079
0902a04e
KH
30802011-08-22 Kenichi Handa <handa@m17n.org>
3081
3082 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3083 extra slot even if the purpose is char-code-property-table.
3084
1a2e6670
EZ
30852011-08-23 Eli Zaretskii <eliz@gnu.org>
3086
8ddde651
EZ
3087 * xdisp.c (redisplay_window): When computing centering_position,
3088 account for the height of the header line. (Bug#8874)
3089
425cc014
EZ
3090 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3091 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3092 candidate is selected by the mouse, and that candidate has a
3093 composed character under the mouse.
3094
1a2e6670
EZ
3095 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3096 coordinates reported by pos-visible-in-window-p for a composed
3097 character in column zero.
3098
8b76d6f8
SM
30992011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3100
3101 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3102
dac347dd
EZ
31032011-08-22 Eli Zaretskii <eliz@gnu.org>
3104
3105 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3106 consider it a hit if to_charpos is anywhere in the range of the
3107 composed buffer positions.
3108
e013fb34
CY
31092011-08-22 Chong Yidong <cyd@stupidchicken.com>
3110
3111 * image.c (gif_load): Don't assume that each subimage has the same
3112 dimensions as the base image. Handle disposal method that is
3113 "undefined" by the gif spec (Bug#9335).
3114
bd1ba3e8
CY
31152011-08-20 Chong Yidong <cyd@stupidchicken.com>
3116
3117 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3118 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3119
54a1215b
EZ
31202011-08-19 Eli Zaretskii <eliz@gnu.org>
3121
823564e5
EZ
3122 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3123 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3124 from an Org mode buffer to a Speedbar frame.
3125
54a1215b
EZ
3126 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3127 a composition, take its buffer position from IT->cmp_it.charpos.
3128 Fixes cursor positioning at the beginning of a line that begins
3129 with a composed character.
3130
9778ebcc
EZ
31312011-08-18 Eli Zaretskii <eliz@gnu.org>
3132
0be6ee06
EZ
3133 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3134 character bidirectional type, use STRONG_L instead. Fixes crashes
3135 in a buffer produced by `describe-categories'.
3136
9778ebcc
EZ
3137 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3138 members before the level stack, so they would be saved and
3139 restored when copying iterator state. Fixes incorrect reordering
3140 around TABs covered by display properties.
3141
156bffbe
AS
31422011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3143
6b02f655 3144 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3145
72ad093b
CY
31462011-08-17 Chong Yidong <cyd@stupidchicken.com>
3147
3148 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3149 (internal_condition_case_2, internal_condition_case_n):
3150 Remove unnecessary aborts (Bug#9081).
72ad093b 3151
35774242
EZ
31522011-08-17 Eli Zaretskii <eliz@gnu.org>
3153
3154 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3155 has no `load' handler, try opening the file locally. (Bug#9311)
3156
db76dd85
KB
31572011-08-16 Ken Brown <kbrown@cornell.edu>
3158
3159 * gmalloc.c: Expand comment.
3160
b215eee5
EZ
31612011-08-16 Eli Zaretskii <eliz@gnu.org>
3162
3163 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3164 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3165
a4579d33
KB
31662011-08-16 Ken Brown <kbrown@cornell.edu>
3167
3168 Fix memory allocation problems in Cygwin build (Bug#9273).
3169
3170 * unexcw.c ( __malloc_initialized): Declare external variable.
3171 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3172
8b76d6f8
SM
3173 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3174 New variables.
a4579d33
KB
3175 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3176 dumped emacs.
3177 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3178 in the static heap.
3179 [CYGWIN] (special_realloc): New function.
3180 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3181 requests to realloc storage in the static heap.
3182
3ebec551
PE
31832011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3184
3185 * bidi.c (bidi_initialize): Remove unused local.
3186
9fd8be00
EZ
31872011-08-15 Eli Zaretskii <eliz@gnu.org>
3188
6b02f655
SM
3189 * bidimirror.h:
3190 * biditype.h: Remove file.
3191 * makefile.w32-in ($(BLD)/bidi.$(O)):
3192 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3193
3194 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3195
3196 * chartab.c: Improve commentary for the uniprop_table API.
3197
32413314
EZ
3198 * bidi.c (bidi_paragraph_init): Support zero value of
3199 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3200 (bidi_initialize): Use uniprop_table instead of including
3201 biditype.h and bidimirror.h.
32413314 3202
9fd8be00
EZ
3203 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3204 coordinates of the iterator when restoring from ppos_it.
3205 (Bug#9296)
3206
5cf2b69b
KH
32072011-08-14 Kenichi Handa <handa@m17n.org>
3208
3209 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3210 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3211
daf17d00
EZ
32122011-08-14 Eli Zaretskii <eliz@gnu.org>
3213
3214 * xdisp.c (move_it_in_display_line_to): Don't invoke
3215 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3216 ppos_it. Fixes vertical cursor motion when line beginning is
3217 covered by an image. (Bug#9296)
3218
08e3161a
JD
32192011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3220
3221 * nsterm.h (ns_run_ascript): Declare.
3222 (NSAPP_DATA2_RUNASSCRIPT): Define.
3223
3224 * nsfns.m (as_script, as_result, as_status): New static variables.
3225 (ns_run_ascript): New function.
5e617bc2 3226 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3227 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3228 the event loop. Get status from as_status (Bug#7276).
3229
3230 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3231 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3232 the event loop (Bug#7276).
3233
a3720aa2
AS
32342011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3235
3236 * gnutls.c (QCgnutls_bootprop_priority)
3237 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3238 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3239 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3240 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3241 (QCgnutls_bootprop_verify_hostname_error)
3242 (QCgnutls_bootprop_callbacks_verify): Rename from
3243 Qgnutls_bootprop_..., all uses changed.
3244
3245 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3246 uses changed.
3247
0a0d27fb
PE
32482011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3249
19d5c50c
PE
3250 * xfaces.c (Qframe_set_background_mode): Now static.
3251 * dispextern.h (Qframe_set_background_mode): Remove decl.
3252
0a0d27fb
PE
3253 * process.c (Fnetwork_interface_info): Declare local only if needed.
3254
377538cb
JD
32552011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3256
3257 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3258 (Fnetwork_interface_list): Allocate in increments of bytes instead
3259 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3260 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3261 sockaddr.
3262 (struct ifflag_def): notrailers is smart on OSX.
3263 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3264 Get hardware address with getifaddrs if available.
3265
08fff70c
EZ
32662011-08-12 Eli Zaretskii <eliz@gnu.org>
3267
3268 * xdisp.c (iterate_out_of_display_property): xassert that
3269 IT->position is set to within IT->object's boundaries. Break from
3270 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3271 when IT->position is set up wrongly due to some bug.
3272 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3273 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3274 entry. Force push_it to save on the stack the current
3275 buffer/string position, to be restored by pop_it. Fix flags in
3276 the iterator structure wrt the object coming from a display
3277 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3278 properties. (Bug#9284)
3279
7be1c708 32802011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3281
7be1c708
CY
3282 * fontset.c (fontset_get_font_group): Add proper type checks.
3283 (Bug#9172)
aac0c6e3 3284
7be1c708 32852011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3286
7be1c708
CY
3287 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3288 and LC_VERSION_MIN_MACOSX.
3289 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3290 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3291
97bb72a6
EZ
32922011-08-08 Eli Zaretskii <eliz@gnu.org>
3293
3294 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3295 no-display-properties-and-no-overlays under bidi display.
3296 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3297 properties and overlays.
97bb72a6 3298
d5617611
CY
32992011-08-08 Chong Yidong <cyd@stupidchicken.com>
3300
37e11a63
CY
3301 * editfns.c (Fset_time_zone_rule): Document relationship with the
3302 setenv function.
3303
d5617611
CY
3304 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3305 the font entity extracted from the cache (Bug#8109).
3306
58872834
CY
33072011-08-07 Chong Yidong <cyd@stupidchicken.com>
3308
3309 * composite.c (autocmp_chars): Don't reset point. That is done by
3310 restore_point_unwind (Bug#5984).
3311
75bfc667
JL
33122011-08-07 Juri Linkov <juri@jurta.org>
3313
3314 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3315 to show the arg `TIME' instead of `TIMEVAL'.
3316
d1410150
EZ
33172011-08-06 Eli Zaretskii <eliz@gnu.org>
3318
3319 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3320 display property strides EOL and includes a newline, as in
3321 longlines-mode. (Bug#9254)
75b771e4
EZ
3322 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3323 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3324
3325 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3326 is non-zero, even if the data buffer is NULL. Fixes a crash in
3327 vertical-motion with longlines-mode. (Bug#9254)
3328
35928349
EZ
33292011-08-05 Eli Zaretskii <eliz@gnu.org>
3330
ec7cc85b
EZ
3331 * bidi.c <bidi_cache_total_alloc>: Now static.
3332 (bidi_initialize): Initialize bidi_cache_total_alloc.
3333
8b76d6f8 3334 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3335 cache. (Bug#9221)
3336
3337 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3338 amount allocated this far in `bidi_cache_total_alloc'.
3339 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3340 non-zero, only free the data buffer without restoring the cache
3341 contents. All callers changed.
3342
3343 * dispextern.h (bidi_unshelve_cache): Update prototype.
3344
3345 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3346 (move_it_in_display_line, move_it_to)
3347 (move_it_vertically_backward, move_it_by_lines): Replace the call
3348 to xfree to an equivalent call to bidi_unshelve_cache.
3349 (move_it_in_display_line_to): Fix logic of returning
412b6358 3350 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3351
e2e2423b
EZ
33522011-08-05 Eli Zaretskii <eliz@gnu.org>
3353
3354 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3355 came from a string character with a `cursor' property. (Bug#9229)
3356
ae9e757a
JD
33572011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3358
3359 * Makefile.in (LIB_PTHREAD): New variable.
3360 (LIBES): Add LIB_PTHREAD (Bug#9216).
3361
3362 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3363 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3364
213bd7f2
AS
33652011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3366
6b02f655 3367 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3368
99aaf75f
JD
33692011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3370
3371 * xterm.c (x_find_topmost_parent): New function.
3372 (x_set_frame_alpha): Find topmost parent window with
3373 x_find_topmost_parent and set the property there also (bug#9181).
3374 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3375
c74e9d86
PE
33762011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3377
3378 * callproc.c (Fcall_process): Avoid vfork clobbering
3379 the local vars buffer, coding_systems, current_dir.
3380
640c8776
SM
33812011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3382
3383 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3384
f26d0e4c
PE
33852011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3386
8a10d76c
PE
3387 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3388 so that it is not optimized away.
3389
f26d0e4c
PE
3390 * xdisp.c (compute_display_string_pos): Remove unused local.
3391
55439c61
EZ
33922011-08-02 Eli Zaretskii <eliz@gnu.org>
3393
3394 Fix slow cursor motion and scrolling in large buffers with
3395 selective display, like Org Mode buffers. (Bug#9218)
3396
3397 * dispextern.h (struct bidi_it): New member disp_prop_p.
3398
3399 * xdisp.c: Remove one-slot cache of display string positions.
3400 (compute_display_string_pos): Accept an additional argument
5e617bc2 3401 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3402 for a display string or property. If found, set DISP_PROP_P
3403 non-zero.
3404
3405 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3406 DISP_PROP_P, and pass it to compute_display_string_pos.
3407 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3408 non-zero. All callers of bidi_fetch_char changed.
3409
fb33fa43
SM
34102011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3411
3412 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3413
b099e063
DM
34142010-12-03 Don March <don@ohspite.net>
3415
3416 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3417 last character M-[char] is translated to ESC [char] (bug#7541).
3418
5cc7f7af
KH
34192011-08-02 Kenichi Handa <handa@m17n.org>
3420
d0fffa3f 3421 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3422
3423 * chartab.c (uniprop_table): Make it non-static.
3424
525d5e6e
EZ
34252011-08-01 Eli Zaretskii <eliz@gnu.org>
3426
3427 * xdisp.c (forward_to_next_line_start): Accept additional argument
3428 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3429 on the newline.
3430 (reseat_at_next_visible_line_start): Use the bidi iterator state
3431 returned by forward_to_next_line_start to restore the state of
3432 it->bidi_it after backing up to previous newline. (Bug#9212)
3433
31011111
AS
34342011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3435
3436 * regex.c (re_comp): Protoize.
3437 (re_exec): Fix return type.
3438 (regexec): Fix type of `ret'. (Bug#9203)
3439
476371c4
PE
34402011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3441
e5d76069
PE
3442 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3443 This is needed if max-image-size is a floating-point number.
3444
9a79b20c
AS
34452011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3446
3447 * print.c (print_object): Print empty symbol as ##.
3448
3449 * lread.c (read1): Read ## as empty symbol.
3450
d8c2fa78
AA
34512011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3452
3453 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3454 setting frame foreground color (Bug#9175).
3455 (x_set_background_color): Likewise.
3456
ffe57a7a
AA
3457 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3458 contents (Bug#9176).
3459 (EmacsTooltip -init): Remove bezels and add shadows to
3460 tooltip windows.
3461
bf3492a5
AA
3462 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3463 or scroll bar (Bug#8470).
3464
d55e9c53
AA
3465 * nsfont.m (nsfont_open): Remove assignment to voffset and
3466 unnecessary vars hshink, expand, hd, full_height, min_height.
3467 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3468
3469 * nsterm.h (nsfont_info): Remove voffset field.
3470
d8c2fa78 34712011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3472
3473 Implement strike-through and overline on NextStep (Bug#8863).
3474
3475 * nsfont.m (nsfont_open): Use underline position provided by font,
3476 instead of hard-coded value of 2.
3477 (nsfont_draw): Call ns_draw_text_decoration instead.
3478
3479 * nsterm.h: Add declaration for ns_draw_text_decoration.
3480
3481 * nsterm.m (ns_draw_text_decoration): New function for drawing
3482 underline, overline, and strike-through.
3483 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3484 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3485 accommodate underlining, etc.
4843aac3 3486
4cc60b9b
EZ
34872011-07-28 Eli Zaretskii <eliz@gnu.org>
3488
bc7ece87
EZ
3489 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3490 default.
4cc60b9b 3491
476371c4
PE
34922011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3493
66606eea
PE
3494 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3495 Without this fix, if a signal arrives just after memory fills up,
3496 'malloc' might be invoked reentrantly.
3497
476371c4
PE
3498 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3499 In other words, assume that every image size is allowed, on non-X
3500 hosts. This assumption is probably wrong, but it lets Emacs compile.
3501
f3fcc40d
AS
35022011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3503
3504 * regex.c (re_iswctype): Convert return values to boolean.
3505
350c992f
EZ
35062011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3507
3508 * xdisp.c (compute_display_string_pos): Don't use cached display
3509 string position if the buffer had its restriction changed.
3510 (Bug#9184)
3511
5266b4bb
PE
35122011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3513
3514 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3515
2573a837 35162011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3517
41f55ccd 3518 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3519
39e378da
PE
3520 * bidi.c: Integer size and overflow fixes.
3521 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3522 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3523 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3524 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3525 (bidi_find_other_level_edge):
3526 Use ptrdiff_t instead of EMACS_INT where either will do.
3527 This works better on 32-bit hosts configured --with-wide-int.
3528 (bidi_cache_ensure_space): Check for size-calculation overflow.
3529 Use % rather than repeated addition, for better worst-case speed.
3530 Don't set bidi_cache_size until after xrealloc returns, because it
3531 might not return.
3532 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3533 (bidi_cache_ensure_space): Also check that the bidi cache size
3534 does not exceed that of the largest Lisp string or buffer. See Eli
3535 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3536
5e927815
PE
3537 * alloc.c (__malloc_size_t): Remove.
3538 All uses replaced by size_t. See Andreas Schwab's note
3539 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3540
ca4aa935
PE
3541 * image.c: Improve checking for integer overflow.
3542 (check_image_size): Assume that f is nonnull, since
3543 it is always nonnull in practice. This is one less thing to
3544 worry about when checking for integer overflow later.
3545 (x_check_image_size): New function, which checks for integer
3546 overflow issues inside X.
3547 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3548 This removes the need for a memory_full check.
3549 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3550 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3551 (xbm_read_bitmap_data): Change locals back to 'int', since
3552 their values must fit in 'int'.
3553 (xpm_load_image, png_load, tiff_load):
3554 Invoke x_create_x_image_and_pixmap earlier,
3555 to avoid much needless work if the image is too large.
3556 (tiff_load): Treat overly large images as if
3557 x_create_x_image_and_pixmap failed, not as malloc failures.
3558 (gs_load): Use x_check_image_size.
3559
5f8f9cc2
PE
3560 * gtkutil.c: Omit integer casts.
3561 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3562 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3563
5adf60bc
PE
3564 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3565
c8907a93
PE
3566 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3567 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3568 would wrongly return t on a 64-bit host.
3569
e3c25c68
PE
3570 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3571 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3572 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3573 and therefore cause GCC to emit a bogus diagnostic in some cases.
3574
3f791afe
PE
3575 * image.c: Integer signedness and overflow and related fixes.
3576 This is not an exhaustive set of fixes, but it's time to
3577 record what I've got.
3578 (lookup_pixel_color, check_image_size): Remove redundant decls.
3579 (check_image_size): Don't assume that arbitrary EMACS_INT values
3580 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3581 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3582 (tiff_load, imagemagick_load_image):
3583 Check for overflow in size calculations.
3584 (x_create_x_image_and_pixmap): Remove unnecessary test for
3585 xmalloc returning NULL; that can't happen.
3586 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3587 (xpm_color_bucket): Use better integer hashing function.
3588 (xpm_cache_color): Don't possibly over-allocate memory.
3589 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3590 (gif_memory_source):
3591 Use ptrdiff_t, not int or size_t, to record sizes.
3592 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3593 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3594 either works, as we prefer signed integers.
3595 (tiff_read_from_memory, tiff_write_from_memory):
3596 Return tsize_t, not size_t, since that's what the TIFF API wants.
3597 (tiff_read_from_memory): Don't fail simply because the read would
3598 go past EOF; instead, return a short read.
3599 (tiff_load): Omit no-longer-needed casts.
3600 (Fimagemagick_types): Don't assume size fits into 'int'.
3601
3cc5a532
PE
3602 Improve hashing quality when configured --with-wide-int.
3603 * fns.c (hash_string): New function, taken from sxhash_string.
3604 Do not discard information about ASCII character case; this
3605 discarding is no longer needed.
3606 (sxhash-string): Use it. Change sig to match it. Caller changed.
3607 * lisp.h: Declare it.
3608 * lread.c (hash_string): Remove, since we now use fns.c's version.
3609 The fns.c version returns a wider integer if --with-wide-int is
3610 specified, so this should help the quality of the hashing a bit.
3611
b312a492
PE
3612 * emacs.c: Integer overflow minor fix.
3613 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3614 Define only if GNU_LINUX.
3615 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3616
dfd153ae
PE
3617 * dispnew.c: Integer signedness and overflow fixes.
3618 Remove unnecessary forward decls, that were a maintenance hassle.
3619 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3620 All uses changed.
3621 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3622 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3623 (prepare_desired_row, line_draw_cost):
3624 Use int, not unsigned, where either works.
3625 (save_current_matrix, restore_current_matrix):
3626 Use ptrdiff_t, not size_t, where either works.
3627 (init_display): Check for overflow more accurately, and without
3628 relying on undefined behavior.
3629
a81d11a3
PE
3630 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3631 Remove, replacing with the new symbols in lisp.h. All uses changed.
3632 * fileio.c (make_temp_name):
3633 * filelock.c (lock_file_1, lock_file):
3634 * xdisp.c (message_dolog):
3635 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3636 Use pMd etc. instead.
3637 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3638 replacing the pWIDE etc. symbols removed from editfns.c.
3639
3300e6fd
PE
3640 * keyboard.h (num_input_events): Now uintmax_t.
3641 This is (very slightly) less likely to mess up due to wraparound.
3642 All uses changed.
3643
fd05c7e9
PE
3644 * buffer.c: Integer signedness fixes.
3645 (alloc_buffer_text, enlarge_buffer_text):
3646 Use ptrdiff_t rather than size_t when either will do, as we prefer
3647 signed integers.
3648
903fe15d
PE
3649 * alloc.c: Integer signedness and overflow fixes.
3650 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3651 (__malloc_size_t): Default to size_t, not to int.
3652 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3653 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3654 Prefer ptrdiff_t to size_t when either would do, as we prefer
3655 signed integers.
3656 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3657 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3658 Now const. Initialize with values that are in range even if char
3659 is signed.
3660 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3661 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3662 These functions do the right thing with sizes > 2**32.
3663 (check_depth): Now ptrdiff_t, not int.
3664 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3665 Adjust to new way of storing sizes. Check for size overflow bugs
3666 in rest of code.
3667 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3668 slightly wrong anyway, as it missed one instance of
3669 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3670 (refill_memory_reserve): Omit needless cast to size_t.
3671 (mark_object_loop_halt): Mark as externally visible.
3672
ac82cc6a
PE
3673 * xselect.c: Integer signedness and overflow fixes.
3674 (Fx_register_dnd_atom, x_handle_dnd_message):
3675 Use ptrdiff_t, not size_t, since we prefer signed.
3676 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3677 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3678 x_dnd_atoms_size and x_dnd_atoms_length.
3679
c2d1e36d
PE
3680 * doprnt.c: Prefer signed to unsigned when either works.
3681 * eval.c (verror):
3682 * doprnt.c (doprnt):
3683 * lisp.h (doprnt):
3684 * xdisp.c (vmessage):
3685 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3686 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3687 prefer signed arithmetic to avoid comparison confusion.
3688 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3689 but is a bit tricky.
3690
0e926e56
PE
3691 Assume freestanding C89 headers, string.h, stdlib.h.
3692 * data.c, doprnt.c, floatfns.c, print.c:
3693 Include float.h unconditionally.
3694 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3695 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3696 * regex.c: Likewise for stddef.h, string.h.
3697 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3698 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3699 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3700 (STDC_HEADERS): Remove obsolete defines.
3701 * sysdep.c: Include limits.h unconditionally.
3702
9cfdb3ec
PE
3703 Assume support for memcmp, memcpy, memmove, memset.
3704 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3705 * regex.c (memcmp, memcpy):
3706 Remove; we assume C89 now.
3707
3708 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3709 (__malloc_safe_bcopy): Remove; no longer needed.
3710
cf950e6b 3711 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3712 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3713 well either way, and we prefer signed to unsigned.
3714
dbf38e02
LMI
37152011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3716
3717 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3718 closes the connection while we're reading (bug#9182).
3719
d6f0886c 37202011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3721
d6f0886c
JD
3722 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3723 are specified (Bug#9168).
24e0f6b1 3724
2eb1f9e6
PE
37252011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3726
3727 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3728 Found by GCC static checking and --with-wide-int on a 32-bit host.
3729
22381272 37302011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3731
3732 * xdisp.c (compute_display_string_pos): Fix logic of caching
3733 previous display string position. Initialize cached_prev_pos to
3734 -1. Fixes slow-down at the beginning of a buffer.
3735
f25e39b4
EZ
37362011-07-24 Eli Zaretskii <eliz@gnu.org>
3737
3738 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3739 for attrs[LFACE_FONTSET_INDEX].
3740
04c4b52e
PE
37412011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3742
3743 * xml.c (parse_region): Remove unused local
3744 that was recently introduced.
3745
c1734fbd
EZ
37462011-07-23 Eli Zaretskii <eliz@gnu.org>
3747
be18c5a5
EZ
3748 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3749 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3750
c1734fbd
EZ
3751 * xdisp.c (move_it_in_display_line_to): Record the best matching
3752 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3753 exit if none of the characters scanned was an exact match.
3754 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3755 when exact match is impossible due to invisible text, and the
3756 lines are truncated.
3757
a258d627
JD
37582011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3759
3760 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3761 for OSX >= 10.7.
3762
b6d5a689
EZ
37632011-07-22 Eli Zaretskii <eliz@gnu.org>
3764
0f74f785
EZ
3765 Fix a significant slow-down of cursor motion with C-n, C-p,
3766 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3767 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3768 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3769 (next_element_from_buffer): Call compute_stop_pos_backwards to
3770 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3771 base_level_stop.
3772 (reseat): Don't look for prev_stop, as that could mean a very long
3773 run.
3774 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3775 <cached_disp_overlay_modiff>: Cache for last found display string
3776 position.
551918c1 3777 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3778 about the same buffer in the same area of character positions, and
3779 the buffer wasn't changed since the time the display string
3780 position was cached.
551918c1 3781
b2d0c91a
EZ
37822011-07-22 Eli Zaretskii <eliz@gnu.org>
3783
3784 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3785 is an integer, which is important for empty lines. (Bug#9149)
3786
043604ee
CY
37872011-07-22 Chong Yidong <cyd@stupidchicken.com>
3788
3789 * frame.c (Fmodify_frame_parameters): In tty case, update the
3790 default face if necessary (Bug#4238).
3791
da4adb04
CY
37922011-07-21 Chong Yidong <cyd@stupidchicken.com>
3793
3794 * editfns.c (Fstring_to_char): No need to explain what a character
3795 is in the docstring (Bug#6576).
3796
9abd0532
LMI
37972011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3798
3799 * xml.c (parse_region): Make sure we always return a tree.
3800
36881d16
HK
38012011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3802
3803 * xml.c (parse_region): If a document contains only comments,
3804 return that, too.
3805
1e98674d
LMI
38062011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3807
3808 * xml.c (make_dom): Return comments, too.
3809
590bd467
PE
38102011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3811
3812 Port to OpenBSD.
3813 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3814 and the surrounding thread.
3815 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3816 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3817 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3818 timer goes off.
3819 * s/openbsd.h (BROKEN_SIGIO): Define.
3820 * unexelf.c (unexec) [__OpenBSD__]:
3821 Don't update the .mdebug section of the Alpha COFF symbol table.
3822
f41628b2
LMI
38232011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3824
3825 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3826 (bug#8460).
3827
b59b67c5
PE
38282011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3829
15e3a074
PE
3830 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3831 This fixes some race conditions on the permissions of any newly
3832 created file.
3833
41bed37d
PE
3834 * alloc.c (valid_pointer_p): Use pipe, not open.
3835 This fixes some permissions issues when debugging.
3836
b59b67c5
PE
3837 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3838 If fchown fails to set both uid and gid, try to set just gid,
3839 as that is sometimes allowed. Adjust the file's mode to eliminate
3840 setuid or setgid bits that are inappropriate if fchown fails.
3841
925a6be7
SM
38422011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3843
3844 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3845 to compare Lisp_Objects.
3846 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3847 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3848 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3849
52968808
AS
38502011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3851
0a6a104b
AS
3852 * lread.c (read_integer): Unread even EOF character.
3853 (read1): Likewise. Properly record start position of symbol.
3854
52968808
AS
3855 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3856 symbol character follows.
3857
9e381cdd
PE
38582011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3859
3860 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3861 This works around a problem with the previous change to Fcopy_file.
3862 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3863 and without this change, GCC might complain about discarding
3864 fchown's return value.
3865
b5641435
JB
38662011-07-16 Juanma Barranquero <lekktu@gmail.com>
3867
3868 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3869
a8031457
PE
38702011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3871
3872 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3873
dd889327
LMI
38742011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3875
750c33f7
LMI
3876 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3877 it's used from the C level.
3878
dd889327
LMI
3879 * process.c: Use the same condition for POLL_FOR_INPUT in both
3880 keyboard.c and process.c (bug#1858).
3881
87e86684
LM
38822011-07-09 Lawrence Mitchell <wence@gmx.li>
3883
3884 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3885 (Fgnutls_boot): Use it.
3886
64348f40
AS
38872011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3888
3889 * doc.c (Fsubstitute_command_keys): Revert last change.
3890
1d698799
LMI
38912011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3892
f863868c
LMI
3893 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3894 quotes the next character, and doesn't affect other longer
3895 sequences (bug#8935).
3896
1d698799
LMI
3897 * lread.c (syms_of_lread): Clarify that is isn't only
3898 `eval-buffer' and `eval-defun' that's affected by
3899 `lexical-binding' (bug#8460).
3900
aa4b6df6
EZ
39012011-07-15 Eli Zaretskii <eliz@gnu.org>
3902
3903 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3904 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3905
5d856da6
PE
39062011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3907
ad6042bb
PE
3908 Fix minor problems found by static checking.
3909 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3910 (elsz): Now a signed constant, not a size_t var. We prefer signed
3911 types to unsigned, to avoid integer comparison confusion. Without
3912 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3913 "cannot optimize loop, the loop counter may overflow", a symptom
3914 of the confusion.
f00bbb22 3915 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3916 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3917
6468f31c
LMI
39182011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3919
49080b10
LMI
3920 * search.c (Fre_search_backward): Mention `case-fold-search' in
3921 all the re_search_* functions (bug#8138).
3922
6468f31c
LMI
3923 * keyboard.c (Fopen_dribble_file): Document when the file is
3924 closed (bug#8056).
3925
c965adc5
EZ
39262011-07-14 Eli Zaretskii <eliz@gnu.org>
3927
df9733bf
EZ
3928 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3929 bidi_cache_idx.
3930
0bb23927
EZ
3931 Support bidi reordering of display and overlay strings.
3932 * xdisp.c (compute_display_string_pos)
3933 (compute_display_string_end): Accept additional argument STRING.
3934 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3935 (reseat_to_string): Initialize bidi_it->string.s and
3936 bidi_it->string.schars.
3937 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3938 NULL (avoids a crash in bidi_paragraph_init).
3939 Initialize itb.string.lstring.
0bb23927
EZ
3940 (init_iterator): Call bidi_init_it only of a valid
3941 buffer position was specified. Initialize paragraph_embedding to
3942 L2R.
3943 (reseat_to_string): Initialize the bidi iterator.
3944 (display_string): If we need to ignore text properties of
3945 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3946 original value of -1 will not work with bidi.)
3947 (compute_display_string_pos): First arg is now struct
3948 `text_pos *'; all callers changed. Support display properties on
3949 Lisp strings.
3950 (compute_display_string_end): Support display properties on Lisp
3951 strings.
3952 (init_iterator, reseat_1, reseat_to_string): Initialize the
3953 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3954 when iterating on a string not from display properties).
640c8776
SM
3955 (compute_display_string_pos, compute_display_string_end):
3956 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3957 arrow keys.
3958 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3959 base_level_stop; instead, set base_level_stop to BEGV.
3960 Fixes crashes in vertical-motion.
0bb23927
EZ
3961 (next_element_from_buffer): Improve commentary for when
3962 the iterator is before prev_stop.
3963 (init_iterator): Initialize bidi_p from the default value of
3964 bidi-display-reordering, not from buffer-local value. Use the
3965 buffer-local value only if initializing for buffer iteration.
3966 (handle_invisible_prop): Support invisible properties on strings
3967 that are being bidi-reordered.
3968 (set_iterator_to_next): Support bidi reordering of C strings and
3969 Lisp strings.
3970 (next_element_from_string): Support bidi reordering of Lisp
3971 strings.
3972 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
3973 (display_string): Support display of R2L glyph rows.
3974 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
3975 (init_iterator): Don't initialize it->bidi_p for strings
3976 here.
3977 (reseat_to_string): Initialize it->bidi_p for strings here.
3978 (next_element_from_string, next_element_from_c_string)
3979 (next_element_from_buffer): Add xassert's for correspondence
3980 between IT's object being iterated and it->bidi_it.string
3981 structure.
3982 (face_before_or_after_it_pos): Support bidi iteration.
3983 (next_element_from_c_string): Handle the case of the first string
3984 character that is not the first one in the visual order.
3985 (get_visually_first_element): New function, refactored from common
3986 parts of next_element_from_buffer, next_element_from_string, and
3987 next_element_from_c_string.
3988 (tool_bar_lines_needed, redisplay_tool_bar)
3989 (display_menu_bar): Force left-to-right direction. Add a FIXME
3990 comment for making that be controlled by a user option.
3991 (push_it, pop_it): Save and restore the state of the
3992 bidi iterator. Save and restore the bidi_p flag.
3993 (pop_it): Iterate out of display property for string iteration as
3994 well.
3995 (iterate_out_of_display_property): Support iteration over strings.
3996 (handle_single_display_spec): Set up it->bidi_it for iteration
3997 over a display string, and call bidi_init_it.
3998 (handle_single_display_spec, next_overlay_string)
3999 (get_overlay_strings_1, push_display_prop): Set up the bidi
4000 iterator for displaying display or overlay strings.
4001 (forward_to_next_line_start): Don't use the shortcut if
4002 bidi-iterating.
4003 (back_to_previous_visible_line_start): If handle_display_prop
4004 pushed the iterator stack, restore the internal state of the bidi
4005 iterator by calling bidi_pop_it same number of times.
4006 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4007 and we are bidi-iterating, don't decrement the iterator position;
4008 instead, set the first_elt flag in the bidi iterator, to produce
4009 the same effect.
4010 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4011 (push_display_prop): xassert that we are iterating a buffer.
4012 (push_it, pop_it): Save and restore paragraph_embedding member.
4013 (handle_single_display_spec, next_overlay_string)
4014 (get_overlay_strings_1, reseat_1, reseat_to_string)
4015 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4016 correctly. Don't assume unibyte strings are not bidi-reordered.
4017 (compute_display_string_pos)
4018 (compute_display_string_end): Fix handling the case of C string.
4019 (push_it, pop_it): Save and restore from_disp_prop_p.
4020 (handle_single_display_spec, push_display_prop): Set the
4021 from_disp_prop_p flag.
4022 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4023 (pop_it): Call iterate_out_of_display_property only if we are
4024 popping after iteration over a string that came from a display
4025 property. Fix a typo in popping stretch info. Add an assertion
4026 for verifying that the iterator position is in sync with the bidi
4027 iterator.
4028 (handle_single_display_spec, get_overlay_strings_1)
4029 (push_display_prop): Fix initialization of paragraph direction for
4030 string when that of the parent object is not yet determined.
4031 (reseat_1): Call bidi_init_it to resync the bidi
4032 iterator with IT's position. (Bug#7616)
4033 (find_row_edges): If ROW->start.pos gives position
4034 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4035 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4036 Reset the from_disp_prop_p flag.
4037 (SAVE_IT, RESTORE_IT): New macros.
4038 (pos_visible_p, face_before_or_after_it_pos)
4039 (back_to_previous_visible_line_start)
4040 (move_it_in_display_line_to, move_it_in_display_line)
4041 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4042 (try_scrolling, redisplay_window, display_line): Use them when
4043 saving a temporary copy of the iterator and restoring it back.
4044 (back_to_previous_visible_line_start, reseat_1)
4045 (init_iterator): Empty the bidi cache "stack".
4046 (move_it_in_display_line_to): If iterator ended up at
4047 EOL, but we never saw any buffer positions smaller than
4048 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4049 motion in bidi-reordered lines.
4050 (move_it_in_display_line_to): Record prev_method and prev_pos
4051 immediately before the call to set_iterator_to_next. Fixes cursor
4052 motion in bidi-reordered lines with stretch glyphs and strings
4053 displayed in margins. (Bug#8133) (Bug#8867)
4054 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4055 TO_CHARPOS.
640c8776
SM
4056 (pos_visible_p): Support positions in bidi-reordered lines.
4057 Save and restore bidi cache.
0bb23927
EZ
4058
4059 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4060 (bidi_paragraph_info): Delete unused struct.
4061 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4062 (bidi_cache_start): New variable.
4063 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4064 to zero.
4065 (bidi_cache_fetch_state, bidi_cache_search)
4066 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4067 (bidi_cache_find, bidi_peek_at_next_level)
4068 (bidi_level_of_next_char, bidi_find_other_level_edge)
4069 (bidi_move_to_visually_next): Compare cache index with
4070 bidi_cache_start rather than with zero.
4071 (bidi_fetch_char): Accept new argument STRING; all callers
4072 changed. Support iteration over a string. Support strings with
4073 display properties. Support unibyte strings. Fix the type of
4074 `len' according to what STRING_CHAR_AND_LENGTH expects.
4075 (bidi_paragraph_init, bidi_resolve_explicit_1)
4076 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4077 (bidi_level_of_next_char, bidi_move_to_visually_next):
4078 Support iteration over a string.
0bb23927
EZ
4079 (bidi_set_sor_type, bidi_resolve_explicit_1)
4080 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4081 can now be zero (for strings); special values 0 and -1 were
4082 changed to -1 and -2, respectively.
4083 (bidi_char_at_pos): New function.
4084 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4085 Call it instead of FETCH_MULTIBYTE_CHAR.
4086 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4087 initialized to valid values.
4088 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4089 values.
4090 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4091 the test for valid cached positions. Fix the logic for looking up
4092 the sentinel state in the cache. GCPRO the Lisp string we are
4093 iterating.
4094 (bidi_push_it, bidi_pop_it): New functions.
4095 (bidi_initialize): Initialize the bidi cache start stack pointer.
4096 (bidi_cache_ensure_space): New function, refactored from part of
4097 bidi_cache_iterator_state. Don't assume the required size is just
4098 one BIDI_CACHE_CHUNK away.
4099 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4100 (bidi_count_bytes, bidi_char_at_pos): New functions.
4101 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4102 always valid if bidi_cache_idx is valid.
4103 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4104 is valid if it's going to be used.
4105 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4106 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4107 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4108 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4109 (bidi_find_other_level_edge, bidi_cache_start_stack):
4110 All variables related to cache indices are now EMACS_INT.
c965adc5 4111
0bb23927
EZ
4112 * dispextern.h (struct bidi_string_data): New structure.
4113 (struct bidi_it): New member `string'. Make flag members be 1-bit
4114 fields, and put them last in the struct.
640c8776
SM
4115 (compute_display_string_pos, compute_display_string_end):
4116 Update prototypes.
0bb23927
EZ
4117 (bidi_push_it, bidi_pop_it): Add prototypes.
4118 (struct iterator_stack_entry): New members bidi_p,
4119 paragraph_embedding, and from_disp_prop_p.
4120 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4121 (bidi_shelve_cache, bidi_unshelve_cache):
4122 Declare prototypes.
0bb23927
EZ
4123
4124 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4125 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4126 and vector-like objects.
4127
4128 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4129 cache around display iteration.
4130
4131 * window.c (Fwindow_end, window_scroll_pixel_based)
4132 (displayed_window_lines, Frecenter): Save and restore the bidi
4133 cache around display iteration.
4134
3bbd2265
LMI
41352011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4136
4137 * editfns.c (Fdelete_region): Clarify the use of the named
4138 parameters (bug#6788).
4139
adc47434
MR
41402011-07-14 Martin Rudalics <rudalics@gmx.at>
4141
4142 * indent.c (Fvertical_motion): Set and restore w->pointm when
4143 saving and restoring the window's buffer (Bug#9006).
4144
837c31f8
LMI
41452011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4146
4147 * editfns.c (Fstring_to_char): Clarify just what is returned
4148 (bug#6576). Text by Eli Zaretskii.
4149
ac389d0c
JB
41502011-07-13 Juanma Barranquero <lekktu@gmail.com>
4151
4152 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4153
0be0ce47
EZ
41542011-07-13 Eli Zaretskii <eliz@gnu.org>
4155
4156 * buffer.c (mmap_find): Fix a typo.
4157
cd18e7e3
JB
41582011-07-13 Johan Bockgård <bojohan@gnu.org>
4159
4160 Fix execution of x selection hooks.
4161 * xselect.c (Qx_lost_selection_functions)
4162 (Qx_sent_selection_functions): New vars.
4163 (syms_of_xselect): DEFSYM them.
4164 (x_handle_selection_request): Pass Qx_sent_selection_functions
4165 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4166 (x_handle_selection_clear,x_clear_frame_selections):
4167 Pass Qx_lost_selection_functions rather than
4168 Vx_lost_selection_functions to Frun_hook_with_args.
4169
47ea7f44
PE
41702011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4171
ac389d0c 4172 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4173 The old code sometimes used this field without initializing it.
4174
47ea7f44
PE
4175 * alloc.c (gc_sweep): Don't read past end of array.
4176 In theory, the old code could also have corrupted Emacs internals,
4177 though it'd be very unlikely.
4178
bc985c87
AS
41792011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4180
4181 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4182 argument. (Bug#4026)
bc985c87 4183
0cf34688
LMI
41842011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4185
b3dadd76
LMI
4186 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4187 key" (bug#4257).
4188
0cf34688
LMI
4189 * window.c (Fset_window_start): Doc fix (bug#4199).
4190 (Fset_window_hscroll): Ditto.
4191
270768cd
PE
41922011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4193
077e3dda 4194 Fix minor new problems caught by GCC 4.6.1.
270768cd 4195 * term.c (init_tty): Remove unused local.
490011a6 4196 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4197 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4198 not used otherwise.
270768cd 4199
b1f58454
CY
42002011-07-12 Chong Yidong <cyd@stupidchicken.com>
4201
4202 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4203
22b9578d
LMI
42042011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4205
6e70ab07
LMI
4206 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4207 are the mini-buffer and the echo area (bug#3320).
4208
22b9578d
LMI
4209 * term.c (init_tty): Remove support for supdup, c10 and perq
4210 terminals, which are no longer supported (bug#1482).
4211
8974cc9f
JB
42122011-07-10 Johan Bockgård <bojohan@gnu.org>
4213
4214 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4215
a560d974
JD
42162011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4217
4218 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4219 for non-popups (Bug#3642).
4220
1dae0f0a
AS
42212011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4222
268c2c36 4223 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4224 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4225 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4226 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4227 * data.c (fmod): Likewise.
4228 * dispnew.c (swap_glyphs_in_rows): Likewise.
4229 * emacs.c (memory_warning_signal): Likewise.
4230 * floatfns.c (float_error): Likewise.
4231 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4232 (otf_open, font_otf_capability, generate_otf_features)
4233 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4234 Likewise.
4235 * image.c (pbm_read_file): Likewise.
4236 * indent.c (string_display_width): Likewise.
4237 * intervals.c (check_for_interval, search_for_interval)
4238 (inc_interval_count, count_intervals, root_interval)
4239 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4240 * lread.c (defalias): Likewise.
268c2c36 4241 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4242 * regex.c (set_image_of_range_1, set_image_of_range)
4243 (regex_grow_registers): Likewise.
4244 * sysdep.c (strerror): Likewise.
4245 * termcap.c (valid_filename_p, tprint, main): Likewise.
4246 * tparam.c (main): Likewise.
4247 * unexhp9k800.c (run_time_remap, save_data_space)
4248 (update_file_ptrs, read_header, write_header, calculate_checksum)
4249 (copy_file, copy_rest, display_header): Likewise.
4250 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4251 Likewise.
4252 * xdisp.c (check_it): Likewise.
4253 * xfaces.c (register_color, unregister_color, unregister_colors):
4254 Likewise.
4255 * xfns.c (print_fontset_result): Likewise.
4256 * xrdb.c (member, fatal, main): Likewise.
4257
99033785
PE
42582011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4259
4260 Fix minor problems found by static checking (Bug#9031).
4261 * chartab.c (char_table_set_range, map_sub_char_table):
4262 Remove unused locals.
4263 (uniprop_table): Now static.
4264 * composite.c (_work_char): Remove unused static var.
4265
9cb2ac56
JB
42662011-07-09 Juanma Barranquero <lekktu@gmail.com>
4267
4268 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4269
f25661f0
JD
42702011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4271
4272 * gtkutil.c (qttip_cb): Remove code without function.
4273
8278c4fe
EZ
42742011-07-09 Eli Zaretskii <eliz@gnu.org>
4275
4276 * w32.c (pthread_sigmask): New stub.
4277
1692ae2d 42782011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4279
8a6ebd58 4280 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4281 sigprocmask is portable only for single-threaded applications, and
4282 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4283 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4284 (LIBES): Use it.
4285 * callproc.c (Fcall_process):
4286 * process.c (create_process):
4287 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4288 Use pthread_sigmask, not sigprocmask.
123403e4 4289
1b854618
JD
42902011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4291
4292 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4293 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4294 wrong (Bug#8591).
4295
3fe4b549
JD
42962011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4297
0ce7e563
JD
4298 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4299 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4300 (xg_hide_tooltip): Fix comment.
4301
3fe4b549
JD
4302 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4303 in registerServicesMenuSendTypes.
4304 (validRequestorForSendType): Don't check ns_return_types.
4305
4306 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4307 ns_return_type.
4308
5df75e47
JR
43092011-07-08 Jason Rumney <jasonr@gnu.org>
4310
22610910
JR
4311 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4312 SH_SHOW for hidden windows (Bug#5482).
4313
5df75e47
JR
4314 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4315 frame struct members of non-existent frames (Bug#6284).
4316
699c10bd
JD
43172011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4318
4393663b
JD
4319 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4320 variable firstTime not needed on OSX >= 10.6.
4321 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4322 >= 10.5. Use setKnobProportion, setDoubleValue.
4323
4324 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4325 (MAC_OS_X_VERSION_10_5): Define if not defined.
4326 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4327 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4328 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4329
4330 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4331 cString and lossyCString on OSX >= 10.4
4332
58179cce 4333 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4334 sizeToFit on OSX >= 10.2.
4335
4336 * nsimage.m (allocInitFromFile): Don't use deprecated method
4337 bestRepresentationForDevice on OSX >= 10.6.
4338
4339 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4340 to avoid warning.
4341
4342 * emacs.c: Declare unexec_init_emacs_zone.
4343
a63e0781
JD
4344 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4345
699c10bd
JD
4346 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4347
4348 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4349 on svcsMenu (Bug#8842).
4350
4351 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4352 ns_return_types.
4353 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4354
4355 * nsterm.m (QUTF8_STRING): Declare.
4356 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4357 (validRequestorForSendType): Return type is (id).
4358 Change indexOfObjectIdenticalTo to indexOfObject.
4359 Check if we have local selection before returning self (Bug#8842).
4360 (writeSelectionToPasteboard): Put local selection into paste board
4361 if we have a local selection (Bug#8842).
4362 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4363
4364 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4365 (ns_get_local_selection): Declare.
4366
54e10184
LMI
43672011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4368
9888ff71
LMI
4369 * keymap.c (describe_map_tree): Don't insert a double newline at
4370 the end of the buffer (bug#1169) and return whether we inserted
4371 something.
4372
54e10184
LMI
4373 * callint.c (Fcall_interactively): Change "reading args" to
4374 "providing args" to try to clarify what it does (bug#1010).
4375
15fa4783
KH
43762011-07-07 Kenichi Handa <handa@m17n.org>
4377
4378 * composite.c (composition_compute_stop_pos): Ignore a static
4379 composition starting before CHARPOS (Bug#8915).
4380
4381 * xdisp.c (handle_composition_prop): Likewise.
4382
a8815b00
EZ
43832011-07-07 Eli Zaretskii <eliz@gnu.org>
4384
4385 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4386 (Bug#9015)
4387
ef7b981d 43882011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4389
4390 * character.h (unicode_category_t): New enum type.
4391
4392 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4393 (Qchar_code_property_table): New variable.
4394 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4395 (UNIPROP_COMPRESSED_FORM_P): New macros.
4396 (char_table_ascii): Uncompress the compressed values.
4397 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4398 Uncompress the compressed values.
ac389d0c 4399 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4400 (char_table_ref_and_range): Uncompress the compressed values.
4401 (sub_char_table_set): New arg is_uniprop. Callers changed.
4402 Uncompress the compressed values.
4403 (sub_char_table_set_range): Args changed. Callers changed.
4404 (char_table_set_range): Adjuted for the above change.
4405 (map_sub_char_table): Delete args default_val and parent. Add arg
4406 top. Give decoded values to a Lisp function.
640c8776 4407 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4408 values to a Lisp function. Gcpro more variables.
4409 (uniprop_table_uncompress)
4410 (uniprop_decode_value_run_length): New functions.
4411 (uniprop_decoder, uniprop_decoder_count): New variables.
4412 (uniprop_get_decoder, uniprop_encode_value_character)
4413 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4414 New functions.
4415 (uniprop_encoder, uniprop_encoder_count): New variables.
4416 (uniprop_get_encoder, uniprop_table)
4417 (Funicode_property_table_internal, Fget_unicode_property_internal)
4418 (Fput_unicode_property_internal): New functions.
4419 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4420 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4421 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4422 char-code-property-alist.
4423
640c8776 4424 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4425 Vunicode_category_table.
4426
640c8776 4427 * font.c (font_range): Adjust for the change of
c805dec0
KH
4428 Vunicode_category_table.
4429
76b397fb
DN
44302011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4431
4432 * m/iris4d.h: Remove file, move contents ...
4433 * s/irix6-5.h: ... here.
4434
22b4128e
PE
44352011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4436
4437 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4438 * alloc.c (mark_buffer):
4439 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4440 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4441 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4442 This isn't true in general, and it's particularly not true
4443 if Emacs is configured with --with-wide-int.
4444 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4445 New macros, used in the buffer.c change.
4446
869795d6
JD
44472011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4448
4449 * xsettings.c: Use both GConf and GSettings if both are available.
4450 (store_config_changed_event): Add comment.
4451 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4452 (store_tool_bar_style_changed): New functions.
5e617bc2 4453 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4454 (struct xsettings): Move font inside HAVE_XFT.
4455 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4456 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4457 Move inside HAVE_XFT.
640c8776 4458 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4459 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4460 also.
4461 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4462 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4463 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4464 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4465 (parse_settings): Move check for font inside HAVE_XFT.
4466 (read_settings, apply_xft_settings): Add comment.
4467 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4468 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4469 call store_font_name_changed.
4470 (xft_settings_event): Add comment.
4471 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4472 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4473 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4474 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4475 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4476 (xsettings_get_system_font, xsettings_get_system_normal_font):
4477 Add comment.
869795d6 4478
d8ed26bd
PE
44792011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4480
4481 Random fixes. E.g., (random) never returned negative values.
4482 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4483 subseconds part to the entropy, as that's a bit more random.
4484 Prefer signed to unsigned, since the signedness doesn't matter and
4485 in general we prefer signed. When given a limit, use a
4486 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4487 latter isn't right if USE_2_TAGS_FOR_INTS.
4488 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4489 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4490
cabf1cac
SM
44912011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4492
4493 * textprop.c (text_property_stickiness):
4494 Obey Vtext_property_default_nonsticky.
4495 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4496 * w32fns.c (syms_of_w32fns):
4497 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4498
6e9b2be9
PE
44992011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4500
4501 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4502 This is more efficient than Ffile_directory_p and avoids a minor race.
4503
90186c68
LMI
45042011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4505
7c301272
LMI
4506 * buffer.c (Foverlay_put): Say what the return value is
4507 (bug#7835).
4508
c4f2d8d4
LMI
4509 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4510 is a directory before asking whether to use the file name
4511 (bug#7564).
ad637907
LMI
4512 (barf_or_query_if_file_exists): Make the "File is a directory"
4513 error be more correct.
c4f2d8d4 4514
90186c68
LMI
4515 * fns.c (Frequire): Remove the mention of the .gz files, since
4516 that's installation-specific, but keep the mention of
4517 `get-load-suffixes'.
4518
da64016e
PE
45192011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4520
4521 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4522 Report string overflow if the output is too long.
4523
7d47b580
JB
45242011-07-04 Juanma Barranquero <lekktu@gmail.com>
4525
a555cb87
JB
4526 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4527 (syms_of_gnutls): Remove duplicate DEFSYM for
4528 Qgnutls_bootprop_verify_hostname_error, an error for
4529 Qgnutls_bootprop_verify_error (which is no longer used).
4530
7d47b580
JB
4531 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4532 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4533 Also (re)move comments that are misplaced or no longer relevant.
4534
1e49bfab
LMI
45352011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4536
4537 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4538
1485f4c0
CY
45392011-07-03 Chong Yidong <cyd@stupidchicken.com>
4540
4541 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4542 and background color parameters if they have been changed.
4543
a9ab721e
LMI
45442011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4545
4546 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4547
cf7cff57
PE
45482011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4549
2e13213d
PE
4550 * xsettings.c (SYSTEM_FONT): Define only when used.
4551 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4552
cf7cff57
PE
4553 * keymap.c (access_keymap_1): Now static.
4554
7a8e04f7
CY
45552011-07-02 Chong Yidong <cyd@stupidchicken.com>
4556
4557 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4558 leave any prefix arg for the up event (Bug#1586).
4559
61352f62
LMI
45602011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4561
69bb1ef7
LMI
4562 * lread.c (syms_of_lread): Mention single symbols defined by
4563 `defvar' or `defconst' (bug#7154).
4564
61352f62 4565 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4566 (Frequire): Mention get-load-suffixes.
61352f62 4567
28545e04
MR
45682011-07-02 Martin Rudalics <rudalics@gmx.at>
4569
4570 * window.h (window): Remove clone_number slot.
4571 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4572 Remove.
4573 (make_parent_window, make_window, saved_window)
4574 (Fset_window_configuration, save_window_save): Don't deal with
4575 clone numbers.
4576 * buffer.c (Qclone_number): Remove declaration.
4577 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4578
3349e122
SM
45792011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4580
4581 Add multiple inheritance to keymaps.
4582 * keymap.c (Fmake_composed_keymap): New function.
4583 (Fset_keymap_parent): Simplify.
4584 (fix_submap_inheritance): Remove.
4585 (access_keymap_1): New function extracted from access_keymap to handle
4586 embedded parents and handle lists of maps.
4587 (access_keymap): Use it.
4588 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4589 (Fcopy_keymap): Handle embedded parents.
4590 (Fcommand_remapping, define_as_prefix): Simplify.
4591 (Fkey_binding): Simplify.
4592 (syms_of_keymap): Move minibuffer-local-completion-map,
4593 minibuffer-local-filename-completion-map,
4594 minibuffer-local-must-match-map, and
4595 minibuffer-local-filename-must-match-map to Elisp.
4596 (syms_of_keymap): Defsubr make-composed-keymap.
4597 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4598 (parse_menu_item): Trivial simplification.
4599
3279eb87
GM
46002011-07-01 Glenn Morris <rgm@gnu.org>
4601
4602 * Makefile.in (SETTINGS_LIBS): Fix typo.
4603
4550efdf
KI
46042011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4605
4606 * coding.c (Fencode_coding_string): Record the last coding system
4607 used, as the function doc string says (bug#8738).
4608
0949d2b6
JD
46092011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4610
4611 * xsettings.c (store_monospaced_changed): Take new font as arg and
4612 check for change against current_mono_font.
4613 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4614 (emacs_settings_constructor, emacs_settings_get_property)
4615 (emacs_settings_set_property, emacs_settings_class_init)
4616 (emacs_settings_init, gsettings_obj): Remove.
4617 (something_changedCB): New function for HAVE_GSETTINGS.
4618 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4619 with value as argument.
4620 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4621 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4622 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4623 "changed".
4624
4625 * xgselect.c: Add defined (HAVE_GSETTINGS).
4626 (xgselect_initialize): Ditto.
4627
4628 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4629 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4630 xg_select.
4631
bbc6b304
PE
46322011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4633
4634 * eval.c (struct backtrace): Simplify and port the data structure.
4635 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4636 signed bit field, as this assumption is not portable and it makes
4637 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4638 "char debug_on_exit : 1" as this is not portable either; instead,
4639 use the portable "unsigned int debug_on_exit : 1". Remove unused
4640 member evalargs. Remove obsolete comments about cc bombing out.
4641
9851bfc5
JD
46422011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4643
51bb811f 4644 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4645 Let HAVE_GSETTINGS override HAVE_GCONF.
4646 (store_monospaced_changed): New function.
4647 (EMACS_SETTINGS): A new type derived from GObject to handle
4648 GSettings notifications.
4649 (emacs_settings_constructor, emacs_settings_get_property)
4650 (emacs_settings_set_property, emacs_settings_class_init):
4651 New functions.
4652 (gsettings_client, gsettings_obj): New variables.
4653 (GSETTINGS_SCHEMA): New define.
4654 (something_changedCB): Call store_monospaced_changed.
4655 (init_gsettings): New function.
4656 (xsettings_initialize): Call init_gsettings.
4657 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4658 to NULL.
4659
640c8776 4660 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4661 GCONF_CFLAGS/LIBS.
4662
5386012d
MR
46632011-06-29 Martin Rudalics <rudalics@gmx.at>
4664
4665 * window.c (resize_root_window, grow_mini_window)
4666 (shrink_mini_window): Rename Qresize_root_window to
4667 Qwindow_resize_root_window and Qresize_root_window_vertically to
4668 Qwindow_resize_root_window_vertically.
4669
f13e0b08
PE
46702011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4671
4672 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4673
94515237
JB
46742011-06-27 Juanma Barranquero <lekktu@gmail.com>
4675
4676 * makefile.w32-in: Redesign dependencies so they reflect more
4677 clearly which files are directly included by each source file,
4678 and not through other includes.
4679
e43b6e43
MR
46802011-06-27 Martin Rudalics <rudalics@gmx.at>
4681
4682 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4683 (sort_overlays, overlay_strings): When an overlay's clone number
4684 matches the window's clone number process the overlay even if
4685 the overlay's window property doesn't match the current window.
4686
d68443dc
MR
4687 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4688 (Fwindow_hchild): Rename to Fwindow_left_child.
4689 (Fwindow_next): Rename to Fwindow_next_sibling.
4690 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4691 (resize_window_check): Rename to window_resize_check.
4692 (resize_window_apply): Rename to window_resize_apply.
4693 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4694 (Fdelete_other_windows_internal, resize_frame_windows)
4695 (Fsplit_window_internal, Fdelete_window_internal)
4696 (grow_mini_window, shrink_mini_window)
4697 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4698
c7e73be5
JD
46992011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4700
4701 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4702 (emacs_fixed_set_min_size): Remove.
4703 (emacs_fixed_new): Take frame as argument.
4704
4705 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4706 (_EmacsFixedPrivate): Remove minwidth/height.
4707 Add struct frame *f.
4708 (emacs_fixed_init): Initialize priv->f.
4709 (get_parent_class, emacs_fixed_set_min_size): Remove.
4710 (emacs_fixed_new): Set priv->f to argument.
4711 (emacs_fixed_get_preferred_width)
4712 (emacs_fixed_get_preferred_height): Use min_width/height from
4713 frames size_hint to set minimum and natural (Bug#8919).
4714 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4715 and use min_width/height from frames size_hint to set
4716 min_width/height (Bug#8919).
4717
4718 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4719 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4720 Fix indentation.
c7e73be5 4721
cf99dcf8
EZ
47222011-06-26 Eli Zaretskii <eliz@gnu.org>
4723
4724 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4725 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4726 called at ZV.
4727
029529ac
CY
47282011-06-26 Chong Yidong <cyd@stupidchicken.com>
4729
4730 * process.c (wait_reading_process_output): Bypass select if
4731 waiting for a cell while ignoring keyboard input, and input is
4732 pending. Suggested by Jan Djärv (Bug#8869).
4733
7a7ef429
PE
47342011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4735
4736 Use gnulib's dup2 module instead of rolling our own.
4737 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4738
11fdef7d 47392011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4740
4741 * dispnew.c (scrolling_window): Before scrolling, turn off a
4742 mouse-highlight in the window being scrolled.
4743
cd3520a4
JB
47442011-06-24 Juanma Barranquero <lekktu@gmail.com>
4745
4746 Move DEFSYM to lisp.h and use everywhere.
4747
4748 * character.h (DEFSYM): Move declaration...
4749 * lisp.h (DEFSYM): ...here.
4750
4751 * gnutls.c:
4752 * minibuf.c:
4753 * w32menu.c:
4754 * w32proc.c:
4755 * w32select.c: Don't include character.h.
4756
4757 * alloc.c (syms_of_alloc):
4758 * buffer.c (syms_of_buffer):
4759 * bytecode.c (syms_of_bytecode):
4760 * callint.c (syms_of_callint):
4761 * casefiddle.c (syms_of_casefiddle):
4762 * casetab.c (init_casetab_once):
4763 * category.c (init_category_once, syms_of_category):
4764 * ccl.c (syms_of_ccl):
4765 * cmds.c (syms_of_cmds):
4766 * composite.c (syms_of_composite):
4767 * dbusbind.c (syms_of_dbusbind):
4768 * dired.c (syms_of_dired):
4769 * dispnew.c (syms_of_display):
4770 * doc.c (syms_of_doc):
4771 * editfns.c (syms_of_editfns):
4772 * emacs.c (syms_of_emacs):
4773 * eval.c (syms_of_eval):
4774 * fileio.c (syms_of_fileio):
4775 * fns.c (syms_of_fns):
4776 * frame.c (syms_of_frame):
4777 * fringe.c (syms_of_fringe):
4778 * insdel.c (syms_of_insdel):
4779 * keymap.c (syms_of_keymap):
4780 * lread.c (init_obarray, syms_of_lread):
4781 * macros.c (syms_of_macros):
4782 * msdos.c (syms_of_msdos):
4783 * print.c (syms_of_print):
4784 * process.c (syms_of_process):
4785 * search.c (syms_of_search):
4786 * sound.c (syms_of_sound):
4787 * syntax.c (init_syntax_once, syms_of_syntax):
4788 * terminal.c (syms_of_terminal):
4789 * textprop.c (syms_of_textprop):
4790 * undo.c (syms_of_undo):
4791 * w32.c (globals_of_w32):
4792 * window.c (syms_of_window):
4793 * xdisp.c (syms_of_xdisp):
4794 * xfaces.c (syms_of_xfaces):
4795 * xfns.c (syms_of_xfns):
4796 * xmenu.c (syms_of_xmenu):
4797 * xsettings.c (syms_of_xsettings):
4798 * xterm.c (syms_of_xterm): Use DEFSYM.
4799
4228cf16
TZ
48002011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4801
cd3520a4 4802 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4803
7fcccf1e
PE
48042011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4805
7efb4e0e
PE
4806 Integer and buffer overflow fixes (Bug#8873).
4807
ff5844ad
PE
4808 * print.c (printchar, strout): Check for string overflow.
4809 (PRINTPREPARE, printchar, strout):
4810 Don't set size unless allocation succeeds.
4811
90532f02
PE
4812 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4813 for sizes. Check for string overflow more accurately.
4814 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4815
6d84508d
PE
4816 * macros.c: Integer and buffer overflow fixes.
4817 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4818 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4819 Use ptrdiff_t, not int, for sizes.
4820 Don't increment bufsize until after realloc succeeds.
4821 Check for size-calculation overflow.
4822 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4823
437b2cb4
PE
4824 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4825
8b9ac8b4
PE
4826 * lread.c: Integer overflow fixes.
4827 (read_integer): Radix is now EMACS_INT, not int,
4828 to improve quality of diagnostics for out-of-range radices.
4829 Calculate buffer size correctly for out-of-range radices.
4830 (read1): Check for integer overflow in radices, and in
4831 read-circle numbers.
82cb60d3
PE
4832 (read_escape): Avoid int overflow.
4833 (Fload, openp, read_buffer_size, read1)
4834 (substitute_object_recurse, read_vector, read_list, map_obarray):
4835 Use ptrdiff_t, not int, for sizes.
4836 (read1): Use EMACS_INT, not int, for sizes.
20270765 4837 Check for size overflow.
8b9ac8b4 4838
7fcccf1e
PE
4839 * image.c (cache_image): Check for size arithmetic overflow.
4840
bfbbd7e7
PE
4841 * lread.c: Integer overflow issues.
4842 (saved_doc_string_size, saved_doc_string_length)
4843 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4844 Now ptrdiff_t, not int.
4845 (read1): Don't assume doc string length fits in int. Check for
4846 out-of-range doc string lengths.
4847 (read_list): Don't assume file position fits in int.
39019e54 4848 (read_escape): Check for hex character overflow.
bfbbd7e7 4849
4e323265
LL
48502011-06-22 Leo Liu <sdl.web@gmail.com>
4851
4852 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4853 Move to minibuffer.el.
4854
85fece3e
PE
48552011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4856
20b84ce9 4857 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4858 The following patches are for when GLYPH_DEBUG && !XASSERT.
4859 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4860 * dispnew.c (flush_stdout):
4861 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4862 Mark as externally visible.
4863 * dispnew.c (check_window_matrix_pointers): Now static.
4864 * dispnew.c (window_to_frame_vpos):
4865 * xfns.c (unwind_create_frame):
4866 * xterm.c (x_check_font): Remove unused local.
4867 * scroll.c (CHECK_BOUNDS):
4868 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4869 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4870 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4871 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4872 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4873 Now static.
4874 (debug_method_add): Use va_list and vsprintf rather than relying
4875 on undefined behavior with wrong number of arguments.
4876 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4877 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4878 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4879 since we're not interested in debugging glyphs with old libraries.
4880 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4881 GCC 4.6.0's static checking.
4882
0766b489
PE
48832011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4884
31fd4b32
PE
4885 Integer overflow and signedness fixes (Bug#8873).
4886 A few related buffer overrun fixes, too.
4887
b79e8648
PE
4888 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4889
0766b489
PE
4890 * dispextern.h (struct face.stipple):
4891 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4892 (x_bitmap_mask, x_allocate_bitmap_record)
4893 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4894 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4895 (x_create_bitmap_from_xpm_data):
4896 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4897 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4898 (.bitmaps_last):
4899 * xfaces.c (load_pixmap):
4900 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4901 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4902 (.bitmaps_last, struct x_output.icon_bitmap):
4903 Use ptrdiff_t, not int, for bitmap indexes.
4904 (x_allocate_bitmap_record): Check for size overflow.
4905 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4906
b081724f
PE
4907 Use ptrdiff_t, not int, for overlay counts.
4908 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4909 * editfns.c (overlays_around, get_pos_property):
4910 * textprop.c (get_char_property_and_overlay):
4911 * xdisp.c (next_overlay_change, note_mouse_highlight):
4912 * xfaces.c (face_at_buffer_position):
21514da7
PE
4913 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4914 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4915 (Fnext_overlay_change, Fprevious_overlay_change)
4916 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4917 Use ptrdiff_t, not int, for sizes.
21514da7 4918 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4919
3de73e5e
PE
4920 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4921
2606c57b
PE
4922 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4923 (x_session_initialize): Do not assume string length fits in int.
4924
aaafe47a
PE
4925 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4926 This is unlikely, but can occur if DPI is outlandish.
4927
2674ddc8 4928 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4929 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4930
28154962
PE
4931 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4932 * xrdb.c (magic_file_p, search_magic_path):
4933 Omit last arg SUFFIX; it was always 0. All callers changed.
4934 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4935
7de51af5
PE
4936 * xfont.c (xfont_match): Avoid need for strlen.
4937
25ed6cc3
PE
4938 * xfns.c: Don't assume strlen fits in int.
4939 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4940
4eab31dd
PE
4941 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4942 not unsigned long, as we prefer signed integers. All callers changed.
4943 Detect integer overflow in repeat count.
4944 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4945 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4946
171e2a58
PE
4947 * termcap.c: Don't assume sizes fit in int and never overflow.
4948 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4949 (gobble_line): Check for size-calculation overflow.
4950
ad39faca 4951 * minibuf.c (Fread_buffer):
6e5bb2dc 4952 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4953 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4954 Don't assume string length fits in int.
4955
52c61c22 4956 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4957 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4958
b5b8c9e5
PE
4959 * font.c: Don't assume string length fits in int.
4960 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4961 Use ptrdiff_t, not int.
ccd6111c
PE
4962 (font_intern_prop): Don't assume string length fits in int.
4963 Don't assume integer property fits in fixnum.
4964 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4965
882f0d81 4966 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4967 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
4968 Reformulate so as not to need the command string.
4969 Invoke gzip -cd rather than gunzip, as it's more portable.
4970 (lock_info_type, lock_file_1, lock_file):
4971 Don't assume pid_t and time_t fit in unsigned long.
4972 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
4973 (current_lock_owner): Prefer signed type for sizes.
4974 Use memcpy, not strncpy, where memcpy is what is really wanted.
4975 Don't assume (via atoi) that time_t and pid_t fit in int.
4976 Check for time_t and/or pid_t out of range, e.g., via a network share.
4977 Don't alloca where an auto var works fine.
4978
93f4cf88
PE
4979 * fileio.c: Fix some integer overflow issues.
4980 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
4981 Don't assume string length fits in int.
4982 (directory_file_name): Don't assume string length fits in long.
4983 (make_temp_name): Don't assume pid fits in int, or that its print
4984 length is less than 20.
4985
f3e92b69
PE
4986 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
4987
1bfdaf10
PE
4988 * coding.c (make_subsidiaries): Don't assume string length fits in int.
4989
35016e9a
PE
4990 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
4991
3d1e65a1
PE
4992 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
4993 We prefer signed integers, even for size calculations.
4994
0b963a93
PE
4995 * emacs.c: Don't assume string length fits in 'int'.
4996 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
4997 (main): Don't invoke strlen when not needed.
4998
573f4b54
PE
4999 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5000 (XD_DEBUG_MESSAGE): Don't waste a byte.
5001
989f33ba
PE
5002 * callproc.c (getenv_internal_1, getenv_internal)
5003 (Fgetenv_internal):
965d34eb
PE
5004 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5005
e4d29b33
PE
5006 * lread.c (invalid_syntax): Omit length argument.
5007 All uses changed. This doesn't fix a bug, but it simplifies the
5008 code away from its former Hollerith-constant appearance, and it's
5009 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5010 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5011
eb49b136
PE
5012 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5013 This didn't break anything, but it didn't help either.
5014 It's confusing to put a bogus integer in a place where the actual
5015 value does not matter.
9f62aeb1 5016 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5017 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5018
15375a22
PE
5019 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5020 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5021 implementation.
b61cc01c
PE
5022 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5023 We prefer signed types, and the value cannot exceed the EMACS_INT
5024 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5025 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5026 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5027 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5028
53b2623d
PE
5029 * indent.c (sane_tab_width): New function.
5030 (current_column, scan_for_column, Findent_to, position_indentation)
5031 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5032 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5033
51cab52b 5034 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5035
f2ed8a70
PE
5036 * lisp.h (lint_assume): New macro.
5037 * composite.c (composition_gstring_put_cache):
5038 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5039
abe80cc6
PE
5040 * editfns.c, insdel.c:
5041 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5042
b02c740e
PE
5043 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5044
ebc96716
PE
5045 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5046
b4e50fa0 5047 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5048 Use much-faster test for byte-length change.
311d5d7c 5049 Don't assume string byte-length fits in 'int'.
a4cf38e4 5050 Check that character arg fits in 'int'.
85461888 5051 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5052
c0c1ee9f
PE
5053 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5054
a498d7f4
PE
5055 * fns.c (concat): Catch string overflow earlier.
5056 Do not rely on integer wraparound.
5057
51cab52b
PE
5058 * dispextern.h (struct it.overlay_strings_charpos)
5059 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5060 * xdisp.c (forward_to_next_line_start)
5061 (back_to_previous_visible_line_start)
5062 (reseat_at_next_visible_line_start, next_element_from_buffer):
5063 Don't arbitrarily truncate the value of 'selective' to int.
5064
76031fad
PE
5065 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5066
5eb55db9
PE
5067 * composite.c: Don't truncate sizes to 'int'.
5068 (composition_gstring_p, composition_reseat_it)
5069 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5070 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5071 not EMACS_UINT, for indexes.
5eb55db9 5072
0703a717
PE
5073 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5074
d6202519
PE
5075 * buffer.c: Include <verify.h>.
5076 (struct sortvec.priority, struct sortstr.priority):
8961a454 5077 Now EMACS_INT, not int.
c20998a7 5078 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5079 (struct sortstr.size, record_overlay_string)
5080 (struct sortstrlist.size, struct sortlist.used):
5081 Don't truncate size to int.
5082 (record_overlay_string): Check for size-calculation overflow.
d6202519 5083 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5084
d5a19415
JM
50852011-06-22 Jim Meyering <meyering@redhat.com>
5086
029529ac 5087 Don't leak an XBM-image-sized buffer
d5a19415
JM
5088 * image.c (xbm_load): Free the image buffer after using it.
5089
a9041e6c
PE
50902011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5091
5092 Port to Sun C.
5093 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5094 that Sun C diagnosed.
5095 * fns.c (secure_hash): Fix pointer signedness issue.
5096 * intervals.c (static_offset_intervals): New function.
5097 (offset_intervals): Use it.
5098
7f3f739f
LL
50992011-06-21 Leo Liu <sdl.web@gmail.com>
5100
5101 * deps.mk (fns.o):
5102 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5103 sha512.h.
5104
5105 * fns.c (secure_hash): Rename from crypto_hash_function and change
5106 the first arg to accept symbols.
5b66d427 5107 (Fsecure_hash): New primitive.
7f3f739f
LL
5108 (syms_of_fns): New symbols.
5109
76147d94
DD
51102011-06-20 Deniz Dogan <deniz@dogan.se>
5111
5112 * process.c (Fset_process_buffer): Clarify return value in
5113 docstring.
5114
7d7d0045
CY
51152011-06-18 Chong Yidong <cyd@stupidchicken.com>
5116
5117 * dispnew.c (add_window_display_history): Use BVAR.
5118
5119 * xdisp.c (debug_method_add): Use BVAR.
5120 (check_window_end, dump_glyph_matrix, dump_glyph)
5121 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5122
5123 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5124 Likewise.
5125
5126 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5127 check till after the cache is created in init_frame_faces.
5128
ff2bc410
SM
51292011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5130
5131 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5132
28177add
PE
51332011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5134
dd3482fe
PE
5135 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5136 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5137 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5138
393d71f3 5139 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5140 * fileio.c (Finsert_file_contents):
5141 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5142 Remove the old (too-loose) buffer overflow checks.
5143 They weren't needed, since make_gap checks for buffer overflow.
5144 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5145 The old code merely checked for Emacs fixnum overflow, and relied
5146 on undefined (wraparound) behavior. The new code avoids undefined
5147 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5148
2e6813b0 5149 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5150 Tune. Don't use wider integers than needed. Don't use alloca.
5151 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5152
599a9e4f
PE
5153 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5154
99561444
PE
5155 * insdel.c, lisp.h (buffer_overflow): New function.
5156 (insert_from_buffer_1, replace_range, replace_range_2):
5157 * insdel.c (make_gap_larger):
5158 * editfns.c (Finsert_char):
5159 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5160
28177add
PE
5161 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5162
e69dafad
PE
51632011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5164
4baa020d 5165 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5166
b1c46f02
PE
5167 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5168 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5169
e69dafad
PE
5170 * fileio.c: Don't assume EMACS_INT fits in off_t.
5171 (emacs_lseek): New static function.
5172 (Finsert_file_contents, Fwrite_region): Use it.
5173 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5174
566684ea
PE
5175 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5176
e6966cd6
PE
5177 * fns.c: Don't overflow int when computing a list length.
5178 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5179 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5180 truncation on 64-bit hosts. Check for QUIT every
5181 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5182 faster and is responsive enough.
5183 (Flength): Report an error instead of overflowing an integer.
5184 (Fsafe_length): Return a float if the value is not representable
5185 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5186 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5187 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5188
dd0b0efb
PE
5189 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5190 (header_size, word_size): New constants.
5191 (allocate_vectorlike): Don't check size overflow here.
5192 (allocate_vector): Check it here instead, since this is the only
5193 caller of allocate_vectorlike that could cause overflow.
5194 Check that the new vector's length is representable as a fixnum.
5195
86fe5cfe
PE
5196 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5197 The previous code was bogus. For example, next_almost_prime (32)
5198 returned 39, which is undesirable as it is a multiple of 3; and
5199 next_almost_prime (24) returned 25, which is a multiple of 5 so
5200 why was the code bothering to check for multiples of 7?
5201
80e88859
PE
5202 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5203
4a2f0ad6
PE
5204 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5205
f66c7cf8
PE
5206 Variadic C functions now count arguments with ptrdiff_t.
5207 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5208 Back then I didn't know that the Emacs coding style prefers signed int.
5209 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5210 were being counted with int, which may truncate counts on 64-bit
5211 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5212 * lisp.h (struct Lisp_Subr.function.aMANY)
5213 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5214 Arg counts are now ptrdiff_t, not size_t.
5215 All variadic functions and their callers changed accordingly.
5216 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5217 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5218 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5219 * callint.c (Fcall_interactively): Check arg count for overflow,
5220 to avoid potential buffer overrun. Use signed char, not 'int',
5221 for 'varies' array, so that we needn't bother to check its size
5222 calculation for overflow.
5223 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5224 * eval.c (apply_lambda):
5225 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5226 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5227 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5228
a1759b76
PE
5229 * callint.c (Fcall_interactively): Don't use index var as event count.
5230
d96be9fc
PE
5231 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5232 * mem-limits.h (SIZE): Remove; no longer used.
5233
a690a978 5234 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5235
578c21e6
PE
5236 Remove unnecessary casts.
5237 * xterm.c (x_term_init):
5238 * xfns.c (x_set_border_pixel):
5239 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5240 These aren't needed now that we assume ANSI C.
5241
96f53c6c
PE
5242 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5243 It's more likely to cause problems (due to unsigned overflow)
5244 than to cure them.
5245
83c77d31
PE
5246 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5247
ee2079f1
PE
5248 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5249
6da65536
PE
5250 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5251
7147c4a4
PE
5252 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5253
193e32d9
PE
5254 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5255
e5533da6
PE
5256 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5257
9910e595
PE
5258 GLYPH_CODE_FACE returns EMACS_INT, not int.
5259 * dispextern.h (merge_faces):
5260 * xfaces.c (merge_faces):
01103c44
PE
5261 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5262 Don't assume EMACS_INT fits in int.
9910e595 5263
2638320e
PE
5264 * character.h (CHAR_VALID_P): Remove unused parameter.
5265 * fontset.c, lisp.h, xdisp.c: All uses changed.
5266
045eb8d9
PE
5267 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5268
c1f134b5
PE
5269 * fns.c (concat): Minor tuning based on overflow analysis.
5270 This doesn't fix any bugs. Use int to hold character, instead
5271 of constantly refetching from Emacs object. Use XFASTINT, not
5272 XINT, for value known to be a character. Don't bother comparing
5273 a single byte to 0400, as it's always less.
5274
395fcb93 5275 * floatfns.c (Fexpt):
327eeec8
PE
5276 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5277
abbd3d23
PE
5278 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5279 for characters.
5280
684a03ef
PE
5281 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5282
0fed43f3
PE
5283 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5284 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5285 incorrectly succeed when S was a string, because 4294967386 was
5286 truncated before it was used.
5287
8fd02eb7
PE
5288 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5289 Otherwise, an out-of-range integer could cause undefined behavior
5290 on a 64-bit host.
5291
f8c86b69
PE
5292 * composite.c: Use int, not EMACS_INT, for characters.
5293 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5294 EMACS_INT, for values that are known to be in character range.
5295 This doesn't fix any bugs but is the usual style inside Emacs and
5296 may generate better code on 32-bit machines.
5297
34206dd2
PE
5298 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5299 This is for reasons similar to the recent CHAR_STRING fix.
5300 * charset.c (Fencode_char): Check that character arg is actually
5301 a character. Pass an int to ENCODE_CHAR.
5302 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5303 wider than 'int', as a compile-time check to prevent future regressions
5304 in this area.
5305
c5958d4c 5306 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5307
5308 Make sure a 64-bit char is never passed to CHAR_STRING.
5309 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5310 by silently ignoring the top 32 bits, allowing some values
5311 that were far too large to be valid characters.
5312 * character.h: Include <verify.h>.
5313 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5314 arguments are no wider than unsigned, as a compile-time check
5315 to prevent future regressions in this area.
5316 * data.c (Faset):
01103c44 5317 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5318 (Fsubst_char_in_region):
5319 * fns.c (concat):
5320 * xdisp.c (decode_mode_spec_coding):
5321 Adjust to CHAR_STRING's new requirement.
5322 * editfns.c (Finsert_char, Fsubst_char_in_region):
5323 * fns.c (concat): Check that character args are actually
5324 characters. Without this test, these functions did the wrong
5325 thing with wildly out-of-range values on 64-bit hosts.
5326
d37ca623
PE
5327 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5328 These casts should not be needed on 32-bit hosts, either.
5329 * keyboard.c (read_char):
5330 * lread.c (Fload): Remove casts to unsigned.
5331
ea204efb
PE
5332 * lisp.h (UNSIGNED_CMP): New macro.
5333 This fixes comparison bugs on 64-bit hosts.
5334 (ASCII_CHAR_P): Use it.
5335 * casefiddle.c (casify_object):
01103c44 5336 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5337 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5338 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5339 * dispextern.h (FACE_FROM_ID):
5340 * keyboard.c (read_char): Use UNSIGNED_CMP.
5341
41cb286c
PE
5342 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5343 not to EMACS_INT, to avoid GCC warning.
5344
4a1b9832
PE
5345 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5346
55daad71
PE
5347 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5348 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5349 isn't needed on 32-bit machines.
8f95c75c 5350
01103c44
PE
5351 * buffer.c (Fgenerate_new_buffer_name):
5352 Use EMACS_INT for count, not int.
0ceccced 5353 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5354
5355 * data.c (Qcompiled_function): Now static.
5356
c6f072e7
PE
5357 * window.c (window_body_lines): Now static.
5358
20ce5912
PE
5359 * image.c (gif_load): Rename local to avoid shadowing.
5360
9c4c5f81
PE
5361 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5362 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5363 * alloc.c (make_save_value): Integer argument is now of type
5364 ptrdiff_t, not int.
5365 (mark_object): Use ptrdiff_t, not int.
5366 * lisp.h (pD): New macro.
5367 * print.c (print_object): Use it.
5368
c0c5c8ae
PE
5369 * alloc.c: Use EMACS_INT, not int, to count objects.
5370 (total_conses, total_markers, total_symbols, total_vector_size)
5371 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5372 (total_free_floats, total_floats, total_free_intervals)
5373 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5374 Now EMACS_INT, not int. All uses changed.
5375 (Fgarbage_collect): Compute overall total using a double, so that
5376 integer overflow is less likely to be a problem. Check for overflow
5377 when converting back to an integer.
5a25e253
PE
5378 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5379 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5380 These were 'int' variables that could overflow on 64-bit hosts;
5381 they were never used, so remove them instead of repairing them.
211a0b2a 5382 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5383 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5384 Previously, this ceilinged at INT_MAX, but that doesn't work on
5385 64-bit machines.
e46bb31a 5386 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5387
c78baabf 5388 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5389 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5390 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5391 when a (possibly-narrower) signed value would do just as well.
5392 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5393
c9d624c6
PE
5394 * alloc.c: Catch some string size overflows that we were missing.
5395 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5396 for convenience in STRING_BYTES_MAX.
5397 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5398 The definition here is exact; the one in lisp.h was approximate.
5399 (allocate_string_data): Check for string overflow. This catches
5400 some instances we weren't catching before. Also, it catches
5401 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5402 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5403 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5404
c9d624c6
PE
5405 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5406 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5407 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5408
353032ce
PE
5409 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5410
2bccce07
PE
5411 * alloc.c (Fmake_string): Check for out-of-range init.
5412
0ac30604
SM
54132011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5414
5415 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5416
c195f2de
JD
54172011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5418
5419 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5420 xg_get_default_scrollbar_width.
5421
5422 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5423 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5424 (style_changed_cb): Call update_theme_scrollbar_width and call
5425 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5426 all frames (Bug#8505).
5427 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5428 Call gtk_window_set_resizable if HAVE_GTK3.
5429 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5430 and height if HAVE_GTK3 (Bug#8505).
5431 (scroll_bar_width_for_theme): New variable.
5432 (update_theme_scrollbar_width): New function.
5433 (xg_get_default_scrollbar_width): Move code to
5434 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5435 (xg_initialize): Call update_theme_scrollbar_width.
5436
5437 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5438
5439 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5440
e10ac9f1
MR
54412011-06-12 Martin Rudalics <rudalics@gmx.at>
5442
5443 * frame.c (make_frame): Call other_buffer_safely instead of
5444 other_buffer.
5445
5446 * window.c (temp_output_buffer_show): Call display_buffer with
5447 second argument Vtemp_buffer_show_specifiers and reset latter
5448 immediately after the call.
5449 (Vtemp_buffer_show_specifiers): New variable.
5450 (auto_window_vscroll_p, next_screen_context_lines)
5451 (Vscroll_preserve_screen_position): Remove leading asterisks from
5452 doc-strings.
5453
2d3c217e 54542011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5455
7b7f97e8 5456 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5457 * buffer.c (Qclone_number): Remove for now, as it's unused.
5458 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5459 (record_buffer): Remove unused local.
5460 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5461 (set_frame_buffer_list): Remove; unused.
5462 * frame.h (other_visible_frames): Remove decl.
5463 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5464 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5465 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5466 if HAVE_GPM.
5467 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5468 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5469 Define only if HAVE_GPM.
5470 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5471 (update_hints_inhibit): Remove; never set. All uses removed.
5472 * widgetprv.h (emacsFrameClassRec): Remove decl.
5473 * window.c (delete_deletable_window): Now returns void, since it
5474 wasn't returning anything.
5475 (compare_window_configurations): Remove unused locals.
5476 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5477 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5478 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5479 the same widths as pointers. This follows up on the 2011-05-06 patch.
5480 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5481 * xterm.h: Likewise.
5482 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5483
1384b89e
JB
54842011-06-12 Juanma Barranquero <lekktu@gmail.com>
5485
5486 * makefile.w32-in: Update dependencies.
5487 (LISP_H): Add lib/intprops.h.
5488
1100a63c
CY
54892011-06-11 Chong Yidong <cyd@stupidchicken.com>
5490
5491 * image.c (gif_load): Add animation frame delay to the metadata.
5492 (syms_of_image): Use DEFSYM. New symbol `delay'.
5493
6198ccd0
MR
54942011-06-11 Martin Rudalics <rudalics@gmx.at>
5495
5496 * window.c (delete_deletable_window): Re-add.
5497 (Fset_window_configuration): Rewrite to handle dead buffers and
5498 consequently deletable windows.
5499 (window_tree, Fwindow_tree): Remove. Supply functionality in
5500 window.el.
5501 (compare_window_configurations): Simplify code.
5502
b6e3633c
AS
55032011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5504
1ab0dee5
AS
5505 * image.c (imagemagick_load_image): Fix type mismatch.
5506 (Fimagemagick_types): Likewise.
5507
b6e3633c
AS
5508 * window.h (replace_buffer_in_windows): Declare.
5509
9397e56f
MR
55102011-06-11 Martin Rudalics <rudalics@gmx.at>
5511
5512 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5513 Qclone_number. Remove external declaration of Qdelete_window.
5514 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5515 code.
640c8776
SM
5516 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5517 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5518 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5519 buffer list implementation.
5520 (other_buffer_safely): New function.
5521 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5522 calls to replace_buffer_in_windows and
5523 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5524 if allowed.
5525 (record_buffer): Inhibit quitting and rewrite using quittable
5526 functions. Run Qbuffer_list_update_hook if allowed.
5527 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5528 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5529 Move switch-to-buffer to window.el.
9397e56f
MR
5530 (bury-buffer): Move to window.el.
5531 (Vbuffer_list_update_hook): New variable.
5532
5533 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5534 section.
5535
5536 * window.h (resize_frame_windows): Move up in code.
5537 (Fwindow_frame): Remove EXFUN.
5538 (replace_buffer_in_all_windows): Remove prototype.
5539 (replace_buffer_in_windows_safely): Add prototype.
5540
5541 * window.c: Declare Qdelete_window static again. Move down
5542 declaration of select_count.
5543 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5544 (Fother_window): Move to window.el.
5545 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5546 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5547 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5548 window.el.
5549 (replace_buffer_in_windows): Implement by calling
5550 Qreplace_buffer_in_windows.
5551 (replace_buffer_in_all_windows): Remove with some functionality
5552 moved into replace_buffer_in_windows_safely.
5553 (replace_buffer_in_windows_safely): New function.
5554 (select_window_norecord, select_frame_norecord): Move in front
5555 of run_window_configuration_change_hook. Remove now obsolete
5556 declarations.
640c8776
SM
5557 (Fset_window_buffer): Rewrite doc-string.
5558 Call Qrecord_window_buffer.
9397e56f
MR
5559 (keys_of_window): Move binding for other-window to window.el.
5560
b50691aa
CY
55612011-06-11 Chong Yidong <cyd@stupidchicken.com>
5562
5563 * dispextern.h (struct image): Replace data member, whose int_val
5564 and ptr_val fields were not used by anything, with a single
5565 lisp_val object.
5566
5567 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5568 (gif_clear_image, gif_load, imagemagick_load_image)
5569 (gs_clear_image, gs_load): Callers changed.
5570
3f754b86
PE
55712011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5572
cca69397
PE
5573 * buffer.h: Include <time.h>, for time_t.
5574 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5575
109e28d0
PE
5576 Fix minor problems found by static checking.
5577
60737f02
PE
5578 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5579
4b66faf3
PE
5580 Make identifiers static if they are not used in other modules.
5581 * data.c (Qcompiled_function, Qframe, Qvector):
5582 * image.c (QimageMagick, Qsvg):
5583 * minibuf.c (Qmetadata):
5584 * window.c (resize_window_check, resize_root_window): Now static.
5585 * window.h (resize_window_check, resize_root_window): Remove decls.
5586
109e28d0
PE
5587 * window.c (window_deletion_count, delete_deletable_window):
5588 Remove; unused.
46a4ce9e
PE
5589 (window_body_lines): Now static.
5590 (Fdelete_other_windows_internal): Mark vars as initialized.
5591 Make sure 'resize_failed' is initialized.
5592 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5593 (resize_window_apply): Remove unused local.
5594 * window.h (delete_deletable_window): Remove decl.
5595
109e28d0 5596 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5597 (imagemagick_load_image): Fix pointer signedness problem by changing
5598 last arg from unsigned char * to char *. All uses changed.
5599 Also, fix a local for similar reasons.
5600 Remove unused locals. Remove locals to avoid shadowing.
5601 (fn_rsvg_handle_free): Remove; unused.
5602 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5603 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5604
3f754b86
PE
5605 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5606
2547adb1
CY
56072011-06-10 Chong Yidong <cyd@stupidchicken.com>
5608
5609 * image.c (gif_load): Fix omitted cast error introduced by
5610 2011-06-06 change.
5611
2c8e37d4
MR
56122011-06-10 Martin Rudalics <rudalics@gmx.at>
5613
5614 * window.h (resize_proportionally, orig_total_lines)
5615 (orig_top_line): Remove from window structure.
5616 (set_window_height, set_window_width, change_window_heights)
5617 (Fdelete_window): Remove prototypes.
5618 (resize_frame_windows): Remove duplicate declaration.
5619
440a42e3
EZ
56202011-06-10 Eli Zaretskii <eliz@gnu.org>
5621
5622 * window.h (resize_frame_windows, resize_window_check)
5623 (delete_deletable_window, resize_root_window)
5624 (resize_frame_windows): Declare prototypes.
5625
5626 * window.c (resize_window_apply): Make definition be "static" to
5627 match the prototype.
5628
562dd5e9
MR
56292011-06-10 Martin Rudalics <rudalics@gmx.at>
5630
5631 * window.c: Remove declarations of Qwindow_size_fixed,
5632 window_min_size_1, window_min_size_2, window_min_size,
5633 size_window, window_fixed_size_p, enlarge_window, delete_window.
5634 Remove static from declaration of Qdelete_window, it's
5635 temporarily needed by Fbury_buffer.
5636 (replace_window): Don't assign orig_top_line and
5637 orig_total_lines.
5638 (Fdelete_window, delete_window): Remove. Window deletion is
5639 handled by window.el.
640c8776
SM
5640 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5641 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5642 (Fdelete_other_windows): Remove. Deleting other windows is
5643 handled by window.el.
5644 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5645 handled in window.el.
5646 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5647 Window minimum sizes are handled in window.el.
5648 (shrink_windows, size_window, set_window_height)
5649 (set_window_width, change_window_heights, window_height)
5650 (window_width, CURBEG, CURSIZE, enlarge_window)
5651 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5652 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5653 handled in window.el.
5654 (make_dummy_parent): Rename to make_parent_window and give it a
5655 second argument horflag.
5656 (make_window): Don't set resize_proportionally any more.
5657 (Fsplit_window): Remove. Windows are split in window.el.
5658 (save_restore_action, save_restore_orig_size)
5659 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5660 Resize mini windows in window.el.
5661 (grow_mini_window, shrink_mini_window): Implement by calling
5662 Qresize_root_window_vertically, resize_window_check and
5663 resize_window_apply.
640c8776
SM
5664 (saved_window, Fset_window_configuration, save_window_save):
5665 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5666 resize_proportionally.
5667 (window_min_height, window_min_width): Move to window.el.
5668 (keys_of_window): Move bindings for delete-other-windows,
5669 split-window, delete-window and enlarge-window to window.el.
5670
5671 * buffer.c: Temporarily extern Qdelete_window.
5672 (Fbury_buffer): Temporarily call Qdelete_window instead of
5673 Fdelete_window (Fbury_buffer will move to window.el soon).
5674
5675 * frame.c (set_menu_bar_lines_1): Remove code handling
5676 orig_top_line and orig_total_lines.
5677
5678 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5679 set_window_height but set heights directly.
5680 (change_frame_size_1): Use resize_frame_windows.
5681
5682 * xdisp.c (init_xdisp): Don't use set_window_height but set
5683 heights directly.
5684
640c8776
SM
5685 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5686 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5687 run_window_configuration_change_hook.
5688
5689 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5690 instead of change_window_heights and run
5691 run_window_configuration_change_hook.
5692
1a13852e
MR
56932011-06-09 Martin Rudalics <rudalics@gmx.at>
5694
5695 * window.c (replace_window): Rename second argument REPLACEMENT to
5696 NEW. New third argument SETFLAG. Rewrite.
5697 (delete_window, make_dummy_parent): Call replace_window with
5698 third argument 1.
5699 (window_list_1): Move down in code.
5700 (run_window_configuration_change_hook): Move set_buffer part
5701 before select_frame_norecord part in order to unwind correctly.
5702 Rename count1 to count.
5703 (recombine_windows, delete_deletable_window, resize_root_window)
5704 (Fdelete_other_windows_internal)
5705 (Frun_window_configuration_change_hook, make_parent_window)
5706 (resize_window_check, resize_window_apply, Fresize_window_apply)
5707 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5708 (Fdelete_window_internal, Fresize_mini_window_internal):
5709 New functions.
1a13852e
MR
5710 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5711
f3d1777e
MR
57122011-06-08 Martin Rudalics <rudalics@gmx.at>
5713
496e208e
MR
5714 * window.h (window): Add some new members to window structure -
5715 normal_lines, normal_cols, new_total, new_normal, clone_number,
5716 splits, nest, prev_buffers, next_buffers.
5717 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5718 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5719
f3d1777e
MR
5720 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5721 Remove.
496e208e
MR
5722 (make_dummy_parent): Set new members of windows structure.
5723 (make_window): Move down in code. Handle new members of window
5724 structure.
5725 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5726 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5727 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5728 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5729 (Fset_window_next_buffers, Fset_window_clone_number):
5730 New functions.
496e208e
MR
5731 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5732 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5733 Doc-string fixes.
5734 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5735 Argument WINDOW can be now internal window too.
5736 (Fwindow_use_time): Move up in code.
5737 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5738 Rewrite doc-string.
5739 (Fset_window_configuration, saved_window)
5740 (Fcurrent_window_configuration, save_window_save): Handle new
5741 members of window structure.
b9e809c2
MR
5742 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5743 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5744 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5745 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5746 Qget_mru_window, Qresize_root_window,
5747 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5748 Qauto_buffer_name; staticpro them.
f3d1777e 5749
abde8f8c
MR
57502011-06-07 Martin Rudalics <rudalics@gmx.at>
5751
5752 * window.c (Fwindow_total_size, Fwindow_left_column)
5753 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5754 (Fwindow_list_1): New functions.
5755 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5756 (Fwindow_width, Fscroll_left, Fscroll_right):
5757 Use window_body_cols instead of window_box_text_cols.
5758 (delete_window, Fset_window_configuration):
5759 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5760 (delete_all_subwindows): Take a window as argument and not a
5761 structure. Rewrite.
190b47e6
MR
5762 (window_loop): Remove handling of GET_LRU_WINDOW and
5763 GET_LARGEST_WINDOW.
5764 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5765
5766 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5767 window_box_text_cols. delete_all_subwindows now takes a
5768 Lisp_Object as argument.
abde8f8c 5769
640c8776
SM
5770 * indent.c (compute_motion, Fcompute_motion):
5771 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5772
fa8a67e6
MR
5773 * frame.c (delete_frame): Call delete_all_subwindows with root
5774 window as argument.
5775
a54e3482
DC
57762011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5777
5778 * fns.c (Fputhash): Document return value.
5779
60002bf5
CY
57802011-06-06 Chong Yidong <cyd@stupidchicken.com>
5781
5782 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5783
0c671da6 57842011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5785
b862a52a 5786 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5787
be44ca6c
PE
5788 Check for overflow when converting integer to cons and back.
5789 * charset.c (Fdefine_charset_internal, Fdecode_char):
5790 Use cons_to_unsigned to catch overflow.
5791 (Fencode_char): Use INTEGER_TO_CONS.
5792 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5793 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5794 * data.c (long_to_cons, cons_to_long): Remove.
5795 (cons_to_unsigned, cons_to_signed): New functions.
5796 These signal an error for invalid or out-of-range values.
5797 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5798 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5799 * font.c (Ffont_variation_glyphs):
5800 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5801 * lisp.h: Include <intprops.h>.
5802 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5803 (cons_to_signed, cons_to_unsigned): New decls.
5804 (long_to_cons, cons_to_long): Remove decls.
5805 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5806 (Fprimitive_undo): Use CONS_TO_INTEGER.
5807 * xfns.c (Fx_window_property): Likewise.
5808 * xselect.c: Include <limits.h>.
5809 (x_own_selection, selection_data_to_lisp_data):
5810 Use INTEGER_TO_CONS.
5811 (x_handle_selection_request, x_handle_selection_clear)
5812 (x_get_foreign_selection, Fx_disown_selection_internal)
5813 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5814 (lisp_data_to_selection_data): Use cons_to_unsigned.
5815 (x_fill_property_data): Use cons_to_signed.
5816 Report values out of range.
5817
d1f3d2af
PE
5818 Check for buffer and string overflow more precisely.
5819 * buffer.h (BUF_BYTES_MAX): New macro.
5820 * lisp.h (STRING_BYTES_MAX): New macro.
5821 * alloc.c (Fmake_string):
5822 * character.c (string_escape_byte8):
5823 * coding.c (coding_alloc_by_realloc):
5824 * doprnt.c (doprnt):
5825 * editfns.c (Fformat):
5826 * eval.c (verror):
5827 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5828 since they may not be the same number.
5829 * editfns.c (Finsert_char):
5830 * fileio.c (Finsert_file_contents):
5831 Likewise for BUF_BYTES_MAX.
5832
dd52fcea
PE
5833 * image.c: Use ptrdiff_t, not int, for sizes.
5834 (slurp_file): Switch from int to ptrdiff_t.
5835 All uses changed.
5836 (slurp_file): Check that file size fits in both size_t (for
5837 malloc) and ptrdiff_t (for sanity and safety).
5838
7f9bbdbb
PE
5839 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5840 if b->modtime has its maximal value.
5841
dfe18f82
PE
5842 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5843
84acfcf0
PE
5844 Don't assume time_t can fit into int.
5845 * buffer.h (struct buffer.modtime): Now time_t, not int.
5846 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5847 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5848
ccd9a01a
PE
5849 Minor fixes for signed vs unsigned integers.
5850 * character.h (MAYBE_UNIFY_CHAR):
5851 * charset.c (maybe_unify_char):
5852 * keyboard.c (read_char, reorder_modifiers):
5853 XINT -> XFASTINT, since the integer must be nonnegative.
5854 * ftfont.c (ftfont_spec_pattern):
5855 * keymap.c (access_keymap, silly_event_symbol_error):
5856 XUINT -> XFASTINT, since the integer must be nonnegative.
5857 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5858 since it makes no difference and we prefer signed.
5859 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5860 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5861 nonnegative.
5862
d6d100dd
SM
58632011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5864
5865 * window.h (Fwindow_frame): Declare.
5866
2b6148e4
PE
58672011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5868
5869 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5870 (SPARE_MEMORY): Always define.
5871 (LARGE_REQUEST): Remove.
5872 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5873
f230ecc9
MR
58742011-06-06 Martin Rudalics <rudalics@gmx.at>
5875
727e958e
MR
5876 * lisp.h: Move EXFUNS for Fframe_root_window,
5877 Fframe_first_window and Fset_frame_selected_window to window.h.
5878
5879 * window.h: Move EXFUNS for Fframe_root_window,
5880 Fframe_first_window and Fset_frame_selected_window here from
5881 lisp.h.
5882
5883 * frame.c (Fwindow_frame, Fframe_first_window)
5884 (Fframe_root_window, Fframe_selected_window)
5885 (Fset_frame_selected_window): Move to window.c.
5886 (Factive_minibuffer_window): Move to minibuf.c.
5887 (Fother_visible_frames_p): New function.
5888
5889 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5890
f230ecc9
MR
5891 * window.c (decode_window, decode_any_window): Move up in code.
5892 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5893 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5894 (Fwindow_buffer): Move up and rewrite doc-string.
5895 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5896 (Fwindow_prev): New functions.
727e958e
MR
5897 (Fwindow_frame): Move here from frame.c. Accept any window as
5898 argument.
5899 (Fframe_root_window, Fframe_first_window)
5900 (Fframe_selected_window): Move here from frame.c. Accept frame
5901 or arbitrary window as argument. Update doc-strings.
5902 (Fminibuffer_window): Move up in code.
5903 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5904 (Fset_frame_selected_window): Move here from frame.c.
5905 Marginal rewrite.
727e958e
MR
5906 (Fselected_window, select_window, Fselect_window): Move up in
5907 code. Minor doc-string fixes.
f230ecc9 5908
4d09bcf6
PE
59092011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5910
5911 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5912 Do not assume that spare memory exists; that assumption is valid
5913 only if SYSTEM_MALLOC.
5914 (LARGE_REQUEST): New macro, so that the issue of large requests
5915 is separated from the issue of spare memory.
5916
810928a2
AS
59172011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5918
172418ad
AS
5919 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5920 format. (Bug#8806)
5921
43f862f7
AS
5922 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5923
810928a2
AS
5924 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5925 before statements.
5926
a059fe24
JD
59272011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5928
5929 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5930
5931 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5932
5933 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5934 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5935
989bf368
JB
59362011-06-05 Juanma Barranquero <lekktu@gmail.com>
5937
5938 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5939
4b80f674
CY
59402011-06-04 Chong Yidong <cyd@stupidchicken.com>
5941
5942 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5943 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5944 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5945 New error handlers.
4b80f674
CY
5946 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5947 Obey Vx_select_enable_clipboard_manager. Catch errors in
5948 x_clipboard_manager_save (Bug#8779).
5949 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5950 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5951
99a33b77 59522011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5953
5954 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5955
99a33b77 59562011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5957
5958 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5959 in the current matrix if keep_current_p is non-zero.
5960
8264569d
EZ
59612011-06-04 Eli Zaretskii <eliz@gnu.org>
5962
5963 * bidi.c (bidi_level_of_next_char): Fix last change.
5964
57f97249
EZ
59652011-06-03 Eli Zaretskii <eliz@gnu.org>
5966
fec2107c 5967 Support bidi reordering of text covered by display properties.
57f97249 5968
fec2107c
EZ
5969 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
5970 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
5971 (bidi_cache_search, bidi_cache_iterator_state)
5972 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
5973 (bidi_level_of_next_char, bidi_move_to_visually_next):
5974 Support character positions inside a run of characters covered by a
fec2107c
EZ
5975 display string.
5976 (bidi_paragraph_init, bidi_resolve_explicit_1)
5977 (bidi_level_of_next_char): Call bidi_fetch_char and
5978 bidi_fetch_char_advance instead of FETCH_CHAR and
5979 FETCH_CHAR_ADVANCE.
5980 (bidi_init_it): Initialize new members.
5981 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
5982 definitions.
5983 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
5984 instead of using explicit *_CHAR codes.
d6d100dd
SM
5985 (bidi_resolve_explicit, bidi_resolve_weak):
5986 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
5987 bidirectional text is supported only in multibyte buffers.
5988 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
5989 it to initialize the frame_window_p member of struct bidi_it.
5990 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
5991 (bidi_resolve_explicit, bidi_resolve_weak)
5992 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
5993 bidi_it->nchars is non-positive.
5994 (bidi_level_of_next_char): Don't try to lookup the cache for the
5995 next/previous character if nothing is cached there yet, or if we
5996 were just reseat()'ed to a new position.
c40e2fb2 5997
0e14fe90
EZ
5998 * xdisp.c (set_cursor_from_row): Set start and stop points
5999 according to the row's direction when priming the loop that looks
6000 for the glyph on which to display cursor.
6001 (single_display_spec_intangible_p): Function deleted.
6002 (display_prop_intangible_p): Reimplement to call
6003 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6004 Accept 3 additional arguments needed by handle_display_spec.
6005 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6006 values: lists, `(when COND...)' forms, etc.
6007 (single_display_spec_string_p): Support property values that are
6008 lists with the argument STRING its top-level element.
6009 (display_prop_string_p): Fix the condition for processing a
6010 property that is a list to be consistent with handle_display_spec.
fec2107c 6011 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6012 last portion of handle_display_prop.
6013 (compute_display_string_pos): Accept additional argument
6014 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6015 value of a `display' property is a "replacing spec".
6016 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6017 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6018 the display property, but just return a value indicating whether
6019 the display property will replace the characters it covers.
6020 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6021 frame_window_p members of struct bidi_it.
d6d100dd
SM
6022 (compute_display_string_pos, compute_display_string_end):
6023 New functions.
fec2107c
EZ
6024 (push_it): Accept second argument POSITION, where pop_it should
6025 jump to continue iteration.
6026 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6027
fec2107c
EZ
6028 * keyboard.c (adjust_point_for_property): Adjust the call to
6029 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6030
6031 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6032 (bidi_init_it): Update prototypes.
6033 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6034 (compute_display_string_pos, compute_display_string_end):
6035 Declare prototypes.
fec2107c
EZ
6036 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6037 EMACS_INT.
fc6f18ce 6038
40087514 60392011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6040
57f53182
PE
6041 Malloc failure behavior now depends on size of allocation.
6042 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6043 * lisp.h: Change signatures accordingly.
6044 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6045 All callers changed. (Bug#8762)
6046
6047 * gnutls.c: Use Emacs's memory allocators.
6048 Without this change, the gnutls library would invoke malloc etc.
6049 directly, which causes problems on non-SYNC_INPUT hosts, and which
6050 runs afoul of improving memory_full behavior. (Bug#8761)
6051 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6052 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6053 xfree instead of the default malloc, realloc, free.
6054 (Fgnutls_boot): No need to check for memory allocation failure,
6055 since xmalloc does that for us.
6056
ac32cd99 6057 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6058 * category.c (hash_get_category_set):
6059 * ccl.c (ccl_driver):
6060 * charset.c (Fdefine_charset_internal):
6061 * charset.h (struct charset.hash_index):
6062 * composite.c (get_composition_id, gstring_lookup_cache)
6063 (composition_gstring_put_cache):
6064 * composite.h (struct composition.hash_index):
6065 * dispextern.h (struct image.hash):
6066 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6067 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6068 (hashfn_equal, hashfn_user_defined, make_hash_table)
6069 (maybe_resize_hash_table, hash_lookup, hash_put)
6070 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6071 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6072 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6073 * image.c (make_image, search_image_cache, lookup_image)
6074 (xpm_put_color_table_h):
6075 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6076 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6077 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6078 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6079 * alloc.c (allocate_vectorlike):
6080 Check for overflow in vector size calculations.
6081 * ccl.c (ccl_driver):
6082 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6083 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6084 need to be updated by these changes.
40087514
PE
6085 * fns.c (make_hash_table, maybe_resize_hash_table):
6086 Check for integer overflow with large hash tables.
0de4bb68
PE
6087 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6088 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6089 (SXHASH_REDUCE): New macro.
6090 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6091 Use it instead of discarding useful hash info with large hash values.
6092 (sxhash_float): New function.
6093 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6094 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6095 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6096 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6097 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6098 Adjust signatures to match updated version of code.
6099 (consing_since_gc): Now EMACS_INT, since a single hash table can
6100 use more than INT_MAX bytes.
6101
698d32e2
DN
61022011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6103
6104 Make it possible to build with GCC-4.6+ -O2 -flto.
6105
6106 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6107
fd6fa53f
SM
61082011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6109
6110 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6111 Call minibuffer-inactive-mode.
6112
864db017
JB
61132011-05-31 Juanma Barranquero <lekktu@gmail.com>
6114
6115 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6116 Update dependencies.
6117
2ad0baf4
DN
61182011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6119
6120 * data.c (init_data): Remove code for UTS, this system is not
6121 supported anymore.
6122
4fcc2638
DN
61232011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6124
6125 Don't force ./temacs to start in terminal mode.
6126
6127 * frame.c (make_initial_frame): Initialize faces in all cases, not
6128 only when CANNOT_DUMP is defined.
6129 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6130
c56e0fd5
DN
61312011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6132
6133 * dispnew.c (add_window_display_history): Use const for the string
6134 pointer. Remove declaration, not needed.
6135
333d54da 61362011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6137
55d4c1b2 6138 Use 'inline', not 'INLINE'.
333d54da 6139 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6140 * alloc.c, fontset.c (INLINE): Remove.
6141 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6142 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6143 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6144 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6145 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6146
738db178
DN
61472011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6148
6149 Make it possible to run ./temacs.
6150
6151 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6152 syms_of_callproc does the same thing. Remove test for
6153 "initialized", do it in the caller.
6154 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6155
620c53a6
SM
61562011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6157
6158 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6159 (read_minibuf): Use get_minibuffer.
6160 (syms_of_minibuf): Use DEFSYM.
6161 (Qmetadata): New var.
6162 * data.c (Qbuffer): Don't make it static.
6163 (syms_of_data): Use DEFSYM.
6164
e003a292
PE
61652011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6166
6167 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6168 (CCL_CODE_MIN): New macro.
6169
ed008a6d
PE
61702011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6171
3687c2ef
PE
6172 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6173
ed008a6d
PE
6174 * eval.c (Qdebug): Now static.
6175 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6176 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6177 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6178
d66c4c7c
CY
61792011-05-29 Chong Yidong <cyd@stupidchicken.com>
6180
6181 * image.c: Various fixes to ImageMagick code comments.
6182 (Fimagemagick_types): Doc fix.
6183
5fbc2025
PE
61842011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6185
0196f88a
PE
6186 Minor fixes prompted by GCC 4.6.0 warnings.
6187
6188 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6189
5fbc2025
PE
6190 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6191 (x_clipboard_manager_save_all): Move extern decl to ...
6192 * xterm.h: ... here, so that it can be checked for consistency.
6193
1dd3c2d9
CY
61942011-05-29 Chong Yidong <cyd@stupidchicken.com>
6195
6196 * xselect.c (x_clipboard_manager_save_frame)
6197 (x_clipboard_manager_save_all): New functions.
6198 (Fx_clipboard_manager_save): Lisp function deleted.
6199
6200 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6201 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6202
6203 * xterm.h: Update prototype.
6204
5ba6571d
WX
62052011-05-28 William Xu <william.xwl@gmail.com>
6206
6207 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6208 exiting (Bug#8239).
6209
3eaff834
JM
62102011-05-28 Jim Meyering <meyering@redhat.com>
6211
e1900994 6212 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6213 * fns.c (to_uchar): Define.
6214 (crypto_hash_function): Use it to convert some newly-signed
6215 variables to unsigned, to avoid sign-extension bugs. For example,
6216 without this change, (md5 "truc") would evaluate to
6217 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6218 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6219 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6220
0f6990a7
PE
62212011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6222
6223 Integer overflow fixes.
c8a9ca5a 6224
08686060
PE
6225 * dbusbind.c: Serial number integer overflow fixes.
6226 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6227 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6228 to hold a serial number that is too large for a fixnum.
6229 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6230 Check for serial numbers out of range. Decode any serial number
59568bf0 6231 that was so large that it became a float. (Bug#8722)
08686060 6232
2d1fc3c7
PE
6233 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6234 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6235 Use XFASTINT rather than XUINT when numbers are nonnegative.
6236 (xd_append_arg, Fdbus_method_return_internal):
6237 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6238 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6239 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6240 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6241 (Bug#8722)
2d1fc3c7 6242
c8a9ca5a
PE
6243 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6244
519e1d69
PE
6245 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6246
6df6ae42 6247 ccl: Add integer overflow checks.
30569699
PE
6248 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6249 (IN_INT_RANGE): New macros.
6250 (ccl_driver): Use them to check for integer overflow when
6251 decoding a CCL program. Many of the new checks are whether XINT (x)
6252 fits in int; it doesn't always, on 64-bit hosts. The new version
6253 doesn't catch all possible integer overflows, but it's an
847044ea 6254 improvement. (Bug#8719)
30569699 6255
c11285dc
PE
6256 * alloc.c (make_event_array): Use XINT, not XUINT.
6257 There's no need for unsigned here.
6258
fdccd48e
PE
6259 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6260 This follows up to the 2011-05-06 change that substituted uintptr_t
6261 for EMACS_INT. This case wasn't caught back then.
6262
37910ab2
PE
6263 Rework Fformat to avoid integer overflow issues.
6264 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6265 now (part of C89). Include <verify.h>.
6266 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6267 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6268 (Fformat): Avoid the prepass trying to compute sizes; it was only
6269 approximate and thus did not catch overflow reliably. Instead, walk
6270 through the format just once, formatting and computing sizes as we go,
6271 checking for integer overflow at every step, and allocating a larger
6272 buffer as needed. Keep track separately whether the format is
6273 multibyte. Keep only the most-recently calculated precision, rather
6274 than them all. Record whether each argument has been converted to
6275 string. Use EMACS_INT, not int, for byte and char and arg counts.
6276 Support field widths and precisions larger than INT_MAX. Avoid
6277 sprintf's undefined behavior with conversion specifications such as %#d
6278 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6279 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6280 formatting out-of-range floating point numbers with int
9173deec 6281 formats. (Bug#8668)
37910ab2 6282
2e6578fb
PE
6283 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6284
0ae6bdee
PE
6285 * data.c: Avoid integer truncation in expressions involving floats.
6286 * data.c: Include <intprops.h>.
6287 (arith_driver): When there's an integer overflow in an expression
6288 involving floating point, convert the integers to floating point
6289 so that the resulting value does not suffer from catastrophic
6290 integer truncation. For example, on a 64-bit host (* 4
6291 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6292 Do not rely on undefined behavior after integer overflow.
6293
de883a70
PE
6294 merge count_size_as_multibyte, parse_str_to_multibyte
6295 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6296 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6297 Check for integer overflow.
6298 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6299 since it's now a duplicate of the other. This is more of
6300 a character than a buffer op, so better that it's in character.c.
6301 * fns.c, print.c: Adjust to above changes.
6302
2ff916cb
PE
63032011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6304
6305 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6306
f1b54466
PE
63072011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6308
fb1ac845
PE
6309 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6310 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6311 (x_clipboard_manager_save): Now static.
6312 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6313
f1b54466
PE
6314 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6315 (crypto_hash_function): Now static.
6316 Fix pointer signedness problems. Avoid unnecessary initializations.
6317
a9f737ee
CY
63182011-05-27 Chong Yidong <cyd@stupidchicken.com>
6319
6320 * termhooks.h (Vselection_alist): Make it terminal-local.
6321
6322 * terminal.c (create_terminal): Initialize it.
6323
6324 * xselect.c: Support for clipboard managers.
6325 (Vselection_alist): Move to termhooks.h as terminal-local var.
6326 (LOCAL_SELECTION): New macro.
6327 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6328 (symbol_to_x_atom): Remove gratuitous arg.
6329 (x_handle_selection_request, lisp_data_to_selection_data)
6330 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6331 (x_own_selection, x_get_local_selection, x_convert_selection):
6332 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6333 (some_frame_on_display): Delete unused function.
6334 (Fx_own_selection_internal, Fx_get_selection_internal)
6335 (Fx_disown_selection_internal, Fx_selection_owner_p)
6336 (Fx_selection_exists_p): New optional frame arg.
6337 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6338 (x_handle_selection_clear): Don't treat other terminals with the
6339 same keyboard specially. Use the terminal-local Vselection_alist.
6340 (x_clear_frame_selections): Use Frun_hook_with_args.
6341
6342 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6343
6344 * xterm.h: Add support for those atoms.
6345
e067f0c1
CY
63462011-05-26 Chong Yidong <cyd@stupidchicken.com>
6347
6348 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6349 (converted_selections, conversion_fail_tag): New global variables.
6350 (x_selection_request_lisp_error): Free the above.
6351 (x_get_local_selection): Remove unnecessary code.
6352 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6353 of converted selections stored in converted_selections.
6354 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6355 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6356 (x_convert_selection): New function.
6357 (x_handle_selection_event): Simplify.
6358 (x_get_foreign_selection): Don't ignore incoming requests while
6359 waiting for an answer; this will fail when we implement
6360 SAVE_TARGETS, and seems unnecessary anyway.
6361 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6362 (Vx_sent_selection_functions): Doc fix.
6363
0f4aebc0
LL
63642011-05-26 Leo Liu <sdl.web@gmail.com>
6365
6366 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6367
e61124cd
YM
63682011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6369
6370 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6371
6372 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6373 for fringe update if it has periodic bitmap.
ac389d0c 6374 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6375 and fringe_bitmap_periodic_p.
6376
6377 * fringe.c (get_fringe_bitmap_data): New function.
6378 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6379 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6380 row. Mark glyph row for fringe update if periodicity changed.
6381
6382 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6383 for fringe update unless it has periodic bitmap.
6384
f16d9837
KH
63852011-05-25 Kenichi Handa <handa@m17n.org>
6386
6387 * xdisp.c (get_next_display_element): Set correct it->face_id for
6388 a static composition.
6389
e1b90ef6
LL
63902011-05-24 Leo Liu <sdl.web@gmail.com>
6391
6392 * deps.mk (fns.o):
6393 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6394
6395 * fns.c (crypto_hash_function, Fsha1): New function.
6396 (Fmd5): Use crypto_hash_function.
6397 (syms_of_fns): Add Ssha1.
6398
7400048f
PE
63992011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6400
6401 * gnutls.c: Remove unused macros.
6402 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6403 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6404 Remove macros that are defined and never used.
6405 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6406
abb71cf4
CY
64072011-05-22 Chong Yidong <cyd@stupidchicken.com>
6408
6409 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6410 (Fx_get_selection_internal): Minor cleanup.
6411 (Fx_own_selection_internal): Rename arguments for consistency with
6412 select.el.
6413
6307db39
PE
64142011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6415
6416 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6417
f3d4e0a4
CY
64182011-05-22 Chong Yidong <cyd@stupidchicken.com>
6419
6420 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6421
4d8ade89
YM
64222011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6423
6424 * dispnew.c (scrolling_window): Don't exclude the case that the
6425 last enabled row in the desired matrix touches the bottom boundary.
6426
32078c8d
GM
64272011-05-21 Glenn Morris <rgm@gnu.org>
6428
6429 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6430 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6431 and add some more files.
32078c8d 6432
7285dc67
EZ
64332011-05-20 Eli Zaretskii <eliz@gnu.org>
6434
6435 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6436 report_file_error introduced by the change from 2011-05-07.
6437
89d1bd22
PE
64382011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6439
6440 * systime.h (Time): Define only if emacs is defined.
6441 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6442 where the include path doesn't have X11/X.h by default. See
6443 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6444
cd394be1 64452011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6446
6447 * composite.c (find_automatic_composition): Fix previous change.
6448
b9704ad9
GM
64492011-05-20 Glenn Morris <rgm@gnu.org>
6450
6451 * lisp.mk: New file, split from Makefile.in.
6452 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6453 (shortlisp): Remove.
6454 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6455
4a720484
GM
64562011-05-19 Glenn Morris <rgm@gnu.org>
6457
6458 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6459 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6460 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6461 (lisp): Set the order to that of loadup.el.
6462 (shortlisp): Make it a copy of $lisp.
6463 (SOME_MACHINE_LISP): Remove.
6464 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6465 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6466
a28d4396
KH
64672011-05-18 Kenichi Handa <handa@m17n.org>
6468
6469 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6470 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6471 (find_automatic_composition): Mostly rewrite for efficiency.
6472
a2b1fa8e
JB
64732011-05-18 Juanma Barranquero <lekktu@gmail.com>
6474
6475 * makefile.w32-in: Update dependencies.
6476
8e1f5610
CS
64772011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6478
6479 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6480 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6481
7025ee00 64822011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6483
cdfa6eab
PE
6484 Fix some integer overflow issues, such as string length overflow.
6485
06d6db33
PE
6486 * insdel.c (count_size_as_multibyte): Check for string overflow.
6487
2b4560a8
PE
6488 * character.c (lisp_string_width): Check for string overflow.
6489 Use EMACS_INT, not int, for string indexes and lengths; in
6490 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6491 the resulting string length overflows an EMACS_INT; instead,
6492 report a string overflow if no precision given. When checking for
6493 precision exhaustion, use a check that cannot possibly have
6494 integer overflow. (Bug#8675)
6495 * character.h (lisp_string_width): Adjust to new signature.
6496
cb93f9be
PE
6497 * alloc.c (string_overflow): New function.
6498 (Fmake_string): Use it. This doesn't change behavior, but saves
6499 a few bytes and will simplify future changes.
6500 * character.c (string_escape_byte8): Likewise.
6501 * lisp.h (string_overflow): New decl.
6502
1a1f3366
PE
6503 Fixups, following up to the user-interface timestamp change.
6504 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6505 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6506 * msdos.c (mouse_get_pos): Likewise.
6507 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6508 * w32gui.h (Time): Define by including "systime.h" rather than by
6509 declaring it ourselves. (Bug#8664)
6510
d4e3e4d3
PE
6511 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6512 * image.c (clear_image_cache): Likewise.
6513
f6a24d19
PE
6514 * term.c (term_mouse_position): Don't assume time_t wraparound.
6515
08dc5ae6
PE
6516 Be more systematic about user-interface timestamps.
6517 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6518 and sometimes 'EMACS_UINT', to represent these timestamps.
6519 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6520 This makes the code easier to follow, and makes it easier to catch
6521 integer overflow bugs such as Bug#8664.
6522 * frame.c (Fmouse_position, Fmouse_pixel_position):
6523 Use Time, not unsigned long, for user-interface timestamps.
6524 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6525 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6526 * keyboard.h (last_event_timestamp): Likewise.
6527 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6528 * menu.h (xmenu_show): Likewise.
6529 * term.c (term_mouse_position): Likewise.
6530 * termhooks.h (struct input_event.timestamp): Likewise.
6531 (struct terminal.mouse_position_hook): Likewise.
6532 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6533 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6534 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6535 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6536 what it was before.
6537 * menu.h, termhooks.h: Include "systime.h", for Time.
6538
8e55734a
PE
6539 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6540 Don't assume that the difference between two unsigned long values
6541 can fit into an integer. At this point, we know button_down_time
6542 <= event->timestamp, so the difference must be nonnegative, so
6543 there's no need to cast the result if double-click-time is
6544 nonnegative, as it should be; check that it's nonnegative, just in
6545 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6546 apart (about 25 days). (Bug#8664)
8e55734a 6547
841f1b75 6548 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6549 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6550
3e26f69c
PE
6551 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6552 that always fit in int. Use a sentinel instead of a counter, to
6553 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6554 * frame.h (struct frame): Use int for menu_bar_items_used
6555 instead of EMACS_INT, since it always fits in int.
3e26f69c 6556
5cc152c0
PE
6557 * menu.c (grow_menu_items): Check for int overflow.
6558
d89eb65e
PE
6559 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6560
5235bd3e
PE
6561 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6562 Before, the code was not consistent. These values cannot exceed
6563 2**31 - 1 so there's no need to make them unsigned.
6564 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6565 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6566 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6567 as modifiers.
6568 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6569
bc827e23
PE
6570 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6571 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6572 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6573 presumably because the widths might not match.
6574
78eb494e
PE
6575 * window.c (size_window): Avoid needless test at loop start.
6576
04f2d78b
CB
65772011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6578
6579 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6580
d2fc7e3d 65812011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6582
6583 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6584
d2fc7e3d 65852011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6586
6587 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6588 `width' to `bar_area_x' and `bar_area_width', respectively.
6589 (x_scroll_run): Take account of fringe background extension.
6590
04f2d78b
CB
6591 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6592 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6593 `bar_area_width', respectively.
6594 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6595 background extension.
6596
79b70037
GM
65972011-05-10 Jim Meyering <meyering@redhat.com>
6598
6599 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6600
2f142cc5
JB
66012011-05-10 Juanma Barranquero <lekktu@gmail.com>
6602
6603 * image.c (Finit_image_library): Return t for built-in image types,
6604 like pbm and xbm. (Bug#8640)
6605
57679c86
AS
66062011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6607
6608 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6609
888c9e86
EZ
66102011-05-07 Eli Zaretskii <eliz@gnu.org>
6611
b0512a1d
EZ
6612 * w32console.c (Fset_screen_color): Doc fix.
6613 (Fget_screen_color): New function.
6614 (syms_of_ntterm): Defsubr it.
6615
7285dc67
EZ
6616 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6617 unlink the temporary file if Fcall_process didn't create it in the
6618 first place.
6619 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6620 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6621 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6622 cue to call_process_cleanup not to close that handle.
6623
4d3fcc8e
BK
66242011-05-07 Ben Key <bkey76@gmail.com>
6625
6626 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6627 one of two shell specific rules, either bootstrap-temacs-CMD or
6628 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6629 to the previous implementation of the bootstrap-temacs rule.
6630 The bootstrap-temacs-CMD rule is similar to the previous
6631 implementation of the bootstrap-temacs rule except that it
6632 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6633 variable.
6634
6635 These changes, along with some changes to nt/configure.bat,
6636 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6637 earlier fix to add support for --cflags and --ldflags options
6638 that include quotes so that it works whether make uses cmd or
6639 sh as the shell.
6640
b4289b64
MA
66412011-05-06 Michael Albinus <michael.albinus@gmx.de>
6642
6643 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6644 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6645 is a constant.
6646 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6647 a string. Handle both cases.
6648 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6649 (Fdbus_register_method): Use Qinvalid_function.
6650
af4c0e28
JB
66512011-05-06 Juanma Barranquero <lekktu@gmail.com>
6652
6653 * makefile.w32-in: Update dependencies.
6654 (LISP_H): Add inttypes.h and stdin.h.
6655 (PROCESS_H): Add unistd.h.
6656
c51453d9
EZ
66572011-05-06 Eli Zaretskii <eliz@gnu.org>
6658
6659 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6660 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6661
8ff0ac3c 66622011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6663
4c4b566b
PE
6664 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6665
aab2b9b5
PE
6666 * term.c (vfatal): Remove stray call to va_end.
6667 It's not needed and the C Standard doesn't allow it here anyway.
6668
c378da0b
PE
6669 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6670 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6671
288b08c7
PE
6672 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6673 bytes.
6674
e3601888
PE
6675 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6676
db6c0e74
PE
6677 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6678
dd5963ea
PE
6679 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6680
88c9450f
PE
6681 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6682
2f9442b8
PE
6683 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6684
c032b5f8
PE
6685 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6686 * charset.c (Fdefine_charset_internal): Don't initialize
6687 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6688 32-bit int (Bug#8600).
a108c10b
PE
6689
6690 * lread.c (read_integer): Be more consistent with string-to-number.
6691 Use string_to_number to do the actual conversion; this avoids
6692 rounding errors and fixes some other screwups. Without this fix,
6693 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6694 (digit_to_number): Move earlier, for benefit of read_integer.
6695 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6696 not a digit in any supported base. (Bug#8602)
a108c10b 6697
ad5f9eea
PE
6698 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6699
aec1708a
PE
6700 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6701 to match comment at start of function. This also removes a
6702 GCC warning about overflow in a 32+64-bit port.
6703
47be4ab5
PE
6704 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6705
371cac43
PE
6706 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6707 Reported by Stefan Monnier in
6708 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6709 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6710 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6711
d01a7826
PE
6712 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6713 (EMACS_UINTPTR): Likewise, with uintptr_t.
6714
7fd47d5c
PE
6715 * lisp.h: Prefer 64-bit EMACS_INT if available.
6716 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6717 on 32-bit hosts that have 64-bit int, so that they can access
6718 large files.
122b0c86
PE
6719 However, temporarily disable this change unless the temporary
6720 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6721
8727937b
PE
6722 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6723
8ac068ac
PE
6724 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6725 This removes an assumption that EMACS_INT and long are the same
6726 width as pointers. The assumption is true for Emacs porting targets
6727 now, but we want to make other targets possible.
6728 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6729 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6730 In the rest of the code, change types of integers that hold casted
6731 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6732 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6733 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6734 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6735 No need to cast type when ORing.
6736 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6737 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6738 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6739 assume EMACS_INT is the same width as char *.
6740 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6741 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6742 Remove no-longer-needed casts.
6743 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6744 (xg_tool_bar_help_callback, xg_make_tool_item):
6745 Use EMACS_INTPTR to hold an integer
6746 that will be cast to void *; this can avoid a GCC warning
6747 if EMACS_INT is not the same width as void *.
6748 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6749 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6750 (current_message_1, set_message_1):
6751 Use a local to convert to proper width without a cast.
6752 * xmenu.c (dialog_selection_callback): Likewise.
6753
ede49d71
PE
6754 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6755 Also, don't assume VALBITS / RAND_BITS is less than 5,
6756 and don't rely on undefined behavior when shifting a 1 left into
6757 the sign bit.
6758 * lisp.h (get_random): Change signature to match.
6759
2f30ecd0
PE
6760 * lread.c (hash_string): Use size_t, not int, for hash computation.
6761 Normally we prefer signed values; but hashing is special, because
6762 it's better to use unsigned division on hash table sizes so that
6763 the remainder is nonnegative. Also, size_t is the natural width
6764 for hashing into memory. The previous code used 'int', which doesn't
6765 retain enough info to hash well into very large tables.
6766 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6767
2a866e7b
PE
6768 * dbusbind.c: Don't possibly lose pointer info when converting.
6769 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6770 Use XPNTR rather than XHASH, so that the high-order bits of
6771 the pointer aren't lost when converting through void *.
6772
51639eac
PE
6773 * eval.c (Fautoload): Don't double-shift a pointer.
6774
92394119
PE
6775 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6776
dbdb9a7c
JB
67772011-05-06 Juanma Barranquero <lekktu@gmail.com>
6778
6779 * gnutls.c (DEF_GNUTLS_FN):
6780 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6781
db7a0b4f
AS
67822011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6783
6784 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6785 marker. (Bug#8610)
6786
cd394be1 67872011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6788
6789 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6790 New version that can reserve upto 2GB of heap space.
6791
f7ff1b0f 67922011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6793
6794 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6795
639c109b
TZ
67962011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6797
6798 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6799 `gnutls_certificate_set_x509_key_file'.
6800
d2127135
JB
68012011-05-05 Juanma Barranquero <lekktu@gmail.com>
6802
6803 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6804 Update dependencies.
6805
e968f4f3
JB
68062011-05-04 Juanma Barranquero <lekktu@gmail.com>
6807
6808 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6809 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6810 Remove unused parameter `fildes'.
6811 * process.c (read_process_output, send_process): Don't pass it.
6812
84d358f0
JB
68132011-05-04 Juanma Barranquero <lekktu@gmail.com>
6814
6815 Fix previous change: the library cache is defined in w32.c.
6816 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6817 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6818
0898ca10
JB
68192011-05-04 Juanma Barranquero <lekktu@gmail.com>
6820
6821 Implement dynamic loading of GnuTLS on Windows.
6822
6823 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6824 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6825 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6826 Declare.
6827
6828 * gnutls.c (Qgnutls_dll): Define.
6829 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6830 (gnutls_*): Declare function pointers.
6831 (init_gnutls_functions): New function to initialize function pointers.
6832 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6833 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6834 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6835 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6836 (emacs_gnutls_write, emacs_gnutls_read)
6837 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6838 (Fgnutls_available_p): New function.
6839 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6840 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6841 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6842
6843 * image.c: Include w32.h.
6844 (Vimage_type_cache): Delete.
6845 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6846 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6847 (w32_delayed_load): Move to w32.c.
6848
6849 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6850
6851 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6852 (w32_delayed_load): Move from image.c. When loading a library, record
6853 its filename in the :loaded-from property of the library id.
6854 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6855 Initialize and staticpro them.
6856 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6857
6858 * process.c: Include lisp.h before w32.h, not after.
6859 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6860 instead of gnutls_record_check_pending.
6861
6862 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6863
ff4de4aa
TZ
68642011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6865
6866 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6867 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6868 as passed in.
6869
abe95abb
JD
68702011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6871
6872 * xterm.c (x_set_frame_alpha): Do not set property on anything
6873 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6874
e16e55d4
JB
68752011-05-02 Juanma Barranquero <lekktu@gmail.com>
6876
6877 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6878
bafcf6a5
JB
68792011-05-02 Juanma Barranquero <lekktu@gmail.com>
6880
6881 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6882 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6883 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6884 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6885 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6886 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6887 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6888 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6889 (Qgnutls_bootprop_callbacks_verify): Make static.
6890
e7a6747f
AS
68912011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6892
19ed11ba
AS
6893 * callproc.c: Indentation fixup.
6894
e7a6747f 6895 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6896 (wait_for_termination, interruptible_wait_for_termination):
6897 Move after wait_for_termination_1.
e7a6747f 6898
1ef14cb4
LMI
68992011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6900
6901 * sysdep.c (interruptible_wait_for_termination): New function
6902 which is like wait_for_termination, but allows keyboard
6903 interruptions.
6904
6905 * callproc.c (Fcall_process): Add (:file "file") as an option for
6906 the STDOUT buffer.
6907 (Fcall_process_region): Ditto.
6908
330d880c
EZ
69092011-04-30 Eli Zaretskii <eliz@gnu.org>
6910
8db90b73
EZ
6911 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6912 rather than `XVECTOR (FOO)->size'.
6913
330d880c
EZ
6914 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6915 inttypes.h, as a gnulib replacement is used if it not available in
6916 system headers.
6917
15cbd324
EZ
69182011-04-21 Eli Zaretskii <eliz@gnu.org>
6919
6920 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6921 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6922 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6923
6924 * coding.c (coding_alloc_by_realloc): Error out if destination
6925 will grow beyond MOST_POSITIVE_FIXNUM.
6926 (decode_coding_emacs_mule): Abort if there isn't enough place in
6927 charbuf for the composition carryover bytes. Reserve an extra
6928 space for up to 2 characters produced in a loop.
6929 (decode_coding_iso_2022): Abort if there isn't enough place in
6930 charbuf for the composition carryover bytes.
6931
69322011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6933
ae940cca
EZ
6934 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6935 aborting when %lld or %lll format is passed.
6936 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6937 %llo or %llx format is passed. (Bug#8545)
6938
03ab8921
EZ
6939 * window.c (window_scroll_line_based): Use a marker instead of
6940 simple variables to record original value of point. (Bug#7952)
6941
afda1437
EZ
6942 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6943 produced by %s or %c overflows available buffer space. (Bug#8545)
6944
f76dee0c
PE
69452011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6946
6947 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6948 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6949
fdc5744d
JB
69502011-04-28 Juanma Barranquero <lekktu@gmail.com>
6951
6952 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6953
638f053a
JB
69542011-04-28 Juanma Barranquero <lekktu@gmail.com>
6955
6956 * keyboard.c (Qdelayed_warnings_hook): Define.
6957 (command_loop_1): Run `delayed-warnings-hook'
6958 if Vdelayed_warnings_list is non-nil.
6959 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6960 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6961
d178f871
EZ
69622011-04-28 Eli Zaretskii <eliz@gnu.org>
6963
6964 * doprnt.c (doprnt): Don't return value smaller than the buffer
6965 size if the message was truncated. (Bug#8545).
6966
b124fd93
JB
69672011-04-28 Juanma Barranquero <lekktu@gmail.com>
6968
6969 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
6970 (Fx_window_property): #if-0 the whole functions, not just the bodies.
6971
e810457d
PE
69722011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6973
6974 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
6975
ea51cceb
JB
69762011-04-27 Juanma Barranquero <lekktu@gmail.com>
6977
6978 * makefile.w32-in: Update dependencies.
6979
94dcfacf
EZ
69802011-04-27 Eli Zaretskii <eliz@gnu.org>
6981
6982 Improve `doprnt' and its usage. (Bug#8545)
6983 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
6984 `format_end'. Remove support for %l as a conversion specifier.
6985 Don't use xrealloc. Improve diagnostics when the %l size modifier
6986 is used. Update the commentary.
6987
6988 * eval.c (verror): Simplify calculation of size_t.
6989
6990 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
6991 messages.
6992
f61f41d7
PE
69932011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
6994
6995 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
6996 change.
6997
96fb4434
PE
69982011-04-27 Paul Eggert <eggert@cs.ucla.edu>
6999
7000 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7001 This makes this file independent of the recent pseudovector change.
7002
671875da 70032011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7004
69e9b5a3
PE
7005 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7006
b5f869a7 7007 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7008 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7009 Remove unused local.
c8926152 7010 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7011
841a1577 7012 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7013 GCC 4.6.0 optimizes based on type-based alias analysis.
7014 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7015 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7016 != &v->size, and therefore "v->size = 1; b->size = 2; return
7017 v->size;" must therefore return 1. This assumption is incorrect
7018 for Emacs, since it type-puns struct Lisp_Vector * with many other
7019 types. To fix this problem, this patch adds a new type struct
f904488f 7020 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7021 and pseudovectors, and helps optimizing compilers not get fooled
7022 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7023 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7024 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7025 the size member.
eab3844f
PE
7026 (XSETPVECTYPE): Rewrite in terms of new macro.
7027 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7028 This is a bit clearer, and further avoids the possibility of
7029 undesirable aliasing.
7030 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7031 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7032 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7033 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7034 (ASIZE): Now uses header.size rather than size.
7035 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7036 to avoid the hassle of writing XVECTOR (foo)->header.size.
7037 (struct vectorlike_header): New type.
eab3844f
PE
7038 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7039 object, to help avoid aliasing.
7040 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7041 (SUBRP): Likewise, since Lisp_Subr is a special case.
7042 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7043 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7044 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7045 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7046 changed to be "header.size" and "header.next".
7047 * buffer.h (struct buffer): Likewise.
7048 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7049 * frame.h (struct frame): Likewise.
7050 * process.h (struct Lisp_Process): Likewise.
7051 * termhooks.h (struct terminal): Likewise.
7052 * window.c (struct save_window_data, struct saved_window): Likewise.
7053 * window.h (struct window): Likewise.
7054 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7055 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7056 * buffer.c (init_buffer_once): Likewise.
7057 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7058 special case.
7059 * process.c (Fformat_network_address): Use local var for size,
7060 for brevity.
7061
0df1eac5
PE
7062 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7063
847ab9d1 7064 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7065 * data.c (atof): Remove decl; no longer used or needed.
7066 (digit_to_number): Move to lread.c.
7067 (Fstring_to_number): Use new string_to_number function, to be
7068 consistent with how the Lisp reader treats infinities and NaNs.
7069 Do not assume that floating-point numbers represent EMACS_INT
7070 without losing information; this is not true on most 64-bit hosts.
7071 Avoid double-rounding errors, by insisting on integers when
7072 parsing non-base-10 numbers, as the documentation specifies.
7073 * lisp.h (string_to_number): New decl, replacing ...
7074 (isfloat_string): Remove.
bc0a5c13 7075 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7076 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7077 appears to have been a coding error. Similarly, do not accept
7078 strings like +-1e0 as floating point numbers. Do not report
7079 overflow for integer overflows unless the base is not 10 which
7080 means we have no simple and reliable way to continue.
7081 Break out the floating-point parsing into a new
7082 function string_to_number, so that Fstring_to_number parses
7083 floating point numbers consistently with the Lisp reader.
04f2d78b 7084 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7085 (E_CHAR, EXP_INT): Remove, replacing with ...
7086 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7087 (string_to_number): New function, replacing isfloat_string.
7088 This function checks for valid syntax and produces the resulting
7089 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7090 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7091 so that overflow for non-base-10 numbers is reported only when
7092 there's no portable and simple way to convert to floating point.
452f4150 7093
67769ffc
PE
7094 * textprop.c (set_text_properties_1): Rewrite for clarity,
7095 and to avoid GCC warning about integer overflow.
7096
c20db43f
PE
7097 * intervals.h (struct interval): Use EMACS_INT for members
7098 where EMACS_UINT might cause problems. See
7099 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7100 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7101 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7102 All uses changed.
37aa2f85
PE
7103 (offset_intervals): Tell GCC not to worry about length overflow
7104 when negating a negative length.
c20db43f 7105
2538aa2f
PE
7106 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7107 (overrun_check_free): Likewise.
7108
f2d3008d
PE
7109 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7110 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7111 word size.
7112
ec8df744
PE
7113 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7114 (gnutls_make_error): Rename local to avoid shadowing.
7115 (gnutls_emacs_global_deinit): ifdef out; not used.
7116 (Fgnutls_boot): Use const for pointer to readonly storage.
7117 Comment out unused local. Fix pointer signedness problems.
7118
640ee02d
PE
7119 * lread.c (openp): Don't stuff size_t into an 'int'.
7120 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7121 about possible signed overflow.
7122
6048fb2a
PE
7123 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7124 (GDK_KEY_g): Don't define if already defined.
7125 (xg_prepare_tooltip): Avoid pointer signedness problem.
7126 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7127
fa3c87e1
PE
7128 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7129 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7130
2172544b
PE
7131 * xfns.c (Fx_window_property): Simplify a bit,
7132 to make a bit faster and to avoid GCC 4.6.0 warning.
7133 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7134
9b821a21
PE
7135 * fns.c (internal_equal): Don't assume size_t fits in int.
7136
3c616cfa
PE
7137 * alloc.c (compact_small_strings): Tighten assertion a little.
7138
c2982e87
PE
7139 Replace pEd with more-general pI, and fix some printf arg casts.
7140 * lisp.h (pI): New macro, generalizing old pEd macro to other
7141 conversion specifiers. For example, use "...%"pI"d..." rather
7142 than "...%"pEd"...".
7143 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7144 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7145 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7146 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7147 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7148 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7149 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7150 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7151 64-bit hosts.
7152 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7153 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7154 * print.c (safe_debug_print, print_object): Likewise.
7155 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7156 to int.
6f04d126
PE
7157 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7158 avoiding the 0 flag, which is not portable.
c2982e87
PE
7159 * process.c (Fmake_network_process): Use pI to avoid cast.
7160 * region-cache.c (pp_cache): Likewise.
7161 * xdisp.c (decode_mode_spec): Likewise.
7162 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7163 behavior on 64-bit hosts with printf arg.
6f04d126 7164 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7165 (x_stop_queuing_selection_requests): Likewise.
7166 (x_get_window_property): Don't truncate byte count to an 'int'
7167 when tracing.
0b432f21 7168
5e073ec7
PE
7169 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7170 here, since it parses constructs like leading '-' and spaces,
7171 which are not wanted; and it overflows with large numbers.
7172 Instead, simply match F[0-9]+, which is what is wanted anyway.
7173
36372bf9
PE
7174 * alloc.c: Remove unportable assumptions about struct layout.
7175 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7176 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7177 (allocate_vectorlike, make_pure_vector): Use the new macros,
7178 plus offsetof, to remove unportable assumptions about struct layout.
7179 These assumptions hold on all porting targets that I know of, but
7180 they are not guaranteed, they're easy to remove, and removing them
7181 makes further changes easier.
7182
0b432f21
PE
7183 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7184 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7185 (string_overrun_cookie): Now const. Use initializers that
7186 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7187 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7188 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7189 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7190 multiple of sizeof (EMACS_INT); it need not be, if
7191 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7192 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7193
895009e1
JB
71942011-04-26 Juanma Barranquero <lekktu@gmail.com>
7195
7196 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7197
6a7a1b0b
TZ
71982011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7199
7200 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7201 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7202 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7203
841a1577 72042011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7205
7206 * lisp.h (Qdebug): List symbol.
895009e1 7207 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7208 * keyboard.c (debug-on-event): New variable.
7209 (handle_user_signal): Break into debugger when debug-on-event
7210 matches the current signal symbol.
7211
f2d3ba6f
DN
72122011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7213
7214 * alloc.c (check_sblock, check_string_bytes)
7215 (check_string_free_list): Convert to standard C.
7216
42ce4c63
TZ
72172011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7218
7219 * w32.c (emacs_gnutls_push): Fix typo.
7220
825cd63c
EZ
72212011-04-25 Eli Zaretskii <eliz@gnu.org>
7222
fb11d64d
EZ
7223 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7224 "cast to pointer from integer of different size".
7225
825cd63c
EZ
7226 Improve doprnt and its use in verror. (Bug#8545)
7227 * doprnt.c (doprnt): Document the set of format control sequences
7228 supported by the function. Use SAFE_ALLOCA instead of always
7229 using `alloca'.
7230
7231 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7232 is one byte too soon. Don't use xrealloc; instead xfree and
7233 xmalloc anew.
7234
e061a11b
TZ
72352011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7236
7237 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7238 callbacks stage.
7239
7240 * gnutls.c: Renamed global_initialized to
7241 gnutls_global_initialized. Added internals for the
7242 :verify-hostname-error, :verify-error, and :verify-flags
7243 parameters of `gnutls-boot' and documented those parameters in the
7244 docstring. Start callback support.
9173deec
JB
7245 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7246 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7247 on error. Return error code.
e061a11b
TZ
7248 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7249 (emacs_gnutls_read): Likewise.
7250 (Fgnutls_boot): Return handshake error code.
7251 (emacs_gnutls_handle_error): New function.
7252 (wsaerror_to_errno): Likewise.
7253
7254 * w32.h (emacs_gnutls_pull): Add prototype.
7255 (emacs_gnutls_push): Likewise.
7256
7257 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7258 (emacs_gnutls_push): Likewise.
7259
72602011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7261
7262 * process.c (wait_reading_process_output): Check if GnuTLS
7263 buffered some data internally if no FDs are set for TLS
7264 connections.
7265
7266 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7267 (LIBS): Link to USER_LIBS.
7268 ($(BLD)/gnutls.$(0)): New target.
7269
fa6996bc
EZ
72702011-04-24 Eli Zaretskii <eliz@gnu.org>
7271
eb35682e
EZ
7272 * xdisp.c (handle_single_display_spec): Rename the
7273 display_replaced_before_p argument into display_replaced_p, to
7274 make it consistent with the commentary. Fix typos in the
7275 commentary.
7276
e2ad650c
EZ
7277 * textprop.c (syms_of_textprop): Remove dead code.
7278 (copy_text_properties): Delete obsolete commentary about an
7279 interface that was deleted long ago. Fix typos in the description
7280 of arguments.
7281
1b2de274
EZ
7282 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7283 to changes in oldXMenu/XMenu.h from 2011-04-16.
7284 <menu_help_message, prev_menu_help_message>: Constify.
7285 (IT_menu_make_room): menu->help_text is now `const char **';
7286 adjust.
7287
7288 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7289 to changes in oldXMenu/XMenu.h from 2011-04-16.
7290 (struct XMenu): Declare `help_text' `const char **'.
7291
7292 * xfaces.c <Qunspecified>: Make extern again.
7293
7294 * syntax.c: Include sys/types.h before including regex.h, as
7295 required by Posix.
7296
762b15be
EZ
7297 * doc.c (get_doc_string): Improve the format passed to `error'.
7298
7299 * doprnt.c (doprnt): Improve commentary.
7300
7301 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7302
7303 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7304 them with etags.
7305
f1052e5d
EZ
7306 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7307 changes in globals.h immediately force recompilation.
762b15be
EZ
7308 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7309 $(CURDIR)/s/ms-w32.h.
7310 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7311
fa6996bc
EZ
7312 * character.c (Fchar_direction): Function deleted.
7313 (syms_of_character): Don't defsubr it.
7314 <char-direction-table>: Deleted.
7315
e6c3da20
EZ
73162011-04-23 Eli Zaretskii <eliz@gnu.org>
7317
7318 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7319 * doprnt.c: Include limits.h.
7320 (SIZE_MAX): New macro.
04f2d78b
CB
7321 (doprnt): Return a size_t value. 2nd arg is now size_t.
7322 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7323 Improve overflow protection. Support `l' modifier for integer
7324 conversions. Support %l conversion. Don't assume an EMACS_INT
7325 argument for integer conversions and for %c.
7326
7327 * lisp.h (doprnt): Restore prototype.
7328
7329 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7330 $(SRC)/character.h.
7331
7332 * Makefile.in (base_obj): Add back doprnt.o.
7333
7334 * deps.mk (doprnt.o): Add back prerequisites.
7335 (callint.o): Depend on character.h.
7336
7337 * eval.c (internal_lisp_condition_case): Include the handler
7338 representation in the error message.
7339 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7340 when breaking from the loop.
7341
7342 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7343
7344 * callint.c (Fcall_interactively): When displaying error message
7345 about invalid control letter, pass the character's codepoint, not
7346 a pointer to its multibyte form. Improve display of the character
7347 in octal and display also its hex code.
7348
7349 * character.c (char_string): Use %x to display the (unsigned)
7350 codepoint of an invalid character, to avoid displaying a bogus
7351 negative value.
7352
7353 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7354 `error', not SYMBOL_NAME itself.
7355
7356 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7357 character arguments to `error'.
7358
7359 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7360 to `error' in error message about FINAL_CHAR argument. Make sure
7361 FINAL_CHAR is a character, and use %c when it is passed as
7362 argument to `error'.
7363
4ffd0d6b 73642011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7365
7366 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7367
7368 * w32.c: Include <time.h>.
7369 (sys_localtime): New function.
7370
4ffd0d6b 73712011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7372
7373 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7374
4ffd0d6b 7375 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7376
4ffd0d6b 73772011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7378
4ffd0d6b
GM
7379 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7380 zombies (Bug#8467).
aac0c6e3 7381
04c56954
EZ
73822011-04-19 Eli Zaretskii <eliz@gnu.org>
7383
7384 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7385 gl_state.e_property when gl_state.object is Qt.
7386
7387 * insdel.c (make_gap_larger): Remove limitation of buffer size
7388 to <= INT_MAX.
7389
16a43933
CY
73902011-04-18 Chong Yidong <cyd@stupidchicken.com>
7391
7392 * xdisp.c (lookup_glyphless_char_display)
7393 (produce_glyphless_glyph): Handle cons cell entry in
7394 glyphless-char-display.
7395 (Vglyphless_char_display): Document it.
7396
7397 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7398 glyphless-char-display.
7399
4581706e
CY
74002011-04-17 Chong Yidong <cyd@stupidchicken.com>
7401
7402 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7403
7404 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7405
7406 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7407 definition for no-X builds.
7408
4887c6e2 74092011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7410
fd35b6f9
PE
7411 Static checks with GCC 4.6.0 and non-default toolkits.
7412
5c1ccb01
PE
7413 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7414
006c5daa
PE
7415 * process.c (keyboard_bit_set): Define only if SIGIO.
7416 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7417 (send_process): Repair possible setjmp clobbering.
7418
efc736d3
PE
7419 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7420
4e2fe2e6
PE
7421 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7422
f97334a2
PE
7423 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7424
4e75f29d
PE
7425 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7426 Define only if needed.
7427
90efadd1
PE
7428 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7429 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7430 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7431
3c647824
PE
7432 * dispextern.h (struct redisplay_interface): Rename param
7433 to avoid shadowing.
e264f262 7434 * termhooks.h (struct terminal): Likewise.
761383f4 7435 * xterm.c (xembed_send_message): Likewise.
3c647824 7436
b58c5c4a
PE
7437 * insdel.c (make_gap_smaller): Define only if
7438 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7439
cad59032
PE
7440 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7441 it.
7442
c339dc2e
PE
7443 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7444 so that we aren't warned about unused symbols.
7445
91a3e27b
PE
7446 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7447
399c71d3 7448 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7449
8ffc96f5
PE
7450 * xfns.c (x_real_positions): Mark locals as initialized.
7451
eef9bc79
PE
7452 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7453
098db9dd
PE
7454 * xterm.c: Fix problems found by static analysis with other toolkits.
7455 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7456 (x_dispatch_event): Declare static if USE_GTK, and
7457 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7458 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7459 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7460 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7461 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7462
eb18f6cc
PE
7463 * xmenu.c (menu_help_callback): Pointer type fixes.
7464 Use const pointers when pointing at readonly data. Avoid pointer
7465 signedness clashes.
7466 (FALSE): Remove unused macro.
7467 (update_frame_menubar): Remove unused decl.
7468
1fe72bf8
PE
7469 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7470
60d9e1db
PE
7471 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7472 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7473 (single_menu_item): Rename local to avoid shadowing.
7474
39261c26
PE
7475 * keyboard.c (make_lispy_event): Remove unused local var.
7476
018c5e19
PE
7477 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7478 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7479
63d2b86e
PE
7480 * bitmaps: Change bitmaps from unsigned char back to the X11
7481 compatible char. Avoid the old compiler warnings about
7482 out-of-range initializers by using, for example, '\xab' rather
7483 than 0xab.
7484
aefd87e1
PE
7485 * xgselect.c (xgselect_initialize): Check vs interface
7486 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7487
bf501fb9
PE
7488 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7489
e9829fdf
PE
7490 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7491 to read-only memory.
7492
1086c095
PE
7493 * fns.c (vector): Remove; this old hack is no longer needed.
7494
2baccd04 7495 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7496 Remove unused var.
dde42981 7497 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7498
72391843 7499 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7500
436c16df 7501 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7502 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7503 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7504
92bb796d 7505 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7506 (x_term_init): Remove local to avoid shadowing.
92bb796d 7507
764430a3 7508 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7509
7510 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7511 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7512
d1dfb56c
EZ
75132011-04-16 Eli Zaretskii <eliz@gnu.org>
7514
c4354cb4
EZ
7515 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7516
d1dfb56c
EZ
7517 Fix regex.c, syntax.c and friends for buffers > 2GB.
7518 * syntax.h (struct gl_state_s): Declare character position members
7519 EMACS_INT.
7520
7521 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7522
04f2d78b
CB
7523 * textprop.c (verify_interval_modification, interval_of):
7524 Declare arguments EMACS_INT.
d1dfb56c
EZ
7525
7526 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7527 EMACS_INT.
7528
7529 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7530
7531 * indent.c (Fvertical_motion): Local variable it_start is now
7532 EMACS_INT.
7533
7534 * regex.c (re_match, re_match_2, re_match_2_internal)
7535 (bcmp_translate, regcomp, regexec, print_double_string)
7536 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7537 (re_compile_pattern, re_exec): Declare arguments and local
7538 variables `size_t' and `ssize_t' and return values `regoff_t', as
7539 appropriate.
7540 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7541 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7542 <compile_stack_type>: `size' and `avail' are now `size_t'.
7543
7544 * regex.h <regoff_t>: Use ssize_t, not int.
7545 (re_search, re_search_2, re_match, re_match_2): Arguments that
7546 specify buffer/string position and length are now ssize_t and
7547 size_t. Return type is regoff_t.
7548
613052cd
BK
75492011-04-16 Ben Key <bkey76@gmail.com>
7550
7551 * nsfont.m: Fixed bugs in ns_get_family and
7552 ns_descriptor_to_entity that were caused by using free to
7553 deallocate memory blocks that were allocated by xmalloc (via
7554 xstrdup). This caused Emacs to crash when compiled with
7555 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7556 --enable-checking=xmallocoverrun). xfree is now used to
7557 deallocate these memory blocks.
7558
4170f62f 75592011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7560
71b41406
PE
7561 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7562
9587a89d
PE
7563 emacs_write: Accept and return EMACS_INT for sizes.
7564 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7565 et seq.
7566 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7567 Accept and return EMACS_INT.
7568 (emacs_gnutls_write): Return the number of bytes written on
7569 partial writes.
7570 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7571 (emacs_read, emacs_write): Remove check for negative size, as the
7572 Emacs source code has been audited now.
9587a89d
PE
7573 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7574 (emacs_read, emacs_write): Use it.
273a5f82
PE
7575 * process.c (send_process): Adjust to the new signatures of
7576 emacs_write and emacs_gnutls_write. Do not attempt to store
7577 a byte offset into an 'int'; it might overflow.
9587a89d 7578 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7579
3e047f51
PE
7580 * sound.c: Don't assume sizes fit in 'int'.
7581 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7582 Return EMACS_INT, not int.
3e047f51 7583 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7584 Accept EMACS_INT, not int.
7585 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7586 record read return values.
7587
cc39a9db
BK
75882011-04-15 Ben Key <bkey76@gmail.com>
7589
c9d0ec6d
JB
7590 * keyboard.c (Qundefined): Don't declare static since it is used
7591 in nsfns.m.
7592 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7593 static since they are used in nsfont.m.
cc39a9db 7594
6c60eb9f
SM
75952011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7596
7597 * process.c (Qprocessp): Don't declare static.
7598 * lisp.h (Qprocessp): Declare again.
7599
7990b61a
JB
76002011-04-15 Juanma Barranquero <lekktu@gmail.com>
7601
7602 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7603
5d4cb038
PE
76042011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7605
8bd7b830 7606 Improve C-level modularity by making more things 'static'.
cd64ea1d 7607
e3b27b31
PE
7608 Don't publish debugger-only interfaces to other modules.
7609 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7610 (verify_bytepos, count_markers): Move decls to the only modules
7611 that need them.
7612 * region-cache.h (pp_cache): Likewise.
7613 * window.h (check_all_windows): Likewise.
7614 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7615
5d4cb038
PE
7616 * sysdep.c (croak): Now static, if
7617 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7618 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7619
7620 * alloc.c (refill_memory_reserve): Now static if
7621 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7622 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7623
e87b6180
PE
7624 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7625 Define only if USE_LUCID.
7626
ac64929e
PE
7627 * xrdb.c (x_customization_string, x_rm_string): Now static.
7628
6f37259d
PE
7629 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7630 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7631
1683e3ab
PE
7632 * xdisp.c (draw_row_with_mouse_face): Now static.
7633 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7634
de9c2632
PE
7635 * window.h (check_all_windows): Mark externally visible.
7636
2b96acb7
PE
7637 * window.c (window_deletion_count): Now static.
7638
7639 * undo.c: Make symbols static if they're not exported.
7640 (last_undo_buffer, last_boundary_position, pending_boundary):
7641 Now static.
7642
50436f33
PE
7643 * textprop.c (interval_insert_behind_hooks): Now static.
7644 (interval_insert_in_front_hooks): Likewise.
7645
64520e5c
PE
7646 * term.c: Make symbols static if they're not exported.
7647 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7648 (max_frame_lines, tty_set_terminal_modes):
7649 (tty_reset_terminal_modes, tty_turn_off_highlight):
7650 (get_tty_terminal): Now static.
7651 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7652 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7653 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7654 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7655 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7656
1fa53021
PE
7657 * sysdep.c: Make symbols static if they're not exported.
7658 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7659 Now static.
7660 (sigprocmask_set, full_mask): Remove; unused.
7661 (wait_debugging): Mark as visible.
7662 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7663 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7664
d4b43b22
PE
7665 * syntax.c (syntax_temp): Define only if !__GNUC__.
7666
b7c513d0
PE
7667 * sound.c (current_sound_device, current_sound): Now static.
7668
989b29ad
PE
7669 * search.c (searchbufs, searchbuf_head): Now static.
7670
13a55a78
PE
7671 * scroll.c (scroll_cost): Remove; unused.
7672 * dispextern.h (scroll_cost): Remove decl.
7673
de68a1fc
PE
7674 * region-cache.h (pp_cache): Mark as externally visible.
7675
40ccffa6
PE
7676 * process.c: Make symbols static if they're not exported.
7677 (process_tick, update_tick, create_process, chan_process):
7678 (Vprocess_alist, proc_buffered_char, datagram_access):
7679 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7680 (deactivate_process): Mark defn as static, as well as decl.
7681 * lisp.h (create_process): Remove decl.
7682 * process.h (chan_process, Vprocess_alist): Remove decls.
7683
ad64fc97
PE
7684 * print.c: Make symbols static if they're not exported.
7685 (print_depth, new_backquote_output, being_printed, print_buffer):
7686 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7687 (print_interval, print_number_index, initial_stderr_stream):
7688 Now static.
7689 * lisp.h (Fprinc): Remove decl.
7690 (debug_output_compilation_hack): Mark as externally visible.
7691
adddb265
PE
7692 * sysdep.c (croak): Move decl from here to syssignal.h.
7693 * syssignal.h (croak): Put it here, so the API can be checked when
7694 'croak' is called from dissociate_if_controlling_tty.
7695
1717ede2
PE
7696 * minibuf.c: Make symbols static if they're not exported.
7697 (minibuf_save_list, choose_minibuf_frame): Now static.
7698 * lisp.h (choose_minibuf_frame): Remove decl.
7699
fa5fb2bc
PE
7700 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7701
1e3890d1
PE
7702 * lread.c: Make symbols static if they're not exported.
7703 (read_objects, initial_obarray, oblookup_last_bucket_number):
7704 Now static.
7705 (make_symbol): Remove; unused.
7706 * lisp.h (initial_obarray, make_symbol): Remove decls.
7707
8a1414fa
PE
7708 * keyboard.c: Make symbols static if they're not exported.
7709 (single_kboard, recent_keys_index, total_keys, recent_keys):
7710 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7711 (this_single_command_key_start, echoing, last_auto_save):
7712 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7713 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7714 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7715 (Vlispy_mouse_stem, double_click_count):
7716 Now static.
7717 (force_auto_save_soon): Define only if SIGDANGER.
7718 (ignore_mouse_drag_p): Now static if
7719 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7720 (print_help): Remove; unused.
7721 (stop_character, last_timer_event): Mark as externally visible.
7722 * keyboard.h (ignore_mouse_drag_p): Declare only if
7723 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7724 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7725 * lisp.h (echoing): Remove decl.
7726 (force_auto_save_soon): Declare only if SIGDANGER.
7727 * xdisp.c (redisplay_window): Simplify code, to make it more
7728 obvious that ignore_mouse_drag_p is not accessed if !defined
7729 USE_GTK && !defined HAVE_NS.
7730
93ea6e8f
PE
7731 * intervals.c: Make symbols static if they're not exported.
7732 (merge_properties_sticky, merge_interval_right, delete_interval):
7733 Now static.
7734 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7735
77382fcc
PE
7736 * insdel.c: Make symbols static if they're not exported.
7737 However, leave prepare_to_modify_buffer alone. It's never
7738 called from outside this function, but that appears to be a bug.
7739 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7740 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7741 (adjust_after_replace_noundo): Remove; unused.
7742 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7743 (signal_before_change): Remove decls.
77382fcc 7744
9306c32e
PE
7745 * indent.c (val_compute_motion, val_vmotion): Now static.
7746
cd44d2eb
PE
7747 * image.c: Make symbols static if they're not exported.
7748 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7749 if USE_GTK.
7750 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7751 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7752
ad9a7a06
PE
7753 * fringe.c (standard_bitmaps): Now static.
7754 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7755
81626931
PE
7756 * frame.c: Make symbols static if they're not exported.
7757 (x_report_frame_params, make_terminal_frame): Now static.
7758 (get_frame_param): Now static, unless HAVE_NS.
7759 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7760 (x_get_resource_string): Remove; not used.
7761 * frame.h (make_terminal_frame, x_report_frame_params):
7762 (x_get_resource_string); Remove decls.
7763 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7764 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7765
239f9db9
PE
7766 * font.c, fontset.c: Make symbols static if they're not exported.
7767 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7768 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7769 * font.c (font_close_object): Now static.
7770 * font.h (font_close_object): Remove.
7771 * fontset.c (FONTSET_OBJLIST): Remove.
7772 (free_realized_fontset) #if-0 the body, which does nothing.
7773 (face_suitable_for_char_p): #if-0, as it's never called.
7774 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7775 * xfaces.c (face_at_string_position):
7776 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7777 since 0 is always ASCII.
7778
dfcf3579
PE
7779 * fns.c (weak_hash_tables): Now static.
7780
5045092b
PE
7781 * fileio.c: Make symbols static if they're not exported.
7782 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7783 (Vwrite_region_annotation_buffers): Now static.
7784
57a96f5c
PE
7785 * eval.c: Make symbols static if they're not exported.
7786 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7787 * lisp.h (backtrace_list): Remove decl.
7788
35f08c38
PE
7789 * emacs.c: Make symbols static if they're not exported.
7790 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7791 (fatal_error_code, fatal_error_signal_hook, standard_args):
7792 Now static.
7793 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7794 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7795 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7796 * lisp.h (fatal_error_signal_hook): Remove decl.
7797 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7798
f44bd759
PE
7799 * editfns.c: Move a (normally-unused) function to its only use.
7800 * editfns.c, lisp.h (get_operating_system_release): Remove.
7801 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7802 worth the hassle of breaking this out.
7803
b532497d
PE
7804 * xterm.c: Make symbols static if they're not exported.
7805 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7806 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7807 (x_destroy_window, x_delete_display):
7808 Now static.
7809 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7810 (x_mouse_leave): Remove; unused.
7811 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7812 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7813 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7814 Remove decls.
7815 (x_mouse_leave): Declare only if WINDOWSNT.
7816 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7817 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7818 USE_X_TOOLKIT.
7819
1675728f
PE
7820 * ftxfont.c: Make symbols static if they're not exported.
7821 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7822 HAVE_FREETYPE.
7823 * font.h (ftxfont_driver): Likewise.
7824
e4cebfca
PE
7825 * xfns.c: Make symbols static if they're not exported.
7826 (x_last_font_name, x_display_info_for_name):
7827 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7828 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7829 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7830 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7831 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7832 (last_show_tip_args): Now static.
7833 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7834 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7835 (x_screen_planes): Remove; unused.
7836 * dispextern.h (x_screen_planes): Remove decl.
7837
5bf46f05
PE
7838 * dispnew.c: Make symbols static if they're not exported.
7839 * dispextern.h (redraw_garbaged_frames, scrolling):
7840 (increment_row_positions): Remove.
7841 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7842 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7843 Now static.
7844 (redraw_garbaged_frames): Remove; unused.
7845
435f4c28
PE
7846 * xfaces.c: Make symbols static if they're not exported.
7847 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7848 Remove decls.
7849 * xterm.h (defined_color): Remove decls.
7850 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7851 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7852 (menu_face_changed_default, defined_color, free_realized_face):
7853 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7854 (ascii_face_of_lisp_face): Remove; unused.
7855
8524aef3
PE
7856 * xdisp.c: Make symbols static if they're not exported.
7857 * dispextern.h (scratch_glyph_row, window_box_edges):
7858 (glyph_to_pixel_coords, set_cursor_from_row):
7859 (get_next_display_element, set_iterator_to_next):
7860 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7861 (show_mouse_face): Remove decls
7862 * frame.h (message_buf_print): Likewise.
7863 * lisp.h (pop_message, set_message, check_point_in_composition):
7864 Likewise.
7865 * xterm.h (set_vertical_scroll_bar): Likewise.
7866 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7867 (message_buf_print, scratch_glyph_row, displayed_buffer):
7868 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7869 (get_next_display_element, show_mouse_face, window_box_edges):
7870 (frame_to_window_pixel_xy, check_point_in_composition):
7871 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7872 (glyph_to_pixel_coords): Remove; unused.
7873
16390cd2
PE
7874 * dired.c (file_name_completion): Now static.
7875
7876 * dbusbind.c (xd_in_read_queued_messages): Now static.
7877
a25f4dfa
PE
7878 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7879 * data.c (circular_list_error): Remove.
7880
14a9c8df
PE
7881 * commands.h (last_point_position, last_point_position_buffer):
7882 (last_point_position_window): Remove decls.
7883 * keyboard.c: Make these variables static.
7884
04f2d78b
CB
7885 * coding.h (coding, code_convert_region, encode_coding_gap):
7886 Remove decls.
74ab6df5
PE
7887 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7888 (iso_code_class, detect_coding, code_convert_region): Now static.
7889 (encode_coding_gap): Remove; unused.
7890
38dfbee1
PE
7891 * chartab.c (chartab_chars, chartab_bits): Now static.
7892
a2cb4e63
PE
7893 * charset.h (charset_iso_8859_1): Remove decl.
7894 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7895 Now static.
7896
127198fd
PE
7897 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7898 * ccl.c (Vccl_program_table): Now static.
7899 (check_ccl_update): Remove; unused.
7900
d85b608f
PE
7901 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7902 * category.h: ... from here.
7903 * category.c (check_category_table, set_category_set): Now static.
7904
31cd66f3
PE
7905 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7906 * lisp.h: Remove these decls.
7907
c358e587
PE
7908 * buffer.c (buffer_count): Remove unused var.
7909
e78aecca
PE
7910 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7911 so that it's not optimized away.
7912 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7913 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7914 exported only to the debugger.
7915
e192d7d3 7916 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7917 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7918
92470028
PE
7919 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7920 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7921 was inaccessible from Lisp.
7922 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7923 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7924
244ed907
PE
7925 alloc.c: Import and export fewer symbols, and remove unused items.
7926 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7927 is defined.
7928 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7929 it's not optimized away by whole-program optimization.
7930 (message_enable_multibyte, free_misc): Remove.
7931 (catchlist, handlerlist, mark_backtrace):
7932 Declare only if BYTE_MARK_STACK.
7933 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7934 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7935 (message_enable_multibyte): Remove decl.
7936 (free_misc, interval_free_list, float_block, float_block_index):
7937 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7938 (cons_free_list, last_marked_index):
7939 Now static.
7940 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7941 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7942 (mark_backtrace): Define only if BYTE_MARK_STACK.
7943 * xdisp.c (message_enable_multibyte): Now static.
7944
61c2b50e 7945 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7946 This makes it easier for human readers (and static analyzers)
7947 to see whether these variables are used from other modules.
7948 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7949 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7950 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7951 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7952 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7953 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7954 * xmenu.c, xselect.c:
7955 Declare Q* vars static if they are not used in other modules.
7956 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7957 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7958 Remove decls of unexported vars.
7959 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7960
95c82688
PE
7961 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7962
16a97296
PE
7963 Make Emacs functions such as Fatom 'static' by default.
7964 This makes it easier for human readers (and static analyzers)
7965 to see whether these functions can be called from other modules.
7966 DEFUN now defines a static function. To make the function external
7967 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
7968 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
7969 (Finit_image_library):
16a97296
PE
7970 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
7971 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
7972 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
7973 Remove decls, since these functions are now static.
7974 (Funintern, Fget_internal_run_time): New decls, since these functions
7975 were already external.
95c82688 7976
16a97296
PE
7977 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
7978 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
7979 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
7980 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
7981 * keyboard.c, keymap.c, lread.c:
7982 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
7983 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
7984 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
7985 Mark functions with DEFUE instead of DEFUN,
7986 if they are used in other modules.
7987 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
7988 decls for now-static functions.
7989 * buffer.h (Fdelete_overlay): Remove decl.
7990 * callproc.c (Fgetenv_internal): Mark as internal.
7991 * composite.c (Fremove_list_of_text_properties): Remove decl.
7992 (Fcomposition_get_gstring): New forward static decl.
7993 * composite.h (Fcomposite_get_gstring): Remove decl.
7994 * dired.c (Ffile_attributes): New forward static decl.
7995 * doc.c (Fdocumntation_property): New forward static decl.
7996 * eval.c (Ffetch_bytecode): New forward static decl.
7997 (Funintern): Remove extern decl; now in .h file where it belongs.
7998 * fileio.c (Fmake_symbolic_link): New forward static decl.
7999 * image.c (Finit_image_library): New forward static decl.
8000 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8001 * intervals.h (Fprevious_property_change):
8002 (Fremove_list_of_text_properties): Remove decls.
8003 * keyboard.c (Fthis_command_keys): Remove decl.
8004 (Fcommand_execute): New forward static decl.
8005 * keymap.c (Flookup_key): New forward static decl.
8006 (Fcopy_keymap): Now static.
8007 * keymap.h (Flookup_key): Remove decl.
8008 * process.c (Fget_process): New forward static decl.
8009 (Fprocess_datagram_address): Mark as internal.
8010 * syntax.c (Fsyntax_table_p): New forward static decl.
8011 (skip_chars): Remove duplicate decl.
8012 * textprop.c (Fprevious_property_change): New forward static decl.
8013 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8014 Now internal.
8015 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8016 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8017
785bbd42
PE
8018 * editfns.c (Fformat): Remove unreachable code.
8019
8b913b57
AS
80202011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8021
8022 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8023 change. (Bug#8496)
8024
a6744a35
EZ
80252011-04-13 Eli Zaretskii <eliz@gnu.org>
8026
8027 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8028 when at ZV. (Bug#8487)
8029
e7974947
AS
80302011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8031
baad03f0
AS
8032 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8033 (Bug#8437)
8034 * keyboard.c (parse_tool_bar_item): Likewise.
8035 * sound.c (sound_cleanup, alsa_close): Likewise.
8036 * termcap.c (tgetent): Likewise.
8037 * xfns.c (x_default_font_parameter): Likewise.
8038 * xsettings.c (read_and_apply_settings): Likewise.
8039
e7974947
AS
8040 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8041 (overrun_check_free): Protoize.
8042
28272684
PE
80432011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8044
8045 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8046 since callers should never pass a negative size.
8047 Change the signature to match that of plain 'read' and 'write'; see
8048 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8049 * lisp.h: Update prototypes of emacs_write and emacs_read.
8050
11997c76
EZ
80512011-04-11 Eli Zaretskii <eliz@gnu.org>
8052
8053 * xdisp.c (redisplay_window): Don't try to determine the character
8054 position of the scroll margin if the window start point w->startp
e896f03c 8055 is outside the buffer's accessible region. (Bug#8468)
11997c76 8056
8a2cbd72
EZ
80572011-04-10 Eli Zaretskii <eliz@gnu.org>
8058
8059 Fix write-region and its subroutines for buffers > 2GB.
8060 * fileio.c (a_write, e_write): Modify declaration of arguments and
8061 local variables to support buffers larger than 2GB.
8062 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8063
8064 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8065 argument, local variables, and return value.
8066
8067 * lisp.h: Update prototypes of emacs_write and emacs_read.
8068
8069 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8070
4073e537 80712011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8072
1ebfdcb6
PE
8073 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8074
b2ded58d
PE
8075 Fix more problems found by GCC 4.6.0's static checks.
8076
7d66342c
PE
8077 * xdisp.c (vmessage): Use a better test for character truncation.
8078
bbf47d44
PE
8079 * charset.c (load_charset_map): <, not <=, for optimization,
8080 and to avoid potential problems with integer overflow.
9248994d 8081 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8082 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8083 * editfns.c (Fformat): Likewise.
1e69125e 8084 * syntax.c (skip_chars): Likewise.
3befa583 8085
e3019616
PE
8086 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8087 This also lets GCC 4.6.0 generate slightly better loop code.
8088
becfa255
PE
8089 * callint.c (Fcall_interactively): <, not <=, for optimization.
8090 (Fcall_interactively): Count the number of arguments produced,
8091 not the number of arguments given. This is simpler and lets GCC
8092 4.6.0 generate slightly better code.
8093
dae0cd48
PE
8094 * ftfont.c: Distingish more carefully between FcChar8 and char.
8095 The previous code passed unsigned char * to a functions like
8096 strlen and xstrcasecmp that expect char *, which does not
8097 conform to the C standard.
8098 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8099 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8100 char * when the C standard requires it.
8101
76032d70
PE
8102 * keyboard.c (read_char): Remove unused var.
8103
eb3f1cc8
PE
8104 * eval.c: Port to Windows vsnprintf (Bug#8435).
8105 Include <limits.h>.
8106 (SIZE_MAX): Define if the headers do not.
8107 (verror): Do not give up if vsnprintf returns a negative count.
8108 Instead, grow the buffer. This ports to Windows vsnprintf, which
8109 does not conform to C99. Problem reported by Eli Zaretskii.
8110 Also, simplify the allocation scheme, by avoiding the need for
8111 calling realloc, and removing the ALLOCATED variable.
8112
70476b54
PE
8113 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8114
12020a9e
PE
8115 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8116 But keep the doprint source code for now, as we might revamp it
8117 and use it again (Bug#8435).
ea6c7ae6
PE
8118 * lisp.h (doprnt): Remove.
8119 * Makefile.in (base_obj): Remove doprnt.o.
8120 * deps.mk (doprnt.o): Remove.
8121
5fdb398c
PE
8122 error: Print 32- and 64-bit integers portably (Bug#8435).
8123 Without this change, on typical 64-bit hosts error ("...%d...", N)
8124 was used to print both 32- and 64-bit integers N, which relied on
8125 undefined behavior.
61bdb816 8126 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8127 * lisp.h (error, verror): Mark as printf-like functions.
8128 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8129 Report overflow in size calculations when allocating printf buffer.
8130 Do not truncate output string at its first null byte.
8131 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8132 Truncate the output at a character boundary, since vsnprintf does not
8133 do that.
8134 * charset.c (check_iso_charset_parameter): Convert internal
8135 character to string before calling 'error', since %c now has the
8136 printf meaning.
8137 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8138 overflow when computing char to be passed to 'error'. Do not
8139 pass Lisp_Object to 'error'; pass the integer instead.
8140 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8141 formatted with plain %d.
8142
b189fa66
PE
8143 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8144
bff87ef0
PE
8145 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8146
7e2cac20
PE
8147 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8148
ce4d90b5
PE
8149 * xterm.c (x_catch_errors): Remove duplicate declaration.
8150
266c9547
PE
8151 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8152
79c49ad2
PE
8153 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8154
368f4090
JM
81552011-04-10 Jim Meyering <meyering@redhat.com>
8156
8157 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8158 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8159 return ssize_t not "int", and use size_t as the buffer length.
8160 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8161 * gnutls.h: Update declarations.
8162 * process.c (read_process_output): Use ssize_t, to match.
8163 (send_process): Likewise.
8164
a32d4040
CY
81652011-04-09 Chong Yidong <cyd@stupidchicken.com>
8166
8167 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8168
8546720e 81692011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8170
04f2d78b
CB
8171 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8172 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8173
8546720e
GM
8174 * xterm.c (handle_one_xevent):
8175 * xmenu.c (create_and_show_popup_menu):
8176 * xselect.c (x_decline_selection_request)
8177 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8178
0a2f5c1a 81792011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8180
8181 Fix some uses of `int' instead of EMACS_INT.
8182 * search.c (string_match_1, fast_string_match)
8183 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8184 (scan_buffer, find_next_newline_no_quit)
8185 (find_before_next_newline, search_command, Freplace_match)
8186 (Fmatch_data): Make some `int' variables be EMACS_INT.
8187
8188 * xdisp.c (display_count_lines): 3rd argument and return value now
8189 EMACS_INT. All callers changed.
8190 (pint2hrstr): Last argument is now EMACS_INT.
8191
8192 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8193 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8194 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8195 (decode_coding_utf_16, decode_coding_emacs_mule)
8196 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8197 (decode_coding_ccl, decode_coding_charset)
8198 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8199 (decode_coding_iso_2022, decode_coding_emacs_mule)
8200 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8201 <char_offset, last_offset>: Declare EMACS_INT.
8202 (encode_coding_utf_8, encode_coding_utf_16)
8203 (encode_coding_emacs_mule, encode_invocation_designation)
8204 (encode_designation_at_bol, encode_coding_iso_2022)
8205 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8206 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8207 Declare EMACS_INT.
8208 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8209 (encode_invocation_designation): Last argument P_NCHARS is now
8210 EMACS_INT.
8211 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8212 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8213
8214 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8215 All users changed.
8216
8217 * ccl.c (Fccl_execute_on_string): Declare some variables
8218 EMACS_INT.
8219
8546720e 82202011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8221
8222 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8223
4e19a977
CS
82242011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8225
8226 * process.c (Fformat_network_address): Doc fix.
8227
87302331
R
82282011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8229
ee7683eb 8230 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8231
cbb59342
CY
82322011-04-08 Chong Yidong <cyd@stupidchicken.com>
8233
8234 * keyboard.c (read_char): Call Lisp function help-form-show,
8235 instead of using internal_with_output_to_temp_buffer.
8236 (Qhelp_form_show): New var.
e0d38eeb 8237 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8238
8239 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8240
8241 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8242
e67a13ab
CY
82432011-04-06 Chong Yidong <cyd@stupidchicken.com>
8244
04f2d78b
CB
8245 * process.c (Flist_processes): Remove to Lisp.
8246 (list_processes_1): Delete.
e67a13ab 8247
973f782d
EZ
82482011-04-06 Eli Zaretskii <eliz@gnu.org>
8249
7c106b1e
EZ
8250 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8251
973f782d
EZ
8252 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8253
41cf7d1a 82542011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8255
ca23cc88
PE
8256 Fix more problems found by GCC 4.6.0's static checks.
8257
f390e2d5
PE
8258 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8259
42eea0d0
PE
8260 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8261
b69769da 8262 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8263
f9541e84
PE
8264 * xdisp.c (vmessage): Mark as a printf-like function.
8265
13841b55
PE
8266 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8267
c136c10f
PE
8268 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8269
5e2d4a30
PE
8270 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8271 printf-like functions.
8272 (tiff_load): Add casts to remove these marks before passing them
8273 to system-supplied API.
8274
583f48b9
PE
8275 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8276
b25d760e
PE
8277 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8278 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8279 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8280 directly, rather than having caller test rule sign. This avoids
8281 some unnecessary tests.
8282 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8283 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8284 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8285
bc7b6697 8286 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8287 (xfont_open): Avoid unnecessary tests.
bc7b6697 8288
27ccc379
PE
8289 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8290
dcd5c89a
PE
8291 * composite.h, composite.c (composition_gstring_put_cache):
8292 Use EMACS_INT, not int, for length.
8293
b13a45c6
PE
8294 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8295 breaking out part of COMPOSITION_DECODE_RULE.
8296 (COMPOSITION_DECODE_RULE): Use it.
8297 * composite.c (get_composition_id): Remove unused local vars,
8298 by using the new macro.
8299
1e792e4d
PE
8300 * textprop.c (set_text_properties_1): Change while to do-while,
8301 since the condition is always true at first.
8302
dc6c6455 8303 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8304 (interval_deletion_adjustment): Return unsigned value.
8305 All uses changed.
dc6c6455 8306
aba7731a
PE
8307 * process.c (list_processes_1, create_pty, read_process_output):
8308 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8309 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8310 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8311 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8312 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8313
fdfc4bf3
PE
8314 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8315
fca8fe46 8316 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8317 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8318
06a0259a 8319 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8320 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8321 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8322
e7b9e80f
PE
8323 * print.c (print_error_message): Avoid int overflow.
8324
56201685
PE
8325 * font.c (font_list_entities): Redo for clarity,
8326 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8327
78834453 8328 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8329 (font_score): Avoid potential overflow in diff calculation.
78834453 8330
0bc0b309 8331 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8332 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8333
e610eaca
PE
8334 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8335
b895abce
PE
8336 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8337 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8338 can always succeed if overflow has undefined behavior.
8339
1f1d9321 8340 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8341 (wordify): Omit three unnecessary tests.
1f1d9321 8342
c59478bc
PE
8343 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8344 All callers changed. This avoids the need for an unused var.
8345
79b73827
PE
8346 * casefiddle.c (casify_region): Remove var that is set but not used.
8347
a4db5dfe
PE
8348 * dired.c (file_name_completion): Remove var that is set but not used.
8349
43aae36e
PE
8350 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8351
2a47c44d 8352 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8353 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8354
a37c69bf
PE
8355 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8356 Check for integer overflow on size calculations.
8357
328ab8e7
PE
8358 * buffer.c (Fprevious_overlay_change): Remove var that is set
8359 but not used.
8360
e5a2a5cb
PE
8361 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8362 Remove vars that are set but not used.
8d84a6eb 8363 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8364 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8365
a60e5f68
PE
8366 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8367
f661cb61 8368 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8369 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8370
f0397f5a
PE
8371 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8372 that are set but not used.
8373
8664db06 8374 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8375 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8376
6abdaa4a
PE
8377 * xselect.c (x_get_local_selection, x_handle_property_notify):
8378 Remove vars that are set but not used.
8379
0ce7538d 8380 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8381 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8382
9ae848fc
PE
8383 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8384 Remove var that is set but not used.
0b918413
PE
8385 (scroll_bar_windows_size): Now size_t, not int.
8386 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8387 Check for overflow.
9ae848fc 8388
a5a62657
PE
8389 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8390 (map_tty_color) [!defined MSDOS]: Likewise.
8391
5c5cdd39
PE
8392 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8393
66ebf983
PE
8394 * coding.c: Remove vars that are set but not used.
8395 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8396 All callers changed.
8397 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8398 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8399 (decode_coding_charset): Remove vars that are set but not used.
8400
1be4d761
PE
8401 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8402 that is set but not used.
8403
47553fa8
PE
8404 * print.c (print_object): Remove var that is set but not used.
8405
1f7196bf 8406 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8407 The gnulib version avoids calling malloc in the usual case,
8408 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8409 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8410 * filelock.c (current_lock_owner): Likewise.
8411 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8412 * sysdep.c: Include allocator.h, careadlinkat.h.
8413 (emacs_no_realloc_allocator): New static constant.
8414 (emacs_readlink): New function.
fdb61804
PE
8415 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8416 ../lib/careadlinkat.h.
d1fdcab7 8417
f84c17c7
SM
84182011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8419
8420 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8421 first non-nil return value).
8422
ef3862ad
JD
84232011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8424
8425 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8426 if not defined (Bug#8403).
8427
376a7006
JB
84282011-04-02 Juanma Barranquero <lekktu@gmail.com>
8429
8430 * xdisp.c (display_count_lines): Remove parameter `start',
8431 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8432 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8433 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8434 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8435 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8436 and thereabouts. All callers changed.
8437 (get_per_char_metric): Remove parameter `f', unused since
8438 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8439
6ca3801d
JM
84402011-04-02 Jim Meyering <meyering@redhat.com>
8441
8442 do not dereference NULL upon failed strdup
8443 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8444 (ns_get_family): Likewise.
8445
d8e2b5ba
JB
84462011-04-02 Juanma Barranquero <lekktu@gmail.com>
8447
8448 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8449
8c74fcbd
JD
84502011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8451
8452 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8453 later (Bug#8403).
8454
7200d79c
SM
84552011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8456
03408648 8457 Add lexical binding.
7200d79c 8458
03408648
SM
8459 * window.c (Ftemp_output_buffer_show): New fun.
8460 (Fsave_window_excursion):
8461 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8462
8463 * lread.c (lisp_file_lexically_bound_p): New function.
8464 (Fload): Bind Qlexical_binding.
8465 (readevalloop): Remove `evalfun' arg.
8466 Bind Qinternal_interpreter_environment.
8467 (Feval_buffer): Bind Qlexical_binding.
8468 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8469 Mark as dynamic.
8470 (syms_of_lread): Declare `lexical-binding'.
8471
8472 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8473
8474 * keyboard.c (eval_dyn): New fun.
8475 (menu_item_eval_property): Use it.
ca105506
SM
8476
8477 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8478
03408648
SM
8479 * fns.c (concat, mapcar1): Accept byte-code-functions.
8480
8481 * eval.c (Fsetq): Handle lexical vars.
8482 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8483 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8484 (FletX, Flet): Obey lexical binding.
8485 (Fcommandp): Handle closures.
8486 (Feval): New `lexical' arg.
8487 (eval_sub): New function extracted from Feval. Use it almost
8488 everywhere where Feval was used. Look up vars in lexical env.
8489 Handle closures.
8490 (Ffunctionp): Move from subr.el.
8491 (Ffuncall): Handle closures.
8492 (apply_lambda): Remove `eval_flags'.
8493 (funcall_lambda): Handle closures and new byte-code-functions.
8494 (Fspecial_variable_p): New function.
8495 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8496 but without exporting it to Lisp.
23aba0ea 8497
23aba0ea 8498 * doc.c (Fdocumentation, store_function_docstring):
03408648 8499 * data.c (Finteractive_form): Handle closures.
23aba0ea 8500
03408648
SM
8501 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8502 interactive spec.
ba83908c 8503
04f2d78b
CB
8504 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8505 New byte-codes.
03408648
SM
8506 (exec_byte_code): New function extracted from Fbyte_code to handle new
8507 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8508
03408648 8509 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8510
03408648 8511 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8512
e2abce01
JB
85132011-03-31 Juanma Barranquero <lekktu@gmail.com>
8514
8515 * xdisp.c (redisplay_internal): Fix prototype.
8516
63696a73 85172011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8518
63696a73 8519 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8520 (try_scrolling): Use it when setting scroll_limit.
8521 Limit scrolling to 100 screen lines.
63696a73
EZ
8522 (redisplay_window): Even when falling back on "recentering",
8523 position point in the window according to scroll-conservatively,
8524 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8525
8526 (try_scrolling): When point is above the window, allow searching
8527 as far as scroll_max, or one screenful, to compute vertical
8528 distance from PT to the scroll margin position. This prevents
8529 try_scrolling from unnecessarily failing when
8530 scroll-conservatively is set to a value slightly larger than the
8531 window height. Clean up the case of PT below the margin at bottom
8532 of window: scroll_max can no longer be INT_MAX. When aggressive
8533 scrolling is in use, don't let point enter the opposite scroll
8534 margin as result of the scroll.
8535 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8536 threshold of 100 lines for never-recentering scrolling.
8537
e4cc2dfc
JB
85382011-03-31 Juanma Barranquero <lekktu@gmail.com>
8539
8540 * dispextern.h (move_it_by_lines):
8541 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8542 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8543 (message_log_check_duplicate): Remove parameters `prev_bol' and
8544 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8545 (redisplay_internal): Remove parameter `preserve_echo_area',
8546 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8547
8548 * indent.c (Fvertical_motion):
8549 * window.c (window_scroll_pixel_based, Frecenter):
8550 Don't pass `need_y_p' to `move_it_by_lines'.
8551
1c470562
SM
85522011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8553
44f230aa
SM
8554 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8555 steal a few bits to be more compact.
8556 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8557 Remove unneeded casts.
8558
1c470562
SM
8559 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8560
888adce9
ZK
85612011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8562
8563 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8564 binding" message (bug#7967).
8565
f838ed7b
PE
85662011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8567
77861b95
PE
8568 Fix more problems found by GCC 4.6.0's static checks.
8569
de6dbc14
PE
8570 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8571 Remove unused local var.
8572
f838ed7b
PE
8573 * editfns.c (Fmessage_box): Remove unused local var.
8574
792c7b2b
PE
8575 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8576 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8577 Omit unused local vars.
c499e557 8578 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8579 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8580 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8581 Omit unused local var.
8582
ba0165e1
PE
8583 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8584 Don't assume string length fits in int.
32ad8845 8585 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8586 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8587
3c59b4c9
PE
8588 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8589 instead of alloca (Bug#8344).
8590
a3eed478 8591 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8592 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8593
eb4d412d
PE
8594 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8595
1658b401
PE
8596 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8597 concerns.
8598
8599 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8600
8601 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8602
9a2c6e05
PE
8603 * keyboard.c (syms_of_keyboard): Use the same style as later
8604 in this function when indexing through an array. This also
8605 works around GCC bug 48267.
8606
03d0a109
PE
8607 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8608
44f730c8
PE
8609 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8610
fe75f926
PE
8611 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8612 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8613
ffa8c828
PE
8614 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8615 This avoids undefined behavior on integer overflow, and is a bit
8616 more convenient anyway since it is compared to a size_t variable.
8617
c5101a77
PE
8618 Variadic C functions now count arguments with size_t, not int.
8619 This avoids an unnecessary limitation on 64-bit machines, which
8620 caused (substring ...) to crash on large vectors (Bug#8344).
8621 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8622 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8623 All variadic functions and their callers changed accordingly.
c5101a77
PE
8624 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8625 * data.c (arith_driver, float_arith_driver): Likewise.
8626 * editfns.c (general_insert_function): Likewise.
8627 * eval.c (struct backtrace.nargs, interactive_p)
8628 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8629 (funcall_lambda, mark_backtrace): Likewise.
8630 * fns.c (concat): Likewise.
8631 * frame.c (x_set_frame_parameters): Likewise.
8632 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8633 0 if not found, not -1. All callers changed.
8634
dd3f25f7
PE
8635 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8636 (stack_copy_size): Now size_t, not int.
8637 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8638
461c2ab9
JB
86392011-03-28 Juanma Barranquero <lekktu@gmail.com>
8640
8641 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8642 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8643 All callers changed.
8644
8645 * lisp.h (multibyte_char_to_unibyte):
8646 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8647 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8648 * character.h (CHAR_TO_BYTE8):
8649 * cmds.c (internal_self_insert):
8650 * editfns.c (general_insert_function):
8651 * keymap.c (push_key_description):
8652 * search.c (Freplace_match):
8653 * xdisp.c (message_dolog, set_message_1): All callers changed.
8654
f6d62986
SM
86552011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8656
8657 * keyboard.c (safe_run_hook_funcall): New function.
8658 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8659 don't set the hook to nil, but remove the offending function instead.
8660 (Qcommand_hook_internal): Remove, unused.
8661 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8662 Vcommand_hook_internal.
8663
8664 * eval.c (enum run_hooks_condition): Remove.
8665 (funcall_nil, funcall_not): New functions.
8666 (run_hook_with_args): Call each function through a `funcall' argument.
8667 Remove `cond' argument, now redundant.
8668 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8669 (Frun_hook_with_args_until_failure): Adjust accordingly.
8670 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8671
1db5b1ad
JB
86722011-03-28 Juanma Barranquero <lekktu@gmail.com>
8673
8674 * dispextern.h (string_buffer_position): Remove declaration.
8675
8676 * print.c (strout): Remove parameter `multibyte', unused since
8677 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8678
8679 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8680 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8681 All callers changed.
8682
8683 * w32.c (_wsa_errlist): Use braces for struct initializers.
8684
8685 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8686 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8687 All callers changed.
8688 (string_buffer_position): Likewise. Also, make static (it's never
8689 used outside xdisp.c).
8690 (cursor_row_p): Remove parameter `w', unused since
8691 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8692 (decode_mode_spec): Remove parameter `precision', introduced during
8693 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8694 All callers changed.
8695
5ffb62aa
JD
86962011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8697
8698 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8699
461c2ab9 87002011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8701
8702 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8703 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8704 (ns_update_auto_hide_menu_bar): New functions.
8705 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8706 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8707 ns_constrain_all_frames.
8708 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8709 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8710
5c380ffb
JD
87112011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8712
8713 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8714
9af30bdf
GM
87152011-03-27 Glenn Morris <rgm@gnu.org>
8716
8717 * syssignal.h: Replace RETSIGTYPE with void.
8718 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8719 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8720 Replace SIGTYPE with void everywhere.
8721 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8722 * s/template.h (SIGTYPE): Remove commented out definition.
8723
e2abce01
JB
87242011-03-26 Eli Zaretskii <eliz@gnu.org>
8725
8726 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8727 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8728
f868cd8a
JB
87292011-03-26 Juanma Barranquero <lekktu@gmail.com>
8730
59eb0929
JB
8731 * w32.c (read_unc_volume): Use parameter `henum', instead of
8732 global variable `wget_enum_handle'.
8733
8734 * keymap.c (describe_vector): Remove parameters `indices' and
8735 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8736 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8737
f868cd8a
JB
8738 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8739
8740 * keyboard.c (timer_check): Remove parameter `do_it_now',
8741 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8742 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8743 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8744
8745 * keyboard.c (read_char):
8746 * w32menu.c (w32_menu_display_help):
8747 * xmenu.c (show_help_event, menu_help_callback):
8748 Adjust calls to `show_help_echo'.
8749
8750 * gtkutil.c (xg_maybe_add_timer):
8751 * keyboard.c (readable_events):
8752 * process.c (wait_reading_process_output):
8753 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8754
8755 * insdel.c (adjust_markers_gap_motion):
8756 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8757 (gap_left, gap_right): Don't call it.
8758
2ecf6fdb
CY
87592011-03-25 Chong Yidong <cyd@stupidchicken.com>
8760
8761 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8762 incurred during fontification.
8763
6b1f9ba4
JB
87642011-03-25 Juanma Barranquero <lekktu@gmail.com>
8765
8766 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8767 (DEFVAR_PER_BUFFER): Don't pass it.
8768
8769 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8770 (scrolling_window): Don't pass it.
8771
0f4a96b5
JB
87722011-03-25 Juanma Barranquero <lekktu@gmail.com>
8773
8774 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8775
8776 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8777 and `suffix'.
8778 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8779 of variables specific to SELinux and computation of `encoded_absname'.
8780
8781 * image.c (XPutPixel): Remove unused variable `height'.
8782
8783 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8784
8785 * unexw32.c (get_section_info): Remove unused variable `section'.
8786
8787 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8788 (system_process_attributes): Remove unused variable `sess'.
8789 (sys_read): Remove unused variable `err'.
8790
8791 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8792 (w32_wnd_proc): Remove unused variable `isdead'.
8793 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8794 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8795 (x_create_tip_frame): Remove unused variable `tem'.
8796
8797 * w32inevt.c (w32_console_read_socket):
8798 Remove unused variable `no_events'.
8799
8800 * w32term.c (x_draw_composite_glyph_string_foreground):
8801 Remove unused variable `width'.
8802
1149507c
JB
88032011-03-24 Juanma Barranquero <lekktu@gmail.com>
8804
8805 * w32term.c (x_set_glyph_string_clipping):
8806 Don't pass uninitialized region to CombineRgn.
8807
9c88f339
JB
88082011-03-23 Juanma Barranquero <lekktu@gmail.com>
8809
8810 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8811 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8812 (Fx_close_connection): Remove unused variable `i'.
8813
8814 * w32font.c (w32font_draw): Return number of glyphs.
8815 (w32font_open_internal): Remove unused variable `i'.
8816 (w32font_driver): Add missing initializer.
8817
8818 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8819 (fill_in_menu): Remove unused variable `items_added'.
8820
8821 * w32term.c (last_mouse_press_frame): Remove static global variable.
8822 (w32_clip_to_row): Remove unused variable `f'.
8823 (x_delete_terminal): Remove unused variable `i'.
8824
8825 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8826 (NOTHING): Remove unused static global variable.
8827 (uniscribe_check_otf): Remove unused variable `table'.
8828 (uniscribe_font_driver): Add missing initializers.
8829
dee091a3
JD
88302011-03-23 Julien Danjou <julien@danjou.info>
8831
8832 * term.c (Fsuspend_tty, Fresume_tty):
8833 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8834 * window.c (temp_output_buffer_show):
8835 * insdel.c (signal_before_change):
8836 * frame.c (Fhandle_switch_frame):
8837 * fileio.c (Fdo_auto_save):
8838 * emacs.c (Fkill_emacs):
8839 * editfns.c (save_excursion_restore):
8840 * cmds.c (internal_self_insert):
8841 * callint.c (Fcall_interactively):
8842 * buffer.c (Fkill_all_local_variables):
8843 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8844 Use Frun_hooks.
0f4a96b5 8845 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8846 unconditionally since it does the check itself.
dee091a3 8847
2c520ab5 88482011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8849
c9c49752
PE
8850 Fix more problems found by GCC 4.5.2's static checks.
8851
8abc3f12
PE
8852 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8853 the first time through the loop, since we know p0 < p1 then.
8854 This also avoids a gcc -Wstrict-overflow warning.
8855
a2d26660
PE
8856 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8857 leading to a memory leak, possible in functions like
8858 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8859 of objects (Bug#8318).
a2d26660 8860
916c72e9
PE
8861 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8862 that could (at least in theory) be that large.
8863
19ab8a18
PE
8864 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8865 This is less likely to overflow, and avoids undefined behavior if
8866 overflow does occur. All callers changed. Use strtoul to scan
8867 for the unsigned long integer.
b7cbbd6f
PE
8868 (pint2hrstr): Simplify and tune code slightly.
8869 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8870
f0641eff
PE
8871 * scroll.c (do_scrolling): Work around GCC bug 48228.
8872 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8873
7f650bb9
PE
8874 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8875 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8876 (validate_x_resource_name): Simplify count usage.
8877 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8878
37dd57d1
PE
8879 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8880 fail (Bug#8306).
81e56e61 8881
699979fc 8882 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8883
401bf9b4
PE
8884 * process.c (Fmake_network_process): Use socklen_t, not int,
8885 where POSIX says socklen_t is required in portable programs.
8886 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8887 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8888 (Fmake_network_process, server_accept_connection):
8889 (wait_reading_process_output, read_process_output):
8890 Likewise.
8891
b93aacde
PE
8892 * process.c: Rename or move locals to avoid shadowing.
8893 (list_processes_1, Fmake_network_process):
8894 (read_process_output_error_handler, exec_sentinel_error_handler):
8895 Rename or move locals.
4dc343ee 8896 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8897 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8898 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8899 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8900 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8901
af8a867c 8902 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8903 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8904 Include tparam.h instead, since it declares them.
af8a867c
PE
8905 * cm.h (PC): Remove extern decl; tparam.h now does this.
8906 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8907 * terminfo.c: Include tparam.h, to check interfaces.
8908 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8909 (tparam): Adjust signature to match interface in tparam.h;
8910 this removes some undefined behavior. Check that outstring and len
8911 are zero, which they always are with Emacs.
8912 * tparam.h (PC, BC, UP): New extern decls.
8913
0248044d 8914 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8915 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8916
8ff096c1 8917 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8918 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8919 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8920 (ftfont_list): Remove unused local.
49eaafba
PE
8921 (get_adstyle_property, ftfont_pattern_entity):
8922 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8923 Rename locals to avoid shadowing.
8ff096c1 8924
e2be39f6
PE
8925 * xfont.c (xfont_list_family): Mark var as initialized.
8926
c9735e30
PE
8927 * xml.c (make_dom): Now static.
8928
8f5201ae
PE
8929 * composite.c (composition_compute_stop_pos): Rename local to
8930 avoid shadowing.
b246f932
PE
8931 (composition_reseat_it): Remove unused locals.
8932 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8933 (composition_update_it): Mark var as initialized.
11b61122
PE
8934 (find_automatic_composition): Mark vars as initialized,
8935 with a FIXME (Bug#8290).
8f5201ae 8936
760fbc2c
PE
8937 character.h: Rename locals to avoid shadowing.
8938 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8939 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8940 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8941 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8942 to avoid shadowing.
8943
ff08eb85
PE
8944 * textprop.c (property_change_between_p): Remove; unused.
8945
fc7bf025
PE
8946 * intervals.c (interval_start_pos): Now static.
8947
235d7abc
PE
8948 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8949
44f230aa
SM
8950 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8951 Rename locals to avoid shadowing.
3e7d6594 8952
50060332
PE
8953 * sound.c (wav_play, au_play, Fplay_sound_internal):
8954 Fix pointer signedness.
d01f234b 8955 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8956 (wav_play): Initialize a variable to 0, to prevent undefined
8957 behavior (Bug#8278).
50060332 8958
c4fc4e30
PE
8959 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8960
918436ed
PE
8961 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8962
c939f91b
PE
8963 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8964 clobbering (Bug#8298).
b9c7f648
PE
8965 * sysdep.c (sys_subshell): Likewise.
8966 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8967
6bd8c144
PE
8968 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
8969 This should get cleaned up, so that child_setup has the
8970 same signature on all platforms.
8971
7710357c 8972 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 8973 (relocate_fd): Rename locals to avoid shadowing.
7710357c 8974
c59da222
CY
89752011-03-22 Chong Yidong <cyd@stupidchicken.com>
8976
8977 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
8978 not to be necessary, and produces flickering.
8979
66b87493
GM
89802011-03-20 Glenn Morris <rgm@gnu.org>
8981
8982 * config.in: Remove file.
8983
45b6f6d5
JB
89842011-03-20 Juanma Barranquero <lekktu@gmail.com>
8985
8986 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
8987 are now in src/globals.h.
8988 (syms_of_minibuf): Remove spurious & from previous change.
8989
cd394be1 89902011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
8991
8992 * minibuf.c (completing-read-function): New variable.
8993 (completing-read-default): Rename from completing-read.
8994 (completing-read): Call completing-read-function.
8995
b14e3e21
CY
89962011-03-19 Juanma Barranquero <lekktu@gmail.com>
8997
8998 * xfaces.c (Fx_load_color_file):
8999 Read color file from absolute filename (bug#8250).
9000
f2b726e6
JB
90012011-03-19 Juanma Barranquero <lekktu@gmail.com>
9002
9003 * makefile.w32-in: Update dependencies.
9004
09f6ff02
EZ
90052011-03-17 Eli Zaretskii <eliz@gnu.org>
9006
9007 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9008
29a6015a
PE
90092011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9010
a3a6c54e
PE
9011 Fix more problems found by GCC 4.5.2's static checks.
9012
b766f867
PE
9013 * process.c (make_serial_process_unwind, send_process_trap):
9014 (sigchld_handler): Now static.
9015
be02381c
PE
9016 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9017 That way, the code declares only the vars that it needs.
9018 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9019 * s/cygwin.h (PTY_ITERATION): Likewise.
9020 * s/darwin.h (PTY_ITERATION): Likewise.
9021 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9022
57048744
PE
9023 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9024 * process.c (allocate_pty): Don't declare stb unless it's needed.
9025
7914961c 9026 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9027 (CONSTANTLIM): Remove; unused.
9028 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9029 Define only if needed.
7914961c 9030
b3967b18
PE
9031 * unexelf.c (unexec): Name an expression,
9032 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9033 Use a different way to cause a compilation error if anyone uses
9034 n rather than nn, a way that does not involve shadowing.
73366a00 9035 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9036
29a6015a
PE
9037 * deps.mk (unexalpha.o): Remove; unused.
9038
43cfc33e 9039 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9040 * unexec.h: New file.
ce701a33
PE
9041 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9042 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9043 Depend on unexec.h.
9044 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9045 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9046 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9047 Change as necessary to match prototype in unexec.h.
ce701a33 9048
01f44d5a
PE
9049 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9050 shadowing.
4f63c6bb 9051 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9052
a6670b0b
PE
9053 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9054 Rename locals to avoid shadowing.
9055
cef2010d 9056 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9057 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9058
d4d7173a
PE
9059 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9060
f08b802a
PE
9061 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9062 warning when compiling print.c.
9063
3ddb0639
PE
9064 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9065 instead of using an uninitialized var.
5ad03b97 9066 (font_sort_entities): Mark var as initialized.
3ddb0639 9067
170a2692
PE
9068 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9069
e663c700
PE
9070 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9071 pointers to constants.
89bc529a 9072 (font_parse_fcname): Remove unused vars.
7b81e2d0 9073 (font_delete_unmatched): Now static.
ea838e10 9074 (font_get_spec): Remove; unused.
13a547c6
PE
9075 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9076 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9077 Rename or move locals to avoid shadowing.
e663c700 9078
2a80c887 9079 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9080 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9081
1384fa33 9082 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9083 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9084
8b2c52e9
PE
9085 * alloc.c (mark_backtrace): Move decl from here ...
9086 * lisp.h: ... to here, so that it can be checked.
9087
475545b5 9088 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9089 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9090 (lisp_indirect_variable): Name an expression,
9091 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9092 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9093
b1349114 9094 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9095 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9096 Use const pointer when appropriate.
b1349114 9097
a2928364
PE
9098 * lisp.h (get_system_name, get_operating_system_release):
9099 Move decls here, to check interfaces.
9100 * process.c (get_operating_system_release): Move decl to lisp.h.
9101 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9102 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9103 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9104 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9105 (Fformat_time_string, Fencode_time, Finsert_char):
9106 (Ftranslate_region_internal, Fformat):
9107 Rename or remove local vars to avoid shadowing.
9710023e 9108 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9109
a415e694
PE
9110 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9111 avoid shadowing.
9112
8ef4622d
PE
9113 * lisp.h (eassert): Check that the argument compiles, even if
9114 ENABLE_CHECKING is not defined.
9115
946f9a5b
PE
9116 * data.c (Findirect_variable): Name an expression, to avoid
9117 gcc -Wbad-function-cast warning.
112396d6 9118 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9119 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9120 (Fmake_variable_buffer_local, Fmake_local_variable):
9121 Mark variables as initialized.
52746918 9122 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9123
e5aab7e7 9124 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9125 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9126 Rename locals to avoid shadowing.
dff45157
PE
9127 (mark_stack): Move local variables into the #ifdef region where
9128 they're used.
7bc26fdb
PE
9129 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9130 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9131 needed otherwise.
9132 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9133 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9134 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9135
e5aab7e7
PE
9136 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9137 avoids undefined behavior in theory.
9138
4da60324
PE
9139 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9140
88043301
PE
9141 Use functions, not macros, for up- and down-casing (Bug#8254).
9142 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9143 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9144 to use the following functions instead of these macros.
9145 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9146 EMACS_INT, since callers assume the returned value fits in int.
9147 (upcase1): Likewise, for UPCASE_TABLE.
9148 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9149 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9150 the race-condition problem in the old DOWNCASE.
88043301 9151
19ed5445
PE
9152 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9153 Rename locals to avoid shadowing.
9154 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9155 (regex_compile, re_search_2, re_match_2_internal):
9156 Remove unused local vars.
952db0d7
PE
9157 (FREE_VAR): Rewrite so as not to use empty "else",
9158 which gcc can warn about.
da053e48 9159 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9160 (RETALLOC_IF): Define only if needed.
9161 (WORDCHAR_P): Likewise. This one is never needed, but is used
9162 only in a comment talking about a compiler bug, so put inside
9163 the #if 0 of that comment.
9164 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9165 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9166 Remove; unused.
19ed5445 9167
1f3561e4 9168 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9169 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9170 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9171
ded6f8f7
PE
9172 * search.c (simple_search): Remove unused var.
9173
dbd37a95
PE
9174 * dired.c (compile_pattern): Move decl from here ...
9175 * lisp.h: ... to here, so that it can be checked.
9176 (struct re_registers): New forward decl.
9177
7e47afad
PE
9178 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9179
85f24f61
PE
9180 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9181 All uses changed.
9182 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9183 Rename locals to avoid shadowing.
5671df8f 9184 (Fvertical_motion): Mark locals as initialized.
85f24f61 9185
181aa2be 9186 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9187 (casify_region): Mark local as initialized.
181aa2be 9188
930d429c
PE
9189 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9190
7082eac6
PE
9191 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9192 New macros, so that the caller can use some names other than
9193 gcpro1, gcpro2, etc.
9194 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9195 of the new macros.
9196 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9197 argument, for consistency with GCPRO2_VAR, etc: it is now the
9198 prefix of the variable, not the variable itself. All uses
9199 changed.
38b2c076
PE
9200 * dired.c (directory_files_internal, file_name_completion):
9201 Rename locals to avoid shadowing.
9202
15206ed9
PE
9203 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9204 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9205 dired.c's scmp function, had undefined behavior.
9206 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9207 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9208 * buffer.h: ... to here, because these macros use current_buffer,
9209 and the new implementation with inline functions needs to have
9210 current_buffer in scope now, rather than later when the macros
9211 are used.
9212 (downcase, upcase1): New static inline functions.
9213 (DOWNCASE, UPCASE1): Reimplement using these functions.
9214 This avoids undefined behavior in expressions like
9215 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9216 from race conditions in accessing the global variables
9217 case_temp1 and case_temp2.
9218 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9219 * lisp.h (case_temp1, case_temp2): Remove their decls.
9220 * character.h (ASCII_CHAR_P): Move from here ...
9221 * lisp.h: ... to here, so that the inline functions mentioned
9222 above can use them.
9223
4a6bea26
PE
9224 * dired.c (directory_files_internal_unwind): Now static.
9225
f14b7e14
PE
9226 * fileio.c (file_name_as_directory, directory_file_name):
9227 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9228 Now static.
2893f146
PE
9229 (file_name_as_directory): Use const pointers when appropriate.
9230 (Fexpand_file_name): Likewise. In particular, newdir might
9231 point at constant storage, so make it a const pointer.
fd4ead52 9232 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9233 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9234 signedness issues.
f839df0c
PE
9235 (Fset_file_times, Finsert_file_contents, auto_save_error):
9236 Rename locals to avoid shadowing.
f14b7e14 9237
5716756e 9238 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9239 (Ftry_completion, Fall_completions): Rename or remove locals
9240 to avoid shadowing.
5716756e 9241
b4c3046a
PE
9242 * marker.c (bytepos_to_charpos): Remove; unused.
9243
b45db522
PE
9244 * lisp.h (verify_bytepos, count_markers): New decls,
9245 so that gcc does not warn that these functions aren't declared.
9246
85876d07
PE
9247 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9248 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9249 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9250 (copy_text): Remove unused local var.
85876d07 9251
03d78a21 9252 * filelock.c (within_one_second): Now static.
b3dd38ab 9253 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9254
5df8f01b
PE
9255 * buffer.c (fix_overlays_before): Mark locals as initialized.
9256 (fix_start_end_in_overlays): Likewise. This function should be
9257 simplified by using pointers-to-pointers, but that's a different
9258 matter.
b1d876f1 9259 (switch_to_buffer_1): Now static.
8f54f30a
PE
9260 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9261 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9262
a70072c9 9263 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9264 Fix pointer signedness issue.
edced198
PE
9265 (sys_subshell): Mark local as volatile if checking for lint,
9266 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9267 (MAXPATHLEN): Define only if needed.
a70072c9 9268
a0977c44
PE
9269 * process.c (serial_open, serial_configure): Move decls from here ...
9270 * systty.h: ... to here, so that they can be checked.
9271
a884fdcc
PE
9272 * fns.c (get_random, seed_random): Move extern decls from here ...
9273 * lisp.h: ... to here, so that they can be checked.
9274
604efe86 9275 * sysdep.c (reset_io): Now static.
b8950c94 9276 (wait_for_termination_signal): Remove; unused.
604efe86 9277
38fc62d9
PE
9278 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9279 (copy_keymap_item, append_key, push_text_char_description):
9280 Now static.
1004a21a 9281 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9282 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9283 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9284 (describe_map_tree):
9285 Rename locals to avoid shadowing.
38fc62d9 9286
2f2650da
PE
9287 * keyboard.c: Declare functions static if they are not used elsewhere.
9288 (echo_char, echo_dash, cmd_error, top_level_2):
9289 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9290 (read_char, kbd_buffer_get_event, make_lispy_position):
9291 (make_lispy_event, make_lispy_movement, apply_modifiers):
9292 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9293 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9294 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9295 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9296 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9297
a053e86c 9298 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9299 (mark_kboards): Move decl here ...
9300 * alloc.c (mark_kboards): ... from here.
a053e86c 9301
4752793e
PE
9302 * lisp.h (force_auto_save_soon): New decl.
9303
74f10ca7 9304 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9305 (DEFINE_DUMMY_FUNCTION): New macro.
9306 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9307 Use it.
c03cd23f
PE
9308 (main): Add casts to avoid warnings
9309 if GCC considers string literals to be constants.
74f10ca7 9310
022e70d4
PE
9311 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9312
59d6fe83
PE
9313 * dbusbind.c: Pointer signedness fixes.
9314 (xd_signature, xd_append_arg, xd_initialize):
9315 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9316 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9317 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9318 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9319
78320123
PE
9320 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9321 if GCC considers string literals to be constants.
49cebcca 9322 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9323
35ac2a97
SM
93242011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9325
fb103ca9
SM
9326 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9327 (print_preprocess, print_object): New macro to fix last change.
9328
35ac2a97
SM
9329 * print.c (print_preprocess): Don't forget font objects.
9330
62973b41
JB
93312011-03-16 Juanma Barranquero <lekktu@gmail.com>
9332
9333 * emacs.c (USAGE3): Doc fixes.
9334
0e48bb22
AS
93352011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9336
9337 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9338 structure.
9339
7684e57b
JB
93402011-03-14 Juanma Barranquero <lekktu@gmail.com>
9341
9342 * lisp.h (VWindow_system, Qfile_name_history):
9343 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9344 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9345 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9346
9347 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9348 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9349
9350 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9351 * w32console.c (detect_input_pending, read_input_pending)
9352 (encode_terminal_code):
9353 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9354 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9355 (w32_system_caret_y, Qfile_name_history):
9356 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9357 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9358 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9359 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9360 * w32proc.c (Qlocal, report_file_error):
9361 * w32term.c (Vwindow_system, updating_frame):
9362 * w32uniscribe.c (initialized, uniscribe_font_driver):
9363 Remove unneeded extern declarations.
9364
2aa46d6c
CY
93652011-03-14 Chong Yidong <cyd@stupidchicken.com>
9366
c96bbc66 9367 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9368
cffc6f3b
CY
93692011-03-13 Chong Yidong <cyd@stupidchicken.com>
9370
9371 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9372 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9373 These macros can no longer be used for assignment.
9374
44f230aa
SM
9375 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9376 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9377 (record_buffer_markers, fetch_buffer_markers): New functions for
9378 recording and fetching special buffer markers.
9379 (set_buffer_internal_1, set_buffer_temp): Use them.
9380
9381 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9382
9383 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9384
9385 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9386 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9387
9388 * xdisp.c (hscroll_window_tree):
9389 (reconsider_clip_changes): Use PT instead of BUF_PT.
9390
d251f04b
EZ
93912011-03-13 Eli Zaretskii <eliz@gnu.org>
9392
9393 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9394 $(EMACS_ROOT)/lib/intprops.h.
9395
f0c77cd1
PE
93962011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9397
3eca4629
PE
9398 Fix more problems found by GCC 4.5.2's static checks.
9399
7c86ee98
PE
9400 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9401 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9402 (xg_free_frame_widgets): Make it clear that a local variable is
9403 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9404 (gdk_window_get_screen): Make it clear that this macro is needed
9405 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9406 (int_gtk_range_get_value): New function, which avoids a diagnostic
9407 from gcc -Wbad-function-cast.
9408 (xg_set_toolkit_scroll_bar_thumb): Use it.
9409 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9410 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9411 (get_utf8_string, xg_get_file_with_chooser):
9412 Rename locals to avoid shadowing.
9413 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9414
41729b81
PE
9415 * xgselect.c (xg_select): Remove unused var.
9416
f0c77cd1
PE
9417 * image.c (four_corners_best): Mark locals as initialized.
9418 (gif_load): Initialize transparent_p to zero (Bug#8238).
9419 Mark another local as initialized.
ec6cf4c6 9420 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9421
ce0ad53d 9422 * image.c (clear_image_cache): Now static.
d5d5a617 9423 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9424 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9425 (x_edge_detection): Remove unnecessary cast that
9426 gcc -Wbad-function-cast diagnoses.
2037898d 9427 (gif_load): Fix pointer signedness.
6ae141d6
PE
9428 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9429 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9430
33383987 94312011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9432
d32df629
PE
9433 Improve quality of tests for time stamp overflow.
9434 For example, without this patch (encode-time 0 0 0 1 1
9435 1152921504606846976) returns the obviously-bogus value (-948597
9436 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9437 reports time overflow. See
9438 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9439 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9440 * editfns.c: Include limits.h and intprops.h.
9441 (TIME_T_MIN, TIME_T_MAX): New macros.
9442 (time_overflow): Move earlier, to before first use.
9443 (hi_time, lo_time): New functions, for an accurate test for
9444 out-of-range times.
9445 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9446 (Fget_internal_run_time): Don't assume time_t fits in int.
9447 (make_time): Use list2 instead of Fcons twice.
9448 (Fdecode_time): More accurate test for out-of-range times.
9449 (check_tm_member): New function.
9450 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9451 (lisp_time_argument): Don't rely on undefined left-shift and
9452 right-shift behavior when checking for time stamp overflow.
8be6f318 9453
fe31d94c
PE
9454 * editfns.c (time_overflow): New function, refactoring common code.
9455 (Fformat_time_string, Fdecode_time, Fencode_time):
9456 (Fcurrent_time_string): Use it.
9457
8be6f318
PE
9458 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9459 * dired.c (make_time): Move to ...
9460 * editfns.c (make_time): ... here.
9461 * systime.h: Note the move.
9462
09d9db2c 94632011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9464
126bc0dc
YM
9465 * fringe.c (update_window_fringes): Remove unused variables.
9466
c47cbdfd
YM
9467 * unexmacosx.c (copy_data_segment): Also copy __got section.
9468 (Bug#8223)
9469
7ac80be9
EZ
94702011-03-12 Eli Zaretskii <eliz@gnu.org>
9471
c96bbc66 9472 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9473 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9474 Constify `char *' arguments and their references according to
9475 prototypes in tparam.h.
9476
ecb0f94d 9477 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9478
7ac80be9
EZ
9479 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9480 Adapt all references accordingly.
9481
9482 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9483
ef1fd07e
TT
94842011-03-11 Tom Tromey <tromey@redhat.com>
9485
9486 * buffer.c (syms_of_buffer): Remove obsolete comment.
9487
7ef4b50c
EZ
94882011-03-11 Eli Zaretskii <eliz@gnu.org>
9489
9490 * termhooks.h (encode_terminal_code): Declare prototype.
9491
9492 * msdos.c (encode_terminal_code): Don't declare prototype.
9493
9494 * term.c (encode_terminal_code): Now external again, used by
9495 w32console.c and msdos.c.
9496
44f230aa
SM
9497 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9498 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9499
4b1ec863 95002011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9501
1714f52b 9502 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9503
4b1ec863
PE
9504 * fringe.c (update_window_fringes): Mark locals as initialized
9505 (Bug#8227).
9506 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9507
524c7aa6
PE
9508 * alloc.c (mark_fringe_data): Move decl from here ...
9509 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9510 to check its interface.
9511 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9512
a5c0af81 9513 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9514 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9515 (fontset_font): Mark local as initialized.
a9a06e0b 9516 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9517
b4716021
PE
9518 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9519
811e9bac 9520 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9521 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9522 (x_own_selection, Fx_disown_selection_internal): Rename locals
9523 to avoid shadowing.
9524 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9525
7e3ab302
PE
9526 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9527 so that the caller can use some name other than gcpro1.
9528 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9529 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9530 (Fx_backspace_delete_keys_p):
9531 Use them to avoid shadowing, and rename vars to avoid shadowing.
9532 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9533 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9534 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9535 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9536 Remove unused locals.
7e3ab302
PE
9537 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9538 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9539 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9540 macros.
f78faa98 9541
e2b13473
PE
9542 * xterm.h (x_mouse_leave): New decl.
9543
77f23912
PE
9544 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9545 Remove unused functions.
cdf4ba58
PE
9546 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9547 (x_calc_absolute_position): Now static.
7411c686 9548 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9549 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9550 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9551 unless they are used.
38d0b34a
PE
9552 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9553 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9554 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9555 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9556 (x_error_catcher, x_connection_closed, x_error_handler):
9557 (x_error_quitter, xembed_send_message, x_iconify_frame):
9558 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9559 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9560 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9561
44f230aa
SM
9562 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9563 Rename or move locals to avoid shadowing.
6b463e58 9564 (tty_defined_color, merge_face_heights): Now static.
5967d051 9565 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9566 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9567 does not deduce is never used uninitialized.
73719eba
PE
9568 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9569 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9570
426994c3 9571 * terminal.c (store_terminal_param): Now static.
5489860b 9572
032f1620 9573 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9574 (set_frame_menubar): Remove unused local.
d4323972 9575 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9576 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9577 since they might point to immutable storage.
281585b0
PE
9578 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9579 since it's unused otherwise.
032f1620 9580
367c19e5 9581 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9582 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9583 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9584 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9585 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9586 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9587 does not deduce are never used uninitialized.
70739cbe 9588
07b48fa9
PE
9589 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9590
8868a238 9591 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9592 * window.c (window_loop, size_window):
9593 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9594
7e5cf297 9595 * window.c (display_buffer): Now static.
d6550a9f
PE
9596 (size_window): Mark variables that gcc -Wuninitialized
9597 does not deduce are never used uninitialized.
a586633d
PE
9598 * window.h (check_all_windows): New decl, to forestall
9599 gcc -Wmissing-prototypes diagnostic.
5b555da1 9600 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9601
f6095868
PE
9602 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9603 shadowing.
9604 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9605 Include <limits.h>.
9606 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9607 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9608 (load_charset_map): Mark variables that gcc -Wuninitialized
9609 does not deduce are never used uninitialized.
53df7c11 9610 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9611
f38b440c
PE
9612 * coding.c (coding_set_source, coding_set_destination):
9613 Use "else { /* comment */ }" rather than "else /* comment */;"
9614 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9615 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9616 a block, when the outer 'i' will do.
9617 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9618 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9619 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9620 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9621 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9622 Rename locals to avoid shadowing.
9623 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9624 * coding.c (emacs_mule_char, encode_invocation_designation):
9625 Now static, since they're not used elsewhere.
413bb2db 9626 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9627 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9628 (decode_coding_emacs_mule): Mark variables that gcc
9629 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9630 (detect_coding_iso_2022): Initialize a local variable that might
9631 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9632 this initialization is needed. (Bug#8211)
5f58e762
PE
9633 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9634 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9635 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9636 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9637 Remove unused macros.
f38b440c 9638
232b38b9 9639 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9640 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9641 * character.c (string_count_byte8): Likewise.
232b38b9 9642
fb90da1b
PE
9643 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9644 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9645
fb93dbc2
PE
9646 * chartab.c (copy_sub_char_table): Now static, since it's not used
9647 elsewhere.
5c156ace
PE
9648 (sub_char_table_ref_and_range, char_table_ref_and_range):
9649 Rename locals to avoid shadowing.
bbcd0949 9650 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9651
7d3b3862 9652 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9653 (BIDI_BOB): Remove unused macro.
7d3b3862 9654
6be7d3da
PE
9655 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9656 deduce are never used uninitialized.
c2ed9c8b 9657 * term.c (encode_terminal_code): Likewise.
6be7d3da 9658
75f8807f 9659 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9660
50938595
PE
9661 * tparam.h: New file.
9662 * term.c, tparam.h: Include it.
9663 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9664 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9665 Move these decls to tparam.h, and make them agree with what
9666 is actually in tparam.c. The previous trick of using incompatible
9667 decls in different modules does not conform to the C standard.
9668 All callers of tparam changed to use tparam's actual API.
9669 * tparam.c (tparam1, tparam, tgoto):
9670 Use const pointers where appropriate.
9671
fbceeba2
PE
9672 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9673 * cm.h (struct cm): Likewise.
9674 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9675 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9676 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9677 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9678 (turn_on_face, init_tty): Likewise.
9679 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9680
7f3f1250
PE
9681 * term.c (term_mouse_position): Rename local to avoid shadowing.
9682
e6ca6543
PE
9683 * alloc.c (mark_ttys): Move decl from here ...
9684 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9685
c40f8d15
AS
96862011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9687
9688 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9689
cfe0661d
JB
96902011-03-09 Juanma Barranquero <lekktu@gmail.com>
9691
9692 * search.c (compile_pattern_1): Remove argument regp, unused since
9693 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9694 (compile_pattern): Don't pass it.
9695
0afb4571
J
96962011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9697
9698 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9699 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9700 for ! HAVE_GTK3.
9701 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9702
9703 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9704
9705 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9706 gdk_window_get_screen, gdk_window_get_geometry,
9707 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9708 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9709 (xg_get_pixbuf_from_pixmap): New function.
9710 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9711 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9712 Call xg_get_pixbuf_from_pixmap instead of
9713 gdk_pixbuf_get_from_drawable.
9714 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9715 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9716 (xg_check_special_colors): Use GtkStyleContext and its functions
9717 for HAVE_GTK3.
9718 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9719 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9720 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9721 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9722 Call gtk_widget_get_preferred_size.
0afb4571
J
9723 (xg_frame_resized): gdk_window_get_geometry only takes 5
9724 parameters.
44f230aa
SM
9725 (xg_win_to_widget, xg_event_is_for_menubar):
9726 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9727 (xg_set_widget_bg): New function.
9728 (delete_cb): New function.
895009e1 9729 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9730 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9731 (xg_set_background_color): Call xg_set_widget_bg.
9732 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9733 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9734 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9735 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9736 if ! HAVE_GTK3.
9737 (update_frame_tool_bar): Call gtk_widget_hide.
9738 (xg_initialize): Use GDK_KEY_g.
9739
9740 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9741 if ! HAVE_GTK3
9742 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9743
9744 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9745 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9746 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9747
1c2cc4ef
JB
97482011-03-08 Juanma Barranquero <lekktu@gmail.com>
9749
9750 * w32xfns.c (select_palette): Check success of RealizePalette against
9751 GDI_ERROR, not zero.
9752
33383987 9753See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9754
9755;; Local Variables:
9756;; coding: utf-8
aac0c6e3
MR
9757;; End:
9758
2f097256 9759 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9760
9761 This file is part of GNU Emacs.
9762
9763 GNU Emacs is free software: you can redistribute it and/or modify
9764 it under the terms of the GNU General Public License as published by
9765 the Free Software Foundation, either version 3 of the License, or
9766 (at your option) any later version.
9767
9768 GNU Emacs is distributed in the hope that it will be useful,
9769 but WITHOUT ANY WARRANTY; without even the implied warranty of
9770 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9771 GNU General Public License for more details.
9772
9773 You should have received a copy of the GNU General Public License
9774 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.