Avoid buffer text relocations in calls to STRING_CHAR_* macros.
[bpt/emacs.git] / src / ChangeLog
CommitLineData
291d430f
EZ
12012-05-23 Eli Zaretskii <eliz@gnu.org>
2
3 * charset.c (maybe_unify_char): Inhibit relocation of buffer text
4 for the duration of call to load_charset, to avoid problems with
5 callers of maybe_unify_char that access buffer text through C
6 pointers.
7
8 * ralloc.c (r_alloc_inhibit_buffer_relocation): Increment and
9 decrement the inhibition flag, instead of just setting or
10 resetting it.
11
2f9b9adb
KB
122012-05-24 Ken Brown <kbrown@cornell.edu>
13
14 * callproc.c (Fcall_process): Restore a line that was accidentally
15 commented out in the 2011-02-13 change (bug#11547).
16
52c55cc7
EZ
172012-05-23 Eli Zaretskii <eliz@gnu.org>
18
19 * lisp.h [REL_ALLOC]: Add prototypes for external functions
20 defined on ralloc.c.
21
22 * buffer.c [REL_ALLOC]: Remove prototypes of
23 r_alloc_reset_variable, r_alloc, r_re_alloc, and r_alloc_free,
24 they are now on lisp.h.
25
26 * ralloc.c (r_alloc_inhibit_buffer_relocation): New function.
27
28 * search.c (search_buffer): Use it to inhibit relocation of buffer
29 text while re_search_2 is doing its job, because re_search_2 is
30 passed C pointers to buffer text. (Bug#11519)
31
23415acf
EZ
322012-05-21 Eli Zaretskii <eliz@gnu.org>
33
34 * msdos.c (internal_terminal_init) <Vwindow_system_version>:
35 Update value to 24.
36
44e27368
EZ
372012-05-19 Eli Zaretskii <eliz@gnu.org>
38
39 * xdisp.c (move_it_to): Under MOVE_TO_Y, when restoring iterator
40 state after an additional call to move_it_in_display_line_to, keep
41 the values of it->max_ascent and it->max_descent found for the
42 entire line.
43 (pos_visible_p): Revert the comparison against bottom_y to what it
44 was in revid eliz@gnu.org-20120513182235-4p6386j761ld0nwb.
45 (Bug#11464)
46
ccbf309c
EZ
472012-05-15 Eli Zaretskii <eliz@gnu.org>
48
49 * xdisp.c (pos_visible_p): Fix last change. (Bug#11464)
50
ac268e67
EZ
512012-05-13 Eli Zaretskii <eliz@gnu.org>
52
53 * xdisp.c (handle_stop): Don't call get_overlay_strings_1 if we
54 already have overlays loaded.
55 (handle_single_display_spec): Before returning without displaying
56 fringe bitmap, synchronize the bidi iterator with the main display
57 iterator, by calling iterate_out_of_display_property.
58 (iterate_out_of_display_property): Detect buffer iteration by
59 testing that it->string is a Lisp string.
60 (get_next_display_element): When the current object is exhausted,
61 and there's something on it->stack, call set_iterator_to_next to
62 proceed with what's on the stack, instead of returning zero.
63 (set_iterator_to_next): If called at the end of a Lisp string,
64 proceed to consider_string_end without incrementing string
65 position. Don't increment display vector index past the end of
66 the display vector. (Bug#11417)
c8fb9dc6
EZ
67 (pos_visible_p): Don't report a position visible when move_it_to
68 stopped at the last line of window, which happens to be scanned
69 backwards by the bidi iteration. (Bug#11464)
ac268e67 70
82f9b393
EZ
712012-05-11 Eli Zaretskii <eliz@gnu.org>
72
73 * xdisp.c (handle_single_display_spec): Return 1 for left-margin
74 and right-margin display specs even if the spec is invalid or we
75 are on a TTY, and thus unable to display on the fringes. That's
76 because the text with the property will not be displayed anyway,
77 so we need to signal to the caller that this is a "replacing"
78 display spec. This fixes display when the spec is invalid or we
79 are on a TTY.
80
297834cd
PE
812012-05-09 Paul Eggert <eggert@cs.ucla.edu>
82
83 * unexaix.c (make_hdr): Fix typo in prototype.
84 This bug broke the build on AIX. Problem reported by Gilles Pion.
85
0d887c7d
EZ
862012-05-05 Eli Zaretskii <eliz@gnu.org>
87
88 * w32proc.c (new_child): Force Windows to reserve only 64KB of
89 stack for each reader_thread, instead of defaulting to 8MB
90 determined by the linker. This avoids failures in creating
91 subprocesses on Windows 7, see the discussion in this thread:
92 http://lists.gnu.org/archive/html/emacs-devel/2012-03/msg00119.html.
93
bf98199c
JM
942012-05-02 Jim Meyering <meyering@redhat.com>
95
96 * w32font.c (fill_in_logfont): NUL-terminate a string (Bug#11372).
97
2fa85638
EZ
982012-04-29 Eli Zaretskii <eliz@gnu.org>
99
100 * xdisp.c (pos_visible_p): If already at a newline from the
101 display string before the 'while' loop, don't walk back the glyphs
102 from it3.glyph_row. Solves assertion violation when the display
103 string begins with a newline (egg.el). (Bug#11367)
104
9be2fd9b
CY
1052012-04-24 Chong Yidong <cyd@gnu.org>
106
107 * xselect.c (x_convert_selection): Initialize a pointer (Bug#11315).
108
f0ee99a0
EZ
1092012-04-23 Eli Zaretskii <eliz@gnu.org>
110
111 * xdisp.c (pos_visible_p): If the window start position is beyond
112 ZV, start the display from buffer beginning. Prevents assertion
113 violation in init_iterator when the minibuffer window is scrolled
114 via the scroll bar.
115
116 * window.c (window_scroll_pixel_based): Likewise.
117
9ec7751f
CY
1182012-04-23 Chong Yidong <cyd@gnu.org>
119
120 * keymap.c (where_is_internal): Doc fix (Bug#10872).
121
24c51a09
GM
1222012-04-20 Glenn Morris <rgm@gnu.org>
123
124 * fileio.c (Fcopy_file, Fset_file_selinux_context):
125 Ignore ENOTSUP failures from setfilecon functions. (Bug#11245)
126
73055685
EZ
1272012-04-20 Eli Zaretskii <eliz@gnu.org>
128
129 * dispnew.c (swap_glyph_pointers, copy_row_except_pointers): Don't
130 overrun array limits of glyph row's used[] array. (Bug#11288)
131
f30d612a
CY
1322012-04-20 Chong Yidong <cyd@gnu.org>
133
134 * process.c (wait_reading_process_output): If EIO occurs on a pty,
135 set the status to "failed" and ensure that sentinel is run.
136
016a35df
GM
1372012-04-18 Glenn Morris <rgm@gnu.org>
138
139 * process.c (Fset_process_inherit_coding_system_flag)
140 (Fset_process_query_on_exit_flag): Doc fix (mention return value).
4373fd43 141 (Fmake_network_process, Fmake_serial_process): Doc fix.
016a35df 142
20a68157
EZ
1432012-04-17 Eli Zaretskii <eliz@gnu.org>
144
145 * xdisp.c (string_buffer_position_lim): Limit starting position to
146 BEGV.
147 (set_cursor_from_row): If called for a mode-line or header-line
148 row, return zero immediately.
149 (try_cursor_movement): If inside continuation line, don't back up
150 farther than the first row after the header line, if any. Don't
151 consider the header-line row as "partially visible", even if
152 MATRIX_ROW_PARTIALLY_VISIBLE_P returns non-zero. (Bug#11261)
153
ad3a2b41
AO
1542012-04-13 Atsuo Ohki <ohki@gssm.otsuka.tsukuba.ac.jp> (tiny change)
155
156 * lread.c (lisp_file_lexically_bound_p): Fix hang at ";-*-\n" (bug#11238).
157
e63c261b
CY
1582012-04-10 Teodor Zlatanov <tzz@lifelogs.com>
159
160 * process.c (make_process):
161 * process.h: Add integer `gnutls_handshakes_tried' member to
162 process struct.
163
ad3a2b41
AO
164 * gnutls.h: Add `GNUTLS_EMACS_HANDSHAKES_LIMIT' upper limit.
165 Add convenience `GNUTLS_LOG2i' macro.
e63c261b
CY
166
167 * gnutls.c (gnutls_log_function2i): Convenience log function.
168 (emacs_gnutls_read): Use new log functions,
169 `gnutls_handshakes_tried' process member, and
170 `GNUTLS_EMACS_HANDSHAKES_LIMIT' to limit the number of handshake
171 attempts per process (connection).
172
e53357c4
EZ
1732012-04-09 Eli Zaretskii <eliz@gnu.org>
174
175 * xdisp.c (find_last_unchanged_at_beg_row): Don't consider a row
176 "unchanged" if its end.pos is beyond ZV. (Bug#11199)
177
aff67c82
JD
1782012-04-09 Jan Djärv <jan.h.d@swipnet.se>
179
180 * nsterm.m (constrainFrameRect): Always constrain when there is only
181 one screen (Bug#10962).
182
2f8e16b2
EZ
1832012-04-06 Eli Zaretskii <eliz@gnu.org>
184
185 * buffer.h (FETCH_CHAR, FETCH_MULTIBYTE_CHAR):
186 * character.h (STRING_CHAR, STRING_CHAR_AND_LENGTH): Add comments
187 about subtle differences between FETCH_CHAR* and STRING_CHAR*
188 macros related to unification of CJK characters. For the details,
189 see the discussion following the message here:
190 http://debbugs.gnu.org/cgi/bugreport.cgi?bug=11073#14.
191
3d439cd1
CY
1922012-04-04 Chong Yidong <cyd@gnu.org>
193
194 * keyboard.c (Vdelayed_warnings_list): Doc fix.
195
8bc53d00
EZ
1962012-04-01 Eli Zaretskii <eliz@gnu.org>
197
198 * w32menu.c (simple_dialog_show, add_menu_item): Use SAFE_ALLOCA
199 instead of alloca. (Bug#11138)
200
3b0512a3
AS
2012012-04-01 Andreas Schwab <schwab@linux-m68k.org>
202
203 * w32menu.c (is_simple_dialog): Properly check lisp types.
204 (Bug#11141)
205
8427ddd2
EZ
2062012-03-31 Eli Zaretskii <eliz@gnu.org>
207
979022ef
EZ
208 * xdisp.c (move_it_by_lines): When DVPOS is positive, and the
209 position we get to after a call to move_it_to fails the
210 IS_POS_VALID_AFTER_MOVE_P test, move to the next buffer position
211 only if we wind up in a string from display property. (Bug#11063)
212
a6b1c7cc
EZ
213 * window.c (Fdelete_other_windows_internal): Invalidate the row
214 and column information about mouse highlight, so that redisplay
215 restores it after reallocating the glyph matrices. (Bug#7464)
216
8427ddd2
EZ
217 * xdisp.c (set_cursor_from_row): If `cursor' property on a display
218 string comes from a `display' text property, use the buffer
219 position of that property as if we actually saw that position in
220 the row's glyphs.
697ba24b
EZ
221 (move_it_by_lines): Remove the assertion that
222 "it->current_x == 0 && it->hpos == 0" which can be legitimately
223 violated when there's a before-string at the beginning of a line.
224 (Bug#11063)
8427ddd2 225
65a0a738
EZ
2262012-03-30 Eli Zaretskii <eliz@gnu.org>
227
228 * xdisp.c (append_space_for_newline): If the default face was
229 remapped, use the remapped face for the appended newline.
230 (extend_face_to_end_of_line): Use the remapped default face for
231 extending the face to the end of the line.
232 (display_line): Call extend_face_to_end_of_line when the default
233 face was remapped. (Bug#11068)
234
581355cc
EZ
2352012-03-29 Eli Zaretskii <eliz@gnu.org>
236
237 * s/ms-w32.h: Discourage from defining HAVE_GETCWD.
238
e8fc049f
SM
2392012-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
240
241 * keyboard.c (safe_run_hooks_error): Don't unquote strings.
242
4fb9a543
GM
2432012-03-27 Glenn Morris <rgm@gnu.org>
244
245 * search.c (Fword_search_backward_lax, Fword_search_forward_lax):
246 Doc fixes.
247
679910f1
KH
2482012-03-26 Kenichi Handa <handa@m17n.org>
249
250 * dispextern.h (struct glyph): Fix previous change. Change the
251 bit length of glyphless.ch to 25 (Bug#11082).
252
90d49b7f
CY
2532012-03-26 Chong Yidong <cyd@gnu.org>
254
255 * keyboard.c (Vselection_inhibit_update_commands): New variable.
256 (command_loop_1): Use it; inhibit selection update for
257 handle-select-window too (Bug#8996).
258
f514f6f0
FP
2592012-03-25 Fabrice Popineau <fabrice.popineau@supelec.fr>
260
e8fc049f 261 * w32heap.c (_heap_init, _heap_term): Remove dead MSVC-specific code.
f514f6f0 262
bf43fa51
KH
2632012-03-25 Kenichi Handa <handa@m17n.org>
264
265 * dispextern.h (struct glyph): Change the bit length of
266 glyphless.ch to 22 to make the member glyphless fit in 32 bits.
267
8a0c01dd
EZ
2682012-03-24 Eli Zaretskii <eliz@gnu.org>
269
270 * s/ms-w32.h (tzname): Include time.h before redirecting to
271 _tzname. Fixes the MSVC build. (Bug#9960)
272
7d1c3a76
AS
2732012-03-24 Andreas Schwab <schwab@linux-m68k.org>
274
8ed79523
AS
275 * xdisp.c (produce_glyphless_glyph): Limit length of acronym to 6
276 characters.
277
7d1c3a76
AS
278 * xterm.c (XTread_socket): Only modify handling_signal if
279 !SYNC_INPUT. (Bug#11080)
280
e99a9b8b
EZ
2812012-03-23 Eli Zaretskii <eliz@gnu.org>
282
283 * bidi.c (bidi_fetch_char): Use STRING_CHAR_AND_LENGTH instead of
284 FETCH_MULTIBYTE_CHAR followed by CHAR_BYTES. Prevents crashes
285 when fetching a multibyte character consumes more bytes than
286 CHAR_BYTES returns, due to unification of CJK characters in
287 string_char. (Bug#11073)
288
5063c0e1
TN
2892012-03-23 Troels Nielsen <bn.troels@gmail.com> (tiny change)
290
291 * process.c (wait_reading_process_output): Handle pty disconnect
292 by refraining from sending oneself a SIGCHLD (bug#10933).
293
9f851fbd
CY
2942012-03-22 Chong Yidong <cyd@gnu.org>
295
296 * dispextern.h (struct it): New member string_from_prefix_prop_p.
297
5063c0e1 298 * xdisp.c (push_prefix_prop): Rename from push_display_prop.
9f851fbd
CY
299 Mark string as coming from a prefix property.
300 (handle_face_prop): Use default face for prefix strings (Bug#4281).
301 (pop_it, reseat_1): Save and restore string_from_prefix_prop_p.
302
fb5b8aca
CY
3032012-03-21 Chong Yidong <cyd@gnu.org>
304
305 * xfaces.c (Vface_remapping_alist): Doc fix.
306
62356a1b
EZ
3072012-03-20 Eli Zaretskii <eliz@gnu.org>
308
309 * w32proc.c (Fw32_set_console_codepage)
5063c0e1
TN
310 (Fw32_set_console_output_codepage, Fw32_get_codepage_charset):
311 Doc fixes.
62356a1b 312
025de85b
CY
3132012-03-20 Chong Yidong <cyd@gnu.org>
314
315 * dispnew.c (Fredisplay, Vredisplay_preemption_period): Update doc
316 to reflect default non-nil value of redisplay-dont-pause.
317
4827f94e
KH
3182012-03-19 Kenichi Handa <handa@m17n.org>
319
320 * ftfont.c (ftfont_drive_otf): Mask bits of character code to make
321 it fit in a valid range (Bug#11003).
322
e50a24a2
EZ
3232012-03-18 Eli Zaretskii <eliz@gnu.org>
324
325 * xdisp.c (cursor_row_p): Even if the glyph row ends in a string
326 that is not from display property, accept the row as a "cursor
327 row" if one of the string's character has a non-nil `cursor'
328 property. Fixes cursor positioning when there are newlines in
329 overlay strings, e.g. in icomplete.el. (Bug#11035)
330
9af5ed87
PE
3312012-03-12 Paul Eggert <eggert@cs.ucla.edu>
332
333 * buffer.c (compare_overlays): Don't assume args differ (Bug#6830).
334
d1f55f16
CY
3352012-03-12 Chong Yidong <cyd@gnu.org>
336
337 * eval.c (inhibit_lisp_code): Rename from
338 inhibit_window_configuration_change_hook; move from window.c.
339
340 * xfns.c (unwind_create_frame_1, Fx_create_frame):
341 * window.c (run_window_configuration_change_hook)
342 (syms_of_window): Callers changed.
343
66c5eebd
CY
3442012-03-11 Chong Yidong <cyd@gnu.org>
345
413df973
CY
346 * keymap.c (Fkey_description): Doc fix (Bug#9700).
347
66c5eebd
CY
348 * editfns.c (Fconstrain_to_field): Doc fix (Bug#9452).
349
1de11f56
CY
3502012-03-10 Chong Yidong <cyd@gnu.org>
351
352 * frame.c (other_visible_frames): Don't assume the selected frame
353 is visible (Bug#10955).
354
cae07000
SM
3552012-03-09 Stefan Monnier <monnier@iro.umontreal.ca>
356
357 * buffer.c (compare_overlays): Avoid qsort's instability (bug#6830).
358
89c94350
JD
3592012-03-08 Jan Djärv <jan.h.d@swipnet.se>
360
361 * gtkutil.c (x_wm_set_size_hint): Use one row in call to
362 FRAME_TEXT_LINES_TO_PIXEL_HEIGHT so base_height is greater than
363 zero (Bug#10954).
364
999dd333
GM
3652012-03-03 Glenn Morris <rgm@gnu.org>
366
01a6dcc8 367 * alloc.c (Fgarbage_collect, misc-objects-consed): Doc fixes.
999dd333 368
de0100f2
EZ
3692012-03-02 Eli Zaretskii <eliz@gnu.org>
370
371 * xdisp.c (try_window_reusing_current_matrix): Don't move cursor
372 position past the first glyph_row that ends at ZV. (Bug#10902)
b8456c5c
EZ
373 (redisplay_window, next_element_from_string): Fix typos in
374 comments.
3e441275
EZ
375 (redisplay_window): Pass to move_it_vertically the margin in
376 pixels, not in screen lines.
de0100f2 377
96a72ee9
GM
3782012-03-02 Glenn Morris <rgm@gnu.org>
379
380 * buffer.c (buffer-list-update-hook): Doc fix.
381
312508d7
EZ
3822012-02-29 Eli Zaretskii <eliz@gnu.org>
383
384 * xdisp.c (get_overlay_strings_1): Under bidi redisplay, call
385 push_it before setting up the iterator for the first overlay
386 string, even if we have an empty string loaded.
387 (next_overlay_string): If there's an empty string on the iterator
388 stack, pop the stack. (Bug#10903)
389
27f3c637
PE
3902012-02-25 Paul Eggert <eggert@cs.ucla.edu>
391
392 Generalize fix for crash due to non-contiguous EMACS_INT (Bug#10780).
393 Suggested by Stefan Monnier in
394 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00692.html>.
395 * alloc.c (widen_to_Lisp_Object): New static function.
396 (mark_memory): Also mark Lisp_Objects by fetching pointer words
397 and widening them to Lisp_Objects. This would work even if
398 USE_LSB_TAG is defined and wide integers are used, which might
399 happen in a future version of Emacs.
400
3c9dfce6
CY
4012012-02-25 Chong Yidong <cyd@gnu.org>
402
fa74b241
CY
403 * fileio.c (Ffile_selinux_context, Fset_file_selinux_context):
404 Doc fix.
405
3c9dfce6
CY
406 * xselect.c (Fx_selection_exists_p): Doc fix.
407 (x_clipboard_manager_save_all): Print an informative message
408 before saving to clipboard manager.
409
9486df08
CY
4102012-02-24 Chong Yidong <cyd@gnu.org>
411
412 * keyboard.c (process_special_events): Handle all X selection
413 requests in kbd_buffer, not just the next one (Bug#8869).
414
f01d3321
CY
4152012-02-23 Chong Yidong <cyd@gnu.org>
416
417 * xfns.c (Fx_create_frame): Avoid window-configuration-change-hook
418 call when setting menu-bar-lines and tool-bar-lines parameters.
419 (unwind_create_frame_1): New helper function.
420
421 * window.c (inhibit_window_configuration_change_hook): New var.
422 (run_window_configuration_change_hook): Obey it.
b2e4ca7d 423 (syms_of_window): Initialize it.
f01d3321 424
86b847b6
CY
4252012-02-22 Chong Yidong <cyd@gnu.org>
426
427 * xterm.c (x_draw_image_relief): Add missing type check for
428 Vtool_bar_button_margin (Bug#10743).
429
a59225b1
CY
4302012-02-21 Chong Yidong <cyd@gnu.org>
431
432 * fileio.c (Vfile_name_handler_alist): Doc fix.
433
434 * buffer.c (Fget_file_buffer): Protect against invalid file
435 handler return value.
436
310f5bd4
PE
4372012-02-20 Paul Eggert <eggert@cs.ucla.edu>
438
cb3a28cc
PE
439 * .gdbinit (xreload): Don't assume EMACS_INT fits in 'long'
440 when computing $valmask.
441
310f5bd4
PE
442 Fix crash due to non-contiguous EMACS_INT (Bug#10780).
443 * lisp.h (VALBITS): Move definition up, so that USE_LSB_TAG can use it.
444 (USE_LSB_TAG): Do not define if UINTPTR_MAX >> VALBITS == 0.
445 It's useless in that case, and it can cause problems on hosts
446 that allocate halves of EMACS_INT values separately.
447 Reported by Dan Horák. Diagnosed by Andreas Schwab in
448 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=10780#30>.
449 * mem-limits.h (EXCEEDS_LISP_PTR): Define to 0 on hosts where
450 UINTPTR_MAX >> VALBITS == 0. This is required by the above change;
451 it avoids undefined behavior on hosts where shifting right by more
452 than the word width has undefined behavior.
453
2375c96a
CY
4542012-02-19 Chong Yidong <cyd@gnu.org>
455
456 * fileio.c (Ffile_name_directory, Ffile_name_nondirectory)
457 (Funhandled_file_name_directory, Ffile_name_as_directory)
458 (Fdirectory_file_name, Fexpand_file_name)
459 (Fsubstitute_in_file_name): Protect against invalid file handler
460 return values (Bug#10845).
461
3eb49e71
EZ
4622012-02-18 Eli Zaretskii <eliz@gnu.org>
463
464 * .gdbinit (pitx): Fix incorrect references to fields of the
465 iterator stack.
466
7b926f3f
CY
4672012-02-17 Chong Yidong <cyd@gnu.org>
468
469 * syntax.c (Fscan_lists): Doc fix (Bug#10833).
470
11273115
PE
4712012-02-15 Paul Eggert <eggert@cs.ucla.edu>
472
473 * image.c (MAX_IMAGE_SIZE): Increase from 6.0 to 10.0; see
474 <http://lists.gnu.org/archive/html/emacs-devel/2012-02/msg00540.html>.
475
c3a70e2b
CY
4762012-02-15 Chong Yidong <cyd@gnu.org>
477
478 * eval.c (Fdefvar, Fdefconst): Doc fix; note that the variable is
479 marked as special. Also, starting docstrings with * is obsolete.
480
0ca43699
AS
4812012-02-13 Andreas Schwab <schwab@linux-m68k.org>
482
483 * gnutls.c (emacs_gnutls_write): Fix last change.
484
2e8f3c56
LI
4852012-02-13 Lars Ingebrigtsen <larsi@gnus.org>
486
487 * gnutls.c (emacs_gnutls_write): Set errno appropriately for
488 send_process.
489
af70074f
SM
4902012-02-13 Stefan Monnier <monnier@iro.umontreal.ca>
491
492 * keymap.c (Fsingle_key_description): Handle char ranges.
493
95986d52
CY
4942012-02-12 Chong Yidong <cyd@gnu.org>
495
afd83bd1
CY
496 * xdisp.c (handle_stop): Avoid assigning -1 to it->face_id here,
497 as that creates a dangerous corner case.
498
95986d52
CY
499 * window.c (Fdelete_window_internal): Invalidate the mouse
500 highlight (Bug#9904).
501
bd7da63e
GM
5022012-02-12 Glenn Morris <rgm@gnu.org>
503
504 * xselect.c (Fx_own_selection_internal)
505 (Fx_get_selection_internal, Fx_disown_selection_internal)
506 (Fx_selection_owner_p, Fx_selection_exists_p): Doc fixes.
507 * nsselect.m (Fx_own_selection_internal)
508 (Fx_disown_selection_internal, Fx_selection_exists_p)
509 (Fx_selection_owner_p, Fx_get_selection_internal):
510 Sync docs and argument specs with the xselect.c versions.
511
77abcbc2
LI
5122012-02-11 Lars Ingebrigtsen <larsi@gnus.org>
513
514 * gnutls.c (emacs_gnutls_write): Don't infloop if sendto fails.
515
90b671e2
EZ
5162012-02-11 Eli Zaretskii <eliz@gnu.org>
517
1c0ca0b7
EZ
518 * w32select.c (Fx_selection_exists_p): Sync doc string and
519 argument list with xselect.c. (Bug#10783)
520
521 * w16select.c (Fx_selection_exists_p): Sync doc string and
522 argument list with xselect.c. (Bug#10783)
90b671e2 523
49241268
GM
5242012-02-10 Glenn Morris <rgm@gnu.org>
525
526 * fns.c (Fsecure_hash): Doc fix.
527
f998bbe7 5282012-02-09 Kenichi Handa <handa@m17n.org>
5c1ca13d
KH
529
530 * coding.c (produce_chars): Fix updating of src_end (Bug#10701).
531
0992bd9c
CY
5322012-02-07 Chong Yidong <cyd@gnu.org>
533
534 * buffer.c (Fbuffer_local_variables)
535 (buffer_lisp_local_variables): Handle unbound vars correctly;
536 don't let Qunbound leak into Lisp.
537
af008560
GM
5382012-02-07 Glenn Morris <rgm@gnu.org>
539
dd605cc4
GM
540 * image.c (Fimagemagick_types): Doc fix.
541
af008560
GM
542 * image.c (imagemagick-render-type): Change it from a lisp object
543 to an integer. Move the doc here from the lisp manual.
544 Treat all values not equal to 0 the same.
545
1449fa1d
CY
5462012-02-06 Chong Yidong <cyd@gnu.org>
547
548 * doc.c (store_function_docstring): Avoid applying docstring of
549 alias to base function (Bug#2603).
550
3723ec07
AS
5512012-02-04 Andreas Schwab <schwab@linux-m68k.org>
552
553 * .gdbinit (pp1, pv1): Remove redundant defines.
554 (pr): Use pp.
555
79c1cc1e
CY
5562012-02-04 Chong Yidong <cyd@gnu.org>
557
558 * nsterm.m: Declare a global (Bug#10694).
559
d7f29f8e
EZ
5602012-02-04 Eli Zaretskii <eliz@gnu.org>
561
cae07000
SM
562 * w32.c (get_emacs_configuration_options):
563 Include --enable-checking, if specified, in the return value.
d7f29f8e 564
3b95a6f9
MR
5652012-02-04 Martin Rudalics <rudalics@gmx.at>
566
567 * dispnew.c (change_frame_size_1): Calculate new_frame_total_cols
568 after rounding frame sizes. (Bug#9723)
569
d6fa96a6
EZ
5702012-02-04 Eli Zaretskii <eliz@gnu.org>
571
572 * keyboard.c (adjust_point_for_property): Don't position point
573 before BEGV. (Bug#10696)
574
df0b2940
PE
5752012-02-03 Paul Eggert <eggert@cs.ucla.edu>
576
577 Handle overflow when computing char display width (Bug#9496).
578 * character.c (char_width): Return EMACS_INT, not int.
579 (char_width, c_string_width): Check for overflow when
580 computing the width; this is possible now that individual
581 characters can have unbounded width. Problem introduced
582 by merge from Emacs 23 on 2012-01-19.
583
6bee44d6
MA
5842012-02-02 Michael Albinus <michael.albinus@gmx.de>
585
586 * dbusbind.c (Fdbus_register_method): Mention the return value
587 :ignore in the docstring.
588
44f92739
GM
5892012-02-02 Glenn Morris <rgm@gnu.org>
590
1b9f60cc
GM
591 * callproc.c (Fcall_process, Fcall_process_region): Doc fix.
592
44f92739
GM
593 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
594 Unconditionally set to t. (Bug#10673)
595 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
596 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
597 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Doc fix.
598
c5d3843c
KH
5992012-02-02 Kenichi Handa <handa@m17n.org>
600
601 (x_produce_glyphs): Cancel previous change. If cmp->glyph_len is
602 0, do not call append_composite_glyph.
603
159462d4 6042012-02-02 Kenichi Handa <handa@m17n.org>
d2a51fd7
KH
605
606 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING): Initialize first_s to
607 NULL (Bug#6988).
608 (x_produce_glyphs): If the component of a composition is a null
609 string, set it->pixel_width to 1 to avoid zero-width glyph.
610
78cef877
EZ
6112012-02-01 Eli Zaretskii <eliz@gnu.org>
612
613 * ralloc.c (resize_bloc, r_alloc_sbrk): Don't call memmove if its
614 first 2 arguments are identical. This makes inserting large
615 output from a subprocess an order of magnitude faster on
616 MS-Windows, where all sbrk'ed memory is always contiguous.
617
97897668
GM
6182012-01-31 Glenn Morris <rgm@gnu.org>
619
620 * nsterm.m (syms_of_nsterm) <x-toolkit-scroll-bars>:
c78c6e0b 621 * w32term.c (syms_of_w32term) <x-toolkit-scroll-bars>:
97897668
GM
622 * xterm.c (syms_of_xterm) <x-toolkit-scroll-bars>: Sync docs.
623
31fd3586
GM
6242012-01-29 Glenn Morris <rgm@gnu.org>
625
626 * gnutls.c (syms_of_gnutls): More doc (from etc/NEWS).
627
0e24a8b2
CY
6282012-01-28 Samuel Thibault <sthibault@debian.org> (tiny change)
629
630 * s/gnu.h: Define POSIX_SIGNALS (Bug#10552).
631
cc0adcb0
CY
6322012-01-28 Chong Yidong <cyd@gnu.org>
633
634 * minibuf.c (syms_of_minibuf): Doc fix (Bug#10550).
635
acc28cb9
CY
6362012-01-26 Chong Yidong <cyd@gnu.org>
637
9c69cfb7
CY
638 * keyboard.c (Vecho_keystrokes): Document zero value (Bug#10503).
639
acc28cb9
CY
640 * search.c (Fsearch_forward, Fsearch_backward): Document negative
641 repeat counts (Bug#10507).
642
48da7392
GM
6432012-01-26 Glenn Morris <rgm@gnu.org>
644
645 * lread.c (syms_of_lread): Doc fix.
646
14af5f7f
CY
6472012-01-25 HIROSHI OOTA <nil@mad.dog.cx> (tiny change)
648
649 * coding.c (encode_designation_at_bol): Change return value to
650 EMACS_INT.
651
0b21c100
CY
6522012-01-25 Chong Yidong <cyd@gnu.org>
653
654 * eval.c (Fuser_variable_p): Doc fix; mention custom-variable-p.
655
3c2907f7
CY
6562012-01-21 Chong Yidong <cyd@gnu.org>
657
658 * floatfns.c (Fcopysign): Make the second argument non-optional,
659 since nil is not allowed anyway.
660
959ad23f
AS
6612012-01-21 Andreas Schwab <schwab@linux-m68k.org>
662
663 * process.c (read_process_output): Use p instead of XPROCESS (proc).
664 (send_process): Likewise.
665
34a02f46
MR
6662012-01-19 Martin Rudalics <rudalics@gmx.at>
667
668 * window.c (save_window_save, Fcurrent_window_configuration)
cae07000
SM
669 (Vwindow_persistent_parameters): Do not use Qstate.
670 Rewrite doc-strings.
34a02f46 671
1259009a 6722012-01-19 Kenichi Handa <handa@m17n.org>
25ed9e61
KH
673
674 * character.c (char_width): New function.
70d4fdf6
GM
675 (Fchar_width, c_string_width, lisp_string_width):
676 Use char_width (Bug#9496).
25ed9e61 677
6a6ee00d
MR
6782012-01-16 Martin Rudalics <rudalics@gmx.at>
679
680 * window.c (Vwindow_persistent_parameters): New variable.
681 (Fset_window_configuration, save_window_save): Handle persistent
682 window parameters.
683
c85efaf7
EZ
6842012-01-14 Eli Zaretskii <eliz@gnu.org>
685
686 * w32fns.c (signal_user_input): Don't do a QUIT, to avoid
687 thrashing the stack of the thread. (Bug#9087)
688
5944709e
PE
6892012-01-12 Paul Eggert <eggert@cs.ucla.edu>
690
691 * xdisp.c (rows_from_pos_range): Add parens as per gcc -Wparentheses.
692
e71f5d99
EZ
6932012-01-11 Eli Zaretskii <eliz@gnu.org>
694
695 * xdisp.c (rows_from_pos_range): Handle the case where the
696 highlight ends on a newline. (Bug#10464)
697 (mouse_face_from_buffer_pos): Fix off-by-one error in calculating
698 he end column for display of highlight that ends on a newline
699 before a R2L line.
700
ce316182
GM
7012012-01-11 Glenn Morris <rgm@gnu.org>
702
703 * lread.c (init_lread): If no-site-lisp, remove site-lisp dirs
704 from load-path also when installation-directory is nil. (Bug#10208)
705
5b43da69
GM
7062012-01-10 Glenn Morris <rgm@gnu.org>
707
74cc8ff9
GM
708 * emacs.c (syms_of_emacs) <installation-directory>: Doc fix.
709
7d8d6e4e
GM
710 * epaths.in (PATH_LOADSEARCH, PATH_EXEC, PATH_DATA, PATH_DOC):
711 Update template values to be closer to their typical values these days.
5b43da69 712
a0db8d43
EZ
7132012-01-09 Eli Zaretskii <eliz@gnu.org>
714
715 * xdisp.c (rows_from_pos_range): Accept additional argument
716 DISP_STRING, and accept any glyph in a row whose object is that
717 string as eligible for mouse highlight. Fixes mouse highlight of
718 display strings from overlays. (Bug#10464)
719
9a0115ab 7202012-01-07 Paul Eggert <eggert@cs.ucla.edu>
09450bae 721
b9110d6a 722 emacs: fix an auto-save permissions race condition (Bug#10400)
09450bae
PE
723 * fileio.c (auto_saving_dir_umask): New static var.
724 (Fmake_directory_internal): Use it.
725 (do_auto_save_make_dir): Set it, instead of invoking chmod after
726 creating the directory. The old code temporarily assigns
727 too-generous permissions to the directory.
728 (do_auto_save_eh): Clear it.
b9110d6a 729 (Fdo_auto_save): Catch all errors, not just file errors, so
09450bae
PE
730 that the var is always cleared.
731
6c1bd3f3
EZ
7322012-01-07 Eli Zaretskii <eliz@gnu.org>
733
734 * search.c (scan_buffer): Pass character positions to
735 know_region_cache, not byte positions. (Bug#6540)
736
069d2b50
L
7372012-01-07 LynX <_LynX@bk.ru> (tiny change)
738
739 * w32.c (sys_rename): Report EXDEV when rename of a directory
740 fails because the target is on another logical disk. (Bug#10284)
741
75bf0d33
DB
7422012-01-07 David Benjamin <davidben@mit.edu> (tiny change)
743
744 * xterm.c (x_embed_request_focus): New function.
745
746 * xterm.h: Add prototype.
747
748 * xfns.c (Fx_focus_frame): Use it for embedded frames (Bug#9977).
749
1c6e5a32
GM
7502012-01-05 Glenn Morris <rgm@gnu.org>
751
752 * emacs.c (emacs_copyright): Update short copyright year to 2012.
753
651e947e
EZ
7542012-01-01 Eli Zaretskii <eliz@gnu.org>
755
756 * gnutls.c (init_gnutls_functions): Load gnutls_check_version.
757 Load gnutls_transport_set_lowat only if GnuTLS version is below
758 2.11.1.
759 (emacs_gnutls_handshake): Call gnutls_transport_set_lowat only for
760 GnuTLS versions below 2.11.1.
761
3778cdd8
AL
7622011-12-31 Antoine Levitt <antoine.levitt@gmail.com>
763
764 * xdisp.c (syms_of_xdisp) <window-scroll-functions>: Add warning
765 to the doc string advising against its use for altering the way
766 windows are scrolled.
767
0e5317f7
KH
7682011-12-28 Kenichi Handa <handa@m17n.org>
769
770 * coding.c (Fdefine_coding_system_internal): Make an utf-8 base
771 coding-system ASCII compatible only when it does not produce BOM
772 on encoding (Bug#10383).
773
93d5ca1f
JD
7742011-12-26 Jan Djärv <jan.h.d@swipnet.se>
775
776 * xmenu.c (x_menu_wait_for_event): Use xg_select for Gtk3 so menus
777 can scroll.
778 (create_and_show_popup_menu): Always use menu_position_func for
779 Gtk3 (Bug#10361).
780
ca22b785
AS
7812011-12-24 Andreas Schwab <schwab@linux-m68k.org>
782
783 * callint.c (Fcall_interactively): Don't truncate prompt string.
784
d048e1e6
EZ
7852011-12-23 Eli Zaretskii <eliz@gnu.org>
786
787 * xdisp.c (handle_invisible_prop): Handle correctly an invisible
788 property that ends at ZV, so that the bidi iteration could be
3ba1a2ad 789 resumed from there (after widening). (Bug#10360)
d048e1e6 790
5ccaba1f
JD
7912011-12-22 Jan Djärv <jan.h.d@swipnet.se>
792
793 * nsfont.m (ns_spec_to_descriptor): Do not autorelease fdesc.
794
204ee57f
JD
7952011-12-21 Jan Djärv <jan.h.d@swipnet.se>
796
b81d40f0
JB
797 * nsterm.m (x_free_frame_resources):
798 Release f->output_data.ns->miniimage.
204ee57f
JD
799 (ns_index_color): Fix indentation. Do not retain
800 color_table->colors[i].
801
802 * nsmenu.m (ns_update_menubar): Call free_menubar_widget_value_tree
803 before returning.
804
805 * nsfns.m (x_set_background_color): Assign return value from
806 ns_index_color to face-background instead of NSColor*.
807 (ns_implicitly_set_icon_type): Fix indentation.
808 Change assignment in for loop to comparison.
809
810 * emacs.c (ns_pool): New variable.
811 (main): Assign ns_pool.
812 (Fkill_emacs): Call ns_release_autorelease_pool.
813
814 * nsfont.m (ns_spec_to_descriptor): Fix indentation,
815 autorelease fdesc, release fdAttrs and tdict.
816 (ns_get_covering_families): Release charset.
817 (ns_findfonts): Release NSFontDescriptor created with new.
818 (ns_uni_to_glyphs): Fix indentation.
819 (setString): Release attrStr before assigning new value.
820
c803b2b7
JD
8212011-12-18 Jan Djärv <jan.h.d@swipnet.se>
822
678f4426
JD
823 * nsmenu.m (NSMenuDidBeginTrackingNotification): Declare if OSX < 10.5
824 and NS_IMPL_COCOA.
825 (trackingNotification): Surround with ifdef NS_IMPL_COCOA.
826 (syms_of_nsmenu): Set trackingMenu to 1 if not NS_IMPL_COCOA.
827
cd394be1 8282011-12-18 David Reitter <reitter@cmu.edu>
678f4426 829
5fecd5fc
JD
830 * nsterm.m (ns_term_init): Subscribe for notifications
831 NSMenuDidBeginTrackingNotification and NSMenuDidEndTrackingNotification
832 to method trackingNotification in EmacsMenu.
833
834 * nsmenu.m (trackingMenu): New variable.
3771cb17 835 (trackingNotification): New method (from Aquamacs).
5fecd5fc 836 (menuNeedsUpdate): Expand comment and return if trackingMenu is 0,
3771cb17 837 from Aquamacs (Bug#7030).
678f4426
JD
838
8392011-12-18 Jan Djärv <jan.h.d@swipnet.se>
5fecd5fc 840
c803b2b7
JD
841 * nsselect.m (CUT_BUFFER_SUPPORT): Remove define.
842 (symbol_to_nsstring): Fix indentation.
843 (ns_symbol_to_pb): New function.
cae07000
SM
844 (Fns_get_selection_internal): Rename from Fns_get_cut_buffer_internal.
845 (Fns_rotate_cut_buffers_internal): Remove.
846 (Fns_store_selection_internal): Rename from
c803b2b7
JD
847 Fns_store_cut_buffer_internal.
848 (ns_get_foreign_selection, Fx_own_selection_internal)
849 (Fx_disown_selection_internal, Fx_selection_exists_p)
b81d40f0
JB
850 (Fns_get_selection_internal, Fns_store_selection_internal):
851 Use ns_symbol_to_pb and check if return value is nil.
852 (syms_of_nsselect): Remove ifdef CUT_BUFFER_SUPPORT. Remove defsubr
853 Sns_rotate_cut_buffers_internal. Sns_get_cut_buffer_internal
c803b2b7
JD
854 renamed to Sns_get_selection_internal, Sns_store_cut_buffer_internal
855 renamed to Sns_store_selection_internal.
856 (ns_handle_selection_request): Move code to Fx_own_selection_internal
857 and remove this function.
858 (ns_handle_selection_clear): Remove, never used.
859 (Fx_own_selection_internal): Move code from ns_handle_selection_request
860 here.
861
e1b01a3a
KB
8622011-12-17 Ken Brown <kbrown@cornell.edu>
863
864 * fileio.c (check_writable) [CYGWIN]: Return non-zero if UID or
865 GID is unknown (Bug#10257).
866
2adb6e85
PE
8672011-12-17 Paul Eggert <eggert@cs.ucla.edu>
868
869 * s/gnu-linux.h: Fix mark_memory typo (Bug#10286).
870 (GC_MARK_SECONDARY_STACK): Omit removed 3rd arg to mark_memory,
871 which caused a build failure on GNU/Linux IA-64. This problem was
872 introduced by my 2011-10-07 patch.
873
d1d7b339
JL
8742011-12-15 Juri Linkov <juri@jurta.org>
875
876 * image.c (imagemagick_error): New function. (Bug#10112)
877 (imagemagick_load_image): Comment out `MagickSetResolution' call.
878 Use `imagemagick_error' where ImageMagick functions return
879 `MagickFalse'.
880 (Fimagemagick_types): Add `Fnreverse' to return the list in the
881 proper order.
882
100d5755
KH
8832011-12-15 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
884
885 * xftfont.c (xftfont_draw): Use the font metrics of s->font to
886 fill background (Bug#8992).
887
454592a6
MR
8882011-12-13 Martin Rudalics <rudalics@gmx.at>
889
890 * window.c (Vwindow_combination_resize)
891 (Vwindow_combination_limit): Use t instead of non-nil in
892 doc-strings.
61d4b438
MR
893 (Vrecenter_redisplay): Add first sentence of doc-string on
894 separate line.
53524d93 895 (Frecenter): Fix doc-string typo.
454592a6 896
3633e3aa
KH
8972011-12-11 Kenichi Handa <handa@m17n.org>
898
899 * coding.c (Funencodable_char_position): Pay attention to the
900 buffer text relocation (Bug#9389).
901
7b9d523a
JD
9022011-12-10 Jan Djärv <jan.h.d@swipnet.se>
903
904 * xterm.c (x_term_init): Move call to gdk_window_add_filter before
905 gtk_init (Bug#10100).
906
b73189c6
EZ
9072011-12-10 Eli Zaretskii <eliz@gnu.org>
908
909 * xdisp.c (RECORD_MAX_MIN_POS): Use IT->cmp_it.charpos only if
910 IT->string is nil. (Bug#10263)
911
f7dfe5d6
JD
9122011-12-10 Jan Djärv <jan.h.d@swipnet.se>
913
83faebb4
JD
914 * nsterm.h (x_free_frame_resources): Declare.
915
f7dfe5d6
JD
916 * nsfns.m (ns_get_defaults_value): New function (Bug#10103).
917 (Fns_get_resource, x_get_string_resource): Call ns_get_defaults_value.
918
919 * nsterm.h (ns_get_defaults_value): Declare.
920
921 * nsterm.m (ns_default): Call ns_get_defaults_value.
922
7cd4e72c
EZ
9232011-12-09 Eli Zaretskii <eliz@gnu.org>
924
925 * xdisp.c (try_scrolling): Don't set scroll_down_p if dy is zero.
926 (Bug#10170)
927
b34d7317
YM
9282011-12-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
929
930 * unexelf.c (unexec) [NS_IMPL_GNUSTEP]: Take account of the case
931 that where the value of an _OBJC_* symbol points to is in the .bss
932 section (Bug#10240).
933
76470ad1
KH
9342011-12-08 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
935
936 * coding.c (encode_coding_ccl): Check (charbuf < charbuf_end)
2fac8180 937 after the loop to call ccl_driver at least once (Bug#8619).
76470ad1 938
745fff94
KH
9392011-12-08 Kenichi Handa <handa@m17n.org>
940
941 * ftfont.c (get_adstyle_property): Fix previous change
942 (Bug#10233).
943
6e44397c
JB
9442011-12-07 Juanma Barranquero <lekktu@gmail.com>
945
946 * w32.c (init_environment): If no_site_lisp, remove site-lisp
947 dirs from the default value of EMACSLOADPATH (bug#10208).
948
7efa6272
GM
9492011-12-07 Glenn Morris <rgm@gnu.org>
950
951 * lread.c (init_lread): If no_site_lisp, exclude site-lisp/ in
952 installation and source directories as well. (Bug#10208)
953
f6fc4d87
CY
9542011-12-06 Chong Yidong <cyd@gnu.org>
955
956 * minibuf.c (Fread_from_minibuffer): Doc fix (Bug#10228).
957
2bf26180
GM
9582011-12-06 Glenn Morris <rgm@gnu.org>
959
960 * process.c (start_process_unwind): Treat any pid <= 0, except -2,
961 as an error, not just -1. (Bug#10217)
962
3a6ad4f0
CY
9632011-12-05 Chong Yidong <cyd@gnu.org>
964
965 * keyboard.c (process_special_events): New function.
966 (swallow_events, Finput_pending_p): Use it (Bug#10195).
967
75a3b399
PE
9682011-12-05 Paul Eggert <eggert@cs.ucla.edu>
969
970 * coding.c (encode_designation_at_bol): Don't use uninitialized
971 local variable (Bug#9318).
972
c3c9e25e
KH
9732011-12-05 Kenichi Handa <handa@m17n.org>
974
975 * ftfont.c (get_adstyle_property): If the font is not BDF nor PCF,
976 return Qnil (Bug#8046, Bug#10193).
977
5eb05ea3
KH
9782011-12-05 Kenichi Handa <handa@m17n.org>
979
980 * coding.c (encode_designation_at_bol): New args charbuf_end and
981 dst. Return the number of produced bytes. Callers changed.
a79703f5
KH
982 (coding_set_source): Return how many bytes coding->source was
983 relocated.
984 (coding_set_destination): Return how many bytes
985 coding->destination was relocated.
986 (CODING_DECODE_CHAR, CODING_ENCODE_CHAR, CODING_CHAR_CHARSET)
cae07000 987 (CODING_CHAR_CHARSET_P): Adjust for the avove changes.
5eb05ea3
KH
988
9892011-12-05 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny change)
990
991 * coding.c (CODING_CHAR_CHARSET_P): New macro.
992 (encode_coding_emacs_mule, encode_coding_iso_2022): Use the above
993 macro (Bug#9318).
994
9952011-12-05 Andreas Schwab <schwab@linux-m68k.org>
996
997 The following changes are to fix Bug#9318.
998
a79703f5 999 * coding.c (CODING_ENCODE_CHAR, CODING_CHAR_CHARSET): New macros.
5eb05ea3
KH
1000 (encode_coding_emacs_mule, ENCODE_ISO_CHARACTER)
1001 (encode_coding_iso_2022, encode_coding_sjis)
a79703f5 1002 (encode_coding_big5, encode_coding_charset): Use the above macros.
5eb05ea3 1003
7dbda6df
JB
10042011-12-05 Juanma Barranquero <lekktu@gmail.com>
1005
1006 * lisp.h (process_quit_flag): Fix external declaration.
1007
6d5eb5b0
SM
10082011-12-04 Stefan Monnier <monnier@iro.umontreal.ca>
1009
1010 Don't macro-inline non-performance-critical code.
1011 * eval.c (process_quit_flag): New function.
1012 * lisp.h (QUIT): Use it.
1013
a0c3fad0
JD
10142011-12-04 Jan Djärv <jan.h.d@swipnet.se>
1015
1016 * nsfns.m (get_geometry_from_preferences): New function.
1017 (Fx_create_frame): Call get_geometry_from_preferences (Bug#10103).
1018
6c07aac2
AS
10192011-12-04 Andreas Schwab <schwab@linux-m68k.org>
1020
1021 * emacs.c (Qkill_emacs): Define.
1022 (syms_of_emacs): Initialize it.
1023 * keyboard.c (interrupt_signal): Don't call Fkill_emacs here, set
1024 Qquit_flag to `kill-emacs' instead.
6d5eb5b0
SM
1025 (quit_throw_to_read_char): Add parameter `from_signal'.
1026 All callers changed. Call Fkill_emacs if requested and safe.
6c07aac2
AS
1027 * lisp.h (QUIT): Call Fkill_emacs if requested.
1028
c052ead4
JD
10292011-12-03 Jan Djärv <jan.h.d@swipnet.se>
1030
1031 * widget.c (update_wm_hints): Return if wmshell is null.
1032 (widget_update_wm_size_hints): New function.
1033
1034 * widget.h (widget_update_wm_size_hints): Declare.
1035
1036 * xterm.c (x_wm_set_size_hint): If USE_X_TOOLKIT, call
1037 widget_update_wm_size_hints (Bug#10104).
1038
9e49252b
EZ
10392011-12-03 Eli Zaretskii <eliz@gnu.org>
1040
1041 * xdisp.c (handle_invisible_prop): If the invisible text ends just
1042 before a newline, prepare the bidi iterator for consuming the
1043 newline, and keep the current paragraph direction. (Bug#10183)
e9a49426 1044 (redisplay_window): Don't let `margin' become negative. (Bug#10192)
9e49252b 1045
02b16839
JL
10462011-12-02 Juri Linkov <juri@jurta.org>
1047
1048 * search.c (Fword_search_regexp): New Lisp function created from
1049 `wordify'. Change type of arg `lax' from `int' to `Lisp_Object'.
1050 (Fword_search_backward, Fword_search_forward)
1051 (Fword_search_backward_lax, Fword_search_forward_lax):
1052 Use `Fword_search_regexp' instead of `wordify'. Doc fix.
1053 (syms_of_search): Define `Sword_search_regexp'. (Bug#10145)
1054
0068070e
SM
10552011-12-01 Stefan Monnier <monnier@iro.umontreal.ca>
1056
1057 * fileio.c (Finsert_file_contents): Move after-change-function call
1058 to before the "handled:" label, since all "goto handled" appear in
1059 cases where the *-change-functions have already been properly called
1060 (bug#10117).
1061
3360a3fc
AS
10622011-12-01 Andreas Schwab <schwab@linux-m68k.org>
1063
1064 * keyboard.c (interrupt_signal): Don't call kill-emacs when
1065 waiting for input. (Bug#10169)
1066
73d6c093
EZ
10672011-11-30 Eli Zaretskii <eliz@gnu.org>
1068
1069 * dispnew.c (adjust_glyph_matrix): Remove the assertion that
1070 verifies glyph row's hash code--we have just reallocated the
1071 glyphs, so their contents can be complete garbage. (Bug#10164)
1072
febe6bea
JB
10732011-11-30 Juanma Barranquero <lekktu@gmail.com>
1074
1075 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Add missing check.
1076
801a4313
EZ
10772011-11-30 Eli Zaretskii <eliz@gnu.org>
1078
1079 * dispnew.c (adjust_glyph_matrix) [XASSERTS]: Ensure ROW's
1080 attributes are tested _before_ calling verify_row_hash, to protect
1081 against GCC re-ordering of the tests. (Bug#10164)
1082
2b56b87e
JD
10832011-11-29 Jan Djärv <jan.h.d@swipnet.se>
1084
1085 * xterm.h (struct x_output): net_wm_state_hidden_seen is new.
1086
1087 * xterm.c (handle_one_xevent): Only set async_visible and friends
1088 if net_wm_state_hidden_seen is non-zero (Bug#10002)
7dbda6df 1089 (get_current_wm_state): Set net_wm_state_hidden_seen to 1 if
2b56b87e
JD
1090 _NET_WM_STATE_HIDDEN is in NET_WM_STATE.
1091
dbf31225
PE
10922011-11-28 Paul Eggert <eggert@cs.ucla.edu>
1093
1094 Remove GCPRO-related macros that exist only to avoid shadowing locals.
1095 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR)
1096 (GCPRO6_VAR, UNGCPRO_VAR): Remove. See
1097 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1098 All uses changed to use GCPRO1 etc.
1099 (GCPRO1, GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6, UNGCPRO):
1100 Revert to old implementation (i.e., before 2011-03-11).
1101
1305621b
YM
11022011-11-28 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
1103
1104 * dispnew.c (scrolling_window): Truncate overlaps in copy destination
1105 of scroll runs so as to avoid assigning disabled bogus rows and
1106 unnecessary graphics copy operations.
1107
8c9afb46
EZ
11082011-11-27 Eli Zaretskii <eliz@gnu.org>
1109
1110 * s/ms-w32.h (utimbuf) [_MSC_VER]: Don't define.
1111 (snprintf) [_MSC_VER]: Redirect to _snprintf.
1112 (strtoll) [_MSC_VER]: Redirect to _strtoi64.
1113 (malloc, free, realloc, calloc): Redirect to e_* only when
1114 compiling Emacs.
1115
1116 * lisp.h (GCTYPEBITS): Move before first use.
1117 (ALIGN_GCTYPEBITS) [_MSC_VER]: Define.
1118 (DECL_ALIGN) [_MSC_VER]: Use it, as MSVC doesn't like bit ops in
1119 this macro definition.
1120
1121 * s/ms-w32.h (tzname): Redirect to _tzname for all values of
1122 _MSC_VER.
1123
54e9e3bf
JD
11242011-11-27 Jan Djärv <jan.h.d@swipnet.se>
1125
6d5eb5b0
SM
1126 * gtkutil.c (xg_create_frame_widgets):
1127 Call gtk_window_set_has_resize_grip (FALSE) if that function is
54e9e3bf
JD
1128 present with Gtk+ 2.0.
1129
83aca1cb
PE
11302011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1131
1132 * fileio.c (Finsert_file_contents): Undo previous change; see
1133 <http://lists.gnu.org/archive/html/emacs-diffs/2011-11/msg00265.html>.
1134
5b76caa4
PE
11352011-11-26 Paul Eggert <eggert@cs.ucla.edu>
1136
1137 Rename locals to avoid shadowing.
1138 * fileio.c (Finsert_file_contents):
1139 Rename inner 'gcpro1' to 'inner_gcpro1' to avoid shadowing.
1140 * process.c (wait_reading_process_output):
1141 Rename inner 'proc' to 'p' to avoid shadowing.
1142 Indent for consistency with usual Emacs style.
1143
8c535114
EZ
11442011-11-25 Eli Zaretskii <eliz@gnu.org>
1145
1146 * xdisp.c (redisplay_window): If cursor row is not fully visible
1147 after recentering, and scroll-conservatively is set to a large
1148 number, scroll window by a few more lines to make the cursor fully
1149 visible and out of scroll-margin. (Bug#10105)
91b4a718
EZ
1150 (start_display): Don't move to the next line if the display should
1151 start at a newline that is part of a display vector or an overlay
1152 string. (Bug#10119)
8c535114 1153
fa4fdb5c
JL
11542011-11-24 Juri Linkov <juri@jurta.org>
1155
1156 * image.c (imagemagick_load_image): Move `MagickSetResolution' down
1157 after the `MagickPingImage' call. (Bug#10112)
1158
90ec88df
CY
11592011-11-23 Chong Yidong <cyd@gnu.org>
1160
1161 * window.c (Fcoordinates_in_window_p): Accept only live windows.
1162
56e2e794
MR
11632011-11-23 Martin Rudalics <rudalics@gmx.at>
1164
1165 * buffer.c (Fkill_buffer): Run replace_buffer_in_windows before
1166 making another buffer current. (Bug#10114)
1167
b6e64c41
GM
11682011-11-23 Glenn Morris <rgm@gnu.org>
1169
1170 * font.c (font_find_for_lface) [HAVE_NS]: Ignore case. (Bug#2526)
1171
6b21de18
CY
11722011-11-23 Chong Yidong <cyd@gnu.org>
1173
1174 * xdisp.c (compute_stop_pos): Check validity of end_charpos before
1175 using it (Bug#5984).
1176
b12cd789
EZ
11772011-11-22 Eli Zaretskii <eliz@gnu.org>
1178
1179 * dispnew.c (adjust_glyph_matrix): Don't verify hash code of mode-
1180 and header-lines, as they don't have one computed for them.
1181 (Bug#10098)
1182
1183 * .gdbinit (prow): Make displayed values more self-explaining.
1184 Add row's hash code.
1185
261b6fd4
LMI
11862011-11-21 Lars Magne Ingebrigtsen <larsi@gnus.org>
1187
1188 * process.c (wait_reading_process_output): Fix asynchrounous
1189 GnuTLS socket handling on some versions of the GnuTLS library.
16c1ad08 1190 (wait_reading_process_output): Add comment and URL.
261b6fd4 1191
e7cfd277
JD
11922011-11-21 Jan Djärv <jan.h.d@swipnet.se>
1193
1194 * xterm.c (x_clear_frame): Reinstate the XClearWindow call.
1195
a9b9b7f5
CY
11962011-11-21 Chong Yidong <cyd@gnu.org>
1197
1198 * window.c (Fnext_window, Fprevious_window): Doc fix.
1199
b0d15b4f
SM
12002011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1201
1202 * window.c (get_phys_cursor_glyph): Fix Lisp_Object/int mixup.
1203
fe7a3057
JB
12042011-11-20 Juanma Barranquero <lekktu@gmail.com>
1205
1206 * nsfont.m (syms_of_nsfont) <ns-reg-to-script>: Fix typo.
1207
d2999b1a
MR
12082011-11-20 Martin Rudalics <rudalics@gmx.at>
1209
1210 * window.c (Fset_window_combination_limit): Rename argument
1211 STATUS to LIMIT.
1212 (Vwindow_combination_limit): Remove "status" from doc-string.
1213
d5ff9cd0
AS
12142011-11-20 Andreas Schwab <schwab@linux-m68k.org>
1215
1216 * m/ibms390.h: Remove.
1217 * m/ibms390x.h: Don't include "ibms390.h".
1218
a5bb9bd3
SM
12192011-11-20 Stefan Monnier <monnier@iro.umontreal.ca>
1220
1221 * fileio.c (Finsert_file_contents): Add missing gcpro1 variable.
1222 Suggested by Dmitry Antipov <dmantipov@yandex.ru>.
1223
cd1181db
JB
12242011-11-20 Juanma Barranquero <lekktu@gmail.com>
1225
1226 * casetab.c (Fset_case_table):
1227 * charset.c (Fcharset_after): Fix typos.
1228
615a3b8d 12292011-11-20 Paul Eggert <eggert@cs.ucla.edu>
6a0bf43d 1230
17e845af
PE
1231 Standardize on VIRT_ADDR_VARIES behavior (Bug#10042).
1232 Otherwise, valgrind does not work on some platforms.
1233 Problem reported by Andreas Schwab in
6a0bf43d
PE
1234 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00081.html>.
1235 * puresize.h (pure, PURE_P): Always behave as if VIRT_ADDR_VARIES
1236 is set, removing the need for VIRT_ADDRESS_VARIES.
1237 (PURE_P): Use a more-efficient implementation that needs just one
1238 comparison, not two: on x86-64 with GCC 4.6.2, this cut down the
1239 number of instructions from 6 (xorl, cmpq, jge, xorl, cmpq, setge)
1240 to 4 (xorl, subq, cmpq, setbe).
1241 * alloc.c (pure): Always extern now, since that's the
1242 VIRT_ADDR_VARIES behavior.
1243 (PURE_POINTER_P): Use a single comparison, not two, for
1244 consistency with the new puresize.h.
1245 * lisp.h (PNTR_COMPARISON_TYPE): Remove; no longer needed.
1246 * m/ibms390.h, m/intel386.h, m/template.h, s/cygwin.h, s/hpux10-20.h:
1247 Remove VIRT_ADDR_VARIES no longer needed.
1248
f8fe6f96
EZ
12492011-11-19 Eli Zaretskii <eliz@gnu.org>
1250
1251 * xdisp.c (x_write_glyphs, draw_phys_cursor_glyph)
1252 (erase_phys_cursor, update_window_cursor, show_mouse_face)
1253 (cursor_in_mouse_face_p): If the cursor position is out of bounds,
1254 behave as if the cursor position were at the window margin.
1255
1256 * window.c (get_phys_cursor_glyph): If the window is hscrolled,
1257 and the cursor position is out of bounds, behave as if the cursor
1258 position were at the window margin. (Bug#10075)
1259
df05a53c
CY
12602011-11-18 Chong Yidong <cyd@gnu.org>
1261
1262 * window.c (Fwindow_combination_limit): Make first argument
1263 non-optional, since it is meaningless for live windows like the
1264 selected window.
1265
2071918e
DA
12662011-11-18 Dmitry Antipov <dmantipov@yandex.ru>
1267
1268 * keymap.c (Fwhere_is_internal): Add missing RETURN_UNGCPROs.
1269
b50a28de
SM
12702011-11-18 Stefan Monnier <monnier@iro.umontreal.ca>
1271
1272 * intervals.c: Fix grafting over the whole buffer (bug#10071).
1273 (graft_intervals_into_buffer): Simplify.
1274
015137db
EZ
12752011-11-18 Eli Zaretskii <eliz@gnu.org>
1276
1277 * dispnew.c (swap_glyph_pointers): Swap the used[] arrays and the
1278 hash values of the two rows.
1279 (copy_row_except_pointers): Preserve the used[] arrays and the
1280 hash values of the two rows. (Bug#10035)
68c95424 1281 (add_row_entry): Add xassert to verify that ROW's hash code is valid.
015137db
EZ
1282
1283 * xdisp.c (row_hash): New function, body extracted from
1284 compute_line_metrics.
1285 (compute_line_metrics): Call row_hash, instead of computing the
1286 hash code inline.
1287
1288 * dispnew.c (verify_row_hash): Call row_hash for computing the
1289 hash code of a row, instead of duplicating code from xdisp.c.
1290
1291 * dispextern.h (row_hash): Add prototype.
1292
a2addb04
TH
12932011-11-18 Tassilo Horn <tassilo@member.fsf.org>
1294
1295 * frame.c (delete_frame): Don't delete the terminal when the last
1296 X frame is closed if emacs is built with GTK toolkit.
1297
df85d315
JB
12982011-11-17 Juanma Barranquero <lekktu@gmail.com>
1299
1300 * window.c (syms_of_window) <window-combination-resize>: Fix typo.
1301
a0c2d0ae
MR
13022011-11-17 Martin Rudalics <rudalics@gmx.at>
1303
1304 * window.c (Vwindow_splits): Rename to
1305 Vwindow_combination_resize. Suggested by Juri Linkov.
1306 (Fsplit_window_internal): Use Vwindow_combination_resize instead
1307 of Vwindow_splits.
1308
58179cce
JB
13092011-11-16 Juanma Barranquero <lekktu@gmail.com>
1310
7877f373
JB
1311 * nsfns.m (Fns_font_name):
1312 * window.c (syms_of_window) <window-combination-limit>: Fix typos.
58179cce 1313
b6f67890
MR
13142011-11-16 Martin Rudalics <rudalics@gmx.at>
1315
1316 * window.h (window): Rename slot "nest" to "combination_limit".
1317 * window.c (Fwindow_nest): Rename to Fwindow_combination_limit.
1318 (Fset_window_nest): Rename to Fset_window_combination_limit.
1319 (Vwindow_nest): Rename to Vwindow_combination_limit.
1320 (recombine_windows, make_parent_window, make_window)
1321 (Fsplit_window_internal, saved_window)
1322 (Fset_window_configuration, save_window_save): Rename all
1323 occurrences of window_nest to window_combination_limit.
1324
c7015153
JB
13252011-11-15 Juanma Barranquero <lekktu@gmail.com>
1326
1327 * image.c (imagemagick_load_image): Fix typo.
1328
322ad6ec
EZ
13292011-11-14 Eli Zaretskii <eliz@gnu.org>
1330
1331 * xdisp.c (display_line): Move the call to
1332 highlight_trailing_whitespace before the call to
1333 compute_line_metrics, since the latter needs to see the final
6d5eb5b0
SM
1334 faces of all the glyphs to compute ROW's hash value.
1335 Fixes assertion violations in row_equal_p. (Bug#10035)
322ad6ec 1336
f067b8ec
JB
13372011-11-14 Juanma Barranquero <lekktu@gmail.com>
1338
1339 * w32proc.c (reader_thread): Don't check pending input if cp->fd < 0,
1340 just return (bug#10044).
1341
1e5b2111
EZ
13422011-11-12 Eli Zaretskii <eliz@gnu.org>
1343
7ef3cbd5
EZ
1344 * makefile.w32-in (HEAPSIZE): New variable, allows to build temacs
1345 with user-defined heap size. Bump the default size of the temacs
1346 heap to 27MB, to avoid memory warning when running temacs.
1347 ($(TEMACS)): Use HEAPSIZE instead of a hardcoded value.
1348
1e5b2111
EZ
1349 * dispnew.c (scrolling_window): Fix incorrect indices in accessing
1350 current_matrix and desired_matrix. (Bug#9990)
7a7270dd
EZ
1351 (verify_row_hash) [XASSERTS]: New function.
1352 (adjust_glyph_matrix, row_equal_p): Use it in xassert to verify
1353 that the hash value of glyph rows is correct.
1e5b2111 1354
89d61221
MR
13552011-11-12 Martin Rudalics <rudalics@gmx.at>
1356
1357 * window.h (window): Remove splits slot.
1358 * window.c (Fwindow_splits, Fset_window_splits): Remove.
1359 (Fdelete_other_windows_internal, make_parent_window)
1360 (make_window, Fsplit_window_internal, Fdelete_window_internal)
1361 (Fset_window_configuration, save_window_save): Don't deal with
1362 split status of windows.
1363 (saved_window): Remove splits slot.
1364 (Vwindow_splits): Rewrite doc-string.
1365
97f18cc8
JD
13662011-11-11 Jan Djärv <jan.h.d@swipnet.se>
1367
1368 * xfns.c (unwind_create_frame):
1369 * nsfns.m (unwind_create_frame):
1370 * w32fns.c (unwind_create_frame): Use Fmemq to check if frame is in
1371 Vframe_list (Bug#9999).
1372
22a648b4
DA
13732011-11-11 Dmitry Antipov <dmantipov@yandex.ru>
1374
0b381c7e 1375 * xdisp.c (syms_of_xdisp): Remove duplicated definition of Qtext.
22a648b4 1376
659afede
KH
13772011-11-11 Kenichi Handa <handa@m17n.org>
1378
1379 * callproc.c (Fcall_process): Set the member dst_multibyte of
1380 process_coding.
1381
9ac0394b
KH
13822011-11-11 Johan Bockgård <bojohan@gnu.org>
1383
1384 * xdisp.c (fill_composite_glyph_string): Always set s->face, to
1385 avoid a crash (bug#9496).
1386
2fbdc249
CY
13872011-11-09 Chong Yidong <cyd@gnu.org>
1388
1389 * window.c (Fwindow_inside_edges, Fwindow_inside_pixel_edges)
1390 (Fwindow_inside_absolute_pixel_edges): Only allow live windows.
1391
ac6b1f81
PE
13922011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1393
1394 * s/gnu.h (GC_MARK_STACK): Define to GC_MAKE_GCPROS_NOOPS (Bug#9926).
1395
09db192c
PE
13962011-11-08 Paul Eggert <eggert@cs.ucla.edu>
1397
1398 Avoid some portability problems by eschewing 'extern inline' functions.
1399 The trivial performance wins aren't worth the portability hassles; see
1400 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>
1401 et seq.
1402 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1403 (window_box_width, window_box_left, window_box_left_offset)
1404 (window_box_right, window_box_right_offset): Undo previous change,
1405 by removing the "extern"s.
1406 * intervals.c (adjust_intervals_for_insertion)
1407 (adjust_intervals_for_deletion): Undo previous change,
1408 making these static again.
1409 (offset_intervals, temp_set_point_both, temp_set_point)
1410 (copy_intervals_to_string): No longer inline.
1411 * xdisp.c (window_text_bottom_y, window_box_width)
1412 (window_box_height, window_box_left_offset)
1413 (window_box_right_offset, window_box_left, window_box_right)
1414 (window_box): No longer inline.
1415
105216ed
CY
14162011-11-08 Chong Yidong <cyd@gnu.org>
1417
1418 * window.c (Fwindow_left_column, Fwindow_top_line): Doc fix.
6d5eb5b0
SM
1419 (Fwindow_body_height, Fwindow_body_width): Move from Lisp.
1420 Signal an error if not a live window.
105216ed
CY
1421 (Fwindow_total_width, Fwindow_total_height): Move from Lisp.
1422 (Fwindow_total_size, Fwindow_body_size): Move to Lisp.
1423
ae9e237f
JB
14242011-11-07 Juanma Barranquero <lekktu@gmail.com>
1425
1426 * lisp.h (syms_of_abbrev): Remove declaration.
1427 Reported by CHENG Gao <chenggao@royau.me>.
1428
c7aa8333
EZ
14292011-11-07 Eli Zaretskii <eliz@gnu.org>
1430
1431 * w32.c (check_windows_init_file): Don't look for term/w32-win.el
1432 if Vpurify_flag is non-nil. Fixes a crash when running w32 build
1433 of temacs in GUI mode.
1434
be7f5545
MR
14352011-11-07 Martin Rudalics <rudalics@gmx.at>
1436
1437 * window.h: Declare delete_all_child_windows instead of
1438 delete_all_subwindows.
1439 * window.c (Fwindow_nest, Fset_window_nest)
1440 (Fset_window_new_total, Fset_window_new_normal)
1441 (Fwindow_resize_apply): Don't use term subwindow in doc-strings.
1442 (delete_all_subwindows): Rename to delete_all_child_windows.
1443 (Fdelete_other_windows_internal, Fset_window_configuration):
1444 Call delete_all_child_windows instead of delete_all_subwindows.
1445 * frame.c (delete_frame): Call delete_all_child_windows instead
1446 of delete_all_subwindows.
1447
ca78dc43
PE
14482011-11-07 Paul Eggert <eggert@cs.ucla.edu>
1449
1450 * alloc.c (DEADP): New macro, for porting to GNU/Hurd (Bug#9926).
1451 This is also needed for porting to any host where GC_MARK_STACK is
1452 not GC_MAKE_GCPROS_NOOPS.
1453 (which_symbols): Use it.
1454
a0241d01
KH
14552011-11-07 Kenichi Handa <handa@m17n.org>
1456
1457 * coding.c (coding_set_destination): Check coding->src_pos only
1458 when coding->src_object is a buffer (bug#9910).
1459
1460 * process.c (send_process): Set the member src_multibyte of coding
1461 to 0 (bug#9911) when sending a unibyte text.
1462
1463 * callproc.c (Fcall_process): Set the member src_multibyte of
1464 process_coding to 0 (bug#9912).
1465
a64bfdfa 14662011-11-06 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
ba24cea2
YM
1467
1468 * xmenu.c (cleanup_widget_value_tree): New function.
1469 (xmenu_show, xdialog_show): Use it in record_unwind_protect instead of
1470 calling free_menubar_widget_value_tree directly (Bug#9830).
1471
cb41b32a
PE
14722011-11-06 Paul Eggert <eggert@cs.ucla.edu>
1473
1474 Fix some portability problems with 'inline'.
1475 * dispextern.h (window_box, window_box_height, window_text_bottom_y)
1476 (window_box_width, window_box_left, window_box_left_offset)
1477 (window_box_right, window_box_right_offset): Declare extern.
1478 Otherwise, these inline functions do not conform to C99 and
1479 are miscompiled by Microsoft compilers. Reported by Eli Zaretskii in
1480 <http://lists.gnu.org/archive/html/emacs-devel/2011-11/msg00084.html>.
1481 * intervals.c (adjust_intervals_for_insertion)
1482 (adjust_intervals_for_deletion): Now extern, because otherwise the
1483 extern inline functions 'offset_intervals' couldn't refer to it.
1484 (static_offset_intervals): Remove.
1485 (offset_intervals): Rewrite using the old contents of
1486 static_offset_intervals. The old version didn't conform to C99
1487 because an extern inline function contained a reference to an
1488 identifier with static linkage.
1489
b7041366
AS
14902011-11-06 Andreas Schwab <schwab@linux-m68k.org>
1491
1492 * keyboard.c (interrupt_signal): Don't call kill-emacs while in
1493 GC.
1494
88a37c4d
EZ
14952011-11-06 Eli Zaretskii <eliz@gnu.org>
1496
1497 * xdisp.c (init_iterator, reseat_to_string): Don't set the
1498 iterator's bidi_p flag if Vpurify_flag is non-nil. (Bug#9963)
1499 (Fcurrent_bidi_paragraph_direction): If Vpurify_flag is non-nil,
1500 return Qleft_to_right.
1501
49745b39
CY
15022011-11-06 Chong Yidong <cyd@gnu.org>
1503
1504 * window.c (Fwindow_live_p, Fwindow_frame, Fframe_root_window)
1505 (Fminibuffer_window, Fwindow_buffer, Fwindow_splits)
1506 (Fset_window_splits, Fwindow_nest, Fset_window_nest)
1507 (Fwindow_use_time, Fwindow_total_size, Fwindow_normal_size)
1508 (Fwindow_new_normal, Fwindow_left_column, Fwindow_top_line)
1509 (Fwindow_margins, Fwindow_fringes, Fwindow_scroll_bars)
1510 (Fwindow_vscroll): Doc fix.
1511 (Fwindow_top_child, Fwindow_left_child): Eliminate a nil default
1512 argument, since it makes no sense to pass a live window and for
1513 consistency with window-child.
1514
1f05cd82
CS
15152011-11-05 Christoph Scholtes <cschol2112@googlemail.com>
1516
1517 * makefile.w32-in ($(TEMACS), (gl-stamp)): Use $(THISDIR) to
1518 support MSVC.
1519
22610910
JR
15202011-11-05 Jason Rumney <jasonr@gnu.org>
1521
1522 * w32font.c (font_matches_spec): Filter out non-Japanese kana fonts.
1523 (add_font_entity_to_list): Filter out non-Japanese Shift-JIS
1524 fonts (Bug#6029).
1525 (add_font_entity_to_list): Fix logic errors in mixed boolean and
1526 bitwise arithmetic preventing use of unicode-sip and non-truetype
1527 opentype fonts.
1528
a06776b2
EZ
15292011-11-05 Eli Zaretskii <eliz@gnu.org>
1530
3ad924ba
EZ
1531 * s/ms-w32.h (fstat, stat, utime): Move redirections to
1532 "emacs"-only part.
1533
a06776b2
EZ
1534 * w32fns.c (x_create_tip_frame, Fx_create_frame): Rearrange
1535 initialization code to keep similarity to xfns.c after changes
1536 from 2011-11-05.
1537
c9e7db78
JD
15382011-11-05 Jan Djärv <jan.h.d@swipnet.se>
1539
a97f8f3f
JD
1540 * nsfns.m: Declare image_cache_refcount if GLYPH_DEBUG.
1541 (unwind_create_frame): New function (Bug#9943).
1542 (Fx_create_frame): Restructure code to be more similar to the one in
1543 xfns.c. Call record_unwind_protect with unwind_create_frame (Bug#9943).
1544 Initialize image_cache_refcount if GLYPH_DEBUG (Bug#9943).
1545 Move terminal->reference_count++ just before making the frame official
1546 (Bug#9943).
1547
1548 * nsterm.m (x_free_frame_resources): New function.
1549 (x_destroy_window): Move code to x_free_frame_resources.
1550
c9e7db78 1551 * xfns.c (unwind_create_frame): Fix comment.
6d5eb5b0
SM
1552 (Fx_create_frame, x_create_tip_frame):
1553 Move terminal->reference_count++ just before making the frame
c9e7db78
JD
1554 official. Move initialization of image_cache_refcount and
1555 dpyinfo_refcount before calling init_frame_faces (Bug#9943).
1556
a6fc3b5c
EZ
15572011-11-05 Eli Zaretskii <eliz@gnu.org>
1558
1559 Support MSVC build with newer versions of Visual Studio.
1560 * makefile.w32-in (TAGS-gmake): Don't use $(patsubst ...), as
1561 Nmake barfs on that. Use $(OBJ*_c) variables instead, defined on
1562 nt/gmake.defs.
1563
1564 * lisp.h (ENUM_BF): New macro, for enumerated types in bitfields,
1565 which are not supported by MSVC.
1566 (Lisp_Symbol, Lisp_Misc_Any, Lisp_Marker, Lisp_Misc_Overlay)
1567 (Lisp_Save_Value, Lisp_Free): Use ENUM_BF for enumerated types in
1568 bitfields.
1569 (Lisp_Object) [USE_LISP_UNION_TYPE]: Use ENUM_BF for enumerated
1570 types in bitfields.
1571 (DEFUN) [_MSC_VER]: Define in a different way for MSVC.
1572
1573 * w32fns.c [_MSC_VER]: DECLARE_HANDLE for any MSVC version.
1574
58179cce 15752011-11-05 Fabrice Popineau <fabrice.popineau@supelec.fr> (tiny change)
a6fc3b5c
EZ
1576
1577 Support MSVC build with newer versions of Visual Studio.
1578 * w32.c: Don't include w32api.h for MSVC.
1579 (init_environment) [_MSC_VER]: Call sys_access, not _access.
1580
1581 * s/ms-w32.h <sigset_t, ssize_t> [_MSC_VER]: Typedefs for MSVC.
1582 [_MSC_VER]: Include sys/timeb.h, sys/stat.h, and signal.h.
1583 (fstat, stat, utime) [_MSC_VER]: Redirect to their sys_* cousins.
1584 (malloc, free, realloc, calloc) [_MSC_VER]: Always redirect to the
1585 e_* cousins.
1586 (alloca) [_MSC_VER]: Define to _alloca.
1587
1588 * lisp.h (DECL_ALIGN) [_MSC_VER]: Define for MSVC.
1589
1590 * regex.c <re_char> [_MSC_VER]: A separate definition for MSVC.
1591
a58c13ed
EZ
15922011-11-04 Eli Zaretskii <eliz@gnu.org>
1593
1594 * xdisp.c (note_mouse_highlight): If either of
1595 previous/next-single-property-change returns nil, treat that as
1596 the beginning or the end of the buffer. (Bug#9955)
1597
fe0b6370
JD
15982011-11-04 Jan Djärv <jan.h.d@swipnet.se>
1599
a58c13ed 1600 * gtkutil.c (xg_make_tool_item): Add callbacks if one of wimage or
fe0b6370
JD
1601 label is not null (Bug#9951).
1602 (xg_tool_item_stale_p): Handle the fact that wimage and/or wlbl
1603 may be NULL.
1604
89bd5ee1
EZ
16052011-11-04 Eli Zaretskii <eliz@gnu.org>
1606
1607 * window.c (Fwindow_body_size): Mention in the doc string that the
1608 return value is in frame's canonical units. (Bug#9949)
1609
84c3edb9
EZ
16102011-11-03 Eli Zaretskii <eliz@gnu.org>
1611
4e2fb5c7
EZ
1612 * xdisp.c (note_mouse_highlight): Initialize `area'. (Bug#9947)
1613
84c3edb9 1614 * w32fns.c (unwind_create_frame): If needed, free the glyph
3ab15fd6 1615 matrices of the partially constructed frame. (Bug#9943)
2a58bbc1 1616 * xfns.c (unwind_create_frame): Likewise.
84c3edb9 1617
bc17a887
EZ
16182011-11-01 Eli Zaretskii <eliz@gnu.org>
1619
1620 * xdisp.c (mouse_face_from_buffer_pos): Fix a typo in a comment.
1621 Don't stop backward scan on the continuation glyph, even though
1622 its CHARPOS is positive.
6d5eb5b0
SM
1623 (mouse_face_from_buffer_pos, note_mouse_highlight):
1624 Rename cover_string to disp_string.
bc17a887 1625
4ee88440
MR
16262011-11-01 Martin Rudalics <rudalics@gmx.at>
1627
1628 * window.c (temp_output_buffer_show): Don't use
1629 Vtemp_buffer_show_specifiers.
1630 (Vtemp_buffer_show_specifiers): Remove unused variable.
1631
c2ff3c02
EZ
16322011-10-30 Eli Zaretskii <eliz@gnu.org>
1633
1634 * xdisp.c (try_cursor_movement): Make sure ROW isn't decremented
1635 past the beginning of the current glyph matrix.
1636
58179cce 16372011-10-30 Adam Sjøgren <asjo@koldfront.dk> (tiny change)
6e56383b
JD
1638
1639 * xterm.c: Include X11/Xproto.h if HAVE_GTK3.
1640 (x_error_handler): Ignore BadMatch for X_SetInputFocus for
1641 HAVE_GTK3 (Bug#9869).
b77a6a7f 1642
3b574623
JD
1643 * gtkutil.c (xg_win_to_widget, xg_event_is_for_menubar): Initialize
1644 type to GDK_NOTHING so valgrind does not complain (Bug#9901).
1645
b77a6a7f
JD
1646 * xterm.h (x_display_info): Add Xatom_net_wm_state_hidden (Bug#9893).
1647
1648 * xterm.c: Declare x_handle_net_wm_state to return int.
1649 (handle_one_xevent): Check if we are iconified but don't have
1650 _NET_WM_STATE_HIDDEN. If do, treat as deiconify (Bug#9893).
1651 (get_current_wm_state): Return non-zero if not hidden,
1652 check for _NET_WM_STATE_HIDDEN (Bug#9893).
1653 (do_ewmh_fullscreen): Ignore return value from get_current_wm_state.
1654 (x_handle_net_wm_state): Return what get_current_wm_state returns.
1655 (x_term_init): Initialize dpyinfo->Xatom_net_wm_state_hidden.
1656
196e41e4
PE
16572011-10-29 Paul Eggert <eggert@cs.ucla.edu>
1658
1659 * alloc.c (which_symbols): Declare EXTERNALLY_VISIBLE,
1660 so that this new function doesn't get optimized away by a
1661 whole-program optimizer. Make the 2nd arg EMACS_INT, not int.
1662
021f2e1a
AS
16632011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1664
1665 * frame.h (MOUSE_HL_INFO): Remove excess parens.
1666
8b058d44
EZ
16672011-10-29 Eli Zaretskii <eliz@gnu.org>
1668
1669 Fix the `xbytecode' command.
1670 * .gdbinit (xprintbytestr): New command.
b50a28de 1671 (xwhichsymbols): Rename from `which'; all callers changed.
8b058d44
EZ
1672 (xbytecode): Print the byte-code string as well.
1673
4452fb80
EZ
16742011-10-29 Kim Storm <storm@cua.dk>
1675
8b058d44
EZ
1676 * alloc.c (which_symbols): New function.
1677
21b72067
AS
16782011-10-29 Andreas Schwab <schwab@linux-m68k.org>
1679
1680 * minibuf.c (read_minibuf_noninteractive): Allow reading empty
1681 line. (Bug#9903)
1682
83ed7b5c
GM
16832011-10-29 Glenn Morris <rgm@gnu.org>
1684
1685 * process.c (wait_reading_process_output): Revert 2009-08-30 change.
1686 Not clear what it was for, and it causes various bugs. (Bug#9839)
1687
5a7a728b
EZ
16882011-10-28 Eli Zaretskii <eliz@gnu.org>
1689
1690 * xdisp.c (note_mouse_highlight): Initialize `part', to avoid a
1691 possible random value that matches one of those tested as
1692 condition to clear the mouse face.
1693
d3d0842f
CY
16942011-10-28 Chong Yidong <cyd@gnu.org>
1695
1696 * xdisp.c (note_mouse_highlight): Fix use of uninitialized var.
1697
31b39d13
DN
16982011-10-28 Dan Nicolaescu <dann@ics.uci.edu>
1699
1700 * window.c (make_window): Initialize phys_cursor_on_p.
1701
9aba6043
SM
17022011-10-28 Stefan Monnier <monnier@iro.umontreal.ca>
1703
1704 * lisp.h (struct Lisp_Symbol): Update comments.
1705
c20992f4
JB
17062011-10-28 Juanma Barranquero <lekktu@gmail.com>
1707
1708 * w32font.c (w32_load_unicows_or_gdi32): Add missing return.
1709
db4f02f2
EZ
17102011-10-28 Eli Zaretskii <eliz@gnu.org>
1711
1712 Fix Emacs on Windows 9X (bug#8562). Thanks to oslsachem
1713 <oslsachem@gmail.com> for helping to debug this.
1714
1715 * w32font.c (g_b_init_is_w9x, g_b_init_get_outline_metrics_w)
1716 (g_b_init_get_text_metrics_w, g_b_init_get_glyph_outline_w)
1717 (g_b_init_get_glyph_outline_w): New static variables.
1718 (GetOutlineTextMetricsW_Proc, GetTextMetricsW_Proc)
1719 (GetGlyphOutlineW_Proc): New typedefs.
1720 (w32_load_unicows_or_gdi32, get_outline_metrics_w)
9aba6043
SM
1721 (get_text_metrics_w, get_glyph_outline_w, globals_of_w32font):
1722 New functions.
1723 (w32font_open_internal, compute_metrics):
1724 Call get_outline_metrics_w, get_text_metrics_w, and get_glyph_outline_w
db4f02f2
EZ
1725 instead of calling the "wide" APIs directly.
1726
1727 * emacs.c (main) [HAVE_NTGUI]: Call globals_of_w32font.
1728
1729 * w32.h (syms_of_w32font): Add prototype.
1730
87e68db4
JB
17312011-10-27 Juanma Barranquero <lekktu@gmail.com>
1732
1733 * window.c (Fframe_root_window, Fframe_first_window, Fwindow_end)
1734 (Fframe_selected_window, Ftemp_output_buffer_show, Fnext_window)
1735 (Fdelete_window_internal, Fwindow_parameters): Fix typos in docstrings.
1736 (Fmove_to_window_line): Doc fix.
1737
435c1d67
CY
17382011-10-27 Chong Yidong <cyd@gnu.org>
1739
1740 * process.c (make_process): Set gnutls_state to NULL.
1741
1742 * gnutls.c (emacs_gnutls_deinit): Deinit the gnutls_state if it is
1743 non-NULL, regardless of GNUTLS_INITSTAGE.
1744 (Fgnutls_boot): Cleanups. Call emacs_gnutls_deinit if we signal
1745 an error. Set process slots as soon as we allocate them.
1746
1747 * gnutls.h (GNUTLS_LOG, GNUTLS_LOG2): Fix macros.
1748
9c6c6f49
CY
17492011-10-27 Chong Yidong <cyd@gnu.org>
1750
9aba6043
SM
1751 * gnutls.c (emacs_gnutls_deinit): New function.
1752 Deallocate credentials structures as well as calling gnutls_deinit.
9c6c6f49
CY
1753 (Fgnutls_deinit, Fgnutls_boot): Use it.
1754
1755 * process.c (make_process): Initialize GnuTLS credentials to NULL.
1756 (deactivate_process): Call emacs_gnutls_deinit.
1757
657d08d3
JB
17582011-10-27 Juanma Barranquero <lekktu@gmail.com>
1759
1760 * image.c (x_create_x_image_and_pixmap):
1761 * w32.c (sys_rename, w32_delayed_load):
1762 * w32font.c (fill_in_logfont):
1763 * w32reg.c (x_get_string_resource): Silence compiler warnings.
1764
5430d399
JB
17652011-10-26 Juanma Barranquero <lekktu@gmail.com>
1766
1767 * w32fns.c (w32_default_color_map): New function,
1768 extracted from Fw32_default_color_map.
a7ef684b 1769 (Fw32_default_color_map, Fx_open_connection): Use it. (Bug#9785)
5430d399 1770
fe0055fa
PE
17712011-10-25 Paul Eggert <eggert@cs.ucla.edu>
1772
1773 * dispextern.h (Fcontrolling_tty_p): New decl (Bug#6649 part 2).
1774
e6346438
SM
17752011-10-25 Stefan Monnier <monnier@iro.umontreal.ca>
1776
1777 * keyboard.c (test_undefined): New function (bug#9751).
1778 (read_key_sequence): Use it to detect when a key is bound to `undefined'.
1779
e112cc37
ET
17802011-10-25 Enami Tsugutomo <tsugutomo.enami@jp.sony.com>
1781
1782 * sysdep.c (init_sys_modes): Fix the check for the controlling
1783 terminal (Bug#6649).
1784
7b5d6677
EZ
17852011-10-20 Eli Zaretskii <eliz@gnu.org>
1786
1787 * dispextern.h (struct bidi_it): New member next_en_type.
1788
1789 * bidi.c (bidi_line_init): Initialize the next_en_type member.
1790 (bidi_resolve_explicit_1): When next_en_pos is valid for the
1791 current character, check also for next_en_type being WEAK_EN.
1792 (bidi_resolve_weak): Don't enter the expensive loop if the current
1793 position is before next_en_pos. Record the bidi type of the first
1794 non-ET, non-BN character we find, in addition to its position.
1795 (bidi_level_of_next_char): Invalidate next_en_type when
1796 next_en_pos is over-stepped.
1797
7da0b018
PE
17982011-10-20 Paul Eggert <eggert@cs.ucla.edu>
1799
1800 Time zone name fixes for non-ASCII locales (Bug#641, Bug#9794)
1801 * editfns.c: Rewrite current-time-zone so that it invokes
1802 the equivalent of (format-time-string "%Z") to get the time zone name.
1803 This fixes a bug when the time zone name contains characters that
1804 need converting from the system time locale to Emacs internal format.
1805 This fixes a shortcoming that I introduced in my 1999-10-19 patch:
1806 that patch fixed format-time-string to do the conversion, but
1807 I forgot to fix current-time-zone.
1808 (format_time_string): New function, containing most of
1809 what Fformat_time_string used to contain.
1810 (Fformat_time_string): Rewrite in terms of format_time_string.
1811 This doesn't change this function's behavior.
1812 (current-time-zone): Rewrite to use format_time_string.
1813 This fixes the bug reported by Michael Schierl in
1814 <http://lists.gnu.org/archive/html/emacs-devel/2007-06/msg00334.html>.
1815 Jason Rumney's 2007-06-07 change worked around this bug, but
1816 didn't fix it.
1817 * systime.h (tzname, timezone): Remove no-longer-used declarations.
1818
8547b010
EZ
18192011-10-19 Eli Zaretskii <eliz@gnu.org>
1820
1821 * xdisp.c (start_display): If the character at POS is displayed
1822 via a display vector, reset IT->current.dpvec_index to zero.
12b32963
EZ
1823 (try_window_reusing_current_matrix): If a line ends in a display
1824 vector or the next line starts in a display vector, continue
1825 redrawing the window even though the character position of
1826 start_row was reached.
8547b010
EZ
1827 (Bug#9771, part 2)
1828
4e948d15
CY
18292011-10-18 Chong Yidong <cyd@gnu.org>
1830
1831 * xdisp.c (get_next_display_element): Handle U+2010 and U+2011
1832 with nobreak-char-display too.
1833
4787455f
EZ
18342011-10-18 Eli Zaretskii <eliz@gnu.org>
1835
1836 Fix part 3 of bug#9771.
1837 * bidi.c (bidi_line_init): Initialize next_en_pos to zero, not -1.
1838 (bidi_resolve_neutral): Don't enter the expensive loop looking for
1839 non-neutral characters if the current character is a paragraph
1840 separator (a.k.a. Newline). This avoids running the same
1841 expensive loop twice, once when we consume the preceding newline
1842 and the other time when the line actually needs to be displayed.
1843 Avoid the loop when we see neutrals on the base embedding level
1844 following a character whose directionality is the same as the
1845 paragraph's. This avoids running the expensive loop when a line
1846 ends in a long sequence of neutrals, like control characters.
1847 Add assertion against STRONG_AL type. Slightly rearrange code
1848 that determines the type of a neutral given the first non-neutral
1849 that follows it.
1850 (bidi_level_of_next_char): Set next_en_pos to zero when
1851 invalidating its info.
1852
2c91f553
EZ
18532011-10-17 Eli Zaretskii <eliz@gnu.org>
1854
1855 * xdisp.c (push_display_prop): Determine whether to record string
1856 or buffer position by IT->string, not by IT->method. Allow
1857 GET_FROM_DISPLAY_VECTOR as IT->method on entry. (Bug#9771, part 4)
f2ff9e88
EZ
1858 (move_it_vertically_backward): Don't look for character position
1859 immediately after the newline when in a continuation line.
1860 (Bug#9771, part 1)
2c91f553 1861
c7b08b0d
MR
18622011-10-15 Martin Rudalics <rudalics@gmx.at>
1863
1864 * window.c (coordinates_in_window): Rewrite and delabelize
1865 vertical border check. (Bug#5357) (Bug#9618)
1866
6b02f655
SM
18672011-10-14 Stefan Monnier <monnier@iro.umontreal.ca>
1868
1869 * xterm.c (frame_highlight, frame_unhighlight): Ignore unexplained
1870 errors in XSetWindowBorder (bug#9310).
1871
81d40c92
DA
18722011-10-13 Dmitry Antipov <dmantipov@yandex.ru>
1873
1874 * editfns.c (Fset_time_zone_rule): Replace free with xfree to
1875 avoid crash when xmalloc overrun checking is enabled.
1876
d4172c3b
EZ
18772011-10-13 Eli Zaretskii <eliz@gnu.org>
1878
1879 * xdisp.c (Fcurrent_bidi_paragraph_direction): Initialize
1880 itb.paragraph_dir to NEUTRAL_DIR. Fixes an occasional incorrect
1881 cursor motion with <left> and <right> arrow keys.
1882
1883 * bidi.c (bidi_init_it): Don't initialize paragraph_dir here, as
1884 some callers set that themselves.
1885
b00eea75
EZ
18862011-10-12 Eli Zaretskii <eliz@gnu.org>
1887
1888 * xdisp.c (find_row_edges): Handle the case where ROW comes from a
1889 display string and the previous row comes from the same string and
1890 is empty. (Bug#9739) (Bug#9738)
1891
8fe012c4
SM
18922011-10-12 Stefan Monnier <monnier@iro.umontreal.ca>
1893
1894 * doc.c (get_doc_string): Encode file name (bug#9735).
1895
0074aef2
EZ
18962011-10-12 Eli Zaretskii <eliz@gnu.org>
1897
79beb178
EZ
1898 * bidi.c (bidi_level_of_next_char):
1899 * xdisp.c (get_visually_first_element): Remove old incorrect
1900 comments regarding the Unicode Line Separator character.
1901
0074aef2
EZ
1902 * bidi.c (bidi_init_it): Initialize paragraph_dir to NEUTRAL_DIR.
1903
6e4b3fbe
DA
19042011-10-12 Dmitry Antipov <dmantipov@yandex.ru>
1905
1906 * alloc.c (Fgc_status): Do not access beyond zombies array
1907 boundary if nzombies > MAX_ZOMBIES.
1908 * alloc.c (dump_zombies): Add missing format specifier.
1909
0324f3af
PE
19102011-10-12 Paul Eggert <eggert@cs.ucla.edu>
1911
b5525cac
PE
1912 * xdisp.c (set_cursor_from_row): Simplify conditionals,
1913 to pacify GCC 4.6.1 x86-64 with -O2 -Wstrict-overflow.
1914
0324f3af
PE
1915 * lread.c (read_escape): Allow hex escapes as large as ?\xfffffff.
1916 Some packages use them to denote characters with modifiers.
1917
e9b5f888
AS
19182011-10-11 Andreas Schwab <schwab@linux-m68k.org>
1919
1920 * lisp.h (GCPRO1_VAR, GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR)
1921 (GCPRO5_VAR, GCPRO6_VAR, UNGCPRO_VAR): Add whitespace to avoid
1922 matching a pp-number. Rename parameter var to var1.
1923
127827c0
SM
19242011-10-11 Stefan Monnier <monnier@iro.umontreal.ca>
1925
1926 * minibuf.c (Finternal_complete_buffer): Fix last change (bug#9709).
1927
c8fd3bd0
GM
19282011-10-08 Glenn Morris <rgm@gnu.org>
1929
1930 * callint.c (Fcall_interactively): Give a more explicit error for the
1931 'c' case with a non-character input. (Bug#8479)
1932
352ec8ff
EZ
19332011-10-08 Eli Zaretskii <eliz@gnu.org>
1934
03669ccb
EZ
1935 * xdisp.c (hscroll_window_tree): Support hscroll in right-to-left
1936 lines.
7061c986
EZ
1937 (set_cursor_from_row): Fix cursor positioning in mixed L2R+R2L
1938 lines that are hscrolled on the left.
03669ccb 1939
352ec8ff
EZ
1940 * dispnew.c (buffer_posn_from_coords): Account for a possible
1941 presence of header-line. (Bug#4426)
1942
a66cfb1c
SM
19432011-10-07 Stefan Monnier <monnier@iro.umontreal.ca>
1944
6b02f655
SM
1945 * buffer.c (syms_of_buffer) <enable-multibyte-characters>:
1946 Don't advertise functionality which we discourage or doesn't work.
a66cfb1c 1947
7c5ee88e
PE
19482011-10-07 Paul Eggert <eggert@cs.ucla.edu>
1949
1950 * alloc.c (GC_LISP_OBJECT_ALIGNMENT): Use offsetof, not __alignof__
1951 or sizeof. __alignof__ gives the wrong answer on Fedora x86-64
1952 with GCC 4.6.1 when configured with CC='gcc -m32' --with-wide-int;
1953 this makes Emacs dump core during garbage collection on rare
1954 occasions. sizeof is obviously inferior to offsetof here, so
1955 stick with offsetof.
1956 (GC_POINTER_ALIGNMENT): New macro.
1957 (mark_memory): Omit 3rd (offset) arg; caller changed.
1958 Don't assume EMACS_INT alignment is the same as pointer alignment.
1959
df1bbe5b
SM
19602011-10-03 Stefan Monnier <monnier@iro.umontreal.ca>
1961
1962 * keyboard.c (read_key_sequence_remapped): New var.
1963 (read_key_sequence): Compute remapping in the right buffer.
1964 (command_loop_1): Use read_key_sequence's remapping directly.
1965
51553db6
SM
19662011-10-02 Stefan Monnier <monnier@iro.umontreal.ca>
1967
32c1fffd
SM
1968 * dired.c (file_name_completion): Don't expand file name.
1969 (Ffile_name_completion, Ffile_name_all_completions): Expand file name
1970 before checking file name handler.
1971
51553db6
SM
1972 * minibuf.c (Finternal_complete_buffer): Only show internal buffers if
1973 they've been requested explicitly (bug#9591).
1974
b6bd1599 19752011-10-01 Andreas Schwab <schwab@linux-m68k.org>
fa2ec41f
AS
1976
1977 * keymap.c (Fsingle_key_description): Use make_specified_string
1978 instead of build_string to build string from push_key_description.
1979 (Bug#5193)
1980
f701dc2a
PE
19812011-09-30 Paul Eggert <eggert@cs.ucla.edu>
1982
4222c55d
PE
1983 * buffer.h (struct buffer): Use time_t, not int, for a time stamp.
1984 This fixes a Y2038 bug on 64-bit hosts.
1985 * buffer.c (reset_buffer):
1986 * fileio.c (Fdo_auto_save, Fset_buffer_auto_saved)
1987 (Fclear_buffer_auto_save_failure):
1988 Use 0, not -1, to represent an unset failure time, since time_t
1989 might not be signed.
1990
f701dc2a
PE
1991 Remove dependency on glibc malloc internals.
1992 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
1993 Move back here from lisp.h, but with their new implementations.
1994 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
1995 (XMALLOC_OVERRUN_SIZE_SIZE): Move these new lisp.h macros here.
1996 * charset.c (charset_table_init): New static var.
1997 (syms_of_charset): Use it instead of xmalloc. This removes a
1998 dependency on glibc malloc internals. See Eli Zaretskii's comment in
1999 <http://lists.gnu.org/archive/html/emacs-devel/2011-09/msg00815.html>.
2000 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2001 Move back to alloc.c.
2002 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2003 (XMALLOC_OVERRUN_SIZE_SIZE): Move to alloc.c.
2004
9ceebf39
JD
20052011-09-30 Jan Djärv <jan.h.d@swipnet.se>
2006
2007 * nsterm.m (windowDidResize): Call x_set_window_size only when
2008 ns_in_resize is true. Otherwise set pixelwidth/height and
2009 call change_frame_size (Bug#9628).
2010
cb993c58
PE
20112011-09-30 Paul Eggert <eggert@cs.ucla.edu>
2012
3930c88b
PE
2013 Port --enable-checking=all to Fedora 14 x86-64.
2014 * charset.c (syms_of_charset): Also account for glibc malloc's
2015 internal overhead when calculating the initial malloc maximum.
2016
cb993c58
PE
2017 Port --enable-checking=all to Fedora 14 x86.
2018 * alloc.c (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2019 Move to lisp.h.
2020 (xmalloc_put_size, xmalloc_get_size, overrun_check_malloc)
2021 (overrun_check_realloc, overrun_check_free):
2022 Use XMALLOC_OVERRUN_SIZE_SIZE, not sizeof (size_t).
2023 That way, xmalloc returns a properly-aligned pointer even if
2024 XMALLOC_OVERRUN_CHECK is defined. The old debugging code happened
2025 to align OK on typical 64-bit hosts, but not on Fedora 14 x86.
2026 * charset.c (syms_of_charset): Take XMALLOC_OVERRUN_CHECK_OVERHEAD
2027 into account when calculating the initial malloc maximum.
2028 * lisp.h (XMALLOC_OVERRUN_CHECK_OVERHEAD, XMALLOC_OVERRUN_CHECK_SIZE):
2029 Move here from alloc.c, so that charset.c can use it too.
2030 Properly align; the old code wasn't right for common 32-bit hosts
2031 when configured with --enable-checking=all.
2032 (XMALLOC_BASE_ALIGNMENT, COMMON_MULTIPLE, XMALLOC_HEADER_ALIGNMENT)
2033 (XMALLOC_OVERRUN_SIZE_SIZE): New macros.
2034
31bed486
EZ
20352011-09-29 Eli Zaretskii <eliz@gnu.org>
2036
04c70788 2037 * sysdep.c (snprintf) [!EOVERFLOW]: If EOVERFLOW is not defined,
31bed486
EZ
2038 use EDOM.
2039
fbcaa2f3
EZ
20402011-09-28 Eli Zaretskii <eliz@gnu.org>
2041
2042 * xdisp.c (compute_display_string_end): If there's no display
2043 string at CHARPOS, return -1.
2044
2045 * bidi.c (bidi_fetch_char): When compute_display_string_end
2046 returns a negative value, treat the character as a normal
2047 character not covered by a display string. (Bug#9624)
2048
a239d4e9
JB
20492011-09-28 Juanma Barranquero <lekktu@gmail.com>
2050
2051 * lread.c (Fread_from_string): Fix typo in docstring.
2052
88652fd5
EZ
20532011-09-27 Eli Zaretskii <eliz@gnu.org>
2054
2055 * xdisp.c (handle_invisible_prop): If invisible text ends on a
2056 newline, reseat the iterator instead of bidi-iterating there one
2057 character at a time. (Bug#9610)
32c1fffd
SM
2058 (BUFFER_POS_REACHED_P, move_it_in_display_line_to): Bail when past
2059 TO_CHARPOS if the bidi iterator is at base embedding level.
88652fd5 2060
ed497dd4
AS
20612011-09-27 Andreas Schwab <schwab@linux-m68k.org>
2062
2063 * lread.c (readevalloop): Use correct code for NBSP.
2064 (read1): Likewise. (Bug#9608)
2065
b2bf61aa
MA
20662011-09-25 Michael Albinus <michael.albinus@gmx.de>
2067
2068 * dbusbind.c (Fdbus_register_signal): When service is not
2069 registered, use nil in Vdbus_registered_objects_table. (Bug#9581)
2070
32bbb17c
GM
20712011-09-25 Glenn Morris <rgm@gnu.org>
2072
2073 * buffer.c (truncate-lines): Doc fix.
2074
94e0933e
CY
20752011-09-24 Chong Yidong <cyd@stupidchicken.com>
2076
2077 * window.c (Fwindow_prev_buffers, Fset_window_prev_buffers)
2078 (Fset_window_next_buffers): Doc fix.
2079
cddde921
GM
20802011-09-24 Glenn Morris <rgm@gnu.org>
2081
2082 * minibuf.c (read_minibuf): Disable line truncation. (Bug#5715)
2083
1260aef1
PE
20842011-09-24 Paul Eggert <eggert@cs.ucla.edu>
2085
25b4bfa0
PE
2086 Fix minor problems found by static checking.
2087 * xdisp.c (string_from_display_spec): Don't assume vecsize fits in int.
1260aef1
PE
2088 * indent.c (Fvertical_motion): Fix == vs = typo.
2089
e3cbd34b
EZ
20902011-09-24 Eli Zaretskii <eliz@gnu.org>
2091
a66cfb1c
SM
2092 * dispnew.c (syms_of_display) <redisplay-dont-pause>:
2093 Default value is now t. Doc fix.
6bf7006f 2094
e3cbd34b 2095 * indent.c (Fvertical_motion): Compute and apply the overshoot
32c1fffd 2096 logic when moving up, not only when moving down. Fix the
e3cbd34b 2097 confusing name and values of the it_overshoot_expected variable;
32c1fffd 2098 logic changes accordingly. (Bug#9254) (Bug#9549)
e3cbd34b
EZ
2099
2100 * xdisp.c (pos_visible_p): Produce correct pixel coordinates when
2101 CHARPOS is covered by a display string which includes newlines.
2102 (move_it_vertically_backward): Avoid inflooping when START_CHARPOS
2103 is covered by a display string with embedded newlines.
2104
a3de0cbd
MA
21052011-09-24 Michael Albinus <michael.albinus@gmx.de>
2106
2107 * dbusbind.c (Fdbus_register_signal): Add match rule to
2108 Vdbus_registered_objects_table. (Bug#9581)
a66cfb1c
SM
2109 (Fdbus_register_method, Vdbus_registered_objects_table):
2110 Fix docstring.
a3de0cbd 2111
b260039d
JM
21122011-09-24 Jim Meyering <meyering@redhat.com>
2113
32c1fffd 2114 do not ignore write error for any output size
b260039d
JM
2115 The previous change was incomplete.
2116 While it makes emacs --batch detect the vast majority of stdout
2117 write failures, errors were still ignored whenever the output size is
2118 k * (BUFSIZ+1) - 4. E.g., on a system with BUFSIZ of 4096,
2119 $ emacs --batch --eval '(print (format "%4093d" 0))' > /dev/full \
2120 && echo FAIL: ignored write error
2121 FAIL: ignored write error
2122 $ emacs --batch --eval '(print (format "%20481d" 0))' > /dev/full \
2123 && echo FAIL: ignored write error
2124 FAIL: ignored write error
2125 * emacs.c (Fkill_emacs): Also test ferror. (Bug#9574)
2126
8eca8a7c
AS
21272011-09-23 Andreas Schwab <schwab@linux-m68k.org>
2128
2129 * emacs.c (Fkill_emacs): In noninteractive mode exit
2130 non-successfully if a write error occurred on stdout. (Bug#9574)
2131
3341db62
EZ
21322011-09-21 Eli Zaretskii <eliz@gnu.org>
2133
2134 * xdisp.c (pop_it): Allow it->object that is a cons cell to pass
2135 the xassert test.
2136
2137 * dispextern.h (struct it): Update the comment documenting what
2138 can it->OBJECT be.
2139
8c203dbf
EZ
21402011-09-20 Eli Zaretskii <eliz@gnu.org>
2141
2142 * xdisp.c (set_cursor_from_row): If the row ends in a newline from
2143 a display string, extend search for cursor position to end of row.
2144 (find_row_edges): If the row ends in a newline from a display
2145 string, increment its MATRIX_ROW_END_CHARPOS by one. (Bug#9549)
2146 Handle the case of a display string with multiple newlines.
fd317ddf
EZ
2147 (Fcurrent_bidi_paragraph_direction): Fix search for previous
2148 non-empty line. Fixes confusing cursor motion with arrow keys at
2149 the beginning of a line that starts with whitespace.
8c203dbf 2150
a4824228
LMI
21512011-09-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
2152
2153 * lread.c (Fread_from_string): Document what FINAL-STRING-INDEX is
2154 (bug#9493).
2155
33ed493b
CY
21562011-09-18 Chong Yidong <cyd@stupidchicken.com>
2157
2158 * xfns.c (Fx_create_frame): Handle the bitmapIcon resource as
2159 boolean (Bug#9154).
2160
56cd55c8
EZ
21612011-09-18 Eli Zaretskii <eliz@gnu.org>
2162
2163 * xdisp.c (display_line): Record maximum and minimum buffer
2164 positions even if no glyphs were produced (e.g., by a zero-width
2165 stretch). Fixes bug#9530 on a TTY. Under word-wrap, don't record
2166 buffer positions that will be removed from the glyph row because
2167 they don't fit.
c02dcedf
EZ
2168 (produce_stretch_glyph): Fix a bug in :align-to on a TTY when the
2169 column is beyond frame width: don't subtract 1 "pixel" when
2170 computing width of the stretch.
3e62b7e0
EZ
2171 (reseat_at_next_visible_line_start): Undo the change made on
2172 2011-09-17 that saved paragraph information and restored it after
2173 the call to `reseat'. (Bug#9545)
56cd55c8 2174
5ed99d36 21752011-09-18 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
3390454c
YM
2176
2177 * xdisp.c (expose_window): Save original value of phys_cursor_on_p
2178 and turn window cursor on if cleared (Bug#9415).
2179
5ed99d36 21802011-09-18 Andreas Schwab <schwab@linux-m68k.org>
edb7b4dc
AS
2181
2182 * search.c (boyer_moore): Take unibyte characters from pattern
2183 literally. (Bug#9458)
2184
9bade7b2
EZ
21852011-09-18 Eli Zaretskii <eliz@gnu.org>
2186
2187 * xdisp.c (reseat_at_next_visible_line_start): Fix last change.
2188
e5e9d610
PE
21892011-09-18 Paul Eggert <eggert@cs.ucla.edu>
2190
87e4427a
PE
2191 Fix minor problem found by static checking.
2192 * xdisp.c (reseat_at_next_visible_line_start): Mark locals as
2193 initialized, to pacify gcc -Wuninitialized.
2194
e5e9d610
PE
2195 * fileio.c: Report proper errno when syscall falls.
2196 (Finsert_file_contents): Save and restore errno,
2197 so that report_file_error outputs the correct diagnostic.
2198 (Fwrite_region) [CLASH_DETECTION]: Likewise.
2199
a1674f0b
EZ
22002011-09-18 Eli Zaretskii <eliz@gnu.org>
2201
2202 * .gdbinit (pgx): Fix references to fields of `struct glyph'.
2203
fbfb6dd4
EZ
22042011-09-17 Eli Zaretskii <eliz@gnu.org>
2205
2206 * xdisp.c (produce_stretch_glyph): Another fix for changes made on
2207 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9530)
2208
bb187662
EZ
22092011-09-17 Eli Zaretskii <eliz@gnu.org>
2210
1137e8b8 2211 * xdisp.c (reseat_at_next_visible_line_start): Keep information
6b02f655 2212 about the current paragraph and restore it after the call to reseat.
1137e8b8
EZ
2213
2214 * bidi.c (MAX_PARAGRAPH_SEARCH): New macro.
2215 (bidi_find_paragraph_start): Search back for paragraph beginning
2216 at most MAX_PARAGRAPH_SEARCH lines; if not found, return BEGV_BYTE.
2217 (bidi_move_to_visually_next): Only trigger paragraph-related
2218 computations when the last character is a newline or at EOB, not
2219 just any NEUTRAL_B. (Bug#9470)
2220
bb187662
EZ
2221 * xdisp.c (set_cursor_from_row): Don't invoke special treatment of
2222 truncated lines if point is covered by a display string. (Bug#9524)
2223
2e621251
PE
22242011-09-16 Paul Eggert <eggert@cs.ucla.edu>
2225
2226 * xselect.c: Relax test for outgoing X longs (Bug#9498).
2227 (cons_to_x_long): New function.
2228 (lisp_data_to_selection_data): Use it. Correct the test for
2229 short-versus-long data; it was negated. Break out of vector
2230 loop, for efficiency, when a long datum is discovered.
2231
91a15bc6
SM
22322011-09-16 Stefan Monnier <monnier@iro.umontreal.ca>
2233
2234 * eval.c (Fquote): Document its non-consing behavior (bug#9482).
2235
b41c3a35
EZ
22362011-09-16 Eli Zaretskii <eliz@gnu.org>
2237
2238 * image.c (tiff_handler): Work around a bug in MinGW GCC 3.x (see
2239 GCC PR/17406) by declaring this function with external scope.
2240
7812ba2d
PE
22412011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2242
2243 * editfns.c (Fformat): Fix bug in text-property fix (Bug#9514).
2244 Don't mishandle (length (format "%%")) and (format "%4000s%%" "").
2245
cf7edc2a
AS
22462011-09-15 Andreas Schwab <schwab@linux-m68k.org>
2247
2248 * editfns.c (Fformat): Correctly handle text properties on "%%".
2249
bd01620e
EZ
22502011-09-15 Eli Zaretskii <eliz@gnu.org>
2251
2252 * xterm.c (x_draw_composite_glyph_string_foreground):
2253 * w32term.c (x_draw_composite_glyph_string_foreground):
2254 * term.c (encode_terminal_code):
2255 * composite.c (composition_update_it, get_composition_id):
2256 * xdisp.c (get_next_display_element)
2257 (fill_composite_glyph_string): Add comments about special meaning
2258 of TAB characters in a composition.
2259
a02719a3
PE
22602011-09-15 Paul Eggert <eggert@cs.ucla.edu>
2261
2262 * editfns.c (Fformat): Fix off-by-1 bug for "%%b" (Bug#9514).
4c122725
PE
2263 This occurs when processing a multibyte format.
2264 Problem reported by Wolfgang Jenker.
a02719a3 2265
72589a3c
JB
22662011-09-15 Johan Bockgård <bojohan@gnu.org>
2267
2268 * xdisp.c (try_cursor_movement): Only check for exact match if
2269 cursor hpos found by set_cursor_from_row is valid. (Bug#9495)
2270
1c14176c
PE
22712011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2272
2273 Remove unused external symbols.
2274 * dispextern.h (calc_pixel_width_or_height): Remove decl.
2275 * xdisp.c (calc_pixel_width_or_height): Now static.
2276 * doprnt.c (exprintf) [! (HAVE_X_WINDOWS && USE_X_TOOLKIT)]: Remove.
2277 * indent.c (check_display_width):
2278 * w32term.c: Fix comment to match code.
2279 * xterm.c, xterm.h (x_catching_errors): Remove.
2280
d2eea5b5
PE
22812011-09-14 Paul Eggert <eggert@cs.ucla.edu>
2282
2283 * xselect.c: Use signed conversions more consistently (Bug#9498).
2284 (selection_data_to_lisp_data): Assume incoming selection data are
2285 signed integers, not unsigned. This is to be consistent with
2286 outgoing selection data, which was modified to use signed integers
2287 in as part of the fix to Bug#9196 in response to Jan D.'s comment
2288 in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9196#32> that X11
2289 expects long, not unsigned long.
2290
46888499
EZ
22912011-09-14 Eli Zaretskii <eliz@gnu.org>
2292
2293 * xdisp.c (try_window_reusing_current_matrix): Fix incorrect
2294 computation of loop end. Reported by Johan Bockgård
2295 <bojohan@gnu.org>.
2296
ef8ef9fb
CY
22972011-09-13 Chong Yidong <cyd@stupidchicken.com>
2298
2299 * frame.c (Fother_visible_frames_p): Function deleted.
2300
fa819fed
EZ
23012011-09-12 Eli Zaretskii <eliz@gnu.org>
2302
2303 * indent.c (compute_motion): Process display vector front to back
2304 rather than the other way around. (Bug#2496)
2305
2ba8e008
SM
23062011-09-12 Stefan Monnier <monnier@iro.umontreal.ca>
2307
2308 * fileio.c (Finsert_file_contents): Don't assume beg_offset is 0.
2309
20f53c69
CY
23102011-09-11 Chong Yidong <cyd@stupidchicken.com>
2311
2312 * minibuf.c (Fread_from_minibuffer): Doc fix.
2313
d562d7a4
EZ
23142011-09-11 Eli Zaretskii <eliz@gnu.org>
2315
2316 * xdisp.c (produce_stretch_glyph): Fix a typo made in changes from
2317 2011-08-30T17:32:44Z!eliz@gnu.org. (Bug#9475)
2318
1c4d7f3d
LMI
23192011-09-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
2320
2321 * fileio.c (Fvisited_file_modtime): Document `(-1 65535)' as a
2322 value for non-existent files.
2323
b885bf36
EZ
23242011-09-11 Eli Zaretskii <eliz@gnu.org>
2325
2326 * fileio.c (Finsert_file_contents): If the file cannot be opened,
2327 set its "size" to -1. This will set the modtime_size field of
2328 the corresponding buffer to -1, which is what
2329 verify-visited-file-modtime expects for files that do not exist.
2330 (Bug#9139)
2331
6612f0bf
PE
23322011-09-11 Paul Eggert <eggert@cs.ucla.edu>
2333
2334 * keymap.h (KEY_DESCRIPTION_SIZE, push_key_description): Move decls
2335 here ...
2336 * lisp.h: ... from here. push_key_description is no longer
2337 defined in keyboard.c, so its declaration should not be in
2338 lisp.h's "Defined in keyboard.c" section, and KEY_DESCRIPTION_SIZE
2339 logically belongs with push_key_description.
2340
dfb3f755
PE
23412011-09-10 Paul Eggert <eggert@cs.ucla.edu>
2342
2343 * buffer.h: Include <sys/types.h> instead of <time.h>.
2344 Otherwise, off_t wasn't defined on FreeBSD 9.0-BETA2 i386.
2345 Problem reported by Herbert J. Skuhra.
2346
3134906c
LMI
23472011-09-10 Lars Magne Ingebrigtsen <larsi@gnus.org>
2348
2349 * xml.c (parse_region): Make the parsing work for
2350 non-comment-starting XML files again (bug#9144).
2351
8d903f4e
AS
23522011-09-10 Andreas Schwab <schwab@linux-m68k.org>
2353
2354 * image.c (gif_load): Fix calculation of bottom and right corner.
2355 (Bug#9468)
2356
80ad64f4
EZ
23572011-09-10 Eli Zaretskii <eliz@gnu.org>
2358
2359 * xdisp.c (MAX_DISP_SCAN): Decrease to 250. Prevents sluggish
2360 redisplay in small windows.
2361
208a048d
EZ
23622011-09-09 Eli Zaretskii <eliz@gnu.org>
2363
2364 * frame.c (x_report_frame_params): Cast to avoid compiler warnings.
2365
9b1c252e
MR
23662011-09-08 Martin Rudalics <rudalics@gmx.at>
2367
2368 * window.c (Fset_window_prev_buffers, Fset_window_next_buffers):
2369 Operate on live windows only.
2370
2949f33b
JB
23712011-09-08 Juanma Barranquero <lekktu@gmail.com>
2372
2373 * emacs.c (my_heap_start): #ifdef to avoid warnings when unused.
2374
e08dcafd
EZ
23752011-09-07 Eli Zaretskii <eliz@gnu.org>
2376
2377 * xdisp.c (move_it_in_display_line_to): Call RESTORE_IT on ppos_it
2378 only under bidi iteration.
2379
115b96bd
JD
23802011-09-07 Jan Djärv <jan.h.d@swipnet.se>
2381
2382 * gtkutil.c (xg_make_tool_item): Insert comment about eventbox.
2383
c8199d0f
PE
23842011-09-06 Paul Eggert <eggert@cs.ucla.edu>
2385
2386 isnan: Fix porting problem to Solaris 10 with bundled gcc.
2387 Without this fix, the command to link temacs failed due to an
2388 undefined symbol __builtin_isnan. This is because
2389 /usr/include/iso/math_c99.h #defines isnan(x) to
2390 __builtin_isnan(x), but the bundled gcc, which identifies itself
2391 as gcc 3.4.3 (csl-sol210-3_4-branch+sol_rpath), does not have
2392 a __builtin_isnan.
2393 * floatfns.c (isnan): #undef, and then #define to a clone of
2394 what's in data.c.
2395 (Fisnan): Always define, since it's always available now.
2396 (syms_of_floatfns): Always define isnan at the Lisp level.
2397
e39b275c 23982011-09-06 Paul Eggert <eggert@cs.ucla.edu>
1c262cae
PE
2399
2400 * Makefile.in (gl-stamp): move-if-change now in build-aux (Bug#9169).
2401
b2db44d9 24022011-09-06 Paul Eggert <eggert@cs.ucla.edu>
728f8f0a 2403
f4af5137 2404 * fileio.c: Fix bugs with large file offsets (Bug#9428).
728f8f0a
PE
2405 The previous code assumed that file offsets (off_t values) fit in
2406 EMACS_INT variables, which is not true on typical 32-bit hosts.
2407 The code messed up by falsely reporting buffer overflow in cases
2408 such as (insert-file-contents "big" nil 1 2) into an empty buffer
2409 when "big" contains more than 2**29 bytes, even though this
2410 inserts just one byte and does not overflow the buffer.
2411 (Finsert_file_contents): Store file offsets as off_t
2412 values, not as EMACS_INT values. Check for overflow when
2413 converting between EMACS_INT and off_t. When checking for
2414 buffer overflow or for overlap, take the offsets into account.
2415 Don't use EMACS_INT for small values where int suffices.
2416 When checking for overlap, fix a typo: ZV was used where
2417 ZV_BYTE was intended.
2418 (Fwrite_region): Don't assume off_t fits into 'long'.
2419 * buffer.h (struct buffer.modtime_size): Now off_t, not EMACS_INT.
2420
ecfc0a49
MA
24212011-09-05 Michael Albinus <michael.albinus@gmx.de>
2422
2423 * dbusbind.c (xd_signature_cat): Rename from signature_cat.
2424
6511acf2 24252011-09-04 Paul Eggert <eggert@cs.ucla.edu>
61bfeeb7 2426
0999621a 2427 sprintf-related integer and memory overflow issues (Bug#9412).
62f19c19
PE
2428
2429 * doprnt.c (doprnt): Support printing ptrdiff_t and intmax_t values.
8666506e 2430 (esprintf, exprintf, evxprintf): New functions.
62f19c19 2431 * keyboard.c (command_loop_level): Now EMACS_INT, not int.
6b02f655 2432 (cmd_error): Kbd macro iterations count is now EMACS_INT, not int.
62f19c19
PE
2433 (modify_event_symbol): Do not assume that the length of
2434 name_alist_or_stem is safe to alloca and fits in int.
2435 (Fexecute_extended_command): Likewise for function name and binding.
2436 (Frecursion_depth): Wrap around reliably on integer overflow.
2437 * keymap.c (push_key_description): First arg is now EMACS_INT, not int,
2438 since some callers pass EMACS_INT values.
2439 (Fsingle_key_description): Don't crash if symbol name contains more
2440 than MAX_ALLOCA bytes.
2441 * minibuf.c (minibuf_level): Now EMACS_INT, not int.
2442 (get_minibuffer): Arg is now EMACS_INT, not int.
2443 * lisp.h (get_minibuffer, push_key_description): Reflect API changes.
8666506e 2444 (esprintf, exprintf, evxprintf): New decls.
62f19c19
PE
2445 * window.h (command_loop_level, minibuf_level): Reflect API changes.
2446
2be7d702
PE
2447 * dbusbind.c (signature_cat): New function.
2448 (xd_signature, Fdbus_register_signal):
2ea16b89
PE
2449 Do not overrun buffer; instead, report string overflow.
2450
9d1df220
PE
2451 * dispnew.c (add_window_display_history): Don't overrun buffer.
2452 Truncate instead; this is OK since it's just a log.
2453
33ef5c64
PE
2454 * editfns.c (Fcurrent_time_zone): Don't overrun buffer
2455 even if the time zone offset is outlandishly large.
2456 Don't mishandle offset == INT_MIN.
2457
66c6fdd5
PE
2458 * emacs.c (main) [NS_IMPL_COCOA]: Don't overrun buffer
2459 when creating daemon; the previous buffer-overflow check was incorrect.
2460
d749b01b
PE
2461 * eval.c (verror): Simplify by rewriting in terms of evxprintf,
2462 which has the guts of the old verror function.
2463
b5cd1905
PE
2464 * filelock.c (lock_file_1, lock_file): Don't blindly alloca long name;
2465 use SAFE_ALLOCA instead. Use esprintf to avoid int-overflow issues.
2466
6e1a67fb
PE
2467 * font.c: Include <float.h>, for DBL_MAX_10_EXP.
2468 (font_unparse_xlfd): Don't blindly alloca long strings.
c21721cc 2469 Don't assume XINT result fits in int, or that XFLOAT_DATA * 10
8666506e 2470 fits in int, when using sprintf. Use single snprintf to count
c21721cc
PE
2471 length of string rather than counting it via multiple sprintfs;
2472 that's simpler and more reliable.
c21721cc
PE
2473 (font_unparse_fcname): Use it to avoid sprintf buffer overrun.
2474 (generate_otf_features) [0 && HAVE_LIBOTF]: Use esprintf, not
2475 sprintf, in case result does not fit in int.
2476
c57b67fc
PE
2477 * fontset.c (num_auto_fontsets): Now printmax_t, not int.
2478 (fontset_from_font): Print it.
2479
8a401434
PE
2480 * frame.c (tty_frame_count): Now printmax_t, not int.
2481 (make_terminal_frame, set_term_frame_name): Print it.
2482 (x_report_frame_params): In X, window IDs are unsigned long,
2483 not signed long, so print them as unsigned.
2484 (validate_x_resource_name): Check for implausibly long names,
2485 and don't assume name length fits in 'int'.
2486 (x_get_resource_string): Don't blindly alloca invocation name;
2487 use SAFE_ALLOCA. Use esprintf, not sprintf, in case result does
2488 not fit in int.
2489
6e1a67fb
PE
2490 * gtkutil.c: Include <float.h>, for DBL_MAX_10_EXP.
2491 (xg_check_special_colors, xg_set_geometry):
84722b3d
PE
2492 Make sprintf buffers a bit bigger, to avoid potential buffer overrun.
2493
0df02bf3
PE
2494 * lread.c (dir_warning): Don't blindly alloca buffer; use SAFE_ALLOCA.
2495 Use esprintf, not sprintf, in case result does not fit in int.
2496
48e30793
PE
2497 * macros.c (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2498 (Fend_kbd_macro): Don't mishandle MOST_NEGATIVE_FIXNUM by treating
2499 it as a large positive number.
2500 (Fexecute_kbd_macro): Don't assume repeat count fits in int.
2501 * macros.h (executing_kbd_macro_iterations): Now EMACS_INT, not int.
2502
a66ff6d8
PE
2503 * nsterm.m ((NSSize)windowWillResize): Use esprintf, not sprintf,
2504 in case result does not fit in int.
2505
aca216ff
PE
2506 * print.c (float_to_string): Detect width overflow more reliably.
2507 (print_object): Make sprintf buffer a bit bigger, to avoid potential
2508 buffer overrun. Don't assume list length fits in 'int'. Treat
2509 print length of 0 as 0, not as infinity; to be consistent with other
2510 uses of print length in this function. Don't overflow print length
2511 index. Don't assume hash table size fits in 'long', or that
2512 vectorlike size fits in 'unsigned long'.
2513
31c286f7
PE
2514 * process.c (make_process): Use printmax_t, not int, to format
2515 process-name gensyms.
2516
55e5faa1
PE
2517 * sysdep.c (snprintf) [! HAVE_SNPRINTF]: New function.
2518
80f2e268
PE
2519 * term.c (produce_glyphless_glyph): Make sprintf buffer a bit bigger
2520 to avoid potential buffer overrun.
2521
670741ab
PE
2522 * xfaces.c (x_update_menu_appearance): Don't overrun buffer
2523 if X resource line is longer than 512 bytes.
2524
b7163a50
PE
2525 * xfns.c (x_window): Make sprintf buffer a bit bigger
2526 to avoid potential buffer overrun.
2527
ae58ff1f
PE
2528 * xterm.c (x_io_error_quitter): Don't overrun sprintf buffer.
2529
c43c8a6a
PE
2530 * xterm.h (x_check_errors): Add ATTRIBUTE_FORMAT_PRINTF.
2531
3f8236f4
PE
25322011-09-04 Paul Eggert <eggert@cs.ucla.edu>
2533
53e9fe90 2534 Integer overflow fixes for scrolling, etc.
6511acf2
PE
2535 Without these, Emacs silently mishandles large integers sometimes.
2536 For example, "C-u 4294967297 M-x recenter" was treated as if
53e9fe90
PE
2537 it were "C-u 1 M-x recenter" on a typical 64-bit host.
2538
6511acf2
PE
2539 * xdisp.c (try_window_id): Check Emacs fixnum range before
2540 converting to 'int'.
806add1d 2541
6511acf2 2542 * window.c (window_scroll_line_based, Frecenter):
71f02bc5
PE
2543 Check that an Emacs fixnum is in range before assigning it to 'int'.
2544 (Frecenter, Fmove_to_window_line): Use EMACS_INT, not int, for
2545 values converted from Emacs fixnums.
2546 (Frecenter): Don't wrap around a line count if it is out of 'int'
2547 range; instead, treat it as an extreme value.
2548 (Fset_window_configuration, compare_window_configurations):
2549 Use ptrdiff_t, not int, for index that might exceed 2 GiB.
2550
6511acf2
PE
2551 * search.c (Freplace_match): Use ptrdiff_t, not int, for indexes
2552 that can exceed INT_MAX. Check that EMACS_INT value is in range
2553 before assigning it to the (possibly-narrower) index.
a0efffc8
PE
2554 (match_limit): Don't assume that a fixnum can fit in 'int'.
2555
6511acf2 2556 * print.c (print_object): Use ptrdiff_t, not int, for index that can
29ebea3b
PE
2557 exceed INT_MAX.
2558
6511acf2 2559 * indent.c (position_indentation): Now takes ptrdiff_t, not int.
3f8236f4
PE
2560 (Fvertical_motion): Don't wrap around LINES values that don't fit
2561 in 'int'. Instead, treat them as extreme values. This is good
2562 enough for windows, which can't have more than INT_MAX lines anyway.
2563
fcb901a7
LMI
25642011-09-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
2565
0f2f6b6d
LMI
2566 * Require libxml/parser.h to avoid compilation warning.
2567
fcb901a7
LMI
2568 * emacs.c (shut_down_emacs): Call xmlCleanupParser on shutdown.
2569
2570 * xml.c (parse_region): Don't call xmlCleanupParser after parsing,
2571 since this reportedly can destroy thread storage.
2572
6e20a0d4
CY
25732011-08-30 Chong Yidong <cyd@stupidchicken.com>
2574
2575 * syntax.c (find_defun_start): Update all cache variables if
2576 exiting early (Bug#9401).
2577
148ae00e
EZ
25782011-08-30 Eli Zaretskii <eliz@gnu.org>
2579
f6cfbd8f
EZ
2580 * image.c (x_bitmap_pixmap): Cast to int to avoid compiler warnings.
2581
148ae00e
EZ
2582 * xdisp.c (produce_stretch_glyph): No longer static, compiled also
2583 when HAVE_WINDOW_SYSTEM is not defined. Support both GUI and TTY
2584 frames. Call tty_append_glyph in the TTY case. (Bug#9402)
2585
2586 * term.c (tty_append_glyph): New function.
2587 (produce_stretch_glyph): Static function and its prototype deleted.
2588
a66cfb1c
SM
2589 * dispextern.h (produce_stretch_glyph, tty_append_glyph):
2590 Add prototypes.
148ae00e 2591
c4a07a4c
PE
25922011-08-29 Paul Eggert <eggert@cs.ucla.edu>
2593
2594 * image.c (parse_image_spec): Check for nonnegative, not for positive,
2595 when checking :margin (Bug#9390).
2596 (IMAGE_NON_NEGATIVE_INTEGER_VALUE_OR_PAIR):
a66cfb1c 2597 Rename from IMAGE_POSITIVE_INTEGER_VALUE_OR_PAIR,
c4a07a4c
PE
2598 so that the name doesn't mislead. All uses changed.
2599
6bc8cd65
JB
26002011-08-28 Johan Bockgård <bojohan@gnu.org>
2601
2602 * term.c (init_tty) [HAVE_GPM]: Move mouse settings after
2603 set_tty_hooks.
2604
dca4927e
EZ
26052011-08-27 Eli Zaretskii <eliz@gnu.org>
2606
2607 * xdisp.c (move_it_to): Don't bail out early when reaching
2608 position beyond to_charpos, if we are scanning backwards.
2609 (move_it_vertically_backward): When DY == 0, make sure we get to
2610 the first character in the line after the newline.
2611
f2cad773
PE
26122011-08-27 Paul Eggert <eggert@cs.ucla.edu>
2613
2614 * ccl.c: Improve and simplify overflow checking (Bug#9196).
2615 (ccl_driver): Do not generate an out-of-range pointer.
2616 (Fccl_execute_on_string): Remove unnecessary check for
2617 integer overflow, noted by Stefan Monnier in
2618 <http://lists.gnu.org/archive/html/emacs-devel/2011-08/msg00979.html>.
2619 Remove a FIXME that didn't need fixing.
2620 Simplify the newly-introduced buffer reallocation code.
2621
0cae2cdb
JB
26222011-08-27 Juanma Barranquero <lekktu@gmail.com>
2623
2624 * makefile.w32-in ($(BLD)/alloc.$(O)): Depend on lib/verify.h.
2625
5fc295a4 26262011-08-26 Paul Eggert <eggert@cs.ucla.edu>
ddff3151 2627
70c60eb2 2628 Integer and memory overflow issues (Bug#9196).
726e0ab1 2629
d31850da
PE
2630 * doc.c (get_doc_string): Rework so that
2631 get_doc_string_buffer_size is the actual buffer size, rather than
2632 being 1 less than the actual buffer size; this makes xpalloc more
2633 convenient.
2634
a69fbedb
PE
2635 * image.c (x_allocate_bitmap_record, cache_image):
2636 * xselect.c (Fx_register_dnd_atom):
2637 Simplify previous changes by using xpalloc.
2638
fe5c5d37
PE
2639 * buffer.c (overlay_str_len): Now ptrdiff_t, not EMACS_INT,
2640 since either will do and ptrdiff_t is convenient with xpalloc.
2641
0065d054
PE
2642 * charset.c (charset_table_size)
2643 (struct charset_sort_data.priority): Now ptrdiff_t.
2644 (charset_compare): Don't overflow if priorities differ greatly.
2645 (Fsort_charsets): Don't assume list length fits in int.
2646 Check for size-calculation overflow when allocating sort data.
2647 (syms_of_charset): Allocate an initial charset table that is
2648 just under 64 KiB, to avoid problems with glibc malloc and mmap.
2649
2650 * cmds.c (internal_self_insert): Check for size-calculation overflow.
2651
2652 * composite.h (struct composition.glyph_len): Now int, not unsigned.
2653 The actual value is always <= INT_MAX, and leaving it unsigned made
2654 overflow checking harder.
2655
2656 * dispextern.h (struct glyph_matrix.rows_allocated)
2657 (struct face_cache.size): Now ptrdiff_t, for convenience in use
2658 with xpalloc. The values are still always <= INT_MAX.
2659
2660 * indent.c (compute_motion): Adjust to region_cache_forward sig change.
2661
2662 * lisp.h (xnmalloc, xnrealloc, xpalloc): New decls.
2663 (SAFE_NALLOCA): New macro.
2664
2665 * region-cache.c (struct boundary.pos, find_cache_boundary)
2666 (move_cache_gap, insert_cache_boundary, delete_cache_boundaries)
2667 (set_cache_region, invalidate_region_cache)
2668 (revalidate_region_cache, know_region_cache, region_cache_forward)
2669 (region_cache_backward, pp_cache):
2670 Use ptrdiff_t, not EMACS_INT, since either will do. This is needed
2671 so that ptrdiff_t * can be passed to xpalloc.
2672 (struct region_cache): Similarly, for gap_start, gap_len, cache_len,
2673 beg_unchanged, end_unchanged, buffer_beg, buffer_end members.
2674 (pp_cache): Don't assume cache_len fits in int.
2675 * region-cache.h: Adjust extern decls to match.
2676
2677 * search.c (scan_buffer, Freplace_match): Use ptrdiff_t, not
2678 EMACS_INT, since either will do, for xpalloc.
2679
2680 * alloc.c: Include verify.h, and check that int fits in ptrdiff_t.
2681 (xnmalloc, xnrealloc, xpalloc): New functions.
2682
726e0ab1
PE
2683 * bidi.c (bidi_shelve_header_size): New constant.
2684 (bidi_cache_ensure_space, bidi_shelve_cache): Use it.
2685 (bidi_cache_ensure_space): Avoid integer overflow when allocating.
2686
51f30bc5 2687 * bidi.c (bidi_cache_shrink):
726e0ab1
PE
2688 * buffer.c (overlays_at, overlays_in, record_overlay_string)
2689 (overlay_strings):
2690 Don't update size of array until after memory allocation succeeds,
2691 because xmalloc/xrealloc may not return.
0065d054
PE
2692 (struct sortstrlist.bytes): Now ptrdiff_t, as EMACS_INT doesn't help
2693 now that we have proper integer overflow checking.
2694 (record_overlay_string, overlay_strings): Catch overflows when
2695 calculating size of overlay_str_buf.
726e0ab1 2696
0065d054
PE
2697 * callproc.c (Fcall_process): Check for size overflow when
2698 calculating size of args2.
2699 (child_setup): Avoid overflow by using size_t rather than ptrdiff_t.
2700 Normally we prefer signed values, but sticking with ptrdiff_t would
2701 require adding more-complicated checks.
726e0ab1
PE
2702
2703 * ccl.c (Fccl_execute_on_string): Check for memory overflow.
2704 Use ptrdiff_t rather than EMACS_INT where ptrdiff_t will do.
2705 Redo buffer-overflow calculations to avoid integer overflow.
0065d054 2706 Add a FIXME comment where memory seems to be over-allocated.
726e0ab1
PE
2707
2708 * character.c (Fstring): Check for size-calculation overflow.
2709
2710 * coding.c (produce_chars): Redo buffer-overflow calculations to avoid
2711 unnecessary integer overflow. Check for size overflow.
2712 (encode_coding_object): Don't update size until xmalloc succeeds.
2713
2714 * composite.c (get_composition_id): Check for overflow in glyph
2715 length calculations.
2716
2717 Integer and memory overflow fixes for display code.
2718 * dispextern.h (struct glyph_pool.nglyphs): Now ptrdiff_t, not int.
2719 * dispnew.c (adjust_glyph_matrix, realloc_glyph_pool)
2720 (scrolling_window): Check for overflow in size calculations.
2721 (line_draw_cost, realloc_glyph_pool, add_row_entry):
2722 Don't assume glyph table len fits in int.
2723 (struct row_entry.bucket, row_entry_pool_size, row_entry_idx)
2724 (row_table_size): Now ptrdiff_t, not int.
2725 (scrolling_window): Avoid overflow in size calculations.
2726 Don't update size until allocation succeeds.
2727 * fns.c (concat): Check for overflow in size calculations.
2728 (next_almost_prime): Verify NEXT_ALMOST_PRIME_LIMIT.
2729 * lisp.h (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
2730 (NEXT_ALMOST_PRIME_LIMIT): New constant.
2731
2732 * doc.c (get_doc_string_buffer_size): Now ptrdiff_t, not int.
2733 (get_doc_string): Check for size calculation overflow.
2734 Don't update size until allocation succeeds.
2735 (get_doc_string, Fsubstitute_command_keys): Use ptrdiff_t, not
2736 EMACS_INT, where ptrdiff_t will do.
2737 (Fsubstitute_command_keys): Check for string overflow.
2738
2739 * editfns.c (set_time_zone_rule): Don't assume environment length
2740 fits in int.
2741 (message_length): Now ptrdiff_t, not int.
2742 (Fmessage_box): Don't update size until allocation succeeds.
2743 Don't assume message length fits in int.
2744 (Fformat): Use ptrdiff_t, not EMACS_INT, where ptrdiff_t will do.
2745
0065d054
PE
2746 * emacs.c (main): Do not reallocate argv, since there is a null at
2747 the end that can be overwritten, and this way there's no need to
2748 worry about size-calculation overflow.
2749 (sort_args): Check for size-calculation overflow.
726e0ab1
PE
2750
2751 * eval.c (init_eval_once, grow_specpdl): Don't update size until
2752 alloc succeeds.
2753 (call_debugger, grow_specpdl): Redo calculations to avoid overflow.
2754
2755 * frame.c (set_menu_bar_lines, x_set_frame_parameters)
2756 (x_set_scroll_bar_width, x_figure_window_size):
2757 Check for integer overflow.
2758 (x_set_alpha): Do not assume XINT fits in int.
2759
2760 * frame.h (struct frame): Use int, not EMACS_INT, where int works.
2761 This is for the members text_lines, text_cols, total_lines, total_cols,
2762 where the system imposes an 'int' limit.
2763
2764 * fringe.c (Fdefine_fringe_bitmap):
2765 Don't update size until alloc works.
2766
2767 * ftfont.c (ftfont_get_open_type_spec, setup_otf_gstring)
2768 (ftfont_shape_by_flt): Check for integer overflow in size calculations.
2769
2770 * gtkutil.c (get_utf8_string, xg_store_widget_in_map):
2771 Check for size-calculation overflow.
2772 (get_utf8_string): Use ptrdiff_t, not size_t, where either will
2773 do, as we prefer signed integers.
2774 (id_to_widget.max_size, id_to_widget.used)
2775 (xg_store_widget_in_map, xg_remove_widget_from_map)
2776 (xg_get_widget_from_map, xg_get_scroll_id_for_window)
2777 (xg_remove_scroll_bar, xg_update_scrollbar_pos):
2778 Use and return ptrdiff_t, not int.
2779 (xg_gtk_scroll_destroy): Don't assume ptrdiff_t fits in int.
2780 * gtkutil.h: Change prototypes to match the above.
2781
2782 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): Remove; these
2783 are duplicate now that they've been promoted to lisp.h.
2784 (x_allocate_bitmap_record, x_alloc_image_color)
2785 (make_image_cache, cache_image, xpm_load):
2786 Don't update size until alloc is done.
2787 (xpm_load, lookup_rgb_color, lookup_pixel_color, x_to_xcolors)
2788 (x_detect_edges):
3256efce 2789 Check for size calculation overflow.
726e0ab1
PE
2790 (ct_colors_allocated_max): New constant.
2791 (x_to_xcolors, x_detect_edges): Reorder multiplicands to avoid
2792 overflow.
3256efce 2793
726e0ab1
PE
2794 * keyboard.c (read_char, menu_bar_items, tool_bar_items)
2795 (read_char_x_menu_prompt, read_char_minibuf_menu_width)
2796 (read_char_minibuf_menu_prompt, follow_key, read_key_sequence):
2797 Use ptrdiff_t, not int, to count maps.
2798 (read_char_minibuf_menu_prompt): Check for overflow in size
a66cfb1c
SM
2799 calculations. Don't update size until allocation succeeds.
2800 Redo calculations to avoid overflow.
726e0ab1
PE
2801 * keyboard.h: Change prototypes to match the above.
2802
2803 * keymap.c (cmm_size, current_minor_maps): Use ptrdiff_t, not int,
2804 to count maps.
2805 (current_minor_maps): Check for size calculation overflow.
2806 * keymap.h: Change prototypes to match the above.
2807
2808 * lread.c (read1, init_obarray): Don't update size until alloc done.
2809
2810 * macros.c (Fstart_kbd_macro): Don't update size until alloc done.
2811 (store_kbd_macro_char): Reorder multiplicands to avoid overflow.
2812
726e0ab1
PE
2813 * nsterm.h (struct ns_color_table.size, struct ns_color_table.avail):
2814 Now ptrdiff_t, not int.
2815 * nsterm.m (ns_index_color): Use ptrdiff_t, not int, for table indexes.
2816 (ns_draw_fringe_bitmap): Rewrite to avoid overflow.
2817
2818 * process.c (Fnetwork_interface_list): Check for overflow
2819 in size calculation.
2820
2821 * region-cache.c (move_cache_gap): Check for size calculation overflow.
2822
2823 * scroll.c (do_line_insertion_deletion_costs): Check for size calc
2824 overflow. Don't bother calling xmalloc when xrealloc will do.
2825
2826 * search.c (Freplace_match): Check for size calculation overflow.
2827 (Fset_match_data): Don't assume list lengths fit in 'int'.
2828
2829 * sysdep.c (system_process_attributes): Use ptrdiff_t, not int,
2830 for command line length. Do not attempt to address one before the
2831 beginning of an array, as that's not portable.
2832
2833 * term.c (max_frame_lines): Remove; unused.
2834 (encode_terminal_src_size, encode_terminal_dst_size): Now ptrdiff_t,
2835 not int.
2836 (encode_terminal_code, calculate_costs): Check for size
2837 calculation overflow.
2838 (encode_terminal_code): Use ptrdiff_t, not int, to record glyph
2839 table lengths and related sizes. Don't update size until alloc
2840 done. Redo calculations to avoid overflow.
2841 (calculate_costs): Don't bother calling xmalloc when xrealloc will do.
2842
2843 * termcap.c (tgetent): Use ptrdiff_t, not int, to record results of
2844 subtracting pointers.
2845 (gobble_line): Check for overflow more carefully. Don't update size
2846 until alloc done.
2847
2848 * tparam.c (tparam1): Use ptrdiff_t, not int, for sizes.
2849 Don't update size until alloc done.
2850 Redo size calculations to avoid overflow.
2851 Check for size calculation overflow.
0065d054 2852 (main) [DEBUG]: Fix typo in invoking tparam1.
726e0ab1
PE
2853
2854 * xdisp.c (store_mode_line_noprop_char, x_consider_frame_title):
2855 Use ptrdiff_t, not int, for sizes.
2856 (store_mode_line_noprop_char): Don't update size until alloc done.
2857
0065d054
PE
2858 * xfaces.c (lface_id_to_name_size, Finternal_make_lisp_face):
2859 Use ptrdiff_t, not int, for sizes.
2860 (Finternal_make_lisp_face, cache_face):
2861 Check for size calculation overflow.
2862 (cache_face): Treat size calculation overflows as if they were
2863 memory exhaustion (the usual treatment), rather than aborting.
726e0ab1
PE
2864
2865 * xfns.c (x_encode_text, x_set_name_internal)
2866 (Fx_change_window_property): Use ptrdiff_t, not int, to count
2867 sizes, since they can exceed INT_MAX in size. Check for size
2868 calculation overflow.
2869
0065d054
PE
2870 * xgselect.c (gfds_size): Now ptrdiff_t, for convenience with xpalloc.
2871 (xg_select): Check for size calculation overflow.
726e0ab1
PE
2872 Don't update size until alloc done.
2873
0065d054 2874 * xrdb.c (get_environ_db): Don't assume path length fits in int,
726e0ab1 2875 as sprintf is limited to int lengths.
1d526e2f 2876
252c5ee1
PE
2877 * xselect.c (X_LONG_SIZE, X_SHRT_MAX, X_SHRT_MIN, X_LONG_MAX)
2878 (X_LONG_MIN): New macros.
864d7ce7
PE
2879 Use them to make the following changes clearer.
2880 (MAX_SELECTION_QUANTUM): Make the other bounds on this value clearer.
2881 This change doesn't affect the value now, but it may help remind
2882 future maintainers not to raise the value too much later.
2883 (SELECTION_QUANTUM): Remove, replacing with ...
2884 (selection_quantum): ... new function, which avoids overflow.
2885 All uses changed.
2886 (struct selection_data.size): Now ptrdiff_t, not int, to avoid
2887 assumption that selection length fits in 'int'.
2888 (x_reply_selection_request, x_handle_selection_request)
2889 (x_get_window_property, receive_incremental_selection)
2890 (x_get_window_property_as_lisp_data, selection_data_to_lisp_data)
2891 (lisp_data_to_selection_data, clean_local_selection_data):
2892 Use ptrdiff_t, not int, to record length of selection.
2893 (x_reply_selection_request, x_get_window_property)
2894 (receive_incremental_selection, x_property_data_to_lisp):
2895 Redo calculations to avoid overflow.
2896 (x_reply_selection_request): When sending hint, ceiling it at
252c5ee1 2897 X_LONG_MAX rather than relying on wraparound overflow to send
864d7ce7
PE
2898 something.
2899 (x_get_window_property, receive_incremental_selection)
2900 (lisp_data_to_selection_data, x_property_data_to_lisp):
2901 Check for size-calculation overflow.
2902 (x_get_window_property, receive_incremental_selection)
2903 (lisp_data_to_selection_data, Fx_register_dnd_atom):
2904 Don't store size until memory allocation succeeds.
2905 (x_get_window_property): Plug memory leak on memory exhaustion.
2906 Don't double-block input; malloc is safe here. Don't assume 2**34
2907 - 4 fits in unsigned long. Add an xassert to check
2908 XGetWindowProperty overflow. Be more careful about overflow
2909 calculations, and distinguish size from memory overflow better.
2910 (receive_incremental_selection): When tracing, don't assume
2911 unsigned int is less than INT_MAX.
2912 (x_selection_data_to_lisp_data): Remove unnecessary (and in theory
2913 harmful) conversions of unsigned short to int.
2914 (lisp_data_to_selection_data): Don't assume that integers
2915 in the range -65535 through -1 fit in an X unsigned short.
2916 Don't assume that ULONG_MAX == X_ULONG_MAX. Don't store into
2917 result parameters unless successful. Rely on cons_to_unsigned
2918 to report problems with elements; the old code wasn't right anyway.
2919 (x_check_property_data): Check for int overflow; we cannot use
2920 a wider type due to X limits.
2921 (x_handle_dnd_message): Use unsigned int, to avoid int overflow.
2922
726e0ab1 2923 * xsmfns.c (smc_save_yourself_CB): Check for size calc overflow.
34db673b 2924
0065d054
PE
2925 * xterm.c (x_color_cells, x_send_scrollbar_event, handle_one_xevent)
2926 (x_term_init): Check for size calculation overflow.
726e0ab1
PE
2927 (x_color_cells): Don't store size until memory allocation succeeds.
2928 (handle_one_xevent): Use ptrdiff_t, not int, for byte counts.
0065d054 2929 Don't assume alloca size is less than MAX_ALLOCA.
726e0ab1
PE
2930 (x_term_init): Don't assume length fits in int (sprintf is limited
2931 to int size).
bc18e09d 2932
ebfa62c0
PE
2933 Use ptrdiff_t for composition IDs.
2934 * character.c (lisp_string_width):
2935 * composite.c (composition_table_size, n_compositions)
2936 (get_composition_id, composition_gstring_from_id):
2937 * dispextern.h (struct glyph_string.cmp_id, struct composition_it.id):
2938 * xdisp.c (BUILD_COMPOSITE_GLYPH_STRING):
2939 * window.c (Frecenter):
2940 Use ptrdiff_t, not int, for composition IDs.
2941 * composite.c (get_composition_id): Check for integer overflow.
2942 * composite.h: Adjust prototypes to match the above changes.
2943
d3411f89
PE
2944 Use ptrdiff_t for hash table indexes.
2945 * category.c (hash_get_category_set):
2946 * ccl.c (ccl_driver):
2947 * charset.h (struct charset.hash_index, CHECK_CHARSET_GET_ID):
2948 * coding.c (coding_system_charset_list, detect_coding_system):
2949 * coding.h (struct coding_system.id):
2950 * composite.c (get_composition_id, gstring_lookup_cache):
2951 * fns.c (hash_lookup, hash_put, Fgethash, Fputhash):
2952 * image.c (xpm_get_color_table_h):
2953 * lisp.h (hash_lookup, hash_put):
2954 * minibuf.c (Ftest_completion):
2955 Use ptrdiff_t for hash table indexes, not int (which is too
2956 narrow, on 64-bit hosts) or EMACS_INT (which is too wide, on
2957 32-bit --with-wide-int hosts).
2958
e097a6fa
PE
2959 * charset.c (Fdefine_charset_internal): Check for integer overflow.
2960 Add a FIXME comment about memory leaks.
2961 (syms_of_charset): Don't assume xmalloc returns.
2962
5637687f
PE
2963 Don't assume that stated character widths fit in int.
2964 * character.c (Fchar_width, c_string_width, lisp_string_width):
2965 * character.h (CHAR_WIDTH):
2966 * indent.c (MULTIBYTE_BYTES_WIDTH):
2967 Use sanitize_char_width to avoid undefined and/or bad behavior
2968 with outlandish widths.
a66cfb1c 2969 * character.h (sanitize_tab_width): Rename from sanitize_width,
5637687f
PE
2970 now that we have two such functions. All uses changed.
2971 (sanitize_char_width): New inline function.
2972
a2271ba2
PE
2973 Don't assume that tab-width fits in int.
2974 * character.h (sanitize_width): New inline function.
2975 (SANE_TAB_WIDTH): New macro.
2976 (ASCII_CHAR_WIDTH): Use it.
2977 * indent.c (sane_tab_width): Remove. All uses replaced by
2978 SANE_TAB_WIDTH (current_buffer).
2979 * xdisp.c (init_iterator): Use SANE_TAB_WIDTH.
2980
18c52557
PE
2981 * fileio.c: Integer overflow issues with file modes.
2982 (Fset_file_modes, auto_save_1): Don't assume EMACS_INT fits in int.
2983
caeeedc1
PE
2984 * charset.c (read_hex): New arg OVERFLOW. All uses changed.
2985 Remove unreachable code.
2986 (read_hex, load_charset_map_from_file): Check for integer overflow.
2987
6df6ae42 2988 * xterm.c: Don't go over XClientMessageEvent limit.
50849c52
PE
2989 (scroll_bar_windows_size): Now ptrdiff_t, as we prefer signed.
2990 (x_send_scroll_bar_event): Likewise. Check that the size does not
2991 exceed limits imposed by XClientMessageEvent, as well as the usual
2992 ptrdiff_t and size_t limits.
2993
b13995db
PE
2994 * keyboard.c: Overflow, signedness and related fixes.
2995 (make_lispy_movement): Use same integer type in forward decl
2996 that is used in the definition.
2997 (read_key_sequence, keyremap_step):
2998 Change bufsize argument back to int, undoing my 2011-03-30 change.
2999 We prefer signed types, and int is wide enough here.
3000 (parse_tool_bar_item): Don't assume tool_bar_max_label_size is less
3001 than TYPE_MAXIMUM (EMACS_INT) / 2. Don't let the label size grow
3002 larger than STRING_BYTES_BOUND. Use ptrdiff_t for Emacs string
3003 length, not size_t. Use ptrdiff_t for index, not int.
3004 (keyremap_step, read_key_sequence): Redo bufsize check to avoid
3005 possibility of integer overflow.
3006
13464394
PE
3007 Overflow, signedness and related fixes for images.
3008
3009 * dispextern.h (struct it.stack[0].u.image.image_id)
3010 (struct_it.image_id, struct image.id, struct image_cache.size)
3011 (struct image_cache.used, struct image_cache.ref_count):
3012 * gtkutil.c (update_frame_tool_bar):
3013 * image.c (x_reference_bitmap, Fimage_size, Fimage_mask_p)
3014 (Fimage_metadata, free_image_cache, clear_image_cache, lookup_image)
3015 (cache_image, mark_image_cache, x_kill_gs_process, Flookup_image):
3016 * nsmenu.m (update_frame_tool_bar):
3017 * xdisp.c (calc_pixel_width_or_height):
3018 * xfns.c (image_cache_refcount):
3019 Image IDs are now ptrdiff_t, not int, to avoid arbitrary limits
3020 on typical 64-bit hosts.
3021
3022 * image.c (RANGED_INTEGERP, TYPE_RANGED_INTEGERP): New macros.
3023 (x_bitmap_pixmap, x_create_x_image_and_pixmap):
3024 Omit unnecessary casts to int.
3025 (parse_image_spec): Check that integers fall into 'int' range
3026 when the callers expect that.
3027 (image_ascent): Redo ascent calculation to avoid int overflow.
3028 (clear_image_cache): Avoid overflow when sqrt (INT_MAX) < nimages.
3029 (lookup_image): Remove unnecessary tests.
3030 (xbm_image_p): Locals are now of int, not EMACS_INT,
3031 since parse_image_check makes sure they fit into int.
3032 (png_load, gif_load, svg_load_image):
3033 Prefer int to unsigned where either will do.
3034 (tiff_handler): New function, combining the cores of the
a66cfb1c
SM
3035 old tiff_error_handler and tiff_warning_handler.
3036 This function is rewritten to use vsnprintf and thereby avoid
13464394
PE
3037 stack buffer overflows. It uses only the features of vsnprintf
3038 that are common to both POSIX and native Microsoft.
3039 (tiff_error_handler, tiff_warning_handler): Use it.
3040 (tiff_load, gif_load, imagemagick_load_image):
3041 Don't assume :index value fits in 'int'.
3042 (gif_load): Omit unnecessary cast to double, and avoid double-rounding.
3043 (imagemagick_load_image): Check that crop parameters fit into
3044 the integer types that MagickCropImage accepts. Don't assume
3045 Vimagemagick_render_type has a nonnegative value. Don't assume
3046 size_t fits in 'long'.
3047 (gs_load): Use printmax_t to print the widest integers possible.
3048 Check for integer overflow when computing image height and width.
3049
c11821d4
EZ
30502011-08-26 Eli Zaretskii <eliz@gnu.org>
3051
3052 * xdisp.c (redisplay_window): Don't force window start if point
3053 will be invisible in the resulting window. (Bug#9324)
3054
0c95fcf7
EZ
30552011-08-25 Eli Zaretskii <eliz@gnu.org>
3056
3057 * xdisp.c (compute_display_string_pos): Return 2 in DISP_PROP when
3058 the display spec is of the form `(space ...)'.
3059 (handle_display_spec): Return the value returned by
3060 handle_single_display_spec, not just 1 or zero.
3061 (handle_single_display_spec): If the display spec is of the form
3062 `(space ...)', and specifies display in the text area, return 2
3063 rather than 1.
fee65a97 3064 (try_cursor_movement): Check for the need to scroll more
a66cfb1c
SM
3065 accurately, and prefer exact match for point under bidi.
3066 Don't advance `row' beyond the last row of the window.
0c95fcf7
EZ
3067
3068 * dispextern.h (struct bidi_it): Rename the disp_prop_p member
3069 into disp_prop; all users changed.
3070
3071 * bidi.c (bidi_fetch_char): If compute_display_string_pos returns
3072 DISP_PROP = 2, substitute the u+2029 PARAGRAPH SEPARATOR character
3073 for the text covered by the display property.
3074
e4ed06f1
CY
30752011-08-25 Chong Yidong <cyd@stupidchicken.com>
3076
3077 * buffer.c (Fbury_buffer_internal): Rename from Funrecord_buffer.
3078 Change return value to nil.
3079 (Frecord_buffer): Delete unused function.
3080
f67cdd7f
EZ
30812011-08-24 Eli Zaretskii <eliz@gnu.org>
3082
5980d4c6
EZ
3083 * xdisp.c (Fcurrent_bidi_paragraph_direction): For unibyte
3084 buffers, return left-to-right.
8610fe8b
EZ
3085 (set_cursor_from_row): Consider candidate row a win if its glyph
3086 represents a newline and point is on that newline. Fixes cursor
3087 positioning on the newline at EOL of R2L text within L2R
3088 paragraph, and vice versa.
3089 (try_cursor_movement): Check continued rows, in addition to
3090 continuation rows. Fixes unwarranted scroll when point enters a
3091 continued line of R2L text within an L2R paragraph, or vice versa.
3092 (cursor_row_p): Consider the case of point being equal to
3093 MATRIX_ROW_END_CHARPOS. Prevents cursor being stuck when moving
3094 from the end of a short line to the beginning of a continued line
3095 of R2L text within L2R paragraph.
3096 (RECORD_MAX_MIN_POS): For max_pos, use IT_CHARPOS even for
3097 composed characters.
5980d4c6 3098
f67cdd7f
EZ
3099 * bidi.c (bidi_check_type): Use xassert.
3100 (bidi_cache_iterator_state): Update the disp_pos and disp_prop_p
3101 members.
3102
bca633fb
EZ
31032011-08-23 Eli Zaretskii <eliz@gnu.org>
3104
3105 * bidi.c (bidi_get_type): Abort if we get zero as the bidi type of
3106 a character.
3107
4a5885a7
CY
31082011-08-23 Chong Yidong <cyd@stupidchicken.com>
3109
3110 * nsfont.m (ns_otf_to_script): Fix typo.
3111
0902a04e
KH
31122011-08-22 Kenichi Handa <handa@m17n.org>
3113
3114 * chartab.c (Fset_char_table_extra_slot): Do not inhibit setting a
3115 extra slot even if the purpose is char-code-property-table.
3116
1a2e6670
EZ
31172011-08-23 Eli Zaretskii <eliz@gnu.org>
3118
8ddde651
EZ
3119 * xdisp.c (redisplay_window): When computing centering_position,
3120 account for the height of the header line. (Bug#8874)
3121
425cc014
EZ
3122 * dispnew.c (buffer_posn_from_coords): Use buf_charpos_to_bytepos
3123 instead of CHAR_TO_BYTE. Fixes a crash when a completion
3124 candidate is selected by the mouse, and that candidate has a
3125 composed character under the mouse.
3126
1a2e6670
EZ
3127 * xdisp.c (x_produce_glyphs): Set it->nglyphs to 1. Fixes pixel
3128 coordinates reported by pos-visible-in-window-p for a composed
3129 character in column zero.
3130
8b76d6f8
SM
31312011-08-23 Stefan Monnier <monnier@iro.umontreal.ca>
3132
3133 * cmds.c (Fself_insert_command): Mention post-self-insert-hook.
3134
dac347dd
EZ
31352011-08-22 Eli Zaretskii <eliz@gnu.org>
3136
3137 * xdisp.c (BUFFER_POS_REACHED_P): If this is a composition,
3138 consider it a hit if to_charpos is anywhere in the range of the
3139 composed buffer positions.
3140
e013fb34
CY
31412011-08-22 Chong Yidong <cyd@stupidchicken.com>
3142
3143 * image.c (gif_load): Don't assume that each subimage has the same
3144 dimensions as the base image. Handle disposal method that is
3145 "undefined" by the gif spec (Bug#9335).
3146
bd1ba3e8
CY
31472011-08-20 Chong Yidong <cyd@stupidchicken.com>
3148
3149 * eval.c (Fsignal): Handle `debug' symbol in error handler (Bug#9329).
024a2d76 3150 (Fcondition_case): Document `debug' symbol in error handler.
bd1ba3e8 3151
54a1215b
EZ
31522011-08-19 Eli Zaretskii <eliz@gnu.org>
3153
823564e5
EZ
3154 * xfaces.c (face_at_buffer_position): Avoid repeated evaluation of
3155 face ID by FACE_FROM_ID, and avoid a crash when mouse is moved
3156 from an Org mode buffer to a Speedbar frame.
3157
54a1215b
EZ
3158 * xdisp.c (RECORD_MAX_MIN_POS): If the display element comes from
3159 a composition, take its buffer position from IT->cmp_it.charpos.
3160 Fixes cursor positioning at the beginning of a line that begins
3161 with a composed character.
3162
9778ebcc
EZ
31632011-08-18 Eli Zaretskii <eliz@gnu.org>
3164
0be6ee06
EZ
3165 * bidi.c (bidi_get_type): If bidi_type_table reports zero as the
3166 character bidirectional type, use STRONG_L instead. Fixes crashes
3167 in a buffer produced by `describe-categories'.
3168
9778ebcc
EZ
3169 * dispextern.h (struct bidi_it): Move disp_pos and disp_prop_p
3170 members before the level stack, so they would be saved and
3171 restored when copying iterator state. Fixes incorrect reordering
3172 around TABs covered by display properties.
3173
156bffbe
AS
31742011-08-18 Andreas Schwab <schwab@linux-m68k.org>
3175
6b02f655 3176 * process.c (Fnetwork_interface_list): Correctly determine buffer size.
156bffbe 3177
72ad093b
CY
31782011-08-17 Chong Yidong <cyd@stupidchicken.com>
3179
3180 * eval.c (internal_condition_case, internal_condition_case_1)
8b76d6f8
SM
3181 (internal_condition_case_2, internal_condition_case_n):
3182 Remove unnecessary aborts (Bug#9081).
72ad093b 3183
35774242
EZ
31842011-08-17 Eli Zaretskii <eliz@gnu.org>
3185
3186 * lread.c (Fload) [DOS_NT]: If `openp' returns -2, but the file
3187 has no `load' handler, try opening the file locally. (Bug#9311)
3188
db76dd85
KB
31892011-08-16 Ken Brown <kbrown@cornell.edu>
3190
3191 * gmalloc.c: Expand comment.
3192
b215eee5
EZ
31932011-08-16 Eli Zaretskii <eliz@gnu.org>
3194
3195 * xdisp.c (set_cursor_from_row): Don't accept a previous candidate
3196 if it fails the cursor_row_p test. Fixes cursor positioning at ZV.
3197
a4579d33
KB
31982011-08-16 Ken Brown <kbrown@cornell.edu>
3199
3200 Fix memory allocation problems in Cygwin build (Bug#9273).
3201
3202 * unexcw.c ( __malloc_initialized): Declare external variable.
3203 (fixup_executable): Force the dumped emacs to reinitialize malloc.
3204
8b76d6f8
SM
3205 * gmalloc.c [CYGWIN] (bss_sbrk_heapbase, bss_sbrk_heapinfo):
3206 New variables.
a4579d33
KB
3207 (malloc_initialize_1) [CYGWIN]: Prepare for reinitializing the
3208 dumped emacs.
3209 (_free_internal_nolock) [CYGWIN]: Ignore requests to free storage
3210 in the static heap.
3211 [CYGWIN] (special_realloc): New function.
3212 (_realloc_internal_nolock) [CYGWIN]: Use the new function on
3213 requests to realloc storage in the static heap.
3214
3ebec551
PE
32152011-08-15 Paul Eggert <eggert@cs.ucla.edu>
3216
3217 * bidi.c (bidi_initialize): Remove unused local.
3218
9fd8be00
EZ
32192011-08-15 Eli Zaretskii <eliz@gnu.org>
3220
6b02f655
SM
3221 * bidimirror.h:
3222 * biditype.h: Remove file.
3223 * makefile.w32-in ($(BLD)/bidi.$(O)):
3224 * deps.mk (bidi.o): Remove biditype.h and bidimirror.h.
474a8465
EZ
3225
3226 * dispextern.h: Fix a typo in the comment to bidi_type_t.
3227
3228 * chartab.c: Improve commentary for the uniprop_table API.
3229
32413314
EZ
3230 * bidi.c (bidi_paragraph_init): Support zero value of
3231 bidi_ignore_explicit_marks_for_paragraph_level.
474a8465
EZ
3232 (bidi_initialize): Use uniprop_table instead of including
3233 biditype.h and bidimirror.h.
32413314 3234
9fd8be00
EZ
3235 * xdisp.c (move_it_in_display_line_to): Don't reset pixel
3236 coordinates of the iterator when restoring from ppos_it.
3237 (Bug#9296)
3238
5cf2b69b
KH
32392011-08-14 Kenichi Handa <handa@m17n.org>
3240
3241 * process.c (create_process): Call setup_process_coding_systems
72ad093b 3242 after the pid of the process is set to -1 (Bug#8162).
5cf2b69b 3243
daf17d00
EZ
32442011-08-14 Eli Zaretskii <eliz@gnu.org>
3245
3246 * xdisp.c (move_it_in_display_line_to): Don't invoke
3247 IT_RESET_X_ASCENT_DESCENT when iterator position was restored from
3248 ppos_it. Fixes vertical cursor motion when line beginning is
3249 covered by an image. (Bug#9296)
3250
08e3161a
JD
32512011-08-14 Jan Djärv <jan.h.d@swipnet.se>
3252
3253 * nsterm.h (ns_run_ascript): Declare.
3254 (NSAPP_DATA2_RUNASSCRIPT): Define.
3255
3256 * nsfns.m (as_script, as_result, as_status): New static variables.
3257 (ns_run_ascript): New function.
5e617bc2 3258 (Fns_do_applescript): Set variables as_*. Make an NSApplicationDefined
08e3161a
JD
3259 event with data2 set to NSAPP_DATA2_RUNASSCRIPT, post it and then start
3260 the event loop. Get status from as_status (Bug#7276).
3261
3262 * nsterm.m (sendEvent): If event is NSApplicationDefined and
3263 data2 is NSAPP_DATA2_RUNASSCRIPT, call ns_run_ascript and then exit
3264 the event loop (Bug#7276).
3265
a3720aa2
AS
32662011-08-14 Andreas Schwab <schwab@linux-m68k.org>
3267
3268 * gnutls.c (QCgnutls_bootprop_priority)
3269 (QCgnutls_bootprop_trustfiles, QCgnutls_bootprop_keylist)
3270 (QCgnutls_bootprop_crlfiles, QCgnutls_bootprop_callbacks)
3271 (QCgnutls_bootprop_loglevel, QCgnutls_bootprop_hostname)
3272 (QCgnutls_bootprop_min_prime_bits, QCgnutls_bootprop_verify_flags)
3273 (QCgnutls_bootprop_verify_hostname_error)
3274 (QCgnutls_bootprop_callbacks_verify): Rename from
3275 Qgnutls_bootprop_..., all uses changed.
3276
3277 * xfaces.c (QCignore_defface): Rename from Qignore_defface, all
3278 uses changed.
3279
0a0d27fb
PE
32802011-08-14 Paul Eggert <eggert@cs.ucla.edu>
3281
19d5c50c
PE
3282 * xfaces.c (Qframe_set_background_mode): Now static.
3283 * dispextern.h (Qframe_set_background_mode): Remove decl.
3284
0a0d27fb
PE
3285 * process.c (Fnetwork_interface_info): Declare local only if needed.
3286
377538cb
JD
32872011-08-13 Jan Djärv <jan.h.d@swipnet.se>
3288
3289 * process.c: Include ifaddrs.h and net/if_dl.h if available (Bug#8477).
3290 (Fnetwork_interface_list): Allocate in increments of bytes instead
3291 of sizeof (struct ifreq). Iterate over ifconf.ifc_req by counting
3292 bytes (Bug#8477). Count bytes correctly when ifr_addr is a struct
3293 sockaddr.
3294 (struct ifflag_def): notrailers is smart on OSX.
3295 (Fnetwork_interface_info): Handle case when ifr_flags is negative.
3296 Get hardware address with getifaddrs if available.
3297
08fff70c
EZ
32982011-08-12 Eli Zaretskii <eliz@gnu.org>
3299
3300 * xdisp.c (iterate_out_of_display_property): xassert that
3301 IT->position is set to within IT->object's boundaries. Break from
3302 the loop as soon as EOB is reached; avoids infloops in redisplay
8b76d6f8
SM
3303 when IT->position is set up wrongly due to some bug.
3304 Set IT->current to match the bidi iterator unconditionally.
08fff70c
EZ
3305 (push_display_prop): Allow GET_FROM_STRING as IT->method on
3306 entry. Force push_it to save on the stack the current
3307 buffer/string position, to be restored by pop_it. Fix flags in
3308 the iterator structure wrt the object coming from a display
3309 property, as `line-prefix' and `wrap-prefix' are not ``replacing''
3310 properties. (Bug#9284)
3311
7be1c708 33122011-08-09 Andreas Schwab <schwab@linux-m68k.org>
aac0c6e3 3313
7be1c708
CY
3314 * fontset.c (fontset_get_font_group): Add proper type checks.
3315 (Bug#9172)
aac0c6e3 3316
7be1c708 33172011-08-09 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
aac0c6e3 3318
7be1c708
CY
3319 * unexmacosx.c (print_load_command_name): Add cases LC_FUNCTION_STARTS
3320 and LC_VERSION_MIN_MACOSX.
3321 (copy_linkedit_data) [LC_FUNCTION_STARTS]: New function.
3322 (dump_it) [LC_FUNCTION_STARTS]: Use it.
aac0c6e3 3323
97bb72a6
EZ
33242011-08-08 Eli Zaretskii <eliz@gnu.org>
3325
3326 * xdisp.c (forward_to_next_line_start): Allow to use the
8b76d6f8
SM
3327 no-display-properties-and-no-overlays under bidi display.
3328 Set disp_pos in the bidi iterator to avoid searches for display
757664a4 3329 properties and overlays.
97bb72a6 3330
d5617611
CY
33312011-08-08 Chong Yidong <cyd@stupidchicken.com>
3332
37e11a63
CY
3333 * editfns.c (Fset_time_zone_rule): Document relationship with the
3334 setenv function.
3335
d5617611
CY
3336 * ftfont.c (ftfont_pattern_entity): Copy the extras argument to
3337 the font entity extracted from the cache (Bug#8109).
3338
58872834
CY
33392011-08-07 Chong Yidong <cyd@stupidchicken.com>
3340
3341 * composite.c (autocmp_chars): Don't reset point. That is done by
3342 restore_point_unwind (Bug#5984).
3343
75bfc667
JL
33442011-08-07 Juri Linkov <juri@jurta.org>
3345
3346 * editfns.c (Fformat_time_string): Doc fix, add tag `usage:'
3347 to show the arg `TIME' instead of `TIMEVAL'.
3348
d1410150
EZ
33492011-08-06 Eli Zaretskii <eliz@gnu.org>
3350
3351 * xdisp.c (set_cursor_from_row): Fix cursor positioning when a
3352 display property strides EOL and includes a newline, as in
3353 longlines-mode. (Bug#9254)
75b771e4
EZ
3354 (move_it_in_display_line_to): Fix vertical-motion in a buffer with
3355 word-wrap under bidirectional display. (Bug#9224)
d1410150
EZ
3356
3357 * bidi.c (bidi_unshelve_cache): Don't reset the cache if JUST_FREE
3358 is non-zero, even if the data buffer is NULL. Fixes a crash in
3359 vertical-motion with longlines-mode. (Bug#9254)
3360
35928349
EZ
33612011-08-05 Eli Zaretskii <eliz@gnu.org>
3362
ec7cc85b
EZ
3363 * bidi.c <bidi_cache_total_alloc>: Now static.
3364 (bidi_initialize): Initialize bidi_cache_total_alloc.
3365
8b76d6f8 3366 * xdisp.c (display_line): Release buffer allocated for shelved bidi
35928349
EZ
3367 cache. (Bug#9221)
3368
3369 * bidi.c (bidi_shelve_cache, bidi_unshelve_cache): Track total
3370 amount allocated this far in `bidi_cache_total_alloc'.
3371 (bidi_unshelve_cache): Accept an additional argument JUST_FREE; if
3372 non-zero, only free the data buffer without restoring the cache
3373 contents. All callers changed.
3374
3375 * dispextern.h (bidi_unshelve_cache): Update prototype.
3376
3377 * xdisp.c (SAVE_IT, pos_visible_p, move_it_in_display_line_to)
3378 (move_it_in_display_line, move_it_to)
3379 (move_it_vertically_backward, move_it_by_lines): Replace the call
3380 to xfree to an equivalent call to bidi_unshelve_cache.
3381 (move_it_in_display_line_to): Fix logic of returning
412b6358 3382 MOVE_POS_MATCH_OR_ZV in the bidi case. (Bug#9224)
35928349 3383
e2e2423b
EZ
33842011-08-05 Eli Zaretskii <eliz@gnu.org>
3385
3386 * xdisp.c (set_cursor_from_row): Prefer the candidate glyph that
3387 came from a string character with a `cursor' property. (Bug#9229)
3388
ae9e757a
JD
33892011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3390
3391 * Makefile.in (LIB_PTHREAD): New variable.
3392 (LIBES): Add LIB_PTHREAD (Bug#9216).
3393
3394 * alloc.c, emacs.c, gmalloc.c, gtkutil.c, keyboard.c, syssignal.h:
3395 Rename HAVE_GTK_AND_PTHREAD to HAVE_PTHREAD (Bug#9216).
3396
213bd7f2
AS
33972011-08-04 Andreas Schwab <schwab@linux-m68k.org>
3398
6b02f655 3399 * regex.c (re_iswctype): Remove some redundant boolean conversions.
213bd7f2 3400
99aaf75f
JD
34012011-08-04 Jan Djärv <jan.h.d@swipnet.se>
3402
3403 * xterm.c (x_find_topmost_parent): New function.
3404 (x_set_frame_alpha): Find topmost parent window with
3405 x_find_topmost_parent and set the property there also (bug#9181).
3406 (handle_one_xevent): Call x_set_frame_alpha on ReparentNotify.
3407
c74e9d86
PE
34082011-08-04 Paul Eggert <eggert@cs.ucla.edu>
3409
3410 * callproc.c (Fcall_process): Avoid vfork clobbering
3411 the local vars buffer, coding_systems, current_dir.
3412
640c8776
SM
34132011-08-03 Stefan Monnier <monnier@iro.umontreal.ca>
3414
3415 * keymap.c (Fmake_composed_keymap): Move to subr.el.
3416
f26d0e4c
PE
34172011-08-03 Paul Eggert <eggert@cs.ucla.edu>
3418
8a10d76c
PE
3419 * fontset.c (dump_fontset) [FONTSET_DEBUG]: Declare EXTERNALLY_VISIBLE
3420 so that it is not optimized away.
3421
f26d0e4c
PE
3422 * xdisp.c (compute_display_string_pos): Remove unused local.
3423
55439c61
EZ
34242011-08-02 Eli Zaretskii <eliz@gnu.org>
3425
3426 Fix slow cursor motion and scrolling in large buffers with
3427 selective display, like Org Mode buffers. (Bug#9218)
3428
3429 * dispextern.h (struct bidi_it): New member disp_prop_p.
3430
3431 * xdisp.c: Remove one-slot cache of display string positions.
3432 (compute_display_string_pos): Accept an additional argument
5e617bc2 3433 DISP_PROP_P; callers changed. Scan at most 5K characters forward
55439c61
EZ
3434 for a display string or property. If found, set DISP_PROP_P
3435 non-zero.
3436
3437 * bidi.c (bidi_fetch_char): Accept an additional argument
640c8776
SM
3438 DISP_PROP_P, and pass it to compute_display_string_pos.
3439 Only handle text covered by a display string if DISP_PROP_P is returned
55439c61
EZ
3440 non-zero. All callers of bidi_fetch_char changed.
3441
fb33fa43
SM
34422011-08-02 Stefan Monnier <monnier@iro.umontreal.ca>
3443
3444 * keymap.c (Fdefine_key): Fix Lisp_Object/int mixup; apply some CSE.
3445
b099e063
DM
34462010-12-03 Don March <don@ohspite.net>
3447
3448 * keymap.c (Fdefine_key): Fix non-prefix key error message when
3449 last character M-[char] is translated to ESC [char] (bug#7541).
3450
5cc7f7af
KH
34512011-08-02 Kenichi Handa <handa@m17n.org>
3452
d0fffa3f 3453 * lisp.h (uniprop_table): Extern it.
5cc7f7af
KH
3454
3455 * chartab.c (uniprop_table): Make it non-static.
3456
525d5e6e
EZ
34572011-08-01 Eli Zaretskii <eliz@gnu.org>
3458
3459 * xdisp.c (forward_to_next_line_start): Accept additional argument
3460 BIDI_IT_PREV, and store into it the state of the bidi iterator had
3461 on the newline.
3462 (reseat_at_next_visible_line_start): Use the bidi iterator state
3463 returned by forward_to_next_line_start to restore the state of
3464 it->bidi_it after backing up to previous newline. (Bug#9212)
3465
31011111
AS
34662011-07-30 Andreas Schwab <schwab@linux-m68k.org>
3467
3468 * regex.c (re_comp): Protoize.
3469 (re_exec): Fix return type.
3470 (regexec): Fix type of `ret'. (Bug#9203)
3471
476371c4
PE
34722011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3473
e5d76069
PE
3474 * image.c (check_image_size): Use 1024x1024 if unknown frame (Bug#9189).
3475 This is needed if max-image-size is a floating-point number.
3476
9a79b20c
AS
34772011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3478
3479 * print.c (print_object): Print empty symbol as ##.
3480
3481 * lread.c (read1): Read ## as empty symbol.
3482
d8c2fa78
AA
34832011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
3484
3485 * nsfns.m (x_set_foreground_color): Set f->foreground_pixel when
3486 setting frame foreground color (Bug#9175).
3487 (x_set_background_color): Likewise.
3488
ffe57a7a
AA
3489 * nsmenu.m (-setText): Size tooltip dimensions precisely to
3490 contents (Bug#9176).
3491 (EmacsTooltip -init): Remove bezels and add shadows to
3492 tooltip windows.
3493
bf3492a5
AA
3494 * nsterm.m (ns_dumpglyphs_stretch): Avoid overwriting left fringe
3495 or scroll bar (Bug#8470).
3496
d55e9c53
AA
3497 * nsfont.m (nsfont_open): Remove assignment to voffset and
3498 unnecessary vars hshink, expand, hd, full_height, min_height.
3499 (nsfont_draw): Use s->ybase as baseline for glyph drawing (Bug#8913).
3500
3501 * nsterm.h (nsfont_info): Remove voffset field.
3502
d8c2fa78 35032011-07-28 Alp Aker <alp.tekin.aker@gmail.com>
4843aac3
AA
3504
3505 Implement strike-through and overline on NextStep (Bug#8863).
3506
3507 * nsfont.m (nsfont_open): Use underline position provided by font,
3508 instead of hard-coded value of 2.
3509 (nsfont_draw): Call ns_draw_text_decoration instead.
3510
3511 * nsterm.h: Add declaration for ns_draw_text_decoration.
3512
3513 * nsterm.m (ns_draw_text_decoration): New function for drawing
3514 underline, overline, and strike-through.
3515 (ns_dumpglyphs_image, ns_dumpglyphs_stretch): Add call to
3516 ns_draw_text_decoration. Change treatment of cursor drawing to
8d5ed899 3517 accommodate underlining, etc.
4843aac3 3518
4cc60b9b
EZ
35192011-07-28 Eli Zaretskii <eliz@gnu.org>
3520
bc7ece87
EZ
3521 * buffer.c (init_buffer_once): Set bidi-display-reordering to t by
3522 default.
4cc60b9b 3523
476371c4
PE
35242011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3525
66606eea
PE
3526 * alloc.c (memory_full) [!SYNC_INPUT]: Fix signal-related race.
3527 Without this fix, if a signal arrives just after memory fills up,
3528 'malloc' might be invoked reentrantly.
3529
476371c4
PE
3530 * image.c (x_check_image_size) [!HAVE_X_WINDOWS]: Return 1.
3531 In other words, assume that every image size is allowed, on non-X
3532 hosts. This assumption is probably wrong, but it lets Emacs compile.
3533
f3fcc40d
AS
35342011-07-28 Andreas Schwab <schwab@linux-m68k.org>
3535
3536 * regex.c (re_iswctype): Convert return values to boolean.
3537
350c992f
EZ
35382011-07-28 Eli Zaretskii <eliz@fencepost.gnu.org>
3539
3540 * xdisp.c (compute_display_string_pos): Don't use cached display
3541 string position if the buffer had its restriction changed.
3542 (Bug#9184)
3543
5266b4bb
PE
35442011-07-28 Paul Eggert <eggert@cs.ucla.edu>
3545
3546 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
3547
2573a837 35482011-07-28 Paul Eggert <eggert@cs.ucla.edu>
ca4aa935 3549
41f55ccd 3550 Integer signedness and overflow and related fixes. (Bug#9079)
cf950e6b 3551
39e378da
PE
3552 * bidi.c: Integer size and overflow fixes.
3553 (bidi_cache_size, bidi_cache_idx, bidi_cache_last_idx)
3554 (bidi_cache_start, bidi_cache_fetch_state, bidi_cache_search)
3555 (bidi_cache_find_level_change, bidi_cache_ensure_space)
3556 (bidi_cache_iterator_state, bidi_cache_find, bidi_cache_start_stack)
3557 (bidi_find_other_level_edge):
3558 Use ptrdiff_t instead of EMACS_INT where either will do.
3559 This works better on 32-bit hosts configured --with-wide-int.
3560 (bidi_cache_ensure_space): Check for size-calculation overflow.
3561 Use % rather than repeated addition, for better worst-case speed.
3562 Don't set bidi_cache_size until after xrealloc returns, because it
3563 might not return.
3564 (bidi_dump_cached_states): Use ptrdiff_t, not int, to avoid overflow.
f0eb61e9
PE
3565 (bidi_cache_ensure_space): Also check that the bidi cache size
3566 does not exceed that of the largest Lisp string or buffer. See Eli
3567 Zaretskii in <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#29>.
39e378da 3568
5e927815
PE
3569 * alloc.c (__malloc_size_t): Remove.
3570 All uses replaced by size_t. See Andreas Schwab's note
3571 <http://debbugs.gnu.org/cgi/bugreport.cgi?bug=9079#8>.
3572
ca4aa935
PE
3573 * image.c: Improve checking for integer overflow.
3574 (check_image_size): Assume that f is nonnull, since
3575 it is always nonnull in practice. This is one less thing to
3576 worry about when checking for integer overflow later.
3577 (x_check_image_size): New function, which checks for integer
3578 overflow issues inside X.
3579 (x_create_x_image_and_pixmap, xbm_read_bitmap_data): Use it.
3580 This removes the need for a memory_full check.
3581 (xbm_image_p): Rewrite to avoid integer multiplication overflow.
3582 (Create_Pixmap_From_Bitmap_Data, xbm_load): Use x_check_image_size.
3583 (xbm_read_bitmap_data): Change locals back to 'int', since
3584 their values must fit in 'int'.
3585 (xpm_load_image, png_load, tiff_load):
3586 Invoke x_create_x_image_and_pixmap earlier,
3587 to avoid much needless work if the image is too large.
3588 (tiff_load): Treat overly large images as if
3589 x_create_x_image_and_pixmap failed, not as malloc failures.
3590 (gs_load): Use x_check_image_size.
3591
5f8f9cc2
PE
3592 * gtkutil.c: Omit integer casts.
3593 (xg_get_pixbuf_from_pixmap): Remove unnecessary cast.
3594 (xg_set_toolkit_scroll_bar_thumb): Rewrite to avoid need for cast.
3595
5adf60bc
PE
3596 * image.c (png_load): Don't assume height * row_bytes fits in 'int'.
3597
c8907a93
PE
3598 * xfaces.c (Fbitmap_spec_p): Fix integer overflow bug.
3599 Without this fix, (bitmap-spec-p '(34359738368 1 "x"))
3600 would wrongly return t on a 64-bit host.
3601
e3c25c68
PE
3602 * dispnew.c (init_display): Use *_RANGE_OVERFLOW macros.
3603 The plain *_OVERFLOW macros run afoul of GCC bug 49705
3604 <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=49705>
3605 and therefore cause GCC to emit a bogus diagnostic in some cases.
3606
3f791afe
PE
3607 * image.c: Integer signedness and overflow and related fixes.
3608 This is not an exhaustive set of fixes, but it's time to
3609 record what I've got.
3610 (lookup_pixel_color, check_image_size): Remove redundant decls.
3611 (check_image_size): Don't assume that arbitrary EMACS_INT values
3612 fit in 'int', or that arbitrary 'double' values fit in 'int'.
3613 (x_alloc_image_color, x_create_x_image_and_pixmap, png_load)
3614 (tiff_load, imagemagick_load_image):
3615 Check for overflow in size calculations.
3616 (x_create_x_image_and_pixmap): Remove unnecessary test for
3617 xmalloc returning NULL; that can't happen.
3618 (xbm_read_bitmap_data): Don't assume sizes fit into 'int'.
3619 (xpm_color_bucket): Use better integer hashing function.
3620 (xpm_cache_color): Don't possibly over-allocate memory.
3621 (struct png_memory_storage, tiff_memory_source, tiff_seek_in_memory)
3622 (gif_memory_source):
3623 Use ptrdiff_t, not int or size_t, to record sizes.
3624 (png_load): Don't assume values greater than 2**31 fit in 'int'.
3625 (our_stdio_fill_input_buffer): Prefer ptrdiff_t to size_t when
3626 either works, as we prefer signed integers.
3627 (tiff_read_from_memory, tiff_write_from_memory):
3628 Return tsize_t, not size_t, since that's what the TIFF API wants.
3629 (tiff_read_from_memory): Don't fail simply because the read would
3630 go past EOF; instead, return a short read.
3631 (tiff_load): Omit no-longer-needed casts.
3632 (Fimagemagick_types): Don't assume size fits into 'int'.
3633
3cc5a532
PE
3634 Improve hashing quality when configured --with-wide-int.
3635 * fns.c (hash_string): New function, taken from sxhash_string.
3636 Do not discard information about ASCII character case; this
3637 discarding is no longer needed.
3638 (sxhash-string): Use it. Change sig to match it. Caller changed.
3639 * lisp.h: Declare it.
3640 * lread.c (hash_string): Remove, since we now use fns.c's version.
3641 The fns.c version returns a wider integer if --with-wide-int is
3642 specified, so this should help the quality of the hashing a bit.
3643
b312a492
PE
3644 * emacs.c: Integer overflow minor fix.
3645 (heap_bss_diff): Now uprintmax_t, not unsigned long. All used changed.
3646 Define only if GNU_LINUX.
3647 (main, Fdump_emacs): Set and use heap_bss_diff only if GNU_LINUX.
3648
dfd153ae
PE
3649 * dispnew.c: Integer signedness and overflow fixes.
3650 Remove unnecessary forward decls, that were a maintenance hassle.
3651 (history_tick): Now uprintmax_t, so it's more likely to avoid overflow.
3652 All uses changed.
3653 (adjust_glyph_matrix, realloc_glyph_pool, adjust_frame_message_buffer)
3654 (scrolling_window): Use ptrdiff_t, not int, for byte count.
3655 (prepare_desired_row, line_draw_cost):
3656 Use int, not unsigned, where either works.
3657 (save_current_matrix, restore_current_matrix):
3658 Use ptrdiff_t, not size_t, where either works.
3659 (init_display): Check for overflow more accurately, and without
3660 relying on undefined behavior.
3661
a81d11a3
PE
3662 * editfns.c (pWIDE, pWIDElen, signed_wide, unsigned_wide):
3663 Remove, replacing with the new symbols in lisp.h. All uses changed.
3664 * fileio.c (make_temp_name):
3665 * filelock.c (lock_file_1, lock_file):
3666 * xdisp.c (message_dolog):
3667 Don't assume PRIdMAX etc. works; this isn't portable to pre-C99 hosts.
3668 Use pMd etc. instead.
3669 * lisp.h (printmax_t, uprintmax_t, pMd, pMu): New types and macros,
3670 replacing the pWIDE etc. symbols removed from editfns.c.
3671
3300e6fd
PE
3672 * keyboard.h (num_input_events): Now uintmax_t.
3673 This is (very slightly) less likely to mess up due to wraparound.
3674 All uses changed.
3675
fd05c7e9
PE
3676 * buffer.c: Integer signedness fixes.
3677 (alloc_buffer_text, enlarge_buffer_text):
3678 Use ptrdiff_t rather than size_t when either will do, as we prefer
3679 signed integers.
3680
903fe15d
PE
3681 * alloc.c: Integer signedness and overflow fixes.
3682 Do not impose an arbitrary 32-bit limit on malloc sizes when debugging.
3683 (__malloc_size_t): Default to size_t, not to int.
3684 (pure_size, pure_bytes_used_before_overflow, stack_copy_size)
3685 (Fgarbage_collect, mark_object_loop_halt, mark_object):
3686 Prefer ptrdiff_t to size_t when either would do, as we prefer
3687 signed integers.
3688 (XMALLOC_OVERRUN_CHECK_OVERHEAD): New macro.
3689 (xmalloc_overrun_check_header, xmalloc_overrun_check_trailer):
3690 Now const. Initialize with values that are in range even if char
3691 is signed.
3692 (XMALLOC_PUT_SIZE, XMALLOC_GET_SIZE): Remove, replacing with ...
3693 (xmalloc_put_size, xmalloc_get_size): New functions. All uses changed.
3694 These functions do the right thing with sizes > 2**32.
3695 (check_depth): Now ptrdiff_t, not int.
3696 (overrun_check_malloc, overrun_check_realloc, overrun_check_free):
3697 Adjust to new way of storing sizes. Check for size overflow bugs
3698 in rest of code.
3699 (STRING_BYTES_MAX): Adjust to new overheads. The old code was
3700 slightly wrong anyway, as it missed one instance of
3701 XMALLOC_OVERRUN_CHECK_OVERHEAD.
3702 (refill_memory_reserve): Omit needless cast to size_t.
3703 (mark_object_loop_halt): Mark as externally visible.
3704
ac82cc6a
PE
3705 * xselect.c: Integer signedness and overflow fixes.
3706 (Fx_register_dnd_atom, x_handle_dnd_message):
3707 Use ptrdiff_t, not size_t, since we prefer signed.
3708 (Fx_register_dnd_atom): Check for ptrdiff_t (and size_t) overflow.
3709 * xterm.h (struct x_display_info): Use ptrdiff_t, not size_t, for
3710 x_dnd_atoms_size and x_dnd_atoms_length.
3711
c2d1e36d
PE
3712 * doprnt.c: Prefer signed to unsigned when either works.
3713 * eval.c (verror):
3714 * doprnt.c (doprnt):
3715 * lisp.h (doprnt):
3716 * xdisp.c (vmessage):
3717 Use ptrdiff_t, not size_t, when using or implementing doprnt,
3718 since the sizes cannot exceed ptrdiff_t bounds anyway, and we
3719 prefer signed arithmetic to avoid comparison confusion.
3720 * doprnt.c (doprnt): Avoid a "+ 1" that can't overflow,
3721 but is a bit tricky.
3722
0e926e56
PE
3723 Assume freestanding C89 headers, string.h, stdlib.h.
3724 * data.c, doprnt.c, floatfns.c, print.c:
3725 Include float.h unconditionally.
3726 * gmalloc.c: Assume C89-at-least behavior for preprocessor,
3727 limits.h, stddef.h, string.h. Use memset instead of 'flood'.
3728 * regex.c: Likewise for stddef.h, string.h.
3729 (ISASCII): Remove; can assume it returns 1 now. All uses removed.
3730 * s/aix4-2.h (HAVE_STRING_H): Remove obsolete undef.
3731 * s/ms-w32.h (HAVE_LIMITS_H, HAVE_STRING_H, HAVE_STDLIB_H)
3732 (STDC_HEADERS): Remove obsolete defines.
3733 * sysdep.c: Include limits.h unconditionally.
3734
9cfdb3ec
PE
3735 Assume support for memcmp, memcpy, memmove, memset.
3736 * lisp.h, sysdep.c (memcmp, memcpy, memmove, memset):
3737 * regex.c (memcmp, memcpy):
3738 Remove; we assume C89 now.
3739
3740 * gmalloc.c (memcpy, memset, memmove): Remove; we assume C89 now.
3741 (__malloc_safe_bcopy): Remove; no longer needed.
3742
cf950e6b 3743 * lisp.h (struct vectorlike_header, struct Lisp_Subr): Signed sizes.
6089c567
PE
3744 Use EMACS_INT, not EMACS_UINT, for sizes. The code works equally
3745 well either way, and we prefer signed to unsigned.
3746
dbf38e02
LMI
37472011-07-27 Lars Magne Ingebrigtsen <larsi@gnus.org>
3748
3749 * gnutls.c (emacs_gnutls_read): Don't message anything if the peer
3750 closes the connection while we're reading (bug#9182).
3751
d6f0886c 37522011-07-25 Jan Djärv <jan.h.d@swipnet.se>
24e0f6b1 3753
d6f0886c
JD
3754 * nsmenu.m (ns_popup_dialog): Add an "ok" button if no buttons
3755 are specified (Bug#9168).
24e0f6b1 3756
2eb1f9e6
PE
37572011-07-25 Paul Eggert <eggert@cs.ucla.edu>
3758
3759 * bidi.c (bidi_dump_cached_states): Fix printf format mismatch.
3760 Found by GCC static checking and --with-wide-int on a 32-bit host.
3761
22381272 37622011-07-25 Eli Zaretskii <eliz@gnu.org>
7daee910
EZ
3763
3764 * xdisp.c (compute_display_string_pos): Fix logic of caching
3765 previous display string position. Initialize cached_prev_pos to
3766 -1. Fixes slow-down at the beginning of a buffer.
3767
f25e39b4
EZ
37682011-07-24 Eli Zaretskii <eliz@gnu.org>
3769
3770 * xfaces.c (check_lface_attrs) [HAVE_WINDOW_SYSTEM]: Allow `nil'
3771 for attrs[LFACE_FONTSET_INDEX].
3772
04c4b52e
PE
37732011-07-23 Paul Eggert <eggert@cs.ucla.edu>
3774
3775 * xml.c (parse_region): Remove unused local
3776 that was recently introduced.
3777
c1734fbd
EZ
37782011-07-23 Eli Zaretskii <eliz@gnu.org>
3779
be18c5a5
EZ
3780 * xfns.c (unwind_create_frame) [GLYPH_DEBUG]: Adapt to changes in
3781 2008-02-22T17:42:09Z!monnier@iro.umontreal.ca.
3782
c1734fbd
EZ
3783 * xdisp.c (move_it_in_display_line_to): Record the best matching
3784 position for TO_CHARPOS while scanning the line, and restore it on
640c8776
SM
3785 exit if none of the characters scanned was an exact match.
3786 Fixes vertical-motion and pos-visible-in-window-p under bidi redisplay
a9269c18
EZ
3787 when exact match is impossible due to invisible text, and the
3788 lines are truncated.
3789
a258d627
JD
37902011-07-23 Jan Djärv <jan.h.d@swipnet.se>
3791
3792 * nsterm.m (initFrameFromEmacs): Set NSTitledWindowMask in styleMask
3793 for OSX >= 10.7.
3794
b6d5a689
EZ
37952011-07-22 Eli Zaretskii <eliz@gnu.org>
3796
0f74f785
EZ
3797 Fix a significant slow-down of cursor motion with C-n, C-p,
3798 C-f/C-b, and C-v/M-v that couldn't keep up with keyboard
3799 auto-repeat under bidi redisplay in fontified buffers.
b6d5a689 3800 * xdisp.c (compute_stop_pos_backwards): New function.
b6d5a689
EZ
3801 (next_element_from_buffer): Call compute_stop_pos_backwards to
3802 find a suitable prev_stop when we find ourselves before
0f74f785
EZ
3803 base_level_stop.
3804 (reseat): Don't look for prev_stop, as that could mean a very long
3805 run.
3806 <cached_disp_pos, cached_disp_buffer, cached_disp_modiff>
3807 <cached_disp_overlay_modiff>: Cache for last found display string
3808 position.
551918c1 3809 (compute_display_string_pos): Return the cached position if asked
0f74f785
EZ
3810 about the same buffer in the same area of character positions, and
3811 the buffer wasn't changed since the time the display string
3812 position was cached.
551918c1 3813
b2d0c91a
EZ
38142011-07-22 Eli Zaretskii <eliz@gnu.org>
3815
3816 * xdisp.c (rows_from_pos_range): Don't ignore glyphs whose object
3817 is an integer, which is important for empty lines. (Bug#9149)
3818
043604ee
CY
38192011-07-22 Chong Yidong <cyd@stupidchicken.com>
3820
3821 * frame.c (Fmodify_frame_parameters): In tty case, update the
3822 default face if necessary (Bug#4238).
3823
da4adb04
CY
38242011-07-21 Chong Yidong <cyd@stupidchicken.com>
3825
3826 * editfns.c (Fstring_to_char): No need to explain what a character
3827 is in the docstring (Bug#6576).
3828
9abd0532
LMI
38292011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3830
3831 * xml.c (parse_region): Make sure we always return a tree.
3832
36881d16
HK
38332011-07-20 HAMANO Kiyoto <khiker.mail@gmail.com>
3834
3835 * xml.c (parse_region): If a document contains only comments,
3836 return that, too.
3837
1e98674d
LMI
38382011-07-20 Lars Magne Ingebrigtsen <larsi@gnus.org>
3839
3840 * xml.c (make_dom): Return comments, too.
3841
590bd467
PE
38422011-07-19 Paul Eggert <eggert@cs.ucla.edu>
3843
3844 Port to OpenBSD.
3845 See http://lists.gnu.org/archive/html/emacs-devel/2011-07/msg00688.html
3846 and the surrounding thread.
3847 * minibuf.c (read_minibuf_noninteractive): Rewrite to use getchar
3848 rather than fgets, and retry after EINTR. Otherwise, 'emacs
3849 --batch -f byte-compile-file' fails on OpenBSD if an inactivity
3850 timer goes off.
3851 * s/openbsd.h (BROKEN_SIGIO): Define.
3852 * unexelf.c (unexec) [__OpenBSD__]:
3853 Don't update the .mdebug section of the Alpha COFF symbol table.
3854
f41628b2
LMI
38552011-07-19 Lars Magne Ingebrigtsen <larsi@gnus.org>
3856
3857 * lread.c (syms_of_lread): Clarify when `lexical-binding' is used
3858 (bug#8460).
3859
b59b67c5
PE
38602011-07-18 Paul Eggert <eggert@cs.ucla.edu>
3861
15e3a074
PE
3862 * fileio.c (Fcopy_file) [!MSDOS]: Tighten created file's mask.
3863 This fixes some race conditions on the permissions of any newly
3864 created file.
3865
41bed37d
PE
3866 * alloc.c (valid_pointer_p): Use pipe, not open.
3867 This fixes some permissions issues when debugging.
3868
b59b67c5
PE
3869 * fileio.c (Fcopy_file): Adjust mode if fchown fails. (Bug#9002)
3870 If fchown fails to set both uid and gid, try to set just gid,
3871 as that is sometimes allowed. Adjust the file's mode to eliminate
3872 setuid or setgid bits that are inappropriate if fchown fails.
3873
925a6be7
SM
38742011-07-18 Stefan Monnier <monnier@iro.umontreal.ca>
3875
3876 * xdisp.c (next_element_from_string, next_element_from_buffer): Use EQ
3877 to compare Lisp_Objects.
3878 * gnutls.c (syms_of_gnutls): Rename Vgnutls_log_level to
3879 global_gnutls_log_level, don't mistake it for a Lisp_Object.
3880 (init_gnutls_functions, emacs_gnutls_handle_error): Fix up uses.
3881
52968808
AS
38822011-07-17 Andreas Schwab <schwab@linux-m68k.org>
3883
0a6a104b
AS
3884 * lread.c (read_integer): Unread even EOF character.
3885 (read1): Likewise. Properly record start position of symbol.
3886
52968808
AS
3887 * lread.c (read1): Read `#:' as empty uninterned symbol if no
3888 symbol character follows.
3889
9e381cdd
PE
38902011-07-17 Paul Eggert <eggert@cs.ucla.edu>
3891
3892 * fileio.c (Fcopy_file): Pacify gcc re fchown. (Bug#9002)
3893 This works around a problem with the previous change to Fcopy_file.
3894 Recent glibc declares fchown with __attribute__((warn_unused_result)),
3895 and without this change, GCC might complain about discarding
3896 fchown's return value.
3897
b5641435
JB
38982011-07-16 Juanma Barranquero <lekktu@gmail.com>
3899
3900 * makefile.w32-in (GLOBAL_SOURCES): Add gnutls.c (followup to bug#9059).
3901
a8031457
PE
39022011-07-16 Paul Eggert <eggert@cs.ucla.edu>
3903
3904 * fileio.c (Fcopy_file): Don't diagnose fchown failures. (Bug#9002)
3905
dd889327
LMI
39062011-07-16 Lars Magne Ingebrigtsen <larsi@gnus.org>
3907
750c33f7
LMI
3908 * gnutls.c (syms_of_gnutls): Define `gnutls-log-level' here, since
3909 it's used from the C level.
3910
dd889327
LMI
3911 * process.c: Use the same condition for POLL_FOR_INPUT in both
3912 keyboard.c and process.c (bug#1858).
3913
87e86684
LM
39142011-07-09 Lawrence Mitchell <wence@gmx.li>
3915
3916 * gnutls.c (Qgnutls_bootprop_min_prime_bits): New variable.
3917 (Fgnutls_boot): Use it.
3918
64348f40
AS
39192011-07-15 Andreas Schwab <schwab@linux-m68k.org>
3920
3921 * doc.c (Fsubstitute_command_keys): Revert last change.
3922
1d698799
LMI
39232011-07-15 Lars Magne Ingebrigtsen <larsi@gnus.org>
3924
f863868c
LMI
3925 * doc.c (Fsubstitute_command_keys): Clarify that \= really only
3926 quotes the next character, and doesn't affect other longer
3927 sequences (bug#8935).
3928
1d698799
LMI
3929 * lread.c (syms_of_lread): Clarify that is isn't only
3930 `eval-buffer' and `eval-defun' that's affected by
3931 `lexical-binding' (bug#8460).
3932
aa4b6df6
EZ
39332011-07-15 Eli Zaretskii <eliz@gnu.org>
3934
3935 * xdisp.c (move_it_in_display_line_to): Fix vertical motion with
6b02f655 3936 bidi redisplay when a line includes both an image and is truncated.
aa4b6df6 3937
5d856da6
PE
39382011-07-14 Paul Eggert <eggert@cs.ucla.edu>
3939
ad6042bb
PE
3940 Fix minor problems found by static checking.
3941 * bidi.c (bidi_cache_size): Now EMACS_INT, not size_t.
3942 (elsz): Now a signed constant, not a size_t var. We prefer signed
3943 types to unsigned, to avoid integer comparison confusion. Without
3944 this change, GCC 4.6.1 with -Wunsafe-loop-optimizations complains
3945 "cannot optimize loop, the loop counter may overflow", a symptom
3946 of the confusion.
f00bbb22 3947 * indent.c (Fvertical_motion): Mark locals as initialized.
5d856da6
PE
3948 * xdisp.c (reseat_to_string): Fix pointer signedness issue.
3949
6468f31c
LMI
39502011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
3951
49080b10
LMI
3952 * search.c (Fre_search_backward): Mention `case-fold-search' in
3953 all the re_search_* functions (bug#8138).
3954
6468f31c
LMI
3955 * keyboard.c (Fopen_dribble_file): Document when the file is
3956 closed (bug#8056).
3957
c965adc5
EZ
39582011-07-14 Eli Zaretskii <eliz@gnu.org>
3959
df9733bf
EZ
3960 * bidi.c (bidi_dump_cached_states): Fix format of displaying
3961 bidi_cache_idx.
3962
0bb23927
EZ
3963 Support bidi reordering of display and overlay strings.
3964 * xdisp.c (compute_display_string_pos)
3965 (compute_display_string_end): Accept additional argument STRING.
3966 (init_iterator, reseat_1): Initialize bidi_it->string.s to NULL.
3967 (reseat_to_string): Initialize bidi_it->string.s and
3968 bidi_it->string.schars.
3969 (Fcurrent_bidi_paragraph_direction): Initialize itb.string.s to
640c8776
SM
3970 NULL (avoids a crash in bidi_paragraph_init).
3971 Initialize itb.string.lstring.
0bb23927
EZ
3972 (init_iterator): Call bidi_init_it only of a valid
3973 buffer position was specified. Initialize paragraph_embedding to
3974 L2R.
3975 (reseat_to_string): Initialize the bidi iterator.
3976 (display_string): If we need to ignore text properties of
3977 LISP_STRING, set IT->stop_charpos to IT->end_charpos. (The
3978 original value of -1 will not work with bidi.)
3979 (compute_display_string_pos): First arg is now struct
3980 `text_pos *'; all callers changed. Support display properties on
3981 Lisp strings.
3982 (compute_display_string_end): Support display properties on Lisp
3983 strings.
3984 (init_iterator, reseat_1, reseat_to_string): Initialize the
3985 string.bufpos member to 0 (zero, for compatibility with IT_CHARPOS
3986 when iterating on a string not from display properties).
640c8776
SM
3987 (compute_display_string_pos, compute_display_string_end):
3988 Fix calculation of the object to scan. Fixes an error when using
0bb23927
EZ
3989 arrow keys.
3990 (next_element_from_buffer): Don't abort when IT_CHARPOS is before
640c8776
SM
3991 base_level_stop; instead, set base_level_stop to BEGV.
3992 Fixes crashes in vertical-motion.
0bb23927
EZ
3993 (next_element_from_buffer): Improve commentary for when
3994 the iterator is before prev_stop.
3995 (init_iterator): Initialize bidi_p from the default value of
3996 bidi-display-reordering, not from buffer-local value. Use the
3997 buffer-local value only if initializing for buffer iteration.
3998 (handle_invisible_prop): Support invisible properties on strings
3999 that are being bidi-reordered.
4000 (set_iterator_to_next): Support bidi reordering of C strings and
4001 Lisp strings.
4002 (next_element_from_string): Support bidi reordering of Lisp
4003 strings.
4004 (handle_stop_backwards): Support Lisp strings as well.
640c8776
SM
4005 (display_string): Support display of R2L glyph rows.
4006 Use IT_STRING_CHARPOS when displaying from a Lisp string.
0bb23927
EZ
4007 (init_iterator): Don't initialize it->bidi_p for strings
4008 here.
4009 (reseat_to_string): Initialize it->bidi_p for strings here.
4010 (next_element_from_string, next_element_from_c_string)
4011 (next_element_from_buffer): Add xassert's for correspondence
4012 between IT's object being iterated and it->bidi_it.string
4013 structure.
4014 (face_before_or_after_it_pos): Support bidi iteration.
4015 (next_element_from_c_string): Handle the case of the first string
4016 character that is not the first one in the visual order.
4017 (get_visually_first_element): New function, refactored from common
4018 parts of next_element_from_buffer, next_element_from_string, and
4019 next_element_from_c_string.
4020 (tool_bar_lines_needed, redisplay_tool_bar)
4021 (display_menu_bar): Force left-to-right direction. Add a FIXME
4022 comment for making that be controlled by a user option.
4023 (push_it, pop_it): Save and restore the state of the
4024 bidi iterator. Save and restore the bidi_p flag.
4025 (pop_it): Iterate out of display property for string iteration as
4026 well.
4027 (iterate_out_of_display_property): Support iteration over strings.
4028 (handle_single_display_spec): Set up it->bidi_it for iteration
4029 over a display string, and call bidi_init_it.
4030 (handle_single_display_spec, next_overlay_string)
4031 (get_overlay_strings_1, push_display_prop): Set up the bidi
4032 iterator for displaying display or overlay strings.
4033 (forward_to_next_line_start): Don't use the shortcut if
4034 bidi-iterating.
4035 (back_to_previous_visible_line_start): If handle_display_prop
4036 pushed the iterator stack, restore the internal state of the bidi
4037 iterator by calling bidi_pop_it same number of times.
4038 (reseat_at_next_visible_line_start): If ON_NEWLINE_P is non-zero,
4039 and we are bidi-iterating, don't decrement the iterator position;
4040 instead, set the first_elt flag in the bidi iterator, to produce
4041 the same effect.
4042 (reseat_1): Remove redundant setting of string_from_display_prop_p.
4043 (push_display_prop): xassert that we are iterating a buffer.
4044 (push_it, pop_it): Save and restore paragraph_embedding member.
4045 (handle_single_display_spec, next_overlay_string)
4046 (get_overlay_strings_1, reseat_1, reseat_to_string)
4047 (push_display_prop): Set up the `unibyte' member of bidi_it.string
4048 correctly. Don't assume unibyte strings are not bidi-reordered.
4049 (compute_display_string_pos)
4050 (compute_display_string_end): Fix handling the case of C string.
4051 (push_it, pop_it): Save and restore from_disp_prop_p.
4052 (handle_single_display_spec, push_display_prop): Set the
4053 from_disp_prop_p flag.
4054 (get_overlay_strings_1): Reset the from_disp_prop_p flag.
4055 (pop_it): Call iterate_out_of_display_property only if we are
4056 popping after iteration over a string that came from a display
4057 property. Fix a typo in popping stretch info. Add an assertion
4058 for verifying that the iterator position is in sync with the bidi
4059 iterator.
4060 (handle_single_display_spec, get_overlay_strings_1)
4061 (push_display_prop): Fix initialization of paragraph direction for
4062 string when that of the parent object is not yet determined.
4063 (reseat_1): Call bidi_init_it to resync the bidi
4064 iterator with IT's position. (Bug#7616)
4065 (find_row_edges): If ROW->start.pos gives position
4066 smaller than min_pos, use it as ROW->minpos. (Bug#7616)
4067 (handle_stop, back_to_previous_visible_line_start, reseat_1):
4068 Reset the from_disp_prop_p flag.
4069 (SAVE_IT, RESTORE_IT): New macros.
4070 (pos_visible_p, face_before_or_after_it_pos)
4071 (back_to_previous_visible_line_start)
4072 (move_it_in_display_line_to, move_it_in_display_line)
4073 (move_it_to, move_it_vertically_backward, move_it_by_lines)
4074 (try_scrolling, redisplay_window, display_line): Use them when
4075 saving a temporary copy of the iterator and restoring it back.
4076 (back_to_previous_visible_line_start, reseat_1)
4077 (init_iterator): Empty the bidi cache "stack".
4078 (move_it_in_display_line_to): If iterator ended up at
4079 EOL, but we never saw any buffer positions smaller than
4080 to_charpos, return MOVE_POS_MATCH_OR_ZV. Fixes vertical cursor
4081 motion in bidi-reordered lines.
4082 (move_it_in_display_line_to): Record prev_method and prev_pos
4083 immediately before the call to set_iterator_to_next. Fixes cursor
4084 motion in bidi-reordered lines with stretch glyphs and strings
4085 displayed in margins. (Bug#8133) (Bug#8867)
4086 Return MOVE_POS_MATCH_OR_ZV only if iterator position is past
4087 TO_CHARPOS.
640c8776
SM
4088 (pos_visible_p): Support positions in bidi-reordered lines.
4089 Save and restore bidi cache.
0bb23927
EZ
4090
4091 * bidi.c (bidi_level_of_next_char): clen should be EMACS_NT, not int.
4092 (bidi_paragraph_info): Delete unused struct.
4093 (bidi_cache_idx, bidi_cache_last_idx): Declare EMACS_INT.
4094 (bidi_cache_start): New variable.
4095 (bidi_cache_reset): Reset bidi_cache_idx to bidi_cache_start, not
4096 to zero.
4097 (bidi_cache_fetch_state, bidi_cache_search)
4098 (bidi_cache_find_level_change, bidi_cache_iterator_state)
4099 (bidi_cache_find, bidi_peek_at_next_level)
4100 (bidi_level_of_next_char, bidi_find_other_level_edge)
4101 (bidi_move_to_visually_next): Compare cache index with
4102 bidi_cache_start rather than with zero.
4103 (bidi_fetch_char): Accept new argument STRING; all callers
4104 changed. Support iteration over a string. Support strings with
4105 display properties. Support unibyte strings. Fix the type of
4106 `len' according to what STRING_CHAR_AND_LENGTH expects.
4107 (bidi_paragraph_init, bidi_resolve_explicit_1)
4108 (bidi_resolve_explicit, bidi_resolve_weak)
640c8776
SM
4109 (bidi_level_of_next_char, bidi_move_to_visually_next):
4110 Support iteration over a string.
0bb23927
EZ
4111 (bidi_set_sor_type, bidi_resolve_explicit_1)
4112 (bidi_resolve_explicit, bidi_type_of_next_char): ignore_bn_limit
4113 can now be zero (for strings); special values 0 and -1 were
4114 changed to -1 and -2, respectively.
4115 (bidi_char_at_pos): New function.
4116 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak):
4117 Call it instead of FETCH_MULTIBYTE_CHAR.
4118 (bidi_move_to_visually_next): Abort if charpos or bytepos were not
4119 initialized to valid values.
4120 (bidi_init_it): Don't initialize charpos and bytepos with invalid
4121 values.
4122 (bidi_level_of_next_char): Allow the sentinel "position" to pass
4123 the test for valid cached positions. Fix the logic for looking up
4124 the sentinel state in the cache. GCPRO the Lisp string we are
4125 iterating.
4126 (bidi_push_it, bidi_pop_it): New functions.
4127 (bidi_initialize): Initialize the bidi cache start stack pointer.
4128 (bidi_cache_ensure_space): New function, refactored from part of
4129 bidi_cache_iterator_state. Don't assume the required size is just
4130 one BIDI_CACHE_CHUNK away.
4131 (bidi_cache_start_stack, bidi_push_it): Use IT_STACK_SIZE.
4132 (bidi_count_bytes, bidi_char_at_pos): New functions.
4133 (bidi_cache_search): Don't assume bidi_cache_last_idx is
4134 always valid if bidi_cache_idx is valid.
4135 (bidi_cache_find_level_change): xassert that bidi_cache_last_idx
4136 is valid if it's going to be used.
4137 (bidi_shelve_cache, bidi_unshelve_cache): New functions.
4138 (bidi_cache_fetch_state, bidi_cache_search)
c965adc5
EZ
4139 (bidi_cache_find_level_change, bidi_cache_ensure_space)
4140 (bidi_cache_iterator_state, bidi_cache_find)
640c8776
SM
4141 (bidi_find_other_level_edge, bidi_cache_start_stack):
4142 All variables related to cache indices are now EMACS_INT.
c965adc5 4143
0bb23927
EZ
4144 * dispextern.h (struct bidi_string_data): New structure.
4145 (struct bidi_it): New member `string'. Make flag members be 1-bit
4146 fields, and put them last in the struct.
640c8776
SM
4147 (compute_display_string_pos, compute_display_string_end):
4148 Update prototypes.
0bb23927
EZ
4149 (bidi_push_it, bidi_pop_it): Add prototypes.
4150 (struct iterator_stack_entry): New members bidi_p,
4151 paragraph_embedding, and from_disp_prop_p.
4152 (struct it): Member bidi_p is now a bit field 1 bit wide.
640c8776
SM
4153 (bidi_shelve_cache, bidi_unshelve_cache):
4154 Declare prototypes.
0bb23927
EZ
4155
4156 * .gdbinit (xvectype, xvector, xcompiled, xchartable, xboolvector)
4157 (xpr, xfont, xbacktrace): Use "header.size" when accessing vectors
4158 and vector-like objects.
4159
4160 * dispnew.c (buffer_posn_from_coords): Save and restore the bidi
4161 cache around display iteration.
4162
4163 * window.c (Fwindow_end, window_scroll_pixel_based)
4164 (displayed_window_lines, Frecenter): Save and restore the bidi
4165 cache around display iteration.
4166
3bbd2265
LMI
41672011-07-14 Lars Magne Ingebrigtsen <larsi@gnus.org>
4168
4169 * editfns.c (Fdelete_region): Clarify the use of the named
4170 parameters (bug#6788).
4171
adc47434
MR
41722011-07-14 Martin Rudalics <rudalics@gmx.at>
4173
4174 * indent.c (Fvertical_motion): Set and restore w->pointm when
4175 saving and restoring the window's buffer (Bug#9006).
4176
837c31f8
LMI
41772011-07-13 Lars Magne Ingebrigtsen <larsi@gnus.org>
4178
4179 * editfns.c (Fstring_to_char): Clarify just what is returned
4180 (bug#6576). Text by Eli Zaretskii.
4181
ac389d0c
JB
41822011-07-13 Juanma Barranquero <lekktu@gmail.com>
4183
4184 * gnutls.c (init_gnutls_functions): Honor gnutls_log_level (bug#9059).
4185
0be0ce47
EZ
41862011-07-13 Eli Zaretskii <eliz@gnu.org>
4187
4188 * buffer.c (mmap_find): Fix a typo.
4189
cd18e7e3
JB
41902011-07-13 Johan Bockgård <bojohan@gnu.org>
4191
4192 Fix execution of x selection hooks.
4193 * xselect.c (Qx_lost_selection_functions)
4194 (Qx_sent_selection_functions): New vars.
4195 (syms_of_xselect): DEFSYM them.
4196 (x_handle_selection_request): Pass Qx_sent_selection_functions
4197 rather than Vx_sent_selection_functions to Frun_hook_with_args.
4198 (x_handle_selection_clear,x_clear_frame_selections):
4199 Pass Qx_lost_selection_functions rather than
4200 Vx_lost_selection_functions to Frun_hook_with_args.
4201
47ea7f44
PE
42022011-07-13 Paul Eggert <eggert@cs.ucla.edu>
4203
ac389d0c 4204 * buffer.c (Fget_buffer_create): Initialize inhibit_shrinking.
2941c447
PE
4205 The old code sometimes used this field without initializing it.
4206
47ea7f44
PE
4207 * alloc.c (gc_sweep): Don't read past end of array.
4208 In theory, the old code could also have corrupted Emacs internals,
4209 though it'd be very unlikely.
4210
bc985c87
AS
42112011-07-12 Andreas Schwab <schwab@linux-m68k.org>
4212
4213 * character.c (Fcharacterp): Don't advertise optional ignored
ac389d0c 4214 argument. (Bug#4026)
bc985c87 4215
0cf34688
LMI
42162011-07-12 Lars Magne Ingebrigtsen <larsi@gnus.org>
4217
b3dadd76
LMI
4218 * keymap.c (syms_of_keymap): Clarify that "modifier" is "modifier
4219 key" (bug#4257).
4220
0cf34688
LMI
4221 * window.c (Fset_window_start): Doc fix (bug#4199).
4222 (Fset_window_hscroll): Ditto.
4223
270768cd
PE
42242011-07-12 Paul Eggert <eggert@cs.ucla.edu>
4225
077e3dda 4226 Fix minor new problems caught by GCC 4.6.1.
270768cd 4227 * term.c (init_tty): Remove unused local.
490011a6 4228 * xsettings.c (store_monospaced_changed): Define this function only
077e3dda 4229 if (defined HAVE_GSETTINGS || defined HAVE_GCONF), as it's
490011a6 4230 not used otherwise.
270768cd 4231
b1f58454
CY
42322011-07-12 Chong Yidong <cyd@stupidchicken.com>
4233
4234 * xdisp.c (Vresize_mini_windows): Minor doc fix (Bug#3300).
4235
22b9578d
LMI
42362011-07-11 Lars Magne Ingebrigtsen <larsi@gnus.org>
4237
6e70ab07
LMI
4238 * xdisp.c (syms_of_xdisp): Make it explicit that the mini-windows
4239 are the mini-buffer and the echo area (bug#3320).
4240
22b9578d
LMI
4241 * term.c (init_tty): Remove support for supdup, c10 and perq
4242 terminals, which are no longer supported (bug#1482).
4243
8974cc9f
JB
42442011-07-10 Johan Bockgård <bojohan@gnu.org>
4245
4246 * xdisp.c (Ftool_bar_lines_needed): Fix WINDOWP check.
4247
a560d974
JD
42482011-07-10 Jan Djärv <jan.h.d@swipnet.se>
4249
4250 * xmenu.c (menu_highlight_callback): Only pass frame to show_help_event
4251 for non-popups (Bug#3642).
4252
1dae0f0a
AS
42532011-07-10 Andreas Schwab <schwab@linux-m68k.org>
4254
268c2c36 4255 * alloc.c (reset_malloc_hooks): Protoize.
1dae0f0a 4256 * buffer.c (mmap_init, mmap_find, mmap_free_1, mmap_enlarge)
268c2c36
AS
4257 (mmap_set_vars, mmap_alloc, mmap_free, mmap_realloc): Likewise.
4258 * cm.c (losecursor): Likewise.
1dae0f0a
AS
4259 * data.c (fmod): Likewise.
4260 * dispnew.c (swap_glyphs_in_rows): Likewise.
4261 * emacs.c (memory_warning_signal): Likewise.
4262 * floatfns.c (float_error): Likewise.
4263 * font.c (check_gstring, check_otf_features, otf_tag_symbol)
4264 (otf_open, font_otf_capability, generate_otf_features)
4265 (font_otf_DeviceTable, font_otf_ValueRecord, font_otf_Anchor):
4266 Likewise.
4267 * image.c (pbm_read_file): Likewise.
4268 * indent.c (string_display_width): Likewise.
4269 * intervals.c (check_for_interval, search_for_interval)
4270 (inc_interval_count, count_intervals, root_interval)
4271 (adjust_intervals_for_insertion, make_new_interval): Likewise.
4272 * lread.c (defalias): Likewise.
268c2c36 4273 * ralloc.c (r_alloc_check): Likewise.
1dae0f0a
AS
4274 * regex.c (set_image_of_range_1, set_image_of_range)
4275 (regex_grow_registers): Likewise.
4276 * sysdep.c (strerror): Likewise.
4277 * termcap.c (valid_filename_p, tprint, main): Likewise.
4278 * tparam.c (main): Likewise.
4279 * unexhp9k800.c (run_time_remap, save_data_space)
4280 (update_file_ptrs, read_header, write_header, calculate_checksum)
4281 (copy_file, copy_rest, display_header): Likewise.
4282 * widget.c (mark_shell_size_user_specified, create_frame_gcs):
4283 Likewise.
4284 * xdisp.c (check_it): Likewise.
4285 * xfaces.c (register_color, unregister_color, unregister_colors):
4286 Likewise.
4287 * xfns.c (print_fontset_result): Likewise.
4288 * xrdb.c (member, fatal, main): Likewise.
4289
99033785
PE
42902011-07-10 Paul Eggert <eggert@cs.ucla.edu>
4291
4292 Fix minor problems found by static checking (Bug#9031).
4293 * chartab.c (char_table_set_range, map_sub_char_table):
4294 Remove unused locals.
4295 (uniprop_table): Now static.
4296 * composite.c (_work_char): Remove unused static var.
4297
9cb2ac56
JB
42982011-07-09 Juanma Barranquero <lekktu@gmail.com>
4299
4300 * chartab.c (uniprop_table_uncompress): Remove unused local variable.
4301
f25661f0
JD
43022011-07-09 Jan Djärv <jan.h.d@swipnet.se>
4303
4304 * gtkutil.c (qttip_cb): Remove code without function.
4305
8278c4fe
EZ
43062011-07-09 Eli Zaretskii <eliz@gnu.org>
4307
4308 * w32.c (pthread_sigmask): New stub.
4309
1692ae2d 43102011-07-08 Paul Eggert <eggert@cs.ucla.edu>
123403e4 4311
8a6ebd58 4312 Use pthread_sigmask, not sigprocmask (Bug#9010).
123403e4
PE
4313 sigprocmask is portable only for single-threaded applications, and
4314 Emacs can be multi-threaded when it uses GTK.
1301ac26
PE
4315 * Makefile.in (LIB_PTHREAD_SIGMASK): New macro.
4316 (LIBES): Use it.
4317 * callproc.c (Fcall_process):
4318 * process.c (create_process):
4319 * sysdep.c (sys_sigblock, sys_sigunblock, sys_sigsetmask):
4320 Use pthread_sigmask, not sigprocmask.
123403e4 4321
1b854618
JD
43222011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4323
4324 * gtkutil.c (qttip_cb): Set line wrap to FALSE for tooltip widget.
4325 (xg_prepare_tooltip): Revert text in x->ttip_lbl, margins was
4326 wrong (Bug#8591).
4327
3fe4b549
JD
43282011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4329
0ce7e563
JD
4330 * gtkutil.c (xg_prepare_tooltip): Fix indentation and comment.
4331 Put text in x->ttip_lbl instead of gtk_tooltip_set_text (Bug#8591).
4332 (xg_hide_tooltip): Fix comment.
4333
3fe4b549
JD
4334 * nsterm.m (initFrameFromEmacs): Don't use ns_return_types
4335 in registerServicesMenuSendTypes.
4336 (validRequestorForSendType): Don't check ns_return_types.
4337
4338 * nsfns.m (Fx_open_connection): Put NSStringPboardType into
4339 ns_return_type.
4340
5df75e47
JR
43412011-07-08 Jason Rumney <jasonr@gnu.org>
4342
22610910
JR
4343 * w32term.c (x_make_frame_visible): Use SH_SHOWNORMAL rather than
4344 SH_SHOW for hidden windows (Bug#5482).
4345
5df75e47
JR
4346 * w32fns.c (w32_wnd_proc) [WM_TIMER, WM_SET_CURSOR]: Avoid using
4347 frame struct members of non-existent frames (Bug#6284).
4348
699c10bd
JD
43492011-07-08 Jan Djärv <jan.h.d@swipnet.se>
4350
4393663b
JD
4351 * nsterm.m (keyDown): Call to wantsToDelayTextChangeNotifications and
4352 variable firstTime not needed on OSX >= 10.6.
4353 (setPosition): setFloatValue:knobProportion: is deprecated on OSX
4354 >= 10.5. Use setKnobProportion, setDoubleValue.
4355
4356 * nsterm.h (MAC_OS_X_VERSION_10_3, MAC_OS_X_VERSION_10_4)
4357 (MAC_OS_X_VERSION_10_5): Define if not defined.
4358 (EmacsView, EmacsTooltip): Implements NSWindowDelegate on OSX >= 10.6.
4359 (EmacsMenu): Implements NSMenuDelegate on OSX >= 10.6.
4360 (EmacsToolbar): Implements NSToolbarDelegate on OSX >= 10.6.
4361
4362 * nsselect.m (ns_string_from_pasteboard): Don't use deprecated methods
4363 cString and lossyCString on OSX >= 10.4
4364
58179cce 4365 * nsmenu.m (fillWithWidgetValue): Don't use deprecated method
4393663b
JD
4366 sizeToFit on OSX >= 10.2.
4367
4368 * nsimage.m (allocInitFromFile): Don't use deprecated method
4369 bestRepresentationForDevice on OSX >= 10.6.
4370
4371 * nsfns.m (check_ns_display_info): Cast to long and use %ld in error
4372 to avoid warning.
4373
4374 * emacs.c: Declare unexec_init_emacs_zone.
4375
a63e0781
JD
4376 * nsgui.h: Fix compiler warning about gnulib redefining verify.
4377
699c10bd
JD
4378 * nsselect.m (ns_get_local_selection): Change to extern (Bug#8842).
4379
4380 * nsmenu.m (ns_update_menubar): Remove useless setDelegate call
4381 on svcsMenu (Bug#8842).
4382
4383 * nsfns.m (Fx_open_connection): Remove NSStringPboardType from
4384 ns_return_types.
4385 (Fns_list_services): Just return Qnil on 10.6, code not working there.
4386
4387 * nsterm.m (QUTF8_STRING): Declare.
4388 (initFrameFromEmacs): Call registerServicesMenuSendTypes.
4389 (validRequestorForSendType): Return type is (id).
4390 Change indexOfObjectIdenticalTo to indexOfObject.
4391 Check if we have local selection before returning self (Bug#8842).
4392 (writeSelectionToPasteboard): Put local selection into paste board
4393 if we have a local selection (Bug#8842).
4394 (syms_of_nsterm): DEFSYM QUTF8_STRING.
4395
4396 * nsterm.h (MAC_OS_X_VERSION_10_6): Define here instead of nsterm.m.
4397 (ns_get_local_selection): Declare.
4398
54e10184
LMI
43992011-07-07 Lars Magne Ingebrigtsen <larsi@gnus.org>
4400
9888ff71
LMI
4401 * keymap.c (describe_map_tree): Don't insert a double newline at
4402 the end of the buffer (bug#1169) and return whether we inserted
4403 something.
4404
54e10184
LMI
4405 * callint.c (Fcall_interactively): Change "reading args" to
4406 "providing args" to try to clarify what it does (bug#1010).
4407
15fa4783
KH
44082011-07-07 Kenichi Handa <handa@m17n.org>
4409
4410 * composite.c (composition_compute_stop_pos): Ignore a static
4411 composition starting before CHARPOS (Bug#8915).
4412
4413 * xdisp.c (handle_composition_prop): Likewise.
4414
a8815b00
EZ
44152011-07-07 Eli Zaretskii <eliz@gnu.org>
4416
4417 * term.c (produce_glyphs) <xassert>: Allow IT_GLYPHLESS in it->what.
4418 (Bug#9015)
4419
ef7b981d 44202011-07-07 Kenichi Handa <handa@m17n.org>
c805dec0
KH
4421
4422 * character.h (unicode_category_t): New enum type.
4423
4424 * chartab.c (uniprop_decoder_t, uniprop_encoder_t): New types.
4425 (Qchar_code_property_table): New variable.
4426 (UNIPROP_TABLE_P, UNIPROP_GET_DECODER)
4427 (UNIPROP_COMPRESSED_FORM_P): New macros.
4428 (char_table_ascii): Uncompress the compressed values.
4429 (sub_char_table_ref): New arg is_uniprop. Callers changed.
4430 Uncompress the compressed values.
ac389d0c 4431 (sub_char_table_ref_and_range): Likewise.
c805dec0
KH
4432 (char_table_ref_and_range): Uncompress the compressed values.
4433 (sub_char_table_set): New arg is_uniprop. Callers changed.
4434 Uncompress the compressed values.
4435 (sub_char_table_set_range): Args changed. Callers changed.
4436 (char_table_set_range): Adjuted for the above change.
4437 (map_sub_char_table): Delete args default_val and parent. Add arg
4438 top. Give decoded values to a Lisp function.
640c8776 4439 (map_char_table): Adjust for the above change. Give decoded
c805dec0
KH
4440 values to a Lisp function. Gcpro more variables.
4441 (uniprop_table_uncompress)
4442 (uniprop_decode_value_run_length): New functions.
4443 (uniprop_decoder, uniprop_decoder_count): New variables.
4444 (uniprop_get_decoder, uniprop_encode_value_character)
4445 (uniprop_encode_value_run_length, uniprop_encode_value_numeric):
4446 New functions.
4447 (uniprop_encoder, uniprop_encoder_count): New variables.
4448 (uniprop_get_encoder, uniprop_table)
4449 (Funicode_property_table_internal, Fget_unicode_property_internal)
4450 (Fput_unicode_property_internal): New functions.
4451 (syms_of_chartab): DEFSYM Qchar_code_property_table, defsubr
4452 Sunicode_property_table_internal, Sget_unicode_property_internal,
5e617bc2 4453 and Sput_unicode_property_internal. Defvar_lisp
c805dec0
KH
4454 char-code-property-alist.
4455
640c8776 4456 * composite.c (CHAR_COMPOSABLE_P): Adjust for the change of
c805dec0
KH
4457 Vunicode_category_table.
4458
640c8776 4459 * font.c (font_range): Adjust for the change of
c805dec0
KH
4460 Vunicode_category_table.
4461
76b397fb
DN
44622011-07-07 Dan Nicolaescu <dann@ics.uci.edu>
4463
4464 * m/iris4d.h: Remove file, move contents ...
4465 * s/irix6-5.h: ... here.
4466
22b4128e
PE
44672011-07-06 Paul Eggert <eggert@cs.ucla.edu>
4468
4469 Remove unportable assumption about struct layout (Bug#8884).
8a5c77bb
PE
4470 * alloc.c (mark_buffer):
4471 * buffer.c (reset_buffer_local_variables, Fbuffer_local_variables)
4472 (clone_per_buffer_values): Don't assume that
22b4128e
PE
4473 sizeof (struct buffer) is a multiple of sizeof (Lisp_Object).
4474 This isn't true in general, and it's particularly not true
4475 if Emacs is configured with --with-wide-int.
4476 * buffer.h (FIRST_FIELD_PER_BUFFER, LAST_FIELD_PER_BUFFER):
4477 New macros, used in the buffer.c change.
4478
869795d6
JD
44792011-07-05 Jan Djärv <jan.h.d@swipnet.se>
4480
4481 * xsettings.c: Use both GConf and GSettings if both are available.
4482 (store_config_changed_event): Add comment.
4483 (dpyinfo_valid, store_font_name_changed, map_tool_bar_style)
4484 (store_tool_bar_style_changed): New functions.
5e617bc2 4485 (store_monospaced_changed): Add comment. Call dpyinfo_valid.
869795d6
JD
4486 (struct xsettings): Move font inside HAVE_XFT.
4487 (GSETTINGS_TOOL_BAR_STYLE, GSETTINGS_FONT_NAME): New defines.
640c8776 4488 (GSETTINGS_MONO_FONT): Rename from SYSTEM_MONO_FONT.
869795d6 4489 Move inside HAVE_XFT.
640c8776 4490 (something_changed_gsettingsCB): Rename from something_changedCB.
869795d6
JD
4491 Check for changes in GSETTINGS_TOOL_BAR_STYLE and GSETTINGS_FONT_NAME
4492 also.
4493 (GCONF_TOOL_BAR_STYLE, GCONF_FONT_NAME): New defines.
5e617bc2 4494 (GCONF_MONO_FONT): Rename from SYSTEM_MONO_FONT. Move inside HAVE_XFT.
640c8776 4495 (something_changed_gconfCB): Rename from something_changedCB.
869795d6
JD
4496 Check for changes in GCONF_TOOL_BAR_STYLE and GCONF_FONT_NAME also.
4497 (parse_settings): Move check for font inside HAVE_XFT.
4498 (read_settings, apply_xft_settings): Add comment.
4499 (read_and_apply_settings): Add comment. Call map_tool_bar_style and
4500 store_tool_bar_style_changed. Move check for font inside HAVE_XFT and
4501 call store_font_name_changed.
4502 (xft_settings_event): Add comment.
4503 (init_gsettings): Add comment. Get values for GSETTINGS_TOOL_BAR_STYLE
4504 and GSETTINGS_FONT_NAME. Move check for fonts within HAVE_XFT.
4505 (init_gconf): Add comment. Get values for GCONF_TOOL_BAR_STYLE
4506 and GCONF_FONT_NAME. Move check for fonts within HAVE_XFT.
4507 (xsettings_initialize): Call init_gsettings last.
640c8776
SM
4508 (xsettings_get_system_font, xsettings_get_system_normal_font):
4509 Add comment.
869795d6 4510
d8ed26bd
PE
45112011-07-05 Paul Eggert <eggert@cs.ucla.edu>
4512
4513 Random fixes. E.g., (random) never returned negative values.
4514 * fns.c (Frandom): Use GET_EMACS_TIME for random seed, and add the
4515 subseconds part to the entropy, as that's a bit more random.
4516 Prefer signed to unsigned, since the signedness doesn't matter and
4517 in general we prefer signed. When given a limit, use a
4518 denominator equal to INTMASK + 1, not to VALMASK + 1, because the
4519 latter isn't right if USE_2_TAGS_FOR_INTS.
4520 * sysdep.c (get_random): Return a value in the range 0..INTMASK,
4521 not 0..VALMASK. Don't discard "excess" bits that random () returns.
4522
cabf1cac
SM
45232011-07-04 Stefan Monnier <monnier@iro.umontreal.ca>
4524
4525 * textprop.c (text_property_stickiness):
4526 Obey Vtext_property_default_nonsticky.
4527 (syms_of_textprop): Add `display' to Vtext_property_default_nonsticky.
4528 * w32fns.c (syms_of_w32fns):
4529 * xfns.c (syms_of_xfns): Don't Add `display' since it's there by default.
4530
6e9b2be9
PE
45312011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4532
4533 * fileio.c (barf_or_query_if_file_exists): Use S_ISDIR.
4534 This is more efficient than Ffile_directory_p and avoids a minor race.
4535
90186c68
LMI
45362011-07-04 Lars Magne Ingebrigtsen <larsi@gnus.org>
4537
7c301272
LMI
4538 * buffer.c (Foverlay_put): Say what the return value is
4539 (bug#7835).
4540
c4f2d8d4
LMI
4541 * fileio.c (barf_or_query_if_file_exists): Check first if the file
4542 is a directory before asking whether to use the file name
4543 (bug#7564).
ad637907
LMI
4544 (barf_or_query_if_file_exists): Make the "File is a directory"
4545 error be more correct.
c4f2d8d4 4546
90186c68
LMI
4547 * fns.c (Frequire): Remove the mention of the .gz files, since
4548 that's installation-specific, but keep the mention of
4549 `get-load-suffixes'.
4550
da64016e
PE
45512011-07-04 Paul Eggert <eggert@cs.ucla.edu>
4552
4553 * editfns.c (Fformat_time_string): Don't assume strlen fits in int.
4554 Report string overflow if the output is too long.
4555
7d47b580
JB
45562011-07-04 Juanma Barranquero <lekktu@gmail.com>
4557
a555cb87
JB
4558 * gnutls.c (Fgnutls_boot): Don't mention :verify-error.
4559 (syms_of_gnutls): Remove duplicate DEFSYM for
4560 Qgnutls_bootprop_verify_hostname_error, an error for
4561 Qgnutls_bootprop_verify_error (which is no longer used).
4562
7d47b580
JB
4563 * eval.c (find_handler_clause): Remove parameters `sig' and `data',
4564 unused since 2011-01-26T20:02:07Z!monnier@iro.umontreal.ca. All callers changed.
4565 Also (re)move comments that are misplaced or no longer relevant.
4566
1e49bfab
LMI
45672011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4568
4569 * callint.c (Finteractive): Clarify the meaning of "@" (bug#8813).
4570
1485f4c0
CY
45712011-07-03 Chong Yidong <cyd@stupidchicken.com>
4572
4573 * xfaces.c (Finternal_merge_in_global_face): Modify the foreground
4574 and background color parameters if they have been changed.
4575
a9ab721e
LMI
45762011-07-03 Lars Magne Ingebrigtsen <larsi@gnus.org>
4577
4578 * editfns.c (Fformat): Clarify the - and 0 flags (bug#6659).
4579
cf7cff57
PE
45802011-07-03 Paul Eggert <eggert@cs.ucla.edu>
4581
2e13213d
PE
4582 * xsettings.c (SYSTEM_FONT): Define only when used.
4583 No need to define when HAVE_GSETTINGS || !HAVE_XFT.
4584
cf7cff57
PE
4585 * keymap.c (access_keymap_1): Now static.
4586
7a8e04f7
CY
45872011-07-02 Chong Yidong <cyd@stupidchicken.com>
4588
4589 * keyboard.c (command_loop_1): If a down-mouse event is unbound,
4590 leave any prefix arg for the up event (Bug#1586).
4591
61352f62
LMI
45922011-07-02 Lars Magne Ingebrigtsen <larsi@gnus.org>
4593
69bb1ef7
LMI
4594 * lread.c (syms_of_lread): Mention single symbols defined by
4595 `defvar' or `defconst' (bug#7154).
4596
61352f62 4597 * fns.c (Frequire): Mention .el.gz files (bug#7314).
7b3747f9 4598 (Frequire): Mention get-load-suffixes.
61352f62 4599
28545e04
MR
46002011-07-02 Martin Rudalics <rudalics@gmx.at>
4601
4602 * window.h (window): Remove clone_number slot.
4603 * window.c (Fwindow_clone_number, Fset_window_clone_number):
4604 Remove.
4605 (make_parent_window, make_window, saved_window)
4606 (Fset_window_configuration, save_window_save): Don't deal with
4607 clone numbers.
4608 * buffer.c (Qclone_number): Remove declaration.
4609 (sort_overlays, overlay_strings): Don't deal with clone numbers.
4610
3349e122
SM
46112011-07-02 Stefan Monnier <monnier@iro.umontreal.ca>
4612
4613 Add multiple inheritance to keymaps.
4614 * keymap.c (Fmake_composed_keymap): New function.
4615 (Fset_keymap_parent): Simplify.
4616 (fix_submap_inheritance): Remove.
4617 (access_keymap_1): New function extracted from access_keymap to handle
4618 embedded parents and handle lists of maps.
4619 (access_keymap): Use it.
4620 (Fkeymap_prompt, map_keymap_internal, map_keymap, store_in_keymap)
4621 (Fcopy_keymap): Handle embedded parents.
4622 (Fcommand_remapping, define_as_prefix): Simplify.
4623 (Fkey_binding): Simplify.
4624 (syms_of_keymap): Move minibuffer-local-completion-map,
4625 minibuffer-local-filename-completion-map,
4626 minibuffer-local-must-match-map, and
4627 minibuffer-local-filename-must-match-map to Elisp.
4628 (syms_of_keymap): Defsubr make-composed-keymap.
4629 * keyboard.c (menu_bar_items): Use map_keymap_canonical.
4630 (parse_menu_item): Trivial simplification.
4631
3279eb87
GM
46322011-07-01 Glenn Morris <rgm@gnu.org>
4633
4634 * Makefile.in (SETTINGS_LIBS): Fix typo.
4635
4550efdf
KI
46362011-07-01 Kazuhiro Ito <kzhr@d1.dion.ne.jp> (tiny patch)
4637
4638 * coding.c (Fencode_coding_string): Record the last coding system
4639 used, as the function doc string says (bug#8738).
4640
0949d2b6
JD
46412011-07-01 Jan Djärv <jan.h.d@swipnet.se>
4642
4643 * xsettings.c (store_monospaced_changed): Take new font as arg and
4644 check for change against current_mono_font.
4645 (EMACS_TYPE_SETTINGS): Remove this and related defines.
4646 (emacs_settings_constructor, emacs_settings_get_property)
4647 (emacs_settings_set_property, emacs_settings_class_init)
4648 (emacs_settings_init, gsettings_obj): Remove.
4649 (something_changedCB): New function for HAVE_GSETTINGS.
4650 (something_changedCB): HAVE_GCONF: Call store_monospaced_changed
4651 with value as argument.
4652 (init_gsettings): Check that GSETTINGS_SCHEMA exists before calling
4653 g_settings_new (Bug#8967). Do not create gsettings_obj.
9173deec 4654 Remove calls to g_settings_bind. Connect something_changedCB to
0949d2b6
JD
4655 "changed".
4656
4657 * xgselect.c: Add defined (HAVE_GSETTINGS).
4658 (xgselect_initialize): Ditto.
4659
4660 * process.c: Add defined (HAVE_GSETTINGS) for xgselect.h
4661 (wait_reading_process_output): Add defined (HAVE_GSETTINGS) for
4662 xg_select.
4663
bbc6b304
PE
46642011-07-01 Paul Eggert <eggert@cs.ucla.edu>
4665
4666 * eval.c (struct backtrace): Simplify and port the data structure.
4667 Do not assume that "int nargs : BITS_PER_INT - 2;" produces a
4668 signed bit field, as this assumption is not portable and it makes
4669 Emacs crash when compiled with Sun C 5.8 on sparc. Do not use
4670 "char debug_on_exit : 1" as this is not portable either; instead,
4671 use the portable "unsigned int debug_on_exit : 1". Remove unused
4672 member evalargs. Remove obsolete comments about cc bombing out.
4673
9851bfc5
JD
46742011-06-30 Jan Djärv <jan.h.d@swipnet.se>
4675
51bb811f 4676 * xsettings.c: Include glib-object.h, gio/gio.h if HAVE_GSETTINGS.
9851bfc5
JD
4677 Let HAVE_GSETTINGS override HAVE_GCONF.
4678 (store_monospaced_changed): New function.
4679 (EMACS_SETTINGS): A new type derived from GObject to handle
4680 GSettings notifications.
4681 (emacs_settings_constructor, emacs_settings_get_property)
4682 (emacs_settings_set_property, emacs_settings_class_init):
4683 New functions.
4684 (gsettings_client, gsettings_obj): New variables.
4685 (GSETTINGS_SCHEMA): New define.
4686 (something_changedCB): Call store_monospaced_changed.
4687 (init_gsettings): New function.
4688 (xsettings_initialize): Call init_gsettings.
4689 (syms_of_xsettings): Initialize gsettings_client, gsettings_obj
4690 to NULL.
4691
640c8776 4692 * Makefile.in (SETTINGS_CFLAGS, SETTINGS_LIBS): Rename from
9851bfc5
JD
4693 GCONF_CFLAGS/LIBS.
4694
5386012d
MR
46952011-06-29 Martin Rudalics <rudalics@gmx.at>
4696
4697 * window.c (resize_root_window, grow_mini_window)
4698 (shrink_mini_window): Rename Qresize_root_window to
4699 Qwindow_resize_root_window and Qresize_root_window_vertically to
4700 Qwindow_resize_root_window_vertically.
4701
f13e0b08
PE
47022011-06-28 Paul Eggert <eggert@cs.ucla.edu>
4703
4704 * gnutls.c (Qgnutls_bootprop_verify_error): Remove unused var.
4705
94515237
JB
47062011-06-27 Juanma Barranquero <lekktu@gmail.com>
4707
4708 * makefile.w32-in: Redesign dependencies so they reflect more
4709 clearly which files are directly included by each source file,
4710 and not through other includes.
4711
e43b6e43
MR
47122011-06-27 Martin Rudalics <rudalics@gmx.at>
4713
4714 * buffer.c (Qclone_number): Declare static and DEFSYM it.
4715 (sort_overlays, overlay_strings): When an overlay's clone number
4716 matches the window's clone number process the overlay even if
4717 the overlay's window property doesn't match the current window.
4718
d68443dc
MR
4719 * window.c (Fwindow_vchild): Rename to Fwindow_top_child.
4720 (Fwindow_hchild): Rename to Fwindow_left_child.
4721 (Fwindow_next): Rename to Fwindow_next_sibling.
4722 (Fwindow_prev): Rename to Fwindow_prev_sibling.
d615d6d2
MR
4723 (resize_window_check): Rename to window_resize_check.
4724 (resize_window_apply): Rename to window_resize_apply.
4725 (Fresize_window_apply): Rename to Fwindow_resize_apply.
4726 (Fdelete_other_windows_internal, resize_frame_windows)
4727 (Fsplit_window_internal, Fdelete_window_internal)
4728 (grow_mini_window, shrink_mini_window)
4729 (Fresize_mini_window_internal): Fix callers accordingly.
d68443dc 4730
c7e73be5
JD
47312011-06-26 Jan Djärv <jan.h.d@swipnet.se>
4732
4733 * emacsgtkfixed.h: State that this is only used with Gtk+3.
4734 (emacs_fixed_set_min_size): Remove.
4735 (emacs_fixed_new): Take frame as argument.
4736
4737 * emacsgtkfixed.c: State that this is only used with Gtk+3.
4738 (_EmacsFixedPrivate): Remove minwidth/height.
4739 Add struct frame *f.
4740 (emacs_fixed_init): Initialize priv->f.
4741 (get_parent_class, emacs_fixed_set_min_size): Remove.
4742 (emacs_fixed_new): Set priv->f to argument.
4743 (emacs_fixed_get_preferred_width)
4744 (emacs_fixed_get_preferred_height): Use min_width/height from
4745 frames size_hint to set minimum and natural (Bug#8919).
4746 (XSetWMSizeHints, XSetWMNormalHints): Override these functions
4747 and use min_width/height from frames size_hint to set
4748 min_width/height (Bug#8919).
4749
4750 * gtkutil.c (xg_create_frame_widgets): Pass f to emacs_fixed_new.
9173deec
JB
4751 (x_wm_set_size_hint): Remove call to emacs_fixed_set_min_size.
4752 Fix indentation.
c7e73be5 4753
cf99dcf8
EZ
47542011-06-26 Eli Zaretskii <eliz@gnu.org>
4755
4756 * bidi.c (bidi_paragraph_init): Test for ZV_BYTE before calling
4757 bidi_at_paragraph_end, since fast_looking_at doesn't like to be
4758 called at ZV.
4759
029529ac
CY
47602011-06-26 Chong Yidong <cyd@stupidchicken.com>
4761
4762 * process.c (wait_reading_process_output): Bypass select if
4763 waiting for a cell while ignoring keyboard input, and input is
4764 pending. Suggested by Jan Djärv (Bug#8869).
4765
7a7ef429
PE
47662011-06-25 Paul Eggert <eggert@cs.ucla.edu>
4767
4768 Use gnulib's dup2 module instead of rolling our own.
4769 * sysdep.c (dup2) [!HAVE_DUP2]: Remove; gnulib now does this.
4770
11fdef7d 47712011-06-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
989b42d2
YM
4772
4773 * dispnew.c (scrolling_window): Before scrolling, turn off a
4774 mouse-highlight in the window being scrolled.
4775
cd3520a4
JB
47762011-06-24 Juanma Barranquero <lekktu@gmail.com>
4777
4778 Move DEFSYM to lisp.h and use everywhere.
4779
4780 * character.h (DEFSYM): Move declaration...
4781 * lisp.h (DEFSYM): ...here.
4782
4783 * gnutls.c:
4784 * minibuf.c:
4785 * w32menu.c:
4786 * w32proc.c:
4787 * w32select.c: Don't include character.h.
4788
4789 * alloc.c (syms_of_alloc):
4790 * buffer.c (syms_of_buffer):
4791 * bytecode.c (syms_of_bytecode):
4792 * callint.c (syms_of_callint):
4793 * casefiddle.c (syms_of_casefiddle):
4794 * casetab.c (init_casetab_once):
4795 * category.c (init_category_once, syms_of_category):
4796 * ccl.c (syms_of_ccl):
4797 * cmds.c (syms_of_cmds):
4798 * composite.c (syms_of_composite):
4799 * dbusbind.c (syms_of_dbusbind):
4800 * dired.c (syms_of_dired):
4801 * dispnew.c (syms_of_display):
4802 * doc.c (syms_of_doc):
4803 * editfns.c (syms_of_editfns):
4804 * emacs.c (syms_of_emacs):
4805 * eval.c (syms_of_eval):
4806 * fileio.c (syms_of_fileio):
4807 * fns.c (syms_of_fns):
4808 * frame.c (syms_of_frame):
4809 * fringe.c (syms_of_fringe):
4810 * insdel.c (syms_of_insdel):
4811 * keymap.c (syms_of_keymap):
4812 * lread.c (init_obarray, syms_of_lread):
4813 * macros.c (syms_of_macros):
4814 * msdos.c (syms_of_msdos):
4815 * print.c (syms_of_print):
4816 * process.c (syms_of_process):
4817 * search.c (syms_of_search):
4818 * sound.c (syms_of_sound):
4819 * syntax.c (init_syntax_once, syms_of_syntax):
4820 * terminal.c (syms_of_terminal):
4821 * textprop.c (syms_of_textprop):
4822 * undo.c (syms_of_undo):
4823 * w32.c (globals_of_w32):
4824 * window.c (syms_of_window):
4825 * xdisp.c (syms_of_xdisp):
4826 * xfaces.c (syms_of_xfaces):
4827 * xfns.c (syms_of_xfns):
4828 * xmenu.c (syms_of_xmenu):
4829 * xsettings.c (syms_of_xsettings):
4830 * xterm.c (syms_of_xterm): Use DEFSYM.
4831
4228cf16
TZ
48322011-06-24 Teodor Zlatanov <tzz@lifelogs.com>
4833
cd3520a4 4834 * gnutls.c (syms_of_gnutls): Use the DEFSYM macro from character.h.
4228cf16 4835
7fcccf1e
PE
48362011-06-23 Paul Eggert <eggert@cs.ucla.edu>
4837
7efb4e0e
PE
4838 Integer and buffer overflow fixes (Bug#8873).
4839
ff5844ad
PE
4840 * print.c (printchar, strout): Check for string overflow.
4841 (PRINTPREPARE, printchar, strout):
4842 Don't set size unless allocation succeeds.
4843
90532f02
PE
4844 * minibuf.c (read_minibuf_noninteractive): Use ptrdiff_t, not int,
4845 for sizes. Check for string overflow more accurately.
4846 Simplify newline removal at end; this suppresses a GCC 4.6.0 warning.
4847
6d84508d
PE
4848 * macros.c: Integer and buffer overflow fixes.
4849 * keyboard.h (struct keyboard.kbd_macro_bufsize):
4850 * macros.c (Fstart_kbd_macro, store_kbd_macro_char):
4851 Use ptrdiff_t, not int, for sizes.
4852 Don't increment bufsize until after realloc succeeds.
4853 Check for size-calculation overflow.
4854 (Fstart_kbd_macro): Use EMACS_INT, not int, for XINT result.
4855
437b2cb4
PE
4856 * lisp.h (DEFVAR_KBOARD): Use offsetof instead of char * finagling.
4857
8b9ac8b4
PE
4858 * lread.c: Integer overflow fixes.
4859 (read_integer): Radix is now EMACS_INT, not int,
4860 to improve quality of diagnostics for out-of-range radices.
4861 Calculate buffer size correctly for out-of-range radices.
4862 (read1): Check for integer overflow in radices, and in
4863 read-circle numbers.
82cb60d3
PE
4864 (read_escape): Avoid int overflow.
4865 (Fload, openp, read_buffer_size, read1)
4866 (substitute_object_recurse, read_vector, read_list, map_obarray):
4867 Use ptrdiff_t, not int, for sizes.
4868 (read1): Use EMACS_INT, not int, for sizes.
20270765 4869 Check for size overflow.
8b9ac8b4 4870
7fcccf1e
PE
4871 * image.c (cache_image): Check for size arithmetic overflow.
4872
bfbbd7e7
PE
4873 * lread.c: Integer overflow issues.
4874 (saved_doc_string_size, saved_doc_string_length)
4875 (prev_saved_doc_string_size, prev_saved_doc_string_length):
4876 Now ptrdiff_t, not int.
4877 (read1): Don't assume doc string length fits in int. Check for
4878 out-of-range doc string lengths.
4879 (read_list): Don't assume file position fits in int.
39019e54 4880 (read_escape): Check for hex character overflow.
bfbbd7e7 4881
4e323265
LL
48822011-06-22 Leo Liu <sdl.web@gmail.com>
4883
4884 * minibuf.c (Fcompleting_read_default, Vcompleting_read_function):
4885 Move to minibuffer.el.
4886
85fece3e
PE
48872011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4888
20b84ce9 4889 Fixes for GLYPH_DEBUG found by GCC 4.6.0 static checking.
85fece3e
PE
4890 The following patches are for when GLYPH_DEBUG && !XASSERT.
4891 * dispextern.h (trace_redisplay_p, dump_glyph_string):
4892 * dispnew.c (flush_stdout):
4893 * xdisp.c (dump_glyph_row, dump_glyph_matrix, dump_glyph):
4894 Mark as externally visible.
4895 * dispnew.c (check_window_matrix_pointers): Now static.
4896 * dispnew.c (window_to_frame_vpos):
4897 * xfns.c (unwind_create_frame):
4898 * xterm.c (x_check_font): Remove unused local.
4899 * scroll.c (CHECK_BOUNDS):
4900 * xfaces.c (cache_fache): Rename local to avoid shadowing.
4901 * xfns.c, w32fns.c (image_cache_refcount, dpyinfo_refcount): Now static.
4902 * xdisp.c (check_window_end): Now a no-op if !XASSERTS.
4903 (debug_first_unchanged_at_end_vpos, debug_last_unchanged_at_beg_vpos)
4904 (debug_dvpos, debug_dy, debug_delta, debug_delta_bytes, debug_end_vpos):
4905 Now static.
4906 (debug_method_add): Use va_list and vsprintf rather than relying
4907 on undefined behavior with wrong number of arguments.
4908 (dump_glyph, dump_glyph_row, Fdump_glyph_matrix):
4909 Don't assume ptrdiff_t and EMACS_INT are the same width as int.
4910 In this code, it's OK to assume C99 behavior for ptrdiff_t formats
4911 since we're not interested in debugging glyphs with old libraries.
4912 * xfaces.c (cache_face): Move debugging code earlier; this pacifies
4913 GCC 4.6.0's static checking.
4914
0766b489
PE
49152011-06-22 Paul Eggert <eggert@cs.ucla.edu>
4916
31fd4b32
PE
4917 Integer overflow and signedness fixes (Bug#8873).
4918 A few related buffer overrun fixes, too.
4919
b79e8648
PE
4920 * font.c (font_score): Use EMACS_INT, not int, to store XINT value.
4921
0766b489
PE
4922 * dispextern.h (struct face.stipple):
4923 * image.c (x_bitmap_height, x_bitmap_width, x_bitmap_pixmap)
4924 (x_bitmap_mask, x_allocate_bitmap_record)
4925 (x_create_bitmap_from_data, x_create_bitmap_from_file)
4926 (x_destroy_bitmap, x_destroy_all_bitmaps, x_create_bitmap_mask)
4927 (x_create_bitmap_from_xpm_data):
4928 * nsterm.h (struct ns_display_info.bitmaps_size, .bitmaps_last):
4929 * w32term.h (struct w32_display_info.icon_bitmap_id, .bitmaps_size)
4930 (.bitmaps_last):
4931 * xfaces.c (load_pixmap):
4932 * xterm.c (x_bitmap_icon, x_wm_set_icon_pixmap):
4933 * xterm.h (struct x_display_info.icon_bitmap_id, .bitmaps_size)
4934 (.bitmaps_last, struct x_output.icon_bitmap):
4935 Use ptrdiff_t, not int, for bitmap indexes.
4936 (x_allocate_bitmap_record): Check for size overflow.
4937 * dispextern.h, lisp.h: Adjust to API changes elsewhere.
4938
b081724f
PE
4939 Use ptrdiff_t, not int, for overlay counts.
4940 * buffer.h (overlays_at, sort_overlays, GET_OVERLAYS_AT):
4941 * editfns.c (overlays_around, get_pos_property):
4942 * textprop.c (get_char_property_and_overlay):
4943 * xdisp.c (next_overlay_change, note_mouse_highlight):
4944 * xfaces.c (face_at_buffer_position):
21514da7
PE
4945 * buffer.c (OVERLAY_COUNT_MAX): New macro.
4946 (overlays_at, overlays_in, sort_overlays, Foverlays_at)
4947 (Fnext_overlay_change, Fprevious_overlay_change)
4948 (mouse_face_overlay_overlaps, Foverlays_in):
b081724f 4949 Use ptrdiff_t, not int, for sizes.
21514da7 4950 (overlays_at, overlays_in): Check for size-calculation overflow.
b081724f 4951
3de73e5e
PE
4952 * xterm.c (xim_initialize, same_x_server): Strlen may not fit in int.
4953
2606c57b
PE
4954 * xsmfns.c (smc_save_yourself_CB, x_session_initialize): Avoid strlen.
4955 (x_session_initialize): Do not assume string length fits in int.
4956
aaafe47a
PE
4957 * xsettings.c (apply_xft_settings): Fix potential buffer overrun.
4958 This is unlikely, but can occur if DPI is outlandish.
4959
2674ddc8 4960 * xsettings.c (Ffont_get_system_normal_font, Ffont_get_system_font):
3a5077c5
PE
4961 * xselect.c (Fx_get_atom_name): Avoid need for strlen.
4962
28154962
PE
4963 * xrdb.c: Don't assume strlen fits in int; avoid some strlens.
4964 * xrdb.c (magic_file_p, search_magic_path):
4965 Omit last arg SUFFIX; it was always 0. All callers changed.
4966 (magic_file_p): Use ptrdiff_t, not int. Check for size overflow.
4967
7de51af5
PE
4968 * xfont.c (xfont_match): Avoid need for strlen.
4969
25ed6cc3
PE
4970 * xfns.c: Don't assume strlen fits in int.
4971 (xic_create_fontsetname, x_window): Use ptrdiff_t, not int.
4972
4eab31dd
PE
4973 * xdisp.c (message_log_check_duplicate): Return intmax_t,
4974 not unsigned long, as we prefer signed integers. All callers changed.
4975 Detect integer overflow in repeat count.
4976 (message_dolog): Don't assume print length fits in 39 bytes.
df1f27af 4977 (display_mode_element): Don't assume strlen fits in int.
4eab31dd 4978
171e2a58
PE
4979 * termcap.c: Don't assume sizes fit in int and never overflow.
4980 (struct termcap_buffer, tgetent): Use ptrdiff_t, not int, for sizes.
4981 (gobble_line): Check for size-calculation overflow.
4982
ad39faca 4983 * minibuf.c (Fread_buffer):
6e5bb2dc 4984 * lread.c (intern, intern_c_string):
74ca2eb3
PE
4985 * image.c (xpm_scan) [HAVE_NS && !HAVE_XPM]:
4986 Don't assume string length fits in int.
4987
52c61c22 4988 * keyboard.c (parse_tool_bar_item):
9bda3520
PE
4989 * gtkutil.c (style_changed_cb): Avoid need for strlen.
4990
b5b8c9e5
PE
4991 * font.c: Don't assume string length fits in int.
4992 (font_parse_xlfd, font_parse_fcname, font_unparse_fcname):
4993 Use ptrdiff_t, not int.
ccd6111c
PE
4994 (font_intern_prop): Don't assume string length fits in int.
4995 Don't assume integer property fits in fixnum.
4996 * font.h (font_intern_prop): 2nd arg is now ptrdiff_t, not int.
b5b8c9e5 4997
882f0d81 4998 * filelock.c: Fix some buffer overrun and integer overflow issues.
51cab52b 4999 (get_boot_time): Don't assume gzip command string fits in 100 bytes.
882f0d81
PE
5000 Reformulate so as not to need the command string.
5001 Invoke gzip -cd rather than gunzip, as it's more portable.
5002 (lock_info_type, lock_file_1, lock_file):
5003 Don't assume pid_t and time_t fit in unsigned long.
5004 (LOCK_PID_MAX): Remove; we now use more-reliable bounds.
5005 (current_lock_owner): Prefer signed type for sizes.
5006 Use memcpy, not strncpy, where memcpy is what is really wanted.
5007 Don't assume (via atoi) that time_t and pid_t fit in int.
5008 Check for time_t and/or pid_t out of range, e.g., via a network share.
5009 Don't alloca where an auto var works fine.
5010
93f4cf88
PE
5011 * fileio.c: Fix some integer overflow issues.
5012 (file_name_as_directory, Fexpand_file_name, Fsubstitute_in_file_name):
5013 Don't assume string length fits in int.
5014 (directory_file_name): Don't assume string length fits in long.
5015 (make_temp_name): Don't assume pid fits in int, or that its print
5016 length is less than 20.
5017
f3e92b69
PE
5018 * data.c (Fsubr_name): Rewrite to avoid a strlen call.
5019
1bfdaf10
PE
5020 * coding.c (make_subsidiaries): Don't assume string length fits in int.
5021
35016e9a
PE
5022 * callproc.c (child_setup): Rewrite to avoid two strlen calls.
5023
3d1e65a1
PE
5024 * process.c (Fformat_network_address): Use EMACS_INT, not EMACS_UINT.
5025 We prefer signed integers, even for size calculations.
5026
0b963a93
PE
5027 * emacs.c: Don't assume string length fits in 'int'.
5028 (DEFINE_DUMMY_FUNCTION, sort_args): Use ptrdiff_t, not int.
5029 (main): Don't invoke strlen when not needed.
5030
573f4b54
PE
5031 * dbusbind.c (XD_ERROR): Don't arbitrarily truncate string.
5032 (XD_DEBUG_MESSAGE): Don't waste a byte.
5033
989f33ba
PE
5034 * callproc.c (getenv_internal_1, getenv_internal)
5035 (Fgetenv_internal):
965d34eb
PE
5036 * buffer.c (init_buffer): Don't assume string length fits in 'int'.
5037
e4d29b33
PE
5038 * lread.c (invalid_syntax): Omit length argument.
5039 All uses changed. This doesn't fix a bug, but it simplifies the
5040 code away from its former Hollerith-constant appearance, and it's
5041 one less 'int' to worry about when looking at integer-overflow issues.
51cab52b 5042 (string_to_number): Simplify 2011-04-26 change by invoking xsignal1.
e4d29b33 5043
eb49b136
PE
5044 * lisp.h (DEFUN): Remove bogus use of sizeof (struct Lisp_Subr).
5045 This didn't break anything, but it didn't help either.
5046 It's confusing to put a bogus integer in a place where the actual
5047 value does not matter.
9f62aeb1 5048 (LIST_END_P): Remove unused macro and its bogus comment.
cbeff735 5049 (make_fixnum_or_float): Remove unnecessary cast to EMACS_INT.
eb49b136 5050
15375a22
PE
5051 * lisp.h (union Lisp_Object.i): EMACS_INT, not EMACS_UINT.
5052 This is for consistency with the ordinary, non-USE_LISP_UNION_TYPE,
5053 implementation.
b61cc01c
PE
5054 (struct Lisp_Bool_Vector.size): EMACS_INT, not EMACS_UINT.
5055 We prefer signed types, and the value cannot exceed the EMACS_INT
5056 range anyway (because otherwise the length would not be representable).
9a8e8d9b
PE
5057 (XSET) [USE_LISP_UNION_TYPE]: Use uintptr_t and intptr_t,
5058 not EMACS_UINT and EMACS_INT, when converting pointer to integer.
5059 This avoids a GCC warning when WIDE_EMACS_INT.
15375a22 5060
53b2623d
PE
5061 * indent.c (sane_tab_width): New function.
5062 (current_column, scan_for_column, Findent_to, position_indentation)
5063 (compute_motion): Use it. This is just for clarity.
8fcaf9cc 5064 (Fcompute_motion): Don't assume hscroll and tab offset fit in int.
53b2623d 5065
51cab52b 5066 * image.c (xbm_image_p): Don't assume stated width, height fit in int.
45aebb64 5067
f2ed8a70
PE
5068 * lisp.h (lint_assume): New macro.
5069 * composite.c (composition_gstring_put_cache):
5070 * ftfont.c (ftfont_shape_by_flt): Use it to pacify GCC 4.6.0.
5071
abe80cc6
PE
5072 * editfns.c, insdel.c:
5073 Omit unnecessary forward decls, to simplify future changes.
a9e860e1 5074
b02c740e
PE
5075 * ftfont.c (ftfont_shape_by_flt): Use signed integers for lengths.
5076
ebc96716
PE
5077 * font.c (Ffont_shape_gstring): Don't assume glyph len fits in 'int'.
5078
b4e50fa0 5079 * fns.c (Ffillarray): Don't assume bool vector size fits in 'int'.
f03dc6ef 5080 Use much-faster test for byte-length change.
311d5d7c 5081 Don't assume string byte-length fits in 'int'.
a4cf38e4 5082 Check that character arg fits in 'int'.
85461888 5083 (mapcar1): Declare byte as byte, for clarity.
b4e50fa0 5084
c0c1ee9f
PE
5085 * alloc.c (Fmake_bool_vector): Avoid unnecessary multiplication.
5086
a498d7f4
PE
5087 * fns.c (concat): Catch string overflow earlier.
5088 Do not rely on integer wraparound.
5089
51cab52b
PE
5090 * dispextern.h (struct it.overlay_strings_charpos)
5091 (struct it.selective): Now EMACS_INT, not int.
87830974
PE
5092 * xdisp.c (forward_to_next_line_start)
5093 (back_to_previous_visible_line_start)
5094 (reseat_at_next_visible_line_start, next_element_from_buffer):
5095 Don't arbitrarily truncate the value of 'selective' to int.
5096
76031fad
PE
5097 * xdisp.c (init_iterator): Use XINT, not XFASTINT; it might be < 0.
5098
5eb55db9
PE
5099 * composite.c: Don't truncate sizes to 'int'.
5100 (composition_gstring_p, composition_reseat_it)
5101 (composition_adjust_point): Use EMACS_INT, not int.
7d100a81
PE
5102 (get_composition_id, composition_gstring_put_cache): Use EMACS_INT,
5103 not EMACS_UINT, for indexes.
5eb55db9 5104
0703a717
PE
5105 * category.h (CATEGORY_SET_P): Remove unnecessary cast to EMACS_INT.
5106
d6202519
PE
5107 * buffer.c: Include <verify.h>.
5108 (struct sortvec.priority, struct sortstr.priority):
8961a454 5109 Now EMACS_INT, not int.
c20998a7 5110 (compare_overlays, cmp_for_strings): Avoid subtraction overflow.
67c36fce
PE
5111 (struct sortstr.size, record_overlay_string)
5112 (struct sortstrlist.size, struct sortlist.used):
5113 Don't truncate size to int.
5114 (record_overlay_string): Check for size-calculation overflow.
d6202519 5115 (init_buffer_once): Check at compile-time, not run-time.
fadf4e30 5116
d5a19415
JM
51172011-06-22 Jim Meyering <meyering@redhat.com>
5118
029529ac 5119 Don't leak an XBM-image-sized buffer
d5a19415
JM
5120 * image.c (xbm_load): Free the image buffer after using it.
5121
a9041e6c
PE
51222011-06-21 Paul Eggert <eggert@cs.ucla.edu>
5123
5124 Port to Sun C.
5125 * composite.c (find_automatic_composition): Omit needless 'return 0;'
5126 that Sun C diagnosed.
5127 * fns.c (secure_hash): Fix pointer signedness issue.
5128 * intervals.c (static_offset_intervals): New function.
5129 (offset_intervals): Use it.
5130
7f3f739f
LL
51312011-06-21 Leo Liu <sdl.web@gmail.com>
5132
5133 * deps.mk (fns.o):
5134 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha256.h and
5135 sha512.h.
5136
5137 * fns.c (secure_hash): Rename from crypto_hash_function and change
5138 the first arg to accept symbols.
5b66d427 5139 (Fsecure_hash): New primitive.
7f3f739f
LL
5140 (syms_of_fns): New symbols.
5141
76147d94
DD
51422011-06-20 Deniz Dogan <deniz@dogan.se>
5143
5144 * process.c (Fset_process_buffer): Clarify return value in
5145 docstring.
5146
7d7d0045
CY
51472011-06-18 Chong Yidong <cyd@stupidchicken.com>
5148
5149 * dispnew.c (add_window_display_history): Use BVAR.
5150
5151 * xdisp.c (debug_method_add): Use BVAR.
5152 (check_window_end, dump_glyph_matrix, dump_glyph)
5153 (dump_glyph_row, dump_glyph_string): Convert arglist to ANSI C.
5154
5155 * xfaces.c (check_lface_attrs, check_lface, dump_realized_face):
5156 Likewise.
5157
5158 * xfns.c (Fx_create_frame, x_create_tip_frame): Delay image cache
5159 check till after the cache is created in init_frame_faces.
5160
ff2bc410
SM
51612011-06-17 Stefan Monnier <monnier@iro.umontreal.ca>
5162
5163 * fns.c (Fsafe_length): Yet another int/Lisp_Object mixup.
5164
28177add
PE
51652011-06-16 Paul Eggert <eggert@cs.ucla.edu>
5166
dd3482fe
PE
5167 * lisp.h: Include <limits.h>, for INT_MAX, LONG_MAX, LLONG_MAX.
5168 Without this, prin1 mishandles Lisp_Misc_Save_Value printing on
5169 hosts with pre-C99 libraries, because pD is wrongly defined to "t".
5170
393d71f3 5171 Improve buffer-overflow checking (Bug#8873).
1c8e352f
PE
5172 * fileio.c (Finsert_file_contents):
5173 * insdel.c (insert_from_buffer_1, replace_range, replace_range_2):
5174 Remove the old (too-loose) buffer overflow checks.
5175 They weren't needed, since make_gap checks for buffer overflow.
5176 * insdel.c (make_gap_larger): Catch buffer overflows that were missed.
5177 The old code merely checked for Emacs fixnum overflow, and relied
5178 on undefined (wraparound) behavior. The new code avoids undefined
5179 behavior, and also checks for ptrdiff_t and/or size_t overflow.
5180
2e6813b0 5181 * editfns.c (Finsert_char): Don't dump core with very negative counts.
21d890a4
PE
5182 Tune. Don't use wider integers than needed. Don't use alloca.
5183 Use a bigger 'string' buffer. Rewrite to avoid 'n > 0' test.
2e6813b0 5184
599a9e4f
PE
5185 * insdel.c (replace_range): Fix buf overflow when insbytes < outgoing.
5186
99561444
PE
5187 * insdel.c, lisp.h (buffer_overflow): New function.
5188 (insert_from_buffer_1, replace_range, replace_range_2):
5189 * insdel.c (make_gap_larger):
5190 * editfns.c (Finsert_char):
5191 * fileio.c (Finsert_file_contents): Use it, to normalize wording.
5192
28177add
PE
5193 * buffer.h (BUF_BYTES_MAX): Cast to ptrdiff_t so that it's signed.
5194
e69dafad
PE
51952011-06-15 Paul Eggert <eggert@cs.ucla.edu>
5196
4baa020d 5197 Integer overflow and signedness fixes (Bug#8873, Bug#8828).
ff672d2c 5198
b1c46f02
PE
5199 * ccl.c (ASCENDING_ORDER): New macro, to work around GCC bug 43772.
5200 (GET_CCL_RANGE, IN_INT_RANGE): Use it.
5201
e69dafad
PE
5202 * fileio.c: Don't assume EMACS_INT fits in off_t.
5203 (emacs_lseek): New static function.
5204 (Finsert_file_contents, Fwrite_region): Use it.
5205 Use SEEK_SET, SEEK_CUR, SEEK_END as appropriate.
5206
566684ea
PE
5207 * fns.c (Fload_average): Don't assume 100 * load average fits in int.
5208
e6966cd6
PE
5209 * fns.c: Don't overflow int when computing a list length.
5210 * fns.c (QUIT_COUNT_HEURISTIC): New constant.
5211 (Flength, Fsafe_length): Use EMACS_INT, not int, to avoid unwanted
5212 truncation on 64-bit hosts. Check for QUIT every
5213 QUIT_COUNT_HEURISTIC entries rather than every other entry; that's
5214 faster and is responsive enough.
5215 (Flength): Report an error instead of overflowing an integer.
5216 (Fsafe_length): Return a float if the value is not representable
5217 as a fixnum. This shouldn't happen except in contrived situations.
6346d301 5218 (Fnthcdr, Fsort): Don't assume list length fits in int.
de41a810 5219 (Fcopy_sequence): Don't assume vector length fits in int.
00c604f2 5220
dd0b0efb
PE
5221 * alloc.c: Check that resized vectors' lengths fit in fixnums.
5222 (header_size, word_size): New constants.
5223 (allocate_vectorlike): Don't check size overflow here.
5224 (allocate_vector): Check it here instead, since this is the only
5225 caller of allocate_vectorlike that could cause overflow.
5226 Check that the new vector's length is representable as a fixnum.
5227
86fe5cfe
PE
5228 * fns.c (next_almost_prime): Don't return a multiple of 3 or 5.
5229 The previous code was bogus. For example, next_almost_prime (32)
5230 returned 39, which is undesirable as it is a multiple of 3; and
5231 next_almost_prime (24) returned 25, which is a multiple of 5 so
5232 why was the code bothering to check for multiples of 7?
5233
80e88859
PE
5234 * bytecode.c (exec_byte_code): Use ptrdiff_t, not int, for vector length.
5235
4a2f0ad6
PE
5236 * eval.c, doprnt.c (SIZE_MAX): Remove; inttypes.h defines this now.
5237
f66c7cf8
PE
5238 Variadic C functions now count arguments with ptrdiff_t.
5239 This partly undoes my 2011-03-30 change, which replaced int with size_t.
5240 Back then I didn't know that the Emacs coding style prefers signed int.
5241 Also, in the meantime I found a few more instances where arguments
4a2f0ad6
PE
5242 were being counted with int, which may truncate counts on 64-bit
5243 machines, or EMACS_INT, which may be unnecessarily wide.
f66c7cf8
PE
5244 * lisp.h (struct Lisp_Subr.function.aMANY)
5245 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call):
5246 Arg counts are now ptrdiff_t, not size_t.
5247 All variadic functions and their callers changed accordingly.
5248 (struct gcpro.nvars): Now size_t, not size_t. All uses changed.
5249 * bytecode.c (exec_byte_code): Check maxdepth for overflow,
5250 to avoid potential buffer overrun. Don't assume arg counts fit in 'int'.
5251 * callint.c (Fcall_interactively): Check arg count for overflow,
5252 to avoid potential buffer overrun. Use signed char, not 'int',
5253 for 'varies' array, so that we needn't bother to check its size
5254 calculation for overflow.
5255 * editfns.c (Fformat): Use ptrdiff_t, not EMACS_INT, to count args.
5256 * eval.c (apply_lambda):
5257 * fns.c (Fmapconcat): Use XFASTINT, not XINT, to get args length.
5258 (struct textprop_rec.argnum): Now ptrdiff_t, not int. All uses changed.
5259 (mapconcat): Use ptrdiff_t, not int and EMACS_INT, to count args.
5260
a1759b76
PE
5261 * callint.c (Fcall_interactively): Don't use index var as event count.
5262
d96be9fc
PE
5263 * vm-limit.c (check_memory_limits): Fix incorrect extern function decls.
5264 * mem-limits.h (SIZE): Remove; no longer used.
5265
a690a978 5266 * xterm.c (x_alloc_nearest_color_1): Prefer int to long when int works.
5efd304b 5267
578c21e6
PE
5268 Remove unnecessary casts.
5269 * xterm.c (x_term_init):
5270 * xfns.c (x_set_border_pixel):
5271 * widget.c (create_frame_gcs): Remove casts to unsigned long etc.
5272 These aren't needed now that we assume ANSI C.
5273
96f53c6c
PE
5274 * sound.c (Fplay_sound_internal): Remove cast to unsigned long.
5275 It's more likely to cause problems (due to unsigned overflow)
5276 than to cure them.
5277
83c77d31
PE
5278 * dired.c (Ffile_attributes): Don't use 32-bit hack on 64-bit hosts.
5279
ee2079f1
PE
5280 * unexelf.c (unexec): Don't assume BSS addr fits in unsigned.
5281
6da65536
PE
5282 * xterm.c (handle_one_xevent): Omit unnecessary casts to unsigned.
5283
7147c4a4
PE
5284 * keyboard.c (modify_event_symbol): Don't limit alist len to UINT_MAX.
5285
193e32d9
PE
5286 * lisp.h (CHAR_TABLE_SET): Omit now-redundant test.
5287
e5533da6
PE
5288 * lread.c (Fload): Don't compare a possibly-garbage time_t value.
5289
9910e595
PE
5290 GLYPH_CODE_FACE returns EMACS_INT, not int.
5291 * dispextern.h (merge_faces):
5292 * xfaces.c (merge_faces):
01103c44
PE
5293 * xdisp.c (get_next_display_element, next_element_from_display_vector):
5294 Don't assume EMACS_INT fits in int.
9910e595 5295
2638320e
PE
5296 * character.h (CHAR_VALID_P): Remove unused parameter.
5297 * fontset.c, lisp.h, xdisp.c: All uses changed.
5298
045eb8d9
PE
5299 * editfns.c (Ftranslate_region_internal): Omit redundant test.
5300
c1f134b5
PE
5301 * fns.c (concat): Minor tuning based on overflow analysis.
5302 This doesn't fix any bugs. Use int to hold character, instead
5303 of constantly refetching from Emacs object. Use XFASTINT, not
5304 XINT, for value known to be a character. Don't bother comparing
5305 a single byte to 0400, as it's always less.
5306
395fcb93 5307 * floatfns.c (Fexpt):
327eeec8
PE
5308 * fileio.c (make_temp_name): Omit unnecessary cast to unsigned.
5309
abbd3d23
PE
5310 * editfns.c (Ftranslate_region_internal): Use int, not EMACS_INT
5311 for characters.
5312
684a03ef
PE
5313 * doc.c (get_doc_string): Omit (unsigned)c that mishandled negatives.
5314
0fed43f3
PE
5315 * data.c (Faset): If ARRAY is a string, check that NEWELT is a char.
5316 Without this fix, on a 64-bit host (aset S 0 4294967386) would
5317 incorrectly succeed when S was a string, because 4294967386 was
5318 truncated before it was used.
5319
8fd02eb7
PE
5320 * chartab.c (Fchar_table_range): Use CHARACTERP to check range.
5321 Otherwise, an out-of-range integer could cause undefined behavior
5322 on a 64-bit host.
5323
f8c86b69
PE
5324 * composite.c: Use int, not EMACS_INT, for characters.
5325 (fill_gstring_body, composition_compute_stop_pos): Use int, not
5326 EMACS_INT, for values that are known to be in character range.
5327 This doesn't fix any bugs but is the usual style inside Emacs and
5328 may generate better code on 32-bit machines.
5329
34206dd2
PE
5330 Make sure a 64-bit char is never passed to ENCODE_CHAR.
5331 This is for reasons similar to the recent CHAR_STRING fix.
5332 * charset.c (Fencode_char): Check that character arg is actually
5333 a character. Pass an int to ENCODE_CHAR.
5334 * charset.h (ENCODE_CHAR): Verify that the character argument is no
5335 wider than 'int', as a compile-time check to prevent future regressions
5336 in this area.
5337
c5958d4c 5338 * character.c (char_string): Remove unnecessary casts.
13bdea59
PE
5339
5340 Make sure a 64-bit char is never passed to CHAR_STRING.
5341 Otherwise, CHAR_STRING would do the wrong thing on a 64-bit platform,
5342 by silently ignoring the top 32 bits, allowing some values
5343 that were far too large to be valid characters.
5344 * character.h: Include <verify.h>.
5345 (CHAR_STRING, CHAR_STRING_ADVANCE): Verify that the character
5346 arguments are no wider than unsigned, as a compile-time check
5347 to prevent future regressions in this area.
5348 * data.c (Faset):
01103c44 5349 * editfns.c (Fchar_to_string, general_insert_function, Finsert_char)
13bdea59
PE
5350 (Fsubst_char_in_region):
5351 * fns.c (concat):
5352 * xdisp.c (decode_mode_spec_coding):
5353 Adjust to CHAR_STRING's new requirement.
5354 * editfns.c (Finsert_char, Fsubst_char_in_region):
5355 * fns.c (concat): Check that character args are actually
5356 characters. Without this test, these functions did the wrong
5357 thing with wildly out-of-range values on 64-bit hosts.
5358
d37ca623
PE
5359 Remove incorrect casts to 'unsigned' that lose info on 64-bit hosts.
5360 These casts should not be needed on 32-bit hosts, either.
5361 * keyboard.c (read_char):
5362 * lread.c (Fload): Remove casts to unsigned.
5363
ea204efb
PE
5364 * lisp.h (UNSIGNED_CMP): New macro.
5365 This fixes comparison bugs on 64-bit hosts.
5366 (ASCII_CHAR_P): Use it.
5367 * casefiddle.c (casify_object):
01103c44 5368 * character.h (ASCII_BYTE_P, CHAR_VALID_P)
ea204efb
PE
5369 (SINGLE_BYTE_CHAR_P, CHAR_STRING):
5370 * composite.h (COMPOSITION_ENCODE_RULE_VALID):
5371 * dispextern.h (FACE_FROM_ID):
5372 * keyboard.c (read_char): Use UNSIGNED_CMP.
5373
41cb286c
PE
5374 * xmenu.c (dialog_selection_callback) [!USE_GTK]: Cast to intptr_t,
5375 not to EMACS_INT, to avoid GCC warning.
5376
4a1b9832
PE
5377 * xfns.c (x_set_scroll_bar_default_width): Remove unused 'int' locals.
5378
55daad71
PE
5379 * buffer.h (PTR_BYTE_POS, BUF_PTR_BYTE_POS): Remove harmful cast.
5380 The cast incorrectly truncated 64-bit byte offsets to 32 bits, and
5381 isn't needed on 32-bit machines.
8f95c75c 5382
01103c44
PE
5383 * buffer.c (Fgenerate_new_buffer_name):
5384 Use EMACS_INT for count, not int.
0ceccced 5385 (advance_to_char_boundary): Return EMACS_INT, not int.
e762cafe
PE
5386
5387 * data.c (Qcompiled_function): Now static.
5388
c6f072e7
PE
5389 * window.c (window_body_lines): Now static.
5390
20ce5912
PE
5391 * image.c (gif_load): Rename local to avoid shadowing.
5392
9c4c5f81
PE
5393 * lisp.h (SAFE_ALLOCA_LISP): Check for integer overflow.
5394 (struct Lisp_Save_Value): Use ptrdiff_t, not int, for 'integer' member.
5395 * alloc.c (make_save_value): Integer argument is now of type
5396 ptrdiff_t, not int.
5397 (mark_object): Use ptrdiff_t, not int.
5398 * lisp.h (pD): New macro.
5399 * print.c (print_object): Use it.
5400
c0c5c8ae
PE
5401 * alloc.c: Use EMACS_INT, not int, to count objects.
5402 (total_conses, total_markers, total_symbols, total_vector_size)
5403 (total_free_conses, total_free_markers, total_free_symbols)
01103c44
PE
5404 (total_free_floats, total_floats, total_free_intervals)
5405 (total_intervals, total_strings, total_free_strings):
c0c5c8ae
PE
5406 Now EMACS_INT, not int. All uses changed.
5407 (Fgarbage_collect): Compute overall total using a double, so that
5408 integer overflow is less likely to be a problem. Check for overflow
5409 when converting back to an integer.
5a25e253
PE
5410 (n_interval_blocks, n_string_blocks, n_float_blocks, n_cons_blocks)
5411 (n_vectors, n_symbol_blocks, n_marker_blocks): Remove.
5412 These were 'int' variables that could overflow on 64-bit hosts;
5413 they were never used, so remove them instead of repairing them.
211a0b2a 5414 (nzombies, ngcs, max_live, max_zombies): Now EMACS_INT, not 'int'.
6349ae4d
PE
5415 (inhibit_garbage_collection): Set gc_cons_threshold to max value.
5416 Previously, this ceilinged at INT_MAX, but that doesn't work on
5417 64-bit machines.
e46bb31a 5418 (allocate_pseudovector): Don't use EMACS_INT when int would do.
c0c5c8ae 5419
c78baabf 5420 * alloc.c (Fmake_bool_vector): Don't assume vector size fits in int.
86f61a15 5421 (allocate_vectorlike): Check for ptrdiff_t overflow.
b6439961
PE
5422 (mark_vectorlike, mark_char_table, mark_object): Avoid EMACS_UINT
5423 when a (possibly-narrower) signed value would do just as well.
5424 We prefer using signed arithmetic, to avoid comparison confusion.
c78baabf 5425
c9d624c6
PE
5426 * alloc.c: Catch some string size overflows that we were missing.
5427 (XMALLOC_OVERRUN_CHECK_SIZE) [!XMALLOC_OVERRUN_CHECK]: Define to 0,
5428 for convenience in STRING_BYTES_MAX.
5429 (STRING_BYTES_MAX): New macro, superseding the old one in lisp.h.
5430 The definition here is exact; the one in lisp.h was approximate.
5431 (allocate_string_data): Check for string overflow. This catches
5432 some instances we weren't catching before. Also, it catches
5433 size_t overflow on (unusual) hosts where SIZE_MAX <= min
5434 (PTRDIFF_MAX, MOST_POSITIVE_FIXNUM), e.g., when size_t is 32 bits
5435 and ptrdiff_t and EMACS_INT are both 64 bits.
c78baabf 5436
c9d624c6
PE
5437 * character.c, coding.c, doprnt.c, editfns.c, eval.c:
5438 All uses of STRING_BYTES_MAX replaced by STRING_BYTES_BOUND.
640c8776 5439 * lisp.h (STRING_BYTES_BOUND): Rename from STRING_BYTES_MAX.
c9d624c6 5440
353032ce
PE
5441 * character.c (string_escape_byte8): Fix nbytes/nchars typo.
5442
2bccce07
PE
5443 * alloc.c (Fmake_string): Check for out-of-range init.
5444
0ac30604
SM
54452011-06-15 Stefan Monnier <monnier@iro.umontreal.ca>
5446
5447 * eval.c (Fdefvaralias): Also mark the target as variable-special-p.
5448
c195f2de
JD
54492011-06-14 Jan Djärv <jan.h.d@swipnet.se>
5450
5451 * xfns.c (x_set_scroll_bar_default_width): Remove argument to
5452 xg_get_default_scrollbar_width.
5453
5454 * gtkutil.c: Include emacsgtkfixed.h if HAVE_GTK3.
5455 (int_gtk_range_get_value): Move to the scroll bar part of the file.
5456 (style_changed_cb): Call update_theme_scrollbar_width and call
5457 x_set_scroll_bar_default_width and xg_frame_set_char_size for
5458 all frames (Bug#8505).
5459 (xg_create_frame_widgets): Call emacs_fixed_new if HAVE_GTK3 (Bug#8505).
5460 Call gtk_window_set_resizable if HAVE_GTK3.
5461 (x_wm_set_size_hint): Call emacs_fixed_set_min_size with min width
5462 and height if HAVE_GTK3 (Bug#8505).
5463 (scroll_bar_width_for_theme): New variable.
5464 (update_theme_scrollbar_width): New function.
5465 (xg_get_default_scrollbar_width): Move code to
5466 update_theme_scrollbar_width, just return scroll_bar_width_for_theme.
5467 (xg_initialize): Call update_theme_scrollbar_width.
5468
5469 * gtkutil.h (xg_get_default_scrollbar_width): Remove argument.
5470
5471 * emacsgtkfixed.c, emacsgtkfixed.h: New files.
5472
e10ac9f1
MR
54732011-06-12 Martin Rudalics <rudalics@gmx.at>
5474
5475 * frame.c (make_frame): Call other_buffer_safely instead of
5476 other_buffer.
5477
5478 * window.c (temp_output_buffer_show): Call display_buffer with
5479 second argument Vtemp_buffer_show_specifiers and reset latter
5480 immediately after the call.
5481 (Vtemp_buffer_show_specifiers): New variable.
5482 (auto_window_vscroll_p, next_screen_context_lines)
5483 (Vscroll_preserve_screen_position): Remove leading asterisks from
5484 doc-strings.
5485
2d3c217e 54862011-06-12 Paul Eggert <eggert@cs.ucla.edu>
4475bec4 5487
7b7f97e8 5488 Fix minor problems found by GCC 4.6.0 static checking.
4475bec4
PE
5489 * buffer.c (Qclone_number): Remove for now, as it's unused.
5490 (record_buffer, Funrecord_buffer): Rename local to avoid shadowing.
5491 (record_buffer): Remove unused local.
5492 * frame.c (other_visible_frames, frame_buffer_list): Now static.
5493 (set_frame_buffer_list): Remove; unused.
5494 * frame.h (other_visible_frames): Remove decl.
5495 * keyboard.h (menu_items_inuse): Declare only if USE_GTK || USE_MOTIF.
5496 * lisp.h (frame_buffer_list, set_frame_buffer_list): Remove decls.
5497 (add_gpm_wait_descriptor, delete_gpm_wait_descriptor): Declare only
5498 if HAVE_GPM.
5499 * menu.c (menu_items_inuse): Now static unless USE_GTK || USE_MOTIF.
5500 * process.c (add_gpm_wait_descriptor, delete_gpm_wait_descriptor):
5501 Define only if HAVE_GPM.
5502 * widget.c (EmacsFrameResize, emacsFrameClassRec): Now static.
5503 (update_hints_inhibit): Remove; never set. All uses removed.
5504 * widgetprv.h (emacsFrameClassRec): Remove decl.
5505 * window.c (delete_deletable_window): Now returns void, since it
5506 wasn't returning anything.
5507 (compare_window_configurations): Remove unused locals.
5508 * xfns.c (x_set_scroll_bar_default_width): Remove unused locals.
5509 * xmenu.c (x_menu_set_in_use): Define only if USE_GTK || USE_MOTIF.
4475bec4
PE
5510 (dialog_selection_callback) [!USE_GTK]: Prefer intptr_t for integers
5511 the same widths as pointers. This follows up on the 2011-05-06 patch.
5512 * xterm.c (x_alloc_lighter_color_for_widget): Define only if USE_LUCID.
5513 * xterm.h: Likewise.
5514 (x_menu_set_in_use): Declare only if USE_GTK || USE_MOTIF.
5515
1384b89e
JB
55162011-06-12 Juanma Barranquero <lekktu@gmail.com>
5517
5518 * makefile.w32-in: Update dependencies.
5519 (LISP_H): Add lib/intprops.h.
5520
1100a63c
CY
55212011-06-11 Chong Yidong <cyd@stupidchicken.com>
5522
5523 * image.c (gif_load): Add animation frame delay to the metadata.
5524 (syms_of_image): Use DEFSYM. New symbol `delay'.
5525
6198ccd0
MR
55262011-06-11 Martin Rudalics <rudalics@gmx.at>
5527
5528 * window.c (delete_deletable_window): Re-add.
5529 (Fset_window_configuration): Rewrite to handle dead buffers and
5530 consequently deletable windows.
5531 (window_tree, Fwindow_tree): Remove. Supply functionality in
5532 window.el.
5533 (compare_window_configurations): Simplify code.
5534
b6e3633c
AS
55352011-06-11 Andreas Schwab <schwab@linux-m68k.org>
5536
1ab0dee5
AS
5537 * image.c (imagemagick_load_image): Fix type mismatch.
5538 (Fimagemagick_types): Likewise.
5539
b6e3633c
AS
5540 * window.h (replace_buffer_in_windows): Declare.
5541
9397e56f
MR
55422011-06-11 Martin Rudalics <rudalics@gmx.at>
5543
5544 * buffer.c: New Lisp objects Qbuffer_list_update_hook and
5545 Qclone_number. Remove external declaration of Qdelete_window.
5546 (Fbuffer_list): Rewrite doc-string. Minor restructuring of
5547 code.
640c8776
SM
5548 (Fget_buffer_create, Fmake_indirect_buffer, Frename_buffer):
5549 Run Qbuffer_list_update_hook if allowed.
9397e56f
MR
5550 (Fother_buffer): Rewrite doc-string. Major rewrite for new
5551 buffer list implementation.
5552 (other_buffer_safely): New function.
5553 (Fkill_buffer): Replace call to replace_buffer_in_all_windows by
5554 calls to replace_buffer_in_windows and
5555 replace_buffer_in_windows_safely. Run Qbuffer_list_update_hook
5556 if allowed.
5557 (record_buffer): Inhibit quitting and rewrite using quittable
5558 functions. Run Qbuffer_list_update_hook if allowed.
5559 (Frecord_buffer, Funrecord_buffer): New functions.
640c8776
SM
5560 (switch_to_buffer_1, Fswitch_to_buffer): Remove.
5561 Move switch-to-buffer to window.el.
9397e56f
MR
5562 (bury-buffer): Move to window.el.
5563 (Vbuffer_list_update_hook): New variable.
5564
5565 * lisp.h (other_buffer_safely): Add prototype in buffer.c
5566 section.
5567
5568 * window.h (resize_frame_windows): Move up in code.
5569 (Fwindow_frame): Remove EXFUN.
5570 (replace_buffer_in_all_windows): Remove prototype.
5571 (replace_buffer_in_windows_safely): Add prototype.
5572
5573 * window.c: Declare Qdelete_window static again. Move down
5574 declaration of select_count.
5575 (Fnext_window, Fprevious_window): Rewrite doc-strings.
5576 (Fother_window): Move to window.el.
5577 (window_loop): Remove DELETE_BUFFER_WINDOWS and UNSHOW_BUFFER
5578 cases. Add REPLACE_BUFFER_IN_WINDOWS_SAFELY case.
5579 (Fdelete_windows_on, Freplace_buffer_in_windows): Move to
5580 window.el.
5581 (replace_buffer_in_windows): Implement by calling
5582 Qreplace_buffer_in_windows.
5583 (replace_buffer_in_all_windows): Remove with some functionality
5584 moved into replace_buffer_in_windows_safely.
5585 (replace_buffer_in_windows_safely): New function.
5586 (select_window_norecord, select_frame_norecord): Move in front
5587 of run_window_configuration_change_hook. Remove now obsolete
5588 declarations.
640c8776
SM
5589 (Fset_window_buffer): Rewrite doc-string.
5590 Call Qrecord_window_buffer.
9397e56f
MR
5591 (keys_of_window): Move binding for other-window to window.el.
5592
b50691aa
CY
55932011-06-11 Chong Yidong <cyd@stupidchicken.com>
5594
5595 * dispextern.h (struct image): Replace data member, whose int_val
5596 and ptr_val fields were not used by anything, with a single
5597 lisp_val object.
5598
5599 * image.c (Fimage_metadata, make_image, mark_image, tiff_load)
5600 (gif_clear_image, gif_load, imagemagick_load_image)
5601 (gs_clear_image, gs_load): Callers changed.
5602
3f754b86
PE
56032011-06-10 Paul Eggert <eggert@cs.ucla.edu>
5604
cca69397
PE
5605 * buffer.h: Include <time.h>, for time_t.
5606 Needed to build on FreeBSD 8.2. Problem reported by Herbert J. Skuhra.
5607
109e28d0
PE
5608 Fix minor problems found by static checking.
5609
60737f02
PE
5610 * image.c (PixelGetMagickColor): Declare if ImageMagick headers don't.
5611
4b66faf3
PE
5612 Make identifiers static if they are not used in other modules.
5613 * data.c (Qcompiled_function, Qframe, Qvector):
5614 * image.c (QimageMagick, Qsvg):
5615 * minibuf.c (Qmetadata):
5616 * window.c (resize_window_check, resize_root_window): Now static.
5617 * window.h (resize_window_check, resize_root_window): Remove decls.
5618
109e28d0
PE
5619 * window.c (window_deletion_count, delete_deletable_window):
5620 Remove; unused.
46a4ce9e
PE
5621 (window_body_lines): Now static.
5622 (Fdelete_other_windows_internal): Mark vars as initialized.
5623 Make sure 'resize_failed' is initialized.
5624 (run_window_configuration_change_hook): Rename local to avoid shadowing.
5625 (resize_window_apply): Remove unused local.
5626 * window.h (delete_deletable_window): Remove decl.
5627
109e28d0 5628 * image.c (gif_load, svg_load_image): Rename locals to avoid shadowing.
33290528
PE
5629 (imagemagick_load_image): Fix pointer signedness problem by changing
5630 last arg from unsigned char * to char *. All uses changed.
5631 Also, fix a local for similar reasons.
5632 Remove unused locals. Remove locals to avoid shadowing.
5633 (fn_rsvg_handle_free): Remove; unused.
5634 (svg_load, svg_load_image): Fix pointer signedness problem.
f7e13da3 5635 (imagemagick_load_image): Don't use garbage pointer image_wand.
33290528 5636
3f754b86
PE
5637 * ftfont.c (ftfont_get_metrics, ftfont_drive_otf): Remove unused locals.
5638
2547adb1
CY
56392011-06-10 Chong Yidong <cyd@stupidchicken.com>
5640
5641 * image.c (gif_load): Fix omitted cast error introduced by
5642 2011-06-06 change.
5643
2c8e37d4
MR
56442011-06-10 Martin Rudalics <rudalics@gmx.at>
5645
5646 * window.h (resize_proportionally, orig_total_lines)
5647 (orig_top_line): Remove from window structure.
5648 (set_window_height, set_window_width, change_window_heights)
5649 (Fdelete_window): Remove prototypes.
5650 (resize_frame_windows): Remove duplicate declaration.
5651
440a42e3
EZ
56522011-06-10 Eli Zaretskii <eliz@gnu.org>
5653
5654 * window.h (resize_frame_windows, resize_window_check)
5655 (delete_deletable_window, resize_root_window)
5656 (resize_frame_windows): Declare prototypes.
5657
5658 * window.c (resize_window_apply): Make definition be "static" to
5659 match the prototype.
5660
562dd5e9
MR
56612011-06-10 Martin Rudalics <rudalics@gmx.at>
5662
5663 * window.c: Remove declarations of Qwindow_size_fixed,
5664 window_min_size_1, window_min_size_2, window_min_size,
5665 size_window, window_fixed_size_p, enlarge_window, delete_window.
5666 Remove static from declaration of Qdelete_window, it's
5667 temporarily needed by Fbury_buffer.
5668 (replace_window): Don't assign orig_top_line and
5669 orig_total_lines.
5670 (Fdelete_window, delete_window): Remove. Window deletion is
5671 handled by window.el.
640c8776
SM
5672 (window_loop): Remove DELETE_OTHER_WINDOWS case.
5673 Replace Fdelete_window calls with calls to Qdelete_window.
562dd5e9
MR
5674 (Fdelete_other_windows): Remove. Deleting other windows is
5675 handled by window.el.
5676 (window_fixed_size_p): Remove. Fixed-sizeness of windows is
5677 handled in window.el.
5678 (window_min_size_2, window_min_size_1, window_min_size): Remove.
5679 Window minimum sizes are handled in window.el.
5680 (shrink_windows, size_window, set_window_height)
5681 (set_window_width, change_window_heights, window_height)
5682 (window_width, CURBEG, CURSIZE, enlarge_window)
5683 (adjust_window_trailing_edge, Fadjust_window_trailing_edge)
5684 (Fenlarge_window, Fshrink_window): Remove. Window resizing is
5685 handled in window.el.
5686 (make_dummy_parent): Rename to make_parent_window and give it a
5687 second argument horflag.
5688 (make_window): Don't set resize_proportionally any more.
5689 (Fsplit_window): Remove. Windows are split in window.el.
5690 (save_restore_action, save_restore_orig_size)
5691 (shrink_window_lowest_first, save_restore_orig_size): Remove.
5692 Resize mini windows in window.el.
5693 (grow_mini_window, shrink_mini_window): Implement by calling
5694 Qresize_root_window_vertically, resize_window_check and
5695 resize_window_apply.
640c8776
SM
5696 (saved_window, Fset_window_configuration, save_window_save):
5697 Do not handle orig_top_line, orig_total_lines, and
562dd5e9
MR
5698 resize_proportionally.
5699 (window_min_height, window_min_width): Move to window.el.
5700 (keys_of_window): Move bindings for delete-other-windows,
5701 split-window, delete-window and enlarge-window to window.el.
5702
5703 * buffer.c: Temporarily extern Qdelete_window.
5704 (Fbury_buffer): Temporarily call Qdelete_window instead of
5705 Fdelete_window (Fbury_buffer will move to window.el soon).
5706
5707 * frame.c (set_menu_bar_lines_1): Remove code handling
5708 orig_top_line and orig_total_lines.
5709
5710 * dispnew.c (adjust_frame_glyphs_initially): Don't use
5711 set_window_height but set heights directly.
5712 (change_frame_size_1): Use resize_frame_windows.
5713
5714 * xdisp.c (init_xdisp): Don't use set_window_height but set
5715 heights directly.
5716
640c8776
SM
5717 * xfns.c (x_set_menu_bar_lines, x_set_tool_bar_lines):
5718 Use resize_frame_windows instead of change_window_heights and run
562dd5e9
MR
5719 run_window_configuration_change_hook.
5720
5721 * w32fns.c (x_set_tool_bar_lines): Use resize_frame_windows
5722 instead of change_window_heights and run
5723 run_window_configuration_change_hook.
5724
1a13852e
MR
57252011-06-09 Martin Rudalics <rudalics@gmx.at>
5726
5727 * window.c (replace_window): Rename second argument REPLACEMENT to
5728 NEW. New third argument SETFLAG. Rewrite.
5729 (delete_window, make_dummy_parent): Call replace_window with
5730 third argument 1.
5731 (window_list_1): Move down in code.
5732 (run_window_configuration_change_hook): Move set_buffer part
5733 before select_frame_norecord part in order to unwind correctly.
5734 Rename count1 to count.
5735 (recombine_windows, delete_deletable_window, resize_root_window)
5736 (Fdelete_other_windows_internal)
5737 (Frun_window_configuration_change_hook, make_parent_window)
5738 (resize_window_check, resize_window_apply, Fresize_window_apply)
5739 (resize_frame_windows, Fsplit_window_internal)
640c8776
SM
5740 (Fdelete_window_internal, Fresize_mini_window_internal):
5741 New functions.
1a13852e
MR
5742 (syms_of_window): New variables Vwindow_splits and Vwindow_nest.
5743
f3d1777e
MR
57442011-06-08 Martin Rudalics <rudalics@gmx.at>
5745
496e208e
MR
5746 * window.h (window): Add some new members to window structure -
5747 normal_lines, normal_cols, new_total, new_normal, clone_number,
5748 splits, nest, prev_buffers, next_buffers.
5749 (WINDOW_TOTAL_SIZE): Move here from window.c.
b9e809c2 5750 (MIN_SAFE_WINDOW_WIDTH, MIN_SAFE_WINDOW_HEIGHT): Define here.
496e208e 5751
f3d1777e
MR
5752 * window.c (Fwindow_height, Fwindow_width, Fwindow_full_width_p):
5753 Remove.
496e208e
MR
5754 (make_dummy_parent): Set new members of windows structure.
5755 (make_window): Move down in code. Handle new members of window
5756 structure.
5757 (Fwindow_clone_number, Fwindow_splits, Fset_window_splits)
5758 (Fwindow_nest, Fset_window_nest, Fwindow_new_total)
5759 (Fwindow_normal_size, Fwindow_new_normal, Fwindow_prev_buffers)
5760 (Fset_window_prev_buffers, Fwindow_next_buffers)
640c8776
SM
5761 (Fset_window_next_buffers, Fset_window_clone_number):
5762 New functions.
496e208e
MR
5763 (Fwindow_hscroll, Fwindow_at, Fwindow_point, Fwindow_start)
5764 (Fwindow_end, Fwindow_line_height, Fset_window_dedicated_p):
5765 Doc-string fixes.
5766 (Fwindow_parameters, Fwindow_parameter, Fset_window_parameter):
5767 Argument WINDOW can be now internal window too.
5768 (Fwindow_use_time): Move up in code.
5769 (Fget_buffer_window): Rename argument FRAME to ALL-FRAMES.
5770 Rewrite doc-string.
5771 (Fset_window_configuration, saved_window)
5772 (Fcurrent_window_configuration, save_window_save): Handle new
5773 members of window structure.
b9e809c2
MR
5774 (WINDOW_TOTAL_SIZE, MIN_SAFE_WINDOW_WIDTH)
5775 (MIN_SAFE_WINDOW_HEIGHT): Move to window.h.
5776 (syms_of_window): New Lisp objects Qrecord_window_buffer,
5777 Qwindow_deletable_p, Qdelete_window, Qreplace_buffer_in_windows,
5778 Qget_mru_window, Qresize_root_window,
5779 Qresize_root_window_vertically, Qsafe, Qabove, Qbelow,
5780 Qauto_buffer_name; staticpro them.
f3d1777e 5781
abde8f8c
MR
57822011-06-07 Martin Rudalics <rudalics@gmx.at>
5783
5784 * window.c (Fwindow_total_size, Fwindow_left_column)
5785 (Fwindow_top_line, window_body_lines, Fwindow_body_size)
5786 (Fwindow_list_1): New functions.
5787 (window_box_text_cols): Replace with window_body_cols.
640c8776
SM
5788 (Fwindow_width, Fscroll_left, Fscroll_right):
5789 Use window_body_cols instead of window_box_text_cols.
5790 (delete_window, Fset_window_configuration):
5791 Call delete_all_subwindows with window as argument.
fa8a67e6
MR
5792 (delete_all_subwindows): Take a window as argument and not a
5793 structure. Rewrite.
190b47e6
MR
5794 (window_loop): Remove handling of GET_LRU_WINDOW and
5795 GET_LARGEST_WINDOW.
5796 (Fget_lru_window, Fget_largest_window): Move to window.el.
abde8f8c
MR
5797
5798 * window.h: Extern window_body_cols instead of
fa8a67e6
MR
5799 window_box_text_cols. delete_all_subwindows now takes a
5800 Lisp_Object as argument.
abde8f8c 5801
640c8776
SM
5802 * indent.c (compute_motion, Fcompute_motion):
5803 Use window_body_cols instead of window_box_text_cols.
abde8f8c 5804
fa8a67e6
MR
5805 * frame.c (delete_frame): Call delete_all_subwindows with root
5806 window as argument.
5807
a54e3482
DC
58082011-06-07 Daniel Colascione <dan.colascione@gmail.com>
5809
5810 * fns.c (Fputhash): Document return value.
5811
60002bf5
CY
58122011-06-06 Chong Yidong <cyd@stupidchicken.com>
5813
5814 * image.c (gif_load): Implement gif89a spec "no disposal" method.
5815
0c671da6 58162011-06-06 Paul Eggert <eggert@cs.ucla.edu>
ccd9a01a 5817
b862a52a 5818 Cons<->int and similar integer overflow fixes (Bug#8794).
77984278 5819
be44ca6c
PE
5820 Check for overflow when converting integer to cons and back.
5821 * charset.c (Fdefine_charset_internal, Fdecode_char):
5822 Use cons_to_unsigned to catch overflow.
5823 (Fencode_char): Use INTEGER_TO_CONS.
5824 * composite.h (LGLYPH_CODE): Use cons_to_unsigned.
5825 (LGLYPH_SET_CODE): Use INTEGER_TO_CONS.
5826 * data.c (long_to_cons, cons_to_long): Remove.
5827 (cons_to_unsigned, cons_to_signed): New functions.
5828 These signal an error for invalid or out-of-range values.
5829 * dired.c (Ffile_attributes): Use INTEGER_TO_CONS.
5830 * fileio.c (Fset_visited_file_modtime): Use CONS_TO_INTEGER.
5831 * font.c (Ffont_variation_glyphs):
5832 * fontset.c (Finternal_char_font): Use INTEGER_TO_CONS.
5833 * lisp.h: Include <intprops.h>.
5834 (INTEGER_TO_CONS, CONS_TO_INTEGER): New macros.
5835 (cons_to_signed, cons_to_unsigned): New decls.
5836 (long_to_cons, cons_to_long): Remove decls.
5837 * undo.c (record_first_change): Use INTEGER_TO_CONS.
5838 (Fprimitive_undo): Use CONS_TO_INTEGER.
5839 * xfns.c (Fx_window_property): Likewise.
5840 * xselect.c: Include <limits.h>.
5841 (x_own_selection, selection_data_to_lisp_data):
5842 Use INTEGER_TO_CONS.
5843 (x_handle_selection_request, x_handle_selection_clear)
5844 (x_get_foreign_selection, Fx_disown_selection_internal)
5845 (Fx_get_atom_name, x_send_client_event): Use CONS_TO_INTEGER.
5846 (lisp_data_to_selection_data): Use cons_to_unsigned.
5847 (x_fill_property_data): Use cons_to_signed.
5848 Report values out of range.
5849
d1f3d2af
PE
5850 Check for buffer and string overflow more precisely.
5851 * buffer.h (BUF_BYTES_MAX): New macro.
5852 * lisp.h (STRING_BYTES_MAX): New macro.
5853 * alloc.c (Fmake_string):
5854 * character.c (string_escape_byte8):
5855 * coding.c (coding_alloc_by_realloc):
5856 * doprnt.c (doprnt):
5857 * editfns.c (Fformat):
5858 * eval.c (verror):
5859 Use STRING_BYTES_MAX, not MOST_POSITIVE_FIXNUM,
5860 since they may not be the same number.
5861 * editfns.c (Finsert_char):
5862 * fileio.c (Finsert_file_contents):
5863 Likewise for BUF_BYTES_MAX.
5864
dd52fcea
PE
5865 * image.c: Use ptrdiff_t, not int, for sizes.
5866 (slurp_file): Switch from int to ptrdiff_t.
5867 All uses changed.
5868 (slurp_file): Check that file size fits in both size_t (for
5869 malloc) and ptrdiff_t (for sanity and safety).
5870
7f9bbdbb
PE
5871 * fileio.c (Fverify_visited_file_modtime): Avoid time overflow
5872 if b->modtime has its maximal value.
5873
dfe18f82
PE
5874 * dired.c (Ffile_attributes): Don't assume EMACS_INT has >32 bits.
5875
84acfcf0
PE
5876 Don't assume time_t can fit into int.
5877 * buffer.h (struct buffer.modtime): Now time_t, not int.
5878 * fileio.c (Fvisited_file_modtime): No need for time_t cast now.
5879 * undo.c (Fprimitive_undo): Use time_t, not int, for time_t value.
5880
ccd9a01a
PE
5881 Minor fixes for signed vs unsigned integers.
5882 * character.h (MAYBE_UNIFY_CHAR):
5883 * charset.c (maybe_unify_char):
5884 * keyboard.c (read_char, reorder_modifiers):
5885 XINT -> XFASTINT, since the integer must be nonnegative.
5886 * ftfont.c (ftfont_spec_pattern):
5887 * keymap.c (access_keymap, silly_event_symbol_error):
5888 XUINT -> XFASTINT, since the integer must be nonnegative.
5889 (Fsingle_key_description, preferred_sequence_p): XUINT -> XINT,
5890 since it makes no difference and we prefer signed.
5891 * keyboard.c (record_char): Use XUINT when all the neighbors do.
5892 (access_keymap): NATNUMP -> INTEGERP, since the integer must be
5893 nonnegative.
5894
d6d100dd
SM
58952011-06-06 Stefan Monnier <monnier@iro.umontreal.ca>
5896
5897 * window.h (Fwindow_frame): Declare.
5898
2b6148e4
PE
58992011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5900
5901 * alloc.c: Simplify handling of large-request failures (Bug#8800).
5902 (SPARE_MEMORY): Always define.
5903 (LARGE_REQUEST): Remove.
5904 (memory_full): Use SPARE_MEMORY rather than LARGE_REQUEST.
5905
f230ecc9
MR
59062011-06-06 Martin Rudalics <rudalics@gmx.at>
5907
727e958e
MR
5908 * lisp.h: Move EXFUNS for Fframe_root_window,
5909 Fframe_first_window and Fset_frame_selected_window to window.h.
5910
5911 * window.h: Move EXFUNS for Fframe_root_window,
5912 Fframe_first_window and Fset_frame_selected_window here from
5913 lisp.h.
5914
5915 * frame.c (Fwindow_frame, Fframe_first_window)
5916 (Fframe_root_window, Fframe_selected_window)
5917 (Fset_frame_selected_window): Move to window.c.
5918 (Factive_minibuffer_window): Move to minibuf.c.
5919 (Fother_visible_frames_p): New function.
5920
5921 * minibuf.c (Factive_minibuffer_window): Move here from frame.c.
5922
f230ecc9
MR
5923 * window.c (decode_window, decode_any_window): Move up in code.
5924 (Fwindowp, Fwindow_live_p): Rewrite doc-strings.
5925 (inhibit_frame_unsplittable): Remove unused variable.
bf60a96b
MR
5926 (Fwindow_buffer): Move up and rewrite doc-string.
5927 (Fwindow_parent, Fwindow_vchild, Fwindow_hchild, Fwindow_next)
5928 (Fwindow_prev): New functions.
727e958e
MR
5929 (Fwindow_frame): Move here from frame.c. Accept any window as
5930 argument.
5931 (Fframe_root_window, Fframe_first_window)
5932 (Fframe_selected_window): Move here from frame.c. Accept frame
5933 or arbitrary window as argument. Update doc-strings.
5934 (Fminibuffer_window): Move up in code.
5935 (Fwindow_minibuffer_p): Move up in code and simplify.
d6d100dd
SM
5936 (Fset_frame_selected_window): Move here from frame.c.
5937 Marginal rewrite.
727e958e
MR
5938 (Fselected_window, select_window, Fselect_window): Move up in
5939 code. Minor doc-string fixes.
f230ecc9 5940
4d09bcf6
PE
59412011-06-06 Paul Eggert <eggert@cs.ucla.edu>
5942
5943 * alloc.c (memory_full) [SYSTEM_MALLOC]: Port to MacOS (Bug#8800).
5944 Do not assume that spare memory exists; that assumption is valid
5945 only if SYSTEM_MALLOC.
5946 (LARGE_REQUEST): New macro, so that the issue of large requests
5947 is separated from the issue of spare memory.
5948
810928a2
AS
59492011-06-05 Andreas Schwab <schwab@linux-m68k.org>
5950
172418ad
AS
5951 * editfns.c (Fformat): Correctly handle zero flag with hexadecimal
5952 format. (Bug#8806)
5953
43f862f7
AS
5954 * gtkutil.c (xg_get_default_scrollbar_width): Avoid warning.
5955
810928a2
AS
5956 * xfns.c (x_set_scroll_bar_default_width): Move declarations
5957 before statements.
5958
a059fe24
JD
59592011-06-05 Jan Djärv <jan.h.d@swipnet.se>
5960
5961 * gtkutil.c (xg_get_default_scrollbar_width): New function.
5962
5963 * gtkutil.h: Declare xg_get_default_scrollbar_width.
5964
5965 * xfns.c (x_set_scroll_bar_default_width): If USE_GTK, get
5966 min width by calling x_set_scroll_bar_default_width (Bug#8505).
5967
989bf368
JB
59682011-06-05 Juanma Barranquero <lekktu@gmail.com>
5969
5970 * xdisp.c (single_display_spec_intangible_p): Remove declaration.
5971
4b80f674
CY
59722011-06-04 Chong Yidong <cyd@stupidchicken.com>
5973
5974 * xselect.c (x_clipboard_manager_save): Remove redundant arg.
5975 (x_clipboard_manager_save): Add return value.
d6d100dd
SM
5976 (x_clipboard_manager_error_1, x_clipboard_manager_error_2):
5977 New error handlers.
4b80f674
CY
5978 (x_clipboard_manager_save_frame, x_clipboard_manager_save_all):
5979 Obey Vx_select_enable_clipboard_manager. Catch errors in
5980 x_clipboard_manager_save (Bug#8779).
5981 (Vx_select_enable_clipboard_manager): New variable.
de65b42c 5982 (x_get_foreign_selection): Reduce scope of x_catch_errors (Bug#8790).
4b80f674 5983
99a33b77 59842011-06-04 Dan Nicolaescu <dann@ics.uci.edu>
8b3115e7
DN
5985
5986 * emacs.c (main): Warn when starting a GTK emacs in daemon mode.
5987
99a33b77 59882011-06-04 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
14eca62f
YM
5989
5990 * fringe.c (update_window_fringes): Don't update overlay arrow bitmap
5991 in the current matrix if keep_current_p is non-zero.
5992
8264569d
EZ
59932011-06-04 Eli Zaretskii <eliz@gnu.org>
5994
5995 * bidi.c (bidi_level_of_next_char): Fix last change.
5996
57f97249
EZ
59972011-06-03 Eli Zaretskii <eliz@gnu.org>
5998
fec2107c 5999 Support bidi reordering of text covered by display properties.
57f97249 6000
fec2107c
EZ
6001 * bidi.c (bidi_copy_it): Use offsetof instead of emulating it.
6002 (bidi_fetch_char, bidi_fetch_char_advance): New functions.
6003 (bidi_cache_search, bidi_cache_iterator_state)
6004 (bidi_paragraph_init, bidi_resolve_explicit, bidi_resolve_weak)
d6d100dd
SM
6005 (bidi_level_of_next_char, bidi_move_to_visually_next):
6006 Support character positions inside a run of characters covered by a
fec2107c
EZ
6007 display string.
6008 (bidi_paragraph_init, bidi_resolve_explicit_1)
6009 (bidi_level_of_next_char): Call bidi_fetch_char and
6010 bidi_fetch_char_advance instead of FETCH_CHAR and
6011 FETCH_CHAR_ADVANCE.
6012 (bidi_init_it): Initialize new members.
6013 (LRE_CHAR, RLE_CHAR, PDF_CHAR, LRO_CHAR, RLO_CHAR): Remove macro
6014 definitions.
6015 (bidi_explicit_dir_char): Lookup character type in bidi_type_table,
6016 instead of using explicit *_CHAR codes.
d6d100dd
SM
6017 (bidi_resolve_explicit, bidi_resolve_weak):
6018 Use FETCH_MULTIBYTE_CHAR instead of FETCH_CHAR, as reordering of
fec2107c
EZ
6019 bidirectional text is supported only in multibyte buffers.
6020 (bidi_init_it): Accept additional argument FRAME_WINDOW_P and use
6021 it to initialize the frame_window_p member of struct bidi_it.
6022 (bidi_cache_iterator_state, bidi_resolve_explicit_1)
6023 (bidi_resolve_explicit, bidi_resolve_weak)
6024 (bidi_level_of_next_char, bidi_move_to_visually_next): Abort if
6025 bidi_it->nchars is non-positive.
6026 (bidi_level_of_next_char): Don't try to lookup the cache for the
6027 next/previous character if nothing is cached there yet, or if we
6028 were just reseat()'ed to a new position.
c40e2fb2 6029
0e14fe90
EZ
6030 * xdisp.c (set_cursor_from_row): Set start and stop points
6031 according to the row's direction when priming the loop that looks
6032 for the glyph on which to display cursor.
6033 (single_display_spec_intangible_p): Function deleted.
6034 (display_prop_intangible_p): Reimplement to call
6035 handle_display_spec instead of single_display_spec_intangible_p.
d6d100dd
SM
6036 Accept 3 additional arguments needed by handle_display_spec.
6037 This fixes incorrect cursor motion across display property with complex
0e14fe90
EZ
6038 values: lists, `(when COND...)' forms, etc.
6039 (single_display_spec_string_p): Support property values that are
6040 lists with the argument STRING its top-level element.
6041 (display_prop_string_p): Fix the condition for processing a
6042 property that is a list to be consistent with handle_display_spec.
fec2107c 6043 (handle_display_spec): New function, refactored from the
fc6f18ce
EZ
6044 last portion of handle_display_prop.
6045 (compute_display_string_pos): Accept additional argument
6046 FRAME_WINDOW_P. Call handle_display_spec to determine whether the
6047 value of a `display' property is a "replacing spec".
6048 (handle_single_display_spec): Accept 2 additional arguments BUFPOS
6049 and FRAME_WINDOW_P. If IT is NULL, don't set up the iterator from
6050 the display property, but just return a value indicating whether
6051 the display property will replace the characters it covers.
6052 (Fcurrent_bidi_paragraph_direction): Initialize the nchars and
6053 frame_window_p members of struct bidi_it.
d6d100dd
SM
6054 (compute_display_string_pos, compute_display_string_end):
6055 New functions.
fec2107c
EZ
6056 (push_it): Accept second argument POSITION, where pop_it should
6057 jump to continue iteration.
6058 (reseat_1): Initialize bidi_it.disp_pos.
fc6f18ce 6059
fec2107c
EZ
6060 * keyboard.c (adjust_point_for_property): Adjust the call to
6061 display_prop_intangible_p to its new signature.
fc6f18ce
EZ
6062
6063 * dispextern.h (struct bidi_it): New member frame_window_p.
fec2107c
EZ
6064 (bidi_init_it): Update prototypes.
6065 (display_prop_intangible_p): Update prototype.
d6d100dd
SM
6066 (compute_display_string_pos, compute_display_string_end):
6067 Declare prototypes.
fec2107c
EZ
6068 (struct bidi_it): New members nchars and disp_pos. ch_len is now
6069 EMACS_INT.
fc6f18ce 6070
40087514 60712011-06-02 Paul Eggert <eggert@cs.ucla.edu>
0de4bb68 6072
57f53182
PE
6073 Malloc failure behavior now depends on size of allocation.
6074 * alloc.c (buffer_memory_full, memory_full): New arg NBYTES.
6075 * lisp.h: Change signatures accordingly.
6076 * alloc.c, buffer.c, editfns.c, menu.c, minibuf.c, xterm.c:
6077 All callers changed. (Bug#8762)
6078
6079 * gnutls.c: Use Emacs's memory allocators.
6080 Without this change, the gnutls library would invoke malloc etc.
6081 directly, which causes problems on non-SYNC_INPUT hosts, and which
6082 runs afoul of improving memory_full behavior. (Bug#8761)
6083 (fn_gnutls_global_set_mem_functions): New macro or function pointer.
6084 (emacs_gnutls_global_init): Use it to specify xmalloc, xrealloc,
6085 xfree instead of the default malloc, realloc, free.
6086 (Fgnutls_boot): No need to check for memory allocation failure,
6087 since xmalloc does that for us.
6088
ac32cd99 6089 Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
3870d916
PE
6090 * category.c (hash_get_category_set):
6091 * ccl.c (ccl_driver):
6092 * charset.c (Fdefine_charset_internal):
6093 * charset.h (struct charset.hash_index):
6094 * composite.c (get_composition_id, gstring_lookup_cache)
6095 (composition_gstring_put_cache):
6096 * composite.h (struct composition.hash_index):
6097 * dispextern.h (struct image.hash):
6098 * fns.c (next_almost_prime, larger_vector, cmpfn_eql)
6099 (cmpfn_equal, cmpfn_user_defined, hashfn_eq, hashfn_eql)
6100 (hashfn_equal, hashfn_user_defined, make_hash_table)
6101 (maybe_resize_hash_table, hash_lookup, hash_put)
6102 (hash_remove_from_table, hash_clear, sweep_weak_table, SXHASH_COMBINE)
6103 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector)
6104 (Fsxhash, Fgethash, Fputhash, Fmaphash):
6105 * image.c (make_image, search_image_cache, lookup_image)
6106 (xpm_put_color_table_h):
6107 * lisp.h (struct Lisp_Hash_Table):
0de4bb68 6108 * minibuf.c (Ftry_completion, Fall_completions, Ftest_completion):
ac389d0c 6109 * print.c (print): Use 'EMACS_UINT' and 'EMACS_INT'
3870d916 6110 for hashes and hash indexes, instead of 'unsigned' and 'int'.
40087514
PE
6111 * alloc.c (allocate_vectorlike):
6112 Check for overflow in vector size calculations.
6113 * ccl.c (ccl_driver):
6114 Check for overflow when converting EMACS_INT to int.
0de4bb68
PE
6115 * fns.c, image.c: Remove unnecessary static decls that would otherwise
6116 need to be updated by these changes.
40087514
PE
6117 * fns.c (make_hash_table, maybe_resize_hash_table):
6118 Check for integer overflow with large hash tables.
0de4bb68
PE
6119 (make_hash_table, maybe_resize_hash_table, Fmake_hash_table):
6120 Prefer the faster XFLOAT_DATA to XFLOATINT where either will do.
6121 (SXHASH_REDUCE): New macro.
6122 (sxhash_string, sxhash_list, sxhash_vector, sxhash_bool_vector):
6123 Use it instead of discarding useful hash info with large hash values.
6124 (sxhash_float): New function.
6125 (sxhash): Use it. No more need for "& INTMASK" due to above changes.
6126 * lisp.h (FIXNUM_BITS): New macro, useful for SXHASH_REDUCE etc.
40087514
PE
6127 (MOST_NEGATIVE_FIXNUM, MOST_POSITIVE_FIXNUM, INTMASK):
6128 Rewrite to use FIXNUM_BITS, as this simplifies things.
0de4bb68
PE
6129 (next_almost_prime, larger_vector, sxhash, hash_lookup, hash_put):
6130 Adjust signatures to match updated version of code.
6131 (consing_since_gc): Now EMACS_INT, since a single hash table can
6132 use more than INT_MAX bytes.
6133
698d32e2
DN
61342011-06-01 Dan Nicolaescu <dann@ics.uci.edu>
6135
6136 Make it possible to build with GCC-4.6+ -O2 -flto.
6137
6138 * emacs.c (__malloc_initialize_hook): Mark as EXTERNALLY_VISIBLE.
6139
fd6fa53f
SM
61402011-06-01 Stefan Monnier <monnier@iro.umontreal.ca>
6141
6142 * minibuf.c (get_minibuffer, read_minibuf_unwind):
6143 Call minibuffer-inactive-mode.
6144
864db017
JB
61452011-05-31 Juanma Barranquero <lekktu@gmail.com>
6146
6147 * makefile.w32-in ($(BLD)/data.$(O), $(BLD)/editfns.$(O)):
6148 Update dependencies.
6149
2ad0baf4
DN
61502011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6151
6152 * data.c (init_data): Remove code for UTS, this system is not
6153 supported anymore.
6154
4fcc2638
DN
61552011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6156
6157 Don't force ./temacs to start in terminal mode.
6158
6159 * frame.c (make_initial_frame): Initialize faces in all cases, not
6160 only when CANNOT_DUMP is defined.
6161 * dispnew.c (init_display): Remove CANNOT_DUMP condition.
6162
c56e0fd5
DN
61632011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6164
6165 * dispnew.c (add_window_display_history): Use const for the string
6166 pointer. Remove declaration, not needed.
6167
333d54da 61682011-05-31 Paul Eggert <eggert@cs.ucla.edu>
9cf9f756 6169
55d4c1b2 6170 Use 'inline', not 'INLINE'.
333d54da 6171 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00914.html>
55d4c1b2
PE
6172 * alloc.c, fontset.c (INLINE): Remove.
6173 * alloc.c, bidi.c, charset.c, coding.c, dispnew.c, fns.c, image.c:
6174 * intervals.c, keyboard.c, process.c, syntax.c, textprop.c, w32term.c:
6175 * xdisp.c, xfaces.c, xterm.c: Replace all uses of INLINE with inline.
6176 * gmalloc.c (register_heapinfo): Use inline unconditionally.
6177 * lisp.h (LISP_MAKE_RVALUE): Use inline, not __inline__.
6178
738db178
DN
61792011-05-31 Dan Nicolaescu <dann@ics.uci.edu>
6180
6181 Make it possible to run ./temacs.
6182
6183 * callproc.c (set_initial_environment): Remove CANNOT_DUMP code,
6184 syms_of_callproc does the same thing. Remove test for
6185 "initialized", do it in the caller.
6186 * emacs.c (main): Avoid calling set_initial_environment when dumping.
6187
620c53a6
SM
61882011-05-31 Stefan Monnier <monnier@iro.umontreal.ca>
6189
6190 * minibuf.c (Finternal_complete_buffer): Return `category' metadata.
6191 (read_minibuf): Use get_minibuffer.
6192 (syms_of_minibuf): Use DEFSYM.
6193 (Qmetadata): New var.
6194 * data.c (Qbuffer): Don't make it static.
6195 (syms_of_data): Use DEFSYM.
6196
e003a292
PE
61972011-05-31 Paul Eggert <eggert@cs.ucla.edu>
6198
6199 * ccl.c (CCL_CODE_RANGE): Allow negative numbers. (Bug#8751)
6200 (CCL_CODE_MIN): New macro.
6201
ed008a6d
PE
62022011-05-30 Paul Eggert <eggert@cs.ucla.edu>
6203
3687c2ef
PE
6204 * alloc.c (lisp_align_malloc): Omit unnecessary val==NULL tests.
6205
ed008a6d
PE
6206 * eval.c (Qdebug): Now static.
6207 * lisp.h (Qdebug): Remove decl. This reverts a part of the
6208 2011-04-26T11:26:05Z!dan.colascione@gmail.com that inadvertently undid part of
6209 2011-04-14T06:48:41Z!eggert@cs.ucla.edu.
6210
d66c4c7c
CY
62112011-05-29 Chong Yidong <cyd@stupidchicken.com>
6212
6213 * image.c: Various fixes to ImageMagick code comments.
6214 (Fimagemagick_types): Doc fix.
6215
5fbc2025
PE
62162011-05-29 Paul Eggert <eggert@cs.ucla.edu>
6217
0196f88a
PE
6218 Minor fixes prompted by GCC 4.6.0 warnings.
6219
6220 * xselect.c (converted_selections, conversion_fail_tag): Now static.
6221
5fbc2025
PE
6222 * emacs.c [HAVE_X_WINDOWS]: Include "xterm.h".
6223 (x_clipboard_manager_save_all): Move extern decl to ...
6224 * xterm.h: ... here, so that it can be checked for consistency.
6225
1dd3c2d9
CY
62262011-05-29 Chong Yidong <cyd@stupidchicken.com>
6227
6228 * xselect.c (x_clipboard_manager_save_frame)
6229 (x_clipboard_manager_save_all): New functions.
6230 (Fx_clipboard_manager_save): Lisp function deleted.
6231
6232 * emacs.c (Fkill_emacs): Call x_clipboard_manager_save_all.
6233 * frame.c (delete_frame): Call x_clipboard_manager_save_frame.
6234
6235 * xterm.h: Update prototype.
6236
5ba6571d
WX
62372011-05-28 William Xu <william.xwl@gmail.com>
6238
6239 * nsterm.m (ns_term_shutdown): Synchronize user defaults before
6240 exiting (Bug#8239).
6241
3eaff834
JM
62422011-05-28 Jim Meyering <meyering@redhat.com>
6243
e1900994 6244 Avoid a sign-extension bug in crypto_hash_function.
3eaff834
JM
6245 * fns.c (to_uchar): Define.
6246 (crypto_hash_function): Use it to convert some newly-signed
6247 variables to unsigned, to avoid sign-extension bugs. For example,
6248 without this change, (md5 "truc") would evaluate to
6249 45723a2aff78ff4fff7fff1114760e62 rather than the expected
6250 45723a2af3788c4ff17f8d1114760e62. Reported by Antoine Levitt in
e1900994 6251 https://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00883.html.
3eaff834 6252
0f6990a7
PE
62532011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6254
6255 Integer overflow fixes.
c8a9ca5a 6256
08686060
PE
6257 * dbusbind.c: Serial number integer overflow fixes.
6258 (CHECK_DBUS_SERIAL_GET_SERIAL): New macro.
08686060
PE
6259 (Fdbus_call_method_asynchronously, xd_read_message_1): Use a float
6260 to hold a serial number that is too large for a fixnum.
6261 (Fdbus_method_return_internal, Fdbus_method_error_internal):
6262 Check for serial numbers out of range. Decode any serial number
59568bf0 6263 that was so large that it became a float. (Bug#8722)
08686060 6264
2d1fc3c7
PE
6265 * dbusbind.c: Use XFASTINT rather than XUINT, and check for nonneg.
6266 (Fdbus_call_method, Fdbus_call_method_asynchronously):
6267 Use XFASTINT rather than XUINT when numbers are nonnegative.
6268 (xd_append_arg, Fdbus_method_return_internal):
6269 (Fdbus_method_error_internal): Likewise. Also, for unsigned
6270 arguments, check that Lisp number is nonnegative, rather than
59568bf0 6271 silently wrapping negative numbers around. (Bug#8722)
30217ff0 6272 (xd_read_message_1): Don't assume dbus_uint32_t can fit in int.
59568bf0 6273 (Bug#8722)
2d1fc3c7 6274
c8a9ca5a
PE
6275 * data.c (arith_driver, Flsh): Avoid unnecessary casts to EMACS_UINT.
6276
519e1d69
PE
6277 * ccl.c (ccl_driver): Redo slightly to avoid the need for 'unsigned'.
6278
6df6ae42 6279 ccl: Add integer overflow checks.
30569699
PE
6280 * ccl.c (CCL_CODE_MAX, GET_CCL_RANGE, GET_CCL_CODE, GET_CCL_INT):
6281 (IN_INT_RANGE): New macros.
6282 (ccl_driver): Use them to check for integer overflow when
6283 decoding a CCL program. Many of the new checks are whether XINT (x)
6284 fits in int; it doesn't always, on 64-bit hosts. The new version
6285 doesn't catch all possible integer overflows, but it's an
847044ea 6286 improvement. (Bug#8719)
30569699 6287
c11285dc
PE
6288 * alloc.c (make_event_array): Use XINT, not XUINT.
6289 There's no need for unsigned here.
6290
fdccd48e
PE
6291 * mem-limits.h (EXCEEDS_LISP_PTR) [!USE_LSB_TAG]: EMACS_UINT -> uintptr_t
6292 This follows up to the 2011-05-06 change that substituted uintptr_t
6293 for EMACS_INT. This case wasn't caught back then.
6294
37910ab2
PE
6295 Rework Fformat to avoid integer overflow issues.
6296 * editfns.c: Include <float.h> unconditionally, as it's everywhere
6297 now (part of C89). Include <verify.h>.
6298 (MAX_10_EXP, CONVERTED_BYTE_SIZE): Remove; no longer needed.
6299 (pWIDE, pWIDElen, signed_wide, unsigned_wide): New defns.
6300 (Fformat): Avoid the prepass trying to compute sizes; it was only
6301 approximate and thus did not catch overflow reliably. Instead, walk
6302 through the format just once, formatting and computing sizes as we go,
6303 checking for integer overflow at every step, and allocating a larger
6304 buffer as needed. Keep track separately whether the format is
6305 multibyte. Keep only the most-recently calculated precision, rather
6306 than them all. Record whether each argument has been converted to
6307 string. Use EMACS_INT, not int, for byte and char and arg counts.
6308 Support field widths and precisions larger than INT_MAX. Avoid
6309 sprintf's undefined behavior with conversion specifications such as %#d
6310 and %.0c. Fix bug with strchr succeeding on '\0' when looking for
6311 flags. Fix bug with (format "%c" 256.0). Avoid integer overflow when
6312 formatting out-of-range floating point numbers with int
9173deec 6313 formats. (Bug#8668)
37910ab2 6314
2e6578fb
PE
6315 * lisp.h (FIXNUM_OVERFLOW_P): Work even if arg is a NaN.
6316
0ae6bdee
PE
6317 * data.c: Avoid integer truncation in expressions involving floats.
6318 * data.c: Include <intprops.h>.
6319 (arith_driver): When there's an integer overflow in an expression
6320 involving floating point, convert the integers to floating point
6321 so that the resulting value does not suffer from catastrophic
6322 integer truncation. For example, on a 64-bit host (* 4
6323 most-negative-fixnum 0.5) should yield about -4.6e+18, not zero.
6324 Do not rely on undefined behavior after integer overflow.
6325
de883a70
PE
6326 merge count_size_as_multibyte, parse_str_to_multibyte
6327 * character.c, character.h (count_size_as_multibyte):
fd6fa53f 6328 Rename from parse_str_to_multibyte; all uses changed.
de883a70
PE
6329 Check for integer overflow.
6330 * insdel.c, lisp.h (count_size_as_multibyte): Remove,
6331 since it's now a duplicate of the other. This is more of
6332 a character than a buffer op, so better that it's in character.c.
6333 * fns.c, print.c: Adjust to above changes.
6334
2ff916cb
PE
63352011-05-27 Stefan Monnier <monnier@iro.umontreal.ca>
6336
6337 * xselect.c (x_convert_selection): Yet another int/Lisp_Object mixup.
6338
f1b54466
PE
63392011-05-27 Paul Eggert <eggert@cs.ucla.edu>
6340
fb1ac845
PE
6341 * xselect.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6342 (x_handle_selection_request, frame_for_x_selection): Remove unused vars.
6343 (x_clipboard_manager_save): Now static.
6344 (Fx_clipboard_manager_save): Rename local to avoid shadowing.
6345
f1b54466
PE
6346 * fns.c: Fix minor problems prompted by GCC 4.6.0 warnings.
6347 (crypto_hash_function): Now static.
6348 Fix pointer signedness problems. Avoid unnecessary initializations.
6349
a9f737ee
CY
63502011-05-27 Chong Yidong <cyd@stupidchicken.com>
6351
6352 * termhooks.h (Vselection_alist): Make it terminal-local.
6353
6354 * terminal.c (create_terminal): Initialize it.
6355
6356 * xselect.c: Support for clipboard managers.
6357 (Vselection_alist): Move to termhooks.h as terminal-local var.
6358 (LOCAL_SELECTION): New macro.
6359 (x_atom_to_symbol): Handle x_display_info_for_display fail case.
6360 (symbol_to_x_atom): Remove gratuitous arg.
6361 (x_handle_selection_request, lisp_data_to_selection_data)
6362 (x_get_foreign_selection, Fx_register_dnd_atom): Callers changed.
620c53a6
SM
6363 (x_own_selection, x_get_local_selection, x_convert_selection):
6364 New arg, specifying work frame. Use terminal-local Vselection_alist.
a9f737ee
CY
6365 (some_frame_on_display): Delete unused function.
6366 (Fx_own_selection_internal, Fx_get_selection_internal)
6367 (Fx_disown_selection_internal, Fx_selection_owner_p)
6368 (Fx_selection_exists_p): New optional frame arg.
6369 (frame_for_x_selection, Fx_clipboard_manager_save): New functions.
6370 (x_handle_selection_clear): Don't treat other terminals with the
6371 same keyboard specially. Use the terminal-local Vselection_alist.
6372 (x_clear_frame_selections): Use Frun_hook_with_args.
6373
6374 * xterm.c (x_term_init): Intern ATOM and CLIPBOARD_MANAGER atoms.
6375
6376 * xterm.h: Add support for those atoms.
6377
e067f0c1
CY
63782011-05-26 Chong Yidong <cyd@stupidchicken.com>
6379
6380 * xselect.c: ICCCM-compliant handling of MULTIPLE targets.
6381 (converted_selections, conversion_fail_tag): New global variables.
6382 (x_selection_request_lisp_error): Free the above.
6383 (x_get_local_selection): Remove unnecessary code.
6384 (x_reply_selection_request): Args changed; handle arbitrary array
620c53a6
SM
6385 of converted selections stored in converted_selections.
6386 Separate the XChangeProperty and SelectionNotify steps.
e067f0c1
CY
6387 (x_handle_selection_request): Rewrite to handle MULTIPLE target.
6388 (x_convert_selection): New function.
6389 (x_handle_selection_event): Simplify.
6390 (x_get_foreign_selection): Don't ignore incoming requests while
6391 waiting for an answer; this will fail when we implement
6392 SAVE_TARGETS, and seems unnecessary anyway.
6393 (selection_data_to_lisp_data): Recognize ATOM_PAIR type.
6394 (Vx_sent_selection_functions): Doc fix.
6395
0f4aebc0
LL
63962011-05-26 Leo Liu <sdl.web@gmail.com>
6397
6398 * editfns.c (Ftranspose_regions): Allow empty regions. (Bug#8699)
6399
e61124cd
YM
64002011-05-25 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6401
6402 * dispextern.h (struct glyph_row): New member fringe_bitmap_periodic_p.
6403
6404 * dispnew.c (shift_glyph_matrix, scrolling_window): Mark scrolled row
6405 for fringe update if it has periodic bitmap.
ac389d0c 6406 (row_equal_p): Also compare left_fringe_offset, right_fringe_offset,
e61124cd
YM
6407 and fringe_bitmap_periodic_p.
6408
6409 * fringe.c (get_fringe_bitmap_data): New function.
6410 (draw_fringe_bitmap_1, update_window_fringes): Use it.
6411 (update_window_fringes): Record periodicity of fringe bitmap in glyph
6412 row. Mark glyph row for fringe update if periodicity changed.
6413
6414 * xdisp.c (try_window_reusing_current_matrix): Don't mark scrolled row
6415 for fringe update unless it has periodic bitmap.
6416
f16d9837
KH
64172011-05-25 Kenichi Handa <handa@m17n.org>
6418
6419 * xdisp.c (get_next_display_element): Set correct it->face_id for
6420 a static composition.
6421
e1b90ef6
LL
64222011-05-24 Leo Liu <sdl.web@gmail.com>
6423
6424 * deps.mk (fns.o):
6425 * makefile.w32-in ($(BLD)/fns.$(O)): Include sha1.h.
6426
6427 * fns.c (crypto_hash_function, Fsha1): New function.
6428 (Fmd5): Use crypto_hash_function.
6429 (syms_of_fns): Add Ssha1.
6430
7400048f
PE
64312011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6432
6433 * gnutls.c: Remove unused macros.
6434 (fn_gnutls_transport_set_lowat, fn_gnutls_transport_set_pull_function):
6435 (fn_gnutls_transport_set_push_function) [!WINDOWSNT]:
6436 Remove macros that are defined and never used.
6437 Caught by gcc -Wunused-macros (GCC 4.6.0, Fedora 14).
6438
abb71cf4
CY
64392011-05-22 Chong Yidong <cyd@stupidchicken.com>
6440
6441 * xselect.c (syms_of_xselect): Remove unused symbol SAVE_TARGETS.
6442 (Fx_get_selection_internal): Minor cleanup.
6443 (Fx_own_selection_internal): Rename arguments for consistency with
6444 select.el.
6445
6307db39
PE
64462011-05-22 Paul Eggert <eggert@cs.ucla.edu>
6447
6448 * xselect.c (QSAVE_TARGETS): New static var, to fix build failure.
6449
f3d4e0a4
CY
64502011-05-22 Chong Yidong <cyd@stupidchicken.com>
6451
6452 * xselect.c (syms_of_xselect): Include character.h; use DEFSYM.
6453
4d8ade89
YM
64542011-05-21 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
6455
6456 * dispnew.c (scrolling_window): Don't exclude the case that the
6457 last enabled row in the desired matrix touches the bottom boundary.
6458
32078c8d
GM
64592011-05-21 Glenn Morris <rgm@gnu.org>
6460
6461 * Makefile.in ($(etc)/DOC): Make second command line even shorter.
33cf345f
GM
6462 (SOME_MACHINE_OBJECTS): Replace FONT_OBJ by its maximal expansion,
6463 and add some more files.
32078c8d 6464
7285dc67
EZ
64652011-05-20 Eli Zaretskii <eliz@gnu.org>
6466
6467 * callproc.c (Fcall_process) [MSDOS]: Fix arguments to
6468 report_file_error introduced by the change from 2011-05-07.
6469
89d1bd22
PE
64702011-05-20 Paul Eggert <eggert@cs.ucla.edu>
6471
6472 * systime.h (Time): Define only if emacs is defined.
6473 This is to allow ../lib-src/profile.c to be compiled on FreeBSD,
6474 where the include path doesn't have X11/X.h by default. See
6475 <http://lists.gnu.org/archive/html/emacs-devel/2011-05/msg00561.html>.
6476
cd394be1 64772011-05-20 Kenichi Handa <handa@m17n.org>
31bfc35c
KH
6478
6479 * composite.c (find_automatic_composition): Fix previous change.
6480
b9704ad9
GM
64812011-05-20 Glenn Morris <rgm@gnu.org>
6482
6483 * lisp.mk: New file, split from Makefile.in.
6484 * Makefile.in (lisp): Move to separate file, inserted by @lisp_frag@.
6485 (shortlisp): Remove.
6486 ($(etc)/DOC): Edit lisp.mk rather than using $shortlisp.
6487
4a720484
GM
64882011-05-19 Glenn Morris <rgm@gnu.org>
6489
6490 * Makefile.in (MSDOS_SUPPORT_REAL, MSDOS_SUPPORT, NS_SUPPORT)
6491 (REAL_MOUSE_SUPPORT, GPM_MOUSE_SUPPORT, MOUSE_SUPPORT, TOOLTIP_SUPPORT)
6492 (BASE_WINDOW_SUPPORT, X_WINDOW_SUPPORT, WINDOW_SUPPORT): Remove.
6493 (lisp): Set the order to that of loadup.el.
6494 (shortlisp): Make it a copy of $lisp.
6495 (SOME_MACHINE_LISP): Remove.
6496 ($(etc)/DOC): Depend just on $lisp, not $SOME_MACHINE_LISP too.
6497 Use just $shortlisp, not $SOME_MACHINE_LISP too.
6498
a28d4396
KH
64992011-05-18 Kenichi Handa <handa@m17n.org>
6500
6501 * composite.c (CHAR_COMPOSABLE_P): Add more check for efficiency.
6502 (BACKWARD_CHAR): Wrap the arg STOP by parenthesis.
6503 (find_automatic_composition): Mostly rewrite for efficiency.
6504
a2b1fa8e
JB
65052011-05-18 Juanma Barranquero <lekktu@gmail.com>
6506
6507 * makefile.w32-in: Update dependencies.
6508
8e1f5610
CS
65092011-05-18 Christoph Scholtes <cschol2112@googlemail.com>
6510
6511 * menu.c: Include limits.h (fixes the MS-Windows build broken by
7d7d0045 6512 2011-06-18T18:49:19Z!cyd@stupidchicken.com).
8e1f5610 6513
7025ee00 65142011-05-18 Paul Eggert <eggert@cs.ucla.edu>
cb93f9be 6515
cdfa6eab
PE
6516 Fix some integer overflow issues, such as string length overflow.
6517
06d6db33
PE
6518 * insdel.c (count_size_as_multibyte): Check for string overflow.
6519
2b4560a8
PE
6520 * character.c (lisp_string_width): Check for string overflow.
6521 Use EMACS_INT, not int, for string indexes and lengths; in
6522 particular, 2nd arg is now EMACS_INT, not int. Do not crash if
6523 the resulting string length overflows an EMACS_INT; instead,
6524 report a string overflow if no precision given. When checking for
6525 precision exhaustion, use a check that cannot possibly have
6526 integer overflow. (Bug#8675)
6527 * character.h (lisp_string_width): Adjust to new signature.
6528
cb93f9be
PE
6529 * alloc.c (string_overflow): New function.
6530 (Fmake_string): Use it. This doesn't change behavior, but saves
6531 a few bytes and will simplify future changes.
6532 * character.c (string_escape_byte8): Likewise.
6533 * lisp.h (string_overflow): New decl.
6534
1a1f3366
PE
6535 Fixups, following up to the user-interface timestamp change.
6536 * nsterm.m (last_mouse_movement_time, ns_mouse_position): Use Time
6537 for UI timestamps, instead of unsigned long.
9fbd6841
PE
6538 * msdos.c (mouse_get_pos): Likewise.
6539 * w32inevt.c (movement_time, w32_console_mouse_position): Likewise.
1a1f3366
PE
6540 * w32gui.h (Time): Define by including "systime.h" rather than by
6541 declaring it ourselves. (Bug#8664)
6542
d4e3e4d3
PE
6543 * dispextern.h (struct image): Don't assume time_t <= unsigned long.
6544 * image.c (clear_image_cache): Likewise.
6545
f6a24d19
PE
6546 * term.c (term_mouse_position): Don't assume time_t wraparound.
6547
08dc5ae6
PE
6548 Be more systematic about user-interface timestamps.
6549 Before, the code sometimes used 'Time', sometimes 'unsigned long',
620c53a6
SM
6550 and sometimes 'EMACS_UINT', to represent these timestamps.
6551 This change causes it to use 'Time' uniformly, as that's what X uses.
08dc5ae6
PE
6552 This makes the code easier to follow, and makes it easier to catch
6553 integer overflow bugs such as Bug#8664.
6554 * frame.c (Fmouse_position, Fmouse_pixel_position):
6555 Use Time, not unsigned long, for user-interface timestamps.
6556 * keyboard.c (last_event_timestamp, kbd_buffer_get_event): Likewise.
6557 (button_down_time, make_lispy_position, make_lispy_movement): Likewise.
6558 * keyboard.h (last_event_timestamp): Likewise.
6559 * menu.c (Fx_popup_menu) [!HAVE_X_WINDOWS]: Likewise.
6560 * menu.h (xmenu_show): Likewise.
6561 * term.c (term_mouse_position): Likewise.
6562 * termhooks.h (struct input_event.timestamp): Likewise.
6563 (struct terminal.mouse_position_hook): Likewise.
6564 * xmenu.c (create_and_show_popup_menu, xmenu_show): Likewise.
6565 * xterm.c (XTmouse_position, x_scroll_bar_report_motion): Likewise.
6566 * systime.h (Time): New decl. Pull it in from <X11/X.h> if
6567 HAVE_X_WINDOWS, otherwise define it as unsigned long, which is
6568 what it was before.
6569 * menu.h, termhooks.h: Include "systime.h", for Time.
6570
8e55734a
PE
6571 * keyboard.c (make_lispy_event): Fix problem in integer overflow.
6572 Don't assume that the difference between two unsigned long values
6573 can fit into an integer. At this point, we know button_down_time
6574 <= event->timestamp, so the difference must be nonnegative, so
6575 there's no need to cast the result if double-click-time is
6576 nonnegative, as it should be; check that it's nonnegative, just in
6577 case. This bug is triggered when events are more than 2**31 ms
86db42d2 6578 apart (about 25 days). (Bug#8664)
8e55734a 6579
841f1b75 6580 * xselect.c (last_event_timestamp): Remove duplicate decl.
6434756c 6581 (x_own_selection): Remove needless cast to unsigned long.
841f1b75 6582
3e26f69c
PE
6583 * xmenu.c (set_frame_menubar): Use int, not EMACS_UINT, for indexes
6584 that always fit in int. Use a sentinel instead of a counter, to
6585 avoid a temp and to allay GCC's concerns about possible int overflow.
d230cb74
PE
6586 * frame.h (struct frame): Use int for menu_bar_items_used
6587 instead of EMACS_INT, since it always fits in int.
3e26f69c 6588
5cc152c0
PE
6589 * menu.c (grow_menu_items): Check for int overflow.
6590
d89eb65e
PE
6591 * xmenu.c (set_frame_menubar): Don't mishandle vectors with no nils.
6592
5235bd3e
PE
6593 * xterm.c: Use EMACS_INT for Emacs modifiers, and int for X modifiers.
6594 Before, the code was not consistent. These values cannot exceed
6595 2**31 - 1 so there's no need to make them unsigned.
6596 (x_x_to_emacs_modifiers): Accept int and return EMACS_INT.
6597 (x_emacs_to_x_modifiers): Accept EMACS_INT and return int.
6598 (x_x_to_emacs_modifiers, x_emacs_to_x_modifiers): Reject non-integers
6599 as modifiers.
6600 * xterm.h (x_x_to_emacs_modifiers): Adjust to signature change.
6601
bc827e23
PE
6602 * lisp.h (XINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_INT.
6603 (XUINT) [USE_LISP_UNION_TYPE]: Cast to EMACS_UINT.
6604 Otherwise, GCC 4.6.0 warns about printf (pI, XINT (...)),
6605 presumably because the widths might not match.
6606
78eb494e
PE
6607 * window.c (size_window): Avoid needless test at loop start.
6608
04f2d78b
CB
66092011-05-18 Courtney Bane <emacs-bugs-7626@cbane.org> (tiny change)
6610
6611 * term.c (Fresume_tty): Restore hooks before reinitializing (bug#8687).
6612
d2fc7e3d 66132011-05-12 Drew Adams <drew.adams@oracle.com>
e531bdff
DA
6614
6615 * textprop.c (Fprevious_single_char_property_change): Doc fix (bug#8655).
6616
d2fc7e3d 66172011-05-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
7db47798
YM
6618
6619 * w32term.c (w32_draw_fringe_bitmap): Rename local vars `left' and
6620 `width' to `bar_area_x' and `bar_area_width', respectively.
6621 (x_scroll_run): Take account of fringe background extension.
6622
04f2d78b
CB
6623 * xterm.c (x_draw_fringe_bitmap) [USE_TOOLKIT_SCROLL_BARS]:
6624 Rename local vars `left' and `width' to `bar_area_x' and
7db47798
YM
6625 `bar_area_width', respectively.
6626 (x_scroll_run) [USE_TOOLKIT_SCROLL_BARS]: Take account of fringe
6627 background extension.
6628
79b70037
GM
66292011-05-10 Jim Meyering <meyering@redhat.com>
6630
6631 * xdisp.c (x_intersect_rectangles): Fix typo "the the -> the".
6632
2f142cc5
JB
66332011-05-10 Juanma Barranquero <lekktu@gmail.com>
6634
6635 * image.c (Finit_image_library): Return t for built-in image types,
6636 like pbm and xbm. (Bug#8640)
6637
57679c86
AS
66382011-05-09 Andreas Schwab <schwab@linux-m68k.org>
6639
6640 * w32menu.c (set_frame_menubar): Fix submenu allocation.
6641
888c9e86
EZ
66422011-05-07 Eli Zaretskii <eliz@gnu.org>
6643
b0512a1d
EZ
6644 * w32console.c (Fset_screen_color): Doc fix.
6645 (Fget_screen_color): New function.
6646 (syms_of_ntterm): Defsubr it.
6647
7285dc67
EZ
6648 * callproc.c (call_process_cleanup) [MSDOS]: Don't close and
6649 unlink the temporary file if Fcall_process didn't create it in the
6650 first place.
6651 (Fcall_process) [MSDOS]: Don't create tempfile if stdout of the
6652 child process will be redirected to a file specified with `:file'.
888c9e86
EZ
6653 Don't try to re-open tempfile in that case, and set fd[0] to -1 as
6654 cue to call_process_cleanup not to close that handle.
6655
4d3fcc8e
BK
66562011-05-07 Ben Key <bkey76@gmail.com>
6657
6658 * makefile.w32-in: The bootstrap-temacs rule now makes use of
6659 one of two shell specific rules, either bootstrap-temacs-CMD or
6660 bootstrap-temacs-SH. The bootstrap-temacs-SH rule is identical
6661 to the previous implementation of the bootstrap-temacs rule.
6662 The bootstrap-temacs-CMD rule is similar to the previous
6663 implementation of the bootstrap-temacs rule except that it
6664 makes use of the ESC_CFLAGS variable instead of the CFLAGS
6665 variable.
6666
6667 These changes, along with some changes to nt/configure.bat,
6668 nt/gmake.defs, and nt/nmake.defs, are required to extend my
6669 earlier fix to add support for --cflags and --ldflags options
6670 that include quotes so that it works whether make uses cmd or
6671 sh as the shell.
6672
b4289b64
MA
66732011-05-06 Michael Albinus <michael.albinus@gmx.de>
6674
6675 * dbusbind.c (QCdbus_type_unix_fd): Declare static.
6676 (xd_remove_watch): Don't check QCdbus_type_unix_fd for SYMBOLP, it
6677 is a constant.
6678 (Fdbus_init_bus, xd_read_queued_messages): Bus can be a symbol or
6679 a string. Handle both cases.
6680 (Fdbus_call_method_asynchronously, Fdbus_register_signal)
6681 (Fdbus_register_method): Use Qinvalid_function.
6682
af4c0e28
JB
66832011-05-06 Juanma Barranquero <lekktu@gmail.com>
6684
6685 * makefile.w32-in: Update dependencies.
6686 (LISP_H): Add inttypes.h and stdin.h.
6687 (PROCESS_H): Add unistd.h.
6688
c51453d9
EZ
66892011-05-06 Eli Zaretskii <eliz@gnu.org>
6690
6691 * lread.c: Include limits.h (fixes the MS-Windows build broken by
6692 2011-05-06T07:13:19Z!eggert@cs.ucla.edu).
6693
8ff0ac3c 66942011-05-06 Paul Eggert <eggert@cs.ucla.edu>
c032b5f8 6695
4c4b566b
PE
6696 * image.c (Finit_image_library) [!HAVE_NTGUI]: Omit unused local.
6697
aab2b9b5
PE
6698 * term.c (vfatal): Remove stray call to va_end.
6699 It's not needed and the C Standard doesn't allow it here anyway.
6700
c378da0b
PE
6701 Use C99's va_copy to avoid undefined behavior on x86-64 GNU/Linux.
6702 * eval.c (verror): doprnt a copy of ap, not the original. (Bug#8545)
6703
288b08c7
PE
6704 * eval.c (verror): OK to create a string of up to MOST_POSITIVE_FIXNUM
6705 bytes.
6706
e3601888
PE
6707 * term.c: Don't include <stdarg.h>, as <lisp.h> does that.
6708
db6c0e74
PE
6709 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork clobbering.
6710
dd5963ea
PE
6711 * process.c (Fformat_network_address): Fix typo: args2 -> *args2.
6712
88c9450f
PE
6713 * xmenu.c (set_frame_menubar): Fix typo: int * -> int (3 times).
6714
2f9442b8
PE
6715 * coding.c (detect_coding_charset): Fix typo: * 2 -> *4 (Bug#8601).
6716
c032b5f8
PE
6717 * charset.h (struct charset.code_space): Now has 15 elements, not 16.
6718 * charset.c (Fdefine_charset_internal): Don't initialize
6719 charset.code_space[15]. The value was garbage, on hosts with
2d38271b 6720 32-bit int (Bug#8600).
a108c10b
PE
6721
6722 * lread.c (read_integer): Be more consistent with string-to-number.
6723 Use string_to_number to do the actual conversion; this avoids
6724 rounding errors and fixes some other screwups. Without this fix,
6725 for example, #x1fffffffffffffff was misread as -2305843009213693952.
6726 (digit_to_number): Move earlier, for benefit of read_integer.
6727 Return -1 if the digit is out of range for the base, -2 if it is
48e400f0 6728 not a digit in any supported base. (Bug#8602)
a108c10b 6729
ad5f9eea
PE
6730 * doprnt.c (doprnt): Support arbitrary pI values, such as "I64".
6731
aec1708a
PE
6732 * dispnew.c (scrolling_window): Return 1 if we scrolled,
6733 to match comment at start of function. This also removes a
6734 GCC warning about overflow in a 32+64-bit port.
6735
47be4ab5
PE
6736 * lisp.h (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Simplify.
6737
371cac43
PE
6738 * dbusbind.c: Do not use XPNTR on a value that may be an integer.
6739 Reported by Stefan Monnier in
6740 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00919.html>.
04f2d78b
CB
6741 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6742 Use SYMBOLP-guarded XSYMBOL, not XPNTR.
371cac43 6743
d01a7826
PE
6744 * lisp.h (EMACS_INTPTR): Remove. All uses changed to intptr_t.
6745 (EMACS_UINTPTR): Likewise, with uintptr_t.
6746
7fd47d5c
PE
6747 * lisp.h: Prefer 64-bit EMACS_INT if available.
6748 (EMACS_INT, EMACS_UINT, BITS_PER_EMACS_INT, pI): Define to 64-bit
6749 on 32-bit hosts that have 64-bit int, so that they can access
6750 large files.
122b0c86
PE
6751 However, temporarily disable this change unless the temporary
6752 symbol WIDE_EMACS_INT is defined.
7fd47d5c 6753
8727937b
PE
6754 * lread.c, process.c: Do not include <inttypes.h>; lisp.h does it now.
6755
8ac068ac
PE
6756 Prefer intptr_t/uintptr_t for integers the same widths as pointers.
6757 This removes an assumption that EMACS_INT and long are the same
6758 width as pointers. The assumption is true for Emacs porting targets
6759 now, but we want to make other targets possible.
6760 * lisp.h: Include <inttypes.h>, for INTPTR_MAX, UINTPTR_MAX.
6761 (EMACS_INTPTR, EMACS_UINTPTR): New macros.
6762 In the rest of the code, change types of integers that hold casted
6763 pointers to EMACS_INTPTR and EMACS_UINTPTR, systematically
6764 replacing EMACS_INT, long, EMACS_UINT, and unsigned long.
6765 (XTYPE): Don't cast arg to EMACS_UINT; normally is not needed.
6766 (XSET): Cast type of XTYPE arg to EMACS_INTPTR; it is needed here.
6767 No need to cast type when ORing.
6768 (XPNTR): Return a value of type EMACS_INTPTR or EMACS_UINTPTR.
6769 * alloc.c (lisp_align_malloc): Remove a no-longer-needed cast.
6770 * doc.c (store_function_docstring): Use EMACS_INTPTR, so as not to
6771 assume EMACS_INT is the same width as char *.
6772 * gtkutil.c (xg_gtk_scroll_destroy, xg_tool_bar_button_cb):
6773 (xg_tool_bar_callback, xg_tool_bar_help_callback, xg_make_tool_item):
6774 Remove no-longer-needed casts.
6775 (xg_create_scroll_bar, xg_tool_bar_button_cb, xg_tool_bar_callback):
6776 (xg_tool_bar_help_callback, xg_make_tool_item):
6777 Use EMACS_INTPTR to hold an integer
6778 that will be cast to void *; this can avoid a GCC warning
6779 if EMACS_INT is not the same width as void *.
6780 * menu.c (find_and_call_menu_selection): Remove no-longer-needed cast.
6781 * xdisp.c (display_echo_area_1, resize_mini_window_1):
6782 (current_message_1, set_message_1):
6783 Use a local to convert to proper width without a cast.
6784 * xmenu.c (dialog_selection_callback): Likewise.
6785
ede49d71
PE
6786 * sysdep.c (get_random): Don't assume EMACS_INT is no wider than long.
6787 Also, don't assume VALBITS / RAND_BITS is less than 5,
6788 and don't rely on undefined behavior when shifting a 1 left into
6789 the sign bit.
6790 * lisp.h (get_random): Change signature to match.
6791
2f30ecd0
PE
6792 * lread.c (hash_string): Use size_t, not int, for hash computation.
6793 Normally we prefer signed values; but hashing is special, because
6794 it's better to use unsigned division on hash table sizes so that
6795 the remainder is nonnegative. Also, size_t is the natural width
6796 for hashing into memory. The previous code used 'int', which doesn't
6797 retain enough info to hash well into very large tables.
6798 (oblookup, oblookup_last_bucket_number, Funintern): Likewise.
6799
2a866e7b
PE
6800 * dbusbind.c: Don't possibly lose pointer info when converting.
6801 (xd_remove_watch, Fdbus_init_bus, xd_read_queued_messages):
6802 Use XPNTR rather than XHASH, so that the high-order bits of
6803 the pointer aren't lost when converting through void *.
6804
51639eac
PE
6805 * eval.c (Fautoload): Don't double-shift a pointer.
6806
92394119
PE
6807 * fns.c (Frandom): Let EMACS_UINT be wider than unsigned long.
6808
dbdb9a7c
JB
68092011-05-06 Juanma Barranquero <lekktu@gmail.com>
6810
6811 * gnutls.c (DEF_GNUTLS_FN):
6812 * image.c (DEF_IMGLIB_FN): Make function pointers static.
6813
db7a0b4f
AS
68142011-05-05 Andreas Schwab <schwab@linux-m68k.org>
6815
6816 * lread.c (lisp_file_lexically_bound_p): Stop scanning at end
6817 marker. (Bug#8610)
6818
cd394be1 68192011-05-05 Eli Zaretskii <eliz@gnu.org>
fab624aa
EZ
6820
6821 * w32heap.c (allocate_heap) [USE_LISP_UNION_TYPE || USE_LSB_TAG]:
6822 New version that can reserve upto 2GB of heap space.
6823
f7ff1b0f 68242011-05-05 Chong Yidong <cyd@stupidchicken.com>
45cb8994
CY
6825
6826 * nsfns.m (Fns_read_file_name): Doc fix (Bug#8534).
6827
639c109b
TZ
68282011-05-05 Teodor Zlatanov <tzz@lifelogs.com>
6829
6830 * gnutls.c (fn_gnutls_certificate_set_x509_key_file): Add alias to
6831 `gnutls_certificate_set_x509_key_file'.
6832
d2127135
JB
68332011-05-05 Juanma Barranquero <lekktu@gmail.com>
6834
6835 * makefile.w32-in ($(BLD)/image.$(O), $(BLD)/process.$(O)):
6836 Update dependencies.
6837
e968f4f3
JB
68382011-05-04 Juanma Barranquero <lekktu@gmail.com>
6839
6840 * gnutls.h (emacs_gnutls_write, emacs_gnutls_read):
6841 * gnutls.c (emacs_gnutls_write, emacs_gnutls_read):
6842 Remove unused parameter `fildes'.
6843 * process.c (read_process_output, send_process): Don't pass it.
6844
84d358f0
JB
68452011-05-04 Juanma Barranquero <lekktu@gmail.com>
6846
6847 Fix previous change: the library cache is defined in w32.c.
6848 * image.c (CACHE_IMAGE_TYPE) [!HAVE_NTGUI]: Define to noop.
6849 (Finit_image_library): Wrap Vlibrary_cache on "#ifdef HAVE_NTGUI".
6850
0898ca10
JB
68512011-05-04 Juanma Barranquero <lekktu@gmail.com>
6852
6853 Implement dynamic loading of GnuTLS on Windows.
6854
6855 * gnutls.h (GNUTLS_EMACS_ERROR_NOT_LOADED): New macro.
6856 (emacs_gnutls_write, emacs_gnutls_read): Mark as extern.
6857 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6858 Declare.
6859
6860 * gnutls.c (Qgnutls_dll): Define.
6861 (DEF_GNUTLS_FN, LOAD_GNUTLS_FN): New macros.
6862 (gnutls_*): Declare function pointers.
6863 (init_gnutls_functions): New function to initialize function pointers.
6864 (emacs_gnutls_handshake, Fgnutls_error_string, Fgnutls_deinit)
6865 (emacs_gnutls_global_init, Fgnutls_bye): Use function pointers.
6866 (emacs_gnutls_record_check_pending, emacs_gnutls_transport_set_errno):
6867 Wrappers for gnutls_record_check_pending and gnutls_transport_set_errno.
6868 (emacs_gnutls_write, emacs_gnutls_read)
6869 (emacs_gnutls_handle_error, Fgnutls_error_fatalp)
6870 (Fgnutls_available_p): New function.
6871 (Fgnutls_boot): Call Fgnutls_available_p. Use function pointers.
6872 (syms_of_gnutls) <Qgnutls_dll>: Initialize and staticpro it.
6873 (syms_of_gnutls) <Sgnutls_available_p>: defsubr it.
6874
6875 * image.c: Include w32.h.
6876 (Vimage_type_cache): Delete.
6877 (syms_of_image) <Vimage_type_cache>: Don't initialize and staticpro it.
6878 (CACHE_IMAGE_TYPE, Finit_image_library): Use Vlibrary_cache instead.
6879 (w32_delayed_load): Move to w32.c.
6880
6881 * w32.h (VlibraryCache, QCloaded_from, w32_delayed_load): Declare.
6882
6883 * w32.c (QCloaded_from, Vlibrary_cache): Define.
6884 (w32_delayed_load): Move from image.c. When loading a library, record
6885 its filename in the :loaded-from property of the library id.
6886 (globals_of_w32) <QCloaded_from, Vlibrary_cache>:
6887 Initialize and staticpro them.
6888 (emacs_gnutls_pull, emacs_gnutls_push): Call emacs_gnutls_* functions.
6889
6890 * process.c: Include lisp.h before w32.h, not after.
6891 (wait_reading_process_output): Call emacs_gnutls_record_check_pending
6892 instead of gnutls_record_check_pending.
6893
6894 * callproc.c, emacs.c: Include lisp.h before w32.h, not after.
6895
ff4de4aa
TZ
68962011-05-04 Teodor Zlatanov <tzz@lifelogs.com>
6897
6898 * gnutls.c (Fgnutls_boot): Support :keylist and :crlfiles options
6899 instead of :keyfiles. Give GnuTLS the keylist and the CRL lists
6900 as passed in.
6901
abe95abb
JD
69022011-05-03 Jan Djärv <jan.h.d@swipnet.se>
6903
6904 * xterm.c (x_set_frame_alpha): Do not set property on anything
6905 else than FRAME_X_OUTER_WINDOW (Bug#8608).
6906
e16e55d4
JB
69072011-05-02 Juanma Barranquero <lekktu@gmail.com>
6908
6909 * sysdep.c (get_tty_size) [WINDOWSNT]: Implement. (Bug#8596)
6910
bafcf6a5
JB
69112011-05-02 Juanma Barranquero <lekktu@gmail.com>
6912
6913 * gnutls.c (Qgnutls_log_level, Qgnutls_code, Qgnutls_anon)
6914 (Qgnutls_x509pki, Qgnutls_e_interrupted, Qgnutls_e_again)
6915 (Qgnutls_e_invalid_session, Qgnutls_e_not_ready_for_handshake)
6916 (gnutls_global_initialized, Qgnutls_bootprop_priority)
6917 (Qgnutls_bootprop_trustfiles, Qgnutls_bootprop_keyfiles)
6918 (Qgnutls_bootprop_callbacks, Qgnutls_bootprop_loglevel)
6919 (Qgnutls_bootprop_hostname, Qgnutls_bootprop_verify_flags)
6920 (Qgnutls_bootprop_verify_error, Qgnutls_bootprop_verify_hostname_error)
6921 (Qgnutls_bootprop_callbacks_verify): Make static.
6922
e7a6747f
AS
69232011-05-01 Andreas Schwab <schwab@linux-m68k.org>
6924
19ed11ba
AS
6925 * callproc.c: Indentation fixup.
6926
e7a6747f 6927 * sysdep.c (wait_for_termination_1): Make static.
04f2d78b
CB
6928 (wait_for_termination, interruptible_wait_for_termination):
6929 Move after wait_for_termination_1.
e7a6747f 6930
1ef14cb4
LMI
69312011-05-01 Lars Magne Ingebrigtsen <larsi@gnus.org>
6932
6933 * sysdep.c (interruptible_wait_for_termination): New function
6934 which is like wait_for_termination, but allows keyboard
6935 interruptions.
6936
6937 * callproc.c (Fcall_process): Add (:file "file") as an option for
6938 the STDOUT buffer.
6939 (Fcall_process_region): Ditto.
6940
330d880c
EZ
69412011-04-30 Eli Zaretskii <eliz@gnu.org>
6942
8db90b73
EZ
6943 * dosfns.c (Fint86, Fdos_memget, Fdos_memput): Use `ASIZE (FOO)'
6944 rather than `XVECTOR (FOO)->size'.
6945
330d880c
EZ
6946 * process.c: Remove HAVE_INTTYPES_H condition from inclusion of
6947 inttypes.h, as a gnulib replacement is used if it not available in
6948 system headers.
6949
15cbd324
EZ
69502011-04-21 Eli Zaretskii <eliz@gnu.org>
6951
6952 Lift the MOST_POSITIVE_FIXNUM/4 limitation on visited files.
6953 * fileio.c (Finsert_file_contents): Don't limit file size to 1/4
6954 of MOST_POSITIVE_FIXNUM. (Bug#8528)
6955
6956 * coding.c (coding_alloc_by_realloc): Error out if destination
6957 will grow beyond MOST_POSITIVE_FIXNUM.
6958 (decode_coding_emacs_mule): Abort if there isn't enough place in
6959 charbuf for the composition carryover bytes. Reserve an extra
6960 space for up to 2 characters produced in a loop.
6961 (decode_coding_iso_2022): Abort if there isn't enough place in
6962 charbuf for the composition carryover bytes.
6963
69642011-04-21 Eli Zaretskii <eliz@gnu.org>
afda1437 6965
ae940cca
EZ
6966 * doprnt.c (doprnt) [!HAVE_LONG_LONG_INT]: Error out instead of
6967 aborting when %lld or %lll format is passed.
6968 [!HAVE_UNSIGNED_LONG_LONG_INT]: Error out instead of aborting when
6969 %llo or %llx format is passed. (Bug#8545)
6970
03ab8921
EZ
6971 * window.c (window_scroll_line_based): Use a marker instead of
6972 simple variables to record original value of point. (Bug#7952)
6973
afda1437
EZ
6974 * doprnt.c (doprnt): Fix the case where a multibyte sequence
6975 produced by %s or %c overflows available buffer space. (Bug#8545)
6976
f76dee0c
PE
69772011-04-28 Paul Eggert <eggert@cs.ucla.edu>
6978
6979 * doprnt.c (doprnt): Omit useless test; int overflow check (Bug#8545).
283cdbef 6980 (SIZE_MAX): Move defn after all includes, as they might #define it.
f76dee0c 6981
fdc5744d
JB
69822011-04-28 Juanma Barranquero <lekktu@gmail.com>
6983
6984 * w32.c (init_environment): Warn about defaulting HOME to C:\.
6985
638f053a
JB
69862011-04-28 Juanma Barranquero <lekktu@gmail.com>
6987
6988 * keyboard.c (Qdelayed_warnings_hook): Define.
6989 (command_loop_1): Run `delayed-warnings-hook'
6990 if Vdelayed_warnings_list is non-nil.
6991 (syms_of_keyboard) <delayed-warnings-hook>: DEFSYM it.
6992 (syms_of_keyboard) <delayed-warnings-list>: DEFVAR_LISP it.
6993
d178f871
EZ
69942011-04-28 Eli Zaretskii <eliz@gnu.org>
6995
6996 * doprnt.c (doprnt): Don't return value smaller than the buffer
6997 size if the message was truncated. (Bug#8545).
6998
b124fd93
JB
69992011-04-28 Juanma Barranquero <lekktu@gmail.com>
7000
7001 * w32fns.c (Fx_change_window_property, Fx_delete_window_property)
7002 (Fx_window_property): #if-0 the whole functions, not just the bodies.
7003
e810457d
PE
70042011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7005
7006 * doprnt.c (doprnt): Support "ll" length modifier, for long long.
7007
ea51cceb
JB
70082011-04-27 Juanma Barranquero <lekktu@gmail.com>
7009
7010 * makefile.w32-in: Update dependencies.
7011
94dcfacf
EZ
70122011-04-27 Eli Zaretskii <eliz@gnu.org>
7013
7014 Improve `doprnt' and its usage. (Bug#8545)
7015 * doprnt.c (doprnt): Make sure `format' is never accessed beyond
7016 `format_end'. Remove support for %l as a conversion specifier.
7017 Don't use xrealloc. Improve diagnostics when the %l size modifier
7018 is used. Update the commentary.
7019
7020 * eval.c (verror): Simplify calculation of size_t.
7021
7022 * coding.c (Ffind_operation_coding_system): Fix diagnostic error
7023 messages.
7024
f61f41d7
PE
70252011-04-27 Yoshiaki Kasahara <kasahara@nc.kyushu-u.ac.jp> (tiny change)
7026
7027 * buffer.c (init_buffer) [USE_MMAP_FOR_BUFFERS]: Adjust to aliasing
7028 change.
7029
96fb4434
PE
70302011-04-27 Paul Eggert <eggert@cs.ucla.edu>
7031
7032 * nsmenu.m: Replace all uses of XVECTOR with ASIZE and AREF.
7033 This makes this file independent of the recent pseudovector change.
7034
671875da 70352011-04-26 Paul Eggert <eggert@cs.ucla.edu>
eab3844f 7036
69e9b5a3
PE
7037 * keyboard.c (handle_user_signal): Fix pointer signedness problem.
7038
b5f869a7 7039 * gnutls.c (emacs_gnutls_handle_error): Remove unused local.
7754e151 7040 (Fgnutls_boot): gnutls_certificate_verify_peers2 wants unsigned *.
8d4c3955 7041 Remove unused local.
c8926152 7042 (emacs_gnutls_write): Don't use uninitialized rtnval if nbyte <= 0.
080e5a8d 7043
841a1577 7044 * lisp.h: Fix a problem with aliasing and vector headers. (Bug#8546)
04f2d78b
CB
7045 GCC 4.6.0 optimizes based on type-based alias analysis.
7046 For example, if b is of type struct buffer * and v of type struct
eab3844f
PE
7047 Lisp_Vector *, then gcc -O2 was incorrectly assuming that &b->size
7048 != &v->size, and therefore "v->size = 1; b->size = 2; return
7049 v->size;" must therefore return 1. This assumption is incorrect
7050 for Emacs, since it type-puns struct Lisp_Vector * with many other
7051 types. To fix this problem, this patch adds a new type struct
f904488f 7052 vectorlike_header that documents the constraints on layout of vectors
eab3844f
PE
7053 and pseudovectors, and helps optimizing compilers not get fooled
7054 by Emacs's type punning. It also adds the macros XSETTYPED_PVECTYPE
7055 XSETTYPED_PSEUDOVECTOR, TYPED_PSEUDOVECTORP, for similar reasons.
f904488f
PE
7056 * lisp.h (XSETTYPED_PVECTYPE): New macro, specifying the name of
7057 the size member.
eab3844f
PE
7058 (XSETPVECTYPE): Rewrite in terms of new macro.
7059 (XSETPVECTYPESIZE): New macro, specifying both type and size.
7060 This is a bit clearer, and further avoids the possibility of
7061 undesirable aliasing.
7062 (XSETTYPED_PSEUDOVECTOR): New macro, specifying the size.
f904488f 7063 (XSETPSEUDOVECTOR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR.
eab3844f
PE
7064 (XSETSUBR): Rewrite in terms of XSETTYPED_PSEUDOVECTOR and XSIZE,
7065 since Lisp_Subr is a special case (no "next" field).
04f2d78b
CB
7066 (ASIZE): Now uses header.size rather than size.
7067 All previous uses of XVECTOR (foo)->size replaced to use this macro,
f904488f
PE
7068 to avoid the hassle of writing XVECTOR (foo)->header.size.
7069 (struct vectorlike_header): New type.
eab3844f
PE
7070 (TYPED_PSEUDOVECTORP): New macro, also specifying the C type of the
7071 object, to help avoid aliasing.
7072 (PSEUDOVECTORP): Rewrite in terms of TYPED_PSEUDOVECTORP.
7073 (SUBRP): Likewise, since Lisp_Subr is a special case.
7074 * lisp.h (struct Lisp_Vector, struct Lisp_Char_Table):
7075 (struct Lisp_Sub_Char_Table, struct Lisp_Bool_Vector):
7076 (struct Lisp_Hash_Table): Combine first two members into a single
f904488f 7077 struct vectorlike_header member. All uses of "size" and "next" members
eab3844f
PE
7078 changed to be "header.size" and "header.next".
7079 * buffer.h (struct buffer): Likewise.
7080 * font.h (struct font_spec, struct font_entity, struct font): Likewise.
7081 * frame.h (struct frame): Likewise.
7082 * process.h (struct Lisp_Process): Likewise.
7083 * termhooks.h (struct terminal): Likewise.
7084 * window.c (struct save_window_data, struct saved_window): Likewise.
7085 * window.h (struct window): Likewise.
7086 * alloc.c (allocate_buffer, Fmake_bool_vector, allocate_pseudovector):
7087 Use XSETPVECTYPESIZE, not XSETPVECTYPE, to avoid aliasing problems.
7088 * buffer.c (init_buffer_once): Likewise.
7089 * lread.c (defsubr): Use XSETTYPED_PVECTYPE, since Lisp_Subr is a
7090 special case.
7091 * process.c (Fformat_network_address): Use local var for size,
7092 for brevity.
7093
0df1eac5
PE
7094 * bytecode.c (exec_byte_code): Don't use XVECTOR before CHECK_VECTOR.
7095
847ab9d1 7096 Make the Lisp reader and string-to-float more consistent (Bug#8525)
452f4150
PE
7097 * data.c (atof): Remove decl; no longer used or needed.
7098 (digit_to_number): Move to lread.c.
7099 (Fstring_to_number): Use new string_to_number function, to be
7100 consistent with how the Lisp reader treats infinities and NaNs.
7101 Do not assume that floating-point numbers represent EMACS_INT
7102 without losing information; this is not true on most 64-bit hosts.
7103 Avoid double-rounding errors, by insisting on integers when
7104 parsing non-base-10 numbers, as the documentation specifies.
7105 * lisp.h (string_to_number): New decl, replacing ...
7106 (isfloat_string): Remove.
bc0a5c13 7107 * lread.c: Include <inttypes.h>, for uintmax_t and strtoumax.
d78050d6 7108 (read1): Do not accept +. and -. as integers; this
452f4150
PE
7109 appears to have been a coding error. Similarly, do not accept
7110 strings like +-1e0 as floating point numbers. Do not report
7111 overflow for integer overflows unless the base is not 10 which
7112 means we have no simple and reliable way to continue.
7113 Break out the floating-point parsing into a new
7114 function string_to_number, so that Fstring_to_number parses
7115 floating point numbers consistently with the Lisp reader.
04f2d78b 7116 (digit_to_number): Move here from data.c. Make it static inline.
452f4150
PE
7117 (E_CHAR, EXP_INT): Remove, replacing with ...
7118 (E_EXP): New macro, to solve the "1.0e+" problem mentioned below.
7119 (string_to_number): New function, replacing isfloat_string.
7120 This function checks for valid syntax and produces the resulting
7121 Lisp float number too. Rework it so that string-to-number
bc0a5c13 7122 no longer mishandles examples like "1.0e+". Use strtoumax,
d78050d6
PE
7123 so that overflow for non-base-10 numbers is reported only when
7124 there's no portable and simple way to convert to floating point.
452f4150 7125
67769ffc
PE
7126 * textprop.c (set_text_properties_1): Rewrite for clarity,
7127 and to avoid GCC warning about integer overflow.
7128
c20db43f
PE
7129 * intervals.h (struct interval): Use EMACS_INT for members
7130 where EMACS_UINT might cause problems. See
7131 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html>.
7132 (CHECK_TOTAL_LENGTH): Remove cast to EMACS_INT; no longer needed.
7133 * intervals.c (interval_deletion_adjustment): Now returns EMACS_INT.
7134 All uses changed.
37aa2f85
PE
7135 (offset_intervals): Tell GCC not to worry about length overflow
7136 when negating a negative length.
c20db43f 7137
2538aa2f
PE
7138 * alloc.c (overrun_check_malloc, overrun_check_realloc): Now static.
7139 (overrun_check_free): Likewise.
7140
f2d3008d
PE
7141 * alloc.c (SDATA_SIZE) [!GC_CHECK_STRING_BYTES]: Avoid runtime check
7142 in the common case where SDATA_DATA_OFFSET is a multiple of Emacs
7143 word size.
7144
ec8df744
PE
7145 * gnutls.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7146 (gnutls_make_error): Rename local to avoid shadowing.
7147 (gnutls_emacs_global_deinit): ifdef out; not used.
7148 (Fgnutls_boot): Use const for pointer to readonly storage.
7149 Comment out unused local. Fix pointer signedness problems.
7150
640ee02d
PE
7151 * lread.c (openp): Don't stuff size_t into an 'int'.
7152 Use <= on length, not < on length + 1, to avoid GCC 4.6.0 warning
7153 about possible signed overflow.
7154
6048fb2a
PE
7155 * gtkutil.c: Fix problems found by GCC 4.6.0 on Ubuntu 10.10.
7156 (GDK_KEY_g): Don't define if already defined.
7157 (xg_prepare_tooltip): Avoid pointer signedness problem.
7158 (xg_set_toolkit_scroll_bar_thumb): Redo to avoid two casts.
7159
fa3c87e1
PE
7160 * process.c (Fnetwork_interface_info): Avoid left-shift undefined
7161 behavior with 1 << 31. GCC 4.6.0 warns about this on 32-bit hosts.
7162
2172544b
PE
7163 * xfns.c (Fx_window_property): Simplify a bit,
7164 to make a bit faster and to avoid GCC 4.6.0 warning.
7165 * xselect.c (x_get_window_property, x_handle_dnd_message): Likewise.
7166
9b821a21
PE
7167 * fns.c (internal_equal): Don't assume size_t fits in int.
7168
3c616cfa
PE
7169 * alloc.c (compact_small_strings): Tighten assertion a little.
7170
c2982e87
PE
7171 Replace pEd with more-general pI, and fix some printf arg casts.
7172 * lisp.h (pI): New macro, generalizing old pEd macro to other
7173 conversion specifiers. For example, use "...%"pI"d..." rather
7174 than "...%"pEd"...".
7175 (pEd): Remove. All uses replaced with similar uses of pI.
61bdb816 7176 * m/amdx86-64.h, m/ia64.h, m/ibms390x.h: Likewise.
c2982e87
PE
7177 * alloc.c (check_pure_size): Don't overflow by converting size to int.
7178 * bidi.c (bidi_dump_cached_states): Use pI to avoid cast.
7179 * data.c (Fnumber_to_string): Use pI instead of if-then-else-abort.
7180 * dbusbind.c (xd_append_arg): Use pI to avoid cast.
7181 (Fdbus_method_return_internal, Fdbus_method_error_internal): Likewise.
7182 * font.c (font_unparse_xlfd): Avoid potential buffer overrun on
7183 64-bit hosts.
7184 (font_unparse_xlfd, font_unparse_fcname): Use pI to avoid casts.
7185 * keyboard.c (record_char, modify_event_symbol): Use pI to avoid casts.
7186 * print.c (safe_debug_print, print_object): Likewise.
7187 (print_object): Don't overflow by converting EMACS_INT or EMACS_UINT
7188 to int.
6f04d126
PE
7189 Use pI instead of if-then-else-abort. Use %p to avoid casts,
7190 avoiding the 0 flag, which is not portable.
c2982e87
PE
7191 * process.c (Fmake_network_process): Use pI to avoid cast.
7192 * region-cache.c (pp_cache): Likewise.
7193 * xdisp.c (decode_mode_spec): Likewise.
7194 * xrdb.c (x_load_resources) [USE_MOTIF]: Use pI to avoid undefined
7195 behavior on 64-bit hosts with printf arg.
6f04d126 7196 * xselect.c (x_queue_event): Use %p to avoid casts, avoiding 0 flag.
c2982e87
PE
7197 (x_stop_queuing_selection_requests): Likewise.
7198 (x_get_window_property): Don't truncate byte count to an 'int'
7199 when tracing.
0b432f21 7200
5e073ec7
PE
7201 * frame.c (frame_name_fnn_p): Get rid of strtol, which isn't right
7202 here, since it parses constructs like leading '-' and spaces,
7203 which are not wanted; and it overflows with large numbers.
7204 Instead, simply match F[0-9]+, which is what is wanted anyway.
7205
36372bf9
PE
7206 * alloc.c: Remove unportable assumptions about struct layout.
7207 (SDATA_SELECTOR, SDATA_DATA_OFFSET): New macros.
7208 (SDATA_OF_STRING, SDATA_SIZE, allocate_string_data):
7209 (allocate_vectorlike, make_pure_vector): Use the new macros,
7210 plus offsetof, to remove unportable assumptions about struct layout.
7211 These assumptions hold on all porting targets that I know of, but
7212 they are not guaranteed, they're easy to remove, and removing them
7213 makes further changes easier.
7214
0b432f21
PE
7215 * alloc.c (BLOCK BYTES): Fix typo by changing "ablock" to "ablocks".
7216 This doesn't fix a bug but makes the code clearer.
bfd1c781
PE
7217 (string_overrun_cookie): Now const. Use initializers that
7218 don't formally overflow signed char, to avoid warnings.
000098c1
PE
7219 (allocate_string_data) [GC_CHECK_STRING_OVERRUN]: Fix typo that
7220 can cause Emacs to crash when string overrun checking is enabled.
c7bda33c
PE
7221 (allocate_buffer): Don't assume sizeof (struct buffer) is a
7222 multiple of sizeof (EMACS_INT); it need not be, if
7223 alignof(EMACS_INT) < sizeof (EMACS_INT).
d0f4e1f5 7224 (check_sblock, check_string_bytes, check_string_free_list): Protoize.
0b432f21 7225
895009e1
JB
72262011-04-26 Juanma Barranquero <lekktu@gmail.com>
7227
7228 * keyboard.c (QCrtl): Rename from Qrtl. All uses changed.
7229
6a7a1b0b
TZ
72302011-04-26 Teodor Zlatanov <tzz@lifelogs.com>
7231
7232 * gnutls.c (emacs_gnutls_handshake): Return an error if we're not
b5f869a7 7233 supposed to be handshaking. (Bug#8556)
6a7a1b0b
TZ
7234 Reported by Paul Eggert <eggert@cs.ucla.edu>.
7235
841a1577 72362011-04-26 Daniel Colascione <dan.colascione@gmail.com>
0438ce91
DC
7237
7238 * lisp.h (Qdebug): List symbol.
895009e1 7239 * eval.c (Qdebug): Restore global linkage.
0438ce91
DC
7240 * keyboard.c (debug-on-event): New variable.
7241 (handle_user_signal): Break into debugger when debug-on-event
7242 matches the current signal symbol.
7243
f2d3ba6f
DN
72442011-04-25 Dan Nicolaescu <dann@ics.uci.edu>
7245
7246 * alloc.c (check_sblock, check_string_bytes)
7247 (check_string_free_list): Convert to standard C.
7248
42ce4c63
TZ
72492011-04-25 Teodor Zlatanov <tzz@lifelogs.com>
7250
7251 * w32.c (emacs_gnutls_push): Fix typo.
7252
825cd63c
EZ
72532011-04-25 Eli Zaretskii <eliz@gnu.org>
7254
fb11d64d
EZ
7255 * gnutls.c (emacs_gnutls_handshake): Avoid compiler warnings about
7256 "cast to pointer from integer of different size".
7257
825cd63c
EZ
7258 Improve doprnt and its use in verror. (Bug#8545)
7259 * doprnt.c (doprnt): Document the set of format control sequences
7260 supported by the function. Use SAFE_ALLOCA instead of always
7261 using `alloca'.
7262
7263 * eval.c (verror): Don't limit the buffer size at size_max-1, that
7264 is one byte too soon. Don't use xrealloc; instead xfree and
7265 xmalloc anew.
7266
e061a11b
TZ
72672011-04-24 Teodor Zlatanov <tzz@lifelogs.com>
7268
7269 * gnutls.h: Add GNUTLS_STAGE_CALLBACKS enum to denote we're in the
7270 callbacks stage.
7271
7272 * gnutls.c: Renamed global_initialized to
7273 gnutls_global_initialized. Added internals for the
7274 :verify-hostname-error, :verify-error, and :verify-flags
7275 parameters of `gnutls-boot' and documented those parameters in the
7276 docstring. Start callback support.
9173deec
JB
7277 (emacs_gnutls_handshake): Add Woe32 support. Retry handshake
7278 unless a fatal error occurred. Call gnutls_alert_send_appropriate
7279 on error. Return error code.
e061a11b
TZ
7280 (emacs_gnutls_write): Call emacs_gnutls_handle_error.
7281 (emacs_gnutls_read): Likewise.
7282 (Fgnutls_boot): Return handshake error code.
7283 (emacs_gnutls_handle_error): New function.
7284 (wsaerror_to_errno): Likewise.
7285
7286 * w32.h (emacs_gnutls_pull): Add prototype.
7287 (emacs_gnutls_push): Likewise.
7288
7289 * w32.c (emacs_gnutls_pull): New function for GnuTLS on Woe32.
7290 (emacs_gnutls_push): Likewise.
7291
72922011-04-24 Claudio Bley <claudio.bley@gmail.com> (tiny change)
7293
7294 * process.c (wait_reading_process_output): Check if GnuTLS
7295 buffered some data internally if no FDs are set for TLS
7296 connections.
7297
7298 * makefile.w32-in (OBJ2): Add gnutls.$(O).
7299 (LIBS): Link to USER_LIBS.
7300 ($(BLD)/gnutls.$(0)): New target.
7301
fa6996bc
EZ
73022011-04-24 Eli Zaretskii <eliz@gnu.org>
7303
eb35682e
EZ
7304 * xdisp.c (handle_single_display_spec): Rename the
7305 display_replaced_before_p argument into display_replaced_p, to
7306 make it consistent with the commentary. Fix typos in the
7307 commentary.
7308
e2ad650c
EZ
7309 * textprop.c (syms_of_textprop): Remove dead code.
7310 (copy_text_properties): Delete obsolete commentary about an
7311 interface that was deleted long ago. Fix typos in the description
7312 of arguments.
7313
1b2de274
EZ
7314 * msdos.c (XMenuActivate, XMenuAddSelection): Adjust argument list
7315 to changes in oldXMenu/XMenu.h from 2011-04-16.
7316 <menu_help_message, prev_menu_help_message>: Constify.
7317 (IT_menu_make_room): menu->help_text is now `const char **';
7318 adjust.
7319
7320 * msdos.h (XMenuActivate, XMenuAddSelection): Adjust prototypes
7321 to changes in oldXMenu/XMenu.h from 2011-04-16.
7322 (struct XMenu): Declare `help_text' `const char **'.
7323
7324 * xfaces.c <Qunspecified>: Make extern again.
7325
7326 * syntax.c: Include sys/types.h before including regex.h, as
7327 required by Posix.
7328
762b15be
EZ
7329 * doc.c (get_doc_string): Improve the format passed to `error'.
7330
7331 * doprnt.c (doprnt): Improve commentary.
7332
7333 * term.c (init_tty) [MSDOS]: Fix 1st argument to maybe_fatal.
7334
7335 * Makefile.in (TAGS): Depend on $(M_FILE) and $(S_FILE), and scan
7336 them with etags.
7337
f1052e5d
EZ
7338 * makefile.w32-in (globals.h): Add a dummy recipe, to make any
7339 changes in globals.h immediately force recompilation.
762b15be
EZ
7340 (TAGS): Depend on $(CURDIR)/m/intel386.h and
7341 $(CURDIR)/s/ms-w32.h.
7342 (TAGS-gmake): Scan $(CURDIR)/m/intel386.h and $(CURDIR)/s/ms-w32.h.
f1052e5d 7343
fa6996bc
EZ
7344 * character.c (Fchar_direction): Function deleted.
7345 (syms_of_character): Don't defsubr it.
7346 <char-direction-table>: Deleted.
7347
e6c3da20
EZ
73482011-04-23 Eli Zaretskii <eliz@gnu.org>
7349
7350 Fix doprnt so it could be used again safely in `verror'. (Bug#8435)
7351 * doprnt.c: Include limits.h.
7352 (SIZE_MAX): New macro.
04f2d78b
CB
7353 (doprnt): Return a size_t value. 2nd arg is now size_t.
7354 Many local variables are now size_t instead of int or unsigned.
e6c3da20
EZ
7355 Improve overflow protection. Support `l' modifier for integer
7356 conversions. Support %l conversion. Don't assume an EMACS_INT
7357 argument for integer conversions and for %c.
7358
7359 * lisp.h (doprnt): Restore prototype.
7360
7361 * makefile.w32-in ($(BLD)/callint.$(O)): Depend on
7362 $(SRC)/character.h.
7363
7364 * Makefile.in (base_obj): Add back doprnt.o.
7365
7366 * deps.mk (doprnt.o): Add back prerequisites.
7367 (callint.o): Depend on character.h.
7368
7369 * eval.c (internal_lisp_condition_case): Include the handler
7370 representation in the error message.
7371 (verror): Call doprnt instead of vsnprintf. Fix an off-by-one bug
7372 when breaking from the loop.
7373
7374 * xdisp.c (vmessage): Call doprnt instead of vsnprintf.
7375
7376 * callint.c (Fcall_interactively): When displaying error message
7377 about invalid control letter, pass the character's codepoint, not
7378 a pointer to its multibyte form. Improve display of the character
7379 in octal and display also its hex code.
7380
7381 * character.c (char_string): Use %x to display the (unsigned)
7382 codepoint of an invalid character, to avoid displaying a bogus
7383 negative value.
7384
7385 * font.c (check_otf_features): Pass SDATA of SYMBOL_NAME to
7386 `error', not SYMBOL_NAME itself.
7387
7388 * coding.c (Fencode_sjis_char, Fencode_big5_char): Use %c for
7389 character arguments to `error'.
7390
7391 * charset.c (check_iso_charset_parameter): Fix incorrect argument
7392 to `error' in error message about FINAL_CHAR argument. Make sure
7393 FINAL_CHAR is a character, and use %c when it is passed as
7394 argument to `error'.
7395
4ffd0d6b 73962011-04-23 Eli Zaretskii <eliz@gnu.org>
97a93095
EZ
7397
7398 * s/ms-w32.h (localtime): Redirect to sys_localtime.
7399
7400 * w32.c: Include <time.h>.
7401 (sys_localtime): New function.
7402
4ffd0d6b 74032011-04-23 Chong Yidong <cyd@stupidchicken.com>
c17819f4
CY
7404
7405 * xdisp.c (init_xdisp): Initialize echo_area_window (Bug#6451).
7406
4ffd0d6b 7407 * buffer.c (syms_of_buffer): Doc fix (Bug#6902).
aac0c6e3 7408
4ffd0d6b 74092011-04-23 Samuel Thibault <sthibault@debian.org> (tiny change)
aac0c6e3 7410
4ffd0d6b
GM
7411 * sysdep.c (wait_for_termination): On GNU Hurd, kill returns -1 on
7412 zombies (Bug#8467).
aac0c6e3 7413
04c56954
EZ
74142011-04-19 Eli Zaretskii <eliz@gnu.org>
7415
7416 * syntax.h (SETUP_SYNTAX_TABLE_FOR_OBJECT): Fix setting of
7417 gl_state.e_property when gl_state.object is Qt.
7418
7419 * insdel.c (make_gap_larger): Remove limitation of buffer size
7420 to <= INT_MAX.
7421
16a43933
CY
74222011-04-18 Chong Yidong <cyd@stupidchicken.com>
7423
7424 * xdisp.c (lookup_glyphless_char_display)
7425 (produce_glyphless_glyph): Handle cons cell entry in
7426 glyphless-char-display.
7427 (Vglyphless_char_display): Document it.
7428
7429 * term.c (produce_glyphless_glyph): Handle cons cell entry in
7430 glyphless-char-display.
7431
4581706e
CY
74322011-04-17 Chong Yidong <cyd@stupidchicken.com>
7433
7434 * xdisp.c (get_next_display_element): Remove unnecessary ifdefs.
7435
7436 * termhooks.h (FRAME_WINDOW_P): Remove duplicated definitions.
7437
7438 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): Add missing
7439 definition for no-X builds.
7440
4887c6e2 74412011-04-16 Paul Eggert <eggert@cs.ucla.edu>
764430a3 7442
fd35b6f9
PE
7443 Static checks with GCC 4.6.0 and non-default toolkits.
7444
5c1ccb01
PE
7445 * s/sol2-6.h, s/unixware.h (PTY_TTY_NAME_SPRINTF): Protoize decl.
7446
006c5daa
PE
7447 * process.c (keyboard_bit_set): Define only if SIGIO.
7448 (send_process_trap): Mark it with NO_RETURN if it doesn't return.
7449 (send_process): Repair possible setjmp clobbering.
7450
efc736d3
PE
7451 * s/usg5-4-common.h (SETUP_SLAVE_PTY): Don't pass extra arg to 'fatal'.
7452
4e2fe2e6
PE
7453 * eval.c: Include <stdio.h>, for vsnprintf on non-GNU/Linux hosts.
7454
f97334a2
PE
7455 * data.c (arith_error): Mark with NO_RETURN if it doesn't return.
7456
4e75f29d
PE
7457 * alloc.c (bytes_used_when_full, SPARE_MEMORY, BYTES_USED):
7458 Define only if needed.
7459
90efadd1
PE
7460 * sysdep.c (_FILE_OFFSET_BITS): Make this hack even uglier
7461 by pacifying GCC about it. Maybe it's time to retire it?
875975e9 7462 * xfaces.c (USG, __TIMEVAL__): Likewise.
90efadd1 7463
3c647824
PE
7464 * dispextern.h (struct redisplay_interface): Rename param
7465 to avoid shadowing.
e264f262 7466 * termhooks.h (struct terminal): Likewise.
761383f4 7467 * xterm.c (xembed_send_message): Likewise.
3c647824 7468
b58c5c4a
PE
7469 * insdel.c (make_gap_smaller): Define only if
7470 USE_MMAP_FOR_BUFFERS || REL_ALLOC || DOUG_LEA_MALLOC.
7471
cad59032
PE
7472 * keyboard.c (read_char): Make a var volatile so longjmp won't clobber
7473 it.
7474
c339dc2e
PE
7475 * emacs.c (MAX_HEAP_BSS_DIFF, my_edata): Move to where they're used,
7476 so that we aren't warned about unused symbols.
7477
91a3e27b
PE
7478 * xfns.c (Fx_file_dialog): Rename local to avoid shadowing.
7479
399c71d3 7480 * xdisp.c (x_produce_glyphs): Mark var as initialized (Bug#8512).
7a3fb125 7481
8ffc96f5
PE
7482 * xfns.c (x_real_positions): Mark locals as initialized.
7483
eef9bc79
PE
7484 * xmenu.c (xmenu_show): Don't use uninitialized vars.
7485
098db9dd
PE
7486 * xterm.c: Fix problems found by static analysis with other toolkits.
7487 (toolkit_scroll_bar_interaction): Define and use only if USE_X_TOOLKIT.
dda3aedd
PE
7488 (x_dispatch_event): Declare static if USE_GTK, and
7489 define if USE_GTK || USE_X_TOOLKIT.
098db9dd 7490 (SET_SAVED_BUTTON_EVENT): Define only if USE_X_TOOLKIT || USE_GTK.
dda3aedd 7491 * xterm.h (x_dispatch_event): Extern only if USE_X_TOOLKIT.
841a1577
JB
7492 * xterm.c, xterm.h (x_mouse_leave): Bring this function back, but only
7493 if defined HAVE_MENUS && !defined USE_X_TOOLKIT && !defined USE_GTK.
098db9dd 7494
eb18f6cc
PE
7495 * xmenu.c (menu_help_callback): Pointer type fixes.
7496 Use const pointers when pointing at readonly data. Avoid pointer
7497 signedness clashes.
7498 (FALSE): Remove unused macro.
7499 (update_frame_menubar): Remove unused decl.
7500
1fe72bf8
PE
7501 * xfns.c (Fx_hide_tip): Move locals to avoid shadowing.
7502
60d9e1db
PE
7503 * menu.c (push_submenu_start, push_submenu_end): Do not define unless
7504 USE_X_TOOLKIT || USE_GTK || HAVE_NS || defined HAVE_NTGUI.
7505 (single_menu_item): Rename local to avoid shadowing.
7506
39261c26
PE
7507 * keyboard.c (make_lispy_event): Remove unused local var.
7508
018c5e19
PE
7509 * frame.c, frame.h (x_get_resource_string): Bring this back, but
7510 only if HAVE_X_WINDOWS && !USE_X_TOOLKIT.
7511
63d2b86e
PE
7512 * bitmaps: Change bitmaps from unsigned char back to the X11
7513 compatible char. Avoid the old compiler warnings about
7514 out-of-range initializers by using, for example, '\xab' rather
7515 than 0xab.
7516
aefd87e1
PE
7517 * xgselect.c (xgselect_initialize): Check vs interface
7518 even if ! (defined (USE_GTK) || defined (HAVE_GCONF)).
7519
bf501fb9
PE
7520 * xmenu.c (xmenu_show): Rename parm to avoid shadowing.
7521
e9829fdf
PE
7522 * xterm.c (x_create_toolkit_scroll_bar): Use const * for pointers
7523 to read-only memory.
7524
1086c095
PE
7525 * fns.c (vector): Remove; this old hack is no longer needed.
7526
2baccd04 7527 * xsmfns.c (create_client_leader_window): Rename shadowing arg.
401f10cb 7528 Remove unused var.
dde42981 7529 (gdk_x11_set_sm_client_id) [!USE_GTK]: Don't define.
2baccd04 7530
72391843 7531 * xrdb.c (x_load_resources): Omit unused local.
3565b346 7532
436c16df 7533 * xfns.c (free_frame_menubar, atof): Remove duplicate decls.
8a94ea33 7534 (x_window): Rename locals to avoid shadowing.
dc5ddd85 7535 (USG): Use the kludged USG macro, to pacify gcc.
436c16df 7536
92bb796d 7537 * xterm.c (x_alloc_nearest_color_for_widget): Remove; unused.
bbbef9e1 7538 (x_term_init): Remove local to avoid shadowing.
92bb796d 7539
764430a3 7540 * xfns.c, xterm.c (_XEditResCheckMessages): Protoize decl.
4887c6e2
PE
7541
7542 * xdisp.c, dispextern.h (set_vertical_scroll_bar): Now extern if
7543 USE_TOOLKIT_SCROLL_BARS && !USE_GTK, as xterm.c needs it then.
7544
d1dfb56c
EZ
75452011-04-16 Eli Zaretskii <eliz@gnu.org>
7546
c4354cb4
EZ
7547 * gnutls.c (Fgnutls_boot): Don't pass Lisp_Object to `error'.
7548
d1dfb56c
EZ
7549 Fix regex.c, syntax.c and friends for buffers > 2GB.
7550 * syntax.h (struct gl_state_s): Declare character position members
7551 EMACS_INT.
7552
7553 * syntax.c (update_syntax_table): Declare 2nd argument EMACS_INT.
7554
04f2d78b
CB
7555 * textprop.c (verify_interval_modification, interval_of):
7556 Declare arguments EMACS_INT.
d1dfb56c
EZ
7557
7558 * intervals.c (adjust_intervals_for_insertion): Declare arguments
7559 EMACS_INT.
7560
7561 * intervals.h (CHECK_TOTAL_LENGTH): Cast to EMACS_INT, not `int'.
7562
7563 * indent.c (Fvertical_motion): Local variable it_start is now
7564 EMACS_INT.
7565
7566 * regex.c (re_match, re_match_2, re_match_2_internal)
7567 (bcmp_translate, regcomp, regexec, print_double_string)
7568 (group_in_compile_stack, re_search, re_search_2, regex_compile)
7569 (re_compile_pattern, re_exec): Declare arguments and local
7570 variables `size_t' and `ssize_t' and return values `regoff_t', as
7571 appropriate.
7572 (POP_FAILURE_REG_OR_COUNT) <pfreg>: Declare `long'.
7573 (CHECK_INFINITE_LOOP) <failure>: Declare `ssize_t'.
7574 <compile_stack_type>: `size' and `avail' are now `size_t'.
7575
7576 * regex.h <regoff_t>: Use ssize_t, not int.
7577 (re_search, re_search_2, re_match, re_match_2): Arguments that
7578 specify buffer/string position and length are now ssize_t and
7579 size_t. Return type is regoff_t.
7580
613052cd
BK
75812011-04-16 Ben Key <bkey76@gmail.com>
7582
7583 * nsfont.m: Fixed bugs in ns_get_family and
7584 ns_descriptor_to_entity that were caused by using free to
7585 deallocate memory blocks that were allocated by xmalloc (via
7586 xstrdup). This caused Emacs to crash when compiled with
7587 XMALLOC_OVERRUN_CHECK defined (when Emacs was configured with
7588 --enable-checking=xmallocoverrun). xfree is now used to
7589 deallocate these memory blocks.
7590
4170f62f 75912011-04-15 Paul Eggert <eggert@cs.ucla.edu>
3e047f51 7592
71b41406
PE
7593 * sysdep.c (emacs_read): Remove unnecessary check vs MAX_RW_COUNT.
7594
9587a89d
PE
7595 emacs_write: Accept and return EMACS_INT for sizes.
7596 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00514.html
7597 et seq.
7598 * gnutls.c, gnutls.h (emacs_gnutls_read, emacs_gnutls_write):
7599 Accept and return EMACS_INT.
7600 (emacs_gnutls_write): Return the number of bytes written on
7601 partial writes.
7602 * sysdep.c, lisp.h (emacs_read, emacs_write): Likewise.
273a5f82
PE
7603 (emacs_read, emacs_write): Remove check for negative size, as the
7604 Emacs source code has been audited now.
9587a89d
PE
7605 * sysdep.c (MAX_RW_COUNT): New macro, to work around kernel bugs.
7606 (emacs_read, emacs_write): Use it.
273a5f82
PE
7607 * process.c (send_process): Adjust to the new signatures of
7608 emacs_write and emacs_gnutls_write. Do not attempt to store
7609 a byte offset into an 'int'; it might overflow.
9587a89d 7610 See http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00483.html
273a5f82 7611
3e047f51
PE
7612 * sound.c: Don't assume sizes fit in 'int'.
7613 (struct sound_device.period_size, alsa_period_size):
9c3c56a7 7614 Return EMACS_INT, not int.
3e047f51 7615 (struct sound_device.write, vox_write, alsa_write):
9c3c56a7
PE
7616 Accept EMACS_INT, not int.
7617 (wav_play, au_play): Use EMACS_INT to store sizes and to
3e047f51
PE
7618 record read return values.
7619
cc39a9db
BK
76202011-04-15 Ben Key <bkey76@gmail.com>
7621
c9d0ec6d
JB
7622 * keyboard.c (Qundefined): Don't declare static since it is used
7623 in nsfns.m.
7624 * xfaces.c (Qbold, Qexpanded, Qitalic, Qcondensed): Don't declare
7625 static since they are used in nsfont.m.
cc39a9db 7626
6c60eb9f
SM
76272011-04-15 Stefan Monnier <monnier@iro.umontreal.ca>
7628
7629 * process.c (Qprocessp): Don't declare static.
7630 * lisp.h (Qprocessp): Declare again.
7631
7990b61a
JB
76322011-04-15 Juanma Barranquero <lekktu@gmail.com>
7633
7634 * font.c (Qopentype): Don't make static (used from w32uniscribe.c).
7635
5d4cb038
PE
76362011-04-14 Paul Eggert <eggert@cs.ucla.edu>
7637
8bd7b830 7638 Improve C-level modularity by making more things 'static'.
cd64ea1d 7639
e3b27b31
PE
7640 Don't publish debugger-only interfaces to other modules.
7641 * lisp.h (safe_debug_print, debug_output_compilation_hack):
7642 (verify_bytepos, count_markers): Move decls to the only modules
7643 that need them.
7644 * region-cache.h (pp_cache): Likewise.
7645 * window.h (check_all_windows): Likewise.
7646 * marker.c, print.c, region-cache.c, window.c: Decls moved here.
7647
5d4cb038
PE
7648 * sysdep.c (croak): Now static, if
7649 defined TIOCNOTTY || defined USG5 || defined CYGWIN.
7650 * syssignal.h (croak): Declare only if not static.
69003fd8
PE
7651
7652 * alloc.c (refill_memory_reserve): Now static if
7653 !defined REL_ALLOC || defined SYSTEM_MALLOC.
7654 * lisp.h (refill_memory_reserve): Declare only if not static.
93ea6e8f 7655
e87b6180
PE
7656 * xsettings.c, xsettings.h (xsettings_get_system_normal_font):
7657 Define only if USE_LUCID.
7658
ac64929e
PE
7659 * xrdb.c (x_customization_string, x_rm_string): Now static.
7660
6f37259d
PE
7661 * xmenu.c (x_menu_wait_for_event): Export only if USE_MOTIF.
7662 * xterm.h (x_menu_wait_for_event): Declare only if USE_MOTIF.
7663
1683e3ab
PE
7664 * xdisp.c (draw_row_with_mouse_face): Now static.
7665 * dispextern.h (draw_row_with_mouse_fave): Remove decl.
7666
de9c2632
PE
7667 * window.h (check_all_windows): Mark externally visible.
7668
2b96acb7
PE
7669 * window.c (window_deletion_count): Now static.
7670
7671 * undo.c: Make symbols static if they're not exported.
7672 (last_undo_buffer, last_boundary_position, pending_boundary):
7673 Now static.
7674
50436f33
PE
7675 * textprop.c (interval_insert_behind_hooks): Now static.
7676 (interval_insert_in_front_hooks): Likewise.
7677
64520e5c
PE
7678 * term.c: Make symbols static if they're not exported.
7679 (tty_turn_off_highlight, get_tty_terminal, max_frame_cols):
7680 (max_frame_lines, tty_set_terminal_modes):
7681 (tty_reset_terminal_modes, tty_turn_off_highlight):
7682 (get_tty_terminal): Now static.
7683 (term_mouse_moveto): Do not define if HAVE_WINDOW_SYSTEM.
7684 * termhooks.h (term_mouse_moveto): Do not declare if
8bd7b830 7685 HAVE_WINDOW_SYSTEM.
64520e5c
PE
7686 * dispextern.h (tty_set_terminal_modes, tty_reset_terminal_modes):
7687 (tty_turn_off_highlight, get_tty_terminal): Remove decls.
7688
1fa53021
PE
7689 * sysdep.c: Make symbols static if they're not exported.
7690 (emacs_get_tty, emacs_set_tty, old_fcntl_flags, old_fcntl_owner):
7691 Now static.
7692 (sigprocmask_set, full_mask): Remove; unused.
7693 (wait_debugging): Mark as visible.
7694 * syssignal.h (SIGFULLMASK, full_mask): Remove decls.
7695 * systty.h (emacs_get_tty, emacs_set_tty): Remove decls.
7696
d4b43b22
PE
7697 * syntax.c (syntax_temp): Define only if !__GNUC__.
7698
b7c513d0
PE
7699 * sound.c (current_sound_device, current_sound): Now static.
7700
989b29ad
PE
7701 * search.c (searchbufs, searchbuf_head): Now static.
7702
13a55a78
PE
7703 * scroll.c (scroll_cost): Remove; unused.
7704 * dispextern.h (scroll_cost): Remove decl.
7705
de68a1fc
PE
7706 * region-cache.h (pp_cache): Mark as externally visible.
7707
40ccffa6
PE
7708 * process.c: Make symbols static if they're not exported.
7709 (process_tick, update_tick, create_process, chan_process):
7710 (Vprocess_alist, proc_buffered_char, datagram_access):
7711 (fd_callback_data, send_process_frame, process_sent_to): Now static.
7712 (deactivate_process): Mark defn as static, as well as decl.
7713 * lisp.h (create_process): Remove decl.
7714 * process.h (chan_process, Vprocess_alist): Remove decls.
7715
ad64fc97
PE
7716 * print.c: Make symbols static if they're not exported.
7717 (print_depth, new_backquote_output, being_printed, print_buffer):
7718 (print_buffer_size, print_buffer_pos, print_buffer_pos_byte):
7719 (print_interval, print_number_index, initial_stderr_stream):
7720 Now static.
7721 * lisp.h (Fprinc): Remove decl.
7722 (debug_output_compilation_hack): Mark as externally visible.
7723
adddb265
PE
7724 * sysdep.c (croak): Move decl from here to syssignal.h.
7725 * syssignal.h (croak): Put it here, so the API can be checked when
7726 'croak' is called from dissociate_if_controlling_tty.
7727
1717ede2
PE
7728 * minibuf.c: Make symbols static if they're not exported.
7729 (minibuf_save_list, choose_minibuf_frame): Now static.
7730 * lisp.h (choose_minibuf_frame): Remove decl.
7731
fa5fb2bc
PE
7732 * lisp.h (verify_bytepos, count_markers): Mark as externally visible.
7733
1e3890d1
PE
7734 * lread.c: Make symbols static if they're not exported.
7735 (read_objects, initial_obarray, oblookup_last_bucket_number):
7736 Now static.
7737 (make_symbol): Remove; unused.
7738 * lisp.h (initial_obarray, make_symbol): Remove decls.
7739
8a1414fa
PE
7740 * keyboard.c: Make symbols static if they're not exported.
7741 (single_kboard, recent_keys_index, total_keys, recent_keys):
7742 (this_command_key_count_reset, raw_keybuf, raw_keybuf_count):
7743 (this_single_command_key_start, echoing, last_auto_save):
7744 (read_key_sequence_cmd, dribble, recursive_edit_unwind):
7745 (command_loop, echo_now, keyboard_init_hook, help_char_p):
7746 (quit_throw_to_read_char, command_loop_2, top_level_1, poll_timer):
7747 (Vlispy_mouse_stem, double_click_count):
7748 Now static.
7749 (force_auto_save_soon): Define only if SIGDANGER.
7750 (ignore_mouse_drag_p): Now static if
7751 !defined HAVE_WINDOW_SYSTEM || defined USE_GTK || defined HAVE_NS.
7752 (print_help): Remove; unused.
7753 (stop_character, last_timer_event): Mark as externally visible.
7754 * keyboard.h (ignore_mouse_drag_p): Declare only if
7755 defined HAVE_WINDOW_SYSTEM && !defined USE_GTK && !defined HAVE_NS.
7756 (echo_now, help_char_p, quit_throw_to_read_char): Remove decls.
7757 * lisp.h (echoing): Remove decl.
7758 (force_auto_save_soon): Declare only if SIGDANGER.
7759 * xdisp.c (redisplay_window): Simplify code, to make it more
7760 obvious that ignore_mouse_drag_p is not accessed if !defined
7761 USE_GTK && !defined HAVE_NS.
7762
93ea6e8f
PE
7763 * intervals.c: Make symbols static if they're not exported.
7764 (merge_properties_sticky, merge_interval_right, delete_interval):
7765 Now static.
7766 * intervals.h (merge_interval_right, delete_interval): Remove decls.
7767
77382fcc
PE
7768 * insdel.c: Make symbols static if they're not exported.
7769 However, leave prepare_to_modify_buffer alone. It's never
7770 called from outside this function, but that appears to be a bug.
7771 (combine_after_change_list, combine_after_change_buffer):
4889fc82 7772 (adjust_after_replace, signal_before_change): Now static.
77382fcc
PE
7773 (adjust_after_replace_noundo): Remove; unused.
7774 * lisp.h (adjust_after_replace, adjust_after_replace_noundo):
4889fc82 7775 (signal_before_change): Remove decls.
77382fcc 7776
9306c32e
PE
7777 * indent.c (val_compute_motion, val_vmotion): Now static.
7778
cd44d2eb
PE
7779 * image.c: Make symbols static if they're not exported.
7780 * dispextern.h (x_create_bitmap_from_xpm_data): Do not declare
7781 if USE_GTK.
7782 * image.c (x_create_bitmap_from_xpm_data): Do not define if USE_GTK.
7783 (xpm_color_cache, ct_table, ct_colors_allocated): Now static.
7784
ad9a7a06
PE
7785 * fringe.c (standard_bitmaps): Now static.
7786 (max_used_fringe_bitmap): Now static, unless HAVE_NS.
7787
81626931
PE
7788 * frame.c: Make symbols static if they're not exported.
7789 (x_report_frame_params, make_terminal_frame): Now static.
7790 (get_frame_param): Now static, unless HAVE_NS.
7791 (x_fullscreen_adjust): Define if WINDOWSNT, not if HAVE_WINDOW_SYSTEM.
7792 (x_get_resource_string): Remove; not used.
7793 * frame.h (make_terminal_frame, x_report_frame_params):
7794 (x_get_resource_string); Remove decls.
7795 (x_fullscreen_adjust): Declare only if WINDOWSNT.
7796 * lisp.h (get_frame_param): Declare only if HAVE_NS.
7797
239f9db9
PE
7798 * font.c, fontset.c: Make symbols static if they're not exported.
7799 * dispextern.h (FACE_SUITABLE_FOR_ASCII_CHAR_P): New macro.
7800 (FACE_SUITABLE_FOR_CHAR_P): Use it.
7801 * font.c (font_close_object): Now static.
7802 * font.h (font_close_object): Remove.
7803 * fontset.c (FONTSET_OBJLIST): Remove.
7804 (free_realized_fontset) #if-0 the body, which does nothing.
7805 (face_suitable_for_char_p): #if-0, as it's never called.
7806 * fontset.h (face_suitable_for_char_p): Remove decl.
04f2d78b
CB
7807 * xfaces.c (face_at_string_position):
7808 Use FACE_SUITABLE_FOR_ASCII_CHAR_P, not FACE_SUITABLE_FOR_CHAR_P,
239f9db9
PE
7809 since 0 is always ASCII.
7810
dfcf3579
PE
7811 * fns.c (weak_hash_tables): Now static.
7812
5045092b
PE
7813 * fileio.c: Make symbols static if they're not exported.
7814 (auto_saving, auto_save_mode_bits, auto_save_error_occurred):
7815 (Vwrite_region_annotation_buffers): Now static.
7816
57a96f5c
PE
7817 * eval.c: Make symbols static if they're not exported.
7818 (backtrace_list, lisp_eval_depth, when_entered_debugger): Now static.
7819 * lisp.h (backtrace_list): Remove decl.
7820
35f08c38
PE
7821 * emacs.c: Make symbols static if they're not exported.
7822 (malloc_state_ptr, malloc_using_checking, syms_of_emacs):
7823 (fatal_error_code, fatal_error_signal_hook, standard_args):
7824 Now static.
7825 (fatal_error_signal): Now static, unless FLOAT_CATCH_SIGKILL.
7826 (DEFINE_DUMMY_FUNCTION): Mark function as externally visible.
7827 (__CTOR_LIST__, __DTOR_LIST__): Now externally visible.
7828 * lisp.h (fatal_error_signal_hook): Remove decl.
7829 (fatal_error_signal): Declare only if FLOAT_CATCH_SIGKILL.
7830
f44bd759
PE
7831 * editfns.c: Move a (normally-unused) function to its only use.
7832 * editfns.c, lisp.h (get_operating_system_release): Remove.
7833 * process.c (init_process) [DARWIN_OS]: Do it inline, as it is not
7834 worth the hassle of breaking this out.
7835
b532497d
PE
7836 * xterm.c: Make symbols static if they're not exported.
7837 (x_raise_frame, x_lower_frame, x_wm_set_window_state):
7838 (x_wm_set_icon_pixmap, x_initialize, XTread_socket_fake_io_error):
7839 (x_destroy_window, x_delete_display):
7840 Now static.
7841 (x_dispatch_event): Now static if ! (USE_MOTIF || USE_X_TOOLKIT).
7842 (x_mouse_leave): Remove; unused.
7843 * xterm.h (x_display_info_for_name, x_raise_frame, x_lower_frame):
7844 (x_destroy_window, x_wm_set_window_state, x_wm_set_icon_pixmap):
7845 (x_delete_display, x_initialize, x_set_border_pixel, x_screen_planes):
7846 Remove decls.
7847 (x_mouse_leave): Declare only if WINDOWSNT.
7848 (x_dispatch_event): Declare only if USE_MOTIF or USE_X_TOOLKIT.
7849 (xic_create_fontsetname): Declare only if HAVE_X_WINDOWS &&
7850 USE_X_TOOLKIT.
7851
1675728f
PE
7852 * ftxfont.c: Make symbols static if they're not exported.
7853 (ftxfont_driver): Export only if !defined HAVE_XFT && def8ined
7854 HAVE_FREETYPE.
7855 * font.h (ftxfont_driver): Likewise.
7856
e4cebfca
PE
7857 * xfns.c: Make symbols static if they're not exported.
7858 (x_last_font_name, x_display_info_for_name):
7859 (x_set_foreground_color, x_set_background_color, x_set_mouse_color):
7860 (x_set_cursor_color, x_set_border_pixel, x_set_border_color):
7861 (x_set_cursor_type, x_set_icon_type, x_set_icon_name):
7862 (x_set_scroll_bar_foreground, x_set_scroll_bar_background):
7863 (x_explicitly_set_name, x_set_title, xic_defaut_fontset, tip_timer):
7864 (last_show_tip_args): Now static.
7865 (xic_defaut_fontset, xic_create_fontsetname): Define only if
7866 defined HAVE_X_WINDOWS && defined USE_X_TOOLKIT
7867 (x_screen_planes): Remove; unused.
7868 * dispextern.h (x_screen_planes): Remove decl.
7869
5bf46f05
PE
7870 * dispnew.c: Make symbols static if they're not exported.
7871 * dispextern.h (redraw_garbaged_frames, scrolling):
7872 (increment_row_positions): Remove.
7873 * dispnew.c (new_glyph_matrix, increment_row_positions, scrolling):
7874 (delayed_size_change, glyph_matrix_count, glyph_pool_count):
7875 Now static.
7876 (redraw_garbaged_frames): Remove; unused.
7877
435f4c28
PE
7878 * xfaces.c: Make symbols static if they're not exported.
7879 * dispextern.h (ascii_face_of_lisp_face, free_realized_face):
7880 Remove decls.
7881 * xterm.h (defined_color): Remove decls.
7882 (x_free_dpy_colors): Declare only if USE_X_TOOLKIT.
7883 * xfaces.c (tty_suppress_bold_inverse_default_colors_p):
7884 (menu_face_changed_default, defined_color, free_realized_face):
7885 (x_free_dpy_colors): Define only if USE_X_TOOLKIT.
7886 (ascii_face_of_lisp_face): Remove; unused.
7887
8524aef3
PE
7888 * xdisp.c: Make symbols static if they're not exported.
7889 * dispextern.h (scratch_glyph_row, window_box_edges):
7890 (glyph_to_pixel_coords, set_cursor_from_row):
7891 (get_next_display_element, set_iterator_to_next):
7892 (highlight_trailing_whitespace, frame_to_window_pixel_xy):
7893 (show_mouse_face): Remove decls
7894 * frame.h (message_buf_print): Likewise.
7895 * lisp.h (pop_message, set_message, check_point_in_composition):
7896 Likewise.
7897 * xterm.h (set_vertical_scroll_bar): Likewise.
7898 * xdisp.c (list_of_error, Vmessage_stack, line_number_displayed):
7899 (message_buf_print, scratch_glyph_row, displayed_buffer):
7900 (set_iterator_to_next, pop_message, set_message, set_cursor_from_row):
7901 (get_next_display_element, show_mouse_face, window_box_edges):
7902 (frame_to_window_pixel_xy, check_point_in_composition):
7903 (set_vertical_scroll_bar, highlight_trailing_whitespace): Now static.
7904 (glyph_to_pixel_coords): Remove; unused.
7905
16390cd2
PE
7906 * dired.c (file_name_completion): Now static.
7907
7908 * dbusbind.c (xd_in_read_queued_messages): Now static.
7909
a25f4dfa
PE
7910 * lisp.h (circular_list_error, FOREACH): Remove; unused.
7911 * data.c (circular_list_error): Remove.
7912
14a9c8df
PE
7913 * commands.h (last_point_position, last_point_position_buffer):
7914 (last_point_position_window): Remove decls.
7915 * keyboard.c: Make these variables static.
7916
04f2d78b
CB
7917 * coding.h (coding, code_convert_region, encode_coding_gap):
7918 Remove decls.
74ab6df5
PE
7919 * coding.c (Vsjis_coding_system, Vbig5_coding_system):
7920 (iso_code_class, detect_coding, code_convert_region): Now static.
7921 (encode_coding_gap): Remove; unused.
7922
38dfbee1
PE
7923 * chartab.c (chartab_chars, chartab_bits): Now static.
7924
a2cb4e63
PE
7925 * charset.h (charset_iso_8859_1): Remove decl.
7926 * charset.c (charset_iso_8859_1, charset_emacs, map_charset_for_dump):
7927 Now static.
7928
127198fd
PE
7929 * ccl.h (check_ccl_update, Vccl_program_table): Remove decls.
7930 * ccl.c (Vccl_program_table): Now static.
7931 (check_ccl_update): Remove; unused.
7932
d85b608f
PE
7933 * category.c (SET_CATEGORY_SET, set_category_set): Move here.
7934 * category.h: ... from here.
7935 * category.c (check_category_table, set_category_set): Now static.
7936
31cd66f3
PE
7937 * casetab.c (Vascii_upcase_table, Vascii_eqv_table): Now static.
7938 * lisp.h: Remove these decls.
7939
c358e587
PE
7940 * buffer.c (buffer_count): Remove unused var.
7941
e78aecca
PE
7942 * bidi.c (bidi_dump_cached_states): Mark as externally visible,
7943 so that it's not optimized away.
7944 (bidi_ignore_explicit_marks_for_paragraph_level): Likewise.
7945 * dispextern.h (bidi_dump_cached_states): Remove, since it's
7946 exported only to the debugger.
7947
e192d7d3 7948 * atimer.c (alarm_signal_handler, run_all_atimers): Now static.
04f2d78b 7949 * atimer.h (run_all_atimers): Remove; not exported.
e192d7d3 7950
92470028
PE
7951 font.c: Make copy_font_spec and merge_font_spec ordinary C functions.
7952 * font.c (copy_font_spec): Rename from Fcopy_font_spec, since it
7953 was inaccessible from Lisp.
7954 (merge_font_spec): Likewise, renaming from Fmerge_font_spec.
7955 * font.c, font.h, fontset.c, xfaces.c, xfont.c: Change all uses.
7956
244ed907
PE
7957 alloc.c: Import and export fewer symbols, and remove unused items.
7958 * lisp.h (suppress_checking, die): Declare only if ENABLE_CHECKING
7959 is defined.
7960 (suppress_checking): Add EXTERNALLY_VISIBLE attribute, so that
7961 it's not optimized away by whole-program optimization.
7962 (message_enable_multibyte, free_misc): Remove.
7963 (catchlist, handlerlist, mark_backtrace):
7964 Declare only if BYTE_MARK_STACK.
7965 (mark_byte_stack): Likewise, fixing a ifdef-vs-if typo.
7966 * alloc.c (pure): Export only if VIRT_ADDR_VARIES is defined.
7967 (message_enable_multibyte): Remove decl.
7968 (free_misc, interval_free_list, float_block, float_block_index):
7969 (n_float_blocks, float_free_list, cons_block, cons_block_index):
7970 (cons_free_list, last_marked_index):
7971 Now static.
7972 (suppress_checking, die): Define only if ENABLE_CHECKING is defined.
7973 * eval.c (catchlist, handlerlist): Export only if BYTE_MARK_STACK.
7974 (mark_backtrace): Define only if BYTE_MARK_STACK.
7975 * xdisp.c (message_enable_multibyte): Now static.
7976
61c2b50e 7977 Declare Lisp_Object Q* variables to be 'static' if not exported.
955cbe7b
PE
7978 This makes it easier for human readers (and static analyzers)
7979 to see whether these variables are used from other modules.
7980 * alloc.c, buffer.c, bytecode.c, callint.c, casetab.c, category.c:
7981 * ccl.c, character.c, charset.c, cmds.c, coding.c, composite.c:
7982 * data.c, dbusbind.c, dired.c, editfns.c, eval.c, fileio.c, fns.c:
7983 * font.c, frame.c, fringe.c, ftfont.c, image.c, keyboard.c, keymap.c:
7984 * lread.c, macros.c, minibuf.c, print.c, process.c, search.c:
7985 * sound.c, syntax.c, textprop.c, window.c, xdisp.c, xfaces.c, xfns.c:
7986 * xmenu.c, xselect.c:
7987 Declare Q* vars static if they are not used in other modules.
7988 * ccl.h, character.h, charset.h, coding.h, composite.h, font.h:
7989 * frame.h, intervals.h, keyboard.h, lisp.h, process.h, syntax.h:
7990 Remove decls of unexported vars.
7991 * keyboard.h (EVENT_HEAD_UNMODIFIED): Remove now-unused macro.
7992
95c82688
PE
7993 * lisp.h (DEFINE_FUNC): Make sname 'static'.
7994
16a97296
PE
7995 Make Emacs functions such as Fatom 'static' by default.
7996 This makes it easier for human readers (and static analyzers)
7997 to see whether these functions can be called from other modules.
7998 DEFUN now defines a static function. To make the function external
7999 so that it can be used in other C modules, use the new macro DEFUE.
8bd7b830
PE
8000 * lisp.h (Funibyte_char_to_multibyte, Fsyntax_table_p):
8001 (Finit_image_library):
16a97296
PE
8002 (Feval_region, Fbacktrace, Ffetch_bytecode, Fswitch_to_buffer):
8003 (Ffile_executable_p, Fmake_symbolic_link, Fcommand_execute):
8004 (Fget_process, Fdocumentation_property, Fbyte_code, Ffile_attributes):
8005 Remove decls, since these functions are now static.
8006 (Funintern, Fget_internal_run_time): New decls, since these functions
8007 were already external.
95c82688 8008
16a97296
PE
8009 * alloc.c, buffer.c, callint.c, callproc.c, casefiddle.c, casetab.c:
8010 * ccl.c, character.c, chartab.c, cmds.c, coding.c, data.c, dispnew.c:
8011 * doc.c, editfns.c, emacs.c, eval.c, fileio.c, filelock.c, floatfns.c:
8012 * fns.c, font.c, fontset.c, frame.c, image.c, indent.c:
8013 * keyboard.c, keymap.c, lread.c:
8014 * macros.c, marker.c, menu.c, minibuf.c, print.c, process.c, search.c:
8015 * syntax.c, term.c, terminal.c, textprop.c, undo.c:
8016 * window.c, xdisp.c, xfaces.c, xfns.c, xmenu.c, xsettings.c:
8017 Mark functions with DEFUE instead of DEFUN,
8018 if they are used in other modules.
8019 * buffer.c (Fset_buffer_major_mode, Fdelete_overlay): New forward
8020 decls for now-static functions.
8021 * buffer.h (Fdelete_overlay): Remove decl.
8022 * callproc.c (Fgetenv_internal): Mark as internal.
8023 * composite.c (Fremove_list_of_text_properties): Remove decl.
8024 (Fcomposition_get_gstring): New forward static decl.
8025 * composite.h (Fcomposite_get_gstring): Remove decl.
8026 * dired.c (Ffile_attributes): New forward static decl.
8027 * doc.c (Fdocumntation_property): New forward static decl.
8028 * eval.c (Ffetch_bytecode): New forward static decl.
8029 (Funintern): Remove extern decl; now in .h file where it belongs.
8030 * fileio.c (Fmake_symbolic_link): New forward static decl.
8031 * image.c (Finit_image_library): New forward static decl.
8032 * insdel.c (Fcombine_after_change_execute): Make forward decl static.
8033 * intervals.h (Fprevious_property_change):
8034 (Fremove_list_of_text_properties): Remove decls.
8035 * keyboard.c (Fthis_command_keys): Remove decl.
8036 (Fcommand_execute): New forward static decl.
8037 * keymap.c (Flookup_key): New forward static decl.
8038 (Fcopy_keymap): Now static.
8039 * keymap.h (Flookup_key): Remove decl.
8040 * process.c (Fget_process): New forward static decl.
8041 (Fprocess_datagram_address): Mark as internal.
8042 * syntax.c (Fsyntax_table_p): New forward static decl.
8043 (skip_chars): Remove duplicate decl.
8044 * textprop.c (Fprevious_property_change): New forward static decl.
8045 * window.c (Fset_window_fringes, Fset_window_scroll_bars):
8046 Now internal.
8047 (Fset_window_margins, Fset_window_vscroll): New forward static decls.
8048 * window.h (Fset_window_vscroll, Fset_window_margins): Remove decls.
8049
785bbd42
PE
8050 * editfns.c (Fformat): Remove unreachable code.
8051
8b913b57
AS
80522011-04-14 Andreas Schwab <schwab@linux-m68k.org>
8053
8054 * fileio.c (Finsert_file_contents): Fix typo in 2005-05-13
8055 change. (Bug#8496)
8056
a6744a35
EZ
80572011-04-13 Eli Zaretskii <eliz@gnu.org>
8058
8059 * xdisp.c (handle_invisible_prop): Don't call bidi_paragraph_init
8060 when at ZV. (Bug#8487)
8061
e7974947
AS
80622011-04-12 Andreas Schwab <schwab@linux-m68k.org>
8063
baad03f0
AS
8064 * charset.c (Fclear_charset_maps): Use xfree instead of free.
8065 (Bug#8437)
8066 * keyboard.c (parse_tool_bar_item): Likewise.
8067 * sound.c (sound_cleanup, alsa_close): Likewise.
8068 * termcap.c (tgetent): Likewise.
8069 * xfns.c (x_default_font_parameter): Likewise.
8070 * xsettings.c (read_and_apply_settings): Likewise.
8071
e7974947
AS
8072 * alloc.c (overrun_check_malloc, overrun_check_realloc)
8073 (overrun_check_free): Protoize.
8074
28272684
PE
80752011-04-12 Paul Eggert <eggert@cs.ucla.edu>
8076
8077 * sysdep.c (emacs_read, emacs_write): Check for negative sizes
8078 since callers should never pass a negative size.
8079 Change the signature to match that of plain 'read' and 'write'; see
8080 <http://lists.gnu.org/archive/html/emacs-devel/2011-04/msg00397.html>.
8081 * lisp.h: Update prototypes of emacs_write and emacs_read.
8082
11997c76
EZ
80832011-04-11 Eli Zaretskii <eliz@gnu.org>
8084
8085 * xdisp.c (redisplay_window): Don't try to determine the character
8086 position of the scroll margin if the window start point w->startp
e896f03c 8087 is outside the buffer's accessible region. (Bug#8468)
11997c76 8088
8a2cbd72
EZ
80892011-04-10 Eli Zaretskii <eliz@gnu.org>
8090
8091 Fix write-region and its subroutines for buffers > 2GB.
8092 * fileio.c (a_write, e_write): Modify declaration of arguments and
8093 local variables to support buffers larger than 2GB.
8094 (Fcopy_file): Use EMACS_INT for return value of emacs_read.
8095
8096 * sysdep.c (emacs_write, emacs_read): Use ssize_t for last
8097 argument, local variables, and return value.
8098
8099 * lisp.h: Update prototypes of emacs_write and emacs_read.
8100
8101 * sound.c (vox_write): Use ssize_t for return value of emacs_write.
8102
4073e537 81032011-04-10 Paul Eggert <eggert@cs.ucla.edu>
eb3f1cc8 8104
1ebfdcb6
PE
8105 * xdisp.c (vmessage): Use memchr, not strnlen, which some hosts lack.
8106
b2ded58d
PE
8107 Fix more problems found by GCC 4.6.0's static checks.
8108
7d66342c
PE
8109 * xdisp.c (vmessage): Use a better test for character truncation.
8110
bbf47d44
PE
8111 * charset.c (load_charset_map): <, not <=, for optimization,
8112 and to avoid potential problems with integer overflow.
9248994d 8113 * chartab.c (sub_char_table_set_range, char_table_set_range): Likewise.
f9a68bc5 8114 * casetab.c (set_identity, shuffle): Likewise.
3ab1c7ce 8115 * editfns.c (Fformat): Likewise.
1e69125e 8116 * syntax.c (skip_chars): Likewise.
3befa583 8117
e3019616
PE
8118 * xmenu.c (set_frame_menubar): Allocate smaller local vectors.
8119 This also lets GCC 4.6.0 generate slightly better loop code.
8120
becfa255
PE
8121 * callint.c (Fcall_interactively): <, not <=, for optimization.
8122 (Fcall_interactively): Count the number of arguments produced,
8123 not the number of arguments given. This is simpler and lets GCC
8124 4.6.0 generate slightly better code.
8125
dae0cd48
PE
8126 * ftfont.c: Distingish more carefully between FcChar8 and char.
8127 The previous code passed unsigned char * to a functions like
8128 strlen and xstrcasecmp that expect char *, which does not
8129 conform to the C standard.
8130 (get_adstyle_property, ftfont_pattern_entity): Use FcChar8 for
8131 arguments to FcPatternGetString, and explicitly cast FcChar8 * to
8132 char * when the C standard requires it.
8133
76032d70
PE
8134 * keyboard.c (read_char): Remove unused var.
8135
eb3f1cc8
PE
8136 * eval.c: Port to Windows vsnprintf (Bug#8435).
8137 Include <limits.h>.
8138 (SIZE_MAX): Define if the headers do not.
8139 (verror): Do not give up if vsnprintf returns a negative count.
8140 Instead, grow the buffer. This ports to Windows vsnprintf, which
8141 does not conform to C99. Problem reported by Eli Zaretskii.
8142 Also, simplify the allocation scheme, by avoiding the need for
8143 calling realloc, and removing the ALLOCATED variable.
8144
70476b54
PE
8145 * eval.c (verror): Initial buffer size is 4000 (not 200) bytes.
8146
12020a9e
PE
8147 Remove invocations of doprnt, as Emacs now uses vsnprintf.
8148 But keep the doprint source code for now, as we might revamp it
8149 and use it again (Bug#8435).
ea6c7ae6
PE
8150 * lisp.h (doprnt): Remove.
8151 * Makefile.in (base_obj): Remove doprnt.o.
8152 * deps.mk (doprnt.o): Remove.
8153
5fdb398c
PE
8154 error: Print 32- and 64-bit integers portably (Bug#8435).
8155 Without this change, on typical 64-bit hosts error ("...%d...", N)
8156 was used to print both 32- and 64-bit integers N, which relied on
8157 undefined behavior.
61bdb816 8158 * lisp.h, m/amdx86-64.h, m/ia64.h, m/ibms390x.h (pEd): New macro.
5fdb398c
PE
8159 * lisp.h (error, verror): Mark as printf-like functions.
8160 * eval.c (verror): Use vsnprintf, not doprnt, to do the real work.
8161 Report overflow in size calculations when allocating printf buffer.
8162 Do not truncate output string at its first null byte.
8163 * xdisp.c (vmessage): Use vsnprintf, not doprnt, to do the real work.
8164 Truncate the output at a character boundary, since vsnprintf does not
8165 do that.
8166 * charset.c (check_iso_charset_parameter): Convert internal
8167 character to string before calling 'error', since %c now has the
8168 printf meaning.
8169 * coding.c (Fdecode_sjis_char, Fdecode_big5_char): Avoid int
8170 overflow when computing char to be passed to 'error'. Do not
8171 pass Lisp_Object to 'error'; pass the integer instead.
8172 * nsfns.m (Fns_do_applescript): Use int, not long, since it's
8173 formatted with plain %d.
8174
b189fa66
PE
8175 * eval.c (internal_lisp_condition_case): Don't pass spurious arg.
8176
bff87ef0
PE
8177 * keyboard.c (access_keymap_keyremap): Print func name, not garbage.
8178
7e2cac20
PE
8179 * coding.c (Fdecode_sjis_char): Don't assume CODE fits in int.
8180
ce4d90b5
PE
8181 * xterm.c (x_catch_errors): Remove duplicate declaration.
8182
266c9547
PE
8183 * term.c (maybe_fatal): Mark its 3rd arg as a printf format, too.
8184
79c49ad2
PE
8185 * xdisp.c, lisp.h (message_nolog): Remove; unused.
8186
368f4090
JM
81872011-04-10 Jim Meyering <meyering@redhat.com>
8188
8189 use ssize_t and size_t for read- and write-like emacs_gnutls_* functions
8190 * gnutls.c (emacs_gnutls_read): Adjust signature to be more read-like:
8191 return ssize_t not "int", and use size_t as the buffer length.
8192 (emacs_gnutls_write): Likewise, and make the buffer pointer "const".
8193 * gnutls.h: Update declarations.
8194 * process.c (read_process_output): Use ssize_t, to match.
8195 (send_process): Likewise.
8196
a32d4040
CY
81972011-04-09 Chong Yidong <cyd@stupidchicken.com>
8198
8199 * image.c (Fimagemagick_types): Doc fix, and comment cleanup.
8200
8546720e 82012011-04-09 Chong Yidong <cyd@stupidchicken.com>
aac0c6e3 8202
04f2d78b
CB
8203 * ftfont.c (get_adstyle_property, ftfont_pattern_entity):
8204 Use unsigned char, to match FcChar8 type definition.
aac0c6e3 8205
8546720e
GM
8206 * xterm.c (handle_one_xevent):
8207 * xmenu.c (create_and_show_popup_menu):
8208 * xselect.c (x_decline_selection_request)
8209 (x_reply_selection_request): Avoid type-punned deref of X events.
aac0c6e3 8210
0a2f5c1a 82112011-04-09 Eli Zaretskii <eliz@gnu.org>
a53e2e89
EZ
8212
8213 Fix some uses of `int' instead of EMACS_INT.
8214 * search.c (string_match_1, fast_string_match)
8215 (fast_c_string_match_ignore_case, fast_string_match_ignore_case)
8216 (scan_buffer, find_next_newline_no_quit)
8217 (find_before_next_newline, search_command, Freplace_match)
8218 (Fmatch_data): Make some `int' variables be EMACS_INT.
8219
8220 * xdisp.c (display_count_lines): 3rd argument and return value now
8221 EMACS_INT. All callers changed.
8222 (pint2hrstr): Last argument is now EMACS_INT.
8223
8224 * coding.c (detect_coding_utf_8, detect_coding_emacs_mule)
8225 (detect_coding_iso_2022, detect_coding_sjis, detect_coding_big5)
8226 (detect_coding_ccl, detect_coding_charset, decode_coding_utf_8)
8227 (decode_coding_utf_16, decode_coding_emacs_mule)
8228 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5)
8229 (decode_coding_ccl, decode_coding_charset)
8230 <consumed_chars, consumed_chars_base>: Declare EMACS_INT.
8231 (decode_coding_iso_2022, decode_coding_emacs_mule)
8232 (decode_coding_sjis, decode_coding_big5, decode_coding_charset)
8233 <char_offset, last_offset>: Declare EMACS_INT.
8234 (encode_coding_utf_8, encode_coding_utf_16)
8235 (encode_coding_emacs_mule, encode_invocation_designation)
8236 (encode_designation_at_bol, encode_coding_iso_2022)
8237 (encode_coding_sjis, encode_coding_big5, encode_coding_ccl)
8238 (encode_coding_raw_text, encode_coding_charset) <produced_chars>:
8239 Declare EMACS_INT.
8240 (ASSURE_DESTINATION): Declare more_bytes EMACS_INT.
8241 (encode_invocation_designation): Last argument P_NCHARS is now
8242 EMACS_INT.
8243 (decode_eol): Declare pos_byte, pos, and pos_end EMACS_INT.
8244 (produce_chars): from_nchars and to_nchars are now EMACS_INT.
8245
8246 * coding.h (struct coding_system) <head_ascii>: Declare EMACS_INT.
8247 All users changed.
8248
8249 * ccl.c (Fccl_execute_on_string): Declare some variables
8250 EMACS_INT.
8251
8546720e 82522011-04-08 Samuel Thibault <sthibault@debian.org> (tiny change)
0080dc6b
SS
8253
8254 * term.c (init_tty): Fix incorrect ifdef placement (Bug#8450).
8255
4e19a977
CS
82562011-03-19 Christoph Scholtes <cschol2112@googlemail.com>
8257
8258 * process.c (Fformat_network_address): Doc fix.
8259
87302331
R
82602011-04-08 T.V. Raman <tv.raman.tv@gmail.com> (tiny change)
8261
ee7683eb 8262 * xml.c (parse_region): Avoid creating spurious whitespace nodes.
87302331 8263
cbb59342
CY
82642011-04-08 Chong Yidong <cyd@stupidchicken.com>
8265
8266 * keyboard.c (read_char): Call Lisp function help-form-show,
8267 instead of using internal_with_output_to_temp_buffer.
8268 (Qhelp_form_show): New var.
e0d38eeb 8269 (syms_of_keyboard): Use DEFSYM macro.
cbb59342
CY
8270
8271 * print.c (internal_with_output_to_temp_buffer): Function deleted.
8272
8273 * lisp.h (internal_with_output_to_temp_buffer): Remove prototype.
8274
e67a13ab
CY
82752011-04-06 Chong Yidong <cyd@stupidchicken.com>
8276
04f2d78b
CB
8277 * process.c (Flist_processes): Remove to Lisp.
8278 (list_processes_1): Delete.
e67a13ab 8279
973f782d
EZ
82802011-04-06 Eli Zaretskii <eliz@gnu.org>
8281
7c106b1e
EZ
8282 * msdos.c (careadlinkat, careadlinkatcwd): MS-DOS replacements.
8283
973f782d
EZ
8284 * w32.c (careadlinkat, careadlinkatcwd): New always-fail stubs.
8285
41cf7d1a 82862011-04-06 Paul Eggert <eggert@cs.ucla.edu>
27ccc379 8287
ca23cc88
PE
8288 Fix more problems found by GCC 4.6.0's static checks.
8289
f390e2d5
PE
8290 * xmenu.c (Fx_popup_dialog): Don't assume string is free of formats.
8291
42eea0d0
PE
8292 * menu.c (Fx_popup_menu): Don't assume error_name lacks printf formats.
8293
b69769da 8294 * lisp.h (message, message_nolog, fatal): Mark as printf-like.
1e973bc7 8295
f9541e84
PE
8296 * xdisp.c (vmessage): Mark as a printf-like function.
8297
13841b55
PE
8298 * term.c (vfatal, maybe_fatal): Mark as printf-like functions.
8299
c136c10f
PE
8300 * sound.c (sound_warning): Don't crash if arg contains a printf format.
8301
5e2d4a30
PE
8302 * image.c (tiff_error_handler, tiff_warning_handler): Mark as
8303 printf-like functions.
8304 (tiff_load): Add casts to remove these marks before passing them
8305 to system-supplied API.
8306
583f48b9
PE
8307 * eval.c (Fsignal): Remove excess argument to 'fatal'.
8308
b25d760e
PE
8309 * coding.c (EMIT_ONE_BYTE, EMIT_TWO_BYTES): Use unsigned, not int.
8310 This avoids several warnings with gcc -Wstrict-overflow.
d5efd1d1
PE
8311 (DECODE_COMPOSITION_RULE): If the rule is invalid, goto invalid_code
8312 directly, rather than having caller test rule sign. This avoids
8313 some unnecessary tests.
8314 * composite.h (COMPOSITION_ENCODE_RULE_VALID): New macro.
8315 (COMPOSITION_ENCODE_RULE): Arguments now must be valid. This
8316 affects only one use, in DECODE_COMPOSITION_RULE, which is changed.
b25d760e 8317
bc7b6697 8318 * xfont.c (xfont_text_extents): Remove var that was set but not used.
625a3eb1 8319 (xfont_open): Avoid unnecessary tests.
bc7b6697 8320
27ccc379
PE
8321 * composite.c (composition_gstring_put_cache): Use unsigned integer.
8322
dcd5c89a
PE
8323 * composite.h, composite.c (composition_gstring_put_cache):
8324 Use EMACS_INT, not int, for length.
8325
b13a45c6
PE
8326 * composite.h (COMPOSITION_DECODE_REFS): New macro,
8327 breaking out part of COMPOSITION_DECODE_RULE.
8328 (COMPOSITION_DECODE_RULE): Use it.
8329 * composite.c (get_composition_id): Remove unused local vars,
8330 by using the new macro.
8331
1e792e4d
PE
8332 * textprop.c (set_text_properties_1): Change while to do-while,
8333 since the condition is always true at first.
8334
dc6c6455 8335 * intervals.c (graft_intervals_into_buffer): Mark var as used.
aa86731f
PE
8336 (interval_deletion_adjustment): Return unsigned value.
8337 All uses changed.
dc6c6455 8338
aba7731a
PE
8339 * process.c (list_processes_1, create_pty, read_process_output):
8340 (exec_sentinel): Remove vars that were set but not used.
afd4052b 8341 (create_pty): Remove unnecessary "volatile"s.
bc57d757 8342 (Fnetwork_interface_info): Avoid possibility of int overflow.
82eaa333 8343 (read_process_output): Do adaptive read buffering even if carryover.
fe07cdfa 8344 (read_process_output): Simplify nbytes computation if buffered.
aba7731a 8345
fdfc4bf3
PE
8346 * bytecode.c (exec_byte_code): Rename local to avoid shadowing.
8347
fca8fe46 8348 * syntax.c (scan_words): Remove var that was set but not used.
12cbf13f 8349 (update_syntax_table): Use unsigned instead of int.
fca8fe46 8350
06a0259a 8351 * lread.c (lisp_file_lexically_bound_p): Use ints rather than endptrs.
3c346cc3 8352 (lisp_file_lexically_bound_p, read1): Use unsigned instead of int.
e6eb4e9e 8353 (safe_to_load_p): Make the end-of-loop test the inverse of the in-loop.
06a0259a 8354
e7b9e80f
PE
8355 * print.c (print_error_message): Avoid int overflow.
8356
56201685
PE
8357 * font.c (font_list_entities): Redo for clarity,
8358 so that reader need not know FONT_DPI_INDEX + 1 == FONT_SPACING_INDEX.
8359
78834453 8360 * font.c (font_find_for_lface, Ffont_get_glyphs): Remove unused vars.
790771b1 8361 (font_score): Avoid potential overflow in diff calculation.
78834453 8362
0bc0b309 8363 * fns.c (substring_both): Remove var that is set but not used.
8cd55cb4 8364 (sxhash): Redo loop for clarity and to avoid wraparound warning.
0bc0b309 8365
e610eaca
PE
8366 * eval.c (funcall_lambda): Rename local to avoid shadowing.
8367
b895abce
PE
8368 * alloc.c (mark_object_loop_halt, mark_object): Use size_t, not int.
8369 Otherwise, GCC 4.6.0 optimizes the loop check away since the check
8370 can always succeed if overflow has undefined behavior.
8371
1f1d9321 8372 * search.c (boyer_moore, wordify): Remove vars set but not used.
6f076cc7 8373 (wordify): Omit three unnecessary tests.
1f1d9321 8374
c59478bc
PE
8375 * indent.c (MULTIBYTE_BYTES_WIDTH): Don't compute wide_column.
8376 All callers changed. This avoids the need for an unused var.
8377
79b73827
PE
8378 * casefiddle.c (casify_region): Remove var that is set but not used.
8379
a4db5dfe
PE
8380 * dired.c (file_name_completion): Remove var that is set but not used.
8381
43aae36e
PE
8382 * fileio.c (Finsert_file_contents): Make EOF condition clearer.
8383
2a47c44d 8384 * fileio.c (Finsert_file_contents): Avoid signed integer overflow.
163c5f32 8385 (Finsert_file_contents): Remove unnecessary code checking fd.
2a47c44d 8386
a37c69bf
PE
8387 * minibuf.c (read_minibuf_noninteractive): Use size_t for sizes.
8388 Check for integer overflow on size calculations.
8389
328ab8e7
PE
8390 * buffer.c (Fprevious_overlay_change): Remove var that is set
8391 but not used.
8392
e5a2a5cb
PE
8393 * keyboard.c (menu_bar_items, read_char_minibuf_menu_prompt):
8394 Remove vars that are set but not used.
8d84a6eb 8395 (timer_check_2): Don't assume timer-list and idle-timer-list are lists.
6b043475 8396 (timer_check_2): Mark vars as initialized.
e5a2a5cb 8397
a60e5f68
PE
8398 * gtkutil.c (xg_get_file_with_chooser): Mark var as initialized.
8399
f661cb61 8400 * image.c (lookup_image): Remove var that is set but not used.
35fa624f 8401 (xbm_load): Use parse_p, for gcc -Werror=unused-but-set-variable.
f661cb61 8402
f0397f5a
PE
8403 * fontset.c (Finternal_char_font, Ffontset_info): Remove vars
8404 that are set but not used.
8405
8664db06 8406 * xfns.c (make_invisible_cursor): Don't return garbage
03733ee7 8407 if XCreateBitmapFromData fails (Bug#8410).
8664db06 8408
6abdaa4a
PE
8409 * xselect.c (x_get_local_selection, x_handle_property_notify):
8410 Remove vars that are set but not used.
8411
0ce7538d 8412 * xfns.c (x_create_tip_frame): Remove var that is set but not used.
6abdaa4a 8413 (make_invisible_cursor): Initialize a possibly-uninitialized variable.
0ce7538d 8414
9ae848fc
PE
8415 * xterm.c (x_scroll_bar_to_input_event) [!USE_GTK]:
8416 Remove var that is set but not used.
0b918413
PE
8417 (scroll_bar_windows_size): Now size_t, not int.
8418 (x_send_scroll_bar_event): Use size_t, not int, for sizes.
8419 Check for overflow.
9ae848fc 8420
a5a62657
PE
8421 * xfaces.c (realize_named_face): Remove vars that are set but not used.
8422 (map_tty_color) [!defined MSDOS]: Likewise.
8423
5c5cdd39
PE
8424 * term.c (tty_write_glyphs): Use size_t; this avoids overflow warning.
8425
66ebf983
PE
8426 * coding.c: Remove vars that are set but not used.
8427 (DECODE_COMPOSITION_RULE): Remove 2nd arg, which is unused.
8428 All callers changed.
8429 (decode_coding_utf_8, decode_coding_utf_16 decode_coding_emacs_mule):
8430 (decode_coding_iso_2022, encode_coding_sjis, encode_coding_big5):
8431 (decode_coding_charset): Remove vars that are set but not used.
8432
1be4d761
PE
8433 * bytecode.c (Fbyte_code) [!defined BYTE_CODE_SAFE]: Remove var
8434 that is set but not used.
8435
47553fa8
PE
8436 * print.c (print_object): Remove var that is set but not used.
8437
1f7196bf 8438 Replace 2 copies of readlink code with 1 gnulib version (Bug#8401).
d1fdcab7
PE
8439 The gnulib version avoids calling malloc in the usual case,
8440 and on 64-bit hosts doesn't have some arbitrary 32-bit limits.
8441 * fileio.c (Ffile_symlink_p): Use emacs_readlink.
8442 * filelock.c (current_lock_owner): Likewise.
8443 * lisp.h (READLINK_BUFSIZE, emacs_readlink): New function.
8444 * sysdep.c: Include allocator.h, careadlinkat.h.
8445 (emacs_no_realloc_allocator): New static constant.
8446 (emacs_readlink): New function.
fdb61804
PE
8447 * deps.mk (sysdep.o): Depend on ../lib/allocator.h and on
8448 ../lib/careadlinkat.h.
d1fdcab7 8449
f84c17c7
SM
84502011-04-04 Stefan Monnier <monnier@iro.umontreal.ca>
8451
8452 * keyboard.c (safe_run_hook_funcall): Fix last change (don't stop at the
8453 first non-nil return value).
8454
ef3862ad
JD
84552011-04-03 Jan Djärv <jan.h.d@swipnet.se>
8456
8457 * nsterm.m (ns_update_auto_hide_menu_bar): Define MAC_OS_X_VERSION_10_6
8458 if not defined (Bug#8403).
8459
376a7006
JB
84602011-04-02 Juanma Barranquero <lekktu@gmail.com>
8461
8462 * xdisp.c (display_count_lines): Remove parameter `start',
8463 unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8464 (get_char_face_and_encoding): Remove parameter `multibyte_p',
8465 unused since 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8466 (fill_stretch_glyph_string): Remove parameters `row' and `area',
8467 unused at least since Kim's GUI unification at 2003-03-16T20:45:46Z!storm@cua.dk
8468 and thereabouts. All callers changed.
8469 (get_per_char_metric): Remove parameter `f', unused since
8470 2008-05-14T01:40:23Z!handa@m17n.org. All callers changed.
8471
6ca3801d
JM
84722011-04-02 Jim Meyering <meyering@redhat.com>
8473
8474 do not dereference NULL upon failed strdup
8475 * nsfont.m (ns_descriptor_to_entity): Use xstrdup, not strdup.
8476 (ns_get_family): Likewise.
8477
d8e2b5ba
JB
84782011-04-02 Juanma Barranquero <lekktu@gmail.com>
8479
8480 * eval.c (unwind_to_catch) [DEBUG_GCPRO]: Remove redundant assignment.
8481
8c74fcbd
JD
84822011-04-02 Jan Djärv <jan.h.d@swipnet.se>
8483
8484 * nsterm.m (ns_update_auto_hide_menu_bar): Only for OSX 10.6 or
8485 later (Bug#8403).
8486
7200d79c
SM
84872011-04-01 Stefan Monnier <monnier@iro.umontreal.ca>
8488
03408648 8489 Add lexical binding.
7200d79c 8490
03408648
SM
8491 * window.c (Ftemp_output_buffer_show): New fun.
8492 (Fsave_window_excursion):
8493 * print.c (Fwith_output_to_temp_buffer): Move to subr.el.
8494
8495 * lread.c (lisp_file_lexically_bound_p): New function.
8496 (Fload): Bind Qlexical_binding.
8497 (readevalloop): Remove `evalfun' arg.
8498 Bind Qinternal_interpreter_environment.
8499 (Feval_buffer): Bind Qlexical_binding.
8500 (defvar_int, defvar_bool, defvar_lisp_nopro, defvar_kboard):
8501 Mark as dynamic.
8502 (syms_of_lread): Declare `lexical-binding'.
8503
8504 * lisp.h (struct Lisp_Symbol): New field `declared_special'.
8505
8506 * keyboard.c (eval_dyn): New fun.
8507 (menu_item_eval_property): Use it.
ca105506
SM
8508
8509 * image.c (parse_image_spec): Use Ffunctionp.
ca105506 8510
03408648
SM
8511 * fns.c (concat, mapcar1): Accept byte-code-functions.
8512
8513 * eval.c (Fsetq): Handle lexical vars.
8514 (Fdefun, Fdefmacro, Ffunction): Make closures when needed.
8515 (Fdefconst, Fdefvaralias, Fdefvar): Mark as dynamic.
8516 (FletX, Flet): Obey lexical binding.
8517 (Fcommandp): Handle closures.
8518 (Feval): New `lexical' arg.
8519 (eval_sub): New function extracted from Feval. Use it almost
8520 everywhere where Feval was used. Look up vars in lexical env.
8521 Handle closures.
8522 (Ffunctionp): Move from subr.el.
8523 (Ffuncall): Handle closures.
8524 (apply_lambda): Remove `eval_flags'.
8525 (funcall_lambda): Handle closures and new byte-code-functions.
8526 (Fspecial_variable_p): New function.
8527 (syms_of_eval): Initialize the Vinternal_interpreter_environment var,
8528 but without exporting it to Lisp.
23aba0ea 8529
23aba0ea 8530 * doc.c (Fdocumentation, store_function_docstring):
03408648 8531 * data.c (Finteractive_form): Handle closures.
23aba0ea 8532
03408648
SM
8533 * callint.c (Fcall_interactively): Preserve lexical-binding mode for
8534 interactive spec.
ba83908c 8535
04f2d78b
CB
8536 * bytecode.c (Bstack_ref, Bstack_set, Bstack_set2, BdiscardN):
8537 New byte-codes.
03408648
SM
8538 (exec_byte_code): New function extracted from Fbyte_code to handle new
8539 calling convention for byte-code-functions. Add new byte-codes.
ba83908c 8540
03408648 8541 * buffer.c (defvar_per_buffer): Set new `declared_special' field.
e2abe5a1 8542
03408648 8543 * alloc.c (Fmake_symbol): Init new `declared_special' field.
e2abe5a1 8544
e2abce01
JB
85452011-03-31 Juanma Barranquero <lekktu@gmail.com>
8546
8547 * xdisp.c (redisplay_internal): Fix prototype.
8548
63696a73 85492011-03-31 Eli Zaretskii <eliz@gnu.org>
09725d26 8550
63696a73 8551 * xdisp.c (SCROLL_LIMIT): New macro.
04f2d78b
CB
8552 (try_scrolling): Use it when setting scroll_limit.
8553 Limit scrolling to 100 screen lines.
63696a73
EZ
8554 (redisplay_window): Even when falling back on "recentering",
8555 position point in the window according to scroll-conservatively,
8556 scroll-margin, and scroll-*-aggressively variables. (Bug#6671)
8557
8558 (try_scrolling): When point is above the window, allow searching
8559 as far as scroll_max, or one screenful, to compute vertical
8560 distance from PT to the scroll margin position. This prevents
8561 try_scrolling from unnecessarily failing when
8562 scroll-conservatively is set to a value slightly larger than the
8563 window height. Clean up the case of PT below the margin at bottom
8564 of window: scroll_max can no longer be INT_MAX. When aggressive
8565 scrolling is in use, don't let point enter the opposite scroll
8566 margin as result of the scroll.
8567 (syms_of_xdisp) <scroll-conservatively>: Document the
09725d26
EZ
8568 threshold of 100 lines for never-recentering scrolling.
8569
e4cc2dfc
JB
85702011-03-31 Juanma Barranquero <lekktu@gmail.com>
8571
8572 * dispextern.h (move_it_by_lines):
8573 * xdisp.c (move_it_by_lines): Remove parameter `need_y_p', unused
8574 since 2000-12-29T14:24:09Z!gerd@gnu.org. All callers changed.
8575 (message_log_check_duplicate): Remove parameters `prev_bol' and
8576 `this_bol', unused since 1998-01-01T02:27:27Z!rms@gnu.org. All callers changed.
8577 (redisplay_internal): Remove parameter `preserve_echo_area',
8578 unused since 1999-07-21T21:43:52Z!gerd@gnu.org. All callers changed.
8579
8580 * indent.c (Fvertical_motion):
8581 * window.c (window_scroll_pixel_based, Frecenter):
8582 Don't pass `need_y_p' to `move_it_by_lines'.
8583
1c470562
SM
85842011-03-30 Stefan Monnier <monnier@iro.umontreal.ca>
8585
44f230aa
SM
8586 * eval.c (struct backtrace): Don't cheat with negative numbers, but do
8587 steal a few bits to be more compact.
8588 (interactive_p, Fbacktrace, Fbacktrace_frame, mark_backtrace):
8589 Remove unneeded casts.
8590
1c470562
SM
8591 * bytecode.c (Fbyte_code): CAR and CDR can GC.
8592
888adce9
ZK
85932011-03-30 Zachary Kanfer <zkanfer@gmail.com> (tiny change)
8594
8595 * keyboard.c (Fexecute_extended_command): Do log the "suggest key
8596 binding" message (bug#7967).
8597
f838ed7b
PE
85982011-03-30 Paul Eggert <eggert@cs.ucla.edu>
8599
77861b95
PE
8600 Fix more problems found by GCC 4.6.0's static checks.
8601
de6dbc14
PE
8602 * unexelf.c (unexec) [! (defined _SYSTYPE_SYSV || defined __sgi)]:
8603 Remove unused local var.
8604
f838ed7b
PE
8605 * editfns.c (Fmessage_box): Remove unused local var.
8606
792c7b2b
PE
8607 * xdisp.c (try_window_reusing_current_matrix, x_produce_glyphs):
8608 (note_mode_line_or_margin_highlight, note_mouse_highlight):
8609 Omit unused local vars.
c499e557 8610 * window.c (shrink_windows): Omit unused local var.
b01a1c29 8611 * menu.c (digest_single_submenu): Omit unused local var.
0bc32927
PE
8612 * dispnew.c (update_window) [PERIODIC_PREEMPTION_CHECKING]:
8613 Omit unused local var.
8614
ba0165e1
PE
8615 * keyboard.c (parse_modifiers_uncached, parse_modifiers):
8616 Don't assume string length fits in int.
32ad8845 8617 (keyremap_step, read_key_sequence): Use size_t for sizes.
48011560 8618 (read_key_sequence): Don't check last_real_key_start redundantly.
ba0165e1 8619
3c59b4c9
PE
8620 * callproc.c (Fcall_process, Fcall_process_region): Use SAFE_ALLOCA
8621 instead of alloca (Bug#8344).
8622
a3eed478 8623 * eval.c (Fbacktrace): Don't assume nargs fits in int.
5d5d959d 8624 (Fbacktrace_frame): Don't assume nframes fits in int.
a3eed478 8625
eb4d412d
PE
8626 * syntax.c (scan_sexps_forward): Avoid pointer wraparound.
8627
1658b401
PE
8628 * xterm.c (x_make_frame_visible, same_x_server): Redo to avoid overflow
8629 concerns.
8630
8631 * term.c (produce_glyphless_glyph): Remove unnecessary test.
8632
8633 * cm.c (calccost): Turn while-do into do-while, for clarity.
44f730c8 8634
9a2c6e05
PE
8635 * keyboard.c (syms_of_keyboard): Use the same style as later
8636 in this function when indexing through an array. This also
8637 works around GCC bug 48267.
8638
03d0a109
PE
8639 * image.c (tiff_load): Fix off-by-one image count (Bug#8336).
8640
44f730c8
PE
8641 * xselect.c (x_check_property_data): Return correct size (Bug#8335).
8642
fe75f926
PE
8643 * chartab.c (sub_char_table_ref_and_range): Redo for slight
8644 efficiency gain, and to bypass a gcc -Wstrict-overflow warning.
8645
ffa8c828
PE
8646 * keyboard.c, keyboard.h (num_input_events): Now size_t.
8647 This avoids undefined behavior on integer overflow, and is a bit
8648 more convenient anyway since it is compared to a size_t variable.
8649
c5101a77
PE
8650 Variadic C functions now count arguments with size_t, not int.
8651 This avoids an unnecessary limitation on 64-bit machines, which
8652 caused (substring ...) to crash on large vectors (Bug#8344).
8653 * lisp.h (struct Lisp_Subr.function.aMANY): Now takes size_t, not int.
8654 (DEFUN_ARGS_MANY, internal_condition_case_n, safe_call): Likewise.
77861b95 8655 All variadic functions and their callers changed accordingly.
c5101a77
PE
8656 (struct gcpro.nvars): Now size_t, not int. All uses changed.
8657 * data.c (arith_driver, float_arith_driver): Likewise.
8658 * editfns.c (general_insert_function): Likewise.
8659 * eval.c (struct backtrace.nargs, interactive_p)
8660 (internal_condition_case_n, run_hook_with_args, apply_lambda)
8661 (funcall_lambda, mark_backtrace): Likewise.
8662 * fns.c (concat): Likewise.
8663 * frame.c (x_set_frame_parameters): Likewise.
8664 * fns.c (get_key_arg): Now accepts and returns size_t, and returns
8665 0 if not found, not -1. All callers changed.
8666
dd3f25f7
PE
8667 * alloc.c (garbage_collect): Don't assume stack size fits in int.
8668 (stack_copy_size): Now size_t, not int.
8669 (stack_copy, stack_copy_size): Define only if MAX_SAVE_STACK > 0.
8670
461c2ab9
JB
86712011-03-28 Juanma Barranquero <lekktu@gmail.com>
8672
8673 * coding.c (encode_designation_at_bol): Remove parameter `charbuf_end',
8674 unused since 2002-03-01T01:17:24Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8675 All callers changed.
8676
8677 * lisp.h (multibyte_char_to_unibyte):
8678 * character.c (multibyte_char_to_unibyte): Remove parameter `rev_tbl',
8679 unused since 2002-03-01T01:16:34Z!handa@m17n.org and 2008-02-01T16:01:31Z!miles@gnu.org.
8680 * character.h (CHAR_TO_BYTE8):
8681 * cmds.c (internal_self_insert):
8682 * editfns.c (general_insert_function):
8683 * keymap.c (push_key_description):
8684 * search.c (Freplace_match):
8685 * xdisp.c (message_dolog, set_message_1): All callers changed.
8686
f6d62986
SM
86872011-03-28 Stefan Monnier <monnier@iro.umontreal.ca>
8688
8689 * keyboard.c (safe_run_hook_funcall): New function.
8690 (safe_run_hooks_1, safe_run_hooks_error, safe_run_hooks): On error,
8691 don't set the hook to nil, but remove the offending function instead.
8692 (Qcommand_hook_internal): Remove, unused.
8693 (syms_of_keyboard): Don't initialize Qcommand_hook_internal nor define
8694 Vcommand_hook_internal.
8695
8696 * eval.c (enum run_hooks_condition): Remove.
8697 (funcall_nil, funcall_not): New functions.
8698 (run_hook_with_args): Call each function through a `funcall' argument.
8699 Remove `cond' argument, now redundant.
8700 (Frun_hooks, Frun_hook_with_args, Frun_hook_with_args_until_success)
8701 (Frun_hook_with_args_until_failure): Adjust accordingly.
8702 (run_hook_wrapped_funcall, Frun_hook_wrapped): New functions.
8703
1db5b1ad
JB
87042011-03-28 Juanma Barranquero <lekktu@gmail.com>
8705
8706 * dispextern.h (string_buffer_position): Remove declaration.
8707
8708 * print.c (strout): Remove parameter `multibyte', unused since
8709 1999-08-21T19:30:21Z!gerd@gnu.org. All callers changed.
8710
8711 * search.c (boyer_moore): Remove parameters `len', `pos' and `lim',
8712 never used since function introduction in 1998-02-08T21:33:56Z!rms@gnu.org.
8713 All callers changed.
8714
8715 * w32.c (_wsa_errlist): Use braces for struct initializers.
8716
8717 * xdisp.c (string_buffer_position_lim): Remove parameter `w',
8718 never used since function introduction in 2001-03-09T18:41:50Z!gerd@gnu.org.
8719 All callers changed.
8720 (string_buffer_position): Likewise. Also, make static (it's never
8721 used outside xdisp.c).
8722 (cursor_row_p): Remove parameter `w', unused since
8723 2000-10-17T16:08:57Z!gerd@gnu.org. All callers changed.
8724 (decode_mode_spec): Remove parameter `precision', introduced during
8725 Gerd Moellmann's rewrite at 1999-07-21T21:43:52Z!gerd@gnu.org, but never used.
8726 All callers changed.
8727
5ffb62aa
JD
87282011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8729
8730 * nsterm.m (syms_of_nsterm): Use doc: for ns-auto-hide-menu-bar.
8731
461c2ab9 87322011-03-27 Anders Lindgren <andlind@gmail.com>
f0a1382a
JD
8733
8734 * nsterm.m (ns_menu_bar_is_hidden): New variable.
8735 (ns_constrain_all_frames, ns_menu_bar_should_be_hidden)
8736 (ns_update_auto_hide_menu_bar): New functions.
8737 (ns_update_begin): Call ns_update_auto_hide_menu_bar.
8738 (applicationDidBecomeActive): Call ns_update_auto_hide_menu_bar and
8739 ns_constrain_all_frames.
8740 (constrainFrameRect): Return at once if ns_menu_bar_should_be_hidden.
8741 (syms_of_nsterm): DEFVAR ns-auto-hide-menu-bar, init to Qnil.
8742
5c380ffb
JD
87432011-03-27 Jan Djärv <jan.h.d@swipnet.se>
8744
8745 * nsmenu.m (runDialogAt): Remove argument to timer_check.
8746
9af30bdf
GM
87472011-03-27 Glenn Morris <rgm@gnu.org>
8748
8749 * syssignal.h: Replace RETSIGTYPE with void.
8750 * atimer.c, data.c, dispnew.c, emacs.c, floatfns.c, keyboard.c:
8751 * keyboard.h, lisp.h, process.c, sysdep.c, xterm.c:
8752 Replace SIGTYPE with void everywhere.
8753 * s/usg5-4-common.h (SIGTYPE): Remove definition.
8754 * s/template.h (SIGTYPE): Remove commented out definition.
8755
e2abce01
JB
87562011-03-26 Eli Zaretskii <eliz@gnu.org>
8757
8758 * xdisp.c (redisplay_window): Don't check buffer's clip_changed
8759 flag as a prerequisite for invoking try_scrolling. (Bug#6671)
8760
f868cd8a
JB
87612011-03-26 Juanma Barranquero <lekktu@gmail.com>
8762
59eb0929
JB
8763 * w32.c (read_unc_volume): Use parameter `henum', instead of
8764 global variable `wget_enum_handle'.
8765
8766 * keymap.c (describe_vector): Remove parameters `indices' and
8767 `char_table_depth', unused since 2002-03-01T01:43:26Z!handa@m17n.org.
8768 (describe_map, Fdescribe_vector): Adjust calls to `describe_vector'.
8769
f868cd8a
JB
8770 * keyboard.h (timer_check, show_help_echo): Remove unused parameters.
8771
8772 * keyboard.c (timer_check): Remove parameter `do_it_now',
8773 unused since 1996-04-12T06:01:29Z!rms@gnu.org.
8774 (show_help_echo): Remove parameter `ok_to_overwrite_keystroke_echo',
8775 unused since 2008-04-19T19:30:53Z!monnier@iro.umontreal.ca.
8776
8777 * keyboard.c (read_char):
8778 * w32menu.c (w32_menu_display_help):
8779 * xmenu.c (show_help_event, menu_help_callback):
8780 Adjust calls to `show_help_echo'.
8781
8782 * gtkutil.c (xg_maybe_add_timer):
8783 * keyboard.c (readable_events):
8784 * process.c (wait_reading_process_output):
8785 * xmenu.c (x_menu_wait_for_event): Adjust calls to `timer_check'.
8786
8787 * insdel.c (adjust_markers_gap_motion):
8788 Remove; no-op since 1998-01-02T21:29:48Z!rms@gnu.org.
8789 (gap_left, gap_right): Don't call it.
8790
2ecf6fdb
CY
87912011-03-25 Chong Yidong <cyd@stupidchicken.com>
8792
8793 * xdisp.c (handle_fontified_prop): Discard changes to clip_changed
8794 incurred during fontification.
8795
6b1f9ba4
JB
87962011-03-25 Juanma Barranquero <lekktu@gmail.com>
8797
8798 * buffer.c (defvar_per_buffer): Remove unused parameter `doc'.
8799 (DEFVAR_PER_BUFFER): Don't pass it.
8800
8801 * dispnew.c (row_equal_p, add_row_entry): Remove unused parameter `w'.
8802 (scrolling_window): Don't pass it.
8803
0f4a96b5
JB
88042011-03-25 Juanma Barranquero <lekktu@gmail.com>
8805
8806 * dispextern.h (glyph_matric): Use #if GLYPH_DEBUG, not #ifdef.
8807
8808 * fileio.c (check_executable) [DOS_NT]: Remove unused variables `len'
8809 and `suffix'.
8810 (Fset_file_selinux_context) [HAVE_LIBSELINUX]: Move here declaration
8811 of variables specific to SELinux and computation of `encoded_absname'.
8812
8813 * image.c (XPutPixel): Remove unused variable `height'.
8814
8815 * keyboard.c (make_lispy_event): Remove unused variable `hpos'.
8816
8817 * unexw32.c (get_section_info): Remove unused variable `section'.
8818
8819 * w32.c (stat): Remove unused variables `drive_root' and `devtype'.
8820 (system_process_attributes): Remove unused variable `sess'.
8821 (sys_read): Remove unused variable `err'.
8822
8823 * w32fns.c (top): Wrap variables with #if GLYPH_DEBUG, not #ifdef.
8824 (w32_wnd_proc): Remove unused variable `isdead'.
8825 (unwind_create_frame): Use #if GLYPH_DEBUG, not #ifdef.
8826 (Fx_server_max_request_size): Remove unused variable `dpyinfo'.
8827 (x_create_tip_frame): Remove unused variable `tem'.
8828
8829 * w32inevt.c (w32_console_read_socket):
8830 Remove unused variable `no_events'.
8831
8832 * w32term.c (x_draw_composite_glyph_string_foreground):
8833 Remove unused variable `width'.
8834
1149507c
JB
88352011-03-24 Juanma Barranquero <lekktu@gmail.com>
8836
8837 * w32term.c (x_set_glyph_string_clipping):
8838 Don't pass uninitialized region to CombineRgn.
8839
9c88f339
JB
88402011-03-23 Juanma Barranquero <lekktu@gmail.com>
8841
8842 * w32fns.c (x_set_menu_bar_lines): Remove unused variable `olines'.
8843 (w32_wnd_proc): Pass NULL to Windows API, not uninitialized buffer.
8844 (Fx_close_connection): Remove unused variable `i'.
8845
8846 * w32font.c (w32font_draw): Return number of glyphs.
8847 (w32font_open_internal): Remove unused variable `i'.
8848 (w32font_driver): Add missing initializer.
8849
8850 * w32menu.c (utf8to16): Remove unused variable `utf16'.
8851 (fill_in_menu): Remove unused variable `items_added'.
8852
8853 * w32term.c (last_mouse_press_frame): Remove static global variable.
8854 (w32_clip_to_row): Remove unused variable `f'.
8855 (x_delete_terminal): Remove unused variable `i'.
8856
8857 * w32uniscribe.c (uniscribe_shape): Remove unused variable `nclusters'.
8858 (NOTHING): Remove unused static global variable.
8859 (uniscribe_check_otf): Remove unused variable `table'.
8860 (uniscribe_font_driver): Add missing initializers.
8861
dee091a3
JD
88622011-03-23 Julien Danjou <julien@danjou.info>
8863
8864 * term.c (Fsuspend_tty, Fresume_tty):
8865 * minibuf.c (read_minibuf, run_exit_minibuf_hook):
8866 * window.c (temp_output_buffer_show):
8867 * insdel.c (signal_before_change):
8868 * frame.c (Fhandle_switch_frame):
8869 * fileio.c (Fdo_auto_save):
8870 * emacs.c (Fkill_emacs):
8871 * editfns.c (save_excursion_restore):
8872 * cmds.c (internal_self_insert):
8873 * callint.c (Fcall_interactively):
8874 * buffer.c (Fkill_all_local_variables):
8875 * keyboard.c (Fcommand_execute, Fsuspend_emacs, safe_run_hooks_1):
8876 Use Frun_hooks.
0f4a96b5 8877 (command_loop_1): Use Frun_hooks. Call safe_run_hooks
e9fce1ac 8878 unconditionally since it does the check itself.
dee091a3 8879
2c520ab5 88802011-03-23 Paul Eggert <eggert@cs.ucla.edu>
f0641eff 8881
c9c49752
PE
8882 Fix more problems found by GCC 4.5.2's static checks.
8883
8abc3f12
PE
8884 * coding.c (encode_coding_raw_text): Avoid unnecessary test
8885 the first time through the loop, since we know p0 < p1 then.
8886 This also avoids a gcc -Wstrict-overflow warning.
8887
a2d26660
PE
8888 * lisp.h (SAFE_ALLOCA, SAFE_ALLOCA_LISP): Avoid 'int' overflow
8889 leading to a memory leak, possible in functions like
8890 load_charset_map_from_file that can allocate an unbounded number
b12ef411 8891 of objects (Bug#8318).
a2d26660 8892
916c72e9
PE
8893 * xmenu.c (set_frame_menubar): Use EMACS_UINT, not int, for indexes
8894 that could (at least in theory) be that large.
8895
19ab8a18
PE
8896 * xdisp.c (message_log_check_duplicate): Return unsigned long, not int.
8897 This is less likely to overflow, and avoids undefined behavior if
8898 overflow does occur. All callers changed. Use strtoul to scan
8899 for the unsigned long integer.
b7cbbd6f
PE
8900 (pint2hrstr): Simplify and tune code slightly.
8901 This also avoids a (bogus) GCC warning with gcc -Wstrict-overflow.
19ab8a18 8902
f0641eff
PE
8903 * scroll.c (do_scrolling): Work around GCC bug 48228.
8904 See <http://gcc.gnu.org/bugzilla/show_bug.cgi?id=48228>.
8905
7f650bb9
PE
8906 * frame.c (Fmodify_frame_parameters): Simplify loop counter.
8907 This also avoids a warning with gcc -Wstrict-overflow.
39f5e519
PE
8908 (validate_x_resource_name): Simplify count usage.
8909 This also avoids a warning with gcc -Wstrict-overflow.
7f650bb9 8910
37dd57d1
PE
8911 * fileio.c (Fcopy_file): Report error if fchown or fchmod
8912 fail (Bug#8306).
81e56e61 8913
699979fc 8914 * emacs.c (Fdaemon_initialized): Do not ignore I/O errors (Bug#8303).
dc1ca6a8 8915
401bf9b4
PE
8916 * process.c (Fmake_network_process): Use socklen_t, not int,
8917 where POSIX says socklen_t is required in portable programs.
8918 This fixes a porting bug on hosts like 64-bit HP-UX, where
591b2973 8919 socklen_t is wider than int (Bug#8277).
401bf9b4
PE
8920 (Fmake_network_process, server_accept_connection):
8921 (wait_reading_process_output, read_process_output):
8922 Likewise.
8923
b93aacde
PE
8924 * process.c: Rename or move locals to avoid shadowing.
8925 (list_processes_1, Fmake_network_process):
8926 (read_process_output_error_handler, exec_sentinel_error_handler):
8927 Rename or move locals.
4dc343ee 8928 (Fmake_network_process): Define label "retry_connect" only if needed.
0da49335 8929 (Fnetwork_interface_info): Fix pointer signedness.
f990b4e5 8930 (process_send_signal): Add cast to avoid pointer signedness problem.
7b808126 8931 (FIRST_PROC_DESC, IF_NON_BLOCKING_CONNECT): Remove unused macros.
c939f91b 8932 (create_process): Use 'volatile' to avoid vfork clobbering (Bug#8298).
b93aacde 8933
af8a867c 8934 Make tparam.h and terminfo.c consistent.
44f230aa
SM
8935 * cm.c (tputs, tgoto, BC, UP): Remove extern decls.
8936 Include tparam.h instead, since it declares them.
af8a867c
PE
8937 * cm.h (PC): Remove extern decl; tparam.h now does this.
8938 * deps.mk (cm.o, terminfo.o): Depend on tparam.h.
8939 * terminfo.c: Include tparam.h, to check interfaces.
8940 (tparm): Make 1st arg a const pointer in decl. Put it at top level.
8941 (tparam): Adjust signature to match interface in tparam.h;
8942 this removes some undefined behavior. Check that outstring and len
8943 are zero, which they always are with Emacs.
8944 * tparam.h (PC, BC, UP): New extern decls.
8945
0248044d 8946 * xftfont.c (xftfont_shape): Now static, and defined only if needed.
001a7ab4 8947 (xftfont_open): Rename locals to avoid shadowing.
0248044d 8948
8ff096c1 8949 * ftfont.c (ftfont_resolve_generic_family): Fix pointer signedness.
a00924bb
PE
8950 (ftfont_otf_capability, ftfont_shape): Omit decls if not needed.
8951 (OTF_TAG_SYM): Omit macro if not needed.
e932860f 8952 (ftfont_list): Remove unused local.
49eaafba
PE
8953 (get_adstyle_property, ftfont_pattern_entity):
8954 (ftfont_lookup_cache, ftfont_open, ftfont_anchor_point):
8955 Rename locals to avoid shadowing.
8ff096c1 8956
e2be39f6
PE
8957 * xfont.c (xfont_list_family): Mark var as initialized.
8958
c9735e30
PE
8959 * xml.c (make_dom): Now static.
8960
8f5201ae
PE
8961 * composite.c (composition_compute_stop_pos): Rename local to
8962 avoid shadowing.
b246f932
PE
8963 (composition_reseat_it): Remove unused locals.
8964 (find_automatic_composition, composition_adjust_point): Likewise.
80e079b2 8965 (composition_update_it): Mark var as initialized.
11b61122
PE
8966 (find_automatic_composition): Mark vars as initialized,
8967 with a FIXME (Bug#8290).
8f5201ae 8968
760fbc2c
PE
8969 character.h: Rename locals to avoid shadowing.
8970 * character.h (PREV_CHAR_BOUNDARY, FETCH_STRING_CHAR_ADVANCE):
8971 (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE, FETCH_CHAR_ADVANCE):
8972 (FETCH_CHAR_ADVANCE_NO_CHECK, INC_POS, DEC_POS, BUF_INC_POS):
8973 (BUF_DEC_POS): Be more systematic about renaming local temporaries
8974 to avoid shadowing.
8975
ff08eb85
PE
8976 * textprop.c (property_change_between_p): Remove; unused.
8977
fc7bf025
PE
8978 * intervals.c (interval_start_pos): Now static.
8979
235d7abc
PE
8980 * intervals.h (CHECK_TOTAL_LENGTH): Avoid empty "else".
8981
44f230aa
SM
8982 * atimer.c (start_atimer, append_atimer_lists, set_alarm):
8983 Rename locals to avoid shadowing.
3e7d6594 8984
50060332
PE
8985 * sound.c (wav_play, au_play, Fplay_sound_internal):
8986 Fix pointer signedness.
d01f234b 8987 (alsa_choose_format): Remove unused local var.
c83b8872
PE
8988 (wav_play): Initialize a variable to 0, to prevent undefined
8989 behavior (Bug#8278).
50060332 8990
c4fc4e30
PE
8991 * region-cache.c (insert_cache_boundary): Redo var to avoid shadowing.
8992
918436ed
PE
8993 * region-cache.h (pp_cache): New decl, for gcc -Wmissing-prototypes.
8994
c939f91b
PE
8995 * callproc.c (Fcall_process): Use 'volatile' to avoid vfork
8996 clobbering (Bug#8298).
b9c7f648
PE
8997 * sysdep.c (sys_subshell): Likewise.
8998 Previously, the sys_subshell 'volatile' was incorrectly IF_LINTted out.
7e9123a2 8999
6bd8c144
PE
9000 * lisp.h (child_setup): Now NO_RETURN unless DOS_NT.
9001 This should get cleaned up, so that child_setup has the
9002 same signature on all platforms.
9003
7710357c 9004 * callproc.c (call_process_cleanup): Now static.
cb1d0ef7 9005 (relocate_fd): Rename locals to avoid shadowing.
7710357c 9006
c59da222
CY
90072011-03-22 Chong Yidong <cyd@stupidchicken.com>
9008
9009 * xterm.c (x_clear_frame): Remove XClearWindow call. This appears
9010 not to be necessary, and produces flickering.
9011
66b87493
GM
90122011-03-20 Glenn Morris <rgm@gnu.org>
9013
9014 * config.in: Remove file.
9015
45b6f6d5
JB
90162011-03-20 Juanma Barranquero <lekktu@gmail.com>
9017
9018 * minibuf.c (Vcompleting_read_function): Don't declare, global variables
9019 are now in src/globals.h.
9020 (syms_of_minibuf): Remove spurious & from previous change.
9021
cd394be1 90222011-03-20 Leo Liu <sdl.web@gmail.com>
3ec03f7e
LL
9023
9024 * minibuf.c (completing-read-function): New variable.
9025 (completing-read-default): Rename from completing-read.
9026 (completing-read): Call completing-read-function.
9027
b14e3e21
CY
90282011-03-19 Juanma Barranquero <lekktu@gmail.com>
9029
9030 * xfaces.c (Fx_load_color_file):
9031 Read color file from absolute filename (bug#8250).
9032
f2b726e6
JB
90332011-03-19 Juanma Barranquero <lekktu@gmail.com>
9034
9035 * makefile.w32-in: Update dependencies.
9036
09f6ff02
EZ
90372011-03-17 Eli Zaretskii <eliz@gnu.org>
9038
9039 * makefile.w32-in ($(BLD)/unexw32.$(O)): Depend on $(SRC)/unexec.h.
9040
29a6015a
PE
90412011-03-17 Paul Eggert <eggert@cs.ucla.edu>
9042
a3a6c54e
PE
9043 Fix more problems found by GCC 4.5.2's static checks.
9044
b766f867
PE
9045 * process.c (make_serial_process_unwind, send_process_trap):
9046 (sigchld_handler): Now static.
9047
be02381c
PE
9048 * process.c (allocate_pty): Let PTY_ITERATION declare iteration vars.
9049 That way, the code declares only the vars that it needs.
9050 * s/aix4-2.h (PTY_ITERATION): Declare iteration vars.
9051 * s/cygwin.h (PTY_ITERATION): Likewise.
9052 * s/darwin.h (PTY_ITERATION): Likewise.
9053 * s/gnu-linux.h (PTY_ITERATION): Likewise.
9054
57048744
PE
9055 * s/irix6-5.h (PTY_OPEN): Declare stb, to loosen coupling.
9056 * process.c (allocate_pty): Don't declare stb unless it's needed.
9057
7914961c 9058 * bytecode.c (MAYBE_GC): Rewrite so as not to use empty "else".
615f2d59
PE
9059 (CONSTANTLIM): Remove; unused.
9060 (METER_CODE, Bscan_buffer, Bread_char, Bset_mark):
9061 Define only if needed.
7914961c 9062
b3967b18
PE
9063 * unexelf.c (unexec): Name an expression,
9064 to avoid gcc -Wbad-function-cast warning.
9ae71512
PE
9065 Use a different way to cause a compilation error if anyone uses
9066 n rather than nn, a way that does not involve shadowing.
73366a00 9067 (ELF_BSS_SECTION_NAME, OLD_PROGRAM_H): Remove; unused.
b3967b18 9068
29a6015a
PE
9069 * deps.mk (unexalpha.o): Remove; unused.
9070
43cfc33e 9071 New file unexec.h, the (simple) interface for unexec (Bug#8267).
7feda0d2 9072 * unexec.h: New file.
ce701a33
PE
9073 * deps.mk (emacs.o, unexaix.o, unexcw.o, unexcoff.o, unexelf.o):
9074 (unexhp9k800.o, unexmacosx.o, unexsol.o, unexw32.o):
9075 Depend on unexec.h.
9076 * emacs.c [!defined CANNOT_DUMP]: Include unexec.h.
9077 * unexaix.c, unexcoff.c, unexcw.c, unexelf.c, unexhp9k800.c:
9078 * unexmacosx.c, unexsol.c, unexw32.c: Include unexec.h.
381259ef 9079 Change as necessary to match prototype in unexec.h.
ce701a33 9080
01f44d5a
PE
9081 * syntax.c (Fforward_comment, scan_lists): Rename locals to avoid
9082 shadowing.
4f63c6bb 9083 (back_comment, skip_chars): Mark vars as initialized.
01f44d5a 9084
a6670b0b
PE
9085 * character.h (FETCH_STRING_CHAR_ADVANCE_NO_CHECK, BUF_INC_POS):
9086 Rename locals to avoid shadowing.
9087
cef2010d 9088 * lread.c (read1): Rewrite so as not to use empty "else".
0902fe45 9089 (Fload, readevalloop, read1): Rename locals to avoid shadowing.
cef2010d 9090
d4d7173a
PE
9091 * print.c (Fredirect_debugging_output): Fix pointer signedess.
9092
f08b802a
PE
9093 * lisp.h (debug_output_compilation_hack): Add decl here, to avoid
9094 warning when compiling print.c.
9095
3ddb0639
PE
9096 * font.c (font_unparse_fcname): Abort in an "impossible" situation
9097 instead of using an uninitialized var.
5ad03b97 9098 (font_sort_entities): Mark var as initialized.
3ddb0639 9099
170a2692
PE
9100 * character.h (FETCH_CHAR_ADVANCE): Rename locals to avoid shadowing.
9101
e663c700
PE
9102 * font.c (font_unparse_xlfd): Don't mix pointers to variables with
9103 pointers to constants.
89bc529a 9104 (font_parse_fcname): Remove unused vars.
7b81e2d0 9105 (font_delete_unmatched): Now static.
ea838e10 9106 (font_get_spec): Remove; unused.
13a547c6
PE
9107 (font_style_to_value, font_prop_validate_style, font_unparse_fcname):
9108 (font_update_drivers, Ffont_get_glyphs, font_add_log):
9109 Rename or move locals to avoid shadowing.
e663c700 9110
2a80c887 9111 * fns.c (require_nesting_list, require_unwind): Now static.
612f56df 9112 (Ffillarray): Rename locals to avoid shadowing.
2a80c887 9113
1384fa33 9114 * floatfns.c (domain_error2): Define only if needed.
a885e2ed 9115 (Ffrexp, Fldexp): Rename locals to avoid shadowing.
1384fa33 9116
8b2c52e9
PE
9117 * alloc.c (mark_backtrace): Move decl from here ...
9118 * lisp.h: ... to here, so that it can be checked.
9119
475545b5 9120 * eval.c (call_debugger, do_debug_on_call, grow_specpdl): Now static.
d28a2170 9121 (Fdefvar): Rewrite so as not to use empty "else".
cfcbfb1a
PE
9122 (lisp_indirect_variable): Name an expression,
9123 to avoid gcc -Wbad-function-cast warning.
1faed8ae 9124 (Fdefvar): Rename locals to avoid shadowing.
475545b5 9125
b1349114 9126 * callint.c (quotify_arg, quotify_args): Now static.
a3e8cbda 9127 (Fcall_interactively): Rename locals to avoid shadowing.
b0e80955 9128 Use const pointer when appropriate.
b1349114 9129
a2928364
PE
9130 * lisp.h (get_system_name, get_operating_system_release):
9131 Move decls here, to check interfaces.
9132 * process.c (get_operating_system_release): Move decl to lisp.h.
9133 * xrdb.c (get_system_name): Likewise.
63c5d10b
PE
9134 * editfns.c (init_editfns, Fuser_login_name, Fuser_uid):
9135 (Fuser_real_uid, Fuser_full_name): Remove unnecessary casts,
9136 some of which prompt warnings from gcc -Wbad-function-cast.
545b49b4
PE
9137 (Fformat_time_string, Fencode_time, Finsert_char):
9138 (Ftranslate_region_internal, Fformat):
9139 Rename or remove local vars to avoid shadowing.
9710023e 9140 (Ftranslate_region_internal): Mark var as initialized.
63c5d10b 9141
a415e694
PE
9142 * doc.c (Fdocumentation, Fsnarf_documentation): Move locals to
9143 avoid shadowing.
9144
8ef4622d
PE
9145 * lisp.h (eassert): Check that the argument compiles, even if
9146 ENABLE_CHECKING is not defined.
9147
946f9a5b
PE
9148 * data.c (Findirect_variable): Name an expression, to avoid
9149 gcc -Wbad-function-cast warning.
112396d6 9150 (default_value, arithcompare, arith_driver, arith_error): Now static.
b9b84fa9 9151 (store_symval_forwarding): Rename local to avoid shadowing.
44f230aa
SM
9152 (Fmake_variable_buffer_local, Fmake_local_variable):
9153 Mark variables as initialized.
52746918 9154 (do_blv_forwarding, do_symval_forwarding): Remove; unused.
946f9a5b 9155
e5aab7e7 9156 * alloc.c (check_cons_list): Do not define unless GC_CHECK_CONS_LIST.
ae35e756
PE
9157 (Fmake_vector, Fvector, Fmake_byte_code, Fgarbage_collect):
9158 Rename locals to avoid shadowing.
dff45157
PE
9159 (mark_stack): Move local variables into the #ifdef region where
9160 they're used.
7bc26fdb
PE
9161 (BLOCK_INPUT_ALLOC, UNBLOCK_INPUT_ALLOC): Define only if
9162 ! defined SYSTEM_MALLOC && ! defined SYNC_INPUT, as they are not
9163 needed otherwise.
9164 (CHECK_ALLOCATED): Define only if GC_CHECK_MARKED_OBJECTS.
9165 (GC_STRING_CHARS): Remove; not used.
d40d4be1 9166 (Fmemory_limit): Cast sbrk's returned value to char *.
ae35e756 9167
e5aab7e7
PE
9168 * lisp.h (check_cons_list): Declare if GC_CHECK_CONS_LIST; this
9169 avoids undefined behavior in theory.
9170
4da60324
PE
9171 * regex.c (IF_LINT): Add defn, for benefit of ../lib-src.
9172
88043301
PE
9173 Use functions, not macros, for up- and down-casing (Bug#8254).
9174 * buffer.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9175 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Remove. All callers changed
9176 to use the following functions instead of these macros.
9177 (downcase): Adjust to lack of DOWNCASE_TABLE. Return int, not
9178 EMACS_INT, since callers assume the returned value fits in int.
9179 (upcase1): Likewise, for UPCASE_TABLE.
9180 (uppercasep, lowercasep, upcase): New static inline functions.
0da09c43 9181 * editfns.c (Fchar_equal): Remove no-longer-needed workaround for
db69b0cd 9182 the race-condition problem in the old DOWNCASE.
88043301 9183
19ed5445
PE
9184 * regex.c (CHARSET_LOOKUP_RANGE_TABLE_RAW, POP_FAILURE_REG_OR_COUNT):
9185 Rename locals to avoid shadowing.
9186 (regex_compile, re_match_2_internal): Move locals to avoid shadowing.
abbd1bcf
PE
9187 (regex_compile, re_search_2, re_match_2_internal):
9188 Remove unused local vars.
952db0d7
PE
9189 (FREE_VAR): Rewrite so as not to use empty "else",
9190 which gcc can warn about.
da053e48 9191 (regex_compile, re_match_2_internal): Mark locals as initialized.
b313f9d8
PE
9192 (RETALLOC_IF): Define only if needed.
9193 (WORDCHAR_P): Likewise. This one is never needed, but is used
9194 only in a comment talking about a compiler bug, so put inside
9195 the #if 0 of that comment.
9196 (CHARSET_LOOKUP_BITMAP, FAIL_STACK_FULL, RESET_FAIL_STACK):
9197 (PUSH_FAILURE_ELT, BUF_PUSH_3, STOP_ADDR_VSTRING):
9198 Remove; unused.
19ed5445 9199
1f3561e4 9200 * search.c (boyer_moore): Rename locals to avoid shadowing.
76ef09b7
PE
9201 * character.h (FETCH_STRING_CHAR_AS_MULTIBYTE_ADVANCE):
9202 (PREV_CHAR_BOUNDARY): Likewise.
1f3561e4 9203
ded6f8f7
PE
9204 * search.c (simple_search): Remove unused var.
9205
dbd37a95
PE
9206 * dired.c (compile_pattern): Move decl from here ...
9207 * lisp.h: ... to here, so that it can be checked.
9208 (struct re_registers): New forward decl.
9209
7e47afad
PE
9210 * character.h (INC_POS, DEC_POS): Rename locals to avoid shadowing.
9211
85f24f61
PE
9212 * indent.c (MULTIBYTE_BYTES_WIDTH): New args bytes, width.
9213 All uses changed.
9214 (MULTIBYTE_BYTES_WIDTH, scan_for_column, compute_motion):
9215 Rename locals to avoid shadowing.
5671df8f 9216 (Fvertical_motion): Mark locals as initialized.
85f24f61 9217
181aa2be 9218 * casefiddle.c (casify_object, casify_region): Now static.
e45a141a 9219 (casify_region): Mark local as initialized.
181aa2be 9220
930d429c
PE
9221 * cmds.c (internal_self_insert): Rename local to avoid shadowing.
9222
7082eac6
PE
9223 * lisp.h (GCPRO2_VAR, GCPRO3_VAR, GCPRO4_VAR, GCPRO5_VAR, GCPRO6_VAR):
9224 New macros, so that the caller can use some names other than
9225 gcpro1, gcpro2, etc.
9226 (GCPRO2, GCPRO3, GCPRO4, GCPRO5, GCPRO6): Reimplement in terms
9227 of the new macros.
9228 (GCPRO1_VAR, UNGCPRO_VAR): Change the meaning of the second
9229 argument, for consistency with GCPRO2_VAR, etc: it is now the
9230 prefix of the variable, not the variable itself. All uses
9231 changed.
38b2c076
PE
9232 * dired.c (directory_files_internal, file_name_completion):
9233 Rename locals to avoid shadowing.
9234
15206ed9
PE
9235 Fix a race condition diagnosed by gcc -Wsequence-point (Bug#8254).
9236 An expression of the form (DOWNCASE (x) == DOWNCASE (y)), found in
9237 dired.c's scmp function, had undefined behavior.
9238 * lisp.h (DOWNCASE_TABLE, UPCASE_TABLE, DOWNCASE, UPPERCASEP):
9239 (NOCASEP, LOWERCASEP, UPCASE, UPCASE1): Move from here ...
9240 * buffer.h: ... to here, because these macros use current_buffer,
9241 and the new implementation with inline functions needs to have
9242 current_buffer in scope now, rather than later when the macros
9243 are used.
9244 (downcase, upcase1): New static inline functions.
9245 (DOWNCASE, UPCASE1): Reimplement using these functions.
9246 This avoids undefined behavior in expressions like
9247 DOWNCASE (x) == DOWNCASE (y), which previously suffered
9248 from race conditions in accessing the global variables
9249 case_temp1 and case_temp2.
9250 * casetab.c (case_temp1, case_temp2): Remove; no longer needed.
9251 * lisp.h (case_temp1, case_temp2): Remove their decls.
9252 * character.h (ASCII_CHAR_P): Move from here ...
9253 * lisp.h: ... to here, so that the inline functions mentioned
9254 above can use them.
9255
4a6bea26
PE
9256 * dired.c (directory_files_internal_unwind): Now static.
9257
f14b7e14
PE
9258 * fileio.c (file_name_as_directory, directory_file_name):
9259 (barf_or_query_if_file_exists, auto_save_error, auto_save_1):
9260 Now static.
2893f146
PE
9261 (file_name_as_directory): Use const pointers when appropriate.
9262 (Fexpand_file_name): Likewise. In particular, newdir might
9263 point at constant storage, so make it a const pointer.
fd4ead52 9264 (Fmake_directory_internal, Fread_file_name): Remove unused vars.
b14aac08
PE
9265 (Ffile_selinux_context, Fset_file_selinux_context): Fix pointer
9266 signedness issues.
f839df0c
PE
9267 (Fset_file_times, Finsert_file_contents, auto_save_error):
9268 Rename locals to avoid shadowing.
f14b7e14 9269
5716756e 9270 * minibuf.c (choose_minibuf_frame_1): Now static.
62137a95
PE
9271 (Ftry_completion, Fall_completions): Rename or remove locals
9272 to avoid shadowing.
5716756e 9273
b4c3046a
PE
9274 * marker.c (bytepos_to_charpos): Remove; unused.
9275
b45db522
PE
9276 * lisp.h (verify_bytepos, count_markers): New decls,
9277 so that gcc does not warn that these functions aren't declared.
9278
85876d07
PE
9279 * insdel.c (check_markers, make_gap_larger, make_gap_smaller):
9280 (reset_var_on_error, Fcombine_after_change_execute_1): Now static.
f0cb4a60 9281 (CHECK_MARKERS): Redo to avoid gcc -Wempty-body diagnostic.
40ef059e 9282 (copy_text): Remove unused local var.
85876d07 9283
03d78a21 9284 * filelock.c (within_one_second): Now static.
b3dd38ab 9285 (lock_file_1): Rename local to avoid shadowing.
03d78a21 9286
5df8f01b
PE
9287 * buffer.c (fix_overlays_before): Mark locals as initialized.
9288 (fix_start_end_in_overlays): Likewise. This function should be
9289 simplified by using pointers-to-pointers, but that's a different
9290 matter.
b1d876f1 9291 (switch_to_buffer_1): Now static.
8f54f30a
PE
9292 (Fkill_buffer, record_buffer, Fbury_buffer, Fset_buffer_multibyte):
9293 (report_overlay_modification): Rename locals to avoid shadowing.
c3bd59b5 9294
a70072c9 9295 * sysdep.c (system_process_attributes): Rename vars to avoid shadowing.
fbd02d7b 9296 Fix pointer signedness issue.
edced198
PE
9297 (sys_subshell): Mark local as volatile if checking for lint,
9298 to suppress a gcc -Wclobbered warning that does not seem to be right.
15dfd3d9 9299 (MAXPATHLEN): Define only if needed.
a70072c9 9300
a0977c44
PE
9301 * process.c (serial_open, serial_configure): Move decls from here ...
9302 * systty.h: ... to here, so that they can be checked.
9303
a884fdcc
PE
9304 * fns.c (get_random, seed_random): Move extern decls from here ...
9305 * lisp.h: ... to here, so that they can be checked.
9306
604efe86 9307 * sysdep.c (reset_io): Now static.
b8950c94 9308 (wait_for_termination_signal): Remove; unused.
604efe86 9309
38fc62d9
PE
9310 * keymap.c (keymap_parent, keymap_memberp, map_keymap_internal):
9311 (copy_keymap_item, append_key, push_text_char_description):
9312 Now static.
1004a21a 9313 (Fwhere_is_internal): Don't test CONSP (sequences) unnecessarily.
dbbb8427 9314 (DENSE_TABLE_SIZE): Remove; unused.
c1141155
PE
9315 (get_keymap, access_keymap, Fdefine_key, Fwhere_is_internal):
9316 (describe_map_tree):
9317 Rename locals to avoid shadowing.
38fc62d9 9318
2f2650da
PE
9319 * keyboard.c: Declare functions static if they are not used elsewhere.
9320 (echo_char, echo_dash, cmd_error, top_level_2):
9321 (poll_for_input, handle_async_input): Now static.
69a058fa
PE
9322 (read_char, kbd_buffer_get_event, make_lispy_position):
9323 (make_lispy_event, make_lispy_movement, apply_modifiers):
9324 (decode_keyboard_code, tty_read_avail_input, menu_bar_items):
9325 (parse_tool_bar_item, read_key_sequence, Fread_key_sequence):
9326 (Fread_key_sequence_vector): Rename locals to avoid shadowing.
c8a06054 9327 (read_key_sequence, read_char): Mark locals as initialized.
3ac94672 9328 (Fexit_recursive_edit, Fabort_recursive_edit): Mark with NO_RETURN.
2f2650da 9329
a053e86c 9330 * keyboard.h (make_ctrl_char): New decl.
da2f2dd9
PE
9331 (mark_kboards): Move decl here ...
9332 * alloc.c (mark_kboards): ... from here.
a053e86c 9333
4752793e
PE
9334 * lisp.h (force_auto_save_soon): New decl.
9335
74f10ca7 9336 * emacs.c (init_cmdargs): Rename local to avoid shadowing.
244fc23d
PE
9337 (DEFINE_DUMMY_FUNCTION): New macro.
9338 (__do_global_ctors, __do_global_ctors_aux, __do_global_dtors, __main):
9339 Use it.
c03cd23f
PE
9340 (main): Add casts to avoid warnings
9341 if GCC considers string literals to be constants.
74f10ca7 9342
022e70d4
PE
9343 * lisp.h (fatal_error_signal): Add decl, since it's exported.
9344
59d6fe83
PE
9345 * dbusbind.c: Pointer signedness fixes.
9346 (xd_signature, xd_append_arg, xd_initialize):
9347 (Fdbus_call_method, Fdbus_call_method_asynchronously):
9348 (Fdbus_method_return_internal, Fdbus_method_error_internal):
9349 (Fdbus_send_signal, xd_read_message_1, Fdbus_register_service):
9350 (Fdbus_register_signal): Use SSDATA when the context wants char *.
9351
78320123
PE
9352 * dbusbind.c (Fdbus_init_bus): Add cast to avoid warning
9353 if GCC considers string literals to be constants.
49cebcca 9354 (Fdbus_register_service, Fdbus_register_method): Remove unused vars.
78320123 9355
35ac2a97
SM
93562011-03-16 Stefan Monnier <monnier@iro.umontreal.ca>
9357
fb103ca9
SM
9358 * print.c (PRINT_CIRCLE_CANDIDATE_P): New macro.
9359 (print_preprocess, print_object): New macro to fix last change.
9360
35ac2a97
SM
9361 * print.c (print_preprocess): Don't forget font objects.
9362
62973b41
JB
93632011-03-16 Juanma Barranquero <lekktu@gmail.com>
9364
9365 * emacs.c (USAGE3): Doc fixes.
9366
0e48bb22
AS
93672011-03-15 Andreas Schwab <schwab@linux-m68k.org>
9368
9369 * coding.c (detect_coding_iso_2022): Reorganize code to clarify
9370 structure.
9371
7684e57b
JB
93722011-03-14 Juanma Barranquero <lekktu@gmail.com>
9373
9374 * lisp.h (VWindow_system, Qfile_name_history):
9375 * keyboard.h (lispy_function_keys) [WINDOWSNT]:
9376 * w32term.h (w32_system_caret_hwnd, w32_system_caret_height)
9377 (w32_system_caret_x, w32_system_caret_y): Declare extern.
9378
9379 * w32select.c: Don't #include "keyboard.h".
c96bbc66 9380 (run_protected): Add extern declaration for waiting_for_input.
7684e57b
JB
9381
9382 * w32.c (Qlocal, noninteractive1, inhibit_window_system):
9383 * w32console.c (detect_input_pending, read_input_pending)
9384 (encode_terminal_code):
9385 * w32fns.c (quit_char, lispy_function_keys, Qtooltip)
9386 (w32_system_caret_hwnd, w32_system_caret_height, w32_system_caret_x)
9387 (w32_system_caret_y, Qfile_name_history):
9388 * w32font.c (w32font_driver, QCantialias, QCotf, QClang):
9389 * w32inevt.c (reinvoke_input_signal, lispy_function_keys):
9390 * w32menu.c (Qmenu_bar, QCtoggle, QCradio, Qoverriding_local_map)
9391 (Qoverriding_terminal_local_map, Qmenu_bar_update_hook):
9392 * w32proc.c (Qlocal, report_file_error):
9393 * w32term.c (Vwindow_system, updating_frame):
9394 * w32uniscribe.c (initialized, uniscribe_font_driver):
9395 Remove unneeded extern declarations.
9396
2aa46d6c
CY
93972011-03-14 Chong Yidong <cyd@stupidchicken.com>
9398
c96bbc66 9399 * buffer.c (Fmake_indirect_buffer): Fix incorrect assertions.
2aa46d6c 9400
cffc6f3b
CY
94012011-03-13 Chong Yidong <cyd@stupidchicken.com>
9402
9403 * buffer.h (BUF_BEGV, BUF_BEGV_BYTE, BUF_ZV, BUF_ZV_BYTE, BUF_PT)
9404 (BUF_PT_BYTE): Rewrite to handle indirect buffers (Bug#8219).
9405 These macros can no longer be used for assignment.
9406
44f230aa
SM
9407 * buffer.c (Fget_buffer_create, Fmake_indirect_buffer):
9408 Assign struct members directly, instead of using BUF_BEGV etc.
cffc6f3b
CY
9409 (record_buffer_markers, fetch_buffer_markers): New functions for
9410 recording and fetching special buffer markers.
9411 (set_buffer_internal_1, set_buffer_temp): Use them.
9412
9413 * lread.c (unreadchar): Use SET_BUF_PT_BOTH.
9414
9415 * insdel.c (adjust_point): Use SET_BUF_PT_BOTH.
9416
9417 * intervals.c (temp_set_point_both): Use SET_BUF_PT_BOTH.
9418 (get_local_map): Use SET_BUF_BEGV_BOTH and SET_BUF_ZV_BOTH.
9419
9420 * xdisp.c (hscroll_window_tree):
9421 (reconsider_clip_changes): Use PT instead of BUF_PT.
9422
d251f04b
EZ
94232011-03-13 Eli Zaretskii <eliz@gnu.org>
9424
9425 * makefile.w32-in ($(BLD)/editfns.$(O)): Depend on
9426 $(EMACS_ROOT)/lib/intprops.h.
9427
f0c77cd1
PE
94282011-03-13 Paul Eggert <eggert@cs.ucla.edu>
9429
3eca4629
PE
9430 Fix more problems found by GCC 4.5.2's static checks.
9431
7c86ee98
PE
9432 * gtkutil.c (xg_get_pixbuf_from_pixmap): Add cast from char *
9433 to unsigned char * to avoid compiler diagnostic.
b0afc268
PE
9434 (xg_free_frame_widgets): Make it clear that a local variable is
9435 needed only if USE_GTK_TOOLTIP.
01e0b5ad
PE
9436 (gdk_window_get_screen): Make it clear that this macro is needed
9437 only if USE_GTK_TOOLTIP.
1e5524e7
PE
9438 (int_gtk_range_get_value): New function, which avoids a diagnostic
9439 from gcc -Wbad-function-cast.
9440 (xg_set_toolkit_scroll_bar_thumb): Use it.
9441 (xg_tool_bar_callback, xg_tool_item_stale_p): Rewrite to avoid
9442 diagnostic from gcc -Wbad-function-cast.
65dc836c
PE
9443 (get_utf8_string, xg_get_file_with_chooser):
9444 Rename locals to avoid shadowing.
9445 (create_dialog): Move locals to avoid shadowing.
7c86ee98 9446
41729b81
PE
9447 * xgselect.c (xg_select): Remove unused var.
9448
f0c77cd1
PE
9449 * image.c (four_corners_best): Mark locals as initialized.
9450 (gif_load): Initialize transparent_p to zero (Bug#8238).
9451 Mark another local as initialized.
ec6cf4c6 9452 (my_png_error, my_error_exit): Mark with NO_RETURN.
f0c77cd1 9453
ce0ad53d 9454 * image.c (clear_image_cache): Now static.
d5d5a617 9455 (DIM, HAVE_STDLIB_H_1): Remove unused macros.
e22cffbc 9456 (xpm_load): Redo to avoid "discards qualifiers" gcc warning.
77a765fd
PE
9457 (x_edge_detection): Remove unnecessary cast that
9458 gcc -Wbad-function-cast diagnoses.
2037898d 9459 (gif_load): Fix pointer signedness.
6ae141d6
PE
9460 (clear_image_cache, xbm_read_bitmap_data, x_detect_edges):
9461 (jpeg_load, gif_load): Rename locals to avoid shadowing.
ce0ad53d 9462
33383987 94632011-03-12 Paul Eggert <eggert@cs.ucla.edu>
3eca4629 9464
d32df629
PE
9465 Improve quality of tests for time stamp overflow.
9466 For example, without this patch (encode-time 0 0 0 1 1
9467 1152921504606846976) returns the obviously-bogus value (-948597
9468 62170) on my RHEL 5.5 x86-64 host. With the patch, it correctly
9469 reports time overflow. See
9470 <http://lists.gnu.org/archive/html/emacs-devel/2011-03/msg00470.html>.
b8d9bd41
PE
9471 * deps.mk (editfns.o): Depend on ../lib/intprops.h.
9472 * editfns.c: Include limits.h and intprops.h.
9473 (TIME_T_MIN, TIME_T_MAX): New macros.
9474 (time_overflow): Move earlier, to before first use.
9475 (hi_time, lo_time): New functions, for an accurate test for
9476 out-of-range times.
9477 (Fcurrent_time, Fget_internal_run_time, make_time): Use them.
9478 (Fget_internal_run_time): Don't assume time_t fits in int.
9479 (make_time): Use list2 instead of Fcons twice.
9480 (Fdecode_time): More accurate test for out-of-range times.
9481 (check_tm_member): New function.
9482 (Fencode_time): Use it, to test for out-of-range times.
d32df629
PE
9483 (lisp_time_argument): Don't rely on undefined left-shift and
9484 right-shift behavior when checking for time stamp overflow.
8be6f318 9485
fe31d94c
PE
9486 * editfns.c (time_overflow): New function, refactoring common code.
9487 (Fformat_time_string, Fdecode_time, Fencode_time):
9488 (Fcurrent_time_string): Use it.
9489
8be6f318
PE
9490 Move 'make_time' to be next to its inverse 'lisp_time_argument'.
9491 * dired.c (make_time): Move to ...
9492 * editfns.c (make_time): ... here.
9493 * systime.h: Note the move.
9494
09d9db2c 94952011-03-12 YAMAMOTO Mitsuharu <mituharu@math.s.chiba-u.ac.jp>
c47cbdfd 9496
126bc0dc
YM
9497 * fringe.c (update_window_fringes): Remove unused variables.
9498
c47cbdfd
YM
9499 * unexmacosx.c (copy_data_segment): Also copy __got section.
9500 (Bug#8223)
9501
7ac80be9
EZ
95022011-03-12 Eli Zaretskii <eliz@gnu.org>
9503
c96bbc66 9504 * termcap.c [MSDOS]: Include "msdos.h".
058e5dad
EZ
9505 (find_capability, tgetnum, tgetflag, tgetstr, tputs, tgetent):
9506 Constify `char *' arguments and their references according to
9507 prototypes in tparam.h.
9508
ecb0f94d 9509 * deps.mk (termcap.o): Depend on tparam.h and msdos.h.
058e5dad 9510
7ac80be9
EZ
9511 * msdos.c (XMenuAddPane): 3rd argument is `const char *' now.
9512 Adapt all references accordingly.
9513
9514 * msdos.h (XMenuAddPane): 3rd argument is `const char *' now.
9515
ef1fd07e
TT
95162011-03-11 Tom Tromey <tromey@redhat.com>
9517
9518 * buffer.c (syms_of_buffer): Remove obsolete comment.
9519
7ef4b50c
EZ
95202011-03-11 Eli Zaretskii <eliz@gnu.org>
9521
9522 * termhooks.h (encode_terminal_code): Declare prototype.
9523
9524 * msdos.c (encode_terminal_code): Don't declare prototype.
9525
9526 * term.c (encode_terminal_code): Now external again, used by
9527 w32console.c and msdos.c.
9528
44f230aa
SM
9529 * makefile.w32-in ($(BLD)/term.$(O), ($(BLD)/tparam.$(O)):
9530 Depend on $(SRC)/tparam.h, see 2011-03-11T07:24:21Z!eggert@cs.ucla.edu.
7ef4b50c 9531
4b1ec863 95322011-03-11 Paul Eggert <eggert@cs.ucla.edu>
f78faa98 9533
1714f52b 9534 Fix some minor problems found by GCC 4.5.2's static checks.
83316bf4 9535
4b1ec863
PE
9536 * fringe.c (update_window_fringes): Mark locals as initialized
9537 (Bug#8227).
9538 (destroy_fringe_bitmap, init_fringe_bitmap): Now static.
bf60f616 9539
524c7aa6
PE
9540 * alloc.c (mark_fringe_data): Move decl from here ...
9541 * lisp.h (mark_fringe_data) [HAVE_WINDOW_SYSTEM]: ... to here,
9542 to check its interface.
9543 (init_fringe_once): Do not declare unless HAVE_WINDOW_SYSTEM.
9544
a5c0af81 9545 * fontset.c (free_realized_fontset): Now static.
7519b8cd 9546 (Fset_fontset_font): Rename local to avoid shadowing.
cc6e5db1 9547 (fontset_font): Mark local as initialized.
a9a06e0b 9548 (FONTSET_SPEC, FONTSET_REPERTORY, RFONT_DEF_REPERTORY): Remove; unused.
a5c0af81 9549
b4716021
PE
9550 * xrdb.c: Include "xterm.h", to check x_load_resources's interface.
9551
811e9bac 9552 * xselect.c (x_disown_buffer_selections): Remove; not used.
7b83e2f1 9553 (TRACE3) [!defined TRACE_SELECTION]: Remove; not used.
aa0daa9f
PE
9554 (x_own_selection, Fx_disown_selection_internal): Rename locals
9555 to avoid shadowing.
9556 (x_handle_dnd_message): Remove local to avoid shadowing.
811e9bac 9557
7e3ab302
PE
9558 * lisp.h (GCPRO1_VAR, UNGCPRO_VAR): New macros,
9559 so that the caller can use some name other than gcpro1.
9560 (GCPRO1, UNGCPRO): Reimplement in terms of the new macros.
58d2d479
PE
9561 * xfns.c (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9562 (Fx_backspace_delete_keys_p):
9563 Use them to avoid shadowing, and rename vars to avoid shadowing.
9564 (x_decode_color, x_set_name, x_window): Now static.
6b437900 9565 (Fx_create_frame): Add braces to silence GCC warning.
c0951e53 9566 (Fx_file_dialog, Fx_select_font): Fix pointer signedness.
06b0c8a0
PE
9567 (x_real_positions, xg_set_icon_from_xpm_data, x_create_tip_frame):
9568 Remove unused locals.
7e3ab302
PE
9569 (Fx_create_frame, x_create_tip_frame, Fx_show_tip):
9570 (Fx_backspace_delete_keys_p): Rename locals to avoid shadowing.
9571 Some of these renamings use the new GCPRO1_VAR and UNGCPRO_VAR
9572 macros.
f78faa98 9573
e2b13473
PE
9574 * xterm.h (x_mouse_leave): New decl.
9575
77f23912
PE
9576 * xterm.c (x_copy_dpy_color, x_focus_on_frame, x_unfocus_frame):
9577 Remove unused functions.
cdf4ba58
PE
9578 (x_shift_glyphs_for_insert, XTflash, XTring_bell):
9579 (x_calc_absolute_position): Now static.
7411c686 9580 (XTread_socket): Don't define label "out" unless it's used.
2b07bcff 9581 Don't declare local "event" unless it's used.
ed7bf3a5
PE
9582 (x_iconify_frame, x_free_frame_resources): Don't declare locals
9583 unless they are used.
38d0b34a
PE
9584 (XEMBED_VERSION, xembed_set_info): Don't define unless needed.
9585 (x_fatal_error_signal): Remove; not used.
a6067996
PE
9586 (x_draw_image_foreground, redo_mouse_highlight, XTmouse_position):
9587 (x_scroll_bar_report_motion, handle_one_xevent, x_draw_bar_cursor):
9588 (x_error_catcher, x_connection_closed, x_error_handler):
9589 (x_error_quitter, xembed_send_message, x_iconify_frame):
9590 (my_log_handler): Rename locals to avoid shadowing.
28f1c698 9591 (x_delete_glyphs, x_ins_del_lines): Mark with NO_RETURN.
2a8fade0 9592 (x_connection_closed): Tell GCC not to suggest NO_RETURN.
77f23912 9593
44f230aa
SM
9594 * xfaces.c (clear_face_cache, Fx_list_fonts, Fface_font):
9595 Rename or move locals to avoid shadowing.
6b463e58 9596 (tty_defined_color, merge_face_heights): Now static.
5967d051 9597 (free_realized_faces_for_fontset): Remove; not used.
1e9966ea
PE
9598 (Fx_list_fonts): Mark variable that gcc -Wuninitialized
9599 does not deduce is never used uninitialized.
73719eba
PE
9600 (STRDUPA, LSTRDUPA, FONT_POINT_SIZE_QUANTUM): Remove; not used.
9601 (LFACEP): Define only if XASSERTS, as it's not needed otherwise.
071048a3 9602
426994c3 9603 * terminal.c (store_terminal_param): Now static.
5489860b 9604
032f1620 9605 * xmenu.c (menu_highlight_callback): Now static.
9d66f88e 9606 (set_frame_menubar): Remove unused local.
d4323972 9607 (xmenu_show): Rename parameter to avoid shadowing.
6d1f7fee
PE
9608 (xmenu_show, xdialog_show, xmenu_show): Make local pointers "const"
9609 since they might point to immutable storage.
281585b0
PE
9610 (next_menubar_widget_id): Declare only if USE_X_TOOLKIT,
9611 since it's unused otherwise.
032f1620 9612
367c19e5 9613 * xdisp.c (produce_glyphless_glyph): Initialize lower_xoff.
53df7c11 9614 Add a FIXME, since the code still doesn't look right. (Bug#8215)
9f36b9fd
PE
9615 (Fcurrent_bidi_paragraph_direction): Simplify slightly; this
9616 avoids a gcc -Wuninitialized diagnostic.
0e086e8f 9617 (display_line, BUILD_COMPOSITE_GLYPH_STRING, draw_glyphs):
44a3a108
PE
9618 (note_mouse_highlight): Mark variables that gcc -Wuninitialized
9619 does not deduce are never used uninitialized.
70739cbe 9620
07b48fa9
PE
9621 * lisp.h (IF_LINT): New macro, copied from ../lib-src/emacsclient.c.
9622
8868a238 9623 * xdisp.c (redisplay_window): Rename local to avoid shadowing.
4554d213
PE
9624 * window.c (window_loop, size_window):
9625 (run_window_configuration_change_hook, enlarge_window): Likewise.
8868a238 9626
7e5cf297 9627 * window.c (display_buffer): Now static.
d6550a9f
PE
9628 (size_window): Mark variables that gcc -Wuninitialized
9629 does not deduce are never used uninitialized.
a586633d
PE
9630 * window.h (check_all_windows): New decl, to forestall
9631 gcc -Wmissing-prototypes diagnostic.
5b555da1 9632 * dispextern.h (bidi_dump_cached_states): Likewise.
7e5cf297 9633
f6095868
PE
9634 * charset.h (CHECK_CHARSET_GET_CHARSET): Rename locals to avoid
9635 shadowing.
9636 * charset.c (map_charset_for_dump, Fchar_charset): Likewise.
726929c4
PE
9637 Include <limits.h>.
9638 (Fsort_charsets): Redo min/max calculation to shorten the code a bit
9639 and to avoid gcc -Wuninitialized warning.
89ef49df
PE
9640 (load_charset_map): Mark variables that gcc -Wuninitialized
9641 does not deduce are never used uninitialized.
53df7c11 9642 (load_charset): Abort instead of using uninitialized var (Bug#8229).
f6095868 9643
f38b440c
PE
9644 * coding.c (coding_set_source, coding_set_destination):
9645 Use "else { /* comment */ }" rather than "else /* comment */;"
9646 for clarity, and to avoid gcc -Wempty-body warning.
2735d060
PE
9647 (Fdefine_coding_system_internal): Don't redeclare 'i' inside
9648 a block, when the outer 'i' will do.
9649 (decode_coding_utf_8, decode_coding_utf_16, detect_coding_emacs_mule):
9650 (emacs_mule_char, decode_coding_emacs_mule, detect_coding_iso_2022):
9651 (decode_coding_iso_2022, decode_coding_sjis, decode_coding_big5):
9652 (decode_coding_raw_text, decode_coding_charset, get_translation_table):
9653 (Fdecode_sjis_char, Fdefine_coding_system_internal):
9654 Rename locals to avoid shadowing.
9655 * character.h (FETCH_STRING_CHAR_ADVANCE): Likewise.
e2f1bab9
PE
9656 * coding.c (emacs_mule_char, encode_invocation_designation):
9657 Now static, since they're not used elsewhere.
413bb2db 9658 (decode_coding_iso_2022): Add "default: abort ();" as a safety check.
c4a63b12 9659 (decode_coding_object, encode_coding_object, detect_coding_system):
ee05f961
PE
9660 (decode_coding_emacs_mule): Mark variables that gcc
9661 -Wuninitialized does not deduce are never used uninitialized.
160b01f6
PE
9662 (detect_coding_iso_2022): Initialize a local variable that might
9663 be used uninitialized. Leave a FIXME because it's not clear that
53df7c11 9664 this initialization is needed. (Bug#8211)
5f58e762
PE
9665 (ISO_CODE_LF, ISO_CODE_CR, CODING_ISO_FLAG_EUC_TW_SHIFT):
9666 (ONE_MORE_BYTE_NO_CHECK, UTF_BOM, UTF_16_INVALID_P):
9667 (SHIFT_OUT_OK, ENCODE_CONTROL_SEQUENCE_INTRODUCER):
9668 (ENCODE_DIRECTION_R2L, ENCODE_DIRECTION_L2R):
9669 Remove unused macros.
f38b440c 9670
232b38b9 9671 * category.c (hash_get_category_set): Remove unused local var.
9f3b5e69 9672 (copy_category_table): Now static, since it's not used elsewhere.
d0891610 9673 * character.c (string_count_byte8): Likewise.
232b38b9 9674
fb90da1b
PE
9675 * ccl.c (CCL_WRITE_STRING, CCL_ENCODE_CHAR, Fccl_execute_on_string):
9676 (Fregister_code_conversion_map): Rename locals to avoid shadowing.
9677
fb93dbc2
PE
9678 * chartab.c (copy_sub_char_table): Now static, since it's not used
9679 elsewhere.
5c156ace
PE
9680 (sub_char_table_ref_and_range, char_table_ref_and_range):
9681 Rename locals to avoid shadowing.
bbcd0949 9682 (ASET_RANGE, GET_SUB_CHAR_TABLE): Remove unused macros.
fb93dbc2 9683
7d3b3862 9684 * bidi.c (bidi_check_type): Now static, since it's not used elsewhere.
630d6892 9685 (BIDI_BOB): Remove unused macro.
7d3b3862 9686
6be7d3da
PE
9687 * cm.c (cmgoto): Mark variables that gcc -Wuninitialized does not
9688 deduce are never used uninitialized.
c2ed9c8b 9689 * term.c (encode_terminal_code): Likewise.
6be7d3da 9690
75f8807f 9691 * term.c (encode_terminal_code): Now static. Remove unused local.
72abad34 9692
50938595
PE
9693 * tparam.h: New file.
9694 * term.c, tparam.h: Include it.
9695 * deps.mk (term.o, tparam.o): Depend on tparam.h.
9696 * term.c (tputs, tgetent, tgetflag, tgetnum, tparam, tgetstr):
9697 Move these decls to tparam.h, and make them agree with what
9698 is actually in tparam.c. The previous trick of using incompatible
9699 decls in different modules does not conform to the C standard.
9700 All callers of tparam changed to use tparam's actual API.
9701 * tparam.c (tparam1, tparam, tgoto):
9702 Use const pointers where appropriate.
9703
fbceeba2
PE
9704 * cm.c (calccost, cmgoto): Use const pointers where appropriate.
9705 * cm.h (struct cm): Likewise.
9706 * dispextern.h (do_line_insertion_deletion_costs): Likewise.
9707 * scroll.c (ins_del_costs, do_line_insertion_deletion_costs): Likewise.
9708 * term.c (tty_ins_del_lines, calculate_costs, struct fkey_table):
9709 (term_get_fkeys_1, append_glyphless_glyph, produce_glyphless_glyph):
9710 (turn_on_face, init_tty): Likewise.
9711 * termchar.h (struct tty_display_info): Likewise.
fbceeba2 9712
7f3f1250
PE
9713 * term.c (term_mouse_position): Rename local to avoid shadowing.
9714
e6ca6543
PE
9715 * alloc.c (mark_ttys): Move decl from here ...
9716 * lisp.h (mark_ttys): ... to here, so that it's checked against defn.
9717
c40f8d15
AS
97182011-03-11 Andreas Schwab <schwab@linux-m68k.org>
9719
9720 * .gdbinit (pwinx, xbuffer): Fix access to buffer name.
9721
cfe0661d
JB
97222011-03-09 Juanma Barranquero <lekktu@gmail.com>
9723
9724 * search.c (compile_pattern_1): Remove argument regp, unused since
9725 revid:rms@gnu.org-19941211082627-3x1g1wyqkjmwloig.
9726 (compile_pattern): Don't pass it.
9727
0afb4571
J
97282011-03-08 Jan Djärv <jan.h.d@swipnet.se>
9729
9730 * xterm.h (DEFAULT_GDK_DISPLAY): New define.
9731 (GDK_WINDOW_XID, gtk_widget_get_preferred_size): New defines
9732 for ! HAVE_GTK3.
9733 (GTK_WIDGET_TO_X_WIN): Use GDK_WINDOW_XID.
9734
9735 * xmenu.c (menu_position_func): Call gtk_widget_get_preferred_size.
9736
9737 * gtkutil.c: Include gtkx.h if HAVE_GTK3. If ! HAVE_GTK3, define
9738 gdk_window_get_screen, gdk_window_get_geometry,
9739 gdk_x11_window_lookup_for_display and GDK_KEY_g.
9740 (xg_set_screen): Use DEFAULT_GDK_DISPLAY.
9741 (xg_get_pixbuf_from_pixmap): New function.
9742 (xg_get_pixbuf_from_pix_and_mask): Change parameters from GdkPixmap
9743 to Pixmap, take frame as parameter, remove GdkColormap parameter.
9744 Call xg_get_pixbuf_from_pixmap instead of
9745 gdk_pixbuf_get_from_drawable.
9746 (xg_get_image_for_pixmap): Do not make GdkPixmaps, call
9747 xg_get_pixbuf_from_pix_and_mask with Pixmap parameters instead.
9748 (xg_check_special_colors): Use GtkStyleContext and its functions
9749 for HAVE_GTK3.
9750 (xg_prepare_tooltip, xg_hide_tooltip): Call gdk_window_get_screen.
9751 (xg_prepare_tooltip, create_dialog, menubar_map_cb)
9752 (xg_update_frame_menubar, xg_tool_bar_detach_callback)
44f230aa
SM
9753 (xg_tool_bar_attach_callback, xg_update_tool_bar_sizes):
9754 Call gtk_widget_get_preferred_size.
0afb4571
J
9755 (xg_frame_resized): gdk_window_get_geometry only takes 5
9756 parameters.
44f230aa
SM
9757 (xg_win_to_widget, xg_event_is_for_menubar):
9758 Call gdk_x11_window_lookup_for_display.
0afb4571
J
9759 (xg_set_widget_bg): New function.
9760 (delete_cb): New function.
895009e1 9761 (xg_create_frame_widgets): Connect delete-event to delete_cb.
5c32d3f2 9762 Call xg_set_widget_bg. Only set background pixmap for ! HAVE_GTK3
0afb4571
J
9763 (xg_set_background_color): Call xg_set_widget_bg.
9764 (xg_set_frame_icon): Call xg_get_pixbuf_from_pix_and_mask.
9765 (xg_create_scroll_bar): vadj is a GtkAdjustment for HAVE_GTK3.
9766 Only call gtk_range_set_update_policy if ! HAVE_GTK3.
9767 (xg_make_tool_item): Only connect xg_tool_bar_item_expose_callback
9768 if ! HAVE_GTK3.
9769 (update_frame_tool_bar): Call gtk_widget_hide.
9770 (xg_initialize): Use GDK_KEY_g.
9771
9772 * xsmfns.c (gdk_set_sm_client_id): Define to gdk_set_sm_client_id
9773 if ! HAVE_GTK3
9774 (x_session_initialize): Call gdk_x11_set_sm_client_id.
9775
9776 * xterm.c (XFillRectangle): Use cairo routines for HAVE_GTK3.
9777 (x_term_init): Disable Xinput(2) with GDK_CORE_DEVICE_EVENTS.
9778 Load ~/emacs.d/gtkrc only for ! HAVE_GTK3.
9779
1c2cc4ef
JB
97802011-03-08 Juanma Barranquero <lekktu@gmail.com>
9781
9782 * w32xfns.c (select_palette): Check success of RealizePalette against
9783 GDI_ERROR, not zero.
9784
33383987 9785See ChangeLog.11 for earlier changes.
aac0c6e3
MR
9786
9787;; Local Variables:
9788;; coding: utf-8
aac0c6e3
MR
9789;; End:
9790
acaf905b 9791 Copyright (C) 2011-2012 Free Software Foundation, Inc.
aac0c6e3
MR
9792
9793 This file is part of GNU Emacs.
9794
9795 GNU Emacs is free software: you can redistribute it and/or modify
9796 it under the terms of the GNU General Public License as published by
9797 the Free Software Foundation, either version 3 of the License, or
9798 (at your option) any later version.
9799
9800 GNU Emacs is distributed in the hope that it will be useful,
9801 but WITHOUT ANY WARRANTY; without even the implied warranty of
9802 MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
9803 GNU General Public License for more details.
9804
9805 You should have received a copy of the GNU General Public License
9806 along with GNU Emacs. If not, see <http://www.gnu.org/licenses/>.